gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_set_exec_info_content)
   4         (tui_show_exec_info_content, tui_erase_exec_info_content)
   5         (tui_clear_exec_info_content, tui_update_exec_info): Change
   6         argument to tui_source_window_base.
   7         * tui/tui-winsource.c (tui_set_exec_info_content)
   8         (tui_show_exec_info_content, tui_erase_exec_info_content)
   9         (tui_clear_exec_info_content, tui_update_exec_info): Change
  10         argument to tui_source_window_base.
  11
  12 2019-06-25  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
  15         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
  16
  17 2019-06-25  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
  20         check.
  21
  22 2019-06-25  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
  25         type to void.
  26         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
  27         type to void.
  28         * tui/tui-source.c (tui_set_source_content): Update.
  29         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  30
  31 2019-06-25  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-win.c (window_name_completer, tui_set_focus)
  34         (tui_all_windows_info): Use name method.
  35         * tui/tui-data.h (struct tui_gen_win_info)
  36         (struct tui_source_window, struct tui_disasm_window)
  37         (struct tui_data_window, struct tui_cmd_window) <name>: New
  38         method.
  39         (tui_win_name): Don't declare.
  40         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
  41         (tui_win_name): Remove.
  42
  43 2019-06-25  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-winsource.h (tui_update_source_window)
  46         (tui_update_source_window_as_is): Change parameter type.
  47         * tui/tui-winsource.c (tui_update_source_window): Change win_info
  48         to be a tui_source_window_base.
  49         (tui_update_source_window_as_is): Likewise.
  50         * tui/tui-win.c (make_visible_with_new_height): Update.
  51
  52 2019-06-25  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-winsource.c (tui_erase_source_content)
  55         (tui_show_source_content, tui_show_exec_info_content)
  56         (tui_erase_exec_info_content): Use refresh_window method.
  57         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
  58         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
  59         from tui_refresh_win.
  60         (tui_data_window::refresh_window): New method.
  61         (tui_win_info::refresh, tui_source_window_base::refresh)
  62         (tui_refresh_all): Use refresh_window method.
  63         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
  64         method.
  65         * tui/tui-regs.c (tui_display_register): Call refresh_window
  66         method.
  67         * tui/tui-layout.c (show_source_disasm_command)
  68         (show_source_or_disasm_and_command): Call refresh_window method.
  69         * tui/tui-data.h (struct tui_gen_win_info)
  70         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
  71         New method.
  72
  73 2019-06-25  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui.c (tui_rl_other_window, tui_enable)
  76         (tui_is_window_visible, tui_get_command_dimension): Update.
  77         * tui/tui-winsource.c (tui_update_source_window_as_is)
  78         (tui_clear_source_content, tui_erase_source_content)
  79         (tui_show_source_line, tui_source_window_base::refill)
  80         (tui_source_window_base::do_scroll_horizontal)
  81         (tui_source_window_base::set_is_exec_point_at)
  82         (tui_update_breakpoint_info, tui_set_exec_info_content)
  83         (tui_alloc_source_buffer, tui_line_is_displayed)
  84         (tui_addr_is_displayed): Update.
  85         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  86         (tui_check_and_display_highlight_if_needed)
  87         (tui_win_info::make_visible, tui_win_info::refresh)
  88         (tui_refresh_all): Update.
  89         * tui/tui-windata.c (tui_first_data_item_displayed)
  90         (tui_delete_data_content_windows, tui_erase_data_content)
  91         (tui_display_all_data, tui_data_window::refresh_all)
  92         (tui_check_data_values): Update.
  93         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
  94         (tui_set_win_focus_to, tui_win_info::forward_scroll)
  95         (tui_win_info::backward_scroll, tui_refresh_all_win)
  96         (tui_resize_all, tui_set_focus, tui_all_windows_info)
  97         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
  98         (tui_source_window_base::set_new_height)
  99         (tui_data_window::set_new_height)
 100         (make_invisible_and_set_new_height)
 101         (make_visible_with_new_height, new_height_ok)
 102         (parse_scrolling_args): Update.
 103         * tui/tui-stack.c (tui_show_frame_info): Update.
 104         * tui/tui-source.c (tui_set_source_content)
 105         (tui_set_source_content_nil, tui_source_is_displayed)
 106         (tui_source_window::do_scroll_vertical): Update.
 107         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 108         (tui_display_registers_from, tui_display_reg_element_at_line)
 109         (tui_check_register_values, tui_reg_command): Update.
 110         * tui/tui-layout.c (tui_default_win_height)
 111         (show_source_disasm_command, show_data, init_and_make_win)
 112         (show_source_or_disasm_and_command): Update.
 113         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 114         (tui_redisplay_readline, tui_mld_flush)
 115         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 116         (tui_getc): Update.
 117         * tui/tui-disasm.c (tui_set_disassem_content)
 118         (tui_disasm_window::do_scroll_vertical): Update.
 119         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 120         Now virtual.
 121         (struct tui_win_info): Derive from tui_gen_win_info.
 122         <~tui_win_info>: Mark as override.
 123         <generic>: Remove member.
 124         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 125         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 126         (~tui_data_window, ~tui_win_info)
 127         (tui_free_all_source_wins_content): Update.
 128         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 129
 130 2019-06-25  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-layout.c (init_and_make_win): Use new.
 133         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 134         destructor, initializers.
 135         (tui_alloc_generic_win_info): Don't declare.
 136         * tui/tui-data.c (_locator): Add argument to constructor.
 137         (source_win, disasm_win): New globals.
 138         (exec_info): Remove.
 139         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 140         Update.
 141         (tui_alloc_generic_win_info): Remove.
 142         (init_content_element): Use new.
 143         (tui_win_info::tui_win_info): Update.
 144         (free_content_elements) <case DATA_WIN>: Use delete.
 145
 146 2019-06-25  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 149         * tui/tui-windata.c (tui_first_data_item_displayed)
 150         (tui_delete_data_content_windows): Update.
 151         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 152         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 153         (tui_display_registers_from, tui_check_register_values): Update.
 154         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 155         pointer.
 156         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 157         window.
 158         (tui_free_data_content): Update.
 159         (free_content_elements) <case DATA_WIN>: Free the window.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 164         Update.
 165         * tui/tui-layout.c (make_command_window)
 166         (show_source_disasm_command, show_data, init_and_make_win)
 167         (show_source_or_disasm_and_command): Update.
 168         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 169         method.
 170         <can_highight, is_highlighted>: Now bool.
 171         (tui_set_win_highlight): Don't declare.
 172         * tui/tui-data.c (tui_set_win_highlight): Remove.
 173
 174 2019-06-25  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-wingeneral.c (make_visible): Remove check of window
 177         type.
 178
 179 2019-06-25  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-win.c (tui_win_info::max_height)
 182         (tui_cmd_window::max_height): New methods.
 183         (new_height_ok): Call max_height.
 184         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 185         <max_height>: New method.
 186
 187 2019-06-25  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-win.c (tui_source_window_base::set_new_height)
 190         (tui_data_window::set_new_height): New methods.
 191         (make_invisible_and_set_new_height): Call set_new_height method.
 192         * tui/tui-data.h (struct tui_win_info)
 193         (struct tui_source_window_base, struct tui_data_window)
 194         <set_new_height>: New method.
 195
 196 2019-06-25  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 199         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 200         tui_refresh_data_win.
 201         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 202         method.
 203         (tui_refresh_all_win): Call the refresh_all method.
 204         (tui_set_focus): Likewise.
 205         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 206         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 207         Likewise.
 208
 209 2019-06-25  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-winsource.h (tui_refill_source_window)
 212         (tui_set_is_exec_point_at): Don't declare.
 213         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 214         (tui_source_window_base::refill): Rename from
 215         tui_refill_source_window.
 216         (tui_source_window_base::do_scroll_horizontal): Update.
 217         (tui_source_window_base::set_is_exec_point_at): Rename from
 218         tui_set_is_exec_point_at.
 219         (tui_update_all_breakpoint_info): Update.
 220         * tui/tui-stack.c (tui_show_frame_info): Update.
 221         * tui/tui-layout.c (show_data): Add cast.
 222         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 223         * tui/tui-data.h (struct tui_source_window_base) <refill,
 224         set_is_exec_point_at>: New methods.
 225         (tui_source_windows, tui_add_to_source_windows): Update types.
 226         (tui_add_to_source_windows): Remove redundant declaration.
 227         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 228         (tui_source_windows): Change return type.
 229         (tui_clear_source_windows_detail): Update.
 230         (tui_add_to_source_windows): Change type of parameter.
 231         (tui_free_all_source_wins_content): Update.
 232
 233 2019-06-25  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-wingeneral.c (tui_win_info::refresh)
 236         (tui_source_window_base::refresh): New methods.
 237         (tui_refresh_all): Call the refresh method.
 238         * tui/tui-data.h (struct tui_win_info)
 239         (struct tui_source_window_base) <refresh>: New method.
 240
 241 2019-06-25  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui.h (tui_is_window_visible): Return bool.
 244         * tui/tui.c (tui_is_window_visible): Return bool.
 245         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 246         (tui_make_visible, tui_make_invisible)
 247         (tui_win_info::make_visible)
 248         (tui_source_window_base::make_visible, make_all_visible)
 249         (tui_make_all_visible, tui_make_all_invisible): Update.
 250         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 251         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 252         bool.
 253         (struct tui_win_info, struct tui_source_window_base)
 254         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 255         * tui/tui-data.c (tui_init_generic_part): Update.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 260         (tui_source_window_base::make_visible): New methods.
 261         (make_all_visible): Make method call.
 262         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 263         (struct tui_source_window_base, struct tui_cmd_window): Override
 264         make_visible.
 265         (tui_win_is_source_type): Don't declare.
 266         * tui/tui-data.c (tui_win_is_source_type): Remove.
 267
 268 2019-06-25  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 271         NULL check.
 272
 273 2019-06-25  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 276         Inline constructor.  Add initializers for members.
 277         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 278         constructors; now inline in class.
 279
 280 2019-06-25  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-regs.c (tui_show_registers): Update.
 283         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 284         bool.
 285         * tui/tui-data.c (tui_data_window::clear_detail)
 286         (tui_data_window): Update.
 287
 288 2019-06-25  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-windata.c (tui_display_all_data)
 291         (tui_display_data_from_line, tui_display_data_from)
 292         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 293         Update.
 294         * tui/tui-regs.c (tui_last_regs_line_no)
 295         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 296         (tui_show_registers, tui_show_register_group)
 297         (tui_display_registers_from, tui_display_reg_element_at_line)
 298         (tui_display_registers_from_line, tui_check_register_values)
 299         (tui_reg_next, tui_reg_prev): Update.
 300         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 301         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 302         tui_data_window.
 303         (struct tui_win_info) <detail>: Remove.  Add new fields from
 304         tui_data_info.
 305         (TUI_DATA_WIN): Add cast.
 306         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 307         (~tui_data_window): Simplify.
 308
 309 2019-06-25  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-layout.c (show_source_disasm_command)
 312         (show_source_or_disasm_and_command): Update.
 313         * tui/tui-io.c (update_cmdwin_start_line)
 314         (tui_redisplay_readline): Update.
 315         * tui/tui-data.h (struct tui_command_info): Remove.
 316         (struct tui_win_info) <detail>: Remove command_info member.
 317         (struct tui_data_window) <start_line>: New member, from
 318         tui_command_info.
 319         (TUI_CMD_WIN): Add casts.
 320
 321 2019-06-25  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-winsource.c (tui_update_source_window)
 324         (tui_refill_source_window)
 325         (tui_source_window_base::do_scroll_horizontal)
 326         (tui_update_breakpoint_info, tui_set_exec_info_content)
 327         (tui_show_exec_info_content, tui_erase_exec_info_content)
 328         (tui_clear_exec_info_content): Update.
 329         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 330         Update.
 331         * tui/tui-win.c (make_invisible_and_set_new_height)
 332         (make_visible_with_new_height): Update.
 333         * tui/tui-source.c (tui_set_source_content)
 334         (tui_show_symtab_source): Update.
 335         * tui/tui-layout.c (extract_display_start_addr)
 336         (show_source_disasm_command, show_data)
 337         (make_source_or_disasm_window)
 338         (show_source_or_disasm_and_command): Update.
 339         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 340         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 341         "gdbarch".
 342         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 343         to tui_source_window_base.
 344         (struct tui_win_info) <detail>: Remove source_info member.
 345         (struct tui_source_window_base) <has_locator>: Inline.
 346         Move contents from tui_source_info; rename has_locator member to
 347         m_has_locator.
 348         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 349         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 350         header file.
 351         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 352         Simplify.
 353         (tui_free_all_source_wins_content): Cast to
 354         tui_source_window_base.
 355
 356 2019-06-25  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-win.c (make_invisible_and_set_new_height)
 359         (make_visible_with_new_height): Call has_locator method.
 360         * tui/tui-layout.c (show_source_disasm_command, show_data)
 361         (show_source_or_disasm_and_command): Update for bool change.
 362         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 363         (tui_win_info) <has_locator>: New method.
 364         (struct tui_source_window_base) <has_locator>: New method.
 365         (tui_win_has_locator): Don't declare.
 366         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 367         from tui_win_has_locator.
 368         (tui_source_window_base): Use false, not FALSE.
 369
 370 2019-06-25  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 373         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 374         clear_detail method directly.
 375         (tui_clear_win_detail): Remove.
 376
 377 2019-06-25  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 380         "this", not TUI_DISASM_WIN.
 381
 382 2019-06-25  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 385         declare.
 386         * tui/tui-winsource.c
 387         (tui_source_window_base::do_scroll_horizontal): Rename from
 388         tui_horizontal_source_scroll.
 389         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 390         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 391         from tui_vertical_data_scroll.
 392         * tui/tui-win.h (tui_scroll): Don't declare.
 393         * tui/tui-win.c (tui_win_info::forward_scroll)
 394         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 395         (tui_win_info::right_scroll): Rename and update.
 396         (tui_scroll_forward_command, tui_scroll_backward_command)
 397         (tui_scroll_left_command, tui_scroll_right_command): Update.
 398         (tui_scroll): Remove.
 399         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 400         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 401         from tui_vertical_source_scroll.
 402         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 403         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 404         from tui_vertical_disassem_scroll.
 405         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 406         do_scroll_horizontal>: New methods.
 407         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 408         Likewise.
 409         (struct tui_source_window_base): Add do_scroll_horizontal.
 410         (struct tui_source_window, struct tui_disasm_window): Add
 411         do_scroll_vertical.
 412         (struct tui_data_window, struct tui_cmd_window): Add
 413         do_scroll_horizontal and do_scroll_vertical.
 414         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 415
 416 2019-06-25  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-data.h (struct tui_source_window_base): New struct.
 419         (struct tui_source_window): Derive from tui_source_window_base.
 420         (struct tui_disasm_window): New struct.
 421         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 422         from tui_source_window::clear_detail.
 423         (tui_source_window_base): Rename from tui_source_window.
 424         (~tui_source_window_base): Rename from ~tui_source_window.
 425         (tui_alloc_win_info): Create a tui_disasm_window.
 426
 427 2019-06-25  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-data.h (struct tui_source_window)
 430         (struct tui_data_window): Declare destructors.
 431         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 432         destructors.
 433         (tui_win_info): Simplify.
 434
 435 2019-06-25  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-winsource.c (tui_display_main)
 438         (tui_update_source_windows_with_addr)
 439         (tui_update_all_breakpoint_info): Update.
 440         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 441         (new_height_ok, parse_scrolling_args): Update.
 442         * tui/tui-stack.c (tui_show_frame_info): Update.
 443         * tui/tui-data.h (struct tui_list): Remove.
 444         (tui_source_windows): Return a reference to a std::vector.
 445         * tui/tui-data.c (source_windows): Now a std::vector.
 446         (tui_source_windows): Change return type.
 447         (tui_clear_source_windows): Rewrite.
 448         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 449         (tui_free_all_source_wins_content): Rewrite.
 450
 451 2019-06-25  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 454         (struct tui_data_window, struct tui_cmd_window): Declare
 455         clear_detail method.
 456         * tui/tui-data.c (tui_source_window::clear_detail)
 457         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 458         methods.
 459         (tui_clear_win_detail): Simplify.
 460
 461 2019-06-25  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-layout.c (make_source_window, make_disasm_window)
 464         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 465         Return the new window.
 466         (show_source_disasm_command, show_data)
 467         (show_source_or_disasm_and_command): Update.
 468
 469 2019-06-25  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 472         parameter.  Return the new window.
 473         (show_source_disasm_command): Update and remove NULL check.
 474         (show_source_or_disasm_and_command): Update.
 475
 476 2019-06-25  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 479
 480 2019-06-25  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-data.h (struct tui_win_info): Make constructor
 483         protected.  Make destructor virtual.  Add initializers.
 484         (tui_source_window, tui_data_window, tui_cmd_window): New
 485         classes.
 486         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 487         constructor.  Add "type" parameter.
 488         (tui_source_window, tui_data_window, tui_cmd_window): New
 489         constructors.
 490         (tui_alloc_win_info): Instantiate the appropriate subclass.
 491
 492 2019-06-25  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-win.c (tui_resize_all): Use delete.
 495         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 496         destructor.
 497         (tui_free_window): Don't declare.
 498         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 499         Update.
 500
 501 2019-06-25  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-data.h (struct tui_win_info): Add constructor.
 504         * tui/tui-data.c (tui_alloc_win_info): Use new.
 505         (tui_free_window): Use delete.
 506
 507 2019-06-22  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 510         declare.
 511         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 512
 513 2019-06-22  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 516         declare.
 517         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 518
 519 2019-06-22  Tom de Vries  <tdevries@suse.de>
 520
 521         * dwarf2read.c (create_addrmap_from_aranges)
 522         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 523         instead of '%zu'.
 524
 525 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 526
 527         * dwarf2read.h (dwarf2_section_info_def): Remove.
 528         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 529         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 530         std::vector<dwarf2_section_info>.
 531         (struct dwo_file) <~dwo_file>: Remove.
 532         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 533         types field.
 534         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 535         (dwarf2_read_debug_names): Likewise.
 536         (create_debug_types_hash_table): Change parameter type to
 537         array_view, adjust code accordingly.
 538         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 539         (partial_die_info::fixup): Likewise.
 540         (determine_prefix): Likewise.
 541         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 542
 543 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 544
 545         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 546         gdb_bfd_ref_ptr.
 547         <~dwo_file>: Remove call to gdb_bfd_unref.
 548         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 549         gdb_bfd_ref_ptr::get.
 550
 551 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 552
 553         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 554         type to htab_up.
 555         * dwarf2read.c (struct dwo_file): Initialize fields.
 556         <~dwo_file>: New.
 557         (free_dwo_file): Remove, move content to ~dwo_file.
 558         (struct dwo_file_deleter): Remove.
 559         (dwo_file_up>: Remove custom deleter.
 560         (free_dwo_files): Remove.
 561         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 562         dwo_files.
 563         (process_skeletonless_type_units): Call unique_ptr::get.
 564         (allocate_dwo_file_hash_table): Add deleter to created hash
 565         table.  Change return type to htab_up.
 566         (lookup_dwo_file_slot): Don't memset dwo_file, call
 567         unique_ptr::get.
 568         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 569         (create_dwo_unit_in_dwp_v2): Likewise.
 570         (open_and_init_dwo_file): Likewise.
 571         (free_dwo_file_from_slot): Remove.
 572
 573 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 574
 575         * dwarf2read.h (struct dwarf2_section_info) <readin,
 576         is_virtual>: Change type to bool.
 577         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 578         true instead of 1.
 579
 580 2019-06-19  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-data.h (tui_init_content_element): Don't declare.
 583
 584 2019-06-19  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-data.h (tui_init_win_info): Don't declare.
 587
 588 2019-06-19  Tom de Vries  <tdevries@suse.de>
 589
 590         * dwarf2read.h (abstract_to_concrete): Change type to
 591         std::unordered_map<sect_offset, std::vector<sect_offset>,
 592         gdb::hash_enum<sect_offset>>.
 593
 594 2019-06-19  Tom Tromey  <tromey@adacore.com>
 595
 596         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 597         EVAL_AVOID_SIDE_EFFECTS specially.
 598
 599 2019-06-19  Tom Tromey  <tromey@adacore.com>
 600
 601         * source-cache.c (highlighter): New global.
 602         (source_cache::get_source_lines): Create a highlighter on demand.
 603
 604 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 605
 606         * defs.h (deprecated_interactive_hook): Delete declaration.
 607         * interps.c (clear_interpreter_hooks): Remove use of
 608         deprecated_interactive_hook.
 609         * top.c (deprecated_interactive_hook): Delete definition.
 610         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 611
 612 2019-06-18  Tom de Vries  <tdevries@suse.de>
 613
 614         PR gdb/24515
 615         * dwarf2read.h (abstract_to_concrete): Change type from
 616         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 617         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 618         * dwarf2read.c (read_variable): Update.
 619         (dwarf2_fetch_die_loc_sect_off): Update.
 620
 621 2019-06-17  Tom de Vries  <tdevries@suse.de>
 622
 623         PR gdb/24617
 624         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 625         accessing parent[parent_len - 1].
 626
 627 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 628
 629         PR gdb/24364
 630         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 631         call dtrace_process_dof with NULL dof.
 632
 633 2019-06-16  Tom de Vries  <tdevries@suse.de>
 634
 635         PR gdb/24445
 636         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 637
 638 2019-06-16  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 641         (make_all_visible): Use address of member.
 642
 643 2019-06-16  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 646         (tui_free_window, free_content, free_content_elements): Remove
 647         unnecessary cast.
 648         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 649         cast.
 650         * tui/tui-regs.c (tui_show_register_group)
 651         (tui_display_registers_from, tui_display_reg_element_at_line):
 652         Remove unnecessary cast.
 653
 654 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 655
 656         * linux-nat.c (normal_mask): Delete.
 657         (_initialize_linux_nat): Don't initialise normal_mask.
 658
 659 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 660
 661         PR gdb/24445
 662         * dwarf-index-write.h (write_psymtabs_to_index): Add
 663         dwz_basename parameter.
 664         * dwarf-index-write.c (write_gdbindex): Move file writing to
 665         write_gdbindex_1.  Change return type void.
 666         (assert_file_size): Move up, remove filename parameter.
 667         (write_gdbindex_1): New function.
 668         (write_debug_names): Change return type to void, call
 669         assert_file_size.
 670         (struct index_wip_file): New struct.
 671         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 672         file logic to index_wip_file.  Write index for dwz file if
 673         needed.
 674         (save_gdb_index_command): Pass basename of dwz file, if present.
 675         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 676         build-id of dwz file, if present.
 677         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 678         (dwarf2_get_dwz_file): Likewise.
 679         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 680         (dwarf2_get_dwz_file): Likewise.
 681
 682 2019-06-16  Tom Tromey  <tom@tromey.com>
 683
 684         * coffread.c (process_coff_symbol): Use xstrdup.
 685         * value.c (create_internalvar): Use xstrdup.
 686
 687 2019-06-16  Tom Tromey  <tom@tromey.com>
 688
 689         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 690         * breakpoint.c (stopin_command, stopat_command)
 691         (until_break_command, decode_location_default): Remove unnecessary
 692         cast.
 693         * utils.c (subset_compare): Remove unnecessary cast.
 694         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 695         cast.
 696         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 697         cast.
 698         * infcmd.c (path_command): Remove unnecessary cast.
 699         * coffread.c (decode_type): Remove unnecessary cast.
 700         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 701         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 702         * tui/tui-stack.c (tui_show_locator_content)
 703         (tui_show_frame_info): Remove unnecessary cast.
 704         * tui/tui-win.c (tui_scroll_forward_command)
 705         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 706         (parse_scrolling_args): Remove unnecessary cast.
 707         * tui/tui-data.c (init_win_info, tui_del_window)
 708         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 709         (free_content_elements): Remove unnecessary cast.
 710         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 711         unnecessary cast.
 712         * tui/tui-source.c (tui_set_source_content)
 713         (tui_vertical_source_scroll): Remove unnecessary cast.
 714         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 715         cast.
 716         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 717         * tui/tui-regs.c (tui_display_registers_from)
 718         (tui_display_register): Remove unnecessary cast.
 719         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 720         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 721         (make_visible): Remove unnecessary cast.
 722         * tui/tui-winsource.c (tui_erase_source_content)
 723         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 724         unnecessary cast.
 725         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 726         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 727         * stabsread.c (read_type, read_array_type, read_range_type):
 728         Remove unnecessary cast.
 729         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 730         (parse_symbol, parse_type, upgrade_type, parse_external)
 731         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 732         unnecessary cast.
 733         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 734
 735 2019-06-16  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-data.c (tui_alloc_generic_win_info)
 738         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 739         checks.
 740
 741 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 742             Andrew Burgess  <andrew.burgess@embecosm.com>
 743
 744         * f-typeprint.c (f_print_type): Don't return early for not
 745         associated or not allocated types.
 746         (f_type_print_varspec_suffix): Add print_rank parameter and print
 747         ranks of array types in case they dangling.
 748         (f_type_print_base): Add print_rank parameter.
 749
 750 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * NEWS: Mention new MI commands.
 753         * break-catch-throw.c (enum exception_event_kind): Move to
 754         breakpoint.h.
 755         (print_mention_exception_catchpoint): Output text as a single
 756         message.
 757         (catch_exception_command_1): Rename to...
 758         (catch_exception_event): ...this, make non-static, update header
 759         command, and change some parameter types.
 760         (catch_catch_command): Update for changes to
 761         catch_exception_command_1.
 762         (catch_throw_command): Likewise.
 763         (catch_rethrow_command): Likewise.
 764         * breakpoint.c (enum exception_event_kind): Delete.
 765         * breakpoint.h (enum exception_event_kind): Moved here from
 766         break-catch-throw.c.
 767         (catch_exception_event): Declare.
 768         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 769         (mi_cmd_catch_throw): New function.
 770         (mi_cmd_catch_rethrow): New function.
 771         (mi_cmd_catch_catch): New function.
 772         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 773         'catch-catch' entries.
 774         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 775         (mi_cmd_catch_rethrow): Declare.
 776         (mi_cmd_catch_catch): Declare.
 777
 778 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * annotate.c (annotate_source_line): Change return type to void,
 781         update implementation to match.
 782         * annotate.h (annotate_source_line): Change return type to void,
 783         update header comment.
 784         * stack.c (print_frame_info): Don't change what frame information
 785         is printed based on whether annotations are on or not.
 786
 787 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 790         (annotate_source): Make static.
 791         (annotate_source_line): Moved from source.c and renamed from
 792         identify_source_line.  Update the return type.
 793         * annotate.h (annotate_source): Delete declaration.
 794         (annotate_source_line): Declaration moved from source.h, and
 795         renamed from identify_source_line.  Return type updated.
 796         * source.c (identify_source_line): Moved to annotate.c and renamed
 797         to annotate_source_line.
 798         (info_line_command): Remove check of annotation_level.
 799         * source.h (identify_source_line): Move declaration to annotate.h
 800         and rename to annotate_source_line.
 801         * stack.c: Add 'annotate.h' include.
 802         (print_frame_info): Remove check of annotation_level before
 803         calling annotate_source_line.
 804
 805 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 806
 807         * source-cache.c (source_cache::get_plain_source_lines): Use
 808         open_source_file_with_line_charpos instead of just
 809         open_source_file, remove call to find_source_lines.
 810         (source_cache::get_source_lines): Likewise.
 811         * source.c (find_source_lines): Make static.
 812         (get_filename_and_charpos): Renamed into...
 813         (open_source_file_with_line_charpos): ..this along with changes to
 814         return a scoped_fd, and some other minor clean ups.
 815         (identify_source_line): Use open_source_file_with_line_charpos.
 816         (search_command_helper): Use open_source_file_with_line_charpos
 817         instead of just open_source_file, remove call to
 818         find_source_lines.
 819         * source.h (open_source_file_with_line_charpos): Declare new
 820         function.
 821         (find_source_lines): Delete declaration.
 822
 823 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * source.c (get_filename_and_charpos): Remove fullname
 826         parameter.
 827         (identify_source_line): Update call to get_filename_and_charpos.
 828
 829 2019-06-14  Tom Tromey  <tromey@adacore.com>
 830
 831         PR gdb/24502:
 832         * ui-style.h (skip_ansi_escape): Update comment.
 833         * ui-file.h (class no_terminal_escape_file): New class.
 834         * ui-file.c (no_terminal_escape_file::write)
 835         (no_terminal_escape_file::puts): New methods.
 836         * cli/cli-logging.c (handle_redirections): Use
 837         no_terminal_escape_file.
 838
 839 2019-06-14  Tom Tromey  <tromey@adacore.com>
 840
 841         * NEWS: Move convenience variable news above Python news.
 842
 843 2019-06-14  Tom Tromey  <tom@tromey.com>
 844
 845         * gnulib: Move directory to top-level.
 846         * configure.ac: Don't configure gnulib.
 847         * configure: Rebuild.
 848         * common/common-defs.h: Use new path to gnulib.
 849         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 850         (GNULIB_H): Remove.
 851         (INCGNU): Look in new gnulib location.
 852         (HFILES_NO_SRCDIR): Remove gnulib files.
 853         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 854         (generated_files): Remove GNULIB_H.
 855         ($(LIBGNU), all-lib): Remove targets.
 856         (distclean): Don't mention GNULIB_BUILDDIR.
 857         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 858
 859 2019-06-14  Tom Tromey  <tromey@adacore.com>
 860
 861         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 862         Warn if symbol file does not provide any symbols.
 863
 864 2019-06-14  Tom Tromey  <tromey@adacore.com>
 865
 866         * source.c (find_and_open_source): Respect basenames_may_differ.
 867
 868 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * annotate.c (annotate_breakpoints_invalid): Make use of
 871         scoped_restore_terminal_state.
 872         (annotate_frames_invalid): Likewise.
 873
 874 2019-06-14  Tom Tromey  <tromey@adacore.com>
 875
 876         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 877         allow assignment to an internalvar.
 878
 879 2019-06-14  Tom Tromey  <tromey@adacore.com>
 880
 881         * ada-lex.l: Allow "_" in attribute names.
 882
 883 2019-06-14  Tom Tromey  <tromey@adacore.com>
 884
 885         PR gdb/24653:
 886         * regcache.c (registers_changed): Don't call alloca.
 887         * top.c (execute_command): Don't call alloca.
 888
 889 2019-06-13  Pedro Alves  <palves@redhat.com>
 890
 891         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 892         'expression'.  When parsing an expression, error out if there's
 893         junk after "unlimited".
 894         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 895         (do_set_command): Adjust calls to is_unlimited_literal.
 896
 897 2019-06-13  Pedro Alves  <palves@redhat.com>
 898
 899         * compile/compile.c (make_compile_options_def_group): Add braces
 900         around array_view initializer.
 901         * thread.c (make_thread_apply_all_options_def_group)
 902         (make_thread_apply_all_options_def_group): Likewise.
 903
 904 2019-06-13  Pedro Alves  <palves@redhat.com>
 905
 906         * NEWS (New commands): Mention "maint test-options
 907         require-delimiter", "maint test-options unknown-is-error", "maint
 908         test-options unknown-is-operand" and "maint show
 909         test-options-completion-result".
 910         (New command options, command completion): New section.
 911         (Completion improvements): New section.
 912         Mention that you can abbreviate "unlimited".
 913
 914 2019-06-13  Pedro Alves  <palves@redhat.com>
 915
 916         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 917         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 918         * unittests/cli-utils-selftests.c (test_parse_flags)
 919         (test_parse_flags_qcs): Delete.
 920         (test_cli_utils): Don't call deleted functions.
 921
 922 2019-06-13  Pedro Alves  <palves@redhat.com>
 923
 924         * thread.c: Include "cli/cli-option.h".
 925         (tp_array_compar_ascending): Global.
 926         (tp_array_compar): Delete function.
 927         (tp_array_compar_ascending, tp_array_compar_descending): New
 928         functions.
 929         (ascending_option_def, qcs_flag_option_def)
 930         (thr_qcs_flags_option_defs)
 931         (make_thread_apply_all_options_def_group)
 932         (make_thread_apply_options_def_group): New.
 933         (thread_apply_all_command): Use gdb::option::process_options.
 934         (thread_apply_command_completer)
 935         (thread_apply_all_command_completer): New.
 936         (thread_apply_command): Use gdb::option::process_options.
 937         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 938         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 939         to generate help text of "thread apply".  Adjust "taas"'s help.
 940         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 941         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 942
 943 2019-06-13  Pedro Alves  <palves@redhat.com>
 944
 945         * thread.c (thread_apply_command): Check for invalid TID with
 946         isdigit instead of !isalpha.
 947
 948 2019-06-13  Pedro Alves  <palves@redhat.com>
 949
 950         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 951         (validate_flags_qcs): New.
 952         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 953         (validate_flags_qcs): Declare.
 954         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 955         (make_frame_apply_options_def_group): New.
 956         (frame_apply_command_count): Process options with
 957         gdb::option::process_options.
 958         (frame_apply_completer): New.
 959         (frame_apply_level_completer, frame_apply_all_completer)
 960         (frame_apply_completer): New.
 961         (_initialize_stack): Update help of "frame apply", "frame apply
 962         level", "frame apply all" and "faas" to mention supported options
 963         and install command completers.
 964         * stack.h (frame_apply_all_completer): Declare.
 965         * thread.c: Include "stack.h".
 966         (tfaas_command): Add "--".
 967         (_initialize_thread): Update help "tfaas" to mention supported
 968         options and install command completer.
 969
 970 2019-06-13  Pedro Alves  <palves@redhat.com>
 971
 972         * completer.c (complete_nested_command_line): New.
 973         (gdb_completion_word_break_characters_throw): Add assertion.
 974         * completer.h (complete_nested_command_line): Declare.
 975
 976 2019-06-13  Pedro Alves  <palves@redhat.com>
 977
 978         * stack.c (parse_backtrace_qualifiers): New.
 979         (backtrace_command): Use it.
 980         (backtrace_command_completer): Complete on qualifiers.
 981
 982 2019-06-13  Pedro Alves  <palves@redhat.com>
 983
 984         * frame.c: Include "cli/cli-option.h.
 985         (user_set_backtrace_options): New.
 986         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 987         Delete.
 988         (get_prev_frame): Adjust.
 989         (boolean_option_def, uinteger_option_def)
 990         (set_backtrace_option_defs): New.
 991         (_initialize_frame): Adjust and use
 992         gdb::option::add_setshow_cmds_for_options to install "set
 993         backtrace past-main" and "set backtrace past-entry".
 994         * frame.h: Include "cli/cli-option.h".
 995         (struct frame_print_options): Forward declare.
 996         (print_frame_arguments_all, print_frame_arguments_scalars)
 997         (print_frame_arguments_none): Declare.
 998         (print_entry_values): Delete declaration.
 999         (struct frame_print_options, user_frame_print_options): New.
1000         (struct set_backtrace_options): New.
1001         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1002         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1003         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1004         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1005         (list_args_or_locals): Add frame_print_options parameter.
1006         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1007         * python/py-framefilter.c (enumerate_args): Pass down
1008         USER_FRAME_PRINT_OPTIONS.
1009         * stack.c: Include "cli/cli-option.h".
1010         (print_frame_arguments_all, print_frame_arguments_scalars)
1011         (print_frame_arguments_none): Declare.
1012         (print_raw_frame_arguments, print_entry_values): Delete.
1013         (user_frame_print_options): New.
1014         (boolean_option_def, enum_option_def, frame_print_option_defs):
1015         New.
1016         (struct backtrace_cmd_options): New.
1017         (bt_flag_option_def): New.
1018         (backtrace_command_option_defs): New.
1019         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1020         (print_frame_arg, read_frame_arg, print_frame_args)
1021         (print_frame_info, print_frame): Add frame_print_options parameter
1022         and use it.
1023         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1024         (backtrace_command_1): Add frame_print_options and
1025         backtrace_cmd_options parameters and use them.
1026         (make_backtrace_options_def_group): New.
1027         (backtrace_command): Process command options with
1028         gdb::option::process_options.
1029         (backtrace_command_completer): New.
1030         (_initialize_stack): Extend "backtrace"'s help to mention
1031         supported options.  Install completer for "backtrace".
1032         Install some settings commands with add_setshow_cmds_for_options.
1033
1034 2019-06-13  Pedro Alves  <palves@redhat.com>
1035
1036         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1037         and that "set/show print raw frame-arguments" are now deprecated.
1038
1039         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1040         command.
1041         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1042         * stack.c (_initialize_stack): Install "set/show print
1043         raw-frame-arguments", and deprecate "set/show print raw
1044         frame-arguments".
1045         * valprint.c (_initialize_valprint): Deprecate "set/show print
1046         raw".
1047
1048 2019-06-13  Pedro Alves  <palves@redhat.com>
1049
1050         * compile/compile.c (struct compile_options): New.
1051         (compile_flag_option_def, compile_command_option_defs)
1052         (make_compile_options_def_group): New.
1053         (compile_file_command): Handle options with
1054         gdb::option::process_options.
1055         (compile_file_command_completer): New function.
1056         (compile_code_command): Handle options with
1057         gdb::option::process_options.
1058         (compile_code_command_completer): New function.
1059         (_initialize_compiler): Install completers for "compile code" and
1060         "compile file".  Mention available options in "compile code" and
1061         "compile code"'s help.
1062         * completer.c (advance_to_completion_word): New, factored out from
1063         ...
1064         (advance_to_expression_complete_word_point): ... this.
1065         (advance_to_filename_complete_word_point): New.
1066         * completer.h (advance_to_filename_complete_word_point): New
1067         declaration.
1068
1069 2019-06-13  Pedro Alves  <palves@redhat.com>
1070
1071         * compile/compile.c: Include "cli/cli-option.h".
1072         (compile_print_value): Scope data pointer is now a
1073         value_print_options pointer; adjust.
1074         (compile_print_command): Process options.  Scope data pointer is
1075         now a value_print_options pointer; adjust.
1076         (_initialize_compile): Update "compile print"'s help to include
1077         supported options.  Install a completer for "compile print".
1078         * cp-valprint.c (show_vtblprint, show_objectprint)
1079         (show_static_field_print): Delete.
1080         (_initialize_cp_valprint): Don't install "set print
1081         static-members", "set print vtbl", "set print object" here.
1082         * printcmd.c: Include "cli/cli-option.h" and
1083         "common/gdb_optional.h".
1084         (print_command_parse_format): Rework to fill in a
1085         value_print_options instead of a format_data.
1086         (print_value): Change parameter type from format_data pointer to
1087         value_print_options reference.  Adjust.
1088         (print_command_1): Process options.  Adjust to pass down a
1089         value_print_options.
1090         (print_command_completer): New.
1091         (_initialize_printcmd): Install print_command_completer as
1092         handle_brkchars completer for the "print" command.  Update
1093         "print"'s help to include supported options.
1094         * valprint.c: Include "cli/cli-option.h".
1095         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1096         here from cp-valprint.c.
1097         (boolean_option_def, uinteger_option_def)
1098         (value_print_option_defs, make_value_print_options_def_group):
1099         New.  Use gdb::option::add_setshow_cmds_for_options to install
1100         "set print elements", "set print null-stop", "set print repeats",
1101         "set print pretty", "set print union", "set print array", "set
1102         print address", "set print symbol", "set print array-indexes".
1103         * valprint.h: Include <string> and "cli/cli-option.h".
1104         (make_value_print_options_def_group): Declare.
1105         (print_value): Change parameter type from format_data pointer to
1106         value_print_options reference.
1107         (print_command_completer): Declare.
1108
1109 2019-06-13  Pedro Alves  <palves@redhat.com>
1110
1111         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1112         (COMMON_SFILES): Add maint-test-settings.c.
1113         * cli/cli-decode.c (boolean_enums): New global, factored out from
1114         ...
1115         (add_setshow_boolean_cmd): ... here.
1116         * cli/cli-decode.h (boolean_enums): Declare.
1117         * cli/cli-option.c: New file.
1118         * cli/cli-option.h: New file.
1119         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1120         factored out from ...
1121         (parse_cli_boolean_value(const char *)): ... this.
1122         (is_unlimited_literal): Change parameter type to pointer to
1123         pointer.  Adjust and advance ARG pointer.
1124         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1125         (parse_cli_var_enum): New, factored out from ...
1126         (do_set_command): ... this.  Adjust.
1127         * cli/cli-setshow.h (parse_cli_boolean_value)
1128         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1129         (parse_cli_var_enum): Declare.
1130         * cli/cli-utils.c: Include "cli/cli-option.h".
1131         (get_ulongest): New.
1132         * cli/cli-utils.h (get_ulongest): Declare.
1133         (check_for_argument): New overloads.
1134         * maint-test-options.c: New file.
1135
1136 2019-06-13  Pedro Alves  <palves@redhat.com>
1137
1138         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1139         parse a range if "-" is at the end of the string.
1140
1141 2019-06-13  Pedro Alves  <palves@redhat.com>
1142
1143         * cli/cli-setshow.c (parse_auto_binary_operation)
1144         (parse_cli_boolean_value): Don't allow "o".
1145
1146 2019-06-13  Pedro Alves  <palves@redhat.com>
1147
1148         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1149         * NEWS: Mention maint test-settings KIND.
1150         * maint-test-settings.c: New file.
1151
1152 2019-06-13  Pedro Alves  <palves@redhat.com>
1153
1154         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1155         completer.
1156         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1157         "set" completers.
1158
1159 2019-06-13  Pedro Alves  <palves@redhat.com>
1160
1161         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1162         after item.
1163
1164 2019-06-13  Pedro Alves  <palves@redhat.com>
1165
1166         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1167
1168 2019-06-13  Pedro Alves <palves@redhat.com>
1169
1170         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1171         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1172         call.
1173         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1174         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1175         calls.
1176         (check_for_argument): Skip spaces after argument.
1177
1178 2019-06-13  Pedro Alves  <palves@redhat.com>
1179
1180         * thread.c (thread_apply_command): Adjust TID parsing.
1181         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1182         detected before end of string.
1183         (tid_is_in_list): Error out if LIST is invalid.
1184
1185 2019-06-13  Pedro Alves  <palves@redhat.com>
1186
1187         * completer.c (complete_line_internal_1): Rewind completion word
1188         point.
1189         (completion_tracker::advance_custom_word_point_by): Change
1190         parameter type to int.
1191         * completer.h (completion_tracker::advance_custom_word_point_by):
1192         Likewise.
1193
1194 2019-06-13  Pedro Alves  <palves@redhat.com>
1195
1196         * completer.c (advance_to_completion_word): Handle delimiters.
1197
1198 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1199
1200         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1201
1202 2019-06-11  Tom Tromey  <tom@tromey.com>
1203
1204         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1205         (xmalloc_failed): Move to alloc.c.
1206         * alloc.c: New file.
1207         * Makefile.in (COMMON_SFILES): Add alloc.c.
1208
1209 2019-06-11  Tom Tromey  <tom@tromey.com>
1210
1211         * nat/linux-waitpid.c: Don't include server.h.
1212         (linux_debug): Remove.
1213         (my_waitpid): Update.
1214
1215 2019-06-11  Tom Tromey  <tromey@adacore.com>
1216
1217         * infcall.c (_initialize_infcall): Remove trailing newline from
1218         help.
1219         * user-regs.c (_initialize_user_regs): Remove trailing newline
1220         from help.
1221         * typeprint.c (_initialize_typeprint): Remove trailing newline
1222         from help.
1223         * reverse.c (_initialize_reverse): Remove trailing newlines from
1224         help.
1225         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1226         from help.
1227         * language.c (add_set_language_command): Remove trailing newline
1228         from help.
1229         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1230         help.
1231         * disasm.c (_initialize_disasm): Remove trailing newline from
1232         help.
1233         * top.c (init_main): Remove trailing newline from help.
1234         * interps.c (_initialize_interpreter): Remove trailing newline
1235         from help.
1236         * btrace.c (_initialize_btrace): Remove trailing newlines from
1237         help.
1238         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1239         from help.
1240         * python/python.c (_initialize_python): Remove trailing newline
1241         from help.
1242         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1243         help.
1244         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1245         from help.  Reformat some text.
1246         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1247         from help.
1248         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1249         newline from help.
1250
1251 2019-06-11  Tom Tromey  <tromey@adacore.com>
1252
1253         * darwin-nat.c (darwin_decode_exception_message)
1254         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1255
1256 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1257
1258         * valops.c (value_slice): Check for not allocated or not
1259         associated values.
1260
1261 2019-06-10  Tom de Vries  <tdevries@suse.de>
1262
1263         PR gdb/24618
1264         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1265         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1266         invalid.
1267
1268 2019-06-10  Tom de Vries  <tdevries@suse.de>
1269
1270         PR gdb/24611
1271         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1272         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1273
1274 2019-06-10  Tom de Vries  <tdevries@suse.de>
1275
1276         PR symtab/24545
1277         * symtab.c (struct demangled_name_entry): Add language field.
1278         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1279         static minimal symbol".  Set and use language field.
1280
1281 2019-06-10  Tom Tromey  <tromey@adacore.com>
1282
1283         * ada-lang.c (_initialize_ada_language): Update help text.
1284
1285 2019-06-10  Tom Tromey  <tromey@adacore.com>
1286
1287         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1288         with a newline.
1289         * guile/guile.c (handle_boot_error): Don't end warning with a
1290         newline.
1291         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1292         warning with a newline.
1293         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1294         newline.
1295         (s12z_frame_cache): Likewise.
1296         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1297         a newline.
1298         * solib-svr4.c (disable_probes_interface): Don't end warning with
1299         a newline.
1300         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1301         newline.
1302         * python/python.c (do_finish_initialization): Don't end warning
1303         with a newline.
1304
1305 2019-06-10  Tom Tromey  <tom@tromey.com>
1306
1307         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1308         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1309         gdbpy_enter.
1310
1311 2019-06-10  Tom Tromey  <tromey@adacore.com>
1312
1313         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1314         data.
1315         (elf_new_init): Don't call stabsread_new_init.
1316         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1317         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1318         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1319
1320 2019-06-10  Tom de Vries  <tdevries@suse.de>
1321
1322         PR symtab/16264
1323         PR symtab/24517
1324         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1325
1326 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1327
1328         * source.c (find_and_open_source): Also rewrite relative file
1329         names.
1330
1331 2019-04-26  Amos Bird  <amosbird@gmail.com>
1332
1333         * annotate.c (annotate_thread_exited): Add "thread-exited"
1334         annotation.
1335
1336 2019-06-06  Tom Tromey  <tromey@adacore.com>
1337
1338         * maint.h (class scoped_command_stats): Use
1339         DISABLE_COPY_AND_ASSIGN.
1340         <print_time>: New method.
1341         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1342         print_time.
1343         (scoped_command_stats::print_time): New method.
1344
1345 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1346
1347         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1348         instructions of lengths 6 or 8 bytes.
1349
1350 2019-06-04  Pedro Alves  <palves@redhat.com>
1351
1352         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1353
1354         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1355         * breakpoint.c (condition_completer): Likewise.
1356         * cli/cli-dump.c (scan_expression): Likewise.
1357         * common/filestuff.c (mkdir_recursive): Likewise.
1358         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1359         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1360         (gdb_abspath): Likewise.
1361         * compile/compile-cplus-types.c
1362         (compile_cplus_instance::decl_name): Likewise.
1363         * completer.c (complete_explicit_location):
1364         (signal_completer, reg_or_group_completer_1): Likewise.
1365         * cp-support.c (cp_remove_params_if_any): Likewise.
1366         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1367         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1368         * infcmd.c (strip_bg_char): Likewise.
1369         * linespec.c (copy_token_string): Likewise.
1370         * mi/mi-main.c (output_cores): Likewise.
1371         * psymtab.c (psymtab_search_name):
1372         * symfile.c (test_set_ext_lang_command): Likewise.
1373         * target.c (target_fileio_read_stralloc): Likewise.
1374         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1375         * value.c (complete_internalvar): Likewise.
1376
1377 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1378
1379         Add objfile property to gdb.Type.
1380         * NEWS: Mention Python API addition.
1381         * python/py-type.c (typy_get_objfile): New method.
1382
1383 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1384
1385         * NEWS: Mention the new set|show style [title|highlight].
1386         Mention changes to "show style", "help" and "apropos".
1387
1388 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1389
1390         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1391         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1392         instead of print_help_for_command.
1393         (print_doc_of_command): New function.
1394         (help_list): Add 'apropos -v word' suggestion.
1395         (print_help_for_command): Style the command name using title style.
1396         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1397         (_initialize_cli_cmds): Describe -v in apropos_command help.
1398
1399 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1400
1401         * cli/cli-style.h (cli_style_option): Add name in constructor,
1402         add m_name class member, add constructor with intensity,
1403         add name class function.
1404         (cli_style_option::add_setshow_commands): Remove name argument.
1405         (highlight_style, title_style): New styles.
1406         * cli/cli-style.c (do_show): New function that shows a style
1407         characteristic styling the style name with itself.
1408         (set_style_name): New function.
1409         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1410         Update all callers according to the changes in cli/cli-style.h.
1411         * utils.h (fputs_highlighted): New function.
1412         * utils.c (fputs_highlighted): Likewise.
1413
1414 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1415
1416         * NEWS: Mention new pipe command and new convenience variables.
1417
1418 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1419
1420         * cli/cli-cmds.c (pipe_command): New function.
1421         (_initialize_cli_cmds): Call add_com for pipe_command.
1422         Define | as an alias for pipe.
1423         (exit_status_set_internal_vars): New function.
1424         (shell_escape): Call exit_status_set_internal_vars.
1425         cli/cli-decode.c (find_command_name_length): Recognize | as
1426         a single character command.
1427
1428 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1429
1430         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1431         top.c (execute_command_to_ui_file): New function, mostly a copy
1432         of execute_command_to_string.
1433         (execute_command_to_string): Implement by calling
1434         execute_command_to_ui_file.
1435
1436 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1437
1438         * top.h (saved_command_line): Remove declaration.
1439         * top.c (previous_saved_command_line, previous_repeat_arguments):
1440         New variables.
1441         (saved_command_line): Make static, define together with other
1442         'repeat variables'.
1443         (dont_repeat): Clear repeat_arguments.
1444         (repeat_previous, get_saved_command_line, save_command_line):
1445         New functions.
1446         (gdb_init): Initialize saved_command_line
1447         and previous_saved_command_line.
1448         * main.c (captured_main_1): Remove saved_command_line initialization.
1449         * event-top.c (handle_line_of_input): Update to use
1450         the new 'repeat' related functions instead of direct access to
1451         saved_command_line.
1452         * command.h (repeat_previous, get_saved_command_line,
1453         save_command_line): New declarations.
1454         (dont_repeat): Add comment.
1455
1456 2019-05-30  Tom Tromey  <tromey@adacore.com>
1457
1458         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1459         Fix comment.
1460         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1461
1462 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1463
1464         PR cli/24587
1465         * completer.c (complete): Initialize variable word.
1466
1467 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1468
1469         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1470         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1471         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1472         'body' is NULL to the outter 'if', protecting the '!is_define'
1473         situation as well.
1474
1475 2019-05-29  Tom Tromey  <tromey@adacore.com>
1476
1477         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1478         (dwarf_unknown): New function.
1479         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1480         (dwarf_type_encoding_name): Use dwarf_unknown.
1481
1482 2019-05-29  Tom Tromey  <tromey@adacore.com>
1483
1484         PR c++/20020:
1485         * cp-valprint.c (cp_print_value_fields): Call
1486         cp_print_static_field inside "try".
1487
1488 2019-05-29  Tom Tromey  <tromey@adacore.com>
1489
1490         * inflow.c (struct terminal_info): Add default operator=.
1491         * configure: Rebuild.
1492         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1493         -Wdeprecated-copy-dtor, -Wredundant-move.
1494
1495 2019-05-29  Tom Tromey  <tromey@adacore.com>
1496
1497         * NEWS: Add entry.
1498         * infcmd.c (print_return_value_1): Handle finish_print
1499         option.
1500         (show_print_finish): New function.
1501         (_initialize_infcmd): Add "set/show print finish" commands.
1502         * valprint.c (user_print_options): Initialize new member.
1503         * valprint.h (struct value_print_options) <finish_print>: New
1504         member.
1505
1506 2019-05-28  Tom Tromey  <tromey@adacore.com>
1507
1508         * ada-lang.c (ada_remove_Xbn_suffix)
1509         (find_old_style_renaming_symbol)
1510         (parse_old_style_renaming): Remove.
1511         (ada_find_renaming_symbol): Don't call
1512         find_old_style_renaming_symbol.
1513         (ada_is_renaming_symbol): Rename from
1514         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1515         bool.  Now static.
1516         (ada_read_var_value): Update and simplify.
1517         * ada-exp.y (write_var_or_type): Remove old code.
1518
1519 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1520
1521         * event-top.c: Remove include comment.
1522         * inflow.c (class scoped_ignore_sigttou): Move from here...
1523         * inflow.h (class scoped_ignore_sigttou): ...to here.
1524         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1525         * top.c:  Remove include comment.
1526
1527 2019-05-27  Tom Tromey  <tom@tromey.com>
1528
1529         * NEWS: Fix typo.
1530
1531 2019-05-22  Tom Tromey  <tromey@adacore.com>
1532
1533         * target.c (target_follow_exec): Constify parameter.
1534         * target-delegates.c: Rebuild.
1535         * remote.c (remote_target::follow_exec): Constify parameter.
1536         * infrun.c (follow_exec): Constify parameter.
1537         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1538         (target_follow_exec): Likewise.
1539
1540 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1543         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1544
1545 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1546
1547         * NEWS: Add debugredirect and testsuite sections.
1548
1549 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1550
1551         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1552         target descriptions using exclusively floating point register name
1553         aliases.
1554
1555 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         PR gdb/18644:
1558         * f-lang.c (build_fortran_types): Handle the case where
1559         gdbarch_floatformat_for_type returns a nullptr.
1560
1561 2019-05-21  Tom de Vries  <tdevries@suse.de>
1562
1563         PR cli/24587
1564         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1565
1566 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         PR gdb/18644:
1569         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1570         16-byte floats.
1571         * i386-tdep.c (i386_floatformat_for_type): Use
1572         floatformats_ia64_quad for the 16-byte floating point component
1573         within a fortran 32-byte complex number.
1574
1575 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1576
1577         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1578         delete default constructor.
1579         (find_partial_die): Update to return const struct.
1580         (partial_die_parent_scope): Move variable declaration into scope
1581         of its use and change its type to auto.
1582         (guess_partial_die_structure_name): Likewise.
1583         (partial_die_info::fixup): Likewise.
1584
1585 2019-05-17  Tom Tromey  <tromey@adacore.com>
1586
1587         * source.c (find_and_open_source): Remove cast.
1588
1589 2019-05-17  Tom Tromey  <tromey@adacore.com>
1590
1591         * annotate.c (annotate_source): Make "filename" const.
1592         * annotate.h (annotate_source): Use const.
1593
1594 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1595
1596         * disasm.c (set_disassembler_options): Send errors to stderr.
1597
1598 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1599
1600         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1601         (cli_interp_base::set_logging): Check debug_redirect.
1602         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1603         * cli/cli-logging.c (debug_redirect): Add static variable.
1604         (pop_output_files): Add default param.
1605         (handle_redirections): Print debug setting.
1606         (show_logging_command): Likewise.
1607         (_initialize_cli_logging): Add debugredirect command.
1608         * interps.c (current_interp_set_logging): Add debug_redirect
1609         parameter.
1610         * interps.h (set_logging): Add debug_redirect parameter.
1611         (current_interp_set_logging): Likewise.
1612         * mi/mi-common.h: Likewise.
1613         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1614
1615 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1616             Tom Tromey  <tromey@adacore.com>
1617
1618         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1619         directly.
1620         * cli/cli-interp.h (make_logging_output): Remove declaration.
1621         * cli/cli-logging.c (make_logging_output): Remove function.
1622         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1623         directly.
1624         * ui-file.c (tee_file::tee_file): Remove bools.
1625         (tee_file::~tee_file): Remove deletes.
1626         * ui-file.h (tee_file): Remove bools.
1627
1628 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1629
1630         * mi/mi-cmds.h (mi_cmd_complete): New function.
1631         * mi/mi-main.c (mi_cmd_complete): Likewise.
1632         * mi/mi-cmds.c: Define new MI command -complete.
1633         * NEWS: Mention new -complete command.
1634
1635 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1636
1637         * completer.h (complete): New function.
1638         * completer.c (complete): Likewise.
1639         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1640         function defined in completer.h.
1641
1642 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1643
1644         * MAINTAINERS (Write After Approval): Add myself.
1645
1646 2019-05-17  Tom de Vries  <tdevries@suse.de>
1647
1648         PR gdb/24094
1649         * dwarf2read.c (struct cu_partial_die_info): New struct.
1650         (find_partial_die): Return cu_partial_die_info.
1651         (partial_die_parent_scope, guess_partial_die_structure_name)
1652         (partial_die_info::fixup): Handle new return type of find_partial_die.
1653
1654 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1655
1656         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1657         "std::string", simplifying the algorithm.
1658
1659 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1660
1661         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1662         (stap_static_probe_ops::get_probes): Likewise.
1663
1664 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1665
1666         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1667         '-')" and "else if".
1668         (stap_parse_single_operand): Join checks for
1669         "gdbarch_stap_parse_special_token_p" and
1670         "gdbarch_stap_parse_special_token" in the same "if" statement.
1671         Invert check when verifying for operation on register
1672         displacement.
1673
1674 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1675
1676         * stap-probe.c (stap_get_opcode): Update comment.
1677         (stap_get_expected_argument_type): Likewise.
1678         (handle_stap_probe): Likewise.
1679
1680 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1681
1682         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1683         return type to 'bool'.  Adjust comment.  Use 'bool' when
1684         appropriate.
1685         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1686         * stap-probe.c (stap_parse_argument_1): Likewise.
1687         (stap_is_operator): Likewise.
1688         (stap_is_generic_prefix): Likewise.
1689         (stap_is_register_prefix): Likewise.
1690         (stap_is_register_indirection_prefix): Likewise.
1691         (stap_is_integer_prefix): Likewise.
1692         (stap_generic_check_suffix): Likewise.
1693         (stap_check_integer_suffix): Likewise.
1694         (stap_check_register_suffix): Likewise.
1695         (stap_check_register_indirection_suffix): Likewise.
1696         (stap_parse_register_operand): Likewise.
1697         (stap_parse_single_operand): Likewise.
1698         (stap_parse_argument_1): Likewise.
1699         (stap_probe::get_argument_count): Likewise.
1700         (stap_is_operator): Likewise.
1701
1702 2019-05-16  Tom Tromey  <tromey@adacore.com>
1703
1704         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1705         keyword to foreach.
1706
1707 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1708
1709         * linux-thread-db.c (try_thread_db_load_1): Change return type
1710         to bool.
1711         (try_thread_db_load): Likewise.
1712         (try_thread_db_load_from_pdir_1): Likewise.
1713         (try_thread_db_load_from_pdir): Likewise.
1714         (try_thread_db_load_from_sdir): Likewise.
1715         (try_thread_db_load_from_dir): Likewise.
1716         (thread_db_load_search): Likewise.
1717         (has_libpthread): Likewise.
1718         (thread_db_load): Likewise.
1719
1720 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1721
1722         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1723         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1724         NULL, and complain/return if that's the case.
1725
1726 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1727
1728         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1729         (advance, posn, abstract_read_memory): New functions.
1730         [struct mem_read_abstraction]: New struct.
1731         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1732
1733 2019-05-14  Tom Tromey  <tromey@adacore.com>
1734
1735         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1736         value is not lval_memory.
1737
1738 2019-05-14  Tom Tromey  <tromey@adacore.com>
1739
1740         * solib.c (info_sharedlibrary_command): Style the file name.
1741
1742 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1743
1744         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1745         (aarch64_vnv_type): Likewise.
1746         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1747         * common/tdesc.c: Likewise.
1748         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1749         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1750         * features/aarch64-fpu.xml: Add ieee half view.
1751         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1752         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1753         * gdbtypes.h (struct builtin_type): Likewise.
1754         (struct objfile_type): Likewise.
1755
1756 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1757
1758         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1759         typo.
1760         * location.h (string_to_event_location): Likewise.
1761
1762 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1763
1764         GDB 8.3 released.
1765
1766 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1767
1768         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1769         New variable declaration.
1770         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1771         New variable.
1772         (print_one_breakpoint): Use ui_out::test_flags and new global
1773         variable to compute use_fixed_output.
1774         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1775         Remove.
1776         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1777         (mi_multi_location_breakpoint_output_fixed): Remove.
1778         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1779         new variable.
1780         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1781         fix_multi_location_breakpoint_output flag if version >= 3.
1782         * ui-out.h (enum ui_out_flag)
1783         <fix_multi_location_breakpoint_output>: New enumerator.
1784
1785 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1786
1787         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1788
1789 2019-05-10  Tom Tromey  <tromey@adacore.com>
1790
1791         * ada-lang.c (catch_ada_completer): New function.
1792         (_initialize_ada_language): Use it.
1793
1794 2019-05-10  Tom Tromey  <tromey@adacore.com>
1795
1796         * thread.c (print_thread_info): Make "requested_threads" const.
1797         * gdbthread.h (print_thread_info): Make "requested_threads"
1798         const.
1799         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1800         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1801
1802 2019-05-08  Tom Tromey  <tom@tromey.com>
1803
1804         * gdbtypes.c (objfile_type_data): Change type.
1805         (objfile_type, _initialize_gdbtypes): Update.
1806
1807 2019-05-08  Tom Tromey  <tom@tromey.com>
1808
1809         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1810         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1811         (_initialize_dwarf2_frame): Update.
1812
1813 2019-05-08  Tom Tromey  <tom@tromey.com>
1814
1815         * objc-lang.c (objc_objfile_data): Change type.
1816         (find_methods): Update.
1817         (_initialize_objc_lang): Remove.
1818
1819 2019-05-08  Tom Tromey  <tom@tromey.com>
1820
1821         * stabsread.c (rs6000_builtin_type_data): Change type.
1822         (rs6000_builtin_type, _initialize_stabsread): Update.
1823
1824 2019-05-08  Tom Tromey  <tom@tromey.com>
1825
1826         * mips-tdep.c (mips_pdr_data): Remove.
1827         (_initialize_mips_tdep): Update.
1828
1829 2019-05-08  Tom Tromey  <tom@tromey.com>
1830
1831         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1832         (hppa_init_objfile_priv_data, read_unwind_info)
1833         (find_unwind_entry, _initialize_hppa_tdep): Update.
1834
1835 2019-05-08  Tom Tromey  <tom@tromey.com>
1836
1837         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1838         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1839         on obstack.
1840         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1841
1842 2019-05-08  Tom Tromey  <tom@tromey.com>
1843
1844         * mdebugread.c (basic_type_data): Change type.
1845         (basic_type, _initialize_mdebugread): Update.
1846
1847 2019-05-08  Tom Tromey  <tom@tromey.com>
1848
1849         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1850
1851 2019-05-08  Tom Tromey  <tom@tromey.com>
1852
1853         * nto-tdep.c (nto_inferior_data_reg): Change type.
1854         (nto_inferior_data): Update.
1855         (nto_inferior_data_cleanup, nto_new_inferior_data)
1856         (_initialize_nto_tdep): Remove.
1857         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1858
1859 2019-05-08  Tom Tromey  <tom@tromey.com>
1860
1861         * ada-lang.c (struct ada_inferior_data): Add initializers.
1862         (ada_inferior_data): Change type.
1863         (ada_inferior_data_cleanup): Remove.
1864         (get_ada_inferior_data, ada_inferior_exit)
1865         (struct ada_pspace_data): Add initializers, destructor.
1866         (ada_pspace_data_handle): Change type.
1867         (get_ada_pspace_data): Update.
1868         (ada_pspace_data_cleanup): Remove.
1869
1870 2019-05-08  Tom Tromey  <tom@tromey.com>
1871
1872         * coffread.c (struct coff_symfile_info): Add initializers.
1873         (coff_objfile_data_key): Move lower.  Change type.
1874         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1875         Update.
1876         (coff_free_info): Remove.
1877
1878 2019-05-08  Tom Tromey  <tom@tromey.com>
1879
1880         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1881         (fbsd_pspace_data_handle): Move lower.  Change type.
1882         (get_fbsd_pspace_data): Update.
1883         (fbsd_pspace_data_cleanup): Remove.
1884         (_initialize_fbsd_tdep): Update.
1885
1886 2019-05-08  Tom Tromey  <tom@tromey.com>
1887
1888         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1889         (get_ada_tasks_pspace_data): Update.
1890         (ada_tasks_pspace_data_cleanup): Remove.
1891         (_initialize_tasks): Update.
1892         (ada_tasks_inferior_data_handle): Change type.
1893         (get_ada_tasks_inferior_data): Update.
1894         (ada_tasks_inferior_data_cleanup): Remove.
1895         (struct ada_tasks_pspace_data): Add initializers.
1896
1897 2019-05-08  Tom Tromey  <tom@tromey.com>
1898
1899         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1900         * symfile-debug.c (debug_sym_get_probes): Change type.
1901         * stap-probe.c (handle_stap_probe):
1902         (stap_static_probe_ops::get_probes): Change type.
1903         * probe.h (class static_probe_ops) <get_probes>: Change type.
1904         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1905         (parse_probes_in_pspace): Update.
1906         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1907         Update.
1908         (any_static_probe_ops::get_probes): Change type.
1909         * elfread.c (elfread_data): New typedef.
1910         (probe_key): Change type.
1911         (elf_get_probes): Likewise.  Update.
1912         (probe_key_free): Remove.
1913         (_initialize_elfread): Update.
1914         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1915         Change type.
1916         (dtrace_process_dof_probe, dtrace_process_dof)
1917         (dtrace_static_probe_ops::get_probe): Change type.
1918
1919 2019-05-08  Tom Tromey  <tom@tromey.com>
1920
1921         * xcoffread.c (struct xcoff_symfile_info): Rename from
1922         coff_symfile_info.  Add initializers.
1923         (xcoff_objfile_data_key): Move lower.  Change type.
1924         (XCOFF_DATA): Rewrite.
1925         (xcoff_free_info): Remove.
1926         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1927         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1928         (xcoff_initial_scan): Update.
1929
1930 2019-05-08  Tom Tromey  <tom@tromey.com>
1931
1932         * solib-svr4.c (struct svr4_info): Add initializers and
1933         destructor.
1934         <probes_table>: Now an htab_up.
1935         (solib_svr4_pspace_data): Change type.
1936         (free_probes_table): Simplify.
1937         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1938         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1939         (probes_table_remove_objfile_probes, register_solib_event_probe)
1940         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1941         (_initialize_svr4_solib): Update.
1942
1943 2019-05-08  Tom Tromey  <tom@tromey.com>
1944
1945         * remote.c (remote_pspace_data): Change type.
1946         (remote_pspace_data_cleanup): Remove.
1947         (get_remote_exec_file, set_pspace_remote_exec_file)
1948         (_initialize_remote): Update.
1949
1950 2019-05-08  Tom Tromey  <tom@tromey.com>
1951
1952         * breakpoint.c (breakpoint_objfile_key): Change type.
1953         (get_breakpoint_objfile_data): Update.
1954         (free_breakpoint_objfile_data): Remove.
1955         (_initialize_breakpoint): Update.
1956
1957 2019-05-08  Tom Tromey  <tom@tromey.com>
1958
1959         * linux-tdep.c (struct linux_info): Add initializers.
1960         (linux_inferior_data): Move.  Change type.
1961         (invalidate_linux_cache_inf): Update.
1962         (linux_inferior_data_cleanup): Remove.
1963         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1964
1965 2019-05-08  Tom Tromey  <tom@tromey.com>
1966
1967         * auxv.c (auxv_inferior_data): Move.  Change type.
1968         (auxv_inferior_data_cleanup): Remove.
1969         (invalidate_auxv_cache_inf): Rewrite.
1970         (get_auxv_inferior_data, _initialize_auxv): Update.
1971
1972 2019-05-08  Tom Tromey  <tom@tromey.com>
1973
1974         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1975         (symfile_debug_objfile_data_key): Change type.
1976         (symfile_debug_installed, debug_qf_has_symbols)
1977         (debug_qf_find_last_source_symtab)
1978         (debug_qf_forget_cached_source_info)
1979         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1980         (debug_qf_print_stats, debug_qf_dump)
1981         (debug_qf_expand_symtabs_for_function)
1982         (debug_qf_expand_all_symtabs)
1983         (debug_qf_expand_symtabs_with_fullname)
1984         (debug_qf_map_matching_symbols)
1985         (debug_qf_expand_symtabs_matching)
1986         (debug_qf_find_pc_sect_compunit_symtab)
1987         (debug_qf_map_symbol_filenames)
1988         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1989         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1990         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1991         (debug_sym_read_linetable, debug_sym_relocate): Update.
1992         (symfile_debug_free_objfile): Remove.
1993         (install_symfile_debug_logging, _initialize_symfile_debug):
1994         Update.
1995
1996 2019-05-08  Tom Tromey  <tom@tromey.com>
1997
1998         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1999         allocate_on_obstack.
2000         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2001         (get_dwarf2_per_objfile): Update.
2002         (set_dwarf2_per_objfile): Remove.
2003         (dwarf2_has_info, dwarf2_get_section_info): Update.
2004         (dwarf2_free_objfile): Remove.
2005         (_initialize_dwarf2_read): Update.
2006
2007 2019-05-08  Tom Tromey  <tom@tromey.com>
2008
2009         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2010         initializers.
2011         <unsupported_script_warning_printed,
2012         script_not_found_warning_printed>: Now bool.
2013         (auto_load_pspace_data): Change type.
2014         (~auto_load_pspace_info): Rename from
2015         auto_load_pspace_data_cleanup.
2016         (get_auto_load_pspace_data, init_loaded_scripts_info)
2017         (clear_section_scripts, maybe_print_unsupported_script_warning)
2018         (maybe_print_script_not_found_warning, _initialize_auto_load):
2019         Update.
2020
2021 2019-05-08  Tom Tromey  <tom@tromey.com>
2022
2023         * objfiles.c (objfile_pspace_info): Add destructor and
2024         initializers.
2025         (objfiles_pspace_data): Change type.
2026         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2027         (get_objfile_pspace_data): Update.
2028         (objfiles_bfd_data): Change type.
2029         (get_objfile_bfd_data): Update.
2030         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2031
2032 2019-05-08  Tom Tromey  <tom@tromey.com>
2033
2034         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2035         Change type.
2036         (get_catch_syscall_inferior_data): Update.
2037         (catch_syscall_inferior_data_cleanup): Remove.
2038         (_initialize_break_catch_syscall): Update.
2039
2040 2019-05-08  Tom Tromey  <tom@tromey.com>
2041
2042         * inflow.c (struct terminal_info): Add destructor and
2043         initializers.
2044         (inflow_inferior_data): Change type.
2045         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2046         (get_inflow_inferior_data, inflow_inferior_exit)
2047         (swap_terminal_info, _initialize_inflow): Update.
2048
2049 2019-05-08  Tom Tromey  <tom@tromey.com>
2050
2051         * target-dcache.c (target_dcache_cleanup): Remove.
2052         (target_dcache_aspace_key): Change type.
2053         (target_dcache_init_p, target_dcache_invalidate)
2054         (target_dcache_get, target_dcache_get_or_init)
2055         (_initialize_target_dcache): Update.
2056         * dcache.h (struct dcache_deleter): New.
2057
2058 2019-05-08  Tom Tromey  <tom@tromey.com>
2059
2060         * symtab.c (struct symbol_cache): Add destructor and
2061         initializers.
2062         (symbol_cache_key): Move.  Change type.
2063         (make_symbol_cache, free_symbol_cache): Remove.
2064         (get_symbol_cache): Update.
2065         (symbol_cache_cleanup): Remove.
2066         (ALL_PSPACES, symbol_cache_flush)
2067         (maintenance_print_symbol_cache)
2068         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2069         Update.
2070
2071 2019-05-08  Tom Tromey  <tom@tromey.com>
2072
2073         * symtab.c (struct main_info): Add destructor and initializers.
2074         (main_progspace_key): Move.  Change type.
2075         (get_main_info): Update.
2076         (main_info_cleanup): Remove.
2077         (_initialize_symtab): Update.
2078
2079 2019-05-08  Tom Tromey  <tom@tromey.com>
2080
2081         * registry.h (DECLARE_REGISTRY): Define the _key class.
2082
2083 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2084
2085         * NEWS: Merge two 'New commands' sections.
2086
2087 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2088
2089         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2090         parameter and use Ada language definition instead.
2091         (ada_val_print_ptr): Remove unused language parameter.
2092         (ada_val_print_num): Remove language parameter and use Ada language
2093         definition instead.
2094         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2095         parameter.
2096         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2097         parameter and use Ada language definition instead.
2098         (ada_val_print_1): Update all ada_val_print_xxx calls.
2099         Remove language parameter.
2100         (ada_val_print): Update ada_val_print_1 call.
2101
2102 2019-05-08  Tom Tromey  <tromey@adacore.com>
2103
2104         * remote.c (remote_hw_watchpoint_limit)
2105         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2106         Now static.
2107
2108 2019-05-08  Tom Tromey  <tromey@adacore.com>
2109
2110         * maint.c (_initialize_maint_cmds): Move initialization code to
2111         remote.c.
2112         (watchdog, show_watchdog): Move to remote.c.
2113         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2114         "watchdog" static.
2115         (_initialize_remote): Move initialization code from maint.c.
2116         * defs.h (watchdog): Don't declare.
2117
2118 2019-05-08  Tom Tromey  <tromey@adacore.com>
2119
2120         * tui/tui-interp.c: Include main.h.
2121         * interps.c: Include main.h.
2122         * main.h (interpreter_p): Declare.
2123         * defs.h (interpreter_p): Don't declare.
2124
2125 2019-05-08  Tom Tromey  <tromey@adacore.com>
2126
2127         * dwarf2loc.c: Include dwarf2read.h.
2128         * defs.h (read_unsigned_leb128): Don't declare.
2129         * dwarf2read.h (read_unsigned_leb128): Declare.
2130
2131 2019-05-08  Tom Tromey  <tromey@adacore.com>
2132
2133         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2134         method.
2135
2136 2019-05-08  Tom Tromey  <tromey@adacore.com>
2137
2138         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2139         when no wrap column is set.
2140
2141 2019-05-08  Tom Tromey  <tromey@adacore.com>
2142
2143         * c-lang.c (c_get_string): Handle non-C-style arrays.
2144
2145 2019-05-08  Tom Tromey  <tromey@adacore.com>
2146
2147         * typeprint.c (print_offset_data::update): Print the bit offset,
2148         not the number of bits remaining.
2149
2150 2019-05-08  Tom Tromey  <tromey@adacore.com>
2151
2152         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2153         padding at end of comment.
2154
2155 2019-05-08  Tom Tromey  <tromey@adacore.com>
2156
2157         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2158         Compare main types.
2159
2160 2019-05-06  Tom Tromey  <tom@tromey.com>
2161
2162         * common/scoped_mmap.c: Include common-defs.h.
2163         * common/scoped_mmap.h: Don't include config.h.
2164
2165 2019-05-04  Tom Tromey  <tom@tromey.com>
2166
2167         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2168         (struct aarch64_call_info): Add initializers.
2169         <si>: Now a std::vector.
2170         (pass_on_stack, aarch64_push_dummy_call): Update.
2171
2172 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2173             Tom Tromey  <tom@tromey.com>
2174
2175         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2176         (ppc_threads): Now a std::vector.  Now static.
2177         (hwdebug_find_thread_points_by_tid)
2178         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2179         Update.
2180
2181 2019-05-04  Tom Tromey  <tom@tromey.com>
2182
2183         * arc-tdep.c (arc_tdesc_init): Return bool.
2184
2185 2019-05-04  Tom Tromey  <tom@tromey.com>
2186
2187         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2188         Use gdb_assert_not_reached.
2189
2190 2019-05-04  Tom Tromey  <tom@tromey.com>
2191
2192         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2193         "false".
2194
2195 2019-05-04  Tom Tromey  <tom@tromey.com>
2196
2197         * arc-tdep.c (arc_tdesc_init): Use bool.
2198
2199 2019-05-04  Tom Tromey  <tom@tromey.com>
2200
2201         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2202
2203 2019-05-04  Tom Tromey  <tom@tromey.com>
2204
2205         * cli/cli-cmds.c (valid_command_p): Return bool.
2206
2207 2019-05-04  Tom Tromey  <tom@tromey.com>
2208
2209         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2210         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2211
2212 2019-05-04  Raul Tambre  <raul@tambre.ee>
2213
2214         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2215         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2216         operator for comparison.
2217
2218 2019-05-04  Tom Tromey  <tom@tromey.com>
2219
2220         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2221         (lookup_partial_symbol, print_partial_symbols)
2222         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2223         (psymbol_compare): Update.
2224         (add_psymbol_to_bcache): Clear the entire psymbol.
2225         (maintenance_check_psymtabs): Update.
2226         * psympriv.h (struct partial_symbol): Don't derive from
2227         general_symbol_info.
2228         <obj_section, unrelocated_address, address,
2229         set_unrelocated_address>: Update.
2230         <ginfo>: New member.
2231         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2232         (debug_names::write_psymbols): Update.
2233
2234 2019-05-04  Tom de Vries  <tdevries@suse.de>
2235
2236         * contrib/cc-with-tweaks.sh: Support -n arg.
2237
2238 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2239
2240         * corelow.c (core_target::detach): Ensure frame cache and
2241         register caches are cleared.
2242         inferior.c (exit_inferior_1): Likewise.
2243
2244 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2245             Tom Tromey  <tom@tromey.com>
2246
2247         * dictionary.c (collate_pending_symbols_by_language): Remove
2248         "struct" from foreach.
2249         * symtab.c (lookup_global_symbol_from_objfile)
2250         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2251         foreach.
2252         * ser-tcp.c (net_open): Remove "struct" from foreach.
2253         * objfiles.c (objfile_relocate, objfile_rebase)
2254         (objfile_has_symbols): Remove "struct" from foreach.
2255         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2256         from foreach.
2257         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2258         foreach.
2259         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2260         "struct" from foreach.
2261         * ada-lang.c (create_excep_cond_exprs)
2262         (ada_exception_catchpoint_cond_string): Remove "struct" from
2263         foreach.
2264
2265 2019-05-03  Tom Tromey  <tromey@adacore.com>
2266
2267         * ada-exp.y (convert_char_literal): Check suffix of each
2268         enumerator.
2269
2270 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2271
2272         PR ada/21406:
2273         * ada-exp.y (yywrap): Don't define.
2274         * ada-lex.l (%option): Add noyywrap
2275         (yywrap): Remove.
2276
2277 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2278
2279         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2280         _WIN32_WINNT to the XP level, unless already defined to a higher
2281         level.
2282
2283         * unittests/parse-connection-spec-selftests.c:
2284         * ser-tcp.c:
2285         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2286         override.
2287
2288         * symfile.c (find_separate_debug_file): Remove colon from the
2289         drive spec of DOS/Windows file names of the target, so that the
2290         file name produced from DEBUGDIR and the target's directory will
2291         be valid on DOS/Windows systems.
2292
2293 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * rust-lang.c (val_print_struct): Handle printing structures
2296         containing strings.
2297
2298 2019-05-02  Tom Tromey  <tromey@adacore.com>
2299
2300         * valarith.c (_initialize_valarith): Remove.
2301
2302 2019-05-01  Tom Tromey  <tromey@adacore.com>
2303
2304         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2305         bitfields.
2306
2307 2019-05-01  Tom Tromey  <tromey@adacore.com>
2308
2309         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2310         for big-endian copies.
2311
2312 2019-04-30  Ali Tamur  <tamur@google.com>
2313         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2314         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2315         (read_3_bytes): New function.
2316
2317 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2318
2319         * windows-nat.c (main_thread_id): Delete.
2320         (handle_output_debug_string): Replace main_thread_id by
2321         current_event.dwThreadId.
2322         (fake_create_process): Likewise.
2323         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2324         Do not set main_thread_id.
2325         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2326         current_event.dwThreadId.
2327         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2328
2329 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2330
2331         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2332         Use current_event.dwThreadId instead of main_thread_id.
2333
2334 2019-04-30  Tom Tromey  <tromey@adacore.com>
2335
2336         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2337         (create_excep_cond_exprs): Iterate over program spaces.
2338         (ada_exception_catchpoint_cond_string): Examine all minimal
2339         symbols for exception types.
2340
2341 2019-04-30  Tom Tromey  <tromey@adacore.com>
2342
2343         PR c++/24470:
2344         * dwarf2read.c (process_structure_scope): Handle case where type
2345         has template parameters but no symbol was created.
2346
2347 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2348             Chris January  <chris.january@arm.com>
2349
2350         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2351         qualifier.
2352         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2353
2354 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * f-typeprint.c (f_print_type): Update rules for printing
2357         whitespace.
2358         (f_type_print_varspec_suffix): Likewise.
2359
2360 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2361             Chris January  <chris.january@arm.com>
2362
2363         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2364         function arguments.
2365
2366 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * f-lang.c (build_fortran_types): Change name of void type to
2369         lower case.
2370         * f-typeprint.c (f_type_print_base): Print the name of the void
2371         type, rather than a fixed string.
2372         * f-valprint.c (f_decorations): Use lower case void string.
2373
2374 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2375             Chris January  <chris.january@arm.com>
2376
2377         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2378         types for Fortran.
2379
2380 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2381             Chris January  <chris.january@arm.com>
2382             David Lecomber  <david.lecomber@arm.com>
2383
2384         * f-exp.y (BINOP_INTRINSIC): New token.
2385         (exp): New parser rule handling BINOP_INTRINSIC.
2386         (f77_keywords): Add new builtin procedures.
2387         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2388         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2389         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2390         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2391         (print_unop_subexp_f): New function.
2392         (print_binop_subexp_f): New function.
2393         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2394         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2395         (dump_subexp_body_f): Likewise.
2396         (operator_check_f): Likewise.
2397         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2398         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2399
2400 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2403         UNOP_KIND.
2404         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2405         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2406         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2407         (operator_length_f): New fuction.
2408         (print_subexp_f): New function.
2409         (op_name_f): New function.
2410         (dump_subexp_body_f): New function.
2411         (operator_check_f): New function.
2412         (exp_descriptor_f): Replace standard expression handling functions
2413         with new functions.
2414         * gdb/fortran-operator.def: New file.
2415         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2416         * gdb/std-operator.def: Remove UNOP_KIND.
2417
2418 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * std-operator.def: Remove unbalanced, stray double quote
2421         character.
2422
2423 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2424             Chris January  <chris.january@arm.com>
2425             Daniel Everett  <daniel.everett@arm.com>
2426             Nick Forrington  <nick.forrington@arm.com>
2427             Richard Bunt  <richard.bunt@arm.com>
2428
2429         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2430         of depth when printing anonymous structs or unions.
2431         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2432         Don't print either the top-level value, or the children if the
2433         max-depth is exceeded.
2434         (ppscm_print_children): When printing the key of a map, allow one
2435         extra level of depth.
2436         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2437         print either the top-level value, or the children if the max-depth
2438         is exceeded.
2439         (print_children): When printing the key of a map, allow one extra
2440         level of depth.
2441         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2442         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2443         (user_print_options): Initialise max_depth field.
2444         (val_print_scalar_or_string_type_p): New function.
2445         (val_print): Check to see if the max depth has been reached.
2446         (val_print_check_max_depth): Define new function.
2447         (show_print_max_depth): New function.
2448         (_initialize_valprint): Add 'print max-depth' option.
2449         * valprint.h (struct value_print_options) <max_depth>: New field.
2450         (val_print_check_max_depth): Declare new function.
2451         * NEWS: Document new feature.
2452
2453 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * ada-lang.c (ada_language_defn): Initialise new field.
2456         * c-lang.c (c_is_string_type_p): New function.
2457         (c_language_defn): Initialise new field.
2458         (cplus_language_defn): Initialise new field.
2459         (asm_language_defn): Initialise new field.
2460         (minimal_language_defn): Initialise new field.
2461         * c-lang.h (c_is_string_type_p): Declare new function.
2462         * d-lang.c (d_language_defn): Initialise new field.
2463         * f-lang.c (f_is_string_type_p): New function.
2464         (f_language_defn): Initialise new field.
2465         * go-lang.c (go_is_string_type_p): New function.
2466         (go_language_defn): Initialise new field.
2467         * language.c (default_is_string_type_p): New function.
2468         (unknown_language_defn): Initialise new field.
2469         (auto_language_defn): Initialise new field.
2470         * language.h (struct language_defn) <la_is_string_type_p>: New
2471         member variable.
2472         (default_is_string_type_p): Declare new function.
2473         * m2-lang.c (m2_language_defn): Initialise new field.
2474         * objc-lang.c (objc_language_defn): Initialise new field.
2475         * opencl-lang.c (opencl_language_defn): Initialise new field.
2476         * p-lang.c (pascal_is_string_type_p): New function.
2477         (pascal_language_defn): Initialise new field.
2478         * rust-lang.c (rust_is_string_type_p): New function.
2479         (rust_language_defn): Initialise new field.
2480
2481 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2482
2483         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2484         New field.
2485         * ada-lang.c (ada_language_defn): Initialise new field.
2486         * c-lang.c (c_language_defn): Likewise.
2487         (cplus_language_defn): Likewise.
2488         (asm_language_defn): Likewise.
2489         (minimal_language_defn): Likewise.
2490         * d-lang.c (d_language_defn): Likewise.
2491         * f-lang.c (f_language_defn): Likewise.
2492         * go-lang.c (go_language_defn): Likewise.
2493         * language.c (unknown_language_defn): Likewise.
2494         (auto_language_defn): Likewise.
2495         * m2-lang.c (m2_language_defn): Likewise.
2496         * objc-lang.c (objc_language_defn): Likewise.
2497         * opencl-lang.c (opencl_language_defn): Likewise.
2498         * p-lang.c (pascal_language_defn): Likewise.
2499         * rust-lang.c (rust_language_defn): Likewise.
2500
2501 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2502
2503         * ada-lang.c (ada_is_character_type): Change return type to bool.
2504         (ada_is_string_type): Likewise.
2505         * ada-lang.h (ada_is_character_type): Update declaration
2506         (ada_is_string_type): Likewise.
2507
2508 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2509
2510         Support style in 'frame|thread apply'
2511
2512         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2513         * record.c (record_start, record_stop): Update callers of
2514         execute_command_to_string with false.
2515         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2516         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2517         methods.
2518         (class string_file): New constructor with term_out parameter.
2519         Override methods term_out and can_emit_style_escape.  New member
2520         term_out.
2521         (class stdio_file): Override can_emit_style_escape.
2522         (class tee_file): Override term_out and can_emit_style_escape.
2523         * utils.h (can_emit_style_escape): Remove.
2524         * utils.c (can_emit_style_escape): Likewise.
2525         Update all callers of can_emit_style_escape (SOMESTREAM) to
2526         SOMESTREAM->can_emit_style_escape.
2527         * source-cache.c (source_cache::get_source_lines): Likewise.
2528         * stack.c (frame_apply_command_count): Call execute_command_to_string
2529         passing the term_out characteristic of the current gdb_stdout.
2530         * thread.c (thr_try_catch_cmd): Likewise.
2531         * top.c (execute_command_to_string): pass term_out parameter
2532         to construct the string_file for the command output.
2533         * ui-file.c (term_cli_styling): New function (most code moved
2534         from utils.c can_emit_style_escape).
2535         (string_file::string_file, string_file::can_emit_style_escape,
2536         stdio_file::can_emit_style_escape, tee_file::term_out,
2537         tee_file::can_emit_style_escape): New functions.
2538
2539 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2540
2541         * NEWS: Mention the new set|show may-call-functions.
2542         * infcall.c (may_call_functions_p): New variable.
2543         (show_may_call_functions_p): New function.
2544         (call_function_by_hand_dummy): Throws an error if not
2545         may-call-functions.
2546         (_initialize_infcall): Call add_setshow_boolean_cmd for
2547         may-call-functions.
2548
2549 2019-04-25  Keith Seitz  <keiths@redhat.com>
2550
2551         PR c++/24367
2552         * cp-support.c (inspect_type): Don't attempt substitutions
2553         of symbol with the same name.
2554
2555 2019-04-25  Tom Tromey  <tromey@adacore.com>
2556
2557         PR gdb/24475:
2558         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2559         static.
2560
2561 2019-04-25  Tom Tromey  <tromey@adacore.com>
2562
2563         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2564         rvalue reference.
2565         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2566         (gdb_xml_parser::parse): Use std::move.
2567         * python/python-internal.h (gdbpy_convert_exception): Take a const
2568         reference.
2569         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2570         std::move.
2571         * python/py-utils.c (gdbpy_convert_exception): Take a const
2572         reference.
2573         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2574         Use std::move.
2575         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2576         Use std::move.
2577         * mi/mi-main.c (mi_print_exception): Take a const reference.
2578         * main.c (handle_command_errors): Take a const reference.
2579         * linespec.c (parse_linespec): Use std::move.
2580         * infcall.c (run_inferior_call): Use std::move.
2581         (call_function_by_hand_dummy): Use std::move.
2582         * exec.c (try_open_exec_file): Use std::move.
2583         * exceptions.h (exception_print, exception_fprintf)
2584         (exception_print_same): Update.
2585         * exceptions.c (print_exception, exception_print)
2586         (exception_fprintf, exception_print_same): Change parameters to
2587         const reference.
2588         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2589         * common/new-op.c: Use std::move.
2590         * common/common-exceptions.h (struct gdb_exception): Add move
2591         constructor.
2592         (struct gdb_exception_error, struct gdb_exception_quit, struct
2593         gdb_quit_bad_alloc): Change constructor to move constructor.
2594         (throw_exception): Change parameter to rvalue reference.
2595         * common/common-exceptions.c (throw_exception): Take rvalue
2596         reference.
2597         * cli/cli-interp.c (safe_execute_command): Use std::move.
2598         * breakpoint.c (insert_bp_location, location_to_sals): Use
2599         std::move.
2600
2601 2019-04-25  Tom Tromey  <tromey@adacore.com>
2602
2603         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2604         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2605         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2606         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2607         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2608         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2609         guile/scm-value.c: Use unpack.
2610         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2611         gdbscm_gdb_exception.
2612         (gdbscm_throw_gdb_exception): Likewise.
2613         (struct gdbscm_gdb_exception): New.
2614         (unpack): New function.
2615         (gdbscm_wrap): Use unpack.
2616
2617 2019-04-25  Tom Tromey  <tromey@adacore.com>
2618
2619         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2620         (gdb_rl_callback_handler): Use std::move.
2621         * common/common-exceptions.h (struct gdb_exception): Add move
2622         assignment operator.
2623         (throw_exception_sjlj): Change "exception" to const reference.
2624         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2625         (throw_exception_sjlj): Change "exception" to const reference.
2626
2627 2019-04-25  Tom Tromey  <tromey@adacore.com>
2628
2629         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2630         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2631         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2632         Update.
2633         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2634         Update.
2635         * mi/mi-interp.c (mi_interp::exec): Update.
2636         * linespec.c (parse_linespec): Update.
2637         * infcall.c (run_inferior_call): Update.
2638         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2639         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2640         (gdbscm_lookup_global_symbol): Update.
2641         * guile/scm-param.c (gdbscm_parameter_value): Update.
2642         * guile/scm-frame.c (gdbscm_frame_read_register)
2643         (gdbscm_frame_read_var): Update.
2644         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2645         * exec.c (try_open_exec_file): Update.
2646         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2647         (gdb_rl_callback_handler): Update.
2648         * common/common-exceptions.h (exception_none): Don't declare.
2649         * common/common-exceptions.c (exception_none): Don't define.
2650         (struct catcher) <exception>: Update.
2651         * cli/cli-interp.c (safe_execute_command): Update.
2652         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2653
2654 2019-04-25  Ali Tamur  <tamur@google.com>
2655
2656         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2657         (read_attribute_value): Likewise.
2658         (dwarf2_read_addr_index): Update comment.
2659         (read_str_index): Add DW_FORM_strx.
2660         (dwarf2_string_attr): Likewise.
2661         (dwarf2_const_value_attr): Likewise.
2662         (dump_die_shallow): Likewise.
2663         (dwarf2_fetch_constant_bytes): Likewise.
2664         (skip_form_bytes): Likewise.
2665         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2666
2667 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2668
2669         PR corefiles/11608
2670         PR corefiles/18187
2671         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2672         OFFSET.  Verify if current mapping contains an ELF header.
2673         (linux_find_memory_regions_full): Adjust call to
2674         dump_mapping_p.
2675
2676 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2677             Kang Li <kanglictf@gmail.com>
2678
2679         PR gdb/21600
2680
2681         * dwarf2-frame.c (read_initial_length): Be consistent about using
2682         unsigned representation of length.
2683         (decode_frame_entry_1): Likewise.  Check for wraparound of
2684         end pointer as well as buffer overflow.
2685
2686 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2687
2688         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2689         "vq".
2690
2691 2019-04-24  Tom Tromey  <tromey@adacore.com>
2692
2693         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2694
2695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2696
2697         * s12z-tdep.c (s12z_unwind_pc): Delete.
2698         (s12z_unwind_sp): Delete.
2699         (s12z_gdbarch_init): Don't register deleted functions with
2700         gdbarch.
2701
2702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2703
2704         * rl78-tdep.c (rl78_unwind_sp): Delete.
2705         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2706
2707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2708
2709         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2710         (xstormy16_unwind_pc): Delete.
2711         (xstormy16_dummy_id): Delete.
2712         (xstormy16_gdbarch_init): Don't register deleted functions with
2713         gdbarch.
2714
2715 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2716
2717         * vax-tdep.c (vax_unwind_pc): Delete.
2718         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2719
2720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2721
2722         * v850-tdep.c (v850_unwind_sp): Delete.
2723         (v850_unwind_pc): Delete.
2724         (v850_dummy_id): Delete.
2725         (v850_gdbarch_init): Don't register deleted functions with
2726         gdbarch.
2727
2728 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2729
2730         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2731         (tilegx_unwind_pc): Delete.
2732         (tilegx_unwind_dummy_id): Delete.
2733         (tilegx_gdbarch_init): Don't register deleted functions with
2734         gdbarch.
2735
2736 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2739         (tic6x_dummy_id): Delete.
2740         (tic6x_gdbarch_init): Don't register deleted functions with
2741         gdbarch.
2742
2743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * sparc-tdep.c (sparc_unwind_pc): Delete.
2746         (sparc32_gdbarch_init): Don't register deleted function with
2747         gdbarch.
2748
2749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * sh-tdep.c (sh_unwind_sp): Delete.
2752         (sh_unwind_pc): Delete.
2753         (sh_dummy_id): Delete.
2754         (sh_gdbarch_init): Don't register deleted functions with
2755         gdbarch.
2756
2757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2758
2759         * score-tdep.c (score_unwind_sp): Delete.
2760         (score_unwind_pc): Delete.
2761         (score_dummy_id): Delete.
2762         (score_gdbarch_init): Don't register deleted functions with
2763         gdbarch.
2764
2765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2766
2767         * rx-tdep.c (rx_unwind_pc): Delete.
2768         (rx_unwind_sp): Delete.
2769         (rx_dummy_id): Delete.
2770         (rx_gdbarch_init): Don't register deleted functions with
2771         gdbarch.  Update comment.
2772
2773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2776         (rs6000_dummy_id): Delete.
2777         (rs6000_gdbarch_init): Don't register deleted functions with
2778         gdbarch.
2779
2780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2781
2782         * or1k-tdep.c (or1k_dummy_id): Delete.
2783         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2784
2785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * nios2-tdep.c (nios2_dummy_id): Delete.
2788         (nios2_unwind_sp): Delete.
2789         (nios2_gdbarch_init): Don't register deleted functions with
2790         gdbarch.
2791
2792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2793
2794         * nds32-tdep.c (nds32_dummy_id): Delete.
2795         (nds32_unwind_pc): Delete.
2796         (nds32_unwind_sp): Delete.
2797         (nds32_gdbarch_init): Don't register deleted functions with
2798         gdbarch.
2799
2800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * msp430-tdep.c (msp430_unwind_pc): Delete.
2803         (msp430_unwind_sp): Delete.
2804         (msp430_dummy_id): Delete.
2805         (msp430_gdbarch_init): Don't register deleted functions with
2806         gdbarch.
2807
2808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2809
2810         * moxie-tdep.c (moxie_unwind_sp): Delete.
2811         (moxie_unwind_pc): Delete.
2812         (moxie_dummy_id): Delete.
2813         (moxie_gdbarch_init): Don't register deleted functions with
2814         gdbarch.
2815
2816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2817
2818         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2819         (mn10300_unwind_pc): Delete.
2820         (mn10300_unwind_sp): Delete.
2821         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2822         mn10300_unwind_sp.
2823         (mn10300_frame_unwind_init): Don't register deleted functions with
2824         gdbarch.
2825
2826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2827
2828         * mep-tdep.c (mep_unwind_pc): Delete.
2829         (mep_unwind_sp): Delete.
2830         (mep_dummy_id): Delete.
2831         (mep_gdbarch_init): Don't register deleted functions with
2832         gdbarch.
2833
2834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2837         (m68hc11_unwind_sp): Delete.
2838         (m68hc11_gdbarch_init): Don't register deleted functions with
2839         gdbarch.
2840
2841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * m32r-tdep.c (m32r_unwind_sp): Delete.
2844         (m32r_unwind_pc): Delete.
2845         (m32r_dummy_id): Delete.
2846         (m32r_gdbarch_init): Don't register deleted functions with
2847         gdbarch.
2848
2849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2850
2851         * m32c-tdep.c (m32c_unwind_pc): Delete.
2852         (m32c_unwind_sp): Delete.
2853         (m32c_dummy_id): Delete.
2854         (m32c_gdbarch_init): Don't register deleted functions with
2855         gdbarch.
2856
2857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2858
2859         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2860         (lm32_unwind_pc): Delete.
2861         (lm32_dummy_id): Delete.
2862         (lm32_gdbarch_init): Don't register deleted functions with
2863         gdbarch.
2864
2865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2868         (iq2000_unwind_pc): Delete.
2869         (iq2000_dummy_id): Delete.
2870         (iq2000_gdbarch_init): Don't register deleted functions with
2871         gdbarch.
2872
2873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2874
2875         * nds32-tdep.c (nds32_type_align): Delete.
2876         (nds32_push_dummy_call): Use type_align instead.
2877
2878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2879
2880         * arm-tdep.c (arm_type_align): Only handle vector override case.
2881         (arm_push_dummy_call): Use type_align.
2882         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2883
2884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2887         case.
2888         (pass_on_stack): Use type_align.
2889         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2890         function.
2891
2892 2019-04-23  Tom Tromey  <tromey@adacore.com>
2893
2894         * dwarf2read.c (line_header::file_name_at): Remove unused
2895         overload.
2896
2897 2019-04-23  Tom de Vries  <tdevries@suse.de>
2898
2899         PR gdb/24438
2900         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2901         invocation.
2902
2903
2904 2019-03-27  Ali Tamur  <tamur@google.com>
2905
2906         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2907         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2908         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2909         (dwarf_expr_context::get_addr_index): Likewise
2910         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2911         (symbol_needs_eval_context::get_addr_index): Likewise
2912         (disassemble_dwarf_expression): Add DW_OP_addrx
2913         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2914         (read_cutu_die_from_dwo): Update comment
2915         (skip_one_die): Add DW_FORM_addrx
2916         (read_attribute_value): Likewise
2917         (var_decode_location): Add DW_OP_addrx
2918         (dwarf2_const_value_attr): Add DW_FORM_addrx
2919         (dump_die_shallow): Likewise
2920         (dwarf2_fetch_constant_bytes): Likewise
2921         (decode_locdesc): Add DW_OP_addrx
2922         (skip_form_bytes): Add DW_FORM_addrx
2923
2924 2019-04-22  Ali Tamur  <tamur@google.com>
2925
2926         * MAINTAINERS (Write After Approval): Add self.
2927
2928 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2929
2930         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2931         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2932         (open_symbol_file_object): Likewise.
2933         (svr4_default_sos): Add info parameter.
2934         (svr4_read_so_list): Likewise.
2935         (svr4_current_sos_direct): Adjust functions calls to pass down
2936         info.
2937         (svr4_current_sos_1): Add info parameter.
2938         (svr4_current_sos): Call get_svr4_info, pass info down to
2939         svr4_current_sos_1.
2940         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2941         get_svr4_info.
2942         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2943         get_svr4_info.
2944         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2945         to get_svr4_info.
2946         (probes_table_remove_objfile_probes): Likewise.
2947         (register_solib_event_probe): Add info parameter.
2948         (solist_update_incremental): Pass info parameter down to
2949         svr4_read_so_list.
2950         (disable_probes_interface): Add info parameter.
2951         (svr4_handle_solib_event): Pass current_program_space to
2952         get_svr4_info.  Adjust disable_probes_interface cleanup.
2953         (svr4_create_probe_breakpoints): Add info parameter, pass it
2954         down to register_solib_event_probe.
2955         (svr4_create_solib_event_breakpoints): Add info parameter,
2956         pass it down to svr4_create_probe_breakpoints.
2957         (enable_break): Pass info down to
2958         svr4_create_solib_event_breakpoints.
2959         (svr4_solib_create_inferior_hook): Pass current_program_space to
2960         get_svr4_info.
2961         (svr4_clear_solib): Likewise.
2962
2963 2019-04-22  Pedro Alves  <palves@redhat.com>
2964
2965         * solib-svr4.c (svr4_free_objfile_observer): New.
2966         (probe_and_action::objfile): New field.
2967         (probes_table_htab_remove_objfile_probes)
2968         (probes_table_remove_objfile_probes): New functions.
2969         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2970         in the new probe_and_action.  Don't store the probe in 'lookup'.
2971         (svr4_create_probe_breakpoints): Pass objfile to
2972         register_solib_event_probe.
2973         (_initialize_svr4_solib): Register a free_objfile observer.
2974
2975 2019-04-19  Tom Tromey  <tom@tromey.com>
2976
2977         * common/queue.h: Remove.
2978
2979 2019-04-19  Tom Tromey  <tom@tromey.com>
2980
2981         * event-loop.c: Don't include "common/queue.h".
2982
2983 2019-04-19  Tom Tromey  <tom@tromey.com>
2984
2985         * remote.c (remote_target): Use delete.
2986         * remote-notif.h: Include <list>, not "common/queue.h".
2987         (notif_client_p): Remove typedef.
2988         (remote_notif_state): Add constructor, destructor, initializer.
2989         <notif_queue>: Now a std::list.
2990         (remote_notif_state_xfree): Don't declare.
2991         * remote-notif.c (remote_notif_process, handle_notification)
2992         (remote_notif_state_allocate): Update.
2993         (~remote_notif_state): Rename from remote_notif_state_xfree.
2994
2995 2019-04-19  Tom Tromey  <tom@tromey.com>
2996
2997         * symfile.c (reread_symbols): Update.
2998         * objfiles.c (objfile_register_static_link)
2999         (objfile_lookup_static_link): Update
3000         (~objfile) Don't delete static_links.
3001         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3002
3003 2019-04-19  Tom Tromey  <tom@tromey.com>
3004
3005         * type-stack.h (struct type_stack) <insert>: Constify string.
3006         * type-stack.c (type_stack::insert): Constify string.
3007         * gdbtypes.h (lookup_template_type): Update.
3008         (address_space_name_to_int): Update.
3009         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3010         const.
3011         (lookup_template_type): Make name const.
3012         * c-exp.y: Update rules.
3013         (lex_one_token, classify_name, classify_inner_name)
3014         (c_print_token): Update.
3015         * p-exp.y: Update rules.
3016         (yylex): Update.
3017         * f-exp.y: Update rules.
3018         (yylex): Update.
3019         * d-exp.y: Update rules.
3020         (lex_one_token, classify_name, classify_inner_name): Update.
3021         * parse.c (write_dollar_variable, copy_name): Return std::string.
3022         * parser-defs.h (copy_name): Change return type.
3023         * m2-exp.y: Update rules.
3024         (yylex): Update.
3025         * go-exp.y (lex_one_token): Update.
3026         Update rules.
3027         (classify_unsafe_function, classify_packaged_name)
3028         (classify_name, yylex): Update.
3029
3030 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3031
3032         * configure.ac: add --enable-source-highlight switch.
3033         * configure: Regenerate.
3034         * top.c (print_gdb_version): plumb --enable-source-highlight
3035         status to "show configuration".
3036
3037 2019-04-19  Tom Tromey  <tromey@adacore.com>
3038
3039         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3040         Check ADA_TYPE_P.
3041         (empty_record, ada_template_to_fixed_record_type_1)
3042         (template_to_static_fixed_type)
3043         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3044         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3045         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3046         macros.
3047
3048 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3049
3050         PR symtab/24423:
3051         * source.c (print_source_lines_base): Advance "iter" when a
3052         control character is seen.
3053
3054 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3055
3056         * inferior.h (struct infcall_suspend_state_deleter):
3057         Catch exception in destructor to avoid crash.
3058
3059 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3060
3061         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3062         close to the add_com "shell".
3063
3064 2019-04-18  Tom Tromey  <tromey@adacore.com>
3065
3066         * process-stratum-target.h (class process_stratum_target)
3067         <stratum>: Add "final".
3068
3069 2019-04-17  Tom Tromey  <tromey@adacore.com>
3070
3071         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3072         against nullptr before use.
3073
3074 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3075
3076         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3077
3078 2019-04-17  Jim Wilson  <jimw@sifive.com>
3079             Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3082         code read might fail, assume 4-byte breakpoint in that case.
3083
3084 2019-04-15  Leszek Swirski  <leszeks@google.com>
3085
3086         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3087         rather than a hand-rolled POD check when checking for forced MEMORY
3088         classification.
3089
3090 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3091
3092         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3093         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3094         function.
3095         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3096         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3097         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3098         declaration.
3099
3100 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3101
3102         * aarch64-linux-nat.c
3103         (aarch64_linux_nat_target::thread_architecture): Add override.
3104         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3105         each VQ.
3106
3107 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3108
3109         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3110
3111 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3114         target types of size 96-bits, add some additional comments, and
3115         check that the builtin type we found was the correct size.
3116
3117 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3118
3119         * utils.c (prompt_for_continue): Don't restore the styling at the
3120         end, as applied_style has the wrong value.  This fixes styling in
3121         long lists of file names that are interrupted by the "Continue?"
3122         prompt.
3123
3124 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3125
3126         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3127         * c-lang.c (c_language_defn): Likewise.
3128         (cplus_language_defn): Likewise.
3129         (asm_language_defn): Likewise.
3130         (minimal_language_defn): Likewise.
3131         * d-lang.c (d_language_defn): Likewise.
3132         * f-lang.c (f_language_defn): Likewise.
3133         * go-lang.c (go_language_defn): Likewise.
3134         * language.c (unknown_language_defn): Likewise.
3135         (auto_language_defn): Likewise.
3136         * language.h (struct language_defn): Remove la_magic field.
3137         (LANG_MAGIC): Delete.
3138         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3139         * objc-lang.c (objc_language_defn): Likewise.
3140         * opencl-lang.c (opencl_language_defn): Likewise.
3141         * p-lang.c (pascal_language_defn): Likewise.
3142         * rust-lang.c (rust_language_defn): Likewise.
3143
3144 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3145
3146         * riscv-tdep.c (riscv_type_align): New function.
3147         (riscv_type_alignment): Delete.
3148         (riscv_arg_location): Use 'type_align'.
3149         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3150
3151 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3152
3153         * gdbtypes.c (type_align): A struct with no non-static fields also
3154         has alignment of 1.
3155
3156 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3159         component to 0.
3160         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3161         member.
3162         (riscv_struct_info::analyse): New implementation using new
3163         analyse_inner member function.
3164         (riscv_struct_info::field_offset): New member function.
3165         (riscv_struct_info::m_offsets): New member variable.
3166         (riscv_struct_info::analyse_inner): New private member function,
3167         takes the old implementation of riscv_struct_info::analyse but
3168         extended to track field offsets.
3169         (riscv_call_arg_struct): Update the struct folding special cases
3170         to handle cases where empty C++ structs, which are non-zero
3171         length, are found.
3172         (riscv_arg_location): Initialise the length of each location, a
3173         non-zero length now indicates the location is in use.
3174         (riscv_push_dummy_call): Allow for the first location having a
3175         non-zero offset when setting up arguments.
3176         (riscv_return_value): Likewise, but for return values.
3177
3178 2019-04-11  Tom Tromey  <tromey@adacore.com>
3179
3180         * utils.c (internal_vproblem): Make "msg" const.
3181
3182 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3183
3184         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3185         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3186         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3187         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3188
3189 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3190
3191         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3192         function.
3193         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3194         of amd64_collect_native_gregset.
3195         (amd64_linux_nat_target::store_registers): Likewise.
3196
3197 2019-04-10  Tom Tromey  <tom@tromey.com>
3198
3199         * symtab.c (lookup_global_symbol_from_objfile)
3200         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3201         * objfiles.h (class separate_debug_iterator): New.
3202         (class separate_debug_range): New.
3203         (struct objfile) <separate_debug_objfiles>: New method.
3204         (objfile_separate_debug_iterate): Don't declare.
3205         * objfiles.c (separate_debug_iterator::operator++): Rename from
3206         objfile_separate_debug_iterate.
3207         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3208         iterator.
3209         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3210         iterator.
3211
3212 2019-04-10  Tom Tromey  <tom@tromey.com>
3213
3214         * symfile.c (reread_symbols): Remove old comment.
3215         * objfiles.c (free_all_objfiles): Fix a typo.
3216
3217 2019-04-10  Tom Tromey  <tom@tromey.com>
3218
3219         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3220         * minsyms.c (lookup_minimal_symbol): Use foreach.
3221         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3222         (lookup_minimal_symbol_solib_trampoline): Likewise.
3223         * symfile.c (reread_symbols): Use foreach.
3224
3225 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3226             Tom Tromey  <tromey@adacore.com>
3227
3228         PR rust/24414:
3229         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3230         (rust_lex_int_test): Change "value" to be LONGEST.
3231         (rust_lex_tests): Add test for long integer literal.
3232
3233 2019-04-09  Tom Tromey  <tromey@adacore.com>
3234
3235         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3236         to bool.
3237         (extended_remote_target::attach): Update.
3238         (remote_target::remote_notice_new_inferior): Update.
3239         (remote_target::add_current_inferior_and_thread): Update.
3240         * inferior.c (exit_inferior_1): Use "false".
3241         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3242
3243 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3244
3245         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3246         the "start" command.
3247
3248 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3249
3250         * python/py-inferior.c (infpy_thread_from_thread_handle):
3251         Adjust comments to reflect renaming of thread_from_thread_handle
3252         to thread_from_handle.  Adjust keywords.  Fix type error message.
3253         (inferior_object_methods): Add thread_from_handle.  Retain
3254         thread_from_thread_handle, but mark it as deprecated.
3255
3256 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3257
3258         * gdbthread.h (find_thread_by_handle): Revise declaration.
3259         * thread.c (find_thread_by_handle): Likewise.  Adjust
3260         implementation too.
3261         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3262         support for buffer objects as handles.
3263
3264 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3265
3266         * python/py-infthread.c (thpy_thread_handle): New function.
3267         (thread_object_methods): Register thpy_thread_handle.
3268
3269 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3270
3271         * gdbthread.h (thread_to_thread_handle): Declare.
3272         * thread.c (gdbtypes.h): Include.
3273         (thread_to_thread_handle): New function.
3274
3275         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3276         (target_thread_info_to_thread_handle): Declare.
3277         * target.c (target_thread_info_to_thread_handle): New function.
3278         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3279         * target-delegates.c: Regenerate.
3280
3281         * linux-thread-db.c (class thread_db_target): Add method
3282         thread_info_to_thread_handle.
3283         (thread_db_target::thread_info_to_thread_handle): Define.
3284         * remote.c (class remote_target): Add new method
3285         thread_info_to_thread_handle.
3286         (remote_target::thread_info_to_thread_handle): Define.
3287
3288 2019-04-08  Pedro Alves  <palves@redhat.com>
3289
3290         * common/common-exceptions.c (throw_exception): Don't create
3291         named object to throw; throw directly.
3292         (throw_it): Likewise.  Don't initialize gdb_exception::message
3293         here, with new; pass FMT and AP to the ctor instead.
3294         * common/common-exceptions.h: Include <string>.
3295         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3296         const char *, va_list)): New ctor.  Use std::make_shared.
3297         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3298         errors)): Delete.
3299         (gdb_exception_error::gdb_exception_error(enum errors, const char
3300         *, va_list)): New.
3301         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3302         Add assertion.
3303         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3304         errors)): Delete.
3305         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3306         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3307         Add assertion.
3308
3309 2019-04-08  Tom Tromey  <tom@tromey.com>
3310
3311         * valops.c (value_rtti_indirect_type): Replace throw_exception
3312         with throw.
3313         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3314         with throw.
3315         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3316         throw.
3317         * target.c (target_translate_tls_address): Replace throw_exception
3318         with throw.
3319         * stack.c (frame_apply_command_count): Replace throw_exception
3320         with throw.
3321         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3322         throw.
3323         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3324         with throw.
3325         * rs6000-tdep.c (rs6000_frame_cache)
3326         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3327         * remote.c: Replace throw_exception with throw.
3328         * record-full.c (record_full_message, record_full_wait_1)
3329         (record_full_restore): Replace throw_exception with throw.
3330         * record-btrace.c:
3331         (get_thread_current_frame_id, record_btrace_start_replaying)
3332         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3333         (cmd_record_btrace_start): Replace throw_exception with throw.
3334         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3335         throw.
3336         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3337         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3338         * linespec.c:
3339         (find_linespec_symbols): Replace throw_exception with throw.
3340         * infrun.c (displaced_step_prepare, resume): Replace
3341         throw_exception with throw.
3342         * infcmd.c (post_create_inferior): Replace throw_exception with
3343         throw.
3344         * inf-loop.c (inferior_event_handler): Replace throw_exception
3345         with throw.
3346         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3347         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3348         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3349         (get_prev_frame_always, get_frame_pc_if_available)
3350         (get_frame_address_in_block_if_available, get_frame_language):
3351         Replace throw_exception with throw.
3352         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3353         throw_exception with throw.
3354         * eval.c (fetch_subexp_value, evaluate_var_value)
3355         (evaluate_funcall, evaluate_subexp_standard): Replace
3356         throw_exception with throw.
3357         * dwarf2loc.c (call_site_find_chain)
3358         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3359         Replace throw_exception with throw.
3360         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3361         with throw.
3362         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3363         throw.
3364         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3365         * completer.c (complete_line_internal): Replace throw_exception
3366         with throw.
3367         * compile/compile-object-run.c (compile_object_run): Replace
3368         throw_exception with throw.
3369         * cli/cli-script.c (process_next_line): Replace throw_exception
3370         with throw.
3371         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3372         (btrace_enable, btrace_maint_update_pt_packets): Replace
3373         throw_exception with throw.
3374         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3375         throw_exception with throw.
3376         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3377         throw_exception with throw.
3378         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3379         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3380         * aarch64-tdep.c (aarch64_make_prologue_cache)
3381         (aarch64_make_stub_cache): Replace throw_exception with throw.
3382
3383 2019-04-08  Tom Tromey  <tom@tromey.com>
3384
3385         * common/common-exceptions.c (throw_exception): Rename from
3386         throw_exception_cxx.  Remove old copy.  Make argument const.
3387         (throw_it): Create and throw exception objects directly.
3388         * common/common-exceptions.h (throw_exception): Make argument
3389         const.
3390         (struct gdb_exception_error): Add constructor.
3391         (struct gdb_exception_quit): Add constructor.
3392
3393 2019-04-08  Tom Tromey  <tom@tromey.com>
3394
3395         * common/common-exceptions.h (exception_rethrow): Don't declare.
3396         (TRY_SJLJ): Update comment.
3397         (TRY, CATCH, END_CATCH): Remove.
3398         * common/common-exceptions.c (exception_rethrow): Remove.
3399
3400 2019-04-08  Tom Tromey  <tom@tromey.com>
3401
3402         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3403         Remove.
3404         (gdb_exception_error): Rename from
3405         gdb_exception_RETURN_MASK_ERROR.
3406         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3407         (gdb_quit_bad_alloc): Update.
3408         * aarch64-tdep.c: Update.
3409         * ada-lang.c: Update.
3410         * ada-typeprint.c: Update.
3411         * ada-valprint.c: Update.
3412         * amd64-tdep.c: Update.
3413         * arch-utils.c: Update.
3414         * break-catch-throw.c: Update.
3415         * breakpoint.c: Update.
3416         * btrace.c: Update.
3417         * c-varobj.c: Update.
3418         * cli/cli-cmds.c: Update.
3419         * cli/cli-interp.c: Update.
3420         * cli/cli-script.c: Update.
3421         * common/common-exceptions.c: Update.
3422         * common/new-op.c: Update.
3423         * common/selftest.c: Update.
3424         * compile/compile-c-symbols.c: Update.
3425         * compile/compile-cplus-symbols.c: Update.
3426         * compile/compile-object-load.c: Update.
3427         * compile/compile-object-run.c: Update.
3428         * completer.c: Update.
3429         * corelow.c: Update.
3430         * cp-abi.c: Update.
3431         * cp-support.c: Update.
3432         * cp-valprint.c: Update.
3433         * darwin-nat.c: Update.
3434         * disasm-selftests.c: Update.
3435         * dtrace-probe.c: Update.
3436         * dwarf-index-cache.c: Update.
3437         * dwarf-index-write.c: Update.
3438         * dwarf2-frame-tailcall.c: Update.
3439         * dwarf2-frame.c: Update.
3440         * dwarf2loc.c: Update.
3441         * dwarf2read.c: Update.
3442         * eval.c: Update.
3443         * event-loop.c: Update.
3444         * event-top.c: Update.
3445         * exec.c: Update.
3446         * f-valprint.c: Update.
3447         * fbsd-tdep.c: Update.
3448         * frame-unwind.c: Update.
3449         * frame.c: Update.
3450         * gdbtypes.c: Update.
3451         * gnu-v3-abi.c: Update.
3452         * guile/guile-internal.h: Update.
3453         * guile/scm-block.c: Update.
3454         * guile/scm-breakpoint.c: Update.
3455         * guile/scm-cmd.c: Update.
3456         * guile/scm-disasm.c: Update.
3457         * guile/scm-frame.c: Update.
3458         * guile/scm-lazy-string.c: Update.
3459         * guile/scm-math.c: Update.
3460         * guile/scm-param.c: Update.
3461         * guile/scm-ports.c: Update.
3462         * guile/scm-pretty-print.c: Update.
3463         * guile/scm-symbol.c: Update.
3464         * guile/scm-symtab.c: Update.
3465         * guile/scm-type.c: Update.
3466         * guile/scm-value.c: Update.
3467         * i386-linux-tdep.c: Update.
3468         * i386-tdep.c: Update.
3469         * inf-loop.c: Update.
3470         * infcall.c: Update.
3471         * infcmd.c: Update.
3472         * infrun.c: Update.
3473         * jit.c: Update.
3474         * language.c: Update.
3475         * linespec.c: Update.
3476         * linux-fork.c: Update.
3477         * linux-nat.c: Update.
3478         * linux-tdep.c: Update.
3479         * linux-thread-db.c: Update.
3480         * main.c: Update.
3481         * mi/mi-cmd-break.c: Update.
3482         * mi/mi-cmd-stack.c: Update.
3483         * mi/mi-interp.c: Update.
3484         * mi/mi-main.c: Update.
3485         * objc-lang.c: Update.
3486         * p-valprint.c: Update.
3487         * parse.c: Update.
3488         * ppc-linux-tdep.c: Update.
3489         * printcmd.c: Update.
3490         * python/py-arch.c: Update.
3491         * python/py-breakpoint.c: Update.
3492         * python/py-cmd.c: Update.
3493         * python/py-finishbreakpoint.c: Update.
3494         * python/py-frame.c: Update.
3495         * python/py-framefilter.c: Update.
3496         * python/py-gdb-readline.c: Update.
3497         * python/py-inferior.c: Update.
3498         * python/py-infthread.c: Update.
3499         * python/py-lazy-string.c: Update.
3500         * python/py-linetable.c: Update.
3501         * python/py-objfile.c: Update.
3502         * python/py-param.c: Update.
3503         * python/py-prettyprint.c: Update.
3504         * python/py-progspace.c: Update.
3505         * python/py-record-btrace.c: Update.
3506         * python/py-record.c: Update.
3507         * python/py-symbol.c: Update.
3508         * python/py-type.c: Update.
3509         * python/py-unwind.c: Update.
3510         * python/py-utils.c: Update.
3511         * python/py-value.c: Update.
3512         * python/python.c: Update.
3513         * record-btrace.c: Update.
3514         * record-full.c: Update.
3515         * remote-fileio.c: Update.
3516         * remote.c: Update.
3517         * riscv-tdep.c: Update.
3518         * rs6000-aix-tdep.c: Update.
3519         * rs6000-tdep.c: Update.
3520         * rust-exp.y: Update.
3521         * rust-lang.c: Update.
3522         * s390-tdep.c: Update.
3523         * selftest-arch.c: Update.
3524         * solib-dsbt.c: Update.
3525         * solib-frv.c: Update.
3526         * solib-spu.c: Update.
3527         * solib-svr4.c: Update.
3528         * solib.c: Update.
3529         * sparc64-linux-tdep.c: Update.
3530         * stack.c: Update.
3531         * symfile-mem.c: Update.
3532         * symmisc.c: Update.
3533         * target.c: Update.
3534         * thread.c: Update.
3535         * top.c: Update.
3536         * tracefile-tfile.c: Update.
3537         * tui/tui.c: Update.
3538         * typeprint.c: Update.
3539         * unittests/cli-utils-selftests.c: Update.
3540         * unittests/parse-connection-spec-selftests.c: Update.
3541         * valops.c: Update.
3542         * valprint.c: Update.
3543         * value.c: Update.
3544         * varobj.c: Update.
3545         * windows-nat.c: Update.
3546         * x86-linux-nat.c: Update.
3547         * xml-support.c: Update.
3548
3549 2019-04-08  Tom Tromey  <tom@tromey.com>
3550
3551         * xml-support.c: Use C++ exception handling.
3552         * x86-linux-nat.c: Use C++ exception handling.
3553         * windows-nat.c: Use C++ exception handling.
3554         * varobj.c: Use C++ exception handling.
3555         * value.c: Use C++ exception handling.
3556         * valprint.c: Use C++ exception handling.
3557         * valops.c: Use C++ exception handling.
3558         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3559         handling.
3560         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3561         * typeprint.c: Use C++ exception handling.
3562         * tui/tui.c: Use C++ exception handling.
3563         * tracefile-tfile.c: Use C++ exception handling.
3564         * top.c: Use C++ exception handling.
3565         * thread.c: Use C++ exception handling.
3566         * target.c: Use C++ exception handling.
3567         * symmisc.c: Use C++ exception handling.
3568         * symfile-mem.c: Use C++ exception handling.
3569         * stack.c: Use C++ exception handling.
3570         * sparc64-linux-tdep.c: Use C++ exception handling.
3571         * solib.c: Use C++ exception handling.
3572         * solib-svr4.c: Use C++ exception handling.
3573         * solib-spu.c: Use C++ exception handling.
3574         * solib-frv.c: Use C++ exception handling.
3575         * solib-dsbt.c: Use C++ exception handling.
3576         * selftest-arch.c: Use C++ exception handling.
3577         * s390-tdep.c: Use C++ exception handling.
3578         * rust-lang.c: Use C++ exception handling.
3579         * rust-exp.y: Use C++ exception handling.
3580         * rs6000-tdep.c: Use C++ exception handling.
3581         * rs6000-aix-tdep.c: Use C++ exception handling.
3582         * riscv-tdep.c: Use C++ exception handling.
3583         * remote.c: Use C++ exception handling.
3584         * remote-fileio.c: Use C++ exception handling.
3585         * record-full.c: Use C++ exception handling.
3586         * record-btrace.c: Use C++ exception handling.
3587         * python/python.c: Use C++ exception handling.
3588         * python/py-value.c: Use C++ exception handling.
3589         * python/py-utils.c: Use C++ exception handling.
3590         * python/py-unwind.c: Use C++ exception handling.
3591         * python/py-type.c: Use C++ exception handling.
3592         * python/py-symbol.c: Use C++ exception handling.
3593         * python/py-record.c: Use C++ exception handling.
3594         * python/py-record-btrace.c: Use C++ exception handling.
3595         * python/py-progspace.c: Use C++ exception handling.
3596         * python/py-prettyprint.c: Use C++ exception handling.
3597         * python/py-param.c: Use C++ exception handling.
3598         * python/py-objfile.c: Use C++ exception handling.
3599         * python/py-linetable.c: Use C++ exception handling.
3600         * python/py-lazy-string.c: Use C++ exception handling.
3601         * python/py-infthread.c: Use C++ exception handling.
3602         * python/py-inferior.c: Use C++ exception handling.
3603         * python/py-gdb-readline.c: Use C++ exception handling.
3604         * python/py-framefilter.c: Use C++ exception handling.
3605         * python/py-frame.c: Use C++ exception handling.
3606         * python/py-finishbreakpoint.c: Use C++ exception handling.
3607         * python/py-cmd.c: Use C++ exception handling.
3608         * python/py-breakpoint.c: Use C++ exception handling.
3609         * python/py-arch.c: Use C++ exception handling.
3610         * printcmd.c: Use C++ exception handling.
3611         * ppc-linux-tdep.c: Use C++ exception handling.
3612         * parse.c: Use C++ exception handling.
3613         * p-valprint.c: Use C++ exception handling.
3614         * objc-lang.c: Use C++ exception handling.
3615         * mi/mi-main.c: Use C++ exception handling.
3616         * mi/mi-interp.c: Use C++ exception handling.
3617         * mi/mi-cmd-stack.c: Use C++ exception handling.
3618         * mi/mi-cmd-break.c: Use C++ exception handling.
3619         * main.c: Use C++ exception handling.
3620         * linux-thread-db.c: Use C++ exception handling.
3621         * linux-tdep.c: Use C++ exception handling.
3622         * linux-nat.c: Use C++ exception handling.
3623         * linux-fork.c: Use C++ exception handling.
3624         * linespec.c: Use C++ exception handling.
3625         * language.c: Use C++ exception handling.
3626         * jit.c: Use C++ exception handling.
3627         * infrun.c: Use C++ exception handling.
3628         * infcmd.c: Use C++ exception handling.
3629         * infcall.c: Use C++ exception handling.
3630         * inf-loop.c: Use C++ exception handling.
3631         * i386-tdep.c: Use C++ exception handling.
3632         * i386-linux-tdep.c: Use C++ exception handling.
3633         * guile/scm-value.c: Use C++ exception handling.
3634         * guile/scm-type.c: Use C++ exception handling.
3635         * guile/scm-symtab.c: Use C++ exception handling.
3636         * guile/scm-symbol.c: Use C++ exception handling.
3637         * guile/scm-pretty-print.c: Use C++ exception handling.
3638         * guile/scm-ports.c: Use C++ exception handling.
3639         * guile/scm-param.c: Use C++ exception handling.
3640         * guile/scm-math.c: Use C++ exception handling.
3641         * guile/scm-lazy-string.c: Use C++ exception handling.
3642         * guile/scm-frame.c: Use C++ exception handling.
3643         * guile/scm-disasm.c: Use C++ exception handling.
3644         * guile/scm-cmd.c: Use C++ exception handling.
3645         * guile/scm-breakpoint.c: Use C++ exception handling.
3646         * guile/scm-block.c: Use C++ exception handling.
3647         * guile/guile-internal.h: Use C++ exception handling.
3648         * gnu-v3-abi.c: Use C++ exception handling.
3649         * gdbtypes.c: Use C++ exception handling.
3650         * frame.c: Use C++ exception handling.
3651         * frame-unwind.c: Use C++ exception handling.
3652         * fbsd-tdep.c: Use C++ exception handling.
3653         * f-valprint.c: Use C++ exception handling.
3654         * exec.c: Use C++ exception handling.
3655         * event-top.c: Use C++ exception handling.
3656         * event-loop.c: Use C++ exception handling.
3657         * eval.c: Use C++ exception handling.
3658         * dwarf2read.c: Use C++ exception handling.
3659         * dwarf2loc.c: Use C++ exception handling.
3660         * dwarf2-frame.c: Use C++ exception handling.
3661         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3662         * dwarf-index-write.c: Use C++ exception handling.
3663         * dwarf-index-cache.c: Use C++ exception handling.
3664         * dtrace-probe.c: Use C++ exception handling.
3665         * disasm-selftests.c: Use C++ exception handling.
3666         * darwin-nat.c: Use C++ exception handling.
3667         * cp-valprint.c: Use C++ exception handling.
3668         * cp-support.c: Use C++ exception handling.
3669         * cp-abi.c: Use C++ exception handling.
3670         * corelow.c: Use C++ exception handling.
3671         * completer.c: Use C++ exception handling.
3672         * compile/compile-object-run.c: Use C++ exception handling.
3673         * compile/compile-object-load.c: Use C++ exception handling.
3674         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3675         * compile/compile-c-symbols.c: Use C++ exception handling.
3676         * common/selftest.c: Use C++ exception handling.
3677         * common/new-op.c: Use C++ exception handling.
3678         * cli/cli-script.c: Use C++ exception handling.
3679         * cli/cli-interp.c: Use C++ exception handling.
3680         * cli/cli-cmds.c: Use C++ exception handling.
3681         * c-varobj.c: Use C++ exception handling.
3682         * btrace.c: Use C++ exception handling.
3683         * breakpoint.c: Use C++ exception handling.
3684         * break-catch-throw.c: Use C++ exception handling.
3685         * arch-utils.c: Use C++ exception handling.
3686         * amd64-tdep.c: Use C++ exception handling.
3687         * ada-valprint.c: Use C++ exception handling.
3688         * ada-typeprint.c: Use C++ exception handling.
3689         * ada-lang.c: Use C++ exception handling.
3690         * aarch64-tdep.c: Use C++ exception handling.
3691
3692 2019-04-08  Tom Tromey  <tom@tromey.com>
3693
3694         * xml-support.c (gdb_xml_parser::parse): Update.
3695         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3696         * value.c (show_convenience): Update.
3697         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3698         (test_parse_flags_qcs): Update.
3699         * thread.c (thr_try_catch_cmd): Update.
3700         * target.c (target_translate_tls_address): Update.
3701         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3702         (info_frame_command_core, frame_apply_command_count): Update.
3703         * rust-exp.y (rust_lex_exception_test): Update.
3704         * riscv-tdep.c (riscv_print_one_register_info): Update.
3705         * remote.c (remote_target::enable_btrace): Update.
3706         * record-btrace.c (record_btrace_enable_warn): Update.
3707         * python/py-utils.c (gdbpy_convert_exception): Update.
3708         * printcmd.c (do_one_display, print_variable_and_value): Update.
3709         * mi/mi-main.c (mi_print_exception): Update.
3710         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3711         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3712         * linux-nat.c (linux_nat_target::attach): Update.
3713         * linux-fork.c (class scoped_switch_fork_info): Update.
3714         * infrun.c (displaced_step_prepare): Update.
3715         * infcall.c (call_function_by_hand_dummy): Update.
3716         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3717         * gnu-v3-abi.c (print_one_vtable): Update.
3718         * frame.c (get_prev_frame_always): Update.
3719         * f-valprint.c (info_common_command_for_block): Update.
3720         * exec.c (try_open_exec_file): Update.
3721         * exceptions.c (print_exception, exception_print)
3722         (exception_fprintf, exception_print_same): Update.
3723         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3724         * dwarf-index-cache.c (index_cache::store)
3725         (index_cache::lookup_gdb_index): Update.
3726         * darwin-nat.c (maybe_cache_shell): Update.
3727         * cp-valprint.c (cp_print_value_fields): Update.
3728         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3729         (gcc_cplus_symbol_address): Update.
3730         * compile/compile-c-symbols.c (gcc_convert_symbol)
3731         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3732         * common/selftest.c: Update.
3733         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3734         a std::string.
3735         (exception_try_scope_entry, exception_try_scope_exit): Don't
3736         declare.
3737         (struct exception_try_scope): Remove.
3738         (TRY): Don't use exception_try_scope.
3739         (struct gdb_exception): Add constructor, operator=.
3740         <what>: New method.
3741         (struct gdb_exception_RETURN_MASK_ALL)
3742         (struct gdb_exception_RETURN_MASK_ERROR)
3743         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3744         (struct gdb_quit_bad_alloc): Update.
3745         * common/common-exceptions.c (exception_none): Change
3746         initializer.
3747         (struct catcher) <state, exception>: Initialize inline.
3748         <prev>: Remove member.
3749         (current_catcher): Remove.
3750         (catchers): New global.
3751         (exceptions_state_mc_init): Simplify.
3752         (catcher_pop): Remove.
3753         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3754         (try_scope_depth, exception_try_scope_entry)
3755         (exception_try_scope_exit): Remove.
3756         (throw_exception_sjlj): Update.
3757         (exception_messages, exception_messages_size): Remove.
3758         (throw_it): Simplify.
3759         (gdb_exception_sliced_copy): Remove.
3760         (throw_exception_cxx): Update.
3761         * cli/cli-script.c (script_from_file): Update.
3762         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3763         Update.
3764         * ada-valprint.c (ada_val_print): Update.
3765         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3766         (create_excep_cond_exprs): Update.
3767
3768 2019-04-08  Tom Tromey  <tom@tromey.com>
3769
3770         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3771         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3772         (TRY, CATCH, END_CATCH): Remove some definitions.
3773         * common/common-exceptions.c: Don't use GDB_XCPT.
3774         (catcher_list_size): Remove.
3775         (throw_exception, throw_it): Simplify.
3776
3777 2019-04-05  Tom Tromey  <tom@tromey.com>
3778
3779         Revert the header-sorting patch.
3780         * ft32-tdep.c: Revert.
3781         * frv-tdep.c: Revert.
3782         * frv-linux-tdep.c: Revert.
3783         * frame.c: Revert.
3784         * frame-unwind.c: Revert.
3785         * frame-base.c: Revert.
3786         * fork-child.c: Revert.
3787         * findvar.c: Revert.
3788         * findcmd.c: Revert.
3789         * filesystem.c: Revert.
3790         * filename-seen-cache.h: Revert.
3791         * filename-seen-cache.c: Revert.
3792         * fbsd-tdep.c: Revert.
3793         * fbsd-nat.h: Revert.
3794         * fbsd-nat.c: Revert.
3795         * f-valprint.c: Revert.
3796         * f-typeprint.c: Revert.
3797         * f-lang.c: Revert.
3798         * extension.h: Revert.
3799         * extension.c: Revert.
3800         * extension-priv.h: Revert.
3801         * expprint.c: Revert.
3802         * exec.h: Revert.
3803         * exec.c: Revert.
3804         * exceptions.c: Revert.
3805         * event-top.c: Revert.
3806         * event-loop.c: Revert.
3807         * eval.c: Revert.
3808         * elfread.c: Revert.
3809         * dwarf2read.h: Revert.
3810         * dwarf2read.c: Revert.
3811         * dwarf2loc.c: Revert.
3812         * dwarf2expr.h: Revert.
3813         * dwarf2expr.c: Revert.
3814         * dwarf2-frame.c: Revert.
3815         * dwarf2-frame-tailcall.c: Revert.
3816         * dwarf-index-write.h: Revert.
3817         * dwarf-index-write.c: Revert.
3818         * dwarf-index-common.c: Revert.
3819         * dwarf-index-cache.h: Revert.
3820         * dwarf-index-cache.c: Revert.
3821         * dummy-frame.c: Revert.
3822         * dtrace-probe.c: Revert.
3823         * disasm.h: Revert.
3824         * disasm.c: Revert.
3825         * disasm-selftests.c: Revert.
3826         * dictionary.c: Revert.
3827         * dicos-tdep.c: Revert.
3828         * demangle.c: Revert.
3829         * dcache.h: Revert.
3830         * dcache.c: Revert.
3831         * darwin-nat.h: Revert.
3832         * darwin-nat.c: Revert.
3833         * darwin-nat-info.c: Revert.
3834         * d-valprint.c: Revert.
3835         * d-namespace.c: Revert.
3836         * d-lang.c: Revert.
3837         * ctf.c: Revert.
3838         * csky-tdep.c: Revert.
3839         * csky-linux-tdep.c: Revert.
3840         * cris-tdep.c: Revert.
3841         * cris-linux-tdep.c: Revert.
3842         * cp-valprint.c: Revert.
3843         * cp-support.c: Revert.
3844         * cp-namespace.c: Revert.
3845         * cp-abi.c: Revert.
3846         * corelow.c: Revert.
3847         * corefile.c: Revert.
3848         * continuations.c: Revert.
3849         * completer.h: Revert.
3850         * completer.c: Revert.
3851         * complaints.c: Revert.
3852         * coffread.c: Revert.
3853         * coff-pe-read.c: Revert.
3854         * cli-out.h: Revert.
3855         * cli-out.c: Revert.
3856         * charset.c: Revert.
3857         * c-varobj.c: Revert.
3858         * c-valprint.c: Revert.
3859         * c-typeprint.c: Revert.
3860         * c-lang.c: Revert.
3861         * buildsym.c: Revert.
3862         * buildsym-legacy.c: Revert.
3863         * build-id.h: Revert.
3864         * build-id.c: Revert.
3865         * btrace.c: Revert.
3866         * bsd-uthread.c: Revert.
3867         * breakpoint.h: Revert.
3868         * breakpoint.c: Revert.
3869         * break-catch-throw.c: Revert.
3870         * break-catch-syscall.c: Revert.
3871         * break-catch-sig.c: Revert.
3872         * blockframe.c: Revert.
3873         * block.c: Revert.
3874         * bfin-tdep.c: Revert.
3875         * bfin-linux-tdep.c: Revert.
3876         * bfd-target.c: Revert.
3877         * bcache.c: Revert.
3878         * ax-general.c: Revert.
3879         * ax-gdb.h: Revert.
3880         * ax-gdb.c: Revert.
3881         * avr-tdep.c: Revert.
3882         * auxv.c: Revert.
3883         * auto-load.c: Revert.
3884         * arm-wince-tdep.c: Revert.
3885         * arm-tdep.c: Revert.
3886         * arm-symbian-tdep.c: Revert.
3887         * arm-pikeos-tdep.c: Revert.
3888         * arm-obsd-tdep.c: Revert.
3889         * arm-nbsd-tdep.c: Revert.
3890         * arm-nbsd-nat.c: Revert.
3891         * arm-linux-tdep.c: Revert.
3892         * arm-linux-nat.c: Revert.
3893         * arm-fbsd-tdep.c: Revert.
3894         * arm-fbsd-nat.c: Revert.
3895         * arm-bsd-tdep.c: Revert.
3896         * arch-utils.c: Revert.
3897         * arc-tdep.c: Revert.
3898         * arc-newlib-tdep.c: Revert.
3899         * annotate.h: Revert.
3900         * annotate.c: Revert.
3901         * amd64-windows-tdep.c: Revert.
3902         * amd64-windows-nat.c: Revert.
3903         * amd64-tdep.c: Revert.
3904         * amd64-sol2-tdep.c: Revert.
3905         * amd64-obsd-tdep.c: Revert.
3906         * amd64-obsd-nat.c: Revert.
3907         * amd64-nbsd-tdep.c: Revert.
3908         * amd64-nbsd-nat.c: Revert.
3909         * amd64-nat.c: Revert.
3910         * amd64-linux-tdep.c: Revert.
3911         * amd64-linux-nat.c: Revert.
3912         * amd64-fbsd-tdep.c: Revert.
3913         * amd64-fbsd-nat.c: Revert.
3914         * amd64-dicos-tdep.c: Revert.
3915         * amd64-darwin-tdep.c: Revert.
3916         * amd64-bsd-nat.c: Revert.
3917         * alpha-tdep.c: Revert.
3918         * alpha-obsd-tdep.c: Revert.
3919         * alpha-nbsd-tdep.c: Revert.
3920         * alpha-mdebug-tdep.c: Revert.
3921         * alpha-linux-tdep.c: Revert.
3922         * alpha-linux-nat.c: Revert.
3923         * alpha-bsd-tdep.c: Revert.
3924         * alpha-bsd-nat.c: Revert.
3925         * aix-thread.c: Revert.
3926         * agent.c: Revert.
3927         * addrmap.c: Revert.
3928         * ada-varobj.c: Revert.
3929         * ada-valprint.c: Revert.
3930         * ada-typeprint.c: Revert.
3931         * ada-tasks.c: Revert.
3932         * ada-lang.c: Revert.
3933         * aarch64-tdep.c: Revert.
3934         * aarch64-ravenscar-thread.c: Revert.
3935         * aarch64-newlib-tdep.c: Revert.
3936         * aarch64-linux-tdep.c: Revert.
3937         * aarch64-linux-nat.c: Revert.
3938         * aarch64-fbsd-tdep.c: Revert.
3939         * aarch64-fbsd-nat.c: Revert.
3940         * aarch32-linux-nat.c: Revert.
3941
3942 2019-04-05  Tom Tromey  <tom@tromey.com>
3943
3944         * ft32-tdep.c: Sort headers.
3945         * frv-tdep.c: Sort headers.
3946         * frv-linux-tdep.c: Sort headers.
3947         * frame.c: Sort headers.
3948         * frame-unwind.c: Sort headers.
3949         * frame-base.c: Sort headers.
3950         * fork-child.c: Sort headers.
3951         * findvar.c: Sort headers.
3952         * findcmd.c: Sort headers.
3953         * filesystem.c: Sort headers.
3954         * filename-seen-cache.h: Sort headers.
3955         * filename-seen-cache.c: Sort headers.
3956         * fbsd-tdep.c: Sort headers.
3957         * fbsd-nat.h: Sort headers.
3958         * fbsd-nat.c: Sort headers.
3959         * f-valprint.c: Sort headers.
3960         * f-typeprint.c: Sort headers.
3961         * f-lang.c: Sort headers.
3962         * extension.h: Sort headers.
3963         * extension.c: Sort headers.
3964         * extension-priv.h: Sort headers.
3965         * expprint.c: Sort headers.
3966         * exec.h: Sort headers.
3967         * exec.c: Sort headers.
3968         * exceptions.c: Sort headers.
3969         * event-top.c: Sort headers.
3970         * event-loop.c: Sort headers.
3971         * eval.c: Sort headers.
3972         * elfread.c: Sort headers.
3973         * dwarf2read.h: Sort headers.
3974         * dwarf2read.c: Sort headers.
3975         * dwarf2loc.c: Sort headers.
3976         * dwarf2expr.h: Sort headers.
3977         * dwarf2expr.c: Sort headers.
3978         * dwarf2-frame.c: Sort headers.
3979         * dwarf2-frame-tailcall.c: Sort headers.
3980         * dwarf-index-write.h: Sort headers.
3981         * dwarf-index-write.c: Sort headers.
3982         * dwarf-index-common.c: Sort headers.
3983         * dwarf-index-cache.h: Sort headers.
3984         * dwarf-index-cache.c: Sort headers.
3985         * dummy-frame.c: Sort headers.
3986         * dtrace-probe.c: Sort headers.
3987         * disasm.h: Sort headers.
3988         * disasm.c: Sort headers.
3989         * disasm-selftests.c: Sort headers.
3990         * dictionary.c: Sort headers.
3991         * dicos-tdep.c: Sort headers.
3992         * demangle.c: Sort headers.
3993         * dcache.h: Sort headers.
3994         * dcache.c: Sort headers.
3995         * darwin-nat.h: Sort headers.
3996         * darwin-nat.c: Sort headers.
3997         * darwin-nat-info.c: Sort headers.
3998         * d-valprint.c: Sort headers.
3999         * d-namespace.c: Sort headers.
4000         * d-lang.c: Sort headers.
4001         * ctf.c: Sort headers.
4002         * csky-tdep.c: Sort headers.
4003         * csky-linux-tdep.c: Sort headers.
4004         * cris-tdep.c: Sort headers.
4005         * cris-linux-tdep.c: Sort headers.
4006         * cp-valprint.c: Sort headers.
4007         * cp-support.c: Sort headers.
4008         * cp-namespace.c: Sort headers.
4009         * cp-abi.c: Sort headers.
4010         * corelow.c: Sort headers.
4011         * corefile.c: Sort headers.
4012         * continuations.c: Sort headers.
4013         * completer.h: Sort headers.
4014         * completer.c: Sort headers.
4015         * complaints.c: Sort headers.
4016         * coffread.c: Sort headers.
4017         * coff-pe-read.c: Sort headers.
4018         * cli-out.h: Sort headers.
4019         * cli-out.c: Sort headers.
4020         * charset.c: Sort headers.
4021         * c-varobj.c: Sort headers.
4022         * c-valprint.c: Sort headers.
4023         * c-typeprint.c: Sort headers.
4024         * c-lang.c: Sort headers.
4025         * buildsym.c: Sort headers.
4026         * buildsym-legacy.c: Sort headers.
4027         * build-id.h: Sort headers.
4028         * build-id.c: Sort headers.
4029         * btrace.c: Sort headers.
4030         * bsd-uthread.c: Sort headers.
4031         * breakpoint.h: Sort headers.
4032         * breakpoint.c: Sort headers.
4033         * break-catch-throw.c: Sort headers.
4034         * break-catch-syscall.c: Sort headers.
4035         * break-catch-sig.c: Sort headers.
4036         * blockframe.c: Sort headers.
4037         * block.c: Sort headers.
4038         * bfin-tdep.c: Sort headers.
4039         * bfin-linux-tdep.c: Sort headers.
4040         * bfd-target.c: Sort headers.
4041         * bcache.c: Sort headers.
4042         * ax-general.c: Sort headers.
4043         * ax-gdb.h: Sort headers.
4044         * ax-gdb.c: Sort headers.
4045         * avr-tdep.c: Sort headers.
4046         * auxv.c: Sort headers.
4047         * auto-load.c: Sort headers.
4048         * arm-wince-tdep.c: Sort headers.
4049         * arm-tdep.c: Sort headers.
4050         * arm-symbian-tdep.c: Sort headers.
4051         * arm-pikeos-tdep.c: Sort headers.
4052         * arm-obsd-tdep.c: Sort headers.
4053         * arm-nbsd-tdep.c: Sort headers.
4054         * arm-nbsd-nat.c: Sort headers.
4055         * arm-linux-tdep.c: Sort headers.
4056         * arm-linux-nat.c: Sort headers.
4057         * arm-fbsd-tdep.c: Sort headers.
4058         * arm-fbsd-nat.c: Sort headers.
4059         * arm-bsd-tdep.c: Sort headers.
4060         * arch-utils.c: Sort headers.
4061         * arc-tdep.c: Sort headers.
4062         * arc-newlib-tdep.c: Sort headers.
4063         * annotate.h: Sort headers.
4064         * annotate.c: Sort headers.
4065         * amd64-windows-tdep.c: Sort headers.
4066         * amd64-windows-nat.c: Sort headers.
4067         * amd64-tdep.c: Sort headers.
4068         * amd64-sol2-tdep.c: Sort headers.
4069         * amd64-obsd-tdep.c: Sort headers.
4070         * amd64-obsd-nat.c: Sort headers.
4071         * amd64-nbsd-tdep.c: Sort headers.
4072         * amd64-nbsd-nat.c: Sort headers.
4073         * amd64-nat.c: Sort headers.
4074         * amd64-linux-tdep.c: Sort headers.
4075         * amd64-linux-nat.c: Sort headers.
4076         * amd64-fbsd-tdep.c: Sort headers.
4077         * amd64-fbsd-nat.c: Sort headers.
4078         * amd64-dicos-tdep.c: Sort headers.
4079         * amd64-darwin-tdep.c: Sort headers.
4080         * amd64-bsd-nat.c: Sort headers.
4081         * alpha-tdep.c: Sort headers.
4082         * alpha-obsd-tdep.c: Sort headers.
4083         * alpha-nbsd-tdep.c: Sort headers.
4084         * alpha-mdebug-tdep.c: Sort headers.
4085         * alpha-linux-tdep.c: Sort headers.
4086         * alpha-linux-nat.c: Sort headers.
4087         * alpha-bsd-tdep.c: Sort headers.
4088         * alpha-bsd-nat.c: Sort headers.
4089         * aix-thread.c: Sort headers.
4090         * agent.c: Sort headers.
4091         * addrmap.c: Sort headers.
4092         * ada-varobj.c: Sort headers.
4093         * ada-valprint.c: Sort headers.
4094         * ada-typeprint.c: Sort headers.
4095         * ada-tasks.c: Sort headers.
4096         * ada-lang.c: Sort headers.
4097         * aarch64-tdep.c: Sort headers.
4098         * aarch64-ravenscar-thread.c: Sort headers.
4099         * aarch64-newlib-tdep.c: Sort headers.
4100         * aarch64-linux-tdep.c: Sort headers.
4101         * aarch64-linux-nat.c: Sort headers.
4102         * aarch64-fbsd-tdep.c: Sort headers.
4103         * aarch64-fbsd-nat.c: Sort headers.
4104         * aarch32-linux-nat.c: Sort headers.
4105
4106 2019-04-04  Tom Tromey  <tom@tromey.com>
4107
4108         * varobj.c (varobj_create): Update.
4109         * rust-exp.y (struct rust_parser) <update_innermost_block,
4110         lookup_symbol>: New methods.
4111         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4112         Rename.
4113         (rust_parser::rust_lookup_type)
4114         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4115         * printcmd.c (display_command, do_one_display): Update.
4116         * parser-defs.h (struct parser_state) <parser_state>: Add
4117         "tracker" parameter.
4118         (block_tracker): New member.
4119         (class innermost_block_tracker) <innermost_block_tracker>: Add
4120         "types" parameter.
4121         <reset>: Remove method.
4122         (innermost_block): Don't declare.
4123         (null_post_parser): Update.
4124         * parse.c (innermost_block): Remove global.
4125         (write_dollar_variable): Update.
4126         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4127         Remove "tracker_types" parameter.
4128         (parse_expression): Add "tracker" parameter.
4129         (parse_expression_for_completion): Update.
4130         (null_post_parser): Add "tracker" parameter.
4131         * p-exp.y: Update rules.
4132         * m2-exp.y: Update rules.
4133         * language.h (struct language_defn) <la_post_parser>: Add
4134         "tracker" parameter.
4135         * go-exp.y: Update rules.
4136         * f-exp.y: Update rules.
4137         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4138         parameter.
4139         * d-exp.y: Update rules.
4140         * c-exp.y: Update rules.
4141         * breakpoint.c (set_breakpoint_condition): Create an
4142         innermost_block_tracker.
4143         (watch_command_1): Likewise.
4144         * ada-lang.c (resolve): Add "tracker" parameter.
4145         (resolve_subexp): Likewise.
4146         * ada-exp.y (write_var_from_sym): Update.
4147
4148 2019-04-04  Tom Tromey  <tom@tromey.com>
4149
4150         * type-stack.h: New file.
4151         * type-stack.c: New file.
4152         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4153         type-stack.h.
4154         (insert_into_type_stack, insert_type, push_type, push_type_int)
4155         (insert_type_address_space, pop_type, pop_type_int)
4156         (pop_typelist, pop_type_stack, append_type_stack)
4157         (push_type_stack, get_type_stack, push_typelist)
4158         (follow_type_instance_flags, follow_types): Don't declare.
4159         * parse.c (type_stack): Remove global.
4160         (parse_exp_in_context): Update.
4161         (insert_into_type_stack, insert_type, push_type, push_type_int)
4162         (insert_type_address_space, pop_type, pop_type_int)
4163         (pop_typelist, pop_type_stack, append_type_stack)
4164         (push_type_stack, get_type_stack, push_typelist)
4165         (follow_type_instance_flags, follow_types): Remove (moved to
4166         type-stack.c).
4167         * f-exp.y (type_stack): New global.
4168         Update rules.
4169         (push_kind_type, f_parse): Update.
4170         * d-exp.y (type_stack): New global.
4171         Update rules.
4172         (d_parse): Update.
4173         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4174         Update rules.
4175         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4176         (HFILES_NO_SRCDIR): Add type-stack.h.
4177
4178 2019-04-04  Tom Tromey  <tom@tromey.com>
4179
4180         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4181         (rust_parser::convert_ast_to_expression, rust_parse)
4182         (rust_lex_test_completion, rust_lex_tests): Update.
4183         * parser-defs.h (struct expr_completion_state): New.
4184         (struct parser_state) <parser_state>: Add completion parameter.
4185         <mark_struct_expression, mark_completion_tag>: New methods.
4186         <parse_completion, m_completion_state>: New members.
4187         (prefixify_expression, null_post_parser): Update.
4188         (mark_struct_expression, mark_completion_tag): Don't declare.
4189         * parse.c (parse_completion, expout_last_struct)
4190         (expout_tag_completion_type, expout_completion_name): Remove
4191         globals.
4192         (parser_state::mark_struct_expression)
4193         (parser_state::mark_completion_tag): Now methods.
4194         (prefixify_expression): Add last_struct parameter.
4195         (prefixify_subexp): Likewise.
4196         (parse_exp_1): Update.
4197         (parse_exp_in_context): Add cstate parameter.  Update.
4198         (parse_expression_for_completion): Create an
4199         expr_completion_state.
4200         (null_post_parser): Add "completion" parameter.
4201         * p-exp.y: Update rules.
4202         (yylex): Update.
4203         * language.h (struct language_defn) <la_post_parser>: Add
4204         "completing" parameter.
4205         * go-exp.y: Update rules.
4206         (lex_one_token): Update.
4207         * expression.h (parse_completion): Don't declare.
4208         * d-exp.y: Update rules.
4209         (lex_one_token): Update rules.
4210         * c-exp.y: Update rules.
4211         (lex_one_token): Update.
4212         * ada-lang.c (resolve): Add "parse_completion" parameter.
4213         (resolve_subexp): Likewise.
4214         (ada_resolve_function): Likewise.
4215
4216 2019-04-04  Tom Tromey  <tom@tromey.com>
4217
4218         * parser-defs.h (struct parser_state) <start_arglist,
4219         end_arglist>: New methods.
4220         <arglist_len, m_funcall_chain>: New members.
4221         (arglist_len, start_arglist, end_arglist): Don't declare.
4222         * parse.c (arglist_len, funcall_chain): Remove global.
4223         (start_arglist, end_arglist): Remove functions.
4224         (parse_exp_in_context): Update.
4225         * p-exp.y: Update rules.
4226         * m2-exp.y: Update rules.
4227         * go-exp.y: Update rules.
4228         * f-exp.y: Update rules.
4229         * d-exp.y: Update rules.
4230         * c-exp.y: Update rules.
4231
4232 2019-04-04  Tom Tromey  <tom@tromey.com>
4233
4234         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4235         lex_operator, push_back>: New methods.
4236         Update all rules.
4237         (rust_parser::lex_hex, lex_escape): Rename and update.
4238         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4239         (rust_parser::lex_operator): Rename and update.
4240         (rust_parser::lex_number, rustyylex, rustyyerror)
4241         (rust_lex_test_init, rust_lex_test_sequence)
4242         (rust_lex_test_push_back, rust_lex_tests): Update.
4243         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4244         parameter.
4245         <lexptr, prev_lexptr>: New members.
4246         (lexptr, prev_lexptr): Don't declare.
4247         * parse.c (lexptr, prev_lexptr): Remove globals.
4248         (parse_exp_in_context): Update.
4249         * p-exp.y (yylex, yyerror): Update.
4250         * m2-exp.y (parse_number, yylex, yyerror): Update.
4251         * go-exp.y (lex_one_token, yyerror): Update.
4252         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4253         * d-exp.y (lex_one_token, yyerror): Update.
4254         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4255         (lex_one_token, yyerror): Update.
4256         * ada-lex.l (YY_INPUT): Update.
4257         (rewind_to_char): Update.
4258         * ada-exp.y (yyerror): Update.
4259
4260 2019-04-04  Tom Tromey  <tom@tromey.com>
4261
4262         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4263         * parser-defs.h (struct parser_state) <parser_state>: Add new
4264         parameter.
4265         <comma_terminates>: New member.
4266         (comma_terminates): Don't declare global.
4267         * parse.c (comma_terminates): Remove global.
4268         (parse_exp_in_context): Update.
4269         * p-exp.y (yylex): Update.
4270         * m2-exp.y (yylex): Update.
4271         * go-exp.y (lex_one_token): Update.
4272         * f-exp.y (yylex): Update.
4273         * d-exp.y (lex_one_token): Update.
4274         * c-exp.y (lex_one_token): Update.
4275         * ada-lex.l: Update.
4276
4277 2019-04-04  Tom Tromey  <tom@tromey.com>
4278
4279         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4280         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4281         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4282         * parser-defs.h (paren_depth): Don't declare.
4283         * parse.c (paren_depth): Remove global.
4284         (parse_exp_in_context): Update.
4285         * p-exp.y (paren_depth): New global.
4286         (pascal_parse): Initialize it.
4287         * m2-exp.y (paren_depth): New global.
4288         (m2_parse): Initialize it.
4289         * go-exp.y (paren_depth): New global.
4290         (go_parse): Initialize it.
4291         * f-exp.y (paren_depth): New global.
4292         (f_parse): Initialize it.
4293         * d-exp.y (paren_depth): New global.
4294         (d_parse): Initialize it.
4295         * c-exp.y (paren_depth): New global.
4296         (c_parse): Initialize it.
4297         * ada-lex.l (paren_depth): New global.
4298         (lexer_init): Initialize it.
4299
4300 2019-04-04  Tom Tromey  <tom@tromey.com>
4301
4302         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4303         (rust_parser::convert_ast_to_type)
4304         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4305         * parser-defs.h (struct parser_state) <parser_state>: Add
4306         parameters.  Initialize new members.
4307         <expression_context_block, expression_context_pc>: New members.
4308         * parse.c (expression_context_block, expression_context_pc):
4309         Remove globals.
4310         (parse_exp_in_context): Update.
4311         * p-exp.y: Update all rules.
4312         (yylex): Update.
4313         * m2-exp.y: Update all rules.
4314         (yylex): Update.
4315         * go-exp.y (yylex): Update.
4316         * f-exp.y (yylex): Update.
4317         * d-exp.y: Update all rules.
4318         (yylex): Update.
4319         * c-exp.y: Update all rules.
4320         (lex_one_token, classify_name, yylex, c_parse): Update.
4321         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4322
4323 2019-04-04  Tom Tromey  <tom@tromey.com>
4324
4325         * gdbarch.h, gdbarch.c: Rebuild.
4326         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4327         * stap-probe.h:
4328         (struct stap_parse_info): Replace "parser_state" with
4329         "expr_builder".
4330         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4331         (parser_state): New class.
4332         * parse.c (expr_builder): Rename.
4333         (expr_builder::release): Rename.
4334         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4335         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4336         (write_exp_elt_longcst, write_exp_elt_floatcst)
4337         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4338         (write_exp_string_vector, write_exp_bitstring)
4339         (write_exp_msymbol, mark_struct_expression)
4340         (write_dollar_variable)
4341         (insert_type_address_space, increase_expout_size): Replace
4342         "parser_state" with "expr_builder".
4343         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4344         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4345         "parser_state" with "expr_builder".
4346
4347 2019-04-04  Tom Tromey  <tom@tromey.com>
4348
4349         * rust-exp.y: Replace "parse_language" with method call.
4350         * p-exp.y:
4351         (yylex): Replace "parse_language" with method call.
4352         * m2-exp.y:
4353         (yylex): Replace "parse_language" with method call.
4354         * go-exp.y (classify_name): Replace "parse_language" with method
4355         call.
4356         * f-exp.y (yylex): Replace "parse_language" with method call.
4357         * d-exp.y (lex_one_token): Replace "parse_language" with method
4358         call.
4359         * c-exp.y:
4360         (lex_one_token, classify_name, yylex): Replace "parse_language"
4361         with method call.
4362         * ada-exp.y (find_primitive_type, type_char)
4363         (type_system_address): Replace "parse_language" with method call.
4364
4365 2019-04-04  Tom Tromey  <tom@tromey.com>
4366
4367         * rust-exp.y: Replace "parse_gdbarch" with method call.
4368         * parse.c (write_dollar_variable, insert_type_address_space):
4369         Replace "parse_gdbarch" with method call.
4370         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4371         call.
4372         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4373         call.
4374         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4375         "parse_gdbarch" with method call.
4376         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4377         with method call.
4378         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4379         "parse_gdbarch" with method call.
4380         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4381         "parse_gdbarch" with method call.
4382         * c-exp.y (parse_type, parse_number, classify_name): Replace
4383         "parse_gdbarch" with method call.
4384         * ada-lex.l: Replace "parse_gdbarch" with method call.
4385         * ada-exp.y (parse_type, find_primitive_type, type_char)
4386         (type_system_address): Replace "parse_gdbarch" with method call.
4387
4388 2019-04-04  Tom Tromey  <tom@tromey.com>
4389
4390         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4391         * stap-probe.c (stap_parse_argument): Update.
4392         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4393         initial_size parameter.
4394         * rust-exp.y (rust_lex_tests): Update.
4395         * parse.c (parser_state): Update.
4396         (parse_exp_in_context): Update.
4397         * parser-defs.h (struct parser_state) <parser_state>: Remove
4398         "initial_size" parameter.
4399
4400 2019-04-04  Tom Tromey  <tom@tromey.com>
4401
4402         * parser-defs.h (increase_expout_size): Don't declare.
4403         * parse.c (increase_expout_size): Now static.
4404
4405 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4406
4407         * gnu-nat.c (gnu_nat_target::wait): Fix
4408         target_waitstatus_to_string call.
4409
4410 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4411
4412         * eval.c (evaluate_subexp_standard): Handle internal functions
4413         during Fortran function call handling.
4414
4415 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4416
4417         * NEWS: Mention new internal functions.
4418         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4419         (read_base_type): Use dwarf2_init_complex_target_type.
4420         * value.c (creal_internal_fn): New function.
4421         (cimag_internal_fn): New function.
4422         (_initialize_values): Register new internal functions.
4423
4424 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4425
4426         * infrun.c (stop_all_threads): If debug_infrun, always
4427         trace the wait status after wait_one, using
4428         target_waitstatus_to_string and target_pid_to_str.
4429         (handle_inferior_event): Replace various trace of
4430         wait status kind by a single trace.
4431         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4432         wait status kind image by target_waitstatus_to_string.
4433         * target/waitstatus.c (target_waitstatus_to_string): Fix
4434         obsolete comment.
4435
4436 2019-04-01  Tom Tromey  <tromey@adacore.com>
4437
4438         PR symtab/23331:
4439         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4440
4441 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4442             Pedro Alves  <palves@redhat.com>
4443
4444         * top.c (quit_force): Call 'finalize_values'.
4445         * value.c (finalize_values): New function.
4446         * value.h (finalize_values): Declare.
4447
4448 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4449
4450         * NEWS: Announce $_gdb_major and $_gdb_minor.
4451
4452         * top.c (init_gdb_version_vars): New function.
4453         (gdb_init): Call init_gdb_version_vars.
4454
4455 2019-03-29  Tom Tromey  <tromey@adacore.com>
4456
4457         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4458         help text.  Remove dead code.
4459
4460 2019-03-29  Keith Seitz  <keiths@redhat.com>
4461
4462         From Siddhesh Poyarekar:
4463         * f-lang.h (f77_get_upperbound): Return LONGEST.
4464         (f77_get_lowerbound): Likewise.
4465         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4466         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4467         print them.
4468         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4469         plongest to format print it.
4470         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4471         (f77_get_upperbound): Likewise.
4472         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4473         LOWER_BOUND to LONGEST.
4474         (f77_create_arrayprint_offset_tbl): Likewise.
4475
4476 2019-03-29  Keith Seitz  <keiths@redhat.com>
4477
4478         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4479         %s/pulongest for TYPE_LENGTH instead of %d in format
4480         strings.
4481         * ada-typerint.c (ada_print_type): Likewise.
4482         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4483         * compile/compile-c-support.c (generate_register_struct): Likewise.
4484         * gdbtypes.c (recursive_dump_type): Likewise.
4485         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4486         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4487         instead of %d in format strings.
4488         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4489         to std::min to ULONGEST.
4490         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4491         instead of %d in format strings.
4492         * tracepoint.c (info_scope_command): Likewise.
4493         * typeprint.c (print_offset_data::update)
4494         (print_offset_data::finish): Likewise.
4495         * xtensa-tdep.c (xtensa_store_return_value)
4496         (xtensa_push_dummy_call): Likewise.
4497
4498 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4499
4500         * windows-nat.c (display_selector): Fixed format specifications
4501         for 64-bit Cygwin.
4502
4503 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4504
4505         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4506
4507 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4508
4509         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4510         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4511         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4512         (nios2_linux_init_abi): Install it.
4513
4514 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4515
4516         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4517
4518 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4519
4520         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4521
4522 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4523             Tom Tromey  <tromey@adacore.com>
4524
4525         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4526
4527 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4528
4529         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4530         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4531         method to compute the bounds of range types. Also print "[evaluated]"
4532         if the bounds' values come from a dynamic evaluation.
4533
4534 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4537         whitespace when pretty printing is on.
4538
4539 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4540
4541         * ppc-linux-nat.c: Add include.
4542
4543 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4544
4545         * NEWS: Mention AArch64 Pointer Authentication.
4546
4547 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4548
4549         * arm-linux-nat.c: Add include.
4550
4551 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4552
4553         * source-cache.c (source_cache::get_source_lines): Re-read
4554         fullname after calling open_source_file.
4555
4556 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4557
4558         * NEWS: Mention TLS support for FreeBSD.
4559
4560 2019-03-25  Tom Tromey  <tromey@adacore.com>
4561
4562         * minsyms.c (BUNCH_SIZE): Update comment.
4563         (~minimal_symbol_reader): Remove old comment.
4564         (compact_minimal_symbols): Update comment.
4565         (minimal_symbol_reader::install): Remove old comment.  Update
4566         other comments.
4567
4568 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4569
4570         * s390-linux-nat.c: Add include.
4571
4572 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4573
4574         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4575         Call linux_get_hwcap.
4576         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4577         Likewise.
4578         (aarch64_linux_get_hwcap): Remove function.
4579         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4580         declaration.
4581         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4582         linux_get_hwcap.
4583         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4584         * linux-tdep.c (linux_get_hwcap): Add function.
4585         (linux_get_hwcap2): Likewise.
4586         * linux-tdep.h (linux_get_hwcap): Add declaration.
4587         (linux_get_hwcap2): Likewise.
4588         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4589         (ppc_linux_get_hwcap2): Likewise.
4590         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4591         linux_get_hwcap.
4592         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4593         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4594         (ppc_linux_nat_target::read_description): Likewise.
4595         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4596         * s390-linux-nat.c: Likewise.
4597         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4598
4599 2019-03-24  Tom Tromey  <tom@tromey.com>
4600
4601         * ada-lang.c (standard_lookup): Simplify initialization.
4602         (ada_lookup_symbol_nonlocal): Simplify return.
4603         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4604         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4605         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4606         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4607         initialization.
4608         * solib.c (solib_global_lookup): Simplify.
4609         * symtab.c (null_block_symbol): Remove.
4610         (symbol_cache_lookup): Simplify returns.
4611         (lookup_language_this): Simplify returns.
4612         (lookup_symbol_aux): Simplify return.
4613         (lookup_local_symbol): Simplify returns.
4614         (lookup_global_symbol_from_objfile): Simplify return.
4615         (lookup_symbol_in_objfile_symtabs)
4616         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4617         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4618         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4619         * cp-namespace.c (cp_lookup_bare_symbol)
4620         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4621         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4622         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4623         (cp_lookup_symbol_via_imports): Simplify initialization.
4624         (find_symbol_in_baseclass): Likewise.
4625         * symtab.h (null_block_symbol): Remove.
4626         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4627         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4628         (d_lookup_symbol_module): Likewise.
4629         (find_symbol_in_baseclass): Simplify initialization.
4630
4631 2019-03-24  Tom Tromey  <tom@tromey.com>
4632
4633         * expression.h: Don't include symtab.h.
4634         (struct block): Forward declare.
4635
4636 2019-03-24  Tom Tromey  <tom@tromey.com>
4637
4638         * c-exp.y (typebase): Remove casts.
4639         * gdbtypes.c (lookup_unsigned_typename, )
4640         (lookup_signed_typename): Remove cast.
4641         * eval.c (parse_to_comma_and_eval): Remove cast.
4642         * parse.c (write_dollar_variable): Remove cast.
4643         * block.h (struct block) <superblock>: Now const.
4644         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4645         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4646         (map_block): Make "block" const.
4647         * symfile.h (struct quick_symbol_functions)
4648         <map_matching_symbols>: Constify block argument to "callback".
4649         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4650         const.
4651         (find_pc_sect_compunit_symtab): Make "b" const.
4652         (find_symbol_at_address): Likewise.
4653         (search_symbols): Likewise.
4654         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4655         (dw2_debug_names_lookup_symbol): Likewise.
4656         (dw2_map_matching_symbols): Update.
4657         * p-valprint.c (pascal_val_print): Remove "block".
4658         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4659         (aux_add_nonlocal_symbols): Make "block" const.
4660         (resolve_subexp): Remove cast.
4661         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4662         const.
4663         (iterate_over_file_blocks): Likewise.
4664         * f-exp.y (%union) <bval>: Remove.
4665         * coffread.c (patch_opaque_types): Make "b" const.
4666         * spu-tdep.c (spu_catch_start): Make "block" const.
4667         * c-valprint.c (print_unpacked_pointer): Remove "block".
4668         * symmisc.c (dump_symtab_1): Make "b" const.
4669         (block_depth): Make "block" const.
4670         * d-exp.y (%union) <bval>: Remove.
4671         * cp-support.h (cp_lookup_rtti_type): Update.
4672         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4673         * psymtab.c (psym_lookup_symbol): Make "block" const.
4674         (maintenance_check_psymtabs): Make "b" const.
4675         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4676         (enumerate_locals, enumerate_args): Update.
4677         * python/py-symtab.c (stpy_global_block): Make "block" const.
4678         (stpy_static_block): Likewise.
4679         * inline-frame.c (block_starting_point_at): Make "new_block"
4680         const.
4681         * block.c (find_block_in_blockvector): Make return type const.
4682         (blockvector_for_pc_sect): Make "b" const.
4683         (find_block_in_blockvector): Make "b" const.
4684
4685 2019-03-23  Tom Tromey  <tom@tromey.com>
4686
4687         * varobj.c (varobj_create): Update.
4688         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4689         * printcmd.c (display_command, do_one_display): Don't reset
4690         innermost_block.
4691         * parser-defs.h (enum innermost_block_tracker_type): Move to
4692         expression.h.
4693         (innermost_block): Update comment.
4694         * parse.c (parse_exp_1): Add tracker_types parameter.
4695         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4696         tracker_types parameter.  Reset innermost_block.
4697         (parse_exp_in_context): Remove.
4698         (parse_expression_for_completion): Update.
4699         * objfiles.c (~objfile): Don't reset expression_context_block or
4700         innermost_block.
4701         * expression.h (enum innermost_block_tracker_type): Move from
4702         parser-defs.h.
4703         (parse_exp_1): Add tracker_types parameter.
4704         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4705         reset innermost_block.
4706
4707 2019-03-23  Tom Tromey  <tom@tromey.com>
4708
4709         * objfiles.h: Include bcache.h.
4710
4711 2019-03-23  Tom Tromey  <tom@tromey.com>
4712
4713         * linespec.c (get_current_search_block): Use
4714         scoped_restore_current_language.
4715         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4716
4717 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4718             Jiong Wang  <jiong.wang@arm.com>
4719
4720         * aarch64-linux-tdep.c
4721         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4722         section.
4723         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4724
4725 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4726             Jiong Wang  <jiong.wang@arm.com>
4727
4728         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4729         instructions.
4730         (aarch64_analyze_prologue_test): Add PACIASP test.
4731         (aarch64_prologue_prev_register): Unmask PC value.
4732
4733 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4734             Jiong Wang  <jiong.wang@arm.com>
4735
4736         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4737         (aarch64_dwarf2_prev_register): Unmask PC value.
4738         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4739         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4740         DW_CFA_AARCH64_negate_ra_state.
4741         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4742
4743 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4744             Jiong Wang  <jiong.wang@arm.com>
4745
4746         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4747         registers.
4748         (aarch64_pseudo_register_name): Likewise.
4749         (aarch64_pseudo_register_type): Likewise.
4750         (aarch64_pseudo_register_reggroup_p): Likewise.
4751         (aarch64_gdbarch_init): Add pauth registers.
4752         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4753         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4754         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4755         (struct gdbarch_tdep): Add regnum for ra_state.
4756
4757 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4758             Jiong Wang  <jiong.wang@arm.com>
4759
4760         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4761
4762 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4763             Jiong Wang  <jiong.wang@arm.com>
4764
4765         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4766         function.
4767         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4768         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4769         (aarch64_gdbarch_init): Add puth registers.
4770         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4771         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4772         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4773
4774 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4775             Jiong Wang  <jiong.wang@arm.com>
4776
4777         * aarch64-linux-nat.c
4778         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4779         * aarch64-linux-tdep.c
4780         (aarch64_linux_core_read_description): Likewise.
4781         (aarch64_linux_get_hwcap): New function.
4782         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4783         (aarch64_linux_get_hwcap): New declaration.
4784
4785 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4786             Jiong Wang  <jiong.wang@arm.com>
4787
4788         * aarch64-linux-nat.c
4789         (aarch64_linux_nat_target::read_description): Add pauth param.
4790         * aarch64-linux-tdep.c
4791         (aarch64_linux_core_read_description): Likewise.
4792         * aarch64-tdep.c (struct target_desc): Add in pauth.
4793         (aarch64_read_description): Add pauth param.
4794         (aarch64_gdbarch_init): Likewise.
4795         * aarch64-tdep.h (aarch64_read_description): Likewise.
4796         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4797         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4798         * features/Makefile: Add new files.
4799         * features/aarch64-pauth.c: New file.
4800         * features/aarch64-pauth.xml: New file.
4801
4802 2019-03-20  Tom Tromey  <tromey@adacore.com>
4803
4804         * infrun.c (handle_inferior_event): Rename from
4805         handle_inferior_event_1.  Create a scoped_value_mark.
4806         (handle_inferior_event): Remove.
4807
4808 2019-03-19  Tom Tromey  <tromey@adacore.com>
4809
4810         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4811         * infrun.h (print_stop_event): Add "displays" parameter.
4812         * infrun.c (print_stop_event): Add "displays" parameter.
4813
4814 2019-03-19  Pedro Alves  <palves@redhat.com>
4815
4816         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4817         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4818         to -1.  Fix TABs vs spaces.
4819         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4820         * tui/tui-out.h (tui_ui_out) Add intro comments.
4821         <m_line, m_start_of_line>: In-class initialize, and add describing
4822         comment.
4823
4824 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4825
4826         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4827         variable names.
4828         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4829
4830 2019-03-18  Pedro Alves  <palves@redhat.com>
4831             Eli Zaretskii <eliz@gnu.org>
4832
4833         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4834         m_line and m_start_of_line.
4835
4836 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4837
4838         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4839         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4840         it returns a newline.  This fixes a regression in TU mode, whereby
4841         the next line is output on the same screen line as the user input.
4842
4843 2019-03-18  Tom Tromey  <tromey@adacore.com>
4844
4845         * minsyms.c (minimal_symbol_reader::install): Remove call to
4846         obstack_blank.
4847
4848 2019-03-18  Pedro Alves  <palves@redhat.com>
4849
4850         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4851         New globals.
4852         (apply_style): New, factored out from ...
4853         (apply_ansi_escape): ... this.  Handle reverse video mode.
4854         (tui_set_reverse_mode): New function.
4855         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4856         * tui/tui-winsource.c (tui_show_source_line): Use
4857         tui_set_reverse_mode instead of setting A_STANDOUT.
4858         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4859         New setter methods.
4860
4861 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4862
4863         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4864         Handle tabs.
4865
4866 2019-03-18  Tom Tromey  <tromey@adacore.com>
4867
4868         * ada-lang.c (empty_array): Add "high" parameter.
4869         (ada_evaluate_subexp): Update.
4870
4871 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4872
4873         * unittests/string_view-selftests.c: Define
4874         _initialize_string_view_selftests unconditionally.
4875
4876 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4877
4878         PR gdb/24350
4879         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4880
4881 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4882
4883         PR gdb/24351
4884         * windows-nat.c (display_selector): Fix format specifiers.
4885
4886 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4887
4888         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4889         tui_refill_source_window instead of tui_refresh_win, to update the
4890         current execution line.  This fixes redisplay of the current line
4891         when stepping through the code with "next" or "step".
4892
4893 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4894
4895         * source-cache.c (source_cache::get_source_lines): Call
4896         find_source_lines to initialize s->nlines.  This fixes vertical
4897         scrolling of TUI source window when the DOWN arrow is pressed.
4898
4899 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4900
4901         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4902         linux-thread-db.c (_initialize_thread_db): Likewise.
4903
4904 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4905
4906         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4907         wclrtoeol in tui_show_source_line".  This reverts changes made in
4908         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4909
4910 2019-03-15  Tom Tromey  <tom@tromey.com>
4911
4912         * symtab.h (struct minimal_symbol): Derive from
4913         general_symbol_info.
4914         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4915         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4916         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4917         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4918         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4919         (MSYMBOL_SEARCH_NAME): Update.
4920         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4921         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4922         * minsyms.c (minimal_symbol_reader::record_full): Update.
4923
4924 2019-03-15  Tom Tromey  <tom@tromey.com>
4925
4926         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4927
4928 2019-03-15  Tom Tromey  <tom@tromey.com>
4929
4930         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4931         unique_xmalloc_ptr.
4932         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4933         Update.
4934         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4935         (build_minimal_symbol_hash_tables)
4936         (minimal_symbol_reader::install): Update.
4937
4938 2019-03-15  Tom Tromey  <tom@tromey.com>
4939
4940         * symtab.c (create_demangled_names_hash): Update.
4941         (symbol_set_names): Update.
4942         * objfiles.h (struct objfile_per_bfd_storage)
4943         <demangled_names_hash>: Now an htab_up.
4944         * objfiles.c (objfile_per_bfd_storage): Simplify.
4945
4946 2019-03-15  Tom Tromey  <tom@tromey.com>
4947
4948         * objfiles.h (struct objfile_per_bfd_storage): Declare
4949         destructor.
4950         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4951         New.
4952         (get_objfile_bfd_data): Use new.  Don't initialize
4953         language_of_main.
4954         (free_objfile_per_bfd_storage): Remove.
4955         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4956
4957 2019-03-15  Tom Tromey  <tom@tromey.com>
4958
4959         * symfile.c (reread_symbols): Update.
4960         * objfiles.c (objfile::objfile): Update.
4961         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4962         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4963         comment.
4964         (minimal_symbol_reader::install): Update.
4965         (terminate_minimal_symbol_table): Remove.
4966         * jit.c (jit_object_close_impl): Update.
4967
4968 2019-03-15  Tom Tromey  <tom@tromey.com>
4969
4970         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4971         initializations.
4972
4973 2019-03-15  Tom Tromey  <tom@tromey.com>
4974
4975         * objfiles.h (struct objfile_per_bfd_storage)
4976         <demangled_hash_languages>: Now a bitset.
4977         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4978         (lookup_minimal_symbol): Update.
4979
4980 2019-03-15  Tom Tromey  <tom@tromey.com>
4981
4982         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4983         Don't return the symbol.
4984         * coffread.c (record_minimal_symbol): Use record_full.
4985
4986 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4987
4988         The MS-Windows port of ncurses fails to switch to a color pair if
4989         one or both of the colors are the implicit default colors.  This
4990         change records the default colors when TUI is initialized, and
4991         then specifies them explicitly when a color pair uses the default
4992         colors.  This allows color styling in TUI mode on MS-Windows.
4993
4994         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4995         ncurses_norm_attr.
4996         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4997         colors in ncurses_norm_attr.
4998         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4999         "none", replace it with the default color recorded in
5000         ncurses_norm_attr.
5001
5002 2019-03-14  Tom Tromey  <tromey@adacore.com>
5003
5004         * source-cache.h (class source_cache) <get_source_lines>: Return
5005         std::string.
5006         * source-cache.c (source_cache::extract_lines): Handle case where
5007         first_pos==npos.  Return std::string.
5008         (source_cache::get_source_lines): Update.
5009
5010 2019-03-14  Tom Tromey  <tromey@adacore.com>
5011
5012         * NEWS: Add item for "style sources" commands.
5013         * source-cache.c (source_cache::get_source_lines): Check
5014         source_styling.
5015         * cli/cli-style.c (source_styling): New global.
5016         (_initialize_cli_style): Add "style sources" commands.
5017         (show_style_sources): New function.
5018         * cli/cli-style.h (source_styling): Declare.
5019
5020 2019-03-14  Pedro Alves  <palves@redhat.com>
5021             Tom Tromey  <tromey@adacore.com>
5022
5023         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5024         * tui/tui-winsource.c (tui_refill_source_window): New function,
5025         from...
5026         (tui_horizontal_source_scroll): ... here.  Move some logic.
5027         * cli/cli-style.c (set_style_enabled): Notify new observable.
5028         * tui/tui-hooks.c (tui_redisplay_source): New function.
5029         (tui_attach_detach_observers): Attach or detach
5030         tui_redisplay_source.
5031         * observable.h (source_styling_changed): New observable.
5032         * observable.c: Define source_styling_changed observable.
5033
5034 2019-03-13  Tom Tromey  <tromey@adacore.com>
5035
5036         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5037         (i386_gnu_nat_target::store_registers): Update.
5038         * target-debug.h (target_debug_print_std_string): New macro.
5039         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5040         * windows-tdep.c (display_one_tib): Update.
5041         * tui/tui-stack.c (tui_make_status_line): Update.
5042         * top.c (print_inferior_quit_action): Update.
5043         * thread.c (thr_try_catch_cmd): Update.
5044         (add_thread_with_info): Update.
5045         (thread_target_id_str): Update.
5046         (thr_try_catch_cmd): Update.
5047         (thread_command): Update.
5048         (thread_find_command): Update.
5049         * record-btrace.c (record_btrace_target::info_record)
5050         (record_btrace_resume_thread, record_btrace_target::resume)
5051         (record_btrace_cancel_resume, record_btrace_step_thread)
5052         (record_btrace_target::wait, record_btrace_target::wait)
5053         (record_btrace_target::wait, record_btrace_target::stop): Update.
5054         * progspace.c (print_program_space): Update.
5055         * process-stratum-target.c
5056         (process_stratum_target::thread_address_space): Update.
5057         * linux-fork.c (linux_fork_mourn_inferior)
5058         (detach_checkpoint_command, info_checkpoints_command)
5059         (linux_fork_context): Update.
5060         (linux_fork_detach): Update.
5061         (class scoped_switch_fork_info): Update.
5062         (delete_checkpoint_command): Update.
5063         * infrun.c (follow_fork_inferior): Update.
5064         (follow_fork_inferior): Update.
5065         (proceed_after_vfork_done): Update.
5066         (handle_vfork_child_exec_or_exit): Update.
5067         (follow_exec): Update.
5068         (displaced_step_prepare_throw): Update.
5069         (displaced_step_restore): Update.
5070         (start_step_over): Update.
5071         (resume_1): Update.
5072         (clear_proceed_status_thread): Update.
5073         (proceed): Update.
5074         (print_target_wait_results): Update.
5075         (do_target_wait): Update.
5076         (context_switch): Update.
5077         (stop_all_threads): Update.
5078         (restart_threads): Update.
5079         (finish_step_over): Update.
5080         (handle_signal_stop): Update.
5081         (switch_back_to_stepped_thread): Update.
5082         (keep_going_pass_signal): Update.
5083         (print_exited_reason): Update.
5084         (normal_stop): Update.
5085         * inferior.c (inferior_pid_to_str): Change return type.
5086         (print_selected_inferior): Update.
5087         (add_inferior): Update.
5088         (detach_inferior): Update.
5089         * dummy-frame.c (fprint_dummy_frames): Update.
5090         * dcache.c (dcache_info_1): Update.
5091         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5092         (btrace_fetch, btrace_clear): Update.
5093         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5094         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5095         type.
5096         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5097         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5098         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5099         * gdbarch.c, gdbarch.h: Rebuild.
5100         * gdbarch.sh (core_pid_to_str): Change return type.
5101         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5102         return type.
5103         (windows_nat_target::pid_to_str): Change return type.
5104         (windows_delete_thread): Update.
5105         (windows_nat_target::attach): Update.
5106         (windows_nat_target::files_info): Update.
5107         * target-delegates.c: Rebuild.
5108         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5109         return type.
5110         (sol_thread_target::pid_to_str): Change return type.
5111         * remote.c (class remote_target) <pid_to_str>: Change return
5112         type.
5113         (remote_target::pid_to_str): Change return type.
5114         (extended_remote_target::attach, remote_target::remote_stop_ns)
5115         (remote_target::remote_notif_remove_queued_reply)
5116         (remote_target::push_stop_reply, remote_target::disable_btrace):
5117         Update.
5118         (extended_remote_target::attach): Update.
5119         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5120         type.
5121         (gdbsim_target::pid_to_str): Change return type.
5122         * ravenscar-thread.c (struct ravenscar_thread_target)
5123         <pid_to_str>: Change return type.
5124         (ravenscar_thread_target::pid_to_str): Change return type.
5125         * procfs.c (class procfs_target) <pid_to_str>: Change return
5126         type.
5127         (procfs_target::pid_to_str): Change return type.
5128         (procfs_target::attach): Update.
5129         (procfs_target::detach): Update.
5130         (procfs_target::fetch_registers): Update.
5131         (procfs_target::store_registers): Update.
5132         (procfs_target::wait): Update.
5133         (procfs_target::files_info): Update.
5134         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5135         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5136         return type.
5137         (nto_procfs_target::pid_to_str): Change return type.
5138         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5139         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5140         return type.
5141         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5142         (exit_lwp): Update.
5143         (attach_proc_task_lwp_callback, get_detach_signal)
5144         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5145         (linux_nat_target::resume, wait_lwp, stop_callback)
5146         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5147         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5148         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5149         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5150         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5151         type.
5152         (inf_ptrace_target::attach): Update.
5153         (inf_ptrace_target::files_info): Update.
5154         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5155         type.
5156         (go32_nat_target::pid_to_str): Change return type.
5157         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5158         (gnu_nat_target::wait): Update.
5159         (gnu_nat_target::wait): Update.
5160         (gnu_nat_target::resume): Update.
5161         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5162         (fbsd_nat_target::wait): Update.
5163         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5164         type.
5165         (darwin_nat_target::attach): Update.
5166         * corelow.c (class core_target) <pid_to_str>: Change return type.
5167         (core_target::pid_to_str): Change return type.
5168         * target.c (normal_pid_to_str): Change return type.
5169         (default_pid_to_str): Likewise.
5170         (target_pid_to_str): Change return type.
5171         (target_translate_tls_address): Update.
5172         (target_announce_detach): Update.
5173         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5174         return type.
5175         (bsd_uthread_target::pid_to_str): Change return type.
5176         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5177         type.
5178         (bsd_kvm_target::pid_to_str): Change return type.
5179         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5180         return type.
5181         (aix_thread_target::pid_to_str): Change return type.
5182         * target.h (struct target_ops) <pid_to_str>: Change return type.
5183         (target_pid_to_str, normal_pid_to_str): Likewise.
5184         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5185         type.
5186         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5187         type.
5188         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5189         return type.
5190         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5191         type.
5192         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5193         type.
5194         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5195         return type.
5196
5197 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5198
5199         * NEWS: Mention that the new default MI version is 3.  Mention
5200         changes to the output of commands and events that deal with
5201         multi-location breakpoints.
5202         * breakpoint.c: Include "mi/mi-out.h".
5203         (print_one_breakpoint): Change output syntax if using MI version
5204         >= 3.
5205         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5206         New.
5207         (mi_multi_location_breakpoint_output_fixed): New.
5208         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5209         (mi_cmd_fix_multi_location_breakpoint_output): New.
5210         (mi_multi_location_breakpoint_output_fixed): New.
5211         * mi/mi-cmds.c (mi_cmds): Register command
5212         -fix-multi-location-breakpoint-output.
5213         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5214         interpreter "mi".
5215
5216 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5217
5218         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5219         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5220         instantiate mi_ui_out based on interpreter name.
5221         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5222         * mi/mi-main.c (mi_load_progress): Likewise.
5223
5224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5225
5226         * NEWS: Combine separate "New targets" sections for 8.3.
5227
5228 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5229
5230         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5231         (ppcfbsd_init_abi): Install gdbarch
5232         "fetch_tls_load_module_address" and "get_thread_local_address"
5233         methods.
5234
5235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5236
5237         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5238         (riscv_fbsd_init_abi): Install gdbarch
5239         "fetch_tls_load_module_address" and "get_thread_local_address"
5240         methods.
5241
5242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5243
5244         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5245         (i386fbsd_init_abi): Install gdbarch
5246         "fetch_tls_load_module_address" and "get_thread_local_address"
5247         methods.
5248
5249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5250
5251         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5252         (amd64fbsd_init_abi): Install gdbarch
5253         "fetch_tls_load_module_address" and "get_thread_local_address"
5254         methods.
5255
5256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5257
5258         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5259         (struct fbsd_pspace_data): New type.
5260         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5261         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5262         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5263         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5264         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5265
5266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5267
5268         * gdbtypes.c (lookup_struct_elt): New function.
5269         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5270         * gdbtypes.h (struct struct_elt): New type.
5271         (lookup_struct_elt): New prototype.
5272
5273 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5274
5275         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5276         remove disabled code block.
5277
5278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5279
5280         * gdbarch.sh (get_thread_local_address): New method.
5281         * gdbarch.h, gdbarch.c: Regenerate.
5282         * target.c (target_translate_tls_address): Use
5283         gdbarch_get_thread_local_address if present instead of
5284         target::get_thread_local_address.
5285
5286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5287
5288         * target.h (target::get_thread_local_address): Update comment.
5289
5290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5291
5292         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5293         objfile->separate_debug_objfile_backlink if not NULL.
5294
5295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5296
5297         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5298         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5299         (amd64bsd_store_inferior_registers): Likewise.
5300         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5301         Enable segment base registers.
5302         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5303         PT_GETFSBASE and PT_GETGSBASE.
5304         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5305         PT_SETGSBASE.
5306         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5307         segment base registers.
5308         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5309
5310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5311
5312         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5313         Update calls to i386_target_description to add 'segments'
5314         parameter.
5315         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5316         add segment base registers.
5317         * arch/i386.c (i386_create_target_description): Add 'segments'
5318         parameter to enable segment base registers.
5319         * arch/i386.h (i386_create_target_description): Likewise.
5320         * features/i386/32bit-segments.xml: New file.
5321         * features/i386/32bit-segments.c: Generate.
5322         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5323         call to i386_target_description to add 'segments' parameter.
5324         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5325         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5326         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5327         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5328         if feature is present.
5329         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5330         Add 'segments' parameter to call to i386_target_description.
5331         (i386_target_description): Add 'segments' parameter to enable
5332         segment base registers.
5333         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5334         to call to i386_target_description.
5335         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5336         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5337         Define I386_NUM_REGS.
5338         (i386_target_description): Add 'segments' parameter to enable
5339         segment base registers.
5340
5341 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5342
5343         PR/24325
5344         * source-cache.c: #undef open and close, to avoid unresolved
5345         externals during linking.
5346
5347 2019-03-12  Tom Tromey  <tromey@adacore.com>
5348
5349         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5350         const.  Add initializers.
5351         (_initialize_remote): Don't initialize ptid globals.
5352
5353 2019-03-12  Pedro Alves  <palves@redhat.com>
5354
5355         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5356
5357 2019-03-12  Pedro Alves  <palves@redhat.com>
5358
5359         * cp-name-parser.y (main): Remove unused 'len' variable.
5360
5361 2019-03-12  Tom Tromey  <tromey@adacore.com>
5362
5363         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5364         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5365
5366 2019-03-12  Tom Tromey  <tromey@adacore.com>
5367
5368         * linux-nat.c (iterate_over_lwps): Update.
5369         (stop_callback): Remove parameter.
5370         (stop_wait_callback, detach_callback, resume_set_callback)
5371         (select_singlestep_lwp_callback, set_ignore_sigint)
5372         (status_callback, resumed_callback, resume_clear_callback)
5373         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5374         data parameter.
5375         (linux_nat_target::detach, linux_nat_target::resume)
5376         (linux_stop_and_wait_all_lwps, select_event_lwp)
5377         (linux_nat_filter_event, linux_nat_wait_1)
5378         (linux_nat_target::kill, linux_nat_target::stop)
5379         (linux_nat_target::stop): Update.
5380         (linux_nat_resume_callback): Change type.
5381         (resume_stopped_resumed_lwps, count_events_callback)
5382         (select_event_lwp_callback): Likewise.
5383         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5384         * arm-linux-nat.c (struct update_registers_data): Remove.
5385         (update_registers_callback): Change type.
5386         (arm_linux_insert_hw_breakpoint1): Update.
5387         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5388         parameter.
5389         (x86_linux_dr_set_addr): Update.
5390         (x86_linux_dr_set_control): Update.
5391         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5392         (iterate_over_lwps): Use gdb::function_view.
5393         * nat/aarch64-linux-hw-point.c (struct
5394         aarch64_dr_update_callback_param): Remove.
5395         (debug_reg_change_callback): Change type.
5396         (aarch64_notify_debug_reg_change): Update.
5397         * s390-linux-nat.c (s390_refresh_per_info): Update.
5398
5399 2019-03-11  Tom Tromey  <tromey@adacore.com>
5400
5401         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5402         redundant assignment to "this_cu".
5403
5404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5405
5406         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5407
5408 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5409
5410         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5411         from...
5412         (rank_one_type): ... this.
5413
5414 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5415
5416         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5417         from...
5418         (rank_one_type): ... this.
5419
5420 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5421
5422         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5423         from...
5424         (rank_one_type): ... this.
5425
5426 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5427
5428         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5429         from...
5430         (rank_one_type): ... this.
5431
5432 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5433
5434         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5435         from...
5436         (rank_one_type): ... this.
5437
5438 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5439
5440         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5441         from...
5442         (rank_one_type): ... this.
5443
5444 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5445
5446         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5447         from...
5448         (rank_one_type): ... this.
5449
5450 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5451
5452         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5453         from...
5454         (rank_one_type): ... this.
5455
5456 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5457
5458         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5459         from...
5460         (rank_one_type): ... this.
5461
5462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5463
5464         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5465         from...
5466         (rank_one_type): ... this.
5467
5468 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5469
5470         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5471         from...
5472         (rank_one_type): ... this.
5473
5474 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5475
5476         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5477         from...
5478         (rank_one_type): ... this.
5479
5480 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5481
5482         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5483         inferior-events' shows the example events.
5484
5485 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5486
5487         Support styling on native MS-Windows console
5488
5489         PR/24315
5490         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5491         on MS-Windows if $TERM is not defined.
5492
5493         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5494
5495         * posix-hdep.c (gdb_console_fputs):
5496         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5497         functions.
5498         * ui-file.h (gdb_console_fputs): Add prototype.
5499
5500         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5501         back to fputs only if the former returns zero.
5502
5503 2019-03-07  Tom Tromey  <tom@tromey.com>
5504
5505         * symmisc.c (print_symbol_bcache_statistics): Update.
5506         (print_objfile_statistics): Update.
5507         * symfile.c (allocate_symtab): Update.
5508         * stabsread.c: Don't include bcache.h.
5509         * psymtab.h (struct psymbol_bcache): Don't declare.
5510         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5511         (psymbol_bcache_init, psymbol_bcache_free)
5512         (psymbol_bcache_get_bcache): Don't declare.
5513         * psymtab.c (struct psymbol_bcache): Remove.
5514         (psymtab_storage::psymtab_storage): Update.
5515         (psymtab_storage::~psymtab_storage): Update.
5516         (psymbol_bcache_init, psymbol_bcache_free)
5517         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5518         (add_psymbol_to_bcache): Update.
5519         (allocate_psymtab): Update.
5520         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5521         macro_cache>: No longer pointers.
5522         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5523         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5524         * macrotab.c (macro_bcache): Update.
5525         * macroexp.c: Don't include bcache.h.
5526         * gdbtypes.c (check_types_worklist): Update.
5527         (types_deeply_equal): Remove TRY/CATCH.  Update.
5528         * elfread.c (elf_symtab_read): Update.
5529         * dwarf2read.c: Don't include bcache.h.
5530         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5531         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5532         (print_bcache_statistics, bcache_memory_used): Don't declare.
5533         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5534         methods.  Rename all data members.
5535         * bcache.c (struct bcache): Move to bcache.h.
5536         (bcache::expand_hash_table): Rename from expand_hash_table.
5537         (bcache): Remove.
5538         (bcache::insert): Rename from bcache_full.
5539         (bcache::compare): Rename from bcache_compare.
5540         (bcache_xmalloc): Remove.
5541         (bcache::~bcache): Rename from bcache_xfree.
5542         (bcache::print_statistics): Rename from print_bcache_statistics.
5543         (bcache::memory_used): Rename from bcache_memory_used.
5544
5545 2019-03-07  Pedro Alves  <palves@redhat.com>
5546
5547         * infrun.c (normal_stop): Also check for
5548         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5549
5550 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5551
5552         * f-lang.c (value_from_host_double): Moved to...
5553         * value.c (value_from_host_double): ...here.
5554         * value.h (value_from_host_double): Declare.
5555         * guile/scm-math.c (vlscm_convert_typed_number): Use
5556         value_from_host_double.
5557         (vlscm_convert_number): Likewise.
5558         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5559         * python/py-value.c (convert_value_from_python): Likewise.
5560
5561 2019-03-06  Tom Tromey  <tom@tromey.com>
5562
5563         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5564
5565 2019-03-06  Tom Tromey  <tom@tromey.com>
5566
5567         * utils.h (free_current_contents): Don't declare.
5568         * utils.c (free_current_contents): Remove.
5569
5570 2019-03-06  Tom Tromey  <tom@tromey.com>
5571
5572         * top.c (quit_force): Update.
5573         * main.c (captured_command_loop): Update.
5574         * common/new-op.c (operator new): Update.
5575         * common/common-exceptions.c (struct catcher)
5576         <save_cleanup_chain>: Remove member.
5577         (exceptions_state_mc_init): Update.
5578         (exception_try_scope_entry): Return nullptr.
5579         (exception_try_scope_exit, exception_rethrow)
5580         (throw_exception_sjlj, throw_exception_cxx): Update.
5581         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5582         (all_cleanups, do_cleanups, discard_cleanups)
5583         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5584         (restore_cleanups, restore_final_cleanups): Don't declare.
5585         (do_final_cleanups): Remove parameter.
5586         * common/cleanups.c (cleanup_chain, make_cleanup)
5587         (make_cleanup_dtor, all_cleanups, do_cleanups)
5588         (discard_my_cleanups, discard_cleanups)
5589         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5590         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5591         (null_cleanup): Remove.
5592         (do_final_cleanups): Remove parameter.
5593
5594 2019-03-06  Tom Tromey  <tom@tromey.com>
5595
5596         * remote.c (remote_target::remote_parse_stop_reply): Use
5597         unique_xmalloc_ptr.
5598
5599 2019-03-06  Tom Tromey  <tom@tromey.com>
5600
5601         * stabsread.c (struct stabs_field_info): Rename from field_info.
5602         <list, fnlist>: Add initializers.
5603         <obstack>: New member.
5604         (read_member_functions, read_struct_fields, read_baseclasses):
5605         Allocate on obstack.  Don't use cleanups.
5606         (read_one_struct_field, read_member_functions, read_struct_fields)
5607         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5608         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5609         (read_struct_type): Update.
5610
5611 2019-03-06  Tom Tromey  <tom@tromey.com>
5612
5613         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5614         * common/filestuff.h (make_cleanup_close): Don't declare.
5615         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5616         Remove.
5617
5618 2019-03-06  Tom Tromey  <tom@tromey.com>
5619
5620         * solib-aix.c: Use make_scope_exit.
5621
5622 2019-03-06  Tom Tromey  <tom@tromey.com>
5623
5624         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5625         Use make_scope_exit.
5626
5627 2019-03-06  Tom Tromey  <tom@tromey.com>
5628
5629         * solib-svr4.c (disable_probes_interface): Remove parameter.
5630         (svr4_handle_solib_event): Use make_scope_exit.
5631
5632 2019-03-06  Tom Tromey  <tom@tromey.com>
5633
5634         * remote.c (struct stop_reply_deleter): Remove.
5635         (stop_reply_up): Update.
5636         (struct stop_reply): Derive from notif_event.  Don't typedef.
5637         <regcache>: Now a std::vector.
5638         (stop_reply_xfree): Remove.
5639         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5640         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5641         (remote_target::discard_pending_stop_replies): Use delete.
5642         (remote_target::remote_parse_stop_reply): Update.
5643         (remote_target::process_stop_reply): Update.
5644         * remote-notif.h (struct notif_event): Add virtual destructor.
5645         Remove "dtr" member.
5646         (struct notif_client) <alloc_event>: Return a unique_ptr.
5647         (notif_event_xfree): Don't declare.
5648         (notif_event_up): New typedef.
5649         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5650         (notif_event_xfree, do_notif_event_xfree): Remove.
5651         (remote_notif_state_xfree): Update.
5652
5653 2019-03-06  Tom Tromey  <tom@tromey.com>
5654
5655         * infrun.c (displaced_step_clear_cleanup): Now a
5656         forward_scope_exit type.
5657         (displaced_step_prepare_throw): Update.
5658         (displaced_step_fixup): Update.
5659
5660 2019-03-06  Tom Tromey  <tom@tromey.com>
5661
5662         * inferior.h (class inferior): Update comment.
5663         * gdbthread.h (class thread_info): Update comment.
5664
5665 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5666             Tom Tromey  <tom@tromey.com>
5667
5668         * stabsread.h (struct stab_section_list): Remove.
5669         (coffstab_build_psymtabs): Update.
5670         * dbxread.c (symbuf_sections): Now a std::vector.
5671         (sect_idx): New global.
5672         (fill_symbuf): Update.
5673         (coffstab_build_psymtabs): Change type of stabsects parameter.
5674         Update.
5675         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5676         std::vector.
5677         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5678         (coff_locate_sections): Update.
5679         (coff_symfile_read): Remove cleanups.  Update.
5680         (init_stringtab): Add storage parameter.
5681         (free_stringtab, free_stringtab_cleanup): Remove.
5682         (init_lineno): Add storage parameter.
5683         (free_linetab, free_linetab_cleanup): Remove.
5684
5685 2019-03-06  Pedro Alves  <palves@redhat.com>
5686
5687         * linux-fork.c (fork_info::clobber_regs): Delete.
5688         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5689         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5690         comment.  Adjust.
5691         (scoped_switch_fork_info::scoped_switch_fork_info)
5692         (checkpoint_command, linux_fork_context): Adjust
5693         fork_save_infrun_state calls.
5694
5695 2019-03-06  Pedro Alves  <palves@redhat.com>
5696
5697         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5698         (inf_has_multiple_threads): Return 'bool' and rewrite using
5699         inferior_info::threads().
5700
5701 2019-03-06  Pedro Alves  <palves@redhat.com>
5702
5703         * linux-fork.c: Include <list>.
5704         (fork_list): Now a std::list instance.
5705         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5706         (forks_exist_p, find_last_fork): Adjust.
5707         (new_fork): Delete.
5708         (one_fork_p): New.
5709         (add_fork): Adjust.
5710         (free_fork): Delete, folded into fork_info::~fork_info().
5711         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5712         Adjust.
5713         (init_fork_list): Delete.
5714         (linux_fork_killall, linux_fork_mourn_inferior)
5715         (linux_fork_detach, info_checkpoints_command): Adjust.
5716         (_initialize_linux_fork): No longer call init_fork_list.
5717
5718 2019-03-06  Pedro Alves  <palves@redhat.com>
5719
5720         * linux-fork.c (new_fork): New, split out of ...
5721         (add_fork): ... this.  Return void.  Move "first fork" special
5722         case from here, to ...
5723         (checkpoint_command): ... here.
5724         * linux-linux.h (add_fork): Return void.
5725
5726 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5729
5730 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5731             Chris January  <chris.january@arm.com>
5732             David Lecomber  <david.lecomber@arm.com>
5733
5734         * f-exp.y: New token, UNOP_INTRINSIC.
5735         (exp): New pattern using UNOP_INTRINSIC token.
5736         (f77_keywords): Add 'abs' keyword.
5737         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5738         (value_from_host_double): New function.
5739         (evaluate_subexp_f): Support UNOP_ABS.
5740
5741 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5742
5743         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5744         types.
5745
5746 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5747
5748         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5749         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5750         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5751
5752 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5753
5754         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5755
5756 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5757             Chris January  <chris.january@arm.com>
5758
5759         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5760         * f-exp.y: Define 'KIND' token.
5761         (exp): New pattern for KIND expressions.
5762         (ptype): Handle types with a kind extension.
5763         (direct_abs_decl): Extend to spot kind extensions.
5764         (f77_keywords): Add 'kind' to the list.
5765         (push_kind_type): New function.
5766         (convert_to_kind_type): New function.
5767         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5768         * parse.c (operator_length_standard): Likewise.
5769         * parser-defs.h (enum type_pieces): Add tp_kind.
5770         * std-operator.def: Add UNOP_KIND.
5771
5772 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5773
5774         * f-exp.y (f_parse): Set yydebug.
5775
5776 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5777
5778         * f-lang.c (evaluate_subexp_f): New function.
5779         (exp_descriptor_f): New global.
5780         (f_language_defn): Use exp_descriptor_f instead of
5781         exp_descriptor_standard.
5782
5783 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * f-exp.y (struct token): Add comments.
5786         (dot_ops): Remove uppercase versions and the end marker.
5787         (f77_keywords): Likewise.
5788         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5789         entries in the dot_ops array are case insensitive, and use
5790         strncasecmp to compare strings.  Also some whitespace cleanup in
5791         this area.  Similar for the f77_keywords array, except entries in
5792         this list might be case sensitive.
5793
5794 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5795
5796         * f-exp.y (struct f77_boolean_val): Add comments.
5797         (boolean_values): Remove uppercase versions, and end marker.
5798         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5799         and use strncasecmp to achieve case insensitivity.  Additionally,
5800         perform whitespace cleanup around this code.
5801
5802 2019-03-06  Tom Tromey  <tromey@adacore.com>
5803
5804         * remote-sim.c (gdbsim_target_open): Use result of
5805         gdb_argv::release.
5806
5807 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5808         Dirk Schubert  <dirk.schubert@arm.com>
5809         Chris January  <chris.january@arm.com>
5810
5811         * eval.c (evaluate_subexp_standard): Call Fortran argument
5812         wrapping logic.
5813         * f-lang.c (struct value): A value which can be passed into a
5814         Fortran function call.
5815         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5816         where appropriate.
5817         (struct type): Value ready for a Fortran function call.
5818         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5819         is needed.
5820         * f-lang.h (fortran_argument_convert): Declaration.
5821         (fortran_preserve_arg_pointer): Declaration.
5822         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5823
5824 2019-03-05  Tom Tromey  <tromey@adacore.com>
5825
5826         * python/py-prettyprint.c (print_string_repr): Remove #if.
5827         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5828
5829 2019-03-05  Tom Tromey  <tromey@adacore.com>
5830
5831         * target.c (the_dummy_target): Move later.  Change type to
5832         "dummy_target".
5833         (initialize_targets): Don't initialize the_dummy_target.
5834
5835 2019-03-05  Tom Tromey  <tromey@adacore.com>
5836
5837         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5838         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5839
5840 2019-03-05  Tom Tromey  <tromey@adacore.com>
5841
5842         * windows-nat.c (windows_nat_target::attach)
5843         (windows_nat_target::detach): Don't call gdb_flush.
5844         * valprint.c (generic_val_print, val_print, val_print_string):
5845         Don't call gdb_flush.
5846         * utils.c (defaulted_query): Don't call gdb_flush.
5847         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5848         * target.c (target_announce_detach): Don't call gdb_flush.
5849         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5850         * remote.c (extended_remote_target::attach): Don't call
5851         gdb_flush.
5852         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5853         * printcmd.c (do_examine): Don't call gdb_flush.
5854         (info_display_command): Don't call gdb_flush.
5855         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5856         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5857         * memattr.c (info_mem_command): Don't call gdb_flush.
5858         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5859         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5860         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5861         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5862         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5863         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5864         (gnu_nat_target::detach): Don't call gdb_flush.
5865         * f-valprint.c (f_val_print): Don't call gdb_flush.
5866         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5867         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5868         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5869         gdb_flush.
5870         * c-valprint.c (c_val_print): Don't call gdb_flush.
5871         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5872
5873 2019-03-05  Tom Tromey  <tromey@adacore.com>
5874
5875         * varobj.c (update_dynamic_varobj_children): Update.
5876         (install_default_visualizer): Use reset, not release.
5877         * value.c (set_internalvar): Update.
5878         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5879         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5880         ATTRIBUTE_UNUSED_RESULT.
5881
5882 2019-03-05  Tom Tromey  <tromey@adacore.com>
5883
5884         * remote.c (class scoped_remote_fd) <release>: Add
5885         ATTRIBUTE_UNUSED_RESULT.
5886
5887 2019-03-05  Tom Tromey  <tromey@adacore.com>
5888
5889         * macroexp.c (struct macro_buffer) <release>: Add
5890         ATTRIBUTE_UNUSED_RESULT.
5891
5892 2019-03-05  Tom Tromey  <tromey@adacore.com>
5893
5894         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5895         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5896         ATTRIBUTE_UNUSED_RESULT.
5897
5898 2019-03-05  Tom Tromey  <tromey@adacore.com>
5899
5900         * common/scoped_fd.h (class scoped_fd) <release>: Add
5901         ATTRIBUTE_UNUSED_RESULT.
5902
5903 2019-03-05  Tom Tromey  <tromey@adacore.com>
5904
5905         * parser-defs.h (struct parser_state) <release>: Add
5906         ATTRIBUTE_UNUSED_RESULT.
5907
5908 2019-03-05  Tom Tromey  <tromey@adacore.com>
5909
5910         * utils.h (class gdb_argv) <release>: Add
5911         ATTRIBUTE_UNUSED_RESULT.
5912         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5913
5914 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5915
5916         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5917         for-loop range, to avoid compiler warnings.
5918
5919         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5920         avoid compiler warnings about unused variables.
5921
5922         * NEWS: Mention end of support for native debugging on MS-Windows
5923         before XP.
5924
5925         PR gdb/24292
5926         * common/netstuff.c:
5927         * gdbserver/gdbreplay.c
5928         * gdbserver/remote-utils.c:
5929         * ser-tcp.c:
5930         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5931         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5932         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5933         'getaddrinfo' and 'freeaddrinfo' were not available before
5934         Windows XP, and mingw.org's MinGW headers by default define
5935         _WIN32_WINNT to 0x500.
5936
5937 2019-03-01  Gary Benson <gbenson@redhat.com>
5938
5939         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5940
5941 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5942             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5943
5944         PR gdb/8527
5945         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5946         set_sigint_trap, clear_sigint_trap.
5947
5948 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5949
5950         * target.c (target_detach): Clear the regcache and the
5951         frame cache.
5952
5953 2019-02-27  Pedro Alves  <palves@redhat.com>
5954
5955         * utils.c (set_screen_size): When we cap the height/width sizes,
5956         tweak the corresponding command variable to show "unlimited":
5957
5958 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5959             Pedro Alves  <palves@redhat.com>
5960
5961         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5962         before calling rl_set_screen_size.
5963
5964 2019-02-27  Tom Tromey  <tromey@adacore.com>
5965
5966         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5967         define.
5968         * python/py-value.c: Remove Python 2.4 workaround.
5969         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5970         workaround.
5971         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5972         Python 2.4 workaround.
5973         * python/python-internal.h: Remove Python 2.4 comment.
5974         (Py_ssize_t): Don't define.
5975         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5976         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5977         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5978         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5979         * python/python.c (do_start_initialization): Remove Python 2.4
5980         workaround.
5981         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5982         (print_children): Remove Python 2.4 workaround.
5983         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5984         workaround.
5985         (CHARBUFFERPROC_NAME): Remove.
5986         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5987         Python 2.4 workaround.
5988
5989 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5990
5991         * NEWS: Note minimum Python version.
5992
5993 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5994
5995         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5996         code from these functions.  Remove corresponding ifdefs.  Use
5997         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5998         Remove gotos and target of gotos.
5999         (infpy_search_memory): Likewise.
6000
6001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6002
6003         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6004         (hppa_gdbarch_init): Don't register deleted functions with
6005         gdbarch.
6006
6007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6010         (h8300_unwind_sp): Delete.
6011         (h8300_dummy_id): Delete.
6012         (h8300_gdbarch_init): Don't register deleted functions with
6013         gdbarch.
6014
6015 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6016
6017         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6018         (ft32_unwind_pc): Delete.
6019         (ft32_unwind_sp): Delete.
6020         (ft32_gdbarch_init): Don't register deleted functions with
6021         gdbarch.
6022
6023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6024
6025         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6026         (frv_unwind_pc): Delete.
6027         (frv_unwind_sp): Delete.
6028         (frv_gdbarch_init): Don't register deleted functions with
6029         gdbarch.
6030
6031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6034         (riscv_unwind_pc): Delete.
6035         (riscv_unwind_sp): Delete.
6036         (riscv_gdbarch_init): Don't register deleted functions with
6037         gdbarch.
6038
6039 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6042         (csky_unwind_pc): Delete.
6043         (csky_unwind_sp): Delete.
6044         (csky_gdbarch_init): Don't register deleted functions with
6045         gdbarch.
6046
6047 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6048
6049         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6050         (cris_unwind_pc): Delete.
6051         (cris_unwind_sp): Delete.
6052         (cris_gdbarch_init): Don't register deleted functions with
6053         gdbarch.
6054
6055 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6058         (bfin_unwind_pc): Delete.
6059         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6060
6061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6062
6063         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6064         (arm_unwind_pc): Delete.
6065         (arm_unwind_sp): Delete.
6066         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6067
6068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6069
6070         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6071         (arc_unwind_pc): Delete.
6072         (arc_unwind_sp): Delete.
6073         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6074
6075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6076
6077         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6078         (alpha_unwind_pc): Delete.
6079         (alpha_gdbarch_init): Don't register deleted functions with
6080         gdbarch.
6081
6082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6083
6084         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6085         (aarch64_unwind_pc): Delete.
6086         (aarch64_unwind_sp): Delete.
6087         (aarch64_gdbarch_init): Don't register deleted functions with
6088         gdbarch.
6089
6090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * gdbtypes.c (type_align): Don't consider static members when
6093         computing structure alignment.
6094
6095 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6096
6097         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6098         return 0 for other types.
6099         * arch-utils.c (default_type_align): Always return 0.
6100         * gdbarch.h: Regenerate.
6101         * gdbarch.sh (type_align): Extend comment.
6102         * gdbtypes.c (type_align): Add additional comments, always call
6103         gdbarch_type_align before applying the default rules.
6104         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6105         generic code will then apply a suitable default.
6106         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6107         types, return 0 for other types.
6108
6109 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6110
6111         * NEWS: Create a new section for the next release branch.
6112         Rename the section of the current branch, now that it has
6113         been cut.
6114
6115 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6116
6117         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6118         * version.in: Bump version to 8.3.50.DATE-git.
6119
6120 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6121
6122         * aix-thread.c (ptid_cmp): Remove unused variable.
6123         (get_signaled_thread): Likewise.
6124         (store_regs_user_thread): Likewise.
6125         (store_regs_kernel_thread): Likewise.
6126         (fetch_regs_kernel_thread): Remove shadowed variable.
6127
6128 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6129
6130         * features/riscv/32bit-cpu.xml: Add register numbers.
6131         * features/riscv/32bit-fpu.c: Regenerate.
6132         * features/riscv/32bit-fpu.xml: Add register numbers.
6133         * features/riscv/64bit-cpu.xml: Add register numbers.
6134         * features/riscv/64bit-fpu.c: Regenerate.
6135         * features/riscv/64bit-fpu.xml: Add register numbers.
6136
6137 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6138
6139         * NEWS: Mention two argument form of gdb.Value constructor.
6140         * python/py-value.c (convert_buffer_and_type_to_value): New
6141         function.
6142         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6143         Add support for handling an optional second argument.  Call
6144         convert_buffer_and_type_to_value as appropriate.
6145         * python/python-internal.h (Py_buffer_deleter): New struct.
6146         (Py_buffer_up): New typedef.
6147
6148 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6149
6150         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6151         instead of releasing ownership.
6152
6153 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6154
6155         * dwarf2read.c (open_and_init_dwp_file): Call
6156         elf_numsections instead of bfd_count_sections to initialize
6157         dwp_file->num_sections.
6158
6159 2019-02-25  Tom Tromey  <tromey@adacore.com>
6160
6161         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6162
6163 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6164
6165         * gcore.in: Add '--readnever' option when invoking GDB.
6166
6167 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6168
6169         * MAINTAINERS: Update my email address.
6170
6171 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6172
6173         * build-id.c (build_id_to_debug_bfd_1): New function.
6174         (build_id_to_debug_bfd): Look for separate debug file in
6175         sysroot.
6176
6177 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6178
6179         * gdbarch.sh: Update the copyright year range that is placed into
6180         generated files.
6181
6182 2019-02-22  Keith Seitz  <keiths@redhat.com>
6183
6184         PR symtab/23853
6185         * linespec.c (create_sals_line_offset): Search for the default
6186         symtab's filename instead of its fullname.
6187
6188 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6189
6190         * NEWS: Update style defaults.
6191
6192 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6193
6194         * main.c (captured_main_1): Disable styling in batch mode.
6195
6196 2019-02-20  Tom Tromey  <tom@tromey.com>
6197
6198         * symtab.c (symtab_symbol_info): Fix typos.
6199
6200 2019-02-20  Tom Tromey  <tromey@adacore.com>
6201
6202         * findcmd.c (_initialize_mem_search): Use upper case for
6203         metasyntactic variables.
6204
6205 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6206
6207         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6208         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6209
6210 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6211
6212         * top.h (source_file_name): Change to std::string.
6213         * top.c (source_file_name): Likewise.
6214         (command_line_input): Adjust.
6215         * cli/cli-script.c (script_from_file): Adjust.
6216
6217 2019-02-19  Tom Tromey  <tromey@adacore.com>
6218
6219         * ravenscar-thread.c
6220         (ravenscar_thread_target::update_thread_list): Don't call
6221         ada_build_task_list.
6222         * ada-lang.h (ada_build_task_list): Don't declare.
6223         * ada-tasks.c (struct ada_tasks_inferior_data)
6224         <task_list_valid_p>: Now bool.
6225         (read_known_tasks, ada_task_list_changed)
6226         (ada_tasks_invalidate_inferior_data): Update.
6227         (read_known_tasks_array): Return bool.
6228         (read_known_tasks_list): Likewise.
6229         (read_known_tasks): Return void.
6230         (ada_build_task_list): Now static.
6231
6232 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6235         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6236
6237 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6238
6239         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6240         variant for ada_tasks_pspace_data_handle and
6241         ada_tasks_inferior_data_handle.
6242         (ada_tasks_pspace_data_cleanup): New function.
6243         (ada_tasks_inferior_data_cleanup): New function.
6244
6245 2019-02-17  Tom Tromey  <tom@tromey.com>
6246
6247         * macrotab.h (macro_source_fullname): Return a std::string.
6248         * macrotab.c (macro_include, check_for_redefinition)
6249         (macro_undef, macro_lookup_definition, foreach_macro)
6250         (foreach_macro_in_scope): Update.
6251         (macro_source_fullname): Return a std::string.
6252         * macrocmd.c (show_pp_source_pos): Update.
6253
6254 2019-02-17  Tom Tromey  <tom@tromey.com>
6255
6256         * macrocmd.c (show_pp_source_pos): Style the file names.
6257
6258 2019-02-17  Tom Tromey  <tom@tromey.com>
6259
6260         PR tui/24197:
6261         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6262
6263 2019-02-17  Tom Tromey  <tom@tromey.com>
6264
6265         * ada-lang.c (user_select_syms): Use filtered printing.
6266         * utils.c (wrap_style): New global.
6267         (desired_style): Remove.
6268         (emit_style_escape): Add stream parameter.
6269         (set_output_style, reset_terminal_style, prompt_for_continue):
6270         Update.
6271         (flush_wrap_buffer): Only flush gdb_stdout.
6272         (wrap_here): Set wrap_style.
6273         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6274         treat escape sequences as a character.  Change when wrap buffer is
6275         flushed.
6276         (fputs_styled): Do not set the output style when the default is
6277         requested.
6278         * ui-style.h (struct ui_file_style) <is_default>: New method.
6279         * source.c (print_source_lines_base): Emit escape sequences in one
6280         piece.
6281
6282 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6283
6284         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6285         integers and enumeration types.
6286
6287 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6288
6289         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6290         instead of lookup_symbol_in_language
6291         (do_exact_match): New function.
6292         (ada_get_symbol_name_matcher): Return do_exact_match when
6293         doing a verbatim match.
6294
6295 2019-02-15  Tom Tromey  <tromey@adacore.com>
6296
6297         * ravenscar-thread.c (ravenscar_thread_target::resume)
6298         (ravenscar_thread_target::wait): Special case wildcard requests.
6299
6300 2019-02-15  Tom Tromey  <tromey@adacore.com>
6301
6302         * ravenscar-thread.c (base_ptid): Remove.
6303         (struct ravenscar_thread_target) <close>: New method.
6304         <m_base_ptid>: New member.
6305         <update_inferior_ptid, active_task, task_is_currently_active,
6306         runtime_initialized>: Declare methods.
6307         <ravenscar_thread_target>: Add constructor.
6308         (ravenscar_thread_target::task_is_currently_active)
6309         (ravenscar_thread_target::update_inferior_ptid)
6310         (ravenscar_runtime_initialized): Rename.  Now methods.
6311         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6312         (ravenscar_thread_target::update_thread_list): Update.
6313         (ravenscar_thread_target::active_task): Now method.
6314         (ravenscar_thread_target::store_registers)
6315         (ravenscar_thread_target::prepare_to_store)
6316         (ravenscar_thread_target::prepare_to_store)
6317         (ravenscar_thread_target::mourn_inferior): Update.
6318         (ravenscar_inferior_created): Use "new" to create target.
6319         (ravenscar_thread_target::get_ada_task_ptid): Update.
6320         (_initialize_ravenscar): Don't initialize base_ptid.
6321         (ravenscar_ops): Remove global.
6322
6323 2019-02-15  Tom Tromey  <tromey@adacore.com>
6324
6325         * target.h (push_target): Declare new overload.
6326         * target.c (push_target): New overload, taking an rvalue reference.
6327         * remote.c (remote_target::open_1): Use push_target overload.
6328         * corelow.c (core_target_open): Use push_target overload.
6329
6330 2019-02-15  Tom Tromey  <tromey@adacore.com>
6331
6332         * ravenscar-thread.c (is_ravenscar_task)
6333         (ravenscar_task_is_currently_active): Return bool.
6334         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6335         (_initialize_ravenscar): Remove "(void)".
6336         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6337         Return bool.
6338
6339 2019-02-15  Tom Tromey  <tromey@adacore.com>
6340
6341         * ravenscar-thread.c (ravenscar_runtime_initializer)
6342         (has_ravenscar_runtime, get_running_thread_id)
6343         (ravenscar_thread_target::resume): Fix indentation.
6344
6345 2019-02-15  Tom Tromey  <tromey@adacore.com>
6346
6347         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6348         from ravenscar_arch_ops.
6349         (sparc_ravenscar_ops::fetch_registers)
6350         (sparc_ravenscar_ops::store_registers): Now methods.
6351         (sparc_ravenscar_prepare_to_store): Remove.
6352         (sparc_ravenscar_ops): Redefine.
6353         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6354         methods and destructor.  Remove members.
6355         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6356         (ravenscar_thread_target::store_registers)
6357         (ravenscar_thread_target::prepare_to_store): Update.
6358         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6359         Remove.
6360         (struct ppc_ravenscar_powerpc_ops): Derive from
6361         ravenscar_arch_ops.
6362         (ppc_ravenscar_powerpc_ops::fetch_registers)
6363         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6364         (ppc_ravenscar_powerpc_ops): Redefine.
6365         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6366         (ppc_ravenscar_e500_ops::fetch_registers)
6367         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6368         (ppc_ravenscar_e500_ops): Redefine.
6369         * aarch64-ravenscar-thread.c
6370         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6371         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6372         (aarch64_ravenscar_fetch_registers)
6373         (aarch64_ravenscar_store_registers): Now methods.
6374         (aarch64_ravenscar_ops): Redefine.
6375
6376 2019-02-15  Tom Tromey  <tromey@adacore.com>
6377
6378         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6379         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6380         (ravenscar_thread_target::stopped_by_watchpoint)
6381         (ravenscar_thread_target::stopped_data_address)
6382         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6383
6384 2019-02-15  Tom Tromey  <tromey@adacore.com>
6385
6386         * ravenscar-thread.c: Fix some typos.
6387
6388 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6389             Tom Tromey  <tromey@adacore.com>
6390
6391         * ada-lang.c (ada_exception_sal): Change addr_string to a
6392         std::string.
6393         (create_ada_exception_catchpoint): Update.
6394
6395 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6396             Tom Tromey  <tromey@adacore.com>
6397
6398         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6399         (bp_location_ops): Remove.
6400         (base_breakpoint_allocate_location): Update.
6401         (free_bp_location): Update.
6402         * ada-lang.c (class ada_catchpoint_location)
6403         <ada_catchpoint_location>: Remove ops parameter.
6404         (ada_catchpoint_location_dtor): Remove.
6405         (ada_catchpoint_location_ops): Remove.
6406         (allocate_location_exception): Update.
6407         * breakpoint.h (struct bp_location_ops): Remove.
6408         (class bp_location) <bp_location>: Remove bp_location_ops
6409         parameter.
6410         <~bp_location>: Add destructor.
6411         <ops>: Remove.
6412
6413 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6414             Pedro Alves  <palves@redhat.com>
6415
6416         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6417         'PATH_MAX'.
6418
6419 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6420             Samuel Thibault  <samuel.thibault@gnu.org>
6421             Thomas Schwinge  <thomas@codesourcery.com>
6422
6423         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6424         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6425
6426 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6427
6428         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6429         (check_empty): Use "const char *".
6430
6431         * gnu-nat.c (gnu_nat_target::detach): Instead of
6432         'detach_inferior (pid)' call
6433         'detach_inferior (find_inferior_pid (pid))'.
6434
6435         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6436         'nat/fork-inferior.o'.
6437         * gnu-nat.c: #include "nat/fork-inferior.h".
6438
6439         * gnu-nat.c (gnu_nat_target::detach): Instead of
6440         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6441         * gnu-nat.h: #include "inf-child.h".
6442         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6443         'i386_gnu_nat_target::fetch_registers'.
6444         (gnu_store_registers): Rename/move to
6445         'i386_gnu_nat_target::store_registers'.
6446
6447         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6448         * gnu-nat.h (mach_thread_info): New function.
6449         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6450
6451         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6452
6453 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6454
6455         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6456
6457 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6458
6459         * windows-nat.c (windows_add_thread): Add new parameter
6460         "main_thread_p" with default value set to false.  Update
6461         function documentation as well as all callers.
6462         (windows_delete_thread): Likewise.
6463         (fake_create_process): Update call to windows_add_thread.
6464         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6465         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6466         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6467         call to windows_delete_thread.
6468
6469 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6470
6471         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6472
6473 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6474
6475         * symfile.c (find_separate_debug_file): Use canonical path of
6476         sysroot with child_path instead of gdb_sysroot if it is valid.
6477
6478 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6479
6480         * symfile.c (find_separate_debug_file): Use child_path to
6481         determine if an object file is under a sysroot.
6482
6483 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6484
6485         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6486         unittests/child-path-selftests.c.
6487         * common/pathstuff.c (child_path): New function.
6488         * common/pathstuff.h (child_path): New prototype.
6489         * unittests/child-path-selftests.c: New file.
6490
6491 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6492
6493         * symfile.c (find_separate_debug_file): Look for separate debug
6494         files in debug directories under the sysroot.
6495
6496 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6497
6498         * symtab.h (struct minimal_symbol data_p): New const method.
6499         (struct minimal_symbol text_p): Likewise.
6500         * symtab.c (output_source_filename): Use file name style
6501         to print file name.
6502         (print_symbol_info): Likewise.
6503         (print_msymbol_info): Use address style to print addresses.
6504         Use function name style to print executable text symbols.
6505         (expand_symtab_containing_pc): Use data_p.
6506         (find_pc_sect_compunit_symtab): Likewise.
6507
6508 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6509
6510         * breakpoint.c (describe_other_breakpoints): Use address style
6511         to print addresses.
6512         (say_where): Likewise.
6513
6514 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6515
6516         * ada-typeprint.c (print_func_type): Print function name
6517         style to print function name.
6518         * c-typeprint.c (c_print_type_1): Likewise.
6519
6520 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6521
6522         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6523         for execve.
6524
6525 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6526
6527         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6528         type_stack.
6529
6530 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6531
6532         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6533         TYPE_CODE_REF types.
6534
6535 2019-02-08  Jim Wilson  <jimw@sifive.com>
6536
6537         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6538         (riscv_linux_fregset): New.
6539         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6540
6541 2019-02-07  Tom Tromey  <tom@tromey.com>
6542
6543         * thread.c (thread_cancel_execution_command): Update.
6544         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6545         methods.
6546         (struct thread_fsm_ops): Remove.
6547         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6548         (thread_fsm_should_stop, thread_fsm_return_value)
6549         (thread_fsm_set_finished, thread_fsm_finished_p)
6550         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6551         Don't declare.
6552         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6553         * infrun.c (clear_proceed_status_thread)
6554         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6555         (print_stop_event): Update.
6556         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6557         Add constructor.
6558         (step_command_fsm_ops): Remove.
6559         (new_step_command_fsm): Remove.
6560         (step_1): Update.
6561         (step_command_fsm::should_stop): Rename from
6562         step_command_fsm_should_stop.
6563         (step_command_fsm::clean_up): Rename from
6564         step_command_fsm_clean_up.
6565         (step_command_fsm::do_async_reply_reason): Rename from
6566         step_command_fsm_async_reply_reason.
6567         (struct until_next_fsm): Inherit from thread_fsm.  Add
6568         constructor.
6569         (until_next_fsm_ops): Remove.
6570         (new_until_next_fsm): Remove.
6571         (until_next_fsm::should_stop): Rename from
6572         until_next_fsm_should_stop.
6573         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6574         (until_next_fsm::do_async_reply_reason): Rename from
6575         until_next_fsm_async_reply_reason.
6576         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6577         constructor.  Change type of breakpoint.
6578         (finish_command_fsm_ops): Remove.
6579         (new_finish_command_fsm): Remove.
6580         (finish_command_fsm::should_stop): Rename from
6581         finish_command_fsm_should_stop.
6582         (finish_command_fsm::clean_up): Rename from
6583         finish_command_fsm_clean_up.
6584         (finish_command_fsm::return_value): Rename from
6585         finish_command_fsm_return_value.
6586         (finish_command_fsm::do_async_reply_reason): Rename from
6587         finish_command_fsm_async_reply_reason.
6588         (finish_command): Update.
6589         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6590         Add constructor.
6591         (call_thread_fsm_ops): Remove.
6592         (call_thread_fsm::call_thread_fsm): Rename from
6593         new_call_thread_fsm.
6594         (call_thread_fsm::should_stop): Rename from
6595         call_thread_fsm_should_stop.
6596         (call_thread_fsm::should_notify_stop): Rename from
6597         call_thread_fsm_should_notify_stop.
6598         (run_inferior_call, call_function_by_hand_dummy): Update.
6599         * cli/cli-interp.c (should_print_stop_to_console): Update.
6600         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6601         Add constructor.  Change type of location_breakpoint,
6602         caller_breakpoint.
6603         (until_break_fsm_ops): Remove.
6604         (new_until_break_fsm): Remove.
6605         (until_break_fsm::should_stop): Rename from
6606         until_break_fsm_should_stop.
6607         (until_break_fsm::clean_up): Rename from
6608         until_break_fsm_clean_up.
6609         (until_break_fsm::do_async_reply_reason): Rename from
6610         until_break_fsm_async_reply_reason.
6611         (until_break_command): Update.
6612         * thread-fsm.c: Remove.
6613         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6614
6615 2019-02-07  Tom Tromey  <tom@tromey.com>
6616
6617         * yy-remap.h: Add include guard.
6618         * xtensa-tdep.h: Add include guard.
6619         * xcoffread.h: Rename include guard.
6620         * varobj-iter.h: Add include guard.
6621         * tui/tui.h: Rename include guard.
6622         * tui/tui-winsource.h: Rename include guard.
6623         * tui/tui-wingeneral.h: Rename include guard.
6624         * tui/tui-windata.h: Rename include guard.
6625         * tui/tui-win.h: Rename include guard.
6626         * tui/tui-stack.h: Rename include guard.
6627         * tui/tui-source.h: Rename include guard.
6628         * tui/tui-regs.h: Rename include guard.
6629         * tui/tui-out.h: Rename include guard.
6630         * tui/tui-layout.h: Rename include guard.
6631         * tui/tui-io.h: Rename include guard.
6632         * tui/tui-hooks.h: Rename include guard.
6633         * tui/tui-file.h: Rename include guard.
6634         * tui/tui-disasm.h: Rename include guard.
6635         * tui/tui-data.h: Rename include guard.
6636         * tui/tui-command.h: Rename include guard.
6637         * tic6x-tdep.h: Add include guard.
6638         * target/waitstatus.h: Rename include guard.
6639         * target/wait.h: Rename include guard.
6640         * target/target.h: Rename include guard.
6641         * target/resume.h: Rename include guard.
6642         * target-float.h: Rename include guard.
6643         * stabsread.h: Add include guard.
6644         * rs6000-tdep.h: Add include guard.
6645         * riscv-fbsd-tdep.h: Add include guard.
6646         * regformats/regdef.h: Rename include guard.
6647         * record.h: Rename include guard.
6648         * python/python.h: Rename include guard.
6649         * python/python-internal.h: Rename include guard.
6650         * python/py-stopevent.h: Rename include guard.
6651         * python/py-ref.h: Rename include guard.
6652         * python/py-record.h: Rename include guard.
6653         * python/py-record-full.h: Rename include guard.
6654         * python/py-record-btrace.h: Rename include guard.
6655         * python/py-instruction.h: Rename include guard.
6656         * python/py-events.h: Rename include guard.
6657         * python/py-event.h: Rename include guard.
6658         * procfs.h: Add include guard.
6659         * proc-utils.h: Add include guard.
6660         * p-lang.h: Add include guard.
6661         * or1k-tdep.h: Rename include guard.
6662         * observable.h: Rename include guard.
6663         * nto-tdep.h: Rename include guard.
6664         * nat/x86-linux.h: Rename include guard.
6665         * nat/x86-linux-dregs.h: Rename include guard.
6666         * nat/x86-gcc-cpuid.h: Add include guard.
6667         * nat/x86-dregs.h: Rename include guard.
6668         * nat/x86-cpuid.h: Rename include guard.
6669         * nat/ppc-linux.h: Rename include guard.
6670         * nat/mips-linux-watch.h: Rename include guard.
6671         * nat/linux-waitpid.h: Rename include guard.
6672         * nat/linux-ptrace.h: Rename include guard.
6673         * nat/linux-procfs.h: Rename include guard.
6674         * nat/linux-osdata.h: Rename include guard.
6675         * nat/linux-nat.h: Rename include guard.
6676         * nat/linux-namespaces.h: Rename include guard.
6677         * nat/linux-btrace.h: Rename include guard.
6678         * nat/glibc_thread_db.h: Rename include guard.
6679         * nat/gdb_thread_db.h: Rename include guard.
6680         * nat/gdb_ptrace.h: Rename include guard.
6681         * nat/fork-inferior.h: Rename include guard.
6682         * nat/amd64-linux-siginfo.h: Rename include guard.
6683         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6684         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6685         * nat/aarch64-linux.h: Rename include guard.
6686         * nat/aarch64-linux-hw-point.h: Rename include guard.
6687         * mn10300-tdep.h: Add include guard.
6688         * mips-linux-tdep.h: Add include guard.
6689         * mi/mi-parse.h: Rename include guard.
6690         * mi/mi-out.h: Rename include guard.
6691         * mi/mi-main.h: Rename include guard.
6692         * mi/mi-interp.h: Rename include guard.
6693         * mi/mi-getopt.h: Rename include guard.
6694         * mi/mi-console.h: Rename include guard.
6695         * mi/mi-common.h: Rename include guard.
6696         * mi/mi-cmds.h: Rename include guard.
6697         * mi/mi-cmd-break.h: Rename include guard.
6698         * m2-lang.h: Add include guard.
6699         * location.h: Rename include guard.
6700         * linux-record.h: Rename include guard.
6701         * linux-nat.h: Add include guard.
6702         * linux-fork.h: Add include guard.
6703         * i386-darwin-tdep.h: Rename include guard.
6704         * hppa-linux-offsets.h: Add include guard.
6705         * guile/guile.h: Rename include guard.
6706         * guile/guile-internal.h: Rename include guard.
6707         * gnu-nat.h: Rename include guard.
6708         * gdb-stabs.h: Rename include guard.
6709         * frv-tdep.h: Add include guard.
6710         * f-lang.h: Add include guard.
6711         * event-loop.h: Add include guard.
6712         * darwin-nat.h: Rename include guard.
6713         * cp-abi.h: Rename include guard.
6714         * config/sparc/nm-sol2.h: Rename include guard.
6715         * config/nm-nto.h: Rename include guard.
6716         * config/nm-linux.h: Add include guard.
6717         * config/i386/nm-i386gnu.h: Rename include guard.
6718         * config/djgpp/nl_types.h: Rename include guard.
6719         * config/djgpp/langinfo.h: Rename include guard.
6720         * compile/gcc-cp-plugin.h: Add include guard.
6721         * compile/gcc-c-plugin.h: Add include guard.
6722         * compile/compile.h: Rename include guard.
6723         * compile/compile-object-run.h: Rename include guard.
6724         * compile/compile-object-load.h: Rename include guard.
6725         * compile/compile-internal.h: Rename include guard.
6726         * compile/compile-cplus.h: Rename include guard.
6727         * compile/compile-c.h: Rename include guard.
6728         * common/xml-utils.h: Rename include guard.
6729         * common/x86-xstate.h: Rename include guard.
6730         * common/version.h: Rename include guard.
6731         * common/vec.h: Rename include guard.
6732         * common/tdesc.h: Rename include guard.
6733         * common/selftest.h: Rename include guard.
6734         * common/scoped_restore.h: Rename include guard.
6735         * common/scoped_mmap.h: Rename include guard.
6736         * common/scoped_fd.h: Rename include guard.
6737         * common/safe-iterator.h: Rename include guard.
6738         * common/run-time-clock.h: Rename include guard.
6739         * common/refcounted-object.h: Rename include guard.
6740         * common/queue.h: Rename include guard.
6741         * common/ptid.h: Rename include guard.
6742         * common/print-utils.h: Rename include guard.
6743         * common/preprocessor.h: Rename include guard.
6744         * common/pathstuff.h: Rename include guard.
6745         * common/observable.h: Rename include guard.
6746         * common/netstuff.h: Rename include guard.
6747         * common/job-control.h: Rename include guard.
6748         * common/host-defs.h: Rename include guard.
6749         * common/gdb_wait.h: Rename include guard.
6750         * common/gdb_vecs.h: Rename include guard.
6751         * common/gdb_unlinker.h: Rename include guard.
6752         * common/gdb_unique_ptr.h: Rename include guard.
6753         * common/gdb_tilde_expand.h: Rename include guard.
6754         * common/gdb_sys_time.h: Rename include guard.
6755         * common/gdb_string_view.h: Rename include guard.
6756         * common/gdb_splay_tree.h: Rename include guard.
6757         * common/gdb_setjmp.h: Rename include guard.
6758         * common/gdb_ref_ptr.h: Rename include guard.
6759         * common/gdb_optional.h: Rename include guard.
6760         * common/gdb_locale.h: Rename include guard.
6761         * common/gdb_assert.h: Rename include guard.
6762         * common/filtered-iterator.h: Rename include guard.
6763         * common/filestuff.h: Rename include guard.
6764         * common/fileio.h: Rename include guard.
6765         * common/environ.h: Rename include guard.
6766         * common/common-utils.h: Rename include guard.
6767         * common/common-types.h: Rename include guard.
6768         * common/common-regcache.h: Rename include guard.
6769         * common/common-inferior.h: Rename include guard.
6770         * common/common-gdbthread.h: Rename include guard.
6771         * common/common-exceptions.h: Rename include guard.
6772         * common/common-defs.h: Rename include guard.
6773         * common/common-debug.h: Rename include guard.
6774         * common/cleanups.h: Rename include guard.
6775         * common/buffer.h: Rename include guard.
6776         * common/btrace-common.h: Rename include guard.
6777         * common/break-common.h: Rename include guard.
6778         * cli/cli-utils.h: Rename include guard.
6779         * cli/cli-style.h: Rename include guard.
6780         * cli/cli-setshow.h: Rename include guard.
6781         * cli/cli-script.h: Rename include guard.
6782         * cli/cli-interp.h: Rename include guard.
6783         * cli/cli-decode.h: Rename include guard.
6784         * cli/cli-cmds.h: Rename include guard.
6785         * charset-list.h: Add include guard.
6786         * buildsym-legacy.h: Rename include guard.
6787         * bfin-tdep.h: Add include guard.
6788         * ax.h: Rename include guard.
6789         * arm-linux-tdep.h: Add include guard.
6790         * arm-fbsd-tdep.h: Add include guard.
6791         * arch/xtensa.h: Rename include guard.
6792         * arch/tic6x.h: Add include guard.
6793         * arch/i386.h: Add include guard.
6794         * arch/arm.h: Rename include guard.
6795         * arch/arm-linux.h: Rename include guard.
6796         * arch/arm-get-next-pcs.h: Rename include guard.
6797         * arch/amd64.h: Add include guard.
6798         * arch/aarch64-insn.h: Rename include guard.
6799         * arch-utils.h: Rename include guard.
6800         * annotate.h: Add include guard.
6801         * amd64-darwin-tdep.h: Rename include guard.
6802         * aarch64-linux-tdep.h: Add include guard.
6803         * aarch64-fbsd-tdep.h: Add include guard.
6804         * aarch32-linux-nat.h: Add include guard.
6805
6806 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6807
6808         * macrotab.c (macro_define_internal): New function that
6809         factorizes macro_define_object_internal and macro_define_function
6810         code.
6811         (macro_define_object_internal): Use macro_define_internal.
6812         (macro_define_function): Likewise.
6813
6814 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6815
6816         * macrocmd.c (extract_identifier): Return
6817         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6818         callers.
6819
6820 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6821
6822         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6823
6824 2019-02-05  Tom Tromey  <tom@tromey.com>
6825
6826         * target.c (target_stack::unpush): Move assertion earlier.
6827
6828 2019-01-30  Tom Tromey  <tom@tromey.com>
6829
6830         PR python/23615:
6831         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6832         (gdbpy_parse_and_eval): Likewise.
6833         * python/python-internal.h (gdbpy_allow_threads): New class.
6834
6835 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6836
6837         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6838         (aarch64_fbsd_fpregmap): Move earlier.
6839         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6840         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6841         instead of individual calls to trad_frame_set_reg_addr.
6842         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6843         earlier.
6844         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6845         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6846         instead of individual calls to trad_frame_set_reg_addr.
6847
6848 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6849
6850         * CONTRIBUTE: Replace contribution list with wiki link.
6851
6852 2019-01-25  Tom Tromey  <tom@tromey.com>
6853
6854         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6855
6856 2019-01-25  Tom Tromey  <tom@tromey.com>
6857
6858         * xtensa-linux-nat.c: Fix common/ includes.
6859         * xml-support.h: Fix common/ includes.
6860         * xml-support.c: Fix common/ includes.
6861         * x86-linux-nat.c: Fix common/ includes.
6862         * windows-nat.c: Fix common/ includes.
6863         * varobj.h: Fix common/ includes.
6864         * varobj.c: Fix common/ includes.
6865         * value.c: Fix common/ includes.
6866         * valops.c: Fix common/ includes.
6867         * utils.c: Fix common/ includes.
6868         * unittests/xml-utils-selftests.c: Fix common/ includes.
6869         * unittests/utils-selftests.c: Fix common/ includes.
6870         * unittests/unpack-selftests.c: Fix common/ includes.
6871         * unittests/tracepoint-selftests.c: Fix common/ includes.
6872         * unittests/style-selftests.c: Fix common/ includes.
6873         * unittests/string_view-selftests.c: Fix common/ includes.
6874         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6875         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6876         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6877         * unittests/rsp-low-selftests.c: Fix common/ includes.
6878         * unittests/parse-connection-spec-selftests.c: Fix common/
6879         includes.
6880         * unittests/optional-selftests.c: Fix common/ includes.
6881         * unittests/offset-type-selftests.c: Fix common/ includes.
6882         * unittests/observable-selftests.c: Fix common/ includes.
6883         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6884         * unittests/memrange-selftests.c: Fix common/ includes.
6885         * unittests/memory-map-selftests.c: Fix common/ includes.
6886         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6887         * unittests/function-view-selftests.c: Fix common/ includes.
6888         * unittests/environ-selftests.c: Fix common/ includes.
6889         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6890         * unittests/common-utils-selftests.c: Fix common/ includes.
6891         * unittests/cli-utils-selftests.c: Fix common/ includes.
6892         * unittests/array-view-selftests.c: Fix common/ includes.
6893         * ui-file.c: Fix common/ includes.
6894         * tui/tui-io.c: Fix common/ includes.
6895         * tracepoint.h: Fix common/ includes.
6896         * tracepoint.c: Fix common/ includes.
6897         * tracefile-tfile.c: Fix common/ includes.
6898         * top.h: Fix common/ includes.
6899         * top.c: Fix common/ includes.
6900         * thread.c: Fix common/ includes.
6901         * target/waitstatus.h: Fix common/ includes.
6902         * target/waitstatus.c: Fix common/ includes.
6903         * target.h: Fix common/ includes.
6904         * target.c: Fix common/ includes.
6905         * target-memory.c: Fix common/ includes.
6906         * target-descriptions.c: Fix common/ includes.
6907         * symtab.h: Fix common/ includes.
6908         * symfile.c: Fix common/ includes.
6909         * stap-probe.c: Fix common/ includes.
6910         * spu-linux-nat.c: Fix common/ includes.
6911         * sparc-nat.c: Fix common/ includes.
6912         * source.c: Fix common/ includes.
6913         * solib.c: Fix common/ includes.
6914         * solib-target.c: Fix common/ includes.
6915         * ser-unix.c: Fix common/ includes.
6916         * ser-tcp.c: Fix common/ includes.
6917         * ser-pipe.c: Fix common/ includes.
6918         * ser-base.c: Fix common/ includes.
6919         * selftest-arch.c: Fix common/ includes.
6920         * s12z-tdep.c: Fix common/ includes.
6921         * rust-exp.y: Fix common/ includes.
6922         * rs6000-aix-tdep.c: Fix common/ includes.
6923         * riscv-tdep.c: Fix common/ includes.
6924         * remote.c: Fix common/ includes.
6925         * remote-notif.h: Fix common/ includes.
6926         * remote-fileio.h: Fix common/ includes.
6927         * remote-fileio.c: Fix common/ includes.
6928         * regcache.h: Fix common/ includes.
6929         * regcache.c: Fix common/ includes.
6930         * record-btrace.c: Fix common/ includes.
6931         * python/python.c: Fix common/ includes.
6932         * python/py-type.c: Fix common/ includes.
6933         * python/py-inferior.c: Fix common/ includes.
6934         * progspace.h: Fix common/ includes.
6935         * producer.c: Fix common/ includes.
6936         * procfs.c: Fix common/ includes.
6937         * proc-api.c: Fix common/ includes.
6938         * printcmd.c: Fix common/ includes.
6939         * ppc-linux-nat.c: Fix common/ includes.
6940         * parser-defs.h: Fix common/ includes.
6941         * osdata.c: Fix common/ includes.
6942         * obsd-nat.c: Fix common/ includes.
6943         * nat/x86-linux.c: Fix common/ includes.
6944         * nat/x86-linux-dregs.c: Fix common/ includes.
6945         * nat/x86-dregs.h: Fix common/ includes.
6946         * nat/x86-dregs.c: Fix common/ includes.
6947         * nat/ppc-linux.c: Fix common/ includes.
6948         * nat/mips-linux-watch.h: Fix common/ includes.
6949         * nat/mips-linux-watch.c: Fix common/ includes.
6950         * nat/linux-waitpid.c: Fix common/ includes.
6951         * nat/linux-ptrace.h: Fix common/ includes.
6952         * nat/linux-ptrace.c: Fix common/ includes.
6953         * nat/linux-procfs.c: Fix common/ includes.
6954         * nat/linux-personality.c: Fix common/ includes.
6955         * nat/linux-osdata.c: Fix common/ includes.
6956         * nat/linux-namespaces.c: Fix common/ includes.
6957         * nat/linux-btrace.h: Fix common/ includes.
6958         * nat/linux-btrace.c: Fix common/ includes.
6959         * nat/fork-inferior.c: Fix common/ includes.
6960         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6961         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6962         * nat/aarch64-linux.c: Fix common/ includes.
6963         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6964         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6965         * namespace.h: Fix common/ includes.
6966         * mips-linux-tdep.c: Fix common/ includes.
6967         * minsyms.c: Fix common/ includes.
6968         * mi/mi-parse.h: Fix common/ includes.
6969         * mi/mi-main.c: Fix common/ includes.
6970         * mi/mi-cmd-env.c: Fix common/ includes.
6971         * memrange.h: Fix common/ includes.
6972         * memattr.c: Fix common/ includes.
6973         * maint.h: Fix common/ includes.
6974         * maint.c: Fix common/ includes.
6975         * main.c: Fix common/ includes.
6976         * machoread.c: Fix common/ includes.
6977         * location.c: Fix common/ includes.
6978         * linux-thread-db.c: Fix common/ includes.
6979         * linux-nat.c: Fix common/ includes.
6980         * linux-fork.c: Fix common/ includes.
6981         * inline-frame.c: Fix common/ includes.
6982         * infrun.c: Fix common/ includes.
6983         * inflow.c: Fix common/ includes.
6984         * inferior.h: Fix common/ includes.
6985         * inferior.c: Fix common/ includes.
6986         * infcmd.c: Fix common/ includes.
6987         * inf-ptrace.c: Fix common/ includes.
6988         * inf-child.c: Fix common/ includes.
6989         * ia64-linux-nat.c: Fix common/ includes.
6990         * i387-tdep.c: Fix common/ includes.
6991         * i386-tdep.c: Fix common/ includes.
6992         * i386-linux-tdep.c: Fix common/ includes.
6993         * i386-linux-nat.c: Fix common/ includes.
6994         * i386-go32-tdep.c: Fix common/ includes.
6995         * i386-fbsd-tdep.c: Fix common/ includes.
6996         * i386-fbsd-nat.c: Fix common/ includes.
6997         * guile/scm-type.c: Fix common/ includes.
6998         * guile/guile.c: Fix common/ includes.
6999         * go32-nat.c: Fix common/ includes.
7000         * gnu-nat.c: Fix common/ includes.
7001         * gdbthread.h: Fix common/ includes.
7002         * gdbarch-selftests.c: Fix common/ includes.
7003         * gdb_usleep.c: Fix common/ includes.
7004         * gdb_select.h: Fix common/ includes.
7005         * gdb_bfd.c: Fix common/ includes.
7006         * gcore.c: Fix common/ includes.
7007         * fork-child.c: Fix common/ includes.
7008         * findvar.c: Fix common/ includes.
7009         * fbsd-nat.c: Fix common/ includes.
7010         * event-top.c: Fix common/ includes.
7011         * event-loop.c: Fix common/ includes.
7012         * dwarf2read.c: Fix common/ includes.
7013         * dwarf2loc.c: Fix common/ includes.
7014         * dwarf2-frame.c: Fix common/ includes.
7015         * dwarf-index-cache.c: Fix common/ includes.
7016         * dtrace-probe.c: Fix common/ includes.
7017         * disasm-selftests.c: Fix common/ includes.
7018         * defs.h: Fix common/ includes.
7019         * csky-tdep.c: Fix common/ includes.
7020         * cp-valprint.c: Fix common/ includes.
7021         * cp-support.h: Fix common/ includes.
7022         * cp-support.c: Fix common/ includes.
7023         * corelow.c: Fix common/ includes.
7024         * completer.h: Fix common/ includes.
7025         * completer.c: Fix common/ includes.
7026         * compile/compile.c: Fix common/ includes.
7027         * compile/compile-loc2c.c: Fix common/ includes.
7028         * compile/compile-cplus-types.c: Fix common/ includes.
7029         * compile/compile-cplus-symbols.c: Fix common/ includes.
7030         * command.h: Fix common/ includes.
7031         * cli/cli-dump.c: Fix common/ includes.
7032         * cli/cli-cmds.c: Fix common/ includes.
7033         * charset.c: Fix common/ includes.
7034         * build-id.c: Fix common/ includes.
7035         * btrace.h: Fix common/ includes.
7036         * btrace.c: Fix common/ includes.
7037         * breakpoint.h: Fix common/ includes.
7038         * breakpoint.c: Fix common/ includes.
7039         * ax.h:
7040         (enum agent_op): Fix common/ includes.
7041         * ax-general.c (struct aop_map): Fix common/ includes.
7042         * ax-gdb.c: Fix common/ includes.
7043         * auxv.c: Fix common/ includes.
7044         * auto-load.c: Fix common/ includes.
7045         * arm-tdep.c: Fix common/ includes.
7046         * arch/riscv.c: Fix common/ includes.
7047         * arch/ppc-linux-common.c: Fix common/ includes.
7048         * arch/i386.c: Fix common/ includes.
7049         * arch/arm.c: Fix common/ includes.
7050         * arch/arm-linux.c: Fix common/ includes.
7051         * arch/arm-get-next-pcs.c: Fix common/ includes.
7052         * arch/amd64.c: Fix common/ includes.
7053         * arch/aarch64.c: Fix common/ includes.
7054         * arch/aarch64-insn.c: Fix common/ includes.
7055         * arch-utils.c: Fix common/ includes.
7056         * amd64-windows-tdep.c: Fix common/ includes.
7057         * amd64-tdep.c: Fix common/ includes.
7058         * amd64-sol2-tdep.c: Fix common/ includes.
7059         * amd64-obsd-tdep.c: Fix common/ includes.
7060         * amd64-nbsd-tdep.c: Fix common/ includes.
7061         * amd64-linux-tdep.c: Fix common/ includes.
7062         * amd64-linux-nat.c: Fix common/ includes.
7063         * amd64-fbsd-tdep.c: Fix common/ includes.
7064         * amd64-fbsd-nat.c: Fix common/ includes.
7065         * amd64-dicos-tdep.c: Fix common/ includes.
7066         * amd64-darwin-tdep.c: Fix common/ includes.
7067         * agent.c: Fix common/ includes.
7068         * ada-lang.h: Fix common/ includes.
7069         * ada-lang.c: Fix common/ includes.
7070         * aarch64-tdep.c: Fix common/ includes.
7071
7072 2019-01-25  Tom Tromey  <tom@tromey.com>
7073
7074         * common/create-version.sh: Use common/version.h.
7075
7076 2019-01-24  Pedro Alves  <palves@redhat.com>
7077
7078         * infrun.c (signal_stop, signal_print, signal_program)
7079         (signal_catch, signal_pass): Now arrays instead of pointers.
7080         (update_signals_program_target, do_target_resume)
7081         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7082         * linux-nat.c (linux_nat_target::pass_signals)
7083         (linux_nat_target::create_inferior, linux_nat_target::attach):
7084         Adjust.
7085         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7086         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7087         * procfs.c (procfs_target::pass_signals): Adjust.
7088         * record-full.c (record_full_target::resume): Adjust.
7089         * remote.c (remote_target::pass_signals)
7090         (remote_target::program_signals): Adjust.
7091         * target-debug.h (target_debug_print_signals): Now takes a
7092         gdb::array_view as parameter.  Adjust.
7093         * target.h (target_ops) <pass_signals, program_signals>: Replace
7094         pointer and length parameters with gdb::array_view.
7095         (target_pass_signals, target_program_signals): Likewise.
7096         * target-delegates.c: Regenerate.
7097
7098 2019-01-24  Pedro Alves  <palves@redhat.com>
7099
7100         * common/forward-scope-exit.h
7101         (forward_scope_exit::forward_scope_exit): Pass arguments to
7102         m_bind_function directly, instead of creating a std::bind and
7103         copying that.
7104
7105 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7106
7107         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7108         for static members.
7109         (pass_in_v_vfp_candidate): Likewise.
7110
7111 2019-01-23  Tom Tromey  <tom@tromey.com>
7112             Pedro Alves  <palves@redhat.com>
7113
7114         * regcache.c (class regcache_invalidator): Remove.
7115         (regcache::raw_write): Use make_scope_exit.
7116
7117 2019-01-23  Tom Tromey  <tom@tromey.com>
7118
7119         * ui-out.h (class ui_out_emit_type): Update comment.
7120
7121 2019-01-23  Tom Tromey  <tom@tromey.com>
7122
7123         * infrun.c (fetch_inferior_event): Update comment.
7124
7125 2019-01-23  Tom Tromey  <tom@tromey.com>
7126             Pedro Alves  <palves@redhat.com>
7127
7128         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7129         parameter.
7130         (fetch_inferior_event): Use SCOPE_EXIT.
7131
7132
7133 2019-01-23  Tom Tromey  <tom@tromey.com>
7134             Pedro Alves  <palves@redhat.com>
7135
7136         * infrun.c (disable_thread_events): Delete.
7137         (stop_all_threads): Use SCOPE_EXIT.
7138
7139 2019-01-23  Tom Tromey  <tom@tromey.com>
7140             Pedro Alves  <palves@redhat.com>
7141
7142         * symfile.c: Include forward-scope-exit.h.
7143         (clear_symtab_users_cleanup): Replace forward declaration with
7144         a FORWARD_SCOPE_EXIT.
7145         (syms_from_objfile_1): Use the forward_scope_exit and
7146         gdb::optional instead of cleanup_function.
7147         (reread_symbols): Use the forward_scope_exit instead of
7148         cleanup_function.
7149         (clear_symtab_users_cleanup): Remove function.
7150
7151 2019-01-23  Tom Tromey  <tom@tromey.com>
7152             Pedro Alves  <palves@redhat.com>
7153
7154         * linux-nat.c: Include scope-exit.h.
7155         (cleanup_target_stop): Remove.
7156         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7157         SCOPE_EXIT.
7158
7159 2019-01-23  Tom Tromey  <tom@tromey.com>
7160             Pedro Alves  <palves@redhat.com>
7161
7162         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7163         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7164
7165 2019-01-23  Tom Tromey  <tom@tromey.com>
7166             Andrew Burgess  <andrew.burgess@embecosm.com>
7167             Pedro Alves  <palves@redhat.com>
7168
7169         * infrun.c (fetch_inferior_event): Use scope_exit.
7170         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7171         * top.c (execute_command): Use scope_exit.
7172         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7173         * utils.c (do_bpstat_clear_actions_cleanup)
7174         (make_bpstat_clear_actions_cleanup): Remove.
7175
7176 2019-01-23  Tom Tromey  <tom@tromey.com>
7177             Pedro Alves  <palves@redhat.com>
7178
7179         * infrun.c: Include "common/scope-exit.h"
7180         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7181         (wait_for_inferior): Use SCOPE_EXIT.
7182         (fetch_inferior_event): Use scope_exit.
7183
7184 2019-01-23  Tom Tromey  <tom@tromey.com>
7185             Pedro Alves  <palves@redhat.com>
7186
7187         * breakpoint.c (create_breakpoint): Remove cleanup.
7188
7189 2019-01-23  Tom Tromey  <tom@tromey.com>
7190             Andrew Burgess  <andrew.burgess@embecosm.com>
7191             Pedro Alves  <palves@redhat.com>
7192
7193 2019-01-23  Pedro Alves  <palves@redhat.com>
7194
7195         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7196
7197 2019-01-23  Pedro Alves  <palves@redhat.com>
7198             Andrew Burgess  <andrew.burgess@embecosm.com>
7199
7200         * gdbthread.h: Include "common/forward-scope-exit.h".
7201         (scoped_finish_thread_state): Redefine custom class in terms of
7202         forward_scope_exit.
7203
7204 2019-01-23  Pedro Alves  <palves@redhat.com>
7205             Andrew Burgess  <andrew.burgess@embecosm.com>
7206
7207         * common/forward-scope-exit.h: New file.
7208
7209 2019-01-23  Pedro Alves  <palves@redhat.com>
7210             Andrew Burgess  <andrew.burgess@embecosm.com>
7211             Tom Tromey  <tom@tromey.com>
7212
7213         * common/scope-exit.h: New file.
7214
7215 2019-01-23  Pedro Alves  <palves@redhat.com>
7216
7217         * common/preprocessor.h (ESC): Rename to ...
7218         (ESC_PARENS): ... this.
7219         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7220         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7221
7222 2019-01-23  Tom Tromey  <tom@tromey.com>
7223
7224         * language.h (class scoped_switch_to_sym_language_if_auto):
7225         Initialize m_lang in both cases.
7226
7227 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7228
7229         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7230         with XCNEW.
7231
7232 2019-01-22  Tom Tromey  <tom@tromey.com>
7233
7234         * corelow.c: Do not include sys/file.h.
7235
7236 2019-01-22  Tom Tromey  <tom@tromey.com>
7237
7238         * tui/tui-wingeneral.h: Include gdb_curses.h.
7239
7240 2019-01-22  Tom Tromey  <tom@tromey.com>
7241
7242         * source-cache.h (class source_cache) <get_source_lines,
7243         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7244
7245 2019-01-22  Tom Tromey  <tom@tromey.com>
7246
7247         * remote-fileio.h (struct remote_target): Declare.
7248
7249 2019-01-22  Tom Tromey  <tom@tromey.com>
7250
7251         * python/py-arch.c: Do not include py-ref.h.
7252         * python/py-bpevent.c: Do not include py-ref.h.
7253         * python/py-cmd.c: Do not include py-ref.h.
7254         * python/py-continueevent.c: Do not include py-ref.h.
7255         * python/py-event.h: Do not include py-ref.h.
7256         * python/py-evtregistry.c: Do not include py-ref.h.
7257         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7258         * python/py-frame.c: Do not include py-ref.h.
7259         * python/py-framefilter.c: Do not include py-ref.h.
7260         * python/py-function.c: Do not include py-ref.h.
7261         * python/py-infevents.c: Do not include py-ref.h.
7262         * python/py-linetable.c: Do not include py-ref.h.
7263         * python/py-objfile.c: Do not include py-ref.h.
7264         * python/py-param.c: Do not include py-ref.h.
7265         * python/py-prettyprint.c: Do not include py-ref.h.
7266         * python/py-progspace.c: Do not include py-ref.h.
7267         * python/py-symbol.c: Do not include py-ref.h.
7268         * python/py-symtab.c: Do not include py-ref.h.
7269         * python/py-type.c: Do not include py-ref.h.
7270         * python/py-unwind.c: Do not include py-ref.h.
7271         * python/py-utils.c: Do not include py-ref.h.
7272         * python/py-value.c: Do not include py-ref.h.
7273         * python/py-varobj.c: Do not include py-ref.h.
7274         * python/py-xmethods.c: Do not include py-ref.h.
7275         * python/python.c: Do not include py-ref.h.
7276         * varobj.c: Do not include py-ref.h.
7277
7278 2019-01-22  Tom Tromey  <tom@tromey.com>
7279
7280         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7281         keyword for bcache.
7282
7283 2019-01-22  Tom Tromey  <tom@tromey.com>
7284
7285         * compile/compile-cplus-types.c: Remove a comment by #include.
7286
7287 2019-01-22  Tom Tromey  <tom@tromey.com>
7288
7289         * compile/gcc-c-plugin.h: Include compile-internal.h.
7290
7291 2019-01-22  Tom Tromey  <tom@tromey.com>
7292
7293         * stabsread.c (EXTERN): Do not define.
7294         (symnum, next_symbol_text_func, processing_gcc_compilation)
7295         (within_function, global_sym_chain, global_stabs)
7296         (previous_stab_code, this_object_header_files)
7297         (n_this_object_header_files)
7298         (n_allocated_this_object_header_files): Define.
7299         * stabsread.h (EXTERN): Never define.  Use "extern".
7300
7301 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7302
7303         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7304         history_value.
7305
7306 2019-01-21  Tom Tromey  <tom@tromey.com>
7307
7308         * ui-out.c: Fix includes.
7309         * tui/tui-source.c: Fix includes.
7310         * target.c: Fix includes.
7311         * remote.c: Fix includes.
7312         * regcache.c: Fix includes.
7313         * python/py-block.c: Fix includes.
7314         * printcmd.c: Fix includes.
7315         * or1k-tdep.c: Fix includes.
7316         * mi/mi-main.c: Fix includes.
7317         * m32r-tdep.c: Fix includes.
7318         * csky-tdep.c: Fix includes.
7319         * compile/compile-cplus-types.c: Fix includes.
7320         * cli/cli-interp.c: Fix includes.
7321
7322 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7323
7324         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7325         for padding.
7326
7327 2019-01-16  Tom Tromey  <tom@tromey.com>
7328
7329         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7330         earlier.
7331         (struct objfile) <msymbols_range>: Move from top level.
7332         <msymbols>: New method.
7333         (class objfile_msymbols): Remove.
7334         * symtab.c (default_collect_symbol_completion_matches_break_on):
7335         Update.
7336         * symmisc.c (dump_msymbols): Update.
7337         * stabsread.c (scan_file_globals): Update.
7338         * objc-lang.c (info_selectors_command, info_classes_command)
7339         (find_methods): Update.
7340         * minsyms.c (find_solib_trampoline_target): Update.
7341         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7342         * coffread.c (coff_symfile_read): Update.
7343         * ada-lang.c (ada_lookup_simple_minsym)
7344         (ada_collect_symbol_completion_matches): Update.
7345
7346 2019-01-16  Tom Tromey  <tom@tromey.com>
7347
7348         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7349         type.  Remove no-argument constructor.
7350         <iterator::operator++>: Simplify.
7351         <begin>: Update.
7352         <end>: Use minimal_symbol_count.
7353
7354 2019-01-16  Tom Tromey  <tom@tromey.com>
7355
7356         * objfiles.h (struct objfile) <psymtabs>: New method.
7357         (class objfile_psymtabs): Remove.
7358         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7359         typedef.
7360         <range>: New method.
7361         (require_partial_symbols): Change return type.
7362         * psymtab.c (require_partial_symbols)
7363         (psym_expand_symtabs_matching): Update.
7364         * mdebugread.c (parse_partial_symbols): Update.
7365         * dbxread.c (dbx_end_psymtab): Update.
7366
7367 2019-01-15  Tom Tromey  <tom@tromey.com>
7368
7369         * symtab.c (lookup_objfile_from_block)
7370         (lookup_symbol_in_objfile_symtabs)
7371         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7372         (find_line_symtab, info_sources_command)
7373         (default_collect_symbol_completion_matches_break_on)
7374         (make_source_files_completion_list): Update.
7375         * symmisc.c (print_objfile_statistics, dump_objfile)
7376         (maintenance_print_symbols, maintenance_info_symtabs)
7377         (maintenance_check_symtabs, maintenance_info_line_tables):
7378         Update.
7379         * source.c (select_source_symtab)
7380         (forget_cached_source_info_for_objfile): Update.
7381         * objfiles.h (class objfile_compunits): Remove.
7382         (struct objfile) <compunits_range>: New typedef.
7383         (compunits): New method.
7384         * objfiles.c (objfile_relocate1): Update.
7385         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7386         * maint.c (count_symtabs_and_blocks): Update.
7387         * linespec.c (iterate_over_all_matching_symtabs): Update.
7388         * cp-support.c (add_symbol_overload_list_qualified): Update.
7389         * coffread.c (coff_symtab_read): Update.
7390         * ada-lang.c (add_nonlocal_symbols)
7391         (ada_collect_symbol_completion_matches)
7392         (ada_add_global_exceptions): Update.
7393
7394 2019-01-15  Tom Tromey  <tom@tromey.com>
7395
7396         * progspace.h (program_space) <objfiles_safe_range>: New
7397         typedef.
7398         <objfiles_safe>: New method.
7399         * objfiles.h (class all_objfiles_safe): Remove.
7400         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7401         * jit.c (jit_inferior_exit_hook): Update.
7402
7403 2019-01-17  Tom Tromey  <tom@tromey.com>
7404
7405         * progspace.h (program_space) <objfiles_range>: New typedef.
7406         <objfiles>: New method.
7407         <objfiles_head>: Rename from objfiles.
7408         (object_files): Update.
7409         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7410         * guile/scm-pretty-print.c
7411         (ppscm_find_pretty_printer_from_objfiles): Update.
7412         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7413         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7414         Update.
7415         * python/py-progspace.c (pspy_get_objfiles): Update.
7416         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7417         Update.
7418         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7419         (objfpy_lookup_objfile_by_build_id): Update.
7420         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7421         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7422         Update.
7423         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7424         (expand_symtab_containing_pc, lookup_objfile_from_block)
7425         (lookup_static_symbol, basic_lookup_transparent_type)
7426         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7427         (find_line_symtab, info_sources_command)
7428         (default_collect_symbol_completion_matches_break_on)
7429         (make_source_files_completion_list, find_main_name): Update.
7430         * symmisc.c (print_symbol_bcache_statistics)
7431         (print_objfile_statistics, maintenance_print_symbols)
7432         (maintenance_print_msymbols, maintenance_print_objfiles)
7433         (maintenance_info_symtabs, maintenance_check_symtabs)
7434         (maintenance_expand_symtabs, maintenance_info_line_tables):
7435         Update.
7436         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7437         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7438         (map_overlay_command, unmap_overlay_command)
7439         (simple_overlay_update, expand_symtabs_matching)
7440         (map_symbol_filenames): Update.
7441         * symfile-debug.c (set_debug_symfile): Update.
7442         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7443         Update.
7444         * source.c (select_source_symtab, forget_cached_source_info):
7445         Update.
7446         * solib.c (solib_read_symbols): Update.
7447         * solib-spu.c (append_ocl_sos): Update.
7448         * psymtab.c (maintenance_print_psymbols)
7449         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7450         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7451         * printcmd.c (info_symbol_command): Update.
7452         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7453         Update.
7454         * objfiles.h (class all_objfiles): Remove.
7455         * objfiles.c (have_partial_symbols, have_full_symbols)
7456         (have_minimal_symbols, qsort_cmp, update_section_map)
7457         (shared_objfile_contains_address_p)
7458         (default_iterate_over_objfiles_in_search_order): Update.
7459         * objc-lang.c (info_selectors_command, info_classes_command)
7460         (find_methods): Update.
7461         * minsyms.c (find_solib_trampoline_target): Update.
7462         * maint.c (maintenance_info_sections)
7463         (maintenance_translate_address, count_symtabs_and_blocks):
7464         Update.
7465         * main.c (captured_main_1): Update.
7466         * linux-thread-db.c (try_thread_db_load_from_pdir)
7467         (has_libpthread): Update.
7468         * linespec.c (iterate_over_all_matching_symtabs)
7469         (search_minsyms_for_name): Update.
7470         * jit.c (jit_find_objf_with_entry_addr): Update.
7471         * hppa-tdep.c (find_unwind_entry)
7472         (hppa_lookup_stub_minimal_symbol): Update.
7473         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7474         Update.
7475         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7476         (elf_gnu_ifunc_resolve_by_got): Update.
7477         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7478         * dwarf-index-write.c (save_gdb_index_command): Update.
7479         * cp-support.c (add_symbol_overload_list_qualified): Update.
7480         * breakpoint.c (create_overlay_event_breakpoint)
7481         (create_longjmp_master_breakpoint)
7482         (create_std_terminate_master_breakpoint)
7483         (create_exception_master_breakpoint): Update.
7484         * blockframe.c (find_pc_partial_function): Update.
7485         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7486         (ada_collect_symbol_completion_matches)
7487         (ada_add_global_exceptions): Update.
7488
7489 2019-01-17  Tom Tromey  <tom@tromey.com>
7490
7491         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7492         declare VEC.
7493         (solib_target_parse_libraries): Change return type.
7494         (library_list_start_segment, library_list_start_section)
7495         (library_list_end_library, library_list_start_library); Update.
7496         (solib_target_free_library_list): Remove.
7497         (solib_target_parse_libraries): Remove cleanup.  Change return
7498         type.
7499         (solib_target_current_sos): Update.
7500
7501 2019-01-17  Tom Tromey  <tromey@bapiya>
7502
7503         * valprint.c: Replace "the the" with "the".
7504         * symtab.c: Replace "the the" with "the".
7505         * solib.c: Replace "the the" with "the".
7506         * solib-dsbt.c: Replace "the the" with "the".
7507         * linespec.c: Replace "the the" with "the".
7508         * dwarf2loc.h: Replace "the the" with "the".
7509         * amd64-windows-tdep.c: Replace "the the" with "the".
7510         * aarch64-tdep.c: Replace "the the" with "the".
7511
7512 2019-01-16  Keith Seitz  <keiths@redhat.com>
7513
7514         PR gdb/23773
7515         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7516         <builder>: Rename to ..
7517         <m_builder>: ... this and make private.
7518         (dwarf2_cu::get_builder): New method.  Change all users of
7519         `builder' to use this method.
7520         (dwarf2_start_symtab): Move to ...
7521         (dwarf2_cu::start_symtab): ... here.  Update all callers
7522         (setup_type_unit_groups): Move to ...
7523         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7524         callers.
7525         (dwarf2_cu::reset_builder): New method.
7526         (process_full_compunit, process_full_type_unit): Use
7527         dwarf2_cu::reset_builder.
7528         (follow_die_offset): Record the ancestor CU if it is different
7529         from the followed DIE's CU.
7530         (follow_die_sig_1): Likewise.
7531
7532 2019-01-15  Tom Tromey  <tom@tromey.com>
7533
7534         * remote.c (class remote_state) <buf>: Now a char_vector.
7535         <buf_size>: Remove.
7536         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7537         parameter.
7538         (remote_target::getpkt_or_notif_sane_1)
7539         (remote_target::getpkt_sane)
7540         (remote_target::getpkt_or_notif_sane): Likewise.
7541         (class remote_target) <putpkt>: New overload.
7542         (remote_target::read_frame): Change type of "buf_p".  Remove
7543         sizeof_p parameter.
7544         (packet_ok): New overload.
7545         (packet_check_result): New overload.
7546         Update all uses.
7547
7548 2019-01-14  Tom Tromey  <tom@tromey.com>
7549
7550         * remote-notif.c (handle_notification, remote_notif_ack)
7551         (remote_notif_parse): Make "buf" const.
7552         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7553         const.
7554         (remote_notif_parse, remote_notif_ack, handle_notification):
7555         Likewise.
7556         * remote.c (remote_notif_stop_parse): Make "buf" const.
7557         (remote_target::remote_parse_stop_reply): Make "buf" const.
7558         (remote_notif_stop_ack): Make "buf" const.
7559
7560 2019-01-14  Tom Tromey  <tom@tromey.com>
7561
7562         * remote.c (remote_console_output): Make parameter const.
7563
7564 2019-01-14  Tom Tromey  <tom@tromey.com>
7565
7566         * target-debug.h (target_debug_print_signals): Constify.
7567         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7568         * procfs.c (procfs_target::pass_signals): Update.
7569         * linux-nat.c (linux_nat_target::pass_signals): Update.
7570         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7571         * target-delegates.c: Rebuild.
7572         * remote.c (remote_target::program_signals): Update.
7573         (remote_target::pass_signals): Update.
7574         * target.c (target_pass_signals): Constify argument.
7575         (target_program_signals): Likewise.
7576         * target.h (struct target_ops) <pass_signals, program_signals>:
7577         Constify argument.
7578         (target_pass_signals, target_program_signals): Constify argument.
7579
7580 2019-01-14  Tom Tromey  <tom@tromey.com>
7581
7582         PR tui/28819:
7583         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7584
7585 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7586
7587         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7588         field.
7589         * rs6000-tdep.c: Include reggroups.h.
7590         (IS_V_ALIAS_PSEUDOREG): Define.
7591         (rs6000_register_name): Return names for the "vX" aliases.
7592         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7593         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7594         aliases.  Call default_register_reggroup_p for all other
7595         pseudo-registers.
7596         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7597         New functions.
7598         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7599         Handle "vX" aliases.
7600         (v_alias_pseudo_register_collect): New function.
7601         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7602         (rs6000_gdbarch_init): Initialize "vX" aliases as
7603         pseudo-registers.  Restore registration of
7604         rs6000_pseudo_register_reggroup_p with
7605         set_tdesc_pseudo_register_reggroup_p.
7606
7607 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7608
7609         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7610         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7611         set_gdbarch_num_pseudo_regs.
7612
7613 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7614
7615         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7616         Remove arg prefixname, add do_set and do_show.
7617         Add member functions set_list and show_list.
7618         * cli/cli-style.c (class cli_style_option): Update accordingly.
7619         (style_set_list): Move to file scope.
7620         (style_show_list): Likewise.
7621         (set_style): Call help_list.
7622         (show_style): Call cmd_show_list.
7623         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7624         Update to use the new macro.
7625
7626 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7627
7628         * ada-lang.c (_initialize_ada_language): Expand the help text
7629         for the "catch exception" command.
7630
7631 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7632
7633         * symtab.c (matching_obj_sections): Initialize obj,
7634         declare it closer to its usage.
7635
7636 2019-01-10  Tom Tromey  <tom@tromey.com>
7637
7638         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7639         (basic_inf_threads_range): Remove.
7640         (inf_threads_range, inf_non_exited_threads_range)
7641         (safe_inf_threads_range): Use next_adapter.
7642
7643 2019-01-10  Keith Seitz  <keiths@redhat.com>
7644
7645         PR gdb/23712
7646         PR symtab/23010
7647         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7648         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7649
7650 2019-01-10  Keith Seitz  <keiths@redhat.com>
7651
7652         PR gdb/23712
7653         PR symtab/23010
7654         * dictionary.c (pending_to_vector): Remove.
7655         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7656         Remove _1 suffix, replacing functions of the same name.  Update
7657         all callers.
7658         (dict_create_hashed, dict_create_hashed_expandable)
7659         (dict_create_linear, dict_create_linear_expandable, dict_free)
7660         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7661         Make functions static.
7662
7663 2019-01-10  Keith Seitz  <keiths@redhat.com>
7664
7665         PR gdb/23712
7666         PR symtab/23010
7667         * dictionary.h (struct dictionary): Replace declaration with
7668         multidictionary.
7669         (dict_create_hashed, dict_create_hashed_expandable)
7670         (dict_create_linear, dict_create_linear_expandable)
7671         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7672         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7673         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7674         taking multidictionary argument.
7675         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7676         * block.h (struct block) <dict>: Change to multidictionary
7677         and rename `multidict'.
7678         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7679         symmisc.c: Update all dictionary references to multidictionary.
7680
7681 2019-01-10  Keith Seitz  <keiths@redhat.com>
7682
7683         PR gdb/23712
7684         PR symtab/23010
7685         * dictionary.c: Include unordered_map.
7686         (pending_to_vector): New function.
7687         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7688         Rewrite the non-"_1" functions to take vector instead
7689         of linked list.
7690         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7691         "new" _1 versions of the same name.
7692         (multidictionary): Define.
7693         (std::hash<enum language): New definition.
7694         (collate_pending_symbols_by_language, mdict_create_hashed)
7695         (mdict_create_hashed_expandable, mdict_create_linear)
7696         (mdict_create_linear_expandable, mdict_free)
7697         (find_language_dictionary, create_new_language_dictionary)
7698         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7699         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7700         (mdict_size, mdict_empty): New functions.
7701         * dictionary.h (mdict_iterator): Define.
7702
7703 2019-01-10  Pedro Alves  <palves@redhat.com>
7704
7705         * breakpoint.c (read_uploaded_action)
7706         (create_tracepoint_from_upload): Adjust to use
7707         gdb::unique_xmalloc_ptr.
7708         * ctf.c (ctf_write_uploaded_tp):
7709         (SET_ARRAY_FIELD): Use emplace_back.
7710         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7711         * tracefile-tfile.c (tfile_write_uploaded_tp):
7712         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7713         gdb::unique_xmalloc_ptr.
7714         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7715         at_string, cond_string, cmd_strings>: Replace char pointers
7716         with gdb::unique_xmalloc_ptr.
7717
7718 2019-01-10  Pedro Alves  <palves@redhat.com>
7719
7720         * solib-target.c (library_list_start_library): Don't xstrdup name.
7721
7722 2019-01-10  Pedro Alves  <palves@redhat.com>
7723
7724         * mdebugread.c (parse_partial_symbols): Use
7725         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7726
7727 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7728
7729         * linux-fork.c (scoped_switch_fork_info)
7730         <~scoped_switch_fork_info>: Fix incorrect variable name.
7731
7732 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7733
7734         * linux-fork.c (scoped_switch_fork_info)
7735         <scoped_switch_fork_info>: Make explicit.
7736         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7737
7738 2019-01-10  Tom Tromey  <tom@tromey.com>
7739
7740         * objfiles.h (objfile::reset_psymtabs): Update.
7741         * objfiles.c (objfile::objfile): Update.
7742         * psymtab.h (psymtab_storage::obstack): Update.
7743         (psymtab_storage::m_obstack): Use gdb::optional.
7744         (class psymtab_storage): Update comment.  Remove objfile
7745         parameter.
7746         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7747
7748 2019-01-10  Tom Tromey  <tom@tromey.com>
7749
7750         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7751         <free_psymtabs>: Now private.
7752         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7753         (allocate_psymtab): Use new method.
7754
7755 2019-01-10  Tom Tromey  <tom@tromey.com>
7756
7757         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7758         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7759         * mdebugread.c (parse_partial_symbols): Use
7760         allocate_dependencies.
7761         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7762         allocate_dependencies.
7763         (process_psymtab_comp_unit_reader)
7764         (build_type_psymtab_dependencies): Likewise.
7765         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7766
7767 2019-01-10  Tom Tromey  <tom@tromey.com>
7768
7769         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7770         PSYMBOL_SET_LANGUAGE.
7771         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7772
7773 2019-01-10  Tom Tromey  <tom@tromey.com>
7774
7775         * psymtab.h (psymtab_storage::obstack): New method.
7776         <m_obstack>: Rename from obstack; now private.
7777         * psymtab.c (psymtab_storage): Update.
7778         * dwarf2read.c (create_addrmap_from_index)
7779         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7780         Update.
7781
7782 2019-01-10  Tom Tromey  <tom@tromey.com>
7783
7784         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7785         * objfiles.h (objfile::reset_psymtabs): New method.
7786
7787 2019-01-10  Tom Tromey  <tom@tromey.com>
7788
7789         * symmisc.c (print_symbol_bcache_statistics): Update.
7790         (print_objfile_statistics): Update.
7791         * symfile.c (reread_symbols): Update.
7792         * psymtab.h (class psymtab_storage): New.
7793         * psymtab.c (psymtab_storage): New constructor.
7794         (~psymtab_storage): New destructor.
7795         (require_partial_symbols): Update.
7796         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7797         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7798         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7799         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7800         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7801         (start_psymtab_common, end_psymtab_common)
7802         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7803         (allocate_psymtab): Update.
7804         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7805         Update.
7806         (dump_psymtab_addrmap, maintenance_print_psymbols)
7807         (maintenance_check_psymtabs): Update.
7808         (class objfile_psymtabs): Move to objfiles.h.
7809         * psympriv.h (discard_psymtab): Now inline.
7810         (psymtab_discarder::psymtab_discarder): Update.
7811         (psymtab_discarder::~psymtab_discarder): Update.
7812         (ALL_OBJFILE_PSYMTABS): Rewrite.
7813         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7814         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7815         Remove fields.
7816         <partial_symtabs>: New field.
7817         (class objfile_psymtabs): Move from psymtab.h.  Update.
7818         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7819         psymbol_cache.
7820         (objfile::~objfile): Don't destroy psymbol_cache.
7821         * mdebugread.c (parse_partial_symbols): Update.
7822         * dwarf2read.c (create_addrmap_from_index)
7823         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7824         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7825         (add_partial_subprogram, dwarf2_ranges_read): Update.
7826         * dwarf-index-write.c (write_address_map)
7827         (write_one_signatured_type, recursively_write_psymbols)
7828         (class debug_names, class debug_names, write_psymtabs_to_index):
7829         Update.
7830
7831 2019-01-10  Tom Tromey  <tom@tromey.com>
7832
7833         * symtab.h (SYMBOL_SET_NAMES): Update.
7834         (symbol_set_names): Update.
7835         (MSYMBOL_SET_NAMES): Update.
7836         * symtab.c (symbol_set_names): Change argument to be an
7837         objfile_per_bfd_storage.
7838         * psymtab.c (add_psymbol_to_bcache): Update.
7839         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7840
7841 2019-01-10  Tom Tromey  <tom@tromey.com>
7842
7843         * symtab.c (create_demangled_names_hash): Change argument to be an
7844         objfile_per_bfd_storage.
7845         (symbol_set_names): Update.
7846
7847 2019-01-10  Tom Tromey  <tom@tromey.com>
7848
7849         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7850         init_psymbol_list.
7851         * psymtab.c (init_psymbol_list): Do nothing if already called.
7852         * psympriv.h (init_psymbol_list): Add comment.
7853         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7854         init_psymbol_list.
7855         * dbxread.c (dbx_symfile_read): Unconditionally call
7856         init_psymbol_list.
7857
7858 2019-01-10  Tom Tromey  <tom@tromey.com>
7859
7860         * xcoffread.c (scan_xcoff_symtab): Update.
7861         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7862         "where".
7863         * mdebugread.c (parse_partial_symbols)
7864         (handle_psymbol_enumerators): Update.
7865         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7866         * dbxread.c (read_dbx_symtab): Update.
7867         * psympriv.h (psymbol_placement): New enum.
7868         (add_psymbol_to_list): Update.
7869
7870 2019-01-10  Tom Tromey  <tom@tromey.com>
7871
7872         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7873         static_psymbols parameters.
7874         (scan_xcoff_symtab): Update.
7875         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7876         static_psymbols parameters.
7877         * psympriv.h (start_psymtab_common): Update.
7878         * mdebugread.c (parse_partial_symbols): Update.
7879         * dwarf2read.c (create_partial_symtab): Update.
7880         * dbxread.c (read_dbx_symtab): Update.
7881         (start_psymtab): Remove global_psymbols and static_psymbols
7882         parameters.
7883
7884 2019-01-10  Tom Tromey  <tom@tromey.com>
7885
7886         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7887         * psymtab.c (allocate_psymtab): Add comment.
7888         * psympriv.h (allocate_psymtab): Add comment.
7889         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7890         initializations.
7891         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7892
7893 2019-01-10  Tom Tromey  <tom@tromey.com>
7894
7895         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7896         Don't declare.
7897         * mipsread.c: Include mdebugread.h.
7898         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7899         Declare.
7900         * elfread.c: Include mdebugread.h.
7901
7902 2019-01-09  Tom Tromey  <tom@tromey.com>
7903
7904         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7905         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7906         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7907         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7908         (psym_lookup_symbol, psym_find_last_source_symtab)
7909         (psym_forget_cached_source_info, psym_print_stats)
7910         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7911         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7912         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7913         (psym_find_compunit_symtab_by_address)
7914         (maintenance_print_psymbols, maintenance_info_psymtabs)
7915         (maintenance_check_psymtabs): Use ranged for.
7916         * psymtab.h (class objfile_psymtabs): New.
7917         (require_partial_symbols): Return objfile_psymtabs.
7918         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7919
7920 2019-01-09  Tom Tromey  <tom@tromey.com>
7921
7922         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7923         (find_pc_mapped_section, list_overlays_command)
7924         (map_overlay_command, unmap_overlay_command)
7925         (simple_overlay_update): Use all_objfiles.
7926         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7927         * printcmd.c (info_symbol_command): Use all_objfiles.
7928         * objfiles.h (ALL_OBJSECTIONS): Remove.
7929         * maint.c (maintenance_translate_address): Use all_objfiles.
7930         * gcore.c (gcore_create_callback): Use all_objfiles.
7931         (objfile_find_memory_regions): Likewise.
7932
7933 2019-01-09  Tom Tromey  <tom@tromey.com>
7934
7935         * symtab.c (find_line_symtab, info_sources_command)
7936         (make_source_files_completion_list): Use objfile_compunits.
7937         * source.c (select_source_symtab): Use objfile_compunits.
7938         * objfiles.h (struct objfile): Update comment.
7939         (ALL_OBJFILES): Remove.
7940         (ALL_FILETABS): Remove.
7941         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7942         objfile_compunits.
7943
7944 2019-01-09  Tom Tromey  <tom@tromey.com>
7945
7946         * symmisc.c (print_objfile_statistics, dump_objfile)
7947         (maintenance_print_symbols): Use compunit_filetabs.
7948         * source.c (forget_cached_source_info_for_objfile): Use
7949         compunit_filetabs.
7950         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7951         (ALL_FILETABS): Use compunit_filetabs.
7952         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7953         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7954
7955 2019-01-09  Tom Tromey  <tom@tromey.com>
7956
7957         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7958         (compunit_filetabs): New.
7959         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7960         compunit_filetabs.
7961         (info_sources_command, make_source_files_completion_list): Remove
7962         declaration.
7963         * symmisc.c (print_objfile_statistics, dump_objfile)
7964         (maintenance_print_symbols): Remove declaration.
7965         (maintenance_info_symtabs): Use compunit_filetabs.
7966         (maintenance_info_line_tables): Likewise.
7967         * source.c (select_source_symtab): Change local variable name.
7968         (forget_cached_source_info_for_objfile): Remove declaration.
7969         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7970         * objfiles.c (objfile_relocate1): Remove declaration.
7971         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7972         declaration.
7973         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7974         * coffread.c (coff_symtab_read): Remove declaration.
7975         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7976         compunit_filetabs.
7977
7978 2019-01-09  Tom Tromey  <tom@tromey.com>
7979
7980         * symtab.c (lookup_objfile_from_block)
7981         (find_pc_sect_compunit_symtab, search_symbols)
7982         (default_collect_symbol_completion_matches_break_on): Use
7983         objfile_compunits.
7984         * objfiles.h (ALL_COMPUNITS): Remove.
7985         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7986         * cp-support.c (add_symbol_overload_list_qualified): Use
7987         objfile_compunits.
7988         * ada-lang.c (ada_collect_symbol_completion_matches)
7989         (ada_add_global_exceptions): Use objfile_compunits.
7990
7991 2019-01-09  Tom Tromey  <tom@tromey.com>
7992
7993         * source.c (select_source_symtab)
7994         (forget_cached_source_info_for_objfile): Remove declaration.
7995         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7996         declaration.
7997         * maint.c (count_symtabs_and_blocks): Remove declaration.
7998         * cp-support.c (add_symbol_overload_list_qualified): Remove
7999         declaration.
8000         * coffread.c (coff_symtab_read): Remove declaration.
8001         * symtab.c (lookup_symbol_in_objfile_symtabs)
8002         (basic_lookup_transparent_type_1): Use objfile_compunits.
8003         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8004         (info_sources_command, search_symbols)
8005         (default_collect_symbol_completion_matches_break_on)
8006         (make_source_files_completion_list): Remove declaration.
8007         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8008         (ada_collect_symbol_completion_matches)
8009         (ada_add_global_exceptions): Remove declaration.
8010         * linespec.c (iterate_over_all_matching_symtabs): Use
8011         objfile_compunits.
8012         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8013         (class objfile_compunits): New.
8014         (ALL_COMPUNITS): Use objfile_compunits.
8015         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8016         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8017         objfile_compunits.
8018         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8019
8020 2019-01-09  Tom Tromey  <tom@tromey.com>
8021
8022         * symtab.c (search_symbols)
8023         (default_collect_symbol_completion_matches_break_on): Use
8024         objfile_msymbols.
8025         * ada-lang.c (ada_lookup_simple_minsym)
8026         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8027         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8028         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8029         objfile_msymbols.
8030         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8031         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8032         * objc-lang.c (find_methods): Use objfile_msymbols.
8033         (info_selectors_command, info_classes_command): Likewise.
8034         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8035         * objfiles.h (class objfile_msymbols): New.
8036         (ALL_OBJFILE_MSYMBOLS): Remove.
8037         (ALL_MSYMBOLS): Remove.
8038
8039 2019-01-09  Tom Tromey  <tom@tromey.com>
8040
8041         * common/next-iterator.h (next_adapter): Add Iterator template
8042         parameter.
8043         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8044         (class all_objfiles_safe): New.
8045         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8046         * objfiles.c (put_objfile_before): Update comment.
8047         (add_separate_debug_objfile): Likewise.
8048         (free_all_objfiles): Use all_objfiles_safe.
8049         (objfile_purge_solibs): Likewise.
8050
8051 2019-01-09  Tom Tromey  <tom@tromey.com>
8052
8053         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8054         (expand_symtab_containing_pc, lookup_static_symbol)
8055         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8056         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8057         all_objfiles.
8058         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8059         * breakpoint.c (create_overlay_event_breakpoint)
8060         (create_longjmp_master_breakpoint)
8061         (create_std_terminate_master_breakpoint)
8062         (create_exception_master_breakpoint): Use all_objfiles.
8063         * linux-thread-db.c (try_thread_db_load_from_pdir)
8064         (has_libpthread): Use all_objfiles.
8065         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8066         * linespec.c (iterate_over_all_matching_symtabs)
8067         (search_minsyms_for_name): Use all_objfiles.
8068         * maint.c (maintenance_info_sections): Use all_objfiles.
8069         * main.c (captured_main_1): Use all_objfiles.
8070         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8071         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8072         * guile/scm-pretty-print.c
8073         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8074         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8075         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8076         (maintenance_print_msymbols): Use all_objfiles.
8077         * source.c (select_source_symtab): Use all_objfiles.
8078         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8079         * symfile.c (remove_symbol_file_command)
8080         (expand_symtabs_matching, map_symbol_filenames): Use
8081         all_objfiles.
8082         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8083         all_objfiles.
8084         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8085         * objc-lang.c (find_methods): Use all_objfiles.
8086         * objfiles.c (have_partial_symbols, have_full_symbols)
8087         (have_minimal_symbols, qsort_cmp)
8088         (default_iterate_over_objfiles_in_search_order): Use
8089         all_objfiles.
8090         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8091         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8092         (maintenance_check_psymtabs): Use all_objfiles.
8093         (ALL_PSYMTABS): Remove.
8094         * compile/compile-object-run.c (do_module_cleanup): Use
8095         all_objfiles.
8096         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8097         * cp-support.c (add_symbol_overload_list_qualified): Use
8098         all_objfiles.
8099         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8100         Use all_objfiles.
8101         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8102         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8103         all_objfiles.
8104         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8105         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8106         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8107         Uses all_objfiles.
8108         * solib.c (solib_read_symbols): Use all_objfiles
8109
8110 2019-01-09  Tom Tromey  <tom@tromey.com>
8111
8112         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8113         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8114         all_objfiles.
8115         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8116         * symmisc.c (print_symbol_bcache_statistics)
8117         (print_objfile_statistics, maintenance_print_objfiles)
8118         (maintenance_info_symtabs, maintenance_check_symtabs)
8119         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8120         all_objfiles.
8121         * source.c (forget_cached_source_info): Use all_objfiles.
8122         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8123         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8124         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8125         * objfiles.c (update_section_map): Use all_objfiles.
8126         (shared_objfile_contains_address_p): Likewise.
8127         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8128         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8129
8130 2019-01-09  Tom Tromey  <tom@tromey.com>
8131
8132         * common/next-iterator.h: New file.
8133         * objfiles.h (class all_objfiles): New.
8134         (struct objfile_iterator): New.
8135
8136 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8137
8138         * NEWS: Move the description of the changed "frame", "select-frame",
8139          and "info frame" commands to the Changed commands section.
8140
8141 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8142
8143         * gdbtypes.c (check_stub_method_group): Remove handling of old
8144         mangling schemes.
8145         * linespec.c (find_methods): Likewise.
8146         * stabsread.c (read_member_functions): Likewise.
8147         * valops.c (search_struct_method): Likewise.
8148         (value_struct_elt_for_reference): Likewise.
8149         * NEWS: Mention this change.
8150
8151 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8154         print_source_lines.
8155         * source.c (print_source_lines_base): Update line number check.
8156         (print_source_lines): New function.
8157         (source_lines_range::source_lines_range): New function.
8158         * source.h (class source_lines_range): New class.
8159         (print_source_lines): New declaration.
8160
8161 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8162
8163         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8164
8165 2019-01-08  Tom Tromey  <tom@tromey.com>
8166             Simon Marchi  <simon.marchi@ericsson.com>
8167
8168         PR gdb/24060
8169         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8170         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8171         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8172         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8173         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8174         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8175
8176 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8177
8178         * source.c (select_source_symtab): Move header comment to
8179         declaration in source.h.
8180         (forget_cached_source_info_for_objfile): Likewise.
8181         (forget_cached_source_info): Likewise.
8182         (identify_source_line): Likewise.
8183         * source.h (identify_source_line): Move declaration from symtab.h
8184         and add comment from source.c
8185         (print_source_lines): Likewise.
8186         (forget_cached_source_info_for_objfile): Likewise.
8187         (forget_cached_source_info): Likewise.
8188         (select_source_symtab): Likewise.
8189         (enum print_source_lines_flag): Move definition from symtab.h.
8190         * symtab.h (identify_source_line): Move declaration to source.h.
8191         (print_source_lines): Likewise.
8192         (forget_cached_source_info_for_objfile): Likewise.
8193         (forget_cached_source_info): Likewise.
8194         (select_source_symtab): Likewise.
8195         (enum print_source_lines_flag): Move definition to source.h.
8196         * tui/tui-hooks.c: Add 'source.h' include.
8197
8198 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8199
8200         * source.c (print_source_lines_base): Handle requests to print
8201         reverse line number sequences, and guard against empty lines
8202         string.
8203
8204 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8205
8206         * source.c (print_source_lines_base): Fix skip of '\r' if next
8207         character is '\n'.
8208
8209 2019-01-06  Tom Tromey  <tom@tromey.com>
8210
8211         * c-exp.y (struct c_parse_state) <macro_original_text,
8212         expansion_obstack>: New member.
8213         (macro_original_text, expansion_obstack): Remove globals.
8214         (scan_macro_expansion, scanning_macro_expansion)
8215         (finished_macro_expansion): Update.
8216         (scan_macro_cleanup): Remove.
8217         (yylex, c_parse): Update.
8218
8219 2019-01-06  Tom Tromey  <tom@tromey.com>
8220
8221         * c-exp.y (struct c_parse_state) <strings>: New member.
8222         (operator_stoken): Update.
8223
8224 2019-01-06  Tom Tromey  <tom@tromey.com>
8225
8226         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8227         (union type_stack_elt) <typelist_val>: Now a pointer to
8228         std::vector.
8229         (type_stack_cleanup): Don't declare.
8230         (push_typelist): Update.
8231         * parse.c (pop_typelist): Return a std::vector.
8232         (push_typelist): Take a std::vector.
8233         (follow_types): Update.  Do not free args.
8234         (type_stack_cleanup): Remove.
8235         * c-exp.y (struct c_parse_state): New.
8236         (cpstate): New global.
8237         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8238         (nonempty_typelist): Update.
8239         (func_mod): Create a new vector.
8240         (c_parse): Create a c_parse_state.
8241         (check_parameter_typelist): Do not delete params.
8242         (function_method): Update.  Do not delete type_list.
8243
8244 2019-01-06  Tom Tromey  <tom@tromey.com>
8245
8246         PR gdb/28155:
8247         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8248         check_typedef.
8249         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8250         (print_return_value): Likewise.
8251
8252 2019-01-05  Tom Tromey  <tom@tromey.com>
8253
8254         * contrib/cleanup_check.py: Remove.
8255         * contrib/gcc-with-excheck: Remove.
8256         * contrib/exsummary.py: Remove.
8257         * contrib/excheck.py: Remove.
8258
8259 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8260
8261         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8262         NULL. Initialize tpprev to NULL instead of assigning it
8263         to NULL on the next statement.
8264         * windows-nat.c (windows_delete_thread): Remove check for
8265         main_thread_id before printing thread exit notifications.
8266         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8267         Remove thread ID check against main_thread_id.
8268         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8269         windows_delete_thread.
8270         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8271
8272 2019-01-04  Tom Tromey  <tom@tromey.com>
8273
8274         * compile/compile.c (_initialize_compile): Use upper case for
8275         metasyntactic variables.
8276         * symmisc.c (_initialize_symmisc): Use upper case for
8277         metasyntactic variables.
8278         * psymtab.c (_initialize_psymtab): Use upper case for
8279         metasyntactic variables.
8280         * demangle.c (demangle_command): Use upper case for metasyntactic
8281         variables.
8282         (_initialize_demangler): Likewise.
8283         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8284         variables.
8285
8286 2019-01-03  Tom Tromey  <tom@tromey.com>
8287
8288         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8289
8290 2019-01-03  Tom Tromey  <tom@tromey.com>
8291
8292         * python/py-symtab.c (salpy_str): Update.
8293         (struct salpy_sal_object) <symtab>: Now a PyObject.
8294         (salpy_dealloc): Update.
8295         (del_objfile_sal): Use gdbpy_ref.
8296
8297 2019-01-03  Tom Tromey  <tom@tromey.com>
8298
8299         * python/py-type.c (convert_field): Use new_reference.  Return
8300         gdbpy_ref.
8301         (make_fielditem): Return gdbpy_ref.
8302         (typy_fields): Update.
8303         (typy_getitem): Update.
8304         (field_name): Return gdbpy_ref.  Use new_reference.
8305         (typy_iterator_iternext): Update.
8306
8307 2019-01-03  Tom Tromey  <tom@tromey.com>
8308
8309         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8310
8311 2019-01-03  Tom Tromey  <tom@tromey.com>
8312
8313         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8314         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8315         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8316         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8317         (pspy_set_type_printers): Likewise.
8318         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8319         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8320         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8321         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8322         (objfpy_set_type_printers): Likewise.
8323
8324 2019-01-03  Tom Tromey  <tom@tromey.com>
8325
8326         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8327         (gdbpy_print_stack): Use gdbpy_err_fetch.
8328         * python/python-internal.h (class gdbpy_err_fetch): New class.
8329         (class gdbpy_enter) <m_error_type, m_error_value,
8330         m_error_traceback>: Remove.
8331         <m_error>: New member.
8332         (gdbpy_exception_to_string): Don't declare.
8333         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8334         * python/py-value.c (convert_value_from_python): Use
8335         gdbpy_err_fetch.
8336         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8337         gdbpy_exception_to_string.
8338         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8339         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8340         gdbpy_err_fetch.
8341
8342 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8343
8344         * linux-nat.c (delete_lwp_cleanup): Delete.
8345         (struct lwp_deleter): New struct.
8346         (lwp_info_up): New typedef.
8347         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8348         lwp_info_up.
8349
8350 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8351
8352         * linux-fork.c (class scoped_switch_fork_info): New class.
8353         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8354
8355 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8356
8357         * valops.c (find_overload_match): Remove use of null_cleanup, and
8358         calls to do_cleanups.
8359
8360 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * compile/compile-cplus-types.c
8363         (compile_cplus_instance::decl_name): Handle changes to
8364         cp_func_name.
8365         * cp-support.c (cp_func_name): Update header comment, update
8366         return type.
8367         * cp-support.h (cp_func_name): Update return type in declaration.
8368         * valops.c (find_overload_match): Move temp_func local to top
8369         level of function and change its type.  Use temp_func to hold and
8370         delete temporary string obtained from cp_func_name.
8371
8372 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8373
8374         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8375         gdb::char_vector, remove cleanup, and update uses of `msg`.
8376
8377 2019-01-03  Jim Wilson  <jimw@sifive.com>
8378
8379         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8380
8381 2019-01-02  Tom Tromey  <tom@tromey.com>
8382
8383         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8384         (tdesc_parse_xml): Remove cleanups.
8385         * target-descriptions.h (make_cleanup_free_target_description):
8386         Don't declare.
8387         (target_desc_deleter): New struct.
8388         (target_desc_up): New typedef.
8389         * target-descriptions.c (target_desc_deleter::operator()): Rename
8390         from free_target_description.
8391         (make_cleanup_free_target_description): Remove.
8392
8393 2019-01-02  Tom Tromey  <tom@tromey.com>
8394
8395         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8396         constructor, destructor.
8397         (linespec_parser): Remove typedef.
8398         (~linespec_parser): Rename from linespec_parser_delete.
8399         (linespec_lex_to_end, linespec_complete_label)
8400         (linespec_complete): Update.
8401         (decode_line_full): Remove cleanups.
8402         (decode_line_1): Update.
8403
8404 2019-01-02  Tom Tromey  <tom@tromey.com>
8405
8406         * python/python-internal.h (inferior_to_inferior_object): Change
8407         return type.
8408         * python/py-exitedevent.c (create_exited_event_object): Update.
8409         * python/py-inferior.c (inferior_to_inferior_object): Return
8410         gdbpy_ref.
8411         (python_new_inferior, python_inferior_deleted)
8412         (thread_to_thread_object, delete_thread_object)
8413         (build_inferior_list, gdbpy_selected_inferior): Update.
8414         * python/py-infthread.c (create_thread_object): Update.  Also fail
8415         if inferior_to_inferior_object fails.
8416
8417 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8418
8419         * inferior.h (class inferior) <displaced_step_state>: New field.
8420         * infrun.h (struct displaced_step_state): Move here from
8421         infrun.c.  Initialize fields, add constructor.
8422         <inf>: Remove field.
8423         <reset>: New method.
8424         * infrun.c (struct displaced_step_inferior_state): Move to
8425         infrun.h.
8426         (displaced_step_inferior_states): Remove.
8427         (get_displaced_stepping_state): Adust.
8428         (displaced_step_in_progress_any_inferior): Adjust.
8429         (displaced_step_in_progress_thread): Adjust.
8430         (displaced_step_in_progress): Adjust.
8431         (add_displaced_stepping_state): Remove.
8432         (get_displaced_step_closure_by_addr): Adjust.
8433         (remove_displaced_stepping_state): Remove.
8434         (infrun_inferior_exit): Call displaced_step_state.reset.
8435         (use_displaced_stepping): Don't check for NULL.
8436         (displaced_step_prepare_throw): Call
8437         get_displaced_stepping_state.
8438         (displaced_step_fixup): Don't check for NULL.
8439         (prepare_for_detach): Don't check for NULL.
8440
8441 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8442
8443         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8444          in case of call that did not complete.
8445
8446 2019-01-02  Andrey Utkin  <autkin@undo.io>
8447
8448         * symfile.c (find_separate_debug_file): Fix search of debug files for
8449         remote debuggee.
8450
8451 2019-01-02  Tom Tromey  <tom@tromey.com>
8452
8453         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8454         indentation.
8455         * python/py-frame.c (frapy_older): Remove cast.
8456         (frapy_newer): Likewise.
8457         * python/py-breakpoint.c (local_setattro): Remove cast.
8458         * python/py-arch.c (archpy_name): Remove local variable.
8459         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8460
8461 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8462
8463         * unittests/basic_string_view/element_access/char/empty.cc:
8464         Fix year range in copyright header.
8465
8466 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8467
8468         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8469         Delete.
8470         <operator==>: Update with for removed field.
8471         <hash>: Likewise.
8472         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8473         <isa_features>: ...this.
8474         <abi_features>: New field.
8475         (riscv_isa_flen): Update comment.
8476         (riscv_abi_xlen): New declaration.
8477         (riscv_abi_flen): New declaration.
8478         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8479         isa_features.
8480         (riscv_abi_xlen): New function.
8481         (riscv_isa_flen): Update to get answer from isa_features.
8482         (riscv_abi_flen): New function.
8483         (riscv_has_fp_abi): Update to get answer from abi_features.
8484         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8485         xlen and flen.
8486         (riscv_call_info) <xlen, flen>: Update comment.
8487         (riscv_call_arg_struct): Remove invalid assertions
8488         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8489         is removed.
8490         (riscv_gdbarch_init): Gather isa features and abi features
8491         separately, ensure both match on the gdbarch when reusing an old
8492         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8493         a target with 64-bit float hardware.
8494
8495 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8496
8497         * source.c (search_command_helper): Stop reverse search
8498         when line 1 has been searched.
8499
8500 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8501
8502         * record-full.c (record_full_base_target::close): Rewrite
8503         record_full_core_buf_list free logic.
8504
8505 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8506
8507         * break-catch-syscall.c (print_one_catch_syscall): xfree
8508         the last text.
8509
8510 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8511
8512         * top.c (print_gdb_version): Update Copyright year in version
8513         message.
8514
8515 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8516
8517         Update copyright year range in all GDB files.
8518
8519 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8520
8521         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8522
8523 For older changes see ChangeLog-2018.
8524 \f
8525 Local Variables:
8526 mode: change-log
8527 left-margin: 8
8528 fill-column: 74
8529 version-control: never
8530 coding: utf-8
8531 End:
8532