gdb/ChangeLog

   1 2020-07-01  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_data_window::show_register_group)
   4         (tui_data_window::check_register_values): Update.
   5         * tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
   6         from item_no.
   7
   8 2020-07-01  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-regs.c (tui_data_window::show_register_group): Remove
  11         useless "if".
  12
  13 2020-07-01  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  16         * tui/tui-regs.h (struct tui_data_item_window) <name>: Remove.
  17
  18 2020-07-01  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-stack.c (SINGLE_KEY): Move from tui-data.h
  21         * tui/tui-winsource.h (enum tui_line_or_address_kind)
  22         (struct tui_line_or_address): Move from tui-data.h.
  23         * tui/tui-win.c (DEFAULT_TAB_LEN): Move from tui-data.h.
  24         * tui/tui-data.h (DEFAULT_TAB_LEN): Move to tui-win.c.
  25         (tui_cmd_window, tui_source_window_base, tui_source_window)
  26         (tui_disasm_window): Don't declare.
  27         (enum tui_line_or_address_kind, struct tui_line_or_address): Move
  28         to tui-winsource.h.
  29         (SINGLE_KEY): Move to tui-stack.c.
  30
  31 2020-07-01  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-regs.h (struct tui_data_item_window) <content>: Now a
  34         std::string.
  35         * tui/tui-regs.c (class tab_expansion_file): New.
  36         (tab_expansion_file::write): New method.
  37         (tui_register_format): Change return type.  Use
  38         tab_expansion_file.
  39         (tui_get_register, tui_data_window::display_registers_from)
  40         (tui_data_item_window::rerender): Update.
  41         * tui/tui-io.h (tui_expand_tabs): Don't declare.
  42         * tui/tui-io.c (tui_expand_tabs): Remove.
  43
  44 2020-07-01  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
  47
  48 2020-07-01  Fangrui Song  <maskray@google.com>
  49
  50         * dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.
  51
  52 2020-07-01  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
  53
  54         * dwarf2/read.c (set_die_type): Removed conditions to restrict
  55         forms for DW_AT_associated and DW_AT_allocated attributes,
  56         which is already checked in function attr_to_dynamic_prop.
  57
  58 2020-06-30  Tom Tromey  <tromey@adacore.com>
  59
  60         * dwarf2/read.c (quirk_rust_enum): Correctly call
  61         alloc_rust_variant for default-less enum.
  62
  63 2020-06-30  Tom Tromey  <tromey@adacore.com>
  64
  65         PR build/26183:
  66         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
  67         gdb::to_string.
  68
  69 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
  70
  71         * gdbarch.sh (displaced_step_copy_insn): Update doc.
  72         * gdbarch.h: Re-generate.
  73
  74 2020-06-28  Tom Tromey  <tom@tromey.com>
  75
  76         * command.h (cmd_types): Remove.
  77         (cmd_type): Don't declare.
  78         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
  79         typedef.
  80         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
  81         * cli/cli-decode.c (cmd_type): Remove.
  82
  83 2020-06-27  Pedro Alves  <palves@redhat.com>
  84
  85         * fork-child.c (prefork_hook): Adjust.
  86         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
  87         Delete.
  88         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
  89         * inferior.c (inferior::set_tty, inferior::tty): New methods.
  90         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
  91         Remove declarations.
  92         (struct inferior) <set_tty, tty>: New methods.
  93         (struct inferior) <terminal>: Rename to ...
  94         (struct inferior) <m_terminal>: ... this and make private.
  95         * main.c (captured_main_1): Adjust.
  96         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
  97         (mi_cmd_inferior_tty_show): Adjust.
  98         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
  99         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
 100
 101 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 102
 103         * configure.ac: Add --enable-libctf: handle --disable-static
 104         properly.
 105         * acinclude.m4: sinclude ../config/enable.m4.
 106         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
 107         (LIBCTF): Substitute in.
 108         (CTF_DEPS): New, likewise.
 109         (CLIBS): libctf needs symbols from libbfd: move earlier.
 110         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
 111         flags.
 112         * ctfread.c: Surround in ENABLE_LIBCTF.
 113         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
 114         * configure: Regenerate.
 115         * config.in: Likewise.
 116
 117 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
 118
 119         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
 120
 121 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
 122
 123         * inferior.h (struct inferior) <terminal>: Change type to
 124         gdb::unique_xmalloc_ptr<char>.
 125         * inferior.c (inferior::~inferior): Don't free inf->terminal.
 126         * infcmd.c (set_inferior_io_terminal): Don't free terminal
 127         field, adjust to unique pointer.
 128         (get_inferior_io_terminal): Adjust to unique pointer.
 129
 130 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * riscv-tdep.c (riscv_print_registers_info): Loop over all
 133         registers, not just the known core set of registers.
 134
 135 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 136
 137         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
 138         fflags, frm, and fcsr registers.
 139         (riscv_register_reggroup_p): Remove unknown CSRs from save and
 140         restore groups.
 141         (riscv_tdesc_unknown_reg): New function.
 142         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
 143         tdesc_use_registers.
 144         * riscv-tdep.h (struct gdbarch_tdep): Add
 145         unknown_csrs_first_regnum, unknown_csrs_count,
 146         duplicate_fflags_regnum, duplicate_frm_regnum, and
 147         duplicate_fcsr_regnum fields.
 148
 149 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         * target-descriptions.c (tdesc_use_registers): Add new parameter a
 152         callback, use the callback (when not null) to help number unknown
 153         registers.
 154         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
 155         (tdesc_use_registers): Add extra parameter to declaration.
 156
 157 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
 160         in the file.
 161         (class riscv_pending_register_alias): Likewise.
 162         (riscv_register_feature::register_info): Change 'required_p' field
 163         to 'required', and change its type.  Add 'check' member function.
 164         (riscv_register_feature::register_info::check): Define new member
 165         function.
 166         (riscv_xreg_feature): Change initialisation of 'required' field.
 167         (riscv_freg_feature): Likewise.
 168         (riscv_virtual_feature): Likewise.
 169         (riscv_csr_feature): Likewise.
 170         (riscv_check_tdesc_feature): Take extra parameter, the csr
 171         tdesc_feature, rewrite the function to use the new
 172         riscv_register_feature::register_info::check function.
 173         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
 174
 175 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 176
 177         * features/Makefile: Remove all references to the deleted files
 178         below.
 179         * features/riscv/32bit-csr.c: Deleted.
 180         * features/riscv/32bit-csr.xml: Deleted.
 181         * features/riscv/64bit-csr.c: Deleted.
 182         * features/riscv/64bit-csr.xml: Deleted.
 183         * features/riscv/rebuild-csr-xml.sh: Deleted.
 184
 185 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 186
 187         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
 188         whitespace error for declaration of names member variable.
 189         (struct riscv_register_feature): Add new prefer_first_name member
 190         variable, and fix whitespace error in declaration of registers.
 191         (riscv_xreg_feature): Initialize prefer_first_name field.
 192         (riscv_freg_feature): Likewise.
 193         (riscv_virtual_feature): Likewise.
 194         (riscv_csr_feature): Likewise.
 195         (riscv_register_name): Expand on comments.  Remove register name
 196         modifications for CSR and virtual registers.
 197
 198 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 199
 200         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
 201         errors.
 202
 203 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 204
 205         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
 206         riscv-opc.h.
 207         (class riscv_pending_register_alias): New class.
 208         (riscv_check_tdesc_feature): Take vector of pending aliases and
 209         populate it as appropriate.
 210         (riscv_setup_register_aliases): Delete.
 211         (riscv_gdbarch_init): Create vector of pending aliases and pass it
 212         to riscv_check_tdesc_feature in all cases.  Use the vector to
 213         create the register aliases.
 214
 215 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 216
 217         * sol2-tdep.c (sol2_static_transform_name): Remove.
 218         (sol2_init_abi): Don't register it.
 219         * gdbarch.sh (static_transform_name): Remove.
 220         * gdbarch.c, gdbarch.h: Regenerate.
 221
 222         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
 223         gdbarch_static_transform_name.
 224         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
 225         * stabsread.c (define_symbol) <'X'>: Remove.
 226         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
 227         handling.
 228         <'V'>: Likewise.
 229         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
 230         <'S'>: Remove call to gdbarch_static_transform_name.
 231
 232 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 233
 234         * procfs.c (procfs_pre_trace): New function.
 235         (procfs_target::create_inferior): Pass it to fork_inferior.
 236
 237 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 238
 239         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
 240         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
 241         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
 242         sol2-tdep.o, sparc-sol2-tdep.o.
 243         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
 244         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
 245         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
 246         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
 247
 248 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 249
 250         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
 251         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
 252         Call sol2_init_abi.
 253         Remove calls to set_gdbarch_skip_solib_resolver,
 254         set_gdbarch_core_pid_to_str.
 255         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
 256         (i386_sol2_static_transform_name): Remove.
 257         (i386_sol2_init_abi): Call sol2_init_abi.
 258         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 259         set_gdbarch_static_transform_name,
 260         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 261         Use sol2_sigtramp_p.
 262         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
 263         (sol2_sigtramp_p): New function.
 264         (sol2_static_transform_name): New function.
 265         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
 266         (sol2_init_abi): New function.
 267         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
 268         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
 269         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
 270         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
 271         (sparc_sol2_static_transform_name): Remove.
 272         (sparc32_sol2_init_abi): Call sol2_init_abi.
 273         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 274         set_gdbarch_static_transform_name,
 275         set_gdbarch_skip_solib_resolver,
 276         set_gdbarch_core_pid_to_str.
 277         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
 278         (sparc_sol2_static_transform_name): Remove
 279         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
 280         call sol2_sigtramp_p.
 281         (sparc64_sol2_init_abi): Call sol2_init_abi.
 282         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 283         set_gdbarch_static_transform_name,
 284         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 285
 286 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 287
 288         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
 289         * exec.c (validate_exec_file): If from_tty, set both
 290         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
 291         * symfile.c (symbol_file_add_with_addrs): if always_confirm
 292         and from_tty, unconditionally ask a confirmation.
 293
 294 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 295
 296         * target-descriptions.c (tdesc_architecture_name): Protect against
 297         NULL pointer dereference.
 298         (maint_print_xml_tdesc_cmd): New function.
 299         (_initialize_target_descriptions): Register new 'maint print
 300         xml-tdesc' command and give it the filename completer.
 301         * NEWS: Mention new 'maint print xml-tdesc' command.
 302
 303 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 304
 305         * target-descriptions.c (class tdesc_compatible_info): New class.
 306         (struct target_desc): Change type of compatible vector.
 307         (tdesc_compatible_p): Update for change in type of
 308         target_desc::compatible.
 309         (tdesc_compatible_info_list): New function.
 310         (tdesc_compatible_info_arch_name): New function.
 311         (tdesc_add_compatible): Update for change in type of
 312         target_desc::compatible.
 313         (print_c_tdesc::visit_pre): Likewise.
 314
 315 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 316
 317         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
 318         whitespace to underscore.
 319         (maint_print_c_tdesc_cmd): Use fake filename for target
 320         descriptions that came from the target.
 321         (_initialize_target_descriptions): Add filename command completion
 322         for 'maint print c-tdesc'.
 323
 324 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 325
 326         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
 327         lines.
 328
 329 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 330
 331         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
 332         lines.
 333         (dwarf2_find_location_expression): Likewise.
 334         (call_site_parameter_matches): Likewise.
 335         (dwarf2_compile_expr_to_ax): Likewise.
 336         (disassemble_dwarf_expression): Likewise.
 337         (loclist_describe_location): Likewise.
 338
 339 2020-06-23  Pedro Alves  <palves@redhat.com>
 340
 341         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
 342         progspace-and-thread.h.  Include scoped-mock-context.h instead.
 343         (register_to_value_test): Use scoped_mock_context.
 344         * regcache.c: Include "scoped-mock-context.h".
 345         (cooked_read_test): Don't error out if a target is already pushed.
 346         Use scoped_mock_context.  Adjust.
 347         * scoped-mock-context.h: New file.
 348
 349 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
 352         initializer.
 353         (ada_language::is_string_type_p): New member function.
 354         * c-lang.c (c_language_data): Delete la_is_string_type_p
 355         initializer.
 356         (cplus_language_data): Likewise.
 357         (asm_language_data): Likewise.
 358         (minimal_language_data): Likewise.
 359         * d-lang.c (d_language_data): Likewise.
 360         * f-lang.c (f_is_string_type_p): Delete function, implementation
 361         moved to f_language::is_string_type_p.
 362         (f_language_data): Delete la_is_string_type_p initializer.
 363         (f_language::is_string_type_p): New member function,
 364         implementation from f_is_string_type_p.
 365         * go-lang.c (go_is_string_type_p): Delete function, implementation
 366         moved to go_language::is_string_type_p.
 367         (go_language_data): Delete la_is_string_type_p initializer.
 368         (go_language::is_string_type_p): New member function,
 369         implementation from go_is_string_type_p.
 370         * language.c (language_defn::is_string_type_p): Define new member
 371         function.
 372         (default_is_string_type_p): Make static, add comment copied from
 373         header file.
 374         (unknown_language_data): Delete la_is_string_type_p initializer.
 375         (unknown_language::is_string_type_p): New member function.
 376         (auto_language_data): Delete la_is_string_type_p initializer.
 377         (auto_language::is_string_type_p): New member function.
 378         * language.h (language_data): Delete la_is_string_type_p field.
 379         (language_defn::is_string_type_p): Declare new function.
 380         (default_is_string_type_p): Delete desclaration, move comment to
 381         definition.
 382         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
 383         moved to m2_language::is_string_type_p.
 384         (m2_language_data): Delete la_is_string_type_p initializer.
 385         (m2_language::is_string_type_p): New member function,
 386         implementation from m2_is_string_type_p.
 387         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
 388         initializer.
 389         * opencl-lang.c (opencl_language_data): Likewise.
 390         * p-lang.c (pascal_is_string_type_p): Delete function,
 391         implementation moved to pascal_language::is_string_type_p.
 392         (pascal_language_data): Delete la_is_string_type_p initializer.
 393         (pascal_language::is_string_type_p): New member function,
 394         implementation from pascal_is_string_type_p.
 395         * rust-lang.c (rust_is_string_type_p): Delete function,
 396         implementation moved to rust_language::is_string_type_p.
 397         (rust_language_data): Delete la_is_string_type_p initializer.
 398         (rust_language::is_string_type_p): New member function,
 399         implementation from rust_is_string_type_p.
 400         * valprint.c (val_print_scalar_or_string_type_p): Update call to
 401         is_string_type_p.
 402
 403 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * ada-lang.c (ada_language_data): Delete la_print_typedef
 406         initializer.
 407         (ada_language::print_typedef): New member function.
 408         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
 409         (cplus_language_data): Likewise.
 410         (asm_language_data): Likewise.
 411         (minimal_language_data): Likewise.
 412         * d-lang.c (d_language_data): Likewise.
 413         * f-lang.c (f_language_data): Likewise.
 414         (f_language::print_typedef): New member function.
 415         * go-lang.c (go_language_data): Delete la_print_typedef
 416         initializer.
 417         * language.c (language_defn::print_typedef): Define member
 418         function.
 419         (unknown_language_data): Delete la_print_typedef initializer.
 420         (unknown_language::print_typedef): New member function.
 421         (auto_language_data): Delete la_print_typedef initializer.
 422         (auto_language::print_typedef): New member function.
 423         * language.h (language_data): Delete la_print_typedef field.
 424         (language_defn::print_typedef): Declare new member function.
 425         (LA_PRINT_TYPEDEF): Update call to print_typedef.
 426         (default_print_typedef): Delete declaration.
 427         * m2-lang.c (m2_language_data): Delete la_print_typedef
 428         initializer.
 429         (m2_language::print_typedef): New member function.
 430         * objc-lang.c (objc_language_data): Delete la_print_typedef
 431         initializer.
 432         * opencl-lang.c (opencl_language_data): Likewise.
 433         * p-lang.c (pascal_language_data): Likewise.
 434         (pascal_language::print_typedef): New member function.
 435         * rust-lang.c (rust_print_typedef): Delete function,
 436         implementation moved to rust_language::print_typedef.
 437         (rust_language): Delete la_print_typedef initializer.
 438         (rust_language::print_typedef): New member function,
 439         implementation from rust_print_typedef.
 440         * typeprint.c (default_print_typedef): Delete.
 441
 442 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
 445         (ada_language::printstr): New member function.
 446         * c-lang.c (c_language_data): Delete la_printstr initializer.
 447         (cplus_language_data): Likewise.
 448         (asm_language_data): Likewise.
 449         (minimal_language_data): Likewise.
 450         * d-lang.c (d_language_data): Likewise.
 451         * f-lang.c (f_printstr): Rename to f_language::printstr.
 452         (f_language_data): Delete la_printstr initializer.
 453         (f_language::printstr): New member function, implementation from
 454         f_printstr.
 455         * go-lang.c (go_language_data): Delete la_printstr initializer.
 456         * language.c (language_defn::printstr): Define new member
 457         function.
 458         (unk_lang_printstr): Delete.
 459         (unknown_language_data): Delete la_printstr initializer.
 460         (unknown_language::printstr): New member function.
 461         (auto_language_data): Delete la_printstr initializer.
 462         (auto_language::printstr): New member function.
 463         * language.h (language_data): Delete la_printstr field.
 464         (language_defn::printstr): Declare new member function.
 465         (LA_PRINT_STRING): Update call to printstr.
 466         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
 467         (m2_language_data): Delete la_printstr initializer.
 468         (m2_language::printstr): New member function, implementation from
 469         m2_printstr.
 470         * objc-lang.c (objc_language_data): Delete la_printstr
 471         initializer.
 472         * opencl-lang.c (opencl_language_data): Likewise.
 473         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
 474         (pascal_language_data): Delete la_printstr initializer.
 475         (pascal_language::printstr): New member function, implementation
 476         from pascal_printstr.
 477         * p-lang.h (pascal_printstr): Delete declaration.
 478         * rust-lang.c (rust_printstr): Update header comment.
 479         (rust_language_data): Delete la_printstr initializer.
 480         (rust_language::printstr): New member function.
 481
 482 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 483
 484         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
 485         (ada_language::printchar): New member function.
 486         * c-lang.c (c_language_data): Delete la_printchar initializer.
 487         (cplus_language_data): Likewise.
 488         (asm_language_data): Likewise.
 489         (minimal_language_data): Likewise.
 490         * d-lang.c (d_language_data): Likewise.
 491         * f-lang.c (f_printchar): Rename to f_language::printchar.
 492         (f_language_data): Delete la_printchar initializer.
 493         (f_language::printchar): New member function, implementation from
 494         f_printchar.
 495         * go-lang.c (go_language_data): Delete la_printchar initializer.
 496         * language.c (unk_lang_printchar): Delete.
 497         (language_defn::printchar): Define new member function.
 498         (unknown_language_data): Delete la_printchar initializer.
 499         (unknown_language::printchar): New member function.
 500         (auto_language_data): Delete la_printchar initializer.
 501         (auto_language::printchar): New member function.
 502         * language.h (language_data): Delete la_printchar field.
 503         (language_defn::printchar): Declare new member function.
 504         (LA_PRINT_CHAR): Update call to printchar.
 505         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
 506         (m2_language::printchar): New member function.
 507         * objc-lang.c (objc_language_data): Delete la_printchar
 508         initializer.
 509         * opencl-lang.c (opencl_language_data): Likewise.
 510         * p-lang.c (pascal_language_data): Delete la_printchar
 511         initializer.
 512         (pascal_language::printchar): New member function.
 513         * rust-lang.c (rust_printchar): Rename to
 514         rust_language::printchar.
 515         (rust_language_data): Delete la_printchar initializer.
 516         (rust_language::printchar): New member function, implementation
 517         from rust_printchar.
 518
 519 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
 522         (ada_language_data): Delete la_emitchar initializer.
 523         (ada_language::emitchar): New member function, implementation from
 524         emit_char.
 525         * c-lang.c (c_language_data): Delete la_emitchar initializer.
 526         (cplus_language_data): Likewise.
 527         (asm_language_data): Likewise.
 528         (minimal_language_data): Likewise.
 529         * d-lang.c (d_language_data): Likewise.
 530         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
 531         (f_language_data): Delete la_emitchar initializer.
 532         (f_language::emitchar): New member function, implementation from
 533         f_emit_char.
 534         * go-lang.c (go_language_data): Delete la_emitchar initializer.
 535         * language.c (unk_lang_emit_char): Delete.
 536         (language_defn::emitchar): New member function definition.
 537         (unknown_language_data): Delete la_emitchar initializer.
 538         (unknown_language::emitchar): New member function.
 539         (auto_language_data): Delete la_emitchar initializer.
 540         (auto_language::emitchar): New member function.
 541         * language.h (language_data): Delete la_emitchar field.
 542         (language_defn::emitchar): New member field declaration.
 543         (LA_EMIT_CHAR): Update call to emitchar.
 544         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
 545         (m2_language_data): Delete la_emitchar initializer.
 546         (m2_language::emitchar): New member function, implementation from
 547         m2_emit_char.
 548         * objc-lang.c (objc_language_data): Delete la_emitchar
 549         initializer.
 550         * opencl-lang.c (opencl_language_data): Likewise.
 551         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
 552         (pascal_language_data): Delete la_emitchar initializer.
 553         (pascal_language::emitchar): New member function, implementation
 554         from pascal_emit_char.
 555         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
 556         (rust_language_data): Delete la_emitchar initializer.
 557         (rust_language::emitchar): New member function, implementation
 558         from rust_emitchar.
 559
 560 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * ada-lang.c (resolve): Rename to ada_language::post_parser.
 563         (ada_language_data): Delete la_post_parser initializer.
 564         (ada_language::post_parser): New member function.
 565         * c-lang.c (c_language_data): Delete la_post_parser initializer.
 566         (cplus_language_data): Likewise.
 567         (asm_language_data): Likewise.
 568         (minimal_language_data): Likewise.
 569         * d-lang.c (d_language_data): Likewise.
 570         * f-lang.c (f_language_data): Likewise.
 571         * go-lang.c (go_language_data): Likewise.
 572         * language.c (unknown_language_data): Likewise.
 573         (auto_language_data): Likewise.
 574         * language.h (language_data): Delete la_post_parser field.
 575         (language_defn::post_parser): New member function.
 576         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
 577         * objc-lang.c (objc_language_data): Likewise.
 578         * opencl-lang.c (opencl_language_data): Likewise.
 579         * p-lang.c (pascal_language_data): Likewise.
 580         * parse.c (parse_exp_in_context): Update call to post_parser.
 581         (null_post_parser): Delete definition.
 582         * parser-defs.h (null_post_parser): Delete declaration.
 583         * rust-lang.c (rust_language_data): Delete la_post_parser
 584         initializer.
 585
 586 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * ada-lang.c (parse): Rename to ada_language::parser.
 589         (ada_language_data): Delete la_parser initializer.
 590         (ada_language::parser): New member function, implementation from
 591         parse.
 592         * c-lang.c (c_language_data): Delete la_parser initializer.
 593         (cplus_language_data): Likewise.
 594         (asm_language_data): Likewise.
 595         (minimal_language_data): Likewise.
 596         * d-lang.c (d_language_data): Likewise.
 597         (d_language::parser): New member function.
 598         * f-lang.c (f_language_data): Delete la_parser initializer.
 599         (f_language::parser): New member function.
 600         * go-lang.c (go_language_data): Delete la_parser initializer.
 601         (go_language::parser): New member function.
 602         * language.c (unk_lang_parser): Delete.
 603         (language_defn::parser): Define new member function.
 604         (unknown_language_data): Delete la_parser initializer.
 605         (unknown_language::parser): New member function.
 606         (auto_language_data): Delete la_parser initializer.
 607         (auto_language::parser): New member function.
 608         * language.h (language_data): Delete la_parser field.
 609         (language_defn::parser): Declare new member function.
 610         * m2-lang.c (m2_language_data): Delete la_parser initializer.
 611         (m2_language::parser): New member function.
 612         * objc-lang.c (objc_language_data): Delete la_parser initializer.
 613         * opencl-lang.c (opencl_language_data): Likewise.
 614         * p-lang.c (pascal_language_data): Likewise.
 615         (pascal_language::parser): New member function.
 616         * parse.c (parse_exp_in_context): Update call to parser.
 617         * rust-lang.c (rust_language_data): Delete la_parser initializer.
 618         (rust_language::parser): New member function.
 619
 620 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 621
 622         * top.c (print_gdb_configuration): Print --with-python-libdir
 623         configuration value.
 624
 625 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 626
 627         * NEWS: Mention change to the alias command.
 628
 629 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 630
 631         * cli/cli-cmds.c (lookup_cmd_for_default_args)
 632         (alias_command_completer)
 633         (make_alias_options_def_group): New functions.
 634         (alias_opts, alias_option_defs): New struct and array.
 635         (alias_usage_error): Update usage.
 636         (alias_command): Handles optional DEFAULT-ARGS... arguments.
 637         Use option framework.
 638         (_initialize_cli_cmds): Update alias command help.
 639         Update aliases command help.
 640         (show_user):
 641         Add NULL for new default_args lookup_cmd argument.
 642         (valid_command_p): Rename to validate_aliased_command.
 643         Add NULL for new default_args lookup_cmd argument.  Verify that the
 644         aliased_command has no default args.
 645         * cli/cli-decode.c (help_cmd): Show aliases definitions.
 646         (lookup_cmd_1, lookup_cmd): New argument default_args.
 647         (add_alias_cmd):
 648         Add NULL for new default_args lookup_cmd argument.
 649         (print_help_for_command): Show default args under the layout
 650          alias some_alias = some_aliased_cmd some_alias_default_arg.
 651         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
 652         xfree default_args in destructor.
 653         * cli/cli-script.c (process_next_line, do_define_command):
 654         Add NULL for new default_args lookup_cmd argument.
 655         * command.h: Declare new default_args argument in lookup_cmd
 656         and lookup_cmd_1.
 657         * completer.c (complete_line_internal_1):
 658         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 659         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 660         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
 661         Likewise.
 662         * infcmd.c (_initialize_infcmd): Likewise.
 663         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
 664         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 665         * python/py-param.c (add_setshow_generic): Likewise.
 666         * remote.c (_initialize_remote): Likewise.
 667         * top.c (execute_command): Prepend default_args if command has some.
 668         (set_verbose):
 669         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 670         * tracepoint.c (validate_actionline, encode_actions_1):
 671         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 672
 673 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 674
 675         * jit.c (jit_read_descriptor): Use bool as the return type.
 676         (jit_breakpoint_re_set_internal): Use bool as the return type.
 677         Invert the return value logic; return true if the jit breakpoint
 678         has been successfully initialized.
 679         (jit_inferior_init): Update the call to
 680         jit_breakpoint_re_set_internal.
 681
 682 2020-06-22  Pedro Alves  <palves@redhat.com>
 683
 684         PR gdb/25939
 685         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
 686         Use the current inferior instead.  Don't return
 687         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
 688         wait again.
 689         * sol-thread.c (sol_thread_target::wait): Don't reference
 690         inferior_ptid.
 691         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
 692         (sol_update_thread_list_callback): Use the current inferior's pid
 693         instead of inferior_ptid.
 694
 695 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 696
 697         * procfs.c: Cleanup many comments.
 698
 699         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
 700         (AFTER_WATCHFLAG): Replace by value.
 701
 702         (MAIN_PROC_NAME_FORMAT): Inline ...
 703         (create_procinfo): ... here.
 704
 705         (procfs_debug_inferior): Remove SYS_exec handling.
 706         (syscall_is_exec): Likewise.
 707         (procfs_set_exec_trap): Likewise.
 708
 709         (syscall_is_lwp_exit): Inline in callers.
 710         (syscall_is_exit): Likewise.
 711         (syscall_is_exec): Likewise.
 712         (syscall_is_lwp_create): Likewise.
 713
 714         (invalidate_cache): Remove #if 0 code.
 715
 716         (make_signal_thread_runnable):  Remove.
 717         (procfs_target::resume): Remove #if 0 code.
 718
 719 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 720
 721         PR gdb/25939
 722         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
 723         call ...
 724         (procfs_target::create_inferior): ... here.
 725
 726 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 727
 728         * exec.c (validate_exec_file): Ensure the build-id is up to
 729         date by calling reopen_exec_file (that checks file timestamp
 730         to decide to re-read the file).
 731
 732 2020-06-18  Pedro Alves  <palves@redhat.com>
 733
 734         PR gdb/25412
 735         * gdbthread.h (delete_thread, delete_thread_silent)
 736         (find_thread_ptid): Update comments.
 737         * thread.c (current_thread_): New global.
 738         (is_current_thread): Move higher, and reimplement.
 739         (inferior_thread): Reimplement.
 740         (set_thread_exited): Use bool.  Add assertions.
 741         (add_thread_silent): Simplify thread-reuse handling by always
 742         calling delete_thread.
 743         (delete_thread): Remove intro comment.
 744         (find_thread_ptid): Skip exited threads.
 745         (switch_to_thread_no_regs): Write to current_thread_.
 746         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
 747         INFERIOR_PTID.  Clear current_thread_.
 748
 749 2020-06-18  Pedro Alves  <palves@redhat.com>
 750
 751         * aix-thread.c (pd_update): Use switch_to_thread.
 752
 753 2020-06-18  Pedro Alves  <palves@redhat.com>
 754
 755         * ravenscar-thread.c (ravenscar_thread_target): Update.
 756         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
 757         (ravenscar_thread_target::add_active_thread): ... this.  Don't
 758         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
 759         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
 760
 761 2020-06-18  Pedro Alves  <palves@redhat.com>
 762
 763         * nat/windows-nat.c (current_windows_thread): Remove.
 764         * nat/windows-nat.h (current_windows_thread): Remove.
 765         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
 766         Adjust.
 767         (display_selectors): Adjust to fetch the current
 768         windows_thread_info based on inferior_ptid.
 769         (fake_create_process): No longer write to current_windows_thread.
 770         (windows_nat_target::get_windows_debug_event):
 771         Don't set inferior_ptid or current_windows_thread.
 772         (windows_nat_target::wait): Adjust to not rely on
 773         current_windows_thread.
 774         (do_initial_windows_stuff): Now a method of windows_nat_target.
 775         Switch to the last_ptid thread.
 776         (windows_nat_target::attach): Adjust.
 777         (windows_nat_target::detach): Use switch_to_no_thread instead of
 778         writing to inferior_ptid directly.
 779         (windows_nat_target::create_inferior): Adjust.
 780
 781 2020-06-18  Pedro Alves  <palves@redhat.com>
 782
 783         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
 784
 785 2020-06-18  Pedro Alves  <palves@redhat.com>
 786
 787         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
 788         after creating it, instead of writing to inferior_ptid.  Don't
 789         write to inferior_ptid.
 790
 791 2020-06-18  Pedro Alves  <palves@redhat.com>
 792
 793         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
 794
 795 2020-06-18  Pedro Alves  <palves@redhat.com>
 796
 797         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
 798         it, instead of writing to inferior_ptid.
 799
 800 2020-06-18  Pedro Alves  <palves@redhat.com>
 801
 802         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
 803         to inferior_ptid.
 804
 805 2020-06-18  Pedro Alves  <palves@redhat.com>
 806
 807         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
 808         instead of writing to inferior_ptid directly.
 809
 810 2020-06-18  Pedro Alves  <palves@redhat.com>
 811
 812         * corelow.c (core_target::close): Use switch_to_no_thread instead
 813         of writing to inferior_ptid directly.
 814         (add_to_thread_list, core_target_open): Use switch_to_thread
 815         instead of writing to inferior_ptid directly.
 816
 817 2020-06-18  Pedro Alves  <palves@redhat.com>
 818
 819         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
 820         inferior_ptid.
 821         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
 822         inferior_ptid.
 823         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
 824         inferior_ptid directly.
 825         (darwin_nat_target::init_thread_list): Switch to thread, instead
 826         of writing to inferior_ptid.
 827         (darwin_nat_target::attach): Don't write to inferior_ptid.
 828         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
 829
 830 2020-06-18  Pedro Alves  <palves@redhat.com>
 831
 832         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
 833         thread.
 834         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
 835         Instead use switch_to_thread.
 836         (gnu_nat_target::detach): Use switch_to_no_thread
 837         instead of writing to inferior_ptid directly.  Used passed-in
 838         inferior instead of looking up the inferior by pid.
 839
 840 2020-06-18  Pedro Alves  <palves@redhat.com>
 841
 842         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
 843         inferior_ptid.
 844
 845 2020-06-18  Pedro Alves  <palves@redhat.com>
 846
 847         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
 848         inferior_ptid.
 849         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
 850         thread.
 851         (nto_procfs_target::detach): Avoid referencing
 852         inferior_ptid.  Use switch_to_no_thread instead of writing to
 853         inferior_ptid directly.
 854         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
 855         instead of writing to inferior_ptid directly.
 856         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
 857         to thread.
 858
 859 2020-06-18  Pedro Alves  <palves@redhat.com>
 860
 861         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
 862         after creating it, instead of writing to inferior_ptid.
 863         (gdbsim_target_open): Use switch_to_no_thread instead of writing
 864         to inferior_ptid directly.
 865         (gdbsim_target::wait): Don't write to inferior_ptid.
 866
 867 2020-06-18  Pedro Alves  <palves@redhat.com>
 868
 869         * remote.c (remote_target::remote_notice_new_inferior): Use
 870         switch_to_thread instead of writing to inferior_ptid directly.
 871         (remote_target::add_current_inferior_and_thread): Use
 872         switch_to_no_thread instead of writing to inferior_ptid directly.
 873         (extended_remote_target::attach): Use switch_to_inferior_no_thread
 874         and switch_to_thread instead of using set_current_inferior or
 875         writing to inferior_ptid directly.
 876
 877 2020-06-18  Pedro Alves  <palves@redhat.com>
 878
 879         * tracectf.c (ctf_target_open): Switch to added thread instead of
 880         writing to inferior_ptid directly.
 881         (ctf_target::close): Use switch_to_no_thread instead of writing to
 882         inferior_ptid directly.
 883
 884 2020-06-18  Pedro Alves  <palves@redhat.com>
 885
 886         * tracefile-tfile.c (tfile_target_open): Don't write to
 887         inferior_ptid directly, instead switch to added thread.
 888         (tfile_target::close): Use switch_to_no_thread instead of writing
 889         to inferior_ptid directly.
 890
 891 2020-06-18  Pedro Alves  <palves@redhat.com>
 892
 893         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
 894         (procfs_target::detach): Use switch_to_no_thread
 895         instead of writing to inferior_ptid directly.
 896         (do_attach): Change return type to void.  Switch to the added
 897         thread.
 898         (procfs_target::create_inferior): Switch to the added thread.
 899         (procfs_do_thread_registers): Don't write to inferior_ptid.
 900
 901 2020-06-18  Pedro Alves  <palves@redhat.com>
 902
 903         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
 904         of writing to inferior_ptid.
 905         (scoped_restore_exited_inferior): Delete.
 906         (handle_vfork_child_exec_or_exit): Simplify using
 907         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
 908         instead of writing to inferior_ptid.
 909         (THREAD_STOPPED_BY): Delete.
 910         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
 911         (thread_stopped_by_hw_breakpoint): Delete.
 912         (save_waitstatus): Use
 913         scoped_restore_current_thread+switch_to_thread, and call
 914         target_stopped_by_watchpoint instead of
 915         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
 916         instead of thread_stopped_by_sw_breakpoint, and
 917         target_stopped_by_hw_breakpoint instead of
 918         thread_stopped_by_hw_breakpoint.
 919         (handle_inferior_event)
 920         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
 921         inferior_ptid directly, nor
 922         set_current_inferior/set_current_program_space.  Use
 923         switch_to_thread / switch_to_inferior_no_thread instead.
 924
 925 2020-06-18  Pedro Alves  <palves@redhat.com>
 926
 927         * target.c (generic_mourn_inferior): Use switch_to_no_thread
 928         instead of writing to inferior_ptid.
 929
 930 2020-06-18  Pedro Alves  <palves@redhat.com>
 931
 932         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
 933         added thread.
 934         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
 935         to the added thread.
 936         (inf_ptrace_target::detach_success): Use switch_to_no_thread
 937         instead of writing to inferior_ptid.
 938
 939 2020-06-18  Pedro Alves  <palves@redhat.com>
 940
 941         * gdbarch-selftests.c: Include "progspace-and-thread.h".
 942         (register_to_value_test): Mock a program_space too.  Heap-allocate
 943         the address space.  Don't write to inferior_ptid.  Use
 944         switch_to_thread instead.
 945
 946 2020-06-18  Pedro Alves  <palves@redhat.com>
 947
 948         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
 949         Delete.
 950         (find_signalled_thread()): New, factored out from
 951         linux_make_corefile_notes and adjusted to handle exited threads.
 952         (linux_make_corefile_notes): Adjust to use the new
 953         find_signalled_thread.
 954
 955 2020-06-18  Pedro Alves  <palves@redhat.com>
 956
 957         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
 958         of saving/restoring inferior_ptid.
 959
 960 2020-06-17  Tom Tromey  <tom@tromey.com>
 961
 962         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
 963         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
 964         declare.
 965         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
 966
 967 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
 968
 969         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
 970         of partial symtabs.
 971
 972 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 973
 974         * regformats/reg-arm.dat: Remove.
 975         * regformats/reg-bfin.dat: Remove.
 976         * regformats/reg-cris.dat: Remove.
 977         * regformats/reg-crisv32.dat: Remove.
 978         * regformats/reg-m32r.dat: Remove.
 979         * regformats/reg-tilegx.dat: Remove.
 980         * regformats/reg-tilegx32.dat: Remove.
 981
 982 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 983
 984         * features/Makefile (WHICH): Remove arm files.
 985         * regformats/arm/arm-with-iwmmxt.dat: Remove.
 986         * regformats/arm/arm-with-neon.dat: Remove.
 987         * regformats/arm/arm-with-vfpv2.dat: Remove.
 988         * regformats/arm/arm-with-vfpv3.dat: Remove.
 989
 990 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 991
 992         * features/Makefile (XMLTOC): Remove rx.xml.
 993
 994 2020-06-17  Pedro Alves  <palves@redhat.com>
 995
 996         * gdbthread.h (thread_control_state) <trap_expected> Update
 997         comments.
 998
 999 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
1002         ada_language::lookup_symbol_nonlocal.
1003         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
1004         (ada_language::lookup_symbol_nonlocal): New member function,
1005         implementation from ada_lookup_symbol_nonlocal.
1006         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
1007         initializer.
1008         (cplus_language_data): Delete la_lookup_symbol_nonlocal
1009         initializer.
1010         (cplus_language::lookup_symbol_nonlocal): New member function.
1011         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
1012         (minimal_language_data) Likewise.
1013         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
1014         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
1015         initializer.
1016         (d_language::lookup_symbol_nonlocal): New member function.
1017         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
1018         initializer.
1019         (f_language::lookup_symbol_nonlocal): New member function.
1020         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
1021         initializer.
1022         * language.c (unknown_language_data): Likewise.
1023         (auto_language_data): Likewise.
1024         * language.h (language_data): Delete la_lookup_symbol_nonlocal
1025         field.
1026         (language_defn::lookup_symbol_nonlocal): New member function.
1027         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
1028         initializer.
1029         * objc-lang.c (objc_language_data): Likewise.
1030         * opencl-lang.c (opencl_language_data): Likewise.
1031         * p-lang.c (pascal_language_data): Likewise.
1032         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
1033         rust_language::lookup_symbol_nonlocal.
1034         (rust_language_data): Delete la_lookup_symbol_nonlocal
1035         initializer.
1036         (rust_language::lookup_symbol_nonlocal): New member function,
1037         implementation from rust_lookup_symbol_nonlocal.
1038         * symtab.c (lookup_symbol_aux): Update call to
1039         lookup_symbol_nonlocal.
1040         (basic_lookup_symbol_nonlocal): Rename to...
1041         (language_defn::lookup_symbol_nonlocal): ...this, and update
1042         header comment.  Remove language_defn parameter, and replace with
1043         uses of `this'.
1044         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
1045
1046 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * ada-lang.c (ada_language_data): Delete la_value_print_inner
1049         initializer.
1050         (ada_language::value_print_inner): New member function.
1051         * c-lang.c (c_language_data): Delete la_value_print_inner
1052         initializer.
1053         (cplus_language_data): Likewise.
1054         (asm_language_data): Likewise.
1055         (minimal_language_data): Likewise.
1056         * d-lang.c (d_language_data): Likewise.
1057         (d_language::value_print_inner): New member function.
1058         * f-lang.c (f_language_data): Delete la_value_print_inner
1059         initializer.
1060         (f_language::value_print_inner): New member function.
1061         * f-lang.h (f_value_print_innner): Rename to...
1062         (f_value_print_inner): ...this (note spelling of 'inner').
1063         * f-valprint.c (f_value_print_innner): Rename to...
1064         (f_value_print_inner): ...this (note spelling of 'inner').
1065         * go-lang.c (go_language_data): Delete la_value_print_inner
1066         initializer.
1067         (go_language::value_print_inner): New member function.
1068         * language.c (language_defn::value_print_inner): Define new member
1069         function.
1070         (unk_lang_value_print_inner): Delete.
1071         (unknown_language_data): Delete la_value_print_inner initializer.
1072         (unknown_language::value_print_inner): New member function.
1073         (auto_language_data): Delete la_value_print_inner initializer.
1074         (auto_language::value_print_inner): New member function.
1075         * language.h (language_data): Delete la_value_print_inner field.
1076         (language_defn::value_print_inner): Delcare new member function.
1077         * m2-lang.c (m2_language_data): Delete la_value_print_inner
1078         initializer.
1079         (m2_language::value_print_inner): New member function.
1080         * objc-lang.c (objc_language_data): Delete la_value_print_inner
1081         initializer.
1082         * opencl-lang.c (opencl_language_data): Likewise.
1083         * p-lang.c (pascal_language_data): Likewise.
1084         (pascal_language::value_print_inner): New member function.
1085         * rust-lang.c (rust_language_data): Delete la_value_print_inner
1086         initializer.
1087         (rust_language::value_print_inner): New member function.
1088         * valprint.c (do_val_print): Update call to value_print_inner.
1089
1090 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1091
1092         * ada-lang.c (ada_language_data): Delete la_value_print
1093         initializer.
1094         (ada_language::value_print): New member function.
1095         * c-lang.c (c_language_data): Delete la_value_print initializer.
1096         (cplus_language_data): Likewise.
1097         (asm_language_data): Likewise.
1098         (minimal_language_data): Likewise.
1099         * d-lang.c (d_language_data): Likewise.
1100         * f-lang.c (f_language_data): Likewise.
1101         * go-lang.c (go_language_data): Likewise.
1102         * language.c (unk_lang_value_print): Delete.
1103         (language_defn::value_print): Define new member function.
1104         (unknown_language_data): Delete la_value_print initializer.
1105         (unknown_language::value_print): New member function.
1106         (auto_language_data): Delete la_value_print initializer.
1107         (auto_language::value_print): New member function.
1108         * language.h (language_data): Delete la_value_print field.
1109         (language_defn::value_print): Declare new member function.
1110         (LA_VALUE_PRINT): Update call to value_print.
1111         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
1112         * objc-lang.c (objc_language_data): Likewise.
1113         * opencl-lang.c (opencl_language_data): Likewise.
1114         * p-lang.c (pascal_language_data): Likewise.
1115         (pascal_language::value_print): New member function.
1116         * rust-lang.c (rust_language_data): Delete la_value_print
1117         initializer.
1118
1119 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * ada-lang.c (ada_watch_location_expression): Rename to
1122         ada_language::watch_location_expression.
1123         (ada_language_data): Delete la_watch_location_expression
1124         initializer.
1125         (ada_language::watch_location_expression): New member function,
1126         implementation from ada_watch_location_expression.
1127         * breakpoint.c (watch_command_1): Update call to
1128         watch_location_expression.
1129         * c-lang.c (c_watch_location_expression): Rename to
1130         language_defn::watch_location_expression.
1131         (c_language_data): Delete la_watch_location_expression
1132         initializer.
1133         (cplus_language_data): Likewise.
1134         (asm_language_data): Likewise.
1135         (minimal_language_data): Likewise.
1136         * c-lang.h (c_watch_location_expression): Delete declaration.
1137         * d-lang.c (d_language_data): Delete la_watch_location_expression
1138         initializer.
1139         * f-lang.c (f_language_data): Likewise.
1140         * go-lang.c (go_language_data): Likewise.
1141         * language.c (language_defn::watch_location_expression): Member
1142         function implementation from c_watch_location_expression.
1143         (unknown_language_data): Delete la_watch_location_expression
1144         initializer.
1145         (auto_language_data): Likewise.
1146         * language.h (language_data): Delete la_watch_location_expression
1147         field.
1148         (language_defn::watch_location_expression): Declare new member
1149         function.
1150         * m2-lang.c (m2_language_data): Delete
1151         la_watch_location_expression initializer.
1152         * objc-lang.c (objc_language_data): Likewise.
1153         * opencl-lang.c (opencl_language_data): Likewise.
1154         * p-lang.c (pascal_language_data): Likewise.
1155         * rust-lang.c (rust_watch_location_expression): Rename to
1156         rust_language::watch_location_expression.
1157         (rust_language_data): Delete la_watch_location_expression
1158         initializer.
1159         (rust_language::watch_location_expression): New member function,
1160         implementation from rust_watch_location_expression.
1161
1162 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
1165         ada_language::collect_symbol_completion_matches.
1166         (ada_language_data): Delete la_collect_symbol_completion_matches
1167         initializer.
1168         (ada_language::collect_symbol_completion_matches): New member
1169         function, implementation from
1170         ada_collect_symbol_completion_matches.
1171         * c-lang.c (c_language_data): Delete
1172         la_collect_symbol_completion_matches initializer.
1173         (cplus_language_data): Likewise.
1174         (asm_language_data): Likewise.
1175         (minimal_language_data): Likewise.
1176         * d-lang.c (d_language_data): Likewise.
1177         * f-lang.c (f_collect_symbol_completion_matches): Rename to
1178         f_language::collect_symbol_completion_matches.
1179         (f_language_data): Delete la_collect_symbol_completion_matches
1180         initializer.
1181         (f_language::collect_symbol_completion_matches) New member
1182         function, implementation from f_collect_symbol_completion_matches.
1183         * go-lang.c (go_language_data): Delete
1184         la_collect_symbol_completion_matches initializer.
1185         * language.c (unknown_language_data): Likewise.
1186         (auto_language_data): Likewise.
1187         * language.h (language_data): Delete
1188         la_collect_symbol_completion_matches field.
1189         (language_defn::collect_symbol_completion_matches): New member
1190         function.
1191         * m2-lang.c (m2_language_data): Delete
1192         la_collect_symbol_completion_matches initializer.
1193         * objc-lang.c (objc_language_data): Likewise.
1194         * opencl-lang.c (opencl_language_data): Likewise.
1195         * p-lang.c (pascal_language_data): Likewise.
1196         * rust-lang.c (rust_language_data): Likewise.
1197         * symtab.c (default_collect_symbol_completion_matches): Delete.
1198         (collect_symbol_completion_matches): Update call to
1199         collect_symbol_completion_matches.
1200         (collect_symbol_completion_matches_type): Likewise.
1201         * symtab.h (default_collect_symbol_completion_matches): Delete
1202         declaration.
1203
1204 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
1207         (ada_language_data): Delete la_word_break_characters initializer.
1208         (ada_language::word_break_characters): New member function.
1209         * c-lang.c (c_language_data): Delete la_word_break_characters
1210         initializer.
1211         (cplus_language_data): Likewise.
1212         (asm_language_data): Likewise.
1213         (minimal_language_data): Likewise.
1214         * completer.c: Update global comment.
1215         (advance_to_expression_complete_word_point): Update call to
1216         word_break_characters.
1217         (complete_files_symbols): Likewise.
1218         (complete_line_internal_1): Likewise.
1219         (default_completer_handle_brkchars): Likewise.
1220         (skip_quoted_chars): Likewise.
1221         * d-lang.c (d_language_data): Delete la_word_break_characters
1222         initializer.
1223         * f-lang.c (f_word_break_characters): Delete.
1224         (f_language_data): Delete la_word_break_characters initializer.
1225         (f_language::word_break_characters): New member function.
1226         * go-lang.c (go_language_data): Delete la_word_break_characters
1227         initializer.
1228         * language.c (unknown_language_data): Likewise.
1229         (auto_language_data): Likewise.
1230         * language.h (default_word_break_characters): Move declaration to
1231         earlier in the file.
1232         (language_data): Delete la_word_break_characters field.
1233         (language_defn::word_break_characters): New member function.
1234         * m2-lang.c (m2_language_data): Delete la_word_break_characters
1235         initializer.
1236         * objc-lang.c (objc_language_data): Likewise.
1237         * opencl-lang.c (opencl_language_data): Likewise.
1238         * p-lang.c (pascal_language_data): Likewise.
1239         * rust-lang.c (rust_language_data): Likewise.
1240
1241 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
1244         (ada_language_data): Delete la_get_symbol_name_matcher
1245         initializer.
1246         (language_defn::get_symbol_name_matcher_inner): New member
1247         function.
1248         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
1249         initializer.
1250         (cplus_language_data): Likewise.
1251         (cplus_language::get_symbol_name_matcher_inner): New member
1252         function.
1253         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
1254         (minimal_language_data): Likewise.
1255         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
1256         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
1257         initializer.
1258         * dictionary.c (iter_match_first_hashed): Update call to
1259         get_symbol_name_matcher.
1260         (iter_match_next_hashed): Likewise.
1261         (iter_match_next_linear): Likewise.
1262         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
1263         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
1264         initializer.
1265         (f_language::get_symbol_name_matcher_inner): New member function.
1266         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
1267         initializer.
1268         * language.c (default_symbol_name_matcher): Update header comment,
1269         make static.
1270         (language_defn::get_symbol_name_matcher): New definition.
1271         (language_defn::get_symbol_name_matcher_inner): Likewise.
1272         (get_symbol_name_matcher): Delete.
1273         (unknown_language_data): Delete la_get_symbol_name_matcher
1274         initializer.
1275         (auto_language_data): Likewise.
1276         * language.h (language_data): Delete la_get_symbol_name_matcher
1277         field.
1278         (language_defn::get_symbol_name_matcher): New member function.
1279         (language_defn::get_symbol_name_matcher_inner): Likewise.
1280         (default_symbol_name_matcher): Delete declaration.
1281         * linespec.c (find_methods): Update call to
1282         get_symbol_name_matcher.
1283         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
1284         initializer.
1285         * minsyms.c (lookup_minimal_symbol): Update call to
1286         get_symbol_name_matcher.
1287         (iterate_over_minimal_symbols): Likewise.
1288         * objc-lang.c (objc_language_data): Delete
1289         la_get_symbol_name_matcher initializer.
1290         * opencl-lang.c (opencl_language_data): Likewise.
1291         * p-lang.c (pascal_language_data): Likewise.
1292         * psymtab.c (psymbol_name_matches): Update call to
1293         get_symbol_name_matcher.
1294         * rust-lang.c (rust_language_data): Delete
1295         la_get_symbol_name_matcher initializer.
1296         * symtab.c (symbol_matches_search_name): Update call to
1297         get_symbol_name_matcher.
1298         (compare_symbol_name): Likewise.
1299
1300 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * ada-lang.c (ada_language_data): Delete la_compute_program
1303         initializer.
1304         * c-lang.c (c_language_data): Likewise.
1305         (c_language::compute_program): New member function.
1306         (cplus_language_data): Delete la_compute_program initializer.
1307         (cplus_language::compute_program): New member function.
1308         (asm_language_data): Delete la_compute_program initializer.
1309         (minimal_language_data): Likewise.
1310         * c-lang.h (c_compute_program): Update comment.
1311         (cplus_compute_program): Likewise.
1312         * compile/compile-c-support.c (c_compute_program): Likewise.
1313         (cplus_compute_program): Likewise.
1314         * compile/compile.c (compile_to_object): Update call to
1315         la_compute_program.
1316         * d-lang.c (d_language_data): Delete la_compute_program
1317         initializer.
1318         * f-lang.c (f_language_data): Likewise.
1319         * go-lang.c (go_language_data): Likewise.
1320         * language.c (unknown_language_data): Likewise.
1321         (auto_language_data): Likewise.
1322         * language.h (language_data): Delete la_compute_program field.
1323         (language_defn::compute_program): New member function.
1324         * m2-lang.c (m2_language_data): Delete la_compute_program
1325         initializer.
1326         * objc-lang.c (objc_language_data): Likewise.
1327         * opencl-lang.c (opencl_language_data): Likewise.
1328         * p-lang.c (pascal_language_data): Likewise.
1329         * rust-lang.c (rust_language_data): Likewise.
1330
1331 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * ada-lang.c (ada_language_data) Delete
1334         la_class_name_from_physname initializer.
1335         * c-lang.c (c_language_data): Likewise.
1336         (cplus_language_data): Likewise.
1337         (cplus_language::class_name_from_physname): New member function.
1338         (asm_language_data): Delete la_class_name_from_physname
1339         initializer.
1340         (minimal_language_data): Likewise.
1341         * d-lang.c (d_language_data): Likewise.
1342         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
1343         method on language_defn class.
1344         (guess_full_die_structure_name): Likewise.
1345         * f-lang.c (f_language_data): Delete la_class_name_from_physname
1346         initializer.
1347         * go-lang.c (go_language_data): Likewise.
1348         * language.c (language_class_name_from_physname): Delete.
1349         (unk_lang_class_name): Delete.
1350         (unknown_language_data): Delete la_class_name_from_physname
1351         initializer.
1352         (auto_language_data): Likewise.
1353         * language.h (language_data): Delete la_class_name_from_physname
1354         field.
1355         (language_defn::class_name_from_physname): New function.
1356         (language_class_name_from_physname): Delete declaration.
1357         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
1358         initializer.
1359         * objc-lang.c (objc_language_data): Likewise.
1360         * opencl-lang.c (opencl_language_data): Likewise.
1361         * p-lang.c (pascal_language_data): Likewise.
1362         * rust-lang.c (rust_language_data): Likewise.
1363
1364 2020-06-16  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-data.h (STATUS_NAME): New macro.
1367         * tui/tui-layout.c (tui_remove_some_windows)
1368         (initialize_known_windows, tui_register_window)
1369         (tui_layout_split::remove_windows, initialize_layouts)
1370         (tui_new_layout_command): Don't use hard-coded window names.
1371
1372 2020-06-16  Tom Tromey  <tom@tromey.com>
1373
1374         PR tui/25348:
1375         * tui/tui.c (tui_ensure_readline_initialized): Rename from
1376         tui_initialize_readline.  Only run once.  Call rl_initialize.
1377         * tui/tui.h (tui_ensure_readline_initialized): Rename from
1378         tui_initialize_readline.
1379         * tui/tui-io.c (tui_setup_io): Call
1380         tui_ensure_readline_initialized.
1381         * tui/tui-interp.c (tui_interp::init): Update.
1382
1383 2020-06-16  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
1386         Also preserve the status window.
1387
1388 2020-06-16  Tom Tromey  <tom@tromey.com>
1389
1390         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
1391         where m_window==nullptr.
1392
1393 2020-06-15  Tom Tromey  <tromey@adacore.com>
1394
1395         * windows-nat.c (windows_nat::handle_output_debug_string):
1396         Update.
1397         (windows_nat::handle_ms_vc_exception): Update.
1398         * target.h (target_read_string): Change API.
1399         * target.c (target_read_string): Change API.
1400         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
1401         Update.
1402         * solib-frv.c (frv_current_sos): Update.
1403         * solib-dsbt.c (dsbt_current_sos): Update.
1404         * solib-darwin.c (darwin_current_sos): Update.
1405         * linux-thread-db.c (inferior_has_bug): Update.
1406         * expprint.c (print_subexp_standard): Update.
1407         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
1408         (ada_exception_message_1): Update.
1409
1410 2020-06-15  Tom Tromey  <tromey@adacore.com>
1411
1412         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
1413
1414 2020-06-15  Tom Tromey  <tromey@adacore.com>
1415
1416         * valprint.c (read_string): Update comment.
1417         * target.c (MIN): Remove.
1418         (target_read_string): Rewrite.
1419
1420 2020-06-15  Tom Tromey  <tromey@adacore.com>
1421
1422         * corefile.c (read_memory_string): Remove.
1423         * ada-valprint.c (ada_value_print_ptr): Update.
1424         * ada-lang.h (ada_tag_name): Change return type.
1425         * ada-lang.c (type_from_tag): Update.
1426         (ada_tag_name_from_tsd): Change return type.  Use
1427         target_read_string.
1428         (ada_tag_name): Likewise.
1429         * gdbcore.h (read_memory_string): Don't declare.
1430
1431 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
1432
1433         * symtab.c (rbreak_command): Ignore Windows drive colon.
1434
1435 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
1436
1437         * NEWS: Mention removed GDBserver host support.
1438
1439 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
1440
1441         * features/riscv/rebuild-csr-xml.sh: Updated.
1442
1443 2020-06-11  Tom Tromey  <tom@tromey.com>
1444
1445         PR gdb/18318:
1446         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
1447
1448 2020-06-09  Jonny Grant  <jg@jguk.org>
1449 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
1450
1451         * main.c (captured_main_1): Don't print new line after help.
1452         (print_gdb_help): add mailing list and IRC channel information
1453         to --help.  Add new lines between items in the footer.  Remove
1454         quotes around bug url.
1455
1456 2020-06-11  Keith Seitz  <keiths@redhat.com>
1457
1458         PR gdb/21356
1459         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
1460         Resolve typedefs for type length calculations.
1461
1462 2020-06-10  Tom de Vries  <tdevries@suse.de>
1463
1464         PR ada/24713
1465         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
1466         (write_psymbols): Enable .gdb_index for ada.
1467         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
1468         ada.
1469
1470 2020-06-10  Tom de Vries  <tdevries@suse.de>
1471
1472         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
1473         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
1474         namei" instead of "const char *name" argument.
1475         (dw2_map_matching_symbols): Use "offset_type namei" variant of
1476         dw2_symtab_iter_init.
1477
1478 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1479
1480         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
1481         to use type::field and field::type instead.
1482
1483 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1484
1485         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
1486         to use field::type instead.
1487
1488 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1489
1490         * gdbtypes.h (struct field) <type, set_type>: New methods.
1491         Rename `type` field to...
1492         <m_type>: ... this.  Change references throughout to use type or
1493         set_type methods.
1494         (FIELD_TYPE): Use field::type.  Change call sites that modify
1495         the field's type to use field::set_type instead.
1496
1497 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1498
1499         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
1500         to use type::index_type instead.
1501
1502 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1503
1504         * gdbtypes.h (struct type) <index_type, set_index_type>: New
1505         methods.
1506         (TYPE_INDEX_TYPE): Use type::index_type.
1507         * gdbtypes.c (create_array_type_with_stride): Likewise.
1508
1509 2020-06-07  Tom Tromey  <tom@tromey.com>
1510
1511         * valprint.c (generic_val_print_float): Remove "embedded_offset"
1512         parameter.
1513         (generic_value_print): Update.
1514
1515 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         Revert commit 982a38f60b0.
1518         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
1519
1520 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1521
1522         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
1523         avoid use after free.
1524
1525 2020-06-05  Tom de Vries  <tdevries@suse.de>
1526
1527         * NEWS: Fix typos.
1528
1529 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
1530
1531         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
1532         the per_bfd object.
1533         (dwarf2_read_debug_names): Likewise.
1534         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
1535         object when re-using a per_bfd object with an index.
1536
1537 2020-06-03  Tom de Vries  <tdevries@suse.de>
1538
1539         PR symtab/26046
1540         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
1541         children for C++.
1542         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
1543         DW_TAG_subprogram.
1544
1545 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * ada-lang.c (ada_language_data): Delete skip_trampoline
1548         initializer.
1549         * c-lang.c (c_language_data): Likewise.
1550         (cplus_language_data): Likewise.
1551         (cplus_language::skip_trampoline): New member function.
1552         (asm_language_data): Delete skip_trampoline initializer.
1553         (minimal_language_data): Likewise.
1554         * d-lang.c (d_language_data): Likewise.
1555         * f-lang.c (f_language_data): Likewise.
1556         * go-lang.c (go_language_data): Likewise.
1557         * language.c (unk_lang_trampoline): Delete function.
1558         (skip_language_trampoline): Update.
1559         (unknown_language_data): Delete skip_trampoline initializer.
1560         (auto_language_data): Likewise.
1561         * language.h (language_data): Delete skip_trampoline field.
1562         (language_defn::skip_trampoline): New function.
1563         * m2-lang.c (m2_language_data): Delete skip_trampoline
1564         initializer.
1565         * objc-lang.c (objc_skip_trampoline): Delete function, move
1566         implementation to objc_language::skip_trampoline.
1567         (objc_language_data): Delete skip_trampoline initializer.
1568         (objc_language::skip_trampoline): New member function with
1569         implementation from objc_skip_trampoline.
1570         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
1571         initializer.
1572         * p-lang.c (pascal_language_data): Likewise.
1573         * rust-lang.c (rust_language_data): Likewise.
1574
1575 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1576
1577         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
1578         (ada_language::demangle): New member function.
1579         * c-lang.c (c_language_data): Delete la_demangle initializer.
1580         (cplus_language_data): Delete la_demangle initializer.
1581         (cplus_language::demangle): New member function.
1582         (asm_language_data): Delete la_demangle initializer.
1583         (minimal_language_data): Delete la_demangle initializer.
1584         * d-lang.c (d_language_data): Delete la_demangle initializer.
1585         (d_language::demangle): New member function.
1586         * f-lang.c (f_language_data): Delete la_demangle initializer.
1587         (f_language::demangle): New member function.
1588         * go-lang.c (go_language_data): Delete la_demangle initializer.
1589         (go_language::demangle): New member function.
1590         * language.c (language_demangle): Update.
1591         (unk_lang_demangle): Delete.
1592         (unknown_language_data): Delete la_demangle initializer.
1593         (unknown_language::demangle): New member function.
1594         (auto_language_data): Delete la_demangle initializer.
1595         (auto_language::demangle): New member function.
1596         * language.h (language_data): Delete la_demangle field.
1597         (language_defn::demangle): New function.
1598         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
1599         * objc-lang.c (objc_language_data): Delete la_demangle
1600         initializer.
1601         (objc_language::demangle): New member function.
1602         * opencl-lang.c (opencl_language_data): Delete la_demangle
1603         initializer.
1604         * p-lang.c (pascal_language_data): Likewise.
1605         * rust-lang.c (rust_language_data): Likewise.
1606         (rust_language::demangle): New member function.
1607
1608 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * ada-lang.c (ada_language_data): Delete la_print_type
1611         initializer.
1612         (ada_language::print_type): New member function.
1613         * c-lang.c (c_language_data): Delete la_print_type initializer.
1614         (c_language::print_type): New member function.
1615         (cplus_language_data): Delete la_print_type initializer.
1616         (cplus_language::print_type): New member function.
1617         (asm_language_data): Delete la_print_type initializer.
1618         (asm_language::print_type): New member function.
1619         (minimal_language_data): Delete la_print_type initializer.
1620         (minimal_language::print_type): New member function.
1621         * d-lang.c (d_language_data): Delete la_print_type initializer.
1622         (d_language::print_type): New member function.
1623         * f-lang.c (f_language_data): Delete la_print_type initializer.
1624         (f_language::print_type): New member function.
1625         * go-lang.c (go_language_data): Delete la_print_type initializer.
1626         (go_language::print_type): New member function.
1627         * language.c (unk_lang_print_type): Delete.
1628         (unknown_language_data): Delete la_print_type initializer.
1629         (unknown_language::print_type): New member function.
1630         (auto_language_data): Delete la_print_type initializer.
1631         (auto_language::print_type): New member function.
1632         * language.h (language_data): Delete la_print_type field.
1633         (language_defn::print_type): New function.
1634         (LA_PRINT_TYPE): Update.
1635         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
1636         (m2_language::print_type): New member function.
1637         * objc-lang.c (objc_language_data): Delete la_print_type
1638         initializer.
1639         (objc_language::print_type): New member function.
1640         * opencl-lang.c (opencl_print_type): Delete, implementation moved
1641         to opencl_language::print_type.
1642         (opencl_language_data): Delete la_print_type initializer.
1643         (opencl_language::print_type): New member function, implementation
1644         from opencl_print_type.
1645         * p-lang.c (pascal_language_data): Delete la_print_type
1646         initializer.
1647         (pascal_language::print_type): New member function.
1648         * rust-lang.c (rust_print_type): Delete, implementation moved to
1649         rust_language::print_type.
1650         (rust_language_data): Delete la_print_type initializer.
1651         (rust_language::print_type): New member function, implementation
1652         from rust_print_type.
1653
1654 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1655
1656         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
1657         implementation moves to...
1658         (ada_language::sniff_from_mangled_name): ...here.  Update return
1659         type.
1660         (ada_language_data): Delete la_sniff_from_mangled_name
1661         initializer.
1662         * c-lang.c (c_language_data): Likewise.
1663         (cplus_language_data): Likewise.
1664         (cplus_language::sniff_from_mangled_name): New member function,
1665         implementation taken from gdb_sniff_from_mangled_name.
1666         (asm_language_data): Delete la_sniff_from_mangled_name
1667         initializer.
1668         (minimal_language_data): Likewise.
1669         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
1670         implementation moves to cplus_language::sniff_from_mangled_name.
1671         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
1672         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
1673         moves to...
1674         (d_language::sniff_from_mangled_name): ...here.
1675         (d_language_data): Delete la_sniff_from_mangled_name initializer.
1676         * f-lang.c (f_language_data): Likewise.
1677         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
1678         moves to...
1679         (go_language::sniff_from_mangled_name): ...here.
1680         (go_language_data): Delete la_sniff_from_mangled_name initializer.
1681         * language.c (language_sniff_from_mangled_name): Delete.
1682         (unknown_language_data): Delete la_sniff_from_mangled_name
1683         initializer.
1684         (auto_language_data): Likewise.
1685         * language.h (language_data): Delete la_sniff_from_mangled_name
1686         field.
1687         (language_defn::sniff_from_mangled_name): New function.
1688         (language_sniff_from_mangled_name): Delete declaration.
1689         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
1690         field.
1691         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
1692         implementation moves to...
1693         (objc_language::sniff_from_mangled_name): ...here.
1694         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
1695         * opencl-lang.c (opencl_language_data): Likewise.
1696         * p-lang.c (pascal_language_data): Likewise.
1697         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
1698         implementation moves to...
1699         (rust_language::sniff_from_mangled_name): ...here.
1700         (rust_language_data): Delete la_sniff_from_mangled_name
1701         initializer.
1702         * symtab.c (symbol_find_demangled_name): Call
1703         sniff_from_mangled_name member function.
1704
1705 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1706
1707         * ada-lang.c (ada_language_data): Delete la_search_name_hash
1708         initializer.
1709         * c-lang.c (c_language_data): Likewise.
1710         (cplus_language_data): Likewise.
1711         (cplus_language::search_name_hash): New member function.
1712         (asm_language_data): Delete la_search_name_hash initializer.
1713         (minimal_language_data): Likewise.
1714         * d-lang.c (d_language_data): Likewise.
1715         * dictionary.c (default_search_name_hash): Rename to...
1716         (language_defn::search_name_hash): ...this.
1717         * f-lang.c (f_language_data): Likewise.
1718         (f_language::search_name_hash): New member function.
1719         * go-lang.c (go_language_data): Delete la_search_name_hash
1720         initializer.
1721         * language.c (unknown_language_data): Likewise.
1722         (auto_language_data): Likewise.
1723         * language.h (struct language_data): Delete la_search_name_hash
1724         field.
1725         (language_defn::search_name_hash): Declare new member function.
1726         (default_search_name_hash): Delete declaration.
1727         * m2-lang.c (m2_language_data): Delete la_search_name_hash
1728         initializer.
1729         * objc-lang.c (objc_language_data): Likewise.
1730         * opencl-lang.c (opencl_language_data): Likewise.
1731         * p-lang.c (pascal_language_data): Likewise.
1732         * rust-lang.c (rust_language_data): Likewise.
1733         * symtab.c (search_name_hash): Update call.
1734
1735 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1736
1737         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
1738         initializer.
1739         * c-lang.c (class compile_instance): Declare.
1740         (c_language_data): Delete la_get_compile_instance initializer.
1741         (c_language::get_compile_instance): New member function.
1742         (cplus_language_data): Delete la_get_compile_instance initializer.
1743         (cplus_language::get_compile_instance): New member function.
1744         (asm_language_data): Delete la_get_compile_instance initializer.
1745         (minimal_language_data): Likewise.
1746         * c-lang.h (c_get_compile_context): Update comment.
1747         (cplus_get_compile_context): Update comment.
1748         * compile/compile.c (compile_to_object): Update calls, don't rely
1749         on function pointer being NULL.
1750         * d-lang.c (d_language_data): Delete la_get_compile_instance
1751         initializer.
1752         * f-lang.c (f_language_data): Likewise.
1753         * go-lang.c (go_language_data): Likewise.
1754         * language.c (unknown_language_data): Likewise.
1755         (auto_language_data): Likewise.
1756         * language.h (language_data): Delete la_get_compile_instance field.
1757         (language_defn::get_compile_instance): New member function.
1758         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
1759         initializer.
1760         * objc-lang.c (objc_language_data): Likewise.
1761         * opencl-lang.c (opencl_language_data): Likewise.
1762         * p-lang.c (pascal_language_data): Likewise.
1763         * rust-lang.c (rust_language_data): Likewise.
1764
1765 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1766
1767         * ada-lang.c (ada_add_all_symbols): Update comment.
1768         (ada_iterate_over_symbols): Delete, move implementation to...
1769         (ada_language::iterate_over_symbols): ...here, a new member
1770         function, rewrite to use range based for loop.
1771         (ada_language_data): Delete la_iterate_over_symbols initializer.
1772         * c-lang.c (c_language_data): Likewise.
1773         (cplus_language_data): Likewise.
1774         (asm_language_data): Likewise.
1775         (minimal_language_data): Likewise.
1776         * d-lang.c (d_language_data): Likewise.
1777         * f-lang.c (f_language_data): Likewise.
1778         * go-lang.c (go_language_data): Likewise.
1779         * language.c (unknown_language_data): Likewise.
1780         (auto_language_data): Likewise.
1781         * language.h (language_data): Delete la_iterate_over_symbols field.
1782         (language_defn::iterate_over_symbols): New member function.
1783         (LA_ITERATE_OVER_SYMBOLS): Update.
1784         * linespec.c (iterate_over_all_matching_symtabs): Update.
1785         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
1786         initializer.
1787         * objc-lang.c (objc_language_data): Likewise.
1788         * opencl-lang.c (opencl_language_data): Likewise.
1789         * p-lang.c (pascal_language_data): Likewise.
1790         * rust-lang.c (rust_language_data): Likewise.
1791
1792 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * ada-lang.c (ada_language_data): Delete
1795         la_lookup_transparent_type initializer.
1796         * c-lang.c (c_language_data): Likewise.
1797         (cplus_language_data): Likewise.
1798         (cplus_language::lookup_transparent_type): New member function.
1799         (asm_language_data): Delete la_lookup_transparent_type
1800         initializer.
1801         (minimal_language_data): Likewise.
1802         * d-lang.c (d_language_data): Likewise.
1803         * f-lang.c (f_language_data): Likewise.
1804         * go-lang.c (go_language_data): Likewise.
1805         * language.c (unknown_language_data): Likewise.
1806         (auto_language_data): Likewise.
1807         * language.h (struct language_data): Delete
1808         la_lookup_transparent_type field.
1809         (language_defn::lookup_transparent_type): New member function.
1810         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
1811         initializer.
1812         * objc-lang.c (objc_language_data): Likewise.
1813         * opencl-lang.c (opencl_language_data): Likewise.
1814         * p-lang.c (pascal_language_data): Likewise.
1815         * rust-lang.c (rust_language_data): Likewise.
1816         * symtab.c (symbol_matches_domain): Update call.
1817
1818 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1819
1820         * ada-lang.c (ada_language_arch_info): Delete function, move
1821         implementation to...
1822         (ada_language::language_arch_info): ...here, a new member
1823         function.
1824         (ada_language_data): Delete la_language_arch_info.
1825         * c-lang.c (c_language_data): Likewise.
1826         (c_language::language_arch_info): New member function.
1827         (cplus_language_arch_info): Delete function, move
1828         implementation to...
1829         (cplus_language::language_arch_info): ...here, a new member
1830         function.
1831         (cplus_language_data): Delete la_language_arch_info.
1832         (asm_language_data): Likewise.
1833         (asm_language::language_arch_info): New member function.
1834         (minimal_language_data): Delete la_language_arch_info.
1835         (minimal_language::language_arch_info): New member function.
1836         * d-lang.c (d_language_arch_info): Delete function, move
1837         implementation to...
1838         (d_language::language_arch_info): ...here, a new member
1839         function.
1840         (d_language_data): Delete la_language_arch_info.
1841         * f-lang.c (f_language_arch_info): Delete function, move
1842         implementation to...
1843         (f_language::language_arch_info): ...here, a new member
1844         function.
1845         (f_language_data): Delete la_language_arch_info.
1846         * go-lang.c (go_language_arch_info): Delete function, move
1847         implementation to...
1848         (go_language::language_arch_info): ...here, a new member
1849         function.
1850         (go_language_data): Delete la_language_arch_info.
1851         * language.c (unknown_language_data): Likewise.
1852         (unknown_language::language_arch_info): New member function.
1853         (auto_language_data): Delete la_language_arch_info.
1854         (auto_language::language_arch_info): New member function.
1855         (language_gdbarch_post_init): Update call to
1856         la_language_arch_info.
1857         * language.h (language_data): Delete la_language_arch_info
1858         function pointer.
1859         (language_defn::language_arch_info): New function.
1860         * m2-lang.c (m2_language_arch_info): Delete function, move
1861         implementation to...
1862         (m2_language::language_arch_info): ...here, a new member
1863         function.
1864         (m2_language_data): Delete la_language_arch_info.
1865         * objc-lang.c (objc_language_arch_info): Delete function, move
1866         implementation to...
1867         (objc_language::language_arch_info): ...here, a new member
1868         function.
1869         (objc_language_data): Delete la_language_arch_info.
1870         * opencl-lang.c (opencl_language_arch_info): Delete function, move
1871         implementation to...
1872         (opencl_language::language_arch_info): ...here, a new member
1873         function.
1874         (opencl_language_data): Delete la_language_arch_info.
1875         * p-lang.c (pascal_language_arch_info): Delete function, move
1876         implementation to...
1877         (pascal_language::language_arch_info): ...here, a new member
1878         function.
1879         (pascal_language_data): Delete la_language_arch_info.
1880         * rust-lang.c (rust_language_arch_info): Delete function, move
1881         implementation to...
1882         (rust_language::language_arch_info): ...here, a new member
1883         function.
1884         (rust_language_data): Delete la_language_arch_info.
1885
1886 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1887
1888         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
1889         initializer.
1890         * c-lang.c (c_language_data): Likewise.
1891         (cplus_language_data): Likewise.
1892         (cplus_language::pass_by_reference_info): New method.
1893         (asm_language_data): Delete la_pass_by_reference initializer.
1894         (minimal_language_data): Likewise.
1895         * cp-abi.c (cp_pass_by_reference): Remove use of
1896         default_pass_by_reference.
1897         * d-lang.c (d_language_data): Likewise.
1898         * f-lang.c (f_language_data): Likewise.
1899         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
1900         default_pass_by_reference.
1901         * go-lang.c (go_language_data): Likewise.
1902         * language.c (language_pass_by_reference): Update.
1903         (default_pass_by_reference): Delete.
1904         (unknown_language_data): Delete la_pass_by_reference
1905         initializer.
1906         (auto_language_data): Likewise.
1907         * language.h (struct language_data): Delete la_pass_by_reference
1908         field.
1909         (language_defn::pass_by_reference_info): New member function.
1910         (default_pass_by_reference): Delete declaration.
1911         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
1912         initializer.
1913         * objc-lang.c (objc_language_data): Likewise.
1914         * opencl-lang.c (opencl_language_data): Likewise.
1915         * p-lang.c (pascal_language_data): Likewise.
1916         * rust-lang.c (rust_language_data): Likewise.
1917
1918 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * ada-lang.c (ada_read_var_value): Delete function, move
1921         implementation to...
1922         (ada_language::read_var_value): ...here.
1923         (ada_language_data): Delete la_read_var_value initializer.
1924         * c-lang.c (c_language_data): Likewise.
1925         (cplus_language_data): Likewise.
1926         (minimal_language_data): Likewise.
1927         * d-lang.c (d_language_data): Likewise.
1928         * f-lang.c (f_language_data): Likewise.
1929         * findvar.c (default_read_var_value): Rename to...
1930         (language_defn::read_var_value): ...this.
1931         * findvar.c (read_var_value): Update header comment, and change to
1932         call member function instead of function pointer.
1933         * go-lang.c (go_language_data): Likewise.
1934         * language.c (unknown_language_data): Delete la_read_var_value
1935         initializer.
1936         (auto_language_data): Likewise.
1937         * language.h (struct language_data): Delete la_read_var_value
1938         field.
1939         (language_defn::read_var_value): New member function.
1940         (default_read_var_value): Delete declaration.
1941         * m2-lang.c (m2_language_data): Delete la_read_var_value
1942         initializer.
1943         * objc-lang.c (objc_language_data): Likewise.
1944         * opencl-lang.c (opencl_language_data): Likewise.
1945         * p-lang.c (pascal_language_data): Likewise.
1946         * rust-lang.c (rust_language_data): Likewise.
1947         * value.h (default_read_var_value): Delete declaration.
1948
1949 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1950
1951         * ada-lang.c (ada_print_array_index): Delete function, move
1952         implementation to...
1953         (ada_language::print_array_index): ...here.
1954         (ada_language_data): Delete la_print_array_index initializer.
1955         * c-lang.c (c_language_data): Likewise.
1956         (cplus_language_data): Likewise.
1957         (minimal_language_data): Likewise.
1958         * d-lang.c (d_language_data): Likewise.
1959         * f-lang.c (f_language_data): Likewise.
1960         * go-lang.c (go_language_data): Likewise.
1961         * language.c (default_print_array_index): Delete function, move
1962         implementation to...
1963         (language_defn::print_array_index): ...here.
1964         (unknown_language_data): Delete la_print_array_index initializer.
1965         (auto_language_data): Likewise.
1966         * language.h (struct language_data): Delete la_print_array_index
1967         field.
1968         (language_defn::print_array_index): New member function.
1969         (LA_PRINT_ARRAY_INDEX): Update.
1970         (default_print_array_index): Delete declaration.
1971         * m2-lang.c (m2_language_data): Delete la_print_array_index
1972         initializer.
1973         * objc-lang.c (objc_language_data): Likewise.
1974         * opencl-lang.c (opencl_language_data): Likewise.
1975         * p-lang.c (pascal_language_data): Likewise.
1976         * rust-lang.c (rust_language_data): Likewise.
1977
1978 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         * gdb/ada-lang.c (ada_language_defn): Convert to...
1981         (ada_language_data): ...this.
1982         (class ada_language): New class.
1983         (ada_language_defn): New static global.
1984         * gdb/c-lang.c (c_language_defn): Convert to...
1985         (c_language_data): ...this.
1986         (class c_language): New class.
1987         (c_language_defn): New static global.
1988         (cplus_language_defn): Convert to...
1989         (cplus_language_data): ...this.
1990         (class cplus_language): New class.
1991         (cplus_language_defn): New static global.
1992         (asm_language_defn): Convert to...
1993         (asm_language_data): ...this.
1994         (class asm_language): New class.
1995         (asm_language_defn): New static global.
1996         (minimal_language_defn): Convert to...
1997         (minimal_language_data): ...this.
1998         (class minimal_language): New class.
1999         (minimal_language_defn): New static global.
2000         * gdb/d-lang.c (d_language_defn): Convert to...
2001         (d_language_data): ...this.
2002         (class d_language): New class.
2003         (d_language_defn): New static global.
2004         * gdb/f-lang.c (f_language_defn): Convert to...
2005         (f_language_data): ...this.
2006         (class f_language): New class.
2007         (f_language_defn): New static global.
2008         * gdb/go-lang.c (go_language_defn): Convert to...
2009         (go_language_data): ...this.
2010         (class go_language): New class.
2011         (go_language_defn): New static global.
2012         * gdb/language.c (unknown_language_defn): Remove declaration.
2013         (current_language): Initialize to nullptr, real initialization is
2014         moved to _initialize_language.
2015         (languages): Delete global.
2016         (language_defn::languages): Define.
2017         (set_language_command): Use language_defn::languages.
2018         (set_language): Likewise.
2019         (range_error): Likewise.
2020         (language_enum): Likewise.
2021         (language_def): Likewise.
2022         (add_set_language_command): Use language_def::languages for the
2023         language list, and language_def to lookup language pointers.
2024         (skip_language_trampoline): Use language_defn::languages.
2025         (unknown_language_defn): Convert to...
2026         (unknown_language_data): ...this.
2027         (class unknown_language): New class.
2028         (unknown_language_defn): New static global.
2029         (auto_language_defn): Convert to...
2030         (auto_language_data): ...this.
2031         (class auto_language): New class.
2032         (auto_language_defn): New static global.
2033         (language_gdbarch_post_init): Use language_defn::languages.
2034         (_initialize_language): Initialize current_language.
2035         * gdb/language.h (struct language_defn): Rename to...
2036         (struct language_data): ...this.
2037         (struct language_defn): New.
2038         (auto_language_defn): Delete.
2039         (unknown_language_defn): Delete.
2040         (minimal_language_defn): Delete.
2041         (ada_language_defn): Delete.
2042         (asm_language_defn): Delete.
2043         (c_language_defn): Delete.
2044         (cplus_language_defn): Delete.
2045         (d_language_defn): Delete.
2046         (f_language_defn): Delete.
2047         (go_language_defn): Delete.
2048         (m2_language_defn): Delete.
2049         (objc_language_defn): Delete.
2050         (opencl_language_defn): Delete.
2051         (pascal_language_defn): Delete.
2052         (rust_language_defn): Delete.
2053         * gdb/m2-lang.c (m2_language_defn): Convert to...
2054         (m2_language_data): ...this.
2055         (class m2_language): New class.
2056         (m2_language_defn): New static global.
2057         * gdb/objc-lang.c (objc_language_defn): Convert to...
2058         (objc_language_data): ...this.
2059         (class objc_language): New class.
2060         (objc_language_defn): New static global.
2061         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
2062         (opencl_language_data): ...this.
2063         (class opencl_language): New class.
2064         (opencl_language_defn): New static global.
2065         * gdb/p-lang.c (pascal_language_defn): Convert to...
2066         (pascal_language_data): ...this.
2067         (class pascal_language): New class.
2068         (pascal_language_defn): New static global.
2069         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
2070         language pointer, update comment format.
2071         * gdb/rust-lang.c (rust_language_defn): Convert to...
2072         (rust_language_data): ...this.
2073         (class rust_language): New class.
2074         (rust_language_defn): New static global.
2075
2076 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2077
2078         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
2079         member variable.
2080         <m_stmt_at_address>: New member variable.
2081         (lnp_state_machine::record_line): Don't record some lines, update
2082         tracking of is_stmt at the same address.
2083         (lnp_state_machine::lnp_state_machine): Initialise new member
2084         variables.
2085
2086 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2087
2088         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
2089         "-include gnu-nat-mig.h".
2090         * gnu-nat-mig.h: New file.
2091         * gnu-nat.c: Include "gnu-nat-mig.h".
2092         (exc_server, msg_reply_server, notify_server,
2093         process_reply_server): Remove declarations.
2094
2095 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2096
2097         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
2098         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
2099         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
2100         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
2101         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
2102         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
2103         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
2104         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
2105         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
2106         to gnu_nat_target class.
2107         * gnu-nat.c: Likewise.
2108         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
2109         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
2110         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
2111         object.
2112         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
2113         instead of `gnu_target'.
2114
2115 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2116
2117         * i386-gnu-tdep.c: Include "gdbcore.h"
2118         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
2119         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
2120         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
2121         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
2122         i386_gnu_sigcontext_addr): New functions
2123         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
2124         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
2125         tdep.
2126
2127 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2128
2129         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
2130         before fork_inferior call. Avoid calling it if target_is_pushed returns
2131         true.
2132
2133 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2134
2135         * gnu-nat.h (gnu_target): New variable declaration.
2136         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
2137         gnu_target.
2138         * gnu-nat.c (gnu_target): New variable.
2139         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
2140         add_thread_silent, and add_thread calls.
2141         (gnu_nat_target::create_inferior): Pass gnu_target to
2142         add_thread_silent, thread_change_ptid call.
2143         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
2144         call.
2145
2146 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2147
2148         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
2149         (gnu_nat_target::find_memory_regions): Remove unused
2150         `old_address' variable.
2151
2152 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2153
2154         * gnu-nat.c: Include "gdbarch.h".
2155
2156 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2157
2158         * reply_mig_hack.awk (Error return): Cast function through
2159         void *, to bypass compiler function call check.
2160
2161 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2162
2163         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
2164         $(srcdir)/reply_mig_hack.awk.
2165
2166 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2167
2168         * gnu-nat.h (gnu_debug_flag): Set type to bool.
2169
2170 2020-05-30  Jonny Grant  <jg@jguk.org>
2171
2172         * configure.ac (ACX_BUGURL): change bug URL to https.
2173
2174 2020-05-30  Pedro Alves  <palves@redhat.com>
2175
2176         * cp-support.c (replace_typedefs_template): New.
2177         (replace_typedefs_qualified_name): Handle
2178         DEMANGLE_COMPONENT_TEMPLATE.
2179
2180 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
2181
2182         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
2183         dwarf2/index-cache.h, dwarf2/index-write.c,
2184         dwarf2/index-write.h, dwarf2/line-header.c,
2185         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
2186         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
2187         variables and fields from `dwarf2_per_objfile` to just
2188         `per_objfile` throughout.
2189
2190 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
2191
2192         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2193         <push_dwarf_reg_entry_value>: Add comment.
2194
2195 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
2196             Keith Seitz  <keiths@redhat.com>
2197
2198         * python/python.c (do_start_initialization): Call PyEval_SaveThread
2199         instead of PyEval_ReleaseLock.
2200         (class gdbpy_gil): Move to earlier in file.
2201         (finalize_python): Set gdb_python_initialized.
2202         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
2203         when not initialized.
2204
2205 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
2206
2207         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2208         <push_dwarf_reg_entry_value>: Remove assert.  Override
2209         per_objfile with caller_per_objfile.
2210
2211 2020-05-28  Tom de Vries  <tdevries@suse.de>
2212
2213         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
2214         PR gold/15646 workaround to symbol kind "type".
2215
2216 2020-05-27  Tom Tromey  <tromey@adacore.com>
2217
2218         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
2219
2220 2020-05-27  Tom Tromey  <tromey@adacore.com>
2221
2222         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
2223         Use htab_find_with_hash.
2224         <add_abbrev>: Remove "abbrev_number" parameter.
2225         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
2226         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
2227         (hash_abbrev): Add comment.
2228         (abbrev_table::lookup_abbrev): Move to header file.
2229         (abbrev_table::read): Update.
2230
2231 2020-05-27  Tom Tromey  <tromey@adacore.com>
2232
2233         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
2234         method.
2235         <canonical_name>: New member.
2236         <raw_name>: Rename from "name".
2237         (partial_die_info): Initialize canonical_name.
2238         (scan_partial_symbols): Check raw_name.
2239         (partial_die_parent_scope, partial_die_full_name)
2240         (add_partial_symbol, add_partial_subprogram)
2241         (add_partial_enumeration, load_partial_dies): Use "name" method.
2242         (partial_die_info::name): New method.
2243         (partial_die_info::read, guess_partial_die_structure_name)
2244         (partial_die_info::fixup): Update.
2245
2246 2020-05-27  Tom Tromey  <tromey@adacore.com>
2247
2248         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
2249         <get_ref_die_offset>: Inline.
2250         <get_ref_die_offset_complaint>: New method.
2251         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
2252         (attribute::get_ref_die_offset_complaint): Rename from
2253         get_ref_die_offset.  Just issue complaint.
2254
2255 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2256
2257         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
2258
2259 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2260
2261         * exec.c (exec_file_attach): Use errno value of first openp failure.
2262
2263 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2264
2265         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
2266         Don't close thread handle.
2267
2268 2020-05-27  Tom Tromey  <tom@tromey.com>
2269             Simon Marchi  <simon.marchi@efficios.com>
2270
2271         * objfiles.h (struct objfile) <partial_symtabs>: Now a
2272         shared_ptr.
2273         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
2274         member.
2275         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
2276         dwarf2_per_bfd_objfile_data_key>: New globals.
2277         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
2278         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
2279         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
2280         shared.
2281         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
2282         short-circuit when sharing.
2283         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
2284         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
2285
2286 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2287
2288         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
2289         to...
2290         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
2291         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
2292
2293 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2294
2295         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
2296         build_name_components, find_name_components_bounds>:
2297         Add per_objfile parameter.
2298         (struct mapped_index) <symbol_name_at>: Likewise.
2299         (struct mapped_debug_names): Remove constructor.
2300         <dwarf2_per_objfile>: Remove field.
2301         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
2302         (mapped_index_base::find_name_components_bounds,
2303         mapped_index_base::build_name_components,
2304         dw2_expand_symtabs_matching_symbol): Likewise.
2305         (class mock_mapped_index) <symbol_name_at>: Likewise.
2306         (check_match): Likewise.
2307         (check_find_bounds_finds): Likewise.
2308         (test_mapped_index_find_name_component_bounds): Update.
2309         (CHECK_MATCH): Update.
2310         (dw2_expand_symtabs_matching): Update.
2311         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
2312         per_objfile parameter.
2313         <find_vec_in_debug_names>: Likewise.
2314         <m_per_objfile>: New field.
2315         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
2316         parameter.
2317         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
2318         (dw2_debug_names_iterator::next): Update.
2319         (dw2_debug_names_lookup_symbol): Update.
2320         (dw2_debug_names_expand_symtabs_for_function): Update.
2321         (dw2_debug_names_map_matching_symbols): Update.
2322         (dw2_debug_names_expand_symtabs_matching): Update.
2323         (dwarf2_read_debug_names): Update.
2324
2325 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2326
2327         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
2328         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
2329         move to dwarf2_per_objfile.
2330         <read_in_chain>: Remove.
2331         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
2332         remove_all_cus, age_comp_units>: New methods.
2333         <m_dwarf2_cus>: New member.
2334         (struct dwarf2_per_cu_data) <cu>: Remove.
2335         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
2336         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
2337         moved to methods of dwarf2_per_objfile.
2338         (dwarf2_clear_marks): Remove.
2339         (dwarf2_queue_item::~dwarf2_queue_item): Update.
2340         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
2341         (dwarf2_per_bfd::free_cached_comp_units): Remove.
2342         (dwarf2_per_objfile::remove_all_cus): New.
2343         (class free_cached_comp_units) <~free_cached_comp_units>:
2344         Update.
2345         (load_cu): Update.
2346         (dw2_do_instantiate_symtab): Adjust.
2347         (fill_in_sig_entry_from_dwo_entry): Adjust.
2348         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2349         (cutu_reader::cutu_reader): Likewise.
2350         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
2351         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
2352         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
2353         and dwarf2_per_objfile::age_comp_units.
2354         (load_partial_comp_unit): Update.
2355         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
2356         (process_queue): Likewise.
2357         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
2358         backlink.
2359         (dwarf2_read_addr_index): Likewise.
2360         (follow_die_offset): Likewise.
2361         (dwarf2_fetch_die_loc_sect_off): Likewise.
2362         (dwarf2_fetch_constant_bytes): Likewise.
2363         (dwarf2_fetch_die_type_sect_off): Likewise.
2364         (follow_die_sig_1): Likewise.
2365         (load_full_type_unit): Likewise.
2366         (read_signatured_type): Likewise.
2367         (dwarf2_cu::dwarf2_cu): Don't set cu field.
2368         (dwarf2_cu::~dwarf2_cu): Remove.
2369         (dwarf2_per_objfile::get_cu): New.
2370         (dwarf2_per_objfile::set_cu): New.
2371         (age_cached_comp_units): Rename to...
2372         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
2373         to std::unordered_map.
2374         (free_one_cached_comp_unit): Rename to...
2375         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
2376         to std::unordered_map.
2377         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
2378         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
2379         a dwarf2_per_objfile in data.
2380         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
2381         (dwarf2_clear_marks): Remove.
2382
2383 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2384
2385         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
2386         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
2387         (init_tu_and_read_dwo_dies): Likewise.
2388         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
2389         (cutu_reader::cutu_reader): Likewise.
2390         (load_partial_comp_unit): Likewise.
2391         (process_psymtab_comp_unit): Update.
2392         (build_type_psymtabs_1): Update.
2393         (process_skeletonless_type_unit): Update.
2394         (load_full_comp_unit): Update.
2395         (find_partial_die): Update.
2396         (dwarf2_read_addr_index): Update.
2397         (read_signatured_type): Update.
2398
2399 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2400
2401         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
2402         m_header_read_in>: New fields.
2403         <get_header>: New method.
2404         * dwarf2/read.c (per_cu_header_read_in): Remove.
2405         (dwarf2_per_cu_data::get_header): New.
2406         (dwarf2_per_cu_data::addr_size): Update.
2407         (dwarf2_per_cu_data::offset_size): Update.
2408         (dwarf2_per_cu_data::ref_addr_size): Update.
2409
2410 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2411
2412         * dwarf2/read.c (load_cu): Return dwarf2_cu.
2413         (dw2_do_instantiate_symtab): Update.
2414         (queue_and_load_all_dwo_tus): Change parameter from
2415         dwarf2_per_cu_data to dwarf2_cu.
2416         (dwarf2_fetch_die_loc_sect_off): Update.
2417         (dwarf2_fetch_constant_bytes): Update.
2418         (dwarf2_fetch_die_type_sect_off): Update.
2419
2420 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2421
2422         * dwarf2/read.c (process_full_comp_unit,
2423         process_full_type_unit): Remove per_cu, per_objfile paramters.
2424         Add dwarf2_cu parameter.
2425         (process_queue): Update.
2426
2427 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2428
2429         * dwarf2/read.c (create_cu_from_index_list): Replace
2430         dwarf2_per_objfile parameter with dwarf2_per_bfd.
2431         (create_cus_from_index_list): Likewise.
2432         (create_cus_from_index): Likewise.
2433         (create_signatured_type_table_from_index): Likewise.
2434         (create_cus_from_debug_names_list): Likewise.
2435         (create_cus_from_debug_names): Likewise.
2436         (dwarf2_read_gdb_index): Update.
2437         (dwarf2_read_debug_names): Update.
2438
2439 2020-05-27  Tom Tromey  <tom@tromey.com>
2440             Simon Marchi  <simon.marchi@efficios.com>
2441
2442         * dwarf2/read.h (struct dwarf2_per_objfile)
2443         <get_type_for_signatured_type, set_type_for_signatured_type>:
2444         New methods.
2445         <m_type_map>: New member.
2446         (struct signatured_type) <type>: Remove.
2447         * dwarf2/read.c
2448         (dwarf2_per_objfile::get_type_for_signatured_type,
2449         dwarf2_per_objfile::set_type_for_signatured_type): New.
2450         (get_signatured_type): Use new methods.
2451
2452 2020-05-27  Tom Tromey  <tom@tromey.com>
2453             Simon Marchi  <simon.marchi@efficios.com>
2454
2455         * dwarf2/read.h (struct type_unit_group_unshareable): New.
2456         (struct dwarf2_per_objfile) <type_units>: New member.
2457         <get_type_unit_group_unshareable>: New method.
2458         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
2459         num_symtabs, symtabs>: Remove; move to
2460         type_unit_group_unshareable.
2461         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
2462         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
2463         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
2464
2465 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2466
2467         * dwarf2/read.h (struct dwarf2_per_cu_data):
2468         <dwarf2_per_objfile>: Remove.
2469         * dwarf2/read.c (create_cu_from_index_list): Don't assign
2470         dwarf2_per_objfile.
2471         (create_signatured_type_table_from_index): Likewise.
2472         (create_signatured_type_table_from_debug_names): Likewise.
2473         (create_debug_type_hash_table): Likewise.
2474         (fill_in_sig_entry_from_dwo_entry): Likewise.
2475         (create_type_unit_group): Likewise.
2476         (read_comp_units_from_section): Likewise.
2477         (create_cus_hash_table): Likewise.
2478
2479 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2480
2481         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
2482         dwarf2_per_cu_data::dwarf2_per_objfile.
2483         (compute_compunit_symtab_includes): Likewise.
2484         (dwarf2_cu::start_symtab): Likewise.
2485
2486 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2487
2488         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
2489         parameter.
2490         * dwarf2/read.c (get_die_type_at_offset): Likewise.
2491         (read_namespace_alias): Update.
2492         (lookup_die_type): Update.
2493         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
2494         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
2495         Update.
2496         (disassemble_dwarf_expression): Update.
2497
2498 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2499
2500         * dwarf2/read.h (struct dwarf2_queue_item): Add
2501         dwarf2_per_objfile parameter, assign new parameter.
2502         <per_objfile>: New field.
2503         * dwarf2/read.c (free_one_cached_comp_unit): Add
2504         dwarf2_per_objfile parameter.
2505         (queue_comp_unit): Likewise.
2506         (dw2_do_instantiate_symtab): Update.
2507         (process_psymtab_comp_unit): Update.
2508         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
2509         (process_imported_unit_die): Update.
2510         (queue_and_load_dwo_tu): Update.
2511         (follow_die_offset): Update.
2512         (follow_die_sig_1): Update.
2513
2514 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2515
2516         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
2517         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
2518         (read_call_site_scope): Assign per_objfile.
2519         (dwarf2_per_cu_data::objfile): Remove.
2520         * gdbtypes.h (struct call_site) <per_objfile>: New member.
2521         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
2522         dwarf2_per_objfile parameter.
2523         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
2524         dwarf2_per_objfile parameter.
2525         (dwarf_expr_reg_to_entry_parameter): Add output
2526         dwarf2_per_objfile parameter.
2527         (locexpr_get_frame_base): Update.
2528         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
2529         <push_dwarf_reg_entry_value>: Update.
2530         <call_site_to_target_addr>: Update.
2531         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
2532         parameter.
2533         (value_of_dwarf_reg_entry): Update.
2534         (rw_pieced_value): Update.
2535         (indirect_synthetic_pointer): Update.
2536         (dwarf2_evaluate_property): Update.
2537         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
2538         parameter.
2539         (locexpr_read_variable): Update.
2540         (locexpr_get_symbol_read_needs): Update.
2541         (loclist_read_variable): Update.
2542
2543 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2544
2545         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2546         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2547         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2548         parameter.
2549         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2550         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2551         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2552         parameter.
2553         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
2554         sect_variable_value): Add dwarf2_per_objfile parameter.
2555         (class dwarf_evaluate_loc_desc) <dwarf_call,
2556         dwarf_variable_value>: Update.
2557         (fetch_const_value_from_synthetic_pointer): Add
2558         dwarf2_per_objfile parameter.
2559         (fetch_const_value_from_synthetic_pointer): Update.
2560         (coerced_pieced_ref): Update.
2561         (class symbol_needs_eval_context) <dwarf_call,
2562         dwarf_variable_value>: Update.
2563         (dwarf2_compile_expr_to_ax): Update.
2564
2565 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2566
2567         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
2568         parameter.
2569         (dwarf2_evaluate_loc_desc_full): Update.
2570
2571 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2572
2573         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
2574         parameter.
2575         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
2576         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
2577         dwarf2_per_objfile parameter.
2578         (decode_debug_loc_dwo_addresses): Likewise.
2579         (dwarf2_find_location_expression): Update.
2580         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
2581         (locexpr_describe_location_piece): Add dwarf2_per_objfile
2582         parameter.
2583         (disassemble_dwarf_expression): Add dwarf2_per_objfile
2584         parameter.
2585         (locexpr_describe_location_1): Likewise.
2586         (locexpr_describe_location): Update.
2587
2588 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2589
2590         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
2591         Remove.
2592         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
2593         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
2594         (dwarf2_compile_property_to_c): Update.
2595         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
2596         use text offset from objfile.
2597         (locexpr_tracepoint_var_ref): Update.
2598         (locexpr_generate_c_location): Update.
2599         (loclist_describe_location): Update.
2600         (loclist_tracepoint_var_ref): Update.
2601         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
2602         dwarf2_per_objfile parameter.
2603         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
2604         use text offset from objfile.
2605         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
2606
2607 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2608
2609         * dwarf2/expr.h (struct dwarf_expr_context)
2610         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
2611         <offset>: Remove.
2612         <per_objfile>: New member.
2613         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
2614         dwarf2_per_objfile parameter.  Don't set offset, set
2615         per_objfile.
2616         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
2617         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
2618         a dwarf2_per_objfile object instead of an offset.
2619         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
2620         constructor.
2621         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
2622         to dwarf2_expr_executor constructor.  Don't set offset.
2623         (dwarf2_fetch_cfa_info): Update.
2624         (struct dwarf2_frame_cache) <text_offset>: Remove.
2625         <per_objfile>: New field.
2626         (dwarf2_frame_cache): Update.
2627         (dwarf2_frame_prev_register): Update.
2628         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2629         <dwarf_evaluate_loc_desc>: Add constructor.
2630         (dwarf2_evaluate_loc_desc_full): Update.
2631         (dwarf2_locexpr_baton_eval): Update.
2632         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
2633         Add constructor.
2634         (dwarf2_loc_desc_get_symbol_read_needs): Update.
2635
2636 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2637
2638         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
2639         addr_sized_int_type>: Move to dwarf2_cu.
2640         <int_type>: Move to dwarf2_per_objfile.
2641         (struct dwarf2_per_objfile) <int_type>: Move here.
2642         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
2643         addr_sized_int_type>: Move here.
2644         (read_func_scope): Update.
2645         (read_array_type): Update.
2646         (read_tag_string_type): Update.
2647         (attr_to_dynamic_prop): Update.
2648         (dwarf2_per_cu_data::int_type): Rename to...
2649         (dwarf2_per_objfile::int_type): ... this.
2650         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
2651         (dwarf2_cu::addr_sized_int_type): ... this.
2652         (read_subrange_type): Update.
2653         (dwarf2_per_cu_data::addr_type): Rename to...
2654         (dwarf2_cu::addr_type): ... this.
2655         (set_die_type): Update.
2656
2657 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2658
2659         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
2660         data through per_cu->cu.
2661
2662 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2663
2664         * dwarf2/read.c (lookup_dwo_comp_unit): Change
2665         dwarf2_per_cu_data parameter fo dwarf2_cu.
2666         (lookup_dwo_type_unit): Likewise.
2667         (read_cutu_die_from_dwo): Likewise.
2668         (lookup_dwo_unit): Likewise.
2669         (open_and_init_dwo_file): Likewise.
2670         (lookup_dwo_cutu): Likewise.
2671         (lookup_dwo_comp_unit): Likewise.
2672         (lookup_dwo_type_unit): Likewise.
2673         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2674         (cutu_reader::cutu_reader): Update.
2675
2676 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2677
2678         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
2679         parameter.
2680         (process_full_type_unit): Likewise.
2681         (process_queue): Update.
2682
2683 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2684
2685         * dwarf2/read.c (recursively_compute_inclusions): Add
2686         dwarf2_per_objfile parameter.
2687         (compute_compunit_symtab_includes): Likewise.
2688         (process_cu_includes): Update.
2689
2690 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2691
2692         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
2693         parameter.
2694         (create_type_unit_group): Update.
2695         (process_psymtab_comp_unit_reader): Update.
2696         (build_type_psymtabs_reader): Update.
2697
2698 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2699
2700         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
2701         object through m_this_cu->cu.
2702
2703 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2704
2705         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
2706         the info parameter.
2707         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
2708
2709 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2710
2711         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
2712         per_objfile parameter.
2713         (load_full_type_unit): Add per_objfile parameter.
2714         (read_signatured_type): Likewise.
2715         (load_full_comp_unit): Likewise.
2716         (load_cu): Likewise.
2717         (dw2_do_instantiate_symtab): Likewise.
2718         (dw2_get_file_names): Likewise.
2719         (dw2_map_symtabs_matching_filename): Update.
2720         (dw_expand_symtabs_matching_file_matcher): Update.
2721         (dw2_map_symbol_filenames): Update.
2722         (process_psymtab_comp_unit): Add per_objfile parameter.
2723         (build_type_psymtabs_1): Update.
2724         (process_skeletonless_type_unit): Update.
2725         (dwarf2_build_psymtabs_hard): Update.
2726         (load_partial_comp_unit): Add per_objfile parameter.
2727         (scan_partial_symbols): Update.
2728         (load_full_comp_unit): Add per_objfile parameter.
2729         (process_imported_unit_die): Update.
2730         (create_cus_hash_table): Update.
2731         (find_partial_die): Update.
2732         (dwarf2_read_addr_index): Update.
2733         (follow_die_offset): Update.
2734         (dwarf2_fetch_die_loc_sect_off): Update.
2735         (dwarf2_fetch_constant_bytes): Update.
2736         (dwarf2_fetch_die_type_sect_off): Update.
2737         (follow_die_sig_1): Update.
2738         (load_full_type_unit): Add per_objfile parameter.
2739         (read_signatured_type): Likewise.
2740
2741 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2742
2743         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
2744         of objfile_name.
2745
2746 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2747
2748         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
2749         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2750         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
2751         field.
2752         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2753         (create_cus_from_index): Update.
2754         (dwarf2_read_gdb_index): Update.
2755         (create_cus_from_debug_names): Update.
2756         (dwarf2_read_debug_names): Update.
2757         (get_abbrev_section_for_cu): Update.
2758         (create_all_comp_units): Update.
2759         (read_attribute_value): Update.
2760         (get_debug_line_section): Update.
2761         * dwarf2/index-cache.c (index_cache::store): Update.
2762         * dwarf2/index-write.c (save_gdb_index_command): Update.
2763         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
2764
2765 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2766
2767         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
2768         member.
2769         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
2770         dwarf2_per_cu_data::per_bfd.
2771         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
2772         (create_type_unit_group): Likewise.
2773         (queue_comp_unit): Remove reference to
2774         per_cu->dwarf2_per_objfile.
2775         (maybe_queue_comp_unit): Likewise.
2776         (fill_in_sig_entry_from_dwo_entry): Assign new field.
2777         (create_cus_hash_table): Assign new field.
2778
2779 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2780
2781         * dwarf2/read.c: Replace
2782         dwarf2_cu->per_cu->dwarf2_per_objfile references with
2783         dwarf2_cu->per_objfile throughout.
2784
2785 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2786
2787         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
2788         parameter, don't use per_cu->dwarf2_per_objfile.
2789         (dw2_instantiate_symtab): Likewise.
2790         (dw2_find_last_source_symtab): Update.
2791         (dw2_map_expand_apply): Update.
2792         (dw2_lookup_symbol): Update.
2793         (dw2_expand_symtabs_for_function): Update.
2794         (dw2_expand_all_symtabs): Update.
2795         (dw2_expand_symtabs_with_fullname): Update.
2796         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
2797         don't use per_cu->dwarf2_per_objfile.
2798         (dw2_expand_marked_cus): Update.
2799         (dw2_find_pc_sect_compunit_symtab): Update.
2800         (dw2_debug_names_lookup_symbol): Update.
2801         (dw2_debug_names_expand_symtabs_for_function): Update.
2802         (dw2_debug_names_map_matching_symbols): Update.
2803         (dwarf2_psymtab::expand_psymtab): Update.
2804
2805 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2806
2807         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
2808         <per_objfile>: New member.
2809         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
2810         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
2811         call to dwarf2_cu.
2812         (cutu_reader::cutu_reader): Update.
2813         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
2814
2815 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2816
2817         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
2818         struct dwarf2_per_objfile.
2819         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
2820         dwarf2_per_bfd.
2821         * dwarf2/read.c (set_die_type): Update.
2822         (get_die_type_at_offset): Update.
2823
2824 2020-05-27  Tom Tromey  <tom@tromey.com>
2825             Simon Marchi  <simon.marchi@efficios.com>
2826
2827         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
2828         method.
2829         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
2830         get_symtab, set_symtab>: New methods.
2831         <m_symtabs>: New field.
2832         (struct dwarf2_psymtab): Derive from partial_symtab.
2833         <readin_p, get_compunit_symtab>: Declare methods.
2834         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
2835         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
2836         New methods.
2837         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
2838         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
2839         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
2840         (dw2_symtab_iter_next, dw2_print_stats)
2841         (dw2_expand_symtabs_with_fullname)
2842         (dw2_expand_symtabs_matching_one)
2843         (dw_expand_symtabs_matching_file_matcher)
2844         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
2845         (dw2_debug_names_iterator::next)
2846         (dw2_debug_names_map_matching_symbols)
2847         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
2848         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
2849         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
2850         New methods.
2851         (get_compunit_symtab, process_full_comp_unit)
2852         (process_full_type_unit): Update.
2853         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
2854
2855 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2856
2857         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
2858         then introduce a new dwarf2_per_objfile type.
2859         <read_line_string>: Move to the new dwarf2_per_objfile type.
2860         <objfile>: Likewise.
2861         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
2862         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
2863         dwarf2_per_objfile->per_bfd.
2864         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
2865         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
2866         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
2867         (dwarf2_per_bfd::free_cached_comp_units): ... this.
2868         (dwarf2_has_info): Allocate dwarf2_per_bfd.
2869         (dwarf2_per_objfile::locate_sections): Rename to...
2870         (dwarf2_per_bfd::locate_sections): ... this.
2871         (dwarf2_per_objfile::get_cutu): Rename to...
2872         (dwarf2_per_bfd::get_cutu): ... this.
2873         (dwarf2_per_objfile::get_cu): Rename to...
2874         (dwarf2_per_bfd::get_cu): ... this.
2875         (dwarf2_per_objfile::get_tu): Rename to...
2876         (dwarf2_per_bfd::get_tu): ... this.
2877         (dwarf2_per_objfile::allocate_per_cu): Rename to...
2878         (dwarf2_per_bfd::allocate_per_cu): ... this.
2879         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
2880         (dwarf2_per_bfd::allocate_signatured_type): ... this.
2881         (get_gdb_index_contents_ftype): Change parameter from
2882         dwarf2_per_objfile to dwarf2_per_bfd.
2883         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
2884         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
2885
2886 2020-05-27  Tom Tromey  <tom@tromey.com>
2887             Simon Marchi  <simon.marchi@efficios.com>
2888
2889         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
2890         (allocate_piece_closure): Set "per_objfile" member.
2891         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
2892         (locexpr_describe_location, loclist_describe_location): Use new
2893         member.
2894         * dwarf2/read.c (read_call_site_scope)
2895         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
2896         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
2897         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
2898         handle_data_member_location): Set per_objfile member.
2899         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
2900         member.
2901         (struct dwarf2_loclist_baton) <per_objfile>: New member.
2902
2903 2020-05-27  Tom Tromey  <tom@tromey.com>
2904
2905         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
2906         allocate_signatured_type>: Declare new methods.
2907         <m_num_psymtabs>: New member.
2908         (struct dwarf2_per_cu_data) <index>: New member.
2909         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
2910         (dwarf2_per_objfile::allocate_signatured_type): New methods.
2911         (create_cu_from_index_list): Use allocate_per_cu.
2912         (create_signatured_type_table_from_index)
2913         (create_signatured_type_table_from_debug_names)
2914         (create_debug_type_hash_table, add_type_unit)
2915         (read_comp_units_from_section): Use allocate_signatured_type.
2916
2917 2020-05-27  Tom Tromey  <tom@tromey.com>
2918
2919         * psymtab.c (partial_map_expand_apply)
2920         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2921         (psym_lookup_global_symbol_language)
2922         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2923         (psym_print_stats, psym_expand_symtabs_for_function)
2924         (psym_map_symbol_filenames, psym_map_matching_symbols)
2925         (psym_expand_symtabs_matching)
2926         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2927         (maintenance_check_psymtabs): Update.
2928         * psympriv.h (struct partial_symtab) <readin_p,
2929         get_compunit_symtab>: Add objfile parameter.
2930         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
2931         Likewise.
2932         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
2933         get_compunit_symtab>: Likewise.
2934         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
2935
2936 2020-05-27  Tom Tromey  <tom@tromey.com>
2937
2938         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
2939         member.
2940         * dwarf2/read.c (delete_file_name_entry): Fix comment.
2941         (create_cu_from_index_list)
2942         (create_signatured_type_table_from_index)
2943         (create_signatured_type_table_from_debug_names)
2944         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
2945         (dwarf2_create_include_psymtab)
2946         (create_debug_type_hash_table, add_type_unit)
2947         (create_type_unit_group, read_comp_units_from_section)
2948         (dwarf2_compute_name, create_cus_hash_table)
2949         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2950         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
2951         obstack.
2952         (dw2_get_real_path): Likewise.  Change argument to
2953         dwarf2_per_objfile.
2954
2955 2020-05-27  Luis Machado  <luis.machado@linaro.org>
2956
2957         PR tdep/26000
2958         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
2959         for ldrd (immediate).
2960
2961 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2962
2963         * command.h: Add comment giving the name of class_tui.
2964         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
2965         create the fake command for the help for class_tui.
2966
2967 2020-05-26  Tom Tromey  <tromey@adacore.com>
2968
2969         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
2970         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2971         (val_atr): New function.
2972         (value_val_atr): Use it.
2973         * ada-valprint.c (print_optional_low_bound): Change low bound
2974         handling for enums.
2975         (val_print_packed_array_elements): Don't call discrete_position.
2976         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2977         discrete_position for enum types.
2978         * language.c (default_print_array_index): Change type.
2979         * language.h (struct language_defn) <la_print_array_index>: Add
2980         index_type parameter, change type of index_value.
2981         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2982         (default_print_array_index): Update.
2983         * valprint.c (maybe_print_array_index): Don't call
2984         value_from_longest.  Update.
2985         (value_print_array_elements): Don't call discrete_position.
2986
2987 2020-05-26  Tom Tromey  <tromey@adacore.com>
2988
2989         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2990         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2991
2992 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2993
2994         PR gdb/13519
2995         * avr-tdep.c (avr_integer_to_address): Return data or code
2996         address accordingly to the second 'type' argument of the
2997         function.
2998
2999 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
3000
3001         * infcmd.c, inferior.h: (construct_inferior_arguments):
3002         Moved function from here to gdbsupport/common-inferior.{h,cc}
3003
3004 2020-05-23  Tom Tromey  <tom@tromey.com>
3005
3006         Revert commit eca1f90c:
3007         * NEWS: Remove entry for completion styling.
3008         * completer.c (_rl_completion_prefix_display_length): Move
3009         declaration later.
3010         (gdb_fnprint): Revert.
3011         (gdb_display_match_list_1): Likewise.
3012         * cli/cli-style.c (completion_prefix_style)
3013         (completion_difference_style, completion_suffix_style): Remove.
3014         (_initialize_cli_style): Revert.
3015         * cli/cli-style.h (completion_prefix_style)
3016         (completion_difference_style, completion_suffix_style): Don't
3017         declare.
3018
3019 2020-05-24  Pedro Alves  <palves@redhat.com>
3020
3021         * symtab.c (completion_list_add_name): Return boolean indication
3022         of whether the symbol matched.
3023         (completion_list_add_symbol): Don't try to remove C++ aliases if
3024         the symbol didn't match in the first place.
3025         * symtab.h (completion_list_add_name): Return bool.
3026
3027 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
3028
3029         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
3030         type::field.
3031
3032 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
3033
3034         GDB 9.2 released.
3035
3036 2020-05-23  Tom Tromey  <tom@tromey.com>
3037
3038         * NEWS: Add entry for completion styling.
3039         * completer.c (_rl_completion_prefix_display_length): Move
3040         declaration earlier.
3041         (gdb_fnprint): Use completion_style.
3042         (gdb_display_match_list_1): Likewise.
3043         * cli/cli-style.c (completion_prefix_style)
3044         (completion_difference_style, completion_suffix_style): New
3045         globals.
3046         (_initialize_cli_style): Register new globals.
3047         * cli/cli-style.h (completion_prefix_style)
3048         (completion_difference_style, completion_suffix_style): Declare.
3049
3050 2020-05-23  Pedro Alves  <palves@redhat.com>
3051
3052         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
3053         (parse_escape): Use ISDIGIT instead of isdigit.
3054         (puts_debug): Use gdb_isprint instead of isprint.
3055         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
3056         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
3057         ISSPACE instead of isspace.
3058         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
3059         instead of isspace.
3060         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
3061         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
3062         instead of isxdigit and ISDIGIT instead of isdigit.
3063
3064 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3065
3066         * gdbtypes.h (struct type) <field>: New method.
3067         (TYPE_FIELDS): Remove, replace all uses with either type::fields
3068         or type::field.
3069
3070 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3071
3072         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
3073         (TYPE_FIELDS): Use type::fields.  Change all call sites that
3074         modify the propery to use type::set_fields instead.
3075
3076 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3077
3078         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
3079         type::num_fields instead.
3080
3081 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3082
3083         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
3084         methods.
3085         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
3086         that modify the number of fields to use type::set_num_fields
3087         instead.
3088
3089 2020-05-22  Tom Tromey  <tromey@adacore.com>
3090
3091         * compile/compile-object-load.h (munmap_list_free): Don't
3092         declare.
3093
3094 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3095
3096         * annotate.c (annotate_source_line): Update return type, add call
3097         to update current symtab and line.
3098         * annotate.h (annotate_source_line): Update return type, and
3099         extend header comment.
3100         * source.c (info_line_command): Check annotation_level before
3101         calling annotate_source_line.
3102         * stack.c (print_frame_info): If calling annotate_source_line
3103         returns true, then don't print any other source line information.
3104
3105 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3106
3107         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
3108
3109 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3110
3111         * coffread.c (patch_type): Remove NULL check before xfree.
3112         * corefile.c (set_gnutarget): Likewise.
3113         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
3114         * exec.c (build_section_table): Likewise.
3115         * remote.c (remote_target::pass_signals): Likewise.
3116         * utils.c (n_spaces): Likewise.
3117         * cli/cli-script.c (document_command): Likewise.
3118         * i386-windows-tdep.c (core_process_module_section): Likewise.
3119         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
3120
3121 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
3122
3123         * symfile.c (reread_symbols): Clear objfile's section_offsets
3124         vector and section indices, re-compute them by calling
3125         sym_offsets.
3126
3127 2020-05-20  Tom Tromey  <tromey@adacore.com>
3128
3129         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
3130         (desc_one_bound, desc_index_type): Compute field name.
3131
3132 2020-05-20  Tom de Vries  <tdevries@suse.de>
3133
3134         PR symtab/25833
3135         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
3136
3137 2020-05-20  Alan Modra  <amodra@gmail.com>
3138
3139         PR 25993
3140         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
3141         bfd_set_filename.
3142         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
3143         passed to bfd_set_filename.
3144         * symfile-mem.c (add_vsyscall_page): Likewise for string
3145         passed to symbol_file_add_from_memory.
3146         (symbol_file_add_from_memory): Make name param a const char* and
3147         don't strdup.
3148
3149 2020-05-20  Alan Modra  <amodra@gmail.com>
3150
3151         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
3152         rather than accessing bfd->filename directly.
3153         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
3154         and use bfd_section_name.
3155         * dwarf2/frame.c (decode_frame_entry): Likewise.
3156         * exec.c (exec_set_section_address): Likewise.
3157         * solib-aix.c (solib_aix_bfd_open): Likewise.
3158         * stap-probe.c (get_stap_base_address): Likewise.
3159         * symfile.c (reread_symbols): Likewise.
3160
3161 2020-05-19  Tom Tromey  <tromey@adacore.com>
3162
3163         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
3164
3165 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3166
3167         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
3168
3169 2020-05-19  Pedro Alves  <palves@redhat.com>
3170
3171         * NEWS (set exec-file-mismatch): Adjust entry.
3172         * exec.c: Include "build-id.h".
3173         (validate_exec_file): Try to match build IDs instead of filenames.
3174         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
3175         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
3176         and pass down 'warn_if_slow'.
3177         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
3178         gdb_bfd_open_closure to pass it down.
3179         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
3180
3181 2020-05-19  Pedro Alves  <palves@redhat.com>
3182
3183         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
3184         * target.c (target_fileio_open_1): Rename to target_fileio_open
3185         and make extern.  Use bool.
3186         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
3187         (target_fileio_read_alloc_1): Adjust.
3188         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
3189         (target_fileio_open_warn_if_slow): Delete declaration.
3190
3191 2020-05-19  Pedro Alves  <palves@redhat.com>
3192
3193         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
3194         Adjust all callers.
3195
3196 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
3197
3198         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
3199         whether disp is negative.
3200
3201 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3202
3203         * symfile.h (struct symfile_segment_data)
3204         <~symfile_segment_data>: Remove.
3205         <segment_info>: Change to std::vector.
3206         * symfile.c (default_symfile_segments): Update.
3207         * elfread.c (elf_symfile_segments): Update.
3208
3209 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3210
3211         * symfile.h (struct symfile_segment_data) <struct segment>: New.
3212         <segments>: New.
3213         <segment_bases, segment_sizes>: Remove.
3214         * symfile.c (default_symfile_segments): Update.
3215         * elfread.c (elf_symfile_segments): Update.
3216         * remote.c (remote_target::get_offsets): Update.
3217         * solib-target.c (solib_target_relocate_section_addresses):
3218         Update.
3219
3220 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3221
3222         * symfile.h (struct symfile_segment_data): Initialize fields.
3223         <~symfile_segment_data>: Add.
3224         (symfile_segment_data_up): New.
3225         (struct sym_fns) <sym_segments>: Return a
3226         symfile_segment_data_up.
3227         (default_symfile_segments): Return a symfile_segment_data_up.
3228         (free_symfile_segment_data): Remove.
3229         (get_symfile_segment_data): Return a symfile_segment_data_up.
3230         * symfile.c (default_symfile_segments): Likewise.
3231         (get_symfile_segment_data): Likewise.
3232         (free_symfile_segment_data): Remove.
3233         (symfile_find_segment_sections): Update.
3234         * elfread.c (elf_symfile_segments): Return a
3235         symfile_segment_data_up.
3236         * remote.c (remote_target::get_offsets): Update.
3237         * solib-target.c (solib_target_relocate_section_addresses):
3238         Update.
3239         * symfile-debug.c (debug_sym_segments): Return a
3240         symfile_segment_data_up.
3241
3242 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3243
3244         PR build/25981
3245         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
3246         Hardcode register numbers.
3247
3248         PR build/25981
3249         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
3250         procfs_find_LDT_entry): Remove.
3251         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
3252         procfs_find_LDT_entry): Remove.
3253         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
3254         Remove.
3255
3256 2020-05-17  Pedro Alves  <palves@redhat.com>
3257             Andrew Burgess  <andrew.burgess@embecosm.com>
3258             Keno Fischer  <keno@juliacomputing.com>
3259
3260         PR gdb/25741
3261         * breakpoint.c (build_target_condition_list): Update comments.
3262         (build_target_command_list): Update comments and skip matching
3263         locations.
3264         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
3265         a separate function.  Simplify "set breakpoint auto-hw off"
3266         handling.
3267         (insert_breakpoints): Update comment.
3268         (tracepoint_locations_match): New parameter.  For breakpoints,
3269         compare location types too, if the caller wants to.
3270         (handle_automatic_hardware_breakpoints): New functions.
3271         (bp_location_is_less_than): Also sort by location type and
3272         hardware breakpoint length.
3273         (update_global_location_list): Handle "set breakpoint auto-hw on"
3274         here.
3275         (update_breakpoint_locations): Ask breakpoint_locations_match to
3276         ignore location types.
3277
3278 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3279
3280         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
3281         type::name instead.
3282
3283 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3284
3285         * gdbtypes.h (struct type) <name, set_name>: New methods.
3286         (TYPE_CODE): Use type::name.  Change all call sites used to set
3287         the name to use type::set_name instead.
3288
3289 2020-05-16  Tom Tromey  <tom@tromey.com>
3290
3291         * top.c (quit_force): Update.
3292         * infrun.c (handle_no_resumed): Update.
3293         * top.h (all_uis): New function.
3294         (ALL_UIS): Remove.
3295
3296 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3297
3298         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
3299
3300 2020-05-16  Pedro Alves  <palves@redhat.com>
3301
3302         * ia64-linux-nat.c
3303         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
3304         Declare method.
3305         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
3306
3307 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
3308
3309         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
3310         (sparc64_adi_info): Likewise.
3311
3312 2020-05-15  Tom Tromey  <tom@tromey.com>
3313
3314         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
3315         block_objfile.
3316         (lookup_objfile_from_block): Remove.
3317         (lookup_symbol_in_block, lookup_symbol_in_static_block)
3318         (lookup_global_symbol): Use block_objfile.
3319         * symtab.h (lookup_objfile_from_block): Don't declare.
3320         * printcmd.c (clear_dangling_display_expressions): Use
3321         block_objfile.
3322         * parse.c (operator_check_standard): Use block_objfile.
3323
3324 2020-05-15  Tom Tromey  <tom@tromey.com>
3325
3326         * language.c (language_alloc_type_symbol): Set
3327         SYMBOL_SECTION.
3328         * symtab.c (initialize_objfile_symbol): Remove.
3329         (allocate_symbol): Remove.
3330         (allocate_template_symbol): Remove.
3331         * dwarf2/read.c (fixup_go_packaging): Use "new".
3332         (new_symbol): Use "new".
3333         (read_variable): Don't call initialize_objfile_symbol.  Use
3334         "new".
3335         (read_func_scope): Use "new".
3336         * xcoffread.c (process_xcoff_symbol): Don't call
3337         initialize_objfile_symbol.
3338         (SYMBOL_DUP): Remove.
3339         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
3340         "new".
3341         * symtab.h (allocate_symbol, initialize_objfile_symbol)
3342         (allocate_template_symbol): Don't declare.
3343         (struct symbol): Add copy constructor.  Change defaults.
3344         * jit.c (finalize_symtab): Use "new".
3345         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
3346         Use "new".
3347         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
3348         (common_block_end): Use "new".
3349         * mdebugread.c (parse_symbol): Use "new".
3350         (new_symbol): Likewise.
3351
3352 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3353
3354         * NEWS: Mention changes to help and apropos.
3355
3356 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3357
3358         * command.h (enum command_class): Improve comments, document
3359         that class_alias is for user-defined aliases, give the class
3360         name for each class, remove unused class_xdb.
3361         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
3362         * breakpoint.c (_initialize_breakpoint): Replace class_alias
3363         by a precise class.
3364         * infcmd.c (_initialize_infcmd): Likewise.
3365         * reverse.c (_initialize_reverse): Likewise.
3366         * stack.c (_initialize_stack): Likewise.
3367         * symfile.c (_initialize_symfile): Likewise.
3368         * tracepoint.c (_initialize_tracepoint): Likewise.
3369
3370 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3371
3372         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
3373         when their aliased command is traversed.
3374         (help_cmd): Add fput_command_names_styled call to
3375         output command name and aliases when command has an alias.
3376
3377 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3378
3379         * cli/cli-decode.h (help_cmd_list): Remove declaration.
3380         * cli/cli-decode.c (help_cmd_list): Declare as static,
3381         remove prefix argument, use bool for recurse arg, rework to show the aliases of
3382         a command together with the command.
3383         (fput_command_name_styled, fput_command_names_styled): New functions.
3384         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
3385         fput_command_name_styled.
3386         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
3387         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
3388
3389 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3390
3391         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
3392         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
3393         * command.h (cmd_show_list): Likewise.
3394         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
3395         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
3396
3397 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3398
3399         * unittests/command-def-selftests.c (traverse_command_structure):
3400         Verify all commands of a list have the same prefix command and
3401         that only the top cmdlist commands have a null prefix.
3402
3403 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3404
3405         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
3406         as prefix, not one of its aliases.
3407         (set_cmd_prefix): Remove.
3408         (do_add_cmd): Centralize the setting of the prefix of a command, when
3409         command is defined after its full chain of prefix commands.
3410         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
3411         (add_setshow_cmd_full): Likewise.
3412         (update_prefix_field_of_prefixed_commands): New function.
3413         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
3414         update_prefix_field_of_prefixed_commands.
3415         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
3416         addresses of remote_set_cmdlist and remote_show_cmdlist given
3417         as argument, not the address of an argument.
3418         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
3419         * gdb/remote.c (_initialize_remote): Likewise.
3420
3421 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3422
3423         * cli/cli-cmds.c (alias_command): Check for an existing alias
3424         using lookup_cmd_composition, as valid_command_p is too strict
3425         and forbids aliases that are the prefix of an existing alias
3426         or command.
3427         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
3428         command is properly recognised as a valid command.
3429
3430 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3431
3432         * unittests/help-doc-selftests.c: Rename to
3433         unittests/command-def-selftests.c
3434         * unittests/command-def-selftests.c (help_doc_tests): Update some
3435         comments.
3436         (command_structure_tests, traverse_command_structure): New namespace
3437         and function.
3438         (command_structure_invariants_tests): New function.
3439         (_initialize_command_def_selftests) Renamed from
3440         _initialize_help_doc_selftests, register command_structure_invariants
3441         selftest.
3442
3443 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3444
3445         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
3446         an alias of 'show'.
3447
3448 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
3449
3450         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
3451         ada_is_fixed_point_type.  Update all callers.
3452         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
3453         all callers.
3454         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
3455         Update all callers.
3456         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
3457         print_fixed_point_type.  Update all callers.
3458         * ada-valprint.c (ada_value_print_num): Replace call to
3459         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
3460
3461 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
3462
3463         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
3464         processors.
3465         (cpu_supports_bts): Add CV_AMD case.
3466
3467 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
3468             Simon Marchi  <simon.marchi@efficios.com>
3469
3470         * infrun.c (stop_all_threads): Collect multiple wait events at
3471         each pass.
3472
3473 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3474
3475         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
3476         type::code instead.
3477
3478 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3479
3480         * gdbtypes.h (struct type) <code, set_code>: New methods.
3481         (TYPE_CODE): Use type::code.  Change all call sites used to set
3482         the code to use type::set_code instead.
3483
3484 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3485             Tom de Vries  <tdevries@suse.de>
3486             Pedro Alves  <palves@redhat.com>
3487
3488         PR threads/25478
3489         * infrun.c (stop_all_threads): Do NOT ignore
3490         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
3491         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
3492         received.
3493         (handle_no_resumed): Remove code handling a live inferior with no
3494         threads.
3495         * remote.c (has_single_non_exited_thread): New.
3496         (remote_target::update_thread_list): Do not delete a thread if is
3497         the last thread of the process.
3498         * thread.c (thread_select): Call delete_exited_threads instead of
3499         prune_threads.
3500
3501 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3502
3503         * infrun.c (stop_all_threads): Enable/disable thread events of all
3504         targets.  Move a debug message denoting the end of the function
3505         into the SCOPED_EXIT block.
3506
3507 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3508
3509         * process-stratum-target.h: Include <set>.
3510         (all_non_exited_process_targets, switch_to_target_no_thread): New
3511         function declarations.
3512         * process-stratum-target.c (all_non_exited_process_targets)
3513         (switch_to_target_no_thread): New function implementations.
3514
3515 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3516
3517         * infrun.c (handle_inferior_event): Extract out a piece of code
3518         into...
3519         (mark_non_executing_threads): ...this new function.
3520
3521 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3522
3523         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
3524         use.
3525
3526 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3527
3528         * regcache.c (regcache_read_pc_protected): New function
3529         implementation that returns 0 if the PC cannot read via
3530         'regcache_read_pc'.
3531         * infrun.c (proceed): Call 'regcache_read_pc_protected'
3532         instead of 'regcache_read_pc'.
3533         (keep_going_pass_signal): Ditto.
3534
3535 2020-05-13  Tom Tromey  <tromey@adacore.com>
3536
3537         * ada-lang.c (align_value): Remove.
3538         (ada_template_to_fixed_record_type_1): Use align_up.
3539
3540 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3541
3542         * async-event.c: Update the copyright year.
3543         * async-event.h: Update the copyright year.
3544
3545 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
3546
3547         * objfiles.h (is_addr_in_objfile,
3548         shared_objfile_contains_address_p): Return bool.
3549         * objfile.c (is_addr_in_objfile,
3550         shared_objfile_contains_address_p): Return bool.
3551
3552 2020-05-11  Tom Tromey  <tromey@adacore.com>
3553
3554         * cli/cli-cmds.c (info_command): Restore.
3555         (_initialize_cli_cmds): Use add_prefix_command for "info".
3556         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
3557
3558 2020-05-11  Tom Tromey  <tromey@adacore.com>
3559
3560         * ada-lang.c (ada_value_primitive_field): Now public.
3561         * ada-lang.h (ada_value_primitive_field): Declare.
3562         * ada-valprint.c (print_field_values): Use
3563         ada_value_primitive_field for wrapper fields.
3564
3565 2020-05-11  Tom de Vries  <tdevries@suse.de>
3566
3567         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
3568         MODULE_DOMAIN.
3569
3570 2020-05-11  Tom de Vries  <tdevries@suse.de>
3571
3572         PR symtab/25941
3573         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
3574         with length 0, if not gdb-produced.
3575         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
3576
3577 2020-05-09  Tom de Vries  <tdevries@suse.de>
3578
3579         PR gdb/25955
3580         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
3581         calculation.
3582
3583 2020-05-09  Tom Tromey  <tom@tromey.com>
3584
3585         * top.c (server_command): Now bool.
3586         * top.h (server_command): Now bool.
3587
3588 2020-05-08  Tom Tromey  <tromey@adacore.com>
3589
3590         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
3591         already being processed.
3592
3593 2020-05-08  Tom Tromey  <tom@tromey.com>
3594
3595         * printcmd.c (struct display) <next>: Remove.
3596         <display>: New constructor.
3597         <exp_string>: Now a std::string.
3598         <enabled_p>: Now a bool.
3599         (display_number): Move definition earlier.
3600         (displays): Rename from display_chain.  Now a std::vector.
3601         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
3602         (display_command): Update.
3603         (do_one_display, disable_display)
3604         (enable_disable_display_command, do_enable_disable_display):
3605         Update.
3606         (free_display): Remove.
3607         (clear_displays): Rewrite.
3608         (delete_display): Update.
3609         (map_display_numbers): Use function_view.  Remove "data"
3610         parameter.  Update.
3611         (do_delete_display): Remove.
3612         (undisplay_command): Update.
3613         (do_one_display, do_displays, disable_display)
3614         (info_display_command): Update.
3615         (do_enable_disable_display): Remove.
3616         (enable_disable_display_command)
3617         (clear_dangling_display_expressions): Update.
3618
3619 2020-05-08  Tom Tromey  <tom@tromey.com>
3620
3621         * symtab.c (set_symbol_cache_size)
3622         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
3623         (maintenance_print_symbol_cache_statistics): Update.
3624         * symmisc.c (print_symbol_bcache_statistics)
3625         (print_objfile_statistics, maintenance_print_objfiles)
3626         (maintenance_info_symtabs, maintenance_check_symtabs)
3627         (maintenance_expand_symtabs, maintenance_info_line_tables):
3628         Update.
3629         * symfile-debug.c (set_debug_symfile): Update.
3630         * source.c (forget_cached_source_info): Update.
3631         * python/python.c (gdbpy_progspaces): Update.
3632         * psymtab.c (maintenance_info_psymtabs): Update.
3633         * probe.c (parse_probes): Update.
3634         * linespec.c (iterate_over_all_matching_symtabs)
3635         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
3636         * guile/scm-progspace.c (gdbscm_progspaces): Update.
3637         * exec.c (exec_target::close): Update.
3638         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
3639         * breakpoint.c (print_one_breakpoint_location)
3640         (create_longjmp_master_breakpoint)
3641         (create_std_terminate_master_breakpoint): Update.
3642         * progspace.c (program_spaces): Now a std::vector.
3643         (maybe_new_address_space): Update.
3644         (add_program_space): Remove.
3645         (program_space::program_space): Update.
3646         (remove_program_space): Update.
3647         (number_of_program_spaces): Remove.
3648         (print_program_space, update_address_spaces): Update.
3649         * progspace.h (program_spaces): Change type.
3650         (ALL_PSPACES): Remove.
3651         (number_of_program_spaces): Don't declare.
3652         (struct program_space) <next>: Remove.
3653
3654 2020-05-08  Tom Tromey  <tom@tromey.com>
3655
3656         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
3657         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
3658         (enable_break): Update.
3659         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
3660         (frv_fdpic_find_canonical_descriptor): Update.
3661         (frv_fetch_objfile_link_map): Update.
3662         * progspace.c (program_space::free_all_objfiles): Update.
3663         (program_space::solibs): New method.
3664         * progspace.h (struct program_space) <solibs>: New method.
3665         * solist.h (master_so_list): Don't declare.
3666         (ALL_SO_LIBS): Remove.
3667         * solib.h (so_list_head): Remove.
3668         (update_solib_list): Update comment.
3669         * solib.c (master_so_list): Remove.
3670         (solib_used, update_solib_list, solib_add)
3671         (info_sharedlibrary_command, clear_solib)
3672         (reload_shared_libraries_1, remove_user_added_objfile): Update.
3673
3674 2020-05-08  Tom Tromey  <tom@tromey.com>
3675
3676         * extension.c (extension_languages): Now a std::array.
3677         (ALL_EXTENSION_LANGUAGES): Remove.
3678         (get_ext_lang_defn, get_ext_lang_of_file)
3679         (eval_ext_lang_from_control_command): Update.
3680         (finish_ext_lang_initialization)
3681         (auto_load_ext_lang_scripts_for_objfile)
3682         (ext_lang_type_printers::ext_lang_type_printers)
3683         (apply_ext_lang_type_printers)
3684         (ext_lang_type_printers::~ext_lang_type_printers)
3685         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
3686         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
3687         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
3688         (get_matching_xmethod_workers, ext_lang_colorize)
3689         (ext_lang_before_prompt): Update.
3690         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
3691
3692 2020-05-08  Tom Tromey  <tom@tromey.com>
3693
3694         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
3695         overload.
3696         <swap_string, m_string>: Remove.
3697         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
3698         Update.
3699         * stabsread.c (define_symbol, read_type): Update.
3700         * linespec.c (find_linespec_symbols): Update.
3701         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
3702         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
3703         * dbxread.c (read_dbx_symtab): Update.
3704         * cp-support.h (cp_canonicalize_string_full)
3705         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
3706         Return unique_xmalloc_ptr.
3707         * cp-support.c (inspect_type): Update.
3708         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
3709         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
3710         Likewise.
3711         * c-typeprint.c (print_name_maybe_canonical): Update.
3712         * break-catch-throw.c (check_status_exception_catchpoint):
3713         Update.
3714
3715 2020-05-08  Tom de Vries  <tdevries@suse.de>
3716
3717         * infrun.c (follow_fork): Copy current_line and current_symtab to
3718         child thread.
3719
3720 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3721
3722         * async-event.c (struct async_signal_handler, struct
3723         async_event_handler): Reformat, remove typedef.
3724
3725 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3726
3727         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
3728         access thistype->main_type->dyn_prop_list directly.
3729
3730 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3731
3732         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
3733         (remove_dyn_prop): Remove.  Update all users to use
3734         type::remove_dyn_prop.
3735         * gdbtypes.c (remove_dyn_prop): Rename to...
3736         (type::remove_dyn_prop): ... this.
3737
3738 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
3739
3740         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
3741         (add_dyn_prop): Remove.  Update all users to use
3742         type::add_dyn_prop.
3743         * gdbtypes.c (add_dyn_prop): Rename to...
3744         (type::add_dyn_prop): ... this.
3745
3746 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3747
3748         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
3749         (get_dyn_prop): Remove.  Update all users to use
3750         type::dyn_prop.
3751         * gdbtypes.c (get_dyn_prop): Rename to...
3752         (type::dyn_prop): ... this.
3753
3754 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3755
3756         * gdbtypes.h (struct main_type) <flag_static>: Remove.
3757
3758 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3759
3760         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
3761         instruction, skip it if it's there.
3762
3763 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
3764
3765         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
3766
3767 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
3768
3769         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
3770         * gdbtypes.c (recursive_dump_type): Remove use of
3771         TYPE_INCOMPLETE.
3772
3773 2020-05-03  Tom Tromey  <tom@tromey.com>
3774
3775         * breakpoint.c (catch_command, tcatch_command): Remove.
3776         (_initialize_breakpoint): Use add_basic_prefix_cmd,
3777         add_show_prefix_cmd.
3778         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
3779         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
3780         Remove.
3781         (add_internal_problem_command): Use add_basic_prefix_cmd,
3782         add_show_prefix_cmd.
3783         * mips-tdep.c (set_mipsfpu_command): Remove.
3784         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
3785         * dwarf2/index-cache.c (set_index_cache_command): Remove.
3786         (_initialize_index_cache): Use add_basic_prefix_cmd.
3787         * memattr.c (dummy_cmd): Remove.
3788         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
3789         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
3790         (_initialize_tui_win): Use add_basic_prefix_cmd,
3791         add_show_prefix_cmd.
3792         * cli/cli-logging.c (set_logging_command): Remove.
3793         (_initialize_cli_logging): Use add_basic_prefix_cmd,
3794         add_show_prefix_cmd.
3795         (show_logging_command): Remove.
3796         * target.c (target_command): Remove.
3797         (add_target): Use add_basic_prefix_cmd.
3798
3799 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
3800
3801         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
3802
3803 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3804
3805         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
3806         info_command.
3807
3808 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
3809
3810         * nbsd-nat.c (nbsd_enable_proc_events)
3811         (nbsd_nat_target::post_startup_inferior): Add.
3812         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
3813         (nbsd_nat_target::update_thread_list): Rewrite.
3814         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
3815         "PTRACE_LWP_CREATE".
3816         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
3817
3818 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3819
3820         * stack.c (_initialize_stack): Remove duplicated creation
3821         of "frame" command and "f" alias.
3822
3823 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3824
3825         PR gdb/18706
3826         * gdbtypes.c (check_typedef): Calculate size of array of
3827         stubbed type.
3828
3829 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3830
3831         PR gdb/15559
3832         * i386-tdep.c (i386_push_dummy_call): Call
3833         i386_thiscall_push_dummy_call.
3834         (i386_thiscall_push_dummy_call): New function.
3835         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
3836         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
3837         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
3838
3839 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3840
3841         * gdbarch.sh (do_read): Add shellcheck disable directive for
3842         warning SC2162.
3843
3844 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3845
3846         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
3847         "referenced but not assigned" warning.
3848
3849 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3850
3851         * gdbarch.sh: Remove code that sets fallbackdefault.
3852
3853 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3854
3855         * gdbarch.sh: Use shell operators && and || instead of
3856         -a and -o.
3857
3858 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3859
3860         * gdbarch.sh: Use $(...) instead of `...`.
3861
3862 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3863
3864         * gdbarch.sh: Use double quotes around variables.
3865
3866 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3867
3868         * gdbarch.sh: Use %s with printf, instead of variables in the
3869         format string.
3870
3871 2020-04-29  Tom Tromey  <tromey@adacore.com>
3872
3873         PR ada/25875:
3874         * dwarf2/read.c (update_enumeration_type_from_children): Compute
3875         type fields here.
3876         (read_enumeration_type): Call
3877         update_enumeration_type_from_children later.  Update comments.
3878         (process_enumeration_scope): Don't create type fields.
3879
3880 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3881
3882         * nbsd-tdep.c: Include "xml-syscall.h".
3883         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
3884
3885 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3886
3887         * nbsd-nat.c: Include "sys/wait.h".
3888         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
3889         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
3890         (nbsd_nat_target::remove_exec_catchpoint)
3891         (nbsd_nat_target::set_syscall_catchpoint): Add.
3892         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
3893         (nbsd_nat_target::insert_exec_catchpoint)
3894         (nbsd_nat_target::remove_exec_catchpoint)
3895         (nbsd_nat_target::set_syscall_catchpoint): Add.
3896         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
3897         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
3898         `nbsd_get_syscall_number'.
3899
3900 2020-04-29  Tom Tromey  <tom@tromey.com>
3901
3902         * stack.c (print_block_frame_labels): Remove.
3903
3904 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
3905
3906         PR gdb/17320
3907         * ada-valprint.c (val_print_packed_array_elements): Move array
3908         end bracket to new line.
3909         (ada_val_print_string): Remove extra spaces before first array
3910         element.
3911         * c-valprint.c (c_value_print_array): Likewise.
3912         * m2-valprint.c (m2_print_array_contents): Likewise.
3913         (m2_value_print_inner): Likewise.
3914         * p-valprint.c (pascal_value_print_inner): Likewise.
3915         * valprint.c (generic_val_print_array): Likewise.
3916         (value_print_array_elements): Move first array element and array
3917         end bracket to new line.
3918
3919 2020-04-29  Tom de Vries  <tdevries@suse.de>
3920
3921         PR symtab/25889
3922         * linespec.c (find_method): Fix ix calculation.
3923
3924 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
3925
3926         * syscalls/update-netbsd.sh: New file.
3927         * syscalls/netbsd.xml: Regenerate.
3928         * data-directory/Makefile.in: Register `netbsd.xml' in
3929         `SYSCALLS_FILES'.
3930
3931 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3932
3933         * syscalls/update-freebsd.sh: Add double quotes.
3934
3935 2020-04-28  Tom Tromey  <tom@tromey.com>
3936
3937         * NEWS: Update.
3938         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
3939         (cmdpy_init): Allow class_tui.
3940
3941 2020-04-28 Mark Williams <mark@myosotissp.com>
3942
3943         PR gdb/24480
3944         * dwarf2read.c: Add missing assingments to list_in_scope when
3945         start_symtab was already called.
3946
3947 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3948
3949         PR gdb/25881
3950         * dwarf2/read.c (offset_map_type): Use
3951         gdb:hash_enum<sect_offset> as hash function.
3952
3953 2020-04-28  Tom de Vries  <tdevries@suse.de>
3954
3955         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
3956         with DW_AT_signature.
3957
3958 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
3959
3960         * configure.ac: Remove check for fs_base/gs_base in
3961         user_regs_struct.
3962         * configure: Re-generate.
3963         * config.in: Re-generate.
3964         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
3965         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
3966         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
3967
3968 2020-04-27  Luis Machado  <luis.machado@linaro.org>
3969
3970         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3971         problematic inline frame unwinding situation.
3972         * frame.c (frame_id_computed_p): New function.
3973         * frame.h (frame_id_computed_p): New prototype.
3974
3975 2020-04-26  Tom Tromey  <tom@tromey.com>
3976
3977         * command.h (enum command_class) <class_pseudo>: Remove.
3978
3979 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3980
3981         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3982         and whitespace.
3983
3984 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3985
3986         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3987         `PT_GET_PROCESS_STATE' block.
3988
3989 2020-04-24  Tom Tromey  <tom@tromey.com>
3990
3991         * symtab.h (symbol_get_demangled_name): Don't declare.
3992         * symtab.c (symbol_get_demangled_name): Remove.
3993         (general_symbol_info::natural_name)
3994         (general_symbol_info::demangled_name): Update.
3995
3996 2020-04-24  Tom Tromey  <tom@tromey.com>
3997
3998         PR rust/25025:
3999         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
4000
4001 2020-04-24  Tom Tromey  <tom@tromey.com>
4002
4003         PR symtab/12707:
4004         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
4005         exists.
4006         (new_symbol): Likewise.
4007         * compile/compile-object-load.c (get_out_value_type): Use
4008         symbol_matches_search_name.
4009
4010 2020-04-24  Tom Tromey  <tom@tromey.com>
4011
4012         * dwarf2/read.c (add_partial_symbol): Do not call
4013         compute_and_set_names.
4014
4015 2020-04-24  Tom Tromey  <tom@tromey.com>
4016
4017         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
4018         overload.
4019
4020 2020-04-24  Tom Tromey  <tom@tromey.com>
4021
4022         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
4023         (add_psymbol_to_list): New overload.  Make old overload call new
4024         one.
4025         * psympriv.h (add_psymbol_to_list): New overload.
4026
4027 2020-04-24  Tom Tromey  <tom@tromey.com>
4028
4029         * dwarf2/read.c (partial_die_info::read) <case
4030         DW_AT_linkage_name>: Use value_as_string.
4031         (dwarf2_string_attr): Use value_as_string.
4032         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
4033         method.
4034         * dwarf2/attribute.c (attribute::value_as_string): New method.
4035
4036 2020-04-24  Tom Tromey  <tom@tromey.com>
4037
4038         * symtab.c (general_symbol_info::natural_name)
4039         (general_symbol_info::demangled_name): Check for language_rust.
4040
4041 2020-04-24  Tom Tromey  <tom@tromey.com>
4042
4043         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
4044         (dwarf2_physname): ... from here.
4045         (partial_die_info::read): Add Rust "{" hack.
4046
4047 2020-04-24  Tom Tromey  <tom@tromey.com>
4048
4049         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
4050         method.
4051         (symbol_set_demangled_name): Don't declare.
4052         * symtab.c (general_symbol_info::set_demangled_name): Rename from
4053         symbol_set_demangled_name.
4054         (general_symbol_info::set_language)
4055         (general_symbol_info::compute_and_set_names): Update.
4056         * minsyms.c (minimal_symbol_reader::install): Update.
4057         * dwarf2/read.c (new_symbol): Update.
4058
4059 2020-04-24  Tom Tromey  <tromey@adacore.com>
4060
4061         PR python/23662:
4062         * python/py-type.c (convert_field): Handle
4063         FIELD_LOC_KIND_DWARF_BLOCK.
4064         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
4065         (typy_get_dynamic): Nw function.
4066         (type_object_getset): Add "dynamic".
4067         * NEWS: Add entry.
4068
4069 2020-04-24  Tom Tromey  <tromey@adacore.com>
4070
4071         * ada-typeprint.c (print_choices, print_variant_part)
4072         (print_record_field_types_dynamic): New functions.
4073         (print_record_field_types): Use print_record_field_types_dynamic.
4074
4075 2020-04-24  Tom Tromey  <tromey@adacore.com>
4076
4077         * dwarf2/read.c (handle_data_member_location): New overload.
4078         (dwarf2_add_field): Use it.
4079         (decode_locdesc): Add "computed" parameter.  Update comment.
4080         * gdbtypes.c (is_dynamic_type_internal): Also look for
4081         FIELD_LOC_KIND_DWARF_BLOCK.
4082         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
4083         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
4084         virtual base classes.
4085         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
4086         FIELD_LOC_KIND_DWARF_BLOCK.
4087
4088 2020-04-24  Tom Tromey  <tromey@adacore.com>
4089
4090         * dwarf2/read.c (read_structure_type): Handle dynamic length.
4091         * gdbtypes.c (is_dynamic_type_internal): Check
4092         TYPE_HAS_DYNAMIC_LENGTH.
4093         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
4094         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
4095         New macros.
4096         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
4097         constant.
4098
4099 2020-04-24  Tom Tromey  <tromey@adacore.com>
4100
4101         * dwarf2/read.c (struct variant_field): Rewrite.
4102         (struct variant_part_builder): New.
4103         (struct nextfield): Remove "variant" field.  Add "offset".
4104         (struct field_info): Add "current_variant_part" and
4105         "variant_parts".
4106         (alloc_discriminant_info): Remove.
4107         (alloc_rust_variant): New function.
4108         (quirk_rust_enum): Update.
4109         (dwarf2_add_field): Set "offset" member.  Don't handle
4110         DW_TAG_variant_part.
4111         (offset_map_type): New typedef.
4112         (convert_variant_range, create_one_variant)
4113         (create_one_variant_part, create_variant_parts)
4114         (add_variant_property): New functions.
4115         (dwarf2_attach_fields_to_type): Call add_variant_property.
4116         (read_structure_type): Don't handle DW_TAG_variant_part.
4117         (handle_variant_part, handle_variant): New functions.
4118         (handle_struct_member_die): Use them.
4119         (process_structure_scope): Don't handle variant parts.
4120         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
4121         (struct discriminant_info): Remove.
4122         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
4123         (struct main_type) <flag_discriminated_union>: Remove.
4124         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
4125         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
4126         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
4127         Update.
4128         * valops.c (value_union_variant): Remove.
4129         * value.h (value_union_variant): Don't declare.
4130
4131 2020-04-24  Tom Tromey  <tromey@adacore.com>
4132
4133         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
4134         (ada_value_primitive_packed_val): Update.
4135         * ada-valprint.c (ada_value_print_1): Update.
4136         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
4137         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
4138         just an address.  Use evaluate_for_locexpr_baton.
4139         (dwarf2_evaluate_property): Update.
4140         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
4141         array_view.
4142         * findvar.c (default_read_var_value): Update.
4143         * gdbtypes.c (compute_variant_fields_inner)
4144         (resolve_dynamic_type_internal): Update.
4145         (resolve_dynamic_type): Change type of valaddr parameter.
4146         * gdbtypes.h (resolve_dynamic_type): Update.
4147         * valarith.c (value_subscripted_rvalue): Update.
4148         * value.c (value_from_contents_and_address): Update.
4149
4150 2020-04-24  Tom Tromey  <tromey@adacore.com>
4151
4152         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
4153         "push_initial_value" parameter.
4154         (dwarf2_evaluate_property): Likewise.
4155         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
4156
4157 2020-04-24  Tom Tromey  <tromey@adacore.com>
4158
4159         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
4160         (variant::matches, compute_variant_fields_recurse)
4161         (compute_variant_fields_inner, compute_variant_fields): New
4162         functions.
4163         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
4164         Use resolved_type after type is made.
4165         (operator==): Add new cases.
4166         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
4167         (struct discriminant_range, struct variant, struct variant_part):
4168         New.
4169         (union dynamic_prop_data) <variant_parts, original_type>: New
4170         members.
4171         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
4172         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
4173         constants.
4174         * value.c (unpack_bits_as_long): Now public.
4175         * value.h (unpack_bits_as_long): Declare.
4176
4177 2020-04-24  Tom Tromey  <tromey@adacore.com>
4178
4179         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
4180         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
4181
4182 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
4183
4184         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
4185
4186 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
4187
4188         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
4189         (remove_fork_catchpoint, post_startup_inferior)
4190         (post_attach): Move...
4191         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
4192         (remove_fork_catchpoint, post_startup_inferior)
4193         (post_attach): ...here.
4194         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
4195         (remove_fork_catchpoint, post_startup_inferior)
4196         (post_attach): Move...
4197         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
4198         (remove_fork_catchpoint, post_startup_inferior)
4199         (post_attach): ...here.
4200
4201 2020-04-24  Tom Tromey  <tromey@adacore.com>
4202
4203         * nat/windows-nat.h (struct windows_thread_info)
4204         <pc_adjusted>: New member.
4205         * windows-nat.c (windows_fetch_one_register): Check
4206         pc_adjusted.
4207         (windows_nat_target::get_windows_debug_event)
4208         (windows_nat_target::wait): Set pc_adjusted.
4209
4210 2020-04-24  Tom de Vries  <tdevries@suse.de>
4211
4212         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
4213         Run gdb-add-index inside temp dir.
4214
4215 2020-04-23  Tom Tromey  <tromey@adacore.com>
4216
4217         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
4218         in loop.
4219
4220 2020-04-23  Luis Machado  <luis.machado@linaro.org>
4221
4222         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
4223         get_frame_register instead of gdbarch_unwind_pc.
4224
4225 2020-04-23  Tom de Vries  <tdevries@suse.de>
4226
4227         * symtab.c (lookup_global_symbol): Prefer def over decl.
4228
4229 2020-04-23  Tom de Vries  <tdevries@suse.de>
4230
4231         PR symtab/25807
4232         * block.c (best_symbol, better_symbol): Promote to external.
4233         * block.h (best_symbol, better_symbol): Declare.
4234         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
4235         decl.
4236
4237 2020-04-23  Tom Tromey  <tromey@adacore.com>
4238
4239         PR ada/25837:
4240         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
4241         "const char *", not a "const std::string &".
4242         <name_and_matcher::operator==>: Update.
4243         * unittests/lookup_name_info-selftests.c: Change type of
4244         "result".
4245
4246 2020-04-23  Tom Tromey  <tom@tromey.com>
4247
4248         * inferior.h (iterate_over_inferiors): Don't declare.
4249         * inferior.c (iterate_over_inferiors): Remove.
4250         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
4251         Remove.
4252         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
4253         use iterate_over_inferiors.
4254         (darwin_resume_inferior_it)
4255         (struct resume_inferior_threads_param)
4256         (darwin_resume_inferior_threads_it): Remove.
4257         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
4258
4259 2020-04-23  Tom de Vries  <tdevries@suse.de>
4260
4261         * blockframe.c (find_pc_partial_function): Use
4262         find_pc_sect_compunit_symtab rather than
4263         objfile->sf->qf->find_pc_sect_compunit_symtab.
4264
4265 2020-04-22  Tom de Vries  <tdevries@suse.de>
4266
4267         PR symtab/25764
4268         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
4269         in psymtabs.
4270
4271 2020-04-22  Tom de Vries  <tdevries@suse.de>
4272
4273         PR symtab/25801
4274         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
4275         symtabs.
4276
4277 2020-04-22  Tom de Vries  <tdevries@suse.de>
4278
4279         PR symtab/25700
4280         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
4281         CU if already created.
4282
4283 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4284
4285         * infrun.c (displaced_step_fixup): Switch to the event_thread
4286         before calling displaced_step_restore, not after.
4287
4288 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4289
4290         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
4291         its inferior is not recorded by us.
4292         (record_btrace_target_open): Replace call to
4293         all_non_exited_threads () with call to current_inferior
4294         ()->non_exited_threads ().
4295         (record_btrace_target::stop_recording): Likewise.
4296         (record_btrace_target::close): Likewise.
4297         (record_btrace_target::wait): Likewise.
4298         (record_btrace_target::record_stop_replaying): Likewise.
4299
4300 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4301
4302         * btrace.c (btrace_enable): Throw an error on double enables and
4303         when enabling recording fails.
4304         (btrace_disable): Throw an error if the thread is not recorded.
4305
4306 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4307
4308         * record-btrace.c (record_btrace_target::fetch_registers): Forward
4309         request if we do not have a thread_info.
4310
4311 2020-04-21  Tom de Vries  <tdevries@suse.de>
4312
4313         PR gdb/25471
4314         * thread.c
4315         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
4316         exception in get_frame_id.
4317
4318 2020-04-20  Tom Tromey  <tromey@adacore.com>
4319
4320         * python/python.c (struct gdbpy_event): Mark move constructor as
4321         noexcept.
4322         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
4323         constructor as noexcept.
4324         * completer.h (struct completion_result): Mark move constructor as
4325         noexcept.
4326         * completer.c (completion_result::completion_result): Use
4327         initialization style.  Don't call reset_match_list.
4328
4329 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
4330
4331         * MAINTAINERS (Write After Approval): Add myself.
4332
4333 2020-04-18  Tom Tromey  <tom@tromey.com>
4334
4335         * windows-tdep.c (init_w32_command_list)
4336         (w32_prefix_command_valid): Restore.
4337         (_initialize_windows_tdep): Call init_w32_command_list.
4338
4339 2020-04-18  Tom Tromey  <tom@tromey.com>
4340
4341         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
4342         * value.c (value_fn_field): Update.
4343         * valops.c (find_function_in_inferior)
4344         (value_allocate_space_in_inferior): Update.
4345         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4346         Update.
4347         * tui/tui-source.c (tui_source_window::set_contents): Update.
4348         * symtab.c (lookup_global_or_static_symbol)
4349         (find_function_start_sal_1, skip_prologue_sal)
4350         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
4351         * symmisc.c (dump_msymbols, dump_symtab_1)
4352         (maintenance_print_one_line_table): Update.
4353         * symfile.c (init_entry_point_info, section_is_mapped)
4354         (list_overlays_command, simple_read_overlay_table)
4355         (simple_overlay_update_1): Update.
4356         * stap-probe.c (handle_stap_probe): Update.
4357         * stabsread.c (dbx_init_float_type, define_symbol)
4358         (read_one_struct_field, read_enum_type, read_range_type): Update.
4359         * source.c (info_line_command): Update.
4360         * python/python.c (gdbpy_source_objfile_script)
4361         (gdbpy_execute_objfile_script): Update.
4362         * python/py-type.c (save_objfile_types): Update.
4363         * python/py-objfile.c (py_free_objfile): Update.
4364         * python/py-inferior.c (python_new_objfile): Update.
4365         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
4366         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
4367         (maintenance_check_psymtabs): Update.
4368         * printcmd.c (info_address_command): Update.
4369         * objfiles.h (struct objfile) <arch>: New method, from
4370         get_objfile_arch.
4371         (get_objfile_arch): Don't declare.
4372         * objfiles.c (get_objfile_arch): Remove.
4373         (filter_overlapping_sections): Update.
4374         * minsyms.c (msymbol_is_function): Update.
4375         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
4376         (output_nondebug_symbol): Update.
4377         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
4378         (mdebug_expand_psymtab): Update.
4379         * machoread.c (macho_add_oso_symfile): Update.
4380         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
4381         Update.
4382         * linux-fork.c (checkpoint_command): Update.
4383         * linespec.c (convert_linespec_to_sals): Update.
4384         * jit.c (finalize_symtab): Update.
4385         * infrun.c (insert_exception_resume_from_probe): Update.
4386         * ia64-tdep.c (ia64_find_unwind_table): Update.
4387         * hppa-tdep.c (internalize_unwinds): Update.
4388         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
4389         Update.
4390         * gcore.c (call_target_sbrk): Update.
4391         * elfread.c (record_minimal_symbol, elf_symtab_read)
4392         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
4393         (elf_gnu_ifunc_resolve_by_got): Update.
4394         * dwarf2/read.c (create_addrmap_from_index)
4395         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4396         (read_debug_names_from_section)
4397         (process_psymtab_comp_unit_reader, add_partial_symbol)
4398         (add_partial_subprogram, process_full_comp_unit)
4399         (read_file_scope, read_func_scope, read_lexical_block_scope)
4400         (read_call_site_scope, dwarf2_ranges_read)
4401         (dwarf2_record_block_ranges, dwarf2_add_field)
4402         (mark_common_block_symbol_computed, read_tag_pointer_type)
4403         (read_tag_string_type, dwarf2_init_float_type)
4404         (dwarf2_init_complex_target_type, read_base_type)
4405         (partial_die_info::read, partial_die_info::read)
4406         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
4407         (dwarf2_fetch_die_loc_sect_off): Update.
4408         * dwarf2/loc.c (dwarf2_find_location_expression)
4409         (class dwarf_evaluate_loc_desc, rw_pieced_value)
4410         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
4411         (dwarf2_loc_desc_get_symbol_read_needs)
4412         (locexpr_describe_location_piece, locexpr_describe_location_1)
4413         (loclist_describe_location): Update.
4414         * dwarf2/index-write.c (write_debug_names): Update.
4415         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
4416         * dtrace-probe.c (dtrace_process_dof): Update.
4417         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
4418         (process_one_symbol): Update.
4419         * ctfread.c (ctf_init_float_type, read_base_type): Update.
4420         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
4421         (coff_read_enum_type): Update.
4422         * cli/cli-cmds.c (edit_command, list_command): Update.
4423         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
4424         * breakpoint.c (create_overlay_event_breakpoint)
4425         (create_longjmp_master_breakpoint)
4426         (create_std_terminate_master_breakpoint)
4427         (create_exception_master_breakpoint, get_sal_arch): Update.
4428         * block.c (block_gdbarch): Update.
4429         * annotate.c (annotate_source_line): Update.
4430
4431 2020-04-17  Tom Tromey  <tromey@adacore.com>
4432
4433         * auto-load.c (show_auto_load_cmd): Remove.
4434         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
4435         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
4436         (maintenance_print_arc_command): Remove.
4437         * tui/tui-win.c (tui_command): Remove.
4438         (tui_get_cmd_list): Use add_basic_prefix_cmd.
4439         * tui/tui-layout.c (tui_layout_command): Remove.
4440         (_initialize_tui_layout): Use add_basic_prefix_cmd.
4441         * python/python.c (user_set_python, user_show_python): Remove.
4442         (_initialize_python): Use add_basic_prefix_cmd,
4443         add_show_prefix_cmd.
4444         * guile/guile.c (set_guile_command, show_guile_command): Remove.
4445         (install_gdb_commands): Use add_basic_prefix_cmd,
4446         add_show_prefix_cmd.
4447         (info_guile_command): Remove.
4448         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
4449         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
4450         add_show_prefix_cmd.
4451         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
4452         Remove do_set and do_show parameters.
4453         * cli/cli-style.c (set_style, show_style): Remove.
4454         (_initialize_cli_style): Use add_basic_prefix_cmd,
4455         add_show_prefix_cmd.
4456         (cli_style_option::add_setshow_commands): Remove do_set and
4457         do_show parameters.
4458         (cli_style_option::add_setshow_commands): Use
4459         add_basic_prefix_cmd, add_show_prefix_cmd.
4460         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
4461         (set_style_name): Remove.
4462         * cli/cli-dump.c (dump_command, append_command): Remove.
4463         (srec_dump_command, ihex_dump_command, verilog_dump_command)
4464         (tekhex_dump_command, binary_dump_command)
4465         (binary_append_command): Remove.
4466         (_initialize_cli_dump): Use add_basic_prefix_cmd.
4467         * windows-tdep.c (w32_prefix_command_valid): Remove global.
4468         (init_w32_command_list): Remove; move into ...
4469         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
4470         * valprint.c (set_print, show_print, set_print_raw)
4471         (show_print_raw): Remove.
4472         (_initialize_valprint): Use add_basic_prefix_cmd,
4473         add_show_prefix_cmd.
4474         * typeprint.c (set_print_type, show_print_type): Remove.
4475         (_initialize_typeprint): Use add_basic_prefix_cmd,
4476         add_show_prefix_cmd.
4477         * record.c (set_record_command, show_record_command): Remove.
4478         (_initialize_record): Use add_basic_prefix_cmd,
4479         add_show_prefix_cmd.
4480         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
4481         add_show_prefix_cmd.
4482         (info_command, show_command, set_debug, show_debug): Remove.
4483         * top.h (set_history, show_history): Don't declare.
4484         * top.c (set_history, show_history): Remove.
4485         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
4486         (unset_tdesc_cmd): Remove.
4487         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
4488         add_show_prefix_cmd.
4489         * symtab.c (info_module_command): Remove.
4490         (_initialize_symtab): Use add_basic_prefix_cmd.
4491         * symfile.c (overlay_command): Remove.
4492         (_initialize_symfile): Use add_basic_prefix_cmd.
4493         * sparc64-tdep.c (info_adi_command): Remove.
4494         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
4495         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
4496         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
4497         add_show_prefix_cmd.
4498         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
4499         (_initialize_serial): Use add_basic_prefix_cmd,
4500         add_show_prefix_cmd.
4501         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
4502         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
4503         add_show_prefix_cmd.
4504         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
4505         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
4506         add_show_prefix_cmd.
4507         * riscv-tdep.c (show_riscv_command, set_riscv_command)
4508         (show_debug_riscv_command, set_debug_riscv_command): Remove.
4509         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
4510         add_show_prefix_cmd.
4511         * remote.c (remote_command, set_remote_cmd): Remove.
4512         (_initialize_remote): Use add_basic_prefix_cmd.
4513         * record-full.c (set_record_full_command)
4514         (show_record_full_command): Remove.
4515         (_initialize_record_full): Use add_basic_prefix_cmd,
4516         add_show_prefix_cmd.
4517         * record-btrace.c (cmd_set_record_btrace)
4518         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
4519         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
4520         (cmd_show_record_btrace_pt): Remove.
4521         (_initialize_record_btrace): Use add_basic_prefix_cmd,
4522         add_show_prefix_cmd.
4523         * ravenscar-thread.c (set_ravenscar_command)
4524         (show_ravenscar_command): Remove.
4525         (_initialize_ravenscar): Use add_basic_prefix_cmd,
4526         add_show_prefix_cmd.
4527         * mips-tdep.c (show_mips_command, set_mips_command)
4528         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
4529         add_show_prefix_cmd.
4530         * maint.c (maintenance_command, maintenance_info_command)
4531         (maintenance_check_command, maintenance_print_command)
4532         (maintenance_set_cmd, maintenance_show_cmd): Remove.
4533         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
4534         add_show_prefix_cmd.
4535         (show_per_command_cmd): Remove.
4536         * maint-test-settings.c (maintenance_set_test_settings_cmd):
4537         Remove.
4538         (maintenance_show_test_settings_cmd): Remove.
4539         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
4540         add_show_prefix_cmd.
4541         * maint-test-options.c (maintenance_test_options_command):
4542         Remove.
4543         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
4544         * macrocmd.c (macro_command): Remove
4545         (_initialize_macrocmd): Use add_basic_prefix_cmd.
4546         * language.c (set_check, show_check): Remove.
4547         (_initialize_language): Use add_basic_prefix_cmd,
4548         add_show_prefix_cmd.
4549         * infcmd.c (unset_command): Remove.
4550         (_initialize_infcmd): Use add_basic_prefix_cmd.
4551         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
4552         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
4553         add_show_prefix_cmd.
4554         * go32-nat.c (go32_info_dos_command): Remove.
4555         (_initialize_go32_nat): Use add_basic_prefix_cmd.
4556         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
4557         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
4558         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
4559         (_initialize_frame): Use add_basic_prefix_cmd,
4560         add_show_prefix_cmd.
4561         * dcache.c (set_dcache_command, show_dcache_command): Remove.
4562         (_initialize_dcache): Use add_basic_prefix_cmd,
4563         add_show_prefix_cmd.
4564         * cp-support.c (maint_cplus_command): Remove.
4565         (_initialize_cp_support): Use add_basic_prefix_cmd.
4566         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
4567         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
4568         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
4569         add_basic_prefix_cmd, add_show_prefix_cmd.
4570         * breakpoint.c (save_command): Remove.
4571         (_initialize_breakpoint): Use add_basic_prefix_cmd.
4572         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
4573         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
4574         add_show_prefix_cmd.
4575         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
4576         (set_ada_command, show_ada_command): Remove.
4577         (_initialize_ada_language): Use add_basic_prefix_cmd,
4578         add_show_prefix_cmd.
4579         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
4580
4581 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
4582
4583         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
4584         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
4585
4586 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4587
4588         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
4589         warning messages.
4590
4591 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4592
4593         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
4594         import table is not at beginning of .idata section.
4595
4596 2020-04-16  Pedro Alves  <palves@redhat.com>
4597
4598         * inferior.c (delete_inferior): Use delete operator directly
4599         instead of delete_program_space.
4600         * progspace.c (add_program_space): New, factored out from
4601         program_space::program_space.
4602         (remove_program_space): New, factored out from
4603         delete_program_space.
4604         (program_space::program_space): Remove intro comment.  Rewrite.
4605         (program_space::~program_space): Remove intro comment.  Call
4606         remove_program_space.
4607         (delete_program_space): Delete.
4608         * progspace.h (program_space::program_space): Make explicit.  Move
4609         intro comment here, adjusted.
4610         (program_space::~program_space): Move intro comment here,
4611         adjusted.
4612         (delete_program_space): Remove.
4613
4614 2020-04-16  Tom Tromey  <tromey@adacore.com>
4615
4616         * windows-nat.c (windows_nat::handle_access_violation): New
4617         function.
4618         * nat/windows-nat.h (handle_access_violation): Declare.
4619         * nat/windows-nat.c (handle_exception): Move Cygwin code to
4620         windows-nat.c.  Call handle_access_violation.
4621
4622 2020-04-16  Tom de Vries  <tdevries@suse.de>
4623
4624         PR symtab/25791
4625         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
4626         CUs without psymtab.
4627
4628 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
4629
4630         * python/python.c (do_start_initialization): Don't call
4631         PyEval_InitThreads for Python 3.9 and beyond.
4632
4633 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
4634
4635         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
4636         thread functions.
4637         (obsd_nat_target::wait): Likewise.
4638
4639 2020-04-15  Tom Tromey  <tromey@adacore.com>
4640
4641         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
4642         (DEBUG_EXCEPT): Use debug_printf.
4643
4644 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * completer.c (class completion_tracker::completion_hash_entry)
4647         <hash_name>: New member function.
4648         (completion_tracker::discard_completions): New callback to hash a
4649         completion_hash_entry, pass this to htab_create_alloc.
4650
4651 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
4652
4653         * windows-nat.c (windows_make_so): Warn rather than stopping with
4654         an error if realpath() fails.
4655
4656 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
4657
4658         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
4659         (nbsd_nat_target::info_proc): Add do_status.
4660
4661 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
4662             Tom de Vries  <tdevries@suse.de>
4663
4664         PR symtab/25718
4665         * psympriv.h (struct partial_symtab::read_symtab)
4666         (struct partial_symtab::expand_psymtab)
4667         (struct partial_symtab::read_dependencies): Update comments.
4668         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
4669         read_symtab for includer.
4670         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
4671         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
4672         (struct dwarf2_include_psymtab::m_readin): Remove.
4673         (struct dwarf2_include_psymtab::includer): New member function.
4674         (dwarf2_psymtab::expand_psymtab): Assert !readin.
4675
4676 2020-04-14  Tom de Vries  <tdevries@suse.de>
4677
4678         PR symtab/25720
4679         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
4680         with NULL symbol_matcher and lookup_name.
4681         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
4682         and lookup_name.
4683         * dwarf2/read.c (dw2_expand_symtabs_matching)
4684         (dw2_debug_names_expand_symtabs_matching): Same.
4685         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
4686         Make lookup_name a pointer.  Update comment.
4687         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
4688         lookup_name being a pointer.
4689         * symfile.c (expand_symtabs_matching): Same.
4690         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
4691         * linespec.c (iterate_over_all_matching_symtabs): Same.
4692
4693 2020-04-13  Tom Tromey  <tom@tromey.com>
4694
4695         * run-on-main-thread.c: Update include.
4696         * unittests/main-thread-selftests.c: Update include.
4697         * tui/tui-win.c: Update include.
4698         * tui/tui-io.c: Update include.
4699         * tui/tui-interp.c: Update include.
4700         * tui/tui-hooks.c: Update include.
4701         * top.h: Update include.
4702         * top.c: Update include.
4703         * ser-base.c: Update include.
4704         * remote.c: Update include.
4705         * remote-notif.c: Update include.
4706         * remote-fileio.c: Update include.
4707         * record-full.c: Update include.
4708         * record-btrace.c: Update include.
4709         * python/python.c: Update include.
4710         * posix-hdep.c: Update include.
4711         * mingw-hdep.c: Update include.
4712         * mi/mi-main.c: Update include.
4713         * mi/mi-interp.c: Update include.
4714         * main.c: Update include.
4715         * linux-nat.c: Update include.
4716         * interps.c: Update include.
4717         * infrun.c: Update include.
4718         * inf-loop.c: Update include.
4719         * event-top.c: Update include.
4720         * event-loop.c: Move to ../gdbsupport/.
4721         * event-loop.h: Move to ../gdbsupport/.
4722         * async-event.h: Update include.
4723         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
4724
4725 2020-04-13  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-win.c: Include async-event.h.
4728         * remote.c: Include async-event.h.
4729         * remote-notif.c: Include async-event.h.
4730         * record-full.c: Include async-event.h.
4731         * record-btrace.c: Include async-event.h.
4732         * infrun.c: Include async-event.h.
4733         * event-top.c: Include async-event.h.
4734         * event-loop.h: Move some declarations to async-event.h.
4735         * event-loop.c: Don't include ser-event.h or top.h.  Move some
4736         code to async-event.c.
4737         * async-event.h: New file.
4738         * async-event.c: New file.
4739         * Makefile.in (COMMON_SFILES): Add async-event.c.
4740         (HFILES_NO_SRCDIR): Add async-event.h.
4741
4742 2020-04-13  Tom Tromey  <tom@tromey.com>
4743
4744         * utils.c (flush_streams): New function.
4745         * event-loop.c (gdb_wait_for_event): Call flush_streams.
4746
4747 2020-04-13  Tom Tromey  <tom@tromey.com>
4748
4749         * event-loop.c (handle_file_event): Use warning, not
4750         printf_unfiltered.
4751
4752 2020-04-13  Tom Tromey  <tom@tromey.com>
4753
4754         * event-loop.c: Include <chrono>.
4755
4756 2020-04-13  Tom Tromey  <tom@tromey.com>
4757
4758         * gdb_select.h: Move to ../gdbsupport/.
4759         * event-loop.c: Update include path.
4760         * top.c: Update include path.
4761         * ser-base.c: Update include path.
4762         * ui-file.c: Update include path.
4763         * ser-tcp.c: Update include path.
4764         * guile/scm-ports.c: Update include path.
4765         * posix-hdep.c: Update include path.
4766         * ser-unix.c: Update include path.
4767         * gdb_usleep.c: Update include path.
4768         * mingw-hdep.c: Update include path.
4769         * inflow.c: Update include path.
4770         * infrun.c: Update include path.
4771         * event-top.c: Update include path.
4772
4773 2020-04-13  Tom Tromey  <tom@tromey.com>
4774
4775         * configure: Rebuild.
4776         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
4777
4778 2020-04-13  Tom Tromey  <tom@tromey.com>
4779
4780         * event-loop.h (start_event_loop): Don't declare.
4781         * event-loop.c (start_event_loop): Move...
4782         * main.c (start_event_loop): ...here.  Now static.
4783
4784 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
4785
4786         * MAINTAINERS: Update my email address.
4787
4788 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4789
4790         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
4791         IP_ALL.
4792
4793 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4794
4795         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
4796         (nbsd_nat_target::info_proc): Add do_cmdline.
4797
4798 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4799
4800         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
4801         (nbsd_nat_target::info_proc): Add do_cwd.
4802
4803 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4804
4805         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
4806
4807 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
4808
4809         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
4810         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
4811         (nbsd_nat_target::info_proc): New functions.
4812         * nbsd-nat.c (kinfo_get_vmmap): New function.
4813         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
4814         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
4815         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
4816         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
4817         functions.
4818         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
4819         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
4820         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
4821         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
4822         (KINFO_VME_FLAG_GROWS_DOWN): New.
4823
4824 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
4825
4826         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
4827         bit shift.
4828
4829 2020-04-10  Tom Tromey  <tromey@adacore.com>
4830
4831         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
4832
4833 2020-04-10  Tom Tromey  <tromey@adacore.com>
4834
4835         * symtab.c (get_symbol_address, get_msymbol_address): Skip
4836         separate debug files.
4837
4838 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
4839
4840         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4841         Move to...
4842         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4843         ... here.
4844         * windows-nat.c (windows_nat_target::get_windows_debug_event):
4845         Check for STATUS_WX86_BREAKPOINT.
4846         (windows_nat_target::wait): Same.
4847
4848 2020-04-10  Tom de Vries  <tdevries@suse.de>
4849
4850         PR cli/25808
4851         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
4852
4853 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4854
4855         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
4856         (Write After Approval): Remove Tom de Vries.
4857
4858 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4859
4860         revert partially:
4861         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4862
4863         * buildsym.c (record_line): Fix undefined behavior and preserve
4864         lines at eof.
4865
4866 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
4867
4868         * auxv.h (svr4_auxv_parse): New.
4869         * auxv.c (default_auxv_parse): Split into default_auxv_parse
4870         and generic_auxv_parse.
4871         (svr4_auxv_parse): Add.
4872         * obsd-tdep.c: Include "auxv.h".
4873         (obsd_auxv_parse): Remove.
4874         (obsd_init_abi): Remove comment.
4875         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
4876         from `obsd_auxv_parse' to `svr4_auxv_parse'.
4877         * nbsd-tdep.c: Include "auxv.h".
4878         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
4879
4880 2020-04-08  Tom Tromey  <tromey@adacore.com>
4881
4882         * nat/windows-nat.h (last_wait_event): Don't declare.
4883         (wait_for_debug_event): Update comment.
4884         * nat/windows-nat.c (last_wait_event): Now static.
4885
4886 2020-04-08  Tom Tromey  <tromey@adacore.com>
4887
4888         * windows-nat.c (wait_for_debug_event): Move to
4889         nat/windows-nat.c.
4890         * nat/windows-nat.h (wait_for_debug_event): Declare.
4891         * nat/windows-nat.c (wait_for_debug_event): Move from
4892         windows-nat.c.  No longer static.
4893
4894 2020-04-08  Tom Tromey  <tromey@adacore.com>
4895
4896         * windows-nat.c (get_windows_debug_event): Use
4897         fetch_pending_stop.
4898         * nat/windows-nat.h (fetch_pending_stop): Declare.
4899         * nat/windows-nat.c (fetch_pending_stop): New function.
4900
4901 2020-04-08  Tom Tromey  <tromey@adacore.com>
4902
4903         * windows-nat.c (windows_continue): Use matching_pending_stop and
4904         continue_last_debug_event.
4905         * nat/windows-nat.h (matching_pending_stop)
4906         (continue_last_debug_event): Declare.
4907         * nat/windows-nat.c (DEBUG_EVENTS): New define.
4908         (matching_pending_stop, continue_last_debug_event): New
4909         functions.
4910
4911 2020-04-08  Tom Tromey  <tromey@adacore.com>
4912
4913         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
4914         (handle_exception_result): Move to nat/windows-nat.h.
4915         (DEBUG_EXCEPTION_SIMPLE): Remove.
4916         (windows_nat::handle_ms_vc_exception): New function.
4917         (handle_exception): Move to nat/windows-nat.c.
4918         (get_windows_debug_event): Update.
4919         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
4920         nat/windows-nat.c.
4921         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
4922         (handle_exception_result): Move from windows-nat.c.
4923         (handle_exception): Declare.
4924         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
4925         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
4926         windows-nat.c.
4927
4928 2020-04-08  Tom Tromey  <tromey@adacore.com>
4929
4930         * windows-nat.c (exception_count, event_count): Remove.
4931         (handle_exception, get_windows_debug_event)
4932         (do_initial_windows_stuff): Update.
4933
4934 2020-04-08  Tom Tromey  <tromey@adacore.com>
4935
4936         * windows-nat.c (windows_nat::handle_load_dll)
4937         (windows_nat::handle_unload_dll): Rename.  No longer static.
4938         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
4939         Declare.
4940
4941 2020-04-08  Tom Tromey  <tromey@adacore.com>
4942
4943         * complaints.h (stop_whining): Declare at top-level.
4944         (complaint): Don't declare stop_whining.
4945
4946 2020-04-08  Tom Tromey  <tromey@adacore.com>
4947
4948         * windows-nat.c (windows_nat::handle_output_debug_string):
4949         Rename.  No longer static.
4950         * nat/windows-nat.h (handle_output_debug_string): Declare.
4951
4952 2020-04-08  Tom Tromey  <tromey@adacore.com>
4953
4954         * windows-nat.c (current_process_handle, current_process_id)
4955         (main_thread_id, last_sig, current_event, last_wait_event)
4956         (current_windows_thread, desired_stop_thread_id, pending_stops)
4957         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
4958         (display_selectors, fake_create_process)
4959         (get_windows_debug_event): Update.
4960         * nat/windows-nat.h (current_process_handle, current_process_id)
4961         (main_thread_id, last_sig, current_event, last_wait_event)
4962         (current_windows_thread, desired_stop_thread_id, pending_stops)
4963         (struct pending_stop, siginfo_er): Move from windows-nat.c.
4964         * nat/windows-nat.c (current_process_handle, current_process_id)
4965         (main_thread_id, last_sig, current_event, last_wait_event)
4966         (current_windows_thread, desired_stop_thread_id, pending_stops)
4967         (siginfo_er): New globals.  Move from windows-nat.c.
4968
4969 2020-04-08  Tom Tromey  <tromey@adacore.com>
4970
4971         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4972         (handle_load_dll): Update.
4973         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4974
4975 2020-04-08  Tom Tromey  <tromey@adacore.com>
4976
4977         * windows-nat.c (enum thread_disposition_type): Move to
4978         nat/windows-nat.h.
4979         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4980         static.
4981         (windows_add_thread, windows_nat_target::fetch_registers)
4982         (windows_nat_target::store_registers, handle_exception)
4983         (windows_nat_target::resume, get_windows_debug_event)
4984         (windows_nat_target::get_tib_address)
4985         (windows_nat_target::thread_name)
4986         (windows_nat_target::thread_alive): Update.
4987         * nat/windows-nat.h (enum thread_disposition_type): Move from
4988         windows-nat.c.
4989         (thread_rec): Declare.
4990
4991 2020-04-08  Tom Tromey  <tromey@adacore.com>
4992
4993         * windows-nat.c: Add "using namespace".
4994         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4995         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4996
4997 2020-04-08  Tom Tromey  <tromey@adacore.com>
4998
4999         * nat/windows-nat.h (struct windows_thread_info): Declare
5000         destructor.
5001         * nat/windows-nat.c (~windows_thread_info): New.
5002
5003 2020-04-08  Tom Tromey  <tromey@adacore.com>
5004
5005         PR gdb/22992
5006         * windows-nat.c (current_event): Update comment.
5007         (last_wait_event, desired_stop_thread_id): New globals.
5008         (struct pending_stop): New.
5009         (pending_stops): New global.
5010         (windows_nat_target) <stopped_by_sw_breakpoint>
5011         <supports_stopped_by_sw_breakpoint>: New methods.
5012         (windows_fetch_one_register): Add assertions.  Adjust PC.
5013         (windows_continue): Handle pending stops.  Suspend other threads
5014         when stepping.  Use last_wait_event
5015         (wait_for_debug_event): New function.
5016         (get_windows_debug_event): Use wait_for_debug_event.  Handle
5017         pending stops.  Queue spurious stops.
5018         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
5019         (windows_nat_target::kill): Use wait_for_debug_event.
5020         * nat/windows-nat.h (struct windows_thread_info)
5021         <stopped_at_software_breakpoint>: New field.
5022         * nat/windows-nat.c (windows_thread_info::resume): Clear
5023         stopped_at_software_breakpoint.
5024
5025 2020-04-08  Tom Tromey  <tromey@adacore.com>
5026
5027         * windows-nat.c (enum thread_disposition_type): New.
5028         (thread_rec): Replace "get_context" parameter with "disposition";
5029         change type.
5030         (windows_add_thread, windows_nat_target::fetch_registers)
5031         (windows_nat_target::store_registers, handle_exception)
5032         (windows_nat_target::resume, get_windows_debug_event)
5033         (windows_nat_target::get_tib_address)
5034         (windows_nat_target::thread_name)
5035         (windows_nat_target::thread_alive): Update.
5036
5037 2020-04-08  Tom Tromey  <tromey@adacore.com>
5038
5039         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
5040         (windows_continue): Use windows_continue::resume.
5041         * nat/windows-nat.h (struct windows_thread_info) <suspend,
5042         resume>: Declare new methods.
5043         * nat/windows-nat.c: New file.
5044         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
5045
5046 2020-04-08  Tom Tromey  <tromey@adacore.com>
5047
5048         * windows-nat.c (windows_add_thread, windows_delete_thread)
5049         (windows_nat_target::fetch_registers)
5050         (windows_nat_target::store_registers, fake_create_process)
5051         (windows_nat_target::resume, windows_nat_target::resume)
5052         (get_windows_debug_event, windows_nat_target::wait)
5053         (windows_nat_target::pid_to_str)
5054         (windows_nat_target::get_tib_address)
5055         (windows_nat_target::get_ada_task_ptid)
5056         (windows_nat_target::thread_name)
5057         (windows_nat_target::thread_alive): Use lwp, not tid.
5058
5059 2020-04-08  Tom Tromey  <tromey@adacore.com>
5060
5061         * windows-nat.c (handle_exception)
5062         (windows_nat_target::thread_name): Update.
5063         * nat/windows-nat.h (windows_thread_info): Remove destructor.
5064         <name>: Now unique_xmalloc_ptr.
5065
5066 2020-04-08  Tom Tromey  <tromey@adacore.com>
5067
5068         * windows-nat.c (thread_rec)
5069         (windows_nat_target::fetch_registers): Update.
5070         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
5071         Update comment.
5072         <debug_registers_changed, reload_context>: Now bool.
5073
5074 2020-04-08  Tom Tromey  <tromey@adacore.com>
5075
5076         * windows-nat.c (windows_add_thread): Use new.
5077         (windows_init_thread_list, windows_delete_thread): Use delete.
5078         (get_windows_debug_event): Update.
5079         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
5080         destructor, and initializers.
5081
5082 2020-04-08  Tom Tromey  <tromey@adacore.com>
5083
5084         * windows-nat.c (struct windows_thread_info): Remove.
5085         * nat/windows-nat.h: New file.
5086
5087 2020-04-08  Tom Tromey  <tromey@adacore.com>
5088
5089         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
5090         (thread_rec, windows_add_thread, windows_delete_thread)
5091         (windows_continue): Update.
5092
5093 2020-04-08  Tom Tromey  <tromey@adacore.com>
5094
5095         * windows-nat.c (struct windows_thread_info): Remove typedef.
5096         (thread_head): Remove.
5097         (thread_list): New global.
5098         (thread_rec, windows_add_thread, windows_init_thread_list)
5099         (windows_delete_thread, windows_continue): Update.
5100
5101 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5102
5103         * windows-tdep.h (windows_init_abi): Add comment.
5104         (cygwin_init_abi): New declaration.
5105         * windows-tdep.c: Split signal enumeration in two, one for
5106         Windows and one for Cygwin.
5107         (windows_gdb_signal_to_target): Only deal with signal of the
5108         Windows OS ABI.
5109         (cygwin_gdb_signal_to_target): New function.
5110         (windows_init_abi): Rename to windows_init_abi_common, don't set
5111         gdb_signal_to_target gdbarch method.  Add new new function with
5112         this name.
5113         (cygwin_init_abi): New function.
5114         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
5115         comment.  Don't call windows_init_abi.
5116         (amd64_windows_init_abi): Add comment, call windows_init_abi.
5117         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
5118         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
5119         i386_windows_init_abi_common, don't call windows_init_abi.  Add
5120         a new function of this name.
5121         (i386_cygwin_init_abi): New function.
5122         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
5123         OS ABI Cygwin.
5124
5125 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5126
5127         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
5128         parameter.c.
5129         (dwarf2_read_gdb_index): Update.
5130
5131 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
5132
5133         * nbsd-tdep.c: Include "objfiles.h".
5134         (nbsd_skip_solib_resolver): New.
5135         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
5136
5137 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5138
5139         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
5140         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
5141         with DW_LLE_base_addressx are being emitted in DWARFv5.
5142         Add the newly added kind DW_LOC_OFFSET_PAIR also.
5143         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
5144         unsigned integer.
5145
5146 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5147
5148         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
5149         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
5150         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
5151         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
5152         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
5153         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
5154         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
5155
5156
5157 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5158
5159         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
5160         (read_loclist_index): New function definition.
5161         (lookup_loclist_base): New function definition.
5162         (read_loclist_header): New function definition.
5163         (dwarf2_cu): Add loclist_base and loclist_header field.
5164         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
5165         (read_full_die_1): Read the value of DW_AT_loclists_base.
5166         (read_attribute_reprocess): Handle DW_FORM_loclistx.
5167         (read_attribute_value): Handle DW_FORM_loclistx.
5168         (skip_one_die): Handle DW_FORM_loclistx.
5169         (loclist_header): New structure declaration.
5170         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
5171
5172 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
5173
5174         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
5175         constructor.  Remove `addr` parameter from other constructor and
5176         add `per_cu` parameter.
5177         * dwarf2/read.c (create_partial_symtab): Update.
5178
5179 2020-04-07  Tom de Vries  <tdevries@suse.de>
5180
5181         PR symtab/25796
5182         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
5183         (partial_die_info::fixup): Inherit has_const_value.
5184
5185 2020-04-07  Tom de Vries  <tdevries@suse.de>
5186
5187         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
5188         symbols without address.
5189
5190 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5191
5192         * nbsd-nat.h (struct thread_info): Add forward declaration.
5193         (nbsd_nat_target::thread_alive): Add.
5194         (nbsd_nat_target::thread_name): Likewise.
5195         (nbsd_nat_target::update_thread_list): Likewise.
5196         (update_thread_list::post_attach): Likewise.
5197         (post_attach::pid_to_str): Likewise.
5198         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
5199         (nbsd_thread_lister): Add.
5200         (nbsd_nat_target::thread_alive): Likewise.
5201         (nbsd_nat_target::thread_name): Likewise.
5202         (nbsd_add_threads): Likewise.
5203         (update_thread_list::post_attach): Likewise.
5204         (nbsd_nat_target::update_thread_list): Likewise.
5205         (post_attach::pid_to_str): Likewise.
5206
5207 2020-04-06  Tom Tromey  <tromey@adacore.com>
5208
5209         * ada-valprint.c (print_variant_part): Extract the variant field.
5210         (print_field_values): Use the field as the outer value when
5211         recursing.
5212
5213 2020-04-06  Tom Tromey  <tromey@adacore.com>
5214
5215         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
5216         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
5217         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
5218         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
5219         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
5220
5221 2020-04-06  Tom Tromey  <tromey@adacore.com>
5222
5223         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
5224         TYPE_CODE_ERROR.
5225
5226 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5227
5228         * nbsd-tdep.c: Include "gdbarch.h".
5229         Define enum with NetBSD signal numbers.
5230         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
5231         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
5232         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
5233         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
5234         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
5235         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
5236         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
5237         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
5238         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
5239         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
5240         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
5241         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
5242
5243 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
5244
5245         PR gdb/25325
5246         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
5247
5248 2020-04-03  Tom Tromey  <tromey@adacore.com>
5249
5250         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
5251         Read constant block.
5252
5253 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5254
5255         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
5256         (gdb_bfd_get_full_section_contents): New declaration.
5257         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
5258         * windows-tdep.c (is_linked_with_cygwin_dll): Use
5259         gdb_bfd_get_full_section_contents.
5260
5261 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5262
5263         * exec.c (build_section_table): Replace internal_error with
5264         gdb_assert.
5265         (section_table_xfer_memory_partial): Likewise.
5266         * mdebugread.c (parse_partial_symbols): Likewise.
5267         * psymtab.c (lookup_partial_symbol): Likewise.
5268         * utils.c (wrap_here): Likewise.
5269
5270 2020-04-02  Tom Tromey  <tromey@adacore.com>
5271
5272         * f-lang.c (build_fortran_types): Use arch_type to initialize
5273         builtin_complex_s32 in the TYPE_CODE_ERROR case.
5274
5275 2020-04-02  Tom Tromey  <tromey@adacore.com>
5276
5277         * dwarf2/read.c (partial_die_info::read): Do not create a vector
5278         of attributes.
5279
5280 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5281             Bernd Edlinger <bernd.edlinger@hotmail.de>
5282             Tom Tromey  <tromey@adacore.com>
5283
5284         * buildsym.c (buildsym_compunit::record_line): Remove
5285         deduplication code.
5286
5287 2020-04-02  Tom de Vries  <tdevries@suse.de>
5288
5289         PR ada/24671
5290         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
5291
5292 2020-04-02  Tom de Vries  <tdevries@suse.de>
5293
5294         * dwarf2/read.c (dwarf2_gdb_index_functions,
5295         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
5296         NULL.
5297         * psymtab.c (psym_lookup_global_symbol_language): New function.
5298         (psym_functions): Init psym_lookup_global_symbol_language with
5299         psym_lookup_global_symbol_language.
5300         * symfile-debug.c (debug_sym_quick_functions): Init
5301         lookup_global_symbol_language with NULL.
5302         * symfile.c (set_initial_language): Remove fixme comment.
5303         * symfile.h (struct quick_symbol_functions): Add
5304         lookup_global_symbol_language.
5305         * symtab.c (find_quick_global_symbol_language): New function.
5306         (find_main_name): Use find_quick_global_symbol_language.
5307
5308 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
5309
5310         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
5311
5312 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5313
5314         * buildsym.c (record_line): Fix undefined behavior and preserve
5315         lines at eof.
5316
5317 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5318
5319         * buildsym.c (record_line): Fix the resizing condition.
5320
5321 2020-04-01  Tom Tromey  <tom@tromey.com>
5322
5323         * value.h (value_literal_complex): Add comment.
5324         * valops.c (value_literal_complex): Refer to value.h.
5325
5326 2020-04-01  Tom Tromey  <tom@tromey.com>
5327
5328         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
5329         (scalar_type): New rule, from typebase.
5330         (typebase): Use scalar_type.  Recognize complex types.
5331         (field_name): Handle FLOAT_KEYWORD.
5332         (ident_tokens): Add _Complex and __complex__.
5333
5334 2020-04-01  Tom Tromey  <tom@tromey.com>
5335
5336         PR exp/25299:
5337         * valarith.c (promotion_type, complex_binop): New functions.
5338         (scalar_binop): Handle complex numbers.  Use promotion_type.
5339         (value_pos, value_neg, value_complement): Handle complex numbers.
5340
5341 2020-04-01  Tom Tromey  <tom@tromey.com>
5342
5343         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
5344         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
5345         (parse_number): Handle complex numbers.
5346
5347 2020-04-01  Tom Tromey  <tom@tromey.com>
5348
5349         * c-valprint.c (c_decorations): Change complex suffix to "i".
5350
5351 2020-04-01  Tom Tromey  <tom@tromey.com>
5352
5353         * valprint.c (generic_value_print_complex): Use accessors.
5354         * value.h (value_real_part, value_imaginary_part): Declare.
5355         * valops.c (value_real_part, value_imaginary_part): New
5356         functions.
5357         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
5358
5359 2020-04-01  Tom Tromey  <tom@tromey.com>
5360
5361         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
5362         (read_range_type): Update.
5363         * mdebugread.c (basic_type): Update.
5364         * go-lang.c (build_go_types): Use init_complex_type.
5365         * gdbtypes.h (struct main_type) <complex_type>: New member.
5366         (init_complex_type): Update.
5367         (arch_complex_type): Don't declare.
5368         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
5369         Make name if none given.  Use alloc_type_copy.  Look for cached
5370         complex type.
5371         (arch_complex_type): Remove.
5372         (gdbtypes_post_init): Use init_complex_type.
5373         * f-lang.c (build_fortran_types): Use init_complex_type.
5374         * dwarf2/read.c (read_base_type): Update.
5375         * d-lang.c (build_d_types): Use init_complex_type.
5376         * ctfread.c (read_base_type): Update.
5377
5378 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5379
5380         * infrun.c (stop_all_threads): Update assertion, plus when
5381         stopping threads, take into account that we might be trying
5382         to stop an all-stop target.
5383         (stop_waiting): Call 'stop_all_threads' if there exists a
5384         non-stop target.
5385
5386 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5387
5388         * target.h (exists_non_stop_target): New function declaration.
5389         * target.c (exists_non_stop_target): New function.
5390
5391 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
5392
5393         PR gdb/24789
5394         * eval.c (is_integral_or_integral_reference): New function.
5395         (evaluate_subexp_standard): Allow integer references in
5396         pointer arithmetic.
5397
5398 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5399
5400         * remote.c (remote_target::remote_parse_stop_reply): Remove the
5401         check for no ptid in the stop reply when the target is non-stop.
5402
5403 2020-04-01  Tom Tromey  <tromey@adacore.com>
5404
5405         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
5406         "name" parameter to rvalue reference.  Initialize m_name_holder.
5407         <lookup_name_info>: New overloads.
5408         <name>: Return gdb::string_view.
5409         <c_str>: New method.
5410         <make_ignore_params>: Update.
5411         <search_name_hash>: Update.
5412         <language_lookup_name>: Return const char *.
5413         <m_name>: Change type.
5414         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
5415         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
5416         (lookup_name_info::match_any): Update.
5417         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
5418         Update.
5419         * minsyms.c (linkage_name_str): Update.
5420         * language.c (default_symbol_name_matcher): Update.
5421         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
5422         Update.
5423         * ada-lang.c (ada_fold_name): Change parameter to string_view.
5424         (ada_lookup_name_info::ada_lookup_name_info): Update.
5425         (literal_symbol_name_matcher): Update.
5426
5427 2020-04-01  Tom Tromey  <tromey@adacore.com>
5428
5429         * psymtab.c (psymtab_search_name): Remove function.
5430         (psym_lookup_symbol): Create search name and lookup name here.
5431         (lookup_partial_symbol): Remove "name" parameter; add
5432         lookup_name.
5433         (psym_expand_symtabs_for_function): Update.
5434
5435 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
5436
5437         PR tui/25597:
5438         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
5439
5440 2020-03-31  Tom Tromey  <tromey@adacore.com>
5441
5442         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
5443         memcpy.
5444
5445 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
5446
5447         * features/riscv/32bit-csr.xml: Regenerated.
5448         * features/riscv/64bit-csr.xml: Regenerated.
5449
5450 2020-03-30  Tom Tromey  <tromey@adacore.com>
5451
5452         * ada-valprint.c (print_variant_part): Update.
5453         * ada-lang.h (ada_which_variant_applies): Update.
5454         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
5455         outer_valaddr parameters; replace with "outer" value parameter.
5456         (to_fixed_variant_branch_type): Update.
5457
5458 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5459
5460         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
5461         <list>.  Remove inclusion of observable.h.
5462         (PPC_DEBUG_CURRENT_VERSION): Move up define.
5463         (struct arch_lwp_info): New struct.
5464         (class ppc_linux_dreg_interface): New class.
5465         (struct ppc_linux_process_info): New struct.
5466         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
5467         <low_new_clone, low_forget_process, low_prepare_to_resume>
5468         <copy_thread_dreg_state, mark_thread_stale>
5469         <mark_debug_registers_changed, register_hw_breakpoint>
5470         <clear_hw_breakpoint, register_wp, clear_wp>
5471         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
5472         <num_memory_accesses, get_trigger_type>
5473         <create_watchpoint_request, hwdebug_point_cmp>
5474         <init_arch_lwp_info, get_arch_lwp_info>
5475         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
5476         methods.
5477         <struct ptid_hash>: New inner struct.
5478         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
5479         members.
5480         (saved_dabr_value, hwdebug_info, max_slots_number)
5481         (struct hw_break_tuple, struct thread_points, ppc_threads)
5482         (have_ptrace_hwdebug_interface)
5483         (hwdebug_find_thread_points_by_tid)
5484         (hwdebug_insert_point, hwdebug_remove_point): Remove.
5485         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
5486         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
5487         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
5488         use m_dreg_interface.
5489         (hwdebug_point_cmp): Change to...
5490         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
5491         reference arguments instead of pointers.
5492         (ppc_linux_nat_target::ranged_break_num_registers): Use
5493         m_dreg_interface.
5494         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
5495         m_dreg_interface.  Call register_hw_breakpoint.
5496         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
5497         m_dreg_interface.  Call clear_hw_breakpoint.
5498         (get_trigger_type): Change to...
5499         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
5500         comment.
5501         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
5502         use m_dreg_interface.  Call register_hw_breakpoint.
5503         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
5504         use m_dreg_interface.  Call clear_hw_breakpoint.
5505         (can_use_watchpoint_cond_accel): Change to...
5506         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
5507         method.  Update comment, use m_dreg_interface and
5508         m_process_info.
5509         (calculate_dvc): Change to...
5510         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
5511         m_dreg_interface.
5512         (num_memory_accesses): Change to...
5513         (ppc_linux_nat_target::num_memory_accesses): ...this method.
5514         (check_condition): Change to...
5515         (ppc_linux_nat_target::check_condition): ...this method.
5516         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
5517         comment, use m_dreg_interface.
5518         (create_watchpoint_request): Change to...
5519         (ppc_linux_nat_target::create_watchpoint_request): ...this
5520         method.  Use m_dreg_interface.
5521         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
5522         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
5523         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
5524         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
5525         (ppc_linux_nat_target::low_forget_process)
5526         (ppc_linux_nat_target::low_new_fork)
5527         (ppc_linux_nat_target::low_new_clone)
5528         (ppc_linux_nat_target::low_delete_thread)
5529         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
5530         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
5531         only call mark_thread_stale.
5532         (ppc_linux_thread_exit): Remove.
5533         (ppc_linux_nat_target::stopped_data_address): Change to...
5534         (ppc_linux_nat_target::low_stopped_data_address): This. Add
5535         comment, use m_dreg_interface and m_thread_hw_breakpoints.
5536         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
5537         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
5538         comment.  Call low_stopped_data_address.
5539         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
5540         m_dreg_interface.
5541         (ppc_linux_nat_target::masked_watch_num_registers): Use
5542         m_dreg_interface.
5543         (ppc_linux_nat_target::copy_thread_dreg_state)
5544         (ppc_linux_nat_target::mark_thread_stale)
5545         (ppc_linux_nat_target::mark_debug_registers_changed)
5546         (ppc_linux_nat_target::register_hw_breakpoint)
5547         (ppc_linux_nat_target::clear_hw_breakpoint)
5548         (ppc_linux_nat_target::register_wp)
5549         (ppc_linux_nat_target::clear_wp)
5550         (ppc_linux_nat_target::init_arch_lwp_info)
5551         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
5552         (_initialize_ppc_linux_nat): Remove observer callback.
5553
5554 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5555
5556         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
5557         (ppc_linux_nat_target::auxv_parse)
5558         (ppc_linux_nat_target::read_description)
5559         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
5560         Move up.
5561
5562 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5563
5564         * linux-nat.h (low_new_clone): New method.
5565         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
5566
5567 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5568
5569         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
5570         (dbx_expand_psymtab): ... this.
5571         (start_psymtab): Update.
5572         * mdebugread.c (psymtab_to_symtab_1): Rename to...
5573         (mdebug_expand_psymtab): ... this.
5574         (parse_partial_symbols): Update.
5575         (new_psymtab): Update.
5576         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
5577         (xcoff_expand_psymtab): ... this.
5578         (xcoff_start_psymtab): Update.
5579
5580 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5581
5582         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
5583         <expand_dependencies>: ... this.
5584         * psymtab.c (partial_symtab::read_dependencies): Rename to...
5585         (partial_symtab::expand_dependencies): ... this.
5586         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
5587         Update.
5588         (dwarf2_psymtab::expand_psymtab): Update.
5589         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5590         * mdebugread.c (psymtab_to_symtab_1): Update.
5591         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5592
5593 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5594
5595         * psympriv.h (discard_psymtab): Remove.
5596         * dbxread.c (dbx_end_psymtab): Update.
5597         * xcoffread.c (xcoff_end_psymtab): Update.
5598
5599 2020-03-28  Tom Tromey  <tom@tromey.com>
5600
5601         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
5602         comment.
5603
5604 2020-03-28  Tom Tromey  <tom@tromey.com>
5605
5606         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
5607
5608 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
5609
5610         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5611
5612 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
5613
5614         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
5615
5616 2020-03-26  Tom Tromey  <tom@tromey.com>
5617
5618         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
5619         (mark_common_block_symbol_computed, read_tag_string_type)
5620         (attr_to_dynamic_prop, read_subrange_type): Update.
5621         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
5622         to be methods on struct attribute.
5623         (skip_one_die, process_imported_unit_die, read_namespace_alias)
5624         (read_call_site_scope, partial_die_info::read)
5625         (partial_die_info::read, lookup_die_type, follow_die_ref):
5626         Update.
5627         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
5628         from dwarf2_get_ref_die_offset.
5629         (attribute::constant_value): New method, from
5630         dwarf2_get_attr_constant_value.
5631         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
5632         Declare method.
5633         <constant_value>: New method.
5634
5635 2020-03-26  Tom Tromey  <tom@tromey.com>
5636
5637         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
5638         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
5639         (dwarf_type_encoding_name): Move to stringify.c.
5640         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
5641         * dwarf2/stringify.c: New file.
5642         * dwarf2/stringify.h: New file.
5643
5644 2020-03-26  Tom Tromey  <tom@tromey.com>
5645
5646         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
5647         Rewrite.
5648
5649 2020-03-26  Tom Tromey  <tom@tromey.com>
5650
5651         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
5652         methods.
5653         * dwarf2/read.c (lookup_addr_base): Move to die.h.
5654         (lookup_ranges_base): Likewise.
5655         (read_cutu_die_from_dwo, read_full_die_1): Update.
5656
5657 2020-03-26  Tom Tromey  <tom@tromey.com>
5658
5659         * dwarf2/read.c (read_import_statement, read_file_scope)
5660         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
5661         (read_lexical_block_scope, read_call_site_scope)
5662         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
5663         (handle_struct_member_die, process_structure_scope)
5664         (update_enumeration_type_from_children)
5665         (process_enumeration_scope, read_array_type, read_common_block)
5666         (read_namespace, read_module, read_subroutine_type): Update.
5667         (sibling_die): Remove.
5668
5669 2020-03-26  Tom Tromey  <tom@tromey.com>
5670
5671         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
5672         (build_type_psymtabs_reader, read_structure_type)
5673         (read_enumeration_type, read_full_die_1): Update.
5674         (dwarf2_attr_no_follow): Move to die.h.
5675         * dwarf2/die.h (struct die_info) <attr>: New method.
5676
5677 2020-03-26  Tom Tromey  <tom@tromey.com>
5678
5679         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
5680         <base_address>: Now an optional.
5681         (dwarf2_find_base_address, dwarf2_rnglists_process)
5682         (dwarf2_ranges_process, fill_in_loclist_baton)
5683         (dwarf2_symbol_mark_computed): Update.
5684
5685 2020-03-26  Tom Tromey  <tom@tromey.com>
5686
5687         * dwarf2/read.c (struct die_info): Move to die.h.
5688         * dwarf2/die.h: New file.
5689
5690 2020-03-26  Tom Tromey  <tom@tromey.com>
5691
5692         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
5693         * dwarf2/read.c
5694         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5695         Move to line-header.c.
5696         (read_checked_initial_length_and_offset, read_formatted_entries):
5697         Likewise.
5698         (dwarf_decode_line_header): Split into two.
5699         * dwarf2/line-header.c
5700         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5701         Move from read.c.
5702         (read_checked_initial_length_and_offset, read_formatted_entries):
5703         Likewise.
5704         (dwarf_decode_line_header): New function, split from read.c.
5705
5706 2020-03-26  Tom Tromey  <tom@tromey.com>
5707
5708         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
5709         Declare method.
5710         * dwarf2/read.c (read_attribute_value): Update.
5711         (dwarf2_per_objfile::read_line_string): Rename from
5712         read_indirect_line_string.
5713         (read_formatted_entries): Update.
5714
5715 2020-03-26  Tom Tromey  <tom@tromey.com>
5716
5717         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
5718         variable.
5719
5720 2020-03-26  Tom Tromey  <tom@tromey.com>
5721
5722         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
5723         const.
5724         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
5725         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
5726         parameter const.
5727
5728 2020-03-26  Tom Tromey  <tom@tromey.com>
5729
5730         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
5731         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
5732         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
5733         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
5734
5735 2020-03-26  Tom Tromey  <tom@tromey.com>
5736
5737         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
5738         file_names_size, file_full_name, file_file_name>: Use const.
5739         <file_name_at, file_names>: Add const overload.
5740         * dwarf2/line-header.c (line_header::file_file_name)
5741         (line_header::file_full_name): Update.
5742
5743 2020-03-26  Tom Tromey  <tom@tromey.com>
5744
5745         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
5746         (macro_start_file, consume_improper_spaces)
5747         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
5748         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
5749         (dwarf_decode_macros): Move to macro.c.
5750         * dwarf2/macro.c: New file.
5751         * dwarf2/macro.h: New file.
5752         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
5753
5754 2020-03-26  Tom Tromey  <tom@tromey.com>
5755
5756         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
5757         method.
5758         * dwarf2/section.c: New method.  From
5759         read_indirect_string_at_offset_from.
5760         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
5761         (read_indirect_string_at_offset_from): Move to section.c.
5762         (read_indirect_string_at_offset): Rewrite.
5763         (read_indirect_line_string_at_offset): Remove.
5764         (read_indirect_string, read_indirect_line_string)
5765         (dwarf_decode_macro_bytes): Update.
5766
5767 2020-03-26  Tom Tromey  <tom@tromey.com>
5768
5769         * dwarf2/section.h (struct dwarf2_section_info)
5770         <overload_complaint>: Declare.
5771         (dwarf2_section_buffer_overflow_complaint): Don't declare.
5772         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
5773         Rename from dwarf2_section_buffer_overflow_complaint.
5774         * dwarf2/read.c (skip_one_die, partial_die_info::read)
5775         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
5776
5777 2020-03-26  Tom Tromey  <tom@tromey.com>
5778
5779         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
5780         Declare.
5781         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
5782         Move from read.c.
5783         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
5784         to section.c.
5785
5786 2020-03-26  Tom Tromey  <tom@tromey.com>
5787
5788         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
5789
5790 2020-03-26  Tom Tromey  <tom@tromey.com>
5791
5792         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
5793         "builder".
5794         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
5795         parameter.
5796         (dwarf_decode_macros): Update.
5797
5798 2020-03-26  Tom Tromey  <tom@tromey.com>
5799
5800         * dwarf2/read.c (read_attribute_value): Update.
5801         (read_indirect_string_from_dwz): Move to dwz.c; change into
5802         method.
5803         (dwarf_decode_macro_bytes): Update.
5804         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
5805         * dwarf2/dwz.c: New file.
5806         * Makefile.in (COMMON_SFILES): Add dwz.c.
5807
5808 2020-03-26  Tom Tromey  <tom@tromey.com>
5809
5810         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
5811         * dwarf2/read.c: Add include.
5812         * dwarf2/index-write.c: Add include.
5813         * dwarf2/index-cache.c: Add include.
5814         * dwarf2/dwz.h: New file.
5815
5816 2020-03-25  Tom Tromey  <tom@tromey.com>
5817
5818         * compile/compile-object-load.c (get_out_value_type): Mention
5819         correct symbol name in error message.
5820
5821 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
5822
5823         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5824
5825 2020-03-25  Tom de Vries  <tdevries@suse.de>
5826
5827         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
5828         * symmisc.c (dump_symtab_1): Print user and includes fields.
5829         (maintenance_info_symtabs): Same.
5830
5831 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
5832
5833         PR gdb/25534
5834         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
5835         (riscv_regcache_cooked_write): New function.
5836         (riscv_push_dummy_call): Use new function.
5837         (riscv_return_value): Likewise.
5838
5839 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
5840
5841         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
5842         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
5843         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
5844         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
5845         * infrun.c (follow_fork): Likewise.
5846         (follow_fork_inferior): Likewise.
5847         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
5848         * linux-nat.h (class linux_nat_target): Likewise.
5849         * remote.c (class remote_target) <follow_fork>: Likewise.
5850         (remote_target::follow_fork): Likewise.
5851         * target-delegates.c: Re-generate.
5852         * target.c (default_follow_fork): Likewise.
5853         (target_follow_fork): Likewise.
5854         * target.h (struct target_ops) <follow_fork>: Likewise.
5855         (target_follow_fork): Likewise.
5856
5857 2020-03-24  Tom de Vries  <tdevries@suse.de>
5858
5859         * psymtab.c (maintenance_info_psymtabs): Print user field.
5860
5861 2020-03-20  Tom Tromey  <tromey@adacore.com>
5862
5863         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
5864         const.
5865         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
5866         const.
5867
5868 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
5869
5870         * ptrace.m4: Don't check for ptrace declaration.
5871         * config.in: Re-generate.
5872         * configure: Re-generate.
5873         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
5874         not defined.
5875
5876 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5877
5878         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
5879         `PTRACE_TYPE_RET'.
5880         * i386-bsd-nat.c (gdb_ptrace): Likewise.
5881         * sparc-nat.c (gdb_ptrace): Likewise.
5882         * x86-bsd-nat.c (gdb_ptrace): Likewise.
5883
5884 2020-03-20  Tom Tromey  <tromey@adacore.com>
5885
5886         * c-exp.y (lex_one_token): Fix assert.
5887
5888 2020-03-20  Tom Tromey  <tromey@adacore.com>
5889
5890         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
5891         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
5892         strncpy call.
5893
5894 2020-03-20  Tom Tromey  <tromey@adacore.com>
5895
5896         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
5897
5898 2020-03-20  Tom Tromey  <tromey@adacore.com>
5899
5900         * ada-valprint.c (print_variant_part): Remove parameters; switch
5901         to value-based API.
5902         (print_field_values): Likewise.
5903         (ada_val_print_struct_union): Likewise.
5904         (ada_value_print_1): Update.
5905
5906 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5907
5908         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
5909         nbsd_nat_target instead of inf_ptrace_target.
5910         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5911         nbsd_nat_target.
5912
5913 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5914
5915         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
5916         it to the ptrace call.
5917         * (store_registers): Likewise.
5918
5919 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5920
5921         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
5922         it to the ptrace call.
5923         * (store_registers): Likewise.
5924
5925 2020-03-19  Luis Machado  <luis.machado@linaro.org>
5926
5927         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
5928         valid, fetch vg value from ptrace.
5929
5930 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5931         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
5932         * inf-ptrace.c: Likewise.
5933         * (gdb_ptrace): Add.
5934         * (inf_ptrace_target::resume): Update.
5935         * (inf_ptrace_target::xfer_partial): Likewise.
5936         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
5937         * (inf_ptrace_peek_poke): Update.
5938
5939 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5940
5941         * x86-bsd-nat.c (gdb_ptrace): New.
5942         * (x86bsd_dr_set): Add new argument `ptid'.
5943         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
5944         x86bsd_dr_set_addr): Update.
5945
5946 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5947
5948         * remote.c (remote_target::process_stop_reply): Handle events for
5949         all threads differently.
5950
5951 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5952
5953         * completer.c (completion_tracker::remove_completion): Define new
5954         function.
5955         * completer.h (completion_tracker::remove_completion): Declare new
5956         function.
5957         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
5958         when adding a C++ function symbol.
5959
5960 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * completer.c (completion_tracker::completion_hash_entry): Define
5963         new class.
5964         (advance_to_filename_complete_word_point): Call
5965         recompute_lowest_common_denominator.
5966         (completion_tracker::completion_tracker): Call discard_completions
5967         to setup the hash table.
5968         (completion_tracker::discard_completions): Allow for being called
5969         from the constructor, pass new equal function, and element deleter
5970         when constructing the hash table.  Initialise new class member
5971         variables.
5972         (completion_tracker::maybe_add_completion): Remove use of
5973         m_entries_vec, and store more information into m_entries_hash.
5974         (completion_tracker::recompute_lcd_visitor): New function, most
5975         content taken from...
5976         (completion_tracker::recompute_lowest_common_denominator):
5977         ...here, this now just visits each item in the hash calling the
5978         above visitor.
5979         (completion_tracker::build_completion_result): Remove use of
5980         m_entries_vec, call recompute_lowest_common_denominator.
5981         * completer.h (completion_tracker::have_completions): Remove use
5982         of m_entries_vec.
5983         (completion_tracker::completion_hash_entry): Declare new class.
5984         (completion_tracker::recompute_lowest_common_denominator): Change
5985         function signature.
5986         (completion_tracker::recompute_lcd_visitor): Declare new function.
5987         (completion_tracker::m_entries_vec): Delete.
5988         (completion_tracker::m_entries_hash): Initialize to NULL.
5989         (completion_tracker::m_lowest_common_denominator_valid): New
5990         member variable.
5991         (completion_tracker::m_lowest_common_denominator_max_length): New
5992         member variable.
5993
5994 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5995
5996         * regformats/regdef.h: Put reg in gdb namespace.
5997
5998 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5999
6000         * i386-bsd-nat.c (gdb_ptrace): New.
6001         * (i386bsd_fetch_inferior_registers,
6002         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
6003         * (i386bsd_fetch_inferior_registers,
6004         i386bsd_store_inferior_registers) Use gdb_ptrace.
6005
6006 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6007
6008         * amd64-bsd-nat.c (gdb_ptrace): New.
6009         * (amd64bsd_fetch_inferior_registers,
6010         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
6011         * (amd64bsd_fetch_inferior_registers,
6012         amd64bsd_store_inferior_registers) Use gdb_ptrace.
6013
6014 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6015
6016         * user-regs.c (user_reg::read): Rename to...
6017         (user_reg::xread): ...this.
6018         * (append_user_reg): Rename argument `read' to `xread'.
6019         * (user_reg_add_builtin): Likewise.
6020         * (user_reg_add): Likewise.
6021         * (value_of_user_reg): Likewise.
6022
6023 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6024
6025         * sparc-nat.c (gdb_ptrace): New.
6026         * sparc-nat.c (sparc_fetch_inferior_registers)
6027         (sparc_store_inferior_registers) Remove obsolete comment.
6028         * sparc-nat.c (sparc_fetch_inferior_registers)
6029         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
6030         * sparc-nat.c (sparc_fetch_inferior_registers)
6031         (sparc_store_inferior_registers) Use gdb_ptrace.
6032
6033 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6034
6035         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
6036         it to the ptrace call.
6037         * sh-nbsd-nat.c (store_registers): Likewise.
6038
6039 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6040
6041         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
6042         nbsd_nat_target instead of inf_ptrace_target.
6043         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6044         nbsd_nat_target.
6045
6046 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6047
6048         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
6049
6050 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6051
6052         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
6053         <sys/sysctl.h>.
6054         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
6055
6056 2020-03-17  Tom de Vries  <tdevries@suse.de>
6057
6058         PR gdb/23710
6059         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
6060         fields.
6061         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
6062         fields.
6063         (process_imported_unit_die): Skip import of c++ CUs.
6064
6065 2020-03-16  Tom Tromey  <tom@tromey.com>
6066
6067         * p-valprint.c (pascal_object_print_value): Initialize
6068         base_value.
6069
6070 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
6071             Shahab Vahedi  <shahab@synopsys.com>
6072
6073         * Makefile.in: Add arch/arc.o
6074         * configure.tgt: Likewise.
6075         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
6076         (_initialize_arc_tdep): Don't initialize old target descriptions.
6077         (arc_read_description): New function to cache target descriptions.
6078         * arc-tdep.h (arc_read_description): Add proto type.
6079         * arch/arc.c: New file.
6080         * arch/arc.h: Likewise.
6081         * features/Makefile: Replace old target descriptions with new.
6082         * features/arc-arcompact.c: Remove.
6083         * features/arc-arcompact.xml: Likewise.
6084         * features/arc-v2.c: Likewise
6085         * features/arc-v2.xml: Likewise
6086         * features/arc/aux-arcompact.xml: New file.
6087         * features/arc/aux-v2.xml: Likewise.
6088         * features/arc/core-arcompact.xml: Likewise.
6089         * features/arc/core-v2.xml: Likewise.
6090         * features/arc/aux-arcompact.c: Generate.
6091         * features/arc/aux-v2.c: Likewise.
6092         * features/arc/core-arcompact.c: Likewise.
6093         * features/arc/core-v2.c: Likewise.
6094         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
6095
6096 2020-03-16  Tom Tromey  <tromey@adacore.com>
6097
6098         PR gdb/25663:
6099         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
6100         putting value into bcache.
6101
6102 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6103
6104         PR gdb/21500
6105         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
6106         to...
6107         (amd64_windows_init_abi_common): ... this.  Don't set size of
6108         long type.
6109         (amd64_windows_init_abi): New function.
6110         (amd64_cygwin_init_abi): New function.
6111         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
6112         the Cygwin OS ABI.
6113         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
6114         comment.
6115
6116 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6117
6118         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
6119         * windows-tdep.c (CYGWIN_DLL_NAME): New.
6120         (pe_import_directory_entry): New struct type.
6121         (is_linked_with_cygwin_dll): New function.
6122         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
6123         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
6124         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
6125
6126 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6127
6128         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
6129         i386_cygwin_core_osabi_sniffer.
6130
6131 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6132
6133         * i386-cygwin-tdep.c: Rename to...
6134         * i386-windows-tdep.c: ... this.
6135         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
6136         i386-windows-tdep.c.
6137         * configure.tgt: Likewise.
6138
6139 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6140
6141         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
6142         * osabi.c (gdb_osabi_names): Add "Windows".
6143         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
6144         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
6145         (i386_cygwin_core_osabi_sniffer): New function, extracted from
6146         i386_cygwin_osabi_sniffer.
6147         (_initialize_i386_cygwin_tdep): Register OS ABI
6148         GDB_OSABI_WINDOWS for i386.
6149         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
6150         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
6151         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
6152         for x86-64.
6153         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
6154         when the target matches '*-*-mingw*'.
6155
6156 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6157
6158         * defs.h (enum gdb_osabi): Move to...
6159         * osabi.h (enum gdb_osabi): ... here.
6160         * gdbarch.sh: Include osabi.h in gdbarch.h.
6161         * gdbarch.h: Re-generate.
6162
6163 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6164
6165         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
6166         function.
6167         (_initialize_amd64_windows_tdep): Register osabi sniffer.
6168
6169 2020-03-14  Tom Tromey  <tom@tromey.com>
6170
6171         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
6172         for C++.
6173         (c_type_print_modifier): Likewise.  Add "language" parameter.
6174         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
6175         (c_type_print_base_1): Update.
6176         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
6177         constants.
6178         * type-stack.c (type_stack::insert): Handle tp_atomic and
6179         tp_restrict.
6180         (type_stack::follow_type_instance_flags): Likewise.
6181         (type_stack::follow_types): Likewise.  Merge type-following code.
6182         * c-exp.y (RESTRICT, ATOMIC): New tokens.
6183         (space_identifier, cv_with_space_id)
6184         (const_or_volatile_or_space_identifier_noopt)
6185         (const_or_volatile_or_space_identifier): Remove.
6186         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
6187         rules.
6188         (ptr_operator, typebase): Update.
6189         (enum token_flag) <FLAG_C>: New constant.
6190         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
6191         "_Atomic".
6192         (lex_one_token): Handle FLAG_C.
6193
6194 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6195
6196         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
6197         it to the ptrace call.
6198         * m68k-bsd-nat.c (store_registers): Likewise.
6199
6200 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6201
6202         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
6203         gdb_byte *.
6204         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
6205         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
6206         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
6207
6208 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6209
6210         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
6211         nbsd_nat_target instead of inf_ptrace_target.
6212         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6213         nbsd_nat_target.
6214
6215 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6216
6217         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
6218         register_t.
6219
6220 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6221
6222         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
6223         it to the ptrace call.
6224         * alpha-bsd-nat.c (store_registers): Likewise.
6225
6226 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6227
6228         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
6229         includes.
6230         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
6231         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
6232         fill_fpregset): Likewise.
6233
6234 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6235
6236         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
6237         nbsd_nat_target instead of inf_ptrace_target.
6238         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6239         nbsd_nat_target.
6240
6241 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6242
6243         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
6244         register_t.
6245
6246 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6247
6248         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
6249         it to the ptrace call.
6250         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
6251         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
6252         * arm-nbsd-nat.c (store_register): Likewise.
6253         * arm-nbsd-nat.c (store_regs): Likewise.
6254         * arm-nbsd-nat.c (store_fp_register): Likewise.
6255         * arm-nbsd-nat.c (store_fp_regs): Likewise.
6256
6257 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6258
6259         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
6260         nbsd_nat_target instead of inf_ptrace_target.
6261         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6262         nbsd_nat_target.
6263
6264 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6265
6266         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
6267         it to the ptrace call.
6268         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
6269
6270 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6271
6272         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
6273         it to the ptrace call.
6274         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
6275
6276 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6277
6278         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
6279         gdb_byte *.
6280         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
6281
6282 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6283
6284         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
6285         instead of inf_ptrace_target.
6286         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6287         nbsd_nat_target.
6288
6289 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6290
6291         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6292         register_t.
6293
6294 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6295
6296         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6297         register_t.
6298
6299 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6300
6301         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
6302         register_t.
6303
6304 2020-03-13  Tom Tromey  <tom@tromey.com>
6305
6306         * value.h (val_print): Don't declare.
6307         * valprint.h (val_print_array_elements)
6308         (val_print_scalar_formatted, generic_val_print): Don't declare.
6309         * valprint.c (generic_val_print_array): Take a struct value.
6310         (generic_val_print_ptr, generic_val_print_memberptr)
6311         (generic_val_print_bool, generic_val_print_int)
6312         (generic_val_print_char, generic_val_print_complex)
6313         (generic_val_print): Remove.
6314         (generic_value_print): Update.
6315         (do_val_print): Remove unused parameters.  Don't call
6316         la_val_print.
6317         (val_print): Remove.
6318         (common_val_print): Update.  Don't call value_check_printable.
6319         (val_print_scalar_formatted, val_print_array_elements): Remove.
6320         * rust-lang.c (rust_val_print): Remove.
6321         (rust_language_defn): Update.
6322         * p-valprint.c (pascal_val_print): Remove.
6323         (pascal_value_print_inner): Update.
6324         (pascal_object_print_val_fields, pascal_object_print_val):
6325         Remove.
6326         (pascal_object_print_static_field): Update.
6327         * p-lang.h (pascal_val_print): Don't declare.
6328         * p-lang.c (pascal_language_defn): Update.
6329         * opencl-lang.c (opencl_language_defn): Update.
6330         * objc-lang.c (objc_language_defn): Update.
6331         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
6332         * m2-lang.h (m2_val_print): Don't declare.
6333         * m2-lang.c (m2_language_defn): Update.
6334         * language.h (struct language_defn) <la_val_print>: Remove.
6335         * language.c (unk_lang_value_print_inner): Rename.  Change
6336         argument types.
6337         (unknown_language_defn, auto_language_defn): Update.
6338         * go-valprint.c (go_val_print): Remove.
6339         * go-lang.h (go_val_print): Don't declare.
6340         * go-lang.c (go_language_defn): Update.
6341         * f-valprint.c (f_val_print): Remove.
6342         * f-lang.h (f_value_print): Don't declare.
6343         * f-lang.c (f_language_defn): Update.
6344         * d-valprint.c (d_val_print): Remove.
6345         * d-lang.h (d_value_print): Don't declare.
6346         * d-lang.c (d_language_defn): Update.
6347         * cp-valprint.c (cp_print_value_fields)
6348         (cp_print_value_fields_rtti, cp_print_value): Remove.
6349         (cp_print_static_field): Update.
6350         * c-valprint.c (c_val_print_array, c_val_print_ptr)
6351         (c_val_print_struct, c_val_print_union, c_val_print_int)
6352         (c_val_print_memberptr, c_val_print): Remove.
6353         * c-lang.h (c_val_print_array, cp_print_value_fields)
6354         (cp_print_value_fields_rtti): Don't declare.
6355         * c-lang.c (c_language_defn, cplus_language_defn)
6356         (asm_language_defn, minimal_language_defn): Update.
6357         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
6358         (ada_val_print_enum): Take a struct value.
6359         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
6360         (ada_val_print): Remove.
6361         (ada_value_print_1): Update.
6362         (printable_val_type): Remove.
6363         * ada-lang.h (ada_val_print): Don't declare.
6364         * ada-lang.c (ada_language_defn): Update.
6365
6366 2020-03-13  Tom Tromey  <tom@tromey.com>
6367
6368         * valprint.c (do_val_print): Update.
6369         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
6370         a struct value.
6371         (value_to_value_object_no_release): Declare.
6372         * python/py-value.c (value_to_value_object_no_release): New
6373         function.
6374         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
6375         struct value.
6376         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
6377         function.
6378         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
6379         a struct value.
6380         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
6381         Declare.
6382         (gdbscm_apply_val_pretty_printer): Take a struct value.
6383         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
6384         value.
6385         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
6386         value.
6387         * extension-priv.h (struct extension_language_ops)
6388         <apply_val_pretty_printer>: Take a struct value.
6389         * cp-valprint.c (cp_print_value): Create a struct value.
6390         (cp_print_value): Update.
6391
6392 2020-03-13  Tom Tromey  <tom@tromey.com>
6393
6394         * ada-valprint.c (print_field_values): Call common_val_print.
6395
6396 2020-03-13  Tom Tromey  <tom@tromey.com>
6397
6398         * ada-valprint.c (val_print_packed_array_elements): Remove
6399         bitoffset and val parameters.  Call common_val_print.
6400         (ada_val_print_string): Remove offset, address, and original_value
6401         parameters.
6402         (ada_val_print_array): Update.
6403         (ada_value_print_array): New function.
6404         (ada_value_print_1): Call it.
6405
6406 2020-03-13  Tom Tromey  <tom@tromey.com>
6407
6408         * ada-valprint.c (ada_value_print): Use common_val_print.
6409
6410 2020-03-13  Tom Tromey  <tom@tromey.com>
6411
6412         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
6413
6414 2020-03-13  Tom Tromey  <tom@tromey.com>
6415
6416         * ada-valprint.c (ada_value_print_num): New function.
6417         (ada_value_print_1): Use it.
6418
6419 2020-03-13  Tom Tromey  <tom@tromey.com>
6420
6421         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
6422
6423 2020-03-13  Tom Tromey  <tom@tromey.com>
6424
6425         * ada-valprint.c (ada_value_print_ptr): New function.
6426         (ada_value_print_1): Use it.
6427
6428 2020-03-13  Tom Tromey  <tom@tromey.com>
6429
6430         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
6431         call common_val_print.
6432         (ada_val_print_1): Update.
6433         (ada_value_print_1): New function.
6434         (ada_value_print_inner): Rewrite.
6435
6436 2020-03-13  Tom Tromey  <tom@tromey.com>
6437
6438         * cp-valprint.c (cp_print_value_fields): Update.
6439         (cp_print_value): New function.
6440
6441 2020-03-13  Tom Tromey  <tom@tromey.com>
6442
6443         * m2-valprint.c (m2_value_print_inner): Use
6444         cp_print_value_fields.
6445         * cp-valprint.c (cp_print_value_fields): New function.
6446         * c-valprint.c (c_value_print_struct): New function.
6447         (c_value_print_inner): Use c_value_print_struct.
6448         * c-lang.h (cp_print_value_fields): Declare.
6449
6450 2020-03-13  Tom Tromey  <tom@tromey.com>
6451
6452         * c-valprint.c (c_value_print_array): New function.
6453         (c_value_print_inner): Use it.
6454
6455 2020-03-13  Tom Tromey  <tom@tromey.com>
6456
6457         * c-valprint.c (c_value_print_memberptr): New function.
6458         (c_value_print_inner): Use it.
6459
6460 2020-03-13  Tom Tromey  <tom@tromey.com>
6461
6462         * c-valprint.c (c_value_print_int): New function.
6463         (c_value_print_inner): Use it.
6464
6465 2020-03-13  Tom Tromey  <tom@tromey.com>
6466
6467         * c-valprint.c (c_value_print_ptr): New function.
6468         (c_value_print_inner): Use it.
6469
6470 2020-03-13  Tom Tromey  <tom@tromey.com>
6471
6472         * c-valprint.c (c_value_print_inner): Rewrite.
6473
6474 2020-03-13  Tom Tromey  <tom@tromey.com>
6475
6476         * valprint.c (generic_value_print_complex): New function.
6477         (generic_value_print): Use it.
6478
6479 2020-03-13  Tom Tromey  <tom@tromey.com>
6480
6481         * valprint.c (generic_val_print_float): Don't call
6482         val_print_scalar_formatted.
6483         (generic_val_print, generic_value_print): Update.
6484
6485 2020-03-13  Tom Tromey  <tom@tromey.com>
6486
6487         * valprint.c (generic_value_print_char): New function
6488         (generic_value_print): Use it.
6489
6490 2020-03-13  Tom Tromey  <tom@tromey.com>
6491
6492         * valprint.c (generic_value_print_int): New function.
6493         (generic_value_print): Use it.
6494
6495 2020-03-13  Tom Tromey  <tom@tromey.com>
6496
6497         * valprint.c (generic_value_print_bool): New function.
6498         (generic_value_print): Use it.
6499
6500 2020-03-13  Tom Tromey  <tom@tromey.com>
6501
6502         * valprint.c (generic_val_print_func): Simplify.
6503         (generic_val_print, generic_value_print): Update.
6504
6505 2020-03-13  Tom Tromey  <tom@tromey.com>
6506
6507         * valprint.c (generic_val_print_flags): Remove.
6508         (generic_val_print, generic_value_print): Update.
6509         (val_print_type_code_flags): Add original_value parameter.
6510
6511 2020-03-13  Tom Tromey  <tom@tromey.com>
6512
6513         * valprint.c (generic_val_print): Update.
6514         (generic_value_print): Update.
6515         * valprint.c (generic_val_print_enum): Don't call
6516         val_print_scalar_formatted.
6517
6518 2020-03-13  Tom Tromey  <tom@tromey.com>
6519
6520         * valprint.c (generic_value_print): Call generic_value_print_ptr.
6521         * valprint.c (generic_value_print_ptr): New function.
6522
6523 2020-03-13  Tom Tromey  <tom@tromey.com>
6524
6525         * valprint.c (generic_value_print): Rewrite.
6526
6527 2020-03-13  Tom Tromey  <tom@tromey.com>
6528
6529         * p-valprint.c (pascal_object_print_value_fields)
6530         (pascal_object_print_value): New functions.
6531
6532 2020-03-13  Tom Tromey  <tom@tromey.com>
6533
6534         * p-valprint.c (pascal_value_print_inner): Rewrite.
6535
6536 2020-03-13  Tom Tromey  <tom@tromey.com>
6537
6538         * f-valprint.c (f_value_print_innner): Rewrite.
6539
6540 2020-03-13  Tom Tromey  <tom@tromey.com>
6541
6542         * m2-valprint.c (m2_print_unbounded_array): New overload.
6543         (m2_print_unbounded_array): Update.
6544         (m2_print_array_contents): Take a struct value.
6545         (m2_value_print_inner): Rewrite.
6546
6547 2020-03-13  Tom Tromey  <tom@tromey.com>
6548
6549         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
6550         (d_value_print_inner): New function.
6551         * d-lang.h (d_value_print_inner): Declare.
6552         * d-lang.c (d_language_defn): Use d_value_print_inner.
6553
6554 2020-03-13  Tom Tromey  <tom@tromey.com>
6555
6556         * go-valprint.c (go_value_print_inner): New function.
6557         * go-lang.h (go_value_print_inner): Declare.
6558         * go-lang.c (go_language_defn): Use go_value_print_inner.
6559
6560 2020-03-13  Tom Tromey  <tom@tromey.com>
6561
6562         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
6563         API.
6564         (rust_val_print): Rewrite.
6565         (rust_value_print_inner): New function, from rust_val_print.
6566         (rust_language_defn): Use rust_value_print_inner.
6567
6568 2020-03-13  Tom Tromey  <tom@tromey.com>
6569
6570         * ada-valprint.c (ada_value_print_inner): New function.
6571         * ada-lang.h (ada_value_print_inner): Declare.
6572         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
6573
6574 2020-03-13  Tom Tromey  <tom@tromey.com>
6575
6576         * f-valprint.c (f_value_print_innner): New function.
6577         * f-lang.h (f_value_print_innner): Declare.
6578         * f-lang.c (f_language_defn): Use f_value_print_innner.
6579
6580 2020-03-13  Tom Tromey  <tom@tromey.com>
6581
6582         * p-valprint.c (pascal_value_print_inner): New function.
6583         * p-lang.h (pascal_value_print_inner): Declare.
6584         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
6585
6586 2020-03-13  Tom Tromey  <tom@tromey.com>
6587
6588         * m2-valprint.c (m2_value_print_inner): New function.
6589         * m2-lang.h (m2_value_print_inner): Declare.
6590         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
6591
6592 2020-03-13  Tom Tromey  <tom@tromey.com>
6593
6594         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
6595         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
6596         * c-valprint.c (c_value_print_inner): New function.
6597         * c-lang.h (c_value_print_inner): Declare.
6598         * c-lang.c (c_language_defn, cplus_language_defn)
6599         (asm_language_defn, minimal_language_defn): Use
6600         c_value_print_inner.
6601
6602 2020-03-13  Tom Tromey  <tom@tromey.com>
6603
6604         * p-valprint.c (pascal_object_print_value_fields): Now static.
6605         * p-lang.h (pascal_object_print_value_fields): Don't declare.
6606
6607 2020-03-13  Tom Tromey  <tom@tromey.com>
6608
6609         * c-valprint.c (c_val_print_array): Simplify.
6610
6611 2020-03-13  Tom Tromey  <tom@tromey.com>
6612
6613         * valprint.c (value_print_array_elements): New function.
6614         * valprint.h (value_print_array_elements): Declare.
6615
6616 2020-03-13  Tom Tromey  <tom@tromey.com>
6617
6618         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
6619         * mips-tdep.c (mips_print_register): Use
6620         value_print_scalar_formatted.
6621
6622 2020-03-13  Tom Tromey  <tom@tromey.com>
6623
6624         * valprint.h (value_print_scalar_formatted): Declare.
6625         * valprint.c (value_print_scalar_formatted): New function.
6626
6627 2020-03-13  Tom Tromey  <tom@tromey.com>
6628
6629         * valprint.h (generic_value_print): Declare.
6630         * valprint.c (generic_value_print): New function.
6631
6632 2020-03-13  Tom Tromey  <tom@tromey.com>
6633
6634         * valprint.c (do_val_print): Call la_value_print_inner, if
6635         available.
6636         * rust-lang.c (rust_language_defn): Update.
6637         * p-lang.c (pascal_language_defn): Update.
6638         * opencl-lang.c (opencl_language_defn): Update.
6639         * objc-lang.c (objc_language_defn): Update.
6640         * m2-lang.c (m2_language_defn): Update.
6641         * language.h (struct language_defn) <la_value_print_inner>: New
6642         member.
6643         * language.c (unknown_language_defn, auto_language_defn): Update.
6644         * go-lang.c (go_language_defn): Update.
6645         * f-lang.c (f_language_defn): Update.
6646         * d-lang.c (d_language_defn): Update.
6647         * c-lang.c (c_language_defn, cplus_language_defn)
6648         (asm_language_defn, minimal_language_defn): Update.
6649         * ada-lang.c (ada_language_defn): Update.
6650
6651 2020-03-13  Tom Tromey  <tom@tromey.com>
6652
6653         * c-valprint.c (c_value_print): Use common_val_print.
6654
6655 2020-03-13  Tom Tromey  <tom@tromey.com>
6656
6657         * cp-valprint.c (cp_print_static_field): Use common_val_print.
6658
6659 2020-03-13  Tom Tromey  <tom@tromey.com>
6660
6661         * f-valprint.c (f77_print_array_1, f_val_print): Use
6662         common_val_print.
6663
6664 2020-03-13  Tom Tromey  <tom@tromey.com>
6665
6666         * riscv-tdep.c (riscv_print_one_register_info): Use
6667         common_val_print.
6668
6669 2020-03-13  Tom Tromey  <tom@tromey.com>
6670
6671         * mi/mi-main.c (output_register): Use common_val_print.
6672
6673 2020-03-13  Tom Tromey  <tom@tromey.com>
6674
6675         * infcmd.c (default_print_one_register_info): Use
6676         common_val_print.
6677
6678 2020-03-13  Tom Tromey  <tom@tromey.com>
6679
6680         * valprint.h (common_val_print_checked): Declare.
6681         * valprint.c (common_val_print_checked): New function.
6682         * stack.c (print_frame_arg): Use common_val_print_checked.
6683
6684 2020-03-13  Tom Tromey  <tom@tromey.com>
6685
6686         * valprint.c (do_val_print): New function, from val_print.
6687         (val_print): Use do_val_print.
6688         (common_val_print): Use do_val_print.
6689
6690 2020-03-13  Tom Tromey  <tom@tromey.com>
6691
6692         * valprint.c (value_print): Use scoped_value_mark.
6693
6694 2020-03-13  Tom de Vries  <tdevries@suse.de>
6695
6696         PR symtab/25646
6697         * psymtab.c (partial_symtab::partial_symtab): Don't set
6698         globals_offset and statics_offset.  Push element onto
6699         current_global_psymbols and current_static_psymbols stacks.
6700         (concat): New function.
6701         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
6702         element from current_global_psymbols and current_static_psymbols
6703         stacks.  Concat popped elements to global_psymbols and
6704         static_symbols.
6705         (add_psymbol_to_list): Use current_global_psymbols and
6706         current_static_psymbols stacks.
6707         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
6708         current_static_psymbols fields.
6709
6710 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6711
6712         * corelow.c (sniff_core_bfd): Remove.
6713         (class core_target) <m_core_vec>: Remove.
6714         (core_target::core_target): Update.
6715         (core_file_fns): Remove.
6716         (deprecated_add_core_fns): Remove.
6717         (default_core_sniffer): Remove.
6718         (sniff_core_bfd): Remove.
6719         (default_check_format): Remove.
6720         (gdb_check_format): Remove.
6721         (core_target_open): Update.
6722         (core_target::get_core_register_section): Update.
6723         (get_core_registers_cb): Update.
6724         (core_target::fetch_registers): Update.
6725         * gdbcore.h (struct core_fns): Remove.
6726         (deprecated_add_core_fns): Remove.
6727         (default_core_sniffer): Remove.
6728         (default_check_format): Remove.
6729
6730 2020-03-12  Tom Tromey  <tom@tromey.com>
6731
6732         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
6733         CORE_ADDR.
6734         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
6735
6736 2020-03-12  Tom Tromey  <tom@tromey.com>
6737
6738         * remote.c (remote_target::download_tracepoint)
6739         (remote_target::enable_tracepoint)
6740         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
6741         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
6742         sprintf_vma.
6743
6744 2020-03-12  Tom Tromey  <tom@tromey.com>
6745
6746         * symfile-mem.c: Update CORE_ADDR size assert.
6747
6748 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6749
6750         * selftest.m4: Move to gdbsupport/.
6751         * acinclude.m4: Update path to selftest.m4.
6752
6753 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6754
6755         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
6756         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
6757         gdbarch-selfselftests.c and selftest-arch.c.
6758         (SUBDIR_UNITTESTS_OBS): Rename to...
6759         (SELFTESTS_OBS): ... this.
6760         (COMMON_SFILES): Remove disasm-selftests.c and
6761         gdbarch-selftests.c.
6762         * configure.ac: Don't add selftest-arch.{c,o} to
6763         CONFIG_{SRCS,OBS}.
6764         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
6765         preprocessor conditions.
6766
6767 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6768
6769         * configure.ac: Don't source bfd/development.sh.
6770         * selftest.m4: Modify comment.
6771         * configure: Re-generate.
6772
6773 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6774
6775         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
6776         not "true" or "false".
6777         * configure: Re-generate.
6778
6779 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6780
6781         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
6782         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
6783         renamed to arm_nbsd_supply_gregset.
6784         (fetch_register): Update to call arm_nbsd_supply_gregset.
6785         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
6786         (arm_netbsd_nat_target::fetch_registers): Update.
6787         (fetch_elfcore_registers): Removed.
6788         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
6789         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
6790         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
6791         not require NetBSD system headers.
6792         (arm_nbsd_regset): New struct.
6793         (arm_nbsd_iterate_over_regset_sections): New function.
6794         (arm_netbsd_init_abi_common): Updated to call
6795         set_gdbarch_iterate_over_regset_sections.
6796         * arm-nbsd-tdep.h: New file.
6797
6798 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
6799
6800         * symtab.c (find_pc_sect_line): Add check which prevents infinite
6801         recursion.
6802
6803 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
6804
6805         * configure: Re-generate.
6806
6807 2020-03-11  Tom Tromey  <tromey@adacore.com>
6808
6809         * ada-typeprint.c (print_choices): Fix comment.
6810
6811 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6812
6813         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
6814         previous item in the list, when the list has no items.
6815
6816 2020-03-11  Tom de Vries  <tdevries@suse.de>
6817
6818         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
6819         PROP_LOCLIST handling code.
6820
6821 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6822
6823         * buildsym-legacy.c (record_line): Pass extra parameter to
6824         record_line.
6825         * buildsym.c (buildsym_compunit::record_line): Take an extra
6826         parameter, reduce duplication in the line table, and record the
6827         is_stmt flag in the line table.
6828         * buildsym.h (buildsym_compunit::record_line): Add extra
6829         parameter.
6830         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
6831         non-statement lines.
6832         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
6833         this to the symtab builder.
6834         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
6835         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
6836         through to dwarf_record_line_1.
6837         * infrun.c (process_event_stop_test): When stepping, don't stop at
6838         a non-statement instruction, and only refresh the step info when
6839         we land in the middle of a line's range.  Also add an extra
6840         comment.
6841         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
6842         field.
6843         * record-btrace.c (btrace_find_line_range): Only record lines
6844         marked as is-statement.
6845         * stack.c (frame_show_address): Show the frame address if we are
6846         in a non-statement sal.
6847         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
6848         (maintenance_print_one_line_table): Print a header for the is_stmt
6849         column, and include is_stmt information in the output.
6850         * symtab.c (find_pc_sect_line): Find lines marked as statements in
6851         preference to non-statements.
6852         (find_pcs_for_symtab_line): Prefer is-statement entries.
6853         (find_line_common): Likewise.
6854         * symtab.h (struct linetable_entry): Add is_stmt field.
6855         (struct symtab_and_line): Likewise.
6856         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
6857         arranging the line table.
6858
6859 2020-03-07  Tom de Vries  <tdevries@suse.de>
6860
6861         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
6862         DIE.
6863
6864 2020-03-07  Tom Tromey  <tom@tromey.com>
6865
6866         * valops.c (value_literal_complex): Remove obsolete comment.
6867         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
6868         comment.
6869
6870 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
6871
6872         * infrun.h: Forward-declare thread_info.
6873         (set_step_info): Add thread_info parameter, add doc.
6874         * infrun.c (set_step_info): Add thread_info parameter, move doc
6875         to header.
6876         * infrun.c (process_event_stop_test): Pass thread to
6877         set_step_info call.
6878         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
6879         set_step_info.
6880         (prepare_one_step): Add thread_info parameter, pass it to
6881         set_step_frame and prepare_one_step (recursive) call.
6882         (step_1): Pass thread to prepare_one_step call.
6883         (step_command_fsm::should_stop): Pass thread to
6884         prepare_one_step.
6885         (until_next_fsm): Pass thread to set_step_frame call.
6886         (finish_command): Pass thread to set_step_info call.
6887
6888 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
6889
6890         * windows-tdep.c (windows_solib_create_inferior_hook):
6891         Check if inferior is running.
6892
6893 2020-03-06  Tom de Vries  <tdevries@suse.de>
6894
6895         * NEWS: Fix "the the".
6896         * ctfread.c: Same.
6897
6898 2020-03-06  Tom de Vries  <tdevries@suse.de>
6899
6900         * psymtab.c (psymtab_to_symtab): Don't print "done.".
6901
6902 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6903
6904         * .dir-locals.el: Add a comment referencing the other copies of
6905         this file.
6906
6907 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
6908
6909         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
6910         psargs.
6911
6912 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6913
6914         * .gitattributes: New file.
6915
6916 2020-03-04  Tom Tromey  <tom@tromey.com>
6917
6918         * symmisc.c (print_symbol_bcache_statistics)
6919         (print_objfile_statistics): Update.
6920         * symfile.c (allocate_symtab): Use intern.
6921         * psymtab.c (partial_symtab::partial_symtab): Use intern.
6922         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6923         macro_cache>: Remove.
6924         <string_cache>: New member.
6925         (struct objfile) <intern>: New methods.
6926         * elfread.c (elf_symtab_read): Use intern.
6927         * dwarf2/read.c (fixup_go_packaging): Intern package name.
6928         (dwarf2_compute_name, dwarf2_physname)
6929         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
6930         names.
6931         (guess_partial_die_structure_name): Update.
6932         (partial_die_info::fixup): Intern name.
6933         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
6934         name.
6935         (dwarf2_name): Intern name.  Update.
6936         * buildsym.c (buildsym_compunit::get_macro_table): Use
6937         string_cache.
6938
6939 2020-03-04  Tom Tromey  <tom@tromey.com>
6940
6941         * jit.c (bfd_open_from_target_memory): Make "target" const.
6942         * corefile.c (gnutarget): Now const.
6943         * gdbcore.h (gnutarget): Now const.
6944
6945 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
6946
6947         * NEWS: Mention support for WOW64 processes.
6948         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
6949         (amd64_windows_segment_register_p): Remove static.
6950         (_initialize_amd64_windows_nat): Update.
6951         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
6952         * i386-windows-nat.c (context_offset): Update.
6953         (i386_mappings): Rename and remove static.
6954         (i386_windows_segment_register_p): Remove static.
6955         (_initialize_i386_windows_nat): Update.
6956         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
6957         (STATUS_WX86_SINGLE_STEP): New macro.
6958         (EnumProcessModulesEx): New macro.
6959         (Wow64SuspendThread): New macro.
6960         (Wow64GetThreadContext): New macro.
6961         (Wow64SetThreadContext): New macro.
6962         (Wow64GetThreadSelectorEntry): New macro.
6963         (windows_set_context_register_offsets): Add static.
6964         (windows_set_segment_register_p): Likewise.
6965         (windows_add_thread): Adapt for WOW64 processes.
6966         (windows_fetch_one_register): Likewise.
6967         (windows_nat_target::fetch_registers): Likewise.
6968         (windows_store_one_register): Likewise.
6969         (display_selector): Likewise.
6970         (display_selectors): Likewise.
6971         (handle_exception): Likewise.
6972         (windows_continue): Likewise.
6973         (windows_nat_target::resume): Likewise.
6974         (windows_add_all_dlls): Likewise.
6975         (do_initial_windows_stuff): Likewise.
6976         (windows_nat_target::attach): Likewise.
6977         (windows_get_exec_module_filename): Likewise.
6978         (windows_nat_target::create_inferior): Likewise.
6979         (windows_xfer_siginfo): Likewise.
6980         (_initialize_loadable): Initialize Wow64SuspendThread,
6981         Wow64GetThreadContext, Wow64SetThreadContext,
6982         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6983         * windows-nat.h (windows_set_context_register_offsets):
6984         Remove declaration.
6985         (windows_set_segment_register_p): Likewise.
6986         (i386_windows_segment_register_p): Add declaration.
6987         (amd64_windows_segment_register_p): Likewise.
6988
6989 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6990
6991         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6992         in "info registers" for AArch64/ARM.
6993
6994         The change caused "info registers" to not print GPR's.
6995
6996         gdb/ChangeLog:
6997
6998         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6999
7000         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
7001         when reg->group is empty and reggroup is not.
7002
7003 2020-03-03  Tom Tromey  <tromey@adacore.com>
7004
7005         * dwarf2/frame.c (struct dwarf2_frame_cache)
7006         <checked_tailcall_bottom, entry_cfa_sp_offset,
7007         entry_cfa_sp_offset_p>: Remove members.
7008         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
7009         (dwarf2_frame_prev_register): Don't call
7010         dwarf2_tailcall_sniffer_first.
7011         (dwarf2_append_unwinders): Don't append tailcall unwinder.
7012         * frame-unwind.c (add_unwinder): New fuction.
7013         (frame_unwind_init): Use it.  Add tailcall unwinder.
7014
7015 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7016             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7017
7018         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
7019         value should be printed as true.
7020
7021 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
7022
7023         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
7024         (windows_init_abi): Set and use windows_so_ops.
7025
7026 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
7027
7028         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
7029         when verifying if dealing with a convenience variable.
7030
7031 2020-03-03  Luis Machado  <luis.machado@linaro.org>
7032
7033         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
7034
7035 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
7036
7037         * infrun.c (gdbarch_supports_displaced_stepping): New.
7038         (use_displaced_stepping): Break up conditions in smaller pieces.
7039         Use gdbarch_supports_displaced_stepping.
7040         (displaced_step_prepare_throw): Use
7041         gdbarch_supports_displaced_stepping.
7042
7043 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7044
7045         * NEWS: Mention new behaviour of the history filename.
7046         * top.c (write_history_p): Add comment.
7047         (show_write_history_p): Add header comment, give a different
7048         message when history writing is on, but the history filename is
7049         empty.
7050         (history_filename): Add comment.
7051         (history_filename_empty): New function.
7052         (show_history_filename): Add header comment, give a different
7053         message when the filename is empty.
7054         (init_history): Compare history_filename against nullptr, and only
7055         read history if the filename is not empty.
7056         (set_history_filename): Add header comment, and only make
7057         non-empty filenames absolute.
7058         (init_main): Make the filename argument to 'set history filename'
7059         optional.
7060
7061 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
7062
7063         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
7064         (arm_supply_vfpregset): ...this, and update to use VFP registers.
7065         (fetch_fp_register): Update.
7066         (fetch_fp_regs): Update.
7067         (store_fp_register): Update.
7068         (store_fp_regs): Update.
7069         (arm_netbsd_nat_target::read_description): New function.
7070         (fetch_elfcore_registers): Update.
7071
7072 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7073
7074         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
7075         general_thread if the stop reply is missing a thread-id.
7076         (remote_target::process_stop_reply): Use the first non-exited
7077         thread if the target didn't pass a thread-id.
7078         * infrun.c (do_target_wait): Move call to
7079         switch_to_inferior_no_thread to ....
7080         (do_target_wait_1): ... here.
7081
7082 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
7083
7084         * debuginfod-support.c: Include defs.h first.
7085
7086 2020-02-28  Tom de Vries  <tdevries@suse.de>
7087
7088         * symfile.c (set_initial_language): Use default language for lookup.
7089
7090 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
7091
7092         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
7093         reader variable, pass `this` to read_cutu_die_from_dwo.
7094
7095 2020-02-27  Aaron Merey  <amerey@redhat.com>
7096
7097         * source.c (open_source_file): Check for nullptr when computing
7098         srcpath.
7099
7100 2020-02-27  Tom Tromey  <tromey@adacore.com>
7101
7102         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
7103         member.
7104         (dwarf2_add_field): Don't update nfields.
7105         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
7106
7107 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7108
7109         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
7110         abs.
7111
7112 2020-02-26  Tom Tromey  <tom@tromey.com>
7113
7114         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
7115         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
7116         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
7117         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
7118         per_cu_data.
7119
7120 2020-02-26  Tom Tromey  <tom@tromey.com>
7121
7122         * dwarf2/index-write.c (psym_index_map): Change type.
7123         (add_address_entry_worker, write_one_signatured_type)
7124         (recursively_count_psymbols, recursively_write_psymbols)
7125         (class debug_names, psyms_seen_size, write_gdbindex)
7126         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
7127
7128 2020-02-26  Aaron Merey  <amerey@redhat.com>
7129
7130         * Makefile.in: Handle optional debuginfod support.
7131         * NEWS: Update.
7132         * README: Add --with-debuginfod summary.
7133         * config.in: Regenerate.
7134         * configure: Regenerate.
7135         * configure.ac: Handle optional debuginfod support.
7136         * debuginfod-support.c: debuginfod helper functions.
7137         * debuginfod-support.h: Ditto.
7138         * doc/gdb.texinfo: Add --with-debuginfod to configure options
7139         summary.
7140         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
7141         when a dwz file cannot be found.
7142         * elfread.c (elf_symfile_read): Query debuginfod servers when a
7143         debuginfo file cannot be found.
7144         * source.c (open_source_file): Query debuginfod servers when a
7145         source file cannot be found.
7146         * top.c (print_gdb_configuration): Include
7147         --{with,without}-debuginfod in the output.
7148
7149 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
7150
7151         * thread.c (thr_try_catch_cmd): Print thread name.
7152
7153 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
7154
7155         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
7156         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7157         dwarf2_fetch_die_type_sect_off): Move to...
7158         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
7159         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7160         dwarf2_fetch_die_type_sect_off): ... here.
7161         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
7162         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7163         dwarf2_fetch_die_type_sect_off): Move doc to header file.
7164
7165 2020-02-26  Tom de Vries  <tdevries@suse.de>
7166
7167         PR gdb/25603
7168         * symfile.c (set_initial_language): Exit-early if
7169         language_mode == language_mode_manual.
7170
7171 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7172
7173         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
7174         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
7175         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
7176
7177 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
7178
7179         * gdbtypes.c (create_array_type_with_stride): Handle negative
7180         array strides.
7181         * valarith.c (value_subscripted_rvalue): Likewise.
7182
7183 2020-02-25  Luis Machado  <luis.machado@linaro.org>
7184
7185         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
7186
7187 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7188
7189         * loc.h (dwarf2_get_die_type): Move to...
7190         * read.h (dwarf2_get_die_type): ... here.
7191         * read.c (dwarf2_get_die_type): Move doc to header.
7192
7193 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
7194
7195         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
7196         'gnulib/Makefile.in' to the list.
7197
7198 2020-02-24  Tom Tromey  <tom@tromey.com>
7199
7200         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
7201         Remove.
7202         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
7203         XOBNEWVEC.
7204
7205 2020-02-24  Tom Tromey  <tom@tromey.com>
7206
7207         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
7208         New method.
7209         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
7210         (dw2_do_instantiate_symtab, dw2_get_file_names)
7211         (build_type_psymtab_dependencies, load_full_type_unit): Update.
7212
7213 2020-02-24  Tom Tromey  <tom@tromey.com>
7214
7215         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
7216         make_scoped_restore.
7217         (dwarf2_psymtab::read_symtab): Don't clear
7218         reading_partial_symbols.
7219
7220 2020-02-24  Tom de Vries  <tdevries@suse.de>
7221
7222         PR gdb/25592
7223         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
7224
7225 2020-02-24  Tom de Vries  <tdevries@suse.de>
7226
7227         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
7228         commands layout next/prev/regs.
7229
7230 2020-02-22  Tom Tromey  <tom@tromey.com>
7231
7232         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
7233         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
7234
7235 2020-02-22  Tom Tromey  <tom@tromey.com>
7236
7237         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
7238
7239 2020-02-22  Tom Tromey  <tom@tromey.com>
7240
7241         * tui/tui-win.c (_initialize_tui_win): Add usage text.
7242         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
7243         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
7244         * tui/tui.c (_initialize_tui): Add usage text.
7245
7246 2020-02-22  Tom Tromey  <tom@tromey.com>
7247
7248         * tui/tui-win.c (tui_set_focus_command)
7249         (tui_set_win_height_command): Use error_no_arg.
7250         (_initialize_tui_win): Update help text.
7251         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
7252
7253 2020-02-22  Tom Tromey  <tom@tromey.com>
7254
7255         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
7256         * tui/tui-disasm.h (struct tui_disasm_window)
7257         <display_start_addr>: Declare.
7258         * tui/tui-source.h (struct tui_source_window)
7259         <display_start_addr>: Declare.
7260         * tui/tui-winsource.h (struct tui_source_window_base)
7261         <show_source_line, display_start_addr>: New methods.
7262         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
7263         Rename and move to protected section.
7264         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
7265         (tui_source_window_base::do_erase_source_content): Update.
7266         (tui_source_window_base::show_source_line): Now a method.
7267         (tui_source_window_base::show_source_content)
7268         (tui_source_window_base::tui_source_window_base)
7269         (tui_source_window_base::rerender)
7270         (tui_source_window_base::refill)
7271         (tui_source_window_base::do_scroll_horizontal)
7272         (tui_source_window_base::set_is_exec_point_at)
7273         (tui_source_window_base::update_breakpoint_info)
7274         (tui_source_window_base::update_exec_info): Update.
7275         * tui/tui-source.c (tui_source_window::set_contents)
7276         (tui_source_window::showing_source_p)
7277         (tui_source_window::do_scroll_vertical)
7278         (tui_source_window::location_matches_p)
7279         (tui_source_window::line_is_displayed): Update.
7280         (tui_source_window::display_start_addr): New method.
7281         * tui/tui-disasm.c (tui_disasm_window::set_contents)
7282         (tui_disasm_window::do_scroll_vertical)
7283         (tui_disasm_window::location_matches_p): Update.
7284         (tui_disasm_window::display_start_addr): New method.
7285
7286 2020-02-22  Tom Tromey  <tom@tromey.com>
7287
7288         * NEWS: Add entry for gdb.register_window_type.
7289         * tui/tui-layout.h (window_factory): New typedef.
7290         (tui_register_window): Declare.
7291         * tui/tui-layout.c (saved_tui_windows): New global.
7292         (tui_apply_current_layout): Use it.
7293         (tui_register_window): New function.
7294         * python/python.c (do_start_initialization): Call
7295         gdbpy_initialize_tui.
7296         (python_GdbMethods): Add "register_window_type" function.
7297         * python/python-internal.h (gdbpy_register_tui_window)
7298         (gdbpy_initialize_tui): Declare.
7299         * python/py-tui.c: New file.
7300         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
7301
7302 2020-02-22  Tom Tromey  <tom@tromey.com>
7303
7304         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
7305
7306 2020-02-22  Tom Tromey  <tom@tromey.com>
7307
7308         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
7309         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
7310         * tui/tui-data.c (tui_set_win_with_focus): Remove.
7311         (tui_set_win_focus_to): Move from tui-win.c.
7312
7313 2020-02-22  Tom Tromey  <tom@tromey.com>
7314
7315         * tui/tui-layout.c (make_standard_window, get_locator_window): New
7316         functions.
7317         (known_window_types): New global.
7318         (tui_get_window_by_name): Reimplement.
7319         (initialize_known_windows): New function.
7320         (validate_window_name): Rewrite.
7321         (_initialize_tui_layout): Call initialize_known_windows.
7322
7323 2020-02-22  Tom Tromey  <tom@tromey.com>
7324
7325         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
7326         Remove constants.
7327         * tui/tui-winsource.h (struct tui_source_window_base)
7328         <tui_source_window_base>: Remove parameter.
7329         * tui/tui-winsource.c
7330         (tui_source_window_base::tui_source_window_base): Remove
7331         parameter.
7332         (tui_source_window_base::refill): Update.
7333         * tui/tui-stack.h (struct tui_locator_window)
7334         <tui_locator_window>: Update.
7335         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
7336         Default the constructor.
7337         * tui/tui-regs.h (struct tui_data_item_window)
7338         <tui_data_item_window>: Default the constructor.
7339         (struct tui_data_window) <tui_data_window>: Likewise.
7340         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
7341         Default the constructor.
7342         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
7343         Default the constructor.
7344         <type>: Remove.
7345         (struct tui_win_info) <tui_win_info>: Default the constructor.
7346         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
7347         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
7348         Default the constructor.
7349
7350 2020-02-22  Tom Tromey  <tom@tromey.com>
7351
7352         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
7353         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
7354         * tui/tui-win.c (tui_resize_all): Don't call
7355         tui_delete_invisible_windows.
7356         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
7357         done.
7358         (tui_set_layout): Update.
7359         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
7360         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
7361         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
7362
7363 2020-02-22  Tom Tromey  <tom@tromey.com>
7364
7365         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
7366         correctly.
7367
7368 2020-02-22  Tom Tromey  <tom@tromey.com>
7369
7370         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
7371
7372 2020-02-22  Tom Tromey  <tom@tromey.com>
7373
7374         * tui/tui-winsource.h (struct tui_source_window_iterator)
7375         <inner_iterator>: New etytypedef.
7376         <tui_source_window_iterator>: Take "end" parameter.
7377         <tui_source_window_iterator>: Take iterator.
7378         <operator*, advance>: Update.
7379         <m_iter>: Change type.
7380         <m_end>: New field.
7381         (struct tui_source_windows) <begin, end>: Update.
7382         * tui/tui-layout.c (tui_windows): New global.
7383         (tui_apply_current_layout): Clear tui_windows.
7384         (tui_layout_window::apply): Update tui_windows.
7385         * tui/tui-data.h (tui_windows): Declare.
7386         (all_tui_windows): Now inline function.
7387         (class tui_window_iterator, struct all_tui_windows): Remove.
7388
7389 2020-02-22  Tom Tromey  <tom@tromey.com>
7390
7391         PR tui/17850:
7392         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
7393         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
7394         "height" argument.
7395         (class tui_layout_window) <get_sizes>: Likewise.
7396         (class tui_layout_split) <tui_layout_split>: Add "vertical"
7397         argument.
7398         <get_sizes>: Add "height" argument.
7399         <m_vertical>: New field.
7400         * tui/tui-layout.c (tui_layout_split::clone): Update.
7401         (tui_layout_split::get_sizes): Add "height" argument.
7402         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
7403         (tui_new_layout_command): Parse "-horizontal".
7404         (_initialize_tui_layout): Update help string.
7405         (tui_layout_split::specification): Add "-horizontal" when needed.
7406         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
7407         argument.
7408         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
7409         New methods.
7410
7411 2020-02-22  Tom Tromey  <tom@tromey.com>
7412
7413         * tui/tui-layout.h (enum tui_adjust_result): New.
7414         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
7415         (class tui_layout_window) <adjust_size>: Return
7416         tui_adjust_result.  Rewrite.
7417         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
7418         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
7419
7420 2020-02-22  Tom Tromey  <tom@tromey.com>
7421
7422         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
7423         parameter and return types.
7424         (class tui_layout_base) <specification>: Add "depth".
7425         (class tui_layout_window) <specification>: Add "depth".
7426         (class tui_layout_split) <specification>: Add "depth".
7427         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
7428         and return types.
7429         (tui_new_layout_command): Parse sub-layouts.
7430         (_initialize_tui_layout): Update help string.
7431         (tui_layout_window::specification): Add "depth".
7432         (add_layout_command): Update.
7433
7434 2020-02-22  Tom Tromey  <tom@tromey.com>
7435
7436         * NEWS: Add "tui new-layout" item.
7437         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
7438         Add new-layout command to help text.
7439         (validate_window_name): New function.
7440         (tui_new_layout_command): New function.
7441         (_initialize_tui_layout): Register "new-layout".
7442         (tui_layout_window::specification): New method.
7443         (tui_layout_window::specification): New method.
7444         * tui/tui-layout.h (class tui_layout_base) <specification>: New
7445         method.
7446         (class tui_layout_window) <specification>: New method.
7447         (class tui_layout_split) <specification>: New method.
7448
7449 2020-02-22  Tom Tromey  <tom@tromey.com>
7450
7451         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
7452         * tui/tui-win.c (window_name_completer): Update comment.
7453         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
7454         Declare method.
7455         (class tui_layout_window) <replace_window>: Likewise.
7456         (class tui_layout_split) <replace_window>: Likewise.
7457         (tui_set_layout): Don't declare.
7458         (tui_set_initial_layout): Declare function.
7459         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
7460         (asm_regs_layout): New globals.
7461         (tui_current_layout, show_layout): Remove.
7462         (tui_set_layout, tui_add_win_to_layout): Rewrite.
7463         (find_layout, tui_apply_layout): New function.
7464         (layout_completer): Remove.
7465         (tui_next_layout): Reimplement.
7466         (tui_next_layout_command): New function.
7467         (tui_set_initial_layout, tui_prev_layout_command): New functions.
7468         (tui_regs_layout): Reimplement.
7469         (tui_regs_layout_command): New function.
7470         (extract_display_start_addr): Rewrite.
7471         (next_layout, prev_layout): Remove.
7472         (tui_layout_window::replace_window): New method.
7473         (tui_layout_split::replace_window): New method.
7474         (destroy_layout): New function.
7475         (layout_list): New global.
7476         (add_layout_command): New function.
7477         (initialize_layouts): Update.
7478         (tui_layout_command): New function.
7479         (_initialize_tui_layout): Install "layout" commands.
7480         * tui/tui-data.h (enum tui_layout_type): Remove.
7481         (tui_current_layout): Don't declare.
7482
7483 2020-02-22  Tom Tromey  <tom@tromey.com>
7484
7485         * tui/tui-regs.c (tui_reg_layout): Remove.
7486         (tui_reg_command): Use tui_regs_layout.
7487         * tui/tui-layout.h (tui_reg_command): Declare.
7488         * tui/tui-layout.c (tui_reg_command): New function.
7489
7490 2020-02-22  Tom Tromey  <tom@tromey.com>
7491
7492         * tui/tui.c (tui_rl_delete_other_windows): Call
7493         tui_remove_some_windows.
7494         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
7495         Declare method.
7496         (class tui_layout_window) <remove_windows>: New method.
7497         (class tui_layout_split) <remove_windows>: Declare.
7498         (tui_remove_some_windows): Declare.
7499         * tui/tui-layout.c (tui_remove_some_windows): New function.
7500         (tui_layout_split::remove_windows): New method.
7501
7502 2020-02-22  Tom Tromey  <tom@tromey.com>
7503
7504         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
7505         * tui/tui-layout.h (tui_next_layout): Declare.
7506         * tui/tui-layout.c (tui_next_layout): New function.
7507
7508 2020-02-22  Tom Tromey  <tom@tromey.com>
7509
7510         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
7511         correct coordinates.
7512
7513 2020-02-22  Tom Tromey  <tom@tromey.com>
7514
7515         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
7516         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
7517         DATA_WIN case.
7518
7519 2020-02-22  Tom Tromey  <tom@tromey.com>
7520
7521         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
7522         TUI_DISASM_WIN, not tui_win_list.
7523
7524 2020-02-22  Tom Tromey  <tom@tromey.com>
7525
7526         * valprint.c (generic_val_print_enum_1)
7527         (val_print_type_code_flags): Style member names.
7528         * rust-lang.c (val_print_struct, rust_print_enum)
7529         (rust_print_struct_def, rust_internal_print_type): Style member
7530         names.
7531         * p-valprint.c (pascal_object_print_value_fields): Style member
7532         names.  Only call fprintf_symbol_filtered for static members.
7533         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
7534         * f-valprint.c (f_val_print): Style member names.
7535         * f-typeprint.c (f_type_print_base): Style member names.
7536         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
7537         call fprintf_symbol_filtered for static members.
7538         (cp_print_class_member): Style member names.
7539         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
7540         member names.
7541         * ada-valprint.c (ada_print_scalar): Style enum names.
7542         (ada_val_print_enum): Likewise.
7543         * ada-typeprint.c (print_enum_type): Style enum names.
7544
7545 2020-02-21  Tom Tromey  <tom@tromey.com>
7546
7547         * psympriv.h (struct partial_symtab): Update comment.
7548
7549 2020-02-21  Tom Tromey  <tromey@adacore.com>
7550
7551         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
7552         type is CORE_ADDR.
7553
7554 2020-02-21  Tom de Vries  <tdevries@suse.de>
7555
7556         PR gdb/25534
7557         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
7558         if dependencies[i]->user != NULL.
7559
7560 2020-02-21  Ali Tamur  <tamur@google.com>
7561
7562         * dwarf2/read.c (dwarf2_name): Add null check.
7563
7564 2020-02-20  Tom Tromey  <tom@tromey.com>
7565
7566         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
7567         ">=", in binary search.
7568         (dwarf2_find_containing_comp_unit): New overload.
7569         (run_test): New self-test.
7570         (_initialize_dwarf2_read): Register new test.
7571
7572 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
7573
7574         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
7575         * riscv-tdep.h: Likewise.
7576         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
7577         rv32-only CSR.
7578         * features/riscv/64bit-csr.xml: Regenerated.
7579
7580 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
7581             Tom Tromey  <tom@tromey.com>
7582
7583         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
7584         of 'fputc_unfiltered'.
7585         (putchar_unfiltered): Call 'fputc_unfiltered'.
7586         (fputc_unfiltered): Call 'fputs_unfiltered'.
7587
7588 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
7589
7590         * config.in: Regenerate.
7591         * configure: Regenerate.
7592         * configure.ac: Add --with-python-libdir option.
7593         * main.c: Use WITH_PYTHON_LIBDIR.
7594
7595 2020-02-19  Tom Tromey  <tom@tromey.com>
7596
7597         * symtab.c (general_symbol_info::compute_and_set_names): Use
7598         obstack_strndup.  Simplify call to symbol_set_demangled_name.
7599
7600 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
7601
7602         * dwarf2/read.c (allocate_signatured_type_table,
7603         allocate_dwo_unit_table, allocate_type_unit_groups_table,
7604         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
7605         Remove objfile parameter, update all callers.
7606
7607 2020-02-19  Doug Evans  <dje@google.com>
7608
7609         PR rust/25535
7610         * rust-lang.c (rust_print_enum): Apply embedded_offset to
7611         rust_enum_variant calculation.
7612
7613 2020-02-19  Tom Tromey  <tromey@adacore.com>
7614
7615         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
7616
7617 2020-02-19  Tom Tromey  <tromey@adacore.com>
7618
7619         * ada-lang.c (cache_symbol): Use obstack_strdup.
7620
7621 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7622
7623         * configure: Regenerate.
7624
7625 2020-02-19  Tom Tromey  <tromey@adacore.com>
7626
7627         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
7628         NULL check.
7629
7630 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
7631
7632         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
7633
7634 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7635
7636         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
7637         if GDBSERVER is not defined.
7638         (riscv_tdesc_cache): Likewise, also store const target_desc.
7639         (STATIC_IN_GDB): Define.
7640         (riscv_create_target_description): Update declaration with
7641         STATIC_IN_GDB.
7642         (riscv_lookup_target_description): New function, only define if
7643         GDBSERVER is not defined.
7644         * arch/riscv.h (riscv_create_target_description): Declare only
7645         when GDBSERVER is defined.
7646         (riscv_lookup_target_description): New declaration when GDBSERVER
7647         is not defined.
7648         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
7649         (riscv_linux_read_features): ...this, and return
7650         riscv_gdbarch_features instead of target_desc.
7651         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
7652         (riscv_linux_read_description): Rename to...
7653         (riscv_linux_read_features): ...this.
7654         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7655         Update to use riscv_gdbarch_features and
7656         riscv_lookup_target_description.
7657         * riscv-tdep.c (riscv_find_default_target_description): Use
7658         riscv_lookup_target_description instead of
7659         riscv_create_target_description.
7660
7661 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7662
7663         * valprint.c (generic_val_print_enum_1): When printing a flag
7664         enum with value 0 and there is no enumerator with value 0, print
7665         just "0" instead of "(unknown: 0x0)".
7666
7667 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7668
7669         * valprint.c (generic_val_print_enum_1): Print unknown part of
7670         flag enum in hex.
7671
7672 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7673
7674         * dwarf2/read.c (update_enumeration_type_from_children): Allow
7675         flag enums to contain duplicate enumerators.
7676         * valprint.c (generic_val_print_enum_1): Update comment.
7677
7678 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7679
7680         * dwarf2/read.c: Include "count-one-bits.h".
7681         (update_enumeration_type_from_children): If an enumerator has
7682         multiple bits set, don't treat the enumeration as a "flag enum".
7683         * valprint.c (generic_val_print_enum_1): Assert that enumerators
7684         of flag enums have 0 or 1 bit set.
7685
7686 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7687
7688         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
7689         conversion.
7690         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7691         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7692         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7693         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7694         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7695
7696 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7697
7698         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
7699
7700 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7701
7702         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
7703         displaced_step_closure_up.
7704         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7705         (struct displaced_step_closure_up):
7706         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7707         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7708         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
7709         Likewise.
7710         * gdbarch.sh (displaced_step_copy_insn): Likewise.
7711         * gdbarch.c, gdbarch.h: Re-generate.
7712         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
7713         displaced_step_closure_up.
7714         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7715         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7716         * infrun.h (displaced_step_closure_up): New type alias.
7717         (struct displaced_step_inferior_state) <step_closure>: Change
7718         type to displaced_step_closure_up.
7719         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
7720         displaced_step_closure_up.
7721         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7722
7723 2020-02-14  Tom Tromey  <tom@tromey.com>
7724
7725         * minidebug.c (gnu_debug_key): New global.
7726         (find_separate_debug_file_in_section): Use it.
7727
7728 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7729
7730         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
7731         std::unique_ptr.
7732         * gdbarch.c: Re-generate.
7733         * gdbarch.h: Re-generate.
7734         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
7735         change.
7736         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
7737         type to std::unique_ptr.
7738         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7739         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7740         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7741         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7742         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
7743         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7744         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7745         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7746         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7747
7748 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7749
7750         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
7751         std::unique_ptr.
7752         (displaced_step_clear): Rename to...
7753         (displaced_step_reset): ... this.  Just call displaced->reset ().
7754         (displaced_step_clear_cleanup): Rename to...
7755         (displaced_step_reset_cleanup): ... this.
7756         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
7757         (displaced_step_fixup): Likewise.
7758         (resume_1): Likewise.
7759         (handle_inferior_event): Restore child's memory before calling
7760         displaced_step_fixup on the parent.
7761         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
7762         to std::unique_ptr.
7763         <step_closure>: Change type to std::unique_ptr.
7764
7765 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7766
7767         * arm-tdep.c: Include count-one-bits.h.
7768         (cleanup_block_store_pc): Use count_one_bits.
7769         (cleanup_block_load_pc): Use count_one_bits.
7770         (arm_copy_block_xfer): Use count_one_bits.
7771         (thumb2_copy_block_xfer): Use count_one_bits.
7772         (thumb_copy_pop_pc_16bit): Use count_one_bits.
7773         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
7774         (thumb_get_next_pcs_raw): Use count_one_bits.
7775         (arm_get_next_pcs_raw): Use count_one_bits_l.
7776         * arch/arm.c (bitcount): Remove.
7777         * arch/arm.h (bitcount): Remove.
7778
7779 2020-02-14  Tom Tromey  <tromey@adacore.com>
7780
7781         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
7782         Update.
7783         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
7784         * dwarf2/loc.c (call_site_find_chain_1): Return
7785         unique_xmalloc_ptr.
7786         (call_site_find_chain): Likewise.
7787
7788 2020-02-14  Richard Biener  <rguenther@suse.de>
7789
7790         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
7791         on expression with division operators.
7792
7793 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7794
7795         * MAINTAINERS (Write After Approval): Adding myself.
7796
7797 2020-02-12  Tom Tromey  <tom@tromey.com>
7798
7799         * event-loop.c (event_data, gdb_event, event_handler_func):
7800         Remove.
7801
7802 2020-02-12  Tom Tromey  <tom@tromey.com>
7803
7804         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
7805         (dwarf2_frame_objfile_data): Add comment.
7806         (find_comp_unit, set_comp_unit): New functions.
7807         (dwarf2_frame_find_fde): Use find_comp_unit.
7808         (dwarf2_build_frame_info): Use set_comp_unit.
7809
7810 2020-02-12  Tom Tromey  <tom@tromey.com>
7811
7812         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
7813         (comp_unit): Don't initialize objfile.
7814         (execute_cfa_program): Add text_offset parameter.
7815         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
7816         (dwarf2_frame_cache): Update.
7817         (dwarf2_build_frame_info): Don't set "objfile" member.
7818
7819 2020-02-12  Tom Tromey  <tom@tromey.com>
7820
7821         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
7822         (decode_frame_entry): Likewise.
7823         (dwarf2_build_frame_info): Update.
7824
7825 2020-02-12  Tom Tromey  <tom@tromey.com>
7826
7827         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
7828         (decode_frame_entry_1): Use the comp_unit obstack.
7829
7830 2020-02-12  Tom Tromey  <tom@tromey.com>
7831
7832         * dwarf2/frame.c (struct comp_unit): Add initializers and
7833         constructor.
7834         (dwarf2_frame_objfile_data): Store a comp_unit.
7835         (dwarf2_frame_find_fde): Update.
7836         (dwarf2_build_frame_info): Use "new".
7837
7838 2020-02-12  Tom Tromey  <tom@tromey.com>
7839
7840         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
7841         (dwarf2_fde_table): Typedef for std::vector.
7842         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
7843         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
7844         (decode_frame_entry): Update.
7845         (dwarf2_build_frame_info): Use "new".
7846
7847 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7848
7849         * arm-tdep.c (arm_gdbarch_init): Update.
7850         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
7851         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
7852         have_neon, is_m>: Change to bool.
7853
7854 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7855
7856         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
7857
7858 2020-02-12  Tom Tromey  <tom@tromey.com>
7859
7860         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
7861
7862 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
7863
7864         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
7865         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
7866
7867 2020-02-11  Tom Tromey  <tom@tromey.com>
7868
7869         * psymtab.h: Update comment.
7870
7871 2020-02-11  Tom Tromey  <tom@tromey.com>
7872
7873         * gdb_obstack.h (struct auto_obstack): Use
7874         DISABLE_COPY_AND_ASSIGN.
7875
7876 2020-02-11  Tom Tromey  <tom@tromey.com>
7877
7878         * dwarf2/frame.h (struct objfile): Don't forward declare.
7879
7880 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7881
7882         * cris-tdep.c (cris_supply_gregset): Change signature to match
7883         what struct regset expects.
7884         (cris_regset): New struct.
7885         (fetch_core_registers): Remove.
7886         (cris_iterate_over_regset_sections): New function.
7887         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
7888         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
7889
7890 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7891
7892         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
7893         registers.
7894
7895 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7896
7897         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
7898
7899 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7900
7901         * configure: Re-generate.
7902
7903 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7904
7905         * configure: Re-generate.
7906
7907 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7908
7909         * acinclude: Update warning.m4 path.
7910         * warning.m4: Move to gdbsupport.
7911
7912 2020-02-11  Tom Tromey  <tromey@adacore.com>
7913
7914         * remote.c (remote_console_output): Update.
7915         * printcmd.c (printf_command): Update.
7916         * event-loop.c (gdb_wait_for_event): Update.
7917         * linux-nat.c (sigchld_handler): Update.
7918         * remote-sim.c (gdb_os_write_stdout): Update.
7919         (gdb_os_flush_stdout): Update.
7920         (gdb_os_flush_stderr): Update.
7921         (gdb_os_write_stderr): Update.
7922         * exceptions.c (print_exception): Update.
7923         * remote-fileio.c (remote_fileio_func_read): Update.
7924         (remote_fileio_func_write): Update.
7925         * tui/tui.c (tui_enable): Update.
7926         * tui/tui-interp.c (tui_interp::init): Update.
7927         * utils.c (init_page_info): Update.
7928         (putchar_unfiltered, fputc_unfiltered): Update.
7929         (gdb_flush): Update.
7930         (emit_style_escape): Update.
7931         (flush_wrap_buffer, fputs_maybe_filtered): Update.
7932         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
7933         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
7934         (stderr_file::write): Update.
7935         (stderr_file::puts): Update.
7936         * ui-file.h (ui_file_isatty, ui_file_write)
7937         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
7938         (ui_file_puts): Don't declare.
7939
7940 2020-02-10  Tom de Vries  <tdevries@suse.de>
7941
7942         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
7943         sentinel to char *.
7944
7945 2020-02-09  Tom de Vries  <tdevries@suse.de>
7946
7947         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
7948         filename if it matches "<artificial>".
7949
7950 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7951
7952         * windows-tdep.c (struct enum_value_name): New struct.
7953         (create_enum): New function.
7954         (windows_get_siginfo_type): Create and use enum types.
7955
7956 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7957
7958         * NEWS: Mention $_siginfo support for Windows.
7959         * windows-nat.c (handle_exception): Set siginfo_er.
7960         (windows_nat_target::mourn_inferior): Reset siginfo_er.
7961         (windows_xfer_siginfo): New function.
7962         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
7963         * windows-tdep.c (struct windows_gdbarch_data): New struct.
7964         (init_windows_gdbarch_data): New function.
7965         (get_windows_gdbarch_data): New function.
7966         (windows_get_siginfo_type): New function.
7967         (windows_init_abi): Register windows_get_siginfo_type.
7968         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
7969
7970 2020-02-08  Tom Tromey  <tom@tromey.com>
7971
7972         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7973         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7974         <keep>: Declare method.
7975         <m_keep>: Remove member.
7976         <~cutu_reader>: Remove.
7977         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7978         (cutu_reader::cutu_reader): Update.
7979         (cutu_reader::keep): Rename from ~cutu_reader.
7980         (process_psymtab_comp_unit, build_type_psymtabs_1)
7981         (process_skeletonless_type_unit, load_partial_comp_unit)
7982         (load_full_comp_unit, dwarf2_read_addr_index)
7983         (read_signatured_type): Update.
7984
7985 2020-02-08  Tom Tromey  <tom@tromey.com>
7986
7987         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7988         "want_partial_unit" parameter.
7989         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7990         Inline check for DW_TAG_partial_unit.
7991         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7992
7993 2020-02-08  Tom Tromey  <tom@tromey.com>
7994
7995         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7996         read.c.
7997         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7998         read.c.
7999
8000 2020-02-08  Tom Tromey  <tom@tromey.com>
8001
8002         * dwarf2/read.c (read_address): Move to comp-unit.c.
8003         (dwarf2_rnglists_process, dwarf2_ranges_process)
8004         (read_attribute_value, dwarf_decode_lines_1)
8005         (var_decode_location, decode_locdesc): Update.
8006         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
8007         read.c.  Remove "cu" parameter.
8008         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
8009         method.
8010
8011 2020-02-08  Tom Tromey  <tom@tromey.com>
8012
8013         * dwarf2/read.c (read_attribute_value, read_indirect_string)
8014         (read_indirect_line_string): Update.
8015         * dwarf2/comp-unit.c (read_offset): Remove.
8016         (read_comp_unit_head): Update.
8017         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
8018         method.
8019         (read_offset): Don't declare.
8020
8021 2020-02-08  Tom Tromey  <tom@tromey.com>
8022
8023         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
8024         * dwarf2/read.c (struct comp_unit_head): Move to
8025         dwarf2/comp-unit.h.
8026         (enum class rcuh_kind): Move to comp-unit.h.
8027         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
8028         (read_comp_unit_head, error_check_comp_unit_head)
8029         (read_and_check_comp_unit_head): Move to comp-unit.c.
8030         (read_offset, dwarf_unit_type_name): Likewise.
8031         (create_debug_type_hash_table, read_cutu_die_from_dwo)
8032         (cutu_reader::cutu_reader, read_call_site_scope)
8033         (find_partial_die, follow_die_offset): Update.
8034         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
8035
8036 2020-02-08  Tom Tromey  <tom@tromey.com>
8037
8038         * dwarf2/read.c (read_offset_1): Move to leb.c.
8039         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
8040         (dwarf_decode_macro_bytes): Update.
8041         * dwarf2/leb.c (read_offset): Rename; move from read.c.
8042         * dwarf2/leb.h (read_offset): Declare.
8043
8044 2020-02-08  Tom Tromey  <tom@tromey.com>
8045
8046         * dwarf2/read.c (dwarf2_section_size): Remove.
8047         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
8048         Update.
8049         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
8050
8051 2020-02-08  Tom Tromey  <tom@tromey.com>
8052
8053         * dwarf2/read.c (read_initial_length): Move to leb.c.
8054         * dwarf2/leb.h (read_initial_length): Declare.
8055         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
8056         handle_nonstd parameter.
8057         * dwarf2/frame.c (read_initial_length): Remove.
8058         (decode_frame_entry_1): Update.
8059
8060 2020-02-08  Tom Tromey  <tom@tromey.com>
8061
8062         * dwarf2/loc.c (dwarf2_find_location_expression)
8063         (dwarf_evaluate_loc_desc::get_tls_address)
8064         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
8065         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
8066         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
8067         (dwarf2_compile_property_to_c)
8068         (dwarf2_loc_desc_get_symbol_read_needs)
8069         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
8070         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
8071         (loclist_describe_location, loclist_tracepoint_var_ref)
8072         (loclist_generate_c_location): Update.
8073         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
8074         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
8075         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
8076         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
8077         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
8078         (dwarf2_per_cu_data::addr_size)
8079         (dwarf2_per_cu_data::ref_addr_size)
8080         (dwarf2_per_cu_data::text_offset)
8081         (dwarf2_per_cu_data::addr_type): Now methods.
8082         (per_cu_header_read_in): Make per_cu "const".
8083         (dwarf2_version): Remove.
8084         (dwarf2_per_cu_data::int_type): Now a method.
8085         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
8086         (set_die_type, read_array_type, read_subrange_index_type)
8087         (read_tag_string_type, read_subrange_type): Update.
8088         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
8089         offset_size, ref_addr_size, text_offset, addr_type, version,
8090         objfile, int_type, addr_sized_int_type>: Declare methods.
8091
8092 2020-02-08  Tom Tromey  <tom@tromey.com>
8093
8094         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
8095         Move earlier.
8096
8097 2020-02-08  Tom Tromey  <tom@tromey.com>
8098
8099         * dwarf2/read.h (dwarf_line_debug): Declare.
8100         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
8101         * dwarf2/read.c: Move line_header code to new files.
8102         (dwarf_line_debug): No longer static.
8103         * dwarf2/line-header.c: New file.
8104         * dwarf2/line-header.h: New file.
8105
8106 2020-02-08  Tom Tromey  <tom@tromey.com>
8107
8108         * dwarf2/read.c (struct line_header) <file_full_name,
8109         file_file_name>: Return unique_xmalloc_ptr.
8110         (line_header::file_file_name): Update.
8111         (line_header::file_full_name): Update.
8112         (dw2_get_file_names_reader): Update.
8113         (macro_start_file): Update.
8114
8115 2020-02-08  Tom Tromey  <tom@tromey.com>
8116
8117         * dwarf2/read.c (struct line_header) <file_full_name,
8118         file_file_name>: Declare methods.
8119         (dw2_get_file_names_reader): Update.
8120         (file_file_name): Now a method.
8121         (file_full_name): Likewise.
8122         (macro_start_file): Update.
8123
8124 2020-02-08  Tom Tromey  <tom@tromey.com>
8125
8126         * dwarf2/read.c (dwarf_always_disassemble)
8127         (show_dwarf_always_disassemble): Move to loc.c.
8128         (_initialize_dwarf2_read): Move "always-disassemble" registration
8129         to loc.c.
8130         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
8131         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
8132         static.
8133         (show_dwarf_always_disassemble): Move from read.c.
8134         (_initialize_dwarf2loc): Move always-disassemble from read.c.
8135
8136 2020-02-08  Tom Tromey  <tom@tromey.com>
8137
8138         * dwarf2/read.c (~dwarf2_per_objfile): Update.
8139         (create_quick_file_names_table): Return htab_up.
8140         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
8141         Update.
8142         * dwarf2/read.h (struct dwarf2_per_objfile)
8143         <quick_file_names_table>: Now htab_up.
8144
8145 2020-02-08  Tom Tromey  <tom@tromey.com>
8146
8147         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
8148
8149 2020-02-08  Tom Tromey  <tom@tromey.com>
8150
8151         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
8152         Rewrite.
8153         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
8154         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
8155         (abbrev_table::abbrev_table): No longer inline.
8156         (ABBREV_HASH_SIZE): Remove.
8157         (abbrev_table::m_abbrevs): Now an htab_up.
8158
8159 2020-02-08  Tom Tromey  <tom@tromey.com>
8160
8161         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
8162         (cutu_reader): Update.
8163         (build_type_psymtabs_1): Update.
8164         * dwarf2/abbrev.c (abbrev_table::read): Rename.
8165         (abbrev_table::alloc_abbrev): Update.
8166         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
8167         (abbrev_table::read): New static method, renamed from
8168         abbrev_table_read_table.
8169         (abbrev_table::alloc_abbrev)
8170         (abbrev_table::add_abbrev): Now private.
8171         (abbrev_table::abbrev_table): Now private.
8172         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
8173
8174 2020-02-08  Tom Tromey  <tom@tromey.com>
8175
8176         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
8177         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
8178         htab_up.
8179
8180 2020-02-08  Tom Tromey  <tom@tromey.com>
8181
8182         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
8183         htab_up.
8184         (lookup_dwo_unit_in_dwp): Update.
8185         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
8186         on obstack.
8187
8188 2020-02-08  Tom Tromey  <tom@tromey.com>
8189
8190         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
8191         obstack.
8192
8193 2020-02-08  Tom Tromey  <tom@tromey.com>
8194
8195         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
8196         line_header_hash.
8197         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
8198         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
8199         Change type to htab_up.
8200
8201 2020-02-08  Tom Tromey  <tom@tromey.com>
8202
8203         * dwarf2/read.c (allocate_type_unit_groups_table): Return
8204         htab_up.  Don't allocate on obstack.
8205         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
8206         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
8207         Change type to htab_up.
8208
8209 2020-02-08  Tom Tromey  <tom@tromey.com>
8210
8211         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
8212         Change type to htab_up.
8213         * dwarf2/read.c (create_signatured_type_table_from_index)
8214         (create_signatured_type_table_from_debug_names)
8215         (create_all_type_units, add_type_unit)
8216         (lookup_dwo_signatured_type, lookup_signatured_type)
8217         (process_skeletonless_type_unit): Update.
8218         (create_debug_type_hash_table, create_debug_types_hash_table):
8219         Change type of types_htab.
8220         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
8221         htab_up.  Don't allocate on obstack.
8222         (create_cus_hash_table): Change type of cus_htab parameter.
8223         (struct dwo_file) <cus, tus>: Now htab_up.
8224         (lookup_dwo_signatured_type, lookup_dwo_cutu)
8225         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
8226         (queue_and_load_all_dwo_tus): Update.
8227         * dwarf2/index-write.c (write_gdbindex): Update.
8228         (write_debug_names): Update.
8229
8230 2020-02-08  Tom Tromey  <tom@tromey.com>
8231
8232         * dwarf2/read.h (struct dwarf2_queue_item): Move from
8233         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
8234         destructor.
8235         (struct dwarf2_per_objfile) <queue>: New member.
8236         * dwarf2/read.c (struct dwarf2_queue_item): Move to
8237         dwarf2/read.h.
8238         (dwarf2_queue, dwarf2_queue_tail): Remove.
8239         (class dwarf2_queue_guard): Add parameter to constructor.  Use
8240         DISABLE_COPY_AND_ASSIGN.
8241         <m_per_objfile>: New member.
8242         <~dwarf2_queue_guard>: Rewrite.
8243         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
8244         Update.
8245         (~dwarf2_queue_item): New.
8246
8247 2020-02-08  Tom Tromey  <tom@tromey.com>
8248
8249         * dwarf2/read.c (struct die_info) <has_children>: New member.
8250         (dw2_get_file_names_reader): Remove has_children.
8251         (dw2_get_file_names): Update.
8252         (read_cutu_die_from_dwo): Remove has_children.
8253         (cutu_reader::init_tu_and_read_dwo_dies)
8254         (cutu_reader::cutu_reader): Update.
8255         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
8256         Remove has_children.
8257         (build_type_psymtabs_1, process_skeletonless_type_unit)
8258         (load_partial_comp_unit, load_full_comp_unit): Update.
8259         (create_dwo_cu_reader): Remove has_children.
8260         (create_cus_hash_table, read_die_and_children): Update.
8261         (read_full_die_1,read_full_die): Remove has_children.
8262         (read_signatured_type): Update.
8263         (class cutu_reader) <has_children>: Remove.
8264
8265 2020-02-08  Tom Tromey  <tom@tromey.com>
8266
8267         * dwarf2/expr.c: Rename from dwarf2expr.c.
8268         * dwarf2/expr.h: Rename from dwarf2expr.h.
8269         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
8270         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
8271         * dwarf2/frame.c: Rename from dwarf2-frame.c.
8272         * dwarf2/frame.h: Rename from dwarf2-frame.h.
8273         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
8274         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
8275         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
8276         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
8277         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
8278         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
8279         * dwarf2/loc.c: Rename from dwarf2loc.c.
8280         * dwarf2/loc.h: Rename from dwarf2loc.h.
8281         * dwarf2/read.c: Rename from dwarf2read.c.
8282         * dwarf2/read.h: Rename from dwarf2read.h.
8283         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
8284         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
8285         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
8286         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
8287         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
8288         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
8289         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
8290         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
8291         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
8292         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
8293         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
8294         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
8295         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
8296         Update.
8297         * Makefile.in (COMMON_SFILES): Update.
8298         (HFILES_NO_SRCDIR): Update.
8299
8300 2020-02-08  Tom Tromey  <tom@tromey.com>
8301
8302         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
8303         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
8304
8305 2020-02-08  Tom Tromey  <tom@tromey.com>
8306
8307         * dwarf2read.h (struct die_info): Don't declare.
8308
8309 2020-02-08  Tom Tromey  <tom@tromey.com>
8310
8311         * dwarf2read.h (die_info_ptr): Remove typedef.
8312
8313 2020-02-08  Tom Tromey  <tom@tromey.com>
8314
8315         * dwarf2read.c (read_call_site_scope)
8316         (handle_data_member_location, dwarf2_add_member_fn)
8317         (mark_common_block_symbol_computed, read_common_block)
8318         (attr_to_dynamic_prop, partial_die_info::read)
8319         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
8320         (dwarf2_symbol_mark_computed, set_die_type): Update.
8321         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
8322         method.
8323         (attr_form_is_block): Don't declare.
8324         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
8325
8326 2020-02-08  Tom Tromey  <tom@tromey.com>
8327
8328         * dwarf2read.c (dwarf2_find_base_address, )
8329         (read_call_site_scope, rust_containing_type)
8330         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
8331         (handle_data_member_location, dwarf2_add_member_fn)
8332         (get_alignment, read_structure_type, process_structure_scope)
8333         (mark_common_block_symbol_computed, read_common_block)
8334         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
8335         (partial_die_info::read, read_attribute_value, new_symbol)
8336         (lookup_die_type, dwarf2_get_ref_die_offset)
8337         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
8338         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
8339         (dwarf2_symbol_mark_computed): Update.
8340         * dwarf2/attribute.h (struct attribute) <value_as_address,
8341         form_is_section_offset, form_is_constant, form_is_ref>: Declare
8342         methods.
8343         (value_as_address, attr_form_is_section_offset)
8344         (attr_form_is_constant, attr_form_is_ref): Don't declare.
8345         * dwarf2/attribute.c (attribute::value_as_address)
8346         (attribute::form_is_section_offset, attribute::form_is_constant)
8347         (attribute::form_is_ref): Now methods.
8348
8349 2020-02-08  Tom Tromey  <tom@tromey.com>
8350
8351         * dwarf2read.c (struct attribute, DW_STRING)
8352         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
8353         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
8354         (attr_form_is_block, attr_form_is_section_offset)
8355         (attr_form_is_constant, attr_form_is_ref): Move.
8356         * dwarf2/attribute.h: New file.
8357         * dwarf2/attribute.c: New file, from dwarf2read.c.
8358         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
8359
8360 2020-02-08  Tom Tromey  <tom@tromey.com>
8361
8362         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
8363         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
8364         Move.
8365         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
8366         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
8367         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
8368         abbrev.c.
8369         * dwarf2/abbrev.h: New file.
8370         * dwarf2/abbrev.c: New file, from dwarf2read.c.
8371         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
8372
8373 2020-02-08  Tom Tromey  <tom@tromey.com>
8374
8375         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
8376         (dwarf2_section_size, dwarf2_get_section_info)
8377         (create_signatured_type_table_from_debug_names)
8378         (create_addrmap_from_aranges, read_debug_names_from_section)
8379         (get_gdb_index_contents_from_section, read_comp_unit_head)
8380         (error_check_comp_unit_head, read_abbrev_offset)
8381         (create_debug_type_hash_table, init_cu_die_reader)
8382         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
8383         (read_comp_units_from_section, create_cus_hash_table)
8384         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
8385         (create_dwp_v2_section, dwarf2_rnglists_process)
8386         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
8387         (abbrev_table_read_table, read_indirect_string_at_offset_from)
8388         (read_indirect_string_from_dwz, read_addr_index_1)
8389         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
8390         (dwarf_decode_macro_bytes, dwarf_decode_macros)
8391         (fill_in_loclist_baton): Update.
8392         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
8393         get_containing_section, get_bfd_owner, get_bfd_section,
8394         get_file_name, get_id, get_flags, empty, read>: Declare methods.
8395         (dwarf2_read_section, get_section_name, get_section_file_name)
8396         (get_containing_section, get_section_bfd_owner)
8397         (get_section_bfd_section, get_section_name, get_section_file_name)
8398         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
8399         declare.
8400         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
8401         (dwarf2_section_info::get_bfd_owner)
8402         (dwarf2_section_info::get_bfd_section)
8403         (dwarf2_section_info::get_name)
8404         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
8405         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
8406         (dwarf2_section_info::read): Now methods.
8407         * dwarf-index-write.c (class debug_names): Update.
8408
8409 2020-02-08  Tom Tromey  <tom@tromey.com>
8410
8411         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
8412         Move to dwarf2/section.h.
8413         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
8414         (get_section_bfd_section, get_section_name)
8415         (get_section_file_name, get_section_id, get_section_flags)
8416         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
8417         dwarf2/section.c.
8418         * dwarf2/section.h: New file.
8419         * dwarf2/section.c: New file, from dwarf2read.c.
8420         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
8421
8422 2020-02-08  Tom Tromey  <tom@tromey.com>
8423
8424         * dwarf2read.h (read_unsigned_leb128): Don't declare.
8425         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
8426         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
8427         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
8428         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
8429         * dwarf2/leb.h: New file, from dwarf2read.c.
8430         * dwarf2/leb.c: New file, from dwarf2read.c.
8431         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
8432         Remove.
8433         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
8434         (COMMON_SFILES): Add dwarf2/leb.c.
8435
8436 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
8437
8438         GDB 9.1 released.
8439
8440 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8441
8442         PR gdb/25190:
8443         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
8444         * gdb/remote.c (remote_console_output): Update.
8445         * gdb/ui-file.c (fputs_unfiltered): Rename to...
8446         (ui_file_puts): ...this.
8447         * gdb/ui-file.h (ui_file_puts): Add declaration.
8448         * gdb/utils.c (emit_style_escape): Update.
8449         (flush_wrap_buffer): Update.
8450         (fputs_maybe_filtered): Update.
8451         (fputs_unfiltered): Add function.
8452
8453 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8454
8455         * gdb/event-loop.c (gdb_wait_for_event): Update.
8456         * gdb/printcmd.c (printf_command): Update.
8457         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
8458         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
8459         (gdb_os_flush_stderr): Update.
8460         * gdb/remote.c (remote_console_output): Update.
8461         * gdb/ui-file.c (gdb_flush): Rename to...
8462         (ui_file_flush): ...this.
8463         (stderr_file::write): Update.
8464         (stderr_file::puts): Update.
8465         * gdb/ui-file.h (gdb_flush): Rename to...
8466         (ui_file_flush): ...this.
8467         * gdb/utils.c (gdb_flush): Add function.
8468         * gdb/utils.h (gdb_flush): Add declaration.
8469
8470 2020-02-07  Tom Tromey  <tromey@adacore.com>
8471
8472         PR breakpoints/24915:
8473         * source.c (find_and_open_source): Do not check basenames_may_differ.
8474
8475 2020-02-07  Tom Tromey  <tom@tromey.com>
8476
8477         * README: Update gdbserver documentation.
8478         * gdbserver: Move to top level.
8479         * configure.tgt (build_gdbserver): Remove.
8480         * configure.ac: Remove --enable-gdbserver.
8481         * configure: Rebuild.
8482         * Makefile.in (distclean): Don't mention gdbserver.
8483
8484 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8485
8486         * source-cache.c (source_cache::ensure): Surround
8487         get_plain_source_lines with a try/catch.
8488         (source_cache::get_line_charpos): Get rid of try/catch
8489         and only check for the return value of "ensure".
8490         * tui/tui-source.c (tui_source_window::set_contents):
8491         Simplify "nlines" calculation.
8492
8493 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8494
8495         * MAINTAINERS (Write After Approval): Add myself.
8496
8497 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8498
8499         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
8500         function call.
8501
8502 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8503
8504         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
8505
8506 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
8507
8508         * nat/riscv-linux-tdesc.h: New file.
8509         * nat/riscv-linux-tdesc.c: New file, taking code from...
8510         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8511         ... here.
8512         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
8513         NATDEPFILES.
8514
8515 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
8516
8517         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
8518         we don't set the fake simulator ptid to the null_ptid.
8519
8520 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
8521
8522         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
8523         * gdbthread.h (class thread_info) <resumed>: Likewise.
8524         * infrun.c (resume_1): Likewise.
8525         (proceed): Likewise.
8526         (infrun_thread_stop_requested): Likewise.
8527         (stop_all_threads): Likewise.
8528         (handle_inferior_event): Likewise.
8529         (restart_threads): Likewise.
8530         (finish_step_over): Likewise.
8531         (keep_going_stepped_thread): Likewise.
8532         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
8533         (linux_handle_extended_wait): Likewise.
8534         * record-btrace.c (get_thread_current_frame_id): Likewise.
8535         * record-full.c (record_full_wait_1): Likewise.
8536         * remote.c (remote_target::process_initial_stop_replies): Likewise.
8537         * target.c (target_resume): Likewise.
8538         * thread.c (set_running_thread): Likewise.
8539
8540 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8541
8542         * f-valprint.c (f77_print_array_1): Changed datatype of index
8543         variable to LONGEST from int to enable it to contain bound
8544         values correctly.
8545
8546 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
8547
8548         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
8549         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
8550         offsets according to FLEN determined.
8551         (riscv_linux_nat_target::read_description): Determine FLEN
8552         dynamically.
8553         (riscv_linux_nat_target::fetch_registers): Size regset buffer
8554         according to FLEN determined.
8555         (riscv_linux_nat_target::store_registers): Likewise.
8556
8557 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8558
8559         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8560         when reg->group is empty and reggroup is not.
8561
8562 2020-01-31  Tom Tromey  <tromey@adacore.com>
8563
8564         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
8565         Call beneath target's mourn_inferior after unpushing.
8566
8567 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8568
8569         PR tui/9765
8570         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
8571         have enough lines to fill the screen, still return the lowest
8572         address we found.
8573
8574 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8575
8576         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
8577         '-', '<', and '>' commands.
8578
8579 2020-01-29  Pedro Alves  <palves@redhat.com>
8580             Sergio Durigan Junior  <sergiodj@redhat.com>
8581
8582         * infcmd.c (construct_inferior_arguments): Assert that
8583         'argc' is greater than 0.
8584
8585 2020-01-29  Luis Machado  <luis.machado@linaro.org>
8586
8587         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
8588         (BRK_INSN_MASK): Define to 0xd4200000.
8589         (aarch64_program_breakpoint_here_p): New function.
8590         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
8591         * arch-utils.c (default_program_breakpoint_here_p): Moved from
8592         breakpoint.c.
8593         * arch-utils.h (default_program_breakpoint_here_p): Moved from
8594         breakpoint.h
8595         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
8596         call gdbarch_program_breakpoint_here_p.
8597         (program_breakpoint_here): Moved to arch-utils.c, renamed to
8598         default_program_breakpoint_here_p, changed return type to bool and
8599         simplified.
8600         * breakpoint.h (program_breakpoint_here): Moved prototype to
8601         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
8602         return type to bool.
8603         * gdbarch.c: Regenerate.
8604         * gdbarch.h: Regenerate.
8605         * gdbarch.sh (program_breakpoint_here_p): New method.
8606         * infrun.c (handle_signal_stop): Call
8607         gdbarch_program_breakpoint_here_p.
8608
8609 2020-01-26  Tom Tromey  <tom@tromey.com>
8610
8611         * ctfread.c (struct ctf_fp_info): Reindent.
8612         (_initialize_ctfread): Remove.
8613
8614 2020-01-26  Tom Tromey  <tom@tromey.com>
8615
8616         * psymtab.c (partial_map_expand_apply)
8617         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
8618         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
8619         (psym_print_stats, psym_expand_symtabs_for_function)
8620         (psym_map_symbol_filenames, psym_map_matching_symbols)
8621         (psym_expand_symtabs_matching)
8622         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
8623         (maintenance_check_psymtabs): Use new methods.
8624         * psympriv.h (struct partial_symtab) <readin_p,
8625         get_compunit_symtab>: New methods.
8626         <readin, compunit_symtab>: Remove members.
8627         (struct standard_psymtab): New.
8628         (struct legacy_psymtab): Derive from standard_psymtab.
8629         * dwarf2read.h (struct dwarf2_psymtab): Derive from
8630         standard_psymtab.
8631         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
8632
8633 2020-01-26  Tom Tromey  <tom@tromey.com>
8634
8635         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
8636         read_dependencies.  Add assert.
8637         * psymtab.c (partial_symtab::read_dependencies): New method.
8638         * psympriv.h (struct partial_symtab) <read_dependencies>: New
8639         method.
8640         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
8641         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
8642         read_dependencies.
8643         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
8644         Add assert.
8645
8646 2020-01-26  Tom Tromey  <tom@tromey.com>
8647
8648         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
8649         Call expand_psymtab.
8650         (xcoff_read_symtab): Call expand_psymtab.
8651         (xcoff_start_psymtab, xcoff_end_psymtab): Set
8652         legacy_expand_psymtab.
8653         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
8654         method.
8655         (struct legacy_psymtab) <expand_psymtab>: Implement.
8656         <legacy_expand_psymtab>: New member.
8657         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
8658         (parse_partial_symbols): Set legacy_expand_psymtab.
8659         (psymtab_to_symtab_1): Change argument order.  Call
8660         expand_psymtab.
8661         (new_psymtab): Set legacy_expand_psymtab.
8662         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
8663         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
8664         expand_psymtab.
8665         (dwarf2_psymtab::expand_psymtab): Rename from
8666         psymtab_to_symtab_1.  Call expand_psymtab.
8667         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
8668         (dbx_end_psymtab): Likewise.
8669         (dbx_psymtab_to_symtab_1): Change argument order. Call
8670         expand_psymtab.
8671         (dbx_read_symtab): Call expand_psymtab.
8672         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
8673         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
8674         (ctf_psymtab::read_symtab): Call expand_psymtab.
8675
8676 2020-01-26  Tom Tromey  <tom@tromey.com>
8677
8678         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
8679         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
8680         messages.
8681         * mdebugread.c (mdebug_read_symtab): Remove prints.
8682         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
8683         assert.
8684         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
8685
8686 2020-01-26  Tom Tromey  <tom@tromey.com>
8687
8688         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
8689         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
8690         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
8691         legacy_symtab.
8692         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
8693         * psymtab.c (psymtab_to_symtab): Call method.
8694         (dump_psymtab): Update.
8695         * psympriv.h (struct partial_symtab): Add virtual destructor.
8696         <read_symtab>: New method.
8697         (struct legacy_symtab): New.
8698         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
8699         (struct pst_map) <pst>: Now a legacy_psymtab.
8700         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
8701         (new_psymtab): Use legacy_psymtab.
8702         * dwarf2read.h (struct dwarf2_psymtab): New.
8703         (struct dwarf2_per_cu_data) <psymtab>: Use it.
8704         * dwarf2read.c (dwarf2_create_include_psymtab)
8705         (dwarf2_build_include_psymtabs, create_type_unit_group)
8706         (create_partial_symtab, process_psymtab_comp_unit_reader)
8707         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
8708         (set_partial_user): Use dwarf2_psymtab.
8709         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
8710         (psymtab_to_symtab_1, process_full_comp_unit)
8711         (process_full_type_unit, dwarf2_ranges_read)
8712         (dwarf2_get_pc_bounds, psymtab_include_file_name)
8713         (dwarf_decode_lines): Use dwarf2_psymtab.
8714         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
8715         (add_address_entry_worker, write_one_signatured_type)
8716         (recursively_count_psymbols, recursively_write_psymbols)
8717         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
8718         (write_debug_names): Likewise.
8719         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
8720         <pst>: Now a legacy_psymtab.
8721         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
8722         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
8723         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
8724         * ctfread.c (struct ctf_psymtab): New.
8725         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
8726         ctf_psymtab.
8727         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
8728         (create_partial_symtab): Return a ctf_psymtab.
8729         (scan_partial_symbols): Update.
8730
8731 2020-01-26  Tom Tromey  <tom@tromey.com>
8732
8733         * xcoffread.c (xcoff_start_psymtab): Use new.
8734         * psymtab.c (partial_symtab::partial_symtab): New constructor,
8735         renamed from start_psymtab_common.
8736         * psympriv.h (struct partial_symtab): Add new constructor.
8737         (start_psymtab_common): Don't declare.
8738         * mdebugread.c (parse_partial_symbols): Use new.
8739         * dwarf2read.c (create_partial_symtab): Use new.
8740         * dbxread.c (start_psymtab): Use new.
8741         * ctfread.c (create_partial_symtab): Use new.
8742
8743 2020-01-26  Tom Tromey  <tom@tromey.com>
8744
8745         * xcoffread.c (xcoff_end_psymtab): Use new.
8746         * psymtab.c (start_psymtab_common): Use new.
8747         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
8748         Update.
8749         * psympriv.h (struct partial_symtab): Add parameters to
8750         constructor.  Don't inline.
8751         (allocate_psymtab): Don't declare.
8752         * mdebugread.c (new_psymtab): Use new.
8753         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
8754         * dbxread.c (dbx_end_psymtab): Use new.
8755
8756 2020-01-26  Tom Tromey  <tom@tromey.com>
8757
8758         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
8759         allocate_psymtab.  Update documentation.
8760         * psymtab.c (psymtab_storage::install_psymtab): Rename from
8761         allocate_psymtab.  Do not use new.
8762         (allocate_psymtab): Use new.  Update.
8763
8764 2020-01-26  Tom Tromey  <tom@tromey.com>
8765
8766         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
8767         * psymtab.c (psym_print_stats): Update.
8768         * psympriv.h (struct partial_symtab) <readin,
8769         psymtabs_addrmap_supported, anonymous>: Now bool.
8770         * mdebugread.c (psymtab_to_symtab_1): Update.
8771         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
8772         (build_type_psymtabs_reader, psymtab_to_symtab_1)
8773         (process_full_comp_unit, process_full_type_unit): Update.
8774         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
8775         * ctfread.c (psymtab_to_symtab): Update.
8776
8777 2020-01-26  Tom Tromey  <tom@tromey.com>
8778
8779         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
8780         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
8781         * psymtab.c (psymtab_storage): Delete psymtabs.
8782         (psymtab_storage::allocate_psymtab): Use new.
8783         (psymtab_storage::discard_psymtab): Use delete.
8784         * psympriv.h (struct partial_symtab): Add constructor and
8785         initializers.
8786
8787 2020-01-26  Tom Tromey  <tom@tromey.com>
8788
8789         * machoread.c: Do not include psympriv.h.
8790
8791 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8792
8793         * NEWS: Mention the new option and the set/show commands.
8794
8795 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8796
8797         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
8798         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
8799         (validate_exec_file): New variables, enums, functions.
8800         (exec_file_locate_attach, print_section_info): Style the filenames.
8801         (_initialize_exec): Install show_exec_file_mismatch_command and
8802          set_exec_file_mismatch_command.
8803         * gdbcore.h (validate_exec_file): Declare.
8804         * infcmd.c (attach_command): Call validate_exec_file.
8805         * remote.c ( remote_target::remote_add_inferior): Likewise.
8806
8807 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8808
8809         * frame.c (find_frame_sal): Move call to get_next_frame into more
8810         inner scope.
8811         * inline-frame.c (inilne_state) <inline_state>: Update argument
8812         types.
8813         (inilne_state) <skipped_symbol>: Rename to...
8814         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
8815         (skip_inline_frames): Build vector of skipped symbols and use this
8816         to reate the inline_state.
8817         (inline_skipped_symbol): Add a comment and some assertions, fetch
8818         skipped symbol from the list.
8819
8820 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8821
8822         * buildsym.c (lte_is_less_than): Delete.
8823         (buildsym_compunit::end_symtab_with_blockvector): Create local
8824         lambda function to sort line table entries, and use
8825         std::stable_sort instead of std::sort.
8826         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
8827         markers when looking for a previous line.
8828
8829 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8830
8831         * dwarf2read.c (lnp_state_machine::record_line): Include
8832         end_sequence parameter in debug print out.  Record the line if we
8833         are at an end_sequence marker even if it's not the start of a
8834         statement.
8835         * symmisc.c (maintenance_print_one_line_table): Print end of
8836         sequence markers with 'END' not '0'.
8837
8838 2020-01-24  Pedro Alves  <palves@redhat.com>
8839
8840         PR gdb/25410
8841         * thread.c (scoped_restore_current_thread::restore): Use
8842         switch_to_inferior_no_thread.
8843         * exec.c: Include "progspace-and-thread.h".
8844         (add_target_sections, remove_target_sections):
8845         scoped_restore_current_pspace_and_thread instead of
8846         scoped_restore_current_thread.
8847         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
8848         and aspace to the inferior before calling clone_program_space.
8849         Remove stale comment.
8850
8851 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8852
8853         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
8854         (arm_netbsd_nat_target::fetch_registers): ...this.
8855         (arm_nbsd_nat_target::store_registers): Rename to...
8856         (arm_netbsd_nat_target::store_registers): ...this.
8857
8858 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8859
8860         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8861         register_t.
8862
8863 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8864
8865         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
8866         Update comment.
8867         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
8868         Likewise.
8869         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
8870         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
8871         the correct replacement (iterate_over_regset_sections).
8872         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
8873         Update comment.
8874
8875 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
8876
8877         PR gdb/23718
8878         * gdb/python/python.c (execute_gdb_command): Call
8879         async_enable_stdin in catch block.
8880
8881 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
8884         SWITCH_THRU_ALL_UIS.
8885
8886 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8887
8888         PR tui/9765
8889         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
8890         comment, add extra parameter, and update to store previous symbol
8891         when appropriate.
8892         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
8893         add extra parameter.
8894         * tui/tui-disasm.c (tui_disassemble): Update header comment,
8895         remove unneeded parameter, add try/catch around gdb_print_insn,
8896         rewrite to add items to asm_lines vector.
8897         (tui_find_backward_disassembly_start_address): New function.
8898         (tui_find_disassembly_address): Updated throughout.
8899         (tui_disasm_window::set_contents): Update for changes to
8900         tui_disassemble.
8901         (tui_disasm_window::do_scroll_vertical): No need to adjust the
8902         number of lines to scroll.
8903
8904 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
8905
8906         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
8907         (SECT_OFF_DATA): Likewise.
8908         (SECT_OFF_RODATA): Likewise.
8909         (SECT_OFF_TEXT): Likewise.
8910         (SECT_OFF_BSS): Likewise.
8911         (struct objfile) <text_section_offset, data_section_offset>: New
8912         methods.
8913         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
8914         objfile::text_section_offset.
8915         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
8916         * coffread.c (coff_symtab_read): Likewise.
8917         (enter_linenos): Likewise.
8918         (process_coff_symbol): Likewise.
8919         * ctfread.c (get_objfile_text_range): Likewise.
8920         * dtrace-probe.c (dtrace_probe::get_relocated_address):
8921         Use objfile::data_section_offset.
8922         * dwarf2-frame.c (execute_cfa_program): Use
8923         objfile::text_section_offset.
8924         (dwarf2_frame_find_fde): Likewise.
8925         * dwarf2read.c (create_addrmap_from_index): Likewise.
8926         (create_addrmap_from_aranges): Likewise.
8927         (dw2_find_pc_sect_compunit_symtab): Likewise.
8928         (process_psymtab_comp_unit_reader): Likewise.
8929         (add_partial_symbol): Likewise.
8930         (add_partial_subprogram): Likewise.
8931         (process_full_comp_unit): Likewise.
8932         (read_file_scope): Likewise.
8933         (read_func_scope): Likewise.
8934         (read_lexical_block_scope): Likewise.
8935         (read_call_site_scope): Likewise.
8936         (dwarf2_rnglists_process): Likewise.
8937         (dwarf2_ranges_process): Likewise.
8938         (dwarf2_ranges_read): Likewise.
8939         (dwarf_decode_lines_1): Likewise.
8940         (new_symbol): Likewise.
8941         (dwarf2_fetch_die_loc_sect_off): Likewise.
8942         (dwarf2_per_cu_text_offset): Likewise.
8943         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
8944         * hppa-tdep.c (read_unwind_info): Likewise.
8945         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
8946         * psympriv.h (struct partial_symtab): Likewise.
8947         * psymtab.c (find_pc_sect_psymtab): Likewise.
8948         * solib-svr4.c (enable_break): Likewise.
8949         * stap-probe.c (relocate_address): Use
8950         objfile::data_section_offset.
8951         * xcoffread.c (enter_line_range): Use
8952         objfile::text_section_offset.
8953         (read_xcoff_symtab): Likewise.
8954
8955 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8956
8957         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
8958         declaration to narrower scopes.
8959
8960 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8961
8962         * darwin-nat.h (struct darwin_exception_msg, enum
8963         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
8964         Move up.
8965         (class darwin_nat_target) <wait_1, check_new_threads,
8966         decode_exception_message, decode_message, stop_inferior,
8967         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
8968         * darwin-nat.c (darwin_check_new_threads): Rename to...
8969         (darwin_nat_target::check_new_threads): ... this.
8970         (darwin_suspend_inferior_it): Remove.
8971         (darwin_decode_exception_message): Rename to...
8972         (darwin_nat_target::decode_exception_message): ... this.
8973         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8974         (darwin_decode_message): Rename to...
8975         (darwin_nat_target::decode_message): ... this.
8976         (cancel_breakpoint): Rename to...
8977         (darwin_nat_target::cancel_breakpoint): ... this.
8978         (darwin_wait): Rename to...
8979         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8980         instead of iterate_over_inferiors.
8981         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8982         (darwin_stop_inferior): Rename to...
8983         (darwin_nat_target::stop_inferior): ... this.
8984         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8985         (darwin_init_thread_list): Rename to...
8986         (darwin_nat_target::init_thread_list): ... this.
8987         (darwin_ptrace_him): Rename to...
8988         (darwin_nat_target::ptrace_him): ... this.
8989         (darwin_nat_target::create_inferior): Pass lambda function to
8990         fork_inferior.
8991         (darwin_nat_target::detach): Call stop_inferior instead of
8992         darwin_stop_inferior.
8993         * fork-inferior.h (fork_inferior): Change init_trace_fun
8994         parameter to gdb::function_view.
8995         * fork-inferior.c (fork_inferior): Likewise.
8996
8997 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8998
8999         * i386-cygwin-tdep.c (core_process_module_section): Update.
9000         * windows-nat.c (struct lm_info_windows): Add text_offset.
9001         (windows_xfer_shared_libraries): Update.
9002         * windows-tdep.c (windows_xfer_shared_library):
9003         Add text_offset_cached argument.
9004         * windows-tdep.h (windows_xfer_shared_library): Update.
9005
9006 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9007
9008         * gdbarch.sh: Add declaration for _initialize_gdbarch.
9009
9010 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9011
9012         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
9013         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
9014         replace with range-based for.
9015         (gdbsim_interrupt_inferior): Remove.
9016         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
9017         with a range-based for.  Inline code from
9018         gdbsim_interrupt_inferior.
9019
9020 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9021
9022         * infrun.c (proceed): Fix indentation.
9023
9024 2020-01-21  Tom Tromey  <tromey@adacore.com>
9025
9026         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
9027         * python/python.c (python_extension_ops): Update.
9028         (gdbpy_colorize): New function.
9029         * python/lib/gdb/__init__.py (colorize): New function.
9030         * extension.h (ext_lang_colorize): Declare.
9031         * extension.c (ext_lang_colorize): New function.
9032         * extension-priv.h (struct extension_language_ops) <colorize>: New
9033         member.
9034         * cli/cli-style.c (_initialize_cli_style): Update help text.
9035
9036 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9037
9038         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
9039         <cond>: Change type to bool.
9040         (aarch64_displaced_step_b_cond): Update cond to use bool type.
9041         (aarch64_displaced_step_cb): Likewise.
9042         (aarch64_displaced_step_tb): Likewise.
9043
9044 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9045
9046         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
9047         output.
9048
9049 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9050
9051         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
9052         <pc_adjust>: Adjust the documentation.
9053         (aarch64_displaced_step_fixup): Check if PC really moved before
9054         adjusting it.
9055
9056 2020-01-19  Tom Tromey  <tom@tromey.com>
9057
9058         * disasm.c (~gdb_disassembler): New destructor.
9059         (gdb_buffered_insn_length): Call disassemble_free_target.
9060         * disasm.h (class gdb_disassembler): Declare destructor.  Use
9061         DISABLE_COPY_AND_ASSIGN.
9062
9063 2020-01-19  Tom Tromey  <tom@tromey.com>
9064
9065         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
9066         (die_reader_func_ftype): Remove.
9067         (cutu_reader): New class.
9068         (dw2_get_file_names_reader): Remove "data" parameter.
9069         (dw2_get_file_names): Use cutu_reader.
9070         (create_debug_type_hash_table): Update.
9071         (read_cutu_die_from_dwo): Update comment.
9072         (lookup_dwo_unit): Add dwo_name parameter.
9073         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
9074         die_reader_func_ftype and data parameters.
9075         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
9076         Remove die_reader_func_ftype and data parameters.
9077         (~cutu_reader): New; from init_cutu_and_read_dies.
9078         (cutu_reader::cutu_reader): Rename from
9079         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
9080         and data parameters.
9081         (init_cutu_and_read_dies_simple): Remove.
9082         (struct process_psymtab_comp_unit_data): Remove.
9083         (process_psymtab_comp_unit_reader): Remove data parameter; add
9084         want_partial_unit and pretend_language parameters.
9085         (process_psymtab_comp_unit): Use cutu_reader.
9086         (build_type_psymtabs_reader): Remove data parameter.
9087         (build_type_psymtabs_1): Use cutu_reader.
9088         (process_skeletonless_type_unit): Likewise.
9089         (load_partial_comp_unit_reader): Remove.
9090         (load_partial_comp_unit): Use cutu_reader.
9091         (load_full_comp_unit_reader): Remove.
9092         (load_full_comp_unit): Use cutu_reader.
9093         (struct create_dwo_cu_data): Remove.
9094         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
9095         dwo_unit parameters.
9096         (create_cus_hash_table): Use cutu_reader.
9097         (struct dwarf2_read_addr_index_data): Remove.
9098         (dwarf2_read_addr_index_reader): Remove.
9099         (dwarf2_read_addr_index): Use cutu_reader.
9100         (read_signatured_type_reader): Remove.
9101         (read_signatured_type): Use cutu_reader.
9102
9103 2020-01-19  Tom Tromey  <tom@tromey.com>
9104
9105         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
9106         * tui/tui-wingeneral.h (class tui_suppress_output): New.
9107         (tui_wrefresh): Declare.
9108         * tui/tui-wingeneral.c (suppress_output): New global.
9109         (tui_suppress_output, ~tui_suppress_output): New constructor and
9110         destructor.
9111         (tui_wrefresh): New function.
9112         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
9113         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
9114         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
9115         method.
9116         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
9117         tui_wrefresh.
9118         (tui_data_window::no_refresh): New method.
9119         (tui_data_item_window::refresh_window): Call tui_wrefresh.
9120         (tui_reg_command): Use tui_suppress_output
9121         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
9122         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
9123         method.
9124         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
9125
9126 2020-01-19  Tom Tromey  <tom@tromey.com>
9127
9128         * tui/tui-winsource.c (tui_update_source_windows_with_line):
9129         Handle case where symtab is null.
9130
9131 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
9132
9133         * linux-fork.c (one_fork_p): Simplify.
9134
9135 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9136
9137         * top.c (struct qt_args): Remove.
9138         (kill_or_detach): Change return type to void, replace `void *`
9139         parameter with a proper one.
9140         (print_inferior_quit_action):  Likewise.
9141         (quit_confirm): Use range-based for loop to iterate over inferiors.
9142         (quit_force): Likewise.
9143
9144 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9145
9146         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
9147         `void *` parameter with proper parameters.
9148         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
9149         (print_one_inferior): Change return type to void, replace `void *`
9150         parameter with proper parameters.
9151         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
9152         inferiors.
9153         (get_other_inferior): Remove.
9154         (mi_cmd_remove_inferior): Use range-based loop to iterate over
9155         inferiors.
9156
9157 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9158
9159         * mi/mi-interp.c (report_initial_inferior): Remove.
9160         (mi_interp::init): Use range-based for to iterate over inferiors.
9161
9162 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9163
9164         * python/py-inferior.c (build_inferior_list): Remove.
9165         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
9166
9167 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
9168
9169         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
9170         (btrace_stitch_trace): Likewise.
9171         * charset.c (intermediate_encoding): Likewise (vaild).
9172         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
9173         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
9174         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
9175
9176 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
9177
9178         * windows-tdep.c (windows_get_tlb_type):
9179         Add rtl_user_process_parameters type.
9180
9181 2020-01-16  Pedro Alves  <palves@redhat.com>
9182             Norbert Lange  <nolange79@gmail.com>
9183
9184         PR build/24805
9185         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
9186         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
9187         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
9188         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
9189         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
9190         (ps_plog): Redeclare exported functions with default visibility.
9191
9192 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
9193
9194         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
9195         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
9196
9197 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
9198
9199         * infcmd.c (post_create_inferior): Use get_thread_regcache
9200         instead of get_current_regcache.
9201
9202 2020-01-14  Tom Tromey  <tom@tromey.com>
9203
9204         PR symtab/12535:
9205         * python/python.c (gdbpy_decode_line): Treat empty string the same
9206         as no argument.
9207
9208 2020-01-14  Tom Tromey  <tom@tromey.com>
9209
9210         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
9211
9212 2020-01-14  Tom Tromey  <tom@tromey.com>
9213
9214         * nat/linux-btrace.c: Don't include <config.h>.
9215         * nat/linux-ptrace.c: Don't include <config.h>.
9216         * nat/x86-linux-dregs.c: Don't include <config.h>.
9217
9218 2020-01-14  Tom Tromey  <tom@tromey.com>
9219
9220         * configure: Rebuild.
9221         * configure.ac: Move many checks to ../gdbsupport/common.m4.
9222
9223 2020-01-14  Tom Tromey  <tom@tromey.com>
9224
9225         * nat/x86-linux-dregs.c: Include configh.h.
9226         * nat/linux-ptrace.c: Include configh.h.
9227         * nat/linux-btrace.c: Include configh.h.
9228         * defs.h: Include config.h, bfd.h.
9229         * configure.ac: Don't source common.host.
9230         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
9231         * configure: Rebuild.
9232         * acinclude.m4: Update path.
9233         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
9234         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
9235         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
9236         (CLIBS): Add LIBSUPPORT.
9237         (CDEPS): Likewise.
9238         (COMMON_SFILES): Remove gdbsupport files.
9239         (HFILES_NO_SRCDIR): Likewise.
9240         (stamp-version): Update path to create-version.sh.
9241         (ALLDEPFILES): Remove gdbsupport files.
9242
9243 2020-01-14  Tom Tromey  <tom@tromey.com>
9244
9245         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
9246         USE_WIN32API when needed.
9247         * configure.ac (USE_WIN32API): Don't define.
9248         (WIN32LIBS): Use WIN32APILIBS.
9249         * configure: Rebuild.
9250
9251 2020-01-14  Tom Tromey  <tom@tromey.com>
9252
9253         * configure: Rebuild.
9254         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
9255
9256 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9257
9258         * skip.c (skip_function_command): Make skip w/o arguments use the
9259         name of the inlined function if pc is inside any inlined function.
9260
9261 2020-01-14  Luis Machado  <luis.machado@linaro.org>
9262
9263         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
9264         * infrun.c (resume_1): Likewise.
9265         (handle_inferior_event): Remove stale comment.
9266         * linux-nat.c (linux_nat_target::resume): Update comments.
9267         (save_stop_reason): Likewise.
9268         (linux_nat_filter_event): Likewise.
9269         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
9270
9271 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * elfread.c (record_minimal_symbol): Set section index to 0 for
9274         non-allocatable sections.
9275
9276
9277 2020-01-13  Ali Tamur <tamur@google.com>
9278
9279         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
9280         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
9281         to gdb::optional.  Update comments.
9282         (dwo_file): Update comments.
9283         (read_attribute): Update API to take an additional out parameter,
9284         need_reprocess.  This is used to mark attributes that need other
9285         attributes (e.g. str_offsets_base) for correct computation which may not
9286         have been read yet.
9287         (read_attribute_reprocess): New function declaration.
9288         (read_addr_index): Likewise.
9289         (read_dwo_str_index): Likewise.
9290         (read_stub_str_index): Likewise.
9291         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
9292         (lookup_addr_base): New function definition.
9293         (lookup_ranges_base): Likewise.
9294         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
9295         lookup_ranges_base.
9296         (init_cutu_and_read_dies): Update comments.
9297         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
9298         unit.  This is used to inherit parent's str_offsets_base and addr_base.
9299         Update comments.
9300         (init_cutu_and_read_dies_simple): Reflect API changes.
9301         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
9302         (create_cus_hash_table): Change API to take parent compile unit.
9303         Reflect API changes.
9304         (open_and_init_dwo_file): Reflect API changes.
9305         (dwarf2_get_pc_bounds): Update comments.
9306         (dwarf2_record_block_ranges): Likewise.
9307         (read_full_die_1): Change implementation to reprocess attributes that
9308         need str_offsets_base and addr_base.
9309         (partial_die_info::read): Likewise.
9310         (read_attribute_reprocess): New function definition.
9311         (read_attribute_value): Change API to take an additional out parameter,
9312         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
9313         when a non-dwo compile unit has index based attributes.
9314         (read_attribute): Reflect API changes.
9315         (read_addr_index_1): Reflect API changes.  Update comments.
9316         (dwarf2_read_addr_index_data): Reflect API changes.
9317         (dwarf2_read_addr_index): Likewise.
9318         (read_str_index): Change API and implementation.  This becomes a helper
9319         to be used by the new string index related methods.  Update error
9320         message and comments.
9321         (read_dwo_str_index): New function definition.
9322         (read_stub_str_index): Likewise.
9323         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
9324         * symfile.h (dwarf2_debug_sections): Likewise.
9325         * xcoffread.c (dwarf2_debug_sections): Likewise.
9326
9327 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9328
9329         * gdbcore.h (struct core_fns) <core_read_registers>: Change
9330         core_reg_sect type to gdb_byte *.
9331         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
9332         * cris-tdep.c (fetch_core_registers): Likewise.
9333         * corelow.c (core_target::get_core_register_section): Change
9334         type of `contents` to gdb::byte_vector.
9335
9336 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9337
9338         * tui/tui-wingeneral.c (box_win): Position the title in the center
9339         of the border.
9340
9341 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9342
9343         * corelow.c (core_target::get_core_register_section): Use
9344           std::vector instead of alloca.
9345
9346 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9347
9348         * warning.m4: Add -Wmissing-declarations to build_warnings.
9349         * configure: Re-generate.
9350
9351 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9352
9353         * python/python.c (init__gdb_module): Add declaration.
9354
9355 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9356
9357         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
9358         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
9359         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
9360         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
9361         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
9362         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
9363         * ada-exp.y (_initialize_ada_exp): Add declaration.
9364         * ada-lang.c (_initialize_ada_language): Add declaration.
9365         * ada-tasks.c (_initialize_tasks): Add declaration.
9366         * agent.c (_initialize_agent): Add declaration.
9367         * aix-thread.c (_initialize_aix_thread): Add declaration.
9368         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
9369         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
9370         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
9371         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
9372         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
9373         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
9374         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
9375         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
9376         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
9377         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
9378         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
9379         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
9380         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
9381         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
9382         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
9383         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
9384         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
9385         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
9386         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
9387         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
9388         * annotate.c (_initialize_annotate): Add declaration.
9389         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
9390         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
9391         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
9392         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
9393         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
9394         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
9395         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
9396         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
9397         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
9398         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
9399         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
9400         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
9401         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
9402         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
9403         * auto-load.c (_initialize_auto_load): Add declaration.
9404         * auxv.c (_initialize_auxv): Add declaration.
9405         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
9406         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
9407         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
9408         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
9409         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
9410         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
9411         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
9412         * breakpoint.c (_initialize_breakpoint): Add declaration.
9413         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
9414         * btrace.c (_initialize_btrace): Add declaration.
9415         * charset.c (_initialize_charset): Add declaration.
9416         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
9417         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
9418         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
9419         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
9420         * cli/cli-script.c (_initialize_cli_script): Add declaration.
9421         * cli/cli-style.c (_initialize_cli_style): Add declaration.
9422         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
9423         * coffread.c (_initialize_coffread): Add declaration.
9424         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
9425         * compile/compile.c (_initialize_compile): Add declaration.
9426         * complaints.c (_initialize_complaints): Add declaration.
9427         * completer.c (_initialize_completer): Add declaration.
9428         * copying.c (_initialize_copying): Add declaration.
9429         * corefile.c (_initialize_core): Add declaration.
9430         * corelow.c (_initialize_corelow): Add declaration.
9431         * cp-abi.c (_initialize_cp_abi): Add declaration.
9432         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
9433         * cp-support.c (_initialize_cp_support): Add declaration.
9434         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
9435         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
9436         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
9437         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
9438         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
9439         * ctfread.c (_initialize_ctfread): Add declaration.
9440         * d-lang.c (_initialize_d_language): Add declaration.
9441         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
9442         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
9443         * dbxread.c (_initialize_dbxread): Add declaration.
9444         * dcache.c (_initialize_dcache): Add declaration.
9445         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
9446         * disasm.c (_initialize_disasm): Add declaration.
9447         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
9448         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
9449         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
9450         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
9451         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
9452         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
9453         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
9454         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
9455         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
9456         * elfread.c (_initialize_elfread): Add declaration.
9457         * exec.c (_initialize_exec): Add declaration.
9458         * extension.c (_initialize_extension): Add declaration.
9459         * f-lang.c (_initialize_f_language): Add declaration.
9460         * f-valprint.c (_initialize_f_valprint): Add declaration.
9461         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
9462         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
9463         * filesystem.c (_initialize_filesystem): Add declaration.
9464         * findcmd.c (_initialize_mem_search): Add declaration.
9465         * findvar.c (_initialize_findvar): Add declaration.
9466         * fork-child.c (_initialize_fork_child): Add declaration.
9467         * frame-base.c (_initialize_frame_base): Add declaration.
9468         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
9469         * frame.c (_initialize_frame): Add declaration.
9470         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
9471         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
9472         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
9473         * gcore.c (_initialize_gcore): Add declaration.
9474         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
9475         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
9476         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
9477         * gdbarch.c (_initialize_gdbarch): Add declaration.
9478         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
9479         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
9480         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
9481         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
9482         * go-lang.c (_initialize_go_language): Add declaration.
9483         * go32-nat.c (_initialize_go32_nat): Add declaration.
9484         * guile/guile.c (_initialize_guile): Add declaration.
9485         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
9486         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
9487         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
9488         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
9489         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
9490         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
9491         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
9492         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
9493         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
9494         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
9495         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
9496         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
9497         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
9498         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
9499         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
9500         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
9501         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
9502         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
9503         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
9504         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
9505         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
9506         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
9507         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
9508         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
9509         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
9510         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
9511         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
9512         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
9513         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
9514         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
9515         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
9516         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
9517         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
9518         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
9519         * infcall.c (_initialize_infcall): Add declaration.
9520         * infcmd.c (_initialize_infcmd): Add declaration.
9521         * inflow.c (_initialize_inflow): Add declaration.
9522         * infrun.c (_initialize_infrun): Add declaration.
9523         * interps.c (_initialize_interpreter): Add declaration.
9524         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
9525         * jit.c (_initialize_jit): Add declaration.
9526         * language.c (_initialize_language): Add declaration.
9527         * linux-fork.c (_initialize_linux_fork): Add declaration.
9528         * linux-nat.c (_initialize_linux_nat): Add declaration.
9529         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
9530         * linux-thread-db.c (_initialize_thread_db): Add declaration.
9531         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
9532         * m2-lang.c (_initialize_m2_language): Add declaration.
9533         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
9534         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
9535         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
9536         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
9537         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
9538         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
9539         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
9540         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
9541         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
9542         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
9543         * machoread.c (_initialize_machoread): Add declaration.
9544         * macrocmd.c (_initialize_macrocmd): Add declaration.
9545         * macroscope.c (_initialize_macroscope): Add declaration.
9546         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
9547         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
9548         * maint.c (_initialize_maint_cmds): Add declaration.
9549         * mdebugread.c (_initialize_mdebugread): Add declaration.
9550         * memattr.c (_initialize_mem): Add declaration.
9551         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
9552         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
9553         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
9554         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
9555         * mi/mi-main.c (_initialize_mi_main): Add declaration.
9556         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
9557         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
9558         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
9559         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
9560         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
9561         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
9562         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
9563         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
9564         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
9565         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
9566         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
9567         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
9568         * mipsread.c (_initialize_mipsread): Add declaration.
9569         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
9570         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
9571         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
9572         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
9573         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
9574         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
9575         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
9576         * nto-procfs.c (_initialize_procfs): Add declaration.
9577         * objc-lang.c (_initialize_objc_language): Add declaration.
9578         * observable.c (_initialize_observer): Add declaration.
9579         * opencl-lang.c (_initialize_opencl_language): Add declaration.
9580         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
9581         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
9582         * osabi.c (_initialize_gdb_osabi): Add declaration.
9583         * osdata.c (_initialize_osdata): Add declaration.
9584         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
9585         * parse.c (_initialize_parse): Add declaration.
9586         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
9587         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
9588         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
9589         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
9590         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
9591         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
9592         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
9593         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
9594         * printcmd.c (_initialize_printcmd): Add declaration.
9595         * probe.c (_initialize_probe): Add declaration.
9596         * proc-api.c (_initialize_proc_api): Add declaration.
9597         * proc-events.c (_initialize_proc_events): Add declaration.
9598         * proc-service.c (_initialize_proc_service): Add declaration.
9599         * procfs.c (_initialize_procfs): Add declaration.
9600         * producer.c (_initialize_producer): Add declaration.
9601         * psymtab.c (_initialize_psymtab): Add declaration.
9602         * python/python.c (_initialize_python): Add declaration.
9603         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
9604         * record-btrace.c (_initialize_record_btrace): Add declaration.
9605         * record-full.c (_initialize_record_full): Add declaration.
9606         * record.c (_initialize_record): Add declaration.
9607         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
9608         * regcache.c (_initialize_regcache): Add declaration.
9609         * reggroups.c (_initialize_reggroup): Add declaration.
9610         * remote-notif.c (_initialize_notif): Add declaration.
9611         * remote-sim.c (_initialize_remote_sim): Add declaration.
9612         * remote.c (_initialize_remote): Add declaration.
9613         * reverse.c (_initialize_reverse): Add declaration.
9614         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
9615         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
9616         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
9617         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
9618         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
9619         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
9620         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
9621         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
9622         Add declaration.
9623         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
9624         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
9625         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
9626         * rust-exp.y (_initialize_rust_exp): Add declaration.
9627         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
9628         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
9629         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
9630         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
9631         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
9632         * score-tdep.c (_initialize_score_tdep): Add declaration.
9633         * ser-go32.c (_initialize_ser_dos): Add declaration.
9634         * ser-mingw.c (_initialize_ser_windows): Add declaration.
9635         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
9636         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
9637         * ser-uds.c (_initialize_ser_socket): Add declaration.
9638         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
9639         * serial.c (_initialize_serial): Add declaration.
9640         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
9641         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
9642         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
9643         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
9644         * skip.c (_initialize_step_skip): Add declaration.
9645         * sol-thread.c (_initialize_sol_thread): Add declaration.
9646         * solib-aix.c (_initialize_solib_aix): Add declaration.
9647         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
9648         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
9649         * solib-frv.c (_initialize_frv_solib): Add declaration.
9650         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
9651         * solib-target.c (_initialize_solib_target): Add declaration.
9652         * solib.c (_initialize_solib): Add declaration.
9653         * source-cache.c (_initialize_source_cache): Add declaration.
9654         * source.c (_initialize_source): Add declaration.
9655         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
9656         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
9657         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
9658         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
9659         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
9660         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
9661         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
9662         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
9663         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
9664         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
9665         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
9666         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
9667         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
9668         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
9669         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
9670         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
9671         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
9672         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
9673         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
9674         * stabsread.c (_initialize_stabsread): Add declaration.
9675         * stack.c (_initialize_stack): Add declaration.
9676         * stap-probe.c (_initialize_stap_probe): Add declaration.
9677         * std-regs.c (_initialize_frame_reg): Add declaration.
9678         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
9679         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
9680         * symfile.c (_initialize_symfile): Add declaration.
9681         * symmisc.c (_initialize_symmisc): Add declaration.
9682         * symtab.c (_initialize_symtab): Add declaration.
9683         * target.c (_initialize_target): Add declaration.
9684         * target-connection.c (_initialize_target_connection): Add
9685         declaration.
9686         * target-dcache.c (_initialize_target_dcache): Add declaration.
9687         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
9688         * thread.c (_initialize_thread): Add declaration.
9689         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
9690         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
9691         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
9692         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
9693         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
9694         * tracectf.c (_initialize_ctf): Add declaration.
9695         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
9696         * tracefile.c (_initialize_tracefile): Add declaration.
9697         * tracepoint.c (_initialize_tracepoint): Add declaration.
9698         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
9699         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
9700         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
9701         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
9702         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
9703         * tui/tui-win.c (_initialize_tui_win): Add declaration.
9704         * tui/tui.c (_initialize_tui): Add declaration.
9705         * typeprint.c (_initialize_typeprint): Add declaration.
9706         * ui-style.c (_initialize_ui_style): Add declaration.
9707         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
9708         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
9709         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
9710         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
9711         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
9712         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
9713         * unittests/filtered_iterator-selftests.c
9714         (_initialize_filtered_iterator_selftests): Add declaration.
9715         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
9716         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
9717         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
9718         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
9719         * unittests/main-thread-selftests.c
9720         (_initialize_main_thread_selftests): Add declaration.
9721         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
9722         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
9723         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
9724         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
9725         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
9726         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
9727         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
9728         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
9729         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
9730         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
9731         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
9732         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
9733         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
9734         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
9735         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
9736         declaration.
9737         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
9738         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
9739         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
9740         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
9741         * user-regs.c (_initialize_user_regs): Add declaration.
9742         * utils.c (_initialize_utils): Add declaration.
9743         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
9744         * valops.c (_initialize_valops): Add declaration.
9745         * valprint.c (_initialize_valprint): Add declaration.
9746         * value.c (_initialize_values): Add declaration.
9747         * varobj.c (_initialize_varobj): Add declaration.
9748         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
9749         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
9750         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
9751         * windows-nat.c (_initialize_windows_nat): Add declaration.
9752         (_initialize_check_for_gdb_ini): Add declaration.
9753         (_initialize_loadable): Add declaration.
9754         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
9755         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
9756         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
9757         * xcoffread.c (_initialize_xcoffread): Add declaration.
9758         * xml-support.c (_initialize_xml_support): Add declaration.
9759         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
9760         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
9761         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
9762         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
9763
9764 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9765
9766         * regformats/regdat.sh: Generate declaration for init function.
9767
9768 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9769
9770         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
9771         up.
9772         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
9773         close_one_inferior>: New methods.
9774         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
9775         pass down target to find_inferior_pid.
9776         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
9777         Pass down target to find_inferior_ptid.
9778         (gdbsim_target::create_inferior): Pass down target to
9779         add_thread_silent.
9780         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
9781         target down to find_inferior_ptid and switch_to_thread.
9782         (gdbsim_target::close): Update to call close_one_inferior.
9783         (struct resume_data): Remove.
9784         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
9785         directly, rather than through a void pointer.
9786         (gdbsim_target::resume): Update to call resume_one_inferior.
9787
9788 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
9789
9790         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
9791
9792 2020-01-12  Pedro Alves  <palves@redhat.com>
9793
9794         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
9795         directly for the current inferior instead of
9796         discard_all_inferiors.
9797         (discard_all_inferiors): Delete.
9798
9799 2020-01-11  Tom Tromey  <tom@tromey.com>
9800
9801         * tui/tui-wingeneral.c (box_win): Check cli_styling.
9802         * tui/tui-winsource.c (tui_source_window_base::refill): Use
9803         deprecated_safe_get_selected_frame.
9804
9805 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9806
9807         * inferior.c (print_inferior): Switch inferior before printing it.
9808
9809 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
9810             Pedro Alves  <palves@redhat.com>
9811
9812         * progspace-and-thread.c (switch_to_program_space_and_thread):
9813         Assert there's an inferior for PSPACE.  Use
9814         switch_to_inferior_no_thread to switch the inferior too.
9815         * progspace.c (program_space::~program_space): Call
9816         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
9817         (program_space::free_all_objfiles): Don't call clear_symtab_users
9818         here.
9819         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
9820
9821 2020-01-10  Pedro Alves  <palves@redhat.com>
9822
9823         * NEWS: Mention multi-target debugging, "info connections", and
9824         "add-inferior -no-connection".
9825
9826 2020-01-10  Pedro Alves  <palves@redhat.com>
9827
9828         * infrun.c: Include "target-connection.h".
9829         (check_multi_target_resumption): New.
9830         (proceed): Call it.
9831         * target-connection.c (make_target_connection_string): Make
9832         extern.
9833         * target-connection.h (make_target_connection_string): Declare.
9834
9835 2020-01-10  Pedro Alves  <palves@redhat.com>
9836
9837         * Makefile.in (COMMON_SFILES): Add target-connection.c.
9838         * inferior.c (uiout_field_connection): New function.
9839         (print_inferior): Add new "connection-id" column.
9840         (add_inferior_command): Show connection number/string of added
9841         inferior.
9842         * process-stratum-target.h
9843         (process_stratum_target::connection_string): New virtual method.
9844         (process_stratum_target::connection_number): New field.
9845         * remote.c (remote_target::connection_string): New override.
9846         * target-connection.c: New file.
9847         * target-connection.h: New file.
9848         * target.c (decref_target): Remove process_stratum targets from
9849         the connection list.
9850         (target_stack::push): Add process_stratum targets to the
9851         connection list.
9852
9853 2020-01-10  Pedro Alves  <palves@redhat.com>
9854
9855         Revert:
9856         2016-04-12  Pedro Alves  <palves@redhat.com>
9857         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
9858         Remove references to name.
9859         * serial.h (struct serial) <name>: Delete.
9860
9861 2020-01-10  Pedro Alves  <palves@redhat.com>
9862
9863         * gdbarch-selftests.c (register_to_value_test): Remove "target
9864         already pushed" check.
9865
9866 2020-01-10  Pedro Alves  <palves@redhat.com>
9867             John Baldwin  <jhb@FreeBSD.org>
9868
9869         * aarch64-linux-nat.c
9870         (aarch64_linux_nat_target::thread_architecture): Adjust.
9871         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
9872         (task_command_1): Likewise.
9873         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
9874         (aix_thread_target::wait, aix_thread_target::fetch_registers)
9875         (aix_thread_target::store_registers)
9876         (aix_thread_target::thread_alive): Adjust.
9877         * amd64-fbsd-tdep.c: Include "inferior.h".
9878         (amd64fbsd_get_thread_local_address): Pass down target.
9879         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
9880         thread's gdbarch instead of target_gdbarch.
9881         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
9882         get_last_target_status.
9883         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
9884         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
9885         inferiors.
9886         (update_inserted_breakpoint_locations): Skip if inferiors with no
9887         execution.
9888         (update_global_location_list): When handling moribund locations,
9889         find representative inferior for location's pspace, and use thread
9890         count of its process_stratum target.
9891         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
9892         * bsd-uthread.c (bsd_uthread_target::wait): Use
9893         as_process_stratum_target and adjust thread_change_ptid and
9894         add_thread calls.
9895         (bsd_uthread_target::update_thread_list): Use
9896         as_process_stratum_target and adjust find_thread_ptid,
9897         thread_change_ptid and add_thread calls.
9898         * btrace.c (maint_btrace_packet_history_cmd): Adjust
9899         find_thread_ptid call.
9900         * corelow.c (add_to_thread_list): Adjust add_thread call.
9901         (core_target_open): Adjust add_thread_silent and thread_count
9902         calls.
9903         (core_target::pid_to_str): Adjust find_inferior_ptid call.
9904         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
9905         * event-top.c (async_disconnect): Pop targets from all inferiors.
9906         * exec.c (add_target_sections): Push exec target on all inferiors
9907         sharing the program space.
9908         (remove_target_sections): Remove the exec target from all
9909         inferiors sharing the program space.
9910         (exec_on_vfork): New.
9911         * exec.h (exec_on_vfork): Declare.
9912         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
9913         Pass it down.
9914         (fbsd_nat_target::update_thread_list): Adjust.
9915         (fbsd_nat_target::resume): Adjust.
9916         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
9917         down.
9918         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
9919         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
9920         get_thread_arch_regcache call.
9921         * fork-child.c (gdb_startup_inferior): Pass target down to
9922         startup_inferior and set_executing.
9923         * gdbthread.h (struct process_stratum_target): Forward declare.
9924         (add_thread, add_thread_silent, add_thread_with_info)
9925         (in_thread_list): Add process_stratum_target parameter.
9926         (find_thread_ptid(inferior*, ptid_t)): New overload.
9927         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
9928         parameter.
9929         (all_threads()): Delete overload.
9930         (all_threads, all_non_exited_threads): Add process_stratum_target
9931         parameter.
9932         (all_threads_safe): Use brace initialization.
9933         (thread_count): Add process_stratum_target parameter.
9934         (set_resumed, set_running, set_stop_requested, set_executing)
9935         (threads_are_executing, finish_thread_state): Add
9936         process_stratum_target parameter.
9937         (switch_to_thread): Use is_current_thread.
9938         * i386-fbsd-tdep.c: Include "inferior.h".
9939         (i386fbsd_get_thread_local_address): Pass down target.
9940         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
9941         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
9942         have_inferiors check.
9943         * inf-ptrace.c (inf_ptrace_target::create_inferior)
9944         (inf_ptrace_target::attach): Adjust.
9945         * infcall.c (run_inferior_call): Adjust.
9946         * infcmd.c (run_command_1): Pass target to
9947         scoped_finish_thread_state.
9948         (proceed_thread_callback): Skip inferiors with no execution.
9949         (continue_command): Rename 'all_threads' local to avoid hiding
9950         'all_threads' function.  Adjust get_last_target_status call.
9951         (prepare_one_step): Adjust set_running call.
9952         (signal_command): Use user_visible_resume_target.  Compare thread
9953         pointers instead of inferior_ptid.
9954         (info_program_command): Adjust to pass down target.
9955         (attach_command): Mark target's 'thread_executing' flag.
9956         (stop_current_target_threads_ns): New, factored out from ...
9957         (interrupt_target_1): ... this.  Switch inferior before making
9958         target calls.
9959         * inferior-iter.h
9960         (struct all_inferiors_iterator, struct all_inferiors_range)
9961         (struct all_inferiors_safe_range)
9962         (struct all_non_exited_inferiors_range): Filter on
9963         process_stratum_target too.  Remove explicit.
9964         * inferior.c (inferior::inferior): Push dummy target on target
9965         stack.
9966         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
9967         Add process_stratum_target parameter, and pass it down.
9968         (have_live_inferiors): Adjust.
9969         (switch_to_inferior_and_push_target): New.
9970         (add_inferior_command, clone_inferior_command): Handle
9971         "-no-connection" parameter.  Use
9972         switch_to_inferior_and_push_target.
9973         (_initialize_inferior): Mention "-no-connection" option in
9974         the help of "add-inferior" and "clone-inferior" commands.
9975         * inferior.h: Include "process-stratum-target.h".
9976         (interrupt_target_1): Use bool.
9977         (struct inferior) <push_target, unpush_target, target_is_pushed,
9978         find_target_beneath, top_target, process_target, target_at,
9979         m_stack>: New.
9980         (discard_all_inferiors): Delete.
9981         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9982         (all_inferiors, all_non_exited_inferiors): Add
9983         process_stratum_target parameter.
9984         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9985         (target_last_proc_target): New global.
9986         (follow_fork_inferior): Push target on new inferior.  Pass target
9987         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9988         reference count.
9989         (follow_fork): Adjust get_last_target_status call.  Also consider
9990         target.
9991         (follow_exec): Push target on new inferior.
9992         (struct execution_control_state) <target>: New field.
9993         (user_visible_resume_target): New.
9994         (do_target_resume): Call target_async.
9995         (resume_1): Set target's threads_executing flag.  Consider resume
9996         target.
9997         (commit_resume_all_targets): New.
9998         (proceed): Also consider resume target.  Skip threads of inferiors
9999         with no execution.  Commit resumtion in all targets.
10000         (start_remote): Pass current inferior to wait_for_inferior.
10001         (infrun_thread_stop_requested): Consider target as well.  Pass
10002         thread_info pointer to clear_inline_frame_state instead of ptid.
10003         (infrun_thread_thread_exit): Consider target as well.
10004         (random_pending_event_thread): New inferior parameter.  Use it.
10005         (do_target_wait): Rename to ...
10006         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
10007         down.
10008         (threads_are_resumed_pending_p, do_target_wait): New.
10009         (prepare_for_detach): Adjust calls.
10010         (wait_for_inferior): New inferior parameter.  Handle it.  Use
10011         do_target_wait_1 instead of do_target_wait.
10012         (fetch_inferior_event): Adjust.  Switch to representative
10013         inferior.  Pass target down.
10014         (set_last_target_status): Add process_stratum_target parameter.
10015         Save target in global.
10016         (get_last_target_status): Add process_stratum_target parameter and
10017         handle it.
10018         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
10019         (context_switch): Check inferior_ptid == null_ptid before calling
10020         inferior_thread().
10021         (get_inferior_stop_soon): Pass down target.
10022         (wait_one): Rename to ...
10023         (poll_one_curr_target): ... this.
10024         (struct wait_one_event): New.
10025         (wait_one): New.
10026         (stop_all_threads): Adjust.
10027         (handle_no_resumed, handle_inferior_event): Adjust to consider the
10028         event's target.
10029         (switch_back_to_stepped_thread): Also consider target.
10030         (print_stop_event): Update.
10031         (normal_stop): Update.  Also consider the resume target.
10032         * infrun.h (wait_for_inferior): Remove declaration.
10033         (user_visible_resume_target): New declaration.
10034         (get_last_target_status, set_last_target_status): New
10035         process_stratum_target parameter.
10036         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
10037         process_stratum_target parameter, and use it.
10038         (clear_inline_frame_state (thread_info*)): New.
10039         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
10040         process_stratum_target parameter.
10041         (clear_inline_frame_state (thread_info*)): Declare.
10042         * linux-fork.c (delete_checkpoint_command): Pass target down to
10043         find_thread_ptid.
10044         (checkpoint_command): Adjust.
10045         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
10046         instead of just tweaking inferior_ptid.
10047         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
10048         (exit_lwp): Pass target down to find_thread_ptid.
10049         (attach_proc_task_lwp_callback): Pass target down to
10050         add_thread/set_running/set_executing.
10051         (linux_nat_target::attach): Pass target down to
10052         thread_change_ptid.
10053         (get_detach_signal): Pass target down to find_thread_ptid.
10054         Consider last target status's target.
10055         (linux_resume_one_lwp_throw, resume_lwp)
10056         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
10057         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
10058         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
10059         (linux_nat_target::async_wait_fd): New.
10060         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
10061         target down.
10062         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
10063         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
10064         * linux-thread-db.c (struct thread_db_info::process_target): New
10065         field.
10066         (add_thread_db_info): Save target.
10067         (get_thread_db_info): New process_stratum_target parameter.  Also
10068         match target.
10069         (delete_thread_db_info): New process_stratum_target parameter.
10070         Also match target.
10071         (thread_from_lwp): Adjust to pass down target.
10072         (thread_db_notice_clone): Pass down target.
10073         (check_thread_db_callback): Pass down target.
10074         (try_thread_db_load_1): Always push the thread_db target.
10075         (try_thread_db_load, record_thread): Pass target down.
10076         (thread_db_target::detach): Pass target down.  Always unpush the
10077         thread_db target.
10078         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
10079         target down.  Always unpush the thread_db target.
10080         (find_new_threads_callback, thread_db_find_new_threads_2)
10081         (thread_db_target::update_thread_list): Pass target down.
10082         (thread_db_target::pid_to_str): Pass current inferior down.
10083         (thread_db_target::get_thread_local_address): Pass target down.
10084         (thread_db_target::resume, maintenance_check_libthread_db): Pass
10085         target down.
10086         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
10087         * procfs.c (procfs_target::procfs_init_inferior): Declare.
10088         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
10089         (procfs_init_inferior): Rename to ...
10090         (procfs_target::procfs_init_inferior): ... this and adjust.
10091         (procfs_target::create_inferior, procfs_notice_thread)
10092         (procfs_do_thread_registers): Adjust.
10093         * ppc-fbsd-tdep.c: Include "inferior.h".
10094         (ppcfbsd_get_thread_local_address): Pass down target.
10095         * proc-service.c (ps_xfer_memory): Switch current inferior and
10096         program space as well.
10097         (get_ps_regcache): Pass target down.
10098         * process-stratum-target.c
10099         (process_stratum_target::thread_address_space)
10100         (process_stratum_target::thread_architecture): Pass target down.
10101         * process-stratum-target.h
10102         (process_stratum_target::threads_executing): New field.
10103         (as_process_stratum_target): New.
10104         * ravenscar-thread.c
10105         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
10106         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
10107         down.
10108         * record-btrace.c (record_btrace_target::info_record): Adjust.
10109         (record_btrace_target::record_method)
10110         (record_btrace_target::record_is_replaying)
10111         (record_btrace_target::fetch_registers)
10112         (get_thread_current_frame_id, record_btrace_target::resume)
10113         (record_btrace_target::wait, record_btrace_target::stop): Pass
10114         target down.
10115         * record-full.c (record_full_wait_1): Switch to event thread.
10116         Pass target down.
10117         * regcache.c (regcache::regcache)
10118         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
10119         process_stratum_target parameter and handle it.
10120         (current_thread_target): New global.
10121         (get_thread_regcache): Add process_stratum_target parameter and
10122         handle it.  Switch inferior before calling target method.
10123         (get_thread_regcache): Pass target down.
10124         (get_thread_regcache_for_ptid): Pass target down.
10125         (registers_changed_ptid): Add process_stratum_target parameter and
10126         handle it.
10127         (registers_changed_thread, registers_changed): Pass target down.
10128         (test_get_thread_arch_aspace_regcache): New.
10129         (current_regcache_test): Define a couple local test_target_ops
10130         instances and use them for testing.
10131         (readwrite_regcache): Pass process_stratum_target parameter.
10132         (cooked_read_test, cooked_write_test): Pass mock_target down.
10133         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
10134         (get_thread_arch_aspace_regcache): Add process_stratum_target
10135         parameter.
10136         (regcache::target): New method.
10137         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
10138         (regcache::registers_changed_ptid): Add process_stratum_target
10139         parameter.
10140         (regcache::m_target): New field.
10141         (registers_changed_ptid): Add process_stratum_target parameter.
10142         * remote.c (remote_state::supports_vCont_probed): New field.
10143         (remote_target::async_wait_fd): New method.
10144         (remote_unpush_and_throw): Add remote_target parameter.
10145         (get_current_remote_target): Adjust.
10146         (remote_target::remote_add_inferior): Push target.
10147         (remote_target::remote_add_thread)
10148         (remote_target::remote_notice_new_inferior)
10149         (get_remote_thread_info): Pass target down.
10150         (remote_target::update_thread_list): Skip threads of inferiors
10151         bound to other targets.  (remote_target::close): Don't discard
10152         inferiors.  (remote_target::add_current_inferior_and_thread)
10153         (remote_target::process_initial_stop_replies)
10154         (remote_target::start_remote)
10155         (remote_target::remote_serial_quit_handler): Pass down target.
10156         (remote_target::remote_unpush_target): New remote_target
10157         parameter.  Unpush the target from all inferiors.
10158         (remote_target::remote_unpush_and_throw): New remote_target
10159         parameter.  Pass it down.
10160         (remote_target::open_1): Check whether the current inferior has
10161         execution instead of checking whether any inferior is live.  Pass
10162         target down.
10163         (remote_target::remote_detach_1): Pass down target.  Use
10164         remote_unpush_target.
10165         (extended_remote_target::attach): Pass down target.
10166         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
10167         (remote_target::append_resumption): Pass down target.
10168         (remote_target::append_pending_thread_resumptions)
10169         (remote_target::remote_resume_with_hc, remote_target::resume)
10170         (remote_target::commit_resume): Pass down target.
10171         (remote_target::remote_stop_ns): Check supports_vCont_probed.
10172         (remote_target::interrupt_query)
10173         (remote_target::remove_new_fork_children)
10174         (remote_target::check_pending_events_prevent_wildcard_vcont)
10175         (remote_target::remote_parse_stop_reply)
10176         (remote_target::process_stop_reply): Pass down target.
10177         (first_remote_resumed_thread): New remote_target parameter.  Pass
10178         it down.
10179         (remote_target::wait_as): Pass down target.
10180         (unpush_and_perror): New remote_target parameter.  Pass it down.
10181         (remote_target::readchar, remote_target::remote_serial_write)
10182         (remote_target::getpkt_or_notif_sane_1)
10183         (remote_target::kill_new_fork_children, remote_target::kill): Pass
10184         down target.
10185         (remote_target::mourn_inferior): Pass down target.  Use
10186         remote_unpush_target.
10187         (remote_target::core_of_thread)
10188         (remote_target::remote_btrace_maybe_reopen): Pass down target.
10189         (remote_target::pid_to_exec_file)
10190         (remote_target::thread_handle_to_thread_info): Pass down target.
10191         (remote_target::async_wait_fd): New.
10192         * riscv-fbsd-tdep.c: Include "inferior.h".
10193         (riscv_fbsd_get_thread_local_address): Pass down target.
10194         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
10195         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
10196         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
10197         Adjust.
10198         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
10199         * solib-svr4.c (enable_break): Pass down target.
10200         * spu-multiarch.c (parse_spufs_run): Pass down target.
10201         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
10202         * target-delegates.c: Regenerate.
10203         * target.c (g_target_stack): Delete.
10204         (current_top_target): Return the current inferior's top target.
10205         (target_has_execution_1): Refer to the passed-in inferior's top
10206         target.
10207         (target_supports_terminal_ours): Check whether the initial
10208         inferior was already created.
10209         (decref_target): New.
10210         (target_stack::push): Incref/decref the target.
10211         (push_target, push_target, unpush_target): Adjust.
10212         (target_stack::unpush): Defref target.
10213         (target_is_pushed): Return bool.  Adjust to refer to the current
10214         inferior's target stack.
10215         (dispose_inferior): Delete, and inline parts ...
10216         (target_preopen): ... here.  Only dispose of the current inferior.
10217         (target_detach): Hold strong target reference while detaching.
10218         Pass target down.
10219         (target_thread_name): Add assertion.
10220         (target_resume): Pass down target.
10221         (target_ops::beneath, find_target_at): Adjust to refer to the
10222         current inferior's target stack.
10223         (get_dummy_target): New.
10224         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
10225         has a thread running.
10226         (initialize_targets): Rename to ...
10227         (_initialize_target): ... this.
10228         * target.h: Include "gdbsupport/refcounted-object.h".
10229         (struct target_ops): Inherit refcounted_object.
10230         (target_ops::shortname, target_ops::longname): Make const.
10231         (target_ops::async_wait_fd): New method.
10232         (decref_target): Declare.
10233         (struct target_ops_ref_policy): New.
10234         (target_ops_ref): New typedef.
10235         (get_dummy_target): Declare function.
10236         (target_is_pushed): Return bool.
10237         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
10238         (all_matching_threads_iterator::all_matching_threads_iterator):
10239         Handle filter target.
10240         * thread-iter.h (struct all_matching_threads_iterator, struct
10241         all_matching_threads_range, class all_non_exited_threads_range):
10242         Filter by target too.  Remove explicit.
10243         * thread.c (threads_executing): Delete.
10244         (inferior_thread): Pass down current inferior.
10245         (clear_thread_inferior_resources): Pass down thread pointer
10246         instead of ptid_t.
10247         (add_thread_silent, add_thread_with_info, add_thread): Add
10248         process_stratum_target parameter.  Use it for thread and inferior
10249         searches.
10250         (is_current_thread): New.
10251         (thread_info::deletable): Use it.
10252         (find_thread_ptid, thread_count, in_thread_list)
10253         (thread_change_ptid, set_resumed, set_running): New
10254         process_stratum_target parameter.  Pass it down.
10255         (set_executing): New process_stratum_target parameter.  Pass it
10256         down.  Adjust reference to 'threads_executing'.
10257         (threads_are_executing): New process_stratum_target parameter.
10258         Adjust reference to 'threads_executing'.
10259         (set_stop_requested, finish_thread_state): New
10260         process_stratum_target parameter.  Pass it down.
10261         (switch_to_thread): Also match inferior.
10262         (switch_to_thread): New process_stratum_target parameter.  Pass it
10263         down.
10264         (update_threads_executing): Reimplement.
10265         * top.c (quit_force): Pop targets from all inferior.
10266         (gdb_init): Don't call initialize_targets.
10267         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
10268         Declare.
10269         (windows_add_thread, windows_delete_thread): Adjust.
10270         (get_windows_debug_event): Rename to ...
10271         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
10272         * tracefile-tfile.c (tfile_target_open): Pass down target.
10273         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
10274         Forward declare.
10275         (switch_to_thread): Add process_stratum_target parameter.
10276         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
10277         parameter.  Use it.
10278         (mi_on_resume): Pass target down.
10279         * nat/fork-inferior.c (startup_inferior): Add
10280         process_stratum_target parameter.  Pass it down.
10281         * nat/fork-inferior.h (startup_inferior): Add
10282         process_stratum_target parameter.
10283         * python/py-threadevent.c (py_get_event_thread): Pass target down.
10284
10285 2020-01-10  Pedro Alves  <palves@redhat.com>
10286
10287         * remote.c (remote_target::start_remote): Don't set inferior_ptid
10288         directly.  Instead find the first thread in the thread list and
10289         use switch_to_thread.
10290
10291 2020-01-10  Pedro Alves  <palves@redhat.com>
10292
10293         * remote.c (remote_target::remote_add_inferior): Don't bind a
10294         process to the current inferior if the current inferior is already
10295         bound to a process.
10296
10297 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
10298             Pedro Alves  <palves@redhat.com>
10299
10300         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
10301         If no process is specified, return null_ptid instead of
10302         inferior_ptid.
10303         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
10304         TARGET_WAITKIND_SIGNALLED with no pid.
10305
10306 2020-01-10  Pedro Alves  <palves@redhat.com>
10307
10308         * remote.c (first_remote_resumed_thread): New.
10309         (remote_target::wait_as): Use it as default event_ptid instead of
10310         inferior_ptid.
10311
10312 2020-01-10  Pedro Alves  <palves@redhat.com>
10313
10314         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
10315
10316 2020-01-10  Pedro Alves  <palves@redhat.com>
10317
10318         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
10319         not -1.
10320
10321 2020-01-10  Pedro Alves  <palves@redhat.com>
10322
10323         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
10324         ptid to get_last_target_status.
10325         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
10326         ptid to get_last_target_status.
10327         * infcmd.c (continue_command): Don't pass a target_waitstatus to
10328         get_last_target_status.
10329         (info_program_command): Don't pass a target_waitstatus to
10330         get_last_target_status.
10331         * infrun.c (init_wait_for_inferior): Use
10332         nullify_last_target_wait_ptid.
10333         (get_last_target_status): Handle nullptr arguments.
10334         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
10335         (print_stop_event): Don't pass a ptid to get_last_target_status.
10336         (normal_stop): Don't pass a ptid to get_last_target_status.
10337         * infrun.h (get_last_target_status, set_last_target_status): Move
10338         comments here and update.
10339         (nullify_last_target_wait_ptid): Declare.
10340         * linux-fork.c (fork_load_infrun_state): Remove local extern
10341         declaration of nullify_last_target_wait_ptid.
10342         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
10343         to get_last_target_status.
10344
10345 2020-01-10  Pedro Alves  <palves@redhat.com>
10346
10347         * gdbthread.h (scoped_restore_current_thread)
10348         <dont_restore, restore, m_dont_restore>: Declare.
10349         * thread.c (thread_alive): Add assertion.  Return bool.
10350         (switch_to_thread_if_alive): New.
10351         (prune_threads): Switch inferior/thread.
10352         (print_thread_info_1): Switch thread before calling target methods.
10353         (scoped_restore_current_thread::restore): New, factored out from
10354         ...
10355         (scoped_restore_current_thread::~scoped_restore_current_thread):
10356         ... this.
10357         (scoped_restore_current_thread::scoped_restore_current_thread):
10358         Add assertion.
10359         (thread_apply_all_command, thread_select): Use
10360         switch_to_thread_if_alive.
10361         * infrun.c (proceed, restart_threads, handle_signal_stop)
10362         (switch_back_to_stepped_thread): Switch current thread before
10363         calling target methods.
10364
10365 2020-01-10  Pedro Alves <palves@redhat.com>
10366
10367         * inferior.c (switch_to_inferior_no_thread): New function,
10368         factored out from ...
10369         (inferior_command): ... here.
10370         * inferior.h (switch_to_inferior_no_thread): Declare.
10371         * mi/mi-main.c (run_one_inferior): Use
10372         switch_to_inferior_no_thread.
10373
10374 2020-01-10  Pedro Alves  <palves@redhat.com>
10375
10376         * infcmd.c (kill_command): Remove dead code.
10377
10378 2020-01-10  Pedro Alves  <palves@redhat.com>
10379
10380         * remote.c (remote_target::mourn_inferior): No longer check
10381         whether the target is running.
10382
10383 2020-01-10  Pedro Alves  <palves@redhat.com>
10384
10385         * corelow.c (core_target::has_execution): Change parameter type to
10386         inferior pointer.
10387         * inferior.c (number_of_live_inferiors): Use
10388         inferior::has_execution instead of target_has_execution_1.
10389         * inferior.h (inferior::has_execution): New.
10390         * linux-thread-db.c (thread_db_target::update_thread_list): Use
10391         inferior::has_execution instead of target_has_execution_1.
10392         * process-stratum-target.c
10393         (process_stratum_target::has_execution): Change parameter type to
10394         inferior pointer.  Check the inferior's PID instead of
10395         inferior_ptid.
10396         * process-stratum-target.h
10397         (process_stratum_target::has_execution): Change parameter type to
10398         inferior pointer.
10399         * record-full.c (record_full_core_target::has_execution): Change
10400         parameter type to inferior pointer.
10401         * target.c (target_has_execution_1): Change parameter type to
10402         inferior pointer.
10403         (target_has_execution_current): Adjust.
10404         * target.h (target_ops::has_execution): Change parameter type to
10405         inferior pointer.
10406         (target_has_execution_1): Change parameter type to inferior
10407         pointer.  Change return type to bool.
10408         * tracefile.h (tracefile_target::has_execution): Change parameter
10409         type to inferior pointer.
10410
10411 2020-01-10  Pedro Alves  <palves@redhat.com>
10412
10413         * exceptions.c (print_flush): Remove current_top_target() check.
10414
10415 2020-01-10  Pedro Alves  <palves@redhat.com>
10416
10417         * remote.c (show_remote_exec_file): Show the current inferior's
10418         exec-file instead of the command variable's value.
10419
10420 2020-01-10  Pedro Alves  <palves@redhat.com>
10421
10422         * record-full.c (record_full_resume_ptid): New global.
10423         (record_full_target::resume): Set it.
10424         (record_full_wait_1): Use record_full_resume_ptid instead of
10425         inferior_ptid.
10426
10427 2020-01-10  Pedro Alves  <palves@redhat.com>
10428
10429         * gdbthread.h (scoped_restore_current_thread)
10430         <dont_restore, restore, m_dont_restore>: Declare.
10431         * thread.c (thread_alive): Add assertion.  Return bool.
10432         (switch_to_thread_if_alive): New.
10433         (prune_threads): Switch inferior/thread.
10434         (print_thread_info_1): Switch thread before calling target methods.
10435         (scoped_restore_current_thread::restore): New, factored out from
10436         ...
10437         (scoped_restore_current_thread::~scoped_restore_current_thread):
10438         ... this.
10439         (scoped_restore_current_thread::scoped_restore_current_thread):
10440         Add assertion.
10441         (thread_apply_all_command, thread_select): Use
10442         switch_to_thread_if_alive.
10443
10444 2020-01-10  George Barrett  <bob@bob131.so>
10445
10446         * stap-probe.c (stap_modify_semaphore): Don't check for null
10447         semaphores.
10448         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
10449         for null semaphores.
10450
10451 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10452
10453         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
10454         all source windows, and maintain horizontal scroll status while
10455         doing so.
10456
10457 2020-01-09  Tom Tromey  <tom@tromey.com>
10458
10459         PR tui/18932:
10460         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
10461         update_source_window, not print_source_lines.
10462
10463 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10464
10465         * tui/tui.c (tui_enable): Register tui hooks after calling
10466         tui_display_main.
10467
10468 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10469
10470         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
10471
10472 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
10473
10474         * thread.c (print_thread_info_1): Fix indentation.
10475
10476 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10477
10478         * symtab.c (general_symbol_info::compute_and_set_names): Move the
10479         unique_xmalloc_ptr outside the if to always free the demangled name.
10480
10481 2020-01-08  Tom Tromey  <tromey@adacore.com>
10482
10483         * xcoffread.c (enter_line_range, read_xcoff_symtab)
10484         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
10485         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
10486         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
10487         Remove.
10488         (section_offsets): New typedef.
10489         * symtab.c (fixup_section, get_msymbol_address): Update.
10490         * symmisc.c (dump_msymbols): Update.
10491         * symfile.h (relative_addr_info_to_section_offsets)
10492         (symfile_map_offsets_to_segments): Update.
10493         * symfile.c (build_section_addr_info_from_objfile)
10494         (init_objfile_sect_indices): Update.
10495         (struct place_section_arg): Change type of "offsets".
10496         (place_section): Update.
10497         (relative_addr_info_to_section_offsets): Change type of
10498         "section_offsets".  Remove "num_sections" parameter.
10499         (default_symfile_offsets, syms_from_objfile_1)
10500         (set_objfile_default_section_offset): Update.
10501         (reread_symbols): No need to preserve section offsets by hand.
10502         (symfile_map_offsets_to_segments): Change type of "offsets".
10503         * stap-probe.c (relocate_address): Update.
10504         * stabsread.h (process_one_symbol): Update.
10505         * solib-target.c (struct lm_info_target) <offsets>: Change type.
10506         (solib_target_relocate_section_addresses): Update.
10507         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
10508         Update.
10509         * solib-frv.c (frv_relocate_main_executable): Update.
10510         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
10511         * solib-aix.c (solib_aix_get_section_offsets): Change return
10512         type.
10513         (solib_aix_solib_create_inferior_hook): Update.
10514         * remote.c (remote_target::get_offsets): Update.
10515         * psymtab.c (find_pc_sect_psymtab): Update.
10516         * psympriv.h (struct partial_symbol) <address, text_low,
10517         text_high>: Update.
10518         * objfiles.h (obj_section_offset): Update.
10519         (struct objfile) <section_offsets>: Change type.
10520         <num_sections>: Remove.
10521         (objfile_relocate): Update.
10522         * objfiles.c (entry_point_address_query): Update
10523         (relocate_one_symbol): Change type of "section_offsets".
10524         (objfile_relocate1, objfile_relocate1): Change type of
10525         "new_offsets".
10526         (objfile_rebase1): Update.
10527         * mipsread.c (mipscoff_symfile_read): Update.
10528         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
10529         parameter.
10530         * mdebugread.c (parse_symbol): Change type of "section_offsets".
10531         (parse_external, psymtab_to_symtab_1): Update.
10532         * machoread.c (macho_symfile_offsets): Update.
10533         * ia64-tdep.c (ia64_find_unwind_table): Update.
10534         * hppa-tdep.c (read_unwind_info): Update.
10535         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
10536         * dwarf2read.c (create_addrmap_from_index)
10537         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10538         (process_psymtab_comp_unit_reader, add_partial_symbol)
10539         (add_partial_subprogram, process_full_comp_unit)
10540         (read_file_scope, read_func_scope, read_lexical_block_scope)
10541         (read_call_site_scope, dwarf2_rnglists_process)
10542         (dwarf2_ranges_process, dwarf2_ranges_read)
10543         (dwarf_decode_lines_1, var_decode_location, new_symbol)
10544         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
10545         Update.
10546         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
10547         Update.
10548         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
10549         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
10550         (process_one_symbol): Change type of "section_offsets".
10551         * ctfread.c (get_objfile_text_range): Update.
10552         * coffread.c (coff_symtab_read, enter_linenos)
10553         (process_coff_symbol): Update.
10554         * coff-pe-read.c (add_pe_forwarded_sym): Update.
10555         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
10556
10557 2020-01-08  Tom Tromey  <tromey@adacore.com>
10558
10559         * dwarf2read.c (parse_macro_definition): Use std::string.
10560         (parse_macro_definition): Likewise.
10561
10562 2020-01-08  Tom Tromey  <tromey@adacore.com>
10563
10564         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
10565         (ATTR_ALLOC_CHUNK): Remove.
10566
10567 2020-01-08  Tom Tromey  <tromey@adacore.com>
10568
10569         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
10570
10571 2020-01-08  Tom Tromey  <tromey@adacore.com>
10572
10573         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
10574         (dwarf2_compute_name, open_dwo_file): Likewise.
10575         (process_enumeration_scope): Use std::vector.
10576         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
10577         (partial_die_info::fixup, dwarf2_start_subfile)
10578         (guess_full_die_structure_name, dwarf2_name): Likewise.
10579         (determine_prefix): Update.
10580         (guess_full_die_structure_name): Make return type const.
10581         (partial_die_full_name): Return unique_xmalloc_ptr.
10582         (DW_FIELD_ALLOC_CHUNK): Remove.
10583
10584 2020-01-07  Tom Tromey  <tromey@adacore.com>
10585
10586         PR build/24937:
10587         * stap-probe.c (class stap_static_probe_ops): Add constructor.
10588
10589 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10590
10591         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
10592
10593 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10594
10595         * stack.c (print_frame_info): Move disassemble_next_line code
10596         inside source_print block.
10597
10598 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10599
10600         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
10601         gdb/signals.h, as we are now using native signal symbols.
10602
10603 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10604
10605         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
10606         overflow by an early check of content vs threshold.
10607         * tui/tui-source.c (tui_source_window::line_is_displayed):
10608         Likewise.
10609
10610 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10611
10612         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
10613
10614 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10615
10616         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
10617         export table if no section contains it's RVA.
10618
10619 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10620
10621         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
10622
10623 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
10624
10625         * source.c (print_source_lines_base): Set last_line_listed.
10626
10627 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10628
10629         * tui/tui-disasm.c: Remove trailing spaces.
10630
10631 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10632             Pedro Alves  <palves@redhat.com>
10633
10634         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
10635         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
10636         (windows_gdb_signal_to_target): New function, uses the above
10637         enumeration to convert GDB internal signal codes to equivalent
10638         Windows codes.
10639         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
10640         * windows-nat.c: Include "gdb_wait.h".
10641         (get_windows_debug_event): Extract the fatal exception from the
10642         exit status and convert to the equivalent Posix signal number.
10643         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
10644         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
10645         * gdbsupport/gdb_wait.c: New file, implements
10646         windows_status_to_termsig.
10647         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
10648         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
10649
10650 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10651
10652         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
10653         show_layout.
10654
10655 2020-01-05  Luis Machado  <luis.machado@linaro.org>
10656
10657         * aarch64-linux-nat.c
10658         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
10659         and bfd_mach_aarch64.
10660
10661 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10662
10663         * ui-file.c (stdio_file::can_emit_style_escape)
10664         (tee_file::can_emit_style_escape): Ensure style is used also on
10665         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
10666         to gdb_stdout.
10667         * main.c (set_gdb_data_directory): Use file style to output the
10668         warning that the given pathname is not a directory.
10669         * top.c (show_history_filename, gdb_safe_append_history)
10670         (show_gdb_datadir): Use file style.
10671
10672 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10673
10674         * solib-target.c (struct lm_info_target):
10675         Change offsets to be a unique_xmalloc_ptr.
10676         (solib_target_relocate_section_addresses): Update.
10677
10678 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10679
10680         * windows-nat.c (windows_clear_solib): Free so_list linked list.
10681
10682 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10683
10684         * MAINTAINERS (Write After Approval): Add myself.
10685
10686 2020-01-02  Luis Machado  <luis.machado@linaro.org>
10687
10688         * proc-service.c (get_ps_regcache): Remove reference to obsolete
10689         Cell BE architecture.
10690         * target.h (struct target_ops) <thread_architecture>: Likewise.
10691
10692 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10693
10694         * Makefile.in: Use INSTALL_PROGRAM_ENV.
10695
10696 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10697
10698         * MAINTAINERS (Write After Approval): Add myself.
10699
10700 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10701
10702         * gdbarch.sh: Update copyright year range of generated files.
10703
10704 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10705
10706         Update copyright year range in all GDB files.
10707
10708 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10709
10710         * copyright.py: Convert to Python 3.
10711
10712 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10713
10714         * copyright.py: Adapt after move of gnulib directory from gdb
10715         directory to toplevel directory.
10716
10717 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10718
10719         * copyright.py (main): Exit if run from the wrong directory.
10720
10721 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10722
10723         * top.c (print_gdb_version): Change copyright year to 2020.
10724
10725 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10726
10727         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
10728
10729 For older changes see ChangeLog-2019.
10730 \f
10731 Local Variables:
10732 mode: change-log
10733 left-margin: 8
10734 fill-column: 74
10735 version-control: never
10736 coding: utf-8
10737 End: