gdb/ChangeLog

   1 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
   4         variable symbol_linkage to symbol_linkage_.
   5
   6 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
   7
   8         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
   9         represent whether the symbol is static, dynamic, or we don't
  10         know.
  11
  12 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
  13
  14         * gdb/rx-tdep.c (rx_register_names): New.
  15         (rx_register_name): Delete.
  16         (rx_psw_type): Delete.
  17         (rx_fpsw_type): Delete.
  18         (rx_register_type): Delete.
  19         (rx_gdbarch_init): Convert target-descriptions.
  20         (_initialize_rx_tdep): Add initialize_tdesc_rx.
  21         * gdb/features/Makefile: Add rx.xml.
  22         * gdb/features/rx.xml: New.
  23         * gdb/features/rx.c: Generated.
  24         * gdb/NEWS: Mention target description support.
  25
  26 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  27
  28         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
  29         *slot_ptr.
  30
  31 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  32
  33         * configure.ac: Don't check for 'dlfcn.h' (moved to
  34         gdbsupport/common.m4).
  35         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
  36         'gdbsupport/'.
  37         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
  38         * compile/compile-c-support.c: Include
  39         'gdbsupport/gdb-dlfcn.h'.
  40         * gdbsupport/common.m4: Check for 'dlfcn.h'.
  41         * gdb-dlfcn.c: Move to...
  42         * gdbsupport/gdb-dlfcn.c: ... here.
  43         * gdb-dlfcn.h: Move to...
  44         * gdbsupport/gdb-dlfcn.h: ... here.
  45
  46 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
  47
  48         * nios2-tdep.c (struct reg_value): Improve comments.  Make
  49         the offset field signed.
  50
  51 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  52
  53         * python/lib/gdb/__init__.py (_execute_file): New function.
  54         * python/python.c (python_run_simple_file): Call gdb._execute_file
  55         on Windows.
  56
  57 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  58
  59         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
  60         all uses as this was never set to anything but a zero value.
  61
  62 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
  63
  64         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
  65
  66 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
  67
  68         * tui/tui-data.h (tui_gen_win_info): Add an =default
  69         move constructor, required by some GCC versions.
  70
  71 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
  72
  73         * go32-nat.c (go32_sysinfo): Add hygon_p.
  74
  75 2019-08-20  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
  78         line_from_reg_element_no, first_reg_element_no_inline,
  79         display_all_data, delete_data_content_windows,
  80         erase_data_content>: Now private.
  81
  82 2019-08-20  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
  85         (tui_unhighlight_win, tui_highlight_win)
  86         (tui_win_info::make_window): Update.
  87         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
  88
  89 2019-08-20  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  92         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  93         (MAX_PID_WIDTH): Move to tui-stack.c.
  94         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  95         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  96         (MAX_PID_WIDTH): Move from tui-data.h.
  97
  98 2019-08-20  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 101         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 102         (box_win): Update.
 103         (tui_gen_win_info::make_window): Rename from tui_make_window.
 104         (tui_win_info::make_window): New method.
 105         (tui_gen_win_info::make_visible): Update.
 106         * tui/tui-source.c (tui_source_window::set_contents): Update.
 107         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 108         (tui_data_window::display_registers_from): Update.
 109         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 110         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 111         Declare.
 112         <can_box>: Remove.
 113         <title>: Remove.
 114         (struct tui_win_info) <make_window>: Declare.
 115         <can_box>: Now virtual.
 116         <title>: New member.
 117         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 118         * tui/tui-command.c (tui_cmd_window::resize): Update.
 119
 120 2019-08-20  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 123         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 124         (tui_data_window::check_register_values): Update.
 125
 126 2019-08-20  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-regs.h (struct tui_data_window): Use
 129         DISABLE_COPY_AND_ASSIGN.
 130         <regs_content>: Change type, removing unique_ptr.
 131         <tui_data_window>: Add move constructor.
 132         * tui/tui-regs.c (tui_data_window::show_registers)
 133         (tui_data_window::show_register_group)
 134         (tui_data_window::display_registers_from)
 135         (tui_data_window::display_registers_from)
 136         (tui_data_window::first_data_item_displayed)
 137         (tui_data_window::delete_data_content_windows)
 138         (tui_data_window::rerender, tui_data_window::refresh_window)
 139         (tui_data_window::check_register_values): Update.
 140
 141 2019-08-20  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 144         show_register_group>: Declare.
 145         (tui_show_register_group): Don't declare.
 146         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 147         tui_show_registers.
 148         (tui_data_window::show_register_group): Rename from
 149         tui_show_register_group.
 150         (tui_data_window::check_register_values, tui_reg_command):
 151         Update.
 152         * tui/tui-layout.c (tui_set_layout): Update.
 153
 154 2019-08-20  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 157         Declare.
 158         (tui_check_register_values): Don't declare.
 159         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 160         from tui_check_register_values.
 161         * tui/tui-hooks.c (tui_register_changed): Update.
 162
 163 2019-08-20  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-regs.c (tui_reg_layout): Move later.
 166         (tui_show_registers): Don't enable TUI mode or change layout.
 167
 168 2019-08-20  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-regs.h (struct tui_data_item_window)
 171         <~tui_data_item_window>: Remove.
 172         <content>: Now a unique_xmalloc_ptr.
 173         * tui/tui-regs.c (tui_register_format): Return a
 174         unique_xmalloc_ptr.
 175         (tui_get_register): Update.
 176         (~tui_data_item_window): Remove.
 177         (tui_data_window::display_registers_from, tui_display_register):
 178         Update.
 179         * tui/tui-io.h (tui_expand_tabs): Update.
 180         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 181         Remove "col" parameter.
 182
 183 2019-08-20  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 186         field.
 187         * tui/tui-regs.c (~tui_data_item_window): Update.
 188
 189 2019-08-20  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 192         earlier.
 193
 194 2019-08-20  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 197
 198 2019-08-20  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-source.h (struct tui_source_window): Update.
 201         * tui/tui-regs.c (tui_show_registers): Update.
 202         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 203         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 204         (NO_REGS_STRING): Remove defines.
 205
 206 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 207
 208         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 209         unnecessary thread walk if remote doesn't support the packet.
 210
 211 2019-08-19  Tom Tromey  <tromey@adacore.com>
 212
 213         * python/py-value.c (value_has_field): Fix indentation.
 214
 215 2019-08-19  Tom Tromey  <tromey@adacore.com>
 216
 217         * printcmd.c (do_one_display, info_display_command): Update.
 218         * block.h (contained_in): Return bool.  Add allow_nested
 219         parameter.
 220         * block.c (contained_in): Return bool.  Add allow_nested
 221         parameter.
 222
 223 2019-08-19  Tom Tromey  <tom@tromey.com>
 224
 225         * configure: Rebuild.
 226         * configure.ac: Disallow the combination of -static-libstdc++ and
 227         source highlight.
 228         * source-cache.c (get_language_name): Handle rust.
 229         (source_cache::get_source_lines): Ignore highlighting exceptions.
 230
 231 2019-08-16  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 234         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 235         (struct tui_source_window_base) <make_visible, refresh_window,
 236         resize>: Remove methods.
 237         <execution_info>: Remove field.
 238         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 239         (tui_show_source_line, tui_source_window_base)
 240         (~tui_source_window_base): Update.
 241         (tui_source_window_base::resize)
 242         (tui_source_window_base::make_visible)
 243         (tui_source_window_base::refresh_window): Remove.
 244         (tui_source_window_base::update_exec_info): Update.
 245         * tui/tui-source.c (tui_source_window::set_contents): Update.
 246         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 247
 248 2019-08-16  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 251         deprecated_query_hook.
 252
 253 2019-08-16  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 256         (tui_update_source_windows_with_line): Update.
 257         * tui/tui-source.h (struct tui_source_window)
 258         <show_symtab_source>: Declare.
 259         (tui_show_symtab_source): Don't declare.
 260         * tui/tui-source.c (tui_show_symtab_source): Rename from
 261         tui_show_symtab_source.
 262
 263 2019-08-16  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-winsource.h (struct tui_source_window_base)
 266         <set_contents>: Declare.
 267         * tui/tui-winsource.c
 268         (tui_source_window_base::update_source_window_as_is): Update.
 269         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 270         Declare.
 271         (tui_set_source_content): Don't declare.
 272         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 273         tui_set_source_content.
 274         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 275         Declare.
 276         (tui_set_disassem_content): Don't declare.
 277         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 278         tui_set_disassem_content.
 279
 280 2019-08-16  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-winsource.h (struct tui_source_window_base)
 283         <update_breakpoint_info>: Declare.
 284         (tui_update_breakpoint_info): Don't declare.
 285         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 286         (tui_update_all_breakpoint_info): Update.
 287         (tui_source_window_base::update_breakpoint_info): Rename from
 288         tui_update_breakpoint_info.
 289         (tui_source_window_base::update_exec_info): Update.
 290
 291 2019-08-16  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-winsource.h (struct tui_source_window_base)
 294         <update_source_window>: Declare.
 295         (tui_update_source_window): Don't declare.
 296         * tui/tui-winsource.c
 297         (tui_source_window_base::update_source_window): Rename from
 298         tui_update_source_window.
 299         (tui_source_window_base::rerender): Update.
 300         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 301         * tui/tui-disasm.c (tui_show_disassem)
 302         (tui_show_disassem_and_update_source)
 303         (tui_disasm_window::maybe_update): Update.
 304
 305 2019-08-16  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-winsource.h (struct tui_source_window_base)
 308         <update_source_window_as_is>: Declare.
 309         (tui_update_source_window_as_is): Don't declare.
 310         * tui/tui-winsource.c (tui_update_source_window): Update
 311         (tui_source_window_base::update_source_window_as_is): Rename from
 312         tui_update_source_window_as_is.
 313         (tui_source_window_base::refill): Update.
 314         * tui/tui-source.c (tui_show_symtab_source): Update.
 315         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 316         Update.
 317
 318 2019-08-16  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-winsource.h (tui_update_source_window)
 321         (tui_update_source_window_as_is): Remove "noerror" parameter.
 322         * tui/tui-winsource.c (tui_update_source_window)
 323         (tui_update_source_window_as_is): Remove "noerror" parameter.
 324         (tui_update_source_windows_with_addr)
 325         (tui_update_source_windows_with_line)
 326         (tui_source_window_base::rerender)
 327         (tui_source_window_base::refill): Update.
 328         * tui/tui-source.h (tui_set_source_content)
 329         (tui_show_symtab_source): Remove "noerror" parameter.
 330         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 331         parameter.
 332         (tui_show_symtab_source): Likewise.
 333         (tui_source_window::maybe_update): Update.
 334         * tui/tui-disasm.c (tui_show_disassem)
 335         (tui_show_disassem_and_update_source)
 336         (tui_disasm_window::do_scroll_vertical)
 337         (tui_disasm_window::maybe_update): Update.
 338
 339 2019-08-16  Tom Tromey  <tom@tromey.com>
 340
 341         * tui/tui.c (tui_is_window_visible): Update.
 342         * tui/tui-wingeneral.c (tui_make_window)
 343         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 344         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 345         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 346         (tui_set_win_height_command, parse_scrolling_args): Update.
 347         * tui/tui-source.c (tui_source_window::style_changed): Update.
 348         * tui/tui-regs.c (tui_show_registers)
 349         (tui_data_window::first_data_item_displayed)
 350         (tui_data_window::delete_data_content_windows)
 351         (tui_check_register_values, tui_reg_command): Update.
 352         * tui/tui-disasm.c (tui_show_disassem): Update.
 353         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 354         method.
 355         <is_visible>: Remove field.
 356         * tui/tui-data.c (tui_next_win, tui_prev_win)
 357         (tui_delete_invisible_windows): Update.
 358
 359 2019-08-16  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-winsource.h (struct tui_source_window_base)
 362         <m_has_locator>: Remove.
 363         * tui/tui-layout.c (show_source_disasm_command, show_data)
 364         (show_source_or_disasm_and_command): Update.
 365
 366 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 367
 368         * NEWS (Other MI changes): New subsection.
 369         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 370         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 371         * arch-utils.c (default_get_pc_address_flags): New function.
 372         * arch-utils.h (default_get_pc_address_flags): New declaration.
 373         * gdbarch.sh: Add get_pc_address_flags.
 374         * gdbarch.c: Regenerate.
 375         * gdbarch.h: Likewise.
 376         * stack.c (print_pc): New function.
 377         (print_frame_info) (print_frame): Call print_pc.
 378
 379 2019-08-16  Tom de Vries  <tdevries@suse.de>
 380
 381         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 382         print_objfile_section_info.
 383
 384 2019-08-15  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 387         calling update_cmdwin_start_line.
 388         * tui/tui-winsource.h (struct tui_source_window_base)
 389         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 390         <rerender>: Declare.
 391         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 392         Call rerender.
 393         (tui_source_window_base::set_new_height): Remove.
 394         (tui_source_window_base::rerender): Rename from
 395         do_make_visible_with_new_height.
 396         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 397         resize method.
 398         (tui_win_info::make_invisible_and_set_new_height)
 399         (tui_win_info::make_visible_with_new_height): Remove.
 400         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 401         Declare.
 402         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 403         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 404         do_make_visible_with_new_height>: Don't declare.
 405         <rerender>: Declare.
 406         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 407         set_new_height.
 408         (tui_data_window::do_make_visible_with_new_height): Remove.
 409         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 410         call tui_show_locator_content.
 411         (tui_gen_win_info::resize): Call rerender.
 412         (show_source_or_disasm_and_command): Don't call
 413         tui_show_locator_content.
 414         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 415         method.
 416         (struct tui_win_info) <rerender>: Declare.
 417         <set_new_height, make_invisible_and_set_new_height,
 418         make_visible_with_new_height>: Don't declare.
 419         * tui/tui-data.c (tui_win_list::rerender): New method.
 420         * tui/tui-command.h (struct tui_cmd_window)
 421         <do_make_visible_with_new_height>: Don't declare.
 422         * tui/tui-command.c
 423         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 424
 425 2019-08-15  Tom Tromey  <tromey@adacore.com>
 426
 427         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 428         * ada-lang.c (ada_enum_name): Likewise.
 429
 430 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 431
 432         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 433         leading underscore.
 434         (GdbOutputErrorFile): Likewise.
 435         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 436         accordingly.
 437         (execute_unwinders): Rename to have a leading underscore.
 438         (auto_load_packages): Likewise.
 439         (global scope): Adjust call to auto_load_packages accordingly.
 440         (GdbSetPythonDirectory): Likewise.
 441         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 442         instead of execute_unwinders.
 443
 444 2019-08-15  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 447         (show_data): Don't change window visibility.
 448         (tui_gen_win_info::resize): Remove special case for command
 449         window.  Use wresize, when available.
 450         (show_source_or_disasm_and_command): Don't change window
 451         visibility.
 452         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 453         <make_visible>: New method.
 454         * tui/tui-command.c (tui_cmd_window::resize): New method.
 455
 456 2019-08-15  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 459         (struct tui_source_windows): New.
 460         * tui/tui-winsource.c (tui_display_main): Update.
 461         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 462         (new_height_ok, parse_scrolling_args): Update.
 463         * tui/tui-layout.c (show_layout, show_data): Update.
 464         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 465         (tui_add_to_source_windows): Don't declare.
 466         * tui/tui-data.c (source_windows, tui_source_windows)
 467         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 468
 469 2019-08-15  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 472         Rename from reset.
 473         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 474         * tui/tui-layout.c (show_source_disasm_command, show_data):
 475         Update.
 476         (tui_gen_win_info::resize): Rename.
 477         (show_source_or_disasm_and_command): Update.
 478         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 479         reset.
 480
 481 2019-08-15  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 484         * tui/tui-interp.c (tui_interp::init): Don't call
 485         tui_initialize_static_data.
 486         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 487
 488 2019-08-15  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 491         examine tui_win_list.
 492
 493 2019-08-15  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 496         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 497         tui_clear_source_content.
 498         (tui_clear_source_content): Remove.
 499         (tui_source_window_base::do_erase_source_content): Hoist call to
 500         content.clear().
 501         * tui/tui-stack.c (tui_show_frame_info): Don't call
 502         tui_clear_source_content.
 503
 504 2019-08-15  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-winsource.h (struct tui_source_window_base)
 507         <do_erase_source_content>: New method.
 508         <erase_source_content>: New method.
 509         (tui_erase_source_content): Don't declare.
 510         * tui/tui-winsource.c (tui_clear_source_content): Update.
 511         (tui_source_window_base::do_erase_source_content): Rename from
 512         tui_erase_source_content.
 513         (tui_source_window_base::show_source_content): Update.
 514         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 515         * tui/tui-source.h (struct tui_source_window)
 516         <erase_source_content>: New method.
 517         * tui/tui-disasm.h (struct tui_disasm_window)
 518         <erase_source_content>: New method.
 519
 520 2019-08-15  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 523         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 524         constructor.
 525         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 526         * tui/tui-source.c (tui_set_source_content): Update.
 527         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 528
 529 2019-08-15  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 532         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 533         tui-source.c.
 534         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 535         Declare.
 536         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 537         method.
 538         (tui_source_window::maybe_update): Update.
 539
 540 2019-08-15  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 543         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 544         tui-disasm.c.
 545         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 546         Declare.
 547         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 548         method.
 549         (tui_disasm_window::maybe_update): Update.
 550
 551 2019-08-15  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-winsource.h (struct tui_source_window_base)
 554         <maybe_update>: Declare.
 555         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 556         method.
 557         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 558         Declare.
 559         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 560         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 561         Declare.
 562         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 563
 564 2019-08-15  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 567
 568 2019-08-15  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-wingeneral.c: Include tui-stack.h.
 571         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 572         (struct tui_locator_window): Move from tui-data.h.
 573         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 574         (tui_initialize_static_data): Move from tui-data.c.
 575         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 576         (struct tui_locator_window): Move to tui-stack.c.
 577         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 578         (tui_initialize_static_data): Move to tui-stack.c.
 579
 580 2019-08-15  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-layout.c (show_source_disasm_command)
 583         (show_source_or_disasm_and_command): Use make_visible method, not
 584         tui_make_window.
 585         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 586         Remove.
 587
 588 2019-08-15  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-wingeneral.h (tui_make_window): Update.
 591         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 592         parameter.
 593         (tui_gen_win_info::make_visible): Update.
 594         * tui/tui-regs.c (tui_data_window::display_registers_from):
 595         Update.
 596         * tui/tui-layout.c (show_source_disasm_command)
 597         (show_source_or_disasm_and_command): Update.
 598         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 599         (enum tui_box): Remove.
 600         (struct tui_win_info) <can_box>: New method.
 601         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 602         method.
 603
 604 2019-08-15  Tom de Vries  <tdevries@suse.de>
 605
 606         * linux-nat-trad.c: Include gdbarch.h.
 607
 608 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 609
 610         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 611         register sizes.
 612
 613 2019-08-14  Tom Tromey  <tromey@adacore.com>
 614
 615         * darwin-nat.c: Include gdbarch.h.
 616         * darwin-nat-info.c: Include gdbarch.h.
 617
 618 2019-08-13  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 621         Remove.
 622         * tui/tui-data.c (tui_initialize_static_data): Update.
 623
 624 2019-08-13  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-winsource.h (struct tui_exec_info_window)
 627         <~tui_exec_info_window, maybe_allocate_content, get_content,
 628         m_content>: Remove.
 629         (struct tui_source_window_base) <set_exec_info_content,
 630         show_exec_info_content>: Don't declare.
 631         * tui/tui-winsource.c
 632         (tui_exec_info_window::maybe_allocate_content): Remove.
 633         (tui_source_window_base::update_exec_info): Rename from
 634         set_exec_info_content.
 635         (tui_source_window_base::show_exec_info_content)
 636         (tui_source_window_base::update_exec_info): Remove.
 637
 638 2019-08-13  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 641         declare.
 642         * tui/tui-winsource.c (tui_update_source_window_as_is)
 643         (tui_update_source_windows_with_addr, tui_erase_source_content):
 644         Update.
 645         (tui_clear_exec_info_content): Remove.
 646
 647 2019-08-13  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 650         declare.
 651         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 652         call tui_erase_exec_info_content.
 653         (tui_clear_exec_info_content): Rename from
 654         tui_erase_exec_info_content.
 655         (tui_clear_exec_info_content): Delete.
 656
 657 2019-08-13  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-winsource.h (struct tui_source_window_base)
 660         <show_exec_info_content>: Declare.
 661         (tui_show_exec_info_content): Don't declare.
 662         * tui/tui-winsource.c
 663         (tui_source_window_base::show_exec_info_content): Rename from
 664         tui_show_exec_info_content.
 665         (tui_source_window_base::update_exec_info): Update.
 666
 667 2019-08-13  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 670         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 671         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 672         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 673         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 674         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 675         ... here.
 676
 677 2019-08-13  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-winsource.h (struct tui_source_window_base)
 680         <update_exec_info>: Declare.
 681         (tui_update_exec_info): Don't declare.
 682         * tui/tui-winsource.c (tui_update_source_window_as_is)
 683         (tui_source_window_base::refresh_all)
 684         (tui_update_all_breakpoint_info): Update.
 685         (tui_source_window_base::update_exec_info): Rename from
 686         tui_update_exec_info.
 687         * tui/tui-stack.c (tui_show_frame_info): Update.
 688
 689 2019-08-13  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-winsource.h (struct tui_source_window_base)
 692         <set_exec_info_content>: Declare.
 693         (tui_set_exec_info_content): Don't declare.
 694         * tui/tui-winsource.c
 695         (tui_source_window_base::set_exec_info_content): Rename from
 696         tui_set_exec_info_content.
 697         (tui_update_exec_info): Update.
 698
 699 2019-08-13  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-winsource.h (struct tui_source_window_base)
 702         <show_source_content>: Declare.
 703         (tui_show_source_content): Don't declare.
 704         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 705         (tui_source_window_base::show_source_content): Rename from
 706         tui_show_source_content.
 707         (tui_source_window_base::refresh_all): Update.
 708         * tui/tui-layout.c (show_source_disasm_command)
 709         (show_source_or_disasm_and_command): Update.
 710
 711 2019-08-13  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-winsource.c (tui_erase_source_content)
 714         (tui_show_source_content, tui_source_window_base::refresh_all):
 715         Update.
 716         * tui/tui-wingeneral.h
 717         (tui_check_and_display_highlight_if_needed): Don't declare.
 718         * tui/tui-wingeneral.c
 719         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 720         check_and_display_highlight_if_needed.
 721         * tui/tui-win.c (tui_rehighlight_all)
 722         (tui_win_info::make_visible_with_new_height): Update.
 723         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 724         (tui_data_window::erase_data_content)
 725         (tui_data_window::display_all_data): Update.
 726         * tui/tui-data.h (struct tui_win_info)
 727         <check_and_display_highlight_if_needed>: Declare.
 728
 729 2019-08-13  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-win.c (tui_resize_all): Call
 732         tui_delete_invisible_windows.
 733         * tui/tui-layout.c (show_layout): Call
 734         tui_delete_invisible_windows.
 735         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 736         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 737
 738 2019-08-13  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 741         tui_add_win_to_layout.
 742
 743 2019-08-13  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 746         * tui/tui-layout.c (tui_default_win_height): Now static.
 747
 748 2019-08-13  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 751         single switch.
 752         (show_source_disasm_command, show_source_or_disasm_and_command):
 753         Don't check current layout.
 754
 755 2019-08-13  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-wingeneral.c (make_all_visible): Remove.
 758         (tui_make_all_invisible): Simplify.
 759         * tui/tui-layout.c (tui_make_all_invisible): Move from
 760         tui-wingeneral.c; simplify.
 761         (show_layout): Hoist call to tui_make_all_invisible.
 762         (show_data): Don't call tui_make_all_invisible.
 763
 764 2019-08-13  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 767         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 768
 769 2019-08-13  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 772         tui-data.c.
 773         (show_source_disasm_command, show_data)
 774         (show_source_or_disasm_and_command): Don't use
 775         tui_set_current_layout_to.
 776         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 777         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 778         tui-layout.c.
 779         (tui_set_current_layout_to): Remove.
 780
 781 2019-08-13  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-layout.c (tui_set_layout): Update.
 784         * tui/tui-data.h (struct tui_layout_def): Remove.
 785         (tui_layout_def): Don't declare.
 786         * tui/tui-data.c (layout_def): Remove.
 787         (tui_layout_def): Remove.
 788
 789 2019-08-13  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-winsource.h (struct tui_source_window_base)
 792         <clear_detail>: No longer "override".
 793         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 794         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 795         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 796         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 797         Remove.
 798         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 799
 800 2019-08-13  Tom Tromey  <tromey@adacore.com>
 801
 802         * tracepoint.c: Don't include readline.h or history.h.
 803
 804 2019-08-12  Tom Tromey  <tom@tromey.com>
 805
 806         * configure: Rebuild.
 807         * configure.ac: Check for readline 7.
 808         * NEWS: Mention readline 7 requirement.
 809         * README: Update.
 810
 811 2019-08-12  Tom Tromey  <tom@tromey.com>
 812
 813         * mingw-hdep.c (gdb_select): Remove readline hack.
 814
 815 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 816
 817         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 818         when the function fails.
 819
 820 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 821
 822         * s390-tdep.c (s390_type_align): New function.
 823         (s390_gdbarch_init): Set it as type_align gdbarch method.
 824
 825 2019-08-09  Tom de Vries  <tdevries@suse.de>
 826
 827         PR gdb/24591
 828         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 829         pc_low with relocation offset.
 830
 831 2019-08-07  Tom Tromey  <tromey@adacore.com>
 832
 833         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 834         (print_frame_args): Update.
 835         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 836         Update.
 837         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 838         * frame.h (struct frame_arg): Add initializers.
 839         <error>: Now a unique_xmalloc_ptr.
 840
 841 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 842
 843         * NEWS: Expand the Pointer Authentication entry.
 844         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 845         (aarch64_frame_unmask_lr): ... to this.
 846         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 847         Call aarch64_frame_unmask_lr.
 848         * frame.c (struct frame_info): Add "masked" variable.
 849         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 850         (fprint_frame): Check for masked pc.
 851         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 852         declarations.
 853         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 854         * stack.c (print_frame): Check for masked pc.
 855
 856 2019-08-06  Tom Tromey  <tom@tromey.com>
 857
 858         * stabsread.c (patch_block_stabs, read_one_struct_field)
 859         (read_enum_type): Use obstack_strndup.
 860         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 861         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 862         * dwarf2read.c (guess_full_die_structure_name)
 863         (anonymous_struct_prefix): Use obstack_strndup.
 864         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 865         * c-exp.y (yylex): Use obstack_strndup.
 866         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 867         (write_var_or_type): Use obstack_strndup.
 868
 869 2019-08-06  Tom Tromey  <tom@tromey.com>
 870
 871         * symfile.c (reread_symbols): Use obstack_strdup.
 872         * stabsread.c (read_type): Use obstack_strdup.
 873         * gdb_obstack.h (obstack_strdup): New overload.
 874         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 875         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 876         (dwarf2_canonicalize_name): Use obstack_strdup.
 877         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 878         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 879         Use obstack_strdup.
 880
 881 2019-08-06  Tom Tromey  <tom@tromey.com>
 882
 883         * gdb_obstack.h (obstack_strdup): Define.
 884         * gdb_obstack.c (obstack_strdup): Don't define.
 885
 886 2019-08-06  Tom Tromey  <tom@tromey.com>
 887
 888         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 889         obstack_strdup.
 890         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 891         obstack_strdup.
 892         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 893         * stabsread.c (common_block_start): Use obstack_strdup.
 894         * objfiles.c (set_objfile_main_name, objfile): Use
 895         obstack_strdup.
 896         * namespace.c (add_using_directive): Use obstack_strdup.
 897         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 898         * jit.c (finalize_symtab): Use obstack_strdup.
 899         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 900         (guess_partial_die_structure_name, partial_die_info::fixup)
 901         (dwarf2_name): Use obstack_strdup.
 902         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 903         obstack_strdup.
 904         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 905         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 906         obstack_strdup.
 907         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 908
 909 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 910
 911         * unittests/help-doc-selftests.c: New file.
 912         * Makefile.in: Add the new file.
 913
 914 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 915
 916         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 917         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 918         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 919         the trailing '.' is not output, and the first character is uppercased.
 920         (print_help_for_command): Update call to print_doc_line.
 921         (print_doc_of_command): Likewise.
 922         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 923         * cli/cli-option.c (append_indented_doc): Do not append newline.
 924         (build_help_option): Append newline after first appended_indented_doc
 925         only if a second call is done.
 926         (build_help): Append 2 new lines before each option, except the first
 927         one.
 928         * compile/compile.c (_initialize_compile): Add new lines after
 929         %OPTIONS%, when not at the end of the help.
 930         Change help doc or code
 931         producing the help doc to respect the invariants.
 932         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 933         Also removed the new line after 'Options:', as all other commands
 934         do not put an empty line between 'Options:' and the first option.
 935         * printcmd.c (_initialize_printcmd): Likewise.
 936         * stack.c (_initialize_stack): Likewise.
 937         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 938         incorrectly telling COMMAND is optional.
 939         * ada-lang.c (_initialize_ada_language): Change help doc or code
 940         producing the help doc to respect the invariants.
 941         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 942         * breakpoint.c (_initialize_breakpoint): Likewise.
 943         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 944         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 945         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 946         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 947         _initialize_cli_style): Likewise.
 948         * corelow.c (core_target_info): Likewise.
 949         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 950         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 951         * filesystem.c (_initialize_filesystem): Likewise.
 952         * frame.c (_initialize_frame): Likewise.
 953         * gnu-nat.c (add_task_commands): Likewise.
 954         * infcall.c (_initialize_infcall): Likewise.
 955         * infcmd.c (_initialize_infcmd): Likewise.
 956         * interps.c (_initialize_interpreter): Likewise.
 957         * language.c (_initialize_language): Likewise.
 958         * linux-fork.c (_initialize_linux_fork): Likewise.
 959         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 960         * maint.c (_initialize_maint_cmds): Likewise.
 961         * memattr.c (_initialize_mem): Likewise.
 962         * printcmd.c (_initialize_printcmd): Likewise.
 963         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 964         _RegEx): Likewise.
 965         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 966         * record-btrace.c (_initialize_record_btrace): Likewise.
 967         * record-full.c (_initialize_record_full): Likewise.
 968         * record.c (_initialize_record): Likewise.
 969         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 970         * regcache.c (_initialize_regcache): Likewise.
 971         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 972         _initialize_remote): Likewise.
 973         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 974         * serial.c (_initialize_serial): Likewise.
 975         * skip.c (_initialize_step_skip): Likewise.
 976         * source.c (_initialize_source): Likewise.
 977         * stack.c (_initialize_stack): Likewise.
 978         * symfile.c (_initialize_symfile): Likewise.
 979         * symtab.c (_initialize_symtab): Likewise.
 980         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 981         * top.c (init_main): Likewise.
 982         * tracefile-tfile.c (tfile_target_info): Likewise.
 983         * tracepoint.c (_initialize_tracepoint): Likewise.
 984         * tui/tui-win.c (_initialize_tui_win): Likewise.
 985         * utils.c (add_internal_problem_command): Likewise.
 986         * valprint.c (value_print_option_defs): Likewise.
 987
 988 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 989
 990         PR build/24886
 991         * configure.ac: Drop enable-libmcheck support.
 992         * configure, config.in: Rebuild.
 993         * libmcheck.m4: Remove.
 994         * acinclude.m4: Don't include it.
 995         * Makefile.in: Don't distribute it.
 996         * top.c (print_gdb_configuration): Don't mention it.
 997
 998 2019-08-06  Tom Tromey  <tom@tromey.com>
 999
1000         * utils.c (set_output_style): Sometimes pass stream to
1001         emit_style_escape.
1002         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1003         * record-btrace.c (btrace_insn_history): Update.
1004         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1005         method.
1006         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1007         Update initializers.
1008         <m_uiout>: New field.
1009         <m_di>: Move lower.
1010         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1011         Remove "uiout" parameter.
1012         (dump_insns): Update.
1013         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1014         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1015
1016 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1017
1018         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1019         (error_in_psymtab_expansion): Likewise.
1020         (lookup_symbol_via_quick_fns): Likewise.
1021         (basic_lookup_transparent_type_quick): Likewise.
1022         (basic_lookup_transparent_type_1): Likewise.
1023
1024 2019-08-06  Tom Tromey  <tromey@adacore.com>
1025
1026         * source.c (last_source_error): Now bool.
1027         (print_source_lines_base): Make "noprint" bool.  Only open
1028         source file when last_source_visited changes.
1029
1030 2019-08-06  Tom Tromey  <tromey@adacore.com>
1031
1032         * annotate.c (annotate_source_line): Use g_source_cache.
1033         * source-cache.c (source_cache::get_plain_source_lines): Change
1034         parameters.  Populate m_offset_cache.
1035         (source_cache::ensure): New method.
1036         (source_cache::get_line_charpos): New method.
1037         (extract_lines): Move lower.  Change parameters.
1038         (source_cache::get_source_lines): Move lower.
1039         * source-cache.h (class source_cache): Update comment.
1040         <get_line_charpos>: New method.
1041         <get_source_lines>: Update comment.
1042         <clear>: Clear m_offset_cache.
1043         <get_plain_source_lines>: Change parameters.
1044         <ensure>: New method
1045         <m_offset_cache>: New member.
1046         * source.c (forget_cached_source_info_for_objfile): Update.
1047         (info_source_command): Use g_source_cache.
1048         (find_source_lines, open_source_file_with_line_charpos): Remove.
1049         (print_source_lines_base, search_command_helper): Use g_source_cache.
1050         * source.h (open_source_file_with_line_charpos): Don't declare.
1051         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1052         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1053         Use g_source_cache.
1054
1055 2019-08-06  Tom Tromey  <tromey@adacore.com>
1056
1057         * source-cache.c (source_cache::get_plain_source_lines):
1058         Remove "first_line" and "last_line" parameters.
1059         (source_cache::get_source_lines): Cache plain text.
1060         * source-cache.h (class source_cache)
1061         <get_plain_source_lines>: Update.
1062
1063 2019-08-06  Tom Tromey  <tromey@adacore.com>
1064
1065         * source-cache.c (extract_lines): No longer a method.
1066         Changed type of parameter.  Include final newline.
1067         (selftests::extract_lines_test): New function.
1068         (_initialize_source_cache): Likewise.
1069         * source-cache.h (class source_cache)
1070         <extract_lines>: Don't declare.
1071
1072 2019-08-06  Tom Tromey  <tromey@adacore.com>
1073
1074         * breakpoint.c (init_breakpoint_sal): Update.
1075         (breakpoint): Update.
1076         * breakpoint.h (struct breakpoint) <filter>: Now a
1077         unique_xmalloc_ptr.
1078
1079 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1080
1081         * NEWS: Mention dictionary access on blocks.
1082         * python/py-block.c (blpy_getitem): New function.
1083         (block_object_as_mapping): New struct.
1084         (block_object_type): Use new struct for tp_as_mapping field.
1085
1086 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1087
1088         * objfiles.h (objfile): Add a comment describing partial symbols.
1089
1090 2019-08-05  Tom Tromey  <tromey@adacore.com>
1091
1092         * compile/compile.c (_initialize_compile): Use _(), not N_().
1093         * thread.c (_initialize_thread): Use _(), not N_().
1094         * stack.c (_initialize_stack): Use _(), not N_().
1095         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1096
1097 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1098
1099         * dwarf2read.c (struct dw2_symtab_iterator):
1100         <want_specific_block>: Remove.
1101         <block_index>: Change type to gdb::optional.
1102         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1103         change type of BLOCK_INDEX parameter to gdb::optional.
1104         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1105         (dw2_lookup_symbol): Don't pass argument for
1106         WANT_SPECIFIC_BLOCK.
1107         (dw2_expand_symtabs_for_function): Don't pass argument for
1108         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1109         (class dw2_debug_names_iterator)
1110         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1111         parameter, change BLOCK_INDEX type to gdb::optional.
1112         <m_want_specific_block>: Remove.
1113         <m_block_index>: Change type to gdb::optional.
1114         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1115         gdb::optional.  Re-write in function of gdb::optional.
1116         (dw2_debug_names_lookup_symbol): Don't pass argument for
1117         WANT_SPECIFIC_BLOCK.
1118         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1119         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1120         BLOCK_INDEX.
1121
1122 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1123
1124         * NEWS: Mention changes to "info sources" command.
1125
1126 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1127
1128         * symtab.c (filename_partial_match_opts): New struct type.
1129         (struct output_source_filename_data): New members
1130         regexp, c_regexp, partial_match.
1131         (output_source_filename): Use new members to decide to print file.
1132         (info_sources_option_defs): New variable.
1133         (make_info_sources_options_def_group, print_info_sources_header,
1134         info_sources_command_completer):
1135         New functions.
1136         (info_sources_command): Read new optional arguments.
1137         (_initialize_symtab): Update info sources help.
1138
1139 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1140
1141         * ada-lang.c (exception_support_info_v0): Renamed from...
1142         (default_exception_support_info): ... this.  Create new
1143         definition for v1.
1144         (ada_has_this_exception_support): Look up catch_handlers_sym.
1145         (ada_exception_support_info_sniffer): Try v0 after default.
1146
1147 2019-08-01  Tom Tromey  <tromey@adacore.com>
1148
1149         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1150         gdbarch.h.
1151
1152 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1153
1154         * s12z-tdep.c: Fix include path for s12z-opc.h.
1155
1156 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1157
1158         * NEWS: Require GNU make 3.82.
1159
1160 2019-07-16  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1163         declare.
1164
1165 2019-07-30  Tom Tromey  <tromey@adacore.com>
1166
1167         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1168
1169 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1170
1171         * printcmd.c (print_address_symbolic): Print negative offsets.
1172         (build_address_symbolic): Force signed arithmetic when computing
1173         offset.
1174
1175 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1176
1177         PR/24474: Add a function to lookup static variables.
1178         * NEWS: Mention this new function.
1179         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1180         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1181         * python/python.c (python_GdbMethods): Add new function.
1182
1183 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1184
1185         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1186         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1187         (objfpy_lookup_static_symbol): New function.
1188         (objfile_object_methods): Add new functions.
1189
1190 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1191
1192         * NEWS: Mention 'set|show print frame-info'.  Mention new
1193         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1194         backtrace argument.  Mention that python frame filtering code
1195         is now consistent with what 'backtrace' command prints.
1196
1197 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1198
1199         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1200         comments.
1201         (print_frame_info_auto, print_frame_info_source_line,
1202         print_frame_info_location, print_frame_info_source_and_location,
1203         print_frame_info_location_and_address, print_frame_info_short_location):
1204         New declarations.
1205         (struct frame_print_options): New member print_frame_info.
1206         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1207         * stack.h (get_user_print_what_frame_info): New declaration.
1208         (frame_show_address): New declaration.
1209         * stack.c (print_frame_arguments_choices): New value 'presence'.
1210         (print_frame_info_auto, print_frame_info_source_line,
1211         print_frame_info_location, print_frame_info_source_and_location,
1212         print_frame_info_location_and_address, print_frame_info_short_location,
1213         print_frame_info_choices, print_frame_info_print_what): New definitions.
1214         (print_frame_args): Only print dots for args if print frame-arguments
1215         is 'presence'.
1216         (frame_print_option_defs): New element for "frame-info".
1217         (get_user_print_what_frame_info): New function.
1218         (frame_show_address): Make non static.  Move comment to stack.h.
1219         (print_frame_info_to_print_what): New function.
1220         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1221         to decide what to print.
1222         (backtrace_command_1): Handle the new print_frame_arguments_presence
1223         value.
1224         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1225         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1226         (py_print_frame): In non-mi mode, use LOCATION as default for
1227         print_what, similarly to frame information printed directly by
1228         backtrace command. Handle frame-info user option in non MI mode.
1229
1230 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1231
1232         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1233         Add case for debugging 32-bit target on 64-bit host.  Revise
1234         comment.
1235
1236 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1237
1238         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1239         instead of find_function_entry_range_from_pc.
1240
1241 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1242
1243         * stack.c (find_frame_funname): Remove code which preferred
1244         minsym over symtab sym in "certain pathological cases".
1245
1246         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1247         parameter.  Change type of "do_demangle" to bool.
1248         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1249         Pass suitable "prefer_sym_over_minsym" flag to
1250         build_address_symbolic().  Don't output "+" for negative offsets.
1251         * printcmd.c (print_address_symbolic): Update invocation of
1252         build_address_symbolic to include a "prefer_sym_over_minsym"
1253         flag.
1254         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1255         Restrict cases in which use of minimal symbol is preferred to that
1256         of a found symbol.  Update comments.
1257
1258         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1259         for entry pc when entry pc is out of range for that FDE.
1260
1261 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1262
1263         PR gdb/24839:
1264         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1265         type.
1266
1267 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1268
1269         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1270         this function's Python signature.
1271
1272
1273 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1274
1275         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1276         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1277         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1278         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1279         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1280
1281
1282 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1283
1284         * h8300-tdep.c (h8300_register_name_common): New.
1285         h8300_register_name): Use h8300_register_name_common.
1286         (h8300s_register_name): Likewise.
1287         (h8300sx_register_name): Likewise.
1288         (h8300h_register_nam): New.
1289         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1290
1291
1292 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1293
1294         * arm-tdep.c (arm_skip_cmse_entry): New function.
1295         (arm_is_sgstubs_section): New function.
1296         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1297
1298 2019-07-22  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1301         Don't self-assign.
1302
1303 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1306         type_print.
1307
1308 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1311         so that GDB doesn't match any msymbols when searching in the
1312         TYPES_DOMAIN.
1313         (print_symbol_info): Print using typedef_print or type_print based
1314         on the type of the symbol.  Add updated FIXME comment moved from...
1315         (_initialize_symtab): ... move and update FIXME comment to above.
1316
1317 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * NEWS: Mention adding -q option to "info types".
1320         * symtab.c (struct info_types_options): New struct.
1321         (info_types_options_defs): New variable.
1322         (make_info_types_options_def_group): New function.
1323         (info_types_command): Use gdb::option framework to parse options.
1324         (info_types_command_completer): New function.
1325         (_initialize_symtab): Extend the help text on "info types" and
1326         register command completer.
1327
1328 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1329
1330         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1331         (lookup_symbol_in_objfile): Change int to block_enum and add a
1332         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1333
1334 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1335
1336         * MAINTAINERS (Write After Approval): Add self.
1337
1338 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1341         instruction to the dummy code region.
1342
1343 2019-07-19  Tom Tromey  <tromey@adacore.com>
1344
1345         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1346         (ARGSUSED, PARAMS, __func__): Remove rules.
1347
1348 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1349
1350         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1351         * features/arm/arm-with-iwmmxt.c: Remove.
1352         * features/arm/arm-with-iwmmxt.xml: Remove.
1353         * features/arm/arm-with-m-fpa-layout.c: Remove.
1354         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1355         * features/arm/arm-with-m-vfp-d16.c: Remove.
1356         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1357         * features/arm/arm-with-m.c: Remove.
1358         * features/arm/arm-with-m.xml: Remove.
1359         * features/arm/arm-with-neon.c: Remove.
1360         * features/arm/arm-with-neon.xml: Remove.
1361         * features/arm/arm-with-vfpv2.c: Remove.
1362         * features/arm/arm-with-vfpv2.xml: Remove.
1363         * features/arm/arm-with-vfpv3.c: Remove.
1364         * features/arm/arm-with-vfpv3.xml: Remove.
1365
1366 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1367
1368         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1369
1370 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1371
1372         * arch/aarch32.c (aarch32_create_target_description): Create
1373         target descriptions using features.
1374         * arch/arm.c (arm_create_target_description)
1375         (arm_create_mprofile_target_description): Likewise.
1376         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1377
1378 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1379
1380         * Makefile.in: Add new files.
1381         * aarch32-tdep.c: New file.
1382         * aarch32-tdep.h: New file.
1383         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1384         Call aarch32_read_description.
1385         * arch/aarch32.c: New file.
1386         * arch/aarch32.h: New file.
1387         * arch/arm.c (arm_create_target_description)
1388         (arm_create_mprofile_target_description): New function.
1389         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1390         (arm_create_target_description)
1391         (arm_create_mprofile_target_description): New declaration.
1392         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1393         read_description functions.
1394         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1395         Likewise.
1396         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1397         * arm-tdep.c (tdesc_arm_list): New variable.
1398         (arm_register_g_packet_guesses): Call create description functions.
1399         (arm_read_description) (arm_read_mprofile_description): New
1400         function.
1401         * arm-tdep.h (arm_read_description)
1402         (arm_read_mprofile_description): Add declaration.
1403         * configure.tgt: Add new files.
1404
1405 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1406
1407         * top.c (new_ui_command): Open specified terminal just once.
1408
1409 2019-07-18  Tom Tromey  <tromey@adacore.com>
1410
1411         * symtab.c (main_name): Constify return type.
1412         * symfile.c (set_initial_language): Update.
1413         * symtab.h (main_name): Constify return type.
1414
1415 2019-07-17  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-winsource.c (tui_update_source_window)
1418         (tui_update_source_window_as_is)
1419         (tui_update_source_windows_with_line): Remove return.
1420         * tui/tui-disasm.c (tui_show_disassem)
1421         (tui_show_disassem_and_update_source): Remove return.
1422         * tui/tui.c (tui_reset): Remove return.
1423         * tui/tui-wingeneral.c
1424         (tui_check_and_display_highlight_if_needed): Remove return.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1429
1430 2019-07-17  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-winsource.h (struct tui_exec_info_window)
1433         (struct tui_source_window_base): Move from tui-data.h.
1434         * tui/tui-winsource.c: Move many method definitions from
1435         elsewhere.  Remove "structuring" comments.
1436         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1437         (tui_source_window_base::refresh_window): Move to
1438         tui-winsource.c.
1439         * tui/tui-win.c (tui_source_window_base::refresh_all)
1440         (tui_source_window_base::update_tab_width)
1441         (tui_source_window_base::set_new_height)
1442         (tui_source_window_base::do_make_visible_with_new_height): Move to
1443         tui-winsource.c.
1444         * tui/tui-source.h: Update.
1445         * tui/tui-source.c (tui_source_window_base::reset): Move to
1446         tui-winsource.c.
1447         * tui/tui-disasm.h: Update.
1448         * tui/tui-data.h (struct tui_exec_info_window): Move to
1449         tui-winsource.h.
1450         (struct tui_source_window_base): Likewise.
1451         * tui/tui-data.c (tui_source_window_base::clear_detail)
1452         (tui_source_window_base, ~tui_source_window_base): Move to
1453         tui-winsource.c.
1454
1455 2019-07-17  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-win.c (tui_resize_all)
1458         (tui_source_window_base::update_tab_width)
1459         (tui_adjust_win_heights): Update.
1460         (tui_win_info::make_invisible_and_set_new_height): Rename from
1461         make_invisible_and_set_new_height.
1462         * tui/tui-data.h (struct tui_win_info)
1463         <make_invisible_and_set_new_height>: New method.
1464
1465 2019-07-17  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui.c: Update.
1468         * tui/tui-source.h (struct tui_source_window): Move from
1469         tui-data.h.
1470         * tui/tui-layout.c: Update.
1471         * tui/tui-disasm.c: Update.
1472         * tui/tui-data.h (struct tui_source_window): Move to
1473         tui-source.h.
1474
1475 2019-07-17  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1478         tui-data.h.
1479         * tui/tui-data.h (struct tui_disasm_window): Move to
1480         tui-disasm.h.
1481
1482 2019-07-17  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-regs.h (struct tui_data_item_window): Move from
1485         tui-data.h.
1486         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1487         * tui/tui-data.h (struct tui_data_item_window): Move to
1488         tui-regs.h.
1489         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1490
1491 2019-07-17  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui.c: Update.
1494         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1495         (tui_cmd_window::max_height): Move to tui-command.c.
1496         * tui/tui-layout.c: Update.
1497         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1498         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1499         tui-command.c.
1500         * tui/tui-command.h (struct tui_cmd_window): Move from
1501         tui-data.h.
1502         * tui/tui-command.c: Remove "structuring" comments.
1503         (tui_cmd_window::clear_detail)
1504         (tui_cmd_window::do_make_visible_with_new_height)
1505         (tui_cmd_window::max_height): Move from elsewhere.
1506
1507 2019-07-17  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1510         Now static.
1511         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1512         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1513
1514 2019-07-17  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui.c: Update.
1517         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1518         tui-regs.c.
1519         * tui/tui-windata.h: Remove file.
1520         * tui/tui-windata.c: Remove file.
1521         * tui/tui-win.c (tui_data_window::set_new_height)
1522         (tui_data_window::do_make_visible_with_new_height): Move to
1523         tui-regs.c.
1524         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1525         * tui/tui-regs.c: Remove "structuring" comments.
1526         (tui_data_window::first_data_item_displayed)
1527         (tui_data_window::delete_data_content_windows)
1528         (tui_data_window::erase_data_content)
1529         (tui_data_window::display_all_data)
1530         (tui_data_window::refresh_all)
1531         (tui_data_window::do_scroll_vertical)
1532         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1533         (tui_data_window::do_make_visible_with_new_height)
1534         (tui_data_window::refresh_window): Move from elsewhere.
1535         (_initialize_tui_regs): Move to end of file.
1536         * tui/tui-layout.c: Update.
1537         * tui/tui-hooks.c: Update.
1538         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1539         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1540         tui-regs.c.
1541         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1546         seen.
1547
1548 2019-07-17  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-win.c (tui_source_window_base::set_new_height)
1551         (tui_source_window_base::do_make_visible_with_new_height): Use
1552         m_has_locator field directly.
1553         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1554         method.
1555         (struct tui_source_window_base) <has_locator>: Likewise.
1556
1557 2019-07-17  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1560         Don't declare.
1561         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1562         Remove.
1563         * tui/tui-win.c (tui_source_window_base::set_new_height)
1564         (tui_source_window_base::set_new_height)
1565         (make_invisible_and_set_new_height)
1566         (tui_source_window_base::do_make_visible_with_new_height)
1567         (tui_source_window_base::do_make_visible_with_new_height):
1568         Update.
1569         * tui/tui-layout.c (show_source_disasm_command, show_data)
1570         (show_source_or_disasm_and_command): Update.
1571         * tui/tui-layout.c (show_layout): Update.
1572
1573 2019-07-17  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-layout.c (make_data_window): Remove.
1576         (show_data): Unify creation and re-initialization cases.
1577
1578 2019-07-17  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-layout.c (make_source_window, make_disasm_window):
1581         Remove.
1582         (show_data): Unify creation and re-initialization cases.
1583
1584 2019-07-17  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-layout.c (make_command_window): Remove.
1587         (show_source_disasm_command, show_source_or_disasm_and_command):
1588         Unify creation and re-initialization cases.
1589
1590 2019-07-17  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1593         creation and re-initialization cases.
1594
1595 2019-07-17  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-regs.c (tui_get_register): Return void.
1598
1599 2019-07-17  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1602         Simplify.
1603
1604 2019-07-17  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1607         resetting.
1608
1609 2019-07-17  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1612         * tui/tui-regs.c (tui_reg_layout): New function.
1613         (tui_show_registers, tui_reg_command): Use it.
1614         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1615         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1616         parameters.
1617         (tui_layout_command): Remove.
1618
1619 2019-07-17  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-layout.h (tui/tui-layout): Return void.
1622         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1623
1624 2019-07-17  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-layout.c (show_source_disasm_command, show_data):
1627         Update.
1628         (reset_locator): Remove.
1629         (show_source_or_disasm_and_command): Update.
1630
1631 2019-07-17  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-source.c (tui_source_window_base::reset): Remove
1634         win_type parameter.
1635         * tui/tui-layout.c (make_command_window, make_source_window)
1636         (make_disasm_window, make_data_window)
1637         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1638         (reset_locator, show_source_or_disasm_and_command): Update.
1639         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1640         win_type parameter.
1641         (struct tui_source_window_base) <reset>: Likewise.
1642
1643 2019-07-17  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-layout.c (show_source_disasm_command): Use
1646         reset_locator.
1647         (reset_locator): New function.
1648         (init_and_make_win): Remove.
1649         (show_source_or_disasm_and_command): Use reset_locator.
1650
1651 2019-07-17  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1654         condition.
1655         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1656         Remove condition.
1657         * tui/tui-source.c (tui_source_window_base::reset): New method.
1658         * tui/tui-layout.c (make_command_window): Don't call
1659         init_and_make_win.
1660         (make_source_window, make_disasm_window): Don't call
1661         make_source_or_disasm_window.
1662         (make_data_window): Don't call init_and_make_win.  Change calling
1663         convention.
1664         (show_source_disasm_command, show_data): Simplify.
1665         (make_source_or_disasm_window): Remove.
1666         (show_source_or_disasm_and_command): Simplify.
1667         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1668         (struct tui_source_window_base) <reset>: Likewise.
1669         <execution_info>: Remove initializer.
1670         * tui/tui-data.c (tui_source_window_base): Initialize
1671         execution_info.
1672
1673 2019-07-17  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1676         variable.
1677
1678 2019-07-17  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui.c (tui_rl_other_window): Update.
1681         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1682         superclass method first.  Always iterate over regs_content.
1683         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1684         method.
1685         * tui/tui-win.c (tui_set_focus_command): Update.
1686
1687 2019-07-17  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-win.c (tui_set_focus_command): Rename from
1690         tui_set_focus.  Call tui_enable.
1691         (tui_set_focus_command): Remove.
1692
1693 2019-07-17  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1696         refresh_window.
1697         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1698         touchwin.
1699         (tui_data_window::refresh_window): Call refresh_window on data
1700         items.  Always call superclass refresh_window.
1701         (tui_win_info::refresh): Remove.
1702         (tui_source_window_base::refresh_window): Update.
1703         (tui_refresh_all): Update.
1704         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1705         refresh_window.
1706         (show_source_or_disasm_and_command): Likewise.
1707         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1708         (struct tui_source_window_base) <refresh>: Likewise.
1709
1710 2019-07-17  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-winsource.c (tui_clear_source_content)
1713         (tui_show_source_content): Update.
1714         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1715         whether content is empty.
1716         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1717         Remove.
1718
1719 2019-07-17  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1722         window's contents.
1723         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1724         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1725
1726 2019-07-17  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1729         (struct tui_data_item_window): Update.
1730
1731 2019-07-17  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1734         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1735         defines.
1736
1737 2019-07-17  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-winsource.h (tui_erase_source_content)
1740         (tui_clear_source_content): Remove "display_prompt" parameter.
1741         * tui/tui-winsource.c (tui_update_source_window_as_is)
1742         (tui_update_source_windows_with_addr): Update.
1743         (tui_clear_source_content): Remove "display_prompt" parameter.
1744         (tui_erase_source_content): Likewise.  Simplify.
1745         (tui_show_source_content): Update.
1746         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1747         * tui/tui-stack.c (tui_show_frame_info): Update.
1748         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1749         Remove defines.
1750
1751 2019-07-17  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1754         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1755         parameter.
1756         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1757         parameter.
1758
1759 2019-07-17  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-winsource.c (tui_clear_source_content)
1762         (tui_show_source_content, tui_show_exec_info_content)
1763         (tui_clear_exec_info_content): Update.
1764         * tui/tui-stack.c (tui_show_locator_content): Update.
1765         (tui_show_frame_info): Update.
1766         * tui/tui-source.h (tui_source_window): Don't declare.
1767         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1768         from tui_source_is_displayed.
1769         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1770         Remove field.
1771         (struct tui_source_window_base) <content_in_use>: New field.  Now
1772         bool.
1773         (struct tui_source_window) <showing_source_p>: New method.
1774         (TUI_SRC_WIN): Change cast.
1775         * tui/tui-data.c (tui_initialize_static_data): Update.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1780         location_matches_p.
1781         * tui/tui-source.c (tui_source_window::location_matches_p): New
1782         method.
1783         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1784         method.
1785         * tui/tui-data.h (struct tui_source_window_base)
1786         <location_matches_p>: New method.
1787         (struct tui_source_window, struct tui_disasm_window)
1788         <location_matches_p>: Likewise.
1789
1790 2019-07-17  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-win.c (tui_set_win_height_command): Rename from
1793         tui_set_win_height.
1794         (tui_set_win_height_command): Remove.
1795
1796 2019-07-17  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-source.c (tui_source_window): New constructor.  Add
1799         observer.
1800         (~tui_source_window): New destructor.
1801         (tui_source_window::style_changed): New method.
1802         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1803         (tui_attach_detach_observers): Update.
1804         * tui/tui-data.h (struct tui_source_window): Make constructor not
1805         inline.  Add destructor.
1806         (struct tui_source_window) <style_changed>: New method.
1807         <m_observable>: New member.
1808
1809 2019-07-17  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1812         * tui/tui-win.c (tui_resize_all): Fix typo.
1813
1814 2019-07-17  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1817         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1818         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1819         * tui/tui-win.c (window_name_completer): Use foreach.
1820         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1821         (update_tab_width): Likewise.
1822         * tui/tui-layout.c (show_layout): Update.
1823         * tui/tui-data.h (class tui_window_iterator): New.
1824         (struct all_tui_windows): New.
1825         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1826
1827 2019-07-17  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1830         parameter.  Don't reference globals.
1831         (tui_reg_command): Update.
1832
1833 2019-07-17  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-regs.c (tui_show_registers): Simplify.
1836
1837 2019-07-17  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-regs.c (tui_show_registers): Update.
1840         (tui_show_register_group): Add win_info parameter.
1841
1842 2019-07-17  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1845         Rename from tui_display_reg_element_at_line.
1846         (tui_data_window::display_registers_from_line): Update.
1847         * tui/tui-data.h (struct tui_data_window)
1848         <display_reg_element_at_line>: New method.
1849
1850 2019-07-17  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-regs.h (tui_display_registers_from)
1853         (tui_display_registers_from_line): Don't declare.
1854         * tui/tui-windata.c (tui_data_window::display_all_data)
1855         (tui_data_window::refresh_all)
1856         (tui_data_window::do_scroll_vertical): Update.
1857         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1858         from tui_display_registers_from.
1859         (tui_display_reg_element_at_line): Update.
1860         (tui_data_window::display_registers_from_line): Rename from
1861         tui_display_registers_from_line.
1862         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1863         display_registers_from_line>: New methods.
1864
1865 2019-07-17  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1868         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1869         from tui_erase_data_content.
1870         (tui_data_window::display_all_data)
1871         (tui_data_window::refresh_all)
1872         (tui_data_window::do_scroll_vertical): Update.
1873         * tui/tui-regs.c (tui_show_registers): Update.
1874         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1875         New method.
1876
1877 2019-07-17  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1880         declare.
1881         * tui/tui-windata.c
1882         (tui_data_window::delete_data_content_windows): Rename from
1883         tui_delete_data_content_windows.
1884         (tui_data_window::display_all_data)
1885         (tui_data_window::do_scroll_vertical): Update.
1886         * tui/tui-data.h (struct tui_data_window)
1887         <delete_data_content_windows>: New method.
1888
1889 2019-07-17  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1892         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1893
1894 2019-07-17  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1897         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1898         from tui_display_all_data.
1899         * tui/tui-win.c
1900         (tui_data_window::do_make_visible_with_new_height): Update.
1901         * tui/tui-regs.c (tui_show_registers): Update.
1902         * tui/tui-layout.c (tui_set_layout): Update.
1903         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1904         method.
1905
1906 2019-07-17  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1909         * tui/tui-windata.c (tui_display_data_from): Remove.
1910         (tui_data_window::refresh_all): Update.
1911
1912 2019-07-17  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1915         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1916         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1917         tui_display_registers_from_line.
1918         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1919         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1920         "force_display" parameter.
1921
1922 2019-07-17  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1925         declare.
1926         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1927         Rename from tui_first_reg_element_no_inline.
1928         (tui_display_reg_element_at_line)
1929         (tui_display_registers_from_line): Update.
1930         * tui/tui-data.h (struct tui_data_window)
1931         <first_reg_element_no_inline>: New method.
1932
1933 2019-07-17  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-windata.c (tui_display_data_from)
1936         (tui_data_window::do_scroll_vertical): Update.
1937         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1938         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1939         Rename from tui_line_from_reg_element_no.
1940         (tui_display_registers_from_line): Update.
1941         * tui/tui-data.h (struct tui_data_window)
1942         <line_from_reg_element_no>: New method.
1943
1944 2019-07-17  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1947         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1948         tui_last_regs_line_no.
1949         (tui_display_reg_element_at_line)
1950         (tui_display_registers_from_line): Update.
1951         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1952         method.
1953
1954 2019-07-17  Tom Tromey  <tom@tromey.com>
1955
1956         PR tui/24722:
1957         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1958         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1959         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1960         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1961         (tui_update_breakpoint_info): Likewise.
1962         * tui/tui-hooks.c (tui_event_create_breakpoint)
1963         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1964         Update.
1965
1966 2019-07-17  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1969
1970 2019-07-17  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-winsource.c (tui_update_source_window_as_is)
1973         (tui_update_source_windows_with_addr): Update.
1974         * tui/tui-source.h (tui_set_source_content)
1975         (tui_show_symtab_source): Add "win_info" parameter.
1976         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1977         parameter.
1978         (tui_show_symtab_source): Likewise.
1979
1980 2019-07-17  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-wingeneral.c
1983         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1984
1985 2019-07-17  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1988         (struct tui_cmd_window) <can_scroll>: New method.
1989         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1990         method.
1991
1992 2019-07-17  Tom Tromey  <tromey@adacore.com>
1993
1994         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1995         do_field_signed>: Rename.  Change type of "value".
1996         * ui-out.c (ui_out::field_signed): Rename from field_int.
1997         Change type of "value".
1998         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1999         type of "value".
2000         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2001         do_field_int.  Change type of "value".
2002         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2003         do_field_int.  Change type of "value".
2004         * tracepoint.c (trace_status_mi, tfind_1)
2005         (print_one_static_tracepoint_marker): Update.
2006         * thread.c (print_thread_info_1, print_selected_thread_frame):
2007         Update.
2008         * stack.c (print_frame, print_frame_info): Update.
2009         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2010         Update.
2011         * source.c (print_source_lines_base): Update.
2012         * skip.c (info_skip_command): Update.
2013         * record-btrace.c (btrace_ui_out_decode_error)
2014         (btrace_call_history_src_line): Update.
2015         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2016         Update.
2017         * progspace.c (print_program_space): Update.
2018         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2019         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2020         do_field_int.  Change type of "value".
2021         * mi/mi-out.c (mi_ui_out::do_table_begin)
2022         (mi_ui_out::do_table_header): Update.
2023         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2024         type of "value".
2025         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2026         (mi_cmd_data_list_changed_registers, output_register)
2027         (mi_cmd_data_read_memory, mi_load_progress)
2028         (mi_cmd_trace_frame_collected): Update.
2029         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2030         Update.
2031         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2032         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2033         (mi_cmd_var_list_children, varobj_update_one): Update.
2034         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2035         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2036         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2037         * inferior.c (print_inferior): Update.
2038         * gdb_bfd.c (print_one_bfd): Update.
2039         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2040         Update.
2041         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2042         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2043         do_field_int.  Change type of "value".
2044         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2045         do_field_int.  Change type of "value".
2046         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2047         (print_one_breakpoint_location, print_it_catch_fork)
2048         (print_one_catch_fork, print_it_catch_vfork)
2049         (print_one_catch_vfork, print_it_catch_solib)
2050         (print_it_catch_exec, print_it_ranged_breakpoint)
2051         (print_mention_watchpoint, print_mention_masked_watchpoint)
2052         (bkpt_print_it, update_static_tracepoint): Update.
2053         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2054         * break-catch-syscall.c (print_it_catch_syscall): Update.
2055         * ada-tasks.c (print_ada_task_info): Update.
2056         * ada-lang.c (print_it_exception, print_mention_exception):
2057         Update.
2058
2059 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2060
2061         PR breakpoints/24541
2062         * gdbarch.c: Regenerate.
2063         * gdbarch.h: Regenerate.
2064         * gdbarch.sh: Adjust return type and parameter types for
2065         'stap_adjust_register'.
2066         (i386_stap_adjust_register): Adjust signature and return new
2067         register name.
2068         * stap-probe.c (stap_parse_register_operand): Adjust use of
2069         'gdbarch_stap_adjust_register'.
2070
2071 2019-07-17  Tom Tromey  <tromey@adacore.com>
2072
2073         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2074         declare VEC.
2075         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2076         std::vector.
2077         (struct s390_process_info): Add initializers.
2078         (s390_add_process): Use new.
2079         (s390_linux_nat_target::low_forget_process): Use delete.
2080         (s390_linux_nat_target::low_new_fork)
2081         (s390_linux_nat_target::stopped_by_watchpoint)
2082         (s390_linux_nat_target::low_prepare_to_resume)
2083         (s390_linux_nat_target::insert_watchpoint)
2084         (s390_linux_nat_target::insert_hw_breakpoint)
2085         (s390_linux_nat_target::remove_watchpoint)
2086         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2087
2088 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2089
2090         * aarch64-fbsd-nat.c: Include regcache.h.
2091         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2092         argument.
2093         (aarch64_fbsd_nat_target::fetch_registers)
2094         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2095         variable.
2096         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2097
2098 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2099
2100         * fbsd-nat.c: Include gdbarch.h.
2101
2102 2019-07-15  Tom Tromey  <tromey@adacore.com>
2103
2104         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2105
2106 2019-07-15  Tom Tromey  <tromey@adacore.com>
2107
2108         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2109         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2110         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2111         * cli-out.c (cli_ui_out::do_field_int): New method.
2112         * ui-out.c (ui_out::field_unsigned): New method.
2113         * symfile.c (generic_load): Use field_unsigned.
2114         (print_transfer_performance): Likewise.
2115         * record-btrace.c (ui_out_field_uint): Remove.
2116         (btrace_call_history_insn_range, btrace_call_history): Use
2117         field_unsigned.
2118         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2119         field_unsigned.
2120         * ui-out.h (class ui_out) <field_unsigned>: New method.
2121         <do_field_unsigned>: Likewise.
2122
2123 2019-07-15  Tom Tromey  <tromey@adacore.com>
2124
2125         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2126         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2127         * target.c (flash_erase_command): Use field_string.
2128         * infrun.c (print_signal_received_reason): Use field_string.
2129         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2130         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2131         field_string.
2132         * ada-tasks.c (print_ada_task_info): Use field_string.
2133
2134 2019-07-15  Tom Tromey  <tromey@adacore.com>
2135
2136         * target.c (flash_erase_command): Use field_core_addr.
2137         * symfile.c (generic_load): Use field_core_addr.
2138         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2139         Use field_core_addr.
2140         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2141         field_core_addr.
2142
2143 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2144
2145         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2146         value if its desired type is smaller than a CORE_ADDR and signed.
2147
2148 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2151         of changes to field names, and use new is_reference field to
2152         decide if a property is a reference or not.
2153         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2154         field.
2155         (struct dwarf2_property_baton): Update header comment, rename
2156         'referenced_type' to 'property_type' and update comments.
2157         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2158         default property type, store in property baton, update to take
2159         accound of renamed field.
2160         (read_func_scope): Update call to attr_to_dynamic_prop.
2161         (read_array_type): Likewise.
2162         (dwarf2_per_cu_addr_sized_int_type): New function.
2163         (read_subrange_index_type): Move type finding code to
2164         dwarf2_per_cu_addr_sized_int_type.
2165         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2166         (dwarf2_per_cu_addr_type): New function.
2167         (set_die_type): Update calls to attr_to_dynamic_prop.
2168
2169 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2170
2171         * dwarf2read.c (read_subrange_index_type): New function.
2172         (read_subrange_type): Move code into new function and call it.
2173         * gdbtypes.c (create_range_type): Add some asserts.
2174
2175 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2176
2177         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2178         update return statements.
2179         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2180         declaration, and update comment to match.
2181         * gdbtypes.c (resolve_dynamic_array): Update call to
2182         dwarf2_evaluate_property to match new return type.
2183
2184 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2185
2186         * valarith.c (value_subscripted_rvalue): Change lowerbound
2187         parameter type from int to LONGEST.
2188         * value.h (value_subscripted_rvalue): Likewise in declaration.
2189
2190 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * cli/cli-utils.c (info_print_command_completer): New function.
2193         * cli/cli-utils.h: Add 'completer.h' include, and forward
2194         declaration for 'struct cmd_list_element'.
2195         (info_print_command_completer): Declare.
2196         * stack.c (_initialize_stack): Add completer for 'info locals' and
2197         'info args'.
2198         * symtab.c (_initialize_symtab): Add completer for 'info
2199         variables' and 'info functions'.
2200         * NEWS: Mention completion for additional info commands.
2201
2202 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * cli/cli-utils.c (extract_info_print_args): Delete.
2205         (extract_arg_maybe_quoted): Delete.
2206         (info_print_options_defs): New variable.
2207         (make_info_print_options_def_group): New function.
2208         (extract_info_print_options): Define new function.
2209         * cli/cli-utils.h (extract_info_print_args): Delete.
2210         (struct info_print_options): New structure.
2211         (extract_info_print_options): Declare new function.
2212         * stack.c (info_locals_command): Update to use new
2213         extract_info_print_options, also add a header comment.
2214         (info_args_command): Likewise.
2215         * symtab.c (info_variables_command): Likewise.
2216         (info_functions_command): Likewise.
2217
2218 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2219
2220         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2221         to extract string arguments.
2222         * common/common-utils.c (extract_string_maybe_quoted): New function.
2223         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2224
2225 2019-07-11  Tom Tromey  <tromey@adacore.com>
2226
2227         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2228         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2229         * top.h (gdbinit): Don't declare.
2230         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2231         into...
2232         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2233         * top.c (gdb_init): Don't call init_cli_cmds.
2234         (gdbinit): Remove.
2235         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2236
2237 2019-07-11  Tom Tromey  <tromey@adacore.com>
2238
2239         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2240         after it has been moved.
2241
2242 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2243
2244         * valops.c (value_must_coerce_to_target): Change return type to
2245         bool.
2246         * value.h (value_must_coerce_to_target): Likewise.
2247
2248 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2249
2250         * breakpoint.c (is_hardware_watchpoint): Remove
2251         forward-declaration.
2252         (is_masked_watchpoint): Change return type to bool.
2253         (is_tracepoint): Likewise.
2254         (is_breakpoint): Likewise.
2255         (is_hardware_watchpoint): Likewise.
2256         (is_watchpoint): Likewise.
2257         (is_no_memory_software_watchpoint): Likewise.
2258         (is_catchpoint): Likewise.
2259         (breakpoint_1): Make FILTER parameter's return type bool.
2260         is_masked_watchpoint): Change return type to bool.
2261         (save_breakpoints): Make FILTER parameter's return type bool.
2262         * breakpoint.h (is_breakpoint): Change return type to bool.
2263         (is_watchpoint): Likewise.
2264         (is_catchpoint): Likewise.
2265         (is_tracepoint): Likewise.
2266
2267 2019-07-10  Tom Tromey  <tom@tromey.com>
2268
2269         * defs.h: Don't include gdbarch.h.
2270         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2271         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2272         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2273         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2274         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2275         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2276         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2277         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2278         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2279         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2280         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2281         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2282         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2283         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2284         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2285         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2286         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2287         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2288         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2289         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2290         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2291         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2292         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2293         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2294         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2295         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2296         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2297
2298 2019-07-10  Tom Tromey  <tromey@adacore.com>
2299
2300         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2301         * breakpoint.c (init_ada_exception_breakpoint): Register as
2302         bp_catchpoint.
2303         (print_one_breakpoint_location, print_one_breakpoint): Use
2304         is_ada_exception_catchpoint.
2305         * ada-lang.c (class ada_catchpoint_location): Pass
2306         bp_loc_software_breakpoint to bp_location constructor.
2307         (is_ada_exception_catchpoint): New function.
2308
2309 2019-07-10  Tom Tromey  <tromey@adacore.com>
2310
2311         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2312         VEC.
2313         (struct arm_exidx_entry): New method operator<.
2314         (struct arm_exidx_data) <section_maps>: Change type.
2315         (arm_exidx_data_free): Remove.
2316         (arm_exidx_data_key): Change type.  Move lower.
2317         (arm_exidx_new_objfile): Update.
2318         (arm_compare_exidx_entries): Remove.
2319         (arm_find_exidx_entry, _initialize_arm_tdep)
2320
2321 2019-07-10  Tom Tromey  <tromey@adacore.com>
2322
2323         * solib-spu.c (ocl_program_data_key): Change type.
2324         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2325         Update.
2326
2327 2019-07-10  Tom Tromey  <tromey@adacore.com>
2328
2329         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2330         (struct solib_aix_inferior_data) <library_list>: Change type.
2331         (solib_aix_inferior_data_handle): Change type.
2332         (get_solib_aix_inferior_data): Update.
2333         (solib_aix_free_library_list): Remove.
2334         (library_list_start_library): Update.
2335         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2336         return type.
2337         (solib_aix_get_library_list)
2338         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2339         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2340
2341 2019-07-10  Tom Tromey  <tromey@adacore.com>
2342
2343         * solib-dsbt.c (struct dsbt_info): Add initializers.
2344         (solib_dsbt_pspace_data): Change type.
2345         (dsbt_pspace_data_cleanup): Remove.
2346         (get_dsbt_info, _initialize_dsbt_solib): Update.
2347
2348 2019-07-10  Tom Tromey  <tromey@adacore.com>
2349
2350         * spu-tdep.c (spu_overlay_data): Change type.
2351         (spu_get_overlay_table, spu_overlay_new_objfile)
2352         (_initialize_spu_tdep): Update.
2353
2354 2019-07-10  Tom Tromey  <tromey@adacore.com>
2355
2356         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2357         destructor.
2358         (dbx_objfile_data_key): Change type and declare later.
2359         (DBX_SYMFILE_INFO): Rewrite.
2360         * dbxread.c (dbx_objfile_data_key): Change type.
2361         (dbx_symfile_init): Update.
2362         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2363         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2364         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2365
2366 2019-07-10  Tom Tromey  <tromey@adacore.com>
2367
2368         * jit.c (jit_program_space_key): Change type.  Move lower.
2369         (get_jit_program_space_data): Update.
2370         (jit_program_space_data_cleanup): Remove.
2371         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2372         Update.
2373         (struct jit_program_space_data): Add initializers.
2374
2375 2019-07-10  Tom Tromey  <tromey@adacore.com>
2376
2377         * solib-darwin.c (struct darwin_info): Add initializers.
2378         (solib_darwin_pspace_data): Change type.
2379         (darwin_pspace_data_cleanup): Remove.
2380         (get_darwin_info, _initialize_darwin_solib): Update.
2381
2382 2019-07-10  Tom Tromey  <tromey@adacore.com>
2383
2384         * remote-sim.c (struct sim_inferior_data): Add initializers,
2385         constructor, and destructor.
2386         (sim_inferior_data_key): Change type.  Move lower.
2387         (check_for_duplicate_sim_descriptor): Update.
2388         (get_sim_inferior_data): Use new.  Update.
2389         (~sim_inferior_data_cleanup): Rename from
2390         sim_inferior_data_cleanup.  Simplify.
2391         (gdbsim_close_inferior, simulator_command)
2392         (sim_command_completer, _initialize_remote_sim): Update.
2393         (next_pid, INITIAL_PID): Move earlier.
2394
2395 2019-07-10  Tom Tromey  <tromey@adacore.com>
2396
2397         * python/python-internal.h (create_thread_object): Return
2398         gdbpy_ref.
2399         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2400         * python/py-inferior.c (struct threadlist_entry): Add
2401         constructor.
2402         <thread_obj>: Now a gdbpy_ref.
2403         (thread_to_thread_object): Update.
2404         (add_thread_object): Use new.
2405         (delete_thread_object): Use delete.
2406         (infpy_threads): Update.
2407         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2408         GIL.
2409
2410 2019-07-10  Tom Tromey  <tromey@adacore.com>
2411
2412         * valops.c (value_cast): Specialize error message for Ada.
2413
2414 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2415
2416         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2417
2418 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2419
2420         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2421         bpstat_should_step): Return bool, adjust comments.
2422         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2423         bpstat_should_step): Likewise.
2424
2425 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2426
2427         * features/Makefile: Use feature target descriptions for Arm.
2428         * features/arm/arm-core.c: Generate new file.
2429         * features/arm/arm-fpa.c: Likewise.
2430         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2431         * features/arm/arm-m-profile.c: Likewise.
2432         * features/arm/arm-vfpv2.c: Likewise.
2433         * features/arm/arm-vfpv3.c: Likewise.
2434         * features/arm/xscale-iwmmxt.c: Likewise.
2435         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2436
2437 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2438
2439         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2440         ptrace earlier.
2441
2442 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2443
2444         * features/aarch64-pauth.c: Regenerate.
2445
2446 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2447
2448         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2449         bool.
2450         (bpstat_what): Use false instead of 0.
2451
2452 2019-07-09  Pedro Alves  <palves@redhat.com>
2453
2454         * break-catch-throw.c (is_exception_catchpoint): New.
2455         * breakpoint.c (print_one_breakpoint_location): New parameter
2456         'raw_loc'.  Handle it.  Use
2457         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2458         looking at the breakpoint's type.
2459         (print_one_breakpoint): If handling "maint info breakpoints", also
2460         print locations of exception catchpoints.
2461         * breakpoint.h (is_exception_catchpoint): Declare.
2462
2463 2019-07-09  Pedro Alves  <palves@redhat.com>
2464
2465         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2466         "addr" field.
2467         (allocate_location_exception_catchpoint): New.
2468         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2469         (initialize_throw_catchpoint_ops): Install
2470         allocate_location_exception_catchpoint as allocate_location
2471         method.
2472         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2473         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2474         bp_loc_other.
2475         (breakpoint_address_is_meaningful): Delete.
2476         (bl_address_is_meaningful): New.
2477         (breakpoint_locations_match): Adjust comment.
2478         (bp_location_from_bp_type): New, factored out of...
2479         (bp_location::bp_location(breakpoint *)): ... this.
2480         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2481         factored out of...
2482         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2483         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2484         breakpoint_address_is_meaningful.
2485         (bp_locations_compare): Adjust comment.
2486         (update_global_location_list): Use bl_address_is_meaningful
2487         instead of breakpoint_address_is_meaningful.
2488         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2489         explicit.
2490         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2491         * python/py-breakpoint.c (bppy_get_location): No longer check
2492         whether location is null.
2493
2494 2019-07-09  Pedro Alves  <palves@redhat.com>
2495
2496         PR c++/15468
2497         * breakpoint.c (print_one_breakpoint_location): Remove
2498         single-location assert.
2499
2500 2019-07-09  Tom Tromey  <tom@tromey.com>
2501
2502         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2503         * configure: Rebuild.
2504         * configure.ac: Change common to gdbsupport.
2505         * gdbsupport: Rename from common.
2506         * acinclude.m4: Change common to gdbsupport.
2507         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2508         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2509         gdbsupport.
2510         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2511         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2512         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2513         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2514         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2515         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2516         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2517         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2518         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2519         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2520         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2521         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2522         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2523         coff-pe-read.c, command.h, compile/compile-c-support.c,
2524         compile/compile-c.h, compile/compile-cplus-symbols.c,
2525         compile/compile-cplus-types.c, compile/compile-cplus.h,
2526         compile/compile-loc2c.c, compile/compile.c, completer.c,
2527         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2528         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2529         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2530         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2531         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2532         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2533         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2534         features/aarch64-core.c, features/aarch64-fpu.c,
2535         features/aarch64-pauth.c, features/aarch64-sve.c,
2536         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2537         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2538         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2539         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2540         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2541         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2542         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2543         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2544         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2545         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2546         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2547         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2548         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2549         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2550         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2551         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2552         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2553         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2554         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2555         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2556         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2557         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2558         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2559         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2560         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2561         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2562         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2563         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2564         minsyms.c, mips-linux-tdep.c, namespace.h,
2565         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2566         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2567         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2568         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2569         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2570         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2571         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2572         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2573         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2574         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2575         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2576         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2577         procfs.c, producer.c, progspace.h, psymtab.h,
2578         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2579         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2580         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2581         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2582         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2583         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2584         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2585         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2586         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2587         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2588         target-memory.c, target.c, target.h, target/waitstatus.c,
2589         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2590         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2591         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2592         unittests/array-view-selftests.c,
2593         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2594         unittests/common-utils-selftests.c,
2595         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2596         unittests/format_pieces-selftests.c,
2597         unittests/function-view-selftests.c,
2598         unittests/lookup_name_info-selftests.c,
2599         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2600         unittests/mkdir-recursive-selftests.c,
2601         unittests/observable-selftests.c,
2602         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2603         unittests/parse-connection-spec-selftests.c,
2604         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2605         unittests/scoped_fd-selftests.c,
2606         unittests/scoped_mmap-selftests.c,
2607         unittests/scoped_restore-selftests.c,
2608         unittests/string_view-selftests.c, unittests/style-selftests.c,
2609         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2610         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2611         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2612         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2613         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2614         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2615
2616 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2619         bool value.
2620         (decode_digits_ordinary): Set explicit_line field in sal.
2621         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2622         symtab_and_line that was set on an explicit line number in
2623         assembler code.  Do always update the recorded symtab and line if
2624         we do skip the prologue.
2625
2626 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2627
2628         * breakpoint.c (set_breakpoint_location_function): Remove
2629         explicit_loc parameter.
2630         (momentary_breakpoint_from_master): Update call to
2631         set_breakpoint_location_function.
2632         (add_location_to_breakpoint): Likewise.
2633
2634 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2635
2636         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2637         required features based on default bfd type when no specific bfd
2638         is present.
2639
2640 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2641
2642         * NEWS: Mention that GDB printf and eval commands can now print
2643         C-style and Ada-style convenience var strings without
2644         calling the inferior.
2645         * printcmd.c (printf_c_string): Locally print GDB internal var
2646         instead of transiting via the inferior.
2647         (printf_wide_c_string): Likewise.
2648
2649 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2650
2651         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2652
2653 2019-07-04  Tom Tromey  <tom@tromey.com>
2654
2655         PR tui/24724:
2656         * tui/tui-winsource.c (tui_clear_source_content): Update.
2657         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2658         (tui_update_breakpoint_info): Update.
2659         (tui_set_exec_info_content): Update.
2660         * tui/tui-source.c (tui_set_source_content_nil): Update.
2661         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2662         has_break.
2663         * tui/tui-data.h (enum tui_bp_flag): New.
2664         (tui_bp_flags): New enum flags type.
2665         (struct tui_source_element) <break_mode>: Change type.  Rename
2666         from has_break.
2667         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2668         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2669         constants.
2670         * tui/tui-winsource.h: Fix comment.
2671
2672 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2673
2674         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2675         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2676         (store_fpregs_to_thread)
2677         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2678         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2679         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2680         (IWMMXT_REGS_SIZE): Add define.
2681         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2682         (fetch_vfp_regs, store_vfp_regs)
2683         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2684         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2685
2686 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2687
2688         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2689         defines.
2690         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2691         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2692         (ARM_INT_REGISTER_SIZE): ...to this.
2693         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2694         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2695         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2696         (arm_linux_collect_gregset, supply_nwfpe_register)
2697         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2698         defines.
2699         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2700         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2701         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2702         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2703         (arm_return_in_memory, arm_store_return_value)
2704         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2705         (arm_record_ld_st_multiple): Likewise.
2706         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2707         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2708
2709 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2710
2711         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2712         AARCH64_DISPLACED_MODIFIED_INSNS.
2713         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2714         (aarch64_displaced_step_copy_insn): Likewise.
2715         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2716         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2717         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2718         ARM_DISPLACED_MODIFIED_INSNS.
2719         * arm-tdep.c (arm_gdbarch_init): Likewise.
2720         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2721         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2722         (struct arm_displaced_step_closure): Use
2723         ARM_DISPLACED_MODIFIED_INSNS.
2724
2725 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2726
2727         * features/Makefile: Remove unused xml files.
2728         * features/aarch64.xml: Remove.
2729         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2730         * features/i386/amd64-avx-avx512.xml: Remove.
2731         * features/i386/amd64-avx-linux.xml: Remove.
2732         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2733         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2734         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2735         * features/i386/amd64-avx-mpx.xml: Remove.
2736         * features/i386/amd64-avx.xml: Remove.
2737         * features/i386/amd64-linux.xml: Remove.
2738         * features/i386/amd64-mpx-linux.xml: Remove.
2739         * features/i386/amd64-mpx.xml: Remove.
2740         * features/i386/amd64.xml: Remove.
2741         * features/i386/i386-avx-avx512-linux.xml: Remove.
2742         * features/i386/i386-avx-avx512.xml: Remove.
2743         * features/i386/i386-avx-linux.xml: Remove.
2744         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2745         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2746         * features/i386/i386-avx-mpx-linux.xml: Remove.
2747         * features/i386/i386-avx-mpx.xml: Remove.
2748         * features/i386/i386-avx.xml: Remove.
2749         * features/i386/i386-linux.xml: Remove.
2750         * features/i386/i386-mmx-linux.xml: Remove.
2751         * features/i386/i386-mmx.xml: Remove.
2752         * features/i386/i386-mpx-linux.xml: Remove.
2753         * features/i386/i386-mpx.xml: Remove.
2754         * features/i386/i386.xml: Remove.
2755         * features/i386/x32-avx-avx512-linux.xml: Remove.
2756         * features/i386/x32-avx-linux.xml: Remove.
2757         * features/i386/x32-linux.xml: Remove.
2758
2759 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2760
2761         * regformats/aarch64.dat: Remove.
2762         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2763         * regformats/i386/amd64-avx-linux.dat: Remove.
2764         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2765         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2766         * regformats/i386/amd64-linux.dat: Remove.
2767         * regformats/i386/amd64-mpx-linux.dat: Remove.
2768         * regformats/i386/amd64.dat: Remove.
2769         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2770         * regformats/i386/i386-avx-linux.dat: Remove.
2771         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2772         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2773         * regformats/i386/i386-linux.dat: Remove.
2774         * regformats/i386/i386-mmx-linux.dat: Remove.
2775         * regformats/i386/i386-mpx-linux.dat: Remove.
2776         * regformats/i386/i386.dat: Remove.
2777         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2778         * regformats/i386/x32-avx-linux.dat: Remove.
2779         * regformats/i386/x32-linux.dat: Remove.
2780
2781 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2782
2783         * aarch64-tdep.c: Remove xml self tests.
2784         * amd64-linux-tdep.c: Likewise.
2785         * amd64-tdep.c: Likewise.
2786         * i386-linux-tdep.c: Likewise.
2787         * i386-tdep.c: Likewise.
2788
2789 2019-07-03  Pedro Alves  <palves@redhat.com>
2790
2791         PR cli/24732
2792         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2793         (pipe_cmd_option_defs): New.
2794         (make_pipe_cmd_options_def_group): New.
2795         (pipe_command): Use gdb::option::process_options.
2796         (pipe_command_completer): New function.
2797         (_initialize_cli_cmds): Install completer for "pipe" command.
2798
2799 2019-07-03  Pedro Alves  <palves@redhat.com>
2800
2801         * cli/cli-option.c (union option_value) <string>: New field.
2802         (struct option_def_and_value): Add ctor, move ctor, dtor and
2803         use DISABLE_COPY_AND_ASSIGN.
2804         (option_def_and_value::clear_value): New.
2805         (parse_option, save_option_value_in_ctx, get_val_type_str)
2806         (add_setshow_cmds_for_options): Handle var_string.
2807         * cli-option.h (union option_def::var_address) <string>: New
2808         field.
2809         (struct string_option_def): New.
2810         * maint-test-options.c (struct test_options_opts): Add default
2811         ctor and use DISABLE_COPY_AND_ASSIGN.
2812         <string_opt>: New field.
2813         (test_options_opts::~test_options_opts): New.
2814         (test_options_opts::dump): Also dump "-string".
2815         (test_options_option_defs): Install "string.
2816
2817 2019-07-03  Pedro Alves  <palves@redhat.com>
2818
2819         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2820         option_value with a null enumeration.
2821         (complete_options): Save the option values in the context.
2822         (save_option_value_in_ctx): New, factored out from ...
2823         (process_options): ... here.
2824         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2825         of the function.
2826         * maint-test-options.c (test_options_opts::dump): New, factored
2827         out from ...
2828         (maintenance_test_options_command_mode): ... here.
2829         (maintenance_test_options_command_completion_result): Delete.
2830         (maintenance_test_options_command_completion_text): Update
2831         comment.
2832         (maintenance_show_test_options_completion_result): Change
2833         prototype.  Just print
2834         maintenance_test_options_command_completion_text.
2835         (save_completion_result): New.
2836         (maintenance_test_options_completer_mode): Pass options context to
2837         complete_options, and then save a dump.
2838         (_initialize_maint_test_options): Use add_cmd to install "maint
2839         show test-options-completion-result".
2840
2841 2019-07-03  Pedro Alves  <palves@redhat.com>
2842
2843         * NEWS (New commands): Mention "with" and "maint with".
2844         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2845         (with_command, with_command_completer): New.
2846         (pipe_command): Adjust to new repeat_previous
2847         interface.
2848         (_initialize_cli_cmds): Install the "with" command and its "w"
2849         alias.
2850         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2851         declarations.
2852         * cli/cli-setshow.c (parse_cli_var_uinteger)
2853         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2854         argument strings for all var_types.
2855         (get_setshow_command_value_string): New, factored out from ...
2856         (do_show_command): ... this.
2857         * cli/cli-setshow.h: Include <string>.
2858         (get_setshow_command_value_string): Declare.
2859         * command.h (repeat_previous): Now returns const char *.  Adjust
2860         comment.
2861         * maint.c: Include "cli/cli-cmds.h".
2862         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2863         (_initialize_maint_cmds): Register the "maintenance with" command.
2864         * top.c (repeat_previous): Move bits from pipe_command here:
2865         Return the saved command line, if any; error out if there's no
2866         command to relaunch.
2867
2868 2019-07-03  Pedro Alves  <palves@redhat.com>
2869
2870         * NEWS (New commands): Mention "maint set/show test-settings"
2871         instead of "maint test-settings".
2872         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2873         (maintenance_test_settings_set_list): Rename to ...
2874         (maintenance_set_test_settings_list): ... this.
2875         (maintenance_test_settings_show_list): Rename to  ...
2876         (maintenance_show_test_settings_list): ... this.
2877         (maintenance_test_settings_cmd): Delete.
2878         (maintenance_test_settings_set_cmd): ...
2879         (maintenance_set_test_settings_cmd): ... this.
2880         (maintenance_test_settings_show_cmd): ...
2881         (maintenance_show_test_settings_cmd): ... this.
2882         (maintenance_test_settings_show_value_cmd):
2883         (maintenance_show_test_settings_value_cmd): ... this.
2884         (_initialize_maint_test_settings): No longer install the "maint
2885         test-settings" prefix command.  Rename "maint test-settings set"
2886         to "maint set test-settings", and "maint test-settings show" to
2887         "maint show test-settings".  Adjust all subcommands.
2888
2889 2019-07-03  Pedro Alves  <palves@redhat.com>
2890
2891         * maint-test-settings.c: Fix file's intro comment.  Replace all
2892         references to "test-options" with references to "test-settings",
2893         in comments.
2894
2895 2019-07-03  Pedro Alves  <palves@redhat.com>
2896
2897         * maint-test-settings.c (maintenance_test_settings_xxx)
2898         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2899         New.
2900         (maintenance_test_settings_enums): Use them.
2901         (maintenance_test_settings_enum): Default to
2902         maintenance_test_settings_xxx.
2903         (_initialize_maint_test_settings): Initialize
2904         MAINTENANCE_TEST_SETTINGS_FILENAME.
2905
2906 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2907
2908         * breakpoint.h (remove_breakpoints_inf): Change return type to
2909         void, move function documentation here.
2910         * breakpoint.c (remove_breakpoints_inf): Change return type to
2911         void, move function documentation to header.
2912
2913 2019-07-02  Pedro Alves  <palves@redhat.com>
2914
2915         * NEWS (Completion improvements): Mention "info threads".
2916         * thread.c (struct info_threads_opts, info_threads_option_defs)
2917         (make_info_threads_options_def_group): New.
2918         (info_threads_command): Use gdb::option::process_options.
2919         (info_threads_command_completer): New.
2920         (_initialize_thread): Use gdb::option::build_help to build the
2921         help text for "info threads".
2922
2923 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2924
2925         * defs.h (generic_load): Move from here...
2926         * symfile.h (generic_load): ... to here.  Rename name parameter
2927         to args.
2928         * symfile.c (generic_load): Add comment.
2929
2930 2019-07-01  Tom Tromey  <tromey@adacore.com>
2931
2932         * dwarf2read.c
2933         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2934         declaration of without_params.  Fix formatting.
2935
2936 2019-07-01  Tom Tromey  <tromey@adacore.com>
2937
2938         * ada-exp.y (find_primitive_type): Update.
2939         * ada-lang.h (ada_lookup_symbol): Update.
2940         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2941         parameter.
2942         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2943
2944 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2945
2946         PR breakpoints/24541
2947         * gdbarch.c: Regenerate.
2948         * gdbarch.h: Regenerate.
2949         * gdbarch.sh: Add 'stap_adjust_register'.
2950         * i386-tdep.c: Include '<unordered_set>'.
2951         (i386_stap_adjust_register): New function.
2952         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2953         * stap-probe.c (stap_parse_register_operand): Call
2954         'gdbarch_stap_adjust_register'.
2955
2956 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2957
2958         PR python/24742
2959         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2960         * python/python.c (do_start_initialization): Use 'xmalloc'
2961         instead of 'PyMem_Malloc'.
2962
2963 2019-06-28  Tom Tromey  <tromey@adacore.com>
2964
2965         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2966         for Ada.
2967
2968 2019-06-27  Tom Tromey  <tromey@adacore.com>
2969
2970         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2971         objfile_key.
2972         (arm_find_mapping_symbol, arm_record_special_symbol)
2973         (_initialize_arm_tdep): Update.
2974         (arm_objfile_data_free): Remove.
2975
2976 2019-06-27  Tom Tromey  <tromey@adacore.com>
2977
2978         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2979         to cp_print_static_field.
2980
2981 2019-06-26  Tom Tromey  <tromey@adacore.com>
2982
2983         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2984         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2985         declare.
2986
2987 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2988
2989         * features/aarch64-core.c (create_feature_aarch64_core):
2990         Regenerate.
2991         * features/aarch64-core.xml: Add cpsr flags.
2992
2993 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2994
2995         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2996         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2997
2998 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2999
3000         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3001         field.
3002         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3003         use.
3004         (arm_record_special_symbol): Don't insert new symbol in sorted
3005         position, push it at the end.
3006
3007 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3008
3009         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3010         (arm_mapping_symbol_s): Remove.
3011         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3012         (arm_mapping_symbol_vec): New typedef.
3013         (struct arm_per_objfile): Add constructor.
3014         <section_maps>: Change type to
3015         std::unique_ptr<arm_mapping_symbol_vec[]>.
3016         (arm_compare_mapping_symbols): Remove.
3017         (arm_find_mapping_symbol): Adjust to section_maps type change.
3018         (arm_objfile_data_free): Call delete on arm_per_objfile.
3019         (arm_record_special_symbol): Adjust to section_maps type change.
3020         Allocate arm_per_objfile with new.
3021
3022 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3023
3024         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3025         with the command prefix.
3026
3027 2019-06-25  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3030         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3031
3032 2019-06-25  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3035         type.
3036         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3037         protected.
3038
3039 2019-06-25  Tom Tromey  <tom@tromey.com>
3040
3041         * tui/tui-winsource.c
3042         (tui_source_window_base::set_is_exec_point_at): Add check against
3043         LOA_ADDRESS.
3044
3045 2019-06-25  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-source.c (tui_set_source_content): Don't check before
3048         xfree.
3049         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-winsource.h (tui_update_source_window_as_is)
3054         (tui_alloc_source_buffer, tui_line_is_displayed)
3055         (tui_addr_is_displayed): Change type of win_info.
3056         * tui/tui-winsource.c (tui_update_source_window_as_is)
3057         (tui_clear_source_content, tui_show_source_line)
3058         (tui_show_source_content, tui_source_window_base::refill)
3059         (tui_source_window_base::set_is_exec_point_at)
3060         (tui_source_window_base::set_is_exec_point_at)
3061         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3062         (tui_alloc_source_buffer, tui_line_is_displayed)
3063         (tui_addr_is_displayed): Change type of win_info.  Update.
3064         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3065         (tui_source_window_base::do_make_visible_with_new_height):
3066         Update.
3067         * tui/tui-source.c (tui_set_source_content)
3068         (tui_set_source_content_nil)
3069         (tui_source_window::do_scroll_vertical): Update.
3070         * tui/tui-layout.c (show_layout): Update.
3071         * tui/tui-disasm.c (tui_set_disassem_content)
3072         (tui_disasm_window::do_scroll_vertical): Update.
3073         * tui/tui-data.h (tui_win_content): Remove.
3074         (struct tui_gen_win_info) <content, content_size>: Remove.
3075         (struct tui_source_element): Add initializers and destructor.
3076         (union tui_which_element, struct tui_win_element): Remove.
3077         (struct tui_source_window_base) <content>: New field.
3078         (struct tui_data_window): Remove destructor.
3079         (tui_alloc_content, tui_free_win_content)
3080         (tui_free_all_source_wins_content): Don't declare.
3081         * tui/tui-data.c (tui_initialize_static_data): Update.
3082         (init_content_element, tui_alloc_content): Remove.
3083         (~tui_gen_win_info): Update.
3084         (~tui_data_window, tui_free_all_source_wins_content)
3085         (tui_free_win_content, free_content, free_content_elements):
3086         Remove.
3087
3088 2019-06-25  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-winsource.h (tui_clear_source_content)
3091         (tui_erase_source_content, tui_show_source_content): Change type
3092         of win_info.
3093         * tui/tui-winsource.c (tui_clear_source_content)
3094         (tui_erase_source_content, tui_show_source_content): Change type
3095         of win_info.
3096         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3097         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3098         win_info.
3099         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3100         win_info.
3101         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3102
3103 2019-06-25  Tom Tromey  <tom@tromey.com>
3104
3105         * tui/tui-winsource.c (tui_clear_source_content)
3106         (tui_source_window_base::set_is_exec_point_at): Update.
3107         * tui/tui-source.c (tui_set_source_content_nil): Update.
3108         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3109         a bool.
3110         * tui/tui-data.c (init_content_element): Update.
3111
3112 2019-06-25  Tom Tromey  <tom@tromey.com>
3113
3114         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3115         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3116         * tui/tui-layout.c (init_and_make_win): Update.
3117         * tui/tui.h (enum tui_win_type): Update.
3118         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3119         tui_win_is_auxillary.
3120         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3121         tui_win_is_auxillary.
3122
3123 2019-06-25  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3126         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3127         (tui_delete_data_content_windows, tui_display_all_data)
3128         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3129         Update.
3130         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3131         * tui/tui-regs.c (tui_last_regs_line_no)
3132         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3133         (tui_show_registers): Update.
3134         (tui_show_register_group): Return void.  Update.
3135         (tui_display_registers_from, tui_display_reg_element_at_line)
3136         (tui_display_registers_from_line, tui_check_register_values):
3137         Update.
3138         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3139         member.
3140         (struct tui_data_window) <regs_content>: Now a std::vector.
3141         <regs_content_count>: Remove.
3142         (tui_add_content_elements, tui_free_data_content): Don't declare.
3143         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3144         (init_content_element): Remove DATA_WIN case.  Add assert.
3145         (tui_add_content_elements): Remove.
3146         (tui_data_window): Update.
3147         (tui_free_data_content): Remove.
3148         (free_content_elements): Remove DATA_WIN case.
3149
3150 2019-06-25  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-data.c (tui_data_item_window): Update.
3153         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3154         * tui/tui-windata.c (tui_display_all_data)
3155         (tui_display_data_from_line): Update.
3156         (tui_check_data_values): Remove.
3157         * tui/tui-regs.c (tui_show_register_group)
3158         (tui_display_reg_element_at_line): Update.
3159         * tui/tui-hooks.c (tui_register_changed)
3160         (tui_refresh_frame_and_register_information): Call
3161         tui_check_register_values.
3162         * tui/tui-data.h (struct tui_data_window) <data_content,
3163         data_content_count, data_type>: Remove.
3164         (enum tui_data_type): Remove.
3165
3166         * tui/tui-data.c (tui_data_window::clear_detail)
3167         (~tui_data_window): Update.
3168
3169 2019-06-25  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3172         declare.
3173         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3174         Rename from tui_first_data_item_displayed.  Update.
3175         (tui_data_window::refresh_all)
3176         (tui_data_window::do_scroll_vertical): Update.
3177         * tui/tui-data.h (struct tui_data_window)
3178         <first_data_item_displayed>: Declare new method.
3179
3180 2019-06-25  Tom Tromey  <tom@tromey.com>
3181
3182         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3183         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3184         contents...
3185         (tui_initialize_static_data): ...here.
3186
3187 2019-06-25  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3190         (tui_display_registers_from, tui_check_register_values): Update.
3191         (tui_display_register): Remove win_info parameter; update.
3192         (tui_get_register): Change type of parameters.
3193         * tui/tui-data.h (struct tui_data_element): Remove.
3194         (union tui_which_element) <data>: Remove.
3195         <data_window>: Change type.
3196         (struct tui_data_item_window): New.
3197         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3198         case.  Add assert.
3199         (~tui_data_item_window): New destructor.
3200         (free_content_elements): Remove DATA_ITEM_WIN case.
3201
3202 2019-06-25  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3205         Remove.
3206
3207 2019-06-25  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-data.h (struct tui_command_element): Remove.
3210         (union tui_which_element) <command>: Remove.
3211         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3212         assert.
3213         (free_content_elements): Remove CMD_WIN case.
3214
3215 2019-06-25  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-layout.c (tui_set_layout): Update.
3218         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3219         * tui/tui-data.c (layout_def): Update.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3224         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3225         (tui_source_window_base::set_new_height): Update.
3226         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3227         Update.
3228         (tui_set_locator_fullname, tui_set_locator_info)
3229         (tui_show_frame_info): Update.
3230         * tui/tui-source.c (tui_set_source_content)
3231         (tui_source_is_displayed): Update.
3232         * tui/tui-layout.c (show_source_disasm_command, show_data)
3233         (show_source_or_disasm_and_command): Update.
3234         * tui/tui-disasm.c (tui_set_disassem_content)
3235         (tui_get_begin_asm_address): Update.
3236         * tui/tui-data.h (struct tui_locator_element): Remove.
3237         (union tui_which_element) <locator>: Remove.
3238         (struct tui_locator_window): New.
3239         (tui_locator_win_info_ptr): Change return type.
3240         * tui/tui-data.c (_locator): Change type.
3241         (tui_locator_win_info_ptr): Change return type.
3242         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3243         (tui_alloc_content): Add assert.
3244
3245 2019-06-25  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-winsource.c
3248         (tui_exec_info_window::maybe_allocate_content): New method.
3249         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3250         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3251         (make_source_or_disasm_window): Add cast.
3252         * tui/tui-data.h (union tui_which_element) <simple_string>:
3253         Remove.
3254         (struct tui_source_info): New.
3255         (struct tui_source_window_base) <execution_info>: Change type.
3256         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3257         case, and add assert.
3258         (tui_alloc_content): Add assert.
3259
3260 2019-06-25  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3263         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3264         * tui/tui-data.c (tui_alloc_win_info): Remove.
3265
3266 2019-06-25  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3269         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3270         can_highlight.
3271
3272 2019-06-25  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3275         make_visible_with_new_height method.
3276         (tui_win_info::make_visible_with_new_height): New method.
3277         (tui_source_window_base::do_make_visible_with_new_height)
3278         (tui_data_window::do_make_visible_with_new_height)
3279         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3280         (make_visible_with_new_height): Remove.
3281         (tui_resize_all, tui_adjust_win_heights): Use
3282         make_visible_with_new_height method.
3283         * tui/tui-data.h (struct tui_win_info)
3284         <do_make_visible_with_new_height, make_visible_with_new_height>:
3285         New methods.
3286         (struct tui_source_window_base, struct tui_data_window)
3287         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3288         methods.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3293         method.
3294         (update_tab_width): Call update_tab_width method.
3295         * tui/tui-data.h (struct tui_win_info)
3296         (struct tui_source_window_base) <update_tab_width>: New methods.
3297
3298 2019-06-25  Tom Tromey  <tom@tromey.com>
3299
3300         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3301         parameter.
3302         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3303         parameter.
3304         (tui_gen_win_info::make_visible): Update.
3305         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3306         parameter.
3307         * tui/tui-data.h (enum tui_box): New enum.
3308         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3309
3310 2019-06-25  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3313         init_and_make_win for EXEC_INFO_WIN.
3314         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3315         longer inline.
3316         (struct tui_win_info) <~tui_win_info>: Inline.
3317         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3318         Don't declare.
3319         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3320         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3321         Remove.
3322         (tui_initialize_static_data): Update.
3323         (~tui_gen_win_info): Handle more cleanup here.
3324         (~tui_source_window_base): Delete "execution_info".
3325         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-layout.c (make_command_window): Don't set
3330         can_highlight.
3331         (show_source_disasm_command): Call the reset method.
3332         (show_data): Don't set can_highlight.  Call the reset method.
3333         (tui_gen_win_info::reset): Rename from init_gen_win_info
3334         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3335         (show_source_or_disasm_and_command): Call the reset method.
3336         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3337         (struct tui_cmd_window): Set can_highlight.
3338
3339 2019-06-25  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3342         from make_visible.
3343         (tui_make_visible, tui_make_invisible): Rewrite.
3344         (tui_win_info::make_visible): Remove.
3345         (tui_source_window_base::make_visible): Update.
3346         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3347         method.  Moved from...
3348         (struct tui_win_info) <make_visible>: ...here.
3349
3350 2019-06-25  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-winsource.c
3353         (tui_source_window_base::do_scroll_horizontal): Remove direction
3354         parameter.
3355         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3356         direction parameter.
3357         * tui/tui-win.c (tui_win_info::forward_scroll)
3358         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3359         (tui_win_info::right_scroll): Update.
3360         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3361         direction parameter.
3362         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3363         direction parameter.
3364         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3365         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3366         Remove direction parameter.
3367         (struct tui_source_window_base, struct tui_source_window)
3368         (struct tui_disasm_window, struct tui_data_window)
3369         (struct tui_cmd_window): Update.
3370
3371 2019-06-25  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-winsource.h (tui_set_exec_info_content)
3374         (tui_show_exec_info_content, tui_erase_exec_info_content)
3375         (tui_clear_exec_info_content, tui_update_exec_info): Change
3376         argument to tui_source_window_base.
3377         * tui/tui-winsource.c (tui_set_exec_info_content)
3378         (tui_show_exec_info_content, tui_erase_exec_info_content)
3379         (tui_clear_exec_info_content, tui_update_exec_info): Change
3380         argument to tui_source_window_base.
3381
3382 2019-06-25  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3385         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3386
3387 2019-06-25  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3390         check.
3391
3392 2019-06-25  Tom Tromey  <tom@tromey.com>
3393
3394         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3395         type to void.
3396         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3397         type to void.
3398         * tui/tui-source.c (tui_set_source_content): Update.
3399         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3400
3401 2019-06-25  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-win.c (window_name_completer, tui_set_focus)
3404         (tui_all_windows_info): Use name method.
3405         * tui/tui-data.h (struct tui_gen_win_info)
3406         (struct tui_source_window, struct tui_disasm_window)
3407         (struct tui_data_window, struct tui_cmd_window) <name>: New
3408         method.
3409         (tui_win_name): Don't declare.
3410         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3411         (tui_win_name): Remove.
3412
3413 2019-06-25  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui-winsource.h (tui_update_source_window)
3416         (tui_update_source_window_as_is): Change parameter type.
3417         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3418         to be a tui_source_window_base.
3419         (tui_update_source_window_as_is): Likewise.
3420         * tui/tui-win.c (make_visible_with_new_height): Update.
3421
3422 2019-06-25  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-winsource.c (tui_erase_source_content)
3425         (tui_show_source_content, tui_show_exec_info_content)
3426         (tui_erase_exec_info_content): Use refresh_window method.
3427         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3428         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3429         from tui_refresh_win.
3430         (tui_data_window::refresh_window): New method.
3431         (tui_win_info::refresh, tui_source_window_base::refresh)
3432         (tui_refresh_all): Use refresh_window method.
3433         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3434         method.
3435         * tui/tui-regs.c (tui_display_register): Call refresh_window
3436         method.
3437         * tui/tui-layout.c (show_source_disasm_command)
3438         (show_source_or_disasm_and_command): Call refresh_window method.
3439         * tui/tui-data.h (struct tui_gen_win_info)
3440         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3441         New method.
3442
3443 2019-06-25  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui.c (tui_rl_other_window, tui_enable)
3446         (tui_is_window_visible, tui_get_command_dimension): Update.
3447         * tui/tui-winsource.c (tui_update_source_window_as_is)
3448         (tui_clear_source_content, tui_erase_source_content)
3449         (tui_show_source_line, tui_source_window_base::refill)
3450         (tui_source_window_base::do_scroll_horizontal)
3451         (tui_source_window_base::set_is_exec_point_at)
3452         (tui_update_breakpoint_info, tui_set_exec_info_content)
3453         (tui_alloc_source_buffer, tui_line_is_displayed)
3454         (tui_addr_is_displayed): Update.
3455         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3456         (tui_check_and_display_highlight_if_needed)
3457         (tui_win_info::make_visible, tui_win_info::refresh)
3458         (tui_refresh_all): Update.
3459         * tui/tui-windata.c (tui_first_data_item_displayed)
3460         (tui_delete_data_content_windows, tui_erase_data_content)
3461         (tui_display_all_data, tui_data_window::refresh_all)
3462         (tui_check_data_values): Update.
3463         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3464         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3465         (tui_win_info::backward_scroll, tui_refresh_all_win)
3466         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3467         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3468         (tui_source_window_base::set_new_height)
3469         (tui_data_window::set_new_height)
3470         (make_invisible_and_set_new_height)
3471         (make_visible_with_new_height, new_height_ok)
3472         (parse_scrolling_args): Update.
3473         * tui/tui-stack.c (tui_show_frame_info): Update.
3474         * tui/tui-source.c (tui_set_source_content)
3475         (tui_set_source_content_nil, tui_source_is_displayed)
3476         (tui_source_window::do_scroll_vertical): Update.
3477         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3478         (tui_display_registers_from, tui_display_reg_element_at_line)
3479         (tui_check_register_values, tui_reg_command): Update.
3480         * tui/tui-layout.c (tui_default_win_height)
3481         (show_source_disasm_command, show_data, init_and_make_win)
3482         (show_source_or_disasm_and_command): Update.
3483         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3484         (tui_redisplay_readline, tui_mld_flush)
3485         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3486         (tui_getc): Update.
3487         * tui/tui-disasm.c (tui_set_disassem_content)
3488         (tui_disasm_window::do_scroll_vertical): Update.
3489         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3490         Now virtual.
3491         (struct tui_win_info): Derive from tui_gen_win_info.
3492         <~tui_win_info>: Mark as override.
3493         <generic>: Remove member.
3494         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3495         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3496         (~tui_data_window, ~tui_win_info)
3497         (tui_free_all_source_wins_content): Update.
3498         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3499
3500 2019-06-25  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-layout.c (init_and_make_win): Use new.
3503         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3504         destructor, initializers.
3505         (tui_alloc_generic_win_info): Don't declare.
3506         * tui/tui-data.c (_locator): Add argument to constructor.
3507         (source_win, disasm_win): New globals.
3508         (exec_info): Remove.
3509         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3510         Update.
3511         (tui_alloc_generic_win_info): Remove.
3512         (init_content_element): Use new.
3513         (tui_win_info::tui_win_info): Update.
3514         (free_content_elements) <case DATA_WIN>: Use delete.
3515
3516 2019-06-25  Tom Tromey  <tom@tromey.com>
3517
3518         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3519         * tui/tui-windata.c (tui_first_data_item_displayed)
3520         (tui_delete_data_content_windows): Update.
3521         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3522         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3523         (tui_display_registers_from, tui_check_register_values): Update.
3524         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3525         pointer.
3526         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3527         window.
3528         (tui_free_data_content): Update.
3529         (free_content_elements) <case DATA_WIN>: Free the window.
3530
3531 2019-06-25  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3534         Update.
3535         * tui/tui-layout.c (make_command_window)
3536         (show_source_disasm_command, show_data, init_and_make_win)
3537         (show_source_or_disasm_and_command): Update.
3538         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3539         method.
3540         <can_highight, is_highlighted>: Now bool.
3541         (tui_set_win_highlight): Don't declare.
3542         * tui/tui-data.c (tui_set_win_highlight): Remove.
3543
3544 2019-06-25  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-wingeneral.c (make_visible): Remove check of window
3547         type.
3548
3549 2019-06-25  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-win.c (tui_win_info::max_height)
3552         (tui_cmd_window::max_height): New methods.
3553         (new_height_ok): Call max_height.
3554         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3555         <max_height>: New method.
3556
3557 2019-06-25  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-win.c (tui_source_window_base::set_new_height)
3560         (tui_data_window::set_new_height): New methods.
3561         (make_invisible_and_set_new_height): Call set_new_height method.
3562         * tui/tui-data.h (struct tui_win_info)
3563         (struct tui_source_window_base, struct tui_data_window)
3564         <set_new_height>: New method.
3565
3566 2019-06-25  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3569         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3570         tui_refresh_data_win.
3571         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3572         method.
3573         (tui_refresh_all_win): Call the refresh_all method.
3574         (tui_set_focus): Likewise.
3575         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3576         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3577         Likewise.
3578
3579 2019-06-25  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-winsource.h (tui_refill_source_window)
3582         (tui_set_is_exec_point_at): Don't declare.
3583         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3584         (tui_source_window_base::refill): Rename from
3585         tui_refill_source_window.
3586         (tui_source_window_base::do_scroll_horizontal): Update.
3587         (tui_source_window_base::set_is_exec_point_at): Rename from
3588         tui_set_is_exec_point_at.
3589         (tui_update_all_breakpoint_info): Update.
3590         * tui/tui-stack.c (tui_show_frame_info): Update.
3591         * tui/tui-layout.c (show_data): Add cast.
3592         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3593         * tui/tui-data.h (struct tui_source_window_base) <refill,
3594         set_is_exec_point_at>: New methods.
3595         (tui_source_windows, tui_add_to_source_windows): Update types.
3596         (tui_add_to_source_windows): Remove redundant declaration.
3597         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3598         (tui_source_windows): Change return type.
3599         (tui_clear_source_windows_detail): Update.
3600         (tui_add_to_source_windows): Change type of parameter.
3601         (tui_free_all_source_wins_content): Update.
3602
3603 2019-06-25  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-wingeneral.c (tui_win_info::refresh)
3606         (tui_source_window_base::refresh): New methods.
3607         (tui_refresh_all): Call the refresh method.
3608         * tui/tui-data.h (struct tui_win_info)
3609         (struct tui_source_window_base) <refresh>: New method.
3610
3611 2019-06-25  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui.h (tui_is_window_visible): Return bool.
3614         * tui/tui.c (tui_is_window_visible): Return bool.
3615         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3616         (tui_make_visible, tui_make_invisible)
3617         (tui_win_info::make_visible)
3618         (tui_source_window_base::make_visible, make_all_visible)
3619         (tui_make_all_visible, tui_make_all_invisible): Update.
3620         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3621         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3622         bool.
3623         (struct tui_win_info, struct tui_source_window_base)
3624         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3625         * tui/tui-data.c (tui_init_generic_part): Update.
3626
3627 2019-06-25  Tom Tromey  <tom@tromey.com>
3628
3629         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3630         (tui_source_window_base::make_visible): New methods.
3631         (make_all_visible): Make method call.
3632         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3633         (struct tui_source_window_base, struct tui_cmd_window): Override
3634         make_visible.
3635         (tui_win_is_source_type): Don't declare.
3636         * tui/tui-data.c (tui_win_is_source_type): Remove.
3637
3638 2019-06-25  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3641         NULL check.
3642
3643 2019-06-25  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3646         Inline constructor.  Add initializers for members.
3647         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3648         constructors; now inline in class.
3649
3650 2019-06-25  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-regs.c (tui_show_registers): Update.
3653         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3654         bool.
3655         * tui/tui-data.c (tui_data_window::clear_detail)
3656         (tui_data_window): Update.
3657
3658 2019-06-25  Tom Tromey  <tom@tromey.com>
3659
3660         * tui/tui-windata.c (tui_display_all_data)
3661         (tui_display_data_from_line, tui_display_data_from)
3662         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3663         Update.
3664         * tui/tui-regs.c (tui_last_regs_line_no)
3665         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3666         (tui_show_registers, tui_show_register_group)
3667         (tui_display_registers_from, tui_display_reg_element_at_line)
3668         (tui_display_registers_from_line, tui_check_register_values)
3669         (tui_reg_next, tui_reg_prev): Update.
3670         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3671         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3672         tui_data_window.
3673         (struct tui_win_info) <detail>: Remove.  Add new fields from
3674         tui_data_info.
3675         (TUI_DATA_WIN): Add cast.
3676         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3677         (~tui_data_window): Simplify.
3678
3679 2019-06-25  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-layout.c (show_source_disasm_command)
3682         (show_source_or_disasm_and_command): Update.
3683         * tui/tui-io.c (update_cmdwin_start_line)
3684         (tui_redisplay_readline): Update.
3685         * tui/tui-data.h (struct tui_command_info): Remove.
3686         (struct tui_win_info) <detail>: Remove command_info member.
3687         (struct tui_data_window) <start_line>: New member, from
3688         tui_command_info.
3689         (TUI_CMD_WIN): Add casts.
3690
3691 2019-06-25  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-winsource.c (tui_update_source_window)
3694         (tui_refill_source_window)
3695         (tui_source_window_base::do_scroll_horizontal)
3696         (tui_update_breakpoint_info, tui_set_exec_info_content)
3697         (tui_show_exec_info_content, tui_erase_exec_info_content)
3698         (tui_clear_exec_info_content): Update.
3699         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3700         Update.
3701         * tui/tui-win.c (make_invisible_and_set_new_height)
3702         (make_visible_with_new_height): Update.
3703         * tui/tui-source.c (tui_set_source_content)
3704         (tui_show_symtab_source): Update.
3705         * tui/tui-layout.c (extract_display_start_addr)
3706         (show_source_disasm_command, show_data)
3707         (make_source_or_disasm_window)
3708         (show_source_or_disasm_and_command): Update.
3709         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3710         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3711         "gdbarch".
3712         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3713         to tui_source_window_base.
3714         (struct tui_win_info) <detail>: Remove source_info member.
3715         (struct tui_source_window_base) <has_locator>: Inline.
3716         Move contents from tui_source_info; rename has_locator member to
3717         m_has_locator.
3718         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3719         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3720         header file.
3721         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3722         Simplify.
3723         (tui_free_all_source_wins_content): Cast to
3724         tui_source_window_base.
3725
3726 2019-06-25  Tom Tromey  <tom@tromey.com>
3727
3728         * tui/tui-win.c (make_invisible_and_set_new_height)
3729         (make_visible_with_new_height): Call has_locator method.
3730         * tui/tui-layout.c (show_source_disasm_command, show_data)
3731         (show_source_or_disasm_and_command): Update for bool change.
3732         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3733         (tui_win_info) <has_locator>: New method.
3734         (struct tui_source_window_base) <has_locator>: New method.
3735         (tui_win_has_locator): Don't declare.
3736         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3737         from tui_win_has_locator.
3738         (tui_source_window_base): Use false, not FALSE.
3739
3740 2019-06-25  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3743         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3744         clear_detail method directly.
3745         (tui_clear_win_detail): Remove.
3746
3747 2019-06-25  Tom Tromey  <tom@tromey.com>
3748
3749         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3750         "this", not TUI_DISASM_WIN.
3751
3752 2019-06-25  Tom Tromey  <tom@tromey.com>
3753
3754         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3755         declare.
3756         * tui/tui-winsource.c
3757         (tui_source_window_base::do_scroll_horizontal): Rename from
3758         tui_horizontal_source_scroll.
3759         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3760         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3761         from tui_vertical_data_scroll.
3762         * tui/tui-win.h (tui_scroll): Don't declare.
3763         * tui/tui-win.c (tui_win_info::forward_scroll)
3764         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3765         (tui_win_info::right_scroll): Rename and update.
3766         (tui_scroll_forward_command, tui_scroll_backward_command)
3767         (tui_scroll_left_command, tui_scroll_right_command): Update.
3768         (tui_scroll): Remove.
3769         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3770         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3771         from tui_vertical_source_scroll.
3772         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3773         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3774         from tui_vertical_disassem_scroll.
3775         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3776         do_scroll_horizontal>: New methods.
3777         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3778         Likewise.
3779         (struct tui_source_window_base): Add do_scroll_horizontal.
3780         (struct tui_source_window, struct tui_disasm_window): Add
3781         do_scroll_vertical.
3782         (struct tui_data_window, struct tui_cmd_window): Add
3783         do_scroll_horizontal and do_scroll_vertical.
3784         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3785
3786 2019-06-25  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-data.h (struct tui_source_window_base): New struct.
3789         (struct tui_source_window): Derive from tui_source_window_base.
3790         (struct tui_disasm_window): New struct.
3791         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3792         from tui_source_window::clear_detail.
3793         (tui_source_window_base): Rename from tui_source_window.
3794         (~tui_source_window_base): Rename from ~tui_source_window.
3795         (tui_alloc_win_info): Create a tui_disasm_window.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-data.h (struct tui_source_window)
3800         (struct tui_data_window): Declare destructors.
3801         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3802         destructors.
3803         (tui_win_info): Simplify.
3804
3805 2019-06-25  Tom Tromey  <tom@tromey.com>
3806
3807         * tui/tui-winsource.c (tui_display_main)
3808         (tui_update_source_windows_with_addr)
3809         (tui_update_all_breakpoint_info): Update.
3810         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3811         (new_height_ok, parse_scrolling_args): Update.
3812         * tui/tui-stack.c (tui_show_frame_info): Update.
3813         * tui/tui-data.h (struct tui_list): Remove.
3814         (tui_source_windows): Return a reference to a std::vector.
3815         * tui/tui-data.c (source_windows): Now a std::vector.
3816         (tui_source_windows): Change return type.
3817         (tui_clear_source_windows): Rewrite.
3818         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3819         (tui_free_all_source_wins_content): Rewrite.
3820
3821 2019-06-25  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3824         (struct tui_data_window, struct tui_cmd_window): Declare
3825         clear_detail method.
3826         * tui/tui-data.c (tui_source_window::clear_detail)
3827         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3828         methods.
3829         (tui_clear_win_detail): Simplify.
3830
3831 2019-06-25  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-layout.c (make_source_window, make_disasm_window)
3834         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3835         Return the new window.
3836         (show_source_disasm_command, show_data)
3837         (show_source_or_disasm_and_command): Update.
3838
3839 2019-06-25  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3842         parameter.  Return the new window.
3843         (show_source_disasm_command): Update and remove NULL check.
3844         (show_source_or_disasm_and_command): Update.
3845
3846 2019-06-25  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3849
3850 2019-06-25  Tom Tromey  <tom@tromey.com>
3851
3852         * tui/tui-data.h (struct tui_win_info): Make constructor
3853         protected.  Make destructor virtual.  Add initializers.
3854         (tui_source_window, tui_data_window, tui_cmd_window): New
3855         classes.
3856         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3857         constructor.  Add "type" parameter.
3858         (tui_source_window, tui_data_window, tui_cmd_window): New
3859         constructors.
3860         (tui_alloc_win_info): Instantiate the appropriate subclass.
3861
3862 2019-06-25  Tom Tromey  <tom@tromey.com>
3863
3864         * tui/tui-win.c (tui_resize_all): Use delete.
3865         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3866         destructor.
3867         (tui_free_window): Don't declare.
3868         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3869         Update.
3870
3871 2019-06-25  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-data.h (struct tui_win_info): Add constructor.
3874         * tui/tui-data.c (tui_alloc_win_info): Use new.
3875         (tui_free_window): Use delete.
3876
3877 2019-06-22  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3880         declare.
3881         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3882
3883 2019-06-22  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3886         declare.
3887         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3888
3889 2019-06-22  Tom de Vries  <tdevries@suse.de>
3890
3891         * dwarf2read.c (create_addrmap_from_aranges)
3892         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3893         instead of '%zu'.
3894
3895 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3896
3897         * dwarf2read.h (dwarf2_section_info_def): Remove.
3898         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3899         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3900         std::vector<dwarf2_section_info>.
3901         (struct dwo_file) <~dwo_file>: Remove.
3902         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3903         types field.
3904         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3905         (dwarf2_read_debug_names): Likewise.
3906         (create_debug_types_hash_table): Change parameter type to
3907         array_view, adjust code accordingly.
3908         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3909         (partial_die_info::fixup): Likewise.
3910         (determine_prefix): Likewise.
3911         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3912
3913 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3914
3915         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3916         gdb_bfd_ref_ptr.
3917         <~dwo_file>: Remove call to gdb_bfd_unref.
3918         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3919         gdb_bfd_ref_ptr::get.
3920
3921 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3922
3923         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3924         type to htab_up.
3925         * dwarf2read.c (struct dwo_file): Initialize fields.
3926         <~dwo_file>: New.
3927         (free_dwo_file): Remove, move content to ~dwo_file.
3928         (struct dwo_file_deleter): Remove.
3929         (dwo_file_up>: Remove custom deleter.
3930         (free_dwo_files): Remove.
3931         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3932         dwo_files.
3933         (process_skeletonless_type_units): Call unique_ptr::get.
3934         (allocate_dwo_file_hash_table): Add deleter to created hash
3935         table.  Change return type to htab_up.
3936         (lookup_dwo_file_slot): Don't memset dwo_file, call
3937         unique_ptr::get.
3938         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3939         (create_dwo_unit_in_dwp_v2): Likewise.
3940         (open_and_init_dwo_file): Likewise.
3941         (free_dwo_file_from_slot): Remove.
3942
3943 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3944
3945         * dwarf2read.h (struct dwarf2_section_info) <readin,
3946         is_virtual>: Change type to bool.
3947         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3948         true instead of 1.
3949
3950 2019-06-19  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-data.h (tui_init_content_element): Don't declare.
3953
3954 2019-06-19  Tom Tromey  <tom@tromey.com>
3955
3956         * tui/tui-data.h (tui_init_win_info): Don't declare.
3957
3958 2019-06-19  Tom de Vries  <tdevries@suse.de>
3959
3960         * dwarf2read.h (abstract_to_concrete): Change type to
3961         std::unordered_map<sect_offset, std::vector<sect_offset>,
3962         gdb::hash_enum<sect_offset>>.
3963
3964 2019-06-19  Tom Tromey  <tromey@adacore.com>
3965
3966         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3967         EVAL_AVOID_SIDE_EFFECTS specially.
3968
3969 2019-06-19  Tom Tromey  <tromey@adacore.com>
3970
3971         * source-cache.c (highlighter): New global.
3972         (source_cache::get_source_lines): Create a highlighter on demand.
3973
3974 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3975
3976         * defs.h (deprecated_interactive_hook): Delete declaration.
3977         * interps.c (clear_interpreter_hooks): Remove use of
3978         deprecated_interactive_hook.
3979         * top.c (deprecated_interactive_hook): Delete definition.
3980         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3981
3982 2019-06-18  Tom de Vries  <tdevries@suse.de>
3983
3984         PR gdb/24515
3985         * dwarf2read.h (abstract_to_concrete): Change type from
3986         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3987         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3988         * dwarf2read.c (read_variable): Update.
3989         (dwarf2_fetch_die_loc_sect_off): Update.
3990
3991 2019-06-17  Tom de Vries  <tdevries@suse.de>
3992
3993         PR gdb/24617
3994         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3995         accessing parent[parent_len - 1].
3996
3997 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3998
3999         PR gdb/24364
4000         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4001         call dtrace_process_dof with NULL dof.
4002
4003 2019-06-16  Tom de Vries  <tdevries@suse.de>
4004
4005         PR gdb/24445
4006         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4007
4008 2019-06-16  Tom Tromey  <tom@tromey.com>
4009
4010         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4011         (make_all_visible): Use address of member.
4012
4013 2019-06-16  Tom Tromey  <tom@tromey.com>
4014
4015         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4016         (tui_free_window, free_content, free_content_elements): Remove
4017         unnecessary cast.
4018         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4019         cast.
4020         * tui/tui-regs.c (tui_show_register_group)
4021         (tui_display_registers_from, tui_display_reg_element_at_line):
4022         Remove unnecessary cast.
4023
4024 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4025
4026         * linux-nat.c (normal_mask): Delete.
4027         (_initialize_linux_nat): Don't initialise normal_mask.
4028
4029 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4030
4031         PR gdb/24445
4032         * dwarf-index-write.h (write_psymtabs_to_index): Add
4033         dwz_basename parameter.
4034         * dwarf-index-write.c (write_gdbindex): Move file writing to
4035         write_gdbindex_1.  Change return type void.
4036         (assert_file_size): Move up, remove filename parameter.
4037         (write_gdbindex_1): New function.
4038         (write_debug_names): Change return type to void, call
4039         assert_file_size.
4040         (struct index_wip_file): New struct.
4041         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4042         file logic to index_wip_file.  Write index for dwz file if
4043         needed.
4044         (save_gdb_index_command): Pass basename of dwz file, if present.
4045         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4046         build-id of dwz file, if present.
4047         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4048         (dwarf2_get_dwz_file): Likewise.
4049         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4050         (dwarf2_get_dwz_file): Likewise.
4051
4052 2019-06-16  Tom Tromey  <tom@tromey.com>
4053
4054         * coffread.c (process_coff_symbol): Use xstrdup.
4055         * value.c (create_internalvar): Use xstrdup.
4056
4057 2019-06-16  Tom Tromey  <tom@tromey.com>
4058
4059         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4060         * breakpoint.c (stopin_command, stopat_command)
4061         (until_break_command, decode_location_default): Remove unnecessary
4062         cast.
4063         * utils.c (subset_compare): Remove unnecessary cast.
4064         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4065         cast.
4066         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4067         cast.
4068         * infcmd.c (path_command): Remove unnecessary cast.
4069         * coffread.c (decode_type): Remove unnecessary cast.
4070         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4071         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4072         * tui/tui-stack.c (tui_show_locator_content)
4073         (tui_show_frame_info): Remove unnecessary cast.
4074         * tui/tui-win.c (tui_scroll_forward_command)
4075         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4076         (parse_scrolling_args): Remove unnecessary cast.
4077         * tui/tui-data.c (init_win_info, tui_del_window)
4078         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4079         (free_content_elements): Remove unnecessary cast.
4080         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4081         unnecessary cast.
4082         * tui/tui-source.c (tui_set_source_content)
4083         (tui_vertical_source_scroll): Remove unnecessary cast.
4084         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4085         cast.
4086         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4087         * tui/tui-regs.c (tui_display_registers_from)
4088         (tui_display_register): Remove unnecessary cast.
4089         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4090         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4091         (make_visible): Remove unnecessary cast.
4092         * tui/tui-winsource.c (tui_erase_source_content)
4093         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4094         unnecessary cast.
4095         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4096         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4097         * stabsread.c (read_type, read_array_type, read_range_type):
4098         Remove unnecessary cast.
4099         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4100         (parse_symbol, parse_type, upgrade_type, parse_external)
4101         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4102         unnecessary cast.
4103         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4104
4105 2019-06-16  Tom Tromey  <tom@tromey.com>
4106
4107         * tui/tui-data.c (tui_alloc_generic_win_info)
4108         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4109         checks.
4110
4111 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4112             Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * f-typeprint.c (f_print_type): Don't return early for not
4115         associated or not allocated types.
4116         (f_type_print_varspec_suffix): Add print_rank parameter and print
4117         ranks of array types in case they dangling.
4118         (f_type_print_base): Add print_rank parameter.
4119
4120 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4121
4122         * NEWS: Mention new MI commands.
4123         * break-catch-throw.c (enum exception_event_kind): Move to
4124         breakpoint.h.
4125         (print_mention_exception_catchpoint): Output text as a single
4126         message.
4127         (catch_exception_command_1): Rename to...
4128         (catch_exception_event): ...this, make non-static, update header
4129         command, and change some parameter types.
4130         (catch_catch_command): Update for changes to
4131         catch_exception_command_1.
4132         (catch_throw_command): Likewise.
4133         (catch_rethrow_command): Likewise.
4134         * breakpoint.c (enum exception_event_kind): Delete.
4135         * breakpoint.h (enum exception_event_kind): Moved here from
4136         break-catch-throw.c.
4137         (catch_exception_event): Declare.
4138         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4139         (mi_cmd_catch_throw): New function.
4140         (mi_cmd_catch_rethrow): New function.
4141         (mi_cmd_catch_catch): New function.
4142         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4143         'catch-catch' entries.
4144         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4145         (mi_cmd_catch_rethrow): Declare.
4146         (mi_cmd_catch_catch): Declare.
4147
4148 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         * annotate.c (annotate_source_line): Change return type to void,
4151         update implementation to match.
4152         * annotate.h (annotate_source_line): Change return type to void,
4153         update header comment.
4154         * stack.c (print_frame_info): Don't change what frame information
4155         is printed based on whether annotations are on or not.
4156
4157 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4160         (annotate_source): Make static.
4161         (annotate_source_line): Moved from source.c and renamed from
4162         identify_source_line.  Update the return type.
4163         * annotate.h (annotate_source): Delete declaration.
4164         (annotate_source_line): Declaration moved from source.h, and
4165         renamed from identify_source_line.  Return type updated.
4166         * source.c (identify_source_line): Moved to annotate.c and renamed
4167         to annotate_source_line.
4168         (info_line_command): Remove check of annotation_level.
4169         * source.h (identify_source_line): Move declaration to annotate.h
4170         and rename to annotate_source_line.
4171         * stack.c: Add 'annotate.h' include.
4172         (print_frame_info): Remove check of annotation_level before
4173         calling annotate_source_line.
4174
4175 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4176
4177         * source-cache.c (source_cache::get_plain_source_lines): Use
4178         open_source_file_with_line_charpos instead of just
4179         open_source_file, remove call to find_source_lines.
4180         (source_cache::get_source_lines): Likewise.
4181         * source.c (find_source_lines): Make static.
4182         (get_filename_and_charpos): Renamed into...
4183         (open_source_file_with_line_charpos): ..this along with changes to
4184         return a scoped_fd, and some other minor clean ups.
4185         (identify_source_line): Use open_source_file_with_line_charpos.
4186         (search_command_helper): Use open_source_file_with_line_charpos
4187         instead of just open_source_file, remove call to
4188         find_source_lines.
4189         * source.h (open_source_file_with_line_charpos): Declare new
4190         function.
4191         (find_source_lines): Delete declaration.
4192
4193 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * source.c (get_filename_and_charpos): Remove fullname
4196         parameter.
4197         (identify_source_line): Update call to get_filename_and_charpos.
4198
4199 2019-06-14  Tom Tromey  <tromey@adacore.com>
4200
4201         PR gdb/24502:
4202         * ui-style.h (skip_ansi_escape): Update comment.
4203         * ui-file.h (class no_terminal_escape_file): New class.
4204         * ui-file.c (no_terminal_escape_file::write)
4205         (no_terminal_escape_file::puts): New methods.
4206         * cli/cli-logging.c (handle_redirections): Use
4207         no_terminal_escape_file.
4208
4209 2019-06-14  Tom Tromey  <tromey@adacore.com>
4210
4211         * NEWS: Move convenience variable news above Python news.
4212
4213 2019-06-14  Tom Tromey  <tom@tromey.com>
4214
4215         * gnulib: Move directory to top-level.
4216         * configure.ac: Don't configure gnulib.
4217         * configure: Rebuild.
4218         * common/common-defs.h: Use new path to gnulib.
4219         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4220         (GNULIB_H): Remove.
4221         (INCGNU): Look in new gnulib location.
4222         (HFILES_NO_SRCDIR): Remove gnulib files.
4223         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4224         (generated_files): Remove GNULIB_H.
4225         ($(LIBGNU), all-lib): Remove targets.
4226         (distclean): Don't mention GNULIB_BUILDDIR.
4227         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4228
4229 2019-06-14  Tom Tromey  <tromey@adacore.com>
4230
4231         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4232         Warn if symbol file does not provide any symbols.
4233
4234 2019-06-14  Tom Tromey  <tromey@adacore.com>
4235
4236         * source.c (find_and_open_source): Respect basenames_may_differ.
4237
4238 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4239
4240         * annotate.c (annotate_breakpoints_invalid): Make use of
4241         scoped_restore_terminal_state.
4242         (annotate_frames_invalid): Likewise.
4243
4244 2019-06-14  Tom Tromey  <tromey@adacore.com>
4245
4246         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4247         allow assignment to an internalvar.
4248
4249 2019-06-14  Tom Tromey  <tromey@adacore.com>
4250
4251         * ada-lex.l: Allow "_" in attribute names.
4252
4253 2019-06-14  Tom Tromey  <tromey@adacore.com>
4254
4255         PR gdb/24653:
4256         * regcache.c (registers_changed): Don't call alloca.
4257         * top.c (execute_command): Don't call alloca.
4258
4259 2019-06-13  Pedro Alves  <palves@redhat.com>
4260
4261         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4262         'expression'.  When parsing an expression, error out if there's
4263         junk after "unlimited".
4264         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4265         (do_set_command): Adjust calls to is_unlimited_literal.
4266
4267 2019-06-13  Pedro Alves  <palves@redhat.com>
4268
4269         * compile/compile.c (make_compile_options_def_group): Add braces
4270         around array_view initializer.
4271         * thread.c (make_thread_apply_all_options_def_group)
4272         (make_thread_apply_all_options_def_group): Likewise.
4273
4274 2019-06-13  Pedro Alves  <palves@redhat.com>
4275
4276         * NEWS (New commands): Mention "maint test-options
4277         require-delimiter", "maint test-options unknown-is-error", "maint
4278         test-options unknown-is-operand" and "maint show
4279         test-options-completion-result".
4280         (New command options, command completion): New section.
4281         (Completion improvements): New section.
4282         Mention that you can abbreviate "unlimited".
4283
4284 2019-06-13  Pedro Alves  <palves@redhat.com>
4285
4286         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4287         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4288         * unittests/cli-utils-selftests.c (test_parse_flags)
4289         (test_parse_flags_qcs): Delete.
4290         (test_cli_utils): Don't call deleted functions.
4291
4292 2019-06-13  Pedro Alves  <palves@redhat.com>
4293
4294         * thread.c: Include "cli/cli-option.h".
4295         (tp_array_compar_ascending): Global.
4296         (tp_array_compar): Delete function.
4297         (tp_array_compar_ascending, tp_array_compar_descending): New
4298         functions.
4299         (ascending_option_def, qcs_flag_option_def)
4300         (thr_qcs_flags_option_defs)
4301         (make_thread_apply_all_options_def_group)
4302         (make_thread_apply_options_def_group): New.
4303         (thread_apply_all_command): Use gdb::option::process_options.
4304         (thread_apply_command_completer)
4305         (thread_apply_all_command_completer): New.
4306         (thread_apply_command): Use gdb::option::process_options.
4307         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4308         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4309         to generate help text of "thread apply".  Adjust "taas"'s help.
4310         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4311         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4312
4313 2019-06-13  Pedro Alves  <palves@redhat.com>
4314
4315         * thread.c (thread_apply_command): Check for invalid TID with
4316         isdigit instead of !isalpha.
4317
4318 2019-06-13  Pedro Alves  <palves@redhat.com>
4319
4320         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4321         (validate_flags_qcs): New.
4322         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4323         (validate_flags_qcs): Declare.
4324         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4325         (make_frame_apply_options_def_group): New.
4326         (frame_apply_command_count): Process options with
4327         gdb::option::process_options.
4328         (frame_apply_completer): New.
4329         (frame_apply_level_completer, frame_apply_all_completer)
4330         (frame_apply_completer): New.
4331         (_initialize_stack): Update help of "frame apply", "frame apply
4332         level", "frame apply all" and "faas" to mention supported options
4333         and install command completers.
4334         * stack.h (frame_apply_all_completer): Declare.
4335         * thread.c: Include "stack.h".
4336         (tfaas_command): Add "--".
4337         (_initialize_thread): Update help "tfaas" to mention supported
4338         options and install command completer.
4339
4340 2019-06-13  Pedro Alves  <palves@redhat.com>
4341
4342         * completer.c (complete_nested_command_line): New.
4343         (gdb_completion_word_break_characters_throw): Add assertion.
4344         * completer.h (complete_nested_command_line): Declare.
4345
4346 2019-06-13  Pedro Alves  <palves@redhat.com>
4347
4348         * stack.c (parse_backtrace_qualifiers): New.
4349         (backtrace_command): Use it.
4350         (backtrace_command_completer): Complete on qualifiers.
4351
4352 2019-06-13  Pedro Alves  <palves@redhat.com>
4353
4354         * frame.c: Include "cli/cli-option.h.
4355         (user_set_backtrace_options): New.
4356         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4357         Delete.
4358         (get_prev_frame): Adjust.
4359         (boolean_option_def, uinteger_option_def)
4360         (set_backtrace_option_defs): New.
4361         (_initialize_frame): Adjust and use
4362         gdb::option::add_setshow_cmds_for_options to install "set
4363         backtrace past-main" and "set backtrace past-entry".
4364         * frame.h: Include "cli/cli-option.h".
4365         (struct frame_print_options): Forward declare.
4366         (print_frame_arguments_all, print_frame_arguments_scalars)
4367         (print_frame_arguments_none): Declare.
4368         (print_entry_values): Delete declaration.
4369         (struct frame_print_options, user_frame_print_options): New.
4370         (struct set_backtrace_options): New.
4371         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4372         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4373         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4374         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4375         (list_args_or_locals): Add frame_print_options parameter.
4376         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4377         * python/py-framefilter.c (enumerate_args): Pass down
4378         USER_FRAME_PRINT_OPTIONS.
4379         * stack.c: Include "cli/cli-option.h".
4380         (print_frame_arguments_all, print_frame_arguments_scalars)
4381         (print_frame_arguments_none): Declare.
4382         (print_raw_frame_arguments, print_entry_values): Delete.
4383         (user_frame_print_options): New.
4384         (boolean_option_def, enum_option_def, frame_print_option_defs):
4385         New.
4386         (struct backtrace_cmd_options): New.
4387         (bt_flag_option_def): New.
4388         (backtrace_command_option_defs): New.
4389         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4390         (print_frame_arg, read_frame_arg, print_frame_args)
4391         (print_frame_info, print_frame): Add frame_print_options parameter
4392         and use it.
4393         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4394         (backtrace_command_1): Add frame_print_options and
4395         backtrace_cmd_options parameters and use them.
4396         (make_backtrace_options_def_group): New.
4397         (backtrace_command): Process command options with
4398         gdb::option::process_options.
4399         (backtrace_command_completer): New.
4400         (_initialize_stack): Extend "backtrace"'s help to mention
4401         supported options.  Install completer for "backtrace".
4402         Install some settings commands with add_setshow_cmds_for_options.
4403
4404 2019-06-13  Pedro Alves  <palves@redhat.com>
4405
4406         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4407         and that "set/show print raw frame-arguments" are now deprecated.
4408
4409         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4410         command.
4411         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4412         * stack.c (_initialize_stack): Install "set/show print
4413         raw-frame-arguments", and deprecate "set/show print raw
4414         frame-arguments".
4415         * valprint.c (_initialize_valprint): Deprecate "set/show print
4416         raw".
4417
4418 2019-06-13  Pedro Alves  <palves@redhat.com>
4419
4420         * compile/compile.c (struct compile_options): New.
4421         (compile_flag_option_def, compile_command_option_defs)
4422         (make_compile_options_def_group): New.
4423         (compile_file_command): Handle options with
4424         gdb::option::process_options.
4425         (compile_file_command_completer): New function.
4426         (compile_code_command): Handle options with
4427         gdb::option::process_options.
4428         (compile_code_command_completer): New function.
4429         (_initialize_compiler): Install completers for "compile code" and
4430         "compile file".  Mention available options in "compile code" and
4431         "compile code"'s help.
4432         * completer.c (advance_to_completion_word): New, factored out from
4433         ...
4434         (advance_to_expression_complete_word_point): ... this.
4435         (advance_to_filename_complete_word_point): New.
4436         * completer.h (advance_to_filename_complete_word_point): New
4437         declaration.
4438
4439 2019-06-13  Pedro Alves  <palves@redhat.com>
4440
4441         * compile/compile.c: Include "cli/cli-option.h".
4442         (compile_print_value): Scope data pointer is now a
4443         value_print_options pointer; adjust.
4444         (compile_print_command): Process options.  Scope data pointer is
4445         now a value_print_options pointer; adjust.
4446         (_initialize_compile): Update "compile print"'s help to include
4447         supported options.  Install a completer for "compile print".
4448         * cp-valprint.c (show_vtblprint, show_objectprint)
4449         (show_static_field_print): Delete.
4450         (_initialize_cp_valprint): Don't install "set print
4451         static-members", "set print vtbl", "set print object" here.
4452         * printcmd.c: Include "cli/cli-option.h" and
4453         "common/gdb_optional.h".
4454         (print_command_parse_format): Rework to fill in a
4455         value_print_options instead of a format_data.
4456         (print_value): Change parameter type from format_data pointer to
4457         value_print_options reference.  Adjust.
4458         (print_command_1): Process options.  Adjust to pass down a
4459         value_print_options.
4460         (print_command_completer): New.
4461         (_initialize_printcmd): Install print_command_completer as
4462         handle_brkchars completer for the "print" command.  Update
4463         "print"'s help to include supported options.
4464         * valprint.c: Include "cli/cli-option.h".
4465         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4466         here from cp-valprint.c.
4467         (boolean_option_def, uinteger_option_def)
4468         (value_print_option_defs, make_value_print_options_def_group):
4469         New.  Use gdb::option::add_setshow_cmds_for_options to install
4470         "set print elements", "set print null-stop", "set print repeats",
4471         "set print pretty", "set print union", "set print array", "set
4472         print address", "set print symbol", "set print array-indexes".
4473         * valprint.h: Include <string> and "cli/cli-option.h".
4474         (make_value_print_options_def_group): Declare.
4475         (print_value): Change parameter type from format_data pointer to
4476         value_print_options reference.
4477         (print_command_completer): Declare.
4478
4479 2019-06-13  Pedro Alves  <palves@redhat.com>
4480
4481         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4482         (COMMON_SFILES): Add maint-test-settings.c.
4483         * cli/cli-decode.c (boolean_enums): New global, factored out from
4484         ...
4485         (add_setshow_boolean_cmd): ... here.
4486         * cli/cli-decode.h (boolean_enums): Declare.
4487         * cli/cli-option.c: New file.
4488         * cli/cli-option.h: New file.
4489         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4490         factored out from ...
4491         (parse_cli_boolean_value(const char *)): ... this.
4492         (is_unlimited_literal): Change parameter type to pointer to
4493         pointer.  Adjust and advance ARG pointer.
4494         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4495         (parse_cli_var_enum): New, factored out from ...
4496         (do_set_command): ... this.  Adjust.
4497         * cli/cli-setshow.h (parse_cli_boolean_value)
4498         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4499         (parse_cli_var_enum): Declare.
4500         * cli/cli-utils.c: Include "cli/cli-option.h".
4501         (get_ulongest): New.
4502         * cli/cli-utils.h (get_ulongest): Declare.
4503         (check_for_argument): New overloads.
4504         * maint-test-options.c: New file.
4505
4506 2019-06-13  Pedro Alves  <palves@redhat.com>
4507
4508         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4509         parse a range if "-" is at the end of the string.
4510
4511 2019-06-13  Pedro Alves  <palves@redhat.com>
4512
4513         * cli/cli-setshow.c (parse_auto_binary_operation)
4514         (parse_cli_boolean_value): Don't allow "o".
4515
4516 2019-06-13  Pedro Alves  <palves@redhat.com>
4517
4518         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4519         * NEWS: Mention maint test-settings KIND.
4520         * maint-test-settings.c: New file.
4521
4522 2019-06-13  Pedro Alves  <palves@redhat.com>
4523
4524         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4525         completer.
4526         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4527         "set" completers.
4528
4529 2019-06-13  Pedro Alves  <palves@redhat.com>
4530
4531         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4532         after item.
4533
4534 2019-06-13  Pedro Alves  <palves@redhat.com>
4535
4536         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4537
4538 2019-06-13  Pedro Alves <palves@redhat.com>
4539
4540         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4541         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4542         call.
4543         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4544         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4545         calls.
4546         (check_for_argument): Skip spaces after argument.
4547
4548 2019-06-13  Pedro Alves  <palves@redhat.com>
4549
4550         * thread.c (thread_apply_command): Adjust TID parsing.
4551         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4552         detected before end of string.
4553         (tid_is_in_list): Error out if LIST is invalid.
4554
4555 2019-06-13  Pedro Alves  <palves@redhat.com>
4556
4557         * completer.c (complete_line_internal_1): Rewind completion word
4558         point.
4559         (completion_tracker::advance_custom_word_point_by): Change
4560         parameter type to int.
4561         * completer.h (completion_tracker::advance_custom_word_point_by):
4562         Likewise.
4563
4564 2019-06-13  Pedro Alves  <palves@redhat.com>
4565
4566         * completer.c (advance_to_completion_word): Handle delimiters.
4567
4568 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4569
4570         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4571
4572 2019-06-11  Tom Tromey  <tom@tromey.com>
4573
4574         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4575         (xmalloc_failed): Move to alloc.c.
4576         * alloc.c: New file.
4577         * Makefile.in (COMMON_SFILES): Add alloc.c.
4578
4579 2019-06-11  Tom Tromey  <tom@tromey.com>
4580
4581         * nat/linux-waitpid.c: Don't include server.h.
4582         (linux_debug): Remove.
4583         (my_waitpid): Update.
4584
4585 2019-06-11  Tom Tromey  <tromey@adacore.com>
4586
4587         * infcall.c (_initialize_infcall): Remove trailing newline from
4588         help.
4589         * user-regs.c (_initialize_user_regs): Remove trailing newline
4590         from help.
4591         * typeprint.c (_initialize_typeprint): Remove trailing newline
4592         from help.
4593         * reverse.c (_initialize_reverse): Remove trailing newlines from
4594         help.
4595         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4596         from help.
4597         * language.c (add_set_language_command): Remove trailing newline
4598         from help.
4599         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4600         help.
4601         * disasm.c (_initialize_disasm): Remove trailing newline from
4602         help.
4603         * top.c (init_main): Remove trailing newline from help.
4604         * interps.c (_initialize_interpreter): Remove trailing newline
4605         from help.
4606         * btrace.c (_initialize_btrace): Remove trailing newlines from
4607         help.
4608         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4609         from help.
4610         * python/python.c (_initialize_python): Remove trailing newline
4611         from help.
4612         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4613         help.
4614         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4615         from help.  Reformat some text.
4616         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4617         from help.
4618         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4619         newline from help.
4620
4621 2019-06-11  Tom Tromey  <tromey@adacore.com>
4622
4623         * darwin-nat.c (darwin_decode_exception_message)
4624         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4625
4626 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4627
4628         * valops.c (value_slice): Check for not allocated or not
4629         associated values.
4630
4631 2019-06-10  Tom de Vries  <tdevries@suse.de>
4632
4633         PR gdb/24618
4634         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4635         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4636         invalid.
4637
4638 2019-06-10  Tom de Vries  <tdevries@suse.de>
4639
4640         PR gdb/24611
4641         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4642         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4643
4644 2019-06-10  Tom de Vries  <tdevries@suse.de>
4645
4646         PR symtab/24545
4647         * symtab.c (struct demangled_name_entry): Add language field.
4648         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4649         static minimal symbol".  Set and use language field.
4650
4651 2019-06-10  Tom Tromey  <tromey@adacore.com>
4652
4653         * ada-lang.c (_initialize_ada_language): Update help text.
4654
4655 2019-06-10  Tom Tromey  <tromey@adacore.com>
4656
4657         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4658         with a newline.
4659         * guile/guile.c (handle_boot_error): Don't end warning with a
4660         newline.
4661         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4662         warning with a newline.
4663         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4664         newline.
4665         (s12z_frame_cache): Likewise.
4666         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4667         a newline.
4668         * solib-svr4.c (disable_probes_interface): Don't end warning with
4669         a newline.
4670         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4671         newline.
4672         * python/python.c (do_finish_initialization): Don't end warning
4673         with a newline.
4674
4675 2019-06-10  Tom Tromey  <tom@tromey.com>
4676
4677         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4678         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4679         gdbpy_enter.
4680
4681 2019-06-10  Tom Tromey  <tromey@adacore.com>
4682
4683         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4684         data.
4685         (elf_new_init): Don't call stabsread_new_init.
4686         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4687         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4688         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4689
4690 2019-06-10  Tom de Vries  <tdevries@suse.de>
4691
4692         PR symtab/16264
4693         PR symtab/24517
4694         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4695
4696 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4697
4698         * source.c (find_and_open_source): Also rewrite relative file
4699         names.
4700
4701 2019-04-26  Amos Bird  <amosbird@gmail.com>
4702
4703         * annotate.c (annotate_thread_exited): Add "thread-exited"
4704         annotation.
4705
4706 2019-06-06  Tom Tromey  <tromey@adacore.com>
4707
4708         * maint.h (class scoped_command_stats): Use
4709         DISABLE_COPY_AND_ASSIGN.
4710         <print_time>: New method.
4711         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4712         print_time.
4713         (scoped_command_stats::print_time): New method.
4714
4715 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4716
4717         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4718         instructions of lengths 6 or 8 bytes.
4719
4720 2019-06-04  Pedro Alves  <palves@redhat.com>
4721
4722         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4723
4724         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4725         * breakpoint.c (condition_completer): Likewise.
4726         * cli/cli-dump.c (scan_expression): Likewise.
4727         * common/filestuff.c (mkdir_recursive): Likewise.
4728         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4729         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4730         (gdb_abspath): Likewise.
4731         * compile/compile-cplus-types.c
4732         (compile_cplus_instance::decl_name): Likewise.
4733         * completer.c (complete_explicit_location):
4734         (signal_completer, reg_or_group_completer_1): Likewise.
4735         * cp-support.c (cp_remove_params_if_any): Likewise.
4736         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4737         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4738         * infcmd.c (strip_bg_char): Likewise.
4739         * linespec.c (copy_token_string): Likewise.
4740         * mi/mi-main.c (output_cores): Likewise.
4741         * psymtab.c (psymtab_search_name):
4742         * symfile.c (test_set_ext_lang_command): Likewise.
4743         * target.c (target_fileio_read_stralloc): Likewise.
4744         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4745         * value.c (complete_internalvar): Likewise.
4746
4747 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4748
4749         Add objfile property to gdb.Type.
4750         * NEWS: Mention Python API addition.
4751         * python/py-type.c (typy_get_objfile): New method.
4752
4753 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4754
4755         * NEWS: Mention the new set|show style [title|highlight].
4756         Mention changes to "show style", "help" and "apropos".
4757
4758 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4759
4760         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4761         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4762         instead of print_help_for_command.
4763         (print_doc_of_command): New function.
4764         (help_list): Add 'apropos -v word' suggestion.
4765         (print_help_for_command): Style the command name using title style.
4766         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4767         (_initialize_cli_cmds): Describe -v in apropos_command help.
4768
4769 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4770
4771         * cli/cli-style.h (cli_style_option): Add name in constructor,
4772         add m_name class member, add constructor with intensity,
4773         add name class function.
4774         (cli_style_option::add_setshow_commands): Remove name argument.
4775         (highlight_style, title_style): New styles.
4776         * cli/cli-style.c (do_show): New function that shows a style
4777         characteristic styling the style name with itself.
4778         (set_style_name): New function.
4779         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4780         Update all callers according to the changes in cli/cli-style.h.
4781         * utils.h (fputs_highlighted): New function.
4782         * utils.c (fputs_highlighted): Likewise.
4783
4784 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4785
4786         * NEWS: Mention new pipe command and new convenience variables.
4787
4788 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4789
4790         * cli/cli-cmds.c (pipe_command): New function.
4791         (_initialize_cli_cmds): Call add_com for pipe_command.
4792         Define | as an alias for pipe.
4793         (exit_status_set_internal_vars): New function.
4794         (shell_escape): Call exit_status_set_internal_vars.
4795         cli/cli-decode.c (find_command_name_length): Recognize | as
4796         a single character command.
4797
4798 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4799
4800         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4801         top.c (execute_command_to_ui_file): New function, mostly a copy
4802         of execute_command_to_string.
4803         (execute_command_to_string): Implement by calling
4804         execute_command_to_ui_file.
4805
4806 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4807
4808         * top.h (saved_command_line): Remove declaration.
4809         * top.c (previous_saved_command_line, previous_repeat_arguments):
4810         New variables.
4811         (saved_command_line): Make static, define together with other
4812         'repeat variables'.
4813         (dont_repeat): Clear repeat_arguments.
4814         (repeat_previous, get_saved_command_line, save_command_line):
4815         New functions.
4816         (gdb_init): Initialize saved_command_line
4817         and previous_saved_command_line.
4818         * main.c (captured_main_1): Remove saved_command_line initialization.
4819         * event-top.c (handle_line_of_input): Update to use
4820         the new 'repeat' related functions instead of direct access to
4821         saved_command_line.
4822         * command.h (repeat_previous, get_saved_command_line,
4823         save_command_line): New declarations.
4824         (dont_repeat): Add comment.
4825
4826 2019-05-30  Tom Tromey  <tromey@adacore.com>
4827
4828         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4829         Fix comment.
4830         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4831
4832 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4833
4834         PR cli/24587
4835         * completer.c (complete): Initialize variable word.
4836
4837 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4838
4839         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4840         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4841         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4842         'body' is NULL to the outter 'if', protecting the '!is_define'
4843         situation as well.
4844
4845 2019-05-29  Tom Tromey  <tromey@adacore.com>
4846
4847         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4848         (dwarf_unknown): New function.
4849         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4850         (dwarf_type_encoding_name): Use dwarf_unknown.
4851
4852 2019-05-29  Tom Tromey  <tromey@adacore.com>
4853
4854         PR c++/20020:
4855         * cp-valprint.c (cp_print_value_fields): Call
4856         cp_print_static_field inside "try".
4857
4858 2019-05-29  Tom Tromey  <tromey@adacore.com>
4859
4860         * inflow.c (struct terminal_info): Add default operator=.
4861         * configure: Rebuild.
4862         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4863         -Wdeprecated-copy-dtor, -Wredundant-move.
4864
4865 2019-05-29  Tom Tromey  <tromey@adacore.com>
4866
4867         * NEWS: Add entry.
4868         * infcmd.c (print_return_value_1): Handle finish_print
4869         option.
4870         (show_print_finish): New function.
4871         (_initialize_infcmd): Add "set/show print finish" commands.
4872         * valprint.c (user_print_options): Initialize new member.
4873         * valprint.h (struct value_print_options) <finish_print>: New
4874         member.
4875
4876 2019-05-28  Tom Tromey  <tromey@adacore.com>
4877
4878         * ada-lang.c (ada_remove_Xbn_suffix)
4879         (find_old_style_renaming_symbol)
4880         (parse_old_style_renaming): Remove.
4881         (ada_find_renaming_symbol): Don't call
4882         find_old_style_renaming_symbol.
4883         (ada_is_renaming_symbol): Rename from
4884         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4885         bool.  Now static.
4886         (ada_read_var_value): Update and simplify.
4887         * ada-exp.y (write_var_or_type): Remove old code.
4888
4889 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4890
4891         * event-top.c: Remove include comment.
4892         * inflow.c (class scoped_ignore_sigttou): Move from here...
4893         * inflow.h (class scoped_ignore_sigttou): ...to here.
4894         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4895         * top.c:  Remove include comment.
4896
4897 2019-05-27  Tom Tromey  <tom@tromey.com>
4898
4899         * NEWS: Fix typo.
4900
4901 2019-05-22  Tom Tromey  <tromey@adacore.com>
4902
4903         * target.c (target_follow_exec): Constify parameter.
4904         * target-delegates.c: Rebuild.
4905         * remote.c (remote_target::follow_exec): Constify parameter.
4906         * infrun.c (follow_exec): Constify parameter.
4907         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4908         (target_follow_exec): Likewise.
4909
4910 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4911
4912         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4913         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4914
4915 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4916
4917         * NEWS: Add debugredirect and testsuite sections.
4918
4919 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4920
4921         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4922         target descriptions using exclusively floating point register name
4923         aliases.
4924
4925 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4926
4927         PR gdb/18644:
4928         * f-lang.c (build_fortran_types): Handle the case where
4929         gdbarch_floatformat_for_type returns a nullptr.
4930
4931 2019-05-21  Tom de Vries  <tdevries@suse.de>
4932
4933         PR cli/24587
4934         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4935
4936 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         PR gdb/18644:
4939         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4940         16-byte floats.
4941         * i386-tdep.c (i386_floatformat_for_type): Use
4942         floatformats_ia64_quad for the 16-byte floating point component
4943         within a fortran 32-byte complex number.
4944
4945 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4946
4947         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4948         delete default constructor.
4949         (find_partial_die): Update to return const struct.
4950         (partial_die_parent_scope): Move variable declaration into scope
4951         of its use and change its type to auto.
4952         (guess_partial_die_structure_name): Likewise.
4953         (partial_die_info::fixup): Likewise.
4954
4955 2019-05-17  Tom Tromey  <tromey@adacore.com>
4956
4957         * source.c (find_and_open_source): Remove cast.
4958
4959 2019-05-17  Tom Tromey  <tromey@adacore.com>
4960
4961         * annotate.c (annotate_source): Make "filename" const.
4962         * annotate.h (annotate_source): Use const.
4963
4964 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4965
4966         * disasm.c (set_disassembler_options): Send errors to stderr.
4967
4968 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4969
4970         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4971         (cli_interp_base::set_logging): Check debug_redirect.
4972         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4973         * cli/cli-logging.c (debug_redirect): Add static variable.
4974         (pop_output_files): Add default param.
4975         (handle_redirections): Print debug setting.
4976         (show_logging_command): Likewise.
4977         (_initialize_cli_logging): Add debugredirect command.
4978         * interps.c (current_interp_set_logging): Add debug_redirect
4979         parameter.
4980         * interps.h (set_logging): Add debug_redirect parameter.
4981         (current_interp_set_logging): Likewise.
4982         * mi/mi-common.h: Likewise.
4983         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4984
4985 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4986             Tom Tromey  <tromey@adacore.com>
4987
4988         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4989         directly.
4990         * cli/cli-interp.h (make_logging_output): Remove declaration.
4991         * cli/cli-logging.c (make_logging_output): Remove function.
4992         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4993         directly.
4994         * ui-file.c (tee_file::tee_file): Remove bools.
4995         (tee_file::~tee_file): Remove deletes.
4996         * ui-file.h (tee_file): Remove bools.
4997
4998 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4999
5000         * mi/mi-cmds.h (mi_cmd_complete): New function.
5001         * mi/mi-main.c (mi_cmd_complete): Likewise.
5002         * mi/mi-cmds.c: Define new MI command -complete.
5003         * NEWS: Mention new -complete command.
5004
5005 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5006
5007         * completer.h (complete): New function.
5008         * completer.c (complete): Likewise.
5009         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5010         function defined in completer.h.
5011
5012 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5013
5014         * MAINTAINERS (Write After Approval): Add myself.
5015
5016 2019-05-17  Tom de Vries  <tdevries@suse.de>
5017
5018         PR gdb/24094
5019         * dwarf2read.c (struct cu_partial_die_info): New struct.
5020         (find_partial_die): Return cu_partial_die_info.
5021         (partial_die_parent_scope, guess_partial_die_structure_name)
5022         (partial_die_info::fixup): Handle new return type of find_partial_die.
5023
5024 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5025
5026         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5027         "std::string", simplifying the algorithm.
5028
5029 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5030
5031         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5032         (stap_static_probe_ops::get_probes): Likewise.
5033
5034 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5035
5036         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5037         '-')" and "else if".
5038         (stap_parse_single_operand): Join checks for
5039         "gdbarch_stap_parse_special_token_p" and
5040         "gdbarch_stap_parse_special_token" in the same "if" statement.
5041         Invert check when verifying for operation on register
5042         displacement.
5043
5044 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5045
5046         * stap-probe.c (stap_get_opcode): Update comment.
5047         (stap_get_expected_argument_type): Likewise.
5048         (handle_stap_probe): Likewise.
5049
5050 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5051
5052         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5053         return type to 'bool'.  Adjust comment.  Use 'bool' when
5054         appropriate.
5055         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5056         * stap-probe.c (stap_parse_argument_1): Likewise.
5057         (stap_is_operator): Likewise.
5058         (stap_is_generic_prefix): Likewise.
5059         (stap_is_register_prefix): Likewise.
5060         (stap_is_register_indirection_prefix): Likewise.
5061         (stap_is_integer_prefix): Likewise.
5062         (stap_generic_check_suffix): Likewise.
5063         (stap_check_integer_suffix): Likewise.
5064         (stap_check_register_suffix): Likewise.
5065         (stap_check_register_indirection_suffix): Likewise.
5066         (stap_parse_register_operand): Likewise.
5067         (stap_parse_single_operand): Likewise.
5068         (stap_parse_argument_1): Likewise.
5069         (stap_probe::get_argument_count): Likewise.
5070         (stap_is_operator): Likewise.
5071
5072 2019-05-16  Tom Tromey  <tromey@adacore.com>
5073
5074         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5075         keyword to foreach.
5076
5077 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5078
5079         * linux-thread-db.c (try_thread_db_load_1): Change return type
5080         to bool.
5081         (try_thread_db_load): Likewise.
5082         (try_thread_db_load_from_pdir_1): Likewise.
5083         (try_thread_db_load_from_pdir): Likewise.
5084         (try_thread_db_load_from_sdir): Likewise.
5085         (try_thread_db_load_from_dir): Likewise.
5086         (thread_db_load_search): Likewise.
5087         (has_libpthread): Likewise.
5088         (thread_db_load): Likewise.
5089
5090 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5091
5092         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5093         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5094         NULL, and complain/return if that's the case.
5095
5096 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5097
5098         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5099         (advance, posn, abstract_read_memory): New functions.
5100         [struct mem_read_abstraction]: New struct.
5101         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5102
5103 2019-05-14  Tom Tromey  <tromey@adacore.com>
5104
5105         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5106         value is not lval_memory.
5107
5108 2019-05-14  Tom Tromey  <tromey@adacore.com>
5109
5110         * solib.c (info_sharedlibrary_command): Style the file name.
5111
5112 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5113
5114         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5115         (aarch64_vnv_type): Likewise.
5116         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5117         * common/tdesc.c: Likewise.
5118         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5119         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5120         * features/aarch64-fpu.xml: Add ieee half view.
5121         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5122         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5123         * gdbtypes.h (struct builtin_type): Likewise.
5124         (struct objfile_type): Likewise.
5125
5126 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5127
5128         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5129         typo.
5130         * location.h (string_to_event_location): Likewise.
5131
5132 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5133
5134         GDB 8.3 released.
5135
5136 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5137
5138         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5139         New variable declaration.
5140         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5141         New variable.
5142         (print_one_breakpoint): Use ui_out::test_flags and new global
5143         variable to compute use_fixed_output.
5144         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5145         Remove.
5146         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5147         (mi_multi_location_breakpoint_output_fixed): Remove.
5148         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5149         new variable.
5150         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5151         fix_multi_location_breakpoint_output flag if version >= 3.
5152         * ui-out.h (enum ui_out_flag)
5153         <fix_multi_location_breakpoint_output>: New enumerator.
5154
5155 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5156
5157         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5158
5159 2019-05-10  Tom Tromey  <tromey@adacore.com>
5160
5161         * ada-lang.c (catch_ada_completer): New function.
5162         (_initialize_ada_language): Use it.
5163
5164 2019-05-10  Tom Tromey  <tromey@adacore.com>
5165
5166         * thread.c (print_thread_info): Make "requested_threads" const.
5167         * gdbthread.h (print_thread_info): Make "requested_threads"
5168         const.
5169         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5170         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5171
5172 2019-05-08  Tom Tromey  <tom@tromey.com>
5173
5174         * gdbtypes.c (objfile_type_data): Change type.
5175         (objfile_type, _initialize_gdbtypes): Update.
5176
5177 2019-05-08  Tom Tromey  <tom@tromey.com>
5178
5179         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5180         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5181         (_initialize_dwarf2_frame): Update.
5182
5183 2019-05-08  Tom Tromey  <tom@tromey.com>
5184
5185         * objc-lang.c (objc_objfile_data): Change type.
5186         (find_methods): Update.
5187         (_initialize_objc_lang): Remove.
5188
5189 2019-05-08  Tom Tromey  <tom@tromey.com>
5190
5191         * stabsread.c (rs6000_builtin_type_data): Change type.
5192         (rs6000_builtin_type, _initialize_stabsread): Update.
5193
5194 2019-05-08  Tom Tromey  <tom@tromey.com>
5195
5196         * mips-tdep.c (mips_pdr_data): Remove.
5197         (_initialize_mips_tdep): Update.
5198
5199 2019-05-08  Tom Tromey  <tom@tromey.com>
5200
5201         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5202         (hppa_init_objfile_priv_data, read_unwind_info)
5203         (find_unwind_entry, _initialize_hppa_tdep): Update.
5204
5205 2019-05-08  Tom Tromey  <tom@tromey.com>
5206
5207         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5208         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5209         on obstack.
5210         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5211
5212 2019-05-08  Tom Tromey  <tom@tromey.com>
5213
5214         * mdebugread.c (basic_type_data): Change type.
5215         (basic_type, _initialize_mdebugread): Update.
5216
5217 2019-05-08  Tom Tromey  <tom@tromey.com>
5218
5219         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5220
5221 2019-05-08  Tom Tromey  <tom@tromey.com>
5222
5223         * nto-tdep.c (nto_inferior_data_reg): Change type.
5224         (nto_inferior_data): Update.
5225         (nto_inferior_data_cleanup, nto_new_inferior_data)
5226         (_initialize_nto_tdep): Remove.
5227         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5228
5229 2019-05-08  Tom Tromey  <tom@tromey.com>
5230
5231         * ada-lang.c (struct ada_inferior_data): Add initializers.
5232         (ada_inferior_data): Change type.
5233         (ada_inferior_data_cleanup): Remove.
5234         (get_ada_inferior_data, ada_inferior_exit)
5235         (struct ada_pspace_data): Add initializers, destructor.
5236         (ada_pspace_data_handle): Change type.
5237         (get_ada_pspace_data): Update.
5238         (ada_pspace_data_cleanup): Remove.
5239
5240 2019-05-08  Tom Tromey  <tom@tromey.com>
5241
5242         * coffread.c (struct coff_symfile_info): Add initializers.
5243         (coff_objfile_data_key): Move lower.  Change type.
5244         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5245         Update.
5246         (coff_free_info): Remove.
5247
5248 2019-05-08  Tom Tromey  <tom@tromey.com>
5249
5250         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5251         (fbsd_pspace_data_handle): Move lower.  Change type.
5252         (get_fbsd_pspace_data): Update.
5253         (fbsd_pspace_data_cleanup): Remove.
5254         (_initialize_fbsd_tdep): Update.
5255
5256 2019-05-08  Tom Tromey  <tom@tromey.com>
5257
5258         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5259         (get_ada_tasks_pspace_data): Update.
5260         (ada_tasks_pspace_data_cleanup): Remove.
5261         (_initialize_tasks): Update.
5262         (ada_tasks_inferior_data_handle): Change type.
5263         (get_ada_tasks_inferior_data): Update.
5264         (ada_tasks_inferior_data_cleanup): Remove.
5265         (struct ada_tasks_pspace_data): Add initializers.
5266
5267 2019-05-08  Tom Tromey  <tom@tromey.com>
5268
5269         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5270         * symfile-debug.c (debug_sym_get_probes): Change type.
5271         * stap-probe.c (handle_stap_probe):
5272         (stap_static_probe_ops::get_probes): Change type.
5273         * probe.h (class static_probe_ops) <get_probes>: Change type.
5274         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5275         (parse_probes_in_pspace): Update.
5276         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5277         Update.
5278         (any_static_probe_ops::get_probes): Change type.
5279         * elfread.c (elfread_data): New typedef.
5280         (probe_key): Change type.
5281         (elf_get_probes): Likewise.  Update.
5282         (probe_key_free): Remove.
5283         (_initialize_elfread): Update.
5284         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5285         Change type.
5286         (dtrace_process_dof_probe, dtrace_process_dof)
5287         (dtrace_static_probe_ops::get_probe): Change type.
5288
5289 2019-05-08  Tom Tromey  <tom@tromey.com>
5290
5291         * xcoffread.c (struct xcoff_symfile_info): Rename from
5292         coff_symfile_info.  Add initializers.
5293         (xcoff_objfile_data_key): Move lower.  Change type.
5294         (XCOFF_DATA): Rewrite.
5295         (xcoff_free_info): Remove.
5296         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5297         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5298         (xcoff_initial_scan): Update.
5299
5300 2019-05-08  Tom Tromey  <tom@tromey.com>
5301
5302         * solib-svr4.c (struct svr4_info): Add initializers and
5303         destructor.
5304         <probes_table>: Now an htab_up.
5305         (solib_svr4_pspace_data): Change type.
5306         (free_probes_table): Simplify.
5307         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5308         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5309         (probes_table_remove_objfile_probes, register_solib_event_probe)
5310         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5311         (_initialize_svr4_solib): Update.
5312
5313 2019-05-08  Tom Tromey  <tom@tromey.com>
5314
5315         * remote.c (remote_pspace_data): Change type.
5316         (remote_pspace_data_cleanup): Remove.
5317         (get_remote_exec_file, set_pspace_remote_exec_file)
5318         (_initialize_remote): Update.
5319
5320 2019-05-08  Tom Tromey  <tom@tromey.com>
5321
5322         * breakpoint.c (breakpoint_objfile_key): Change type.
5323         (get_breakpoint_objfile_data): Update.
5324         (free_breakpoint_objfile_data): Remove.
5325         (_initialize_breakpoint): Update.
5326
5327 2019-05-08  Tom Tromey  <tom@tromey.com>
5328
5329         * linux-tdep.c (struct linux_info): Add initializers.
5330         (linux_inferior_data): Move.  Change type.
5331         (invalidate_linux_cache_inf): Update.
5332         (linux_inferior_data_cleanup): Remove.
5333         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5334
5335 2019-05-08  Tom Tromey  <tom@tromey.com>
5336
5337         * auxv.c (auxv_inferior_data): Move.  Change type.
5338         (auxv_inferior_data_cleanup): Remove.
5339         (invalidate_auxv_cache_inf): Rewrite.
5340         (get_auxv_inferior_data, _initialize_auxv): Update.
5341
5342 2019-05-08  Tom Tromey  <tom@tromey.com>
5343
5344         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5345         (symfile_debug_objfile_data_key): Change type.
5346         (symfile_debug_installed, debug_qf_has_symbols)
5347         (debug_qf_find_last_source_symtab)
5348         (debug_qf_forget_cached_source_info)
5349         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5350         (debug_qf_print_stats, debug_qf_dump)
5351         (debug_qf_expand_symtabs_for_function)
5352         (debug_qf_expand_all_symtabs)
5353         (debug_qf_expand_symtabs_with_fullname)
5354         (debug_qf_map_matching_symbols)
5355         (debug_qf_expand_symtabs_matching)
5356         (debug_qf_find_pc_sect_compunit_symtab)
5357         (debug_qf_map_symbol_filenames)
5358         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5359         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5360         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5361         (debug_sym_read_linetable, debug_sym_relocate): Update.
5362         (symfile_debug_free_objfile): Remove.
5363         (install_symfile_debug_logging, _initialize_symfile_debug):
5364         Update.
5365
5366 2019-05-08  Tom Tromey  <tom@tromey.com>
5367
5368         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5369         allocate_on_obstack.
5370         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5371         (get_dwarf2_per_objfile): Update.
5372         (set_dwarf2_per_objfile): Remove.
5373         (dwarf2_has_info, dwarf2_get_section_info): Update.
5374         (dwarf2_free_objfile): Remove.
5375         (_initialize_dwarf2_read): Update.
5376
5377 2019-05-08  Tom Tromey  <tom@tromey.com>
5378
5379         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5380         initializers.
5381         <unsupported_script_warning_printed,
5382         script_not_found_warning_printed>: Now bool.
5383         (auto_load_pspace_data): Change type.
5384         (~auto_load_pspace_info): Rename from
5385         auto_load_pspace_data_cleanup.
5386         (get_auto_load_pspace_data, init_loaded_scripts_info)
5387         (clear_section_scripts, maybe_print_unsupported_script_warning)
5388         (maybe_print_script_not_found_warning, _initialize_auto_load):
5389         Update.
5390
5391 2019-05-08  Tom Tromey  <tom@tromey.com>
5392
5393         * objfiles.c (objfile_pspace_info): Add destructor and
5394         initializers.
5395         (objfiles_pspace_data): Change type.
5396         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5397         (get_objfile_pspace_data): Update.
5398         (objfiles_bfd_data): Change type.
5399         (get_objfile_bfd_data): Update.
5400         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5401
5402 2019-05-08  Tom Tromey  <tom@tromey.com>
5403
5404         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5405         Change type.
5406         (get_catch_syscall_inferior_data): Update.
5407         (catch_syscall_inferior_data_cleanup): Remove.
5408         (_initialize_break_catch_syscall): Update.
5409
5410 2019-05-08  Tom Tromey  <tom@tromey.com>
5411
5412         * inflow.c (struct terminal_info): Add destructor and
5413         initializers.
5414         (inflow_inferior_data): Change type.
5415         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5416         (get_inflow_inferior_data, inflow_inferior_exit)
5417         (swap_terminal_info, _initialize_inflow): Update.
5418
5419 2019-05-08  Tom Tromey  <tom@tromey.com>
5420
5421         * target-dcache.c (target_dcache_cleanup): Remove.
5422         (target_dcache_aspace_key): Change type.
5423         (target_dcache_init_p, target_dcache_invalidate)
5424         (target_dcache_get, target_dcache_get_or_init)
5425         (_initialize_target_dcache): Update.
5426         * dcache.h (struct dcache_deleter): New.
5427
5428 2019-05-08  Tom Tromey  <tom@tromey.com>
5429
5430         * symtab.c (struct symbol_cache): Add destructor and
5431         initializers.
5432         (symbol_cache_key): Move.  Change type.
5433         (make_symbol_cache, free_symbol_cache): Remove.
5434         (get_symbol_cache): Update.
5435         (symbol_cache_cleanup): Remove.
5436         (ALL_PSPACES, symbol_cache_flush)
5437         (maintenance_print_symbol_cache)
5438         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5439         Update.
5440
5441 2019-05-08  Tom Tromey  <tom@tromey.com>
5442
5443         * symtab.c (struct main_info): Add destructor and initializers.
5444         (main_progspace_key): Move.  Change type.
5445         (get_main_info): Update.
5446         (main_info_cleanup): Remove.
5447         (_initialize_symtab): Update.
5448
5449 2019-05-08  Tom Tromey  <tom@tromey.com>
5450
5451         * registry.h (DECLARE_REGISTRY): Define the _key class.
5452
5453 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5454
5455         * NEWS: Merge two 'New commands' sections.
5456
5457 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5458
5459         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5460         parameter and use Ada language definition instead.
5461         (ada_val_print_ptr): Remove unused language parameter.
5462         (ada_val_print_num): Remove language parameter and use Ada language
5463         definition instead.
5464         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5465         parameter.
5466         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5467         parameter and use Ada language definition instead.
5468         (ada_val_print_1): Update all ada_val_print_xxx calls.
5469         Remove language parameter.
5470         (ada_val_print): Update ada_val_print_1 call.
5471
5472 2019-05-08  Tom Tromey  <tromey@adacore.com>
5473
5474         * remote.c (remote_hw_watchpoint_limit)
5475         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5476         Now static.
5477
5478 2019-05-08  Tom Tromey  <tromey@adacore.com>
5479
5480         * maint.c (_initialize_maint_cmds): Move initialization code to
5481         remote.c.
5482         (watchdog, show_watchdog): Move to remote.c.
5483         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5484         "watchdog" static.
5485         (_initialize_remote): Move initialization code from maint.c.
5486         * defs.h (watchdog): Don't declare.
5487
5488 2019-05-08  Tom Tromey  <tromey@adacore.com>
5489
5490         * tui/tui-interp.c: Include main.h.
5491         * interps.c: Include main.h.
5492         * main.h (interpreter_p): Declare.
5493         * defs.h (interpreter_p): Don't declare.
5494
5495 2019-05-08  Tom Tromey  <tromey@adacore.com>
5496
5497         * dwarf2loc.c: Include dwarf2read.h.
5498         * defs.h (read_unsigned_leb128): Don't declare.
5499         * dwarf2read.h (read_unsigned_leb128): Declare.
5500
5501 2019-05-08  Tom Tromey  <tromey@adacore.com>
5502
5503         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5504         method.
5505
5506 2019-05-08  Tom Tromey  <tromey@adacore.com>
5507
5508         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5509         when no wrap column is set.
5510
5511 2019-05-08  Tom Tromey  <tromey@adacore.com>
5512
5513         * c-lang.c (c_get_string): Handle non-C-style arrays.
5514
5515 2019-05-08  Tom Tromey  <tromey@adacore.com>
5516
5517         * typeprint.c (print_offset_data::update): Print the bit offset,
5518         not the number of bits remaining.
5519
5520 2019-05-08  Tom Tromey  <tromey@adacore.com>
5521
5522         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5523         padding at end of comment.
5524
5525 2019-05-08  Tom Tromey  <tromey@adacore.com>
5526
5527         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5528         Compare main types.
5529
5530 2019-05-06  Tom Tromey  <tom@tromey.com>
5531
5532         * common/scoped_mmap.c: Include common-defs.h.
5533         * common/scoped_mmap.h: Don't include config.h.
5534
5535 2019-05-04  Tom Tromey  <tom@tromey.com>
5536
5537         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5538         (struct aarch64_call_info): Add initializers.
5539         <si>: Now a std::vector.
5540         (pass_on_stack, aarch64_push_dummy_call): Update.
5541
5542 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5543             Tom Tromey  <tom@tromey.com>
5544
5545         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5546         (ppc_threads): Now a std::vector.  Now static.
5547         (hwdebug_find_thread_points_by_tid)
5548         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5549         Update.
5550
5551 2019-05-04  Tom Tromey  <tom@tromey.com>
5552
5553         * arc-tdep.c (arc_tdesc_init): Return bool.
5554
5555 2019-05-04  Tom Tromey  <tom@tromey.com>
5556
5557         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5558         Use gdb_assert_not_reached.
5559
5560 2019-05-04  Tom Tromey  <tom@tromey.com>
5561
5562         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5563         "false".
5564
5565 2019-05-04  Tom Tromey  <tom@tromey.com>
5566
5567         * arc-tdep.c (arc_tdesc_init): Use bool.
5568
5569 2019-05-04  Tom Tromey  <tom@tromey.com>
5570
5571         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5572
5573 2019-05-04  Tom Tromey  <tom@tromey.com>
5574
5575         * cli/cli-cmds.c (valid_command_p): Return bool.
5576
5577 2019-05-04  Tom Tromey  <tom@tromey.com>
5578
5579         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5580         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5581
5582 2019-05-04  Raul Tambre  <raul@tambre.ee>
5583
5584         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5585         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5586         operator for comparison.
5587
5588 2019-05-04  Tom Tromey  <tom@tromey.com>
5589
5590         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5591         (lookup_partial_symbol, print_partial_symbols)
5592         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5593         (psymbol_compare): Update.
5594         (add_psymbol_to_bcache): Clear the entire psymbol.
5595         (maintenance_check_psymtabs): Update.
5596         * psympriv.h (struct partial_symbol): Don't derive from
5597         general_symbol_info.
5598         <obj_section, unrelocated_address, address,
5599         set_unrelocated_address>: Update.
5600         <ginfo>: New member.
5601         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5602         (debug_names::write_psymbols): Update.
5603
5604 2019-05-04  Tom de Vries  <tdevries@suse.de>
5605
5606         * contrib/cc-with-tweaks.sh: Support -n arg.
5607
5608 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5609
5610         * corelow.c (core_target::detach): Ensure frame cache and
5611         register caches are cleared.
5612         inferior.c (exit_inferior_1): Likewise.
5613
5614 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5615             Tom Tromey  <tom@tromey.com>
5616
5617         * dictionary.c (collate_pending_symbols_by_language): Remove
5618         "struct" from foreach.
5619         * symtab.c (lookup_global_symbol_from_objfile)
5620         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5621         foreach.
5622         * ser-tcp.c (net_open): Remove "struct" from foreach.
5623         * objfiles.c (objfile_relocate, objfile_rebase)
5624         (objfile_has_symbols): Remove "struct" from foreach.
5625         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5626         from foreach.
5627         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5628         foreach.
5629         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5630         "struct" from foreach.
5631         * ada-lang.c (create_excep_cond_exprs)
5632         (ada_exception_catchpoint_cond_string): Remove "struct" from
5633         foreach.
5634
5635 2019-05-03  Tom Tromey  <tromey@adacore.com>
5636
5637         * ada-exp.y (convert_char_literal): Check suffix of each
5638         enumerator.
5639
5640 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5641
5642         PR ada/21406:
5643         * ada-exp.y (yywrap): Don't define.
5644         * ada-lex.l (%option): Add noyywrap
5645         (yywrap): Remove.
5646
5647 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5648
5649         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5650         _WIN32_WINNT to the XP level, unless already defined to a higher
5651         level.
5652
5653         * unittests/parse-connection-spec-selftests.c:
5654         * ser-tcp.c:
5655         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5656         override.
5657
5658         * symfile.c (find_separate_debug_file): Remove colon from the
5659         drive spec of DOS/Windows file names of the target, so that the
5660         file name produced from DEBUGDIR and the target's directory will
5661         be valid on DOS/Windows systems.
5662
5663 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5664
5665         * rust-lang.c (val_print_struct): Handle printing structures
5666         containing strings.
5667
5668 2019-05-02  Tom Tromey  <tromey@adacore.com>
5669
5670         * valarith.c (_initialize_valarith): Remove.
5671
5672 2019-05-01  Tom Tromey  <tromey@adacore.com>
5673
5674         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5675         bitfields.
5676
5677 2019-05-01  Tom Tromey  <tromey@adacore.com>
5678
5679         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5680         for big-endian copies.
5681
5682 2019-04-30  Ali Tamur  <tamur@google.com>
5683         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5684         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5685         (read_3_bytes): New function.
5686
5687 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5688
5689         * windows-nat.c (main_thread_id): Delete.
5690         (handle_output_debug_string): Replace main_thread_id by
5691         current_event.dwThreadId.
5692         (fake_create_process): Likewise.
5693         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5694         Do not set main_thread_id.
5695         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5696         current_event.dwThreadId.
5697         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5698
5699 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5700
5701         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5702         Use current_event.dwThreadId instead of main_thread_id.
5703
5704 2019-04-30  Tom Tromey  <tromey@adacore.com>
5705
5706         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5707         (create_excep_cond_exprs): Iterate over program spaces.
5708         (ada_exception_catchpoint_cond_string): Examine all minimal
5709         symbols for exception types.
5710
5711 2019-04-30  Tom Tromey  <tromey@adacore.com>
5712
5713         PR c++/24470:
5714         * dwarf2read.c (process_structure_scope): Handle case where type
5715         has template parameters but no symbol was created.
5716
5717 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5718             Chris January  <chris.january@arm.com>
5719
5720         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5721         qualifier.
5722         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5723
5724 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * f-typeprint.c (f_print_type): Update rules for printing
5727         whitespace.
5728         (f_type_print_varspec_suffix): Likewise.
5729
5730 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5731             Chris January  <chris.january@arm.com>
5732
5733         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5734         function arguments.
5735
5736 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5737
5738         * f-lang.c (build_fortran_types): Change name of void type to
5739         lower case.
5740         * f-typeprint.c (f_type_print_base): Print the name of the void
5741         type, rather than a fixed string.
5742         * f-valprint.c (f_decorations): Use lower case void string.
5743
5744 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5745             Chris January  <chris.january@arm.com>
5746
5747         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5748         types for Fortran.
5749
5750 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5751             Chris January  <chris.january@arm.com>
5752             David Lecomber  <david.lecomber@arm.com>
5753
5754         * f-exp.y (BINOP_INTRINSIC): New token.
5755         (exp): New parser rule handling BINOP_INTRINSIC.
5756         (f77_keywords): Add new builtin procedures.
5757         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5758         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5759         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5760         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5761         (print_unop_subexp_f): New function.
5762         (print_binop_subexp_f): New function.
5763         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5764         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5765         (dump_subexp_body_f): Likewise.
5766         (operator_check_f): Likewise.
5767         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5768         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5769
5770 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5771
5772         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5773         UNOP_KIND.
5774         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5775         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5776         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5777         (operator_length_f): New fuction.
5778         (print_subexp_f): New function.
5779         (op_name_f): New function.
5780         (dump_subexp_body_f): New function.
5781         (operator_check_f): New function.
5782         (exp_descriptor_f): Replace standard expression handling functions
5783         with new functions.
5784         * gdb/fortran-operator.def: New file.
5785         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5786         * gdb/std-operator.def: Remove UNOP_KIND.
5787
5788 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5789
5790         * std-operator.def: Remove unbalanced, stray double quote
5791         character.
5792
5793 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5794             Chris January  <chris.january@arm.com>
5795             Daniel Everett  <daniel.everett@arm.com>
5796             Nick Forrington  <nick.forrington@arm.com>
5797             Richard Bunt  <richard.bunt@arm.com>
5798
5799         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5800         of depth when printing anonymous structs or unions.
5801         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5802         Don't print either the top-level value, or the children if the
5803         max-depth is exceeded.
5804         (ppscm_print_children): When printing the key of a map, allow one
5805         extra level of depth.
5806         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5807         print either the top-level value, or the children if the max-depth
5808         is exceeded.
5809         (print_children): When printing the key of a map, allow one extra
5810         level of depth.
5811         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5812         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5813         (user_print_options): Initialise max_depth field.
5814         (val_print_scalar_or_string_type_p): New function.
5815         (val_print): Check to see if the max depth has been reached.
5816         (val_print_check_max_depth): Define new function.
5817         (show_print_max_depth): New function.
5818         (_initialize_valprint): Add 'print max-depth' option.
5819         * valprint.h (struct value_print_options) <max_depth>: New field.
5820         (val_print_check_max_depth): Declare new function.
5821         * NEWS: Document new feature.
5822
5823 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * ada-lang.c (ada_language_defn): Initialise new field.
5826         * c-lang.c (c_is_string_type_p): New function.
5827         (c_language_defn): Initialise new field.
5828         (cplus_language_defn): Initialise new field.
5829         (asm_language_defn): Initialise new field.
5830         (minimal_language_defn): Initialise new field.
5831         * c-lang.h (c_is_string_type_p): Declare new function.
5832         * d-lang.c (d_language_defn): Initialise new field.
5833         * f-lang.c (f_is_string_type_p): New function.
5834         (f_language_defn): Initialise new field.
5835         * go-lang.c (go_is_string_type_p): New function.
5836         (go_language_defn): Initialise new field.
5837         * language.c (default_is_string_type_p): New function.
5838         (unknown_language_defn): Initialise new field.
5839         (auto_language_defn): Initialise new field.
5840         * language.h (struct language_defn) <la_is_string_type_p>: New
5841         member variable.
5842         (default_is_string_type_p): Declare new function.
5843         * m2-lang.c (m2_language_defn): Initialise new field.
5844         * objc-lang.c (objc_language_defn): Initialise new field.
5845         * opencl-lang.c (opencl_language_defn): Initialise new field.
5846         * p-lang.c (pascal_is_string_type_p): New function.
5847         (pascal_language_defn): Initialise new field.
5848         * rust-lang.c (rust_is_string_type_p): New function.
5849         (rust_language_defn): Initialise new field.
5850
5851 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5852
5853         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5854         New field.
5855         * ada-lang.c (ada_language_defn): Initialise new field.
5856         * c-lang.c (c_language_defn): Likewise.
5857         (cplus_language_defn): Likewise.
5858         (asm_language_defn): Likewise.
5859         (minimal_language_defn): Likewise.
5860         * d-lang.c (d_language_defn): Likewise.
5861         * f-lang.c (f_language_defn): Likewise.
5862         * go-lang.c (go_language_defn): Likewise.
5863         * language.c (unknown_language_defn): Likewise.
5864         (auto_language_defn): Likewise.
5865         * m2-lang.c (m2_language_defn): Likewise.
5866         * objc-lang.c (objc_language_defn): Likewise.
5867         * opencl-lang.c (opencl_language_defn): Likewise.
5868         * p-lang.c (pascal_language_defn): Likewise.
5869         * rust-lang.c (rust_language_defn): Likewise.
5870
5871 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5872
5873         * ada-lang.c (ada_is_character_type): Change return type to bool.
5874         (ada_is_string_type): Likewise.
5875         * ada-lang.h (ada_is_character_type): Update declaration
5876         (ada_is_string_type): Likewise.
5877
5878 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5879
5880         Support style in 'frame|thread apply'
5881
5882         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5883         * record.c (record_start, record_stop): Update callers of
5884         execute_command_to_string with false.
5885         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5886         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5887         methods.
5888         (class string_file): New constructor with term_out parameter.
5889         Override methods term_out and can_emit_style_escape.  New member
5890         term_out.
5891         (class stdio_file): Override can_emit_style_escape.
5892         (class tee_file): Override term_out and can_emit_style_escape.
5893         * utils.h (can_emit_style_escape): Remove.
5894         * utils.c (can_emit_style_escape): Likewise.
5895         Update all callers of can_emit_style_escape (SOMESTREAM) to
5896         SOMESTREAM->can_emit_style_escape.
5897         * source-cache.c (source_cache::get_source_lines): Likewise.
5898         * stack.c (frame_apply_command_count): Call execute_command_to_string
5899         passing the term_out characteristic of the current gdb_stdout.
5900         * thread.c (thr_try_catch_cmd): Likewise.
5901         * top.c (execute_command_to_string): pass term_out parameter
5902         to construct the string_file for the command output.
5903         * ui-file.c (term_cli_styling): New function (most code moved
5904         from utils.c can_emit_style_escape).
5905         (string_file::string_file, string_file::can_emit_style_escape,
5906         stdio_file::can_emit_style_escape, tee_file::term_out,
5907         tee_file::can_emit_style_escape): New functions.
5908
5909 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5910
5911         * NEWS: Mention the new set|show may-call-functions.
5912         * infcall.c (may_call_functions_p): New variable.
5913         (show_may_call_functions_p): New function.
5914         (call_function_by_hand_dummy): Throws an error if not
5915         may-call-functions.
5916         (_initialize_infcall): Call add_setshow_boolean_cmd for
5917         may-call-functions.
5918
5919 2019-04-25  Keith Seitz  <keiths@redhat.com>
5920
5921         PR c++/24367
5922         * cp-support.c (inspect_type): Don't attempt substitutions
5923         of symbol with the same name.
5924
5925 2019-04-25  Tom Tromey  <tromey@adacore.com>
5926
5927         PR gdb/24475:
5928         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5929         static.
5930
5931 2019-04-25  Tom Tromey  <tromey@adacore.com>
5932
5933         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5934         rvalue reference.
5935         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5936         (gdb_xml_parser::parse): Use std::move.
5937         * python/python-internal.h (gdbpy_convert_exception): Take a const
5938         reference.
5939         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5940         std::move.
5941         * python/py-utils.c (gdbpy_convert_exception): Take a const
5942         reference.
5943         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5944         Use std::move.
5945         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5946         Use std::move.
5947         * mi/mi-main.c (mi_print_exception): Take a const reference.
5948         * main.c (handle_command_errors): Take a const reference.
5949         * linespec.c (parse_linespec): Use std::move.
5950         * infcall.c (run_inferior_call): Use std::move.
5951         (call_function_by_hand_dummy): Use std::move.
5952         * exec.c (try_open_exec_file): Use std::move.
5953         * exceptions.h (exception_print, exception_fprintf)
5954         (exception_print_same): Update.
5955         * exceptions.c (print_exception, exception_print)
5956         (exception_fprintf, exception_print_same): Change parameters to
5957         const reference.
5958         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5959         * common/new-op.c: Use std::move.
5960         * common/common-exceptions.h (struct gdb_exception): Add move
5961         constructor.
5962         (struct gdb_exception_error, struct gdb_exception_quit, struct
5963         gdb_quit_bad_alloc): Change constructor to move constructor.
5964         (throw_exception): Change parameter to rvalue reference.
5965         * common/common-exceptions.c (throw_exception): Take rvalue
5966         reference.
5967         * cli/cli-interp.c (safe_execute_command): Use std::move.
5968         * breakpoint.c (insert_bp_location, location_to_sals): Use
5969         std::move.
5970
5971 2019-04-25  Tom Tromey  <tromey@adacore.com>
5972
5973         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5974         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5975         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5976         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5977         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5978         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5979         guile/scm-value.c: Use unpack.
5980         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5981         gdbscm_gdb_exception.
5982         (gdbscm_throw_gdb_exception): Likewise.
5983         (struct gdbscm_gdb_exception): New.
5984         (unpack): New function.
5985         (gdbscm_wrap): Use unpack.
5986
5987 2019-04-25  Tom Tromey  <tromey@adacore.com>
5988
5989         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5990         (gdb_rl_callback_handler): Use std::move.
5991         * common/common-exceptions.h (struct gdb_exception): Add move
5992         assignment operator.
5993         (throw_exception_sjlj): Change "exception" to const reference.
5994         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5995         (throw_exception_sjlj): Change "exception" to const reference.
5996
5997 2019-04-25  Tom Tromey  <tromey@adacore.com>
5998
5999         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6000         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6001         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6002         Update.
6003         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6004         Update.
6005         * mi/mi-interp.c (mi_interp::exec): Update.
6006         * linespec.c (parse_linespec): Update.
6007         * infcall.c (run_inferior_call): Update.
6008         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6009         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6010         (gdbscm_lookup_global_symbol): Update.
6011         * guile/scm-param.c (gdbscm_parameter_value): Update.
6012         * guile/scm-frame.c (gdbscm_frame_read_register)
6013         (gdbscm_frame_read_var): Update.
6014         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6015         * exec.c (try_open_exec_file): Update.
6016         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6017         (gdb_rl_callback_handler): Update.
6018         * common/common-exceptions.h (exception_none): Don't declare.
6019         * common/common-exceptions.c (exception_none): Don't define.
6020         (struct catcher) <exception>: Update.
6021         * cli/cli-interp.c (safe_execute_command): Update.
6022         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6023
6024 2019-04-25  Ali Tamur  <tamur@google.com>
6025
6026         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6027         (read_attribute_value): Likewise.
6028         (dwarf2_read_addr_index): Update comment.
6029         (read_str_index): Add DW_FORM_strx.
6030         (dwarf2_string_attr): Likewise.
6031         (dwarf2_const_value_attr): Likewise.
6032         (dump_die_shallow): Likewise.
6033         (dwarf2_fetch_constant_bytes): Likewise.
6034         (skip_form_bytes): Likewise.
6035         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6036
6037 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6038
6039         PR corefiles/11608
6040         PR corefiles/18187
6041         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6042         OFFSET.  Verify if current mapping contains an ELF header.
6043         (linux_find_memory_regions_full): Adjust call to
6044         dump_mapping_p.
6045
6046 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6047             Kang Li <kanglictf@gmail.com>
6048
6049         PR gdb/21600
6050
6051         * dwarf2-frame.c (read_initial_length): Be consistent about using
6052         unsigned representation of length.
6053         (decode_frame_entry_1): Likewise.  Check for wraparound of
6054         end pointer as well as buffer overflow.
6055
6056 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6057
6058         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6059         "vq".
6060
6061 2019-04-24  Tom Tromey  <tromey@adacore.com>
6062
6063         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6064
6065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * s12z-tdep.c (s12z_unwind_pc): Delete.
6068         (s12z_unwind_sp): Delete.
6069         (s12z_gdbarch_init): Don't register deleted functions with
6070         gdbarch.
6071
6072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6073
6074         * rl78-tdep.c (rl78_unwind_sp): Delete.
6075         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6076
6077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6078
6079         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6080         (xstormy16_unwind_pc): Delete.
6081         (xstormy16_dummy_id): Delete.
6082         (xstormy16_gdbarch_init): Don't register deleted functions with
6083         gdbarch.
6084
6085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * vax-tdep.c (vax_unwind_pc): Delete.
6088         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6089
6090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * v850-tdep.c (v850_unwind_sp): Delete.
6093         (v850_unwind_pc): Delete.
6094         (v850_dummy_id): Delete.
6095         (v850_gdbarch_init): Don't register deleted functions with
6096         gdbarch.
6097
6098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6099
6100         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6101         (tilegx_unwind_pc): Delete.
6102         (tilegx_unwind_dummy_id): Delete.
6103         (tilegx_gdbarch_init): Don't register deleted functions with
6104         gdbarch.
6105
6106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6107
6108         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6109         (tic6x_dummy_id): Delete.
6110         (tic6x_gdbarch_init): Don't register deleted functions with
6111         gdbarch.
6112
6113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6114
6115         * sparc-tdep.c (sparc_unwind_pc): Delete.
6116         (sparc32_gdbarch_init): Don't register deleted function with
6117         gdbarch.
6118
6119 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6120
6121         * sh-tdep.c (sh_unwind_sp): Delete.
6122         (sh_unwind_pc): Delete.
6123         (sh_dummy_id): Delete.
6124         (sh_gdbarch_init): Don't register deleted functions with
6125         gdbarch.
6126
6127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6128
6129         * score-tdep.c (score_unwind_sp): Delete.
6130         (score_unwind_pc): Delete.
6131         (score_dummy_id): Delete.
6132         (score_gdbarch_init): Don't register deleted functions with
6133         gdbarch.
6134
6135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6136
6137         * rx-tdep.c (rx_unwind_pc): Delete.
6138         (rx_unwind_sp): Delete.
6139         (rx_dummy_id): Delete.
6140         (rx_gdbarch_init): Don't register deleted functions with
6141         gdbarch.  Update comment.
6142
6143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6146         (rs6000_dummy_id): Delete.
6147         (rs6000_gdbarch_init): Don't register deleted functions with
6148         gdbarch.
6149
6150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6151
6152         * or1k-tdep.c (or1k_dummy_id): Delete.
6153         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6154
6155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6156
6157         * nios2-tdep.c (nios2_dummy_id): Delete.
6158         (nios2_unwind_sp): Delete.
6159         (nios2_gdbarch_init): Don't register deleted functions with
6160         gdbarch.
6161
6162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6163
6164         * nds32-tdep.c (nds32_dummy_id): Delete.
6165         (nds32_unwind_pc): Delete.
6166         (nds32_unwind_sp): Delete.
6167         (nds32_gdbarch_init): Don't register deleted functions with
6168         gdbarch.
6169
6170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6171
6172         * msp430-tdep.c (msp430_unwind_pc): Delete.
6173         (msp430_unwind_sp): Delete.
6174         (msp430_dummy_id): Delete.
6175         (msp430_gdbarch_init): Don't register deleted functions with
6176         gdbarch.
6177
6178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * moxie-tdep.c (moxie_unwind_sp): Delete.
6181         (moxie_unwind_pc): Delete.
6182         (moxie_dummy_id): Delete.
6183         (moxie_gdbarch_init): Don't register deleted functions with
6184         gdbarch.
6185
6186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6189         (mn10300_unwind_pc): Delete.
6190         (mn10300_unwind_sp): Delete.
6191         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6192         mn10300_unwind_sp.
6193         (mn10300_frame_unwind_init): Don't register deleted functions with
6194         gdbarch.
6195
6196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6197
6198         * mep-tdep.c (mep_unwind_pc): Delete.
6199         (mep_unwind_sp): Delete.
6200         (mep_dummy_id): Delete.
6201         (mep_gdbarch_init): Don't register deleted functions with
6202         gdbarch.
6203
6204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6205
6206         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6207         (m68hc11_unwind_sp): Delete.
6208         (m68hc11_gdbarch_init): Don't register deleted functions with
6209         gdbarch.
6210
6211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * m32r-tdep.c (m32r_unwind_sp): Delete.
6214         (m32r_unwind_pc): Delete.
6215         (m32r_dummy_id): Delete.
6216         (m32r_gdbarch_init): Don't register deleted functions with
6217         gdbarch.
6218
6219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6220
6221         * m32c-tdep.c (m32c_unwind_pc): Delete.
6222         (m32c_unwind_sp): Delete.
6223         (m32c_dummy_id): Delete.
6224         (m32c_gdbarch_init): Don't register deleted functions with
6225         gdbarch.
6226
6227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6230         (lm32_unwind_pc): Delete.
6231         (lm32_dummy_id): Delete.
6232         (lm32_gdbarch_init): Don't register deleted functions with
6233         gdbarch.
6234
6235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6236
6237         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6238         (iq2000_unwind_pc): Delete.
6239         (iq2000_dummy_id): Delete.
6240         (iq2000_gdbarch_init): Don't register deleted functions with
6241         gdbarch.
6242
6243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6244
6245         * nds32-tdep.c (nds32_type_align): Delete.
6246         (nds32_push_dummy_call): Use type_align instead.
6247
6248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6249
6250         * arm-tdep.c (arm_type_align): Only handle vector override case.
6251         (arm_push_dummy_call): Use type_align.
6252         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6253
6254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6255
6256         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6257         case.
6258         (pass_on_stack): Use type_align.
6259         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6260         function.
6261
6262 2019-04-23  Tom Tromey  <tromey@adacore.com>
6263
6264         * dwarf2read.c (line_header::file_name_at): Remove unused
6265         overload.
6266
6267 2019-04-23  Tom de Vries  <tdevries@suse.de>
6268
6269         PR gdb/24438
6270         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6271         invocation.
6272
6273
6274 2019-03-27  Ali Tamur  <tamur@google.com>
6275
6276         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6277         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6278         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6279         (dwarf_expr_context::get_addr_index): Likewise
6280         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6281         (symbol_needs_eval_context::get_addr_index): Likewise
6282         (disassemble_dwarf_expression): Add DW_OP_addrx
6283         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6284         (read_cutu_die_from_dwo): Update comment
6285         (skip_one_die): Add DW_FORM_addrx
6286         (read_attribute_value): Likewise
6287         (var_decode_location): Add DW_OP_addrx
6288         (dwarf2_const_value_attr): Add DW_FORM_addrx
6289         (dump_die_shallow): Likewise
6290         (dwarf2_fetch_constant_bytes): Likewise
6291         (decode_locdesc): Add DW_OP_addrx
6292         (skip_form_bytes): Add DW_FORM_addrx
6293
6294 2019-04-22  Ali Tamur  <tamur@google.com>
6295
6296         * MAINTAINERS (Write After Approval): Add self.
6297
6298 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6299
6300         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6301         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6302         (open_symbol_file_object): Likewise.
6303         (svr4_default_sos): Add info parameter.
6304         (svr4_read_so_list): Likewise.
6305         (svr4_current_sos_direct): Adjust functions calls to pass down
6306         info.
6307         (svr4_current_sos_1): Add info parameter.
6308         (svr4_current_sos): Call get_svr4_info, pass info down to
6309         svr4_current_sos_1.
6310         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6311         get_svr4_info.
6312         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6313         get_svr4_info.
6314         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6315         to get_svr4_info.
6316         (probes_table_remove_objfile_probes): Likewise.
6317         (register_solib_event_probe): Add info parameter.
6318         (solist_update_incremental): Pass info parameter down to
6319         svr4_read_so_list.
6320         (disable_probes_interface): Add info parameter.
6321         (svr4_handle_solib_event): Pass current_program_space to
6322         get_svr4_info.  Adjust disable_probes_interface cleanup.
6323         (svr4_create_probe_breakpoints): Add info parameter, pass it
6324         down to register_solib_event_probe.
6325         (svr4_create_solib_event_breakpoints): Add info parameter,
6326         pass it down to svr4_create_probe_breakpoints.
6327         (enable_break): Pass info down to
6328         svr4_create_solib_event_breakpoints.
6329         (svr4_solib_create_inferior_hook): Pass current_program_space to
6330         get_svr4_info.
6331         (svr4_clear_solib): Likewise.
6332
6333 2019-04-22  Pedro Alves  <palves@redhat.com>
6334
6335         * solib-svr4.c (svr4_free_objfile_observer): New.
6336         (probe_and_action::objfile): New field.
6337         (probes_table_htab_remove_objfile_probes)
6338         (probes_table_remove_objfile_probes): New functions.
6339         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6340         in the new probe_and_action.  Don't store the probe in 'lookup'.
6341         (svr4_create_probe_breakpoints): Pass objfile to
6342         register_solib_event_probe.
6343         (_initialize_svr4_solib): Register a free_objfile observer.
6344
6345 2019-04-19  Tom Tromey  <tom@tromey.com>
6346
6347         * common/queue.h: Remove.
6348
6349 2019-04-19  Tom Tromey  <tom@tromey.com>
6350
6351         * event-loop.c: Don't include "common/queue.h".
6352
6353 2019-04-19  Tom Tromey  <tom@tromey.com>
6354
6355         * remote.c (remote_target): Use delete.
6356         * remote-notif.h: Include <list>, not "common/queue.h".
6357         (notif_client_p): Remove typedef.
6358         (remote_notif_state): Add constructor, destructor, initializer.
6359         <notif_queue>: Now a std::list.
6360         (remote_notif_state_xfree): Don't declare.
6361         * remote-notif.c (remote_notif_process, handle_notification)
6362         (remote_notif_state_allocate): Update.
6363         (~remote_notif_state): Rename from remote_notif_state_xfree.
6364
6365 2019-04-19  Tom Tromey  <tom@tromey.com>
6366
6367         * symfile.c (reread_symbols): Update.
6368         * objfiles.c (objfile_register_static_link)
6369         (objfile_lookup_static_link): Update
6370         (~objfile) Don't delete static_links.
6371         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6372
6373 2019-04-19  Tom Tromey  <tom@tromey.com>
6374
6375         * type-stack.h (struct type_stack) <insert>: Constify string.
6376         * type-stack.c (type_stack::insert): Constify string.
6377         * gdbtypes.h (lookup_template_type): Update.
6378         (address_space_name_to_int): Update.
6379         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6380         const.
6381         (lookup_template_type): Make name const.
6382         * c-exp.y: Update rules.
6383         (lex_one_token, classify_name, classify_inner_name)
6384         (c_print_token): Update.
6385         * p-exp.y: Update rules.
6386         (yylex): Update.
6387         * f-exp.y: Update rules.
6388         (yylex): Update.
6389         * d-exp.y: Update rules.
6390         (lex_one_token, classify_name, classify_inner_name): Update.
6391         * parse.c (write_dollar_variable, copy_name): Return std::string.
6392         * parser-defs.h (copy_name): Change return type.
6393         * m2-exp.y: Update rules.
6394         (yylex): Update.
6395         * go-exp.y (lex_one_token): Update.
6396         Update rules.
6397         (classify_unsafe_function, classify_packaged_name)
6398         (classify_name, yylex): Update.
6399
6400 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6401
6402         * configure.ac: add --enable-source-highlight switch.
6403         * configure: Regenerate.
6404         * top.c (print_gdb_version): plumb --enable-source-highlight
6405         status to "show configuration".
6406
6407 2019-04-19  Tom Tromey  <tromey@adacore.com>
6408
6409         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6410         Check ADA_TYPE_P.
6411         (empty_record, ada_template_to_fixed_record_type_1)
6412         (template_to_static_fixed_type)
6413         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6414         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6415         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6416         macros.
6417
6418 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6419
6420         PR symtab/24423:
6421         * source.c (print_source_lines_base): Advance "iter" when a
6422         control character is seen.
6423
6424 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6425
6426         * inferior.h (struct infcall_suspend_state_deleter):
6427         Catch exception in destructor to avoid crash.
6428
6429 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6430
6431         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6432         close to the add_com "shell".
6433
6434 2019-04-18  Tom Tromey  <tromey@adacore.com>
6435
6436         * process-stratum-target.h (class process_stratum_target)
6437         <stratum>: Add "final".
6438
6439 2019-04-17  Tom Tromey  <tromey@adacore.com>
6440
6441         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6442         against nullptr before use.
6443
6444 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6445
6446         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6447
6448 2019-04-17  Jim Wilson  <jimw@sifive.com>
6449             Andrew Burgess  <andrew.burgess@embecosm.com>
6450
6451         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6452         code read might fail, assume 4-byte breakpoint in that case.
6453
6454 2019-04-15  Leszek Swirski  <leszeks@google.com>
6455
6456         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6457         rather than a hand-rolled POD check when checking for forced MEMORY
6458         classification.
6459
6460 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6461
6462         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6463         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6464         function.
6465         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6466         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6467         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6468         declaration.
6469
6470 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6471
6472         * aarch64-linux-nat.c
6473         (aarch64_linux_nat_target::thread_architecture): Add override.
6474         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6475         each VQ.
6476
6477 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6478
6479         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6480
6481 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6482
6483         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6484         target types of size 96-bits, add some additional comments, and
6485         check that the builtin type we found was the correct size.
6486
6487 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6488
6489         * utils.c (prompt_for_continue): Don't restore the styling at the
6490         end, as applied_style has the wrong value.  This fixes styling in
6491         long lists of file names that are interrupted by the "Continue?"
6492         prompt.
6493
6494 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6495
6496         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6497         * c-lang.c (c_language_defn): Likewise.
6498         (cplus_language_defn): Likewise.
6499         (asm_language_defn): Likewise.
6500         (minimal_language_defn): Likewise.
6501         * d-lang.c (d_language_defn): Likewise.
6502         * f-lang.c (f_language_defn): Likewise.
6503         * go-lang.c (go_language_defn): Likewise.
6504         * language.c (unknown_language_defn): Likewise.
6505         (auto_language_defn): Likewise.
6506         * language.h (struct language_defn): Remove la_magic field.
6507         (LANG_MAGIC): Delete.
6508         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6509         * objc-lang.c (objc_language_defn): Likewise.
6510         * opencl-lang.c (opencl_language_defn): Likewise.
6511         * p-lang.c (pascal_language_defn): Likewise.
6512         * rust-lang.c (rust_language_defn): Likewise.
6513
6514 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * riscv-tdep.c (riscv_type_align): New function.
6517         (riscv_type_alignment): Delete.
6518         (riscv_arg_location): Use 'type_align'.
6519         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6520
6521 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6522
6523         * gdbtypes.c (type_align): A struct with no non-static fields also
6524         has alignment of 1.
6525
6526 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6529         component to 0.
6530         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6531         member.
6532         (riscv_struct_info::analyse): New implementation using new
6533         analyse_inner member function.
6534         (riscv_struct_info::field_offset): New member function.
6535         (riscv_struct_info::m_offsets): New member variable.
6536         (riscv_struct_info::analyse_inner): New private member function,
6537         takes the old implementation of riscv_struct_info::analyse but
6538         extended to track field offsets.
6539         (riscv_call_arg_struct): Update the struct folding special cases
6540         to handle cases where empty C++ structs, which are non-zero
6541         length, are found.
6542         (riscv_arg_location): Initialise the length of each location, a
6543         non-zero length now indicates the location is in use.
6544         (riscv_push_dummy_call): Allow for the first location having a
6545         non-zero offset when setting up arguments.
6546         (riscv_return_value): Likewise, but for return values.
6547
6548 2019-04-11  Tom Tromey  <tromey@adacore.com>
6549
6550         * utils.c (internal_vproblem): Make "msg" const.
6551
6552 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6553
6554         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6555         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6556         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6557         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6558
6559 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6560
6561         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6562         function.
6563         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6564         of amd64_collect_native_gregset.
6565         (amd64_linux_nat_target::store_registers): Likewise.
6566
6567 2019-04-10  Tom Tromey  <tom@tromey.com>
6568
6569         * symtab.c (lookup_global_symbol_from_objfile)
6570         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6571         * objfiles.h (class separate_debug_iterator): New.
6572         (class separate_debug_range): New.
6573         (struct objfile) <separate_debug_objfiles>: New method.
6574         (objfile_separate_debug_iterate): Don't declare.
6575         * objfiles.c (separate_debug_iterator::operator++): Rename from
6576         objfile_separate_debug_iterate.
6577         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6578         iterator.
6579         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6580         iterator.
6581
6582 2019-04-10  Tom Tromey  <tom@tromey.com>
6583
6584         * symfile.c (reread_symbols): Remove old comment.
6585         * objfiles.c (free_all_objfiles): Fix a typo.
6586
6587 2019-04-10  Tom Tromey  <tom@tromey.com>
6588
6589         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6590         * minsyms.c (lookup_minimal_symbol): Use foreach.
6591         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6592         (lookup_minimal_symbol_solib_trampoline): Likewise.
6593         * symfile.c (reread_symbols): Use foreach.
6594
6595 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6596             Tom Tromey  <tromey@adacore.com>
6597
6598         PR rust/24414:
6599         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6600         (rust_lex_int_test): Change "value" to be LONGEST.
6601         (rust_lex_tests): Add test for long integer literal.
6602
6603 2019-04-09  Tom Tromey  <tromey@adacore.com>
6604
6605         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6606         to bool.
6607         (extended_remote_target::attach): Update.
6608         (remote_target::remote_notice_new_inferior): Update.
6609         (remote_target::add_current_inferior_and_thread): Update.
6610         * inferior.c (exit_inferior_1): Use "false".
6611         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6612
6613 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6614
6615         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6616         the "start" command.
6617
6618 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6619
6620         * python/py-inferior.c (infpy_thread_from_thread_handle):
6621         Adjust comments to reflect renaming of thread_from_thread_handle
6622         to thread_from_handle.  Adjust keywords.  Fix type error message.
6623         (inferior_object_methods): Add thread_from_handle.  Retain
6624         thread_from_thread_handle, but mark it as deprecated.
6625
6626 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6627
6628         * gdbthread.h (find_thread_by_handle): Revise declaration.
6629         * thread.c (find_thread_by_handle): Likewise.  Adjust
6630         implementation too.
6631         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6632         support for buffer objects as handles.
6633
6634 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6635
6636         * python/py-infthread.c (thpy_thread_handle): New function.
6637         (thread_object_methods): Register thpy_thread_handle.
6638
6639 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6640
6641         * gdbthread.h (thread_to_thread_handle): Declare.
6642         * thread.c (gdbtypes.h): Include.
6643         (thread_to_thread_handle): New function.
6644
6645         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6646         (target_thread_info_to_thread_handle): Declare.
6647         * target.c (target_thread_info_to_thread_handle): New function.
6648         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6649         * target-delegates.c: Regenerate.
6650
6651         * linux-thread-db.c (class thread_db_target): Add method
6652         thread_info_to_thread_handle.
6653         (thread_db_target::thread_info_to_thread_handle): Define.
6654         * remote.c (class remote_target): Add new method
6655         thread_info_to_thread_handle.
6656         (remote_target::thread_info_to_thread_handle): Define.
6657
6658 2019-04-08  Pedro Alves  <palves@redhat.com>
6659
6660         * common/common-exceptions.c (throw_exception): Don't create
6661         named object to throw; throw directly.
6662         (throw_it): Likewise.  Don't initialize gdb_exception::message
6663         here, with new; pass FMT and AP to the ctor instead.
6664         * common/common-exceptions.h: Include <string>.
6665         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6666         const char *, va_list)): New ctor.  Use std::make_shared.
6667         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6668         errors)): Delete.
6669         (gdb_exception_error::gdb_exception_error(enum errors, const char
6670         *, va_list)): New.
6671         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6672         Add assertion.
6673         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6674         errors)): Delete.
6675         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6676         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6677         Add assertion.
6678
6679 2019-04-08  Tom Tromey  <tom@tromey.com>
6680
6681         * valops.c (value_rtti_indirect_type): Replace throw_exception
6682         with throw.
6683         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6684         with throw.
6685         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6686         throw.
6687         * target.c (target_translate_tls_address): Replace throw_exception
6688         with throw.
6689         * stack.c (frame_apply_command_count): Replace throw_exception
6690         with throw.
6691         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6692         throw.
6693         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6694         with throw.
6695         * rs6000-tdep.c (rs6000_frame_cache)
6696         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6697         * remote.c: Replace throw_exception with throw.
6698         * record-full.c (record_full_message, record_full_wait_1)
6699         (record_full_restore): Replace throw_exception with throw.
6700         * record-btrace.c:
6701         (get_thread_current_frame_id, record_btrace_start_replaying)
6702         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6703         (cmd_record_btrace_start): Replace throw_exception with throw.
6704         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6705         throw.
6706         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6707         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6708         * linespec.c:
6709         (find_linespec_symbols): Replace throw_exception with throw.
6710         * infrun.c (displaced_step_prepare, resume): Replace
6711         throw_exception with throw.
6712         * infcmd.c (post_create_inferior): Replace throw_exception with
6713         throw.
6714         * inf-loop.c (inferior_event_handler): Replace throw_exception
6715         with throw.
6716         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6717         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6718         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6719         (get_prev_frame_always, get_frame_pc_if_available)
6720         (get_frame_address_in_block_if_available, get_frame_language):
6721         Replace throw_exception with throw.
6722         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6723         throw_exception with throw.
6724         * eval.c (fetch_subexp_value, evaluate_var_value)
6725         (evaluate_funcall, evaluate_subexp_standard): Replace
6726         throw_exception with throw.
6727         * dwarf2loc.c (call_site_find_chain)
6728         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6729         Replace throw_exception with throw.
6730         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6731         with throw.
6732         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6733         throw.
6734         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6735         * completer.c (complete_line_internal): Replace throw_exception
6736         with throw.
6737         * compile/compile-object-run.c (compile_object_run): Replace
6738         throw_exception with throw.
6739         * cli/cli-script.c (process_next_line): Replace throw_exception
6740         with throw.
6741         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6742         (btrace_enable, btrace_maint_update_pt_packets): Replace
6743         throw_exception with throw.
6744         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6745         throw_exception with throw.
6746         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6747         throw_exception with throw.
6748         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6749         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6750         * aarch64-tdep.c (aarch64_make_prologue_cache)
6751         (aarch64_make_stub_cache): Replace throw_exception with throw.
6752
6753 2019-04-08  Tom Tromey  <tom@tromey.com>
6754
6755         * common/common-exceptions.c (throw_exception): Rename from
6756         throw_exception_cxx.  Remove old copy.  Make argument const.
6757         (throw_it): Create and throw exception objects directly.
6758         * common/common-exceptions.h (throw_exception): Make argument
6759         const.
6760         (struct gdb_exception_error): Add constructor.
6761         (struct gdb_exception_quit): Add constructor.
6762
6763 2019-04-08  Tom Tromey  <tom@tromey.com>
6764
6765         * common/common-exceptions.h (exception_rethrow): Don't declare.
6766         (TRY_SJLJ): Update comment.
6767         (TRY, CATCH, END_CATCH): Remove.
6768         * common/common-exceptions.c (exception_rethrow): Remove.
6769
6770 2019-04-08  Tom Tromey  <tom@tromey.com>
6771
6772         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6773         Remove.
6774         (gdb_exception_error): Rename from
6775         gdb_exception_RETURN_MASK_ERROR.
6776         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6777         (gdb_quit_bad_alloc): Update.
6778         * aarch64-tdep.c: Update.
6779         * ada-lang.c: Update.
6780         * ada-typeprint.c: Update.
6781         * ada-valprint.c: Update.
6782         * amd64-tdep.c: Update.
6783         * arch-utils.c: Update.
6784         * break-catch-throw.c: Update.
6785         * breakpoint.c: Update.
6786         * btrace.c: Update.
6787         * c-varobj.c: Update.
6788         * cli/cli-cmds.c: Update.
6789         * cli/cli-interp.c: Update.
6790         * cli/cli-script.c: Update.
6791         * common/common-exceptions.c: Update.
6792         * common/new-op.c: Update.
6793         * common/selftest.c: Update.
6794         * compile/compile-c-symbols.c: Update.
6795         * compile/compile-cplus-symbols.c: Update.
6796         * compile/compile-object-load.c: Update.
6797         * compile/compile-object-run.c: Update.
6798         * completer.c: Update.
6799         * corelow.c: Update.
6800         * cp-abi.c: Update.
6801         * cp-support.c: Update.
6802         * cp-valprint.c: Update.
6803         * darwin-nat.c: Update.
6804         * disasm-selftests.c: Update.
6805         * dtrace-probe.c: Update.
6806         * dwarf-index-cache.c: Update.
6807         * dwarf-index-write.c: Update.
6808         * dwarf2-frame-tailcall.c: Update.
6809         * dwarf2-frame.c: Update.
6810         * dwarf2loc.c: Update.
6811         * dwarf2read.c: Update.
6812         * eval.c: Update.
6813         * event-loop.c: Update.
6814         * event-top.c: Update.
6815         * exec.c: Update.
6816         * f-valprint.c: Update.
6817         * fbsd-tdep.c: Update.
6818         * frame-unwind.c: Update.
6819         * frame.c: Update.
6820         * gdbtypes.c: Update.
6821         * gnu-v3-abi.c: Update.
6822         * guile/guile-internal.h: Update.
6823         * guile/scm-block.c: Update.
6824         * guile/scm-breakpoint.c: Update.
6825         * guile/scm-cmd.c: Update.
6826         * guile/scm-disasm.c: Update.
6827         * guile/scm-frame.c: Update.
6828         * guile/scm-lazy-string.c: Update.
6829         * guile/scm-math.c: Update.
6830         * guile/scm-param.c: Update.
6831         * guile/scm-ports.c: Update.
6832         * guile/scm-pretty-print.c: Update.
6833         * guile/scm-symbol.c: Update.
6834         * guile/scm-symtab.c: Update.
6835         * guile/scm-type.c: Update.
6836         * guile/scm-value.c: Update.
6837         * i386-linux-tdep.c: Update.
6838         * i386-tdep.c: Update.
6839         * inf-loop.c: Update.
6840         * infcall.c: Update.
6841         * infcmd.c: Update.
6842         * infrun.c: Update.
6843         * jit.c: Update.
6844         * language.c: Update.
6845         * linespec.c: Update.
6846         * linux-fork.c: Update.
6847         * linux-nat.c: Update.
6848         * linux-tdep.c: Update.
6849         * linux-thread-db.c: Update.
6850         * main.c: Update.
6851         * mi/mi-cmd-break.c: Update.
6852         * mi/mi-cmd-stack.c: Update.
6853         * mi/mi-interp.c: Update.
6854         * mi/mi-main.c: Update.
6855         * objc-lang.c: Update.
6856         * p-valprint.c: Update.
6857         * parse.c: Update.
6858         * ppc-linux-tdep.c: Update.
6859         * printcmd.c: Update.
6860         * python/py-arch.c: Update.
6861         * python/py-breakpoint.c: Update.
6862         * python/py-cmd.c: Update.
6863         * python/py-finishbreakpoint.c: Update.
6864         * python/py-frame.c: Update.
6865         * python/py-framefilter.c: Update.
6866         * python/py-gdb-readline.c: Update.
6867         * python/py-inferior.c: Update.
6868         * python/py-infthread.c: Update.
6869         * python/py-lazy-string.c: Update.
6870         * python/py-linetable.c: Update.
6871         * python/py-objfile.c: Update.
6872         * python/py-param.c: Update.
6873         * python/py-prettyprint.c: Update.
6874         * python/py-progspace.c: Update.
6875         * python/py-record-btrace.c: Update.
6876         * python/py-record.c: Update.
6877         * python/py-symbol.c: Update.
6878         * python/py-type.c: Update.
6879         * python/py-unwind.c: Update.
6880         * python/py-utils.c: Update.
6881         * python/py-value.c: Update.
6882         * python/python.c: Update.
6883         * record-btrace.c: Update.
6884         * record-full.c: Update.
6885         * remote-fileio.c: Update.
6886         * remote.c: Update.
6887         * riscv-tdep.c: Update.
6888         * rs6000-aix-tdep.c: Update.
6889         * rs6000-tdep.c: Update.
6890         * rust-exp.y: Update.
6891         * rust-lang.c: Update.
6892         * s390-tdep.c: Update.
6893         * selftest-arch.c: Update.
6894         * solib-dsbt.c: Update.
6895         * solib-frv.c: Update.
6896         * solib-spu.c: Update.
6897         * solib-svr4.c: Update.
6898         * solib.c: Update.
6899         * sparc64-linux-tdep.c: Update.
6900         * stack.c: Update.
6901         * symfile-mem.c: Update.
6902         * symmisc.c: Update.
6903         * target.c: Update.
6904         * thread.c: Update.
6905         * top.c: Update.
6906         * tracefile-tfile.c: Update.
6907         * tui/tui.c: Update.
6908         * typeprint.c: Update.
6909         * unittests/cli-utils-selftests.c: Update.
6910         * unittests/parse-connection-spec-selftests.c: Update.
6911         * valops.c: Update.
6912         * valprint.c: Update.
6913         * value.c: Update.
6914         * varobj.c: Update.
6915         * windows-nat.c: Update.
6916         * x86-linux-nat.c: Update.
6917         * xml-support.c: Update.
6918
6919 2019-04-08  Tom Tromey  <tom@tromey.com>
6920
6921         * xml-support.c: Use C++ exception handling.
6922         * x86-linux-nat.c: Use C++ exception handling.
6923         * windows-nat.c: Use C++ exception handling.
6924         * varobj.c: Use C++ exception handling.
6925         * value.c: Use C++ exception handling.
6926         * valprint.c: Use C++ exception handling.
6927         * valops.c: Use C++ exception handling.
6928         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6929         handling.
6930         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6931         * typeprint.c: Use C++ exception handling.
6932         * tui/tui.c: Use C++ exception handling.
6933         * tracefile-tfile.c: Use C++ exception handling.
6934         * top.c: Use C++ exception handling.
6935         * thread.c: Use C++ exception handling.
6936         * target.c: Use C++ exception handling.
6937         * symmisc.c: Use C++ exception handling.
6938         * symfile-mem.c: Use C++ exception handling.
6939         * stack.c: Use C++ exception handling.
6940         * sparc64-linux-tdep.c: Use C++ exception handling.
6941         * solib.c: Use C++ exception handling.
6942         * solib-svr4.c: Use C++ exception handling.
6943         * solib-spu.c: Use C++ exception handling.
6944         * solib-frv.c: Use C++ exception handling.
6945         * solib-dsbt.c: Use C++ exception handling.
6946         * selftest-arch.c: Use C++ exception handling.
6947         * s390-tdep.c: Use C++ exception handling.
6948         * rust-lang.c: Use C++ exception handling.
6949         * rust-exp.y: Use C++ exception handling.
6950         * rs6000-tdep.c: Use C++ exception handling.
6951         * rs6000-aix-tdep.c: Use C++ exception handling.
6952         * riscv-tdep.c: Use C++ exception handling.
6953         * remote.c: Use C++ exception handling.
6954         * remote-fileio.c: Use C++ exception handling.
6955         * record-full.c: Use C++ exception handling.
6956         * record-btrace.c: Use C++ exception handling.
6957         * python/python.c: Use C++ exception handling.
6958         * python/py-value.c: Use C++ exception handling.
6959         * python/py-utils.c: Use C++ exception handling.
6960         * python/py-unwind.c: Use C++ exception handling.
6961         * python/py-type.c: Use C++ exception handling.
6962         * python/py-symbol.c: Use C++ exception handling.
6963         * python/py-record.c: Use C++ exception handling.
6964         * python/py-record-btrace.c: Use C++ exception handling.
6965         * python/py-progspace.c: Use C++ exception handling.
6966         * python/py-prettyprint.c: Use C++ exception handling.
6967         * python/py-param.c: Use C++ exception handling.
6968         * python/py-objfile.c: Use C++ exception handling.
6969         * python/py-linetable.c: Use C++ exception handling.
6970         * python/py-lazy-string.c: Use C++ exception handling.
6971         * python/py-infthread.c: Use C++ exception handling.
6972         * python/py-inferior.c: Use C++ exception handling.
6973         * python/py-gdb-readline.c: Use C++ exception handling.
6974         * python/py-framefilter.c: Use C++ exception handling.
6975         * python/py-frame.c: Use C++ exception handling.
6976         * python/py-finishbreakpoint.c: Use C++ exception handling.
6977         * python/py-cmd.c: Use C++ exception handling.
6978         * python/py-breakpoint.c: Use C++ exception handling.
6979         * python/py-arch.c: Use C++ exception handling.
6980         * printcmd.c: Use C++ exception handling.
6981         * ppc-linux-tdep.c: Use C++ exception handling.
6982         * parse.c: Use C++ exception handling.
6983         * p-valprint.c: Use C++ exception handling.
6984         * objc-lang.c: Use C++ exception handling.
6985         * mi/mi-main.c: Use C++ exception handling.
6986         * mi/mi-interp.c: Use C++ exception handling.
6987         * mi/mi-cmd-stack.c: Use C++ exception handling.
6988         * mi/mi-cmd-break.c: Use C++ exception handling.
6989         * main.c: Use C++ exception handling.
6990         * linux-thread-db.c: Use C++ exception handling.
6991         * linux-tdep.c: Use C++ exception handling.
6992         * linux-nat.c: Use C++ exception handling.
6993         * linux-fork.c: Use C++ exception handling.
6994         * linespec.c: Use C++ exception handling.
6995         * language.c: Use C++ exception handling.
6996         * jit.c: Use C++ exception handling.
6997         * infrun.c: Use C++ exception handling.
6998         * infcmd.c: Use C++ exception handling.
6999         * infcall.c: Use C++ exception handling.
7000         * inf-loop.c: Use C++ exception handling.
7001         * i386-tdep.c: Use C++ exception handling.
7002         * i386-linux-tdep.c: Use C++ exception handling.
7003         * guile/scm-value.c: Use C++ exception handling.
7004         * guile/scm-type.c: Use C++ exception handling.
7005         * guile/scm-symtab.c: Use C++ exception handling.
7006         * guile/scm-symbol.c: Use C++ exception handling.
7007         * guile/scm-pretty-print.c: Use C++ exception handling.
7008         * guile/scm-ports.c: Use C++ exception handling.
7009         * guile/scm-param.c: Use C++ exception handling.
7010         * guile/scm-math.c: Use C++ exception handling.
7011         * guile/scm-lazy-string.c: Use C++ exception handling.
7012         * guile/scm-frame.c: Use C++ exception handling.
7013         * guile/scm-disasm.c: Use C++ exception handling.
7014         * guile/scm-cmd.c: Use C++ exception handling.
7015         * guile/scm-breakpoint.c: Use C++ exception handling.
7016         * guile/scm-block.c: Use C++ exception handling.
7017         * guile/guile-internal.h: Use C++ exception handling.
7018         * gnu-v3-abi.c: Use C++ exception handling.
7019         * gdbtypes.c: Use C++ exception handling.
7020         * frame.c: Use C++ exception handling.
7021         * frame-unwind.c: Use C++ exception handling.
7022         * fbsd-tdep.c: Use C++ exception handling.
7023         * f-valprint.c: Use C++ exception handling.
7024         * exec.c: Use C++ exception handling.
7025         * event-top.c: Use C++ exception handling.
7026         * event-loop.c: Use C++ exception handling.
7027         * eval.c: Use C++ exception handling.
7028         * dwarf2read.c: Use C++ exception handling.
7029         * dwarf2loc.c: Use C++ exception handling.
7030         * dwarf2-frame.c: Use C++ exception handling.
7031         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7032         * dwarf-index-write.c: Use C++ exception handling.
7033         * dwarf-index-cache.c: Use C++ exception handling.
7034         * dtrace-probe.c: Use C++ exception handling.
7035         * disasm-selftests.c: Use C++ exception handling.
7036         * darwin-nat.c: Use C++ exception handling.
7037         * cp-valprint.c: Use C++ exception handling.
7038         * cp-support.c: Use C++ exception handling.
7039         * cp-abi.c: Use C++ exception handling.
7040         * corelow.c: Use C++ exception handling.
7041         * completer.c: Use C++ exception handling.
7042         * compile/compile-object-run.c: Use C++ exception handling.
7043         * compile/compile-object-load.c: Use C++ exception handling.
7044         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7045         * compile/compile-c-symbols.c: Use C++ exception handling.
7046         * common/selftest.c: Use C++ exception handling.
7047         * common/new-op.c: Use C++ exception handling.
7048         * cli/cli-script.c: Use C++ exception handling.
7049         * cli/cli-interp.c: Use C++ exception handling.
7050         * cli/cli-cmds.c: Use C++ exception handling.
7051         * c-varobj.c: Use C++ exception handling.
7052         * btrace.c: Use C++ exception handling.
7053         * breakpoint.c: Use C++ exception handling.
7054         * break-catch-throw.c: Use C++ exception handling.
7055         * arch-utils.c: Use C++ exception handling.
7056         * amd64-tdep.c: Use C++ exception handling.
7057         * ada-valprint.c: Use C++ exception handling.
7058         * ada-typeprint.c: Use C++ exception handling.
7059         * ada-lang.c: Use C++ exception handling.
7060         * aarch64-tdep.c: Use C++ exception handling.
7061
7062 2019-04-08  Tom Tromey  <tom@tromey.com>
7063
7064         * xml-support.c (gdb_xml_parser::parse): Update.
7065         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7066         * value.c (show_convenience): Update.
7067         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7068         (test_parse_flags_qcs): Update.
7069         * thread.c (thr_try_catch_cmd): Update.
7070         * target.c (target_translate_tls_address): Update.
7071         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7072         (info_frame_command_core, frame_apply_command_count): Update.
7073         * rust-exp.y (rust_lex_exception_test): Update.
7074         * riscv-tdep.c (riscv_print_one_register_info): Update.
7075         * remote.c (remote_target::enable_btrace): Update.
7076         * record-btrace.c (record_btrace_enable_warn): Update.
7077         * python/py-utils.c (gdbpy_convert_exception): Update.
7078         * printcmd.c (do_one_display, print_variable_and_value): Update.
7079         * mi/mi-main.c (mi_print_exception): Update.
7080         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7081         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7082         * linux-nat.c (linux_nat_target::attach): Update.
7083         * linux-fork.c (class scoped_switch_fork_info): Update.
7084         * infrun.c (displaced_step_prepare): Update.
7085         * infcall.c (call_function_by_hand_dummy): Update.
7086         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7087         * gnu-v3-abi.c (print_one_vtable): Update.
7088         * frame.c (get_prev_frame_always): Update.
7089         * f-valprint.c (info_common_command_for_block): Update.
7090         * exec.c (try_open_exec_file): Update.
7091         * exceptions.c (print_exception, exception_print)
7092         (exception_fprintf, exception_print_same): Update.
7093         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7094         * dwarf-index-cache.c (index_cache::store)
7095         (index_cache::lookup_gdb_index): Update.
7096         * darwin-nat.c (maybe_cache_shell): Update.
7097         * cp-valprint.c (cp_print_value_fields): Update.
7098         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7099         (gcc_cplus_symbol_address): Update.
7100         * compile/compile-c-symbols.c (gcc_convert_symbol)
7101         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7102         * common/selftest.c: Update.
7103         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7104         a std::string.
7105         (exception_try_scope_entry, exception_try_scope_exit): Don't
7106         declare.
7107         (struct exception_try_scope): Remove.
7108         (TRY): Don't use exception_try_scope.
7109         (struct gdb_exception): Add constructor, operator=.
7110         <what>: New method.
7111         (struct gdb_exception_RETURN_MASK_ALL)
7112         (struct gdb_exception_RETURN_MASK_ERROR)
7113         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7114         (struct gdb_quit_bad_alloc): Update.
7115         * common/common-exceptions.c (exception_none): Change
7116         initializer.
7117         (struct catcher) <state, exception>: Initialize inline.
7118         <prev>: Remove member.
7119         (current_catcher): Remove.
7120         (catchers): New global.
7121         (exceptions_state_mc_init): Simplify.
7122         (catcher_pop): Remove.
7123         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7124         (try_scope_depth, exception_try_scope_entry)
7125         (exception_try_scope_exit): Remove.
7126         (throw_exception_sjlj): Update.
7127         (exception_messages, exception_messages_size): Remove.
7128         (throw_it): Simplify.
7129         (gdb_exception_sliced_copy): Remove.
7130         (throw_exception_cxx): Update.
7131         * cli/cli-script.c (script_from_file): Update.
7132         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7133         Update.
7134         * ada-valprint.c (ada_val_print): Update.
7135         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7136         (create_excep_cond_exprs): Update.
7137
7138 2019-04-08  Tom Tromey  <tom@tromey.com>
7139
7140         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7141         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7142         (TRY, CATCH, END_CATCH): Remove some definitions.
7143         * common/common-exceptions.c: Don't use GDB_XCPT.
7144         (catcher_list_size): Remove.
7145         (throw_exception, throw_it): Simplify.
7146
7147 2019-04-05  Tom Tromey  <tom@tromey.com>
7148
7149         Revert the header-sorting patch.
7150         * ft32-tdep.c: Revert.
7151         * frv-tdep.c: Revert.
7152         * frv-linux-tdep.c: Revert.
7153         * frame.c: Revert.
7154         * frame-unwind.c: Revert.
7155         * frame-base.c: Revert.
7156         * fork-child.c: Revert.
7157         * findvar.c: Revert.
7158         * findcmd.c: Revert.
7159         * filesystem.c: Revert.
7160         * filename-seen-cache.h: Revert.
7161         * filename-seen-cache.c: Revert.
7162         * fbsd-tdep.c: Revert.
7163         * fbsd-nat.h: Revert.
7164         * fbsd-nat.c: Revert.
7165         * f-valprint.c: Revert.
7166         * f-typeprint.c: Revert.
7167         * f-lang.c: Revert.
7168         * extension.h: Revert.
7169         * extension.c: Revert.
7170         * extension-priv.h: Revert.
7171         * expprint.c: Revert.
7172         * exec.h: Revert.
7173         * exec.c: Revert.
7174         * exceptions.c: Revert.
7175         * event-top.c: Revert.
7176         * event-loop.c: Revert.
7177         * eval.c: Revert.
7178         * elfread.c: Revert.
7179         * dwarf2read.h: Revert.
7180         * dwarf2read.c: Revert.
7181         * dwarf2loc.c: Revert.
7182         * dwarf2expr.h: Revert.
7183         * dwarf2expr.c: Revert.
7184         * dwarf2-frame.c: Revert.
7185         * dwarf2-frame-tailcall.c: Revert.
7186         * dwarf-index-write.h: Revert.
7187         * dwarf-index-write.c: Revert.
7188         * dwarf-index-common.c: Revert.
7189         * dwarf-index-cache.h: Revert.
7190         * dwarf-index-cache.c: Revert.
7191         * dummy-frame.c: Revert.
7192         * dtrace-probe.c: Revert.
7193         * disasm.h: Revert.
7194         * disasm.c: Revert.
7195         * disasm-selftests.c: Revert.
7196         * dictionary.c: Revert.
7197         * dicos-tdep.c: Revert.
7198         * demangle.c: Revert.
7199         * dcache.h: Revert.
7200         * dcache.c: Revert.
7201         * darwin-nat.h: Revert.
7202         * darwin-nat.c: Revert.
7203         * darwin-nat-info.c: Revert.
7204         * d-valprint.c: Revert.
7205         * d-namespace.c: Revert.
7206         * d-lang.c: Revert.
7207         * ctf.c: Revert.
7208         * csky-tdep.c: Revert.
7209         * csky-linux-tdep.c: Revert.
7210         * cris-tdep.c: Revert.
7211         * cris-linux-tdep.c: Revert.
7212         * cp-valprint.c: Revert.
7213         * cp-support.c: Revert.
7214         * cp-namespace.c: Revert.
7215         * cp-abi.c: Revert.
7216         * corelow.c: Revert.
7217         * corefile.c: Revert.
7218         * continuations.c: Revert.
7219         * completer.h: Revert.
7220         * completer.c: Revert.
7221         * complaints.c: Revert.
7222         * coffread.c: Revert.
7223         * coff-pe-read.c: Revert.
7224         * cli-out.h: Revert.
7225         * cli-out.c: Revert.
7226         * charset.c: Revert.
7227         * c-varobj.c: Revert.
7228         * c-valprint.c: Revert.
7229         * c-typeprint.c: Revert.
7230         * c-lang.c: Revert.
7231         * buildsym.c: Revert.
7232         * buildsym-legacy.c: Revert.
7233         * build-id.h: Revert.
7234         * build-id.c: Revert.
7235         * btrace.c: Revert.
7236         * bsd-uthread.c: Revert.
7237         * breakpoint.h: Revert.
7238         * breakpoint.c: Revert.
7239         * break-catch-throw.c: Revert.
7240         * break-catch-syscall.c: Revert.
7241         * break-catch-sig.c: Revert.
7242         * blockframe.c: Revert.
7243         * block.c: Revert.
7244         * bfin-tdep.c: Revert.
7245         * bfin-linux-tdep.c: Revert.
7246         * bfd-target.c: Revert.
7247         * bcache.c: Revert.
7248         * ax-general.c: Revert.
7249         * ax-gdb.h: Revert.
7250         * ax-gdb.c: Revert.
7251         * avr-tdep.c: Revert.
7252         * auxv.c: Revert.
7253         * auto-load.c: Revert.
7254         * arm-wince-tdep.c: Revert.
7255         * arm-tdep.c: Revert.
7256         * arm-symbian-tdep.c: Revert.
7257         * arm-pikeos-tdep.c: Revert.
7258         * arm-obsd-tdep.c: Revert.
7259         * arm-nbsd-tdep.c: Revert.
7260         * arm-nbsd-nat.c: Revert.
7261         * arm-linux-tdep.c: Revert.
7262         * arm-linux-nat.c: Revert.
7263         * arm-fbsd-tdep.c: Revert.
7264         * arm-fbsd-nat.c: Revert.
7265         * arm-bsd-tdep.c: Revert.
7266         * arch-utils.c: Revert.
7267         * arc-tdep.c: Revert.
7268         * arc-newlib-tdep.c: Revert.
7269         * annotate.h: Revert.
7270         * annotate.c: Revert.
7271         * amd64-windows-tdep.c: Revert.
7272         * amd64-windows-nat.c: Revert.
7273         * amd64-tdep.c: Revert.
7274         * amd64-sol2-tdep.c: Revert.
7275         * amd64-obsd-tdep.c: Revert.
7276         * amd64-obsd-nat.c: Revert.
7277         * amd64-nbsd-tdep.c: Revert.
7278         * amd64-nbsd-nat.c: Revert.
7279         * amd64-nat.c: Revert.
7280         * amd64-linux-tdep.c: Revert.
7281         * amd64-linux-nat.c: Revert.
7282         * amd64-fbsd-tdep.c: Revert.
7283         * amd64-fbsd-nat.c: Revert.
7284         * amd64-dicos-tdep.c: Revert.
7285         * amd64-darwin-tdep.c: Revert.
7286         * amd64-bsd-nat.c: Revert.
7287         * alpha-tdep.c: Revert.
7288         * alpha-obsd-tdep.c: Revert.
7289         * alpha-nbsd-tdep.c: Revert.
7290         * alpha-mdebug-tdep.c: Revert.
7291         * alpha-linux-tdep.c: Revert.
7292         * alpha-linux-nat.c: Revert.
7293         * alpha-bsd-tdep.c: Revert.
7294         * alpha-bsd-nat.c: Revert.
7295         * aix-thread.c: Revert.
7296         * agent.c: Revert.
7297         * addrmap.c: Revert.
7298         * ada-varobj.c: Revert.
7299         * ada-valprint.c: Revert.
7300         * ada-typeprint.c: Revert.
7301         * ada-tasks.c: Revert.
7302         * ada-lang.c: Revert.
7303         * aarch64-tdep.c: Revert.
7304         * aarch64-ravenscar-thread.c: Revert.
7305         * aarch64-newlib-tdep.c: Revert.
7306         * aarch64-linux-tdep.c: Revert.
7307         * aarch64-linux-nat.c: Revert.
7308         * aarch64-fbsd-tdep.c: Revert.
7309         * aarch64-fbsd-nat.c: Revert.
7310         * aarch32-linux-nat.c: Revert.
7311
7312 2019-04-05  Tom Tromey  <tom@tromey.com>
7313
7314         * ft32-tdep.c: Sort headers.
7315         * frv-tdep.c: Sort headers.
7316         * frv-linux-tdep.c: Sort headers.
7317         * frame.c: Sort headers.
7318         * frame-unwind.c: Sort headers.
7319         * frame-base.c: Sort headers.
7320         * fork-child.c: Sort headers.
7321         * findvar.c: Sort headers.
7322         * findcmd.c: Sort headers.
7323         * filesystem.c: Sort headers.
7324         * filename-seen-cache.h: Sort headers.
7325         * filename-seen-cache.c: Sort headers.
7326         * fbsd-tdep.c: Sort headers.
7327         * fbsd-nat.h: Sort headers.
7328         * fbsd-nat.c: Sort headers.
7329         * f-valprint.c: Sort headers.
7330         * f-typeprint.c: Sort headers.
7331         * f-lang.c: Sort headers.
7332         * extension.h: Sort headers.
7333         * extension.c: Sort headers.
7334         * extension-priv.h: Sort headers.
7335         * expprint.c: Sort headers.
7336         * exec.h: Sort headers.
7337         * exec.c: Sort headers.
7338         * exceptions.c: Sort headers.
7339         * event-top.c: Sort headers.
7340         * event-loop.c: Sort headers.
7341         * eval.c: Sort headers.
7342         * elfread.c: Sort headers.
7343         * dwarf2read.h: Sort headers.
7344         * dwarf2read.c: Sort headers.
7345         * dwarf2loc.c: Sort headers.
7346         * dwarf2expr.h: Sort headers.
7347         * dwarf2expr.c: Sort headers.
7348         * dwarf2-frame.c: Sort headers.
7349         * dwarf2-frame-tailcall.c: Sort headers.
7350         * dwarf-index-write.h: Sort headers.
7351         * dwarf-index-write.c: Sort headers.
7352         * dwarf-index-common.c: Sort headers.
7353         * dwarf-index-cache.h: Sort headers.
7354         * dwarf-index-cache.c: Sort headers.
7355         * dummy-frame.c: Sort headers.
7356         * dtrace-probe.c: Sort headers.
7357         * disasm.h: Sort headers.
7358         * disasm.c: Sort headers.
7359         * disasm-selftests.c: Sort headers.
7360         * dictionary.c: Sort headers.
7361         * dicos-tdep.c: Sort headers.
7362         * demangle.c: Sort headers.
7363         * dcache.h: Sort headers.
7364         * dcache.c: Sort headers.
7365         * darwin-nat.h: Sort headers.
7366         * darwin-nat.c: Sort headers.
7367         * darwin-nat-info.c: Sort headers.
7368         * d-valprint.c: Sort headers.
7369         * d-namespace.c: Sort headers.
7370         * d-lang.c: Sort headers.
7371         * ctf.c: Sort headers.
7372         * csky-tdep.c: Sort headers.
7373         * csky-linux-tdep.c: Sort headers.
7374         * cris-tdep.c: Sort headers.
7375         * cris-linux-tdep.c: Sort headers.
7376         * cp-valprint.c: Sort headers.
7377         * cp-support.c: Sort headers.
7378         * cp-namespace.c: Sort headers.
7379         * cp-abi.c: Sort headers.
7380         * corelow.c: Sort headers.
7381         * corefile.c: Sort headers.
7382         * continuations.c: Sort headers.
7383         * completer.h: Sort headers.
7384         * completer.c: Sort headers.
7385         * complaints.c: Sort headers.
7386         * coffread.c: Sort headers.
7387         * coff-pe-read.c: Sort headers.
7388         * cli-out.h: Sort headers.
7389         * cli-out.c: Sort headers.
7390         * charset.c: Sort headers.
7391         * c-varobj.c: Sort headers.
7392         * c-valprint.c: Sort headers.
7393         * c-typeprint.c: Sort headers.
7394         * c-lang.c: Sort headers.
7395         * buildsym.c: Sort headers.
7396         * buildsym-legacy.c: Sort headers.
7397         * build-id.h: Sort headers.
7398         * build-id.c: Sort headers.
7399         * btrace.c: Sort headers.
7400         * bsd-uthread.c: Sort headers.
7401         * breakpoint.h: Sort headers.
7402         * breakpoint.c: Sort headers.
7403         * break-catch-throw.c: Sort headers.
7404         * break-catch-syscall.c: Sort headers.
7405         * break-catch-sig.c: Sort headers.
7406         * blockframe.c: Sort headers.
7407         * block.c: Sort headers.
7408         * bfin-tdep.c: Sort headers.
7409         * bfin-linux-tdep.c: Sort headers.
7410         * bfd-target.c: Sort headers.
7411         * bcache.c: Sort headers.
7412         * ax-general.c: Sort headers.
7413         * ax-gdb.h: Sort headers.
7414         * ax-gdb.c: Sort headers.
7415         * avr-tdep.c: Sort headers.
7416         * auxv.c: Sort headers.
7417         * auto-load.c: Sort headers.
7418         * arm-wince-tdep.c: Sort headers.
7419         * arm-tdep.c: Sort headers.
7420         * arm-symbian-tdep.c: Sort headers.
7421         * arm-pikeos-tdep.c: Sort headers.
7422         * arm-obsd-tdep.c: Sort headers.
7423         * arm-nbsd-tdep.c: Sort headers.
7424         * arm-nbsd-nat.c: Sort headers.
7425         * arm-linux-tdep.c: Sort headers.
7426         * arm-linux-nat.c: Sort headers.
7427         * arm-fbsd-tdep.c: Sort headers.
7428         * arm-fbsd-nat.c: Sort headers.
7429         * arm-bsd-tdep.c: Sort headers.
7430         * arch-utils.c: Sort headers.
7431         * arc-tdep.c: Sort headers.
7432         * arc-newlib-tdep.c: Sort headers.
7433         * annotate.h: Sort headers.
7434         * annotate.c: Sort headers.
7435         * amd64-windows-tdep.c: Sort headers.
7436         * amd64-windows-nat.c: Sort headers.
7437         * amd64-tdep.c: Sort headers.
7438         * amd64-sol2-tdep.c: Sort headers.
7439         * amd64-obsd-tdep.c: Sort headers.
7440         * amd64-obsd-nat.c: Sort headers.
7441         * amd64-nbsd-tdep.c: Sort headers.
7442         * amd64-nbsd-nat.c: Sort headers.
7443         * amd64-nat.c: Sort headers.
7444         * amd64-linux-tdep.c: Sort headers.
7445         * amd64-linux-nat.c: Sort headers.
7446         * amd64-fbsd-tdep.c: Sort headers.
7447         * amd64-fbsd-nat.c: Sort headers.
7448         * amd64-dicos-tdep.c: Sort headers.
7449         * amd64-darwin-tdep.c: Sort headers.
7450         * amd64-bsd-nat.c: Sort headers.
7451         * alpha-tdep.c: Sort headers.
7452         * alpha-obsd-tdep.c: Sort headers.
7453         * alpha-nbsd-tdep.c: Sort headers.
7454         * alpha-mdebug-tdep.c: Sort headers.
7455         * alpha-linux-tdep.c: Sort headers.
7456         * alpha-linux-nat.c: Sort headers.
7457         * alpha-bsd-tdep.c: Sort headers.
7458         * alpha-bsd-nat.c: Sort headers.
7459         * aix-thread.c: Sort headers.
7460         * agent.c: Sort headers.
7461         * addrmap.c: Sort headers.
7462         * ada-varobj.c: Sort headers.
7463         * ada-valprint.c: Sort headers.
7464         * ada-typeprint.c: Sort headers.
7465         * ada-tasks.c: Sort headers.
7466         * ada-lang.c: Sort headers.
7467         * aarch64-tdep.c: Sort headers.
7468         * aarch64-ravenscar-thread.c: Sort headers.
7469         * aarch64-newlib-tdep.c: Sort headers.
7470         * aarch64-linux-tdep.c: Sort headers.
7471         * aarch64-linux-nat.c: Sort headers.
7472         * aarch64-fbsd-tdep.c: Sort headers.
7473         * aarch64-fbsd-nat.c: Sort headers.
7474         * aarch32-linux-nat.c: Sort headers.
7475
7476 2019-04-04  Tom Tromey  <tom@tromey.com>
7477
7478         * varobj.c (varobj_create): Update.
7479         * rust-exp.y (struct rust_parser) <update_innermost_block,
7480         lookup_symbol>: New methods.
7481         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7482         Rename.
7483         (rust_parser::rust_lookup_type)
7484         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7485         * printcmd.c (display_command, do_one_display): Update.
7486         * parser-defs.h (struct parser_state) <parser_state>: Add
7487         "tracker" parameter.
7488         (block_tracker): New member.
7489         (class innermost_block_tracker) <innermost_block_tracker>: Add
7490         "types" parameter.
7491         <reset>: Remove method.
7492         (innermost_block): Don't declare.
7493         (null_post_parser): Update.
7494         * parse.c (innermost_block): Remove global.
7495         (write_dollar_variable): Update.
7496         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7497         Remove "tracker_types" parameter.
7498         (parse_expression): Add "tracker" parameter.
7499         (parse_expression_for_completion): Update.
7500         (null_post_parser): Add "tracker" parameter.
7501         * p-exp.y: Update rules.
7502         * m2-exp.y: Update rules.
7503         * language.h (struct language_defn) <la_post_parser>: Add
7504         "tracker" parameter.
7505         * go-exp.y: Update rules.
7506         * f-exp.y: Update rules.
7507         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7508         parameter.
7509         * d-exp.y: Update rules.
7510         * c-exp.y: Update rules.
7511         * breakpoint.c (set_breakpoint_condition): Create an
7512         innermost_block_tracker.
7513         (watch_command_1): Likewise.
7514         * ada-lang.c (resolve): Add "tracker" parameter.
7515         (resolve_subexp): Likewise.
7516         * ada-exp.y (write_var_from_sym): Update.
7517
7518 2019-04-04  Tom Tromey  <tom@tromey.com>
7519
7520         * type-stack.h: New file.
7521         * type-stack.c: New file.
7522         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7523         type-stack.h.
7524         (insert_into_type_stack, insert_type, push_type, push_type_int)
7525         (insert_type_address_space, pop_type, pop_type_int)
7526         (pop_typelist, pop_type_stack, append_type_stack)
7527         (push_type_stack, get_type_stack, push_typelist)
7528         (follow_type_instance_flags, follow_types): Don't declare.
7529         * parse.c (type_stack): Remove global.
7530         (parse_exp_in_context): Update.
7531         (insert_into_type_stack, insert_type, push_type, push_type_int)
7532         (insert_type_address_space, pop_type, pop_type_int)
7533         (pop_typelist, pop_type_stack, append_type_stack)
7534         (push_type_stack, get_type_stack, push_typelist)
7535         (follow_type_instance_flags, follow_types): Remove (moved to
7536         type-stack.c).
7537         * f-exp.y (type_stack): New global.
7538         Update rules.
7539         (push_kind_type, f_parse): Update.
7540         * d-exp.y (type_stack): New global.
7541         Update rules.
7542         (d_parse): Update.
7543         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7544         Update rules.
7545         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7546         (HFILES_NO_SRCDIR): Add type-stack.h.
7547
7548 2019-04-04  Tom Tromey  <tom@tromey.com>
7549
7550         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7551         (rust_parser::convert_ast_to_expression, rust_parse)
7552         (rust_lex_test_completion, rust_lex_tests): Update.
7553         * parser-defs.h (struct expr_completion_state): New.
7554         (struct parser_state) <parser_state>: Add completion parameter.
7555         <mark_struct_expression, mark_completion_tag>: New methods.
7556         <parse_completion, m_completion_state>: New members.
7557         (prefixify_expression, null_post_parser): Update.
7558         (mark_struct_expression, mark_completion_tag): Don't declare.
7559         * parse.c (parse_completion, expout_last_struct)
7560         (expout_tag_completion_type, expout_completion_name): Remove
7561         globals.
7562         (parser_state::mark_struct_expression)
7563         (parser_state::mark_completion_tag): Now methods.
7564         (prefixify_expression): Add last_struct parameter.
7565         (prefixify_subexp): Likewise.
7566         (parse_exp_1): Update.
7567         (parse_exp_in_context): Add cstate parameter.  Update.
7568         (parse_expression_for_completion): Create an
7569         expr_completion_state.
7570         (null_post_parser): Add "completion" parameter.
7571         * p-exp.y: Update rules.
7572         (yylex): Update.
7573         * language.h (struct language_defn) <la_post_parser>: Add
7574         "completing" parameter.
7575         * go-exp.y: Update rules.
7576         (lex_one_token): Update.
7577         * expression.h (parse_completion): Don't declare.
7578         * d-exp.y: Update rules.
7579         (lex_one_token): Update rules.
7580         * c-exp.y: Update rules.
7581         (lex_one_token): Update.
7582         * ada-lang.c (resolve): Add "parse_completion" parameter.
7583         (resolve_subexp): Likewise.
7584         (ada_resolve_function): Likewise.
7585
7586 2019-04-04  Tom Tromey  <tom@tromey.com>
7587
7588         * parser-defs.h (struct parser_state) <start_arglist,
7589         end_arglist>: New methods.
7590         <arglist_len, m_funcall_chain>: New members.
7591         (arglist_len, start_arglist, end_arglist): Don't declare.
7592         * parse.c (arglist_len, funcall_chain): Remove global.
7593         (start_arglist, end_arglist): Remove functions.
7594         (parse_exp_in_context): Update.
7595         * p-exp.y: Update rules.
7596         * m2-exp.y: Update rules.
7597         * go-exp.y: Update rules.
7598         * f-exp.y: Update rules.
7599         * d-exp.y: Update rules.
7600         * c-exp.y: Update rules.
7601
7602 2019-04-04  Tom Tromey  <tom@tromey.com>
7603
7604         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7605         lex_operator, push_back>: New methods.
7606         Update all rules.
7607         (rust_parser::lex_hex, lex_escape): Rename and update.
7608         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7609         (rust_parser::lex_operator): Rename and update.
7610         (rust_parser::lex_number, rustyylex, rustyyerror)
7611         (rust_lex_test_init, rust_lex_test_sequence)
7612         (rust_lex_test_push_back, rust_lex_tests): Update.
7613         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7614         parameter.
7615         <lexptr, prev_lexptr>: New members.
7616         (lexptr, prev_lexptr): Don't declare.
7617         * parse.c (lexptr, prev_lexptr): Remove globals.
7618         (parse_exp_in_context): Update.
7619         * p-exp.y (yylex, yyerror): Update.
7620         * m2-exp.y (parse_number, yylex, yyerror): Update.
7621         * go-exp.y (lex_one_token, yyerror): Update.
7622         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7623         * d-exp.y (lex_one_token, yyerror): Update.
7624         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7625         (lex_one_token, yyerror): Update.
7626         * ada-lex.l (YY_INPUT): Update.
7627         (rewind_to_char): Update.
7628         * ada-exp.y (yyerror): Update.
7629
7630 2019-04-04  Tom Tromey  <tom@tromey.com>
7631
7632         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7633         * parser-defs.h (struct parser_state) <parser_state>: Add new
7634         parameter.
7635         <comma_terminates>: New member.
7636         (comma_terminates): Don't declare global.
7637         * parse.c (comma_terminates): Remove global.
7638         (parse_exp_in_context): Update.
7639         * p-exp.y (yylex): Update.
7640         * m2-exp.y (yylex): Update.
7641         * go-exp.y (lex_one_token): Update.
7642         * f-exp.y (yylex): Update.
7643         * d-exp.y (lex_one_token): Update.
7644         * c-exp.y (lex_one_token): Update.
7645         * ada-lex.l: Update.
7646
7647 2019-04-04  Tom Tromey  <tom@tromey.com>
7648
7649         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7650         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7651         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7652         * parser-defs.h (paren_depth): Don't declare.
7653         * parse.c (paren_depth): Remove global.
7654         (parse_exp_in_context): Update.
7655         * p-exp.y (paren_depth): New global.
7656         (pascal_parse): Initialize it.
7657         * m2-exp.y (paren_depth): New global.
7658         (m2_parse): Initialize it.
7659         * go-exp.y (paren_depth): New global.
7660         (go_parse): Initialize it.
7661         * f-exp.y (paren_depth): New global.
7662         (f_parse): Initialize it.
7663         * d-exp.y (paren_depth): New global.
7664         (d_parse): Initialize it.
7665         * c-exp.y (paren_depth): New global.
7666         (c_parse): Initialize it.
7667         * ada-lex.l (paren_depth): New global.
7668         (lexer_init): Initialize it.
7669
7670 2019-04-04  Tom Tromey  <tom@tromey.com>
7671
7672         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7673         (rust_parser::convert_ast_to_type)
7674         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7675         * parser-defs.h (struct parser_state) <parser_state>: Add
7676         parameters.  Initialize new members.
7677         <expression_context_block, expression_context_pc>: New members.
7678         * parse.c (expression_context_block, expression_context_pc):
7679         Remove globals.
7680         (parse_exp_in_context): Update.
7681         * p-exp.y: Update all rules.
7682         (yylex): Update.
7683         * m2-exp.y: Update all rules.
7684         (yylex): Update.
7685         * go-exp.y (yylex): Update.
7686         * f-exp.y (yylex): Update.
7687         * d-exp.y: Update all rules.
7688         (yylex): Update.
7689         * c-exp.y: Update all rules.
7690         (lex_one_token, classify_name, yylex, c_parse): Update.
7691         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7692
7693 2019-04-04  Tom Tromey  <tom@tromey.com>
7694
7695         * gdbarch.h, gdbarch.c: Rebuild.
7696         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7697         * stap-probe.h:
7698         (struct stap_parse_info): Replace "parser_state" with
7699         "expr_builder".
7700         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7701         (parser_state): New class.
7702         * parse.c (expr_builder): Rename.
7703         (expr_builder::release): Rename.
7704         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7705         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7706         (write_exp_elt_longcst, write_exp_elt_floatcst)
7707         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7708         (write_exp_string_vector, write_exp_bitstring)
7709         (write_exp_msymbol, mark_struct_expression)
7710         (write_dollar_variable)
7711         (insert_type_address_space, increase_expout_size): Replace
7712         "parser_state" with "expr_builder".
7713         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7714         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7715         "parser_state" with "expr_builder".
7716
7717 2019-04-04  Tom Tromey  <tom@tromey.com>
7718
7719         * rust-exp.y: Replace "parse_language" with method call.
7720         * p-exp.y:
7721         (yylex): Replace "parse_language" with method call.
7722         * m2-exp.y:
7723         (yylex): Replace "parse_language" with method call.
7724         * go-exp.y (classify_name): Replace "parse_language" with method
7725         call.
7726         * f-exp.y (yylex): Replace "parse_language" with method call.
7727         * d-exp.y (lex_one_token): Replace "parse_language" with method
7728         call.
7729         * c-exp.y:
7730         (lex_one_token, classify_name, yylex): Replace "parse_language"
7731         with method call.
7732         * ada-exp.y (find_primitive_type, type_char)
7733         (type_system_address): Replace "parse_language" with method call.
7734
7735 2019-04-04  Tom Tromey  <tom@tromey.com>
7736
7737         * rust-exp.y: Replace "parse_gdbarch" with method call.
7738         * parse.c (write_dollar_variable, insert_type_address_space):
7739         Replace "parse_gdbarch" with method call.
7740         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7741         call.
7742         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7743         call.
7744         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7745         "parse_gdbarch" with method call.
7746         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7747         with method call.
7748         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7749         "parse_gdbarch" with method call.
7750         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7751         "parse_gdbarch" with method call.
7752         * c-exp.y (parse_type, parse_number, classify_name): Replace
7753         "parse_gdbarch" with method call.
7754         * ada-lex.l: Replace "parse_gdbarch" with method call.
7755         * ada-exp.y (parse_type, find_primitive_type, type_char)
7756         (type_system_address): Replace "parse_gdbarch" with method call.
7757
7758 2019-04-04  Tom Tromey  <tom@tromey.com>
7759
7760         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7761         * stap-probe.c (stap_parse_argument): Update.
7762         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7763         initial_size parameter.
7764         * rust-exp.y (rust_lex_tests): Update.
7765         * parse.c (parser_state): Update.
7766         (parse_exp_in_context): Update.
7767         * parser-defs.h (struct parser_state) <parser_state>: Remove
7768         "initial_size" parameter.
7769
7770 2019-04-04  Tom Tromey  <tom@tromey.com>
7771
7772         * parser-defs.h (increase_expout_size): Don't declare.
7773         * parse.c (increase_expout_size): Now static.
7774
7775 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7776
7777         * gnu-nat.c (gnu_nat_target::wait): Fix
7778         target_waitstatus_to_string call.
7779
7780 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7781
7782         * eval.c (evaluate_subexp_standard): Handle internal functions
7783         during Fortran function call handling.
7784
7785 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7786
7787         * NEWS: Mention new internal functions.
7788         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7789         (read_base_type): Use dwarf2_init_complex_target_type.
7790         * value.c (creal_internal_fn): New function.
7791         (cimag_internal_fn): New function.
7792         (_initialize_values): Register new internal functions.
7793
7794 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7795
7796         * infrun.c (stop_all_threads): If debug_infrun, always
7797         trace the wait status after wait_one, using
7798         target_waitstatus_to_string and target_pid_to_str.
7799         (handle_inferior_event): Replace various trace of
7800         wait status kind by a single trace.
7801         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7802         wait status kind image by target_waitstatus_to_string.
7803         * target/waitstatus.c (target_waitstatus_to_string): Fix
7804         obsolete comment.
7805
7806 2019-04-01  Tom Tromey  <tromey@adacore.com>
7807
7808         PR symtab/23331:
7809         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7810
7811 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7812             Pedro Alves  <palves@redhat.com>
7813
7814         * top.c (quit_force): Call 'finalize_values'.
7815         * value.c (finalize_values): New function.
7816         * value.h (finalize_values): Declare.
7817
7818 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7819
7820         * NEWS: Announce $_gdb_major and $_gdb_minor.
7821
7822         * top.c (init_gdb_version_vars): New function.
7823         (gdb_init): Call init_gdb_version_vars.
7824
7825 2019-03-29  Tom Tromey  <tromey@adacore.com>
7826
7827         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7828         help text.  Remove dead code.
7829
7830 2019-03-29  Keith Seitz  <keiths@redhat.com>
7831
7832         From Siddhesh Poyarekar:
7833         * f-lang.h (f77_get_upperbound): Return LONGEST.
7834         (f77_get_lowerbound): Likewise.
7835         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7836         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7837         print them.
7838         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7839         plongest to format print it.
7840         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7841         (f77_get_upperbound): Likewise.
7842         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7843         LOWER_BOUND to LONGEST.
7844         (f77_create_arrayprint_offset_tbl): Likewise.
7845
7846 2019-03-29  Keith Seitz  <keiths@redhat.com>
7847
7848         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7849         %s/pulongest for TYPE_LENGTH instead of %d in format
7850         strings.
7851         * ada-typerint.c (ada_print_type): Likewise.
7852         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7853         * compile/compile-c-support.c (generate_register_struct): Likewise.
7854         * gdbtypes.c (recursive_dump_type): Likewise.
7855         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7856         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7857         instead of %d in format strings.
7858         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7859         to std::min to ULONGEST.
7860         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7861         instead of %d in format strings.
7862         * tracepoint.c (info_scope_command): Likewise.
7863         * typeprint.c (print_offset_data::update)
7864         (print_offset_data::finish): Likewise.
7865         * xtensa-tdep.c (xtensa_store_return_value)
7866         (xtensa_push_dummy_call): Likewise.
7867
7868 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7869
7870         * windows-nat.c (display_selector): Fixed format specifications
7871         for 64-bit Cygwin.
7872
7873 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7874
7875         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7876
7877 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7878
7879         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7880         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7881         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7882         (nios2_linux_init_abi): Install it.
7883
7884 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7885
7886         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7887
7888 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7889
7890         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7891
7892 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7893             Tom Tromey  <tromey@adacore.com>
7894
7895         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7896
7897 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7898
7899         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7900         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7901         method to compute the bounds of range types. Also print "[evaluated]"
7902         if the bounds' values come from a dynamic evaluation.
7903
7904 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7907         whitespace when pretty printing is on.
7908
7909 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7910
7911         * ppc-linux-nat.c: Add include.
7912
7913 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7914
7915         * NEWS: Mention AArch64 Pointer Authentication.
7916
7917 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7918
7919         * arm-linux-nat.c: Add include.
7920
7921 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7922
7923         * source-cache.c (source_cache::get_source_lines): Re-read
7924         fullname after calling open_source_file.
7925
7926 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7927
7928         * NEWS: Mention TLS support for FreeBSD.
7929
7930 2019-03-25  Tom Tromey  <tromey@adacore.com>
7931
7932         * minsyms.c (BUNCH_SIZE): Update comment.
7933         (~minimal_symbol_reader): Remove old comment.
7934         (compact_minimal_symbols): Update comment.
7935         (minimal_symbol_reader::install): Remove old comment.  Update
7936         other comments.
7937
7938 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7939
7940         * s390-linux-nat.c: Add include.
7941
7942 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7943
7944         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7945         Call linux_get_hwcap.
7946         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7947         Likewise.
7948         (aarch64_linux_get_hwcap): Remove function.
7949         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7950         declaration.
7951         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7952         linux_get_hwcap.
7953         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7954         * linux-tdep.c (linux_get_hwcap): Add function.
7955         (linux_get_hwcap2): Likewise.
7956         * linux-tdep.h (linux_get_hwcap): Add declaration.
7957         (linux_get_hwcap2): Likewise.
7958         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7959         (ppc_linux_get_hwcap2): Likewise.
7960         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7961         linux_get_hwcap.
7962         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7963         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7964         (ppc_linux_nat_target::read_description): Likewise.
7965         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7966         * s390-linux-nat.c: Likewise.
7967         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7968
7969 2019-03-24  Tom Tromey  <tom@tromey.com>
7970
7971         * ada-lang.c (standard_lookup): Simplify initialization.
7972         (ada_lookup_symbol_nonlocal): Simplify return.
7973         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7974         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7975         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7976         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7977         initialization.
7978         * solib.c (solib_global_lookup): Simplify.
7979         * symtab.c (null_block_symbol): Remove.
7980         (symbol_cache_lookup): Simplify returns.
7981         (lookup_language_this): Simplify returns.
7982         (lookup_symbol_aux): Simplify return.
7983         (lookup_local_symbol): Simplify returns.
7984         (lookup_global_symbol_from_objfile): Simplify return.
7985         (lookup_symbol_in_objfile_symtabs)
7986         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7987         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7988         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7989         * cp-namespace.c (cp_lookup_bare_symbol)
7990         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7991         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7992         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7993         (cp_lookup_symbol_via_imports): Simplify initialization.
7994         (find_symbol_in_baseclass): Likewise.
7995         * symtab.h (null_block_symbol): Remove.
7996         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7997         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7998         (d_lookup_symbol_module): Likewise.
7999         (find_symbol_in_baseclass): Simplify initialization.
8000
8001 2019-03-24  Tom Tromey  <tom@tromey.com>
8002
8003         * expression.h: Don't include symtab.h.
8004         (struct block): Forward declare.
8005
8006 2019-03-24  Tom Tromey  <tom@tromey.com>
8007
8008         * c-exp.y (typebase): Remove casts.
8009         * gdbtypes.c (lookup_unsigned_typename, )
8010         (lookup_signed_typename): Remove cast.
8011         * eval.c (parse_to_comma_and_eval): Remove cast.
8012         * parse.c (write_dollar_variable): Remove cast.
8013         * block.h (struct block) <superblock>: Now const.
8014         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8015         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8016         (map_block): Make "block" const.
8017         * symfile.h (struct quick_symbol_functions)
8018         <map_matching_symbols>: Constify block argument to "callback".
8019         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8020         const.
8021         (find_pc_sect_compunit_symtab): Make "b" const.
8022         (find_symbol_at_address): Likewise.
8023         (search_symbols): Likewise.
8024         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8025         (dw2_debug_names_lookup_symbol): Likewise.
8026         (dw2_map_matching_symbols): Update.
8027         * p-valprint.c (pascal_val_print): Remove "block".
8028         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8029         (aux_add_nonlocal_symbols): Make "block" const.
8030         (resolve_subexp): Remove cast.
8031         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8032         const.
8033         (iterate_over_file_blocks): Likewise.
8034         * f-exp.y (%union) <bval>: Remove.
8035         * coffread.c (patch_opaque_types): Make "b" const.
8036         * spu-tdep.c (spu_catch_start): Make "block" const.
8037         * c-valprint.c (print_unpacked_pointer): Remove "block".
8038         * symmisc.c (dump_symtab_1): Make "b" const.
8039         (block_depth): Make "block" const.
8040         * d-exp.y (%union) <bval>: Remove.
8041         * cp-support.h (cp_lookup_rtti_type): Update.
8042         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8043         * psymtab.c (psym_lookup_symbol): Make "block" const.
8044         (maintenance_check_psymtabs): Make "b" const.
8045         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8046         (enumerate_locals, enumerate_args): Update.
8047         * python/py-symtab.c (stpy_global_block): Make "block" const.
8048         (stpy_static_block): Likewise.
8049         * inline-frame.c (block_starting_point_at): Make "new_block"
8050         const.
8051         * block.c (find_block_in_blockvector): Make return type const.
8052         (blockvector_for_pc_sect): Make "b" const.
8053         (find_block_in_blockvector): Make "b" const.
8054
8055 2019-03-23  Tom Tromey  <tom@tromey.com>
8056
8057         * varobj.c (varobj_create): Update.
8058         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8059         * printcmd.c (display_command, do_one_display): Don't reset
8060         innermost_block.
8061         * parser-defs.h (enum innermost_block_tracker_type): Move to
8062         expression.h.
8063         (innermost_block): Update comment.
8064         * parse.c (parse_exp_1): Add tracker_types parameter.
8065         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8066         tracker_types parameter.  Reset innermost_block.
8067         (parse_exp_in_context): Remove.
8068         (parse_expression_for_completion): Update.
8069         * objfiles.c (~objfile): Don't reset expression_context_block or
8070         innermost_block.
8071         * expression.h (enum innermost_block_tracker_type): Move from
8072         parser-defs.h.
8073         (parse_exp_1): Add tracker_types parameter.
8074         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8075         reset innermost_block.
8076
8077 2019-03-23  Tom Tromey  <tom@tromey.com>
8078
8079         * objfiles.h: Include bcache.h.
8080
8081 2019-03-23  Tom Tromey  <tom@tromey.com>
8082
8083         * linespec.c (get_current_search_block): Use
8084         scoped_restore_current_language.
8085         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8086
8087 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8088             Jiong Wang  <jiong.wang@arm.com>
8089
8090         * aarch64-linux-tdep.c
8091         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8092         section.
8093         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8094
8095 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8096             Jiong Wang  <jiong.wang@arm.com>
8097
8098         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8099         instructions.
8100         (aarch64_analyze_prologue_test): Add PACIASP test.
8101         (aarch64_prologue_prev_register): Unmask PC value.
8102
8103 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8104             Jiong Wang  <jiong.wang@arm.com>
8105
8106         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8107         (aarch64_dwarf2_prev_register): Unmask PC value.
8108         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8109         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8110         DW_CFA_AARCH64_negate_ra_state.
8111         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8112
8113 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8114             Jiong Wang  <jiong.wang@arm.com>
8115
8116         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8117         registers.
8118         (aarch64_pseudo_register_name): Likewise.
8119         (aarch64_pseudo_register_type): Likewise.
8120         (aarch64_pseudo_register_reggroup_p): Likewise.
8121         (aarch64_gdbarch_init): Add pauth registers.
8122         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8123         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8124         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8125         (struct gdbarch_tdep): Add regnum for ra_state.
8126
8127 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8128             Jiong Wang  <jiong.wang@arm.com>
8129
8130         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8131
8132 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8133             Jiong Wang  <jiong.wang@arm.com>
8134
8135         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8136         function.
8137         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8138         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8139         (aarch64_gdbarch_init): Add puth registers.
8140         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8141         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8142         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8143
8144 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8145             Jiong Wang  <jiong.wang@arm.com>
8146
8147         * aarch64-linux-nat.c
8148         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8149         * aarch64-linux-tdep.c
8150         (aarch64_linux_core_read_description): Likewise.
8151         (aarch64_linux_get_hwcap): New function.
8152         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8153         (aarch64_linux_get_hwcap): New declaration.
8154
8155 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8156             Jiong Wang  <jiong.wang@arm.com>
8157
8158         * aarch64-linux-nat.c
8159         (aarch64_linux_nat_target::read_description): Add pauth param.
8160         * aarch64-linux-tdep.c
8161         (aarch64_linux_core_read_description): Likewise.
8162         * aarch64-tdep.c (struct target_desc): Add in pauth.
8163         (aarch64_read_description): Add pauth param.
8164         (aarch64_gdbarch_init): Likewise.
8165         * aarch64-tdep.h (aarch64_read_description): Likewise.
8166         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8167         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8168         * features/Makefile: Add new files.
8169         * features/aarch64-pauth.c: New file.
8170         * features/aarch64-pauth.xml: New file.
8171
8172 2019-03-20  Tom Tromey  <tromey@adacore.com>
8173
8174         * infrun.c (handle_inferior_event): Rename from
8175         handle_inferior_event_1.  Create a scoped_value_mark.
8176         (handle_inferior_event): Remove.
8177
8178 2019-03-19  Tom Tromey  <tromey@adacore.com>
8179
8180         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8181         * infrun.h (print_stop_event): Add "displays" parameter.
8182         * infrun.c (print_stop_event): Add "displays" parameter.
8183
8184 2019-03-19  Pedro Alves  <palves@redhat.com>
8185
8186         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8187         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8188         to -1.  Fix TABs vs spaces.
8189         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8190         * tui/tui-out.h (tui_ui_out) Add intro comments.
8191         <m_line, m_start_of_line>: In-class initialize, and add describing
8192         comment.
8193
8194 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8195
8196         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8197         variable names.
8198         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8199
8200 2019-03-18  Pedro Alves  <palves@redhat.com>
8201             Eli Zaretskii <eliz@gnu.org>
8202
8203         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8204         m_line and m_start_of_line.
8205
8206 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8207
8208         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8209         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8210         it returns a newline.  This fixes a regression in TU mode, whereby
8211         the next line is output on the same screen line as the user input.
8212
8213 2019-03-18  Tom Tromey  <tromey@adacore.com>
8214
8215         * minsyms.c (minimal_symbol_reader::install): Remove call to
8216         obstack_blank.
8217
8218 2019-03-18  Pedro Alves  <palves@redhat.com>
8219
8220         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8221         New globals.
8222         (apply_style): New, factored out from ...
8223         (apply_ansi_escape): ... this.  Handle reverse video mode.
8224         (tui_set_reverse_mode): New function.
8225         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8226         * tui/tui-winsource.c (tui_show_source_line): Use
8227         tui_set_reverse_mode instead of setting A_STANDOUT.
8228         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8229         New setter methods.
8230
8231 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8232
8233         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8234         Handle tabs.
8235
8236 2019-03-18  Tom Tromey  <tromey@adacore.com>
8237
8238         * ada-lang.c (empty_array): Add "high" parameter.
8239         (ada_evaluate_subexp): Update.
8240
8241 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8242
8243         * unittests/string_view-selftests.c: Define
8244         _initialize_string_view_selftests unconditionally.
8245
8246 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8247
8248         PR gdb/24350
8249         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8250
8251 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8252
8253         PR gdb/24351
8254         * windows-nat.c (display_selector): Fix format specifiers.
8255
8256 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8257
8258         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8259         tui_refill_source_window instead of tui_refresh_win, to update the
8260         current execution line.  This fixes redisplay of the current line
8261         when stepping through the code with "next" or "step".
8262
8263 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8264
8265         * source-cache.c (source_cache::get_source_lines): Call
8266         find_source_lines to initialize s->nlines.  This fixes vertical
8267         scrolling of TUI source window when the DOWN arrow is pressed.
8268
8269 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8270
8271         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8272         linux-thread-db.c (_initialize_thread_db): Likewise.
8273
8274 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8275
8276         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8277         wclrtoeol in tui_show_source_line".  This reverts changes made in
8278         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8279
8280 2019-03-15  Tom Tromey  <tom@tromey.com>
8281
8282         * symtab.h (struct minimal_symbol): Derive from
8283         general_symbol_info.
8284         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8285         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8286         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8287         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8288         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8289         (MSYMBOL_SEARCH_NAME): Update.
8290         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8291         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8292         * minsyms.c (minimal_symbol_reader::record_full): Update.
8293
8294 2019-03-15  Tom Tromey  <tom@tromey.com>
8295
8296         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8297
8298 2019-03-15  Tom Tromey  <tom@tromey.com>
8299
8300         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8301         unique_xmalloc_ptr.
8302         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8303         Update.
8304         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8305         (build_minimal_symbol_hash_tables)
8306         (minimal_symbol_reader::install): Update.
8307
8308 2019-03-15  Tom Tromey  <tom@tromey.com>
8309
8310         * symtab.c (create_demangled_names_hash): Update.
8311         (symbol_set_names): Update.
8312         * objfiles.h (struct objfile_per_bfd_storage)
8313         <demangled_names_hash>: Now an htab_up.
8314         * objfiles.c (objfile_per_bfd_storage): Simplify.
8315
8316 2019-03-15  Tom Tromey  <tom@tromey.com>
8317
8318         * objfiles.h (struct objfile_per_bfd_storage): Declare
8319         destructor.
8320         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8321         New.
8322         (get_objfile_bfd_data): Use new.  Don't initialize
8323         language_of_main.
8324         (free_objfile_per_bfd_storage): Remove.
8325         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8326
8327 2019-03-15  Tom Tromey  <tom@tromey.com>
8328
8329         * symfile.c (reread_symbols): Update.
8330         * objfiles.c (objfile::objfile): Update.
8331         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8332         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8333         comment.
8334         (minimal_symbol_reader::install): Update.
8335         (terminate_minimal_symbol_table): Remove.
8336         * jit.c (jit_object_close_impl): Update.
8337
8338 2019-03-15  Tom Tromey  <tom@tromey.com>
8339
8340         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8341         initializations.
8342
8343 2019-03-15  Tom Tromey  <tom@tromey.com>
8344
8345         * objfiles.h (struct objfile_per_bfd_storage)
8346         <demangled_hash_languages>: Now a bitset.
8347         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8348         (lookup_minimal_symbol): Update.
8349
8350 2019-03-15  Tom Tromey  <tom@tromey.com>
8351
8352         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8353         Don't return the symbol.
8354         * coffread.c (record_minimal_symbol): Use record_full.
8355
8356 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8357
8358         The MS-Windows port of ncurses fails to switch to a color pair if
8359         one or both of the colors are the implicit default colors.  This
8360         change records the default colors when TUI is initialized, and
8361         then specifies them explicitly when a color pair uses the default
8362         colors.  This allows color styling in TUI mode on MS-Windows.
8363
8364         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8365         ncurses_norm_attr.
8366         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8367         colors in ncurses_norm_attr.
8368         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8369         "none", replace it with the default color recorded in
8370         ncurses_norm_attr.
8371
8372 2019-03-14  Tom Tromey  <tromey@adacore.com>
8373
8374         * source-cache.h (class source_cache) <get_source_lines>: Return
8375         std::string.
8376         * source-cache.c (source_cache::extract_lines): Handle case where
8377         first_pos==npos.  Return std::string.
8378         (source_cache::get_source_lines): Update.
8379
8380 2019-03-14  Tom Tromey  <tromey@adacore.com>
8381
8382         * NEWS: Add item for "style sources" commands.
8383         * source-cache.c (source_cache::get_source_lines): Check
8384         source_styling.
8385         * cli/cli-style.c (source_styling): New global.
8386         (_initialize_cli_style): Add "style sources" commands.
8387         (show_style_sources): New function.
8388         * cli/cli-style.h (source_styling): Declare.
8389
8390 2019-03-14  Pedro Alves  <palves@redhat.com>
8391             Tom Tromey  <tromey@adacore.com>
8392
8393         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8394         * tui/tui-winsource.c (tui_refill_source_window): New function,
8395         from...
8396         (tui_horizontal_source_scroll): ... here.  Move some logic.
8397         * cli/cli-style.c (set_style_enabled): Notify new observable.
8398         * tui/tui-hooks.c (tui_redisplay_source): New function.
8399         (tui_attach_detach_observers): Attach or detach
8400         tui_redisplay_source.
8401         * observable.h (source_styling_changed): New observable.
8402         * observable.c: Define source_styling_changed observable.
8403
8404 2019-03-13  Tom Tromey  <tromey@adacore.com>
8405
8406         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8407         (i386_gnu_nat_target::store_registers): Update.
8408         * target-debug.h (target_debug_print_std_string): New macro.
8409         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8410         * windows-tdep.c (display_one_tib): Update.
8411         * tui/tui-stack.c (tui_make_status_line): Update.
8412         * top.c (print_inferior_quit_action): Update.
8413         * thread.c (thr_try_catch_cmd): Update.
8414         (add_thread_with_info): Update.
8415         (thread_target_id_str): Update.
8416         (thr_try_catch_cmd): Update.
8417         (thread_command): Update.
8418         (thread_find_command): Update.
8419         * record-btrace.c (record_btrace_target::info_record)
8420         (record_btrace_resume_thread, record_btrace_target::resume)
8421         (record_btrace_cancel_resume, record_btrace_step_thread)
8422         (record_btrace_target::wait, record_btrace_target::wait)
8423         (record_btrace_target::wait, record_btrace_target::stop): Update.
8424         * progspace.c (print_program_space): Update.
8425         * process-stratum-target.c
8426         (process_stratum_target::thread_address_space): Update.
8427         * linux-fork.c (linux_fork_mourn_inferior)
8428         (detach_checkpoint_command, info_checkpoints_command)
8429         (linux_fork_context): Update.
8430         (linux_fork_detach): Update.
8431         (class scoped_switch_fork_info): Update.
8432         (delete_checkpoint_command): Update.
8433         * infrun.c (follow_fork_inferior): Update.
8434         (follow_fork_inferior): Update.
8435         (proceed_after_vfork_done): Update.
8436         (handle_vfork_child_exec_or_exit): Update.
8437         (follow_exec): Update.
8438         (displaced_step_prepare_throw): Update.
8439         (displaced_step_restore): Update.
8440         (start_step_over): Update.
8441         (resume_1): Update.
8442         (clear_proceed_status_thread): Update.
8443         (proceed): Update.
8444         (print_target_wait_results): Update.
8445         (do_target_wait): Update.
8446         (context_switch): Update.
8447         (stop_all_threads): Update.
8448         (restart_threads): Update.
8449         (finish_step_over): Update.
8450         (handle_signal_stop): Update.
8451         (switch_back_to_stepped_thread): Update.
8452         (keep_going_pass_signal): Update.
8453         (print_exited_reason): Update.
8454         (normal_stop): Update.
8455         * inferior.c (inferior_pid_to_str): Change return type.
8456         (print_selected_inferior): Update.
8457         (add_inferior): Update.
8458         (detach_inferior): Update.
8459         * dummy-frame.c (fprint_dummy_frames): Update.
8460         * dcache.c (dcache_info_1): Update.
8461         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8462         (btrace_fetch, btrace_clear): Update.
8463         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8464         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8465         type.
8466         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8467         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8468         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8469         * gdbarch.c, gdbarch.h: Rebuild.
8470         * gdbarch.sh (core_pid_to_str): Change return type.
8471         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8472         return type.
8473         (windows_nat_target::pid_to_str): Change return type.
8474         (windows_delete_thread): Update.
8475         (windows_nat_target::attach): Update.
8476         (windows_nat_target::files_info): Update.
8477         * target-delegates.c: Rebuild.
8478         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8479         return type.
8480         (sol_thread_target::pid_to_str): Change return type.
8481         * remote.c (class remote_target) <pid_to_str>: Change return
8482         type.
8483         (remote_target::pid_to_str): Change return type.
8484         (extended_remote_target::attach, remote_target::remote_stop_ns)
8485         (remote_target::remote_notif_remove_queued_reply)
8486         (remote_target::push_stop_reply, remote_target::disable_btrace):
8487         Update.
8488         (extended_remote_target::attach): Update.
8489         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8490         type.
8491         (gdbsim_target::pid_to_str): Change return type.
8492         * ravenscar-thread.c (struct ravenscar_thread_target)
8493         <pid_to_str>: Change return type.
8494         (ravenscar_thread_target::pid_to_str): Change return type.
8495         * procfs.c (class procfs_target) <pid_to_str>: Change return
8496         type.
8497         (procfs_target::pid_to_str): Change return type.
8498         (procfs_target::attach): Update.
8499         (procfs_target::detach): Update.
8500         (procfs_target::fetch_registers): Update.
8501         (procfs_target::store_registers): Update.
8502         (procfs_target::wait): Update.
8503         (procfs_target::files_info): Update.
8504         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8505         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8506         return type.
8507         (nto_procfs_target::pid_to_str): Change return type.
8508         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8509         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8510         return type.
8511         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8512         (exit_lwp): Update.
8513         (attach_proc_task_lwp_callback, get_detach_signal)
8514         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8515         (linux_nat_target::resume, wait_lwp, stop_callback)
8516         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8517         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8518         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8519         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8520         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8521         type.
8522         (inf_ptrace_target::attach): Update.
8523         (inf_ptrace_target::files_info): Update.
8524         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8525         type.
8526         (go32_nat_target::pid_to_str): Change return type.
8527         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8528         (gnu_nat_target::wait): Update.
8529         (gnu_nat_target::wait): Update.
8530         (gnu_nat_target::resume): Update.
8531         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8532         (fbsd_nat_target::wait): Update.
8533         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8534         type.
8535         (darwin_nat_target::attach): Update.
8536         * corelow.c (class core_target) <pid_to_str>: Change return type.
8537         (core_target::pid_to_str): Change return type.
8538         * target.c (normal_pid_to_str): Change return type.
8539         (default_pid_to_str): Likewise.
8540         (target_pid_to_str): Change return type.
8541         (target_translate_tls_address): Update.
8542         (target_announce_detach): Update.
8543         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8544         return type.
8545         (bsd_uthread_target::pid_to_str): Change return type.
8546         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8547         type.
8548         (bsd_kvm_target::pid_to_str): Change return type.
8549         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8550         return type.
8551         (aix_thread_target::pid_to_str): Change return type.
8552         * target.h (struct target_ops) <pid_to_str>: Change return type.
8553         (target_pid_to_str, normal_pid_to_str): Likewise.
8554         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8555         type.
8556         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8557         type.
8558         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8559         return type.
8560         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8561         type.
8562         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8563         type.
8564         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8565         return type.
8566
8567 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8568
8569         * NEWS: Mention that the new default MI version is 3.  Mention
8570         changes to the output of commands and events that deal with
8571         multi-location breakpoints.
8572         * breakpoint.c: Include "mi/mi-out.h".
8573         (print_one_breakpoint): Change output syntax if using MI version
8574         >= 3.
8575         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8576         New.
8577         (mi_multi_location_breakpoint_output_fixed): New.
8578         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8579         (mi_cmd_fix_multi_location_breakpoint_output): New.
8580         (mi_multi_location_breakpoint_output_fixed): New.
8581         * mi/mi-cmds.c (mi_cmds): Register command
8582         -fix-multi-location-breakpoint-output.
8583         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8584         interpreter "mi".
8585
8586 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8587
8588         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8589         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8590         instantiate mi_ui_out based on interpreter name.
8591         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8592         * mi/mi-main.c (mi_load_progress): Likewise.
8593
8594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8595
8596         * NEWS: Combine separate "New targets" sections for 8.3.
8597
8598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8599
8600         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8601         (ppcfbsd_init_abi): Install gdbarch
8602         "fetch_tls_load_module_address" and "get_thread_local_address"
8603         methods.
8604
8605 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8606
8607         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8608         (riscv_fbsd_init_abi): Install gdbarch
8609         "fetch_tls_load_module_address" and "get_thread_local_address"
8610         methods.
8611
8612 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8613
8614         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8615         (i386fbsd_init_abi): Install gdbarch
8616         "fetch_tls_load_module_address" and "get_thread_local_address"
8617         methods.
8618
8619 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8620
8621         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8622         (amd64fbsd_init_abi): Install gdbarch
8623         "fetch_tls_load_module_address" and "get_thread_local_address"
8624         methods.
8625
8626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8627
8628         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8629         (struct fbsd_pspace_data): New type.
8630         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8631         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8632         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8633         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8634         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8635
8636 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8637
8638         * gdbtypes.c (lookup_struct_elt): New function.
8639         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8640         * gdbtypes.h (struct struct_elt): New type.
8641         (lookup_struct_elt): New prototype.
8642
8643 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8644
8645         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8646         remove disabled code block.
8647
8648 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8649
8650         * gdbarch.sh (get_thread_local_address): New method.
8651         * gdbarch.h, gdbarch.c: Regenerate.
8652         * target.c (target_translate_tls_address): Use
8653         gdbarch_get_thread_local_address if present instead of
8654         target::get_thread_local_address.
8655
8656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8657
8658         * target.h (target::get_thread_local_address): Update comment.
8659
8660 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8661
8662         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8663         objfile->separate_debug_objfile_backlink if not NULL.
8664
8665 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8666
8667         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8668         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8669         (amd64bsd_store_inferior_registers): Likewise.
8670         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8671         Enable segment base registers.
8672         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8673         PT_GETFSBASE and PT_GETGSBASE.
8674         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8675         PT_SETGSBASE.
8676         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8677         segment base registers.
8678         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8679
8680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8681
8682         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8683         Update calls to i386_target_description to add 'segments'
8684         parameter.
8685         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8686         add segment base registers.
8687         * arch/i386.c (i386_create_target_description): Add 'segments'
8688         parameter to enable segment base registers.
8689         * arch/i386.h (i386_create_target_description): Likewise.
8690         * features/i386/32bit-segments.xml: New file.
8691         * features/i386/32bit-segments.c: Generate.
8692         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8693         call to i386_target_description to add 'segments' parameter.
8694         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8695         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8696         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8697         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8698         if feature is present.
8699         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8700         Add 'segments' parameter to call to i386_target_description.
8701         (i386_target_description): Add 'segments' parameter to enable
8702         segment base registers.
8703         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8704         to call to i386_target_description.
8705         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8706         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8707         Define I386_NUM_REGS.
8708         (i386_target_description): Add 'segments' parameter to enable
8709         segment base registers.
8710
8711 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8712
8713         PR/24325
8714         * source-cache.c: #undef open and close, to avoid unresolved
8715         externals during linking.
8716
8717 2019-03-12  Tom Tromey  <tromey@adacore.com>
8718
8719         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8720         const.  Add initializers.
8721         (_initialize_remote): Don't initialize ptid globals.
8722
8723 2019-03-12  Pedro Alves  <palves@redhat.com>
8724
8725         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8726
8727 2019-03-12  Pedro Alves  <palves@redhat.com>
8728
8729         * cp-name-parser.y (main): Remove unused 'len' variable.
8730
8731 2019-03-12  Tom Tromey  <tromey@adacore.com>
8732
8733         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8734         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8735
8736 2019-03-12  Tom Tromey  <tromey@adacore.com>
8737
8738         * linux-nat.c (iterate_over_lwps): Update.
8739         (stop_callback): Remove parameter.
8740         (stop_wait_callback, detach_callback, resume_set_callback)
8741         (select_singlestep_lwp_callback, set_ignore_sigint)
8742         (status_callback, resumed_callback, resume_clear_callback)
8743         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8744         data parameter.
8745         (linux_nat_target::detach, linux_nat_target::resume)
8746         (linux_stop_and_wait_all_lwps, select_event_lwp)
8747         (linux_nat_filter_event, linux_nat_wait_1)
8748         (linux_nat_target::kill, linux_nat_target::stop)
8749         (linux_nat_target::stop): Update.
8750         (linux_nat_resume_callback): Change type.
8751         (resume_stopped_resumed_lwps, count_events_callback)
8752         (select_event_lwp_callback): Likewise.
8753         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8754         * arm-linux-nat.c (struct update_registers_data): Remove.
8755         (update_registers_callback): Change type.
8756         (arm_linux_insert_hw_breakpoint1): Update.
8757         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8758         parameter.
8759         (x86_linux_dr_set_addr): Update.
8760         (x86_linux_dr_set_control): Update.
8761         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8762         (iterate_over_lwps): Use gdb::function_view.
8763         * nat/aarch64-linux-hw-point.c (struct
8764         aarch64_dr_update_callback_param): Remove.
8765         (debug_reg_change_callback): Change type.
8766         (aarch64_notify_debug_reg_change): Update.
8767         * s390-linux-nat.c (s390_refresh_per_info): Update.
8768
8769 2019-03-11  Tom Tromey  <tromey@adacore.com>
8770
8771         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8772         redundant assignment to "this_cu".
8773
8774 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8775
8776         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8777
8778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8779
8780         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8781         from...
8782         (rank_one_type): ... this.
8783
8784 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8785
8786         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8787         from...
8788         (rank_one_type): ... this.
8789
8790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8791
8792         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8793         from...
8794         (rank_one_type): ... this.
8795
8796 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8797
8798         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8799         from...
8800         (rank_one_type): ... this.
8801
8802 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8803
8804         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8805         from...
8806         (rank_one_type): ... this.
8807
8808 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8809
8810         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8811         from...
8812         (rank_one_type): ... this.
8813
8814 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8815
8816         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8817         from...
8818         (rank_one_type): ... this.
8819
8820 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8821
8822         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8823         from...
8824         (rank_one_type): ... this.
8825
8826 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8827
8828         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8829         from...
8830         (rank_one_type): ... this.
8831
8832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8833
8834         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8835         from...
8836         (rank_one_type): ... this.
8837
8838 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8839
8840         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8841         from...
8842         (rank_one_type): ... this.
8843
8844 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8845
8846         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8847         from...
8848         (rank_one_type): ... this.
8849
8850 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8851
8852         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8853         inferior-events' shows the example events.
8854
8855 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8856
8857         Support styling on native MS-Windows console
8858
8859         PR/24315
8860         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8861         on MS-Windows if $TERM is not defined.
8862
8863         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8864
8865         * posix-hdep.c (gdb_console_fputs):
8866         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8867         functions.
8868         * ui-file.h (gdb_console_fputs): Add prototype.
8869
8870         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8871         back to fputs only if the former returns zero.
8872
8873 2019-03-07  Tom Tromey  <tom@tromey.com>
8874
8875         * symmisc.c (print_symbol_bcache_statistics): Update.
8876         (print_objfile_statistics): Update.
8877         * symfile.c (allocate_symtab): Update.
8878         * stabsread.c: Don't include bcache.h.
8879         * psymtab.h (struct psymbol_bcache): Don't declare.
8880         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8881         (psymbol_bcache_init, psymbol_bcache_free)
8882         (psymbol_bcache_get_bcache): Don't declare.
8883         * psymtab.c (struct psymbol_bcache): Remove.
8884         (psymtab_storage::psymtab_storage): Update.
8885         (psymtab_storage::~psymtab_storage): Update.
8886         (psymbol_bcache_init, psymbol_bcache_free)
8887         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8888         (add_psymbol_to_bcache): Update.
8889         (allocate_psymtab): Update.
8890         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8891         macro_cache>: No longer pointers.
8892         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8893         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8894         * macrotab.c (macro_bcache): Update.
8895         * macroexp.c: Don't include bcache.h.
8896         * gdbtypes.c (check_types_worklist): Update.
8897         (types_deeply_equal): Remove TRY/CATCH.  Update.
8898         * elfread.c (elf_symtab_read): Update.
8899         * dwarf2read.c: Don't include bcache.h.
8900         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8901         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8902         (print_bcache_statistics, bcache_memory_used): Don't declare.
8903         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8904         methods.  Rename all data members.
8905         * bcache.c (struct bcache): Move to bcache.h.
8906         (bcache::expand_hash_table): Rename from expand_hash_table.
8907         (bcache): Remove.
8908         (bcache::insert): Rename from bcache_full.
8909         (bcache::compare): Rename from bcache_compare.
8910         (bcache_xmalloc): Remove.
8911         (bcache::~bcache): Rename from bcache_xfree.
8912         (bcache::print_statistics): Rename from print_bcache_statistics.
8913         (bcache::memory_used): Rename from bcache_memory_used.
8914
8915 2019-03-07  Pedro Alves  <palves@redhat.com>
8916
8917         * infrun.c (normal_stop): Also check for
8918         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8919
8920 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8921
8922         * f-lang.c (value_from_host_double): Moved to...
8923         * value.c (value_from_host_double): ...here.
8924         * value.h (value_from_host_double): Declare.
8925         * guile/scm-math.c (vlscm_convert_typed_number): Use
8926         value_from_host_double.
8927         (vlscm_convert_number): Likewise.
8928         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8929         * python/py-value.c (convert_value_from_python): Likewise.
8930
8931 2019-03-06  Tom Tromey  <tom@tromey.com>
8932
8933         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8934
8935 2019-03-06  Tom Tromey  <tom@tromey.com>
8936
8937         * utils.h (free_current_contents): Don't declare.
8938         * utils.c (free_current_contents): Remove.
8939
8940 2019-03-06  Tom Tromey  <tom@tromey.com>
8941
8942         * top.c (quit_force): Update.
8943         * main.c (captured_command_loop): Update.
8944         * common/new-op.c (operator new): Update.
8945         * common/common-exceptions.c (struct catcher)
8946         <save_cleanup_chain>: Remove member.
8947         (exceptions_state_mc_init): Update.
8948         (exception_try_scope_entry): Return nullptr.
8949         (exception_try_scope_exit, exception_rethrow)
8950         (throw_exception_sjlj, throw_exception_cxx): Update.
8951         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8952         (all_cleanups, do_cleanups, discard_cleanups)
8953         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8954         (restore_cleanups, restore_final_cleanups): Don't declare.
8955         (do_final_cleanups): Remove parameter.
8956         * common/cleanups.c (cleanup_chain, make_cleanup)
8957         (make_cleanup_dtor, all_cleanups, do_cleanups)
8958         (discard_my_cleanups, discard_cleanups)
8959         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8960         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8961         (null_cleanup): Remove.
8962         (do_final_cleanups): Remove parameter.
8963
8964 2019-03-06  Tom Tromey  <tom@tromey.com>
8965
8966         * remote.c (remote_target::remote_parse_stop_reply): Use
8967         unique_xmalloc_ptr.
8968
8969 2019-03-06  Tom Tromey  <tom@tromey.com>
8970
8971         * stabsread.c (struct stabs_field_info): Rename from field_info.
8972         <list, fnlist>: Add initializers.
8973         <obstack>: New member.
8974         (read_member_functions, read_struct_fields, read_baseclasses):
8975         Allocate on obstack.  Don't use cleanups.
8976         (read_one_struct_field, read_member_functions, read_struct_fields)
8977         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8978         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8979         (read_struct_type): Update.
8980
8981 2019-03-06  Tom Tromey  <tom@tromey.com>
8982
8983         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8984         * common/filestuff.h (make_cleanup_close): Don't declare.
8985         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8986         Remove.
8987
8988 2019-03-06  Tom Tromey  <tom@tromey.com>
8989
8990         * solib-aix.c: Use make_scope_exit.
8991
8992 2019-03-06  Tom Tromey  <tom@tromey.com>
8993
8994         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8995         Use make_scope_exit.
8996
8997 2019-03-06  Tom Tromey  <tom@tromey.com>
8998
8999         * solib-svr4.c (disable_probes_interface): Remove parameter.
9000         (svr4_handle_solib_event): Use make_scope_exit.
9001
9002 2019-03-06  Tom Tromey  <tom@tromey.com>
9003
9004         * remote.c (struct stop_reply_deleter): Remove.
9005         (stop_reply_up): Update.
9006         (struct stop_reply): Derive from notif_event.  Don't typedef.
9007         <regcache>: Now a std::vector.
9008         (stop_reply_xfree): Remove.
9009         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9010         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9011         (remote_target::discard_pending_stop_replies): Use delete.
9012         (remote_target::remote_parse_stop_reply): Update.
9013         (remote_target::process_stop_reply): Update.
9014         * remote-notif.h (struct notif_event): Add virtual destructor.
9015         Remove "dtr" member.
9016         (struct notif_client) <alloc_event>: Return a unique_ptr.
9017         (notif_event_xfree): Don't declare.
9018         (notif_event_up): New typedef.
9019         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9020         (notif_event_xfree, do_notif_event_xfree): Remove.
9021         (remote_notif_state_xfree): Update.
9022
9023 2019-03-06  Tom Tromey  <tom@tromey.com>
9024
9025         * infrun.c (displaced_step_clear_cleanup): Now a
9026         forward_scope_exit type.
9027         (displaced_step_prepare_throw): Update.
9028         (displaced_step_fixup): Update.
9029
9030 2019-03-06  Tom Tromey  <tom@tromey.com>
9031
9032         * inferior.h (class inferior): Update comment.
9033         * gdbthread.h (class thread_info): Update comment.
9034
9035 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9036             Tom Tromey  <tom@tromey.com>
9037
9038         * stabsread.h (struct stab_section_list): Remove.
9039         (coffstab_build_psymtabs): Update.
9040         * dbxread.c (symbuf_sections): Now a std::vector.
9041         (sect_idx): New global.
9042         (fill_symbuf): Update.
9043         (coffstab_build_psymtabs): Change type of stabsects parameter.
9044         Update.
9045         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9046         std::vector.
9047         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9048         (coff_locate_sections): Update.
9049         (coff_symfile_read): Remove cleanups.  Update.
9050         (init_stringtab): Add storage parameter.
9051         (free_stringtab, free_stringtab_cleanup): Remove.
9052         (init_lineno): Add storage parameter.
9053         (free_linetab, free_linetab_cleanup): Remove.
9054
9055 2019-03-06  Pedro Alves  <palves@redhat.com>
9056
9057         * linux-fork.c (fork_info::clobber_regs): Delete.
9058         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9059         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9060         comment.  Adjust.
9061         (scoped_switch_fork_info::scoped_switch_fork_info)
9062         (checkpoint_command, linux_fork_context): Adjust
9063         fork_save_infrun_state calls.
9064
9065 2019-03-06  Pedro Alves  <palves@redhat.com>
9066
9067         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9068         (inf_has_multiple_threads): Return 'bool' and rewrite using
9069         inferior_info::threads().
9070
9071 2019-03-06  Pedro Alves  <palves@redhat.com>
9072
9073         * linux-fork.c: Include <list>.
9074         (fork_list): Now a std::list instance.
9075         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9076         (forks_exist_p, find_last_fork): Adjust.
9077         (new_fork): Delete.
9078         (one_fork_p): New.
9079         (add_fork): Adjust.
9080         (free_fork): Delete, folded into fork_info::~fork_info().
9081         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9082         Adjust.
9083         (init_fork_list): Delete.
9084         (linux_fork_killall, linux_fork_mourn_inferior)
9085         (linux_fork_detach, info_checkpoints_command): Adjust.
9086         (_initialize_linux_fork): No longer call init_fork_list.
9087
9088 2019-03-06  Pedro Alves  <palves@redhat.com>
9089
9090         * linux-fork.c (new_fork): New, split out of ...
9091         (add_fork): ... this.  Return void.  Move "first fork" special
9092         case from here, to ...
9093         (checkpoint_command): ... here.
9094         * linux-linux.h (add_fork): Return void.
9095
9096 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9097
9098         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9099
9100 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9101             Chris January  <chris.january@arm.com>
9102             David Lecomber  <david.lecomber@arm.com>
9103
9104         * f-exp.y: New token, UNOP_INTRINSIC.
9105         (exp): New pattern using UNOP_INTRINSIC token.
9106         (f77_keywords): Add 'abs' keyword.
9107         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9108         (value_from_host_double): New function.
9109         (evaluate_subexp_f): Support UNOP_ABS.
9110
9111 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9112
9113         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9114         types.
9115
9116 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9117
9118         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9119         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9120         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9121
9122 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9123
9124         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9125
9126 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9127             Chris January  <chris.january@arm.com>
9128
9129         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9130         * f-exp.y: Define 'KIND' token.
9131         (exp): New pattern for KIND expressions.
9132         (ptype): Handle types with a kind extension.
9133         (direct_abs_decl): Extend to spot kind extensions.
9134         (f77_keywords): Add 'kind' to the list.
9135         (push_kind_type): New function.
9136         (convert_to_kind_type): New function.
9137         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9138         * parse.c (operator_length_standard): Likewise.
9139         * parser-defs.h (enum type_pieces): Add tp_kind.
9140         * std-operator.def: Add UNOP_KIND.
9141
9142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9143
9144         * f-exp.y (f_parse): Set yydebug.
9145
9146 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9147
9148         * f-lang.c (evaluate_subexp_f): New function.
9149         (exp_descriptor_f): New global.
9150         (f_language_defn): Use exp_descriptor_f instead of
9151         exp_descriptor_standard.
9152
9153 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9154
9155         * f-exp.y (struct token): Add comments.
9156         (dot_ops): Remove uppercase versions and the end marker.
9157         (f77_keywords): Likewise.
9158         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9159         entries in the dot_ops array are case insensitive, and use
9160         strncasecmp to compare strings.  Also some whitespace cleanup in
9161         this area.  Similar for the f77_keywords array, except entries in
9162         this list might be case sensitive.
9163
9164 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9165
9166         * f-exp.y (struct f77_boolean_val): Add comments.
9167         (boolean_values): Remove uppercase versions, and end marker.
9168         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9169         and use strncasecmp to achieve case insensitivity.  Additionally,
9170         perform whitespace cleanup around this code.
9171
9172 2019-03-06  Tom Tromey  <tromey@adacore.com>
9173
9174         * remote-sim.c (gdbsim_target_open): Use result of
9175         gdb_argv::release.
9176
9177 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9178         Dirk Schubert  <dirk.schubert@arm.com>
9179         Chris January  <chris.january@arm.com>
9180
9181         * eval.c (evaluate_subexp_standard): Call Fortran argument
9182         wrapping logic.
9183         * f-lang.c (struct value): A value which can be passed into a
9184         Fortran function call.
9185         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9186         where appropriate.
9187         (struct type): Value ready for a Fortran function call.
9188         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9189         is needed.
9190         * f-lang.h (fortran_argument_convert): Declaration.
9191         (fortran_preserve_arg_pointer): Declaration.
9192         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9193
9194 2019-03-05  Tom Tromey  <tromey@adacore.com>
9195
9196         * python/py-prettyprint.c (print_string_repr): Remove #if.
9197         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9198
9199 2019-03-05  Tom Tromey  <tromey@adacore.com>
9200
9201         * target.c (the_dummy_target): Move later.  Change type to
9202         "dummy_target".
9203         (initialize_targets): Don't initialize the_dummy_target.
9204
9205 2019-03-05  Tom Tromey  <tromey@adacore.com>
9206
9207         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9208         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9209
9210 2019-03-05  Tom Tromey  <tromey@adacore.com>
9211
9212         * windows-nat.c (windows_nat_target::attach)
9213         (windows_nat_target::detach): Don't call gdb_flush.
9214         * valprint.c (generic_val_print, val_print, val_print_string):
9215         Don't call gdb_flush.
9216         * utils.c (defaulted_query): Don't call gdb_flush.
9217         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9218         * target.c (target_announce_detach): Don't call gdb_flush.
9219         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9220         * remote.c (extended_remote_target::attach): Don't call
9221         gdb_flush.
9222         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9223         * printcmd.c (do_examine): Don't call gdb_flush.
9224         (info_display_command): Don't call gdb_flush.
9225         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9226         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9227         * memattr.c (info_mem_command): Don't call gdb_flush.
9228         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9229         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9230         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9231         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9232         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9233         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9234         (gnu_nat_target::detach): Don't call gdb_flush.
9235         * f-valprint.c (f_val_print): Don't call gdb_flush.
9236         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9237         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9238         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9239         gdb_flush.
9240         * c-valprint.c (c_val_print): Don't call gdb_flush.
9241         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9242
9243 2019-03-05  Tom Tromey  <tromey@adacore.com>
9244
9245         * varobj.c (update_dynamic_varobj_children): Update.
9246         (install_default_visualizer): Use reset, not release.
9247         * value.c (set_internalvar): Update.
9248         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9249         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9250         ATTRIBUTE_UNUSED_RESULT.
9251
9252 2019-03-05  Tom Tromey  <tromey@adacore.com>
9253
9254         * remote.c (class scoped_remote_fd) <release>: Add
9255         ATTRIBUTE_UNUSED_RESULT.
9256
9257 2019-03-05  Tom Tromey  <tromey@adacore.com>
9258
9259         * macroexp.c (struct macro_buffer) <release>: Add
9260         ATTRIBUTE_UNUSED_RESULT.
9261
9262 2019-03-05  Tom Tromey  <tromey@adacore.com>
9263
9264         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9265         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9266         ATTRIBUTE_UNUSED_RESULT.
9267
9268 2019-03-05  Tom Tromey  <tromey@adacore.com>
9269
9270         * common/scoped_fd.h (class scoped_fd) <release>: Add
9271         ATTRIBUTE_UNUSED_RESULT.
9272
9273 2019-03-05  Tom Tromey  <tromey@adacore.com>
9274
9275         * parser-defs.h (struct parser_state) <release>: Add
9276         ATTRIBUTE_UNUSED_RESULT.
9277
9278 2019-03-05  Tom Tromey  <tromey@adacore.com>
9279
9280         * utils.h (class gdb_argv) <release>: Add
9281         ATTRIBUTE_UNUSED_RESULT.
9282         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9283
9284 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9285
9286         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9287         for-loop range, to avoid compiler warnings.
9288
9289         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9290         avoid compiler warnings about unused variables.
9291
9292         * NEWS: Mention end of support for native debugging on MS-Windows
9293         before XP.
9294
9295         PR gdb/24292
9296         * common/netstuff.c:
9297         * gdbserver/gdbreplay.c
9298         * gdbserver/remote-utils.c:
9299         * ser-tcp.c:
9300         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9301         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9302         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9303         'getaddrinfo' and 'freeaddrinfo' were not available before
9304         Windows XP, and mingw.org's MinGW headers by default define
9305         _WIN32_WINNT to 0x500.
9306
9307 2019-03-01  Gary Benson <gbenson@redhat.com>
9308
9309         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9310
9311 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9312             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9313
9314         PR gdb/8527
9315         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9316         set_sigint_trap, clear_sigint_trap.
9317
9318 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9319
9320         * target.c (target_detach): Clear the regcache and the
9321         frame cache.
9322
9323 2019-02-27  Pedro Alves  <palves@redhat.com>
9324
9325         * utils.c (set_screen_size): When we cap the height/width sizes,
9326         tweak the corresponding command variable to show "unlimited":
9327
9328 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9329             Pedro Alves  <palves@redhat.com>
9330
9331         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9332         before calling rl_set_screen_size.
9333
9334 2019-02-27  Tom Tromey  <tromey@adacore.com>
9335
9336         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9337         define.
9338         * python/py-value.c: Remove Python 2.4 workaround.
9339         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9340         workaround.
9341         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9342         Python 2.4 workaround.
9343         * python/python-internal.h: Remove Python 2.4 comment.
9344         (Py_ssize_t): Don't define.
9345         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9346         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9347         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9348         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9349         * python/python.c (do_start_initialization): Remove Python 2.4
9350         workaround.
9351         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9352         (print_children): Remove Python 2.4 workaround.
9353         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9354         workaround.
9355         (CHARBUFFERPROC_NAME): Remove.
9356         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9357         Python 2.4 workaround.
9358
9359 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9360
9361         * NEWS: Note minimum Python version.
9362
9363 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9364
9365         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9366         code from these functions.  Remove corresponding ifdefs.  Use
9367         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9368         Remove gotos and target of gotos.
9369         (infpy_search_memory): Likewise.
9370
9371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9372
9373         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9374         (hppa_gdbarch_init): Don't register deleted functions with
9375         gdbarch.
9376
9377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9378
9379         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9380         (h8300_unwind_sp): Delete.
9381         (h8300_dummy_id): Delete.
9382         (h8300_gdbarch_init): Don't register deleted functions with
9383         gdbarch.
9384
9385 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9386
9387         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9388         (ft32_unwind_pc): Delete.
9389         (ft32_unwind_sp): Delete.
9390         (ft32_gdbarch_init): Don't register deleted functions with
9391         gdbarch.
9392
9393 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9394
9395         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9396         (frv_unwind_pc): Delete.
9397         (frv_unwind_sp): Delete.
9398         (frv_gdbarch_init): Don't register deleted functions with
9399         gdbarch.
9400
9401 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9402
9403         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9404         (riscv_unwind_pc): Delete.
9405         (riscv_unwind_sp): Delete.
9406         (riscv_gdbarch_init): Don't register deleted functions with
9407         gdbarch.
9408
9409 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9410
9411         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9412         (csky_unwind_pc): Delete.
9413         (csky_unwind_sp): Delete.
9414         (csky_gdbarch_init): Don't register deleted functions with
9415         gdbarch.
9416
9417 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9418
9419         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9420         (cris_unwind_pc): Delete.
9421         (cris_unwind_sp): Delete.
9422         (cris_gdbarch_init): Don't register deleted functions with
9423         gdbarch.
9424
9425 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9426
9427         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9428         (bfin_unwind_pc): Delete.
9429         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9430
9431 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9432
9433         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9434         (arm_unwind_pc): Delete.
9435         (arm_unwind_sp): Delete.
9436         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9437
9438 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9439
9440         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9441         (arc_unwind_pc): Delete.
9442         (arc_unwind_sp): Delete.
9443         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9444
9445 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9446
9447         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9448         (alpha_unwind_pc): Delete.
9449         (alpha_gdbarch_init): Don't register deleted functions with
9450         gdbarch.
9451
9452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9453
9454         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9455         (aarch64_unwind_pc): Delete.
9456         (aarch64_unwind_sp): Delete.
9457         (aarch64_gdbarch_init): Don't register deleted functions with
9458         gdbarch.
9459
9460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9461
9462         * gdbtypes.c (type_align): Don't consider static members when
9463         computing structure alignment.
9464
9465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9466
9467         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9468         return 0 for other types.
9469         * arch-utils.c (default_type_align): Always return 0.
9470         * gdbarch.h: Regenerate.
9471         * gdbarch.sh (type_align): Extend comment.
9472         * gdbtypes.c (type_align): Add additional comments, always call
9473         gdbarch_type_align before applying the default rules.
9474         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9475         generic code will then apply a suitable default.
9476         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9477         types, return 0 for other types.
9478
9479 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9480
9481         * NEWS: Create a new section for the next release branch.
9482         Rename the section of the current branch, now that it has
9483         been cut.
9484
9485 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9486
9487         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9488         * version.in: Bump version to 8.3.50.DATE-git.
9489
9490 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9491
9492         * aix-thread.c (ptid_cmp): Remove unused variable.
9493         (get_signaled_thread): Likewise.
9494         (store_regs_user_thread): Likewise.
9495         (store_regs_kernel_thread): Likewise.
9496         (fetch_regs_kernel_thread): Remove shadowed variable.
9497
9498 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9499
9500         * features/riscv/32bit-cpu.xml: Add register numbers.
9501         * features/riscv/32bit-fpu.c: Regenerate.
9502         * features/riscv/32bit-fpu.xml: Add register numbers.
9503         * features/riscv/64bit-cpu.xml: Add register numbers.
9504         * features/riscv/64bit-fpu.c: Regenerate.
9505         * features/riscv/64bit-fpu.xml: Add register numbers.
9506
9507 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9508
9509         * NEWS: Mention two argument form of gdb.Value constructor.
9510         * python/py-value.c (convert_buffer_and_type_to_value): New
9511         function.
9512         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9513         Add support for handling an optional second argument.  Call
9514         convert_buffer_and_type_to_value as appropriate.
9515         * python/python-internal.h (Py_buffer_deleter): New struct.
9516         (Py_buffer_up): New typedef.
9517
9518 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9519
9520         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9521         instead of releasing ownership.
9522
9523 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9524
9525         * dwarf2read.c (open_and_init_dwp_file): Call
9526         elf_numsections instead of bfd_count_sections to initialize
9527         dwp_file->num_sections.
9528
9529 2019-02-25  Tom Tromey  <tromey@adacore.com>
9530
9531         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9532
9533 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9534
9535         * gcore.in: Add '--readnever' option when invoking GDB.
9536
9537 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9538
9539         * MAINTAINERS: Update my email address.
9540
9541 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9542
9543         * build-id.c (build_id_to_debug_bfd_1): New function.
9544         (build_id_to_debug_bfd): Look for separate debug file in
9545         sysroot.
9546
9547 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9548
9549         * gdbarch.sh: Update the copyright year range that is placed into
9550         generated files.
9551
9552 2019-02-22  Keith Seitz  <keiths@redhat.com>
9553
9554         PR symtab/23853
9555         * linespec.c (create_sals_line_offset): Search for the default
9556         symtab's filename instead of its fullname.
9557
9558 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9559
9560         * NEWS: Update style defaults.
9561
9562 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9563
9564         * main.c (captured_main_1): Disable styling in batch mode.
9565
9566 2019-02-20  Tom Tromey  <tom@tromey.com>
9567
9568         * symtab.c (symtab_symbol_info): Fix typos.
9569
9570 2019-02-20  Tom Tromey  <tromey@adacore.com>
9571
9572         * findcmd.c (_initialize_mem_search): Use upper case for
9573         metasyntactic variables.
9574
9575 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9576
9577         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9578         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9579
9580 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9581
9582         * top.h (source_file_name): Change to std::string.
9583         * top.c (source_file_name): Likewise.
9584         (command_line_input): Adjust.
9585         * cli/cli-script.c (script_from_file): Adjust.
9586
9587 2019-02-19  Tom Tromey  <tromey@adacore.com>
9588
9589         * ravenscar-thread.c
9590         (ravenscar_thread_target::update_thread_list): Don't call
9591         ada_build_task_list.
9592         * ada-lang.h (ada_build_task_list): Don't declare.
9593         * ada-tasks.c (struct ada_tasks_inferior_data)
9594         <task_list_valid_p>: Now bool.
9595         (read_known_tasks, ada_task_list_changed)
9596         (ada_tasks_invalidate_inferior_data): Update.
9597         (read_known_tasks_array): Return bool.
9598         (read_known_tasks_list): Likewise.
9599         (read_known_tasks): Return void.
9600         (ada_build_task_list): Now static.
9601
9602 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9603
9604         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9605         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9606
9607 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9608
9609         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9610         variant for ada_tasks_pspace_data_handle and
9611         ada_tasks_inferior_data_handle.
9612         (ada_tasks_pspace_data_cleanup): New function.
9613         (ada_tasks_inferior_data_cleanup): New function.
9614
9615 2019-02-17  Tom Tromey  <tom@tromey.com>
9616
9617         * macrotab.h (macro_source_fullname): Return a std::string.
9618         * macrotab.c (macro_include, check_for_redefinition)
9619         (macro_undef, macro_lookup_definition, foreach_macro)
9620         (foreach_macro_in_scope): Update.
9621         (macro_source_fullname): Return a std::string.
9622         * macrocmd.c (show_pp_source_pos): Update.
9623
9624 2019-02-17  Tom Tromey  <tom@tromey.com>
9625
9626         * macrocmd.c (show_pp_source_pos): Style the file names.
9627
9628 2019-02-17  Tom Tromey  <tom@tromey.com>
9629
9630         PR tui/24197:
9631         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9632
9633 2019-02-17  Tom Tromey  <tom@tromey.com>
9634
9635         * ada-lang.c (user_select_syms): Use filtered printing.
9636         * utils.c (wrap_style): New global.
9637         (desired_style): Remove.
9638         (emit_style_escape): Add stream parameter.
9639         (set_output_style, reset_terminal_style, prompt_for_continue):
9640         Update.
9641         (flush_wrap_buffer): Only flush gdb_stdout.
9642         (wrap_here): Set wrap_style.
9643         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9644         treat escape sequences as a character.  Change when wrap buffer is
9645         flushed.
9646         (fputs_styled): Do not set the output style when the default is
9647         requested.
9648         * ui-style.h (struct ui_file_style) <is_default>: New method.
9649         * source.c (print_source_lines_base): Emit escape sequences in one
9650         piece.
9651
9652 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9653
9654         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9655         integers and enumeration types.
9656
9657 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9658
9659         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9660         instead of lookup_symbol_in_language
9661         (do_exact_match): New function.
9662         (ada_get_symbol_name_matcher): Return do_exact_match when
9663         doing a verbatim match.
9664
9665 2019-02-15  Tom Tromey  <tromey@adacore.com>
9666
9667         * ravenscar-thread.c (ravenscar_thread_target::resume)
9668         (ravenscar_thread_target::wait): Special case wildcard requests.
9669
9670 2019-02-15  Tom Tromey  <tromey@adacore.com>
9671
9672         * ravenscar-thread.c (base_ptid): Remove.
9673         (struct ravenscar_thread_target) <close>: New method.
9674         <m_base_ptid>: New member.
9675         <update_inferior_ptid, active_task, task_is_currently_active,
9676         runtime_initialized>: Declare methods.
9677         <ravenscar_thread_target>: Add constructor.
9678         (ravenscar_thread_target::task_is_currently_active)
9679         (ravenscar_thread_target::update_inferior_ptid)
9680         (ravenscar_runtime_initialized): Rename.  Now methods.
9681         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9682         (ravenscar_thread_target::update_thread_list): Update.
9683         (ravenscar_thread_target::active_task): Now method.
9684         (ravenscar_thread_target::store_registers)
9685         (ravenscar_thread_target::prepare_to_store)
9686         (ravenscar_thread_target::prepare_to_store)
9687         (ravenscar_thread_target::mourn_inferior): Update.
9688         (ravenscar_inferior_created): Use "new" to create target.
9689         (ravenscar_thread_target::get_ada_task_ptid): Update.
9690         (_initialize_ravenscar): Don't initialize base_ptid.
9691         (ravenscar_ops): Remove global.
9692
9693 2019-02-15  Tom Tromey  <tromey@adacore.com>
9694
9695         * target.h (push_target): Declare new overload.
9696         * target.c (push_target): New overload, taking an rvalue reference.
9697         * remote.c (remote_target::open_1): Use push_target overload.
9698         * corelow.c (core_target_open): Use push_target overload.
9699
9700 2019-02-15  Tom Tromey  <tromey@adacore.com>
9701
9702         * ravenscar-thread.c (is_ravenscar_task)
9703         (ravenscar_task_is_currently_active): Return bool.
9704         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9705         (_initialize_ravenscar): Remove "(void)".
9706         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9707         Return bool.
9708
9709 2019-02-15  Tom Tromey  <tromey@adacore.com>
9710
9711         * ravenscar-thread.c (ravenscar_runtime_initializer)
9712         (has_ravenscar_runtime, get_running_thread_id)
9713         (ravenscar_thread_target::resume): Fix indentation.
9714
9715 2019-02-15  Tom Tromey  <tromey@adacore.com>
9716
9717         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9718         from ravenscar_arch_ops.
9719         (sparc_ravenscar_ops::fetch_registers)
9720         (sparc_ravenscar_ops::store_registers): Now methods.
9721         (sparc_ravenscar_prepare_to_store): Remove.
9722         (sparc_ravenscar_ops): Redefine.
9723         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9724         methods and destructor.  Remove members.
9725         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9726         (ravenscar_thread_target::store_registers)
9727         (ravenscar_thread_target::prepare_to_store): Update.
9728         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9729         Remove.
9730         (struct ppc_ravenscar_powerpc_ops): Derive from
9731         ravenscar_arch_ops.
9732         (ppc_ravenscar_powerpc_ops::fetch_registers)
9733         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9734         (ppc_ravenscar_powerpc_ops): Redefine.
9735         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9736         (ppc_ravenscar_e500_ops::fetch_registers)
9737         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9738         (ppc_ravenscar_e500_ops): Redefine.
9739         * aarch64-ravenscar-thread.c
9740         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9741         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9742         (aarch64_ravenscar_fetch_registers)
9743         (aarch64_ravenscar_store_registers): Now methods.
9744         (aarch64_ravenscar_ops): Redefine.
9745
9746 2019-02-15  Tom Tromey  <tromey@adacore.com>
9747
9748         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9749         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9750         (ravenscar_thread_target::stopped_by_watchpoint)
9751         (ravenscar_thread_target::stopped_data_address)
9752         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9753
9754 2019-02-15  Tom Tromey  <tromey@adacore.com>
9755
9756         * ravenscar-thread.c: Fix some typos.
9757
9758 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9759             Tom Tromey  <tromey@adacore.com>
9760
9761         * ada-lang.c (ada_exception_sal): Change addr_string to a
9762         std::string.
9763         (create_ada_exception_catchpoint): Update.
9764
9765 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9766             Tom Tromey  <tromey@adacore.com>
9767
9768         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9769         (bp_location_ops): Remove.
9770         (base_breakpoint_allocate_location): Update.
9771         (free_bp_location): Update.
9772         * ada-lang.c (class ada_catchpoint_location)
9773         <ada_catchpoint_location>: Remove ops parameter.
9774         (ada_catchpoint_location_dtor): Remove.
9775         (ada_catchpoint_location_ops): Remove.
9776         (allocate_location_exception): Update.
9777         * breakpoint.h (struct bp_location_ops): Remove.
9778         (class bp_location) <bp_location>: Remove bp_location_ops
9779         parameter.
9780         <~bp_location>: Add destructor.
9781         <ops>: Remove.
9782
9783 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9784             Pedro Alves  <palves@redhat.com>
9785
9786         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9787         'PATH_MAX'.
9788
9789 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9790             Samuel Thibault  <samuel.thibault@gnu.org>
9791             Thomas Schwinge  <thomas@codesourcery.com>
9792
9793         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9794         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9795
9796 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9797
9798         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9799         (check_empty): Use "const char *".
9800
9801         * gnu-nat.c (gnu_nat_target::detach): Instead of
9802         'detach_inferior (pid)' call
9803         'detach_inferior (find_inferior_pid (pid))'.
9804
9805         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9806         'nat/fork-inferior.o'.
9807         * gnu-nat.c: #include "nat/fork-inferior.h".
9808
9809         * gnu-nat.c (gnu_nat_target::detach): Instead of
9810         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9811         * gnu-nat.h: #include "inf-child.h".
9812         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9813         'i386_gnu_nat_target::fetch_registers'.
9814         (gnu_store_registers): Rename/move to
9815         'i386_gnu_nat_target::store_registers'.
9816
9817         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9818         * gnu-nat.h (mach_thread_info): New function.
9819         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9820
9821         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9822
9823 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9824
9825         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9826
9827 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9828
9829         * windows-nat.c (windows_add_thread): Add new parameter
9830         "main_thread_p" with default value set to false.  Update
9831         function documentation as well as all callers.
9832         (windows_delete_thread): Likewise.
9833         (fake_create_process): Update call to windows_add_thread.
9834         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9835         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9836         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9837         call to windows_delete_thread.
9838
9839 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9840
9841         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9842
9843 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9844
9845         * symfile.c (find_separate_debug_file): Use canonical path of
9846         sysroot with child_path instead of gdb_sysroot if it is valid.
9847
9848 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9849
9850         * symfile.c (find_separate_debug_file): Use child_path to
9851         determine if an object file is under a sysroot.
9852
9853 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9854
9855         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9856         unittests/child-path-selftests.c.
9857         * common/pathstuff.c (child_path): New function.
9858         * common/pathstuff.h (child_path): New prototype.
9859         * unittests/child-path-selftests.c: New file.
9860
9861 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9862
9863         * symfile.c (find_separate_debug_file): Look for separate debug
9864         files in debug directories under the sysroot.
9865
9866 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9867
9868         * symtab.h (struct minimal_symbol data_p): New const method.
9869         (struct minimal_symbol text_p): Likewise.
9870         * symtab.c (output_source_filename): Use file name style
9871         to print file name.
9872         (print_symbol_info): Likewise.
9873         (print_msymbol_info): Use address style to print addresses.
9874         Use function name style to print executable text symbols.
9875         (expand_symtab_containing_pc): Use data_p.
9876         (find_pc_sect_compunit_symtab): Likewise.
9877
9878 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9879
9880         * breakpoint.c (describe_other_breakpoints): Use address style
9881         to print addresses.
9882         (say_where): Likewise.
9883
9884 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9885
9886         * ada-typeprint.c (print_func_type): Print function name
9887         style to print function name.
9888         * c-typeprint.c (c_print_type_1): Likewise.
9889
9890 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9891
9892         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9893         for execve.
9894
9895 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9896
9897         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9898         type_stack.
9899
9900 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9901
9902         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9903         TYPE_CODE_REF types.
9904
9905 2019-02-08  Jim Wilson  <jimw@sifive.com>
9906
9907         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9908         (riscv_linux_fregset): New.
9909         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9910
9911 2019-02-07  Tom Tromey  <tom@tromey.com>
9912
9913         * thread.c (thread_cancel_execution_command): Update.
9914         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9915         methods.
9916         (struct thread_fsm_ops): Remove.
9917         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9918         (thread_fsm_should_stop, thread_fsm_return_value)
9919         (thread_fsm_set_finished, thread_fsm_finished_p)
9920         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9921         Don't declare.
9922         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9923         * infrun.c (clear_proceed_status_thread)
9924         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9925         (print_stop_event): Update.
9926         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9927         Add constructor.
9928         (step_command_fsm_ops): Remove.
9929         (new_step_command_fsm): Remove.
9930         (step_1): Update.
9931         (step_command_fsm::should_stop): Rename from
9932         step_command_fsm_should_stop.
9933         (step_command_fsm::clean_up): Rename from
9934         step_command_fsm_clean_up.
9935         (step_command_fsm::do_async_reply_reason): Rename from
9936         step_command_fsm_async_reply_reason.
9937         (struct until_next_fsm): Inherit from thread_fsm.  Add
9938         constructor.
9939         (until_next_fsm_ops): Remove.
9940         (new_until_next_fsm): Remove.
9941         (until_next_fsm::should_stop): Rename from
9942         until_next_fsm_should_stop.
9943         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9944         (until_next_fsm::do_async_reply_reason): Rename from
9945         until_next_fsm_async_reply_reason.
9946         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9947         constructor.  Change type of breakpoint.
9948         (finish_command_fsm_ops): Remove.
9949         (new_finish_command_fsm): Remove.
9950         (finish_command_fsm::should_stop): Rename from
9951         finish_command_fsm_should_stop.
9952         (finish_command_fsm::clean_up): Rename from
9953         finish_command_fsm_clean_up.
9954         (finish_command_fsm::return_value): Rename from
9955         finish_command_fsm_return_value.
9956         (finish_command_fsm::do_async_reply_reason): Rename from
9957         finish_command_fsm_async_reply_reason.
9958         (finish_command): Update.
9959         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9960         Add constructor.
9961         (call_thread_fsm_ops): Remove.
9962         (call_thread_fsm::call_thread_fsm): Rename from
9963         new_call_thread_fsm.
9964         (call_thread_fsm::should_stop): Rename from
9965         call_thread_fsm_should_stop.
9966         (call_thread_fsm::should_notify_stop): Rename from
9967         call_thread_fsm_should_notify_stop.
9968         (run_inferior_call, call_function_by_hand_dummy): Update.
9969         * cli/cli-interp.c (should_print_stop_to_console): Update.
9970         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9971         Add constructor.  Change type of location_breakpoint,
9972         caller_breakpoint.
9973         (until_break_fsm_ops): Remove.
9974         (new_until_break_fsm): Remove.
9975         (until_break_fsm::should_stop): Rename from
9976         until_break_fsm_should_stop.
9977         (until_break_fsm::clean_up): Rename from
9978         until_break_fsm_clean_up.
9979         (until_break_fsm::do_async_reply_reason): Rename from
9980         until_break_fsm_async_reply_reason.
9981         (until_break_command): Update.
9982         * thread-fsm.c: Remove.
9983         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9984
9985 2019-02-07  Tom Tromey  <tom@tromey.com>
9986
9987         * yy-remap.h: Add include guard.
9988         * xtensa-tdep.h: Add include guard.
9989         * xcoffread.h: Rename include guard.
9990         * varobj-iter.h: Add include guard.
9991         * tui/tui.h: Rename include guard.
9992         * tui/tui-winsource.h: Rename include guard.
9993         * tui/tui-wingeneral.h: Rename include guard.
9994         * tui/tui-windata.h: Rename include guard.
9995         * tui/tui-win.h: Rename include guard.
9996         * tui/tui-stack.h: Rename include guard.
9997         * tui/tui-source.h: Rename include guard.
9998         * tui/tui-regs.h: Rename include guard.
9999         * tui/tui-out.h: Rename include guard.
10000         * tui/tui-layout.h: Rename include guard.
10001         * tui/tui-io.h: Rename include guard.
10002         * tui/tui-hooks.h: Rename include guard.
10003         * tui/tui-file.h: Rename include guard.
10004         * tui/tui-disasm.h: Rename include guard.
10005         * tui/tui-data.h: Rename include guard.
10006         * tui/tui-command.h: Rename include guard.
10007         * tic6x-tdep.h: Add include guard.
10008         * target/waitstatus.h: Rename include guard.
10009         * target/wait.h: Rename include guard.
10010         * target/target.h: Rename include guard.
10011         * target/resume.h: Rename include guard.
10012         * target-float.h: Rename include guard.
10013         * stabsread.h: Add include guard.
10014         * rs6000-tdep.h: Add include guard.
10015         * riscv-fbsd-tdep.h: Add include guard.
10016         * regformats/regdef.h: Rename include guard.
10017         * record.h: Rename include guard.
10018         * python/python.h: Rename include guard.
10019         * python/python-internal.h: Rename include guard.
10020         * python/py-stopevent.h: Rename include guard.
10021         * python/py-ref.h: Rename include guard.
10022         * python/py-record.h: Rename include guard.
10023         * python/py-record-full.h: Rename include guard.
10024         * python/py-record-btrace.h: Rename include guard.
10025         * python/py-instruction.h: Rename include guard.
10026         * python/py-events.h: Rename include guard.
10027         * python/py-event.h: Rename include guard.
10028         * procfs.h: Add include guard.
10029         * proc-utils.h: Add include guard.
10030         * p-lang.h: Add include guard.
10031         * or1k-tdep.h: Rename include guard.
10032         * observable.h: Rename include guard.
10033         * nto-tdep.h: Rename include guard.
10034         * nat/x86-linux.h: Rename include guard.
10035         * nat/x86-linux-dregs.h: Rename include guard.
10036         * nat/x86-gcc-cpuid.h: Add include guard.
10037         * nat/x86-dregs.h: Rename include guard.
10038         * nat/x86-cpuid.h: Rename include guard.
10039         * nat/ppc-linux.h: Rename include guard.
10040         * nat/mips-linux-watch.h: Rename include guard.
10041         * nat/linux-waitpid.h: Rename include guard.
10042         * nat/linux-ptrace.h: Rename include guard.
10043         * nat/linux-procfs.h: Rename include guard.
10044         * nat/linux-osdata.h: Rename include guard.
10045         * nat/linux-nat.h: Rename include guard.
10046         * nat/linux-namespaces.h: Rename include guard.
10047         * nat/linux-btrace.h: Rename include guard.
10048         * nat/glibc_thread_db.h: Rename include guard.
10049         * nat/gdb_thread_db.h: Rename include guard.
10050         * nat/gdb_ptrace.h: Rename include guard.
10051         * nat/fork-inferior.h: Rename include guard.
10052         * nat/amd64-linux-siginfo.h: Rename include guard.
10053         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10054         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10055         * nat/aarch64-linux.h: Rename include guard.
10056         * nat/aarch64-linux-hw-point.h: Rename include guard.
10057         * mn10300-tdep.h: Add include guard.
10058         * mips-linux-tdep.h: Add include guard.
10059         * mi/mi-parse.h: Rename include guard.
10060         * mi/mi-out.h: Rename include guard.
10061         * mi/mi-main.h: Rename include guard.
10062         * mi/mi-interp.h: Rename include guard.
10063         * mi/mi-getopt.h: Rename include guard.
10064         * mi/mi-console.h: Rename include guard.
10065         * mi/mi-common.h: Rename include guard.
10066         * mi/mi-cmds.h: Rename include guard.
10067         * mi/mi-cmd-break.h: Rename include guard.
10068         * m2-lang.h: Add include guard.
10069         * location.h: Rename include guard.
10070         * linux-record.h: Rename include guard.
10071         * linux-nat.h: Add include guard.
10072         * linux-fork.h: Add include guard.
10073         * i386-darwin-tdep.h: Rename include guard.
10074         * hppa-linux-offsets.h: Add include guard.
10075         * guile/guile.h: Rename include guard.
10076         * guile/guile-internal.h: Rename include guard.
10077         * gnu-nat.h: Rename include guard.
10078         * gdb-stabs.h: Rename include guard.
10079         * frv-tdep.h: Add include guard.
10080         * f-lang.h: Add include guard.
10081         * event-loop.h: Add include guard.
10082         * darwin-nat.h: Rename include guard.
10083         * cp-abi.h: Rename include guard.
10084         * config/sparc/nm-sol2.h: Rename include guard.
10085         * config/nm-nto.h: Rename include guard.
10086         * config/nm-linux.h: Add include guard.
10087         * config/i386/nm-i386gnu.h: Rename include guard.
10088         * config/djgpp/nl_types.h: Rename include guard.
10089         * config/djgpp/langinfo.h: Rename include guard.
10090         * compile/gcc-cp-plugin.h: Add include guard.
10091         * compile/gcc-c-plugin.h: Add include guard.
10092         * compile/compile.h: Rename include guard.
10093         * compile/compile-object-run.h: Rename include guard.
10094         * compile/compile-object-load.h: Rename include guard.
10095         * compile/compile-internal.h: Rename include guard.
10096         * compile/compile-cplus.h: Rename include guard.
10097         * compile/compile-c.h: Rename include guard.
10098         * common/xml-utils.h: Rename include guard.
10099         * common/x86-xstate.h: Rename include guard.
10100         * common/version.h: Rename include guard.
10101         * common/vec.h: Rename include guard.
10102         * common/tdesc.h: Rename include guard.
10103         * common/selftest.h: Rename include guard.
10104         * common/scoped_restore.h: Rename include guard.
10105         * common/scoped_mmap.h: Rename include guard.
10106         * common/scoped_fd.h: Rename include guard.
10107         * common/safe-iterator.h: Rename include guard.
10108         * common/run-time-clock.h: Rename include guard.
10109         * common/refcounted-object.h: Rename include guard.
10110         * common/queue.h: Rename include guard.
10111         * common/ptid.h: Rename include guard.
10112         * common/print-utils.h: Rename include guard.
10113         * common/preprocessor.h: Rename include guard.
10114         * common/pathstuff.h: Rename include guard.
10115         * common/observable.h: Rename include guard.
10116         * common/netstuff.h: Rename include guard.
10117         * common/job-control.h: Rename include guard.
10118         * common/host-defs.h: Rename include guard.
10119         * common/gdb_wait.h: Rename include guard.
10120         * common/gdb_vecs.h: Rename include guard.
10121         * common/gdb_unlinker.h: Rename include guard.
10122         * common/gdb_unique_ptr.h: Rename include guard.
10123         * common/gdb_tilde_expand.h: Rename include guard.
10124         * common/gdb_sys_time.h: Rename include guard.
10125         * common/gdb_string_view.h: Rename include guard.
10126         * common/gdb_splay_tree.h: Rename include guard.
10127         * common/gdb_setjmp.h: Rename include guard.
10128         * common/gdb_ref_ptr.h: Rename include guard.
10129         * common/gdb_optional.h: Rename include guard.
10130         * common/gdb_locale.h: Rename include guard.
10131         * common/gdb_assert.h: Rename include guard.
10132         * common/filtered-iterator.h: Rename include guard.
10133         * common/filestuff.h: Rename include guard.
10134         * common/fileio.h: Rename include guard.
10135         * common/environ.h: Rename include guard.
10136         * common/common-utils.h: Rename include guard.
10137         * common/common-types.h: Rename include guard.
10138         * common/common-regcache.h: Rename include guard.
10139         * common/common-inferior.h: Rename include guard.
10140         * common/common-gdbthread.h: Rename include guard.
10141         * common/common-exceptions.h: Rename include guard.
10142         * common/common-defs.h: Rename include guard.
10143         * common/common-debug.h: Rename include guard.
10144         * common/cleanups.h: Rename include guard.
10145         * common/buffer.h: Rename include guard.
10146         * common/btrace-common.h: Rename include guard.
10147         * common/break-common.h: Rename include guard.
10148         * cli/cli-utils.h: Rename include guard.
10149         * cli/cli-style.h: Rename include guard.
10150         * cli/cli-setshow.h: Rename include guard.
10151         * cli/cli-script.h: Rename include guard.
10152         * cli/cli-interp.h: Rename include guard.
10153         * cli/cli-decode.h: Rename include guard.
10154         * cli/cli-cmds.h: Rename include guard.
10155         * charset-list.h: Add include guard.
10156         * buildsym-legacy.h: Rename include guard.
10157         * bfin-tdep.h: Add include guard.
10158         * ax.h: Rename include guard.
10159         * arm-linux-tdep.h: Add include guard.
10160         * arm-fbsd-tdep.h: Add include guard.
10161         * arch/xtensa.h: Rename include guard.
10162         * arch/tic6x.h: Add include guard.
10163         * arch/i386.h: Add include guard.
10164         * arch/arm.h: Rename include guard.
10165         * arch/arm-linux.h: Rename include guard.
10166         * arch/arm-get-next-pcs.h: Rename include guard.
10167         * arch/amd64.h: Add include guard.
10168         * arch/aarch64-insn.h: Rename include guard.
10169         * arch-utils.h: Rename include guard.
10170         * annotate.h: Add include guard.
10171         * amd64-darwin-tdep.h: Rename include guard.
10172         * aarch64-linux-tdep.h: Add include guard.
10173         * aarch64-fbsd-tdep.h: Add include guard.
10174         * aarch32-linux-nat.h: Add include guard.
10175
10176 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10177
10178         * macrotab.c (macro_define_internal): New function that
10179         factorizes macro_define_object_internal and macro_define_function
10180         code.
10181         (macro_define_object_internal): Use macro_define_internal.
10182         (macro_define_function): Likewise.
10183
10184 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10185
10186         * macrocmd.c (extract_identifier): Return
10187         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10188         callers.
10189
10190 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10191
10192         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10193
10194 2019-02-05  Tom Tromey  <tom@tromey.com>
10195
10196         * target.c (target_stack::unpush): Move assertion earlier.
10197
10198 2019-01-30  Tom Tromey  <tom@tromey.com>
10199
10200         PR python/23615:
10201         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10202         (gdbpy_parse_and_eval): Likewise.
10203         * python/python-internal.h (gdbpy_allow_threads): New class.
10204
10205 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10206
10207         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10208         (aarch64_fbsd_fpregmap): Move earlier.
10209         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10210         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10211         instead of individual calls to trad_frame_set_reg_addr.
10212         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10213         earlier.
10214         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10215         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10216         instead of individual calls to trad_frame_set_reg_addr.
10217
10218 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10219
10220         * CONTRIBUTE: Replace contribution list with wiki link.
10221
10222 2019-01-25  Tom Tromey  <tom@tromey.com>
10223
10224         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10225
10226 2019-01-25  Tom Tromey  <tom@tromey.com>
10227
10228         * xtensa-linux-nat.c: Fix common/ includes.
10229         * xml-support.h: Fix common/ includes.
10230         * xml-support.c: Fix common/ includes.
10231         * x86-linux-nat.c: Fix common/ includes.
10232         * windows-nat.c: Fix common/ includes.
10233         * varobj.h: Fix common/ includes.
10234         * varobj.c: Fix common/ includes.
10235         * value.c: Fix common/ includes.
10236         * valops.c: Fix common/ includes.
10237         * utils.c: Fix common/ includes.
10238         * unittests/xml-utils-selftests.c: Fix common/ includes.
10239         * unittests/utils-selftests.c: Fix common/ includes.
10240         * unittests/unpack-selftests.c: Fix common/ includes.
10241         * unittests/tracepoint-selftests.c: Fix common/ includes.
10242         * unittests/style-selftests.c: Fix common/ includes.
10243         * unittests/string_view-selftests.c: Fix common/ includes.
10244         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10245         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10246         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10247         * unittests/rsp-low-selftests.c: Fix common/ includes.
10248         * unittests/parse-connection-spec-selftests.c: Fix common/
10249         includes.
10250         * unittests/optional-selftests.c: Fix common/ includes.
10251         * unittests/offset-type-selftests.c: Fix common/ includes.
10252         * unittests/observable-selftests.c: Fix common/ includes.
10253         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10254         * unittests/memrange-selftests.c: Fix common/ includes.
10255         * unittests/memory-map-selftests.c: Fix common/ includes.
10256         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10257         * unittests/function-view-selftests.c: Fix common/ includes.
10258         * unittests/environ-selftests.c: Fix common/ includes.
10259         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10260         * unittests/common-utils-selftests.c: Fix common/ includes.
10261         * unittests/cli-utils-selftests.c: Fix common/ includes.
10262         * unittests/array-view-selftests.c: Fix common/ includes.
10263         * ui-file.c: Fix common/ includes.
10264         * tui/tui-io.c: Fix common/ includes.
10265         * tracepoint.h: Fix common/ includes.
10266         * tracepoint.c: Fix common/ includes.
10267         * tracefile-tfile.c: Fix common/ includes.
10268         * top.h: Fix common/ includes.
10269         * top.c: Fix common/ includes.
10270         * thread.c: Fix common/ includes.
10271         * target/waitstatus.h: Fix common/ includes.
10272         * target/waitstatus.c: Fix common/ includes.
10273         * target.h: Fix common/ includes.
10274         * target.c: Fix common/ includes.
10275         * target-memory.c: Fix common/ includes.
10276         * target-descriptions.c: Fix common/ includes.
10277         * symtab.h: Fix common/ includes.
10278         * symfile.c: Fix common/ includes.
10279         * stap-probe.c: Fix common/ includes.
10280         * spu-linux-nat.c: Fix common/ includes.
10281         * sparc-nat.c: Fix common/ includes.
10282         * source.c: Fix common/ includes.
10283         * solib.c: Fix common/ includes.
10284         * solib-target.c: Fix common/ includes.
10285         * ser-unix.c: Fix common/ includes.
10286         * ser-tcp.c: Fix common/ includes.
10287         * ser-pipe.c: Fix common/ includes.
10288         * ser-base.c: Fix common/ includes.
10289         * selftest-arch.c: Fix common/ includes.
10290         * s12z-tdep.c: Fix common/ includes.
10291         * rust-exp.y: Fix common/ includes.
10292         * rs6000-aix-tdep.c: Fix common/ includes.
10293         * riscv-tdep.c: Fix common/ includes.
10294         * remote.c: Fix common/ includes.
10295         * remote-notif.h: Fix common/ includes.
10296         * remote-fileio.h: Fix common/ includes.
10297         * remote-fileio.c: Fix common/ includes.
10298         * regcache.h: Fix common/ includes.
10299         * regcache.c: Fix common/ includes.
10300         * record-btrace.c: Fix common/ includes.
10301         * python/python.c: Fix common/ includes.
10302         * python/py-type.c: Fix common/ includes.
10303         * python/py-inferior.c: Fix common/ includes.
10304         * progspace.h: Fix common/ includes.
10305         * producer.c: Fix common/ includes.
10306         * procfs.c: Fix common/ includes.
10307         * proc-api.c: Fix common/ includes.
10308         * printcmd.c: Fix common/ includes.
10309         * ppc-linux-nat.c: Fix common/ includes.
10310         * parser-defs.h: Fix common/ includes.
10311         * osdata.c: Fix common/ includes.
10312         * obsd-nat.c: Fix common/ includes.
10313         * nat/x86-linux.c: Fix common/ includes.
10314         * nat/x86-linux-dregs.c: Fix common/ includes.
10315         * nat/x86-dregs.h: Fix common/ includes.
10316         * nat/x86-dregs.c: Fix common/ includes.
10317         * nat/ppc-linux.c: Fix common/ includes.
10318         * nat/mips-linux-watch.h: Fix common/ includes.
10319         * nat/mips-linux-watch.c: Fix common/ includes.
10320         * nat/linux-waitpid.c: Fix common/ includes.
10321         * nat/linux-ptrace.h: Fix common/ includes.
10322         * nat/linux-ptrace.c: Fix common/ includes.
10323         * nat/linux-procfs.c: Fix common/ includes.
10324         * nat/linux-personality.c: Fix common/ includes.
10325         * nat/linux-osdata.c: Fix common/ includes.
10326         * nat/linux-namespaces.c: Fix common/ includes.
10327         * nat/linux-btrace.h: Fix common/ includes.
10328         * nat/linux-btrace.c: Fix common/ includes.
10329         * nat/fork-inferior.c: Fix common/ includes.
10330         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10331         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10332         * nat/aarch64-linux.c: Fix common/ includes.
10333         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10334         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10335         * namespace.h: Fix common/ includes.
10336         * mips-linux-tdep.c: Fix common/ includes.
10337         * minsyms.c: Fix common/ includes.
10338         * mi/mi-parse.h: Fix common/ includes.
10339         * mi/mi-main.c: Fix common/ includes.
10340         * mi/mi-cmd-env.c: Fix common/ includes.
10341         * memrange.h: Fix common/ includes.
10342         * memattr.c: Fix common/ includes.
10343         * maint.h: Fix common/ includes.
10344         * maint.c: Fix common/ includes.
10345         * main.c: Fix common/ includes.
10346         * machoread.c: Fix common/ includes.
10347         * location.c: Fix common/ includes.
10348         * linux-thread-db.c: Fix common/ includes.
10349         * linux-nat.c: Fix common/ includes.
10350         * linux-fork.c: Fix common/ includes.
10351         * inline-frame.c: Fix common/ includes.
10352         * infrun.c: Fix common/ includes.
10353         * inflow.c: Fix common/ includes.
10354         * inferior.h: Fix common/ includes.
10355         * inferior.c: Fix common/ includes.
10356         * infcmd.c: Fix common/ includes.
10357         * inf-ptrace.c: Fix common/ includes.
10358         * inf-child.c: Fix common/ includes.
10359         * ia64-linux-nat.c: Fix common/ includes.
10360         * i387-tdep.c: Fix common/ includes.
10361         * i386-tdep.c: Fix common/ includes.
10362         * i386-linux-tdep.c: Fix common/ includes.
10363         * i386-linux-nat.c: Fix common/ includes.
10364         * i386-go32-tdep.c: Fix common/ includes.
10365         * i386-fbsd-tdep.c: Fix common/ includes.
10366         * i386-fbsd-nat.c: Fix common/ includes.
10367         * guile/scm-type.c: Fix common/ includes.
10368         * guile/guile.c: Fix common/ includes.
10369         * go32-nat.c: Fix common/ includes.
10370         * gnu-nat.c: Fix common/ includes.
10371         * gdbthread.h: Fix common/ includes.
10372         * gdbarch-selftests.c: Fix common/ includes.
10373         * gdb_usleep.c: Fix common/ includes.
10374         * gdb_select.h: Fix common/ includes.
10375         * gdb_bfd.c: Fix common/ includes.
10376         * gcore.c: Fix common/ includes.
10377         * fork-child.c: Fix common/ includes.
10378         * findvar.c: Fix common/ includes.
10379         * fbsd-nat.c: Fix common/ includes.
10380         * event-top.c: Fix common/ includes.
10381         * event-loop.c: Fix common/ includes.
10382         * dwarf2read.c: Fix common/ includes.
10383         * dwarf2loc.c: Fix common/ includes.
10384         * dwarf2-frame.c: Fix common/ includes.
10385         * dwarf-index-cache.c: Fix common/ includes.
10386         * dtrace-probe.c: Fix common/ includes.
10387         * disasm-selftests.c: Fix common/ includes.
10388         * defs.h: Fix common/ includes.
10389         * csky-tdep.c: Fix common/ includes.
10390         * cp-valprint.c: Fix common/ includes.
10391         * cp-support.h: Fix common/ includes.
10392         * cp-support.c: Fix common/ includes.
10393         * corelow.c: Fix common/ includes.
10394         * completer.h: Fix common/ includes.
10395         * completer.c: Fix common/ includes.
10396         * compile/compile.c: Fix common/ includes.
10397         * compile/compile-loc2c.c: Fix common/ includes.
10398         * compile/compile-cplus-types.c: Fix common/ includes.
10399         * compile/compile-cplus-symbols.c: Fix common/ includes.
10400         * command.h: Fix common/ includes.
10401         * cli/cli-dump.c: Fix common/ includes.
10402         * cli/cli-cmds.c: Fix common/ includes.
10403         * charset.c: Fix common/ includes.
10404         * build-id.c: Fix common/ includes.
10405         * btrace.h: Fix common/ includes.
10406         * btrace.c: Fix common/ includes.
10407         * breakpoint.h: Fix common/ includes.
10408         * breakpoint.c: Fix common/ includes.
10409         * ax.h:
10410         (enum agent_op): Fix common/ includes.
10411         * ax-general.c (struct aop_map): Fix common/ includes.
10412         * ax-gdb.c: Fix common/ includes.
10413         * auxv.c: Fix common/ includes.
10414         * auto-load.c: Fix common/ includes.
10415         * arm-tdep.c: Fix common/ includes.
10416         * arch/riscv.c: Fix common/ includes.
10417         * arch/ppc-linux-common.c: Fix common/ includes.
10418         * arch/i386.c: Fix common/ includes.
10419         * arch/arm.c: Fix common/ includes.
10420         * arch/arm-linux.c: Fix common/ includes.
10421         * arch/arm-get-next-pcs.c: Fix common/ includes.
10422         * arch/amd64.c: Fix common/ includes.
10423         * arch/aarch64.c: Fix common/ includes.
10424         * arch/aarch64-insn.c: Fix common/ includes.
10425         * arch-utils.c: Fix common/ includes.
10426         * amd64-windows-tdep.c: Fix common/ includes.
10427         * amd64-tdep.c: Fix common/ includes.
10428         * amd64-sol2-tdep.c: Fix common/ includes.
10429         * amd64-obsd-tdep.c: Fix common/ includes.
10430         * amd64-nbsd-tdep.c: Fix common/ includes.
10431         * amd64-linux-tdep.c: Fix common/ includes.
10432         * amd64-linux-nat.c: Fix common/ includes.
10433         * amd64-fbsd-tdep.c: Fix common/ includes.
10434         * amd64-fbsd-nat.c: Fix common/ includes.
10435         * amd64-dicos-tdep.c: Fix common/ includes.
10436         * amd64-darwin-tdep.c: Fix common/ includes.
10437         * agent.c: Fix common/ includes.
10438         * ada-lang.h: Fix common/ includes.
10439         * ada-lang.c: Fix common/ includes.
10440         * aarch64-tdep.c: Fix common/ includes.
10441
10442 2019-01-25  Tom Tromey  <tom@tromey.com>
10443
10444         * common/create-version.sh: Use common/version.h.
10445
10446 2019-01-24  Pedro Alves  <palves@redhat.com>
10447
10448         * infrun.c (signal_stop, signal_print, signal_program)
10449         (signal_catch, signal_pass): Now arrays instead of pointers.
10450         (update_signals_program_target, do_target_resume)
10451         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10452         * linux-nat.c (linux_nat_target::pass_signals)
10453         (linux_nat_target::create_inferior, linux_nat_target::attach):
10454         Adjust.
10455         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10456         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10457         * procfs.c (procfs_target::pass_signals): Adjust.
10458         * record-full.c (record_full_target::resume): Adjust.
10459         * remote.c (remote_target::pass_signals)
10460         (remote_target::program_signals): Adjust.
10461         * target-debug.h (target_debug_print_signals): Now takes a
10462         gdb::array_view as parameter.  Adjust.
10463         * target.h (target_ops) <pass_signals, program_signals>: Replace
10464         pointer and length parameters with gdb::array_view.
10465         (target_pass_signals, target_program_signals): Likewise.
10466         * target-delegates.c: Regenerate.
10467
10468 2019-01-24  Pedro Alves  <palves@redhat.com>
10469
10470         * common/forward-scope-exit.h
10471         (forward_scope_exit::forward_scope_exit): Pass arguments to
10472         m_bind_function directly, instead of creating a std::bind and
10473         copying that.
10474
10475 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10476
10477         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10478         for static members.
10479         (pass_in_v_vfp_candidate): Likewise.
10480
10481 2019-01-23  Tom Tromey  <tom@tromey.com>
10482             Pedro Alves  <palves@redhat.com>
10483
10484         * regcache.c (class regcache_invalidator): Remove.
10485         (regcache::raw_write): Use make_scope_exit.
10486
10487 2019-01-23  Tom Tromey  <tom@tromey.com>
10488
10489         * ui-out.h (class ui_out_emit_type): Update comment.
10490
10491 2019-01-23  Tom Tromey  <tom@tromey.com>
10492
10493         * infrun.c (fetch_inferior_event): Update comment.
10494
10495 2019-01-23  Tom Tromey  <tom@tromey.com>
10496             Pedro Alves  <palves@redhat.com>
10497
10498         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10499         parameter.
10500         (fetch_inferior_event): Use SCOPE_EXIT.
10501
10502
10503 2019-01-23  Tom Tromey  <tom@tromey.com>
10504             Pedro Alves  <palves@redhat.com>
10505
10506         * infrun.c (disable_thread_events): Delete.
10507         (stop_all_threads): Use SCOPE_EXIT.
10508
10509 2019-01-23  Tom Tromey  <tom@tromey.com>
10510             Pedro Alves  <palves@redhat.com>
10511
10512         * symfile.c: Include forward-scope-exit.h.
10513         (clear_symtab_users_cleanup): Replace forward declaration with
10514         a FORWARD_SCOPE_EXIT.
10515         (syms_from_objfile_1): Use the forward_scope_exit and
10516         gdb::optional instead of cleanup_function.
10517         (reread_symbols): Use the forward_scope_exit instead of
10518         cleanup_function.
10519         (clear_symtab_users_cleanup): Remove function.
10520
10521 2019-01-23  Tom Tromey  <tom@tromey.com>
10522             Pedro Alves  <palves@redhat.com>
10523
10524         * linux-nat.c: Include scope-exit.h.
10525         (cleanup_target_stop): Remove.
10526         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10527         SCOPE_EXIT.
10528
10529 2019-01-23  Tom Tromey  <tom@tromey.com>
10530             Pedro Alves  <palves@redhat.com>
10531
10532         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10533         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10534
10535 2019-01-23  Tom Tromey  <tom@tromey.com>
10536             Andrew Burgess  <andrew.burgess@embecosm.com>
10537             Pedro Alves  <palves@redhat.com>
10538
10539         * infrun.c (fetch_inferior_event): Use scope_exit.
10540         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10541         * top.c (execute_command): Use scope_exit.
10542         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10543         * utils.c (do_bpstat_clear_actions_cleanup)
10544         (make_bpstat_clear_actions_cleanup): Remove.
10545
10546 2019-01-23  Tom Tromey  <tom@tromey.com>
10547             Pedro Alves  <palves@redhat.com>
10548
10549         * infrun.c: Include "common/scope-exit.h"
10550         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10551         (wait_for_inferior): Use SCOPE_EXIT.
10552         (fetch_inferior_event): Use scope_exit.
10553
10554 2019-01-23  Tom Tromey  <tom@tromey.com>
10555             Pedro Alves  <palves@redhat.com>
10556
10557         * breakpoint.c (create_breakpoint): Remove cleanup.
10558
10559 2019-01-23  Tom Tromey  <tom@tromey.com>
10560             Andrew Burgess  <andrew.burgess@embecosm.com>
10561             Pedro Alves  <palves@redhat.com>
10562
10563 2019-01-23  Pedro Alves  <palves@redhat.com>
10564
10565         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10566
10567 2019-01-23  Pedro Alves  <palves@redhat.com>
10568             Andrew Burgess  <andrew.burgess@embecosm.com>
10569
10570         * gdbthread.h: Include "common/forward-scope-exit.h".
10571         (scoped_finish_thread_state): Redefine custom class in terms of
10572         forward_scope_exit.
10573
10574 2019-01-23  Pedro Alves  <palves@redhat.com>
10575             Andrew Burgess  <andrew.burgess@embecosm.com>
10576
10577         * common/forward-scope-exit.h: New file.
10578
10579 2019-01-23  Pedro Alves  <palves@redhat.com>
10580             Andrew Burgess  <andrew.burgess@embecosm.com>
10581             Tom Tromey  <tom@tromey.com>
10582
10583         * common/scope-exit.h: New file.
10584
10585 2019-01-23  Pedro Alves  <palves@redhat.com>
10586
10587         * common/preprocessor.h (ESC): Rename to ...
10588         (ESC_PARENS): ... this.
10589         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10590         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10591
10592 2019-01-23  Tom Tromey  <tom@tromey.com>
10593
10594         * language.h (class scoped_switch_to_sym_language_if_auto):
10595         Initialize m_lang in both cases.
10596
10597 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10598
10599         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10600         with XCNEW.
10601
10602 2019-01-22  Tom Tromey  <tom@tromey.com>
10603
10604         * corelow.c: Do not include sys/file.h.
10605
10606 2019-01-22  Tom Tromey  <tom@tromey.com>
10607
10608         * tui/tui-wingeneral.h: Include gdb_curses.h.
10609
10610 2019-01-22  Tom Tromey  <tom@tromey.com>
10611
10612         * source-cache.h (class source_cache) <get_source_lines,
10613         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10614
10615 2019-01-22  Tom Tromey  <tom@tromey.com>
10616
10617         * remote-fileio.h (struct remote_target): Declare.
10618
10619 2019-01-22  Tom Tromey  <tom@tromey.com>
10620
10621         * python/py-arch.c: Do not include py-ref.h.
10622         * python/py-bpevent.c: Do not include py-ref.h.
10623         * python/py-cmd.c: Do not include py-ref.h.
10624         * python/py-continueevent.c: Do not include py-ref.h.
10625         * python/py-event.h: Do not include py-ref.h.
10626         * python/py-evtregistry.c: Do not include py-ref.h.
10627         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10628         * python/py-frame.c: Do not include py-ref.h.
10629         * python/py-framefilter.c: Do not include py-ref.h.
10630         * python/py-function.c: Do not include py-ref.h.
10631         * python/py-infevents.c: Do not include py-ref.h.
10632         * python/py-linetable.c: Do not include py-ref.h.
10633         * python/py-objfile.c: Do not include py-ref.h.
10634         * python/py-param.c: Do not include py-ref.h.
10635         * python/py-prettyprint.c: Do not include py-ref.h.
10636         * python/py-progspace.c: Do not include py-ref.h.
10637         * python/py-symbol.c: Do not include py-ref.h.
10638         * python/py-symtab.c: Do not include py-ref.h.
10639         * python/py-type.c: Do not include py-ref.h.
10640         * python/py-unwind.c: Do not include py-ref.h.
10641         * python/py-utils.c: Do not include py-ref.h.
10642         * python/py-value.c: Do not include py-ref.h.
10643         * python/py-varobj.c: Do not include py-ref.h.
10644         * python/py-xmethods.c: Do not include py-ref.h.
10645         * python/python.c: Do not include py-ref.h.
10646         * varobj.c: Do not include py-ref.h.
10647
10648 2019-01-22  Tom Tromey  <tom@tromey.com>
10649
10650         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10651         keyword for bcache.
10652
10653 2019-01-22  Tom Tromey  <tom@tromey.com>
10654
10655         * compile/compile-cplus-types.c: Remove a comment by #include.
10656
10657 2019-01-22  Tom Tromey  <tom@tromey.com>
10658
10659         * compile/gcc-c-plugin.h: Include compile-internal.h.
10660
10661 2019-01-22  Tom Tromey  <tom@tromey.com>
10662
10663         * stabsread.c (EXTERN): Do not define.
10664         (symnum, next_symbol_text_func, processing_gcc_compilation)
10665         (within_function, global_sym_chain, global_stabs)
10666         (previous_stab_code, this_object_header_files)
10667         (n_this_object_header_files)
10668         (n_allocated_this_object_header_files): Define.
10669         * stabsread.h (EXTERN): Never define.  Use "extern".
10670
10671 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10672
10673         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10674         history_value.
10675
10676 2019-01-21  Tom Tromey  <tom@tromey.com>
10677
10678         * ui-out.c: Fix includes.
10679         * tui/tui-source.c: Fix includes.
10680         * target.c: Fix includes.
10681         * remote.c: Fix includes.
10682         * regcache.c: Fix includes.
10683         * python/py-block.c: Fix includes.
10684         * printcmd.c: Fix includes.
10685         * or1k-tdep.c: Fix includes.
10686         * mi/mi-main.c: Fix includes.
10687         * m32r-tdep.c: Fix includes.
10688         * csky-tdep.c: Fix includes.
10689         * compile/compile-cplus-types.c: Fix includes.
10690         * cli/cli-interp.c: Fix includes.
10691
10692 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10693
10694         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10695         for padding.
10696
10697 2019-01-16  Tom Tromey  <tom@tromey.com>
10698
10699         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10700         earlier.
10701         (struct objfile) <msymbols_range>: Move from top level.
10702         <msymbols>: New method.
10703         (class objfile_msymbols): Remove.
10704         * symtab.c (default_collect_symbol_completion_matches_break_on):
10705         Update.
10706         * symmisc.c (dump_msymbols): Update.
10707         * stabsread.c (scan_file_globals): Update.
10708         * objc-lang.c (info_selectors_command, info_classes_command)
10709         (find_methods): Update.
10710         * minsyms.c (find_solib_trampoline_target): Update.
10711         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10712         * coffread.c (coff_symfile_read): Update.
10713         * ada-lang.c (ada_lookup_simple_minsym)
10714         (ada_collect_symbol_completion_matches): Update.
10715
10716 2019-01-16  Tom Tromey  <tom@tromey.com>
10717
10718         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10719         type.  Remove no-argument constructor.
10720         <iterator::operator++>: Simplify.
10721         <begin>: Update.
10722         <end>: Use minimal_symbol_count.
10723
10724 2019-01-16  Tom Tromey  <tom@tromey.com>
10725
10726         * objfiles.h (struct objfile) <psymtabs>: New method.
10727         (class objfile_psymtabs): Remove.
10728         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10729         typedef.
10730         <range>: New method.
10731         (require_partial_symbols): Change return type.
10732         * psymtab.c (require_partial_symbols)
10733         (psym_expand_symtabs_matching): Update.
10734         * mdebugread.c (parse_partial_symbols): Update.
10735         * dbxread.c (dbx_end_psymtab): Update.
10736
10737 2019-01-15  Tom Tromey  <tom@tromey.com>
10738
10739         * symtab.c (lookup_objfile_from_block)
10740         (lookup_symbol_in_objfile_symtabs)
10741         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10742         (find_line_symtab, info_sources_command)
10743         (default_collect_symbol_completion_matches_break_on)
10744         (make_source_files_completion_list): Update.
10745         * symmisc.c (print_objfile_statistics, dump_objfile)
10746         (maintenance_print_symbols, maintenance_info_symtabs)
10747         (maintenance_check_symtabs, maintenance_info_line_tables):
10748         Update.
10749         * source.c (select_source_symtab)
10750         (forget_cached_source_info_for_objfile): Update.
10751         * objfiles.h (class objfile_compunits): Remove.
10752         (struct objfile) <compunits_range>: New typedef.
10753         (compunits): New method.
10754         * objfiles.c (objfile_relocate1): Update.
10755         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10756         * maint.c (count_symtabs_and_blocks): Update.
10757         * linespec.c (iterate_over_all_matching_symtabs): Update.
10758         * cp-support.c (add_symbol_overload_list_qualified): Update.
10759         * coffread.c (coff_symtab_read): Update.
10760         * ada-lang.c (add_nonlocal_symbols)
10761         (ada_collect_symbol_completion_matches)
10762         (ada_add_global_exceptions): Update.
10763
10764 2019-01-15  Tom Tromey  <tom@tromey.com>
10765
10766         * progspace.h (program_space) <objfiles_safe_range>: New
10767         typedef.
10768         <objfiles_safe>: New method.
10769         * objfiles.h (class all_objfiles_safe): Remove.
10770         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10771         * jit.c (jit_inferior_exit_hook): Update.
10772
10773 2019-01-17  Tom Tromey  <tom@tromey.com>
10774
10775         * progspace.h (program_space) <objfiles_range>: New typedef.
10776         <objfiles>: New method.
10777         <objfiles_head>: Rename from objfiles.
10778         (object_files): Update.
10779         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10780         * guile/scm-pretty-print.c
10781         (ppscm_find_pretty_printer_from_objfiles): Update.
10782         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10783         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10784         Update.
10785         * python/py-progspace.c (pspy_get_objfiles): Update.
10786         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10787         Update.
10788         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10789         (objfpy_lookup_objfile_by_build_id): Update.
10790         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10791         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10792         Update.
10793         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10794         (expand_symtab_containing_pc, lookup_objfile_from_block)
10795         (lookup_static_symbol, basic_lookup_transparent_type)
10796         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10797         (find_line_symtab, info_sources_command)
10798         (default_collect_symbol_completion_matches_break_on)
10799         (make_source_files_completion_list, find_main_name): Update.
10800         * symmisc.c (print_symbol_bcache_statistics)
10801         (print_objfile_statistics, maintenance_print_symbols)
10802         (maintenance_print_msymbols, maintenance_print_objfiles)
10803         (maintenance_info_symtabs, maintenance_check_symtabs)
10804         (maintenance_expand_symtabs, maintenance_info_line_tables):
10805         Update.
10806         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10807         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10808         (map_overlay_command, unmap_overlay_command)
10809         (simple_overlay_update, expand_symtabs_matching)
10810         (map_symbol_filenames): Update.
10811         * symfile-debug.c (set_debug_symfile): Update.
10812         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10813         Update.
10814         * source.c (select_source_symtab, forget_cached_source_info):
10815         Update.
10816         * solib.c (solib_read_symbols): Update.
10817         * solib-spu.c (append_ocl_sos): Update.
10818         * psymtab.c (maintenance_print_psymbols)
10819         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10820         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10821         * printcmd.c (info_symbol_command): Update.
10822         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10823         Update.
10824         * objfiles.h (class all_objfiles): Remove.
10825         * objfiles.c (have_partial_symbols, have_full_symbols)
10826         (have_minimal_symbols, qsort_cmp, update_section_map)
10827         (shared_objfile_contains_address_p)
10828         (default_iterate_over_objfiles_in_search_order): Update.
10829         * objc-lang.c (info_selectors_command, info_classes_command)
10830         (find_methods): Update.
10831         * minsyms.c (find_solib_trampoline_target): Update.
10832         * maint.c (maintenance_info_sections)
10833         (maintenance_translate_address, count_symtabs_and_blocks):
10834         Update.
10835         * main.c (captured_main_1): Update.
10836         * linux-thread-db.c (try_thread_db_load_from_pdir)
10837         (has_libpthread): Update.
10838         * linespec.c (iterate_over_all_matching_symtabs)
10839         (search_minsyms_for_name): Update.
10840         * jit.c (jit_find_objf_with_entry_addr): Update.
10841         * hppa-tdep.c (find_unwind_entry)
10842         (hppa_lookup_stub_minimal_symbol): Update.
10843         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10844         Update.
10845         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10846         (elf_gnu_ifunc_resolve_by_got): Update.
10847         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10848         * dwarf-index-write.c (save_gdb_index_command): Update.
10849         * cp-support.c (add_symbol_overload_list_qualified): Update.
10850         * breakpoint.c (create_overlay_event_breakpoint)
10851         (create_longjmp_master_breakpoint)
10852         (create_std_terminate_master_breakpoint)
10853         (create_exception_master_breakpoint): Update.
10854         * blockframe.c (find_pc_partial_function): Update.
10855         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10856         (ada_collect_symbol_completion_matches)
10857         (ada_add_global_exceptions): Update.
10858
10859 2019-01-17  Tom Tromey  <tom@tromey.com>
10860
10861         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10862         declare VEC.
10863         (solib_target_parse_libraries): Change return type.
10864         (library_list_start_segment, library_list_start_section)
10865         (library_list_end_library, library_list_start_library); Update.
10866         (solib_target_free_library_list): Remove.
10867         (solib_target_parse_libraries): Remove cleanup.  Change return
10868         type.
10869         (solib_target_current_sos): Update.
10870
10871 2019-01-17  Tom Tromey  <tromey@bapiya>
10872
10873         * valprint.c: Replace "the the" with "the".
10874         * symtab.c: Replace "the the" with "the".
10875         * solib.c: Replace "the the" with "the".
10876         * solib-dsbt.c: Replace "the the" with "the".
10877         * linespec.c: Replace "the the" with "the".
10878         * dwarf2loc.h: Replace "the the" with "the".
10879         * amd64-windows-tdep.c: Replace "the the" with "the".
10880         * aarch64-tdep.c: Replace "the the" with "the".
10881
10882 2019-01-16  Keith Seitz  <keiths@redhat.com>
10883
10884         PR gdb/23773
10885         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10886         <builder>: Rename to ..
10887         <m_builder>: ... this and make private.
10888         (dwarf2_cu::get_builder): New method.  Change all users of
10889         `builder' to use this method.
10890         (dwarf2_start_symtab): Move to ...
10891         (dwarf2_cu::start_symtab): ... here.  Update all callers
10892         (setup_type_unit_groups): Move to ...
10893         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10894         callers.
10895         (dwarf2_cu::reset_builder): New method.
10896         (process_full_compunit, process_full_type_unit): Use
10897         dwarf2_cu::reset_builder.
10898         (follow_die_offset): Record the ancestor CU if it is different
10899         from the followed DIE's CU.
10900         (follow_die_sig_1): Likewise.
10901
10902 2019-01-15  Tom Tromey  <tom@tromey.com>
10903
10904         * remote.c (class remote_state) <buf>: Now a char_vector.
10905         <buf_size>: Remove.
10906         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10907         parameter.
10908         (remote_target::getpkt_or_notif_sane_1)
10909         (remote_target::getpkt_sane)
10910         (remote_target::getpkt_or_notif_sane): Likewise.
10911         (class remote_target) <putpkt>: New overload.
10912         (remote_target::read_frame): Change type of "buf_p".  Remove
10913         sizeof_p parameter.
10914         (packet_ok): New overload.
10915         (packet_check_result): New overload.
10916         Update all uses.
10917
10918 2019-01-14  Tom Tromey  <tom@tromey.com>
10919
10920         * remote-notif.c (handle_notification, remote_notif_ack)
10921         (remote_notif_parse): Make "buf" const.
10922         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10923         const.
10924         (remote_notif_parse, remote_notif_ack, handle_notification):
10925         Likewise.
10926         * remote.c (remote_notif_stop_parse): Make "buf" const.
10927         (remote_target::remote_parse_stop_reply): Make "buf" const.
10928         (remote_notif_stop_ack): Make "buf" const.
10929
10930 2019-01-14  Tom Tromey  <tom@tromey.com>
10931
10932         * remote.c (remote_console_output): Make parameter const.
10933
10934 2019-01-14  Tom Tromey  <tom@tromey.com>
10935
10936         * target-debug.h (target_debug_print_signals): Constify.
10937         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10938         * procfs.c (procfs_target::pass_signals): Update.
10939         * linux-nat.c (linux_nat_target::pass_signals): Update.
10940         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10941         * target-delegates.c: Rebuild.
10942         * remote.c (remote_target::program_signals): Update.
10943         (remote_target::pass_signals): Update.
10944         * target.c (target_pass_signals): Constify argument.
10945         (target_program_signals): Likewise.
10946         * target.h (struct target_ops) <pass_signals, program_signals>:
10947         Constify argument.
10948         (target_pass_signals, target_program_signals): Constify argument.
10949
10950 2019-01-14  Tom Tromey  <tom@tromey.com>
10951
10952         PR tui/28819:
10953         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10954
10955 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10956
10957         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10958         field.
10959         * rs6000-tdep.c: Include reggroups.h.
10960         (IS_V_ALIAS_PSEUDOREG): Define.
10961         (rs6000_register_name): Return names for the "vX" aliases.
10962         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10963         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10964         aliases.  Call default_register_reggroup_p for all other
10965         pseudo-registers.
10966         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10967         New functions.
10968         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10969         Handle "vX" aliases.
10970         (v_alias_pseudo_register_collect): New function.
10971         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10972         (rs6000_gdbarch_init): Initialize "vX" aliases as
10973         pseudo-registers.  Restore registration of
10974         rs6000_pseudo_register_reggroup_p with
10975         set_tdesc_pseudo_register_reggroup_p.
10976
10977 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10978
10979         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10980         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10981         set_gdbarch_num_pseudo_regs.
10982
10983 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10984
10985         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10986         Remove arg prefixname, add do_set and do_show.
10987         Add member functions set_list and show_list.
10988         * cli/cli-style.c (class cli_style_option): Update accordingly.
10989         (style_set_list): Move to file scope.
10990         (style_show_list): Likewise.
10991         (set_style): Call help_list.
10992         (show_style): Call cmd_show_list.
10993         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10994         Update to use the new macro.
10995
10996 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10997
10998         * ada-lang.c (_initialize_ada_language): Expand the help text
10999         for the "catch exception" command.
11000
11001 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11002
11003         * symtab.c (matching_obj_sections): Initialize obj,
11004         declare it closer to its usage.
11005
11006 2019-01-10  Tom Tromey  <tom@tromey.com>
11007
11008         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11009         (basic_inf_threads_range): Remove.
11010         (inf_threads_range, inf_non_exited_threads_range)
11011         (safe_inf_threads_range): Use next_adapter.
11012
11013 2019-01-10  Keith Seitz  <keiths@redhat.com>
11014
11015         PR gdb/23712
11016         PR symtab/23010
11017         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11018         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11019
11020 2019-01-10  Keith Seitz  <keiths@redhat.com>
11021
11022         PR gdb/23712
11023         PR symtab/23010
11024         * dictionary.c (pending_to_vector): Remove.
11025         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11026         Remove _1 suffix, replacing functions of the same name.  Update
11027         all callers.
11028         (dict_create_hashed, dict_create_hashed_expandable)
11029         (dict_create_linear, dict_create_linear_expandable, dict_free)
11030         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11031         Make functions static.
11032
11033 2019-01-10  Keith Seitz  <keiths@redhat.com>
11034
11035         PR gdb/23712
11036         PR symtab/23010
11037         * dictionary.h (struct dictionary): Replace declaration with
11038         multidictionary.
11039         (dict_create_hashed, dict_create_hashed_expandable)
11040         (dict_create_linear, dict_create_linear_expandable)
11041         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11042         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11043         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11044         taking multidictionary argument.
11045         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11046         * block.h (struct block) <dict>: Change to multidictionary
11047         and rename `multidict'.
11048         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11049         symmisc.c: Update all dictionary references to multidictionary.
11050
11051 2019-01-10  Keith Seitz  <keiths@redhat.com>
11052
11053         PR gdb/23712
11054         PR symtab/23010
11055         * dictionary.c: Include unordered_map.
11056         (pending_to_vector): New function.
11057         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11058         Rewrite the non-"_1" functions to take vector instead
11059         of linked list.
11060         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11061         "new" _1 versions of the same name.
11062         (multidictionary): Define.
11063         (std::hash<enum language): New definition.
11064         (collate_pending_symbols_by_language, mdict_create_hashed)
11065         (mdict_create_hashed_expandable, mdict_create_linear)
11066         (mdict_create_linear_expandable, mdict_free)
11067         (find_language_dictionary, create_new_language_dictionary)
11068         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11069         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11070         (mdict_size, mdict_empty): New functions.
11071         * dictionary.h (mdict_iterator): Define.
11072
11073 2019-01-10  Pedro Alves  <palves@redhat.com>
11074
11075         * breakpoint.c (read_uploaded_action)
11076         (create_tracepoint_from_upload): Adjust to use
11077         gdb::unique_xmalloc_ptr.
11078         * ctf.c (ctf_write_uploaded_tp):
11079         (SET_ARRAY_FIELD): Use emplace_back.
11080         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11081         * tracefile-tfile.c (tfile_write_uploaded_tp):
11082         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11083         gdb::unique_xmalloc_ptr.
11084         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11085         at_string, cond_string, cmd_strings>: Replace char pointers
11086         with gdb::unique_xmalloc_ptr.
11087
11088 2019-01-10  Pedro Alves  <palves@redhat.com>
11089
11090         * solib-target.c (library_list_start_library): Don't xstrdup name.
11091
11092 2019-01-10  Pedro Alves  <palves@redhat.com>
11093
11094         * mdebugread.c (parse_partial_symbols): Use
11095         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11096
11097 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11098
11099         * linux-fork.c (scoped_switch_fork_info)
11100         <~scoped_switch_fork_info>: Fix incorrect variable name.
11101
11102 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11103
11104         * linux-fork.c (scoped_switch_fork_info)
11105         <scoped_switch_fork_info>: Make explicit.
11106         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11107
11108 2019-01-10  Tom Tromey  <tom@tromey.com>
11109
11110         * objfiles.h (objfile::reset_psymtabs): Update.
11111         * objfiles.c (objfile::objfile): Update.
11112         * psymtab.h (psymtab_storage::obstack): Update.
11113         (psymtab_storage::m_obstack): Use gdb::optional.
11114         (class psymtab_storage): Update comment.  Remove objfile
11115         parameter.
11116         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11117
11118 2019-01-10  Tom Tromey  <tom@tromey.com>
11119
11120         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11121         <free_psymtabs>: Now private.
11122         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11123         (allocate_psymtab): Use new method.
11124
11125 2019-01-10  Tom Tromey  <tom@tromey.com>
11126
11127         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11128         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11129         * mdebugread.c (parse_partial_symbols): Use
11130         allocate_dependencies.
11131         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11132         allocate_dependencies.
11133         (process_psymtab_comp_unit_reader)
11134         (build_type_psymtab_dependencies): Likewise.
11135         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11136
11137 2019-01-10  Tom Tromey  <tom@tromey.com>
11138
11139         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11140         PSYMBOL_SET_LANGUAGE.
11141         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11142
11143 2019-01-10  Tom Tromey  <tom@tromey.com>
11144
11145         * psymtab.h (psymtab_storage::obstack): New method.
11146         <m_obstack>: Rename from obstack; now private.
11147         * psymtab.c (psymtab_storage): Update.
11148         * dwarf2read.c (create_addrmap_from_index)
11149         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11150         Update.
11151
11152 2019-01-10  Tom Tromey  <tom@tromey.com>
11153
11154         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11155         * objfiles.h (objfile::reset_psymtabs): New method.
11156
11157 2019-01-10  Tom Tromey  <tom@tromey.com>
11158
11159         * symmisc.c (print_symbol_bcache_statistics): Update.
11160         (print_objfile_statistics): Update.
11161         * symfile.c (reread_symbols): Update.
11162         * psymtab.h (class psymtab_storage): New.
11163         * psymtab.c (psymtab_storage): New constructor.
11164         (~psymtab_storage): New destructor.
11165         (require_partial_symbols): Update.
11166         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11167         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11168         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11169         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11170         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11171         (start_psymtab_common, end_psymtab_common)
11172         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11173         (allocate_psymtab): Update.
11174         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11175         Update.
11176         (dump_psymtab_addrmap, maintenance_print_psymbols)
11177         (maintenance_check_psymtabs): Update.
11178         (class objfile_psymtabs): Move to objfiles.h.
11179         * psympriv.h (discard_psymtab): Now inline.
11180         (psymtab_discarder::psymtab_discarder): Update.
11181         (psymtab_discarder::~psymtab_discarder): Update.
11182         (ALL_OBJFILE_PSYMTABS): Rewrite.
11183         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11184         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11185         Remove fields.
11186         <partial_symtabs>: New field.
11187         (class objfile_psymtabs): Move from psymtab.h.  Update.
11188         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11189         psymbol_cache.
11190         (objfile::~objfile): Don't destroy psymbol_cache.
11191         * mdebugread.c (parse_partial_symbols): Update.
11192         * dwarf2read.c (create_addrmap_from_index)
11193         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11194         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11195         (add_partial_subprogram, dwarf2_ranges_read): Update.
11196         * dwarf-index-write.c (write_address_map)
11197         (write_one_signatured_type, recursively_write_psymbols)
11198         (class debug_names, class debug_names, write_psymtabs_to_index):
11199         Update.
11200
11201 2019-01-10  Tom Tromey  <tom@tromey.com>
11202
11203         * symtab.h (SYMBOL_SET_NAMES): Update.
11204         (symbol_set_names): Update.
11205         (MSYMBOL_SET_NAMES): Update.
11206         * symtab.c (symbol_set_names): Change argument to be an
11207         objfile_per_bfd_storage.
11208         * psymtab.c (add_psymbol_to_bcache): Update.
11209         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11210
11211 2019-01-10  Tom Tromey  <tom@tromey.com>
11212
11213         * symtab.c (create_demangled_names_hash): Change argument to be an
11214         objfile_per_bfd_storage.
11215         (symbol_set_names): Update.
11216
11217 2019-01-10  Tom Tromey  <tom@tromey.com>
11218
11219         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11220         init_psymbol_list.
11221         * psymtab.c (init_psymbol_list): Do nothing if already called.
11222         * psympriv.h (init_psymbol_list): Add comment.
11223         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11224         init_psymbol_list.
11225         * dbxread.c (dbx_symfile_read): Unconditionally call
11226         init_psymbol_list.
11227
11228 2019-01-10  Tom Tromey  <tom@tromey.com>
11229
11230         * xcoffread.c (scan_xcoff_symtab): Update.
11231         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11232         "where".
11233         * mdebugread.c (parse_partial_symbols)
11234         (handle_psymbol_enumerators): Update.
11235         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11236         * dbxread.c (read_dbx_symtab): Update.
11237         * psympriv.h (psymbol_placement): New enum.
11238         (add_psymbol_to_list): Update.
11239
11240 2019-01-10  Tom Tromey  <tom@tromey.com>
11241
11242         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11243         static_psymbols parameters.
11244         (scan_xcoff_symtab): Update.
11245         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11246         static_psymbols parameters.
11247         * psympriv.h (start_psymtab_common): Update.
11248         * mdebugread.c (parse_partial_symbols): Update.
11249         * dwarf2read.c (create_partial_symtab): Update.
11250         * dbxread.c (read_dbx_symtab): Update.
11251         (start_psymtab): Remove global_psymbols and static_psymbols
11252         parameters.
11253
11254 2019-01-10  Tom Tromey  <tom@tromey.com>
11255
11256         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11257         * psymtab.c (allocate_psymtab): Add comment.
11258         * psympriv.h (allocate_psymtab): Add comment.
11259         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11260         initializations.
11261         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11262
11263 2019-01-10  Tom Tromey  <tom@tromey.com>
11264
11265         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11266         Don't declare.
11267         * mipsread.c: Include mdebugread.h.
11268         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11269         Declare.
11270         * elfread.c: Include mdebugread.h.
11271
11272 2019-01-09  Tom Tromey  <tom@tromey.com>
11273
11274         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11275         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11276         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11277         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11278         (psym_lookup_symbol, psym_find_last_source_symtab)
11279         (psym_forget_cached_source_info, psym_print_stats)
11280         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11281         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11282         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11283         (psym_find_compunit_symtab_by_address)
11284         (maintenance_print_psymbols, maintenance_info_psymtabs)
11285         (maintenance_check_psymtabs): Use ranged for.
11286         * psymtab.h (class objfile_psymtabs): New.
11287         (require_partial_symbols): Return objfile_psymtabs.
11288         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11289
11290 2019-01-09  Tom Tromey  <tom@tromey.com>
11291
11292         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11293         (find_pc_mapped_section, list_overlays_command)
11294         (map_overlay_command, unmap_overlay_command)
11295         (simple_overlay_update): Use all_objfiles.
11296         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11297         * printcmd.c (info_symbol_command): Use all_objfiles.
11298         * objfiles.h (ALL_OBJSECTIONS): Remove.
11299         * maint.c (maintenance_translate_address): Use all_objfiles.
11300         * gcore.c (gcore_create_callback): Use all_objfiles.
11301         (objfile_find_memory_regions): Likewise.
11302
11303 2019-01-09  Tom Tromey  <tom@tromey.com>
11304
11305         * symtab.c (find_line_symtab, info_sources_command)
11306         (make_source_files_completion_list): Use objfile_compunits.
11307         * source.c (select_source_symtab): Use objfile_compunits.
11308         * objfiles.h (struct objfile): Update comment.
11309         (ALL_OBJFILES): Remove.
11310         (ALL_FILETABS): Remove.
11311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11312         objfile_compunits.
11313
11314 2019-01-09  Tom Tromey  <tom@tromey.com>
11315
11316         * symmisc.c (print_objfile_statistics, dump_objfile)
11317         (maintenance_print_symbols): Use compunit_filetabs.
11318         * source.c (forget_cached_source_info_for_objfile): Use
11319         compunit_filetabs.
11320         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11321         (ALL_FILETABS): Use compunit_filetabs.
11322         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11323         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11324
11325 2019-01-09  Tom Tromey  <tom@tromey.com>
11326
11327         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11328         (compunit_filetabs): New.
11329         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11330         compunit_filetabs.
11331         (info_sources_command, make_source_files_completion_list): Remove
11332         declaration.
11333         * symmisc.c (print_objfile_statistics, dump_objfile)
11334         (maintenance_print_symbols): Remove declaration.
11335         (maintenance_info_symtabs): Use compunit_filetabs.
11336         (maintenance_info_line_tables): Likewise.
11337         * source.c (select_source_symtab): Change local variable name.
11338         (forget_cached_source_info_for_objfile): Remove declaration.
11339         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11340         * objfiles.c (objfile_relocate1): Remove declaration.
11341         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11342         declaration.
11343         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11344         * coffread.c (coff_symtab_read): Remove declaration.
11345         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11346         compunit_filetabs.
11347
11348 2019-01-09  Tom Tromey  <tom@tromey.com>
11349
11350         * symtab.c (lookup_objfile_from_block)
11351         (find_pc_sect_compunit_symtab, search_symbols)
11352         (default_collect_symbol_completion_matches_break_on): Use
11353         objfile_compunits.
11354         * objfiles.h (ALL_COMPUNITS): Remove.
11355         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11356         * cp-support.c (add_symbol_overload_list_qualified): Use
11357         objfile_compunits.
11358         * ada-lang.c (ada_collect_symbol_completion_matches)
11359         (ada_add_global_exceptions): Use objfile_compunits.
11360
11361 2019-01-09  Tom Tromey  <tom@tromey.com>
11362
11363         * source.c (select_source_symtab)
11364         (forget_cached_source_info_for_objfile): Remove declaration.
11365         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11366         declaration.
11367         * maint.c (count_symtabs_and_blocks): Remove declaration.
11368         * cp-support.c (add_symbol_overload_list_qualified): Remove
11369         declaration.
11370         * coffread.c (coff_symtab_read): Remove declaration.
11371         * symtab.c (lookup_symbol_in_objfile_symtabs)
11372         (basic_lookup_transparent_type_1): Use objfile_compunits.
11373         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11374         (info_sources_command, search_symbols)
11375         (default_collect_symbol_completion_matches_break_on)
11376         (make_source_files_completion_list): Remove declaration.
11377         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11378         (ada_collect_symbol_completion_matches)
11379         (ada_add_global_exceptions): Remove declaration.
11380         * linespec.c (iterate_over_all_matching_symtabs): Use
11381         objfile_compunits.
11382         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11383         (class objfile_compunits): New.
11384         (ALL_COMPUNITS): Use objfile_compunits.
11385         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11386         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11387         objfile_compunits.
11388         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11389
11390 2019-01-09  Tom Tromey  <tom@tromey.com>
11391
11392         * symtab.c (search_symbols)
11393         (default_collect_symbol_completion_matches_break_on): Use
11394         objfile_msymbols.
11395         * ada-lang.c (ada_lookup_simple_minsym)
11396         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11397         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11398         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11399         objfile_msymbols.
11400         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11401         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11402         * objc-lang.c (find_methods): Use objfile_msymbols.
11403         (info_selectors_command, info_classes_command): Likewise.
11404         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11405         * objfiles.h (class objfile_msymbols): New.
11406         (ALL_OBJFILE_MSYMBOLS): Remove.
11407         (ALL_MSYMBOLS): Remove.
11408
11409 2019-01-09  Tom Tromey  <tom@tromey.com>
11410
11411         * common/next-iterator.h (next_adapter): Add Iterator template
11412         parameter.
11413         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11414         (class all_objfiles_safe): New.
11415         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11416         * objfiles.c (put_objfile_before): Update comment.
11417         (add_separate_debug_objfile): Likewise.
11418         (free_all_objfiles): Use all_objfiles_safe.
11419         (objfile_purge_solibs): Likewise.
11420
11421 2019-01-09  Tom Tromey  <tom@tromey.com>
11422
11423         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11424         (expand_symtab_containing_pc, lookup_static_symbol)
11425         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11426         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11427         all_objfiles.
11428         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11429         * breakpoint.c (create_overlay_event_breakpoint)
11430         (create_longjmp_master_breakpoint)
11431         (create_std_terminate_master_breakpoint)
11432         (create_exception_master_breakpoint): Use all_objfiles.
11433         * linux-thread-db.c (try_thread_db_load_from_pdir)
11434         (has_libpthread): Use all_objfiles.
11435         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11436         * linespec.c (iterate_over_all_matching_symtabs)
11437         (search_minsyms_for_name): Use all_objfiles.
11438         * maint.c (maintenance_info_sections): Use all_objfiles.
11439         * main.c (captured_main_1): Use all_objfiles.
11440         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11441         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11442         * guile/scm-pretty-print.c
11443         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11444         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11445         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11446         (maintenance_print_msymbols): Use all_objfiles.
11447         * source.c (select_source_symtab): Use all_objfiles.
11448         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11449         * symfile.c (remove_symbol_file_command)
11450         (expand_symtabs_matching, map_symbol_filenames): Use
11451         all_objfiles.
11452         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11453         all_objfiles.
11454         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11455         * objc-lang.c (find_methods): Use all_objfiles.
11456         * objfiles.c (have_partial_symbols, have_full_symbols)
11457         (have_minimal_symbols, qsort_cmp)
11458         (default_iterate_over_objfiles_in_search_order): Use
11459         all_objfiles.
11460         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11461         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11462         (maintenance_check_psymtabs): Use all_objfiles.
11463         (ALL_PSYMTABS): Remove.
11464         * compile/compile-object-run.c (do_module_cleanup): Use
11465         all_objfiles.
11466         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11467         * cp-support.c (add_symbol_overload_list_qualified): Use
11468         all_objfiles.
11469         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11470         Use all_objfiles.
11471         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11472         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11473         all_objfiles.
11474         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11475         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11476         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11477         Uses all_objfiles.
11478         * solib.c (solib_read_symbols): Use all_objfiles
11479
11480 2019-01-09  Tom Tromey  <tom@tromey.com>
11481
11482         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11483         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11484         all_objfiles.
11485         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11486         * symmisc.c (print_symbol_bcache_statistics)
11487         (print_objfile_statistics, maintenance_print_objfiles)
11488         (maintenance_info_symtabs, maintenance_check_symtabs)
11489         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11490         all_objfiles.
11491         * source.c (forget_cached_source_info): Use all_objfiles.
11492         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11493         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11494         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11495         * objfiles.c (update_section_map): Use all_objfiles.
11496         (shared_objfile_contains_address_p): Likewise.
11497         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11498         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11499
11500 2019-01-09  Tom Tromey  <tom@tromey.com>
11501
11502         * common/next-iterator.h: New file.
11503         * objfiles.h (class all_objfiles): New.
11504         (struct objfile_iterator): New.
11505
11506 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11507
11508         * NEWS: Move the description of the changed "frame", "select-frame",
11509          and "info frame" commands to the Changed commands section.
11510
11511 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11512
11513         * gdbtypes.c (check_stub_method_group): Remove handling of old
11514         mangling schemes.
11515         * linespec.c (find_methods): Likewise.
11516         * stabsread.c (read_member_functions): Likewise.
11517         * valops.c (search_struct_method): Likewise.
11518         (value_struct_elt_for_reference): Likewise.
11519         * NEWS: Mention this change.
11520
11521 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11522
11523         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11524         print_source_lines.
11525         * source.c (print_source_lines_base): Update line number check.
11526         (print_source_lines): New function.
11527         (source_lines_range::source_lines_range): New function.
11528         * source.h (class source_lines_range): New class.
11529         (print_source_lines): New declaration.
11530
11531 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11532
11533         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11534
11535 2019-01-08  Tom Tromey  <tom@tromey.com>
11536             Simon Marchi  <simon.marchi@ericsson.com>
11537
11538         PR gdb/24060
11539         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11540         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11541         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11542         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11543         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11544         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11545
11546 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11547
11548         * source.c (select_source_symtab): Move header comment to
11549         declaration in source.h.
11550         (forget_cached_source_info_for_objfile): Likewise.
11551         (forget_cached_source_info): Likewise.
11552         (identify_source_line): Likewise.
11553         * source.h (identify_source_line): Move declaration from symtab.h
11554         and add comment from source.c
11555         (print_source_lines): Likewise.
11556         (forget_cached_source_info_for_objfile): Likewise.
11557         (forget_cached_source_info): Likewise.
11558         (select_source_symtab): Likewise.
11559         (enum print_source_lines_flag): Move definition from symtab.h.
11560         * symtab.h (identify_source_line): Move declaration to source.h.
11561         (print_source_lines): Likewise.
11562         (forget_cached_source_info_for_objfile): Likewise.
11563         (forget_cached_source_info): Likewise.
11564         (select_source_symtab): Likewise.
11565         (enum print_source_lines_flag): Move definition to source.h.
11566         * tui/tui-hooks.c: Add 'source.h' include.
11567
11568 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11569
11570         * source.c (print_source_lines_base): Handle requests to print
11571         reverse line number sequences, and guard against empty lines
11572         string.
11573
11574 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11575
11576         * source.c (print_source_lines_base): Fix skip of '\r' if next
11577         character is '\n'.
11578
11579 2019-01-06  Tom Tromey  <tom@tromey.com>
11580
11581         * c-exp.y (struct c_parse_state) <macro_original_text,
11582         expansion_obstack>: New member.
11583         (macro_original_text, expansion_obstack): Remove globals.
11584         (scan_macro_expansion, scanning_macro_expansion)
11585         (finished_macro_expansion): Update.
11586         (scan_macro_cleanup): Remove.
11587         (yylex, c_parse): Update.
11588
11589 2019-01-06  Tom Tromey  <tom@tromey.com>
11590
11591         * c-exp.y (struct c_parse_state) <strings>: New member.
11592         (operator_stoken): Update.
11593
11594 2019-01-06  Tom Tromey  <tom@tromey.com>
11595
11596         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11597         (union type_stack_elt) <typelist_val>: Now a pointer to
11598         std::vector.
11599         (type_stack_cleanup): Don't declare.
11600         (push_typelist): Update.
11601         * parse.c (pop_typelist): Return a std::vector.
11602         (push_typelist): Take a std::vector.
11603         (follow_types): Update.  Do not free args.
11604         (type_stack_cleanup): Remove.
11605         * c-exp.y (struct c_parse_state): New.
11606         (cpstate): New global.
11607         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11608         (nonempty_typelist): Update.
11609         (func_mod): Create a new vector.
11610         (c_parse): Create a c_parse_state.
11611         (check_parameter_typelist): Do not delete params.
11612         (function_method): Update.  Do not delete type_list.
11613
11614 2019-01-06  Tom Tromey  <tom@tromey.com>
11615
11616         PR gdb/28155:
11617         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11618         check_typedef.
11619         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11620         (print_return_value): Likewise.
11621
11622 2019-01-05  Tom Tromey  <tom@tromey.com>
11623
11624         * contrib/cleanup_check.py: Remove.
11625         * contrib/gcc-with-excheck: Remove.
11626         * contrib/exsummary.py: Remove.
11627         * contrib/excheck.py: Remove.
11628
11629 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11630
11631         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11632         NULL. Initialize tpprev to NULL instead of assigning it
11633         to NULL on the next statement.
11634         * windows-nat.c (windows_delete_thread): Remove check for
11635         main_thread_id before printing thread exit notifications.
11636         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11637         Remove thread ID check against main_thread_id.
11638         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11639         windows_delete_thread.
11640         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11641
11642 2019-01-04  Tom Tromey  <tom@tromey.com>
11643
11644         * compile/compile.c (_initialize_compile): Use upper case for
11645         metasyntactic variables.
11646         * symmisc.c (_initialize_symmisc): Use upper case for
11647         metasyntactic variables.
11648         * psymtab.c (_initialize_psymtab): Use upper case for
11649         metasyntactic variables.
11650         * demangle.c (demangle_command): Use upper case for metasyntactic
11651         variables.
11652         (_initialize_demangler): Likewise.
11653         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11654         variables.
11655
11656 2019-01-03  Tom Tromey  <tom@tromey.com>
11657
11658         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11659
11660 2019-01-03  Tom Tromey  <tom@tromey.com>
11661
11662         * python/py-symtab.c (salpy_str): Update.
11663         (struct salpy_sal_object) <symtab>: Now a PyObject.
11664         (salpy_dealloc): Update.
11665         (del_objfile_sal): Use gdbpy_ref.
11666
11667 2019-01-03  Tom Tromey  <tom@tromey.com>
11668
11669         * python/py-type.c (convert_field): Use new_reference.  Return
11670         gdbpy_ref.
11671         (make_fielditem): Return gdbpy_ref.
11672         (typy_fields): Update.
11673         (typy_getitem): Update.
11674         (field_name): Return gdbpy_ref.  Use new_reference.
11675         (typy_iterator_iternext): Update.
11676
11677 2019-01-03  Tom Tromey  <tom@tromey.com>
11678
11679         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11680
11681 2019-01-03  Tom Tromey  <tom@tromey.com>
11682
11683         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11684         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11685         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11686         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11687         (pspy_set_type_printers): Likewise.
11688         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11689         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11690         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11691         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11692         (objfpy_set_type_printers): Likewise.
11693
11694 2019-01-03  Tom Tromey  <tom@tromey.com>
11695
11696         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11697         (gdbpy_print_stack): Use gdbpy_err_fetch.
11698         * python/python-internal.h (class gdbpy_err_fetch): New class.
11699         (class gdbpy_enter) <m_error_type, m_error_value,
11700         m_error_traceback>: Remove.
11701         <m_error>: New member.
11702         (gdbpy_exception_to_string): Don't declare.
11703         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11704         * python/py-value.c (convert_value_from_python): Use
11705         gdbpy_err_fetch.
11706         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11707         gdbpy_exception_to_string.
11708         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11709         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11710         gdbpy_err_fetch.
11711
11712 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11713
11714         * linux-nat.c (delete_lwp_cleanup): Delete.
11715         (struct lwp_deleter): New struct.
11716         (lwp_info_up): New typedef.
11717         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11718         lwp_info_up.
11719
11720 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11721
11722         * linux-fork.c (class scoped_switch_fork_info): New class.
11723         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11724
11725 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11726
11727         * valops.c (find_overload_match): Remove use of null_cleanup, and
11728         calls to do_cleanups.
11729
11730 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11731
11732         * compile/compile-cplus-types.c
11733         (compile_cplus_instance::decl_name): Handle changes to
11734         cp_func_name.
11735         * cp-support.c (cp_func_name): Update header comment, update
11736         return type.
11737         * cp-support.h (cp_func_name): Update return type in declaration.
11738         * valops.c (find_overload_match): Move temp_func local to top
11739         level of function and change its type.  Use temp_func to hold and
11740         delete temporary string obtained from cp_func_name.
11741
11742 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11743
11744         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11745         gdb::char_vector, remove cleanup, and update uses of `msg`.
11746
11747 2019-01-03  Jim Wilson  <jimw@sifive.com>
11748
11749         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11750
11751 2019-01-02  Tom Tromey  <tom@tromey.com>
11752
11753         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11754         (tdesc_parse_xml): Remove cleanups.
11755         * target-descriptions.h (make_cleanup_free_target_description):
11756         Don't declare.
11757         (target_desc_deleter): New struct.
11758         (target_desc_up): New typedef.
11759         * target-descriptions.c (target_desc_deleter::operator()): Rename
11760         from free_target_description.
11761         (make_cleanup_free_target_description): Remove.
11762
11763 2019-01-02  Tom Tromey  <tom@tromey.com>
11764
11765         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11766         constructor, destructor.
11767         (linespec_parser): Remove typedef.
11768         (~linespec_parser): Rename from linespec_parser_delete.
11769         (linespec_lex_to_end, linespec_complete_label)
11770         (linespec_complete): Update.
11771         (decode_line_full): Remove cleanups.
11772         (decode_line_1): Update.
11773
11774 2019-01-02  Tom Tromey  <tom@tromey.com>
11775
11776         * python/python-internal.h (inferior_to_inferior_object): Change
11777         return type.
11778         * python/py-exitedevent.c (create_exited_event_object): Update.
11779         * python/py-inferior.c (inferior_to_inferior_object): Return
11780         gdbpy_ref.
11781         (python_new_inferior, python_inferior_deleted)
11782         (thread_to_thread_object, delete_thread_object)
11783         (build_inferior_list, gdbpy_selected_inferior): Update.
11784         * python/py-infthread.c (create_thread_object): Update.  Also fail
11785         if inferior_to_inferior_object fails.
11786
11787 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11788
11789         * inferior.h (class inferior) <displaced_step_state>: New field.
11790         * infrun.h (struct displaced_step_state): Move here from
11791         infrun.c.  Initialize fields, add constructor.
11792         <inf>: Remove field.
11793         <reset>: New method.
11794         * infrun.c (struct displaced_step_inferior_state): Move to
11795         infrun.h.
11796         (displaced_step_inferior_states): Remove.
11797         (get_displaced_stepping_state): Adust.
11798         (displaced_step_in_progress_any_inferior): Adjust.
11799         (displaced_step_in_progress_thread): Adjust.
11800         (displaced_step_in_progress): Adjust.
11801         (add_displaced_stepping_state): Remove.
11802         (get_displaced_step_closure_by_addr): Adjust.
11803         (remove_displaced_stepping_state): Remove.
11804         (infrun_inferior_exit): Call displaced_step_state.reset.
11805         (use_displaced_stepping): Don't check for NULL.
11806         (displaced_step_prepare_throw): Call
11807         get_displaced_stepping_state.
11808         (displaced_step_fixup): Don't check for NULL.
11809         (prepare_for_detach): Don't check for NULL.
11810
11811 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11812
11813         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11814          in case of call that did not complete.
11815
11816 2019-01-02  Andrey Utkin  <autkin@undo.io>
11817
11818         * symfile.c (find_separate_debug_file): Fix search of debug files for
11819         remote debuggee.
11820
11821 2019-01-02  Tom Tromey  <tom@tromey.com>
11822
11823         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11824         indentation.
11825         * python/py-frame.c (frapy_older): Remove cast.
11826         (frapy_newer): Likewise.
11827         * python/py-breakpoint.c (local_setattro): Remove cast.
11828         * python/py-arch.c (archpy_name): Remove local variable.
11829         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11830
11831 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11832
11833         * unittests/basic_string_view/element_access/char/empty.cc:
11834         Fix year range in copyright header.
11835
11836 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11837
11838         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11839         Delete.
11840         <operator==>: Update with for removed field.
11841         <hash>: Likewise.
11842         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11843         <isa_features>: ...this.
11844         <abi_features>: New field.
11845         (riscv_isa_flen): Update comment.
11846         (riscv_abi_xlen): New declaration.
11847         (riscv_abi_flen): New declaration.
11848         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11849         isa_features.
11850         (riscv_abi_xlen): New function.
11851         (riscv_isa_flen): Update to get answer from isa_features.
11852         (riscv_abi_flen): New function.
11853         (riscv_has_fp_abi): Update to get answer from abi_features.
11854         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11855         xlen and flen.
11856         (riscv_call_info) <xlen, flen>: Update comment.
11857         (riscv_call_arg_struct): Remove invalid assertions
11858         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11859         is removed.
11860         (riscv_gdbarch_init): Gather isa features and abi features
11861         separately, ensure both match on the gdbarch when reusing an old
11862         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11863         a target with 64-bit float hardware.
11864
11865 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11866
11867         * source.c (search_command_helper): Stop reverse search
11868         when line 1 has been searched.
11869
11870 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11871
11872         * record-full.c (record_full_base_target::close): Rewrite
11873         record_full_core_buf_list free logic.
11874
11875 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11876
11877         * break-catch-syscall.c (print_one_catch_syscall): xfree
11878         the last text.
11879
11880 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11881
11882         * top.c (print_gdb_version): Update Copyright year in version
11883         message.
11884
11885 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11886
11887         Update copyright year range in all GDB files.
11888
11889 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11890
11891         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11892
11893 For older changes see ChangeLog-2018.
11894 \f
11895 Local Variables:
11896 mode: change-log
11897 left-margin: 8
11898 fill-column: 74
11899 version-control: never
11900 coding: utf-8
11901 End:
11902