gdb/ChangeLog

   1 2019-09-09  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
   4
   5 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   6
   7         * python/python.c (do_start_initialization): Make progname_copy static,
   8         to avoid a leak report.
   9
  10 2019-09-08  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
  13
  14 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
  15
  16         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
  17         Change type to gdb::optional<block_enum>.
  18         (dw2_symtab_iter_init): Change block_index parameter type
  19         to gdb::optional<block_enum>.
  20         (dw2_lookup_symbol): Change block_index parameter
  21         type to block_enum.c
  22         (dw2_debug_names_lookup_symbol): Likewise.
  23         * psymtab.c (psym_lookup_symbol): Likewise.
  24         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
  25         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
  26         Likewise.
  27
  28 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
  29
  30         * defs.h (relocate_gdb_directory): Change int to bool in
  31         signature and rename flag to relocatable.
  32         * main.c (relocate_path): Likewise.
  33         (relocate_gdb_directory): Likewise.
  34
  35 2019-09-06  Alan Modra  <amodra@gmail.com>
  36
  37         * coffread.c (coff_symfile_read): Constify filename variable.
  38         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
  39         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
  40         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
  41         * solib.c (reload_shared_libraries_1): Likewise.
  42         * symfile.c (reread_symbols): Likewise.
  43         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
  44         * solib-darwin.c (darwin_bfd_open): Likewise.
  45         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
  46
  47 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * psymtab.c (print_partial_symbols): Handle missing domain_enum
  50         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
  51
  52 2019-09-03  Tom Tromey  <tromey@adacore.com>
  53
  54         * ada-valprint.c (ada_val_print_num): Don't recurse for range
  55         types.
  56         (has_negatives): Unbias a range type bound.
  57         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
  58         * gdbtypes.c (operator==): Handle new field.
  59         (create_range_type): Add "bias" parameter.
  60         (create_static_range_type, resolve_dynamic_range): Update.
  61         * gdbtypes.h (struct range_bounds) <bias>: New member.
  62         (create_range_type): Add bias parameter.
  63         * printcmd.c (print_scalar_formatted): Unbias range types.
  64         * value.c (unpack_long): Unbias range types.
  65         (pack_long): Bias range types.
  66
  67 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  68
  69         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
  70         probe arguments.
  71
  72 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  73
  74         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
  75         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
  76         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
  77         (compile_probe_arg): Likewise.
  78         * probe.h (get_argument_count): Likewise.
  79         * solib-svr4.c (solib_event_probe_action): Likewise.
  80         * stap-probe.c (stap_probe::get_argument_count): Likewise.
  81
  82 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  83
  84         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
  85         code to here...
  86         (svr4_create_solib_event_breakpoints): ...from here.
  87
  88 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
  89
  90         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
  91         suffix from warning message.
  92
  93 2019-08-30  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-winsource.h (struct tui_source_window_base)
  96         <refresh_all>: Don't declare.
  97         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  98         Remove.
  99         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 100         tui_show_locator_content.
 101         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 102         declare.
 103         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 104         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 105         declare.
 106
 107 2019-08-30  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 110
 111 2019-08-30  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 114         Remove unnecessary forward declarations.
 115
 116 2019-08-30  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 119         rerender.
 120         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 121         tui_show_locator_content.
 122
 123 2019-08-30  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 126         (tui_locator_window::rerender): Rewrite using body of previous
 127         tui_show_locator_content.
 128
 129 2019-08-30  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 132         set_locator_fullname>: New methods.
 133         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 134         Rename from tui_set_locator_fullname.
 135         (tui_locator_window::set_locator_info): Rename from
 136         tui_set_locator_info.  Return bool.
 137         (tui_update_locator_fullname, tui_show_frame_info): Update.
 138
 139 2019-08-30  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 142
 143 2019-08-30  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 146         call touchwin.
 147
 148 2019-08-30  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-wingeneral.c (box_win): Assume win_info and
 151         win_info->handle cannot be NULL.
 152
 153 2019-08-30  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 156         refresh_window>: Declare.
 157         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 158         resize.
 159         (tui_data_item_window::rerender): Rename from
 160         tui_display_register.
 161         (tui_data_item_window::refresh_window): New method.
 162         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 163         no-op.
 164
 165 2019-08-30  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 168         regs_column_count, current_group>: Move later.  Now private.
 169         <get_current_group>: New method.
 170         * tui/tui-regs.c (tui_reg_command): Update.
 171         * tui/tui-layout.c (tui_set_layout): Update.
 172
 173 2019-08-30  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 176         (tui_data_window::rerender): Don't call
 177         check_and_display_highlight_if_needed.
 178         (tui_data_window::refresh_all): Remove call to
 179         erase_data_content.
 180
 181 2019-08-30  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 184         (tui_data_window::display_registers_from)
 185         (tui_data_window::display_reg_element_at_line)
 186         (tui_data_window::display_registers_from_line): Remove checks of
 187         "empty".
 188
 189 2019-08-30  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 192         Don't declare.
 193         * tui/tui-regs.c (tui_data_window::show_registers): Call
 194         rerender.
 195         (tui_data_window::rerender): Rename from display_all_data.
 196         (tui_data_window::rerender): Remove old implementation.
 197
 198 2019-08-30  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 201         text.
 202         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 203
 204 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 205             Sergio Durigan Junior  <sergiodj@redhat.com>
 206
 207         PR win32/24284
 208         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 209
 210 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 213         when searching for types.
 214
 215 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 216
 217         * f-lang.c (f_language_defn): Use f_print_typedef.
 218         * f-lang.h (f_print_typedef): Declare.
 219         * f-typeprint.c (f_print_typedef): Define.
 220
 221 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 222
 223         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 224
 225 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * cli/cli-utils.c (info_print_options_defs): Delete.
 228         (make_info_print_options_def_group): Delete.
 229         (extract_info_print_options): Delete.
 230         (info_print_command_completer): Delete.
 231         (info_print_args_help): Add extra parameter, and optionally
 232         include text about -n flag.
 233         * cli/cli-utils.h (struct info_print_options): Delete.
 234         (extract_info_print_options): Delete declaration.
 235         (info_print_command_completer): Delete declaration.
 236         (info_print_args_help): Add extra parameter, extend header
 237         comment.
 238         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 239         search_symbols.
 240         * stack.c (struct info_print_options): New type.
 241         (info_print_options_defs): New file scoped variable.
 242         (make_info_print_options_def_group): New static function.
 243         (info_print_command_completer): New static function.
 244         (info_locals_command): Update to use new local functions.
 245         (info_args_command): Likewise.
 246         (_initialize_stack): Add extra parameter to calls to
 247         info_print_args_help.
 248         * symtab.c (search_symbols): Add extra parameter, use this to
 249         possibly excluse non-debug symbols.
 250         (symtab_symbol_info): Add extra parameter, which is passed on to
 251         search_symbols.
 252         (struct info_print_options): New type.
 253         (info_print_options_defs): New file scoped variable.
 254         (make_info_print_options_def_group): New static function.
 255         (info_print_command_completer): New static function.
 256         (info_variables_command): Update to use local functions, and pass
 257         extra parameter through to symtab_symbol_info.
 258         (info_functions_command): Likewise.
 259         (info_types_command): Pass additional argument through to
 260         symtab_symbol_info.
 261         (rbreak_command): Pass extra argument to search_symbols.
 262         (_initialize_symtab): Add extra arguments for calls to
 263         info_print_args_help, and update help text for 'info variables',
 264         'whereis', and 'info functions' commands.
 265         * symtab.h (search_symbols): Add extra argument to declaration.
 266         * NEWS: Mention new flags.
 267
 268 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 269
 270         * symtab.c (lookup_static_symbol): Call the new function (and move
 271         it down to be next to lookup_global_symbol).
 272         (struct global_sym_lookup_data): Add block_enum member and rename to...
 273         (struct global_or_static_sym_lookup_data): ...this.
 274         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 275         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 276         (lookup_symbol_global_or_static_iterator_cb): ...this.
 277         (lookup_global_or_static_symbol): New function.
 278         (lookup_global_symbol): Call new function.
 279
 280 2019-08-26  Tom de Vries  <tdevries@suse.de>
 281
 282         PR c++/24852
 283         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 284         when pc_probe.prob == NULL.
 285
 286 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 287
 288         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 289         variable symbol_linkage to symbol_linkage_.
 290
 291 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 292
 293         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 294         represent whether the symbol is static, dynamic, or we don't
 295         know.
 296
 297 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 298
 299         * gdb/rx-tdep.c (rx_register_names): New.
 300         (rx_register_name): Delete.
 301         (rx_psw_type): Delete.
 302         (rx_fpsw_type): Delete.
 303         (rx_register_type): Delete.
 304         (rx_gdbarch_init): Convert target-descriptions.
 305         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 306         * gdb/features/Makefile: Add rx.xml.
 307         * gdb/features/rx.xml: New.
 308         * gdb/features/rx.c: Generated.
 309         * gdb/NEWS: Mention target description support.
 310
 311 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 312
 313         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 314         *slot_ptr.
 315
 316 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 317
 318         * configure.ac: Don't check for 'dlfcn.h' (moved to
 319         gdbsupport/common.m4).
 320         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 321         'gdbsupport/'.
 322         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 323         * compile/compile-c-support.c: Include
 324         'gdbsupport/gdb-dlfcn.h'.
 325         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 326         * gdb-dlfcn.c: Move to...
 327         * gdbsupport/gdb-dlfcn.c: ... here.
 328         * gdb-dlfcn.h: Move to...
 329         * gdbsupport/gdb-dlfcn.h: ... here.
 330
 331 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 332
 333         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 334         the offset field signed.
 335
 336 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 337
 338         * python/lib/gdb/__init__.py (_execute_file): New function.
 339         * python/python.c (python_run_simple_file): Call gdb._execute_file
 340         on Windows.
 341
 342 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 343
 344         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 345         all uses as this was never set to anything but a zero value.
 346
 347 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 348
 349         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 350
 351 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 352
 353         * tui/tui-data.h (tui_gen_win_info): Add an =default
 354         move constructor, required by some GCC versions.
 355
 356 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 357
 358         * go32-nat.c (go32_sysinfo): Add hygon_p.
 359
 360 2019-08-20  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 363         line_from_reg_element_no, first_reg_element_no_inline,
 364         display_all_data, delete_data_content_windows,
 365         erase_data_content>: Now private.
 366
 367 2019-08-20  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 370         (tui_unhighlight_win, tui_highlight_win)
 371         (tui_win_info::make_window): Update.
 372         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 373
 374 2019-08-20  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 377         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 378         (MAX_PID_WIDTH): Move to tui-stack.c.
 379         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 380         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 381         (MAX_PID_WIDTH): Move from tui-data.h.
 382
 383 2019-08-20  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 386         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 387         (box_win): Update.
 388         (tui_gen_win_info::make_window): Rename from tui_make_window.
 389         (tui_win_info::make_window): New method.
 390         (tui_gen_win_info::make_visible): Update.
 391         * tui/tui-source.c (tui_source_window::set_contents): Update.
 392         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 393         (tui_data_window::display_registers_from): Update.
 394         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 395         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 396         Declare.
 397         <can_box>: Remove.
 398         <title>: Remove.
 399         (struct tui_win_info) <make_window>: Declare.
 400         <can_box>: Now virtual.
 401         <title>: New member.
 402         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 403         * tui/tui-command.c (tui_cmd_window::resize): Update.
 404
 405 2019-08-20  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 408         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 409         (tui_data_window::check_register_values): Update.
 410
 411 2019-08-20  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-regs.h (struct tui_data_window): Use
 414         DISABLE_COPY_AND_ASSIGN.
 415         <regs_content>: Change type, removing unique_ptr.
 416         <tui_data_window>: Add move constructor.
 417         * tui/tui-regs.c (tui_data_window::show_registers)
 418         (tui_data_window::show_register_group)
 419         (tui_data_window::display_registers_from)
 420         (tui_data_window::display_registers_from)
 421         (tui_data_window::first_data_item_displayed)
 422         (tui_data_window::delete_data_content_windows)
 423         (tui_data_window::rerender, tui_data_window::refresh_window)
 424         (tui_data_window::check_register_values): Update.
 425
 426 2019-08-20  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 429         show_register_group>: Declare.
 430         (tui_show_register_group): Don't declare.
 431         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 432         tui_show_registers.
 433         (tui_data_window::show_register_group): Rename from
 434         tui_show_register_group.
 435         (tui_data_window::check_register_values, tui_reg_command):
 436         Update.
 437         * tui/tui-layout.c (tui_set_layout): Update.
 438
 439 2019-08-20  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 442         Declare.
 443         (tui_check_register_values): Don't declare.
 444         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 445         from tui_check_register_values.
 446         * tui/tui-hooks.c (tui_register_changed): Update.
 447
 448 2019-08-20  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-regs.c (tui_reg_layout): Move later.
 451         (tui_show_registers): Don't enable TUI mode or change layout.
 452
 453 2019-08-20  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-regs.h (struct tui_data_item_window)
 456         <~tui_data_item_window>: Remove.
 457         <content>: Now a unique_xmalloc_ptr.
 458         * tui/tui-regs.c (tui_register_format): Return a
 459         unique_xmalloc_ptr.
 460         (tui_get_register): Update.
 461         (~tui_data_item_window): Remove.
 462         (tui_data_window::display_registers_from, tui_display_register):
 463         Update.
 464         * tui/tui-io.h (tui_expand_tabs): Update.
 465         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 466         Remove "col" parameter.
 467
 468 2019-08-20  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 471         field.
 472         * tui/tui-regs.c (~tui_data_item_window): Update.
 473
 474 2019-08-20  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 477         earlier.
 478
 479 2019-08-20  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 482
 483 2019-08-20  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-source.h (struct tui_source_window): Update.
 486         * tui/tui-regs.c (tui_show_registers): Update.
 487         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 488         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 489         (NO_REGS_STRING): Remove defines.
 490
 491 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 492
 493         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 494         unnecessary thread walk if remote doesn't support the packet.
 495
 496 2019-08-19  Tom Tromey  <tromey@adacore.com>
 497
 498         * python/py-value.c (value_has_field): Fix indentation.
 499
 500 2019-08-19  Tom Tromey  <tromey@adacore.com>
 501
 502         * printcmd.c (do_one_display, info_display_command): Update.
 503         * block.h (contained_in): Return bool.  Add allow_nested
 504         parameter.
 505         * block.c (contained_in): Return bool.  Add allow_nested
 506         parameter.
 507
 508 2019-08-19  Tom Tromey  <tom@tromey.com>
 509
 510         * configure: Rebuild.
 511         * configure.ac: Disallow the combination of -static-libstdc++ and
 512         source highlight.
 513         * source-cache.c (get_language_name): Handle rust.
 514         (source_cache::get_source_lines): Ignore highlighting exceptions.
 515
 516 2019-08-16  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 519         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 520         (struct tui_source_window_base) <make_visible, refresh_window,
 521         resize>: Remove methods.
 522         <execution_info>: Remove field.
 523         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 524         (tui_show_source_line, tui_source_window_base)
 525         (~tui_source_window_base): Update.
 526         (tui_source_window_base::resize)
 527         (tui_source_window_base::make_visible)
 528         (tui_source_window_base::refresh_window): Remove.
 529         (tui_source_window_base::update_exec_info): Update.
 530         * tui/tui-source.c (tui_source_window::set_contents): Update.
 531         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 532
 533 2019-08-16  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 536         deprecated_query_hook.
 537
 538 2019-08-16  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 541         (tui_update_source_windows_with_line): Update.
 542         * tui/tui-source.h (struct tui_source_window)
 543         <show_symtab_source>: Declare.
 544         (tui_show_symtab_source): Don't declare.
 545         * tui/tui-source.c (tui_show_symtab_source): Rename from
 546         tui_show_symtab_source.
 547
 548 2019-08-16  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-winsource.h (struct tui_source_window_base)
 551         <set_contents>: Declare.
 552         * tui/tui-winsource.c
 553         (tui_source_window_base::update_source_window_as_is): Update.
 554         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 555         Declare.
 556         (tui_set_source_content): Don't declare.
 557         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 558         tui_set_source_content.
 559         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 560         Declare.
 561         (tui_set_disassem_content): Don't declare.
 562         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 563         tui_set_disassem_content.
 564
 565 2019-08-16  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-winsource.h (struct tui_source_window_base)
 568         <update_breakpoint_info>: Declare.
 569         (tui_update_breakpoint_info): Don't declare.
 570         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 571         (tui_update_all_breakpoint_info): Update.
 572         (tui_source_window_base::update_breakpoint_info): Rename from
 573         tui_update_breakpoint_info.
 574         (tui_source_window_base::update_exec_info): Update.
 575
 576 2019-08-16  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-winsource.h (struct tui_source_window_base)
 579         <update_source_window>: Declare.
 580         (tui_update_source_window): Don't declare.
 581         * tui/tui-winsource.c
 582         (tui_source_window_base::update_source_window): Rename from
 583         tui_update_source_window.
 584         (tui_source_window_base::rerender): Update.
 585         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 586         * tui/tui-disasm.c (tui_show_disassem)
 587         (tui_show_disassem_and_update_source)
 588         (tui_disasm_window::maybe_update): Update.
 589
 590 2019-08-16  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-winsource.h (struct tui_source_window_base)
 593         <update_source_window_as_is>: Declare.
 594         (tui_update_source_window_as_is): Don't declare.
 595         * tui/tui-winsource.c (tui_update_source_window): Update
 596         (tui_source_window_base::update_source_window_as_is): Rename from
 597         tui_update_source_window_as_is.
 598         (tui_source_window_base::refill): Update.
 599         * tui/tui-source.c (tui_show_symtab_source): Update.
 600         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 601         Update.
 602
 603 2019-08-16  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-winsource.h (tui_update_source_window)
 606         (tui_update_source_window_as_is): Remove "noerror" parameter.
 607         * tui/tui-winsource.c (tui_update_source_window)
 608         (tui_update_source_window_as_is): Remove "noerror" parameter.
 609         (tui_update_source_windows_with_addr)
 610         (tui_update_source_windows_with_line)
 611         (tui_source_window_base::rerender)
 612         (tui_source_window_base::refill): Update.
 613         * tui/tui-source.h (tui_set_source_content)
 614         (tui_show_symtab_source): Remove "noerror" parameter.
 615         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 616         parameter.
 617         (tui_show_symtab_source): Likewise.
 618         (tui_source_window::maybe_update): Update.
 619         * tui/tui-disasm.c (tui_show_disassem)
 620         (tui_show_disassem_and_update_source)
 621         (tui_disasm_window::do_scroll_vertical)
 622         (tui_disasm_window::maybe_update): Update.
 623
 624 2019-08-16  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui.c (tui_is_window_visible): Update.
 627         * tui/tui-wingeneral.c (tui_make_window)
 628         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 629         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 630         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 631         (tui_set_win_height_command, parse_scrolling_args): Update.
 632         * tui/tui-source.c (tui_source_window::style_changed): Update.
 633         * tui/tui-regs.c (tui_show_registers)
 634         (tui_data_window::first_data_item_displayed)
 635         (tui_data_window::delete_data_content_windows)
 636         (tui_check_register_values, tui_reg_command): Update.
 637         * tui/tui-disasm.c (tui_show_disassem): Update.
 638         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 639         method.
 640         <is_visible>: Remove field.
 641         * tui/tui-data.c (tui_next_win, tui_prev_win)
 642         (tui_delete_invisible_windows): Update.
 643
 644 2019-08-16  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-winsource.h (struct tui_source_window_base)
 647         <m_has_locator>: Remove.
 648         * tui/tui-layout.c (show_source_disasm_command, show_data)
 649         (show_source_or_disasm_and_command): Update.
 650
 651 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 652
 653         * NEWS (Other MI changes): New subsection.
 654         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 655         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 656         * arch-utils.c (default_get_pc_address_flags): New function.
 657         * arch-utils.h (default_get_pc_address_flags): New declaration.
 658         * gdbarch.sh: Add get_pc_address_flags.
 659         * gdbarch.c: Regenerate.
 660         * gdbarch.h: Likewise.
 661         * stack.c (print_pc): New function.
 662         (print_frame_info) (print_frame): Call print_pc.
 663
 664 2019-08-16  Tom de Vries  <tdevries@suse.de>
 665
 666         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 667         print_objfile_section_info.
 668
 669 2019-08-15  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 672         calling update_cmdwin_start_line.
 673         * tui/tui-winsource.h (struct tui_source_window_base)
 674         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 675         <rerender>: Declare.
 676         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 677         Call rerender.
 678         (tui_source_window_base::set_new_height): Remove.
 679         (tui_source_window_base::rerender): Rename from
 680         do_make_visible_with_new_height.
 681         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 682         resize method.
 683         (tui_win_info::make_invisible_and_set_new_height)
 684         (tui_win_info::make_visible_with_new_height): Remove.
 685         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 686         Declare.
 687         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 688         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 689         do_make_visible_with_new_height>: Don't declare.
 690         <rerender>: Declare.
 691         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 692         set_new_height.
 693         (tui_data_window::do_make_visible_with_new_height): Remove.
 694         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 695         call tui_show_locator_content.
 696         (tui_gen_win_info::resize): Call rerender.
 697         (show_source_or_disasm_and_command): Don't call
 698         tui_show_locator_content.
 699         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 700         method.
 701         (struct tui_win_info) <rerender>: Declare.
 702         <set_new_height, make_invisible_and_set_new_height,
 703         make_visible_with_new_height>: Don't declare.
 704         * tui/tui-data.c (tui_win_list::rerender): New method.
 705         * tui/tui-command.h (struct tui_cmd_window)
 706         <do_make_visible_with_new_height>: Don't declare.
 707         * tui/tui-command.c
 708         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 709
 710 2019-08-15  Tom Tromey  <tromey@adacore.com>
 711
 712         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 713         * ada-lang.c (ada_enum_name): Likewise.
 714
 715 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 716
 717         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 718         leading underscore.
 719         (GdbOutputErrorFile): Likewise.
 720         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 721         accordingly.
 722         (execute_unwinders): Rename to have a leading underscore.
 723         (auto_load_packages): Likewise.
 724         (global scope): Adjust call to auto_load_packages accordingly.
 725         (GdbSetPythonDirectory): Likewise.
 726         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 727         instead of execute_unwinders.
 728
 729 2019-08-15  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 732         (show_data): Don't change window visibility.
 733         (tui_gen_win_info::resize): Remove special case for command
 734         window.  Use wresize, when available.
 735         (show_source_or_disasm_and_command): Don't change window
 736         visibility.
 737         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 738         <make_visible>: New method.
 739         * tui/tui-command.c (tui_cmd_window::resize): New method.
 740
 741 2019-08-15  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 744         (struct tui_source_windows): New.
 745         * tui/tui-winsource.c (tui_display_main): Update.
 746         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 747         (new_height_ok, parse_scrolling_args): Update.
 748         * tui/tui-layout.c (show_layout, show_data): Update.
 749         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 750         (tui_add_to_source_windows): Don't declare.
 751         * tui/tui-data.c (source_windows, tui_source_windows)
 752         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 753
 754 2019-08-15  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 757         Rename from reset.
 758         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 759         * tui/tui-layout.c (show_source_disasm_command, show_data):
 760         Update.
 761         (tui_gen_win_info::resize): Rename.
 762         (show_source_or_disasm_and_command): Update.
 763         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 764         reset.
 765
 766 2019-08-15  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 769         * tui/tui-interp.c (tui_interp::init): Don't call
 770         tui_initialize_static_data.
 771         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 772
 773 2019-08-15  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 776         examine tui_win_list.
 777
 778 2019-08-15  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 781         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 782         tui_clear_source_content.
 783         (tui_clear_source_content): Remove.
 784         (tui_source_window_base::do_erase_source_content): Hoist call to
 785         content.clear().
 786         * tui/tui-stack.c (tui_show_frame_info): Don't call
 787         tui_clear_source_content.
 788
 789 2019-08-15  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-winsource.h (struct tui_source_window_base)
 792         <do_erase_source_content>: New method.
 793         <erase_source_content>: New method.
 794         (tui_erase_source_content): Don't declare.
 795         * tui/tui-winsource.c (tui_clear_source_content): Update.
 796         (tui_source_window_base::do_erase_source_content): Rename from
 797         tui_erase_source_content.
 798         (tui_source_window_base::show_source_content): Update.
 799         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 800         * tui/tui-source.h (struct tui_source_window)
 801         <erase_source_content>: New method.
 802         * tui/tui-disasm.h (struct tui_disasm_window)
 803         <erase_source_content>: New method.
 804
 805 2019-08-15  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 808         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 809         constructor.
 810         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 811         * tui/tui-source.c (tui_set_source_content): Update.
 812         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 813
 814 2019-08-15  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 817         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 818         tui-source.c.
 819         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 820         Declare.
 821         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 822         method.
 823         (tui_source_window::maybe_update): Update.
 824
 825 2019-08-15  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 828         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 829         tui-disasm.c.
 830         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 831         Declare.
 832         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 833         method.
 834         (tui_disasm_window::maybe_update): Update.
 835
 836 2019-08-15  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-winsource.h (struct tui_source_window_base)
 839         <maybe_update>: Declare.
 840         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 841         method.
 842         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 843         Declare.
 844         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 845         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 846         Declare.
 847         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 848
 849 2019-08-15  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 852
 853 2019-08-15  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-wingeneral.c: Include tui-stack.h.
 856         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 857         (struct tui_locator_window): Move from tui-data.h.
 858         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 859         (tui_initialize_static_data): Move from tui-data.c.
 860         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 861         (struct tui_locator_window): Move to tui-stack.c.
 862         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 863         (tui_initialize_static_data): Move to tui-stack.c.
 864
 865 2019-08-15  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-layout.c (show_source_disasm_command)
 868         (show_source_or_disasm_and_command): Use make_visible method, not
 869         tui_make_window.
 870         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 871         Remove.
 872
 873 2019-08-15  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-wingeneral.h (tui_make_window): Update.
 876         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 877         parameter.
 878         (tui_gen_win_info::make_visible): Update.
 879         * tui/tui-regs.c (tui_data_window::display_registers_from):
 880         Update.
 881         * tui/tui-layout.c (show_source_disasm_command)
 882         (show_source_or_disasm_and_command): Update.
 883         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 884         (enum tui_box): Remove.
 885         (struct tui_win_info) <can_box>: New method.
 886         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 887         method.
 888
 889 2019-08-15  Tom de Vries  <tdevries@suse.de>
 890
 891         * linux-nat-trad.c: Include gdbarch.h.
 892
 893 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 894
 895         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 896         register sizes.
 897
 898 2019-08-14  Tom Tromey  <tromey@adacore.com>
 899
 900         * darwin-nat.c: Include gdbarch.h.
 901         * darwin-nat-info.c: Include gdbarch.h.
 902
 903 2019-08-13  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 906         Remove.
 907         * tui/tui-data.c (tui_initialize_static_data): Update.
 908
 909 2019-08-13  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-winsource.h (struct tui_exec_info_window)
 912         <~tui_exec_info_window, maybe_allocate_content, get_content,
 913         m_content>: Remove.
 914         (struct tui_source_window_base) <set_exec_info_content,
 915         show_exec_info_content>: Don't declare.
 916         * tui/tui-winsource.c
 917         (tui_exec_info_window::maybe_allocate_content): Remove.
 918         (tui_source_window_base::update_exec_info): Rename from
 919         set_exec_info_content.
 920         (tui_source_window_base::show_exec_info_content)
 921         (tui_source_window_base::update_exec_info): Remove.
 922
 923 2019-08-13  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 926         declare.
 927         * tui/tui-winsource.c (tui_update_source_window_as_is)
 928         (tui_update_source_windows_with_addr, tui_erase_source_content):
 929         Update.
 930         (tui_clear_exec_info_content): Remove.
 931
 932 2019-08-13  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 935         declare.
 936         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 937         call tui_erase_exec_info_content.
 938         (tui_clear_exec_info_content): Rename from
 939         tui_erase_exec_info_content.
 940         (tui_clear_exec_info_content): Delete.
 941
 942 2019-08-13  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-winsource.h (struct tui_source_window_base)
 945         <show_exec_info_content>: Declare.
 946         (tui_show_exec_info_content): Don't declare.
 947         * tui/tui-winsource.c
 948         (tui_source_window_base::show_exec_info_content): Rename from
 949         tui_show_exec_info_content.
 950         (tui_source_window_base::update_exec_info): Update.
 951
 952 2019-08-13  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 955         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 956         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 957         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 958         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 959         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 960         ... here.
 961
 962 2019-08-13  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-winsource.h (struct tui_source_window_base)
 965         <update_exec_info>: Declare.
 966         (tui_update_exec_info): Don't declare.
 967         * tui/tui-winsource.c (tui_update_source_window_as_is)
 968         (tui_source_window_base::refresh_all)
 969         (tui_update_all_breakpoint_info): Update.
 970         (tui_source_window_base::update_exec_info): Rename from
 971         tui_update_exec_info.
 972         * tui/tui-stack.c (tui_show_frame_info): Update.
 973
 974 2019-08-13  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-winsource.h (struct tui_source_window_base)
 977         <set_exec_info_content>: Declare.
 978         (tui_set_exec_info_content): Don't declare.
 979         * tui/tui-winsource.c
 980         (tui_source_window_base::set_exec_info_content): Rename from
 981         tui_set_exec_info_content.
 982         (tui_update_exec_info): Update.
 983
 984 2019-08-13  Tom Tromey  <tom@tromey.com>
 985
 986         * tui/tui-winsource.h (struct tui_source_window_base)
 987         <show_source_content>: Declare.
 988         (tui_show_source_content): Don't declare.
 989         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 990         (tui_source_window_base::show_source_content): Rename from
 991         tui_show_source_content.
 992         (tui_source_window_base::refresh_all): Update.
 993         * tui/tui-layout.c (show_source_disasm_command)
 994         (show_source_or_disasm_and_command): Update.
 995
 996 2019-08-13  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-winsource.c (tui_erase_source_content)
 999         (tui_show_source_content, tui_source_window_base::refresh_all):
1000         Update.
1001         * tui/tui-wingeneral.h
1002         (tui_check_and_display_highlight_if_needed): Don't declare.
1003         * tui/tui-wingeneral.c
1004         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1005         check_and_display_highlight_if_needed.
1006         * tui/tui-win.c (tui_rehighlight_all)
1007         (tui_win_info::make_visible_with_new_height): Update.
1008         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1009         (tui_data_window::erase_data_content)
1010         (tui_data_window::display_all_data): Update.
1011         * tui/tui-data.h (struct tui_win_info)
1012         <check_and_display_highlight_if_needed>: Declare.
1013
1014 2019-08-13  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-win.c (tui_resize_all): Call
1017         tui_delete_invisible_windows.
1018         * tui/tui-layout.c (show_layout): Call
1019         tui_delete_invisible_windows.
1020         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1021         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1022
1023 2019-08-13  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1026         tui_add_win_to_layout.
1027
1028 2019-08-13  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1031         * tui/tui-layout.c (tui_default_win_height): Now static.
1032
1033 2019-08-13  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1036         single switch.
1037         (show_source_disasm_command, show_source_or_disasm_and_command):
1038         Don't check current layout.
1039
1040 2019-08-13  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-wingeneral.c (make_all_visible): Remove.
1043         (tui_make_all_invisible): Simplify.
1044         * tui/tui-layout.c (tui_make_all_invisible): Move from
1045         tui-wingeneral.c; simplify.
1046         (show_layout): Hoist call to tui_make_all_invisible.
1047         (show_data): Don't call tui_make_all_invisible.
1048
1049 2019-08-13  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1052         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1053
1054 2019-08-13  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1057         tui-data.c.
1058         (show_source_disasm_command, show_data)
1059         (show_source_or_disasm_and_command): Don't use
1060         tui_set_current_layout_to.
1061         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1062         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1063         tui-layout.c.
1064         (tui_set_current_layout_to): Remove.
1065
1066 2019-08-13  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-layout.c (tui_set_layout): Update.
1069         * tui/tui-data.h (struct tui_layout_def): Remove.
1070         (tui_layout_def): Don't declare.
1071         * tui/tui-data.c (layout_def): Remove.
1072         (tui_layout_def): Remove.
1073
1074 2019-08-13  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-winsource.h (struct tui_source_window_base)
1077         <clear_detail>: No longer "override".
1078         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1079         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1080         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1081         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1082         Remove.
1083         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1084
1085 2019-08-13  Tom Tromey  <tromey@adacore.com>
1086
1087         * tracepoint.c: Don't include readline.h or history.h.
1088
1089 2019-08-12  Tom Tromey  <tom@tromey.com>
1090
1091         * configure: Rebuild.
1092         * configure.ac: Check for readline 7.
1093         * NEWS: Mention readline 7 requirement.
1094         * README: Update.
1095
1096 2019-08-12  Tom Tromey  <tom@tromey.com>
1097
1098         * mingw-hdep.c (gdb_select): Remove readline hack.
1099
1100 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1101
1102         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1103         when the function fails.
1104
1105 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1106
1107         * s390-tdep.c (s390_type_align): New function.
1108         (s390_gdbarch_init): Set it as type_align gdbarch method.
1109
1110 2019-08-09  Tom de Vries  <tdevries@suse.de>
1111
1112         PR gdb/24591
1113         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1114         pc_low with relocation offset.
1115
1116 2019-08-07  Tom Tromey  <tromey@adacore.com>
1117
1118         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1119         (print_frame_args): Update.
1120         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1121         Update.
1122         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1123         * frame.h (struct frame_arg): Add initializers.
1124         <error>: Now a unique_xmalloc_ptr.
1125
1126 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1127
1128         * NEWS: Expand the Pointer Authentication entry.
1129         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1130         (aarch64_frame_unmask_lr): ... to this.
1131         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1132         Call aarch64_frame_unmask_lr.
1133         * frame.c (struct frame_info): Add "masked" variable.
1134         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1135         (fprint_frame): Check for masked pc.
1136         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1137         declarations.
1138         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1139         * stack.c (print_frame): Check for masked pc.
1140
1141 2019-08-06  Tom Tromey  <tom@tromey.com>
1142
1143         * stabsread.c (patch_block_stabs, read_one_struct_field)
1144         (read_enum_type): Use obstack_strndup.
1145         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1146         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1147         * dwarf2read.c (guess_full_die_structure_name)
1148         (anonymous_struct_prefix): Use obstack_strndup.
1149         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1150         * c-exp.y (yylex): Use obstack_strndup.
1151         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1152         (write_var_or_type): Use obstack_strndup.
1153
1154 2019-08-06  Tom Tromey  <tom@tromey.com>
1155
1156         * symfile.c (reread_symbols): Use obstack_strdup.
1157         * stabsread.c (read_type): Use obstack_strdup.
1158         * gdb_obstack.h (obstack_strdup): New overload.
1159         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1160         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1161         (dwarf2_canonicalize_name): Use obstack_strdup.
1162         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1163         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1164         Use obstack_strdup.
1165
1166 2019-08-06  Tom Tromey  <tom@tromey.com>
1167
1168         * gdb_obstack.h (obstack_strdup): Define.
1169         * gdb_obstack.c (obstack_strdup): Don't define.
1170
1171 2019-08-06  Tom Tromey  <tom@tromey.com>
1172
1173         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1174         obstack_strdup.
1175         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1176         obstack_strdup.
1177         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1178         * stabsread.c (common_block_start): Use obstack_strdup.
1179         * objfiles.c (set_objfile_main_name, objfile): Use
1180         obstack_strdup.
1181         * namespace.c (add_using_directive): Use obstack_strdup.
1182         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1183         * jit.c (finalize_symtab): Use obstack_strdup.
1184         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1185         (guess_partial_die_structure_name, partial_die_info::fixup)
1186         (dwarf2_name): Use obstack_strdup.
1187         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1188         obstack_strdup.
1189         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1190         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1191         obstack_strdup.
1192         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1193
1194 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1195
1196         * unittests/help-doc-selftests.c: New file.
1197         * Makefile.in: Add the new file.
1198
1199 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1200
1201         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1202         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1203         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1204         the trailing '.' is not output, and the first character is uppercased.
1205         (print_help_for_command): Update call to print_doc_line.
1206         (print_doc_of_command): Likewise.
1207         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1208         * cli/cli-option.c (append_indented_doc): Do not append newline.
1209         (build_help_option): Append newline after first appended_indented_doc
1210         only if a second call is done.
1211         (build_help): Append 2 new lines before each option, except the first
1212         one.
1213         * compile/compile.c (_initialize_compile): Add new lines after
1214         %OPTIONS%, when not at the end of the help.
1215         Change help doc or code
1216         producing the help doc to respect the invariants.
1217         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1218         Also removed the new line after 'Options:', as all other commands
1219         do not put an empty line between 'Options:' and the first option.
1220         * printcmd.c (_initialize_printcmd): Likewise.
1221         * stack.c (_initialize_stack): Likewise.
1222         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1223         incorrectly telling COMMAND is optional.
1224         * ada-lang.c (_initialize_ada_language): Change help doc or code
1225         producing the help doc to respect the invariants.
1226         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1227         * breakpoint.c (_initialize_breakpoint): Likewise.
1228         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1229         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1230         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1231         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1232         _initialize_cli_style): Likewise.
1233         * corelow.c (core_target_info): Likewise.
1234         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1235         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1236         * filesystem.c (_initialize_filesystem): Likewise.
1237         * frame.c (_initialize_frame): Likewise.
1238         * gnu-nat.c (add_task_commands): Likewise.
1239         * infcall.c (_initialize_infcall): Likewise.
1240         * infcmd.c (_initialize_infcmd): Likewise.
1241         * interps.c (_initialize_interpreter): Likewise.
1242         * language.c (_initialize_language): Likewise.
1243         * linux-fork.c (_initialize_linux_fork): Likewise.
1244         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1245         * maint.c (_initialize_maint_cmds): Likewise.
1246         * memattr.c (_initialize_mem): Likewise.
1247         * printcmd.c (_initialize_printcmd): Likewise.
1248         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1249         _RegEx): Likewise.
1250         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1251         * record-btrace.c (_initialize_record_btrace): Likewise.
1252         * record-full.c (_initialize_record_full): Likewise.
1253         * record.c (_initialize_record): Likewise.
1254         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1255         * regcache.c (_initialize_regcache): Likewise.
1256         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1257         _initialize_remote): Likewise.
1258         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1259         * serial.c (_initialize_serial): Likewise.
1260         * skip.c (_initialize_step_skip): Likewise.
1261         * source.c (_initialize_source): Likewise.
1262         * stack.c (_initialize_stack): Likewise.
1263         * symfile.c (_initialize_symfile): Likewise.
1264         * symtab.c (_initialize_symtab): Likewise.
1265         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1266         * top.c (init_main): Likewise.
1267         * tracefile-tfile.c (tfile_target_info): Likewise.
1268         * tracepoint.c (_initialize_tracepoint): Likewise.
1269         * tui/tui-win.c (_initialize_tui_win): Likewise.
1270         * utils.c (add_internal_problem_command): Likewise.
1271         * valprint.c (value_print_option_defs): Likewise.
1272
1273 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1274
1275         PR build/24886
1276         * configure.ac: Drop enable-libmcheck support.
1277         * configure, config.in: Rebuild.
1278         * libmcheck.m4: Remove.
1279         * acinclude.m4: Don't include it.
1280         * Makefile.in: Don't distribute it.
1281         * top.c (print_gdb_configuration): Don't mention it.
1282
1283 2019-08-06  Tom Tromey  <tom@tromey.com>
1284
1285         * utils.c (set_output_style): Sometimes pass stream to
1286         emit_style_escape.
1287         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1288         * record-btrace.c (btrace_insn_history): Update.
1289         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1290         method.
1291         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1292         Update initializers.
1293         <m_uiout>: New field.
1294         <m_di>: Move lower.
1295         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1296         Remove "uiout" parameter.
1297         (dump_insns): Update.
1298         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1299         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1300
1301 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1302
1303         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1304         (error_in_psymtab_expansion): Likewise.
1305         (lookup_symbol_via_quick_fns): Likewise.
1306         (basic_lookup_transparent_type_quick): Likewise.
1307         (basic_lookup_transparent_type_1): Likewise.
1308
1309 2019-08-06  Tom Tromey  <tromey@adacore.com>
1310
1311         * source.c (last_source_error): Now bool.
1312         (print_source_lines_base): Make "noprint" bool.  Only open
1313         source file when last_source_visited changes.
1314
1315 2019-08-06  Tom Tromey  <tromey@adacore.com>
1316
1317         * annotate.c (annotate_source_line): Use g_source_cache.
1318         * source-cache.c (source_cache::get_plain_source_lines): Change
1319         parameters.  Populate m_offset_cache.
1320         (source_cache::ensure): New method.
1321         (source_cache::get_line_charpos): New method.
1322         (extract_lines): Move lower.  Change parameters.
1323         (source_cache::get_source_lines): Move lower.
1324         * source-cache.h (class source_cache): Update comment.
1325         <get_line_charpos>: New method.
1326         <get_source_lines>: Update comment.
1327         <clear>: Clear m_offset_cache.
1328         <get_plain_source_lines>: Change parameters.
1329         <ensure>: New method
1330         <m_offset_cache>: New member.
1331         * source.c (forget_cached_source_info_for_objfile): Update.
1332         (info_source_command): Use g_source_cache.
1333         (find_source_lines, open_source_file_with_line_charpos): Remove.
1334         (print_source_lines_base, search_command_helper): Use g_source_cache.
1335         * source.h (open_source_file_with_line_charpos): Don't declare.
1336         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1337         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1338         Use g_source_cache.
1339
1340 2019-08-06  Tom Tromey  <tromey@adacore.com>
1341
1342         * source-cache.c (source_cache::get_plain_source_lines):
1343         Remove "first_line" and "last_line" parameters.
1344         (source_cache::get_source_lines): Cache plain text.
1345         * source-cache.h (class source_cache)
1346         <get_plain_source_lines>: Update.
1347
1348 2019-08-06  Tom Tromey  <tromey@adacore.com>
1349
1350         * source-cache.c (extract_lines): No longer a method.
1351         Changed type of parameter.  Include final newline.
1352         (selftests::extract_lines_test): New function.
1353         (_initialize_source_cache): Likewise.
1354         * source-cache.h (class source_cache)
1355         <extract_lines>: Don't declare.
1356
1357 2019-08-06  Tom Tromey  <tromey@adacore.com>
1358
1359         * breakpoint.c (init_breakpoint_sal): Update.
1360         (breakpoint): Update.
1361         * breakpoint.h (struct breakpoint) <filter>: Now a
1362         unique_xmalloc_ptr.
1363
1364 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1365
1366         * NEWS: Mention dictionary access on blocks.
1367         * python/py-block.c (blpy_getitem): New function.
1368         (block_object_as_mapping): New struct.
1369         (block_object_type): Use new struct for tp_as_mapping field.
1370
1371 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1372
1373         * objfiles.h (objfile): Add a comment describing partial symbols.
1374
1375 2019-08-05  Tom Tromey  <tromey@adacore.com>
1376
1377         * compile/compile.c (_initialize_compile): Use _(), not N_().
1378         * thread.c (_initialize_thread): Use _(), not N_().
1379         * stack.c (_initialize_stack): Use _(), not N_().
1380         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1381
1382 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1383
1384         * dwarf2read.c (struct dw2_symtab_iterator):
1385         <want_specific_block>: Remove.
1386         <block_index>: Change type to gdb::optional.
1387         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1388         change type of BLOCK_INDEX parameter to gdb::optional.
1389         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1390         (dw2_lookup_symbol): Don't pass argument for
1391         WANT_SPECIFIC_BLOCK.
1392         (dw2_expand_symtabs_for_function): Don't pass argument for
1393         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1394         (class dw2_debug_names_iterator)
1395         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1396         parameter, change BLOCK_INDEX type to gdb::optional.
1397         <m_want_specific_block>: Remove.
1398         <m_block_index>: Change type to gdb::optional.
1399         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1400         gdb::optional.  Re-write in function of gdb::optional.
1401         (dw2_debug_names_lookup_symbol): Don't pass argument for
1402         WANT_SPECIFIC_BLOCK.
1403         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1404         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1405         BLOCK_INDEX.
1406
1407 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1408
1409         * NEWS: Mention changes to "info sources" command.
1410
1411 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1412
1413         * symtab.c (filename_partial_match_opts): New struct type.
1414         (struct output_source_filename_data): New members
1415         regexp, c_regexp, partial_match.
1416         (output_source_filename): Use new members to decide to print file.
1417         (info_sources_option_defs): New variable.
1418         (make_info_sources_options_def_group, print_info_sources_header,
1419         info_sources_command_completer):
1420         New functions.
1421         (info_sources_command): Read new optional arguments.
1422         (_initialize_symtab): Update info sources help.
1423
1424 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1425
1426         * ada-lang.c (exception_support_info_v0): Renamed from...
1427         (default_exception_support_info): ... this.  Create new
1428         definition for v1.
1429         (ada_has_this_exception_support): Look up catch_handlers_sym.
1430         (ada_exception_support_info_sniffer): Try v0 after default.
1431
1432 2019-08-01  Tom Tromey  <tromey@adacore.com>
1433
1434         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1435         gdbarch.h.
1436
1437 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1438
1439         * s12z-tdep.c: Fix include path for s12z-opc.h.
1440
1441 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1442
1443         * NEWS: Require GNU make 3.82.
1444
1445 2019-07-16  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1448         declare.
1449
1450 2019-07-30  Tom Tromey  <tromey@adacore.com>
1451
1452         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1453
1454 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1455
1456         * printcmd.c (print_address_symbolic): Print negative offsets.
1457         (build_address_symbolic): Force signed arithmetic when computing
1458         offset.
1459
1460 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1461
1462         PR/24474: Add a function to lookup static variables.
1463         * NEWS: Mention this new function.
1464         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1465         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1466         * python/python.c (python_GdbMethods): Add new function.
1467
1468 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1469
1470         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1471         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1472         (objfpy_lookup_static_symbol): New function.
1473         (objfile_object_methods): Add new functions.
1474
1475 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1476
1477         * NEWS: Mention 'set|show print frame-info'.  Mention new
1478         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1479         backtrace argument.  Mention that python frame filtering code
1480         is now consistent with what 'backtrace' command prints.
1481
1482 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1483
1484         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1485         comments.
1486         (print_frame_info_auto, print_frame_info_source_line,
1487         print_frame_info_location, print_frame_info_source_and_location,
1488         print_frame_info_location_and_address, print_frame_info_short_location):
1489         New declarations.
1490         (struct frame_print_options): New member print_frame_info.
1491         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1492         * stack.h (get_user_print_what_frame_info): New declaration.
1493         (frame_show_address): New declaration.
1494         * stack.c (print_frame_arguments_choices): New value 'presence'.
1495         (print_frame_info_auto, print_frame_info_source_line,
1496         print_frame_info_location, print_frame_info_source_and_location,
1497         print_frame_info_location_and_address, print_frame_info_short_location,
1498         print_frame_info_choices, print_frame_info_print_what): New definitions.
1499         (print_frame_args): Only print dots for args if print frame-arguments
1500         is 'presence'.
1501         (frame_print_option_defs): New element for "frame-info".
1502         (get_user_print_what_frame_info): New function.
1503         (frame_show_address): Make non static.  Move comment to stack.h.
1504         (print_frame_info_to_print_what): New function.
1505         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1506         to decide what to print.
1507         (backtrace_command_1): Handle the new print_frame_arguments_presence
1508         value.
1509         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1510         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1511         (py_print_frame): In non-mi mode, use LOCATION as default for
1512         print_what, similarly to frame information printed directly by
1513         backtrace command. Handle frame-info user option in non MI mode.
1514
1515 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1516
1517         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1518         Add case for debugging 32-bit target on 64-bit host.  Revise
1519         comment.
1520
1521 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1522
1523         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1524         instead of find_function_entry_range_from_pc.
1525
1526 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1527
1528         * stack.c (find_frame_funname): Remove code which preferred
1529         minsym over symtab sym in "certain pathological cases".
1530
1531         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1532         parameter.  Change type of "do_demangle" to bool.
1533         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1534         Pass suitable "prefer_sym_over_minsym" flag to
1535         build_address_symbolic().  Don't output "+" for negative offsets.
1536         * printcmd.c (print_address_symbolic): Update invocation of
1537         build_address_symbolic to include a "prefer_sym_over_minsym"
1538         flag.
1539         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1540         Restrict cases in which use of minimal symbol is preferred to that
1541         of a found symbol.  Update comments.
1542
1543         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1544         for entry pc when entry pc is out of range for that FDE.
1545
1546 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1547
1548         PR gdb/24839:
1549         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1550         type.
1551
1552 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1553
1554         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1555         this function's Python signature.
1556
1557
1558 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1559
1560         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1561         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1562         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1563         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1564         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1565
1566
1567 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1568
1569         * h8300-tdep.c (h8300_register_name_common): New.
1570         h8300_register_name): Use h8300_register_name_common.
1571         (h8300s_register_name): Likewise.
1572         (h8300sx_register_name): Likewise.
1573         (h8300h_register_nam): New.
1574         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1575
1576
1577 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1578
1579         * arm-tdep.c (arm_skip_cmse_entry): New function.
1580         (arm_is_sgstubs_section): New function.
1581         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1582
1583 2019-07-22  Tom Tromey  <tom@tromey.com>
1584
1585         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1586         Don't self-assign.
1587
1588 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1591         type_print.
1592
1593 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1596         so that GDB doesn't match any msymbols when searching in the
1597         TYPES_DOMAIN.
1598         (print_symbol_info): Print using typedef_print or type_print based
1599         on the type of the symbol.  Add updated FIXME comment moved from...
1600         (_initialize_symtab): ... move and update FIXME comment to above.
1601
1602 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1603
1604         * NEWS: Mention adding -q option to "info types".
1605         * symtab.c (struct info_types_options): New struct.
1606         (info_types_options_defs): New variable.
1607         (make_info_types_options_def_group): New function.
1608         (info_types_command): Use gdb::option framework to parse options.
1609         (info_types_command_completer): New function.
1610         (_initialize_symtab): Extend the help text on "info types" and
1611         register command completer.
1612
1613 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1614
1615         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1616         (lookup_symbol_in_objfile): Change int to block_enum and add a
1617         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1618
1619 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1620
1621         * MAINTAINERS (Write After Approval): Add self.
1622
1623 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1624
1625         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1626         instruction to the dummy code region.
1627
1628 2019-07-19  Tom Tromey  <tromey@adacore.com>
1629
1630         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1631         (ARGSUSED, PARAMS, __func__): Remove rules.
1632
1633 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1634
1635         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1636         * features/arm/arm-with-iwmmxt.c: Remove.
1637         * features/arm/arm-with-iwmmxt.xml: Remove.
1638         * features/arm/arm-with-m-fpa-layout.c: Remove.
1639         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1640         * features/arm/arm-with-m-vfp-d16.c: Remove.
1641         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1642         * features/arm/arm-with-m.c: Remove.
1643         * features/arm/arm-with-m.xml: Remove.
1644         * features/arm/arm-with-neon.c: Remove.
1645         * features/arm/arm-with-neon.xml: Remove.
1646         * features/arm/arm-with-vfpv2.c: Remove.
1647         * features/arm/arm-with-vfpv2.xml: Remove.
1648         * features/arm/arm-with-vfpv3.c: Remove.
1649         * features/arm/arm-with-vfpv3.xml: Remove.
1650
1651 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1652
1653         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1654
1655 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1656
1657         * arch/aarch32.c (aarch32_create_target_description): Create
1658         target descriptions using features.
1659         * arch/arm.c (arm_create_target_description)
1660         (arm_create_mprofile_target_description): Likewise.
1661         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1662
1663 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1664
1665         * Makefile.in: Add new files.
1666         * aarch32-tdep.c: New file.
1667         * aarch32-tdep.h: New file.
1668         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1669         Call aarch32_read_description.
1670         * arch/aarch32.c: New file.
1671         * arch/aarch32.h: New file.
1672         * arch/arm.c (arm_create_target_description)
1673         (arm_create_mprofile_target_description): New function.
1674         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1675         (arm_create_target_description)
1676         (arm_create_mprofile_target_description): New declaration.
1677         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1678         read_description functions.
1679         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1680         Likewise.
1681         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1682         * arm-tdep.c (tdesc_arm_list): New variable.
1683         (arm_register_g_packet_guesses): Call create description functions.
1684         (arm_read_description) (arm_read_mprofile_description): New
1685         function.
1686         * arm-tdep.h (arm_read_description)
1687         (arm_read_mprofile_description): Add declaration.
1688         * configure.tgt: Add new files.
1689
1690 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1691
1692         * top.c (new_ui_command): Open specified terminal just once.
1693
1694 2019-07-18  Tom Tromey  <tromey@adacore.com>
1695
1696         * symtab.c (main_name): Constify return type.
1697         * symfile.c (set_initial_language): Update.
1698         * symtab.h (main_name): Constify return type.
1699
1700 2019-07-17  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-winsource.c (tui_update_source_window)
1703         (tui_update_source_window_as_is)
1704         (tui_update_source_windows_with_line): Remove return.
1705         * tui/tui-disasm.c (tui_show_disassem)
1706         (tui_show_disassem_and_update_source): Remove return.
1707         * tui/tui.c (tui_reset): Remove return.
1708         * tui/tui-wingeneral.c
1709         (tui_check_and_display_highlight_if_needed): Remove return.
1710
1711 2019-07-17  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1714
1715 2019-07-17  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-winsource.h (struct tui_exec_info_window)
1718         (struct tui_source_window_base): Move from tui-data.h.
1719         * tui/tui-winsource.c: Move many method definitions from
1720         elsewhere.  Remove "structuring" comments.
1721         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1722         (tui_source_window_base::refresh_window): Move to
1723         tui-winsource.c.
1724         * tui/tui-win.c (tui_source_window_base::refresh_all)
1725         (tui_source_window_base::update_tab_width)
1726         (tui_source_window_base::set_new_height)
1727         (tui_source_window_base::do_make_visible_with_new_height): Move to
1728         tui-winsource.c.
1729         * tui/tui-source.h: Update.
1730         * tui/tui-source.c (tui_source_window_base::reset): Move to
1731         tui-winsource.c.
1732         * tui/tui-disasm.h: Update.
1733         * tui/tui-data.h (struct tui_exec_info_window): Move to
1734         tui-winsource.h.
1735         (struct tui_source_window_base): Likewise.
1736         * tui/tui-data.c (tui_source_window_base::clear_detail)
1737         (tui_source_window_base, ~tui_source_window_base): Move to
1738         tui-winsource.c.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-win.c (tui_resize_all)
1743         (tui_source_window_base::update_tab_width)
1744         (tui_adjust_win_heights): Update.
1745         (tui_win_info::make_invisible_and_set_new_height): Rename from
1746         make_invisible_and_set_new_height.
1747         * tui/tui-data.h (struct tui_win_info)
1748         <make_invisible_and_set_new_height>: New method.
1749
1750 2019-07-17  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui.c: Update.
1753         * tui/tui-source.h (struct tui_source_window): Move from
1754         tui-data.h.
1755         * tui/tui-layout.c: Update.
1756         * tui/tui-disasm.c: Update.
1757         * tui/tui-data.h (struct tui_source_window): Move to
1758         tui-source.h.
1759
1760 2019-07-17  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1763         tui-data.h.
1764         * tui/tui-data.h (struct tui_disasm_window): Move to
1765         tui-disasm.h.
1766
1767 2019-07-17  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-regs.h (struct tui_data_item_window): Move from
1770         tui-data.h.
1771         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1772         * tui/tui-data.h (struct tui_data_item_window): Move to
1773         tui-regs.h.
1774         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1775
1776 2019-07-17  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui.c: Update.
1779         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1780         (tui_cmd_window::max_height): Move to tui-command.c.
1781         * tui/tui-layout.c: Update.
1782         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1783         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1784         tui-command.c.
1785         * tui/tui-command.h (struct tui_cmd_window): Move from
1786         tui-data.h.
1787         * tui/tui-command.c: Remove "structuring" comments.
1788         (tui_cmd_window::clear_detail)
1789         (tui_cmd_window::do_make_visible_with_new_height)
1790         (tui_cmd_window::max_height): Move from elsewhere.
1791
1792 2019-07-17  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1795         Now static.
1796         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1797         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1798
1799 2019-07-17  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui.c: Update.
1802         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1803         tui-regs.c.
1804         * tui/tui-windata.h: Remove file.
1805         * tui/tui-windata.c: Remove file.
1806         * tui/tui-win.c (tui_data_window::set_new_height)
1807         (tui_data_window::do_make_visible_with_new_height): Move to
1808         tui-regs.c.
1809         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1810         * tui/tui-regs.c: Remove "structuring" comments.
1811         (tui_data_window::first_data_item_displayed)
1812         (tui_data_window::delete_data_content_windows)
1813         (tui_data_window::erase_data_content)
1814         (tui_data_window::display_all_data)
1815         (tui_data_window::refresh_all)
1816         (tui_data_window::do_scroll_vertical)
1817         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1818         (tui_data_window::do_make_visible_with_new_height)
1819         (tui_data_window::refresh_window): Move from elsewhere.
1820         (_initialize_tui_regs): Move to end of file.
1821         * tui/tui-layout.c: Update.
1822         * tui/tui-hooks.c: Update.
1823         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1824         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1825         tui-regs.c.
1826         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1827
1828 2019-07-17  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1831         seen.
1832
1833 2019-07-17  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-win.c (tui_source_window_base::set_new_height)
1836         (tui_source_window_base::do_make_visible_with_new_height): Use
1837         m_has_locator field directly.
1838         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1839         method.
1840         (struct tui_source_window_base) <has_locator>: Likewise.
1841
1842 2019-07-17  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1845         Don't declare.
1846         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1847         Remove.
1848         * tui/tui-win.c (tui_source_window_base::set_new_height)
1849         (tui_source_window_base::set_new_height)
1850         (make_invisible_and_set_new_height)
1851         (tui_source_window_base::do_make_visible_with_new_height)
1852         (tui_source_window_base::do_make_visible_with_new_height):
1853         Update.
1854         * tui/tui-layout.c (show_source_disasm_command, show_data)
1855         (show_source_or_disasm_and_command): Update.
1856         * tui/tui-layout.c (show_layout): Update.
1857
1858 2019-07-17  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-layout.c (make_data_window): Remove.
1861         (show_data): Unify creation and re-initialization cases.
1862
1863 2019-07-17  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-layout.c (make_source_window, make_disasm_window):
1866         Remove.
1867         (show_data): Unify creation and re-initialization cases.
1868
1869 2019-07-17  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-layout.c (make_command_window): Remove.
1872         (show_source_disasm_command, show_source_or_disasm_and_command):
1873         Unify creation and re-initialization cases.
1874
1875 2019-07-17  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1878         creation and re-initialization cases.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-regs.c (tui_get_register): Return void.
1883
1884 2019-07-17  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1887         Simplify.
1888
1889 2019-07-17  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1892         resetting.
1893
1894 2019-07-17  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1897         * tui/tui-regs.c (tui_reg_layout): New function.
1898         (tui_show_registers, tui_reg_command): Use it.
1899         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1900         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1901         parameters.
1902         (tui_layout_command): Remove.
1903
1904 2019-07-17  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-layout.h (tui/tui-layout): Return void.
1907         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1908
1909 2019-07-17  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-layout.c (show_source_disasm_command, show_data):
1912         Update.
1913         (reset_locator): Remove.
1914         (show_source_or_disasm_and_command): Update.
1915
1916 2019-07-17  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-source.c (tui_source_window_base::reset): Remove
1919         win_type parameter.
1920         * tui/tui-layout.c (make_command_window, make_source_window)
1921         (make_disasm_window, make_data_window)
1922         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1923         (reset_locator, show_source_or_disasm_and_command): Update.
1924         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1925         win_type parameter.
1926         (struct tui_source_window_base) <reset>: Likewise.
1927
1928 2019-07-17  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-layout.c (show_source_disasm_command): Use
1931         reset_locator.
1932         (reset_locator): New function.
1933         (init_and_make_win): Remove.
1934         (show_source_or_disasm_and_command): Use reset_locator.
1935
1936 2019-07-17  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1939         condition.
1940         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1941         Remove condition.
1942         * tui/tui-source.c (tui_source_window_base::reset): New method.
1943         * tui/tui-layout.c (make_command_window): Don't call
1944         init_and_make_win.
1945         (make_source_window, make_disasm_window): Don't call
1946         make_source_or_disasm_window.
1947         (make_data_window): Don't call init_and_make_win.  Change calling
1948         convention.
1949         (show_source_disasm_command, show_data): Simplify.
1950         (make_source_or_disasm_window): Remove.
1951         (show_source_or_disasm_and_command): Simplify.
1952         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1953         (struct tui_source_window_base) <reset>: Likewise.
1954         <execution_info>: Remove initializer.
1955         * tui/tui-data.c (tui_source_window_base): Initialize
1956         execution_info.
1957
1958 2019-07-17  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1961         variable.
1962
1963 2019-07-17  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui.c (tui_rl_other_window): Update.
1966         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1967         superclass method first.  Always iterate over regs_content.
1968         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1969         method.
1970         * tui/tui-win.c (tui_set_focus_command): Update.
1971
1972 2019-07-17  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-win.c (tui_set_focus_command): Rename from
1975         tui_set_focus.  Call tui_enable.
1976         (tui_set_focus_command): Remove.
1977
1978 2019-07-17  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1981         refresh_window.
1982         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1983         touchwin.
1984         (tui_data_window::refresh_window): Call refresh_window on data
1985         items.  Always call superclass refresh_window.
1986         (tui_win_info::refresh): Remove.
1987         (tui_source_window_base::refresh_window): Update.
1988         (tui_refresh_all): Update.
1989         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1990         refresh_window.
1991         (show_source_or_disasm_and_command): Likewise.
1992         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1993         (struct tui_source_window_base) <refresh>: Likewise.
1994
1995 2019-07-17  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-winsource.c (tui_clear_source_content)
1998         (tui_show_source_content): Update.
1999         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2000         whether content is empty.
2001         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2002         Remove.
2003
2004 2019-07-17  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2007         window's contents.
2008         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2009         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2010
2011 2019-07-17  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2014         (struct tui_data_item_window): Update.
2015
2016 2019-07-17  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2019         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2020         defines.
2021
2022 2019-07-17  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-winsource.h (tui_erase_source_content)
2025         (tui_clear_source_content): Remove "display_prompt" parameter.
2026         * tui/tui-winsource.c (tui_update_source_window_as_is)
2027         (tui_update_source_windows_with_addr): Update.
2028         (tui_clear_source_content): Remove "display_prompt" parameter.
2029         (tui_erase_source_content): Likewise.  Simplify.
2030         (tui_show_source_content): Update.
2031         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2032         * tui/tui-stack.c (tui_show_frame_info): Update.
2033         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2034         Remove defines.
2035
2036 2019-07-17  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2039         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2040         parameter.
2041         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2042         parameter.
2043
2044 2019-07-17  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-winsource.c (tui_clear_source_content)
2047         (tui_show_source_content, tui_show_exec_info_content)
2048         (tui_clear_exec_info_content): Update.
2049         * tui/tui-stack.c (tui_show_locator_content): Update.
2050         (tui_show_frame_info): Update.
2051         * tui/tui-source.h (tui_source_window): Don't declare.
2052         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2053         from tui_source_is_displayed.
2054         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2055         Remove field.
2056         (struct tui_source_window_base) <content_in_use>: New field.  Now
2057         bool.
2058         (struct tui_source_window) <showing_source_p>: New method.
2059         (TUI_SRC_WIN): Change cast.
2060         * tui/tui-data.c (tui_initialize_static_data): Update.
2061
2062 2019-07-17  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2065         location_matches_p.
2066         * tui/tui-source.c (tui_source_window::location_matches_p): New
2067         method.
2068         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2069         method.
2070         * tui/tui-data.h (struct tui_source_window_base)
2071         <location_matches_p>: New method.
2072         (struct tui_source_window, struct tui_disasm_window)
2073         <location_matches_p>: Likewise.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-win.c (tui_set_win_height_command): Rename from
2078         tui_set_win_height.
2079         (tui_set_win_height_command): Remove.
2080
2081 2019-07-17  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-source.c (tui_source_window): New constructor.  Add
2084         observer.
2085         (~tui_source_window): New destructor.
2086         (tui_source_window::style_changed): New method.
2087         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2088         (tui_attach_detach_observers): Update.
2089         * tui/tui-data.h (struct tui_source_window): Make constructor not
2090         inline.  Add destructor.
2091         (struct tui_source_window) <style_changed>: New method.
2092         <m_observable>: New member.
2093
2094 2019-07-17  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2097         * tui/tui-win.c (tui_resize_all): Fix typo.
2098
2099 2019-07-17  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2102         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2103         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2104         * tui/tui-win.c (window_name_completer): Use foreach.
2105         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2106         (update_tab_width): Likewise.
2107         * tui/tui-layout.c (show_layout): Update.
2108         * tui/tui-data.h (class tui_window_iterator): New.
2109         (struct all_tui_windows): New.
2110         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2111
2112 2019-07-17  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2115         parameter.  Don't reference globals.
2116         (tui_reg_command): Update.
2117
2118 2019-07-17  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-regs.c (tui_show_registers): Simplify.
2121
2122 2019-07-17  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-regs.c (tui_show_registers): Update.
2125         (tui_show_register_group): Add win_info parameter.
2126
2127 2019-07-17  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2130         Rename from tui_display_reg_element_at_line.
2131         (tui_data_window::display_registers_from_line): Update.
2132         * tui/tui-data.h (struct tui_data_window)
2133         <display_reg_element_at_line>: New method.
2134
2135 2019-07-17  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-regs.h (tui_display_registers_from)
2138         (tui_display_registers_from_line): Don't declare.
2139         * tui/tui-windata.c (tui_data_window::display_all_data)
2140         (tui_data_window::refresh_all)
2141         (tui_data_window::do_scroll_vertical): Update.
2142         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2143         from tui_display_registers_from.
2144         (tui_display_reg_element_at_line): Update.
2145         (tui_data_window::display_registers_from_line): Rename from
2146         tui_display_registers_from_line.
2147         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2148         display_registers_from_line>: New methods.
2149
2150 2019-07-17  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2153         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2154         from tui_erase_data_content.
2155         (tui_data_window::display_all_data)
2156         (tui_data_window::refresh_all)
2157         (tui_data_window::do_scroll_vertical): Update.
2158         * tui/tui-regs.c (tui_show_registers): Update.
2159         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2160         New method.
2161
2162 2019-07-17  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2165         declare.
2166         * tui/tui-windata.c
2167         (tui_data_window::delete_data_content_windows): Rename from
2168         tui_delete_data_content_windows.
2169         (tui_data_window::display_all_data)
2170         (tui_data_window::do_scroll_vertical): Update.
2171         * tui/tui-data.h (struct tui_data_window)
2172         <delete_data_content_windows>: New method.
2173
2174 2019-07-17  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2177         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2178
2179 2019-07-17  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2182         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2183         from tui_display_all_data.
2184         * tui/tui-win.c
2185         (tui_data_window::do_make_visible_with_new_height): Update.
2186         * tui/tui-regs.c (tui_show_registers): Update.
2187         * tui/tui-layout.c (tui_set_layout): Update.
2188         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2189         method.
2190
2191 2019-07-17  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2194         * tui/tui-windata.c (tui_display_data_from): Remove.
2195         (tui_data_window::refresh_all): Update.
2196
2197 2019-07-17  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2200         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2201         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2202         tui_display_registers_from_line.
2203         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2204         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2205         "force_display" parameter.
2206
2207 2019-07-17  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2210         declare.
2211         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2212         Rename from tui_first_reg_element_no_inline.
2213         (tui_display_reg_element_at_line)
2214         (tui_display_registers_from_line): Update.
2215         * tui/tui-data.h (struct tui_data_window)
2216         <first_reg_element_no_inline>: New method.
2217
2218 2019-07-17  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-windata.c (tui_display_data_from)
2221         (tui_data_window::do_scroll_vertical): Update.
2222         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2223         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2224         Rename from tui_line_from_reg_element_no.
2225         (tui_display_registers_from_line): Update.
2226         * tui/tui-data.h (struct tui_data_window)
2227         <line_from_reg_element_no>: New method.
2228
2229 2019-07-17  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2232         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2233         tui_last_regs_line_no.
2234         (tui_display_reg_element_at_line)
2235         (tui_display_registers_from_line): Update.
2236         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2237         method.
2238
2239 2019-07-17  Tom Tromey  <tom@tromey.com>
2240
2241         PR tui/24722:
2242         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2243         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2244         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2245         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2246         (tui_update_breakpoint_info): Likewise.
2247         * tui/tui-hooks.c (tui_event_create_breakpoint)
2248         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2249         Update.
2250
2251 2019-07-17  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2254
2255 2019-07-17  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-winsource.c (tui_update_source_window_as_is)
2258         (tui_update_source_windows_with_addr): Update.
2259         * tui/tui-source.h (tui_set_source_content)
2260         (tui_show_symtab_source): Add "win_info" parameter.
2261         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2262         parameter.
2263         (tui_show_symtab_source): Likewise.
2264
2265 2019-07-17  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-wingeneral.c
2268         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2269
2270 2019-07-17  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2273         (struct tui_cmd_window) <can_scroll>: New method.
2274         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2275         method.
2276
2277 2019-07-17  Tom Tromey  <tromey@adacore.com>
2278
2279         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2280         do_field_signed>: Rename.  Change type of "value".
2281         * ui-out.c (ui_out::field_signed): Rename from field_int.
2282         Change type of "value".
2283         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2284         type of "value".
2285         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2286         do_field_int.  Change type of "value".
2287         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2288         do_field_int.  Change type of "value".
2289         * tracepoint.c (trace_status_mi, tfind_1)
2290         (print_one_static_tracepoint_marker): Update.
2291         * thread.c (print_thread_info_1, print_selected_thread_frame):
2292         Update.
2293         * stack.c (print_frame, print_frame_info): Update.
2294         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2295         Update.
2296         * source.c (print_source_lines_base): Update.
2297         * skip.c (info_skip_command): Update.
2298         * record-btrace.c (btrace_ui_out_decode_error)
2299         (btrace_call_history_src_line): Update.
2300         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2301         Update.
2302         * progspace.c (print_program_space): Update.
2303         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2304         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2305         do_field_int.  Change type of "value".
2306         * mi/mi-out.c (mi_ui_out::do_table_begin)
2307         (mi_ui_out::do_table_header): Update.
2308         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2309         type of "value".
2310         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2311         (mi_cmd_data_list_changed_registers, output_register)
2312         (mi_cmd_data_read_memory, mi_load_progress)
2313         (mi_cmd_trace_frame_collected): Update.
2314         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2315         Update.
2316         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2317         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2318         (mi_cmd_var_list_children, varobj_update_one): Update.
2319         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2320         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2321         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2322         * inferior.c (print_inferior): Update.
2323         * gdb_bfd.c (print_one_bfd): Update.
2324         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2325         Update.
2326         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2327         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2328         do_field_int.  Change type of "value".
2329         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2330         do_field_int.  Change type of "value".
2331         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2332         (print_one_breakpoint_location, print_it_catch_fork)
2333         (print_one_catch_fork, print_it_catch_vfork)
2334         (print_one_catch_vfork, print_it_catch_solib)
2335         (print_it_catch_exec, print_it_ranged_breakpoint)
2336         (print_mention_watchpoint, print_mention_masked_watchpoint)
2337         (bkpt_print_it, update_static_tracepoint): Update.
2338         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2339         * break-catch-syscall.c (print_it_catch_syscall): Update.
2340         * ada-tasks.c (print_ada_task_info): Update.
2341         * ada-lang.c (print_it_exception, print_mention_exception):
2342         Update.
2343
2344 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         PR breakpoints/24541
2347         * gdbarch.c: Regenerate.
2348         * gdbarch.h: Regenerate.
2349         * gdbarch.sh: Adjust return type and parameter types for
2350         'stap_adjust_register'.
2351         (i386_stap_adjust_register): Adjust signature and return new
2352         register name.
2353         * stap-probe.c (stap_parse_register_operand): Adjust use of
2354         'gdbarch_stap_adjust_register'.
2355
2356 2019-07-17  Tom Tromey  <tromey@adacore.com>
2357
2358         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2359         declare VEC.
2360         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2361         std::vector.
2362         (struct s390_process_info): Add initializers.
2363         (s390_add_process): Use new.
2364         (s390_linux_nat_target::low_forget_process): Use delete.
2365         (s390_linux_nat_target::low_new_fork)
2366         (s390_linux_nat_target::stopped_by_watchpoint)
2367         (s390_linux_nat_target::low_prepare_to_resume)
2368         (s390_linux_nat_target::insert_watchpoint)
2369         (s390_linux_nat_target::insert_hw_breakpoint)
2370         (s390_linux_nat_target::remove_watchpoint)
2371         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2372
2373 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2374
2375         * aarch64-fbsd-nat.c: Include regcache.h.
2376         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2377         argument.
2378         (aarch64_fbsd_nat_target::fetch_registers)
2379         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2380         variable.
2381         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2382
2383 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2384
2385         * fbsd-nat.c: Include gdbarch.h.
2386
2387 2019-07-15  Tom Tromey  <tromey@adacore.com>
2388
2389         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2390
2391 2019-07-15  Tom Tromey  <tromey@adacore.com>
2392
2393         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2394         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2395         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2396         * cli-out.c (cli_ui_out::do_field_int): New method.
2397         * ui-out.c (ui_out::field_unsigned): New method.
2398         * symfile.c (generic_load): Use field_unsigned.
2399         (print_transfer_performance): Likewise.
2400         * record-btrace.c (ui_out_field_uint): Remove.
2401         (btrace_call_history_insn_range, btrace_call_history): Use
2402         field_unsigned.
2403         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2404         field_unsigned.
2405         * ui-out.h (class ui_out) <field_unsigned>: New method.
2406         <do_field_unsigned>: Likewise.
2407
2408 2019-07-15  Tom Tromey  <tromey@adacore.com>
2409
2410         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2411         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2412         * target.c (flash_erase_command): Use field_string.
2413         * infrun.c (print_signal_received_reason): Use field_string.
2414         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2415         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2416         field_string.
2417         * ada-tasks.c (print_ada_task_info): Use field_string.
2418
2419 2019-07-15  Tom Tromey  <tromey@adacore.com>
2420
2421         * target.c (flash_erase_command): Use field_core_addr.
2422         * symfile.c (generic_load): Use field_core_addr.
2423         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2424         Use field_core_addr.
2425         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2426         field_core_addr.
2427
2428 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2429
2430         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2431         value if its desired type is smaller than a CORE_ADDR and signed.
2432
2433 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2434
2435         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2436         of changes to field names, and use new is_reference field to
2437         decide if a property is a reference or not.
2438         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2439         field.
2440         (struct dwarf2_property_baton): Update header comment, rename
2441         'referenced_type' to 'property_type' and update comments.
2442         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2443         default property type, store in property baton, update to take
2444         accound of renamed field.
2445         (read_func_scope): Update call to attr_to_dynamic_prop.
2446         (read_array_type): Likewise.
2447         (dwarf2_per_cu_addr_sized_int_type): New function.
2448         (read_subrange_index_type): Move type finding code to
2449         dwarf2_per_cu_addr_sized_int_type.
2450         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2451         (dwarf2_per_cu_addr_type): New function.
2452         (set_die_type): Update calls to attr_to_dynamic_prop.
2453
2454 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2455
2456         * dwarf2read.c (read_subrange_index_type): New function.
2457         (read_subrange_type): Move code into new function and call it.
2458         * gdbtypes.c (create_range_type): Add some asserts.
2459
2460 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2461
2462         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2463         update return statements.
2464         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2465         declaration, and update comment to match.
2466         * gdbtypes.c (resolve_dynamic_array): Update call to
2467         dwarf2_evaluate_property to match new return type.
2468
2469 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2470
2471         * valarith.c (value_subscripted_rvalue): Change lowerbound
2472         parameter type from int to LONGEST.
2473         * value.h (value_subscripted_rvalue): Likewise in declaration.
2474
2475 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * cli/cli-utils.c (info_print_command_completer): New function.
2478         * cli/cli-utils.h: Add 'completer.h' include, and forward
2479         declaration for 'struct cmd_list_element'.
2480         (info_print_command_completer): Declare.
2481         * stack.c (_initialize_stack): Add completer for 'info locals' and
2482         'info args'.
2483         * symtab.c (_initialize_symtab): Add completer for 'info
2484         variables' and 'info functions'.
2485         * NEWS: Mention completion for additional info commands.
2486
2487 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2488
2489         * cli/cli-utils.c (extract_info_print_args): Delete.
2490         (extract_arg_maybe_quoted): Delete.
2491         (info_print_options_defs): New variable.
2492         (make_info_print_options_def_group): New function.
2493         (extract_info_print_options): Define new function.
2494         * cli/cli-utils.h (extract_info_print_args): Delete.
2495         (struct info_print_options): New structure.
2496         (extract_info_print_options): Declare new function.
2497         * stack.c (info_locals_command): Update to use new
2498         extract_info_print_options, also add a header comment.
2499         (info_args_command): Likewise.
2500         * symtab.c (info_variables_command): Likewise.
2501         (info_functions_command): Likewise.
2502
2503 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2504
2505         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2506         to extract string arguments.
2507         * common/common-utils.c (extract_string_maybe_quoted): New function.
2508         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2509
2510 2019-07-11  Tom Tromey  <tromey@adacore.com>
2511
2512         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2513         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2514         * top.h (gdbinit): Don't declare.
2515         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2516         into...
2517         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2518         * top.c (gdb_init): Don't call init_cli_cmds.
2519         (gdbinit): Remove.
2520         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2521
2522 2019-07-11  Tom Tromey  <tromey@adacore.com>
2523
2524         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2525         after it has been moved.
2526
2527 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2528
2529         * valops.c (value_must_coerce_to_target): Change return type to
2530         bool.
2531         * value.h (value_must_coerce_to_target): Likewise.
2532
2533 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2534
2535         * breakpoint.c (is_hardware_watchpoint): Remove
2536         forward-declaration.
2537         (is_masked_watchpoint): Change return type to bool.
2538         (is_tracepoint): Likewise.
2539         (is_breakpoint): Likewise.
2540         (is_hardware_watchpoint): Likewise.
2541         (is_watchpoint): Likewise.
2542         (is_no_memory_software_watchpoint): Likewise.
2543         (is_catchpoint): Likewise.
2544         (breakpoint_1): Make FILTER parameter's return type bool.
2545         is_masked_watchpoint): Change return type to bool.
2546         (save_breakpoints): Make FILTER parameter's return type bool.
2547         * breakpoint.h (is_breakpoint): Change return type to bool.
2548         (is_watchpoint): Likewise.
2549         (is_catchpoint): Likewise.
2550         (is_tracepoint): Likewise.
2551
2552 2019-07-10  Tom Tromey  <tom@tromey.com>
2553
2554         * defs.h: Don't include gdbarch.h.
2555         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2556         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2557         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2558         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2559         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2560         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2561         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2562         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2563         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2564         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2565         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2566         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2567         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2568         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2569         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2570         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2571         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2572         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2573         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2574         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2575         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2576         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2577         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2578         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2579         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2580         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2581         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2582
2583 2019-07-10  Tom Tromey  <tromey@adacore.com>
2584
2585         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2586         * breakpoint.c (init_ada_exception_breakpoint): Register as
2587         bp_catchpoint.
2588         (print_one_breakpoint_location, print_one_breakpoint): Use
2589         is_ada_exception_catchpoint.
2590         * ada-lang.c (class ada_catchpoint_location): Pass
2591         bp_loc_software_breakpoint to bp_location constructor.
2592         (is_ada_exception_catchpoint): New function.
2593
2594 2019-07-10  Tom Tromey  <tromey@adacore.com>
2595
2596         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2597         VEC.
2598         (struct arm_exidx_entry): New method operator<.
2599         (struct arm_exidx_data) <section_maps>: Change type.
2600         (arm_exidx_data_free): Remove.
2601         (arm_exidx_data_key): Change type.  Move lower.
2602         (arm_exidx_new_objfile): Update.
2603         (arm_compare_exidx_entries): Remove.
2604         (arm_find_exidx_entry, _initialize_arm_tdep)
2605
2606 2019-07-10  Tom Tromey  <tromey@adacore.com>
2607
2608         * solib-spu.c (ocl_program_data_key): Change type.
2609         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2610         Update.
2611
2612 2019-07-10  Tom Tromey  <tromey@adacore.com>
2613
2614         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2615         (struct solib_aix_inferior_data) <library_list>: Change type.
2616         (solib_aix_inferior_data_handle): Change type.
2617         (get_solib_aix_inferior_data): Update.
2618         (solib_aix_free_library_list): Remove.
2619         (library_list_start_library): Update.
2620         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2621         return type.
2622         (solib_aix_get_library_list)
2623         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2624         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2625
2626 2019-07-10  Tom Tromey  <tromey@adacore.com>
2627
2628         * solib-dsbt.c (struct dsbt_info): Add initializers.
2629         (solib_dsbt_pspace_data): Change type.
2630         (dsbt_pspace_data_cleanup): Remove.
2631         (get_dsbt_info, _initialize_dsbt_solib): Update.
2632
2633 2019-07-10  Tom Tromey  <tromey@adacore.com>
2634
2635         * spu-tdep.c (spu_overlay_data): Change type.
2636         (spu_get_overlay_table, spu_overlay_new_objfile)
2637         (_initialize_spu_tdep): Update.
2638
2639 2019-07-10  Tom Tromey  <tromey@adacore.com>
2640
2641         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2642         destructor.
2643         (dbx_objfile_data_key): Change type and declare later.
2644         (DBX_SYMFILE_INFO): Rewrite.
2645         * dbxread.c (dbx_objfile_data_key): Change type.
2646         (dbx_symfile_init): Update.
2647         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2648         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2649         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2650
2651 2019-07-10  Tom Tromey  <tromey@adacore.com>
2652
2653         * jit.c (jit_program_space_key): Change type.  Move lower.
2654         (get_jit_program_space_data): Update.
2655         (jit_program_space_data_cleanup): Remove.
2656         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2657         Update.
2658         (struct jit_program_space_data): Add initializers.
2659
2660 2019-07-10  Tom Tromey  <tromey@adacore.com>
2661
2662         * solib-darwin.c (struct darwin_info): Add initializers.
2663         (solib_darwin_pspace_data): Change type.
2664         (darwin_pspace_data_cleanup): Remove.
2665         (get_darwin_info, _initialize_darwin_solib): Update.
2666
2667 2019-07-10  Tom Tromey  <tromey@adacore.com>
2668
2669         * remote-sim.c (struct sim_inferior_data): Add initializers,
2670         constructor, and destructor.
2671         (sim_inferior_data_key): Change type.  Move lower.
2672         (check_for_duplicate_sim_descriptor): Update.
2673         (get_sim_inferior_data): Use new.  Update.
2674         (~sim_inferior_data_cleanup): Rename from
2675         sim_inferior_data_cleanup.  Simplify.
2676         (gdbsim_close_inferior, simulator_command)
2677         (sim_command_completer, _initialize_remote_sim): Update.
2678         (next_pid, INITIAL_PID): Move earlier.
2679
2680 2019-07-10  Tom Tromey  <tromey@adacore.com>
2681
2682         * python/python-internal.h (create_thread_object): Return
2683         gdbpy_ref.
2684         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2685         * python/py-inferior.c (struct threadlist_entry): Add
2686         constructor.
2687         <thread_obj>: Now a gdbpy_ref.
2688         (thread_to_thread_object): Update.
2689         (add_thread_object): Use new.
2690         (delete_thread_object): Use delete.
2691         (infpy_threads): Update.
2692         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2693         GIL.
2694
2695 2019-07-10  Tom Tromey  <tromey@adacore.com>
2696
2697         * valops.c (value_cast): Specialize error message for Ada.
2698
2699 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2700
2701         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2702
2703 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2704
2705         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2706         bpstat_should_step): Return bool, adjust comments.
2707         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2708         bpstat_should_step): Likewise.
2709
2710 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2711
2712         * features/Makefile: Use feature target descriptions for Arm.
2713         * features/arm/arm-core.c: Generate new file.
2714         * features/arm/arm-fpa.c: Likewise.
2715         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2716         * features/arm/arm-m-profile.c: Likewise.
2717         * features/arm/arm-vfpv2.c: Likewise.
2718         * features/arm/arm-vfpv3.c: Likewise.
2719         * features/arm/xscale-iwmmxt.c: Likewise.
2720         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2721
2722 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2723
2724         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2725         ptrace earlier.
2726
2727 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2728
2729         * features/aarch64-pauth.c: Regenerate.
2730
2731 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2732
2733         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2734         bool.
2735         (bpstat_what): Use false instead of 0.
2736
2737 2019-07-09  Pedro Alves  <palves@redhat.com>
2738
2739         * break-catch-throw.c (is_exception_catchpoint): New.
2740         * breakpoint.c (print_one_breakpoint_location): New parameter
2741         'raw_loc'.  Handle it.  Use
2742         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2743         looking at the breakpoint's type.
2744         (print_one_breakpoint): If handling "maint info breakpoints", also
2745         print locations of exception catchpoints.
2746         * breakpoint.h (is_exception_catchpoint): Declare.
2747
2748 2019-07-09  Pedro Alves  <palves@redhat.com>
2749
2750         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2751         "addr" field.
2752         (allocate_location_exception_catchpoint): New.
2753         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2754         (initialize_throw_catchpoint_ops): Install
2755         allocate_location_exception_catchpoint as allocate_location
2756         method.
2757         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2758         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2759         bp_loc_other.
2760         (breakpoint_address_is_meaningful): Delete.
2761         (bl_address_is_meaningful): New.
2762         (breakpoint_locations_match): Adjust comment.
2763         (bp_location_from_bp_type): New, factored out of...
2764         (bp_location::bp_location(breakpoint *)): ... this.
2765         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2766         factored out of...
2767         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2768         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2769         breakpoint_address_is_meaningful.
2770         (bp_locations_compare): Adjust comment.
2771         (update_global_location_list): Use bl_address_is_meaningful
2772         instead of breakpoint_address_is_meaningful.
2773         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2774         explicit.
2775         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2776         * python/py-breakpoint.c (bppy_get_location): No longer check
2777         whether location is null.
2778
2779 2019-07-09  Pedro Alves  <palves@redhat.com>
2780
2781         PR c++/15468
2782         * breakpoint.c (print_one_breakpoint_location): Remove
2783         single-location assert.
2784
2785 2019-07-09  Tom Tromey  <tom@tromey.com>
2786
2787         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2788         * configure: Rebuild.
2789         * configure.ac: Change common to gdbsupport.
2790         * gdbsupport: Rename from common.
2791         * acinclude.m4: Change common to gdbsupport.
2792         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2793         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2794         gdbsupport.
2795         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2796         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2797         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2798         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2799         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2800         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2801         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2802         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2803         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2804         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2805         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2806         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2807         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2808         coff-pe-read.c, command.h, compile/compile-c-support.c,
2809         compile/compile-c.h, compile/compile-cplus-symbols.c,
2810         compile/compile-cplus-types.c, compile/compile-cplus.h,
2811         compile/compile-loc2c.c, compile/compile.c, completer.c,
2812         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2813         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2814         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2815         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2816         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2817         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2818         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2819         features/aarch64-core.c, features/aarch64-fpu.c,
2820         features/aarch64-pauth.c, features/aarch64-sve.c,
2821         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2822         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2823         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2824         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2825         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2826         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2827         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2828         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2829         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2830         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2831         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2832         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2833         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2834         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2835         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2836         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2837         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2838         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2839         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2840         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2841         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2842         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2843         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2844         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2845         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2846         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2847         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2848         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2849         minsyms.c, mips-linux-tdep.c, namespace.h,
2850         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2851         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2852         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2853         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2854         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2855         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2856         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2857         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2858         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2859         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2860         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2861         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2862         procfs.c, producer.c, progspace.h, psymtab.h,
2863         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2864         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2865         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2866         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2867         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2868         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2869         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2870         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2871         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2872         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2873         target-memory.c, target.c, target.h, target/waitstatus.c,
2874         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2875         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2876         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2877         unittests/array-view-selftests.c,
2878         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2879         unittests/common-utils-selftests.c,
2880         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2881         unittests/format_pieces-selftests.c,
2882         unittests/function-view-selftests.c,
2883         unittests/lookup_name_info-selftests.c,
2884         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2885         unittests/mkdir-recursive-selftests.c,
2886         unittests/observable-selftests.c,
2887         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2888         unittests/parse-connection-spec-selftests.c,
2889         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2890         unittests/scoped_fd-selftests.c,
2891         unittests/scoped_mmap-selftests.c,
2892         unittests/scoped_restore-selftests.c,
2893         unittests/string_view-selftests.c, unittests/style-selftests.c,
2894         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2895         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2896         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2897         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2898         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2899         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2900
2901 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2904         bool value.
2905         (decode_digits_ordinary): Set explicit_line field in sal.
2906         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2907         symtab_and_line that was set on an explicit line number in
2908         assembler code.  Do always update the recorded symtab and line if
2909         we do skip the prologue.
2910
2911 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * breakpoint.c (set_breakpoint_location_function): Remove
2914         explicit_loc parameter.
2915         (momentary_breakpoint_from_master): Update call to
2916         set_breakpoint_location_function.
2917         (add_location_to_breakpoint): Likewise.
2918
2919 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2920
2921         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2922         required features based on default bfd type when no specific bfd
2923         is present.
2924
2925 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2926
2927         * NEWS: Mention that GDB printf and eval commands can now print
2928         C-style and Ada-style convenience var strings without
2929         calling the inferior.
2930         * printcmd.c (printf_c_string): Locally print GDB internal var
2931         instead of transiting via the inferior.
2932         (printf_wide_c_string): Likewise.
2933
2934 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2935
2936         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2937
2938 2019-07-04  Tom Tromey  <tom@tromey.com>
2939
2940         PR tui/24724:
2941         * tui/tui-winsource.c (tui_clear_source_content): Update.
2942         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2943         (tui_update_breakpoint_info): Update.
2944         (tui_set_exec_info_content): Update.
2945         * tui/tui-source.c (tui_set_source_content_nil): Update.
2946         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2947         has_break.
2948         * tui/tui-data.h (enum tui_bp_flag): New.
2949         (tui_bp_flags): New enum flags type.
2950         (struct tui_source_element) <break_mode>: Change type.  Rename
2951         from has_break.
2952         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2953         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2954         constants.
2955         * tui/tui-winsource.h: Fix comment.
2956
2957 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2958
2959         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2960         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2961         (store_fpregs_to_thread)
2962         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2963         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2964         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2965         (IWMMXT_REGS_SIZE): Add define.
2966         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2967         (fetch_vfp_regs, store_vfp_regs)
2968         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2969         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2970
2971 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2972
2973         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2974         defines.
2975         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2976         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2977         (ARM_INT_REGISTER_SIZE): ...to this.
2978         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2979         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2980         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2981         (arm_linux_collect_gregset, supply_nwfpe_register)
2982         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2983         defines.
2984         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2985         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2986         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2987         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2988         (arm_return_in_memory, arm_store_return_value)
2989         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2990         (arm_record_ld_st_multiple): Likewise.
2991         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2992         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2993
2994 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2995
2996         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2997         AARCH64_DISPLACED_MODIFIED_INSNS.
2998         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2999         (aarch64_displaced_step_copy_insn): Likewise.
3000         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3001         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3002         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3003         ARM_DISPLACED_MODIFIED_INSNS.
3004         * arm-tdep.c (arm_gdbarch_init): Likewise.
3005         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3006         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3007         (struct arm_displaced_step_closure): Use
3008         ARM_DISPLACED_MODIFIED_INSNS.
3009
3010 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3011
3012         * features/Makefile: Remove unused xml files.
3013         * features/aarch64.xml: Remove.
3014         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3015         * features/i386/amd64-avx-avx512.xml: Remove.
3016         * features/i386/amd64-avx-linux.xml: Remove.
3017         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3018         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3019         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3020         * features/i386/amd64-avx-mpx.xml: Remove.
3021         * features/i386/amd64-avx.xml: Remove.
3022         * features/i386/amd64-linux.xml: Remove.
3023         * features/i386/amd64-mpx-linux.xml: Remove.
3024         * features/i386/amd64-mpx.xml: Remove.
3025         * features/i386/amd64.xml: Remove.
3026         * features/i386/i386-avx-avx512-linux.xml: Remove.
3027         * features/i386/i386-avx-avx512.xml: Remove.
3028         * features/i386/i386-avx-linux.xml: Remove.
3029         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3030         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3031         * features/i386/i386-avx-mpx-linux.xml: Remove.
3032         * features/i386/i386-avx-mpx.xml: Remove.
3033         * features/i386/i386-avx.xml: Remove.
3034         * features/i386/i386-linux.xml: Remove.
3035         * features/i386/i386-mmx-linux.xml: Remove.
3036         * features/i386/i386-mmx.xml: Remove.
3037         * features/i386/i386-mpx-linux.xml: Remove.
3038         * features/i386/i386-mpx.xml: Remove.
3039         * features/i386/i386.xml: Remove.
3040         * features/i386/x32-avx-avx512-linux.xml: Remove.
3041         * features/i386/x32-avx-linux.xml: Remove.
3042         * features/i386/x32-linux.xml: Remove.
3043
3044 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3045
3046         * regformats/aarch64.dat: Remove.
3047         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3048         * regformats/i386/amd64-avx-linux.dat: Remove.
3049         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3050         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3051         * regformats/i386/amd64-linux.dat: Remove.
3052         * regformats/i386/amd64-mpx-linux.dat: Remove.
3053         * regformats/i386/amd64.dat: Remove.
3054         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3055         * regformats/i386/i386-avx-linux.dat: Remove.
3056         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3057         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3058         * regformats/i386/i386-linux.dat: Remove.
3059         * regformats/i386/i386-mmx-linux.dat: Remove.
3060         * regformats/i386/i386-mpx-linux.dat: Remove.
3061         * regformats/i386/i386.dat: Remove.
3062         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3063         * regformats/i386/x32-avx-linux.dat: Remove.
3064         * regformats/i386/x32-linux.dat: Remove.
3065
3066 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3067
3068         * aarch64-tdep.c: Remove xml self tests.
3069         * amd64-linux-tdep.c: Likewise.
3070         * amd64-tdep.c: Likewise.
3071         * i386-linux-tdep.c: Likewise.
3072         * i386-tdep.c: Likewise.
3073
3074 2019-07-03  Pedro Alves  <palves@redhat.com>
3075
3076         PR cli/24732
3077         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3078         (pipe_cmd_option_defs): New.
3079         (make_pipe_cmd_options_def_group): New.
3080         (pipe_command): Use gdb::option::process_options.
3081         (pipe_command_completer): New function.
3082         (_initialize_cli_cmds): Install completer for "pipe" command.
3083
3084 2019-07-03  Pedro Alves  <palves@redhat.com>
3085
3086         * cli/cli-option.c (union option_value) <string>: New field.
3087         (struct option_def_and_value): Add ctor, move ctor, dtor and
3088         use DISABLE_COPY_AND_ASSIGN.
3089         (option_def_and_value::clear_value): New.
3090         (parse_option, save_option_value_in_ctx, get_val_type_str)
3091         (add_setshow_cmds_for_options): Handle var_string.
3092         * cli-option.h (union option_def::var_address) <string>: New
3093         field.
3094         (struct string_option_def): New.
3095         * maint-test-options.c (struct test_options_opts): Add default
3096         ctor and use DISABLE_COPY_AND_ASSIGN.
3097         <string_opt>: New field.
3098         (test_options_opts::~test_options_opts): New.
3099         (test_options_opts::dump): Also dump "-string".
3100         (test_options_option_defs): Install "string.
3101
3102 2019-07-03  Pedro Alves  <palves@redhat.com>
3103
3104         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3105         option_value with a null enumeration.
3106         (complete_options): Save the option values in the context.
3107         (save_option_value_in_ctx): New, factored out from ...
3108         (process_options): ... here.
3109         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3110         of the function.
3111         * maint-test-options.c (test_options_opts::dump): New, factored
3112         out from ...
3113         (maintenance_test_options_command_mode): ... here.
3114         (maintenance_test_options_command_completion_result): Delete.
3115         (maintenance_test_options_command_completion_text): Update
3116         comment.
3117         (maintenance_show_test_options_completion_result): Change
3118         prototype.  Just print
3119         maintenance_test_options_command_completion_text.
3120         (save_completion_result): New.
3121         (maintenance_test_options_completer_mode): Pass options context to
3122         complete_options, and then save a dump.
3123         (_initialize_maint_test_options): Use add_cmd to install "maint
3124         show test-options-completion-result".
3125
3126 2019-07-03  Pedro Alves  <palves@redhat.com>
3127
3128         * NEWS (New commands): Mention "with" and "maint with".
3129         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3130         (with_command, with_command_completer): New.
3131         (pipe_command): Adjust to new repeat_previous
3132         interface.
3133         (_initialize_cli_cmds): Install the "with" command and its "w"
3134         alias.
3135         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3136         declarations.
3137         * cli/cli-setshow.c (parse_cli_var_uinteger)
3138         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3139         argument strings for all var_types.
3140         (get_setshow_command_value_string): New, factored out from ...
3141         (do_show_command): ... this.
3142         * cli/cli-setshow.h: Include <string>.
3143         (get_setshow_command_value_string): Declare.
3144         * command.h (repeat_previous): Now returns const char *.  Adjust
3145         comment.
3146         * maint.c: Include "cli/cli-cmds.h".
3147         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3148         (_initialize_maint_cmds): Register the "maintenance with" command.
3149         * top.c (repeat_previous): Move bits from pipe_command here:
3150         Return the saved command line, if any; error out if there's no
3151         command to relaunch.
3152
3153 2019-07-03  Pedro Alves  <palves@redhat.com>
3154
3155         * NEWS (New commands): Mention "maint set/show test-settings"
3156         instead of "maint test-settings".
3157         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3158         (maintenance_test_settings_set_list): Rename to ...
3159         (maintenance_set_test_settings_list): ... this.
3160         (maintenance_test_settings_show_list): Rename to  ...
3161         (maintenance_show_test_settings_list): ... this.
3162         (maintenance_test_settings_cmd): Delete.
3163         (maintenance_test_settings_set_cmd): ...
3164         (maintenance_set_test_settings_cmd): ... this.
3165         (maintenance_test_settings_show_cmd): ...
3166         (maintenance_show_test_settings_cmd): ... this.
3167         (maintenance_test_settings_show_value_cmd):
3168         (maintenance_show_test_settings_value_cmd): ... this.
3169         (_initialize_maint_test_settings): No longer install the "maint
3170         test-settings" prefix command.  Rename "maint test-settings set"
3171         to "maint set test-settings", and "maint test-settings show" to
3172         "maint show test-settings".  Adjust all subcommands.
3173
3174 2019-07-03  Pedro Alves  <palves@redhat.com>
3175
3176         * maint-test-settings.c: Fix file's intro comment.  Replace all
3177         references to "test-options" with references to "test-settings",
3178         in comments.
3179
3180 2019-07-03  Pedro Alves  <palves@redhat.com>
3181
3182         * maint-test-settings.c (maintenance_test_settings_xxx)
3183         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3184         New.
3185         (maintenance_test_settings_enums): Use them.
3186         (maintenance_test_settings_enum): Default to
3187         maintenance_test_settings_xxx.
3188         (_initialize_maint_test_settings): Initialize
3189         MAINTENANCE_TEST_SETTINGS_FILENAME.
3190
3191 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3192
3193         * breakpoint.h (remove_breakpoints_inf): Change return type to
3194         void, move function documentation here.
3195         * breakpoint.c (remove_breakpoints_inf): Change return type to
3196         void, move function documentation to header.
3197
3198 2019-07-02  Pedro Alves  <palves@redhat.com>
3199
3200         * NEWS (Completion improvements): Mention "info threads".
3201         * thread.c (struct info_threads_opts, info_threads_option_defs)
3202         (make_info_threads_options_def_group): New.
3203         (info_threads_command): Use gdb::option::process_options.
3204         (info_threads_command_completer): New.
3205         (_initialize_thread): Use gdb::option::build_help to build the
3206         help text for "info threads".
3207
3208 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3209
3210         * defs.h (generic_load): Move from here...
3211         * symfile.h (generic_load): ... to here.  Rename name parameter
3212         to args.
3213         * symfile.c (generic_load): Add comment.
3214
3215 2019-07-01  Tom Tromey  <tromey@adacore.com>
3216
3217         * dwarf2read.c
3218         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3219         declaration of without_params.  Fix formatting.
3220
3221 2019-07-01  Tom Tromey  <tromey@adacore.com>
3222
3223         * ada-exp.y (find_primitive_type): Update.
3224         * ada-lang.h (ada_lookup_symbol): Update.
3225         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3226         parameter.
3227         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3228
3229 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3230
3231         PR breakpoints/24541
3232         * gdbarch.c: Regenerate.
3233         * gdbarch.h: Regenerate.
3234         * gdbarch.sh: Add 'stap_adjust_register'.
3235         * i386-tdep.c: Include '<unordered_set>'.
3236         (i386_stap_adjust_register): New function.
3237         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3238         * stap-probe.c (stap_parse_register_operand): Call
3239         'gdbarch_stap_adjust_register'.
3240
3241 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3242
3243         PR python/24742
3244         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3245         * python/python.c (do_start_initialization): Use 'xmalloc'
3246         instead of 'PyMem_Malloc'.
3247
3248 2019-06-28  Tom Tromey  <tromey@adacore.com>
3249
3250         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3251         for Ada.
3252
3253 2019-06-27  Tom Tromey  <tromey@adacore.com>
3254
3255         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3256         objfile_key.
3257         (arm_find_mapping_symbol, arm_record_special_symbol)
3258         (_initialize_arm_tdep): Update.
3259         (arm_objfile_data_free): Remove.
3260
3261 2019-06-27  Tom Tromey  <tromey@adacore.com>
3262
3263         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3264         to cp_print_static_field.
3265
3266 2019-06-26  Tom Tromey  <tromey@adacore.com>
3267
3268         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3269         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3270         declare.
3271
3272 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3273
3274         * features/aarch64-core.c (create_feature_aarch64_core):
3275         Regenerate.
3276         * features/aarch64-core.xml: Add cpsr flags.
3277
3278 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3279
3280         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3281         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3282
3283 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3284
3285         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3286         field.
3287         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3288         use.
3289         (arm_record_special_symbol): Don't insert new symbol in sorted
3290         position, push it at the end.
3291
3292 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3293
3294         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3295         (arm_mapping_symbol_s): Remove.
3296         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3297         (arm_mapping_symbol_vec): New typedef.
3298         (struct arm_per_objfile): Add constructor.
3299         <section_maps>: Change type to
3300         std::unique_ptr<arm_mapping_symbol_vec[]>.
3301         (arm_compare_mapping_symbols): Remove.
3302         (arm_find_mapping_symbol): Adjust to section_maps type change.
3303         (arm_objfile_data_free): Call delete on arm_per_objfile.
3304         (arm_record_special_symbol): Adjust to section_maps type change.
3305         Allocate arm_per_objfile with new.
3306
3307 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3308
3309         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3310         with the command prefix.
3311
3312 2019-06-25  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3315         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3316
3317 2019-06-25  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3320         type.
3321         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3322         protected.
3323
3324 2019-06-25  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui-winsource.c
3327         (tui_source_window_base::set_is_exec_point_at): Add check against
3328         LOA_ADDRESS.
3329
3330 2019-06-25  Tom Tromey  <tom@tromey.com>
3331
3332         * tui/tui-source.c (tui_set_source_content): Don't check before
3333         xfree.
3334         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3335
3336 2019-06-25  Tom Tromey  <tom@tromey.com>
3337
3338         * tui/tui-winsource.h (tui_update_source_window_as_is)
3339         (tui_alloc_source_buffer, tui_line_is_displayed)
3340         (tui_addr_is_displayed): Change type of win_info.
3341         * tui/tui-winsource.c (tui_update_source_window_as_is)
3342         (tui_clear_source_content, tui_show_source_line)
3343         (tui_show_source_content, tui_source_window_base::refill)
3344         (tui_source_window_base::set_is_exec_point_at)
3345         (tui_source_window_base::set_is_exec_point_at)
3346         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3347         (tui_alloc_source_buffer, tui_line_is_displayed)
3348         (tui_addr_is_displayed): Change type of win_info.  Update.
3349         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3350         (tui_source_window_base::do_make_visible_with_new_height):
3351         Update.
3352         * tui/tui-source.c (tui_set_source_content)
3353         (tui_set_source_content_nil)
3354         (tui_source_window::do_scroll_vertical): Update.
3355         * tui/tui-layout.c (show_layout): Update.
3356         * tui/tui-disasm.c (tui_set_disassem_content)
3357         (tui_disasm_window::do_scroll_vertical): Update.
3358         * tui/tui-data.h (tui_win_content): Remove.
3359         (struct tui_gen_win_info) <content, content_size>: Remove.
3360         (struct tui_source_element): Add initializers and destructor.
3361         (union tui_which_element, struct tui_win_element): Remove.
3362         (struct tui_source_window_base) <content>: New field.
3363         (struct tui_data_window): Remove destructor.
3364         (tui_alloc_content, tui_free_win_content)
3365         (tui_free_all_source_wins_content): Don't declare.
3366         * tui/tui-data.c (tui_initialize_static_data): Update.
3367         (init_content_element, tui_alloc_content): Remove.
3368         (~tui_gen_win_info): Update.
3369         (~tui_data_window, tui_free_all_source_wins_content)
3370         (tui_free_win_content, free_content, free_content_elements):
3371         Remove.
3372
3373 2019-06-25  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-winsource.h (tui_clear_source_content)
3376         (tui_erase_source_content, tui_show_source_content): Change type
3377         of win_info.
3378         * tui/tui-winsource.c (tui_clear_source_content)
3379         (tui_erase_source_content, tui_show_source_content): Change type
3380         of win_info.
3381         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3382         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3383         win_info.
3384         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3385         win_info.
3386         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3387
3388 2019-06-25  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-winsource.c (tui_clear_source_content)
3391         (tui_source_window_base::set_is_exec_point_at): Update.
3392         * tui/tui-source.c (tui_set_source_content_nil): Update.
3393         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3394         a bool.
3395         * tui/tui-data.c (init_content_element): Update.
3396
3397 2019-06-25  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3400         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3401         * tui/tui-layout.c (init_and_make_win): Update.
3402         * tui/tui.h (enum tui_win_type): Update.
3403         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3404         tui_win_is_auxillary.
3405         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3406         tui_win_is_auxillary.
3407
3408 2019-06-25  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3411         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3412         (tui_delete_data_content_windows, tui_display_all_data)
3413         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3414         Update.
3415         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3416         * tui/tui-regs.c (tui_last_regs_line_no)
3417         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3418         (tui_show_registers): Update.
3419         (tui_show_register_group): Return void.  Update.
3420         (tui_display_registers_from, tui_display_reg_element_at_line)
3421         (tui_display_registers_from_line, tui_check_register_values):
3422         Update.
3423         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3424         member.
3425         (struct tui_data_window) <regs_content>: Now a std::vector.
3426         <regs_content_count>: Remove.
3427         (tui_add_content_elements, tui_free_data_content): Don't declare.
3428         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3429         (init_content_element): Remove DATA_WIN case.  Add assert.
3430         (tui_add_content_elements): Remove.
3431         (tui_data_window): Update.
3432         (tui_free_data_content): Remove.
3433         (free_content_elements): Remove DATA_WIN case.
3434
3435 2019-06-25  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui-data.c (tui_data_item_window): Update.
3438         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3439         * tui/tui-windata.c (tui_display_all_data)
3440         (tui_display_data_from_line): Update.
3441         (tui_check_data_values): Remove.
3442         * tui/tui-regs.c (tui_show_register_group)
3443         (tui_display_reg_element_at_line): Update.
3444         * tui/tui-hooks.c (tui_register_changed)
3445         (tui_refresh_frame_and_register_information): Call
3446         tui_check_register_values.
3447         * tui/tui-data.h (struct tui_data_window) <data_content,
3448         data_content_count, data_type>: Remove.
3449         (enum tui_data_type): Remove.
3450
3451         * tui/tui-data.c (tui_data_window::clear_detail)
3452         (~tui_data_window): Update.
3453
3454 2019-06-25  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3457         declare.
3458         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3459         Rename from tui_first_data_item_displayed.  Update.
3460         (tui_data_window::refresh_all)
3461         (tui_data_window::do_scroll_vertical): Update.
3462         * tui/tui-data.h (struct tui_data_window)
3463         <first_data_item_displayed>: Declare new method.
3464
3465 2019-06-25  Tom Tromey  <tom@tromey.com>
3466
3467         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3468         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3469         contents...
3470         (tui_initialize_static_data): ...here.
3471
3472 2019-06-25  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3475         (tui_display_registers_from, tui_check_register_values): Update.
3476         (tui_display_register): Remove win_info parameter; update.
3477         (tui_get_register): Change type of parameters.
3478         * tui/tui-data.h (struct tui_data_element): Remove.
3479         (union tui_which_element) <data>: Remove.
3480         <data_window>: Change type.
3481         (struct tui_data_item_window): New.
3482         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3483         case.  Add assert.
3484         (~tui_data_item_window): New destructor.
3485         (free_content_elements): Remove DATA_ITEM_WIN case.
3486
3487 2019-06-25  Tom Tromey  <tom@tromey.com>
3488
3489         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3490         Remove.
3491
3492 2019-06-25  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-data.h (struct tui_command_element): Remove.
3495         (union tui_which_element) <command>: Remove.
3496         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3497         assert.
3498         (free_content_elements): Remove CMD_WIN case.
3499
3500 2019-06-25  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-layout.c (tui_set_layout): Update.
3503         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3504         * tui/tui-data.c (layout_def): Update.
3505
3506 2019-06-25  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3509         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3510         (tui_source_window_base::set_new_height): Update.
3511         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3512         Update.
3513         (tui_set_locator_fullname, tui_set_locator_info)
3514         (tui_show_frame_info): Update.
3515         * tui/tui-source.c (tui_set_source_content)
3516         (tui_source_is_displayed): Update.
3517         * tui/tui-layout.c (show_source_disasm_command, show_data)
3518         (show_source_or_disasm_and_command): Update.
3519         * tui/tui-disasm.c (tui_set_disassem_content)
3520         (tui_get_begin_asm_address): Update.
3521         * tui/tui-data.h (struct tui_locator_element): Remove.
3522         (union tui_which_element) <locator>: Remove.
3523         (struct tui_locator_window): New.
3524         (tui_locator_win_info_ptr): Change return type.
3525         * tui/tui-data.c (_locator): Change type.
3526         (tui_locator_win_info_ptr): Change return type.
3527         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3528         (tui_alloc_content): Add assert.
3529
3530 2019-06-25  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-winsource.c
3533         (tui_exec_info_window::maybe_allocate_content): New method.
3534         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3535         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3536         (make_source_or_disasm_window): Add cast.
3537         * tui/tui-data.h (union tui_which_element) <simple_string>:
3538         Remove.
3539         (struct tui_source_info): New.
3540         (struct tui_source_window_base) <execution_info>: Change type.
3541         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3542         case, and add assert.
3543         (tui_alloc_content): Add assert.
3544
3545 2019-06-25  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3548         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3549         * tui/tui-data.c (tui_alloc_win_info): Remove.
3550
3551 2019-06-25  Tom Tromey  <tom@tromey.com>
3552
3553         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3554         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3555         can_highlight.
3556
3557 2019-06-25  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3560         make_visible_with_new_height method.
3561         (tui_win_info::make_visible_with_new_height): New method.
3562         (tui_source_window_base::do_make_visible_with_new_height)
3563         (tui_data_window::do_make_visible_with_new_height)
3564         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3565         (make_visible_with_new_height): Remove.
3566         (tui_resize_all, tui_adjust_win_heights): Use
3567         make_visible_with_new_height method.
3568         * tui/tui-data.h (struct tui_win_info)
3569         <do_make_visible_with_new_height, make_visible_with_new_height>:
3570         New methods.
3571         (struct tui_source_window_base, struct tui_data_window)
3572         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3573         methods.
3574
3575 2019-06-25  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3578         method.
3579         (update_tab_width): Call update_tab_width method.
3580         * tui/tui-data.h (struct tui_win_info)
3581         (struct tui_source_window_base) <update_tab_width>: New methods.
3582
3583 2019-06-25  Tom Tromey  <tom@tromey.com>
3584
3585         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3586         parameter.
3587         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3588         parameter.
3589         (tui_gen_win_info::make_visible): Update.
3590         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3591         parameter.
3592         * tui/tui-data.h (enum tui_box): New enum.
3593         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3594
3595 2019-06-25  Tom Tromey  <tom@tromey.com>
3596
3597         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3598         init_and_make_win for EXEC_INFO_WIN.
3599         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3600         longer inline.
3601         (struct tui_win_info) <~tui_win_info>: Inline.
3602         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3603         Don't declare.
3604         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3605         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3606         Remove.
3607         (tui_initialize_static_data): Update.
3608         (~tui_gen_win_info): Handle more cleanup here.
3609         (~tui_source_window_base): Delete "execution_info".
3610         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3611
3612 2019-06-25  Tom Tromey  <tom@tromey.com>
3613
3614         * tui/tui-layout.c (make_command_window): Don't set
3615         can_highlight.
3616         (show_source_disasm_command): Call the reset method.
3617         (show_data): Don't set can_highlight.  Call the reset method.
3618         (tui_gen_win_info::reset): Rename from init_gen_win_info
3619         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3620         (show_source_or_disasm_and_command): Call the reset method.
3621         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3622         (struct tui_cmd_window): Set can_highlight.
3623
3624 2019-06-25  Tom Tromey  <tom@tromey.com>
3625
3626         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3627         from make_visible.
3628         (tui_make_visible, tui_make_invisible): Rewrite.
3629         (tui_win_info::make_visible): Remove.
3630         (tui_source_window_base::make_visible): Update.
3631         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3632         method.  Moved from...
3633         (struct tui_win_info) <make_visible>: ...here.
3634
3635 2019-06-25  Tom Tromey  <tom@tromey.com>
3636
3637         * tui/tui-winsource.c
3638         (tui_source_window_base::do_scroll_horizontal): Remove direction
3639         parameter.
3640         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3641         direction parameter.
3642         * tui/tui-win.c (tui_win_info::forward_scroll)
3643         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3644         (tui_win_info::right_scroll): Update.
3645         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3646         direction parameter.
3647         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3648         direction parameter.
3649         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3650         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3651         Remove direction parameter.
3652         (struct tui_source_window_base, struct tui_source_window)
3653         (struct tui_disasm_window, struct tui_data_window)
3654         (struct tui_cmd_window): Update.
3655
3656 2019-06-25  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-winsource.h (tui_set_exec_info_content)
3659         (tui_show_exec_info_content, tui_erase_exec_info_content)
3660         (tui_clear_exec_info_content, tui_update_exec_info): Change
3661         argument to tui_source_window_base.
3662         * tui/tui-winsource.c (tui_set_exec_info_content)
3663         (tui_show_exec_info_content, tui_erase_exec_info_content)
3664         (tui_clear_exec_info_content, tui_update_exec_info): Change
3665         argument to tui_source_window_base.
3666
3667 2019-06-25  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3670         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3671
3672 2019-06-25  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3675         check.
3676
3677 2019-06-25  Tom Tromey  <tom@tromey.com>
3678
3679         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3680         type to void.
3681         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3682         type to void.
3683         * tui/tui-source.c (tui_set_source_content): Update.
3684         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3685
3686 2019-06-25  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-win.c (window_name_completer, tui_set_focus)
3689         (tui_all_windows_info): Use name method.
3690         * tui/tui-data.h (struct tui_gen_win_info)
3691         (struct tui_source_window, struct tui_disasm_window)
3692         (struct tui_data_window, struct tui_cmd_window) <name>: New
3693         method.
3694         (tui_win_name): Don't declare.
3695         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3696         (tui_win_name): Remove.
3697
3698 2019-06-25  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-winsource.h (tui_update_source_window)
3701         (tui_update_source_window_as_is): Change parameter type.
3702         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3703         to be a tui_source_window_base.
3704         (tui_update_source_window_as_is): Likewise.
3705         * tui/tui-win.c (make_visible_with_new_height): Update.
3706
3707 2019-06-25  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-winsource.c (tui_erase_source_content)
3710         (tui_show_source_content, tui_show_exec_info_content)
3711         (tui_erase_exec_info_content): Use refresh_window method.
3712         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3713         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3714         from tui_refresh_win.
3715         (tui_data_window::refresh_window): New method.
3716         (tui_win_info::refresh, tui_source_window_base::refresh)
3717         (tui_refresh_all): Use refresh_window method.
3718         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3719         method.
3720         * tui/tui-regs.c (tui_display_register): Call refresh_window
3721         method.
3722         * tui/tui-layout.c (show_source_disasm_command)
3723         (show_source_or_disasm_and_command): Call refresh_window method.
3724         * tui/tui-data.h (struct tui_gen_win_info)
3725         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3726         New method.
3727
3728 2019-06-25  Tom Tromey  <tom@tromey.com>
3729
3730         * tui/tui.c (tui_rl_other_window, tui_enable)
3731         (tui_is_window_visible, tui_get_command_dimension): Update.
3732         * tui/tui-winsource.c (tui_update_source_window_as_is)
3733         (tui_clear_source_content, tui_erase_source_content)
3734         (tui_show_source_line, tui_source_window_base::refill)
3735         (tui_source_window_base::do_scroll_horizontal)
3736         (tui_source_window_base::set_is_exec_point_at)
3737         (tui_update_breakpoint_info, tui_set_exec_info_content)
3738         (tui_alloc_source_buffer, tui_line_is_displayed)
3739         (tui_addr_is_displayed): Update.
3740         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3741         (tui_check_and_display_highlight_if_needed)
3742         (tui_win_info::make_visible, tui_win_info::refresh)
3743         (tui_refresh_all): Update.
3744         * tui/tui-windata.c (tui_first_data_item_displayed)
3745         (tui_delete_data_content_windows, tui_erase_data_content)
3746         (tui_display_all_data, tui_data_window::refresh_all)
3747         (tui_check_data_values): Update.
3748         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3749         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3750         (tui_win_info::backward_scroll, tui_refresh_all_win)
3751         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3752         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3753         (tui_source_window_base::set_new_height)
3754         (tui_data_window::set_new_height)
3755         (make_invisible_and_set_new_height)
3756         (make_visible_with_new_height, new_height_ok)
3757         (parse_scrolling_args): Update.
3758         * tui/tui-stack.c (tui_show_frame_info): Update.
3759         * tui/tui-source.c (tui_set_source_content)
3760         (tui_set_source_content_nil, tui_source_is_displayed)
3761         (tui_source_window::do_scroll_vertical): Update.
3762         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3763         (tui_display_registers_from, tui_display_reg_element_at_line)
3764         (tui_check_register_values, tui_reg_command): Update.
3765         * tui/tui-layout.c (tui_default_win_height)
3766         (show_source_disasm_command, show_data, init_and_make_win)
3767         (show_source_or_disasm_and_command): Update.
3768         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3769         (tui_redisplay_readline, tui_mld_flush)
3770         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3771         (tui_getc): Update.
3772         * tui/tui-disasm.c (tui_set_disassem_content)
3773         (tui_disasm_window::do_scroll_vertical): Update.
3774         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3775         Now virtual.
3776         (struct tui_win_info): Derive from tui_gen_win_info.
3777         <~tui_win_info>: Mark as override.
3778         <generic>: Remove member.
3779         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3780         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3781         (~tui_data_window, ~tui_win_info)
3782         (tui_free_all_source_wins_content): Update.
3783         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3784
3785 2019-06-25  Tom Tromey  <tom@tromey.com>
3786
3787         * tui/tui-layout.c (init_and_make_win): Use new.
3788         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3789         destructor, initializers.
3790         (tui_alloc_generic_win_info): Don't declare.
3791         * tui/tui-data.c (_locator): Add argument to constructor.
3792         (source_win, disasm_win): New globals.
3793         (exec_info): Remove.
3794         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3795         Update.
3796         (tui_alloc_generic_win_info): Remove.
3797         (init_content_element): Use new.
3798         (tui_win_info::tui_win_info): Update.
3799         (free_content_elements) <case DATA_WIN>: Use delete.
3800
3801 2019-06-25  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3804         * tui/tui-windata.c (tui_first_data_item_displayed)
3805         (tui_delete_data_content_windows): Update.
3806         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3807         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3808         (tui_display_registers_from, tui_check_register_values): Update.
3809         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3810         pointer.
3811         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3812         window.
3813         (tui_free_data_content): Update.
3814         (free_content_elements) <case DATA_WIN>: Free the window.
3815
3816 2019-06-25  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3819         Update.
3820         * tui/tui-layout.c (make_command_window)
3821         (show_source_disasm_command, show_data, init_and_make_win)
3822         (show_source_or_disasm_and_command): Update.
3823         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3824         method.
3825         <can_highight, is_highlighted>: Now bool.
3826         (tui_set_win_highlight): Don't declare.
3827         * tui/tui-data.c (tui_set_win_highlight): Remove.
3828
3829 2019-06-25  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-wingeneral.c (make_visible): Remove check of window
3832         type.
3833
3834 2019-06-25  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui-win.c (tui_win_info::max_height)
3837         (tui_cmd_window::max_height): New methods.
3838         (new_height_ok): Call max_height.
3839         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3840         <max_height>: New method.
3841
3842 2019-06-25  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-win.c (tui_source_window_base::set_new_height)
3845         (tui_data_window::set_new_height): New methods.
3846         (make_invisible_and_set_new_height): Call set_new_height method.
3847         * tui/tui-data.h (struct tui_win_info)
3848         (struct tui_source_window_base, struct tui_data_window)
3849         <set_new_height>: New method.
3850
3851 2019-06-25  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3854         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3855         tui_refresh_data_win.
3856         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3857         method.
3858         (tui_refresh_all_win): Call the refresh_all method.
3859         (tui_set_focus): Likewise.
3860         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3861         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3862         Likewise.
3863
3864 2019-06-25  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-winsource.h (tui_refill_source_window)
3867         (tui_set_is_exec_point_at): Don't declare.
3868         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3869         (tui_source_window_base::refill): Rename from
3870         tui_refill_source_window.
3871         (tui_source_window_base::do_scroll_horizontal): Update.
3872         (tui_source_window_base::set_is_exec_point_at): Rename from
3873         tui_set_is_exec_point_at.
3874         (tui_update_all_breakpoint_info): Update.
3875         * tui/tui-stack.c (tui_show_frame_info): Update.
3876         * tui/tui-layout.c (show_data): Add cast.
3877         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3878         * tui/tui-data.h (struct tui_source_window_base) <refill,
3879         set_is_exec_point_at>: New methods.
3880         (tui_source_windows, tui_add_to_source_windows): Update types.
3881         (tui_add_to_source_windows): Remove redundant declaration.
3882         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3883         (tui_source_windows): Change return type.
3884         (tui_clear_source_windows_detail): Update.
3885         (tui_add_to_source_windows): Change type of parameter.
3886         (tui_free_all_source_wins_content): Update.
3887
3888 2019-06-25  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-wingeneral.c (tui_win_info::refresh)
3891         (tui_source_window_base::refresh): New methods.
3892         (tui_refresh_all): Call the refresh method.
3893         * tui/tui-data.h (struct tui_win_info)
3894         (struct tui_source_window_base) <refresh>: New method.
3895
3896 2019-06-25  Tom Tromey  <tom@tromey.com>
3897
3898         * tui/tui.h (tui_is_window_visible): Return bool.
3899         * tui/tui.c (tui_is_window_visible): Return bool.
3900         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3901         (tui_make_visible, tui_make_invisible)
3902         (tui_win_info::make_visible)
3903         (tui_source_window_base::make_visible, make_all_visible)
3904         (tui_make_all_visible, tui_make_all_invisible): Update.
3905         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3906         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3907         bool.
3908         (struct tui_win_info, struct tui_source_window_base)
3909         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3910         * tui/tui-data.c (tui_init_generic_part): Update.
3911
3912 2019-06-25  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3915         (tui_source_window_base::make_visible): New methods.
3916         (make_all_visible): Make method call.
3917         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3918         (struct tui_source_window_base, struct tui_cmd_window): Override
3919         make_visible.
3920         (tui_win_is_source_type): Don't declare.
3921         * tui/tui-data.c (tui_win_is_source_type): Remove.
3922
3923 2019-06-25  Tom Tromey  <tom@tromey.com>
3924
3925         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3926         NULL check.
3927
3928 2019-06-25  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3931         Inline constructor.  Add initializers for members.
3932         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3933         constructors; now inline in class.
3934
3935 2019-06-25  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui-regs.c (tui_show_registers): Update.
3938         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3939         bool.
3940         * tui/tui-data.c (tui_data_window::clear_detail)
3941         (tui_data_window): Update.
3942
3943 2019-06-25  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-windata.c (tui_display_all_data)
3946         (tui_display_data_from_line, tui_display_data_from)
3947         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3948         Update.
3949         * tui/tui-regs.c (tui_last_regs_line_no)
3950         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3951         (tui_show_registers, tui_show_register_group)
3952         (tui_display_registers_from, tui_display_reg_element_at_line)
3953         (tui_display_registers_from_line, tui_check_register_values)
3954         (tui_reg_next, tui_reg_prev): Update.
3955         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3956         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3957         tui_data_window.
3958         (struct tui_win_info) <detail>: Remove.  Add new fields from
3959         tui_data_info.
3960         (TUI_DATA_WIN): Add cast.
3961         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3962         (~tui_data_window): Simplify.
3963
3964 2019-06-25  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-layout.c (show_source_disasm_command)
3967         (show_source_or_disasm_and_command): Update.
3968         * tui/tui-io.c (update_cmdwin_start_line)
3969         (tui_redisplay_readline): Update.
3970         * tui/tui-data.h (struct tui_command_info): Remove.
3971         (struct tui_win_info) <detail>: Remove command_info member.
3972         (struct tui_data_window) <start_line>: New member, from
3973         tui_command_info.
3974         (TUI_CMD_WIN): Add casts.
3975
3976 2019-06-25  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-winsource.c (tui_update_source_window)
3979         (tui_refill_source_window)
3980         (tui_source_window_base::do_scroll_horizontal)
3981         (tui_update_breakpoint_info, tui_set_exec_info_content)
3982         (tui_show_exec_info_content, tui_erase_exec_info_content)
3983         (tui_clear_exec_info_content): Update.
3984         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3985         Update.
3986         * tui/tui-win.c (make_invisible_and_set_new_height)
3987         (make_visible_with_new_height): Update.
3988         * tui/tui-source.c (tui_set_source_content)
3989         (tui_show_symtab_source): Update.
3990         * tui/tui-layout.c (extract_display_start_addr)
3991         (show_source_disasm_command, show_data)
3992         (make_source_or_disasm_window)
3993         (show_source_or_disasm_and_command): Update.
3994         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3995         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3996         "gdbarch".
3997         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3998         to tui_source_window_base.
3999         (struct tui_win_info) <detail>: Remove source_info member.
4000         (struct tui_source_window_base) <has_locator>: Inline.
4001         Move contents from tui_source_info; rename has_locator member to
4002         m_has_locator.
4003         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4004         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4005         header file.
4006         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4007         Simplify.
4008         (tui_free_all_source_wins_content): Cast to
4009         tui_source_window_base.
4010
4011 2019-06-25  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui-win.c (make_invisible_and_set_new_height)
4014         (make_visible_with_new_height): Call has_locator method.
4015         * tui/tui-layout.c (show_source_disasm_command, show_data)
4016         (show_source_or_disasm_and_command): Update for bool change.
4017         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4018         (tui_win_info) <has_locator>: New method.
4019         (struct tui_source_window_base) <has_locator>: New method.
4020         (tui_win_has_locator): Don't declare.
4021         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4022         from tui_win_has_locator.
4023         (tui_source_window_base): Use false, not FALSE.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4028         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4029         clear_detail method directly.
4030         (tui_clear_win_detail): Remove.
4031
4032 2019-06-25  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4035         "this", not TUI_DISASM_WIN.
4036
4037 2019-06-25  Tom Tromey  <tom@tromey.com>
4038
4039         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4040         declare.
4041         * tui/tui-winsource.c
4042         (tui_source_window_base::do_scroll_horizontal): Rename from
4043         tui_horizontal_source_scroll.
4044         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4045         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4046         from tui_vertical_data_scroll.
4047         * tui/tui-win.h (tui_scroll): Don't declare.
4048         * tui/tui-win.c (tui_win_info::forward_scroll)
4049         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4050         (tui_win_info::right_scroll): Rename and update.
4051         (tui_scroll_forward_command, tui_scroll_backward_command)
4052         (tui_scroll_left_command, tui_scroll_right_command): Update.
4053         (tui_scroll): Remove.
4054         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4055         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4056         from tui_vertical_source_scroll.
4057         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4058         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4059         from tui_vertical_disassem_scroll.
4060         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4061         do_scroll_horizontal>: New methods.
4062         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4063         Likewise.
4064         (struct tui_source_window_base): Add do_scroll_horizontal.
4065         (struct tui_source_window, struct tui_disasm_window): Add
4066         do_scroll_vertical.
4067         (struct tui_data_window, struct tui_cmd_window): Add
4068         do_scroll_horizontal and do_scroll_vertical.
4069         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4070
4071 2019-06-25  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-data.h (struct tui_source_window_base): New struct.
4074         (struct tui_source_window): Derive from tui_source_window_base.
4075         (struct tui_disasm_window): New struct.
4076         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4077         from tui_source_window::clear_detail.
4078         (tui_source_window_base): Rename from tui_source_window.
4079         (~tui_source_window_base): Rename from ~tui_source_window.
4080         (tui_alloc_win_info): Create a tui_disasm_window.
4081
4082 2019-06-25  Tom Tromey  <tom@tromey.com>
4083
4084         * tui/tui-data.h (struct tui_source_window)
4085         (struct tui_data_window): Declare destructors.
4086         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4087         destructors.
4088         (tui_win_info): Simplify.
4089
4090 2019-06-25  Tom Tromey  <tom@tromey.com>
4091
4092         * tui/tui-winsource.c (tui_display_main)
4093         (tui_update_source_windows_with_addr)
4094         (tui_update_all_breakpoint_info): Update.
4095         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4096         (new_height_ok, parse_scrolling_args): Update.
4097         * tui/tui-stack.c (tui_show_frame_info): Update.
4098         * tui/tui-data.h (struct tui_list): Remove.
4099         (tui_source_windows): Return a reference to a std::vector.
4100         * tui/tui-data.c (source_windows): Now a std::vector.
4101         (tui_source_windows): Change return type.
4102         (tui_clear_source_windows): Rewrite.
4103         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4104         (tui_free_all_source_wins_content): Rewrite.
4105
4106 2019-06-25  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4109         (struct tui_data_window, struct tui_cmd_window): Declare
4110         clear_detail method.
4111         * tui/tui-data.c (tui_source_window::clear_detail)
4112         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4113         methods.
4114         (tui_clear_win_detail): Simplify.
4115
4116 2019-06-25  Tom Tromey  <tom@tromey.com>
4117
4118         * tui/tui-layout.c (make_source_window, make_disasm_window)
4119         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4120         Return the new window.
4121         (show_source_disasm_command, show_data)
4122         (show_source_or_disasm_and_command): Update.
4123
4124 2019-06-25  Tom Tromey  <tom@tromey.com>
4125
4126         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4127         parameter.  Return the new window.
4128         (show_source_disasm_command): Update and remove NULL check.
4129         (show_source_or_disasm_and_command): Update.
4130
4131 2019-06-25  Tom Tromey  <tom@tromey.com>
4132
4133         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4134
4135 2019-06-25  Tom Tromey  <tom@tromey.com>
4136
4137         * tui/tui-data.h (struct tui_win_info): Make constructor
4138         protected.  Make destructor virtual.  Add initializers.
4139         (tui_source_window, tui_data_window, tui_cmd_window): New
4140         classes.
4141         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4142         constructor.  Add "type" parameter.
4143         (tui_source_window, tui_data_window, tui_cmd_window): New
4144         constructors.
4145         (tui_alloc_win_info): Instantiate the appropriate subclass.
4146
4147 2019-06-25  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-win.c (tui_resize_all): Use delete.
4150         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4151         destructor.
4152         (tui_free_window): Don't declare.
4153         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4154         Update.
4155
4156 2019-06-25  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-data.h (struct tui_win_info): Add constructor.
4159         * tui/tui-data.c (tui_alloc_win_info): Use new.
4160         (tui_free_window): Use delete.
4161
4162 2019-06-22  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4165         declare.
4166         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4167
4168 2019-06-22  Tom Tromey  <tom@tromey.com>
4169
4170         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4171         declare.
4172         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4173
4174 2019-06-22  Tom de Vries  <tdevries@suse.de>
4175
4176         * dwarf2read.c (create_addrmap_from_aranges)
4177         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4178         instead of '%zu'.
4179
4180 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4181
4182         * dwarf2read.h (dwarf2_section_info_def): Remove.
4183         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4184         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4185         std::vector<dwarf2_section_info>.
4186         (struct dwo_file) <~dwo_file>: Remove.
4187         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4188         types field.
4189         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4190         (dwarf2_read_debug_names): Likewise.
4191         (create_debug_types_hash_table): Change parameter type to
4192         array_view, adjust code accordingly.
4193         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4194         (partial_die_info::fixup): Likewise.
4195         (determine_prefix): Likewise.
4196         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4197
4198 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4199
4200         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4201         gdb_bfd_ref_ptr.
4202         <~dwo_file>: Remove call to gdb_bfd_unref.
4203         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4204         gdb_bfd_ref_ptr::get.
4205
4206 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4207
4208         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4209         type to htab_up.
4210         * dwarf2read.c (struct dwo_file): Initialize fields.
4211         <~dwo_file>: New.
4212         (free_dwo_file): Remove, move content to ~dwo_file.
4213         (struct dwo_file_deleter): Remove.
4214         (dwo_file_up>: Remove custom deleter.
4215         (free_dwo_files): Remove.
4216         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4217         dwo_files.
4218         (process_skeletonless_type_units): Call unique_ptr::get.
4219         (allocate_dwo_file_hash_table): Add deleter to created hash
4220         table.  Change return type to htab_up.
4221         (lookup_dwo_file_slot): Don't memset dwo_file, call
4222         unique_ptr::get.
4223         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4224         (create_dwo_unit_in_dwp_v2): Likewise.
4225         (open_and_init_dwo_file): Likewise.
4226         (free_dwo_file_from_slot): Remove.
4227
4228 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4229
4230         * dwarf2read.h (struct dwarf2_section_info) <readin,
4231         is_virtual>: Change type to bool.
4232         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4233         true instead of 1.
4234
4235 2019-06-19  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-data.h (tui_init_content_element): Don't declare.
4238
4239 2019-06-19  Tom Tromey  <tom@tromey.com>
4240
4241         * tui/tui-data.h (tui_init_win_info): Don't declare.
4242
4243 2019-06-19  Tom de Vries  <tdevries@suse.de>
4244
4245         * dwarf2read.h (abstract_to_concrete): Change type to
4246         std::unordered_map<sect_offset, std::vector<sect_offset>,
4247         gdb::hash_enum<sect_offset>>.
4248
4249 2019-06-19  Tom Tromey  <tromey@adacore.com>
4250
4251         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4252         EVAL_AVOID_SIDE_EFFECTS specially.
4253
4254 2019-06-19  Tom Tromey  <tromey@adacore.com>
4255
4256         * source-cache.c (highlighter): New global.
4257         (source_cache::get_source_lines): Create a highlighter on demand.
4258
4259 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * defs.h (deprecated_interactive_hook): Delete declaration.
4262         * interps.c (clear_interpreter_hooks): Remove use of
4263         deprecated_interactive_hook.
4264         * top.c (deprecated_interactive_hook): Delete definition.
4265         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4266
4267 2019-06-18  Tom de Vries  <tdevries@suse.de>
4268
4269         PR gdb/24515
4270         * dwarf2read.h (abstract_to_concrete): Change type from
4271         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4272         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4273         * dwarf2read.c (read_variable): Update.
4274         (dwarf2_fetch_die_loc_sect_off): Update.
4275
4276 2019-06-17  Tom de Vries  <tdevries@suse.de>
4277
4278         PR gdb/24617
4279         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4280         accessing parent[parent_len - 1].
4281
4282 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4283
4284         PR gdb/24364
4285         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4286         call dtrace_process_dof with NULL dof.
4287
4288 2019-06-16  Tom de Vries  <tdevries@suse.de>
4289
4290         PR gdb/24445
4291         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4292
4293 2019-06-16  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4296         (make_all_visible): Use address of member.
4297
4298 2019-06-16  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4301         (tui_free_window, free_content, free_content_elements): Remove
4302         unnecessary cast.
4303         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4304         cast.
4305         * tui/tui-regs.c (tui_show_register_group)
4306         (tui_display_registers_from, tui_display_reg_element_at_line):
4307         Remove unnecessary cast.
4308
4309 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * linux-nat.c (normal_mask): Delete.
4312         (_initialize_linux_nat): Don't initialise normal_mask.
4313
4314 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4315
4316         PR gdb/24445
4317         * dwarf-index-write.h (write_psymtabs_to_index): Add
4318         dwz_basename parameter.
4319         * dwarf-index-write.c (write_gdbindex): Move file writing to
4320         write_gdbindex_1.  Change return type void.
4321         (assert_file_size): Move up, remove filename parameter.
4322         (write_gdbindex_1): New function.
4323         (write_debug_names): Change return type to void, call
4324         assert_file_size.
4325         (struct index_wip_file): New struct.
4326         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4327         file logic to index_wip_file.  Write index for dwz file if
4328         needed.
4329         (save_gdb_index_command): Pass basename of dwz file, if present.
4330         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4331         build-id of dwz file, if present.
4332         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4333         (dwarf2_get_dwz_file): Likewise.
4334         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4335         (dwarf2_get_dwz_file): Likewise.
4336
4337 2019-06-16  Tom Tromey  <tom@tromey.com>
4338
4339         * coffread.c (process_coff_symbol): Use xstrdup.
4340         * value.c (create_internalvar): Use xstrdup.
4341
4342 2019-06-16  Tom Tromey  <tom@tromey.com>
4343
4344         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4345         * breakpoint.c (stopin_command, stopat_command)
4346         (until_break_command, decode_location_default): Remove unnecessary
4347         cast.
4348         * utils.c (subset_compare): Remove unnecessary cast.
4349         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4350         cast.
4351         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4352         cast.
4353         * infcmd.c (path_command): Remove unnecessary cast.
4354         * coffread.c (decode_type): Remove unnecessary cast.
4355         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4356         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4357         * tui/tui-stack.c (tui_show_locator_content)
4358         (tui_show_frame_info): Remove unnecessary cast.
4359         * tui/tui-win.c (tui_scroll_forward_command)
4360         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4361         (parse_scrolling_args): Remove unnecessary cast.
4362         * tui/tui-data.c (init_win_info, tui_del_window)
4363         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4364         (free_content_elements): Remove unnecessary cast.
4365         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4366         unnecessary cast.
4367         * tui/tui-source.c (tui_set_source_content)
4368         (tui_vertical_source_scroll): Remove unnecessary cast.
4369         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4370         cast.
4371         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4372         * tui/tui-regs.c (tui_display_registers_from)
4373         (tui_display_register): Remove unnecessary cast.
4374         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4375         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4376         (make_visible): Remove unnecessary cast.
4377         * tui/tui-winsource.c (tui_erase_source_content)
4378         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4379         unnecessary cast.
4380         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4381         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4382         * stabsread.c (read_type, read_array_type, read_range_type):
4383         Remove unnecessary cast.
4384         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4385         (parse_symbol, parse_type, upgrade_type, parse_external)
4386         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4387         unnecessary cast.
4388         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4389
4390 2019-06-16  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-data.c (tui_alloc_generic_win_info)
4393         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4394         checks.
4395
4396 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4397             Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * f-typeprint.c (f_print_type): Don't return early for not
4400         associated or not allocated types.
4401         (f_type_print_varspec_suffix): Add print_rank parameter and print
4402         ranks of array types in case they dangling.
4403         (f_type_print_base): Add print_rank parameter.
4404
4405 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4406
4407         * NEWS: Mention new MI commands.
4408         * break-catch-throw.c (enum exception_event_kind): Move to
4409         breakpoint.h.
4410         (print_mention_exception_catchpoint): Output text as a single
4411         message.
4412         (catch_exception_command_1): Rename to...
4413         (catch_exception_event): ...this, make non-static, update header
4414         command, and change some parameter types.
4415         (catch_catch_command): Update for changes to
4416         catch_exception_command_1.
4417         (catch_throw_command): Likewise.
4418         (catch_rethrow_command): Likewise.
4419         * breakpoint.c (enum exception_event_kind): Delete.
4420         * breakpoint.h (enum exception_event_kind): Moved here from
4421         break-catch-throw.c.
4422         (catch_exception_event): Declare.
4423         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4424         (mi_cmd_catch_throw): New function.
4425         (mi_cmd_catch_rethrow): New function.
4426         (mi_cmd_catch_catch): New function.
4427         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4428         'catch-catch' entries.
4429         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4430         (mi_cmd_catch_rethrow): Declare.
4431         (mi_cmd_catch_catch): Declare.
4432
4433 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * annotate.c (annotate_source_line): Change return type to void,
4436         update implementation to match.
4437         * annotate.h (annotate_source_line): Change return type to void,
4438         update header comment.
4439         * stack.c (print_frame_info): Don't change what frame information
4440         is printed based on whether annotations are on or not.
4441
4442 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4445         (annotate_source): Make static.
4446         (annotate_source_line): Moved from source.c and renamed from
4447         identify_source_line.  Update the return type.
4448         * annotate.h (annotate_source): Delete declaration.
4449         (annotate_source_line): Declaration moved from source.h, and
4450         renamed from identify_source_line.  Return type updated.
4451         * source.c (identify_source_line): Moved to annotate.c and renamed
4452         to annotate_source_line.
4453         (info_line_command): Remove check of annotation_level.
4454         * source.h (identify_source_line): Move declaration to annotate.h
4455         and rename to annotate_source_line.
4456         * stack.c: Add 'annotate.h' include.
4457         (print_frame_info): Remove check of annotation_level before
4458         calling annotate_source_line.
4459
4460 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4461
4462         * source-cache.c (source_cache::get_plain_source_lines): Use
4463         open_source_file_with_line_charpos instead of just
4464         open_source_file, remove call to find_source_lines.
4465         (source_cache::get_source_lines): Likewise.
4466         * source.c (find_source_lines): Make static.
4467         (get_filename_and_charpos): Renamed into...
4468         (open_source_file_with_line_charpos): ..this along with changes to
4469         return a scoped_fd, and some other minor clean ups.
4470         (identify_source_line): Use open_source_file_with_line_charpos.
4471         (search_command_helper): Use open_source_file_with_line_charpos
4472         instead of just open_source_file, remove call to
4473         find_source_lines.
4474         * source.h (open_source_file_with_line_charpos): Declare new
4475         function.
4476         (find_source_lines): Delete declaration.
4477
4478 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * source.c (get_filename_and_charpos): Remove fullname
4481         parameter.
4482         (identify_source_line): Update call to get_filename_and_charpos.
4483
4484 2019-06-14  Tom Tromey  <tromey@adacore.com>
4485
4486         PR gdb/24502:
4487         * ui-style.h (skip_ansi_escape): Update comment.
4488         * ui-file.h (class no_terminal_escape_file): New class.
4489         * ui-file.c (no_terminal_escape_file::write)
4490         (no_terminal_escape_file::puts): New methods.
4491         * cli/cli-logging.c (handle_redirections): Use
4492         no_terminal_escape_file.
4493
4494 2019-06-14  Tom Tromey  <tromey@adacore.com>
4495
4496         * NEWS: Move convenience variable news above Python news.
4497
4498 2019-06-14  Tom Tromey  <tom@tromey.com>
4499
4500         * gnulib: Move directory to top-level.
4501         * configure.ac: Don't configure gnulib.
4502         * configure: Rebuild.
4503         * common/common-defs.h: Use new path to gnulib.
4504         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4505         (GNULIB_H): Remove.
4506         (INCGNU): Look in new gnulib location.
4507         (HFILES_NO_SRCDIR): Remove gnulib files.
4508         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4509         (generated_files): Remove GNULIB_H.
4510         ($(LIBGNU), all-lib): Remove targets.
4511         (distclean): Don't mention GNULIB_BUILDDIR.
4512         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4513
4514 2019-06-14  Tom Tromey  <tromey@adacore.com>
4515
4516         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4517         Warn if symbol file does not provide any symbols.
4518
4519 2019-06-14  Tom Tromey  <tromey@adacore.com>
4520
4521         * source.c (find_and_open_source): Respect basenames_may_differ.
4522
4523 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * annotate.c (annotate_breakpoints_invalid): Make use of
4526         scoped_restore_terminal_state.
4527         (annotate_frames_invalid): Likewise.
4528
4529 2019-06-14  Tom Tromey  <tromey@adacore.com>
4530
4531         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4532         allow assignment to an internalvar.
4533
4534 2019-06-14  Tom Tromey  <tromey@adacore.com>
4535
4536         * ada-lex.l: Allow "_" in attribute names.
4537
4538 2019-06-14  Tom Tromey  <tromey@adacore.com>
4539
4540         PR gdb/24653:
4541         * regcache.c (registers_changed): Don't call alloca.
4542         * top.c (execute_command): Don't call alloca.
4543
4544 2019-06-13  Pedro Alves  <palves@redhat.com>
4545
4546         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4547         'expression'.  When parsing an expression, error out if there's
4548         junk after "unlimited".
4549         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4550         (do_set_command): Adjust calls to is_unlimited_literal.
4551
4552 2019-06-13  Pedro Alves  <palves@redhat.com>
4553
4554         * compile/compile.c (make_compile_options_def_group): Add braces
4555         around array_view initializer.
4556         * thread.c (make_thread_apply_all_options_def_group)
4557         (make_thread_apply_all_options_def_group): Likewise.
4558
4559 2019-06-13  Pedro Alves  <palves@redhat.com>
4560
4561         * NEWS (New commands): Mention "maint test-options
4562         require-delimiter", "maint test-options unknown-is-error", "maint
4563         test-options unknown-is-operand" and "maint show
4564         test-options-completion-result".
4565         (New command options, command completion): New section.
4566         (Completion improvements): New section.
4567         Mention that you can abbreviate "unlimited".
4568
4569 2019-06-13  Pedro Alves  <palves@redhat.com>
4570
4571         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4572         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4573         * unittests/cli-utils-selftests.c (test_parse_flags)
4574         (test_parse_flags_qcs): Delete.
4575         (test_cli_utils): Don't call deleted functions.
4576
4577 2019-06-13  Pedro Alves  <palves@redhat.com>
4578
4579         * thread.c: Include "cli/cli-option.h".
4580         (tp_array_compar_ascending): Global.
4581         (tp_array_compar): Delete function.
4582         (tp_array_compar_ascending, tp_array_compar_descending): New
4583         functions.
4584         (ascending_option_def, qcs_flag_option_def)
4585         (thr_qcs_flags_option_defs)
4586         (make_thread_apply_all_options_def_group)
4587         (make_thread_apply_options_def_group): New.
4588         (thread_apply_all_command): Use gdb::option::process_options.
4589         (thread_apply_command_completer)
4590         (thread_apply_all_command_completer): New.
4591         (thread_apply_command): Use gdb::option::process_options.
4592         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4593         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4594         to generate help text of "thread apply".  Adjust "taas"'s help.
4595         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4596         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4597
4598 2019-06-13  Pedro Alves  <palves@redhat.com>
4599
4600         * thread.c (thread_apply_command): Check for invalid TID with
4601         isdigit instead of !isalpha.
4602
4603 2019-06-13  Pedro Alves  <palves@redhat.com>
4604
4605         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4606         (validate_flags_qcs): New.
4607         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4608         (validate_flags_qcs): Declare.
4609         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4610         (make_frame_apply_options_def_group): New.
4611         (frame_apply_command_count): Process options with
4612         gdb::option::process_options.
4613         (frame_apply_completer): New.
4614         (frame_apply_level_completer, frame_apply_all_completer)
4615         (frame_apply_completer): New.
4616         (_initialize_stack): Update help of "frame apply", "frame apply
4617         level", "frame apply all" and "faas" to mention supported options
4618         and install command completers.
4619         * stack.h (frame_apply_all_completer): Declare.
4620         * thread.c: Include "stack.h".
4621         (tfaas_command): Add "--".
4622         (_initialize_thread): Update help "tfaas" to mention supported
4623         options and install command completer.
4624
4625 2019-06-13  Pedro Alves  <palves@redhat.com>
4626
4627         * completer.c (complete_nested_command_line): New.
4628         (gdb_completion_word_break_characters_throw): Add assertion.
4629         * completer.h (complete_nested_command_line): Declare.
4630
4631 2019-06-13  Pedro Alves  <palves@redhat.com>
4632
4633         * stack.c (parse_backtrace_qualifiers): New.
4634         (backtrace_command): Use it.
4635         (backtrace_command_completer): Complete on qualifiers.
4636
4637 2019-06-13  Pedro Alves  <palves@redhat.com>
4638
4639         * frame.c: Include "cli/cli-option.h.
4640         (user_set_backtrace_options): New.
4641         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4642         Delete.
4643         (get_prev_frame): Adjust.
4644         (boolean_option_def, uinteger_option_def)
4645         (set_backtrace_option_defs): New.
4646         (_initialize_frame): Adjust and use
4647         gdb::option::add_setshow_cmds_for_options to install "set
4648         backtrace past-main" and "set backtrace past-entry".
4649         * frame.h: Include "cli/cli-option.h".
4650         (struct frame_print_options): Forward declare.
4651         (print_frame_arguments_all, print_frame_arguments_scalars)
4652         (print_frame_arguments_none): Declare.
4653         (print_entry_values): Delete declaration.
4654         (struct frame_print_options, user_frame_print_options): New.
4655         (struct set_backtrace_options): New.
4656         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4657         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4658         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4659         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4660         (list_args_or_locals): Add frame_print_options parameter.
4661         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4662         * python/py-framefilter.c (enumerate_args): Pass down
4663         USER_FRAME_PRINT_OPTIONS.
4664         * stack.c: Include "cli/cli-option.h".
4665         (print_frame_arguments_all, print_frame_arguments_scalars)
4666         (print_frame_arguments_none): Declare.
4667         (print_raw_frame_arguments, print_entry_values): Delete.
4668         (user_frame_print_options): New.
4669         (boolean_option_def, enum_option_def, frame_print_option_defs):
4670         New.
4671         (struct backtrace_cmd_options): New.
4672         (bt_flag_option_def): New.
4673         (backtrace_command_option_defs): New.
4674         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4675         (print_frame_arg, read_frame_arg, print_frame_args)
4676         (print_frame_info, print_frame): Add frame_print_options parameter
4677         and use it.
4678         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4679         (backtrace_command_1): Add frame_print_options and
4680         backtrace_cmd_options parameters and use them.
4681         (make_backtrace_options_def_group): New.
4682         (backtrace_command): Process command options with
4683         gdb::option::process_options.
4684         (backtrace_command_completer): New.
4685         (_initialize_stack): Extend "backtrace"'s help to mention
4686         supported options.  Install completer for "backtrace".
4687         Install some settings commands with add_setshow_cmds_for_options.
4688
4689 2019-06-13  Pedro Alves  <palves@redhat.com>
4690
4691         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4692         and that "set/show print raw frame-arguments" are now deprecated.
4693
4694         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4695         command.
4696         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4697         * stack.c (_initialize_stack): Install "set/show print
4698         raw-frame-arguments", and deprecate "set/show print raw
4699         frame-arguments".
4700         * valprint.c (_initialize_valprint): Deprecate "set/show print
4701         raw".
4702
4703 2019-06-13  Pedro Alves  <palves@redhat.com>
4704
4705         * compile/compile.c (struct compile_options): New.
4706         (compile_flag_option_def, compile_command_option_defs)
4707         (make_compile_options_def_group): New.
4708         (compile_file_command): Handle options with
4709         gdb::option::process_options.
4710         (compile_file_command_completer): New function.
4711         (compile_code_command): Handle options with
4712         gdb::option::process_options.
4713         (compile_code_command_completer): New function.
4714         (_initialize_compiler): Install completers for "compile code" and
4715         "compile file".  Mention available options in "compile code" and
4716         "compile code"'s help.
4717         * completer.c (advance_to_completion_word): New, factored out from
4718         ...
4719         (advance_to_expression_complete_word_point): ... this.
4720         (advance_to_filename_complete_word_point): New.
4721         * completer.h (advance_to_filename_complete_word_point): New
4722         declaration.
4723
4724 2019-06-13  Pedro Alves  <palves@redhat.com>
4725
4726         * compile/compile.c: Include "cli/cli-option.h".
4727         (compile_print_value): Scope data pointer is now a
4728         value_print_options pointer; adjust.
4729         (compile_print_command): Process options.  Scope data pointer is
4730         now a value_print_options pointer; adjust.
4731         (_initialize_compile): Update "compile print"'s help to include
4732         supported options.  Install a completer for "compile print".
4733         * cp-valprint.c (show_vtblprint, show_objectprint)
4734         (show_static_field_print): Delete.
4735         (_initialize_cp_valprint): Don't install "set print
4736         static-members", "set print vtbl", "set print object" here.
4737         * printcmd.c: Include "cli/cli-option.h" and
4738         "common/gdb_optional.h".
4739         (print_command_parse_format): Rework to fill in a
4740         value_print_options instead of a format_data.
4741         (print_value): Change parameter type from format_data pointer to
4742         value_print_options reference.  Adjust.
4743         (print_command_1): Process options.  Adjust to pass down a
4744         value_print_options.
4745         (print_command_completer): New.
4746         (_initialize_printcmd): Install print_command_completer as
4747         handle_brkchars completer for the "print" command.  Update
4748         "print"'s help to include supported options.
4749         * valprint.c: Include "cli/cli-option.h".
4750         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4751         here from cp-valprint.c.
4752         (boolean_option_def, uinteger_option_def)
4753         (value_print_option_defs, make_value_print_options_def_group):
4754         New.  Use gdb::option::add_setshow_cmds_for_options to install
4755         "set print elements", "set print null-stop", "set print repeats",
4756         "set print pretty", "set print union", "set print array", "set
4757         print address", "set print symbol", "set print array-indexes".
4758         * valprint.h: Include <string> and "cli/cli-option.h".
4759         (make_value_print_options_def_group): Declare.
4760         (print_value): Change parameter type from format_data pointer to
4761         value_print_options reference.
4762         (print_command_completer): Declare.
4763
4764 2019-06-13  Pedro Alves  <palves@redhat.com>
4765
4766         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4767         (COMMON_SFILES): Add maint-test-settings.c.
4768         * cli/cli-decode.c (boolean_enums): New global, factored out from
4769         ...
4770         (add_setshow_boolean_cmd): ... here.
4771         * cli/cli-decode.h (boolean_enums): Declare.
4772         * cli/cli-option.c: New file.
4773         * cli/cli-option.h: New file.
4774         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4775         factored out from ...
4776         (parse_cli_boolean_value(const char *)): ... this.
4777         (is_unlimited_literal): Change parameter type to pointer to
4778         pointer.  Adjust and advance ARG pointer.
4779         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4780         (parse_cli_var_enum): New, factored out from ...
4781         (do_set_command): ... this.  Adjust.
4782         * cli/cli-setshow.h (parse_cli_boolean_value)
4783         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4784         (parse_cli_var_enum): Declare.
4785         * cli/cli-utils.c: Include "cli/cli-option.h".
4786         (get_ulongest): New.
4787         * cli/cli-utils.h (get_ulongest): Declare.
4788         (check_for_argument): New overloads.
4789         * maint-test-options.c: New file.
4790
4791 2019-06-13  Pedro Alves  <palves@redhat.com>
4792
4793         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4794         parse a range if "-" is at the end of the string.
4795
4796 2019-06-13  Pedro Alves  <palves@redhat.com>
4797
4798         * cli/cli-setshow.c (parse_auto_binary_operation)
4799         (parse_cli_boolean_value): Don't allow "o".
4800
4801 2019-06-13  Pedro Alves  <palves@redhat.com>
4802
4803         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4804         * NEWS: Mention maint test-settings KIND.
4805         * maint-test-settings.c: New file.
4806
4807 2019-06-13  Pedro Alves  <palves@redhat.com>
4808
4809         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4810         completer.
4811         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4812         "set" completers.
4813
4814 2019-06-13  Pedro Alves  <palves@redhat.com>
4815
4816         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4817         after item.
4818
4819 2019-06-13  Pedro Alves  <palves@redhat.com>
4820
4821         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4822
4823 2019-06-13  Pedro Alves <palves@redhat.com>
4824
4825         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4826         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4827         call.
4828         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4829         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4830         calls.
4831         (check_for_argument): Skip spaces after argument.
4832
4833 2019-06-13  Pedro Alves  <palves@redhat.com>
4834
4835         * thread.c (thread_apply_command): Adjust TID parsing.
4836         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4837         detected before end of string.
4838         (tid_is_in_list): Error out if LIST is invalid.
4839
4840 2019-06-13  Pedro Alves  <palves@redhat.com>
4841
4842         * completer.c (complete_line_internal_1): Rewind completion word
4843         point.
4844         (completion_tracker::advance_custom_word_point_by): Change
4845         parameter type to int.
4846         * completer.h (completion_tracker::advance_custom_word_point_by):
4847         Likewise.
4848
4849 2019-06-13  Pedro Alves  <palves@redhat.com>
4850
4851         * completer.c (advance_to_completion_word): Handle delimiters.
4852
4853 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4854
4855         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4856
4857 2019-06-11  Tom Tromey  <tom@tromey.com>
4858
4859         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4860         (xmalloc_failed): Move to alloc.c.
4861         * alloc.c: New file.
4862         * Makefile.in (COMMON_SFILES): Add alloc.c.
4863
4864 2019-06-11  Tom Tromey  <tom@tromey.com>
4865
4866         * nat/linux-waitpid.c: Don't include server.h.
4867         (linux_debug): Remove.
4868         (my_waitpid): Update.
4869
4870 2019-06-11  Tom Tromey  <tromey@adacore.com>
4871
4872         * infcall.c (_initialize_infcall): Remove trailing newline from
4873         help.
4874         * user-regs.c (_initialize_user_regs): Remove trailing newline
4875         from help.
4876         * typeprint.c (_initialize_typeprint): Remove trailing newline
4877         from help.
4878         * reverse.c (_initialize_reverse): Remove trailing newlines from
4879         help.
4880         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4881         from help.
4882         * language.c (add_set_language_command): Remove trailing newline
4883         from help.
4884         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4885         help.
4886         * disasm.c (_initialize_disasm): Remove trailing newline from
4887         help.
4888         * top.c (init_main): Remove trailing newline from help.
4889         * interps.c (_initialize_interpreter): Remove trailing newline
4890         from help.
4891         * btrace.c (_initialize_btrace): Remove trailing newlines from
4892         help.
4893         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4894         from help.
4895         * python/python.c (_initialize_python): Remove trailing newline
4896         from help.
4897         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4898         help.
4899         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4900         from help.  Reformat some text.
4901         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4902         from help.
4903         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4904         newline from help.
4905
4906 2019-06-11  Tom Tromey  <tromey@adacore.com>
4907
4908         * darwin-nat.c (darwin_decode_exception_message)
4909         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4910
4911 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4912
4913         * valops.c (value_slice): Check for not allocated or not
4914         associated values.
4915
4916 2019-06-10  Tom de Vries  <tdevries@suse.de>
4917
4918         PR gdb/24618
4919         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4920         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4921         invalid.
4922
4923 2019-06-10  Tom de Vries  <tdevries@suse.de>
4924
4925         PR gdb/24611
4926         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4927         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4928
4929 2019-06-10  Tom de Vries  <tdevries@suse.de>
4930
4931         PR symtab/24545
4932         * symtab.c (struct demangled_name_entry): Add language field.
4933         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4934         static minimal symbol".  Set and use language field.
4935
4936 2019-06-10  Tom Tromey  <tromey@adacore.com>
4937
4938         * ada-lang.c (_initialize_ada_language): Update help text.
4939
4940 2019-06-10  Tom Tromey  <tromey@adacore.com>
4941
4942         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4943         with a newline.
4944         * guile/guile.c (handle_boot_error): Don't end warning with a
4945         newline.
4946         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4947         warning with a newline.
4948         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4949         newline.
4950         (s12z_frame_cache): Likewise.
4951         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4952         a newline.
4953         * solib-svr4.c (disable_probes_interface): Don't end warning with
4954         a newline.
4955         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4956         newline.
4957         * python/python.c (do_finish_initialization): Don't end warning
4958         with a newline.
4959
4960 2019-06-10  Tom Tromey  <tom@tromey.com>
4961
4962         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4963         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4964         gdbpy_enter.
4965
4966 2019-06-10  Tom Tromey  <tromey@adacore.com>
4967
4968         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4969         data.
4970         (elf_new_init): Don't call stabsread_new_init.
4971         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4972         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4973         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4974
4975 2019-06-10  Tom de Vries  <tdevries@suse.de>
4976
4977         PR symtab/16264
4978         PR symtab/24517
4979         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4980
4981 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4982
4983         * source.c (find_and_open_source): Also rewrite relative file
4984         names.
4985
4986 2019-04-26  Amos Bird  <amosbird@gmail.com>
4987
4988         * annotate.c (annotate_thread_exited): Add "thread-exited"
4989         annotation.
4990
4991 2019-06-06  Tom Tromey  <tromey@adacore.com>
4992
4993         * maint.h (class scoped_command_stats): Use
4994         DISABLE_COPY_AND_ASSIGN.
4995         <print_time>: New method.
4996         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4997         print_time.
4998         (scoped_command_stats::print_time): New method.
4999
5000 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5003         instructions of lengths 6 or 8 bytes.
5004
5005 2019-06-04  Pedro Alves  <palves@redhat.com>
5006
5007         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5008
5009         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5010         * breakpoint.c (condition_completer): Likewise.
5011         * cli/cli-dump.c (scan_expression): Likewise.
5012         * common/filestuff.c (mkdir_recursive): Likewise.
5013         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5014         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5015         (gdb_abspath): Likewise.
5016         * compile/compile-cplus-types.c
5017         (compile_cplus_instance::decl_name): Likewise.
5018         * completer.c (complete_explicit_location):
5019         (signal_completer, reg_or_group_completer_1): Likewise.
5020         * cp-support.c (cp_remove_params_if_any): Likewise.
5021         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5022         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5023         * infcmd.c (strip_bg_char): Likewise.
5024         * linespec.c (copy_token_string): Likewise.
5025         * mi/mi-main.c (output_cores): Likewise.
5026         * psymtab.c (psymtab_search_name):
5027         * symfile.c (test_set_ext_lang_command): Likewise.
5028         * target.c (target_fileio_read_stralloc): Likewise.
5029         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5030         * value.c (complete_internalvar): Likewise.
5031
5032 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5033
5034         Add objfile property to gdb.Type.
5035         * NEWS: Mention Python API addition.
5036         * python/py-type.c (typy_get_objfile): New method.
5037
5038 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5039
5040         * NEWS: Mention the new set|show style [title|highlight].
5041         Mention changes to "show style", "help" and "apropos".
5042
5043 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5044
5045         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5046         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5047         instead of print_help_for_command.
5048         (print_doc_of_command): New function.
5049         (help_list): Add 'apropos -v word' suggestion.
5050         (print_help_for_command): Style the command name using title style.
5051         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5052         (_initialize_cli_cmds): Describe -v in apropos_command help.
5053
5054 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5055
5056         * cli/cli-style.h (cli_style_option): Add name in constructor,
5057         add m_name class member, add constructor with intensity,
5058         add name class function.
5059         (cli_style_option::add_setshow_commands): Remove name argument.
5060         (highlight_style, title_style): New styles.
5061         * cli/cli-style.c (do_show): New function that shows a style
5062         characteristic styling the style name with itself.
5063         (set_style_name): New function.
5064         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5065         Update all callers according to the changes in cli/cli-style.h.
5066         * utils.h (fputs_highlighted): New function.
5067         * utils.c (fputs_highlighted): Likewise.
5068
5069 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5070
5071         * NEWS: Mention new pipe command and new convenience variables.
5072
5073 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5074
5075         * cli/cli-cmds.c (pipe_command): New function.
5076         (_initialize_cli_cmds): Call add_com for pipe_command.
5077         Define | as an alias for pipe.
5078         (exit_status_set_internal_vars): New function.
5079         (shell_escape): Call exit_status_set_internal_vars.
5080         cli/cli-decode.c (find_command_name_length): Recognize | as
5081         a single character command.
5082
5083 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5084
5085         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5086         top.c (execute_command_to_ui_file): New function, mostly a copy
5087         of execute_command_to_string.
5088         (execute_command_to_string): Implement by calling
5089         execute_command_to_ui_file.
5090
5091 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5092
5093         * top.h (saved_command_line): Remove declaration.
5094         * top.c (previous_saved_command_line, previous_repeat_arguments):
5095         New variables.
5096         (saved_command_line): Make static, define together with other
5097         'repeat variables'.
5098         (dont_repeat): Clear repeat_arguments.
5099         (repeat_previous, get_saved_command_line, save_command_line):
5100         New functions.
5101         (gdb_init): Initialize saved_command_line
5102         and previous_saved_command_line.
5103         * main.c (captured_main_1): Remove saved_command_line initialization.
5104         * event-top.c (handle_line_of_input): Update to use
5105         the new 'repeat' related functions instead of direct access to
5106         saved_command_line.
5107         * command.h (repeat_previous, get_saved_command_line,
5108         save_command_line): New declarations.
5109         (dont_repeat): Add comment.
5110
5111 2019-05-30  Tom Tromey  <tromey@adacore.com>
5112
5113         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5114         Fix comment.
5115         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5116
5117 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5118
5119         PR cli/24587
5120         * completer.c (complete): Initialize variable word.
5121
5122 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5123
5124         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5125         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5126         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5127         'body' is NULL to the outter 'if', protecting the '!is_define'
5128         situation as well.
5129
5130 2019-05-29  Tom Tromey  <tromey@adacore.com>
5131
5132         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5133         (dwarf_unknown): New function.
5134         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5135         (dwarf_type_encoding_name): Use dwarf_unknown.
5136
5137 2019-05-29  Tom Tromey  <tromey@adacore.com>
5138
5139         PR c++/20020:
5140         * cp-valprint.c (cp_print_value_fields): Call
5141         cp_print_static_field inside "try".
5142
5143 2019-05-29  Tom Tromey  <tromey@adacore.com>
5144
5145         * inflow.c (struct terminal_info): Add default operator=.
5146         * configure: Rebuild.
5147         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5148         -Wdeprecated-copy-dtor, -Wredundant-move.
5149
5150 2019-05-29  Tom Tromey  <tromey@adacore.com>
5151
5152         * NEWS: Add entry.
5153         * infcmd.c (print_return_value_1): Handle finish_print
5154         option.
5155         (show_print_finish): New function.
5156         (_initialize_infcmd): Add "set/show print finish" commands.
5157         * valprint.c (user_print_options): Initialize new member.
5158         * valprint.h (struct value_print_options) <finish_print>: New
5159         member.
5160
5161 2019-05-28  Tom Tromey  <tromey@adacore.com>
5162
5163         * ada-lang.c (ada_remove_Xbn_suffix)
5164         (find_old_style_renaming_symbol)
5165         (parse_old_style_renaming): Remove.
5166         (ada_find_renaming_symbol): Don't call
5167         find_old_style_renaming_symbol.
5168         (ada_is_renaming_symbol): Rename from
5169         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5170         bool.  Now static.
5171         (ada_read_var_value): Update and simplify.
5172         * ada-exp.y (write_var_or_type): Remove old code.
5173
5174 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5175
5176         * event-top.c: Remove include comment.
5177         * inflow.c (class scoped_ignore_sigttou): Move from here...
5178         * inflow.h (class scoped_ignore_sigttou): ...to here.
5179         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5180         * top.c:  Remove include comment.
5181
5182 2019-05-27  Tom Tromey  <tom@tromey.com>
5183
5184         * NEWS: Fix typo.
5185
5186 2019-05-22  Tom Tromey  <tromey@adacore.com>
5187
5188         * target.c (target_follow_exec): Constify parameter.
5189         * target-delegates.c: Rebuild.
5190         * remote.c (remote_target::follow_exec): Constify parameter.
5191         * infrun.c (follow_exec): Constify parameter.
5192         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5193         (target_follow_exec): Likewise.
5194
5195 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5196
5197         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5198         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5199
5200 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5201
5202         * NEWS: Add debugredirect and testsuite sections.
5203
5204 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5205
5206         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5207         target descriptions using exclusively floating point register name
5208         aliases.
5209
5210 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5211
5212         PR gdb/18644:
5213         * f-lang.c (build_fortran_types): Handle the case where
5214         gdbarch_floatformat_for_type returns a nullptr.
5215
5216 2019-05-21  Tom de Vries  <tdevries@suse.de>
5217
5218         PR cli/24587
5219         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5220
5221 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5222
5223         PR gdb/18644:
5224         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5225         16-byte floats.
5226         * i386-tdep.c (i386_floatformat_for_type): Use
5227         floatformats_ia64_quad for the 16-byte floating point component
5228         within a fortran 32-byte complex number.
5229
5230 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5233         delete default constructor.
5234         (find_partial_die): Update to return const struct.
5235         (partial_die_parent_scope): Move variable declaration into scope
5236         of its use and change its type to auto.
5237         (guess_partial_die_structure_name): Likewise.
5238         (partial_die_info::fixup): Likewise.
5239
5240 2019-05-17  Tom Tromey  <tromey@adacore.com>
5241
5242         * source.c (find_and_open_source): Remove cast.
5243
5244 2019-05-17  Tom Tromey  <tromey@adacore.com>
5245
5246         * annotate.c (annotate_source): Make "filename" const.
5247         * annotate.h (annotate_source): Use const.
5248
5249 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5250
5251         * disasm.c (set_disassembler_options): Send errors to stderr.
5252
5253 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5254
5255         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5256         (cli_interp_base::set_logging): Check debug_redirect.
5257         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5258         * cli/cli-logging.c (debug_redirect): Add static variable.
5259         (pop_output_files): Add default param.
5260         (handle_redirections): Print debug setting.
5261         (show_logging_command): Likewise.
5262         (_initialize_cli_logging): Add debugredirect command.
5263         * interps.c (current_interp_set_logging): Add debug_redirect
5264         parameter.
5265         * interps.h (set_logging): Add debug_redirect parameter.
5266         (current_interp_set_logging): Likewise.
5267         * mi/mi-common.h: Likewise.
5268         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5269
5270 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5271             Tom Tromey  <tromey@adacore.com>
5272
5273         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5274         directly.
5275         * cli/cli-interp.h (make_logging_output): Remove declaration.
5276         * cli/cli-logging.c (make_logging_output): Remove function.
5277         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5278         directly.
5279         * ui-file.c (tee_file::tee_file): Remove bools.
5280         (tee_file::~tee_file): Remove deletes.
5281         * ui-file.h (tee_file): Remove bools.
5282
5283 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5284
5285         * mi/mi-cmds.h (mi_cmd_complete): New function.
5286         * mi/mi-main.c (mi_cmd_complete): Likewise.
5287         * mi/mi-cmds.c: Define new MI command -complete.
5288         * NEWS: Mention new -complete command.
5289
5290 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5291
5292         * completer.h (complete): New function.
5293         * completer.c (complete): Likewise.
5294         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5295         function defined in completer.h.
5296
5297 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5298
5299         * MAINTAINERS (Write After Approval): Add myself.
5300
5301 2019-05-17  Tom de Vries  <tdevries@suse.de>
5302
5303         PR gdb/24094
5304         * dwarf2read.c (struct cu_partial_die_info): New struct.
5305         (find_partial_die): Return cu_partial_die_info.
5306         (partial_die_parent_scope, guess_partial_die_structure_name)
5307         (partial_die_info::fixup): Handle new return type of find_partial_die.
5308
5309 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5310
5311         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5312         "std::string", simplifying the algorithm.
5313
5314 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5315
5316         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5317         (stap_static_probe_ops::get_probes): Likewise.
5318
5319 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5320
5321         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5322         '-')" and "else if".
5323         (stap_parse_single_operand): Join checks for
5324         "gdbarch_stap_parse_special_token_p" and
5325         "gdbarch_stap_parse_special_token" in the same "if" statement.
5326         Invert check when verifying for operation on register
5327         displacement.
5328
5329 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5330
5331         * stap-probe.c (stap_get_opcode): Update comment.
5332         (stap_get_expected_argument_type): Likewise.
5333         (handle_stap_probe): Likewise.
5334
5335 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5336
5337         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5338         return type to 'bool'.  Adjust comment.  Use 'bool' when
5339         appropriate.
5340         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5341         * stap-probe.c (stap_parse_argument_1): Likewise.
5342         (stap_is_operator): Likewise.
5343         (stap_is_generic_prefix): Likewise.
5344         (stap_is_register_prefix): Likewise.
5345         (stap_is_register_indirection_prefix): Likewise.
5346         (stap_is_integer_prefix): Likewise.
5347         (stap_generic_check_suffix): Likewise.
5348         (stap_check_integer_suffix): Likewise.
5349         (stap_check_register_suffix): Likewise.
5350         (stap_check_register_indirection_suffix): Likewise.
5351         (stap_parse_register_operand): Likewise.
5352         (stap_parse_single_operand): Likewise.
5353         (stap_parse_argument_1): Likewise.
5354         (stap_probe::get_argument_count): Likewise.
5355         (stap_is_operator): Likewise.
5356
5357 2019-05-16  Tom Tromey  <tromey@adacore.com>
5358
5359         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5360         keyword to foreach.
5361
5362 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5363
5364         * linux-thread-db.c (try_thread_db_load_1): Change return type
5365         to bool.
5366         (try_thread_db_load): Likewise.
5367         (try_thread_db_load_from_pdir_1): Likewise.
5368         (try_thread_db_load_from_pdir): Likewise.
5369         (try_thread_db_load_from_sdir): Likewise.
5370         (try_thread_db_load_from_dir): Likewise.
5371         (thread_db_load_search): Likewise.
5372         (has_libpthread): Likewise.
5373         (thread_db_load): Likewise.
5374
5375 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5376
5377         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5378         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5379         NULL, and complain/return if that's the case.
5380
5381 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5382
5383         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5384         (advance, posn, abstract_read_memory): New functions.
5385         [struct mem_read_abstraction]: New struct.
5386         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5387
5388 2019-05-14  Tom Tromey  <tromey@adacore.com>
5389
5390         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5391         value is not lval_memory.
5392
5393 2019-05-14  Tom Tromey  <tromey@adacore.com>
5394
5395         * solib.c (info_sharedlibrary_command): Style the file name.
5396
5397 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5398
5399         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5400         (aarch64_vnv_type): Likewise.
5401         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5402         * common/tdesc.c: Likewise.
5403         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5404         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5405         * features/aarch64-fpu.xml: Add ieee half view.
5406         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5407         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5408         * gdbtypes.h (struct builtin_type): Likewise.
5409         (struct objfile_type): Likewise.
5410
5411 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5412
5413         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5414         typo.
5415         * location.h (string_to_event_location): Likewise.
5416
5417 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5418
5419         GDB 8.3 released.
5420
5421 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5422
5423         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5424         New variable declaration.
5425         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5426         New variable.
5427         (print_one_breakpoint): Use ui_out::test_flags and new global
5428         variable to compute use_fixed_output.
5429         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5430         Remove.
5431         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5432         (mi_multi_location_breakpoint_output_fixed): Remove.
5433         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5434         new variable.
5435         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5436         fix_multi_location_breakpoint_output flag if version >= 3.
5437         * ui-out.h (enum ui_out_flag)
5438         <fix_multi_location_breakpoint_output>: New enumerator.
5439
5440 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5441
5442         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5443
5444 2019-05-10  Tom Tromey  <tromey@adacore.com>
5445
5446         * ada-lang.c (catch_ada_completer): New function.
5447         (_initialize_ada_language): Use it.
5448
5449 2019-05-10  Tom Tromey  <tromey@adacore.com>
5450
5451         * thread.c (print_thread_info): Make "requested_threads" const.
5452         * gdbthread.h (print_thread_info): Make "requested_threads"
5453         const.
5454         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5455         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5456
5457 2019-05-08  Tom Tromey  <tom@tromey.com>
5458
5459         * gdbtypes.c (objfile_type_data): Change type.
5460         (objfile_type, _initialize_gdbtypes): Update.
5461
5462 2019-05-08  Tom Tromey  <tom@tromey.com>
5463
5464         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5465         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5466         (_initialize_dwarf2_frame): Update.
5467
5468 2019-05-08  Tom Tromey  <tom@tromey.com>
5469
5470         * objc-lang.c (objc_objfile_data): Change type.
5471         (find_methods): Update.
5472         (_initialize_objc_lang): Remove.
5473
5474 2019-05-08  Tom Tromey  <tom@tromey.com>
5475
5476         * stabsread.c (rs6000_builtin_type_data): Change type.
5477         (rs6000_builtin_type, _initialize_stabsread): Update.
5478
5479 2019-05-08  Tom Tromey  <tom@tromey.com>
5480
5481         * mips-tdep.c (mips_pdr_data): Remove.
5482         (_initialize_mips_tdep): Update.
5483
5484 2019-05-08  Tom Tromey  <tom@tromey.com>
5485
5486         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5487         (hppa_init_objfile_priv_data, read_unwind_info)
5488         (find_unwind_entry, _initialize_hppa_tdep): Update.
5489
5490 2019-05-08  Tom Tromey  <tom@tromey.com>
5491
5492         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5493         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5494         on obstack.
5495         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5496
5497 2019-05-08  Tom Tromey  <tom@tromey.com>
5498
5499         * mdebugread.c (basic_type_data): Change type.
5500         (basic_type, _initialize_mdebugread): Update.
5501
5502 2019-05-08  Tom Tromey  <tom@tromey.com>
5503
5504         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5505
5506 2019-05-08  Tom Tromey  <tom@tromey.com>
5507
5508         * nto-tdep.c (nto_inferior_data_reg): Change type.
5509         (nto_inferior_data): Update.
5510         (nto_inferior_data_cleanup, nto_new_inferior_data)
5511         (_initialize_nto_tdep): Remove.
5512         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5513
5514 2019-05-08  Tom Tromey  <tom@tromey.com>
5515
5516         * ada-lang.c (struct ada_inferior_data): Add initializers.
5517         (ada_inferior_data): Change type.
5518         (ada_inferior_data_cleanup): Remove.
5519         (get_ada_inferior_data, ada_inferior_exit)
5520         (struct ada_pspace_data): Add initializers, destructor.
5521         (ada_pspace_data_handle): Change type.
5522         (get_ada_pspace_data): Update.
5523         (ada_pspace_data_cleanup): Remove.
5524
5525 2019-05-08  Tom Tromey  <tom@tromey.com>
5526
5527         * coffread.c (struct coff_symfile_info): Add initializers.
5528         (coff_objfile_data_key): Move lower.  Change type.
5529         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5530         Update.
5531         (coff_free_info): Remove.
5532
5533 2019-05-08  Tom Tromey  <tom@tromey.com>
5534
5535         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5536         (fbsd_pspace_data_handle): Move lower.  Change type.
5537         (get_fbsd_pspace_data): Update.
5538         (fbsd_pspace_data_cleanup): Remove.
5539         (_initialize_fbsd_tdep): Update.
5540
5541 2019-05-08  Tom Tromey  <tom@tromey.com>
5542
5543         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5544         (get_ada_tasks_pspace_data): Update.
5545         (ada_tasks_pspace_data_cleanup): Remove.
5546         (_initialize_tasks): Update.
5547         (ada_tasks_inferior_data_handle): Change type.
5548         (get_ada_tasks_inferior_data): Update.
5549         (ada_tasks_inferior_data_cleanup): Remove.
5550         (struct ada_tasks_pspace_data): Add initializers.
5551
5552 2019-05-08  Tom Tromey  <tom@tromey.com>
5553
5554         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5555         * symfile-debug.c (debug_sym_get_probes): Change type.
5556         * stap-probe.c (handle_stap_probe):
5557         (stap_static_probe_ops::get_probes): Change type.
5558         * probe.h (class static_probe_ops) <get_probes>: Change type.
5559         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5560         (parse_probes_in_pspace): Update.
5561         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5562         Update.
5563         (any_static_probe_ops::get_probes): Change type.
5564         * elfread.c (elfread_data): New typedef.
5565         (probe_key): Change type.
5566         (elf_get_probes): Likewise.  Update.
5567         (probe_key_free): Remove.
5568         (_initialize_elfread): Update.
5569         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5570         Change type.
5571         (dtrace_process_dof_probe, dtrace_process_dof)
5572         (dtrace_static_probe_ops::get_probe): Change type.
5573
5574 2019-05-08  Tom Tromey  <tom@tromey.com>
5575
5576         * xcoffread.c (struct xcoff_symfile_info): Rename from
5577         coff_symfile_info.  Add initializers.
5578         (xcoff_objfile_data_key): Move lower.  Change type.
5579         (XCOFF_DATA): Rewrite.
5580         (xcoff_free_info): Remove.
5581         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5582         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5583         (xcoff_initial_scan): Update.
5584
5585 2019-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * solib-svr4.c (struct svr4_info): Add initializers and
5588         destructor.
5589         <probes_table>: Now an htab_up.
5590         (solib_svr4_pspace_data): Change type.
5591         (free_probes_table): Simplify.
5592         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5593         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5594         (probes_table_remove_objfile_probes, register_solib_event_probe)
5595         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5596         (_initialize_svr4_solib): Update.
5597
5598 2019-05-08  Tom Tromey  <tom@tromey.com>
5599
5600         * remote.c (remote_pspace_data): Change type.
5601         (remote_pspace_data_cleanup): Remove.
5602         (get_remote_exec_file, set_pspace_remote_exec_file)
5603         (_initialize_remote): Update.
5604
5605 2019-05-08  Tom Tromey  <tom@tromey.com>
5606
5607         * breakpoint.c (breakpoint_objfile_key): Change type.
5608         (get_breakpoint_objfile_data): Update.
5609         (free_breakpoint_objfile_data): Remove.
5610         (_initialize_breakpoint): Update.
5611
5612 2019-05-08  Tom Tromey  <tom@tromey.com>
5613
5614         * linux-tdep.c (struct linux_info): Add initializers.
5615         (linux_inferior_data): Move.  Change type.
5616         (invalidate_linux_cache_inf): Update.
5617         (linux_inferior_data_cleanup): Remove.
5618         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5619
5620 2019-05-08  Tom Tromey  <tom@tromey.com>
5621
5622         * auxv.c (auxv_inferior_data): Move.  Change type.
5623         (auxv_inferior_data_cleanup): Remove.
5624         (invalidate_auxv_cache_inf): Rewrite.
5625         (get_auxv_inferior_data, _initialize_auxv): Update.
5626
5627 2019-05-08  Tom Tromey  <tom@tromey.com>
5628
5629         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5630         (symfile_debug_objfile_data_key): Change type.
5631         (symfile_debug_installed, debug_qf_has_symbols)
5632         (debug_qf_find_last_source_symtab)
5633         (debug_qf_forget_cached_source_info)
5634         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5635         (debug_qf_print_stats, debug_qf_dump)
5636         (debug_qf_expand_symtabs_for_function)
5637         (debug_qf_expand_all_symtabs)
5638         (debug_qf_expand_symtabs_with_fullname)
5639         (debug_qf_map_matching_symbols)
5640         (debug_qf_expand_symtabs_matching)
5641         (debug_qf_find_pc_sect_compunit_symtab)
5642         (debug_qf_map_symbol_filenames)
5643         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5644         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5645         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5646         (debug_sym_read_linetable, debug_sym_relocate): Update.
5647         (symfile_debug_free_objfile): Remove.
5648         (install_symfile_debug_logging, _initialize_symfile_debug):
5649         Update.
5650
5651 2019-05-08  Tom Tromey  <tom@tromey.com>
5652
5653         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5654         allocate_on_obstack.
5655         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5656         (get_dwarf2_per_objfile): Update.
5657         (set_dwarf2_per_objfile): Remove.
5658         (dwarf2_has_info, dwarf2_get_section_info): Update.
5659         (dwarf2_free_objfile): Remove.
5660         (_initialize_dwarf2_read): Update.
5661
5662 2019-05-08  Tom Tromey  <tom@tromey.com>
5663
5664         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5665         initializers.
5666         <unsupported_script_warning_printed,
5667         script_not_found_warning_printed>: Now bool.
5668         (auto_load_pspace_data): Change type.
5669         (~auto_load_pspace_info): Rename from
5670         auto_load_pspace_data_cleanup.
5671         (get_auto_load_pspace_data, init_loaded_scripts_info)
5672         (clear_section_scripts, maybe_print_unsupported_script_warning)
5673         (maybe_print_script_not_found_warning, _initialize_auto_load):
5674         Update.
5675
5676 2019-05-08  Tom Tromey  <tom@tromey.com>
5677
5678         * objfiles.c (objfile_pspace_info): Add destructor and
5679         initializers.
5680         (objfiles_pspace_data): Change type.
5681         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5682         (get_objfile_pspace_data): Update.
5683         (objfiles_bfd_data): Change type.
5684         (get_objfile_bfd_data): Update.
5685         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5686
5687 2019-05-08  Tom Tromey  <tom@tromey.com>
5688
5689         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5690         Change type.
5691         (get_catch_syscall_inferior_data): Update.
5692         (catch_syscall_inferior_data_cleanup): Remove.
5693         (_initialize_break_catch_syscall): Update.
5694
5695 2019-05-08  Tom Tromey  <tom@tromey.com>
5696
5697         * inflow.c (struct terminal_info): Add destructor and
5698         initializers.
5699         (inflow_inferior_data): Change type.
5700         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5701         (get_inflow_inferior_data, inflow_inferior_exit)
5702         (swap_terminal_info, _initialize_inflow): Update.
5703
5704 2019-05-08  Tom Tromey  <tom@tromey.com>
5705
5706         * target-dcache.c (target_dcache_cleanup): Remove.
5707         (target_dcache_aspace_key): Change type.
5708         (target_dcache_init_p, target_dcache_invalidate)
5709         (target_dcache_get, target_dcache_get_or_init)
5710         (_initialize_target_dcache): Update.
5711         * dcache.h (struct dcache_deleter): New.
5712
5713 2019-05-08  Tom Tromey  <tom@tromey.com>
5714
5715         * symtab.c (struct symbol_cache): Add destructor and
5716         initializers.
5717         (symbol_cache_key): Move.  Change type.
5718         (make_symbol_cache, free_symbol_cache): Remove.
5719         (get_symbol_cache): Update.
5720         (symbol_cache_cleanup): Remove.
5721         (ALL_PSPACES, symbol_cache_flush)
5722         (maintenance_print_symbol_cache)
5723         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5724         Update.
5725
5726 2019-05-08  Tom Tromey  <tom@tromey.com>
5727
5728         * symtab.c (struct main_info): Add destructor and initializers.
5729         (main_progspace_key): Move.  Change type.
5730         (get_main_info): Update.
5731         (main_info_cleanup): Remove.
5732         (_initialize_symtab): Update.
5733
5734 2019-05-08  Tom Tromey  <tom@tromey.com>
5735
5736         * registry.h (DECLARE_REGISTRY): Define the _key class.
5737
5738 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5739
5740         * NEWS: Merge two 'New commands' sections.
5741
5742 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5743
5744         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5745         parameter and use Ada language definition instead.
5746         (ada_val_print_ptr): Remove unused language parameter.
5747         (ada_val_print_num): Remove language parameter and use Ada language
5748         definition instead.
5749         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5750         parameter.
5751         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5752         parameter and use Ada language definition instead.
5753         (ada_val_print_1): Update all ada_val_print_xxx calls.
5754         Remove language parameter.
5755         (ada_val_print): Update ada_val_print_1 call.
5756
5757 2019-05-08  Tom Tromey  <tromey@adacore.com>
5758
5759         * remote.c (remote_hw_watchpoint_limit)
5760         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5761         Now static.
5762
5763 2019-05-08  Tom Tromey  <tromey@adacore.com>
5764
5765         * maint.c (_initialize_maint_cmds): Move initialization code to
5766         remote.c.
5767         (watchdog, show_watchdog): Move to remote.c.
5768         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5769         "watchdog" static.
5770         (_initialize_remote): Move initialization code from maint.c.
5771         * defs.h (watchdog): Don't declare.
5772
5773 2019-05-08  Tom Tromey  <tromey@adacore.com>
5774
5775         * tui/tui-interp.c: Include main.h.
5776         * interps.c: Include main.h.
5777         * main.h (interpreter_p): Declare.
5778         * defs.h (interpreter_p): Don't declare.
5779
5780 2019-05-08  Tom Tromey  <tromey@adacore.com>
5781
5782         * dwarf2loc.c: Include dwarf2read.h.
5783         * defs.h (read_unsigned_leb128): Don't declare.
5784         * dwarf2read.h (read_unsigned_leb128): Declare.
5785
5786 2019-05-08  Tom Tromey  <tromey@adacore.com>
5787
5788         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5789         method.
5790
5791 2019-05-08  Tom Tromey  <tromey@adacore.com>
5792
5793         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5794         when no wrap column is set.
5795
5796 2019-05-08  Tom Tromey  <tromey@adacore.com>
5797
5798         * c-lang.c (c_get_string): Handle non-C-style arrays.
5799
5800 2019-05-08  Tom Tromey  <tromey@adacore.com>
5801
5802         * typeprint.c (print_offset_data::update): Print the bit offset,
5803         not the number of bits remaining.
5804
5805 2019-05-08  Tom Tromey  <tromey@adacore.com>
5806
5807         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5808         padding at end of comment.
5809
5810 2019-05-08  Tom Tromey  <tromey@adacore.com>
5811
5812         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5813         Compare main types.
5814
5815 2019-05-06  Tom Tromey  <tom@tromey.com>
5816
5817         * common/scoped_mmap.c: Include common-defs.h.
5818         * common/scoped_mmap.h: Don't include config.h.
5819
5820 2019-05-04  Tom Tromey  <tom@tromey.com>
5821
5822         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5823         (struct aarch64_call_info): Add initializers.
5824         <si>: Now a std::vector.
5825         (pass_on_stack, aarch64_push_dummy_call): Update.
5826
5827 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5828             Tom Tromey  <tom@tromey.com>
5829
5830         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5831         (ppc_threads): Now a std::vector.  Now static.
5832         (hwdebug_find_thread_points_by_tid)
5833         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5834         Update.
5835
5836 2019-05-04  Tom Tromey  <tom@tromey.com>
5837
5838         * arc-tdep.c (arc_tdesc_init): Return bool.
5839
5840 2019-05-04  Tom Tromey  <tom@tromey.com>
5841
5842         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5843         Use gdb_assert_not_reached.
5844
5845 2019-05-04  Tom Tromey  <tom@tromey.com>
5846
5847         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5848         "false".
5849
5850 2019-05-04  Tom Tromey  <tom@tromey.com>
5851
5852         * arc-tdep.c (arc_tdesc_init): Use bool.
5853
5854 2019-05-04  Tom Tromey  <tom@tromey.com>
5855
5856         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5857
5858 2019-05-04  Tom Tromey  <tom@tromey.com>
5859
5860         * cli/cli-cmds.c (valid_command_p): Return bool.
5861
5862 2019-05-04  Tom Tromey  <tom@tromey.com>
5863
5864         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5865         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5866
5867 2019-05-04  Raul Tambre  <raul@tambre.ee>
5868
5869         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5870         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5871         operator for comparison.
5872
5873 2019-05-04  Tom Tromey  <tom@tromey.com>
5874
5875         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5876         (lookup_partial_symbol, print_partial_symbols)
5877         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5878         (psymbol_compare): Update.
5879         (add_psymbol_to_bcache): Clear the entire psymbol.
5880         (maintenance_check_psymtabs): Update.
5881         * psympriv.h (struct partial_symbol): Don't derive from
5882         general_symbol_info.
5883         <obj_section, unrelocated_address, address,
5884         set_unrelocated_address>: Update.
5885         <ginfo>: New member.
5886         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5887         (debug_names::write_psymbols): Update.
5888
5889 2019-05-04  Tom de Vries  <tdevries@suse.de>
5890
5891         * contrib/cc-with-tweaks.sh: Support -n arg.
5892
5893 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5894
5895         * corelow.c (core_target::detach): Ensure frame cache and
5896         register caches are cleared.
5897         inferior.c (exit_inferior_1): Likewise.
5898
5899 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5900             Tom Tromey  <tom@tromey.com>
5901
5902         * dictionary.c (collate_pending_symbols_by_language): Remove
5903         "struct" from foreach.
5904         * symtab.c (lookup_global_symbol_from_objfile)
5905         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5906         foreach.
5907         * ser-tcp.c (net_open): Remove "struct" from foreach.
5908         * objfiles.c (objfile_relocate, objfile_rebase)
5909         (objfile_has_symbols): Remove "struct" from foreach.
5910         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5911         from foreach.
5912         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5913         foreach.
5914         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5915         "struct" from foreach.
5916         * ada-lang.c (create_excep_cond_exprs)
5917         (ada_exception_catchpoint_cond_string): Remove "struct" from
5918         foreach.
5919
5920 2019-05-03  Tom Tromey  <tromey@adacore.com>
5921
5922         * ada-exp.y (convert_char_literal): Check suffix of each
5923         enumerator.
5924
5925 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5926
5927         PR ada/21406:
5928         * ada-exp.y (yywrap): Don't define.
5929         * ada-lex.l (%option): Add noyywrap
5930         (yywrap): Remove.
5931
5932 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5933
5934         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5935         _WIN32_WINNT to the XP level, unless already defined to a higher
5936         level.
5937
5938         * unittests/parse-connection-spec-selftests.c:
5939         * ser-tcp.c:
5940         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5941         override.
5942
5943         * symfile.c (find_separate_debug_file): Remove colon from the
5944         drive spec of DOS/Windows file names of the target, so that the
5945         file name produced from DEBUGDIR and the target's directory will
5946         be valid on DOS/Windows systems.
5947
5948 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * rust-lang.c (val_print_struct): Handle printing structures
5951         containing strings.
5952
5953 2019-05-02  Tom Tromey  <tromey@adacore.com>
5954
5955         * valarith.c (_initialize_valarith): Remove.
5956
5957 2019-05-01  Tom Tromey  <tromey@adacore.com>
5958
5959         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5960         bitfields.
5961
5962 2019-05-01  Tom Tromey  <tromey@adacore.com>
5963
5964         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5965         for big-endian copies.
5966
5967 2019-04-30  Ali Tamur  <tamur@google.com>
5968         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5969         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5970         (read_3_bytes): New function.
5971
5972 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5973
5974         * windows-nat.c (main_thread_id): Delete.
5975         (handle_output_debug_string): Replace main_thread_id by
5976         current_event.dwThreadId.
5977         (fake_create_process): Likewise.
5978         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5979         Do not set main_thread_id.
5980         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5981         current_event.dwThreadId.
5982         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5983
5984 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5985
5986         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5987         Use current_event.dwThreadId instead of main_thread_id.
5988
5989 2019-04-30  Tom Tromey  <tromey@adacore.com>
5990
5991         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5992         (create_excep_cond_exprs): Iterate over program spaces.
5993         (ada_exception_catchpoint_cond_string): Examine all minimal
5994         symbols for exception types.
5995
5996 2019-04-30  Tom Tromey  <tromey@adacore.com>
5997
5998         PR c++/24470:
5999         * dwarf2read.c (process_structure_scope): Handle case where type
6000         has template parameters but no symbol was created.
6001
6002 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6003             Chris January  <chris.january@arm.com>
6004
6005         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6006         qualifier.
6007         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6008
6009 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * f-typeprint.c (f_print_type): Update rules for printing
6012         whitespace.
6013         (f_type_print_varspec_suffix): Likewise.
6014
6015 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6016             Chris January  <chris.january@arm.com>
6017
6018         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6019         function arguments.
6020
6021 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6022
6023         * f-lang.c (build_fortran_types): Change name of void type to
6024         lower case.
6025         * f-typeprint.c (f_type_print_base): Print the name of the void
6026         type, rather than a fixed string.
6027         * f-valprint.c (f_decorations): Use lower case void string.
6028
6029 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6030             Chris January  <chris.january@arm.com>
6031
6032         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6033         types for Fortran.
6034
6035 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6036             Chris January  <chris.january@arm.com>
6037             David Lecomber  <david.lecomber@arm.com>
6038
6039         * f-exp.y (BINOP_INTRINSIC): New token.
6040         (exp): New parser rule handling BINOP_INTRINSIC.
6041         (f77_keywords): Add new builtin procedures.
6042         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6043         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6044         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6045         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6046         (print_unop_subexp_f): New function.
6047         (print_binop_subexp_f): New function.
6048         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6049         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6050         (dump_subexp_body_f): Likewise.
6051         (operator_check_f): Likewise.
6052         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6053         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6054
6055 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6058         UNOP_KIND.
6059         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6060         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6061         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6062         (operator_length_f): New fuction.
6063         (print_subexp_f): New function.
6064         (op_name_f): New function.
6065         (dump_subexp_body_f): New function.
6066         (operator_check_f): New function.
6067         (exp_descriptor_f): Replace standard expression handling functions
6068         with new functions.
6069         * gdb/fortran-operator.def: New file.
6070         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6071         * gdb/std-operator.def: Remove UNOP_KIND.
6072
6073 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6074
6075         * std-operator.def: Remove unbalanced, stray double quote
6076         character.
6077
6078 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6079             Chris January  <chris.january@arm.com>
6080             Daniel Everett  <daniel.everett@arm.com>
6081             Nick Forrington  <nick.forrington@arm.com>
6082             Richard Bunt  <richard.bunt@arm.com>
6083
6084         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6085         of depth when printing anonymous structs or unions.
6086         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6087         Don't print either the top-level value, or the children if the
6088         max-depth is exceeded.
6089         (ppscm_print_children): When printing the key of a map, allow one
6090         extra level of depth.
6091         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6092         print either the top-level value, or the children if the max-depth
6093         is exceeded.
6094         (print_children): When printing the key of a map, allow one extra
6095         level of depth.
6096         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6097         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6098         (user_print_options): Initialise max_depth field.
6099         (val_print_scalar_or_string_type_p): New function.
6100         (val_print): Check to see if the max depth has been reached.
6101         (val_print_check_max_depth): Define new function.
6102         (show_print_max_depth): New function.
6103         (_initialize_valprint): Add 'print max-depth' option.
6104         * valprint.h (struct value_print_options) <max_depth>: New field.
6105         (val_print_check_max_depth): Declare new function.
6106         * NEWS: Document new feature.
6107
6108 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * ada-lang.c (ada_language_defn): Initialise new field.
6111         * c-lang.c (c_is_string_type_p): New function.
6112         (c_language_defn): Initialise new field.
6113         (cplus_language_defn): Initialise new field.
6114         (asm_language_defn): Initialise new field.
6115         (minimal_language_defn): Initialise new field.
6116         * c-lang.h (c_is_string_type_p): Declare new function.
6117         * d-lang.c (d_language_defn): Initialise new field.
6118         * f-lang.c (f_is_string_type_p): New function.
6119         (f_language_defn): Initialise new field.
6120         * go-lang.c (go_is_string_type_p): New function.
6121         (go_language_defn): Initialise new field.
6122         * language.c (default_is_string_type_p): New function.
6123         (unknown_language_defn): Initialise new field.
6124         (auto_language_defn): Initialise new field.
6125         * language.h (struct language_defn) <la_is_string_type_p>: New
6126         member variable.
6127         (default_is_string_type_p): Declare new function.
6128         * m2-lang.c (m2_language_defn): Initialise new field.
6129         * objc-lang.c (objc_language_defn): Initialise new field.
6130         * opencl-lang.c (opencl_language_defn): Initialise new field.
6131         * p-lang.c (pascal_is_string_type_p): New function.
6132         (pascal_language_defn): Initialise new field.
6133         * rust-lang.c (rust_is_string_type_p): New function.
6134         (rust_language_defn): Initialise new field.
6135
6136 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6139         New field.
6140         * ada-lang.c (ada_language_defn): Initialise new field.
6141         * c-lang.c (c_language_defn): Likewise.
6142         (cplus_language_defn): Likewise.
6143         (asm_language_defn): Likewise.
6144         (minimal_language_defn): Likewise.
6145         * d-lang.c (d_language_defn): Likewise.
6146         * f-lang.c (f_language_defn): Likewise.
6147         * go-lang.c (go_language_defn): Likewise.
6148         * language.c (unknown_language_defn): Likewise.
6149         (auto_language_defn): Likewise.
6150         * m2-lang.c (m2_language_defn): Likewise.
6151         * objc-lang.c (objc_language_defn): Likewise.
6152         * opencl-lang.c (opencl_language_defn): Likewise.
6153         * p-lang.c (pascal_language_defn): Likewise.
6154         * rust-lang.c (rust_language_defn): Likewise.
6155
6156 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * ada-lang.c (ada_is_character_type): Change return type to bool.
6159         (ada_is_string_type): Likewise.
6160         * ada-lang.h (ada_is_character_type): Update declaration
6161         (ada_is_string_type): Likewise.
6162
6163 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6164
6165         Support style in 'frame|thread apply'
6166
6167         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6168         * record.c (record_start, record_stop): Update callers of
6169         execute_command_to_string with false.
6170         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6171         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6172         methods.
6173         (class string_file): New constructor with term_out parameter.
6174         Override methods term_out and can_emit_style_escape.  New member
6175         term_out.
6176         (class stdio_file): Override can_emit_style_escape.
6177         (class tee_file): Override term_out and can_emit_style_escape.
6178         * utils.h (can_emit_style_escape): Remove.
6179         * utils.c (can_emit_style_escape): Likewise.
6180         Update all callers of can_emit_style_escape (SOMESTREAM) to
6181         SOMESTREAM->can_emit_style_escape.
6182         * source-cache.c (source_cache::get_source_lines): Likewise.
6183         * stack.c (frame_apply_command_count): Call execute_command_to_string
6184         passing the term_out characteristic of the current gdb_stdout.
6185         * thread.c (thr_try_catch_cmd): Likewise.
6186         * top.c (execute_command_to_string): pass term_out parameter
6187         to construct the string_file for the command output.
6188         * ui-file.c (term_cli_styling): New function (most code moved
6189         from utils.c can_emit_style_escape).
6190         (string_file::string_file, string_file::can_emit_style_escape,
6191         stdio_file::can_emit_style_escape, tee_file::term_out,
6192         tee_file::can_emit_style_escape): New functions.
6193
6194 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6195
6196         * NEWS: Mention the new set|show may-call-functions.
6197         * infcall.c (may_call_functions_p): New variable.
6198         (show_may_call_functions_p): New function.
6199         (call_function_by_hand_dummy): Throws an error if not
6200         may-call-functions.
6201         (_initialize_infcall): Call add_setshow_boolean_cmd for
6202         may-call-functions.
6203
6204 2019-04-25  Keith Seitz  <keiths@redhat.com>
6205
6206         PR c++/24367
6207         * cp-support.c (inspect_type): Don't attempt substitutions
6208         of symbol with the same name.
6209
6210 2019-04-25  Tom Tromey  <tromey@adacore.com>
6211
6212         PR gdb/24475:
6213         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6214         static.
6215
6216 2019-04-25  Tom Tromey  <tromey@adacore.com>
6217
6218         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6219         rvalue reference.
6220         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6221         (gdb_xml_parser::parse): Use std::move.
6222         * python/python-internal.h (gdbpy_convert_exception): Take a const
6223         reference.
6224         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6225         std::move.
6226         * python/py-utils.c (gdbpy_convert_exception): Take a const
6227         reference.
6228         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6229         Use std::move.
6230         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6231         Use std::move.
6232         * mi/mi-main.c (mi_print_exception): Take a const reference.
6233         * main.c (handle_command_errors): Take a const reference.
6234         * linespec.c (parse_linespec): Use std::move.
6235         * infcall.c (run_inferior_call): Use std::move.
6236         (call_function_by_hand_dummy): Use std::move.
6237         * exec.c (try_open_exec_file): Use std::move.
6238         * exceptions.h (exception_print, exception_fprintf)
6239         (exception_print_same): Update.
6240         * exceptions.c (print_exception, exception_print)
6241         (exception_fprintf, exception_print_same): Change parameters to
6242         const reference.
6243         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6244         * common/new-op.c: Use std::move.
6245         * common/common-exceptions.h (struct gdb_exception): Add move
6246         constructor.
6247         (struct gdb_exception_error, struct gdb_exception_quit, struct
6248         gdb_quit_bad_alloc): Change constructor to move constructor.
6249         (throw_exception): Change parameter to rvalue reference.
6250         * common/common-exceptions.c (throw_exception): Take rvalue
6251         reference.
6252         * cli/cli-interp.c (safe_execute_command): Use std::move.
6253         * breakpoint.c (insert_bp_location, location_to_sals): Use
6254         std::move.
6255
6256 2019-04-25  Tom Tromey  <tromey@adacore.com>
6257
6258         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6259         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6260         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6261         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6262         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6263         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6264         guile/scm-value.c: Use unpack.
6265         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6266         gdbscm_gdb_exception.
6267         (gdbscm_throw_gdb_exception): Likewise.
6268         (struct gdbscm_gdb_exception): New.
6269         (unpack): New function.
6270         (gdbscm_wrap): Use unpack.
6271
6272 2019-04-25  Tom Tromey  <tromey@adacore.com>
6273
6274         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6275         (gdb_rl_callback_handler): Use std::move.
6276         * common/common-exceptions.h (struct gdb_exception): Add move
6277         assignment operator.
6278         (throw_exception_sjlj): Change "exception" to const reference.
6279         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6280         (throw_exception_sjlj): Change "exception" to const reference.
6281
6282 2019-04-25  Tom Tromey  <tromey@adacore.com>
6283
6284         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6285         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6286         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6287         Update.
6288         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6289         Update.
6290         * mi/mi-interp.c (mi_interp::exec): Update.
6291         * linespec.c (parse_linespec): Update.
6292         * infcall.c (run_inferior_call): Update.
6293         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6294         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6295         (gdbscm_lookup_global_symbol): Update.
6296         * guile/scm-param.c (gdbscm_parameter_value): Update.
6297         * guile/scm-frame.c (gdbscm_frame_read_register)
6298         (gdbscm_frame_read_var): Update.
6299         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6300         * exec.c (try_open_exec_file): Update.
6301         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6302         (gdb_rl_callback_handler): Update.
6303         * common/common-exceptions.h (exception_none): Don't declare.
6304         * common/common-exceptions.c (exception_none): Don't define.
6305         (struct catcher) <exception>: Update.
6306         * cli/cli-interp.c (safe_execute_command): Update.
6307         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6308
6309 2019-04-25  Ali Tamur  <tamur@google.com>
6310
6311         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6312         (read_attribute_value): Likewise.
6313         (dwarf2_read_addr_index): Update comment.
6314         (read_str_index): Add DW_FORM_strx.
6315         (dwarf2_string_attr): Likewise.
6316         (dwarf2_const_value_attr): Likewise.
6317         (dump_die_shallow): Likewise.
6318         (dwarf2_fetch_constant_bytes): Likewise.
6319         (skip_form_bytes): Likewise.
6320         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6321
6322 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6323
6324         PR corefiles/11608
6325         PR corefiles/18187
6326         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6327         OFFSET.  Verify if current mapping contains an ELF header.
6328         (linux_find_memory_regions_full): Adjust call to
6329         dump_mapping_p.
6330
6331 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6332             Kang Li <kanglictf@gmail.com>
6333
6334         PR gdb/21600
6335
6336         * dwarf2-frame.c (read_initial_length): Be consistent about using
6337         unsigned representation of length.
6338         (decode_frame_entry_1): Likewise.  Check for wraparound of
6339         end pointer as well as buffer overflow.
6340
6341 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6342
6343         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6344         "vq".
6345
6346 2019-04-24  Tom Tromey  <tromey@adacore.com>
6347
6348         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6349
6350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6351
6352         * s12z-tdep.c (s12z_unwind_pc): Delete.
6353         (s12z_unwind_sp): Delete.
6354         (s12z_gdbarch_init): Don't register deleted functions with
6355         gdbarch.
6356
6357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6358
6359         * rl78-tdep.c (rl78_unwind_sp): Delete.
6360         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6361
6362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6365         (xstormy16_unwind_pc): Delete.
6366         (xstormy16_dummy_id): Delete.
6367         (xstormy16_gdbarch_init): Don't register deleted functions with
6368         gdbarch.
6369
6370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * vax-tdep.c (vax_unwind_pc): Delete.
6373         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6374
6375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * v850-tdep.c (v850_unwind_sp): Delete.
6378         (v850_unwind_pc): Delete.
6379         (v850_dummy_id): Delete.
6380         (v850_gdbarch_init): Don't register deleted functions with
6381         gdbarch.
6382
6383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6384
6385         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6386         (tilegx_unwind_pc): Delete.
6387         (tilegx_unwind_dummy_id): Delete.
6388         (tilegx_gdbarch_init): Don't register deleted functions with
6389         gdbarch.
6390
6391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6392
6393         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6394         (tic6x_dummy_id): Delete.
6395         (tic6x_gdbarch_init): Don't register deleted functions with
6396         gdbarch.
6397
6398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6399
6400         * sparc-tdep.c (sparc_unwind_pc): Delete.
6401         (sparc32_gdbarch_init): Don't register deleted function with
6402         gdbarch.
6403
6404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * sh-tdep.c (sh_unwind_sp): Delete.
6407         (sh_unwind_pc): Delete.
6408         (sh_dummy_id): Delete.
6409         (sh_gdbarch_init): Don't register deleted functions with
6410         gdbarch.
6411
6412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6413
6414         * score-tdep.c (score_unwind_sp): Delete.
6415         (score_unwind_pc): Delete.
6416         (score_dummy_id): Delete.
6417         (score_gdbarch_init): Don't register deleted functions with
6418         gdbarch.
6419
6420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6421
6422         * rx-tdep.c (rx_unwind_pc): Delete.
6423         (rx_unwind_sp): Delete.
6424         (rx_dummy_id): Delete.
6425         (rx_gdbarch_init): Don't register deleted functions with
6426         gdbarch.  Update comment.
6427
6428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6429
6430         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6431         (rs6000_dummy_id): Delete.
6432         (rs6000_gdbarch_init): Don't register deleted functions with
6433         gdbarch.
6434
6435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6436
6437         * or1k-tdep.c (or1k_dummy_id): Delete.
6438         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6439
6440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6441
6442         * nios2-tdep.c (nios2_dummy_id): Delete.
6443         (nios2_unwind_sp): Delete.
6444         (nios2_gdbarch_init): Don't register deleted functions with
6445         gdbarch.
6446
6447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6448
6449         * nds32-tdep.c (nds32_dummy_id): Delete.
6450         (nds32_unwind_pc): Delete.
6451         (nds32_unwind_sp): Delete.
6452         (nds32_gdbarch_init): Don't register deleted functions with
6453         gdbarch.
6454
6455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6456
6457         * msp430-tdep.c (msp430_unwind_pc): Delete.
6458         (msp430_unwind_sp): Delete.
6459         (msp430_dummy_id): Delete.
6460         (msp430_gdbarch_init): Don't register deleted functions with
6461         gdbarch.
6462
6463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * moxie-tdep.c (moxie_unwind_sp): Delete.
6466         (moxie_unwind_pc): Delete.
6467         (moxie_dummy_id): Delete.
6468         (moxie_gdbarch_init): Don't register deleted functions with
6469         gdbarch.
6470
6471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6474         (mn10300_unwind_pc): Delete.
6475         (mn10300_unwind_sp): Delete.
6476         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6477         mn10300_unwind_sp.
6478         (mn10300_frame_unwind_init): Don't register deleted functions with
6479         gdbarch.
6480
6481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6482
6483         * mep-tdep.c (mep_unwind_pc): Delete.
6484         (mep_unwind_sp): Delete.
6485         (mep_dummy_id): Delete.
6486         (mep_gdbarch_init): Don't register deleted functions with
6487         gdbarch.
6488
6489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6492         (m68hc11_unwind_sp): Delete.
6493         (m68hc11_gdbarch_init): Don't register deleted functions with
6494         gdbarch.
6495
6496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * m32r-tdep.c (m32r_unwind_sp): Delete.
6499         (m32r_unwind_pc): Delete.
6500         (m32r_dummy_id): Delete.
6501         (m32r_gdbarch_init): Don't register deleted functions with
6502         gdbarch.
6503
6504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6505
6506         * m32c-tdep.c (m32c_unwind_pc): Delete.
6507         (m32c_unwind_sp): Delete.
6508         (m32c_dummy_id): Delete.
6509         (m32c_gdbarch_init): Don't register deleted functions with
6510         gdbarch.
6511
6512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6513
6514         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6515         (lm32_unwind_pc): Delete.
6516         (lm32_dummy_id): Delete.
6517         (lm32_gdbarch_init): Don't register deleted functions with
6518         gdbarch.
6519
6520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6521
6522         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6523         (iq2000_unwind_pc): Delete.
6524         (iq2000_dummy_id): Delete.
6525         (iq2000_gdbarch_init): Don't register deleted functions with
6526         gdbarch.
6527
6528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6529
6530         * nds32-tdep.c (nds32_type_align): Delete.
6531         (nds32_push_dummy_call): Use type_align instead.
6532
6533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6534
6535         * arm-tdep.c (arm_type_align): Only handle vector override case.
6536         (arm_push_dummy_call): Use type_align.
6537         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6538
6539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6540
6541         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6542         case.
6543         (pass_on_stack): Use type_align.
6544         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6545         function.
6546
6547 2019-04-23  Tom Tromey  <tromey@adacore.com>
6548
6549         * dwarf2read.c (line_header::file_name_at): Remove unused
6550         overload.
6551
6552 2019-04-23  Tom de Vries  <tdevries@suse.de>
6553
6554         PR gdb/24438
6555         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6556         invocation.
6557
6558
6559 2019-03-27  Ali Tamur  <tamur@google.com>
6560
6561         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6562         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6563         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6564         (dwarf_expr_context::get_addr_index): Likewise
6565         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6566         (symbol_needs_eval_context::get_addr_index): Likewise
6567         (disassemble_dwarf_expression): Add DW_OP_addrx
6568         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6569         (read_cutu_die_from_dwo): Update comment
6570         (skip_one_die): Add DW_FORM_addrx
6571         (read_attribute_value): Likewise
6572         (var_decode_location): Add DW_OP_addrx
6573         (dwarf2_const_value_attr): Add DW_FORM_addrx
6574         (dump_die_shallow): Likewise
6575         (dwarf2_fetch_constant_bytes): Likewise
6576         (decode_locdesc): Add DW_OP_addrx
6577         (skip_form_bytes): Add DW_FORM_addrx
6578
6579 2019-04-22  Ali Tamur  <tamur@google.com>
6580
6581         * MAINTAINERS (Write After Approval): Add self.
6582
6583 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6584
6585         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6586         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6587         (open_symbol_file_object): Likewise.
6588         (svr4_default_sos): Add info parameter.
6589         (svr4_read_so_list): Likewise.
6590         (svr4_current_sos_direct): Adjust functions calls to pass down
6591         info.
6592         (svr4_current_sos_1): Add info parameter.
6593         (svr4_current_sos): Call get_svr4_info, pass info down to
6594         svr4_current_sos_1.
6595         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6596         get_svr4_info.
6597         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6598         get_svr4_info.
6599         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6600         to get_svr4_info.
6601         (probes_table_remove_objfile_probes): Likewise.
6602         (register_solib_event_probe): Add info parameter.
6603         (solist_update_incremental): Pass info parameter down to
6604         svr4_read_so_list.
6605         (disable_probes_interface): Add info parameter.
6606         (svr4_handle_solib_event): Pass current_program_space to
6607         get_svr4_info.  Adjust disable_probes_interface cleanup.
6608         (svr4_create_probe_breakpoints): Add info parameter, pass it
6609         down to register_solib_event_probe.
6610         (svr4_create_solib_event_breakpoints): Add info parameter,
6611         pass it down to svr4_create_probe_breakpoints.
6612         (enable_break): Pass info down to
6613         svr4_create_solib_event_breakpoints.
6614         (svr4_solib_create_inferior_hook): Pass current_program_space to
6615         get_svr4_info.
6616         (svr4_clear_solib): Likewise.
6617
6618 2019-04-22  Pedro Alves  <palves@redhat.com>
6619
6620         * solib-svr4.c (svr4_free_objfile_observer): New.
6621         (probe_and_action::objfile): New field.
6622         (probes_table_htab_remove_objfile_probes)
6623         (probes_table_remove_objfile_probes): New functions.
6624         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6625         in the new probe_and_action.  Don't store the probe in 'lookup'.
6626         (svr4_create_probe_breakpoints): Pass objfile to
6627         register_solib_event_probe.
6628         (_initialize_svr4_solib): Register a free_objfile observer.
6629
6630 2019-04-19  Tom Tromey  <tom@tromey.com>
6631
6632         * common/queue.h: Remove.
6633
6634 2019-04-19  Tom Tromey  <tom@tromey.com>
6635
6636         * event-loop.c: Don't include "common/queue.h".
6637
6638 2019-04-19  Tom Tromey  <tom@tromey.com>
6639
6640         * remote.c (remote_target): Use delete.
6641         * remote-notif.h: Include <list>, not "common/queue.h".
6642         (notif_client_p): Remove typedef.
6643         (remote_notif_state): Add constructor, destructor, initializer.
6644         <notif_queue>: Now a std::list.
6645         (remote_notif_state_xfree): Don't declare.
6646         * remote-notif.c (remote_notif_process, handle_notification)
6647         (remote_notif_state_allocate): Update.
6648         (~remote_notif_state): Rename from remote_notif_state_xfree.
6649
6650 2019-04-19  Tom Tromey  <tom@tromey.com>
6651
6652         * symfile.c (reread_symbols): Update.
6653         * objfiles.c (objfile_register_static_link)
6654         (objfile_lookup_static_link): Update
6655         (~objfile) Don't delete static_links.
6656         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6657
6658 2019-04-19  Tom Tromey  <tom@tromey.com>
6659
6660         * type-stack.h (struct type_stack) <insert>: Constify string.
6661         * type-stack.c (type_stack::insert): Constify string.
6662         * gdbtypes.h (lookup_template_type): Update.
6663         (address_space_name_to_int): Update.
6664         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6665         const.
6666         (lookup_template_type): Make name const.
6667         * c-exp.y: Update rules.
6668         (lex_one_token, classify_name, classify_inner_name)
6669         (c_print_token): Update.
6670         * p-exp.y: Update rules.
6671         (yylex): Update.
6672         * f-exp.y: Update rules.
6673         (yylex): Update.
6674         * d-exp.y: Update rules.
6675         (lex_one_token, classify_name, classify_inner_name): Update.
6676         * parse.c (write_dollar_variable, copy_name): Return std::string.
6677         * parser-defs.h (copy_name): Change return type.
6678         * m2-exp.y: Update rules.
6679         (yylex): Update.
6680         * go-exp.y (lex_one_token): Update.
6681         Update rules.
6682         (classify_unsafe_function, classify_packaged_name)
6683         (classify_name, yylex): Update.
6684
6685 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6686
6687         * configure.ac: add --enable-source-highlight switch.
6688         * configure: Regenerate.
6689         * top.c (print_gdb_version): plumb --enable-source-highlight
6690         status to "show configuration".
6691
6692 2019-04-19  Tom Tromey  <tromey@adacore.com>
6693
6694         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6695         Check ADA_TYPE_P.
6696         (empty_record, ada_template_to_fixed_record_type_1)
6697         (template_to_static_fixed_type)
6698         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6699         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6700         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6701         macros.
6702
6703 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6704
6705         PR symtab/24423:
6706         * source.c (print_source_lines_base): Advance "iter" when a
6707         control character is seen.
6708
6709 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6710
6711         * inferior.h (struct infcall_suspend_state_deleter):
6712         Catch exception in destructor to avoid crash.
6713
6714 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6715
6716         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6717         close to the add_com "shell".
6718
6719 2019-04-18  Tom Tromey  <tromey@adacore.com>
6720
6721         * process-stratum-target.h (class process_stratum_target)
6722         <stratum>: Add "final".
6723
6724 2019-04-17  Tom Tromey  <tromey@adacore.com>
6725
6726         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6727         against nullptr before use.
6728
6729 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6730
6731         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6732
6733 2019-04-17  Jim Wilson  <jimw@sifive.com>
6734             Andrew Burgess  <andrew.burgess@embecosm.com>
6735
6736         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6737         code read might fail, assume 4-byte breakpoint in that case.
6738
6739 2019-04-15  Leszek Swirski  <leszeks@google.com>
6740
6741         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6742         rather than a hand-rolled POD check when checking for forced MEMORY
6743         classification.
6744
6745 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6746
6747         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6748         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6749         function.
6750         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6751         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6752         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6753         declaration.
6754
6755 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6756
6757         * aarch64-linux-nat.c
6758         (aarch64_linux_nat_target::thread_architecture): Add override.
6759         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6760         each VQ.
6761
6762 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6763
6764         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6765
6766 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6767
6768         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6769         target types of size 96-bits, add some additional comments, and
6770         check that the builtin type we found was the correct size.
6771
6772 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6773
6774         * utils.c (prompt_for_continue): Don't restore the styling at the
6775         end, as applied_style has the wrong value.  This fixes styling in
6776         long lists of file names that are interrupted by the "Continue?"
6777         prompt.
6778
6779 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6780
6781         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6782         * c-lang.c (c_language_defn): Likewise.
6783         (cplus_language_defn): Likewise.
6784         (asm_language_defn): Likewise.
6785         (minimal_language_defn): Likewise.
6786         * d-lang.c (d_language_defn): Likewise.
6787         * f-lang.c (f_language_defn): Likewise.
6788         * go-lang.c (go_language_defn): Likewise.
6789         * language.c (unknown_language_defn): Likewise.
6790         (auto_language_defn): Likewise.
6791         * language.h (struct language_defn): Remove la_magic field.
6792         (LANG_MAGIC): Delete.
6793         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6794         * objc-lang.c (objc_language_defn): Likewise.
6795         * opencl-lang.c (opencl_language_defn): Likewise.
6796         * p-lang.c (pascal_language_defn): Likewise.
6797         * rust-lang.c (rust_language_defn): Likewise.
6798
6799 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6800
6801         * riscv-tdep.c (riscv_type_align): New function.
6802         (riscv_type_alignment): Delete.
6803         (riscv_arg_location): Use 'type_align'.
6804         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6805
6806 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * gdbtypes.c (type_align): A struct with no non-static fields also
6809         has alignment of 1.
6810
6811 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6812
6813         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6814         component to 0.
6815         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6816         member.
6817         (riscv_struct_info::analyse): New implementation using new
6818         analyse_inner member function.
6819         (riscv_struct_info::field_offset): New member function.
6820         (riscv_struct_info::m_offsets): New member variable.
6821         (riscv_struct_info::analyse_inner): New private member function,
6822         takes the old implementation of riscv_struct_info::analyse but
6823         extended to track field offsets.
6824         (riscv_call_arg_struct): Update the struct folding special cases
6825         to handle cases where empty C++ structs, which are non-zero
6826         length, are found.
6827         (riscv_arg_location): Initialise the length of each location, a
6828         non-zero length now indicates the location is in use.
6829         (riscv_push_dummy_call): Allow for the first location having a
6830         non-zero offset when setting up arguments.
6831         (riscv_return_value): Likewise, but for return values.
6832
6833 2019-04-11  Tom Tromey  <tromey@adacore.com>
6834
6835         * utils.c (internal_vproblem): Make "msg" const.
6836
6837 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6838
6839         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6840         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6841         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6842         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6843
6844 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6845
6846         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6847         function.
6848         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6849         of amd64_collect_native_gregset.
6850         (amd64_linux_nat_target::store_registers): Likewise.
6851
6852 2019-04-10  Tom Tromey  <tom@tromey.com>
6853
6854         * symtab.c (lookup_global_symbol_from_objfile)
6855         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6856         * objfiles.h (class separate_debug_iterator): New.
6857         (class separate_debug_range): New.
6858         (struct objfile) <separate_debug_objfiles>: New method.
6859         (objfile_separate_debug_iterate): Don't declare.
6860         * objfiles.c (separate_debug_iterator::operator++): Rename from
6861         objfile_separate_debug_iterate.
6862         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6863         iterator.
6864         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6865         iterator.
6866
6867 2019-04-10  Tom Tromey  <tom@tromey.com>
6868
6869         * symfile.c (reread_symbols): Remove old comment.
6870         * objfiles.c (free_all_objfiles): Fix a typo.
6871
6872 2019-04-10  Tom Tromey  <tom@tromey.com>
6873
6874         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6875         * minsyms.c (lookup_minimal_symbol): Use foreach.
6876         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6877         (lookup_minimal_symbol_solib_trampoline): Likewise.
6878         * symfile.c (reread_symbols): Use foreach.
6879
6880 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6881             Tom Tromey  <tromey@adacore.com>
6882
6883         PR rust/24414:
6884         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6885         (rust_lex_int_test): Change "value" to be LONGEST.
6886         (rust_lex_tests): Add test for long integer literal.
6887
6888 2019-04-09  Tom Tromey  <tromey@adacore.com>
6889
6890         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6891         to bool.
6892         (extended_remote_target::attach): Update.
6893         (remote_target::remote_notice_new_inferior): Update.
6894         (remote_target::add_current_inferior_and_thread): Update.
6895         * inferior.c (exit_inferior_1): Use "false".
6896         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6897
6898 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6899
6900         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6901         the "start" command.
6902
6903 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6904
6905         * python/py-inferior.c (infpy_thread_from_thread_handle):
6906         Adjust comments to reflect renaming of thread_from_thread_handle
6907         to thread_from_handle.  Adjust keywords.  Fix type error message.
6908         (inferior_object_methods): Add thread_from_handle.  Retain
6909         thread_from_thread_handle, but mark it as deprecated.
6910
6911 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6912
6913         * gdbthread.h (find_thread_by_handle): Revise declaration.
6914         * thread.c (find_thread_by_handle): Likewise.  Adjust
6915         implementation too.
6916         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6917         support for buffer objects as handles.
6918
6919 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6920
6921         * python/py-infthread.c (thpy_thread_handle): New function.
6922         (thread_object_methods): Register thpy_thread_handle.
6923
6924 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6925
6926         * gdbthread.h (thread_to_thread_handle): Declare.
6927         * thread.c (gdbtypes.h): Include.
6928         (thread_to_thread_handle): New function.
6929
6930         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6931         (target_thread_info_to_thread_handle): Declare.
6932         * target.c (target_thread_info_to_thread_handle): New function.
6933         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6934         * target-delegates.c: Regenerate.
6935
6936         * linux-thread-db.c (class thread_db_target): Add method
6937         thread_info_to_thread_handle.
6938         (thread_db_target::thread_info_to_thread_handle): Define.
6939         * remote.c (class remote_target): Add new method
6940         thread_info_to_thread_handle.
6941         (remote_target::thread_info_to_thread_handle): Define.
6942
6943 2019-04-08  Pedro Alves  <palves@redhat.com>
6944
6945         * common/common-exceptions.c (throw_exception): Don't create
6946         named object to throw; throw directly.
6947         (throw_it): Likewise.  Don't initialize gdb_exception::message
6948         here, with new; pass FMT and AP to the ctor instead.
6949         * common/common-exceptions.h: Include <string>.
6950         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6951         const char *, va_list)): New ctor.  Use std::make_shared.
6952         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6953         errors)): Delete.
6954         (gdb_exception_error::gdb_exception_error(enum errors, const char
6955         *, va_list)): New.
6956         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6957         Add assertion.
6958         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6959         errors)): Delete.
6960         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6961         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6962         Add assertion.
6963
6964 2019-04-08  Tom Tromey  <tom@tromey.com>
6965
6966         * valops.c (value_rtti_indirect_type): Replace throw_exception
6967         with throw.
6968         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6969         with throw.
6970         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6971         throw.
6972         * target.c (target_translate_tls_address): Replace throw_exception
6973         with throw.
6974         * stack.c (frame_apply_command_count): Replace throw_exception
6975         with throw.
6976         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6977         throw.
6978         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6979         with throw.
6980         * rs6000-tdep.c (rs6000_frame_cache)
6981         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6982         * remote.c: Replace throw_exception with throw.
6983         * record-full.c (record_full_message, record_full_wait_1)
6984         (record_full_restore): Replace throw_exception with throw.
6985         * record-btrace.c:
6986         (get_thread_current_frame_id, record_btrace_start_replaying)
6987         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6988         (cmd_record_btrace_start): Replace throw_exception with throw.
6989         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6990         throw.
6991         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6992         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6993         * linespec.c:
6994         (find_linespec_symbols): Replace throw_exception with throw.
6995         * infrun.c (displaced_step_prepare, resume): Replace
6996         throw_exception with throw.
6997         * infcmd.c (post_create_inferior): Replace throw_exception with
6998         throw.
6999         * inf-loop.c (inferior_event_handler): Replace throw_exception
7000         with throw.
7001         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7002         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7003         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7004         (get_prev_frame_always, get_frame_pc_if_available)
7005         (get_frame_address_in_block_if_available, get_frame_language):
7006         Replace throw_exception with throw.
7007         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7008         throw_exception with throw.
7009         * eval.c (fetch_subexp_value, evaluate_var_value)
7010         (evaluate_funcall, evaluate_subexp_standard): Replace
7011         throw_exception with throw.
7012         * dwarf2loc.c (call_site_find_chain)
7013         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7014         Replace throw_exception with throw.
7015         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7016         with throw.
7017         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7018         throw.
7019         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7020         * completer.c (complete_line_internal): Replace throw_exception
7021         with throw.
7022         * compile/compile-object-run.c (compile_object_run): Replace
7023         throw_exception with throw.
7024         * cli/cli-script.c (process_next_line): Replace throw_exception
7025         with throw.
7026         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7027         (btrace_enable, btrace_maint_update_pt_packets): Replace
7028         throw_exception with throw.
7029         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7030         throw_exception with throw.
7031         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7032         throw_exception with throw.
7033         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7034         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7035         * aarch64-tdep.c (aarch64_make_prologue_cache)
7036         (aarch64_make_stub_cache): Replace throw_exception with throw.
7037
7038 2019-04-08  Tom Tromey  <tom@tromey.com>
7039
7040         * common/common-exceptions.c (throw_exception): Rename from
7041         throw_exception_cxx.  Remove old copy.  Make argument const.
7042         (throw_it): Create and throw exception objects directly.
7043         * common/common-exceptions.h (throw_exception): Make argument
7044         const.
7045         (struct gdb_exception_error): Add constructor.
7046         (struct gdb_exception_quit): Add constructor.
7047
7048 2019-04-08  Tom Tromey  <tom@tromey.com>
7049
7050         * common/common-exceptions.h (exception_rethrow): Don't declare.
7051         (TRY_SJLJ): Update comment.
7052         (TRY, CATCH, END_CATCH): Remove.
7053         * common/common-exceptions.c (exception_rethrow): Remove.
7054
7055 2019-04-08  Tom Tromey  <tom@tromey.com>
7056
7057         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7058         Remove.
7059         (gdb_exception_error): Rename from
7060         gdb_exception_RETURN_MASK_ERROR.
7061         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7062         (gdb_quit_bad_alloc): Update.
7063         * aarch64-tdep.c: Update.
7064         * ada-lang.c: Update.
7065         * ada-typeprint.c: Update.
7066         * ada-valprint.c: Update.
7067         * amd64-tdep.c: Update.
7068         * arch-utils.c: Update.
7069         * break-catch-throw.c: Update.
7070         * breakpoint.c: Update.
7071         * btrace.c: Update.
7072         * c-varobj.c: Update.
7073         * cli/cli-cmds.c: Update.
7074         * cli/cli-interp.c: Update.
7075         * cli/cli-script.c: Update.
7076         * common/common-exceptions.c: Update.
7077         * common/new-op.c: Update.
7078         * common/selftest.c: Update.
7079         * compile/compile-c-symbols.c: Update.
7080         * compile/compile-cplus-symbols.c: Update.
7081         * compile/compile-object-load.c: Update.
7082         * compile/compile-object-run.c: Update.
7083         * completer.c: Update.
7084         * corelow.c: Update.
7085         * cp-abi.c: Update.
7086         * cp-support.c: Update.
7087         * cp-valprint.c: Update.
7088         * darwin-nat.c: Update.
7089         * disasm-selftests.c: Update.
7090         * dtrace-probe.c: Update.
7091         * dwarf-index-cache.c: Update.
7092         * dwarf-index-write.c: Update.
7093         * dwarf2-frame-tailcall.c: Update.
7094         * dwarf2-frame.c: Update.
7095         * dwarf2loc.c: Update.
7096         * dwarf2read.c: Update.
7097         * eval.c: Update.
7098         * event-loop.c: Update.
7099         * event-top.c: Update.
7100         * exec.c: Update.
7101         * f-valprint.c: Update.
7102         * fbsd-tdep.c: Update.
7103         * frame-unwind.c: Update.
7104         * frame.c: Update.
7105         * gdbtypes.c: Update.
7106         * gnu-v3-abi.c: Update.
7107         * guile/guile-internal.h: Update.
7108         * guile/scm-block.c: Update.
7109         * guile/scm-breakpoint.c: Update.
7110         * guile/scm-cmd.c: Update.
7111         * guile/scm-disasm.c: Update.
7112         * guile/scm-frame.c: Update.
7113         * guile/scm-lazy-string.c: Update.
7114         * guile/scm-math.c: Update.
7115         * guile/scm-param.c: Update.
7116         * guile/scm-ports.c: Update.
7117         * guile/scm-pretty-print.c: Update.
7118         * guile/scm-symbol.c: Update.
7119         * guile/scm-symtab.c: Update.
7120         * guile/scm-type.c: Update.
7121         * guile/scm-value.c: Update.
7122         * i386-linux-tdep.c: Update.
7123         * i386-tdep.c: Update.
7124         * inf-loop.c: Update.
7125         * infcall.c: Update.
7126         * infcmd.c: Update.
7127         * infrun.c: Update.
7128         * jit.c: Update.
7129         * language.c: Update.
7130         * linespec.c: Update.
7131         * linux-fork.c: Update.
7132         * linux-nat.c: Update.
7133         * linux-tdep.c: Update.
7134         * linux-thread-db.c: Update.
7135         * main.c: Update.
7136         * mi/mi-cmd-break.c: Update.
7137         * mi/mi-cmd-stack.c: Update.
7138         * mi/mi-interp.c: Update.
7139         * mi/mi-main.c: Update.
7140         * objc-lang.c: Update.
7141         * p-valprint.c: Update.
7142         * parse.c: Update.
7143         * ppc-linux-tdep.c: Update.
7144         * printcmd.c: Update.
7145         * python/py-arch.c: Update.
7146         * python/py-breakpoint.c: Update.
7147         * python/py-cmd.c: Update.
7148         * python/py-finishbreakpoint.c: Update.
7149         * python/py-frame.c: Update.
7150         * python/py-framefilter.c: Update.
7151         * python/py-gdb-readline.c: Update.
7152         * python/py-inferior.c: Update.
7153         * python/py-infthread.c: Update.
7154         * python/py-lazy-string.c: Update.
7155         * python/py-linetable.c: Update.
7156         * python/py-objfile.c: Update.
7157         * python/py-param.c: Update.
7158         * python/py-prettyprint.c: Update.
7159         * python/py-progspace.c: Update.
7160         * python/py-record-btrace.c: Update.
7161         * python/py-record.c: Update.
7162         * python/py-symbol.c: Update.
7163         * python/py-type.c: Update.
7164         * python/py-unwind.c: Update.
7165         * python/py-utils.c: Update.
7166         * python/py-value.c: Update.
7167         * python/python.c: Update.
7168         * record-btrace.c: Update.
7169         * record-full.c: Update.
7170         * remote-fileio.c: Update.
7171         * remote.c: Update.
7172         * riscv-tdep.c: Update.
7173         * rs6000-aix-tdep.c: Update.
7174         * rs6000-tdep.c: Update.
7175         * rust-exp.y: Update.
7176         * rust-lang.c: Update.
7177         * s390-tdep.c: Update.
7178         * selftest-arch.c: Update.
7179         * solib-dsbt.c: Update.
7180         * solib-frv.c: Update.
7181         * solib-spu.c: Update.
7182         * solib-svr4.c: Update.
7183         * solib.c: Update.
7184         * sparc64-linux-tdep.c: Update.
7185         * stack.c: Update.
7186         * symfile-mem.c: Update.
7187         * symmisc.c: Update.
7188         * target.c: Update.
7189         * thread.c: Update.
7190         * top.c: Update.
7191         * tracefile-tfile.c: Update.
7192         * tui/tui.c: Update.
7193         * typeprint.c: Update.
7194         * unittests/cli-utils-selftests.c: Update.
7195         * unittests/parse-connection-spec-selftests.c: Update.
7196         * valops.c: Update.
7197         * valprint.c: Update.
7198         * value.c: Update.
7199         * varobj.c: Update.
7200         * windows-nat.c: Update.
7201         * x86-linux-nat.c: Update.
7202         * xml-support.c: Update.
7203
7204 2019-04-08  Tom Tromey  <tom@tromey.com>
7205
7206         * xml-support.c: Use C++ exception handling.
7207         * x86-linux-nat.c: Use C++ exception handling.
7208         * windows-nat.c: Use C++ exception handling.
7209         * varobj.c: Use C++ exception handling.
7210         * value.c: Use C++ exception handling.
7211         * valprint.c: Use C++ exception handling.
7212         * valops.c: Use C++ exception handling.
7213         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7214         handling.
7215         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7216         * typeprint.c: Use C++ exception handling.
7217         * tui/tui.c: Use C++ exception handling.
7218         * tracefile-tfile.c: Use C++ exception handling.
7219         * top.c: Use C++ exception handling.
7220         * thread.c: Use C++ exception handling.
7221         * target.c: Use C++ exception handling.
7222         * symmisc.c: Use C++ exception handling.
7223         * symfile-mem.c: Use C++ exception handling.
7224         * stack.c: Use C++ exception handling.
7225         * sparc64-linux-tdep.c: Use C++ exception handling.
7226         * solib.c: Use C++ exception handling.
7227         * solib-svr4.c: Use C++ exception handling.
7228         * solib-spu.c: Use C++ exception handling.
7229         * solib-frv.c: Use C++ exception handling.
7230         * solib-dsbt.c: Use C++ exception handling.
7231         * selftest-arch.c: Use C++ exception handling.
7232         * s390-tdep.c: Use C++ exception handling.
7233         * rust-lang.c: Use C++ exception handling.
7234         * rust-exp.y: Use C++ exception handling.
7235         * rs6000-tdep.c: Use C++ exception handling.
7236         * rs6000-aix-tdep.c: Use C++ exception handling.
7237         * riscv-tdep.c: Use C++ exception handling.
7238         * remote.c: Use C++ exception handling.
7239         * remote-fileio.c: Use C++ exception handling.
7240         * record-full.c: Use C++ exception handling.
7241         * record-btrace.c: Use C++ exception handling.
7242         * python/python.c: Use C++ exception handling.
7243         * python/py-value.c: Use C++ exception handling.
7244         * python/py-utils.c: Use C++ exception handling.
7245         * python/py-unwind.c: Use C++ exception handling.
7246         * python/py-type.c: Use C++ exception handling.
7247         * python/py-symbol.c: Use C++ exception handling.
7248         * python/py-record.c: Use C++ exception handling.
7249         * python/py-record-btrace.c: Use C++ exception handling.
7250         * python/py-progspace.c: Use C++ exception handling.
7251         * python/py-prettyprint.c: Use C++ exception handling.
7252         * python/py-param.c: Use C++ exception handling.
7253         * python/py-objfile.c: Use C++ exception handling.
7254         * python/py-linetable.c: Use C++ exception handling.
7255         * python/py-lazy-string.c: Use C++ exception handling.
7256         * python/py-infthread.c: Use C++ exception handling.
7257         * python/py-inferior.c: Use C++ exception handling.
7258         * python/py-gdb-readline.c: Use C++ exception handling.
7259         * python/py-framefilter.c: Use C++ exception handling.
7260         * python/py-frame.c: Use C++ exception handling.
7261         * python/py-finishbreakpoint.c: Use C++ exception handling.
7262         * python/py-cmd.c: Use C++ exception handling.
7263         * python/py-breakpoint.c: Use C++ exception handling.
7264         * python/py-arch.c: Use C++ exception handling.
7265         * printcmd.c: Use C++ exception handling.
7266         * ppc-linux-tdep.c: Use C++ exception handling.
7267         * parse.c: Use C++ exception handling.
7268         * p-valprint.c: Use C++ exception handling.
7269         * objc-lang.c: Use C++ exception handling.
7270         * mi/mi-main.c: Use C++ exception handling.
7271         * mi/mi-interp.c: Use C++ exception handling.
7272         * mi/mi-cmd-stack.c: Use C++ exception handling.
7273         * mi/mi-cmd-break.c: Use C++ exception handling.
7274         * main.c: Use C++ exception handling.
7275         * linux-thread-db.c: Use C++ exception handling.
7276         * linux-tdep.c: Use C++ exception handling.
7277         * linux-nat.c: Use C++ exception handling.
7278         * linux-fork.c: Use C++ exception handling.
7279         * linespec.c: Use C++ exception handling.
7280         * language.c: Use C++ exception handling.
7281         * jit.c: Use C++ exception handling.
7282         * infrun.c: Use C++ exception handling.
7283         * infcmd.c: Use C++ exception handling.
7284         * infcall.c: Use C++ exception handling.
7285         * inf-loop.c: Use C++ exception handling.
7286         * i386-tdep.c: Use C++ exception handling.
7287         * i386-linux-tdep.c: Use C++ exception handling.
7288         * guile/scm-value.c: Use C++ exception handling.
7289         * guile/scm-type.c: Use C++ exception handling.
7290         * guile/scm-symtab.c: Use C++ exception handling.
7291         * guile/scm-symbol.c: Use C++ exception handling.
7292         * guile/scm-pretty-print.c: Use C++ exception handling.
7293         * guile/scm-ports.c: Use C++ exception handling.
7294         * guile/scm-param.c: Use C++ exception handling.
7295         * guile/scm-math.c: Use C++ exception handling.
7296         * guile/scm-lazy-string.c: Use C++ exception handling.
7297         * guile/scm-frame.c: Use C++ exception handling.
7298         * guile/scm-disasm.c: Use C++ exception handling.
7299         * guile/scm-cmd.c: Use C++ exception handling.
7300         * guile/scm-breakpoint.c: Use C++ exception handling.
7301         * guile/scm-block.c: Use C++ exception handling.
7302         * guile/guile-internal.h: Use C++ exception handling.
7303         * gnu-v3-abi.c: Use C++ exception handling.
7304         * gdbtypes.c: Use C++ exception handling.
7305         * frame.c: Use C++ exception handling.
7306         * frame-unwind.c: Use C++ exception handling.
7307         * fbsd-tdep.c: Use C++ exception handling.
7308         * f-valprint.c: Use C++ exception handling.
7309         * exec.c: Use C++ exception handling.
7310         * event-top.c: Use C++ exception handling.
7311         * event-loop.c: Use C++ exception handling.
7312         * eval.c: Use C++ exception handling.
7313         * dwarf2read.c: Use C++ exception handling.
7314         * dwarf2loc.c: Use C++ exception handling.
7315         * dwarf2-frame.c: Use C++ exception handling.
7316         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7317         * dwarf-index-write.c: Use C++ exception handling.
7318         * dwarf-index-cache.c: Use C++ exception handling.
7319         * dtrace-probe.c: Use C++ exception handling.
7320         * disasm-selftests.c: Use C++ exception handling.
7321         * darwin-nat.c: Use C++ exception handling.
7322         * cp-valprint.c: Use C++ exception handling.
7323         * cp-support.c: Use C++ exception handling.
7324         * cp-abi.c: Use C++ exception handling.
7325         * corelow.c: Use C++ exception handling.
7326         * completer.c: Use C++ exception handling.
7327         * compile/compile-object-run.c: Use C++ exception handling.
7328         * compile/compile-object-load.c: Use C++ exception handling.
7329         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7330         * compile/compile-c-symbols.c: Use C++ exception handling.
7331         * common/selftest.c: Use C++ exception handling.
7332         * common/new-op.c: Use C++ exception handling.
7333         * cli/cli-script.c: Use C++ exception handling.
7334         * cli/cli-interp.c: Use C++ exception handling.
7335         * cli/cli-cmds.c: Use C++ exception handling.
7336         * c-varobj.c: Use C++ exception handling.
7337         * btrace.c: Use C++ exception handling.
7338         * breakpoint.c: Use C++ exception handling.
7339         * break-catch-throw.c: Use C++ exception handling.
7340         * arch-utils.c: Use C++ exception handling.
7341         * amd64-tdep.c: Use C++ exception handling.
7342         * ada-valprint.c: Use C++ exception handling.
7343         * ada-typeprint.c: Use C++ exception handling.
7344         * ada-lang.c: Use C++ exception handling.
7345         * aarch64-tdep.c: Use C++ exception handling.
7346
7347 2019-04-08  Tom Tromey  <tom@tromey.com>
7348
7349         * xml-support.c (gdb_xml_parser::parse): Update.
7350         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7351         * value.c (show_convenience): Update.
7352         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7353         (test_parse_flags_qcs): Update.
7354         * thread.c (thr_try_catch_cmd): Update.
7355         * target.c (target_translate_tls_address): Update.
7356         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7357         (info_frame_command_core, frame_apply_command_count): Update.
7358         * rust-exp.y (rust_lex_exception_test): Update.
7359         * riscv-tdep.c (riscv_print_one_register_info): Update.
7360         * remote.c (remote_target::enable_btrace): Update.
7361         * record-btrace.c (record_btrace_enable_warn): Update.
7362         * python/py-utils.c (gdbpy_convert_exception): Update.
7363         * printcmd.c (do_one_display, print_variable_and_value): Update.
7364         * mi/mi-main.c (mi_print_exception): Update.
7365         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7366         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7367         * linux-nat.c (linux_nat_target::attach): Update.
7368         * linux-fork.c (class scoped_switch_fork_info): Update.
7369         * infrun.c (displaced_step_prepare): Update.
7370         * infcall.c (call_function_by_hand_dummy): Update.
7371         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7372         * gnu-v3-abi.c (print_one_vtable): Update.
7373         * frame.c (get_prev_frame_always): Update.
7374         * f-valprint.c (info_common_command_for_block): Update.
7375         * exec.c (try_open_exec_file): Update.
7376         * exceptions.c (print_exception, exception_print)
7377         (exception_fprintf, exception_print_same): Update.
7378         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7379         * dwarf-index-cache.c (index_cache::store)
7380         (index_cache::lookup_gdb_index): Update.
7381         * darwin-nat.c (maybe_cache_shell): Update.
7382         * cp-valprint.c (cp_print_value_fields): Update.
7383         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7384         (gcc_cplus_symbol_address): Update.
7385         * compile/compile-c-symbols.c (gcc_convert_symbol)
7386         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7387         * common/selftest.c: Update.
7388         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7389         a std::string.
7390         (exception_try_scope_entry, exception_try_scope_exit): Don't
7391         declare.
7392         (struct exception_try_scope): Remove.
7393         (TRY): Don't use exception_try_scope.
7394         (struct gdb_exception): Add constructor, operator=.
7395         <what>: New method.
7396         (struct gdb_exception_RETURN_MASK_ALL)
7397         (struct gdb_exception_RETURN_MASK_ERROR)
7398         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7399         (struct gdb_quit_bad_alloc): Update.
7400         * common/common-exceptions.c (exception_none): Change
7401         initializer.
7402         (struct catcher) <state, exception>: Initialize inline.
7403         <prev>: Remove member.
7404         (current_catcher): Remove.
7405         (catchers): New global.
7406         (exceptions_state_mc_init): Simplify.
7407         (catcher_pop): Remove.
7408         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7409         (try_scope_depth, exception_try_scope_entry)
7410         (exception_try_scope_exit): Remove.
7411         (throw_exception_sjlj): Update.
7412         (exception_messages, exception_messages_size): Remove.
7413         (throw_it): Simplify.
7414         (gdb_exception_sliced_copy): Remove.
7415         (throw_exception_cxx): Update.
7416         * cli/cli-script.c (script_from_file): Update.
7417         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7418         Update.
7419         * ada-valprint.c (ada_val_print): Update.
7420         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7421         (create_excep_cond_exprs): Update.
7422
7423 2019-04-08  Tom Tromey  <tom@tromey.com>
7424
7425         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7426         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7427         (TRY, CATCH, END_CATCH): Remove some definitions.
7428         * common/common-exceptions.c: Don't use GDB_XCPT.
7429         (catcher_list_size): Remove.
7430         (throw_exception, throw_it): Simplify.
7431
7432 2019-04-05  Tom Tromey  <tom@tromey.com>
7433
7434         Revert the header-sorting patch.
7435         * ft32-tdep.c: Revert.
7436         * frv-tdep.c: Revert.
7437         * frv-linux-tdep.c: Revert.
7438         * frame.c: Revert.
7439         * frame-unwind.c: Revert.
7440         * frame-base.c: Revert.
7441         * fork-child.c: Revert.
7442         * findvar.c: Revert.
7443         * findcmd.c: Revert.
7444         * filesystem.c: Revert.
7445         * filename-seen-cache.h: Revert.
7446         * filename-seen-cache.c: Revert.
7447         * fbsd-tdep.c: Revert.
7448         * fbsd-nat.h: Revert.
7449         * fbsd-nat.c: Revert.
7450         * f-valprint.c: Revert.
7451         * f-typeprint.c: Revert.
7452         * f-lang.c: Revert.
7453         * extension.h: Revert.
7454         * extension.c: Revert.
7455         * extension-priv.h: Revert.
7456         * expprint.c: Revert.
7457         * exec.h: Revert.
7458         * exec.c: Revert.
7459         * exceptions.c: Revert.
7460         * event-top.c: Revert.
7461         * event-loop.c: Revert.
7462         * eval.c: Revert.
7463         * elfread.c: Revert.
7464         * dwarf2read.h: Revert.
7465         * dwarf2read.c: Revert.
7466         * dwarf2loc.c: Revert.
7467         * dwarf2expr.h: Revert.
7468         * dwarf2expr.c: Revert.
7469         * dwarf2-frame.c: Revert.
7470         * dwarf2-frame-tailcall.c: Revert.
7471         * dwarf-index-write.h: Revert.
7472         * dwarf-index-write.c: Revert.
7473         * dwarf-index-common.c: Revert.
7474         * dwarf-index-cache.h: Revert.
7475         * dwarf-index-cache.c: Revert.
7476         * dummy-frame.c: Revert.
7477         * dtrace-probe.c: Revert.
7478         * disasm.h: Revert.
7479         * disasm.c: Revert.
7480         * disasm-selftests.c: Revert.
7481         * dictionary.c: Revert.
7482         * dicos-tdep.c: Revert.
7483         * demangle.c: Revert.
7484         * dcache.h: Revert.
7485         * dcache.c: Revert.
7486         * darwin-nat.h: Revert.
7487         * darwin-nat.c: Revert.
7488         * darwin-nat-info.c: Revert.
7489         * d-valprint.c: Revert.
7490         * d-namespace.c: Revert.
7491         * d-lang.c: Revert.
7492         * ctf.c: Revert.
7493         * csky-tdep.c: Revert.
7494         * csky-linux-tdep.c: Revert.
7495         * cris-tdep.c: Revert.
7496         * cris-linux-tdep.c: Revert.
7497         * cp-valprint.c: Revert.
7498         * cp-support.c: Revert.
7499         * cp-namespace.c: Revert.
7500         * cp-abi.c: Revert.
7501         * corelow.c: Revert.
7502         * corefile.c: Revert.
7503         * continuations.c: Revert.
7504         * completer.h: Revert.
7505         * completer.c: Revert.
7506         * complaints.c: Revert.
7507         * coffread.c: Revert.
7508         * coff-pe-read.c: Revert.
7509         * cli-out.h: Revert.
7510         * cli-out.c: Revert.
7511         * charset.c: Revert.
7512         * c-varobj.c: Revert.
7513         * c-valprint.c: Revert.
7514         * c-typeprint.c: Revert.
7515         * c-lang.c: Revert.
7516         * buildsym.c: Revert.
7517         * buildsym-legacy.c: Revert.
7518         * build-id.h: Revert.
7519         * build-id.c: Revert.
7520         * btrace.c: Revert.
7521         * bsd-uthread.c: Revert.
7522         * breakpoint.h: Revert.
7523         * breakpoint.c: Revert.
7524         * break-catch-throw.c: Revert.
7525         * break-catch-syscall.c: Revert.
7526         * break-catch-sig.c: Revert.
7527         * blockframe.c: Revert.
7528         * block.c: Revert.
7529         * bfin-tdep.c: Revert.
7530         * bfin-linux-tdep.c: Revert.
7531         * bfd-target.c: Revert.
7532         * bcache.c: Revert.
7533         * ax-general.c: Revert.
7534         * ax-gdb.h: Revert.
7535         * ax-gdb.c: Revert.
7536         * avr-tdep.c: Revert.
7537         * auxv.c: Revert.
7538         * auto-load.c: Revert.
7539         * arm-wince-tdep.c: Revert.
7540         * arm-tdep.c: Revert.
7541         * arm-symbian-tdep.c: Revert.
7542         * arm-pikeos-tdep.c: Revert.
7543         * arm-obsd-tdep.c: Revert.
7544         * arm-nbsd-tdep.c: Revert.
7545         * arm-nbsd-nat.c: Revert.
7546         * arm-linux-tdep.c: Revert.
7547         * arm-linux-nat.c: Revert.
7548         * arm-fbsd-tdep.c: Revert.
7549         * arm-fbsd-nat.c: Revert.
7550         * arm-bsd-tdep.c: Revert.
7551         * arch-utils.c: Revert.
7552         * arc-tdep.c: Revert.
7553         * arc-newlib-tdep.c: Revert.
7554         * annotate.h: Revert.
7555         * annotate.c: Revert.
7556         * amd64-windows-tdep.c: Revert.
7557         * amd64-windows-nat.c: Revert.
7558         * amd64-tdep.c: Revert.
7559         * amd64-sol2-tdep.c: Revert.
7560         * amd64-obsd-tdep.c: Revert.
7561         * amd64-obsd-nat.c: Revert.
7562         * amd64-nbsd-tdep.c: Revert.
7563         * amd64-nbsd-nat.c: Revert.
7564         * amd64-nat.c: Revert.
7565         * amd64-linux-tdep.c: Revert.
7566         * amd64-linux-nat.c: Revert.
7567         * amd64-fbsd-tdep.c: Revert.
7568         * amd64-fbsd-nat.c: Revert.
7569         * amd64-dicos-tdep.c: Revert.
7570         * amd64-darwin-tdep.c: Revert.
7571         * amd64-bsd-nat.c: Revert.
7572         * alpha-tdep.c: Revert.
7573         * alpha-obsd-tdep.c: Revert.
7574         * alpha-nbsd-tdep.c: Revert.
7575         * alpha-mdebug-tdep.c: Revert.
7576         * alpha-linux-tdep.c: Revert.
7577         * alpha-linux-nat.c: Revert.
7578         * alpha-bsd-tdep.c: Revert.
7579         * alpha-bsd-nat.c: Revert.
7580         * aix-thread.c: Revert.
7581         * agent.c: Revert.
7582         * addrmap.c: Revert.
7583         * ada-varobj.c: Revert.
7584         * ada-valprint.c: Revert.
7585         * ada-typeprint.c: Revert.
7586         * ada-tasks.c: Revert.
7587         * ada-lang.c: Revert.
7588         * aarch64-tdep.c: Revert.
7589         * aarch64-ravenscar-thread.c: Revert.
7590         * aarch64-newlib-tdep.c: Revert.
7591         * aarch64-linux-tdep.c: Revert.
7592         * aarch64-linux-nat.c: Revert.
7593         * aarch64-fbsd-tdep.c: Revert.
7594         * aarch64-fbsd-nat.c: Revert.
7595         * aarch32-linux-nat.c: Revert.
7596
7597 2019-04-05  Tom Tromey  <tom@tromey.com>
7598
7599         * ft32-tdep.c: Sort headers.
7600         * frv-tdep.c: Sort headers.
7601         * frv-linux-tdep.c: Sort headers.
7602         * frame.c: Sort headers.
7603         * frame-unwind.c: Sort headers.
7604         * frame-base.c: Sort headers.
7605         * fork-child.c: Sort headers.
7606         * findvar.c: Sort headers.
7607         * findcmd.c: Sort headers.
7608         * filesystem.c: Sort headers.
7609         * filename-seen-cache.h: Sort headers.
7610         * filename-seen-cache.c: Sort headers.
7611         * fbsd-tdep.c: Sort headers.
7612         * fbsd-nat.h: Sort headers.
7613         * fbsd-nat.c: Sort headers.
7614         * f-valprint.c: Sort headers.
7615         * f-typeprint.c: Sort headers.
7616         * f-lang.c: Sort headers.
7617         * extension.h: Sort headers.
7618         * extension.c: Sort headers.
7619         * extension-priv.h: Sort headers.
7620         * expprint.c: Sort headers.
7621         * exec.h: Sort headers.
7622         * exec.c: Sort headers.
7623         * exceptions.c: Sort headers.
7624         * event-top.c: Sort headers.
7625         * event-loop.c: Sort headers.
7626         * eval.c: Sort headers.
7627         * elfread.c: Sort headers.
7628         * dwarf2read.h: Sort headers.
7629         * dwarf2read.c: Sort headers.
7630         * dwarf2loc.c: Sort headers.
7631         * dwarf2expr.h: Sort headers.
7632         * dwarf2expr.c: Sort headers.
7633         * dwarf2-frame.c: Sort headers.
7634         * dwarf2-frame-tailcall.c: Sort headers.
7635         * dwarf-index-write.h: Sort headers.
7636         * dwarf-index-write.c: Sort headers.
7637         * dwarf-index-common.c: Sort headers.
7638         * dwarf-index-cache.h: Sort headers.
7639         * dwarf-index-cache.c: Sort headers.
7640         * dummy-frame.c: Sort headers.
7641         * dtrace-probe.c: Sort headers.
7642         * disasm.h: Sort headers.
7643         * disasm.c: Sort headers.
7644         * disasm-selftests.c: Sort headers.
7645         * dictionary.c: Sort headers.
7646         * dicos-tdep.c: Sort headers.
7647         * demangle.c: Sort headers.
7648         * dcache.h: Sort headers.
7649         * dcache.c: Sort headers.
7650         * darwin-nat.h: Sort headers.
7651         * darwin-nat.c: Sort headers.
7652         * darwin-nat-info.c: Sort headers.
7653         * d-valprint.c: Sort headers.
7654         * d-namespace.c: Sort headers.
7655         * d-lang.c: Sort headers.
7656         * ctf.c: Sort headers.
7657         * csky-tdep.c: Sort headers.
7658         * csky-linux-tdep.c: Sort headers.
7659         * cris-tdep.c: Sort headers.
7660         * cris-linux-tdep.c: Sort headers.
7661         * cp-valprint.c: Sort headers.
7662         * cp-support.c: Sort headers.
7663         * cp-namespace.c: Sort headers.
7664         * cp-abi.c: Sort headers.
7665         * corelow.c: Sort headers.
7666         * corefile.c: Sort headers.
7667         * continuations.c: Sort headers.
7668         * completer.h: Sort headers.
7669         * completer.c: Sort headers.
7670         * complaints.c: Sort headers.
7671         * coffread.c: Sort headers.
7672         * coff-pe-read.c: Sort headers.
7673         * cli-out.h: Sort headers.
7674         * cli-out.c: Sort headers.
7675         * charset.c: Sort headers.
7676         * c-varobj.c: Sort headers.
7677         * c-valprint.c: Sort headers.
7678         * c-typeprint.c: Sort headers.
7679         * c-lang.c: Sort headers.
7680         * buildsym.c: Sort headers.
7681         * buildsym-legacy.c: Sort headers.
7682         * build-id.h: Sort headers.
7683         * build-id.c: Sort headers.
7684         * btrace.c: Sort headers.
7685         * bsd-uthread.c: Sort headers.
7686         * breakpoint.h: Sort headers.
7687         * breakpoint.c: Sort headers.
7688         * break-catch-throw.c: Sort headers.
7689         * break-catch-syscall.c: Sort headers.
7690         * break-catch-sig.c: Sort headers.
7691         * blockframe.c: Sort headers.
7692         * block.c: Sort headers.
7693         * bfin-tdep.c: Sort headers.
7694         * bfin-linux-tdep.c: Sort headers.
7695         * bfd-target.c: Sort headers.
7696         * bcache.c: Sort headers.
7697         * ax-general.c: Sort headers.
7698         * ax-gdb.h: Sort headers.
7699         * ax-gdb.c: Sort headers.
7700         * avr-tdep.c: Sort headers.
7701         * auxv.c: Sort headers.
7702         * auto-load.c: Sort headers.
7703         * arm-wince-tdep.c: Sort headers.
7704         * arm-tdep.c: Sort headers.
7705         * arm-symbian-tdep.c: Sort headers.
7706         * arm-pikeos-tdep.c: Sort headers.
7707         * arm-obsd-tdep.c: Sort headers.
7708         * arm-nbsd-tdep.c: Sort headers.
7709         * arm-nbsd-nat.c: Sort headers.
7710         * arm-linux-tdep.c: Sort headers.
7711         * arm-linux-nat.c: Sort headers.
7712         * arm-fbsd-tdep.c: Sort headers.
7713         * arm-fbsd-nat.c: Sort headers.
7714         * arm-bsd-tdep.c: Sort headers.
7715         * arch-utils.c: Sort headers.
7716         * arc-tdep.c: Sort headers.
7717         * arc-newlib-tdep.c: Sort headers.
7718         * annotate.h: Sort headers.
7719         * annotate.c: Sort headers.
7720         * amd64-windows-tdep.c: Sort headers.
7721         * amd64-windows-nat.c: Sort headers.
7722         * amd64-tdep.c: Sort headers.
7723         * amd64-sol2-tdep.c: Sort headers.
7724         * amd64-obsd-tdep.c: Sort headers.
7725         * amd64-obsd-nat.c: Sort headers.
7726         * amd64-nbsd-tdep.c: Sort headers.
7727         * amd64-nbsd-nat.c: Sort headers.
7728         * amd64-nat.c: Sort headers.
7729         * amd64-linux-tdep.c: Sort headers.
7730         * amd64-linux-nat.c: Sort headers.
7731         * amd64-fbsd-tdep.c: Sort headers.
7732         * amd64-fbsd-nat.c: Sort headers.
7733         * amd64-dicos-tdep.c: Sort headers.
7734         * amd64-darwin-tdep.c: Sort headers.
7735         * amd64-bsd-nat.c: Sort headers.
7736         * alpha-tdep.c: Sort headers.
7737         * alpha-obsd-tdep.c: Sort headers.
7738         * alpha-nbsd-tdep.c: Sort headers.
7739         * alpha-mdebug-tdep.c: Sort headers.
7740         * alpha-linux-tdep.c: Sort headers.
7741         * alpha-linux-nat.c: Sort headers.
7742         * alpha-bsd-tdep.c: Sort headers.
7743         * alpha-bsd-nat.c: Sort headers.
7744         * aix-thread.c: Sort headers.
7745         * agent.c: Sort headers.
7746         * addrmap.c: Sort headers.
7747         * ada-varobj.c: Sort headers.
7748         * ada-valprint.c: Sort headers.
7749         * ada-typeprint.c: Sort headers.
7750         * ada-tasks.c: Sort headers.
7751         * ada-lang.c: Sort headers.
7752         * aarch64-tdep.c: Sort headers.
7753         * aarch64-ravenscar-thread.c: Sort headers.
7754         * aarch64-newlib-tdep.c: Sort headers.
7755         * aarch64-linux-tdep.c: Sort headers.
7756         * aarch64-linux-nat.c: Sort headers.
7757         * aarch64-fbsd-tdep.c: Sort headers.
7758         * aarch64-fbsd-nat.c: Sort headers.
7759         * aarch32-linux-nat.c: Sort headers.
7760
7761 2019-04-04  Tom Tromey  <tom@tromey.com>
7762
7763         * varobj.c (varobj_create): Update.
7764         * rust-exp.y (struct rust_parser) <update_innermost_block,
7765         lookup_symbol>: New methods.
7766         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7767         Rename.
7768         (rust_parser::rust_lookup_type)
7769         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7770         * printcmd.c (display_command, do_one_display): Update.
7771         * parser-defs.h (struct parser_state) <parser_state>: Add
7772         "tracker" parameter.
7773         (block_tracker): New member.
7774         (class innermost_block_tracker) <innermost_block_tracker>: Add
7775         "types" parameter.
7776         <reset>: Remove method.
7777         (innermost_block): Don't declare.
7778         (null_post_parser): Update.
7779         * parse.c (innermost_block): Remove global.
7780         (write_dollar_variable): Update.
7781         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7782         Remove "tracker_types" parameter.
7783         (parse_expression): Add "tracker" parameter.
7784         (parse_expression_for_completion): Update.
7785         (null_post_parser): Add "tracker" parameter.
7786         * p-exp.y: Update rules.
7787         * m2-exp.y: Update rules.
7788         * language.h (struct language_defn) <la_post_parser>: Add
7789         "tracker" parameter.
7790         * go-exp.y: Update rules.
7791         * f-exp.y: Update rules.
7792         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7793         parameter.
7794         * d-exp.y: Update rules.
7795         * c-exp.y: Update rules.
7796         * breakpoint.c (set_breakpoint_condition): Create an
7797         innermost_block_tracker.
7798         (watch_command_1): Likewise.
7799         * ada-lang.c (resolve): Add "tracker" parameter.
7800         (resolve_subexp): Likewise.
7801         * ada-exp.y (write_var_from_sym): Update.
7802
7803 2019-04-04  Tom Tromey  <tom@tromey.com>
7804
7805         * type-stack.h: New file.
7806         * type-stack.c: New file.
7807         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7808         type-stack.h.
7809         (insert_into_type_stack, insert_type, push_type, push_type_int)
7810         (insert_type_address_space, pop_type, pop_type_int)
7811         (pop_typelist, pop_type_stack, append_type_stack)
7812         (push_type_stack, get_type_stack, push_typelist)
7813         (follow_type_instance_flags, follow_types): Don't declare.
7814         * parse.c (type_stack): Remove global.
7815         (parse_exp_in_context): Update.
7816         (insert_into_type_stack, insert_type, push_type, push_type_int)
7817         (insert_type_address_space, pop_type, pop_type_int)
7818         (pop_typelist, pop_type_stack, append_type_stack)
7819         (push_type_stack, get_type_stack, push_typelist)
7820         (follow_type_instance_flags, follow_types): Remove (moved to
7821         type-stack.c).
7822         * f-exp.y (type_stack): New global.
7823         Update rules.
7824         (push_kind_type, f_parse): Update.
7825         * d-exp.y (type_stack): New global.
7826         Update rules.
7827         (d_parse): Update.
7828         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7829         Update rules.
7830         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7831         (HFILES_NO_SRCDIR): Add type-stack.h.
7832
7833 2019-04-04  Tom Tromey  <tom@tromey.com>
7834
7835         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7836         (rust_parser::convert_ast_to_expression, rust_parse)
7837         (rust_lex_test_completion, rust_lex_tests): Update.
7838         * parser-defs.h (struct expr_completion_state): New.
7839         (struct parser_state) <parser_state>: Add completion parameter.
7840         <mark_struct_expression, mark_completion_tag>: New methods.
7841         <parse_completion, m_completion_state>: New members.
7842         (prefixify_expression, null_post_parser): Update.
7843         (mark_struct_expression, mark_completion_tag): Don't declare.
7844         * parse.c (parse_completion, expout_last_struct)
7845         (expout_tag_completion_type, expout_completion_name): Remove
7846         globals.
7847         (parser_state::mark_struct_expression)
7848         (parser_state::mark_completion_tag): Now methods.
7849         (prefixify_expression): Add last_struct parameter.
7850         (prefixify_subexp): Likewise.
7851         (parse_exp_1): Update.
7852         (parse_exp_in_context): Add cstate parameter.  Update.
7853         (parse_expression_for_completion): Create an
7854         expr_completion_state.
7855         (null_post_parser): Add "completion" parameter.
7856         * p-exp.y: Update rules.
7857         (yylex): Update.
7858         * language.h (struct language_defn) <la_post_parser>: Add
7859         "completing" parameter.
7860         * go-exp.y: Update rules.
7861         (lex_one_token): Update.
7862         * expression.h (parse_completion): Don't declare.
7863         * d-exp.y: Update rules.
7864         (lex_one_token): Update rules.
7865         * c-exp.y: Update rules.
7866         (lex_one_token): Update.
7867         * ada-lang.c (resolve): Add "parse_completion" parameter.
7868         (resolve_subexp): Likewise.
7869         (ada_resolve_function): Likewise.
7870
7871 2019-04-04  Tom Tromey  <tom@tromey.com>
7872
7873         * parser-defs.h (struct parser_state) <start_arglist,
7874         end_arglist>: New methods.
7875         <arglist_len, m_funcall_chain>: New members.
7876         (arglist_len, start_arglist, end_arglist): Don't declare.
7877         * parse.c (arglist_len, funcall_chain): Remove global.
7878         (start_arglist, end_arglist): Remove functions.
7879         (parse_exp_in_context): Update.
7880         * p-exp.y: Update rules.
7881         * m2-exp.y: Update rules.
7882         * go-exp.y: Update rules.
7883         * f-exp.y: Update rules.
7884         * d-exp.y: Update rules.
7885         * c-exp.y: Update rules.
7886
7887 2019-04-04  Tom Tromey  <tom@tromey.com>
7888
7889         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7890         lex_operator, push_back>: New methods.
7891         Update all rules.
7892         (rust_parser::lex_hex, lex_escape): Rename and update.
7893         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7894         (rust_parser::lex_operator): Rename and update.
7895         (rust_parser::lex_number, rustyylex, rustyyerror)
7896         (rust_lex_test_init, rust_lex_test_sequence)
7897         (rust_lex_test_push_back, rust_lex_tests): Update.
7898         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7899         parameter.
7900         <lexptr, prev_lexptr>: New members.
7901         (lexptr, prev_lexptr): Don't declare.
7902         * parse.c (lexptr, prev_lexptr): Remove globals.
7903         (parse_exp_in_context): Update.
7904         * p-exp.y (yylex, yyerror): Update.
7905         * m2-exp.y (parse_number, yylex, yyerror): Update.
7906         * go-exp.y (lex_one_token, yyerror): Update.
7907         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7908         * d-exp.y (lex_one_token, yyerror): Update.
7909         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7910         (lex_one_token, yyerror): Update.
7911         * ada-lex.l (YY_INPUT): Update.
7912         (rewind_to_char): Update.
7913         * ada-exp.y (yyerror): Update.
7914
7915 2019-04-04  Tom Tromey  <tom@tromey.com>
7916
7917         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7918         * parser-defs.h (struct parser_state) <parser_state>: Add new
7919         parameter.
7920         <comma_terminates>: New member.
7921         (comma_terminates): Don't declare global.
7922         * parse.c (comma_terminates): Remove global.
7923         (parse_exp_in_context): Update.
7924         * p-exp.y (yylex): Update.
7925         * m2-exp.y (yylex): Update.
7926         * go-exp.y (lex_one_token): Update.
7927         * f-exp.y (yylex): Update.
7928         * d-exp.y (lex_one_token): Update.
7929         * c-exp.y (lex_one_token): Update.
7930         * ada-lex.l: Update.
7931
7932 2019-04-04  Tom Tromey  <tom@tromey.com>
7933
7934         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7935         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7936         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7937         * parser-defs.h (paren_depth): Don't declare.
7938         * parse.c (paren_depth): Remove global.
7939         (parse_exp_in_context): Update.
7940         * p-exp.y (paren_depth): New global.
7941         (pascal_parse): Initialize it.
7942         * m2-exp.y (paren_depth): New global.
7943         (m2_parse): Initialize it.
7944         * go-exp.y (paren_depth): New global.
7945         (go_parse): Initialize it.
7946         * f-exp.y (paren_depth): New global.
7947         (f_parse): Initialize it.
7948         * d-exp.y (paren_depth): New global.
7949         (d_parse): Initialize it.
7950         * c-exp.y (paren_depth): New global.
7951         (c_parse): Initialize it.
7952         * ada-lex.l (paren_depth): New global.
7953         (lexer_init): Initialize it.
7954
7955 2019-04-04  Tom Tromey  <tom@tromey.com>
7956
7957         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7958         (rust_parser::convert_ast_to_type)
7959         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7960         * parser-defs.h (struct parser_state) <parser_state>: Add
7961         parameters.  Initialize new members.
7962         <expression_context_block, expression_context_pc>: New members.
7963         * parse.c (expression_context_block, expression_context_pc):
7964         Remove globals.
7965         (parse_exp_in_context): Update.
7966         * p-exp.y: Update all rules.
7967         (yylex): Update.
7968         * m2-exp.y: Update all rules.
7969         (yylex): Update.
7970         * go-exp.y (yylex): Update.
7971         * f-exp.y (yylex): Update.
7972         * d-exp.y: Update all rules.
7973         (yylex): Update.
7974         * c-exp.y: Update all rules.
7975         (lex_one_token, classify_name, yylex, c_parse): Update.
7976         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7977
7978 2019-04-04  Tom Tromey  <tom@tromey.com>
7979
7980         * gdbarch.h, gdbarch.c: Rebuild.
7981         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7982         * stap-probe.h:
7983         (struct stap_parse_info): Replace "parser_state" with
7984         "expr_builder".
7985         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7986         (parser_state): New class.
7987         * parse.c (expr_builder): Rename.
7988         (expr_builder::release): Rename.
7989         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7990         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7991         (write_exp_elt_longcst, write_exp_elt_floatcst)
7992         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7993         (write_exp_string_vector, write_exp_bitstring)
7994         (write_exp_msymbol, mark_struct_expression)
7995         (write_dollar_variable)
7996         (insert_type_address_space, increase_expout_size): Replace
7997         "parser_state" with "expr_builder".
7998         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7999         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8000         "parser_state" with "expr_builder".
8001
8002 2019-04-04  Tom Tromey  <tom@tromey.com>
8003
8004         * rust-exp.y: Replace "parse_language" with method call.
8005         * p-exp.y:
8006         (yylex): Replace "parse_language" with method call.
8007         * m2-exp.y:
8008         (yylex): Replace "parse_language" with method call.
8009         * go-exp.y (classify_name): Replace "parse_language" with method
8010         call.
8011         * f-exp.y (yylex): Replace "parse_language" with method call.
8012         * d-exp.y (lex_one_token): Replace "parse_language" with method
8013         call.
8014         * c-exp.y:
8015         (lex_one_token, classify_name, yylex): Replace "parse_language"
8016         with method call.
8017         * ada-exp.y (find_primitive_type, type_char)
8018         (type_system_address): Replace "parse_language" with method call.
8019
8020 2019-04-04  Tom Tromey  <tom@tromey.com>
8021
8022         * rust-exp.y: Replace "parse_gdbarch" with method call.
8023         * parse.c (write_dollar_variable, insert_type_address_space):
8024         Replace "parse_gdbarch" with method call.
8025         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8026         call.
8027         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8028         call.
8029         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8030         "parse_gdbarch" with method call.
8031         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8032         with method call.
8033         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8034         "parse_gdbarch" with method call.
8035         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8036         "parse_gdbarch" with method call.
8037         * c-exp.y (parse_type, parse_number, classify_name): Replace
8038         "parse_gdbarch" with method call.
8039         * ada-lex.l: Replace "parse_gdbarch" with method call.
8040         * ada-exp.y (parse_type, find_primitive_type, type_char)
8041         (type_system_address): Replace "parse_gdbarch" with method call.
8042
8043 2019-04-04  Tom Tromey  <tom@tromey.com>
8044
8045         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8046         * stap-probe.c (stap_parse_argument): Update.
8047         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8048         initial_size parameter.
8049         * rust-exp.y (rust_lex_tests): Update.
8050         * parse.c (parser_state): Update.
8051         (parse_exp_in_context): Update.
8052         * parser-defs.h (struct parser_state) <parser_state>: Remove
8053         "initial_size" parameter.
8054
8055 2019-04-04  Tom Tromey  <tom@tromey.com>
8056
8057         * parser-defs.h (increase_expout_size): Don't declare.
8058         * parse.c (increase_expout_size): Now static.
8059
8060 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8061
8062         * gnu-nat.c (gnu_nat_target::wait): Fix
8063         target_waitstatus_to_string call.
8064
8065 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8066
8067         * eval.c (evaluate_subexp_standard): Handle internal functions
8068         during Fortran function call handling.
8069
8070 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8071
8072         * NEWS: Mention new internal functions.
8073         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8074         (read_base_type): Use dwarf2_init_complex_target_type.
8075         * value.c (creal_internal_fn): New function.
8076         (cimag_internal_fn): New function.
8077         (_initialize_values): Register new internal functions.
8078
8079 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8080
8081         * infrun.c (stop_all_threads): If debug_infrun, always
8082         trace the wait status after wait_one, using
8083         target_waitstatus_to_string and target_pid_to_str.
8084         (handle_inferior_event): Replace various trace of
8085         wait status kind by a single trace.
8086         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8087         wait status kind image by target_waitstatus_to_string.
8088         * target/waitstatus.c (target_waitstatus_to_string): Fix
8089         obsolete comment.
8090
8091 2019-04-01  Tom Tromey  <tromey@adacore.com>
8092
8093         PR symtab/23331:
8094         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8095
8096 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8097             Pedro Alves  <palves@redhat.com>
8098
8099         * top.c (quit_force): Call 'finalize_values'.
8100         * value.c (finalize_values): New function.
8101         * value.h (finalize_values): Declare.
8102
8103 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8104
8105         * NEWS: Announce $_gdb_major and $_gdb_minor.
8106
8107         * top.c (init_gdb_version_vars): New function.
8108         (gdb_init): Call init_gdb_version_vars.
8109
8110 2019-03-29  Tom Tromey  <tromey@adacore.com>
8111
8112         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8113         help text.  Remove dead code.
8114
8115 2019-03-29  Keith Seitz  <keiths@redhat.com>
8116
8117         From Siddhesh Poyarekar:
8118         * f-lang.h (f77_get_upperbound): Return LONGEST.
8119         (f77_get_lowerbound): Likewise.
8120         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8121         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8122         print them.
8123         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8124         plongest to format print it.
8125         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8126         (f77_get_upperbound): Likewise.
8127         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8128         LOWER_BOUND to LONGEST.
8129         (f77_create_arrayprint_offset_tbl): Likewise.
8130
8131 2019-03-29  Keith Seitz  <keiths@redhat.com>
8132
8133         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8134         %s/pulongest for TYPE_LENGTH instead of %d in format
8135         strings.
8136         * ada-typerint.c (ada_print_type): Likewise.
8137         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8138         * compile/compile-c-support.c (generate_register_struct): Likewise.
8139         * gdbtypes.c (recursive_dump_type): Likewise.
8140         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8141         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8142         instead of %d in format strings.
8143         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8144         to std::min to ULONGEST.
8145         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8146         instead of %d in format strings.
8147         * tracepoint.c (info_scope_command): Likewise.
8148         * typeprint.c (print_offset_data::update)
8149         (print_offset_data::finish): Likewise.
8150         * xtensa-tdep.c (xtensa_store_return_value)
8151         (xtensa_push_dummy_call): Likewise.
8152
8153 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8154
8155         * windows-nat.c (display_selector): Fixed format specifications
8156         for 64-bit Cygwin.
8157
8158 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8159
8160         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8161
8162 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8163
8164         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8165         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8166         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8167         (nios2_linux_init_abi): Install it.
8168
8169 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8170
8171         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8172
8173 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8174
8175         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8176
8177 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8178             Tom Tromey  <tromey@adacore.com>
8179
8180         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8181
8182 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8183
8184         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8185         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8186         method to compute the bounds of range types. Also print "[evaluated]"
8187         if the bounds' values come from a dynamic evaluation.
8188
8189 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8190
8191         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8192         whitespace when pretty printing is on.
8193
8194 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8195
8196         * ppc-linux-nat.c: Add include.
8197
8198 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8199
8200         * NEWS: Mention AArch64 Pointer Authentication.
8201
8202 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8203
8204         * arm-linux-nat.c: Add include.
8205
8206 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8207
8208         * source-cache.c (source_cache::get_source_lines): Re-read
8209         fullname after calling open_source_file.
8210
8211 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8212
8213         * NEWS: Mention TLS support for FreeBSD.
8214
8215 2019-03-25  Tom Tromey  <tromey@adacore.com>
8216
8217         * minsyms.c (BUNCH_SIZE): Update comment.
8218         (~minimal_symbol_reader): Remove old comment.
8219         (compact_minimal_symbols): Update comment.
8220         (minimal_symbol_reader::install): Remove old comment.  Update
8221         other comments.
8222
8223 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8224
8225         * s390-linux-nat.c: Add include.
8226
8227 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8228
8229         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8230         Call linux_get_hwcap.
8231         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8232         Likewise.
8233         (aarch64_linux_get_hwcap): Remove function.
8234         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8235         declaration.
8236         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8237         linux_get_hwcap.
8238         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8239         * linux-tdep.c (linux_get_hwcap): Add function.
8240         (linux_get_hwcap2): Likewise.
8241         * linux-tdep.h (linux_get_hwcap): Add declaration.
8242         (linux_get_hwcap2): Likewise.
8243         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8244         (ppc_linux_get_hwcap2): Likewise.
8245         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8246         linux_get_hwcap.
8247         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8248         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8249         (ppc_linux_nat_target::read_description): Likewise.
8250         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8251         * s390-linux-nat.c: Likewise.
8252         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8253
8254 2019-03-24  Tom Tromey  <tom@tromey.com>
8255
8256         * ada-lang.c (standard_lookup): Simplify initialization.
8257         (ada_lookup_symbol_nonlocal): Simplify return.
8258         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8259         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8260         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8261         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8262         initialization.
8263         * solib.c (solib_global_lookup): Simplify.
8264         * symtab.c (null_block_symbol): Remove.
8265         (symbol_cache_lookup): Simplify returns.
8266         (lookup_language_this): Simplify returns.
8267         (lookup_symbol_aux): Simplify return.
8268         (lookup_local_symbol): Simplify returns.
8269         (lookup_global_symbol_from_objfile): Simplify return.
8270         (lookup_symbol_in_objfile_symtabs)
8271         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8272         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8273         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8274         * cp-namespace.c (cp_lookup_bare_symbol)
8275         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8276         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8277         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8278         (cp_lookup_symbol_via_imports): Simplify initialization.
8279         (find_symbol_in_baseclass): Likewise.
8280         * symtab.h (null_block_symbol): Remove.
8281         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8282         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8283         (d_lookup_symbol_module): Likewise.
8284         (find_symbol_in_baseclass): Simplify initialization.
8285
8286 2019-03-24  Tom Tromey  <tom@tromey.com>
8287
8288         * expression.h: Don't include symtab.h.
8289         (struct block): Forward declare.
8290
8291 2019-03-24  Tom Tromey  <tom@tromey.com>
8292
8293         * c-exp.y (typebase): Remove casts.
8294         * gdbtypes.c (lookup_unsigned_typename, )
8295         (lookup_signed_typename): Remove cast.
8296         * eval.c (parse_to_comma_and_eval): Remove cast.
8297         * parse.c (write_dollar_variable): Remove cast.
8298         * block.h (struct block) <superblock>: Now const.
8299         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8300         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8301         (map_block): Make "block" const.
8302         * symfile.h (struct quick_symbol_functions)
8303         <map_matching_symbols>: Constify block argument to "callback".
8304         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8305         const.
8306         (find_pc_sect_compunit_symtab): Make "b" const.
8307         (find_symbol_at_address): Likewise.
8308         (search_symbols): Likewise.
8309         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8310         (dw2_debug_names_lookup_symbol): Likewise.
8311         (dw2_map_matching_symbols): Update.
8312         * p-valprint.c (pascal_val_print): Remove "block".
8313         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8314         (aux_add_nonlocal_symbols): Make "block" const.
8315         (resolve_subexp): Remove cast.
8316         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8317         const.
8318         (iterate_over_file_blocks): Likewise.
8319         * f-exp.y (%union) <bval>: Remove.
8320         * coffread.c (patch_opaque_types): Make "b" const.
8321         * spu-tdep.c (spu_catch_start): Make "block" const.
8322         * c-valprint.c (print_unpacked_pointer): Remove "block".
8323         * symmisc.c (dump_symtab_1): Make "b" const.
8324         (block_depth): Make "block" const.
8325         * d-exp.y (%union) <bval>: Remove.
8326         * cp-support.h (cp_lookup_rtti_type): Update.
8327         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8328         * psymtab.c (psym_lookup_symbol): Make "block" const.
8329         (maintenance_check_psymtabs): Make "b" const.
8330         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8331         (enumerate_locals, enumerate_args): Update.
8332         * python/py-symtab.c (stpy_global_block): Make "block" const.
8333         (stpy_static_block): Likewise.
8334         * inline-frame.c (block_starting_point_at): Make "new_block"
8335         const.
8336         * block.c (find_block_in_blockvector): Make return type const.
8337         (blockvector_for_pc_sect): Make "b" const.
8338         (find_block_in_blockvector): Make "b" const.
8339
8340 2019-03-23  Tom Tromey  <tom@tromey.com>
8341
8342         * varobj.c (varobj_create): Update.
8343         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8344         * printcmd.c (display_command, do_one_display): Don't reset
8345         innermost_block.
8346         * parser-defs.h (enum innermost_block_tracker_type): Move to
8347         expression.h.
8348         (innermost_block): Update comment.
8349         * parse.c (parse_exp_1): Add tracker_types parameter.
8350         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8351         tracker_types parameter.  Reset innermost_block.
8352         (parse_exp_in_context): Remove.
8353         (parse_expression_for_completion): Update.
8354         * objfiles.c (~objfile): Don't reset expression_context_block or
8355         innermost_block.
8356         * expression.h (enum innermost_block_tracker_type): Move from
8357         parser-defs.h.
8358         (parse_exp_1): Add tracker_types parameter.
8359         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8360         reset innermost_block.
8361
8362 2019-03-23  Tom Tromey  <tom@tromey.com>
8363
8364         * objfiles.h: Include bcache.h.
8365
8366 2019-03-23  Tom Tromey  <tom@tromey.com>
8367
8368         * linespec.c (get_current_search_block): Use
8369         scoped_restore_current_language.
8370         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8371
8372 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8373             Jiong Wang  <jiong.wang@arm.com>
8374
8375         * aarch64-linux-tdep.c
8376         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8377         section.
8378         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8379
8380 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8381             Jiong Wang  <jiong.wang@arm.com>
8382
8383         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8384         instructions.
8385         (aarch64_analyze_prologue_test): Add PACIASP test.
8386         (aarch64_prologue_prev_register): Unmask PC value.
8387
8388 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8389             Jiong Wang  <jiong.wang@arm.com>
8390
8391         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8392         (aarch64_dwarf2_prev_register): Unmask PC value.
8393         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8394         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8395         DW_CFA_AARCH64_negate_ra_state.
8396         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8397
8398 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8399             Jiong Wang  <jiong.wang@arm.com>
8400
8401         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8402         registers.
8403         (aarch64_pseudo_register_name): Likewise.
8404         (aarch64_pseudo_register_type): Likewise.
8405         (aarch64_pseudo_register_reggroup_p): Likewise.
8406         (aarch64_gdbarch_init): Add pauth registers.
8407         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8408         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8409         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8410         (struct gdbarch_tdep): Add regnum for ra_state.
8411
8412 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8413             Jiong Wang  <jiong.wang@arm.com>
8414
8415         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8416
8417 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8418             Jiong Wang  <jiong.wang@arm.com>
8419
8420         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8421         function.
8422         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8423         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8424         (aarch64_gdbarch_init): Add puth registers.
8425         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8426         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8427         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8428
8429 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8430             Jiong Wang  <jiong.wang@arm.com>
8431
8432         * aarch64-linux-nat.c
8433         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8434         * aarch64-linux-tdep.c
8435         (aarch64_linux_core_read_description): Likewise.
8436         (aarch64_linux_get_hwcap): New function.
8437         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8438         (aarch64_linux_get_hwcap): New declaration.
8439
8440 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8441             Jiong Wang  <jiong.wang@arm.com>
8442
8443         * aarch64-linux-nat.c
8444         (aarch64_linux_nat_target::read_description): Add pauth param.
8445         * aarch64-linux-tdep.c
8446         (aarch64_linux_core_read_description): Likewise.
8447         * aarch64-tdep.c (struct target_desc): Add in pauth.
8448         (aarch64_read_description): Add pauth param.
8449         (aarch64_gdbarch_init): Likewise.
8450         * aarch64-tdep.h (aarch64_read_description): Likewise.
8451         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8452         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8453         * features/Makefile: Add new files.
8454         * features/aarch64-pauth.c: New file.
8455         * features/aarch64-pauth.xml: New file.
8456
8457 2019-03-20  Tom Tromey  <tromey@adacore.com>
8458
8459         * infrun.c (handle_inferior_event): Rename from
8460         handle_inferior_event_1.  Create a scoped_value_mark.
8461         (handle_inferior_event): Remove.
8462
8463 2019-03-19  Tom Tromey  <tromey@adacore.com>
8464
8465         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8466         * infrun.h (print_stop_event): Add "displays" parameter.
8467         * infrun.c (print_stop_event): Add "displays" parameter.
8468
8469 2019-03-19  Pedro Alves  <palves@redhat.com>
8470
8471         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8472         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8473         to -1.  Fix TABs vs spaces.
8474         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8475         * tui/tui-out.h (tui_ui_out) Add intro comments.
8476         <m_line, m_start_of_line>: In-class initialize, and add describing
8477         comment.
8478
8479 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8480
8481         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8482         variable names.
8483         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8484
8485 2019-03-18  Pedro Alves  <palves@redhat.com>
8486             Eli Zaretskii <eliz@gnu.org>
8487
8488         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8489         m_line and m_start_of_line.
8490
8491 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8492
8493         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8494         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8495         it returns a newline.  This fixes a regression in TU mode, whereby
8496         the next line is output on the same screen line as the user input.
8497
8498 2019-03-18  Tom Tromey  <tromey@adacore.com>
8499
8500         * minsyms.c (minimal_symbol_reader::install): Remove call to
8501         obstack_blank.
8502
8503 2019-03-18  Pedro Alves  <palves@redhat.com>
8504
8505         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8506         New globals.
8507         (apply_style): New, factored out from ...
8508         (apply_ansi_escape): ... this.  Handle reverse video mode.
8509         (tui_set_reverse_mode): New function.
8510         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8511         * tui/tui-winsource.c (tui_show_source_line): Use
8512         tui_set_reverse_mode instead of setting A_STANDOUT.
8513         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8514         New setter methods.
8515
8516 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8517
8518         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8519         Handle tabs.
8520
8521 2019-03-18  Tom Tromey  <tromey@adacore.com>
8522
8523         * ada-lang.c (empty_array): Add "high" parameter.
8524         (ada_evaluate_subexp): Update.
8525
8526 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8527
8528         * unittests/string_view-selftests.c: Define
8529         _initialize_string_view_selftests unconditionally.
8530
8531 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8532
8533         PR gdb/24350
8534         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8535
8536 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8537
8538         PR gdb/24351
8539         * windows-nat.c (display_selector): Fix format specifiers.
8540
8541 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8542
8543         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8544         tui_refill_source_window instead of tui_refresh_win, to update the
8545         current execution line.  This fixes redisplay of the current line
8546         when stepping through the code with "next" or "step".
8547
8548 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8549
8550         * source-cache.c (source_cache::get_source_lines): Call
8551         find_source_lines to initialize s->nlines.  This fixes vertical
8552         scrolling of TUI source window when the DOWN arrow is pressed.
8553
8554 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8555
8556         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8557         linux-thread-db.c (_initialize_thread_db): Likewise.
8558
8559 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8560
8561         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8562         wclrtoeol in tui_show_source_line".  This reverts changes made in
8563         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8564
8565 2019-03-15  Tom Tromey  <tom@tromey.com>
8566
8567         * symtab.h (struct minimal_symbol): Derive from
8568         general_symbol_info.
8569         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8570         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8571         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8572         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8573         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8574         (MSYMBOL_SEARCH_NAME): Update.
8575         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8576         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8577         * minsyms.c (minimal_symbol_reader::record_full): Update.
8578
8579 2019-03-15  Tom Tromey  <tom@tromey.com>
8580
8581         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8582
8583 2019-03-15  Tom Tromey  <tom@tromey.com>
8584
8585         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8586         unique_xmalloc_ptr.
8587         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8588         Update.
8589         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8590         (build_minimal_symbol_hash_tables)
8591         (minimal_symbol_reader::install): Update.
8592
8593 2019-03-15  Tom Tromey  <tom@tromey.com>
8594
8595         * symtab.c (create_demangled_names_hash): Update.
8596         (symbol_set_names): Update.
8597         * objfiles.h (struct objfile_per_bfd_storage)
8598         <demangled_names_hash>: Now an htab_up.
8599         * objfiles.c (objfile_per_bfd_storage): Simplify.
8600
8601 2019-03-15  Tom Tromey  <tom@tromey.com>
8602
8603         * objfiles.h (struct objfile_per_bfd_storage): Declare
8604         destructor.
8605         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8606         New.
8607         (get_objfile_bfd_data): Use new.  Don't initialize
8608         language_of_main.
8609         (free_objfile_per_bfd_storage): Remove.
8610         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8611
8612 2019-03-15  Tom Tromey  <tom@tromey.com>
8613
8614         * symfile.c (reread_symbols): Update.
8615         * objfiles.c (objfile::objfile): Update.
8616         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8617         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8618         comment.
8619         (minimal_symbol_reader::install): Update.
8620         (terminate_minimal_symbol_table): Remove.
8621         * jit.c (jit_object_close_impl): Update.
8622
8623 2019-03-15  Tom Tromey  <tom@tromey.com>
8624
8625         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8626         initializations.
8627
8628 2019-03-15  Tom Tromey  <tom@tromey.com>
8629
8630         * objfiles.h (struct objfile_per_bfd_storage)
8631         <demangled_hash_languages>: Now a bitset.
8632         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8633         (lookup_minimal_symbol): Update.
8634
8635 2019-03-15  Tom Tromey  <tom@tromey.com>
8636
8637         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8638         Don't return the symbol.
8639         * coffread.c (record_minimal_symbol): Use record_full.
8640
8641 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8642
8643         The MS-Windows port of ncurses fails to switch to a color pair if
8644         one or both of the colors are the implicit default colors.  This
8645         change records the default colors when TUI is initialized, and
8646         then specifies them explicitly when a color pair uses the default
8647         colors.  This allows color styling in TUI mode on MS-Windows.
8648
8649         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8650         ncurses_norm_attr.
8651         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8652         colors in ncurses_norm_attr.
8653         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8654         "none", replace it with the default color recorded in
8655         ncurses_norm_attr.
8656
8657 2019-03-14  Tom Tromey  <tromey@adacore.com>
8658
8659         * source-cache.h (class source_cache) <get_source_lines>: Return
8660         std::string.
8661         * source-cache.c (source_cache::extract_lines): Handle case where
8662         first_pos==npos.  Return std::string.
8663         (source_cache::get_source_lines): Update.
8664
8665 2019-03-14  Tom Tromey  <tromey@adacore.com>
8666
8667         * NEWS: Add item for "style sources" commands.
8668         * source-cache.c (source_cache::get_source_lines): Check
8669         source_styling.
8670         * cli/cli-style.c (source_styling): New global.
8671         (_initialize_cli_style): Add "style sources" commands.
8672         (show_style_sources): New function.
8673         * cli/cli-style.h (source_styling): Declare.
8674
8675 2019-03-14  Pedro Alves  <palves@redhat.com>
8676             Tom Tromey  <tromey@adacore.com>
8677
8678         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8679         * tui/tui-winsource.c (tui_refill_source_window): New function,
8680         from...
8681         (tui_horizontal_source_scroll): ... here.  Move some logic.
8682         * cli/cli-style.c (set_style_enabled): Notify new observable.
8683         * tui/tui-hooks.c (tui_redisplay_source): New function.
8684         (tui_attach_detach_observers): Attach or detach
8685         tui_redisplay_source.
8686         * observable.h (source_styling_changed): New observable.
8687         * observable.c: Define source_styling_changed observable.
8688
8689 2019-03-13  Tom Tromey  <tromey@adacore.com>
8690
8691         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8692         (i386_gnu_nat_target::store_registers): Update.
8693         * target-debug.h (target_debug_print_std_string): New macro.
8694         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8695         * windows-tdep.c (display_one_tib): Update.
8696         * tui/tui-stack.c (tui_make_status_line): Update.
8697         * top.c (print_inferior_quit_action): Update.
8698         * thread.c (thr_try_catch_cmd): Update.
8699         (add_thread_with_info): Update.
8700         (thread_target_id_str): Update.
8701         (thr_try_catch_cmd): Update.
8702         (thread_command): Update.
8703         (thread_find_command): Update.
8704         * record-btrace.c (record_btrace_target::info_record)
8705         (record_btrace_resume_thread, record_btrace_target::resume)
8706         (record_btrace_cancel_resume, record_btrace_step_thread)
8707         (record_btrace_target::wait, record_btrace_target::wait)
8708         (record_btrace_target::wait, record_btrace_target::stop): Update.
8709         * progspace.c (print_program_space): Update.
8710         * process-stratum-target.c
8711         (process_stratum_target::thread_address_space): Update.
8712         * linux-fork.c (linux_fork_mourn_inferior)
8713         (detach_checkpoint_command, info_checkpoints_command)
8714         (linux_fork_context): Update.
8715         (linux_fork_detach): Update.
8716         (class scoped_switch_fork_info): Update.
8717         (delete_checkpoint_command): Update.
8718         * infrun.c (follow_fork_inferior): Update.
8719         (follow_fork_inferior): Update.
8720         (proceed_after_vfork_done): Update.
8721         (handle_vfork_child_exec_or_exit): Update.
8722         (follow_exec): Update.
8723         (displaced_step_prepare_throw): Update.
8724         (displaced_step_restore): Update.
8725         (start_step_over): Update.
8726         (resume_1): Update.
8727         (clear_proceed_status_thread): Update.
8728         (proceed): Update.
8729         (print_target_wait_results): Update.
8730         (do_target_wait): Update.
8731         (context_switch): Update.
8732         (stop_all_threads): Update.
8733         (restart_threads): Update.
8734         (finish_step_over): Update.
8735         (handle_signal_stop): Update.
8736         (switch_back_to_stepped_thread): Update.
8737         (keep_going_pass_signal): Update.
8738         (print_exited_reason): Update.
8739         (normal_stop): Update.
8740         * inferior.c (inferior_pid_to_str): Change return type.
8741         (print_selected_inferior): Update.
8742         (add_inferior): Update.
8743         (detach_inferior): Update.
8744         * dummy-frame.c (fprint_dummy_frames): Update.
8745         * dcache.c (dcache_info_1): Update.
8746         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8747         (btrace_fetch, btrace_clear): Update.
8748         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8749         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8750         type.
8751         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8752         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8753         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8754         * gdbarch.c, gdbarch.h: Rebuild.
8755         * gdbarch.sh (core_pid_to_str): Change return type.
8756         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8757         return type.
8758         (windows_nat_target::pid_to_str): Change return type.
8759         (windows_delete_thread): Update.
8760         (windows_nat_target::attach): Update.
8761         (windows_nat_target::files_info): Update.
8762         * target-delegates.c: Rebuild.
8763         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8764         return type.
8765         (sol_thread_target::pid_to_str): Change return type.
8766         * remote.c (class remote_target) <pid_to_str>: Change return
8767         type.
8768         (remote_target::pid_to_str): Change return type.
8769         (extended_remote_target::attach, remote_target::remote_stop_ns)
8770         (remote_target::remote_notif_remove_queued_reply)
8771         (remote_target::push_stop_reply, remote_target::disable_btrace):
8772         Update.
8773         (extended_remote_target::attach): Update.
8774         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8775         type.
8776         (gdbsim_target::pid_to_str): Change return type.
8777         * ravenscar-thread.c (struct ravenscar_thread_target)
8778         <pid_to_str>: Change return type.
8779         (ravenscar_thread_target::pid_to_str): Change return type.
8780         * procfs.c (class procfs_target) <pid_to_str>: Change return
8781         type.
8782         (procfs_target::pid_to_str): Change return type.
8783         (procfs_target::attach): Update.
8784         (procfs_target::detach): Update.
8785         (procfs_target::fetch_registers): Update.
8786         (procfs_target::store_registers): Update.
8787         (procfs_target::wait): Update.
8788         (procfs_target::files_info): Update.
8789         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8790         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8791         return type.
8792         (nto_procfs_target::pid_to_str): Change return type.
8793         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8794         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8795         return type.
8796         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8797         (exit_lwp): Update.
8798         (attach_proc_task_lwp_callback, get_detach_signal)
8799         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8800         (linux_nat_target::resume, wait_lwp, stop_callback)
8801         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8802         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8803         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8804         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8805         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8806         type.
8807         (inf_ptrace_target::attach): Update.
8808         (inf_ptrace_target::files_info): Update.
8809         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8810         type.
8811         (go32_nat_target::pid_to_str): Change return type.
8812         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8813         (gnu_nat_target::wait): Update.
8814         (gnu_nat_target::wait): Update.
8815         (gnu_nat_target::resume): Update.
8816         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8817         (fbsd_nat_target::wait): Update.
8818         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8819         type.
8820         (darwin_nat_target::attach): Update.
8821         * corelow.c (class core_target) <pid_to_str>: Change return type.
8822         (core_target::pid_to_str): Change return type.
8823         * target.c (normal_pid_to_str): Change return type.
8824         (default_pid_to_str): Likewise.
8825         (target_pid_to_str): Change return type.
8826         (target_translate_tls_address): Update.
8827         (target_announce_detach): Update.
8828         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8829         return type.
8830         (bsd_uthread_target::pid_to_str): Change return type.
8831         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8832         type.
8833         (bsd_kvm_target::pid_to_str): Change return type.
8834         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8835         return type.
8836         (aix_thread_target::pid_to_str): Change return type.
8837         * target.h (struct target_ops) <pid_to_str>: Change return type.
8838         (target_pid_to_str, normal_pid_to_str): Likewise.
8839         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8840         type.
8841         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8842         type.
8843         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8844         return type.
8845         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8846         type.
8847         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8848         type.
8849         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8850         return type.
8851
8852 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8853
8854         * NEWS: Mention that the new default MI version is 3.  Mention
8855         changes to the output of commands and events that deal with
8856         multi-location breakpoints.
8857         * breakpoint.c: Include "mi/mi-out.h".
8858         (print_one_breakpoint): Change output syntax if using MI version
8859         >= 3.
8860         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8861         New.
8862         (mi_multi_location_breakpoint_output_fixed): New.
8863         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8864         (mi_cmd_fix_multi_location_breakpoint_output): New.
8865         (mi_multi_location_breakpoint_output_fixed): New.
8866         * mi/mi-cmds.c (mi_cmds): Register command
8867         -fix-multi-location-breakpoint-output.
8868         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8869         interpreter "mi".
8870
8871 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8872
8873         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8874         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8875         instantiate mi_ui_out based on interpreter name.
8876         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8877         * mi/mi-main.c (mi_load_progress): Likewise.
8878
8879 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8880
8881         * NEWS: Combine separate "New targets" sections for 8.3.
8882
8883 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8884
8885         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8886         (ppcfbsd_init_abi): Install gdbarch
8887         "fetch_tls_load_module_address" and "get_thread_local_address"
8888         methods.
8889
8890 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8891
8892         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8893         (riscv_fbsd_init_abi): Install gdbarch
8894         "fetch_tls_load_module_address" and "get_thread_local_address"
8895         methods.
8896
8897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8898
8899         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8900         (i386fbsd_init_abi): Install gdbarch
8901         "fetch_tls_load_module_address" and "get_thread_local_address"
8902         methods.
8903
8904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8905
8906         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8907         (amd64fbsd_init_abi): Install gdbarch
8908         "fetch_tls_load_module_address" and "get_thread_local_address"
8909         methods.
8910
8911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8912
8913         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8914         (struct fbsd_pspace_data): New type.
8915         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8916         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8917         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8918         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8919         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8920
8921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8922
8923         * gdbtypes.c (lookup_struct_elt): New function.
8924         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8925         * gdbtypes.h (struct struct_elt): New type.
8926         (lookup_struct_elt): New prototype.
8927
8928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8929
8930         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8931         remove disabled code block.
8932
8933 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8934
8935         * gdbarch.sh (get_thread_local_address): New method.
8936         * gdbarch.h, gdbarch.c: Regenerate.
8937         * target.c (target_translate_tls_address): Use
8938         gdbarch_get_thread_local_address if present instead of
8939         target::get_thread_local_address.
8940
8941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8942
8943         * target.h (target::get_thread_local_address): Update comment.
8944
8945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8946
8947         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8948         objfile->separate_debug_objfile_backlink if not NULL.
8949
8950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8951
8952         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8953         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8954         (amd64bsd_store_inferior_registers): Likewise.
8955         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8956         Enable segment base registers.
8957         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8958         PT_GETFSBASE and PT_GETGSBASE.
8959         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8960         PT_SETGSBASE.
8961         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8962         segment base registers.
8963         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8964
8965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8966
8967         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8968         Update calls to i386_target_description to add 'segments'
8969         parameter.
8970         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8971         add segment base registers.
8972         * arch/i386.c (i386_create_target_description): Add 'segments'
8973         parameter to enable segment base registers.
8974         * arch/i386.h (i386_create_target_description): Likewise.
8975         * features/i386/32bit-segments.xml: New file.
8976         * features/i386/32bit-segments.c: Generate.
8977         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8978         call to i386_target_description to add 'segments' parameter.
8979         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8980         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8981         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8982         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8983         if feature is present.
8984         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8985         Add 'segments' parameter to call to i386_target_description.
8986         (i386_target_description): Add 'segments' parameter to enable
8987         segment base registers.
8988         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8989         to call to i386_target_description.
8990         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8991         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8992         Define I386_NUM_REGS.
8993         (i386_target_description): Add 'segments' parameter to enable
8994         segment base registers.
8995
8996 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8997
8998         PR/24325
8999         * source-cache.c: #undef open and close, to avoid unresolved
9000         externals during linking.
9001
9002 2019-03-12  Tom Tromey  <tromey@adacore.com>
9003
9004         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9005         const.  Add initializers.
9006         (_initialize_remote): Don't initialize ptid globals.
9007
9008 2019-03-12  Pedro Alves  <palves@redhat.com>
9009
9010         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9011
9012 2019-03-12  Pedro Alves  <palves@redhat.com>
9013
9014         * cp-name-parser.y (main): Remove unused 'len' variable.
9015
9016 2019-03-12  Tom Tromey  <tromey@adacore.com>
9017
9018         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9019         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9020
9021 2019-03-12  Tom Tromey  <tromey@adacore.com>
9022
9023         * linux-nat.c (iterate_over_lwps): Update.
9024         (stop_callback): Remove parameter.
9025         (stop_wait_callback, detach_callback, resume_set_callback)
9026         (select_singlestep_lwp_callback, set_ignore_sigint)
9027         (status_callback, resumed_callback, resume_clear_callback)
9028         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9029         data parameter.
9030         (linux_nat_target::detach, linux_nat_target::resume)
9031         (linux_stop_and_wait_all_lwps, select_event_lwp)
9032         (linux_nat_filter_event, linux_nat_wait_1)
9033         (linux_nat_target::kill, linux_nat_target::stop)
9034         (linux_nat_target::stop): Update.
9035         (linux_nat_resume_callback): Change type.
9036         (resume_stopped_resumed_lwps, count_events_callback)
9037         (select_event_lwp_callback): Likewise.
9038         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9039         * arm-linux-nat.c (struct update_registers_data): Remove.
9040         (update_registers_callback): Change type.
9041         (arm_linux_insert_hw_breakpoint1): Update.
9042         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9043         parameter.
9044         (x86_linux_dr_set_addr): Update.
9045         (x86_linux_dr_set_control): Update.
9046         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9047         (iterate_over_lwps): Use gdb::function_view.
9048         * nat/aarch64-linux-hw-point.c (struct
9049         aarch64_dr_update_callback_param): Remove.
9050         (debug_reg_change_callback): Change type.
9051         (aarch64_notify_debug_reg_change): Update.
9052         * s390-linux-nat.c (s390_refresh_per_info): Update.
9053
9054 2019-03-11  Tom Tromey  <tromey@adacore.com>
9055
9056         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9057         redundant assignment to "this_cu".
9058
9059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9060
9061         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9062
9063 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9064
9065         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9066         from...
9067         (rank_one_type): ... this.
9068
9069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9070
9071         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9072         from...
9073         (rank_one_type): ... this.
9074
9075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9076
9077         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9078         from...
9079         (rank_one_type): ... this.
9080
9081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9082
9083         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9084         from...
9085         (rank_one_type): ... this.
9086
9087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9088
9089         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9090         from...
9091         (rank_one_type): ... this.
9092
9093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9094
9095         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9096         from...
9097         (rank_one_type): ... this.
9098
9099 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9100
9101         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9102         from...
9103         (rank_one_type): ... this.
9104
9105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9106
9107         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9108         from...
9109         (rank_one_type): ... this.
9110
9111 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9112
9113         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9114         from...
9115         (rank_one_type): ... this.
9116
9117 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9118
9119         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9120         from...
9121         (rank_one_type): ... this.
9122
9123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9124
9125         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9126         from...
9127         (rank_one_type): ... this.
9128
9129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9130
9131         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9132         from...
9133         (rank_one_type): ... this.
9134
9135 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9136
9137         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9138         inferior-events' shows the example events.
9139
9140 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9141
9142         Support styling on native MS-Windows console
9143
9144         PR/24315
9145         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9146         on MS-Windows if $TERM is not defined.
9147
9148         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9149
9150         * posix-hdep.c (gdb_console_fputs):
9151         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9152         functions.
9153         * ui-file.h (gdb_console_fputs): Add prototype.
9154
9155         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9156         back to fputs only if the former returns zero.
9157
9158 2019-03-07  Tom Tromey  <tom@tromey.com>
9159
9160         * symmisc.c (print_symbol_bcache_statistics): Update.
9161         (print_objfile_statistics): Update.
9162         * symfile.c (allocate_symtab): Update.
9163         * stabsread.c: Don't include bcache.h.
9164         * psymtab.h (struct psymbol_bcache): Don't declare.
9165         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9166         (psymbol_bcache_init, psymbol_bcache_free)
9167         (psymbol_bcache_get_bcache): Don't declare.
9168         * psymtab.c (struct psymbol_bcache): Remove.
9169         (psymtab_storage::psymtab_storage): Update.
9170         (psymtab_storage::~psymtab_storage): Update.
9171         (psymbol_bcache_init, psymbol_bcache_free)
9172         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9173         (add_psymbol_to_bcache): Update.
9174         (allocate_psymtab): Update.
9175         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9176         macro_cache>: No longer pointers.
9177         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9178         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9179         * macrotab.c (macro_bcache): Update.
9180         * macroexp.c: Don't include bcache.h.
9181         * gdbtypes.c (check_types_worklist): Update.
9182         (types_deeply_equal): Remove TRY/CATCH.  Update.
9183         * elfread.c (elf_symtab_read): Update.
9184         * dwarf2read.c: Don't include bcache.h.
9185         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9186         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9187         (print_bcache_statistics, bcache_memory_used): Don't declare.
9188         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9189         methods.  Rename all data members.
9190         * bcache.c (struct bcache): Move to bcache.h.
9191         (bcache::expand_hash_table): Rename from expand_hash_table.
9192         (bcache): Remove.
9193         (bcache::insert): Rename from bcache_full.
9194         (bcache::compare): Rename from bcache_compare.
9195         (bcache_xmalloc): Remove.
9196         (bcache::~bcache): Rename from bcache_xfree.
9197         (bcache::print_statistics): Rename from print_bcache_statistics.
9198         (bcache::memory_used): Rename from bcache_memory_used.
9199
9200 2019-03-07  Pedro Alves  <palves@redhat.com>
9201
9202         * infrun.c (normal_stop): Also check for
9203         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9204
9205 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9206
9207         * f-lang.c (value_from_host_double): Moved to...
9208         * value.c (value_from_host_double): ...here.
9209         * value.h (value_from_host_double): Declare.
9210         * guile/scm-math.c (vlscm_convert_typed_number): Use
9211         value_from_host_double.
9212         (vlscm_convert_number): Likewise.
9213         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9214         * python/py-value.c (convert_value_from_python): Likewise.
9215
9216 2019-03-06  Tom Tromey  <tom@tromey.com>
9217
9218         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9219
9220 2019-03-06  Tom Tromey  <tom@tromey.com>
9221
9222         * utils.h (free_current_contents): Don't declare.
9223         * utils.c (free_current_contents): Remove.
9224
9225 2019-03-06  Tom Tromey  <tom@tromey.com>
9226
9227         * top.c (quit_force): Update.
9228         * main.c (captured_command_loop): Update.
9229         * common/new-op.c (operator new): Update.
9230         * common/common-exceptions.c (struct catcher)
9231         <save_cleanup_chain>: Remove member.
9232         (exceptions_state_mc_init): Update.
9233         (exception_try_scope_entry): Return nullptr.
9234         (exception_try_scope_exit, exception_rethrow)
9235         (throw_exception_sjlj, throw_exception_cxx): Update.
9236         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9237         (all_cleanups, do_cleanups, discard_cleanups)
9238         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9239         (restore_cleanups, restore_final_cleanups): Don't declare.
9240         (do_final_cleanups): Remove parameter.
9241         * common/cleanups.c (cleanup_chain, make_cleanup)
9242         (make_cleanup_dtor, all_cleanups, do_cleanups)
9243         (discard_my_cleanups, discard_cleanups)
9244         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9245         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9246         (null_cleanup): Remove.
9247         (do_final_cleanups): Remove parameter.
9248
9249 2019-03-06  Tom Tromey  <tom@tromey.com>
9250
9251         * remote.c (remote_target::remote_parse_stop_reply): Use
9252         unique_xmalloc_ptr.
9253
9254 2019-03-06  Tom Tromey  <tom@tromey.com>
9255
9256         * stabsread.c (struct stabs_field_info): Rename from field_info.
9257         <list, fnlist>: Add initializers.
9258         <obstack>: New member.
9259         (read_member_functions, read_struct_fields, read_baseclasses):
9260         Allocate on obstack.  Don't use cleanups.
9261         (read_one_struct_field, read_member_functions, read_struct_fields)
9262         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9263         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9264         (read_struct_type): Update.
9265
9266 2019-03-06  Tom Tromey  <tom@tromey.com>
9267
9268         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9269         * common/filestuff.h (make_cleanup_close): Don't declare.
9270         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9271         Remove.
9272
9273 2019-03-06  Tom Tromey  <tom@tromey.com>
9274
9275         * solib-aix.c: Use make_scope_exit.
9276
9277 2019-03-06  Tom Tromey  <tom@tromey.com>
9278
9279         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9280         Use make_scope_exit.
9281
9282 2019-03-06  Tom Tromey  <tom@tromey.com>
9283
9284         * solib-svr4.c (disable_probes_interface): Remove parameter.
9285         (svr4_handle_solib_event): Use make_scope_exit.
9286
9287 2019-03-06  Tom Tromey  <tom@tromey.com>
9288
9289         * remote.c (struct stop_reply_deleter): Remove.
9290         (stop_reply_up): Update.
9291         (struct stop_reply): Derive from notif_event.  Don't typedef.
9292         <regcache>: Now a std::vector.
9293         (stop_reply_xfree): Remove.
9294         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9295         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9296         (remote_target::discard_pending_stop_replies): Use delete.
9297         (remote_target::remote_parse_stop_reply): Update.
9298         (remote_target::process_stop_reply): Update.
9299         * remote-notif.h (struct notif_event): Add virtual destructor.
9300         Remove "dtr" member.
9301         (struct notif_client) <alloc_event>: Return a unique_ptr.
9302         (notif_event_xfree): Don't declare.
9303         (notif_event_up): New typedef.
9304         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9305         (notif_event_xfree, do_notif_event_xfree): Remove.
9306         (remote_notif_state_xfree): Update.
9307
9308 2019-03-06  Tom Tromey  <tom@tromey.com>
9309
9310         * infrun.c (displaced_step_clear_cleanup): Now a
9311         forward_scope_exit type.
9312         (displaced_step_prepare_throw): Update.
9313         (displaced_step_fixup): Update.
9314
9315 2019-03-06  Tom Tromey  <tom@tromey.com>
9316
9317         * inferior.h (class inferior): Update comment.
9318         * gdbthread.h (class thread_info): Update comment.
9319
9320 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9321             Tom Tromey  <tom@tromey.com>
9322
9323         * stabsread.h (struct stab_section_list): Remove.
9324         (coffstab_build_psymtabs): Update.
9325         * dbxread.c (symbuf_sections): Now a std::vector.
9326         (sect_idx): New global.
9327         (fill_symbuf): Update.
9328         (coffstab_build_psymtabs): Change type of stabsects parameter.
9329         Update.
9330         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9331         std::vector.
9332         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9333         (coff_locate_sections): Update.
9334         (coff_symfile_read): Remove cleanups.  Update.
9335         (init_stringtab): Add storage parameter.
9336         (free_stringtab, free_stringtab_cleanup): Remove.
9337         (init_lineno): Add storage parameter.
9338         (free_linetab, free_linetab_cleanup): Remove.
9339
9340 2019-03-06  Pedro Alves  <palves@redhat.com>
9341
9342         * linux-fork.c (fork_info::clobber_regs): Delete.
9343         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9344         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9345         comment.  Adjust.
9346         (scoped_switch_fork_info::scoped_switch_fork_info)
9347         (checkpoint_command, linux_fork_context): Adjust
9348         fork_save_infrun_state calls.
9349
9350 2019-03-06  Pedro Alves  <palves@redhat.com>
9351
9352         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9353         (inf_has_multiple_threads): Return 'bool' and rewrite using
9354         inferior_info::threads().
9355
9356 2019-03-06  Pedro Alves  <palves@redhat.com>
9357
9358         * linux-fork.c: Include <list>.
9359         (fork_list): Now a std::list instance.
9360         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9361         (forks_exist_p, find_last_fork): Adjust.
9362         (new_fork): Delete.
9363         (one_fork_p): New.
9364         (add_fork): Adjust.
9365         (free_fork): Delete, folded into fork_info::~fork_info().
9366         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9367         Adjust.
9368         (init_fork_list): Delete.
9369         (linux_fork_killall, linux_fork_mourn_inferior)
9370         (linux_fork_detach, info_checkpoints_command): Adjust.
9371         (_initialize_linux_fork): No longer call init_fork_list.
9372
9373 2019-03-06  Pedro Alves  <palves@redhat.com>
9374
9375         * linux-fork.c (new_fork): New, split out of ...
9376         (add_fork): ... this.  Return void.  Move "first fork" special
9377         case from here, to ...
9378         (checkpoint_command): ... here.
9379         * linux-linux.h (add_fork): Return void.
9380
9381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9382
9383         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9384
9385 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9386             Chris January  <chris.january@arm.com>
9387             David Lecomber  <david.lecomber@arm.com>
9388
9389         * f-exp.y: New token, UNOP_INTRINSIC.
9390         (exp): New pattern using UNOP_INTRINSIC token.
9391         (f77_keywords): Add 'abs' keyword.
9392         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9393         (value_from_host_double): New function.
9394         (evaluate_subexp_f): Support UNOP_ABS.
9395
9396 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9397
9398         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9399         types.
9400
9401 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9402
9403         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9404         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9405         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9406
9407 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9408
9409         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9410
9411 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9412             Chris January  <chris.january@arm.com>
9413
9414         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9415         * f-exp.y: Define 'KIND' token.
9416         (exp): New pattern for KIND expressions.
9417         (ptype): Handle types with a kind extension.
9418         (direct_abs_decl): Extend to spot kind extensions.
9419         (f77_keywords): Add 'kind' to the list.
9420         (push_kind_type): New function.
9421         (convert_to_kind_type): New function.
9422         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9423         * parse.c (operator_length_standard): Likewise.
9424         * parser-defs.h (enum type_pieces): Add tp_kind.
9425         * std-operator.def: Add UNOP_KIND.
9426
9427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * f-exp.y (f_parse): Set yydebug.
9430
9431 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9432
9433         * f-lang.c (evaluate_subexp_f): New function.
9434         (exp_descriptor_f): New global.
9435         (f_language_defn): Use exp_descriptor_f instead of
9436         exp_descriptor_standard.
9437
9438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9439
9440         * f-exp.y (struct token): Add comments.
9441         (dot_ops): Remove uppercase versions and the end marker.
9442         (f77_keywords): Likewise.
9443         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9444         entries in the dot_ops array are case insensitive, and use
9445         strncasecmp to compare strings.  Also some whitespace cleanup in
9446         this area.  Similar for the f77_keywords array, except entries in
9447         this list might be case sensitive.
9448
9449 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9450
9451         * f-exp.y (struct f77_boolean_val): Add comments.
9452         (boolean_values): Remove uppercase versions, and end marker.
9453         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9454         and use strncasecmp to achieve case insensitivity.  Additionally,
9455         perform whitespace cleanup around this code.
9456
9457 2019-03-06  Tom Tromey  <tromey@adacore.com>
9458
9459         * remote-sim.c (gdbsim_target_open): Use result of
9460         gdb_argv::release.
9461
9462 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9463         Dirk Schubert  <dirk.schubert@arm.com>
9464         Chris January  <chris.january@arm.com>
9465
9466         * eval.c (evaluate_subexp_standard): Call Fortran argument
9467         wrapping logic.
9468         * f-lang.c (struct value): A value which can be passed into a
9469         Fortran function call.
9470         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9471         where appropriate.
9472         (struct type): Value ready for a Fortran function call.
9473         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9474         is needed.
9475         * f-lang.h (fortran_argument_convert): Declaration.
9476         (fortran_preserve_arg_pointer): Declaration.
9477         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9478
9479 2019-03-05  Tom Tromey  <tromey@adacore.com>
9480
9481         * python/py-prettyprint.c (print_string_repr): Remove #if.
9482         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9483
9484 2019-03-05  Tom Tromey  <tromey@adacore.com>
9485
9486         * target.c (the_dummy_target): Move later.  Change type to
9487         "dummy_target".
9488         (initialize_targets): Don't initialize the_dummy_target.
9489
9490 2019-03-05  Tom Tromey  <tromey@adacore.com>
9491
9492         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9493         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9494
9495 2019-03-05  Tom Tromey  <tromey@adacore.com>
9496
9497         * windows-nat.c (windows_nat_target::attach)
9498         (windows_nat_target::detach): Don't call gdb_flush.
9499         * valprint.c (generic_val_print, val_print, val_print_string):
9500         Don't call gdb_flush.
9501         * utils.c (defaulted_query): Don't call gdb_flush.
9502         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9503         * target.c (target_announce_detach): Don't call gdb_flush.
9504         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9505         * remote.c (extended_remote_target::attach): Don't call
9506         gdb_flush.
9507         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9508         * printcmd.c (do_examine): Don't call gdb_flush.
9509         (info_display_command): Don't call gdb_flush.
9510         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9511         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9512         * memattr.c (info_mem_command): Don't call gdb_flush.
9513         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9514         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9515         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9516         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9517         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9518         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9519         (gnu_nat_target::detach): Don't call gdb_flush.
9520         * f-valprint.c (f_val_print): Don't call gdb_flush.
9521         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9522         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9523         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9524         gdb_flush.
9525         * c-valprint.c (c_val_print): Don't call gdb_flush.
9526         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9527
9528 2019-03-05  Tom Tromey  <tromey@adacore.com>
9529
9530         * varobj.c (update_dynamic_varobj_children): Update.
9531         (install_default_visualizer): Use reset, not release.
9532         * value.c (set_internalvar): Update.
9533         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9534         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9535         ATTRIBUTE_UNUSED_RESULT.
9536
9537 2019-03-05  Tom Tromey  <tromey@adacore.com>
9538
9539         * remote.c (class scoped_remote_fd) <release>: Add
9540         ATTRIBUTE_UNUSED_RESULT.
9541
9542 2019-03-05  Tom Tromey  <tromey@adacore.com>
9543
9544         * macroexp.c (struct macro_buffer) <release>: Add
9545         ATTRIBUTE_UNUSED_RESULT.
9546
9547 2019-03-05  Tom Tromey  <tromey@adacore.com>
9548
9549         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9550         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9551         ATTRIBUTE_UNUSED_RESULT.
9552
9553 2019-03-05  Tom Tromey  <tromey@adacore.com>
9554
9555         * common/scoped_fd.h (class scoped_fd) <release>: Add
9556         ATTRIBUTE_UNUSED_RESULT.
9557
9558 2019-03-05  Tom Tromey  <tromey@adacore.com>
9559
9560         * parser-defs.h (struct parser_state) <release>: Add
9561         ATTRIBUTE_UNUSED_RESULT.
9562
9563 2019-03-05  Tom Tromey  <tromey@adacore.com>
9564
9565         * utils.h (class gdb_argv) <release>: Add
9566         ATTRIBUTE_UNUSED_RESULT.
9567         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9568
9569 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9570
9571         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9572         for-loop range, to avoid compiler warnings.
9573
9574         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9575         avoid compiler warnings about unused variables.
9576
9577         * NEWS: Mention end of support for native debugging on MS-Windows
9578         before XP.
9579
9580         PR gdb/24292
9581         * common/netstuff.c:
9582         * gdbserver/gdbreplay.c
9583         * gdbserver/remote-utils.c:
9584         * ser-tcp.c:
9585         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9586         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9587         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9588         'getaddrinfo' and 'freeaddrinfo' were not available before
9589         Windows XP, and mingw.org's MinGW headers by default define
9590         _WIN32_WINNT to 0x500.
9591
9592 2019-03-01  Gary Benson <gbenson@redhat.com>
9593
9594         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9595
9596 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9597             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9598
9599         PR gdb/8527
9600         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9601         set_sigint_trap, clear_sigint_trap.
9602
9603 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9604
9605         * target.c (target_detach): Clear the regcache and the
9606         frame cache.
9607
9608 2019-02-27  Pedro Alves  <palves@redhat.com>
9609
9610         * utils.c (set_screen_size): When we cap the height/width sizes,
9611         tweak the corresponding command variable to show "unlimited":
9612
9613 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9614             Pedro Alves  <palves@redhat.com>
9615
9616         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9617         before calling rl_set_screen_size.
9618
9619 2019-02-27  Tom Tromey  <tromey@adacore.com>
9620
9621         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9622         define.
9623         * python/py-value.c: Remove Python 2.4 workaround.
9624         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9625         workaround.
9626         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9627         Python 2.4 workaround.
9628         * python/python-internal.h: Remove Python 2.4 comment.
9629         (Py_ssize_t): Don't define.
9630         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9631         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9632         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9633         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9634         * python/python.c (do_start_initialization): Remove Python 2.4
9635         workaround.
9636         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9637         (print_children): Remove Python 2.4 workaround.
9638         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9639         workaround.
9640         (CHARBUFFERPROC_NAME): Remove.
9641         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9642         Python 2.4 workaround.
9643
9644 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9645
9646         * NEWS: Note minimum Python version.
9647
9648 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9649
9650         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9651         code from these functions.  Remove corresponding ifdefs.  Use
9652         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9653         Remove gotos and target of gotos.
9654         (infpy_search_memory): Likewise.
9655
9656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9657
9658         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9659         (hppa_gdbarch_init): Don't register deleted functions with
9660         gdbarch.
9661
9662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9663
9664         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9665         (h8300_unwind_sp): Delete.
9666         (h8300_dummy_id): Delete.
9667         (h8300_gdbarch_init): Don't register deleted functions with
9668         gdbarch.
9669
9670 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9671
9672         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9673         (ft32_unwind_pc): Delete.
9674         (ft32_unwind_sp): Delete.
9675         (ft32_gdbarch_init): Don't register deleted functions with
9676         gdbarch.
9677
9678 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9679
9680         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9681         (frv_unwind_pc): Delete.
9682         (frv_unwind_sp): Delete.
9683         (frv_gdbarch_init): Don't register deleted functions with
9684         gdbarch.
9685
9686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9687
9688         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9689         (riscv_unwind_pc): Delete.
9690         (riscv_unwind_sp): Delete.
9691         (riscv_gdbarch_init): Don't register deleted functions with
9692         gdbarch.
9693
9694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9695
9696         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9697         (csky_unwind_pc): Delete.
9698         (csky_unwind_sp): Delete.
9699         (csky_gdbarch_init): Don't register deleted functions with
9700         gdbarch.
9701
9702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9703
9704         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9705         (cris_unwind_pc): Delete.
9706         (cris_unwind_sp): Delete.
9707         (cris_gdbarch_init): Don't register deleted functions with
9708         gdbarch.
9709
9710 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9711
9712         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9713         (bfin_unwind_pc): Delete.
9714         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9715
9716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9717
9718         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9719         (arm_unwind_pc): Delete.
9720         (arm_unwind_sp): Delete.
9721         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9722
9723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9724
9725         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9726         (arc_unwind_pc): Delete.
9727         (arc_unwind_sp): Delete.
9728         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9729
9730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9731
9732         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9733         (alpha_unwind_pc): Delete.
9734         (alpha_gdbarch_init): Don't register deleted functions with
9735         gdbarch.
9736
9737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9738
9739         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9740         (aarch64_unwind_pc): Delete.
9741         (aarch64_unwind_sp): Delete.
9742         (aarch64_gdbarch_init): Don't register deleted functions with
9743         gdbarch.
9744
9745 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9746
9747         * gdbtypes.c (type_align): Don't consider static members when
9748         computing structure alignment.
9749
9750 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9751
9752         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9753         return 0 for other types.
9754         * arch-utils.c (default_type_align): Always return 0.
9755         * gdbarch.h: Regenerate.
9756         * gdbarch.sh (type_align): Extend comment.
9757         * gdbtypes.c (type_align): Add additional comments, always call
9758         gdbarch_type_align before applying the default rules.
9759         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9760         generic code will then apply a suitable default.
9761         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9762         types, return 0 for other types.
9763
9764 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9765
9766         * NEWS: Create a new section for the next release branch.
9767         Rename the section of the current branch, now that it has
9768         been cut.
9769
9770 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9771
9772         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9773         * version.in: Bump version to 8.3.50.DATE-git.
9774
9775 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9776
9777         * aix-thread.c (ptid_cmp): Remove unused variable.
9778         (get_signaled_thread): Likewise.
9779         (store_regs_user_thread): Likewise.
9780         (store_regs_kernel_thread): Likewise.
9781         (fetch_regs_kernel_thread): Remove shadowed variable.
9782
9783 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9784
9785         * features/riscv/32bit-cpu.xml: Add register numbers.
9786         * features/riscv/32bit-fpu.c: Regenerate.
9787         * features/riscv/32bit-fpu.xml: Add register numbers.
9788         * features/riscv/64bit-cpu.xml: Add register numbers.
9789         * features/riscv/64bit-fpu.c: Regenerate.
9790         * features/riscv/64bit-fpu.xml: Add register numbers.
9791
9792 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9793
9794         * NEWS: Mention two argument form of gdb.Value constructor.
9795         * python/py-value.c (convert_buffer_and_type_to_value): New
9796         function.
9797         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9798         Add support for handling an optional second argument.  Call
9799         convert_buffer_and_type_to_value as appropriate.
9800         * python/python-internal.h (Py_buffer_deleter): New struct.
9801         (Py_buffer_up): New typedef.
9802
9803 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9804
9805         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9806         instead of releasing ownership.
9807
9808 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9809
9810         * dwarf2read.c (open_and_init_dwp_file): Call
9811         elf_numsections instead of bfd_count_sections to initialize
9812         dwp_file->num_sections.
9813
9814 2019-02-25  Tom Tromey  <tromey@adacore.com>
9815
9816         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9817
9818 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9819
9820         * gcore.in: Add '--readnever' option when invoking GDB.
9821
9822 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9823
9824         * MAINTAINERS: Update my email address.
9825
9826 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9827
9828         * build-id.c (build_id_to_debug_bfd_1): New function.
9829         (build_id_to_debug_bfd): Look for separate debug file in
9830         sysroot.
9831
9832 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9833
9834         * gdbarch.sh: Update the copyright year range that is placed into
9835         generated files.
9836
9837 2019-02-22  Keith Seitz  <keiths@redhat.com>
9838
9839         PR symtab/23853
9840         * linespec.c (create_sals_line_offset): Search for the default
9841         symtab's filename instead of its fullname.
9842
9843 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9844
9845         * NEWS: Update style defaults.
9846
9847 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9848
9849         * main.c (captured_main_1): Disable styling in batch mode.
9850
9851 2019-02-20  Tom Tromey  <tom@tromey.com>
9852
9853         * symtab.c (symtab_symbol_info): Fix typos.
9854
9855 2019-02-20  Tom Tromey  <tromey@adacore.com>
9856
9857         * findcmd.c (_initialize_mem_search): Use upper case for
9858         metasyntactic variables.
9859
9860 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9861
9862         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9863         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9864
9865 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9866
9867         * top.h (source_file_name): Change to std::string.
9868         * top.c (source_file_name): Likewise.
9869         (command_line_input): Adjust.
9870         * cli/cli-script.c (script_from_file): Adjust.
9871
9872 2019-02-19  Tom Tromey  <tromey@adacore.com>
9873
9874         * ravenscar-thread.c
9875         (ravenscar_thread_target::update_thread_list): Don't call
9876         ada_build_task_list.
9877         * ada-lang.h (ada_build_task_list): Don't declare.
9878         * ada-tasks.c (struct ada_tasks_inferior_data)
9879         <task_list_valid_p>: Now bool.
9880         (read_known_tasks, ada_task_list_changed)
9881         (ada_tasks_invalidate_inferior_data): Update.
9882         (read_known_tasks_array): Return bool.
9883         (read_known_tasks_list): Likewise.
9884         (read_known_tasks): Return void.
9885         (ada_build_task_list): Now static.
9886
9887 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9888
9889         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9890         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9891
9892 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9893
9894         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9895         variant for ada_tasks_pspace_data_handle and
9896         ada_tasks_inferior_data_handle.
9897         (ada_tasks_pspace_data_cleanup): New function.
9898         (ada_tasks_inferior_data_cleanup): New function.
9899
9900 2019-02-17  Tom Tromey  <tom@tromey.com>
9901
9902         * macrotab.h (macro_source_fullname): Return a std::string.
9903         * macrotab.c (macro_include, check_for_redefinition)
9904         (macro_undef, macro_lookup_definition, foreach_macro)
9905         (foreach_macro_in_scope): Update.
9906         (macro_source_fullname): Return a std::string.
9907         * macrocmd.c (show_pp_source_pos): Update.
9908
9909 2019-02-17  Tom Tromey  <tom@tromey.com>
9910
9911         * macrocmd.c (show_pp_source_pos): Style the file names.
9912
9913 2019-02-17  Tom Tromey  <tom@tromey.com>
9914
9915         PR tui/24197:
9916         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9917
9918 2019-02-17  Tom Tromey  <tom@tromey.com>
9919
9920         * ada-lang.c (user_select_syms): Use filtered printing.
9921         * utils.c (wrap_style): New global.
9922         (desired_style): Remove.
9923         (emit_style_escape): Add stream parameter.
9924         (set_output_style, reset_terminal_style, prompt_for_continue):
9925         Update.
9926         (flush_wrap_buffer): Only flush gdb_stdout.
9927         (wrap_here): Set wrap_style.
9928         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9929         treat escape sequences as a character.  Change when wrap buffer is
9930         flushed.
9931         (fputs_styled): Do not set the output style when the default is
9932         requested.
9933         * ui-style.h (struct ui_file_style) <is_default>: New method.
9934         * source.c (print_source_lines_base): Emit escape sequences in one
9935         piece.
9936
9937 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9938
9939         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9940         integers and enumeration types.
9941
9942 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9943
9944         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9945         instead of lookup_symbol_in_language
9946         (do_exact_match): New function.
9947         (ada_get_symbol_name_matcher): Return do_exact_match when
9948         doing a verbatim match.
9949
9950 2019-02-15  Tom Tromey  <tromey@adacore.com>
9951
9952         * ravenscar-thread.c (ravenscar_thread_target::resume)
9953         (ravenscar_thread_target::wait): Special case wildcard requests.
9954
9955 2019-02-15  Tom Tromey  <tromey@adacore.com>
9956
9957         * ravenscar-thread.c (base_ptid): Remove.
9958         (struct ravenscar_thread_target) <close>: New method.
9959         <m_base_ptid>: New member.
9960         <update_inferior_ptid, active_task, task_is_currently_active,
9961         runtime_initialized>: Declare methods.
9962         <ravenscar_thread_target>: Add constructor.
9963         (ravenscar_thread_target::task_is_currently_active)
9964         (ravenscar_thread_target::update_inferior_ptid)
9965         (ravenscar_runtime_initialized): Rename.  Now methods.
9966         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9967         (ravenscar_thread_target::update_thread_list): Update.
9968         (ravenscar_thread_target::active_task): Now method.
9969         (ravenscar_thread_target::store_registers)
9970         (ravenscar_thread_target::prepare_to_store)
9971         (ravenscar_thread_target::prepare_to_store)
9972         (ravenscar_thread_target::mourn_inferior): Update.
9973         (ravenscar_inferior_created): Use "new" to create target.
9974         (ravenscar_thread_target::get_ada_task_ptid): Update.
9975         (_initialize_ravenscar): Don't initialize base_ptid.
9976         (ravenscar_ops): Remove global.
9977
9978 2019-02-15  Tom Tromey  <tromey@adacore.com>
9979
9980         * target.h (push_target): Declare new overload.
9981         * target.c (push_target): New overload, taking an rvalue reference.
9982         * remote.c (remote_target::open_1): Use push_target overload.
9983         * corelow.c (core_target_open): Use push_target overload.
9984
9985 2019-02-15  Tom Tromey  <tromey@adacore.com>
9986
9987         * ravenscar-thread.c (is_ravenscar_task)
9988         (ravenscar_task_is_currently_active): Return bool.
9989         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9990         (_initialize_ravenscar): Remove "(void)".
9991         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9992         Return bool.
9993
9994 2019-02-15  Tom Tromey  <tromey@adacore.com>
9995
9996         * ravenscar-thread.c (ravenscar_runtime_initializer)
9997         (has_ravenscar_runtime, get_running_thread_id)
9998         (ravenscar_thread_target::resume): Fix indentation.
9999
10000 2019-02-15  Tom Tromey  <tromey@adacore.com>
10001
10002         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10003         from ravenscar_arch_ops.
10004         (sparc_ravenscar_ops::fetch_registers)
10005         (sparc_ravenscar_ops::store_registers): Now methods.
10006         (sparc_ravenscar_prepare_to_store): Remove.
10007         (sparc_ravenscar_ops): Redefine.
10008         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10009         methods and destructor.  Remove members.
10010         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10011         (ravenscar_thread_target::store_registers)
10012         (ravenscar_thread_target::prepare_to_store): Update.
10013         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10014         Remove.
10015         (struct ppc_ravenscar_powerpc_ops): Derive from
10016         ravenscar_arch_ops.
10017         (ppc_ravenscar_powerpc_ops::fetch_registers)
10018         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10019         (ppc_ravenscar_powerpc_ops): Redefine.
10020         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10021         (ppc_ravenscar_e500_ops::fetch_registers)
10022         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10023         (ppc_ravenscar_e500_ops): Redefine.
10024         * aarch64-ravenscar-thread.c
10025         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10026         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10027         (aarch64_ravenscar_fetch_registers)
10028         (aarch64_ravenscar_store_registers): Now methods.
10029         (aarch64_ravenscar_ops): Redefine.
10030
10031 2019-02-15  Tom Tromey  <tromey@adacore.com>
10032
10033         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10034         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10035         (ravenscar_thread_target::stopped_by_watchpoint)
10036         (ravenscar_thread_target::stopped_data_address)
10037         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10038
10039 2019-02-15  Tom Tromey  <tromey@adacore.com>
10040
10041         * ravenscar-thread.c: Fix some typos.
10042
10043 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10044             Tom Tromey  <tromey@adacore.com>
10045
10046         * ada-lang.c (ada_exception_sal): Change addr_string to a
10047         std::string.
10048         (create_ada_exception_catchpoint): Update.
10049
10050 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10051             Tom Tromey  <tromey@adacore.com>
10052
10053         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10054         (bp_location_ops): Remove.
10055         (base_breakpoint_allocate_location): Update.
10056         (free_bp_location): Update.
10057         * ada-lang.c (class ada_catchpoint_location)
10058         <ada_catchpoint_location>: Remove ops parameter.
10059         (ada_catchpoint_location_dtor): Remove.
10060         (ada_catchpoint_location_ops): Remove.
10061         (allocate_location_exception): Update.
10062         * breakpoint.h (struct bp_location_ops): Remove.
10063         (class bp_location) <bp_location>: Remove bp_location_ops
10064         parameter.
10065         <~bp_location>: Add destructor.
10066         <ops>: Remove.
10067
10068 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10069             Pedro Alves  <palves@redhat.com>
10070
10071         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10072         'PATH_MAX'.
10073
10074 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10075             Samuel Thibault  <samuel.thibault@gnu.org>
10076             Thomas Schwinge  <thomas@codesourcery.com>
10077
10078         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10079         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10080
10081 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10082
10083         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10084         (check_empty): Use "const char *".
10085
10086         * gnu-nat.c (gnu_nat_target::detach): Instead of
10087         'detach_inferior (pid)' call
10088         'detach_inferior (find_inferior_pid (pid))'.
10089
10090         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10091         'nat/fork-inferior.o'.
10092         * gnu-nat.c: #include "nat/fork-inferior.h".
10093
10094         * gnu-nat.c (gnu_nat_target::detach): Instead of
10095         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10096         * gnu-nat.h: #include "inf-child.h".
10097         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10098         'i386_gnu_nat_target::fetch_registers'.
10099         (gnu_store_registers): Rename/move to
10100         'i386_gnu_nat_target::store_registers'.
10101
10102         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10103         * gnu-nat.h (mach_thread_info): New function.
10104         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10105
10106         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10107
10108 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10109
10110         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10111
10112 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10113
10114         * windows-nat.c (windows_add_thread): Add new parameter
10115         "main_thread_p" with default value set to false.  Update
10116         function documentation as well as all callers.
10117         (windows_delete_thread): Likewise.
10118         (fake_create_process): Update call to windows_add_thread.
10119         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10120         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10121         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10122         call to windows_delete_thread.
10123
10124 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10125
10126         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10127
10128 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10129
10130         * symfile.c (find_separate_debug_file): Use canonical path of
10131         sysroot with child_path instead of gdb_sysroot if it is valid.
10132
10133 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10134
10135         * symfile.c (find_separate_debug_file): Use child_path to
10136         determine if an object file is under a sysroot.
10137
10138 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10139
10140         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10141         unittests/child-path-selftests.c.
10142         * common/pathstuff.c (child_path): New function.
10143         * common/pathstuff.h (child_path): New prototype.
10144         * unittests/child-path-selftests.c: New file.
10145
10146 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10147
10148         * symfile.c (find_separate_debug_file): Look for separate debug
10149         files in debug directories under the sysroot.
10150
10151 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10152
10153         * symtab.h (struct minimal_symbol data_p): New const method.
10154         (struct minimal_symbol text_p): Likewise.
10155         * symtab.c (output_source_filename): Use file name style
10156         to print file name.
10157         (print_symbol_info): Likewise.
10158         (print_msymbol_info): Use address style to print addresses.
10159         Use function name style to print executable text symbols.
10160         (expand_symtab_containing_pc): Use data_p.
10161         (find_pc_sect_compunit_symtab): Likewise.
10162
10163 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10164
10165         * breakpoint.c (describe_other_breakpoints): Use address style
10166         to print addresses.
10167         (say_where): Likewise.
10168
10169 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10170
10171         * ada-typeprint.c (print_func_type): Print function name
10172         style to print function name.
10173         * c-typeprint.c (c_print_type_1): Likewise.
10174
10175 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10176
10177         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10178         for execve.
10179
10180 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10181
10182         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10183         type_stack.
10184
10185 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10186
10187         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10188         TYPE_CODE_REF types.
10189
10190 2019-02-08  Jim Wilson  <jimw@sifive.com>
10191
10192         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10193         (riscv_linux_fregset): New.
10194         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10195
10196 2019-02-07  Tom Tromey  <tom@tromey.com>
10197
10198         * thread.c (thread_cancel_execution_command): Update.
10199         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10200         methods.
10201         (struct thread_fsm_ops): Remove.
10202         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10203         (thread_fsm_should_stop, thread_fsm_return_value)
10204         (thread_fsm_set_finished, thread_fsm_finished_p)
10205         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10206         Don't declare.
10207         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10208         * infrun.c (clear_proceed_status_thread)
10209         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10210         (print_stop_event): Update.
10211         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10212         Add constructor.
10213         (step_command_fsm_ops): Remove.
10214         (new_step_command_fsm): Remove.
10215         (step_1): Update.
10216         (step_command_fsm::should_stop): Rename from
10217         step_command_fsm_should_stop.
10218         (step_command_fsm::clean_up): Rename from
10219         step_command_fsm_clean_up.
10220         (step_command_fsm::do_async_reply_reason): Rename from
10221         step_command_fsm_async_reply_reason.
10222         (struct until_next_fsm): Inherit from thread_fsm.  Add
10223         constructor.
10224         (until_next_fsm_ops): Remove.
10225         (new_until_next_fsm): Remove.
10226         (until_next_fsm::should_stop): Rename from
10227         until_next_fsm_should_stop.
10228         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10229         (until_next_fsm::do_async_reply_reason): Rename from
10230         until_next_fsm_async_reply_reason.
10231         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10232         constructor.  Change type of breakpoint.
10233         (finish_command_fsm_ops): Remove.
10234         (new_finish_command_fsm): Remove.
10235         (finish_command_fsm::should_stop): Rename from
10236         finish_command_fsm_should_stop.
10237         (finish_command_fsm::clean_up): Rename from
10238         finish_command_fsm_clean_up.
10239         (finish_command_fsm::return_value): Rename from
10240         finish_command_fsm_return_value.
10241         (finish_command_fsm::do_async_reply_reason): Rename from
10242         finish_command_fsm_async_reply_reason.
10243         (finish_command): Update.
10244         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10245         Add constructor.
10246         (call_thread_fsm_ops): Remove.
10247         (call_thread_fsm::call_thread_fsm): Rename from
10248         new_call_thread_fsm.
10249         (call_thread_fsm::should_stop): Rename from
10250         call_thread_fsm_should_stop.
10251         (call_thread_fsm::should_notify_stop): Rename from
10252         call_thread_fsm_should_notify_stop.
10253         (run_inferior_call, call_function_by_hand_dummy): Update.
10254         * cli/cli-interp.c (should_print_stop_to_console): Update.
10255         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10256         Add constructor.  Change type of location_breakpoint,
10257         caller_breakpoint.
10258         (until_break_fsm_ops): Remove.
10259         (new_until_break_fsm): Remove.
10260         (until_break_fsm::should_stop): Rename from
10261         until_break_fsm_should_stop.
10262         (until_break_fsm::clean_up): Rename from
10263         until_break_fsm_clean_up.
10264         (until_break_fsm::do_async_reply_reason): Rename from
10265         until_break_fsm_async_reply_reason.
10266         (until_break_command): Update.
10267         * thread-fsm.c: Remove.
10268         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10269
10270 2019-02-07  Tom Tromey  <tom@tromey.com>
10271
10272         * yy-remap.h: Add include guard.
10273         * xtensa-tdep.h: Add include guard.
10274         * xcoffread.h: Rename include guard.
10275         * varobj-iter.h: Add include guard.
10276         * tui/tui.h: Rename include guard.
10277         * tui/tui-winsource.h: Rename include guard.
10278         * tui/tui-wingeneral.h: Rename include guard.
10279         * tui/tui-windata.h: Rename include guard.
10280         * tui/tui-win.h: Rename include guard.
10281         * tui/tui-stack.h: Rename include guard.
10282         * tui/tui-source.h: Rename include guard.
10283         * tui/tui-regs.h: Rename include guard.
10284         * tui/tui-out.h: Rename include guard.
10285         * tui/tui-layout.h: Rename include guard.
10286         * tui/tui-io.h: Rename include guard.
10287         * tui/tui-hooks.h: Rename include guard.
10288         * tui/tui-file.h: Rename include guard.
10289         * tui/tui-disasm.h: Rename include guard.
10290         * tui/tui-data.h: Rename include guard.
10291         * tui/tui-command.h: Rename include guard.
10292         * tic6x-tdep.h: Add include guard.
10293         * target/waitstatus.h: Rename include guard.
10294         * target/wait.h: Rename include guard.
10295         * target/target.h: Rename include guard.
10296         * target/resume.h: Rename include guard.
10297         * target-float.h: Rename include guard.
10298         * stabsread.h: Add include guard.
10299         * rs6000-tdep.h: Add include guard.
10300         * riscv-fbsd-tdep.h: Add include guard.
10301         * regformats/regdef.h: Rename include guard.
10302         * record.h: Rename include guard.
10303         * python/python.h: Rename include guard.
10304         * python/python-internal.h: Rename include guard.
10305         * python/py-stopevent.h: Rename include guard.
10306         * python/py-ref.h: Rename include guard.
10307         * python/py-record.h: Rename include guard.
10308         * python/py-record-full.h: Rename include guard.
10309         * python/py-record-btrace.h: Rename include guard.
10310         * python/py-instruction.h: Rename include guard.
10311         * python/py-events.h: Rename include guard.
10312         * python/py-event.h: Rename include guard.
10313         * procfs.h: Add include guard.
10314         * proc-utils.h: Add include guard.
10315         * p-lang.h: Add include guard.
10316         * or1k-tdep.h: Rename include guard.
10317         * observable.h: Rename include guard.
10318         * nto-tdep.h: Rename include guard.
10319         * nat/x86-linux.h: Rename include guard.
10320         * nat/x86-linux-dregs.h: Rename include guard.
10321         * nat/x86-gcc-cpuid.h: Add include guard.
10322         * nat/x86-dregs.h: Rename include guard.
10323         * nat/x86-cpuid.h: Rename include guard.
10324         * nat/ppc-linux.h: Rename include guard.
10325         * nat/mips-linux-watch.h: Rename include guard.
10326         * nat/linux-waitpid.h: Rename include guard.
10327         * nat/linux-ptrace.h: Rename include guard.
10328         * nat/linux-procfs.h: Rename include guard.
10329         * nat/linux-osdata.h: Rename include guard.
10330         * nat/linux-nat.h: Rename include guard.
10331         * nat/linux-namespaces.h: Rename include guard.
10332         * nat/linux-btrace.h: Rename include guard.
10333         * nat/glibc_thread_db.h: Rename include guard.
10334         * nat/gdb_thread_db.h: Rename include guard.
10335         * nat/gdb_ptrace.h: Rename include guard.
10336         * nat/fork-inferior.h: Rename include guard.
10337         * nat/amd64-linux-siginfo.h: Rename include guard.
10338         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10339         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10340         * nat/aarch64-linux.h: Rename include guard.
10341         * nat/aarch64-linux-hw-point.h: Rename include guard.
10342         * mn10300-tdep.h: Add include guard.
10343         * mips-linux-tdep.h: Add include guard.
10344         * mi/mi-parse.h: Rename include guard.
10345         * mi/mi-out.h: Rename include guard.
10346         * mi/mi-main.h: Rename include guard.
10347         * mi/mi-interp.h: Rename include guard.
10348         * mi/mi-getopt.h: Rename include guard.
10349         * mi/mi-console.h: Rename include guard.
10350         * mi/mi-common.h: Rename include guard.
10351         * mi/mi-cmds.h: Rename include guard.
10352         * mi/mi-cmd-break.h: Rename include guard.
10353         * m2-lang.h: Add include guard.
10354         * location.h: Rename include guard.
10355         * linux-record.h: Rename include guard.
10356         * linux-nat.h: Add include guard.
10357         * linux-fork.h: Add include guard.
10358         * i386-darwin-tdep.h: Rename include guard.
10359         * hppa-linux-offsets.h: Add include guard.
10360         * guile/guile.h: Rename include guard.
10361         * guile/guile-internal.h: Rename include guard.
10362         * gnu-nat.h: Rename include guard.
10363         * gdb-stabs.h: Rename include guard.
10364         * frv-tdep.h: Add include guard.
10365         * f-lang.h: Add include guard.
10366         * event-loop.h: Add include guard.
10367         * darwin-nat.h: Rename include guard.
10368         * cp-abi.h: Rename include guard.
10369         * config/sparc/nm-sol2.h: Rename include guard.
10370         * config/nm-nto.h: Rename include guard.
10371         * config/nm-linux.h: Add include guard.
10372         * config/i386/nm-i386gnu.h: Rename include guard.
10373         * config/djgpp/nl_types.h: Rename include guard.
10374         * config/djgpp/langinfo.h: Rename include guard.
10375         * compile/gcc-cp-plugin.h: Add include guard.
10376         * compile/gcc-c-plugin.h: Add include guard.
10377         * compile/compile.h: Rename include guard.
10378         * compile/compile-object-run.h: Rename include guard.
10379         * compile/compile-object-load.h: Rename include guard.
10380         * compile/compile-internal.h: Rename include guard.
10381         * compile/compile-cplus.h: Rename include guard.
10382         * compile/compile-c.h: Rename include guard.
10383         * common/xml-utils.h: Rename include guard.
10384         * common/x86-xstate.h: Rename include guard.
10385         * common/version.h: Rename include guard.
10386         * common/vec.h: Rename include guard.
10387         * common/tdesc.h: Rename include guard.
10388         * common/selftest.h: Rename include guard.
10389         * common/scoped_restore.h: Rename include guard.
10390         * common/scoped_mmap.h: Rename include guard.
10391         * common/scoped_fd.h: Rename include guard.
10392         * common/safe-iterator.h: Rename include guard.
10393         * common/run-time-clock.h: Rename include guard.
10394         * common/refcounted-object.h: Rename include guard.
10395         * common/queue.h: Rename include guard.
10396         * common/ptid.h: Rename include guard.
10397         * common/print-utils.h: Rename include guard.
10398         * common/preprocessor.h: Rename include guard.
10399         * common/pathstuff.h: Rename include guard.
10400         * common/observable.h: Rename include guard.
10401         * common/netstuff.h: Rename include guard.
10402         * common/job-control.h: Rename include guard.
10403         * common/host-defs.h: Rename include guard.
10404         * common/gdb_wait.h: Rename include guard.
10405         * common/gdb_vecs.h: Rename include guard.
10406         * common/gdb_unlinker.h: Rename include guard.
10407         * common/gdb_unique_ptr.h: Rename include guard.
10408         * common/gdb_tilde_expand.h: Rename include guard.
10409         * common/gdb_sys_time.h: Rename include guard.
10410         * common/gdb_string_view.h: Rename include guard.
10411         * common/gdb_splay_tree.h: Rename include guard.
10412         * common/gdb_setjmp.h: Rename include guard.
10413         * common/gdb_ref_ptr.h: Rename include guard.
10414         * common/gdb_optional.h: Rename include guard.
10415         * common/gdb_locale.h: Rename include guard.
10416         * common/gdb_assert.h: Rename include guard.
10417         * common/filtered-iterator.h: Rename include guard.
10418         * common/filestuff.h: Rename include guard.
10419         * common/fileio.h: Rename include guard.
10420         * common/environ.h: Rename include guard.
10421         * common/common-utils.h: Rename include guard.
10422         * common/common-types.h: Rename include guard.
10423         * common/common-regcache.h: Rename include guard.
10424         * common/common-inferior.h: Rename include guard.
10425         * common/common-gdbthread.h: Rename include guard.
10426         * common/common-exceptions.h: Rename include guard.
10427         * common/common-defs.h: Rename include guard.
10428         * common/common-debug.h: Rename include guard.
10429         * common/cleanups.h: Rename include guard.
10430         * common/buffer.h: Rename include guard.
10431         * common/btrace-common.h: Rename include guard.
10432         * common/break-common.h: Rename include guard.
10433         * cli/cli-utils.h: Rename include guard.
10434         * cli/cli-style.h: Rename include guard.
10435         * cli/cli-setshow.h: Rename include guard.
10436         * cli/cli-script.h: Rename include guard.
10437         * cli/cli-interp.h: Rename include guard.
10438         * cli/cli-decode.h: Rename include guard.
10439         * cli/cli-cmds.h: Rename include guard.
10440         * charset-list.h: Add include guard.
10441         * buildsym-legacy.h: Rename include guard.
10442         * bfin-tdep.h: Add include guard.
10443         * ax.h: Rename include guard.
10444         * arm-linux-tdep.h: Add include guard.
10445         * arm-fbsd-tdep.h: Add include guard.
10446         * arch/xtensa.h: Rename include guard.
10447         * arch/tic6x.h: Add include guard.
10448         * arch/i386.h: Add include guard.
10449         * arch/arm.h: Rename include guard.
10450         * arch/arm-linux.h: Rename include guard.
10451         * arch/arm-get-next-pcs.h: Rename include guard.
10452         * arch/amd64.h: Add include guard.
10453         * arch/aarch64-insn.h: Rename include guard.
10454         * arch-utils.h: Rename include guard.
10455         * annotate.h: Add include guard.
10456         * amd64-darwin-tdep.h: Rename include guard.
10457         * aarch64-linux-tdep.h: Add include guard.
10458         * aarch64-fbsd-tdep.h: Add include guard.
10459         * aarch32-linux-nat.h: Add include guard.
10460
10461 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10462
10463         * macrotab.c (macro_define_internal): New function that
10464         factorizes macro_define_object_internal and macro_define_function
10465         code.
10466         (macro_define_object_internal): Use macro_define_internal.
10467         (macro_define_function): Likewise.
10468
10469 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10470
10471         * macrocmd.c (extract_identifier): Return
10472         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10473         callers.
10474
10475 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10476
10477         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10478
10479 2019-02-05  Tom Tromey  <tom@tromey.com>
10480
10481         * target.c (target_stack::unpush): Move assertion earlier.
10482
10483 2019-01-30  Tom Tromey  <tom@tromey.com>
10484
10485         PR python/23615:
10486         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10487         (gdbpy_parse_and_eval): Likewise.
10488         * python/python-internal.h (gdbpy_allow_threads): New class.
10489
10490 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10491
10492         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10493         (aarch64_fbsd_fpregmap): Move earlier.
10494         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10495         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10496         instead of individual calls to trad_frame_set_reg_addr.
10497         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10498         earlier.
10499         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10500         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10501         instead of individual calls to trad_frame_set_reg_addr.
10502
10503 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10504
10505         * CONTRIBUTE: Replace contribution list with wiki link.
10506
10507 2019-01-25  Tom Tromey  <tom@tromey.com>
10508
10509         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10510
10511 2019-01-25  Tom Tromey  <tom@tromey.com>
10512
10513         * xtensa-linux-nat.c: Fix common/ includes.
10514         * xml-support.h: Fix common/ includes.
10515         * xml-support.c: Fix common/ includes.
10516         * x86-linux-nat.c: Fix common/ includes.
10517         * windows-nat.c: Fix common/ includes.
10518         * varobj.h: Fix common/ includes.
10519         * varobj.c: Fix common/ includes.
10520         * value.c: Fix common/ includes.
10521         * valops.c: Fix common/ includes.
10522         * utils.c: Fix common/ includes.
10523         * unittests/xml-utils-selftests.c: Fix common/ includes.
10524         * unittests/utils-selftests.c: Fix common/ includes.
10525         * unittests/unpack-selftests.c: Fix common/ includes.
10526         * unittests/tracepoint-selftests.c: Fix common/ includes.
10527         * unittests/style-selftests.c: Fix common/ includes.
10528         * unittests/string_view-selftests.c: Fix common/ includes.
10529         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10530         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10531         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10532         * unittests/rsp-low-selftests.c: Fix common/ includes.
10533         * unittests/parse-connection-spec-selftests.c: Fix common/
10534         includes.
10535         * unittests/optional-selftests.c: Fix common/ includes.
10536         * unittests/offset-type-selftests.c: Fix common/ includes.
10537         * unittests/observable-selftests.c: Fix common/ includes.
10538         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10539         * unittests/memrange-selftests.c: Fix common/ includes.
10540         * unittests/memory-map-selftests.c: Fix common/ includes.
10541         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10542         * unittests/function-view-selftests.c: Fix common/ includes.
10543         * unittests/environ-selftests.c: Fix common/ includes.
10544         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10545         * unittests/common-utils-selftests.c: Fix common/ includes.
10546         * unittests/cli-utils-selftests.c: Fix common/ includes.
10547         * unittests/array-view-selftests.c: Fix common/ includes.
10548         * ui-file.c: Fix common/ includes.
10549         * tui/tui-io.c: Fix common/ includes.
10550         * tracepoint.h: Fix common/ includes.
10551         * tracepoint.c: Fix common/ includes.
10552         * tracefile-tfile.c: Fix common/ includes.
10553         * top.h: Fix common/ includes.
10554         * top.c: Fix common/ includes.
10555         * thread.c: Fix common/ includes.
10556         * target/waitstatus.h: Fix common/ includes.
10557         * target/waitstatus.c: Fix common/ includes.
10558         * target.h: Fix common/ includes.
10559         * target.c: Fix common/ includes.
10560         * target-memory.c: Fix common/ includes.
10561         * target-descriptions.c: Fix common/ includes.
10562         * symtab.h: Fix common/ includes.
10563         * symfile.c: Fix common/ includes.
10564         * stap-probe.c: Fix common/ includes.
10565         * spu-linux-nat.c: Fix common/ includes.
10566         * sparc-nat.c: Fix common/ includes.
10567         * source.c: Fix common/ includes.
10568         * solib.c: Fix common/ includes.
10569         * solib-target.c: Fix common/ includes.
10570         * ser-unix.c: Fix common/ includes.
10571         * ser-tcp.c: Fix common/ includes.
10572         * ser-pipe.c: Fix common/ includes.
10573         * ser-base.c: Fix common/ includes.
10574         * selftest-arch.c: Fix common/ includes.
10575         * s12z-tdep.c: Fix common/ includes.
10576         * rust-exp.y: Fix common/ includes.
10577         * rs6000-aix-tdep.c: Fix common/ includes.
10578         * riscv-tdep.c: Fix common/ includes.
10579         * remote.c: Fix common/ includes.
10580         * remote-notif.h: Fix common/ includes.
10581         * remote-fileio.h: Fix common/ includes.
10582         * remote-fileio.c: Fix common/ includes.
10583         * regcache.h: Fix common/ includes.
10584         * regcache.c: Fix common/ includes.
10585         * record-btrace.c: Fix common/ includes.
10586         * python/python.c: Fix common/ includes.
10587         * python/py-type.c: Fix common/ includes.
10588         * python/py-inferior.c: Fix common/ includes.
10589         * progspace.h: Fix common/ includes.
10590         * producer.c: Fix common/ includes.
10591         * procfs.c: Fix common/ includes.
10592         * proc-api.c: Fix common/ includes.
10593         * printcmd.c: Fix common/ includes.
10594         * ppc-linux-nat.c: Fix common/ includes.
10595         * parser-defs.h: Fix common/ includes.
10596         * osdata.c: Fix common/ includes.
10597         * obsd-nat.c: Fix common/ includes.
10598         * nat/x86-linux.c: Fix common/ includes.
10599         * nat/x86-linux-dregs.c: Fix common/ includes.
10600         * nat/x86-dregs.h: Fix common/ includes.
10601         * nat/x86-dregs.c: Fix common/ includes.
10602         * nat/ppc-linux.c: Fix common/ includes.
10603         * nat/mips-linux-watch.h: Fix common/ includes.
10604         * nat/mips-linux-watch.c: Fix common/ includes.
10605         * nat/linux-waitpid.c: Fix common/ includes.
10606         * nat/linux-ptrace.h: Fix common/ includes.
10607         * nat/linux-ptrace.c: Fix common/ includes.
10608         * nat/linux-procfs.c: Fix common/ includes.
10609         * nat/linux-personality.c: Fix common/ includes.
10610         * nat/linux-osdata.c: Fix common/ includes.
10611         * nat/linux-namespaces.c: Fix common/ includes.
10612         * nat/linux-btrace.h: Fix common/ includes.
10613         * nat/linux-btrace.c: Fix common/ includes.
10614         * nat/fork-inferior.c: Fix common/ includes.
10615         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10616         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10617         * nat/aarch64-linux.c: Fix common/ includes.
10618         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10619         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10620         * namespace.h: Fix common/ includes.
10621         * mips-linux-tdep.c: Fix common/ includes.
10622         * minsyms.c: Fix common/ includes.
10623         * mi/mi-parse.h: Fix common/ includes.
10624         * mi/mi-main.c: Fix common/ includes.
10625         * mi/mi-cmd-env.c: Fix common/ includes.
10626         * memrange.h: Fix common/ includes.
10627         * memattr.c: Fix common/ includes.
10628         * maint.h: Fix common/ includes.
10629         * maint.c: Fix common/ includes.
10630         * main.c: Fix common/ includes.
10631         * machoread.c: Fix common/ includes.
10632         * location.c: Fix common/ includes.
10633         * linux-thread-db.c: Fix common/ includes.
10634         * linux-nat.c: Fix common/ includes.
10635         * linux-fork.c: Fix common/ includes.
10636         * inline-frame.c: Fix common/ includes.
10637         * infrun.c: Fix common/ includes.
10638         * inflow.c: Fix common/ includes.
10639         * inferior.h: Fix common/ includes.
10640         * inferior.c: Fix common/ includes.
10641         * infcmd.c: Fix common/ includes.
10642         * inf-ptrace.c: Fix common/ includes.
10643         * inf-child.c: Fix common/ includes.
10644         * ia64-linux-nat.c: Fix common/ includes.
10645         * i387-tdep.c: Fix common/ includes.
10646         * i386-tdep.c: Fix common/ includes.
10647         * i386-linux-tdep.c: Fix common/ includes.
10648         * i386-linux-nat.c: Fix common/ includes.
10649         * i386-go32-tdep.c: Fix common/ includes.
10650         * i386-fbsd-tdep.c: Fix common/ includes.
10651         * i386-fbsd-nat.c: Fix common/ includes.
10652         * guile/scm-type.c: Fix common/ includes.
10653         * guile/guile.c: Fix common/ includes.
10654         * go32-nat.c: Fix common/ includes.
10655         * gnu-nat.c: Fix common/ includes.
10656         * gdbthread.h: Fix common/ includes.
10657         * gdbarch-selftests.c: Fix common/ includes.
10658         * gdb_usleep.c: Fix common/ includes.
10659         * gdb_select.h: Fix common/ includes.
10660         * gdb_bfd.c: Fix common/ includes.
10661         * gcore.c: Fix common/ includes.
10662         * fork-child.c: Fix common/ includes.
10663         * findvar.c: Fix common/ includes.
10664         * fbsd-nat.c: Fix common/ includes.
10665         * event-top.c: Fix common/ includes.
10666         * event-loop.c: Fix common/ includes.
10667         * dwarf2read.c: Fix common/ includes.
10668         * dwarf2loc.c: Fix common/ includes.
10669         * dwarf2-frame.c: Fix common/ includes.
10670         * dwarf-index-cache.c: Fix common/ includes.
10671         * dtrace-probe.c: Fix common/ includes.
10672         * disasm-selftests.c: Fix common/ includes.
10673         * defs.h: Fix common/ includes.
10674         * csky-tdep.c: Fix common/ includes.
10675         * cp-valprint.c: Fix common/ includes.
10676         * cp-support.h: Fix common/ includes.
10677         * cp-support.c: Fix common/ includes.
10678         * corelow.c: Fix common/ includes.
10679         * completer.h: Fix common/ includes.
10680         * completer.c: Fix common/ includes.
10681         * compile/compile.c: Fix common/ includes.
10682         * compile/compile-loc2c.c: Fix common/ includes.
10683         * compile/compile-cplus-types.c: Fix common/ includes.
10684         * compile/compile-cplus-symbols.c: Fix common/ includes.
10685         * command.h: Fix common/ includes.
10686         * cli/cli-dump.c: Fix common/ includes.
10687         * cli/cli-cmds.c: Fix common/ includes.
10688         * charset.c: Fix common/ includes.
10689         * build-id.c: Fix common/ includes.
10690         * btrace.h: Fix common/ includes.
10691         * btrace.c: Fix common/ includes.
10692         * breakpoint.h: Fix common/ includes.
10693         * breakpoint.c: Fix common/ includes.
10694         * ax.h:
10695         (enum agent_op): Fix common/ includes.
10696         * ax-general.c (struct aop_map): Fix common/ includes.
10697         * ax-gdb.c: Fix common/ includes.
10698         * auxv.c: Fix common/ includes.
10699         * auto-load.c: Fix common/ includes.
10700         * arm-tdep.c: Fix common/ includes.
10701         * arch/riscv.c: Fix common/ includes.
10702         * arch/ppc-linux-common.c: Fix common/ includes.
10703         * arch/i386.c: Fix common/ includes.
10704         * arch/arm.c: Fix common/ includes.
10705         * arch/arm-linux.c: Fix common/ includes.
10706         * arch/arm-get-next-pcs.c: Fix common/ includes.
10707         * arch/amd64.c: Fix common/ includes.
10708         * arch/aarch64.c: Fix common/ includes.
10709         * arch/aarch64-insn.c: Fix common/ includes.
10710         * arch-utils.c: Fix common/ includes.
10711         * amd64-windows-tdep.c: Fix common/ includes.
10712         * amd64-tdep.c: Fix common/ includes.
10713         * amd64-sol2-tdep.c: Fix common/ includes.
10714         * amd64-obsd-tdep.c: Fix common/ includes.
10715         * amd64-nbsd-tdep.c: Fix common/ includes.
10716         * amd64-linux-tdep.c: Fix common/ includes.
10717         * amd64-linux-nat.c: Fix common/ includes.
10718         * amd64-fbsd-tdep.c: Fix common/ includes.
10719         * amd64-fbsd-nat.c: Fix common/ includes.
10720         * amd64-dicos-tdep.c: Fix common/ includes.
10721         * amd64-darwin-tdep.c: Fix common/ includes.
10722         * agent.c: Fix common/ includes.
10723         * ada-lang.h: Fix common/ includes.
10724         * ada-lang.c: Fix common/ includes.
10725         * aarch64-tdep.c: Fix common/ includes.
10726
10727 2019-01-25  Tom Tromey  <tom@tromey.com>
10728
10729         * common/create-version.sh: Use common/version.h.
10730
10731 2019-01-24  Pedro Alves  <palves@redhat.com>
10732
10733         * infrun.c (signal_stop, signal_print, signal_program)
10734         (signal_catch, signal_pass): Now arrays instead of pointers.
10735         (update_signals_program_target, do_target_resume)
10736         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10737         * linux-nat.c (linux_nat_target::pass_signals)
10738         (linux_nat_target::create_inferior, linux_nat_target::attach):
10739         Adjust.
10740         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10741         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10742         * procfs.c (procfs_target::pass_signals): Adjust.
10743         * record-full.c (record_full_target::resume): Adjust.
10744         * remote.c (remote_target::pass_signals)
10745         (remote_target::program_signals): Adjust.
10746         * target-debug.h (target_debug_print_signals): Now takes a
10747         gdb::array_view as parameter.  Adjust.
10748         * target.h (target_ops) <pass_signals, program_signals>: Replace
10749         pointer and length parameters with gdb::array_view.
10750         (target_pass_signals, target_program_signals): Likewise.
10751         * target-delegates.c: Regenerate.
10752
10753 2019-01-24  Pedro Alves  <palves@redhat.com>
10754
10755         * common/forward-scope-exit.h
10756         (forward_scope_exit::forward_scope_exit): Pass arguments to
10757         m_bind_function directly, instead of creating a std::bind and
10758         copying that.
10759
10760 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10761
10762         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10763         for static members.
10764         (pass_in_v_vfp_candidate): Likewise.
10765
10766 2019-01-23  Tom Tromey  <tom@tromey.com>
10767             Pedro Alves  <palves@redhat.com>
10768
10769         * regcache.c (class regcache_invalidator): Remove.
10770         (regcache::raw_write): Use make_scope_exit.
10771
10772 2019-01-23  Tom Tromey  <tom@tromey.com>
10773
10774         * ui-out.h (class ui_out_emit_type): Update comment.
10775
10776 2019-01-23  Tom Tromey  <tom@tromey.com>
10777
10778         * infrun.c (fetch_inferior_event): Update comment.
10779
10780 2019-01-23  Tom Tromey  <tom@tromey.com>
10781             Pedro Alves  <palves@redhat.com>
10782
10783         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10784         parameter.
10785         (fetch_inferior_event): Use SCOPE_EXIT.
10786
10787
10788 2019-01-23  Tom Tromey  <tom@tromey.com>
10789             Pedro Alves  <palves@redhat.com>
10790
10791         * infrun.c (disable_thread_events): Delete.
10792         (stop_all_threads): Use SCOPE_EXIT.
10793
10794 2019-01-23  Tom Tromey  <tom@tromey.com>
10795             Pedro Alves  <palves@redhat.com>
10796
10797         * symfile.c: Include forward-scope-exit.h.
10798         (clear_symtab_users_cleanup): Replace forward declaration with
10799         a FORWARD_SCOPE_EXIT.
10800         (syms_from_objfile_1): Use the forward_scope_exit and
10801         gdb::optional instead of cleanup_function.
10802         (reread_symbols): Use the forward_scope_exit instead of
10803         cleanup_function.
10804         (clear_symtab_users_cleanup): Remove function.
10805
10806 2019-01-23  Tom Tromey  <tom@tromey.com>
10807             Pedro Alves  <palves@redhat.com>
10808
10809         * linux-nat.c: Include scope-exit.h.
10810         (cleanup_target_stop): Remove.
10811         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10812         SCOPE_EXIT.
10813
10814 2019-01-23  Tom Tromey  <tom@tromey.com>
10815             Pedro Alves  <palves@redhat.com>
10816
10817         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10818         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10819
10820 2019-01-23  Tom Tromey  <tom@tromey.com>
10821             Andrew Burgess  <andrew.burgess@embecosm.com>
10822             Pedro Alves  <palves@redhat.com>
10823
10824         * infrun.c (fetch_inferior_event): Use scope_exit.
10825         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10826         * top.c (execute_command): Use scope_exit.
10827         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10828         * utils.c (do_bpstat_clear_actions_cleanup)
10829         (make_bpstat_clear_actions_cleanup): Remove.
10830
10831 2019-01-23  Tom Tromey  <tom@tromey.com>
10832             Pedro Alves  <palves@redhat.com>
10833
10834         * infrun.c: Include "common/scope-exit.h"
10835         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10836         (wait_for_inferior): Use SCOPE_EXIT.
10837         (fetch_inferior_event): Use scope_exit.
10838
10839 2019-01-23  Tom Tromey  <tom@tromey.com>
10840             Pedro Alves  <palves@redhat.com>
10841
10842         * breakpoint.c (create_breakpoint): Remove cleanup.
10843
10844 2019-01-23  Tom Tromey  <tom@tromey.com>
10845             Andrew Burgess  <andrew.burgess@embecosm.com>
10846             Pedro Alves  <palves@redhat.com>
10847
10848 2019-01-23  Pedro Alves  <palves@redhat.com>
10849
10850         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10851
10852 2019-01-23  Pedro Alves  <palves@redhat.com>
10853             Andrew Burgess  <andrew.burgess@embecosm.com>
10854
10855         * gdbthread.h: Include "common/forward-scope-exit.h".
10856         (scoped_finish_thread_state): Redefine custom class in terms of
10857         forward_scope_exit.
10858
10859 2019-01-23  Pedro Alves  <palves@redhat.com>
10860             Andrew Burgess  <andrew.burgess@embecosm.com>
10861
10862         * common/forward-scope-exit.h: New file.
10863
10864 2019-01-23  Pedro Alves  <palves@redhat.com>
10865             Andrew Burgess  <andrew.burgess@embecosm.com>
10866             Tom Tromey  <tom@tromey.com>
10867
10868         * common/scope-exit.h: New file.
10869
10870 2019-01-23  Pedro Alves  <palves@redhat.com>
10871
10872         * common/preprocessor.h (ESC): Rename to ...
10873         (ESC_PARENS): ... this.
10874         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10875         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10876
10877 2019-01-23  Tom Tromey  <tom@tromey.com>
10878
10879         * language.h (class scoped_switch_to_sym_language_if_auto):
10880         Initialize m_lang in both cases.
10881
10882 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10883
10884         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10885         with XCNEW.
10886
10887 2019-01-22  Tom Tromey  <tom@tromey.com>
10888
10889         * corelow.c: Do not include sys/file.h.
10890
10891 2019-01-22  Tom Tromey  <tom@tromey.com>
10892
10893         * tui/tui-wingeneral.h: Include gdb_curses.h.
10894
10895 2019-01-22  Tom Tromey  <tom@tromey.com>
10896
10897         * source-cache.h (class source_cache) <get_source_lines,
10898         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10899
10900 2019-01-22  Tom Tromey  <tom@tromey.com>
10901
10902         * remote-fileio.h (struct remote_target): Declare.
10903
10904 2019-01-22  Tom Tromey  <tom@tromey.com>
10905
10906         * python/py-arch.c: Do not include py-ref.h.
10907         * python/py-bpevent.c: Do not include py-ref.h.
10908         * python/py-cmd.c: Do not include py-ref.h.
10909         * python/py-continueevent.c: Do not include py-ref.h.
10910         * python/py-event.h: Do not include py-ref.h.
10911         * python/py-evtregistry.c: Do not include py-ref.h.
10912         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10913         * python/py-frame.c: Do not include py-ref.h.
10914         * python/py-framefilter.c: Do not include py-ref.h.
10915         * python/py-function.c: Do not include py-ref.h.
10916         * python/py-infevents.c: Do not include py-ref.h.
10917         * python/py-linetable.c: Do not include py-ref.h.
10918         * python/py-objfile.c: Do not include py-ref.h.
10919         * python/py-param.c: Do not include py-ref.h.
10920         * python/py-prettyprint.c: Do not include py-ref.h.
10921         * python/py-progspace.c: Do not include py-ref.h.
10922         * python/py-symbol.c: Do not include py-ref.h.
10923         * python/py-symtab.c: Do not include py-ref.h.
10924         * python/py-type.c: Do not include py-ref.h.
10925         * python/py-unwind.c: Do not include py-ref.h.
10926         * python/py-utils.c: Do not include py-ref.h.
10927         * python/py-value.c: Do not include py-ref.h.
10928         * python/py-varobj.c: Do not include py-ref.h.
10929         * python/py-xmethods.c: Do not include py-ref.h.
10930         * python/python.c: Do not include py-ref.h.
10931         * varobj.c: Do not include py-ref.h.
10932
10933 2019-01-22  Tom Tromey  <tom@tromey.com>
10934
10935         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10936         keyword for bcache.
10937
10938 2019-01-22  Tom Tromey  <tom@tromey.com>
10939
10940         * compile/compile-cplus-types.c: Remove a comment by #include.
10941
10942 2019-01-22  Tom Tromey  <tom@tromey.com>
10943
10944         * compile/gcc-c-plugin.h: Include compile-internal.h.
10945
10946 2019-01-22  Tom Tromey  <tom@tromey.com>
10947
10948         * stabsread.c (EXTERN): Do not define.
10949         (symnum, next_symbol_text_func, processing_gcc_compilation)
10950         (within_function, global_sym_chain, global_stabs)
10951         (previous_stab_code, this_object_header_files)
10952         (n_this_object_header_files)
10953         (n_allocated_this_object_header_files): Define.
10954         * stabsread.h (EXTERN): Never define.  Use "extern".
10955
10956 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10957
10958         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10959         history_value.
10960
10961 2019-01-21  Tom Tromey  <tom@tromey.com>
10962
10963         * ui-out.c: Fix includes.
10964         * tui/tui-source.c: Fix includes.
10965         * target.c: Fix includes.
10966         * remote.c: Fix includes.
10967         * regcache.c: Fix includes.
10968         * python/py-block.c: Fix includes.
10969         * printcmd.c: Fix includes.
10970         * or1k-tdep.c: Fix includes.
10971         * mi/mi-main.c: Fix includes.
10972         * m32r-tdep.c: Fix includes.
10973         * csky-tdep.c: Fix includes.
10974         * compile/compile-cplus-types.c: Fix includes.
10975         * cli/cli-interp.c: Fix includes.
10976
10977 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10978
10979         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10980         for padding.
10981
10982 2019-01-16  Tom Tromey  <tom@tromey.com>
10983
10984         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10985         earlier.
10986         (struct objfile) <msymbols_range>: Move from top level.
10987         <msymbols>: New method.
10988         (class objfile_msymbols): Remove.
10989         * symtab.c (default_collect_symbol_completion_matches_break_on):
10990         Update.
10991         * symmisc.c (dump_msymbols): Update.
10992         * stabsread.c (scan_file_globals): Update.
10993         * objc-lang.c (info_selectors_command, info_classes_command)
10994         (find_methods): Update.
10995         * minsyms.c (find_solib_trampoline_target): Update.
10996         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10997         * coffread.c (coff_symfile_read): Update.
10998         * ada-lang.c (ada_lookup_simple_minsym)
10999         (ada_collect_symbol_completion_matches): Update.
11000
11001 2019-01-16  Tom Tromey  <tom@tromey.com>
11002
11003         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11004         type.  Remove no-argument constructor.
11005         <iterator::operator++>: Simplify.
11006         <begin>: Update.
11007         <end>: Use minimal_symbol_count.
11008
11009 2019-01-16  Tom Tromey  <tom@tromey.com>
11010
11011         * objfiles.h (struct objfile) <psymtabs>: New method.
11012         (class objfile_psymtabs): Remove.
11013         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11014         typedef.
11015         <range>: New method.
11016         (require_partial_symbols): Change return type.
11017         * psymtab.c (require_partial_symbols)
11018         (psym_expand_symtabs_matching): Update.
11019         * mdebugread.c (parse_partial_symbols): Update.
11020         * dbxread.c (dbx_end_psymtab): Update.
11021
11022 2019-01-15  Tom Tromey  <tom@tromey.com>
11023
11024         * symtab.c (lookup_objfile_from_block)
11025         (lookup_symbol_in_objfile_symtabs)
11026         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11027         (find_line_symtab, info_sources_command)
11028         (default_collect_symbol_completion_matches_break_on)
11029         (make_source_files_completion_list): Update.
11030         * symmisc.c (print_objfile_statistics, dump_objfile)
11031         (maintenance_print_symbols, maintenance_info_symtabs)
11032         (maintenance_check_symtabs, maintenance_info_line_tables):
11033         Update.
11034         * source.c (select_source_symtab)
11035         (forget_cached_source_info_for_objfile): Update.
11036         * objfiles.h (class objfile_compunits): Remove.
11037         (struct objfile) <compunits_range>: New typedef.
11038         (compunits): New method.
11039         * objfiles.c (objfile_relocate1): Update.
11040         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11041         * maint.c (count_symtabs_and_blocks): Update.
11042         * linespec.c (iterate_over_all_matching_symtabs): Update.
11043         * cp-support.c (add_symbol_overload_list_qualified): Update.
11044         * coffread.c (coff_symtab_read): Update.
11045         * ada-lang.c (add_nonlocal_symbols)
11046         (ada_collect_symbol_completion_matches)
11047         (ada_add_global_exceptions): Update.
11048
11049 2019-01-15  Tom Tromey  <tom@tromey.com>
11050
11051         * progspace.h (program_space) <objfiles_safe_range>: New
11052         typedef.
11053         <objfiles_safe>: New method.
11054         * objfiles.h (class all_objfiles_safe): Remove.
11055         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11056         * jit.c (jit_inferior_exit_hook): Update.
11057
11058 2019-01-17  Tom Tromey  <tom@tromey.com>
11059
11060         * progspace.h (program_space) <objfiles_range>: New typedef.
11061         <objfiles>: New method.
11062         <objfiles_head>: Rename from objfiles.
11063         (object_files): Update.
11064         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11065         * guile/scm-pretty-print.c
11066         (ppscm_find_pretty_printer_from_objfiles): Update.
11067         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11068         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11069         Update.
11070         * python/py-progspace.c (pspy_get_objfiles): Update.
11071         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11072         Update.
11073         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11074         (objfpy_lookup_objfile_by_build_id): Update.
11075         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11076         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11077         Update.
11078         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11079         (expand_symtab_containing_pc, lookup_objfile_from_block)
11080         (lookup_static_symbol, basic_lookup_transparent_type)
11081         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11082         (find_line_symtab, info_sources_command)
11083         (default_collect_symbol_completion_matches_break_on)
11084         (make_source_files_completion_list, find_main_name): Update.
11085         * symmisc.c (print_symbol_bcache_statistics)
11086         (print_objfile_statistics, maintenance_print_symbols)
11087         (maintenance_print_msymbols, maintenance_print_objfiles)
11088         (maintenance_info_symtabs, maintenance_check_symtabs)
11089         (maintenance_expand_symtabs, maintenance_info_line_tables):
11090         Update.
11091         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11092         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11093         (map_overlay_command, unmap_overlay_command)
11094         (simple_overlay_update, expand_symtabs_matching)
11095         (map_symbol_filenames): Update.
11096         * symfile-debug.c (set_debug_symfile): Update.
11097         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11098         Update.
11099         * source.c (select_source_symtab, forget_cached_source_info):
11100         Update.
11101         * solib.c (solib_read_symbols): Update.
11102         * solib-spu.c (append_ocl_sos): Update.
11103         * psymtab.c (maintenance_print_psymbols)
11104         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11105         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11106         * printcmd.c (info_symbol_command): Update.
11107         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11108         Update.
11109         * objfiles.h (class all_objfiles): Remove.
11110         * objfiles.c (have_partial_symbols, have_full_symbols)
11111         (have_minimal_symbols, qsort_cmp, update_section_map)
11112         (shared_objfile_contains_address_p)
11113         (default_iterate_over_objfiles_in_search_order): Update.
11114         * objc-lang.c (info_selectors_command, info_classes_command)
11115         (find_methods): Update.
11116         * minsyms.c (find_solib_trampoline_target): Update.
11117         * maint.c (maintenance_info_sections)
11118         (maintenance_translate_address, count_symtabs_and_blocks):
11119         Update.
11120         * main.c (captured_main_1): Update.
11121         * linux-thread-db.c (try_thread_db_load_from_pdir)
11122         (has_libpthread): Update.
11123         * linespec.c (iterate_over_all_matching_symtabs)
11124         (search_minsyms_for_name): Update.
11125         * jit.c (jit_find_objf_with_entry_addr): Update.
11126         * hppa-tdep.c (find_unwind_entry)
11127         (hppa_lookup_stub_minimal_symbol): Update.
11128         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11129         Update.
11130         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11131         (elf_gnu_ifunc_resolve_by_got): Update.
11132         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11133         * dwarf-index-write.c (save_gdb_index_command): Update.
11134         * cp-support.c (add_symbol_overload_list_qualified): Update.
11135         * breakpoint.c (create_overlay_event_breakpoint)
11136         (create_longjmp_master_breakpoint)
11137         (create_std_terminate_master_breakpoint)
11138         (create_exception_master_breakpoint): Update.
11139         * blockframe.c (find_pc_partial_function): Update.
11140         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11141         (ada_collect_symbol_completion_matches)
11142         (ada_add_global_exceptions): Update.
11143
11144 2019-01-17  Tom Tromey  <tom@tromey.com>
11145
11146         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11147         declare VEC.
11148         (solib_target_parse_libraries): Change return type.
11149         (library_list_start_segment, library_list_start_section)
11150         (library_list_end_library, library_list_start_library); Update.
11151         (solib_target_free_library_list): Remove.
11152         (solib_target_parse_libraries): Remove cleanup.  Change return
11153         type.
11154         (solib_target_current_sos): Update.
11155
11156 2019-01-17  Tom Tromey  <tromey@bapiya>
11157
11158         * valprint.c: Replace "the the" with "the".
11159         * symtab.c: Replace "the the" with "the".
11160         * solib.c: Replace "the the" with "the".
11161         * solib-dsbt.c: Replace "the the" with "the".
11162         * linespec.c: Replace "the the" with "the".
11163         * dwarf2loc.h: Replace "the the" with "the".
11164         * amd64-windows-tdep.c: Replace "the the" with "the".
11165         * aarch64-tdep.c: Replace "the the" with "the".
11166
11167 2019-01-16  Keith Seitz  <keiths@redhat.com>
11168
11169         PR gdb/23773
11170         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11171         <builder>: Rename to ..
11172         <m_builder>: ... this and make private.
11173         (dwarf2_cu::get_builder): New method.  Change all users of
11174         `builder' to use this method.
11175         (dwarf2_start_symtab): Move to ...
11176         (dwarf2_cu::start_symtab): ... here.  Update all callers
11177         (setup_type_unit_groups): Move to ...
11178         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11179         callers.
11180         (dwarf2_cu::reset_builder): New method.
11181         (process_full_compunit, process_full_type_unit): Use
11182         dwarf2_cu::reset_builder.
11183         (follow_die_offset): Record the ancestor CU if it is different
11184         from the followed DIE's CU.
11185         (follow_die_sig_1): Likewise.
11186
11187 2019-01-15  Tom Tromey  <tom@tromey.com>
11188
11189         * remote.c (class remote_state) <buf>: Now a char_vector.
11190         <buf_size>: Remove.
11191         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11192         parameter.
11193         (remote_target::getpkt_or_notif_sane_1)
11194         (remote_target::getpkt_sane)
11195         (remote_target::getpkt_or_notif_sane): Likewise.
11196         (class remote_target) <putpkt>: New overload.
11197         (remote_target::read_frame): Change type of "buf_p".  Remove
11198         sizeof_p parameter.
11199         (packet_ok): New overload.
11200         (packet_check_result): New overload.
11201         Update all uses.
11202
11203 2019-01-14  Tom Tromey  <tom@tromey.com>
11204
11205         * remote-notif.c (handle_notification, remote_notif_ack)
11206         (remote_notif_parse): Make "buf" const.
11207         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11208         const.
11209         (remote_notif_parse, remote_notif_ack, handle_notification):
11210         Likewise.
11211         * remote.c (remote_notif_stop_parse): Make "buf" const.
11212         (remote_target::remote_parse_stop_reply): Make "buf" const.
11213         (remote_notif_stop_ack): Make "buf" const.
11214
11215 2019-01-14  Tom Tromey  <tom@tromey.com>
11216
11217         * remote.c (remote_console_output): Make parameter const.
11218
11219 2019-01-14  Tom Tromey  <tom@tromey.com>
11220
11221         * target-debug.h (target_debug_print_signals): Constify.
11222         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11223         * procfs.c (procfs_target::pass_signals): Update.
11224         * linux-nat.c (linux_nat_target::pass_signals): Update.
11225         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11226         * target-delegates.c: Rebuild.
11227         * remote.c (remote_target::program_signals): Update.
11228         (remote_target::pass_signals): Update.
11229         * target.c (target_pass_signals): Constify argument.
11230         (target_program_signals): Likewise.
11231         * target.h (struct target_ops) <pass_signals, program_signals>:
11232         Constify argument.
11233         (target_pass_signals, target_program_signals): Constify argument.
11234
11235 2019-01-14  Tom Tromey  <tom@tromey.com>
11236
11237         PR tui/28819:
11238         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11239
11240 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11241
11242         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11243         field.
11244         * rs6000-tdep.c: Include reggroups.h.
11245         (IS_V_ALIAS_PSEUDOREG): Define.
11246         (rs6000_register_name): Return names for the "vX" aliases.
11247         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11248         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11249         aliases.  Call default_register_reggroup_p for all other
11250         pseudo-registers.
11251         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11252         New functions.
11253         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11254         Handle "vX" aliases.
11255         (v_alias_pseudo_register_collect): New function.
11256         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11257         (rs6000_gdbarch_init): Initialize "vX" aliases as
11258         pseudo-registers.  Restore registration of
11259         rs6000_pseudo_register_reggroup_p with
11260         set_tdesc_pseudo_register_reggroup_p.
11261
11262 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11263
11264         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11265         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11266         set_gdbarch_num_pseudo_regs.
11267
11268 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11269
11270         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11271         Remove arg prefixname, add do_set and do_show.
11272         Add member functions set_list and show_list.
11273         * cli/cli-style.c (class cli_style_option): Update accordingly.
11274         (style_set_list): Move to file scope.
11275         (style_show_list): Likewise.
11276         (set_style): Call help_list.
11277         (show_style): Call cmd_show_list.
11278         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11279         Update to use the new macro.
11280
11281 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11282
11283         * ada-lang.c (_initialize_ada_language): Expand the help text
11284         for the "catch exception" command.
11285
11286 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11287
11288         * symtab.c (matching_obj_sections): Initialize obj,
11289         declare it closer to its usage.
11290
11291 2019-01-10  Tom Tromey  <tom@tromey.com>
11292
11293         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11294         (basic_inf_threads_range): Remove.
11295         (inf_threads_range, inf_non_exited_threads_range)
11296         (safe_inf_threads_range): Use next_adapter.
11297
11298 2019-01-10  Keith Seitz  <keiths@redhat.com>
11299
11300         PR gdb/23712
11301         PR symtab/23010
11302         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11303         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11304
11305 2019-01-10  Keith Seitz  <keiths@redhat.com>
11306
11307         PR gdb/23712
11308         PR symtab/23010
11309         * dictionary.c (pending_to_vector): Remove.
11310         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11311         Remove _1 suffix, replacing functions of the same name.  Update
11312         all callers.
11313         (dict_create_hashed, dict_create_hashed_expandable)
11314         (dict_create_linear, dict_create_linear_expandable, dict_free)
11315         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11316         Make functions static.
11317
11318 2019-01-10  Keith Seitz  <keiths@redhat.com>
11319
11320         PR gdb/23712
11321         PR symtab/23010
11322         * dictionary.h (struct dictionary): Replace declaration with
11323         multidictionary.
11324         (dict_create_hashed, dict_create_hashed_expandable)
11325         (dict_create_linear, dict_create_linear_expandable)
11326         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11327         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11328         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11329         taking multidictionary argument.
11330         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11331         * block.h (struct block) <dict>: Change to multidictionary
11332         and rename `multidict'.
11333         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11334         symmisc.c: Update all dictionary references to multidictionary.
11335
11336 2019-01-10  Keith Seitz  <keiths@redhat.com>
11337
11338         PR gdb/23712
11339         PR symtab/23010
11340         * dictionary.c: Include unordered_map.
11341         (pending_to_vector): New function.
11342         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11343         Rewrite the non-"_1" functions to take vector instead
11344         of linked list.
11345         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11346         "new" _1 versions of the same name.
11347         (multidictionary): Define.
11348         (std::hash<enum language): New definition.
11349         (collate_pending_symbols_by_language, mdict_create_hashed)
11350         (mdict_create_hashed_expandable, mdict_create_linear)
11351         (mdict_create_linear_expandable, mdict_free)
11352         (find_language_dictionary, create_new_language_dictionary)
11353         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11354         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11355         (mdict_size, mdict_empty): New functions.
11356         * dictionary.h (mdict_iterator): Define.
11357
11358 2019-01-10  Pedro Alves  <palves@redhat.com>
11359
11360         * breakpoint.c (read_uploaded_action)
11361         (create_tracepoint_from_upload): Adjust to use
11362         gdb::unique_xmalloc_ptr.
11363         * ctf.c (ctf_write_uploaded_tp):
11364         (SET_ARRAY_FIELD): Use emplace_back.
11365         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11366         * tracefile-tfile.c (tfile_write_uploaded_tp):
11367         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11368         gdb::unique_xmalloc_ptr.
11369         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11370         at_string, cond_string, cmd_strings>: Replace char pointers
11371         with gdb::unique_xmalloc_ptr.
11372
11373 2019-01-10  Pedro Alves  <palves@redhat.com>
11374
11375         * solib-target.c (library_list_start_library): Don't xstrdup name.
11376
11377 2019-01-10  Pedro Alves  <palves@redhat.com>
11378
11379         * mdebugread.c (parse_partial_symbols): Use
11380         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11381
11382 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11383
11384         * linux-fork.c (scoped_switch_fork_info)
11385         <~scoped_switch_fork_info>: Fix incorrect variable name.
11386
11387 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11388
11389         * linux-fork.c (scoped_switch_fork_info)
11390         <scoped_switch_fork_info>: Make explicit.
11391         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11392
11393 2019-01-10  Tom Tromey  <tom@tromey.com>
11394
11395         * objfiles.h (objfile::reset_psymtabs): Update.
11396         * objfiles.c (objfile::objfile): Update.
11397         * psymtab.h (psymtab_storage::obstack): Update.
11398         (psymtab_storage::m_obstack): Use gdb::optional.
11399         (class psymtab_storage): Update comment.  Remove objfile
11400         parameter.
11401         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11402
11403 2019-01-10  Tom Tromey  <tom@tromey.com>
11404
11405         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11406         <free_psymtabs>: Now private.
11407         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11408         (allocate_psymtab): Use new method.
11409
11410 2019-01-10  Tom Tromey  <tom@tromey.com>
11411
11412         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11413         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11414         * mdebugread.c (parse_partial_symbols): Use
11415         allocate_dependencies.
11416         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11417         allocate_dependencies.
11418         (process_psymtab_comp_unit_reader)
11419         (build_type_psymtab_dependencies): Likewise.
11420         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11421
11422 2019-01-10  Tom Tromey  <tom@tromey.com>
11423
11424         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11425         PSYMBOL_SET_LANGUAGE.
11426         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11427
11428 2019-01-10  Tom Tromey  <tom@tromey.com>
11429
11430         * psymtab.h (psymtab_storage::obstack): New method.
11431         <m_obstack>: Rename from obstack; now private.
11432         * psymtab.c (psymtab_storage): Update.
11433         * dwarf2read.c (create_addrmap_from_index)
11434         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11435         Update.
11436
11437 2019-01-10  Tom Tromey  <tom@tromey.com>
11438
11439         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11440         * objfiles.h (objfile::reset_psymtabs): New method.
11441
11442 2019-01-10  Tom Tromey  <tom@tromey.com>
11443
11444         * symmisc.c (print_symbol_bcache_statistics): Update.
11445         (print_objfile_statistics): Update.
11446         * symfile.c (reread_symbols): Update.
11447         * psymtab.h (class psymtab_storage): New.
11448         * psymtab.c (psymtab_storage): New constructor.
11449         (~psymtab_storage): New destructor.
11450         (require_partial_symbols): Update.
11451         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11452         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11453         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11454         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11455         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11456         (start_psymtab_common, end_psymtab_common)
11457         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11458         (allocate_psymtab): Update.
11459         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11460         Update.
11461         (dump_psymtab_addrmap, maintenance_print_psymbols)
11462         (maintenance_check_psymtabs): Update.
11463         (class objfile_psymtabs): Move to objfiles.h.
11464         * psympriv.h (discard_psymtab): Now inline.
11465         (psymtab_discarder::psymtab_discarder): Update.
11466         (psymtab_discarder::~psymtab_discarder): Update.
11467         (ALL_OBJFILE_PSYMTABS): Rewrite.
11468         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11469         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11470         Remove fields.
11471         <partial_symtabs>: New field.
11472         (class objfile_psymtabs): Move from psymtab.h.  Update.
11473         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11474         psymbol_cache.
11475         (objfile::~objfile): Don't destroy psymbol_cache.
11476         * mdebugread.c (parse_partial_symbols): Update.
11477         * dwarf2read.c (create_addrmap_from_index)
11478         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11479         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11480         (add_partial_subprogram, dwarf2_ranges_read): Update.
11481         * dwarf-index-write.c (write_address_map)
11482         (write_one_signatured_type, recursively_write_psymbols)
11483         (class debug_names, class debug_names, write_psymtabs_to_index):
11484         Update.
11485
11486 2019-01-10  Tom Tromey  <tom@tromey.com>
11487
11488         * symtab.h (SYMBOL_SET_NAMES): Update.
11489         (symbol_set_names): Update.
11490         (MSYMBOL_SET_NAMES): Update.
11491         * symtab.c (symbol_set_names): Change argument to be an
11492         objfile_per_bfd_storage.
11493         * psymtab.c (add_psymbol_to_bcache): Update.
11494         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11495
11496 2019-01-10  Tom Tromey  <tom@tromey.com>
11497
11498         * symtab.c (create_demangled_names_hash): Change argument to be an
11499         objfile_per_bfd_storage.
11500         (symbol_set_names): Update.
11501
11502 2019-01-10  Tom Tromey  <tom@tromey.com>
11503
11504         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11505         init_psymbol_list.
11506         * psymtab.c (init_psymbol_list): Do nothing if already called.
11507         * psympriv.h (init_psymbol_list): Add comment.
11508         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11509         init_psymbol_list.
11510         * dbxread.c (dbx_symfile_read): Unconditionally call
11511         init_psymbol_list.
11512
11513 2019-01-10  Tom Tromey  <tom@tromey.com>
11514
11515         * xcoffread.c (scan_xcoff_symtab): Update.
11516         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11517         "where".
11518         * mdebugread.c (parse_partial_symbols)
11519         (handle_psymbol_enumerators): Update.
11520         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11521         * dbxread.c (read_dbx_symtab): Update.
11522         * psympriv.h (psymbol_placement): New enum.
11523         (add_psymbol_to_list): Update.
11524
11525 2019-01-10  Tom Tromey  <tom@tromey.com>
11526
11527         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11528         static_psymbols parameters.
11529         (scan_xcoff_symtab): Update.
11530         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11531         static_psymbols parameters.
11532         * psympriv.h (start_psymtab_common): Update.
11533         * mdebugread.c (parse_partial_symbols): Update.
11534         * dwarf2read.c (create_partial_symtab): Update.
11535         * dbxread.c (read_dbx_symtab): Update.
11536         (start_psymtab): Remove global_psymbols and static_psymbols
11537         parameters.
11538
11539 2019-01-10  Tom Tromey  <tom@tromey.com>
11540
11541         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11542         * psymtab.c (allocate_psymtab): Add comment.
11543         * psympriv.h (allocate_psymtab): Add comment.
11544         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11545         initializations.
11546         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11547
11548 2019-01-10  Tom Tromey  <tom@tromey.com>
11549
11550         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11551         Don't declare.
11552         * mipsread.c: Include mdebugread.h.
11553         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11554         Declare.
11555         * elfread.c: Include mdebugread.h.
11556
11557 2019-01-09  Tom Tromey  <tom@tromey.com>
11558
11559         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11560         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11561         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11562         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11563         (psym_lookup_symbol, psym_find_last_source_symtab)
11564         (psym_forget_cached_source_info, psym_print_stats)
11565         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11566         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11567         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11568         (psym_find_compunit_symtab_by_address)
11569         (maintenance_print_psymbols, maintenance_info_psymtabs)
11570         (maintenance_check_psymtabs): Use ranged for.
11571         * psymtab.h (class objfile_psymtabs): New.
11572         (require_partial_symbols): Return objfile_psymtabs.
11573         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11574
11575 2019-01-09  Tom Tromey  <tom@tromey.com>
11576
11577         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11578         (find_pc_mapped_section, list_overlays_command)
11579         (map_overlay_command, unmap_overlay_command)
11580         (simple_overlay_update): Use all_objfiles.
11581         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11582         * printcmd.c (info_symbol_command): Use all_objfiles.
11583         * objfiles.h (ALL_OBJSECTIONS): Remove.
11584         * maint.c (maintenance_translate_address): Use all_objfiles.
11585         * gcore.c (gcore_create_callback): Use all_objfiles.
11586         (objfile_find_memory_regions): Likewise.
11587
11588 2019-01-09  Tom Tromey  <tom@tromey.com>
11589
11590         * symtab.c (find_line_symtab, info_sources_command)
11591         (make_source_files_completion_list): Use objfile_compunits.
11592         * source.c (select_source_symtab): Use objfile_compunits.
11593         * objfiles.h (struct objfile): Update comment.
11594         (ALL_OBJFILES): Remove.
11595         (ALL_FILETABS): Remove.
11596         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11597         objfile_compunits.
11598
11599 2019-01-09  Tom Tromey  <tom@tromey.com>
11600
11601         * symmisc.c (print_objfile_statistics, dump_objfile)
11602         (maintenance_print_symbols): Use compunit_filetabs.
11603         * source.c (forget_cached_source_info_for_objfile): Use
11604         compunit_filetabs.
11605         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11606         (ALL_FILETABS): Use compunit_filetabs.
11607         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11608         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11609
11610 2019-01-09  Tom Tromey  <tom@tromey.com>
11611
11612         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11613         (compunit_filetabs): New.
11614         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11615         compunit_filetabs.
11616         (info_sources_command, make_source_files_completion_list): Remove
11617         declaration.
11618         * symmisc.c (print_objfile_statistics, dump_objfile)
11619         (maintenance_print_symbols): Remove declaration.
11620         (maintenance_info_symtabs): Use compunit_filetabs.
11621         (maintenance_info_line_tables): Likewise.
11622         * source.c (select_source_symtab): Change local variable name.
11623         (forget_cached_source_info_for_objfile): Remove declaration.
11624         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11625         * objfiles.c (objfile_relocate1): Remove declaration.
11626         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11627         declaration.
11628         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11629         * coffread.c (coff_symtab_read): Remove declaration.
11630         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11631         compunit_filetabs.
11632
11633 2019-01-09  Tom Tromey  <tom@tromey.com>
11634
11635         * symtab.c (lookup_objfile_from_block)
11636         (find_pc_sect_compunit_symtab, search_symbols)
11637         (default_collect_symbol_completion_matches_break_on): Use
11638         objfile_compunits.
11639         * objfiles.h (ALL_COMPUNITS): Remove.
11640         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11641         * cp-support.c (add_symbol_overload_list_qualified): Use
11642         objfile_compunits.
11643         * ada-lang.c (ada_collect_symbol_completion_matches)
11644         (ada_add_global_exceptions): Use objfile_compunits.
11645
11646 2019-01-09  Tom Tromey  <tom@tromey.com>
11647
11648         * source.c (select_source_symtab)
11649         (forget_cached_source_info_for_objfile): Remove declaration.
11650         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11651         declaration.
11652         * maint.c (count_symtabs_and_blocks): Remove declaration.
11653         * cp-support.c (add_symbol_overload_list_qualified): Remove
11654         declaration.
11655         * coffread.c (coff_symtab_read): Remove declaration.
11656         * symtab.c (lookup_symbol_in_objfile_symtabs)
11657         (basic_lookup_transparent_type_1): Use objfile_compunits.
11658         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11659         (info_sources_command, search_symbols)
11660         (default_collect_symbol_completion_matches_break_on)
11661         (make_source_files_completion_list): Remove declaration.
11662         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11663         (ada_collect_symbol_completion_matches)
11664         (ada_add_global_exceptions): Remove declaration.
11665         * linespec.c (iterate_over_all_matching_symtabs): Use
11666         objfile_compunits.
11667         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11668         (class objfile_compunits): New.
11669         (ALL_COMPUNITS): Use objfile_compunits.
11670         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11671         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11672         objfile_compunits.
11673         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11674
11675 2019-01-09  Tom Tromey  <tom@tromey.com>
11676
11677         * symtab.c (search_symbols)
11678         (default_collect_symbol_completion_matches_break_on): Use
11679         objfile_msymbols.
11680         * ada-lang.c (ada_lookup_simple_minsym)
11681         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11682         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11683         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11684         objfile_msymbols.
11685         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11686         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11687         * objc-lang.c (find_methods): Use objfile_msymbols.
11688         (info_selectors_command, info_classes_command): Likewise.
11689         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11690         * objfiles.h (class objfile_msymbols): New.
11691         (ALL_OBJFILE_MSYMBOLS): Remove.
11692         (ALL_MSYMBOLS): Remove.
11693
11694 2019-01-09  Tom Tromey  <tom@tromey.com>
11695
11696         * common/next-iterator.h (next_adapter): Add Iterator template
11697         parameter.
11698         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11699         (class all_objfiles_safe): New.
11700         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11701         * objfiles.c (put_objfile_before): Update comment.
11702         (add_separate_debug_objfile): Likewise.
11703         (free_all_objfiles): Use all_objfiles_safe.
11704         (objfile_purge_solibs): Likewise.
11705
11706 2019-01-09  Tom Tromey  <tom@tromey.com>
11707
11708         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11709         (expand_symtab_containing_pc, lookup_static_symbol)
11710         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11711         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11712         all_objfiles.
11713         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11714         * breakpoint.c (create_overlay_event_breakpoint)
11715         (create_longjmp_master_breakpoint)
11716         (create_std_terminate_master_breakpoint)
11717         (create_exception_master_breakpoint): Use all_objfiles.
11718         * linux-thread-db.c (try_thread_db_load_from_pdir)
11719         (has_libpthread): Use all_objfiles.
11720         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11721         * linespec.c (iterate_over_all_matching_symtabs)
11722         (search_minsyms_for_name): Use all_objfiles.
11723         * maint.c (maintenance_info_sections): Use all_objfiles.
11724         * main.c (captured_main_1): Use all_objfiles.
11725         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11726         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11727         * guile/scm-pretty-print.c
11728         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11729         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11730         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11731         (maintenance_print_msymbols): Use all_objfiles.
11732         * source.c (select_source_symtab): Use all_objfiles.
11733         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11734         * symfile.c (remove_symbol_file_command)
11735         (expand_symtabs_matching, map_symbol_filenames): Use
11736         all_objfiles.
11737         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11738         all_objfiles.
11739         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11740         * objc-lang.c (find_methods): Use all_objfiles.
11741         * objfiles.c (have_partial_symbols, have_full_symbols)
11742         (have_minimal_symbols, qsort_cmp)
11743         (default_iterate_over_objfiles_in_search_order): Use
11744         all_objfiles.
11745         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11746         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11747         (maintenance_check_psymtabs): Use all_objfiles.
11748         (ALL_PSYMTABS): Remove.
11749         * compile/compile-object-run.c (do_module_cleanup): Use
11750         all_objfiles.
11751         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11752         * cp-support.c (add_symbol_overload_list_qualified): Use
11753         all_objfiles.
11754         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11755         Use all_objfiles.
11756         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11757         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11758         all_objfiles.
11759         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11760         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11761         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11762         Uses all_objfiles.
11763         * solib.c (solib_read_symbols): Use all_objfiles
11764
11765 2019-01-09  Tom Tromey  <tom@tromey.com>
11766
11767         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11768         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11769         all_objfiles.
11770         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11771         * symmisc.c (print_symbol_bcache_statistics)
11772         (print_objfile_statistics, maintenance_print_objfiles)
11773         (maintenance_info_symtabs, maintenance_check_symtabs)
11774         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11775         all_objfiles.
11776         * source.c (forget_cached_source_info): Use all_objfiles.
11777         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11778         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11779         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11780         * objfiles.c (update_section_map): Use all_objfiles.
11781         (shared_objfile_contains_address_p): Likewise.
11782         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11783         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11784
11785 2019-01-09  Tom Tromey  <tom@tromey.com>
11786
11787         * common/next-iterator.h: New file.
11788         * objfiles.h (class all_objfiles): New.
11789         (struct objfile_iterator): New.
11790
11791 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11792
11793         * NEWS: Move the description of the changed "frame", "select-frame",
11794          and "info frame" commands to the Changed commands section.
11795
11796 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11797
11798         * gdbtypes.c (check_stub_method_group): Remove handling of old
11799         mangling schemes.
11800         * linespec.c (find_methods): Likewise.
11801         * stabsread.c (read_member_functions): Likewise.
11802         * valops.c (search_struct_method): Likewise.
11803         (value_struct_elt_for_reference): Likewise.
11804         * NEWS: Mention this change.
11805
11806 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11807
11808         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11809         print_source_lines.
11810         * source.c (print_source_lines_base): Update line number check.
11811         (print_source_lines): New function.
11812         (source_lines_range::source_lines_range): New function.
11813         * source.h (class source_lines_range): New class.
11814         (print_source_lines): New declaration.
11815
11816 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11817
11818         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11819
11820 2019-01-08  Tom Tromey  <tom@tromey.com>
11821             Simon Marchi  <simon.marchi@ericsson.com>
11822
11823         PR gdb/24060
11824         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11825         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11826         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11827         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11828         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11829         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11830
11831 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11832
11833         * source.c (select_source_symtab): Move header comment to
11834         declaration in source.h.
11835         (forget_cached_source_info_for_objfile): Likewise.
11836         (forget_cached_source_info): Likewise.
11837         (identify_source_line): Likewise.
11838         * source.h (identify_source_line): Move declaration from symtab.h
11839         and add comment from source.c
11840         (print_source_lines): Likewise.
11841         (forget_cached_source_info_for_objfile): Likewise.
11842         (forget_cached_source_info): Likewise.
11843         (select_source_symtab): Likewise.
11844         (enum print_source_lines_flag): Move definition from symtab.h.
11845         * symtab.h (identify_source_line): Move declaration to source.h.
11846         (print_source_lines): Likewise.
11847         (forget_cached_source_info_for_objfile): Likewise.
11848         (forget_cached_source_info): Likewise.
11849         (select_source_symtab): Likewise.
11850         (enum print_source_lines_flag): Move definition to source.h.
11851         * tui/tui-hooks.c: Add 'source.h' include.
11852
11853 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11854
11855         * source.c (print_source_lines_base): Handle requests to print
11856         reverse line number sequences, and guard against empty lines
11857         string.
11858
11859 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11860
11861         * source.c (print_source_lines_base): Fix skip of '\r' if next
11862         character is '\n'.
11863
11864 2019-01-06  Tom Tromey  <tom@tromey.com>
11865
11866         * c-exp.y (struct c_parse_state) <macro_original_text,
11867         expansion_obstack>: New member.
11868         (macro_original_text, expansion_obstack): Remove globals.
11869         (scan_macro_expansion, scanning_macro_expansion)
11870         (finished_macro_expansion): Update.
11871         (scan_macro_cleanup): Remove.
11872         (yylex, c_parse): Update.
11873
11874 2019-01-06  Tom Tromey  <tom@tromey.com>
11875
11876         * c-exp.y (struct c_parse_state) <strings>: New member.
11877         (operator_stoken): Update.
11878
11879 2019-01-06  Tom Tromey  <tom@tromey.com>
11880
11881         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11882         (union type_stack_elt) <typelist_val>: Now a pointer to
11883         std::vector.
11884         (type_stack_cleanup): Don't declare.
11885         (push_typelist): Update.
11886         * parse.c (pop_typelist): Return a std::vector.
11887         (push_typelist): Take a std::vector.
11888         (follow_types): Update.  Do not free args.
11889         (type_stack_cleanup): Remove.
11890         * c-exp.y (struct c_parse_state): New.
11891         (cpstate): New global.
11892         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11893         (nonempty_typelist): Update.
11894         (func_mod): Create a new vector.
11895         (c_parse): Create a c_parse_state.
11896         (check_parameter_typelist): Do not delete params.
11897         (function_method): Update.  Do not delete type_list.
11898
11899 2019-01-06  Tom Tromey  <tom@tromey.com>
11900
11901         PR gdb/28155:
11902         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11903         check_typedef.
11904         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11905         (print_return_value): Likewise.
11906
11907 2019-01-05  Tom Tromey  <tom@tromey.com>
11908
11909         * contrib/cleanup_check.py: Remove.
11910         * contrib/gcc-with-excheck: Remove.
11911         * contrib/exsummary.py: Remove.
11912         * contrib/excheck.py: Remove.
11913
11914 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11915
11916         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11917         NULL. Initialize tpprev to NULL instead of assigning it
11918         to NULL on the next statement.
11919         * windows-nat.c (windows_delete_thread): Remove check for
11920         main_thread_id before printing thread exit notifications.
11921         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11922         Remove thread ID check against main_thread_id.
11923         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11924         windows_delete_thread.
11925         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11926
11927 2019-01-04  Tom Tromey  <tom@tromey.com>
11928
11929         * compile/compile.c (_initialize_compile): Use upper case for
11930         metasyntactic variables.
11931         * symmisc.c (_initialize_symmisc): Use upper case for
11932         metasyntactic variables.
11933         * psymtab.c (_initialize_psymtab): Use upper case for
11934         metasyntactic variables.
11935         * demangle.c (demangle_command): Use upper case for metasyntactic
11936         variables.
11937         (_initialize_demangler): Likewise.
11938         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11939         variables.
11940
11941 2019-01-03  Tom Tromey  <tom@tromey.com>
11942
11943         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11944
11945 2019-01-03  Tom Tromey  <tom@tromey.com>
11946
11947         * python/py-symtab.c (salpy_str): Update.
11948         (struct salpy_sal_object) <symtab>: Now a PyObject.
11949         (salpy_dealloc): Update.
11950         (del_objfile_sal): Use gdbpy_ref.
11951
11952 2019-01-03  Tom Tromey  <tom@tromey.com>
11953
11954         * python/py-type.c (convert_field): Use new_reference.  Return
11955         gdbpy_ref.
11956         (make_fielditem): Return gdbpy_ref.
11957         (typy_fields): Update.
11958         (typy_getitem): Update.
11959         (field_name): Return gdbpy_ref.  Use new_reference.
11960         (typy_iterator_iternext): Update.
11961
11962 2019-01-03  Tom Tromey  <tom@tromey.com>
11963
11964         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11965
11966 2019-01-03  Tom Tromey  <tom@tromey.com>
11967
11968         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11969         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11970         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11971         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11972         (pspy_set_type_printers): Likewise.
11973         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11974         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11975         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11976         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11977         (objfpy_set_type_printers): Likewise.
11978
11979 2019-01-03  Tom Tromey  <tom@tromey.com>
11980
11981         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11982         (gdbpy_print_stack): Use gdbpy_err_fetch.
11983         * python/python-internal.h (class gdbpy_err_fetch): New class.
11984         (class gdbpy_enter) <m_error_type, m_error_value,
11985         m_error_traceback>: Remove.
11986         <m_error>: New member.
11987         (gdbpy_exception_to_string): Don't declare.
11988         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11989         * python/py-value.c (convert_value_from_python): Use
11990         gdbpy_err_fetch.
11991         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11992         gdbpy_exception_to_string.
11993         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11994         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11995         gdbpy_err_fetch.
11996
11997 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11998
11999         * linux-nat.c (delete_lwp_cleanup): Delete.
12000         (struct lwp_deleter): New struct.
12001         (lwp_info_up): New typedef.
12002         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12003         lwp_info_up.
12004
12005 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12006
12007         * linux-fork.c (class scoped_switch_fork_info): New class.
12008         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12009
12010 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12011
12012         * valops.c (find_overload_match): Remove use of null_cleanup, and
12013         calls to do_cleanups.
12014
12015 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12016
12017         * compile/compile-cplus-types.c
12018         (compile_cplus_instance::decl_name): Handle changes to
12019         cp_func_name.
12020         * cp-support.c (cp_func_name): Update header comment, update
12021         return type.
12022         * cp-support.h (cp_func_name): Update return type in declaration.
12023         * valops.c (find_overload_match): Move temp_func local to top
12024         level of function and change its type.  Use temp_func to hold and
12025         delete temporary string obtained from cp_func_name.
12026
12027 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12028
12029         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12030         gdb::char_vector, remove cleanup, and update uses of `msg`.
12031
12032 2019-01-03  Jim Wilson  <jimw@sifive.com>
12033
12034         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12035
12036 2019-01-02  Tom Tromey  <tom@tromey.com>
12037
12038         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12039         (tdesc_parse_xml): Remove cleanups.
12040         * target-descriptions.h (make_cleanup_free_target_description):
12041         Don't declare.
12042         (target_desc_deleter): New struct.
12043         (target_desc_up): New typedef.
12044         * target-descriptions.c (target_desc_deleter::operator()): Rename
12045         from free_target_description.
12046         (make_cleanup_free_target_description): Remove.
12047
12048 2019-01-02  Tom Tromey  <tom@tromey.com>
12049
12050         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12051         constructor, destructor.
12052         (linespec_parser): Remove typedef.
12053         (~linespec_parser): Rename from linespec_parser_delete.
12054         (linespec_lex_to_end, linespec_complete_label)
12055         (linespec_complete): Update.
12056         (decode_line_full): Remove cleanups.
12057         (decode_line_1): Update.
12058
12059 2019-01-02  Tom Tromey  <tom@tromey.com>
12060
12061         * python/python-internal.h (inferior_to_inferior_object): Change
12062         return type.
12063         * python/py-exitedevent.c (create_exited_event_object): Update.
12064         * python/py-inferior.c (inferior_to_inferior_object): Return
12065         gdbpy_ref.
12066         (python_new_inferior, python_inferior_deleted)
12067         (thread_to_thread_object, delete_thread_object)
12068         (build_inferior_list, gdbpy_selected_inferior): Update.
12069         * python/py-infthread.c (create_thread_object): Update.  Also fail
12070         if inferior_to_inferior_object fails.
12071
12072 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12073
12074         * inferior.h (class inferior) <displaced_step_state>: New field.
12075         * infrun.h (struct displaced_step_state): Move here from
12076         infrun.c.  Initialize fields, add constructor.
12077         <inf>: Remove field.
12078         <reset>: New method.
12079         * infrun.c (struct displaced_step_inferior_state): Move to
12080         infrun.h.
12081         (displaced_step_inferior_states): Remove.
12082         (get_displaced_stepping_state): Adust.
12083         (displaced_step_in_progress_any_inferior): Adjust.
12084         (displaced_step_in_progress_thread): Adjust.
12085         (displaced_step_in_progress): Adjust.
12086         (add_displaced_stepping_state): Remove.
12087         (get_displaced_step_closure_by_addr): Adjust.
12088         (remove_displaced_stepping_state): Remove.
12089         (infrun_inferior_exit): Call displaced_step_state.reset.
12090         (use_displaced_stepping): Don't check for NULL.
12091         (displaced_step_prepare_throw): Call
12092         get_displaced_stepping_state.
12093         (displaced_step_fixup): Don't check for NULL.
12094         (prepare_for_detach): Don't check for NULL.
12095
12096 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12097
12098         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12099          in case of call that did not complete.
12100
12101 2019-01-02  Andrey Utkin  <autkin@undo.io>
12102
12103         * symfile.c (find_separate_debug_file): Fix search of debug files for
12104         remote debuggee.
12105
12106 2019-01-02  Tom Tromey  <tom@tromey.com>
12107
12108         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12109         indentation.
12110         * python/py-frame.c (frapy_older): Remove cast.
12111         (frapy_newer): Likewise.
12112         * python/py-breakpoint.c (local_setattro): Remove cast.
12113         * python/py-arch.c (archpy_name): Remove local variable.
12114         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12115
12116 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12117
12118         * unittests/basic_string_view/element_access/char/empty.cc:
12119         Fix year range in copyright header.
12120
12121 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12122
12123         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12124         Delete.
12125         <operator==>: Update with for removed field.
12126         <hash>: Likewise.
12127         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12128         <isa_features>: ...this.
12129         <abi_features>: New field.
12130         (riscv_isa_flen): Update comment.
12131         (riscv_abi_xlen): New declaration.
12132         (riscv_abi_flen): New declaration.
12133         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12134         isa_features.
12135         (riscv_abi_xlen): New function.
12136         (riscv_isa_flen): Update to get answer from isa_features.
12137         (riscv_abi_flen): New function.
12138         (riscv_has_fp_abi): Update to get answer from abi_features.
12139         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12140         xlen and flen.
12141         (riscv_call_info) <xlen, flen>: Update comment.
12142         (riscv_call_arg_struct): Remove invalid assertions
12143         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12144         is removed.
12145         (riscv_gdbarch_init): Gather isa features and abi features
12146         separately, ensure both match on the gdbarch when reusing an old
12147         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12148         a target with 64-bit float hardware.
12149
12150 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12151
12152         * source.c (search_command_helper): Stop reverse search
12153         when line 1 has been searched.
12154
12155 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12156
12157         * record-full.c (record_full_base_target::close): Rewrite
12158         record_full_core_buf_list free logic.
12159
12160 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12161
12162         * break-catch-syscall.c (print_one_catch_syscall): xfree
12163         the last text.
12164
12165 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12166
12167         * top.c (print_gdb_version): Update Copyright year in version
12168         message.
12169
12170 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12171
12172         Update copyright year range in all GDB files.
12173
12174 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12175
12176         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12177
12178 For older changes see ChangeLog-2018.
12179 \f
12180 Local Variables:
12181 mode: change-log
12182 left-margin: 8
12183 fill-column: 74
12184 version-control: never
12185 coding: utf-8
12186 End:
12187