gdb/ChangeLog

   1 2020-04-28  Tom Tromey  <tom@tromey.com>
   2
   3         * NEWS: Update.
   4         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
   5         (cmdpy_init): Allow class_tui.
   6
   7 2020-04-28 Mark Williams <mark@myosotissp.com>
   8
   9         PR gdb/24480
  10         * dwarf2read.c: Add missing assingments to list_in_scope when
  11         start_symtab was already called.
  12
  13 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
  14
  15         PR gdb/25881
  16         * dwarf2/read.c (offset_map_type): Use
  17         gdb:hash_enum<sect_offset> as hash function.
  18
  19 2020-04-28  Tom de Vries  <tdevries@suse.de>
  20
  21         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
  22         with DW_AT_signature.
  23
  24 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
  25
  26         * configure.ac: Remove check for fs_base/gs_base in
  27         user_regs_struct.
  28         * configure: Re-generate.
  29         * config.in: Re-generate.
  30         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
  31         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
  32         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
  33
  34 2020-04-27  Luis Machado  <luis.machado@linaro.org>
  35
  36         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
  37         problematic inline frame unwinding situation.
  38         * frame.c (frame_id_computed_p): New function.
  39         * frame.h (frame_id_computed_p): New prototype.
  40
  41 2020-04-26  Tom Tromey  <tom@tromey.com>
  42
  43         * command.h (enum command_class) <class_pseudo>: Remove.
  44
  45 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  46
  47         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
  48         and whitespace.
  49
  50 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
  51
  52        * inf-ptrace.c (inf_ptrace_target::wait): Remove
  53        `PT_GET_PROCESS_STATE' block.
  54
  55 2020-04-24  Tom Tromey  <tom@tromey.com>
  56
  57         * symtab.h (symbol_get_demangled_name): Don't declare.
  58         * symtab.c (symbol_get_demangled_name): Remove.
  59         (general_symbol_info::natural_name)
  60         (general_symbol_info::demangled_name): Update.
  61
  62 2020-04-24  Tom Tromey  <tom@tromey.com>
  63
  64         PR rust/25025:
  65         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
  66
  67 2020-04-24  Tom Tromey  <tom@tromey.com>
  68
  69         PR symtab/12707:
  70         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
  71         exists.
  72         (new_symbol): Likewise.
  73         * compile/compile-object-load.c (get_out_value_type): Use
  74         symbol_matches_search_name.
  75
  76 2020-04-24  Tom Tromey  <tom@tromey.com>
  77
  78         * dwarf2/read.c (add_partial_symbol): Do not call
  79         compute_and_set_names.
  80
  81 2020-04-24  Tom Tromey  <tom@tromey.com>
  82
  83         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
  84         overload.
  85
  86 2020-04-24  Tom Tromey  <tom@tromey.com>
  87
  88         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
  89         (add_psymbol_to_list): New overload.  Make old overload call new
  90         one.
  91         * psympriv.h (add_psymbol_to_list): New overload.
  92
  93 2020-04-24  Tom Tromey  <tom@tromey.com>
  94
  95         * dwarf2/read.c (partial_die_info::read) <case
  96         DW_AT_linkage_name>: Use value_as_string.
  97         (dwarf2_string_attr): Use value_as_string.
  98         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
  99         method.
 100         * dwarf2/attribute.c (attribute::value_as_string): New method.
 101
 102 2020-04-24  Tom Tromey  <tom@tromey.com>
 103
 104         * symtab.c (general_symbol_info::natural_name)
 105         (general_symbol_info::demangled_name): Check for language_rust.
 106
 107 2020-04-24  Tom Tromey  <tom@tromey.com>
 108
 109         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 110         (dwarf2_physname): ... from here.
 111         (partial_die_info::read): Add Rust "{" hack.
 112
 113 2020-04-24  Tom Tromey  <tom@tromey.com>
 114
 115         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 116         method.
 117         (symbol_set_demangled_name): Don't declare.
 118         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 119         symbol_set_demangled_name.
 120         (general_symbol_info::set_language)
 121         (general_symbol_info::compute_and_set_names): Update.
 122         * minsyms.c (minimal_symbol_reader::install): Update.
 123         * dwarf2/read.c (new_symbol): Update.
 124
 125 2020-04-24  Tom Tromey  <tromey@adacore.com>
 126
 127         PR python/23662:
 128         * python/py-type.c (convert_field): Handle
 129         FIELD_LOC_KIND_DWARF_BLOCK.
 130         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 131         (typy_get_dynamic): Nw function.
 132         (type_object_getset): Add "dynamic".
 133         * NEWS: Add entry.
 134
 135 2020-04-24  Tom Tromey  <tromey@adacore.com>
 136
 137         * ada-typeprint.c (print_choices, print_variant_part)
 138         (print_record_field_types_dynamic): New functions.
 139         (print_record_field_types): Use print_record_field_types_dynamic.
 140
 141 2020-04-24  Tom Tromey  <tromey@adacore.com>
 142
 143         * dwarf2/read.c (handle_data_member_location): New overload.
 144         (dwarf2_add_field): Use it.
 145         (decode_locdesc): Add "computed" parameter.  Update comment.
 146         * gdbtypes.c (is_dynamic_type_internal): Also look for
 147         FIELD_LOC_KIND_DWARF_BLOCK.
 148         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 149         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 150         virtual base classes.
 151         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 152         FIELD_LOC_KIND_DWARF_BLOCK.
 153
 154 2020-04-24  Tom Tromey  <tromey@adacore.com>
 155
 156         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 157         * gdbtypes.c (is_dynamic_type_internal): Check
 158         TYPE_HAS_DYNAMIC_LENGTH.
 159         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 160         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 161         New macros.
 162         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 163         constant.
 164
 165 2020-04-24  Tom Tromey  <tromey@adacore.com>
 166
 167         * dwarf2/read.c (struct variant_field): Rewrite.
 168         (struct variant_part_builder): New.
 169         (struct nextfield): Remove "variant" field.  Add "offset".
 170         (struct field_info): Add "current_variant_part" and
 171         "variant_parts".
 172         (alloc_discriminant_info): Remove.
 173         (alloc_rust_variant): New function.
 174         (quirk_rust_enum): Update.
 175         (dwarf2_add_field): Set "offset" member.  Don't handle
 176         DW_TAG_variant_part.
 177         (offset_map_type): New typedef.
 178         (convert_variant_range, create_one_variant)
 179         (create_one_variant_part, create_variant_parts)
 180         (add_variant_property): New functions.
 181         (dwarf2_attach_fields_to_type): Call add_variant_property.
 182         (read_structure_type): Don't handle DW_TAG_variant_part.
 183         (handle_variant_part, handle_variant): New functions.
 184         (handle_struct_member_die): Use them.
 185         (process_structure_scope): Don't handle variant parts.
 186         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 187         (struct discriminant_info): Remove.
 188         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 189         (struct main_type) <flag_discriminated_union>: Remove.
 190         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 191         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 192         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 193         Update.
 194         * valops.c (value_union_variant): Remove.
 195         * value.h (value_union_variant): Don't declare.
 196
 197 2020-04-24  Tom Tromey  <tromey@adacore.com>
 198
 199         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 200         (ada_value_primitive_packed_val): Update.
 201         * ada-valprint.c (ada_value_print_1): Update.
 202         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 203         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 204         just an address.  Use evaluate_for_locexpr_baton.
 205         (dwarf2_evaluate_property): Update.
 206         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 207         array_view.
 208         * findvar.c (default_read_var_value): Update.
 209         * gdbtypes.c (compute_variant_fields_inner)
 210         (resolve_dynamic_type_internal): Update.
 211         (resolve_dynamic_type): Change type of valaddr parameter.
 212         * gdbtypes.h (resolve_dynamic_type): Update.
 213         * valarith.c (value_subscripted_rvalue): Update.
 214         * value.c (value_from_contents_and_address): Update.
 215
 216 2020-04-24  Tom Tromey  <tromey@adacore.com>
 217
 218         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 219         "push_initial_value" parameter.
 220         (dwarf2_evaluate_property): Likewise.
 221         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 222
 223 2020-04-24  Tom Tromey  <tromey@adacore.com>
 224
 225         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 226         (variant::matches, compute_variant_fields_recurse)
 227         (compute_variant_fields_inner, compute_variant_fields): New
 228         functions.
 229         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 230         Use resolved_type after type is made.
 231         (operator==): Add new cases.
 232         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 233         (struct discriminant_range, struct variant, struct variant_part):
 234         New.
 235         (union dynamic_prop_data) <variant_parts, original_type>: New
 236         members.
 237         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 238         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 239         constants.
 240         * value.c (unpack_bits_as_long): Now public.
 241         * value.h (unpack_bits_as_long): Declare.
 242
 243 2020-04-24  Tom Tromey  <tromey@adacore.com>
 244
 245         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 246         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 247
 248 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 249
 250         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 251
 252 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 253
 254         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 255         (remove_fork_catchpoint, post_startup_inferior)
 256         (post_attach): Move...
 257         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 258         (remove_fork_catchpoint, post_startup_inferior)
 259         (post_attach): ...here.
 260         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 261         (remove_fork_catchpoint, post_startup_inferior)
 262         (post_attach): Move...
 263         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 264         (remove_fork_catchpoint, post_startup_inferior)
 265         (post_attach): ...here.
 266
 267 2020-04-24  Tom Tromey  <tromey@adacore.com>
 268
 269         * nat/windows-nat.h (struct windows_thread_info)
 270         <pc_adjusted>: New member.
 271         * windows-nat.c (windows_fetch_one_register): Check
 272         pc_adjusted.
 273         (windows_nat_target::get_windows_debug_event)
 274         (windows_nat_target::wait): Set pc_adjusted.
 275
 276 2020-04-24  Tom de Vries  <tdevries@suse.de>
 277
 278         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 279         Run gdb-add-index inside temp dir.
 280
 281 2020-04-23  Tom Tromey  <tromey@adacore.com>
 282
 283         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 284         in loop.
 285
 286 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 287
 288         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 289         get_frame_register instead of gdbarch_unwind_pc.
 290
 291 2020-04-23  Tom de Vries  <tdevries@suse.de>
 292
 293         * symtab.c (lookup_global_symbol): Prefer def over decl.
 294
 295 2020-04-23  Tom de Vries  <tdevries@suse.de>
 296
 297         PR symtab/25807
 298         * block.c (best_symbol, better_symbol): Promote to external.
 299         * block.h (best_symbol, better_symbol): Declare.
 300         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 301         decl.
 302
 303 2020-04-23  Tom Tromey  <tromey@adacore.com>
 304
 305         PR ada/25837:
 306         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 307         "const char *", not a "const std::string &".
 308         <name_and_matcher::operator==>: Update.
 309         * unittests/lookup_name_info-selftests.c: Change type of
 310         "result".
 311
 312 2020-04-23  Tom Tromey  <tom@tromey.com>
 313
 314         * inferior.h (iterate_over_inferiors): Don't declare.
 315         * inferior.c (iterate_over_inferiors): Remove.
 316         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 317         Remove.
 318         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 319         use iterate_over_inferiors.
 320         (darwin_resume_inferior_it)
 321         (struct resume_inferior_threads_param)
 322         (darwin_resume_inferior_threads_it): Remove.
 323         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 324
 325 2020-04-23  Tom de Vries  <tdevries@suse.de>
 326
 327         * blockframe.c (find_pc_partial_function): Use
 328         find_pc_sect_compunit_symtab rather than
 329         objfile->sf->qf->find_pc_sect_compunit_symtab.
 330
 331 2020-04-22  Tom de Vries  <tdevries@suse.de>
 332
 333         PR symtab/25764
 334         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 335         in psymtabs.
 336
 337 2020-04-22  Tom de Vries  <tdevries@suse.de>
 338
 339         PR symtab/25801
 340         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 341         symtabs.
 342
 343 2020-04-22  Tom de Vries  <tdevries@suse.de>
 344
 345         PR symtab/25700
 346         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 347         CU if already created.
 348
 349 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 350
 351         * infrun.c (displaced_step_fixup): Switch to the event_thread
 352         before calling displaced_step_restore, not after.
 353
 354 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 355
 356         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 357         its inferior is not recorded by us.
 358         (record_btrace_target_open): Replace call to
 359         all_non_exited_threads () with call to current_inferior
 360         ()->non_exited_threads ().
 361         (record_btrace_target::stop_recording): Likewise.
 362         (record_btrace_target::close): Likewise.
 363         (record_btrace_target::wait): Likewise.
 364         (record_btrace_target::record_stop_replaying): Likewise.
 365
 366 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 367
 368         * btrace.c (btrace_enable): Throw an error on double enables and
 369         when enabling recording fails.
 370         (btrace_disable): Throw an error if the thread is not recorded.
 371
 372 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 373
 374         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 375         request if we do not have a thread_info.
 376
 377 2020-04-21  Tom de Vries  <tdevries@suse.de>
 378
 379         PR gdb/25471
 380         * thread.c
 381         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 382         exception in get_frame_id.
 383
 384 2020-04-20  Tom Tromey  <tromey@adacore.com>
 385
 386         * python/python.c (struct gdbpy_event): Mark move constructor as
 387         noexcept.
 388         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 389         constructor as noexcept.
 390         * completer.h (struct completion_result): Mark move constructor as
 391         noexcept.
 392         * completer.c (completion_result::completion_result): Use
 393         initialization style.  Don't call reset_match_list.
 394
 395 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 396
 397         * MAINTAINERS (Write After Approval): Add myself.
 398
 399 2020-04-18  Tom Tromey  <tom@tromey.com>
 400
 401         * windows-tdep.c (init_w32_command_list)
 402         (w32_prefix_command_valid): Restore.
 403         (_initialize_windows_tdep): Call init_w32_command_list.
 404
 405 2020-04-18  Tom Tromey  <tom@tromey.com>
 406
 407         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 408         * value.c (value_fn_field): Update.
 409         * valops.c (find_function_in_inferior)
 410         (value_allocate_space_in_inferior): Update.
 411         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 412         Update.
 413         * tui/tui-source.c (tui_source_window::set_contents): Update.
 414         * symtab.c (lookup_global_or_static_symbol)
 415         (find_function_start_sal_1, skip_prologue_sal)
 416         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
 417         * symmisc.c (dump_msymbols, dump_symtab_1)
 418         (maintenance_print_one_line_table): Update.
 419         * symfile.c (init_entry_point_info, section_is_mapped)
 420         (list_overlays_command, simple_read_overlay_table)
 421         (simple_overlay_update_1): Update.
 422         * stap-probe.c (handle_stap_probe): Update.
 423         * stabsread.c (dbx_init_float_type, define_symbol)
 424         (read_one_struct_field, read_enum_type, read_range_type): Update.
 425         * source.c (info_line_command): Update.
 426         * python/python.c (gdbpy_source_objfile_script)
 427         (gdbpy_execute_objfile_script): Update.
 428         * python/py-type.c (save_objfile_types): Update.
 429         * python/py-objfile.c (py_free_objfile): Update.
 430         * python/py-inferior.c (python_new_objfile): Update.
 431         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
 432         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
 433         (maintenance_check_psymtabs): Update.
 434         * printcmd.c (info_address_command): Update.
 435         * objfiles.h (struct objfile) <arch>: New method, from
 436         get_objfile_arch.
 437         (get_objfile_arch): Don't declare.
 438         * objfiles.c (get_objfile_arch): Remove.
 439         (filter_overlapping_sections): Update.
 440         * minsyms.c (msymbol_is_function): Update.
 441         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
 442         (output_nondebug_symbol): Update.
 443         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
 444         (mdebug_expand_psymtab): Update.
 445         * machoread.c (macho_add_oso_symfile): Update.
 446         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
 447         Update.
 448         * linux-fork.c (checkpoint_command): Update.
 449         * linespec.c (convert_linespec_to_sals): Update.
 450         * jit.c (finalize_symtab): Update.
 451         * infrun.c (insert_exception_resume_from_probe): Update.
 452         * ia64-tdep.c (ia64_find_unwind_table): Update.
 453         * hppa-tdep.c (internalize_unwinds): Update.
 454         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 455         Update.
 456         * gcore.c (call_target_sbrk): Update.
 457         * elfread.c (record_minimal_symbol, elf_symtab_read)
 458         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 459         (elf_gnu_ifunc_resolve_by_got): Update.
 460         * dwarf2/read.c (create_addrmap_from_index)
 461         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 462         (read_debug_names_from_section)
 463         (process_psymtab_comp_unit_reader, add_partial_symbol)
 464         (add_partial_subprogram, process_full_comp_unit)
 465         (read_file_scope, read_func_scope, read_lexical_block_scope)
 466         (read_call_site_scope, dwarf2_ranges_read)
 467         (dwarf2_record_block_ranges, dwarf2_add_field)
 468         (mark_common_block_symbol_computed, read_tag_pointer_type)
 469         (read_tag_string_type, dwarf2_init_float_type)
 470         (dwarf2_init_complex_target_type, read_base_type)
 471         (partial_die_info::read, partial_die_info::read)
 472         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 473         (dwarf2_fetch_die_loc_sect_off): Update.
 474         * dwarf2/loc.c (dwarf2_find_location_expression)
 475         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 476         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 477         (dwarf2_loc_desc_get_symbol_read_needs)
 478         (locexpr_describe_location_piece, locexpr_describe_location_1)
 479         (loclist_describe_location): Update.
 480         * dwarf2/index-write.c (write_debug_names): Update.
 481         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 482         * dtrace-probe.c (dtrace_process_dof): Update.
 483         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 484         (process_one_symbol): Update.
 485         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 486         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 487         (coff_read_enum_type): Update.
 488         * cli/cli-cmds.c (edit_command, list_command): Update.
 489         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 490         * breakpoint.c (create_overlay_event_breakpoint)
 491         (create_longjmp_master_breakpoint)
 492         (create_std_terminate_master_breakpoint)
 493         (create_exception_master_breakpoint, get_sal_arch): Update.
 494         * block.c (block_gdbarch): Update.
 495         * annotate.c (annotate_source_line): Update.
 496
 497 2020-04-17  Tom Tromey  <tromey@adacore.com>
 498
 499         * auto-load.c (show_auto_load_cmd): Remove.
 500         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 501         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 502         (maintenance_print_arc_command): Remove.
 503         * tui/tui-win.c (tui_command): Remove.
 504         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 505         * tui/tui-layout.c (tui_layout_command): Remove.
 506         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 507         * python/python.c (user_set_python, user_show_python): Remove.
 508         (_initialize_python): Use add_basic_prefix_cmd,
 509         add_show_prefix_cmd.
 510         * guile/guile.c (set_guile_command, show_guile_command): Remove.
 511         (install_gdb_commands): Use add_basic_prefix_cmd,
 512         add_show_prefix_cmd.
 513         (info_guile_command): Remove.
 514         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
 515         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
 516         add_show_prefix_cmd.
 517         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 518         Remove do_set and do_show parameters.
 519         * cli/cli-style.c (set_style, show_style): Remove.
 520         (_initialize_cli_style): Use add_basic_prefix_cmd,
 521         add_show_prefix_cmd.
 522         (cli_style_option::add_setshow_commands): Remove do_set and
 523         do_show parameters.
 524         (cli_style_option::add_setshow_commands): Use
 525         add_basic_prefix_cmd, add_show_prefix_cmd.
 526         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
 527         (set_style_name): Remove.
 528         * cli/cli-dump.c (dump_command, append_command): Remove.
 529         (srec_dump_command, ihex_dump_command, verilog_dump_command)
 530         (tekhex_dump_command, binary_dump_command)
 531         (binary_append_command): Remove.
 532         (_initialize_cli_dump): Use add_basic_prefix_cmd.
 533         * windows-tdep.c (w32_prefix_command_valid): Remove global.
 534         (init_w32_command_list): Remove; move into ...
 535         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
 536         * valprint.c (set_print, show_print, set_print_raw)
 537         (show_print_raw): Remove.
 538         (_initialize_valprint): Use add_basic_prefix_cmd,
 539         add_show_prefix_cmd.
 540         * typeprint.c (set_print_type, show_print_type): Remove.
 541         (_initialize_typeprint): Use add_basic_prefix_cmd,
 542         add_show_prefix_cmd.
 543         * record.c (set_record_command, show_record_command): Remove.
 544         (_initialize_record): Use add_basic_prefix_cmd,
 545         add_show_prefix_cmd.
 546         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
 547         add_show_prefix_cmd.
 548         (info_command, show_command, set_debug, show_debug): Remove.
 549         * top.h (set_history, show_history): Don't declare.
 550         * top.c (set_history, show_history): Remove.
 551         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
 552         (unset_tdesc_cmd): Remove.
 553         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
 554         add_show_prefix_cmd.
 555         * symtab.c (info_module_command): Remove.
 556         (_initialize_symtab): Use add_basic_prefix_cmd.
 557         * symfile.c (overlay_command): Remove.
 558         (_initialize_symfile): Use add_basic_prefix_cmd.
 559         * sparc64-tdep.c (info_adi_command): Remove.
 560         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
 561         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
 562         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
 563         add_show_prefix_cmd.
 564         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
 565         (_initialize_serial): Use add_basic_prefix_cmd,
 566         add_show_prefix_cmd.
 567         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
 568         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
 569         add_show_prefix_cmd.
 570         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
 571         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
 572         add_show_prefix_cmd.
 573         * riscv-tdep.c (show_riscv_command, set_riscv_command)
 574         (show_debug_riscv_command, set_debug_riscv_command): Remove.
 575         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
 576         add_show_prefix_cmd.
 577         * remote.c (remote_command, set_remote_cmd): Remove.
 578         (_initialize_remote): Use add_basic_prefix_cmd.
 579         * record-full.c (set_record_full_command)
 580         (show_record_full_command): Remove.
 581         (_initialize_record_full): Use add_basic_prefix_cmd,
 582         add_show_prefix_cmd.
 583         * record-btrace.c (cmd_set_record_btrace)
 584         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
 585         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
 586         (cmd_show_record_btrace_pt): Remove.
 587         (_initialize_record_btrace): Use add_basic_prefix_cmd,
 588         add_show_prefix_cmd.
 589         * ravenscar-thread.c (set_ravenscar_command)
 590         (show_ravenscar_command): Remove.
 591         (_initialize_ravenscar): Use add_basic_prefix_cmd,
 592         add_show_prefix_cmd.
 593         * mips-tdep.c (show_mips_command, set_mips_command)
 594         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
 595         add_show_prefix_cmd.
 596         * maint.c (maintenance_command, maintenance_info_command)
 597         (maintenance_check_command, maintenance_print_command)
 598         (maintenance_set_cmd, maintenance_show_cmd): Remove.
 599         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
 600         add_show_prefix_cmd.
 601         (show_per_command_cmd): Remove.
 602         * maint-test-settings.c (maintenance_set_test_settings_cmd):
 603         Remove.
 604         (maintenance_show_test_settings_cmd): Remove.
 605         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
 606         add_show_prefix_cmd.
 607         * maint-test-options.c (maintenance_test_options_command):
 608         Remove.
 609         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
 610         * macrocmd.c (macro_command): Remove
 611         (_initialize_macrocmd): Use add_basic_prefix_cmd.
 612         * language.c (set_check, show_check): Remove.
 613         (_initialize_language): Use add_basic_prefix_cmd,
 614         add_show_prefix_cmd.
 615         * infcmd.c (unset_command): Remove.
 616         (_initialize_infcmd): Use add_basic_prefix_cmd.
 617         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
 618         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
 619         add_show_prefix_cmd.
 620         * go32-nat.c (go32_info_dos_command): Remove.
 621         (_initialize_go32_nat): Use add_basic_prefix_cmd.
 622         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
 623         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
 624         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
 625         (_initialize_frame): Use add_basic_prefix_cmd,
 626         add_show_prefix_cmd.
 627         * dcache.c (set_dcache_command, show_dcache_command): Remove.
 628         (_initialize_dcache): Use add_basic_prefix_cmd,
 629         add_show_prefix_cmd.
 630         * cp-support.c (maint_cplus_command): Remove.
 631         (_initialize_cp_support): Use add_basic_prefix_cmd.
 632         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
 633         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
 634         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
 635         add_basic_prefix_cmd, add_show_prefix_cmd.
 636         * breakpoint.c (save_command): Remove.
 637         (_initialize_breakpoint): Use add_basic_prefix_cmd.
 638         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
 639         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
 640         add_show_prefix_cmd.
 641         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
 642         (set_ada_command, show_ada_command): Remove.
 643         (_initialize_ada_language): Use add_basic_prefix_cmd,
 644         add_show_prefix_cmd.
 645         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
 646
 647 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
 648
 649         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
 650         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
 651
 652 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 653
 654         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
 655         warning messages.
 656
 657 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 658
 659         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
 660         import table is not at beginning of .idata section.
 661
 662 2020-04-16  Pedro Alves  <palves@redhat.com>
 663
 664         * inferior.c (delete_inferior): Use delete operator directly
 665         instead of delete_program_space.
 666         * progspace.c (add_program_space): New, factored out from
 667         program_space::program_space.
 668         (remove_program_space): New, factored out from
 669         delete_program_space.
 670         (program_space::program_space): Remove intro comment.  Rewrite.
 671         (program_space::~program_space): Remove intro comment.  Call
 672         remove_program_space.
 673         (delete_program_space): Delete.
 674         * progspace.h (program_space::program_space): Make explicit.  Move
 675         intro comment here, adjusted.
 676         (program_space::~program_space): Move intro comment here,
 677         adjusted.
 678         (delete_program_space): Remove.
 679
 680 2020-04-16  Tom Tromey  <tromey@adacore.com>
 681
 682         * windows-nat.c (windows_nat::handle_access_violation): New
 683         function.
 684         * nat/windows-nat.h (handle_access_violation): Declare.
 685         * nat/windows-nat.c (handle_exception): Move Cygwin code to
 686         windows-nat.c.  Call handle_access_violation.
 687
 688 2020-04-16  Tom de Vries  <tdevries@suse.de>
 689
 690         PR symtab/25791
 691         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
 692         CUs without psymtab.
 693
 694 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
 695
 696         * python/python.c (do_start_initialization): Don't call
 697         PyEval_InitThreads for Python 3.9 and beyond.
 698
 699 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
 700
 701         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
 702         thread functions.
 703         (obsd_nat_target::wait): Likewise.
 704
 705 2020-04-15  Tom Tromey  <tromey@adacore.com>
 706
 707         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
 708         (DEBUG_EXCEPT): Use debug_printf.
 709
 710 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 711
 712         * completer.c (class completion_tracker::completion_hash_entry)
 713         <hash_name>: New member function.
 714         (completion_tracker::discard_completions): New callback to hash a
 715         completion_hash_entry, pass this to htab_create_alloc.
 716
 717 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
 718
 719         * windows-nat.c (windows_make_so): Warn rather than stopping with
 720         an error if realpath() fails.
 721
 722 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
 723
 724         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
 725         (nbsd_nat_target::info_proc): Add do_status.
 726
 727 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
 728             Tom de Vries  <tdevries@suse.de>
 729
 730         PR symtab/25718
 731         * psympriv.h (struct partial_symtab::read_symtab)
 732         (struct partial_symtab::expand_psymtab)
 733         (struct partial_symtab::read_dependencies): Update comments.
 734         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
 735         read_symtab for includer.
 736         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
 737         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
 738         (struct dwarf2_include_psymtab::m_readin): Remove.
 739         (struct dwarf2_include_psymtab::includer): New member function.
 740         (dwarf2_psymtab::expand_psymtab): Assert !readin.
 741
 742 2020-04-14  Tom de Vries  <tdevries@suse.de>
 743
 744         PR symtab/25720
 745         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
 746         with NULL symbol_matcher and lookup_name.
 747         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
 748         and lookup_name.
 749         * dwarf2/read.c (dw2_expand_symtabs_matching)
 750         (dw2_debug_names_expand_symtabs_matching): Same.
 751         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
 752         Make lookup_name a pointer.  Update comment.
 753         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
 754         lookup_name being a pointer.
 755         * symfile.c (expand_symtabs_matching): Same.
 756         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
 757         * linespec.c (iterate_over_all_matching_symtabs): Same.
 758
 759 2020-04-13  Tom Tromey  <tom@tromey.com>
 760
 761         * run-on-main-thread.c: Update include.
 762         * unittests/main-thread-selftests.c: Update include.
 763         * tui/tui-win.c: Update include.
 764         * tui/tui-io.c: Update include.
 765         * tui/tui-interp.c: Update include.
 766         * tui/tui-hooks.c: Update include.
 767         * top.h: Update include.
 768         * top.c: Update include.
 769         * ser-base.c: Update include.
 770         * remote.c: Update include.
 771         * remote-notif.c: Update include.
 772         * remote-fileio.c: Update include.
 773         * record-full.c: Update include.
 774         * record-btrace.c: Update include.
 775         * python/python.c: Update include.
 776         * posix-hdep.c: Update include.
 777         * mingw-hdep.c: Update include.
 778         * mi/mi-main.c: Update include.
 779         * mi/mi-interp.c: Update include.
 780         * main.c: Update include.
 781         * linux-nat.c: Update include.
 782         * interps.c: Update include.
 783         * infrun.c: Update include.
 784         * inf-loop.c: Update include.
 785         * event-top.c: Update include.
 786         * event-loop.c: Move to ../gdbsupport/.
 787         * event-loop.h: Move to ../gdbsupport/.
 788         * async-event.h: Update include.
 789         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
 790
 791 2020-04-13  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-win.c: Include async-event.h.
 794         * remote.c: Include async-event.h.
 795         * remote-notif.c: Include async-event.h.
 796         * record-full.c: Include async-event.h.
 797         * record-btrace.c: Include async-event.h.
 798         * infrun.c: Include async-event.h.
 799         * event-top.c: Include async-event.h.
 800         * event-loop.h: Move some declarations to async-event.h.
 801         * event-loop.c: Don't include ser-event.h or top.h.  Move some
 802         code to async-event.c.
 803         * async-event.h: New file.
 804         * async-event.c: New file.
 805         * Makefile.in (COMMON_SFILES): Add async-event.c.
 806         (HFILES_NO_SRCDIR): Add async-event.h.
 807
 808 2020-04-13  Tom Tromey  <tom@tromey.com>
 809
 810         * utils.c (flush_streams): New function.
 811         * event-loop.c (gdb_wait_for_event): Call flush_streams.
 812
 813 2020-04-13  Tom Tromey  <tom@tromey.com>
 814
 815         * event-loop.c (handle_file_event): Use warning, not
 816         printf_unfiltered.
 817
 818 2020-04-13  Tom Tromey  <tom@tromey.com>
 819
 820         * event-loop.c: Include <chrono>.
 821
 822 2020-04-13  Tom Tromey  <tom@tromey.com>
 823
 824         * gdb_select.h: Move to ../gdbsupport/.
 825         * event-loop.c: Update include path.
 826         * top.c: Update include path.
 827         * ser-base.c: Update include path.
 828         * ui-file.c: Update include path.
 829         * ser-tcp.c: Update include path.
 830         * guile/scm-ports.c: Update include path.
 831         * posix-hdep.c: Update include path.
 832         * ser-unix.c: Update include path.
 833         * gdb_usleep.c: Update include path.
 834         * mingw-hdep.c: Update include path.
 835         * inflow.c: Update include path.
 836         * infrun.c: Update include path.
 837         * event-top.c: Update include path.
 838
 839 2020-04-13  Tom Tromey  <tom@tromey.com>
 840
 841         * configure: Rebuild.
 842         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
 843
 844 2020-04-13  Tom Tromey  <tom@tromey.com>
 845
 846         * event-loop.h (start_event_loop): Don't declare.
 847         * event-loop.c (start_event_loop): Move...
 848         * main.c (start_event_loop): ...here.  Now static.
 849
 850 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
 851
 852         * MAINTAINERS: Update my email address.
 853
 854 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
 855
 856         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
 857         IP_ALL.
 858
 859 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
 860
 861         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
 862         (nbsd_nat_target::info_proc): Add do_cmdline.
 863
 864 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
 865
 866         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
 867         (nbsd_nat_target::info_proc): Add do_cwd.
 868
 869 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
 870
 871         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
 872
 873 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
 874
 875         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
 876         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
 877         (nbsd_nat_target::info_proc): New functions.
 878         * nbsd-nat.c (kinfo_get_vmmap): New function.
 879         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
 880         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
 881         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
 882         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
 883         functions.
 884         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
 885         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
 886         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
 887         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
 888         (KINFO_VME_FLAG_GROWS_DOWN): New.
 889
 890 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
 891
 892         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
 893         bit shift.
 894
 895 2020-04-10  Tom Tromey  <tromey@adacore.com>
 896
 897         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
 898
 899 2020-04-10  Tom Tromey  <tromey@adacore.com>
 900
 901         * symtab.c (get_symbol_address, get_msymbol_address): Skip
 902         separate debug files.
 903
 904 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
 905
 906         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
 907         Move to...
 908         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
 909         ... here.
 910         * windows-nat.c (windows_nat_target::get_windows_debug_event):
 911         Check for STATUS_WX86_BREAKPOINT.
 912         (windows_nat_target::wait): Same.
 913
 914 2020-04-10  Tom de Vries  <tdevries@suse.de>
 915
 916         PR cli/25808
 917         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
 918
 919 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
 920
 921         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
 922         (Write After Approval): Remove Tom de Vries.
 923
 924 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 925
 926         revert partially:
 927         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 928
 929         * buildsym.c (record_line): Fix undefined behavior and preserve
 930         lines at eof.
 931
 932 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
 933
 934         * auxv.h (svr4_auxv_parse): New.
 935         * auxv.c (default_auxv_parse): Split into default_auxv_parse
 936         and generic_auxv_parse.
 937         (svr4_auxv_parse): Add.
 938         * obsd-tdep.c: Include "auxv.h".
 939         (obsd_auxv_parse): Remove.
 940         (obsd_init_abi): Remove comment.
 941         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
 942         from `obsd_auxv_parse' to `svr4_auxv_parse'.
 943         * nbsd-tdep.c: Include "auxv.h".
 944         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
 945
 946 2020-04-08  Tom Tromey  <tromey@adacore.com>
 947
 948         * nat/windows-nat.h (last_wait_event): Don't declare.
 949         (wait_for_debug_event): Update comment.
 950         * nat/windows-nat.c (last_wait_event): Now static.
 951
 952 2020-04-08  Tom Tromey  <tromey@adacore.com>
 953
 954         * windows-nat.c (wait_for_debug_event): Move to
 955         nat/windows-nat.c.
 956         * nat/windows-nat.h (wait_for_debug_event): Declare.
 957         * nat/windows-nat.c (wait_for_debug_event): Move from
 958         windows-nat.c.  No longer static.
 959
 960 2020-04-08  Tom Tromey  <tromey@adacore.com>
 961
 962         * windows-nat.c (get_windows_debug_event): Use
 963         fetch_pending_stop.
 964         * nat/windows-nat.h (fetch_pending_stop): Declare.
 965         * nat/windows-nat.c (fetch_pending_stop): New function.
 966
 967 2020-04-08  Tom Tromey  <tromey@adacore.com>
 968
 969         * windows-nat.c (windows_continue): Use matching_pending_stop and
 970         continue_last_debug_event.
 971         * nat/windows-nat.h (matching_pending_stop)
 972         (continue_last_debug_event): Declare.
 973         * nat/windows-nat.c (DEBUG_EVENTS): New define.
 974         (matching_pending_stop, continue_last_debug_event): New
 975         functions.
 976
 977 2020-04-08  Tom Tromey  <tromey@adacore.com>
 978
 979         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
 980         (handle_exception_result): Move to nat/windows-nat.h.
 981         (DEBUG_EXCEPTION_SIMPLE): Remove.
 982         (windows_nat::handle_ms_vc_exception): New function.
 983         (handle_exception): Move to nat/windows-nat.c.
 984         (get_windows_debug_event): Update.
 985         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
 986         nat/windows-nat.c.
 987         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
 988         (handle_exception_result): Move from windows-nat.c.
 989         (handle_exception): Declare.
 990         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
 991         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
 992         windows-nat.c.
 993
 994 2020-04-08  Tom Tromey  <tromey@adacore.com>
 995
 996         * windows-nat.c (exception_count, event_count): Remove.
 997         (handle_exception, get_windows_debug_event)
 998         (do_initial_windows_stuff): Update.
 999
1000 2020-04-08  Tom Tromey  <tromey@adacore.com>
1001
1002         * windows-nat.c (windows_nat::handle_load_dll)
1003         (windows_nat::handle_unload_dll): Rename.  No longer static.
1004         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1005         Declare.
1006
1007 2020-04-08  Tom Tromey  <tromey@adacore.com>
1008
1009         * complaints.h (stop_whining): Declare at top-level.
1010         (complaint): Don't declare stop_whining.
1011
1012 2020-04-08  Tom Tromey  <tromey@adacore.com>
1013
1014         * windows-nat.c (windows_nat::handle_output_debug_string):
1015         Rename.  No longer static.
1016         * nat/windows-nat.h (handle_output_debug_string): Declare.
1017
1018 2020-04-08  Tom Tromey  <tromey@adacore.com>
1019
1020         * windows-nat.c (current_process_handle, current_process_id)
1021         (main_thread_id, last_sig, current_event, last_wait_event)
1022         (current_windows_thread, desired_stop_thread_id, pending_stops)
1023         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1024         (display_selectors, fake_create_process)
1025         (get_windows_debug_event): Update.
1026         * nat/windows-nat.h (current_process_handle, current_process_id)
1027         (main_thread_id, last_sig, current_event, last_wait_event)
1028         (current_windows_thread, desired_stop_thread_id, pending_stops)
1029         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1030         * nat/windows-nat.c (current_process_handle, current_process_id)
1031         (main_thread_id, last_sig, current_event, last_wait_event)
1032         (current_windows_thread, desired_stop_thread_id, pending_stops)
1033         (siginfo_er): New globals.  Move from windows-nat.c.
1034
1035 2020-04-08  Tom Tromey  <tromey@adacore.com>
1036
1037         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1038         (handle_load_dll): Update.
1039         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1040
1041 2020-04-08  Tom Tromey  <tromey@adacore.com>
1042
1043         * windows-nat.c (enum thread_disposition_type): Move to
1044         nat/windows-nat.h.
1045         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1046         static.
1047         (windows_add_thread, windows_nat_target::fetch_registers)
1048         (windows_nat_target::store_registers, handle_exception)
1049         (windows_nat_target::resume, get_windows_debug_event)
1050         (windows_nat_target::get_tib_address)
1051         (windows_nat_target::thread_name)
1052         (windows_nat_target::thread_alive): Update.
1053         * nat/windows-nat.h (enum thread_disposition_type): Move from
1054         windows-nat.c.
1055         (thread_rec): Declare.
1056
1057 2020-04-08  Tom Tromey  <tromey@adacore.com>
1058
1059         * windows-nat.c: Add "using namespace".
1060         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1061         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1062
1063 2020-04-08  Tom Tromey  <tromey@adacore.com>
1064
1065         * nat/windows-nat.h (struct windows_thread_info): Declare
1066         destructor.
1067         * nat/windows-nat.c (~windows_thread_info): New.
1068
1069 2020-04-08  Tom Tromey  <tromey@adacore.com>
1070
1071         PR gdb/22992
1072         * windows-nat.c (current_event): Update comment.
1073         (last_wait_event, desired_stop_thread_id): New globals.
1074         (struct pending_stop): New.
1075         (pending_stops): New global.
1076         (windows_nat_target) <stopped_by_sw_breakpoint>
1077         <supports_stopped_by_sw_breakpoint>: New methods.
1078         (windows_fetch_one_register): Add assertions.  Adjust PC.
1079         (windows_continue): Handle pending stops.  Suspend other threads
1080         when stepping.  Use last_wait_event
1081         (wait_for_debug_event): New function.
1082         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1083         pending stops.  Queue spurious stops.
1084         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1085         (windows_nat_target::kill): Use wait_for_debug_event.
1086         * nat/windows-nat.h (struct windows_thread_info)
1087         <stopped_at_software_breakpoint>: New field.
1088         * nat/windows-nat.c (windows_thread_info::resume): Clear
1089         stopped_at_software_breakpoint.
1090
1091 2020-04-08  Tom Tromey  <tromey@adacore.com>
1092
1093         * windows-nat.c (enum thread_disposition_type): New.
1094         (thread_rec): Replace "get_context" parameter with "disposition";
1095         change type.
1096         (windows_add_thread, windows_nat_target::fetch_registers)
1097         (windows_nat_target::store_registers, handle_exception)
1098         (windows_nat_target::resume, get_windows_debug_event)
1099         (windows_nat_target::get_tib_address)
1100         (windows_nat_target::thread_name)
1101         (windows_nat_target::thread_alive): Update.
1102
1103 2020-04-08  Tom Tromey  <tromey@adacore.com>
1104
1105         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1106         (windows_continue): Use windows_continue::resume.
1107         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1108         resume>: Declare new methods.
1109         * nat/windows-nat.c: New file.
1110         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1111
1112 2020-04-08  Tom Tromey  <tromey@adacore.com>
1113
1114         * windows-nat.c (windows_add_thread, windows_delete_thread)
1115         (windows_nat_target::fetch_registers)
1116         (windows_nat_target::store_registers, fake_create_process)
1117         (windows_nat_target::resume, windows_nat_target::resume)
1118         (get_windows_debug_event, windows_nat_target::wait)
1119         (windows_nat_target::pid_to_str)
1120         (windows_nat_target::get_tib_address)
1121         (windows_nat_target::get_ada_task_ptid)
1122         (windows_nat_target::thread_name)
1123         (windows_nat_target::thread_alive): Use lwp, not tid.
1124
1125 2020-04-08  Tom Tromey  <tromey@adacore.com>
1126
1127         * windows-nat.c (handle_exception)
1128         (windows_nat_target::thread_name): Update.
1129         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1130         <name>: Now unique_xmalloc_ptr.
1131
1132 2020-04-08  Tom Tromey  <tromey@adacore.com>
1133
1134         * windows-nat.c (thread_rec)
1135         (windows_nat_target::fetch_registers): Update.
1136         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1137         Update comment.
1138         <debug_registers_changed, reload_context>: Now bool.
1139
1140 2020-04-08  Tom Tromey  <tromey@adacore.com>
1141
1142         * windows-nat.c (windows_add_thread): Use new.
1143         (windows_init_thread_list, windows_delete_thread): Use delete.
1144         (get_windows_debug_event): Update.
1145         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1146         destructor, and initializers.
1147
1148 2020-04-08  Tom Tromey  <tromey@adacore.com>
1149
1150         * windows-nat.c (struct windows_thread_info): Remove.
1151         * nat/windows-nat.h: New file.
1152
1153 2020-04-08  Tom Tromey  <tromey@adacore.com>
1154
1155         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1156         (thread_rec, windows_add_thread, windows_delete_thread)
1157         (windows_continue): Update.
1158
1159 2020-04-08  Tom Tromey  <tromey@adacore.com>
1160
1161         * windows-nat.c (struct windows_thread_info): Remove typedef.
1162         (thread_head): Remove.
1163         (thread_list): New global.
1164         (thread_rec, windows_add_thread, windows_init_thread_list)
1165         (windows_delete_thread, windows_continue): Update.
1166
1167 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1168
1169         * windows-tdep.h (windows_init_abi): Add comment.
1170         (cygwin_init_abi): New declaration.
1171         * windows-tdep.c: Split signal enumeration in two, one for
1172         Windows and one for Cygwin.
1173         (windows_gdb_signal_to_target): Only deal with signal of the
1174         Windows OS ABI.
1175         (cygwin_gdb_signal_to_target): New function.
1176         (windows_init_abi): Rename to windows_init_abi_common, don't set
1177         gdb_signal_to_target gdbarch method.  Add new new function with
1178         this name.
1179         (cygwin_init_abi): New function.
1180         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1181         comment.  Don't call windows_init_abi.
1182         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1183         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1184         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1185         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1186         a new function of this name.
1187         (i386_cygwin_init_abi): New function.
1188         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1189         OS ABI Cygwin.
1190
1191 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1192
1193         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1194         parameter.c.
1195         (dwarf2_read_gdb_index): Update.
1196
1197 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1198
1199         * nbsd-tdep.c: Include "objfiles.h".
1200         (nbsd_skip_solib_resolver): New.
1201         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1202
1203 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1204
1205         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1206         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1207         with DW_LLE_base_addressx are being emitted in DWARFv5.
1208         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1209         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1210         unsigned integer.
1211
1212 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1213
1214         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1215         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1216         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1217         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1218         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1219         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1220         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1221
1222
1223 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1224
1225         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1226         (read_loclist_index): New function definition.
1227         (lookup_loclist_base): New function definition.
1228         (read_loclist_header): New function definition.
1229         (dwarf2_cu): Add loclist_base and loclist_header field.
1230         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1231         (read_full_die_1): Read the value of DW_AT_loclists_base.
1232         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1233         (read_attribute_value): Handle DW_FORM_loclistx.
1234         (skip_one_die): Handle DW_FORM_loclistx.
1235         (loclist_header): New structure declaration.
1236         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1237
1238 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1239
1240         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1241         constructor.  Remove `addr` parameter from other constructor and
1242         add `per_cu` parameter.
1243         * dwarf2/read.c (create_partial_symtab): Update.
1244
1245 2020-04-07  Tom de Vries  <tdevries@suse.de>
1246
1247         PR symtab/25796
1248         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1249         (partial_die_info::fixup): Inherit has_const_value.
1250
1251 2020-04-07  Tom de Vries  <tdevries@suse.de>
1252
1253         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1254         symbols without address.
1255
1256 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1257
1258         * nbsd-nat.h (struct thread_info): Add forward declaration.
1259         (nbsd_nat_target::thread_alive): Add.
1260         (nbsd_nat_target::thread_name): Likewise.
1261         (nbsd_nat_target::update_thread_list): Likewise.
1262         (update_thread_list::post_attach): Likewise.
1263         (post_attach::pid_to_str): Likewise.
1264         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1265         (nbsd_thread_lister): Add.
1266         (nbsd_nat_target::thread_alive): Likewise.
1267         (nbsd_nat_target::thread_name): Likewise.
1268         (nbsd_add_threads): Likewise.
1269         (update_thread_list::post_attach): Likewise.
1270         (nbsd_nat_target::update_thread_list): Likewise.
1271         (post_attach::pid_to_str): Likewise.
1272
1273 2020-04-06  Tom Tromey  <tromey@adacore.com>
1274
1275         * ada-valprint.c (print_variant_part): Extract the variant field.
1276         (print_field_values): Use the field as the outer value when
1277         recursing.
1278
1279 2020-04-06  Tom Tromey  <tromey@adacore.com>
1280
1281         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1282         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1283         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1284         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1285         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1286
1287 2020-04-06  Tom Tromey  <tromey@adacore.com>
1288
1289         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1290         TYPE_CODE_ERROR.
1291
1292 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1293
1294         * nbsd-tdep.c: Include "gdbarch.h".
1295         Define enum with NetBSD signal numbers.
1296         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1297         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1298         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1299         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1300         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1301         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1302         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1303         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1304         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1305         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1306         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1307         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1308
1309 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1310
1311         PR gdb/25325
1312         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1313
1314 2020-04-03  Tom Tromey  <tromey@adacore.com>
1315
1316         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1317         Read constant block.
1318
1319 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1320
1321         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1322         (gdb_bfd_get_full_section_contents): New declaration.
1323         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1324         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1325         gdb_bfd_get_full_section_contents.
1326
1327 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1328
1329         * exec.c (build_section_table): Replace internal_error with
1330         gdb_assert.
1331         (section_table_xfer_memory_partial): Likewise.
1332         * mdebugread.c (parse_partial_symbols): Likewise.
1333         * psymtab.c (lookup_partial_symbol): Likewise.
1334         * utils.c (wrap_here): Likewise.
1335
1336 2020-04-02  Tom Tromey  <tromey@adacore.com>
1337
1338         * f-lang.c (build_fortran_types): Use arch_type to initialize
1339         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1340
1341 2020-04-02  Tom Tromey  <tromey@adacore.com>
1342
1343         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1344         of attributes.
1345
1346 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1347             Bernd Edlinger <bernd.edlinger@hotmail.de>
1348             Tom Tromey  <tromey@adacore.com>
1349
1350         * buildsym.c (buildsym_compunit::record_line): Remove
1351         deduplication code.
1352
1353 2020-04-02  Tom de Vries  <tdevries@suse.de>
1354
1355         PR ada/24671
1356         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1357
1358 2020-04-02  Tom de Vries  <tdevries@suse.de>
1359
1360         * dwarf2/read.c (dwarf2_gdb_index_functions,
1361         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1362         NULL.
1363         * psymtab.c (psym_lookup_global_symbol_language): New function.
1364         (psym_functions): Init psym_lookup_global_symbol_language with
1365         psym_lookup_global_symbol_language.
1366         * symfile-debug.c (debug_sym_quick_functions): Init
1367         lookup_global_symbol_language with NULL.
1368         * symfile.c (set_initial_language): Remove fixme comment.
1369         * symfile.h (struct quick_symbol_functions): Add
1370         lookup_global_symbol_language.
1371         * symtab.c (find_quick_global_symbol_language): New function.
1372         (find_main_name): Use find_quick_global_symbol_language.
1373
1374 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1375
1376         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1377
1378 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1379
1380         * buildsym.c (record_line): Fix undefined behavior and preserve
1381         lines at eof.
1382
1383 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1384
1385         * buildsym.c (record_line): Fix the resizing condition.
1386
1387 2020-04-01  Tom Tromey  <tom@tromey.com>
1388
1389         * value.h (value_literal_complex): Add comment.
1390         * valops.c (value_literal_complex): Refer to value.h.
1391
1392 2020-04-01  Tom Tromey  <tom@tromey.com>
1393
1394         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1395         (scalar_type): New rule, from typebase.
1396         (typebase): Use scalar_type.  Recognize complex types.
1397         (field_name): Handle FLOAT_KEYWORD.
1398         (ident_tokens): Add _Complex and __complex__.
1399
1400 2020-04-01  Tom Tromey  <tom@tromey.com>
1401
1402         PR exp/25299:
1403         * valarith.c (promotion_type, complex_binop): New functions.
1404         (scalar_binop): Handle complex numbers.  Use promotion_type.
1405         (value_pos, value_neg, value_complement): Handle complex numbers.
1406
1407 2020-04-01  Tom Tromey  <tom@tromey.com>
1408
1409         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1410         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1411         (parse_number): Handle complex numbers.
1412
1413 2020-04-01  Tom Tromey  <tom@tromey.com>
1414
1415         * c-valprint.c (c_decorations): Change complex suffix to "i".
1416
1417 2020-04-01  Tom Tromey  <tom@tromey.com>
1418
1419         * valprint.c (generic_value_print_complex): Use accessors.
1420         * value.h (value_real_part, value_imaginary_part): Declare.
1421         * valops.c (value_real_part, value_imaginary_part): New
1422         functions.
1423         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1424
1425 2020-04-01  Tom Tromey  <tom@tromey.com>
1426
1427         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1428         (read_range_type): Update.
1429         * mdebugread.c (basic_type): Update.
1430         * go-lang.c (build_go_types): Use init_complex_type.
1431         * gdbtypes.h (struct main_type) <complex_type>: New member.
1432         (init_complex_type): Update.
1433         (arch_complex_type): Don't declare.
1434         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1435         Make name if none given.  Use alloc_type_copy.  Look for cached
1436         complex type.
1437         (arch_complex_type): Remove.
1438         (gdbtypes_post_init): Use init_complex_type.
1439         * f-lang.c (build_fortran_types): Use init_complex_type.
1440         * dwarf2/read.c (read_base_type): Update.
1441         * d-lang.c (build_d_types): Use init_complex_type.
1442         * ctfread.c (read_base_type): Update.
1443
1444 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1445
1446         * infrun.c (stop_all_threads): Update assertion, plus when
1447         stopping threads, take into account that we might be trying
1448         to stop an all-stop target.
1449         (stop_waiting): Call 'stop_all_threads' if there exists a
1450         non-stop target.
1451
1452 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1453
1454         * target.h (exists_non_stop_target): New function declaration.
1455         * target.c (exists_non_stop_target): New function.
1456
1457 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1458
1459         PR gdb/24789
1460         * eval.c (is_integral_or_integral_reference): New function.
1461         (evaluate_subexp_standard): Allow integer references in
1462         pointer arithmetic.
1463
1464 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1465
1466         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1467         check for no ptid in the stop reply when the target is non-stop.
1468
1469 2020-04-01  Tom Tromey  <tromey@adacore.com>
1470
1471         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1472         "name" parameter to rvalue reference.  Initialize m_name_holder.
1473         <lookup_name_info>: New overloads.
1474         <name>: Return gdb::string_view.
1475         <c_str>: New method.
1476         <make_ignore_params>: Update.
1477         <search_name_hash>: Update.
1478         <language_lookup_name>: Return const char *.
1479         <m_name>: Change type.
1480         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1481         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1482         (lookup_name_info::match_any): Update.
1483         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1484         Update.
1485         * minsyms.c (linkage_name_str): Update.
1486         * language.c (default_symbol_name_matcher): Update.
1487         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1488         Update.
1489         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1490         (ada_lookup_name_info::ada_lookup_name_info): Update.
1491         (literal_symbol_name_matcher): Update.
1492
1493 2020-04-01  Tom Tromey  <tromey@adacore.com>
1494
1495         * psymtab.c (psymtab_search_name): Remove function.
1496         (psym_lookup_symbol): Create search name and lookup name here.
1497         (lookup_partial_symbol): Remove "name" parameter; add
1498         lookup_name.
1499         (psym_expand_symtabs_for_function): Update.
1500
1501 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1502
1503         PR tui/25597:
1504         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1505
1506 2020-03-31  Tom Tromey  <tromey@adacore.com>
1507
1508         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
1509         memcpy.
1510
1511 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
1512
1513         * features/riscv/32bit-csr.xml: Regenerated.
1514         * features/riscv/64bit-csr.xml: Regenerated.
1515
1516 2020-03-30  Tom Tromey  <tromey@adacore.com>
1517
1518         * ada-valprint.c (print_variant_part): Update.
1519         * ada-lang.h (ada_which_variant_applies): Update.
1520         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
1521         outer_valaddr parameters; replace with "outer" value parameter.
1522         (to_fixed_variant_branch_type): Update.
1523
1524 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1525
1526         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
1527         <list>.  Remove inclusion of observable.h.
1528         (PPC_DEBUG_CURRENT_VERSION): Move up define.
1529         (struct arch_lwp_info): New struct.
1530         (class ppc_linux_dreg_interface): New class.
1531         (struct ppc_linux_process_info): New struct.
1532         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
1533         <low_new_clone, low_forget_process, low_prepare_to_resume>
1534         <copy_thread_dreg_state, mark_thread_stale>
1535         <mark_debug_registers_changed, register_hw_breakpoint>
1536         <clear_hw_breakpoint, register_wp, clear_wp>
1537         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
1538         <num_memory_accesses, get_trigger_type>
1539         <create_watchpoint_request, hwdebug_point_cmp>
1540         <init_arch_lwp_info, get_arch_lwp_info>
1541         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
1542         methods.
1543         <struct ptid_hash>: New inner struct.
1544         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
1545         members.
1546         (saved_dabr_value, hwdebug_info, max_slots_number)
1547         (struct hw_break_tuple, struct thread_points, ppc_threads)
1548         (have_ptrace_hwdebug_interface)
1549         (hwdebug_find_thread_points_by_tid)
1550         (hwdebug_insert_point, hwdebug_remove_point): Remove.
1551         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
1552         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
1553         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
1554         use m_dreg_interface.
1555         (hwdebug_point_cmp): Change to...
1556         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
1557         reference arguments instead of pointers.
1558         (ppc_linux_nat_target::ranged_break_num_registers): Use
1559         m_dreg_interface.
1560         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
1561         m_dreg_interface.  Call register_hw_breakpoint.
1562         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
1563         m_dreg_interface.  Call clear_hw_breakpoint.
1564         (get_trigger_type): Change to...
1565         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
1566         comment.
1567         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
1568         use m_dreg_interface.  Call register_hw_breakpoint.
1569         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
1570         use m_dreg_interface.  Call clear_hw_breakpoint.
1571         (can_use_watchpoint_cond_accel): Change to...
1572         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
1573         method.  Update comment, use m_dreg_interface and
1574         m_process_info.
1575         (calculate_dvc): Change to...
1576         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
1577         m_dreg_interface.
1578         (num_memory_accesses): Change to...
1579         (ppc_linux_nat_target::num_memory_accesses): ...this method.
1580         (check_condition): Change to...
1581         (ppc_linux_nat_target::check_condition): ...this method.
1582         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
1583         comment, use m_dreg_interface.
1584         (create_watchpoint_request): Change to...
1585         (ppc_linux_nat_target::create_watchpoint_request): ...this
1586         method.  Use m_dreg_interface.
1587         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
1588         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
1589         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
1590         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
1591         (ppc_linux_nat_target::low_forget_process)
1592         (ppc_linux_nat_target::low_new_fork)
1593         (ppc_linux_nat_target::low_new_clone)
1594         (ppc_linux_nat_target::low_delete_thread)
1595         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
1596         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
1597         only call mark_thread_stale.
1598         (ppc_linux_thread_exit): Remove.
1599         (ppc_linux_nat_target::stopped_data_address): Change to...
1600         (ppc_linux_nat_target::low_stopped_data_address): This. Add
1601         comment, use m_dreg_interface and m_thread_hw_breakpoints.
1602         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
1603         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
1604         comment.  Call low_stopped_data_address.
1605         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
1606         m_dreg_interface.
1607         (ppc_linux_nat_target::masked_watch_num_registers): Use
1608         m_dreg_interface.
1609         (ppc_linux_nat_target::copy_thread_dreg_state)
1610         (ppc_linux_nat_target::mark_thread_stale)
1611         (ppc_linux_nat_target::mark_debug_registers_changed)
1612         (ppc_linux_nat_target::register_hw_breakpoint)
1613         (ppc_linux_nat_target::clear_hw_breakpoint)
1614         (ppc_linux_nat_target::register_wp)
1615         (ppc_linux_nat_target::clear_wp)
1616         (ppc_linux_nat_target::init_arch_lwp_info)
1617         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
1618         (_initialize_ppc_linux_nat): Remove observer callback.
1619
1620 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1621
1622         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
1623         (ppc_linux_nat_target::auxv_parse)
1624         (ppc_linux_nat_target::read_description)
1625         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
1626         Move up.
1627
1628 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1629
1630         * linux-nat.h (low_new_clone): New method.
1631         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
1632
1633 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1634
1635         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
1636         (dbx_expand_psymtab): ... this.
1637         (start_psymtab): Update.
1638         * mdebugread.c (psymtab_to_symtab_1): Rename to...
1639         (mdebug_expand_psymtab): ... this.
1640         (parse_partial_symbols): Update.
1641         (new_psymtab): Update.
1642         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
1643         (xcoff_expand_psymtab): ... this.
1644         (xcoff_start_psymtab): Update.
1645
1646 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1647
1648         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
1649         <expand_dependencies>: ... this.
1650         * psymtab.c (partial_symtab::read_dependencies): Rename to...
1651         (partial_symtab::expand_dependencies): ... this.
1652         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
1653         Update.
1654         (dwarf2_psymtab::expand_psymtab): Update.
1655         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1656         * mdebugread.c (psymtab_to_symtab_1): Update.
1657         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1658
1659 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1660
1661         * psympriv.h (discard_psymtab): Remove.
1662         * dbxread.c (dbx_end_psymtab): Update.
1663         * xcoffread.c (xcoff_end_psymtab): Update.
1664
1665 2020-03-28  Tom Tromey  <tom@tromey.com>
1666
1667         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
1668         comment.
1669
1670 2020-03-28  Tom Tromey  <tom@tromey.com>
1671
1672         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
1673
1674 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
1675
1676         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1677
1678 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
1679
1680         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
1681
1682 2020-03-26  Tom Tromey  <tom@tromey.com>
1683
1684         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
1685         (mark_common_block_symbol_computed, read_tag_string_type)
1686         (attr_to_dynamic_prop, read_subrange_type): Update.
1687         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
1688         to be methods on struct attribute.
1689         (skip_one_die, process_imported_unit_die, read_namespace_alias)
1690         (read_call_site_scope, partial_die_info::read)
1691         (partial_die_info::read, lookup_die_type, follow_die_ref):
1692         Update.
1693         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
1694         from dwarf2_get_ref_die_offset.
1695         (attribute::constant_value): New method, from
1696         dwarf2_get_attr_constant_value.
1697         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
1698         Declare method.
1699         <constant_value>: New method.
1700
1701 2020-03-26  Tom Tromey  <tom@tromey.com>
1702
1703         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
1704         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
1705         (dwarf_type_encoding_name): Move to stringify.c.
1706         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
1707         * dwarf2/stringify.c: New file.
1708         * dwarf2/stringify.h: New file.
1709
1710 2020-03-26  Tom Tromey  <tom@tromey.com>
1711
1712         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
1713         Rewrite.
1714
1715 2020-03-26  Tom Tromey  <tom@tromey.com>
1716
1717         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
1718         methods.
1719         * dwarf2/read.c (lookup_addr_base): Move to die.h.
1720         (lookup_ranges_base): Likewise.
1721         (read_cutu_die_from_dwo, read_full_die_1): Update.
1722
1723 2020-03-26  Tom Tromey  <tom@tromey.com>
1724
1725         * dwarf2/read.c (read_import_statement, read_file_scope)
1726         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
1727         (read_lexical_block_scope, read_call_site_scope)
1728         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
1729         (handle_struct_member_die, process_structure_scope)
1730         (update_enumeration_type_from_children)
1731         (process_enumeration_scope, read_array_type, read_common_block)
1732         (read_namespace, read_module, read_subroutine_type): Update.
1733         (sibling_die): Remove.
1734
1735 2020-03-26  Tom Tromey  <tom@tromey.com>
1736
1737         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
1738         (build_type_psymtabs_reader, read_structure_type)
1739         (read_enumeration_type, read_full_die_1): Update.
1740         (dwarf2_attr_no_follow): Move to die.h.
1741         * dwarf2/die.h (struct die_info) <attr>: New method.
1742
1743 2020-03-26  Tom Tromey  <tom@tromey.com>
1744
1745         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
1746         <base_address>: Now an optional.
1747         (dwarf2_find_base_address, dwarf2_rnglists_process)
1748         (dwarf2_ranges_process, fill_in_loclist_baton)
1749         (dwarf2_symbol_mark_computed): Update.
1750
1751 2020-03-26  Tom Tromey  <tom@tromey.com>
1752
1753         * dwarf2/read.c (struct die_info): Move to die.h.
1754         * dwarf2/die.h: New file.
1755
1756 2020-03-26  Tom Tromey  <tom@tromey.com>
1757
1758         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
1759         * dwarf2/read.c
1760         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1761         Move to line-header.c.
1762         (read_checked_initial_length_and_offset, read_formatted_entries):
1763         Likewise.
1764         (dwarf_decode_line_header): Split into two.
1765         * dwarf2/line-header.c
1766         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1767         Move from read.c.
1768         (read_checked_initial_length_and_offset, read_formatted_entries):
1769         Likewise.
1770         (dwarf_decode_line_header): New function, split from read.c.
1771
1772 2020-03-26  Tom Tromey  <tom@tromey.com>
1773
1774         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
1775         Declare method.
1776         * dwarf2/read.c (read_attribute_value): Update.
1777         (dwarf2_per_objfile::read_line_string): Rename from
1778         read_indirect_line_string.
1779         (read_formatted_entries): Update.
1780
1781 2020-03-26  Tom Tromey  <tom@tromey.com>
1782
1783         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
1784         variable.
1785
1786 2020-03-26  Tom Tromey  <tom@tromey.com>
1787
1788         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
1789         const.
1790         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
1791         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
1792         parameter const.
1793
1794 2020-03-26  Tom Tromey  <tom@tromey.com>
1795
1796         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
1797         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
1798         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
1799         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
1800
1801 2020-03-26  Tom Tromey  <tom@tromey.com>
1802
1803         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
1804         file_names_size, file_full_name, file_file_name>: Use const.
1805         <file_name_at, file_names>: Add const overload.
1806         * dwarf2/line-header.c (line_header::file_file_name)
1807         (line_header::file_full_name): Update.
1808
1809 2020-03-26  Tom Tromey  <tom@tromey.com>
1810
1811         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
1812         (macro_start_file, consume_improper_spaces)
1813         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
1814         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
1815         (dwarf_decode_macros): Move to macro.c.
1816         * dwarf2/macro.c: New file.
1817         * dwarf2/macro.h: New file.
1818         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
1819
1820 2020-03-26  Tom Tromey  <tom@tromey.com>
1821
1822         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
1823         method.
1824         * dwarf2/section.c: New method.  From
1825         read_indirect_string_at_offset_from.
1826         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
1827         (read_indirect_string_at_offset_from): Move to section.c.
1828         (read_indirect_string_at_offset): Rewrite.
1829         (read_indirect_line_string_at_offset): Remove.
1830         (read_indirect_string, read_indirect_line_string)
1831         (dwarf_decode_macro_bytes): Update.
1832
1833 2020-03-26  Tom Tromey  <tom@tromey.com>
1834
1835         * dwarf2/section.h (struct dwarf2_section_info)
1836         <overload_complaint>: Declare.
1837         (dwarf2_section_buffer_overflow_complaint): Don't declare.
1838         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
1839         Rename from dwarf2_section_buffer_overflow_complaint.
1840         * dwarf2/read.c (skip_one_die, partial_die_info::read)
1841         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
1842
1843 2020-03-26  Tom Tromey  <tom@tromey.com>
1844
1845         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
1846         Declare.
1847         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
1848         Move from read.c.
1849         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
1850         to section.c.
1851
1852 2020-03-26  Tom Tromey  <tom@tromey.com>
1853
1854         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
1855
1856 2020-03-26  Tom Tromey  <tom@tromey.com>
1857
1858         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
1859         "builder".
1860         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
1861         parameter.
1862         (dwarf_decode_macros): Update.
1863
1864 2020-03-26  Tom Tromey  <tom@tromey.com>
1865
1866         * dwarf2/read.c (read_attribute_value): Update.
1867         (read_indirect_string_from_dwz): Move to dwz.c; change into
1868         method.
1869         (dwarf_decode_macro_bytes): Update.
1870         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
1871         * dwarf2/dwz.c: New file.
1872         * Makefile.in (COMMON_SFILES): Add dwz.c.
1873
1874 2020-03-26  Tom Tromey  <tom@tromey.com>
1875
1876         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
1877         * dwarf2/read.c: Add include.
1878         * dwarf2/index-write.c: Add include.
1879         * dwarf2/index-cache.c: Add include.
1880         * dwarf2/dwz.h: New file.
1881
1882 2020-03-25  Tom Tromey  <tom@tromey.com>
1883
1884         * compile/compile-object-load.c (get_out_value_type): Mention
1885         correct symbol name in error message.
1886
1887 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
1888
1889         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1890
1891 2020-03-25  Tom de Vries  <tdevries@suse.de>
1892
1893         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
1894         * symmisc.c (dump_symtab_1): Print user and includes fields.
1895         (maintenance_info_symtabs): Same.
1896
1897 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         PR gdb/25534
1900         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
1901         (riscv_regcache_cooked_write): New function.
1902         (riscv_push_dummy_call): Use new function.
1903         (riscv_return_value): Likewise.
1904
1905 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
1906
1907         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
1908         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
1909         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
1910         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
1911         * infrun.c (follow_fork): Likewise.
1912         (follow_fork_inferior): Likewise.
1913         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
1914         * linux-nat.h (class linux_nat_target): Likewise.
1915         * remote.c (class remote_target) <follow_fork>: Likewise.
1916         (remote_target::follow_fork): Likewise.
1917         * target-delegates.c: Re-generate.
1918         * target.c (default_follow_fork): Likewise.
1919         (target_follow_fork): Likewise.
1920         * target.h (struct target_ops) <follow_fork>: Likewise.
1921         (target_follow_fork): Likewise.
1922
1923 2020-03-24  Tom de Vries  <tdevries@suse.de>
1924
1925         * psymtab.c (maintenance_info_psymtabs): Print user field.
1926
1927 2020-03-20  Tom Tromey  <tromey@adacore.com>
1928
1929         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
1930         const.
1931         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
1932         const.
1933
1934 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
1935
1936         * ptrace.m4: Don't check for ptrace declaration.
1937         * config.in: Re-generate.
1938         * configure: Re-generate.
1939         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
1940         not defined.
1941
1942 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1943
1944         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
1945         `PTRACE_TYPE_RET'.
1946         * i386-bsd-nat.c (gdb_ptrace): Likewise.
1947         * sparc-nat.c (gdb_ptrace): Likewise.
1948         * x86-bsd-nat.c (gdb_ptrace): Likewise.
1949
1950 2020-03-20  Tom Tromey  <tromey@adacore.com>
1951
1952         * c-exp.y (lex_one_token): Fix assert.
1953
1954 2020-03-20  Tom Tromey  <tromey@adacore.com>
1955
1956         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
1957         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
1958         strncpy call.
1959
1960 2020-03-20  Tom Tromey  <tromey@adacore.com>
1961
1962         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
1963
1964 2020-03-20  Tom Tromey  <tromey@adacore.com>
1965
1966         * ada-valprint.c (print_variant_part): Remove parameters; switch
1967         to value-based API.
1968         (print_field_values): Likewise.
1969         (ada_val_print_struct_union): Likewise.
1970         (ada_value_print_1): Update.
1971
1972 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1973
1974         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
1975         nbsd_nat_target instead of inf_ptrace_target.
1976         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1977         nbsd_nat_target.
1978
1979 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1980
1981         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
1982         it to the ptrace call.
1983         * (store_registers): Likewise.
1984
1985 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1986
1987         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
1988         it to the ptrace call.
1989         * (store_registers): Likewise.
1990
1991 2020-03-19  Luis Machado  <luis.machado@linaro.org>
1992
1993         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
1994         valid, fetch vg value from ptrace.
1995
1996 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
1997         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
1998         * inf-ptrace.c: Likewise.
1999         * (gdb_ptrace): Add.
2000         * (inf_ptrace_target::resume): Update.
2001         * (inf_ptrace_target::xfer_partial): Likewise.
2002         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2003         * (inf_ptrace_peek_poke): Update.
2004
2005 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2006
2007         * x86-bsd-nat.c (gdb_ptrace): New.
2008         * (x86bsd_dr_set): Add new argument `ptid'.
2009         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2010         x86bsd_dr_set_addr): Update.
2011
2012 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2013
2014         * remote.c (remote_target::process_stop_reply): Handle events for
2015         all threads differently.
2016
2017 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * completer.c (completion_tracker::remove_completion): Define new
2020         function.
2021         * completer.h (completion_tracker::remove_completion): Declare new
2022         function.
2023         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2024         when adding a C++ function symbol.
2025
2026 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2027
2028         * completer.c (completion_tracker::completion_hash_entry): Define
2029         new class.
2030         (advance_to_filename_complete_word_point): Call
2031         recompute_lowest_common_denominator.
2032         (completion_tracker::completion_tracker): Call discard_completions
2033         to setup the hash table.
2034         (completion_tracker::discard_completions): Allow for being called
2035         from the constructor, pass new equal function, and element deleter
2036         when constructing the hash table.  Initialise new class member
2037         variables.
2038         (completion_tracker::maybe_add_completion): Remove use of
2039         m_entries_vec, and store more information into m_entries_hash.
2040         (completion_tracker::recompute_lcd_visitor): New function, most
2041         content taken from...
2042         (completion_tracker::recompute_lowest_common_denominator):
2043         ...here, this now just visits each item in the hash calling the
2044         above visitor.
2045         (completion_tracker::build_completion_result): Remove use of
2046         m_entries_vec, call recompute_lowest_common_denominator.
2047         * completer.h (completion_tracker::have_completions): Remove use
2048         of m_entries_vec.
2049         (completion_tracker::completion_hash_entry): Declare new class.
2050         (completion_tracker::recompute_lowest_common_denominator): Change
2051         function signature.
2052         (completion_tracker::recompute_lcd_visitor): Declare new function.
2053         (completion_tracker::m_entries_vec): Delete.
2054         (completion_tracker::m_entries_hash): Initialize to NULL.
2055         (completion_tracker::m_lowest_common_denominator_valid): New
2056         member variable.
2057         (completion_tracker::m_lowest_common_denominator_max_length): New
2058         member variable.
2059
2060 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2061
2062         * regformats/regdef.h: Put reg in gdb namespace.
2063
2064 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2065
2066         * i386-bsd-nat.c (gdb_ptrace): New.
2067         * (i386bsd_fetch_inferior_registers,
2068         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2069         * (i386bsd_fetch_inferior_registers,
2070         i386bsd_store_inferior_registers) Use gdb_ptrace.
2071
2072 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2073
2074         * amd64-bsd-nat.c (gdb_ptrace): New.
2075         * (amd64bsd_fetch_inferior_registers,
2076         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2077         * (amd64bsd_fetch_inferior_registers,
2078         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2079
2080 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2081
2082         * user-regs.c (user_reg::read): Rename to...
2083         (user_reg::xread): ...this.
2084         * (append_user_reg): Rename argument `read' to `xread'.
2085         * (user_reg_add_builtin): Likewise.
2086         * (user_reg_add): Likewise.
2087         * (value_of_user_reg): Likewise.
2088
2089 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2090
2091         * sparc-nat.c (gdb_ptrace): New.
2092         * sparc-nat.c (sparc_fetch_inferior_registers)
2093         (sparc_store_inferior_registers) Remove obsolete comment.
2094         * sparc-nat.c (sparc_fetch_inferior_registers)
2095         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2096         * sparc-nat.c (sparc_fetch_inferior_registers)
2097         (sparc_store_inferior_registers) Use gdb_ptrace.
2098
2099 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2100
2101         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2102         it to the ptrace call.
2103         * sh-nbsd-nat.c (store_registers): Likewise.
2104
2105 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2106
2107         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2108         nbsd_nat_target instead of inf_ptrace_target.
2109         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2110         nbsd_nat_target.
2111
2112 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2113
2114         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2115
2116 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2117
2118         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2119         <sys/sysctl.h>.
2120         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2121
2122 2020-03-17  Tom de Vries  <tdevries@suse.de>
2123
2124         PR gdb/23710
2125         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2126         fields.
2127         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2128         fields.
2129         (process_imported_unit_die): Skip import of c++ CUs.
2130
2131 2020-03-16  Tom Tromey  <tom@tromey.com>
2132
2133         * p-valprint.c (pascal_object_print_value): Initialize
2134         base_value.
2135
2136 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2137             Shahab Vahedi  <shahab@synopsys.com>
2138
2139         * Makefile.in: Add arch/arc.o
2140         * configure.tgt: Likewise.
2141         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2142         (_initialize_arc_tdep): Don't initialize old target descriptions.
2143         (arc_read_description): New function to cache target descriptions.
2144         * arc-tdep.h (arc_read_description): Add proto type.
2145         * arch/arc.c: New file.
2146         * arch/arc.h: Likewise.
2147         * features/Makefile: Replace old target descriptions with new.
2148         * features/arc-arcompact.c: Remove.
2149         * features/arc-arcompact.xml: Likewise.
2150         * features/arc-v2.c: Likewise
2151         * features/arc-v2.xml: Likewise
2152         * features/arc/aux-arcompact.xml: New file.
2153         * features/arc/aux-v2.xml: Likewise.
2154         * features/arc/core-arcompact.xml: Likewise.
2155         * features/arc/core-v2.xml: Likewise.
2156         * features/arc/aux-arcompact.c: Generate.
2157         * features/arc/aux-v2.c: Likewise.
2158         * features/arc/core-arcompact.c: Likewise.
2159         * features/arc/core-v2.c: Likewise.
2160         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2161
2162 2020-03-16  Tom Tromey  <tromey@adacore.com>
2163
2164         PR gdb/25663:
2165         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2166         putting value into bcache.
2167
2168 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2169
2170         PR gdb/21500
2171         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2172         to...
2173         (amd64_windows_init_abi_common): ... this.  Don't set size of
2174         long type.
2175         (amd64_windows_init_abi): New function.
2176         (amd64_cygwin_init_abi): New function.
2177         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2178         the Cygwin OS ABI.
2179         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2180         comment.
2181
2182 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2183
2184         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2185         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2186         (pe_import_directory_entry): New struct type.
2187         (is_linked_with_cygwin_dll): New function.
2188         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2189         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2190         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2191
2192 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2193
2194         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2195         i386_cygwin_core_osabi_sniffer.
2196
2197 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2198
2199         * i386-cygwin-tdep.c: Rename to...
2200         * i386-windows-tdep.c: ... this.
2201         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2202         i386-windows-tdep.c.
2203         * configure.tgt: Likewise.
2204
2205 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2206
2207         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2208         * osabi.c (gdb_osabi_names): Add "Windows".
2209         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2210         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2211         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2212         i386_cygwin_osabi_sniffer.
2213         (_initialize_i386_cygwin_tdep): Register OS ABI
2214         GDB_OSABI_WINDOWS for i386.
2215         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2216         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2217         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2218         for x86-64.
2219         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2220         when the target matches '*-*-mingw*'.
2221
2222 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2223
2224         * defs.h (enum gdb_osabi): Move to...
2225         * osabi.h (enum gdb_osabi): ... here.
2226         * gdbarch.sh: Include osabi.h in gdbarch.h.
2227         * gdbarch.h: Re-generate.
2228
2229 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2230
2231         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2232         function.
2233         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2234
2235 2020-03-14  Tom Tromey  <tom@tromey.com>
2236
2237         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2238         for C++.
2239         (c_type_print_modifier): Likewise.  Add "language" parameter.
2240         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2241         (c_type_print_base_1): Update.
2242         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2243         constants.
2244         * type-stack.c (type_stack::insert): Handle tp_atomic and
2245         tp_restrict.
2246         (type_stack::follow_type_instance_flags): Likewise.
2247         (type_stack::follow_types): Likewise.  Merge type-following code.
2248         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2249         (space_identifier, cv_with_space_id)
2250         (const_or_volatile_or_space_identifier_noopt)
2251         (const_or_volatile_or_space_identifier): Remove.
2252         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2253         rules.
2254         (ptr_operator, typebase): Update.
2255         (enum token_flag) <FLAG_C>: New constant.
2256         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2257         "_Atomic".
2258         (lex_one_token): Handle FLAG_C.
2259
2260 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2261
2262         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2263         it to the ptrace call.
2264         * m68k-bsd-nat.c (store_registers): Likewise.
2265
2266 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2267
2268         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2269         gdb_byte *.
2270         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2271         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2272         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2273
2274 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2275
2276         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2277         nbsd_nat_target instead of inf_ptrace_target.
2278         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2279         nbsd_nat_target.
2280
2281 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2282
2283         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2284         register_t.
2285
2286 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2287
2288         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2289         it to the ptrace call.
2290         * alpha-bsd-nat.c (store_registers): Likewise.
2291
2292 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2293
2294         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2295         includes.
2296         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2297         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2298         fill_fpregset): Likewise.
2299
2300 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2301
2302         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2303         nbsd_nat_target instead of inf_ptrace_target.
2304         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2305         nbsd_nat_target.
2306
2307 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2308
2309         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2310         register_t.
2311
2312 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2313
2314         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2315         it to the ptrace call.
2316         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2317         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2318         * arm-nbsd-nat.c (store_register): Likewise.
2319         * arm-nbsd-nat.c (store_regs): Likewise.
2320         * arm-nbsd-nat.c (store_fp_register): Likewise.
2321         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2322
2323 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2324
2325         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2326         nbsd_nat_target instead of inf_ptrace_target.
2327         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2328         nbsd_nat_target.
2329
2330 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2331
2332         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2333         it to the ptrace call.
2334         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2335
2336 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2337
2338         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2339         it to the ptrace call.
2340         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2341
2342 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2343
2344         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2345         gdb_byte *.
2346         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2347
2348 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2349
2350         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2351         instead of inf_ptrace_target.
2352         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2353         nbsd_nat_target.
2354
2355 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2356
2357         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2358         register_t.
2359
2360 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2361
2362         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2363         register_t.
2364
2365 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2366
2367         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2368         register_t.
2369
2370 2020-03-13  Tom Tromey  <tom@tromey.com>
2371
2372         * value.h (val_print): Don't declare.
2373         * valprint.h (val_print_array_elements)
2374         (val_print_scalar_formatted, generic_val_print): Don't declare.
2375         * valprint.c (generic_val_print_array): Take a struct value.
2376         (generic_val_print_ptr, generic_val_print_memberptr)
2377         (generic_val_print_bool, generic_val_print_int)
2378         (generic_val_print_char, generic_val_print_complex)
2379         (generic_val_print): Remove.
2380         (generic_value_print): Update.
2381         (do_val_print): Remove unused parameters.  Don't call
2382         la_val_print.
2383         (val_print): Remove.
2384         (common_val_print): Update.  Don't call value_check_printable.
2385         (val_print_scalar_formatted, val_print_array_elements): Remove.
2386         * rust-lang.c (rust_val_print): Remove.
2387         (rust_language_defn): Update.
2388         * p-valprint.c (pascal_val_print): Remove.
2389         (pascal_value_print_inner): Update.
2390         (pascal_object_print_val_fields, pascal_object_print_val):
2391         Remove.
2392         (pascal_object_print_static_field): Update.
2393         * p-lang.h (pascal_val_print): Don't declare.
2394         * p-lang.c (pascal_language_defn): Update.
2395         * opencl-lang.c (opencl_language_defn): Update.
2396         * objc-lang.c (objc_language_defn): Update.
2397         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2398         * m2-lang.h (m2_val_print): Don't declare.
2399         * m2-lang.c (m2_language_defn): Update.
2400         * language.h (struct language_defn) <la_val_print>: Remove.
2401         * language.c (unk_lang_value_print_inner): Rename.  Change
2402         argument types.
2403         (unknown_language_defn, auto_language_defn): Update.
2404         * go-valprint.c (go_val_print): Remove.
2405         * go-lang.h (go_val_print): Don't declare.
2406         * go-lang.c (go_language_defn): Update.
2407         * f-valprint.c (f_val_print): Remove.
2408         * f-lang.h (f_value_print): Don't declare.
2409         * f-lang.c (f_language_defn): Update.
2410         * d-valprint.c (d_val_print): Remove.
2411         * d-lang.h (d_value_print): Don't declare.
2412         * d-lang.c (d_language_defn): Update.
2413         * cp-valprint.c (cp_print_value_fields)
2414         (cp_print_value_fields_rtti, cp_print_value): Remove.
2415         (cp_print_static_field): Update.
2416         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2417         (c_val_print_struct, c_val_print_union, c_val_print_int)
2418         (c_val_print_memberptr, c_val_print): Remove.
2419         * c-lang.h (c_val_print_array, cp_print_value_fields)
2420         (cp_print_value_fields_rtti): Don't declare.
2421         * c-lang.c (c_language_defn, cplus_language_defn)
2422         (asm_language_defn, minimal_language_defn): Update.
2423         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2424         (ada_val_print_enum): Take a struct value.
2425         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2426         (ada_val_print): Remove.
2427         (ada_value_print_1): Update.
2428         (printable_val_type): Remove.
2429         * ada-lang.h (ada_val_print): Don't declare.
2430         * ada-lang.c (ada_language_defn): Update.
2431
2432 2020-03-13  Tom Tromey  <tom@tromey.com>
2433
2434         * valprint.c (do_val_print): Update.
2435         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2436         a struct value.
2437         (value_to_value_object_no_release): Declare.
2438         * python/py-value.c (value_to_value_object_no_release): New
2439         function.
2440         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2441         struct value.
2442         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2443         function.
2444         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2445         a struct value.
2446         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2447         Declare.
2448         (gdbscm_apply_val_pretty_printer): Take a struct value.
2449         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2450         value.
2451         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2452         value.
2453         * extension-priv.h (struct extension_language_ops)
2454         <apply_val_pretty_printer>: Take a struct value.
2455         * cp-valprint.c (cp_print_value): Create a struct value.
2456         (cp_print_value): Update.
2457
2458 2020-03-13  Tom Tromey  <tom@tromey.com>
2459
2460         * ada-valprint.c (print_field_values): Call common_val_print.
2461
2462 2020-03-13  Tom Tromey  <tom@tromey.com>
2463
2464         * ada-valprint.c (val_print_packed_array_elements): Remove
2465         bitoffset and val parameters.  Call common_val_print.
2466         (ada_val_print_string): Remove offset, address, and original_value
2467         parameters.
2468         (ada_val_print_array): Update.
2469         (ada_value_print_array): New function.
2470         (ada_value_print_1): Call it.
2471
2472 2020-03-13  Tom Tromey  <tom@tromey.com>
2473
2474         * ada-valprint.c (ada_value_print): Use common_val_print.
2475
2476 2020-03-13  Tom Tromey  <tom@tromey.com>
2477
2478         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2479
2480 2020-03-13  Tom Tromey  <tom@tromey.com>
2481
2482         * ada-valprint.c (ada_value_print_num): New function.
2483         (ada_value_print_1): Use it.
2484
2485 2020-03-13  Tom Tromey  <tom@tromey.com>
2486
2487         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2488
2489 2020-03-13  Tom Tromey  <tom@tromey.com>
2490
2491         * ada-valprint.c (ada_value_print_ptr): New function.
2492         (ada_value_print_1): Use it.
2493
2494 2020-03-13  Tom Tromey  <tom@tromey.com>
2495
2496         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2497         call common_val_print.
2498         (ada_val_print_1): Update.
2499         (ada_value_print_1): New function.
2500         (ada_value_print_inner): Rewrite.
2501
2502 2020-03-13  Tom Tromey  <tom@tromey.com>
2503
2504         * cp-valprint.c (cp_print_value_fields): Update.
2505         (cp_print_value): New function.
2506
2507 2020-03-13  Tom Tromey  <tom@tromey.com>
2508
2509         * m2-valprint.c (m2_value_print_inner): Use
2510         cp_print_value_fields.
2511         * cp-valprint.c (cp_print_value_fields): New function.
2512         * c-valprint.c (c_value_print_struct): New function.
2513         (c_value_print_inner): Use c_value_print_struct.
2514         * c-lang.h (cp_print_value_fields): Declare.
2515
2516 2020-03-13  Tom Tromey  <tom@tromey.com>
2517
2518         * c-valprint.c (c_value_print_array): New function.
2519         (c_value_print_inner): Use it.
2520
2521 2020-03-13  Tom Tromey  <tom@tromey.com>
2522
2523         * c-valprint.c (c_value_print_memberptr): New function.
2524         (c_value_print_inner): Use it.
2525
2526 2020-03-13  Tom Tromey  <tom@tromey.com>
2527
2528         * c-valprint.c (c_value_print_int): New function.
2529         (c_value_print_inner): Use it.
2530
2531 2020-03-13  Tom Tromey  <tom@tromey.com>
2532
2533         * c-valprint.c (c_value_print_ptr): New function.
2534         (c_value_print_inner): Use it.
2535
2536 2020-03-13  Tom Tromey  <tom@tromey.com>
2537
2538         * c-valprint.c (c_value_print_inner): Rewrite.
2539
2540 2020-03-13  Tom Tromey  <tom@tromey.com>
2541
2542         * valprint.c (generic_value_print_complex): New function.
2543         (generic_value_print): Use it.
2544
2545 2020-03-13  Tom Tromey  <tom@tromey.com>
2546
2547         * valprint.c (generic_val_print_float): Don't call
2548         val_print_scalar_formatted.
2549         (generic_val_print, generic_value_print): Update.
2550
2551 2020-03-13  Tom Tromey  <tom@tromey.com>
2552
2553         * valprint.c (generic_value_print_char): New function
2554         (generic_value_print): Use it.
2555
2556 2020-03-13  Tom Tromey  <tom@tromey.com>
2557
2558         * valprint.c (generic_value_print_int): New function.
2559         (generic_value_print): Use it.
2560
2561 2020-03-13  Tom Tromey  <tom@tromey.com>
2562
2563         * valprint.c (generic_value_print_bool): New function.
2564         (generic_value_print): Use it.
2565
2566 2020-03-13  Tom Tromey  <tom@tromey.com>
2567
2568         * valprint.c (generic_val_print_func): Simplify.
2569         (generic_val_print, generic_value_print): Update.
2570
2571 2020-03-13  Tom Tromey  <tom@tromey.com>
2572
2573         * valprint.c (generic_val_print_flags): Remove.
2574         (generic_val_print, generic_value_print): Update.
2575         (val_print_type_code_flags): Add original_value parameter.
2576
2577 2020-03-13  Tom Tromey  <tom@tromey.com>
2578
2579         * valprint.c (generic_val_print): Update.
2580         (generic_value_print): Update.
2581         * valprint.c (generic_val_print_enum): Don't call
2582         val_print_scalar_formatted.
2583
2584 2020-03-13  Tom Tromey  <tom@tromey.com>
2585
2586         * valprint.c (generic_value_print): Call generic_value_print_ptr.
2587         * valprint.c (generic_value_print_ptr): New function.
2588
2589 2020-03-13  Tom Tromey  <tom@tromey.com>
2590
2591         * valprint.c (generic_value_print): Rewrite.
2592
2593 2020-03-13  Tom Tromey  <tom@tromey.com>
2594
2595         * p-valprint.c (pascal_object_print_value_fields)
2596         (pascal_object_print_value): New functions.
2597
2598 2020-03-13  Tom Tromey  <tom@tromey.com>
2599
2600         * p-valprint.c (pascal_value_print_inner): Rewrite.
2601
2602 2020-03-13  Tom Tromey  <tom@tromey.com>
2603
2604         * f-valprint.c (f_value_print_innner): Rewrite.
2605
2606 2020-03-13  Tom Tromey  <tom@tromey.com>
2607
2608         * m2-valprint.c (m2_print_unbounded_array): New overload.
2609         (m2_print_unbounded_array): Update.
2610         (m2_print_array_contents): Take a struct value.
2611         (m2_value_print_inner): Rewrite.
2612
2613 2020-03-13  Tom Tromey  <tom@tromey.com>
2614
2615         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
2616         (d_value_print_inner): New function.
2617         * d-lang.h (d_value_print_inner): Declare.
2618         * d-lang.c (d_language_defn): Use d_value_print_inner.
2619
2620 2020-03-13  Tom Tromey  <tom@tromey.com>
2621
2622         * go-valprint.c (go_value_print_inner): New function.
2623         * go-lang.h (go_value_print_inner): Declare.
2624         * go-lang.c (go_language_defn): Use go_value_print_inner.
2625
2626 2020-03-13  Tom Tromey  <tom@tromey.com>
2627
2628         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
2629         API.
2630         (rust_val_print): Rewrite.
2631         (rust_value_print_inner): New function, from rust_val_print.
2632         (rust_language_defn): Use rust_value_print_inner.
2633
2634 2020-03-13  Tom Tromey  <tom@tromey.com>
2635
2636         * ada-valprint.c (ada_value_print_inner): New function.
2637         * ada-lang.h (ada_value_print_inner): Declare.
2638         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
2639
2640 2020-03-13  Tom Tromey  <tom@tromey.com>
2641
2642         * f-valprint.c (f_value_print_innner): New function.
2643         * f-lang.h (f_value_print_innner): Declare.
2644         * f-lang.c (f_language_defn): Use f_value_print_innner.
2645
2646 2020-03-13  Tom Tromey  <tom@tromey.com>
2647
2648         * p-valprint.c (pascal_value_print_inner): New function.
2649         * p-lang.h (pascal_value_print_inner): Declare.
2650         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
2651
2652 2020-03-13  Tom Tromey  <tom@tromey.com>
2653
2654         * m2-valprint.c (m2_value_print_inner): New function.
2655         * m2-lang.h (m2_value_print_inner): Declare.
2656         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
2657
2658 2020-03-13  Tom Tromey  <tom@tromey.com>
2659
2660         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
2661         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
2662         * c-valprint.c (c_value_print_inner): New function.
2663         * c-lang.h (c_value_print_inner): Declare.
2664         * c-lang.c (c_language_defn, cplus_language_defn)
2665         (asm_language_defn, minimal_language_defn): Use
2666         c_value_print_inner.
2667
2668 2020-03-13  Tom Tromey  <tom@tromey.com>
2669
2670         * p-valprint.c (pascal_object_print_value_fields): Now static.
2671         * p-lang.h (pascal_object_print_value_fields): Don't declare.
2672
2673 2020-03-13  Tom Tromey  <tom@tromey.com>
2674
2675         * c-valprint.c (c_val_print_array): Simplify.
2676
2677 2020-03-13  Tom Tromey  <tom@tromey.com>
2678
2679         * valprint.c (value_print_array_elements): New function.
2680         * valprint.h (value_print_array_elements): Declare.
2681
2682 2020-03-13  Tom Tromey  <tom@tromey.com>
2683
2684         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
2685         * mips-tdep.c (mips_print_register): Use
2686         value_print_scalar_formatted.
2687
2688 2020-03-13  Tom Tromey  <tom@tromey.com>
2689
2690         * valprint.h (value_print_scalar_formatted): Declare.
2691         * valprint.c (value_print_scalar_formatted): New function.
2692
2693 2020-03-13  Tom Tromey  <tom@tromey.com>
2694
2695         * valprint.h (generic_value_print): Declare.
2696         * valprint.c (generic_value_print): New function.
2697
2698 2020-03-13  Tom Tromey  <tom@tromey.com>
2699
2700         * valprint.c (do_val_print): Call la_value_print_inner, if
2701         available.
2702         * rust-lang.c (rust_language_defn): Update.
2703         * p-lang.c (pascal_language_defn): Update.
2704         * opencl-lang.c (opencl_language_defn): Update.
2705         * objc-lang.c (objc_language_defn): Update.
2706         * m2-lang.c (m2_language_defn): Update.
2707         * language.h (struct language_defn) <la_value_print_inner>: New
2708         member.
2709         * language.c (unknown_language_defn, auto_language_defn): Update.
2710         * go-lang.c (go_language_defn): Update.
2711         * f-lang.c (f_language_defn): Update.
2712         * d-lang.c (d_language_defn): Update.
2713         * c-lang.c (c_language_defn, cplus_language_defn)
2714         (asm_language_defn, minimal_language_defn): Update.
2715         * ada-lang.c (ada_language_defn): Update.
2716
2717 2020-03-13  Tom Tromey  <tom@tromey.com>
2718
2719         * c-valprint.c (c_value_print): Use common_val_print.
2720
2721 2020-03-13  Tom Tromey  <tom@tromey.com>
2722
2723         * cp-valprint.c (cp_print_static_field): Use common_val_print.
2724
2725 2020-03-13  Tom Tromey  <tom@tromey.com>
2726
2727         * f-valprint.c (f77_print_array_1, f_val_print): Use
2728         common_val_print.
2729
2730 2020-03-13  Tom Tromey  <tom@tromey.com>
2731
2732         * riscv-tdep.c (riscv_print_one_register_info): Use
2733         common_val_print.
2734
2735 2020-03-13  Tom Tromey  <tom@tromey.com>
2736
2737         * mi/mi-main.c (output_register): Use common_val_print.
2738
2739 2020-03-13  Tom Tromey  <tom@tromey.com>
2740
2741         * infcmd.c (default_print_one_register_info): Use
2742         common_val_print.
2743
2744 2020-03-13  Tom Tromey  <tom@tromey.com>
2745
2746         * valprint.h (common_val_print_checked): Declare.
2747         * valprint.c (common_val_print_checked): New function.
2748         * stack.c (print_frame_arg): Use common_val_print_checked.
2749
2750 2020-03-13  Tom Tromey  <tom@tromey.com>
2751
2752         * valprint.c (do_val_print): New function, from val_print.
2753         (val_print): Use do_val_print.
2754         (common_val_print): Use do_val_print.
2755
2756 2020-03-13  Tom Tromey  <tom@tromey.com>
2757
2758         * valprint.c (value_print): Use scoped_value_mark.
2759
2760 2020-03-13  Tom de Vries  <tdevries@suse.de>
2761
2762         PR symtab/25646
2763         * psymtab.c (partial_symtab::partial_symtab): Don't set
2764         globals_offset and statics_offset.  Push element onto
2765         current_global_psymbols and current_static_psymbols stacks.
2766         (concat): New function.
2767         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
2768         element from current_global_psymbols and current_static_psymbols
2769         stacks.  Concat popped elements to global_psymbols and
2770         static_symbols.
2771         (add_psymbol_to_list): Use current_global_psymbols and
2772         current_static_psymbols stacks.
2773         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
2774         current_static_psymbols fields.
2775
2776 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2777
2778         * corelow.c (sniff_core_bfd): Remove.
2779         (class core_target) <m_core_vec>: Remove.
2780         (core_target::core_target): Update.
2781         (core_file_fns): Remove.
2782         (deprecated_add_core_fns): Remove.
2783         (default_core_sniffer): Remove.
2784         (sniff_core_bfd): Remove.
2785         (default_check_format): Remove.
2786         (gdb_check_format): Remove.
2787         (core_target_open): Update.
2788         (core_target::get_core_register_section): Update.
2789         (get_core_registers_cb): Update.
2790         (core_target::fetch_registers): Update.
2791         * gdbcore.h (struct core_fns): Remove.
2792         (deprecated_add_core_fns): Remove.
2793         (default_core_sniffer): Remove.
2794         (default_check_format): Remove.
2795
2796 2020-03-12  Tom Tromey  <tom@tromey.com>
2797
2798         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
2799         CORE_ADDR.
2800         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
2801
2802 2020-03-12  Tom Tromey  <tom@tromey.com>
2803
2804         * remote.c (remote_target::download_tracepoint)
2805         (remote_target::enable_tracepoint)
2806         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
2807         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
2808         sprintf_vma.
2809
2810 2020-03-12  Tom Tromey  <tom@tromey.com>
2811
2812         * symfile-mem.c: Update CORE_ADDR size assert.
2813
2814 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2815
2816         * selftest.m4: Move to gdbsupport/.
2817         * acinclude.m4: Update path to selftest.m4.
2818
2819 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2820
2821         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
2822         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
2823         gdbarch-selfselftests.c and selftest-arch.c.
2824         (SUBDIR_UNITTESTS_OBS): Rename to...
2825         (SELFTESTS_OBS): ... this.
2826         (COMMON_SFILES): Remove disasm-selftests.c and
2827         gdbarch-selftests.c.
2828         * configure.ac: Don't add selftest-arch.{c,o} to
2829         CONFIG_{SRCS,OBS}.
2830         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
2831         preprocessor conditions.
2832
2833 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2834
2835         * configure.ac: Don't source bfd/development.sh.
2836         * selftest.m4: Modify comment.
2837         * configure: Re-generate.
2838
2839 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
2840
2841         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
2842         not "true" or "false".
2843         * configure: Re-generate.
2844
2845 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2846
2847         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
2848         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
2849         renamed to arm_nbsd_supply_gregset.
2850         (fetch_register): Update to call arm_nbsd_supply_gregset.
2851         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
2852         (arm_netbsd_nat_target::fetch_registers): Update.
2853         (fetch_elfcore_registers): Removed.
2854         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
2855         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
2856         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
2857         not require NetBSD system headers.
2858         (arm_nbsd_regset): New struct.
2859         (arm_nbsd_iterate_over_regset_sections): New function.
2860         (arm_netbsd_init_abi_common): Updated to call
2861         set_gdbarch_iterate_over_regset_sections.
2862         * arm-nbsd-tdep.h: New file.
2863
2864 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
2865
2866         * symtab.c (find_pc_sect_line): Add check which prevents infinite
2867         recursion.
2868
2869 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
2870
2871         * configure: Re-generate.
2872
2873 2020-03-11  Tom Tromey  <tromey@adacore.com>
2874
2875         * ada-typeprint.c (print_choices): Fix comment.
2876
2877 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
2880         previous item in the list, when the list has no items.
2881
2882 2020-03-11  Tom de Vries  <tdevries@suse.de>
2883
2884         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
2885         PROP_LOCLIST handling code.
2886
2887 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2888
2889         * buildsym-legacy.c (record_line): Pass extra parameter to
2890         record_line.
2891         * buildsym.c (buildsym_compunit::record_line): Take an extra
2892         parameter, reduce duplication in the line table, and record the
2893         is_stmt flag in the line table.
2894         * buildsym.h (buildsym_compunit::record_line): Add extra
2895         parameter.
2896         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
2897         non-statement lines.
2898         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
2899         this to the symtab builder.
2900         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
2901         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
2902         through to dwarf_record_line_1.
2903         * infrun.c (process_event_stop_test): When stepping, don't stop at
2904         a non-statement instruction, and only refresh the step info when
2905         we land in the middle of a line's range.  Also add an extra
2906         comment.
2907         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
2908         field.
2909         * record-btrace.c (btrace_find_line_range): Only record lines
2910         marked as is-statement.
2911         * stack.c (frame_show_address): Show the frame address if we are
2912         in a non-statement sal.
2913         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
2914         (maintenance_print_one_line_table): Print a header for the is_stmt
2915         column, and include is_stmt information in the output.
2916         * symtab.c (find_pc_sect_line): Find lines marked as statements in
2917         preference to non-statements.
2918         (find_pcs_for_symtab_line): Prefer is-statement entries.
2919         (find_line_common): Likewise.
2920         * symtab.h (struct linetable_entry): Add is_stmt field.
2921         (struct symtab_and_line): Likewise.
2922         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
2923         arranging the line table.
2924
2925 2020-03-07  Tom de Vries  <tdevries@suse.de>
2926
2927         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
2928         DIE.
2929
2930 2020-03-07  Tom Tromey  <tom@tromey.com>
2931
2932         * valops.c (value_literal_complex): Remove obsolete comment.
2933         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
2934         comment.
2935
2936 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
2937
2938         * infrun.h: Forward-declare thread_info.
2939         (set_step_info): Add thread_info parameter, add doc.
2940         * infrun.c (set_step_info): Add thread_info parameter, move doc
2941         to header.
2942         * infrun.c (process_event_stop_test): Pass thread to
2943         set_step_info call.
2944         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
2945         set_step_info.
2946         (prepare_one_step): Add thread_info parameter, pass it to
2947         set_step_frame and prepare_one_step (recursive) call.
2948         (step_1): Pass thread to prepare_one_step call.
2949         (step_command_fsm::should_stop): Pass thread to
2950         prepare_one_step.
2951         (until_next_fsm): Pass thread to set_step_frame call.
2952         (finish_command): Pass thread to set_step_info call.
2953
2954 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
2955
2956         * windows-tdep.c (windows_solib_create_inferior_hook):
2957         Check if inferior is running.
2958
2959 2020-03-06  Tom de Vries  <tdevries@suse.de>
2960
2961         * NEWS: Fix "the the".
2962         * ctfread.c: Same.
2963
2964 2020-03-06  Tom de Vries  <tdevries@suse.de>
2965
2966         * psymtab.c (psymtab_to_symtab): Don't print "done.".
2967
2968 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2969
2970         * .dir-locals.el: Add a comment referencing the other copies of
2971         this file.
2972
2973 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
2974
2975         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
2976         psargs.
2977
2978 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2979
2980         * .gitattributes: New file.
2981
2982 2020-03-04  Tom Tromey  <tom@tromey.com>
2983
2984         * symmisc.c (print_symbol_bcache_statistics)
2985         (print_objfile_statistics): Update.
2986         * symfile.c (allocate_symtab): Use intern.
2987         * psymtab.c (partial_symtab::partial_symtab): Use intern.
2988         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2989         macro_cache>: Remove.
2990         <string_cache>: New member.
2991         (struct objfile) <intern>: New methods.
2992         * elfread.c (elf_symtab_read): Use intern.
2993         * dwarf2/read.c (fixup_go_packaging): Intern package name.
2994         (dwarf2_compute_name, dwarf2_physname)
2995         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
2996         names.
2997         (guess_partial_die_structure_name): Update.
2998         (partial_die_info::fixup): Intern name.
2999         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3000         name.
3001         (dwarf2_name): Intern name.  Update.
3002         * buildsym.c (buildsym_compunit::get_macro_table): Use
3003         string_cache.
3004
3005 2020-03-04  Tom Tromey  <tom@tromey.com>
3006
3007         * jit.c (bfd_open_from_target_memory): Make "target" const.
3008         * corefile.c (gnutarget): Now const.
3009         * gdbcore.h (gnutarget): Now const.
3010
3011 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3012
3013         * NEWS: Mention support for WOW64 processes.
3014         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3015         (amd64_windows_segment_register_p): Remove static.
3016         (_initialize_amd64_windows_nat): Update.
3017         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3018         * i386-windows-nat.c (context_offset): Update.
3019         (i386_mappings): Rename and remove static.
3020         (i386_windows_segment_register_p): Remove static.
3021         (_initialize_i386_windows_nat): Update.
3022         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3023         (STATUS_WX86_SINGLE_STEP): New macro.
3024         (EnumProcessModulesEx): New macro.
3025         (Wow64SuspendThread): New macro.
3026         (Wow64GetThreadContext): New macro.
3027         (Wow64SetThreadContext): New macro.
3028         (Wow64GetThreadSelectorEntry): New macro.
3029         (windows_set_context_register_offsets): Add static.
3030         (windows_set_segment_register_p): Likewise.
3031         (windows_add_thread): Adapt for WOW64 processes.
3032         (windows_fetch_one_register): Likewise.
3033         (windows_nat_target::fetch_registers): Likewise.
3034         (windows_store_one_register): Likewise.
3035         (display_selector): Likewise.
3036         (display_selectors): Likewise.
3037         (handle_exception): Likewise.
3038         (windows_continue): Likewise.
3039         (windows_nat_target::resume): Likewise.
3040         (windows_add_all_dlls): Likewise.
3041         (do_initial_windows_stuff): Likewise.
3042         (windows_nat_target::attach): Likewise.
3043         (windows_get_exec_module_filename): Likewise.
3044         (windows_nat_target::create_inferior): Likewise.
3045         (windows_xfer_siginfo): Likewise.
3046         (_initialize_loadable): Initialize Wow64SuspendThread,
3047         Wow64GetThreadContext, Wow64SetThreadContext,
3048         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3049         * windows-nat.h (windows_set_context_register_offsets):
3050         Remove declaration.
3051         (windows_set_segment_register_p): Likewise.
3052         (i386_windows_segment_register_p): Add declaration.
3053         (amd64_windows_segment_register_p): Likewise.
3054
3055 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3056
3057         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3058         in "info registers" for AArch64/ARM.
3059
3060         The change caused "info registers" to not print GPR's.
3061
3062         gdb/ChangeLog:
3063
3064         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3065
3066         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3067         when reg->group is empty and reggroup is not.
3068
3069 2020-03-03  Tom Tromey  <tromey@adacore.com>
3070
3071         * dwarf2/frame.c (struct dwarf2_frame_cache)
3072         <checked_tailcall_bottom, entry_cfa_sp_offset,
3073         entry_cfa_sp_offset_p>: Remove members.
3074         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3075         (dwarf2_frame_prev_register): Don't call
3076         dwarf2_tailcall_sniffer_first.
3077         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3078         * frame-unwind.c (add_unwinder): New fuction.
3079         (frame_unwind_init): Use it.  Add tailcall unwinder.
3080
3081 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3082             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3083
3084         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3085         value should be printed as true.
3086
3087 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3088
3089         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3090         (windows_init_abi): Set and use windows_so_ops.
3091
3092 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3093
3094         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3095         when verifying if dealing with a convenience variable.
3096
3097 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3098
3099         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3100
3101 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3102
3103         * infrun.c (gdbarch_supports_displaced_stepping): New.
3104         (use_displaced_stepping): Break up conditions in smaller pieces.
3105         Use gdbarch_supports_displaced_stepping.
3106         (displaced_step_prepare_throw): Use
3107         gdbarch_supports_displaced_stepping.
3108
3109 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * NEWS: Mention new behaviour of the history filename.
3112         * top.c (write_history_p): Add comment.
3113         (show_write_history_p): Add header comment, give a different
3114         message when history writing is on, but the history filename is
3115         empty.
3116         (history_filename): Add comment.
3117         (history_filename_empty): New function.
3118         (show_history_filename): Add header comment, give a different
3119         message when the filename is empty.
3120         (init_history): Compare history_filename against nullptr, and only
3121         read history if the filename is not empty.
3122         (set_history_filename): Add header comment, and only make
3123         non-empty filenames absolute.
3124         (init_main): Make the filename argument to 'set history filename'
3125         optional.
3126
3127 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3128
3129         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3130         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3131         (fetch_fp_register): Update.
3132         (fetch_fp_regs): Update.
3133         (store_fp_register): Update.
3134         (store_fp_regs): Update.
3135         (arm_netbsd_nat_target::read_description): New function.
3136         (fetch_elfcore_registers): Update.
3137
3138 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3139
3140         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3141         general_thread if the stop reply is missing a thread-id.
3142         (remote_target::process_stop_reply): Use the first non-exited
3143         thread if the target didn't pass a thread-id.
3144         * infrun.c (do_target_wait): Move call to
3145         switch_to_inferior_no_thread to ....
3146         (do_target_wait_1): ... here.
3147
3148 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3149
3150         * debuginfod-support.c: Include defs.h first.
3151
3152 2020-02-28  Tom de Vries  <tdevries@suse.de>
3153
3154         * symfile.c (set_initial_language): Use default language for lookup.
3155
3156 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3157
3158         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3159         reader variable, pass `this` to read_cutu_die_from_dwo.
3160
3161 2020-02-27  Aaron Merey  <amerey@redhat.com>
3162
3163         * source.c (open_source_file): Check for nullptr when computing
3164         srcpath.
3165
3166 2020-02-27  Tom Tromey  <tromey@adacore.com>
3167
3168         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3169         member.
3170         (dwarf2_add_field): Don't update nfields.
3171         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3172
3173 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3176         abs.
3177
3178 2020-02-26  Tom Tromey  <tom@tromey.com>
3179
3180         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3181         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3182         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3183         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3184         per_cu_data.
3185
3186 2020-02-26  Tom Tromey  <tom@tromey.com>
3187
3188         * dwarf2/index-write.c (psym_index_map): Change type.
3189         (add_address_entry_worker, write_one_signatured_type)
3190         (recursively_count_psymbols, recursively_write_psymbols)
3191         (class debug_names, psyms_seen_size, write_gdbindex)
3192         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3193
3194 2020-02-26  Aaron Merey  <amerey@redhat.com>
3195
3196         * Makefile.in: Handle optional debuginfod support.
3197         * NEWS: Update.
3198         * README: Add --with-debuginfod summary.
3199         * config.in: Regenerate.
3200         * configure: Regenerate.
3201         * configure.ac: Handle optional debuginfod support.
3202         * debuginfod-support.c: debuginfod helper functions.
3203         * debuginfod-support.h: Ditto.
3204         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3205         summary.
3206         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3207         when a dwz file cannot be found.
3208         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3209         debuginfo file cannot be found.
3210         * source.c (open_source_file): Query debuginfod servers when a
3211         source file cannot be found.
3212         * top.c (print_gdb_configuration): Include
3213         --{with,without}-debuginfod in the output.
3214
3215 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3216
3217         * thread.c (thr_try_catch_cmd): Print thread name.
3218
3219 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3220
3221         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3222         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3223         dwarf2_fetch_die_type_sect_off): Move to...
3224         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3225         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3226         dwarf2_fetch_die_type_sect_off): ... here.
3227         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3228         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3229         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3230
3231 2020-02-26  Tom de Vries  <tdevries@suse.de>
3232
3233         PR gdb/25603
3234         * symfile.c (set_initial_language): Exit-early if
3235         language_mode == language_mode_manual.
3236
3237 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3238
3239         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3240         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3241         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3242
3243 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3244
3245         * gdbtypes.c (create_array_type_with_stride): Handle negative
3246         array strides.
3247         * valarith.c (value_subscripted_rvalue): Likewise.
3248
3249 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3250
3251         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3252
3253 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3254
3255         * loc.h (dwarf2_get_die_type): Move to...
3256         * read.h (dwarf2_get_die_type): ... here.
3257         * read.c (dwarf2_get_die_type): Move doc to header.
3258
3259 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3260
3261         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3262         'gnulib/Makefile.in' to the list.
3263
3264 2020-02-24  Tom Tromey  <tom@tromey.com>
3265
3266         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3267         Remove.
3268         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3269         XOBNEWVEC.
3270
3271 2020-02-24  Tom Tromey  <tom@tromey.com>
3272
3273         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3274         New method.
3275         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3276         (dw2_do_instantiate_symtab, dw2_get_file_names)
3277         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3278
3279 2020-02-24  Tom Tromey  <tom@tromey.com>
3280
3281         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3282         make_scoped_restore.
3283         (dwarf2_psymtab::read_symtab): Don't clear
3284         reading_partial_symbols.
3285
3286 2020-02-24  Tom de Vries  <tdevries@suse.de>
3287
3288         PR gdb/25592
3289         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3290
3291 2020-02-24  Tom de Vries  <tdevries@suse.de>
3292
3293         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3294         commands layout next/prev/regs.
3295
3296 2020-02-22  Tom Tromey  <tom@tromey.com>
3297
3298         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3299         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3300
3301 2020-02-22  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3304
3305 2020-02-22  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3308         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3309         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3310         * tui/tui.c (_initialize_tui): Add usage text.
3311
3312 2020-02-22  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-win.c (tui_set_focus_command)
3315         (tui_set_win_height_command): Use error_no_arg.
3316         (_initialize_tui_win): Update help text.
3317         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3318
3319 2020-02-22  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3322         * tui/tui-disasm.h (struct tui_disasm_window)
3323         <display_start_addr>: Declare.
3324         * tui/tui-source.h (struct tui_source_window)
3325         <display_start_addr>: Declare.
3326         * tui/tui-winsource.h (struct tui_source_window_base)
3327         <show_source_line, display_start_addr>: New methods.
3328         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3329         Rename and move to protected section.
3330         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3331         (tui_source_window_base::do_erase_source_content): Update.
3332         (tui_source_window_base::show_source_line): Now a method.
3333         (tui_source_window_base::show_source_content)
3334         (tui_source_window_base::tui_source_window_base)
3335         (tui_source_window_base::rerender)
3336         (tui_source_window_base::refill)
3337         (tui_source_window_base::do_scroll_horizontal)
3338         (tui_source_window_base::set_is_exec_point_at)
3339         (tui_source_window_base::update_breakpoint_info)
3340         (tui_source_window_base::update_exec_info): Update.
3341         * tui/tui-source.c (tui_source_window::set_contents)
3342         (tui_source_window::showing_source_p)
3343         (tui_source_window::do_scroll_vertical)
3344         (tui_source_window::location_matches_p)
3345         (tui_source_window::line_is_displayed): Update.
3346         (tui_source_window::display_start_addr): New method.
3347         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3348         (tui_disasm_window::do_scroll_vertical)
3349         (tui_disasm_window::location_matches_p): Update.
3350         (tui_disasm_window::display_start_addr): New method.
3351
3352 2020-02-22  Tom Tromey  <tom@tromey.com>
3353
3354         * NEWS: Add entry for gdb.register_window_type.
3355         * tui/tui-layout.h (window_factory): New typedef.
3356         (tui_register_window): Declare.
3357         * tui/tui-layout.c (saved_tui_windows): New global.
3358         (tui_apply_current_layout): Use it.
3359         (tui_register_window): New function.
3360         * python/python.c (do_start_initialization): Call
3361         gdbpy_initialize_tui.
3362         (python_GdbMethods): Add "register_window_type" function.
3363         * python/python-internal.h (gdbpy_register_tui_window)
3364         (gdbpy_initialize_tui): Declare.
3365         * python/py-tui.c: New file.
3366         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3367
3368 2020-02-22  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3371
3372 2020-02-22  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3375         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3376         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3377         (tui_set_win_focus_to): Move from tui-win.c.
3378
3379 2020-02-22  Tom Tromey  <tom@tromey.com>
3380
3381         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3382         functions.
3383         (known_window_types): New global.
3384         (tui_get_window_by_name): Reimplement.
3385         (initialize_known_windows): New function.
3386         (validate_window_name): Rewrite.
3387         (_initialize_tui_layout): Call initialize_known_windows.
3388
3389 2020-02-22  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3392         Remove constants.
3393         * tui/tui-winsource.h (struct tui_source_window_base)
3394         <tui_source_window_base>: Remove parameter.
3395         * tui/tui-winsource.c
3396         (tui_source_window_base::tui_source_window_base): Remove
3397         parameter.
3398         (tui_source_window_base::refill): Update.
3399         * tui/tui-stack.h (struct tui_locator_window)
3400         <tui_locator_window>: Update.
3401         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3402         Default the constructor.
3403         * tui/tui-regs.h (struct tui_data_item_window)
3404         <tui_data_item_window>: Default the constructor.
3405         (struct tui_data_window) <tui_data_window>: Likewise.
3406         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3407         Default the constructor.
3408         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3409         Default the constructor.
3410         <type>: Remove.
3411         (struct tui_win_info) <tui_win_info>: Default the constructor.
3412         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3413         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3414         Default the constructor.
3415
3416 2020-02-22  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3419         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3420         * tui/tui-win.c (tui_resize_all): Don't call
3421         tui_delete_invisible_windows.
3422         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3423         done.
3424         (tui_set_layout): Update.
3425         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3426         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3427         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3428
3429 2020-02-22  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3432         correctly.
3433
3434 2020-02-22  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3437
3438 2020-02-22  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-winsource.h (struct tui_source_window_iterator)
3441         <inner_iterator>: New etytypedef.
3442         <tui_source_window_iterator>: Take "end" parameter.
3443         <tui_source_window_iterator>: Take iterator.
3444         <operator*, advance>: Update.
3445         <m_iter>: Change type.
3446         <m_end>: New field.
3447         (struct tui_source_windows) <begin, end>: Update.
3448         * tui/tui-layout.c (tui_windows): New global.
3449         (tui_apply_current_layout): Clear tui_windows.
3450         (tui_layout_window::apply): Update tui_windows.
3451         * tui/tui-data.h (tui_windows): Declare.
3452         (all_tui_windows): Now inline function.
3453         (class tui_window_iterator, struct all_tui_windows): Remove.
3454
3455 2020-02-22  Tom Tromey  <tom@tromey.com>
3456
3457         PR tui/17850:
3458         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3459         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3460         "height" argument.
3461         (class tui_layout_window) <get_sizes>: Likewise.
3462         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3463         argument.
3464         <get_sizes>: Add "height" argument.
3465         <m_vertical>: New field.
3466         * tui/tui-layout.c (tui_layout_split::clone): Update.
3467         (tui_layout_split::get_sizes): Add "height" argument.
3468         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3469         (tui_new_layout_command): Parse "-horizontal".
3470         (_initialize_tui_layout): Update help string.
3471         (tui_layout_split::specification): Add "-horizontal" when needed.
3472         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3473         argument.
3474         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3475         New methods.
3476
3477 2020-02-22  Tom Tromey  <tom@tromey.com>
3478
3479         * tui/tui-layout.h (enum tui_adjust_result): New.
3480         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3481         (class tui_layout_window) <adjust_size>: Return
3482         tui_adjust_result.  Rewrite.
3483         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3484         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3485
3486 2020-02-22  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3489         parameter and return types.
3490         (class tui_layout_base) <specification>: Add "depth".
3491         (class tui_layout_window) <specification>: Add "depth".
3492         (class tui_layout_split) <specification>: Add "depth".
3493         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3494         and return types.
3495         (tui_new_layout_command): Parse sub-layouts.
3496         (_initialize_tui_layout): Update help string.
3497         (tui_layout_window::specification): Add "depth".
3498         (add_layout_command): Update.
3499
3500 2020-02-22  Tom Tromey  <tom@tromey.com>
3501
3502         * NEWS: Add "tui new-layout" item.
3503         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3504         Add new-layout command to help text.
3505         (validate_window_name): New function.
3506         (tui_new_layout_command): New function.
3507         (_initialize_tui_layout): Register "new-layout".
3508         (tui_layout_window::specification): New method.
3509         (tui_layout_window::specification): New method.
3510         * tui/tui-layout.h (class tui_layout_base) <specification>: New
3511         method.
3512         (class tui_layout_window) <specification>: New method.
3513         (class tui_layout_split) <specification>: New method.
3514
3515 2020-02-22  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
3518         * tui/tui-win.c (window_name_completer): Update comment.
3519         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
3520         Declare method.
3521         (class tui_layout_window) <replace_window>: Likewise.
3522         (class tui_layout_split) <replace_window>: Likewise.
3523         (tui_set_layout): Don't declare.
3524         (tui_set_initial_layout): Declare function.
3525         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
3526         (asm_regs_layout): New globals.
3527         (tui_current_layout, show_layout): Remove.
3528         (tui_set_layout, tui_add_win_to_layout): Rewrite.
3529         (find_layout, tui_apply_layout): New function.
3530         (layout_completer): Remove.
3531         (tui_next_layout): Reimplement.
3532         (tui_next_layout_command): New function.
3533         (tui_set_initial_layout, tui_prev_layout_command): New functions.
3534         (tui_regs_layout): Reimplement.
3535         (tui_regs_layout_command): New function.
3536         (extract_display_start_addr): Rewrite.
3537         (next_layout, prev_layout): Remove.
3538         (tui_layout_window::replace_window): New method.
3539         (tui_layout_split::replace_window): New method.
3540         (destroy_layout): New function.
3541         (layout_list): New global.
3542         (add_layout_command): New function.
3543         (initialize_layouts): Update.
3544         (tui_layout_command): New function.
3545         (_initialize_tui_layout): Install "layout" commands.
3546         * tui/tui-data.h (enum tui_layout_type): Remove.
3547         (tui_current_layout): Don't declare.
3548
3549 2020-02-22  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-regs.c (tui_reg_layout): Remove.
3552         (tui_reg_command): Use tui_regs_layout.
3553         * tui/tui-layout.h (tui_reg_command): Declare.
3554         * tui/tui-layout.c (tui_reg_command): New function.
3555
3556 2020-02-22  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui.c (tui_rl_delete_other_windows): Call
3559         tui_remove_some_windows.
3560         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
3561         Declare method.
3562         (class tui_layout_window) <remove_windows>: New method.
3563         (class tui_layout_split) <remove_windows>: Declare.
3564         (tui_remove_some_windows): Declare.
3565         * tui/tui-layout.c (tui_remove_some_windows): New function.
3566         (tui_layout_split::remove_windows): New method.
3567
3568 2020-02-22  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
3571         * tui/tui-layout.h (tui_next_layout): Declare.
3572         * tui/tui-layout.c (tui_next_layout): New function.
3573
3574 2020-02-22  Tom Tromey  <tom@tromey.com>
3575
3576         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
3577         correct coordinates.
3578
3579 2020-02-22  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
3582         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
3583         DATA_WIN case.
3584
3585 2020-02-22  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
3588         TUI_DISASM_WIN, not tui_win_list.
3589
3590 2020-02-22  Tom Tromey  <tom@tromey.com>
3591
3592         * valprint.c (generic_val_print_enum_1)
3593         (val_print_type_code_flags): Style member names.
3594         * rust-lang.c (val_print_struct, rust_print_enum)
3595         (rust_print_struct_def, rust_internal_print_type): Style member
3596         names.
3597         * p-valprint.c (pascal_object_print_value_fields): Style member
3598         names.  Only call fprintf_symbol_filtered for static members.
3599         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
3600         * f-valprint.c (f_val_print): Style member names.
3601         * f-typeprint.c (f_type_print_base): Style member names.
3602         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
3603         call fprintf_symbol_filtered for static members.
3604         (cp_print_class_member): Style member names.
3605         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
3606         member names.
3607         * ada-valprint.c (ada_print_scalar): Style enum names.
3608         (ada_val_print_enum): Likewise.
3609         * ada-typeprint.c (print_enum_type): Style enum names.
3610
3611 2020-02-21  Tom Tromey  <tom@tromey.com>
3612
3613         * psympriv.h (struct partial_symtab): Update comment.
3614
3615 2020-02-21  Tom Tromey  <tromey@adacore.com>
3616
3617         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
3618         type is CORE_ADDR.
3619
3620 2020-02-21  Tom de Vries  <tdevries@suse.de>
3621
3622         PR gdb/25534
3623         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
3624         if dependencies[i]->user != NULL.
3625
3626 2020-02-21  Ali Tamur  <tamur@google.com>
3627
3628         * dwarf2/read.c (dwarf2_name): Add null check.
3629
3630 2020-02-20  Tom Tromey  <tom@tromey.com>
3631
3632         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
3633         ">=", in binary search.
3634         (dwarf2_find_containing_comp_unit): New overload.
3635         (run_test): New self-test.
3636         (_initialize_dwarf2_read): Register new test.
3637
3638 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
3639
3640         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
3641         * riscv-tdep.h: Likewise.
3642         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
3643         rv32-only CSR.
3644         * features/riscv/64bit-csr.xml: Regenerated.
3645
3646 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3647             Tom Tromey  <tom@tromey.com>
3648
3649         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
3650         of 'fputc_unfiltered'.
3651         (putchar_unfiltered): Call 'fputc_unfiltered'.
3652         (fputc_unfiltered): Call 'fputs_unfiltered'.
3653
3654 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * config.in: Regenerate.
3657         * configure: Regenerate.
3658         * configure.ac: Add --with-python-libdir option.
3659         * main.c: Use WITH_PYTHON_LIBDIR.
3660
3661 2020-02-19  Tom Tromey  <tom@tromey.com>
3662
3663         * symtab.c (general_symbol_info::compute_and_set_names): Use
3664         obstack_strndup.  Simplify call to symbol_set_demangled_name.
3665
3666 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
3667
3668         * dwarf2/read.c (allocate_signatured_type_table,
3669         allocate_dwo_unit_table, allocate_type_unit_groups_table,
3670         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
3671         Remove objfile parameter, update all callers.
3672
3673 2020-02-19  Doug Evans  <dje@google.com>
3674
3675         PR rust/25535
3676         * rust-lang.c (rust_print_enum): Apply embedded_offset to
3677         rust_enum_variant calculation.
3678
3679 2020-02-19  Tom Tromey  <tromey@adacore.com>
3680
3681         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
3682
3683 2020-02-19  Tom Tromey  <tromey@adacore.com>
3684
3685         * ada-lang.c (cache_symbol): Use obstack_strdup.
3686
3687 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3688
3689         * configure: Regenerate.
3690
3691 2020-02-19  Tom Tromey  <tromey@adacore.com>
3692
3693         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
3694         NULL check.
3695
3696 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
3697
3698         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
3699
3700 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
3703         if GDBSERVER is not defined.
3704         (riscv_tdesc_cache): Likewise, also store const target_desc.
3705         (STATIC_IN_GDB): Define.
3706         (riscv_create_target_description): Update declaration with
3707         STATIC_IN_GDB.
3708         (riscv_lookup_target_description): New function, only define if
3709         GDBSERVER is not defined.
3710         * arch/riscv.h (riscv_create_target_description): Declare only
3711         when GDBSERVER is defined.
3712         (riscv_lookup_target_description): New declaration when GDBSERVER
3713         is not defined.
3714         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
3715         (riscv_linux_read_features): ...this, and return
3716         riscv_gdbarch_features instead of target_desc.
3717         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
3718         (riscv_linux_read_description): Rename to...
3719         (riscv_linux_read_features): ...this.
3720         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3721         Update to use riscv_gdbarch_features and
3722         riscv_lookup_target_description.
3723         * riscv-tdep.c (riscv_find_default_target_description): Use
3724         riscv_lookup_target_description instead of
3725         riscv_create_target_description.
3726
3727 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3728
3729         * valprint.c (generic_val_print_enum_1): When printing a flag
3730         enum with value 0 and there is no enumerator with value 0, print
3731         just "0" instead of "(unknown: 0x0)".
3732
3733 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3734
3735         * valprint.c (generic_val_print_enum_1): Print unknown part of
3736         flag enum in hex.
3737
3738 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3739
3740         * dwarf2/read.c (update_enumeration_type_from_children): Allow
3741         flag enums to contain duplicate enumerators.
3742         * valprint.c (generic_val_print_enum_1): Update comment.
3743
3744 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3745
3746         * dwarf2/read.c: Include "count-one-bits.h".
3747         (update_enumeration_type_from_children): If an enumerator has
3748         multiple bits set, don't treat the enumeration as a "flag enum".
3749         * valprint.c (generic_val_print_enum_1): Assert that enumerators
3750         of flag enums have 0 or 1 bit set.
3751
3752 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3753
3754         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
3755         conversion.
3756         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3757         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3758         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3759         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3760         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3761
3762 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3763
3764         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
3765
3766 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3767
3768         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
3769         displaced_step_closure_up.
3770         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3771         (struct displaced_step_closure_up):
3772         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3773         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3774         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
3775         Likewise.
3776         * gdbarch.sh (displaced_step_copy_insn): Likewise.
3777         * gdbarch.c, gdbarch.h: Re-generate.
3778         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
3779         displaced_step_closure_up.
3780         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3781         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3782         * infrun.h (displaced_step_closure_up): New type alias.
3783         (struct displaced_step_inferior_state) <step_closure>: Change
3784         type to displaced_step_closure_up.
3785         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
3786         displaced_step_closure_up.
3787         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3788
3789 2020-02-14  Tom Tromey  <tom@tromey.com>
3790
3791         * minidebug.c (gnu_debug_key): New global.
3792         (find_separate_debug_file_in_section): Use it.
3793
3794 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3795
3796         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
3797         std::unique_ptr.
3798         * gdbarch.c: Re-generate.
3799         * gdbarch.h: Re-generate.
3800         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
3801         change.
3802         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
3803         type to std::unique_ptr.
3804         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3805         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3806         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3807         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3808         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
3809         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3810         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3811         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3812         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3813
3814 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3815
3816         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
3817         std::unique_ptr.
3818         (displaced_step_clear): Rename to...
3819         (displaced_step_reset): ... this.  Just call displaced->reset ().
3820         (displaced_step_clear_cleanup): Rename to...
3821         (displaced_step_reset_cleanup): ... this.
3822         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
3823         (displaced_step_fixup): Likewise.
3824         (resume_1): Likewise.
3825         (handle_inferior_event): Restore child's memory before calling
3826         displaced_step_fixup on the parent.
3827         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
3828         to std::unique_ptr.
3829         <step_closure>: Change type to std::unique_ptr.
3830
3831 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3832
3833         * arm-tdep.c: Include count-one-bits.h.
3834         (cleanup_block_store_pc): Use count_one_bits.
3835         (cleanup_block_load_pc): Use count_one_bits.
3836         (arm_copy_block_xfer): Use count_one_bits.
3837         (thumb2_copy_block_xfer): Use count_one_bits.
3838         (thumb_copy_pop_pc_16bit): Use count_one_bits.
3839         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
3840         (thumb_get_next_pcs_raw): Use count_one_bits.
3841         (arm_get_next_pcs_raw): Use count_one_bits_l.
3842         * arch/arm.c (bitcount): Remove.
3843         * arch/arm.h (bitcount): Remove.
3844
3845 2020-02-14  Tom Tromey  <tromey@adacore.com>
3846
3847         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
3848         Update.
3849         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
3850         * dwarf2/loc.c (call_site_find_chain_1): Return
3851         unique_xmalloc_ptr.
3852         (call_site_find_chain): Likewise.
3853
3854 2020-02-14  Richard Biener  <rguenther@suse.de>
3855
3856         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
3857         on expression with division operators.
3858
3859 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3860
3861         * MAINTAINERS (Write After Approval): Adding myself.
3862
3863 2020-02-12  Tom Tromey  <tom@tromey.com>
3864
3865         * event-loop.c (event_data, gdb_event, event_handler_func):
3866         Remove.
3867
3868 2020-02-12  Tom Tromey  <tom@tromey.com>
3869
3870         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
3871         (dwarf2_frame_objfile_data): Add comment.
3872         (find_comp_unit, set_comp_unit): New functions.
3873         (dwarf2_frame_find_fde): Use find_comp_unit.
3874         (dwarf2_build_frame_info): Use set_comp_unit.
3875
3876 2020-02-12  Tom Tromey  <tom@tromey.com>
3877
3878         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
3879         (comp_unit): Don't initialize objfile.
3880         (execute_cfa_program): Add text_offset parameter.
3881         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
3882         (dwarf2_frame_cache): Update.
3883         (dwarf2_build_frame_info): Don't set "objfile" member.
3884
3885 2020-02-12  Tom Tromey  <tom@tromey.com>
3886
3887         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
3888         (decode_frame_entry): Likewise.
3889         (dwarf2_build_frame_info): Update.
3890
3891 2020-02-12  Tom Tromey  <tom@tromey.com>
3892
3893         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
3894         (decode_frame_entry_1): Use the comp_unit obstack.
3895
3896 2020-02-12  Tom Tromey  <tom@tromey.com>
3897
3898         * dwarf2/frame.c (struct comp_unit): Add initializers and
3899         constructor.
3900         (dwarf2_frame_objfile_data): Store a comp_unit.
3901         (dwarf2_frame_find_fde): Update.
3902         (dwarf2_build_frame_info): Use "new".
3903
3904 2020-02-12  Tom Tromey  <tom@tromey.com>
3905
3906         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
3907         (dwarf2_fde_table): Typedef for std::vector.
3908         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
3909         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
3910         (decode_frame_entry): Update.
3911         (dwarf2_build_frame_info): Use "new".
3912
3913 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
3914
3915         * arm-tdep.c (arm_gdbarch_init): Update.
3916         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
3917         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
3918         have_neon, is_m>: Change to bool.
3919
3920 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
3921
3922         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
3923
3924 2020-02-12  Tom Tromey  <tom@tromey.com>
3925
3926         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
3927
3928 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
3929
3930         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
3931         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
3932
3933 2020-02-11  Tom Tromey  <tom@tromey.com>
3934
3935         * psymtab.h: Update comment.
3936
3937 2020-02-11  Tom Tromey  <tom@tromey.com>
3938
3939         * gdb_obstack.h (struct auto_obstack): Use
3940         DISABLE_COPY_AND_ASSIGN.
3941
3942 2020-02-11  Tom Tromey  <tom@tromey.com>
3943
3944         * dwarf2/frame.h (struct objfile): Don't forward declare.
3945
3946 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3947
3948         * cris-tdep.c (cris_supply_gregset): Change signature to match
3949         what struct regset expects.
3950         (cris_regset): New struct.
3951         (fetch_core_registers): Remove.
3952         (cris_iterate_over_regset_sections): New function.
3953         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
3954         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
3955
3956 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3957
3958         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
3959         registers.
3960
3961 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3962
3963         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
3964
3965 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3966
3967         * configure: Re-generate.
3968
3969 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3970
3971         * configure: Re-generate.
3972
3973 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3974
3975         * acinclude: Update warning.m4 path.
3976         * warning.m4: Move to gdbsupport.
3977
3978 2020-02-11  Tom Tromey  <tromey@adacore.com>
3979
3980         * remote.c (remote_console_output): Update.
3981         * printcmd.c (printf_command): Update.
3982         * event-loop.c (gdb_wait_for_event): Update.
3983         * linux-nat.c (sigchld_handler): Update.
3984         * remote-sim.c (gdb_os_write_stdout): Update.
3985         (gdb_os_flush_stdout): Update.
3986         (gdb_os_flush_stderr): Update.
3987         (gdb_os_write_stderr): Update.
3988         * exceptions.c (print_exception): Update.
3989         * remote-fileio.c (remote_fileio_func_read): Update.
3990         (remote_fileio_func_write): Update.
3991         * tui/tui.c (tui_enable): Update.
3992         * tui/tui-interp.c (tui_interp::init): Update.
3993         * utils.c (init_page_info): Update.
3994         (putchar_unfiltered, fputc_unfiltered): Update.
3995         (gdb_flush): Update.
3996         (emit_style_escape): Update.
3997         (flush_wrap_buffer, fputs_maybe_filtered): Update.
3998         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
3999         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4000         (stderr_file::write): Update.
4001         (stderr_file::puts): Update.
4002         * ui-file.h (ui_file_isatty, ui_file_write)
4003         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4004         (ui_file_puts): Don't declare.
4005
4006 2020-02-10  Tom de Vries  <tdevries@suse.de>
4007
4008         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4009         sentinel to char *.
4010
4011 2020-02-09  Tom de Vries  <tdevries@suse.de>
4012
4013         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4014         filename if it matches "<artificial>".
4015
4016 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4017
4018         * windows-tdep.c (struct enum_value_name): New struct.
4019         (create_enum): New function.
4020         (windows_get_siginfo_type): Create and use enum types.
4021
4022 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4023
4024         * NEWS: Mention $_siginfo support for Windows.
4025         * windows-nat.c (handle_exception): Set siginfo_er.
4026         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4027         (windows_xfer_siginfo): New function.
4028         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4029         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4030         (init_windows_gdbarch_data): New function.
4031         (get_windows_gdbarch_data): New function.
4032         (windows_get_siginfo_type): New function.
4033         (windows_init_abi): Register windows_get_siginfo_type.
4034         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4035
4036 2020-02-08  Tom Tromey  <tom@tromey.com>
4037
4038         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4039         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4040         <keep>: Declare method.
4041         <m_keep>: Remove member.
4042         <~cutu_reader>: Remove.
4043         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4044         (cutu_reader::cutu_reader): Update.
4045         (cutu_reader::keep): Rename from ~cutu_reader.
4046         (process_psymtab_comp_unit, build_type_psymtabs_1)
4047         (process_skeletonless_type_unit, load_partial_comp_unit)
4048         (load_full_comp_unit, dwarf2_read_addr_index)
4049         (read_signatured_type): Update.
4050
4051 2020-02-08  Tom Tromey  <tom@tromey.com>
4052
4053         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4054         "want_partial_unit" parameter.
4055         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4056         Inline check for DW_TAG_partial_unit.
4057         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4058
4059 2020-02-08  Tom Tromey  <tom@tromey.com>
4060
4061         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4062         read.c.
4063         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4064         read.c.
4065
4066 2020-02-08  Tom Tromey  <tom@tromey.com>
4067
4068         * dwarf2/read.c (read_address): Move to comp-unit.c.
4069         (dwarf2_rnglists_process, dwarf2_ranges_process)
4070         (read_attribute_value, dwarf_decode_lines_1)
4071         (var_decode_location, decode_locdesc): Update.
4072         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4073         read.c.  Remove "cu" parameter.
4074         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4075         method.
4076
4077 2020-02-08  Tom Tromey  <tom@tromey.com>
4078
4079         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4080         (read_indirect_line_string): Update.
4081         * dwarf2/comp-unit.c (read_offset): Remove.
4082         (read_comp_unit_head): Update.
4083         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4084         method.
4085         (read_offset): Don't declare.
4086
4087 2020-02-08  Tom Tromey  <tom@tromey.com>
4088
4089         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4090         * dwarf2/read.c (struct comp_unit_head): Move to
4091         dwarf2/comp-unit.h.
4092         (enum class rcuh_kind): Move to comp-unit.h.
4093         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4094         (read_comp_unit_head, error_check_comp_unit_head)
4095         (read_and_check_comp_unit_head): Move to comp-unit.c.
4096         (read_offset, dwarf_unit_type_name): Likewise.
4097         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4098         (cutu_reader::cutu_reader, read_call_site_scope)
4099         (find_partial_die, follow_die_offset): Update.
4100         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4101
4102 2020-02-08  Tom Tromey  <tom@tromey.com>
4103
4104         * dwarf2/read.c (read_offset_1): Move to leb.c.
4105         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4106         (dwarf_decode_macro_bytes): Update.
4107         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4108         * dwarf2/leb.h (read_offset): Declare.
4109
4110 2020-02-08  Tom Tromey  <tom@tromey.com>
4111
4112         * dwarf2/read.c (dwarf2_section_size): Remove.
4113         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4114         Update.
4115         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4116
4117 2020-02-08  Tom Tromey  <tom@tromey.com>
4118
4119         * dwarf2/read.c (read_initial_length): Move to leb.c.
4120         * dwarf2/leb.h (read_initial_length): Declare.
4121         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4122         handle_nonstd parameter.
4123         * dwarf2/frame.c (read_initial_length): Remove.
4124         (decode_frame_entry_1): Update.
4125
4126 2020-02-08  Tom Tromey  <tom@tromey.com>
4127
4128         * dwarf2/loc.c (dwarf2_find_location_expression)
4129         (dwarf_evaluate_loc_desc::get_tls_address)
4130         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4131         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4132         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4133         (dwarf2_compile_property_to_c)
4134         (dwarf2_loc_desc_get_symbol_read_needs)
4135         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4136         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4137         (loclist_describe_location, loclist_tracepoint_var_ref)
4138         (loclist_generate_c_location): Update.
4139         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4140         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4141         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4142         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4143         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4144         (dwarf2_per_cu_data::addr_size)
4145         (dwarf2_per_cu_data::ref_addr_size)
4146         (dwarf2_per_cu_data::text_offset)
4147         (dwarf2_per_cu_data::addr_type): Now methods.
4148         (per_cu_header_read_in): Make per_cu "const".
4149         (dwarf2_version): Remove.
4150         (dwarf2_per_cu_data::int_type): Now a method.
4151         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4152         (set_die_type, read_array_type, read_subrange_index_type)
4153         (read_tag_string_type, read_subrange_type): Update.
4154         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4155         offset_size, ref_addr_size, text_offset, addr_type, version,
4156         objfile, int_type, addr_sized_int_type>: Declare methods.
4157
4158 2020-02-08  Tom Tromey  <tom@tromey.com>
4159
4160         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4161         Move earlier.
4162
4163 2020-02-08  Tom Tromey  <tom@tromey.com>
4164
4165         * dwarf2/read.h (dwarf_line_debug): Declare.
4166         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4167         * dwarf2/read.c: Move line_header code to new files.
4168         (dwarf_line_debug): No longer static.
4169         * dwarf2/line-header.c: New file.
4170         * dwarf2/line-header.h: New file.
4171
4172 2020-02-08  Tom Tromey  <tom@tromey.com>
4173
4174         * dwarf2/read.c (struct line_header) <file_full_name,
4175         file_file_name>: Return unique_xmalloc_ptr.
4176         (line_header::file_file_name): Update.
4177         (line_header::file_full_name): Update.
4178         (dw2_get_file_names_reader): Update.
4179         (macro_start_file): Update.
4180
4181 2020-02-08  Tom Tromey  <tom@tromey.com>
4182
4183         * dwarf2/read.c (struct line_header) <file_full_name,
4184         file_file_name>: Declare methods.
4185         (dw2_get_file_names_reader): Update.
4186         (file_file_name): Now a method.
4187         (file_full_name): Likewise.
4188         (macro_start_file): Update.
4189
4190 2020-02-08  Tom Tromey  <tom@tromey.com>
4191
4192         * dwarf2/read.c (dwarf_always_disassemble)
4193         (show_dwarf_always_disassemble): Move to loc.c.
4194         (_initialize_dwarf2_read): Move "always-disassemble" registration
4195         to loc.c.
4196         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4197         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4198         static.
4199         (show_dwarf_always_disassemble): Move from read.c.
4200         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4201
4202 2020-02-08  Tom Tromey  <tom@tromey.com>
4203
4204         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4205         (create_quick_file_names_table): Return htab_up.
4206         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4207         Update.
4208         * dwarf2/read.h (struct dwarf2_per_objfile)
4209         <quick_file_names_table>: Now htab_up.
4210
4211 2020-02-08  Tom Tromey  <tom@tromey.com>
4212
4213         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4214
4215 2020-02-08  Tom Tromey  <tom@tromey.com>
4216
4217         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4218         Rewrite.
4219         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4220         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4221         (abbrev_table::abbrev_table): No longer inline.
4222         (ABBREV_HASH_SIZE): Remove.
4223         (abbrev_table::m_abbrevs): Now an htab_up.
4224
4225 2020-02-08  Tom Tromey  <tom@tromey.com>
4226
4227         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4228         (cutu_reader): Update.
4229         (build_type_psymtabs_1): Update.
4230         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4231         (abbrev_table::alloc_abbrev): Update.
4232         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4233         (abbrev_table::read): New static method, renamed from
4234         abbrev_table_read_table.
4235         (abbrev_table::alloc_abbrev)
4236         (abbrev_table::add_abbrev): Now private.
4237         (abbrev_table::abbrev_table): Now private.
4238         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4239
4240 2020-02-08  Tom Tromey  <tom@tromey.com>
4241
4242         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4243         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4244         htab_up.
4245
4246 2020-02-08  Tom Tromey  <tom@tromey.com>
4247
4248         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4249         htab_up.
4250         (lookup_dwo_unit_in_dwp): Update.
4251         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4252         on obstack.
4253
4254 2020-02-08  Tom Tromey  <tom@tromey.com>
4255
4256         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4257         obstack.
4258
4259 2020-02-08  Tom Tromey  <tom@tromey.com>
4260
4261         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4262         line_header_hash.
4263         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4264         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4265         Change type to htab_up.
4266
4267 2020-02-08  Tom Tromey  <tom@tromey.com>
4268
4269         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4270         htab_up.  Don't allocate on obstack.
4271         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4272         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4273         Change type to htab_up.
4274
4275 2020-02-08  Tom Tromey  <tom@tromey.com>
4276
4277         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4278         Change type to htab_up.
4279         * dwarf2/read.c (create_signatured_type_table_from_index)
4280         (create_signatured_type_table_from_debug_names)
4281         (create_all_type_units, add_type_unit)
4282         (lookup_dwo_signatured_type, lookup_signatured_type)
4283         (process_skeletonless_type_unit): Update.
4284         (create_debug_type_hash_table, create_debug_types_hash_table):
4285         Change type of types_htab.
4286         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4287         htab_up.  Don't allocate on obstack.
4288         (create_cus_hash_table): Change type of cus_htab parameter.
4289         (struct dwo_file) <cus, tus>: Now htab_up.
4290         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4291         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4292         (queue_and_load_all_dwo_tus): Update.
4293         * dwarf2/index-write.c (write_gdbindex): Update.
4294         (write_debug_names): Update.
4295
4296 2020-02-08  Tom Tromey  <tom@tromey.com>
4297
4298         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4299         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4300         destructor.
4301         (struct dwarf2_per_objfile) <queue>: New member.
4302         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4303         dwarf2/read.h.
4304         (dwarf2_queue, dwarf2_queue_tail): Remove.
4305         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4306         DISABLE_COPY_AND_ASSIGN.
4307         <m_per_objfile>: New member.
4308         <~dwarf2_queue_guard>: Rewrite.
4309         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4310         Update.
4311         (~dwarf2_queue_item): New.
4312
4313 2020-02-08  Tom Tromey  <tom@tromey.com>
4314
4315         * dwarf2/read.c (struct die_info) <has_children>: New member.
4316         (dw2_get_file_names_reader): Remove has_children.
4317         (dw2_get_file_names): Update.
4318         (read_cutu_die_from_dwo): Remove has_children.
4319         (cutu_reader::init_tu_and_read_dwo_dies)
4320         (cutu_reader::cutu_reader): Update.
4321         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4322         Remove has_children.
4323         (build_type_psymtabs_1, process_skeletonless_type_unit)
4324         (load_partial_comp_unit, load_full_comp_unit): Update.
4325         (create_dwo_cu_reader): Remove has_children.
4326         (create_cus_hash_table, read_die_and_children): Update.
4327         (read_full_die_1,read_full_die): Remove has_children.
4328         (read_signatured_type): Update.
4329         (class cutu_reader) <has_children>: Remove.
4330
4331 2020-02-08  Tom Tromey  <tom@tromey.com>
4332
4333         * dwarf2/expr.c: Rename from dwarf2expr.c.
4334         * dwarf2/expr.h: Rename from dwarf2expr.h.
4335         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4336         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4337         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4338         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4339         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4340         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4341         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4342         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4343         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4344         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4345         * dwarf2/loc.c: Rename from dwarf2loc.c.
4346         * dwarf2/loc.h: Rename from dwarf2loc.h.
4347         * dwarf2/read.c: Rename from dwarf2read.c.
4348         * dwarf2/read.h: Rename from dwarf2read.h.
4349         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4350         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4351         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4352         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4353         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4354         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4355         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4356         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4357         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4358         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4359         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4360         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4361         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4362         Update.
4363         * Makefile.in (COMMON_SFILES): Update.
4364         (HFILES_NO_SRCDIR): Update.
4365
4366 2020-02-08  Tom Tromey  <tom@tromey.com>
4367
4368         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4369         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4370
4371 2020-02-08  Tom Tromey  <tom@tromey.com>
4372
4373         * dwarf2read.h (struct die_info): Don't declare.
4374
4375 2020-02-08  Tom Tromey  <tom@tromey.com>
4376
4377         * dwarf2read.h (die_info_ptr): Remove typedef.
4378
4379 2020-02-08  Tom Tromey  <tom@tromey.com>
4380
4381         * dwarf2read.c (read_call_site_scope)
4382         (handle_data_member_location, dwarf2_add_member_fn)
4383         (mark_common_block_symbol_computed, read_common_block)
4384         (attr_to_dynamic_prop, partial_die_info::read)
4385         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4386         (dwarf2_symbol_mark_computed, set_die_type): Update.
4387         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4388         method.
4389         (attr_form_is_block): Don't declare.
4390         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4391
4392 2020-02-08  Tom Tromey  <tom@tromey.com>
4393
4394         * dwarf2read.c (dwarf2_find_base_address, )
4395         (read_call_site_scope, rust_containing_type)
4396         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4397         (handle_data_member_location, dwarf2_add_member_fn)
4398         (get_alignment, read_structure_type, process_structure_scope)
4399         (mark_common_block_symbol_computed, read_common_block)
4400         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4401         (partial_die_info::read, read_attribute_value, new_symbol)
4402         (lookup_die_type, dwarf2_get_ref_die_offset)
4403         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4404         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4405         (dwarf2_symbol_mark_computed): Update.
4406         * dwarf2/attribute.h (struct attribute) <value_as_address,
4407         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4408         methods.
4409         (value_as_address, attr_form_is_section_offset)
4410         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4411         * dwarf2/attribute.c (attribute::value_as_address)
4412         (attribute::form_is_section_offset, attribute::form_is_constant)
4413         (attribute::form_is_ref): Now methods.
4414
4415 2020-02-08  Tom Tromey  <tom@tromey.com>
4416
4417         * dwarf2read.c (struct attribute, DW_STRING)
4418         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4419         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4420         (attr_form_is_block, attr_form_is_section_offset)
4421         (attr_form_is_constant, attr_form_is_ref): Move.
4422         * dwarf2/attribute.h: New file.
4423         * dwarf2/attribute.c: New file, from dwarf2read.c.
4424         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4425
4426 2020-02-08  Tom Tromey  <tom@tromey.com>
4427
4428         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4429         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4430         Move.
4431         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4432         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4433         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4434         abbrev.c.
4435         * dwarf2/abbrev.h: New file.
4436         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4437         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4438
4439 2020-02-08  Tom Tromey  <tom@tromey.com>
4440
4441         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4442         (dwarf2_section_size, dwarf2_get_section_info)
4443         (create_signatured_type_table_from_debug_names)
4444         (create_addrmap_from_aranges, read_debug_names_from_section)
4445         (get_gdb_index_contents_from_section, read_comp_unit_head)
4446         (error_check_comp_unit_head, read_abbrev_offset)
4447         (create_debug_type_hash_table, init_cu_die_reader)
4448         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4449         (read_comp_units_from_section, create_cus_hash_table)
4450         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4451         (create_dwp_v2_section, dwarf2_rnglists_process)
4452         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4453         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4454         (read_indirect_string_from_dwz, read_addr_index_1)
4455         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4456         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4457         (fill_in_loclist_baton): Update.
4458         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4459         get_containing_section, get_bfd_owner, get_bfd_section,
4460         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4461         (dwarf2_read_section, get_section_name, get_section_file_name)
4462         (get_containing_section, get_section_bfd_owner)
4463         (get_section_bfd_section, get_section_name, get_section_file_name)
4464         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4465         declare.
4466         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4467         (dwarf2_section_info::get_bfd_owner)
4468         (dwarf2_section_info::get_bfd_section)
4469         (dwarf2_section_info::get_name)
4470         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4471         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4472         (dwarf2_section_info::read): Now methods.
4473         * dwarf-index-write.c (class debug_names): Update.
4474
4475 2020-02-08  Tom Tromey  <tom@tromey.com>
4476
4477         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4478         Move to dwarf2/section.h.
4479         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4480         (get_section_bfd_section, get_section_name)
4481         (get_section_file_name, get_section_id, get_section_flags)
4482         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4483         dwarf2/section.c.
4484         * dwarf2/section.h: New file.
4485         * dwarf2/section.c: New file, from dwarf2read.c.
4486         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4487
4488 2020-02-08  Tom Tromey  <tom@tromey.com>
4489
4490         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4491         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4492         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4493         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4494         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4495         * dwarf2/leb.h: New file, from dwarf2read.c.
4496         * dwarf2/leb.c: New file, from dwarf2read.c.
4497         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4498         Remove.
4499         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4500         (COMMON_SFILES): Add dwarf2/leb.c.
4501
4502 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4503
4504         GDB 9.1 released.
4505
4506 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4507
4508         PR gdb/25190:
4509         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
4510         * gdb/remote.c (remote_console_output): Update.
4511         * gdb/ui-file.c (fputs_unfiltered): Rename to...
4512         (ui_file_puts): ...this.
4513         * gdb/ui-file.h (ui_file_puts): Add declaration.
4514         * gdb/utils.c (emit_style_escape): Update.
4515         (flush_wrap_buffer): Update.
4516         (fputs_maybe_filtered): Update.
4517         (fputs_unfiltered): Add function.
4518
4519 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4520
4521         * gdb/event-loop.c (gdb_wait_for_event): Update.
4522         * gdb/printcmd.c (printf_command): Update.
4523         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
4524         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
4525         (gdb_os_flush_stderr): Update.
4526         * gdb/remote.c (remote_console_output): Update.
4527         * gdb/ui-file.c (gdb_flush): Rename to...
4528         (ui_file_flush): ...this.
4529         (stderr_file::write): Update.
4530         (stderr_file::puts): Update.
4531         * gdb/ui-file.h (gdb_flush): Rename to...
4532         (ui_file_flush): ...this.
4533         * gdb/utils.c (gdb_flush): Add function.
4534         * gdb/utils.h (gdb_flush): Add declaration.
4535
4536 2020-02-07  Tom Tromey  <tromey@adacore.com>
4537
4538         PR breakpoints/24915:
4539         * source.c (find_and_open_source): Do not check basenames_may_differ.
4540
4541 2020-02-07  Tom Tromey  <tom@tromey.com>
4542
4543         * README: Update gdbserver documentation.
4544         * gdbserver: Move to top level.
4545         * configure.tgt (build_gdbserver): Remove.
4546         * configure.ac: Remove --enable-gdbserver.
4547         * configure: Rebuild.
4548         * Makefile.in (distclean): Don't mention gdbserver.
4549
4550 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4551
4552         * source-cache.c (source_cache::ensure): Surround
4553         get_plain_source_lines with a try/catch.
4554         (source_cache::get_line_charpos): Get rid of try/catch
4555         and only check for the return value of "ensure".
4556         * tui/tui-source.c (tui_source_window::set_contents):
4557         Simplify "nlines" calculation.
4558
4559 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4560
4561         * MAINTAINERS (Write After Approval): Add myself.
4562
4563 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4564
4565         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
4566         function call.
4567
4568 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4569
4570         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
4571
4572 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
4573
4574         * nat/riscv-linux-tdesc.h: New file.
4575         * nat/riscv-linux-tdesc.c: New file, taking code from...
4576         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4577         ... here.
4578         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
4579         NATDEPFILES.
4580
4581 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
4584         we don't set the fake simulator ptid to the null_ptid.
4585
4586 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
4587
4588         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
4589         * gdbthread.h (class thread_info) <resumed>: Likewise.
4590         * infrun.c (resume_1): Likewise.
4591         (proceed): Likewise.
4592         (infrun_thread_stop_requested): Likewise.
4593         (stop_all_threads): Likewise.
4594         (handle_inferior_event): Likewise.
4595         (restart_threads): Likewise.
4596         (finish_step_over): Likewise.
4597         (keep_going_stepped_thread): Likewise.
4598         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
4599         (linux_handle_extended_wait): Likewise.
4600         * record-btrace.c (get_thread_current_frame_id): Likewise.
4601         * record-full.c (record_full_wait_1): Likewise.
4602         * remote.c (remote_target::process_initial_stop_replies): Likewise.
4603         * target.c (target_resume): Likewise.
4604         * thread.c (set_running_thread): Likewise.
4605
4606 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4607
4608         * f-valprint.c (f77_print_array_1): Changed datatype of index
4609         variable to LONGEST from int to enable it to contain bound
4610         values correctly.
4611
4612 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
4613
4614         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
4615         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
4616         offsets according to FLEN determined.
4617         (riscv_linux_nat_target::read_description): Determine FLEN
4618         dynamically.
4619         (riscv_linux_nat_target::fetch_registers): Size regset buffer
4620         according to FLEN determined.
4621         (riscv_linux_nat_target::store_registers): Likewise.
4622
4623 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
4624
4625         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
4626         when reg->group is empty and reggroup is not.
4627
4628 2020-01-31  Tom Tromey  <tromey@adacore.com>
4629
4630         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
4631         Call beneath target's mourn_inferior after unpushing.
4632
4633 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         PR tui/9765
4636         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
4637         have enough lines to fill the screen, still return the lowest
4638         address we found.
4639
4640 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
4643         '-', '<', and '>' commands.
4644
4645 2020-01-29  Pedro Alves  <palves@redhat.com>
4646             Sergio Durigan Junior  <sergiodj@redhat.com>
4647
4648         * infcmd.c (construct_inferior_arguments): Assert that
4649         'argc' is greater than 0.
4650
4651 2020-01-29  Luis Machado  <luis.machado@linaro.org>
4652
4653         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
4654         (BRK_INSN_MASK): Define to 0xd4200000.
4655         (aarch64_program_breakpoint_here_p): New function.
4656         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
4657         * arch-utils.c (default_program_breakpoint_here_p): Moved from
4658         breakpoint.c.
4659         * arch-utils.h (default_program_breakpoint_here_p): Moved from
4660         breakpoint.h
4661         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
4662         call gdbarch_program_breakpoint_here_p.
4663         (program_breakpoint_here): Moved to arch-utils.c, renamed to
4664         default_program_breakpoint_here_p, changed return type to bool and
4665         simplified.
4666         * breakpoint.h (program_breakpoint_here): Moved prototype to
4667         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
4668         return type to bool.
4669         * gdbarch.c: Regenerate.
4670         * gdbarch.h: Regenerate.
4671         * gdbarch.sh (program_breakpoint_here_p): New method.
4672         * infrun.c (handle_signal_stop): Call
4673         gdbarch_program_breakpoint_here_p.
4674
4675 2020-01-26  Tom Tromey  <tom@tromey.com>
4676
4677         * ctfread.c (struct ctf_fp_info): Reindent.
4678         (_initialize_ctfread): Remove.
4679
4680 2020-01-26  Tom Tromey  <tom@tromey.com>
4681
4682         * psymtab.c (partial_map_expand_apply)
4683         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4684         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4685         (psym_print_stats, psym_expand_symtabs_for_function)
4686         (psym_map_symbol_filenames, psym_map_matching_symbols)
4687         (psym_expand_symtabs_matching)
4688         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4689         (maintenance_check_psymtabs): Use new methods.
4690         * psympriv.h (struct partial_symtab) <readin_p,
4691         get_compunit_symtab>: New methods.
4692         <readin, compunit_symtab>: Remove members.
4693         (struct standard_psymtab): New.
4694         (struct legacy_psymtab): Derive from standard_psymtab.
4695         * dwarf2read.h (struct dwarf2_psymtab): Derive from
4696         standard_psymtab.
4697         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
4698
4699 2020-01-26  Tom Tromey  <tom@tromey.com>
4700
4701         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
4702         read_dependencies.  Add assert.
4703         * psymtab.c (partial_symtab::read_dependencies): New method.
4704         * psympriv.h (struct partial_symtab) <read_dependencies>: New
4705         method.
4706         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
4707         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
4708         read_dependencies.
4709         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
4710         Add assert.
4711
4712 2020-01-26  Tom Tromey  <tom@tromey.com>
4713
4714         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
4715         Call expand_psymtab.
4716         (xcoff_read_symtab): Call expand_psymtab.
4717         (xcoff_start_psymtab, xcoff_end_psymtab): Set
4718         legacy_expand_psymtab.
4719         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
4720         method.
4721         (struct legacy_psymtab) <expand_psymtab>: Implement.
4722         <legacy_expand_psymtab>: New member.
4723         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
4724         (parse_partial_symbols): Set legacy_expand_psymtab.
4725         (psymtab_to_symtab_1): Change argument order.  Call
4726         expand_psymtab.
4727         (new_psymtab): Set legacy_expand_psymtab.
4728         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
4729         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
4730         expand_psymtab.
4731         (dwarf2_psymtab::expand_psymtab): Rename from
4732         psymtab_to_symtab_1.  Call expand_psymtab.
4733         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
4734         (dbx_end_psymtab): Likewise.
4735         (dbx_psymtab_to_symtab_1): Change argument order. Call
4736         expand_psymtab.
4737         (dbx_read_symtab): Call expand_psymtab.
4738         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
4739         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
4740         (ctf_psymtab::read_symtab): Call expand_psymtab.
4741
4742 2020-01-26  Tom Tromey  <tom@tromey.com>
4743
4744         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
4745         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
4746         messages.
4747         * mdebugread.c (mdebug_read_symtab): Remove prints.
4748         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
4749         assert.
4750         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
4751
4752 2020-01-26  Tom Tromey  <tom@tromey.com>
4753
4754         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
4755         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
4756         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
4757         legacy_symtab.
4758         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
4759         * psymtab.c (psymtab_to_symtab): Call method.
4760         (dump_psymtab): Update.
4761         * psympriv.h (struct partial_symtab): Add virtual destructor.
4762         <read_symtab>: New method.
4763         (struct legacy_symtab): New.
4764         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
4765         (struct pst_map) <pst>: Now a legacy_psymtab.
4766         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
4767         (new_psymtab): Use legacy_psymtab.
4768         * dwarf2read.h (struct dwarf2_psymtab): New.
4769         (struct dwarf2_per_cu_data) <psymtab>: Use it.
4770         * dwarf2read.c (dwarf2_create_include_psymtab)
4771         (dwarf2_build_include_psymtabs, create_type_unit_group)
4772         (create_partial_symtab, process_psymtab_comp_unit_reader)
4773         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
4774         (set_partial_user): Use dwarf2_psymtab.
4775         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
4776         (psymtab_to_symtab_1, process_full_comp_unit)
4777         (process_full_type_unit, dwarf2_ranges_read)
4778         (dwarf2_get_pc_bounds, psymtab_include_file_name)
4779         (dwarf_decode_lines): Use dwarf2_psymtab.
4780         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
4781         (add_address_entry_worker, write_one_signatured_type)
4782         (recursively_count_psymbols, recursively_write_psymbols)
4783         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
4784         (write_debug_names): Likewise.
4785         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
4786         <pst>: Now a legacy_psymtab.
4787         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
4788         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
4789         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
4790         * ctfread.c (struct ctf_psymtab): New.
4791         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
4792         ctf_psymtab.
4793         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
4794         (create_partial_symtab): Return a ctf_psymtab.
4795         (scan_partial_symbols): Update.
4796
4797 2020-01-26  Tom Tromey  <tom@tromey.com>
4798
4799         * xcoffread.c (xcoff_start_psymtab): Use new.
4800         * psymtab.c (partial_symtab::partial_symtab): New constructor,
4801         renamed from start_psymtab_common.
4802         * psympriv.h (struct partial_symtab): Add new constructor.
4803         (start_psymtab_common): Don't declare.
4804         * mdebugread.c (parse_partial_symbols): Use new.
4805         * dwarf2read.c (create_partial_symtab): Use new.
4806         * dbxread.c (start_psymtab): Use new.
4807         * ctfread.c (create_partial_symtab): Use new.
4808
4809 2020-01-26  Tom Tromey  <tom@tromey.com>
4810
4811         * xcoffread.c (xcoff_end_psymtab): Use new.
4812         * psymtab.c (start_psymtab_common): Use new.
4813         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
4814         Update.
4815         * psympriv.h (struct partial_symtab): Add parameters to
4816         constructor.  Don't inline.
4817         (allocate_psymtab): Don't declare.
4818         * mdebugread.c (new_psymtab): Use new.
4819         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
4820         * dbxread.c (dbx_end_psymtab): Use new.
4821
4822 2020-01-26  Tom Tromey  <tom@tromey.com>
4823
4824         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
4825         allocate_psymtab.  Update documentation.
4826         * psymtab.c (psymtab_storage::install_psymtab): Rename from
4827         allocate_psymtab.  Do not use new.
4828         (allocate_psymtab): Use new.  Update.
4829
4830 2020-01-26  Tom Tromey  <tom@tromey.com>
4831
4832         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
4833         * psymtab.c (psym_print_stats): Update.
4834         * psympriv.h (struct partial_symtab) <readin,
4835         psymtabs_addrmap_supported, anonymous>: Now bool.
4836         * mdebugread.c (psymtab_to_symtab_1): Update.
4837         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
4838         (build_type_psymtabs_reader, psymtab_to_symtab_1)
4839         (process_full_comp_unit, process_full_type_unit): Update.
4840         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
4841         * ctfread.c (psymtab_to_symtab): Update.
4842
4843 2020-01-26  Tom Tromey  <tom@tromey.com>
4844
4845         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
4846         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
4847         * psymtab.c (psymtab_storage): Delete psymtabs.
4848         (psymtab_storage::allocate_psymtab): Use new.
4849         (psymtab_storage::discard_psymtab): Use delete.
4850         * psympriv.h (struct partial_symtab): Add constructor and
4851         initializers.
4852
4853 2020-01-26  Tom Tromey  <tom@tromey.com>
4854
4855         * machoread.c: Do not include psympriv.h.
4856
4857 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4858
4859         * NEWS: Mention the new option and the set/show commands.
4860
4861 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4862
4863         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
4864         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
4865         (validate_exec_file): New variables, enums, functions.
4866         (exec_file_locate_attach, print_section_info): Style the filenames.
4867         (_initialize_exec): Install show_exec_file_mismatch_command and
4868          set_exec_file_mismatch_command.
4869         * gdbcore.h (validate_exec_file): Declare.
4870         * infcmd.c (attach_command): Call validate_exec_file.
4871         * remote.c ( remote_target::remote_add_inferior): Likewise.
4872
4873 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * frame.c (find_frame_sal): Move call to get_next_frame into more
4876         inner scope.
4877         * inline-frame.c (inilne_state) <inline_state>: Update argument
4878         types.
4879         (inilne_state) <skipped_symbol>: Rename to...
4880         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
4881         (skip_inline_frames): Build vector of skipped symbols and use this
4882         to reate the inline_state.
4883         (inline_skipped_symbol): Add a comment and some assertions, fetch
4884         skipped symbol from the list.
4885
4886 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4887
4888         * buildsym.c (lte_is_less_than): Delete.
4889         (buildsym_compunit::end_symtab_with_blockvector): Create local
4890         lambda function to sort line table entries, and use
4891         std::stable_sort instead of std::sort.
4892         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
4893         markers when looking for a previous line.
4894
4895 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4896
4897         * dwarf2read.c (lnp_state_machine::record_line): Include
4898         end_sequence parameter in debug print out.  Record the line if we
4899         are at an end_sequence marker even if it's not the start of a
4900         statement.
4901         * symmisc.c (maintenance_print_one_line_table): Print end of
4902         sequence markers with 'END' not '0'.
4903
4904 2020-01-24  Pedro Alves  <palves@redhat.com>
4905
4906         PR gdb/25410
4907         * thread.c (scoped_restore_current_thread::restore): Use
4908         switch_to_inferior_no_thread.
4909         * exec.c: Include "progspace-and-thread.h".
4910         (add_target_sections, remove_target_sections):
4911         scoped_restore_current_pspace_and_thread instead of
4912         scoped_restore_current_thread.
4913         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
4914         and aspace to the inferior before calling clone_program_space.
4915         Remove stale comment.
4916
4917 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4918
4919         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
4920         (arm_netbsd_nat_target::fetch_registers): ...this.
4921         (arm_nbsd_nat_target::store_registers): Rename to...
4922         (arm_netbsd_nat_target::store_registers): ...this.
4923
4924 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4925
4926         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
4927         register_t.
4928
4929 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4930
4931         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
4932         Update comment.
4933         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
4934         Likewise.
4935         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
4936         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
4937         the correct replacement (iterate_over_regset_sections).
4938         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
4939         Update comment.
4940
4941 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
4942
4943         PR gdb/23718
4944         * gdb/python/python.c (execute_gdb_command): Call
4945         async_enable_stdin in catch block.
4946
4947 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
4950         SWITCH_THRU_ALL_UIS.
4951
4952 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         PR tui/9765
4955         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
4956         comment, add extra parameter, and update to store previous symbol
4957         when appropriate.
4958         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
4959         add extra parameter.
4960         * tui/tui-disasm.c (tui_disassemble): Update header comment,
4961         remove unneeded parameter, add try/catch around gdb_print_insn,
4962         rewrite to add items to asm_lines vector.
4963         (tui_find_backward_disassembly_start_address): New function.
4964         (tui_find_disassembly_address): Updated throughout.
4965         (tui_disasm_window::set_contents): Update for changes to
4966         tui_disassemble.
4967         (tui_disasm_window::do_scroll_vertical): No need to adjust the
4968         number of lines to scroll.
4969
4970 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
4971
4972         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
4973         (SECT_OFF_DATA): Likewise.
4974         (SECT_OFF_RODATA): Likewise.
4975         (SECT_OFF_TEXT): Likewise.
4976         (SECT_OFF_BSS): Likewise.
4977         (struct objfile) <text_section_offset, data_section_offset>: New
4978         methods.
4979         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
4980         objfile::text_section_offset.
4981         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
4982         * coffread.c (coff_symtab_read): Likewise.
4983         (enter_linenos): Likewise.
4984         (process_coff_symbol): Likewise.
4985         * ctfread.c (get_objfile_text_range): Likewise.
4986         * dtrace-probe.c (dtrace_probe::get_relocated_address):
4987         Use objfile::data_section_offset.
4988         * dwarf2-frame.c (execute_cfa_program): Use
4989         objfile::text_section_offset.
4990         (dwarf2_frame_find_fde): Likewise.
4991         * dwarf2read.c (create_addrmap_from_index): Likewise.
4992         (create_addrmap_from_aranges): Likewise.
4993         (dw2_find_pc_sect_compunit_symtab): Likewise.
4994         (process_psymtab_comp_unit_reader): Likewise.
4995         (add_partial_symbol): Likewise.
4996         (add_partial_subprogram): Likewise.
4997         (process_full_comp_unit): Likewise.
4998         (read_file_scope): Likewise.
4999         (read_func_scope): Likewise.
5000         (read_lexical_block_scope): Likewise.
5001         (read_call_site_scope): Likewise.
5002         (dwarf2_rnglists_process): Likewise.
5003         (dwarf2_ranges_process): Likewise.
5004         (dwarf2_ranges_read): Likewise.
5005         (dwarf_decode_lines_1): Likewise.
5006         (new_symbol): Likewise.
5007         (dwarf2_fetch_die_loc_sect_off): Likewise.
5008         (dwarf2_per_cu_text_offset): Likewise.
5009         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5010         * hppa-tdep.c (read_unwind_info): Likewise.
5011         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5012         * psympriv.h (struct partial_symtab): Likewise.
5013         * psymtab.c (find_pc_sect_psymtab): Likewise.
5014         * solib-svr4.c (enable_break): Likewise.
5015         * stap-probe.c (relocate_address): Use
5016         objfile::data_section_offset.
5017         * xcoffread.c (enter_line_range): Use
5018         objfile::text_section_offset.
5019         (read_xcoff_symtab): Likewise.
5020
5021 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5022
5023         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5024         declaration to narrower scopes.
5025
5026 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5027
5028         * darwin-nat.h (struct darwin_exception_msg, enum
5029         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5030         Move up.
5031         (class darwin_nat_target) <wait_1, check_new_threads,
5032         decode_exception_message, decode_message, stop_inferior,
5033         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5034         * darwin-nat.c (darwin_check_new_threads): Rename to...
5035         (darwin_nat_target::check_new_threads): ... this.
5036         (darwin_suspend_inferior_it): Remove.
5037         (darwin_decode_exception_message): Rename to...
5038         (darwin_nat_target::decode_exception_message): ... this.
5039         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5040         (darwin_decode_message): Rename to...
5041         (darwin_nat_target::decode_message): ... this.
5042         (cancel_breakpoint): Rename to...
5043         (darwin_nat_target::cancel_breakpoint): ... this.
5044         (darwin_wait): Rename to...
5045         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5046         instead of iterate_over_inferiors.
5047         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5048         (darwin_stop_inferior): Rename to...
5049         (darwin_nat_target::stop_inferior): ... this.
5050         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5051         (darwin_init_thread_list): Rename to...
5052         (darwin_nat_target::init_thread_list): ... this.
5053         (darwin_ptrace_him): Rename to...
5054         (darwin_nat_target::ptrace_him): ... this.
5055         (darwin_nat_target::create_inferior): Pass lambda function to
5056         fork_inferior.
5057         (darwin_nat_target::detach): Call stop_inferior instead of
5058         darwin_stop_inferior.
5059         * fork-inferior.h (fork_inferior): Change init_trace_fun
5060         parameter to gdb::function_view.
5061         * fork-inferior.c (fork_inferior): Likewise.
5062
5063 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5064
5065         * i386-cygwin-tdep.c (core_process_module_section): Update.
5066         * windows-nat.c (struct lm_info_windows): Add text_offset.
5067         (windows_xfer_shared_libraries): Update.
5068         * windows-tdep.c (windows_xfer_shared_library):
5069         Add text_offset_cached argument.
5070         * windows-tdep.h (windows_xfer_shared_library): Update.
5071
5072 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5073
5074         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5075
5076 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5077
5078         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5079         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5080         replace with range-based for.
5081         (gdbsim_interrupt_inferior): Remove.
5082         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5083         with a range-based for.  Inline code from
5084         gdbsim_interrupt_inferior.
5085
5086 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5087
5088         * infrun.c (proceed): Fix indentation.
5089
5090 2020-01-21  Tom Tromey  <tromey@adacore.com>
5091
5092         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5093         * python/python.c (python_extension_ops): Update.
5094         (gdbpy_colorize): New function.
5095         * python/lib/gdb/__init__.py (colorize): New function.
5096         * extension.h (ext_lang_colorize): Declare.
5097         * extension.c (ext_lang_colorize): New function.
5098         * extension-priv.h (struct extension_language_ops) <colorize>: New
5099         member.
5100         * cli/cli-style.c (_initialize_cli_style): Update help text.
5101
5102 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5103
5104         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5105         <cond>: Change type to bool.
5106         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5107         (aarch64_displaced_step_cb): Likewise.
5108         (aarch64_displaced_step_tb): Likewise.
5109
5110 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5111
5112         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5113         output.
5114
5115 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5116
5117         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5118         <pc_adjust>: Adjust the documentation.
5119         (aarch64_displaced_step_fixup): Check if PC really moved before
5120         adjusting it.
5121
5122 2020-01-19  Tom Tromey  <tom@tromey.com>
5123
5124         * disasm.c (~gdb_disassembler): New destructor.
5125         (gdb_buffered_insn_length): Call disassemble_free_target.
5126         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5127         DISABLE_COPY_AND_ASSIGN.
5128
5129 2020-01-19  Tom Tromey  <tom@tromey.com>
5130
5131         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5132         (die_reader_func_ftype): Remove.
5133         (cutu_reader): New class.
5134         (dw2_get_file_names_reader): Remove "data" parameter.
5135         (dw2_get_file_names): Use cutu_reader.
5136         (create_debug_type_hash_table): Update.
5137         (read_cutu_die_from_dwo): Update comment.
5138         (lookup_dwo_unit): Add dwo_name parameter.
5139         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5140         die_reader_func_ftype and data parameters.
5141         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5142         Remove die_reader_func_ftype and data parameters.
5143         (~cutu_reader): New; from init_cutu_and_read_dies.
5144         (cutu_reader::cutu_reader): Rename from
5145         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5146         and data parameters.
5147         (init_cutu_and_read_dies_simple): Remove.
5148         (struct process_psymtab_comp_unit_data): Remove.
5149         (process_psymtab_comp_unit_reader): Remove data parameter; add
5150         want_partial_unit and pretend_language parameters.
5151         (process_psymtab_comp_unit): Use cutu_reader.
5152         (build_type_psymtabs_reader): Remove data parameter.
5153         (build_type_psymtabs_1): Use cutu_reader.
5154         (process_skeletonless_type_unit): Likewise.
5155         (load_partial_comp_unit_reader): Remove.
5156         (load_partial_comp_unit): Use cutu_reader.
5157         (load_full_comp_unit_reader): Remove.
5158         (load_full_comp_unit): Use cutu_reader.
5159         (struct create_dwo_cu_data): Remove.
5160         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5161         dwo_unit parameters.
5162         (create_cus_hash_table): Use cutu_reader.
5163         (struct dwarf2_read_addr_index_data): Remove.
5164         (dwarf2_read_addr_index_reader): Remove.
5165         (dwarf2_read_addr_index): Use cutu_reader.
5166         (read_signatured_type_reader): Remove.
5167         (read_signatured_type): Use cutu_reader.
5168
5169 2020-01-19  Tom Tromey  <tom@tromey.com>
5170
5171         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5172         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5173         (tui_wrefresh): Declare.
5174         * tui/tui-wingeneral.c (suppress_output): New global.
5175         (tui_suppress_output, ~tui_suppress_output): New constructor and
5176         destructor.
5177         (tui_wrefresh): New function.
5178         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5179         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5180         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5181         method.
5182         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5183         tui_wrefresh.
5184         (tui_data_window::no_refresh): New method.
5185         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5186         (tui_reg_command): Use tui_suppress_output
5187         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5188         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5189         method.
5190         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5191
5192 2020-01-19  Tom Tromey  <tom@tromey.com>
5193
5194         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5195         Handle case where symtab is null.
5196
5197 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5198
5199         * linux-fork.c (one_fork_p): Simplify.
5200
5201 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5202
5203         * top.c (struct qt_args): Remove.
5204         (kill_or_detach): Change return type to void, replace `void *`
5205         parameter with a proper one.
5206         (print_inferior_quit_action):  Likewise.
5207         (quit_confirm): Use range-based for loop to iterate over inferiors.
5208         (quit_force): Likewise.
5209
5210 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5211
5212         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5213         `void *` parameter with proper parameters.
5214         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5215         (print_one_inferior): Change return type to void, replace `void *`
5216         parameter with proper parameters.
5217         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5218         inferiors.
5219         (get_other_inferior): Remove.
5220         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5221         inferiors.
5222
5223 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5224
5225         * mi/mi-interp.c (report_initial_inferior): Remove.
5226         (mi_interp::init): Use range-based for to iterate over inferiors.
5227
5228 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5229
5230         * python/py-inferior.c (build_inferior_list): Remove.
5231         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5232
5233 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5234
5235         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5236         (btrace_stitch_trace): Likewise.
5237         * charset.c (intermediate_encoding): Likewise (vaild).
5238         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5239         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5240         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5241
5242 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5243
5244         * windows-tdep.c (windows_get_tlb_type):
5245         Add rtl_user_process_parameters type.
5246
5247 2020-01-16  Pedro Alves  <palves@redhat.com>
5248             Norbert Lange  <nolange79@gmail.com>
5249
5250         PR build/24805
5251         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5252         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5253         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5254         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5255         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5256         (ps_plog): Redeclare exported functions with default visibility.
5257
5258 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5259
5260         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5261         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5262
5263 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5264
5265         * infcmd.c (post_create_inferior): Use get_thread_regcache
5266         instead of get_current_regcache.
5267
5268 2020-01-14  Tom Tromey  <tom@tromey.com>
5269
5270         PR symtab/12535:
5271         * python/python.c (gdbpy_decode_line): Treat empty string the same
5272         as no argument.
5273
5274 2020-01-14  Tom Tromey  <tom@tromey.com>
5275
5276         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5277
5278 2020-01-14  Tom Tromey  <tom@tromey.com>
5279
5280         * nat/linux-btrace.c: Don't include <config.h>.
5281         * nat/linux-ptrace.c: Don't include <config.h>.
5282         * nat/x86-linux-dregs.c: Don't include <config.h>.
5283
5284 2020-01-14  Tom Tromey  <tom@tromey.com>
5285
5286         * configure: Rebuild.
5287         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5288
5289 2020-01-14  Tom Tromey  <tom@tromey.com>
5290
5291         * nat/x86-linux-dregs.c: Include configh.h.
5292         * nat/linux-ptrace.c: Include configh.h.
5293         * nat/linux-btrace.c: Include configh.h.
5294         * defs.h: Include config.h, bfd.h.
5295         * configure.ac: Don't source common.host.
5296         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5297         * configure: Rebuild.
5298         * acinclude.m4: Update path.
5299         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5300         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5301         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5302         (CLIBS): Add LIBSUPPORT.
5303         (CDEPS): Likewise.
5304         (COMMON_SFILES): Remove gdbsupport files.
5305         (HFILES_NO_SRCDIR): Likewise.
5306         (stamp-version): Update path to create-version.sh.
5307         (ALLDEPFILES): Remove gdbsupport files.
5308
5309 2020-01-14  Tom Tromey  <tom@tromey.com>
5310
5311         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5312         USE_WIN32API when needed.
5313         * configure.ac (USE_WIN32API): Don't define.
5314         (WIN32LIBS): Use WIN32APILIBS.
5315         * configure: Rebuild.
5316
5317 2020-01-14  Tom Tromey  <tom@tromey.com>
5318
5319         * configure: Rebuild.
5320         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5321
5322 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5323
5324         * skip.c (skip_function_command): Make skip w/o arguments use the
5325         name of the inlined function if pc is inside any inlined function.
5326
5327 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5328
5329         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5330         * infrun.c (resume_1): Likewise.
5331         (handle_inferior_event): Remove stale comment.
5332         * linux-nat.c (linux_nat_target::resume): Update comments.
5333         (save_stop_reason): Likewise.
5334         (linux_nat_filter_event): Likewise.
5335         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5336
5337 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5338
5339         * elfread.c (record_minimal_symbol): Set section index to 0 for
5340         non-allocatable sections.
5341
5342
5343 2020-01-13  Ali Tamur <tamur@google.com>
5344
5345         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5346         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5347         to gdb::optional.  Update comments.
5348         (dwo_file): Update comments.
5349         (read_attribute): Update API to take an additional out parameter,
5350         need_reprocess.  This is used to mark attributes that need other
5351         attributes (e.g. str_offsets_base) for correct computation which may not
5352         have been read yet.
5353         (read_attribute_reprocess): New function declaration.
5354         (read_addr_index): Likewise.
5355         (read_dwo_str_index): Likewise.
5356         (read_stub_str_index): Likewise.
5357         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5358         (lookup_addr_base): New function definition.
5359         (lookup_ranges_base): Likewise.
5360         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5361         lookup_ranges_base.
5362         (init_cutu_and_read_dies): Update comments.
5363         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5364         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5365         Update comments.
5366         (init_cutu_and_read_dies_simple): Reflect API changes.
5367         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5368         (create_cus_hash_table): Change API to take parent compile unit.
5369         Reflect API changes.
5370         (open_and_init_dwo_file): Reflect API changes.
5371         (dwarf2_get_pc_bounds): Update comments.
5372         (dwarf2_record_block_ranges): Likewise.
5373         (read_full_die_1): Change implementation to reprocess attributes that
5374         need str_offsets_base and addr_base.
5375         (partial_die_info::read): Likewise.
5376         (read_attribute_reprocess): New function definition.
5377         (read_attribute_value): Change API to take an additional out parameter,
5378         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5379         when a non-dwo compile unit has index based attributes.
5380         (read_attribute): Reflect API changes.
5381         (read_addr_index_1): Reflect API changes.  Update comments.
5382         (dwarf2_read_addr_index_data): Reflect API changes.
5383         (dwarf2_read_addr_index): Likewise.
5384         (read_str_index): Change API and implementation.  This becomes a helper
5385         to be used by the new string index related methods.  Update error
5386         message and comments.
5387         (read_dwo_str_index): New function definition.
5388         (read_stub_str_index): Likewise.
5389         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5390         * symfile.h (dwarf2_debug_sections): Likewise.
5391         * xcoffread.c (dwarf2_debug_sections): Likewise.
5392
5393 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5394
5395         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5396         core_reg_sect type to gdb_byte *.
5397         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5398         * cris-tdep.c (fetch_core_registers): Likewise.
5399         * corelow.c (core_target::get_core_register_section): Change
5400         type of `contents` to gdb::byte_vector.
5401
5402 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5403
5404         * tui/tui-wingeneral.c (box_win): Position the title in the center
5405         of the border.
5406
5407 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5408
5409         * corelow.c (core_target::get_core_register_section): Use
5410           std::vector instead of alloca.
5411
5412 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5413
5414         * warning.m4: Add -Wmissing-declarations to build_warnings.
5415         * configure: Re-generate.
5416
5417 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5418
5419         * python/python.c (init__gdb_module): Add declaration.
5420
5421 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5422
5423         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5424         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5425         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5426         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5427         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5428         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5429         * ada-exp.y (_initialize_ada_exp): Add declaration.
5430         * ada-lang.c (_initialize_ada_language): Add declaration.
5431         * ada-tasks.c (_initialize_tasks): Add declaration.
5432         * agent.c (_initialize_agent): Add declaration.
5433         * aix-thread.c (_initialize_aix_thread): Add declaration.
5434         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5435         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5436         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5437         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5438         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5439         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5440         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5441         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5442         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5443         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5444         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5445         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5446         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5447         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5448         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5449         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5450         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5451         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5452         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5453         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5454         * annotate.c (_initialize_annotate): Add declaration.
5455         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5456         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5457         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5458         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5459         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5460         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5461         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5462         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5463         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5464         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5465         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5466         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5467         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5468         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5469         * auto-load.c (_initialize_auto_load): Add declaration.
5470         * auxv.c (_initialize_auxv): Add declaration.
5471         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5472         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5473         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5474         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5475         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5476         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5477         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5478         * breakpoint.c (_initialize_breakpoint): Add declaration.
5479         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5480         * btrace.c (_initialize_btrace): Add declaration.
5481         * charset.c (_initialize_charset): Add declaration.
5482         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5483         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5484         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5485         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5486         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5487         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5488         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5489         * coffread.c (_initialize_coffread): Add declaration.
5490         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5491         * compile/compile.c (_initialize_compile): Add declaration.
5492         * complaints.c (_initialize_complaints): Add declaration.
5493         * completer.c (_initialize_completer): Add declaration.
5494         * copying.c (_initialize_copying): Add declaration.
5495         * corefile.c (_initialize_core): Add declaration.
5496         * corelow.c (_initialize_corelow): Add declaration.
5497         * cp-abi.c (_initialize_cp_abi): Add declaration.
5498         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5499         * cp-support.c (_initialize_cp_support): Add declaration.
5500         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5501         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5502         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5503         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5504         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5505         * ctfread.c (_initialize_ctfread): Add declaration.
5506         * d-lang.c (_initialize_d_language): Add declaration.
5507         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
5508         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
5509         * dbxread.c (_initialize_dbxread): Add declaration.
5510         * dcache.c (_initialize_dcache): Add declaration.
5511         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
5512         * disasm.c (_initialize_disasm): Add declaration.
5513         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
5514         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
5515         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
5516         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
5517         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
5518         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
5519         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
5520         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
5521         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
5522         * elfread.c (_initialize_elfread): Add declaration.
5523         * exec.c (_initialize_exec): Add declaration.
5524         * extension.c (_initialize_extension): Add declaration.
5525         * f-lang.c (_initialize_f_language): Add declaration.
5526         * f-valprint.c (_initialize_f_valprint): Add declaration.
5527         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
5528         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
5529         * filesystem.c (_initialize_filesystem): Add declaration.
5530         * findcmd.c (_initialize_mem_search): Add declaration.
5531         * findvar.c (_initialize_findvar): Add declaration.
5532         * fork-child.c (_initialize_fork_child): Add declaration.
5533         * frame-base.c (_initialize_frame_base): Add declaration.
5534         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
5535         * frame.c (_initialize_frame): Add declaration.
5536         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
5537         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
5538         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
5539         * gcore.c (_initialize_gcore): Add declaration.
5540         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
5541         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
5542         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
5543         * gdbarch.c (_initialize_gdbarch): Add declaration.
5544         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
5545         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
5546         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
5547         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
5548         * go-lang.c (_initialize_go_language): Add declaration.
5549         * go32-nat.c (_initialize_go32_nat): Add declaration.
5550         * guile/guile.c (_initialize_guile): Add declaration.
5551         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
5552         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
5553         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
5554         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
5555         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
5556         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
5557         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
5558         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
5559         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
5560         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
5561         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
5562         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
5563         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
5564         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
5565         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
5566         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
5567         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
5568         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
5569         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
5570         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
5571         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
5572         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
5573         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
5574         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
5575         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
5576         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
5577         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
5578         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
5579         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
5580         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
5581         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
5582         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
5583         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
5584         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
5585         * infcall.c (_initialize_infcall): Add declaration.
5586         * infcmd.c (_initialize_infcmd): Add declaration.
5587         * inflow.c (_initialize_inflow): Add declaration.
5588         * infrun.c (_initialize_infrun): Add declaration.
5589         * interps.c (_initialize_interpreter): Add declaration.
5590         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
5591         * jit.c (_initialize_jit): Add declaration.
5592         * language.c (_initialize_language): Add declaration.
5593         * linux-fork.c (_initialize_linux_fork): Add declaration.
5594         * linux-nat.c (_initialize_linux_nat): Add declaration.
5595         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
5596         * linux-thread-db.c (_initialize_thread_db): Add declaration.
5597         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
5598         * m2-lang.c (_initialize_m2_language): Add declaration.
5599         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
5600         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
5601         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
5602         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
5603         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
5604         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
5605         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
5606         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
5607         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
5608         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
5609         * machoread.c (_initialize_machoread): Add declaration.
5610         * macrocmd.c (_initialize_macrocmd): Add declaration.
5611         * macroscope.c (_initialize_macroscope): Add declaration.
5612         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
5613         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
5614         * maint.c (_initialize_maint_cmds): Add declaration.
5615         * mdebugread.c (_initialize_mdebugread): Add declaration.
5616         * memattr.c (_initialize_mem): Add declaration.
5617         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
5618         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
5619         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
5620         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
5621         * mi/mi-main.c (_initialize_mi_main): Add declaration.
5622         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
5623         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
5624         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
5625         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
5626         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
5627         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
5628         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
5629         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
5630         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
5631         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
5632         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
5633         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
5634         * mipsread.c (_initialize_mipsread): Add declaration.
5635         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
5636         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
5637         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
5638         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
5639         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
5640         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
5641         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
5642         * nto-procfs.c (_initialize_procfs): Add declaration.
5643         * objc-lang.c (_initialize_objc_language): Add declaration.
5644         * observable.c (_initialize_observer): Add declaration.
5645         * opencl-lang.c (_initialize_opencl_language): Add declaration.
5646         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
5647         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
5648         * osabi.c (_initialize_gdb_osabi): Add declaration.
5649         * osdata.c (_initialize_osdata): Add declaration.
5650         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
5651         * parse.c (_initialize_parse): Add declaration.
5652         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
5653         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
5654         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
5655         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
5656         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
5657         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
5658         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
5659         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
5660         * printcmd.c (_initialize_printcmd): Add declaration.
5661         * probe.c (_initialize_probe): Add declaration.
5662         * proc-api.c (_initialize_proc_api): Add declaration.
5663         * proc-events.c (_initialize_proc_events): Add declaration.
5664         * proc-service.c (_initialize_proc_service): Add declaration.
5665         * procfs.c (_initialize_procfs): Add declaration.
5666         * producer.c (_initialize_producer): Add declaration.
5667         * psymtab.c (_initialize_psymtab): Add declaration.
5668         * python/python.c (_initialize_python): Add declaration.
5669         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
5670         * record-btrace.c (_initialize_record_btrace): Add declaration.
5671         * record-full.c (_initialize_record_full): Add declaration.
5672         * record.c (_initialize_record): Add declaration.
5673         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
5674         * regcache.c (_initialize_regcache): Add declaration.
5675         * reggroups.c (_initialize_reggroup): Add declaration.
5676         * remote-notif.c (_initialize_notif): Add declaration.
5677         * remote-sim.c (_initialize_remote_sim): Add declaration.
5678         * remote.c (_initialize_remote): Add declaration.
5679         * reverse.c (_initialize_reverse): Add declaration.
5680         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
5681         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
5682         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
5683         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
5684         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
5685         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
5686         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
5687         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
5688         Add declaration.
5689         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
5690         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
5691         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
5692         * rust-exp.y (_initialize_rust_exp): Add declaration.
5693         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
5694         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
5695         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
5696         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
5697         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
5698         * score-tdep.c (_initialize_score_tdep): Add declaration.
5699         * ser-go32.c (_initialize_ser_dos): Add declaration.
5700         * ser-mingw.c (_initialize_ser_windows): Add declaration.
5701         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
5702         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
5703         * ser-uds.c (_initialize_ser_socket): Add declaration.
5704         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
5705         * serial.c (_initialize_serial): Add declaration.
5706         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
5707         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
5708         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
5709         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
5710         * skip.c (_initialize_step_skip): Add declaration.
5711         * sol-thread.c (_initialize_sol_thread): Add declaration.
5712         * solib-aix.c (_initialize_solib_aix): Add declaration.
5713         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
5714         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
5715         * solib-frv.c (_initialize_frv_solib): Add declaration.
5716         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
5717         * solib-target.c (_initialize_solib_target): Add declaration.
5718         * solib.c (_initialize_solib): Add declaration.
5719         * source-cache.c (_initialize_source_cache): Add declaration.
5720         * source.c (_initialize_source): Add declaration.
5721         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
5722         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
5723         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
5724         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
5725         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
5726         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
5727         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
5728         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
5729         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
5730         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
5731         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
5732         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
5733         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
5734         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
5735         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
5736         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
5737         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
5738         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
5739         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
5740         * stabsread.c (_initialize_stabsread): Add declaration.
5741         * stack.c (_initialize_stack): Add declaration.
5742         * stap-probe.c (_initialize_stap_probe): Add declaration.
5743         * std-regs.c (_initialize_frame_reg): Add declaration.
5744         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
5745         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
5746         * symfile.c (_initialize_symfile): Add declaration.
5747         * symmisc.c (_initialize_symmisc): Add declaration.
5748         * symtab.c (_initialize_symtab): Add declaration.
5749         * target.c (_initialize_target): Add declaration.
5750         * target-connection.c (_initialize_target_connection): Add
5751         declaration.
5752         * target-dcache.c (_initialize_target_dcache): Add declaration.
5753         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
5754         * thread.c (_initialize_thread): Add declaration.
5755         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
5756         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
5757         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
5758         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
5759         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
5760         * tracectf.c (_initialize_ctf): Add declaration.
5761         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
5762         * tracefile.c (_initialize_tracefile): Add declaration.
5763         * tracepoint.c (_initialize_tracepoint): Add declaration.
5764         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
5765         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
5766         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
5767         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
5768         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
5769         * tui/tui-win.c (_initialize_tui_win): Add declaration.
5770         * tui/tui.c (_initialize_tui): Add declaration.
5771         * typeprint.c (_initialize_typeprint): Add declaration.
5772         * ui-style.c (_initialize_ui_style): Add declaration.
5773         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
5774         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
5775         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
5776         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
5777         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
5778         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
5779         * unittests/filtered_iterator-selftests.c
5780         (_initialize_filtered_iterator_selftests): Add declaration.
5781         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
5782         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
5783         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
5784         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
5785         * unittests/main-thread-selftests.c
5786         (_initialize_main_thread_selftests): Add declaration.
5787         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
5788         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
5789         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
5790         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
5791         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
5792         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
5793         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
5794         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
5795         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
5796         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
5797         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
5798         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
5799         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
5800         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
5801         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
5802         declaration.
5803         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
5804         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
5805         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
5806         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
5807         * user-regs.c (_initialize_user_regs): Add declaration.
5808         * utils.c (_initialize_utils): Add declaration.
5809         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
5810         * valops.c (_initialize_valops): Add declaration.
5811         * valprint.c (_initialize_valprint): Add declaration.
5812         * value.c (_initialize_values): Add declaration.
5813         * varobj.c (_initialize_varobj): Add declaration.
5814         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
5815         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
5816         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
5817         * windows-nat.c (_initialize_windows_nat): Add declaration.
5818         (_initialize_check_for_gdb_ini): Add declaration.
5819         (_initialize_loadable): Add declaration.
5820         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
5821         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
5822         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
5823         * xcoffread.c (_initialize_xcoffread): Add declaration.
5824         * xml-support.c (_initialize_xml_support): Add declaration.
5825         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
5826         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
5827         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
5828         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
5829
5830 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5831
5832         * regformats/regdat.sh: Generate declaration for init function.
5833
5834 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5835
5836         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
5837         up.
5838         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
5839         close_one_inferior>: New methods.
5840         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
5841         pass down target to find_inferior_pid.
5842         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
5843         Pass down target to find_inferior_ptid.
5844         (gdbsim_target::create_inferior): Pass down target to
5845         add_thread_silent.
5846         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
5847         target down to find_inferior_ptid and switch_to_thread.
5848         (gdbsim_target::close): Update to call close_one_inferior.
5849         (struct resume_data): Remove.
5850         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
5851         directly, rather than through a void pointer.
5852         (gdbsim_target::resume): Update to call resume_one_inferior.
5853
5854 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
5855
5856         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
5857
5858 2020-01-12  Pedro Alves  <palves@redhat.com>
5859
5860         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
5861         directly for the current inferior instead of
5862         discard_all_inferiors.
5863         (discard_all_inferiors): Delete.
5864
5865 2020-01-11  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-wingeneral.c (box_win): Check cli_styling.
5868         * tui/tui-winsource.c (tui_source_window_base::refill): Use
5869         deprecated_safe_get_selected_frame.
5870
5871 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5872
5873         * inferior.c (print_inferior): Switch inferior before printing it.
5874
5875 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
5876             Pedro Alves  <palves@redhat.com>
5877
5878         * progspace-and-thread.c (switch_to_program_space_and_thread):
5879         Assert there's an inferior for PSPACE.  Use
5880         switch_to_inferior_no_thread to switch the inferior too.
5881         * progspace.c (program_space::~program_space): Call
5882         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
5883         (program_space::free_all_objfiles): Don't call clear_symtab_users
5884         here.
5885         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
5886
5887 2020-01-10  Pedro Alves  <palves@redhat.com>
5888
5889         * NEWS: Mention multi-target debugging, "info connections", and
5890         "add-inferior -no-connection".
5891
5892 2020-01-10  Pedro Alves  <palves@redhat.com>
5893
5894         * infrun.c: Include "target-connection.h".
5895         (check_multi_target_resumption): New.
5896         (proceed): Call it.
5897         * target-connection.c (make_target_connection_string): Make
5898         extern.
5899         * target-connection.h (make_target_connection_string): Declare.
5900
5901 2020-01-10  Pedro Alves  <palves@redhat.com>
5902
5903         * Makefile.in (COMMON_SFILES): Add target-connection.c.
5904         * inferior.c (uiout_field_connection): New function.
5905         (print_inferior): Add new "connection-id" column.
5906         (add_inferior_command): Show connection number/string of added
5907         inferior.
5908         * process-stratum-target.h
5909         (process_stratum_target::connection_string): New virtual method.
5910         (process_stratum_target::connection_number): New field.
5911         * remote.c (remote_target::connection_string): New override.
5912         * target-connection.c: New file.
5913         * target-connection.h: New file.
5914         * target.c (decref_target): Remove process_stratum targets from
5915         the connection list.
5916         (target_stack::push): Add process_stratum targets to the
5917         connection list.
5918
5919 2020-01-10  Pedro Alves  <palves@redhat.com>
5920
5921         Revert:
5922         2016-04-12  Pedro Alves  <palves@redhat.com>
5923         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
5924         Remove references to name.
5925         * serial.h (struct serial) <name>: Delete.
5926
5927 2020-01-10  Pedro Alves  <palves@redhat.com>
5928
5929         * gdbarch-selftests.c (register_to_value_test): Remove "target
5930         already pushed" check.
5931
5932 2020-01-10  Pedro Alves  <palves@redhat.com>
5933             John Baldwin  <jhb@FreeBSD.org>
5934
5935         * aarch64-linux-nat.c
5936         (aarch64_linux_nat_target::thread_architecture): Adjust.
5937         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
5938         (task_command_1): Likewise.
5939         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
5940         (aix_thread_target::wait, aix_thread_target::fetch_registers)
5941         (aix_thread_target::store_registers)
5942         (aix_thread_target::thread_alive): Adjust.
5943         * amd64-fbsd-tdep.c: Include "inferior.h".
5944         (amd64fbsd_get_thread_local_address): Pass down target.
5945         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
5946         thread's gdbarch instead of target_gdbarch.
5947         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
5948         get_last_target_status.
5949         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
5950         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
5951         inferiors.
5952         (update_inserted_breakpoint_locations): Skip if inferiors with no
5953         execution.
5954         (update_global_location_list): When handling moribund locations,
5955         find representative inferior for location's pspace, and use thread
5956         count of its process_stratum target.
5957         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
5958         * bsd-uthread.c (bsd_uthread_target::wait): Use
5959         as_process_stratum_target and adjust thread_change_ptid and
5960         add_thread calls.
5961         (bsd_uthread_target::update_thread_list): Use
5962         as_process_stratum_target and adjust find_thread_ptid,
5963         thread_change_ptid and add_thread calls.
5964         * btrace.c (maint_btrace_packet_history_cmd): Adjust
5965         find_thread_ptid call.
5966         * corelow.c (add_to_thread_list): Adjust add_thread call.
5967         (core_target_open): Adjust add_thread_silent and thread_count
5968         calls.
5969         (core_target::pid_to_str): Adjust find_inferior_ptid call.
5970         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
5971         * event-top.c (async_disconnect): Pop targets from all inferiors.
5972         * exec.c (add_target_sections): Push exec target on all inferiors
5973         sharing the program space.
5974         (remove_target_sections): Remove the exec target from all
5975         inferiors sharing the program space.
5976         (exec_on_vfork): New.
5977         * exec.h (exec_on_vfork): Declare.
5978         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
5979         Pass it down.
5980         (fbsd_nat_target::update_thread_list): Adjust.
5981         (fbsd_nat_target::resume): Adjust.
5982         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
5983         down.
5984         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
5985         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
5986         get_thread_arch_regcache call.
5987         * fork-child.c (gdb_startup_inferior): Pass target down to
5988         startup_inferior and set_executing.
5989         * gdbthread.h (struct process_stratum_target): Forward declare.
5990         (add_thread, add_thread_silent, add_thread_with_info)
5991         (in_thread_list): Add process_stratum_target parameter.
5992         (find_thread_ptid(inferior*, ptid_t)): New overload.
5993         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
5994         parameter.
5995         (all_threads()): Delete overload.
5996         (all_threads, all_non_exited_threads): Add process_stratum_target
5997         parameter.
5998         (all_threads_safe): Use brace initialization.
5999         (thread_count): Add process_stratum_target parameter.
6000         (set_resumed, set_running, set_stop_requested, set_executing)
6001         (threads_are_executing, finish_thread_state): Add
6002         process_stratum_target parameter.
6003         (switch_to_thread): Use is_current_thread.
6004         * i386-fbsd-tdep.c: Include "inferior.h".
6005         (i386fbsd_get_thread_local_address): Pass down target.
6006         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6007         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6008         have_inferiors check.
6009         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6010         (inf_ptrace_target::attach): Adjust.
6011         * infcall.c (run_inferior_call): Adjust.
6012         * infcmd.c (run_command_1): Pass target to
6013         scoped_finish_thread_state.
6014         (proceed_thread_callback): Skip inferiors with no execution.
6015         (continue_command): Rename 'all_threads' local to avoid hiding
6016         'all_threads' function.  Adjust get_last_target_status call.
6017         (prepare_one_step): Adjust set_running call.
6018         (signal_command): Use user_visible_resume_target.  Compare thread
6019         pointers instead of inferior_ptid.
6020         (info_program_command): Adjust to pass down target.
6021         (attach_command): Mark target's 'thread_executing' flag.
6022         (stop_current_target_threads_ns): New, factored out from ...
6023         (interrupt_target_1): ... this.  Switch inferior before making
6024         target calls.
6025         * inferior-iter.h
6026         (struct all_inferiors_iterator, struct all_inferiors_range)
6027         (struct all_inferiors_safe_range)
6028         (struct all_non_exited_inferiors_range): Filter on
6029         process_stratum_target too.  Remove explicit.
6030         * inferior.c (inferior::inferior): Push dummy target on target
6031         stack.
6032         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6033         Add process_stratum_target parameter, and pass it down.
6034         (have_live_inferiors): Adjust.
6035         (switch_to_inferior_and_push_target): New.
6036         (add_inferior_command, clone_inferior_command): Handle
6037         "-no-connection" parameter.  Use
6038         switch_to_inferior_and_push_target.
6039         (_initialize_inferior): Mention "-no-connection" option in
6040         the help of "add-inferior" and "clone-inferior" commands.
6041         * inferior.h: Include "process-stratum-target.h".
6042         (interrupt_target_1): Use bool.
6043         (struct inferior) <push_target, unpush_target, target_is_pushed,
6044         find_target_beneath, top_target, process_target, target_at,
6045         m_stack>: New.
6046         (discard_all_inferiors): Delete.
6047         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6048         (all_inferiors, all_non_exited_inferiors): Add
6049         process_stratum_target parameter.
6050         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6051         (target_last_proc_target): New global.
6052         (follow_fork_inferior): Push target on new inferior.  Pass target
6053         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6054         reference count.
6055         (follow_fork): Adjust get_last_target_status call.  Also consider
6056         target.
6057         (follow_exec): Push target on new inferior.
6058         (struct execution_control_state) <target>: New field.
6059         (user_visible_resume_target): New.
6060         (do_target_resume): Call target_async.
6061         (resume_1): Set target's threads_executing flag.  Consider resume
6062         target.
6063         (commit_resume_all_targets): New.
6064         (proceed): Also consider resume target.  Skip threads of inferiors
6065         with no execution.  Commit resumtion in all targets.
6066         (start_remote): Pass current inferior to wait_for_inferior.
6067         (infrun_thread_stop_requested): Consider target as well.  Pass
6068         thread_info pointer to clear_inline_frame_state instead of ptid.
6069         (infrun_thread_thread_exit): Consider target as well.
6070         (random_pending_event_thread): New inferior parameter.  Use it.
6071         (do_target_wait): Rename to ...
6072         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6073         down.
6074         (threads_are_resumed_pending_p, do_target_wait): New.
6075         (prepare_for_detach): Adjust calls.
6076         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6077         do_target_wait_1 instead of do_target_wait.
6078         (fetch_inferior_event): Adjust.  Switch to representative
6079         inferior.  Pass target down.
6080         (set_last_target_status): Add process_stratum_target parameter.
6081         Save target in global.
6082         (get_last_target_status): Add process_stratum_target parameter and
6083         handle it.
6084         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6085         (context_switch): Check inferior_ptid == null_ptid before calling
6086         inferior_thread().
6087         (get_inferior_stop_soon): Pass down target.
6088         (wait_one): Rename to ...
6089         (poll_one_curr_target): ... this.
6090         (struct wait_one_event): New.
6091         (wait_one): New.
6092         (stop_all_threads): Adjust.
6093         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6094         event's target.
6095         (switch_back_to_stepped_thread): Also consider target.
6096         (print_stop_event): Update.
6097         (normal_stop): Update.  Also consider the resume target.
6098         * infrun.h (wait_for_inferior): Remove declaration.
6099         (user_visible_resume_target): New declaration.
6100         (get_last_target_status, set_last_target_status): New
6101         process_stratum_target parameter.
6102         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6103         process_stratum_target parameter, and use it.
6104         (clear_inline_frame_state (thread_info*)): New.
6105         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6106         process_stratum_target parameter.
6107         (clear_inline_frame_state (thread_info*)): Declare.
6108         * linux-fork.c (delete_checkpoint_command): Pass target down to
6109         find_thread_ptid.
6110         (checkpoint_command): Adjust.
6111         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6112         instead of just tweaking inferior_ptid.
6113         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6114         (exit_lwp): Pass target down to find_thread_ptid.
6115         (attach_proc_task_lwp_callback): Pass target down to
6116         add_thread/set_running/set_executing.
6117         (linux_nat_target::attach): Pass target down to
6118         thread_change_ptid.
6119         (get_detach_signal): Pass target down to find_thread_ptid.
6120         Consider last target status's target.
6121         (linux_resume_one_lwp_throw, resume_lwp)
6122         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6123         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6124         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6125         (linux_nat_target::async_wait_fd): New.
6126         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6127         target down.
6128         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6129         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6130         * linux-thread-db.c (struct thread_db_info::process_target): New
6131         field.
6132         (add_thread_db_info): Save target.
6133         (get_thread_db_info): New process_stratum_target parameter.  Also
6134         match target.
6135         (delete_thread_db_info): New process_stratum_target parameter.
6136         Also match target.
6137         (thread_from_lwp): Adjust to pass down target.
6138         (thread_db_notice_clone): Pass down target.
6139         (check_thread_db_callback): Pass down target.
6140         (try_thread_db_load_1): Always push the thread_db target.
6141         (try_thread_db_load, record_thread): Pass target down.
6142         (thread_db_target::detach): Pass target down.  Always unpush the
6143         thread_db target.
6144         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6145         target down.  Always unpush the thread_db target.
6146         (find_new_threads_callback, thread_db_find_new_threads_2)
6147         (thread_db_target::update_thread_list): Pass target down.
6148         (thread_db_target::pid_to_str): Pass current inferior down.
6149         (thread_db_target::get_thread_local_address): Pass target down.
6150         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6151         target down.
6152         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6153         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6154         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6155         (procfs_init_inferior): Rename to ...
6156         (procfs_target::procfs_init_inferior): ... this and adjust.
6157         (procfs_target::create_inferior, procfs_notice_thread)
6158         (procfs_do_thread_registers): Adjust.
6159         * ppc-fbsd-tdep.c: Include "inferior.h".
6160         (ppcfbsd_get_thread_local_address): Pass down target.
6161         * proc-service.c (ps_xfer_memory): Switch current inferior and
6162         program space as well.
6163         (get_ps_regcache): Pass target down.
6164         * process-stratum-target.c
6165         (process_stratum_target::thread_address_space)
6166         (process_stratum_target::thread_architecture): Pass target down.
6167         * process-stratum-target.h
6168         (process_stratum_target::threads_executing): New field.
6169         (as_process_stratum_target): New.
6170         * ravenscar-thread.c
6171         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6172         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6173         down.
6174         * record-btrace.c (record_btrace_target::info_record): Adjust.
6175         (record_btrace_target::record_method)
6176         (record_btrace_target::record_is_replaying)
6177         (record_btrace_target::fetch_registers)
6178         (get_thread_current_frame_id, record_btrace_target::resume)
6179         (record_btrace_target::wait, record_btrace_target::stop): Pass
6180         target down.
6181         * record-full.c (record_full_wait_1): Switch to event thread.
6182         Pass target down.
6183         * regcache.c (regcache::regcache)
6184         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6185         process_stratum_target parameter and handle it.
6186         (current_thread_target): New global.
6187         (get_thread_regcache): Add process_stratum_target parameter and
6188         handle it.  Switch inferior before calling target method.
6189         (get_thread_regcache): Pass target down.
6190         (get_thread_regcache_for_ptid): Pass target down.
6191         (registers_changed_ptid): Add process_stratum_target parameter and
6192         handle it.
6193         (registers_changed_thread, registers_changed): Pass target down.
6194         (test_get_thread_arch_aspace_regcache): New.
6195         (current_regcache_test): Define a couple local test_target_ops
6196         instances and use them for testing.
6197         (readwrite_regcache): Pass process_stratum_target parameter.
6198         (cooked_read_test, cooked_write_test): Pass mock_target down.
6199         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6200         (get_thread_arch_aspace_regcache): Add process_stratum_target
6201         parameter.
6202         (regcache::target): New method.
6203         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6204         (regcache::registers_changed_ptid): Add process_stratum_target
6205         parameter.
6206         (regcache::m_target): New field.
6207         (registers_changed_ptid): Add process_stratum_target parameter.
6208         * remote.c (remote_state::supports_vCont_probed): New field.
6209         (remote_target::async_wait_fd): New method.
6210         (remote_unpush_and_throw): Add remote_target parameter.
6211         (get_current_remote_target): Adjust.
6212         (remote_target::remote_add_inferior): Push target.
6213         (remote_target::remote_add_thread)
6214         (remote_target::remote_notice_new_inferior)
6215         (get_remote_thread_info): Pass target down.
6216         (remote_target::update_thread_list): Skip threads of inferiors
6217         bound to other targets.  (remote_target::close): Don't discard
6218         inferiors.  (remote_target::add_current_inferior_and_thread)
6219         (remote_target::process_initial_stop_replies)
6220         (remote_target::start_remote)
6221         (remote_target::remote_serial_quit_handler): Pass down target.
6222         (remote_target::remote_unpush_target): New remote_target
6223         parameter.  Unpush the target from all inferiors.
6224         (remote_target::remote_unpush_and_throw): New remote_target
6225         parameter.  Pass it down.
6226         (remote_target::open_1): Check whether the current inferior has
6227         execution instead of checking whether any inferior is live.  Pass
6228         target down.
6229         (remote_target::remote_detach_1): Pass down target.  Use
6230         remote_unpush_target.
6231         (extended_remote_target::attach): Pass down target.
6232         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6233         (remote_target::append_resumption): Pass down target.
6234         (remote_target::append_pending_thread_resumptions)
6235         (remote_target::remote_resume_with_hc, remote_target::resume)
6236         (remote_target::commit_resume): Pass down target.
6237         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6238         (remote_target::interrupt_query)
6239         (remote_target::remove_new_fork_children)
6240         (remote_target::check_pending_events_prevent_wildcard_vcont)
6241         (remote_target::remote_parse_stop_reply)
6242         (remote_target::process_stop_reply): Pass down target.
6243         (first_remote_resumed_thread): New remote_target parameter.  Pass
6244         it down.
6245         (remote_target::wait_as): Pass down target.
6246         (unpush_and_perror): New remote_target parameter.  Pass it down.
6247         (remote_target::readchar, remote_target::remote_serial_write)
6248         (remote_target::getpkt_or_notif_sane_1)
6249         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6250         down target.
6251         (remote_target::mourn_inferior): Pass down target.  Use
6252         remote_unpush_target.
6253         (remote_target::core_of_thread)
6254         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6255         (remote_target::pid_to_exec_file)
6256         (remote_target::thread_handle_to_thread_info): Pass down target.
6257         (remote_target::async_wait_fd): New.
6258         * riscv-fbsd-tdep.c: Include "inferior.h".
6259         (riscv_fbsd_get_thread_local_address): Pass down target.
6260         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6261         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6262         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6263         Adjust.
6264         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6265         * solib-svr4.c (enable_break): Pass down target.
6266         * spu-multiarch.c (parse_spufs_run): Pass down target.
6267         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6268         * target-delegates.c: Regenerate.
6269         * target.c (g_target_stack): Delete.
6270         (current_top_target): Return the current inferior's top target.
6271         (target_has_execution_1): Refer to the passed-in inferior's top
6272         target.
6273         (target_supports_terminal_ours): Check whether the initial
6274         inferior was already created.
6275         (decref_target): New.
6276         (target_stack::push): Incref/decref the target.
6277         (push_target, push_target, unpush_target): Adjust.
6278         (target_stack::unpush): Defref target.
6279         (target_is_pushed): Return bool.  Adjust to refer to the current
6280         inferior's target stack.
6281         (dispose_inferior): Delete, and inline parts ...
6282         (target_preopen): ... here.  Only dispose of the current inferior.
6283         (target_detach): Hold strong target reference while detaching.
6284         Pass target down.
6285         (target_thread_name): Add assertion.
6286         (target_resume): Pass down target.
6287         (target_ops::beneath, find_target_at): Adjust to refer to the
6288         current inferior's target stack.
6289         (get_dummy_target): New.
6290         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6291         has a thread running.
6292         (initialize_targets): Rename to ...
6293         (_initialize_target): ... this.
6294         * target.h: Include "gdbsupport/refcounted-object.h".
6295         (struct target_ops): Inherit refcounted_object.
6296         (target_ops::shortname, target_ops::longname): Make const.
6297         (target_ops::async_wait_fd): New method.
6298         (decref_target): Declare.
6299         (struct target_ops_ref_policy): New.
6300         (target_ops_ref): New typedef.
6301         (get_dummy_target): Declare function.
6302         (target_is_pushed): Return bool.
6303         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6304         (all_matching_threads_iterator::all_matching_threads_iterator):
6305         Handle filter target.
6306         * thread-iter.h (struct all_matching_threads_iterator, struct
6307         all_matching_threads_range, class all_non_exited_threads_range):
6308         Filter by target too.  Remove explicit.
6309         * thread.c (threads_executing): Delete.
6310         (inferior_thread): Pass down current inferior.
6311         (clear_thread_inferior_resources): Pass down thread pointer
6312         instead of ptid_t.
6313         (add_thread_silent, add_thread_with_info, add_thread): Add
6314         process_stratum_target parameter.  Use it for thread and inferior
6315         searches.
6316         (is_current_thread): New.
6317         (thread_info::deletable): Use it.
6318         (find_thread_ptid, thread_count, in_thread_list)
6319         (thread_change_ptid, set_resumed, set_running): New
6320         process_stratum_target parameter.  Pass it down.
6321         (set_executing): New process_stratum_target parameter.  Pass it
6322         down.  Adjust reference to 'threads_executing'.
6323         (threads_are_executing): New process_stratum_target parameter.
6324         Adjust reference to 'threads_executing'.
6325         (set_stop_requested, finish_thread_state): New
6326         process_stratum_target parameter.  Pass it down.
6327         (switch_to_thread): Also match inferior.
6328         (switch_to_thread): New process_stratum_target parameter.  Pass it
6329         down.
6330         (update_threads_executing): Reimplement.
6331         * top.c (quit_force): Pop targets from all inferior.
6332         (gdb_init): Don't call initialize_targets.
6333         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6334         Declare.
6335         (windows_add_thread, windows_delete_thread): Adjust.
6336         (get_windows_debug_event): Rename to ...
6337         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6338         * tracefile-tfile.c (tfile_target_open): Pass down target.
6339         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6340         Forward declare.
6341         (switch_to_thread): Add process_stratum_target parameter.
6342         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6343         parameter.  Use it.
6344         (mi_on_resume): Pass target down.
6345         * nat/fork-inferior.c (startup_inferior): Add
6346         process_stratum_target parameter.  Pass it down.
6347         * nat/fork-inferior.h (startup_inferior): Add
6348         process_stratum_target parameter.
6349         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6350
6351 2020-01-10  Pedro Alves  <palves@redhat.com>
6352
6353         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6354         directly.  Instead find the first thread in the thread list and
6355         use switch_to_thread.
6356
6357 2020-01-10  Pedro Alves  <palves@redhat.com>
6358
6359         * remote.c (remote_target::remote_add_inferior): Don't bind a
6360         process to the current inferior if the current inferior is already
6361         bound to a process.
6362
6363 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6364             Pedro Alves  <palves@redhat.com>
6365
6366         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6367         If no process is specified, return null_ptid instead of
6368         inferior_ptid.
6369         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6370         TARGET_WAITKIND_SIGNALLED with no pid.
6371
6372 2020-01-10  Pedro Alves  <palves@redhat.com>
6373
6374         * remote.c (first_remote_resumed_thread): New.
6375         (remote_target::wait_as): Use it as default event_ptid instead of
6376         inferior_ptid.
6377
6378 2020-01-10  Pedro Alves  <palves@redhat.com>
6379
6380         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6381
6382 2020-01-10  Pedro Alves  <palves@redhat.com>
6383
6384         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6385         not -1.
6386
6387 2020-01-10  Pedro Alves  <palves@redhat.com>
6388
6389         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6390         ptid to get_last_target_status.
6391         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6392         ptid to get_last_target_status.
6393         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6394         get_last_target_status.
6395         (info_program_command): Don't pass a target_waitstatus to
6396         get_last_target_status.
6397         * infrun.c (init_wait_for_inferior): Use
6398         nullify_last_target_wait_ptid.
6399         (get_last_target_status): Handle nullptr arguments.
6400         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6401         (print_stop_event): Don't pass a ptid to get_last_target_status.
6402         (normal_stop): Don't pass a ptid to get_last_target_status.
6403         * infrun.h (get_last_target_status, set_last_target_status): Move
6404         comments here and update.
6405         (nullify_last_target_wait_ptid): Declare.
6406         * linux-fork.c (fork_load_infrun_state): Remove local extern
6407         declaration of nullify_last_target_wait_ptid.
6408         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6409         to get_last_target_status.
6410
6411 2020-01-10  Pedro Alves  <palves@redhat.com>
6412
6413         * gdbthread.h (scoped_restore_current_thread)
6414         <dont_restore, restore, m_dont_restore>: Declare.
6415         * thread.c (thread_alive): Add assertion.  Return bool.
6416         (switch_to_thread_if_alive): New.
6417         (prune_threads): Switch inferior/thread.
6418         (print_thread_info_1): Switch thread before calling target methods.
6419         (scoped_restore_current_thread::restore): New, factored out from
6420         ...
6421         (scoped_restore_current_thread::~scoped_restore_current_thread):
6422         ... this.
6423         (scoped_restore_current_thread::scoped_restore_current_thread):
6424         Add assertion.
6425         (thread_apply_all_command, thread_select): Use
6426         switch_to_thread_if_alive.
6427         * infrun.c (proceed, restart_threads, handle_signal_stop)
6428         (switch_back_to_stepped_thread): Switch current thread before
6429         calling target methods.
6430
6431 2020-01-10  Pedro Alves <palves@redhat.com>
6432
6433         * inferior.c (switch_to_inferior_no_thread): New function,
6434         factored out from ...
6435         (inferior_command): ... here.
6436         * inferior.h (switch_to_inferior_no_thread): Declare.
6437         * mi/mi-main.c (run_one_inferior): Use
6438         switch_to_inferior_no_thread.
6439
6440 2020-01-10  Pedro Alves  <palves@redhat.com>
6441
6442         * infcmd.c (kill_command): Remove dead code.
6443
6444 2020-01-10  Pedro Alves  <palves@redhat.com>
6445
6446         * remote.c (remote_target::mourn_inferior): No longer check
6447         whether the target is running.
6448
6449 2020-01-10  Pedro Alves  <palves@redhat.com>
6450
6451         * corelow.c (core_target::has_execution): Change parameter type to
6452         inferior pointer.
6453         * inferior.c (number_of_live_inferiors): Use
6454         inferior::has_execution instead of target_has_execution_1.
6455         * inferior.h (inferior::has_execution): New.
6456         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6457         inferior::has_execution instead of target_has_execution_1.
6458         * process-stratum-target.c
6459         (process_stratum_target::has_execution): Change parameter type to
6460         inferior pointer.  Check the inferior's PID instead of
6461         inferior_ptid.
6462         * process-stratum-target.h
6463         (process_stratum_target::has_execution): Change parameter type to
6464         inferior pointer.
6465         * record-full.c (record_full_core_target::has_execution): Change
6466         parameter type to inferior pointer.
6467         * target.c (target_has_execution_1): Change parameter type to
6468         inferior pointer.
6469         (target_has_execution_current): Adjust.
6470         * target.h (target_ops::has_execution): Change parameter type to
6471         inferior pointer.
6472         (target_has_execution_1): Change parameter type to inferior
6473         pointer.  Change return type to bool.
6474         * tracefile.h (tracefile_target::has_execution): Change parameter
6475         type to inferior pointer.
6476
6477 2020-01-10  Pedro Alves  <palves@redhat.com>
6478
6479         * exceptions.c (print_flush): Remove current_top_target() check.
6480
6481 2020-01-10  Pedro Alves  <palves@redhat.com>
6482
6483         * remote.c (show_remote_exec_file): Show the current inferior's
6484         exec-file instead of the command variable's value.
6485
6486 2020-01-10  Pedro Alves  <palves@redhat.com>
6487
6488         * record-full.c (record_full_resume_ptid): New global.
6489         (record_full_target::resume): Set it.
6490         (record_full_wait_1): Use record_full_resume_ptid instead of
6491         inferior_ptid.
6492
6493 2020-01-10  Pedro Alves  <palves@redhat.com>
6494
6495         * gdbthread.h (scoped_restore_current_thread)
6496         <dont_restore, restore, m_dont_restore>: Declare.
6497         * thread.c (thread_alive): Add assertion.  Return bool.
6498         (switch_to_thread_if_alive): New.
6499         (prune_threads): Switch inferior/thread.
6500         (print_thread_info_1): Switch thread before calling target methods.
6501         (scoped_restore_current_thread::restore): New, factored out from
6502         ...
6503         (scoped_restore_current_thread::~scoped_restore_current_thread):
6504         ... this.
6505         (scoped_restore_current_thread::scoped_restore_current_thread):
6506         Add assertion.
6507         (thread_apply_all_command, thread_select): Use
6508         switch_to_thread_if_alive.
6509
6510 2020-01-10  George Barrett  <bob@bob131.so>
6511
6512         * stap-probe.c (stap_modify_semaphore): Don't check for null
6513         semaphores.
6514         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
6515         for null semaphores.
6516
6517 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6518
6519         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
6520         all source windows, and maintain horizontal scroll status while
6521         doing so.
6522
6523 2020-01-09  Tom Tromey  <tom@tromey.com>
6524
6525         PR tui/18932:
6526         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
6527         update_source_window, not print_source_lines.
6528
6529 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6530
6531         * tui/tui.c (tui_enable): Register tui hooks after calling
6532         tui_display_main.
6533
6534 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6535
6536         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
6537
6538 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
6539
6540         * thread.c (print_thread_info_1): Fix indentation.
6541
6542 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6543
6544         * symtab.c (general_symbol_info::compute_and_set_names): Move the
6545         unique_xmalloc_ptr outside the if to always free the demangled name.
6546
6547 2020-01-08  Tom Tromey  <tromey@adacore.com>
6548
6549         * xcoffread.c (enter_line_range, read_xcoff_symtab)
6550         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
6551         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
6552         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
6553         Remove.
6554         (section_offsets): New typedef.
6555         * symtab.c (fixup_section, get_msymbol_address): Update.
6556         * symmisc.c (dump_msymbols): Update.
6557         * symfile.h (relative_addr_info_to_section_offsets)
6558         (symfile_map_offsets_to_segments): Update.
6559         * symfile.c (build_section_addr_info_from_objfile)
6560         (init_objfile_sect_indices): Update.
6561         (struct place_section_arg): Change type of "offsets".
6562         (place_section): Update.
6563         (relative_addr_info_to_section_offsets): Change type of
6564         "section_offsets".  Remove "num_sections" parameter.
6565         (default_symfile_offsets, syms_from_objfile_1)
6566         (set_objfile_default_section_offset): Update.
6567         (reread_symbols): No need to preserve section offsets by hand.
6568         (symfile_map_offsets_to_segments): Change type of "offsets".
6569         * stap-probe.c (relocate_address): Update.
6570         * stabsread.h (process_one_symbol): Update.
6571         * solib-target.c (struct lm_info_target) <offsets>: Change type.
6572         (solib_target_relocate_section_addresses): Update.
6573         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
6574         Update.
6575         * solib-frv.c (frv_relocate_main_executable): Update.
6576         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
6577         * solib-aix.c (solib_aix_get_section_offsets): Change return
6578         type.
6579         (solib_aix_solib_create_inferior_hook): Update.
6580         * remote.c (remote_target::get_offsets): Update.
6581         * psymtab.c (find_pc_sect_psymtab): Update.
6582         * psympriv.h (struct partial_symbol) <address, text_low,
6583         text_high>: Update.
6584         * objfiles.h (obj_section_offset): Update.
6585         (struct objfile) <section_offsets>: Change type.
6586         <num_sections>: Remove.
6587         (objfile_relocate): Update.
6588         * objfiles.c (entry_point_address_query): Update
6589         (relocate_one_symbol): Change type of "section_offsets".
6590         (objfile_relocate1, objfile_relocate1): Change type of
6591         "new_offsets".
6592         (objfile_rebase1): Update.
6593         * mipsread.c (mipscoff_symfile_read): Update.
6594         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
6595         parameter.
6596         * mdebugread.c (parse_symbol): Change type of "section_offsets".
6597         (parse_external, psymtab_to_symtab_1): Update.
6598         * machoread.c (macho_symfile_offsets): Update.
6599         * ia64-tdep.c (ia64_find_unwind_table): Update.
6600         * hppa-tdep.c (read_unwind_info): Update.
6601         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
6602         * dwarf2read.c (create_addrmap_from_index)
6603         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6604         (process_psymtab_comp_unit_reader, add_partial_symbol)
6605         (add_partial_subprogram, process_full_comp_unit)
6606         (read_file_scope, read_func_scope, read_lexical_block_scope)
6607         (read_call_site_scope, dwarf2_rnglists_process)
6608         (dwarf2_ranges_process, dwarf2_ranges_read)
6609         (dwarf_decode_lines_1, var_decode_location, new_symbol)
6610         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
6611         Update.
6612         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
6613         Update.
6614         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
6615         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
6616         (process_one_symbol): Change type of "section_offsets".
6617         * ctfread.c (get_objfile_text_range): Update.
6618         * coffread.c (coff_symtab_read, enter_linenos)
6619         (process_coff_symbol): Update.
6620         * coff-pe-read.c (add_pe_forwarded_sym): Update.
6621         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
6622
6623 2020-01-08  Tom Tromey  <tromey@adacore.com>
6624
6625         * dwarf2read.c (parse_macro_definition): Use std::string.
6626         (parse_macro_definition): Likewise.
6627
6628 2020-01-08  Tom Tromey  <tromey@adacore.com>
6629
6630         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
6631         (ATTR_ALLOC_CHUNK): Remove.
6632
6633 2020-01-08  Tom Tromey  <tromey@adacore.com>
6634
6635         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
6636
6637 2020-01-08  Tom Tromey  <tromey@adacore.com>
6638
6639         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
6640         (dwarf2_compute_name, open_dwo_file): Likewise.
6641         (process_enumeration_scope): Use std::vector.
6642         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
6643         (partial_die_info::fixup, dwarf2_start_subfile)
6644         (guess_full_die_structure_name, dwarf2_name): Likewise.
6645         (determine_prefix): Update.
6646         (guess_full_die_structure_name): Make return type const.
6647         (partial_die_full_name): Return unique_xmalloc_ptr.
6648         (DW_FIELD_ALLOC_CHUNK): Remove.
6649
6650 2020-01-07  Tom Tromey  <tromey@adacore.com>
6651
6652         PR build/24937:
6653         * stap-probe.c (class stap_static_probe_ops): Add constructor.
6654
6655 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6656
6657         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
6658
6659 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6660
6661         * stack.c (print_frame_info): Move disassemble_next_line code
6662         inside source_print block.
6663
6664 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6665
6666         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
6667         gdb/signals.h, as we are now using native signal symbols.
6668
6669 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6670
6671         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
6672         overflow by an early check of content vs threshold.
6673         * tui/tui-source.c (tui_source_window::line_is_displayed):
6674         Likewise.
6675
6676 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6677
6678         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
6679
6680 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6681
6682         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
6683         export table if no section contains it's RVA.
6684
6685 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6686
6687         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
6688
6689 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
6690
6691         * source.c (print_source_lines_base): Set last_line_listed.
6692
6693 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6694
6695         * tui/tui-disasm.c: Remove trailing spaces.
6696
6697 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6698             Pedro Alves  <palves@redhat.com>
6699
6700         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
6701         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
6702         (windows_gdb_signal_to_target): New function, uses the above
6703         enumeration to convert GDB internal signal codes to equivalent
6704         Windows codes.
6705         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
6706         * windows-nat.c: Include "gdb_wait.h".
6707         (get_windows_debug_event): Extract the fatal exception from the
6708         exit status and convert to the equivalent Posix signal number.
6709         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
6710         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
6711         * gdbsupport/gdb_wait.c: New file, implements
6712         windows_status_to_termsig.
6713         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
6714         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
6715
6716 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6717
6718         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
6719         show_layout.
6720
6721 2020-01-05  Luis Machado  <luis.machado@linaro.org>
6722
6723         * aarch64-linux-nat.c
6724         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
6725         and bfd_mach_aarch64.
6726
6727 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6728
6729         * ui-file.c (stdio_file::can_emit_style_escape)
6730         (tee_file::can_emit_style_escape): Ensure style is used also on
6731         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
6732         to gdb_stdout.
6733         * main.c (set_gdb_data_directory): Use file style to output the
6734         warning that the given pathname is not a directory.
6735         * top.c (show_history_filename, gdb_safe_append_history)
6736         (show_gdb_datadir): Use file style.
6737
6738 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6739
6740         * solib-target.c (struct lm_info_target):
6741         Change offsets to be a unique_xmalloc_ptr.
6742         (solib_target_relocate_section_addresses): Update.
6743
6744 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6745
6746         * windows-nat.c (windows_clear_solib): Free so_list linked list.
6747
6748 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6749
6750         * MAINTAINERS (Write After Approval): Add myself.
6751
6752 2020-01-02  Luis Machado  <luis.machado@linaro.org>
6753
6754         * proc-service.c (get_ps_regcache): Remove reference to obsolete
6755         Cell BE architecture.
6756         * target.h (struct target_ops) <thread_architecture>: Likewise.
6757
6758 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6759
6760         * Makefile.in: Use INSTALL_PROGRAM_ENV.
6761
6762 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6763
6764         * MAINTAINERS (Write After Approval): Add myself.
6765
6766 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6767
6768         * gdbarch.sh: Update copyright year range of generated files.
6769
6770 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6771
6772         Update copyright year range in all GDB files.
6773
6774 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6775
6776         * copyright.py: Convert to Python 3.
6777
6778 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6779
6780         * copyright.py: Adapt after move of gnulib directory from gdb
6781         directory to toplevel directory.
6782
6783 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6784
6785         * copyright.py (main): Exit if run from the wrong directory.
6786
6787 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6788
6789         * top.c (print_gdb_version): Change copyright year to 2020.
6790
6791 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6792
6793         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
6794
6795 For older changes see ChangeLog-2019.
6796 \f
6797 Local Variables:
6798 mode: change-log
6799 left-margin: 8
6800 fill-column: 74
6801 version-control: never
6802 coding: utf-8
6803 End: