gdb/ChangeLog

   1 2019-06-16  Tom de Vries  <tdevries@suse.de>
   2
   3         PR gdb/24445
   4         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
   5
   6 2019-06-16  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
   9         (make_all_visible): Use address of member.
  10
  11 2019-06-16  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  14         (tui_free_window, free_content, free_content_elements): Remove
  15         unnecessary cast.
  16         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  17         cast.
  18         * tui/tui-regs.c (tui_show_register_group)
  19         (tui_display_registers_from, tui_display_reg_element_at_line):
  20         Remove unnecessary cast.
  21
  22 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  23
  24         * linux-nat.c (normal_mask): Delete.
  25         (_initialize_linux_nat): Don't initialise normal_mask.
  26
  27 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  28
  29         PR gdb/24445
  30         * dwarf-index-write.h (write_psymtabs_to_index): Add
  31         dwz_basename parameter.
  32         * dwarf-index-write.c (write_gdbindex): Move file writing to
  33         write_gdbindex_1.  Change return type void.
  34         (assert_file_size): Move up, remove filename parameter.
  35         (write_gdbindex_1): New function.
  36         (write_debug_names): Change return type to void, call
  37         assert_file_size.
  38         (struct index_wip_file): New struct.
  39         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  40         file logic to index_wip_file.  Write index for dwz file if
  41         needed.
  42         (save_gdb_index_command): Pass basename of dwz file, if present.
  43         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  44         build-id of dwz file, if present.
  45         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  46         (dwarf2_get_dwz_file): Likewise.
  47         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
  48         (dwarf2_get_dwz_file): Likewise.
  49
  50 2019-06-16  Tom Tromey  <tom@tromey.com>
  51
  52         * coffread.c (process_coff_symbol): Use xstrdup.
  53         * value.c (create_internalvar): Use xstrdup.
  54
  55 2019-06-16  Tom Tromey  <tom@tromey.com>
  56
  57         * valops.c (value_cast, value_slice): Remove unnecessary cast.
  58         * breakpoint.c (stopin_command, stopat_command)
  59         (until_break_command, decode_location_default): Remove unnecessary
  60         cast.
  61         * utils.c (subset_compare): Remove unnecessary cast.
  62         * ada-lang.c (ada_update_initial_language): Remove unnecessary
  63         cast.
  64         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
  65         cast.
  66         * infcmd.c (path_command): Remove unnecessary cast.
  67         * coffread.c (decode_type): Remove unnecessary cast.
  68         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
  69         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
  70         * tui/tui-stack.c (tui_show_locator_content)
  71         (tui_show_frame_info): Remove unnecessary cast.
  72         * tui/tui-win.c (tui_scroll_forward_command)
  73         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
  74         (parse_scrolling_args): Remove unnecessary cast.
  75         * tui/tui-data.c (init_win_info, tui_del_window)
  76         (tui_free_window, tui_del_data_windows, tui_free_data_content)
  77         (free_content_elements): Remove unnecessary cast.
  78         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
  79         unnecessary cast.
  80         * tui/tui-source.c (tui_set_source_content)
  81         (tui_vertical_source_scroll): Remove unnecessary cast.
  82         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
  83         cast.
  84         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
  85         * tui/tui-regs.c (tui_display_registers_from)
  86         (tui_display_register): Remove unnecessary cast.
  87         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
  88         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
  89         (make_visible): Remove unnecessary cast.
  90         * tui/tui-winsource.c (tui_erase_source_content)
  91         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
  92         unnecessary cast.
  93         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
  94         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
  95         * stabsread.c (read_type, read_array_type, read_range_type):
  96         Remove unnecessary cast.
  97         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
  98         (parse_symbol, parse_type, upgrade_type, parse_external)
  99         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 100         unnecessary cast.
 101         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 102
 103 2019-06-16  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-data.c (tui_alloc_generic_win_info)
 106         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 107         checks.
 108
 109 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 110             Andrew Burgess  <andrew.burgess@embecosm.com>
 111
 112         * f-typeprint.c (f_print_type): Don't return early for not
 113         associated or not allocated types.
 114         (f_type_print_varspec_suffix): Add print_rank parameter and print
 115         ranks of array types in case they dangling.
 116         (f_type_print_base): Add print_rank parameter.
 117
 118 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 119
 120         * NEWS: Mention new MI commands.
 121         * break-catch-throw.c (enum exception_event_kind): Move to
 122         breakpoint.h.
 123         (print_mention_exception_catchpoint): Output text as a single
 124         message.
 125         (catch_exception_command_1): Rename to...
 126         (catch_exception_event): ...this, make non-static, update header
 127         command, and change some parameter types.
 128         (catch_catch_command): Update for changes to
 129         catch_exception_command_1.
 130         (catch_throw_command): Likewise.
 131         (catch_rethrow_command): Likewise.
 132         * breakpoint.c (enum exception_event_kind): Delete.
 133         * breakpoint.h (enum exception_event_kind): Moved here from
 134         break-catch-throw.c.
 135         (catch_exception_event): Declare.
 136         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 137         (mi_cmd_catch_throw): New function.
 138         (mi_cmd_catch_rethrow): New function.
 139         (mi_cmd_catch_catch): New function.
 140         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 141         'catch-catch' entries.
 142         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 143         (mi_cmd_catch_rethrow): Declare.
 144         (mi_cmd_catch_catch): Declare.
 145
 146 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 147
 148         * annotate.c (annotate_source_line): Change return type to void,
 149         update implementation to match.
 150         * annotate.h (annotate_source_line): Change return type to void,
 151         update header comment.
 152         * stack.c (print_frame_info): Don't change what frame information
 153         is printed based on whether annotations are on or not.
 154
 155 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 156
 157         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 158         (annotate_source): Make static.
 159         (annotate_source_line): Moved from source.c and renamed from
 160         identify_source_line.  Update the return type.
 161         * annotate.h (annotate_source): Delete declaration.
 162         (annotate_source_line): Declaration moved from source.h, and
 163         renamed from identify_source_line.  Return type updated.
 164         * source.c (identify_source_line): Moved to annotate.c and renamed
 165         to annotate_source_line.
 166         (info_line_command): Remove check of annotation_level.
 167         * source.h (identify_source_line): Move declaration to annotate.h
 168         and rename to annotate_source_line.
 169         * stack.c: Add 'annotate.h' include.
 170         (print_frame_info): Remove check of annotation_level before
 171         calling annotate_source_line.
 172
 173 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 174
 175         * source-cache.c (source_cache::get_plain_source_lines): Use
 176         open_source_file_with_line_charpos instead of just
 177         open_source_file, remove call to find_source_lines.
 178         (source_cache::get_source_lines): Likewise.
 179         * source.c (find_source_lines): Make static.
 180         (get_filename_and_charpos): Renamed into...
 181         (open_source_file_with_line_charpos): ..this along with changes to
 182         return a scoped_fd, and some other minor clean ups.
 183         (identify_source_line): Use open_source_file_with_line_charpos.
 184         (search_command_helper): Use open_source_file_with_line_charpos
 185         instead of just open_source_file, remove call to
 186         find_source_lines.
 187         * source.h (open_source_file_with_line_charpos): Declare new
 188         function.
 189         (find_source_lines): Delete declaration.
 190
 191 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 192
 193         * source.c (get_filename_and_charpos): Remove fullname
 194         parameter.
 195         (identify_source_line): Update call to get_filename_and_charpos.
 196
 197 2019-06-14  Tom Tromey  <tromey@adacore.com>
 198
 199         PR gdb/24502:
 200         * ui-style.h (skip_ansi_escape): Update comment.
 201         * ui-file.h (class no_terminal_escape_file): New class.
 202         * ui-file.c (no_terminal_escape_file::write)
 203         (no_terminal_escape_file::puts): New methods.
 204         * cli/cli-logging.c (handle_redirections): Use
 205         no_terminal_escape_file.
 206
 207 2019-06-14  Tom Tromey  <tromey@adacore.com>
 208
 209         * NEWS: Move convenience variable news above Python news.
 210
 211 2019-06-14  Tom Tromey  <tom@tromey.com>
 212
 213         * gnulib: Move directory to top-level.
 214         * configure.ac: Don't configure gnulib.
 215         * configure: Rebuild.
 216         * common/common-defs.h: Use new path to gnulib.
 217         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 218         (GNULIB_H): Remove.
 219         (INCGNU): Look in new gnulib location.
 220         (HFILES_NO_SRCDIR): Remove gnulib files.
 221         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 222         (generated_files): Remove GNULIB_H.
 223         ($(LIBGNU), all-lib): Remove targets.
 224         (distclean): Don't mention GNULIB_BUILDDIR.
 225         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 226
 227 2019-06-14  Tom Tromey  <tromey@adacore.com>
 228
 229         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 230         Warn if symbol file does not provide any symbols.
 231
 232 2019-06-14  Tom Tromey  <tromey@adacore.com>
 233
 234         * source.c (find_and_open_source): Respect basenames_may_differ.
 235
 236 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * annotate.c (annotate_breakpoints_invalid): Make use of
 239         scoped_restore_terminal_state.
 240         (annotate_frames_invalid): Likewise.
 241
 242 2019-06-14  Tom Tromey  <tromey@adacore.com>
 243
 244         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 245         allow assignment to an internalvar.
 246
 247 2019-06-14  Tom Tromey  <tromey@adacore.com>
 248
 249         * ada-lex.l: Allow "_" in attribute names.
 250
 251 2019-06-14  Tom Tromey  <tromey@adacore.com>
 252
 253         PR gdb/24653:
 254         * regcache.c (registers_changed): Don't call alloca.
 255         * top.c (execute_command): Don't call alloca.
 256
 257 2019-06-13  Pedro Alves  <palves@redhat.com>
 258
 259         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 260         'expression'.  When parsing an expression, error out if there's
 261         junk after "unlimited".
 262         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 263         (do_set_command): Adjust calls to is_unlimited_literal.
 264
 265 2019-06-13  Pedro Alves  <palves@redhat.com>
 266
 267         * compile/compile.c (make_compile_options_def_group): Add braces
 268         around array_view initializer.
 269         * thread.c (make_thread_apply_all_options_def_group)
 270         (make_thread_apply_all_options_def_group): Likewise.
 271
 272 2019-06-13  Pedro Alves  <palves@redhat.com>
 273
 274         * NEWS (New commands): Mention "maint test-options
 275         require-delimiter", "maint test-options unknown-is-error", "maint
 276         test-options unknown-is-operand" and "maint show
 277         test-options-completion-result".
 278         (New command options, command completion): New section.
 279         (Completion improvements): New section.
 280         Mention that you can abbreviate "unlimited".
 281
 282 2019-06-13  Pedro Alves  <palves@redhat.com>
 283
 284         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 285         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 286         * unittests/cli-utils-selftests.c (test_parse_flags)
 287         (test_parse_flags_qcs): Delete.
 288         (test_cli_utils): Don't call deleted functions.
 289
 290 2019-06-13  Pedro Alves  <palves@redhat.com>
 291
 292         * thread.c: Include "cli/cli-option.h".
 293         (tp_array_compar_ascending): Global.
 294         (tp_array_compar): Delete function.
 295         (tp_array_compar_ascending, tp_array_compar_descending): New
 296         functions.
 297         (ascending_option_def, qcs_flag_option_def)
 298         (thr_qcs_flags_option_defs)
 299         (make_thread_apply_all_options_def_group)
 300         (make_thread_apply_options_def_group): New.
 301         (thread_apply_all_command): Use gdb::option::process_options.
 302         (thread_apply_command_completer)
 303         (thread_apply_all_command_completer): New.
 304         (thread_apply_command): Use gdb::option::process_options.
 305         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 306         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 307         to generate help text of "thread apply".  Adjust "taas"'s help.
 308         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 309         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 310
 311 2019-06-13  Pedro Alves  <palves@redhat.com>
 312
 313         * thread.c (thread_apply_command): Check for invalid TID with
 314         isdigit instead of !isalpha.
 315
 316 2019-06-13  Pedro Alves  <palves@redhat.com>
 317
 318         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 319         (validate_flags_qcs): New.
 320         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 321         (validate_flags_qcs): Declare.
 322         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 323         (make_frame_apply_options_def_group): New.
 324         (frame_apply_command_count): Process options with
 325         gdb::option::process_options.
 326         (frame_apply_completer): New.
 327         (frame_apply_level_completer, frame_apply_all_completer)
 328         (frame_apply_completer): New.
 329         (_initialize_stack): Update help of "frame apply", "frame apply
 330         level", "frame apply all" and "faas" to mention supported options
 331         and install command completers.
 332         * stack.h (frame_apply_all_completer): Declare.
 333         * thread.c: Include "stack.h".
 334         (tfaas_command): Add "--".
 335         (_initialize_thread): Update help "tfaas" to mention supported
 336         options and install command completer.
 337
 338 2019-06-13  Pedro Alves  <palves@redhat.com>
 339
 340         * completer.c (complete_nested_command_line): New.
 341         (gdb_completion_word_break_characters_throw): Add assertion.
 342         * completer.h (complete_nested_command_line): Declare.
 343
 344 2019-06-13  Pedro Alves  <palves@redhat.com>
 345
 346         * stack.c (parse_backtrace_qualifiers): New.
 347         (backtrace_command): Use it.
 348         (backtrace_command_completer): Complete on qualifiers.
 349
 350 2019-06-13  Pedro Alves  <palves@redhat.com>
 351
 352         * frame.c: Include "cli/cli-option.h.
 353         (user_set_backtrace_options): New.
 354         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 355         Delete.
 356         (get_prev_frame): Adjust.
 357         (boolean_option_def, uinteger_option_def)
 358         (set_backtrace_option_defs): New.
 359         (_initialize_frame): Adjust and use
 360         gdb::option::add_setshow_cmds_for_options to install "set
 361         backtrace past-main" and "set backtrace past-entry".
 362         * frame.h: Include "cli/cli-option.h".
 363         (struct frame_print_options): Forward declare.
 364         (print_frame_arguments_all, print_frame_arguments_scalars)
 365         (print_frame_arguments_none): Declare.
 366         (print_entry_values): Delete declaration.
 367         (struct frame_print_options, user_frame_print_options): New.
 368         (struct set_backtrace_options): New.
 369         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 370         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 371         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 372         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 373         (list_args_or_locals): Add frame_print_options parameter.
 374         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 375         * python/py-framefilter.c (enumerate_args): Pass down
 376         USER_FRAME_PRINT_OPTIONS.
 377         * stack.c: Include "cli/cli-option.h".
 378         (print_frame_arguments_all, print_frame_arguments_scalars)
 379         (print_frame_arguments_none): Declare.
 380         (print_raw_frame_arguments, print_entry_values): Delete.
 381         (user_frame_print_options): New.
 382         (boolean_option_def, enum_option_def, frame_print_option_defs):
 383         New.
 384         (struct backtrace_cmd_options): New.
 385         (bt_flag_option_def): New.
 386         (backtrace_command_option_defs): New.
 387         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 388         (print_frame_arg, read_frame_arg, print_frame_args)
 389         (print_frame_info, print_frame): Add frame_print_options parameter
 390         and use it.
 391         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 392         (backtrace_command_1): Add frame_print_options and
 393         backtrace_cmd_options parameters and use them.
 394         (make_backtrace_options_def_group): New.
 395         (backtrace_command): Process command options with
 396         gdb::option::process_options.
 397         (backtrace_command_completer): New.
 398         (_initialize_stack): Extend "backtrace"'s help to mention
 399         supported options.  Install completer for "backtrace".
 400         Install some settings commands with add_setshow_cmds_for_options.
 401
 402 2019-06-13  Pedro Alves  <palves@redhat.com>
 403
 404         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 405         and that "set/show print raw frame-arguments" are now deprecated.
 406
 407         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 408         command.
 409         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 410         * stack.c (_initialize_stack): Install "set/show print
 411         raw-frame-arguments", and deprecate "set/show print raw
 412         frame-arguments".
 413         * valprint.c (_initialize_valprint): Deprecate "set/show print
 414         raw".
 415
 416 2019-06-13  Pedro Alves  <palves@redhat.com>
 417
 418         * compile/compile.c (struct compile_options): New.
 419         (compile_flag_option_def, compile_command_option_defs)
 420         (make_compile_options_def_group): New.
 421         (compile_file_command): Handle options with
 422         gdb::option::process_options.
 423         (compile_file_command_completer): New function.
 424         (compile_code_command): Handle options with
 425         gdb::option::process_options.
 426         (compile_code_command_completer): New function.
 427         (_initialize_compiler): Install completers for "compile code" and
 428         "compile file".  Mention available options in "compile code" and
 429         "compile code"'s help.
 430         * completer.c (advance_to_completion_word): New, factored out from
 431         ...
 432         (advance_to_expression_complete_word_point): ... this.
 433         (advance_to_filename_complete_word_point): New.
 434         * completer.h (advance_to_filename_complete_word_point): New
 435         declaration.
 436
 437 2019-06-13  Pedro Alves  <palves@redhat.com>
 438
 439         * compile/compile.c: Include "cli/cli-option.h".
 440         (compile_print_value): Scope data pointer is now a
 441         value_print_options pointer; adjust.
 442         (compile_print_command): Process options.  Scope data pointer is
 443         now a value_print_options pointer; adjust.
 444         (_initialize_compile): Update "compile print"'s help to include
 445         supported options.  Install a completer for "compile print".
 446         * cp-valprint.c (show_vtblprint, show_objectprint)
 447         (show_static_field_print): Delete.
 448         (_initialize_cp_valprint): Don't install "set print
 449         static-members", "set print vtbl", "set print object" here.
 450         * printcmd.c: Include "cli/cli-option.h" and
 451         "common/gdb_optional.h".
 452         (print_command_parse_format): Rework to fill in a
 453         value_print_options instead of a format_data.
 454         (print_value): Change parameter type from format_data pointer to
 455         value_print_options reference.  Adjust.
 456         (print_command_1): Process options.  Adjust to pass down a
 457         value_print_options.
 458         (print_command_completer): New.
 459         (_initialize_printcmd): Install print_command_completer as
 460         handle_brkchars completer for the "print" command.  Update
 461         "print"'s help to include supported options.
 462         * valprint.c: Include "cli/cli-option.h".
 463         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 464         here from cp-valprint.c.
 465         (boolean_option_def, uinteger_option_def)
 466         (value_print_option_defs, make_value_print_options_def_group):
 467         New.  Use gdb::option::add_setshow_cmds_for_options to install
 468         "set print elements", "set print null-stop", "set print repeats",
 469         "set print pretty", "set print union", "set print array", "set
 470         print address", "set print symbol", "set print array-indexes".
 471         * valprint.h: Include <string> and "cli/cli-option.h".
 472         (make_value_print_options_def_group): Declare.
 473         (print_value): Change parameter type from format_data pointer to
 474         value_print_options reference.
 475         (print_command_completer): Declare.
 476
 477 2019-06-13  Pedro Alves  <palves@redhat.com>
 478
 479         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 480         (COMMON_SFILES): Add maint-test-settings.c.
 481         * cli/cli-decode.c (boolean_enums): New global, factored out from
 482         ...
 483         (add_setshow_boolean_cmd): ... here.
 484         * cli/cli-decode.h (boolean_enums): Declare.
 485         * cli/cli-option.c: New file.
 486         * cli/cli-option.h: New file.
 487         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 488         factored out from ...
 489         (parse_cli_boolean_value(const char *)): ... this.
 490         (is_unlimited_literal): Change parameter type to pointer to
 491         pointer.  Adjust and advance ARG pointer.
 492         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 493         (parse_cli_var_enum): New, factored out from ...
 494         (do_set_command): ... this.  Adjust.
 495         * cli/cli-setshow.h (parse_cli_boolean_value)
 496         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 497         (parse_cli_var_enum): Declare.
 498         * cli/cli-utils.c: Include "cli/cli-option.h".
 499         (get_ulongest): New.
 500         * cli/cli-utils.h (get_ulongest): Declare.
 501         (check_for_argument): New overloads.
 502         * maint-test-options.c: New file.
 503
 504 2019-06-13  Pedro Alves  <palves@redhat.com>
 505
 506         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 507         parse a range if "-" is at the end of the string.
 508
 509 2019-06-13  Pedro Alves  <palves@redhat.com>
 510
 511         * cli/cli-setshow.c (parse_auto_binary_operation)
 512         (parse_cli_boolean_value): Don't allow "o".
 513
 514 2019-06-13  Pedro Alves  <palves@redhat.com>
 515
 516         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 517         * NEWS: Mention maint test-settings KIND.
 518         * maint-test-settings.c: New file.
 519
 520 2019-06-13  Pedro Alves  <palves@redhat.com>
 521
 522         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 523         completer.
 524         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 525         "set" completers.
 526
 527 2019-06-13  Pedro Alves  <palves@redhat.com>
 528
 529         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 530         after item.
 531
 532 2019-06-13  Pedro Alves  <palves@redhat.com>
 533
 534         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 535
 536 2019-06-13  Pedro Alves <palves@redhat.com>
 537
 538         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 539         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 540         call.
 541         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 542         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 543         calls.
 544         (check_for_argument): Skip spaces after argument.
 545
 546 2019-06-13  Pedro Alves  <palves@redhat.com>
 547
 548         * thread.c (thread_apply_command): Adjust TID parsing.
 549         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 550         detected before end of string.
 551         (tid_is_in_list): Error out if LIST is invalid.
 552
 553 2019-06-13  Pedro Alves  <palves@redhat.com>
 554
 555         * completer.c (complete_line_internal_1): Rewind completion word
 556         point.
 557         (completion_tracker::advance_custom_word_point_by): Change
 558         parameter type to int.
 559         * completer.h (completion_tracker::advance_custom_word_point_by):
 560         Likewise.
 561
 562 2019-06-13  Pedro Alves  <palves@redhat.com>
 563
 564         * completer.c (advance_to_completion_word): Handle delimiters.
 565
 566 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 567
 568         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 569
 570 2019-06-11  Tom Tromey  <tom@tromey.com>
 571
 572         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 573         (xmalloc_failed): Move to alloc.c.
 574         * alloc.c: New file.
 575         * Makefile.in (COMMON_SFILES): Add alloc.c.
 576
 577 2019-06-11  Tom Tromey  <tom@tromey.com>
 578
 579         * nat/linux-waitpid.c: Don't include server.h.
 580         (linux_debug): Remove.
 581         (my_waitpid): Update.
 582
 583 2019-06-11  Tom Tromey  <tromey@adacore.com>
 584
 585         * infcall.c (_initialize_infcall): Remove trailing newline from
 586         help.
 587         * user-regs.c (_initialize_user_regs): Remove trailing newline
 588         from help.
 589         * typeprint.c (_initialize_typeprint): Remove trailing newline
 590         from help.
 591         * reverse.c (_initialize_reverse): Remove trailing newlines from
 592         help.
 593         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 594         from help.
 595         * language.c (add_set_language_command): Remove trailing newline
 596         from help.
 597         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 598         help.
 599         * disasm.c (_initialize_disasm): Remove trailing newline from
 600         help.
 601         * top.c (init_main): Remove trailing newline from help.
 602         * interps.c (_initialize_interpreter): Remove trailing newline
 603         from help.
 604         * btrace.c (_initialize_btrace): Remove trailing newlines from
 605         help.
 606         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 607         from help.
 608         * python/python.c (_initialize_python): Remove trailing newline
 609         from help.
 610         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 611         help.
 612         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 613         from help.  Reformat some text.
 614         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 615         from help.
 616         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 617         newline from help.
 618
 619 2019-06-11  Tom Tromey  <tromey@adacore.com>
 620
 621         * darwin-nat.c (darwin_decode_exception_message)
 622         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 623
 624 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * valops.c (value_slice): Check for not allocated or not
 627         associated values.
 628
 629 2019-06-10  Tom de Vries  <tdevries@suse.de>
 630
 631         PR gdb/24618
 632         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 633         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 634         invalid.
 635
 636 2019-06-10  Tom de Vries  <tdevries@suse.de>
 637
 638         PR gdb/24611
 639         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 640         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 641
 642 2019-06-10  Tom de Vries  <tdevries@suse.de>
 643
 644         PR symtab/24545
 645         * symtab.c (struct demangled_name_entry): Add language field.
 646         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 647         static minimal symbol".  Set and use language field.
 648
 649 2019-06-10  Tom Tromey  <tromey@adacore.com>
 650
 651         * ada-lang.c (_initialize_ada_language): Update help text.
 652
 653 2019-06-10  Tom Tromey  <tromey@adacore.com>
 654
 655         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 656         with a newline.
 657         * guile/guile.c (handle_boot_error): Don't end warning with a
 658         newline.
 659         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 660         warning with a newline.
 661         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 662         newline.
 663         (s12z_frame_cache): Likewise.
 664         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 665         a newline.
 666         * solib-svr4.c (disable_probes_interface): Don't end warning with
 667         a newline.
 668         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 669         newline.
 670         * python/python.c (do_finish_initialization): Don't end warning
 671         with a newline.
 672
 673 2019-06-10  Tom Tromey  <tom@tromey.com>
 674
 675         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 676         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 677         gdbpy_enter.
 678
 679 2019-06-10  Tom Tromey  <tromey@adacore.com>
 680
 681         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 682         data.
 683         (elf_new_init): Don't call stabsread_new_init.
 684         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 685         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 686         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 687
 688 2019-06-10  Tom de Vries  <tdevries@suse.de>
 689
 690         PR symtab/16264
 691         PR symtab/24517
 692         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 693
 694 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 695
 696         * source.c (find_and_open_source): Also rewrite relative file
 697         names.
 698
 699 2019-04-26  Amos Bird  <amosbird@gmail.com>
 700
 701         * annotate.c (annotate_thread_exited): Add "thread-exited"
 702         annotation.
 703
 704 2019-06-06  Tom Tromey  <tromey@adacore.com>
 705
 706         * maint.h (class scoped_command_stats): Use
 707         DISABLE_COPY_AND_ASSIGN.
 708         <print_time>: New method.
 709         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 710         print_time.
 711         (scoped_command_stats::print_time): New method.
 712
 713 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 714
 715         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 716         instructions of lengths 6 or 8 bytes.
 717
 718 2019-06-04  Pedro Alves  <palves@redhat.com>
 719
 720         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 721
 722         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 723         * breakpoint.c (condition_completer): Likewise.
 724         * cli/cli-dump.c (scan_expression): Likewise.
 725         * common/filestuff.c (mkdir_recursive): Likewise.
 726         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 727         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 728         (gdb_abspath): Likewise.
 729         * compile/compile-cplus-types.c
 730         (compile_cplus_instance::decl_name): Likewise.
 731         * completer.c (complete_explicit_location):
 732         (signal_completer, reg_or_group_completer_1): Likewise.
 733         * cp-support.c (cp_remove_params_if_any): Likewise.
 734         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 735         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 736         * infcmd.c (strip_bg_char): Likewise.
 737         * linespec.c (copy_token_string): Likewise.
 738         * mi/mi-main.c (output_cores): Likewise.
 739         * psymtab.c (psymtab_search_name):
 740         * symfile.c (test_set_ext_lang_command): Likewise.
 741         * target.c (target_fileio_read_stralloc): Likewise.
 742         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 743         * value.c (complete_internalvar): Likewise.
 744
 745 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 746
 747         Add objfile property to gdb.Type.
 748         * NEWS: Mention Python API addition.
 749         * python/py-type.c (typy_get_objfile): New method.
 750
 751 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 752
 753         * NEWS: Mention the new set|show style [title|highlight].
 754         Mention changes to "show style", "help" and "apropos".
 755
 756 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 757
 758         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 759         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 760         instead of print_help_for_command.
 761         (print_doc_of_command): New function.
 762         (help_list): Add 'apropos -v word' suggestion.
 763         (print_help_for_command): Style the command name using title style.
 764         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 765         (_initialize_cli_cmds): Describe -v in apropos_command help.
 766
 767 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 768
 769         * cli/cli-style.h (cli_style_option): Add name in constructor,
 770         add m_name class member, add constructor with intensity,
 771         add name class function.
 772         (cli_style_option::add_setshow_commands): Remove name argument.
 773         (highlight_style, title_style): New styles.
 774         * cli/cli-style.c (do_show): New function that shows a style
 775         characteristic styling the style name with itself.
 776         (set_style_name): New function.
 777         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 778         Update all callers according to the changes in cli/cli-style.h.
 779         * utils.h (fputs_highlighted): New function.
 780         * utils.c (fputs_highlighted): Likewise.
 781
 782 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 783
 784         * NEWS: Mention new pipe command and new convenience variables.
 785
 786 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 787
 788         * cli/cli-cmds.c (pipe_command): New function.
 789         (_initialize_cli_cmds): Call add_com for pipe_command.
 790         Define | as an alias for pipe.
 791         (exit_status_set_internal_vars): New function.
 792         (shell_escape): Call exit_status_set_internal_vars.
 793         cli/cli-decode.c (find_command_name_length): Recognize | as
 794         a single character command.
 795
 796 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 797
 798         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 799         top.c (execute_command_to_ui_file): New function, mostly a copy
 800         of execute_command_to_string.
 801         (execute_command_to_string): Implement by calling
 802         execute_command_to_ui_file.
 803
 804 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 805
 806         * top.h (saved_command_line): Remove declaration.
 807         * top.c (previous_saved_command_line, previous_repeat_arguments):
 808         New variables.
 809         (saved_command_line): Make static, define together with other
 810         'repeat variables'.
 811         (dont_repeat): Clear repeat_arguments.
 812         (repeat_previous, get_saved_command_line, save_command_line):
 813         New functions.
 814         (gdb_init): Initialize saved_command_line
 815         and previous_saved_command_line.
 816         * main.c (captured_main_1): Remove saved_command_line initialization.
 817         * event-top.c (handle_line_of_input): Update to use
 818         the new 'repeat' related functions instead of direct access to
 819         saved_command_line.
 820         * command.h (repeat_previous, get_saved_command_line,
 821         save_command_line): New declarations.
 822         (dont_repeat): Add comment.
 823
 824 2019-05-30  Tom Tromey  <tromey@adacore.com>
 825
 826         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 827         Fix comment.
 828         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 829
 830 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 831
 832         PR cli/24587
 833         * completer.c (complete): Initialize variable word.
 834
 835 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 836
 837         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 838         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 839         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 840         'body' is NULL to the outter 'if', protecting the '!is_define'
 841         situation as well.
 842
 843 2019-05-29  Tom Tromey  <tromey@adacore.com>
 844
 845         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 846         (dwarf_unknown): New function.
 847         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 848         (dwarf_type_encoding_name): Use dwarf_unknown.
 849
 850 2019-05-29  Tom Tromey  <tromey@adacore.com>
 851
 852         PR c++/20020:
 853         * cp-valprint.c (cp_print_value_fields): Call
 854         cp_print_static_field inside "try".
 855
 856 2019-05-29  Tom Tromey  <tromey@adacore.com>
 857
 858         * inflow.c (struct terminal_info): Add default operator=.
 859         * configure: Rebuild.
 860         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 861         -Wdeprecated-copy-dtor, -Wredundant-move.
 862
 863 2019-05-29  Tom Tromey  <tromey@adacore.com>
 864
 865         * NEWS: Add entry.
 866         * infcmd.c (print_return_value_1): Handle finish_print
 867         option.
 868         (show_print_finish): New function.
 869         (_initialize_infcmd): Add "set/show print finish" commands.
 870         * valprint.c (user_print_options): Initialize new member.
 871         * valprint.h (struct value_print_options) <finish_print>: New
 872         member.
 873
 874 2019-05-28  Tom Tromey  <tromey@adacore.com>
 875
 876         * ada-lang.c (ada_remove_Xbn_suffix)
 877         (find_old_style_renaming_symbol)
 878         (parse_old_style_renaming): Remove.
 879         (ada_find_renaming_symbol): Don't call
 880         find_old_style_renaming_symbol.
 881         (ada_is_renaming_symbol): Rename from
 882         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 883         bool.  Now static.
 884         (ada_read_var_value): Update and simplify.
 885         * ada-exp.y (write_var_or_type): Remove old code.
 886
 887 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 888
 889         * event-top.c: Remove include comment.
 890         * inflow.c (class scoped_ignore_sigttou): Move from here...
 891         * inflow.h (class scoped_ignore_sigttou): ...to here.
 892         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 893         * top.c:  Remove include comment.
 894
 895 2019-05-27  Tom Tromey  <tom@tromey.com>
 896
 897         * NEWS: Fix typo.
 898
 899 2019-05-22  Tom Tromey  <tromey@adacore.com>
 900
 901         * target.c (target_follow_exec): Constify parameter.
 902         * target-delegates.c: Rebuild.
 903         * remote.c (remote_target::follow_exec): Constify parameter.
 904         * infrun.c (follow_exec): Constify parameter.
 905         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 906         (target_follow_exec): Likewise.
 907
 908 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 909
 910         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 911         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 912
 913 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 914
 915         * NEWS: Add debugredirect and testsuite sections.
 916
 917 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 918
 919         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 920         target descriptions using exclusively floating point register name
 921         aliases.
 922
 923 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         PR gdb/18644:
 926         * f-lang.c (build_fortran_types): Handle the case where
 927         gdbarch_floatformat_for_type returns a nullptr.
 928
 929 2019-05-21  Tom de Vries  <tdevries@suse.de>
 930
 931         PR cli/24587
 932         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 933
 934 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         PR gdb/18644:
 937         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 938         16-byte floats.
 939         * i386-tdep.c (i386_floatformat_for_type): Use
 940         floatformats_ia64_quad for the 16-byte floating point component
 941         within a fortran 32-byte complex number.
 942
 943 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 946         delete default constructor.
 947         (find_partial_die): Update to return const struct.
 948         (partial_die_parent_scope): Move variable declaration into scope
 949         of its use and change its type to auto.
 950         (guess_partial_die_structure_name): Likewise.
 951         (partial_die_info::fixup): Likewise.
 952
 953 2019-05-17  Tom Tromey  <tromey@adacore.com>
 954
 955         * source.c (find_and_open_source): Remove cast.
 956
 957 2019-05-17  Tom Tromey  <tromey@adacore.com>
 958
 959         * annotate.c (annotate_source): Make "filename" const.
 960         * annotate.h (annotate_source): Use const.
 961
 962 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 963
 964         * disasm.c (set_disassembler_options): Send errors to stderr.
 965
 966 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 967
 968         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 969         (cli_interp_base::set_logging): Check debug_redirect.
 970         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 971         * cli/cli-logging.c (debug_redirect): Add static variable.
 972         (pop_output_files): Add default param.
 973         (handle_redirections): Print debug setting.
 974         (show_logging_command): Likewise.
 975         (_initialize_cli_logging): Add debugredirect command.
 976         * interps.c (current_interp_set_logging): Add debug_redirect
 977         parameter.
 978         * interps.h (set_logging): Add debug_redirect parameter.
 979         (current_interp_set_logging): Likewise.
 980         * mi/mi-common.h: Likewise.
 981         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 982
 983 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 984             Tom Tromey  <tromey@adacore.com>
 985
 986         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 987         directly.
 988         * cli/cli-interp.h (make_logging_output): Remove declaration.
 989         * cli/cli-logging.c (make_logging_output): Remove function.
 990         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 991         directly.
 992         * ui-file.c (tee_file::tee_file): Remove bools.
 993         (tee_file::~tee_file): Remove deletes.
 994         * ui-file.h (tee_file): Remove bools.
 995
 996 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 997
 998         * mi/mi-cmds.h (mi_cmd_complete): New function.
 999         * mi/mi-main.c (mi_cmd_complete): Likewise.
1000         * mi/mi-cmds.c: Define new MI command -complete.
1001         * NEWS: Mention new -complete command.
1002
1003 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1004
1005         * completer.h (complete): New function.
1006         * completer.c (complete): Likewise.
1007         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1008         function defined in completer.h.
1009
1010 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1011
1012         * MAINTAINERS (Write After Approval): Add myself.
1013
1014 2019-05-17  Tom de Vries  <tdevries@suse.de>
1015
1016         PR gdb/24094
1017         * dwarf2read.c (struct cu_partial_die_info): New struct.
1018         (find_partial_die): Return cu_partial_die_info.
1019         (partial_die_parent_scope, guess_partial_die_structure_name)
1020         (partial_die_info::fixup): Handle new return type of find_partial_die.
1021
1022 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1023
1024         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1025         "std::string", simplifying the algorithm.
1026
1027 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1028
1029         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1030         (stap_static_probe_ops::get_probes): Likewise.
1031
1032 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1033
1034         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1035         '-')" and "else if".
1036         (stap_parse_single_operand): Join checks for
1037         "gdbarch_stap_parse_special_token_p" and
1038         "gdbarch_stap_parse_special_token" in the same "if" statement.
1039         Invert check when verifying for operation on register
1040         displacement.
1041
1042 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1043
1044         * stap-probe.c (stap_get_opcode): Update comment.
1045         (stap_get_expected_argument_type): Likewise.
1046         (handle_stap_probe): Likewise.
1047
1048 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1049
1050         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1051         return type to 'bool'.  Adjust comment.  Use 'bool' when
1052         appropriate.
1053         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1054         * stap-probe.c (stap_parse_argument_1): Likewise.
1055         (stap_is_operator): Likewise.
1056         (stap_is_generic_prefix): Likewise.
1057         (stap_is_register_prefix): Likewise.
1058         (stap_is_register_indirection_prefix): Likewise.
1059         (stap_is_integer_prefix): Likewise.
1060         (stap_generic_check_suffix): Likewise.
1061         (stap_check_integer_suffix): Likewise.
1062         (stap_check_register_suffix): Likewise.
1063         (stap_check_register_indirection_suffix): Likewise.
1064         (stap_parse_register_operand): Likewise.
1065         (stap_parse_single_operand): Likewise.
1066         (stap_parse_argument_1): Likewise.
1067         (stap_probe::get_argument_count): Likewise.
1068         (stap_is_operator): Likewise.
1069
1070 2019-05-16  Tom Tromey  <tromey@adacore.com>
1071
1072         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1073         keyword to foreach.
1074
1075 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1076
1077         * linux-thread-db.c (try_thread_db_load_1): Change return type
1078         to bool.
1079         (try_thread_db_load): Likewise.
1080         (try_thread_db_load_from_pdir_1): Likewise.
1081         (try_thread_db_load_from_pdir): Likewise.
1082         (try_thread_db_load_from_sdir): Likewise.
1083         (try_thread_db_load_from_dir): Likewise.
1084         (thread_db_load_search): Likewise.
1085         (has_libpthread): Likewise.
1086         (thread_db_load): Likewise.
1087
1088 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1089
1090         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1091         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1092         NULL, and complain/return if that's the case.
1093
1094 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1095
1096         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1097         (advance, posn, abstract_read_memory): New functions.
1098         [struct mem_read_abstraction]: New struct.
1099         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1100
1101 2019-05-14  Tom Tromey  <tromey@adacore.com>
1102
1103         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1104         value is not lval_memory.
1105
1106 2019-05-14  Tom Tromey  <tromey@adacore.com>
1107
1108         * solib.c (info_sharedlibrary_command): Style the file name.
1109
1110 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1111
1112         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1113         (aarch64_vnv_type): Likewise.
1114         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1115         * common/tdesc.c: Likewise.
1116         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1117         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1118         * features/aarch64-fpu.xml: Add ieee half view.
1119         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1120         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1121         * gdbtypes.h (struct builtin_type): Likewise.
1122         (struct objfile_type): Likewise.
1123
1124 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1125
1126         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1127         typo.
1128         * location.h (string_to_event_location): Likewise.
1129
1130 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1131
1132         GDB 8.3 released.
1133
1134 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1135
1136         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1137         New variable declaration.
1138         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1139         New variable.
1140         (print_one_breakpoint): Use ui_out::test_flags and new global
1141         variable to compute use_fixed_output.
1142         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1143         Remove.
1144         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1145         (mi_multi_location_breakpoint_output_fixed): Remove.
1146         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1147         new variable.
1148         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1149         fix_multi_location_breakpoint_output flag if version >= 3.
1150         * ui-out.h (enum ui_out_flag)
1151         <fix_multi_location_breakpoint_output>: New enumerator.
1152
1153 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1154
1155         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1156
1157 2019-05-10  Tom Tromey  <tromey@adacore.com>
1158
1159         * ada-lang.c (catch_ada_completer): New function.
1160         (_initialize_ada_language): Use it.
1161
1162 2019-05-10  Tom Tromey  <tromey@adacore.com>
1163
1164         * thread.c (print_thread_info): Make "requested_threads" const.
1165         * gdbthread.h (print_thread_info): Make "requested_threads"
1166         const.
1167         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1168         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1169
1170 2019-05-08  Tom Tromey  <tom@tromey.com>
1171
1172         * gdbtypes.c (objfile_type_data): Change type.
1173         (objfile_type, _initialize_gdbtypes): Update.
1174
1175 2019-05-08  Tom Tromey  <tom@tromey.com>
1176
1177         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1178         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1179         (_initialize_dwarf2_frame): Update.
1180
1181 2019-05-08  Tom Tromey  <tom@tromey.com>
1182
1183         * objc-lang.c (objc_objfile_data): Change type.
1184         (find_methods): Update.
1185         (_initialize_objc_lang): Remove.
1186
1187 2019-05-08  Tom Tromey  <tom@tromey.com>
1188
1189         * stabsread.c (rs6000_builtin_type_data): Change type.
1190         (rs6000_builtin_type, _initialize_stabsread): Update.
1191
1192 2019-05-08  Tom Tromey  <tom@tromey.com>
1193
1194         * mips-tdep.c (mips_pdr_data): Remove.
1195         (_initialize_mips_tdep): Update.
1196
1197 2019-05-08  Tom Tromey  <tom@tromey.com>
1198
1199         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1200         (hppa_init_objfile_priv_data, read_unwind_info)
1201         (find_unwind_entry, _initialize_hppa_tdep): Update.
1202
1203 2019-05-08  Tom Tromey  <tom@tromey.com>
1204
1205         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1206         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1207         on obstack.
1208         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1209
1210 2019-05-08  Tom Tromey  <tom@tromey.com>
1211
1212         * mdebugread.c (basic_type_data): Change type.
1213         (basic_type, _initialize_mdebugread): Update.
1214
1215 2019-05-08  Tom Tromey  <tom@tromey.com>
1216
1217         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1218
1219 2019-05-08  Tom Tromey  <tom@tromey.com>
1220
1221         * nto-tdep.c (nto_inferior_data_reg): Change type.
1222         (nto_inferior_data): Update.
1223         (nto_inferior_data_cleanup, nto_new_inferior_data)
1224         (_initialize_nto_tdep): Remove.
1225         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1226
1227 2019-05-08  Tom Tromey  <tom@tromey.com>
1228
1229         * ada-lang.c (struct ada_inferior_data): Add initializers.
1230         (ada_inferior_data): Change type.
1231         (ada_inferior_data_cleanup): Remove.
1232         (get_ada_inferior_data, ada_inferior_exit)
1233         (struct ada_pspace_data): Add initializers, destructor.
1234         (ada_pspace_data_handle): Change type.
1235         (get_ada_pspace_data): Update.
1236         (ada_pspace_data_cleanup): Remove.
1237
1238 2019-05-08  Tom Tromey  <tom@tromey.com>
1239
1240         * coffread.c (struct coff_symfile_info): Add initializers.
1241         (coff_objfile_data_key): Move lower.  Change type.
1242         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1243         Update.
1244         (coff_free_info): Remove.
1245
1246 2019-05-08  Tom Tromey  <tom@tromey.com>
1247
1248         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1249         (fbsd_pspace_data_handle): Move lower.  Change type.
1250         (get_fbsd_pspace_data): Update.
1251         (fbsd_pspace_data_cleanup): Remove.
1252         (_initialize_fbsd_tdep): Update.
1253
1254 2019-05-08  Tom Tromey  <tom@tromey.com>
1255
1256         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1257         (get_ada_tasks_pspace_data): Update.
1258         (ada_tasks_pspace_data_cleanup): Remove.
1259         (_initialize_tasks): Update.
1260         (ada_tasks_inferior_data_handle): Change type.
1261         (get_ada_tasks_inferior_data): Update.
1262         (ada_tasks_inferior_data_cleanup): Remove.
1263         (struct ada_tasks_pspace_data): Add initializers.
1264
1265 2019-05-08  Tom Tromey  <tom@tromey.com>
1266
1267         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1268         * symfile-debug.c (debug_sym_get_probes): Change type.
1269         * stap-probe.c (handle_stap_probe):
1270         (stap_static_probe_ops::get_probes): Change type.
1271         * probe.h (class static_probe_ops) <get_probes>: Change type.
1272         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1273         (parse_probes_in_pspace): Update.
1274         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1275         Update.
1276         (any_static_probe_ops::get_probes): Change type.
1277         * elfread.c (elfread_data): New typedef.
1278         (probe_key): Change type.
1279         (elf_get_probes): Likewise.  Update.
1280         (probe_key_free): Remove.
1281         (_initialize_elfread): Update.
1282         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1283         Change type.
1284         (dtrace_process_dof_probe, dtrace_process_dof)
1285         (dtrace_static_probe_ops::get_probe): Change type.
1286
1287 2019-05-08  Tom Tromey  <tom@tromey.com>
1288
1289         * xcoffread.c (struct xcoff_symfile_info): Rename from
1290         coff_symfile_info.  Add initializers.
1291         (xcoff_objfile_data_key): Move lower.  Change type.
1292         (XCOFF_DATA): Rewrite.
1293         (xcoff_free_info): Remove.
1294         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1295         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1296         (xcoff_initial_scan): Update.
1297
1298 2019-05-08  Tom Tromey  <tom@tromey.com>
1299
1300         * solib-svr4.c (struct svr4_info): Add initializers and
1301         destructor.
1302         <probes_table>: Now an htab_up.
1303         (solib_svr4_pspace_data): Change type.
1304         (free_probes_table): Simplify.
1305         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1306         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1307         (probes_table_remove_objfile_probes, register_solib_event_probe)
1308         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1309         (_initialize_svr4_solib): Update.
1310
1311 2019-05-08  Tom Tromey  <tom@tromey.com>
1312
1313         * remote.c (remote_pspace_data): Change type.
1314         (remote_pspace_data_cleanup): Remove.
1315         (get_remote_exec_file, set_pspace_remote_exec_file)
1316         (_initialize_remote): Update.
1317
1318 2019-05-08  Tom Tromey  <tom@tromey.com>
1319
1320         * breakpoint.c (breakpoint_objfile_key): Change type.
1321         (get_breakpoint_objfile_data): Update.
1322         (free_breakpoint_objfile_data): Remove.
1323         (_initialize_breakpoint): Update.
1324
1325 2019-05-08  Tom Tromey  <tom@tromey.com>
1326
1327         * linux-tdep.c (struct linux_info): Add initializers.
1328         (linux_inferior_data): Move.  Change type.
1329         (invalidate_linux_cache_inf): Update.
1330         (linux_inferior_data_cleanup): Remove.
1331         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1332
1333 2019-05-08  Tom Tromey  <tom@tromey.com>
1334
1335         * auxv.c (auxv_inferior_data): Move.  Change type.
1336         (auxv_inferior_data_cleanup): Remove.
1337         (invalidate_auxv_cache_inf): Rewrite.
1338         (get_auxv_inferior_data, _initialize_auxv): Update.
1339
1340 2019-05-08  Tom Tromey  <tom@tromey.com>
1341
1342         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1343         (symfile_debug_objfile_data_key): Change type.
1344         (symfile_debug_installed, debug_qf_has_symbols)
1345         (debug_qf_find_last_source_symtab)
1346         (debug_qf_forget_cached_source_info)
1347         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1348         (debug_qf_print_stats, debug_qf_dump)
1349         (debug_qf_expand_symtabs_for_function)
1350         (debug_qf_expand_all_symtabs)
1351         (debug_qf_expand_symtabs_with_fullname)
1352         (debug_qf_map_matching_symbols)
1353         (debug_qf_expand_symtabs_matching)
1354         (debug_qf_find_pc_sect_compunit_symtab)
1355         (debug_qf_map_symbol_filenames)
1356         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1357         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1358         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1359         (debug_sym_read_linetable, debug_sym_relocate): Update.
1360         (symfile_debug_free_objfile): Remove.
1361         (install_symfile_debug_logging, _initialize_symfile_debug):
1362         Update.
1363
1364 2019-05-08  Tom Tromey  <tom@tromey.com>
1365
1366         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1367         allocate_on_obstack.
1368         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1369         (get_dwarf2_per_objfile): Update.
1370         (set_dwarf2_per_objfile): Remove.
1371         (dwarf2_has_info, dwarf2_get_section_info): Update.
1372         (dwarf2_free_objfile): Remove.
1373         (_initialize_dwarf2_read): Update.
1374
1375 2019-05-08  Tom Tromey  <tom@tromey.com>
1376
1377         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1378         initializers.
1379         <unsupported_script_warning_printed,
1380         script_not_found_warning_printed>: Now bool.
1381         (auto_load_pspace_data): Change type.
1382         (~auto_load_pspace_info): Rename from
1383         auto_load_pspace_data_cleanup.
1384         (get_auto_load_pspace_data, init_loaded_scripts_info)
1385         (clear_section_scripts, maybe_print_unsupported_script_warning)
1386         (maybe_print_script_not_found_warning, _initialize_auto_load):
1387         Update.
1388
1389 2019-05-08  Tom Tromey  <tom@tromey.com>
1390
1391         * objfiles.c (objfile_pspace_info): Add destructor and
1392         initializers.
1393         (objfiles_pspace_data): Change type.
1394         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1395         (get_objfile_pspace_data): Update.
1396         (objfiles_bfd_data): Change type.
1397         (get_objfile_bfd_data): Update.
1398         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1399
1400 2019-05-08  Tom Tromey  <tom@tromey.com>
1401
1402         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1403         Change type.
1404         (get_catch_syscall_inferior_data): Update.
1405         (catch_syscall_inferior_data_cleanup): Remove.
1406         (_initialize_break_catch_syscall): Update.
1407
1408 2019-05-08  Tom Tromey  <tom@tromey.com>
1409
1410         * inflow.c (struct terminal_info): Add destructor and
1411         initializers.
1412         (inflow_inferior_data): Change type.
1413         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1414         (get_inflow_inferior_data, inflow_inferior_exit)
1415         (swap_terminal_info, _initialize_inflow): Update.
1416
1417 2019-05-08  Tom Tromey  <tom@tromey.com>
1418
1419         * target-dcache.c (target_dcache_cleanup): Remove.
1420         (target_dcache_aspace_key): Change type.
1421         (target_dcache_init_p, target_dcache_invalidate)
1422         (target_dcache_get, target_dcache_get_or_init)
1423         (_initialize_target_dcache): Update.
1424         * dcache.h (struct dcache_deleter): New.
1425
1426 2019-05-08  Tom Tromey  <tom@tromey.com>
1427
1428         * symtab.c (struct symbol_cache): Add destructor and
1429         initializers.
1430         (symbol_cache_key): Move.  Change type.
1431         (make_symbol_cache, free_symbol_cache): Remove.
1432         (get_symbol_cache): Update.
1433         (symbol_cache_cleanup): Remove.
1434         (ALL_PSPACES, symbol_cache_flush)
1435         (maintenance_print_symbol_cache)
1436         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1437         Update.
1438
1439 2019-05-08  Tom Tromey  <tom@tromey.com>
1440
1441         * symtab.c (struct main_info): Add destructor and initializers.
1442         (main_progspace_key): Move.  Change type.
1443         (get_main_info): Update.
1444         (main_info_cleanup): Remove.
1445         (_initialize_symtab): Update.
1446
1447 2019-05-08  Tom Tromey  <tom@tromey.com>
1448
1449         * registry.h (DECLARE_REGISTRY): Define the _key class.
1450
1451 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * NEWS: Merge two 'New commands' sections.
1454
1455 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1456
1457         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1458         parameter and use Ada language definition instead.
1459         (ada_val_print_ptr): Remove unused language parameter.
1460         (ada_val_print_num): Remove language parameter and use Ada language
1461         definition instead.
1462         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1463         parameter.
1464         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1465         parameter and use Ada language definition instead.
1466         (ada_val_print_1): Update all ada_val_print_xxx calls.
1467         Remove language parameter.
1468         (ada_val_print): Update ada_val_print_1 call.
1469
1470 2019-05-08  Tom Tromey  <tromey@adacore.com>
1471
1472         * remote.c (remote_hw_watchpoint_limit)
1473         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1474         Now static.
1475
1476 2019-05-08  Tom Tromey  <tromey@adacore.com>
1477
1478         * maint.c (_initialize_maint_cmds): Move initialization code to
1479         remote.c.
1480         (watchdog, show_watchdog): Move to remote.c.
1481         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1482         "watchdog" static.
1483         (_initialize_remote): Move initialization code from maint.c.
1484         * defs.h (watchdog): Don't declare.
1485
1486 2019-05-08  Tom Tromey  <tromey@adacore.com>
1487
1488         * tui/tui-interp.c: Include main.h.
1489         * interps.c: Include main.h.
1490         * main.h (interpreter_p): Declare.
1491         * defs.h (interpreter_p): Don't declare.
1492
1493 2019-05-08  Tom Tromey  <tromey@adacore.com>
1494
1495         * dwarf2loc.c: Include dwarf2read.h.
1496         * defs.h (read_unsigned_leb128): Don't declare.
1497         * dwarf2read.h (read_unsigned_leb128): Declare.
1498
1499 2019-05-08  Tom Tromey  <tromey@adacore.com>
1500
1501         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1502         method.
1503
1504 2019-05-08  Tom Tromey  <tromey@adacore.com>
1505
1506         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1507         when no wrap column is set.
1508
1509 2019-05-08  Tom Tromey  <tromey@adacore.com>
1510
1511         * c-lang.c (c_get_string): Handle non-C-style arrays.
1512
1513 2019-05-08  Tom Tromey  <tromey@adacore.com>
1514
1515         * typeprint.c (print_offset_data::update): Print the bit offset,
1516         not the number of bits remaining.
1517
1518 2019-05-08  Tom Tromey  <tromey@adacore.com>
1519
1520         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1521         padding at end of comment.
1522
1523 2019-05-08  Tom Tromey  <tromey@adacore.com>
1524
1525         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1526         Compare main types.
1527
1528 2019-05-06  Tom Tromey  <tom@tromey.com>
1529
1530         * common/scoped_mmap.c: Include common-defs.h.
1531         * common/scoped_mmap.h: Don't include config.h.
1532
1533 2019-05-04  Tom Tromey  <tom@tromey.com>
1534
1535         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1536         (struct aarch64_call_info): Add initializers.
1537         <si>: Now a std::vector.
1538         (pass_on_stack, aarch64_push_dummy_call): Update.
1539
1540 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1541             Tom Tromey  <tom@tromey.com>
1542
1543         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1544         (ppc_threads): Now a std::vector.  Now static.
1545         (hwdebug_find_thread_points_by_tid)
1546         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1547         Update.
1548
1549 2019-05-04  Tom Tromey  <tom@tromey.com>
1550
1551         * arc-tdep.c (arc_tdesc_init): Return bool.
1552
1553 2019-05-04  Tom Tromey  <tom@tromey.com>
1554
1555         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1556         Use gdb_assert_not_reached.
1557
1558 2019-05-04  Tom Tromey  <tom@tromey.com>
1559
1560         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1561         "false".
1562
1563 2019-05-04  Tom Tromey  <tom@tromey.com>
1564
1565         * arc-tdep.c (arc_tdesc_init): Use bool.
1566
1567 2019-05-04  Tom Tromey  <tom@tromey.com>
1568
1569         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1570
1571 2019-05-04  Tom Tromey  <tom@tromey.com>
1572
1573         * cli/cli-cmds.c (valid_command_p): Return bool.
1574
1575 2019-05-04  Tom Tromey  <tom@tromey.com>
1576
1577         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1578         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1579
1580 2019-05-04  Raul Tambre  <raul@tambre.ee>
1581
1582         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1583         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1584         operator for comparison.
1585
1586 2019-05-04  Tom Tromey  <tom@tromey.com>
1587
1588         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1589         (lookup_partial_symbol, print_partial_symbols)
1590         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1591         (psymbol_compare): Update.
1592         (add_psymbol_to_bcache): Clear the entire psymbol.
1593         (maintenance_check_psymtabs): Update.
1594         * psympriv.h (struct partial_symbol): Don't derive from
1595         general_symbol_info.
1596         <obj_section, unrelocated_address, address,
1597         set_unrelocated_address>: Update.
1598         <ginfo>: New member.
1599         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1600         (debug_names::write_psymbols): Update.
1601
1602 2019-05-04  Tom de Vries  <tdevries@suse.de>
1603
1604         * contrib/cc-with-tweaks.sh: Support -n arg.
1605
1606 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1607
1608         * corelow.c (core_target::detach): Ensure frame cache and
1609         register caches are cleared.
1610         inferior.c (exit_inferior_1): Likewise.
1611
1612 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1613             Tom Tromey  <tom@tromey.com>
1614
1615         * dictionary.c (collate_pending_symbols_by_language): Remove
1616         "struct" from foreach.
1617         * symtab.c (lookup_global_symbol_from_objfile)
1618         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1619         foreach.
1620         * ser-tcp.c (net_open): Remove "struct" from foreach.
1621         * objfiles.c (objfile_relocate, objfile_rebase)
1622         (objfile_has_symbols): Remove "struct" from foreach.
1623         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1624         from foreach.
1625         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1626         foreach.
1627         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1628         "struct" from foreach.
1629         * ada-lang.c (create_excep_cond_exprs)
1630         (ada_exception_catchpoint_cond_string): Remove "struct" from
1631         foreach.
1632
1633 2019-05-03  Tom Tromey  <tromey@adacore.com>
1634
1635         * ada-exp.y (convert_char_literal): Check suffix of each
1636         enumerator.
1637
1638 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1639
1640         PR ada/21406:
1641         * ada-exp.y (yywrap): Don't define.
1642         * ada-lex.l (%option): Add noyywrap
1643         (yywrap): Remove.
1644
1645 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1646
1647         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1648         _WIN32_WINNT to the XP level, unless already defined to a higher
1649         level.
1650
1651         * unittests/parse-connection-spec-selftests.c:
1652         * ser-tcp.c:
1653         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1654         override.
1655
1656         * symfile.c (find_separate_debug_file): Remove colon from the
1657         drive spec of DOS/Windows file names of the target, so that the
1658         file name produced from DEBUGDIR and the target's directory will
1659         be valid on DOS/Windows systems.
1660
1661 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1662
1663         * rust-lang.c (val_print_struct): Handle printing structures
1664         containing strings.
1665
1666 2019-05-02  Tom Tromey  <tromey@adacore.com>
1667
1668         * valarith.c (_initialize_valarith): Remove.
1669
1670 2019-05-01  Tom Tromey  <tromey@adacore.com>
1671
1672         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1673         bitfields.
1674
1675 2019-05-01  Tom Tromey  <tromey@adacore.com>
1676
1677         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1678         for big-endian copies.
1679
1680 2019-04-30  Ali Tamur  <tamur@google.com>
1681         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1682         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1683         (read_3_bytes): New function.
1684
1685 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1686
1687         * windows-nat.c (main_thread_id): Delete.
1688         (handle_output_debug_string): Replace main_thread_id by
1689         current_event.dwThreadId.
1690         (fake_create_process): Likewise.
1691         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1692         Do not set main_thread_id.
1693         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1694         current_event.dwThreadId.
1695         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1696
1697 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1698
1699         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1700         Use current_event.dwThreadId instead of main_thread_id.
1701
1702 2019-04-30  Tom Tromey  <tromey@adacore.com>
1703
1704         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1705         (create_excep_cond_exprs): Iterate over program spaces.
1706         (ada_exception_catchpoint_cond_string): Examine all minimal
1707         symbols for exception types.
1708
1709 2019-04-30  Tom Tromey  <tromey@adacore.com>
1710
1711         PR c++/24470:
1712         * dwarf2read.c (process_structure_scope): Handle case where type
1713         has template parameters but no symbol was created.
1714
1715 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1716             Chris January  <chris.january@arm.com>
1717
1718         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1719         qualifier.
1720         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1721
1722 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1723
1724         * f-typeprint.c (f_print_type): Update rules for printing
1725         whitespace.
1726         (f_type_print_varspec_suffix): Likewise.
1727
1728 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1729             Chris January  <chris.january@arm.com>
1730
1731         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1732         function arguments.
1733
1734 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1735
1736         * f-lang.c (build_fortran_types): Change name of void type to
1737         lower case.
1738         * f-typeprint.c (f_type_print_base): Print the name of the void
1739         type, rather than a fixed string.
1740         * f-valprint.c (f_decorations): Use lower case void string.
1741
1742 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1743             Chris January  <chris.january@arm.com>
1744
1745         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1746         types for Fortran.
1747
1748 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1749             Chris January  <chris.january@arm.com>
1750             David Lecomber  <david.lecomber@arm.com>
1751
1752         * f-exp.y (BINOP_INTRINSIC): New token.
1753         (exp): New parser rule handling BINOP_INTRINSIC.
1754         (f77_keywords): Add new builtin procedures.
1755         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1756         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1757         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1758         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1759         (print_unop_subexp_f): New function.
1760         (print_binop_subexp_f): New function.
1761         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1762         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1763         (dump_subexp_body_f): Likewise.
1764         (operator_check_f): Likewise.
1765         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1766         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1767
1768 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1771         UNOP_KIND.
1772         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1773         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1774         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1775         (operator_length_f): New fuction.
1776         (print_subexp_f): New function.
1777         (op_name_f): New function.
1778         (dump_subexp_body_f): New function.
1779         (operator_check_f): New function.
1780         (exp_descriptor_f): Replace standard expression handling functions
1781         with new functions.
1782         * gdb/fortran-operator.def: New file.
1783         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1784         * gdb/std-operator.def: Remove UNOP_KIND.
1785
1786 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1787
1788         * std-operator.def: Remove unbalanced, stray double quote
1789         character.
1790
1791 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1792             Chris January  <chris.january@arm.com>
1793             Daniel Everett  <daniel.everett@arm.com>
1794             Nick Forrington  <nick.forrington@arm.com>
1795             Richard Bunt  <richard.bunt@arm.com>
1796
1797         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1798         of depth when printing anonymous structs or unions.
1799         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1800         Don't print either the top-level value, or the children if the
1801         max-depth is exceeded.
1802         (ppscm_print_children): When printing the key of a map, allow one
1803         extra level of depth.
1804         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1805         print either the top-level value, or the children if the max-depth
1806         is exceeded.
1807         (print_children): When printing the key of a map, allow one extra
1808         level of depth.
1809         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1810         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1811         (user_print_options): Initialise max_depth field.
1812         (val_print_scalar_or_string_type_p): New function.
1813         (val_print): Check to see if the max depth has been reached.
1814         (val_print_check_max_depth): Define new function.
1815         (show_print_max_depth): New function.
1816         (_initialize_valprint): Add 'print max-depth' option.
1817         * valprint.h (struct value_print_options) <max_depth>: New field.
1818         (val_print_check_max_depth): Declare new function.
1819         * NEWS: Document new feature.
1820
1821 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1822
1823         * ada-lang.c (ada_language_defn): Initialise new field.
1824         * c-lang.c (c_is_string_type_p): New function.
1825         (c_language_defn): Initialise new field.
1826         (cplus_language_defn): Initialise new field.
1827         (asm_language_defn): Initialise new field.
1828         (minimal_language_defn): Initialise new field.
1829         * c-lang.h (c_is_string_type_p): Declare new function.
1830         * d-lang.c (d_language_defn): Initialise new field.
1831         * f-lang.c (f_is_string_type_p): New function.
1832         (f_language_defn): Initialise new field.
1833         * go-lang.c (go_is_string_type_p): New function.
1834         (go_language_defn): Initialise new field.
1835         * language.c (default_is_string_type_p): New function.
1836         (unknown_language_defn): Initialise new field.
1837         (auto_language_defn): Initialise new field.
1838         * language.h (struct language_defn) <la_is_string_type_p>: New
1839         member variable.
1840         (default_is_string_type_p): Declare new function.
1841         * m2-lang.c (m2_language_defn): Initialise new field.
1842         * objc-lang.c (objc_language_defn): Initialise new field.
1843         * opencl-lang.c (opencl_language_defn): Initialise new field.
1844         * p-lang.c (pascal_is_string_type_p): New function.
1845         (pascal_language_defn): Initialise new field.
1846         * rust-lang.c (rust_is_string_type_p): New function.
1847         (rust_language_defn): Initialise new field.
1848
1849 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1850
1851         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1852         New field.
1853         * ada-lang.c (ada_language_defn): Initialise new field.
1854         * c-lang.c (c_language_defn): Likewise.
1855         (cplus_language_defn): Likewise.
1856         (asm_language_defn): Likewise.
1857         (minimal_language_defn): Likewise.
1858         * d-lang.c (d_language_defn): Likewise.
1859         * f-lang.c (f_language_defn): Likewise.
1860         * go-lang.c (go_language_defn): Likewise.
1861         * language.c (unknown_language_defn): Likewise.
1862         (auto_language_defn): Likewise.
1863         * m2-lang.c (m2_language_defn): Likewise.
1864         * objc-lang.c (objc_language_defn): Likewise.
1865         * opencl-lang.c (opencl_language_defn): Likewise.
1866         * p-lang.c (pascal_language_defn): Likewise.
1867         * rust-lang.c (rust_language_defn): Likewise.
1868
1869 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * ada-lang.c (ada_is_character_type): Change return type to bool.
1872         (ada_is_string_type): Likewise.
1873         * ada-lang.h (ada_is_character_type): Update declaration
1874         (ada_is_string_type): Likewise.
1875
1876 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1877
1878         Support style in 'frame|thread apply'
1879
1880         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1881         * record.c (record_start, record_stop): Update callers of
1882         execute_command_to_string with false.
1883         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1884         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1885         methods.
1886         (class string_file): New constructor with term_out parameter.
1887         Override methods term_out and can_emit_style_escape.  New member
1888         term_out.
1889         (class stdio_file): Override can_emit_style_escape.
1890         (class tee_file): Override term_out and can_emit_style_escape.
1891         * utils.h (can_emit_style_escape): Remove.
1892         * utils.c (can_emit_style_escape): Likewise.
1893         Update all callers of can_emit_style_escape (SOMESTREAM) to
1894         SOMESTREAM->can_emit_style_escape.
1895         * source-cache.c (source_cache::get_source_lines): Likewise.
1896         * stack.c (frame_apply_command_count): Call execute_command_to_string
1897         passing the term_out characteristic of the current gdb_stdout.
1898         * thread.c (thr_try_catch_cmd): Likewise.
1899         * top.c (execute_command_to_string): pass term_out parameter
1900         to construct the string_file for the command output.
1901         * ui-file.c (term_cli_styling): New function (most code moved
1902         from utils.c can_emit_style_escape).
1903         (string_file::string_file, string_file::can_emit_style_escape,
1904         stdio_file::can_emit_style_escape, tee_file::term_out,
1905         tee_file::can_emit_style_escape): New functions.
1906
1907 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1908
1909         * NEWS: Mention the new set|show may-call-functions.
1910         * infcall.c (may_call_functions_p): New variable.
1911         (show_may_call_functions_p): New function.
1912         (call_function_by_hand_dummy): Throws an error if not
1913         may-call-functions.
1914         (_initialize_infcall): Call add_setshow_boolean_cmd for
1915         may-call-functions.
1916
1917 2019-04-25  Keith Seitz  <keiths@redhat.com>
1918
1919         PR c++/24367
1920         * cp-support.c (inspect_type): Don't attempt substitutions
1921         of symbol with the same name.
1922
1923 2019-04-25  Tom Tromey  <tromey@adacore.com>
1924
1925         PR gdb/24475:
1926         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1927         static.
1928
1929 2019-04-25  Tom Tromey  <tromey@adacore.com>
1930
1931         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1932         rvalue reference.
1933         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1934         (gdb_xml_parser::parse): Use std::move.
1935         * python/python-internal.h (gdbpy_convert_exception): Take a const
1936         reference.
1937         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1938         std::move.
1939         * python/py-utils.c (gdbpy_convert_exception): Take a const
1940         reference.
1941         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1942         Use std::move.
1943         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1944         Use std::move.
1945         * mi/mi-main.c (mi_print_exception): Take a const reference.
1946         * main.c (handle_command_errors): Take a const reference.
1947         * linespec.c (parse_linespec): Use std::move.
1948         * infcall.c (run_inferior_call): Use std::move.
1949         (call_function_by_hand_dummy): Use std::move.
1950         * exec.c (try_open_exec_file): Use std::move.
1951         * exceptions.h (exception_print, exception_fprintf)
1952         (exception_print_same): Update.
1953         * exceptions.c (print_exception, exception_print)
1954         (exception_fprintf, exception_print_same): Change parameters to
1955         const reference.
1956         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1957         * common/new-op.c: Use std::move.
1958         * common/common-exceptions.h (struct gdb_exception): Add move
1959         constructor.
1960         (struct gdb_exception_error, struct gdb_exception_quit, struct
1961         gdb_quit_bad_alloc): Change constructor to move constructor.
1962         (throw_exception): Change parameter to rvalue reference.
1963         * common/common-exceptions.c (throw_exception): Take rvalue
1964         reference.
1965         * cli/cli-interp.c (safe_execute_command): Use std::move.
1966         * breakpoint.c (insert_bp_location, location_to_sals): Use
1967         std::move.
1968
1969 2019-04-25  Tom Tromey  <tromey@adacore.com>
1970
1971         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1972         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1973         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1974         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1975         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1976         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1977         guile/scm-value.c: Use unpack.
1978         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1979         gdbscm_gdb_exception.
1980         (gdbscm_throw_gdb_exception): Likewise.
1981         (struct gdbscm_gdb_exception): New.
1982         (unpack): New function.
1983         (gdbscm_wrap): Use unpack.
1984
1985 2019-04-25  Tom Tromey  <tromey@adacore.com>
1986
1987         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1988         (gdb_rl_callback_handler): Use std::move.
1989         * common/common-exceptions.h (struct gdb_exception): Add move
1990         assignment operator.
1991         (throw_exception_sjlj): Change "exception" to const reference.
1992         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1993         (throw_exception_sjlj): Change "exception" to const reference.
1994
1995 2019-04-25  Tom Tromey  <tromey@adacore.com>
1996
1997         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1998         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1999         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2000         Update.
2001         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2002         Update.
2003         * mi/mi-interp.c (mi_interp::exec): Update.
2004         * linespec.c (parse_linespec): Update.
2005         * infcall.c (run_inferior_call): Update.
2006         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2007         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2008         (gdbscm_lookup_global_symbol): Update.
2009         * guile/scm-param.c (gdbscm_parameter_value): Update.
2010         * guile/scm-frame.c (gdbscm_frame_read_register)
2011         (gdbscm_frame_read_var): Update.
2012         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2013         * exec.c (try_open_exec_file): Update.
2014         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2015         (gdb_rl_callback_handler): Update.
2016         * common/common-exceptions.h (exception_none): Don't declare.
2017         * common/common-exceptions.c (exception_none): Don't define.
2018         (struct catcher) <exception>: Update.
2019         * cli/cli-interp.c (safe_execute_command): Update.
2020         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2021
2022 2019-04-25  Ali Tamur  <tamur@google.com>
2023
2024         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2025         (read_attribute_value): Likewise.
2026         (dwarf2_read_addr_index): Update comment.
2027         (read_str_index): Add DW_FORM_strx.
2028         (dwarf2_string_attr): Likewise.
2029         (dwarf2_const_value_attr): Likewise.
2030         (dump_die_shallow): Likewise.
2031         (dwarf2_fetch_constant_bytes): Likewise.
2032         (skip_form_bytes): Likewise.
2033         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2034
2035 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2036
2037         PR corefiles/11608
2038         PR corefiles/18187
2039         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2040         OFFSET.  Verify if current mapping contains an ELF header.
2041         (linux_find_memory_regions_full): Adjust call to
2042         dump_mapping_p.
2043
2044 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2045             Kang Li <kanglictf@gmail.com>
2046
2047         PR gdb/21600
2048
2049         * dwarf2-frame.c (read_initial_length): Be consistent about using
2050         unsigned representation of length.
2051         (decode_frame_entry_1): Likewise.  Check for wraparound of
2052         end pointer as well as buffer overflow.
2053
2054 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2055
2056         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2057         "vq".
2058
2059 2019-04-24  Tom Tromey  <tromey@adacore.com>
2060
2061         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2062
2063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2064
2065         * s12z-tdep.c (s12z_unwind_pc): Delete.
2066         (s12z_unwind_sp): Delete.
2067         (s12z_gdbarch_init): Don't register deleted functions with
2068         gdbarch.
2069
2070 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2071
2072         * rl78-tdep.c (rl78_unwind_sp): Delete.
2073         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2074
2075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2076
2077         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2078         (xstormy16_unwind_pc): Delete.
2079         (xstormy16_dummy_id): Delete.
2080         (xstormy16_gdbarch_init): Don't register deleted functions with
2081         gdbarch.
2082
2083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2084
2085         * vax-tdep.c (vax_unwind_pc): Delete.
2086         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2087
2088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * v850-tdep.c (v850_unwind_sp): Delete.
2091         (v850_unwind_pc): Delete.
2092         (v850_dummy_id): Delete.
2093         (v850_gdbarch_init): Don't register deleted functions with
2094         gdbarch.
2095
2096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2097
2098         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2099         (tilegx_unwind_pc): Delete.
2100         (tilegx_unwind_dummy_id): Delete.
2101         (tilegx_gdbarch_init): Don't register deleted functions with
2102         gdbarch.
2103
2104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2105
2106         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2107         (tic6x_dummy_id): Delete.
2108         (tic6x_gdbarch_init): Don't register deleted functions with
2109         gdbarch.
2110
2111 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2112
2113         * sparc-tdep.c (sparc_unwind_pc): Delete.
2114         (sparc32_gdbarch_init): Don't register deleted function with
2115         gdbarch.
2116
2117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2118
2119         * sh-tdep.c (sh_unwind_sp): Delete.
2120         (sh_unwind_pc): Delete.
2121         (sh_dummy_id): Delete.
2122         (sh_gdbarch_init): Don't register deleted functions with
2123         gdbarch.
2124
2125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2126
2127         * score-tdep.c (score_unwind_sp): Delete.
2128         (score_unwind_pc): Delete.
2129         (score_dummy_id): Delete.
2130         (score_gdbarch_init): Don't register deleted functions with
2131         gdbarch.
2132
2133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * rx-tdep.c (rx_unwind_pc): Delete.
2136         (rx_unwind_sp): Delete.
2137         (rx_dummy_id): Delete.
2138         (rx_gdbarch_init): Don't register deleted functions with
2139         gdbarch.  Update comment.
2140
2141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2144         (rs6000_dummy_id): Delete.
2145         (rs6000_gdbarch_init): Don't register deleted functions with
2146         gdbarch.
2147
2148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * or1k-tdep.c (or1k_dummy_id): Delete.
2151         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2152
2153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2154
2155         * nios2-tdep.c (nios2_dummy_id): Delete.
2156         (nios2_unwind_sp): Delete.
2157         (nios2_gdbarch_init): Don't register deleted functions with
2158         gdbarch.
2159
2160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * nds32-tdep.c (nds32_dummy_id): Delete.
2163         (nds32_unwind_pc): Delete.
2164         (nds32_unwind_sp): Delete.
2165         (nds32_gdbarch_init): Don't register deleted functions with
2166         gdbarch.
2167
2168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2169
2170         * msp430-tdep.c (msp430_unwind_pc): Delete.
2171         (msp430_unwind_sp): Delete.
2172         (msp430_dummy_id): Delete.
2173         (msp430_gdbarch_init): Don't register deleted functions with
2174         gdbarch.
2175
2176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * moxie-tdep.c (moxie_unwind_sp): Delete.
2179         (moxie_unwind_pc): Delete.
2180         (moxie_dummy_id): Delete.
2181         (moxie_gdbarch_init): Don't register deleted functions with
2182         gdbarch.
2183
2184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2185
2186         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2187         (mn10300_unwind_pc): Delete.
2188         (mn10300_unwind_sp): Delete.
2189         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2190         mn10300_unwind_sp.
2191         (mn10300_frame_unwind_init): Don't register deleted functions with
2192         gdbarch.
2193
2194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * mep-tdep.c (mep_unwind_pc): Delete.
2197         (mep_unwind_sp): Delete.
2198         (mep_dummy_id): Delete.
2199         (mep_gdbarch_init): Don't register deleted functions with
2200         gdbarch.
2201
2202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2205         (m68hc11_unwind_sp): Delete.
2206         (m68hc11_gdbarch_init): Don't register deleted functions with
2207         gdbarch.
2208
2209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * m32r-tdep.c (m32r_unwind_sp): Delete.
2212         (m32r_unwind_pc): Delete.
2213         (m32r_dummy_id): Delete.
2214         (m32r_gdbarch_init): Don't register deleted functions with
2215         gdbarch.
2216
2217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2218
2219         * m32c-tdep.c (m32c_unwind_pc): Delete.
2220         (m32c_unwind_sp): Delete.
2221         (m32c_dummy_id): Delete.
2222         (m32c_gdbarch_init): Don't register deleted functions with
2223         gdbarch.
2224
2225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2226
2227         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2228         (lm32_unwind_pc): Delete.
2229         (lm32_dummy_id): Delete.
2230         (lm32_gdbarch_init): Don't register deleted functions with
2231         gdbarch.
2232
2233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2236         (iq2000_unwind_pc): Delete.
2237         (iq2000_dummy_id): Delete.
2238         (iq2000_gdbarch_init): Don't register deleted functions with
2239         gdbarch.
2240
2241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * nds32-tdep.c (nds32_type_align): Delete.
2244         (nds32_push_dummy_call): Use type_align instead.
2245
2246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * arm-tdep.c (arm_type_align): Only handle vector override case.
2249         (arm_push_dummy_call): Use type_align.
2250         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2251
2252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2253
2254         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2255         case.
2256         (pass_on_stack): Use type_align.
2257         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2258         function.
2259
2260 2019-04-23  Tom Tromey  <tromey@adacore.com>
2261
2262         * dwarf2read.c (line_header::file_name_at): Remove unused
2263         overload.
2264
2265 2019-04-23  Tom de Vries  <tdevries@suse.de>
2266
2267         PR gdb/24438
2268         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2269         invocation.
2270
2271
2272 2019-03-27  Ali Tamur  <tamur@google.com>
2273
2274         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2275         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2276         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2277         (dwarf_expr_context::get_addr_index): Likewise
2278         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2279         (symbol_needs_eval_context::get_addr_index): Likewise
2280         (disassemble_dwarf_expression): Add DW_OP_addrx
2281         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2282         (read_cutu_die_from_dwo): Update comment
2283         (skip_one_die): Add DW_FORM_addrx
2284         (read_attribute_value): Likewise
2285         (var_decode_location): Add DW_OP_addrx
2286         (dwarf2_const_value_attr): Add DW_FORM_addrx
2287         (dump_die_shallow): Likewise
2288         (dwarf2_fetch_constant_bytes): Likewise
2289         (decode_locdesc): Add DW_OP_addrx
2290         (skip_form_bytes): Add DW_FORM_addrx
2291
2292 2019-04-22  Ali Tamur  <tamur@google.com>
2293
2294         * MAINTAINERS (Write After Approval): Add self.
2295
2296 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2297
2298         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2299         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2300         (open_symbol_file_object): Likewise.
2301         (svr4_default_sos): Add info parameter.
2302         (svr4_read_so_list): Likewise.
2303         (svr4_current_sos_direct): Adjust functions calls to pass down
2304         info.
2305         (svr4_current_sos_1): Add info parameter.
2306         (svr4_current_sos): Call get_svr4_info, pass info down to
2307         svr4_current_sos_1.
2308         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2309         get_svr4_info.
2310         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2311         get_svr4_info.
2312         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2313         to get_svr4_info.
2314         (probes_table_remove_objfile_probes): Likewise.
2315         (register_solib_event_probe): Add info parameter.
2316         (solist_update_incremental): Pass info parameter down to
2317         svr4_read_so_list.
2318         (disable_probes_interface): Add info parameter.
2319         (svr4_handle_solib_event): Pass current_program_space to
2320         get_svr4_info.  Adjust disable_probes_interface cleanup.
2321         (svr4_create_probe_breakpoints): Add info parameter, pass it
2322         down to register_solib_event_probe.
2323         (svr4_create_solib_event_breakpoints): Add info parameter,
2324         pass it down to svr4_create_probe_breakpoints.
2325         (enable_break): Pass info down to
2326         svr4_create_solib_event_breakpoints.
2327         (svr4_solib_create_inferior_hook): Pass current_program_space to
2328         get_svr4_info.
2329         (svr4_clear_solib): Likewise.
2330
2331 2019-04-22  Pedro Alves  <palves@redhat.com>
2332
2333         * solib-svr4.c (svr4_free_objfile_observer): New.
2334         (probe_and_action::objfile): New field.
2335         (probes_table_htab_remove_objfile_probes)
2336         (probes_table_remove_objfile_probes): New functions.
2337         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2338         in the new probe_and_action.  Don't store the probe in 'lookup'.
2339         (svr4_create_probe_breakpoints): Pass objfile to
2340         register_solib_event_probe.
2341         (_initialize_svr4_solib): Register a free_objfile observer.
2342
2343 2019-04-19  Tom Tromey  <tom@tromey.com>
2344
2345         * common/queue.h: Remove.
2346
2347 2019-04-19  Tom Tromey  <tom@tromey.com>
2348
2349         * event-loop.c: Don't include "common/queue.h".
2350
2351 2019-04-19  Tom Tromey  <tom@tromey.com>
2352
2353         * remote.c (remote_target): Use delete.
2354         * remote-notif.h: Include <list>, not "common/queue.h".
2355         (notif_client_p): Remove typedef.
2356         (remote_notif_state): Add constructor, destructor, initializer.
2357         <notif_queue>: Now a std::list.
2358         (remote_notif_state_xfree): Don't declare.
2359         * remote-notif.c (remote_notif_process, handle_notification)
2360         (remote_notif_state_allocate): Update.
2361         (~remote_notif_state): Rename from remote_notif_state_xfree.
2362
2363 2019-04-19  Tom Tromey  <tom@tromey.com>
2364
2365         * symfile.c (reread_symbols): Update.
2366         * objfiles.c (objfile_register_static_link)
2367         (objfile_lookup_static_link): Update
2368         (~objfile) Don't delete static_links.
2369         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2370
2371 2019-04-19  Tom Tromey  <tom@tromey.com>
2372
2373         * type-stack.h (struct type_stack) <insert>: Constify string.
2374         * type-stack.c (type_stack::insert): Constify string.
2375         * gdbtypes.h (lookup_template_type): Update.
2376         (address_space_name_to_int): Update.
2377         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2378         const.
2379         (lookup_template_type): Make name const.
2380         * c-exp.y: Update rules.
2381         (lex_one_token, classify_name, classify_inner_name)
2382         (c_print_token): Update.
2383         * p-exp.y: Update rules.
2384         (yylex): Update.
2385         * f-exp.y: Update rules.
2386         (yylex): Update.
2387         * d-exp.y: Update rules.
2388         (lex_one_token, classify_name, classify_inner_name): Update.
2389         * parse.c (write_dollar_variable, copy_name): Return std::string.
2390         * parser-defs.h (copy_name): Change return type.
2391         * m2-exp.y: Update rules.
2392         (yylex): Update.
2393         * go-exp.y (lex_one_token): Update.
2394         Update rules.
2395         (classify_unsafe_function, classify_packaged_name)
2396         (classify_name, yylex): Update.
2397
2398 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2399
2400         * configure.ac: add --enable-source-highlight switch.
2401         * configure: Regenerate.
2402         * top.c (print_gdb_version): plumb --enable-source-highlight
2403         status to "show configuration".
2404
2405 2019-04-19  Tom Tromey  <tromey@adacore.com>
2406
2407         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2408         Check ADA_TYPE_P.
2409         (empty_record, ada_template_to_fixed_record_type_1)
2410         (template_to_static_fixed_type)
2411         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2412         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2413         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2414         macros.
2415
2416 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2417
2418         PR symtab/24423:
2419         * source.c (print_source_lines_base): Advance "iter" when a
2420         control character is seen.
2421
2422 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2423
2424         * inferior.h (struct infcall_suspend_state_deleter):
2425         Catch exception in destructor to avoid crash.
2426
2427 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2428
2429         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2430         close to the add_com "shell".
2431
2432 2019-04-18  Tom Tromey  <tromey@adacore.com>
2433
2434         * process-stratum-target.h (class process_stratum_target)
2435         <stratum>: Add "final".
2436
2437 2019-04-17  Tom Tromey  <tromey@adacore.com>
2438
2439         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2440         against nullptr before use.
2441
2442 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2443
2444         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2445
2446 2019-04-17  Jim Wilson  <jimw@sifive.com>
2447             Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2450         code read might fail, assume 4-byte breakpoint in that case.
2451
2452 2019-04-15  Leszek Swirski  <leszeks@google.com>
2453
2454         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2455         rather than a hand-rolled POD check when checking for forced MEMORY
2456         classification.
2457
2458 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2459
2460         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2461         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2462         function.
2463         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2464         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2465         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2466         declaration.
2467
2468 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2469
2470         * aarch64-linux-nat.c
2471         (aarch64_linux_nat_target::thread_architecture): Add override.
2472         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2473         each VQ.
2474
2475 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2476
2477         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2478
2479 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2482         target types of size 96-bits, add some additional comments, and
2483         check that the builtin type we found was the correct size.
2484
2485 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2486
2487         * utils.c (prompt_for_continue): Don't restore the styling at the
2488         end, as applied_style has the wrong value.  This fixes styling in
2489         long lists of file names that are interrupted by the "Continue?"
2490         prompt.
2491
2492 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2495         * c-lang.c (c_language_defn): Likewise.
2496         (cplus_language_defn): Likewise.
2497         (asm_language_defn): Likewise.
2498         (minimal_language_defn): Likewise.
2499         * d-lang.c (d_language_defn): Likewise.
2500         * f-lang.c (f_language_defn): Likewise.
2501         * go-lang.c (go_language_defn): Likewise.
2502         * language.c (unknown_language_defn): Likewise.
2503         (auto_language_defn): Likewise.
2504         * language.h (struct language_defn): Remove la_magic field.
2505         (LANG_MAGIC): Delete.
2506         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2507         * objc-lang.c (objc_language_defn): Likewise.
2508         * opencl-lang.c (opencl_language_defn): Likewise.
2509         * p-lang.c (pascal_language_defn): Likewise.
2510         * rust-lang.c (rust_language_defn): Likewise.
2511
2512 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         * riscv-tdep.c (riscv_type_align): New function.
2515         (riscv_type_alignment): Delete.
2516         (riscv_arg_location): Use 'type_align'.
2517         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2518
2519 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2520
2521         * gdbtypes.c (type_align): A struct with no non-static fields also
2522         has alignment of 1.
2523
2524 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2525
2526         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2527         component to 0.
2528         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2529         member.
2530         (riscv_struct_info::analyse): New implementation using new
2531         analyse_inner member function.
2532         (riscv_struct_info::field_offset): New member function.
2533         (riscv_struct_info::m_offsets): New member variable.
2534         (riscv_struct_info::analyse_inner): New private member function,
2535         takes the old implementation of riscv_struct_info::analyse but
2536         extended to track field offsets.
2537         (riscv_call_arg_struct): Update the struct folding special cases
2538         to handle cases where empty C++ structs, which are non-zero
2539         length, are found.
2540         (riscv_arg_location): Initialise the length of each location, a
2541         non-zero length now indicates the location is in use.
2542         (riscv_push_dummy_call): Allow for the first location having a
2543         non-zero offset when setting up arguments.
2544         (riscv_return_value): Likewise, but for return values.
2545
2546 2019-04-11  Tom Tromey  <tromey@adacore.com>
2547
2548         * utils.c (internal_vproblem): Make "msg" const.
2549
2550 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2551
2552         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2553         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2554         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2555         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2556
2557 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2558
2559         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2560         function.
2561         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2562         of amd64_collect_native_gregset.
2563         (amd64_linux_nat_target::store_registers): Likewise.
2564
2565 2019-04-10  Tom Tromey  <tom@tromey.com>
2566
2567         * symtab.c (lookup_global_symbol_from_objfile)
2568         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2569         * objfiles.h (class separate_debug_iterator): New.
2570         (class separate_debug_range): New.
2571         (struct objfile) <separate_debug_objfiles>: New method.
2572         (objfile_separate_debug_iterate): Don't declare.
2573         * objfiles.c (separate_debug_iterator::operator++): Rename from
2574         objfile_separate_debug_iterate.
2575         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2576         iterator.
2577         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2578         iterator.
2579
2580 2019-04-10  Tom Tromey  <tom@tromey.com>
2581
2582         * symfile.c (reread_symbols): Remove old comment.
2583         * objfiles.c (free_all_objfiles): Fix a typo.
2584
2585 2019-04-10  Tom Tromey  <tom@tromey.com>
2586
2587         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2588         * minsyms.c (lookup_minimal_symbol): Use foreach.
2589         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2590         (lookup_minimal_symbol_solib_trampoline): Likewise.
2591         * symfile.c (reread_symbols): Use foreach.
2592
2593 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2594             Tom Tromey  <tromey@adacore.com>
2595
2596         PR rust/24414:
2597         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2598         (rust_lex_int_test): Change "value" to be LONGEST.
2599         (rust_lex_tests): Add test for long integer literal.
2600
2601 2019-04-09  Tom Tromey  <tromey@adacore.com>
2602
2603         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2604         to bool.
2605         (extended_remote_target::attach): Update.
2606         (remote_target::remote_notice_new_inferior): Update.
2607         (remote_target::add_current_inferior_and_thread): Update.
2608         * inferior.c (exit_inferior_1): Use "false".
2609         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2610
2611 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2612
2613         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2614         the "start" command.
2615
2616 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2617
2618         * python/py-inferior.c (infpy_thread_from_thread_handle):
2619         Adjust comments to reflect renaming of thread_from_thread_handle
2620         to thread_from_handle.  Adjust keywords.  Fix type error message.
2621         (inferior_object_methods): Add thread_from_handle.  Retain
2622         thread_from_thread_handle, but mark it as deprecated.
2623
2624 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2625
2626         * gdbthread.h (find_thread_by_handle): Revise declaration.
2627         * thread.c (find_thread_by_handle): Likewise.  Adjust
2628         implementation too.
2629         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2630         support for buffer objects as handles.
2631
2632 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2633
2634         * python/py-infthread.c (thpy_thread_handle): New function.
2635         (thread_object_methods): Register thpy_thread_handle.
2636
2637 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2638
2639         * gdbthread.h (thread_to_thread_handle): Declare.
2640         * thread.c (gdbtypes.h): Include.
2641         (thread_to_thread_handle): New function.
2642
2643         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2644         (target_thread_info_to_thread_handle): Declare.
2645         * target.c (target_thread_info_to_thread_handle): New function.
2646         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2647         * target-delegates.c: Regenerate.
2648
2649         * linux-thread-db.c (class thread_db_target): Add method
2650         thread_info_to_thread_handle.
2651         (thread_db_target::thread_info_to_thread_handle): Define.
2652         * remote.c (class remote_target): Add new method
2653         thread_info_to_thread_handle.
2654         (remote_target::thread_info_to_thread_handle): Define.
2655
2656 2019-04-08  Pedro Alves  <palves@redhat.com>
2657
2658         * common/common-exceptions.c (throw_exception): Don't create
2659         named object to throw; throw directly.
2660         (throw_it): Likewise.  Don't initialize gdb_exception::message
2661         here, with new; pass FMT and AP to the ctor instead.
2662         * common/common-exceptions.h: Include <string>.
2663         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2664         const char *, va_list)): New ctor.  Use std::make_shared.
2665         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2666         errors)): Delete.
2667         (gdb_exception_error::gdb_exception_error(enum errors, const char
2668         *, va_list)): New.
2669         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2670         Add assertion.
2671         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2672         errors)): Delete.
2673         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2674         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2675         Add assertion.
2676
2677 2019-04-08  Tom Tromey  <tom@tromey.com>
2678
2679         * valops.c (value_rtti_indirect_type): Replace throw_exception
2680         with throw.
2681         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2682         with throw.
2683         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2684         throw.
2685         * target.c (target_translate_tls_address): Replace throw_exception
2686         with throw.
2687         * stack.c (frame_apply_command_count): Replace throw_exception
2688         with throw.
2689         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2690         throw.
2691         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2692         with throw.
2693         * rs6000-tdep.c (rs6000_frame_cache)
2694         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2695         * remote.c: Replace throw_exception with throw.
2696         * record-full.c (record_full_message, record_full_wait_1)
2697         (record_full_restore): Replace throw_exception with throw.
2698         * record-btrace.c:
2699         (get_thread_current_frame_id, record_btrace_start_replaying)
2700         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2701         (cmd_record_btrace_start): Replace throw_exception with throw.
2702         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2703         throw.
2704         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2705         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2706         * linespec.c:
2707         (find_linespec_symbols): Replace throw_exception with throw.
2708         * infrun.c (displaced_step_prepare, resume): Replace
2709         throw_exception with throw.
2710         * infcmd.c (post_create_inferior): Replace throw_exception with
2711         throw.
2712         * inf-loop.c (inferior_event_handler): Replace throw_exception
2713         with throw.
2714         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2715         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2716         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2717         (get_prev_frame_always, get_frame_pc_if_available)
2718         (get_frame_address_in_block_if_available, get_frame_language):
2719         Replace throw_exception with throw.
2720         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2721         throw_exception with throw.
2722         * eval.c (fetch_subexp_value, evaluate_var_value)
2723         (evaluate_funcall, evaluate_subexp_standard): Replace
2724         throw_exception with throw.
2725         * dwarf2loc.c (call_site_find_chain)
2726         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2727         Replace throw_exception with throw.
2728         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2729         with throw.
2730         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2731         throw.
2732         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2733         * completer.c (complete_line_internal): Replace throw_exception
2734         with throw.
2735         * compile/compile-object-run.c (compile_object_run): Replace
2736         throw_exception with throw.
2737         * cli/cli-script.c (process_next_line): Replace throw_exception
2738         with throw.
2739         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2740         (btrace_enable, btrace_maint_update_pt_packets): Replace
2741         throw_exception with throw.
2742         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2743         throw_exception with throw.
2744         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2745         throw_exception with throw.
2746         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2747         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2748         * aarch64-tdep.c (aarch64_make_prologue_cache)
2749         (aarch64_make_stub_cache): Replace throw_exception with throw.
2750
2751 2019-04-08  Tom Tromey  <tom@tromey.com>
2752
2753         * common/common-exceptions.c (throw_exception): Rename from
2754         throw_exception_cxx.  Remove old copy.  Make argument const.
2755         (throw_it): Create and throw exception objects directly.
2756         * common/common-exceptions.h (throw_exception): Make argument
2757         const.
2758         (struct gdb_exception_error): Add constructor.
2759         (struct gdb_exception_quit): Add constructor.
2760
2761 2019-04-08  Tom Tromey  <tom@tromey.com>
2762
2763         * common/common-exceptions.h (exception_rethrow): Don't declare.
2764         (TRY_SJLJ): Update comment.
2765         (TRY, CATCH, END_CATCH): Remove.
2766         * common/common-exceptions.c (exception_rethrow): Remove.
2767
2768 2019-04-08  Tom Tromey  <tom@tromey.com>
2769
2770         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2771         Remove.
2772         (gdb_exception_error): Rename from
2773         gdb_exception_RETURN_MASK_ERROR.
2774         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2775         (gdb_quit_bad_alloc): Update.
2776         * aarch64-tdep.c: Update.
2777         * ada-lang.c: Update.
2778         * ada-typeprint.c: Update.
2779         * ada-valprint.c: Update.
2780         * amd64-tdep.c: Update.
2781         * arch-utils.c: Update.
2782         * break-catch-throw.c: Update.
2783         * breakpoint.c: Update.
2784         * btrace.c: Update.
2785         * c-varobj.c: Update.
2786         * cli/cli-cmds.c: Update.
2787         * cli/cli-interp.c: Update.
2788         * cli/cli-script.c: Update.
2789         * common/common-exceptions.c: Update.
2790         * common/new-op.c: Update.
2791         * common/selftest.c: Update.
2792         * compile/compile-c-symbols.c: Update.
2793         * compile/compile-cplus-symbols.c: Update.
2794         * compile/compile-object-load.c: Update.
2795         * compile/compile-object-run.c: Update.
2796         * completer.c: Update.
2797         * corelow.c: Update.
2798         * cp-abi.c: Update.
2799         * cp-support.c: Update.
2800         * cp-valprint.c: Update.
2801         * darwin-nat.c: Update.
2802         * disasm-selftests.c: Update.
2803         * dtrace-probe.c: Update.
2804         * dwarf-index-cache.c: Update.
2805         * dwarf-index-write.c: Update.
2806         * dwarf2-frame-tailcall.c: Update.
2807         * dwarf2-frame.c: Update.
2808         * dwarf2loc.c: Update.
2809         * dwarf2read.c: Update.
2810         * eval.c: Update.
2811         * event-loop.c: Update.
2812         * event-top.c: Update.
2813         * exec.c: Update.
2814         * f-valprint.c: Update.
2815         * fbsd-tdep.c: Update.
2816         * frame-unwind.c: Update.
2817         * frame.c: Update.
2818         * gdbtypes.c: Update.
2819         * gnu-v3-abi.c: Update.
2820         * guile/guile-internal.h: Update.
2821         * guile/scm-block.c: Update.
2822         * guile/scm-breakpoint.c: Update.
2823         * guile/scm-cmd.c: Update.
2824         * guile/scm-disasm.c: Update.
2825         * guile/scm-frame.c: Update.
2826         * guile/scm-lazy-string.c: Update.
2827         * guile/scm-math.c: Update.
2828         * guile/scm-param.c: Update.
2829         * guile/scm-ports.c: Update.
2830         * guile/scm-pretty-print.c: Update.
2831         * guile/scm-symbol.c: Update.
2832         * guile/scm-symtab.c: Update.
2833         * guile/scm-type.c: Update.
2834         * guile/scm-value.c: Update.
2835         * i386-linux-tdep.c: Update.
2836         * i386-tdep.c: Update.
2837         * inf-loop.c: Update.
2838         * infcall.c: Update.
2839         * infcmd.c: Update.
2840         * infrun.c: Update.
2841         * jit.c: Update.
2842         * language.c: Update.
2843         * linespec.c: Update.
2844         * linux-fork.c: Update.
2845         * linux-nat.c: Update.
2846         * linux-tdep.c: Update.
2847         * linux-thread-db.c: Update.
2848         * main.c: Update.
2849         * mi/mi-cmd-break.c: Update.
2850         * mi/mi-cmd-stack.c: Update.
2851         * mi/mi-interp.c: Update.
2852         * mi/mi-main.c: Update.
2853         * objc-lang.c: Update.
2854         * p-valprint.c: Update.
2855         * parse.c: Update.
2856         * ppc-linux-tdep.c: Update.
2857         * printcmd.c: Update.
2858         * python/py-arch.c: Update.
2859         * python/py-breakpoint.c: Update.
2860         * python/py-cmd.c: Update.
2861         * python/py-finishbreakpoint.c: Update.
2862         * python/py-frame.c: Update.
2863         * python/py-framefilter.c: Update.
2864         * python/py-gdb-readline.c: Update.
2865         * python/py-inferior.c: Update.
2866         * python/py-infthread.c: Update.
2867         * python/py-lazy-string.c: Update.
2868         * python/py-linetable.c: Update.
2869         * python/py-objfile.c: Update.
2870         * python/py-param.c: Update.
2871         * python/py-prettyprint.c: Update.
2872         * python/py-progspace.c: Update.
2873         * python/py-record-btrace.c: Update.
2874         * python/py-record.c: Update.
2875         * python/py-symbol.c: Update.
2876         * python/py-type.c: Update.
2877         * python/py-unwind.c: Update.
2878         * python/py-utils.c: Update.
2879         * python/py-value.c: Update.
2880         * python/python.c: Update.
2881         * record-btrace.c: Update.
2882         * record-full.c: Update.
2883         * remote-fileio.c: Update.
2884         * remote.c: Update.
2885         * riscv-tdep.c: Update.
2886         * rs6000-aix-tdep.c: Update.
2887         * rs6000-tdep.c: Update.
2888         * rust-exp.y: Update.
2889         * rust-lang.c: Update.
2890         * s390-tdep.c: Update.
2891         * selftest-arch.c: Update.
2892         * solib-dsbt.c: Update.
2893         * solib-frv.c: Update.
2894         * solib-spu.c: Update.
2895         * solib-svr4.c: Update.
2896         * solib.c: Update.
2897         * sparc64-linux-tdep.c: Update.
2898         * stack.c: Update.
2899         * symfile-mem.c: Update.
2900         * symmisc.c: Update.
2901         * target.c: Update.
2902         * thread.c: Update.
2903         * top.c: Update.
2904         * tracefile-tfile.c: Update.
2905         * tui/tui.c: Update.
2906         * typeprint.c: Update.
2907         * unittests/cli-utils-selftests.c: Update.
2908         * unittests/parse-connection-spec-selftests.c: Update.
2909         * valops.c: Update.
2910         * valprint.c: Update.
2911         * value.c: Update.
2912         * varobj.c: Update.
2913         * windows-nat.c: Update.
2914         * x86-linux-nat.c: Update.
2915         * xml-support.c: Update.
2916
2917 2019-04-08  Tom Tromey  <tom@tromey.com>
2918
2919         * xml-support.c: Use C++ exception handling.
2920         * x86-linux-nat.c: Use C++ exception handling.
2921         * windows-nat.c: Use C++ exception handling.
2922         * varobj.c: Use C++ exception handling.
2923         * value.c: Use C++ exception handling.
2924         * valprint.c: Use C++ exception handling.
2925         * valops.c: Use C++ exception handling.
2926         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2927         handling.
2928         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2929         * typeprint.c: Use C++ exception handling.
2930         * tui/tui.c: Use C++ exception handling.
2931         * tracefile-tfile.c: Use C++ exception handling.
2932         * top.c: Use C++ exception handling.
2933         * thread.c: Use C++ exception handling.
2934         * target.c: Use C++ exception handling.
2935         * symmisc.c: Use C++ exception handling.
2936         * symfile-mem.c: Use C++ exception handling.
2937         * stack.c: Use C++ exception handling.
2938         * sparc64-linux-tdep.c: Use C++ exception handling.
2939         * solib.c: Use C++ exception handling.
2940         * solib-svr4.c: Use C++ exception handling.
2941         * solib-spu.c: Use C++ exception handling.
2942         * solib-frv.c: Use C++ exception handling.
2943         * solib-dsbt.c: Use C++ exception handling.
2944         * selftest-arch.c: Use C++ exception handling.
2945         * s390-tdep.c: Use C++ exception handling.
2946         * rust-lang.c: Use C++ exception handling.
2947         * rust-exp.y: Use C++ exception handling.
2948         * rs6000-tdep.c: Use C++ exception handling.
2949         * rs6000-aix-tdep.c: Use C++ exception handling.
2950         * riscv-tdep.c: Use C++ exception handling.
2951         * remote.c: Use C++ exception handling.
2952         * remote-fileio.c: Use C++ exception handling.
2953         * record-full.c: Use C++ exception handling.
2954         * record-btrace.c: Use C++ exception handling.
2955         * python/python.c: Use C++ exception handling.
2956         * python/py-value.c: Use C++ exception handling.
2957         * python/py-utils.c: Use C++ exception handling.
2958         * python/py-unwind.c: Use C++ exception handling.
2959         * python/py-type.c: Use C++ exception handling.
2960         * python/py-symbol.c: Use C++ exception handling.
2961         * python/py-record.c: Use C++ exception handling.
2962         * python/py-record-btrace.c: Use C++ exception handling.
2963         * python/py-progspace.c: Use C++ exception handling.
2964         * python/py-prettyprint.c: Use C++ exception handling.
2965         * python/py-param.c: Use C++ exception handling.
2966         * python/py-objfile.c: Use C++ exception handling.
2967         * python/py-linetable.c: Use C++ exception handling.
2968         * python/py-lazy-string.c: Use C++ exception handling.
2969         * python/py-infthread.c: Use C++ exception handling.
2970         * python/py-inferior.c: Use C++ exception handling.
2971         * python/py-gdb-readline.c: Use C++ exception handling.
2972         * python/py-framefilter.c: Use C++ exception handling.
2973         * python/py-frame.c: Use C++ exception handling.
2974         * python/py-finishbreakpoint.c: Use C++ exception handling.
2975         * python/py-cmd.c: Use C++ exception handling.
2976         * python/py-breakpoint.c: Use C++ exception handling.
2977         * python/py-arch.c: Use C++ exception handling.
2978         * printcmd.c: Use C++ exception handling.
2979         * ppc-linux-tdep.c: Use C++ exception handling.
2980         * parse.c: Use C++ exception handling.
2981         * p-valprint.c: Use C++ exception handling.
2982         * objc-lang.c: Use C++ exception handling.
2983         * mi/mi-main.c: Use C++ exception handling.
2984         * mi/mi-interp.c: Use C++ exception handling.
2985         * mi/mi-cmd-stack.c: Use C++ exception handling.
2986         * mi/mi-cmd-break.c: Use C++ exception handling.
2987         * main.c: Use C++ exception handling.
2988         * linux-thread-db.c: Use C++ exception handling.
2989         * linux-tdep.c: Use C++ exception handling.
2990         * linux-nat.c: Use C++ exception handling.
2991         * linux-fork.c: Use C++ exception handling.
2992         * linespec.c: Use C++ exception handling.
2993         * language.c: Use C++ exception handling.
2994         * jit.c: Use C++ exception handling.
2995         * infrun.c: Use C++ exception handling.
2996         * infcmd.c: Use C++ exception handling.
2997         * infcall.c: Use C++ exception handling.
2998         * inf-loop.c: Use C++ exception handling.
2999         * i386-tdep.c: Use C++ exception handling.
3000         * i386-linux-tdep.c: Use C++ exception handling.
3001         * guile/scm-value.c: Use C++ exception handling.
3002         * guile/scm-type.c: Use C++ exception handling.
3003         * guile/scm-symtab.c: Use C++ exception handling.
3004         * guile/scm-symbol.c: Use C++ exception handling.
3005         * guile/scm-pretty-print.c: Use C++ exception handling.
3006         * guile/scm-ports.c: Use C++ exception handling.
3007         * guile/scm-param.c: Use C++ exception handling.
3008         * guile/scm-math.c: Use C++ exception handling.
3009         * guile/scm-lazy-string.c: Use C++ exception handling.
3010         * guile/scm-frame.c: Use C++ exception handling.
3011         * guile/scm-disasm.c: Use C++ exception handling.
3012         * guile/scm-cmd.c: Use C++ exception handling.
3013         * guile/scm-breakpoint.c: Use C++ exception handling.
3014         * guile/scm-block.c: Use C++ exception handling.
3015         * guile/guile-internal.h: Use C++ exception handling.
3016         * gnu-v3-abi.c: Use C++ exception handling.
3017         * gdbtypes.c: Use C++ exception handling.
3018         * frame.c: Use C++ exception handling.
3019         * frame-unwind.c: Use C++ exception handling.
3020         * fbsd-tdep.c: Use C++ exception handling.
3021         * f-valprint.c: Use C++ exception handling.
3022         * exec.c: Use C++ exception handling.
3023         * event-top.c: Use C++ exception handling.
3024         * event-loop.c: Use C++ exception handling.
3025         * eval.c: Use C++ exception handling.
3026         * dwarf2read.c: Use C++ exception handling.
3027         * dwarf2loc.c: Use C++ exception handling.
3028         * dwarf2-frame.c: Use C++ exception handling.
3029         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3030         * dwarf-index-write.c: Use C++ exception handling.
3031         * dwarf-index-cache.c: Use C++ exception handling.
3032         * dtrace-probe.c: Use C++ exception handling.
3033         * disasm-selftests.c: Use C++ exception handling.
3034         * darwin-nat.c: Use C++ exception handling.
3035         * cp-valprint.c: Use C++ exception handling.
3036         * cp-support.c: Use C++ exception handling.
3037         * cp-abi.c: Use C++ exception handling.
3038         * corelow.c: Use C++ exception handling.
3039         * completer.c: Use C++ exception handling.
3040         * compile/compile-object-run.c: Use C++ exception handling.
3041         * compile/compile-object-load.c: Use C++ exception handling.
3042         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3043         * compile/compile-c-symbols.c: Use C++ exception handling.
3044         * common/selftest.c: Use C++ exception handling.
3045         * common/new-op.c: Use C++ exception handling.
3046         * cli/cli-script.c: Use C++ exception handling.
3047         * cli/cli-interp.c: Use C++ exception handling.
3048         * cli/cli-cmds.c: Use C++ exception handling.
3049         * c-varobj.c: Use C++ exception handling.
3050         * btrace.c: Use C++ exception handling.
3051         * breakpoint.c: Use C++ exception handling.
3052         * break-catch-throw.c: Use C++ exception handling.
3053         * arch-utils.c: Use C++ exception handling.
3054         * amd64-tdep.c: Use C++ exception handling.
3055         * ada-valprint.c: Use C++ exception handling.
3056         * ada-typeprint.c: Use C++ exception handling.
3057         * ada-lang.c: Use C++ exception handling.
3058         * aarch64-tdep.c: Use C++ exception handling.
3059
3060 2019-04-08  Tom Tromey  <tom@tromey.com>
3061
3062         * xml-support.c (gdb_xml_parser::parse): Update.
3063         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3064         * value.c (show_convenience): Update.
3065         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3066         (test_parse_flags_qcs): Update.
3067         * thread.c (thr_try_catch_cmd): Update.
3068         * target.c (target_translate_tls_address): Update.
3069         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3070         (info_frame_command_core, frame_apply_command_count): Update.
3071         * rust-exp.y (rust_lex_exception_test): Update.
3072         * riscv-tdep.c (riscv_print_one_register_info): Update.
3073         * remote.c (remote_target::enable_btrace): Update.
3074         * record-btrace.c (record_btrace_enable_warn): Update.
3075         * python/py-utils.c (gdbpy_convert_exception): Update.
3076         * printcmd.c (do_one_display, print_variable_and_value): Update.
3077         * mi/mi-main.c (mi_print_exception): Update.
3078         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3079         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3080         * linux-nat.c (linux_nat_target::attach): Update.
3081         * linux-fork.c (class scoped_switch_fork_info): Update.
3082         * infrun.c (displaced_step_prepare): Update.
3083         * infcall.c (call_function_by_hand_dummy): Update.
3084         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3085         * gnu-v3-abi.c (print_one_vtable): Update.
3086         * frame.c (get_prev_frame_always): Update.
3087         * f-valprint.c (info_common_command_for_block): Update.
3088         * exec.c (try_open_exec_file): Update.
3089         * exceptions.c (print_exception, exception_print)
3090         (exception_fprintf, exception_print_same): Update.
3091         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3092         * dwarf-index-cache.c (index_cache::store)
3093         (index_cache::lookup_gdb_index): Update.
3094         * darwin-nat.c (maybe_cache_shell): Update.
3095         * cp-valprint.c (cp_print_value_fields): Update.
3096         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3097         (gcc_cplus_symbol_address): Update.
3098         * compile/compile-c-symbols.c (gcc_convert_symbol)
3099         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3100         * common/selftest.c: Update.
3101         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3102         a std::string.
3103         (exception_try_scope_entry, exception_try_scope_exit): Don't
3104         declare.
3105         (struct exception_try_scope): Remove.
3106         (TRY): Don't use exception_try_scope.
3107         (struct gdb_exception): Add constructor, operator=.
3108         <what>: New method.
3109         (struct gdb_exception_RETURN_MASK_ALL)
3110         (struct gdb_exception_RETURN_MASK_ERROR)
3111         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3112         (struct gdb_quit_bad_alloc): Update.
3113         * common/common-exceptions.c (exception_none): Change
3114         initializer.
3115         (struct catcher) <state, exception>: Initialize inline.
3116         <prev>: Remove member.
3117         (current_catcher): Remove.
3118         (catchers): New global.
3119         (exceptions_state_mc_init): Simplify.
3120         (catcher_pop): Remove.
3121         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3122         (try_scope_depth, exception_try_scope_entry)
3123         (exception_try_scope_exit): Remove.
3124         (throw_exception_sjlj): Update.
3125         (exception_messages, exception_messages_size): Remove.
3126         (throw_it): Simplify.
3127         (gdb_exception_sliced_copy): Remove.
3128         (throw_exception_cxx): Update.
3129         * cli/cli-script.c (script_from_file): Update.
3130         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3131         Update.
3132         * ada-valprint.c (ada_val_print): Update.
3133         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3134         (create_excep_cond_exprs): Update.
3135
3136 2019-04-08  Tom Tromey  <tom@tromey.com>
3137
3138         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3139         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3140         (TRY, CATCH, END_CATCH): Remove some definitions.
3141         * common/common-exceptions.c: Don't use GDB_XCPT.
3142         (catcher_list_size): Remove.
3143         (throw_exception, throw_it): Simplify.
3144
3145 2019-04-05  Tom Tromey  <tom@tromey.com>
3146
3147         Revert the header-sorting patch.
3148         * ft32-tdep.c: Revert.
3149         * frv-tdep.c: Revert.
3150         * frv-linux-tdep.c: Revert.
3151         * frame.c: Revert.
3152         * frame-unwind.c: Revert.
3153         * frame-base.c: Revert.
3154         * fork-child.c: Revert.
3155         * findvar.c: Revert.
3156         * findcmd.c: Revert.
3157         * filesystem.c: Revert.
3158         * filename-seen-cache.h: Revert.
3159         * filename-seen-cache.c: Revert.
3160         * fbsd-tdep.c: Revert.
3161         * fbsd-nat.h: Revert.
3162         * fbsd-nat.c: Revert.
3163         * f-valprint.c: Revert.
3164         * f-typeprint.c: Revert.
3165         * f-lang.c: Revert.
3166         * extension.h: Revert.
3167         * extension.c: Revert.
3168         * extension-priv.h: Revert.
3169         * expprint.c: Revert.
3170         * exec.h: Revert.
3171         * exec.c: Revert.
3172         * exceptions.c: Revert.
3173         * event-top.c: Revert.
3174         * event-loop.c: Revert.
3175         * eval.c: Revert.
3176         * elfread.c: Revert.
3177         * dwarf2read.h: Revert.
3178         * dwarf2read.c: Revert.
3179         * dwarf2loc.c: Revert.
3180         * dwarf2expr.h: Revert.
3181         * dwarf2expr.c: Revert.
3182         * dwarf2-frame.c: Revert.
3183         * dwarf2-frame-tailcall.c: Revert.
3184         * dwarf-index-write.h: Revert.
3185         * dwarf-index-write.c: Revert.
3186         * dwarf-index-common.c: Revert.
3187         * dwarf-index-cache.h: Revert.
3188         * dwarf-index-cache.c: Revert.
3189         * dummy-frame.c: Revert.
3190         * dtrace-probe.c: Revert.
3191         * disasm.h: Revert.
3192         * disasm.c: Revert.
3193         * disasm-selftests.c: Revert.
3194         * dictionary.c: Revert.
3195         * dicos-tdep.c: Revert.
3196         * demangle.c: Revert.
3197         * dcache.h: Revert.
3198         * dcache.c: Revert.
3199         * darwin-nat.h: Revert.
3200         * darwin-nat.c: Revert.
3201         * darwin-nat-info.c: Revert.
3202         * d-valprint.c: Revert.
3203         * d-namespace.c: Revert.
3204         * d-lang.c: Revert.
3205         * ctf.c: Revert.
3206         * csky-tdep.c: Revert.
3207         * csky-linux-tdep.c: Revert.
3208         * cris-tdep.c: Revert.
3209         * cris-linux-tdep.c: Revert.
3210         * cp-valprint.c: Revert.
3211         * cp-support.c: Revert.
3212         * cp-namespace.c: Revert.
3213         * cp-abi.c: Revert.
3214         * corelow.c: Revert.
3215         * corefile.c: Revert.
3216         * continuations.c: Revert.
3217         * completer.h: Revert.
3218         * completer.c: Revert.
3219         * complaints.c: Revert.
3220         * coffread.c: Revert.
3221         * coff-pe-read.c: Revert.
3222         * cli-out.h: Revert.
3223         * cli-out.c: Revert.
3224         * charset.c: Revert.
3225         * c-varobj.c: Revert.
3226         * c-valprint.c: Revert.
3227         * c-typeprint.c: Revert.
3228         * c-lang.c: Revert.
3229         * buildsym.c: Revert.
3230         * buildsym-legacy.c: Revert.
3231         * build-id.h: Revert.
3232         * build-id.c: Revert.
3233         * btrace.c: Revert.
3234         * bsd-uthread.c: Revert.
3235         * breakpoint.h: Revert.
3236         * breakpoint.c: Revert.
3237         * break-catch-throw.c: Revert.
3238         * break-catch-syscall.c: Revert.
3239         * break-catch-sig.c: Revert.
3240         * blockframe.c: Revert.
3241         * block.c: Revert.
3242         * bfin-tdep.c: Revert.
3243         * bfin-linux-tdep.c: Revert.
3244         * bfd-target.c: Revert.
3245         * bcache.c: Revert.
3246         * ax-general.c: Revert.
3247         * ax-gdb.h: Revert.
3248         * ax-gdb.c: Revert.
3249         * avr-tdep.c: Revert.
3250         * auxv.c: Revert.
3251         * auto-load.c: Revert.
3252         * arm-wince-tdep.c: Revert.
3253         * arm-tdep.c: Revert.
3254         * arm-symbian-tdep.c: Revert.
3255         * arm-pikeos-tdep.c: Revert.
3256         * arm-obsd-tdep.c: Revert.
3257         * arm-nbsd-tdep.c: Revert.
3258         * arm-nbsd-nat.c: Revert.
3259         * arm-linux-tdep.c: Revert.
3260         * arm-linux-nat.c: Revert.
3261         * arm-fbsd-tdep.c: Revert.
3262         * arm-fbsd-nat.c: Revert.
3263         * arm-bsd-tdep.c: Revert.
3264         * arch-utils.c: Revert.
3265         * arc-tdep.c: Revert.
3266         * arc-newlib-tdep.c: Revert.
3267         * annotate.h: Revert.
3268         * annotate.c: Revert.
3269         * amd64-windows-tdep.c: Revert.
3270         * amd64-windows-nat.c: Revert.
3271         * amd64-tdep.c: Revert.
3272         * amd64-sol2-tdep.c: Revert.
3273         * amd64-obsd-tdep.c: Revert.
3274         * amd64-obsd-nat.c: Revert.
3275         * amd64-nbsd-tdep.c: Revert.
3276         * amd64-nbsd-nat.c: Revert.
3277         * amd64-nat.c: Revert.
3278         * amd64-linux-tdep.c: Revert.
3279         * amd64-linux-nat.c: Revert.
3280         * amd64-fbsd-tdep.c: Revert.
3281         * amd64-fbsd-nat.c: Revert.
3282         * amd64-dicos-tdep.c: Revert.
3283         * amd64-darwin-tdep.c: Revert.
3284         * amd64-bsd-nat.c: Revert.
3285         * alpha-tdep.c: Revert.
3286         * alpha-obsd-tdep.c: Revert.
3287         * alpha-nbsd-tdep.c: Revert.
3288         * alpha-mdebug-tdep.c: Revert.
3289         * alpha-linux-tdep.c: Revert.
3290         * alpha-linux-nat.c: Revert.
3291         * alpha-bsd-tdep.c: Revert.
3292         * alpha-bsd-nat.c: Revert.
3293         * aix-thread.c: Revert.
3294         * agent.c: Revert.
3295         * addrmap.c: Revert.
3296         * ada-varobj.c: Revert.
3297         * ada-valprint.c: Revert.
3298         * ada-typeprint.c: Revert.
3299         * ada-tasks.c: Revert.
3300         * ada-lang.c: Revert.
3301         * aarch64-tdep.c: Revert.
3302         * aarch64-ravenscar-thread.c: Revert.
3303         * aarch64-newlib-tdep.c: Revert.
3304         * aarch64-linux-tdep.c: Revert.
3305         * aarch64-linux-nat.c: Revert.
3306         * aarch64-fbsd-tdep.c: Revert.
3307         * aarch64-fbsd-nat.c: Revert.
3308         * aarch32-linux-nat.c: Revert.
3309
3310 2019-04-05  Tom Tromey  <tom@tromey.com>
3311
3312         * ft32-tdep.c: Sort headers.
3313         * frv-tdep.c: Sort headers.
3314         * frv-linux-tdep.c: Sort headers.
3315         * frame.c: Sort headers.
3316         * frame-unwind.c: Sort headers.
3317         * frame-base.c: Sort headers.
3318         * fork-child.c: Sort headers.
3319         * findvar.c: Sort headers.
3320         * findcmd.c: Sort headers.
3321         * filesystem.c: Sort headers.
3322         * filename-seen-cache.h: Sort headers.
3323         * filename-seen-cache.c: Sort headers.
3324         * fbsd-tdep.c: Sort headers.
3325         * fbsd-nat.h: Sort headers.
3326         * fbsd-nat.c: Sort headers.
3327         * f-valprint.c: Sort headers.
3328         * f-typeprint.c: Sort headers.
3329         * f-lang.c: Sort headers.
3330         * extension.h: Sort headers.
3331         * extension.c: Sort headers.
3332         * extension-priv.h: Sort headers.
3333         * expprint.c: Sort headers.
3334         * exec.h: Sort headers.
3335         * exec.c: Sort headers.
3336         * exceptions.c: Sort headers.
3337         * event-top.c: Sort headers.
3338         * event-loop.c: Sort headers.
3339         * eval.c: Sort headers.
3340         * elfread.c: Sort headers.
3341         * dwarf2read.h: Sort headers.
3342         * dwarf2read.c: Sort headers.
3343         * dwarf2loc.c: Sort headers.
3344         * dwarf2expr.h: Sort headers.
3345         * dwarf2expr.c: Sort headers.
3346         * dwarf2-frame.c: Sort headers.
3347         * dwarf2-frame-tailcall.c: Sort headers.
3348         * dwarf-index-write.h: Sort headers.
3349         * dwarf-index-write.c: Sort headers.
3350         * dwarf-index-common.c: Sort headers.
3351         * dwarf-index-cache.h: Sort headers.
3352         * dwarf-index-cache.c: Sort headers.
3353         * dummy-frame.c: Sort headers.
3354         * dtrace-probe.c: Sort headers.
3355         * disasm.h: Sort headers.
3356         * disasm.c: Sort headers.
3357         * disasm-selftests.c: Sort headers.
3358         * dictionary.c: Sort headers.
3359         * dicos-tdep.c: Sort headers.
3360         * demangle.c: Sort headers.
3361         * dcache.h: Sort headers.
3362         * dcache.c: Sort headers.
3363         * darwin-nat.h: Sort headers.
3364         * darwin-nat.c: Sort headers.
3365         * darwin-nat-info.c: Sort headers.
3366         * d-valprint.c: Sort headers.
3367         * d-namespace.c: Sort headers.
3368         * d-lang.c: Sort headers.
3369         * ctf.c: Sort headers.
3370         * csky-tdep.c: Sort headers.
3371         * csky-linux-tdep.c: Sort headers.
3372         * cris-tdep.c: Sort headers.
3373         * cris-linux-tdep.c: Sort headers.
3374         * cp-valprint.c: Sort headers.
3375         * cp-support.c: Sort headers.
3376         * cp-namespace.c: Sort headers.
3377         * cp-abi.c: Sort headers.
3378         * corelow.c: Sort headers.
3379         * corefile.c: Sort headers.
3380         * continuations.c: Sort headers.
3381         * completer.h: Sort headers.
3382         * completer.c: Sort headers.
3383         * complaints.c: Sort headers.
3384         * coffread.c: Sort headers.
3385         * coff-pe-read.c: Sort headers.
3386         * cli-out.h: Sort headers.
3387         * cli-out.c: Sort headers.
3388         * charset.c: Sort headers.
3389         * c-varobj.c: Sort headers.
3390         * c-valprint.c: Sort headers.
3391         * c-typeprint.c: Sort headers.
3392         * c-lang.c: Sort headers.
3393         * buildsym.c: Sort headers.
3394         * buildsym-legacy.c: Sort headers.
3395         * build-id.h: Sort headers.
3396         * build-id.c: Sort headers.
3397         * btrace.c: Sort headers.
3398         * bsd-uthread.c: Sort headers.
3399         * breakpoint.h: Sort headers.
3400         * breakpoint.c: Sort headers.
3401         * break-catch-throw.c: Sort headers.
3402         * break-catch-syscall.c: Sort headers.
3403         * break-catch-sig.c: Sort headers.
3404         * blockframe.c: Sort headers.
3405         * block.c: Sort headers.
3406         * bfin-tdep.c: Sort headers.
3407         * bfin-linux-tdep.c: Sort headers.
3408         * bfd-target.c: Sort headers.
3409         * bcache.c: Sort headers.
3410         * ax-general.c: Sort headers.
3411         * ax-gdb.h: Sort headers.
3412         * ax-gdb.c: Sort headers.
3413         * avr-tdep.c: Sort headers.
3414         * auxv.c: Sort headers.
3415         * auto-load.c: Sort headers.
3416         * arm-wince-tdep.c: Sort headers.
3417         * arm-tdep.c: Sort headers.
3418         * arm-symbian-tdep.c: Sort headers.
3419         * arm-pikeos-tdep.c: Sort headers.
3420         * arm-obsd-tdep.c: Sort headers.
3421         * arm-nbsd-tdep.c: Sort headers.
3422         * arm-nbsd-nat.c: Sort headers.
3423         * arm-linux-tdep.c: Sort headers.
3424         * arm-linux-nat.c: Sort headers.
3425         * arm-fbsd-tdep.c: Sort headers.
3426         * arm-fbsd-nat.c: Sort headers.
3427         * arm-bsd-tdep.c: Sort headers.
3428         * arch-utils.c: Sort headers.
3429         * arc-tdep.c: Sort headers.
3430         * arc-newlib-tdep.c: Sort headers.
3431         * annotate.h: Sort headers.
3432         * annotate.c: Sort headers.
3433         * amd64-windows-tdep.c: Sort headers.
3434         * amd64-windows-nat.c: Sort headers.
3435         * amd64-tdep.c: Sort headers.
3436         * amd64-sol2-tdep.c: Sort headers.
3437         * amd64-obsd-tdep.c: Sort headers.
3438         * amd64-obsd-nat.c: Sort headers.
3439         * amd64-nbsd-tdep.c: Sort headers.
3440         * amd64-nbsd-nat.c: Sort headers.
3441         * amd64-nat.c: Sort headers.
3442         * amd64-linux-tdep.c: Sort headers.
3443         * amd64-linux-nat.c: Sort headers.
3444         * amd64-fbsd-tdep.c: Sort headers.
3445         * amd64-fbsd-nat.c: Sort headers.
3446         * amd64-dicos-tdep.c: Sort headers.
3447         * amd64-darwin-tdep.c: Sort headers.
3448         * amd64-bsd-nat.c: Sort headers.
3449         * alpha-tdep.c: Sort headers.
3450         * alpha-obsd-tdep.c: Sort headers.
3451         * alpha-nbsd-tdep.c: Sort headers.
3452         * alpha-mdebug-tdep.c: Sort headers.
3453         * alpha-linux-tdep.c: Sort headers.
3454         * alpha-linux-nat.c: Sort headers.
3455         * alpha-bsd-tdep.c: Sort headers.
3456         * alpha-bsd-nat.c: Sort headers.
3457         * aix-thread.c: Sort headers.
3458         * agent.c: Sort headers.
3459         * addrmap.c: Sort headers.
3460         * ada-varobj.c: Sort headers.
3461         * ada-valprint.c: Sort headers.
3462         * ada-typeprint.c: Sort headers.
3463         * ada-tasks.c: Sort headers.
3464         * ada-lang.c: Sort headers.
3465         * aarch64-tdep.c: Sort headers.
3466         * aarch64-ravenscar-thread.c: Sort headers.
3467         * aarch64-newlib-tdep.c: Sort headers.
3468         * aarch64-linux-tdep.c: Sort headers.
3469         * aarch64-linux-nat.c: Sort headers.
3470         * aarch64-fbsd-tdep.c: Sort headers.
3471         * aarch64-fbsd-nat.c: Sort headers.
3472         * aarch32-linux-nat.c: Sort headers.
3473
3474 2019-04-04  Tom Tromey  <tom@tromey.com>
3475
3476         * varobj.c (varobj_create): Update.
3477         * rust-exp.y (struct rust_parser) <update_innermost_block,
3478         lookup_symbol>: New methods.
3479         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3480         Rename.
3481         (rust_parser::rust_lookup_type)
3482         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3483         * printcmd.c (display_command, do_one_display): Update.
3484         * parser-defs.h (struct parser_state) <parser_state>: Add
3485         "tracker" parameter.
3486         (block_tracker): New member.
3487         (class innermost_block_tracker) <innermost_block_tracker>: Add
3488         "types" parameter.
3489         <reset>: Remove method.
3490         (innermost_block): Don't declare.
3491         (null_post_parser): Update.
3492         * parse.c (innermost_block): Remove global.
3493         (write_dollar_variable): Update.
3494         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3495         Remove "tracker_types" parameter.
3496         (parse_expression): Add "tracker" parameter.
3497         (parse_expression_for_completion): Update.
3498         (null_post_parser): Add "tracker" parameter.
3499         * p-exp.y: Update rules.
3500         * m2-exp.y: Update rules.
3501         * language.h (struct language_defn) <la_post_parser>: Add
3502         "tracker" parameter.
3503         * go-exp.y: Update rules.
3504         * f-exp.y: Update rules.
3505         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3506         parameter.
3507         * d-exp.y: Update rules.
3508         * c-exp.y: Update rules.
3509         * breakpoint.c (set_breakpoint_condition): Create an
3510         innermost_block_tracker.
3511         (watch_command_1): Likewise.
3512         * ada-lang.c (resolve): Add "tracker" parameter.
3513         (resolve_subexp): Likewise.
3514         * ada-exp.y (write_var_from_sym): Update.
3515
3516 2019-04-04  Tom Tromey  <tom@tromey.com>
3517
3518         * type-stack.h: New file.
3519         * type-stack.c: New file.
3520         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3521         type-stack.h.
3522         (insert_into_type_stack, insert_type, push_type, push_type_int)
3523         (insert_type_address_space, pop_type, pop_type_int)
3524         (pop_typelist, pop_type_stack, append_type_stack)
3525         (push_type_stack, get_type_stack, push_typelist)
3526         (follow_type_instance_flags, follow_types): Don't declare.
3527         * parse.c (type_stack): Remove global.
3528         (parse_exp_in_context): Update.
3529         (insert_into_type_stack, insert_type, push_type, push_type_int)
3530         (insert_type_address_space, pop_type, pop_type_int)
3531         (pop_typelist, pop_type_stack, append_type_stack)
3532         (push_type_stack, get_type_stack, push_typelist)
3533         (follow_type_instance_flags, follow_types): Remove (moved to
3534         type-stack.c).
3535         * f-exp.y (type_stack): New global.
3536         Update rules.
3537         (push_kind_type, f_parse): Update.
3538         * d-exp.y (type_stack): New global.
3539         Update rules.
3540         (d_parse): Update.
3541         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3542         Update rules.
3543         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3544         (HFILES_NO_SRCDIR): Add type-stack.h.
3545
3546 2019-04-04  Tom Tromey  <tom@tromey.com>
3547
3548         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3549         (rust_parser::convert_ast_to_expression, rust_parse)
3550         (rust_lex_test_completion, rust_lex_tests): Update.
3551         * parser-defs.h (struct expr_completion_state): New.
3552         (struct parser_state) <parser_state>: Add completion parameter.
3553         <mark_struct_expression, mark_completion_tag>: New methods.
3554         <parse_completion, m_completion_state>: New members.
3555         (prefixify_expression, null_post_parser): Update.
3556         (mark_struct_expression, mark_completion_tag): Don't declare.
3557         * parse.c (parse_completion, expout_last_struct)
3558         (expout_tag_completion_type, expout_completion_name): Remove
3559         globals.
3560         (parser_state::mark_struct_expression)
3561         (parser_state::mark_completion_tag): Now methods.
3562         (prefixify_expression): Add last_struct parameter.
3563         (prefixify_subexp): Likewise.
3564         (parse_exp_1): Update.
3565         (parse_exp_in_context): Add cstate parameter.  Update.
3566         (parse_expression_for_completion): Create an
3567         expr_completion_state.
3568         (null_post_parser): Add "completion" parameter.
3569         * p-exp.y: Update rules.
3570         (yylex): Update.
3571         * language.h (struct language_defn) <la_post_parser>: Add
3572         "completing" parameter.
3573         * go-exp.y: Update rules.
3574         (lex_one_token): Update.
3575         * expression.h (parse_completion): Don't declare.
3576         * d-exp.y: Update rules.
3577         (lex_one_token): Update rules.
3578         * c-exp.y: Update rules.
3579         (lex_one_token): Update.
3580         * ada-lang.c (resolve): Add "parse_completion" parameter.
3581         (resolve_subexp): Likewise.
3582         (ada_resolve_function): Likewise.
3583
3584 2019-04-04  Tom Tromey  <tom@tromey.com>
3585
3586         * parser-defs.h (struct parser_state) <start_arglist,
3587         end_arglist>: New methods.
3588         <arglist_len, m_funcall_chain>: New members.
3589         (arglist_len, start_arglist, end_arglist): Don't declare.
3590         * parse.c (arglist_len, funcall_chain): Remove global.
3591         (start_arglist, end_arglist): Remove functions.
3592         (parse_exp_in_context): Update.
3593         * p-exp.y: Update rules.
3594         * m2-exp.y: Update rules.
3595         * go-exp.y: Update rules.
3596         * f-exp.y: Update rules.
3597         * d-exp.y: Update rules.
3598         * c-exp.y: Update rules.
3599
3600 2019-04-04  Tom Tromey  <tom@tromey.com>
3601
3602         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3603         lex_operator, push_back>: New methods.
3604         Update all rules.
3605         (rust_parser::lex_hex, lex_escape): Rename and update.
3606         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3607         (rust_parser::lex_operator): Rename and update.
3608         (rust_parser::lex_number, rustyylex, rustyyerror)
3609         (rust_lex_test_init, rust_lex_test_sequence)
3610         (rust_lex_test_push_back, rust_lex_tests): Update.
3611         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3612         parameter.
3613         <lexptr, prev_lexptr>: New members.
3614         (lexptr, prev_lexptr): Don't declare.
3615         * parse.c (lexptr, prev_lexptr): Remove globals.
3616         (parse_exp_in_context): Update.
3617         * p-exp.y (yylex, yyerror): Update.
3618         * m2-exp.y (parse_number, yylex, yyerror): Update.
3619         * go-exp.y (lex_one_token, yyerror): Update.
3620         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3621         * d-exp.y (lex_one_token, yyerror): Update.
3622         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3623         (lex_one_token, yyerror): Update.
3624         * ada-lex.l (YY_INPUT): Update.
3625         (rewind_to_char): Update.
3626         * ada-exp.y (yyerror): Update.
3627
3628 2019-04-04  Tom Tromey  <tom@tromey.com>
3629
3630         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3631         * parser-defs.h (struct parser_state) <parser_state>: Add new
3632         parameter.
3633         <comma_terminates>: New member.
3634         (comma_terminates): Don't declare global.
3635         * parse.c (comma_terminates): Remove global.
3636         (parse_exp_in_context): Update.
3637         * p-exp.y (yylex): Update.
3638         * m2-exp.y (yylex): Update.
3639         * go-exp.y (lex_one_token): Update.
3640         * f-exp.y (yylex): Update.
3641         * d-exp.y (lex_one_token): Update.
3642         * c-exp.y (lex_one_token): Update.
3643         * ada-lex.l: Update.
3644
3645 2019-04-04  Tom Tromey  <tom@tromey.com>
3646
3647         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3648         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3649         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3650         * parser-defs.h (paren_depth): Don't declare.
3651         * parse.c (paren_depth): Remove global.
3652         (parse_exp_in_context): Update.
3653         * p-exp.y (paren_depth): New global.
3654         (pascal_parse): Initialize it.
3655         * m2-exp.y (paren_depth): New global.
3656         (m2_parse): Initialize it.
3657         * go-exp.y (paren_depth): New global.
3658         (go_parse): Initialize it.
3659         * f-exp.y (paren_depth): New global.
3660         (f_parse): Initialize it.
3661         * d-exp.y (paren_depth): New global.
3662         (d_parse): Initialize it.
3663         * c-exp.y (paren_depth): New global.
3664         (c_parse): Initialize it.
3665         * ada-lex.l (paren_depth): New global.
3666         (lexer_init): Initialize it.
3667
3668 2019-04-04  Tom Tromey  <tom@tromey.com>
3669
3670         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3671         (rust_parser::convert_ast_to_type)
3672         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3673         * parser-defs.h (struct parser_state) <parser_state>: Add
3674         parameters.  Initialize new members.
3675         <expression_context_block, expression_context_pc>: New members.
3676         * parse.c (expression_context_block, expression_context_pc):
3677         Remove globals.
3678         (parse_exp_in_context): Update.
3679         * p-exp.y: Update all rules.
3680         (yylex): Update.
3681         * m2-exp.y: Update all rules.
3682         (yylex): Update.
3683         * go-exp.y (yylex): Update.
3684         * f-exp.y (yylex): Update.
3685         * d-exp.y: Update all rules.
3686         (yylex): Update.
3687         * c-exp.y: Update all rules.
3688         (lex_one_token, classify_name, yylex, c_parse): Update.
3689         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3690
3691 2019-04-04  Tom Tromey  <tom@tromey.com>
3692
3693         * gdbarch.h, gdbarch.c: Rebuild.
3694         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3695         * stap-probe.h:
3696         (struct stap_parse_info): Replace "parser_state" with
3697         "expr_builder".
3698         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3699         (parser_state): New class.
3700         * parse.c (expr_builder): Rename.
3701         (expr_builder::release): Rename.
3702         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3703         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3704         (write_exp_elt_longcst, write_exp_elt_floatcst)
3705         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3706         (write_exp_string_vector, write_exp_bitstring)
3707         (write_exp_msymbol, mark_struct_expression)
3708         (write_dollar_variable)
3709         (insert_type_address_space, increase_expout_size): Replace
3710         "parser_state" with "expr_builder".
3711         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3712         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3713         "parser_state" with "expr_builder".
3714
3715 2019-04-04  Tom Tromey  <tom@tromey.com>
3716
3717         * rust-exp.y: Replace "parse_language" with method call.
3718         * p-exp.y:
3719         (yylex): Replace "parse_language" with method call.
3720         * m2-exp.y:
3721         (yylex): Replace "parse_language" with method call.
3722         * go-exp.y (classify_name): Replace "parse_language" with method
3723         call.
3724         * f-exp.y (yylex): Replace "parse_language" with method call.
3725         * d-exp.y (lex_one_token): Replace "parse_language" with method
3726         call.
3727         * c-exp.y:
3728         (lex_one_token, classify_name, yylex): Replace "parse_language"
3729         with method call.
3730         * ada-exp.y (find_primitive_type, type_char)
3731         (type_system_address): Replace "parse_language" with method call.
3732
3733 2019-04-04  Tom Tromey  <tom@tromey.com>
3734
3735         * rust-exp.y: Replace "parse_gdbarch" with method call.
3736         * parse.c (write_dollar_variable, insert_type_address_space):
3737         Replace "parse_gdbarch" with method call.
3738         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3739         call.
3740         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3741         call.
3742         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3743         "parse_gdbarch" with method call.
3744         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3745         with method call.
3746         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3747         "parse_gdbarch" with method call.
3748         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3749         "parse_gdbarch" with method call.
3750         * c-exp.y (parse_type, parse_number, classify_name): Replace
3751         "parse_gdbarch" with method call.
3752         * ada-lex.l: Replace "parse_gdbarch" with method call.
3753         * ada-exp.y (parse_type, find_primitive_type, type_char)
3754         (type_system_address): Replace "parse_gdbarch" with method call.
3755
3756 2019-04-04  Tom Tromey  <tom@tromey.com>
3757
3758         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3759         * stap-probe.c (stap_parse_argument): Update.
3760         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3761         initial_size parameter.
3762         * rust-exp.y (rust_lex_tests): Update.
3763         * parse.c (parser_state): Update.
3764         (parse_exp_in_context): Update.
3765         * parser-defs.h (struct parser_state) <parser_state>: Remove
3766         "initial_size" parameter.
3767
3768 2019-04-04  Tom Tromey  <tom@tromey.com>
3769
3770         * parser-defs.h (increase_expout_size): Don't declare.
3771         * parse.c (increase_expout_size): Now static.
3772
3773 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3774
3775         * gnu-nat.c (gnu_nat_target::wait): Fix
3776         target_waitstatus_to_string call.
3777
3778 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3779
3780         * eval.c (evaluate_subexp_standard): Handle internal functions
3781         during Fortran function call handling.
3782
3783 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * NEWS: Mention new internal functions.
3786         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3787         (read_base_type): Use dwarf2_init_complex_target_type.
3788         * value.c (creal_internal_fn): New function.
3789         (cimag_internal_fn): New function.
3790         (_initialize_values): Register new internal functions.
3791
3792 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3793
3794         * infrun.c (stop_all_threads): If debug_infrun, always
3795         trace the wait status after wait_one, using
3796         target_waitstatus_to_string and target_pid_to_str.
3797         (handle_inferior_event): Replace various trace of
3798         wait status kind by a single trace.
3799         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3800         wait status kind image by target_waitstatus_to_string.
3801         * target/waitstatus.c (target_waitstatus_to_string): Fix
3802         obsolete comment.
3803
3804 2019-04-01  Tom Tromey  <tromey@adacore.com>
3805
3806         PR symtab/23331:
3807         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3808
3809 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3810             Pedro Alves  <palves@redhat.com>
3811
3812         * top.c (quit_force): Call 'finalize_values'.
3813         * value.c (finalize_values): New function.
3814         * value.h (finalize_values): Declare.
3815
3816 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3817
3818         * NEWS: Announce $_gdb_major and $_gdb_minor.
3819
3820         * top.c (init_gdb_version_vars): New function.
3821         (gdb_init): Call init_gdb_version_vars.
3822
3823 2019-03-29  Tom Tromey  <tromey@adacore.com>
3824
3825         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3826         help text.  Remove dead code.
3827
3828 2019-03-29  Keith Seitz  <keiths@redhat.com>
3829
3830         From Siddhesh Poyarekar:
3831         * f-lang.h (f77_get_upperbound): Return LONGEST.
3832         (f77_get_lowerbound): Likewise.
3833         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3834         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3835         print them.
3836         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3837         plongest to format print it.
3838         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3839         (f77_get_upperbound): Likewise.
3840         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3841         LOWER_BOUND to LONGEST.
3842         (f77_create_arrayprint_offset_tbl): Likewise.
3843
3844 2019-03-29  Keith Seitz  <keiths@redhat.com>
3845
3846         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3847         %s/pulongest for TYPE_LENGTH instead of %d in format
3848         strings.
3849         * ada-typerint.c (ada_print_type): Likewise.
3850         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3851         * compile/compile-c-support.c (generate_register_struct): Likewise.
3852         * gdbtypes.c (recursive_dump_type): Likewise.
3853         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3854         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3855         instead of %d in format strings.
3856         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3857         to std::min to ULONGEST.
3858         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3859         instead of %d in format strings.
3860         * tracepoint.c (info_scope_command): Likewise.
3861         * typeprint.c (print_offset_data::update)
3862         (print_offset_data::finish): Likewise.
3863         * xtensa-tdep.c (xtensa_store_return_value)
3864         (xtensa_push_dummy_call): Likewise.
3865
3866 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3867
3868         * windows-nat.c (display_selector): Fixed format specifications
3869         for 64-bit Cygwin.
3870
3871 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3872
3873         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3874
3875 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3876
3877         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3878         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3879         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3880         (nios2_linux_init_abi): Install it.
3881
3882 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3883
3884         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3885
3886 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3887
3888         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3889
3890 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3891             Tom Tromey  <tromey@adacore.com>
3892
3893         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3894
3895 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3896
3897         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3898         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3899         method to compute the bounds of range types. Also print "[evaluated]"
3900         if the bounds' values come from a dynamic evaluation.
3901
3902 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3903
3904         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3905         whitespace when pretty printing is on.
3906
3907 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3908
3909         * ppc-linux-nat.c: Add include.
3910
3911 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3912
3913         * NEWS: Mention AArch64 Pointer Authentication.
3914
3915 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3916
3917         * arm-linux-nat.c: Add include.
3918
3919 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3920
3921         * source-cache.c (source_cache::get_source_lines): Re-read
3922         fullname after calling open_source_file.
3923
3924 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3925
3926         * NEWS: Mention TLS support for FreeBSD.
3927
3928 2019-03-25  Tom Tromey  <tromey@adacore.com>
3929
3930         * minsyms.c (BUNCH_SIZE): Update comment.
3931         (~minimal_symbol_reader): Remove old comment.
3932         (compact_minimal_symbols): Update comment.
3933         (minimal_symbol_reader::install): Remove old comment.  Update
3934         other comments.
3935
3936 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3937
3938         * s390-linux-nat.c: Add include.
3939
3940 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3941
3942         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3943         Call linux_get_hwcap.
3944         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3945         Likewise.
3946         (aarch64_linux_get_hwcap): Remove function.
3947         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3948         declaration.
3949         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3950         linux_get_hwcap.
3951         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3952         * linux-tdep.c (linux_get_hwcap): Add function.
3953         (linux_get_hwcap2): Likewise.
3954         * linux-tdep.h (linux_get_hwcap): Add declaration.
3955         (linux_get_hwcap2): Likewise.
3956         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3957         (ppc_linux_get_hwcap2): Likewise.
3958         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3959         linux_get_hwcap.
3960         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3961         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3962         (ppc_linux_nat_target::read_description): Likewise.
3963         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3964         * s390-linux-nat.c: Likewise.
3965         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3966
3967 2019-03-24  Tom Tromey  <tom@tromey.com>
3968
3969         * ada-lang.c (standard_lookup): Simplify initialization.
3970         (ada_lookup_symbol_nonlocal): Simplify return.
3971         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3972         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3973         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3974         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3975         initialization.
3976         * solib.c (solib_global_lookup): Simplify.
3977         * symtab.c (null_block_symbol): Remove.
3978         (symbol_cache_lookup): Simplify returns.
3979         (lookup_language_this): Simplify returns.
3980         (lookup_symbol_aux): Simplify return.
3981         (lookup_local_symbol): Simplify returns.
3982         (lookup_global_symbol_from_objfile): Simplify return.
3983         (lookup_symbol_in_objfile_symtabs)
3984         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3985         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3986         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3987         * cp-namespace.c (cp_lookup_bare_symbol)
3988         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3989         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3990         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3991         (cp_lookup_symbol_via_imports): Simplify initialization.
3992         (find_symbol_in_baseclass): Likewise.
3993         * symtab.h (null_block_symbol): Remove.
3994         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3995         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3996         (d_lookup_symbol_module): Likewise.
3997         (find_symbol_in_baseclass): Simplify initialization.
3998
3999 2019-03-24  Tom Tromey  <tom@tromey.com>
4000
4001         * expression.h: Don't include symtab.h.
4002         (struct block): Forward declare.
4003
4004 2019-03-24  Tom Tromey  <tom@tromey.com>
4005
4006         * c-exp.y (typebase): Remove casts.
4007         * gdbtypes.c (lookup_unsigned_typename, )
4008         (lookup_signed_typename): Remove cast.
4009         * eval.c (parse_to_comma_and_eval): Remove cast.
4010         * parse.c (write_dollar_variable): Remove cast.
4011         * block.h (struct block) <superblock>: Now const.
4012         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4013         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4014         (map_block): Make "block" const.
4015         * symfile.h (struct quick_symbol_functions)
4016         <map_matching_symbols>: Constify block argument to "callback".
4017         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4018         const.
4019         (find_pc_sect_compunit_symtab): Make "b" const.
4020         (find_symbol_at_address): Likewise.
4021         (search_symbols): Likewise.
4022         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4023         (dw2_debug_names_lookup_symbol): Likewise.
4024         (dw2_map_matching_symbols): Update.
4025         * p-valprint.c (pascal_val_print): Remove "block".
4026         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4027         (aux_add_nonlocal_symbols): Make "block" const.
4028         (resolve_subexp): Remove cast.
4029         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4030         const.
4031         (iterate_over_file_blocks): Likewise.
4032         * f-exp.y (%union) <bval>: Remove.
4033         * coffread.c (patch_opaque_types): Make "b" const.
4034         * spu-tdep.c (spu_catch_start): Make "block" const.
4035         * c-valprint.c (print_unpacked_pointer): Remove "block".
4036         * symmisc.c (dump_symtab_1): Make "b" const.
4037         (block_depth): Make "block" const.
4038         * d-exp.y (%union) <bval>: Remove.
4039         * cp-support.h (cp_lookup_rtti_type): Update.
4040         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4041         * psymtab.c (psym_lookup_symbol): Make "block" const.
4042         (maintenance_check_psymtabs): Make "b" const.
4043         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4044         (enumerate_locals, enumerate_args): Update.
4045         * python/py-symtab.c (stpy_global_block): Make "block" const.
4046         (stpy_static_block): Likewise.
4047         * inline-frame.c (block_starting_point_at): Make "new_block"
4048         const.
4049         * block.c (find_block_in_blockvector): Make return type const.
4050         (blockvector_for_pc_sect): Make "b" const.
4051         (find_block_in_blockvector): Make "b" const.
4052
4053 2019-03-23  Tom Tromey  <tom@tromey.com>
4054
4055         * varobj.c (varobj_create): Update.
4056         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4057         * printcmd.c (display_command, do_one_display): Don't reset
4058         innermost_block.
4059         * parser-defs.h (enum innermost_block_tracker_type): Move to
4060         expression.h.
4061         (innermost_block): Update comment.
4062         * parse.c (parse_exp_1): Add tracker_types parameter.
4063         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4064         tracker_types parameter.  Reset innermost_block.
4065         (parse_exp_in_context): Remove.
4066         (parse_expression_for_completion): Update.
4067         * objfiles.c (~objfile): Don't reset expression_context_block or
4068         innermost_block.
4069         * expression.h (enum innermost_block_tracker_type): Move from
4070         parser-defs.h.
4071         (parse_exp_1): Add tracker_types parameter.
4072         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4073         reset innermost_block.
4074
4075 2019-03-23  Tom Tromey  <tom@tromey.com>
4076
4077         * objfiles.h: Include bcache.h.
4078
4079 2019-03-23  Tom Tromey  <tom@tromey.com>
4080
4081         * linespec.c (get_current_search_block): Use
4082         scoped_restore_current_language.
4083         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4084
4085 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4086             Jiong Wang  <jiong.wang@arm.com>
4087
4088         * aarch64-linux-tdep.c
4089         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4090         section.
4091         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4092
4093 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4094             Jiong Wang  <jiong.wang@arm.com>
4095
4096         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4097         instructions.
4098         (aarch64_analyze_prologue_test): Add PACIASP test.
4099         (aarch64_prologue_prev_register): Unmask PC value.
4100
4101 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4102             Jiong Wang  <jiong.wang@arm.com>
4103
4104         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4105         (aarch64_dwarf2_prev_register): Unmask PC value.
4106         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4107         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4108         DW_CFA_AARCH64_negate_ra_state.
4109         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4110
4111 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4112             Jiong Wang  <jiong.wang@arm.com>
4113
4114         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4115         registers.
4116         (aarch64_pseudo_register_name): Likewise.
4117         (aarch64_pseudo_register_type): Likewise.
4118         (aarch64_pseudo_register_reggroup_p): Likewise.
4119         (aarch64_gdbarch_init): Add pauth registers.
4120         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4121         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4122         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4123         (struct gdbarch_tdep): Add regnum for ra_state.
4124
4125 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4126             Jiong Wang  <jiong.wang@arm.com>
4127
4128         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4129
4130 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4131             Jiong Wang  <jiong.wang@arm.com>
4132
4133         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4134         function.
4135         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4136         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4137         (aarch64_gdbarch_init): Add puth registers.
4138         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4139         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4140         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4141
4142 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4143             Jiong Wang  <jiong.wang@arm.com>
4144
4145         * aarch64-linux-nat.c
4146         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4147         * aarch64-linux-tdep.c
4148         (aarch64_linux_core_read_description): Likewise.
4149         (aarch64_linux_get_hwcap): New function.
4150         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4151         (aarch64_linux_get_hwcap): New declaration.
4152
4153 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4154             Jiong Wang  <jiong.wang@arm.com>
4155
4156         * aarch64-linux-nat.c
4157         (aarch64_linux_nat_target::read_description): Add pauth param.
4158         * aarch64-linux-tdep.c
4159         (aarch64_linux_core_read_description): Likewise.
4160         * aarch64-tdep.c (struct target_desc): Add in pauth.
4161         (aarch64_read_description): Add pauth param.
4162         (aarch64_gdbarch_init): Likewise.
4163         * aarch64-tdep.h (aarch64_read_description): Likewise.
4164         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4165         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4166         * features/Makefile: Add new files.
4167         * features/aarch64-pauth.c: New file.
4168         * features/aarch64-pauth.xml: New file.
4169
4170 2019-03-20  Tom Tromey  <tromey@adacore.com>
4171
4172         * infrun.c (handle_inferior_event): Rename from
4173         handle_inferior_event_1.  Create a scoped_value_mark.
4174         (handle_inferior_event): Remove.
4175
4176 2019-03-19  Tom Tromey  <tromey@adacore.com>
4177
4178         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4179         * infrun.h (print_stop_event): Add "displays" parameter.
4180         * infrun.c (print_stop_event): Add "displays" parameter.
4181
4182 2019-03-19  Pedro Alves  <palves@redhat.com>
4183
4184         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4185         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4186         to -1.  Fix TABs vs spaces.
4187         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4188         * tui/tui-out.h (tui_ui_out) Add intro comments.
4189         <m_line, m_start_of_line>: In-class initialize, and add describing
4190         comment.
4191
4192 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4193
4194         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4195         variable names.
4196         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4197
4198 2019-03-18  Pedro Alves  <palves@redhat.com>
4199             Eli Zaretskii <eliz@gnu.org>
4200
4201         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4202         m_line and m_start_of_line.
4203
4204 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4205
4206         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4207         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4208         it returns a newline.  This fixes a regression in TU mode, whereby
4209         the next line is output on the same screen line as the user input.
4210
4211 2019-03-18  Tom Tromey  <tromey@adacore.com>
4212
4213         * minsyms.c (minimal_symbol_reader::install): Remove call to
4214         obstack_blank.
4215
4216 2019-03-18  Pedro Alves  <palves@redhat.com>
4217
4218         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4219         New globals.
4220         (apply_style): New, factored out from ...
4221         (apply_ansi_escape): ... this.  Handle reverse video mode.
4222         (tui_set_reverse_mode): New function.
4223         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4224         * tui/tui-winsource.c (tui_show_source_line): Use
4225         tui_set_reverse_mode instead of setting A_STANDOUT.
4226         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4227         New setter methods.
4228
4229 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4230
4231         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4232         Handle tabs.
4233
4234 2019-03-18  Tom Tromey  <tromey@adacore.com>
4235
4236         * ada-lang.c (empty_array): Add "high" parameter.
4237         (ada_evaluate_subexp): Update.
4238
4239 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4240
4241         * unittests/string_view-selftests.c: Define
4242         _initialize_string_view_selftests unconditionally.
4243
4244 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4245
4246         PR gdb/24350
4247         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4248
4249 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4250
4251         PR gdb/24351
4252         * windows-nat.c (display_selector): Fix format specifiers.
4253
4254 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4255
4256         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4257         tui_refill_source_window instead of tui_refresh_win, to update the
4258         current execution line.  This fixes redisplay of the current line
4259         when stepping through the code with "next" or "step".
4260
4261 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4262
4263         * source-cache.c (source_cache::get_source_lines): Call
4264         find_source_lines to initialize s->nlines.  This fixes vertical
4265         scrolling of TUI source window when the DOWN arrow is pressed.
4266
4267 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4268
4269         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4270         linux-thread-db.c (_initialize_thread_db): Likewise.
4271
4272 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4273
4274         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4275         wclrtoeol in tui_show_source_line".  This reverts changes made in
4276         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4277
4278 2019-03-15  Tom Tromey  <tom@tromey.com>
4279
4280         * symtab.h (struct minimal_symbol): Derive from
4281         general_symbol_info.
4282         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4283         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4284         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4285         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4286         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4287         (MSYMBOL_SEARCH_NAME): Update.
4288         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4289         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4290         * minsyms.c (minimal_symbol_reader::record_full): Update.
4291
4292 2019-03-15  Tom Tromey  <tom@tromey.com>
4293
4294         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4295
4296 2019-03-15  Tom Tromey  <tom@tromey.com>
4297
4298         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4299         unique_xmalloc_ptr.
4300         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4301         Update.
4302         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4303         (build_minimal_symbol_hash_tables)
4304         (minimal_symbol_reader::install): Update.
4305
4306 2019-03-15  Tom Tromey  <tom@tromey.com>
4307
4308         * symtab.c (create_demangled_names_hash): Update.
4309         (symbol_set_names): Update.
4310         * objfiles.h (struct objfile_per_bfd_storage)
4311         <demangled_names_hash>: Now an htab_up.
4312         * objfiles.c (objfile_per_bfd_storage): Simplify.
4313
4314 2019-03-15  Tom Tromey  <tom@tromey.com>
4315
4316         * objfiles.h (struct objfile_per_bfd_storage): Declare
4317         destructor.
4318         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4319         New.
4320         (get_objfile_bfd_data): Use new.  Don't initialize
4321         language_of_main.
4322         (free_objfile_per_bfd_storage): Remove.
4323         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4324
4325 2019-03-15  Tom Tromey  <tom@tromey.com>
4326
4327         * symfile.c (reread_symbols): Update.
4328         * objfiles.c (objfile::objfile): Update.
4329         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4330         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4331         comment.
4332         (minimal_symbol_reader::install): Update.
4333         (terminate_minimal_symbol_table): Remove.
4334         * jit.c (jit_object_close_impl): Update.
4335
4336 2019-03-15  Tom Tromey  <tom@tromey.com>
4337
4338         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4339         initializations.
4340
4341 2019-03-15  Tom Tromey  <tom@tromey.com>
4342
4343         * objfiles.h (struct objfile_per_bfd_storage)
4344         <demangled_hash_languages>: Now a bitset.
4345         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4346         (lookup_minimal_symbol): Update.
4347
4348 2019-03-15  Tom Tromey  <tom@tromey.com>
4349
4350         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4351         Don't return the symbol.
4352         * coffread.c (record_minimal_symbol): Use record_full.
4353
4354 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4355
4356         The MS-Windows port of ncurses fails to switch to a color pair if
4357         one or both of the colors are the implicit default colors.  This
4358         change records the default colors when TUI is initialized, and
4359         then specifies them explicitly when a color pair uses the default
4360         colors.  This allows color styling in TUI mode on MS-Windows.
4361
4362         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4363         ncurses_norm_attr.
4364         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4365         colors in ncurses_norm_attr.
4366         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4367         "none", replace it with the default color recorded in
4368         ncurses_norm_attr.
4369
4370 2019-03-14  Tom Tromey  <tromey@adacore.com>
4371
4372         * source-cache.h (class source_cache) <get_source_lines>: Return
4373         std::string.
4374         * source-cache.c (source_cache::extract_lines): Handle case where
4375         first_pos==npos.  Return std::string.
4376         (source_cache::get_source_lines): Update.
4377
4378 2019-03-14  Tom Tromey  <tromey@adacore.com>
4379
4380         * NEWS: Add item for "style sources" commands.
4381         * source-cache.c (source_cache::get_source_lines): Check
4382         source_styling.
4383         * cli/cli-style.c (source_styling): New global.
4384         (_initialize_cli_style): Add "style sources" commands.
4385         (show_style_sources): New function.
4386         * cli/cli-style.h (source_styling): Declare.
4387
4388 2019-03-14  Pedro Alves  <palves@redhat.com>
4389             Tom Tromey  <tromey@adacore.com>
4390
4391         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4392         * tui/tui-winsource.c (tui_refill_source_window): New function,
4393         from...
4394         (tui_horizontal_source_scroll): ... here.  Move some logic.
4395         * cli/cli-style.c (set_style_enabled): Notify new observable.
4396         * tui/tui-hooks.c (tui_redisplay_source): New function.
4397         (tui_attach_detach_observers): Attach or detach
4398         tui_redisplay_source.
4399         * observable.h (source_styling_changed): New observable.
4400         * observable.c: Define source_styling_changed observable.
4401
4402 2019-03-13  Tom Tromey  <tromey@adacore.com>
4403
4404         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4405         (i386_gnu_nat_target::store_registers): Update.
4406         * target-debug.h (target_debug_print_std_string): New macro.
4407         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4408         * windows-tdep.c (display_one_tib): Update.
4409         * tui/tui-stack.c (tui_make_status_line): Update.
4410         * top.c (print_inferior_quit_action): Update.
4411         * thread.c (thr_try_catch_cmd): Update.
4412         (add_thread_with_info): Update.
4413         (thread_target_id_str): Update.
4414         (thr_try_catch_cmd): Update.
4415         (thread_command): Update.
4416         (thread_find_command): Update.
4417         * record-btrace.c (record_btrace_target::info_record)
4418         (record_btrace_resume_thread, record_btrace_target::resume)
4419         (record_btrace_cancel_resume, record_btrace_step_thread)
4420         (record_btrace_target::wait, record_btrace_target::wait)
4421         (record_btrace_target::wait, record_btrace_target::stop): Update.
4422         * progspace.c (print_program_space): Update.
4423         * process-stratum-target.c
4424         (process_stratum_target::thread_address_space): Update.
4425         * linux-fork.c (linux_fork_mourn_inferior)
4426         (detach_checkpoint_command, info_checkpoints_command)
4427         (linux_fork_context): Update.
4428         (linux_fork_detach): Update.
4429         (class scoped_switch_fork_info): Update.
4430         (delete_checkpoint_command): Update.
4431         * infrun.c (follow_fork_inferior): Update.
4432         (follow_fork_inferior): Update.
4433         (proceed_after_vfork_done): Update.
4434         (handle_vfork_child_exec_or_exit): Update.
4435         (follow_exec): Update.
4436         (displaced_step_prepare_throw): Update.
4437         (displaced_step_restore): Update.
4438         (start_step_over): Update.
4439         (resume_1): Update.
4440         (clear_proceed_status_thread): Update.
4441         (proceed): Update.
4442         (print_target_wait_results): Update.
4443         (do_target_wait): Update.
4444         (context_switch): Update.
4445         (stop_all_threads): Update.
4446         (restart_threads): Update.
4447         (finish_step_over): Update.
4448         (handle_signal_stop): Update.
4449         (switch_back_to_stepped_thread): Update.
4450         (keep_going_pass_signal): Update.
4451         (print_exited_reason): Update.
4452         (normal_stop): Update.
4453         * inferior.c (inferior_pid_to_str): Change return type.
4454         (print_selected_inferior): Update.
4455         (add_inferior): Update.
4456         (detach_inferior): Update.
4457         * dummy-frame.c (fprint_dummy_frames): Update.
4458         * dcache.c (dcache_info_1): Update.
4459         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4460         (btrace_fetch, btrace_clear): Update.
4461         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4462         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4463         type.
4464         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4465         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4466         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4467         * gdbarch.c, gdbarch.h: Rebuild.
4468         * gdbarch.sh (core_pid_to_str): Change return type.
4469         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4470         return type.
4471         (windows_nat_target::pid_to_str): Change return type.
4472         (windows_delete_thread): Update.
4473         (windows_nat_target::attach): Update.
4474         (windows_nat_target::files_info): Update.
4475         * target-delegates.c: Rebuild.
4476         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4477         return type.
4478         (sol_thread_target::pid_to_str): Change return type.
4479         * remote.c (class remote_target) <pid_to_str>: Change return
4480         type.
4481         (remote_target::pid_to_str): Change return type.
4482         (extended_remote_target::attach, remote_target::remote_stop_ns)
4483         (remote_target::remote_notif_remove_queued_reply)
4484         (remote_target::push_stop_reply, remote_target::disable_btrace):
4485         Update.
4486         (extended_remote_target::attach): Update.
4487         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4488         type.
4489         (gdbsim_target::pid_to_str): Change return type.
4490         * ravenscar-thread.c (struct ravenscar_thread_target)
4491         <pid_to_str>: Change return type.
4492         (ravenscar_thread_target::pid_to_str): Change return type.
4493         * procfs.c (class procfs_target) <pid_to_str>: Change return
4494         type.
4495         (procfs_target::pid_to_str): Change return type.
4496         (procfs_target::attach): Update.
4497         (procfs_target::detach): Update.
4498         (procfs_target::fetch_registers): Update.
4499         (procfs_target::store_registers): Update.
4500         (procfs_target::wait): Update.
4501         (procfs_target::files_info): Update.
4502         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4503         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4504         return type.
4505         (nto_procfs_target::pid_to_str): Change return type.
4506         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4507         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4508         return type.
4509         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4510         (exit_lwp): Update.
4511         (attach_proc_task_lwp_callback, get_detach_signal)
4512         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4513         (linux_nat_target::resume, wait_lwp, stop_callback)
4514         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4515         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4516         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4517         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4518         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4519         type.
4520         (inf_ptrace_target::attach): Update.
4521         (inf_ptrace_target::files_info): Update.
4522         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4523         type.
4524         (go32_nat_target::pid_to_str): Change return type.
4525         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4526         (gnu_nat_target::wait): Update.
4527         (gnu_nat_target::wait): Update.
4528         (gnu_nat_target::resume): Update.
4529         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4530         (fbsd_nat_target::wait): Update.
4531         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4532         type.
4533         (darwin_nat_target::attach): Update.
4534         * corelow.c (class core_target) <pid_to_str>: Change return type.
4535         (core_target::pid_to_str): Change return type.
4536         * target.c (normal_pid_to_str): Change return type.
4537         (default_pid_to_str): Likewise.
4538         (target_pid_to_str): Change return type.
4539         (target_translate_tls_address): Update.
4540         (target_announce_detach): Update.
4541         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4542         return type.
4543         (bsd_uthread_target::pid_to_str): Change return type.
4544         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4545         type.
4546         (bsd_kvm_target::pid_to_str): Change return type.
4547         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4548         return type.
4549         (aix_thread_target::pid_to_str): Change return type.
4550         * target.h (struct target_ops) <pid_to_str>: Change return type.
4551         (target_pid_to_str, normal_pid_to_str): Likewise.
4552         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4553         type.
4554         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4555         type.
4556         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4557         return type.
4558         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4559         type.
4560         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4561         type.
4562         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4563         return type.
4564
4565 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4566
4567         * NEWS: Mention that the new default MI version is 3.  Mention
4568         changes to the output of commands and events that deal with
4569         multi-location breakpoints.
4570         * breakpoint.c: Include "mi/mi-out.h".
4571         (print_one_breakpoint): Change output syntax if using MI version
4572         >= 3.
4573         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4574         New.
4575         (mi_multi_location_breakpoint_output_fixed): New.
4576         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4577         (mi_cmd_fix_multi_location_breakpoint_output): New.
4578         (mi_multi_location_breakpoint_output_fixed): New.
4579         * mi/mi-cmds.c (mi_cmds): Register command
4580         -fix-multi-location-breakpoint-output.
4581         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4582         interpreter "mi".
4583
4584 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4585
4586         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4587         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4588         instantiate mi_ui_out based on interpreter name.
4589         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4590         * mi/mi-main.c (mi_load_progress): Likewise.
4591
4592 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4593
4594         * NEWS: Combine separate "New targets" sections for 8.3.
4595
4596 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4597
4598         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4599         (ppcfbsd_init_abi): Install gdbarch
4600         "fetch_tls_load_module_address" and "get_thread_local_address"
4601         methods.
4602
4603 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4604
4605         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4606         (riscv_fbsd_init_abi): Install gdbarch
4607         "fetch_tls_load_module_address" and "get_thread_local_address"
4608         methods.
4609
4610 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4611
4612         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4613         (i386fbsd_init_abi): Install gdbarch
4614         "fetch_tls_load_module_address" and "get_thread_local_address"
4615         methods.
4616
4617 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4618
4619         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4620         (amd64fbsd_init_abi): Install gdbarch
4621         "fetch_tls_load_module_address" and "get_thread_local_address"
4622         methods.
4623
4624 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4625
4626         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4627         (struct fbsd_pspace_data): New type.
4628         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4629         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4630         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4631         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4632         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4633
4634 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4635
4636         * gdbtypes.c (lookup_struct_elt): New function.
4637         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4638         * gdbtypes.h (struct struct_elt): New type.
4639         (lookup_struct_elt): New prototype.
4640
4641 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4642
4643         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4644         remove disabled code block.
4645
4646 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4647
4648         * gdbarch.sh (get_thread_local_address): New method.
4649         * gdbarch.h, gdbarch.c: Regenerate.
4650         * target.c (target_translate_tls_address): Use
4651         gdbarch_get_thread_local_address if present instead of
4652         target::get_thread_local_address.
4653
4654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4655
4656         * target.h (target::get_thread_local_address): Update comment.
4657
4658 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4659
4660         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4661         objfile->separate_debug_objfile_backlink if not NULL.
4662
4663 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4664
4665         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4666         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4667         (amd64bsd_store_inferior_registers): Likewise.
4668         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4669         Enable segment base registers.
4670         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4671         PT_GETFSBASE and PT_GETGSBASE.
4672         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4673         PT_SETGSBASE.
4674         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4675         segment base registers.
4676         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4677
4678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4679
4680         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4681         Update calls to i386_target_description to add 'segments'
4682         parameter.
4683         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4684         add segment base registers.
4685         * arch/i386.c (i386_create_target_description): Add 'segments'
4686         parameter to enable segment base registers.
4687         * arch/i386.h (i386_create_target_description): Likewise.
4688         * features/i386/32bit-segments.xml: New file.
4689         * features/i386/32bit-segments.c: Generate.
4690         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4691         call to i386_target_description to add 'segments' parameter.
4692         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4693         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4694         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4695         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4696         if feature is present.
4697         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4698         Add 'segments' parameter to call to i386_target_description.
4699         (i386_target_description): Add 'segments' parameter to enable
4700         segment base registers.
4701         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4702         to call to i386_target_description.
4703         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4704         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4705         Define I386_NUM_REGS.
4706         (i386_target_description): Add 'segments' parameter to enable
4707         segment base registers.
4708
4709 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4710
4711         PR/24325
4712         * source-cache.c: #undef open and close, to avoid unresolved
4713         externals during linking.
4714
4715 2019-03-12  Tom Tromey  <tromey@adacore.com>
4716
4717         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4718         const.  Add initializers.
4719         (_initialize_remote): Don't initialize ptid globals.
4720
4721 2019-03-12  Pedro Alves  <palves@redhat.com>
4722
4723         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4724
4725 2019-03-12  Pedro Alves  <palves@redhat.com>
4726
4727         * cp-name-parser.y (main): Remove unused 'len' variable.
4728
4729 2019-03-12  Tom Tromey  <tromey@adacore.com>
4730
4731         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4732         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4733
4734 2019-03-12  Tom Tromey  <tromey@adacore.com>
4735
4736         * linux-nat.c (iterate_over_lwps): Update.
4737         (stop_callback): Remove parameter.
4738         (stop_wait_callback, detach_callback, resume_set_callback)
4739         (select_singlestep_lwp_callback, set_ignore_sigint)
4740         (status_callback, resumed_callback, resume_clear_callback)
4741         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4742         data parameter.
4743         (linux_nat_target::detach, linux_nat_target::resume)
4744         (linux_stop_and_wait_all_lwps, select_event_lwp)
4745         (linux_nat_filter_event, linux_nat_wait_1)
4746         (linux_nat_target::kill, linux_nat_target::stop)
4747         (linux_nat_target::stop): Update.
4748         (linux_nat_resume_callback): Change type.
4749         (resume_stopped_resumed_lwps, count_events_callback)
4750         (select_event_lwp_callback): Likewise.
4751         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4752         * arm-linux-nat.c (struct update_registers_data): Remove.
4753         (update_registers_callback): Change type.
4754         (arm_linux_insert_hw_breakpoint1): Update.
4755         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4756         parameter.
4757         (x86_linux_dr_set_addr): Update.
4758         (x86_linux_dr_set_control): Update.
4759         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4760         (iterate_over_lwps): Use gdb::function_view.
4761         * nat/aarch64-linux-hw-point.c (struct
4762         aarch64_dr_update_callback_param): Remove.
4763         (debug_reg_change_callback): Change type.
4764         (aarch64_notify_debug_reg_change): Update.
4765         * s390-linux-nat.c (s390_refresh_per_info): Update.
4766
4767 2019-03-11  Tom Tromey  <tromey@adacore.com>
4768
4769         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4770         redundant assignment to "this_cu".
4771
4772 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4773
4774         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4775
4776 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4777
4778         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4779         from...
4780         (rank_one_type): ... this.
4781
4782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4783
4784         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4785         from...
4786         (rank_one_type): ... this.
4787
4788 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4789
4790         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4791         from...
4792         (rank_one_type): ... this.
4793
4794 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4795
4796         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4797         from...
4798         (rank_one_type): ... this.
4799
4800 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4801
4802         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4803         from...
4804         (rank_one_type): ... this.
4805
4806 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4807
4808         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4809         from...
4810         (rank_one_type): ... this.
4811
4812 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4813
4814         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4815         from...
4816         (rank_one_type): ... this.
4817
4818 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4819
4820         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4821         from...
4822         (rank_one_type): ... this.
4823
4824 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4825
4826         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4827         from...
4828         (rank_one_type): ... this.
4829
4830 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4831
4832         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4833         from...
4834         (rank_one_type): ... this.
4835
4836 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4837
4838         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4839         from...
4840         (rank_one_type): ... this.
4841
4842 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4843
4844         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4845         from...
4846         (rank_one_type): ... this.
4847
4848 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4849
4850         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4851         inferior-events' shows the example events.
4852
4853 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4854
4855         Support styling on native MS-Windows console
4856
4857         PR/24315
4858         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4859         on MS-Windows if $TERM is not defined.
4860
4861         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4862
4863         * posix-hdep.c (gdb_console_fputs):
4864         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4865         functions.
4866         * ui-file.h (gdb_console_fputs): Add prototype.
4867
4868         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4869         back to fputs only if the former returns zero.
4870
4871 2019-03-07  Tom Tromey  <tom@tromey.com>
4872
4873         * symmisc.c (print_symbol_bcache_statistics): Update.
4874         (print_objfile_statistics): Update.
4875         * symfile.c (allocate_symtab): Update.
4876         * stabsread.c: Don't include bcache.h.
4877         * psymtab.h (struct psymbol_bcache): Don't declare.
4878         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4879         (psymbol_bcache_init, psymbol_bcache_free)
4880         (psymbol_bcache_get_bcache): Don't declare.
4881         * psymtab.c (struct psymbol_bcache): Remove.
4882         (psymtab_storage::psymtab_storage): Update.
4883         (psymtab_storage::~psymtab_storage): Update.
4884         (psymbol_bcache_init, psymbol_bcache_free)
4885         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4886         (add_psymbol_to_bcache): Update.
4887         (allocate_psymtab): Update.
4888         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4889         macro_cache>: No longer pointers.
4890         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4891         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4892         * macrotab.c (macro_bcache): Update.
4893         * macroexp.c: Don't include bcache.h.
4894         * gdbtypes.c (check_types_worklist): Update.
4895         (types_deeply_equal): Remove TRY/CATCH.  Update.
4896         * elfread.c (elf_symtab_read): Update.
4897         * dwarf2read.c: Don't include bcache.h.
4898         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4899         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4900         (print_bcache_statistics, bcache_memory_used): Don't declare.
4901         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4902         methods.  Rename all data members.
4903         * bcache.c (struct bcache): Move to bcache.h.
4904         (bcache::expand_hash_table): Rename from expand_hash_table.
4905         (bcache): Remove.
4906         (bcache::insert): Rename from bcache_full.
4907         (bcache::compare): Rename from bcache_compare.
4908         (bcache_xmalloc): Remove.
4909         (bcache::~bcache): Rename from bcache_xfree.
4910         (bcache::print_statistics): Rename from print_bcache_statistics.
4911         (bcache::memory_used): Rename from bcache_memory_used.
4912
4913 2019-03-07  Pedro Alves  <palves@redhat.com>
4914
4915         * infrun.c (normal_stop): Also check for
4916         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4917
4918 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * f-lang.c (value_from_host_double): Moved to...
4921         * value.c (value_from_host_double): ...here.
4922         * value.h (value_from_host_double): Declare.
4923         * guile/scm-math.c (vlscm_convert_typed_number): Use
4924         value_from_host_double.
4925         (vlscm_convert_number): Likewise.
4926         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4927         * python/py-value.c (convert_value_from_python): Likewise.
4928
4929 2019-03-06  Tom Tromey  <tom@tromey.com>
4930
4931         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4932
4933 2019-03-06  Tom Tromey  <tom@tromey.com>
4934
4935         * utils.h (free_current_contents): Don't declare.
4936         * utils.c (free_current_contents): Remove.
4937
4938 2019-03-06  Tom Tromey  <tom@tromey.com>
4939
4940         * top.c (quit_force): Update.
4941         * main.c (captured_command_loop): Update.
4942         * common/new-op.c (operator new): Update.
4943         * common/common-exceptions.c (struct catcher)
4944         <save_cleanup_chain>: Remove member.
4945         (exceptions_state_mc_init): Update.
4946         (exception_try_scope_entry): Return nullptr.
4947         (exception_try_scope_exit, exception_rethrow)
4948         (throw_exception_sjlj, throw_exception_cxx): Update.
4949         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4950         (all_cleanups, do_cleanups, discard_cleanups)
4951         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4952         (restore_cleanups, restore_final_cleanups): Don't declare.
4953         (do_final_cleanups): Remove parameter.
4954         * common/cleanups.c (cleanup_chain, make_cleanup)
4955         (make_cleanup_dtor, all_cleanups, do_cleanups)
4956         (discard_my_cleanups, discard_cleanups)
4957         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4958         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4959         (null_cleanup): Remove.
4960         (do_final_cleanups): Remove parameter.
4961
4962 2019-03-06  Tom Tromey  <tom@tromey.com>
4963
4964         * remote.c (remote_target::remote_parse_stop_reply): Use
4965         unique_xmalloc_ptr.
4966
4967 2019-03-06  Tom Tromey  <tom@tromey.com>
4968
4969         * stabsread.c (struct stabs_field_info): Rename from field_info.
4970         <list, fnlist>: Add initializers.
4971         <obstack>: New member.
4972         (read_member_functions, read_struct_fields, read_baseclasses):
4973         Allocate on obstack.  Don't use cleanups.
4974         (read_one_struct_field, read_member_functions, read_struct_fields)
4975         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4976         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4977         (read_struct_type): Update.
4978
4979 2019-03-06  Tom Tromey  <tom@tromey.com>
4980
4981         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4982         * common/filestuff.h (make_cleanup_close): Don't declare.
4983         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4984         Remove.
4985
4986 2019-03-06  Tom Tromey  <tom@tromey.com>
4987
4988         * solib-aix.c: Use make_scope_exit.
4989
4990 2019-03-06  Tom Tromey  <tom@tromey.com>
4991
4992         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4993         Use make_scope_exit.
4994
4995 2019-03-06  Tom Tromey  <tom@tromey.com>
4996
4997         * solib-svr4.c (disable_probes_interface): Remove parameter.
4998         (svr4_handle_solib_event): Use make_scope_exit.
4999
5000 2019-03-06  Tom Tromey  <tom@tromey.com>
5001
5002         * remote.c (struct stop_reply_deleter): Remove.
5003         (stop_reply_up): Update.
5004         (struct stop_reply): Derive from notif_event.  Don't typedef.
5005         <regcache>: Now a std::vector.
5006         (stop_reply_xfree): Remove.
5007         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5008         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5009         (remote_target::discard_pending_stop_replies): Use delete.
5010         (remote_target::remote_parse_stop_reply): Update.
5011         (remote_target::process_stop_reply): Update.
5012         * remote-notif.h (struct notif_event): Add virtual destructor.
5013         Remove "dtr" member.
5014         (struct notif_client) <alloc_event>: Return a unique_ptr.
5015         (notif_event_xfree): Don't declare.
5016         (notif_event_up): New typedef.
5017         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5018         (notif_event_xfree, do_notif_event_xfree): Remove.
5019         (remote_notif_state_xfree): Update.
5020
5021 2019-03-06  Tom Tromey  <tom@tromey.com>
5022
5023         * infrun.c (displaced_step_clear_cleanup): Now a
5024         forward_scope_exit type.
5025         (displaced_step_prepare_throw): Update.
5026         (displaced_step_fixup): Update.
5027
5028 2019-03-06  Tom Tromey  <tom@tromey.com>
5029
5030         * inferior.h (class inferior): Update comment.
5031         * gdbthread.h (class thread_info): Update comment.
5032
5033 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5034             Tom Tromey  <tom@tromey.com>
5035
5036         * stabsread.h (struct stab_section_list): Remove.
5037         (coffstab_build_psymtabs): Update.
5038         * dbxread.c (symbuf_sections): Now a std::vector.
5039         (sect_idx): New global.
5040         (fill_symbuf): Update.
5041         (coffstab_build_psymtabs): Change type of stabsects parameter.
5042         Update.
5043         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5044         std::vector.
5045         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5046         (coff_locate_sections): Update.
5047         (coff_symfile_read): Remove cleanups.  Update.
5048         (init_stringtab): Add storage parameter.
5049         (free_stringtab, free_stringtab_cleanup): Remove.
5050         (init_lineno): Add storage parameter.
5051         (free_linetab, free_linetab_cleanup): Remove.
5052
5053 2019-03-06  Pedro Alves  <palves@redhat.com>
5054
5055         * linux-fork.c (fork_info::clobber_regs): Delete.
5056         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5057         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5058         comment.  Adjust.
5059         (scoped_switch_fork_info::scoped_switch_fork_info)
5060         (checkpoint_command, linux_fork_context): Adjust
5061         fork_save_infrun_state calls.
5062
5063 2019-03-06  Pedro Alves  <palves@redhat.com>
5064
5065         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5066         (inf_has_multiple_threads): Return 'bool' and rewrite using
5067         inferior_info::threads().
5068
5069 2019-03-06  Pedro Alves  <palves@redhat.com>
5070
5071         * linux-fork.c: Include <list>.
5072         (fork_list): Now a std::list instance.
5073         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5074         (forks_exist_p, find_last_fork): Adjust.
5075         (new_fork): Delete.
5076         (one_fork_p): New.
5077         (add_fork): Adjust.
5078         (free_fork): Delete, folded into fork_info::~fork_info().
5079         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5080         Adjust.
5081         (init_fork_list): Delete.
5082         (linux_fork_killall, linux_fork_mourn_inferior)
5083         (linux_fork_detach, info_checkpoints_command): Adjust.
5084         (_initialize_linux_fork): No longer call init_fork_list.
5085
5086 2019-03-06  Pedro Alves  <palves@redhat.com>
5087
5088         * linux-fork.c (new_fork): New, split out of ...
5089         (add_fork): ... this.  Return void.  Move "first fork" special
5090         case from here, to ...
5091         (checkpoint_command): ... here.
5092         * linux-linux.h (add_fork): Return void.
5093
5094 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5097
5098 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5099             Chris January  <chris.january@arm.com>
5100             David Lecomber  <david.lecomber@arm.com>
5101
5102         * f-exp.y: New token, UNOP_INTRINSIC.
5103         (exp): New pattern using UNOP_INTRINSIC token.
5104         (f77_keywords): Add 'abs' keyword.
5105         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5106         (value_from_host_double): New function.
5107         (evaluate_subexp_f): Support UNOP_ABS.
5108
5109 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5110
5111         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5112         types.
5113
5114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5117         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5118         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5119
5120 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5123
5124 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5125             Chris January  <chris.january@arm.com>
5126
5127         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5128         * f-exp.y: Define 'KIND' token.
5129         (exp): New pattern for KIND expressions.
5130         (ptype): Handle types with a kind extension.
5131         (direct_abs_decl): Extend to spot kind extensions.
5132         (f77_keywords): Add 'kind' to the list.
5133         (push_kind_type): New function.
5134         (convert_to_kind_type): New function.
5135         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5136         * parse.c (operator_length_standard): Likewise.
5137         * parser-defs.h (enum type_pieces): Add tp_kind.
5138         * std-operator.def: Add UNOP_KIND.
5139
5140 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5141
5142         * f-exp.y (f_parse): Set yydebug.
5143
5144 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * f-lang.c (evaluate_subexp_f): New function.
5147         (exp_descriptor_f): New global.
5148         (f_language_defn): Use exp_descriptor_f instead of
5149         exp_descriptor_standard.
5150
5151 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5152
5153         * f-exp.y (struct token): Add comments.
5154         (dot_ops): Remove uppercase versions and the end marker.
5155         (f77_keywords): Likewise.
5156         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5157         entries in the dot_ops array are case insensitive, and use
5158         strncasecmp to compare strings.  Also some whitespace cleanup in
5159         this area.  Similar for the f77_keywords array, except entries in
5160         this list might be case sensitive.
5161
5162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5163
5164         * f-exp.y (struct f77_boolean_val): Add comments.
5165         (boolean_values): Remove uppercase versions, and end marker.
5166         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5167         and use strncasecmp to achieve case insensitivity.  Additionally,
5168         perform whitespace cleanup around this code.
5169
5170 2019-03-06  Tom Tromey  <tromey@adacore.com>
5171
5172         * remote-sim.c (gdbsim_target_open): Use result of
5173         gdb_argv::release.
5174
5175 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5176         Dirk Schubert  <dirk.schubert@arm.com>
5177         Chris January  <chris.january@arm.com>
5178
5179         * eval.c (evaluate_subexp_standard): Call Fortran argument
5180         wrapping logic.
5181         * f-lang.c (struct value): A value which can be passed into a
5182         Fortran function call.
5183         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5184         where appropriate.
5185         (struct type): Value ready for a Fortran function call.
5186         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5187         is needed.
5188         * f-lang.h (fortran_argument_convert): Declaration.
5189         (fortran_preserve_arg_pointer): Declaration.
5190         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5191
5192 2019-03-05  Tom Tromey  <tromey@adacore.com>
5193
5194         * python/py-prettyprint.c (print_string_repr): Remove #if.
5195         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5196
5197 2019-03-05  Tom Tromey  <tromey@adacore.com>
5198
5199         * target.c (the_dummy_target): Move later.  Change type to
5200         "dummy_target".
5201         (initialize_targets): Don't initialize the_dummy_target.
5202
5203 2019-03-05  Tom Tromey  <tromey@adacore.com>
5204
5205         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5206         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5207
5208 2019-03-05  Tom Tromey  <tromey@adacore.com>
5209
5210         * windows-nat.c (windows_nat_target::attach)
5211         (windows_nat_target::detach): Don't call gdb_flush.
5212         * valprint.c (generic_val_print, val_print, val_print_string):
5213         Don't call gdb_flush.
5214         * utils.c (defaulted_query): Don't call gdb_flush.
5215         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5216         * target.c (target_announce_detach): Don't call gdb_flush.
5217         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5218         * remote.c (extended_remote_target::attach): Don't call
5219         gdb_flush.
5220         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5221         * printcmd.c (do_examine): Don't call gdb_flush.
5222         (info_display_command): Don't call gdb_flush.
5223         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5224         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5225         * memattr.c (info_mem_command): Don't call gdb_flush.
5226         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5227         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5228         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5229         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5230         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5231         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5232         (gnu_nat_target::detach): Don't call gdb_flush.
5233         * f-valprint.c (f_val_print): Don't call gdb_flush.
5234         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5235         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5236         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5237         gdb_flush.
5238         * c-valprint.c (c_val_print): Don't call gdb_flush.
5239         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5240
5241 2019-03-05  Tom Tromey  <tromey@adacore.com>
5242
5243         * varobj.c (update_dynamic_varobj_children): Update.
5244         (install_default_visualizer): Use reset, not release.
5245         * value.c (set_internalvar): Update.
5246         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5247         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5248         ATTRIBUTE_UNUSED_RESULT.
5249
5250 2019-03-05  Tom Tromey  <tromey@adacore.com>
5251
5252         * remote.c (class scoped_remote_fd) <release>: Add
5253         ATTRIBUTE_UNUSED_RESULT.
5254
5255 2019-03-05  Tom Tromey  <tromey@adacore.com>
5256
5257         * macroexp.c (struct macro_buffer) <release>: Add
5258         ATTRIBUTE_UNUSED_RESULT.
5259
5260 2019-03-05  Tom Tromey  <tromey@adacore.com>
5261
5262         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5263         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5264         ATTRIBUTE_UNUSED_RESULT.
5265
5266 2019-03-05  Tom Tromey  <tromey@adacore.com>
5267
5268         * common/scoped_fd.h (class scoped_fd) <release>: Add
5269         ATTRIBUTE_UNUSED_RESULT.
5270
5271 2019-03-05  Tom Tromey  <tromey@adacore.com>
5272
5273         * parser-defs.h (struct parser_state) <release>: Add
5274         ATTRIBUTE_UNUSED_RESULT.
5275
5276 2019-03-05  Tom Tromey  <tromey@adacore.com>
5277
5278         * utils.h (class gdb_argv) <release>: Add
5279         ATTRIBUTE_UNUSED_RESULT.
5280         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5281
5282 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5283
5284         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5285         for-loop range, to avoid compiler warnings.
5286
5287         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5288         avoid compiler warnings about unused variables.
5289
5290         * NEWS: Mention end of support for native debugging on MS-Windows
5291         before XP.
5292
5293         PR gdb/24292
5294         * common/netstuff.c:
5295         * gdbserver/gdbreplay.c
5296         * gdbserver/remote-utils.c:
5297         * ser-tcp.c:
5298         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5299         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5300         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5301         'getaddrinfo' and 'freeaddrinfo' were not available before
5302         Windows XP, and mingw.org's MinGW headers by default define
5303         _WIN32_WINNT to 0x500.
5304
5305 2019-03-01  Gary Benson <gbenson@redhat.com>
5306
5307         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5308
5309 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5310             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5311
5312         PR gdb/8527
5313         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5314         set_sigint_trap, clear_sigint_trap.
5315
5316 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5317
5318         * target.c (target_detach): Clear the regcache and the
5319         frame cache.
5320
5321 2019-02-27  Pedro Alves  <palves@redhat.com>
5322
5323         * utils.c (set_screen_size): When we cap the height/width sizes,
5324         tweak the corresponding command variable to show "unlimited":
5325
5326 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5327             Pedro Alves  <palves@redhat.com>
5328
5329         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5330         before calling rl_set_screen_size.
5331
5332 2019-02-27  Tom Tromey  <tromey@adacore.com>
5333
5334         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5335         define.
5336         * python/py-value.c: Remove Python 2.4 workaround.
5337         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5338         workaround.
5339         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5340         Python 2.4 workaround.
5341         * python/python-internal.h: Remove Python 2.4 comment.
5342         (Py_ssize_t): Don't define.
5343         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5344         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5345         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5346         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5347         * python/python.c (do_start_initialization): Remove Python 2.4
5348         workaround.
5349         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5350         (print_children): Remove Python 2.4 workaround.
5351         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5352         workaround.
5353         (CHARBUFFERPROC_NAME): Remove.
5354         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5355         Python 2.4 workaround.
5356
5357 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5358
5359         * NEWS: Note minimum Python version.
5360
5361 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5362
5363         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5364         code from these functions.  Remove corresponding ifdefs.  Use
5365         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5366         Remove gotos and target of gotos.
5367         (infpy_search_memory): Likewise.
5368
5369 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5370
5371         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5372         (hppa_gdbarch_init): Don't register deleted functions with
5373         gdbarch.
5374
5375 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5378         (h8300_unwind_sp): Delete.
5379         (h8300_dummy_id): Delete.
5380         (h8300_gdbarch_init): Don't register deleted functions with
5381         gdbarch.
5382
5383 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5384
5385         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5386         (ft32_unwind_pc): Delete.
5387         (ft32_unwind_sp): Delete.
5388         (ft32_gdbarch_init): Don't register deleted functions with
5389         gdbarch.
5390
5391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5392
5393         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5394         (frv_unwind_pc): Delete.
5395         (frv_unwind_sp): Delete.
5396         (frv_gdbarch_init): Don't register deleted functions with
5397         gdbarch.
5398
5399 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5402         (riscv_unwind_pc): Delete.
5403         (riscv_unwind_sp): Delete.
5404         (riscv_gdbarch_init): Don't register deleted functions with
5405         gdbarch.
5406
5407 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5408
5409         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5410         (csky_unwind_pc): Delete.
5411         (csky_unwind_sp): Delete.
5412         (csky_gdbarch_init): Don't register deleted functions with
5413         gdbarch.
5414
5415 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5416
5417         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5418         (cris_unwind_pc): Delete.
5419         (cris_unwind_sp): Delete.
5420         (cris_gdbarch_init): Don't register deleted functions with
5421         gdbarch.
5422
5423 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5424
5425         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5426         (bfin_unwind_pc): Delete.
5427         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5428
5429 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5430
5431         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5432         (arm_unwind_pc): Delete.
5433         (arm_unwind_sp): Delete.
5434         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5435
5436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5437
5438         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5439         (arc_unwind_pc): Delete.
5440         (arc_unwind_sp): Delete.
5441         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5442
5443 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5444
5445         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5446         (alpha_unwind_pc): Delete.
5447         (alpha_gdbarch_init): Don't register deleted functions with
5448         gdbarch.
5449
5450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5451
5452         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5453         (aarch64_unwind_pc): Delete.
5454         (aarch64_unwind_sp): Delete.
5455         (aarch64_gdbarch_init): Don't register deleted functions with
5456         gdbarch.
5457
5458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5459
5460         * gdbtypes.c (type_align): Don't consider static members when
5461         computing structure alignment.
5462
5463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5466         return 0 for other types.
5467         * arch-utils.c (default_type_align): Always return 0.
5468         * gdbarch.h: Regenerate.
5469         * gdbarch.sh (type_align): Extend comment.
5470         * gdbtypes.c (type_align): Add additional comments, always call
5471         gdbarch_type_align before applying the default rules.
5472         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5473         generic code will then apply a suitable default.
5474         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5475         types, return 0 for other types.
5476
5477 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5478
5479         * NEWS: Create a new section for the next release branch.
5480         Rename the section of the current branch, now that it has
5481         been cut.
5482
5483 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5484
5485         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5486         * version.in: Bump version to 8.3.50.DATE-git.
5487
5488 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5489
5490         * aix-thread.c (ptid_cmp): Remove unused variable.
5491         (get_signaled_thread): Likewise.
5492         (store_regs_user_thread): Likewise.
5493         (store_regs_kernel_thread): Likewise.
5494         (fetch_regs_kernel_thread): Remove shadowed variable.
5495
5496 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5497
5498         * features/riscv/32bit-cpu.xml: Add register numbers.
5499         * features/riscv/32bit-fpu.c: Regenerate.
5500         * features/riscv/32bit-fpu.xml: Add register numbers.
5501         * features/riscv/64bit-cpu.xml: Add register numbers.
5502         * features/riscv/64bit-fpu.c: Regenerate.
5503         * features/riscv/64bit-fpu.xml: Add register numbers.
5504
5505 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5506
5507         * NEWS: Mention two argument form of gdb.Value constructor.
5508         * python/py-value.c (convert_buffer_and_type_to_value): New
5509         function.
5510         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5511         Add support for handling an optional second argument.  Call
5512         convert_buffer_and_type_to_value as appropriate.
5513         * python/python-internal.h (Py_buffer_deleter): New struct.
5514         (Py_buffer_up): New typedef.
5515
5516 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5517
5518         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5519         instead of releasing ownership.
5520
5521 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5522
5523         * dwarf2read.c (open_and_init_dwp_file): Call
5524         elf_numsections instead of bfd_count_sections to initialize
5525         dwp_file->num_sections.
5526
5527 2019-02-25  Tom Tromey  <tromey@adacore.com>
5528
5529         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5530
5531 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5532
5533         * gcore.in: Add '--readnever' option when invoking GDB.
5534
5535 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5536
5537         * MAINTAINERS: Update my email address.
5538
5539 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5540
5541         * build-id.c (build_id_to_debug_bfd_1): New function.
5542         (build_id_to_debug_bfd): Look for separate debug file in
5543         sysroot.
5544
5545 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5546
5547         * gdbarch.sh: Update the copyright year range that is placed into
5548         generated files.
5549
5550 2019-02-22  Keith Seitz  <keiths@redhat.com>
5551
5552         PR symtab/23853
5553         * linespec.c (create_sals_line_offset): Search for the default
5554         symtab's filename instead of its fullname.
5555
5556 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5557
5558         * NEWS: Update style defaults.
5559
5560 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5561
5562         * main.c (captured_main_1): Disable styling in batch mode.
5563
5564 2019-02-20  Tom Tromey  <tom@tromey.com>
5565
5566         * symtab.c (symtab_symbol_info): Fix typos.
5567
5568 2019-02-20  Tom Tromey  <tromey@adacore.com>
5569
5570         * findcmd.c (_initialize_mem_search): Use upper case for
5571         metasyntactic variables.
5572
5573 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5574
5575         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5576         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5577
5578 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5579
5580         * top.h (source_file_name): Change to std::string.
5581         * top.c (source_file_name): Likewise.
5582         (command_line_input): Adjust.
5583         * cli/cli-script.c (script_from_file): Adjust.
5584
5585 2019-02-19  Tom Tromey  <tromey@adacore.com>
5586
5587         * ravenscar-thread.c
5588         (ravenscar_thread_target::update_thread_list): Don't call
5589         ada_build_task_list.
5590         * ada-lang.h (ada_build_task_list): Don't declare.
5591         * ada-tasks.c (struct ada_tasks_inferior_data)
5592         <task_list_valid_p>: Now bool.
5593         (read_known_tasks, ada_task_list_changed)
5594         (ada_tasks_invalidate_inferior_data): Update.
5595         (read_known_tasks_array): Return bool.
5596         (read_known_tasks_list): Likewise.
5597         (read_known_tasks): Return void.
5598         (ada_build_task_list): Now static.
5599
5600 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5601
5602         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5603         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5604
5605 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5606
5607         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5608         variant for ada_tasks_pspace_data_handle and
5609         ada_tasks_inferior_data_handle.
5610         (ada_tasks_pspace_data_cleanup): New function.
5611         (ada_tasks_inferior_data_cleanup): New function.
5612
5613 2019-02-17  Tom Tromey  <tom@tromey.com>
5614
5615         * macrotab.h (macro_source_fullname): Return a std::string.
5616         * macrotab.c (macro_include, check_for_redefinition)
5617         (macro_undef, macro_lookup_definition, foreach_macro)
5618         (foreach_macro_in_scope): Update.
5619         (macro_source_fullname): Return a std::string.
5620         * macrocmd.c (show_pp_source_pos): Update.
5621
5622 2019-02-17  Tom Tromey  <tom@tromey.com>
5623
5624         * macrocmd.c (show_pp_source_pos): Style the file names.
5625
5626 2019-02-17  Tom Tromey  <tom@tromey.com>
5627
5628         PR tui/24197:
5629         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5630
5631 2019-02-17  Tom Tromey  <tom@tromey.com>
5632
5633         * ada-lang.c (user_select_syms): Use filtered printing.
5634         * utils.c (wrap_style): New global.
5635         (desired_style): Remove.
5636         (emit_style_escape): Add stream parameter.
5637         (set_output_style, reset_terminal_style, prompt_for_continue):
5638         Update.
5639         (flush_wrap_buffer): Only flush gdb_stdout.
5640         (wrap_here): Set wrap_style.
5641         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5642         treat escape sequences as a character.  Change when wrap buffer is
5643         flushed.
5644         (fputs_styled): Do not set the output style when the default is
5645         requested.
5646         * ui-style.h (struct ui_file_style) <is_default>: New method.
5647         * source.c (print_source_lines_base): Emit escape sequences in one
5648         piece.
5649
5650 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5651
5652         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5653         integers and enumeration types.
5654
5655 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5656
5657         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5658         instead of lookup_symbol_in_language
5659         (do_exact_match): New function.
5660         (ada_get_symbol_name_matcher): Return do_exact_match when
5661         doing a verbatim match.
5662
5663 2019-02-15  Tom Tromey  <tromey@adacore.com>
5664
5665         * ravenscar-thread.c (ravenscar_thread_target::resume)
5666         (ravenscar_thread_target::wait): Special case wildcard requests.
5667
5668 2019-02-15  Tom Tromey  <tromey@adacore.com>
5669
5670         * ravenscar-thread.c (base_ptid): Remove.
5671         (struct ravenscar_thread_target) <close>: New method.
5672         <m_base_ptid>: New member.
5673         <update_inferior_ptid, active_task, task_is_currently_active,
5674         runtime_initialized>: Declare methods.
5675         <ravenscar_thread_target>: Add constructor.
5676         (ravenscar_thread_target::task_is_currently_active)
5677         (ravenscar_thread_target::update_inferior_ptid)
5678         (ravenscar_runtime_initialized): Rename.  Now methods.
5679         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5680         (ravenscar_thread_target::update_thread_list): Update.
5681         (ravenscar_thread_target::active_task): Now method.
5682         (ravenscar_thread_target::store_registers)
5683         (ravenscar_thread_target::prepare_to_store)
5684         (ravenscar_thread_target::prepare_to_store)
5685         (ravenscar_thread_target::mourn_inferior): Update.
5686         (ravenscar_inferior_created): Use "new" to create target.
5687         (ravenscar_thread_target::get_ada_task_ptid): Update.
5688         (_initialize_ravenscar): Don't initialize base_ptid.
5689         (ravenscar_ops): Remove global.
5690
5691 2019-02-15  Tom Tromey  <tromey@adacore.com>
5692
5693         * target.h (push_target): Declare new overload.
5694         * target.c (push_target): New overload, taking an rvalue reference.
5695         * remote.c (remote_target::open_1): Use push_target overload.
5696         * corelow.c (core_target_open): Use push_target overload.
5697
5698 2019-02-15  Tom Tromey  <tromey@adacore.com>
5699
5700         * ravenscar-thread.c (is_ravenscar_task)
5701         (ravenscar_task_is_currently_active): Return bool.
5702         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5703         (_initialize_ravenscar): Remove "(void)".
5704         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5705         Return bool.
5706
5707 2019-02-15  Tom Tromey  <tromey@adacore.com>
5708
5709         * ravenscar-thread.c (ravenscar_runtime_initializer)
5710         (has_ravenscar_runtime, get_running_thread_id)
5711         (ravenscar_thread_target::resume): Fix indentation.
5712
5713 2019-02-15  Tom Tromey  <tromey@adacore.com>
5714
5715         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5716         from ravenscar_arch_ops.
5717         (sparc_ravenscar_ops::fetch_registers)
5718         (sparc_ravenscar_ops::store_registers): Now methods.
5719         (sparc_ravenscar_prepare_to_store): Remove.
5720         (sparc_ravenscar_ops): Redefine.
5721         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5722         methods and destructor.  Remove members.
5723         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5724         (ravenscar_thread_target::store_registers)
5725         (ravenscar_thread_target::prepare_to_store): Update.
5726         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5727         Remove.
5728         (struct ppc_ravenscar_powerpc_ops): Derive from
5729         ravenscar_arch_ops.
5730         (ppc_ravenscar_powerpc_ops::fetch_registers)
5731         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5732         (ppc_ravenscar_powerpc_ops): Redefine.
5733         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5734         (ppc_ravenscar_e500_ops::fetch_registers)
5735         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5736         (ppc_ravenscar_e500_ops): Redefine.
5737         * aarch64-ravenscar-thread.c
5738         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5739         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5740         (aarch64_ravenscar_fetch_registers)
5741         (aarch64_ravenscar_store_registers): Now methods.
5742         (aarch64_ravenscar_ops): Redefine.
5743
5744 2019-02-15  Tom Tromey  <tromey@adacore.com>
5745
5746         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5747         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5748         (ravenscar_thread_target::stopped_by_watchpoint)
5749         (ravenscar_thread_target::stopped_data_address)
5750         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5751
5752 2019-02-15  Tom Tromey  <tromey@adacore.com>
5753
5754         * ravenscar-thread.c: Fix some typos.
5755
5756 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5757             Tom Tromey  <tromey@adacore.com>
5758
5759         * ada-lang.c (ada_exception_sal): Change addr_string to a
5760         std::string.
5761         (create_ada_exception_catchpoint): Update.
5762
5763 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5764             Tom Tromey  <tromey@adacore.com>
5765
5766         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5767         (bp_location_ops): Remove.
5768         (base_breakpoint_allocate_location): Update.
5769         (free_bp_location): Update.
5770         * ada-lang.c (class ada_catchpoint_location)
5771         <ada_catchpoint_location>: Remove ops parameter.
5772         (ada_catchpoint_location_dtor): Remove.
5773         (ada_catchpoint_location_ops): Remove.
5774         (allocate_location_exception): Update.
5775         * breakpoint.h (struct bp_location_ops): Remove.
5776         (class bp_location) <bp_location>: Remove bp_location_ops
5777         parameter.
5778         <~bp_location>: Add destructor.
5779         <ops>: Remove.
5780
5781 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5782             Pedro Alves  <palves@redhat.com>
5783
5784         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5785         'PATH_MAX'.
5786
5787 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5788             Samuel Thibault  <samuel.thibault@gnu.org>
5789             Thomas Schwinge  <thomas@codesourcery.com>
5790
5791         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5792         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5793
5794 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5795
5796         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5797         (check_empty): Use "const char *".
5798
5799         * gnu-nat.c (gnu_nat_target::detach): Instead of
5800         'detach_inferior (pid)' call
5801         'detach_inferior (find_inferior_pid (pid))'.
5802
5803         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5804         'nat/fork-inferior.o'.
5805         * gnu-nat.c: #include "nat/fork-inferior.h".
5806
5807         * gnu-nat.c (gnu_nat_target::detach): Instead of
5808         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5809         * gnu-nat.h: #include "inf-child.h".
5810         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5811         'i386_gnu_nat_target::fetch_registers'.
5812         (gnu_store_registers): Rename/move to
5813         'i386_gnu_nat_target::store_registers'.
5814
5815         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5816         * gnu-nat.h (mach_thread_info): New function.
5817         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5818
5819         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5820
5821 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5822
5823         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5824
5825 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5826
5827         * windows-nat.c (windows_add_thread): Add new parameter
5828         "main_thread_p" with default value set to false.  Update
5829         function documentation as well as all callers.
5830         (windows_delete_thread): Likewise.
5831         (fake_create_process): Update call to windows_add_thread.
5832         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5833         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5834         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5835         call to windows_delete_thread.
5836
5837 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5838
5839         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5840
5841 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5842
5843         * symfile.c (find_separate_debug_file): Use canonical path of
5844         sysroot with child_path instead of gdb_sysroot if it is valid.
5845
5846 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5847
5848         * symfile.c (find_separate_debug_file): Use child_path to
5849         determine if an object file is under a sysroot.
5850
5851 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5852
5853         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5854         unittests/child-path-selftests.c.
5855         * common/pathstuff.c (child_path): New function.
5856         * common/pathstuff.h (child_path): New prototype.
5857         * unittests/child-path-selftests.c: New file.
5858
5859 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5860
5861         * symfile.c (find_separate_debug_file): Look for separate debug
5862         files in debug directories under the sysroot.
5863
5864 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5865
5866         * symtab.h (struct minimal_symbol data_p): New const method.
5867         (struct minimal_symbol text_p): Likewise.
5868         * symtab.c (output_source_filename): Use file name style
5869         to print file name.
5870         (print_symbol_info): Likewise.
5871         (print_msymbol_info): Use address style to print addresses.
5872         Use function name style to print executable text symbols.
5873         (expand_symtab_containing_pc): Use data_p.
5874         (find_pc_sect_compunit_symtab): Likewise.
5875
5876 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5877
5878         * breakpoint.c (describe_other_breakpoints): Use address style
5879         to print addresses.
5880         (say_where): Likewise.
5881
5882 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5883
5884         * ada-typeprint.c (print_func_type): Print function name
5885         style to print function name.
5886         * c-typeprint.c (c_print_type_1): Likewise.
5887
5888 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5889
5890         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5891         for execve.
5892
5893 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5894
5895         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5896         type_stack.
5897
5898 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5899
5900         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5901         TYPE_CODE_REF types.
5902
5903 2019-02-08  Jim Wilson  <jimw@sifive.com>
5904
5905         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5906         (riscv_linux_fregset): New.
5907         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5908
5909 2019-02-07  Tom Tromey  <tom@tromey.com>
5910
5911         * thread.c (thread_cancel_execution_command): Update.
5912         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5913         methods.
5914         (struct thread_fsm_ops): Remove.
5915         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5916         (thread_fsm_should_stop, thread_fsm_return_value)
5917         (thread_fsm_set_finished, thread_fsm_finished_p)
5918         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5919         Don't declare.
5920         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5921         * infrun.c (clear_proceed_status_thread)
5922         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5923         (print_stop_event): Update.
5924         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5925         Add constructor.
5926         (step_command_fsm_ops): Remove.
5927         (new_step_command_fsm): Remove.
5928         (step_1): Update.
5929         (step_command_fsm::should_stop): Rename from
5930         step_command_fsm_should_stop.
5931         (step_command_fsm::clean_up): Rename from
5932         step_command_fsm_clean_up.
5933         (step_command_fsm::do_async_reply_reason): Rename from
5934         step_command_fsm_async_reply_reason.
5935         (struct until_next_fsm): Inherit from thread_fsm.  Add
5936         constructor.
5937         (until_next_fsm_ops): Remove.
5938         (new_until_next_fsm): Remove.
5939         (until_next_fsm::should_stop): Rename from
5940         until_next_fsm_should_stop.
5941         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5942         (until_next_fsm::do_async_reply_reason): Rename from
5943         until_next_fsm_async_reply_reason.
5944         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5945         constructor.  Change type of breakpoint.
5946         (finish_command_fsm_ops): Remove.
5947         (new_finish_command_fsm): Remove.
5948         (finish_command_fsm::should_stop): Rename from
5949         finish_command_fsm_should_stop.
5950         (finish_command_fsm::clean_up): Rename from
5951         finish_command_fsm_clean_up.
5952         (finish_command_fsm::return_value): Rename from
5953         finish_command_fsm_return_value.
5954         (finish_command_fsm::do_async_reply_reason): Rename from
5955         finish_command_fsm_async_reply_reason.
5956         (finish_command): Update.
5957         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5958         Add constructor.
5959         (call_thread_fsm_ops): Remove.
5960         (call_thread_fsm::call_thread_fsm): Rename from
5961         new_call_thread_fsm.
5962         (call_thread_fsm::should_stop): Rename from
5963         call_thread_fsm_should_stop.
5964         (call_thread_fsm::should_notify_stop): Rename from
5965         call_thread_fsm_should_notify_stop.
5966         (run_inferior_call, call_function_by_hand_dummy): Update.
5967         * cli/cli-interp.c (should_print_stop_to_console): Update.
5968         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5969         Add constructor.  Change type of location_breakpoint,
5970         caller_breakpoint.
5971         (until_break_fsm_ops): Remove.
5972         (new_until_break_fsm): Remove.
5973         (until_break_fsm::should_stop): Rename from
5974         until_break_fsm_should_stop.
5975         (until_break_fsm::clean_up): Rename from
5976         until_break_fsm_clean_up.
5977         (until_break_fsm::do_async_reply_reason): Rename from
5978         until_break_fsm_async_reply_reason.
5979         (until_break_command): Update.
5980         * thread-fsm.c: Remove.
5981         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5982
5983 2019-02-07  Tom Tromey  <tom@tromey.com>
5984
5985         * yy-remap.h: Add include guard.
5986         * xtensa-tdep.h: Add include guard.
5987         * xcoffread.h: Rename include guard.
5988         * varobj-iter.h: Add include guard.
5989         * tui/tui.h: Rename include guard.
5990         * tui/tui-winsource.h: Rename include guard.
5991         * tui/tui-wingeneral.h: Rename include guard.
5992         * tui/tui-windata.h: Rename include guard.
5993         * tui/tui-win.h: Rename include guard.
5994         * tui/tui-stack.h: Rename include guard.
5995         * tui/tui-source.h: Rename include guard.
5996         * tui/tui-regs.h: Rename include guard.
5997         * tui/tui-out.h: Rename include guard.
5998         * tui/tui-layout.h: Rename include guard.
5999         * tui/tui-io.h: Rename include guard.
6000         * tui/tui-hooks.h: Rename include guard.
6001         * tui/tui-file.h: Rename include guard.
6002         * tui/tui-disasm.h: Rename include guard.
6003         * tui/tui-data.h: Rename include guard.
6004         * tui/tui-command.h: Rename include guard.
6005         * tic6x-tdep.h: Add include guard.
6006         * target/waitstatus.h: Rename include guard.
6007         * target/wait.h: Rename include guard.
6008         * target/target.h: Rename include guard.
6009         * target/resume.h: Rename include guard.
6010         * target-float.h: Rename include guard.
6011         * stabsread.h: Add include guard.
6012         * rs6000-tdep.h: Add include guard.
6013         * riscv-fbsd-tdep.h: Add include guard.
6014         * regformats/regdef.h: Rename include guard.
6015         * record.h: Rename include guard.
6016         * python/python.h: Rename include guard.
6017         * python/python-internal.h: Rename include guard.
6018         * python/py-stopevent.h: Rename include guard.
6019         * python/py-ref.h: Rename include guard.
6020         * python/py-record.h: Rename include guard.
6021         * python/py-record-full.h: Rename include guard.
6022         * python/py-record-btrace.h: Rename include guard.
6023         * python/py-instruction.h: Rename include guard.
6024         * python/py-events.h: Rename include guard.
6025         * python/py-event.h: Rename include guard.
6026         * procfs.h: Add include guard.
6027         * proc-utils.h: Add include guard.
6028         * p-lang.h: Add include guard.
6029         * or1k-tdep.h: Rename include guard.
6030         * observable.h: Rename include guard.
6031         * nto-tdep.h: Rename include guard.
6032         * nat/x86-linux.h: Rename include guard.
6033         * nat/x86-linux-dregs.h: Rename include guard.
6034         * nat/x86-gcc-cpuid.h: Add include guard.
6035         * nat/x86-dregs.h: Rename include guard.
6036         * nat/x86-cpuid.h: Rename include guard.
6037         * nat/ppc-linux.h: Rename include guard.
6038         * nat/mips-linux-watch.h: Rename include guard.
6039         * nat/linux-waitpid.h: Rename include guard.
6040         * nat/linux-ptrace.h: Rename include guard.
6041         * nat/linux-procfs.h: Rename include guard.
6042         * nat/linux-osdata.h: Rename include guard.
6043         * nat/linux-nat.h: Rename include guard.
6044         * nat/linux-namespaces.h: Rename include guard.
6045         * nat/linux-btrace.h: Rename include guard.
6046         * nat/glibc_thread_db.h: Rename include guard.
6047         * nat/gdb_thread_db.h: Rename include guard.
6048         * nat/gdb_ptrace.h: Rename include guard.
6049         * nat/fork-inferior.h: Rename include guard.
6050         * nat/amd64-linux-siginfo.h: Rename include guard.
6051         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6052         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6053         * nat/aarch64-linux.h: Rename include guard.
6054         * nat/aarch64-linux-hw-point.h: Rename include guard.
6055         * mn10300-tdep.h: Add include guard.
6056         * mips-linux-tdep.h: Add include guard.
6057         * mi/mi-parse.h: Rename include guard.
6058         * mi/mi-out.h: Rename include guard.
6059         * mi/mi-main.h: Rename include guard.
6060         * mi/mi-interp.h: Rename include guard.
6061         * mi/mi-getopt.h: Rename include guard.
6062         * mi/mi-console.h: Rename include guard.
6063         * mi/mi-common.h: Rename include guard.
6064         * mi/mi-cmds.h: Rename include guard.
6065         * mi/mi-cmd-break.h: Rename include guard.
6066         * m2-lang.h: Add include guard.
6067         * location.h: Rename include guard.
6068         * linux-record.h: Rename include guard.
6069         * linux-nat.h: Add include guard.
6070         * linux-fork.h: Add include guard.
6071         * i386-darwin-tdep.h: Rename include guard.
6072         * hppa-linux-offsets.h: Add include guard.
6073         * guile/guile.h: Rename include guard.
6074         * guile/guile-internal.h: Rename include guard.
6075         * gnu-nat.h: Rename include guard.
6076         * gdb-stabs.h: Rename include guard.
6077         * frv-tdep.h: Add include guard.
6078         * f-lang.h: Add include guard.
6079         * event-loop.h: Add include guard.
6080         * darwin-nat.h: Rename include guard.
6081         * cp-abi.h: Rename include guard.
6082         * config/sparc/nm-sol2.h: Rename include guard.
6083         * config/nm-nto.h: Rename include guard.
6084         * config/nm-linux.h: Add include guard.
6085         * config/i386/nm-i386gnu.h: Rename include guard.
6086         * config/djgpp/nl_types.h: Rename include guard.
6087         * config/djgpp/langinfo.h: Rename include guard.
6088         * compile/gcc-cp-plugin.h: Add include guard.
6089         * compile/gcc-c-plugin.h: Add include guard.
6090         * compile/compile.h: Rename include guard.
6091         * compile/compile-object-run.h: Rename include guard.
6092         * compile/compile-object-load.h: Rename include guard.
6093         * compile/compile-internal.h: Rename include guard.
6094         * compile/compile-cplus.h: Rename include guard.
6095         * compile/compile-c.h: Rename include guard.
6096         * common/xml-utils.h: Rename include guard.
6097         * common/x86-xstate.h: Rename include guard.
6098         * common/version.h: Rename include guard.
6099         * common/vec.h: Rename include guard.
6100         * common/tdesc.h: Rename include guard.
6101         * common/selftest.h: Rename include guard.
6102         * common/scoped_restore.h: Rename include guard.
6103         * common/scoped_mmap.h: Rename include guard.
6104         * common/scoped_fd.h: Rename include guard.
6105         * common/safe-iterator.h: Rename include guard.
6106         * common/run-time-clock.h: Rename include guard.
6107         * common/refcounted-object.h: Rename include guard.
6108         * common/queue.h: Rename include guard.
6109         * common/ptid.h: Rename include guard.
6110         * common/print-utils.h: Rename include guard.
6111         * common/preprocessor.h: Rename include guard.
6112         * common/pathstuff.h: Rename include guard.
6113         * common/observable.h: Rename include guard.
6114         * common/netstuff.h: Rename include guard.
6115         * common/job-control.h: Rename include guard.
6116         * common/host-defs.h: Rename include guard.
6117         * common/gdb_wait.h: Rename include guard.
6118         * common/gdb_vecs.h: Rename include guard.
6119         * common/gdb_unlinker.h: Rename include guard.
6120         * common/gdb_unique_ptr.h: Rename include guard.
6121         * common/gdb_tilde_expand.h: Rename include guard.
6122         * common/gdb_sys_time.h: Rename include guard.
6123         * common/gdb_string_view.h: Rename include guard.
6124         * common/gdb_splay_tree.h: Rename include guard.
6125         * common/gdb_setjmp.h: Rename include guard.
6126         * common/gdb_ref_ptr.h: Rename include guard.
6127         * common/gdb_optional.h: Rename include guard.
6128         * common/gdb_locale.h: Rename include guard.
6129         * common/gdb_assert.h: Rename include guard.
6130         * common/filtered-iterator.h: Rename include guard.
6131         * common/filestuff.h: Rename include guard.
6132         * common/fileio.h: Rename include guard.
6133         * common/environ.h: Rename include guard.
6134         * common/common-utils.h: Rename include guard.
6135         * common/common-types.h: Rename include guard.
6136         * common/common-regcache.h: Rename include guard.
6137         * common/common-inferior.h: Rename include guard.
6138         * common/common-gdbthread.h: Rename include guard.
6139         * common/common-exceptions.h: Rename include guard.
6140         * common/common-defs.h: Rename include guard.
6141         * common/common-debug.h: Rename include guard.
6142         * common/cleanups.h: Rename include guard.
6143         * common/buffer.h: Rename include guard.
6144         * common/btrace-common.h: Rename include guard.
6145         * common/break-common.h: Rename include guard.
6146         * cli/cli-utils.h: Rename include guard.
6147         * cli/cli-style.h: Rename include guard.
6148         * cli/cli-setshow.h: Rename include guard.
6149         * cli/cli-script.h: Rename include guard.
6150         * cli/cli-interp.h: Rename include guard.
6151         * cli/cli-decode.h: Rename include guard.
6152         * cli/cli-cmds.h: Rename include guard.
6153         * charset-list.h: Add include guard.
6154         * buildsym-legacy.h: Rename include guard.
6155         * bfin-tdep.h: Add include guard.
6156         * ax.h: Rename include guard.
6157         * arm-linux-tdep.h: Add include guard.
6158         * arm-fbsd-tdep.h: Add include guard.
6159         * arch/xtensa.h: Rename include guard.
6160         * arch/tic6x.h: Add include guard.
6161         * arch/i386.h: Add include guard.
6162         * arch/arm.h: Rename include guard.
6163         * arch/arm-linux.h: Rename include guard.
6164         * arch/arm-get-next-pcs.h: Rename include guard.
6165         * arch/amd64.h: Add include guard.
6166         * arch/aarch64-insn.h: Rename include guard.
6167         * arch-utils.h: Rename include guard.
6168         * annotate.h: Add include guard.
6169         * amd64-darwin-tdep.h: Rename include guard.
6170         * aarch64-linux-tdep.h: Add include guard.
6171         * aarch64-fbsd-tdep.h: Add include guard.
6172         * aarch32-linux-nat.h: Add include guard.
6173
6174 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6175
6176         * macrotab.c (macro_define_internal): New function that
6177         factorizes macro_define_object_internal and macro_define_function
6178         code.
6179         (macro_define_object_internal): Use macro_define_internal.
6180         (macro_define_function): Likewise.
6181
6182 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6183
6184         * macrocmd.c (extract_identifier): Return
6185         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6186         callers.
6187
6188 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6189
6190         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6191
6192 2019-02-05  Tom Tromey  <tom@tromey.com>
6193
6194         * target.c (target_stack::unpush): Move assertion earlier.
6195
6196 2019-01-30  Tom Tromey  <tom@tromey.com>
6197
6198         PR python/23615:
6199         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6200         (gdbpy_parse_and_eval): Likewise.
6201         * python/python-internal.h (gdbpy_allow_threads): New class.
6202
6203 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6204
6205         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6206         (aarch64_fbsd_fpregmap): Move earlier.
6207         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6208         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6209         instead of individual calls to trad_frame_set_reg_addr.
6210         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6211         earlier.
6212         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6213         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6214         instead of individual calls to trad_frame_set_reg_addr.
6215
6216 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6217
6218         * CONTRIBUTE: Replace contribution list with wiki link.
6219
6220 2019-01-25  Tom Tromey  <tom@tromey.com>
6221
6222         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6223
6224 2019-01-25  Tom Tromey  <tom@tromey.com>
6225
6226         * xtensa-linux-nat.c: Fix common/ includes.
6227         * xml-support.h: Fix common/ includes.
6228         * xml-support.c: Fix common/ includes.
6229         * x86-linux-nat.c: Fix common/ includes.
6230         * windows-nat.c: Fix common/ includes.
6231         * varobj.h: Fix common/ includes.
6232         * varobj.c: Fix common/ includes.
6233         * value.c: Fix common/ includes.
6234         * valops.c: Fix common/ includes.
6235         * utils.c: Fix common/ includes.
6236         * unittests/xml-utils-selftests.c: Fix common/ includes.
6237         * unittests/utils-selftests.c: Fix common/ includes.
6238         * unittests/unpack-selftests.c: Fix common/ includes.
6239         * unittests/tracepoint-selftests.c: Fix common/ includes.
6240         * unittests/style-selftests.c: Fix common/ includes.
6241         * unittests/string_view-selftests.c: Fix common/ includes.
6242         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6243         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6244         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6245         * unittests/rsp-low-selftests.c: Fix common/ includes.
6246         * unittests/parse-connection-spec-selftests.c: Fix common/
6247         includes.
6248         * unittests/optional-selftests.c: Fix common/ includes.
6249         * unittests/offset-type-selftests.c: Fix common/ includes.
6250         * unittests/observable-selftests.c: Fix common/ includes.
6251         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6252         * unittests/memrange-selftests.c: Fix common/ includes.
6253         * unittests/memory-map-selftests.c: Fix common/ includes.
6254         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6255         * unittests/function-view-selftests.c: Fix common/ includes.
6256         * unittests/environ-selftests.c: Fix common/ includes.
6257         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6258         * unittests/common-utils-selftests.c: Fix common/ includes.
6259         * unittests/cli-utils-selftests.c: Fix common/ includes.
6260         * unittests/array-view-selftests.c: Fix common/ includes.
6261         * ui-file.c: Fix common/ includes.
6262         * tui/tui-io.c: Fix common/ includes.
6263         * tracepoint.h: Fix common/ includes.
6264         * tracepoint.c: Fix common/ includes.
6265         * tracefile-tfile.c: Fix common/ includes.
6266         * top.h: Fix common/ includes.
6267         * top.c: Fix common/ includes.
6268         * thread.c: Fix common/ includes.
6269         * target/waitstatus.h: Fix common/ includes.
6270         * target/waitstatus.c: Fix common/ includes.
6271         * target.h: Fix common/ includes.
6272         * target.c: Fix common/ includes.
6273         * target-memory.c: Fix common/ includes.
6274         * target-descriptions.c: Fix common/ includes.
6275         * symtab.h: Fix common/ includes.
6276         * symfile.c: Fix common/ includes.
6277         * stap-probe.c: Fix common/ includes.
6278         * spu-linux-nat.c: Fix common/ includes.
6279         * sparc-nat.c: Fix common/ includes.
6280         * source.c: Fix common/ includes.
6281         * solib.c: Fix common/ includes.
6282         * solib-target.c: Fix common/ includes.
6283         * ser-unix.c: Fix common/ includes.
6284         * ser-tcp.c: Fix common/ includes.
6285         * ser-pipe.c: Fix common/ includes.
6286         * ser-base.c: Fix common/ includes.
6287         * selftest-arch.c: Fix common/ includes.
6288         * s12z-tdep.c: Fix common/ includes.
6289         * rust-exp.y: Fix common/ includes.
6290         * rs6000-aix-tdep.c: Fix common/ includes.
6291         * riscv-tdep.c: Fix common/ includes.
6292         * remote.c: Fix common/ includes.
6293         * remote-notif.h: Fix common/ includes.
6294         * remote-fileio.h: Fix common/ includes.
6295         * remote-fileio.c: Fix common/ includes.
6296         * regcache.h: Fix common/ includes.
6297         * regcache.c: Fix common/ includes.
6298         * record-btrace.c: Fix common/ includes.
6299         * python/python.c: Fix common/ includes.
6300         * python/py-type.c: Fix common/ includes.
6301         * python/py-inferior.c: Fix common/ includes.
6302         * progspace.h: Fix common/ includes.
6303         * producer.c: Fix common/ includes.
6304         * procfs.c: Fix common/ includes.
6305         * proc-api.c: Fix common/ includes.
6306         * printcmd.c: Fix common/ includes.
6307         * ppc-linux-nat.c: Fix common/ includes.
6308         * parser-defs.h: Fix common/ includes.
6309         * osdata.c: Fix common/ includes.
6310         * obsd-nat.c: Fix common/ includes.
6311         * nat/x86-linux.c: Fix common/ includes.
6312         * nat/x86-linux-dregs.c: Fix common/ includes.
6313         * nat/x86-dregs.h: Fix common/ includes.
6314         * nat/x86-dregs.c: Fix common/ includes.
6315         * nat/ppc-linux.c: Fix common/ includes.
6316         * nat/mips-linux-watch.h: Fix common/ includes.
6317         * nat/mips-linux-watch.c: Fix common/ includes.
6318         * nat/linux-waitpid.c: Fix common/ includes.
6319         * nat/linux-ptrace.h: Fix common/ includes.
6320         * nat/linux-ptrace.c: Fix common/ includes.
6321         * nat/linux-procfs.c: Fix common/ includes.
6322         * nat/linux-personality.c: Fix common/ includes.
6323         * nat/linux-osdata.c: Fix common/ includes.
6324         * nat/linux-namespaces.c: Fix common/ includes.
6325         * nat/linux-btrace.h: Fix common/ includes.
6326         * nat/linux-btrace.c: Fix common/ includes.
6327         * nat/fork-inferior.c: Fix common/ includes.
6328         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6329         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6330         * nat/aarch64-linux.c: Fix common/ includes.
6331         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6332         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6333         * namespace.h: Fix common/ includes.
6334         * mips-linux-tdep.c: Fix common/ includes.
6335         * minsyms.c: Fix common/ includes.
6336         * mi/mi-parse.h: Fix common/ includes.
6337         * mi/mi-main.c: Fix common/ includes.
6338         * mi/mi-cmd-env.c: Fix common/ includes.
6339         * memrange.h: Fix common/ includes.
6340         * memattr.c: Fix common/ includes.
6341         * maint.h: Fix common/ includes.
6342         * maint.c: Fix common/ includes.
6343         * main.c: Fix common/ includes.
6344         * machoread.c: Fix common/ includes.
6345         * location.c: Fix common/ includes.
6346         * linux-thread-db.c: Fix common/ includes.
6347         * linux-nat.c: Fix common/ includes.
6348         * linux-fork.c: Fix common/ includes.
6349         * inline-frame.c: Fix common/ includes.
6350         * infrun.c: Fix common/ includes.
6351         * inflow.c: Fix common/ includes.
6352         * inferior.h: Fix common/ includes.
6353         * inferior.c: Fix common/ includes.
6354         * infcmd.c: Fix common/ includes.
6355         * inf-ptrace.c: Fix common/ includes.
6356         * inf-child.c: Fix common/ includes.
6357         * ia64-linux-nat.c: Fix common/ includes.
6358         * i387-tdep.c: Fix common/ includes.
6359         * i386-tdep.c: Fix common/ includes.
6360         * i386-linux-tdep.c: Fix common/ includes.
6361         * i386-linux-nat.c: Fix common/ includes.
6362         * i386-go32-tdep.c: Fix common/ includes.
6363         * i386-fbsd-tdep.c: Fix common/ includes.
6364         * i386-fbsd-nat.c: Fix common/ includes.
6365         * guile/scm-type.c: Fix common/ includes.
6366         * guile/guile.c: Fix common/ includes.
6367         * go32-nat.c: Fix common/ includes.
6368         * gnu-nat.c: Fix common/ includes.
6369         * gdbthread.h: Fix common/ includes.
6370         * gdbarch-selftests.c: Fix common/ includes.
6371         * gdb_usleep.c: Fix common/ includes.
6372         * gdb_select.h: Fix common/ includes.
6373         * gdb_bfd.c: Fix common/ includes.
6374         * gcore.c: Fix common/ includes.
6375         * fork-child.c: Fix common/ includes.
6376         * findvar.c: Fix common/ includes.
6377         * fbsd-nat.c: Fix common/ includes.
6378         * event-top.c: Fix common/ includes.
6379         * event-loop.c: Fix common/ includes.
6380         * dwarf2read.c: Fix common/ includes.
6381         * dwarf2loc.c: Fix common/ includes.
6382         * dwarf2-frame.c: Fix common/ includes.
6383         * dwarf-index-cache.c: Fix common/ includes.
6384         * dtrace-probe.c: Fix common/ includes.
6385         * disasm-selftests.c: Fix common/ includes.
6386         * defs.h: Fix common/ includes.
6387         * csky-tdep.c: Fix common/ includes.
6388         * cp-valprint.c: Fix common/ includes.
6389         * cp-support.h: Fix common/ includes.
6390         * cp-support.c: Fix common/ includes.
6391         * corelow.c: Fix common/ includes.
6392         * completer.h: Fix common/ includes.
6393         * completer.c: Fix common/ includes.
6394         * compile/compile.c: Fix common/ includes.
6395         * compile/compile-loc2c.c: Fix common/ includes.
6396         * compile/compile-cplus-types.c: Fix common/ includes.
6397         * compile/compile-cplus-symbols.c: Fix common/ includes.
6398         * command.h: Fix common/ includes.
6399         * cli/cli-dump.c: Fix common/ includes.
6400         * cli/cli-cmds.c: Fix common/ includes.
6401         * charset.c: Fix common/ includes.
6402         * build-id.c: Fix common/ includes.
6403         * btrace.h: Fix common/ includes.
6404         * btrace.c: Fix common/ includes.
6405         * breakpoint.h: Fix common/ includes.
6406         * breakpoint.c: Fix common/ includes.
6407         * ax.h:
6408         (enum agent_op): Fix common/ includes.
6409         * ax-general.c (struct aop_map): Fix common/ includes.
6410         * ax-gdb.c: Fix common/ includes.
6411         * auxv.c: Fix common/ includes.
6412         * auto-load.c: Fix common/ includes.
6413         * arm-tdep.c: Fix common/ includes.
6414         * arch/riscv.c: Fix common/ includes.
6415         * arch/ppc-linux-common.c: Fix common/ includes.
6416         * arch/i386.c: Fix common/ includes.
6417         * arch/arm.c: Fix common/ includes.
6418         * arch/arm-linux.c: Fix common/ includes.
6419         * arch/arm-get-next-pcs.c: Fix common/ includes.
6420         * arch/amd64.c: Fix common/ includes.
6421         * arch/aarch64.c: Fix common/ includes.
6422         * arch/aarch64-insn.c: Fix common/ includes.
6423         * arch-utils.c: Fix common/ includes.
6424         * amd64-windows-tdep.c: Fix common/ includes.
6425         * amd64-tdep.c: Fix common/ includes.
6426         * amd64-sol2-tdep.c: Fix common/ includes.
6427         * amd64-obsd-tdep.c: Fix common/ includes.
6428         * amd64-nbsd-tdep.c: Fix common/ includes.
6429         * amd64-linux-tdep.c: Fix common/ includes.
6430         * amd64-linux-nat.c: Fix common/ includes.
6431         * amd64-fbsd-tdep.c: Fix common/ includes.
6432         * amd64-fbsd-nat.c: Fix common/ includes.
6433         * amd64-dicos-tdep.c: Fix common/ includes.
6434         * amd64-darwin-tdep.c: Fix common/ includes.
6435         * agent.c: Fix common/ includes.
6436         * ada-lang.h: Fix common/ includes.
6437         * ada-lang.c: Fix common/ includes.
6438         * aarch64-tdep.c: Fix common/ includes.
6439
6440 2019-01-25  Tom Tromey  <tom@tromey.com>
6441
6442         * common/create-version.sh: Use common/version.h.
6443
6444 2019-01-24  Pedro Alves  <palves@redhat.com>
6445
6446         * infrun.c (signal_stop, signal_print, signal_program)
6447         (signal_catch, signal_pass): Now arrays instead of pointers.
6448         (update_signals_program_target, do_target_resume)
6449         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6450         * linux-nat.c (linux_nat_target::pass_signals)
6451         (linux_nat_target::create_inferior, linux_nat_target::attach):
6452         Adjust.
6453         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6454         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6455         * procfs.c (procfs_target::pass_signals): Adjust.
6456         * record-full.c (record_full_target::resume): Adjust.
6457         * remote.c (remote_target::pass_signals)
6458         (remote_target::program_signals): Adjust.
6459         * target-debug.h (target_debug_print_signals): Now takes a
6460         gdb::array_view as parameter.  Adjust.
6461         * target.h (target_ops) <pass_signals, program_signals>: Replace
6462         pointer and length parameters with gdb::array_view.
6463         (target_pass_signals, target_program_signals): Likewise.
6464         * target-delegates.c: Regenerate.
6465
6466 2019-01-24  Pedro Alves  <palves@redhat.com>
6467
6468         * common/forward-scope-exit.h
6469         (forward_scope_exit::forward_scope_exit): Pass arguments to
6470         m_bind_function directly, instead of creating a std::bind and
6471         copying that.
6472
6473 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6474
6475         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6476         for static members.
6477         (pass_in_v_vfp_candidate): Likewise.
6478
6479 2019-01-23  Tom Tromey  <tom@tromey.com>
6480             Pedro Alves  <palves@redhat.com>
6481
6482         * regcache.c (class regcache_invalidator): Remove.
6483         (regcache::raw_write): Use make_scope_exit.
6484
6485 2019-01-23  Tom Tromey  <tom@tromey.com>
6486
6487         * ui-out.h (class ui_out_emit_type): Update comment.
6488
6489 2019-01-23  Tom Tromey  <tom@tromey.com>
6490
6491         * infrun.c (fetch_inferior_event): Update comment.
6492
6493 2019-01-23  Tom Tromey  <tom@tromey.com>
6494             Pedro Alves  <palves@redhat.com>
6495
6496         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6497         parameter.
6498         (fetch_inferior_event): Use SCOPE_EXIT.
6499
6500
6501 2019-01-23  Tom Tromey  <tom@tromey.com>
6502             Pedro Alves  <palves@redhat.com>
6503
6504         * infrun.c (disable_thread_events): Delete.
6505         (stop_all_threads): Use SCOPE_EXIT.
6506
6507 2019-01-23  Tom Tromey  <tom@tromey.com>
6508             Pedro Alves  <palves@redhat.com>
6509
6510         * symfile.c: Include forward-scope-exit.h.
6511         (clear_symtab_users_cleanup): Replace forward declaration with
6512         a FORWARD_SCOPE_EXIT.
6513         (syms_from_objfile_1): Use the forward_scope_exit and
6514         gdb::optional instead of cleanup_function.
6515         (reread_symbols): Use the forward_scope_exit instead of
6516         cleanup_function.
6517         (clear_symtab_users_cleanup): Remove function.
6518
6519 2019-01-23  Tom Tromey  <tom@tromey.com>
6520             Pedro Alves  <palves@redhat.com>
6521
6522         * linux-nat.c: Include scope-exit.h.
6523         (cleanup_target_stop): Remove.
6524         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6525         SCOPE_EXIT.
6526
6527 2019-01-23  Tom Tromey  <tom@tromey.com>
6528             Pedro Alves  <palves@redhat.com>
6529
6530         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6531         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6532
6533 2019-01-23  Tom Tromey  <tom@tromey.com>
6534             Andrew Burgess  <andrew.burgess@embecosm.com>
6535             Pedro Alves  <palves@redhat.com>
6536
6537         * infrun.c (fetch_inferior_event): Use scope_exit.
6538         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6539         * top.c (execute_command): Use scope_exit.
6540         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6541         * utils.c (do_bpstat_clear_actions_cleanup)
6542         (make_bpstat_clear_actions_cleanup): Remove.
6543
6544 2019-01-23  Tom Tromey  <tom@tromey.com>
6545             Pedro Alves  <palves@redhat.com>
6546
6547         * infrun.c: Include "common/scope-exit.h"
6548         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6549         (wait_for_inferior): Use SCOPE_EXIT.
6550         (fetch_inferior_event): Use scope_exit.
6551
6552 2019-01-23  Tom Tromey  <tom@tromey.com>
6553             Pedro Alves  <palves@redhat.com>
6554
6555         * breakpoint.c (create_breakpoint): Remove cleanup.
6556
6557 2019-01-23  Tom Tromey  <tom@tromey.com>
6558             Andrew Burgess  <andrew.burgess@embecosm.com>
6559             Pedro Alves  <palves@redhat.com>
6560
6561 2019-01-23  Pedro Alves  <palves@redhat.com>
6562
6563         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6564
6565 2019-01-23  Pedro Alves  <palves@redhat.com>
6566             Andrew Burgess  <andrew.burgess@embecosm.com>
6567
6568         * gdbthread.h: Include "common/forward-scope-exit.h".
6569         (scoped_finish_thread_state): Redefine custom class in terms of
6570         forward_scope_exit.
6571
6572 2019-01-23  Pedro Alves  <palves@redhat.com>
6573             Andrew Burgess  <andrew.burgess@embecosm.com>
6574
6575         * common/forward-scope-exit.h: New file.
6576
6577 2019-01-23  Pedro Alves  <palves@redhat.com>
6578             Andrew Burgess  <andrew.burgess@embecosm.com>
6579             Tom Tromey  <tom@tromey.com>
6580
6581         * common/scope-exit.h: New file.
6582
6583 2019-01-23  Pedro Alves  <palves@redhat.com>
6584
6585         * common/preprocessor.h (ESC): Rename to ...
6586         (ESC_PARENS): ... this.
6587         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6588         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6589
6590 2019-01-23  Tom Tromey  <tom@tromey.com>
6591
6592         * language.h (class scoped_switch_to_sym_language_if_auto):
6593         Initialize m_lang in both cases.
6594
6595 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6596
6597         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6598         with XCNEW.
6599
6600 2019-01-22  Tom Tromey  <tom@tromey.com>
6601
6602         * corelow.c: Do not include sys/file.h.
6603
6604 2019-01-22  Tom Tromey  <tom@tromey.com>
6605
6606         * tui/tui-wingeneral.h: Include gdb_curses.h.
6607
6608 2019-01-22  Tom Tromey  <tom@tromey.com>
6609
6610         * source-cache.h (class source_cache) <get_source_lines,
6611         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6612
6613 2019-01-22  Tom Tromey  <tom@tromey.com>
6614
6615         * remote-fileio.h (struct remote_target): Declare.
6616
6617 2019-01-22  Tom Tromey  <tom@tromey.com>
6618
6619         * python/py-arch.c: Do not include py-ref.h.
6620         * python/py-bpevent.c: Do not include py-ref.h.
6621         * python/py-cmd.c: Do not include py-ref.h.
6622         * python/py-continueevent.c: Do not include py-ref.h.
6623         * python/py-event.h: Do not include py-ref.h.
6624         * python/py-evtregistry.c: Do not include py-ref.h.
6625         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6626         * python/py-frame.c: Do not include py-ref.h.
6627         * python/py-framefilter.c: Do not include py-ref.h.
6628         * python/py-function.c: Do not include py-ref.h.
6629         * python/py-infevents.c: Do not include py-ref.h.
6630         * python/py-linetable.c: Do not include py-ref.h.
6631         * python/py-objfile.c: Do not include py-ref.h.
6632         * python/py-param.c: Do not include py-ref.h.
6633         * python/py-prettyprint.c: Do not include py-ref.h.
6634         * python/py-progspace.c: Do not include py-ref.h.
6635         * python/py-symbol.c: Do not include py-ref.h.
6636         * python/py-symtab.c: Do not include py-ref.h.
6637         * python/py-type.c: Do not include py-ref.h.
6638         * python/py-unwind.c: Do not include py-ref.h.
6639         * python/py-utils.c: Do not include py-ref.h.
6640         * python/py-value.c: Do not include py-ref.h.
6641         * python/py-varobj.c: Do not include py-ref.h.
6642         * python/py-xmethods.c: Do not include py-ref.h.
6643         * python/python.c: Do not include py-ref.h.
6644         * varobj.c: Do not include py-ref.h.
6645
6646 2019-01-22  Tom Tromey  <tom@tromey.com>
6647
6648         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6649         keyword for bcache.
6650
6651 2019-01-22  Tom Tromey  <tom@tromey.com>
6652
6653         * compile/compile-cplus-types.c: Remove a comment by #include.
6654
6655 2019-01-22  Tom Tromey  <tom@tromey.com>
6656
6657         * compile/gcc-c-plugin.h: Include compile-internal.h.
6658
6659 2019-01-22  Tom Tromey  <tom@tromey.com>
6660
6661         * stabsread.c (EXTERN): Do not define.
6662         (symnum, next_symbol_text_func, processing_gcc_compilation)
6663         (within_function, global_sym_chain, global_stabs)
6664         (previous_stab_code, this_object_header_files)
6665         (n_this_object_header_files)
6666         (n_allocated_this_object_header_files): Define.
6667         * stabsread.h (EXTERN): Never define.  Use "extern".
6668
6669 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6670
6671         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6672         history_value.
6673
6674 2019-01-21  Tom Tromey  <tom@tromey.com>
6675
6676         * ui-out.c: Fix includes.
6677         * tui/tui-source.c: Fix includes.
6678         * target.c: Fix includes.
6679         * remote.c: Fix includes.
6680         * regcache.c: Fix includes.
6681         * python/py-block.c: Fix includes.
6682         * printcmd.c: Fix includes.
6683         * or1k-tdep.c: Fix includes.
6684         * mi/mi-main.c: Fix includes.
6685         * m32r-tdep.c: Fix includes.
6686         * csky-tdep.c: Fix includes.
6687         * compile/compile-cplus-types.c: Fix includes.
6688         * cli/cli-interp.c: Fix includes.
6689
6690 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6691
6692         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6693         for padding.
6694
6695 2019-01-16  Tom Tromey  <tom@tromey.com>
6696
6697         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6698         earlier.
6699         (struct objfile) <msymbols_range>: Move from top level.
6700         <msymbols>: New method.
6701         (class objfile_msymbols): Remove.
6702         * symtab.c (default_collect_symbol_completion_matches_break_on):
6703         Update.
6704         * symmisc.c (dump_msymbols): Update.
6705         * stabsread.c (scan_file_globals): Update.
6706         * objc-lang.c (info_selectors_command, info_classes_command)
6707         (find_methods): Update.
6708         * minsyms.c (find_solib_trampoline_target): Update.
6709         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6710         * coffread.c (coff_symfile_read): Update.
6711         * ada-lang.c (ada_lookup_simple_minsym)
6712         (ada_collect_symbol_completion_matches): Update.
6713
6714 2019-01-16  Tom Tromey  <tom@tromey.com>
6715
6716         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6717         type.  Remove no-argument constructor.
6718         <iterator::operator++>: Simplify.
6719         <begin>: Update.
6720         <end>: Use minimal_symbol_count.
6721
6722 2019-01-16  Tom Tromey  <tom@tromey.com>
6723
6724         * objfiles.h (struct objfile) <psymtabs>: New method.
6725         (class objfile_psymtabs): Remove.
6726         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6727         typedef.
6728         <range>: New method.
6729         (require_partial_symbols): Change return type.
6730         * psymtab.c (require_partial_symbols)
6731         (psym_expand_symtabs_matching): Update.
6732         * mdebugread.c (parse_partial_symbols): Update.
6733         * dbxread.c (dbx_end_psymtab): Update.
6734
6735 2019-01-15  Tom Tromey  <tom@tromey.com>
6736
6737         * symtab.c (lookup_objfile_from_block)
6738         (lookup_symbol_in_objfile_symtabs)
6739         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6740         (find_line_symtab, info_sources_command)
6741         (default_collect_symbol_completion_matches_break_on)
6742         (make_source_files_completion_list): Update.
6743         * symmisc.c (print_objfile_statistics, dump_objfile)
6744         (maintenance_print_symbols, maintenance_info_symtabs)
6745         (maintenance_check_symtabs, maintenance_info_line_tables):
6746         Update.
6747         * source.c (select_source_symtab)
6748         (forget_cached_source_info_for_objfile): Update.
6749         * objfiles.h (class objfile_compunits): Remove.
6750         (struct objfile) <compunits_range>: New typedef.
6751         (compunits): New method.
6752         * objfiles.c (objfile_relocate1): Update.
6753         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6754         * maint.c (count_symtabs_and_blocks): Update.
6755         * linespec.c (iterate_over_all_matching_symtabs): Update.
6756         * cp-support.c (add_symbol_overload_list_qualified): Update.
6757         * coffread.c (coff_symtab_read): Update.
6758         * ada-lang.c (add_nonlocal_symbols)
6759         (ada_collect_symbol_completion_matches)
6760         (ada_add_global_exceptions): Update.
6761
6762 2019-01-15  Tom Tromey  <tom@tromey.com>
6763
6764         * progspace.h (program_space) <objfiles_safe_range>: New
6765         typedef.
6766         <objfiles_safe>: New method.
6767         * objfiles.h (class all_objfiles_safe): Remove.
6768         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6769         * jit.c (jit_inferior_exit_hook): Update.
6770
6771 2019-01-17  Tom Tromey  <tom@tromey.com>
6772
6773         * progspace.h (program_space) <objfiles_range>: New typedef.
6774         <objfiles>: New method.
6775         <objfiles_head>: Rename from objfiles.
6776         (object_files): Update.
6777         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6778         * guile/scm-pretty-print.c
6779         (ppscm_find_pretty_printer_from_objfiles): Update.
6780         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6781         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6782         Update.
6783         * python/py-progspace.c (pspy_get_objfiles): Update.
6784         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6785         Update.
6786         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6787         (objfpy_lookup_objfile_by_build_id): Update.
6788         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6789         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6790         Update.
6791         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6792         (expand_symtab_containing_pc, lookup_objfile_from_block)
6793         (lookup_static_symbol, basic_lookup_transparent_type)
6794         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6795         (find_line_symtab, info_sources_command)
6796         (default_collect_symbol_completion_matches_break_on)
6797         (make_source_files_completion_list, find_main_name): Update.
6798         * symmisc.c (print_symbol_bcache_statistics)
6799         (print_objfile_statistics, maintenance_print_symbols)
6800         (maintenance_print_msymbols, maintenance_print_objfiles)
6801         (maintenance_info_symtabs, maintenance_check_symtabs)
6802         (maintenance_expand_symtabs, maintenance_info_line_tables):
6803         Update.
6804         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6805         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6806         (map_overlay_command, unmap_overlay_command)
6807         (simple_overlay_update, expand_symtabs_matching)
6808         (map_symbol_filenames): Update.
6809         * symfile-debug.c (set_debug_symfile): Update.
6810         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6811         Update.
6812         * source.c (select_source_symtab, forget_cached_source_info):
6813         Update.
6814         * solib.c (solib_read_symbols): Update.
6815         * solib-spu.c (append_ocl_sos): Update.
6816         * psymtab.c (maintenance_print_psymbols)
6817         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6818         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6819         * printcmd.c (info_symbol_command): Update.
6820         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6821         Update.
6822         * objfiles.h (class all_objfiles): Remove.
6823         * objfiles.c (have_partial_symbols, have_full_symbols)
6824         (have_minimal_symbols, qsort_cmp, update_section_map)
6825         (shared_objfile_contains_address_p)
6826         (default_iterate_over_objfiles_in_search_order): Update.
6827         * objc-lang.c (info_selectors_command, info_classes_command)
6828         (find_methods): Update.
6829         * minsyms.c (find_solib_trampoline_target): Update.
6830         * maint.c (maintenance_info_sections)
6831         (maintenance_translate_address, count_symtabs_and_blocks):
6832         Update.
6833         * main.c (captured_main_1): Update.
6834         * linux-thread-db.c (try_thread_db_load_from_pdir)
6835         (has_libpthread): Update.
6836         * linespec.c (iterate_over_all_matching_symtabs)
6837         (search_minsyms_for_name): Update.
6838         * jit.c (jit_find_objf_with_entry_addr): Update.
6839         * hppa-tdep.c (find_unwind_entry)
6840         (hppa_lookup_stub_minimal_symbol): Update.
6841         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6842         Update.
6843         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6844         (elf_gnu_ifunc_resolve_by_got): Update.
6845         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6846         * dwarf-index-write.c (save_gdb_index_command): Update.
6847         * cp-support.c (add_symbol_overload_list_qualified): Update.
6848         * breakpoint.c (create_overlay_event_breakpoint)
6849         (create_longjmp_master_breakpoint)
6850         (create_std_terminate_master_breakpoint)
6851         (create_exception_master_breakpoint): Update.
6852         * blockframe.c (find_pc_partial_function): Update.
6853         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6854         (ada_collect_symbol_completion_matches)
6855         (ada_add_global_exceptions): Update.
6856
6857 2019-01-17  Tom Tromey  <tom@tromey.com>
6858
6859         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6860         declare VEC.
6861         (solib_target_parse_libraries): Change return type.
6862         (library_list_start_segment, library_list_start_section)
6863         (library_list_end_library, library_list_start_library); Update.
6864         (solib_target_free_library_list): Remove.
6865         (solib_target_parse_libraries): Remove cleanup.  Change return
6866         type.
6867         (solib_target_current_sos): Update.
6868
6869 2019-01-17  Tom Tromey  <tromey@bapiya>
6870
6871         * valprint.c: Replace "the the" with "the".
6872         * symtab.c: Replace "the the" with "the".
6873         * solib.c: Replace "the the" with "the".
6874         * solib-dsbt.c: Replace "the the" with "the".
6875         * linespec.c: Replace "the the" with "the".
6876         * dwarf2loc.h: Replace "the the" with "the".
6877         * amd64-windows-tdep.c: Replace "the the" with "the".
6878         * aarch64-tdep.c: Replace "the the" with "the".
6879
6880 2019-01-16  Keith Seitz  <keiths@redhat.com>
6881
6882         PR gdb/23773
6883         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6884         <builder>: Rename to ..
6885         <m_builder>: ... this and make private.
6886         (dwarf2_cu::get_builder): New method.  Change all users of
6887         `builder' to use this method.
6888         (dwarf2_start_symtab): Move to ...
6889         (dwarf2_cu::start_symtab): ... here.  Update all callers
6890         (setup_type_unit_groups): Move to ...
6891         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6892         callers.
6893         (dwarf2_cu::reset_builder): New method.
6894         (process_full_compunit, process_full_type_unit): Use
6895         dwarf2_cu::reset_builder.
6896         (follow_die_offset): Record the ancestor CU if it is different
6897         from the followed DIE's CU.
6898         (follow_die_sig_1): Likewise.
6899
6900 2019-01-15  Tom Tromey  <tom@tromey.com>
6901
6902         * remote.c (class remote_state) <buf>: Now a char_vector.
6903         <buf_size>: Remove.
6904         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6905         parameter.
6906         (remote_target::getpkt_or_notif_sane_1)
6907         (remote_target::getpkt_sane)
6908         (remote_target::getpkt_or_notif_sane): Likewise.
6909         (class remote_target) <putpkt>: New overload.
6910         (remote_target::read_frame): Change type of "buf_p".  Remove
6911         sizeof_p parameter.
6912         (packet_ok): New overload.
6913         (packet_check_result): New overload.
6914         Update all uses.
6915
6916 2019-01-14  Tom Tromey  <tom@tromey.com>
6917
6918         * remote-notif.c (handle_notification, remote_notif_ack)
6919         (remote_notif_parse): Make "buf" const.
6920         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6921         const.
6922         (remote_notif_parse, remote_notif_ack, handle_notification):
6923         Likewise.
6924         * remote.c (remote_notif_stop_parse): Make "buf" const.
6925         (remote_target::remote_parse_stop_reply): Make "buf" const.
6926         (remote_notif_stop_ack): Make "buf" const.
6927
6928 2019-01-14  Tom Tromey  <tom@tromey.com>
6929
6930         * remote.c (remote_console_output): Make parameter const.
6931
6932 2019-01-14  Tom Tromey  <tom@tromey.com>
6933
6934         * target-debug.h (target_debug_print_signals): Constify.
6935         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6936         * procfs.c (procfs_target::pass_signals): Update.
6937         * linux-nat.c (linux_nat_target::pass_signals): Update.
6938         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6939         * target-delegates.c: Rebuild.
6940         * remote.c (remote_target::program_signals): Update.
6941         (remote_target::pass_signals): Update.
6942         * target.c (target_pass_signals): Constify argument.
6943         (target_program_signals): Likewise.
6944         * target.h (struct target_ops) <pass_signals, program_signals>:
6945         Constify argument.
6946         (target_pass_signals, target_program_signals): Constify argument.
6947
6948 2019-01-14  Tom Tromey  <tom@tromey.com>
6949
6950         PR tui/28819:
6951         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6952
6953 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6954
6955         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6956         field.
6957         * rs6000-tdep.c: Include reggroups.h.
6958         (IS_V_ALIAS_PSEUDOREG): Define.
6959         (rs6000_register_name): Return names for the "vX" aliases.
6960         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6961         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6962         aliases.  Call default_register_reggroup_p for all other
6963         pseudo-registers.
6964         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6965         New functions.
6966         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6967         Handle "vX" aliases.
6968         (v_alias_pseudo_register_collect): New function.
6969         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6970         (rs6000_gdbarch_init): Initialize "vX" aliases as
6971         pseudo-registers.  Restore registration of
6972         rs6000_pseudo_register_reggroup_p with
6973         set_tdesc_pseudo_register_reggroup_p.
6974
6975 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6976
6977         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6978         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6979         set_gdbarch_num_pseudo_regs.
6980
6981 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6982
6983         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6984         Remove arg prefixname, add do_set and do_show.
6985         Add member functions set_list and show_list.
6986         * cli/cli-style.c (class cli_style_option): Update accordingly.
6987         (style_set_list): Move to file scope.
6988         (style_show_list): Likewise.
6989         (set_style): Call help_list.
6990         (show_style): Call cmd_show_list.
6991         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6992         Update to use the new macro.
6993
6994 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6995
6996         * ada-lang.c (_initialize_ada_language): Expand the help text
6997         for the "catch exception" command.
6998
6999 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7000
7001         * symtab.c (matching_obj_sections): Initialize obj,
7002         declare it closer to its usage.
7003
7004 2019-01-10  Tom Tromey  <tom@tromey.com>
7005
7006         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7007         (basic_inf_threads_range): Remove.
7008         (inf_threads_range, inf_non_exited_threads_range)
7009         (safe_inf_threads_range): Use next_adapter.
7010
7011 2019-01-10  Keith Seitz  <keiths@redhat.com>
7012
7013         PR gdb/23712
7014         PR symtab/23010
7015         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7016         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7017
7018 2019-01-10  Keith Seitz  <keiths@redhat.com>
7019
7020         PR gdb/23712
7021         PR symtab/23010
7022         * dictionary.c (pending_to_vector): Remove.
7023         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7024         Remove _1 suffix, replacing functions of the same name.  Update
7025         all callers.
7026         (dict_create_hashed, dict_create_hashed_expandable)
7027         (dict_create_linear, dict_create_linear_expandable, dict_free)
7028         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7029         Make functions static.
7030
7031 2019-01-10  Keith Seitz  <keiths@redhat.com>
7032
7033         PR gdb/23712
7034         PR symtab/23010
7035         * dictionary.h (struct dictionary): Replace declaration with
7036         multidictionary.
7037         (dict_create_hashed, dict_create_hashed_expandable)
7038         (dict_create_linear, dict_create_linear_expandable)
7039         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7040         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7041         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7042         taking multidictionary argument.
7043         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7044         * block.h (struct block) <dict>: Change to multidictionary
7045         and rename `multidict'.
7046         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7047         symmisc.c: Update all dictionary references to multidictionary.
7048
7049 2019-01-10  Keith Seitz  <keiths@redhat.com>
7050
7051         PR gdb/23712
7052         PR symtab/23010
7053         * dictionary.c: Include unordered_map.
7054         (pending_to_vector): New function.
7055         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7056         Rewrite the non-"_1" functions to take vector instead
7057         of linked list.
7058         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7059         "new" _1 versions of the same name.
7060         (multidictionary): Define.
7061         (std::hash<enum language): New definition.
7062         (collate_pending_symbols_by_language, mdict_create_hashed)
7063         (mdict_create_hashed_expandable, mdict_create_linear)
7064         (mdict_create_linear_expandable, mdict_free)
7065         (find_language_dictionary, create_new_language_dictionary)
7066         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7067         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7068         (mdict_size, mdict_empty): New functions.
7069         * dictionary.h (mdict_iterator): Define.
7070
7071 2019-01-10  Pedro Alves  <palves@redhat.com>
7072
7073         * breakpoint.c (read_uploaded_action)
7074         (create_tracepoint_from_upload): Adjust to use
7075         gdb::unique_xmalloc_ptr.
7076         * ctf.c (ctf_write_uploaded_tp):
7077         (SET_ARRAY_FIELD): Use emplace_back.
7078         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7079         * tracefile-tfile.c (tfile_write_uploaded_tp):
7080         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7081         gdb::unique_xmalloc_ptr.
7082         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7083         at_string, cond_string, cmd_strings>: Replace char pointers
7084         with gdb::unique_xmalloc_ptr.
7085
7086 2019-01-10  Pedro Alves  <palves@redhat.com>
7087
7088         * solib-target.c (library_list_start_library): Don't xstrdup name.
7089
7090 2019-01-10  Pedro Alves  <palves@redhat.com>
7091
7092         * mdebugread.c (parse_partial_symbols): Use
7093         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7094
7095 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7096
7097         * linux-fork.c (scoped_switch_fork_info)
7098         <~scoped_switch_fork_info>: Fix incorrect variable name.
7099
7100 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * linux-fork.c (scoped_switch_fork_info)
7103         <scoped_switch_fork_info>: Make explicit.
7104         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7105
7106 2019-01-10  Tom Tromey  <tom@tromey.com>
7107
7108         * objfiles.h (objfile::reset_psymtabs): Update.
7109         * objfiles.c (objfile::objfile): Update.
7110         * psymtab.h (psymtab_storage::obstack): Update.
7111         (psymtab_storage::m_obstack): Use gdb::optional.
7112         (class psymtab_storage): Update comment.  Remove objfile
7113         parameter.
7114         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7115
7116 2019-01-10  Tom Tromey  <tom@tromey.com>
7117
7118         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7119         <free_psymtabs>: Now private.
7120         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7121         (allocate_psymtab): Use new method.
7122
7123 2019-01-10  Tom Tromey  <tom@tromey.com>
7124
7125         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7126         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7127         * mdebugread.c (parse_partial_symbols): Use
7128         allocate_dependencies.
7129         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7130         allocate_dependencies.
7131         (process_psymtab_comp_unit_reader)
7132         (build_type_psymtab_dependencies): Likewise.
7133         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7134
7135 2019-01-10  Tom Tromey  <tom@tromey.com>
7136
7137         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7138         PSYMBOL_SET_LANGUAGE.
7139         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7140
7141 2019-01-10  Tom Tromey  <tom@tromey.com>
7142
7143         * psymtab.h (psymtab_storage::obstack): New method.
7144         <m_obstack>: Rename from obstack; now private.
7145         * psymtab.c (psymtab_storage): Update.
7146         * dwarf2read.c (create_addrmap_from_index)
7147         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7148         Update.
7149
7150 2019-01-10  Tom Tromey  <tom@tromey.com>
7151
7152         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7153         * objfiles.h (objfile::reset_psymtabs): New method.
7154
7155 2019-01-10  Tom Tromey  <tom@tromey.com>
7156
7157         * symmisc.c (print_symbol_bcache_statistics): Update.
7158         (print_objfile_statistics): Update.
7159         * symfile.c (reread_symbols): Update.
7160         * psymtab.h (class psymtab_storage): New.
7161         * psymtab.c (psymtab_storage): New constructor.
7162         (~psymtab_storage): New destructor.
7163         (require_partial_symbols): Update.
7164         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7165         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7166         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7167         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7168         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7169         (start_psymtab_common, end_psymtab_common)
7170         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7171         (allocate_psymtab): Update.
7172         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7173         Update.
7174         (dump_psymtab_addrmap, maintenance_print_psymbols)
7175         (maintenance_check_psymtabs): Update.
7176         (class objfile_psymtabs): Move to objfiles.h.
7177         * psympriv.h (discard_psymtab): Now inline.
7178         (psymtab_discarder::psymtab_discarder): Update.
7179         (psymtab_discarder::~psymtab_discarder): Update.
7180         (ALL_OBJFILE_PSYMTABS): Rewrite.
7181         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7182         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7183         Remove fields.
7184         <partial_symtabs>: New field.
7185         (class objfile_psymtabs): Move from psymtab.h.  Update.
7186         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7187         psymbol_cache.
7188         (objfile::~objfile): Don't destroy psymbol_cache.
7189         * mdebugread.c (parse_partial_symbols): Update.
7190         * dwarf2read.c (create_addrmap_from_index)
7191         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7192         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7193         (add_partial_subprogram, dwarf2_ranges_read): Update.
7194         * dwarf-index-write.c (write_address_map)
7195         (write_one_signatured_type, recursively_write_psymbols)
7196         (class debug_names, class debug_names, write_psymtabs_to_index):
7197         Update.
7198
7199 2019-01-10  Tom Tromey  <tom@tromey.com>
7200
7201         * symtab.h (SYMBOL_SET_NAMES): Update.
7202         (symbol_set_names): Update.
7203         (MSYMBOL_SET_NAMES): Update.
7204         * symtab.c (symbol_set_names): Change argument to be an
7205         objfile_per_bfd_storage.
7206         * psymtab.c (add_psymbol_to_bcache): Update.
7207         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7208
7209 2019-01-10  Tom Tromey  <tom@tromey.com>
7210
7211         * symtab.c (create_demangled_names_hash): Change argument to be an
7212         objfile_per_bfd_storage.
7213         (symbol_set_names): Update.
7214
7215 2019-01-10  Tom Tromey  <tom@tromey.com>
7216
7217         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7218         init_psymbol_list.
7219         * psymtab.c (init_psymbol_list): Do nothing if already called.
7220         * psympriv.h (init_psymbol_list): Add comment.
7221         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7222         init_psymbol_list.
7223         * dbxread.c (dbx_symfile_read): Unconditionally call
7224         init_psymbol_list.
7225
7226 2019-01-10  Tom Tromey  <tom@tromey.com>
7227
7228         * xcoffread.c (scan_xcoff_symtab): Update.
7229         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7230         "where".
7231         * mdebugread.c (parse_partial_symbols)
7232         (handle_psymbol_enumerators): Update.
7233         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7234         * dbxread.c (read_dbx_symtab): Update.
7235         * psympriv.h (psymbol_placement): New enum.
7236         (add_psymbol_to_list): Update.
7237
7238 2019-01-10  Tom Tromey  <tom@tromey.com>
7239
7240         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7241         static_psymbols parameters.
7242         (scan_xcoff_symtab): Update.
7243         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7244         static_psymbols parameters.
7245         * psympriv.h (start_psymtab_common): Update.
7246         * mdebugread.c (parse_partial_symbols): Update.
7247         * dwarf2read.c (create_partial_symtab): Update.
7248         * dbxread.c (read_dbx_symtab): Update.
7249         (start_psymtab): Remove global_psymbols and static_psymbols
7250         parameters.
7251
7252 2019-01-10  Tom Tromey  <tom@tromey.com>
7253
7254         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7255         * psymtab.c (allocate_psymtab): Add comment.
7256         * psympriv.h (allocate_psymtab): Add comment.
7257         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7258         initializations.
7259         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7260
7261 2019-01-10  Tom Tromey  <tom@tromey.com>
7262
7263         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7264         Don't declare.
7265         * mipsread.c: Include mdebugread.h.
7266         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7267         Declare.
7268         * elfread.c: Include mdebugread.h.
7269
7270 2019-01-09  Tom Tromey  <tom@tromey.com>
7271
7272         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7273         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7274         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7275         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7276         (psym_lookup_symbol, psym_find_last_source_symtab)
7277         (psym_forget_cached_source_info, psym_print_stats)
7278         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7279         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7280         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7281         (psym_find_compunit_symtab_by_address)
7282         (maintenance_print_psymbols, maintenance_info_psymtabs)
7283         (maintenance_check_psymtabs): Use ranged for.
7284         * psymtab.h (class objfile_psymtabs): New.
7285         (require_partial_symbols): Return objfile_psymtabs.
7286         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7287
7288 2019-01-09  Tom Tromey  <tom@tromey.com>
7289
7290         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7291         (find_pc_mapped_section, list_overlays_command)
7292         (map_overlay_command, unmap_overlay_command)
7293         (simple_overlay_update): Use all_objfiles.
7294         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7295         * printcmd.c (info_symbol_command): Use all_objfiles.
7296         * objfiles.h (ALL_OBJSECTIONS): Remove.
7297         * maint.c (maintenance_translate_address): Use all_objfiles.
7298         * gcore.c (gcore_create_callback): Use all_objfiles.
7299         (objfile_find_memory_regions): Likewise.
7300
7301 2019-01-09  Tom Tromey  <tom@tromey.com>
7302
7303         * symtab.c (find_line_symtab, info_sources_command)
7304         (make_source_files_completion_list): Use objfile_compunits.
7305         * source.c (select_source_symtab): Use objfile_compunits.
7306         * objfiles.h (struct objfile): Update comment.
7307         (ALL_OBJFILES): Remove.
7308         (ALL_FILETABS): Remove.
7309         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7310         objfile_compunits.
7311
7312 2019-01-09  Tom Tromey  <tom@tromey.com>
7313
7314         * symmisc.c (print_objfile_statistics, dump_objfile)
7315         (maintenance_print_symbols): Use compunit_filetabs.
7316         * source.c (forget_cached_source_info_for_objfile): Use
7317         compunit_filetabs.
7318         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7319         (ALL_FILETABS): Use compunit_filetabs.
7320         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7321         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7322
7323 2019-01-09  Tom Tromey  <tom@tromey.com>
7324
7325         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7326         (compunit_filetabs): New.
7327         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7328         compunit_filetabs.
7329         (info_sources_command, make_source_files_completion_list): Remove
7330         declaration.
7331         * symmisc.c (print_objfile_statistics, dump_objfile)
7332         (maintenance_print_symbols): Remove declaration.
7333         (maintenance_info_symtabs): Use compunit_filetabs.
7334         (maintenance_info_line_tables): Likewise.
7335         * source.c (select_source_symtab): Change local variable name.
7336         (forget_cached_source_info_for_objfile): Remove declaration.
7337         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7338         * objfiles.c (objfile_relocate1): Remove declaration.
7339         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7340         declaration.
7341         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7342         * coffread.c (coff_symtab_read): Remove declaration.
7343         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7344         compunit_filetabs.
7345
7346 2019-01-09  Tom Tromey  <tom@tromey.com>
7347
7348         * symtab.c (lookup_objfile_from_block)
7349         (find_pc_sect_compunit_symtab, search_symbols)
7350         (default_collect_symbol_completion_matches_break_on): Use
7351         objfile_compunits.
7352         * objfiles.h (ALL_COMPUNITS): Remove.
7353         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7354         * cp-support.c (add_symbol_overload_list_qualified): Use
7355         objfile_compunits.
7356         * ada-lang.c (ada_collect_symbol_completion_matches)
7357         (ada_add_global_exceptions): Use objfile_compunits.
7358
7359 2019-01-09  Tom Tromey  <tom@tromey.com>
7360
7361         * source.c (select_source_symtab)
7362         (forget_cached_source_info_for_objfile): Remove declaration.
7363         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7364         declaration.
7365         * maint.c (count_symtabs_and_blocks): Remove declaration.
7366         * cp-support.c (add_symbol_overload_list_qualified): Remove
7367         declaration.
7368         * coffread.c (coff_symtab_read): Remove declaration.
7369         * symtab.c (lookup_symbol_in_objfile_symtabs)
7370         (basic_lookup_transparent_type_1): Use objfile_compunits.
7371         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7372         (info_sources_command, search_symbols)
7373         (default_collect_symbol_completion_matches_break_on)
7374         (make_source_files_completion_list): Remove declaration.
7375         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7376         (ada_collect_symbol_completion_matches)
7377         (ada_add_global_exceptions): Remove declaration.
7378         * linespec.c (iterate_over_all_matching_symtabs): Use
7379         objfile_compunits.
7380         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7381         (class objfile_compunits): New.
7382         (ALL_COMPUNITS): Use objfile_compunits.
7383         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7384         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7385         objfile_compunits.
7386         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7387
7388 2019-01-09  Tom Tromey  <tom@tromey.com>
7389
7390         * symtab.c (search_symbols)
7391         (default_collect_symbol_completion_matches_break_on): Use
7392         objfile_msymbols.
7393         * ada-lang.c (ada_lookup_simple_minsym)
7394         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7395         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7396         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7397         objfile_msymbols.
7398         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7399         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7400         * objc-lang.c (find_methods): Use objfile_msymbols.
7401         (info_selectors_command, info_classes_command): Likewise.
7402         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7403         * objfiles.h (class objfile_msymbols): New.
7404         (ALL_OBJFILE_MSYMBOLS): Remove.
7405         (ALL_MSYMBOLS): Remove.
7406
7407 2019-01-09  Tom Tromey  <tom@tromey.com>
7408
7409         * common/next-iterator.h (next_adapter): Add Iterator template
7410         parameter.
7411         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7412         (class all_objfiles_safe): New.
7413         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7414         * objfiles.c (put_objfile_before): Update comment.
7415         (add_separate_debug_objfile): Likewise.
7416         (free_all_objfiles): Use all_objfiles_safe.
7417         (objfile_purge_solibs): Likewise.
7418
7419 2019-01-09  Tom Tromey  <tom@tromey.com>
7420
7421         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7422         (expand_symtab_containing_pc, lookup_static_symbol)
7423         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7424         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7425         all_objfiles.
7426         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7427         * breakpoint.c (create_overlay_event_breakpoint)
7428         (create_longjmp_master_breakpoint)
7429         (create_std_terminate_master_breakpoint)
7430         (create_exception_master_breakpoint): Use all_objfiles.
7431         * linux-thread-db.c (try_thread_db_load_from_pdir)
7432         (has_libpthread): Use all_objfiles.
7433         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7434         * linespec.c (iterate_over_all_matching_symtabs)
7435         (search_minsyms_for_name): Use all_objfiles.
7436         * maint.c (maintenance_info_sections): Use all_objfiles.
7437         * main.c (captured_main_1): Use all_objfiles.
7438         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7439         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7440         * guile/scm-pretty-print.c
7441         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7442         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7443         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7444         (maintenance_print_msymbols): Use all_objfiles.
7445         * source.c (select_source_symtab): Use all_objfiles.
7446         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7447         * symfile.c (remove_symbol_file_command)
7448         (expand_symtabs_matching, map_symbol_filenames): Use
7449         all_objfiles.
7450         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7451         all_objfiles.
7452         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7453         * objc-lang.c (find_methods): Use all_objfiles.
7454         * objfiles.c (have_partial_symbols, have_full_symbols)
7455         (have_minimal_symbols, qsort_cmp)
7456         (default_iterate_over_objfiles_in_search_order): Use
7457         all_objfiles.
7458         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7459         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7460         (maintenance_check_psymtabs): Use all_objfiles.
7461         (ALL_PSYMTABS): Remove.
7462         * compile/compile-object-run.c (do_module_cleanup): Use
7463         all_objfiles.
7464         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7465         * cp-support.c (add_symbol_overload_list_qualified): Use
7466         all_objfiles.
7467         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7468         Use all_objfiles.
7469         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7470         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7471         all_objfiles.
7472         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7473         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7474         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7475         Uses all_objfiles.
7476         * solib.c (solib_read_symbols): Use all_objfiles
7477
7478 2019-01-09  Tom Tromey  <tom@tromey.com>
7479
7480         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7481         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7482         all_objfiles.
7483         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7484         * symmisc.c (print_symbol_bcache_statistics)
7485         (print_objfile_statistics, maintenance_print_objfiles)
7486         (maintenance_info_symtabs, maintenance_check_symtabs)
7487         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7488         all_objfiles.
7489         * source.c (forget_cached_source_info): Use all_objfiles.
7490         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7491         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7492         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7493         * objfiles.c (update_section_map): Use all_objfiles.
7494         (shared_objfile_contains_address_p): Likewise.
7495         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7496         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7497
7498 2019-01-09  Tom Tromey  <tom@tromey.com>
7499
7500         * common/next-iterator.h: New file.
7501         * objfiles.h (class all_objfiles): New.
7502         (struct objfile_iterator): New.
7503
7504 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7505
7506         * NEWS: Move the description of the changed "frame", "select-frame",
7507          and "info frame" commands to the Changed commands section.
7508
7509 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7510
7511         * gdbtypes.c (check_stub_method_group): Remove handling of old
7512         mangling schemes.
7513         * linespec.c (find_methods): Likewise.
7514         * stabsread.c (read_member_functions): Likewise.
7515         * valops.c (search_struct_method): Likewise.
7516         (value_struct_elt_for_reference): Likewise.
7517         * NEWS: Mention this change.
7518
7519 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7522         print_source_lines.
7523         * source.c (print_source_lines_base): Update line number check.
7524         (print_source_lines): New function.
7525         (source_lines_range::source_lines_range): New function.
7526         * source.h (class source_lines_range): New class.
7527         (print_source_lines): New declaration.
7528
7529 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7530
7531         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7532
7533 2019-01-08  Tom Tromey  <tom@tromey.com>
7534             Simon Marchi  <simon.marchi@ericsson.com>
7535
7536         PR gdb/24060
7537         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7538         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7539         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7540         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7541         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7542         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7543
7544 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * source.c (select_source_symtab): Move header comment to
7547         declaration in source.h.
7548         (forget_cached_source_info_for_objfile): Likewise.
7549         (forget_cached_source_info): Likewise.
7550         (identify_source_line): Likewise.
7551         * source.h (identify_source_line): Move declaration from symtab.h
7552         and add comment from source.c
7553         (print_source_lines): Likewise.
7554         (forget_cached_source_info_for_objfile): Likewise.
7555         (forget_cached_source_info): Likewise.
7556         (select_source_symtab): Likewise.
7557         (enum print_source_lines_flag): Move definition from symtab.h.
7558         * symtab.h (identify_source_line): Move declaration to source.h.
7559         (print_source_lines): Likewise.
7560         (forget_cached_source_info_for_objfile): Likewise.
7561         (forget_cached_source_info): Likewise.
7562         (select_source_symtab): Likewise.
7563         (enum print_source_lines_flag): Move definition to source.h.
7564         * tui/tui-hooks.c: Add 'source.h' include.
7565
7566 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7567
7568         * source.c (print_source_lines_base): Handle requests to print
7569         reverse line number sequences, and guard against empty lines
7570         string.
7571
7572 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * source.c (print_source_lines_base): Fix skip of '\r' if next
7575         character is '\n'.
7576
7577 2019-01-06  Tom Tromey  <tom@tromey.com>
7578
7579         * c-exp.y (struct c_parse_state) <macro_original_text,
7580         expansion_obstack>: New member.
7581         (macro_original_text, expansion_obstack): Remove globals.
7582         (scan_macro_expansion, scanning_macro_expansion)
7583         (finished_macro_expansion): Update.
7584         (scan_macro_cleanup): Remove.
7585         (yylex, c_parse): Update.
7586
7587 2019-01-06  Tom Tromey  <tom@tromey.com>
7588
7589         * c-exp.y (struct c_parse_state) <strings>: New member.
7590         (operator_stoken): Update.
7591
7592 2019-01-06  Tom Tromey  <tom@tromey.com>
7593
7594         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7595         (union type_stack_elt) <typelist_val>: Now a pointer to
7596         std::vector.
7597         (type_stack_cleanup): Don't declare.
7598         (push_typelist): Update.
7599         * parse.c (pop_typelist): Return a std::vector.
7600         (push_typelist): Take a std::vector.
7601         (follow_types): Update.  Do not free args.
7602         (type_stack_cleanup): Remove.
7603         * c-exp.y (struct c_parse_state): New.
7604         (cpstate): New global.
7605         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7606         (nonempty_typelist): Update.
7607         (func_mod): Create a new vector.
7608         (c_parse): Create a c_parse_state.
7609         (check_parameter_typelist): Do not delete params.
7610         (function_method): Update.  Do not delete type_list.
7611
7612 2019-01-06  Tom Tromey  <tom@tromey.com>
7613
7614         PR gdb/28155:
7615         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7616         check_typedef.
7617         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7618         (print_return_value): Likewise.
7619
7620 2019-01-05  Tom Tromey  <tom@tromey.com>
7621
7622         * contrib/cleanup_check.py: Remove.
7623         * contrib/gcc-with-excheck: Remove.
7624         * contrib/exsummary.py: Remove.
7625         * contrib/excheck.py: Remove.
7626
7627 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7628
7629         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7630         NULL. Initialize tpprev to NULL instead of assigning it
7631         to NULL on the next statement.
7632         * windows-nat.c (windows_delete_thread): Remove check for
7633         main_thread_id before printing thread exit notifications.
7634         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7635         Remove thread ID check against main_thread_id.
7636         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7637         windows_delete_thread.
7638         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7639
7640 2019-01-04  Tom Tromey  <tom@tromey.com>
7641
7642         * compile/compile.c (_initialize_compile): Use upper case for
7643         metasyntactic variables.
7644         * symmisc.c (_initialize_symmisc): Use upper case for
7645         metasyntactic variables.
7646         * psymtab.c (_initialize_psymtab): Use upper case for
7647         metasyntactic variables.
7648         * demangle.c (demangle_command): Use upper case for metasyntactic
7649         variables.
7650         (_initialize_demangler): Likewise.
7651         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7652         variables.
7653
7654 2019-01-03  Tom Tromey  <tom@tromey.com>
7655
7656         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7657
7658 2019-01-03  Tom Tromey  <tom@tromey.com>
7659
7660         * python/py-symtab.c (salpy_str): Update.
7661         (struct salpy_sal_object) <symtab>: Now a PyObject.
7662         (salpy_dealloc): Update.
7663         (del_objfile_sal): Use gdbpy_ref.
7664
7665 2019-01-03  Tom Tromey  <tom@tromey.com>
7666
7667         * python/py-type.c (convert_field): Use new_reference.  Return
7668         gdbpy_ref.
7669         (make_fielditem): Return gdbpy_ref.
7670         (typy_fields): Update.
7671         (typy_getitem): Update.
7672         (field_name): Return gdbpy_ref.  Use new_reference.
7673         (typy_iterator_iternext): Update.
7674
7675 2019-01-03  Tom Tromey  <tom@tromey.com>
7676
7677         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7678
7679 2019-01-03  Tom Tromey  <tom@tromey.com>
7680
7681         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7682         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7683         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7684         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7685         (pspy_set_type_printers): Likewise.
7686         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7687         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7688         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7689         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7690         (objfpy_set_type_printers): Likewise.
7691
7692 2019-01-03  Tom Tromey  <tom@tromey.com>
7693
7694         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7695         (gdbpy_print_stack): Use gdbpy_err_fetch.
7696         * python/python-internal.h (class gdbpy_err_fetch): New class.
7697         (class gdbpy_enter) <m_error_type, m_error_value,
7698         m_error_traceback>: Remove.
7699         <m_error>: New member.
7700         (gdbpy_exception_to_string): Don't declare.
7701         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7702         * python/py-value.c (convert_value_from_python): Use
7703         gdbpy_err_fetch.
7704         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7705         gdbpy_exception_to_string.
7706         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7707         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7708         gdbpy_err_fetch.
7709
7710 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7711
7712         * linux-nat.c (delete_lwp_cleanup): Delete.
7713         (struct lwp_deleter): New struct.
7714         (lwp_info_up): New typedef.
7715         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7716         lwp_info_up.
7717
7718 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7719
7720         * linux-fork.c (class scoped_switch_fork_info): New class.
7721         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7722
7723 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7724
7725         * valops.c (find_overload_match): Remove use of null_cleanup, and
7726         calls to do_cleanups.
7727
7728 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7729
7730         * compile/compile-cplus-types.c
7731         (compile_cplus_instance::decl_name): Handle changes to
7732         cp_func_name.
7733         * cp-support.c (cp_func_name): Update header comment, update
7734         return type.
7735         * cp-support.h (cp_func_name): Update return type in declaration.
7736         * valops.c (find_overload_match): Move temp_func local to top
7737         level of function and change its type.  Use temp_func to hold and
7738         delete temporary string obtained from cp_func_name.
7739
7740 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7741
7742         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7743         gdb::char_vector, remove cleanup, and update uses of `msg`.
7744
7745 2019-01-03  Jim Wilson  <jimw@sifive.com>
7746
7747         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7748
7749 2019-01-02  Tom Tromey  <tom@tromey.com>
7750
7751         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7752         (tdesc_parse_xml): Remove cleanups.
7753         * target-descriptions.h (make_cleanup_free_target_description):
7754         Don't declare.
7755         (target_desc_deleter): New struct.
7756         (target_desc_up): New typedef.
7757         * target-descriptions.c (target_desc_deleter::operator()): Rename
7758         from free_target_description.
7759         (make_cleanup_free_target_description): Remove.
7760
7761 2019-01-02  Tom Tromey  <tom@tromey.com>
7762
7763         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7764         constructor, destructor.
7765         (linespec_parser): Remove typedef.
7766         (~linespec_parser): Rename from linespec_parser_delete.
7767         (linespec_lex_to_end, linespec_complete_label)
7768         (linespec_complete): Update.
7769         (decode_line_full): Remove cleanups.
7770         (decode_line_1): Update.
7771
7772 2019-01-02  Tom Tromey  <tom@tromey.com>
7773
7774         * python/python-internal.h (inferior_to_inferior_object): Change
7775         return type.
7776         * python/py-exitedevent.c (create_exited_event_object): Update.
7777         * python/py-inferior.c (inferior_to_inferior_object): Return
7778         gdbpy_ref.
7779         (python_new_inferior, python_inferior_deleted)
7780         (thread_to_thread_object, delete_thread_object)
7781         (build_inferior_list, gdbpy_selected_inferior): Update.
7782         * python/py-infthread.c (create_thread_object): Update.  Also fail
7783         if inferior_to_inferior_object fails.
7784
7785 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7786
7787         * inferior.h (class inferior) <displaced_step_state>: New field.
7788         * infrun.h (struct displaced_step_state): Move here from
7789         infrun.c.  Initialize fields, add constructor.
7790         <inf>: Remove field.
7791         <reset>: New method.
7792         * infrun.c (struct displaced_step_inferior_state): Move to
7793         infrun.h.
7794         (displaced_step_inferior_states): Remove.
7795         (get_displaced_stepping_state): Adust.
7796         (displaced_step_in_progress_any_inferior): Adjust.
7797         (displaced_step_in_progress_thread): Adjust.
7798         (displaced_step_in_progress): Adjust.
7799         (add_displaced_stepping_state): Remove.
7800         (get_displaced_step_closure_by_addr): Adjust.
7801         (remove_displaced_stepping_state): Remove.
7802         (infrun_inferior_exit): Call displaced_step_state.reset.
7803         (use_displaced_stepping): Don't check for NULL.
7804         (displaced_step_prepare_throw): Call
7805         get_displaced_stepping_state.
7806         (displaced_step_fixup): Don't check for NULL.
7807         (prepare_for_detach): Don't check for NULL.
7808
7809 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7810
7811         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7812          in case of call that did not complete.
7813
7814 2019-01-02  Andrey Utkin  <autkin@undo.io>
7815
7816         * symfile.c (find_separate_debug_file): Fix search of debug files for
7817         remote debuggee.
7818
7819 2019-01-02  Tom Tromey  <tom@tromey.com>
7820
7821         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7822         indentation.
7823         * python/py-frame.c (frapy_older): Remove cast.
7824         (frapy_newer): Likewise.
7825         * python/py-breakpoint.c (local_setattro): Remove cast.
7826         * python/py-arch.c (archpy_name): Remove local variable.
7827         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7828
7829 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7830
7831         * unittests/basic_string_view/element_access/char/empty.cc:
7832         Fix year range in copyright header.
7833
7834 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7835
7836         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7837         Delete.
7838         <operator==>: Update with for removed field.
7839         <hash>: Likewise.
7840         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7841         <isa_features>: ...this.
7842         <abi_features>: New field.
7843         (riscv_isa_flen): Update comment.
7844         (riscv_abi_xlen): New declaration.
7845         (riscv_abi_flen): New declaration.
7846         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7847         isa_features.
7848         (riscv_abi_xlen): New function.
7849         (riscv_isa_flen): Update to get answer from isa_features.
7850         (riscv_abi_flen): New function.
7851         (riscv_has_fp_abi): Update to get answer from abi_features.
7852         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7853         xlen and flen.
7854         (riscv_call_info) <xlen, flen>: Update comment.
7855         (riscv_call_arg_struct): Remove invalid assertions
7856         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7857         is removed.
7858         (riscv_gdbarch_init): Gather isa features and abi features
7859         separately, ensure both match on the gdbarch when reusing an old
7860         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7861         a target with 64-bit float hardware.
7862
7863 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7864
7865         * source.c (search_command_helper): Stop reverse search
7866         when line 1 has been searched.
7867
7868 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7869
7870         * record-full.c (record_full_base_target::close): Rewrite
7871         record_full_core_buf_list free logic.
7872
7873 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7874
7875         * break-catch-syscall.c (print_one_catch_syscall): xfree
7876         the last text.
7877
7878 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7879
7880         * top.c (print_gdb_version): Update Copyright year in version
7881         message.
7882
7883 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7884
7885         Update copyright year range in all GDB files.
7886
7887 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7888
7889         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7890
7891 For older changes see ChangeLog-2018.
7892 \f
7893 Local Variables:
7894 mode: change-log
7895 left-margin: 8
7896 fill-column: 74
7897 version-control: never
7898 coding: utf-8
7899 End:
7900