gdb/ChangeLog

   1 2020-04-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * windows-nat.c (wait_for_debug_event): Move to
   4         nat/windows-nat.c.
   5         * nat/windows-nat.h (wait_for_debug_event): Declare.
   6         * nat/windows-nat.c (wait_for_debug_event): Move from
   7         windows-nat.c.  No longer static.
   8
   9 2020-04-08  Tom Tromey  <tromey@adacore.com>
  10
  11         * windows-nat.c (get_windows_debug_event): Use
  12         fetch_pending_stop.
  13         * nat/windows-nat.h (fetch_pending_stop): Declare.
  14         * nat/windows-nat.c (fetch_pending_stop): New function.
  15
  16 2020-04-08  Tom Tromey  <tromey@adacore.com>
  17
  18         * windows-nat.c (windows_continue): Use matching_pending_stop and
  19         continue_last_debug_event.
  20         * nat/windows-nat.h (matching_pending_stop)
  21         (continue_last_debug_event): Declare.
  22         * nat/windows-nat.c (DEBUG_EVENTS): New define.
  23         (matching_pending_stop, continue_last_debug_event): New
  24         functions.
  25
  26 2020-04-08  Tom Tromey  <tromey@adacore.com>
  27
  28         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
  29         (handle_exception_result): Move to nat/windows-nat.h.
  30         (DEBUG_EXCEPTION_SIMPLE): Remove.
  31         (windows_nat::handle_ms_vc_exception): New function.
  32         (handle_exception): Move to nat/windows-nat.c.
  33         (get_windows_debug_event): Update.
  34         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
  35         nat/windows-nat.c.
  36         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
  37         (handle_exception_result): Move from windows-nat.c.
  38         (handle_exception): Declare.
  39         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
  40         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
  41         windows-nat.c.
  42
  43 2020-04-08  Tom Tromey  <tromey@adacore.com>
  44
  45         * windows-nat.c (exception_count, event_count): Remove.
  46         (handle_exception, get_windows_debug_event)
  47         (do_initial_windows_stuff): Update.
  48
  49 2020-04-08  Tom Tromey  <tromey@adacore.com>
  50
  51         * windows-nat.c (windows_nat::handle_load_dll)
  52         (windows_nat::handle_unload_dll): Rename.  No longer static.
  53         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
  54         Declare.
  55
  56 2020-04-08  Tom Tromey  <tromey@adacore.com>
  57
  58         * complaints.h (stop_whining): Declare at top-level.
  59         (complaint): Don't declare stop_whining.
  60
  61 2020-04-08  Tom Tromey  <tromey@adacore.com>
  62
  63         * windows-nat.c (windows_nat::handle_output_debug_string):
  64         Rename.  No longer static.
  65         * nat/windows-nat.h (handle_output_debug_string): Declare.
  66
  67 2020-04-08  Tom Tromey  <tromey@adacore.com>
  68
  69         * windows-nat.c (current_process_handle, current_process_id)
  70         (main_thread_id, last_sig, current_event, last_wait_event)
  71         (current_windows_thread, desired_stop_thread_id, pending_stops)
  72         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
  73         (display_selectors, fake_create_process)
  74         (get_windows_debug_event): Update.
  75         * nat/windows-nat.h (current_process_handle, current_process_id)
  76         (main_thread_id, last_sig, current_event, last_wait_event)
  77         (current_windows_thread, desired_stop_thread_id, pending_stops)
  78         (struct pending_stop, siginfo_er): Move from windows-nat.c.
  79         * nat/windows-nat.c (current_process_handle, current_process_id)
  80         (main_thread_id, last_sig, current_event, last_wait_event)
  81         (current_windows_thread, desired_stop_thread_id, pending_stops)
  82         (siginfo_er): New globals.  Move from windows-nat.c.
  83
  84 2020-04-08  Tom Tromey  <tromey@adacore.com>
  85
  86         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
  87         (handle_load_dll): Update.
  88         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
  89
  90 2020-04-08  Tom Tromey  <tromey@adacore.com>
  91
  92         * windows-nat.c (enum thread_disposition_type): Move to
  93         nat/windows-nat.h.
  94         (windows_nat::thread_rec): Rename from thread_rec.  No longer
  95         static.
  96         (windows_add_thread, windows_nat_target::fetch_registers)
  97         (windows_nat_target::store_registers, handle_exception)
  98         (windows_nat_target::resume, get_windows_debug_event)
  99         (windows_nat_target::get_tib_address)
 100         (windows_nat_target::thread_name)
 101         (windows_nat_target::thread_alive): Update.
 102         * nat/windows-nat.h (enum thread_disposition_type): Move from
 103         windows-nat.c.
 104         (thread_rec): Declare.
 105
 106 2020-04-08  Tom Tromey  <tromey@adacore.com>
 107
 108         * windows-nat.c: Add "using namespace".
 109         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
 110         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
 111
 112 2020-04-08  Tom Tromey  <tromey@adacore.com>
 113
 114         * nat/windows-nat.h (struct windows_thread_info): Declare
 115         destructor.
 116         * nat/windows-nat.c (~windows_thread_info): New.
 117
 118 2020-04-08  Tom Tromey  <tromey@adacore.com>
 119
 120         PR gdb/22992
 121         * windows-nat.c (current_event): Update comment.
 122         (last_wait_event, desired_stop_thread_id): New globals.
 123         (struct pending_stop): New.
 124         (pending_stops): New global.
 125         (windows_nat_target) <stopped_by_sw_breakpoint>
 126         <supports_stopped_by_sw_breakpoint>: New methods.
 127         (windows_fetch_one_register): Add assertions.  Adjust PC.
 128         (windows_continue): Handle pending stops.  Suspend other threads
 129         when stepping.  Use last_wait_event
 130         (wait_for_debug_event): New function.
 131         (get_windows_debug_event): Use wait_for_debug_event.  Handle
 132         pending stops.  Queue spurious stops.
 133         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
 134         (windows_nat_target::kill): Use wait_for_debug_event.
 135         * nat/windows-nat.h (struct windows_thread_info)
 136         <stopped_at_software_breakpoint>: New field.
 137         * nat/windows-nat.c (windows_thread_info::resume): Clear
 138         stopped_at_software_breakpoint.
 139
 140 2020-04-08  Tom Tromey  <tromey@adacore.com>
 141
 142         * windows-nat.c (enum thread_disposition_type): New.
 143         (thread_rec): Replace "get_context" parameter with "disposition";
 144         change type.
 145         (windows_add_thread, windows_nat_target::fetch_registers)
 146         (windows_nat_target::store_registers, handle_exception)
 147         (windows_nat_target::resume, get_windows_debug_event)
 148         (windows_nat_target::get_tib_address)
 149         (windows_nat_target::thread_name)
 150         (windows_nat_target::thread_alive): Update.
 151
 152 2020-04-08  Tom Tromey  <tromey@adacore.com>
 153
 154         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
 155         (windows_continue): Use windows_continue::resume.
 156         * nat/windows-nat.h (struct windows_thread_info) <suspend,
 157         resume>: Declare new methods.
 158         * nat/windows-nat.c: New file.
 159         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
 160
 161 2020-04-08  Tom Tromey  <tromey@adacore.com>
 162
 163         * windows-nat.c (windows_add_thread, windows_delete_thread)
 164         (windows_nat_target::fetch_registers)
 165         (windows_nat_target::store_registers, fake_create_process)
 166         (windows_nat_target::resume, windows_nat_target::resume)
 167         (get_windows_debug_event, windows_nat_target::wait)
 168         (windows_nat_target::pid_to_str)
 169         (windows_nat_target::get_tib_address)
 170         (windows_nat_target::get_ada_task_ptid)
 171         (windows_nat_target::thread_name)
 172         (windows_nat_target::thread_alive): Use lwp, not tid.
 173
 174 2020-04-08  Tom Tromey  <tromey@adacore.com>
 175
 176         * windows-nat.c (handle_exception)
 177         (windows_nat_target::thread_name): Update.
 178         * nat/windows-nat.h (windows_thread_info): Remove destructor.
 179         <name>: Now unique_xmalloc_ptr.
 180
 181 2020-04-08  Tom Tromey  <tromey@adacore.com>
 182
 183         * windows-nat.c (thread_rec)
 184         (windows_nat_target::fetch_registers): Update.
 185         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
 186         Update comment.
 187         <debug_registers_changed, reload_context>: Now bool.
 188
 189 2020-04-08  Tom Tromey  <tromey@adacore.com>
 190
 191         * windows-nat.c (windows_add_thread): Use new.
 192         (windows_init_thread_list, windows_delete_thread): Use delete.
 193         (get_windows_debug_event): Update.
 194         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
 195         destructor, and initializers.
 196
 197 2020-04-08  Tom Tromey  <tromey@adacore.com>
 198
 199         * windows-nat.c (struct windows_thread_info): Remove.
 200         * nat/windows-nat.h: New file.
 201
 202 2020-04-08  Tom Tromey  <tromey@adacore.com>
 203
 204         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
 205         (thread_rec, windows_add_thread, windows_delete_thread)
 206         (windows_continue): Update.
 207
 208 2020-04-08  Tom Tromey  <tromey@adacore.com>
 209
 210         * windows-nat.c (struct windows_thread_info): Remove typedef.
 211         (thread_head): Remove.
 212         (thread_list): New global.
 213         (thread_rec, windows_add_thread, windows_init_thread_list)
 214         (windows_delete_thread, windows_continue): Update.
 215
 216 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
 217
 218         * windows-tdep.h (windows_init_abi): Add comment.
 219         (cygwin_init_abi): New declaration.
 220         * windows-tdep.c: Split signal enumeration in two, one for
 221         Windows and one for Cygwin.
 222         (windows_gdb_signal_to_target): Only deal with signal of the
 223         Windows OS ABI.
 224         (cygwin_gdb_signal_to_target): New function.
 225         (windows_init_abi): Rename to windows_init_abi_common, don't set
 226         gdb_signal_to_target gdbarch method.  Add new new function with
 227         this name.
 228         (cygwin_init_abi): New function.
 229         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
 230         comment.  Don't call windows_init_abi.
 231         (amd64_windows_init_abi): Add comment, call windows_init_abi.
 232         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
 233         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
 234         i386_windows_init_abi_common, don't call windows_init_abi.  Add
 235         a new function of this name.
 236         (i386_cygwin_init_abi): New function.
 237         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
 238         OS ABI Cygwin.
 239
 240 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
 241
 242         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
 243         parameter.c.
 244         (dwarf2_read_gdb_index): Update.
 245
 246 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
 247
 248         * nbsd-tdep.c: Include "objfiles.h".
 249         (nbsd_skip_solib_resolver): New.
 250         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
 251
 252 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 253
 254         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
 255         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
 256         with DW_LLE_base_addressx are being emitted in DWARFv5.
 257         Add the newly added kind DW_LOC_OFFSET_PAIR also.
 258         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
 259         unsigned integer.
 260
 261 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 262
 263         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
 264         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
 265         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
 266         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
 267         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
 268         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
 269         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
 270
 271
 272 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 273
 274         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
 275         (read_loclist_index): New function definition.
 276         (lookup_loclist_base): New function definition.
 277         (read_loclist_header): New function definition.
 278         (dwarf2_cu): Add loclist_base and loclist_header field.
 279         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
 280         (read_full_die_1): Read the value of DW_AT_loclists_base.
 281         (read_attribute_reprocess): Handle DW_FORM_loclistx.
 282         (read_attribute_value): Handle DW_FORM_loclistx.
 283         (skip_one_die): Handle DW_FORM_loclistx.
 284         (loclist_header): New structure declaration.
 285         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
 286
 287 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
 288
 289         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
 290         constructor.  Remove `addr` parameter from other constructor and
 291         add `per_cu` parameter.
 292         * dwarf2/read.c (create_partial_symtab): Update.
 293
 294 2020-04-07  Tom de Vries  <tdevries@suse.de>
 295
 296         PR symtab/25796
 297         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
 298         (partial_die_info::fixup): Inherit has_const_value.
 299
 300 2020-04-07  Tom de Vries  <tdevries@suse.de>
 301
 302         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
 303         symbols without address.
 304
 305 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
 306
 307         * nbsd-nat.h (struct thread_info): Add forward declaration.
 308         (nbsd_nat_target::thread_alive): Add.
 309         (nbsd_nat_target::thread_name): Likewise.
 310         (nbsd_nat_target::update_thread_list): Likewise.
 311         (update_thread_list::post_attach): Likewise.
 312         (post_attach::pid_to_str): Likewise.
 313         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
 314         (nbsd_thread_lister): Add.
 315         (nbsd_nat_target::thread_alive): Likewise.
 316         (nbsd_nat_target::thread_name): Likewise.
 317         (nbsd_add_threads): Likewise.
 318         (update_thread_list::post_attach): Likewise.
 319         (nbsd_nat_target::update_thread_list): Likewise.
 320         (post_attach::pid_to_str): Likewise.
 321
 322 2020-04-06  Tom Tromey  <tromey@adacore.com>
 323
 324         * ada-valprint.c (print_variant_part): Extract the variant field.
 325         (print_field_values): Use the field as the outer value when
 326         recursing.
 327
 328 2020-04-06  Tom Tromey  <tromey@adacore.com>
 329
 330         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
 331         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
 332         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
 333         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
 334         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
 335
 336 2020-04-06  Tom Tromey  <tromey@adacore.com>
 337
 338         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
 339         TYPE_CODE_ERROR.
 340
 341 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
 342
 343         * nbsd-tdep.c: Include "gdbarch.h".
 344         Define enum with NetBSD signal numbers.
 345         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
 346         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
 347         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
 348         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
 349         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
 350         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
 351         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
 352         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
 353         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
 354         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
 355         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
 356         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
 357
 358 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
 359
 360         PR gdb/25325
 361         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
 362
 363 2020-04-03  Tom Tromey  <tromey@adacore.com>
 364
 365         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
 366         Read constant block.
 367
 368 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
 369
 370         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
 371         (gdb_bfd_get_full_section_contents): New declaration.
 372         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
 373         * windows-tdep.c (is_linked_with_cygwin_dll): Use
 374         gdb_bfd_get_full_section_contents.
 375
 376 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
 377
 378         * exec.c (build_section_table): Replace internal_error with
 379         gdb_assert.
 380         (section_table_xfer_memory_partial): Likewise.
 381         * mdebugread.c (parse_partial_symbols): Likewise.
 382         * psymtab.c (lookup_partial_symbol): Likewise.
 383         * utils.c (wrap_here): Likewise.
 384
 385 2020-04-02  Tom Tromey  <tromey@adacore.com>
 386
 387         * f-lang.c (build_fortran_types): Use arch_type to initialize
 388         builtin_complex_s32 in the TYPE_CODE_ERROR case.
 389
 390 2020-04-02  Tom Tromey  <tromey@adacore.com>
 391
 392         * dwarf2/read.c (partial_die_info::read): Do not create a vector
 393         of attributes.
 394
 395 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 396             Bernd Edlinger <bernd.edlinger@hotmail.de>
 397             Tom Tromey  <tromey@adacore.com>
 398
 399         * buildsym.c (buildsym_compunit::record_line): Remove
 400         deduplication code.
 401
 402 2020-04-02  Tom de Vries  <tdevries@suse.de>
 403
 404         PR ada/24671
 405         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
 406
 407 2020-04-02  Tom de Vries  <tdevries@suse.de>
 408
 409         * dwarf2/read.c (dwarf2_gdb_index_functions,
 410         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
 411         NULL.
 412         * psymtab.c (psym_lookup_global_symbol_language): New function.
 413         (psym_functions): Init psym_lookup_global_symbol_language with
 414         psym_lookup_global_symbol_language.
 415         * symfile-debug.c (debug_sym_quick_functions): Init
 416         lookup_global_symbol_language with NULL.
 417         * symfile.c (set_initial_language): Remove fixme comment.
 418         * symfile.h (struct quick_symbol_functions): Add
 419         lookup_global_symbol_language.
 420         * symtab.c (find_quick_global_symbol_language): New function.
 421         (find_main_name): Use find_quick_global_symbol_language.
 422
 423 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
 424
 425         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
 426
 427 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 428
 429         * buildsym.c (record_line): Fix undefined behavior and preserve
 430         lines at eof.
 431
 432 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 433
 434         * buildsym.c (record_line): Fix the resizing condition.
 435
 436 2020-04-01  Tom Tromey  <tom@tromey.com>
 437
 438         * value.h (value_literal_complex): Add comment.
 439         * valops.c (value_literal_complex): Refer to value.h.
 440
 441 2020-04-01  Tom Tromey  <tom@tromey.com>
 442
 443         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
 444         (scalar_type): New rule, from typebase.
 445         (typebase): Use scalar_type.  Recognize complex types.
 446         (field_name): Handle FLOAT_KEYWORD.
 447         (ident_tokens): Add _Complex and __complex__.
 448
 449 2020-04-01  Tom Tromey  <tom@tromey.com>
 450
 451         PR exp/25299:
 452         * valarith.c (promotion_type, complex_binop): New functions.
 453         (scalar_binop): Handle complex numbers.  Use promotion_type.
 454         (value_pos, value_neg, value_complement): Handle complex numbers.
 455
 456 2020-04-01  Tom Tromey  <tom@tromey.com>
 457
 458         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
 459         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
 460         (parse_number): Handle complex numbers.
 461
 462 2020-04-01  Tom Tromey  <tom@tromey.com>
 463
 464         * c-valprint.c (c_decorations): Change complex suffix to "i".
 465
 466 2020-04-01  Tom Tromey  <tom@tromey.com>
 467
 468         * valprint.c (generic_value_print_complex): Use accessors.
 469         * value.h (value_real_part, value_imaginary_part): Declare.
 470         * valops.c (value_real_part, value_imaginary_part): New
 471         functions.
 472         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
 473
 474 2020-04-01  Tom Tromey  <tom@tromey.com>
 475
 476         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
 477         (read_range_type): Update.
 478         * mdebugread.c (basic_type): Update.
 479         * go-lang.c (build_go_types): Use init_complex_type.
 480         * gdbtypes.h (struct main_type) <complex_type>: New member.
 481         (init_complex_type): Update.
 482         (arch_complex_type): Don't declare.
 483         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
 484         Make name if none given.  Use alloc_type_copy.  Look for cached
 485         complex type.
 486         (arch_complex_type): Remove.
 487         (gdbtypes_post_init): Use init_complex_type.
 488         * f-lang.c (build_fortran_types): Use init_complex_type.
 489         * dwarf2/read.c (read_base_type): Update.
 490         * d-lang.c (build_d_types): Use init_complex_type.
 491         * ctfread.c (read_base_type): Update.
 492
 493 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 494
 495         * infrun.c (stop_all_threads): Update assertion, plus when
 496         stopping threads, take into account that we might be trying
 497         to stop an all-stop target.
 498         (stop_waiting): Call 'stop_all_threads' if there exists a
 499         non-stop target.
 500
 501 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 502
 503         * target.h (exists_non_stop_target): New function declaration.
 504         * target.c (exists_non_stop_target): New function.
 505
 506 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
 507
 508         PR gdb/24789
 509         * eval.c (is_integral_or_integral_reference): New function.
 510         (evaluate_subexp_standard): Allow integer references in
 511         pointer arithmetic.
 512
 513 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 514
 515         * remote.c (remote_target::remote_parse_stop_reply): Remove the
 516         check for no ptid in the stop reply when the target is non-stop.
 517
 518 2020-04-01  Tom Tromey  <tromey@adacore.com>
 519
 520         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
 521         "name" parameter to rvalue reference.  Initialize m_name_holder.
 522         <lookup_name_info>: New overloads.
 523         <name>: Return gdb::string_view.
 524         <c_str>: New method.
 525         <make_ignore_params>: Update.
 526         <search_name_hash>: Update.
 527         <language_lookup_name>: Return const char *.
 528         <m_name>: Change type.
 529         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
 530         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
 531         (lookup_name_info::match_any): Update.
 532         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
 533         Update.
 534         * minsyms.c (linkage_name_str): Update.
 535         * language.c (default_symbol_name_matcher): Update.
 536         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
 537         Update.
 538         * ada-lang.c (ada_fold_name): Change parameter to string_view.
 539         (ada_lookup_name_info::ada_lookup_name_info): Update.
 540         (literal_symbol_name_matcher): Update.
 541
 542 2020-04-01  Tom Tromey  <tromey@adacore.com>
 543
 544         * psymtab.c (psymtab_search_name): Remove function.
 545         (psym_lookup_symbol): Create search name and lookup name here.
 546         (lookup_partial_symbol): Remove "name" parameter; add
 547         lookup_name.
 548         (psym_expand_symtabs_for_function): Update.
 549
 550 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
 551
 552         PR tui/25597:
 553         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
 554
 555 2020-03-31  Tom Tromey  <tromey@adacore.com>
 556
 557         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
 558         memcpy.
 559
 560 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
 561
 562         * features/riscv/32bit-csr.xml: Regenerated.
 563         * features/riscv/64bit-csr.xml: Regenerated.
 564
 565 2020-03-30  Tom Tromey  <tromey@adacore.com>
 566
 567         * ada-valprint.c (print_variant_part): Update.
 568         * ada-lang.h (ada_which_variant_applies): Update.
 569         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
 570         outer_valaddr parameters; replace with "outer" value parameter.
 571         (to_fixed_variant_branch_type): Update.
 572
 573 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 574
 575         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
 576         <list>.  Remove inclusion of observable.h.
 577         (PPC_DEBUG_CURRENT_VERSION): Move up define.
 578         (struct arch_lwp_info): New struct.
 579         (class ppc_linux_dreg_interface): New class.
 580         (struct ppc_linux_process_info): New struct.
 581         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
 582         <low_new_clone, low_forget_process, low_prepare_to_resume>
 583         <copy_thread_dreg_state, mark_thread_stale>
 584         <mark_debug_registers_changed, register_hw_breakpoint>
 585         <clear_hw_breakpoint, register_wp, clear_wp>
 586         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
 587         <num_memory_accesses, get_trigger_type>
 588         <create_watchpoint_request, hwdebug_point_cmp>
 589         <init_arch_lwp_info, get_arch_lwp_info>
 590         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
 591         methods.
 592         <struct ptid_hash>: New inner struct.
 593         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
 594         members.
 595         (saved_dabr_value, hwdebug_info, max_slots_number)
 596         (struct hw_break_tuple, struct thread_points, ppc_threads)
 597         (have_ptrace_hwdebug_interface)
 598         (hwdebug_find_thread_points_by_tid)
 599         (hwdebug_insert_point, hwdebug_remove_point): Remove.
 600         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
 601         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
 602         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
 603         use m_dreg_interface.
 604         (hwdebug_point_cmp): Change to...
 605         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
 606         reference arguments instead of pointers.
 607         (ppc_linux_nat_target::ranged_break_num_registers): Use
 608         m_dreg_interface.
 609         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
 610         m_dreg_interface.  Call register_hw_breakpoint.
 611         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
 612         m_dreg_interface.  Call clear_hw_breakpoint.
 613         (get_trigger_type): Change to...
 614         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
 615         comment.
 616         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
 617         use m_dreg_interface.  Call register_hw_breakpoint.
 618         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
 619         use m_dreg_interface.  Call clear_hw_breakpoint.
 620         (can_use_watchpoint_cond_accel): Change to...
 621         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
 622         method.  Update comment, use m_dreg_interface and
 623         m_process_info.
 624         (calculate_dvc): Change to...
 625         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
 626         m_dreg_interface.
 627         (num_memory_accesses): Change to...
 628         (ppc_linux_nat_target::num_memory_accesses): ...this method.
 629         (check_condition): Change to...
 630         (ppc_linux_nat_target::check_condition): ...this method.
 631         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
 632         comment, use m_dreg_interface.
 633         (create_watchpoint_request): Change to...
 634         (ppc_linux_nat_target::create_watchpoint_request): ...this
 635         method.  Use m_dreg_interface.
 636         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
 637         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
 638         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
 639         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
 640         (ppc_linux_nat_target::low_forget_process)
 641         (ppc_linux_nat_target::low_new_fork)
 642         (ppc_linux_nat_target::low_new_clone)
 643         (ppc_linux_nat_target::low_delete_thread)
 644         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
 645         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
 646         only call mark_thread_stale.
 647         (ppc_linux_thread_exit): Remove.
 648         (ppc_linux_nat_target::stopped_data_address): Change to...
 649         (ppc_linux_nat_target::low_stopped_data_address): This. Add
 650         comment, use m_dreg_interface and m_thread_hw_breakpoints.
 651         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
 652         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
 653         comment.  Call low_stopped_data_address.
 654         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
 655         m_dreg_interface.
 656         (ppc_linux_nat_target::masked_watch_num_registers): Use
 657         m_dreg_interface.
 658         (ppc_linux_nat_target::copy_thread_dreg_state)
 659         (ppc_linux_nat_target::mark_thread_stale)
 660         (ppc_linux_nat_target::mark_debug_registers_changed)
 661         (ppc_linux_nat_target::register_hw_breakpoint)
 662         (ppc_linux_nat_target::clear_hw_breakpoint)
 663         (ppc_linux_nat_target::register_wp)
 664         (ppc_linux_nat_target::clear_wp)
 665         (ppc_linux_nat_target::init_arch_lwp_info)
 666         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
 667         (_initialize_ppc_linux_nat): Remove observer callback.
 668
 669 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 670
 671         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
 672         (ppc_linux_nat_target::auxv_parse)
 673         (ppc_linux_nat_target::read_description)
 674         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
 675         Move up.
 676
 677 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 678
 679         * linux-nat.h (low_new_clone): New method.
 680         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
 681
 682 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 683
 684         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
 685         (dbx_expand_psymtab): ... this.
 686         (start_psymtab): Update.
 687         * mdebugread.c (psymtab_to_symtab_1): Rename to...
 688         (mdebug_expand_psymtab): ... this.
 689         (parse_partial_symbols): Update.
 690         (new_psymtab): Update.
 691         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
 692         (xcoff_expand_psymtab): ... this.
 693         (xcoff_start_psymtab): Update.
 694
 695 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 696
 697         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
 698         <expand_dependencies>: ... this.
 699         * psymtab.c (partial_symtab::read_dependencies): Rename to...
 700         (partial_symtab::expand_dependencies): ... this.
 701         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
 702         Update.
 703         (dwarf2_psymtab::expand_psymtab): Update.
 704         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
 705         * mdebugread.c (psymtab_to_symtab_1): Update.
 706         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
 707
 708 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 709
 710         * psympriv.h (discard_psymtab): Remove.
 711         * dbxread.c (dbx_end_psymtab): Update.
 712         * xcoffread.c (xcoff_end_psymtab): Update.
 713
 714 2020-03-28  Tom Tromey  <tom@tromey.com>
 715
 716         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
 717         comment.
 718
 719 2020-03-28  Tom Tromey  <tom@tromey.com>
 720
 721         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
 722
 723 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
 724
 725         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
 726
 727 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
 728
 729         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
 730
 731 2020-03-26  Tom Tromey  <tom@tromey.com>
 732
 733         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
 734         (mark_common_block_symbol_computed, read_tag_string_type)
 735         (attr_to_dynamic_prop, read_subrange_type): Update.
 736         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
 737         to be methods on struct attribute.
 738         (skip_one_die, process_imported_unit_die, read_namespace_alias)
 739         (read_call_site_scope, partial_die_info::read)
 740         (partial_die_info::read, lookup_die_type, follow_die_ref):
 741         Update.
 742         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
 743         from dwarf2_get_ref_die_offset.
 744         (attribute::constant_value): New method, from
 745         dwarf2_get_attr_constant_value.
 746         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
 747         Declare method.
 748         <constant_value>: New method.
 749
 750 2020-03-26  Tom Tromey  <tom@tromey.com>
 751
 752         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
 753         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
 754         (dwarf_type_encoding_name): Move to stringify.c.
 755         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
 756         * dwarf2/stringify.c: New file.
 757         * dwarf2/stringify.h: New file.
 758
 759 2020-03-26  Tom Tromey  <tom@tromey.com>
 760
 761         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
 762         Rewrite.
 763
 764 2020-03-26  Tom Tromey  <tom@tromey.com>
 765
 766         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
 767         methods.
 768         * dwarf2/read.c (lookup_addr_base): Move to die.h.
 769         (lookup_ranges_base): Likewise.
 770         (read_cutu_die_from_dwo, read_full_die_1): Update.
 771
 772 2020-03-26  Tom Tromey  <tom@tromey.com>
 773
 774         * dwarf2/read.c (read_import_statement, read_file_scope)
 775         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
 776         (read_lexical_block_scope, read_call_site_scope)
 777         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
 778         (handle_struct_member_die, process_structure_scope)
 779         (update_enumeration_type_from_children)
 780         (process_enumeration_scope, read_array_type, read_common_block)
 781         (read_namespace, read_module, read_subroutine_type): Update.
 782         (sibling_die): Remove.
 783
 784 2020-03-26  Tom Tromey  <tom@tromey.com>
 785
 786         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
 787         (build_type_psymtabs_reader, read_structure_type)
 788         (read_enumeration_type, read_full_die_1): Update.
 789         (dwarf2_attr_no_follow): Move to die.h.
 790         * dwarf2/die.h (struct die_info) <attr>: New method.
 791
 792 2020-03-26  Tom Tromey  <tom@tromey.com>
 793
 794         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
 795         <base_address>: Now an optional.
 796         (dwarf2_find_base_address, dwarf2_rnglists_process)
 797         (dwarf2_ranges_process, fill_in_loclist_baton)
 798         (dwarf2_symbol_mark_computed): Update.
 799
 800 2020-03-26  Tom Tromey  <tom@tromey.com>
 801
 802         * dwarf2/read.c (struct die_info): Move to die.h.
 803         * dwarf2/die.h: New file.
 804
 805 2020-03-26  Tom Tromey  <tom@tromey.com>
 806
 807         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
 808         * dwarf2/read.c
 809         (dwarf2_statement_list_fits_in_line_number_section_complaint):
 810         Move to line-header.c.
 811         (read_checked_initial_length_and_offset, read_formatted_entries):
 812         Likewise.
 813         (dwarf_decode_line_header): Split into two.
 814         * dwarf2/line-header.c
 815         (dwarf2_statement_list_fits_in_line_number_section_complaint):
 816         Move from read.c.
 817         (read_checked_initial_length_and_offset, read_formatted_entries):
 818         Likewise.
 819         (dwarf_decode_line_header): New function, split from read.c.
 820
 821 2020-03-26  Tom Tromey  <tom@tromey.com>
 822
 823         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
 824         Declare method.
 825         * dwarf2/read.c (read_attribute_value): Update.
 826         (dwarf2_per_objfile::read_line_string): Rename from
 827         read_indirect_line_string.
 828         (read_formatted_entries): Update.
 829
 830 2020-03-26  Tom Tromey  <tom@tromey.com>
 831
 832         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
 833         variable.
 834
 835 2020-03-26  Tom Tromey  <tom@tromey.com>
 836
 837         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
 838         const.
 839         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
 840         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
 841         parameter const.
 842
 843 2020-03-26  Tom Tromey  <tom@tromey.com>
 844
 845         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
 846         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
 847         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
 848         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
 849
 850 2020-03-26  Tom Tromey  <tom@tromey.com>
 851
 852         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
 853         file_names_size, file_full_name, file_file_name>: Use const.
 854         <file_name_at, file_names>: Add const overload.
 855         * dwarf2/line-header.c (line_header::file_file_name)
 856         (line_header::file_full_name): Update.
 857
 858 2020-03-26  Tom Tromey  <tom@tromey.com>
 859
 860         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
 861         (macro_start_file, consume_improper_spaces)
 862         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
 863         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
 864         (dwarf_decode_macros): Move to macro.c.
 865         * dwarf2/macro.c: New file.
 866         * dwarf2/macro.h: New file.
 867         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
 868
 869 2020-03-26  Tom Tromey  <tom@tromey.com>
 870
 871         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
 872         method.
 873         * dwarf2/section.c: New method.  From
 874         read_indirect_string_at_offset_from.
 875         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
 876         (read_indirect_string_at_offset_from): Move to section.c.
 877         (read_indirect_string_at_offset): Rewrite.
 878         (read_indirect_line_string_at_offset): Remove.
 879         (read_indirect_string, read_indirect_line_string)
 880         (dwarf_decode_macro_bytes): Update.
 881
 882 2020-03-26  Tom Tromey  <tom@tromey.com>
 883
 884         * dwarf2/section.h (struct dwarf2_section_info)
 885         <overload_complaint>: Declare.
 886         (dwarf2_section_buffer_overflow_complaint): Don't declare.
 887         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
 888         Rename from dwarf2_section_buffer_overflow_complaint.
 889         * dwarf2/read.c (skip_one_die, partial_die_info::read)
 890         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
 891
 892 2020-03-26  Tom Tromey  <tom@tromey.com>
 893
 894         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
 895         Declare.
 896         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
 897         Move from read.c.
 898         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
 899         to section.c.
 900
 901 2020-03-26  Tom Tromey  <tom@tromey.com>
 902
 903         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
 904
 905 2020-03-26  Tom Tromey  <tom@tromey.com>
 906
 907         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
 908         "builder".
 909         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
 910         parameter.
 911         (dwarf_decode_macros): Update.
 912
 913 2020-03-26  Tom Tromey  <tom@tromey.com>
 914
 915         * dwarf2/read.c (read_attribute_value): Update.
 916         (read_indirect_string_from_dwz): Move to dwz.c; change into
 917         method.
 918         (dwarf_decode_macro_bytes): Update.
 919         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
 920         * dwarf2/dwz.c: New file.
 921         * Makefile.in (COMMON_SFILES): Add dwz.c.
 922
 923 2020-03-26  Tom Tromey  <tom@tromey.com>
 924
 925         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
 926         * dwarf2/read.c: Add include.
 927         * dwarf2/index-write.c: Add include.
 928         * dwarf2/index-cache.c: Add include.
 929         * dwarf2/dwz.h: New file.
 930
 931 2020-03-25  Tom Tromey  <tom@tromey.com>
 932
 933         * compile/compile-object-load.c (get_out_value_type): Mention
 934         correct symbol name in error message.
 935
 936 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
 937
 938         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
 939
 940 2020-03-25  Tom de Vries  <tdevries@suse.de>
 941
 942         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
 943         * symmisc.c (dump_symtab_1): Print user and includes fields.
 944         (maintenance_info_symtabs): Same.
 945
 946 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 947
 948         PR gdb/25534
 949         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
 950         (riscv_regcache_cooked_write): New function.
 951         (riscv_push_dummy_call): Use new function.
 952         (riscv_return_value): Likewise.
 953
 954 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
 955
 956         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
 957         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
 958         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
 959         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
 960         * infrun.c (follow_fork): Likewise.
 961         (follow_fork_inferior): Likewise.
 962         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
 963         * linux-nat.h (class linux_nat_target): Likewise.
 964         * remote.c (class remote_target) <follow_fork>: Likewise.
 965         (remote_target::follow_fork): Likewise.
 966         * target-delegates.c: Re-generate.
 967         * target.c (default_follow_fork): Likewise.
 968         (target_follow_fork): Likewise.
 969         * target.h (struct target_ops) <follow_fork>: Likewise.
 970         (target_follow_fork): Likewise.
 971
 972 2020-03-24  Tom de Vries  <tdevries@suse.de>
 973
 974         * psymtab.c (maintenance_info_psymtabs): Print user field.
 975
 976 2020-03-20  Tom Tromey  <tromey@adacore.com>
 977
 978         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
 979         const.
 980         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
 981         const.
 982
 983 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
 984
 985         * ptrace.m4: Don't check for ptrace declaration.
 986         * config.in: Re-generate.
 987         * configure: Re-generate.
 988         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
 989         not defined.
 990
 991 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 992
 993         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
 994         `PTRACE_TYPE_RET'.
 995         * i386-bsd-nat.c (gdb_ptrace): Likewise.
 996         * sparc-nat.c (gdb_ptrace): Likewise.
 997         * x86-bsd-nat.c (gdb_ptrace): Likewise.
 998
 999 2020-03-20  Tom Tromey  <tromey@adacore.com>
1000
1001         * c-exp.y (lex_one_token): Fix assert.
1002
1003 2020-03-20  Tom Tromey  <tromey@adacore.com>
1004
1005         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
1006         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
1007         strncpy call.
1008
1009 2020-03-20  Tom Tromey  <tromey@adacore.com>
1010
1011         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
1012
1013 2020-03-20  Tom Tromey  <tromey@adacore.com>
1014
1015         * ada-valprint.c (print_variant_part): Remove parameters; switch
1016         to value-based API.
1017         (print_field_values): Likewise.
1018         (ada_val_print_struct_union): Likewise.
1019         (ada_value_print_1): Update.
1020
1021 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1022
1023         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
1024         nbsd_nat_target instead of inf_ptrace_target.
1025         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1026         nbsd_nat_target.
1027
1028 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1029
1030         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
1031         it to the ptrace call.
1032         * (store_registers): Likewise.
1033
1034 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1035
1036         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
1037         it to the ptrace call.
1038         * (store_registers): Likewise.
1039
1040 2020-03-19  Luis Machado  <luis.machado@linaro.org>
1041
1042         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
1043         valid, fetch vg value from ptrace.
1044
1045 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
1046         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
1047         * inf-ptrace.c: Likewise.
1048         * (gdb_ptrace): Add.
1049         * (inf_ptrace_target::resume): Update.
1050         * (inf_ptrace_target::xfer_partial): Likewise.
1051         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
1052         * (inf_ptrace_peek_poke): Update.
1053
1054 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
1055
1056         * x86-bsd-nat.c (gdb_ptrace): New.
1057         * (x86bsd_dr_set): Add new argument `ptid'.
1058         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
1059         x86bsd_dr_set_addr): Update.
1060
1061 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * remote.c (remote_target::process_stop_reply): Handle events for
1064         all threads differently.
1065
1066 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         * completer.c (completion_tracker::remove_completion): Define new
1069         function.
1070         * completer.h (completion_tracker::remove_completion): Declare new
1071         function.
1072         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
1073         when adding a C++ function symbol.
1074
1075 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * completer.c (completion_tracker::completion_hash_entry): Define
1078         new class.
1079         (advance_to_filename_complete_word_point): Call
1080         recompute_lowest_common_denominator.
1081         (completion_tracker::completion_tracker): Call discard_completions
1082         to setup the hash table.
1083         (completion_tracker::discard_completions): Allow for being called
1084         from the constructor, pass new equal function, and element deleter
1085         when constructing the hash table.  Initialise new class member
1086         variables.
1087         (completion_tracker::maybe_add_completion): Remove use of
1088         m_entries_vec, and store more information into m_entries_hash.
1089         (completion_tracker::recompute_lcd_visitor): New function, most
1090         content taken from...
1091         (completion_tracker::recompute_lowest_common_denominator):
1092         ...here, this now just visits each item in the hash calling the
1093         above visitor.
1094         (completion_tracker::build_completion_result): Remove use of
1095         m_entries_vec, call recompute_lowest_common_denominator.
1096         * completer.h (completion_tracker::have_completions): Remove use
1097         of m_entries_vec.
1098         (completion_tracker::completion_hash_entry): Declare new class.
1099         (completion_tracker::recompute_lowest_common_denominator): Change
1100         function signature.
1101         (completion_tracker::recompute_lcd_visitor): Declare new function.
1102         (completion_tracker::m_entries_vec): Delete.
1103         (completion_tracker::m_entries_hash): Initialize to NULL.
1104         (completion_tracker::m_lowest_common_denominator_valid): New
1105         member variable.
1106         (completion_tracker::m_lowest_common_denominator_max_length): New
1107         member variable.
1108
1109 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1110
1111         * regformats/regdef.h: Put reg in gdb namespace.
1112
1113 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1114
1115         * i386-bsd-nat.c (gdb_ptrace): New.
1116         * (i386bsd_fetch_inferior_registers,
1117         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
1118         * (i386bsd_fetch_inferior_registers,
1119         i386bsd_store_inferior_registers) Use gdb_ptrace.
1120
1121 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1122
1123         * amd64-bsd-nat.c (gdb_ptrace): New.
1124         * (amd64bsd_fetch_inferior_registers,
1125         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
1126         * (amd64bsd_fetch_inferior_registers,
1127         amd64bsd_store_inferior_registers) Use gdb_ptrace.
1128
1129 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1130
1131         * user-regs.c (user_reg::read): Rename to...
1132         (user_reg::xread): ...this.
1133         * (append_user_reg): Rename argument `read' to `xread'.
1134         * (user_reg_add_builtin): Likewise.
1135         * (user_reg_add): Likewise.
1136         * (value_of_user_reg): Likewise.
1137
1138 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1139
1140         * sparc-nat.c (gdb_ptrace): New.
1141         * sparc-nat.c (sparc_fetch_inferior_registers)
1142         (sparc_store_inferior_registers) Remove obsolete comment.
1143         * sparc-nat.c (sparc_fetch_inferior_registers)
1144         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
1145         * sparc-nat.c (sparc_fetch_inferior_registers)
1146         (sparc_store_inferior_registers) Use gdb_ptrace.
1147
1148 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1149
1150         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
1151         it to the ptrace call.
1152         * sh-nbsd-nat.c (store_registers): Likewise.
1153
1154 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1155
1156         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
1157         nbsd_nat_target instead of inf_ptrace_target.
1158         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1159         nbsd_nat_target.
1160
1161 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1162
1163         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
1164
1165 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1166
1167         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
1168         <sys/sysctl.h>.
1169         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
1170
1171 2020-03-17  Tom de Vries  <tdevries@suse.de>
1172
1173         PR gdb/23710
1174         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
1175         fields.
1176         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
1177         fields.
1178         (process_imported_unit_die): Skip import of c++ CUs.
1179
1180 2020-03-16  Tom Tromey  <tom@tromey.com>
1181
1182         * p-valprint.c (pascal_object_print_value): Initialize
1183         base_value.
1184
1185 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
1186             Shahab Vahedi  <shahab@synopsys.com>
1187
1188         * Makefile.in: Add arch/arc.o
1189         * configure.tgt: Likewise.
1190         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
1191         (_initialize_arc_tdep): Don't initialize old target descriptions.
1192         (arc_read_description): New function to cache target descriptions.
1193         * arc-tdep.h (arc_read_description): Add proto type.
1194         * arch/arc.c: New file.
1195         * arch/arc.h: Likewise.
1196         * features/Makefile: Replace old target descriptions with new.
1197         * features/arc-arcompact.c: Remove.
1198         * features/arc-arcompact.xml: Likewise.
1199         * features/arc-v2.c: Likewise
1200         * features/arc-v2.xml: Likewise
1201         * features/arc/aux-arcompact.xml: New file.
1202         * features/arc/aux-v2.xml: Likewise.
1203         * features/arc/core-arcompact.xml: Likewise.
1204         * features/arc/core-v2.xml: Likewise.
1205         * features/arc/aux-arcompact.c: Generate.
1206         * features/arc/aux-v2.c: Likewise.
1207         * features/arc/core-arcompact.c: Likewise.
1208         * features/arc/core-v2.c: Likewise.
1209         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
1210
1211 2020-03-16  Tom Tromey  <tromey@adacore.com>
1212
1213         PR gdb/25663:
1214         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
1215         putting value into bcache.
1216
1217 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1218
1219         PR gdb/21500
1220         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
1221         to...
1222         (amd64_windows_init_abi_common): ... this.  Don't set size of
1223         long type.
1224         (amd64_windows_init_abi): New function.
1225         (amd64_cygwin_init_abi): New function.
1226         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
1227         the Cygwin OS ABI.
1228         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
1229         comment.
1230
1231 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1232
1233         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
1234         * windows-tdep.c (CYGWIN_DLL_NAME): New.
1235         (pe_import_directory_entry): New struct type.
1236         (is_linked_with_cygwin_dll): New function.
1237         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
1238         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
1239         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
1240
1241 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1242
1243         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
1244         i386_cygwin_core_osabi_sniffer.
1245
1246 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1247
1248         * i386-cygwin-tdep.c: Rename to...
1249         * i386-windows-tdep.c: ... this.
1250         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
1251         i386-windows-tdep.c.
1252         * configure.tgt: Likewise.
1253
1254 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1255
1256         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
1257         * osabi.c (gdb_osabi_names): Add "Windows".
1258         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
1259         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
1260         (i386_cygwin_core_osabi_sniffer): New function, extracted from
1261         i386_cygwin_osabi_sniffer.
1262         (_initialize_i386_cygwin_tdep): Register OS ABI
1263         GDB_OSABI_WINDOWS for i386.
1264         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
1265         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
1266         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
1267         for x86-64.
1268         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
1269         when the target matches '*-*-mingw*'.
1270
1271 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1272
1273         * defs.h (enum gdb_osabi): Move to...
1274         * osabi.h (enum gdb_osabi): ... here.
1275         * gdbarch.sh: Include osabi.h in gdbarch.h.
1276         * gdbarch.h: Re-generate.
1277
1278 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1279
1280         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
1281         function.
1282         (_initialize_amd64_windows_tdep): Register osabi sniffer.
1283
1284 2020-03-14  Tom Tromey  <tom@tromey.com>
1285
1286         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
1287         for C++.
1288         (c_type_print_modifier): Likewise.  Add "language" parameter.
1289         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
1290         (c_type_print_base_1): Update.
1291         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
1292         constants.
1293         * type-stack.c (type_stack::insert): Handle tp_atomic and
1294         tp_restrict.
1295         (type_stack::follow_type_instance_flags): Likewise.
1296         (type_stack::follow_types): Likewise.  Merge type-following code.
1297         * c-exp.y (RESTRICT, ATOMIC): New tokens.
1298         (space_identifier, cv_with_space_id)
1299         (const_or_volatile_or_space_identifier_noopt)
1300         (const_or_volatile_or_space_identifier): Remove.
1301         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
1302         rules.
1303         (ptr_operator, typebase): Update.
1304         (enum token_flag) <FLAG_C>: New constant.
1305         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
1306         "_Atomic".
1307         (lex_one_token): Handle FLAG_C.
1308
1309 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1310
1311         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
1312         it to the ptrace call.
1313         * m68k-bsd-nat.c (store_registers): Likewise.
1314
1315 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1316
1317         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
1318         gdb_byte *.
1319         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
1320         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
1321         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
1322
1323 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1324
1325         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
1326         nbsd_nat_target instead of inf_ptrace_target.
1327         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1328         nbsd_nat_target.
1329
1330 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1331
1332         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
1333         register_t.
1334
1335 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1336
1337         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
1338         it to the ptrace call.
1339         * alpha-bsd-nat.c (store_registers): Likewise.
1340
1341 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1342
1343         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
1344         includes.
1345         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
1346         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
1347         fill_fpregset): Likewise.
1348
1349 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1350
1351         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
1352         nbsd_nat_target instead of inf_ptrace_target.
1353         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1354         nbsd_nat_target.
1355
1356 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1357
1358         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
1359         register_t.
1360
1361 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1362
1363         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
1364         it to the ptrace call.
1365         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
1366         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
1367         * arm-nbsd-nat.c (store_register): Likewise.
1368         * arm-nbsd-nat.c (store_regs): Likewise.
1369         * arm-nbsd-nat.c (store_fp_register): Likewise.
1370         * arm-nbsd-nat.c (store_fp_regs): Likewise.
1371
1372 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1373
1374         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
1375         nbsd_nat_target instead of inf_ptrace_target.
1376         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1377         nbsd_nat_target.
1378
1379 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1380
1381         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
1382         it to the ptrace call.
1383         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
1384
1385 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1386
1387         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
1388         it to the ptrace call.
1389         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
1390
1391 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1392
1393         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
1394         gdb_byte *.
1395         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
1396
1397 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1398
1399         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
1400         instead of inf_ptrace_target.
1401         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1402         nbsd_nat_target.
1403
1404 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1405
1406         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1407         register_t.
1408
1409 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1410
1411         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1412         register_t.
1413
1414 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1415
1416         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
1417         register_t.
1418
1419 2020-03-13  Tom Tromey  <tom@tromey.com>
1420
1421         * value.h (val_print): Don't declare.
1422         * valprint.h (val_print_array_elements)
1423         (val_print_scalar_formatted, generic_val_print): Don't declare.
1424         * valprint.c (generic_val_print_array): Take a struct value.
1425         (generic_val_print_ptr, generic_val_print_memberptr)
1426         (generic_val_print_bool, generic_val_print_int)
1427         (generic_val_print_char, generic_val_print_complex)
1428         (generic_val_print): Remove.
1429         (generic_value_print): Update.
1430         (do_val_print): Remove unused parameters.  Don't call
1431         la_val_print.
1432         (val_print): Remove.
1433         (common_val_print): Update.  Don't call value_check_printable.
1434         (val_print_scalar_formatted, val_print_array_elements): Remove.
1435         * rust-lang.c (rust_val_print): Remove.
1436         (rust_language_defn): Update.
1437         * p-valprint.c (pascal_val_print): Remove.
1438         (pascal_value_print_inner): Update.
1439         (pascal_object_print_val_fields, pascal_object_print_val):
1440         Remove.
1441         (pascal_object_print_static_field): Update.
1442         * p-lang.h (pascal_val_print): Don't declare.
1443         * p-lang.c (pascal_language_defn): Update.
1444         * opencl-lang.c (opencl_language_defn): Update.
1445         * objc-lang.c (objc_language_defn): Update.
1446         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
1447         * m2-lang.h (m2_val_print): Don't declare.
1448         * m2-lang.c (m2_language_defn): Update.
1449         * language.h (struct language_defn) <la_val_print>: Remove.
1450         * language.c (unk_lang_value_print_inner): Rename.  Change
1451         argument types.
1452         (unknown_language_defn, auto_language_defn): Update.
1453         * go-valprint.c (go_val_print): Remove.
1454         * go-lang.h (go_val_print): Don't declare.
1455         * go-lang.c (go_language_defn): Update.
1456         * f-valprint.c (f_val_print): Remove.
1457         * f-lang.h (f_value_print): Don't declare.
1458         * f-lang.c (f_language_defn): Update.
1459         * d-valprint.c (d_val_print): Remove.
1460         * d-lang.h (d_value_print): Don't declare.
1461         * d-lang.c (d_language_defn): Update.
1462         * cp-valprint.c (cp_print_value_fields)
1463         (cp_print_value_fields_rtti, cp_print_value): Remove.
1464         (cp_print_static_field): Update.
1465         * c-valprint.c (c_val_print_array, c_val_print_ptr)
1466         (c_val_print_struct, c_val_print_union, c_val_print_int)
1467         (c_val_print_memberptr, c_val_print): Remove.
1468         * c-lang.h (c_val_print_array, cp_print_value_fields)
1469         (cp_print_value_fields_rtti): Don't declare.
1470         * c-lang.c (c_language_defn, cplus_language_defn)
1471         (asm_language_defn, minimal_language_defn): Update.
1472         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
1473         (ada_val_print_enum): Take a struct value.
1474         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
1475         (ada_val_print): Remove.
1476         (ada_value_print_1): Update.
1477         (printable_val_type): Remove.
1478         * ada-lang.h (ada_val_print): Don't declare.
1479         * ada-lang.c (ada_language_defn): Update.
1480
1481 2020-03-13  Tom Tromey  <tom@tromey.com>
1482
1483         * valprint.c (do_val_print): Update.
1484         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
1485         a struct value.
1486         (value_to_value_object_no_release): Declare.
1487         * python/py-value.c (value_to_value_object_no_release): New
1488         function.
1489         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
1490         struct value.
1491         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
1492         function.
1493         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
1494         a struct value.
1495         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
1496         Declare.
1497         (gdbscm_apply_val_pretty_printer): Take a struct value.
1498         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
1499         value.
1500         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
1501         value.
1502         * extension-priv.h (struct extension_language_ops)
1503         <apply_val_pretty_printer>: Take a struct value.
1504         * cp-valprint.c (cp_print_value): Create a struct value.
1505         (cp_print_value): Update.
1506
1507 2020-03-13  Tom Tromey  <tom@tromey.com>
1508
1509         * ada-valprint.c (print_field_values): Call common_val_print.
1510
1511 2020-03-13  Tom Tromey  <tom@tromey.com>
1512
1513         * ada-valprint.c (val_print_packed_array_elements): Remove
1514         bitoffset and val parameters.  Call common_val_print.
1515         (ada_val_print_string): Remove offset, address, and original_value
1516         parameters.
1517         (ada_val_print_array): Update.
1518         (ada_value_print_array): New function.
1519         (ada_value_print_1): Call it.
1520
1521 2020-03-13  Tom Tromey  <tom@tromey.com>
1522
1523         * ada-valprint.c (ada_value_print): Use common_val_print.
1524
1525 2020-03-13  Tom Tromey  <tom@tromey.com>
1526
1527         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
1528
1529 2020-03-13  Tom Tromey  <tom@tromey.com>
1530
1531         * ada-valprint.c (ada_value_print_num): New function.
1532         (ada_value_print_1): Use it.
1533
1534 2020-03-13  Tom Tromey  <tom@tromey.com>
1535
1536         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
1537
1538 2020-03-13  Tom Tromey  <tom@tromey.com>
1539
1540         * ada-valprint.c (ada_value_print_ptr): New function.
1541         (ada_value_print_1): Use it.
1542
1543 2020-03-13  Tom Tromey  <tom@tromey.com>
1544
1545         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
1546         call common_val_print.
1547         (ada_val_print_1): Update.
1548         (ada_value_print_1): New function.
1549         (ada_value_print_inner): Rewrite.
1550
1551 2020-03-13  Tom Tromey  <tom@tromey.com>
1552
1553         * cp-valprint.c (cp_print_value_fields): Update.
1554         (cp_print_value): New function.
1555
1556 2020-03-13  Tom Tromey  <tom@tromey.com>
1557
1558         * m2-valprint.c (m2_value_print_inner): Use
1559         cp_print_value_fields.
1560         * cp-valprint.c (cp_print_value_fields): New function.
1561         * c-valprint.c (c_value_print_struct): New function.
1562         (c_value_print_inner): Use c_value_print_struct.
1563         * c-lang.h (cp_print_value_fields): Declare.
1564
1565 2020-03-13  Tom Tromey  <tom@tromey.com>
1566
1567         * c-valprint.c (c_value_print_array): New function.
1568         (c_value_print_inner): Use it.
1569
1570 2020-03-13  Tom Tromey  <tom@tromey.com>
1571
1572         * c-valprint.c (c_value_print_memberptr): New function.
1573         (c_value_print_inner): Use it.
1574
1575 2020-03-13  Tom Tromey  <tom@tromey.com>
1576
1577         * c-valprint.c (c_value_print_int): New function.
1578         (c_value_print_inner): Use it.
1579
1580 2020-03-13  Tom Tromey  <tom@tromey.com>
1581
1582         * c-valprint.c (c_value_print_ptr): New function.
1583         (c_value_print_inner): Use it.
1584
1585 2020-03-13  Tom Tromey  <tom@tromey.com>
1586
1587         * c-valprint.c (c_value_print_inner): Rewrite.
1588
1589 2020-03-13  Tom Tromey  <tom@tromey.com>
1590
1591         * valprint.c (generic_value_print_complex): New function.
1592         (generic_value_print): Use it.
1593
1594 2020-03-13  Tom Tromey  <tom@tromey.com>
1595
1596         * valprint.c (generic_val_print_float): Don't call
1597         val_print_scalar_formatted.
1598         (generic_val_print, generic_value_print): Update.
1599
1600 2020-03-13  Tom Tromey  <tom@tromey.com>
1601
1602         * valprint.c (generic_value_print_char): New function
1603         (generic_value_print): Use it.
1604
1605 2020-03-13  Tom Tromey  <tom@tromey.com>
1606
1607         * valprint.c (generic_value_print_int): New function.
1608         (generic_value_print): Use it.
1609
1610 2020-03-13  Tom Tromey  <tom@tromey.com>
1611
1612         * valprint.c (generic_value_print_bool): New function.
1613         (generic_value_print): Use it.
1614
1615 2020-03-13  Tom Tromey  <tom@tromey.com>
1616
1617         * valprint.c (generic_val_print_func): Simplify.
1618         (generic_val_print, generic_value_print): Update.
1619
1620 2020-03-13  Tom Tromey  <tom@tromey.com>
1621
1622         * valprint.c (generic_val_print_flags): Remove.
1623         (generic_val_print, generic_value_print): Update.
1624         (val_print_type_code_flags): Add original_value parameter.
1625
1626 2020-03-13  Tom Tromey  <tom@tromey.com>
1627
1628         * valprint.c (generic_val_print): Update.
1629         (generic_value_print): Update.
1630         * valprint.c (generic_val_print_enum): Don't call
1631         val_print_scalar_formatted.
1632
1633 2020-03-13  Tom Tromey  <tom@tromey.com>
1634
1635         * valprint.c (generic_value_print): Call generic_value_print_ptr.
1636         * valprint.c (generic_value_print_ptr): New function.
1637
1638 2020-03-13  Tom Tromey  <tom@tromey.com>
1639
1640         * valprint.c (generic_value_print): Rewrite.
1641
1642 2020-03-13  Tom Tromey  <tom@tromey.com>
1643
1644         * p-valprint.c (pascal_object_print_value_fields)
1645         (pascal_object_print_value): New functions.
1646
1647 2020-03-13  Tom Tromey  <tom@tromey.com>
1648
1649         * p-valprint.c (pascal_value_print_inner): Rewrite.
1650
1651 2020-03-13  Tom Tromey  <tom@tromey.com>
1652
1653         * f-valprint.c (f_value_print_innner): Rewrite.
1654
1655 2020-03-13  Tom Tromey  <tom@tromey.com>
1656
1657         * m2-valprint.c (m2_print_unbounded_array): New overload.
1658         (m2_print_unbounded_array): Update.
1659         (m2_print_array_contents): Take a struct value.
1660         (m2_value_print_inner): Rewrite.
1661
1662 2020-03-13  Tom Tromey  <tom@tromey.com>
1663
1664         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
1665         (d_value_print_inner): New function.
1666         * d-lang.h (d_value_print_inner): Declare.
1667         * d-lang.c (d_language_defn): Use d_value_print_inner.
1668
1669 2020-03-13  Tom Tromey  <tom@tromey.com>
1670
1671         * go-valprint.c (go_value_print_inner): New function.
1672         * go-lang.h (go_value_print_inner): Declare.
1673         * go-lang.c (go_language_defn): Use go_value_print_inner.
1674
1675 2020-03-13  Tom Tromey  <tom@tromey.com>
1676
1677         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
1678         API.
1679         (rust_val_print): Rewrite.
1680         (rust_value_print_inner): New function, from rust_val_print.
1681         (rust_language_defn): Use rust_value_print_inner.
1682
1683 2020-03-13  Tom Tromey  <tom@tromey.com>
1684
1685         * ada-valprint.c (ada_value_print_inner): New function.
1686         * ada-lang.h (ada_value_print_inner): Declare.
1687         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
1688
1689 2020-03-13  Tom Tromey  <tom@tromey.com>
1690
1691         * f-valprint.c (f_value_print_innner): New function.
1692         * f-lang.h (f_value_print_innner): Declare.
1693         * f-lang.c (f_language_defn): Use f_value_print_innner.
1694
1695 2020-03-13  Tom Tromey  <tom@tromey.com>
1696
1697         * p-valprint.c (pascal_value_print_inner): New function.
1698         * p-lang.h (pascal_value_print_inner): Declare.
1699         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
1700
1701 2020-03-13  Tom Tromey  <tom@tromey.com>
1702
1703         * m2-valprint.c (m2_value_print_inner): New function.
1704         * m2-lang.h (m2_value_print_inner): Declare.
1705         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
1706
1707 2020-03-13  Tom Tromey  <tom@tromey.com>
1708
1709         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
1710         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
1711         * c-valprint.c (c_value_print_inner): New function.
1712         * c-lang.h (c_value_print_inner): Declare.
1713         * c-lang.c (c_language_defn, cplus_language_defn)
1714         (asm_language_defn, minimal_language_defn): Use
1715         c_value_print_inner.
1716
1717 2020-03-13  Tom Tromey  <tom@tromey.com>
1718
1719         * p-valprint.c (pascal_object_print_value_fields): Now static.
1720         * p-lang.h (pascal_object_print_value_fields): Don't declare.
1721
1722 2020-03-13  Tom Tromey  <tom@tromey.com>
1723
1724         * c-valprint.c (c_val_print_array): Simplify.
1725
1726 2020-03-13  Tom Tromey  <tom@tromey.com>
1727
1728         * valprint.c (value_print_array_elements): New function.
1729         * valprint.h (value_print_array_elements): Declare.
1730
1731 2020-03-13  Tom Tromey  <tom@tromey.com>
1732
1733         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
1734         * mips-tdep.c (mips_print_register): Use
1735         value_print_scalar_formatted.
1736
1737 2020-03-13  Tom Tromey  <tom@tromey.com>
1738
1739         * valprint.h (value_print_scalar_formatted): Declare.
1740         * valprint.c (value_print_scalar_formatted): New function.
1741
1742 2020-03-13  Tom Tromey  <tom@tromey.com>
1743
1744         * valprint.h (generic_value_print): Declare.
1745         * valprint.c (generic_value_print): New function.
1746
1747 2020-03-13  Tom Tromey  <tom@tromey.com>
1748
1749         * valprint.c (do_val_print): Call la_value_print_inner, if
1750         available.
1751         * rust-lang.c (rust_language_defn): Update.
1752         * p-lang.c (pascal_language_defn): Update.
1753         * opencl-lang.c (opencl_language_defn): Update.
1754         * objc-lang.c (objc_language_defn): Update.
1755         * m2-lang.c (m2_language_defn): Update.
1756         * language.h (struct language_defn) <la_value_print_inner>: New
1757         member.
1758         * language.c (unknown_language_defn, auto_language_defn): Update.
1759         * go-lang.c (go_language_defn): Update.
1760         * f-lang.c (f_language_defn): Update.
1761         * d-lang.c (d_language_defn): Update.
1762         * c-lang.c (c_language_defn, cplus_language_defn)
1763         (asm_language_defn, minimal_language_defn): Update.
1764         * ada-lang.c (ada_language_defn): Update.
1765
1766 2020-03-13  Tom Tromey  <tom@tromey.com>
1767
1768         * c-valprint.c (c_value_print): Use common_val_print.
1769
1770 2020-03-13  Tom Tromey  <tom@tromey.com>
1771
1772         * cp-valprint.c (cp_print_static_field): Use common_val_print.
1773
1774 2020-03-13  Tom Tromey  <tom@tromey.com>
1775
1776         * f-valprint.c (f77_print_array_1, f_val_print): Use
1777         common_val_print.
1778
1779 2020-03-13  Tom Tromey  <tom@tromey.com>
1780
1781         * riscv-tdep.c (riscv_print_one_register_info): Use
1782         common_val_print.
1783
1784 2020-03-13  Tom Tromey  <tom@tromey.com>
1785
1786         * mi/mi-main.c (output_register): Use common_val_print.
1787
1788 2020-03-13  Tom Tromey  <tom@tromey.com>
1789
1790         * infcmd.c (default_print_one_register_info): Use
1791         common_val_print.
1792
1793 2020-03-13  Tom Tromey  <tom@tromey.com>
1794
1795         * valprint.h (common_val_print_checked): Declare.
1796         * valprint.c (common_val_print_checked): New function.
1797         * stack.c (print_frame_arg): Use common_val_print_checked.
1798
1799 2020-03-13  Tom Tromey  <tom@tromey.com>
1800
1801         * valprint.c (do_val_print): New function, from val_print.
1802         (val_print): Use do_val_print.
1803         (common_val_print): Use do_val_print.
1804
1805 2020-03-13  Tom Tromey  <tom@tromey.com>
1806
1807         * valprint.c (value_print): Use scoped_value_mark.
1808
1809 2020-03-13  Tom de Vries  <tdevries@suse.de>
1810
1811         PR symtab/25646
1812         * psymtab.c (partial_symtab::partial_symtab): Don't set
1813         globals_offset and statics_offset.  Push element onto
1814         current_global_psymbols and current_static_psymbols stacks.
1815         (concat): New function.
1816         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
1817         element from current_global_psymbols and current_static_psymbols
1818         stacks.  Concat popped elements to global_psymbols and
1819         static_symbols.
1820         (add_psymbol_to_list): Use current_global_psymbols and
1821         current_static_psymbols stacks.
1822         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
1823         current_static_psymbols fields.
1824
1825 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1826
1827         * corelow.c (sniff_core_bfd): Remove.
1828         (class core_target) <m_core_vec>: Remove.
1829         (core_target::core_target): Update.
1830         (core_file_fns): Remove.
1831         (deprecated_add_core_fns): Remove.
1832         (default_core_sniffer): Remove.
1833         (sniff_core_bfd): Remove.
1834         (default_check_format): Remove.
1835         (gdb_check_format): Remove.
1836         (core_target_open): Update.
1837         (core_target::get_core_register_section): Update.
1838         (get_core_registers_cb): Update.
1839         (core_target::fetch_registers): Update.
1840         * gdbcore.h (struct core_fns): Remove.
1841         (deprecated_add_core_fns): Remove.
1842         (default_core_sniffer): Remove.
1843         (default_check_format): Remove.
1844
1845 2020-03-12  Tom Tromey  <tom@tromey.com>
1846
1847         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
1848         CORE_ADDR.
1849         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
1850
1851 2020-03-12  Tom Tromey  <tom@tromey.com>
1852
1853         * remote.c (remote_target::download_tracepoint)
1854         (remote_target::enable_tracepoint)
1855         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
1856         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
1857         sprintf_vma.
1858
1859 2020-03-12  Tom Tromey  <tom@tromey.com>
1860
1861         * symfile-mem.c: Update CORE_ADDR size assert.
1862
1863 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1864
1865         * selftest.m4: Move to gdbsupport/.
1866         * acinclude.m4: Update path to selftest.m4.
1867
1868 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1869
1870         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
1871         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
1872         gdbarch-selfselftests.c and selftest-arch.c.
1873         (SUBDIR_UNITTESTS_OBS): Rename to...
1874         (SELFTESTS_OBS): ... this.
1875         (COMMON_SFILES): Remove disasm-selftests.c and
1876         gdbarch-selftests.c.
1877         * configure.ac: Don't add selftest-arch.{c,o} to
1878         CONFIG_{SRCS,OBS}.
1879         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
1880         preprocessor conditions.
1881
1882 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1883
1884         * configure.ac: Don't source bfd/development.sh.
1885         * selftest.m4: Modify comment.
1886         * configure: Re-generate.
1887
1888 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1889
1890         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
1891         not "true" or "false".
1892         * configure: Re-generate.
1893
1894 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1895
1896         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
1897         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
1898         renamed to arm_nbsd_supply_gregset.
1899         (fetch_register): Update to call arm_nbsd_supply_gregset.
1900         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
1901         (arm_netbsd_nat_target::fetch_registers): Update.
1902         (fetch_elfcore_registers): Removed.
1903         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
1904         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
1905         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
1906         not require NetBSD system headers.
1907         (arm_nbsd_regset): New struct.
1908         (arm_nbsd_iterate_over_regset_sections): New function.
1909         (arm_netbsd_init_abi_common): Updated to call
1910         set_gdbarch_iterate_over_regset_sections.
1911         * arm-nbsd-tdep.h: New file.
1912
1913 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
1914
1915         * symtab.c (find_pc_sect_line): Add check which prevents infinite
1916         recursion.
1917
1918 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
1919
1920         * configure: Re-generate.
1921
1922 2020-03-11  Tom Tromey  <tromey@adacore.com>
1923
1924         * ada-typeprint.c (print_choices): Fix comment.
1925
1926 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1927
1928         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
1929         previous item in the list, when the list has no items.
1930
1931 2020-03-11  Tom de Vries  <tdevries@suse.de>
1932
1933         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
1934         PROP_LOCLIST handling code.
1935
1936 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         * buildsym-legacy.c (record_line): Pass extra parameter to
1939         record_line.
1940         * buildsym.c (buildsym_compunit::record_line): Take an extra
1941         parameter, reduce duplication in the line table, and record the
1942         is_stmt flag in the line table.
1943         * buildsym.h (buildsym_compunit::record_line): Add extra
1944         parameter.
1945         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
1946         non-statement lines.
1947         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
1948         this to the symtab builder.
1949         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
1950         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
1951         through to dwarf_record_line_1.
1952         * infrun.c (process_event_stop_test): When stepping, don't stop at
1953         a non-statement instruction, and only refresh the step info when
1954         we land in the middle of a line's range.  Also add an extra
1955         comment.
1956         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
1957         field.
1958         * record-btrace.c (btrace_find_line_range): Only record lines
1959         marked as is-statement.
1960         * stack.c (frame_show_address): Show the frame address if we are
1961         in a non-statement sal.
1962         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
1963         (maintenance_print_one_line_table): Print a header for the is_stmt
1964         column, and include is_stmt information in the output.
1965         * symtab.c (find_pc_sect_line): Find lines marked as statements in
1966         preference to non-statements.
1967         (find_pcs_for_symtab_line): Prefer is-statement entries.
1968         (find_line_common): Likewise.
1969         * symtab.h (struct linetable_entry): Add is_stmt field.
1970         (struct symtab_and_line): Likewise.
1971         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
1972         arranging the line table.
1973
1974 2020-03-07  Tom de Vries  <tdevries@suse.de>
1975
1976         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
1977         DIE.
1978
1979 2020-03-07  Tom Tromey  <tom@tromey.com>
1980
1981         * valops.c (value_literal_complex): Remove obsolete comment.
1982         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
1983         comment.
1984
1985 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
1986
1987         * infrun.h: Forward-declare thread_info.
1988         (set_step_info): Add thread_info parameter, add doc.
1989         * infrun.c (set_step_info): Add thread_info parameter, move doc
1990         to header.
1991         * infrun.c (process_event_stop_test): Pass thread to
1992         set_step_info call.
1993         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
1994         set_step_info.
1995         (prepare_one_step): Add thread_info parameter, pass it to
1996         set_step_frame and prepare_one_step (recursive) call.
1997         (step_1): Pass thread to prepare_one_step call.
1998         (step_command_fsm::should_stop): Pass thread to
1999         prepare_one_step.
2000         (until_next_fsm): Pass thread to set_step_frame call.
2001         (finish_command): Pass thread to set_step_info call.
2002
2003 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
2004
2005         * windows-tdep.c (windows_solib_create_inferior_hook):
2006         Check if inferior is running.
2007
2008 2020-03-06  Tom de Vries  <tdevries@suse.de>
2009
2010         * NEWS: Fix "the the".
2011         * ctfread.c: Same.
2012
2013 2020-03-06  Tom de Vries  <tdevries@suse.de>
2014
2015         * psymtab.c (psymtab_to_symtab): Don't print "done.".
2016
2017 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * .dir-locals.el: Add a comment referencing the other copies of
2020         this file.
2021
2022 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
2023
2024         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
2025         psargs.
2026
2027 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2028
2029         * .gitattributes: New file.
2030
2031 2020-03-04  Tom Tromey  <tom@tromey.com>
2032
2033         * symmisc.c (print_symbol_bcache_statistics)
2034         (print_objfile_statistics): Update.
2035         * symfile.c (allocate_symtab): Use intern.
2036         * psymtab.c (partial_symtab::partial_symtab): Use intern.
2037         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2038         macro_cache>: Remove.
2039         <string_cache>: New member.
2040         (struct objfile) <intern>: New methods.
2041         * elfread.c (elf_symtab_read): Use intern.
2042         * dwarf2/read.c (fixup_go_packaging): Intern package name.
2043         (dwarf2_compute_name, dwarf2_physname)
2044         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
2045         names.
2046         (guess_partial_die_structure_name): Update.
2047         (partial_die_info::fixup): Intern name.
2048         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
2049         name.
2050         (dwarf2_name): Intern name.  Update.
2051         * buildsym.c (buildsym_compunit::get_macro_table): Use
2052         string_cache.
2053
2054 2020-03-04  Tom Tromey  <tom@tromey.com>
2055
2056         * jit.c (bfd_open_from_target_memory): Make "target" const.
2057         * corefile.c (gnutarget): Now const.
2058         * gdbcore.h (gnutarget): Now const.
2059
2060 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
2061
2062         * NEWS: Mention support for WOW64 processes.
2063         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
2064         (amd64_windows_segment_register_p): Remove static.
2065         (_initialize_amd64_windows_nat): Update.
2066         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
2067         * i386-windows-nat.c (context_offset): Update.
2068         (i386_mappings): Rename and remove static.
2069         (i386_windows_segment_register_p): Remove static.
2070         (_initialize_i386_windows_nat): Update.
2071         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
2072         (STATUS_WX86_SINGLE_STEP): New macro.
2073         (EnumProcessModulesEx): New macro.
2074         (Wow64SuspendThread): New macro.
2075         (Wow64GetThreadContext): New macro.
2076         (Wow64SetThreadContext): New macro.
2077         (Wow64GetThreadSelectorEntry): New macro.
2078         (windows_set_context_register_offsets): Add static.
2079         (windows_set_segment_register_p): Likewise.
2080         (windows_add_thread): Adapt for WOW64 processes.
2081         (windows_fetch_one_register): Likewise.
2082         (windows_nat_target::fetch_registers): Likewise.
2083         (windows_store_one_register): Likewise.
2084         (display_selector): Likewise.
2085         (display_selectors): Likewise.
2086         (handle_exception): Likewise.
2087         (windows_continue): Likewise.
2088         (windows_nat_target::resume): Likewise.
2089         (windows_add_all_dlls): Likewise.
2090         (do_initial_windows_stuff): Likewise.
2091         (windows_nat_target::attach): Likewise.
2092         (windows_get_exec_module_filename): Likewise.
2093         (windows_nat_target::create_inferior): Likewise.
2094         (windows_xfer_siginfo): Likewise.
2095         (_initialize_loadable): Initialize Wow64SuspendThread,
2096         Wow64GetThreadContext, Wow64SetThreadContext,
2097         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
2098         * windows-nat.h (windows_set_context_register_offsets):
2099         Remove declaration.
2100         (windows_set_segment_register_p): Likewise.
2101         (i386_windows_segment_register_p): Add declaration.
2102         (amd64_windows_segment_register_p): Likewise.
2103
2104 2020-03-04  Luis Machado  <luis.machado@linaro.org>
2105
2106         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
2107         in "info registers" for AArch64/ARM.
2108
2109         The change caused "info registers" to not print GPR's.
2110
2111         gdb/ChangeLog:
2112
2113         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
2114
2115         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
2116         when reg->group is empty and reggroup is not.
2117
2118 2020-03-03  Tom Tromey  <tromey@adacore.com>
2119
2120         * dwarf2/frame.c (struct dwarf2_frame_cache)
2121         <checked_tailcall_bottom, entry_cfa_sp_offset,
2122         entry_cfa_sp_offset_p>: Remove members.
2123         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
2124         (dwarf2_frame_prev_register): Don't call
2125         dwarf2_tailcall_sniffer_first.
2126         (dwarf2_append_unwinders): Don't append tailcall unwinder.
2127         * frame-unwind.c (add_unwinder): New fuction.
2128         (frame_unwind_init): Use it.  Add tailcall unwinder.
2129
2130 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2131             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2132
2133         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
2134         value should be printed as true.
2135
2136 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
2137
2138         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
2139         (windows_init_abi): Set and use windows_so_ops.
2140
2141 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
2142
2143         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
2144         when verifying if dealing with a convenience variable.
2145
2146 2020-03-03  Luis Machado  <luis.machado@linaro.org>
2147
2148         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
2149
2150 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2151
2152         * infrun.c (gdbarch_supports_displaced_stepping): New.
2153         (use_displaced_stepping): Break up conditions in smaller pieces.
2154         Use gdbarch_supports_displaced_stepping.
2155         (displaced_step_prepare_throw): Use
2156         gdbarch_supports_displaced_stepping.
2157
2158 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2159
2160         * NEWS: Mention new behaviour of the history filename.
2161         * top.c (write_history_p): Add comment.
2162         (show_write_history_p): Add header comment, give a different
2163         message when history writing is on, but the history filename is
2164         empty.
2165         (history_filename): Add comment.
2166         (history_filename_empty): New function.
2167         (show_history_filename): Add header comment, give a different
2168         message when the filename is empty.
2169         (init_history): Compare history_filename against nullptr, and only
2170         read history if the filename is not empty.
2171         (set_history_filename): Add header comment, and only make
2172         non-empty filenames absolute.
2173         (init_main): Make the filename argument to 'set history filename'
2174         optional.
2175
2176 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
2177
2178         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
2179         (arm_supply_vfpregset): ...this, and update to use VFP registers.
2180         (fetch_fp_register): Update.
2181         (fetch_fp_regs): Update.
2182         (store_fp_register): Update.
2183         (store_fp_regs): Update.
2184         (arm_netbsd_nat_target::read_description): New function.
2185         (fetch_elfcore_registers): Update.
2186
2187 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2188
2189         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
2190         general_thread if the stop reply is missing a thread-id.
2191         (remote_target::process_stop_reply): Use the first non-exited
2192         thread if the target didn't pass a thread-id.
2193         * infrun.c (do_target_wait): Move call to
2194         switch_to_inferior_no_thread to ....
2195         (do_target_wait_1): ... here.
2196
2197 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
2198
2199         * debuginfod-support.c: Include defs.h first.
2200
2201 2020-02-28  Tom de Vries  <tdevries@suse.de>
2202
2203         * symfile.c (set_initial_language): Use default language for lookup.
2204
2205 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
2206
2207         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
2208         reader variable, pass `this` to read_cutu_die_from_dwo.
2209
2210 2020-02-27  Aaron Merey  <amerey@redhat.com>
2211
2212         * source.c (open_source_file): Check for nullptr when computing
2213         srcpath.
2214
2215 2020-02-27  Tom Tromey  <tromey@adacore.com>
2216
2217         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
2218         member.
2219         (dwarf2_add_field): Don't update nfields.
2220         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
2221
2222 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
2225         abs.
2226
2227 2020-02-26  Tom Tromey  <tom@tromey.com>
2228
2229         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
2230         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
2231         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
2232         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
2233         per_cu_data.
2234
2235 2020-02-26  Tom Tromey  <tom@tromey.com>
2236
2237         * dwarf2/index-write.c (psym_index_map): Change type.
2238         (add_address_entry_worker, write_one_signatured_type)
2239         (recursively_count_psymbols, recursively_write_psymbols)
2240         (class debug_names, psyms_seen_size, write_gdbindex)
2241         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
2242
2243 2020-02-26  Aaron Merey  <amerey@redhat.com>
2244
2245         * Makefile.in: Handle optional debuginfod support.
2246         * NEWS: Update.
2247         * README: Add --with-debuginfod summary.
2248         * config.in: Regenerate.
2249         * configure: Regenerate.
2250         * configure.ac: Handle optional debuginfod support.
2251         * debuginfod-support.c: debuginfod helper functions.
2252         * debuginfod-support.h: Ditto.
2253         * doc/gdb.texinfo: Add --with-debuginfod to configure options
2254         summary.
2255         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
2256         when a dwz file cannot be found.
2257         * elfread.c (elf_symfile_read): Query debuginfod servers when a
2258         debuginfo file cannot be found.
2259         * source.c (open_source_file): Query debuginfod servers when a
2260         source file cannot be found.
2261         * top.c (print_gdb_configuration): Include
2262         --{with,without}-debuginfod in the output.
2263
2264 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
2265
2266         * thread.c (thr_try_catch_cmd): Print thread name.
2267
2268 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
2269
2270         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
2271         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2272         dwarf2_fetch_die_type_sect_off): Move to...
2273         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2274         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2275         dwarf2_fetch_die_type_sect_off): ... here.
2276         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2277         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2278         dwarf2_fetch_die_type_sect_off): Move doc to header file.
2279
2280 2020-02-26  Tom de Vries  <tdevries@suse.de>
2281
2282         PR gdb/25603
2283         * symfile.c (set_initial_language): Exit-early if
2284         language_mode == language_mode_manual.
2285
2286 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
2287
2288         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
2289         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
2290         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
2291
2292 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         * gdbtypes.c (create_array_type_with_stride): Handle negative
2295         array strides.
2296         * valarith.c (value_subscripted_rvalue): Likewise.
2297
2298 2020-02-25  Luis Machado  <luis.machado@linaro.org>
2299
2300         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
2301
2302 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
2303
2304         * loc.h (dwarf2_get_die_type): Move to...
2305         * read.h (dwarf2_get_die_type): ... here.
2306         * read.c (dwarf2_get_die_type): Move doc to header.
2307
2308 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
2309
2310         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
2311         'gnulib/Makefile.in' to the list.
2312
2313 2020-02-24  Tom Tromey  <tom@tromey.com>
2314
2315         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
2316         Remove.
2317         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
2318         XOBNEWVEC.
2319
2320 2020-02-24  Tom Tromey  <tom@tromey.com>
2321
2322         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
2323         New method.
2324         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
2325         (dw2_do_instantiate_symtab, dw2_get_file_names)
2326         (build_type_psymtab_dependencies, load_full_type_unit): Update.
2327
2328 2020-02-24  Tom Tromey  <tom@tromey.com>
2329
2330         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
2331         make_scoped_restore.
2332         (dwarf2_psymtab::read_symtab): Don't clear
2333         reading_partial_symbols.
2334
2335 2020-02-24  Tom de Vries  <tdevries@suse.de>
2336
2337         PR gdb/25592
2338         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
2339
2340 2020-02-24  Tom de Vries  <tdevries@suse.de>
2341
2342         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
2343         commands layout next/prev/regs.
2344
2345 2020-02-22  Tom Tromey  <tom@tromey.com>
2346
2347         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
2348         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
2349
2350 2020-02-22  Tom Tromey  <tom@tromey.com>
2351
2352         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
2353
2354 2020-02-22  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui-win.c (_initialize_tui_win): Add usage text.
2357         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
2358         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
2359         * tui/tui.c (_initialize_tui): Add usage text.
2360
2361 2020-02-22  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-win.c (tui_set_focus_command)
2364         (tui_set_win_height_command): Use error_no_arg.
2365         (_initialize_tui_win): Update help text.
2366         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
2367
2368 2020-02-22  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
2371         * tui/tui-disasm.h (struct tui_disasm_window)
2372         <display_start_addr>: Declare.
2373         * tui/tui-source.h (struct tui_source_window)
2374         <display_start_addr>: Declare.
2375         * tui/tui-winsource.h (struct tui_source_window_base)
2376         <show_source_line, display_start_addr>: New methods.
2377         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
2378         Rename and move to protected section.
2379         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
2380         (tui_source_window_base::do_erase_source_content): Update.
2381         (tui_source_window_base::show_source_line): Now a method.
2382         (tui_source_window_base::show_source_content)
2383         (tui_source_window_base::tui_source_window_base)
2384         (tui_source_window_base::rerender)
2385         (tui_source_window_base::refill)
2386         (tui_source_window_base::do_scroll_horizontal)
2387         (tui_source_window_base::set_is_exec_point_at)
2388         (tui_source_window_base::update_breakpoint_info)
2389         (tui_source_window_base::update_exec_info): Update.
2390         * tui/tui-source.c (tui_source_window::set_contents)
2391         (tui_source_window::showing_source_p)
2392         (tui_source_window::do_scroll_vertical)
2393         (tui_source_window::location_matches_p)
2394         (tui_source_window::line_is_displayed): Update.
2395         (tui_source_window::display_start_addr): New method.
2396         * tui/tui-disasm.c (tui_disasm_window::set_contents)
2397         (tui_disasm_window::do_scroll_vertical)
2398         (tui_disasm_window::location_matches_p): Update.
2399         (tui_disasm_window::display_start_addr): New method.
2400
2401 2020-02-22  Tom Tromey  <tom@tromey.com>
2402
2403         * NEWS: Add entry for gdb.register_window_type.
2404         * tui/tui-layout.h (window_factory): New typedef.
2405         (tui_register_window): Declare.
2406         * tui/tui-layout.c (saved_tui_windows): New global.
2407         (tui_apply_current_layout): Use it.
2408         (tui_register_window): New function.
2409         * python/python.c (do_start_initialization): Call
2410         gdbpy_initialize_tui.
2411         (python_GdbMethods): Add "register_window_type" function.
2412         * python/python-internal.h (gdbpy_register_tui_window)
2413         (gdbpy_initialize_tui): Declare.
2414         * python/py-tui.c: New file.
2415         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
2416
2417 2020-02-22  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
2420
2421 2020-02-22  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
2424         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
2425         * tui/tui-data.c (tui_set_win_with_focus): Remove.
2426         (tui_set_win_focus_to): Move from tui-win.c.
2427
2428 2020-02-22  Tom Tromey  <tom@tromey.com>
2429
2430         * tui/tui-layout.c (make_standard_window, get_locator_window): New
2431         functions.
2432         (known_window_types): New global.
2433         (tui_get_window_by_name): Reimplement.
2434         (initialize_known_windows): New function.
2435         (validate_window_name): Rewrite.
2436         (_initialize_tui_layout): Call initialize_known_windows.
2437
2438 2020-02-22  Tom Tromey  <tom@tromey.com>
2439
2440         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
2441         Remove constants.
2442         * tui/tui-winsource.h (struct tui_source_window_base)
2443         <tui_source_window_base>: Remove parameter.
2444         * tui/tui-winsource.c
2445         (tui_source_window_base::tui_source_window_base): Remove
2446         parameter.
2447         (tui_source_window_base::refill): Update.
2448         * tui/tui-stack.h (struct tui_locator_window)
2449         <tui_locator_window>: Update.
2450         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
2451         Default the constructor.
2452         * tui/tui-regs.h (struct tui_data_item_window)
2453         <tui_data_item_window>: Default the constructor.
2454         (struct tui_data_window) <tui_data_window>: Likewise.
2455         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
2456         Default the constructor.
2457         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
2458         Default the constructor.
2459         <type>: Remove.
2460         (struct tui_win_info) <tui_win_info>: Default the constructor.
2461         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
2462         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2463         Default the constructor.
2464
2465 2020-02-22  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
2468         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
2469         * tui/tui-win.c (tui_resize_all): Don't call
2470         tui_delete_invisible_windows.
2471         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
2472         done.
2473         (tui_set_layout): Update.
2474         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
2475         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
2476         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
2477
2478 2020-02-22  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
2481         correctly.
2482
2483 2020-02-22  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
2486
2487 2020-02-22  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-winsource.h (struct tui_source_window_iterator)
2490         <inner_iterator>: New etytypedef.
2491         <tui_source_window_iterator>: Take "end" parameter.
2492         <tui_source_window_iterator>: Take iterator.
2493         <operator*, advance>: Update.
2494         <m_iter>: Change type.
2495         <m_end>: New field.
2496         (struct tui_source_windows) <begin, end>: Update.
2497         * tui/tui-layout.c (tui_windows): New global.
2498         (tui_apply_current_layout): Clear tui_windows.
2499         (tui_layout_window::apply): Update tui_windows.
2500         * tui/tui-data.h (tui_windows): Declare.
2501         (all_tui_windows): Now inline function.
2502         (class tui_window_iterator, struct all_tui_windows): Remove.
2503
2504 2020-02-22  Tom Tromey  <tom@tromey.com>
2505
2506         PR tui/17850:
2507         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
2508         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
2509         "height" argument.
2510         (class tui_layout_window) <get_sizes>: Likewise.
2511         (class tui_layout_split) <tui_layout_split>: Add "vertical"
2512         argument.
2513         <get_sizes>: Add "height" argument.
2514         <m_vertical>: New field.
2515         * tui/tui-layout.c (tui_layout_split::clone): Update.
2516         (tui_layout_split::get_sizes): Add "height" argument.
2517         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
2518         (tui_new_layout_command): Parse "-horizontal".
2519         (_initialize_tui_layout): Update help string.
2520         (tui_layout_split::specification): Add "-horizontal" when needed.
2521         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
2522         argument.
2523         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
2524         New methods.
2525
2526 2020-02-22  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-layout.h (enum tui_adjust_result): New.
2529         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
2530         (class tui_layout_window) <adjust_size>: Return
2531         tui_adjust_result.  Rewrite.
2532         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
2533         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
2534
2535 2020-02-22  Tom Tromey  <tom@tromey.com>
2536
2537         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
2538         parameter and return types.
2539         (class tui_layout_base) <specification>: Add "depth".
2540         (class tui_layout_window) <specification>: Add "depth".
2541         (class tui_layout_split) <specification>: Add "depth".
2542         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
2543         and return types.
2544         (tui_new_layout_command): Parse sub-layouts.
2545         (_initialize_tui_layout): Update help string.
2546         (tui_layout_window::specification): Add "depth".
2547         (add_layout_command): Update.
2548
2549 2020-02-22  Tom Tromey  <tom@tromey.com>
2550
2551         * NEWS: Add "tui new-layout" item.
2552         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
2553         Add new-layout command to help text.
2554         (validate_window_name): New function.
2555         (tui_new_layout_command): New function.
2556         (_initialize_tui_layout): Register "new-layout".
2557         (tui_layout_window::specification): New method.
2558         (tui_layout_window::specification): New method.
2559         * tui/tui-layout.h (class tui_layout_base) <specification>: New
2560         method.
2561         (class tui_layout_window) <specification>: New method.
2562         (class tui_layout_split) <specification>: New method.
2563
2564 2020-02-22  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
2567         * tui/tui-win.c (window_name_completer): Update comment.
2568         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
2569         Declare method.
2570         (class tui_layout_window) <replace_window>: Likewise.
2571         (class tui_layout_split) <replace_window>: Likewise.
2572         (tui_set_layout): Don't declare.
2573         (tui_set_initial_layout): Declare function.
2574         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
2575         (asm_regs_layout): New globals.
2576         (tui_current_layout, show_layout): Remove.
2577         (tui_set_layout, tui_add_win_to_layout): Rewrite.
2578         (find_layout, tui_apply_layout): New function.
2579         (layout_completer): Remove.
2580         (tui_next_layout): Reimplement.
2581         (tui_next_layout_command): New function.
2582         (tui_set_initial_layout, tui_prev_layout_command): New functions.
2583         (tui_regs_layout): Reimplement.
2584         (tui_regs_layout_command): New function.
2585         (extract_display_start_addr): Rewrite.
2586         (next_layout, prev_layout): Remove.
2587         (tui_layout_window::replace_window): New method.
2588         (tui_layout_split::replace_window): New method.
2589         (destroy_layout): New function.
2590         (layout_list): New global.
2591         (add_layout_command): New function.
2592         (initialize_layouts): Update.
2593         (tui_layout_command): New function.
2594         (_initialize_tui_layout): Install "layout" commands.
2595         * tui/tui-data.h (enum tui_layout_type): Remove.
2596         (tui_current_layout): Don't declare.
2597
2598 2020-02-22  Tom Tromey  <tom@tromey.com>
2599
2600         * tui/tui-regs.c (tui_reg_layout): Remove.
2601         (tui_reg_command): Use tui_regs_layout.
2602         * tui/tui-layout.h (tui_reg_command): Declare.
2603         * tui/tui-layout.c (tui_reg_command): New function.
2604
2605 2020-02-22  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui.c (tui_rl_delete_other_windows): Call
2608         tui_remove_some_windows.
2609         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
2610         Declare method.
2611         (class tui_layout_window) <remove_windows>: New method.
2612         (class tui_layout_split) <remove_windows>: Declare.
2613         (tui_remove_some_windows): Declare.
2614         * tui/tui-layout.c (tui_remove_some_windows): New function.
2615         (tui_layout_split::remove_windows): New method.
2616
2617 2020-02-22  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
2620         * tui/tui-layout.h (tui_next_layout): Declare.
2621         * tui/tui-layout.c (tui_next_layout): New function.
2622
2623 2020-02-22  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
2626         correct coordinates.
2627
2628 2020-02-22  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
2631         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
2632         DATA_WIN case.
2633
2634 2020-02-22  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
2637         TUI_DISASM_WIN, not tui_win_list.
2638
2639 2020-02-22  Tom Tromey  <tom@tromey.com>
2640
2641         * valprint.c (generic_val_print_enum_1)
2642         (val_print_type_code_flags): Style member names.
2643         * rust-lang.c (val_print_struct, rust_print_enum)
2644         (rust_print_struct_def, rust_internal_print_type): Style member
2645         names.
2646         * p-valprint.c (pascal_object_print_value_fields): Style member
2647         names.  Only call fprintf_symbol_filtered for static members.
2648         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
2649         * f-valprint.c (f_val_print): Style member names.
2650         * f-typeprint.c (f_type_print_base): Style member names.
2651         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
2652         call fprintf_symbol_filtered for static members.
2653         (cp_print_class_member): Style member names.
2654         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
2655         member names.
2656         * ada-valprint.c (ada_print_scalar): Style enum names.
2657         (ada_val_print_enum): Likewise.
2658         * ada-typeprint.c (print_enum_type): Style enum names.
2659
2660 2020-02-21  Tom Tromey  <tom@tromey.com>
2661
2662         * psympriv.h (struct partial_symtab): Update comment.
2663
2664 2020-02-21  Tom Tromey  <tromey@adacore.com>
2665
2666         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
2667         type is CORE_ADDR.
2668
2669 2020-02-21  Tom de Vries  <tdevries@suse.de>
2670
2671         PR gdb/25534
2672         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
2673         if dependencies[i]->user != NULL.
2674
2675 2020-02-21  Ali Tamur  <tamur@google.com>
2676
2677         * dwarf2/read.c (dwarf2_name): Add null check.
2678
2679 2020-02-20  Tom Tromey  <tom@tromey.com>
2680
2681         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
2682         ">=", in binary search.
2683         (dwarf2_find_containing_comp_unit): New overload.
2684         (run_test): New self-test.
2685         (_initialize_dwarf2_read): Register new test.
2686
2687 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
2688
2689         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
2690         * riscv-tdep.h: Likewise.
2691         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
2692         rv32-only CSR.
2693         * features/riscv/64bit-csr.xml: Regenerated.
2694
2695 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
2696             Tom Tromey  <tom@tromey.com>
2697
2698         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
2699         of 'fputc_unfiltered'.
2700         (putchar_unfiltered): Call 'fputc_unfiltered'.
2701         (fputc_unfiltered): Call 'fputs_unfiltered'.
2702
2703 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * config.in: Regenerate.
2706         * configure: Regenerate.
2707         * configure.ac: Add --with-python-libdir option.
2708         * main.c: Use WITH_PYTHON_LIBDIR.
2709
2710 2020-02-19  Tom Tromey  <tom@tromey.com>
2711
2712         * symtab.c (general_symbol_info::compute_and_set_names): Use
2713         obstack_strndup.  Simplify call to symbol_set_demangled_name.
2714
2715 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
2716
2717         * dwarf2/read.c (allocate_signatured_type_table,
2718         allocate_dwo_unit_table, allocate_type_unit_groups_table,
2719         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
2720         Remove objfile parameter, update all callers.
2721
2722 2020-02-19  Doug Evans  <dje@google.com>
2723
2724         PR rust/25535
2725         * rust-lang.c (rust_print_enum): Apply embedded_offset to
2726         rust_enum_variant calculation.
2727
2728 2020-02-19  Tom Tromey  <tromey@adacore.com>
2729
2730         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
2731
2732 2020-02-19  Tom Tromey  <tromey@adacore.com>
2733
2734         * ada-lang.c (cache_symbol): Use obstack_strdup.
2735
2736 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * configure: Regenerate.
2739
2740 2020-02-19  Tom Tromey  <tromey@adacore.com>
2741
2742         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
2743         NULL check.
2744
2745 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
2746
2747         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
2748
2749 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
2752         if GDBSERVER is not defined.
2753         (riscv_tdesc_cache): Likewise, also store const target_desc.
2754         (STATIC_IN_GDB): Define.
2755         (riscv_create_target_description): Update declaration with
2756         STATIC_IN_GDB.
2757         (riscv_lookup_target_description): New function, only define if
2758         GDBSERVER is not defined.
2759         * arch/riscv.h (riscv_create_target_description): Declare only
2760         when GDBSERVER is defined.
2761         (riscv_lookup_target_description): New declaration when GDBSERVER
2762         is not defined.
2763         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
2764         (riscv_linux_read_features): ...this, and return
2765         riscv_gdbarch_features instead of target_desc.
2766         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
2767         (riscv_linux_read_description): Rename to...
2768         (riscv_linux_read_features): ...this.
2769         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
2770         Update to use riscv_gdbarch_features and
2771         riscv_lookup_target_description.
2772         * riscv-tdep.c (riscv_find_default_target_description): Use
2773         riscv_lookup_target_description instead of
2774         riscv_create_target_description.
2775
2776 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2777
2778         * valprint.c (generic_val_print_enum_1): When printing a flag
2779         enum with value 0 and there is no enumerator with value 0, print
2780         just "0" instead of "(unknown: 0x0)".
2781
2782 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2783
2784         * valprint.c (generic_val_print_enum_1): Print unknown part of
2785         flag enum in hex.
2786
2787 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2788
2789         * dwarf2/read.c (update_enumeration_type_from_children): Allow
2790         flag enums to contain duplicate enumerators.
2791         * valprint.c (generic_val_print_enum_1): Update comment.
2792
2793 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2794
2795         * dwarf2/read.c: Include "count-one-bits.h".
2796         (update_enumeration_type_from_children): If an enumerator has
2797         multiple bits set, don't treat the enumeration as a "flag enum".
2798         * valprint.c (generic_val_print_enum_1): Assert that enumerators
2799         of flag enums have 0 or 1 bit set.
2800
2801 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2802
2803         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
2804         conversion.
2805         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2806         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2807         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2808         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2809         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2810
2811 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2812
2813         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
2814
2815 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2816
2817         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
2818         displaced_step_closure_up.
2819         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2820         (struct displaced_step_closure_up):
2821         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2822         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2823         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
2824         Likewise.
2825         * gdbarch.sh (displaced_step_copy_insn): Likewise.
2826         * gdbarch.c, gdbarch.h: Re-generate.
2827         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
2828         displaced_step_closure_up.
2829         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2830         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2831         * infrun.h (displaced_step_closure_up): New type alias.
2832         (struct displaced_step_inferior_state) <step_closure>: Change
2833         type to displaced_step_closure_up.
2834         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
2835         displaced_step_closure_up.
2836         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2837
2838 2020-02-14  Tom Tromey  <tom@tromey.com>
2839
2840         * minidebug.c (gnu_debug_key): New global.
2841         (find_separate_debug_file_in_section): Use it.
2842
2843 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2844
2845         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
2846         std::unique_ptr.
2847         * gdbarch.c: Re-generate.
2848         * gdbarch.h: Re-generate.
2849         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
2850         change.
2851         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
2852         type to std::unique_ptr.
2853         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2854         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2855         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2856         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2857         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
2858         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2859         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2860         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2861         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2862
2863 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2864
2865         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
2866         std::unique_ptr.
2867         (displaced_step_clear): Rename to...
2868         (displaced_step_reset): ... this.  Just call displaced->reset ().
2869         (displaced_step_clear_cleanup): Rename to...
2870         (displaced_step_reset_cleanup): ... this.
2871         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
2872         (displaced_step_fixup): Likewise.
2873         (resume_1): Likewise.
2874         (handle_inferior_event): Restore child's memory before calling
2875         displaced_step_fixup on the parent.
2876         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
2877         to std::unique_ptr.
2878         <step_closure>: Change type to std::unique_ptr.
2879
2880 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2881
2882         * arm-tdep.c: Include count-one-bits.h.
2883         (cleanup_block_store_pc): Use count_one_bits.
2884         (cleanup_block_load_pc): Use count_one_bits.
2885         (arm_copy_block_xfer): Use count_one_bits.
2886         (thumb2_copy_block_xfer): Use count_one_bits.
2887         (thumb_copy_pop_pc_16bit): Use count_one_bits.
2888         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
2889         (thumb_get_next_pcs_raw): Use count_one_bits.
2890         (arm_get_next_pcs_raw): Use count_one_bits_l.
2891         * arch/arm.c (bitcount): Remove.
2892         * arch/arm.h (bitcount): Remove.
2893
2894 2020-02-14  Tom Tromey  <tromey@adacore.com>
2895
2896         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
2897         Update.
2898         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
2899         * dwarf2/loc.c (call_site_find_chain_1): Return
2900         unique_xmalloc_ptr.
2901         (call_site_find_chain): Likewise.
2902
2903 2020-02-14  Richard Biener  <rguenther@suse.de>
2904
2905         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
2906         on expression with division operators.
2907
2908 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2909
2910         * MAINTAINERS (Write After Approval): Adding myself.
2911
2912 2020-02-12  Tom Tromey  <tom@tromey.com>
2913
2914         * event-loop.c (event_data, gdb_event, event_handler_func):
2915         Remove.
2916
2917 2020-02-12  Tom Tromey  <tom@tromey.com>
2918
2919         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
2920         (dwarf2_frame_objfile_data): Add comment.
2921         (find_comp_unit, set_comp_unit): New functions.
2922         (dwarf2_frame_find_fde): Use find_comp_unit.
2923         (dwarf2_build_frame_info): Use set_comp_unit.
2924
2925 2020-02-12  Tom Tromey  <tom@tromey.com>
2926
2927         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
2928         (comp_unit): Don't initialize objfile.
2929         (execute_cfa_program): Add text_offset parameter.
2930         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
2931         (dwarf2_frame_cache): Update.
2932         (dwarf2_build_frame_info): Don't set "objfile" member.
2933
2934 2020-02-12  Tom Tromey  <tom@tromey.com>
2935
2936         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
2937         (decode_frame_entry): Likewise.
2938         (dwarf2_build_frame_info): Update.
2939
2940 2020-02-12  Tom Tromey  <tom@tromey.com>
2941
2942         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
2943         (decode_frame_entry_1): Use the comp_unit obstack.
2944
2945 2020-02-12  Tom Tromey  <tom@tromey.com>
2946
2947         * dwarf2/frame.c (struct comp_unit): Add initializers and
2948         constructor.
2949         (dwarf2_frame_objfile_data): Store a comp_unit.
2950         (dwarf2_frame_find_fde): Update.
2951         (dwarf2_build_frame_info): Use "new".
2952
2953 2020-02-12  Tom Tromey  <tom@tromey.com>
2954
2955         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
2956         (dwarf2_fde_table): Typedef for std::vector.
2957         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
2958         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
2959         (decode_frame_entry): Update.
2960         (dwarf2_build_frame_info): Use "new".
2961
2962 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2963
2964         * arm-tdep.c (arm_gdbarch_init): Update.
2965         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
2966         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
2967         have_neon, is_m>: Change to bool.
2968
2969 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2970
2971         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
2972
2973 2020-02-12  Tom Tromey  <tom@tromey.com>
2974
2975         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
2976
2977 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
2978
2979         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
2980         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
2981
2982 2020-02-11  Tom Tromey  <tom@tromey.com>
2983
2984         * psymtab.h: Update comment.
2985
2986 2020-02-11  Tom Tromey  <tom@tromey.com>
2987
2988         * gdb_obstack.h (struct auto_obstack): Use
2989         DISABLE_COPY_AND_ASSIGN.
2990
2991 2020-02-11  Tom Tromey  <tom@tromey.com>
2992
2993         * dwarf2/frame.h (struct objfile): Don't forward declare.
2994
2995 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2996
2997         * cris-tdep.c (cris_supply_gregset): Change signature to match
2998         what struct regset expects.
2999         (cris_regset): New struct.
3000         (fetch_core_registers): Remove.
3001         (cris_iterate_over_regset_sections): New function.
3002         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
3003         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
3004
3005 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3006
3007         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
3008         registers.
3009
3010 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3011
3012         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
3013
3014 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3015
3016         * configure: Re-generate.
3017
3018 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3019
3020         * configure: Re-generate.
3021
3022 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3023
3024         * acinclude: Update warning.m4 path.
3025         * warning.m4: Move to gdbsupport.
3026
3027 2020-02-11  Tom Tromey  <tromey@adacore.com>
3028
3029         * remote.c (remote_console_output): Update.
3030         * printcmd.c (printf_command): Update.
3031         * event-loop.c (gdb_wait_for_event): Update.
3032         * linux-nat.c (sigchld_handler): Update.
3033         * remote-sim.c (gdb_os_write_stdout): Update.
3034         (gdb_os_flush_stdout): Update.
3035         (gdb_os_flush_stderr): Update.
3036         (gdb_os_write_stderr): Update.
3037         * exceptions.c (print_exception): Update.
3038         * remote-fileio.c (remote_fileio_func_read): Update.
3039         (remote_fileio_func_write): Update.
3040         * tui/tui.c (tui_enable): Update.
3041         * tui/tui-interp.c (tui_interp::init): Update.
3042         * utils.c (init_page_info): Update.
3043         (putchar_unfiltered, fputc_unfiltered): Update.
3044         (gdb_flush): Update.
3045         (emit_style_escape): Update.
3046         (flush_wrap_buffer, fputs_maybe_filtered): Update.
3047         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
3048         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
3049         (stderr_file::write): Update.
3050         (stderr_file::puts): Update.
3051         * ui-file.h (ui_file_isatty, ui_file_write)
3052         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
3053         (ui_file_puts): Don't declare.
3054
3055 2020-02-10  Tom de Vries  <tdevries@suse.de>
3056
3057         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
3058         sentinel to char *.
3059
3060 2020-02-09  Tom de Vries  <tdevries@suse.de>
3061
3062         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
3063         filename if it matches "<artificial>".
3064
3065 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
3066
3067         * windows-tdep.c (struct enum_value_name): New struct.
3068         (create_enum): New function.
3069         (windows_get_siginfo_type): Create and use enum types.
3070
3071 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
3072
3073         * NEWS: Mention $_siginfo support for Windows.
3074         * windows-nat.c (handle_exception): Set siginfo_er.
3075         (windows_nat_target::mourn_inferior): Reset siginfo_er.
3076         (windows_xfer_siginfo): New function.
3077         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
3078         * windows-tdep.c (struct windows_gdbarch_data): New struct.
3079         (init_windows_gdbarch_data): New function.
3080         (get_windows_gdbarch_data): New function.
3081         (windows_get_siginfo_type): New function.
3082         (windows_init_abi): Register windows_get_siginfo_type.
3083         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
3084
3085 2020-02-08  Tom Tromey  <tom@tromey.com>
3086
3087         * dwarf2/read.c (class cutu_reader) <cutu_reader,
3088         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
3089         <keep>: Declare method.
3090         <m_keep>: Remove member.
3091         <~cutu_reader>: Remove.
3092         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3093         (cutu_reader::cutu_reader): Update.
3094         (cutu_reader::keep): Rename from ~cutu_reader.
3095         (process_psymtab_comp_unit, build_type_psymtabs_1)
3096         (process_skeletonless_type_unit, load_partial_comp_unit)
3097         (load_full_comp_unit, dwarf2_read_addr_index)
3098         (read_signatured_type): Update.
3099
3100 2020-02-08  Tom Tromey  <tom@tromey.com>
3101
3102         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
3103         "want_partial_unit" parameter.
3104         (process_psymtab_comp_unit): Change want_partial_unit to bool.
3105         Inline check for DW_TAG_partial_unit.
3106         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
3107
3108 2020-02-08  Tom Tromey  <tom@tromey.com>
3109
3110         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
3111         read.c.
3112         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
3113         read.c.
3114
3115 2020-02-08  Tom Tromey  <tom@tromey.com>
3116
3117         * dwarf2/read.c (read_address): Move to comp-unit.c.
3118         (dwarf2_rnglists_process, dwarf2_ranges_process)
3119         (read_attribute_value, dwarf_decode_lines_1)
3120         (var_decode_location, decode_locdesc): Update.
3121         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
3122         read.c.  Remove "cu" parameter.
3123         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
3124         method.
3125
3126 2020-02-08  Tom Tromey  <tom@tromey.com>
3127
3128         * dwarf2/read.c (read_attribute_value, read_indirect_string)
3129         (read_indirect_line_string): Update.
3130         * dwarf2/comp-unit.c (read_offset): Remove.
3131         (read_comp_unit_head): Update.
3132         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
3133         method.
3134         (read_offset): Don't declare.
3135
3136 2020-02-08  Tom Tromey  <tom@tromey.com>
3137
3138         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
3139         * dwarf2/read.c (struct comp_unit_head): Move to
3140         dwarf2/comp-unit.h.
3141         (enum class rcuh_kind): Move to comp-unit.h.
3142         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
3143         (read_comp_unit_head, error_check_comp_unit_head)
3144         (read_and_check_comp_unit_head): Move to comp-unit.c.
3145         (read_offset, dwarf_unit_type_name): Likewise.
3146         (create_debug_type_hash_table, read_cutu_die_from_dwo)
3147         (cutu_reader::cutu_reader, read_call_site_scope)
3148         (find_partial_die, follow_die_offset): Update.
3149         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
3150
3151 2020-02-08  Tom Tromey  <tom@tromey.com>
3152
3153         * dwarf2/read.c (read_offset_1): Move to leb.c.
3154         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
3155         (dwarf_decode_macro_bytes): Update.
3156         * dwarf2/leb.c (read_offset): Rename; move from read.c.
3157         * dwarf2/leb.h (read_offset): Declare.
3158
3159 2020-02-08  Tom Tromey  <tom@tromey.com>
3160
3161         * dwarf2/read.c (dwarf2_section_size): Remove.
3162         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
3163         Update.
3164         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
3165
3166 2020-02-08  Tom Tromey  <tom@tromey.com>
3167
3168         * dwarf2/read.c (read_initial_length): Move to leb.c.
3169         * dwarf2/leb.h (read_initial_length): Declare.
3170         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
3171         handle_nonstd parameter.
3172         * dwarf2/frame.c (read_initial_length): Remove.
3173         (decode_frame_entry_1): Update.
3174
3175 2020-02-08  Tom Tromey  <tom@tromey.com>
3176
3177         * dwarf2/loc.c (dwarf2_find_location_expression)
3178         (dwarf_evaluate_loc_desc::get_tls_address)
3179         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
3180         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
3181         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
3182         (dwarf2_compile_property_to_c)
3183         (dwarf2_loc_desc_get_symbol_read_needs)
3184         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
3185         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
3186         (loclist_describe_location, loclist_tracepoint_var_ref)
3187         (loclist_generate_c_location): Update.
3188         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
3189         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
3190         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
3191         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
3192         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
3193         (dwarf2_per_cu_data::addr_size)
3194         (dwarf2_per_cu_data::ref_addr_size)
3195         (dwarf2_per_cu_data::text_offset)
3196         (dwarf2_per_cu_data::addr_type): Now methods.
3197         (per_cu_header_read_in): Make per_cu "const".
3198         (dwarf2_version): Remove.
3199         (dwarf2_per_cu_data::int_type): Now a method.
3200         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
3201         (set_die_type, read_array_type, read_subrange_index_type)
3202         (read_tag_string_type, read_subrange_type): Update.
3203         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
3204         offset_size, ref_addr_size, text_offset, addr_type, version,
3205         objfile, int_type, addr_sized_int_type>: Declare methods.
3206
3207 2020-02-08  Tom Tromey  <tom@tromey.com>
3208
3209         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
3210         Move earlier.
3211
3212 2020-02-08  Tom Tromey  <tom@tromey.com>
3213
3214         * dwarf2/read.h (dwarf_line_debug): Declare.
3215         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
3216         * dwarf2/read.c: Move line_header code to new files.
3217         (dwarf_line_debug): No longer static.
3218         * dwarf2/line-header.c: New file.
3219         * dwarf2/line-header.h: New file.
3220
3221 2020-02-08  Tom Tromey  <tom@tromey.com>
3222
3223         * dwarf2/read.c (struct line_header) <file_full_name,
3224         file_file_name>: Return unique_xmalloc_ptr.
3225         (line_header::file_file_name): Update.
3226         (line_header::file_full_name): Update.
3227         (dw2_get_file_names_reader): Update.
3228         (macro_start_file): Update.
3229
3230 2020-02-08  Tom Tromey  <tom@tromey.com>
3231
3232         * dwarf2/read.c (struct line_header) <file_full_name,
3233         file_file_name>: Declare methods.
3234         (dw2_get_file_names_reader): Update.
3235         (file_file_name): Now a method.
3236         (file_full_name): Likewise.
3237         (macro_start_file): Update.
3238
3239 2020-02-08  Tom Tromey  <tom@tromey.com>
3240
3241         * dwarf2/read.c (dwarf_always_disassemble)
3242         (show_dwarf_always_disassemble): Move to loc.c.
3243         (_initialize_dwarf2_read): Move "always-disassemble" registration
3244         to loc.c.
3245         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
3246         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
3247         static.
3248         (show_dwarf_always_disassemble): Move from read.c.
3249         (_initialize_dwarf2loc): Move always-disassemble from read.c.
3250
3251 2020-02-08  Tom Tromey  <tom@tromey.com>
3252
3253         * dwarf2/read.c (~dwarf2_per_objfile): Update.
3254         (create_quick_file_names_table): Return htab_up.
3255         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
3256         Update.
3257         * dwarf2/read.h (struct dwarf2_per_objfile)
3258         <quick_file_names_table>: Now htab_up.
3259
3260 2020-02-08  Tom Tromey  <tom@tromey.com>
3261
3262         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
3263
3264 2020-02-08  Tom Tromey  <tom@tromey.com>
3265
3266         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
3267         Rewrite.
3268         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
3269         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
3270         (abbrev_table::abbrev_table): No longer inline.
3271         (ABBREV_HASH_SIZE): Remove.
3272         (abbrev_table::m_abbrevs): Now an htab_up.
3273
3274 2020-02-08  Tom Tromey  <tom@tromey.com>
3275
3276         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
3277         (cutu_reader): Update.
3278         (build_type_psymtabs_1): Update.
3279         * dwarf2/abbrev.c (abbrev_table::read): Rename.
3280         (abbrev_table::alloc_abbrev): Update.
3281         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
3282         (abbrev_table::read): New static method, renamed from
3283         abbrev_table_read_table.
3284         (abbrev_table::alloc_abbrev)
3285         (abbrev_table::add_abbrev): Now private.
3286         (abbrev_table::abbrev_table): Now private.
3287         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
3288
3289 2020-02-08  Tom Tromey  <tom@tromey.com>
3290
3291         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
3292         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
3293         htab_up.
3294
3295 2020-02-08  Tom Tromey  <tom@tromey.com>
3296
3297         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
3298         htab_up.
3299         (lookup_dwo_unit_in_dwp): Update.
3300         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
3301         on obstack.
3302
3303 2020-02-08  Tom Tromey  <tom@tromey.com>
3304
3305         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
3306         obstack.
3307
3308 2020-02-08  Tom Tromey  <tom@tromey.com>
3309
3310         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
3311         line_header_hash.
3312         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
3313         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
3314         Change type to htab_up.
3315
3316 2020-02-08  Tom Tromey  <tom@tromey.com>
3317
3318         * dwarf2/read.c (allocate_type_unit_groups_table): Return
3319         htab_up.  Don't allocate on obstack.
3320         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
3321         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
3322         Change type to htab_up.
3323
3324 2020-02-08  Tom Tromey  <tom@tromey.com>
3325
3326         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
3327         Change type to htab_up.
3328         * dwarf2/read.c (create_signatured_type_table_from_index)
3329         (create_signatured_type_table_from_debug_names)
3330         (create_all_type_units, add_type_unit)
3331         (lookup_dwo_signatured_type, lookup_signatured_type)
3332         (process_skeletonless_type_unit): Update.
3333         (create_debug_type_hash_table, create_debug_types_hash_table):
3334         Change type of types_htab.
3335         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
3336         htab_up.  Don't allocate on obstack.
3337         (create_cus_hash_table): Change type of cus_htab parameter.
3338         (struct dwo_file) <cus, tus>: Now htab_up.
3339         (lookup_dwo_signatured_type, lookup_dwo_cutu)
3340         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
3341         (queue_and_load_all_dwo_tus): Update.
3342         * dwarf2/index-write.c (write_gdbindex): Update.
3343         (write_debug_names): Update.
3344
3345 2020-02-08  Tom Tromey  <tom@tromey.com>
3346
3347         * dwarf2/read.h (struct dwarf2_queue_item): Move from
3348         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
3349         destructor.
3350         (struct dwarf2_per_objfile) <queue>: New member.
3351         * dwarf2/read.c (struct dwarf2_queue_item): Move to
3352         dwarf2/read.h.
3353         (dwarf2_queue, dwarf2_queue_tail): Remove.
3354         (class dwarf2_queue_guard): Add parameter to constructor.  Use
3355         DISABLE_COPY_AND_ASSIGN.
3356         <m_per_objfile>: New member.
3357         <~dwarf2_queue_guard>: Rewrite.
3358         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
3359         Update.
3360         (~dwarf2_queue_item): New.
3361
3362 2020-02-08  Tom Tromey  <tom@tromey.com>
3363
3364         * dwarf2/read.c (struct die_info) <has_children>: New member.
3365         (dw2_get_file_names_reader): Remove has_children.
3366         (dw2_get_file_names): Update.
3367         (read_cutu_die_from_dwo): Remove has_children.
3368         (cutu_reader::init_tu_and_read_dwo_dies)
3369         (cutu_reader::cutu_reader): Update.
3370         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
3371         Remove has_children.
3372         (build_type_psymtabs_1, process_skeletonless_type_unit)
3373         (load_partial_comp_unit, load_full_comp_unit): Update.
3374         (create_dwo_cu_reader): Remove has_children.
3375         (create_cus_hash_table, read_die_and_children): Update.
3376         (read_full_die_1,read_full_die): Remove has_children.
3377         (read_signatured_type): Update.
3378         (class cutu_reader) <has_children>: Remove.
3379
3380 2020-02-08  Tom Tromey  <tom@tromey.com>
3381
3382         * dwarf2/expr.c: Rename from dwarf2expr.c.
3383         * dwarf2/expr.h: Rename from dwarf2expr.h.
3384         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
3385         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
3386         * dwarf2/frame.c: Rename from dwarf2-frame.c.
3387         * dwarf2/frame.h: Rename from dwarf2-frame.h.
3388         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
3389         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
3390         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
3391         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
3392         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
3393         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
3394         * dwarf2/loc.c: Rename from dwarf2loc.c.
3395         * dwarf2/loc.h: Rename from dwarf2loc.h.
3396         * dwarf2/read.c: Rename from dwarf2read.c.
3397         * dwarf2/read.h: Rename from dwarf2read.h.
3398         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
3399         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
3400         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
3401         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
3402         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
3403         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
3404         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
3405         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
3406         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
3407         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
3408         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
3409         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
3410         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
3411         Update.
3412         * Makefile.in (COMMON_SFILES): Update.
3413         (HFILES_NO_SRCDIR): Update.
3414
3415 2020-02-08  Tom Tromey  <tom@tromey.com>
3416
3417         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
3418         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
3419
3420 2020-02-08  Tom Tromey  <tom@tromey.com>
3421
3422         * dwarf2read.h (struct die_info): Don't declare.
3423
3424 2020-02-08  Tom Tromey  <tom@tromey.com>
3425
3426         * dwarf2read.h (die_info_ptr): Remove typedef.
3427
3428 2020-02-08  Tom Tromey  <tom@tromey.com>
3429
3430         * dwarf2read.c (read_call_site_scope)
3431         (handle_data_member_location, dwarf2_add_member_fn)
3432         (mark_common_block_symbol_computed, read_common_block)
3433         (attr_to_dynamic_prop, partial_die_info::read)
3434         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
3435         (dwarf2_symbol_mark_computed, set_die_type): Update.
3436         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
3437         method.
3438         (attr_form_is_block): Don't declare.
3439         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
3440
3441 2020-02-08  Tom Tromey  <tom@tromey.com>
3442
3443         * dwarf2read.c (dwarf2_find_base_address, )
3444         (read_call_site_scope, rust_containing_type)
3445         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
3446         (handle_data_member_location, dwarf2_add_member_fn)
3447         (get_alignment, read_structure_type, process_structure_scope)
3448         (mark_common_block_symbol_computed, read_common_block)
3449         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
3450         (partial_die_info::read, read_attribute_value, new_symbol)
3451         (lookup_die_type, dwarf2_get_ref_die_offset)
3452         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
3453         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
3454         (dwarf2_symbol_mark_computed): Update.
3455         * dwarf2/attribute.h (struct attribute) <value_as_address,
3456         form_is_section_offset, form_is_constant, form_is_ref>: Declare
3457         methods.
3458         (value_as_address, attr_form_is_section_offset)
3459         (attr_form_is_constant, attr_form_is_ref): Don't declare.
3460         * dwarf2/attribute.c (attribute::value_as_address)
3461         (attribute::form_is_section_offset, attribute::form_is_constant)
3462         (attribute::form_is_ref): Now methods.
3463
3464 2020-02-08  Tom Tromey  <tom@tromey.com>
3465
3466         * dwarf2read.c (struct attribute, DW_STRING)
3467         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
3468         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
3469         (attr_form_is_block, attr_form_is_section_offset)
3470         (attr_form_is_constant, attr_form_is_ref): Move.
3471         * dwarf2/attribute.h: New file.
3472         * dwarf2/attribute.c: New file, from dwarf2read.c.
3473         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
3474
3475 2020-02-08  Tom Tromey  <tom@tromey.com>
3476
3477         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
3478         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
3479         Move.
3480         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
3481         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
3482         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
3483         abbrev.c.
3484         * dwarf2/abbrev.h: New file.
3485         * dwarf2/abbrev.c: New file, from dwarf2read.c.
3486         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
3487
3488 2020-02-08  Tom Tromey  <tom@tromey.com>
3489
3490         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
3491         (dwarf2_section_size, dwarf2_get_section_info)
3492         (create_signatured_type_table_from_debug_names)
3493         (create_addrmap_from_aranges, read_debug_names_from_section)
3494         (get_gdb_index_contents_from_section, read_comp_unit_head)
3495         (error_check_comp_unit_head, read_abbrev_offset)
3496         (create_debug_type_hash_table, init_cu_die_reader)
3497         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
3498         (read_comp_units_from_section, create_cus_hash_table)
3499         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
3500         (create_dwp_v2_section, dwarf2_rnglists_process)
3501         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
3502         (abbrev_table_read_table, read_indirect_string_at_offset_from)
3503         (read_indirect_string_from_dwz, read_addr_index_1)
3504         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
3505         (dwarf_decode_macro_bytes, dwarf_decode_macros)
3506         (fill_in_loclist_baton): Update.
3507         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
3508         get_containing_section, get_bfd_owner, get_bfd_section,
3509         get_file_name, get_id, get_flags, empty, read>: Declare methods.
3510         (dwarf2_read_section, get_section_name, get_section_file_name)
3511         (get_containing_section, get_section_bfd_owner)
3512         (get_section_bfd_section, get_section_name, get_section_file_name)
3513         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
3514         declare.
3515         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
3516         (dwarf2_section_info::get_bfd_owner)
3517         (dwarf2_section_info::get_bfd_section)
3518         (dwarf2_section_info::get_name)
3519         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
3520         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
3521         (dwarf2_section_info::read): Now methods.
3522         * dwarf-index-write.c (class debug_names): Update.
3523
3524 2020-02-08  Tom Tromey  <tom@tromey.com>
3525
3526         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
3527         Move to dwarf2/section.h.
3528         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
3529         (get_section_bfd_section, get_section_name)
3530         (get_section_file_name, get_section_id, get_section_flags)
3531         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
3532         dwarf2/section.c.
3533         * dwarf2/section.h: New file.
3534         * dwarf2/section.c: New file, from dwarf2read.c.
3535         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
3536
3537 2020-02-08  Tom Tromey  <tom@tromey.com>
3538
3539         * dwarf2read.h (read_unsigned_leb128): Don't declare.
3540         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
3541         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
3542         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
3543         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
3544         * dwarf2/leb.h: New file, from dwarf2read.c.
3545         * dwarf2/leb.c: New file, from dwarf2read.c.
3546         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
3547         Remove.
3548         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
3549         (COMMON_SFILES): Add dwarf2/leb.c.
3550
3551 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
3552
3553         GDB 9.1 released.
3554
3555 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
3556
3557         PR gdb/25190:
3558         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
3559         * gdb/remote.c (remote_console_output): Update.
3560         * gdb/ui-file.c (fputs_unfiltered): Rename to...
3561         (ui_file_puts): ...this.
3562         * gdb/ui-file.h (ui_file_puts): Add declaration.
3563         * gdb/utils.c (emit_style_escape): Update.
3564         (flush_wrap_buffer): Update.
3565         (fputs_maybe_filtered): Update.
3566         (fputs_unfiltered): Add function.
3567
3568 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
3569
3570         * gdb/event-loop.c (gdb_wait_for_event): Update.
3571         * gdb/printcmd.c (printf_command): Update.
3572         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
3573         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
3574         (gdb_os_flush_stderr): Update.
3575         * gdb/remote.c (remote_console_output): Update.
3576         * gdb/ui-file.c (gdb_flush): Rename to...
3577         (ui_file_flush): ...this.
3578         (stderr_file::write): Update.
3579         (stderr_file::puts): Update.
3580         * gdb/ui-file.h (gdb_flush): Rename to...
3581         (ui_file_flush): ...this.
3582         * gdb/utils.c (gdb_flush): Add function.
3583         * gdb/utils.h (gdb_flush): Add declaration.
3584
3585 2020-02-07  Tom Tromey  <tromey@adacore.com>
3586
3587         PR breakpoints/24915:
3588         * source.c (find_and_open_source): Do not check basenames_may_differ.
3589
3590 2020-02-07  Tom Tromey  <tom@tromey.com>
3591
3592         * README: Update gdbserver documentation.
3593         * gdbserver: Move to top level.
3594         * configure.tgt (build_gdbserver): Remove.
3595         * configure.ac: Remove --enable-gdbserver.
3596         * configure: Rebuild.
3597         * Makefile.in (distclean): Don't mention gdbserver.
3598
3599 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
3600
3601         * source-cache.c (source_cache::ensure): Surround
3602         get_plain_source_lines with a try/catch.
3603         (source_cache::get_line_charpos): Get rid of try/catch
3604         and only check for the return value of "ensure".
3605         * tui/tui-source.c (tui_source_window::set_contents):
3606         Simplify "nlines" calculation.
3607
3608 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
3609
3610         * MAINTAINERS (Write After Approval): Add myself.
3611
3612 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
3613
3614         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
3615         function call.
3616
3617 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
3618
3619         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
3620
3621 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
3622
3623         * nat/riscv-linux-tdesc.h: New file.
3624         * nat/riscv-linux-tdesc.c: New file, taking code from...
3625         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3626         ... here.
3627         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
3628         NATDEPFILES.
3629
3630 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
3631
3632         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
3633         we don't set the fake simulator ptid to the null_ptid.
3634
3635 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
3636
3637         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
3638         * gdbthread.h (class thread_info) <resumed>: Likewise.
3639         * infrun.c (resume_1): Likewise.
3640         (proceed): Likewise.
3641         (infrun_thread_stop_requested): Likewise.
3642         (stop_all_threads): Likewise.
3643         (handle_inferior_event): Likewise.
3644         (restart_threads): Likewise.
3645         (finish_step_over): Likewise.
3646         (keep_going_stepped_thread): Likewise.
3647         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
3648         (linux_handle_extended_wait): Likewise.
3649         * record-btrace.c (get_thread_current_frame_id): Likewise.
3650         * record-full.c (record_full_wait_1): Likewise.
3651         * remote.c (remote_target::process_initial_stop_replies): Likewise.
3652         * target.c (target_resume): Likewise.
3653         * thread.c (set_running_thread): Likewise.
3654
3655 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3656
3657         * f-valprint.c (f77_print_array_1): Changed datatype of index
3658         variable to LONGEST from int to enable it to contain bound
3659         values correctly.
3660
3661 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
3662
3663         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
3664         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
3665         offsets according to FLEN determined.
3666         (riscv_linux_nat_target::read_description): Determine FLEN
3667         dynamically.
3668         (riscv_linux_nat_target::fetch_registers): Size regset buffer
3669         according to FLEN determined.
3670         (riscv_linux_nat_target::store_registers): Likewise.
3671
3672 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3673
3674         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3675         when reg->group is empty and reggroup is not.
3676
3677 2020-01-31  Tom Tromey  <tromey@adacore.com>
3678
3679         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
3680         Call beneath target's mourn_inferior after unpushing.
3681
3682 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
3683
3684         PR tui/9765
3685         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
3686         have enough lines to fill the screen, still return the lowest
3687         address we found.
3688
3689 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
3690
3691         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
3692         '-', '<', and '>' commands.
3693
3694 2020-01-29  Pedro Alves  <palves@redhat.com>
3695             Sergio Durigan Junior  <sergiodj@redhat.com>
3696
3697         * infcmd.c (construct_inferior_arguments): Assert that
3698         'argc' is greater than 0.
3699
3700 2020-01-29  Luis Machado  <luis.machado@linaro.org>
3701
3702         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
3703         (BRK_INSN_MASK): Define to 0xd4200000.
3704         (aarch64_program_breakpoint_here_p): New function.
3705         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
3706         * arch-utils.c (default_program_breakpoint_here_p): Moved from
3707         breakpoint.c.
3708         * arch-utils.h (default_program_breakpoint_here_p): Moved from
3709         breakpoint.h
3710         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
3711         call gdbarch_program_breakpoint_here_p.
3712         (program_breakpoint_here): Moved to arch-utils.c, renamed to
3713         default_program_breakpoint_here_p, changed return type to bool and
3714         simplified.
3715         * breakpoint.h (program_breakpoint_here): Moved prototype to
3716         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
3717         return type to bool.
3718         * gdbarch.c: Regenerate.
3719         * gdbarch.h: Regenerate.
3720         * gdbarch.sh (program_breakpoint_here_p): New method.
3721         * infrun.c (handle_signal_stop): Call
3722         gdbarch_program_breakpoint_here_p.
3723
3724 2020-01-26  Tom Tromey  <tom@tromey.com>
3725
3726         * ctfread.c (struct ctf_fp_info): Reindent.
3727         (_initialize_ctfread): Remove.
3728
3729 2020-01-26  Tom Tromey  <tom@tromey.com>
3730
3731         * psymtab.c (partial_map_expand_apply)
3732         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
3733         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
3734         (psym_print_stats, psym_expand_symtabs_for_function)
3735         (psym_map_symbol_filenames, psym_map_matching_symbols)
3736         (psym_expand_symtabs_matching)
3737         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
3738         (maintenance_check_psymtabs): Use new methods.
3739         * psympriv.h (struct partial_symtab) <readin_p,
3740         get_compunit_symtab>: New methods.
3741         <readin, compunit_symtab>: Remove members.
3742         (struct standard_psymtab): New.
3743         (struct legacy_psymtab): Derive from standard_psymtab.
3744         * dwarf2read.h (struct dwarf2_psymtab): Derive from
3745         standard_psymtab.
3746         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
3747
3748 2020-01-26  Tom Tromey  <tom@tromey.com>
3749
3750         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
3751         read_dependencies.  Add assert.
3752         * psymtab.c (partial_symtab::read_dependencies): New method.
3753         * psympriv.h (struct partial_symtab) <read_dependencies>: New
3754         method.
3755         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
3756         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
3757         read_dependencies.
3758         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
3759         Add assert.
3760
3761 2020-01-26  Tom Tromey  <tom@tromey.com>
3762
3763         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
3764         Call expand_psymtab.
3765         (xcoff_read_symtab): Call expand_psymtab.
3766         (xcoff_start_psymtab, xcoff_end_psymtab): Set
3767         legacy_expand_psymtab.
3768         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
3769         method.
3770         (struct legacy_psymtab) <expand_psymtab>: Implement.
3771         <legacy_expand_psymtab>: New member.
3772         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
3773         (parse_partial_symbols): Set legacy_expand_psymtab.
3774         (psymtab_to_symtab_1): Change argument order.  Call
3775         expand_psymtab.
3776         (new_psymtab): Set legacy_expand_psymtab.
3777         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
3778         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
3779         expand_psymtab.
3780         (dwarf2_psymtab::expand_psymtab): Rename from
3781         psymtab_to_symtab_1.  Call expand_psymtab.
3782         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
3783         (dbx_end_psymtab): Likewise.
3784         (dbx_psymtab_to_symtab_1): Change argument order. Call
3785         expand_psymtab.
3786         (dbx_read_symtab): Call expand_psymtab.
3787         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
3788         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
3789         (ctf_psymtab::read_symtab): Call expand_psymtab.
3790
3791 2020-01-26  Tom Tromey  <tom@tromey.com>
3792
3793         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
3794         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
3795         messages.
3796         * mdebugread.c (mdebug_read_symtab): Remove prints.
3797         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
3798         assert.
3799         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
3800
3801 2020-01-26  Tom Tromey  <tom@tromey.com>
3802
3803         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
3804         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
3805         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
3806         legacy_symtab.
3807         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
3808         * psymtab.c (psymtab_to_symtab): Call method.
3809         (dump_psymtab): Update.
3810         * psympriv.h (struct partial_symtab): Add virtual destructor.
3811         <read_symtab>: New method.
3812         (struct legacy_symtab): New.
3813         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
3814         (struct pst_map) <pst>: Now a legacy_psymtab.
3815         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
3816         (new_psymtab): Use legacy_psymtab.
3817         * dwarf2read.h (struct dwarf2_psymtab): New.
3818         (struct dwarf2_per_cu_data) <psymtab>: Use it.
3819         * dwarf2read.c (dwarf2_create_include_psymtab)
3820         (dwarf2_build_include_psymtabs, create_type_unit_group)
3821         (create_partial_symtab, process_psymtab_comp_unit_reader)
3822         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
3823         (set_partial_user): Use dwarf2_psymtab.
3824         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
3825         (psymtab_to_symtab_1, process_full_comp_unit)
3826         (process_full_type_unit, dwarf2_ranges_read)
3827         (dwarf2_get_pc_bounds, psymtab_include_file_name)
3828         (dwarf_decode_lines): Use dwarf2_psymtab.
3829         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
3830         (add_address_entry_worker, write_one_signatured_type)
3831         (recursively_count_psymbols, recursively_write_psymbols)
3832         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
3833         (write_debug_names): Likewise.
3834         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
3835         <pst>: Now a legacy_psymtab.
3836         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
3837         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
3838         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
3839         * ctfread.c (struct ctf_psymtab): New.
3840         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
3841         ctf_psymtab.
3842         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
3843         (create_partial_symtab): Return a ctf_psymtab.
3844         (scan_partial_symbols): Update.
3845
3846 2020-01-26  Tom Tromey  <tom@tromey.com>
3847
3848         * xcoffread.c (xcoff_start_psymtab): Use new.
3849         * psymtab.c (partial_symtab::partial_symtab): New constructor,
3850         renamed from start_psymtab_common.
3851         * psympriv.h (struct partial_symtab): Add new constructor.
3852         (start_psymtab_common): Don't declare.
3853         * mdebugread.c (parse_partial_symbols): Use new.
3854         * dwarf2read.c (create_partial_symtab): Use new.
3855         * dbxread.c (start_psymtab): Use new.
3856         * ctfread.c (create_partial_symtab): Use new.
3857
3858 2020-01-26  Tom Tromey  <tom@tromey.com>
3859
3860         * xcoffread.c (xcoff_end_psymtab): Use new.
3861         * psymtab.c (start_psymtab_common): Use new.
3862         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
3863         Update.
3864         * psympriv.h (struct partial_symtab): Add parameters to
3865         constructor.  Don't inline.
3866         (allocate_psymtab): Don't declare.
3867         * mdebugread.c (new_psymtab): Use new.
3868         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
3869         * dbxread.c (dbx_end_psymtab): Use new.
3870
3871 2020-01-26  Tom Tromey  <tom@tromey.com>
3872
3873         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
3874         allocate_psymtab.  Update documentation.
3875         * psymtab.c (psymtab_storage::install_psymtab): Rename from
3876         allocate_psymtab.  Do not use new.
3877         (allocate_psymtab): Use new.  Update.
3878
3879 2020-01-26  Tom Tromey  <tom@tromey.com>
3880
3881         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
3882         * psymtab.c (psym_print_stats): Update.
3883         * psympriv.h (struct partial_symtab) <readin,
3884         psymtabs_addrmap_supported, anonymous>: Now bool.
3885         * mdebugread.c (psymtab_to_symtab_1): Update.
3886         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
3887         (build_type_psymtabs_reader, psymtab_to_symtab_1)
3888         (process_full_comp_unit, process_full_type_unit): Update.
3889         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
3890         * ctfread.c (psymtab_to_symtab): Update.
3891
3892 2020-01-26  Tom Tromey  <tom@tromey.com>
3893
3894         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
3895         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
3896         * psymtab.c (psymtab_storage): Delete psymtabs.
3897         (psymtab_storage::allocate_psymtab): Use new.
3898         (psymtab_storage::discard_psymtab): Use delete.
3899         * psympriv.h (struct partial_symtab): Add constructor and
3900         initializers.
3901
3902 2020-01-26  Tom Tromey  <tom@tromey.com>
3903
3904         * machoread.c: Do not include psympriv.h.
3905
3906 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3907
3908         * NEWS: Mention the new option and the set/show commands.
3909
3910 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3911
3912         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
3913         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
3914         (validate_exec_file): New variables, enums, functions.
3915         (exec_file_locate_attach, print_section_info): Style the filenames.
3916         (_initialize_exec): Install show_exec_file_mismatch_command and
3917          set_exec_file_mismatch_command.
3918         * gdbcore.h (validate_exec_file): Declare.
3919         * infcmd.c (attach_command): Call validate_exec_file.
3920         * remote.c ( remote_target::remote_add_inferior): Likewise.
3921
3922 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3923
3924         * frame.c (find_frame_sal): Move call to get_next_frame into more
3925         inner scope.
3926         * inline-frame.c (inilne_state) <inline_state>: Update argument
3927         types.
3928         (inilne_state) <skipped_symbol>: Rename to...
3929         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
3930         (skip_inline_frames): Build vector of skipped symbols and use this
3931         to reate the inline_state.
3932         (inline_skipped_symbol): Add a comment and some assertions, fetch
3933         skipped symbol from the list.
3934
3935 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * buildsym.c (lte_is_less_than): Delete.
3938         (buildsym_compunit::end_symtab_with_blockvector): Create local
3939         lambda function to sort line table entries, and use
3940         std::stable_sort instead of std::sort.
3941         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
3942         markers when looking for a previous line.
3943
3944 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3945
3946         * dwarf2read.c (lnp_state_machine::record_line): Include
3947         end_sequence parameter in debug print out.  Record the line if we
3948         are at an end_sequence marker even if it's not the start of a
3949         statement.
3950         * symmisc.c (maintenance_print_one_line_table): Print end of
3951         sequence markers with 'END' not '0'.
3952
3953 2020-01-24  Pedro Alves  <palves@redhat.com>
3954
3955         PR gdb/25410
3956         * thread.c (scoped_restore_current_thread::restore): Use
3957         switch_to_inferior_no_thread.
3958         * exec.c: Include "progspace-and-thread.h".
3959         (add_target_sections, remove_target_sections):
3960         scoped_restore_current_pspace_and_thread instead of
3961         scoped_restore_current_thread.
3962         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
3963         and aspace to the inferior before calling clone_program_space.
3964         Remove stale comment.
3965
3966 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3967
3968         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
3969         (arm_netbsd_nat_target::fetch_registers): ...this.
3970         (arm_nbsd_nat_target::store_registers): Rename to...
3971         (arm_netbsd_nat_target::store_registers): ...this.
3972
3973 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3974
3975         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3976         register_t.
3977
3978 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3979
3980         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
3981         Update comment.
3982         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
3983         Likewise.
3984         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
3985         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
3986         the correct replacement (iterate_over_regset_sections).
3987         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
3988         Update comment.
3989
3990 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
3991
3992         PR gdb/23718
3993         * gdb/python/python.c (execute_gdb_command): Call
3994         async_enable_stdin in catch block.
3995
3996 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3997
3998         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
3999         SWITCH_THRU_ALL_UIS.
4000
4001 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         PR tui/9765
4004         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
4005         comment, add extra parameter, and update to store previous symbol
4006         when appropriate.
4007         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
4008         add extra parameter.
4009         * tui/tui-disasm.c (tui_disassemble): Update header comment,
4010         remove unneeded parameter, add try/catch around gdb_print_insn,
4011         rewrite to add items to asm_lines vector.
4012         (tui_find_backward_disassembly_start_address): New function.
4013         (tui_find_disassembly_address): Updated throughout.
4014         (tui_disasm_window::set_contents): Update for changes to
4015         tui_disassemble.
4016         (tui_disasm_window::do_scroll_vertical): No need to adjust the
4017         number of lines to scroll.
4018
4019 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
4020
4021         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
4022         (SECT_OFF_DATA): Likewise.
4023         (SECT_OFF_RODATA): Likewise.
4024         (SECT_OFF_TEXT): Likewise.
4025         (SECT_OFF_BSS): Likewise.
4026         (struct objfile) <text_section_offset, data_section_offset>: New
4027         methods.
4028         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
4029         objfile::text_section_offset.
4030         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
4031         * coffread.c (coff_symtab_read): Likewise.
4032         (enter_linenos): Likewise.
4033         (process_coff_symbol): Likewise.
4034         * ctfread.c (get_objfile_text_range): Likewise.
4035         * dtrace-probe.c (dtrace_probe::get_relocated_address):
4036         Use objfile::data_section_offset.
4037         * dwarf2-frame.c (execute_cfa_program): Use
4038         objfile::text_section_offset.
4039         (dwarf2_frame_find_fde): Likewise.
4040         * dwarf2read.c (create_addrmap_from_index): Likewise.
4041         (create_addrmap_from_aranges): Likewise.
4042         (dw2_find_pc_sect_compunit_symtab): Likewise.
4043         (process_psymtab_comp_unit_reader): Likewise.
4044         (add_partial_symbol): Likewise.
4045         (add_partial_subprogram): Likewise.
4046         (process_full_comp_unit): Likewise.
4047         (read_file_scope): Likewise.
4048         (read_func_scope): Likewise.
4049         (read_lexical_block_scope): Likewise.
4050         (read_call_site_scope): Likewise.
4051         (dwarf2_rnglists_process): Likewise.
4052         (dwarf2_ranges_process): Likewise.
4053         (dwarf2_ranges_read): Likewise.
4054         (dwarf_decode_lines_1): Likewise.
4055         (new_symbol): Likewise.
4056         (dwarf2_fetch_die_loc_sect_off): Likewise.
4057         (dwarf2_per_cu_text_offset): Likewise.
4058         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
4059         * hppa-tdep.c (read_unwind_info): Likewise.
4060         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
4061         * psympriv.h (struct partial_symtab): Likewise.
4062         * psymtab.c (find_pc_sect_psymtab): Likewise.
4063         * solib-svr4.c (enable_break): Likewise.
4064         * stap-probe.c (relocate_address): Use
4065         objfile::data_section_offset.
4066         * xcoffread.c (enter_line_range): Use
4067         objfile::text_section_offset.
4068         (read_xcoff_symtab): Likewise.
4069
4070 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
4071
4072         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
4073         declaration to narrower scopes.
4074
4075 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
4076
4077         * darwin-nat.h (struct darwin_exception_msg, enum
4078         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
4079         Move up.
4080         (class darwin_nat_target) <wait_1, check_new_threads,
4081         decode_exception_message, decode_message, stop_inferior,
4082         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
4083         * darwin-nat.c (darwin_check_new_threads): Rename to...
4084         (darwin_nat_target::check_new_threads): ... this.
4085         (darwin_suspend_inferior_it): Remove.
4086         (darwin_decode_exception_message): Rename to...
4087         (darwin_nat_target::decode_exception_message): ... this.
4088         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
4089         (darwin_decode_message): Rename to...
4090         (darwin_nat_target::decode_message): ... this.
4091         (cancel_breakpoint): Rename to...
4092         (darwin_nat_target::cancel_breakpoint): ... this.
4093         (darwin_wait): Rename to...
4094         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
4095         instead of iterate_over_inferiors.
4096         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
4097         (darwin_stop_inferior): Rename to...
4098         (darwin_nat_target::stop_inferior): ... this.
4099         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
4100         (darwin_init_thread_list): Rename to...
4101         (darwin_nat_target::init_thread_list): ... this.
4102         (darwin_ptrace_him): Rename to...
4103         (darwin_nat_target::ptrace_him): ... this.
4104         (darwin_nat_target::create_inferior): Pass lambda function to
4105         fork_inferior.
4106         (darwin_nat_target::detach): Call stop_inferior instead of
4107         darwin_stop_inferior.
4108         * fork-inferior.h (fork_inferior): Change init_trace_fun
4109         parameter to gdb::function_view.
4110         * fork-inferior.c (fork_inferior): Likewise.
4111
4112 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
4113
4114         * i386-cygwin-tdep.c (core_process_module_section): Update.
4115         * windows-nat.c (struct lm_info_windows): Add text_offset.
4116         (windows_xfer_shared_libraries): Update.
4117         * windows-tdep.c (windows_xfer_shared_library):
4118         Add text_offset_cached argument.
4119         * windows-tdep.h (windows_xfer_shared_library): Update.
4120
4121 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4122
4123         * gdbarch.sh: Add declaration for _initialize_gdbarch.
4124
4125 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4126
4127         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
4128         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
4129         replace with range-based for.
4130         (gdbsim_interrupt_inferior): Remove.
4131         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
4132         with a range-based for.  Inline code from
4133         gdbsim_interrupt_inferior.
4134
4135 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4136
4137         * infrun.c (proceed): Fix indentation.
4138
4139 2020-01-21  Tom Tromey  <tromey@adacore.com>
4140
4141         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
4142         * python/python.c (python_extension_ops): Update.
4143         (gdbpy_colorize): New function.
4144         * python/lib/gdb/__init__.py (colorize): New function.
4145         * extension.h (ext_lang_colorize): Declare.
4146         * extension.c (ext_lang_colorize): New function.
4147         * extension-priv.h (struct extension_language_ops) <colorize>: New
4148         member.
4149         * cli/cli-style.c (_initialize_cli_style): Update help text.
4150
4151 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4152
4153         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
4154         <cond>: Change type to bool.
4155         (aarch64_displaced_step_b_cond): Update cond to use bool type.
4156         (aarch64_displaced_step_cb): Likewise.
4157         (aarch64_displaced_step_tb): Likewise.
4158
4159 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4160
4161         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
4162         output.
4163
4164 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4165
4166         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
4167         <pc_adjust>: Adjust the documentation.
4168         (aarch64_displaced_step_fixup): Check if PC really moved before
4169         adjusting it.
4170
4171 2020-01-19  Tom Tromey  <tom@tromey.com>
4172
4173         * disasm.c (~gdb_disassembler): New destructor.
4174         (gdb_buffered_insn_length): Call disassemble_free_target.
4175         * disasm.h (class gdb_disassembler): Declare destructor.  Use
4176         DISABLE_COPY_AND_ASSIGN.
4177
4178 2020-01-19  Tom Tromey  <tom@tromey.com>
4179
4180         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
4181         (die_reader_func_ftype): Remove.
4182         (cutu_reader): New class.
4183         (dw2_get_file_names_reader): Remove "data" parameter.
4184         (dw2_get_file_names): Use cutu_reader.
4185         (create_debug_type_hash_table): Update.
4186         (read_cutu_die_from_dwo): Update comment.
4187         (lookup_dwo_unit): Add dwo_name parameter.
4188         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
4189         die_reader_func_ftype and data parameters.
4190         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
4191         Remove die_reader_func_ftype and data parameters.
4192         (~cutu_reader): New; from init_cutu_and_read_dies.
4193         (cutu_reader::cutu_reader): Rename from
4194         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
4195         and data parameters.
4196         (init_cutu_and_read_dies_simple): Remove.
4197         (struct process_psymtab_comp_unit_data): Remove.
4198         (process_psymtab_comp_unit_reader): Remove data parameter; add
4199         want_partial_unit and pretend_language parameters.
4200         (process_psymtab_comp_unit): Use cutu_reader.
4201         (build_type_psymtabs_reader): Remove data parameter.
4202         (build_type_psymtabs_1): Use cutu_reader.
4203         (process_skeletonless_type_unit): Likewise.
4204         (load_partial_comp_unit_reader): Remove.
4205         (load_partial_comp_unit): Use cutu_reader.
4206         (load_full_comp_unit_reader): Remove.
4207         (load_full_comp_unit): Use cutu_reader.
4208         (struct create_dwo_cu_data): Remove.
4209         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
4210         dwo_unit parameters.
4211         (create_cus_hash_table): Use cutu_reader.
4212         (struct dwarf2_read_addr_index_data): Remove.
4213         (dwarf2_read_addr_index_reader): Remove.
4214         (dwarf2_read_addr_index): Use cutu_reader.
4215         (read_signatured_type_reader): Remove.
4216         (read_signatured_type): Use cutu_reader.
4217
4218 2020-01-19  Tom Tromey  <tom@tromey.com>
4219
4220         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
4221         * tui/tui-wingeneral.h (class tui_suppress_output): New.
4222         (tui_wrefresh): Declare.
4223         * tui/tui-wingeneral.c (suppress_output): New global.
4224         (tui_suppress_output, ~tui_suppress_output): New constructor and
4225         destructor.
4226         (tui_wrefresh): New function.
4227         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
4228         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
4229         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
4230         method.
4231         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
4232         tui_wrefresh.
4233         (tui_data_window::no_refresh): New method.
4234         (tui_data_item_window::refresh_window): Call tui_wrefresh.
4235         (tui_reg_command): Use tui_suppress_output
4236         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
4237         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
4238         method.
4239         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
4240
4241 2020-01-19  Tom Tromey  <tom@tromey.com>
4242
4243         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4244         Handle case where symtab is null.
4245
4246 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
4247
4248         * linux-fork.c (one_fork_p): Simplify.
4249
4250 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4251
4252         * top.c (struct qt_args): Remove.
4253         (kill_or_detach): Change return type to void, replace `void *`
4254         parameter with a proper one.
4255         (print_inferior_quit_action):  Likewise.
4256         (quit_confirm): Use range-based for loop to iterate over inferiors.
4257         (quit_force): Likewise.
4258
4259 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4260
4261         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
4262         `void *` parameter with proper parameters.
4263         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
4264         (print_one_inferior): Change return type to void, replace `void *`
4265         parameter with proper parameters.
4266         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
4267         inferiors.
4268         (get_other_inferior): Remove.
4269         (mi_cmd_remove_inferior): Use range-based loop to iterate over
4270         inferiors.
4271
4272 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4273
4274         * mi/mi-interp.c (report_initial_inferior): Remove.
4275         (mi_interp::init): Use range-based for to iterate over inferiors.
4276
4277 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4278
4279         * python/py-inferior.c (build_inferior_list): Remove.
4280         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
4281
4282 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
4283
4284         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
4285         (btrace_stitch_trace): Likewise.
4286         * charset.c (intermediate_encoding): Likewise (vaild).
4287         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
4288         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
4289         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
4290
4291 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
4292
4293         * windows-tdep.c (windows_get_tlb_type):
4294         Add rtl_user_process_parameters type.
4295
4296 2020-01-16  Pedro Alves  <palves@redhat.com>
4297             Norbert Lange  <nolange79@gmail.com>
4298
4299         PR build/24805
4300         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
4301         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
4302         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
4303         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
4304         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
4305         (ps_plog): Redeclare exported functions with default visibility.
4306
4307 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
4308
4309         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
4310         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
4311
4312 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
4313
4314         * infcmd.c (post_create_inferior): Use get_thread_regcache
4315         instead of get_current_regcache.
4316
4317 2020-01-14  Tom Tromey  <tom@tromey.com>
4318
4319         PR symtab/12535:
4320         * python/python.c (gdbpy_decode_line): Treat empty string the same
4321         as no argument.
4322
4323 2020-01-14  Tom Tromey  <tom@tromey.com>
4324
4325         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
4326
4327 2020-01-14  Tom Tromey  <tom@tromey.com>
4328
4329         * nat/linux-btrace.c: Don't include <config.h>.
4330         * nat/linux-ptrace.c: Don't include <config.h>.
4331         * nat/x86-linux-dregs.c: Don't include <config.h>.
4332
4333 2020-01-14  Tom Tromey  <tom@tromey.com>
4334
4335         * configure: Rebuild.
4336         * configure.ac: Move many checks to ../gdbsupport/common.m4.
4337
4338 2020-01-14  Tom Tromey  <tom@tromey.com>
4339
4340         * nat/x86-linux-dregs.c: Include configh.h.
4341         * nat/linux-ptrace.c: Include configh.h.
4342         * nat/linux-btrace.c: Include configh.h.
4343         * defs.h: Include config.h, bfd.h.
4344         * configure.ac: Don't source common.host.
4345         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
4346         * configure: Rebuild.
4347         * acinclude.m4: Update path.
4348         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
4349         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
4350         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
4351         (CLIBS): Add LIBSUPPORT.
4352         (CDEPS): Likewise.
4353         (COMMON_SFILES): Remove gdbsupport files.
4354         (HFILES_NO_SRCDIR): Likewise.
4355         (stamp-version): Update path to create-version.sh.
4356         (ALLDEPFILES): Remove gdbsupport files.
4357
4358 2020-01-14  Tom Tromey  <tom@tromey.com>
4359
4360         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
4361         USE_WIN32API when needed.
4362         * configure.ac (USE_WIN32API): Don't define.
4363         (WIN32LIBS): Use WIN32APILIBS.
4364         * configure: Rebuild.
4365
4366 2020-01-14  Tom Tromey  <tom@tromey.com>
4367
4368         * configure: Rebuild.
4369         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
4370
4371 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4372
4373         * skip.c (skip_function_command): Make skip w/o arguments use the
4374         name of the inlined function if pc is inside any inlined function.
4375
4376 2020-01-14  Luis Machado  <luis.machado@linaro.org>
4377
4378         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
4379         * infrun.c (resume_1): Likewise.
4380         (handle_inferior_event): Remove stale comment.
4381         * linux-nat.c (linux_nat_target::resume): Update comments.
4382         (save_stop_reason): Likewise.
4383         (linux_nat_filter_event): Likewise.
4384         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
4385
4386 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4387
4388         * elfread.c (record_minimal_symbol): Set section index to 0 for
4389         non-allocatable sections.
4390
4391
4392 2020-01-13  Ali Tamur <tamur@google.com>
4393
4394         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
4395         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
4396         to gdb::optional.  Update comments.
4397         (dwo_file): Update comments.
4398         (read_attribute): Update API to take an additional out parameter,
4399         need_reprocess.  This is used to mark attributes that need other
4400         attributes (e.g. str_offsets_base) for correct computation which may not
4401         have been read yet.
4402         (read_attribute_reprocess): New function declaration.
4403         (read_addr_index): Likewise.
4404         (read_dwo_str_index): Likewise.
4405         (read_stub_str_index): Likewise.
4406         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
4407         (lookup_addr_base): New function definition.
4408         (lookup_ranges_base): Likewise.
4409         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
4410         lookup_ranges_base.
4411         (init_cutu_and_read_dies): Update comments.
4412         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
4413         unit.  This is used to inherit parent's str_offsets_base and addr_base.
4414         Update comments.
4415         (init_cutu_and_read_dies_simple): Reflect API changes.
4416         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
4417         (create_cus_hash_table): Change API to take parent compile unit.
4418         Reflect API changes.
4419         (open_and_init_dwo_file): Reflect API changes.
4420         (dwarf2_get_pc_bounds): Update comments.
4421         (dwarf2_record_block_ranges): Likewise.
4422         (read_full_die_1): Change implementation to reprocess attributes that
4423         need str_offsets_base and addr_base.
4424         (partial_die_info::read): Likewise.
4425         (read_attribute_reprocess): New function definition.
4426         (read_attribute_value): Change API to take an additional out parameter,
4427         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
4428         when a non-dwo compile unit has index based attributes.
4429         (read_attribute): Reflect API changes.
4430         (read_addr_index_1): Reflect API changes.  Update comments.
4431         (dwarf2_read_addr_index_data): Reflect API changes.
4432         (dwarf2_read_addr_index): Likewise.
4433         (read_str_index): Change API and implementation.  This becomes a helper
4434         to be used by the new string index related methods.  Update error
4435         message and comments.
4436         (read_dwo_str_index): New function definition.
4437         (read_stub_str_index): Likewise.
4438         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
4439         * symfile.h (dwarf2_debug_sections): Likewise.
4440         * xcoffread.c (dwarf2_debug_sections): Likewise.
4441
4442 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4443
4444         * gdbcore.h (struct core_fns) <core_read_registers>: Change
4445         core_reg_sect type to gdb_byte *.
4446         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
4447         * cris-tdep.c (fetch_core_registers): Likewise.
4448         * corelow.c (core_target::get_core_register_section): Change
4449         type of `contents` to gdb::byte_vector.
4450
4451 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4452
4453         * tui/tui-wingeneral.c (box_win): Position the title in the center
4454         of the border.
4455
4456 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4457
4458         * corelow.c (core_target::get_core_register_section): Use
4459           std::vector instead of alloca.
4460
4461 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4462
4463         * warning.m4: Add -Wmissing-declarations to build_warnings.
4464         * configure: Re-generate.
4465
4466 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4467
4468         * python/python.c (init__gdb_module): Add declaration.
4469
4470 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4471
4472         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
4473         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
4474         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
4475         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
4476         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
4477         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
4478         * ada-exp.y (_initialize_ada_exp): Add declaration.
4479         * ada-lang.c (_initialize_ada_language): Add declaration.
4480         * ada-tasks.c (_initialize_tasks): Add declaration.
4481         * agent.c (_initialize_agent): Add declaration.
4482         * aix-thread.c (_initialize_aix_thread): Add declaration.
4483         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
4484         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
4485         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
4486         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
4487         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
4488         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
4489         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
4490         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
4491         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
4492         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
4493         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
4494         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
4495         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
4496         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
4497         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
4498         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
4499         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
4500         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
4501         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
4502         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
4503         * annotate.c (_initialize_annotate): Add declaration.
4504         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
4505         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
4506         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
4507         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
4508         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
4509         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
4510         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
4511         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
4512         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
4513         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
4514         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
4515         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
4516         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
4517         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
4518         * auto-load.c (_initialize_auto_load): Add declaration.
4519         * auxv.c (_initialize_auxv): Add declaration.
4520         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
4521         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
4522         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
4523         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
4524         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
4525         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
4526         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
4527         * breakpoint.c (_initialize_breakpoint): Add declaration.
4528         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
4529         * btrace.c (_initialize_btrace): Add declaration.
4530         * charset.c (_initialize_charset): Add declaration.
4531         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
4532         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
4533         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
4534         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
4535         * cli/cli-script.c (_initialize_cli_script): Add declaration.
4536         * cli/cli-style.c (_initialize_cli_style): Add declaration.
4537         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
4538         * coffread.c (_initialize_coffread): Add declaration.
4539         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
4540         * compile/compile.c (_initialize_compile): Add declaration.
4541         * complaints.c (_initialize_complaints): Add declaration.
4542         * completer.c (_initialize_completer): Add declaration.
4543         * copying.c (_initialize_copying): Add declaration.
4544         * corefile.c (_initialize_core): Add declaration.
4545         * corelow.c (_initialize_corelow): Add declaration.
4546         * cp-abi.c (_initialize_cp_abi): Add declaration.
4547         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
4548         * cp-support.c (_initialize_cp_support): Add declaration.
4549         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
4550         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
4551         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
4552         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
4553         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
4554         * ctfread.c (_initialize_ctfread): Add declaration.
4555         * d-lang.c (_initialize_d_language): Add declaration.
4556         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
4557         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
4558         * dbxread.c (_initialize_dbxread): Add declaration.
4559         * dcache.c (_initialize_dcache): Add declaration.
4560         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
4561         * disasm.c (_initialize_disasm): Add declaration.
4562         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
4563         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
4564         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
4565         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
4566         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
4567         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
4568         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
4569         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
4570         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
4571         * elfread.c (_initialize_elfread): Add declaration.
4572         * exec.c (_initialize_exec): Add declaration.
4573         * extension.c (_initialize_extension): Add declaration.
4574         * f-lang.c (_initialize_f_language): Add declaration.
4575         * f-valprint.c (_initialize_f_valprint): Add declaration.
4576         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
4577         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
4578         * filesystem.c (_initialize_filesystem): Add declaration.
4579         * findcmd.c (_initialize_mem_search): Add declaration.
4580         * findvar.c (_initialize_findvar): Add declaration.
4581         * fork-child.c (_initialize_fork_child): Add declaration.
4582         * frame-base.c (_initialize_frame_base): Add declaration.
4583         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
4584         * frame.c (_initialize_frame): Add declaration.
4585         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
4586         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
4587         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
4588         * gcore.c (_initialize_gcore): Add declaration.
4589         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
4590         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
4591         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
4592         * gdbarch.c (_initialize_gdbarch): Add declaration.
4593         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
4594         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
4595         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
4596         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
4597         * go-lang.c (_initialize_go_language): Add declaration.
4598         * go32-nat.c (_initialize_go32_nat): Add declaration.
4599         * guile/guile.c (_initialize_guile): Add declaration.
4600         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
4601         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
4602         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
4603         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
4604         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
4605         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
4606         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
4607         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
4608         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
4609         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
4610         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
4611         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
4612         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
4613         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
4614         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
4615         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
4616         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
4617         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
4618         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
4619         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
4620         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
4621         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
4622         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
4623         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
4624         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
4625         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
4626         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
4627         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
4628         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
4629         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
4630         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
4631         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
4632         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
4633         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
4634         * infcall.c (_initialize_infcall): Add declaration.
4635         * infcmd.c (_initialize_infcmd): Add declaration.
4636         * inflow.c (_initialize_inflow): Add declaration.
4637         * infrun.c (_initialize_infrun): Add declaration.
4638         * interps.c (_initialize_interpreter): Add declaration.
4639         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
4640         * jit.c (_initialize_jit): Add declaration.
4641         * language.c (_initialize_language): Add declaration.
4642         * linux-fork.c (_initialize_linux_fork): Add declaration.
4643         * linux-nat.c (_initialize_linux_nat): Add declaration.
4644         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
4645         * linux-thread-db.c (_initialize_thread_db): Add declaration.
4646         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
4647         * m2-lang.c (_initialize_m2_language): Add declaration.
4648         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
4649         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
4650         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
4651         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
4652         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
4653         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
4654         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
4655         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
4656         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
4657         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
4658         * machoread.c (_initialize_machoread): Add declaration.
4659         * macrocmd.c (_initialize_macrocmd): Add declaration.
4660         * macroscope.c (_initialize_macroscope): Add declaration.
4661         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
4662         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
4663         * maint.c (_initialize_maint_cmds): Add declaration.
4664         * mdebugread.c (_initialize_mdebugread): Add declaration.
4665         * memattr.c (_initialize_mem): Add declaration.
4666         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
4667         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
4668         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
4669         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
4670         * mi/mi-main.c (_initialize_mi_main): Add declaration.
4671         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
4672         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
4673         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
4674         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
4675         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
4676         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
4677         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
4678         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
4679         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
4680         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
4681         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
4682         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
4683         * mipsread.c (_initialize_mipsread): Add declaration.
4684         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
4685         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
4686         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
4687         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
4688         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
4689         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
4690         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
4691         * nto-procfs.c (_initialize_procfs): Add declaration.
4692         * objc-lang.c (_initialize_objc_language): Add declaration.
4693         * observable.c (_initialize_observer): Add declaration.
4694         * opencl-lang.c (_initialize_opencl_language): Add declaration.
4695         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
4696         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
4697         * osabi.c (_initialize_gdb_osabi): Add declaration.
4698         * osdata.c (_initialize_osdata): Add declaration.
4699         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
4700         * parse.c (_initialize_parse): Add declaration.
4701         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
4702         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
4703         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
4704         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
4705         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
4706         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
4707         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
4708         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
4709         * printcmd.c (_initialize_printcmd): Add declaration.
4710         * probe.c (_initialize_probe): Add declaration.
4711         * proc-api.c (_initialize_proc_api): Add declaration.
4712         * proc-events.c (_initialize_proc_events): Add declaration.
4713         * proc-service.c (_initialize_proc_service): Add declaration.
4714         * procfs.c (_initialize_procfs): Add declaration.
4715         * producer.c (_initialize_producer): Add declaration.
4716         * psymtab.c (_initialize_psymtab): Add declaration.
4717         * python/python.c (_initialize_python): Add declaration.
4718         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
4719         * record-btrace.c (_initialize_record_btrace): Add declaration.
4720         * record-full.c (_initialize_record_full): Add declaration.
4721         * record.c (_initialize_record): Add declaration.
4722         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
4723         * regcache.c (_initialize_regcache): Add declaration.
4724         * reggroups.c (_initialize_reggroup): Add declaration.
4725         * remote-notif.c (_initialize_notif): Add declaration.
4726         * remote-sim.c (_initialize_remote_sim): Add declaration.
4727         * remote.c (_initialize_remote): Add declaration.
4728         * reverse.c (_initialize_reverse): Add declaration.
4729         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
4730         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
4731         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
4732         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
4733         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
4734         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
4735         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
4736         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
4737         Add declaration.
4738         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
4739         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
4740         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
4741         * rust-exp.y (_initialize_rust_exp): Add declaration.
4742         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
4743         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
4744         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
4745         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
4746         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
4747         * score-tdep.c (_initialize_score_tdep): Add declaration.
4748         * ser-go32.c (_initialize_ser_dos): Add declaration.
4749         * ser-mingw.c (_initialize_ser_windows): Add declaration.
4750         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
4751         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
4752         * ser-uds.c (_initialize_ser_socket): Add declaration.
4753         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
4754         * serial.c (_initialize_serial): Add declaration.
4755         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
4756         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
4757         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
4758         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
4759         * skip.c (_initialize_step_skip): Add declaration.
4760         * sol-thread.c (_initialize_sol_thread): Add declaration.
4761         * solib-aix.c (_initialize_solib_aix): Add declaration.
4762         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
4763         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
4764         * solib-frv.c (_initialize_frv_solib): Add declaration.
4765         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
4766         * solib-target.c (_initialize_solib_target): Add declaration.
4767         * solib.c (_initialize_solib): Add declaration.
4768         * source-cache.c (_initialize_source_cache): Add declaration.
4769         * source.c (_initialize_source): Add declaration.
4770         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
4771         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
4772         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
4773         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
4774         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
4775         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
4776         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
4777         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
4778         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
4779         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
4780         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
4781         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
4782         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
4783         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
4784         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
4785         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
4786         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
4787         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
4788         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
4789         * stabsread.c (_initialize_stabsread): Add declaration.
4790         * stack.c (_initialize_stack): Add declaration.
4791         * stap-probe.c (_initialize_stap_probe): Add declaration.
4792         * std-regs.c (_initialize_frame_reg): Add declaration.
4793         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
4794         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
4795         * symfile.c (_initialize_symfile): Add declaration.
4796         * symmisc.c (_initialize_symmisc): Add declaration.
4797         * symtab.c (_initialize_symtab): Add declaration.
4798         * target.c (_initialize_target): Add declaration.
4799         * target-connection.c (_initialize_target_connection): Add
4800         declaration.
4801         * target-dcache.c (_initialize_target_dcache): Add declaration.
4802         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
4803         * thread.c (_initialize_thread): Add declaration.
4804         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
4805         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
4806         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
4807         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
4808         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
4809         * tracectf.c (_initialize_ctf): Add declaration.
4810         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
4811         * tracefile.c (_initialize_tracefile): Add declaration.
4812         * tracepoint.c (_initialize_tracepoint): Add declaration.
4813         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
4814         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
4815         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
4816         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
4817         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
4818         * tui/tui-win.c (_initialize_tui_win): Add declaration.
4819         * tui/tui.c (_initialize_tui): Add declaration.
4820         * typeprint.c (_initialize_typeprint): Add declaration.
4821         * ui-style.c (_initialize_ui_style): Add declaration.
4822         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
4823         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
4824         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
4825         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
4826         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
4827         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
4828         * unittests/filtered_iterator-selftests.c
4829         (_initialize_filtered_iterator_selftests): Add declaration.
4830         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
4831         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
4832         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
4833         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
4834         * unittests/main-thread-selftests.c
4835         (_initialize_main_thread_selftests): Add declaration.
4836         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
4837         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
4838         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
4839         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
4840         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
4841         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
4842         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
4843         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
4844         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
4845         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
4846         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
4847         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
4848         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
4849         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
4850         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
4851         declaration.
4852         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
4853         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
4854         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
4855         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
4856         * user-regs.c (_initialize_user_regs): Add declaration.
4857         * utils.c (_initialize_utils): Add declaration.
4858         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
4859         * valops.c (_initialize_valops): Add declaration.
4860         * valprint.c (_initialize_valprint): Add declaration.
4861         * value.c (_initialize_values): Add declaration.
4862         * varobj.c (_initialize_varobj): Add declaration.
4863         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
4864         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
4865         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
4866         * windows-nat.c (_initialize_windows_nat): Add declaration.
4867         (_initialize_check_for_gdb_ini): Add declaration.
4868         (_initialize_loadable): Add declaration.
4869         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
4870         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
4871         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
4872         * xcoffread.c (_initialize_xcoffread): Add declaration.
4873         * xml-support.c (_initialize_xml_support): Add declaration.
4874         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
4875         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
4876         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
4877         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
4878
4879 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4880
4881         * regformats/regdat.sh: Generate declaration for init function.
4882
4883 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4884
4885         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
4886         up.
4887         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
4888         close_one_inferior>: New methods.
4889         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
4890         pass down target to find_inferior_pid.
4891         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
4892         Pass down target to find_inferior_ptid.
4893         (gdbsim_target::create_inferior): Pass down target to
4894         add_thread_silent.
4895         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
4896         target down to find_inferior_ptid and switch_to_thread.
4897         (gdbsim_target::close): Update to call close_one_inferior.
4898         (struct resume_data): Remove.
4899         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
4900         directly, rather than through a void pointer.
4901         (gdbsim_target::resume): Update to call resume_one_inferior.
4902
4903 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
4904
4905         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
4906
4907 2020-01-12  Pedro Alves  <palves@redhat.com>
4908
4909         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
4910         directly for the current inferior instead of
4911         discard_all_inferiors.
4912         (discard_all_inferiors): Delete.
4913
4914 2020-01-11  Tom Tromey  <tom@tromey.com>
4915
4916         * tui/tui-wingeneral.c (box_win): Check cli_styling.
4917         * tui/tui-winsource.c (tui_source_window_base::refill): Use
4918         deprecated_safe_get_selected_frame.
4919
4920 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4921
4922         * inferior.c (print_inferior): Switch inferior before printing it.
4923
4924 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
4925             Pedro Alves  <palves@redhat.com>
4926
4927         * progspace-and-thread.c (switch_to_program_space_and_thread):
4928         Assert there's an inferior for PSPACE.  Use
4929         switch_to_inferior_no_thread to switch the inferior too.
4930         * progspace.c (program_space::~program_space): Call
4931         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
4932         (program_space::free_all_objfiles): Don't call clear_symtab_users
4933         here.
4934         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
4935
4936 2020-01-10  Pedro Alves  <palves@redhat.com>
4937
4938         * NEWS: Mention multi-target debugging, "info connections", and
4939         "add-inferior -no-connection".
4940
4941 2020-01-10  Pedro Alves  <palves@redhat.com>
4942
4943         * infrun.c: Include "target-connection.h".
4944         (check_multi_target_resumption): New.
4945         (proceed): Call it.
4946         * target-connection.c (make_target_connection_string): Make
4947         extern.
4948         * target-connection.h (make_target_connection_string): Declare.
4949
4950 2020-01-10  Pedro Alves  <palves@redhat.com>
4951
4952         * Makefile.in (COMMON_SFILES): Add target-connection.c.
4953         * inferior.c (uiout_field_connection): New function.
4954         (print_inferior): Add new "connection-id" column.
4955         (add_inferior_command): Show connection number/string of added
4956         inferior.
4957         * process-stratum-target.h
4958         (process_stratum_target::connection_string): New virtual method.
4959         (process_stratum_target::connection_number): New field.
4960         * remote.c (remote_target::connection_string): New override.
4961         * target-connection.c: New file.
4962         * target-connection.h: New file.
4963         * target.c (decref_target): Remove process_stratum targets from
4964         the connection list.
4965         (target_stack::push): Add process_stratum targets to the
4966         connection list.
4967
4968 2020-01-10  Pedro Alves  <palves@redhat.com>
4969
4970         Revert:
4971         2016-04-12  Pedro Alves  <palves@redhat.com>
4972         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
4973         Remove references to name.
4974         * serial.h (struct serial) <name>: Delete.
4975
4976 2020-01-10  Pedro Alves  <palves@redhat.com>
4977
4978         * gdbarch-selftests.c (register_to_value_test): Remove "target
4979         already pushed" check.
4980
4981 2020-01-10  Pedro Alves  <palves@redhat.com>
4982             John Baldwin  <jhb@FreeBSD.org>
4983
4984         * aarch64-linux-nat.c
4985         (aarch64_linux_nat_target::thread_architecture): Adjust.
4986         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
4987         (task_command_1): Likewise.
4988         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
4989         (aix_thread_target::wait, aix_thread_target::fetch_registers)
4990         (aix_thread_target::store_registers)
4991         (aix_thread_target::thread_alive): Adjust.
4992         * amd64-fbsd-tdep.c: Include "inferior.h".
4993         (amd64fbsd_get_thread_local_address): Pass down target.
4994         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
4995         thread's gdbarch instead of target_gdbarch.
4996         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
4997         get_last_target_status.
4998         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
4999         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
5000         inferiors.
5001         (update_inserted_breakpoint_locations): Skip if inferiors with no
5002         execution.
5003         (update_global_location_list): When handling moribund locations,
5004         find representative inferior for location's pspace, and use thread
5005         count of its process_stratum target.
5006         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
5007         * bsd-uthread.c (bsd_uthread_target::wait): Use
5008         as_process_stratum_target and adjust thread_change_ptid and
5009         add_thread calls.
5010         (bsd_uthread_target::update_thread_list): Use
5011         as_process_stratum_target and adjust find_thread_ptid,
5012         thread_change_ptid and add_thread calls.
5013         * btrace.c (maint_btrace_packet_history_cmd): Adjust
5014         find_thread_ptid call.
5015         * corelow.c (add_to_thread_list): Adjust add_thread call.
5016         (core_target_open): Adjust add_thread_silent and thread_count
5017         calls.
5018         (core_target::pid_to_str): Adjust find_inferior_ptid call.
5019         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
5020         * event-top.c (async_disconnect): Pop targets from all inferiors.
5021         * exec.c (add_target_sections): Push exec target on all inferiors
5022         sharing the program space.
5023         (remove_target_sections): Remove the exec target from all
5024         inferiors sharing the program space.
5025         (exec_on_vfork): New.
5026         * exec.h (exec_on_vfork): Declare.
5027         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
5028         Pass it down.
5029         (fbsd_nat_target::update_thread_list): Adjust.
5030         (fbsd_nat_target::resume): Adjust.
5031         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
5032         down.
5033         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
5034         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
5035         get_thread_arch_regcache call.
5036         * fork-child.c (gdb_startup_inferior): Pass target down to
5037         startup_inferior and set_executing.
5038         * gdbthread.h (struct process_stratum_target): Forward declare.
5039         (add_thread, add_thread_silent, add_thread_with_info)
5040         (in_thread_list): Add process_stratum_target parameter.
5041         (find_thread_ptid(inferior*, ptid_t)): New overload.
5042         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
5043         parameter.
5044         (all_threads()): Delete overload.
5045         (all_threads, all_non_exited_threads): Add process_stratum_target
5046         parameter.
5047         (all_threads_safe): Use brace initialization.
5048         (thread_count): Add process_stratum_target parameter.
5049         (set_resumed, set_running, set_stop_requested, set_executing)
5050         (threads_are_executing, finish_thread_state): Add
5051         process_stratum_target parameter.
5052         (switch_to_thread): Use is_current_thread.
5053         * i386-fbsd-tdep.c: Include "inferior.h".
5054         (i386fbsd_get_thread_local_address): Pass down target.
5055         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
5056         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
5057         have_inferiors check.
5058         * inf-ptrace.c (inf_ptrace_target::create_inferior)
5059         (inf_ptrace_target::attach): Adjust.
5060         * infcall.c (run_inferior_call): Adjust.
5061         * infcmd.c (run_command_1): Pass target to
5062         scoped_finish_thread_state.
5063         (proceed_thread_callback): Skip inferiors with no execution.
5064         (continue_command): Rename 'all_threads' local to avoid hiding
5065         'all_threads' function.  Adjust get_last_target_status call.
5066         (prepare_one_step): Adjust set_running call.
5067         (signal_command): Use user_visible_resume_target.  Compare thread
5068         pointers instead of inferior_ptid.
5069         (info_program_command): Adjust to pass down target.
5070         (attach_command): Mark target's 'thread_executing' flag.
5071         (stop_current_target_threads_ns): New, factored out from ...
5072         (interrupt_target_1): ... this.  Switch inferior before making
5073         target calls.
5074         * inferior-iter.h
5075         (struct all_inferiors_iterator, struct all_inferiors_range)
5076         (struct all_inferiors_safe_range)
5077         (struct all_non_exited_inferiors_range): Filter on
5078         process_stratum_target too.  Remove explicit.
5079         * inferior.c (inferior::inferior): Push dummy target on target
5080         stack.
5081         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
5082         Add process_stratum_target parameter, and pass it down.
5083         (have_live_inferiors): Adjust.
5084         (switch_to_inferior_and_push_target): New.
5085         (add_inferior_command, clone_inferior_command): Handle
5086         "-no-connection" parameter.  Use
5087         switch_to_inferior_and_push_target.
5088         (_initialize_inferior): Mention "-no-connection" option in
5089         the help of "add-inferior" and "clone-inferior" commands.
5090         * inferior.h: Include "process-stratum-target.h".
5091         (interrupt_target_1): Use bool.
5092         (struct inferior) <push_target, unpush_target, target_is_pushed,
5093         find_target_beneath, top_target, process_target, target_at,
5094         m_stack>: New.
5095         (discard_all_inferiors): Delete.
5096         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
5097         (all_inferiors, all_non_exited_inferiors): Add
5098         process_stratum_target parameter.
5099         * infrun.c: Include "gdb_select.h" and <unordered_map>.
5100         (target_last_proc_target): New global.
5101         (follow_fork_inferior): Push target on new inferior.  Pass target
5102         to add_thread_silent.  Call exec_on_vfork.  Handle target's
5103         reference count.
5104         (follow_fork): Adjust get_last_target_status call.  Also consider
5105         target.
5106         (follow_exec): Push target on new inferior.
5107         (struct execution_control_state) <target>: New field.
5108         (user_visible_resume_target): New.
5109         (do_target_resume): Call target_async.
5110         (resume_1): Set target's threads_executing flag.  Consider resume
5111         target.
5112         (commit_resume_all_targets): New.
5113         (proceed): Also consider resume target.  Skip threads of inferiors
5114         with no execution.  Commit resumtion in all targets.
5115         (start_remote): Pass current inferior to wait_for_inferior.
5116         (infrun_thread_stop_requested): Consider target as well.  Pass
5117         thread_info pointer to clear_inline_frame_state instead of ptid.
5118         (infrun_thread_thread_exit): Consider target as well.
5119         (random_pending_event_thread): New inferior parameter.  Use it.
5120         (do_target_wait): Rename to ...
5121         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
5122         down.
5123         (threads_are_resumed_pending_p, do_target_wait): New.
5124         (prepare_for_detach): Adjust calls.
5125         (wait_for_inferior): New inferior parameter.  Handle it.  Use
5126         do_target_wait_1 instead of do_target_wait.
5127         (fetch_inferior_event): Adjust.  Switch to representative
5128         inferior.  Pass target down.
5129         (set_last_target_status): Add process_stratum_target parameter.
5130         Save target in global.
5131         (get_last_target_status): Add process_stratum_target parameter and
5132         handle it.
5133         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
5134         (context_switch): Check inferior_ptid == null_ptid before calling
5135         inferior_thread().
5136         (get_inferior_stop_soon): Pass down target.
5137         (wait_one): Rename to ...
5138         (poll_one_curr_target): ... this.
5139         (struct wait_one_event): New.
5140         (wait_one): New.
5141         (stop_all_threads): Adjust.
5142         (handle_no_resumed, handle_inferior_event): Adjust to consider the
5143         event's target.
5144         (switch_back_to_stepped_thread): Also consider target.
5145         (print_stop_event): Update.
5146         (normal_stop): Update.  Also consider the resume target.
5147         * infrun.h (wait_for_inferior): Remove declaration.
5148         (user_visible_resume_target): New declaration.
5149         (get_last_target_status, set_last_target_status): New
5150         process_stratum_target parameter.
5151         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
5152         process_stratum_target parameter, and use it.
5153         (clear_inline_frame_state (thread_info*)): New.
5154         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
5155         process_stratum_target parameter.
5156         (clear_inline_frame_state (thread_info*)): Declare.
5157         * linux-fork.c (delete_checkpoint_command): Pass target down to
5158         find_thread_ptid.
5159         (checkpoint_command): Adjust.
5160         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
5161         instead of just tweaking inferior_ptid.
5162         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
5163         (exit_lwp): Pass target down to find_thread_ptid.
5164         (attach_proc_task_lwp_callback): Pass target down to
5165         add_thread/set_running/set_executing.
5166         (linux_nat_target::attach): Pass target down to
5167         thread_change_ptid.
5168         (get_detach_signal): Pass target down to find_thread_ptid.
5169         Consider last target status's target.
5170         (linux_resume_one_lwp_throw, resume_lwp)
5171         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
5172         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
5173         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
5174         (linux_nat_target::async_wait_fd): New.
5175         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
5176         target down.
5177         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
5178         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
5179         * linux-thread-db.c (struct thread_db_info::process_target): New
5180         field.
5181         (add_thread_db_info): Save target.
5182         (get_thread_db_info): New process_stratum_target parameter.  Also
5183         match target.
5184         (delete_thread_db_info): New process_stratum_target parameter.
5185         Also match target.
5186         (thread_from_lwp): Adjust to pass down target.
5187         (thread_db_notice_clone): Pass down target.
5188         (check_thread_db_callback): Pass down target.
5189         (try_thread_db_load_1): Always push the thread_db target.
5190         (try_thread_db_load, record_thread): Pass target down.
5191         (thread_db_target::detach): Pass target down.  Always unpush the
5192         thread_db target.
5193         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
5194         target down.  Always unpush the thread_db target.
5195         (find_new_threads_callback, thread_db_find_new_threads_2)
5196         (thread_db_target::update_thread_list): Pass target down.
5197         (thread_db_target::pid_to_str): Pass current inferior down.
5198         (thread_db_target::get_thread_local_address): Pass target down.
5199         (thread_db_target::resume, maintenance_check_libthread_db): Pass
5200         target down.
5201         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
5202         * procfs.c (procfs_target::procfs_init_inferior): Declare.
5203         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
5204         (procfs_init_inferior): Rename to ...
5205         (procfs_target::procfs_init_inferior): ... this and adjust.
5206         (procfs_target::create_inferior, procfs_notice_thread)
5207         (procfs_do_thread_registers): Adjust.
5208         * ppc-fbsd-tdep.c: Include "inferior.h".
5209         (ppcfbsd_get_thread_local_address): Pass down target.
5210         * proc-service.c (ps_xfer_memory): Switch current inferior and
5211         program space as well.
5212         (get_ps_regcache): Pass target down.
5213         * process-stratum-target.c
5214         (process_stratum_target::thread_address_space)
5215         (process_stratum_target::thread_architecture): Pass target down.
5216         * process-stratum-target.h
5217         (process_stratum_target::threads_executing): New field.
5218         (as_process_stratum_target): New.
5219         * ravenscar-thread.c
5220         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
5221         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
5222         down.
5223         * record-btrace.c (record_btrace_target::info_record): Adjust.
5224         (record_btrace_target::record_method)
5225         (record_btrace_target::record_is_replaying)
5226         (record_btrace_target::fetch_registers)
5227         (get_thread_current_frame_id, record_btrace_target::resume)
5228         (record_btrace_target::wait, record_btrace_target::stop): Pass
5229         target down.
5230         * record-full.c (record_full_wait_1): Switch to event thread.
5231         Pass target down.
5232         * regcache.c (regcache::regcache)
5233         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
5234         process_stratum_target parameter and handle it.
5235         (current_thread_target): New global.
5236         (get_thread_regcache): Add process_stratum_target parameter and
5237         handle it.  Switch inferior before calling target method.
5238         (get_thread_regcache): Pass target down.
5239         (get_thread_regcache_for_ptid): Pass target down.
5240         (registers_changed_ptid): Add process_stratum_target parameter and
5241         handle it.
5242         (registers_changed_thread, registers_changed): Pass target down.
5243         (test_get_thread_arch_aspace_regcache): New.
5244         (current_regcache_test): Define a couple local test_target_ops
5245         instances and use them for testing.
5246         (readwrite_regcache): Pass process_stratum_target parameter.
5247         (cooked_read_test, cooked_write_test): Pass mock_target down.
5248         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
5249         (get_thread_arch_aspace_regcache): Add process_stratum_target
5250         parameter.
5251         (regcache::target): New method.
5252         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
5253         (regcache::registers_changed_ptid): Add process_stratum_target
5254         parameter.
5255         (regcache::m_target): New field.
5256         (registers_changed_ptid): Add process_stratum_target parameter.
5257         * remote.c (remote_state::supports_vCont_probed): New field.
5258         (remote_target::async_wait_fd): New method.
5259         (remote_unpush_and_throw): Add remote_target parameter.
5260         (get_current_remote_target): Adjust.
5261         (remote_target::remote_add_inferior): Push target.
5262         (remote_target::remote_add_thread)
5263         (remote_target::remote_notice_new_inferior)
5264         (get_remote_thread_info): Pass target down.
5265         (remote_target::update_thread_list): Skip threads of inferiors
5266         bound to other targets.  (remote_target::close): Don't discard
5267         inferiors.  (remote_target::add_current_inferior_and_thread)
5268         (remote_target::process_initial_stop_replies)
5269         (remote_target::start_remote)
5270         (remote_target::remote_serial_quit_handler): Pass down target.
5271         (remote_target::remote_unpush_target): New remote_target
5272         parameter.  Unpush the target from all inferiors.
5273         (remote_target::remote_unpush_and_throw): New remote_target
5274         parameter.  Pass it down.
5275         (remote_target::open_1): Check whether the current inferior has
5276         execution instead of checking whether any inferior is live.  Pass
5277         target down.
5278         (remote_target::remote_detach_1): Pass down target.  Use
5279         remote_unpush_target.
5280         (extended_remote_target::attach): Pass down target.
5281         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
5282         (remote_target::append_resumption): Pass down target.
5283         (remote_target::append_pending_thread_resumptions)
5284         (remote_target::remote_resume_with_hc, remote_target::resume)
5285         (remote_target::commit_resume): Pass down target.
5286         (remote_target::remote_stop_ns): Check supports_vCont_probed.
5287         (remote_target::interrupt_query)
5288         (remote_target::remove_new_fork_children)
5289         (remote_target::check_pending_events_prevent_wildcard_vcont)
5290         (remote_target::remote_parse_stop_reply)
5291         (remote_target::process_stop_reply): Pass down target.
5292         (first_remote_resumed_thread): New remote_target parameter.  Pass
5293         it down.
5294         (remote_target::wait_as): Pass down target.
5295         (unpush_and_perror): New remote_target parameter.  Pass it down.
5296         (remote_target::readchar, remote_target::remote_serial_write)
5297         (remote_target::getpkt_or_notif_sane_1)
5298         (remote_target::kill_new_fork_children, remote_target::kill): Pass
5299         down target.
5300         (remote_target::mourn_inferior): Pass down target.  Use
5301         remote_unpush_target.
5302         (remote_target::core_of_thread)
5303         (remote_target::remote_btrace_maybe_reopen): Pass down target.
5304         (remote_target::pid_to_exec_file)
5305         (remote_target::thread_handle_to_thread_info): Pass down target.
5306         (remote_target::async_wait_fd): New.
5307         * riscv-fbsd-tdep.c: Include "inferior.h".
5308         (riscv_fbsd_get_thread_local_address): Pass down target.
5309         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
5310         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
5311         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
5312         Adjust.
5313         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
5314         * solib-svr4.c (enable_break): Pass down target.
5315         * spu-multiarch.c (parse_spufs_run): Pass down target.
5316         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
5317         * target-delegates.c: Regenerate.
5318         * target.c (g_target_stack): Delete.
5319         (current_top_target): Return the current inferior's top target.
5320         (target_has_execution_1): Refer to the passed-in inferior's top
5321         target.
5322         (target_supports_terminal_ours): Check whether the initial
5323         inferior was already created.
5324         (decref_target): New.
5325         (target_stack::push): Incref/decref the target.
5326         (push_target, push_target, unpush_target): Adjust.
5327         (target_stack::unpush): Defref target.
5328         (target_is_pushed): Return bool.  Adjust to refer to the current
5329         inferior's target stack.
5330         (dispose_inferior): Delete, and inline parts ...
5331         (target_preopen): ... here.  Only dispose of the current inferior.
5332         (target_detach): Hold strong target reference while detaching.
5333         Pass target down.
5334         (target_thread_name): Add assertion.
5335         (target_resume): Pass down target.
5336         (target_ops::beneath, find_target_at): Adjust to refer to the
5337         current inferior's target stack.
5338         (get_dummy_target): New.
5339         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
5340         has a thread running.
5341         (initialize_targets): Rename to ...
5342         (_initialize_target): ... this.
5343         * target.h: Include "gdbsupport/refcounted-object.h".
5344         (struct target_ops): Inherit refcounted_object.
5345         (target_ops::shortname, target_ops::longname): Make const.
5346         (target_ops::async_wait_fd): New method.
5347         (decref_target): Declare.
5348         (struct target_ops_ref_policy): New.
5349         (target_ops_ref): New typedef.
5350         (get_dummy_target): Declare function.
5351         (target_is_pushed): Return bool.
5352         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
5353         (all_matching_threads_iterator::all_matching_threads_iterator):
5354         Handle filter target.
5355         * thread-iter.h (struct all_matching_threads_iterator, struct
5356         all_matching_threads_range, class all_non_exited_threads_range):
5357         Filter by target too.  Remove explicit.
5358         * thread.c (threads_executing): Delete.
5359         (inferior_thread): Pass down current inferior.
5360         (clear_thread_inferior_resources): Pass down thread pointer
5361         instead of ptid_t.
5362         (add_thread_silent, add_thread_with_info, add_thread): Add
5363         process_stratum_target parameter.  Use it for thread and inferior
5364         searches.
5365         (is_current_thread): New.
5366         (thread_info::deletable): Use it.
5367         (find_thread_ptid, thread_count, in_thread_list)
5368         (thread_change_ptid, set_resumed, set_running): New
5369         process_stratum_target parameter.  Pass it down.
5370         (set_executing): New process_stratum_target parameter.  Pass it
5371         down.  Adjust reference to 'threads_executing'.
5372         (threads_are_executing): New process_stratum_target parameter.
5373         Adjust reference to 'threads_executing'.
5374         (set_stop_requested, finish_thread_state): New
5375         process_stratum_target parameter.  Pass it down.
5376         (switch_to_thread): Also match inferior.
5377         (switch_to_thread): New process_stratum_target parameter.  Pass it
5378         down.
5379         (update_threads_executing): Reimplement.
5380         * top.c (quit_force): Pop targets from all inferior.
5381         (gdb_init): Don't call initialize_targets.
5382         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
5383         Declare.
5384         (windows_add_thread, windows_delete_thread): Adjust.
5385         (get_windows_debug_event): Rename to ...
5386         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
5387         * tracefile-tfile.c (tfile_target_open): Pass down target.
5388         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
5389         Forward declare.
5390         (switch_to_thread): Add process_stratum_target parameter.
5391         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
5392         parameter.  Use it.
5393         (mi_on_resume): Pass target down.
5394         * nat/fork-inferior.c (startup_inferior): Add
5395         process_stratum_target parameter.  Pass it down.
5396         * nat/fork-inferior.h (startup_inferior): Add
5397         process_stratum_target parameter.
5398         * python/py-threadevent.c (py_get_event_thread): Pass target down.
5399
5400 2020-01-10  Pedro Alves  <palves@redhat.com>
5401
5402         * remote.c (remote_target::start_remote): Don't set inferior_ptid
5403         directly.  Instead find the first thread in the thread list and
5404         use switch_to_thread.
5405
5406 2020-01-10  Pedro Alves  <palves@redhat.com>
5407
5408         * remote.c (remote_target::remote_add_inferior): Don't bind a
5409         process to the current inferior if the current inferior is already
5410         bound to a process.
5411
5412 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5413             Pedro Alves  <palves@redhat.com>
5414
5415         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
5416         If no process is specified, return null_ptid instead of
5417         inferior_ptid.
5418         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
5419         TARGET_WAITKIND_SIGNALLED with no pid.
5420
5421 2020-01-10  Pedro Alves  <palves@redhat.com>
5422
5423         * remote.c (first_remote_resumed_thread): New.
5424         (remote_target::wait_as): Use it as default event_ptid instead of
5425         inferior_ptid.
5426
5427 2020-01-10  Pedro Alves  <palves@redhat.com>
5428
5429         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
5430
5431 2020-01-10  Pedro Alves  <palves@redhat.com>
5432
5433         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
5434         not -1.
5435
5436 2020-01-10  Pedro Alves  <palves@redhat.com>
5437
5438         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
5439         ptid to get_last_target_status.
5440         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
5441         ptid to get_last_target_status.
5442         * infcmd.c (continue_command): Don't pass a target_waitstatus to
5443         get_last_target_status.
5444         (info_program_command): Don't pass a target_waitstatus to
5445         get_last_target_status.
5446         * infrun.c (init_wait_for_inferior): Use
5447         nullify_last_target_wait_ptid.
5448         (get_last_target_status): Handle nullptr arguments.
5449         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
5450         (print_stop_event): Don't pass a ptid to get_last_target_status.
5451         (normal_stop): Don't pass a ptid to get_last_target_status.
5452         * infrun.h (get_last_target_status, set_last_target_status): Move
5453         comments here and update.
5454         (nullify_last_target_wait_ptid): Declare.
5455         * linux-fork.c (fork_load_infrun_state): Remove local extern
5456         declaration of nullify_last_target_wait_ptid.
5457         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
5458         to get_last_target_status.
5459
5460 2020-01-10  Pedro Alves  <palves@redhat.com>
5461
5462         * gdbthread.h (scoped_restore_current_thread)
5463         <dont_restore, restore, m_dont_restore>: Declare.
5464         * thread.c (thread_alive): Add assertion.  Return bool.
5465         (switch_to_thread_if_alive): New.
5466         (prune_threads): Switch inferior/thread.
5467         (print_thread_info_1): Switch thread before calling target methods.
5468         (scoped_restore_current_thread::restore): New, factored out from
5469         ...
5470         (scoped_restore_current_thread::~scoped_restore_current_thread):
5471         ... this.
5472         (scoped_restore_current_thread::scoped_restore_current_thread):
5473         Add assertion.
5474         (thread_apply_all_command, thread_select): Use
5475         switch_to_thread_if_alive.
5476         * infrun.c (proceed, restart_threads, handle_signal_stop)
5477         (switch_back_to_stepped_thread): Switch current thread before
5478         calling target methods.
5479
5480 2020-01-10  Pedro Alves <palves@redhat.com>
5481
5482         * inferior.c (switch_to_inferior_no_thread): New function,
5483         factored out from ...
5484         (inferior_command): ... here.
5485         * inferior.h (switch_to_inferior_no_thread): Declare.
5486         * mi/mi-main.c (run_one_inferior): Use
5487         switch_to_inferior_no_thread.
5488
5489 2020-01-10  Pedro Alves  <palves@redhat.com>
5490
5491         * infcmd.c (kill_command): Remove dead code.
5492
5493 2020-01-10  Pedro Alves  <palves@redhat.com>
5494
5495         * remote.c (remote_target::mourn_inferior): No longer check
5496         whether the target is running.
5497
5498 2020-01-10  Pedro Alves  <palves@redhat.com>
5499
5500         * corelow.c (core_target::has_execution): Change parameter type to
5501         inferior pointer.
5502         * inferior.c (number_of_live_inferiors): Use
5503         inferior::has_execution instead of target_has_execution_1.
5504         * inferior.h (inferior::has_execution): New.
5505         * linux-thread-db.c (thread_db_target::update_thread_list): Use
5506         inferior::has_execution instead of target_has_execution_1.
5507         * process-stratum-target.c
5508         (process_stratum_target::has_execution): Change parameter type to
5509         inferior pointer.  Check the inferior's PID instead of
5510         inferior_ptid.
5511         * process-stratum-target.h
5512         (process_stratum_target::has_execution): Change parameter type to
5513         inferior pointer.
5514         * record-full.c (record_full_core_target::has_execution): Change
5515         parameter type to inferior pointer.
5516         * target.c (target_has_execution_1): Change parameter type to
5517         inferior pointer.
5518         (target_has_execution_current): Adjust.
5519         * target.h (target_ops::has_execution): Change parameter type to
5520         inferior pointer.
5521         (target_has_execution_1): Change parameter type to inferior
5522         pointer.  Change return type to bool.
5523         * tracefile.h (tracefile_target::has_execution): Change parameter
5524         type to inferior pointer.
5525
5526 2020-01-10  Pedro Alves  <palves@redhat.com>
5527
5528         * exceptions.c (print_flush): Remove current_top_target() check.
5529
5530 2020-01-10  Pedro Alves  <palves@redhat.com>
5531
5532         * remote.c (show_remote_exec_file): Show the current inferior's
5533         exec-file instead of the command variable's value.
5534
5535 2020-01-10  Pedro Alves  <palves@redhat.com>
5536
5537         * record-full.c (record_full_resume_ptid): New global.
5538         (record_full_target::resume): Set it.
5539         (record_full_wait_1): Use record_full_resume_ptid instead of
5540         inferior_ptid.
5541
5542 2020-01-10  Pedro Alves  <palves@redhat.com>
5543
5544         * gdbthread.h (scoped_restore_current_thread)
5545         <dont_restore, restore, m_dont_restore>: Declare.
5546         * thread.c (thread_alive): Add assertion.  Return bool.
5547         (switch_to_thread_if_alive): New.
5548         (prune_threads): Switch inferior/thread.
5549         (print_thread_info_1): Switch thread before calling target methods.
5550         (scoped_restore_current_thread::restore): New, factored out from
5551         ...
5552         (scoped_restore_current_thread::~scoped_restore_current_thread):
5553         ... this.
5554         (scoped_restore_current_thread::scoped_restore_current_thread):
5555         Add assertion.
5556         (thread_apply_all_command, thread_select): Use
5557         switch_to_thread_if_alive.
5558
5559 2020-01-10  George Barrett  <bob@bob131.so>
5560
5561         * stap-probe.c (stap_modify_semaphore): Don't check for null
5562         semaphores.
5563         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
5564         for null semaphores.
5565
5566 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
5569         all source windows, and maintain horizontal scroll status while
5570         doing so.
5571
5572 2020-01-09  Tom Tromey  <tom@tromey.com>
5573
5574         PR tui/18932:
5575         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
5576         update_source_window, not print_source_lines.
5577
5578 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * tui/tui.c (tui_enable): Register tui hooks after calling
5581         tui_display_main.
5582
5583 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
5584
5585         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
5586
5587 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
5588
5589         * thread.c (print_thread_info_1): Fix indentation.
5590
5591 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
5592
5593         * symtab.c (general_symbol_info::compute_and_set_names): Move the
5594         unique_xmalloc_ptr outside the if to always free the demangled name.
5595
5596 2020-01-08  Tom Tromey  <tromey@adacore.com>
5597
5598         * xcoffread.c (enter_line_range, read_xcoff_symtab)
5599         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
5600         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
5601         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
5602         Remove.
5603         (section_offsets): New typedef.
5604         * symtab.c (fixup_section, get_msymbol_address): Update.
5605         * symmisc.c (dump_msymbols): Update.
5606         * symfile.h (relative_addr_info_to_section_offsets)
5607         (symfile_map_offsets_to_segments): Update.
5608         * symfile.c (build_section_addr_info_from_objfile)
5609         (init_objfile_sect_indices): Update.
5610         (struct place_section_arg): Change type of "offsets".
5611         (place_section): Update.
5612         (relative_addr_info_to_section_offsets): Change type of
5613         "section_offsets".  Remove "num_sections" parameter.
5614         (default_symfile_offsets, syms_from_objfile_1)
5615         (set_objfile_default_section_offset): Update.
5616         (reread_symbols): No need to preserve section offsets by hand.
5617         (symfile_map_offsets_to_segments): Change type of "offsets".
5618         * stap-probe.c (relocate_address): Update.
5619         * stabsread.h (process_one_symbol): Update.
5620         * solib-target.c (struct lm_info_target) <offsets>: Change type.
5621         (solib_target_relocate_section_addresses): Update.
5622         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
5623         Update.
5624         * solib-frv.c (frv_relocate_main_executable): Update.
5625         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
5626         * solib-aix.c (solib_aix_get_section_offsets): Change return
5627         type.
5628         (solib_aix_solib_create_inferior_hook): Update.
5629         * remote.c (remote_target::get_offsets): Update.
5630         * psymtab.c (find_pc_sect_psymtab): Update.
5631         * psympriv.h (struct partial_symbol) <address, text_low,
5632         text_high>: Update.
5633         * objfiles.h (obj_section_offset): Update.
5634         (struct objfile) <section_offsets>: Change type.
5635         <num_sections>: Remove.
5636         (objfile_relocate): Update.
5637         * objfiles.c (entry_point_address_query): Update
5638         (relocate_one_symbol): Change type of "section_offsets".
5639         (objfile_relocate1, objfile_relocate1): Change type of
5640         "new_offsets".
5641         (objfile_rebase1): Update.
5642         * mipsread.c (mipscoff_symfile_read): Update.
5643         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
5644         parameter.
5645         * mdebugread.c (parse_symbol): Change type of "section_offsets".
5646         (parse_external, psymtab_to_symtab_1): Update.
5647         * machoread.c (macho_symfile_offsets): Update.
5648         * ia64-tdep.c (ia64_find_unwind_table): Update.
5649         * hppa-tdep.c (read_unwind_info): Update.
5650         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
5651         * dwarf2read.c (create_addrmap_from_index)
5652         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5653         (process_psymtab_comp_unit_reader, add_partial_symbol)
5654         (add_partial_subprogram, process_full_comp_unit)
5655         (read_file_scope, read_func_scope, read_lexical_block_scope)
5656         (read_call_site_scope, dwarf2_rnglists_process)
5657         (dwarf2_ranges_process, dwarf2_ranges_read)
5658         (dwarf_decode_lines_1, var_decode_location, new_symbol)
5659         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
5660         Update.
5661         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
5662         Update.
5663         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
5664         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
5665         (process_one_symbol): Change type of "section_offsets".
5666         * ctfread.c (get_objfile_text_range): Update.
5667         * coffread.c (coff_symtab_read, enter_linenos)
5668         (process_coff_symbol): Update.
5669         * coff-pe-read.c (add_pe_forwarded_sym): Update.
5670         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
5671
5672 2020-01-08  Tom Tromey  <tromey@adacore.com>
5673
5674         * dwarf2read.c (parse_macro_definition): Use std::string.
5675         (parse_macro_definition): Likewise.
5676
5677 2020-01-08  Tom Tromey  <tromey@adacore.com>
5678
5679         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
5680         (ATTR_ALLOC_CHUNK): Remove.
5681
5682 2020-01-08  Tom Tromey  <tromey@adacore.com>
5683
5684         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
5685
5686 2020-01-08  Tom Tromey  <tromey@adacore.com>
5687
5688         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
5689         (dwarf2_compute_name, open_dwo_file): Likewise.
5690         (process_enumeration_scope): Use std::vector.
5691         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
5692         (partial_die_info::fixup, dwarf2_start_subfile)
5693         (guess_full_die_structure_name, dwarf2_name): Likewise.
5694         (determine_prefix): Update.
5695         (guess_full_die_structure_name): Make return type const.
5696         (partial_die_full_name): Return unique_xmalloc_ptr.
5697         (DW_FIELD_ALLOC_CHUNK): Remove.
5698
5699 2020-01-07  Tom Tromey  <tromey@adacore.com>
5700
5701         PR build/24937:
5702         * stap-probe.c (class stap_static_probe_ops): Add constructor.
5703
5704 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
5705
5706         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
5707
5708 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5709
5710         * stack.c (print_frame_info): Move disassemble_next_line code
5711         inside source_print block.
5712
5713 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5714
5715         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
5716         gdb/signals.h, as we are now using native signal symbols.
5717
5718 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
5719
5720         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
5721         overflow by an early check of content vs threshold.
5722         * tui/tui-source.c (tui_source_window::line_is_displayed):
5723         Likewise.
5724
5725 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5726
5727         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
5728
5729 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
5730
5731         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
5732         export table if no section contains it's RVA.
5733
5734 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5735
5736         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
5737
5738 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
5739
5740         * source.c (print_source_lines_base): Set last_line_listed.
5741
5742 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
5743
5744         * tui/tui-disasm.c: Remove trailing spaces.
5745
5746 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5747             Pedro Alves  <palves@redhat.com>
5748
5749         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
5750         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
5751         (windows_gdb_signal_to_target): New function, uses the above
5752         enumeration to convert GDB internal signal codes to equivalent
5753         Windows codes.
5754         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
5755         * windows-nat.c: Include "gdb_wait.h".
5756         (get_windows_debug_event): Extract the fatal exception from the
5757         exit status and convert to the equivalent Posix signal number.
5758         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
5759         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
5760         * gdbsupport/gdb_wait.c: New file, implements
5761         windows_status_to_termsig.
5762         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
5763         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
5764
5765 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5766
5767         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
5768         show_layout.
5769
5770 2020-01-05  Luis Machado  <luis.machado@linaro.org>
5771
5772         * aarch64-linux-nat.c
5773         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
5774         and bfd_mach_aarch64.
5775
5776 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5777
5778         * ui-file.c (stdio_file::can_emit_style_escape)
5779         (tee_file::can_emit_style_escape): Ensure style is used also on
5780         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
5781         to gdb_stdout.
5782         * main.c (set_gdb_data_directory): Use file style to output the
5783         warning that the given pathname is not a directory.
5784         * top.c (show_history_filename, gdb_safe_append_history)
5785         (show_gdb_datadir): Use file style.
5786
5787 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
5788
5789         * solib-target.c (struct lm_info_target):
5790         Change offsets to be a unique_xmalloc_ptr.
5791         (solib_target_relocate_section_addresses): Update.
5792
5793 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
5794
5795         * windows-nat.c (windows_clear_solib): Free so_list linked list.
5796
5797 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5798
5799         * MAINTAINERS (Write After Approval): Add myself.
5800
5801 2020-01-02  Luis Machado  <luis.machado@linaro.org>
5802
5803         * proc-service.c (get_ps_regcache): Remove reference to obsolete
5804         Cell BE architecture.
5805         * target.h (struct target_ops) <thread_architecture>: Likewise.
5806
5807 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
5808
5809         * Makefile.in: Use INSTALL_PROGRAM_ENV.
5810
5811 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
5812
5813         * MAINTAINERS (Write After Approval): Add myself.
5814
5815 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5816
5817         * gdbarch.sh: Update copyright year range of generated files.
5818
5819 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5820
5821         Update copyright year range in all GDB files.
5822
5823 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5824
5825         * copyright.py: Convert to Python 3.
5826
5827 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5828
5829         * copyright.py: Adapt after move of gnulib directory from gdb
5830         directory to toplevel directory.
5831
5832 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5833
5834         * copyright.py (main): Exit if run from the wrong directory.
5835
5836 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5837
5838         * top.c (print_gdb_version): Change copyright year to 2020.
5839
5840 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5841
5842         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
5843
5844 For older changes see ChangeLog-2019.
5845 \f
5846 Local Variables:
5847 mode: change-log
5848 left-margin: 8
5849 fill-column: 74
5850 version-control: never
5851 coding: utf-8
5852 End: