gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
   4         parse a range if "-" is at the end of the string.
   5
   6 2019-06-13  Pedro Alves  <palves@redhat.com>
   7
   8         * cli/cli-setshow.c (parse_auto_binary_operation)
   9         (parse_cli_boolean_value): Don't allow "o".
  10
  11 2019-06-13  Pedro Alves  <palves@redhat.com>
  12
  13         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
  14         * NEWS: Mention maint test-settings KIND.
  15         * maint-test-settings.c: New file.
  16
  17 2019-06-13  Pedro Alves  <palves@redhat.com>
  18
  19         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
  20         completer.
  21         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
  22         "set" completers.
  23
  24 2019-06-13  Pedro Alves  <palves@redhat.com>
  25
  26         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
  27         after item.
  28
  29 2019-06-13  Pedro Alves  <palves@redhat.com>
  30
  31         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
  32
  33 2019-06-13  Pedro Alves <palves@redhat.com>
  34
  35         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
  36         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
  37         call.
  38         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
  39         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
  40         calls.
  41         (check_for_argument): Skip spaces after argument.
  42
  43 2019-06-13  Pedro Alves  <palves@redhat.com>
  44
  45         * thread.c (thread_apply_command): Adjust TID parsing.
  46         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
  47         detected before end of string.
  48         (tid_is_in_list): Error out if LIST is invalid.
  49
  50 2019-06-13  Pedro Alves  <palves@redhat.com>
  51
  52         * completer.c (complete_line_internal_1): Rewind completion word
  53         point.
  54         (completion_tracker::advance_custom_word_point_by): Change
  55         parameter type to int.
  56         * completer.h (completion_tracker::advance_custom_word_point_by):
  57         Likewise.
  58
  59 2019-06-13  Pedro Alves  <palves@redhat.com>
  60
  61         * completer.c (advance_to_completion_word): Handle delimiters.
  62
  63 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
  64
  65         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
  66
  67 2019-06-11  Tom Tromey  <tom@tromey.com>
  68
  69         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
  70         (xmalloc_failed): Move to alloc.c.
  71         * alloc.c: New file.
  72         * Makefile.in (COMMON_SFILES): Add alloc.c.
  73
  74 2019-06-11  Tom Tromey  <tom@tromey.com>
  75
  76         * nat/linux-waitpid.c: Don't include server.h.
  77         (linux_debug): Remove.
  78         (my_waitpid): Update.
  79
  80 2019-06-11  Tom Tromey  <tromey@adacore.com>
  81
  82         * infcall.c (_initialize_infcall): Remove trailing newline from
  83         help.
  84         * user-regs.c (_initialize_user_regs): Remove trailing newline
  85         from help.
  86         * typeprint.c (_initialize_typeprint): Remove trailing newline
  87         from help.
  88         * reverse.c (_initialize_reverse): Remove trailing newlines from
  89         help.
  90         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
  91         from help.
  92         * language.c (add_set_language_command): Remove trailing newline
  93         from help.
  94         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
  95         help.
  96         * disasm.c (_initialize_disasm): Remove trailing newline from
  97         help.
  98         * top.c (init_main): Remove trailing newline from help.
  99         * interps.c (_initialize_interpreter): Remove trailing newline
 100         from help.
 101         * btrace.c (_initialize_btrace): Remove trailing newlines from
 102         help.
 103         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 104         from help.
 105         * python/python.c (_initialize_python): Remove trailing newline
 106         from help.
 107         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 108         help.
 109         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 110         from help.  Reformat some text.
 111         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 112         from help.
 113         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 114         newline from help.
 115
 116 2019-06-11  Tom Tromey  <tromey@adacore.com>
 117
 118         * darwin-nat.c (darwin_decode_exception_message)
 119         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 120
 121 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 122
 123         * valops.c (value_slice): Check for not allocated or not
 124         associated values.
 125
 126 2019-06-10  Tom de Vries  <tdevries@suse.de>
 127
 128         PR gdb/24618
 129         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 130         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 131         invalid.
 132
 133 2019-06-10  Tom de Vries  <tdevries@suse.de>
 134
 135         PR gdb/24611
 136         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 137         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 138
 139 2019-06-10  Tom de Vries  <tdevries@suse.de>
 140
 141         PR symtab/24545
 142         * symtab.c (struct demangled_name_entry): Add language field.
 143         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 144         static minimal symbol".  Set and use language field.
 145
 146 2019-06-10  Tom Tromey  <tromey@adacore.com>
 147
 148         * ada-lang.c (_initialize_ada_language): Update help text.
 149
 150 2019-06-10  Tom Tromey  <tromey@adacore.com>
 151
 152         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 153         with a newline.
 154         * guile/guile.c (handle_boot_error): Don't end warning with a
 155         newline.
 156         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 157         warning with a newline.
 158         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 159         newline.
 160         (s12z_frame_cache): Likewise.
 161         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 162         a newline.
 163         * solib-svr4.c (disable_probes_interface): Don't end warning with
 164         a newline.
 165         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 166         newline.
 167         * python/python.c (do_finish_initialization): Don't end warning
 168         with a newline.
 169
 170 2019-06-10  Tom Tromey  <tom@tromey.com>
 171
 172         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 173         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 174         gdbpy_enter.
 175
 176 2019-06-10  Tom Tromey  <tromey@adacore.com>
 177
 178         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 179         data.
 180         (elf_new_init): Don't call stabsread_new_init.
 181         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 182         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 183         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 184
 185 2019-06-10  Tom de Vries  <tdevries@suse.de>
 186
 187         PR symtab/16264
 188         PR symtab/24517
 189         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 190
 191 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 192
 193         * source.c (find_and_open_source): Also rewrite relative file
 194         names.
 195
 196 2019-04-26  Amos Bird  <amosbird@gmail.com>
 197
 198         * annotate.c (annotate_thread_exited): Add "thread-exited"
 199         annotation.
 200
 201 2019-06-06  Tom Tromey  <tromey@adacore.com>
 202
 203         * maint.h (class scoped_command_stats): Use
 204         DISABLE_COPY_AND_ASSIGN.
 205         <print_time>: New method.
 206         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 207         print_time.
 208         (scoped_command_stats::print_time): New method.
 209
 210 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 213         instructions of lengths 6 or 8 bytes.
 214
 215 2019-06-04  Pedro Alves  <palves@redhat.com>
 216
 217         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 218
 219         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 220         * breakpoint.c (condition_completer): Likewise.
 221         * cli/cli-dump.c (scan_expression): Likewise.
 222         * common/filestuff.c (mkdir_recursive): Likewise.
 223         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 224         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 225         (gdb_abspath): Likewise.
 226         * compile/compile-cplus-types.c
 227         (compile_cplus_instance::decl_name): Likewise.
 228         * completer.c (complete_explicit_location):
 229         (signal_completer, reg_or_group_completer_1): Likewise.
 230         * cp-support.c (cp_remove_params_if_any): Likewise.
 231         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 232         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 233         * infcmd.c (strip_bg_char): Likewise.
 234         * linespec.c (copy_token_string): Likewise.
 235         * mi/mi-main.c (output_cores): Likewise.
 236         * psymtab.c (psymtab_search_name):
 237         * symfile.c (test_set_ext_lang_command): Likewise.
 238         * target.c (target_fileio_read_stralloc): Likewise.
 239         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 240         * value.c (complete_internalvar): Likewise.
 241
 242 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 243
 244         Add objfile property to gdb.Type.
 245         * NEWS: Mention Python API addition.
 246         * python/py-type.c (typy_get_objfile): New method.
 247
 248 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 249
 250         * NEWS: Mention the new set|show style [title|highlight].
 251         Mention changes to "show style", "help" and "apropos".
 252
 253 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 254
 255         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 256         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 257         instead of print_help_for_command.
 258         (print_doc_of_command): New function.
 259         (help_list): Add 'apropos -v word' suggestion.
 260         (print_help_for_command): Style the command name using title style.
 261         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 262         (_initialize_cli_cmds): Describe -v in apropos_command help.
 263
 264 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 265
 266         * cli/cli-style.h (cli_style_option): Add name in constructor,
 267         add m_name class member, add constructor with intensity,
 268         add name class function.
 269         (cli_style_option::add_setshow_commands): Remove name argument.
 270         (highlight_style, title_style): New styles.
 271         * cli/cli-style.c (do_show): New function that shows a style
 272         characteristic styling the style name with itself.
 273         (set_style_name): New function.
 274         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 275         Update all callers according to the changes in cli/cli-style.h.
 276         * utils.h (fputs_highlighted): New function.
 277         * utils.c (fputs_highlighted): Likewise.
 278
 279 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 280
 281         * NEWS: Mention new pipe command and new convenience variables.
 282
 283 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 284
 285         * cli/cli-cmds.c (pipe_command): New function.
 286         (_initialize_cli_cmds): Call add_com for pipe_command.
 287         Define | as an alias for pipe.
 288         (exit_status_set_internal_vars): New function.
 289         (shell_escape): Call exit_status_set_internal_vars.
 290         cli/cli-decode.c (find_command_name_length): Recognize | as
 291         a single character command.
 292
 293 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 294
 295         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 296         top.c (execute_command_to_ui_file): New function, mostly a copy
 297         of execute_command_to_string.
 298         (execute_command_to_string): Implement by calling
 299         execute_command_to_ui_file.
 300
 301 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 302
 303         * top.h (saved_command_line): Remove declaration.
 304         * top.c (previous_saved_command_line, previous_repeat_arguments):
 305         New variables.
 306         (saved_command_line): Make static, define together with other
 307         'repeat variables'.
 308         (dont_repeat): Clear repeat_arguments.
 309         (repeat_previous, get_saved_command_line, save_command_line):
 310         New functions.
 311         (gdb_init): Initialize saved_command_line
 312         and previous_saved_command_line.
 313         * main.c (captured_main_1): Remove saved_command_line initialization.
 314         * event-top.c (handle_line_of_input): Update to use
 315         the new 'repeat' related functions instead of direct access to
 316         saved_command_line.
 317         * command.h (repeat_previous, get_saved_command_line,
 318         save_command_line): New declarations.
 319         (dont_repeat): Add comment.
 320
 321 2019-05-30  Tom Tromey  <tromey@adacore.com>
 322
 323         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 324         Fix comment.
 325         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 326
 327 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 328
 329         PR cli/24587
 330         * completer.c (complete): Initialize variable word.
 331
 332 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 333
 334         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 335         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 336         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 337         'body' is NULL to the outter 'if', protecting the '!is_define'
 338         situation as well.
 339
 340 2019-05-29  Tom Tromey  <tromey@adacore.com>
 341
 342         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 343         (dwarf_unknown): New function.
 344         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 345         (dwarf_type_encoding_name): Use dwarf_unknown.
 346
 347 2019-05-29  Tom Tromey  <tromey@adacore.com>
 348
 349         PR c++/20020:
 350         * cp-valprint.c (cp_print_value_fields): Call
 351         cp_print_static_field inside "try".
 352
 353 2019-05-29  Tom Tromey  <tromey@adacore.com>
 354
 355         * inflow.c (struct terminal_info): Add default operator=.
 356         * configure: Rebuild.
 357         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 358         -Wdeprecated-copy-dtor, -Wredundant-move.
 359
 360 2019-05-29  Tom Tromey  <tromey@adacore.com>
 361
 362         * NEWS: Add entry.
 363         * infcmd.c (print_return_value_1): Handle finish_print
 364         option.
 365         (show_print_finish): New function.
 366         (_initialize_infcmd): Add "set/show print finish" commands.
 367         * valprint.c (user_print_options): Initialize new member.
 368         * valprint.h (struct value_print_options) <finish_print>: New
 369         member.
 370
 371 2019-05-28  Tom Tromey  <tromey@adacore.com>
 372
 373         * ada-lang.c (ada_remove_Xbn_suffix)
 374         (find_old_style_renaming_symbol)
 375         (parse_old_style_renaming): Remove.
 376         (ada_find_renaming_symbol): Don't call
 377         find_old_style_renaming_symbol.
 378         (ada_is_renaming_symbol): Rename from
 379         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 380         bool.  Now static.
 381         (ada_read_var_value): Update and simplify.
 382         * ada-exp.y (write_var_or_type): Remove old code.
 383
 384 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 385
 386         * event-top.c: Remove include comment.
 387         * inflow.c (class scoped_ignore_sigttou): Move from here...
 388         * inflow.h (class scoped_ignore_sigttou): ...to here.
 389         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 390         * top.c:  Remove include comment.
 391
 392 2019-05-27  Tom Tromey  <tom@tromey.com>
 393
 394         * NEWS: Fix typo.
 395
 396 2019-05-22  Tom Tromey  <tromey@adacore.com>
 397
 398         * target.c (target_follow_exec): Constify parameter.
 399         * target-delegates.c: Rebuild.
 400         * remote.c (remote_target::follow_exec): Constify parameter.
 401         * infrun.c (follow_exec): Constify parameter.
 402         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 403         (target_follow_exec): Likewise.
 404
 405 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 406
 407         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 408         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 409
 410 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 411
 412         * NEWS: Add debugredirect and testsuite sections.
 413
 414 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 415
 416         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 417         target descriptions using exclusively floating point register name
 418         aliases.
 419
 420 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 421
 422         PR gdb/18644:
 423         * f-lang.c (build_fortran_types): Handle the case where
 424         gdbarch_floatformat_for_type returns a nullptr.
 425
 426 2019-05-21  Tom de Vries  <tdevries@suse.de>
 427
 428         PR cli/24587
 429         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 430
 431 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         PR gdb/18644:
 434         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 435         16-byte floats.
 436         * i386-tdep.c (i386_floatformat_for_type): Use
 437         floatformats_ia64_quad for the 16-byte floating point component
 438         within a fortran 32-byte complex number.
 439
 440 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 441
 442         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 443         delete default constructor.
 444         (find_partial_die): Update to return const struct.
 445         (partial_die_parent_scope): Move variable declaration into scope
 446         of its use and change its type to auto.
 447         (guess_partial_die_structure_name): Likewise.
 448         (partial_die_info::fixup): Likewise.
 449
 450 2019-05-17  Tom Tromey  <tromey@adacore.com>
 451
 452         * source.c (find_and_open_source): Remove cast.
 453
 454 2019-05-17  Tom Tromey  <tromey@adacore.com>
 455
 456         * annotate.c (annotate_source): Make "filename" const.
 457         * annotate.h (annotate_source): Use const.
 458
 459 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 460
 461         * disasm.c (set_disassembler_options): Send errors to stderr.
 462
 463 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 464
 465         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 466         (cli_interp_base::set_logging): Check debug_redirect.
 467         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 468         * cli/cli-logging.c (debug_redirect): Add static variable.
 469         (pop_output_files): Add default param.
 470         (handle_redirections): Print debug setting.
 471         (show_logging_command): Likewise.
 472         (_initialize_cli_logging): Add debugredirect command.
 473         * interps.c (current_interp_set_logging): Add debug_redirect
 474         parameter.
 475         * interps.h (set_logging): Add debug_redirect parameter.
 476         (current_interp_set_logging): Likewise.
 477         * mi/mi-common.h: Likewise.
 478         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 479
 480 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 481             Tom Tromey  <tromey@adacore.com>
 482
 483         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 484         directly.
 485         * cli/cli-interp.h (make_logging_output): Remove declaration.
 486         * cli/cli-logging.c (make_logging_output): Remove function.
 487         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 488         directly.
 489         * ui-file.c (tee_file::tee_file): Remove bools.
 490         (tee_file::~tee_file): Remove deletes.
 491         * ui-file.h (tee_file): Remove bools.
 492
 493 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 494
 495         * mi/mi-cmds.h (mi_cmd_complete): New function.
 496         * mi/mi-main.c (mi_cmd_complete): Likewise.
 497         * mi/mi-cmds.c: Define new MI command -complete.
 498         * NEWS: Mention new -complete command.
 499
 500 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 501
 502         * completer.h (complete): New function.
 503         * completer.c (complete): Likewise.
 504         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 505         function defined in completer.h.
 506
 507 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 508
 509        * MAINTAINERS (Write After Approval): Add myself.
 510
 511 2019-05-17  Tom de Vries  <tdevries@suse.de>
 512
 513         PR gdb/24094
 514         * dwarf2read.c (struct cu_partial_die_info): New struct.
 515         (find_partial_die): Return cu_partial_die_info.
 516         (partial_die_parent_scope, guess_partial_die_structure_name)
 517         (partial_die_info::fixup): Handle new return type of find_partial_die.
 518
 519 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 520
 521         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 522         "std::string", simplifying the algorithm.
 523
 524 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 525
 526         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 527         (stap_static_probe_ops::get_probes): Likewise.
 528
 529 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 530
 531         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 532         '-')" and "else if".
 533         (stap_parse_single_operand): Join checks for
 534         "gdbarch_stap_parse_special_token_p" and
 535         "gdbarch_stap_parse_special_token" in the same "if" statement.
 536         Invert check when verifying for operation on register
 537         displacement.
 538
 539 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 540
 541         * stap-probe.c (stap_get_opcode): Update comment.
 542         (stap_get_expected_argument_type): Likewise.
 543         (handle_stap_probe): Likewise.
 544
 545 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 546
 547         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 548         return type to 'bool'.  Adjust comment.  Use 'bool' when
 549         appropriate.
 550         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 551         * stap-probe.c (stap_parse_argument_1): Likewise.
 552         (stap_is_operator): Likewise.
 553         (stap_is_generic_prefix): Likewise.
 554         (stap_is_register_prefix): Likewise.
 555         (stap_is_register_indirection_prefix): Likewise.
 556         (stap_is_integer_prefix): Likewise.
 557         (stap_generic_check_suffix): Likewise.
 558         (stap_check_integer_suffix): Likewise.
 559         (stap_check_register_suffix): Likewise.
 560         (stap_check_register_indirection_suffix): Likewise.
 561         (stap_parse_register_operand): Likewise.
 562         (stap_parse_single_operand): Likewise.
 563         (stap_parse_argument_1): Likewise.
 564         (stap_probe::get_argument_count): Likewise.
 565         (stap_is_operator): Likewise.
 566
 567 2019-05-16  Tom Tromey  <tromey@adacore.com>
 568
 569         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 570         keyword to foreach.
 571
 572 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 573
 574         * linux-thread-db.c (try_thread_db_load_1): Change return type
 575         to bool.
 576         (try_thread_db_load): Likewise.
 577         (try_thread_db_load_from_pdir_1): Likewise.
 578         (try_thread_db_load_from_pdir): Likewise.
 579         (try_thread_db_load_from_sdir): Likewise.
 580         (try_thread_db_load_from_dir): Likewise.
 581         (thread_db_load_search): Likewise.
 582         (has_libpthread): Likewise.
 583         (thread_db_load): Likewise.
 584
 585 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 586
 587         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 588         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 589         NULL, and complain/return if that's the case.
 590
 591 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 592
 593         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 594         (advance, posn, abstract_read_memory): New functions.
 595         [struct mem_read_abstraction]: New struct.
 596         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 597
 598 2019-05-14  Tom Tromey  <tromey@adacore.com>
 599
 600         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 601         value is not lval_memory.
 602
 603 2019-05-14  Tom Tromey  <tromey@adacore.com>
 604
 605         * solib.c (info_sharedlibrary_command): Style the file name.
 606
 607 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 608
 609         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 610         (aarch64_vnv_type): Likewise.
 611         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 612         * common/tdesc.c: Likewise.
 613         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 614         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 615         * features/aarch64-fpu.xml: Add ieee half view.
 616         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 617         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 618         * gdbtypes.h (struct builtin_type): Likewise.
 619         (struct objfile_type): Likewise.
 620
 621 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 622
 623         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 624         typo.
 625         * location.h (string_to_event_location): Likewise.
 626
 627 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 628
 629         GDB 8.3 released.
 630
 631 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 632
 633         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 634         New variable declaration.
 635         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 636         New variable.
 637         (print_one_breakpoint): Use ui_out::test_flags and new global
 638         variable to compute use_fixed_output.
 639         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 640         Remove.
 641         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 642         (mi_multi_location_breakpoint_output_fixed): Remove.
 643         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 644         new variable.
 645         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 646         fix_multi_location_breakpoint_output flag if version >= 3.
 647         * ui-out.h (enum ui_out_flag)
 648         <fix_multi_location_breakpoint_output>: New enumerator.
 649
 650 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 651
 652         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 653
 654 2019-05-10  Tom Tromey  <tromey@adacore.com>
 655
 656         * ada-lang.c (catch_ada_completer): New function.
 657         (_initialize_ada_language): Use it.
 658
 659 2019-05-10  Tom Tromey  <tromey@adacore.com>
 660
 661         * thread.c (print_thread_info): Make "requested_threads" const.
 662         * gdbthread.h (print_thread_info): Make "requested_threads"
 663         const.
 664         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 665         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 666
 667 2019-05-08  Tom Tromey  <tom@tromey.com>
 668
 669         * gdbtypes.c (objfile_type_data): Change type.
 670         (objfile_type, _initialize_gdbtypes): Update.
 671
 672 2019-05-08  Tom Tromey  <tom@tromey.com>
 673
 674         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 675         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 676         (_initialize_dwarf2_frame): Update.
 677
 678 2019-05-08  Tom Tromey  <tom@tromey.com>
 679
 680         * objc-lang.c (objc_objfile_data): Change type.
 681         (find_methods): Update.
 682         (_initialize_objc_lang): Remove.
 683
 684 2019-05-08  Tom Tromey  <tom@tromey.com>
 685
 686         * stabsread.c (rs6000_builtin_type_data): Change type.
 687         (rs6000_builtin_type, _initialize_stabsread): Update.
 688
 689 2019-05-08  Tom Tromey  <tom@tromey.com>
 690
 691         * mips-tdep.c (mips_pdr_data): Remove.
 692         (_initialize_mips_tdep): Update.
 693
 694 2019-05-08  Tom Tromey  <tom@tromey.com>
 695
 696         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 697         (hppa_init_objfile_priv_data, read_unwind_info)
 698         (find_unwind_entry, _initialize_hppa_tdep): Update.
 699
 700 2019-05-08  Tom Tromey  <tom@tromey.com>
 701
 702         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 703         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 704         on obstack.
 705         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 706
 707 2019-05-08  Tom Tromey  <tom@tromey.com>
 708
 709         * mdebugread.c (basic_type_data): Change type.
 710         (basic_type, _initialize_mdebugread): Update.
 711
 712 2019-05-08  Tom Tromey  <tom@tromey.com>
 713
 714         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 715
 716 2019-05-08  Tom Tromey  <tom@tromey.com>
 717
 718         * nto-tdep.c (nto_inferior_data_reg): Change type.
 719         (nto_inferior_data): Update.
 720         (nto_inferior_data_cleanup, nto_new_inferior_data)
 721         (_initialize_nto_tdep): Remove.
 722         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 723
 724 2019-05-08  Tom Tromey  <tom@tromey.com>
 725
 726         * ada-lang.c (struct ada_inferior_data): Add initializers.
 727         (ada_inferior_data): Change type.
 728         (ada_inferior_data_cleanup): Remove.
 729         (get_ada_inferior_data, ada_inferior_exit)
 730         (struct ada_pspace_data): Add initializers, destructor.
 731         (ada_pspace_data_handle): Change type.
 732         (get_ada_pspace_data): Update.
 733         (ada_pspace_data_cleanup): Remove.
 734
 735 2019-05-08  Tom Tromey  <tom@tromey.com>
 736
 737         * coffread.c (struct coff_symfile_info): Add initializers.
 738         (coff_objfile_data_key): Move lower.  Change type.
 739         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 740         Update.
 741         (coff_free_info): Remove.
 742
 743 2019-05-08  Tom Tromey  <tom@tromey.com>
 744
 745         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 746         (fbsd_pspace_data_handle): Move lower.  Change type.
 747         (get_fbsd_pspace_data): Update.
 748         (fbsd_pspace_data_cleanup): Remove.
 749         (_initialize_fbsd_tdep): Update.
 750
 751 2019-05-08  Tom Tromey  <tom@tromey.com>
 752
 753         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 754         (get_ada_tasks_pspace_data): Update.
 755         (ada_tasks_pspace_data_cleanup): Remove.
 756         (_initialize_tasks): Update.
 757         (ada_tasks_inferior_data_handle): Change type.
 758         (get_ada_tasks_inferior_data): Update.
 759         (ada_tasks_inferior_data_cleanup): Remove.
 760         (struct ada_tasks_pspace_data): Add initializers.
 761
 762 2019-05-08  Tom Tromey  <tom@tromey.com>
 763
 764         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 765         * symfile-debug.c (debug_sym_get_probes): Change type.
 766         * stap-probe.c (handle_stap_probe):
 767         (stap_static_probe_ops::get_probes): Change type.
 768         * probe.h (class static_probe_ops) <get_probes>: Change type.
 769         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 770         (parse_probes_in_pspace): Update.
 771         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 772         Update.
 773         (any_static_probe_ops::get_probes): Change type.
 774         * elfread.c (elfread_data): New typedef.
 775         (probe_key): Change type.
 776         (elf_get_probes): Likewise.  Update.
 777         (probe_key_free): Remove.
 778         (_initialize_elfread): Update.
 779         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 780         Change type.
 781         (dtrace_process_dof_probe, dtrace_process_dof)
 782         (dtrace_static_probe_ops::get_probe): Change type.
 783
 784 2019-05-08  Tom Tromey  <tom@tromey.com>
 785
 786         * xcoffread.c (struct xcoff_symfile_info): Rename from
 787         coff_symfile_info.  Add initializers.
 788         (xcoff_objfile_data_key): Move lower.  Change type.
 789         (XCOFF_DATA): Rewrite.
 790         (xcoff_free_info): Remove.
 791         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 792         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 793         (xcoff_initial_scan): Update.
 794
 795 2019-05-08  Tom Tromey  <tom@tromey.com>
 796
 797         * solib-svr4.c (struct svr4_info): Add initializers and
 798         destructor.
 799         <probes_table>: Now an htab_up.
 800         (solib_svr4_pspace_data): Change type.
 801         (free_probes_table): Simplify.
 802         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 803         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 804         (probes_table_remove_objfile_probes, register_solib_event_probe)
 805         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 806         (_initialize_svr4_solib): Update.
 807
 808 2019-05-08  Tom Tromey  <tom@tromey.com>
 809
 810         * remote.c (remote_pspace_data): Change type.
 811         (remote_pspace_data_cleanup): Remove.
 812         (get_remote_exec_file, set_pspace_remote_exec_file)
 813         (_initialize_remote): Update.
 814
 815 2019-05-08  Tom Tromey  <tom@tromey.com>
 816
 817         * breakpoint.c (breakpoint_objfile_key): Change type.
 818         (get_breakpoint_objfile_data): Update.
 819         (free_breakpoint_objfile_data): Remove.
 820         (_initialize_breakpoint): Update.
 821
 822 2019-05-08  Tom Tromey  <tom@tromey.com>
 823
 824         * linux-tdep.c (struct linux_info): Add initializers.
 825         (linux_inferior_data): Move.  Change type.
 826         (invalidate_linux_cache_inf): Update.
 827         (linux_inferior_data_cleanup): Remove.
 828         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 829
 830 2019-05-08  Tom Tromey  <tom@tromey.com>
 831
 832         * auxv.c (auxv_inferior_data): Move.  Change type.
 833         (auxv_inferior_data_cleanup): Remove.
 834         (invalidate_auxv_cache_inf): Rewrite.
 835         (get_auxv_inferior_data, _initialize_auxv): Update.
 836
 837 2019-05-08  Tom Tromey  <tom@tromey.com>
 838
 839         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 840         (symfile_debug_objfile_data_key): Change type.
 841         (symfile_debug_installed, debug_qf_has_symbols)
 842         (debug_qf_find_last_source_symtab)
 843         (debug_qf_forget_cached_source_info)
 844         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 845         (debug_qf_print_stats, debug_qf_dump)
 846         (debug_qf_expand_symtabs_for_function)
 847         (debug_qf_expand_all_symtabs)
 848         (debug_qf_expand_symtabs_with_fullname)
 849         (debug_qf_map_matching_symbols)
 850         (debug_qf_expand_symtabs_matching)
 851         (debug_qf_find_pc_sect_compunit_symtab)
 852         (debug_qf_map_symbol_filenames)
 853         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 854         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 855         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 856         (debug_sym_read_linetable, debug_sym_relocate): Update.
 857         (symfile_debug_free_objfile): Remove.
 858         (install_symfile_debug_logging, _initialize_symfile_debug):
 859         Update.
 860
 861 2019-05-08  Tom Tromey  <tom@tromey.com>
 862
 863         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 864         allocate_on_obstack.
 865         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 866         (get_dwarf2_per_objfile): Update.
 867         (set_dwarf2_per_objfile): Remove.
 868         (dwarf2_has_info, dwarf2_get_section_info): Update.
 869         (dwarf2_free_objfile): Remove.
 870         (_initialize_dwarf2_read): Update.
 871
 872 2019-05-08  Tom Tromey  <tom@tromey.com>
 873
 874         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 875         initializers.
 876         <unsupported_script_warning_printed,
 877         script_not_found_warning_printed>: Now bool.
 878         (auto_load_pspace_data): Change type.
 879         (~auto_load_pspace_info): Rename from
 880         auto_load_pspace_data_cleanup.
 881         (get_auto_load_pspace_data, init_loaded_scripts_info)
 882         (clear_section_scripts, maybe_print_unsupported_script_warning)
 883         (maybe_print_script_not_found_warning, _initialize_auto_load):
 884         Update.
 885
 886 2019-05-08  Tom Tromey  <tom@tromey.com>
 887
 888         * objfiles.c (objfile_pspace_info): Add destructor and
 889         initializers.
 890         (objfiles_pspace_data): Change type.
 891         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 892         (get_objfile_pspace_data): Update.
 893         (objfiles_bfd_data): Change type.
 894         (get_objfile_bfd_data): Update.
 895         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 896
 897 2019-05-08  Tom Tromey  <tom@tromey.com>
 898
 899         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 900         Change type.
 901         (get_catch_syscall_inferior_data): Update.
 902         (catch_syscall_inferior_data_cleanup): Remove.
 903         (_initialize_break_catch_syscall): Update.
 904
 905 2019-05-08  Tom Tromey  <tom@tromey.com>
 906
 907         * inflow.c (struct terminal_info): Add destructor and
 908         initializers.
 909         (inflow_inferior_data): Change type.
 910         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 911         (get_inflow_inferior_data, inflow_inferior_exit)
 912         (swap_terminal_info, _initialize_inflow): Update.
 913
 914 2019-05-08  Tom Tromey  <tom@tromey.com>
 915
 916         * target-dcache.c (target_dcache_cleanup): Remove.
 917         (target_dcache_aspace_key): Change type.
 918         (target_dcache_init_p, target_dcache_invalidate)
 919         (target_dcache_get, target_dcache_get_or_init)
 920         (_initialize_target_dcache): Update.
 921         * dcache.h (struct dcache_deleter): New.
 922
 923 2019-05-08  Tom Tromey  <tom@tromey.com>
 924
 925         * symtab.c (struct symbol_cache): Add destructor and
 926         initializers.
 927         (symbol_cache_key): Move.  Change type.
 928         (make_symbol_cache, free_symbol_cache): Remove.
 929         (get_symbol_cache): Update.
 930         (symbol_cache_cleanup): Remove.
 931         (ALL_PSPACES, symbol_cache_flush)
 932         (maintenance_print_symbol_cache)
 933         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 934         Update.
 935
 936 2019-05-08  Tom Tromey  <tom@tromey.com>
 937
 938         * symtab.c (struct main_info): Add destructor and initializers.
 939         (main_progspace_key): Move.  Change type.
 940         (get_main_info): Update.
 941         (main_info_cleanup): Remove.
 942         (_initialize_symtab): Update.
 943
 944 2019-05-08  Tom Tromey  <tom@tromey.com>
 945
 946         * registry.h (DECLARE_REGISTRY): Define the _key class.
 947
 948 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 949
 950         * NEWS: Merge two 'New commands' sections.
 951
 952 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 953
 954         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 955         parameter and use Ada language definition instead.
 956         (ada_val_print_ptr): Remove unused language parameter.
 957         (ada_val_print_num): Remove language parameter and use Ada language
 958         definition instead.
 959         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 960         parameter.
 961         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 962         parameter and use Ada language definition instead.
 963         (ada_val_print_1): Update all ada_val_print_xxx calls.
 964         Remove language parameter.
 965         (ada_val_print): Update ada_val_print_1 call.
 966
 967 2019-05-08  Tom Tromey  <tromey@adacore.com>
 968
 969         * remote.c (remote_hw_watchpoint_limit)
 970         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 971         Now static.
 972
 973 2019-05-08  Tom Tromey  <tromey@adacore.com>
 974
 975         * maint.c (_initialize_maint_cmds): Move initialization code to
 976         remote.c.
 977         (watchdog, show_watchdog): Move to remote.c.
 978         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 979         "watchdog" static.
 980         (_initialize_remote): Move initialization code from maint.c.
 981         * defs.h (watchdog): Don't declare.
 982
 983 2019-05-08  Tom Tromey  <tromey@adacore.com>
 984
 985         * tui/tui-interp.c: Include main.h.
 986         * interps.c: Include main.h.
 987         * main.h (interpreter_p): Declare.
 988         * defs.h (interpreter_p): Don't declare.
 989
 990 2019-05-08  Tom Tromey  <tromey@adacore.com>
 991
 992         * dwarf2loc.c: Include dwarf2read.h.
 993         * defs.h (read_unsigned_leb128): Don't declare.
 994         * dwarf2read.h (read_unsigned_leb128): Declare.
 995
 996 2019-05-08  Tom Tromey  <tromey@adacore.com>
 997
 998         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 999         method.
1000
1001 2019-05-08  Tom Tromey  <tromey@adacore.com>
1002
1003         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1004         when no wrap column is set.
1005
1006 2019-05-08  Tom Tromey  <tromey@adacore.com>
1007
1008         * c-lang.c (c_get_string): Handle non-C-style arrays.
1009
1010 2019-05-08  Tom Tromey  <tromey@adacore.com>
1011
1012         * typeprint.c (print_offset_data::update): Print the bit offset,
1013         not the number of bits remaining.
1014
1015 2019-05-08  Tom Tromey  <tromey@adacore.com>
1016
1017         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1018         padding at end of comment.
1019
1020 2019-05-08  Tom Tromey  <tromey@adacore.com>
1021
1022         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1023         Compare main types.
1024
1025 2019-05-06  Tom Tromey  <tom@tromey.com>
1026
1027         * common/scoped_mmap.c: Include common-defs.h.
1028         * common/scoped_mmap.h: Don't include config.h.
1029
1030 2019-05-04  Tom Tromey  <tom@tromey.com>
1031
1032         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1033         (struct aarch64_call_info): Add initializers.
1034         <si>: Now a std::vector.
1035         (pass_on_stack, aarch64_push_dummy_call): Update.
1036
1037 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1038             Tom Tromey  <tom@tromey.com>
1039
1040         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1041         (ppc_threads): Now a std::vector.  Now static.
1042         (hwdebug_find_thread_points_by_tid)
1043         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1044         Update.
1045
1046 2019-05-04  Tom Tromey  <tom@tromey.com>
1047
1048         * arc-tdep.c (arc_tdesc_init): Return bool.
1049
1050 2019-05-04  Tom Tromey  <tom@tromey.com>
1051
1052         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1053         Use gdb_assert_not_reached.
1054
1055 2019-05-04  Tom Tromey  <tom@tromey.com>
1056
1057         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1058         "false".
1059
1060 2019-05-04  Tom Tromey  <tom@tromey.com>
1061
1062         * arc-tdep.c (arc_tdesc_init): Use bool.
1063
1064 2019-05-04  Tom Tromey  <tom@tromey.com>
1065
1066         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1067
1068 2019-05-04  Tom Tromey  <tom@tromey.com>
1069
1070         * cli/cli-cmds.c (valid_command_p): Return bool.
1071
1072 2019-05-04  Tom Tromey  <tom@tromey.com>
1073
1074         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1075         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1076
1077 2019-05-04  Raul Tambre  <raul@tambre.ee>
1078
1079         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1080         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1081         operator for comparison.
1082
1083 2019-05-04  Tom Tromey  <tom@tromey.com>
1084
1085         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1086         (lookup_partial_symbol, print_partial_symbols)
1087         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1088         (psymbol_compare): Update.
1089         (add_psymbol_to_bcache): Clear the entire psymbol.
1090         (maintenance_check_psymtabs): Update.
1091         * psympriv.h (struct partial_symbol): Don't derive from
1092         general_symbol_info.
1093         <obj_section, unrelocated_address, address,
1094         set_unrelocated_address>: Update.
1095         <ginfo>: New member.
1096         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1097         (debug_names::write_psymbols): Update.
1098
1099 2019-05-04  Tom de Vries  <tdevries@suse.de>
1100
1101         * contrib/cc-with-tweaks.sh: Support -n arg.
1102
1103 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1104
1105         * corelow.c (core_target::detach): Ensure frame cache and
1106         register caches are cleared.
1107         inferior.c (exit_inferior_1): Likewise.
1108
1109 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1110             Tom Tromey  <tom@tromey.com>
1111
1112         * dictionary.c (collate_pending_symbols_by_language): Remove
1113         "struct" from foreach.
1114         * symtab.c (lookup_global_symbol_from_objfile)
1115         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1116         foreach.
1117         * ser-tcp.c (net_open): Remove "struct" from foreach.
1118         * objfiles.c (objfile_relocate, objfile_rebase)
1119         (objfile_has_symbols): Remove "struct" from foreach.
1120         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1121         from foreach.
1122         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1123         foreach.
1124         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1125         "struct" from foreach.
1126         * ada-lang.c (create_excep_cond_exprs)
1127         (ada_exception_catchpoint_cond_string): Remove "struct" from
1128         foreach.
1129
1130 2019-05-03  Tom Tromey  <tromey@adacore.com>
1131
1132         * ada-exp.y (convert_char_literal): Check suffix of each
1133         enumerator.
1134
1135 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1136
1137         PR ada/21406:
1138         * ada-exp.y (yywrap): Don't define.
1139         * ada-lex.l (%option): Add noyywrap
1140         (yywrap): Remove.
1141
1142 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1143
1144         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1145         _WIN32_WINNT to the XP level, unless already defined to a higher
1146         level.
1147
1148         * unittests/parse-connection-spec-selftests.c:
1149         * ser-tcp.c:
1150         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1151         override.
1152
1153         * symfile.c (find_separate_debug_file): Remove colon from the
1154         drive spec of DOS/Windows file names of the target, so that the
1155         file name produced from DEBUGDIR and the target's directory will
1156         be valid on DOS/Windows systems.
1157
1158 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * rust-lang.c (val_print_struct): Handle printing structures
1161         containing strings.
1162
1163 2019-05-02  Tom Tromey  <tromey@adacore.com>
1164
1165         * valarith.c (_initialize_valarith): Remove.
1166
1167 2019-05-01  Tom Tromey  <tromey@adacore.com>
1168
1169         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1170         bitfields.
1171
1172 2019-05-01  Tom Tromey  <tromey@adacore.com>
1173
1174         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1175         for big-endian copies.
1176
1177 2019-04-30  Ali Tamur  <tamur@google.com>
1178         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1179         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1180         (read_3_bytes): New function.
1181
1182 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1183
1184         * windows-nat.c (main_thread_id): Delete.
1185         (handle_output_debug_string): Replace main_thread_id by
1186         current_event.dwThreadId.
1187         (fake_create_process): Likewise.
1188         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1189         Do not set main_thread_id.
1190         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1191         current_event.dwThreadId.
1192         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1193
1194 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1195
1196         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1197         Use current_event.dwThreadId instead of main_thread_id.
1198
1199 2019-04-30  Tom Tromey  <tromey@adacore.com>
1200
1201         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1202         (create_excep_cond_exprs): Iterate over program spaces.
1203         (ada_exception_catchpoint_cond_string): Examine all minimal
1204         symbols for exception types.
1205
1206 2019-04-30  Tom Tromey  <tromey@adacore.com>
1207
1208         PR c++/24470:
1209         * dwarf2read.c (process_structure_scope): Handle case where type
1210         has template parameters but no symbol was created.
1211
1212 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1213             Chris January  <chris.january@arm.com>
1214
1215         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1216         qualifier.
1217         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1218
1219 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         * f-typeprint.c (f_print_type): Update rules for printing
1222         whitespace.
1223         (f_type_print_varspec_suffix): Likewise.
1224
1225 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1226             Chris January  <chris.january@arm.com>
1227
1228         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1229         function arguments.
1230
1231 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * f-lang.c (build_fortran_types): Change name of void type to
1234         lower case.
1235         * f-typeprint.c (f_type_print_base): Print the name of the void
1236         type, rather than a fixed string.
1237         * f-valprint.c (f_decorations): Use lower case void string.
1238
1239 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1240             Chris January  <chris.january@arm.com>
1241
1242         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1243         types for Fortran.
1244
1245 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1246             Chris January  <chris.january@arm.com>
1247             David Lecomber  <david.lecomber@arm.com>
1248
1249         * f-exp.y (BINOP_INTRINSIC): New token.
1250         (exp): New parser rule handling BINOP_INTRINSIC.
1251         (f77_keywords): Add new builtin procedures.
1252         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1253         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1254         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1255         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1256         (print_unop_subexp_f): New function.
1257         (print_binop_subexp_f): New function.
1258         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1259         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1260         (dump_subexp_body_f): Likewise.
1261         (operator_check_f): Likewise.
1262         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1263         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1264
1265 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1266
1267         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1268         UNOP_KIND.
1269         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1270         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1271         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1272         (operator_length_f): New fuction.
1273         (print_subexp_f): New function.
1274         (op_name_f): New function.
1275         (dump_subexp_body_f): New function.
1276         (operator_check_f): New function.
1277         (exp_descriptor_f): Replace standard expression handling functions
1278         with new functions.
1279         * gdb/fortran-operator.def: New file.
1280         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1281         * gdb/std-operator.def: Remove UNOP_KIND.
1282
1283 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * std-operator.def: Remove unbalanced, stray double quote
1286         character.
1287
1288 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1289             Chris January  <chris.january@arm.com>
1290             Daniel Everett  <daniel.everett@arm.com>
1291             Nick Forrington  <nick.forrington@arm.com>
1292             Richard Bunt  <richard.bunt@arm.com>
1293
1294         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1295         of depth when printing anonymous structs or unions.
1296         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1297         Don't print either the top-level value, or the children if the
1298         max-depth is exceeded.
1299         (ppscm_print_children): When printing the key of a map, allow one
1300         extra level of depth.
1301         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1302         print either the top-level value, or the children if the max-depth
1303         is exceeded.
1304         (print_children): When printing the key of a map, allow one extra
1305         level of depth.
1306         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1307         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1308         (user_print_options): Initialise max_depth field.
1309         (val_print_scalar_or_string_type_p): New function.
1310         (val_print): Check to see if the max depth has been reached.
1311         (val_print_check_max_depth): Define new function.
1312         (show_print_max_depth): New function.
1313         (_initialize_valprint): Add 'print max-depth' option.
1314         * valprint.h (struct value_print_options) <max_depth>: New field.
1315         (val_print_check_max_depth): Declare new function.
1316         * NEWS: Document new feature.
1317
1318 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * ada-lang.c (ada_language_defn): Initialise new field.
1321         * c-lang.c (c_is_string_type_p): New function.
1322         (c_language_defn): Initialise new field.
1323         (cplus_language_defn): Initialise new field.
1324         (asm_language_defn): Initialise new field.
1325         (minimal_language_defn): Initialise new field.
1326         * c-lang.h (c_is_string_type_p): Declare new function.
1327         * d-lang.c (d_language_defn): Initialise new field.
1328         * f-lang.c (f_is_string_type_p): New function.
1329         (f_language_defn): Initialise new field.
1330         * go-lang.c (go_is_string_type_p): New function.
1331         (go_language_defn): Initialise new field.
1332         * language.c (default_is_string_type_p): New function.
1333         (unknown_language_defn): Initialise new field.
1334         (auto_language_defn): Initialise new field.
1335         * language.h (struct language_defn) <la_is_string_type_p>: New
1336         member variable.
1337         (default_is_string_type_p): Declare new function.
1338         * m2-lang.c (m2_language_defn): Initialise new field.
1339         * objc-lang.c (objc_language_defn): Initialise new field.
1340         * opencl-lang.c (opencl_language_defn): Initialise new field.
1341         * p-lang.c (pascal_is_string_type_p): New function.
1342         (pascal_language_defn): Initialise new field.
1343         * rust-lang.c (rust_is_string_type_p): New function.
1344         (rust_language_defn): Initialise new field.
1345
1346 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1347
1348         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1349         New field.
1350         * ada-lang.c (ada_language_defn): Initialise new field.
1351         * c-lang.c (c_language_defn): Likewise.
1352         (cplus_language_defn): Likewise.
1353         (asm_language_defn): Likewise.
1354         (minimal_language_defn): Likewise.
1355         * d-lang.c (d_language_defn): Likewise.
1356         * f-lang.c (f_language_defn): Likewise.
1357         * go-lang.c (go_language_defn): Likewise.
1358         * language.c (unknown_language_defn): Likewise.
1359         (auto_language_defn): Likewise.
1360         * m2-lang.c (m2_language_defn): Likewise.
1361         * objc-lang.c (objc_language_defn): Likewise.
1362         * opencl-lang.c (opencl_language_defn): Likewise.
1363         * p-lang.c (pascal_language_defn): Likewise.
1364         * rust-lang.c (rust_language_defn): Likewise.
1365
1366 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1367
1368         * ada-lang.c (ada_is_character_type): Change return type to bool.
1369         (ada_is_string_type): Likewise.
1370         * ada-lang.h (ada_is_character_type): Update declaration
1371         (ada_is_string_type): Likewise.
1372
1373 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1374
1375         Support style in 'frame|thread apply'
1376
1377         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1378         * record.c (record_start, record_stop): Update callers of
1379         execute_command_to_string with false.
1380         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1381         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1382         methods.
1383         (class string_file): New constructor with term_out parameter.
1384         Override methods term_out and can_emit_style_escape.  New member
1385         term_out.
1386         (class stdio_file): Override can_emit_style_escape.
1387         (class tee_file): Override term_out and can_emit_style_escape.
1388         * utils.h (can_emit_style_escape): Remove.
1389         * utils.c (can_emit_style_escape): Likewise.
1390         Update all callers of can_emit_style_escape (SOMESTREAM) to
1391         SOMESTREAM->can_emit_style_escape.
1392         * source-cache.c (source_cache::get_source_lines): Likewise.
1393         * stack.c (frame_apply_command_count): Call execute_command_to_string
1394         passing the term_out characteristic of the current gdb_stdout.
1395         * thread.c (thr_try_catch_cmd): Likewise.
1396         * top.c (execute_command_to_string): pass term_out parameter
1397         to construct the string_file for the command output.
1398         * ui-file.c (term_cli_styling): New function (most code moved
1399         from utils.c can_emit_style_escape).
1400         (string_file::string_file, string_file::can_emit_style_escape,
1401         stdio_file::can_emit_style_escape, tee_file::term_out,
1402         tee_file::can_emit_style_escape): New functions.
1403
1404 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1405
1406         * NEWS: Mention the new set|show may-call-functions.
1407         * infcall.c (may_call_functions_p): New variable.
1408         (show_may_call_functions_p): New function.
1409         (call_function_by_hand_dummy): Throws an error if not
1410         may-call-functions.
1411         (_initialize_infcall): Call add_setshow_boolean_cmd for
1412         may-call-functions.
1413
1414 2019-04-25  Keith Seitz  <keiths@redhat.com>
1415
1416         PR c++/24367
1417         * cp-support.c (inspect_type): Don't attempt substitutions
1418         of symbol with the same name.
1419
1420 2019-04-25  Tom Tromey  <tromey@adacore.com>
1421
1422         PR gdb/24475:
1423         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1424         static.
1425
1426 2019-04-25  Tom Tromey  <tromey@adacore.com>
1427
1428         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1429         rvalue reference.
1430         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1431         (gdb_xml_parser::parse): Use std::move.
1432         * python/python-internal.h (gdbpy_convert_exception): Take a const
1433         reference.
1434         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1435         std::move.
1436         * python/py-utils.c (gdbpy_convert_exception): Take a const
1437         reference.
1438         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1439         Use std::move.
1440         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1441         Use std::move.
1442         * mi/mi-main.c (mi_print_exception): Take a const reference.
1443         * main.c (handle_command_errors): Take a const reference.
1444         * linespec.c (parse_linespec): Use std::move.
1445         * infcall.c (run_inferior_call): Use std::move.
1446         (call_function_by_hand_dummy): Use std::move.
1447         * exec.c (try_open_exec_file): Use std::move.
1448         * exceptions.h (exception_print, exception_fprintf)
1449         (exception_print_same): Update.
1450         * exceptions.c (print_exception, exception_print)
1451         (exception_fprintf, exception_print_same): Change parameters to
1452         const reference.
1453         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1454         * common/new-op.c: Use std::move.
1455         * common/common-exceptions.h (struct gdb_exception): Add move
1456         constructor.
1457         (struct gdb_exception_error, struct gdb_exception_quit, struct
1458         gdb_quit_bad_alloc): Change constructor to move constructor.
1459         (throw_exception): Change parameter to rvalue reference.
1460         * common/common-exceptions.c (throw_exception): Take rvalue
1461         reference.
1462         * cli/cli-interp.c (safe_execute_command): Use std::move.
1463         * breakpoint.c (insert_bp_location, location_to_sals): Use
1464         std::move.
1465
1466 2019-04-25  Tom Tromey  <tromey@adacore.com>
1467
1468         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1469         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1470         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1471         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1472         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1473         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1474         guile/scm-value.c: Use unpack.
1475         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1476         gdbscm_gdb_exception.
1477         (gdbscm_throw_gdb_exception): Likewise.
1478         (struct gdbscm_gdb_exception): New.
1479         (unpack): New function.
1480         (gdbscm_wrap): Use unpack.
1481
1482 2019-04-25  Tom Tromey  <tromey@adacore.com>
1483
1484         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1485         (gdb_rl_callback_handler): Use std::move.
1486         * common/common-exceptions.h (struct gdb_exception): Add move
1487         assignment operator.
1488         (throw_exception_sjlj): Change "exception" to const reference.
1489         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1490         (throw_exception_sjlj): Change "exception" to const reference.
1491
1492 2019-04-25  Tom Tromey  <tromey@adacore.com>
1493
1494         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1495         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1496         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1497         Update.
1498         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1499         Update.
1500         * mi/mi-interp.c (mi_interp::exec): Update.
1501         * linespec.c (parse_linespec): Update.
1502         * infcall.c (run_inferior_call): Update.
1503         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1504         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1505         (gdbscm_lookup_global_symbol): Update.
1506         * guile/scm-param.c (gdbscm_parameter_value): Update.
1507         * guile/scm-frame.c (gdbscm_frame_read_register)
1508         (gdbscm_frame_read_var): Update.
1509         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1510         * exec.c (try_open_exec_file): Update.
1511         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1512         (gdb_rl_callback_handler): Update.
1513         * common/common-exceptions.h (exception_none): Don't declare.
1514         * common/common-exceptions.c (exception_none): Don't define.
1515         (struct catcher) <exception>: Update.
1516         * cli/cli-interp.c (safe_execute_command): Update.
1517         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1518
1519 2019-04-25  Ali Tamur  <tamur@google.com>
1520
1521         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1522         (read_attribute_value): Likewise.
1523         (dwarf2_read_addr_index): Update comment.
1524         (read_str_index): Add DW_FORM_strx.
1525         (dwarf2_string_attr): Likewise.
1526         (dwarf2_const_value_attr): Likewise.
1527         (dump_die_shallow): Likewise.
1528         (dwarf2_fetch_constant_bytes): Likewise.
1529         (skip_form_bytes): Likewise.
1530         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1531
1532 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1533
1534         PR corefiles/11608
1535         PR corefiles/18187
1536         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1537         OFFSET.  Verify if current mapping contains an ELF header.
1538         (linux_find_memory_regions_full): Adjust call to
1539         dump_mapping_p.
1540
1541 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1542             Kang Li <kanglictf@gmail.com>
1543
1544         PR gdb/21600
1545
1546         * dwarf2-frame.c (read_initial_length): Be consistent about using
1547         unsigned representation of length.
1548         (decode_frame_entry_1): Likewise.  Check for wraparound of
1549         end pointer as well as buffer overflow.
1550
1551 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1552
1553         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1554         "vq".
1555
1556 2019-04-24  Tom Tromey  <tromey@adacore.com>
1557
1558         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1559
1560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1561
1562         * s12z-tdep.c (s12z_unwind_pc): Delete.
1563         (s12z_unwind_sp): Delete.
1564         (s12z_gdbarch_init): Don't register deleted functions with
1565         gdbarch.
1566
1567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1568
1569         * rl78-tdep.c (rl78_unwind_sp): Delete.
1570         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1571
1572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1575         (xstormy16_unwind_pc): Delete.
1576         (xstormy16_dummy_id): Delete.
1577         (xstormy16_gdbarch_init): Don't register deleted functions with
1578         gdbarch.
1579
1580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * vax-tdep.c (vax_unwind_pc): Delete.
1583         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1584
1585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * v850-tdep.c (v850_unwind_sp): Delete.
1588         (v850_unwind_pc): Delete.
1589         (v850_dummy_id): Delete.
1590         (v850_gdbarch_init): Don't register deleted functions with
1591         gdbarch.
1592
1593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1596         (tilegx_unwind_pc): Delete.
1597         (tilegx_unwind_dummy_id): Delete.
1598         (tilegx_gdbarch_init): Don't register deleted functions with
1599         gdbarch.
1600
1601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1602
1603         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1604         (tic6x_dummy_id): Delete.
1605         (tic6x_gdbarch_init): Don't register deleted functions with
1606         gdbarch.
1607
1608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * sparc-tdep.c (sparc_unwind_pc): Delete.
1611         (sparc32_gdbarch_init): Don't register deleted function with
1612         gdbarch.
1613
1614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * sh-tdep.c (sh_unwind_sp): Delete.
1617         (sh_unwind_pc): Delete.
1618         (sh_dummy_id): Delete.
1619         (sh_gdbarch_init): Don't register deleted functions with
1620         gdbarch.
1621
1622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1623
1624         * score-tdep.c (score_unwind_sp): Delete.
1625         (score_unwind_pc): Delete.
1626         (score_dummy_id): Delete.
1627         (score_gdbarch_init): Don't register deleted functions with
1628         gdbarch.
1629
1630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1631
1632         * rx-tdep.c (rx_unwind_pc): Delete.
1633         (rx_unwind_sp): Delete.
1634         (rx_dummy_id): Delete.
1635         (rx_gdbarch_init): Don't register deleted functions with
1636         gdbarch.  Update comment.
1637
1638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1639
1640         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1641         (rs6000_dummy_id): Delete.
1642         (rs6000_gdbarch_init): Don't register deleted functions with
1643         gdbarch.
1644
1645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1646
1647         * or1k-tdep.c (or1k_dummy_id): Delete.
1648         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1649
1650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * nios2-tdep.c (nios2_dummy_id): Delete.
1653         (nios2_unwind_sp): Delete.
1654         (nios2_gdbarch_init): Don't register deleted functions with
1655         gdbarch.
1656
1657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * nds32-tdep.c (nds32_dummy_id): Delete.
1660         (nds32_unwind_pc): Delete.
1661         (nds32_unwind_sp): Delete.
1662         (nds32_gdbarch_init): Don't register deleted functions with
1663         gdbarch.
1664
1665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1666
1667         * msp430-tdep.c (msp430_unwind_pc): Delete.
1668         (msp430_unwind_sp): Delete.
1669         (msp430_dummy_id): Delete.
1670         (msp430_gdbarch_init): Don't register deleted functions with
1671         gdbarch.
1672
1673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1674
1675         * moxie-tdep.c (moxie_unwind_sp): Delete.
1676         (moxie_unwind_pc): Delete.
1677         (moxie_dummy_id): Delete.
1678         (moxie_gdbarch_init): Don't register deleted functions with
1679         gdbarch.
1680
1681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1684         (mn10300_unwind_pc): Delete.
1685         (mn10300_unwind_sp): Delete.
1686         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1687         mn10300_unwind_sp.
1688         (mn10300_frame_unwind_init): Don't register deleted functions with
1689         gdbarch.
1690
1691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1692
1693         * mep-tdep.c (mep_unwind_pc): Delete.
1694         (mep_unwind_sp): Delete.
1695         (mep_dummy_id): Delete.
1696         (mep_gdbarch_init): Don't register deleted functions with
1697         gdbarch.
1698
1699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1702         (m68hc11_unwind_sp): Delete.
1703         (m68hc11_gdbarch_init): Don't register deleted functions with
1704         gdbarch.
1705
1706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1707
1708         * m32r-tdep.c (m32r_unwind_sp): Delete.
1709         (m32r_unwind_pc): Delete.
1710         (m32r_dummy_id): Delete.
1711         (m32r_gdbarch_init): Don't register deleted functions with
1712         gdbarch.
1713
1714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1715
1716         * m32c-tdep.c (m32c_unwind_pc): Delete.
1717         (m32c_unwind_sp): Delete.
1718         (m32c_dummy_id): Delete.
1719         (m32c_gdbarch_init): Don't register deleted functions with
1720         gdbarch.
1721
1722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1723
1724         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1725         (lm32_unwind_pc): Delete.
1726         (lm32_dummy_id): Delete.
1727         (lm32_gdbarch_init): Don't register deleted functions with
1728         gdbarch.
1729
1730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1731
1732         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1733         (iq2000_unwind_pc): Delete.
1734         (iq2000_dummy_id): Delete.
1735         (iq2000_gdbarch_init): Don't register deleted functions with
1736         gdbarch.
1737
1738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1739
1740         * nds32-tdep.c (nds32_type_align): Delete.
1741         (nds32_push_dummy_call): Use type_align instead.
1742
1743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1744
1745         * arm-tdep.c (arm_type_align): Only handle vector override case.
1746         (arm_push_dummy_call): Use type_align.
1747         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1748
1749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1750
1751         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1752         case.
1753         (pass_on_stack): Use type_align.
1754         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1755         function.
1756
1757 2019-04-23  Tom Tromey  <tromey@adacore.com>
1758
1759         * dwarf2read.c (line_header::file_name_at): Remove unused
1760         overload.
1761
1762 2019-04-23  Tom de Vries  <tdevries@suse.de>
1763
1764         PR gdb/24438
1765         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1766         invocation.
1767
1768
1769 2019-03-27  Ali Tamur  <tamur@google.com>
1770
1771         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1772         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1773         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1774         (dwarf_expr_context::get_addr_index): Likewise
1775         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1776         (symbol_needs_eval_context::get_addr_index): Likewise
1777         (disassemble_dwarf_expression): Add DW_OP_addrx
1778         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1779         (read_cutu_die_from_dwo): Update comment
1780         (skip_one_die): Add DW_FORM_addrx
1781         (read_attribute_value): Likewise
1782         (var_decode_location): Add DW_OP_addrx
1783         (dwarf2_const_value_attr): Add DW_FORM_addrx
1784         (dump_die_shallow): Likewise
1785         (dwarf2_fetch_constant_bytes): Likewise
1786         (decode_locdesc): Add DW_OP_addrx
1787         (skip_form_bytes): Add DW_FORM_addrx
1788
1789 2019-04-22  Ali Tamur  <tamur@google.com>
1790
1791         * MAINTAINERS (Write After Approval): Add self.
1792
1793 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1794
1795         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1796         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1797         (open_symbol_file_object): Likewise.
1798         (svr4_default_sos): Add info parameter.
1799         (svr4_read_so_list): Likewise.
1800         (svr4_current_sos_direct): Adjust functions calls to pass down
1801         info.
1802         (svr4_current_sos_1): Add info parameter.
1803         (svr4_current_sos): Call get_svr4_info, pass info down to
1804         svr4_current_sos_1.
1805         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1806         get_svr4_info.
1807         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1808         get_svr4_info.
1809         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1810         to get_svr4_info.
1811         (probes_table_remove_objfile_probes): Likewise.
1812         (register_solib_event_probe): Add info parameter.
1813         (solist_update_incremental): Pass info parameter down to
1814         svr4_read_so_list.
1815         (disable_probes_interface): Add info parameter.
1816         (svr4_handle_solib_event): Pass current_program_space to
1817         get_svr4_info.  Adjust disable_probes_interface cleanup.
1818         (svr4_create_probe_breakpoints): Add info parameter, pass it
1819         down to register_solib_event_probe.
1820         (svr4_create_solib_event_breakpoints): Add info parameter,
1821         pass it down to svr4_create_probe_breakpoints.
1822         (enable_break): Pass info down to
1823         svr4_create_solib_event_breakpoints.
1824         (svr4_solib_create_inferior_hook): Pass current_program_space to
1825         get_svr4_info.
1826         (svr4_clear_solib): Likewise.
1827
1828 2019-04-22  Pedro Alves  <palves@redhat.com>
1829
1830         * solib-svr4.c (svr4_free_objfile_observer): New.
1831         (probe_and_action::objfile): New field.
1832         (probes_table_htab_remove_objfile_probes)
1833         (probes_table_remove_objfile_probes): New functions.
1834         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1835         in the new probe_and_action.  Don't store the probe in 'lookup'.
1836         (svr4_create_probe_breakpoints): Pass objfile to
1837         register_solib_event_probe.
1838         (_initialize_svr4_solib): Register a free_objfile observer.
1839
1840 2019-04-19  Tom Tromey  <tom@tromey.com>
1841
1842         * common/queue.h: Remove.
1843
1844 2019-04-19  Tom Tromey  <tom@tromey.com>
1845
1846         * event-loop.c: Don't include "common/queue.h".
1847
1848 2019-04-19  Tom Tromey  <tom@tromey.com>
1849
1850         * remote.c (remote_target): Use delete.
1851         * remote-notif.h: Include <list>, not "common/queue.h".
1852         (notif_client_p): Remove typedef.
1853         (remote_notif_state): Add constructor, destructor, initializer.
1854         <notif_queue>: Now a std::list.
1855         (remote_notif_state_xfree): Don't declare.
1856         * remote-notif.c (remote_notif_process, handle_notification)
1857         (remote_notif_state_allocate): Update.
1858         (~remote_notif_state): Rename from remote_notif_state_xfree.
1859
1860 2019-04-19  Tom Tromey  <tom@tromey.com>
1861
1862         * symfile.c (reread_symbols): Update.
1863         * objfiles.c (objfile_register_static_link)
1864         (objfile_lookup_static_link): Update
1865         (~objfile) Don't delete static_links.
1866         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1867
1868 2019-04-19  Tom Tromey  <tom@tromey.com>
1869
1870         * type-stack.h (struct type_stack) <insert>: Constify string.
1871         * type-stack.c (type_stack::insert): Constify string.
1872         * gdbtypes.h (lookup_template_type): Update.
1873         (address_space_name_to_int): Update.
1874         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1875         const.
1876         (lookup_template_type): Make name const.
1877         * c-exp.y: Update rules.
1878         (lex_one_token, classify_name, classify_inner_name)
1879         (c_print_token): Update.
1880         * p-exp.y: Update rules.
1881         (yylex): Update.
1882         * f-exp.y: Update rules.
1883         (yylex): Update.
1884         * d-exp.y: Update rules.
1885         (lex_one_token, classify_name, classify_inner_name): Update.
1886         * parse.c (write_dollar_variable, copy_name): Return std::string.
1887         * parser-defs.h (copy_name): Change return type.
1888         * m2-exp.y: Update rules.
1889         (yylex): Update.
1890         * go-exp.y (lex_one_token): Update.
1891         Update rules.
1892         (classify_unsafe_function, classify_packaged_name)
1893         (classify_name, yylex): Update.
1894
1895 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1896
1897         * configure.ac: add --enable-source-highlight switch.
1898         * configure: Regenerate.
1899         * top.c (print_gdb_version): plumb --enable-source-highlight
1900         status to "show configuration".
1901
1902 2019-04-19  Tom Tromey  <tromey@adacore.com>
1903
1904         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1905         Check ADA_TYPE_P.
1906         (empty_record, ada_template_to_fixed_record_type_1)
1907         (template_to_static_fixed_type)
1908         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1909         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1910         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1911         macros.
1912
1913 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1914
1915         PR symtab/24423:
1916         * source.c (print_source_lines_base): Advance "iter" when a
1917         control character is seen.
1918
1919 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1920
1921         * inferior.h (struct infcall_suspend_state_deleter):
1922         Catch exception in destructor to avoid crash.
1923
1924 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1925
1926         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1927         close to the add_com "shell".
1928
1929 2019-04-18  Tom Tromey  <tromey@adacore.com>
1930
1931         * process-stratum-target.h (class process_stratum_target)
1932         <stratum>: Add "final".
1933
1934 2019-04-17  Tom Tromey  <tromey@adacore.com>
1935
1936         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1937         against nullptr before use.
1938
1939 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1940
1941         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1942
1943 2019-04-17  Jim Wilson  <jimw@sifive.com>
1944             Andrew Burgess  <andrew.burgess@embecosm.com>
1945
1946         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1947         code read might fail, assume 4-byte breakpoint in that case.
1948
1949 2019-04-15  Leszek Swirski  <leszeks@google.com>
1950
1951         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1952         rather than a hand-rolled POD check when checking for forced MEMORY
1953         classification.
1954
1955 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1956
1957         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1958         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1959         function.
1960         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1961         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1962         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1963         declaration.
1964
1965 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1966
1967         * aarch64-linux-nat.c
1968         (aarch64_linux_nat_target::thread_architecture): Add override.
1969         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1970         each VQ.
1971
1972 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1973
1974         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1975
1976 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1977
1978         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1979         target types of size 96-bits, add some additional comments, and
1980         check that the builtin type we found was the correct size.
1981
1982 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1983
1984         * utils.c (prompt_for_continue): Don't restore the styling at the
1985         end, as applied_style has the wrong value.  This fixes styling in
1986         long lists of file names that are interrupted by the "Continue?"
1987         prompt.
1988
1989 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1990
1991         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1992         * c-lang.c (c_language_defn): Likewise.
1993         (cplus_language_defn): Likewise.
1994         (asm_language_defn): Likewise.
1995         (minimal_language_defn): Likewise.
1996         * d-lang.c (d_language_defn): Likewise.
1997         * f-lang.c (f_language_defn): Likewise.
1998         * go-lang.c (go_language_defn): Likewise.
1999         * language.c (unknown_language_defn): Likewise.
2000         (auto_language_defn): Likewise.
2001         * language.h (struct language_defn): Remove la_magic field.
2002         (LANG_MAGIC): Delete.
2003         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2004         * objc-lang.c (objc_language_defn): Likewise.
2005         * opencl-lang.c (opencl_language_defn): Likewise.
2006         * p-lang.c (pascal_language_defn): Likewise.
2007         * rust-lang.c (rust_language_defn): Likewise.
2008
2009 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * riscv-tdep.c (riscv_type_align): New function.
2012         (riscv_type_alignment): Delete.
2013         (riscv_arg_location): Use 'type_align'.
2014         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2015
2016 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2017
2018         * gdbtypes.c (type_align): A struct with no non-static fields also
2019         has alignment of 1.
2020
2021 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2022
2023         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2024         component to 0.
2025         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2026         member.
2027         (riscv_struct_info::analyse): New implementation using new
2028         analyse_inner member function.
2029         (riscv_struct_info::field_offset): New member function.
2030         (riscv_struct_info::m_offsets): New member variable.
2031         (riscv_struct_info::analyse_inner): New private member function,
2032         takes the old implementation of riscv_struct_info::analyse but
2033         extended to track field offsets.
2034         (riscv_call_arg_struct): Update the struct folding special cases
2035         to handle cases where empty C++ structs, which are non-zero
2036         length, are found.
2037         (riscv_arg_location): Initialise the length of each location, a
2038         non-zero length now indicates the location is in use.
2039         (riscv_push_dummy_call): Allow for the first location having a
2040         non-zero offset when setting up arguments.
2041         (riscv_return_value): Likewise, but for return values.
2042
2043 2019-04-11  Tom Tromey  <tromey@adacore.com>
2044
2045         * utils.c (internal_vproblem): Make "msg" const.
2046
2047 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2048
2049         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2050         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2051         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2052         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2053
2054 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2055
2056         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2057         function.
2058         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2059         of amd64_collect_native_gregset.
2060         (amd64_linux_nat_target::store_registers): Likewise.
2061
2062 2019-04-10  Tom Tromey  <tom@tromey.com>
2063
2064         * symtab.c (lookup_global_symbol_from_objfile)
2065         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2066         * objfiles.h (class separate_debug_iterator): New.
2067         (class separate_debug_range): New.
2068         (struct objfile) <separate_debug_objfiles>: New method.
2069         (objfile_separate_debug_iterate): Don't declare.
2070         * objfiles.c (separate_debug_iterator::operator++): Rename from
2071         objfile_separate_debug_iterate.
2072         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2073         iterator.
2074         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2075         iterator.
2076
2077 2019-04-10  Tom Tromey  <tom@tromey.com>
2078
2079         * symfile.c (reread_symbols): Remove old comment.
2080         * objfiles.c (free_all_objfiles): Fix a typo.
2081
2082 2019-04-10  Tom Tromey  <tom@tromey.com>
2083
2084         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2085         * minsyms.c (lookup_minimal_symbol): Use foreach.
2086         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2087         (lookup_minimal_symbol_solib_trampoline): Likewise.
2088         * symfile.c (reread_symbols): Use foreach.
2089
2090 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2091             Tom Tromey  <tromey@adacore.com>
2092
2093         PR rust/24414:
2094         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2095         (rust_lex_int_test): Change "value" to be LONGEST.
2096         (rust_lex_tests): Add test for long integer literal.
2097
2098 2019-04-09  Tom Tromey  <tromey@adacore.com>
2099
2100         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2101         to bool.
2102         (extended_remote_target::attach): Update.
2103         (remote_target::remote_notice_new_inferior): Update.
2104         (remote_target::add_current_inferior_and_thread): Update.
2105         * inferior.c (exit_inferior_1): Use "false".
2106         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2107
2108 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2109
2110         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2111         the "start" command.
2112
2113 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2114
2115         * python/py-inferior.c (infpy_thread_from_thread_handle):
2116         Adjust comments to reflect renaming of thread_from_thread_handle
2117         to thread_from_handle.  Adjust keywords.  Fix type error message.
2118         (inferior_object_methods): Add thread_from_handle.  Retain
2119         thread_from_thread_handle, but mark it as deprecated.
2120
2121 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2122
2123         * gdbthread.h (find_thread_by_handle): Revise declaration.
2124         * thread.c (find_thread_by_handle): Likewise.  Adjust
2125         implementation too.
2126         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2127         support for buffer objects as handles.
2128
2129 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2130
2131         * python/py-infthread.c (thpy_thread_handle): New function.
2132         (thread_object_methods): Register thpy_thread_handle.
2133
2134 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2135
2136         * gdbthread.h (thread_to_thread_handle): Declare.
2137         * thread.c (gdbtypes.h): Include.
2138         (thread_to_thread_handle): New function.
2139
2140         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2141         (target_thread_info_to_thread_handle): Declare.
2142         * target.c (target_thread_info_to_thread_handle): New function.
2143         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2144         * target-delegates.c: Regenerate.
2145
2146         * linux-thread-db.c (class thread_db_target): Add method
2147         thread_info_to_thread_handle.
2148         (thread_db_target::thread_info_to_thread_handle): Define.
2149         * remote.c (class remote_target): Add new method
2150         thread_info_to_thread_handle.
2151         (remote_target::thread_info_to_thread_handle): Define.
2152
2153 2019-04-08  Pedro Alves  <palves@redhat.com>
2154
2155         * common/common-exceptions.c (throw_exception): Don't create
2156         named object to throw; throw directly.
2157         (throw_it): Likewise.  Don't initialize gdb_exception::message
2158         here, with new; pass FMT and AP to the ctor instead.
2159         * common/common-exceptions.h: Include <string>.
2160         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2161         const char *, va_list)): New ctor.  Use std::make_shared.
2162         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2163         errors)): Delete.
2164         (gdb_exception_error::gdb_exception_error(enum errors, const char
2165         *, va_list)): New.
2166         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2167         Add assertion.
2168         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2169         errors)): Delete.
2170         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2171         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2172         Add assertion.
2173
2174 2019-04-08  Tom Tromey  <tom@tromey.com>
2175
2176         * valops.c (value_rtti_indirect_type): Replace throw_exception
2177         with throw.
2178         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2179         with throw.
2180         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2181         throw.
2182         * target.c (target_translate_tls_address): Replace throw_exception
2183         with throw.
2184         * stack.c (frame_apply_command_count): Replace throw_exception
2185         with throw.
2186         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2187         throw.
2188         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2189         with throw.
2190         * rs6000-tdep.c (rs6000_frame_cache)
2191         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2192         * remote.c: Replace throw_exception with throw.
2193         * record-full.c (record_full_message, record_full_wait_1)
2194         (record_full_restore): Replace throw_exception with throw.
2195         * record-btrace.c:
2196         (get_thread_current_frame_id, record_btrace_start_replaying)
2197         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2198         (cmd_record_btrace_start): Replace throw_exception with throw.
2199         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2200         throw.
2201         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2202         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2203         * linespec.c:
2204         (find_linespec_symbols): Replace throw_exception with throw.
2205         * infrun.c (displaced_step_prepare, resume): Replace
2206         throw_exception with throw.
2207         * infcmd.c (post_create_inferior): Replace throw_exception with
2208         throw.
2209         * inf-loop.c (inferior_event_handler): Replace throw_exception
2210         with throw.
2211         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2212         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2213         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2214         (get_prev_frame_always, get_frame_pc_if_available)
2215         (get_frame_address_in_block_if_available, get_frame_language):
2216         Replace throw_exception with throw.
2217         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2218         throw_exception with throw.
2219         * eval.c (fetch_subexp_value, evaluate_var_value)
2220         (evaluate_funcall, evaluate_subexp_standard): Replace
2221         throw_exception with throw.
2222         * dwarf2loc.c (call_site_find_chain)
2223         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2224         Replace throw_exception with throw.
2225         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2226         with throw.
2227         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2228         throw.
2229         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2230         * completer.c (complete_line_internal): Replace throw_exception
2231         with throw.
2232         * compile/compile-object-run.c (compile_object_run): Replace
2233         throw_exception with throw.
2234         * cli/cli-script.c (process_next_line): Replace throw_exception
2235         with throw.
2236         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2237         (btrace_enable, btrace_maint_update_pt_packets): Replace
2238         throw_exception with throw.
2239         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2240         throw_exception with throw.
2241         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2242         throw_exception with throw.
2243         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2244         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2245         * aarch64-tdep.c (aarch64_make_prologue_cache)
2246         (aarch64_make_stub_cache): Replace throw_exception with throw.
2247
2248 2019-04-08  Tom Tromey  <tom@tromey.com>
2249
2250         * common/common-exceptions.c (throw_exception): Rename from
2251         throw_exception_cxx.  Remove old copy.  Make argument const.
2252         (throw_it): Create and throw exception objects directly.
2253         * common/common-exceptions.h (throw_exception): Make argument
2254         const.
2255         (struct gdb_exception_error): Add constructor.
2256         (struct gdb_exception_quit): Add constructor.
2257
2258 2019-04-08  Tom Tromey  <tom@tromey.com>
2259
2260         * common/common-exceptions.h (exception_rethrow): Don't declare.
2261         (TRY_SJLJ): Update comment.
2262         (TRY, CATCH, END_CATCH): Remove.
2263         * common/common-exceptions.c (exception_rethrow): Remove.
2264
2265 2019-04-08  Tom Tromey  <tom@tromey.com>
2266
2267         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2268         Remove.
2269         (gdb_exception_error): Rename from
2270         gdb_exception_RETURN_MASK_ERROR.
2271         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2272         (gdb_quit_bad_alloc): Update.
2273         * aarch64-tdep.c: Update.
2274         * ada-lang.c: Update.
2275         * ada-typeprint.c: Update.
2276         * ada-valprint.c: Update.
2277         * amd64-tdep.c: Update.
2278         * arch-utils.c: Update.
2279         * break-catch-throw.c: Update.
2280         * breakpoint.c: Update.
2281         * btrace.c: Update.
2282         * c-varobj.c: Update.
2283         * cli/cli-cmds.c: Update.
2284         * cli/cli-interp.c: Update.
2285         * cli/cli-script.c: Update.
2286         * common/common-exceptions.c: Update.
2287         * common/new-op.c: Update.
2288         * common/selftest.c: Update.
2289         * compile/compile-c-symbols.c: Update.
2290         * compile/compile-cplus-symbols.c: Update.
2291         * compile/compile-object-load.c: Update.
2292         * compile/compile-object-run.c: Update.
2293         * completer.c: Update.
2294         * corelow.c: Update.
2295         * cp-abi.c: Update.
2296         * cp-support.c: Update.
2297         * cp-valprint.c: Update.
2298         * darwin-nat.c: Update.
2299         * disasm-selftests.c: Update.
2300         * dtrace-probe.c: Update.
2301         * dwarf-index-cache.c: Update.
2302         * dwarf-index-write.c: Update.
2303         * dwarf2-frame-tailcall.c: Update.
2304         * dwarf2-frame.c: Update.
2305         * dwarf2loc.c: Update.
2306         * dwarf2read.c: Update.
2307         * eval.c: Update.
2308         * event-loop.c: Update.
2309         * event-top.c: Update.
2310         * exec.c: Update.
2311         * f-valprint.c: Update.
2312         * fbsd-tdep.c: Update.
2313         * frame-unwind.c: Update.
2314         * frame.c: Update.
2315         * gdbtypes.c: Update.
2316         * gnu-v3-abi.c: Update.
2317         * guile/guile-internal.h: Update.
2318         * guile/scm-block.c: Update.
2319         * guile/scm-breakpoint.c: Update.
2320         * guile/scm-cmd.c: Update.
2321         * guile/scm-disasm.c: Update.
2322         * guile/scm-frame.c: Update.
2323         * guile/scm-lazy-string.c: Update.
2324         * guile/scm-math.c: Update.
2325         * guile/scm-param.c: Update.
2326         * guile/scm-ports.c: Update.
2327         * guile/scm-pretty-print.c: Update.
2328         * guile/scm-symbol.c: Update.
2329         * guile/scm-symtab.c: Update.
2330         * guile/scm-type.c: Update.
2331         * guile/scm-value.c: Update.
2332         * i386-linux-tdep.c: Update.
2333         * i386-tdep.c: Update.
2334         * inf-loop.c: Update.
2335         * infcall.c: Update.
2336         * infcmd.c: Update.
2337         * infrun.c: Update.
2338         * jit.c: Update.
2339         * language.c: Update.
2340         * linespec.c: Update.
2341         * linux-fork.c: Update.
2342         * linux-nat.c: Update.
2343         * linux-tdep.c: Update.
2344         * linux-thread-db.c: Update.
2345         * main.c: Update.
2346         * mi/mi-cmd-break.c: Update.
2347         * mi/mi-cmd-stack.c: Update.
2348         * mi/mi-interp.c: Update.
2349         * mi/mi-main.c: Update.
2350         * objc-lang.c: Update.
2351         * p-valprint.c: Update.
2352         * parse.c: Update.
2353         * ppc-linux-tdep.c: Update.
2354         * printcmd.c: Update.
2355         * python/py-arch.c: Update.
2356         * python/py-breakpoint.c: Update.
2357         * python/py-cmd.c: Update.
2358         * python/py-finishbreakpoint.c: Update.
2359         * python/py-frame.c: Update.
2360         * python/py-framefilter.c: Update.
2361         * python/py-gdb-readline.c: Update.
2362         * python/py-inferior.c: Update.
2363         * python/py-infthread.c: Update.
2364         * python/py-lazy-string.c: Update.
2365         * python/py-linetable.c: Update.
2366         * python/py-objfile.c: Update.
2367         * python/py-param.c: Update.
2368         * python/py-prettyprint.c: Update.
2369         * python/py-progspace.c: Update.
2370         * python/py-record-btrace.c: Update.
2371         * python/py-record.c: Update.
2372         * python/py-symbol.c: Update.
2373         * python/py-type.c: Update.
2374         * python/py-unwind.c: Update.
2375         * python/py-utils.c: Update.
2376         * python/py-value.c: Update.
2377         * python/python.c: Update.
2378         * record-btrace.c: Update.
2379         * record-full.c: Update.
2380         * remote-fileio.c: Update.
2381         * remote.c: Update.
2382         * riscv-tdep.c: Update.
2383         * rs6000-aix-tdep.c: Update.
2384         * rs6000-tdep.c: Update.
2385         * rust-exp.y: Update.
2386         * rust-lang.c: Update.
2387         * s390-tdep.c: Update.
2388         * selftest-arch.c: Update.
2389         * solib-dsbt.c: Update.
2390         * solib-frv.c: Update.
2391         * solib-spu.c: Update.
2392         * solib-svr4.c: Update.
2393         * solib.c: Update.
2394         * sparc64-linux-tdep.c: Update.
2395         * stack.c: Update.
2396         * symfile-mem.c: Update.
2397         * symmisc.c: Update.
2398         * target.c: Update.
2399         * thread.c: Update.
2400         * top.c: Update.
2401         * tracefile-tfile.c: Update.
2402         * tui/tui.c: Update.
2403         * typeprint.c: Update.
2404         * unittests/cli-utils-selftests.c: Update.
2405         * unittests/parse-connection-spec-selftests.c: Update.
2406         * valops.c: Update.
2407         * valprint.c: Update.
2408         * value.c: Update.
2409         * varobj.c: Update.
2410         * windows-nat.c: Update.
2411         * x86-linux-nat.c: Update.
2412         * xml-support.c: Update.
2413
2414 2019-04-08  Tom Tromey  <tom@tromey.com>
2415
2416         * xml-support.c: Use C++ exception handling.
2417         * x86-linux-nat.c: Use C++ exception handling.
2418         * windows-nat.c: Use C++ exception handling.
2419         * varobj.c: Use C++ exception handling.
2420         * value.c: Use C++ exception handling.
2421         * valprint.c: Use C++ exception handling.
2422         * valops.c: Use C++ exception handling.
2423         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2424         handling.
2425         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2426         * typeprint.c: Use C++ exception handling.
2427         * tui/tui.c: Use C++ exception handling.
2428         * tracefile-tfile.c: Use C++ exception handling.
2429         * top.c: Use C++ exception handling.
2430         * thread.c: Use C++ exception handling.
2431         * target.c: Use C++ exception handling.
2432         * symmisc.c: Use C++ exception handling.
2433         * symfile-mem.c: Use C++ exception handling.
2434         * stack.c: Use C++ exception handling.
2435         * sparc64-linux-tdep.c: Use C++ exception handling.
2436         * solib.c: Use C++ exception handling.
2437         * solib-svr4.c: Use C++ exception handling.
2438         * solib-spu.c: Use C++ exception handling.
2439         * solib-frv.c: Use C++ exception handling.
2440         * solib-dsbt.c: Use C++ exception handling.
2441         * selftest-arch.c: Use C++ exception handling.
2442         * s390-tdep.c: Use C++ exception handling.
2443         * rust-lang.c: Use C++ exception handling.
2444         * rust-exp.y: Use C++ exception handling.
2445         * rs6000-tdep.c: Use C++ exception handling.
2446         * rs6000-aix-tdep.c: Use C++ exception handling.
2447         * riscv-tdep.c: Use C++ exception handling.
2448         * remote.c: Use C++ exception handling.
2449         * remote-fileio.c: Use C++ exception handling.
2450         * record-full.c: Use C++ exception handling.
2451         * record-btrace.c: Use C++ exception handling.
2452         * python/python.c: Use C++ exception handling.
2453         * python/py-value.c: Use C++ exception handling.
2454         * python/py-utils.c: Use C++ exception handling.
2455         * python/py-unwind.c: Use C++ exception handling.
2456         * python/py-type.c: Use C++ exception handling.
2457         * python/py-symbol.c: Use C++ exception handling.
2458         * python/py-record.c: Use C++ exception handling.
2459         * python/py-record-btrace.c: Use C++ exception handling.
2460         * python/py-progspace.c: Use C++ exception handling.
2461         * python/py-prettyprint.c: Use C++ exception handling.
2462         * python/py-param.c: Use C++ exception handling.
2463         * python/py-objfile.c: Use C++ exception handling.
2464         * python/py-linetable.c: Use C++ exception handling.
2465         * python/py-lazy-string.c: Use C++ exception handling.
2466         * python/py-infthread.c: Use C++ exception handling.
2467         * python/py-inferior.c: Use C++ exception handling.
2468         * python/py-gdb-readline.c: Use C++ exception handling.
2469         * python/py-framefilter.c: Use C++ exception handling.
2470         * python/py-frame.c: Use C++ exception handling.
2471         * python/py-finishbreakpoint.c: Use C++ exception handling.
2472         * python/py-cmd.c: Use C++ exception handling.
2473         * python/py-breakpoint.c: Use C++ exception handling.
2474         * python/py-arch.c: Use C++ exception handling.
2475         * printcmd.c: Use C++ exception handling.
2476         * ppc-linux-tdep.c: Use C++ exception handling.
2477         * parse.c: Use C++ exception handling.
2478         * p-valprint.c: Use C++ exception handling.
2479         * objc-lang.c: Use C++ exception handling.
2480         * mi/mi-main.c: Use C++ exception handling.
2481         * mi/mi-interp.c: Use C++ exception handling.
2482         * mi/mi-cmd-stack.c: Use C++ exception handling.
2483         * mi/mi-cmd-break.c: Use C++ exception handling.
2484         * main.c: Use C++ exception handling.
2485         * linux-thread-db.c: Use C++ exception handling.
2486         * linux-tdep.c: Use C++ exception handling.
2487         * linux-nat.c: Use C++ exception handling.
2488         * linux-fork.c: Use C++ exception handling.
2489         * linespec.c: Use C++ exception handling.
2490         * language.c: Use C++ exception handling.
2491         * jit.c: Use C++ exception handling.
2492         * infrun.c: Use C++ exception handling.
2493         * infcmd.c: Use C++ exception handling.
2494         * infcall.c: Use C++ exception handling.
2495         * inf-loop.c: Use C++ exception handling.
2496         * i386-tdep.c: Use C++ exception handling.
2497         * i386-linux-tdep.c: Use C++ exception handling.
2498         * guile/scm-value.c: Use C++ exception handling.
2499         * guile/scm-type.c: Use C++ exception handling.
2500         * guile/scm-symtab.c: Use C++ exception handling.
2501         * guile/scm-symbol.c: Use C++ exception handling.
2502         * guile/scm-pretty-print.c: Use C++ exception handling.
2503         * guile/scm-ports.c: Use C++ exception handling.
2504         * guile/scm-param.c: Use C++ exception handling.
2505         * guile/scm-math.c: Use C++ exception handling.
2506         * guile/scm-lazy-string.c: Use C++ exception handling.
2507         * guile/scm-frame.c: Use C++ exception handling.
2508         * guile/scm-disasm.c: Use C++ exception handling.
2509         * guile/scm-cmd.c: Use C++ exception handling.
2510         * guile/scm-breakpoint.c: Use C++ exception handling.
2511         * guile/scm-block.c: Use C++ exception handling.
2512         * guile/guile-internal.h: Use C++ exception handling.
2513         * gnu-v3-abi.c: Use C++ exception handling.
2514         * gdbtypes.c: Use C++ exception handling.
2515         * frame.c: Use C++ exception handling.
2516         * frame-unwind.c: Use C++ exception handling.
2517         * fbsd-tdep.c: Use C++ exception handling.
2518         * f-valprint.c: Use C++ exception handling.
2519         * exec.c: Use C++ exception handling.
2520         * event-top.c: Use C++ exception handling.
2521         * event-loop.c: Use C++ exception handling.
2522         * eval.c: Use C++ exception handling.
2523         * dwarf2read.c: Use C++ exception handling.
2524         * dwarf2loc.c: Use C++ exception handling.
2525         * dwarf2-frame.c: Use C++ exception handling.
2526         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2527         * dwarf-index-write.c: Use C++ exception handling.
2528         * dwarf-index-cache.c: Use C++ exception handling.
2529         * dtrace-probe.c: Use C++ exception handling.
2530         * disasm-selftests.c: Use C++ exception handling.
2531         * darwin-nat.c: Use C++ exception handling.
2532         * cp-valprint.c: Use C++ exception handling.
2533         * cp-support.c: Use C++ exception handling.
2534         * cp-abi.c: Use C++ exception handling.
2535         * corelow.c: Use C++ exception handling.
2536         * completer.c: Use C++ exception handling.
2537         * compile/compile-object-run.c: Use C++ exception handling.
2538         * compile/compile-object-load.c: Use C++ exception handling.
2539         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2540         * compile/compile-c-symbols.c: Use C++ exception handling.
2541         * common/selftest.c: Use C++ exception handling.
2542         * common/new-op.c: Use C++ exception handling.
2543         * cli/cli-script.c: Use C++ exception handling.
2544         * cli/cli-interp.c: Use C++ exception handling.
2545         * cli/cli-cmds.c: Use C++ exception handling.
2546         * c-varobj.c: Use C++ exception handling.
2547         * btrace.c: Use C++ exception handling.
2548         * breakpoint.c: Use C++ exception handling.
2549         * break-catch-throw.c: Use C++ exception handling.
2550         * arch-utils.c: Use C++ exception handling.
2551         * amd64-tdep.c: Use C++ exception handling.
2552         * ada-valprint.c: Use C++ exception handling.
2553         * ada-typeprint.c: Use C++ exception handling.
2554         * ada-lang.c: Use C++ exception handling.
2555         * aarch64-tdep.c: Use C++ exception handling.
2556
2557 2019-04-08  Tom Tromey  <tom@tromey.com>
2558
2559         * xml-support.c (gdb_xml_parser::parse): Update.
2560         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2561         * value.c (show_convenience): Update.
2562         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2563         (test_parse_flags_qcs): Update.
2564         * thread.c (thr_try_catch_cmd): Update.
2565         * target.c (target_translate_tls_address): Update.
2566         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2567         (info_frame_command_core, frame_apply_command_count): Update.
2568         * rust-exp.y (rust_lex_exception_test): Update.
2569         * riscv-tdep.c (riscv_print_one_register_info): Update.
2570         * remote.c (remote_target::enable_btrace): Update.
2571         * record-btrace.c (record_btrace_enable_warn): Update.
2572         * python/py-utils.c (gdbpy_convert_exception): Update.
2573         * printcmd.c (do_one_display, print_variable_and_value): Update.
2574         * mi/mi-main.c (mi_print_exception): Update.
2575         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2576         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2577         * linux-nat.c (linux_nat_target::attach): Update.
2578         * linux-fork.c (class scoped_switch_fork_info): Update.
2579         * infrun.c (displaced_step_prepare): Update.
2580         * infcall.c (call_function_by_hand_dummy): Update.
2581         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2582         * gnu-v3-abi.c (print_one_vtable): Update.
2583         * frame.c (get_prev_frame_always): Update.
2584         * f-valprint.c (info_common_command_for_block): Update.
2585         * exec.c (try_open_exec_file): Update.
2586         * exceptions.c (print_exception, exception_print)
2587         (exception_fprintf, exception_print_same): Update.
2588         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2589         * dwarf-index-cache.c (index_cache::store)
2590         (index_cache::lookup_gdb_index): Update.
2591         * darwin-nat.c (maybe_cache_shell): Update.
2592         * cp-valprint.c (cp_print_value_fields): Update.
2593         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2594         (gcc_cplus_symbol_address): Update.
2595         * compile/compile-c-symbols.c (gcc_convert_symbol)
2596         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2597         * common/selftest.c: Update.
2598         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2599         a std::string.
2600         (exception_try_scope_entry, exception_try_scope_exit): Don't
2601         declare.
2602         (struct exception_try_scope): Remove.
2603         (TRY): Don't use exception_try_scope.
2604         (struct gdb_exception): Add constructor, operator=.
2605         <what>: New method.
2606         (struct gdb_exception_RETURN_MASK_ALL)
2607         (struct gdb_exception_RETURN_MASK_ERROR)
2608         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2609         (struct gdb_quit_bad_alloc): Update.
2610         * common/common-exceptions.c (exception_none): Change
2611         initializer.
2612         (struct catcher) <state, exception>: Initialize inline.
2613         <prev>: Remove member.
2614         (current_catcher): Remove.
2615         (catchers): New global.
2616         (exceptions_state_mc_init): Simplify.
2617         (catcher_pop): Remove.
2618         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2619         (try_scope_depth, exception_try_scope_entry)
2620         (exception_try_scope_exit): Remove.
2621         (throw_exception_sjlj): Update.
2622         (exception_messages, exception_messages_size): Remove.
2623         (throw_it): Simplify.
2624         (gdb_exception_sliced_copy): Remove.
2625         (throw_exception_cxx): Update.
2626         * cli/cli-script.c (script_from_file): Update.
2627         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2628         Update.
2629         * ada-valprint.c (ada_val_print): Update.
2630         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2631         (create_excep_cond_exprs): Update.
2632
2633 2019-04-08  Tom Tromey  <tom@tromey.com>
2634
2635         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2636         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2637         (TRY, CATCH, END_CATCH): Remove some definitions.
2638         * common/common-exceptions.c: Don't use GDB_XCPT.
2639         (catcher_list_size): Remove.
2640         (throw_exception, throw_it): Simplify.
2641
2642 2019-04-05  Tom Tromey  <tom@tromey.com>
2643
2644         Revert the header-sorting patch.
2645         * ft32-tdep.c: Revert.
2646         * frv-tdep.c: Revert.
2647         * frv-linux-tdep.c: Revert.
2648         * frame.c: Revert.
2649         * frame-unwind.c: Revert.
2650         * frame-base.c: Revert.
2651         * fork-child.c: Revert.
2652         * findvar.c: Revert.
2653         * findcmd.c: Revert.
2654         * filesystem.c: Revert.
2655         * filename-seen-cache.h: Revert.
2656         * filename-seen-cache.c: Revert.
2657         * fbsd-tdep.c: Revert.
2658         * fbsd-nat.h: Revert.
2659         * fbsd-nat.c: Revert.
2660         * f-valprint.c: Revert.
2661         * f-typeprint.c: Revert.
2662         * f-lang.c: Revert.
2663         * extension.h: Revert.
2664         * extension.c: Revert.
2665         * extension-priv.h: Revert.
2666         * expprint.c: Revert.
2667         * exec.h: Revert.
2668         * exec.c: Revert.
2669         * exceptions.c: Revert.
2670         * event-top.c: Revert.
2671         * event-loop.c: Revert.
2672         * eval.c: Revert.
2673         * elfread.c: Revert.
2674         * dwarf2read.h: Revert.
2675         * dwarf2read.c: Revert.
2676         * dwarf2loc.c: Revert.
2677         * dwarf2expr.h: Revert.
2678         * dwarf2expr.c: Revert.
2679         * dwarf2-frame.c: Revert.
2680         * dwarf2-frame-tailcall.c: Revert.
2681         * dwarf-index-write.h: Revert.
2682         * dwarf-index-write.c: Revert.
2683         * dwarf-index-common.c: Revert.
2684         * dwarf-index-cache.h: Revert.
2685         * dwarf-index-cache.c: Revert.
2686         * dummy-frame.c: Revert.
2687         * dtrace-probe.c: Revert.
2688         * disasm.h: Revert.
2689         * disasm.c: Revert.
2690         * disasm-selftests.c: Revert.
2691         * dictionary.c: Revert.
2692         * dicos-tdep.c: Revert.
2693         * demangle.c: Revert.
2694         * dcache.h: Revert.
2695         * dcache.c: Revert.
2696         * darwin-nat.h: Revert.
2697         * darwin-nat.c: Revert.
2698         * darwin-nat-info.c: Revert.
2699         * d-valprint.c: Revert.
2700         * d-namespace.c: Revert.
2701         * d-lang.c: Revert.
2702         * ctf.c: Revert.
2703         * csky-tdep.c: Revert.
2704         * csky-linux-tdep.c: Revert.
2705         * cris-tdep.c: Revert.
2706         * cris-linux-tdep.c: Revert.
2707         * cp-valprint.c: Revert.
2708         * cp-support.c: Revert.
2709         * cp-namespace.c: Revert.
2710         * cp-abi.c: Revert.
2711         * corelow.c: Revert.
2712         * corefile.c: Revert.
2713         * continuations.c: Revert.
2714         * completer.h: Revert.
2715         * completer.c: Revert.
2716         * complaints.c: Revert.
2717         * coffread.c: Revert.
2718         * coff-pe-read.c: Revert.
2719         * cli-out.h: Revert.
2720         * cli-out.c: Revert.
2721         * charset.c: Revert.
2722         * c-varobj.c: Revert.
2723         * c-valprint.c: Revert.
2724         * c-typeprint.c: Revert.
2725         * c-lang.c: Revert.
2726         * buildsym.c: Revert.
2727         * buildsym-legacy.c: Revert.
2728         * build-id.h: Revert.
2729         * build-id.c: Revert.
2730         * btrace.c: Revert.
2731         * bsd-uthread.c: Revert.
2732         * breakpoint.h: Revert.
2733         * breakpoint.c: Revert.
2734         * break-catch-throw.c: Revert.
2735         * break-catch-syscall.c: Revert.
2736         * break-catch-sig.c: Revert.
2737         * blockframe.c: Revert.
2738         * block.c: Revert.
2739         * bfin-tdep.c: Revert.
2740         * bfin-linux-tdep.c: Revert.
2741         * bfd-target.c: Revert.
2742         * bcache.c: Revert.
2743         * ax-general.c: Revert.
2744         * ax-gdb.h: Revert.
2745         * ax-gdb.c: Revert.
2746         * avr-tdep.c: Revert.
2747         * auxv.c: Revert.
2748         * auto-load.c: Revert.
2749         * arm-wince-tdep.c: Revert.
2750         * arm-tdep.c: Revert.
2751         * arm-symbian-tdep.c: Revert.
2752         * arm-pikeos-tdep.c: Revert.
2753         * arm-obsd-tdep.c: Revert.
2754         * arm-nbsd-tdep.c: Revert.
2755         * arm-nbsd-nat.c: Revert.
2756         * arm-linux-tdep.c: Revert.
2757         * arm-linux-nat.c: Revert.
2758         * arm-fbsd-tdep.c: Revert.
2759         * arm-fbsd-nat.c: Revert.
2760         * arm-bsd-tdep.c: Revert.
2761         * arch-utils.c: Revert.
2762         * arc-tdep.c: Revert.
2763         * arc-newlib-tdep.c: Revert.
2764         * annotate.h: Revert.
2765         * annotate.c: Revert.
2766         * amd64-windows-tdep.c: Revert.
2767         * amd64-windows-nat.c: Revert.
2768         * amd64-tdep.c: Revert.
2769         * amd64-sol2-tdep.c: Revert.
2770         * amd64-obsd-tdep.c: Revert.
2771         * amd64-obsd-nat.c: Revert.
2772         * amd64-nbsd-tdep.c: Revert.
2773         * amd64-nbsd-nat.c: Revert.
2774         * amd64-nat.c: Revert.
2775         * amd64-linux-tdep.c: Revert.
2776         * amd64-linux-nat.c: Revert.
2777         * amd64-fbsd-tdep.c: Revert.
2778         * amd64-fbsd-nat.c: Revert.
2779         * amd64-dicos-tdep.c: Revert.
2780         * amd64-darwin-tdep.c: Revert.
2781         * amd64-bsd-nat.c: Revert.
2782         * alpha-tdep.c: Revert.
2783         * alpha-obsd-tdep.c: Revert.
2784         * alpha-nbsd-tdep.c: Revert.
2785         * alpha-mdebug-tdep.c: Revert.
2786         * alpha-linux-tdep.c: Revert.
2787         * alpha-linux-nat.c: Revert.
2788         * alpha-bsd-tdep.c: Revert.
2789         * alpha-bsd-nat.c: Revert.
2790         * aix-thread.c: Revert.
2791         * agent.c: Revert.
2792         * addrmap.c: Revert.
2793         * ada-varobj.c: Revert.
2794         * ada-valprint.c: Revert.
2795         * ada-typeprint.c: Revert.
2796         * ada-tasks.c: Revert.
2797         * ada-lang.c: Revert.
2798         * aarch64-tdep.c: Revert.
2799         * aarch64-ravenscar-thread.c: Revert.
2800         * aarch64-newlib-tdep.c: Revert.
2801         * aarch64-linux-tdep.c: Revert.
2802         * aarch64-linux-nat.c: Revert.
2803         * aarch64-fbsd-tdep.c: Revert.
2804         * aarch64-fbsd-nat.c: Revert.
2805         * aarch32-linux-nat.c: Revert.
2806
2807 2019-04-05  Tom Tromey  <tom@tromey.com>
2808
2809         * ft32-tdep.c: Sort headers.
2810         * frv-tdep.c: Sort headers.
2811         * frv-linux-tdep.c: Sort headers.
2812         * frame.c: Sort headers.
2813         * frame-unwind.c: Sort headers.
2814         * frame-base.c: Sort headers.
2815         * fork-child.c: Sort headers.
2816         * findvar.c: Sort headers.
2817         * findcmd.c: Sort headers.
2818         * filesystem.c: Sort headers.
2819         * filename-seen-cache.h: Sort headers.
2820         * filename-seen-cache.c: Sort headers.
2821         * fbsd-tdep.c: Sort headers.
2822         * fbsd-nat.h: Sort headers.
2823         * fbsd-nat.c: Sort headers.
2824         * f-valprint.c: Sort headers.
2825         * f-typeprint.c: Sort headers.
2826         * f-lang.c: Sort headers.
2827         * extension.h: Sort headers.
2828         * extension.c: Sort headers.
2829         * extension-priv.h: Sort headers.
2830         * expprint.c: Sort headers.
2831         * exec.h: Sort headers.
2832         * exec.c: Sort headers.
2833         * exceptions.c: Sort headers.
2834         * event-top.c: Sort headers.
2835         * event-loop.c: Sort headers.
2836         * eval.c: Sort headers.
2837         * elfread.c: Sort headers.
2838         * dwarf2read.h: Sort headers.
2839         * dwarf2read.c: Sort headers.
2840         * dwarf2loc.c: Sort headers.
2841         * dwarf2expr.h: Sort headers.
2842         * dwarf2expr.c: Sort headers.
2843         * dwarf2-frame.c: Sort headers.
2844         * dwarf2-frame-tailcall.c: Sort headers.
2845         * dwarf-index-write.h: Sort headers.
2846         * dwarf-index-write.c: Sort headers.
2847         * dwarf-index-common.c: Sort headers.
2848         * dwarf-index-cache.h: Sort headers.
2849         * dwarf-index-cache.c: Sort headers.
2850         * dummy-frame.c: Sort headers.
2851         * dtrace-probe.c: Sort headers.
2852         * disasm.h: Sort headers.
2853         * disasm.c: Sort headers.
2854         * disasm-selftests.c: Sort headers.
2855         * dictionary.c: Sort headers.
2856         * dicos-tdep.c: Sort headers.
2857         * demangle.c: Sort headers.
2858         * dcache.h: Sort headers.
2859         * dcache.c: Sort headers.
2860         * darwin-nat.h: Sort headers.
2861         * darwin-nat.c: Sort headers.
2862         * darwin-nat-info.c: Sort headers.
2863         * d-valprint.c: Sort headers.
2864         * d-namespace.c: Sort headers.
2865         * d-lang.c: Sort headers.
2866         * ctf.c: Sort headers.
2867         * csky-tdep.c: Sort headers.
2868         * csky-linux-tdep.c: Sort headers.
2869         * cris-tdep.c: Sort headers.
2870         * cris-linux-tdep.c: Sort headers.
2871         * cp-valprint.c: Sort headers.
2872         * cp-support.c: Sort headers.
2873         * cp-namespace.c: Sort headers.
2874         * cp-abi.c: Sort headers.
2875         * corelow.c: Sort headers.
2876         * corefile.c: Sort headers.
2877         * continuations.c: Sort headers.
2878         * completer.h: Sort headers.
2879         * completer.c: Sort headers.
2880         * complaints.c: Sort headers.
2881         * coffread.c: Sort headers.
2882         * coff-pe-read.c: Sort headers.
2883         * cli-out.h: Sort headers.
2884         * cli-out.c: Sort headers.
2885         * charset.c: Sort headers.
2886         * c-varobj.c: Sort headers.
2887         * c-valprint.c: Sort headers.
2888         * c-typeprint.c: Sort headers.
2889         * c-lang.c: Sort headers.
2890         * buildsym.c: Sort headers.
2891         * buildsym-legacy.c: Sort headers.
2892         * build-id.h: Sort headers.
2893         * build-id.c: Sort headers.
2894         * btrace.c: Sort headers.
2895         * bsd-uthread.c: Sort headers.
2896         * breakpoint.h: Sort headers.
2897         * breakpoint.c: Sort headers.
2898         * break-catch-throw.c: Sort headers.
2899         * break-catch-syscall.c: Sort headers.
2900         * break-catch-sig.c: Sort headers.
2901         * blockframe.c: Sort headers.
2902         * block.c: Sort headers.
2903         * bfin-tdep.c: Sort headers.
2904         * bfin-linux-tdep.c: Sort headers.
2905         * bfd-target.c: Sort headers.
2906         * bcache.c: Sort headers.
2907         * ax-general.c: Sort headers.
2908         * ax-gdb.h: Sort headers.
2909         * ax-gdb.c: Sort headers.
2910         * avr-tdep.c: Sort headers.
2911         * auxv.c: Sort headers.
2912         * auto-load.c: Sort headers.
2913         * arm-wince-tdep.c: Sort headers.
2914         * arm-tdep.c: Sort headers.
2915         * arm-symbian-tdep.c: Sort headers.
2916         * arm-pikeos-tdep.c: Sort headers.
2917         * arm-obsd-tdep.c: Sort headers.
2918         * arm-nbsd-tdep.c: Sort headers.
2919         * arm-nbsd-nat.c: Sort headers.
2920         * arm-linux-tdep.c: Sort headers.
2921         * arm-linux-nat.c: Sort headers.
2922         * arm-fbsd-tdep.c: Sort headers.
2923         * arm-fbsd-nat.c: Sort headers.
2924         * arm-bsd-tdep.c: Sort headers.
2925         * arch-utils.c: Sort headers.
2926         * arc-tdep.c: Sort headers.
2927         * arc-newlib-tdep.c: Sort headers.
2928         * annotate.h: Sort headers.
2929         * annotate.c: Sort headers.
2930         * amd64-windows-tdep.c: Sort headers.
2931         * amd64-windows-nat.c: Sort headers.
2932         * amd64-tdep.c: Sort headers.
2933         * amd64-sol2-tdep.c: Sort headers.
2934         * amd64-obsd-tdep.c: Sort headers.
2935         * amd64-obsd-nat.c: Sort headers.
2936         * amd64-nbsd-tdep.c: Sort headers.
2937         * amd64-nbsd-nat.c: Sort headers.
2938         * amd64-nat.c: Sort headers.
2939         * amd64-linux-tdep.c: Sort headers.
2940         * amd64-linux-nat.c: Sort headers.
2941         * amd64-fbsd-tdep.c: Sort headers.
2942         * amd64-fbsd-nat.c: Sort headers.
2943         * amd64-dicos-tdep.c: Sort headers.
2944         * amd64-darwin-tdep.c: Sort headers.
2945         * amd64-bsd-nat.c: Sort headers.
2946         * alpha-tdep.c: Sort headers.
2947         * alpha-obsd-tdep.c: Sort headers.
2948         * alpha-nbsd-tdep.c: Sort headers.
2949         * alpha-mdebug-tdep.c: Sort headers.
2950         * alpha-linux-tdep.c: Sort headers.
2951         * alpha-linux-nat.c: Sort headers.
2952         * alpha-bsd-tdep.c: Sort headers.
2953         * alpha-bsd-nat.c: Sort headers.
2954         * aix-thread.c: Sort headers.
2955         * agent.c: Sort headers.
2956         * addrmap.c: Sort headers.
2957         * ada-varobj.c: Sort headers.
2958         * ada-valprint.c: Sort headers.
2959         * ada-typeprint.c: Sort headers.
2960         * ada-tasks.c: Sort headers.
2961         * ada-lang.c: Sort headers.
2962         * aarch64-tdep.c: Sort headers.
2963         * aarch64-ravenscar-thread.c: Sort headers.
2964         * aarch64-newlib-tdep.c: Sort headers.
2965         * aarch64-linux-tdep.c: Sort headers.
2966         * aarch64-linux-nat.c: Sort headers.
2967         * aarch64-fbsd-tdep.c: Sort headers.
2968         * aarch64-fbsd-nat.c: Sort headers.
2969         * aarch32-linux-nat.c: Sort headers.
2970
2971 2019-04-04  Tom Tromey  <tom@tromey.com>
2972
2973         * varobj.c (varobj_create): Update.
2974         * rust-exp.y (struct rust_parser) <update_innermost_block,
2975         lookup_symbol>: New methods.
2976         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2977         Rename.
2978         (rust_parser::rust_lookup_type)
2979         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2980         * printcmd.c (display_command, do_one_display): Update.
2981         * parser-defs.h (struct parser_state) <parser_state>: Add
2982         "tracker" parameter.
2983         (block_tracker): New member.
2984         (class innermost_block_tracker) <innermost_block_tracker>: Add
2985         "types" parameter.
2986         <reset>: Remove method.
2987         (innermost_block): Don't declare.
2988         (null_post_parser): Update.
2989         * parse.c (innermost_block): Remove global.
2990         (write_dollar_variable): Update.
2991         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2992         Remove "tracker_types" parameter.
2993         (parse_expression): Add "tracker" parameter.
2994         (parse_expression_for_completion): Update.
2995         (null_post_parser): Add "tracker" parameter.
2996         * p-exp.y: Update rules.
2997         * m2-exp.y: Update rules.
2998         * language.h (struct language_defn) <la_post_parser>: Add
2999         "tracker" parameter.
3000         * go-exp.y: Update rules.
3001         * f-exp.y: Update rules.
3002         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3003         parameter.
3004         * d-exp.y: Update rules.
3005         * c-exp.y: Update rules.
3006         * breakpoint.c (set_breakpoint_condition): Create an
3007         innermost_block_tracker.
3008         (watch_command_1): Likewise.
3009         * ada-lang.c (resolve): Add "tracker" parameter.
3010         (resolve_subexp): Likewise.
3011         * ada-exp.y (write_var_from_sym): Update.
3012
3013 2019-04-04  Tom Tromey  <tom@tromey.com>
3014
3015         * type-stack.h: New file.
3016         * type-stack.c: New file.
3017         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3018         type-stack.h.
3019         (insert_into_type_stack, insert_type, push_type, push_type_int)
3020         (insert_type_address_space, pop_type, pop_type_int)
3021         (pop_typelist, pop_type_stack, append_type_stack)
3022         (push_type_stack, get_type_stack, push_typelist)
3023         (follow_type_instance_flags, follow_types): Don't declare.
3024         * parse.c (type_stack): Remove global.
3025         (parse_exp_in_context): Update.
3026         (insert_into_type_stack, insert_type, push_type, push_type_int)
3027         (insert_type_address_space, pop_type, pop_type_int)
3028         (pop_typelist, pop_type_stack, append_type_stack)
3029         (push_type_stack, get_type_stack, push_typelist)
3030         (follow_type_instance_flags, follow_types): Remove (moved to
3031         type-stack.c).
3032         * f-exp.y (type_stack): New global.
3033         Update rules.
3034         (push_kind_type, f_parse): Update.
3035         * d-exp.y (type_stack): New global.
3036         Update rules.
3037         (d_parse): Update.
3038         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3039         Update rules.
3040         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3041         (HFILES_NO_SRCDIR): Add type-stack.h.
3042
3043 2019-04-04  Tom Tromey  <tom@tromey.com>
3044
3045         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3046         (rust_parser::convert_ast_to_expression, rust_parse)
3047         (rust_lex_test_completion, rust_lex_tests): Update.
3048         * parser-defs.h (struct expr_completion_state): New.
3049         (struct parser_state) <parser_state>: Add completion parameter.
3050         <mark_struct_expression, mark_completion_tag>: New methods.
3051         <parse_completion, m_completion_state>: New members.
3052         (prefixify_expression, null_post_parser): Update.
3053         (mark_struct_expression, mark_completion_tag): Don't declare.
3054         * parse.c (parse_completion, expout_last_struct)
3055         (expout_tag_completion_type, expout_completion_name): Remove
3056         globals.
3057         (parser_state::mark_struct_expression)
3058         (parser_state::mark_completion_tag): Now methods.
3059         (prefixify_expression): Add last_struct parameter.
3060         (prefixify_subexp): Likewise.
3061         (parse_exp_1): Update.
3062         (parse_exp_in_context): Add cstate parameter.  Update.
3063         (parse_expression_for_completion): Create an
3064         expr_completion_state.
3065         (null_post_parser): Add "completion" parameter.
3066         * p-exp.y: Update rules.
3067         (yylex): Update.
3068         * language.h (struct language_defn) <la_post_parser>: Add
3069         "completing" parameter.
3070         * go-exp.y: Update rules.
3071         (lex_one_token): Update.
3072         * expression.h (parse_completion): Don't declare.
3073         * d-exp.y: Update rules.
3074         (lex_one_token): Update rules.
3075         * c-exp.y: Update rules.
3076         (lex_one_token): Update.
3077         * ada-lang.c (resolve): Add "parse_completion" parameter.
3078         (resolve_subexp): Likewise.
3079         (ada_resolve_function): Likewise.
3080
3081 2019-04-04  Tom Tromey  <tom@tromey.com>
3082
3083         * parser-defs.h (struct parser_state) <start_arglist,
3084         end_arglist>: New methods.
3085         <arglist_len, m_funcall_chain>: New members.
3086         (arglist_len, start_arglist, end_arglist): Don't declare.
3087         * parse.c (arglist_len, funcall_chain): Remove global.
3088         (start_arglist, end_arglist): Remove functions.
3089         (parse_exp_in_context): Update.
3090         * p-exp.y: Update rules.
3091         * m2-exp.y: Update rules.
3092         * go-exp.y: Update rules.
3093         * f-exp.y: Update rules.
3094         * d-exp.y: Update rules.
3095         * c-exp.y: Update rules.
3096
3097 2019-04-04  Tom Tromey  <tom@tromey.com>
3098
3099         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3100         lex_operator, push_back>: New methods.
3101         Update all rules.
3102         (rust_parser::lex_hex, lex_escape): Rename and update.
3103         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3104         (rust_parser::lex_operator): Rename and update.
3105         (rust_parser::lex_number, rustyylex, rustyyerror)
3106         (rust_lex_test_init, rust_lex_test_sequence)
3107         (rust_lex_test_push_back, rust_lex_tests): Update.
3108         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3109         parameter.
3110         <lexptr, prev_lexptr>: New members.
3111         (lexptr, prev_lexptr): Don't declare.
3112         * parse.c (lexptr, prev_lexptr): Remove globals.
3113         (parse_exp_in_context): Update.
3114         * p-exp.y (yylex, yyerror): Update.
3115         * m2-exp.y (parse_number, yylex, yyerror): Update.
3116         * go-exp.y (lex_one_token, yyerror): Update.
3117         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3118         * d-exp.y (lex_one_token, yyerror): Update.
3119         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3120         (lex_one_token, yyerror): Update.
3121         * ada-lex.l (YY_INPUT): Update.
3122         (rewind_to_char): Update.
3123         * ada-exp.y (yyerror): Update.
3124
3125 2019-04-04  Tom Tromey  <tom@tromey.com>
3126
3127         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3128         * parser-defs.h (struct parser_state) <parser_state>: Add new
3129         parameter.
3130         <comma_terminates>: New member.
3131         (comma_terminates): Don't declare global.
3132         * parse.c (comma_terminates): Remove global.
3133         (parse_exp_in_context): Update.
3134         * p-exp.y (yylex): Update.
3135         * m2-exp.y (yylex): Update.
3136         * go-exp.y (lex_one_token): Update.
3137         * f-exp.y (yylex): Update.
3138         * d-exp.y (lex_one_token): Update.
3139         * c-exp.y (lex_one_token): Update.
3140         * ada-lex.l: Update.
3141
3142 2019-04-04  Tom Tromey  <tom@tromey.com>
3143
3144         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3145         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3146         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3147         * parser-defs.h (paren_depth): Don't declare.
3148         * parse.c (paren_depth): Remove global.
3149         (parse_exp_in_context): Update.
3150         * p-exp.y (paren_depth): New global.
3151         (pascal_parse): Initialize it.
3152         * m2-exp.y (paren_depth): New global.
3153         (m2_parse): Initialize it.
3154         * go-exp.y (paren_depth): New global.
3155         (go_parse): Initialize it.
3156         * f-exp.y (paren_depth): New global.
3157         (f_parse): Initialize it.
3158         * d-exp.y (paren_depth): New global.
3159         (d_parse): Initialize it.
3160         * c-exp.y (paren_depth): New global.
3161         (c_parse): Initialize it.
3162         * ada-lex.l (paren_depth): New global.
3163         (lexer_init): Initialize it.
3164
3165 2019-04-04  Tom Tromey  <tom@tromey.com>
3166
3167         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3168         (rust_parser::convert_ast_to_type)
3169         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3170         * parser-defs.h (struct parser_state) <parser_state>: Add
3171         parameters.  Initialize new members.
3172         <expression_context_block, expression_context_pc>: New members.
3173         * parse.c (expression_context_block, expression_context_pc):
3174         Remove globals.
3175         (parse_exp_in_context): Update.
3176         * p-exp.y: Update all rules.
3177         (yylex): Update.
3178         * m2-exp.y: Update all rules.
3179         (yylex): Update.
3180         * go-exp.y (yylex): Update.
3181         * f-exp.y (yylex): Update.
3182         * d-exp.y: Update all rules.
3183         (yylex): Update.
3184         * c-exp.y: Update all rules.
3185         (lex_one_token, classify_name, yylex, c_parse): Update.
3186         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3187
3188 2019-04-04  Tom Tromey  <tom@tromey.com>
3189
3190         * gdbarch.h, gdbarch.c: Rebuild.
3191         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3192         * stap-probe.h:
3193         (struct stap_parse_info): Replace "parser_state" with
3194         "expr_builder".
3195         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3196         (parser_state): New class.
3197         * parse.c (expr_builder): Rename.
3198         (expr_builder::release): Rename.
3199         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3200         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3201         (write_exp_elt_longcst, write_exp_elt_floatcst)
3202         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3203         (write_exp_string_vector, write_exp_bitstring)
3204         (write_exp_msymbol, mark_struct_expression)
3205         (write_dollar_variable)
3206         (insert_type_address_space, increase_expout_size): Replace
3207         "parser_state" with "expr_builder".
3208         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3209         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3210         "parser_state" with "expr_builder".
3211
3212 2019-04-04  Tom Tromey  <tom@tromey.com>
3213
3214         * rust-exp.y: Replace "parse_language" with method call.
3215         * p-exp.y:
3216         (yylex): Replace "parse_language" with method call.
3217         * m2-exp.y:
3218         (yylex): Replace "parse_language" with method call.
3219         * go-exp.y (classify_name): Replace "parse_language" with method
3220         call.
3221         * f-exp.y (yylex): Replace "parse_language" with method call.
3222         * d-exp.y (lex_one_token): Replace "parse_language" with method
3223         call.
3224         * c-exp.y:
3225         (lex_one_token, classify_name, yylex): Replace "parse_language"
3226         with method call.
3227         * ada-exp.y (find_primitive_type, type_char)
3228         (type_system_address): Replace "parse_language" with method call.
3229
3230 2019-04-04  Tom Tromey  <tom@tromey.com>
3231
3232         * rust-exp.y: Replace "parse_gdbarch" with method call.
3233         * parse.c (write_dollar_variable, insert_type_address_space):
3234         Replace "parse_gdbarch" with method call.
3235         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3236         call.
3237         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3238         call.
3239         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3240         "parse_gdbarch" with method call.
3241         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3242         with method call.
3243         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3244         "parse_gdbarch" with method call.
3245         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3246         "parse_gdbarch" with method call.
3247         * c-exp.y (parse_type, parse_number, classify_name): Replace
3248         "parse_gdbarch" with method call.
3249         * ada-lex.l: Replace "parse_gdbarch" with method call.
3250         * ada-exp.y (parse_type, find_primitive_type, type_char)
3251         (type_system_address): Replace "parse_gdbarch" with method call.
3252
3253 2019-04-04  Tom Tromey  <tom@tromey.com>
3254
3255         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3256         * stap-probe.c (stap_parse_argument): Update.
3257         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3258         initial_size parameter.
3259         * rust-exp.y (rust_lex_tests): Update.
3260         * parse.c (parser_state): Update.
3261         (parse_exp_in_context): Update.
3262         * parser-defs.h (struct parser_state) <parser_state>: Remove
3263         "initial_size" parameter.
3264
3265 2019-04-04  Tom Tromey  <tom@tromey.com>
3266
3267         * parser-defs.h (increase_expout_size): Don't declare.
3268         * parse.c (increase_expout_size): Now static.
3269
3270 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3271
3272         * gnu-nat.c (gnu_nat_target::wait): Fix
3273         target_waitstatus_to_string call.
3274
3275 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3276
3277         * eval.c (evaluate_subexp_standard): Handle internal functions
3278         during Fortran function call handling.
3279
3280 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3281
3282         * NEWS: Mention new internal functions.
3283         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3284         (read_base_type): Use dwarf2_init_complex_target_type.
3285         * value.c (creal_internal_fn): New function.
3286         (cimag_internal_fn): New function.
3287         (_initialize_values): Register new internal functions.
3288
3289 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3290
3291         * infrun.c (stop_all_threads): If debug_infrun, always
3292         trace the wait status after wait_one, using
3293         target_waitstatus_to_string and target_pid_to_str.
3294         (handle_inferior_event): Replace various trace of
3295         wait status kind by a single trace.
3296         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3297         wait status kind image by target_waitstatus_to_string.
3298         * target/waitstatus.c (target_waitstatus_to_string): Fix
3299         obsolete comment.
3300
3301 2019-04-01  Tom Tromey  <tromey@adacore.com>
3302
3303         PR symtab/23331:
3304         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3305
3306 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3307             Pedro Alves  <palves@redhat.com>
3308
3309         * top.c (quit_force): Call 'finalize_values'.
3310         * value.c (finalize_values): New function.
3311         * value.h (finalize_values): Declare.
3312
3313 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3314
3315         * NEWS: Announce $_gdb_major and $_gdb_minor.
3316
3317         * top.c (init_gdb_version_vars): New function.
3318         (gdb_init): Call init_gdb_version_vars.
3319
3320 2019-03-29  Tom Tromey  <tromey@adacore.com>
3321
3322         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3323         help text.  Remove dead code.
3324
3325 2019-03-29  Keith Seitz  <keiths@redhat.com>
3326
3327         From Siddhesh Poyarekar:
3328         * f-lang.h (f77_get_upperbound): Return LONGEST.
3329         (f77_get_lowerbound): Likewise.
3330         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3331         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3332         print them.
3333         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3334         plongest to format print it.
3335         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3336         (f77_get_upperbound): Likewise.
3337         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3338         LOWER_BOUND to LONGEST.
3339         (f77_create_arrayprint_offset_tbl): Likewise.
3340
3341 2019-03-29  Keith Seitz  <keiths@redhat.com>
3342
3343         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3344         %s/pulongest for TYPE_LENGTH instead of %d in format
3345         strings.
3346         * ada-typerint.c (ada_print_type): Likewise.
3347         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3348         * compile/compile-c-support.c (generate_register_struct): Likewise.
3349         * gdbtypes.c (recursive_dump_type): Likewise.
3350         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3351         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3352         instead of %d in format strings.
3353         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3354         to std::min to ULONGEST.
3355         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3356         instead of %d in format strings.
3357         * tracepoint.c (info_scope_command): Likewise.
3358         * typeprint.c (print_offset_data::update)
3359         (print_offset_data::finish): Likewise.
3360         * xtensa-tdep.c (xtensa_store_return_value)
3361         (xtensa_push_dummy_call): Likewise.
3362
3363 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3364
3365         * windows-nat.c (display_selector): Fixed format specifications
3366         for 64-bit Cygwin.
3367
3368 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3369
3370         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3371
3372 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3373
3374         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3375         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3376         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3377         (nios2_linux_init_abi): Install it.
3378
3379 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3380
3381         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3382
3383 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3384
3385         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3386
3387 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3388             Tom Tromey  <tromey@adacore.com>
3389
3390         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3391
3392 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3393
3394         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3395         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3396         method to compute the bounds of range types. Also print "[evaluated]"
3397         if the bounds' values come from a dynamic evaluation.
3398
3399 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3402         whitespace when pretty printing is on.
3403
3404 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3405
3406         * ppc-linux-nat.c: Add include.
3407
3408 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3409
3410         * NEWS: Mention AArch64 Pointer Authentication.
3411
3412 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3413
3414         * arm-linux-nat.c: Add include.
3415
3416 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3417
3418         * source-cache.c (source_cache::get_source_lines): Re-read
3419         fullname after calling open_source_file.
3420
3421 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3422
3423         * NEWS: Mention TLS support for FreeBSD.
3424
3425 2019-03-25  Tom Tromey  <tromey@adacore.com>
3426
3427         * minsyms.c (BUNCH_SIZE): Update comment.
3428         (~minimal_symbol_reader): Remove old comment.
3429         (compact_minimal_symbols): Update comment.
3430         (minimal_symbol_reader::install): Remove old comment.  Update
3431         other comments.
3432
3433 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3434
3435         * s390-linux-nat.c: Add include.
3436
3437 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3438
3439         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3440         Call linux_get_hwcap.
3441         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3442         Likewise.
3443         (aarch64_linux_get_hwcap): Remove function.
3444         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3445         declaration.
3446         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3447         linux_get_hwcap.
3448         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3449         * linux-tdep.c (linux_get_hwcap): Add function.
3450         (linux_get_hwcap2): Likewise.
3451         * linux-tdep.h (linux_get_hwcap): Add declaration.
3452         (linux_get_hwcap2): Likewise.
3453         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3454         (ppc_linux_get_hwcap2): Likewise.
3455         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3456         linux_get_hwcap.
3457         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3458         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3459         (ppc_linux_nat_target::read_description): Likewise.
3460         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3461         * s390-linux-nat.c: Likewise.
3462         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3463
3464 2019-03-24  Tom Tromey  <tom@tromey.com>
3465
3466         * ada-lang.c (standard_lookup): Simplify initialization.
3467         (ada_lookup_symbol_nonlocal): Simplify return.
3468         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3469         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3470         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3471         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3472         initialization.
3473         * solib.c (solib_global_lookup): Simplify.
3474         * symtab.c (null_block_symbol): Remove.
3475         (symbol_cache_lookup): Simplify returns.
3476         (lookup_language_this): Simplify returns.
3477         (lookup_symbol_aux): Simplify return.
3478         (lookup_local_symbol): Simplify returns.
3479         (lookup_global_symbol_from_objfile): Simplify return.
3480         (lookup_symbol_in_objfile_symtabs)
3481         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3482         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3483         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3484         * cp-namespace.c (cp_lookup_bare_symbol)
3485         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3486         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3487         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3488         (cp_lookup_symbol_via_imports): Simplify initialization.
3489         (find_symbol_in_baseclass): Likewise.
3490         * symtab.h (null_block_symbol): Remove.
3491         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3492         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3493         (d_lookup_symbol_module): Likewise.
3494         (find_symbol_in_baseclass): Simplify initialization.
3495
3496 2019-03-24  Tom Tromey  <tom@tromey.com>
3497
3498         * expression.h: Don't include symtab.h.
3499         (struct block): Forward declare.
3500
3501 2019-03-24  Tom Tromey  <tom@tromey.com>
3502
3503         * c-exp.y (typebase): Remove casts.
3504         * gdbtypes.c (lookup_unsigned_typename, )
3505         (lookup_signed_typename): Remove cast.
3506         * eval.c (parse_to_comma_and_eval): Remove cast.
3507         * parse.c (write_dollar_variable): Remove cast.
3508         * block.h (struct block) <superblock>: Now const.
3509         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3510         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3511         (map_block): Make "block" const.
3512         * symfile.h (struct quick_symbol_functions)
3513         <map_matching_symbols>: Constify block argument to "callback".
3514         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3515         const.
3516         (find_pc_sect_compunit_symtab): Make "b" const.
3517         (find_symbol_at_address): Likewise.
3518         (search_symbols): Likewise.
3519         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3520         (dw2_debug_names_lookup_symbol): Likewise.
3521         (dw2_map_matching_symbols): Update.
3522         * p-valprint.c (pascal_val_print): Remove "block".
3523         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3524         (aux_add_nonlocal_symbols): Make "block" const.
3525         (resolve_subexp): Remove cast.
3526         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3527         const.
3528         (iterate_over_file_blocks): Likewise.
3529         * f-exp.y (%union) <bval>: Remove.
3530         * coffread.c (patch_opaque_types): Make "b" const.
3531         * spu-tdep.c (spu_catch_start): Make "block" const.
3532         * c-valprint.c (print_unpacked_pointer): Remove "block".
3533         * symmisc.c (dump_symtab_1): Make "b" const.
3534         (block_depth): Make "block" const.
3535         * d-exp.y (%union) <bval>: Remove.
3536         * cp-support.h (cp_lookup_rtti_type): Update.
3537         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3538         * psymtab.c (psym_lookup_symbol): Make "block" const.
3539         (maintenance_check_psymtabs): Make "b" const.
3540         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3541         (enumerate_locals, enumerate_args): Update.
3542         * python/py-symtab.c (stpy_global_block): Make "block" const.
3543         (stpy_static_block): Likewise.
3544         * inline-frame.c (block_starting_point_at): Make "new_block"
3545         const.
3546         * block.c (find_block_in_blockvector): Make return type const.
3547         (blockvector_for_pc_sect): Make "b" const.
3548         (find_block_in_blockvector): Make "b" const.
3549
3550 2019-03-23  Tom Tromey  <tom@tromey.com>
3551
3552         * varobj.c (varobj_create): Update.
3553         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3554         * printcmd.c (display_command, do_one_display): Don't reset
3555         innermost_block.
3556         * parser-defs.h (enum innermost_block_tracker_type): Move to
3557         expression.h.
3558         (innermost_block): Update comment.
3559         * parse.c (parse_exp_1): Add tracker_types parameter.
3560         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3561         tracker_types parameter.  Reset innermost_block.
3562         (parse_exp_in_context): Remove.
3563         (parse_expression_for_completion): Update.
3564         * objfiles.c (~objfile): Don't reset expression_context_block or
3565         innermost_block.
3566         * expression.h (enum innermost_block_tracker_type): Move from
3567         parser-defs.h.
3568         (parse_exp_1): Add tracker_types parameter.
3569         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3570         reset innermost_block.
3571
3572 2019-03-23  Tom Tromey  <tom@tromey.com>
3573
3574         * objfiles.h: Include bcache.h.
3575
3576 2019-03-23  Tom Tromey  <tom@tromey.com>
3577
3578         * linespec.c (get_current_search_block): Use
3579         scoped_restore_current_language.
3580         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3581
3582 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3583             Jiong Wang  <jiong.wang@arm.com>
3584
3585         * aarch64-linux-tdep.c
3586         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3587         section.
3588         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3589
3590 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3591             Jiong Wang  <jiong.wang@arm.com>
3592
3593         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3594         instructions.
3595         (aarch64_analyze_prologue_test): Add PACIASP test.
3596         (aarch64_prologue_prev_register): Unmask PC value.
3597
3598 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3599             Jiong Wang  <jiong.wang@arm.com>
3600
3601         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3602         (aarch64_dwarf2_prev_register): Unmask PC value.
3603         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3604         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3605         DW_CFA_AARCH64_negate_ra_state.
3606         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3607
3608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3609             Jiong Wang  <jiong.wang@arm.com>
3610
3611         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3612         registers.
3613         (aarch64_pseudo_register_name): Likewise.
3614         (aarch64_pseudo_register_type): Likewise.
3615         (aarch64_pseudo_register_reggroup_p): Likewise.
3616         (aarch64_gdbarch_init): Add pauth registers.
3617         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3618         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3619         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3620         (struct gdbarch_tdep): Add regnum for ra_state.
3621
3622 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3623             Jiong Wang  <jiong.wang@arm.com>
3624
3625         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3626
3627 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3628             Jiong Wang  <jiong.wang@arm.com>
3629
3630         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3631         function.
3632         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3633         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3634         (aarch64_gdbarch_init): Add puth registers.
3635         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3636         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3637         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3638
3639 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3640             Jiong Wang  <jiong.wang@arm.com>
3641
3642         * aarch64-linux-nat.c
3643         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3644         * aarch64-linux-tdep.c
3645         (aarch64_linux_core_read_description): Likewise.
3646         (aarch64_linux_get_hwcap): New function.
3647         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3648         (aarch64_linux_get_hwcap): New declaration.
3649
3650 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3651             Jiong Wang  <jiong.wang@arm.com>
3652
3653         * aarch64-linux-nat.c
3654         (aarch64_linux_nat_target::read_description): Add pauth param.
3655         * aarch64-linux-tdep.c
3656         (aarch64_linux_core_read_description): Likewise.
3657         * aarch64-tdep.c (struct target_desc): Add in pauth.
3658         (aarch64_read_description): Add pauth param.
3659         (aarch64_gdbarch_init): Likewise.
3660         * aarch64-tdep.h (aarch64_read_description): Likewise.
3661         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3662         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3663         * features/Makefile: Add new files.
3664         * features/aarch64-pauth.c: New file.
3665         * features/aarch64-pauth.xml: New file.
3666
3667 2019-03-20  Tom Tromey  <tromey@adacore.com>
3668
3669         * infrun.c (handle_inferior_event): Rename from
3670         handle_inferior_event_1.  Create a scoped_value_mark.
3671         (handle_inferior_event): Remove.
3672
3673 2019-03-19  Tom Tromey  <tromey@adacore.com>
3674
3675         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3676         * infrun.h (print_stop_event): Add "displays" parameter.
3677         * infrun.c (print_stop_event): Add "displays" parameter.
3678
3679 2019-03-19  Pedro Alves  <palves@redhat.com>
3680
3681         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3682         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3683         to -1.  Fix TABs vs spaces.
3684         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3685         * tui/tui-out.h (tui_ui_out) Add intro comments.
3686         <m_line, m_start_of_line>: In-class initialize, and add describing
3687         comment.
3688
3689 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3690
3691         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3692         variable names.
3693         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3694
3695 2019-03-18  Pedro Alves  <palves@redhat.com>
3696             Eli Zaretskii <eliz@gnu.org>
3697
3698         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3699         m_line and m_start_of_line.
3700
3701 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3702
3703         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3704         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3705         it returns a newline.  This fixes a regression in TU mode, whereby
3706         the next line is output on the same screen line as the user input.
3707
3708 2019-03-18  Tom Tromey  <tromey@adacore.com>
3709
3710         * minsyms.c (minimal_symbol_reader::install): Remove call to
3711         obstack_blank.
3712
3713 2019-03-18  Pedro Alves  <palves@redhat.com>
3714
3715         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3716         New globals.
3717         (apply_style): New, factored out from ...
3718         (apply_ansi_escape): ... this.  Handle reverse video mode.
3719         (tui_set_reverse_mode): New function.
3720         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3721         * tui/tui-winsource.c (tui_show_source_line): Use
3722         tui_set_reverse_mode instead of setting A_STANDOUT.
3723         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3724         New setter methods.
3725
3726 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3727
3728         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3729         Handle tabs.
3730
3731 2019-03-18  Tom Tromey  <tromey@adacore.com>
3732
3733         * ada-lang.c (empty_array): Add "high" parameter.
3734         (ada_evaluate_subexp): Update.
3735
3736 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3737
3738         * unittests/string_view-selftests.c: Define
3739         _initialize_string_view_selftests unconditionally.
3740
3741 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3742
3743         PR gdb/24350
3744         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3745
3746 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3747
3748         PR gdb/24351
3749         * windows-nat.c (display_selector): Fix format specifiers.
3750
3751 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3752
3753         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3754         tui_refill_source_window instead of tui_refresh_win, to update the
3755         current execution line.  This fixes redisplay of the current line
3756         when stepping through the code with "next" or "step".
3757
3758 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3759
3760         * source-cache.c (source_cache::get_source_lines): Call
3761         find_source_lines to initialize s->nlines.  This fixes vertical
3762         scrolling of TUI source window when the DOWN arrow is pressed.
3763
3764 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3765
3766         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3767         linux-thread-db.c (_initialize_thread_db): Likewise.
3768
3769 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3770
3771         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3772         wclrtoeol in tui_show_source_line".  This reverts changes made in
3773         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3774
3775 2019-03-15  Tom Tromey  <tom@tromey.com>
3776
3777         * symtab.h (struct minimal_symbol): Derive from
3778         general_symbol_info.
3779         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3780         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3781         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3782         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3783         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3784         (MSYMBOL_SEARCH_NAME): Update.
3785         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3786         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3787         * minsyms.c (minimal_symbol_reader::record_full): Update.
3788
3789 2019-03-15  Tom Tromey  <tom@tromey.com>
3790
3791         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3792
3793 2019-03-15  Tom Tromey  <tom@tromey.com>
3794
3795         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3796         unique_xmalloc_ptr.
3797         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3798         Update.
3799         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3800         (build_minimal_symbol_hash_tables)
3801         (minimal_symbol_reader::install): Update.
3802
3803 2019-03-15  Tom Tromey  <tom@tromey.com>
3804
3805         * symtab.c (create_demangled_names_hash): Update.
3806         (symbol_set_names): Update.
3807         * objfiles.h (struct objfile_per_bfd_storage)
3808         <demangled_names_hash>: Now an htab_up.
3809         * objfiles.c (objfile_per_bfd_storage): Simplify.
3810
3811 2019-03-15  Tom Tromey  <tom@tromey.com>
3812
3813         * objfiles.h (struct objfile_per_bfd_storage): Declare
3814         destructor.
3815         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3816         New.
3817         (get_objfile_bfd_data): Use new.  Don't initialize
3818         language_of_main.
3819         (free_objfile_per_bfd_storage): Remove.
3820         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3821
3822 2019-03-15  Tom Tromey  <tom@tromey.com>
3823
3824         * symfile.c (reread_symbols): Update.
3825         * objfiles.c (objfile::objfile): Update.
3826         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3827         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3828         comment.
3829         (minimal_symbol_reader::install): Update.
3830         (terminate_minimal_symbol_table): Remove.
3831         * jit.c (jit_object_close_impl): Update.
3832
3833 2019-03-15  Tom Tromey  <tom@tromey.com>
3834
3835         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3836         initializations.
3837
3838 2019-03-15  Tom Tromey  <tom@tromey.com>
3839
3840         * objfiles.h (struct objfile_per_bfd_storage)
3841         <demangled_hash_languages>: Now a bitset.
3842         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3843         (lookup_minimal_symbol): Update.
3844
3845 2019-03-15  Tom Tromey  <tom@tromey.com>
3846
3847         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3848         Don't return the symbol.
3849         * coffread.c (record_minimal_symbol): Use record_full.
3850
3851 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3852
3853         The MS-Windows port of ncurses fails to switch to a color pair if
3854         one or both of the colors are the implicit default colors.  This
3855         change records the default colors when TUI is initialized, and
3856         then specifies them explicitly when a color pair uses the default
3857         colors.  This allows color styling in TUI mode on MS-Windows.
3858
3859         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3860         ncurses_norm_attr.
3861         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3862         colors in ncurses_norm_attr.
3863         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3864         "none", replace it with the default color recorded in
3865         ncurses_norm_attr.
3866
3867 2019-03-14  Tom Tromey  <tromey@adacore.com>
3868
3869         * source-cache.h (class source_cache) <get_source_lines>: Return
3870         std::string.
3871         * source-cache.c (source_cache::extract_lines): Handle case where
3872         first_pos==npos.  Return std::string.
3873         (source_cache::get_source_lines): Update.
3874
3875 2019-03-14  Tom Tromey  <tromey@adacore.com>
3876
3877         * NEWS: Add item for "style sources" commands.
3878         * source-cache.c (source_cache::get_source_lines): Check
3879         source_styling.
3880         * cli/cli-style.c (source_styling): New global.
3881         (_initialize_cli_style): Add "style sources" commands.
3882         (show_style_sources): New function.
3883         * cli/cli-style.h (source_styling): Declare.
3884
3885 2019-03-14  Pedro Alves  <palves@redhat.com>
3886             Tom Tromey  <tromey@adacore.com>
3887
3888         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3889         * tui/tui-winsource.c (tui_refill_source_window): New function,
3890         from...
3891         (tui_horizontal_source_scroll): ... here.  Move some logic.
3892         * cli/cli-style.c (set_style_enabled): Notify new observable.
3893         * tui/tui-hooks.c (tui_redisplay_source): New function.
3894         (tui_attach_detach_observers): Attach or detach
3895         tui_redisplay_source.
3896         * observable.h (source_styling_changed): New observable.
3897         * observable.c: Define source_styling_changed observable.
3898
3899 2019-03-13  Tom Tromey  <tromey@adacore.com>
3900
3901         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3902         (i386_gnu_nat_target::store_registers): Update.
3903         * target-debug.h (target_debug_print_std_string): New macro.
3904         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3905         * windows-tdep.c (display_one_tib): Update.
3906         * tui/tui-stack.c (tui_make_status_line): Update.
3907         * top.c (print_inferior_quit_action): Update.
3908         * thread.c (thr_try_catch_cmd): Update.
3909         (add_thread_with_info): Update.
3910         (thread_target_id_str): Update.
3911         (thr_try_catch_cmd): Update.
3912         (thread_command): Update.
3913         (thread_find_command): Update.
3914         * record-btrace.c (record_btrace_target::info_record)
3915         (record_btrace_resume_thread, record_btrace_target::resume)
3916         (record_btrace_cancel_resume, record_btrace_step_thread)
3917         (record_btrace_target::wait, record_btrace_target::wait)
3918         (record_btrace_target::wait, record_btrace_target::stop): Update.
3919         * progspace.c (print_program_space): Update.
3920         * process-stratum-target.c
3921         (process_stratum_target::thread_address_space): Update.
3922         * linux-fork.c (linux_fork_mourn_inferior)
3923         (detach_checkpoint_command, info_checkpoints_command)
3924         (linux_fork_context): Update.
3925         (linux_fork_detach): Update.
3926         (class scoped_switch_fork_info): Update.
3927         (delete_checkpoint_command): Update.
3928         * infrun.c (follow_fork_inferior): Update.
3929         (follow_fork_inferior): Update.
3930         (proceed_after_vfork_done): Update.
3931         (handle_vfork_child_exec_or_exit): Update.
3932         (follow_exec): Update.
3933         (displaced_step_prepare_throw): Update.
3934         (displaced_step_restore): Update.
3935         (start_step_over): Update.
3936         (resume_1): Update.
3937         (clear_proceed_status_thread): Update.
3938         (proceed): Update.
3939         (print_target_wait_results): Update.
3940         (do_target_wait): Update.
3941         (context_switch): Update.
3942         (stop_all_threads): Update.
3943         (restart_threads): Update.
3944         (finish_step_over): Update.
3945         (handle_signal_stop): Update.
3946         (switch_back_to_stepped_thread): Update.
3947         (keep_going_pass_signal): Update.
3948         (print_exited_reason): Update.
3949         (normal_stop): Update.
3950         * inferior.c (inferior_pid_to_str): Change return type.
3951         (print_selected_inferior): Update.
3952         (add_inferior): Update.
3953         (detach_inferior): Update.
3954         * dummy-frame.c (fprint_dummy_frames): Update.
3955         * dcache.c (dcache_info_1): Update.
3956         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3957         (btrace_fetch, btrace_clear): Update.
3958         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3959         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3960         type.
3961         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3962         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3963         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3964         * gdbarch.c, gdbarch.h: Rebuild.
3965         * gdbarch.sh (core_pid_to_str): Change return type.
3966         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3967         return type.
3968         (windows_nat_target::pid_to_str): Change return type.
3969         (windows_delete_thread): Update.
3970         (windows_nat_target::attach): Update.
3971         (windows_nat_target::files_info): Update.
3972         * target-delegates.c: Rebuild.
3973         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3974         return type.
3975         (sol_thread_target::pid_to_str): Change return type.
3976         * remote.c (class remote_target) <pid_to_str>: Change return
3977         type.
3978         (remote_target::pid_to_str): Change return type.
3979         (extended_remote_target::attach, remote_target::remote_stop_ns)
3980         (remote_target::remote_notif_remove_queued_reply)
3981         (remote_target::push_stop_reply, remote_target::disable_btrace):
3982         Update.
3983         (extended_remote_target::attach): Update.
3984         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3985         type.
3986         (gdbsim_target::pid_to_str): Change return type.
3987         * ravenscar-thread.c (struct ravenscar_thread_target)
3988         <pid_to_str>: Change return type.
3989         (ravenscar_thread_target::pid_to_str): Change return type.
3990         * procfs.c (class procfs_target) <pid_to_str>: Change return
3991         type.
3992         (procfs_target::pid_to_str): Change return type.
3993         (procfs_target::attach): Update.
3994         (procfs_target::detach): Update.
3995         (procfs_target::fetch_registers): Update.
3996         (procfs_target::store_registers): Update.
3997         (procfs_target::wait): Update.
3998         (procfs_target::files_info): Update.
3999         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4000         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4001         return type.
4002         (nto_procfs_target::pid_to_str): Change return type.
4003         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4004         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4005         return type.
4006         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4007         (exit_lwp): Update.
4008         (attach_proc_task_lwp_callback, get_detach_signal)
4009         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4010         (linux_nat_target::resume, wait_lwp, stop_callback)
4011         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4012         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4013         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4014         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4015         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4016         type.
4017         (inf_ptrace_target::attach): Update.
4018         (inf_ptrace_target::files_info): Update.
4019         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4020         type.
4021         (go32_nat_target::pid_to_str): Change return type.
4022         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4023         (gnu_nat_target::wait): Update.
4024         (gnu_nat_target::wait): Update.
4025         (gnu_nat_target::resume): Update.
4026         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4027         (fbsd_nat_target::wait): Update.
4028         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4029         type.
4030         (darwin_nat_target::attach): Update.
4031         * corelow.c (class core_target) <pid_to_str>: Change return type.
4032         (core_target::pid_to_str): Change return type.
4033         * target.c (normal_pid_to_str): Change return type.
4034         (default_pid_to_str): Likewise.
4035         (target_pid_to_str): Change return type.
4036         (target_translate_tls_address): Update.
4037         (target_announce_detach): Update.
4038         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4039         return type.
4040         (bsd_uthread_target::pid_to_str): Change return type.
4041         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4042         type.
4043         (bsd_kvm_target::pid_to_str): Change return type.
4044         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4045         return type.
4046         (aix_thread_target::pid_to_str): Change return type.
4047         * target.h (struct target_ops) <pid_to_str>: Change return type.
4048         (target_pid_to_str, normal_pid_to_str): Likewise.
4049         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4050         type.
4051         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4052         type.
4053         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4054         return type.
4055         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4056         type.
4057         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4058         type.
4059         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4060         return type.
4061
4062 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4063
4064         * NEWS: Mention that the new default MI version is 3.  Mention
4065         changes to the output of commands and events that deal with
4066         multi-location breakpoints.
4067         * breakpoint.c: Include "mi/mi-out.h".
4068         (print_one_breakpoint): Change output syntax if using MI version
4069         >= 3.
4070         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4071         New.
4072         (mi_multi_location_breakpoint_output_fixed): New.
4073         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4074         (mi_cmd_fix_multi_location_breakpoint_output): New.
4075         (mi_multi_location_breakpoint_output_fixed): New.
4076         * mi/mi-cmds.c (mi_cmds): Register command
4077         -fix-multi-location-breakpoint-output.
4078         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4079         interpreter "mi".
4080
4081 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4082
4083         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4084         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4085         instantiate mi_ui_out based on interpreter name.
4086         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4087         * mi/mi-main.c (mi_load_progress): Likewise.
4088
4089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4090
4091         * NEWS: Combine separate "New targets" sections for 8.3.
4092
4093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4094
4095         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4096         (ppcfbsd_init_abi): Install gdbarch
4097         "fetch_tls_load_module_address" and "get_thread_local_address"
4098         methods.
4099
4100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4101
4102         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4103         (riscv_fbsd_init_abi): Install gdbarch
4104         "fetch_tls_load_module_address" and "get_thread_local_address"
4105         methods.
4106
4107 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4108
4109         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4110         (i386fbsd_init_abi): Install gdbarch
4111         "fetch_tls_load_module_address" and "get_thread_local_address"
4112         methods.
4113
4114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4115
4116         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4117         (amd64fbsd_init_abi): Install gdbarch
4118         "fetch_tls_load_module_address" and "get_thread_local_address"
4119         methods.
4120
4121 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4122
4123         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4124         (struct fbsd_pspace_data): New type.
4125         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4126         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4127         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4128         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4129         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4130
4131 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4132
4133         * gdbtypes.c (lookup_struct_elt): New function.
4134         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4135         * gdbtypes.h (struct struct_elt): New type.
4136         (lookup_struct_elt): New prototype.
4137
4138 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4139
4140         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4141         remove disabled code block.
4142
4143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4144
4145         * gdbarch.sh (get_thread_local_address): New method.
4146         * gdbarch.h, gdbarch.c: Regenerate.
4147         * target.c (target_translate_tls_address): Use
4148         gdbarch_get_thread_local_address if present instead of
4149         target::get_thread_local_address.
4150
4151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4152
4153         * target.h (target::get_thread_local_address): Update comment.
4154
4155 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4156
4157         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4158         objfile->separate_debug_objfile_backlink if not NULL.
4159
4160 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4161
4162         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4163         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4164         (amd64bsd_store_inferior_registers): Likewise.
4165         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4166         Enable segment base registers.
4167         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4168         PT_GETFSBASE and PT_GETGSBASE.
4169         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4170         PT_SETGSBASE.
4171         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4172         segment base registers.
4173         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4174
4175 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4176
4177         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4178         Update calls to i386_target_description to add 'segments'
4179         parameter.
4180         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4181         add segment base registers.
4182         * arch/i386.c (i386_create_target_description): Add 'segments'
4183         parameter to enable segment base registers.
4184         * arch/i386.h (i386_create_target_description): Likewise.
4185         * features/i386/32bit-segments.xml: New file.
4186         * features/i386/32bit-segments.c: Generate.
4187         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4188         call to i386_target_description to add 'segments' parameter.
4189         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4190         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4191         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4192         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4193         if feature is present.
4194         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4195         Add 'segments' parameter to call to i386_target_description.
4196         (i386_target_description): Add 'segments' parameter to enable
4197         segment base registers.
4198         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4199         to call to i386_target_description.
4200         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4201         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4202         Define I386_NUM_REGS.
4203         (i386_target_description): Add 'segments' parameter to enable
4204         segment base registers.
4205
4206 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4207
4208         PR/24325
4209         * source-cache.c: #undef open and close, to avoid unresolved
4210         externals during linking.
4211
4212 2019-03-12  Tom Tromey  <tromey@adacore.com>
4213
4214         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4215         const.  Add initializers.
4216         (_initialize_remote): Don't initialize ptid globals.
4217
4218 2019-03-12  Pedro Alves  <palves@redhat.com>
4219
4220         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4221
4222 2019-03-12  Pedro Alves  <palves@redhat.com>
4223
4224         * cp-name-parser.y (main): Remove unused 'len' variable.
4225
4226 2019-03-12  Tom Tromey  <tromey@adacore.com>
4227
4228         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4229         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4230
4231 2019-03-12  Tom Tromey  <tromey@adacore.com>
4232
4233         * linux-nat.c (iterate_over_lwps): Update.
4234         (stop_callback): Remove parameter.
4235         (stop_wait_callback, detach_callback, resume_set_callback)
4236         (select_singlestep_lwp_callback, set_ignore_sigint)
4237         (status_callback, resumed_callback, resume_clear_callback)
4238         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4239         data parameter.
4240         (linux_nat_target::detach, linux_nat_target::resume)
4241         (linux_stop_and_wait_all_lwps, select_event_lwp)
4242         (linux_nat_filter_event, linux_nat_wait_1)
4243         (linux_nat_target::kill, linux_nat_target::stop)
4244         (linux_nat_target::stop): Update.
4245         (linux_nat_resume_callback): Change type.
4246         (resume_stopped_resumed_lwps, count_events_callback)
4247         (select_event_lwp_callback): Likewise.
4248         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4249         * arm-linux-nat.c (struct update_registers_data): Remove.
4250         (update_registers_callback): Change type.
4251         (arm_linux_insert_hw_breakpoint1): Update.
4252         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4253         parameter.
4254         (x86_linux_dr_set_addr): Update.
4255         (x86_linux_dr_set_control): Update.
4256         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4257         (iterate_over_lwps): Use gdb::function_view.
4258         * nat/aarch64-linux-hw-point.c (struct
4259         aarch64_dr_update_callback_param): Remove.
4260         (debug_reg_change_callback): Change type.
4261         (aarch64_notify_debug_reg_change): Update.
4262         * s390-linux-nat.c (s390_refresh_per_info): Update.
4263
4264 2019-03-11  Tom Tromey  <tromey@adacore.com>
4265
4266         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4267         redundant assignment to "this_cu".
4268
4269 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4270
4271         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4272
4273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4274
4275         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4276         from...
4277         (rank_one_type): ... this.
4278
4279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4280
4281         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4282         from...
4283         (rank_one_type): ... this.
4284
4285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4286
4287         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4288         from...
4289         (rank_one_type): ... this.
4290
4291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4292
4293         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4294         from...
4295         (rank_one_type): ... this.
4296
4297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4298
4299         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4300         from...
4301         (rank_one_type): ... this.
4302
4303 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4304
4305         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4306         from...
4307         (rank_one_type): ... this.
4308
4309 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4310
4311         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4312         from...
4313         (rank_one_type): ... this.
4314
4315 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4316
4317         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4318         from...
4319         (rank_one_type): ... this.
4320
4321 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4322
4323         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4324         from...
4325         (rank_one_type): ... this.
4326
4327 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4328
4329         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4330         from...
4331         (rank_one_type): ... this.
4332
4333 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4334
4335         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4336         from...
4337         (rank_one_type): ... this.
4338
4339 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4340
4341         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4342         from...
4343         (rank_one_type): ... this.
4344
4345 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4346
4347         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4348         inferior-events' shows the example events.
4349
4350 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4351
4352         Support styling on native MS-Windows console
4353
4354         PR/24315
4355         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4356         on MS-Windows if $TERM is not defined.
4357
4358         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4359
4360         * posix-hdep.c (gdb_console_fputs):
4361         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4362         functions.
4363         * ui-file.h (gdb_console_fputs): Add prototype.
4364
4365         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4366         back to fputs only if the former returns zero.
4367
4368 2019-03-07  Tom Tromey  <tom@tromey.com>
4369
4370         * symmisc.c (print_symbol_bcache_statistics): Update.
4371         (print_objfile_statistics): Update.
4372         * symfile.c (allocate_symtab): Update.
4373         * stabsread.c: Don't include bcache.h.
4374         * psymtab.h (struct psymbol_bcache): Don't declare.
4375         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4376         (psymbol_bcache_init, psymbol_bcache_free)
4377         (psymbol_bcache_get_bcache): Don't declare.
4378         * psymtab.c (struct psymbol_bcache): Remove.
4379         (psymtab_storage::psymtab_storage): Update.
4380         (psymtab_storage::~psymtab_storage): Update.
4381         (psymbol_bcache_init, psymbol_bcache_free)
4382         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4383         (add_psymbol_to_bcache): Update.
4384         (allocate_psymtab): Update.
4385         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4386         macro_cache>: No longer pointers.
4387         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4388         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4389         * macrotab.c (macro_bcache): Update.
4390         * macroexp.c: Don't include bcache.h.
4391         * gdbtypes.c (check_types_worklist): Update.
4392         (types_deeply_equal): Remove TRY/CATCH.  Update.
4393         * elfread.c (elf_symtab_read): Update.
4394         * dwarf2read.c: Don't include bcache.h.
4395         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4396         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4397         (print_bcache_statistics, bcache_memory_used): Don't declare.
4398         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4399         methods.  Rename all data members.
4400         * bcache.c (struct bcache): Move to bcache.h.
4401         (bcache::expand_hash_table): Rename from expand_hash_table.
4402         (bcache): Remove.
4403         (bcache::insert): Rename from bcache_full.
4404         (bcache::compare): Rename from bcache_compare.
4405         (bcache_xmalloc): Remove.
4406         (bcache::~bcache): Rename from bcache_xfree.
4407         (bcache::print_statistics): Rename from print_bcache_statistics.
4408         (bcache::memory_used): Rename from bcache_memory_used.
4409
4410 2019-03-07  Pedro Alves  <palves@redhat.com>
4411
4412         * infrun.c (normal_stop): Also check for
4413         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4414
4415 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4416
4417         * f-lang.c (value_from_host_double): Moved to...
4418         * value.c (value_from_host_double): ...here.
4419         * value.h (value_from_host_double): Declare.
4420         * guile/scm-math.c (vlscm_convert_typed_number): Use
4421         value_from_host_double.
4422         (vlscm_convert_number): Likewise.
4423         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4424         * python/py-value.c (convert_value_from_python): Likewise.
4425
4426 2019-03-06  Tom Tromey  <tom@tromey.com>
4427
4428         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4429
4430 2019-03-06  Tom Tromey  <tom@tromey.com>
4431
4432         * utils.h (free_current_contents): Don't declare.
4433         * utils.c (free_current_contents): Remove.
4434
4435 2019-03-06  Tom Tromey  <tom@tromey.com>
4436
4437         * top.c (quit_force): Update.
4438         * main.c (captured_command_loop): Update.
4439         * common/new-op.c (operator new): Update.
4440         * common/common-exceptions.c (struct catcher)
4441         <save_cleanup_chain>: Remove member.
4442         (exceptions_state_mc_init): Update.
4443         (exception_try_scope_entry): Return nullptr.
4444         (exception_try_scope_exit, exception_rethrow)
4445         (throw_exception_sjlj, throw_exception_cxx): Update.
4446         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4447         (all_cleanups, do_cleanups, discard_cleanups)
4448         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4449         (restore_cleanups, restore_final_cleanups): Don't declare.
4450         (do_final_cleanups): Remove parameter.
4451         * common/cleanups.c (cleanup_chain, make_cleanup)
4452         (make_cleanup_dtor, all_cleanups, do_cleanups)
4453         (discard_my_cleanups, discard_cleanups)
4454         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4455         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4456         (null_cleanup): Remove.
4457         (do_final_cleanups): Remove parameter.
4458
4459 2019-03-06  Tom Tromey  <tom@tromey.com>
4460
4461         * remote.c (remote_target::remote_parse_stop_reply): Use
4462         unique_xmalloc_ptr.
4463
4464 2019-03-06  Tom Tromey  <tom@tromey.com>
4465
4466         * stabsread.c (struct stabs_field_info): Rename from field_info.
4467         <list, fnlist>: Add initializers.
4468         <obstack>: New member.
4469         (read_member_functions, read_struct_fields, read_baseclasses):
4470         Allocate on obstack.  Don't use cleanups.
4471         (read_one_struct_field, read_member_functions, read_struct_fields)
4472         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4473         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4474         (read_struct_type): Update.
4475
4476 2019-03-06  Tom Tromey  <tom@tromey.com>
4477
4478         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4479         * common/filestuff.h (make_cleanup_close): Don't declare.
4480         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4481         Remove.
4482
4483 2019-03-06  Tom Tromey  <tom@tromey.com>
4484
4485         * solib-aix.c: Use make_scope_exit.
4486
4487 2019-03-06  Tom Tromey  <tom@tromey.com>
4488
4489         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4490         Use make_scope_exit.
4491
4492 2019-03-06  Tom Tromey  <tom@tromey.com>
4493
4494         * solib-svr4.c (disable_probes_interface): Remove parameter.
4495         (svr4_handle_solib_event): Use make_scope_exit.
4496
4497 2019-03-06  Tom Tromey  <tom@tromey.com>
4498
4499         * remote.c (struct stop_reply_deleter): Remove.
4500         (stop_reply_up): Update.
4501         (struct stop_reply): Derive from notif_event.  Don't typedef.
4502         <regcache>: Now a std::vector.
4503         (stop_reply_xfree): Remove.
4504         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4505         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4506         (remote_target::discard_pending_stop_replies): Use delete.
4507         (remote_target::remote_parse_stop_reply): Update.
4508         (remote_target::process_stop_reply): Update.
4509         * remote-notif.h (struct notif_event): Add virtual destructor.
4510         Remove "dtr" member.
4511         (struct notif_client) <alloc_event>: Return a unique_ptr.
4512         (notif_event_xfree): Don't declare.
4513         (notif_event_up): New typedef.
4514         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4515         (notif_event_xfree, do_notif_event_xfree): Remove.
4516         (remote_notif_state_xfree): Update.
4517
4518 2019-03-06  Tom Tromey  <tom@tromey.com>
4519
4520         * infrun.c (displaced_step_clear_cleanup): Now a
4521         forward_scope_exit type.
4522         (displaced_step_prepare_throw): Update.
4523         (displaced_step_fixup): Update.
4524
4525 2019-03-06  Tom Tromey  <tom@tromey.com>
4526
4527         * inferior.h (class inferior): Update comment.
4528         * gdbthread.h (class thread_info): Update comment.
4529
4530 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4531             Tom Tromey  <tom@tromey.com>
4532
4533         * stabsread.h (struct stab_section_list): Remove.
4534         (coffstab_build_psymtabs): Update.
4535         * dbxread.c (symbuf_sections): Now a std::vector.
4536         (sect_idx): New global.
4537         (fill_symbuf): Update.
4538         (coffstab_build_psymtabs): Change type of stabsects parameter.
4539         Update.
4540         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4541         std::vector.
4542         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4543         (coff_locate_sections): Update.
4544         (coff_symfile_read): Remove cleanups.  Update.
4545         (init_stringtab): Add storage parameter.
4546         (free_stringtab, free_stringtab_cleanup): Remove.
4547         (init_lineno): Add storage parameter.
4548         (free_linetab, free_linetab_cleanup): Remove.
4549
4550 2019-03-06  Pedro Alves  <palves@redhat.com>
4551
4552         * linux-fork.c (fork_info::clobber_regs): Delete.
4553         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4554         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4555         comment.  Adjust.
4556         (scoped_switch_fork_info::scoped_switch_fork_info)
4557         (checkpoint_command, linux_fork_context): Adjust
4558         fork_save_infrun_state calls.
4559
4560 2019-03-06  Pedro Alves  <palves@redhat.com>
4561
4562         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4563         (inf_has_multiple_threads): Return 'bool' and rewrite using
4564         inferior_info::threads().
4565
4566 2019-03-06  Pedro Alves  <palves@redhat.com>
4567
4568         * linux-fork.c: Include <list>.
4569         (fork_list): Now a std::list instance.
4570         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4571         (forks_exist_p, find_last_fork): Adjust.
4572         (new_fork): Delete.
4573         (one_fork_p): New.
4574         (add_fork): Adjust.
4575         (free_fork): Delete, folded into fork_info::~fork_info().
4576         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4577         Adjust.
4578         (init_fork_list): Delete.
4579         (linux_fork_killall, linux_fork_mourn_inferior)
4580         (linux_fork_detach, info_checkpoints_command): Adjust.
4581         (_initialize_linux_fork): No longer call init_fork_list.
4582
4583 2019-03-06  Pedro Alves  <palves@redhat.com>
4584
4585         * linux-fork.c (new_fork): New, split out of ...
4586         (add_fork): ... this.  Return void.  Move "first fork" special
4587         case from here, to ...
4588         (checkpoint_command): ... here.
4589         * linux-linux.h (add_fork): Return void.
4590
4591 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4592
4593         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4594
4595 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4596             Chris January  <chris.january@arm.com>
4597             David Lecomber  <david.lecomber@arm.com>
4598
4599         * f-exp.y: New token, UNOP_INTRINSIC.
4600         (exp): New pattern using UNOP_INTRINSIC token.
4601         (f77_keywords): Add 'abs' keyword.
4602         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4603         (value_from_host_double): New function.
4604         (evaluate_subexp_f): Support UNOP_ABS.
4605
4606 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4609         types.
4610
4611 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4614         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4615         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4616
4617 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4620
4621 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4622             Chris January  <chris.january@arm.com>
4623
4624         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4625         * f-exp.y: Define 'KIND' token.
4626         (exp): New pattern for KIND expressions.
4627         (ptype): Handle types with a kind extension.
4628         (direct_abs_decl): Extend to spot kind extensions.
4629         (f77_keywords): Add 'kind' to the list.
4630         (push_kind_type): New function.
4631         (convert_to_kind_type): New function.
4632         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4633         * parse.c (operator_length_standard): Likewise.
4634         * parser-defs.h (enum type_pieces): Add tp_kind.
4635         * std-operator.def: Add UNOP_KIND.
4636
4637 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4638
4639         * f-exp.y (f_parse): Set yydebug.
4640
4641 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * f-lang.c (evaluate_subexp_f): New function.
4644         (exp_descriptor_f): New global.
4645         (f_language_defn): Use exp_descriptor_f instead of
4646         exp_descriptor_standard.
4647
4648 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4649
4650         * f-exp.y (struct token): Add comments.
4651         (dot_ops): Remove uppercase versions and the end marker.
4652         (f77_keywords): Likewise.
4653         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4654         entries in the dot_ops array are case insensitive, and use
4655         strncasecmp to compare strings.  Also some whitespace cleanup in
4656         this area.  Similar for the f77_keywords array, except entries in
4657         this list might be case sensitive.
4658
4659 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * f-exp.y (struct f77_boolean_val): Add comments.
4662         (boolean_values): Remove uppercase versions, and end marker.
4663         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4664         and use strncasecmp to achieve case insensitivity.  Additionally,
4665         perform whitespace cleanup around this code.
4666
4667 2019-03-06  Tom Tromey  <tromey@adacore.com>
4668
4669         * remote-sim.c (gdbsim_target_open): Use result of
4670         gdb_argv::release.
4671
4672 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4673         Dirk Schubert  <dirk.schubert@arm.com>
4674         Chris January  <chris.january@arm.com>
4675
4676         * eval.c (evaluate_subexp_standard): Call Fortran argument
4677         wrapping logic.
4678         * f-lang.c (struct value): A value which can be passed into a
4679         Fortran function call.
4680         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4681         where appropriate.
4682         (struct type): Value ready for a Fortran function call.
4683         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4684         is needed.
4685         * f-lang.h (fortran_argument_convert): Declaration.
4686         (fortran_preserve_arg_pointer): Declaration.
4687         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4688
4689 2019-03-05  Tom Tromey  <tromey@adacore.com>
4690
4691         * python/py-prettyprint.c (print_string_repr): Remove #if.
4692         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4693
4694 2019-03-05  Tom Tromey  <tromey@adacore.com>
4695
4696         * target.c (the_dummy_target): Move later.  Change type to
4697         "dummy_target".
4698         (initialize_targets): Don't initialize the_dummy_target.
4699
4700 2019-03-05  Tom Tromey  <tromey@adacore.com>
4701
4702         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4703         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4704
4705 2019-03-05  Tom Tromey  <tromey@adacore.com>
4706
4707         * windows-nat.c (windows_nat_target::attach)
4708         (windows_nat_target::detach): Don't call gdb_flush.
4709         * valprint.c (generic_val_print, val_print, val_print_string):
4710         Don't call gdb_flush.
4711         * utils.c (defaulted_query): Don't call gdb_flush.
4712         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4713         * target.c (target_announce_detach): Don't call gdb_flush.
4714         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4715         * remote.c (extended_remote_target::attach): Don't call
4716         gdb_flush.
4717         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4718         * printcmd.c (do_examine): Don't call gdb_flush.
4719         (info_display_command): Don't call gdb_flush.
4720         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4721         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4722         * memattr.c (info_mem_command): Don't call gdb_flush.
4723         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4724         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4725         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4726         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4727         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4728         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4729         (gnu_nat_target::detach): Don't call gdb_flush.
4730         * f-valprint.c (f_val_print): Don't call gdb_flush.
4731         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4732         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4733         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4734         gdb_flush.
4735         * c-valprint.c (c_val_print): Don't call gdb_flush.
4736         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4737
4738 2019-03-05  Tom Tromey  <tromey@adacore.com>
4739
4740         * varobj.c (update_dynamic_varobj_children): Update.
4741         (install_default_visualizer): Use reset, not release.
4742         * value.c (set_internalvar): Update.
4743         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4744         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4745         ATTRIBUTE_UNUSED_RESULT.
4746
4747 2019-03-05  Tom Tromey  <tromey@adacore.com>
4748
4749         * remote.c (class scoped_remote_fd) <release>: Add
4750         ATTRIBUTE_UNUSED_RESULT.
4751
4752 2019-03-05  Tom Tromey  <tromey@adacore.com>
4753
4754         * macroexp.c (struct macro_buffer) <release>: Add
4755         ATTRIBUTE_UNUSED_RESULT.
4756
4757 2019-03-05  Tom Tromey  <tromey@adacore.com>
4758
4759         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4760         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4761         ATTRIBUTE_UNUSED_RESULT.
4762
4763 2019-03-05  Tom Tromey  <tromey@adacore.com>
4764
4765         * common/scoped_fd.h (class scoped_fd) <release>: Add
4766         ATTRIBUTE_UNUSED_RESULT.
4767
4768 2019-03-05  Tom Tromey  <tromey@adacore.com>
4769
4770         * parser-defs.h (struct parser_state) <release>: Add
4771         ATTRIBUTE_UNUSED_RESULT.
4772
4773 2019-03-05  Tom Tromey  <tromey@adacore.com>
4774
4775         * utils.h (class gdb_argv) <release>: Add
4776         ATTRIBUTE_UNUSED_RESULT.
4777         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4778
4779 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4780
4781         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4782         for-loop range, to avoid compiler warnings.
4783
4784         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4785         avoid compiler warnings about unused variables.
4786
4787         * NEWS: Mention end of support for native debugging on MS-Windows
4788         before XP.
4789
4790         PR gdb/24292
4791         * common/netstuff.c:
4792         * gdbserver/gdbreplay.c
4793         * gdbserver/remote-utils.c:
4794         * ser-tcp.c:
4795         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4796         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4797         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4798         'getaddrinfo' and 'freeaddrinfo' were not available before
4799         Windows XP, and mingw.org's MinGW headers by default define
4800         _WIN32_WINNT to 0x500.
4801
4802 2019-03-01  Gary Benson <gbenson@redhat.com>
4803
4804         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4805
4806 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4807             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4808
4809         PR gdb/8527
4810         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4811         set_sigint_trap, clear_sigint_trap.
4812
4813 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4814
4815         * target.c (target_detach): Clear the regcache and the
4816         frame cache.
4817
4818 2019-02-27  Pedro Alves  <palves@redhat.com>
4819
4820         * utils.c (set_screen_size): When we cap the height/width sizes,
4821         tweak the corresponding command variable to show "unlimited":
4822
4823 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4824             Pedro Alves  <palves@redhat.com>
4825
4826         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4827         before calling rl_set_screen_size.
4828
4829 2019-02-27  Tom Tromey  <tromey@adacore.com>
4830
4831         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4832         define.
4833         * python/py-value.c: Remove Python 2.4 workaround.
4834         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4835         workaround.
4836         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4837         Python 2.4 workaround.
4838         * python/python-internal.h: Remove Python 2.4 comment.
4839         (Py_ssize_t): Don't define.
4840         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4841         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4842         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4843         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4844         * python/python.c (do_start_initialization): Remove Python 2.4
4845         workaround.
4846         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4847         (print_children): Remove Python 2.4 workaround.
4848         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4849         workaround.
4850         (CHARBUFFERPROC_NAME): Remove.
4851         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4852         Python 2.4 workaround.
4853
4854 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4855
4856         * NEWS: Note minimum Python version.
4857
4858 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4859
4860         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4861         code from these functions.  Remove corresponding ifdefs.  Use
4862         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4863         Remove gotos and target of gotos.
4864         (infpy_search_memory): Likewise.
4865
4866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4867
4868         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4869         (hppa_gdbarch_init): Don't register deleted functions with
4870         gdbarch.
4871
4872 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4873
4874         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4875         (h8300_unwind_sp): Delete.
4876         (h8300_dummy_id): Delete.
4877         (h8300_gdbarch_init): Don't register deleted functions with
4878         gdbarch.
4879
4880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4883         (ft32_unwind_pc): Delete.
4884         (ft32_unwind_sp): Delete.
4885         (ft32_gdbarch_init): Don't register deleted functions with
4886         gdbarch.
4887
4888 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4891         (frv_unwind_pc): Delete.
4892         (frv_unwind_sp): Delete.
4893         (frv_gdbarch_init): Don't register deleted functions with
4894         gdbarch.
4895
4896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4899         (riscv_unwind_pc): Delete.
4900         (riscv_unwind_sp): Delete.
4901         (riscv_gdbarch_init): Don't register deleted functions with
4902         gdbarch.
4903
4904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4907         (csky_unwind_pc): Delete.
4908         (csky_unwind_sp): Delete.
4909         (csky_gdbarch_init): Don't register deleted functions with
4910         gdbarch.
4911
4912 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4913
4914         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4915         (cris_unwind_pc): Delete.
4916         (cris_unwind_sp): Delete.
4917         (cris_gdbarch_init): Don't register deleted functions with
4918         gdbarch.
4919
4920 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4923         (bfin_unwind_pc): Delete.
4924         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4925
4926 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4929         (arm_unwind_pc): Delete.
4930         (arm_unwind_sp): Delete.
4931         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4932
4933 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4934
4935         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4936         (arc_unwind_pc): Delete.
4937         (arc_unwind_sp): Delete.
4938         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4939
4940 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4941
4942         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4943         (alpha_unwind_pc): Delete.
4944         (alpha_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4950         (aarch64_unwind_pc): Delete.
4951         (aarch64_unwind_sp): Delete.
4952         (aarch64_gdbarch_init): Don't register deleted functions with
4953         gdbarch.
4954
4955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * gdbtypes.c (type_align): Don't consider static members when
4958         computing structure alignment.
4959
4960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4963         return 0 for other types.
4964         * arch-utils.c (default_type_align): Always return 0.
4965         * gdbarch.h: Regenerate.
4966         * gdbarch.sh (type_align): Extend comment.
4967         * gdbtypes.c (type_align): Add additional comments, always call
4968         gdbarch_type_align before applying the default rules.
4969         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4970         generic code will then apply a suitable default.
4971         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4972         types, return 0 for other types.
4973
4974 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4975
4976         * NEWS: Create a new section for the next release branch.
4977         Rename the section of the current branch, now that it has
4978         been cut.
4979
4980 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4981
4982         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4983         * version.in: Bump version to 8.3.50.DATE-git.
4984
4985 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4986
4987         * aix-thread.c (ptid_cmp): Remove unused variable.
4988         (get_signaled_thread): Likewise.
4989         (store_regs_user_thread): Likewise.
4990         (store_regs_kernel_thread): Likewise.
4991         (fetch_regs_kernel_thread): Remove shadowed variable.
4992
4993 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4994
4995         * features/riscv/32bit-cpu.xml: Add register numbers.
4996         * features/riscv/32bit-fpu.c: Regenerate.
4997         * features/riscv/32bit-fpu.xml: Add register numbers.
4998         * features/riscv/64bit-cpu.xml: Add register numbers.
4999         * features/riscv/64bit-fpu.c: Regenerate.
5000         * features/riscv/64bit-fpu.xml: Add register numbers.
5001
5002 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5003
5004         * NEWS: Mention two argument form of gdb.Value constructor.
5005         * python/py-value.c (convert_buffer_and_type_to_value): New
5006         function.
5007         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5008         Add support for handling an optional second argument.  Call
5009         convert_buffer_and_type_to_value as appropriate.
5010         * python/python-internal.h (Py_buffer_deleter): New struct.
5011         (Py_buffer_up): New typedef.
5012
5013 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5014
5015         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5016         instead of releasing ownership.
5017
5018 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5019
5020         * dwarf2read.c (open_and_init_dwp_file): Call
5021         elf_numsections instead of bfd_count_sections to initialize
5022         dwp_file->num_sections.
5023
5024 2019-02-25  Tom Tromey  <tromey@adacore.com>
5025
5026         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5027
5028 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5029
5030         * gcore.in: Add '--readnever' option when invoking GDB.
5031
5032 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5033
5034         * MAINTAINERS: Update my email address.
5035
5036 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5037
5038         * build-id.c (build_id_to_debug_bfd_1): New function.
5039         (build_id_to_debug_bfd): Look for separate debug file in
5040         sysroot.
5041
5042 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5043
5044         * gdbarch.sh: Update the copyright year range that is placed into
5045         generated files.
5046
5047 2019-02-22  Keith Seitz  <keiths@redhat.com>
5048
5049         PR symtab/23853
5050         * linespec.c (create_sals_line_offset): Search for the default
5051         symtab's filename instead of its fullname.
5052
5053 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5054
5055         * NEWS: Update style defaults.
5056
5057 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5058
5059         * main.c (captured_main_1): Disable styling in batch mode.
5060
5061 2019-02-20  Tom Tromey  <tom@tromey.com>
5062
5063         * symtab.c (symtab_symbol_info): Fix typos.
5064
5065 2019-02-20  Tom Tromey  <tromey@adacore.com>
5066
5067         * findcmd.c (_initialize_mem_search): Use upper case for
5068         metasyntactic variables.
5069
5070 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5071
5072         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5073         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5074
5075 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5076
5077         * top.h (source_file_name): Change to std::string.
5078         * top.c (source_file_name): Likewise.
5079         (command_line_input): Adjust.
5080         * cli/cli-script.c (script_from_file): Adjust.
5081
5082 2019-02-19  Tom Tromey  <tromey@adacore.com>
5083
5084         * ravenscar-thread.c
5085         (ravenscar_thread_target::update_thread_list): Don't call
5086         ada_build_task_list.
5087         * ada-lang.h (ada_build_task_list): Don't declare.
5088         * ada-tasks.c (struct ada_tasks_inferior_data)
5089         <task_list_valid_p>: Now bool.
5090         (read_known_tasks, ada_task_list_changed)
5091         (ada_tasks_invalidate_inferior_data): Update.
5092         (read_known_tasks_array): Return bool.
5093         (read_known_tasks_list): Likewise.
5094         (read_known_tasks): Return void.
5095         (ada_build_task_list): Now static.
5096
5097 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5100         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5101
5102 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5103
5104         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5105         variant for ada_tasks_pspace_data_handle and
5106         ada_tasks_inferior_data_handle.
5107         (ada_tasks_pspace_data_cleanup): New function.
5108         (ada_tasks_inferior_data_cleanup): New function.
5109
5110 2019-02-17  Tom Tromey  <tom@tromey.com>
5111
5112         * macrotab.h (macro_source_fullname): Return a std::string.
5113         * macrotab.c (macro_include, check_for_redefinition)
5114         (macro_undef, macro_lookup_definition, foreach_macro)
5115         (foreach_macro_in_scope): Update.
5116         (macro_source_fullname): Return a std::string.
5117         * macrocmd.c (show_pp_source_pos): Update.
5118
5119 2019-02-17  Tom Tromey  <tom@tromey.com>
5120
5121         * macrocmd.c (show_pp_source_pos): Style the file names.
5122
5123 2019-02-17  Tom Tromey  <tom@tromey.com>
5124
5125         PR tui/24197:
5126         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5127
5128 2019-02-17  Tom Tromey  <tom@tromey.com>
5129
5130         * ada-lang.c (user_select_syms): Use filtered printing.
5131         * utils.c (wrap_style): New global.
5132         (desired_style): Remove.
5133         (emit_style_escape): Add stream parameter.
5134         (set_output_style, reset_terminal_style, prompt_for_continue):
5135         Update.
5136         (flush_wrap_buffer): Only flush gdb_stdout.
5137         (wrap_here): Set wrap_style.
5138         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5139         treat escape sequences as a character.  Change when wrap buffer is
5140         flushed.
5141         (fputs_styled): Do not set the output style when the default is
5142         requested.
5143         * ui-style.h (struct ui_file_style) <is_default>: New method.
5144         * source.c (print_source_lines_base): Emit escape sequences in one
5145         piece.
5146
5147 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5148
5149         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5150         integers and enumeration types.
5151
5152 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5153
5154         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5155         instead of lookup_symbol_in_language
5156         (do_exact_match): New function.
5157         (ada_get_symbol_name_matcher): Return do_exact_match when
5158         doing a verbatim match.
5159
5160 2019-02-15  Tom Tromey  <tromey@adacore.com>
5161
5162         * ravenscar-thread.c (ravenscar_thread_target::resume)
5163         (ravenscar_thread_target::wait): Special case wildcard requests.
5164
5165 2019-02-15  Tom Tromey  <tromey@adacore.com>
5166
5167         * ravenscar-thread.c (base_ptid): Remove.
5168         (struct ravenscar_thread_target) <close>: New method.
5169         <m_base_ptid>: New member.
5170         <update_inferior_ptid, active_task, task_is_currently_active,
5171         runtime_initialized>: Declare methods.
5172         <ravenscar_thread_target>: Add constructor.
5173         (ravenscar_thread_target::task_is_currently_active)
5174         (ravenscar_thread_target::update_inferior_ptid)
5175         (ravenscar_runtime_initialized): Rename.  Now methods.
5176         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5177         (ravenscar_thread_target::update_thread_list): Update.
5178         (ravenscar_thread_target::active_task): Now method.
5179         (ravenscar_thread_target::store_registers)
5180         (ravenscar_thread_target::prepare_to_store)
5181         (ravenscar_thread_target::prepare_to_store)
5182         (ravenscar_thread_target::mourn_inferior): Update.
5183         (ravenscar_inferior_created): Use "new" to create target.
5184         (ravenscar_thread_target::get_ada_task_ptid): Update.
5185         (_initialize_ravenscar): Don't initialize base_ptid.
5186         (ravenscar_ops): Remove global.
5187
5188 2019-02-15  Tom Tromey  <tromey@adacore.com>
5189
5190         * target.h (push_target): Declare new overload.
5191         * target.c (push_target): New overload, taking an rvalue reference.
5192         * remote.c (remote_target::open_1): Use push_target overload.
5193         * corelow.c (core_target_open): Use push_target overload.
5194
5195 2019-02-15  Tom Tromey  <tromey@adacore.com>
5196
5197         * ravenscar-thread.c (is_ravenscar_task)
5198         (ravenscar_task_is_currently_active): Return bool.
5199         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5200         (_initialize_ravenscar): Remove "(void)".
5201         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5202         Return bool.
5203
5204 2019-02-15  Tom Tromey  <tromey@adacore.com>
5205
5206         * ravenscar-thread.c (ravenscar_runtime_initializer)
5207         (has_ravenscar_runtime, get_running_thread_id)
5208         (ravenscar_thread_target::resume): Fix indentation.
5209
5210 2019-02-15  Tom Tromey  <tromey@adacore.com>
5211
5212         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5213         from ravenscar_arch_ops.
5214         (sparc_ravenscar_ops::fetch_registers)
5215         (sparc_ravenscar_ops::store_registers): Now methods.
5216         (sparc_ravenscar_prepare_to_store): Remove.
5217         (sparc_ravenscar_ops): Redefine.
5218         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5219         methods and destructor.  Remove members.
5220         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5221         (ravenscar_thread_target::store_registers)
5222         (ravenscar_thread_target::prepare_to_store): Update.
5223         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5224         Remove.
5225         (struct ppc_ravenscar_powerpc_ops): Derive from
5226         ravenscar_arch_ops.
5227         (ppc_ravenscar_powerpc_ops::fetch_registers)
5228         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5229         (ppc_ravenscar_powerpc_ops): Redefine.
5230         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5231         (ppc_ravenscar_e500_ops::fetch_registers)
5232         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5233         (ppc_ravenscar_e500_ops): Redefine.
5234         * aarch64-ravenscar-thread.c
5235         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5236         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5237         (aarch64_ravenscar_fetch_registers)
5238         (aarch64_ravenscar_store_registers): Now methods.
5239         (aarch64_ravenscar_ops): Redefine.
5240
5241 2019-02-15  Tom Tromey  <tromey@adacore.com>
5242
5243         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5244         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5245         (ravenscar_thread_target::stopped_by_watchpoint)
5246         (ravenscar_thread_target::stopped_data_address)
5247         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5248
5249 2019-02-15  Tom Tromey  <tromey@adacore.com>
5250
5251         * ravenscar-thread.c: Fix some typos.
5252
5253 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5254             Tom Tromey  <tromey@adacore.com>
5255
5256         * ada-lang.c (ada_exception_sal): Change addr_string to a
5257         std::string.
5258         (create_ada_exception_catchpoint): Update.
5259
5260 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5261             Tom Tromey  <tromey@adacore.com>
5262
5263         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5264         (bp_location_ops): Remove.
5265         (base_breakpoint_allocate_location): Update.
5266         (free_bp_location): Update.
5267         * ada-lang.c (class ada_catchpoint_location)
5268         <ada_catchpoint_location>: Remove ops parameter.
5269         (ada_catchpoint_location_dtor): Remove.
5270         (ada_catchpoint_location_ops): Remove.
5271         (allocate_location_exception): Update.
5272         * breakpoint.h (struct bp_location_ops): Remove.
5273         (class bp_location) <bp_location>: Remove bp_location_ops
5274         parameter.
5275         <~bp_location>: Add destructor.
5276         <ops>: Remove.
5277
5278 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5279             Pedro Alves  <palves@redhat.com>
5280
5281         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5282         'PATH_MAX'.
5283
5284 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5285             Samuel Thibault  <samuel.thibault@gnu.org>
5286             Thomas Schwinge  <thomas@codesourcery.com>
5287
5288         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5289         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5290
5291 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5292
5293         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5294         (check_empty): Use "const char *".
5295
5296         * gnu-nat.c (gnu_nat_target::detach): Instead of
5297         'detach_inferior (pid)' call
5298         'detach_inferior (find_inferior_pid (pid))'.
5299
5300         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5301         'nat/fork-inferior.o'.
5302         * gnu-nat.c: #include "nat/fork-inferior.h".
5303
5304         * gnu-nat.c (gnu_nat_target::detach): Instead of
5305         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5306         * gnu-nat.h: #include "inf-child.h".
5307         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5308         'i386_gnu_nat_target::fetch_registers'.
5309         (gnu_store_registers): Rename/move to
5310         'i386_gnu_nat_target::store_registers'.
5311
5312         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5313         * gnu-nat.h (mach_thread_info): New function.
5314         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5315
5316         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5317
5318 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5319
5320         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5321
5322 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5323
5324         * windows-nat.c (windows_add_thread): Add new parameter
5325         "main_thread_p" with default value set to false.  Update
5326         function documentation as well as all callers.
5327         (windows_delete_thread): Likewise.
5328         (fake_create_process): Update call to windows_add_thread.
5329         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5330         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5331         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5332         call to windows_delete_thread.
5333
5334 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5335
5336         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5337
5338 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5339
5340         * symfile.c (find_separate_debug_file): Use canonical path of
5341         sysroot with child_path instead of gdb_sysroot if it is valid.
5342
5343 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5344
5345         * symfile.c (find_separate_debug_file): Use child_path to
5346         determine if an object file is under a sysroot.
5347
5348 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5349
5350         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5351         unittests/child-path-selftests.c.
5352         * common/pathstuff.c (child_path): New function.
5353         * common/pathstuff.h (child_path): New prototype.
5354         * unittests/child-path-selftests.c: New file.
5355
5356 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5357
5358         * symfile.c (find_separate_debug_file): Look for separate debug
5359         files in debug directories under the sysroot.
5360
5361 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5362
5363         * symtab.h (struct minimal_symbol data_p): New const method.
5364         (struct minimal_symbol text_p): Likewise.
5365         * symtab.c (output_source_filename): Use file name style
5366         to print file name.
5367         (print_symbol_info): Likewise.
5368         (print_msymbol_info): Use address style to print addresses.
5369         Use function name style to print executable text symbols.
5370         (expand_symtab_containing_pc): Use data_p.
5371         (find_pc_sect_compunit_symtab): Likewise.
5372
5373 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5374
5375         * breakpoint.c (describe_other_breakpoints): Use address style
5376         to print addresses.
5377         (say_where): Likewise.
5378
5379 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5380
5381         * ada-typeprint.c (print_func_type): Print function name
5382         style to print function name.
5383         * c-typeprint.c (c_print_type_1): Likewise.
5384
5385 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5386
5387         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5388         for execve.
5389
5390 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5391
5392         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5393         type_stack.
5394
5395 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5396
5397         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5398         TYPE_CODE_REF types.
5399
5400 2019-02-08  Jim Wilson  <jimw@sifive.com>
5401
5402         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5403         (riscv_linux_fregset): New.
5404         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5405
5406 2019-02-07  Tom Tromey  <tom@tromey.com>
5407
5408         * thread.c (thread_cancel_execution_command): Update.
5409         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5410         methods.
5411         (struct thread_fsm_ops): Remove.
5412         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5413         (thread_fsm_should_stop, thread_fsm_return_value)
5414         (thread_fsm_set_finished, thread_fsm_finished_p)
5415         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5416         Don't declare.
5417         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5418         * infrun.c (clear_proceed_status_thread)
5419         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5420         (print_stop_event): Update.
5421         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5422         Add constructor.
5423         (step_command_fsm_ops): Remove.
5424         (new_step_command_fsm): Remove.
5425         (step_1): Update.
5426         (step_command_fsm::should_stop): Rename from
5427         step_command_fsm_should_stop.
5428         (step_command_fsm::clean_up): Rename from
5429         step_command_fsm_clean_up.
5430         (step_command_fsm::do_async_reply_reason): Rename from
5431         step_command_fsm_async_reply_reason.
5432         (struct until_next_fsm): Inherit from thread_fsm.  Add
5433         constructor.
5434         (until_next_fsm_ops): Remove.
5435         (new_until_next_fsm): Remove.
5436         (until_next_fsm::should_stop): Rename from
5437         until_next_fsm_should_stop.
5438         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5439         (until_next_fsm::do_async_reply_reason): Rename from
5440         until_next_fsm_async_reply_reason.
5441         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5442         constructor.  Change type of breakpoint.
5443         (finish_command_fsm_ops): Remove.
5444         (new_finish_command_fsm): Remove.
5445         (finish_command_fsm::should_stop): Rename from
5446         finish_command_fsm_should_stop.
5447         (finish_command_fsm::clean_up): Rename from
5448         finish_command_fsm_clean_up.
5449         (finish_command_fsm::return_value): Rename from
5450         finish_command_fsm_return_value.
5451         (finish_command_fsm::do_async_reply_reason): Rename from
5452         finish_command_fsm_async_reply_reason.
5453         (finish_command): Update.
5454         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5455         Add constructor.
5456         (call_thread_fsm_ops): Remove.
5457         (call_thread_fsm::call_thread_fsm): Rename from
5458         new_call_thread_fsm.
5459         (call_thread_fsm::should_stop): Rename from
5460         call_thread_fsm_should_stop.
5461         (call_thread_fsm::should_notify_stop): Rename from
5462         call_thread_fsm_should_notify_stop.
5463         (run_inferior_call, call_function_by_hand_dummy): Update.
5464         * cli/cli-interp.c (should_print_stop_to_console): Update.
5465         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5466         Add constructor.  Change type of location_breakpoint,
5467         caller_breakpoint.
5468         (until_break_fsm_ops): Remove.
5469         (new_until_break_fsm): Remove.
5470         (until_break_fsm::should_stop): Rename from
5471         until_break_fsm_should_stop.
5472         (until_break_fsm::clean_up): Rename from
5473         until_break_fsm_clean_up.
5474         (until_break_fsm::do_async_reply_reason): Rename from
5475         until_break_fsm_async_reply_reason.
5476         (until_break_command): Update.
5477         * thread-fsm.c: Remove.
5478         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5479
5480 2019-02-07  Tom Tromey  <tom@tromey.com>
5481
5482         * yy-remap.h: Add include guard.
5483         * xtensa-tdep.h: Add include guard.
5484         * xcoffread.h: Rename include guard.
5485         * varobj-iter.h: Add include guard.
5486         * tui/tui.h: Rename include guard.
5487         * tui/tui-winsource.h: Rename include guard.
5488         * tui/tui-wingeneral.h: Rename include guard.
5489         * tui/tui-windata.h: Rename include guard.
5490         * tui/tui-win.h: Rename include guard.
5491         * tui/tui-stack.h: Rename include guard.
5492         * tui/tui-source.h: Rename include guard.
5493         * tui/tui-regs.h: Rename include guard.
5494         * tui/tui-out.h: Rename include guard.
5495         * tui/tui-layout.h: Rename include guard.
5496         * tui/tui-io.h: Rename include guard.
5497         * tui/tui-hooks.h: Rename include guard.
5498         * tui/tui-file.h: Rename include guard.
5499         * tui/tui-disasm.h: Rename include guard.
5500         * tui/tui-data.h: Rename include guard.
5501         * tui/tui-command.h: Rename include guard.
5502         * tic6x-tdep.h: Add include guard.
5503         * target/waitstatus.h: Rename include guard.
5504         * target/wait.h: Rename include guard.
5505         * target/target.h: Rename include guard.
5506         * target/resume.h: Rename include guard.
5507         * target-float.h: Rename include guard.
5508         * stabsread.h: Add include guard.
5509         * rs6000-tdep.h: Add include guard.
5510         * riscv-fbsd-tdep.h: Add include guard.
5511         * regformats/regdef.h: Rename include guard.
5512         * record.h: Rename include guard.
5513         * python/python.h: Rename include guard.
5514         * python/python-internal.h: Rename include guard.
5515         * python/py-stopevent.h: Rename include guard.
5516         * python/py-ref.h: Rename include guard.
5517         * python/py-record.h: Rename include guard.
5518         * python/py-record-full.h: Rename include guard.
5519         * python/py-record-btrace.h: Rename include guard.
5520         * python/py-instruction.h: Rename include guard.
5521         * python/py-events.h: Rename include guard.
5522         * python/py-event.h: Rename include guard.
5523         * procfs.h: Add include guard.
5524         * proc-utils.h: Add include guard.
5525         * p-lang.h: Add include guard.
5526         * or1k-tdep.h: Rename include guard.
5527         * observable.h: Rename include guard.
5528         * nto-tdep.h: Rename include guard.
5529         * nat/x86-linux.h: Rename include guard.
5530         * nat/x86-linux-dregs.h: Rename include guard.
5531         * nat/x86-gcc-cpuid.h: Add include guard.
5532         * nat/x86-dregs.h: Rename include guard.
5533         * nat/x86-cpuid.h: Rename include guard.
5534         * nat/ppc-linux.h: Rename include guard.
5535         * nat/mips-linux-watch.h: Rename include guard.
5536         * nat/linux-waitpid.h: Rename include guard.
5537         * nat/linux-ptrace.h: Rename include guard.
5538         * nat/linux-procfs.h: Rename include guard.
5539         * nat/linux-osdata.h: Rename include guard.
5540         * nat/linux-nat.h: Rename include guard.
5541         * nat/linux-namespaces.h: Rename include guard.
5542         * nat/linux-btrace.h: Rename include guard.
5543         * nat/glibc_thread_db.h: Rename include guard.
5544         * nat/gdb_thread_db.h: Rename include guard.
5545         * nat/gdb_ptrace.h: Rename include guard.
5546         * nat/fork-inferior.h: Rename include guard.
5547         * nat/amd64-linux-siginfo.h: Rename include guard.
5548         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5549         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5550         * nat/aarch64-linux.h: Rename include guard.
5551         * nat/aarch64-linux-hw-point.h: Rename include guard.
5552         * mn10300-tdep.h: Add include guard.
5553         * mips-linux-tdep.h: Add include guard.
5554         * mi/mi-parse.h: Rename include guard.
5555         * mi/mi-out.h: Rename include guard.
5556         * mi/mi-main.h: Rename include guard.
5557         * mi/mi-interp.h: Rename include guard.
5558         * mi/mi-getopt.h: Rename include guard.
5559         * mi/mi-console.h: Rename include guard.
5560         * mi/mi-common.h: Rename include guard.
5561         * mi/mi-cmds.h: Rename include guard.
5562         * mi/mi-cmd-break.h: Rename include guard.
5563         * m2-lang.h: Add include guard.
5564         * location.h: Rename include guard.
5565         * linux-record.h: Rename include guard.
5566         * linux-nat.h: Add include guard.
5567         * linux-fork.h: Add include guard.
5568         * i386-darwin-tdep.h: Rename include guard.
5569         * hppa-linux-offsets.h: Add include guard.
5570         * guile/guile.h: Rename include guard.
5571         * guile/guile-internal.h: Rename include guard.
5572         * gnu-nat.h: Rename include guard.
5573         * gdb-stabs.h: Rename include guard.
5574         * frv-tdep.h: Add include guard.
5575         * f-lang.h: Add include guard.
5576         * event-loop.h: Add include guard.
5577         * darwin-nat.h: Rename include guard.
5578         * cp-abi.h: Rename include guard.
5579         * config/sparc/nm-sol2.h: Rename include guard.
5580         * config/nm-nto.h: Rename include guard.
5581         * config/nm-linux.h: Add include guard.
5582         * config/i386/nm-i386gnu.h: Rename include guard.
5583         * config/djgpp/nl_types.h: Rename include guard.
5584         * config/djgpp/langinfo.h: Rename include guard.
5585         * compile/gcc-cp-plugin.h: Add include guard.
5586         * compile/gcc-c-plugin.h: Add include guard.
5587         * compile/compile.h: Rename include guard.
5588         * compile/compile-object-run.h: Rename include guard.
5589         * compile/compile-object-load.h: Rename include guard.
5590         * compile/compile-internal.h: Rename include guard.
5591         * compile/compile-cplus.h: Rename include guard.
5592         * compile/compile-c.h: Rename include guard.
5593         * common/xml-utils.h: Rename include guard.
5594         * common/x86-xstate.h: Rename include guard.
5595         * common/version.h: Rename include guard.
5596         * common/vec.h: Rename include guard.
5597         * common/tdesc.h: Rename include guard.
5598         * common/selftest.h: Rename include guard.
5599         * common/scoped_restore.h: Rename include guard.
5600         * common/scoped_mmap.h: Rename include guard.
5601         * common/scoped_fd.h: Rename include guard.
5602         * common/safe-iterator.h: Rename include guard.
5603         * common/run-time-clock.h: Rename include guard.
5604         * common/refcounted-object.h: Rename include guard.
5605         * common/queue.h: Rename include guard.
5606         * common/ptid.h: Rename include guard.
5607         * common/print-utils.h: Rename include guard.
5608         * common/preprocessor.h: Rename include guard.
5609         * common/pathstuff.h: Rename include guard.
5610         * common/observable.h: Rename include guard.
5611         * common/netstuff.h: Rename include guard.
5612         * common/job-control.h: Rename include guard.
5613         * common/host-defs.h: Rename include guard.
5614         * common/gdb_wait.h: Rename include guard.
5615         * common/gdb_vecs.h: Rename include guard.
5616         * common/gdb_unlinker.h: Rename include guard.
5617         * common/gdb_unique_ptr.h: Rename include guard.
5618         * common/gdb_tilde_expand.h: Rename include guard.
5619         * common/gdb_sys_time.h: Rename include guard.
5620         * common/gdb_string_view.h: Rename include guard.
5621         * common/gdb_splay_tree.h: Rename include guard.
5622         * common/gdb_setjmp.h: Rename include guard.
5623         * common/gdb_ref_ptr.h: Rename include guard.
5624         * common/gdb_optional.h: Rename include guard.
5625         * common/gdb_locale.h: Rename include guard.
5626         * common/gdb_assert.h: Rename include guard.
5627         * common/filtered-iterator.h: Rename include guard.
5628         * common/filestuff.h: Rename include guard.
5629         * common/fileio.h: Rename include guard.
5630         * common/environ.h: Rename include guard.
5631         * common/common-utils.h: Rename include guard.
5632         * common/common-types.h: Rename include guard.
5633         * common/common-regcache.h: Rename include guard.
5634         * common/common-inferior.h: Rename include guard.
5635         * common/common-gdbthread.h: Rename include guard.
5636         * common/common-exceptions.h: Rename include guard.
5637         * common/common-defs.h: Rename include guard.
5638         * common/common-debug.h: Rename include guard.
5639         * common/cleanups.h: Rename include guard.
5640         * common/buffer.h: Rename include guard.
5641         * common/btrace-common.h: Rename include guard.
5642         * common/break-common.h: Rename include guard.
5643         * cli/cli-utils.h: Rename include guard.
5644         * cli/cli-style.h: Rename include guard.
5645         * cli/cli-setshow.h: Rename include guard.
5646         * cli/cli-script.h: Rename include guard.
5647         * cli/cli-interp.h: Rename include guard.
5648         * cli/cli-decode.h: Rename include guard.
5649         * cli/cli-cmds.h: Rename include guard.
5650         * charset-list.h: Add include guard.
5651         * buildsym-legacy.h: Rename include guard.
5652         * bfin-tdep.h: Add include guard.
5653         * ax.h: Rename include guard.
5654         * arm-linux-tdep.h: Add include guard.
5655         * arm-fbsd-tdep.h: Add include guard.
5656         * arch/xtensa.h: Rename include guard.
5657         * arch/tic6x.h: Add include guard.
5658         * arch/i386.h: Add include guard.
5659         * arch/arm.h: Rename include guard.
5660         * arch/arm-linux.h: Rename include guard.
5661         * arch/arm-get-next-pcs.h: Rename include guard.
5662         * arch/amd64.h: Add include guard.
5663         * arch/aarch64-insn.h: Rename include guard.
5664         * arch-utils.h: Rename include guard.
5665         * annotate.h: Add include guard.
5666         * amd64-darwin-tdep.h: Rename include guard.
5667         * aarch64-linux-tdep.h: Add include guard.
5668         * aarch64-fbsd-tdep.h: Add include guard.
5669         * aarch32-linux-nat.h: Add include guard.
5670
5671 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5672
5673         * macrotab.c (macro_define_internal): New function that
5674         factorizes macro_define_object_internal and macro_define_function
5675         code.
5676         (macro_define_object_internal): Use macro_define_internal.
5677         (macro_define_function): Likewise.
5678
5679 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5680
5681         * macrocmd.c (extract_identifier): Return
5682         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5683         callers.
5684
5685 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5686
5687         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5688
5689 2019-02-05  Tom Tromey  <tom@tromey.com>
5690
5691         * target.c (target_stack::unpush): Move assertion earlier.
5692
5693 2019-01-30  Tom Tromey  <tom@tromey.com>
5694
5695         PR python/23615:
5696         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5697         (gdbpy_parse_and_eval): Likewise.
5698         * python/python-internal.h (gdbpy_allow_threads): New class.
5699
5700 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5701
5702         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5703         (aarch64_fbsd_fpregmap): Move earlier.
5704         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5705         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5706         instead of individual calls to trad_frame_set_reg_addr.
5707         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5708         earlier.
5709         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5710         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5711         instead of individual calls to trad_frame_set_reg_addr.
5712
5713 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5714
5715         * CONTRIBUTE: Replace contribution list with wiki link.
5716
5717 2019-01-25  Tom Tromey  <tom@tromey.com>
5718
5719         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5720
5721 2019-01-25  Tom Tromey  <tom@tromey.com>
5722
5723         * xtensa-linux-nat.c: Fix common/ includes.
5724         * xml-support.h: Fix common/ includes.
5725         * xml-support.c: Fix common/ includes.
5726         * x86-linux-nat.c: Fix common/ includes.
5727         * windows-nat.c: Fix common/ includes.
5728         * varobj.h: Fix common/ includes.
5729         * varobj.c: Fix common/ includes.
5730         * value.c: Fix common/ includes.
5731         * valops.c: Fix common/ includes.
5732         * utils.c: Fix common/ includes.
5733         * unittests/xml-utils-selftests.c: Fix common/ includes.
5734         * unittests/utils-selftests.c: Fix common/ includes.
5735         * unittests/unpack-selftests.c: Fix common/ includes.
5736         * unittests/tracepoint-selftests.c: Fix common/ includes.
5737         * unittests/style-selftests.c: Fix common/ includes.
5738         * unittests/string_view-selftests.c: Fix common/ includes.
5739         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5740         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5741         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5742         * unittests/rsp-low-selftests.c: Fix common/ includes.
5743         * unittests/parse-connection-spec-selftests.c: Fix common/
5744         includes.
5745         * unittests/optional-selftests.c: Fix common/ includes.
5746         * unittests/offset-type-selftests.c: Fix common/ includes.
5747         * unittests/observable-selftests.c: Fix common/ includes.
5748         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5749         * unittests/memrange-selftests.c: Fix common/ includes.
5750         * unittests/memory-map-selftests.c: Fix common/ includes.
5751         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5752         * unittests/function-view-selftests.c: Fix common/ includes.
5753         * unittests/environ-selftests.c: Fix common/ includes.
5754         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5755         * unittests/common-utils-selftests.c: Fix common/ includes.
5756         * unittests/cli-utils-selftests.c: Fix common/ includes.
5757         * unittests/array-view-selftests.c: Fix common/ includes.
5758         * ui-file.c: Fix common/ includes.
5759         * tui/tui-io.c: Fix common/ includes.
5760         * tracepoint.h: Fix common/ includes.
5761         * tracepoint.c: Fix common/ includes.
5762         * tracefile-tfile.c: Fix common/ includes.
5763         * top.h: Fix common/ includes.
5764         * top.c: Fix common/ includes.
5765         * thread.c: Fix common/ includes.
5766         * target/waitstatus.h: Fix common/ includes.
5767         * target/waitstatus.c: Fix common/ includes.
5768         * target.h: Fix common/ includes.
5769         * target.c: Fix common/ includes.
5770         * target-memory.c: Fix common/ includes.
5771         * target-descriptions.c: Fix common/ includes.
5772         * symtab.h: Fix common/ includes.
5773         * symfile.c: Fix common/ includes.
5774         * stap-probe.c: Fix common/ includes.
5775         * spu-linux-nat.c: Fix common/ includes.
5776         * sparc-nat.c: Fix common/ includes.
5777         * source.c: Fix common/ includes.
5778         * solib.c: Fix common/ includes.
5779         * solib-target.c: Fix common/ includes.
5780         * ser-unix.c: Fix common/ includes.
5781         * ser-tcp.c: Fix common/ includes.
5782         * ser-pipe.c: Fix common/ includes.
5783         * ser-base.c: Fix common/ includes.
5784         * selftest-arch.c: Fix common/ includes.
5785         * s12z-tdep.c: Fix common/ includes.
5786         * rust-exp.y: Fix common/ includes.
5787         * rs6000-aix-tdep.c: Fix common/ includes.
5788         * riscv-tdep.c: Fix common/ includes.
5789         * remote.c: Fix common/ includes.
5790         * remote-notif.h: Fix common/ includes.
5791         * remote-fileio.h: Fix common/ includes.
5792         * remote-fileio.c: Fix common/ includes.
5793         * regcache.h: Fix common/ includes.
5794         * regcache.c: Fix common/ includes.
5795         * record-btrace.c: Fix common/ includes.
5796         * python/python.c: Fix common/ includes.
5797         * python/py-type.c: Fix common/ includes.
5798         * python/py-inferior.c: Fix common/ includes.
5799         * progspace.h: Fix common/ includes.
5800         * producer.c: Fix common/ includes.
5801         * procfs.c: Fix common/ includes.
5802         * proc-api.c: Fix common/ includes.
5803         * printcmd.c: Fix common/ includes.
5804         * ppc-linux-nat.c: Fix common/ includes.
5805         * parser-defs.h: Fix common/ includes.
5806         * osdata.c: Fix common/ includes.
5807         * obsd-nat.c: Fix common/ includes.
5808         * nat/x86-linux.c: Fix common/ includes.
5809         * nat/x86-linux-dregs.c: Fix common/ includes.
5810         * nat/x86-dregs.h: Fix common/ includes.
5811         * nat/x86-dregs.c: Fix common/ includes.
5812         * nat/ppc-linux.c: Fix common/ includes.
5813         * nat/mips-linux-watch.h: Fix common/ includes.
5814         * nat/mips-linux-watch.c: Fix common/ includes.
5815         * nat/linux-waitpid.c: Fix common/ includes.
5816         * nat/linux-ptrace.h: Fix common/ includes.
5817         * nat/linux-ptrace.c: Fix common/ includes.
5818         * nat/linux-procfs.c: Fix common/ includes.
5819         * nat/linux-personality.c: Fix common/ includes.
5820         * nat/linux-osdata.c: Fix common/ includes.
5821         * nat/linux-namespaces.c: Fix common/ includes.
5822         * nat/linux-btrace.h: Fix common/ includes.
5823         * nat/linux-btrace.c: Fix common/ includes.
5824         * nat/fork-inferior.c: Fix common/ includes.
5825         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5826         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5827         * nat/aarch64-linux.c: Fix common/ includes.
5828         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5829         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5830         * namespace.h: Fix common/ includes.
5831         * mips-linux-tdep.c: Fix common/ includes.
5832         * minsyms.c: Fix common/ includes.
5833         * mi/mi-parse.h: Fix common/ includes.
5834         * mi/mi-main.c: Fix common/ includes.
5835         * mi/mi-cmd-env.c: Fix common/ includes.
5836         * memrange.h: Fix common/ includes.
5837         * memattr.c: Fix common/ includes.
5838         * maint.h: Fix common/ includes.
5839         * maint.c: Fix common/ includes.
5840         * main.c: Fix common/ includes.
5841         * machoread.c: Fix common/ includes.
5842         * location.c: Fix common/ includes.
5843         * linux-thread-db.c: Fix common/ includes.
5844         * linux-nat.c: Fix common/ includes.
5845         * linux-fork.c: Fix common/ includes.
5846         * inline-frame.c: Fix common/ includes.
5847         * infrun.c: Fix common/ includes.
5848         * inflow.c: Fix common/ includes.
5849         * inferior.h: Fix common/ includes.
5850         * inferior.c: Fix common/ includes.
5851         * infcmd.c: Fix common/ includes.
5852         * inf-ptrace.c: Fix common/ includes.
5853         * inf-child.c: Fix common/ includes.
5854         * ia64-linux-nat.c: Fix common/ includes.
5855         * i387-tdep.c: Fix common/ includes.
5856         * i386-tdep.c: Fix common/ includes.
5857         * i386-linux-tdep.c: Fix common/ includes.
5858         * i386-linux-nat.c: Fix common/ includes.
5859         * i386-go32-tdep.c: Fix common/ includes.
5860         * i386-fbsd-tdep.c: Fix common/ includes.
5861         * i386-fbsd-nat.c: Fix common/ includes.
5862         * guile/scm-type.c: Fix common/ includes.
5863         * guile/guile.c: Fix common/ includes.
5864         * go32-nat.c: Fix common/ includes.
5865         * gnu-nat.c: Fix common/ includes.
5866         * gdbthread.h: Fix common/ includes.
5867         * gdbarch-selftests.c: Fix common/ includes.
5868         * gdb_usleep.c: Fix common/ includes.
5869         * gdb_select.h: Fix common/ includes.
5870         * gdb_bfd.c: Fix common/ includes.
5871         * gcore.c: Fix common/ includes.
5872         * fork-child.c: Fix common/ includes.
5873         * findvar.c: Fix common/ includes.
5874         * fbsd-nat.c: Fix common/ includes.
5875         * event-top.c: Fix common/ includes.
5876         * event-loop.c: Fix common/ includes.
5877         * dwarf2read.c: Fix common/ includes.
5878         * dwarf2loc.c: Fix common/ includes.
5879         * dwarf2-frame.c: Fix common/ includes.
5880         * dwarf-index-cache.c: Fix common/ includes.
5881         * dtrace-probe.c: Fix common/ includes.
5882         * disasm-selftests.c: Fix common/ includes.
5883         * defs.h: Fix common/ includes.
5884         * csky-tdep.c: Fix common/ includes.
5885         * cp-valprint.c: Fix common/ includes.
5886         * cp-support.h: Fix common/ includes.
5887         * cp-support.c: Fix common/ includes.
5888         * corelow.c: Fix common/ includes.
5889         * completer.h: Fix common/ includes.
5890         * completer.c: Fix common/ includes.
5891         * compile/compile.c: Fix common/ includes.
5892         * compile/compile-loc2c.c: Fix common/ includes.
5893         * compile/compile-cplus-types.c: Fix common/ includes.
5894         * compile/compile-cplus-symbols.c: Fix common/ includes.
5895         * command.h: Fix common/ includes.
5896         * cli/cli-dump.c: Fix common/ includes.
5897         * cli/cli-cmds.c: Fix common/ includes.
5898         * charset.c: Fix common/ includes.
5899         * build-id.c: Fix common/ includes.
5900         * btrace.h: Fix common/ includes.
5901         * btrace.c: Fix common/ includes.
5902         * breakpoint.h: Fix common/ includes.
5903         * breakpoint.c: Fix common/ includes.
5904         * ax.h:
5905         (enum agent_op): Fix common/ includes.
5906         * ax-general.c (struct aop_map): Fix common/ includes.
5907         * ax-gdb.c: Fix common/ includes.
5908         * auxv.c: Fix common/ includes.
5909         * auto-load.c: Fix common/ includes.
5910         * arm-tdep.c: Fix common/ includes.
5911         * arch/riscv.c: Fix common/ includes.
5912         * arch/ppc-linux-common.c: Fix common/ includes.
5913         * arch/i386.c: Fix common/ includes.
5914         * arch/arm.c: Fix common/ includes.
5915         * arch/arm-linux.c: Fix common/ includes.
5916         * arch/arm-get-next-pcs.c: Fix common/ includes.
5917         * arch/amd64.c: Fix common/ includes.
5918         * arch/aarch64.c: Fix common/ includes.
5919         * arch/aarch64-insn.c: Fix common/ includes.
5920         * arch-utils.c: Fix common/ includes.
5921         * amd64-windows-tdep.c: Fix common/ includes.
5922         * amd64-tdep.c: Fix common/ includes.
5923         * amd64-sol2-tdep.c: Fix common/ includes.
5924         * amd64-obsd-tdep.c: Fix common/ includes.
5925         * amd64-nbsd-tdep.c: Fix common/ includes.
5926         * amd64-linux-tdep.c: Fix common/ includes.
5927         * amd64-linux-nat.c: Fix common/ includes.
5928         * amd64-fbsd-tdep.c: Fix common/ includes.
5929         * amd64-fbsd-nat.c: Fix common/ includes.
5930         * amd64-dicos-tdep.c: Fix common/ includes.
5931         * amd64-darwin-tdep.c: Fix common/ includes.
5932         * agent.c: Fix common/ includes.
5933         * ada-lang.h: Fix common/ includes.
5934         * ada-lang.c: Fix common/ includes.
5935         * aarch64-tdep.c: Fix common/ includes.
5936
5937 2019-01-25  Tom Tromey  <tom@tromey.com>
5938
5939         * common/create-version.sh: Use common/version.h.
5940
5941 2019-01-24  Pedro Alves  <palves@redhat.com>
5942
5943         * infrun.c (signal_stop, signal_print, signal_program)
5944         (signal_catch, signal_pass): Now arrays instead of pointers.
5945         (update_signals_program_target, do_target_resume)
5946         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5947         * linux-nat.c (linux_nat_target::pass_signals)
5948         (linux_nat_target::create_inferior, linux_nat_target::attach):
5949         Adjust.
5950         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5951         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5952         * procfs.c (procfs_target::pass_signals): Adjust.
5953         * record-full.c (record_full_target::resume): Adjust.
5954         * remote.c (remote_target::pass_signals)
5955         (remote_target::program_signals): Adjust.
5956         * target-debug.h (target_debug_print_signals): Now takes a
5957         gdb::array_view as parameter.  Adjust.
5958         * target.h (target_ops) <pass_signals, program_signals>: Replace
5959         pointer and length parameters with gdb::array_view.
5960         (target_pass_signals, target_program_signals): Likewise.
5961         * target-delegates.c: Regenerate.
5962
5963 2019-01-24  Pedro Alves  <palves@redhat.com>
5964
5965         * common/forward-scope-exit.h
5966         (forward_scope_exit::forward_scope_exit): Pass arguments to
5967         m_bind_function directly, instead of creating a std::bind and
5968         copying that.
5969
5970 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5971
5972         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5973         for static members.
5974         (pass_in_v_vfp_candidate): Likewise.
5975
5976 2019-01-23  Tom Tromey  <tom@tromey.com>
5977             Pedro Alves  <palves@redhat.com>
5978
5979         * regcache.c (class regcache_invalidator): Remove.
5980         (regcache::raw_write): Use make_scope_exit.
5981
5982 2019-01-23  Tom Tromey  <tom@tromey.com>
5983
5984         * ui-out.h (class ui_out_emit_type): Update comment.
5985
5986 2019-01-23  Tom Tromey  <tom@tromey.com>
5987
5988         * infrun.c (fetch_inferior_event): Update comment.
5989
5990 2019-01-23  Tom Tromey  <tom@tromey.com>
5991             Pedro Alves  <palves@redhat.com>
5992
5993         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5994         parameter.
5995         (fetch_inferior_event): Use SCOPE_EXIT.
5996
5997
5998 2019-01-23  Tom Tromey  <tom@tromey.com>
5999             Pedro Alves  <palves@redhat.com>
6000
6001         * infrun.c (disable_thread_events): Delete.
6002         (stop_all_threads): Use SCOPE_EXIT.
6003
6004 2019-01-23  Tom Tromey  <tom@tromey.com>
6005             Pedro Alves  <palves@redhat.com>
6006
6007         * symfile.c: Include forward-scope-exit.h.
6008         (clear_symtab_users_cleanup): Replace forward declaration with
6009         a FORWARD_SCOPE_EXIT.
6010         (syms_from_objfile_1): Use the forward_scope_exit and
6011         gdb::optional instead of cleanup_function.
6012         (reread_symbols): Use the forward_scope_exit instead of
6013         cleanup_function.
6014         (clear_symtab_users_cleanup): Remove function.
6015
6016 2019-01-23  Tom Tromey  <tom@tromey.com>
6017             Pedro Alves  <palves@redhat.com>
6018
6019         * linux-nat.c: Include scope-exit.h.
6020         (cleanup_target_stop): Remove.
6021         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6022         SCOPE_EXIT.
6023
6024 2019-01-23  Tom Tromey  <tom@tromey.com>
6025             Pedro Alves  <palves@redhat.com>
6026
6027         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6028         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6029
6030 2019-01-23  Tom Tromey  <tom@tromey.com>
6031             Andrew Burgess  <andrew.burgess@embecosm.com>
6032             Pedro Alves  <palves@redhat.com>
6033
6034         * infrun.c (fetch_inferior_event): Use scope_exit.
6035         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6036         * top.c (execute_command): Use scope_exit.
6037         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6038         * utils.c (do_bpstat_clear_actions_cleanup)
6039         (make_bpstat_clear_actions_cleanup): Remove.
6040
6041 2019-01-23  Tom Tromey  <tom@tromey.com>
6042             Pedro Alves  <palves@redhat.com>
6043
6044         * infrun.c: Include "common/scope-exit.h"
6045         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6046         (wait_for_inferior): Use SCOPE_EXIT.
6047         (fetch_inferior_event): Use scope_exit.
6048
6049 2019-01-23  Tom Tromey  <tom@tromey.com>
6050             Pedro Alves  <palves@redhat.com>
6051
6052         * breakpoint.c (create_breakpoint): Remove cleanup.
6053
6054 2019-01-23  Tom Tromey  <tom@tromey.com>
6055             Andrew Burgess  <andrew.burgess@embecosm.com>
6056             Pedro Alves  <palves@redhat.com>
6057
6058 2019-01-23  Pedro Alves  <palves@redhat.com>
6059
6060         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6061
6062 2019-01-23  Pedro Alves  <palves@redhat.com>
6063             Andrew Burgess  <andrew.burgess@embecosm.com>
6064
6065         * gdbthread.h: Include "common/forward-scope-exit.h".
6066         (scoped_finish_thread_state): Redefine custom class in terms of
6067         forward_scope_exit.
6068
6069 2019-01-23  Pedro Alves  <palves@redhat.com>
6070             Andrew Burgess  <andrew.burgess@embecosm.com>
6071
6072         * common/forward-scope-exit.h: New file.
6073
6074 2019-01-23  Pedro Alves  <palves@redhat.com>
6075             Andrew Burgess  <andrew.burgess@embecosm.com>
6076             Tom Tromey  <tom@tromey.com>
6077
6078         * common/scope-exit.h: New file.
6079
6080 2019-01-23  Pedro Alves  <palves@redhat.com>
6081
6082         * common/preprocessor.h (ESC): Rename to ...
6083         (ESC_PARENS): ... this.
6084         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6085         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6086
6087 2019-01-23  Tom Tromey  <tom@tromey.com>
6088
6089         * language.h (class scoped_switch_to_sym_language_if_auto):
6090         Initialize m_lang in both cases.
6091
6092 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6093
6094         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6095         with XCNEW.
6096
6097 2019-01-22  Tom Tromey  <tom@tromey.com>
6098
6099         * corelow.c: Do not include sys/file.h.
6100
6101 2019-01-22  Tom Tromey  <tom@tromey.com>
6102
6103         * tui/tui-wingeneral.h: Include gdb_curses.h.
6104
6105 2019-01-22  Tom Tromey  <tom@tromey.com>
6106
6107         * source-cache.h (class source_cache) <get_source_lines,
6108         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6109
6110 2019-01-22  Tom Tromey  <tom@tromey.com>
6111
6112         * remote-fileio.h (struct remote_target): Declare.
6113
6114 2019-01-22  Tom Tromey  <tom@tromey.com>
6115
6116         * python/py-arch.c: Do not include py-ref.h.
6117         * python/py-bpevent.c: Do not include py-ref.h.
6118         * python/py-cmd.c: Do not include py-ref.h.
6119         * python/py-continueevent.c: Do not include py-ref.h.
6120         * python/py-event.h: Do not include py-ref.h.
6121         * python/py-evtregistry.c: Do not include py-ref.h.
6122         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6123         * python/py-frame.c: Do not include py-ref.h.
6124         * python/py-framefilter.c: Do not include py-ref.h.
6125         * python/py-function.c: Do not include py-ref.h.
6126         * python/py-infevents.c: Do not include py-ref.h.
6127         * python/py-linetable.c: Do not include py-ref.h.
6128         * python/py-objfile.c: Do not include py-ref.h.
6129         * python/py-param.c: Do not include py-ref.h.
6130         * python/py-prettyprint.c: Do not include py-ref.h.
6131         * python/py-progspace.c: Do not include py-ref.h.
6132         * python/py-symbol.c: Do not include py-ref.h.
6133         * python/py-symtab.c: Do not include py-ref.h.
6134         * python/py-type.c: Do not include py-ref.h.
6135         * python/py-unwind.c: Do not include py-ref.h.
6136         * python/py-utils.c: Do not include py-ref.h.
6137         * python/py-value.c: Do not include py-ref.h.
6138         * python/py-varobj.c: Do not include py-ref.h.
6139         * python/py-xmethods.c: Do not include py-ref.h.
6140         * python/python.c: Do not include py-ref.h.
6141         * varobj.c: Do not include py-ref.h.
6142
6143 2019-01-22  Tom Tromey  <tom@tromey.com>
6144
6145         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6146         keyword for bcache.
6147
6148 2019-01-22  Tom Tromey  <tom@tromey.com>
6149
6150         * compile/compile-cplus-types.c: Remove a comment by #include.
6151
6152 2019-01-22  Tom Tromey  <tom@tromey.com>
6153
6154         * compile/gcc-c-plugin.h: Include compile-internal.h.
6155
6156 2019-01-22  Tom Tromey  <tom@tromey.com>
6157
6158         * stabsread.c (EXTERN): Do not define.
6159         (symnum, next_symbol_text_func, processing_gcc_compilation)
6160         (within_function, global_sym_chain, global_stabs)
6161         (previous_stab_code, this_object_header_files)
6162         (n_this_object_header_files)
6163         (n_allocated_this_object_header_files): Define.
6164         * stabsread.h (EXTERN): Never define.  Use "extern".
6165
6166 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6167
6168         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6169         history_value.
6170
6171 2019-01-21  Tom Tromey  <tom@tromey.com>
6172
6173         * ui-out.c: Fix includes.
6174         * tui/tui-source.c: Fix includes.
6175         * target.c: Fix includes.
6176         * remote.c: Fix includes.
6177         * regcache.c: Fix includes.
6178         * python/py-block.c: Fix includes.
6179         * printcmd.c: Fix includes.
6180         * or1k-tdep.c: Fix includes.
6181         * mi/mi-main.c: Fix includes.
6182         * m32r-tdep.c: Fix includes.
6183         * csky-tdep.c: Fix includes.
6184         * compile/compile-cplus-types.c: Fix includes.
6185         * cli/cli-interp.c: Fix includes.
6186
6187 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6188
6189         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6190         for padding.
6191
6192 2019-01-16  Tom Tromey  <tom@tromey.com>
6193
6194         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6195         earlier.
6196         (struct objfile) <msymbols_range>: Move from top level.
6197         <msymbols>: New method.
6198         (class objfile_msymbols): Remove.
6199         * symtab.c (default_collect_symbol_completion_matches_break_on):
6200         Update.
6201         * symmisc.c (dump_msymbols): Update.
6202         * stabsread.c (scan_file_globals): Update.
6203         * objc-lang.c (info_selectors_command, info_classes_command)
6204         (find_methods): Update.
6205         * minsyms.c (find_solib_trampoline_target): Update.
6206         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6207         * coffread.c (coff_symfile_read): Update.
6208         * ada-lang.c (ada_lookup_simple_minsym)
6209         (ada_collect_symbol_completion_matches): Update.
6210
6211 2019-01-16  Tom Tromey  <tom@tromey.com>
6212
6213         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6214         type.  Remove no-argument constructor.
6215         <iterator::operator++>: Simplify.
6216         <begin>: Update.
6217         <end>: Use minimal_symbol_count.
6218
6219 2019-01-16  Tom Tromey  <tom@tromey.com>
6220
6221         * objfiles.h (struct objfile) <psymtabs>: New method.
6222         (class objfile_psymtabs): Remove.
6223         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6224         typedef.
6225         <range>: New method.
6226         (require_partial_symbols): Change return type.
6227         * psymtab.c (require_partial_symbols)
6228         (psym_expand_symtabs_matching): Update.
6229         * mdebugread.c (parse_partial_symbols): Update.
6230         * dbxread.c (dbx_end_psymtab): Update.
6231
6232 2019-01-15  Tom Tromey  <tom@tromey.com>
6233
6234         * symtab.c (lookup_objfile_from_block)
6235         (lookup_symbol_in_objfile_symtabs)
6236         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6237         (find_line_symtab, info_sources_command)
6238         (default_collect_symbol_completion_matches_break_on)
6239         (make_source_files_completion_list): Update.
6240         * symmisc.c (print_objfile_statistics, dump_objfile)
6241         (maintenance_print_symbols, maintenance_info_symtabs)
6242         (maintenance_check_symtabs, maintenance_info_line_tables):
6243         Update.
6244         * source.c (select_source_symtab)
6245         (forget_cached_source_info_for_objfile): Update.
6246         * objfiles.h (class objfile_compunits): Remove.
6247         (struct objfile) <compunits_range>: New typedef.
6248         (compunits): New method.
6249         * objfiles.c (objfile_relocate1): Update.
6250         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6251         * maint.c (count_symtabs_and_blocks): Update.
6252         * linespec.c (iterate_over_all_matching_symtabs): Update.
6253         * cp-support.c (add_symbol_overload_list_qualified): Update.
6254         * coffread.c (coff_symtab_read): Update.
6255         * ada-lang.c (add_nonlocal_symbols)
6256         (ada_collect_symbol_completion_matches)
6257         (ada_add_global_exceptions): Update.
6258
6259 2019-01-15  Tom Tromey  <tom@tromey.com>
6260
6261         * progspace.h (program_space) <objfiles_safe_range>: New
6262         typedef.
6263         <objfiles_safe>: New method.
6264         * objfiles.h (class all_objfiles_safe): Remove.
6265         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6266         * jit.c (jit_inferior_exit_hook): Update.
6267
6268 2019-01-17  Tom Tromey  <tom@tromey.com>
6269
6270         * progspace.h (program_space) <objfiles_range>: New typedef.
6271         <objfiles>: New method.
6272         <objfiles_head>: Rename from objfiles.
6273         (object_files): Update.
6274         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6275         * guile/scm-pretty-print.c
6276         (ppscm_find_pretty_printer_from_objfiles): Update.
6277         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6278         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6279         Update.
6280         * python/py-progspace.c (pspy_get_objfiles): Update.
6281         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6282         Update.
6283         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6284         (objfpy_lookup_objfile_by_build_id): Update.
6285         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6286         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6287         Update.
6288         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6289         (expand_symtab_containing_pc, lookup_objfile_from_block)
6290         (lookup_static_symbol, basic_lookup_transparent_type)
6291         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6292         (find_line_symtab, info_sources_command)
6293         (default_collect_symbol_completion_matches_break_on)
6294         (make_source_files_completion_list, find_main_name): Update.
6295         * symmisc.c (print_symbol_bcache_statistics)
6296         (print_objfile_statistics, maintenance_print_symbols)
6297         (maintenance_print_msymbols, maintenance_print_objfiles)
6298         (maintenance_info_symtabs, maintenance_check_symtabs)
6299         (maintenance_expand_symtabs, maintenance_info_line_tables):
6300         Update.
6301         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6302         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6303         (map_overlay_command, unmap_overlay_command)
6304         (simple_overlay_update, expand_symtabs_matching)
6305         (map_symbol_filenames): Update.
6306         * symfile-debug.c (set_debug_symfile): Update.
6307         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6308         Update.
6309         * source.c (select_source_symtab, forget_cached_source_info):
6310         Update.
6311         * solib.c (solib_read_symbols): Update.
6312         * solib-spu.c (append_ocl_sos): Update.
6313         * psymtab.c (maintenance_print_psymbols)
6314         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6315         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6316         * printcmd.c (info_symbol_command): Update.
6317         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6318         Update.
6319         * objfiles.h (class all_objfiles): Remove.
6320         * objfiles.c (have_partial_symbols, have_full_symbols)
6321         (have_minimal_symbols, qsort_cmp, update_section_map)
6322         (shared_objfile_contains_address_p)
6323         (default_iterate_over_objfiles_in_search_order): Update.
6324         * objc-lang.c (info_selectors_command, info_classes_command)
6325         (find_methods): Update.
6326         * minsyms.c (find_solib_trampoline_target): Update.
6327         * maint.c (maintenance_info_sections)
6328         (maintenance_translate_address, count_symtabs_and_blocks):
6329         Update.
6330         * main.c (captured_main_1): Update.
6331         * linux-thread-db.c (try_thread_db_load_from_pdir)
6332         (has_libpthread): Update.
6333         * linespec.c (iterate_over_all_matching_symtabs)
6334         (search_minsyms_for_name): Update.
6335         * jit.c (jit_find_objf_with_entry_addr): Update.
6336         * hppa-tdep.c (find_unwind_entry)
6337         (hppa_lookup_stub_minimal_symbol): Update.
6338         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6339         Update.
6340         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6341         (elf_gnu_ifunc_resolve_by_got): Update.
6342         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6343         * dwarf-index-write.c (save_gdb_index_command): Update.
6344         * cp-support.c (add_symbol_overload_list_qualified): Update.
6345         * breakpoint.c (create_overlay_event_breakpoint)
6346         (create_longjmp_master_breakpoint)
6347         (create_std_terminate_master_breakpoint)
6348         (create_exception_master_breakpoint): Update.
6349         * blockframe.c (find_pc_partial_function): Update.
6350         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6351         (ada_collect_symbol_completion_matches)
6352         (ada_add_global_exceptions): Update.
6353
6354 2019-01-17  Tom Tromey  <tom@tromey.com>
6355
6356         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6357         declare VEC.
6358         (solib_target_parse_libraries): Change return type.
6359         (library_list_start_segment, library_list_start_section)
6360         (library_list_end_library, library_list_start_library); Update.
6361         (solib_target_free_library_list): Remove.
6362         (solib_target_parse_libraries): Remove cleanup.  Change return
6363         type.
6364         (solib_target_current_sos): Update.
6365
6366 2019-01-17  Tom Tromey  <tromey@bapiya>
6367
6368         * valprint.c: Replace "the the" with "the".
6369         * symtab.c: Replace "the the" with "the".
6370         * solib.c: Replace "the the" with "the".
6371         * solib-dsbt.c: Replace "the the" with "the".
6372         * linespec.c: Replace "the the" with "the".
6373         * dwarf2loc.h: Replace "the the" with "the".
6374         * amd64-windows-tdep.c: Replace "the the" with "the".
6375         * aarch64-tdep.c: Replace "the the" with "the".
6376
6377 2019-01-16  Keith Seitz  <keiths@redhat.com>
6378
6379         PR gdb/23773
6380         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6381         <builder>: Rename to ..
6382         <m_builder>: ... this and make private.
6383         (dwarf2_cu::get_builder): New method.  Change all users of
6384         `builder' to use this method.
6385         (dwarf2_start_symtab): Move to ...
6386         (dwarf2_cu::start_symtab): ... here.  Update all callers
6387         (setup_type_unit_groups): Move to ...
6388         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6389         callers.
6390         (dwarf2_cu::reset_builder): New method.
6391         (process_full_compunit, process_full_type_unit): Use
6392         dwarf2_cu::reset_builder.
6393         (follow_die_offset): Record the ancestor CU if it is different
6394         from the followed DIE's CU.
6395         (follow_die_sig_1): Likewise.
6396
6397 2019-01-15  Tom Tromey  <tom@tromey.com>
6398
6399         * remote.c (class remote_state) <buf>: Now a char_vector.
6400         <buf_size>: Remove.
6401         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6402         parameter.
6403         (remote_target::getpkt_or_notif_sane_1)
6404         (remote_target::getpkt_sane)
6405         (remote_target::getpkt_or_notif_sane): Likewise.
6406         (class remote_target) <putpkt>: New overload.
6407         (remote_target::read_frame): Change type of "buf_p".  Remove
6408         sizeof_p parameter.
6409         (packet_ok): New overload.
6410         (packet_check_result): New overload.
6411         Update all uses.
6412
6413 2019-01-14  Tom Tromey  <tom@tromey.com>
6414
6415         * remote-notif.c (handle_notification, remote_notif_ack)
6416         (remote_notif_parse): Make "buf" const.
6417         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6418         const.
6419         (remote_notif_parse, remote_notif_ack, handle_notification):
6420         Likewise.
6421         * remote.c (remote_notif_stop_parse): Make "buf" const.
6422         (remote_target::remote_parse_stop_reply): Make "buf" const.
6423         (remote_notif_stop_ack): Make "buf" const.
6424
6425 2019-01-14  Tom Tromey  <tom@tromey.com>
6426
6427         * remote.c (remote_console_output): Make parameter const.
6428
6429 2019-01-14  Tom Tromey  <tom@tromey.com>
6430
6431         * target-debug.h (target_debug_print_signals): Constify.
6432         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6433         * procfs.c (procfs_target::pass_signals): Update.
6434         * linux-nat.c (linux_nat_target::pass_signals): Update.
6435         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6436         * target-delegates.c: Rebuild.
6437         * remote.c (remote_target::program_signals): Update.
6438         (remote_target::pass_signals): Update.
6439         * target.c (target_pass_signals): Constify argument.
6440         (target_program_signals): Likewise.
6441         * target.h (struct target_ops) <pass_signals, program_signals>:
6442         Constify argument.
6443         (target_pass_signals, target_program_signals): Constify argument.
6444
6445 2019-01-14  Tom Tromey  <tom@tromey.com>
6446
6447         PR tui/28819:
6448         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6449
6450 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6451
6452         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6453         field.
6454         * rs6000-tdep.c: Include reggroups.h.
6455         (IS_V_ALIAS_PSEUDOREG): Define.
6456         (rs6000_register_name): Return names for the "vX" aliases.
6457         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6458         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6459         aliases.  Call default_register_reggroup_p for all other
6460         pseudo-registers.
6461         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6462         New functions.
6463         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6464         Handle "vX" aliases.
6465         (v_alias_pseudo_register_collect): New function.
6466         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6467         (rs6000_gdbarch_init): Initialize "vX" aliases as
6468         pseudo-registers.  Restore registration of
6469         rs6000_pseudo_register_reggroup_p with
6470         set_tdesc_pseudo_register_reggroup_p.
6471
6472 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6473
6474         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6475         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6476         set_gdbarch_num_pseudo_regs.
6477
6478 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6479
6480         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6481         Remove arg prefixname, add do_set and do_show.
6482         Add member functions set_list and show_list.
6483         * cli/cli-style.c (class cli_style_option): Update accordingly.
6484         (style_set_list): Move to file scope.
6485         (style_show_list): Likewise.
6486         (set_style): Call help_list.
6487         (show_style): Call cmd_show_list.
6488         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6489         Update to use the new macro.
6490
6491 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6492
6493         * ada-lang.c (_initialize_ada_language): Expand the help text
6494         for the "catch exception" command.
6495
6496 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6497
6498         * symtab.c (matching_obj_sections): Initialize obj,
6499         declare it closer to its usage.
6500
6501 2019-01-10  Tom Tromey  <tom@tromey.com>
6502
6503         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6504         (basic_inf_threads_range): Remove.
6505         (inf_threads_range, inf_non_exited_threads_range)
6506         (safe_inf_threads_range): Use next_adapter.
6507
6508 2019-01-10  Keith Seitz  <keiths@redhat.com>
6509
6510         PR gdb/23712
6511         PR symtab/23010
6512         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6513         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6514
6515 2019-01-10  Keith Seitz  <keiths@redhat.com>
6516
6517         PR gdb/23712
6518         PR symtab/23010
6519         * dictionary.c (pending_to_vector): Remove.
6520         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6521         Remove _1 suffix, replacing functions of the same name.  Update
6522         all callers.
6523         (dict_create_hashed, dict_create_hashed_expandable)
6524         (dict_create_linear, dict_create_linear_expandable, dict_free)
6525         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6526         Make functions static.
6527
6528 2019-01-10  Keith Seitz  <keiths@redhat.com>
6529
6530         PR gdb/23712
6531         PR symtab/23010
6532         * dictionary.h (struct dictionary): Replace declaration with
6533         multidictionary.
6534         (dict_create_hashed, dict_create_hashed_expandable)
6535         (dict_create_linear, dict_create_linear_expandable)
6536         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6537         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6538         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6539         taking multidictionary argument.
6540         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6541         * block.h (struct block) <dict>: Change to multidictionary
6542         and rename `multidict'.
6543         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6544         symmisc.c: Update all dictionary references to multidictionary.
6545
6546 2019-01-10  Keith Seitz  <keiths@redhat.com>
6547
6548         PR gdb/23712
6549         PR symtab/23010
6550         * dictionary.c: Include unordered_map.
6551         (pending_to_vector): New function.
6552         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6553         Rewrite the non-"_1" functions to take vector instead
6554         of linked list.
6555         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6556         "new" _1 versions of the same name.
6557         (multidictionary): Define.
6558         (std::hash<enum language): New definition.
6559         (collate_pending_symbols_by_language, mdict_create_hashed)
6560         (mdict_create_hashed_expandable, mdict_create_linear)
6561         (mdict_create_linear_expandable, mdict_free)
6562         (find_language_dictionary, create_new_language_dictionary)
6563         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6564         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6565         (mdict_size, mdict_empty): New functions.
6566         * dictionary.h (mdict_iterator): Define.
6567
6568 2019-01-10  Pedro Alves  <palves@redhat.com>
6569
6570         * breakpoint.c (read_uploaded_action)
6571         (create_tracepoint_from_upload): Adjust to use
6572         gdb::unique_xmalloc_ptr.
6573         * ctf.c (ctf_write_uploaded_tp):
6574         (SET_ARRAY_FIELD): Use emplace_back.
6575         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6576         * tracefile-tfile.c (tfile_write_uploaded_tp):
6577         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6578         gdb::unique_xmalloc_ptr.
6579         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6580         at_string, cond_string, cmd_strings>: Replace char pointers
6581         with gdb::unique_xmalloc_ptr.
6582
6583 2019-01-10  Pedro Alves  <palves@redhat.com>
6584
6585         * solib-target.c (library_list_start_library): Don't xstrdup name.
6586
6587 2019-01-10  Pedro Alves  <palves@redhat.com>
6588
6589         * mdebugread.c (parse_partial_symbols): Use
6590         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6591
6592 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6593
6594         * linux-fork.c (scoped_switch_fork_info)
6595         <~scoped_switch_fork_info>: Fix incorrect variable name.
6596
6597 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6598
6599         * linux-fork.c (scoped_switch_fork_info)
6600         <scoped_switch_fork_info>: Make explicit.
6601         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6602
6603 2019-01-10  Tom Tromey  <tom@tromey.com>
6604
6605         * objfiles.h (objfile::reset_psymtabs): Update.
6606         * objfiles.c (objfile::objfile): Update.
6607         * psymtab.h (psymtab_storage::obstack): Update.
6608         (psymtab_storage::m_obstack): Use gdb::optional.
6609         (class psymtab_storage): Update comment.  Remove objfile
6610         parameter.
6611         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6612
6613 2019-01-10  Tom Tromey  <tom@tromey.com>
6614
6615         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6616         <free_psymtabs>: Now private.
6617         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6618         (allocate_psymtab): Use new method.
6619
6620 2019-01-10  Tom Tromey  <tom@tromey.com>
6621
6622         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6623         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6624         * mdebugread.c (parse_partial_symbols): Use
6625         allocate_dependencies.
6626         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6627         allocate_dependencies.
6628         (process_psymtab_comp_unit_reader)
6629         (build_type_psymtab_dependencies): Likewise.
6630         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6631
6632 2019-01-10  Tom Tromey  <tom@tromey.com>
6633
6634         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6635         PSYMBOL_SET_LANGUAGE.
6636         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6637
6638 2019-01-10  Tom Tromey  <tom@tromey.com>
6639
6640         * psymtab.h (psymtab_storage::obstack): New method.
6641         <m_obstack>: Rename from obstack; now private.
6642         * psymtab.c (psymtab_storage): Update.
6643         * dwarf2read.c (create_addrmap_from_index)
6644         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6645         Update.
6646
6647 2019-01-10  Tom Tromey  <tom@tromey.com>
6648
6649         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6650         * objfiles.h (objfile::reset_psymtabs): New method.
6651
6652 2019-01-10  Tom Tromey  <tom@tromey.com>
6653
6654         * symmisc.c (print_symbol_bcache_statistics): Update.
6655         (print_objfile_statistics): Update.
6656         * symfile.c (reread_symbols): Update.
6657         * psymtab.h (class psymtab_storage): New.
6658         * psymtab.c (psymtab_storage): New constructor.
6659         (~psymtab_storage): New destructor.
6660         (require_partial_symbols): Update.
6661         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6662         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6663         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6664         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6665         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6666         (start_psymtab_common, end_psymtab_common)
6667         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6668         (allocate_psymtab): Update.
6669         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6670         Update.
6671         (dump_psymtab_addrmap, maintenance_print_psymbols)
6672         (maintenance_check_psymtabs): Update.
6673         (class objfile_psymtabs): Move to objfiles.h.
6674         * psympriv.h (discard_psymtab): Now inline.
6675         (psymtab_discarder::psymtab_discarder): Update.
6676         (psymtab_discarder::~psymtab_discarder): Update.
6677         (ALL_OBJFILE_PSYMTABS): Rewrite.
6678         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6679         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6680         Remove fields.
6681         <partial_symtabs>: New field.
6682         (class objfile_psymtabs): Move from psymtab.h.  Update.
6683         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6684         psymbol_cache.
6685         (objfile::~objfile): Don't destroy psymbol_cache.
6686         * mdebugread.c (parse_partial_symbols): Update.
6687         * dwarf2read.c (create_addrmap_from_index)
6688         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6689         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6690         (add_partial_subprogram, dwarf2_ranges_read): Update.
6691         * dwarf-index-write.c (write_address_map)
6692         (write_one_signatured_type, recursively_write_psymbols)
6693         (class debug_names, class debug_names, write_psymtabs_to_index):
6694         Update.
6695
6696 2019-01-10  Tom Tromey  <tom@tromey.com>
6697
6698         * symtab.h (SYMBOL_SET_NAMES): Update.
6699         (symbol_set_names): Update.
6700         (MSYMBOL_SET_NAMES): Update.
6701         * symtab.c (symbol_set_names): Change argument to be an
6702         objfile_per_bfd_storage.
6703         * psymtab.c (add_psymbol_to_bcache): Update.
6704         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6705
6706 2019-01-10  Tom Tromey  <tom@tromey.com>
6707
6708         * symtab.c (create_demangled_names_hash): Change argument to be an
6709         objfile_per_bfd_storage.
6710         (symbol_set_names): Update.
6711
6712 2019-01-10  Tom Tromey  <tom@tromey.com>
6713
6714         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6715         init_psymbol_list.
6716         * psymtab.c (init_psymbol_list): Do nothing if already called.
6717         * psympriv.h (init_psymbol_list): Add comment.
6718         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6719         init_psymbol_list.
6720         * dbxread.c (dbx_symfile_read): Unconditionally call
6721         init_psymbol_list.
6722
6723 2019-01-10  Tom Tromey  <tom@tromey.com>
6724
6725         * xcoffread.c (scan_xcoff_symtab): Update.
6726         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6727         "where".
6728         * mdebugread.c (parse_partial_symbols)
6729         (handle_psymbol_enumerators): Update.
6730         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6731         * dbxread.c (read_dbx_symtab): Update.
6732         * psympriv.h (psymbol_placement): New enum.
6733         (add_psymbol_to_list): Update.
6734
6735 2019-01-10  Tom Tromey  <tom@tromey.com>
6736
6737         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6738         static_psymbols parameters.
6739         (scan_xcoff_symtab): Update.
6740         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6741         static_psymbols parameters.
6742         * psympriv.h (start_psymtab_common): Update.
6743         * mdebugread.c (parse_partial_symbols): Update.
6744         * dwarf2read.c (create_partial_symtab): Update.
6745         * dbxread.c (read_dbx_symtab): Update.
6746         (start_psymtab): Remove global_psymbols and static_psymbols
6747         parameters.
6748
6749 2019-01-10  Tom Tromey  <tom@tromey.com>
6750
6751         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6752         * psymtab.c (allocate_psymtab): Add comment.
6753         * psympriv.h (allocate_psymtab): Add comment.
6754         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6755         initializations.
6756         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6757
6758 2019-01-10  Tom Tromey  <tom@tromey.com>
6759
6760         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6761         Don't declare.
6762         * mipsread.c: Include mdebugread.h.
6763         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6764         Declare.
6765         * elfread.c: Include mdebugread.h.
6766
6767 2019-01-09  Tom Tromey  <tom@tromey.com>
6768
6769         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6770         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6771         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6772         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6773         (psym_lookup_symbol, psym_find_last_source_symtab)
6774         (psym_forget_cached_source_info, psym_print_stats)
6775         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6776         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6777         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6778         (psym_find_compunit_symtab_by_address)
6779         (maintenance_print_psymbols, maintenance_info_psymtabs)
6780         (maintenance_check_psymtabs): Use ranged for.
6781         * psymtab.h (class objfile_psymtabs): New.
6782         (require_partial_symbols): Return objfile_psymtabs.
6783         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6784
6785 2019-01-09  Tom Tromey  <tom@tromey.com>
6786
6787         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6788         (find_pc_mapped_section, list_overlays_command)
6789         (map_overlay_command, unmap_overlay_command)
6790         (simple_overlay_update): Use all_objfiles.
6791         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6792         * printcmd.c (info_symbol_command): Use all_objfiles.
6793         * objfiles.h (ALL_OBJSECTIONS): Remove.
6794         * maint.c (maintenance_translate_address): Use all_objfiles.
6795         * gcore.c (gcore_create_callback): Use all_objfiles.
6796         (objfile_find_memory_regions): Likewise.
6797
6798 2019-01-09  Tom Tromey  <tom@tromey.com>
6799
6800         * symtab.c (find_line_symtab, info_sources_command)
6801         (make_source_files_completion_list): Use objfile_compunits.
6802         * source.c (select_source_symtab): Use objfile_compunits.
6803         * objfiles.h (struct objfile): Update comment.
6804         (ALL_OBJFILES): Remove.
6805         (ALL_FILETABS): Remove.
6806         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6807         objfile_compunits.
6808
6809 2019-01-09  Tom Tromey  <tom@tromey.com>
6810
6811         * symmisc.c (print_objfile_statistics, dump_objfile)
6812         (maintenance_print_symbols): Use compunit_filetabs.
6813         * source.c (forget_cached_source_info_for_objfile): Use
6814         compunit_filetabs.
6815         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6816         (ALL_FILETABS): Use compunit_filetabs.
6817         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6818         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6819
6820 2019-01-09  Tom Tromey  <tom@tromey.com>
6821
6822         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6823         (compunit_filetabs): New.
6824         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6825         compunit_filetabs.
6826         (info_sources_command, make_source_files_completion_list): Remove
6827         declaration.
6828         * symmisc.c (print_objfile_statistics, dump_objfile)
6829         (maintenance_print_symbols): Remove declaration.
6830         (maintenance_info_symtabs): Use compunit_filetabs.
6831         (maintenance_info_line_tables): Likewise.
6832         * source.c (select_source_symtab): Change local variable name.
6833         (forget_cached_source_info_for_objfile): Remove declaration.
6834         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6835         * objfiles.c (objfile_relocate1): Remove declaration.
6836         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6837         declaration.
6838         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6839         * coffread.c (coff_symtab_read): Remove declaration.
6840         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6841         compunit_filetabs.
6842
6843 2019-01-09  Tom Tromey  <tom@tromey.com>
6844
6845         * symtab.c (lookup_objfile_from_block)
6846         (find_pc_sect_compunit_symtab, search_symbols)
6847         (default_collect_symbol_completion_matches_break_on): Use
6848         objfile_compunits.
6849         * objfiles.h (ALL_COMPUNITS): Remove.
6850         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6851         * cp-support.c (add_symbol_overload_list_qualified): Use
6852         objfile_compunits.
6853         * ada-lang.c (ada_collect_symbol_completion_matches)
6854         (ada_add_global_exceptions): Use objfile_compunits.
6855
6856 2019-01-09  Tom Tromey  <tom@tromey.com>
6857
6858         * source.c (select_source_symtab)
6859         (forget_cached_source_info_for_objfile): Remove declaration.
6860         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6861         declaration.
6862         * maint.c (count_symtabs_and_blocks): Remove declaration.
6863         * cp-support.c (add_symbol_overload_list_qualified): Remove
6864         declaration.
6865         * coffread.c (coff_symtab_read): Remove declaration.
6866         * symtab.c (lookup_symbol_in_objfile_symtabs)
6867         (basic_lookup_transparent_type_1): Use objfile_compunits.
6868         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6869         (info_sources_command, search_symbols)
6870         (default_collect_symbol_completion_matches_break_on)
6871         (make_source_files_completion_list): Remove declaration.
6872         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6873         (ada_collect_symbol_completion_matches)
6874         (ada_add_global_exceptions): Remove declaration.
6875         * linespec.c (iterate_over_all_matching_symtabs): Use
6876         objfile_compunits.
6877         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6878         (class objfile_compunits): New.
6879         (ALL_COMPUNITS): Use objfile_compunits.
6880         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6881         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6882         objfile_compunits.
6883         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6884
6885 2019-01-09  Tom Tromey  <tom@tromey.com>
6886
6887         * symtab.c (search_symbols)
6888         (default_collect_symbol_completion_matches_break_on): Use
6889         objfile_msymbols.
6890         * ada-lang.c (ada_lookup_simple_minsym)
6891         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6892         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6893         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6894         objfile_msymbols.
6895         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6896         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6897         * objc-lang.c (find_methods): Use objfile_msymbols.
6898         (info_selectors_command, info_classes_command): Likewise.
6899         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6900         * objfiles.h (class objfile_msymbols): New.
6901         (ALL_OBJFILE_MSYMBOLS): Remove.
6902         (ALL_MSYMBOLS): Remove.
6903
6904 2019-01-09  Tom Tromey  <tom@tromey.com>
6905
6906         * common/next-iterator.h (next_adapter): Add Iterator template
6907         parameter.
6908         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6909         (class all_objfiles_safe): New.
6910         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6911         * objfiles.c (put_objfile_before): Update comment.
6912         (add_separate_debug_objfile): Likewise.
6913         (free_all_objfiles): Use all_objfiles_safe.
6914         (objfile_purge_solibs): Likewise.
6915
6916 2019-01-09  Tom Tromey  <tom@tromey.com>
6917
6918         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6919         (expand_symtab_containing_pc, lookup_static_symbol)
6920         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6921         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6922         all_objfiles.
6923         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6924         * breakpoint.c (create_overlay_event_breakpoint)
6925         (create_longjmp_master_breakpoint)
6926         (create_std_terminate_master_breakpoint)
6927         (create_exception_master_breakpoint): Use all_objfiles.
6928         * linux-thread-db.c (try_thread_db_load_from_pdir)
6929         (has_libpthread): Use all_objfiles.
6930         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6931         * linespec.c (iterate_over_all_matching_symtabs)
6932         (search_minsyms_for_name): Use all_objfiles.
6933         * maint.c (maintenance_info_sections): Use all_objfiles.
6934         * main.c (captured_main_1): Use all_objfiles.
6935         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6936         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6937         * guile/scm-pretty-print.c
6938         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6939         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6940         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6941         (maintenance_print_msymbols): Use all_objfiles.
6942         * source.c (select_source_symtab): Use all_objfiles.
6943         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6944         * symfile.c (remove_symbol_file_command)
6945         (expand_symtabs_matching, map_symbol_filenames): Use
6946         all_objfiles.
6947         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6948         all_objfiles.
6949         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6950         * objc-lang.c (find_methods): Use all_objfiles.
6951         * objfiles.c (have_partial_symbols, have_full_symbols)
6952         (have_minimal_symbols, qsort_cmp)
6953         (default_iterate_over_objfiles_in_search_order): Use
6954         all_objfiles.
6955         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6956         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6957         (maintenance_check_psymtabs): Use all_objfiles.
6958         (ALL_PSYMTABS): Remove.
6959         * compile/compile-object-run.c (do_module_cleanup): Use
6960         all_objfiles.
6961         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6962         * cp-support.c (add_symbol_overload_list_qualified): Use
6963         all_objfiles.
6964         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6965         Use all_objfiles.
6966         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6967         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6968         all_objfiles.
6969         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6970         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6971         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6972         Uses all_objfiles.
6973         * solib.c (solib_read_symbols): Use all_objfiles
6974
6975 2019-01-09  Tom Tromey  <tom@tromey.com>
6976
6977         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6978         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6979         all_objfiles.
6980         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6981         * symmisc.c (print_symbol_bcache_statistics)
6982         (print_objfile_statistics, maintenance_print_objfiles)
6983         (maintenance_info_symtabs, maintenance_check_symtabs)
6984         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6985         all_objfiles.
6986         * source.c (forget_cached_source_info): Use all_objfiles.
6987         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6988         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6989         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6990         * objfiles.c (update_section_map): Use all_objfiles.
6991         (shared_objfile_contains_address_p): Likewise.
6992         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6993         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6994
6995 2019-01-09  Tom Tromey  <tom@tromey.com>
6996
6997         * common/next-iterator.h: New file.
6998         * objfiles.h (class all_objfiles): New.
6999         (struct objfile_iterator): New.
7000
7001 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7002
7003         * NEWS: Move the description of the changed "frame", "select-frame",
7004          and "info frame" commands to the Changed commands section.
7005
7006 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7007
7008         * gdbtypes.c (check_stub_method_group): Remove handling of old
7009         mangling schemes.
7010         * linespec.c (find_methods): Likewise.
7011         * stabsread.c (read_member_functions): Likewise.
7012         * valops.c (search_struct_method): Likewise.
7013         (value_struct_elt_for_reference): Likewise.
7014         * NEWS: Mention this change.
7015
7016 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7017
7018         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7019         print_source_lines.
7020         * source.c (print_source_lines_base): Update line number check.
7021         (print_source_lines): New function.
7022         (source_lines_range::source_lines_range): New function.
7023         * source.h (class source_lines_range): New class.
7024         (print_source_lines): New declaration.
7025
7026 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7027
7028         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7029
7030 2019-01-08  Tom Tromey  <tom@tromey.com>
7031             Simon Marchi  <simon.marchi@ericsson.com>
7032
7033         PR gdb/24060
7034         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7035         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7036         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7037         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7038         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7039         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7040
7041 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7042
7043         * source.c (select_source_symtab): Move header comment to
7044         declaration in source.h.
7045         (forget_cached_source_info_for_objfile): Likewise.
7046         (forget_cached_source_info): Likewise.
7047         (identify_source_line): Likewise.
7048         * source.h (identify_source_line): Move declaration from symtab.h
7049         and add comment from source.c
7050         (print_source_lines): Likewise.
7051         (forget_cached_source_info_for_objfile): Likewise.
7052         (forget_cached_source_info): Likewise.
7053         (select_source_symtab): Likewise.
7054         (enum print_source_lines_flag): Move definition from symtab.h.
7055         * symtab.h (identify_source_line): Move declaration to source.h.
7056         (print_source_lines): Likewise.
7057         (forget_cached_source_info_for_objfile): Likewise.
7058         (forget_cached_source_info): Likewise.
7059         (select_source_symtab): Likewise.
7060         (enum print_source_lines_flag): Move definition to source.h.
7061         * tui/tui-hooks.c: Add 'source.h' include.
7062
7063 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7064
7065         * source.c (print_source_lines_base): Handle requests to print
7066         reverse line number sequences, and guard against empty lines
7067         string.
7068
7069 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7070
7071         * source.c (print_source_lines_base): Fix skip of '\r' if next
7072         character is '\n'.
7073
7074 2019-01-06  Tom Tromey  <tom@tromey.com>
7075
7076         * c-exp.y (struct c_parse_state) <macro_original_text,
7077         expansion_obstack>: New member.
7078         (macro_original_text, expansion_obstack): Remove globals.
7079         (scan_macro_expansion, scanning_macro_expansion)
7080         (finished_macro_expansion): Update.
7081         (scan_macro_cleanup): Remove.
7082         (yylex, c_parse): Update.
7083
7084 2019-01-06  Tom Tromey  <tom@tromey.com>
7085
7086         * c-exp.y (struct c_parse_state) <strings>: New member.
7087         (operator_stoken): Update.
7088
7089 2019-01-06  Tom Tromey  <tom@tromey.com>
7090
7091         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7092         (union type_stack_elt) <typelist_val>: Now a pointer to
7093         std::vector.
7094         (type_stack_cleanup): Don't declare.
7095         (push_typelist): Update.
7096         * parse.c (pop_typelist): Return a std::vector.
7097         (push_typelist): Take a std::vector.
7098         (follow_types): Update.  Do not free args.
7099         (type_stack_cleanup): Remove.
7100         * c-exp.y (struct c_parse_state): New.
7101         (cpstate): New global.
7102         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7103         (nonempty_typelist): Update.
7104         (func_mod): Create a new vector.
7105         (c_parse): Create a c_parse_state.
7106         (check_parameter_typelist): Do not delete params.
7107         (function_method): Update.  Do not delete type_list.
7108
7109 2019-01-06  Tom Tromey  <tom@tromey.com>
7110
7111         PR gdb/28155:
7112         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7113         check_typedef.
7114         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7115         (print_return_value): Likewise.
7116
7117 2019-01-05  Tom Tromey  <tom@tromey.com>
7118
7119         * contrib/cleanup_check.py: Remove.
7120         * contrib/gcc-with-excheck: Remove.
7121         * contrib/exsummary.py: Remove.
7122         * contrib/excheck.py: Remove.
7123
7124 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7125
7126         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7127         NULL. Initialize tpprev to NULL instead of assigning it
7128         to NULL on the next statement.
7129         * windows-nat.c (windows_delete_thread): Remove check for
7130         main_thread_id before printing thread exit notifications.
7131         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7132         Remove thread ID check against main_thread_id.
7133         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7134         windows_delete_thread.
7135         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7136
7137 2019-01-04  Tom Tromey  <tom@tromey.com>
7138
7139         * compile/compile.c (_initialize_compile): Use upper case for
7140         metasyntactic variables.
7141         * symmisc.c (_initialize_symmisc): Use upper case for
7142         metasyntactic variables.
7143         * psymtab.c (_initialize_psymtab): Use upper case for
7144         metasyntactic variables.
7145         * demangle.c (demangle_command): Use upper case for metasyntactic
7146         variables.
7147         (_initialize_demangler): Likewise.
7148         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7149         variables.
7150
7151 2019-01-03  Tom Tromey  <tom@tromey.com>
7152
7153         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7154
7155 2019-01-03  Tom Tromey  <tom@tromey.com>
7156
7157         * python/py-symtab.c (salpy_str): Update.
7158         (struct salpy_sal_object) <symtab>: Now a PyObject.
7159         (salpy_dealloc): Update.
7160         (del_objfile_sal): Use gdbpy_ref.
7161
7162 2019-01-03  Tom Tromey  <tom@tromey.com>
7163
7164         * python/py-type.c (convert_field): Use new_reference.  Return
7165         gdbpy_ref.
7166         (make_fielditem): Return gdbpy_ref.
7167         (typy_fields): Update.
7168         (typy_getitem): Update.
7169         (field_name): Return gdbpy_ref.  Use new_reference.
7170         (typy_iterator_iternext): Update.
7171
7172 2019-01-03  Tom Tromey  <tom@tromey.com>
7173
7174         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7175
7176 2019-01-03  Tom Tromey  <tom@tromey.com>
7177
7178         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7179         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7180         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7181         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7182         (pspy_set_type_printers): Likewise.
7183         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7184         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7185         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7186         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7187         (objfpy_set_type_printers): Likewise.
7188
7189 2019-01-03  Tom Tromey  <tom@tromey.com>
7190
7191         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7192         (gdbpy_print_stack): Use gdbpy_err_fetch.
7193         * python/python-internal.h (class gdbpy_err_fetch): New class.
7194         (class gdbpy_enter) <m_error_type, m_error_value,
7195         m_error_traceback>: Remove.
7196         <m_error>: New member.
7197         (gdbpy_exception_to_string): Don't declare.
7198         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7199         * python/py-value.c (convert_value_from_python): Use
7200         gdbpy_err_fetch.
7201         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7202         gdbpy_exception_to_string.
7203         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7204         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7205         gdbpy_err_fetch.
7206
7207 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7208
7209         * linux-nat.c (delete_lwp_cleanup): Delete.
7210         (struct lwp_deleter): New struct.
7211         (lwp_info_up): New typedef.
7212         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7213         lwp_info_up.
7214
7215 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7216
7217         * linux-fork.c (class scoped_switch_fork_info): New class.
7218         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7219
7220 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7221
7222         * valops.c (find_overload_match): Remove use of null_cleanup, and
7223         calls to do_cleanups.
7224
7225 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7226
7227         * compile/compile-cplus-types.c
7228         (compile_cplus_instance::decl_name): Handle changes to
7229         cp_func_name.
7230         * cp-support.c (cp_func_name): Update header comment, update
7231         return type.
7232         * cp-support.h (cp_func_name): Update return type in declaration.
7233         * valops.c (find_overload_match): Move temp_func local to top
7234         level of function and change its type.  Use temp_func to hold and
7235         delete temporary string obtained from cp_func_name.
7236
7237 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7238
7239         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7240         gdb::char_vector, remove cleanup, and update uses of `msg`.
7241
7242 2019-01-03  Jim Wilson  <jimw@sifive.com>
7243
7244         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7245
7246 2019-01-02  Tom Tromey  <tom@tromey.com>
7247
7248         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7249         (tdesc_parse_xml): Remove cleanups.
7250         * target-descriptions.h (make_cleanup_free_target_description):
7251         Don't declare.
7252         (target_desc_deleter): New struct.
7253         (target_desc_up): New typedef.
7254         * target-descriptions.c (target_desc_deleter::operator()): Rename
7255         from free_target_description.
7256         (make_cleanup_free_target_description): Remove.
7257
7258 2019-01-02  Tom Tromey  <tom@tromey.com>
7259
7260         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7261         constructor, destructor.
7262         (linespec_parser): Remove typedef.
7263         (~linespec_parser): Rename from linespec_parser_delete.
7264         (linespec_lex_to_end, linespec_complete_label)
7265         (linespec_complete): Update.
7266         (decode_line_full): Remove cleanups.
7267         (decode_line_1): Update.
7268
7269 2019-01-02  Tom Tromey  <tom@tromey.com>
7270
7271         * python/python-internal.h (inferior_to_inferior_object): Change
7272         return type.
7273         * python/py-exitedevent.c (create_exited_event_object): Update.
7274         * python/py-inferior.c (inferior_to_inferior_object): Return
7275         gdbpy_ref.
7276         (python_new_inferior, python_inferior_deleted)
7277         (thread_to_thread_object, delete_thread_object)
7278         (build_inferior_list, gdbpy_selected_inferior): Update.
7279         * python/py-infthread.c (create_thread_object): Update.  Also fail
7280         if inferior_to_inferior_object fails.
7281
7282 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7283
7284         * inferior.h (class inferior) <displaced_step_state>: New field.
7285         * infrun.h (struct displaced_step_state): Move here from
7286         infrun.c.  Initialize fields, add constructor.
7287         <inf>: Remove field.
7288         <reset>: New method.
7289         * infrun.c (struct displaced_step_inferior_state): Move to
7290         infrun.h.
7291         (displaced_step_inferior_states): Remove.
7292         (get_displaced_stepping_state): Adust.
7293         (displaced_step_in_progress_any_inferior): Adjust.
7294         (displaced_step_in_progress_thread): Adjust.
7295         (displaced_step_in_progress): Adjust.
7296         (add_displaced_stepping_state): Remove.
7297         (get_displaced_step_closure_by_addr): Adjust.
7298         (remove_displaced_stepping_state): Remove.
7299         (infrun_inferior_exit): Call displaced_step_state.reset.
7300         (use_displaced_stepping): Don't check for NULL.
7301         (displaced_step_prepare_throw): Call
7302         get_displaced_stepping_state.
7303         (displaced_step_fixup): Don't check for NULL.
7304         (prepare_for_detach): Don't check for NULL.
7305
7306 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7307
7308         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7309          in case of call that did not complete.
7310
7311 2019-01-02  Andrey Utkin  <autkin@undo.io>
7312
7313         * symfile.c (find_separate_debug_file): Fix search of debug files for
7314         remote debuggee.
7315
7316 2019-01-02  Tom Tromey  <tom@tromey.com>
7317
7318         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7319         indentation.
7320         * python/py-frame.c (frapy_older): Remove cast.
7321         (frapy_newer): Likewise.
7322         * python/py-breakpoint.c (local_setattro): Remove cast.
7323         * python/py-arch.c (archpy_name): Remove local variable.
7324         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7325
7326 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7327
7328         * unittests/basic_string_view/element_access/char/empty.cc:
7329         Fix year range in copyright header.
7330
7331 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7332
7333         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7334         Delete.
7335         <operator==>: Update with for removed field.
7336         <hash>: Likewise.
7337         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7338         <isa_features>: ...this.
7339         <abi_features>: New field.
7340         (riscv_isa_flen): Update comment.
7341         (riscv_abi_xlen): New declaration.
7342         (riscv_abi_flen): New declaration.
7343         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7344         isa_features.
7345         (riscv_abi_xlen): New function.
7346         (riscv_isa_flen): Update to get answer from isa_features.
7347         (riscv_abi_flen): New function.
7348         (riscv_has_fp_abi): Update to get answer from abi_features.
7349         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7350         xlen and flen.
7351         (riscv_call_info) <xlen, flen>: Update comment.
7352         (riscv_call_arg_struct): Remove invalid assertions
7353         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7354         is removed.
7355         (riscv_gdbarch_init): Gather isa features and abi features
7356         separately, ensure both match on the gdbarch when reusing an old
7357         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7358         a target with 64-bit float hardware.
7359
7360 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7361
7362         * source.c (search_command_helper): Stop reverse search
7363         when line 1 has been searched.
7364
7365 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7366
7367         * record-full.c (record_full_base_target::close): Rewrite
7368         record_full_core_buf_list free logic.
7369
7370 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7371
7372         * break-catch-syscall.c (print_one_catch_syscall): xfree
7373         the last text.
7374
7375 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7376
7377         * top.c (print_gdb_version): Update Copyright year in version
7378         message.
7379
7380 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7381
7382         Update copyright year range in all GDB files.
7383
7384 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7385
7386         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7387
7388 For older changes see ChangeLog-2018.
7389 \f
7390 Local Variables:
7391 mode: change-log
7392 left-margin: 8
7393 fill-column: 74
7394 version-control: never
7395 coding: utf-8
7396 End:
7397