gdb/ChangeLog

   1 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
   2
   3         * configure.ac: Don't check for 'dlfcn.h' (moved to
   4         gdbsupport/common.m4).
   5         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
   6         'gdbsupport/'.
   7         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
   8         * compile/compile-c-support.c: Include
   9         'gdbsupport/gdb-dlfcn.h'.
  10         * gdbsupport/common.m4: Check for 'dlfcn.h'.
  11         * gdb-dlfcn.c: Move to...
  12         * gdbsupport/gdb-dlfcn.c: ... here.
  13         * gdb-dlfcn.h: Move to...
  14         * gdbsupport/gdb-dlfcn.h: ... here.
  15
  16 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
  17
  18         * nios2-tdep.c (struct reg_value): Improve comments.  Make
  19         the offset field signed.
  20
  21 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
  22
  23         * python/lib/gdb/__init__.py (_execute_file): New function.
  24         * python/python.c (python_run_simple_file): Call gdb._execute_file
  25         on Windows.
  26
  27 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
  30         all uses as this was never set to anything but a zero value.
  31
  32 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
  33
  34         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
  35
  36 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * tui/tui-data.h (tui_gen_win_info): Add an =default
  39         move constructor, required by some GCC versions.
  40
  41 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
  42
  43         * go32-nat.c (go32_sysinfo): Add hygon_p.
  44
  45 2019-08-20  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
  48         line_from_reg_element_no, first_reg_element_no_inline,
  49         display_all_data, delete_data_content_windows,
  50         erase_data_content>: Now private.
  51
  52 2019-08-20  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
  55         (tui_unhighlight_win, tui_highlight_win)
  56         (tui_win_info::make_window): Update.
  57         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
  58
  59 2019-08-20  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  62         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  63         (MAX_PID_WIDTH): Move to tui-stack.c.
  64         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  65         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  66         (MAX_PID_WIDTH): Move from tui-data.h.
  67
  68 2019-08-20  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
  71         * tui/tui-wingeneral.c (box_win): Change type of win_info.
  72         (box_win): Update.
  73         (tui_gen_win_info::make_window): Rename from tui_make_window.
  74         (tui_win_info::make_window): New method.
  75         (tui_gen_win_info::make_visible): Update.
  76         * tui/tui-source.c (tui_source_window::set_contents): Update.
  77         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  78         (tui_data_window::display_registers_from): Update.
  79         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  80         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
  81         Declare.
  82         <can_box>: Remove.
  83         <title>: Remove.
  84         (struct tui_win_info) <make_window>: Declare.
  85         <can_box>: Now virtual.
  86         <title>: New member.
  87         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
  88         * tui/tui-command.c (tui_cmd_window::resize): Update.
  89
  90 2019-08-20  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
  93         * tui/tui-regs.c (tui_data_window::show_registers): Update.
  94         (tui_data_window::check_register_values): Update.
  95
  96 2019-08-20  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-regs.h (struct tui_data_window): Use
  99         DISABLE_COPY_AND_ASSIGN.
 100         <regs_content>: Change type, removing unique_ptr.
 101         <tui_data_window>: Add move constructor.
 102         * tui/tui-regs.c (tui_data_window::show_registers)
 103         (tui_data_window::show_register_group)
 104         (tui_data_window::display_registers_from)
 105         (tui_data_window::display_registers_from)
 106         (tui_data_window::first_data_item_displayed)
 107         (tui_data_window::delete_data_content_windows)
 108         (tui_data_window::rerender, tui_data_window::refresh_window)
 109         (tui_data_window::check_register_values): Update.
 110
 111 2019-08-20  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 114         show_register_group>: Declare.
 115         (tui_show_register_group): Don't declare.
 116         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 117         tui_show_registers.
 118         (tui_data_window::show_register_group): Rename from
 119         tui_show_register_group.
 120         (tui_data_window::check_register_values, tui_reg_command):
 121         Update.
 122         * tui/tui-layout.c (tui_set_layout): Update.
 123
 124 2019-08-20  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 127         Declare.
 128         (tui_check_register_values): Don't declare.
 129         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 130         from tui_check_register_values.
 131         * tui/tui-hooks.c (tui_register_changed): Update.
 132
 133 2019-08-20  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-regs.c (tui_reg_layout): Move later.
 136         (tui_show_registers): Don't enable TUI mode or change layout.
 137
 138 2019-08-20  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-regs.h (struct tui_data_item_window)
 141         <~tui_data_item_window>: Remove.
 142         <content>: Now a unique_xmalloc_ptr.
 143         * tui/tui-regs.c (tui_register_format): Return a
 144         unique_xmalloc_ptr.
 145         (tui_get_register): Update.
 146         (~tui_data_item_window): Remove.
 147         (tui_data_window::display_registers_from, tui_display_register):
 148         Update.
 149         * tui/tui-io.h (tui_expand_tabs): Update.
 150         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 151         Remove "col" parameter.
 152
 153 2019-08-20  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 156         field.
 157         * tui/tui-regs.c (~tui_data_item_window): Update.
 158
 159 2019-08-20  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 162         earlier.
 163
 164 2019-08-20  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 167
 168 2019-08-20  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-source.h (struct tui_source_window): Update.
 171         * tui/tui-regs.c (tui_show_registers): Update.
 172         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 173         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 174         (NO_REGS_STRING): Remove defines.
 175
 176 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 177
 178         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 179         unnecessary thread walk if remote doesn't support the packet.
 180
 181 2019-08-19  Tom Tromey  <tromey@adacore.com>
 182
 183         * python/py-value.c (value_has_field): Fix indentation.
 184
 185 2019-08-19  Tom Tromey  <tromey@adacore.com>
 186
 187         * printcmd.c (do_one_display, info_display_command): Update.
 188         * block.h (contained_in): Return bool.  Add allow_nested
 189         parameter.
 190         * block.c (contained_in): Return bool.  Add allow_nested
 191         parameter.
 192
 193 2019-08-19  Tom Tromey  <tom@tromey.com>
 194
 195         * configure: Rebuild.
 196         * configure.ac: Disallow the combination of -static-libstdc++ and
 197         source highlight.
 198         * source-cache.c (get_language_name): Handle rust.
 199         (source_cache::get_source_lines): Ignore highlighting exceptions.
 200
 201 2019-08-16  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 204         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 205         (struct tui_source_window_base) <make_visible, refresh_window,
 206         resize>: Remove methods.
 207         <execution_info>: Remove field.
 208         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 209         (tui_show_source_line, tui_source_window_base)
 210         (~tui_source_window_base): Update.
 211         (tui_source_window_base::resize)
 212         (tui_source_window_base::make_visible)
 213         (tui_source_window_base::refresh_window): Remove.
 214         (tui_source_window_base::update_exec_info): Update.
 215         * tui/tui-source.c (tui_source_window::set_contents): Update.
 216         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 217
 218 2019-08-16  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 221         deprecated_query_hook.
 222
 223 2019-08-16  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 226         (tui_update_source_windows_with_line): Update.
 227         * tui/tui-source.h (struct tui_source_window)
 228         <show_symtab_source>: Declare.
 229         (tui_show_symtab_source): Don't declare.
 230         * tui/tui-source.c (tui_show_symtab_source): Rename from
 231         tui_show_symtab_source.
 232
 233 2019-08-16  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-winsource.h (struct tui_source_window_base)
 236         <set_contents>: Declare.
 237         * tui/tui-winsource.c
 238         (tui_source_window_base::update_source_window_as_is): Update.
 239         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 240         Declare.
 241         (tui_set_source_content): Don't declare.
 242         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 243         tui_set_source_content.
 244         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 245         Declare.
 246         (tui_set_disassem_content): Don't declare.
 247         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 248         tui_set_disassem_content.
 249
 250 2019-08-16  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-winsource.h (struct tui_source_window_base)
 253         <update_breakpoint_info>: Declare.
 254         (tui_update_breakpoint_info): Don't declare.
 255         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 256         (tui_update_all_breakpoint_info): Update.
 257         (tui_source_window_base::update_breakpoint_info): Rename from
 258         tui_update_breakpoint_info.
 259         (tui_source_window_base::update_exec_info): Update.
 260
 261 2019-08-16  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-winsource.h (struct tui_source_window_base)
 264         <update_source_window>: Declare.
 265         (tui_update_source_window): Don't declare.
 266         * tui/tui-winsource.c
 267         (tui_source_window_base::update_source_window): Rename from
 268         tui_update_source_window.
 269         (tui_source_window_base::rerender): Update.
 270         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 271         * tui/tui-disasm.c (tui_show_disassem)
 272         (tui_show_disassem_and_update_source)
 273         (tui_disasm_window::maybe_update): Update.
 274
 275 2019-08-16  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-winsource.h (struct tui_source_window_base)
 278         <update_source_window_as_is>: Declare.
 279         (tui_update_source_window_as_is): Don't declare.
 280         * tui/tui-winsource.c (tui_update_source_window): Update
 281         (tui_source_window_base::update_source_window_as_is): Rename from
 282         tui_update_source_window_as_is.
 283         (tui_source_window_base::refill): Update.
 284         * tui/tui-source.c (tui_show_symtab_source): Update.
 285         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 286         Update.
 287
 288 2019-08-16  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-winsource.h (tui_update_source_window)
 291         (tui_update_source_window_as_is): Remove "noerror" parameter.
 292         * tui/tui-winsource.c (tui_update_source_window)
 293         (tui_update_source_window_as_is): Remove "noerror" parameter.
 294         (tui_update_source_windows_with_addr)
 295         (tui_update_source_windows_with_line)
 296         (tui_source_window_base::rerender)
 297         (tui_source_window_base::refill): Update.
 298         * tui/tui-source.h (tui_set_source_content)
 299         (tui_show_symtab_source): Remove "noerror" parameter.
 300         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 301         parameter.
 302         (tui_show_symtab_source): Likewise.
 303         (tui_source_window::maybe_update): Update.
 304         * tui/tui-disasm.c (tui_show_disassem)
 305         (tui_show_disassem_and_update_source)
 306         (tui_disasm_window::do_scroll_vertical)
 307         (tui_disasm_window::maybe_update): Update.
 308
 309 2019-08-16  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui.c (tui_is_window_visible): Update.
 312         * tui/tui-wingeneral.c (tui_make_window)
 313         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 314         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 315         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 316         (tui_set_win_height_command, parse_scrolling_args): Update.
 317         * tui/tui-source.c (tui_source_window::style_changed): Update.
 318         * tui/tui-regs.c (tui_show_registers)
 319         (tui_data_window::first_data_item_displayed)
 320         (tui_data_window::delete_data_content_windows)
 321         (tui_check_register_values, tui_reg_command): Update.
 322         * tui/tui-disasm.c (tui_show_disassem): Update.
 323         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 324         method.
 325         <is_visible>: Remove field.
 326         * tui/tui-data.c (tui_next_win, tui_prev_win)
 327         (tui_delete_invisible_windows): Update.
 328
 329 2019-08-16  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-winsource.h (struct tui_source_window_base)
 332         <m_has_locator>: Remove.
 333         * tui/tui-layout.c (show_source_disasm_command, show_data)
 334         (show_source_or_disasm_and_command): Update.
 335
 336 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 337
 338         * NEWS (Other MI changes): New subsection.
 339         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 340         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 341         * arch-utils.c (default_get_pc_address_flags): New function.
 342         * arch-utils.h (default_get_pc_address_flags): New declaration.
 343         * gdbarch.sh: Add get_pc_address_flags.
 344         * gdbarch.c: Regenerate.
 345         * gdbarch.h: Likewise.
 346         * stack.c (print_pc): New function.
 347         (print_frame_info) (print_frame): Call print_pc.
 348
 349 2019-08-16  Tom de Vries  <tdevries@suse.de>
 350
 351         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 352         print_objfile_section_info.
 353
 354 2019-08-15  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 357         calling update_cmdwin_start_line.
 358         * tui/tui-winsource.h (struct tui_source_window_base)
 359         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 360         <rerender>: Declare.
 361         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 362         Call rerender.
 363         (tui_source_window_base::set_new_height): Remove.
 364         (tui_source_window_base::rerender): Rename from
 365         do_make_visible_with_new_height.
 366         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 367         resize method.
 368         (tui_win_info::make_invisible_and_set_new_height)
 369         (tui_win_info::make_visible_with_new_height): Remove.
 370         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 371         Declare.
 372         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 373         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 374         do_make_visible_with_new_height>: Don't declare.
 375         <rerender>: Declare.
 376         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 377         set_new_height.
 378         (tui_data_window::do_make_visible_with_new_height): Remove.
 379         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 380         call tui_show_locator_content.
 381         (tui_gen_win_info::resize): Call rerender.
 382         (show_source_or_disasm_and_command): Don't call
 383         tui_show_locator_content.
 384         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 385         method.
 386         (struct tui_win_info) <rerender>: Declare.
 387         <set_new_height, make_invisible_and_set_new_height,
 388         make_visible_with_new_height>: Don't declare.
 389         * tui/tui-data.c (tui_win_list::rerender): New method.
 390         * tui/tui-command.h (struct tui_cmd_window)
 391         <do_make_visible_with_new_height>: Don't declare.
 392         * tui/tui-command.c
 393         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 394
 395 2019-08-15  Tom Tromey  <tromey@adacore.com>
 396
 397         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 398         * ada-lang.c (ada_enum_name): Likewise.
 399
 400 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 401
 402         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 403         leading underscore.
 404         (GdbOutputErrorFile): Likewise.
 405         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 406         accordingly.
 407         (execute_unwinders): Rename to have a leading underscore.
 408         (auto_load_packages): Likewise.
 409         (global scope): Adjust call to auto_load_packages accordingly.
 410         (GdbSetPythonDirectory): Likewise.
 411         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 412         instead of execute_unwinders.
 413
 414 2019-08-15  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 417         (show_data): Don't change window visibility.
 418         (tui_gen_win_info::resize): Remove special case for command
 419         window.  Use wresize, when available.
 420         (show_source_or_disasm_and_command): Don't change window
 421         visibility.
 422         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 423         <make_visible>: New method.
 424         * tui/tui-command.c (tui_cmd_window::resize): New method.
 425
 426 2019-08-15  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 429         (struct tui_source_windows): New.
 430         * tui/tui-winsource.c (tui_display_main): Update.
 431         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 432         (new_height_ok, parse_scrolling_args): Update.
 433         * tui/tui-layout.c (show_layout, show_data): Update.
 434         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 435         (tui_add_to_source_windows): Don't declare.
 436         * tui/tui-data.c (source_windows, tui_source_windows)
 437         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 438
 439 2019-08-15  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 442         Rename from reset.
 443         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 444         * tui/tui-layout.c (show_source_disasm_command, show_data):
 445         Update.
 446         (tui_gen_win_info::resize): Rename.
 447         (show_source_or_disasm_and_command): Update.
 448         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 449         reset.
 450
 451 2019-08-15  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 454         * tui/tui-interp.c (tui_interp::init): Don't call
 455         tui_initialize_static_data.
 456         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 457
 458 2019-08-15  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 461         examine tui_win_list.
 462
 463 2019-08-15  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 466         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 467         tui_clear_source_content.
 468         (tui_clear_source_content): Remove.
 469         (tui_source_window_base::do_erase_source_content): Hoist call to
 470         content.clear().
 471         * tui/tui-stack.c (tui_show_frame_info): Don't call
 472         tui_clear_source_content.
 473
 474 2019-08-15  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-winsource.h (struct tui_source_window_base)
 477         <do_erase_source_content>: New method.
 478         <erase_source_content>: New method.
 479         (tui_erase_source_content): Don't declare.
 480         * tui/tui-winsource.c (tui_clear_source_content): Update.
 481         (tui_source_window_base::do_erase_source_content): Rename from
 482         tui_erase_source_content.
 483         (tui_source_window_base::show_source_content): Update.
 484         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 485         * tui/tui-source.h (struct tui_source_window)
 486         <erase_source_content>: New method.
 487         * tui/tui-disasm.h (struct tui_disasm_window)
 488         <erase_source_content>: New method.
 489
 490 2019-08-15  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 493         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 494         constructor.
 495         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 496         * tui/tui-source.c (tui_set_source_content): Update.
 497         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 498
 499 2019-08-15  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 502         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 503         tui-source.c.
 504         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 505         Declare.
 506         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 507         method.
 508         (tui_source_window::maybe_update): Update.
 509
 510 2019-08-15  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 513         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 514         tui-disasm.c.
 515         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 516         Declare.
 517         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 518         method.
 519         (tui_disasm_window::maybe_update): Update.
 520
 521 2019-08-15  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui-winsource.h (struct tui_source_window_base)
 524         <maybe_update>: Declare.
 525         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 526         method.
 527         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 528         Declare.
 529         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 530         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 531         Declare.
 532         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 533
 534 2019-08-15  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 537
 538 2019-08-15  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-wingeneral.c: Include tui-stack.h.
 541         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 542         (struct tui_locator_window): Move from tui-data.h.
 543         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 544         (tui_initialize_static_data): Move from tui-data.c.
 545         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 546         (struct tui_locator_window): Move to tui-stack.c.
 547         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 548         (tui_initialize_static_data): Move to tui-stack.c.
 549
 550 2019-08-15  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-layout.c (show_source_disasm_command)
 553         (show_source_or_disasm_and_command): Use make_visible method, not
 554         tui_make_window.
 555         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 556         Remove.
 557
 558 2019-08-15  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-wingeneral.h (tui_make_window): Update.
 561         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 562         parameter.
 563         (tui_gen_win_info::make_visible): Update.
 564         * tui/tui-regs.c (tui_data_window::display_registers_from):
 565         Update.
 566         * tui/tui-layout.c (show_source_disasm_command)
 567         (show_source_or_disasm_and_command): Update.
 568         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 569         (enum tui_box): Remove.
 570         (struct tui_win_info) <can_box>: New method.
 571         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 572         method.
 573
 574 2019-08-15  Tom de Vries  <tdevries@suse.de>
 575
 576         * linux-nat-trad.c: Include gdbarch.h.
 577
 578 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 579
 580         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 581         register sizes.
 582
 583 2019-08-14  Tom Tromey  <tromey@adacore.com>
 584
 585         * darwin-nat.c: Include gdbarch.h.
 586         * darwin-nat-info.c: Include gdbarch.h.
 587
 588 2019-08-13  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 591         Remove.
 592         * tui/tui-data.c (tui_initialize_static_data): Update.
 593
 594 2019-08-13  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-winsource.h (struct tui_exec_info_window)
 597         <~tui_exec_info_window, maybe_allocate_content, get_content,
 598         m_content>: Remove.
 599         (struct tui_source_window_base) <set_exec_info_content,
 600         show_exec_info_content>: Don't declare.
 601         * tui/tui-winsource.c
 602         (tui_exec_info_window::maybe_allocate_content): Remove.
 603         (tui_source_window_base::update_exec_info): Rename from
 604         set_exec_info_content.
 605         (tui_source_window_base::show_exec_info_content)
 606         (tui_source_window_base::update_exec_info): Remove.
 607
 608 2019-08-13  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 611         declare.
 612         * tui/tui-winsource.c (tui_update_source_window_as_is)
 613         (tui_update_source_windows_with_addr, tui_erase_source_content):
 614         Update.
 615         (tui_clear_exec_info_content): Remove.
 616
 617 2019-08-13  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 620         declare.
 621         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 622         call tui_erase_exec_info_content.
 623         (tui_clear_exec_info_content): Rename from
 624         tui_erase_exec_info_content.
 625         (tui_clear_exec_info_content): Delete.
 626
 627 2019-08-13  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-winsource.h (struct tui_source_window_base)
 630         <show_exec_info_content>: Declare.
 631         (tui_show_exec_info_content): Don't declare.
 632         * tui/tui-winsource.c
 633         (tui_source_window_base::show_exec_info_content): Rename from
 634         tui_show_exec_info_content.
 635         (tui_source_window_base::update_exec_info): Update.
 636
 637 2019-08-13  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 640         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 641         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 642         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 643         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 644         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 645         ... here.
 646
 647 2019-08-13  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-winsource.h (struct tui_source_window_base)
 650         <update_exec_info>: Declare.
 651         (tui_update_exec_info): Don't declare.
 652         * tui/tui-winsource.c (tui_update_source_window_as_is)
 653         (tui_source_window_base::refresh_all)
 654         (tui_update_all_breakpoint_info): Update.
 655         (tui_source_window_base::update_exec_info): Rename from
 656         tui_update_exec_info.
 657         * tui/tui-stack.c (tui_show_frame_info): Update.
 658
 659 2019-08-13  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-winsource.h (struct tui_source_window_base)
 662         <set_exec_info_content>: Declare.
 663         (tui_set_exec_info_content): Don't declare.
 664         * tui/tui-winsource.c
 665         (tui_source_window_base::set_exec_info_content): Rename from
 666         tui_set_exec_info_content.
 667         (tui_update_exec_info): Update.
 668
 669 2019-08-13  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-winsource.h (struct tui_source_window_base)
 672         <show_source_content>: Declare.
 673         (tui_show_source_content): Don't declare.
 674         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 675         (tui_source_window_base::show_source_content): Rename from
 676         tui_show_source_content.
 677         (tui_source_window_base::refresh_all): Update.
 678         * tui/tui-layout.c (show_source_disasm_command)
 679         (show_source_or_disasm_and_command): Update.
 680
 681 2019-08-13  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-winsource.c (tui_erase_source_content)
 684         (tui_show_source_content, tui_source_window_base::refresh_all):
 685         Update.
 686         * tui/tui-wingeneral.h
 687         (tui_check_and_display_highlight_if_needed): Don't declare.
 688         * tui/tui-wingeneral.c
 689         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 690         check_and_display_highlight_if_needed.
 691         * tui/tui-win.c (tui_rehighlight_all)
 692         (tui_win_info::make_visible_with_new_height): Update.
 693         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 694         (tui_data_window::erase_data_content)
 695         (tui_data_window::display_all_data): Update.
 696         * tui/tui-data.h (struct tui_win_info)
 697         <check_and_display_highlight_if_needed>: Declare.
 698
 699 2019-08-13  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-win.c (tui_resize_all): Call
 702         tui_delete_invisible_windows.
 703         * tui/tui-layout.c (show_layout): Call
 704         tui_delete_invisible_windows.
 705         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 706         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 707
 708 2019-08-13  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 711         tui_add_win_to_layout.
 712
 713 2019-08-13  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 716         * tui/tui-layout.c (tui_default_win_height): Now static.
 717
 718 2019-08-13  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 721         single switch.
 722         (show_source_disasm_command, show_source_or_disasm_and_command):
 723         Don't check current layout.
 724
 725 2019-08-13  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-wingeneral.c (make_all_visible): Remove.
 728         (tui_make_all_invisible): Simplify.
 729         * tui/tui-layout.c (tui_make_all_invisible): Move from
 730         tui-wingeneral.c; simplify.
 731         (show_layout): Hoist call to tui_make_all_invisible.
 732         (show_data): Don't call tui_make_all_invisible.
 733
 734 2019-08-13  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 737         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 738
 739 2019-08-13  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 742         tui-data.c.
 743         (show_source_disasm_command, show_data)
 744         (show_source_or_disasm_and_command): Don't use
 745         tui_set_current_layout_to.
 746         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 747         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 748         tui-layout.c.
 749         (tui_set_current_layout_to): Remove.
 750
 751 2019-08-13  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-layout.c (tui_set_layout): Update.
 754         * tui/tui-data.h (struct tui_layout_def): Remove.
 755         (tui_layout_def): Don't declare.
 756         * tui/tui-data.c (layout_def): Remove.
 757         (tui_layout_def): Remove.
 758
 759 2019-08-13  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-winsource.h (struct tui_source_window_base)
 762         <clear_detail>: No longer "override".
 763         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 764         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 765         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 766         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 767         Remove.
 768         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 769
 770 2019-08-13  Tom Tromey  <tromey@adacore.com>
 771
 772         * tracepoint.c: Don't include readline.h or history.h.
 773
 774 2019-08-12  Tom Tromey  <tom@tromey.com>
 775
 776         * configure: Rebuild.
 777         * configure.ac: Check for readline 7.
 778         * NEWS: Mention readline 7 requirement.
 779         * README: Update.
 780
 781 2019-08-12  Tom Tromey  <tom@tromey.com>
 782
 783         * mingw-hdep.c (gdb_select): Remove readline hack.
 784
 785 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 786
 787         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 788         when the function fails.
 789
 790 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 791
 792         * s390-tdep.c (s390_type_align): New function.
 793         (s390_gdbarch_init): Set it as type_align gdbarch method.
 794
 795 2019-08-09  Tom de Vries  <tdevries@suse.de>
 796
 797         PR gdb/24591
 798         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 799         pc_low with relocation offset.
 800
 801 2019-08-07  Tom Tromey  <tromey@adacore.com>
 802
 803         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 804         (print_frame_args): Update.
 805         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 806         Update.
 807         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 808         * frame.h (struct frame_arg): Add initializers.
 809         <error>: Now a unique_xmalloc_ptr.
 810
 811 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 812
 813         * NEWS: Expand the Pointer Authentication entry.
 814         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 815         (aarch64_frame_unmask_lr): ... to this.
 816         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 817         Call aarch64_frame_unmask_lr.
 818         * frame.c (struct frame_info): Add "masked" variable.
 819         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 820         (fprint_frame): Check for masked pc.
 821         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 822         declarations.
 823         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 824         * stack.c (print_frame): Check for masked pc.
 825
 826 2019-08-06  Tom Tromey  <tom@tromey.com>
 827
 828         * stabsread.c (patch_block_stabs, read_one_struct_field)
 829         (read_enum_type): Use obstack_strndup.
 830         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 831         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 832         * dwarf2read.c (guess_full_die_structure_name)
 833         (anonymous_struct_prefix): Use obstack_strndup.
 834         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 835         * c-exp.y (yylex): Use obstack_strndup.
 836         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 837         (write_var_or_type): Use obstack_strndup.
 838
 839 2019-08-06  Tom Tromey  <tom@tromey.com>
 840
 841         * symfile.c (reread_symbols): Use obstack_strdup.
 842         * stabsread.c (read_type): Use obstack_strdup.
 843         * gdb_obstack.h (obstack_strdup): New overload.
 844         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 845         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 846         (dwarf2_canonicalize_name): Use obstack_strdup.
 847         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 848         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 849         Use obstack_strdup.
 850
 851 2019-08-06  Tom Tromey  <tom@tromey.com>
 852
 853         * gdb_obstack.h (obstack_strdup): Define.
 854         * gdb_obstack.c (obstack_strdup): Don't define.
 855
 856 2019-08-06  Tom Tromey  <tom@tromey.com>
 857
 858         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 859         obstack_strdup.
 860         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 861         obstack_strdup.
 862         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 863         * stabsread.c (common_block_start): Use obstack_strdup.
 864         * objfiles.c (set_objfile_main_name, objfile): Use
 865         obstack_strdup.
 866         * namespace.c (add_using_directive): Use obstack_strdup.
 867         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 868         * jit.c (finalize_symtab): Use obstack_strdup.
 869         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 870         (guess_partial_die_structure_name, partial_die_info::fixup)
 871         (dwarf2_name): Use obstack_strdup.
 872         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 873         obstack_strdup.
 874         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 875         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 876         obstack_strdup.
 877         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 878
 879 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 880
 881         * unittests/help-doc-selftests.c: New file.
 882         * Makefile.in: Add the new file.
 883
 884 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 885
 886         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 887         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 888         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 889         the trailing '.' is not output, and the first character is uppercased.
 890         (print_help_for_command): Update call to print_doc_line.
 891         (print_doc_of_command): Likewise.
 892         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 893         * cli/cli-option.c (append_indented_doc): Do not append newline.
 894         (build_help_option): Append newline after first appended_indented_doc
 895         only if a second call is done.
 896         (build_help): Append 2 new lines before each option, except the first
 897         one.
 898         * compile/compile.c (_initialize_compile): Add new lines after
 899         %OPTIONS%, when not at the end of the help.
 900         Change help doc or code
 901         producing the help doc to respect the invariants.
 902         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 903         Also removed the new line after 'Options:', as all other commands
 904         do not put an empty line between 'Options:' and the first option.
 905         * printcmd.c (_initialize_printcmd): Likewise.
 906         * stack.c (_initialize_stack): Likewise.
 907         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 908         incorrectly telling COMMAND is optional.
 909         * ada-lang.c (_initialize_ada_language): Change help doc or code
 910         producing the help doc to respect the invariants.
 911         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 912         * breakpoint.c (_initialize_breakpoint): Likewise.
 913         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 914         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 915         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 916         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 917         _initialize_cli_style): Likewise.
 918         * corelow.c (core_target_info): Likewise.
 919         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 920         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 921         * filesystem.c (_initialize_filesystem): Likewise.
 922         * frame.c (_initialize_frame): Likewise.
 923         * gnu-nat.c (add_task_commands): Likewise.
 924         * infcall.c (_initialize_infcall): Likewise.
 925         * infcmd.c (_initialize_infcmd): Likewise.
 926         * interps.c (_initialize_interpreter): Likewise.
 927         * language.c (_initialize_language): Likewise.
 928         * linux-fork.c (_initialize_linux_fork): Likewise.
 929         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 930         * maint.c (_initialize_maint_cmds): Likewise.
 931         * memattr.c (_initialize_mem): Likewise.
 932         * printcmd.c (_initialize_printcmd): Likewise.
 933         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 934         _RegEx): Likewise.
 935         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 936         * record-btrace.c (_initialize_record_btrace): Likewise.
 937         * record-full.c (_initialize_record_full): Likewise.
 938         * record.c (_initialize_record): Likewise.
 939         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 940         * regcache.c (_initialize_regcache): Likewise.
 941         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 942         _initialize_remote): Likewise.
 943         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 944         * serial.c (_initialize_serial): Likewise.
 945         * skip.c (_initialize_step_skip): Likewise.
 946         * source.c (_initialize_source): Likewise.
 947         * stack.c (_initialize_stack): Likewise.
 948         * symfile.c (_initialize_symfile): Likewise.
 949         * symtab.c (_initialize_symtab): Likewise.
 950         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 951         * top.c (init_main): Likewise.
 952         * tracefile-tfile.c (tfile_target_info): Likewise.
 953         * tracepoint.c (_initialize_tracepoint): Likewise.
 954         * tui/tui-win.c (_initialize_tui_win): Likewise.
 955         * utils.c (add_internal_problem_command): Likewise.
 956         * valprint.c (value_print_option_defs): Likewise.
 957
 958 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 959
 960         PR build/24886
 961         * configure.ac: Drop enable-libmcheck support.
 962         * configure, config.in: Rebuild.
 963         * libmcheck.m4: Remove.
 964         * acinclude.m4: Don't include it.
 965         * Makefile.in: Don't distribute it.
 966         * top.c (print_gdb_configuration): Don't mention it.
 967
 968 2019-08-06  Tom Tromey  <tom@tromey.com>
 969
 970         * utils.c (set_output_style): Sometimes pass stream to
 971         emit_style_escape.
 972         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 973         * record-btrace.c (btrace_insn_history): Update.
 974         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 975         method.
 976         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 977         Update initializers.
 978         <m_uiout>: New field.
 979         <m_di>: Move lower.
 980         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 981         Remove "uiout" parameter.
 982         (dump_insns): Update.
 983         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 984         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 985
 986 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 987
 988         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 989         (error_in_psymtab_expansion): Likewise.
 990         (lookup_symbol_via_quick_fns): Likewise.
 991         (basic_lookup_transparent_type_quick): Likewise.
 992         (basic_lookup_transparent_type_1): Likewise.
 993
 994 2019-08-06  Tom Tromey  <tromey@adacore.com>
 995
 996         * source.c (last_source_error): Now bool.
 997         (print_source_lines_base): Make "noprint" bool.  Only open
 998         source file when last_source_visited changes.
 999
1000 2019-08-06  Tom Tromey  <tromey@adacore.com>
1001
1002         * annotate.c (annotate_source_line): Use g_source_cache.
1003         * source-cache.c (source_cache::get_plain_source_lines): Change
1004         parameters.  Populate m_offset_cache.
1005         (source_cache::ensure): New method.
1006         (source_cache::get_line_charpos): New method.
1007         (extract_lines): Move lower.  Change parameters.
1008         (source_cache::get_source_lines): Move lower.
1009         * source-cache.h (class source_cache): Update comment.
1010         <get_line_charpos>: New method.
1011         <get_source_lines>: Update comment.
1012         <clear>: Clear m_offset_cache.
1013         <get_plain_source_lines>: Change parameters.
1014         <ensure>: New method
1015         <m_offset_cache>: New member.
1016         * source.c (forget_cached_source_info_for_objfile): Update.
1017         (info_source_command): Use g_source_cache.
1018         (find_source_lines, open_source_file_with_line_charpos): Remove.
1019         (print_source_lines_base, search_command_helper): Use g_source_cache.
1020         * source.h (open_source_file_with_line_charpos): Don't declare.
1021         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1022         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1023         Use g_source_cache.
1024
1025 2019-08-06  Tom Tromey  <tromey@adacore.com>
1026
1027         * source-cache.c (source_cache::get_plain_source_lines):
1028         Remove "first_line" and "last_line" parameters.
1029         (source_cache::get_source_lines): Cache plain text.
1030         * source-cache.h (class source_cache)
1031         <get_plain_source_lines>: Update.
1032
1033 2019-08-06  Tom Tromey  <tromey@adacore.com>
1034
1035         * source-cache.c (extract_lines): No longer a method.
1036         Changed type of parameter.  Include final newline.
1037         (selftests::extract_lines_test): New function.
1038         (_initialize_source_cache): Likewise.
1039         * source-cache.h (class source_cache)
1040         <extract_lines>: Don't declare.
1041
1042 2019-08-06  Tom Tromey  <tromey@adacore.com>
1043
1044         * breakpoint.c (init_breakpoint_sal): Update.
1045         (breakpoint): Update.
1046         * breakpoint.h (struct breakpoint) <filter>: Now a
1047         unique_xmalloc_ptr.
1048
1049 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1050
1051         * NEWS: Mention dictionary access on blocks.
1052         * python/py-block.c (blpy_getitem): New function.
1053         (block_object_as_mapping): New struct.
1054         (block_object_type): Use new struct for tp_as_mapping field.
1055
1056 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1057
1058         * objfiles.h (objfile): Add a comment describing partial symbols.
1059
1060 2019-08-05  Tom Tromey  <tromey@adacore.com>
1061
1062         * compile/compile.c (_initialize_compile): Use _(), not N_().
1063         * thread.c (_initialize_thread): Use _(), not N_().
1064         * stack.c (_initialize_stack): Use _(), not N_().
1065         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1066
1067 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1068
1069         * dwarf2read.c (struct dw2_symtab_iterator):
1070         <want_specific_block>: Remove.
1071         <block_index>: Change type to gdb::optional.
1072         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1073         change type of BLOCK_INDEX parameter to gdb::optional.
1074         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1075         (dw2_lookup_symbol): Don't pass argument for
1076         WANT_SPECIFIC_BLOCK.
1077         (dw2_expand_symtabs_for_function): Don't pass argument for
1078         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1079         (class dw2_debug_names_iterator)
1080         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1081         parameter, change BLOCK_INDEX type to gdb::optional.
1082         <m_want_specific_block>: Remove.
1083         <m_block_index>: Change type to gdb::optional.
1084         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1085         gdb::optional.  Re-write in function of gdb::optional.
1086         (dw2_debug_names_lookup_symbol): Don't pass argument for
1087         WANT_SPECIFIC_BLOCK.
1088         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1089         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1090         BLOCK_INDEX.
1091
1092 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1093
1094         * NEWS: Mention changes to "info sources" command.
1095
1096 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1097
1098         * symtab.c (filename_partial_match_opts): New struct type.
1099         (struct output_source_filename_data): New members
1100         regexp, c_regexp, partial_match.
1101         (output_source_filename): Use new members to decide to print file.
1102         (info_sources_option_defs): New variable.
1103         (make_info_sources_options_def_group, print_info_sources_header,
1104         info_sources_command_completer):
1105         New functions.
1106         (info_sources_command): Read new optional arguments.
1107         (_initialize_symtab): Update info sources help.
1108
1109 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1110
1111         * ada-lang.c (exception_support_info_v0): Renamed from...
1112         (default_exception_support_info): ... this.  Create new
1113         definition for v1.
1114         (ada_has_this_exception_support): Look up catch_handlers_sym.
1115         (ada_exception_support_info_sniffer): Try v0 after default.
1116
1117 2019-08-01  Tom Tromey  <tromey@adacore.com>
1118
1119         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1120         gdbarch.h.
1121
1122 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1123
1124         * s12z-tdep.c: Fix include path for s12z-opc.h.
1125
1126 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1127
1128         * NEWS: Require GNU make 3.82.
1129
1130 2019-07-16  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1133         declare.
1134
1135 2019-07-30  Tom Tromey  <tromey@adacore.com>
1136
1137         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1138
1139 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1140
1141         * printcmd.c (print_address_symbolic): Print negative offsets.
1142         (build_address_symbolic): Force signed arithmetic when computing
1143         offset.
1144
1145 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1146
1147         PR/24474: Add a function to lookup static variables.
1148         * NEWS: Mention this new function.
1149         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1150         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1151         * python/python.c (python_GdbMethods): Add new function.
1152
1153 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1154
1155         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1156         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1157         (objfpy_lookup_static_symbol): New function.
1158         (objfile_object_methods): Add new functions.
1159
1160 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1161
1162         * NEWS: Mention 'set|show print frame-info'.  Mention new
1163         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1164         backtrace argument.  Mention that python frame filtering code
1165         is now consistent with what 'backtrace' command prints.
1166
1167 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1168
1169         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1170         comments.
1171         (print_frame_info_auto, print_frame_info_source_line,
1172         print_frame_info_location, print_frame_info_source_and_location,
1173         print_frame_info_location_and_address, print_frame_info_short_location):
1174         New declarations.
1175         (struct frame_print_options): New member print_frame_info.
1176         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1177         * stack.h (get_user_print_what_frame_info): New declaration.
1178         (frame_show_address): New declaration.
1179         * stack.c (print_frame_arguments_choices): New value 'presence'.
1180         (print_frame_info_auto, print_frame_info_source_line,
1181         print_frame_info_location, print_frame_info_source_and_location,
1182         print_frame_info_location_and_address, print_frame_info_short_location,
1183         print_frame_info_choices, print_frame_info_print_what): New definitions.
1184         (print_frame_args): Only print dots for args if print frame-arguments
1185         is 'presence'.
1186         (frame_print_option_defs): New element for "frame-info".
1187         (get_user_print_what_frame_info): New function.
1188         (frame_show_address): Make non static.  Move comment to stack.h.
1189         (print_frame_info_to_print_what): New function.
1190         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1191         to decide what to print.
1192         (backtrace_command_1): Handle the new print_frame_arguments_presence
1193         value.
1194         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1195         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1196         (py_print_frame): In non-mi mode, use LOCATION as default for
1197         print_what, similarly to frame information printed directly by
1198         backtrace command. Handle frame-info user option in non MI mode.
1199
1200 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1201
1202         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1203         Add case for debugging 32-bit target on 64-bit host.  Revise
1204         comment.
1205
1206 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1207
1208         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1209         instead of find_function_entry_range_from_pc.
1210
1211 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1212
1213         * stack.c (find_frame_funname): Remove code which preferred
1214         minsym over symtab sym in "certain pathological cases".
1215
1216         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1217         parameter.  Change type of "do_demangle" to bool.
1218         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1219         Pass suitable "prefer_sym_over_minsym" flag to
1220         build_address_symbolic().  Don't output "+" for negative offsets.
1221         * printcmd.c (print_address_symbolic): Update invocation of
1222         build_address_symbolic to include a "prefer_sym_over_minsym"
1223         flag.
1224         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1225         Restrict cases in which use of minimal symbol is preferred to that
1226         of a found symbol.  Update comments.
1227
1228         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1229         for entry pc when entry pc is out of range for that FDE.
1230
1231 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1232
1233         PR gdb/24839:
1234         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1235         type.
1236
1237 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1238
1239         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1240         this function's Python signature.
1241
1242
1243 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1244
1245         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1246         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1247         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1248         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1249         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1250
1251
1252 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1253
1254         * h8300-tdep.c (h8300_register_name_common): New.
1255         h8300_register_name): Use h8300_register_name_common.
1256         (h8300s_register_name): Likewise.
1257         (h8300sx_register_name): Likewise.
1258         (h8300h_register_nam): New.
1259         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1260
1261
1262 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1263
1264         * arm-tdep.c (arm_skip_cmse_entry): New function.
1265         (arm_is_sgstubs_section): New function.
1266         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1267
1268 2019-07-22  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1271         Don't self-assign.
1272
1273 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1274
1275         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1276         type_print.
1277
1278 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1281         so that GDB doesn't match any msymbols when searching in the
1282         TYPES_DOMAIN.
1283         (print_symbol_info): Print using typedef_print or type_print based
1284         on the type of the symbol.  Add updated FIXME comment moved from...
1285         (_initialize_symtab): ... move and update FIXME comment to above.
1286
1287 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * NEWS: Mention adding -q option to "info types".
1290         * symtab.c (struct info_types_options): New struct.
1291         (info_types_options_defs): New variable.
1292         (make_info_types_options_def_group): New function.
1293         (info_types_command): Use gdb::option framework to parse options.
1294         (info_types_command_completer): New function.
1295         (_initialize_symtab): Extend the help text on "info types" and
1296         register command completer.
1297
1298 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1299
1300         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1301         (lookup_symbol_in_objfile): Change int to block_enum and add a
1302         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1303
1304 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1305
1306         * MAINTAINERS (Write After Approval): Add self.
1307
1308 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1311         instruction to the dummy code region.
1312
1313 2019-07-19  Tom Tromey  <tromey@adacore.com>
1314
1315         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1316         (ARGSUSED, PARAMS, __func__): Remove rules.
1317
1318 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1319
1320         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1321         * features/arm/arm-with-iwmmxt.c: Remove.
1322         * features/arm/arm-with-iwmmxt.xml: Remove.
1323         * features/arm/arm-with-m-fpa-layout.c: Remove.
1324         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1325         * features/arm/arm-with-m-vfp-d16.c: Remove.
1326         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1327         * features/arm/arm-with-m.c: Remove.
1328         * features/arm/arm-with-m.xml: Remove.
1329         * features/arm/arm-with-neon.c: Remove.
1330         * features/arm/arm-with-neon.xml: Remove.
1331         * features/arm/arm-with-vfpv2.c: Remove.
1332         * features/arm/arm-with-vfpv2.xml: Remove.
1333         * features/arm/arm-with-vfpv3.c: Remove.
1334         * features/arm/arm-with-vfpv3.xml: Remove.
1335
1336 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1337
1338         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1339
1340 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1341
1342         * arch/aarch32.c (aarch32_create_target_description): Create
1343         target descriptions using features.
1344         * arch/arm.c (arm_create_target_description)
1345         (arm_create_mprofile_target_description): Likewise.
1346         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1347
1348 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1349
1350         * Makefile.in: Add new files.
1351         * aarch32-tdep.c: New file.
1352         * aarch32-tdep.h: New file.
1353         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1354         Call aarch32_read_description.
1355         * arch/aarch32.c: New file.
1356         * arch/aarch32.h: New file.
1357         * arch/arm.c (arm_create_target_description)
1358         (arm_create_mprofile_target_description): New function.
1359         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1360         (arm_create_target_description)
1361         (arm_create_mprofile_target_description): New declaration.
1362         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1363         read_description functions.
1364         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1365         Likewise.
1366         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1367         * arm-tdep.c (tdesc_arm_list): New variable.
1368         (arm_register_g_packet_guesses): Call create description functions.
1369         (arm_read_description) (arm_read_mprofile_description): New
1370         function.
1371         * arm-tdep.h (arm_read_description)
1372         (arm_read_mprofile_description): Add declaration.
1373         * configure.tgt: Add new files.
1374
1375 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1376
1377         * top.c (new_ui_command): Open specified terminal just once.
1378
1379 2019-07-18  Tom Tromey  <tromey@adacore.com>
1380
1381         * symtab.c (main_name): Constify return type.
1382         * symfile.c (set_initial_language): Update.
1383         * symtab.h (main_name): Constify return type.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-winsource.c (tui_update_source_window)
1388         (tui_update_source_window_as_is)
1389         (tui_update_source_windows_with_line): Remove return.
1390         * tui/tui-disasm.c (tui_show_disassem)
1391         (tui_show_disassem_and_update_source): Remove return.
1392         * tui/tui.c (tui_reset): Remove return.
1393         * tui/tui-wingeneral.c
1394         (tui_check_and_display_highlight_if_needed): Remove return.
1395
1396 2019-07-17  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1399
1400 2019-07-17  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-winsource.h (struct tui_exec_info_window)
1403         (struct tui_source_window_base): Move from tui-data.h.
1404         * tui/tui-winsource.c: Move many method definitions from
1405         elsewhere.  Remove "structuring" comments.
1406         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1407         (tui_source_window_base::refresh_window): Move to
1408         tui-winsource.c.
1409         * tui/tui-win.c (tui_source_window_base::refresh_all)
1410         (tui_source_window_base::update_tab_width)
1411         (tui_source_window_base::set_new_height)
1412         (tui_source_window_base::do_make_visible_with_new_height): Move to
1413         tui-winsource.c.
1414         * tui/tui-source.h: Update.
1415         * tui/tui-source.c (tui_source_window_base::reset): Move to
1416         tui-winsource.c.
1417         * tui/tui-disasm.h: Update.
1418         * tui/tui-data.h (struct tui_exec_info_window): Move to
1419         tui-winsource.h.
1420         (struct tui_source_window_base): Likewise.
1421         * tui/tui-data.c (tui_source_window_base::clear_detail)
1422         (tui_source_window_base, ~tui_source_window_base): Move to
1423         tui-winsource.c.
1424
1425 2019-07-17  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-win.c (tui_resize_all)
1428         (tui_source_window_base::update_tab_width)
1429         (tui_adjust_win_heights): Update.
1430         (tui_win_info::make_invisible_and_set_new_height): Rename from
1431         make_invisible_and_set_new_height.
1432         * tui/tui-data.h (struct tui_win_info)
1433         <make_invisible_and_set_new_height>: New method.
1434
1435 2019-07-17  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui.c: Update.
1438         * tui/tui-source.h (struct tui_source_window): Move from
1439         tui-data.h.
1440         * tui/tui-layout.c: Update.
1441         * tui/tui-disasm.c: Update.
1442         * tui/tui-data.h (struct tui_source_window): Move to
1443         tui-source.h.
1444
1445 2019-07-17  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1448         tui-data.h.
1449         * tui/tui-data.h (struct tui_disasm_window): Move to
1450         tui-disasm.h.
1451
1452 2019-07-17  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-regs.h (struct tui_data_item_window): Move from
1455         tui-data.h.
1456         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1457         * tui/tui-data.h (struct tui_data_item_window): Move to
1458         tui-regs.h.
1459         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1460
1461 2019-07-17  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui.c: Update.
1464         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1465         (tui_cmd_window::max_height): Move to tui-command.c.
1466         * tui/tui-layout.c: Update.
1467         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1468         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1469         tui-command.c.
1470         * tui/tui-command.h (struct tui_cmd_window): Move from
1471         tui-data.h.
1472         * tui/tui-command.c: Remove "structuring" comments.
1473         (tui_cmd_window::clear_detail)
1474         (tui_cmd_window::do_make_visible_with_new_height)
1475         (tui_cmd_window::max_height): Move from elsewhere.
1476
1477 2019-07-17  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1480         Now static.
1481         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1482         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1483
1484 2019-07-17  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui.c: Update.
1487         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1488         tui-regs.c.
1489         * tui/tui-windata.h: Remove file.
1490         * tui/tui-windata.c: Remove file.
1491         * tui/tui-win.c (tui_data_window::set_new_height)
1492         (tui_data_window::do_make_visible_with_new_height): Move to
1493         tui-regs.c.
1494         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1495         * tui/tui-regs.c: Remove "structuring" comments.
1496         (tui_data_window::first_data_item_displayed)
1497         (tui_data_window::delete_data_content_windows)
1498         (tui_data_window::erase_data_content)
1499         (tui_data_window::display_all_data)
1500         (tui_data_window::refresh_all)
1501         (tui_data_window::do_scroll_vertical)
1502         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1503         (tui_data_window::do_make_visible_with_new_height)
1504         (tui_data_window::refresh_window): Move from elsewhere.
1505         (_initialize_tui_regs): Move to end of file.
1506         * tui/tui-layout.c: Update.
1507         * tui/tui-hooks.c: Update.
1508         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1509         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1510         tui-regs.c.
1511         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1512
1513 2019-07-17  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1516         seen.
1517
1518 2019-07-17  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-win.c (tui_source_window_base::set_new_height)
1521         (tui_source_window_base::do_make_visible_with_new_height): Use
1522         m_has_locator field directly.
1523         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1524         method.
1525         (struct tui_source_window_base) <has_locator>: Likewise.
1526
1527 2019-07-17  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1530         Don't declare.
1531         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1532         Remove.
1533         * tui/tui-win.c (tui_source_window_base::set_new_height)
1534         (tui_source_window_base::set_new_height)
1535         (make_invisible_and_set_new_height)
1536         (tui_source_window_base::do_make_visible_with_new_height)
1537         (tui_source_window_base::do_make_visible_with_new_height):
1538         Update.
1539         * tui/tui-layout.c (show_source_disasm_command, show_data)
1540         (show_source_or_disasm_and_command): Update.
1541         * tui/tui-layout.c (show_layout): Update.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-layout.c (make_data_window): Remove.
1546         (show_data): Unify creation and re-initialization cases.
1547
1548 2019-07-17  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-layout.c (make_source_window, make_disasm_window):
1551         Remove.
1552         (show_data): Unify creation and re-initialization cases.
1553
1554 2019-07-17  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-layout.c (make_command_window): Remove.
1557         (show_source_disasm_command, show_source_or_disasm_and_command):
1558         Unify creation and re-initialization cases.
1559
1560 2019-07-17  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1563         creation and re-initialization cases.
1564
1565 2019-07-17  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-regs.c (tui_get_register): Return void.
1568
1569 2019-07-17  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1572         Simplify.
1573
1574 2019-07-17  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1577         resetting.
1578
1579 2019-07-17  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1582         * tui/tui-regs.c (tui_reg_layout): New function.
1583         (tui_show_registers, tui_reg_command): Use it.
1584         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1585         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1586         parameters.
1587         (tui_layout_command): Remove.
1588
1589 2019-07-17  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-layout.h (tui/tui-layout): Return void.
1592         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1593
1594 2019-07-17  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-layout.c (show_source_disasm_command, show_data):
1597         Update.
1598         (reset_locator): Remove.
1599         (show_source_or_disasm_and_command): Update.
1600
1601 2019-07-17  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui-source.c (tui_source_window_base::reset): Remove
1604         win_type parameter.
1605         * tui/tui-layout.c (make_command_window, make_source_window)
1606         (make_disasm_window, make_data_window)
1607         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1608         (reset_locator, show_source_or_disasm_and_command): Update.
1609         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1610         win_type parameter.
1611         (struct tui_source_window_base) <reset>: Likewise.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-layout.c (show_source_disasm_command): Use
1616         reset_locator.
1617         (reset_locator): New function.
1618         (init_and_make_win): Remove.
1619         (show_source_or_disasm_and_command): Use reset_locator.
1620
1621 2019-07-17  Tom Tromey  <tom@tromey.com>
1622
1623         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1624         condition.
1625         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1626         Remove condition.
1627         * tui/tui-source.c (tui_source_window_base::reset): New method.
1628         * tui/tui-layout.c (make_command_window): Don't call
1629         init_and_make_win.
1630         (make_source_window, make_disasm_window): Don't call
1631         make_source_or_disasm_window.
1632         (make_data_window): Don't call init_and_make_win.  Change calling
1633         convention.
1634         (show_source_disasm_command, show_data): Simplify.
1635         (make_source_or_disasm_window): Remove.
1636         (show_source_or_disasm_and_command): Simplify.
1637         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1638         (struct tui_source_window_base) <reset>: Likewise.
1639         <execution_info>: Remove initializer.
1640         * tui/tui-data.c (tui_source_window_base): Initialize
1641         execution_info.
1642
1643 2019-07-17  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1646         variable.
1647
1648 2019-07-17  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui.c (tui_rl_other_window): Update.
1651         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1652         superclass method first.  Always iterate over regs_content.
1653         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1654         method.
1655         * tui/tui-win.c (tui_set_focus_command): Update.
1656
1657 2019-07-17  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-win.c (tui_set_focus_command): Rename from
1660         tui_set_focus.  Call tui_enable.
1661         (tui_set_focus_command): Remove.
1662
1663 2019-07-17  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1666         refresh_window.
1667         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1668         touchwin.
1669         (tui_data_window::refresh_window): Call refresh_window on data
1670         items.  Always call superclass refresh_window.
1671         (tui_win_info::refresh): Remove.
1672         (tui_source_window_base::refresh_window): Update.
1673         (tui_refresh_all): Update.
1674         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1675         refresh_window.
1676         (show_source_or_disasm_and_command): Likewise.
1677         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1678         (struct tui_source_window_base) <refresh>: Likewise.
1679
1680 2019-07-17  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-winsource.c (tui_clear_source_content)
1683         (tui_show_source_content): Update.
1684         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1685         whether content is empty.
1686         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1687         Remove.
1688
1689 2019-07-17  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1692         window's contents.
1693         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1694         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1695
1696 2019-07-17  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1699         (struct tui_data_item_window): Update.
1700
1701 2019-07-17  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1704         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1705         defines.
1706
1707 2019-07-17  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-winsource.h (tui_erase_source_content)
1710         (tui_clear_source_content): Remove "display_prompt" parameter.
1711         * tui/tui-winsource.c (tui_update_source_window_as_is)
1712         (tui_update_source_windows_with_addr): Update.
1713         (tui_clear_source_content): Remove "display_prompt" parameter.
1714         (tui_erase_source_content): Likewise.  Simplify.
1715         (tui_show_source_content): Update.
1716         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1717         * tui/tui-stack.c (tui_show_frame_info): Update.
1718         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1719         Remove defines.
1720
1721 2019-07-17  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1724         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1725         parameter.
1726         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1727         parameter.
1728
1729 2019-07-17  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-winsource.c (tui_clear_source_content)
1732         (tui_show_source_content, tui_show_exec_info_content)
1733         (tui_clear_exec_info_content): Update.
1734         * tui/tui-stack.c (tui_show_locator_content): Update.
1735         (tui_show_frame_info): Update.
1736         * tui/tui-source.h (tui_source_window): Don't declare.
1737         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1738         from tui_source_is_displayed.
1739         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1740         Remove field.
1741         (struct tui_source_window_base) <content_in_use>: New field.  Now
1742         bool.
1743         (struct tui_source_window) <showing_source_p>: New method.
1744         (TUI_SRC_WIN): Change cast.
1745         * tui/tui-data.c (tui_initialize_static_data): Update.
1746
1747 2019-07-17  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1750         location_matches_p.
1751         * tui/tui-source.c (tui_source_window::location_matches_p): New
1752         method.
1753         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1754         method.
1755         * tui/tui-data.h (struct tui_source_window_base)
1756         <location_matches_p>: New method.
1757         (struct tui_source_window, struct tui_disasm_window)
1758         <location_matches_p>: Likewise.
1759
1760 2019-07-17  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-win.c (tui_set_win_height_command): Rename from
1763         tui_set_win_height.
1764         (tui_set_win_height_command): Remove.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-source.c (tui_source_window): New constructor.  Add
1769         observer.
1770         (~tui_source_window): New destructor.
1771         (tui_source_window::style_changed): New method.
1772         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1773         (tui_attach_detach_observers): Update.
1774         * tui/tui-data.h (struct tui_source_window): Make constructor not
1775         inline.  Add destructor.
1776         (struct tui_source_window) <style_changed>: New method.
1777         <m_observable>: New member.
1778
1779 2019-07-17  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1782         * tui/tui-win.c (tui_resize_all): Fix typo.
1783
1784 2019-07-17  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1787         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1788         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1789         * tui/tui-win.c (window_name_completer): Use foreach.
1790         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1791         (update_tab_width): Likewise.
1792         * tui/tui-layout.c (show_layout): Update.
1793         * tui/tui-data.h (class tui_window_iterator): New.
1794         (struct all_tui_windows): New.
1795         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1796
1797 2019-07-17  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1800         parameter.  Don't reference globals.
1801         (tui_reg_command): Update.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-regs.c (tui_show_registers): Simplify.
1806
1807 2019-07-17  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-regs.c (tui_show_registers): Update.
1810         (tui_show_register_group): Add win_info parameter.
1811
1812 2019-07-17  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1815         Rename from tui_display_reg_element_at_line.
1816         (tui_data_window::display_registers_from_line): Update.
1817         * tui/tui-data.h (struct tui_data_window)
1818         <display_reg_element_at_line>: New method.
1819
1820 2019-07-17  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-regs.h (tui_display_registers_from)
1823         (tui_display_registers_from_line): Don't declare.
1824         * tui/tui-windata.c (tui_data_window::display_all_data)
1825         (tui_data_window::refresh_all)
1826         (tui_data_window::do_scroll_vertical): Update.
1827         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1828         from tui_display_registers_from.
1829         (tui_display_reg_element_at_line): Update.
1830         (tui_data_window::display_registers_from_line): Rename from
1831         tui_display_registers_from_line.
1832         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1833         display_registers_from_line>: New methods.
1834
1835 2019-07-17  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1838         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1839         from tui_erase_data_content.
1840         (tui_data_window::display_all_data)
1841         (tui_data_window::refresh_all)
1842         (tui_data_window::do_scroll_vertical): Update.
1843         * tui/tui-regs.c (tui_show_registers): Update.
1844         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1845         New method.
1846
1847 2019-07-17  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1850         declare.
1851         * tui/tui-windata.c
1852         (tui_data_window::delete_data_content_windows): Rename from
1853         tui_delete_data_content_windows.
1854         (tui_data_window::display_all_data)
1855         (tui_data_window::do_scroll_vertical): Update.
1856         * tui/tui-data.h (struct tui_data_window)
1857         <delete_data_content_windows>: New method.
1858
1859 2019-07-17  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1862         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1863
1864 2019-07-17  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1867         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1868         from tui_display_all_data.
1869         * tui/tui-win.c
1870         (tui_data_window::do_make_visible_with_new_height): Update.
1871         * tui/tui-regs.c (tui_show_registers): Update.
1872         * tui/tui-layout.c (tui_set_layout): Update.
1873         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1874         method.
1875
1876 2019-07-17  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1879         * tui/tui-windata.c (tui_display_data_from): Remove.
1880         (tui_data_window::refresh_all): Update.
1881
1882 2019-07-17  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1885         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1886         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1887         tui_display_registers_from_line.
1888         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1889         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1890         "force_display" parameter.
1891
1892 2019-07-17  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1895         declare.
1896         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1897         Rename from tui_first_reg_element_no_inline.
1898         (tui_display_reg_element_at_line)
1899         (tui_display_registers_from_line): Update.
1900         * tui/tui-data.h (struct tui_data_window)
1901         <first_reg_element_no_inline>: New method.
1902
1903 2019-07-17  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-windata.c (tui_display_data_from)
1906         (tui_data_window::do_scroll_vertical): Update.
1907         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1908         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1909         Rename from tui_line_from_reg_element_no.
1910         (tui_display_registers_from_line): Update.
1911         * tui/tui-data.h (struct tui_data_window)
1912         <line_from_reg_element_no>: New method.
1913
1914 2019-07-17  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1917         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1918         tui_last_regs_line_no.
1919         (tui_display_reg_element_at_line)
1920         (tui_display_registers_from_line): Update.
1921         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1922         method.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         PR tui/24722:
1927         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1928         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1929         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1930         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1931         (tui_update_breakpoint_info): Likewise.
1932         * tui/tui-hooks.c (tui_event_create_breakpoint)
1933         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1934         Update.
1935
1936 2019-07-17  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1939
1940 2019-07-17  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-winsource.c (tui_update_source_window_as_is)
1943         (tui_update_source_windows_with_addr): Update.
1944         * tui/tui-source.h (tui_set_source_content)
1945         (tui_show_symtab_source): Add "win_info" parameter.
1946         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1947         parameter.
1948         (tui_show_symtab_source): Likewise.
1949
1950 2019-07-17  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-wingeneral.c
1953         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1954
1955 2019-07-17  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1958         (struct tui_cmd_window) <can_scroll>: New method.
1959         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1960         method.
1961
1962 2019-07-17  Tom Tromey  <tromey@adacore.com>
1963
1964         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1965         do_field_signed>: Rename.  Change type of "value".
1966         * ui-out.c (ui_out::field_signed): Rename from field_int.
1967         Change type of "value".
1968         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1969         type of "value".
1970         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1971         do_field_int.  Change type of "value".
1972         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1973         do_field_int.  Change type of "value".
1974         * tracepoint.c (trace_status_mi, tfind_1)
1975         (print_one_static_tracepoint_marker): Update.
1976         * thread.c (print_thread_info_1, print_selected_thread_frame):
1977         Update.
1978         * stack.c (print_frame, print_frame_info): Update.
1979         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1980         Update.
1981         * source.c (print_source_lines_base): Update.
1982         * skip.c (info_skip_command): Update.
1983         * record-btrace.c (btrace_ui_out_decode_error)
1984         (btrace_call_history_src_line): Update.
1985         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1986         Update.
1987         * progspace.c (print_program_space): Update.
1988         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1989         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1990         do_field_int.  Change type of "value".
1991         * mi/mi-out.c (mi_ui_out::do_table_begin)
1992         (mi_ui_out::do_table_header): Update.
1993         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1994         type of "value".
1995         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1996         (mi_cmd_data_list_changed_registers, output_register)
1997         (mi_cmd_data_read_memory, mi_load_progress)
1998         (mi_cmd_trace_frame_collected): Update.
1999         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2000         Update.
2001         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2002         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2003         (mi_cmd_var_list_children, varobj_update_one): Update.
2004         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2005         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2006         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2007         * inferior.c (print_inferior): Update.
2008         * gdb_bfd.c (print_one_bfd): Update.
2009         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2010         Update.
2011         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2012         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2013         do_field_int.  Change type of "value".
2014         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2015         do_field_int.  Change type of "value".
2016         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2017         (print_one_breakpoint_location, print_it_catch_fork)
2018         (print_one_catch_fork, print_it_catch_vfork)
2019         (print_one_catch_vfork, print_it_catch_solib)
2020         (print_it_catch_exec, print_it_ranged_breakpoint)
2021         (print_mention_watchpoint, print_mention_masked_watchpoint)
2022         (bkpt_print_it, update_static_tracepoint): Update.
2023         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2024         * break-catch-syscall.c (print_it_catch_syscall): Update.
2025         * ada-tasks.c (print_ada_task_info): Update.
2026         * ada-lang.c (print_it_exception, print_mention_exception):
2027         Update.
2028
2029 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2030
2031         PR breakpoints/24541
2032         * gdbarch.c: Regenerate.
2033         * gdbarch.h: Regenerate.
2034         * gdbarch.sh: Adjust return type and parameter types for
2035         'stap_adjust_register'.
2036         (i386_stap_adjust_register): Adjust signature and return new
2037         register name.
2038         * stap-probe.c (stap_parse_register_operand): Adjust use of
2039         'gdbarch_stap_adjust_register'.
2040
2041 2019-07-17  Tom Tromey  <tromey@adacore.com>
2042
2043         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2044         declare VEC.
2045         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2046         std::vector.
2047         (struct s390_process_info): Add initializers.
2048         (s390_add_process): Use new.
2049         (s390_linux_nat_target::low_forget_process): Use delete.
2050         (s390_linux_nat_target::low_new_fork)
2051         (s390_linux_nat_target::stopped_by_watchpoint)
2052         (s390_linux_nat_target::low_prepare_to_resume)
2053         (s390_linux_nat_target::insert_watchpoint)
2054         (s390_linux_nat_target::insert_hw_breakpoint)
2055         (s390_linux_nat_target::remove_watchpoint)
2056         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2057
2058 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2059
2060         * aarch64-fbsd-nat.c: Include regcache.h.
2061         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2062         argument.
2063         (aarch64_fbsd_nat_target::fetch_registers)
2064         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2065         variable.
2066         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2067
2068 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2069
2070         * fbsd-nat.c: Include gdbarch.h.
2071
2072 2019-07-15  Tom Tromey  <tromey@adacore.com>
2073
2074         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2075
2076 2019-07-15  Tom Tromey  <tromey@adacore.com>
2077
2078         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2079         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2080         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2081         * cli-out.c (cli_ui_out::do_field_int): New method.
2082         * ui-out.c (ui_out::field_unsigned): New method.
2083         * symfile.c (generic_load): Use field_unsigned.
2084         (print_transfer_performance): Likewise.
2085         * record-btrace.c (ui_out_field_uint): Remove.
2086         (btrace_call_history_insn_range, btrace_call_history): Use
2087         field_unsigned.
2088         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2089         field_unsigned.
2090         * ui-out.h (class ui_out) <field_unsigned>: New method.
2091         <do_field_unsigned>: Likewise.
2092
2093 2019-07-15  Tom Tromey  <tromey@adacore.com>
2094
2095         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2096         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2097         * target.c (flash_erase_command): Use field_string.
2098         * infrun.c (print_signal_received_reason): Use field_string.
2099         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2100         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2101         field_string.
2102         * ada-tasks.c (print_ada_task_info): Use field_string.
2103
2104 2019-07-15  Tom Tromey  <tromey@adacore.com>
2105
2106         * target.c (flash_erase_command): Use field_core_addr.
2107         * symfile.c (generic_load): Use field_core_addr.
2108         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2109         Use field_core_addr.
2110         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2111         field_core_addr.
2112
2113 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2114
2115         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2116         value if its desired type is smaller than a CORE_ADDR and signed.
2117
2118 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2119
2120         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2121         of changes to field names, and use new is_reference field to
2122         decide if a property is a reference or not.
2123         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2124         field.
2125         (struct dwarf2_property_baton): Update header comment, rename
2126         'referenced_type' to 'property_type' and update comments.
2127         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2128         default property type, store in property baton, update to take
2129         accound of renamed field.
2130         (read_func_scope): Update call to attr_to_dynamic_prop.
2131         (read_array_type): Likewise.
2132         (dwarf2_per_cu_addr_sized_int_type): New function.
2133         (read_subrange_index_type): Move type finding code to
2134         dwarf2_per_cu_addr_sized_int_type.
2135         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2136         (dwarf2_per_cu_addr_type): New function.
2137         (set_die_type): Update calls to attr_to_dynamic_prop.
2138
2139 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * dwarf2read.c (read_subrange_index_type): New function.
2142         (read_subrange_type): Move code into new function and call it.
2143         * gdbtypes.c (create_range_type): Add some asserts.
2144
2145 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2146
2147         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2148         update return statements.
2149         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2150         declaration, and update comment to match.
2151         * gdbtypes.c (resolve_dynamic_array): Update call to
2152         dwarf2_evaluate_property to match new return type.
2153
2154 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2155
2156         * valarith.c (value_subscripted_rvalue): Change lowerbound
2157         parameter type from int to LONGEST.
2158         * value.h (value_subscripted_rvalue): Likewise in declaration.
2159
2160 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * cli/cli-utils.c (info_print_command_completer): New function.
2163         * cli/cli-utils.h: Add 'completer.h' include, and forward
2164         declaration for 'struct cmd_list_element'.
2165         (info_print_command_completer): Declare.
2166         * stack.c (_initialize_stack): Add completer for 'info locals' and
2167         'info args'.
2168         * symtab.c (_initialize_symtab): Add completer for 'info
2169         variables' and 'info functions'.
2170         * NEWS: Mention completion for additional info commands.
2171
2172 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * cli/cli-utils.c (extract_info_print_args): Delete.
2175         (extract_arg_maybe_quoted): Delete.
2176         (info_print_options_defs): New variable.
2177         (make_info_print_options_def_group): New function.
2178         (extract_info_print_options): Define new function.
2179         * cli/cli-utils.h (extract_info_print_args): Delete.
2180         (struct info_print_options): New structure.
2181         (extract_info_print_options): Declare new function.
2182         * stack.c (info_locals_command): Update to use new
2183         extract_info_print_options, also add a header comment.
2184         (info_args_command): Likewise.
2185         * symtab.c (info_variables_command): Likewise.
2186         (info_functions_command): Likewise.
2187
2188 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2191         to extract string arguments.
2192         * common/common-utils.c (extract_string_maybe_quoted): New function.
2193         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2194
2195 2019-07-11  Tom Tromey  <tromey@adacore.com>
2196
2197         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2198         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2199         * top.h (gdbinit): Don't declare.
2200         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2201         into...
2202         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2203         * top.c (gdb_init): Don't call init_cli_cmds.
2204         (gdbinit): Remove.
2205         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2206
2207 2019-07-11  Tom Tromey  <tromey@adacore.com>
2208
2209         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2210         after it has been moved.
2211
2212 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2213
2214         * valops.c (value_must_coerce_to_target): Change return type to
2215         bool.
2216         * value.h (value_must_coerce_to_target): Likewise.
2217
2218 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2219
2220         * breakpoint.c (is_hardware_watchpoint): Remove
2221         forward-declaration.
2222         (is_masked_watchpoint): Change return type to bool.
2223         (is_tracepoint): Likewise.
2224         (is_breakpoint): Likewise.
2225         (is_hardware_watchpoint): Likewise.
2226         (is_watchpoint): Likewise.
2227         (is_no_memory_software_watchpoint): Likewise.
2228         (is_catchpoint): Likewise.
2229         (breakpoint_1): Make FILTER parameter's return type bool.
2230         is_masked_watchpoint): Change return type to bool.
2231         (save_breakpoints): Make FILTER parameter's return type bool.
2232         * breakpoint.h (is_breakpoint): Change return type to bool.
2233         (is_watchpoint): Likewise.
2234         (is_catchpoint): Likewise.
2235         (is_tracepoint): Likewise.
2236
2237 2019-07-10  Tom Tromey  <tom@tromey.com>
2238
2239         * defs.h: Don't include gdbarch.h.
2240         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2241         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2242         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2243         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2244         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2245         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2246         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2247         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2248         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2249         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2250         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2251         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2252         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2253         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2254         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2255         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2256         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2257         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2258         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2259         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2260         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2261         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2262         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2263         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2264         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2265         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2266         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2267
2268 2019-07-10  Tom Tromey  <tromey@adacore.com>
2269
2270         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2271         * breakpoint.c (init_ada_exception_breakpoint): Register as
2272         bp_catchpoint.
2273         (print_one_breakpoint_location, print_one_breakpoint): Use
2274         is_ada_exception_catchpoint.
2275         * ada-lang.c (class ada_catchpoint_location): Pass
2276         bp_loc_software_breakpoint to bp_location constructor.
2277         (is_ada_exception_catchpoint): New function.
2278
2279 2019-07-10  Tom Tromey  <tromey@adacore.com>
2280
2281         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2282         VEC.
2283         (struct arm_exidx_entry): New method operator<.
2284         (struct arm_exidx_data) <section_maps>: Change type.
2285         (arm_exidx_data_free): Remove.
2286         (arm_exidx_data_key): Change type.  Move lower.
2287         (arm_exidx_new_objfile): Update.
2288         (arm_compare_exidx_entries): Remove.
2289         (arm_find_exidx_entry, _initialize_arm_tdep)
2290
2291 2019-07-10  Tom Tromey  <tromey@adacore.com>
2292
2293         * solib-spu.c (ocl_program_data_key): Change type.
2294         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2295         Update.
2296
2297 2019-07-10  Tom Tromey  <tromey@adacore.com>
2298
2299         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2300         (struct solib_aix_inferior_data) <library_list>: Change type.
2301         (solib_aix_inferior_data_handle): Change type.
2302         (get_solib_aix_inferior_data): Update.
2303         (solib_aix_free_library_list): Remove.
2304         (library_list_start_library): Update.
2305         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2306         return type.
2307         (solib_aix_get_library_list)
2308         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2309         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2310
2311 2019-07-10  Tom Tromey  <tromey@adacore.com>
2312
2313         * solib-dsbt.c (struct dsbt_info): Add initializers.
2314         (solib_dsbt_pspace_data): Change type.
2315         (dsbt_pspace_data_cleanup): Remove.
2316         (get_dsbt_info, _initialize_dsbt_solib): Update.
2317
2318 2019-07-10  Tom Tromey  <tromey@adacore.com>
2319
2320         * spu-tdep.c (spu_overlay_data): Change type.
2321         (spu_get_overlay_table, spu_overlay_new_objfile)
2322         (_initialize_spu_tdep): Update.
2323
2324 2019-07-10  Tom Tromey  <tromey@adacore.com>
2325
2326         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2327         destructor.
2328         (dbx_objfile_data_key): Change type and declare later.
2329         (DBX_SYMFILE_INFO): Rewrite.
2330         * dbxread.c (dbx_objfile_data_key): Change type.
2331         (dbx_symfile_init): Update.
2332         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2333         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2334         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2335
2336 2019-07-10  Tom Tromey  <tromey@adacore.com>
2337
2338         * jit.c (jit_program_space_key): Change type.  Move lower.
2339         (get_jit_program_space_data): Update.
2340         (jit_program_space_data_cleanup): Remove.
2341         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2342         Update.
2343         (struct jit_program_space_data): Add initializers.
2344
2345 2019-07-10  Tom Tromey  <tromey@adacore.com>
2346
2347         * solib-darwin.c (struct darwin_info): Add initializers.
2348         (solib_darwin_pspace_data): Change type.
2349         (darwin_pspace_data_cleanup): Remove.
2350         (get_darwin_info, _initialize_darwin_solib): Update.
2351
2352 2019-07-10  Tom Tromey  <tromey@adacore.com>
2353
2354         * remote-sim.c (struct sim_inferior_data): Add initializers,
2355         constructor, and destructor.
2356         (sim_inferior_data_key): Change type.  Move lower.
2357         (check_for_duplicate_sim_descriptor): Update.
2358         (get_sim_inferior_data): Use new.  Update.
2359         (~sim_inferior_data_cleanup): Rename from
2360         sim_inferior_data_cleanup.  Simplify.
2361         (gdbsim_close_inferior, simulator_command)
2362         (sim_command_completer, _initialize_remote_sim): Update.
2363         (next_pid, INITIAL_PID): Move earlier.
2364
2365 2019-07-10  Tom Tromey  <tromey@adacore.com>
2366
2367         * python/python-internal.h (create_thread_object): Return
2368         gdbpy_ref.
2369         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2370         * python/py-inferior.c (struct threadlist_entry): Add
2371         constructor.
2372         <thread_obj>: Now a gdbpy_ref.
2373         (thread_to_thread_object): Update.
2374         (add_thread_object): Use new.
2375         (delete_thread_object): Use delete.
2376         (infpy_threads): Update.
2377         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2378         GIL.
2379
2380 2019-07-10  Tom Tromey  <tromey@adacore.com>
2381
2382         * valops.c (value_cast): Specialize error message for Ada.
2383
2384 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2385
2386         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2387
2388 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2389
2390         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2391         bpstat_should_step): Return bool, adjust comments.
2392         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2393         bpstat_should_step): Likewise.
2394
2395 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2396
2397         * features/Makefile: Use feature target descriptions for Arm.
2398         * features/arm/arm-core.c: Generate new file.
2399         * features/arm/arm-fpa.c: Likewise.
2400         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2401         * features/arm/arm-m-profile.c: Likewise.
2402         * features/arm/arm-vfpv2.c: Likewise.
2403         * features/arm/arm-vfpv3.c: Likewise.
2404         * features/arm/xscale-iwmmxt.c: Likewise.
2405         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2406
2407 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2408
2409         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2410         ptrace earlier.
2411
2412 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2413
2414         * features/aarch64-pauth.c: Regenerate.
2415
2416 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2417
2418         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2419         bool.
2420         (bpstat_what): Use false instead of 0.
2421
2422 2019-07-09  Pedro Alves  <palves@redhat.com>
2423
2424         * break-catch-throw.c (is_exception_catchpoint): New.
2425         * breakpoint.c (print_one_breakpoint_location): New parameter
2426         'raw_loc'.  Handle it.  Use
2427         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2428         looking at the breakpoint's type.
2429         (print_one_breakpoint): If handling "maint info breakpoints", also
2430         print locations of exception catchpoints.
2431         * breakpoint.h (is_exception_catchpoint): Declare.
2432
2433 2019-07-09  Pedro Alves  <palves@redhat.com>
2434
2435         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2436         "addr" field.
2437         (allocate_location_exception_catchpoint): New.
2438         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2439         (initialize_throw_catchpoint_ops): Install
2440         allocate_location_exception_catchpoint as allocate_location
2441         method.
2442         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2443         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2444         bp_loc_other.
2445         (breakpoint_address_is_meaningful): Delete.
2446         (bl_address_is_meaningful): New.
2447         (breakpoint_locations_match): Adjust comment.
2448         (bp_location_from_bp_type): New, factored out of...
2449         (bp_location::bp_location(breakpoint *)): ... this.
2450         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2451         factored out of...
2452         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2453         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2454         breakpoint_address_is_meaningful.
2455         (bp_locations_compare): Adjust comment.
2456         (update_global_location_list): Use bl_address_is_meaningful
2457         instead of breakpoint_address_is_meaningful.
2458         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2459         explicit.
2460         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2461         * python/py-breakpoint.c (bppy_get_location): No longer check
2462         whether location is null.
2463
2464 2019-07-09  Pedro Alves  <palves@redhat.com>
2465
2466         PR c++/15468
2467         * breakpoint.c (print_one_breakpoint_location): Remove
2468         single-location assert.
2469
2470 2019-07-09  Tom Tromey  <tom@tromey.com>
2471
2472         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2473         * configure: Rebuild.
2474         * configure.ac: Change common to gdbsupport.
2475         * gdbsupport: Rename from common.
2476         * acinclude.m4: Change common to gdbsupport.
2477         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2478         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2479         gdbsupport.
2480         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2481         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2482         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2483         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2484         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2485         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2486         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2487         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2488         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2489         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2490         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2491         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2492         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2493         coff-pe-read.c, command.h, compile/compile-c-support.c,
2494         compile/compile-c.h, compile/compile-cplus-symbols.c,
2495         compile/compile-cplus-types.c, compile/compile-cplus.h,
2496         compile/compile-loc2c.c, compile/compile.c, completer.c,
2497         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2498         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2499         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2500         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2501         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2502         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2503         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2504         features/aarch64-core.c, features/aarch64-fpu.c,
2505         features/aarch64-pauth.c, features/aarch64-sve.c,
2506         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2507         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2508         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2509         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2510         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2511         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2512         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2513         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2514         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2515         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2516         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2517         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2518         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2519         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2520         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2521         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2522         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2523         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2524         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2525         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2526         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2527         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2528         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2529         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2530         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2531         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2532         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2533         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2534         minsyms.c, mips-linux-tdep.c, namespace.h,
2535         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2536         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2537         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2538         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2539         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2540         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2541         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2542         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2543         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2544         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2545         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2546         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2547         procfs.c, producer.c, progspace.h, psymtab.h,
2548         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2549         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2550         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2551         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2552         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2553         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2554         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2555         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2556         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2557         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2558         target-memory.c, target.c, target.h, target/waitstatus.c,
2559         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2560         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2561         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2562         unittests/array-view-selftests.c,
2563         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2564         unittests/common-utils-selftests.c,
2565         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2566         unittests/format_pieces-selftests.c,
2567         unittests/function-view-selftests.c,
2568         unittests/lookup_name_info-selftests.c,
2569         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2570         unittests/mkdir-recursive-selftests.c,
2571         unittests/observable-selftests.c,
2572         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2573         unittests/parse-connection-spec-selftests.c,
2574         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2575         unittests/scoped_fd-selftests.c,
2576         unittests/scoped_mmap-selftests.c,
2577         unittests/scoped_restore-selftests.c,
2578         unittests/string_view-selftests.c, unittests/style-selftests.c,
2579         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2580         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2581         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2582         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2583         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2584         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2585
2586 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2589         bool value.
2590         (decode_digits_ordinary): Set explicit_line field in sal.
2591         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2592         symtab_and_line that was set on an explicit line number in
2593         assembler code.  Do always update the recorded symtab and line if
2594         we do skip the prologue.
2595
2596 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2597
2598         * breakpoint.c (set_breakpoint_location_function): Remove
2599         explicit_loc parameter.
2600         (momentary_breakpoint_from_master): Update call to
2601         set_breakpoint_location_function.
2602         (add_location_to_breakpoint): Likewise.
2603
2604 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2605
2606         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2607         required features based on default bfd type when no specific bfd
2608         is present.
2609
2610 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2611
2612         * NEWS: Mention that GDB printf and eval commands can now print
2613         C-style and Ada-style convenience var strings without
2614         calling the inferior.
2615         * printcmd.c (printf_c_string): Locally print GDB internal var
2616         instead of transiting via the inferior.
2617         (printf_wide_c_string): Likewise.
2618
2619 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2620
2621         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2622
2623 2019-07-04  Tom Tromey  <tom@tromey.com>
2624
2625         PR tui/24724:
2626         * tui/tui-winsource.c (tui_clear_source_content): Update.
2627         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2628         (tui_update_breakpoint_info): Update.
2629         (tui_set_exec_info_content): Update.
2630         * tui/tui-source.c (tui_set_source_content_nil): Update.
2631         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2632         has_break.
2633         * tui/tui-data.h (enum tui_bp_flag): New.
2634         (tui_bp_flags): New enum flags type.
2635         (struct tui_source_element) <break_mode>: Change type.  Rename
2636         from has_break.
2637         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2638         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2639         constants.
2640         * tui/tui-winsource.h: Fix comment.
2641
2642 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2643
2644         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2645         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2646         (store_fpregs_to_thread)
2647         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2648         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2649         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2650         (IWMMXT_REGS_SIZE): Add define.
2651         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2652         (fetch_vfp_regs, store_vfp_regs)
2653         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2654         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2655
2656 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2657
2658         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2659         defines.
2660         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2661         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2662         (ARM_INT_REGISTER_SIZE): ...to this.
2663         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2664         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2665         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2666         (arm_linux_collect_gregset, supply_nwfpe_register)
2667         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2668         defines.
2669         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2670         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2671         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2672         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2673         (arm_return_in_memory, arm_store_return_value)
2674         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2675         (arm_record_ld_st_multiple): Likewise.
2676         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2677         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2678
2679 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2680
2681         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2682         AARCH64_DISPLACED_MODIFIED_INSNS.
2683         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2684         (aarch64_displaced_step_copy_insn): Likewise.
2685         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2686         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2687         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2688         ARM_DISPLACED_MODIFIED_INSNS.
2689         * arm-tdep.c (arm_gdbarch_init): Likewise.
2690         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2691         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2692         (struct arm_displaced_step_closure): Use
2693         ARM_DISPLACED_MODIFIED_INSNS.
2694
2695 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2696
2697         * features/Makefile: Remove unused xml files.
2698         * features/aarch64.xml: Remove.
2699         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2700         * features/i386/amd64-avx-avx512.xml: Remove.
2701         * features/i386/amd64-avx-linux.xml: Remove.
2702         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2703         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2704         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2705         * features/i386/amd64-avx-mpx.xml: Remove.
2706         * features/i386/amd64-avx.xml: Remove.
2707         * features/i386/amd64-linux.xml: Remove.
2708         * features/i386/amd64-mpx-linux.xml: Remove.
2709         * features/i386/amd64-mpx.xml: Remove.
2710         * features/i386/amd64.xml: Remove.
2711         * features/i386/i386-avx-avx512-linux.xml: Remove.
2712         * features/i386/i386-avx-avx512.xml: Remove.
2713         * features/i386/i386-avx-linux.xml: Remove.
2714         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2715         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2716         * features/i386/i386-avx-mpx-linux.xml: Remove.
2717         * features/i386/i386-avx-mpx.xml: Remove.
2718         * features/i386/i386-avx.xml: Remove.
2719         * features/i386/i386-linux.xml: Remove.
2720         * features/i386/i386-mmx-linux.xml: Remove.
2721         * features/i386/i386-mmx.xml: Remove.
2722         * features/i386/i386-mpx-linux.xml: Remove.
2723         * features/i386/i386-mpx.xml: Remove.
2724         * features/i386/i386.xml: Remove.
2725         * features/i386/x32-avx-avx512-linux.xml: Remove.
2726         * features/i386/x32-avx-linux.xml: Remove.
2727         * features/i386/x32-linux.xml: Remove.
2728
2729 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2730
2731         * regformats/aarch64.dat: Remove.
2732         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2733         * regformats/i386/amd64-avx-linux.dat: Remove.
2734         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2735         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2736         * regformats/i386/amd64-linux.dat: Remove.
2737         * regformats/i386/amd64-mpx-linux.dat: Remove.
2738         * regformats/i386/amd64.dat: Remove.
2739         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2740         * regformats/i386/i386-avx-linux.dat: Remove.
2741         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2742         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2743         * regformats/i386/i386-linux.dat: Remove.
2744         * regformats/i386/i386-mmx-linux.dat: Remove.
2745         * regformats/i386/i386-mpx-linux.dat: Remove.
2746         * regformats/i386/i386.dat: Remove.
2747         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2748         * regformats/i386/x32-avx-linux.dat: Remove.
2749         * regformats/i386/x32-linux.dat: Remove.
2750
2751 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2752
2753         * aarch64-tdep.c: Remove xml self tests.
2754         * amd64-linux-tdep.c: Likewise.
2755         * amd64-tdep.c: Likewise.
2756         * i386-linux-tdep.c: Likewise.
2757         * i386-tdep.c: Likewise.
2758
2759 2019-07-03  Pedro Alves  <palves@redhat.com>
2760
2761         PR cli/24732
2762         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2763         (pipe_cmd_option_defs): New.
2764         (make_pipe_cmd_options_def_group): New.
2765         (pipe_command): Use gdb::option::process_options.
2766         (pipe_command_completer): New function.
2767         (_initialize_cli_cmds): Install completer for "pipe" command.
2768
2769 2019-07-03  Pedro Alves  <palves@redhat.com>
2770
2771         * cli/cli-option.c (union option_value) <string>: New field.
2772         (struct option_def_and_value): Add ctor, move ctor, dtor and
2773         use DISABLE_COPY_AND_ASSIGN.
2774         (option_def_and_value::clear_value): New.
2775         (parse_option, save_option_value_in_ctx, get_val_type_str)
2776         (add_setshow_cmds_for_options): Handle var_string.
2777         * cli-option.h (union option_def::var_address) <string>: New
2778         field.
2779         (struct string_option_def): New.
2780         * maint-test-options.c (struct test_options_opts): Add default
2781         ctor and use DISABLE_COPY_AND_ASSIGN.
2782         <string_opt>: New field.
2783         (test_options_opts::~test_options_opts): New.
2784         (test_options_opts::dump): Also dump "-string".
2785         (test_options_option_defs): Install "string.
2786
2787 2019-07-03  Pedro Alves  <palves@redhat.com>
2788
2789         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2790         option_value with a null enumeration.
2791         (complete_options): Save the option values in the context.
2792         (save_option_value_in_ctx): New, factored out from ...
2793         (process_options): ... here.
2794         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2795         of the function.
2796         * maint-test-options.c (test_options_opts::dump): New, factored
2797         out from ...
2798         (maintenance_test_options_command_mode): ... here.
2799         (maintenance_test_options_command_completion_result): Delete.
2800         (maintenance_test_options_command_completion_text): Update
2801         comment.
2802         (maintenance_show_test_options_completion_result): Change
2803         prototype.  Just print
2804         maintenance_test_options_command_completion_text.
2805         (save_completion_result): New.
2806         (maintenance_test_options_completer_mode): Pass options context to
2807         complete_options, and then save a dump.
2808         (_initialize_maint_test_options): Use add_cmd to install "maint
2809         show test-options-completion-result".
2810
2811 2019-07-03  Pedro Alves  <palves@redhat.com>
2812
2813         * NEWS (New commands): Mention "with" and "maint with".
2814         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2815         (with_command, with_command_completer): New.
2816         (pipe_command): Adjust to new repeat_previous
2817         interface.
2818         (_initialize_cli_cmds): Install the "with" command and its "w"
2819         alias.
2820         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2821         declarations.
2822         * cli/cli-setshow.c (parse_cli_var_uinteger)
2823         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2824         argument strings for all var_types.
2825         (get_setshow_command_value_string): New, factored out from ...
2826         (do_show_command): ... this.
2827         * cli/cli-setshow.h: Include <string>.
2828         (get_setshow_command_value_string): Declare.
2829         * command.h (repeat_previous): Now returns const char *.  Adjust
2830         comment.
2831         * maint.c: Include "cli/cli-cmds.h".
2832         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2833         (_initialize_maint_cmds): Register the "maintenance with" command.
2834         * top.c (repeat_previous): Move bits from pipe_command here:
2835         Return the saved command line, if any; error out if there's no
2836         command to relaunch.
2837
2838 2019-07-03  Pedro Alves  <palves@redhat.com>
2839
2840         * NEWS (New commands): Mention "maint set/show test-settings"
2841         instead of "maint test-settings".
2842         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2843         (maintenance_test_settings_set_list): Rename to ...
2844         (maintenance_set_test_settings_list): ... this.
2845         (maintenance_test_settings_show_list): Rename to  ...
2846         (maintenance_show_test_settings_list): ... this.
2847         (maintenance_test_settings_cmd): Delete.
2848         (maintenance_test_settings_set_cmd): ...
2849         (maintenance_set_test_settings_cmd): ... this.
2850         (maintenance_test_settings_show_cmd): ...
2851         (maintenance_show_test_settings_cmd): ... this.
2852         (maintenance_test_settings_show_value_cmd):
2853         (maintenance_show_test_settings_value_cmd): ... this.
2854         (_initialize_maint_test_settings): No longer install the "maint
2855         test-settings" prefix command.  Rename "maint test-settings set"
2856         to "maint set test-settings", and "maint test-settings show" to
2857         "maint show test-settings".  Adjust all subcommands.
2858
2859 2019-07-03  Pedro Alves  <palves@redhat.com>
2860
2861         * maint-test-settings.c: Fix file's intro comment.  Replace all
2862         references to "test-options" with references to "test-settings",
2863         in comments.
2864
2865 2019-07-03  Pedro Alves  <palves@redhat.com>
2866
2867         * maint-test-settings.c (maintenance_test_settings_xxx)
2868         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2869         New.
2870         (maintenance_test_settings_enums): Use them.
2871         (maintenance_test_settings_enum): Default to
2872         maintenance_test_settings_xxx.
2873         (_initialize_maint_test_settings): Initialize
2874         MAINTENANCE_TEST_SETTINGS_FILENAME.
2875
2876 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2877
2878         * breakpoint.h (remove_breakpoints_inf): Change return type to
2879         void, move function documentation here.
2880         * breakpoint.c (remove_breakpoints_inf): Change return type to
2881         void, move function documentation to header.
2882
2883 2019-07-02  Pedro Alves  <palves@redhat.com>
2884
2885         * NEWS (Completion improvements): Mention "info threads".
2886         * thread.c (struct info_threads_opts, info_threads_option_defs)
2887         (make_info_threads_options_def_group): New.
2888         (info_threads_command): Use gdb::option::process_options.
2889         (info_threads_command_completer): New.
2890         (_initialize_thread): Use gdb::option::build_help to build the
2891         help text for "info threads".
2892
2893 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2894
2895         * defs.h (generic_load): Move from here...
2896         * symfile.h (generic_load): ... to here.  Rename name parameter
2897         to args.
2898         * symfile.c (generic_load): Add comment.
2899
2900 2019-07-01  Tom Tromey  <tromey@adacore.com>
2901
2902         * dwarf2read.c
2903         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2904         declaration of without_params.  Fix formatting.
2905
2906 2019-07-01  Tom Tromey  <tromey@adacore.com>
2907
2908         * ada-exp.y (find_primitive_type): Update.
2909         * ada-lang.h (ada_lookup_symbol): Update.
2910         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2911         parameter.
2912         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2913
2914 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2915
2916         PR breakpoints/24541
2917         * gdbarch.c: Regenerate.
2918         * gdbarch.h: Regenerate.
2919         * gdbarch.sh: Add 'stap_adjust_register'.
2920         * i386-tdep.c: Include '<unordered_set>'.
2921         (i386_stap_adjust_register): New function.
2922         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2923         * stap-probe.c (stap_parse_register_operand): Call
2924         'gdbarch_stap_adjust_register'.
2925
2926 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2927
2928         PR python/24742
2929         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2930         * python/python.c (do_start_initialization): Use 'xmalloc'
2931         instead of 'PyMem_Malloc'.
2932
2933 2019-06-28  Tom Tromey  <tromey@adacore.com>
2934
2935         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2936         for Ada.
2937
2938 2019-06-27  Tom Tromey  <tromey@adacore.com>
2939
2940         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2941         objfile_key.
2942         (arm_find_mapping_symbol, arm_record_special_symbol)
2943         (_initialize_arm_tdep): Update.
2944         (arm_objfile_data_free): Remove.
2945
2946 2019-06-27  Tom Tromey  <tromey@adacore.com>
2947
2948         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2949         to cp_print_static_field.
2950
2951 2019-06-26  Tom Tromey  <tromey@adacore.com>
2952
2953         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2954         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2955         declare.
2956
2957 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2958
2959         * features/aarch64-core.c (create_feature_aarch64_core):
2960         Regenerate.
2961         * features/aarch64-core.xml: Add cpsr flags.
2962
2963 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2964
2965         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2966         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2967
2968 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2969
2970         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2971         field.
2972         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2973         use.
2974         (arm_record_special_symbol): Don't insert new symbol in sorted
2975         position, push it at the end.
2976
2977 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2978
2979         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2980         (arm_mapping_symbol_s): Remove.
2981         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2982         (arm_mapping_symbol_vec): New typedef.
2983         (struct arm_per_objfile): Add constructor.
2984         <section_maps>: Change type to
2985         std::unique_ptr<arm_mapping_symbol_vec[]>.
2986         (arm_compare_mapping_symbols): Remove.
2987         (arm_find_mapping_symbol): Adjust to section_maps type change.
2988         (arm_objfile_data_free): Call delete on arm_per_objfile.
2989         (arm_record_special_symbol): Adjust to section_maps type change.
2990         Allocate arm_per_objfile with new.
2991
2992 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2993
2994         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2995         with the command prefix.
2996
2997 2019-06-25  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3000         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3001
3002 2019-06-25  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3005         type.
3006         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3007         protected.
3008
3009 2019-06-25  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-winsource.c
3012         (tui_source_window_base::set_is_exec_point_at): Add check against
3013         LOA_ADDRESS.
3014
3015 2019-06-25  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-source.c (tui_set_source_content): Don't check before
3018         xfree.
3019         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3020
3021 2019-06-25  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-winsource.h (tui_update_source_window_as_is)
3024         (tui_alloc_source_buffer, tui_line_is_displayed)
3025         (tui_addr_is_displayed): Change type of win_info.
3026         * tui/tui-winsource.c (tui_update_source_window_as_is)
3027         (tui_clear_source_content, tui_show_source_line)
3028         (tui_show_source_content, tui_source_window_base::refill)
3029         (tui_source_window_base::set_is_exec_point_at)
3030         (tui_source_window_base::set_is_exec_point_at)
3031         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3032         (tui_alloc_source_buffer, tui_line_is_displayed)
3033         (tui_addr_is_displayed): Change type of win_info.  Update.
3034         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3035         (tui_source_window_base::do_make_visible_with_new_height):
3036         Update.
3037         * tui/tui-source.c (tui_set_source_content)
3038         (tui_set_source_content_nil)
3039         (tui_source_window::do_scroll_vertical): Update.
3040         * tui/tui-layout.c (show_layout): Update.
3041         * tui/tui-disasm.c (tui_set_disassem_content)
3042         (tui_disasm_window::do_scroll_vertical): Update.
3043         * tui/tui-data.h (tui_win_content): Remove.
3044         (struct tui_gen_win_info) <content, content_size>: Remove.
3045         (struct tui_source_element): Add initializers and destructor.
3046         (union tui_which_element, struct tui_win_element): Remove.
3047         (struct tui_source_window_base) <content>: New field.
3048         (struct tui_data_window): Remove destructor.
3049         (tui_alloc_content, tui_free_win_content)
3050         (tui_free_all_source_wins_content): Don't declare.
3051         * tui/tui-data.c (tui_initialize_static_data): Update.
3052         (init_content_element, tui_alloc_content): Remove.
3053         (~tui_gen_win_info): Update.
3054         (~tui_data_window, tui_free_all_source_wins_content)
3055         (tui_free_win_content, free_content, free_content_elements):
3056         Remove.
3057
3058 2019-06-25  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-winsource.h (tui_clear_source_content)
3061         (tui_erase_source_content, tui_show_source_content): Change type
3062         of win_info.
3063         * tui/tui-winsource.c (tui_clear_source_content)
3064         (tui_erase_source_content, tui_show_source_content): Change type
3065         of win_info.
3066         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3067         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3068         win_info.
3069         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3070         win_info.
3071         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3072
3073 2019-06-25  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-winsource.c (tui_clear_source_content)
3076         (tui_source_window_base::set_is_exec_point_at): Update.
3077         * tui/tui-source.c (tui_set_source_content_nil): Update.
3078         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3079         a bool.
3080         * tui/tui-data.c (init_content_element): Update.
3081
3082 2019-06-25  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3085         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3086         * tui/tui-layout.c (init_and_make_win): Update.
3087         * tui/tui.h (enum tui_win_type): Update.
3088         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3089         tui_win_is_auxillary.
3090         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3091         tui_win_is_auxillary.
3092
3093 2019-06-25  Tom Tromey  <tom@tromey.com>
3094
3095         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3096         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3097         (tui_delete_data_content_windows, tui_display_all_data)
3098         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3099         Update.
3100         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3101         * tui/tui-regs.c (tui_last_regs_line_no)
3102         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3103         (tui_show_registers): Update.
3104         (tui_show_register_group): Return void.  Update.
3105         (tui_display_registers_from, tui_display_reg_element_at_line)
3106         (tui_display_registers_from_line, tui_check_register_values):
3107         Update.
3108         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3109         member.
3110         (struct tui_data_window) <regs_content>: Now a std::vector.
3111         <regs_content_count>: Remove.
3112         (tui_add_content_elements, tui_free_data_content): Don't declare.
3113         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3114         (init_content_element): Remove DATA_WIN case.  Add assert.
3115         (tui_add_content_elements): Remove.
3116         (tui_data_window): Update.
3117         (tui_free_data_content): Remove.
3118         (free_content_elements): Remove DATA_WIN case.
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-data.c (tui_data_item_window): Update.
3123         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3124         * tui/tui-windata.c (tui_display_all_data)
3125         (tui_display_data_from_line): Update.
3126         (tui_check_data_values): Remove.
3127         * tui/tui-regs.c (tui_show_register_group)
3128         (tui_display_reg_element_at_line): Update.
3129         * tui/tui-hooks.c (tui_register_changed)
3130         (tui_refresh_frame_and_register_information): Call
3131         tui_check_register_values.
3132         * tui/tui-data.h (struct tui_data_window) <data_content,
3133         data_content_count, data_type>: Remove.
3134         (enum tui_data_type): Remove.
3135
3136         * tui/tui-data.c (tui_data_window::clear_detail)
3137         (~tui_data_window): Update.
3138
3139 2019-06-25  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3142         declare.
3143         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3144         Rename from tui_first_data_item_displayed.  Update.
3145         (tui_data_window::refresh_all)
3146         (tui_data_window::do_scroll_vertical): Update.
3147         * tui/tui-data.h (struct tui_data_window)
3148         <first_data_item_displayed>: Declare new method.
3149
3150 2019-06-25  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3153         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3154         contents...
3155         (tui_initialize_static_data): ...here.
3156
3157 2019-06-25  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3160         (tui_display_registers_from, tui_check_register_values): Update.
3161         (tui_display_register): Remove win_info parameter; update.
3162         (tui_get_register): Change type of parameters.
3163         * tui/tui-data.h (struct tui_data_element): Remove.
3164         (union tui_which_element) <data>: Remove.
3165         <data_window>: Change type.
3166         (struct tui_data_item_window): New.
3167         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3168         case.  Add assert.
3169         (~tui_data_item_window): New destructor.
3170         (free_content_elements): Remove DATA_ITEM_WIN case.
3171
3172 2019-06-25  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3175         Remove.
3176
3177 2019-06-25  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-data.h (struct tui_command_element): Remove.
3180         (union tui_which_element) <command>: Remove.
3181         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3182         assert.
3183         (free_content_elements): Remove CMD_WIN case.
3184
3185 2019-06-25  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-layout.c (tui_set_layout): Update.
3188         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3189         * tui/tui-data.c (layout_def): Update.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3194         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3195         (tui_source_window_base::set_new_height): Update.
3196         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3197         Update.
3198         (tui_set_locator_fullname, tui_set_locator_info)
3199         (tui_show_frame_info): Update.
3200         * tui/tui-source.c (tui_set_source_content)
3201         (tui_source_is_displayed): Update.
3202         * tui/tui-layout.c (show_source_disasm_command, show_data)
3203         (show_source_or_disasm_and_command): Update.
3204         * tui/tui-disasm.c (tui_set_disassem_content)
3205         (tui_get_begin_asm_address): Update.
3206         * tui/tui-data.h (struct tui_locator_element): Remove.
3207         (union tui_which_element) <locator>: Remove.
3208         (struct tui_locator_window): New.
3209         (tui_locator_win_info_ptr): Change return type.
3210         * tui/tui-data.c (_locator): Change type.
3211         (tui_locator_win_info_ptr): Change return type.
3212         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3213         (tui_alloc_content): Add assert.
3214
3215 2019-06-25  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-winsource.c
3218         (tui_exec_info_window::maybe_allocate_content): New method.
3219         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3220         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3221         (make_source_or_disasm_window): Add cast.
3222         * tui/tui-data.h (union tui_which_element) <simple_string>:
3223         Remove.
3224         (struct tui_source_info): New.
3225         (struct tui_source_window_base) <execution_info>: Change type.
3226         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3227         case, and add assert.
3228         (tui_alloc_content): Add assert.
3229
3230 2019-06-25  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3233         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3234         * tui/tui-data.c (tui_alloc_win_info): Remove.
3235
3236 2019-06-25  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3239         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3240         can_highlight.
3241
3242 2019-06-25  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3245         make_visible_with_new_height method.
3246         (tui_win_info::make_visible_with_new_height): New method.
3247         (tui_source_window_base::do_make_visible_with_new_height)
3248         (tui_data_window::do_make_visible_with_new_height)
3249         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3250         (make_visible_with_new_height): Remove.
3251         (tui_resize_all, tui_adjust_win_heights): Use
3252         make_visible_with_new_height method.
3253         * tui/tui-data.h (struct tui_win_info)
3254         <do_make_visible_with_new_height, make_visible_with_new_height>:
3255         New methods.
3256         (struct tui_source_window_base, struct tui_data_window)
3257         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3258         methods.
3259
3260 2019-06-25  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3263         method.
3264         (update_tab_width): Call update_tab_width method.
3265         * tui/tui-data.h (struct tui_win_info)
3266         (struct tui_source_window_base) <update_tab_width>: New methods.
3267
3268 2019-06-25  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3271         parameter.
3272         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3273         parameter.
3274         (tui_gen_win_info::make_visible): Update.
3275         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3276         parameter.
3277         * tui/tui-data.h (enum tui_box): New enum.
3278         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3279
3280 2019-06-25  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3283         init_and_make_win for EXEC_INFO_WIN.
3284         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3285         longer inline.
3286         (struct tui_win_info) <~tui_win_info>: Inline.
3287         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3288         Don't declare.
3289         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3290         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3291         Remove.
3292         (tui_initialize_static_data): Update.
3293         (~tui_gen_win_info): Handle more cleanup here.
3294         (~tui_source_window_base): Delete "execution_info".
3295         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3296
3297 2019-06-25  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-layout.c (make_command_window): Don't set
3300         can_highlight.
3301         (show_source_disasm_command): Call the reset method.
3302         (show_data): Don't set can_highlight.  Call the reset method.
3303         (tui_gen_win_info::reset): Rename from init_gen_win_info
3304         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3305         (show_source_or_disasm_and_command): Call the reset method.
3306         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3307         (struct tui_cmd_window): Set can_highlight.
3308
3309 2019-06-25  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3312         from make_visible.
3313         (tui_make_visible, tui_make_invisible): Rewrite.
3314         (tui_win_info::make_visible): Remove.
3315         (tui_source_window_base::make_visible): Update.
3316         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3317         method.  Moved from...
3318         (struct tui_win_info) <make_visible>: ...here.
3319
3320 2019-06-25  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-winsource.c
3323         (tui_source_window_base::do_scroll_horizontal): Remove direction
3324         parameter.
3325         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3326         direction parameter.
3327         * tui/tui-win.c (tui_win_info::forward_scroll)
3328         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3329         (tui_win_info::right_scroll): Update.
3330         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3331         direction parameter.
3332         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3333         direction parameter.
3334         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3335         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3336         Remove direction parameter.
3337         (struct tui_source_window_base, struct tui_source_window)
3338         (struct tui_disasm_window, struct tui_data_window)
3339         (struct tui_cmd_window): Update.
3340
3341 2019-06-25  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-winsource.h (tui_set_exec_info_content)
3344         (tui_show_exec_info_content, tui_erase_exec_info_content)
3345         (tui_clear_exec_info_content, tui_update_exec_info): Change
3346         argument to tui_source_window_base.
3347         * tui/tui-winsource.c (tui_set_exec_info_content)
3348         (tui_show_exec_info_content, tui_erase_exec_info_content)
3349         (tui_clear_exec_info_content, tui_update_exec_info): Change
3350         argument to tui_source_window_base.
3351
3352 2019-06-25  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3355         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3360         check.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3365         type to void.
3366         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3367         type to void.
3368         * tui/tui-source.c (tui_set_source_content): Update.
3369         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3370
3371 2019-06-25  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-win.c (window_name_completer, tui_set_focus)
3374         (tui_all_windows_info): Use name method.
3375         * tui/tui-data.h (struct tui_gen_win_info)
3376         (struct tui_source_window, struct tui_disasm_window)
3377         (struct tui_data_window, struct tui_cmd_window) <name>: New
3378         method.
3379         (tui_win_name): Don't declare.
3380         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3381         (tui_win_name): Remove.
3382
3383 2019-06-25  Tom Tromey  <tom@tromey.com>
3384
3385         * tui/tui-winsource.h (tui_update_source_window)
3386         (tui_update_source_window_as_is): Change parameter type.
3387         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3388         to be a tui_source_window_base.
3389         (tui_update_source_window_as_is): Likewise.
3390         * tui/tui-win.c (make_visible_with_new_height): Update.
3391
3392 2019-06-25  Tom Tromey  <tom@tromey.com>
3393
3394         * tui/tui-winsource.c (tui_erase_source_content)
3395         (tui_show_source_content, tui_show_exec_info_content)
3396         (tui_erase_exec_info_content): Use refresh_window method.
3397         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3398         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3399         from tui_refresh_win.
3400         (tui_data_window::refresh_window): New method.
3401         (tui_win_info::refresh, tui_source_window_base::refresh)
3402         (tui_refresh_all): Use refresh_window method.
3403         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3404         method.
3405         * tui/tui-regs.c (tui_display_register): Call refresh_window
3406         method.
3407         * tui/tui-layout.c (show_source_disasm_command)
3408         (show_source_or_disasm_and_command): Call refresh_window method.
3409         * tui/tui-data.h (struct tui_gen_win_info)
3410         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3411         New method.
3412
3413 2019-06-25  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui.c (tui_rl_other_window, tui_enable)
3416         (tui_is_window_visible, tui_get_command_dimension): Update.
3417         * tui/tui-winsource.c (tui_update_source_window_as_is)
3418         (tui_clear_source_content, tui_erase_source_content)
3419         (tui_show_source_line, tui_source_window_base::refill)
3420         (tui_source_window_base::do_scroll_horizontal)
3421         (tui_source_window_base::set_is_exec_point_at)
3422         (tui_update_breakpoint_info, tui_set_exec_info_content)
3423         (tui_alloc_source_buffer, tui_line_is_displayed)
3424         (tui_addr_is_displayed): Update.
3425         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3426         (tui_check_and_display_highlight_if_needed)
3427         (tui_win_info::make_visible, tui_win_info::refresh)
3428         (tui_refresh_all): Update.
3429         * tui/tui-windata.c (tui_first_data_item_displayed)
3430         (tui_delete_data_content_windows, tui_erase_data_content)
3431         (tui_display_all_data, tui_data_window::refresh_all)
3432         (tui_check_data_values): Update.
3433         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3434         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3435         (tui_win_info::backward_scroll, tui_refresh_all_win)
3436         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3437         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3438         (tui_source_window_base::set_new_height)
3439         (tui_data_window::set_new_height)
3440         (make_invisible_and_set_new_height)
3441         (make_visible_with_new_height, new_height_ok)
3442         (parse_scrolling_args): Update.
3443         * tui/tui-stack.c (tui_show_frame_info): Update.
3444         * tui/tui-source.c (tui_set_source_content)
3445         (tui_set_source_content_nil, tui_source_is_displayed)
3446         (tui_source_window::do_scroll_vertical): Update.
3447         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3448         (tui_display_registers_from, tui_display_reg_element_at_line)
3449         (tui_check_register_values, tui_reg_command): Update.
3450         * tui/tui-layout.c (tui_default_win_height)
3451         (show_source_disasm_command, show_data, init_and_make_win)
3452         (show_source_or_disasm_and_command): Update.
3453         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3454         (tui_redisplay_readline, tui_mld_flush)
3455         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3456         (tui_getc): Update.
3457         * tui/tui-disasm.c (tui_set_disassem_content)
3458         (tui_disasm_window::do_scroll_vertical): Update.
3459         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3460         Now virtual.
3461         (struct tui_win_info): Derive from tui_gen_win_info.
3462         <~tui_win_info>: Mark as override.
3463         <generic>: Remove member.
3464         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3465         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3466         (~tui_data_window, ~tui_win_info)
3467         (tui_free_all_source_wins_content): Update.
3468         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3469
3470 2019-06-25  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-layout.c (init_and_make_win): Use new.
3473         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3474         destructor, initializers.
3475         (tui_alloc_generic_win_info): Don't declare.
3476         * tui/tui-data.c (_locator): Add argument to constructor.
3477         (source_win, disasm_win): New globals.
3478         (exec_info): Remove.
3479         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3480         Update.
3481         (tui_alloc_generic_win_info): Remove.
3482         (init_content_element): Use new.
3483         (tui_win_info::tui_win_info): Update.
3484         (free_content_elements) <case DATA_WIN>: Use delete.
3485
3486 2019-06-25  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3489         * tui/tui-windata.c (tui_first_data_item_displayed)
3490         (tui_delete_data_content_windows): Update.
3491         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3492         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3493         (tui_display_registers_from, tui_check_register_values): Update.
3494         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3495         pointer.
3496         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3497         window.
3498         (tui_free_data_content): Update.
3499         (free_content_elements) <case DATA_WIN>: Free the window.
3500
3501 2019-06-25  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3504         Update.
3505         * tui/tui-layout.c (make_command_window)
3506         (show_source_disasm_command, show_data, init_and_make_win)
3507         (show_source_or_disasm_and_command): Update.
3508         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3509         method.
3510         <can_highight, is_highlighted>: Now bool.
3511         (tui_set_win_highlight): Don't declare.
3512         * tui/tui-data.c (tui_set_win_highlight): Remove.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-wingeneral.c (make_visible): Remove check of window
3517         type.
3518
3519 2019-06-25  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-win.c (tui_win_info::max_height)
3522         (tui_cmd_window::max_height): New methods.
3523         (new_height_ok): Call max_height.
3524         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3525         <max_height>: New method.
3526
3527 2019-06-25  Tom Tromey  <tom@tromey.com>
3528
3529         * tui/tui-win.c (tui_source_window_base::set_new_height)
3530         (tui_data_window::set_new_height): New methods.
3531         (make_invisible_and_set_new_height): Call set_new_height method.
3532         * tui/tui-data.h (struct tui_win_info)
3533         (struct tui_source_window_base, struct tui_data_window)
3534         <set_new_height>: New method.
3535
3536 2019-06-25  Tom Tromey  <tom@tromey.com>
3537
3538         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3539         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3540         tui_refresh_data_win.
3541         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3542         method.
3543         (tui_refresh_all_win): Call the refresh_all method.
3544         (tui_set_focus): Likewise.
3545         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3546         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3547         Likewise.
3548
3549 2019-06-25  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-winsource.h (tui_refill_source_window)
3552         (tui_set_is_exec_point_at): Don't declare.
3553         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3554         (tui_source_window_base::refill): Rename from
3555         tui_refill_source_window.
3556         (tui_source_window_base::do_scroll_horizontal): Update.
3557         (tui_source_window_base::set_is_exec_point_at): Rename from
3558         tui_set_is_exec_point_at.
3559         (tui_update_all_breakpoint_info): Update.
3560         * tui/tui-stack.c (tui_show_frame_info): Update.
3561         * tui/tui-layout.c (show_data): Add cast.
3562         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3563         * tui/tui-data.h (struct tui_source_window_base) <refill,
3564         set_is_exec_point_at>: New methods.
3565         (tui_source_windows, tui_add_to_source_windows): Update types.
3566         (tui_add_to_source_windows): Remove redundant declaration.
3567         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3568         (tui_source_windows): Change return type.
3569         (tui_clear_source_windows_detail): Update.
3570         (tui_add_to_source_windows): Change type of parameter.
3571         (tui_free_all_source_wins_content): Update.
3572
3573 2019-06-25  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui-wingeneral.c (tui_win_info::refresh)
3576         (tui_source_window_base::refresh): New methods.
3577         (tui_refresh_all): Call the refresh method.
3578         * tui/tui-data.h (struct tui_win_info)
3579         (struct tui_source_window_base) <refresh>: New method.
3580
3581 2019-06-25  Tom Tromey  <tom@tromey.com>
3582
3583         * tui/tui.h (tui_is_window_visible): Return bool.
3584         * tui/tui.c (tui_is_window_visible): Return bool.
3585         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3586         (tui_make_visible, tui_make_invisible)
3587         (tui_win_info::make_visible)
3588         (tui_source_window_base::make_visible, make_all_visible)
3589         (tui_make_all_visible, tui_make_all_invisible): Update.
3590         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3591         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3592         bool.
3593         (struct tui_win_info, struct tui_source_window_base)
3594         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3595         * tui/tui-data.c (tui_init_generic_part): Update.
3596
3597 2019-06-25  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3600         (tui_source_window_base::make_visible): New methods.
3601         (make_all_visible): Make method call.
3602         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3603         (struct tui_source_window_base, struct tui_cmd_window): Override
3604         make_visible.
3605         (tui_win_is_source_type): Don't declare.
3606         * tui/tui-data.c (tui_win_is_source_type): Remove.
3607
3608 2019-06-25  Tom Tromey  <tom@tromey.com>
3609
3610         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3611         NULL check.
3612
3613 2019-06-25  Tom Tromey  <tom@tromey.com>
3614
3615         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3616         Inline constructor.  Add initializers for members.
3617         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3618         constructors; now inline in class.
3619
3620 2019-06-25  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-regs.c (tui_show_registers): Update.
3623         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3624         bool.
3625         * tui/tui-data.c (tui_data_window::clear_detail)
3626         (tui_data_window): Update.
3627
3628 2019-06-25  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-windata.c (tui_display_all_data)
3631         (tui_display_data_from_line, tui_display_data_from)
3632         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3633         Update.
3634         * tui/tui-regs.c (tui_last_regs_line_no)
3635         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3636         (tui_show_registers, tui_show_register_group)
3637         (tui_display_registers_from, tui_display_reg_element_at_line)
3638         (tui_display_registers_from_line, tui_check_register_values)
3639         (tui_reg_next, tui_reg_prev): Update.
3640         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3641         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3642         tui_data_window.
3643         (struct tui_win_info) <detail>: Remove.  Add new fields from
3644         tui_data_info.
3645         (TUI_DATA_WIN): Add cast.
3646         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3647         (~tui_data_window): Simplify.
3648
3649 2019-06-25  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-layout.c (show_source_disasm_command)
3652         (show_source_or_disasm_and_command): Update.
3653         * tui/tui-io.c (update_cmdwin_start_line)
3654         (tui_redisplay_readline): Update.
3655         * tui/tui-data.h (struct tui_command_info): Remove.
3656         (struct tui_win_info) <detail>: Remove command_info member.
3657         (struct tui_data_window) <start_line>: New member, from
3658         tui_command_info.
3659         (TUI_CMD_WIN): Add casts.
3660
3661 2019-06-25  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-winsource.c (tui_update_source_window)
3664         (tui_refill_source_window)
3665         (tui_source_window_base::do_scroll_horizontal)
3666         (tui_update_breakpoint_info, tui_set_exec_info_content)
3667         (tui_show_exec_info_content, tui_erase_exec_info_content)
3668         (tui_clear_exec_info_content): Update.
3669         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3670         Update.
3671         * tui/tui-win.c (make_invisible_and_set_new_height)
3672         (make_visible_with_new_height): Update.
3673         * tui/tui-source.c (tui_set_source_content)
3674         (tui_show_symtab_source): Update.
3675         * tui/tui-layout.c (extract_display_start_addr)
3676         (show_source_disasm_command, show_data)
3677         (make_source_or_disasm_window)
3678         (show_source_or_disasm_and_command): Update.
3679         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3680         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3681         "gdbarch".
3682         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3683         to tui_source_window_base.
3684         (struct tui_win_info) <detail>: Remove source_info member.
3685         (struct tui_source_window_base) <has_locator>: Inline.
3686         Move contents from tui_source_info; rename has_locator member to
3687         m_has_locator.
3688         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3689         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3690         header file.
3691         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3692         Simplify.
3693         (tui_free_all_source_wins_content): Cast to
3694         tui_source_window_base.
3695
3696 2019-06-25  Tom Tromey  <tom@tromey.com>
3697
3698         * tui/tui-win.c (make_invisible_and_set_new_height)
3699         (make_visible_with_new_height): Call has_locator method.
3700         * tui/tui-layout.c (show_source_disasm_command, show_data)
3701         (show_source_or_disasm_and_command): Update for bool change.
3702         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3703         (tui_win_info) <has_locator>: New method.
3704         (struct tui_source_window_base) <has_locator>: New method.
3705         (tui_win_has_locator): Don't declare.
3706         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3707         from tui_win_has_locator.
3708         (tui_source_window_base): Use false, not FALSE.
3709
3710 2019-06-25  Tom Tromey  <tom@tromey.com>
3711
3712         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3713         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3714         clear_detail method directly.
3715         (tui_clear_win_detail): Remove.
3716
3717 2019-06-25  Tom Tromey  <tom@tromey.com>
3718
3719         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3720         "this", not TUI_DISASM_WIN.
3721
3722 2019-06-25  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3725         declare.
3726         * tui/tui-winsource.c
3727         (tui_source_window_base::do_scroll_horizontal): Rename from
3728         tui_horizontal_source_scroll.
3729         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3730         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3731         from tui_vertical_data_scroll.
3732         * tui/tui-win.h (tui_scroll): Don't declare.
3733         * tui/tui-win.c (tui_win_info::forward_scroll)
3734         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3735         (tui_win_info::right_scroll): Rename and update.
3736         (tui_scroll_forward_command, tui_scroll_backward_command)
3737         (tui_scroll_left_command, tui_scroll_right_command): Update.
3738         (tui_scroll): Remove.
3739         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3740         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3741         from tui_vertical_source_scroll.
3742         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3743         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3744         from tui_vertical_disassem_scroll.
3745         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3746         do_scroll_horizontal>: New methods.
3747         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3748         Likewise.
3749         (struct tui_source_window_base): Add do_scroll_horizontal.
3750         (struct tui_source_window, struct tui_disasm_window): Add
3751         do_scroll_vertical.
3752         (struct tui_data_window, struct tui_cmd_window): Add
3753         do_scroll_horizontal and do_scroll_vertical.
3754         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3755
3756 2019-06-25  Tom Tromey  <tom@tromey.com>
3757
3758         * tui/tui-data.h (struct tui_source_window_base): New struct.
3759         (struct tui_source_window): Derive from tui_source_window_base.
3760         (struct tui_disasm_window): New struct.
3761         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3762         from tui_source_window::clear_detail.
3763         (tui_source_window_base): Rename from tui_source_window.
3764         (~tui_source_window_base): Rename from ~tui_source_window.
3765         (tui_alloc_win_info): Create a tui_disasm_window.
3766
3767 2019-06-25  Tom Tromey  <tom@tromey.com>
3768
3769         * tui/tui-data.h (struct tui_source_window)
3770         (struct tui_data_window): Declare destructors.
3771         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3772         destructors.
3773         (tui_win_info): Simplify.
3774
3775 2019-06-25  Tom Tromey  <tom@tromey.com>
3776
3777         * tui/tui-winsource.c (tui_display_main)
3778         (tui_update_source_windows_with_addr)
3779         (tui_update_all_breakpoint_info): Update.
3780         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3781         (new_height_ok, parse_scrolling_args): Update.
3782         * tui/tui-stack.c (tui_show_frame_info): Update.
3783         * tui/tui-data.h (struct tui_list): Remove.
3784         (tui_source_windows): Return a reference to a std::vector.
3785         * tui/tui-data.c (source_windows): Now a std::vector.
3786         (tui_source_windows): Change return type.
3787         (tui_clear_source_windows): Rewrite.
3788         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3789         (tui_free_all_source_wins_content): Rewrite.
3790
3791 2019-06-25  Tom Tromey  <tom@tromey.com>
3792
3793         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3794         (struct tui_data_window, struct tui_cmd_window): Declare
3795         clear_detail method.
3796         * tui/tui-data.c (tui_source_window::clear_detail)
3797         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3798         methods.
3799         (tui_clear_win_detail): Simplify.
3800
3801 2019-06-25  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-layout.c (make_source_window, make_disasm_window)
3804         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3805         Return the new window.
3806         (show_source_disasm_command, show_data)
3807         (show_source_or_disasm_and_command): Update.
3808
3809 2019-06-25  Tom Tromey  <tom@tromey.com>
3810
3811         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3812         parameter.  Return the new window.
3813         (show_source_disasm_command): Update and remove NULL check.
3814         (show_source_or_disasm_and_command): Update.
3815
3816 2019-06-25  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3819
3820 2019-06-25  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-data.h (struct tui_win_info): Make constructor
3823         protected.  Make destructor virtual.  Add initializers.
3824         (tui_source_window, tui_data_window, tui_cmd_window): New
3825         classes.
3826         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3827         constructor.  Add "type" parameter.
3828         (tui_source_window, tui_data_window, tui_cmd_window): New
3829         constructors.
3830         (tui_alloc_win_info): Instantiate the appropriate subclass.
3831
3832 2019-06-25  Tom Tromey  <tom@tromey.com>
3833
3834         * tui/tui-win.c (tui_resize_all): Use delete.
3835         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3836         destructor.
3837         (tui_free_window): Don't declare.
3838         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3839         Update.
3840
3841 2019-06-25  Tom Tromey  <tom@tromey.com>
3842
3843         * tui/tui-data.h (struct tui_win_info): Add constructor.
3844         * tui/tui-data.c (tui_alloc_win_info): Use new.
3845         (tui_free_window): Use delete.
3846
3847 2019-06-22  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3850         declare.
3851         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3852
3853 2019-06-22  Tom Tromey  <tom@tromey.com>
3854
3855         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3856         declare.
3857         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3858
3859 2019-06-22  Tom de Vries  <tdevries@suse.de>
3860
3861         * dwarf2read.c (create_addrmap_from_aranges)
3862         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3863         instead of '%zu'.
3864
3865 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3866
3867         * dwarf2read.h (dwarf2_section_info_def): Remove.
3868         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3869         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3870         std::vector<dwarf2_section_info>.
3871         (struct dwo_file) <~dwo_file>: Remove.
3872         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3873         types field.
3874         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3875         (dwarf2_read_debug_names): Likewise.
3876         (create_debug_types_hash_table): Change parameter type to
3877         array_view, adjust code accordingly.
3878         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3879         (partial_die_info::fixup): Likewise.
3880         (determine_prefix): Likewise.
3881         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3882
3883 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3884
3885         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3886         gdb_bfd_ref_ptr.
3887         <~dwo_file>: Remove call to gdb_bfd_unref.
3888         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3889         gdb_bfd_ref_ptr::get.
3890
3891 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3892
3893         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3894         type to htab_up.
3895         * dwarf2read.c (struct dwo_file): Initialize fields.
3896         <~dwo_file>: New.
3897         (free_dwo_file): Remove, move content to ~dwo_file.
3898         (struct dwo_file_deleter): Remove.
3899         (dwo_file_up>: Remove custom deleter.
3900         (free_dwo_files): Remove.
3901         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3902         dwo_files.
3903         (process_skeletonless_type_units): Call unique_ptr::get.
3904         (allocate_dwo_file_hash_table): Add deleter to created hash
3905         table.  Change return type to htab_up.
3906         (lookup_dwo_file_slot): Don't memset dwo_file, call
3907         unique_ptr::get.
3908         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3909         (create_dwo_unit_in_dwp_v2): Likewise.
3910         (open_and_init_dwo_file): Likewise.
3911         (free_dwo_file_from_slot): Remove.
3912
3913 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3914
3915         * dwarf2read.h (struct dwarf2_section_info) <readin,
3916         is_virtual>: Change type to bool.
3917         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3918         true instead of 1.
3919
3920 2019-06-19  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui-data.h (tui_init_content_element): Don't declare.
3923
3924 2019-06-19  Tom Tromey  <tom@tromey.com>
3925
3926         * tui/tui-data.h (tui_init_win_info): Don't declare.
3927
3928 2019-06-19  Tom de Vries  <tdevries@suse.de>
3929
3930         * dwarf2read.h (abstract_to_concrete): Change type to
3931         std::unordered_map<sect_offset, std::vector<sect_offset>,
3932         gdb::hash_enum<sect_offset>>.
3933
3934 2019-06-19  Tom Tromey  <tromey@adacore.com>
3935
3936         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3937         EVAL_AVOID_SIDE_EFFECTS specially.
3938
3939 2019-06-19  Tom Tromey  <tromey@adacore.com>
3940
3941         * source-cache.c (highlighter): New global.
3942         (source_cache::get_source_lines): Create a highlighter on demand.
3943
3944 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3945
3946         * defs.h (deprecated_interactive_hook): Delete declaration.
3947         * interps.c (clear_interpreter_hooks): Remove use of
3948         deprecated_interactive_hook.
3949         * top.c (deprecated_interactive_hook): Delete definition.
3950         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3951
3952 2019-06-18  Tom de Vries  <tdevries@suse.de>
3953
3954         PR gdb/24515
3955         * dwarf2read.h (abstract_to_concrete): Change type from
3956         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3957         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3958         * dwarf2read.c (read_variable): Update.
3959         (dwarf2_fetch_die_loc_sect_off): Update.
3960
3961 2019-06-17  Tom de Vries  <tdevries@suse.de>
3962
3963         PR gdb/24617
3964         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3965         accessing parent[parent_len - 1].
3966
3967 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3968
3969         PR gdb/24364
3970         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3971         call dtrace_process_dof with NULL dof.
3972
3973 2019-06-16  Tom de Vries  <tdevries@suse.de>
3974
3975         PR gdb/24445
3976         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3977
3978 2019-06-16  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3981         (make_all_visible): Use address of member.
3982
3983 2019-06-16  Tom Tromey  <tom@tromey.com>
3984
3985         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3986         (tui_free_window, free_content, free_content_elements): Remove
3987         unnecessary cast.
3988         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3989         cast.
3990         * tui/tui-regs.c (tui_show_register_group)
3991         (tui_display_registers_from, tui_display_reg_element_at_line):
3992         Remove unnecessary cast.
3993
3994 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3995
3996         * linux-nat.c (normal_mask): Delete.
3997         (_initialize_linux_nat): Don't initialise normal_mask.
3998
3999 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4000
4001         PR gdb/24445
4002         * dwarf-index-write.h (write_psymtabs_to_index): Add
4003         dwz_basename parameter.
4004         * dwarf-index-write.c (write_gdbindex): Move file writing to
4005         write_gdbindex_1.  Change return type void.
4006         (assert_file_size): Move up, remove filename parameter.
4007         (write_gdbindex_1): New function.
4008         (write_debug_names): Change return type to void, call
4009         assert_file_size.
4010         (struct index_wip_file): New struct.
4011         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4012         file logic to index_wip_file.  Write index for dwz file if
4013         needed.
4014         (save_gdb_index_command): Pass basename of dwz file, if present.
4015         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4016         build-id of dwz file, if present.
4017         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4018         (dwarf2_get_dwz_file): Likewise.
4019         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4020         (dwarf2_get_dwz_file): Likewise.
4021
4022 2019-06-16  Tom Tromey  <tom@tromey.com>
4023
4024         * coffread.c (process_coff_symbol): Use xstrdup.
4025         * value.c (create_internalvar): Use xstrdup.
4026
4027 2019-06-16  Tom Tromey  <tom@tromey.com>
4028
4029         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4030         * breakpoint.c (stopin_command, stopat_command)
4031         (until_break_command, decode_location_default): Remove unnecessary
4032         cast.
4033         * utils.c (subset_compare): Remove unnecessary cast.
4034         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4035         cast.
4036         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4037         cast.
4038         * infcmd.c (path_command): Remove unnecessary cast.
4039         * coffread.c (decode_type): Remove unnecessary cast.
4040         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4041         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4042         * tui/tui-stack.c (tui_show_locator_content)
4043         (tui_show_frame_info): Remove unnecessary cast.
4044         * tui/tui-win.c (tui_scroll_forward_command)
4045         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4046         (parse_scrolling_args): Remove unnecessary cast.
4047         * tui/tui-data.c (init_win_info, tui_del_window)
4048         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4049         (free_content_elements): Remove unnecessary cast.
4050         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4051         unnecessary cast.
4052         * tui/tui-source.c (tui_set_source_content)
4053         (tui_vertical_source_scroll): Remove unnecessary cast.
4054         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4055         cast.
4056         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4057         * tui/tui-regs.c (tui_display_registers_from)
4058         (tui_display_register): Remove unnecessary cast.
4059         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4060         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4061         (make_visible): Remove unnecessary cast.
4062         * tui/tui-winsource.c (tui_erase_source_content)
4063         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4064         unnecessary cast.
4065         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4066         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4067         * stabsread.c (read_type, read_array_type, read_range_type):
4068         Remove unnecessary cast.
4069         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4070         (parse_symbol, parse_type, upgrade_type, parse_external)
4071         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4072         unnecessary cast.
4073         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4074
4075 2019-06-16  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-data.c (tui_alloc_generic_win_info)
4078         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4079         checks.
4080
4081 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4082             Andrew Burgess  <andrew.burgess@embecosm.com>
4083
4084         * f-typeprint.c (f_print_type): Don't return early for not
4085         associated or not allocated types.
4086         (f_type_print_varspec_suffix): Add print_rank parameter and print
4087         ranks of array types in case they dangling.
4088         (f_type_print_base): Add print_rank parameter.
4089
4090 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4091
4092         * NEWS: Mention new MI commands.
4093         * break-catch-throw.c (enum exception_event_kind): Move to
4094         breakpoint.h.
4095         (print_mention_exception_catchpoint): Output text as a single
4096         message.
4097         (catch_exception_command_1): Rename to...
4098         (catch_exception_event): ...this, make non-static, update header
4099         command, and change some parameter types.
4100         (catch_catch_command): Update for changes to
4101         catch_exception_command_1.
4102         (catch_throw_command): Likewise.
4103         (catch_rethrow_command): Likewise.
4104         * breakpoint.c (enum exception_event_kind): Delete.
4105         * breakpoint.h (enum exception_event_kind): Moved here from
4106         break-catch-throw.c.
4107         (catch_exception_event): Declare.
4108         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4109         (mi_cmd_catch_throw): New function.
4110         (mi_cmd_catch_rethrow): New function.
4111         (mi_cmd_catch_catch): New function.
4112         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4113         'catch-catch' entries.
4114         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4115         (mi_cmd_catch_rethrow): Declare.
4116         (mi_cmd_catch_catch): Declare.
4117
4118 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4119
4120         * annotate.c (annotate_source_line): Change return type to void,
4121         update implementation to match.
4122         * annotate.h (annotate_source_line): Change return type to void,
4123         update header comment.
4124         * stack.c (print_frame_info): Don't change what frame information
4125         is printed based on whether annotations are on or not.
4126
4127 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4128
4129         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4130         (annotate_source): Make static.
4131         (annotate_source_line): Moved from source.c and renamed from
4132         identify_source_line.  Update the return type.
4133         * annotate.h (annotate_source): Delete declaration.
4134         (annotate_source_line): Declaration moved from source.h, and
4135         renamed from identify_source_line.  Return type updated.
4136         * source.c (identify_source_line): Moved to annotate.c and renamed
4137         to annotate_source_line.
4138         (info_line_command): Remove check of annotation_level.
4139         * source.h (identify_source_line): Move declaration to annotate.h
4140         and rename to annotate_source_line.
4141         * stack.c: Add 'annotate.h' include.
4142         (print_frame_info): Remove check of annotation_level before
4143         calling annotate_source_line.
4144
4145 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4146
4147         * source-cache.c (source_cache::get_plain_source_lines): Use
4148         open_source_file_with_line_charpos instead of just
4149         open_source_file, remove call to find_source_lines.
4150         (source_cache::get_source_lines): Likewise.
4151         * source.c (find_source_lines): Make static.
4152         (get_filename_and_charpos): Renamed into...
4153         (open_source_file_with_line_charpos): ..this along with changes to
4154         return a scoped_fd, and some other minor clean ups.
4155         (identify_source_line): Use open_source_file_with_line_charpos.
4156         (search_command_helper): Use open_source_file_with_line_charpos
4157         instead of just open_source_file, remove call to
4158         find_source_lines.
4159         * source.h (open_source_file_with_line_charpos): Declare new
4160         function.
4161         (find_source_lines): Delete declaration.
4162
4163 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4164
4165         * source.c (get_filename_and_charpos): Remove fullname
4166         parameter.
4167         (identify_source_line): Update call to get_filename_and_charpos.
4168
4169 2019-06-14  Tom Tromey  <tromey@adacore.com>
4170
4171         PR gdb/24502:
4172         * ui-style.h (skip_ansi_escape): Update comment.
4173         * ui-file.h (class no_terminal_escape_file): New class.
4174         * ui-file.c (no_terminal_escape_file::write)
4175         (no_terminal_escape_file::puts): New methods.
4176         * cli/cli-logging.c (handle_redirections): Use
4177         no_terminal_escape_file.
4178
4179 2019-06-14  Tom Tromey  <tromey@adacore.com>
4180
4181         * NEWS: Move convenience variable news above Python news.
4182
4183 2019-06-14  Tom Tromey  <tom@tromey.com>
4184
4185         * gnulib: Move directory to top-level.
4186         * configure.ac: Don't configure gnulib.
4187         * configure: Rebuild.
4188         * common/common-defs.h: Use new path to gnulib.
4189         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4190         (GNULIB_H): Remove.
4191         (INCGNU): Look in new gnulib location.
4192         (HFILES_NO_SRCDIR): Remove gnulib files.
4193         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4194         (generated_files): Remove GNULIB_H.
4195         ($(LIBGNU), all-lib): Remove targets.
4196         (distclean): Don't mention GNULIB_BUILDDIR.
4197         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4198
4199 2019-06-14  Tom Tromey  <tromey@adacore.com>
4200
4201         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4202         Warn if symbol file does not provide any symbols.
4203
4204 2019-06-14  Tom Tromey  <tromey@adacore.com>
4205
4206         * source.c (find_and_open_source): Respect basenames_may_differ.
4207
4208 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * annotate.c (annotate_breakpoints_invalid): Make use of
4211         scoped_restore_terminal_state.
4212         (annotate_frames_invalid): Likewise.
4213
4214 2019-06-14  Tom Tromey  <tromey@adacore.com>
4215
4216         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4217         allow assignment to an internalvar.
4218
4219 2019-06-14  Tom Tromey  <tromey@adacore.com>
4220
4221         * ada-lex.l: Allow "_" in attribute names.
4222
4223 2019-06-14  Tom Tromey  <tromey@adacore.com>
4224
4225         PR gdb/24653:
4226         * regcache.c (registers_changed): Don't call alloca.
4227         * top.c (execute_command): Don't call alloca.
4228
4229 2019-06-13  Pedro Alves  <palves@redhat.com>
4230
4231         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4232         'expression'.  When parsing an expression, error out if there's
4233         junk after "unlimited".
4234         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4235         (do_set_command): Adjust calls to is_unlimited_literal.
4236
4237 2019-06-13  Pedro Alves  <palves@redhat.com>
4238
4239         * compile/compile.c (make_compile_options_def_group): Add braces
4240         around array_view initializer.
4241         * thread.c (make_thread_apply_all_options_def_group)
4242         (make_thread_apply_all_options_def_group): Likewise.
4243
4244 2019-06-13  Pedro Alves  <palves@redhat.com>
4245
4246         * NEWS (New commands): Mention "maint test-options
4247         require-delimiter", "maint test-options unknown-is-error", "maint
4248         test-options unknown-is-operand" and "maint show
4249         test-options-completion-result".
4250         (New command options, command completion): New section.
4251         (Completion improvements): New section.
4252         Mention that you can abbreviate "unlimited".
4253
4254 2019-06-13  Pedro Alves  <palves@redhat.com>
4255
4256         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4257         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4258         * unittests/cli-utils-selftests.c (test_parse_flags)
4259         (test_parse_flags_qcs): Delete.
4260         (test_cli_utils): Don't call deleted functions.
4261
4262 2019-06-13  Pedro Alves  <palves@redhat.com>
4263
4264         * thread.c: Include "cli/cli-option.h".
4265         (tp_array_compar_ascending): Global.
4266         (tp_array_compar): Delete function.
4267         (tp_array_compar_ascending, tp_array_compar_descending): New
4268         functions.
4269         (ascending_option_def, qcs_flag_option_def)
4270         (thr_qcs_flags_option_defs)
4271         (make_thread_apply_all_options_def_group)
4272         (make_thread_apply_options_def_group): New.
4273         (thread_apply_all_command): Use gdb::option::process_options.
4274         (thread_apply_command_completer)
4275         (thread_apply_all_command_completer): New.
4276         (thread_apply_command): Use gdb::option::process_options.
4277         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4278         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4279         to generate help text of "thread apply".  Adjust "taas"'s help.
4280         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4281         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4282
4283 2019-06-13  Pedro Alves  <palves@redhat.com>
4284
4285         * thread.c (thread_apply_command): Check for invalid TID with
4286         isdigit instead of !isalpha.
4287
4288 2019-06-13  Pedro Alves  <palves@redhat.com>
4289
4290         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4291         (validate_flags_qcs): New.
4292         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4293         (validate_flags_qcs): Declare.
4294         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4295         (make_frame_apply_options_def_group): New.
4296         (frame_apply_command_count): Process options with
4297         gdb::option::process_options.
4298         (frame_apply_completer): New.
4299         (frame_apply_level_completer, frame_apply_all_completer)
4300         (frame_apply_completer): New.
4301         (_initialize_stack): Update help of "frame apply", "frame apply
4302         level", "frame apply all" and "faas" to mention supported options
4303         and install command completers.
4304         * stack.h (frame_apply_all_completer): Declare.
4305         * thread.c: Include "stack.h".
4306         (tfaas_command): Add "--".
4307         (_initialize_thread): Update help "tfaas" to mention supported
4308         options and install command completer.
4309
4310 2019-06-13  Pedro Alves  <palves@redhat.com>
4311
4312         * completer.c (complete_nested_command_line): New.
4313         (gdb_completion_word_break_characters_throw): Add assertion.
4314         * completer.h (complete_nested_command_line): Declare.
4315
4316 2019-06-13  Pedro Alves  <palves@redhat.com>
4317
4318         * stack.c (parse_backtrace_qualifiers): New.
4319         (backtrace_command): Use it.
4320         (backtrace_command_completer): Complete on qualifiers.
4321
4322 2019-06-13  Pedro Alves  <palves@redhat.com>
4323
4324         * frame.c: Include "cli/cli-option.h.
4325         (user_set_backtrace_options): New.
4326         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4327         Delete.
4328         (get_prev_frame): Adjust.
4329         (boolean_option_def, uinteger_option_def)
4330         (set_backtrace_option_defs): New.
4331         (_initialize_frame): Adjust and use
4332         gdb::option::add_setshow_cmds_for_options to install "set
4333         backtrace past-main" and "set backtrace past-entry".
4334         * frame.h: Include "cli/cli-option.h".
4335         (struct frame_print_options): Forward declare.
4336         (print_frame_arguments_all, print_frame_arguments_scalars)
4337         (print_frame_arguments_none): Declare.
4338         (print_entry_values): Delete declaration.
4339         (struct frame_print_options, user_frame_print_options): New.
4340         (struct set_backtrace_options): New.
4341         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4342         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4343         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4344         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4345         (list_args_or_locals): Add frame_print_options parameter.
4346         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4347         * python/py-framefilter.c (enumerate_args): Pass down
4348         USER_FRAME_PRINT_OPTIONS.
4349         * stack.c: Include "cli/cli-option.h".
4350         (print_frame_arguments_all, print_frame_arguments_scalars)
4351         (print_frame_arguments_none): Declare.
4352         (print_raw_frame_arguments, print_entry_values): Delete.
4353         (user_frame_print_options): New.
4354         (boolean_option_def, enum_option_def, frame_print_option_defs):
4355         New.
4356         (struct backtrace_cmd_options): New.
4357         (bt_flag_option_def): New.
4358         (backtrace_command_option_defs): New.
4359         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4360         (print_frame_arg, read_frame_arg, print_frame_args)
4361         (print_frame_info, print_frame): Add frame_print_options parameter
4362         and use it.
4363         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4364         (backtrace_command_1): Add frame_print_options and
4365         backtrace_cmd_options parameters and use them.
4366         (make_backtrace_options_def_group): New.
4367         (backtrace_command): Process command options with
4368         gdb::option::process_options.
4369         (backtrace_command_completer): New.
4370         (_initialize_stack): Extend "backtrace"'s help to mention
4371         supported options.  Install completer for "backtrace".
4372         Install some settings commands with add_setshow_cmds_for_options.
4373
4374 2019-06-13  Pedro Alves  <palves@redhat.com>
4375
4376         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4377         and that "set/show print raw frame-arguments" are now deprecated.
4378
4379         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4380         command.
4381         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4382         * stack.c (_initialize_stack): Install "set/show print
4383         raw-frame-arguments", and deprecate "set/show print raw
4384         frame-arguments".
4385         * valprint.c (_initialize_valprint): Deprecate "set/show print
4386         raw".
4387
4388 2019-06-13  Pedro Alves  <palves@redhat.com>
4389
4390         * compile/compile.c (struct compile_options): New.
4391         (compile_flag_option_def, compile_command_option_defs)
4392         (make_compile_options_def_group): New.
4393         (compile_file_command): Handle options with
4394         gdb::option::process_options.
4395         (compile_file_command_completer): New function.
4396         (compile_code_command): Handle options with
4397         gdb::option::process_options.
4398         (compile_code_command_completer): New function.
4399         (_initialize_compiler): Install completers for "compile code" and
4400         "compile file".  Mention available options in "compile code" and
4401         "compile code"'s help.
4402         * completer.c (advance_to_completion_word): New, factored out from
4403         ...
4404         (advance_to_expression_complete_word_point): ... this.
4405         (advance_to_filename_complete_word_point): New.
4406         * completer.h (advance_to_filename_complete_word_point): New
4407         declaration.
4408
4409 2019-06-13  Pedro Alves  <palves@redhat.com>
4410
4411         * compile/compile.c: Include "cli/cli-option.h".
4412         (compile_print_value): Scope data pointer is now a
4413         value_print_options pointer; adjust.
4414         (compile_print_command): Process options.  Scope data pointer is
4415         now a value_print_options pointer; adjust.
4416         (_initialize_compile): Update "compile print"'s help to include
4417         supported options.  Install a completer for "compile print".
4418         * cp-valprint.c (show_vtblprint, show_objectprint)
4419         (show_static_field_print): Delete.
4420         (_initialize_cp_valprint): Don't install "set print
4421         static-members", "set print vtbl", "set print object" here.
4422         * printcmd.c: Include "cli/cli-option.h" and
4423         "common/gdb_optional.h".
4424         (print_command_parse_format): Rework to fill in a
4425         value_print_options instead of a format_data.
4426         (print_value): Change parameter type from format_data pointer to
4427         value_print_options reference.  Adjust.
4428         (print_command_1): Process options.  Adjust to pass down a
4429         value_print_options.
4430         (print_command_completer): New.
4431         (_initialize_printcmd): Install print_command_completer as
4432         handle_brkchars completer for the "print" command.  Update
4433         "print"'s help to include supported options.
4434         * valprint.c: Include "cli/cli-option.h".
4435         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4436         here from cp-valprint.c.
4437         (boolean_option_def, uinteger_option_def)
4438         (value_print_option_defs, make_value_print_options_def_group):
4439         New.  Use gdb::option::add_setshow_cmds_for_options to install
4440         "set print elements", "set print null-stop", "set print repeats",
4441         "set print pretty", "set print union", "set print array", "set
4442         print address", "set print symbol", "set print array-indexes".
4443         * valprint.h: Include <string> and "cli/cli-option.h".
4444         (make_value_print_options_def_group): Declare.
4445         (print_value): Change parameter type from format_data pointer to
4446         value_print_options reference.
4447         (print_command_completer): Declare.
4448
4449 2019-06-13  Pedro Alves  <palves@redhat.com>
4450
4451         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4452         (COMMON_SFILES): Add maint-test-settings.c.
4453         * cli/cli-decode.c (boolean_enums): New global, factored out from
4454         ...
4455         (add_setshow_boolean_cmd): ... here.
4456         * cli/cli-decode.h (boolean_enums): Declare.
4457         * cli/cli-option.c: New file.
4458         * cli/cli-option.h: New file.
4459         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4460         factored out from ...
4461         (parse_cli_boolean_value(const char *)): ... this.
4462         (is_unlimited_literal): Change parameter type to pointer to
4463         pointer.  Adjust and advance ARG pointer.
4464         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4465         (parse_cli_var_enum): New, factored out from ...
4466         (do_set_command): ... this.  Adjust.
4467         * cli/cli-setshow.h (parse_cli_boolean_value)
4468         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4469         (parse_cli_var_enum): Declare.
4470         * cli/cli-utils.c: Include "cli/cli-option.h".
4471         (get_ulongest): New.
4472         * cli/cli-utils.h (get_ulongest): Declare.
4473         (check_for_argument): New overloads.
4474         * maint-test-options.c: New file.
4475
4476 2019-06-13  Pedro Alves  <palves@redhat.com>
4477
4478         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4479         parse a range if "-" is at the end of the string.
4480
4481 2019-06-13  Pedro Alves  <palves@redhat.com>
4482
4483         * cli/cli-setshow.c (parse_auto_binary_operation)
4484         (parse_cli_boolean_value): Don't allow "o".
4485
4486 2019-06-13  Pedro Alves  <palves@redhat.com>
4487
4488         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4489         * NEWS: Mention maint test-settings KIND.
4490         * maint-test-settings.c: New file.
4491
4492 2019-06-13  Pedro Alves  <palves@redhat.com>
4493
4494         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4495         completer.
4496         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4497         "set" completers.
4498
4499 2019-06-13  Pedro Alves  <palves@redhat.com>
4500
4501         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4502         after item.
4503
4504 2019-06-13  Pedro Alves  <palves@redhat.com>
4505
4506         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4507
4508 2019-06-13  Pedro Alves <palves@redhat.com>
4509
4510         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4511         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4512         call.
4513         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4514         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4515         calls.
4516         (check_for_argument): Skip spaces after argument.
4517
4518 2019-06-13  Pedro Alves  <palves@redhat.com>
4519
4520         * thread.c (thread_apply_command): Adjust TID parsing.
4521         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4522         detected before end of string.
4523         (tid_is_in_list): Error out if LIST is invalid.
4524
4525 2019-06-13  Pedro Alves  <palves@redhat.com>
4526
4527         * completer.c (complete_line_internal_1): Rewind completion word
4528         point.
4529         (completion_tracker::advance_custom_word_point_by): Change
4530         parameter type to int.
4531         * completer.h (completion_tracker::advance_custom_word_point_by):
4532         Likewise.
4533
4534 2019-06-13  Pedro Alves  <palves@redhat.com>
4535
4536         * completer.c (advance_to_completion_word): Handle delimiters.
4537
4538 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4539
4540         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4541
4542 2019-06-11  Tom Tromey  <tom@tromey.com>
4543
4544         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4545         (xmalloc_failed): Move to alloc.c.
4546         * alloc.c: New file.
4547         * Makefile.in (COMMON_SFILES): Add alloc.c.
4548
4549 2019-06-11  Tom Tromey  <tom@tromey.com>
4550
4551         * nat/linux-waitpid.c: Don't include server.h.
4552         (linux_debug): Remove.
4553         (my_waitpid): Update.
4554
4555 2019-06-11  Tom Tromey  <tromey@adacore.com>
4556
4557         * infcall.c (_initialize_infcall): Remove trailing newline from
4558         help.
4559         * user-regs.c (_initialize_user_regs): Remove trailing newline
4560         from help.
4561         * typeprint.c (_initialize_typeprint): Remove trailing newline
4562         from help.
4563         * reverse.c (_initialize_reverse): Remove trailing newlines from
4564         help.
4565         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4566         from help.
4567         * language.c (add_set_language_command): Remove trailing newline
4568         from help.
4569         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4570         help.
4571         * disasm.c (_initialize_disasm): Remove trailing newline from
4572         help.
4573         * top.c (init_main): Remove trailing newline from help.
4574         * interps.c (_initialize_interpreter): Remove trailing newline
4575         from help.
4576         * btrace.c (_initialize_btrace): Remove trailing newlines from
4577         help.
4578         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4579         from help.
4580         * python/python.c (_initialize_python): Remove trailing newline
4581         from help.
4582         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4583         help.
4584         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4585         from help.  Reformat some text.
4586         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4587         from help.
4588         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4589         newline from help.
4590
4591 2019-06-11  Tom Tromey  <tromey@adacore.com>
4592
4593         * darwin-nat.c (darwin_decode_exception_message)
4594         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4595
4596 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * valops.c (value_slice): Check for not allocated or not
4599         associated values.
4600
4601 2019-06-10  Tom de Vries  <tdevries@suse.de>
4602
4603         PR gdb/24618
4604         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4605         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4606         invalid.
4607
4608 2019-06-10  Tom de Vries  <tdevries@suse.de>
4609
4610         PR gdb/24611
4611         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4612         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4613
4614 2019-06-10  Tom de Vries  <tdevries@suse.de>
4615
4616         PR symtab/24545
4617         * symtab.c (struct demangled_name_entry): Add language field.
4618         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4619         static minimal symbol".  Set and use language field.
4620
4621 2019-06-10  Tom Tromey  <tromey@adacore.com>
4622
4623         * ada-lang.c (_initialize_ada_language): Update help text.
4624
4625 2019-06-10  Tom Tromey  <tromey@adacore.com>
4626
4627         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4628         with a newline.
4629         * guile/guile.c (handle_boot_error): Don't end warning with a
4630         newline.
4631         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4632         warning with a newline.
4633         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4634         newline.
4635         (s12z_frame_cache): Likewise.
4636         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4637         a newline.
4638         * solib-svr4.c (disable_probes_interface): Don't end warning with
4639         a newline.
4640         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4641         newline.
4642         * python/python.c (do_finish_initialization): Don't end warning
4643         with a newline.
4644
4645 2019-06-10  Tom Tromey  <tom@tromey.com>
4646
4647         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4648         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4649         gdbpy_enter.
4650
4651 2019-06-10  Tom Tromey  <tromey@adacore.com>
4652
4653         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4654         data.
4655         (elf_new_init): Don't call stabsread_new_init.
4656         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4657         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4658         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4659
4660 2019-06-10  Tom de Vries  <tdevries@suse.de>
4661
4662         PR symtab/16264
4663         PR symtab/24517
4664         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4665
4666 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4667
4668         * source.c (find_and_open_source): Also rewrite relative file
4669         names.
4670
4671 2019-04-26  Amos Bird  <amosbird@gmail.com>
4672
4673         * annotate.c (annotate_thread_exited): Add "thread-exited"
4674         annotation.
4675
4676 2019-06-06  Tom Tromey  <tromey@adacore.com>
4677
4678         * maint.h (class scoped_command_stats): Use
4679         DISABLE_COPY_AND_ASSIGN.
4680         <print_time>: New method.
4681         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4682         print_time.
4683         (scoped_command_stats::print_time): New method.
4684
4685 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4686
4687         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4688         instructions of lengths 6 or 8 bytes.
4689
4690 2019-06-04  Pedro Alves  <palves@redhat.com>
4691
4692         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4693
4694         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4695         * breakpoint.c (condition_completer): Likewise.
4696         * cli/cli-dump.c (scan_expression): Likewise.
4697         * common/filestuff.c (mkdir_recursive): Likewise.
4698         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4699         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4700         (gdb_abspath): Likewise.
4701         * compile/compile-cplus-types.c
4702         (compile_cplus_instance::decl_name): Likewise.
4703         * completer.c (complete_explicit_location):
4704         (signal_completer, reg_or_group_completer_1): Likewise.
4705         * cp-support.c (cp_remove_params_if_any): Likewise.
4706         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4707         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4708         * infcmd.c (strip_bg_char): Likewise.
4709         * linespec.c (copy_token_string): Likewise.
4710         * mi/mi-main.c (output_cores): Likewise.
4711         * psymtab.c (psymtab_search_name):
4712         * symfile.c (test_set_ext_lang_command): Likewise.
4713         * target.c (target_fileio_read_stralloc): Likewise.
4714         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4715         * value.c (complete_internalvar): Likewise.
4716
4717 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4718
4719         Add objfile property to gdb.Type.
4720         * NEWS: Mention Python API addition.
4721         * python/py-type.c (typy_get_objfile): New method.
4722
4723 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4724
4725         * NEWS: Mention the new set|show style [title|highlight].
4726         Mention changes to "show style", "help" and "apropos".
4727
4728 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4729
4730         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4731         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4732         instead of print_help_for_command.
4733         (print_doc_of_command): New function.
4734         (help_list): Add 'apropos -v word' suggestion.
4735         (print_help_for_command): Style the command name using title style.
4736         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4737         (_initialize_cli_cmds): Describe -v in apropos_command help.
4738
4739 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4740
4741         * cli/cli-style.h (cli_style_option): Add name in constructor,
4742         add m_name class member, add constructor with intensity,
4743         add name class function.
4744         (cli_style_option::add_setshow_commands): Remove name argument.
4745         (highlight_style, title_style): New styles.
4746         * cli/cli-style.c (do_show): New function that shows a style
4747         characteristic styling the style name with itself.
4748         (set_style_name): New function.
4749         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4750         Update all callers according to the changes in cli/cli-style.h.
4751         * utils.h (fputs_highlighted): New function.
4752         * utils.c (fputs_highlighted): Likewise.
4753
4754 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4755
4756         * NEWS: Mention new pipe command and new convenience variables.
4757
4758 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4759
4760         * cli/cli-cmds.c (pipe_command): New function.
4761         (_initialize_cli_cmds): Call add_com for pipe_command.
4762         Define | as an alias for pipe.
4763         (exit_status_set_internal_vars): New function.
4764         (shell_escape): Call exit_status_set_internal_vars.
4765         cli/cli-decode.c (find_command_name_length): Recognize | as
4766         a single character command.
4767
4768 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4769
4770         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4771         top.c (execute_command_to_ui_file): New function, mostly a copy
4772         of execute_command_to_string.
4773         (execute_command_to_string): Implement by calling
4774         execute_command_to_ui_file.
4775
4776 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4777
4778         * top.h (saved_command_line): Remove declaration.
4779         * top.c (previous_saved_command_line, previous_repeat_arguments):
4780         New variables.
4781         (saved_command_line): Make static, define together with other
4782         'repeat variables'.
4783         (dont_repeat): Clear repeat_arguments.
4784         (repeat_previous, get_saved_command_line, save_command_line):
4785         New functions.
4786         (gdb_init): Initialize saved_command_line
4787         and previous_saved_command_line.
4788         * main.c (captured_main_1): Remove saved_command_line initialization.
4789         * event-top.c (handle_line_of_input): Update to use
4790         the new 'repeat' related functions instead of direct access to
4791         saved_command_line.
4792         * command.h (repeat_previous, get_saved_command_line,
4793         save_command_line): New declarations.
4794         (dont_repeat): Add comment.
4795
4796 2019-05-30  Tom Tromey  <tromey@adacore.com>
4797
4798         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4799         Fix comment.
4800         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4801
4802 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4803
4804         PR cli/24587
4805         * completer.c (complete): Initialize variable word.
4806
4807 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4808
4809         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4810         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4811         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4812         'body' is NULL to the outter 'if', protecting the '!is_define'
4813         situation as well.
4814
4815 2019-05-29  Tom Tromey  <tromey@adacore.com>
4816
4817         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4818         (dwarf_unknown): New function.
4819         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4820         (dwarf_type_encoding_name): Use dwarf_unknown.
4821
4822 2019-05-29  Tom Tromey  <tromey@adacore.com>
4823
4824         PR c++/20020:
4825         * cp-valprint.c (cp_print_value_fields): Call
4826         cp_print_static_field inside "try".
4827
4828 2019-05-29  Tom Tromey  <tromey@adacore.com>
4829
4830         * inflow.c (struct terminal_info): Add default operator=.
4831         * configure: Rebuild.
4832         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4833         -Wdeprecated-copy-dtor, -Wredundant-move.
4834
4835 2019-05-29  Tom Tromey  <tromey@adacore.com>
4836
4837         * NEWS: Add entry.
4838         * infcmd.c (print_return_value_1): Handle finish_print
4839         option.
4840         (show_print_finish): New function.
4841         (_initialize_infcmd): Add "set/show print finish" commands.
4842         * valprint.c (user_print_options): Initialize new member.
4843         * valprint.h (struct value_print_options) <finish_print>: New
4844         member.
4845
4846 2019-05-28  Tom Tromey  <tromey@adacore.com>
4847
4848         * ada-lang.c (ada_remove_Xbn_suffix)
4849         (find_old_style_renaming_symbol)
4850         (parse_old_style_renaming): Remove.
4851         (ada_find_renaming_symbol): Don't call
4852         find_old_style_renaming_symbol.
4853         (ada_is_renaming_symbol): Rename from
4854         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4855         bool.  Now static.
4856         (ada_read_var_value): Update and simplify.
4857         * ada-exp.y (write_var_or_type): Remove old code.
4858
4859 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4860
4861         * event-top.c: Remove include comment.
4862         * inflow.c (class scoped_ignore_sigttou): Move from here...
4863         * inflow.h (class scoped_ignore_sigttou): ...to here.
4864         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4865         * top.c:  Remove include comment.
4866
4867 2019-05-27  Tom Tromey  <tom@tromey.com>
4868
4869         * NEWS: Fix typo.
4870
4871 2019-05-22  Tom Tromey  <tromey@adacore.com>
4872
4873         * target.c (target_follow_exec): Constify parameter.
4874         * target-delegates.c: Rebuild.
4875         * remote.c (remote_target::follow_exec): Constify parameter.
4876         * infrun.c (follow_exec): Constify parameter.
4877         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4878         (target_follow_exec): Likewise.
4879
4880 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4881
4882         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4883         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4884
4885 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4886
4887         * NEWS: Add debugredirect and testsuite sections.
4888
4889 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4890
4891         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4892         target descriptions using exclusively floating point register name
4893         aliases.
4894
4895 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4896
4897         PR gdb/18644:
4898         * f-lang.c (build_fortran_types): Handle the case where
4899         gdbarch_floatformat_for_type returns a nullptr.
4900
4901 2019-05-21  Tom de Vries  <tdevries@suse.de>
4902
4903         PR cli/24587
4904         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4905
4906 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         PR gdb/18644:
4909         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4910         16-byte floats.
4911         * i386-tdep.c (i386_floatformat_for_type): Use
4912         floatformats_ia64_quad for the 16-byte floating point component
4913         within a fortran 32-byte complex number.
4914
4915 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4918         delete default constructor.
4919         (find_partial_die): Update to return const struct.
4920         (partial_die_parent_scope): Move variable declaration into scope
4921         of its use and change its type to auto.
4922         (guess_partial_die_structure_name): Likewise.
4923         (partial_die_info::fixup): Likewise.
4924
4925 2019-05-17  Tom Tromey  <tromey@adacore.com>
4926
4927         * source.c (find_and_open_source): Remove cast.
4928
4929 2019-05-17  Tom Tromey  <tromey@adacore.com>
4930
4931         * annotate.c (annotate_source): Make "filename" const.
4932         * annotate.h (annotate_source): Use const.
4933
4934 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4935
4936         * disasm.c (set_disassembler_options): Send errors to stderr.
4937
4938 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4939
4940         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4941         (cli_interp_base::set_logging): Check debug_redirect.
4942         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4943         * cli/cli-logging.c (debug_redirect): Add static variable.
4944         (pop_output_files): Add default param.
4945         (handle_redirections): Print debug setting.
4946         (show_logging_command): Likewise.
4947         (_initialize_cli_logging): Add debugredirect command.
4948         * interps.c (current_interp_set_logging): Add debug_redirect
4949         parameter.
4950         * interps.h (set_logging): Add debug_redirect parameter.
4951         (current_interp_set_logging): Likewise.
4952         * mi/mi-common.h: Likewise.
4953         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4954
4955 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4956             Tom Tromey  <tromey@adacore.com>
4957
4958         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4959         directly.
4960         * cli/cli-interp.h (make_logging_output): Remove declaration.
4961         * cli/cli-logging.c (make_logging_output): Remove function.
4962         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4963         directly.
4964         * ui-file.c (tee_file::tee_file): Remove bools.
4965         (tee_file::~tee_file): Remove deletes.
4966         * ui-file.h (tee_file): Remove bools.
4967
4968 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4969
4970         * mi/mi-cmds.h (mi_cmd_complete): New function.
4971         * mi/mi-main.c (mi_cmd_complete): Likewise.
4972         * mi/mi-cmds.c: Define new MI command -complete.
4973         * NEWS: Mention new -complete command.
4974
4975 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4976
4977         * completer.h (complete): New function.
4978         * completer.c (complete): Likewise.
4979         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4980         function defined in completer.h.
4981
4982 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4983
4984         * MAINTAINERS (Write After Approval): Add myself.
4985
4986 2019-05-17  Tom de Vries  <tdevries@suse.de>
4987
4988         PR gdb/24094
4989         * dwarf2read.c (struct cu_partial_die_info): New struct.
4990         (find_partial_die): Return cu_partial_die_info.
4991         (partial_die_parent_scope, guess_partial_die_structure_name)
4992         (partial_die_info::fixup): Handle new return type of find_partial_die.
4993
4994 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4995
4996         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4997         "std::string", simplifying the algorithm.
4998
4999 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5000
5001         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5002         (stap_static_probe_ops::get_probes): Likewise.
5003
5004 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5005
5006         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5007         '-')" and "else if".
5008         (stap_parse_single_operand): Join checks for
5009         "gdbarch_stap_parse_special_token_p" and
5010         "gdbarch_stap_parse_special_token" in the same "if" statement.
5011         Invert check when verifying for operation on register
5012         displacement.
5013
5014 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5015
5016         * stap-probe.c (stap_get_opcode): Update comment.
5017         (stap_get_expected_argument_type): Likewise.
5018         (handle_stap_probe): Likewise.
5019
5020 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5021
5022         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5023         return type to 'bool'.  Adjust comment.  Use 'bool' when
5024         appropriate.
5025         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5026         * stap-probe.c (stap_parse_argument_1): Likewise.
5027         (stap_is_operator): Likewise.
5028         (stap_is_generic_prefix): Likewise.
5029         (stap_is_register_prefix): Likewise.
5030         (stap_is_register_indirection_prefix): Likewise.
5031         (stap_is_integer_prefix): Likewise.
5032         (stap_generic_check_suffix): Likewise.
5033         (stap_check_integer_suffix): Likewise.
5034         (stap_check_register_suffix): Likewise.
5035         (stap_check_register_indirection_suffix): Likewise.
5036         (stap_parse_register_operand): Likewise.
5037         (stap_parse_single_operand): Likewise.
5038         (stap_parse_argument_1): Likewise.
5039         (stap_probe::get_argument_count): Likewise.
5040         (stap_is_operator): Likewise.
5041
5042 2019-05-16  Tom Tromey  <tromey@adacore.com>
5043
5044         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5045         keyword to foreach.
5046
5047 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5048
5049         * linux-thread-db.c (try_thread_db_load_1): Change return type
5050         to bool.
5051         (try_thread_db_load): Likewise.
5052         (try_thread_db_load_from_pdir_1): Likewise.
5053         (try_thread_db_load_from_pdir): Likewise.
5054         (try_thread_db_load_from_sdir): Likewise.
5055         (try_thread_db_load_from_dir): Likewise.
5056         (thread_db_load_search): Likewise.
5057         (has_libpthread): Likewise.
5058         (thread_db_load): Likewise.
5059
5060 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5061
5062         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5063         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5064         NULL, and complain/return if that's the case.
5065
5066 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5067
5068         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5069         (advance, posn, abstract_read_memory): New functions.
5070         [struct mem_read_abstraction]: New struct.
5071         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5072
5073 2019-05-14  Tom Tromey  <tromey@adacore.com>
5074
5075         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5076         value is not lval_memory.
5077
5078 2019-05-14  Tom Tromey  <tromey@adacore.com>
5079
5080         * solib.c (info_sharedlibrary_command): Style the file name.
5081
5082 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5083
5084         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5085         (aarch64_vnv_type): Likewise.
5086         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5087         * common/tdesc.c: Likewise.
5088         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5089         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5090         * features/aarch64-fpu.xml: Add ieee half view.
5091         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5092         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5093         * gdbtypes.h (struct builtin_type): Likewise.
5094         (struct objfile_type): Likewise.
5095
5096 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5097
5098         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5099         typo.
5100         * location.h (string_to_event_location): Likewise.
5101
5102 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5103
5104         GDB 8.3 released.
5105
5106 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5107
5108         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5109         New variable declaration.
5110         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5111         New variable.
5112         (print_one_breakpoint): Use ui_out::test_flags and new global
5113         variable to compute use_fixed_output.
5114         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5115         Remove.
5116         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5117         (mi_multi_location_breakpoint_output_fixed): Remove.
5118         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5119         new variable.
5120         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5121         fix_multi_location_breakpoint_output flag if version >= 3.
5122         * ui-out.h (enum ui_out_flag)
5123         <fix_multi_location_breakpoint_output>: New enumerator.
5124
5125 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5126
5127         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5128
5129 2019-05-10  Tom Tromey  <tromey@adacore.com>
5130
5131         * ada-lang.c (catch_ada_completer): New function.
5132         (_initialize_ada_language): Use it.
5133
5134 2019-05-10  Tom Tromey  <tromey@adacore.com>
5135
5136         * thread.c (print_thread_info): Make "requested_threads" const.
5137         * gdbthread.h (print_thread_info): Make "requested_threads"
5138         const.
5139         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5140         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5141
5142 2019-05-08  Tom Tromey  <tom@tromey.com>
5143
5144         * gdbtypes.c (objfile_type_data): Change type.
5145         (objfile_type, _initialize_gdbtypes): Update.
5146
5147 2019-05-08  Tom Tromey  <tom@tromey.com>
5148
5149         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5150         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5151         (_initialize_dwarf2_frame): Update.
5152
5153 2019-05-08  Tom Tromey  <tom@tromey.com>
5154
5155         * objc-lang.c (objc_objfile_data): Change type.
5156         (find_methods): Update.
5157         (_initialize_objc_lang): Remove.
5158
5159 2019-05-08  Tom Tromey  <tom@tromey.com>
5160
5161         * stabsread.c (rs6000_builtin_type_data): Change type.
5162         (rs6000_builtin_type, _initialize_stabsread): Update.
5163
5164 2019-05-08  Tom Tromey  <tom@tromey.com>
5165
5166         * mips-tdep.c (mips_pdr_data): Remove.
5167         (_initialize_mips_tdep): Update.
5168
5169 2019-05-08  Tom Tromey  <tom@tromey.com>
5170
5171         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5172         (hppa_init_objfile_priv_data, read_unwind_info)
5173         (find_unwind_entry, _initialize_hppa_tdep): Update.
5174
5175 2019-05-08  Tom Tromey  <tom@tromey.com>
5176
5177         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5178         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5179         on obstack.
5180         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5181
5182 2019-05-08  Tom Tromey  <tom@tromey.com>
5183
5184         * mdebugread.c (basic_type_data): Change type.
5185         (basic_type, _initialize_mdebugread): Update.
5186
5187 2019-05-08  Tom Tromey  <tom@tromey.com>
5188
5189         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5190
5191 2019-05-08  Tom Tromey  <tom@tromey.com>
5192
5193         * nto-tdep.c (nto_inferior_data_reg): Change type.
5194         (nto_inferior_data): Update.
5195         (nto_inferior_data_cleanup, nto_new_inferior_data)
5196         (_initialize_nto_tdep): Remove.
5197         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5198
5199 2019-05-08  Tom Tromey  <tom@tromey.com>
5200
5201         * ada-lang.c (struct ada_inferior_data): Add initializers.
5202         (ada_inferior_data): Change type.
5203         (ada_inferior_data_cleanup): Remove.
5204         (get_ada_inferior_data, ada_inferior_exit)
5205         (struct ada_pspace_data): Add initializers, destructor.
5206         (ada_pspace_data_handle): Change type.
5207         (get_ada_pspace_data): Update.
5208         (ada_pspace_data_cleanup): Remove.
5209
5210 2019-05-08  Tom Tromey  <tom@tromey.com>
5211
5212         * coffread.c (struct coff_symfile_info): Add initializers.
5213         (coff_objfile_data_key): Move lower.  Change type.
5214         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5215         Update.
5216         (coff_free_info): Remove.
5217
5218 2019-05-08  Tom Tromey  <tom@tromey.com>
5219
5220         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5221         (fbsd_pspace_data_handle): Move lower.  Change type.
5222         (get_fbsd_pspace_data): Update.
5223         (fbsd_pspace_data_cleanup): Remove.
5224         (_initialize_fbsd_tdep): Update.
5225
5226 2019-05-08  Tom Tromey  <tom@tromey.com>
5227
5228         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5229         (get_ada_tasks_pspace_data): Update.
5230         (ada_tasks_pspace_data_cleanup): Remove.
5231         (_initialize_tasks): Update.
5232         (ada_tasks_inferior_data_handle): Change type.
5233         (get_ada_tasks_inferior_data): Update.
5234         (ada_tasks_inferior_data_cleanup): Remove.
5235         (struct ada_tasks_pspace_data): Add initializers.
5236
5237 2019-05-08  Tom Tromey  <tom@tromey.com>
5238
5239         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5240         * symfile-debug.c (debug_sym_get_probes): Change type.
5241         * stap-probe.c (handle_stap_probe):
5242         (stap_static_probe_ops::get_probes): Change type.
5243         * probe.h (class static_probe_ops) <get_probes>: Change type.
5244         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5245         (parse_probes_in_pspace): Update.
5246         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5247         Update.
5248         (any_static_probe_ops::get_probes): Change type.
5249         * elfread.c (elfread_data): New typedef.
5250         (probe_key): Change type.
5251         (elf_get_probes): Likewise.  Update.
5252         (probe_key_free): Remove.
5253         (_initialize_elfread): Update.
5254         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5255         Change type.
5256         (dtrace_process_dof_probe, dtrace_process_dof)
5257         (dtrace_static_probe_ops::get_probe): Change type.
5258
5259 2019-05-08  Tom Tromey  <tom@tromey.com>
5260
5261         * xcoffread.c (struct xcoff_symfile_info): Rename from
5262         coff_symfile_info.  Add initializers.
5263         (xcoff_objfile_data_key): Move lower.  Change type.
5264         (XCOFF_DATA): Rewrite.
5265         (xcoff_free_info): Remove.
5266         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5267         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5268         (xcoff_initial_scan): Update.
5269
5270 2019-05-08  Tom Tromey  <tom@tromey.com>
5271
5272         * solib-svr4.c (struct svr4_info): Add initializers and
5273         destructor.
5274         <probes_table>: Now an htab_up.
5275         (solib_svr4_pspace_data): Change type.
5276         (free_probes_table): Simplify.
5277         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5278         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5279         (probes_table_remove_objfile_probes, register_solib_event_probe)
5280         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5281         (_initialize_svr4_solib): Update.
5282
5283 2019-05-08  Tom Tromey  <tom@tromey.com>
5284
5285         * remote.c (remote_pspace_data): Change type.
5286         (remote_pspace_data_cleanup): Remove.
5287         (get_remote_exec_file, set_pspace_remote_exec_file)
5288         (_initialize_remote): Update.
5289
5290 2019-05-08  Tom Tromey  <tom@tromey.com>
5291
5292         * breakpoint.c (breakpoint_objfile_key): Change type.
5293         (get_breakpoint_objfile_data): Update.
5294         (free_breakpoint_objfile_data): Remove.
5295         (_initialize_breakpoint): Update.
5296
5297 2019-05-08  Tom Tromey  <tom@tromey.com>
5298
5299         * linux-tdep.c (struct linux_info): Add initializers.
5300         (linux_inferior_data): Move.  Change type.
5301         (invalidate_linux_cache_inf): Update.
5302         (linux_inferior_data_cleanup): Remove.
5303         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5304
5305 2019-05-08  Tom Tromey  <tom@tromey.com>
5306
5307         * auxv.c (auxv_inferior_data): Move.  Change type.
5308         (auxv_inferior_data_cleanup): Remove.
5309         (invalidate_auxv_cache_inf): Rewrite.
5310         (get_auxv_inferior_data, _initialize_auxv): Update.
5311
5312 2019-05-08  Tom Tromey  <tom@tromey.com>
5313
5314         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5315         (symfile_debug_objfile_data_key): Change type.
5316         (symfile_debug_installed, debug_qf_has_symbols)
5317         (debug_qf_find_last_source_symtab)
5318         (debug_qf_forget_cached_source_info)
5319         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5320         (debug_qf_print_stats, debug_qf_dump)
5321         (debug_qf_expand_symtabs_for_function)
5322         (debug_qf_expand_all_symtabs)
5323         (debug_qf_expand_symtabs_with_fullname)
5324         (debug_qf_map_matching_symbols)
5325         (debug_qf_expand_symtabs_matching)
5326         (debug_qf_find_pc_sect_compunit_symtab)
5327         (debug_qf_map_symbol_filenames)
5328         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5329         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5330         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5331         (debug_sym_read_linetable, debug_sym_relocate): Update.
5332         (symfile_debug_free_objfile): Remove.
5333         (install_symfile_debug_logging, _initialize_symfile_debug):
5334         Update.
5335
5336 2019-05-08  Tom Tromey  <tom@tromey.com>
5337
5338         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5339         allocate_on_obstack.
5340         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5341         (get_dwarf2_per_objfile): Update.
5342         (set_dwarf2_per_objfile): Remove.
5343         (dwarf2_has_info, dwarf2_get_section_info): Update.
5344         (dwarf2_free_objfile): Remove.
5345         (_initialize_dwarf2_read): Update.
5346
5347 2019-05-08  Tom Tromey  <tom@tromey.com>
5348
5349         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5350         initializers.
5351         <unsupported_script_warning_printed,
5352         script_not_found_warning_printed>: Now bool.
5353         (auto_load_pspace_data): Change type.
5354         (~auto_load_pspace_info): Rename from
5355         auto_load_pspace_data_cleanup.
5356         (get_auto_load_pspace_data, init_loaded_scripts_info)
5357         (clear_section_scripts, maybe_print_unsupported_script_warning)
5358         (maybe_print_script_not_found_warning, _initialize_auto_load):
5359         Update.
5360
5361 2019-05-08  Tom Tromey  <tom@tromey.com>
5362
5363         * objfiles.c (objfile_pspace_info): Add destructor and
5364         initializers.
5365         (objfiles_pspace_data): Change type.
5366         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5367         (get_objfile_pspace_data): Update.
5368         (objfiles_bfd_data): Change type.
5369         (get_objfile_bfd_data): Update.
5370         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5371
5372 2019-05-08  Tom Tromey  <tom@tromey.com>
5373
5374         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5375         Change type.
5376         (get_catch_syscall_inferior_data): Update.
5377         (catch_syscall_inferior_data_cleanup): Remove.
5378         (_initialize_break_catch_syscall): Update.
5379
5380 2019-05-08  Tom Tromey  <tom@tromey.com>
5381
5382         * inflow.c (struct terminal_info): Add destructor and
5383         initializers.
5384         (inflow_inferior_data): Change type.
5385         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5386         (get_inflow_inferior_data, inflow_inferior_exit)
5387         (swap_terminal_info, _initialize_inflow): Update.
5388
5389 2019-05-08  Tom Tromey  <tom@tromey.com>
5390
5391         * target-dcache.c (target_dcache_cleanup): Remove.
5392         (target_dcache_aspace_key): Change type.
5393         (target_dcache_init_p, target_dcache_invalidate)
5394         (target_dcache_get, target_dcache_get_or_init)
5395         (_initialize_target_dcache): Update.
5396         * dcache.h (struct dcache_deleter): New.
5397
5398 2019-05-08  Tom Tromey  <tom@tromey.com>
5399
5400         * symtab.c (struct symbol_cache): Add destructor and
5401         initializers.
5402         (symbol_cache_key): Move.  Change type.
5403         (make_symbol_cache, free_symbol_cache): Remove.
5404         (get_symbol_cache): Update.
5405         (symbol_cache_cleanup): Remove.
5406         (ALL_PSPACES, symbol_cache_flush)
5407         (maintenance_print_symbol_cache)
5408         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5409         Update.
5410
5411 2019-05-08  Tom Tromey  <tom@tromey.com>
5412
5413         * symtab.c (struct main_info): Add destructor and initializers.
5414         (main_progspace_key): Move.  Change type.
5415         (get_main_info): Update.
5416         (main_info_cleanup): Remove.
5417         (_initialize_symtab): Update.
5418
5419 2019-05-08  Tom Tromey  <tom@tromey.com>
5420
5421         * registry.h (DECLARE_REGISTRY): Define the _key class.
5422
5423 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5424
5425         * NEWS: Merge two 'New commands' sections.
5426
5427 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5428
5429         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5430         parameter and use Ada language definition instead.
5431         (ada_val_print_ptr): Remove unused language parameter.
5432         (ada_val_print_num): Remove language parameter and use Ada language
5433         definition instead.
5434         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5435         parameter.
5436         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5437         parameter and use Ada language definition instead.
5438         (ada_val_print_1): Update all ada_val_print_xxx calls.
5439         Remove language parameter.
5440         (ada_val_print): Update ada_val_print_1 call.
5441
5442 2019-05-08  Tom Tromey  <tromey@adacore.com>
5443
5444         * remote.c (remote_hw_watchpoint_limit)
5445         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5446         Now static.
5447
5448 2019-05-08  Tom Tromey  <tromey@adacore.com>
5449
5450         * maint.c (_initialize_maint_cmds): Move initialization code to
5451         remote.c.
5452         (watchdog, show_watchdog): Move to remote.c.
5453         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5454         "watchdog" static.
5455         (_initialize_remote): Move initialization code from maint.c.
5456         * defs.h (watchdog): Don't declare.
5457
5458 2019-05-08  Tom Tromey  <tromey@adacore.com>
5459
5460         * tui/tui-interp.c: Include main.h.
5461         * interps.c: Include main.h.
5462         * main.h (interpreter_p): Declare.
5463         * defs.h (interpreter_p): Don't declare.
5464
5465 2019-05-08  Tom Tromey  <tromey@adacore.com>
5466
5467         * dwarf2loc.c: Include dwarf2read.h.
5468         * defs.h (read_unsigned_leb128): Don't declare.
5469         * dwarf2read.h (read_unsigned_leb128): Declare.
5470
5471 2019-05-08  Tom Tromey  <tromey@adacore.com>
5472
5473         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5474         method.
5475
5476 2019-05-08  Tom Tromey  <tromey@adacore.com>
5477
5478         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5479         when no wrap column is set.
5480
5481 2019-05-08  Tom Tromey  <tromey@adacore.com>
5482
5483         * c-lang.c (c_get_string): Handle non-C-style arrays.
5484
5485 2019-05-08  Tom Tromey  <tromey@adacore.com>
5486
5487         * typeprint.c (print_offset_data::update): Print the bit offset,
5488         not the number of bits remaining.
5489
5490 2019-05-08  Tom Tromey  <tromey@adacore.com>
5491
5492         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5493         padding at end of comment.
5494
5495 2019-05-08  Tom Tromey  <tromey@adacore.com>
5496
5497         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5498         Compare main types.
5499
5500 2019-05-06  Tom Tromey  <tom@tromey.com>
5501
5502         * common/scoped_mmap.c: Include common-defs.h.
5503         * common/scoped_mmap.h: Don't include config.h.
5504
5505 2019-05-04  Tom Tromey  <tom@tromey.com>
5506
5507         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5508         (struct aarch64_call_info): Add initializers.
5509         <si>: Now a std::vector.
5510         (pass_on_stack, aarch64_push_dummy_call): Update.
5511
5512 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5513             Tom Tromey  <tom@tromey.com>
5514
5515         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5516         (ppc_threads): Now a std::vector.  Now static.
5517         (hwdebug_find_thread_points_by_tid)
5518         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5519         Update.
5520
5521 2019-05-04  Tom Tromey  <tom@tromey.com>
5522
5523         * arc-tdep.c (arc_tdesc_init): Return bool.
5524
5525 2019-05-04  Tom Tromey  <tom@tromey.com>
5526
5527         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5528         Use gdb_assert_not_reached.
5529
5530 2019-05-04  Tom Tromey  <tom@tromey.com>
5531
5532         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5533         "false".
5534
5535 2019-05-04  Tom Tromey  <tom@tromey.com>
5536
5537         * arc-tdep.c (arc_tdesc_init): Use bool.
5538
5539 2019-05-04  Tom Tromey  <tom@tromey.com>
5540
5541         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5542
5543 2019-05-04  Tom Tromey  <tom@tromey.com>
5544
5545         * cli/cli-cmds.c (valid_command_p): Return bool.
5546
5547 2019-05-04  Tom Tromey  <tom@tromey.com>
5548
5549         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5550         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5551
5552 2019-05-04  Raul Tambre  <raul@tambre.ee>
5553
5554         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5555         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5556         operator for comparison.
5557
5558 2019-05-04  Tom Tromey  <tom@tromey.com>
5559
5560         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5561         (lookup_partial_symbol, print_partial_symbols)
5562         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5563         (psymbol_compare): Update.
5564         (add_psymbol_to_bcache): Clear the entire psymbol.
5565         (maintenance_check_psymtabs): Update.
5566         * psympriv.h (struct partial_symbol): Don't derive from
5567         general_symbol_info.
5568         <obj_section, unrelocated_address, address,
5569         set_unrelocated_address>: Update.
5570         <ginfo>: New member.
5571         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5572         (debug_names::write_psymbols): Update.
5573
5574 2019-05-04  Tom de Vries  <tdevries@suse.de>
5575
5576         * contrib/cc-with-tweaks.sh: Support -n arg.
5577
5578 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5579
5580         * corelow.c (core_target::detach): Ensure frame cache and
5581         register caches are cleared.
5582         inferior.c (exit_inferior_1): Likewise.
5583
5584 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5585             Tom Tromey  <tom@tromey.com>
5586
5587         * dictionary.c (collate_pending_symbols_by_language): Remove
5588         "struct" from foreach.
5589         * symtab.c (lookup_global_symbol_from_objfile)
5590         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5591         foreach.
5592         * ser-tcp.c (net_open): Remove "struct" from foreach.
5593         * objfiles.c (objfile_relocate, objfile_rebase)
5594         (objfile_has_symbols): Remove "struct" from foreach.
5595         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5596         from foreach.
5597         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5598         foreach.
5599         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5600         "struct" from foreach.
5601         * ada-lang.c (create_excep_cond_exprs)
5602         (ada_exception_catchpoint_cond_string): Remove "struct" from
5603         foreach.
5604
5605 2019-05-03  Tom Tromey  <tromey@adacore.com>
5606
5607         * ada-exp.y (convert_char_literal): Check suffix of each
5608         enumerator.
5609
5610 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5611
5612         PR ada/21406:
5613         * ada-exp.y (yywrap): Don't define.
5614         * ada-lex.l (%option): Add noyywrap
5615         (yywrap): Remove.
5616
5617 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5618
5619         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5620         _WIN32_WINNT to the XP level, unless already defined to a higher
5621         level.
5622
5623         * unittests/parse-connection-spec-selftests.c:
5624         * ser-tcp.c:
5625         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5626         override.
5627
5628         * symfile.c (find_separate_debug_file): Remove colon from the
5629         drive spec of DOS/Windows file names of the target, so that the
5630         file name produced from DEBUGDIR and the target's directory will
5631         be valid on DOS/Windows systems.
5632
5633 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5634
5635         * rust-lang.c (val_print_struct): Handle printing structures
5636         containing strings.
5637
5638 2019-05-02  Tom Tromey  <tromey@adacore.com>
5639
5640         * valarith.c (_initialize_valarith): Remove.
5641
5642 2019-05-01  Tom Tromey  <tromey@adacore.com>
5643
5644         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5645         bitfields.
5646
5647 2019-05-01  Tom Tromey  <tromey@adacore.com>
5648
5649         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5650         for big-endian copies.
5651
5652 2019-04-30  Ali Tamur  <tamur@google.com>
5653         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5654         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5655         (read_3_bytes): New function.
5656
5657 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5658
5659         * windows-nat.c (main_thread_id): Delete.
5660         (handle_output_debug_string): Replace main_thread_id by
5661         current_event.dwThreadId.
5662         (fake_create_process): Likewise.
5663         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5664         Do not set main_thread_id.
5665         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5666         current_event.dwThreadId.
5667         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5668
5669 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5670
5671         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5672         Use current_event.dwThreadId instead of main_thread_id.
5673
5674 2019-04-30  Tom Tromey  <tromey@adacore.com>
5675
5676         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5677         (create_excep_cond_exprs): Iterate over program spaces.
5678         (ada_exception_catchpoint_cond_string): Examine all minimal
5679         symbols for exception types.
5680
5681 2019-04-30  Tom Tromey  <tromey@adacore.com>
5682
5683         PR c++/24470:
5684         * dwarf2read.c (process_structure_scope): Handle case where type
5685         has template parameters but no symbol was created.
5686
5687 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5688             Chris January  <chris.january@arm.com>
5689
5690         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5691         qualifier.
5692         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5693
5694 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5695
5696         * f-typeprint.c (f_print_type): Update rules for printing
5697         whitespace.
5698         (f_type_print_varspec_suffix): Likewise.
5699
5700 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5701             Chris January  <chris.january@arm.com>
5702
5703         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5704         function arguments.
5705
5706 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         * f-lang.c (build_fortran_types): Change name of void type to
5709         lower case.
5710         * f-typeprint.c (f_type_print_base): Print the name of the void
5711         type, rather than a fixed string.
5712         * f-valprint.c (f_decorations): Use lower case void string.
5713
5714 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5715             Chris January  <chris.january@arm.com>
5716
5717         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5718         types for Fortran.
5719
5720 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5721             Chris January  <chris.january@arm.com>
5722             David Lecomber  <david.lecomber@arm.com>
5723
5724         * f-exp.y (BINOP_INTRINSIC): New token.
5725         (exp): New parser rule handling BINOP_INTRINSIC.
5726         (f77_keywords): Add new builtin procedures.
5727         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5728         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5729         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5730         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5731         (print_unop_subexp_f): New function.
5732         (print_binop_subexp_f): New function.
5733         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5734         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5735         (dump_subexp_body_f): Likewise.
5736         (operator_check_f): Likewise.
5737         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5738         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5739
5740 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5741
5742         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5743         UNOP_KIND.
5744         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5745         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5746         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5747         (operator_length_f): New fuction.
5748         (print_subexp_f): New function.
5749         (op_name_f): New function.
5750         (dump_subexp_body_f): New function.
5751         (operator_check_f): New function.
5752         (exp_descriptor_f): Replace standard expression handling functions
5753         with new functions.
5754         * gdb/fortran-operator.def: New file.
5755         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5756         * gdb/std-operator.def: Remove UNOP_KIND.
5757
5758 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5759
5760         * std-operator.def: Remove unbalanced, stray double quote
5761         character.
5762
5763 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5764             Chris January  <chris.january@arm.com>
5765             Daniel Everett  <daniel.everett@arm.com>
5766             Nick Forrington  <nick.forrington@arm.com>
5767             Richard Bunt  <richard.bunt@arm.com>
5768
5769         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5770         of depth when printing anonymous structs or unions.
5771         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5772         Don't print either the top-level value, or the children if the
5773         max-depth is exceeded.
5774         (ppscm_print_children): When printing the key of a map, allow one
5775         extra level of depth.
5776         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5777         print either the top-level value, or the children if the max-depth
5778         is exceeded.
5779         (print_children): When printing the key of a map, allow one extra
5780         level of depth.
5781         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5782         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5783         (user_print_options): Initialise max_depth field.
5784         (val_print_scalar_or_string_type_p): New function.
5785         (val_print): Check to see if the max depth has been reached.
5786         (val_print_check_max_depth): Define new function.
5787         (show_print_max_depth): New function.
5788         (_initialize_valprint): Add 'print max-depth' option.
5789         * valprint.h (struct value_print_options) <max_depth>: New field.
5790         (val_print_check_max_depth): Declare new function.
5791         * NEWS: Document new feature.
5792
5793 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5794
5795         * ada-lang.c (ada_language_defn): Initialise new field.
5796         * c-lang.c (c_is_string_type_p): New function.
5797         (c_language_defn): Initialise new field.
5798         (cplus_language_defn): Initialise new field.
5799         (asm_language_defn): Initialise new field.
5800         (minimal_language_defn): Initialise new field.
5801         * c-lang.h (c_is_string_type_p): Declare new function.
5802         * d-lang.c (d_language_defn): Initialise new field.
5803         * f-lang.c (f_is_string_type_p): New function.
5804         (f_language_defn): Initialise new field.
5805         * go-lang.c (go_is_string_type_p): New function.
5806         (go_language_defn): Initialise new field.
5807         * language.c (default_is_string_type_p): New function.
5808         (unknown_language_defn): Initialise new field.
5809         (auto_language_defn): Initialise new field.
5810         * language.h (struct language_defn) <la_is_string_type_p>: New
5811         member variable.
5812         (default_is_string_type_p): Declare new function.
5813         * m2-lang.c (m2_language_defn): Initialise new field.
5814         * objc-lang.c (objc_language_defn): Initialise new field.
5815         * opencl-lang.c (opencl_language_defn): Initialise new field.
5816         * p-lang.c (pascal_is_string_type_p): New function.
5817         (pascal_language_defn): Initialise new field.
5818         * rust-lang.c (rust_is_string_type_p): New function.
5819         (rust_language_defn): Initialise new field.
5820
5821 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5822
5823         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5824         New field.
5825         * ada-lang.c (ada_language_defn): Initialise new field.
5826         * c-lang.c (c_language_defn): Likewise.
5827         (cplus_language_defn): Likewise.
5828         (asm_language_defn): Likewise.
5829         (minimal_language_defn): Likewise.
5830         * d-lang.c (d_language_defn): Likewise.
5831         * f-lang.c (f_language_defn): Likewise.
5832         * go-lang.c (go_language_defn): Likewise.
5833         * language.c (unknown_language_defn): Likewise.
5834         (auto_language_defn): Likewise.
5835         * m2-lang.c (m2_language_defn): Likewise.
5836         * objc-lang.c (objc_language_defn): Likewise.
5837         * opencl-lang.c (opencl_language_defn): Likewise.
5838         * p-lang.c (pascal_language_defn): Likewise.
5839         * rust-lang.c (rust_language_defn): Likewise.
5840
5841 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5842
5843         * ada-lang.c (ada_is_character_type): Change return type to bool.
5844         (ada_is_string_type): Likewise.
5845         * ada-lang.h (ada_is_character_type): Update declaration
5846         (ada_is_string_type): Likewise.
5847
5848 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5849
5850         Support style in 'frame|thread apply'
5851
5852         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5853         * record.c (record_start, record_stop): Update callers of
5854         execute_command_to_string with false.
5855         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5856         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5857         methods.
5858         (class string_file): New constructor with term_out parameter.
5859         Override methods term_out and can_emit_style_escape.  New member
5860         term_out.
5861         (class stdio_file): Override can_emit_style_escape.
5862         (class tee_file): Override term_out and can_emit_style_escape.
5863         * utils.h (can_emit_style_escape): Remove.
5864         * utils.c (can_emit_style_escape): Likewise.
5865         Update all callers of can_emit_style_escape (SOMESTREAM) to
5866         SOMESTREAM->can_emit_style_escape.
5867         * source-cache.c (source_cache::get_source_lines): Likewise.
5868         * stack.c (frame_apply_command_count): Call execute_command_to_string
5869         passing the term_out characteristic of the current gdb_stdout.
5870         * thread.c (thr_try_catch_cmd): Likewise.
5871         * top.c (execute_command_to_string): pass term_out parameter
5872         to construct the string_file for the command output.
5873         * ui-file.c (term_cli_styling): New function (most code moved
5874         from utils.c can_emit_style_escape).
5875         (string_file::string_file, string_file::can_emit_style_escape,
5876         stdio_file::can_emit_style_escape, tee_file::term_out,
5877         tee_file::can_emit_style_escape): New functions.
5878
5879 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5880
5881         * NEWS: Mention the new set|show may-call-functions.
5882         * infcall.c (may_call_functions_p): New variable.
5883         (show_may_call_functions_p): New function.
5884         (call_function_by_hand_dummy): Throws an error if not
5885         may-call-functions.
5886         (_initialize_infcall): Call add_setshow_boolean_cmd for
5887         may-call-functions.
5888
5889 2019-04-25  Keith Seitz  <keiths@redhat.com>
5890
5891         PR c++/24367
5892         * cp-support.c (inspect_type): Don't attempt substitutions
5893         of symbol with the same name.
5894
5895 2019-04-25  Tom Tromey  <tromey@adacore.com>
5896
5897         PR gdb/24475:
5898         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5899         static.
5900
5901 2019-04-25  Tom Tromey  <tromey@adacore.com>
5902
5903         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5904         rvalue reference.
5905         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5906         (gdb_xml_parser::parse): Use std::move.
5907         * python/python-internal.h (gdbpy_convert_exception): Take a const
5908         reference.
5909         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5910         std::move.
5911         * python/py-utils.c (gdbpy_convert_exception): Take a const
5912         reference.
5913         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5914         Use std::move.
5915         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5916         Use std::move.
5917         * mi/mi-main.c (mi_print_exception): Take a const reference.
5918         * main.c (handle_command_errors): Take a const reference.
5919         * linespec.c (parse_linespec): Use std::move.
5920         * infcall.c (run_inferior_call): Use std::move.
5921         (call_function_by_hand_dummy): Use std::move.
5922         * exec.c (try_open_exec_file): Use std::move.
5923         * exceptions.h (exception_print, exception_fprintf)
5924         (exception_print_same): Update.
5925         * exceptions.c (print_exception, exception_print)
5926         (exception_fprintf, exception_print_same): Change parameters to
5927         const reference.
5928         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5929         * common/new-op.c: Use std::move.
5930         * common/common-exceptions.h (struct gdb_exception): Add move
5931         constructor.
5932         (struct gdb_exception_error, struct gdb_exception_quit, struct
5933         gdb_quit_bad_alloc): Change constructor to move constructor.
5934         (throw_exception): Change parameter to rvalue reference.
5935         * common/common-exceptions.c (throw_exception): Take rvalue
5936         reference.
5937         * cli/cli-interp.c (safe_execute_command): Use std::move.
5938         * breakpoint.c (insert_bp_location, location_to_sals): Use
5939         std::move.
5940
5941 2019-04-25  Tom Tromey  <tromey@adacore.com>
5942
5943         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5944         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5945         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5946         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5947         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5948         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5949         guile/scm-value.c: Use unpack.
5950         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5951         gdbscm_gdb_exception.
5952         (gdbscm_throw_gdb_exception): Likewise.
5953         (struct gdbscm_gdb_exception): New.
5954         (unpack): New function.
5955         (gdbscm_wrap): Use unpack.
5956
5957 2019-04-25  Tom Tromey  <tromey@adacore.com>
5958
5959         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5960         (gdb_rl_callback_handler): Use std::move.
5961         * common/common-exceptions.h (struct gdb_exception): Add move
5962         assignment operator.
5963         (throw_exception_sjlj): Change "exception" to const reference.
5964         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5965         (throw_exception_sjlj): Change "exception" to const reference.
5966
5967 2019-04-25  Tom Tromey  <tromey@adacore.com>
5968
5969         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5970         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5971         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5972         Update.
5973         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5974         Update.
5975         * mi/mi-interp.c (mi_interp::exec): Update.
5976         * linespec.c (parse_linespec): Update.
5977         * infcall.c (run_inferior_call): Update.
5978         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5979         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5980         (gdbscm_lookup_global_symbol): Update.
5981         * guile/scm-param.c (gdbscm_parameter_value): Update.
5982         * guile/scm-frame.c (gdbscm_frame_read_register)
5983         (gdbscm_frame_read_var): Update.
5984         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5985         * exec.c (try_open_exec_file): Update.
5986         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5987         (gdb_rl_callback_handler): Update.
5988         * common/common-exceptions.h (exception_none): Don't declare.
5989         * common/common-exceptions.c (exception_none): Don't define.
5990         (struct catcher) <exception>: Update.
5991         * cli/cli-interp.c (safe_execute_command): Update.
5992         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5993
5994 2019-04-25  Ali Tamur  <tamur@google.com>
5995
5996         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5997         (read_attribute_value): Likewise.
5998         (dwarf2_read_addr_index): Update comment.
5999         (read_str_index): Add DW_FORM_strx.
6000         (dwarf2_string_attr): Likewise.
6001         (dwarf2_const_value_attr): Likewise.
6002         (dump_die_shallow): Likewise.
6003         (dwarf2_fetch_constant_bytes): Likewise.
6004         (skip_form_bytes): Likewise.
6005         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6006
6007 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6008
6009         PR corefiles/11608
6010         PR corefiles/18187
6011         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6012         OFFSET.  Verify if current mapping contains an ELF header.
6013         (linux_find_memory_regions_full): Adjust call to
6014         dump_mapping_p.
6015
6016 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6017             Kang Li <kanglictf@gmail.com>
6018
6019         PR gdb/21600
6020
6021         * dwarf2-frame.c (read_initial_length): Be consistent about using
6022         unsigned representation of length.
6023         (decode_frame_entry_1): Likewise.  Check for wraparound of
6024         end pointer as well as buffer overflow.
6025
6026 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6027
6028         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6029         "vq".
6030
6031 2019-04-24  Tom Tromey  <tromey@adacore.com>
6032
6033         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6034
6035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6036
6037         * s12z-tdep.c (s12z_unwind_pc): Delete.
6038         (s12z_unwind_sp): Delete.
6039         (s12z_gdbarch_init): Don't register deleted functions with
6040         gdbarch.
6041
6042 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6043
6044         * rl78-tdep.c (rl78_unwind_sp): Delete.
6045         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6046
6047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6048
6049         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6050         (xstormy16_unwind_pc): Delete.
6051         (xstormy16_dummy_id): Delete.
6052         (xstormy16_gdbarch_init): Don't register deleted functions with
6053         gdbarch.
6054
6055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * vax-tdep.c (vax_unwind_pc): Delete.
6058         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6059
6060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6061
6062         * v850-tdep.c (v850_unwind_sp): Delete.
6063         (v850_unwind_pc): Delete.
6064         (v850_dummy_id): Delete.
6065         (v850_gdbarch_init): Don't register deleted functions with
6066         gdbarch.
6067
6068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6069
6070         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6071         (tilegx_unwind_pc): Delete.
6072         (tilegx_unwind_dummy_id): Delete.
6073         (tilegx_gdbarch_init): Don't register deleted functions with
6074         gdbarch.
6075
6076 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6077
6078         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6079         (tic6x_dummy_id): Delete.
6080         (tic6x_gdbarch_init): Don't register deleted functions with
6081         gdbarch.
6082
6083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6084
6085         * sparc-tdep.c (sparc_unwind_pc): Delete.
6086         (sparc32_gdbarch_init): Don't register deleted function with
6087         gdbarch.
6088
6089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6090
6091         * sh-tdep.c (sh_unwind_sp): Delete.
6092         (sh_unwind_pc): Delete.
6093         (sh_dummy_id): Delete.
6094         (sh_gdbarch_init): Don't register deleted functions with
6095         gdbarch.
6096
6097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6098
6099         * score-tdep.c (score_unwind_sp): Delete.
6100         (score_unwind_pc): Delete.
6101         (score_dummy_id): Delete.
6102         (score_gdbarch_init): Don't register deleted functions with
6103         gdbarch.
6104
6105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         * rx-tdep.c (rx_unwind_pc): Delete.
6108         (rx_unwind_sp): Delete.
6109         (rx_dummy_id): Delete.
6110         (rx_gdbarch_init): Don't register deleted functions with
6111         gdbarch.  Update comment.
6112
6113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6114
6115         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6116         (rs6000_dummy_id): Delete.
6117         (rs6000_gdbarch_init): Don't register deleted functions with
6118         gdbarch.
6119
6120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6121
6122         * or1k-tdep.c (or1k_dummy_id): Delete.
6123         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6124
6125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6126
6127         * nios2-tdep.c (nios2_dummy_id): Delete.
6128         (nios2_unwind_sp): Delete.
6129         (nios2_gdbarch_init): Don't register deleted functions with
6130         gdbarch.
6131
6132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6133
6134         * nds32-tdep.c (nds32_dummy_id): Delete.
6135         (nds32_unwind_pc): Delete.
6136         (nds32_unwind_sp): Delete.
6137         (nds32_gdbarch_init): Don't register deleted functions with
6138         gdbarch.
6139
6140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6141
6142         * msp430-tdep.c (msp430_unwind_pc): Delete.
6143         (msp430_unwind_sp): Delete.
6144         (msp430_dummy_id): Delete.
6145         (msp430_gdbarch_init): Don't register deleted functions with
6146         gdbarch.
6147
6148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6149
6150         * moxie-tdep.c (moxie_unwind_sp): Delete.
6151         (moxie_unwind_pc): Delete.
6152         (moxie_dummy_id): Delete.
6153         (moxie_gdbarch_init): Don't register deleted functions with
6154         gdbarch.
6155
6156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6159         (mn10300_unwind_pc): Delete.
6160         (mn10300_unwind_sp): Delete.
6161         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6162         mn10300_unwind_sp.
6163         (mn10300_frame_unwind_init): Don't register deleted functions with
6164         gdbarch.
6165
6166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * mep-tdep.c (mep_unwind_pc): Delete.
6169         (mep_unwind_sp): Delete.
6170         (mep_dummy_id): Delete.
6171         (mep_gdbarch_init): Don't register deleted functions with
6172         gdbarch.
6173
6174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6177         (m68hc11_unwind_sp): Delete.
6178         (m68hc11_gdbarch_init): Don't register deleted functions with
6179         gdbarch.
6180
6181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6182
6183         * m32r-tdep.c (m32r_unwind_sp): Delete.
6184         (m32r_unwind_pc): Delete.
6185         (m32r_dummy_id): Delete.
6186         (m32r_gdbarch_init): Don't register deleted functions with
6187         gdbarch.
6188
6189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         * m32c-tdep.c (m32c_unwind_pc): Delete.
6192         (m32c_unwind_sp): Delete.
6193         (m32c_dummy_id): Delete.
6194         (m32c_gdbarch_init): Don't register deleted functions with
6195         gdbarch.
6196
6197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6198
6199         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6200         (lm32_unwind_pc): Delete.
6201         (lm32_dummy_id): Delete.
6202         (lm32_gdbarch_init): Don't register deleted functions with
6203         gdbarch.
6204
6205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6206
6207         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6208         (iq2000_unwind_pc): Delete.
6209         (iq2000_dummy_id): Delete.
6210         (iq2000_gdbarch_init): Don't register deleted functions with
6211         gdbarch.
6212
6213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6214
6215         * nds32-tdep.c (nds32_type_align): Delete.
6216         (nds32_push_dummy_call): Use type_align instead.
6217
6218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6219
6220         * arm-tdep.c (arm_type_align): Only handle vector override case.
6221         (arm_push_dummy_call): Use type_align.
6222         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6223
6224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6227         case.
6228         (pass_on_stack): Use type_align.
6229         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6230         function.
6231
6232 2019-04-23  Tom Tromey  <tromey@adacore.com>
6233
6234         * dwarf2read.c (line_header::file_name_at): Remove unused
6235         overload.
6236
6237 2019-04-23  Tom de Vries  <tdevries@suse.de>
6238
6239         PR gdb/24438
6240         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6241         invocation.
6242
6243
6244 2019-03-27  Ali Tamur  <tamur@google.com>
6245
6246         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6247         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6248         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6249         (dwarf_expr_context::get_addr_index): Likewise
6250         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6251         (symbol_needs_eval_context::get_addr_index): Likewise
6252         (disassemble_dwarf_expression): Add DW_OP_addrx
6253         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6254         (read_cutu_die_from_dwo): Update comment
6255         (skip_one_die): Add DW_FORM_addrx
6256         (read_attribute_value): Likewise
6257         (var_decode_location): Add DW_OP_addrx
6258         (dwarf2_const_value_attr): Add DW_FORM_addrx
6259         (dump_die_shallow): Likewise
6260         (dwarf2_fetch_constant_bytes): Likewise
6261         (decode_locdesc): Add DW_OP_addrx
6262         (skip_form_bytes): Add DW_FORM_addrx
6263
6264 2019-04-22  Ali Tamur  <tamur@google.com>
6265
6266         * MAINTAINERS (Write After Approval): Add self.
6267
6268 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6269
6270         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6271         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6272         (open_symbol_file_object): Likewise.
6273         (svr4_default_sos): Add info parameter.
6274         (svr4_read_so_list): Likewise.
6275         (svr4_current_sos_direct): Adjust functions calls to pass down
6276         info.
6277         (svr4_current_sos_1): Add info parameter.
6278         (svr4_current_sos): Call get_svr4_info, pass info down to
6279         svr4_current_sos_1.
6280         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6281         get_svr4_info.
6282         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6283         get_svr4_info.
6284         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6285         to get_svr4_info.
6286         (probes_table_remove_objfile_probes): Likewise.
6287         (register_solib_event_probe): Add info parameter.
6288         (solist_update_incremental): Pass info parameter down to
6289         svr4_read_so_list.
6290         (disable_probes_interface): Add info parameter.
6291         (svr4_handle_solib_event): Pass current_program_space to
6292         get_svr4_info.  Adjust disable_probes_interface cleanup.
6293         (svr4_create_probe_breakpoints): Add info parameter, pass it
6294         down to register_solib_event_probe.
6295         (svr4_create_solib_event_breakpoints): Add info parameter,
6296         pass it down to svr4_create_probe_breakpoints.
6297         (enable_break): Pass info down to
6298         svr4_create_solib_event_breakpoints.
6299         (svr4_solib_create_inferior_hook): Pass current_program_space to
6300         get_svr4_info.
6301         (svr4_clear_solib): Likewise.
6302
6303 2019-04-22  Pedro Alves  <palves@redhat.com>
6304
6305         * solib-svr4.c (svr4_free_objfile_observer): New.
6306         (probe_and_action::objfile): New field.
6307         (probes_table_htab_remove_objfile_probes)
6308         (probes_table_remove_objfile_probes): New functions.
6309         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6310         in the new probe_and_action.  Don't store the probe in 'lookup'.
6311         (svr4_create_probe_breakpoints): Pass objfile to
6312         register_solib_event_probe.
6313         (_initialize_svr4_solib): Register a free_objfile observer.
6314
6315 2019-04-19  Tom Tromey  <tom@tromey.com>
6316
6317         * common/queue.h: Remove.
6318
6319 2019-04-19  Tom Tromey  <tom@tromey.com>
6320
6321         * event-loop.c: Don't include "common/queue.h".
6322
6323 2019-04-19  Tom Tromey  <tom@tromey.com>
6324
6325         * remote.c (remote_target): Use delete.
6326         * remote-notif.h: Include <list>, not "common/queue.h".
6327         (notif_client_p): Remove typedef.
6328         (remote_notif_state): Add constructor, destructor, initializer.
6329         <notif_queue>: Now a std::list.
6330         (remote_notif_state_xfree): Don't declare.
6331         * remote-notif.c (remote_notif_process, handle_notification)
6332         (remote_notif_state_allocate): Update.
6333         (~remote_notif_state): Rename from remote_notif_state_xfree.
6334
6335 2019-04-19  Tom Tromey  <tom@tromey.com>
6336
6337         * symfile.c (reread_symbols): Update.
6338         * objfiles.c (objfile_register_static_link)
6339         (objfile_lookup_static_link): Update
6340         (~objfile) Don't delete static_links.
6341         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6342
6343 2019-04-19  Tom Tromey  <tom@tromey.com>
6344
6345         * type-stack.h (struct type_stack) <insert>: Constify string.
6346         * type-stack.c (type_stack::insert): Constify string.
6347         * gdbtypes.h (lookup_template_type): Update.
6348         (address_space_name_to_int): Update.
6349         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6350         const.
6351         (lookup_template_type): Make name const.
6352         * c-exp.y: Update rules.
6353         (lex_one_token, classify_name, classify_inner_name)
6354         (c_print_token): Update.
6355         * p-exp.y: Update rules.
6356         (yylex): Update.
6357         * f-exp.y: Update rules.
6358         (yylex): Update.
6359         * d-exp.y: Update rules.
6360         (lex_one_token, classify_name, classify_inner_name): Update.
6361         * parse.c (write_dollar_variable, copy_name): Return std::string.
6362         * parser-defs.h (copy_name): Change return type.
6363         * m2-exp.y: Update rules.
6364         (yylex): Update.
6365         * go-exp.y (lex_one_token): Update.
6366         Update rules.
6367         (classify_unsafe_function, classify_packaged_name)
6368         (classify_name, yylex): Update.
6369
6370 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6371
6372         * configure.ac: add --enable-source-highlight switch.
6373         * configure: Regenerate.
6374         * top.c (print_gdb_version): plumb --enable-source-highlight
6375         status to "show configuration".
6376
6377 2019-04-19  Tom Tromey  <tromey@adacore.com>
6378
6379         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6380         Check ADA_TYPE_P.
6381         (empty_record, ada_template_to_fixed_record_type_1)
6382         (template_to_static_fixed_type)
6383         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6384         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6385         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6386         macros.
6387
6388 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6389
6390         PR symtab/24423:
6391         * source.c (print_source_lines_base): Advance "iter" when a
6392         control character is seen.
6393
6394 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6395
6396         * inferior.h (struct infcall_suspend_state_deleter):
6397         Catch exception in destructor to avoid crash.
6398
6399 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6400
6401         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6402         close to the add_com "shell".
6403
6404 2019-04-18  Tom Tromey  <tromey@adacore.com>
6405
6406         * process-stratum-target.h (class process_stratum_target)
6407         <stratum>: Add "final".
6408
6409 2019-04-17  Tom Tromey  <tromey@adacore.com>
6410
6411         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6412         against nullptr before use.
6413
6414 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6415
6416         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6417
6418 2019-04-17  Jim Wilson  <jimw@sifive.com>
6419             Andrew Burgess  <andrew.burgess@embecosm.com>
6420
6421         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6422         code read might fail, assume 4-byte breakpoint in that case.
6423
6424 2019-04-15  Leszek Swirski  <leszeks@google.com>
6425
6426         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6427         rather than a hand-rolled POD check when checking for forced MEMORY
6428         classification.
6429
6430 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6431
6432         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6433         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6434         function.
6435         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6436         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6437         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6438         declaration.
6439
6440 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6441
6442         * aarch64-linux-nat.c
6443         (aarch64_linux_nat_target::thread_architecture): Add override.
6444         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6445         each VQ.
6446
6447 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6448
6449         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6450
6451 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6454         target types of size 96-bits, add some additional comments, and
6455         check that the builtin type we found was the correct size.
6456
6457 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6458
6459         * utils.c (prompt_for_continue): Don't restore the styling at the
6460         end, as applied_style has the wrong value.  This fixes styling in
6461         long lists of file names that are interrupted by the "Continue?"
6462         prompt.
6463
6464 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6465
6466         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6467         * c-lang.c (c_language_defn): Likewise.
6468         (cplus_language_defn): Likewise.
6469         (asm_language_defn): Likewise.
6470         (minimal_language_defn): Likewise.
6471         * d-lang.c (d_language_defn): Likewise.
6472         * f-lang.c (f_language_defn): Likewise.
6473         * go-lang.c (go_language_defn): Likewise.
6474         * language.c (unknown_language_defn): Likewise.
6475         (auto_language_defn): Likewise.
6476         * language.h (struct language_defn): Remove la_magic field.
6477         (LANG_MAGIC): Delete.
6478         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6479         * objc-lang.c (objc_language_defn): Likewise.
6480         * opencl-lang.c (opencl_language_defn): Likewise.
6481         * p-lang.c (pascal_language_defn): Likewise.
6482         * rust-lang.c (rust_language_defn): Likewise.
6483
6484 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6485
6486         * riscv-tdep.c (riscv_type_align): New function.
6487         (riscv_type_alignment): Delete.
6488         (riscv_arg_location): Use 'type_align'.
6489         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6490
6491 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6492
6493         * gdbtypes.c (type_align): A struct with no non-static fields also
6494         has alignment of 1.
6495
6496 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6499         component to 0.
6500         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6501         member.
6502         (riscv_struct_info::analyse): New implementation using new
6503         analyse_inner member function.
6504         (riscv_struct_info::field_offset): New member function.
6505         (riscv_struct_info::m_offsets): New member variable.
6506         (riscv_struct_info::analyse_inner): New private member function,
6507         takes the old implementation of riscv_struct_info::analyse but
6508         extended to track field offsets.
6509         (riscv_call_arg_struct): Update the struct folding special cases
6510         to handle cases where empty C++ structs, which are non-zero
6511         length, are found.
6512         (riscv_arg_location): Initialise the length of each location, a
6513         non-zero length now indicates the location is in use.
6514         (riscv_push_dummy_call): Allow for the first location having a
6515         non-zero offset when setting up arguments.
6516         (riscv_return_value): Likewise, but for return values.
6517
6518 2019-04-11  Tom Tromey  <tromey@adacore.com>
6519
6520         * utils.c (internal_vproblem): Make "msg" const.
6521
6522 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6523
6524         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6525         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6526         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6527         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6528
6529 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6530
6531         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6532         function.
6533         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6534         of amd64_collect_native_gregset.
6535         (amd64_linux_nat_target::store_registers): Likewise.
6536
6537 2019-04-10  Tom Tromey  <tom@tromey.com>
6538
6539         * symtab.c (lookup_global_symbol_from_objfile)
6540         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6541         * objfiles.h (class separate_debug_iterator): New.
6542         (class separate_debug_range): New.
6543         (struct objfile) <separate_debug_objfiles>: New method.
6544         (objfile_separate_debug_iterate): Don't declare.
6545         * objfiles.c (separate_debug_iterator::operator++): Rename from
6546         objfile_separate_debug_iterate.
6547         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6548         iterator.
6549         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6550         iterator.
6551
6552 2019-04-10  Tom Tromey  <tom@tromey.com>
6553
6554         * symfile.c (reread_symbols): Remove old comment.
6555         * objfiles.c (free_all_objfiles): Fix a typo.
6556
6557 2019-04-10  Tom Tromey  <tom@tromey.com>
6558
6559         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6560         * minsyms.c (lookup_minimal_symbol): Use foreach.
6561         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6562         (lookup_minimal_symbol_solib_trampoline): Likewise.
6563         * symfile.c (reread_symbols): Use foreach.
6564
6565 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6566             Tom Tromey  <tromey@adacore.com>
6567
6568         PR rust/24414:
6569         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6570         (rust_lex_int_test): Change "value" to be LONGEST.
6571         (rust_lex_tests): Add test for long integer literal.
6572
6573 2019-04-09  Tom Tromey  <tromey@adacore.com>
6574
6575         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6576         to bool.
6577         (extended_remote_target::attach): Update.
6578         (remote_target::remote_notice_new_inferior): Update.
6579         (remote_target::add_current_inferior_and_thread): Update.
6580         * inferior.c (exit_inferior_1): Use "false".
6581         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6582
6583 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6584
6585         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6586         the "start" command.
6587
6588 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6589
6590         * python/py-inferior.c (infpy_thread_from_thread_handle):
6591         Adjust comments to reflect renaming of thread_from_thread_handle
6592         to thread_from_handle.  Adjust keywords.  Fix type error message.
6593         (inferior_object_methods): Add thread_from_handle.  Retain
6594         thread_from_thread_handle, but mark it as deprecated.
6595
6596 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6597
6598         * gdbthread.h (find_thread_by_handle): Revise declaration.
6599         * thread.c (find_thread_by_handle): Likewise.  Adjust
6600         implementation too.
6601         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6602         support for buffer objects as handles.
6603
6604 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6605
6606         * python/py-infthread.c (thpy_thread_handle): New function.
6607         (thread_object_methods): Register thpy_thread_handle.
6608
6609 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6610
6611         * gdbthread.h (thread_to_thread_handle): Declare.
6612         * thread.c (gdbtypes.h): Include.
6613         (thread_to_thread_handle): New function.
6614
6615         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6616         (target_thread_info_to_thread_handle): Declare.
6617         * target.c (target_thread_info_to_thread_handle): New function.
6618         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6619         * target-delegates.c: Regenerate.
6620
6621         * linux-thread-db.c (class thread_db_target): Add method
6622         thread_info_to_thread_handle.
6623         (thread_db_target::thread_info_to_thread_handle): Define.
6624         * remote.c (class remote_target): Add new method
6625         thread_info_to_thread_handle.
6626         (remote_target::thread_info_to_thread_handle): Define.
6627
6628 2019-04-08  Pedro Alves  <palves@redhat.com>
6629
6630         * common/common-exceptions.c (throw_exception): Don't create
6631         named object to throw; throw directly.
6632         (throw_it): Likewise.  Don't initialize gdb_exception::message
6633         here, with new; pass FMT and AP to the ctor instead.
6634         * common/common-exceptions.h: Include <string>.
6635         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6636         const char *, va_list)): New ctor.  Use std::make_shared.
6637         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6638         errors)): Delete.
6639         (gdb_exception_error::gdb_exception_error(enum errors, const char
6640         *, va_list)): New.
6641         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6642         Add assertion.
6643         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6644         errors)): Delete.
6645         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6646         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6647         Add assertion.
6648
6649 2019-04-08  Tom Tromey  <tom@tromey.com>
6650
6651         * valops.c (value_rtti_indirect_type): Replace throw_exception
6652         with throw.
6653         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6654         with throw.
6655         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6656         throw.
6657         * target.c (target_translate_tls_address): Replace throw_exception
6658         with throw.
6659         * stack.c (frame_apply_command_count): Replace throw_exception
6660         with throw.
6661         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6662         throw.
6663         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6664         with throw.
6665         * rs6000-tdep.c (rs6000_frame_cache)
6666         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6667         * remote.c: Replace throw_exception with throw.
6668         * record-full.c (record_full_message, record_full_wait_1)
6669         (record_full_restore): Replace throw_exception with throw.
6670         * record-btrace.c:
6671         (get_thread_current_frame_id, record_btrace_start_replaying)
6672         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6673         (cmd_record_btrace_start): Replace throw_exception with throw.
6674         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6675         throw.
6676         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6677         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6678         * linespec.c:
6679         (find_linespec_symbols): Replace throw_exception with throw.
6680         * infrun.c (displaced_step_prepare, resume): Replace
6681         throw_exception with throw.
6682         * infcmd.c (post_create_inferior): Replace throw_exception with
6683         throw.
6684         * inf-loop.c (inferior_event_handler): Replace throw_exception
6685         with throw.
6686         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6687         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6688         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6689         (get_prev_frame_always, get_frame_pc_if_available)
6690         (get_frame_address_in_block_if_available, get_frame_language):
6691         Replace throw_exception with throw.
6692         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6693         throw_exception with throw.
6694         * eval.c (fetch_subexp_value, evaluate_var_value)
6695         (evaluate_funcall, evaluate_subexp_standard): Replace
6696         throw_exception with throw.
6697         * dwarf2loc.c (call_site_find_chain)
6698         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6699         Replace throw_exception with throw.
6700         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6701         with throw.
6702         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6703         throw.
6704         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6705         * completer.c (complete_line_internal): Replace throw_exception
6706         with throw.
6707         * compile/compile-object-run.c (compile_object_run): Replace
6708         throw_exception with throw.
6709         * cli/cli-script.c (process_next_line): Replace throw_exception
6710         with throw.
6711         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6712         (btrace_enable, btrace_maint_update_pt_packets): Replace
6713         throw_exception with throw.
6714         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6715         throw_exception with throw.
6716         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6717         throw_exception with throw.
6718         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6719         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6720         * aarch64-tdep.c (aarch64_make_prologue_cache)
6721         (aarch64_make_stub_cache): Replace throw_exception with throw.
6722
6723 2019-04-08  Tom Tromey  <tom@tromey.com>
6724
6725         * common/common-exceptions.c (throw_exception): Rename from
6726         throw_exception_cxx.  Remove old copy.  Make argument const.
6727         (throw_it): Create and throw exception objects directly.
6728         * common/common-exceptions.h (throw_exception): Make argument
6729         const.
6730         (struct gdb_exception_error): Add constructor.
6731         (struct gdb_exception_quit): Add constructor.
6732
6733 2019-04-08  Tom Tromey  <tom@tromey.com>
6734
6735         * common/common-exceptions.h (exception_rethrow): Don't declare.
6736         (TRY_SJLJ): Update comment.
6737         (TRY, CATCH, END_CATCH): Remove.
6738         * common/common-exceptions.c (exception_rethrow): Remove.
6739
6740 2019-04-08  Tom Tromey  <tom@tromey.com>
6741
6742         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6743         Remove.
6744         (gdb_exception_error): Rename from
6745         gdb_exception_RETURN_MASK_ERROR.
6746         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6747         (gdb_quit_bad_alloc): Update.
6748         * aarch64-tdep.c: Update.
6749         * ada-lang.c: Update.
6750         * ada-typeprint.c: Update.
6751         * ada-valprint.c: Update.
6752         * amd64-tdep.c: Update.
6753         * arch-utils.c: Update.
6754         * break-catch-throw.c: Update.
6755         * breakpoint.c: Update.
6756         * btrace.c: Update.
6757         * c-varobj.c: Update.
6758         * cli/cli-cmds.c: Update.
6759         * cli/cli-interp.c: Update.
6760         * cli/cli-script.c: Update.
6761         * common/common-exceptions.c: Update.
6762         * common/new-op.c: Update.
6763         * common/selftest.c: Update.
6764         * compile/compile-c-symbols.c: Update.
6765         * compile/compile-cplus-symbols.c: Update.
6766         * compile/compile-object-load.c: Update.
6767         * compile/compile-object-run.c: Update.
6768         * completer.c: Update.
6769         * corelow.c: Update.
6770         * cp-abi.c: Update.
6771         * cp-support.c: Update.
6772         * cp-valprint.c: Update.
6773         * darwin-nat.c: Update.
6774         * disasm-selftests.c: Update.
6775         * dtrace-probe.c: Update.
6776         * dwarf-index-cache.c: Update.
6777         * dwarf-index-write.c: Update.
6778         * dwarf2-frame-tailcall.c: Update.
6779         * dwarf2-frame.c: Update.
6780         * dwarf2loc.c: Update.
6781         * dwarf2read.c: Update.
6782         * eval.c: Update.
6783         * event-loop.c: Update.
6784         * event-top.c: Update.
6785         * exec.c: Update.
6786         * f-valprint.c: Update.
6787         * fbsd-tdep.c: Update.
6788         * frame-unwind.c: Update.
6789         * frame.c: Update.
6790         * gdbtypes.c: Update.
6791         * gnu-v3-abi.c: Update.
6792         * guile/guile-internal.h: Update.
6793         * guile/scm-block.c: Update.
6794         * guile/scm-breakpoint.c: Update.
6795         * guile/scm-cmd.c: Update.
6796         * guile/scm-disasm.c: Update.
6797         * guile/scm-frame.c: Update.
6798         * guile/scm-lazy-string.c: Update.
6799         * guile/scm-math.c: Update.
6800         * guile/scm-param.c: Update.
6801         * guile/scm-ports.c: Update.
6802         * guile/scm-pretty-print.c: Update.
6803         * guile/scm-symbol.c: Update.
6804         * guile/scm-symtab.c: Update.
6805         * guile/scm-type.c: Update.
6806         * guile/scm-value.c: Update.
6807         * i386-linux-tdep.c: Update.
6808         * i386-tdep.c: Update.
6809         * inf-loop.c: Update.
6810         * infcall.c: Update.
6811         * infcmd.c: Update.
6812         * infrun.c: Update.
6813         * jit.c: Update.
6814         * language.c: Update.
6815         * linespec.c: Update.
6816         * linux-fork.c: Update.
6817         * linux-nat.c: Update.
6818         * linux-tdep.c: Update.
6819         * linux-thread-db.c: Update.
6820         * main.c: Update.
6821         * mi/mi-cmd-break.c: Update.
6822         * mi/mi-cmd-stack.c: Update.
6823         * mi/mi-interp.c: Update.
6824         * mi/mi-main.c: Update.
6825         * objc-lang.c: Update.
6826         * p-valprint.c: Update.
6827         * parse.c: Update.
6828         * ppc-linux-tdep.c: Update.
6829         * printcmd.c: Update.
6830         * python/py-arch.c: Update.
6831         * python/py-breakpoint.c: Update.
6832         * python/py-cmd.c: Update.
6833         * python/py-finishbreakpoint.c: Update.
6834         * python/py-frame.c: Update.
6835         * python/py-framefilter.c: Update.
6836         * python/py-gdb-readline.c: Update.
6837         * python/py-inferior.c: Update.
6838         * python/py-infthread.c: Update.
6839         * python/py-lazy-string.c: Update.
6840         * python/py-linetable.c: Update.
6841         * python/py-objfile.c: Update.
6842         * python/py-param.c: Update.
6843         * python/py-prettyprint.c: Update.
6844         * python/py-progspace.c: Update.
6845         * python/py-record-btrace.c: Update.
6846         * python/py-record.c: Update.
6847         * python/py-symbol.c: Update.
6848         * python/py-type.c: Update.
6849         * python/py-unwind.c: Update.
6850         * python/py-utils.c: Update.
6851         * python/py-value.c: Update.
6852         * python/python.c: Update.
6853         * record-btrace.c: Update.
6854         * record-full.c: Update.
6855         * remote-fileio.c: Update.
6856         * remote.c: Update.
6857         * riscv-tdep.c: Update.
6858         * rs6000-aix-tdep.c: Update.
6859         * rs6000-tdep.c: Update.
6860         * rust-exp.y: Update.
6861         * rust-lang.c: Update.
6862         * s390-tdep.c: Update.
6863         * selftest-arch.c: Update.
6864         * solib-dsbt.c: Update.
6865         * solib-frv.c: Update.
6866         * solib-spu.c: Update.
6867         * solib-svr4.c: Update.
6868         * solib.c: Update.
6869         * sparc64-linux-tdep.c: Update.
6870         * stack.c: Update.
6871         * symfile-mem.c: Update.
6872         * symmisc.c: Update.
6873         * target.c: Update.
6874         * thread.c: Update.
6875         * top.c: Update.
6876         * tracefile-tfile.c: Update.
6877         * tui/tui.c: Update.
6878         * typeprint.c: Update.
6879         * unittests/cli-utils-selftests.c: Update.
6880         * unittests/parse-connection-spec-selftests.c: Update.
6881         * valops.c: Update.
6882         * valprint.c: Update.
6883         * value.c: Update.
6884         * varobj.c: Update.
6885         * windows-nat.c: Update.
6886         * x86-linux-nat.c: Update.
6887         * xml-support.c: Update.
6888
6889 2019-04-08  Tom Tromey  <tom@tromey.com>
6890
6891         * xml-support.c: Use C++ exception handling.
6892         * x86-linux-nat.c: Use C++ exception handling.
6893         * windows-nat.c: Use C++ exception handling.
6894         * varobj.c: Use C++ exception handling.
6895         * value.c: Use C++ exception handling.
6896         * valprint.c: Use C++ exception handling.
6897         * valops.c: Use C++ exception handling.
6898         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6899         handling.
6900         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6901         * typeprint.c: Use C++ exception handling.
6902         * tui/tui.c: Use C++ exception handling.
6903         * tracefile-tfile.c: Use C++ exception handling.
6904         * top.c: Use C++ exception handling.
6905         * thread.c: Use C++ exception handling.
6906         * target.c: Use C++ exception handling.
6907         * symmisc.c: Use C++ exception handling.
6908         * symfile-mem.c: Use C++ exception handling.
6909         * stack.c: Use C++ exception handling.
6910         * sparc64-linux-tdep.c: Use C++ exception handling.
6911         * solib.c: Use C++ exception handling.
6912         * solib-svr4.c: Use C++ exception handling.
6913         * solib-spu.c: Use C++ exception handling.
6914         * solib-frv.c: Use C++ exception handling.
6915         * solib-dsbt.c: Use C++ exception handling.
6916         * selftest-arch.c: Use C++ exception handling.
6917         * s390-tdep.c: Use C++ exception handling.
6918         * rust-lang.c: Use C++ exception handling.
6919         * rust-exp.y: Use C++ exception handling.
6920         * rs6000-tdep.c: Use C++ exception handling.
6921         * rs6000-aix-tdep.c: Use C++ exception handling.
6922         * riscv-tdep.c: Use C++ exception handling.
6923         * remote.c: Use C++ exception handling.
6924         * remote-fileio.c: Use C++ exception handling.
6925         * record-full.c: Use C++ exception handling.
6926         * record-btrace.c: Use C++ exception handling.
6927         * python/python.c: Use C++ exception handling.
6928         * python/py-value.c: Use C++ exception handling.
6929         * python/py-utils.c: Use C++ exception handling.
6930         * python/py-unwind.c: Use C++ exception handling.
6931         * python/py-type.c: Use C++ exception handling.
6932         * python/py-symbol.c: Use C++ exception handling.
6933         * python/py-record.c: Use C++ exception handling.
6934         * python/py-record-btrace.c: Use C++ exception handling.
6935         * python/py-progspace.c: Use C++ exception handling.
6936         * python/py-prettyprint.c: Use C++ exception handling.
6937         * python/py-param.c: Use C++ exception handling.
6938         * python/py-objfile.c: Use C++ exception handling.
6939         * python/py-linetable.c: Use C++ exception handling.
6940         * python/py-lazy-string.c: Use C++ exception handling.
6941         * python/py-infthread.c: Use C++ exception handling.
6942         * python/py-inferior.c: Use C++ exception handling.
6943         * python/py-gdb-readline.c: Use C++ exception handling.
6944         * python/py-framefilter.c: Use C++ exception handling.
6945         * python/py-frame.c: Use C++ exception handling.
6946         * python/py-finishbreakpoint.c: Use C++ exception handling.
6947         * python/py-cmd.c: Use C++ exception handling.
6948         * python/py-breakpoint.c: Use C++ exception handling.
6949         * python/py-arch.c: Use C++ exception handling.
6950         * printcmd.c: Use C++ exception handling.
6951         * ppc-linux-tdep.c: Use C++ exception handling.
6952         * parse.c: Use C++ exception handling.
6953         * p-valprint.c: Use C++ exception handling.
6954         * objc-lang.c: Use C++ exception handling.
6955         * mi/mi-main.c: Use C++ exception handling.
6956         * mi/mi-interp.c: Use C++ exception handling.
6957         * mi/mi-cmd-stack.c: Use C++ exception handling.
6958         * mi/mi-cmd-break.c: Use C++ exception handling.
6959         * main.c: Use C++ exception handling.
6960         * linux-thread-db.c: Use C++ exception handling.
6961         * linux-tdep.c: Use C++ exception handling.
6962         * linux-nat.c: Use C++ exception handling.
6963         * linux-fork.c: Use C++ exception handling.
6964         * linespec.c: Use C++ exception handling.
6965         * language.c: Use C++ exception handling.
6966         * jit.c: Use C++ exception handling.
6967         * infrun.c: Use C++ exception handling.
6968         * infcmd.c: Use C++ exception handling.
6969         * infcall.c: Use C++ exception handling.
6970         * inf-loop.c: Use C++ exception handling.
6971         * i386-tdep.c: Use C++ exception handling.
6972         * i386-linux-tdep.c: Use C++ exception handling.
6973         * guile/scm-value.c: Use C++ exception handling.
6974         * guile/scm-type.c: Use C++ exception handling.
6975         * guile/scm-symtab.c: Use C++ exception handling.
6976         * guile/scm-symbol.c: Use C++ exception handling.
6977         * guile/scm-pretty-print.c: Use C++ exception handling.
6978         * guile/scm-ports.c: Use C++ exception handling.
6979         * guile/scm-param.c: Use C++ exception handling.
6980         * guile/scm-math.c: Use C++ exception handling.
6981         * guile/scm-lazy-string.c: Use C++ exception handling.
6982         * guile/scm-frame.c: Use C++ exception handling.
6983         * guile/scm-disasm.c: Use C++ exception handling.
6984         * guile/scm-cmd.c: Use C++ exception handling.
6985         * guile/scm-breakpoint.c: Use C++ exception handling.
6986         * guile/scm-block.c: Use C++ exception handling.
6987         * guile/guile-internal.h: Use C++ exception handling.
6988         * gnu-v3-abi.c: Use C++ exception handling.
6989         * gdbtypes.c: Use C++ exception handling.
6990         * frame.c: Use C++ exception handling.
6991         * frame-unwind.c: Use C++ exception handling.
6992         * fbsd-tdep.c: Use C++ exception handling.
6993         * f-valprint.c: Use C++ exception handling.
6994         * exec.c: Use C++ exception handling.
6995         * event-top.c: Use C++ exception handling.
6996         * event-loop.c: Use C++ exception handling.
6997         * eval.c: Use C++ exception handling.
6998         * dwarf2read.c: Use C++ exception handling.
6999         * dwarf2loc.c: Use C++ exception handling.
7000         * dwarf2-frame.c: Use C++ exception handling.
7001         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7002         * dwarf-index-write.c: Use C++ exception handling.
7003         * dwarf-index-cache.c: Use C++ exception handling.
7004         * dtrace-probe.c: Use C++ exception handling.
7005         * disasm-selftests.c: Use C++ exception handling.
7006         * darwin-nat.c: Use C++ exception handling.
7007         * cp-valprint.c: Use C++ exception handling.
7008         * cp-support.c: Use C++ exception handling.
7009         * cp-abi.c: Use C++ exception handling.
7010         * corelow.c: Use C++ exception handling.
7011         * completer.c: Use C++ exception handling.
7012         * compile/compile-object-run.c: Use C++ exception handling.
7013         * compile/compile-object-load.c: Use C++ exception handling.
7014         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7015         * compile/compile-c-symbols.c: Use C++ exception handling.
7016         * common/selftest.c: Use C++ exception handling.
7017         * common/new-op.c: Use C++ exception handling.
7018         * cli/cli-script.c: Use C++ exception handling.
7019         * cli/cli-interp.c: Use C++ exception handling.
7020         * cli/cli-cmds.c: Use C++ exception handling.
7021         * c-varobj.c: Use C++ exception handling.
7022         * btrace.c: Use C++ exception handling.
7023         * breakpoint.c: Use C++ exception handling.
7024         * break-catch-throw.c: Use C++ exception handling.
7025         * arch-utils.c: Use C++ exception handling.
7026         * amd64-tdep.c: Use C++ exception handling.
7027         * ada-valprint.c: Use C++ exception handling.
7028         * ada-typeprint.c: Use C++ exception handling.
7029         * ada-lang.c: Use C++ exception handling.
7030         * aarch64-tdep.c: Use C++ exception handling.
7031
7032 2019-04-08  Tom Tromey  <tom@tromey.com>
7033
7034         * xml-support.c (gdb_xml_parser::parse): Update.
7035         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7036         * value.c (show_convenience): Update.
7037         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7038         (test_parse_flags_qcs): Update.
7039         * thread.c (thr_try_catch_cmd): Update.
7040         * target.c (target_translate_tls_address): Update.
7041         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7042         (info_frame_command_core, frame_apply_command_count): Update.
7043         * rust-exp.y (rust_lex_exception_test): Update.
7044         * riscv-tdep.c (riscv_print_one_register_info): Update.
7045         * remote.c (remote_target::enable_btrace): Update.
7046         * record-btrace.c (record_btrace_enable_warn): Update.
7047         * python/py-utils.c (gdbpy_convert_exception): Update.
7048         * printcmd.c (do_one_display, print_variable_and_value): Update.
7049         * mi/mi-main.c (mi_print_exception): Update.
7050         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7051         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7052         * linux-nat.c (linux_nat_target::attach): Update.
7053         * linux-fork.c (class scoped_switch_fork_info): Update.
7054         * infrun.c (displaced_step_prepare): Update.
7055         * infcall.c (call_function_by_hand_dummy): Update.
7056         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7057         * gnu-v3-abi.c (print_one_vtable): Update.
7058         * frame.c (get_prev_frame_always): Update.
7059         * f-valprint.c (info_common_command_for_block): Update.
7060         * exec.c (try_open_exec_file): Update.
7061         * exceptions.c (print_exception, exception_print)
7062         (exception_fprintf, exception_print_same): Update.
7063         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7064         * dwarf-index-cache.c (index_cache::store)
7065         (index_cache::lookup_gdb_index): Update.
7066         * darwin-nat.c (maybe_cache_shell): Update.
7067         * cp-valprint.c (cp_print_value_fields): Update.
7068         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7069         (gcc_cplus_symbol_address): Update.
7070         * compile/compile-c-symbols.c (gcc_convert_symbol)
7071         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7072         * common/selftest.c: Update.
7073         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7074         a std::string.
7075         (exception_try_scope_entry, exception_try_scope_exit): Don't
7076         declare.
7077         (struct exception_try_scope): Remove.
7078         (TRY): Don't use exception_try_scope.
7079         (struct gdb_exception): Add constructor, operator=.
7080         <what>: New method.
7081         (struct gdb_exception_RETURN_MASK_ALL)
7082         (struct gdb_exception_RETURN_MASK_ERROR)
7083         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7084         (struct gdb_quit_bad_alloc): Update.
7085         * common/common-exceptions.c (exception_none): Change
7086         initializer.
7087         (struct catcher) <state, exception>: Initialize inline.
7088         <prev>: Remove member.
7089         (current_catcher): Remove.
7090         (catchers): New global.
7091         (exceptions_state_mc_init): Simplify.
7092         (catcher_pop): Remove.
7093         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7094         (try_scope_depth, exception_try_scope_entry)
7095         (exception_try_scope_exit): Remove.
7096         (throw_exception_sjlj): Update.
7097         (exception_messages, exception_messages_size): Remove.
7098         (throw_it): Simplify.
7099         (gdb_exception_sliced_copy): Remove.
7100         (throw_exception_cxx): Update.
7101         * cli/cli-script.c (script_from_file): Update.
7102         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7103         Update.
7104         * ada-valprint.c (ada_val_print): Update.
7105         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7106         (create_excep_cond_exprs): Update.
7107
7108 2019-04-08  Tom Tromey  <tom@tromey.com>
7109
7110         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7111         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7112         (TRY, CATCH, END_CATCH): Remove some definitions.
7113         * common/common-exceptions.c: Don't use GDB_XCPT.
7114         (catcher_list_size): Remove.
7115         (throw_exception, throw_it): Simplify.
7116
7117 2019-04-05  Tom Tromey  <tom@tromey.com>
7118
7119         Revert the header-sorting patch.
7120         * ft32-tdep.c: Revert.
7121         * frv-tdep.c: Revert.
7122         * frv-linux-tdep.c: Revert.
7123         * frame.c: Revert.
7124         * frame-unwind.c: Revert.
7125         * frame-base.c: Revert.
7126         * fork-child.c: Revert.
7127         * findvar.c: Revert.
7128         * findcmd.c: Revert.
7129         * filesystem.c: Revert.
7130         * filename-seen-cache.h: Revert.
7131         * filename-seen-cache.c: Revert.
7132         * fbsd-tdep.c: Revert.
7133         * fbsd-nat.h: Revert.
7134         * fbsd-nat.c: Revert.
7135         * f-valprint.c: Revert.
7136         * f-typeprint.c: Revert.
7137         * f-lang.c: Revert.
7138         * extension.h: Revert.
7139         * extension.c: Revert.
7140         * extension-priv.h: Revert.
7141         * expprint.c: Revert.
7142         * exec.h: Revert.
7143         * exec.c: Revert.
7144         * exceptions.c: Revert.
7145         * event-top.c: Revert.
7146         * event-loop.c: Revert.
7147         * eval.c: Revert.
7148         * elfread.c: Revert.
7149         * dwarf2read.h: Revert.
7150         * dwarf2read.c: Revert.
7151         * dwarf2loc.c: Revert.
7152         * dwarf2expr.h: Revert.
7153         * dwarf2expr.c: Revert.
7154         * dwarf2-frame.c: Revert.
7155         * dwarf2-frame-tailcall.c: Revert.
7156         * dwarf-index-write.h: Revert.
7157         * dwarf-index-write.c: Revert.
7158         * dwarf-index-common.c: Revert.
7159         * dwarf-index-cache.h: Revert.
7160         * dwarf-index-cache.c: Revert.
7161         * dummy-frame.c: Revert.
7162         * dtrace-probe.c: Revert.
7163         * disasm.h: Revert.
7164         * disasm.c: Revert.
7165         * disasm-selftests.c: Revert.
7166         * dictionary.c: Revert.
7167         * dicos-tdep.c: Revert.
7168         * demangle.c: Revert.
7169         * dcache.h: Revert.
7170         * dcache.c: Revert.
7171         * darwin-nat.h: Revert.
7172         * darwin-nat.c: Revert.
7173         * darwin-nat-info.c: Revert.
7174         * d-valprint.c: Revert.
7175         * d-namespace.c: Revert.
7176         * d-lang.c: Revert.
7177         * ctf.c: Revert.
7178         * csky-tdep.c: Revert.
7179         * csky-linux-tdep.c: Revert.
7180         * cris-tdep.c: Revert.
7181         * cris-linux-tdep.c: Revert.
7182         * cp-valprint.c: Revert.
7183         * cp-support.c: Revert.
7184         * cp-namespace.c: Revert.
7185         * cp-abi.c: Revert.
7186         * corelow.c: Revert.
7187         * corefile.c: Revert.
7188         * continuations.c: Revert.
7189         * completer.h: Revert.
7190         * completer.c: Revert.
7191         * complaints.c: Revert.
7192         * coffread.c: Revert.
7193         * coff-pe-read.c: Revert.
7194         * cli-out.h: Revert.
7195         * cli-out.c: Revert.
7196         * charset.c: Revert.
7197         * c-varobj.c: Revert.
7198         * c-valprint.c: Revert.
7199         * c-typeprint.c: Revert.
7200         * c-lang.c: Revert.
7201         * buildsym.c: Revert.
7202         * buildsym-legacy.c: Revert.
7203         * build-id.h: Revert.
7204         * build-id.c: Revert.
7205         * btrace.c: Revert.
7206         * bsd-uthread.c: Revert.
7207         * breakpoint.h: Revert.
7208         * breakpoint.c: Revert.
7209         * break-catch-throw.c: Revert.
7210         * break-catch-syscall.c: Revert.
7211         * break-catch-sig.c: Revert.
7212         * blockframe.c: Revert.
7213         * block.c: Revert.
7214         * bfin-tdep.c: Revert.
7215         * bfin-linux-tdep.c: Revert.
7216         * bfd-target.c: Revert.
7217         * bcache.c: Revert.
7218         * ax-general.c: Revert.
7219         * ax-gdb.h: Revert.
7220         * ax-gdb.c: Revert.
7221         * avr-tdep.c: Revert.
7222         * auxv.c: Revert.
7223         * auto-load.c: Revert.
7224         * arm-wince-tdep.c: Revert.
7225         * arm-tdep.c: Revert.
7226         * arm-symbian-tdep.c: Revert.
7227         * arm-pikeos-tdep.c: Revert.
7228         * arm-obsd-tdep.c: Revert.
7229         * arm-nbsd-tdep.c: Revert.
7230         * arm-nbsd-nat.c: Revert.
7231         * arm-linux-tdep.c: Revert.
7232         * arm-linux-nat.c: Revert.
7233         * arm-fbsd-tdep.c: Revert.
7234         * arm-fbsd-nat.c: Revert.
7235         * arm-bsd-tdep.c: Revert.
7236         * arch-utils.c: Revert.
7237         * arc-tdep.c: Revert.
7238         * arc-newlib-tdep.c: Revert.
7239         * annotate.h: Revert.
7240         * annotate.c: Revert.
7241         * amd64-windows-tdep.c: Revert.
7242         * amd64-windows-nat.c: Revert.
7243         * amd64-tdep.c: Revert.
7244         * amd64-sol2-tdep.c: Revert.
7245         * amd64-obsd-tdep.c: Revert.
7246         * amd64-obsd-nat.c: Revert.
7247         * amd64-nbsd-tdep.c: Revert.
7248         * amd64-nbsd-nat.c: Revert.
7249         * amd64-nat.c: Revert.
7250         * amd64-linux-tdep.c: Revert.
7251         * amd64-linux-nat.c: Revert.
7252         * amd64-fbsd-tdep.c: Revert.
7253         * amd64-fbsd-nat.c: Revert.
7254         * amd64-dicos-tdep.c: Revert.
7255         * amd64-darwin-tdep.c: Revert.
7256         * amd64-bsd-nat.c: Revert.
7257         * alpha-tdep.c: Revert.
7258         * alpha-obsd-tdep.c: Revert.
7259         * alpha-nbsd-tdep.c: Revert.
7260         * alpha-mdebug-tdep.c: Revert.
7261         * alpha-linux-tdep.c: Revert.
7262         * alpha-linux-nat.c: Revert.
7263         * alpha-bsd-tdep.c: Revert.
7264         * alpha-bsd-nat.c: Revert.
7265         * aix-thread.c: Revert.
7266         * agent.c: Revert.
7267         * addrmap.c: Revert.
7268         * ada-varobj.c: Revert.
7269         * ada-valprint.c: Revert.
7270         * ada-typeprint.c: Revert.
7271         * ada-tasks.c: Revert.
7272         * ada-lang.c: Revert.
7273         * aarch64-tdep.c: Revert.
7274         * aarch64-ravenscar-thread.c: Revert.
7275         * aarch64-newlib-tdep.c: Revert.
7276         * aarch64-linux-tdep.c: Revert.
7277         * aarch64-linux-nat.c: Revert.
7278         * aarch64-fbsd-tdep.c: Revert.
7279         * aarch64-fbsd-nat.c: Revert.
7280         * aarch32-linux-nat.c: Revert.
7281
7282 2019-04-05  Tom Tromey  <tom@tromey.com>
7283
7284         * ft32-tdep.c: Sort headers.
7285         * frv-tdep.c: Sort headers.
7286         * frv-linux-tdep.c: Sort headers.
7287         * frame.c: Sort headers.
7288         * frame-unwind.c: Sort headers.
7289         * frame-base.c: Sort headers.
7290         * fork-child.c: Sort headers.
7291         * findvar.c: Sort headers.
7292         * findcmd.c: Sort headers.
7293         * filesystem.c: Sort headers.
7294         * filename-seen-cache.h: Sort headers.
7295         * filename-seen-cache.c: Sort headers.
7296         * fbsd-tdep.c: Sort headers.
7297         * fbsd-nat.h: Sort headers.
7298         * fbsd-nat.c: Sort headers.
7299         * f-valprint.c: Sort headers.
7300         * f-typeprint.c: Sort headers.
7301         * f-lang.c: Sort headers.
7302         * extension.h: Sort headers.
7303         * extension.c: Sort headers.
7304         * extension-priv.h: Sort headers.
7305         * expprint.c: Sort headers.
7306         * exec.h: Sort headers.
7307         * exec.c: Sort headers.
7308         * exceptions.c: Sort headers.
7309         * event-top.c: Sort headers.
7310         * event-loop.c: Sort headers.
7311         * eval.c: Sort headers.
7312         * elfread.c: Sort headers.
7313         * dwarf2read.h: Sort headers.
7314         * dwarf2read.c: Sort headers.
7315         * dwarf2loc.c: Sort headers.
7316         * dwarf2expr.h: Sort headers.
7317         * dwarf2expr.c: Sort headers.
7318         * dwarf2-frame.c: Sort headers.
7319         * dwarf2-frame-tailcall.c: Sort headers.
7320         * dwarf-index-write.h: Sort headers.
7321         * dwarf-index-write.c: Sort headers.
7322         * dwarf-index-common.c: Sort headers.
7323         * dwarf-index-cache.h: Sort headers.
7324         * dwarf-index-cache.c: Sort headers.
7325         * dummy-frame.c: Sort headers.
7326         * dtrace-probe.c: Sort headers.
7327         * disasm.h: Sort headers.
7328         * disasm.c: Sort headers.
7329         * disasm-selftests.c: Sort headers.
7330         * dictionary.c: Sort headers.
7331         * dicos-tdep.c: Sort headers.
7332         * demangle.c: Sort headers.
7333         * dcache.h: Sort headers.
7334         * dcache.c: Sort headers.
7335         * darwin-nat.h: Sort headers.
7336         * darwin-nat.c: Sort headers.
7337         * darwin-nat-info.c: Sort headers.
7338         * d-valprint.c: Sort headers.
7339         * d-namespace.c: Sort headers.
7340         * d-lang.c: Sort headers.
7341         * ctf.c: Sort headers.
7342         * csky-tdep.c: Sort headers.
7343         * csky-linux-tdep.c: Sort headers.
7344         * cris-tdep.c: Sort headers.
7345         * cris-linux-tdep.c: Sort headers.
7346         * cp-valprint.c: Sort headers.
7347         * cp-support.c: Sort headers.
7348         * cp-namespace.c: Sort headers.
7349         * cp-abi.c: Sort headers.
7350         * corelow.c: Sort headers.
7351         * corefile.c: Sort headers.
7352         * continuations.c: Sort headers.
7353         * completer.h: Sort headers.
7354         * completer.c: Sort headers.
7355         * complaints.c: Sort headers.
7356         * coffread.c: Sort headers.
7357         * coff-pe-read.c: Sort headers.
7358         * cli-out.h: Sort headers.
7359         * cli-out.c: Sort headers.
7360         * charset.c: Sort headers.
7361         * c-varobj.c: Sort headers.
7362         * c-valprint.c: Sort headers.
7363         * c-typeprint.c: Sort headers.
7364         * c-lang.c: Sort headers.
7365         * buildsym.c: Sort headers.
7366         * buildsym-legacy.c: Sort headers.
7367         * build-id.h: Sort headers.
7368         * build-id.c: Sort headers.
7369         * btrace.c: Sort headers.
7370         * bsd-uthread.c: Sort headers.
7371         * breakpoint.h: Sort headers.
7372         * breakpoint.c: Sort headers.
7373         * break-catch-throw.c: Sort headers.
7374         * break-catch-syscall.c: Sort headers.
7375         * break-catch-sig.c: Sort headers.
7376         * blockframe.c: Sort headers.
7377         * block.c: Sort headers.
7378         * bfin-tdep.c: Sort headers.
7379         * bfin-linux-tdep.c: Sort headers.
7380         * bfd-target.c: Sort headers.
7381         * bcache.c: Sort headers.
7382         * ax-general.c: Sort headers.
7383         * ax-gdb.h: Sort headers.
7384         * ax-gdb.c: Sort headers.
7385         * avr-tdep.c: Sort headers.
7386         * auxv.c: Sort headers.
7387         * auto-load.c: Sort headers.
7388         * arm-wince-tdep.c: Sort headers.
7389         * arm-tdep.c: Sort headers.
7390         * arm-symbian-tdep.c: Sort headers.
7391         * arm-pikeos-tdep.c: Sort headers.
7392         * arm-obsd-tdep.c: Sort headers.
7393         * arm-nbsd-tdep.c: Sort headers.
7394         * arm-nbsd-nat.c: Sort headers.
7395         * arm-linux-tdep.c: Sort headers.
7396         * arm-linux-nat.c: Sort headers.
7397         * arm-fbsd-tdep.c: Sort headers.
7398         * arm-fbsd-nat.c: Sort headers.
7399         * arm-bsd-tdep.c: Sort headers.
7400         * arch-utils.c: Sort headers.
7401         * arc-tdep.c: Sort headers.
7402         * arc-newlib-tdep.c: Sort headers.
7403         * annotate.h: Sort headers.
7404         * annotate.c: Sort headers.
7405         * amd64-windows-tdep.c: Sort headers.
7406         * amd64-windows-nat.c: Sort headers.
7407         * amd64-tdep.c: Sort headers.
7408         * amd64-sol2-tdep.c: Sort headers.
7409         * amd64-obsd-tdep.c: Sort headers.
7410         * amd64-obsd-nat.c: Sort headers.
7411         * amd64-nbsd-tdep.c: Sort headers.
7412         * amd64-nbsd-nat.c: Sort headers.
7413         * amd64-nat.c: Sort headers.
7414         * amd64-linux-tdep.c: Sort headers.
7415         * amd64-linux-nat.c: Sort headers.
7416         * amd64-fbsd-tdep.c: Sort headers.
7417         * amd64-fbsd-nat.c: Sort headers.
7418         * amd64-dicos-tdep.c: Sort headers.
7419         * amd64-darwin-tdep.c: Sort headers.
7420         * amd64-bsd-nat.c: Sort headers.
7421         * alpha-tdep.c: Sort headers.
7422         * alpha-obsd-tdep.c: Sort headers.
7423         * alpha-nbsd-tdep.c: Sort headers.
7424         * alpha-mdebug-tdep.c: Sort headers.
7425         * alpha-linux-tdep.c: Sort headers.
7426         * alpha-linux-nat.c: Sort headers.
7427         * alpha-bsd-tdep.c: Sort headers.
7428         * alpha-bsd-nat.c: Sort headers.
7429         * aix-thread.c: Sort headers.
7430         * agent.c: Sort headers.
7431         * addrmap.c: Sort headers.
7432         * ada-varobj.c: Sort headers.
7433         * ada-valprint.c: Sort headers.
7434         * ada-typeprint.c: Sort headers.
7435         * ada-tasks.c: Sort headers.
7436         * ada-lang.c: Sort headers.
7437         * aarch64-tdep.c: Sort headers.
7438         * aarch64-ravenscar-thread.c: Sort headers.
7439         * aarch64-newlib-tdep.c: Sort headers.
7440         * aarch64-linux-tdep.c: Sort headers.
7441         * aarch64-linux-nat.c: Sort headers.
7442         * aarch64-fbsd-tdep.c: Sort headers.
7443         * aarch64-fbsd-nat.c: Sort headers.
7444         * aarch32-linux-nat.c: Sort headers.
7445
7446 2019-04-04  Tom Tromey  <tom@tromey.com>
7447
7448         * varobj.c (varobj_create): Update.
7449         * rust-exp.y (struct rust_parser) <update_innermost_block,
7450         lookup_symbol>: New methods.
7451         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7452         Rename.
7453         (rust_parser::rust_lookup_type)
7454         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7455         * printcmd.c (display_command, do_one_display): Update.
7456         * parser-defs.h (struct parser_state) <parser_state>: Add
7457         "tracker" parameter.
7458         (block_tracker): New member.
7459         (class innermost_block_tracker) <innermost_block_tracker>: Add
7460         "types" parameter.
7461         <reset>: Remove method.
7462         (innermost_block): Don't declare.
7463         (null_post_parser): Update.
7464         * parse.c (innermost_block): Remove global.
7465         (write_dollar_variable): Update.
7466         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7467         Remove "tracker_types" parameter.
7468         (parse_expression): Add "tracker" parameter.
7469         (parse_expression_for_completion): Update.
7470         (null_post_parser): Add "tracker" parameter.
7471         * p-exp.y: Update rules.
7472         * m2-exp.y: Update rules.
7473         * language.h (struct language_defn) <la_post_parser>: Add
7474         "tracker" parameter.
7475         * go-exp.y: Update rules.
7476         * f-exp.y: Update rules.
7477         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7478         parameter.
7479         * d-exp.y: Update rules.
7480         * c-exp.y: Update rules.
7481         * breakpoint.c (set_breakpoint_condition): Create an
7482         innermost_block_tracker.
7483         (watch_command_1): Likewise.
7484         * ada-lang.c (resolve): Add "tracker" parameter.
7485         (resolve_subexp): Likewise.
7486         * ada-exp.y (write_var_from_sym): Update.
7487
7488 2019-04-04  Tom Tromey  <tom@tromey.com>
7489
7490         * type-stack.h: New file.
7491         * type-stack.c: New file.
7492         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7493         type-stack.h.
7494         (insert_into_type_stack, insert_type, push_type, push_type_int)
7495         (insert_type_address_space, pop_type, pop_type_int)
7496         (pop_typelist, pop_type_stack, append_type_stack)
7497         (push_type_stack, get_type_stack, push_typelist)
7498         (follow_type_instance_flags, follow_types): Don't declare.
7499         * parse.c (type_stack): Remove global.
7500         (parse_exp_in_context): Update.
7501         (insert_into_type_stack, insert_type, push_type, push_type_int)
7502         (insert_type_address_space, pop_type, pop_type_int)
7503         (pop_typelist, pop_type_stack, append_type_stack)
7504         (push_type_stack, get_type_stack, push_typelist)
7505         (follow_type_instance_flags, follow_types): Remove (moved to
7506         type-stack.c).
7507         * f-exp.y (type_stack): New global.
7508         Update rules.
7509         (push_kind_type, f_parse): Update.
7510         * d-exp.y (type_stack): New global.
7511         Update rules.
7512         (d_parse): Update.
7513         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7514         Update rules.
7515         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7516         (HFILES_NO_SRCDIR): Add type-stack.h.
7517
7518 2019-04-04  Tom Tromey  <tom@tromey.com>
7519
7520         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7521         (rust_parser::convert_ast_to_expression, rust_parse)
7522         (rust_lex_test_completion, rust_lex_tests): Update.
7523         * parser-defs.h (struct expr_completion_state): New.
7524         (struct parser_state) <parser_state>: Add completion parameter.
7525         <mark_struct_expression, mark_completion_tag>: New methods.
7526         <parse_completion, m_completion_state>: New members.
7527         (prefixify_expression, null_post_parser): Update.
7528         (mark_struct_expression, mark_completion_tag): Don't declare.
7529         * parse.c (parse_completion, expout_last_struct)
7530         (expout_tag_completion_type, expout_completion_name): Remove
7531         globals.
7532         (parser_state::mark_struct_expression)
7533         (parser_state::mark_completion_tag): Now methods.
7534         (prefixify_expression): Add last_struct parameter.
7535         (prefixify_subexp): Likewise.
7536         (parse_exp_1): Update.
7537         (parse_exp_in_context): Add cstate parameter.  Update.
7538         (parse_expression_for_completion): Create an
7539         expr_completion_state.
7540         (null_post_parser): Add "completion" parameter.
7541         * p-exp.y: Update rules.
7542         (yylex): Update.
7543         * language.h (struct language_defn) <la_post_parser>: Add
7544         "completing" parameter.
7545         * go-exp.y: Update rules.
7546         (lex_one_token): Update.
7547         * expression.h (parse_completion): Don't declare.
7548         * d-exp.y: Update rules.
7549         (lex_one_token): Update rules.
7550         * c-exp.y: Update rules.
7551         (lex_one_token): Update.
7552         * ada-lang.c (resolve): Add "parse_completion" parameter.
7553         (resolve_subexp): Likewise.
7554         (ada_resolve_function): Likewise.
7555
7556 2019-04-04  Tom Tromey  <tom@tromey.com>
7557
7558         * parser-defs.h (struct parser_state) <start_arglist,
7559         end_arglist>: New methods.
7560         <arglist_len, m_funcall_chain>: New members.
7561         (arglist_len, start_arglist, end_arglist): Don't declare.
7562         * parse.c (arglist_len, funcall_chain): Remove global.
7563         (start_arglist, end_arglist): Remove functions.
7564         (parse_exp_in_context): Update.
7565         * p-exp.y: Update rules.
7566         * m2-exp.y: Update rules.
7567         * go-exp.y: Update rules.
7568         * f-exp.y: Update rules.
7569         * d-exp.y: Update rules.
7570         * c-exp.y: Update rules.
7571
7572 2019-04-04  Tom Tromey  <tom@tromey.com>
7573
7574         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7575         lex_operator, push_back>: New methods.
7576         Update all rules.
7577         (rust_parser::lex_hex, lex_escape): Rename and update.
7578         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7579         (rust_parser::lex_operator): Rename and update.
7580         (rust_parser::lex_number, rustyylex, rustyyerror)
7581         (rust_lex_test_init, rust_lex_test_sequence)
7582         (rust_lex_test_push_back, rust_lex_tests): Update.
7583         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7584         parameter.
7585         <lexptr, prev_lexptr>: New members.
7586         (lexptr, prev_lexptr): Don't declare.
7587         * parse.c (lexptr, prev_lexptr): Remove globals.
7588         (parse_exp_in_context): Update.
7589         * p-exp.y (yylex, yyerror): Update.
7590         * m2-exp.y (parse_number, yylex, yyerror): Update.
7591         * go-exp.y (lex_one_token, yyerror): Update.
7592         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7593         * d-exp.y (lex_one_token, yyerror): Update.
7594         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7595         (lex_one_token, yyerror): Update.
7596         * ada-lex.l (YY_INPUT): Update.
7597         (rewind_to_char): Update.
7598         * ada-exp.y (yyerror): Update.
7599
7600 2019-04-04  Tom Tromey  <tom@tromey.com>
7601
7602         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7603         * parser-defs.h (struct parser_state) <parser_state>: Add new
7604         parameter.
7605         <comma_terminates>: New member.
7606         (comma_terminates): Don't declare global.
7607         * parse.c (comma_terminates): Remove global.
7608         (parse_exp_in_context): Update.
7609         * p-exp.y (yylex): Update.
7610         * m2-exp.y (yylex): Update.
7611         * go-exp.y (lex_one_token): Update.
7612         * f-exp.y (yylex): Update.
7613         * d-exp.y (lex_one_token): Update.
7614         * c-exp.y (lex_one_token): Update.
7615         * ada-lex.l: Update.
7616
7617 2019-04-04  Tom Tromey  <tom@tromey.com>
7618
7619         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7620         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7621         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7622         * parser-defs.h (paren_depth): Don't declare.
7623         * parse.c (paren_depth): Remove global.
7624         (parse_exp_in_context): Update.
7625         * p-exp.y (paren_depth): New global.
7626         (pascal_parse): Initialize it.
7627         * m2-exp.y (paren_depth): New global.
7628         (m2_parse): Initialize it.
7629         * go-exp.y (paren_depth): New global.
7630         (go_parse): Initialize it.
7631         * f-exp.y (paren_depth): New global.
7632         (f_parse): Initialize it.
7633         * d-exp.y (paren_depth): New global.
7634         (d_parse): Initialize it.
7635         * c-exp.y (paren_depth): New global.
7636         (c_parse): Initialize it.
7637         * ada-lex.l (paren_depth): New global.
7638         (lexer_init): Initialize it.
7639
7640 2019-04-04  Tom Tromey  <tom@tromey.com>
7641
7642         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7643         (rust_parser::convert_ast_to_type)
7644         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7645         * parser-defs.h (struct parser_state) <parser_state>: Add
7646         parameters.  Initialize new members.
7647         <expression_context_block, expression_context_pc>: New members.
7648         * parse.c (expression_context_block, expression_context_pc):
7649         Remove globals.
7650         (parse_exp_in_context): Update.
7651         * p-exp.y: Update all rules.
7652         (yylex): Update.
7653         * m2-exp.y: Update all rules.
7654         (yylex): Update.
7655         * go-exp.y (yylex): Update.
7656         * f-exp.y (yylex): Update.
7657         * d-exp.y: Update all rules.
7658         (yylex): Update.
7659         * c-exp.y: Update all rules.
7660         (lex_one_token, classify_name, yylex, c_parse): Update.
7661         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7662
7663 2019-04-04  Tom Tromey  <tom@tromey.com>
7664
7665         * gdbarch.h, gdbarch.c: Rebuild.
7666         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7667         * stap-probe.h:
7668         (struct stap_parse_info): Replace "parser_state" with
7669         "expr_builder".
7670         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7671         (parser_state): New class.
7672         * parse.c (expr_builder): Rename.
7673         (expr_builder::release): Rename.
7674         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7675         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7676         (write_exp_elt_longcst, write_exp_elt_floatcst)
7677         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7678         (write_exp_string_vector, write_exp_bitstring)
7679         (write_exp_msymbol, mark_struct_expression)
7680         (write_dollar_variable)
7681         (insert_type_address_space, increase_expout_size): Replace
7682         "parser_state" with "expr_builder".
7683         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7684         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7685         "parser_state" with "expr_builder".
7686
7687 2019-04-04  Tom Tromey  <tom@tromey.com>
7688
7689         * rust-exp.y: Replace "parse_language" with method call.
7690         * p-exp.y:
7691         (yylex): Replace "parse_language" with method call.
7692         * m2-exp.y:
7693         (yylex): Replace "parse_language" with method call.
7694         * go-exp.y (classify_name): Replace "parse_language" with method
7695         call.
7696         * f-exp.y (yylex): Replace "parse_language" with method call.
7697         * d-exp.y (lex_one_token): Replace "parse_language" with method
7698         call.
7699         * c-exp.y:
7700         (lex_one_token, classify_name, yylex): Replace "parse_language"
7701         with method call.
7702         * ada-exp.y (find_primitive_type, type_char)
7703         (type_system_address): Replace "parse_language" with method call.
7704
7705 2019-04-04  Tom Tromey  <tom@tromey.com>
7706
7707         * rust-exp.y: Replace "parse_gdbarch" with method call.
7708         * parse.c (write_dollar_variable, insert_type_address_space):
7709         Replace "parse_gdbarch" with method call.
7710         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7711         call.
7712         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7713         call.
7714         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7715         "parse_gdbarch" with method call.
7716         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7717         with method call.
7718         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7719         "parse_gdbarch" with method call.
7720         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7721         "parse_gdbarch" with method call.
7722         * c-exp.y (parse_type, parse_number, classify_name): Replace
7723         "parse_gdbarch" with method call.
7724         * ada-lex.l: Replace "parse_gdbarch" with method call.
7725         * ada-exp.y (parse_type, find_primitive_type, type_char)
7726         (type_system_address): Replace "parse_gdbarch" with method call.
7727
7728 2019-04-04  Tom Tromey  <tom@tromey.com>
7729
7730         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7731         * stap-probe.c (stap_parse_argument): Update.
7732         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7733         initial_size parameter.
7734         * rust-exp.y (rust_lex_tests): Update.
7735         * parse.c (parser_state): Update.
7736         (parse_exp_in_context): Update.
7737         * parser-defs.h (struct parser_state) <parser_state>: Remove
7738         "initial_size" parameter.
7739
7740 2019-04-04  Tom Tromey  <tom@tromey.com>
7741
7742         * parser-defs.h (increase_expout_size): Don't declare.
7743         * parse.c (increase_expout_size): Now static.
7744
7745 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7746
7747         * gnu-nat.c (gnu_nat_target::wait): Fix
7748         target_waitstatus_to_string call.
7749
7750 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7751
7752         * eval.c (evaluate_subexp_standard): Handle internal functions
7753         during Fortran function call handling.
7754
7755 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7756
7757         * NEWS: Mention new internal functions.
7758         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7759         (read_base_type): Use dwarf2_init_complex_target_type.
7760         * value.c (creal_internal_fn): New function.
7761         (cimag_internal_fn): New function.
7762         (_initialize_values): Register new internal functions.
7763
7764 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7765
7766         * infrun.c (stop_all_threads): If debug_infrun, always
7767         trace the wait status after wait_one, using
7768         target_waitstatus_to_string and target_pid_to_str.
7769         (handle_inferior_event): Replace various trace of
7770         wait status kind by a single trace.
7771         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7772         wait status kind image by target_waitstatus_to_string.
7773         * target/waitstatus.c (target_waitstatus_to_string): Fix
7774         obsolete comment.
7775
7776 2019-04-01  Tom Tromey  <tromey@adacore.com>
7777
7778         PR symtab/23331:
7779         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7780
7781 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7782             Pedro Alves  <palves@redhat.com>
7783
7784         * top.c (quit_force): Call 'finalize_values'.
7785         * value.c (finalize_values): New function.
7786         * value.h (finalize_values): Declare.
7787
7788 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7789
7790         * NEWS: Announce $_gdb_major and $_gdb_minor.
7791
7792         * top.c (init_gdb_version_vars): New function.
7793         (gdb_init): Call init_gdb_version_vars.
7794
7795 2019-03-29  Tom Tromey  <tromey@adacore.com>
7796
7797         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7798         help text.  Remove dead code.
7799
7800 2019-03-29  Keith Seitz  <keiths@redhat.com>
7801
7802         From Siddhesh Poyarekar:
7803         * f-lang.h (f77_get_upperbound): Return LONGEST.
7804         (f77_get_lowerbound): Likewise.
7805         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7806         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7807         print them.
7808         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7809         plongest to format print it.
7810         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7811         (f77_get_upperbound): Likewise.
7812         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7813         LOWER_BOUND to LONGEST.
7814         (f77_create_arrayprint_offset_tbl): Likewise.
7815
7816 2019-03-29  Keith Seitz  <keiths@redhat.com>
7817
7818         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7819         %s/pulongest for TYPE_LENGTH instead of %d in format
7820         strings.
7821         * ada-typerint.c (ada_print_type): Likewise.
7822         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7823         * compile/compile-c-support.c (generate_register_struct): Likewise.
7824         * gdbtypes.c (recursive_dump_type): Likewise.
7825         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7826         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7827         instead of %d in format strings.
7828         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7829         to std::min to ULONGEST.
7830         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7831         instead of %d in format strings.
7832         * tracepoint.c (info_scope_command): Likewise.
7833         * typeprint.c (print_offset_data::update)
7834         (print_offset_data::finish): Likewise.
7835         * xtensa-tdep.c (xtensa_store_return_value)
7836         (xtensa_push_dummy_call): Likewise.
7837
7838 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7839
7840         * windows-nat.c (display_selector): Fixed format specifications
7841         for 64-bit Cygwin.
7842
7843 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7844
7845         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7846
7847 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7848
7849         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7850         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7851         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7852         (nios2_linux_init_abi): Install it.
7853
7854 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7855
7856         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7857
7858 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7859
7860         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7861
7862 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7863             Tom Tromey  <tromey@adacore.com>
7864
7865         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7866
7867 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7868
7869         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7870         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7871         method to compute the bounds of range types. Also print "[evaluated]"
7872         if the bounds' values come from a dynamic evaluation.
7873
7874 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7875
7876         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7877         whitespace when pretty printing is on.
7878
7879 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7880
7881         * ppc-linux-nat.c: Add include.
7882
7883 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7884
7885         * NEWS: Mention AArch64 Pointer Authentication.
7886
7887 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7888
7889         * arm-linux-nat.c: Add include.
7890
7891 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7892
7893         * source-cache.c (source_cache::get_source_lines): Re-read
7894         fullname after calling open_source_file.
7895
7896 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7897
7898         * NEWS: Mention TLS support for FreeBSD.
7899
7900 2019-03-25  Tom Tromey  <tromey@adacore.com>
7901
7902         * minsyms.c (BUNCH_SIZE): Update comment.
7903         (~minimal_symbol_reader): Remove old comment.
7904         (compact_minimal_symbols): Update comment.
7905         (minimal_symbol_reader::install): Remove old comment.  Update
7906         other comments.
7907
7908 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7909
7910         * s390-linux-nat.c: Add include.
7911
7912 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7913
7914         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7915         Call linux_get_hwcap.
7916         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7917         Likewise.
7918         (aarch64_linux_get_hwcap): Remove function.
7919         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7920         declaration.
7921         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7922         linux_get_hwcap.
7923         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7924         * linux-tdep.c (linux_get_hwcap): Add function.
7925         (linux_get_hwcap2): Likewise.
7926         * linux-tdep.h (linux_get_hwcap): Add declaration.
7927         (linux_get_hwcap2): Likewise.
7928         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7929         (ppc_linux_get_hwcap2): Likewise.
7930         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7931         linux_get_hwcap.
7932         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7933         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7934         (ppc_linux_nat_target::read_description): Likewise.
7935         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7936         * s390-linux-nat.c: Likewise.
7937         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7938
7939 2019-03-24  Tom Tromey  <tom@tromey.com>
7940
7941         * ada-lang.c (standard_lookup): Simplify initialization.
7942         (ada_lookup_symbol_nonlocal): Simplify return.
7943         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7944         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7945         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7946         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7947         initialization.
7948         * solib.c (solib_global_lookup): Simplify.
7949         * symtab.c (null_block_symbol): Remove.
7950         (symbol_cache_lookup): Simplify returns.
7951         (lookup_language_this): Simplify returns.
7952         (lookup_symbol_aux): Simplify return.
7953         (lookup_local_symbol): Simplify returns.
7954         (lookup_global_symbol_from_objfile): Simplify return.
7955         (lookup_symbol_in_objfile_symtabs)
7956         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7957         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7958         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7959         * cp-namespace.c (cp_lookup_bare_symbol)
7960         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7961         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7962         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7963         (cp_lookup_symbol_via_imports): Simplify initialization.
7964         (find_symbol_in_baseclass): Likewise.
7965         * symtab.h (null_block_symbol): Remove.
7966         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7967         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7968         (d_lookup_symbol_module): Likewise.
7969         (find_symbol_in_baseclass): Simplify initialization.
7970
7971 2019-03-24  Tom Tromey  <tom@tromey.com>
7972
7973         * expression.h: Don't include symtab.h.
7974         (struct block): Forward declare.
7975
7976 2019-03-24  Tom Tromey  <tom@tromey.com>
7977
7978         * c-exp.y (typebase): Remove casts.
7979         * gdbtypes.c (lookup_unsigned_typename, )
7980         (lookup_signed_typename): Remove cast.
7981         * eval.c (parse_to_comma_and_eval): Remove cast.
7982         * parse.c (write_dollar_variable): Remove cast.
7983         * block.h (struct block) <superblock>: Now const.
7984         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7985         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7986         (map_block): Make "block" const.
7987         * symfile.h (struct quick_symbol_functions)
7988         <map_matching_symbols>: Constify block argument to "callback".
7989         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7990         const.
7991         (find_pc_sect_compunit_symtab): Make "b" const.
7992         (find_symbol_at_address): Likewise.
7993         (search_symbols): Likewise.
7994         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7995         (dw2_debug_names_lookup_symbol): Likewise.
7996         (dw2_map_matching_symbols): Update.
7997         * p-valprint.c (pascal_val_print): Remove "block".
7998         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7999         (aux_add_nonlocal_symbols): Make "block" const.
8000         (resolve_subexp): Remove cast.
8001         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8002         const.
8003         (iterate_over_file_blocks): Likewise.
8004         * f-exp.y (%union) <bval>: Remove.
8005         * coffread.c (patch_opaque_types): Make "b" const.
8006         * spu-tdep.c (spu_catch_start): Make "block" const.
8007         * c-valprint.c (print_unpacked_pointer): Remove "block".
8008         * symmisc.c (dump_symtab_1): Make "b" const.
8009         (block_depth): Make "block" const.
8010         * d-exp.y (%union) <bval>: Remove.
8011         * cp-support.h (cp_lookup_rtti_type): Update.
8012         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8013         * psymtab.c (psym_lookup_symbol): Make "block" const.
8014         (maintenance_check_psymtabs): Make "b" const.
8015         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8016         (enumerate_locals, enumerate_args): Update.
8017         * python/py-symtab.c (stpy_global_block): Make "block" const.
8018         (stpy_static_block): Likewise.
8019         * inline-frame.c (block_starting_point_at): Make "new_block"
8020         const.
8021         * block.c (find_block_in_blockvector): Make return type const.
8022         (blockvector_for_pc_sect): Make "b" const.
8023         (find_block_in_blockvector): Make "b" const.
8024
8025 2019-03-23  Tom Tromey  <tom@tromey.com>
8026
8027         * varobj.c (varobj_create): Update.
8028         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8029         * printcmd.c (display_command, do_one_display): Don't reset
8030         innermost_block.
8031         * parser-defs.h (enum innermost_block_tracker_type): Move to
8032         expression.h.
8033         (innermost_block): Update comment.
8034         * parse.c (parse_exp_1): Add tracker_types parameter.
8035         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8036         tracker_types parameter.  Reset innermost_block.
8037         (parse_exp_in_context): Remove.
8038         (parse_expression_for_completion): Update.
8039         * objfiles.c (~objfile): Don't reset expression_context_block or
8040         innermost_block.
8041         * expression.h (enum innermost_block_tracker_type): Move from
8042         parser-defs.h.
8043         (parse_exp_1): Add tracker_types parameter.
8044         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8045         reset innermost_block.
8046
8047 2019-03-23  Tom Tromey  <tom@tromey.com>
8048
8049         * objfiles.h: Include bcache.h.
8050
8051 2019-03-23  Tom Tromey  <tom@tromey.com>
8052
8053         * linespec.c (get_current_search_block): Use
8054         scoped_restore_current_language.
8055         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8056
8057 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8058             Jiong Wang  <jiong.wang@arm.com>
8059
8060         * aarch64-linux-tdep.c
8061         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8062         section.
8063         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8064
8065 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8066             Jiong Wang  <jiong.wang@arm.com>
8067
8068         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8069         instructions.
8070         (aarch64_analyze_prologue_test): Add PACIASP test.
8071         (aarch64_prologue_prev_register): Unmask PC value.
8072
8073 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8074             Jiong Wang  <jiong.wang@arm.com>
8075
8076         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8077         (aarch64_dwarf2_prev_register): Unmask PC value.
8078         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8079         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8080         DW_CFA_AARCH64_negate_ra_state.
8081         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8082
8083 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8084             Jiong Wang  <jiong.wang@arm.com>
8085
8086         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8087         registers.
8088         (aarch64_pseudo_register_name): Likewise.
8089         (aarch64_pseudo_register_type): Likewise.
8090         (aarch64_pseudo_register_reggroup_p): Likewise.
8091         (aarch64_gdbarch_init): Add pauth registers.
8092         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8093         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8094         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8095         (struct gdbarch_tdep): Add regnum for ra_state.
8096
8097 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8098             Jiong Wang  <jiong.wang@arm.com>
8099
8100         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8101
8102 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8103             Jiong Wang  <jiong.wang@arm.com>
8104
8105         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8106         function.
8107         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8108         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8109         (aarch64_gdbarch_init): Add puth registers.
8110         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8111         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8112         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8113
8114 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8115             Jiong Wang  <jiong.wang@arm.com>
8116
8117         * aarch64-linux-nat.c
8118         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8119         * aarch64-linux-tdep.c
8120         (aarch64_linux_core_read_description): Likewise.
8121         (aarch64_linux_get_hwcap): New function.
8122         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8123         (aarch64_linux_get_hwcap): New declaration.
8124
8125 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8126             Jiong Wang  <jiong.wang@arm.com>
8127
8128         * aarch64-linux-nat.c
8129         (aarch64_linux_nat_target::read_description): Add pauth param.
8130         * aarch64-linux-tdep.c
8131         (aarch64_linux_core_read_description): Likewise.
8132         * aarch64-tdep.c (struct target_desc): Add in pauth.
8133         (aarch64_read_description): Add pauth param.
8134         (aarch64_gdbarch_init): Likewise.
8135         * aarch64-tdep.h (aarch64_read_description): Likewise.
8136         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8137         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8138         * features/Makefile: Add new files.
8139         * features/aarch64-pauth.c: New file.
8140         * features/aarch64-pauth.xml: New file.
8141
8142 2019-03-20  Tom Tromey  <tromey@adacore.com>
8143
8144         * infrun.c (handle_inferior_event): Rename from
8145         handle_inferior_event_1.  Create a scoped_value_mark.
8146         (handle_inferior_event): Remove.
8147
8148 2019-03-19  Tom Tromey  <tromey@adacore.com>
8149
8150         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8151         * infrun.h (print_stop_event): Add "displays" parameter.
8152         * infrun.c (print_stop_event): Add "displays" parameter.
8153
8154 2019-03-19  Pedro Alves  <palves@redhat.com>
8155
8156         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8157         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8158         to -1.  Fix TABs vs spaces.
8159         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8160         * tui/tui-out.h (tui_ui_out) Add intro comments.
8161         <m_line, m_start_of_line>: In-class initialize, and add describing
8162         comment.
8163
8164 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8165
8166         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8167         variable names.
8168         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8169
8170 2019-03-18  Pedro Alves  <palves@redhat.com>
8171             Eli Zaretskii <eliz@gnu.org>
8172
8173         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8174         m_line and m_start_of_line.
8175
8176 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8177
8178         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8179         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8180         it returns a newline.  This fixes a regression in TU mode, whereby
8181         the next line is output on the same screen line as the user input.
8182
8183 2019-03-18  Tom Tromey  <tromey@adacore.com>
8184
8185         * minsyms.c (minimal_symbol_reader::install): Remove call to
8186         obstack_blank.
8187
8188 2019-03-18  Pedro Alves  <palves@redhat.com>
8189
8190         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8191         New globals.
8192         (apply_style): New, factored out from ...
8193         (apply_ansi_escape): ... this.  Handle reverse video mode.
8194         (tui_set_reverse_mode): New function.
8195         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8196         * tui/tui-winsource.c (tui_show_source_line): Use
8197         tui_set_reverse_mode instead of setting A_STANDOUT.
8198         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8199         New setter methods.
8200
8201 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8202
8203         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8204         Handle tabs.
8205
8206 2019-03-18  Tom Tromey  <tromey@adacore.com>
8207
8208         * ada-lang.c (empty_array): Add "high" parameter.
8209         (ada_evaluate_subexp): Update.
8210
8211 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8212
8213         * unittests/string_view-selftests.c: Define
8214         _initialize_string_view_selftests unconditionally.
8215
8216 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8217
8218         PR gdb/24350
8219         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8220
8221 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8222
8223         PR gdb/24351
8224         * windows-nat.c (display_selector): Fix format specifiers.
8225
8226 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8227
8228         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8229         tui_refill_source_window instead of tui_refresh_win, to update the
8230         current execution line.  This fixes redisplay of the current line
8231         when stepping through the code with "next" or "step".
8232
8233 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8234
8235         * source-cache.c (source_cache::get_source_lines): Call
8236         find_source_lines to initialize s->nlines.  This fixes vertical
8237         scrolling of TUI source window when the DOWN arrow is pressed.
8238
8239 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8240
8241         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8242         linux-thread-db.c (_initialize_thread_db): Likewise.
8243
8244 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8245
8246         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8247         wclrtoeol in tui_show_source_line".  This reverts changes made in
8248         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8249
8250 2019-03-15  Tom Tromey  <tom@tromey.com>
8251
8252         * symtab.h (struct minimal_symbol): Derive from
8253         general_symbol_info.
8254         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8255         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8256         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8257         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8258         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8259         (MSYMBOL_SEARCH_NAME): Update.
8260         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8261         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8262         * minsyms.c (minimal_symbol_reader::record_full): Update.
8263
8264 2019-03-15  Tom Tromey  <tom@tromey.com>
8265
8266         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8267
8268 2019-03-15  Tom Tromey  <tom@tromey.com>
8269
8270         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8271         unique_xmalloc_ptr.
8272         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8273         Update.
8274         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8275         (build_minimal_symbol_hash_tables)
8276         (minimal_symbol_reader::install): Update.
8277
8278 2019-03-15  Tom Tromey  <tom@tromey.com>
8279
8280         * symtab.c (create_demangled_names_hash): Update.
8281         (symbol_set_names): Update.
8282         * objfiles.h (struct objfile_per_bfd_storage)
8283         <demangled_names_hash>: Now an htab_up.
8284         * objfiles.c (objfile_per_bfd_storage): Simplify.
8285
8286 2019-03-15  Tom Tromey  <tom@tromey.com>
8287
8288         * objfiles.h (struct objfile_per_bfd_storage): Declare
8289         destructor.
8290         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8291         New.
8292         (get_objfile_bfd_data): Use new.  Don't initialize
8293         language_of_main.
8294         (free_objfile_per_bfd_storage): Remove.
8295         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8296
8297 2019-03-15  Tom Tromey  <tom@tromey.com>
8298
8299         * symfile.c (reread_symbols): Update.
8300         * objfiles.c (objfile::objfile): Update.
8301         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8302         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8303         comment.
8304         (minimal_symbol_reader::install): Update.
8305         (terminate_minimal_symbol_table): Remove.
8306         * jit.c (jit_object_close_impl): Update.
8307
8308 2019-03-15  Tom Tromey  <tom@tromey.com>
8309
8310         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8311         initializations.
8312
8313 2019-03-15  Tom Tromey  <tom@tromey.com>
8314
8315         * objfiles.h (struct objfile_per_bfd_storage)
8316         <demangled_hash_languages>: Now a bitset.
8317         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8318         (lookup_minimal_symbol): Update.
8319
8320 2019-03-15  Tom Tromey  <tom@tromey.com>
8321
8322         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8323         Don't return the symbol.
8324         * coffread.c (record_minimal_symbol): Use record_full.
8325
8326 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8327
8328         The MS-Windows port of ncurses fails to switch to a color pair if
8329         one or both of the colors are the implicit default colors.  This
8330         change records the default colors when TUI is initialized, and
8331         then specifies them explicitly when a color pair uses the default
8332         colors.  This allows color styling in TUI mode on MS-Windows.
8333
8334         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8335         ncurses_norm_attr.
8336         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8337         colors in ncurses_norm_attr.
8338         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8339         "none", replace it with the default color recorded in
8340         ncurses_norm_attr.
8341
8342 2019-03-14  Tom Tromey  <tromey@adacore.com>
8343
8344         * source-cache.h (class source_cache) <get_source_lines>: Return
8345         std::string.
8346         * source-cache.c (source_cache::extract_lines): Handle case where
8347         first_pos==npos.  Return std::string.
8348         (source_cache::get_source_lines): Update.
8349
8350 2019-03-14  Tom Tromey  <tromey@adacore.com>
8351
8352         * NEWS: Add item for "style sources" commands.
8353         * source-cache.c (source_cache::get_source_lines): Check
8354         source_styling.
8355         * cli/cli-style.c (source_styling): New global.
8356         (_initialize_cli_style): Add "style sources" commands.
8357         (show_style_sources): New function.
8358         * cli/cli-style.h (source_styling): Declare.
8359
8360 2019-03-14  Pedro Alves  <palves@redhat.com>
8361             Tom Tromey  <tromey@adacore.com>
8362
8363         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8364         * tui/tui-winsource.c (tui_refill_source_window): New function,
8365         from...
8366         (tui_horizontal_source_scroll): ... here.  Move some logic.
8367         * cli/cli-style.c (set_style_enabled): Notify new observable.
8368         * tui/tui-hooks.c (tui_redisplay_source): New function.
8369         (tui_attach_detach_observers): Attach or detach
8370         tui_redisplay_source.
8371         * observable.h (source_styling_changed): New observable.
8372         * observable.c: Define source_styling_changed observable.
8373
8374 2019-03-13  Tom Tromey  <tromey@adacore.com>
8375
8376         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8377         (i386_gnu_nat_target::store_registers): Update.
8378         * target-debug.h (target_debug_print_std_string): New macro.
8379         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8380         * windows-tdep.c (display_one_tib): Update.
8381         * tui/tui-stack.c (tui_make_status_line): Update.
8382         * top.c (print_inferior_quit_action): Update.
8383         * thread.c (thr_try_catch_cmd): Update.
8384         (add_thread_with_info): Update.
8385         (thread_target_id_str): Update.
8386         (thr_try_catch_cmd): Update.
8387         (thread_command): Update.
8388         (thread_find_command): Update.
8389         * record-btrace.c (record_btrace_target::info_record)
8390         (record_btrace_resume_thread, record_btrace_target::resume)
8391         (record_btrace_cancel_resume, record_btrace_step_thread)
8392         (record_btrace_target::wait, record_btrace_target::wait)
8393         (record_btrace_target::wait, record_btrace_target::stop): Update.
8394         * progspace.c (print_program_space): Update.
8395         * process-stratum-target.c
8396         (process_stratum_target::thread_address_space): Update.
8397         * linux-fork.c (linux_fork_mourn_inferior)
8398         (detach_checkpoint_command, info_checkpoints_command)
8399         (linux_fork_context): Update.
8400         (linux_fork_detach): Update.
8401         (class scoped_switch_fork_info): Update.
8402         (delete_checkpoint_command): Update.
8403         * infrun.c (follow_fork_inferior): Update.
8404         (follow_fork_inferior): Update.
8405         (proceed_after_vfork_done): Update.
8406         (handle_vfork_child_exec_or_exit): Update.
8407         (follow_exec): Update.
8408         (displaced_step_prepare_throw): Update.
8409         (displaced_step_restore): Update.
8410         (start_step_over): Update.
8411         (resume_1): Update.
8412         (clear_proceed_status_thread): Update.
8413         (proceed): Update.
8414         (print_target_wait_results): Update.
8415         (do_target_wait): Update.
8416         (context_switch): Update.
8417         (stop_all_threads): Update.
8418         (restart_threads): Update.
8419         (finish_step_over): Update.
8420         (handle_signal_stop): Update.
8421         (switch_back_to_stepped_thread): Update.
8422         (keep_going_pass_signal): Update.
8423         (print_exited_reason): Update.
8424         (normal_stop): Update.
8425         * inferior.c (inferior_pid_to_str): Change return type.
8426         (print_selected_inferior): Update.
8427         (add_inferior): Update.
8428         (detach_inferior): Update.
8429         * dummy-frame.c (fprint_dummy_frames): Update.
8430         * dcache.c (dcache_info_1): Update.
8431         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8432         (btrace_fetch, btrace_clear): Update.
8433         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8434         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8435         type.
8436         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8437         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8438         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8439         * gdbarch.c, gdbarch.h: Rebuild.
8440         * gdbarch.sh (core_pid_to_str): Change return type.
8441         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8442         return type.
8443         (windows_nat_target::pid_to_str): Change return type.
8444         (windows_delete_thread): Update.
8445         (windows_nat_target::attach): Update.
8446         (windows_nat_target::files_info): Update.
8447         * target-delegates.c: Rebuild.
8448         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8449         return type.
8450         (sol_thread_target::pid_to_str): Change return type.
8451         * remote.c (class remote_target) <pid_to_str>: Change return
8452         type.
8453         (remote_target::pid_to_str): Change return type.
8454         (extended_remote_target::attach, remote_target::remote_stop_ns)
8455         (remote_target::remote_notif_remove_queued_reply)
8456         (remote_target::push_stop_reply, remote_target::disable_btrace):
8457         Update.
8458         (extended_remote_target::attach): Update.
8459         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8460         type.
8461         (gdbsim_target::pid_to_str): Change return type.
8462         * ravenscar-thread.c (struct ravenscar_thread_target)
8463         <pid_to_str>: Change return type.
8464         (ravenscar_thread_target::pid_to_str): Change return type.
8465         * procfs.c (class procfs_target) <pid_to_str>: Change return
8466         type.
8467         (procfs_target::pid_to_str): Change return type.
8468         (procfs_target::attach): Update.
8469         (procfs_target::detach): Update.
8470         (procfs_target::fetch_registers): Update.
8471         (procfs_target::store_registers): Update.
8472         (procfs_target::wait): Update.
8473         (procfs_target::files_info): Update.
8474         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8475         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8476         return type.
8477         (nto_procfs_target::pid_to_str): Change return type.
8478         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8479         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8480         return type.
8481         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8482         (exit_lwp): Update.
8483         (attach_proc_task_lwp_callback, get_detach_signal)
8484         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8485         (linux_nat_target::resume, wait_lwp, stop_callback)
8486         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8487         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8488         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8489         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8490         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8491         type.
8492         (inf_ptrace_target::attach): Update.
8493         (inf_ptrace_target::files_info): Update.
8494         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8495         type.
8496         (go32_nat_target::pid_to_str): Change return type.
8497         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8498         (gnu_nat_target::wait): Update.
8499         (gnu_nat_target::wait): Update.
8500         (gnu_nat_target::resume): Update.
8501         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8502         (fbsd_nat_target::wait): Update.
8503         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8504         type.
8505         (darwin_nat_target::attach): Update.
8506         * corelow.c (class core_target) <pid_to_str>: Change return type.
8507         (core_target::pid_to_str): Change return type.
8508         * target.c (normal_pid_to_str): Change return type.
8509         (default_pid_to_str): Likewise.
8510         (target_pid_to_str): Change return type.
8511         (target_translate_tls_address): Update.
8512         (target_announce_detach): Update.
8513         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8514         return type.
8515         (bsd_uthread_target::pid_to_str): Change return type.
8516         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8517         type.
8518         (bsd_kvm_target::pid_to_str): Change return type.
8519         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8520         return type.
8521         (aix_thread_target::pid_to_str): Change return type.
8522         * target.h (struct target_ops) <pid_to_str>: Change return type.
8523         (target_pid_to_str, normal_pid_to_str): Likewise.
8524         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8525         type.
8526         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8527         type.
8528         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8529         return type.
8530         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8531         type.
8532         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8533         type.
8534         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8535         return type.
8536
8537 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8538
8539         * NEWS: Mention that the new default MI version is 3.  Mention
8540         changes to the output of commands and events that deal with
8541         multi-location breakpoints.
8542         * breakpoint.c: Include "mi/mi-out.h".
8543         (print_one_breakpoint): Change output syntax if using MI version
8544         >= 3.
8545         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8546         New.
8547         (mi_multi_location_breakpoint_output_fixed): New.
8548         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8549         (mi_cmd_fix_multi_location_breakpoint_output): New.
8550         (mi_multi_location_breakpoint_output_fixed): New.
8551         * mi/mi-cmds.c (mi_cmds): Register command
8552         -fix-multi-location-breakpoint-output.
8553         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8554         interpreter "mi".
8555
8556 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8557
8558         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8559         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8560         instantiate mi_ui_out based on interpreter name.
8561         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8562         * mi/mi-main.c (mi_load_progress): Likewise.
8563
8564 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8565
8566         * NEWS: Combine separate "New targets" sections for 8.3.
8567
8568 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8569
8570         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8571         (ppcfbsd_init_abi): Install gdbarch
8572         "fetch_tls_load_module_address" and "get_thread_local_address"
8573         methods.
8574
8575 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8576
8577         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8578         (riscv_fbsd_init_abi): Install gdbarch
8579         "fetch_tls_load_module_address" and "get_thread_local_address"
8580         methods.
8581
8582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8583
8584         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8585         (i386fbsd_init_abi): Install gdbarch
8586         "fetch_tls_load_module_address" and "get_thread_local_address"
8587         methods.
8588
8589 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8590
8591         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8592         (amd64fbsd_init_abi): Install gdbarch
8593         "fetch_tls_load_module_address" and "get_thread_local_address"
8594         methods.
8595
8596 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8597
8598         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8599         (struct fbsd_pspace_data): New type.
8600         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8601         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8602         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8603         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8604         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8605
8606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8607
8608         * gdbtypes.c (lookup_struct_elt): New function.
8609         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8610         * gdbtypes.h (struct struct_elt): New type.
8611         (lookup_struct_elt): New prototype.
8612
8613 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8614
8615         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8616         remove disabled code block.
8617
8618 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8619
8620         * gdbarch.sh (get_thread_local_address): New method.
8621         * gdbarch.h, gdbarch.c: Regenerate.
8622         * target.c (target_translate_tls_address): Use
8623         gdbarch_get_thread_local_address if present instead of
8624         target::get_thread_local_address.
8625
8626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8627
8628         * target.h (target::get_thread_local_address): Update comment.
8629
8630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8631
8632         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8633         objfile->separate_debug_objfile_backlink if not NULL.
8634
8635 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8636
8637         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8638         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8639         (amd64bsd_store_inferior_registers): Likewise.
8640         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8641         Enable segment base registers.
8642         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8643         PT_GETFSBASE and PT_GETGSBASE.
8644         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8645         PT_SETGSBASE.
8646         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8647         segment base registers.
8648         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8649
8650 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8651
8652         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8653         Update calls to i386_target_description to add 'segments'
8654         parameter.
8655         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8656         add segment base registers.
8657         * arch/i386.c (i386_create_target_description): Add 'segments'
8658         parameter to enable segment base registers.
8659         * arch/i386.h (i386_create_target_description): Likewise.
8660         * features/i386/32bit-segments.xml: New file.
8661         * features/i386/32bit-segments.c: Generate.
8662         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8663         call to i386_target_description to add 'segments' parameter.
8664         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8665         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8666         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8667         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8668         if feature is present.
8669         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8670         Add 'segments' parameter to call to i386_target_description.
8671         (i386_target_description): Add 'segments' parameter to enable
8672         segment base registers.
8673         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8674         to call to i386_target_description.
8675         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8676         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8677         Define I386_NUM_REGS.
8678         (i386_target_description): Add 'segments' parameter to enable
8679         segment base registers.
8680
8681 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8682
8683         PR/24325
8684         * source-cache.c: #undef open and close, to avoid unresolved
8685         externals during linking.
8686
8687 2019-03-12  Tom Tromey  <tromey@adacore.com>
8688
8689         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8690         const.  Add initializers.
8691         (_initialize_remote): Don't initialize ptid globals.
8692
8693 2019-03-12  Pedro Alves  <palves@redhat.com>
8694
8695         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8696
8697 2019-03-12  Pedro Alves  <palves@redhat.com>
8698
8699         * cp-name-parser.y (main): Remove unused 'len' variable.
8700
8701 2019-03-12  Tom Tromey  <tromey@adacore.com>
8702
8703         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8704         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8705
8706 2019-03-12  Tom Tromey  <tromey@adacore.com>
8707
8708         * linux-nat.c (iterate_over_lwps): Update.
8709         (stop_callback): Remove parameter.
8710         (stop_wait_callback, detach_callback, resume_set_callback)
8711         (select_singlestep_lwp_callback, set_ignore_sigint)
8712         (status_callback, resumed_callback, resume_clear_callback)
8713         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8714         data parameter.
8715         (linux_nat_target::detach, linux_nat_target::resume)
8716         (linux_stop_and_wait_all_lwps, select_event_lwp)
8717         (linux_nat_filter_event, linux_nat_wait_1)
8718         (linux_nat_target::kill, linux_nat_target::stop)
8719         (linux_nat_target::stop): Update.
8720         (linux_nat_resume_callback): Change type.
8721         (resume_stopped_resumed_lwps, count_events_callback)
8722         (select_event_lwp_callback): Likewise.
8723         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8724         * arm-linux-nat.c (struct update_registers_data): Remove.
8725         (update_registers_callback): Change type.
8726         (arm_linux_insert_hw_breakpoint1): Update.
8727         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8728         parameter.
8729         (x86_linux_dr_set_addr): Update.
8730         (x86_linux_dr_set_control): Update.
8731         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8732         (iterate_over_lwps): Use gdb::function_view.
8733         * nat/aarch64-linux-hw-point.c (struct
8734         aarch64_dr_update_callback_param): Remove.
8735         (debug_reg_change_callback): Change type.
8736         (aarch64_notify_debug_reg_change): Update.
8737         * s390-linux-nat.c (s390_refresh_per_info): Update.
8738
8739 2019-03-11  Tom Tromey  <tromey@adacore.com>
8740
8741         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8742         redundant assignment to "this_cu".
8743
8744 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8745
8746         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8747
8748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8749
8750         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8751         from...
8752         (rank_one_type): ... this.
8753
8754 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8755
8756         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8757         from...
8758         (rank_one_type): ... this.
8759
8760 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8761
8762         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8763         from...
8764         (rank_one_type): ... this.
8765
8766 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8767
8768         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8769         from...
8770         (rank_one_type): ... this.
8771
8772 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8773
8774         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8775         from...
8776         (rank_one_type): ... this.
8777
8778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8779
8780         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8781         from...
8782         (rank_one_type): ... this.
8783
8784 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8785
8786         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8787         from...
8788         (rank_one_type): ... this.
8789
8790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8791
8792         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8793         from...
8794         (rank_one_type): ... this.
8795
8796 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8797
8798         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8799         from...
8800         (rank_one_type): ... this.
8801
8802 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8803
8804         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8805         from...
8806         (rank_one_type): ... this.
8807
8808 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8809
8810         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8811         from...
8812         (rank_one_type): ... this.
8813
8814 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8815
8816         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8817         from...
8818         (rank_one_type): ... this.
8819
8820 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8821
8822         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8823         inferior-events' shows the example events.
8824
8825 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8826
8827         Support styling on native MS-Windows console
8828
8829         PR/24315
8830         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8831         on MS-Windows if $TERM is not defined.
8832
8833         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8834
8835         * posix-hdep.c (gdb_console_fputs):
8836         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8837         functions.
8838         * ui-file.h (gdb_console_fputs): Add prototype.
8839
8840         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8841         back to fputs only if the former returns zero.
8842
8843 2019-03-07  Tom Tromey  <tom@tromey.com>
8844
8845         * symmisc.c (print_symbol_bcache_statistics): Update.
8846         (print_objfile_statistics): Update.
8847         * symfile.c (allocate_symtab): Update.
8848         * stabsread.c: Don't include bcache.h.
8849         * psymtab.h (struct psymbol_bcache): Don't declare.
8850         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8851         (psymbol_bcache_init, psymbol_bcache_free)
8852         (psymbol_bcache_get_bcache): Don't declare.
8853         * psymtab.c (struct psymbol_bcache): Remove.
8854         (psymtab_storage::psymtab_storage): Update.
8855         (psymtab_storage::~psymtab_storage): Update.
8856         (psymbol_bcache_init, psymbol_bcache_free)
8857         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8858         (add_psymbol_to_bcache): Update.
8859         (allocate_psymtab): Update.
8860         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8861         macro_cache>: No longer pointers.
8862         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8863         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8864         * macrotab.c (macro_bcache): Update.
8865         * macroexp.c: Don't include bcache.h.
8866         * gdbtypes.c (check_types_worklist): Update.
8867         (types_deeply_equal): Remove TRY/CATCH.  Update.
8868         * elfread.c (elf_symtab_read): Update.
8869         * dwarf2read.c: Don't include bcache.h.
8870         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8871         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8872         (print_bcache_statistics, bcache_memory_used): Don't declare.
8873         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8874         methods.  Rename all data members.
8875         * bcache.c (struct bcache): Move to bcache.h.
8876         (bcache::expand_hash_table): Rename from expand_hash_table.
8877         (bcache): Remove.
8878         (bcache::insert): Rename from bcache_full.
8879         (bcache::compare): Rename from bcache_compare.
8880         (bcache_xmalloc): Remove.
8881         (bcache::~bcache): Rename from bcache_xfree.
8882         (bcache::print_statistics): Rename from print_bcache_statistics.
8883         (bcache::memory_used): Rename from bcache_memory_used.
8884
8885 2019-03-07  Pedro Alves  <palves@redhat.com>
8886
8887         * infrun.c (normal_stop): Also check for
8888         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8889
8890 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8891
8892         * f-lang.c (value_from_host_double): Moved to...
8893         * value.c (value_from_host_double): ...here.
8894         * value.h (value_from_host_double): Declare.
8895         * guile/scm-math.c (vlscm_convert_typed_number): Use
8896         value_from_host_double.
8897         (vlscm_convert_number): Likewise.
8898         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8899         * python/py-value.c (convert_value_from_python): Likewise.
8900
8901 2019-03-06  Tom Tromey  <tom@tromey.com>
8902
8903         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8904
8905 2019-03-06  Tom Tromey  <tom@tromey.com>
8906
8907         * utils.h (free_current_contents): Don't declare.
8908         * utils.c (free_current_contents): Remove.
8909
8910 2019-03-06  Tom Tromey  <tom@tromey.com>
8911
8912         * top.c (quit_force): Update.
8913         * main.c (captured_command_loop): Update.
8914         * common/new-op.c (operator new): Update.
8915         * common/common-exceptions.c (struct catcher)
8916         <save_cleanup_chain>: Remove member.
8917         (exceptions_state_mc_init): Update.
8918         (exception_try_scope_entry): Return nullptr.
8919         (exception_try_scope_exit, exception_rethrow)
8920         (throw_exception_sjlj, throw_exception_cxx): Update.
8921         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8922         (all_cleanups, do_cleanups, discard_cleanups)
8923         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8924         (restore_cleanups, restore_final_cleanups): Don't declare.
8925         (do_final_cleanups): Remove parameter.
8926         * common/cleanups.c (cleanup_chain, make_cleanup)
8927         (make_cleanup_dtor, all_cleanups, do_cleanups)
8928         (discard_my_cleanups, discard_cleanups)
8929         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8930         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8931         (null_cleanup): Remove.
8932         (do_final_cleanups): Remove parameter.
8933
8934 2019-03-06  Tom Tromey  <tom@tromey.com>
8935
8936         * remote.c (remote_target::remote_parse_stop_reply): Use
8937         unique_xmalloc_ptr.
8938
8939 2019-03-06  Tom Tromey  <tom@tromey.com>
8940
8941         * stabsread.c (struct stabs_field_info): Rename from field_info.
8942         <list, fnlist>: Add initializers.
8943         <obstack>: New member.
8944         (read_member_functions, read_struct_fields, read_baseclasses):
8945         Allocate on obstack.  Don't use cleanups.
8946         (read_one_struct_field, read_member_functions, read_struct_fields)
8947         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8948         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8949         (read_struct_type): Update.
8950
8951 2019-03-06  Tom Tromey  <tom@tromey.com>
8952
8953         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8954         * common/filestuff.h (make_cleanup_close): Don't declare.
8955         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8956         Remove.
8957
8958 2019-03-06  Tom Tromey  <tom@tromey.com>
8959
8960         * solib-aix.c: Use make_scope_exit.
8961
8962 2019-03-06  Tom Tromey  <tom@tromey.com>
8963
8964         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8965         Use make_scope_exit.
8966
8967 2019-03-06  Tom Tromey  <tom@tromey.com>
8968
8969         * solib-svr4.c (disable_probes_interface): Remove parameter.
8970         (svr4_handle_solib_event): Use make_scope_exit.
8971
8972 2019-03-06  Tom Tromey  <tom@tromey.com>
8973
8974         * remote.c (struct stop_reply_deleter): Remove.
8975         (stop_reply_up): Update.
8976         (struct stop_reply): Derive from notif_event.  Don't typedef.
8977         <regcache>: Now a std::vector.
8978         (stop_reply_xfree): Remove.
8979         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8980         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8981         (remote_target::discard_pending_stop_replies): Use delete.
8982         (remote_target::remote_parse_stop_reply): Update.
8983         (remote_target::process_stop_reply): Update.
8984         * remote-notif.h (struct notif_event): Add virtual destructor.
8985         Remove "dtr" member.
8986         (struct notif_client) <alloc_event>: Return a unique_ptr.
8987         (notif_event_xfree): Don't declare.
8988         (notif_event_up): New typedef.
8989         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8990         (notif_event_xfree, do_notif_event_xfree): Remove.
8991         (remote_notif_state_xfree): Update.
8992
8993 2019-03-06  Tom Tromey  <tom@tromey.com>
8994
8995         * infrun.c (displaced_step_clear_cleanup): Now a
8996         forward_scope_exit type.
8997         (displaced_step_prepare_throw): Update.
8998         (displaced_step_fixup): Update.
8999
9000 2019-03-06  Tom Tromey  <tom@tromey.com>
9001
9002         * inferior.h (class inferior): Update comment.
9003         * gdbthread.h (class thread_info): Update comment.
9004
9005 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9006             Tom Tromey  <tom@tromey.com>
9007
9008         * stabsread.h (struct stab_section_list): Remove.
9009         (coffstab_build_psymtabs): Update.
9010         * dbxread.c (symbuf_sections): Now a std::vector.
9011         (sect_idx): New global.
9012         (fill_symbuf): Update.
9013         (coffstab_build_psymtabs): Change type of stabsects parameter.
9014         Update.
9015         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9016         std::vector.
9017         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9018         (coff_locate_sections): Update.
9019         (coff_symfile_read): Remove cleanups.  Update.
9020         (init_stringtab): Add storage parameter.
9021         (free_stringtab, free_stringtab_cleanup): Remove.
9022         (init_lineno): Add storage parameter.
9023         (free_linetab, free_linetab_cleanup): Remove.
9024
9025 2019-03-06  Pedro Alves  <palves@redhat.com>
9026
9027         * linux-fork.c (fork_info::clobber_regs): Delete.
9028         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9029         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9030         comment.  Adjust.
9031         (scoped_switch_fork_info::scoped_switch_fork_info)
9032         (checkpoint_command, linux_fork_context): Adjust
9033         fork_save_infrun_state calls.
9034
9035 2019-03-06  Pedro Alves  <palves@redhat.com>
9036
9037         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9038         (inf_has_multiple_threads): Return 'bool' and rewrite using
9039         inferior_info::threads().
9040
9041 2019-03-06  Pedro Alves  <palves@redhat.com>
9042
9043         * linux-fork.c: Include <list>.
9044         (fork_list): Now a std::list instance.
9045         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9046         (forks_exist_p, find_last_fork): Adjust.
9047         (new_fork): Delete.
9048         (one_fork_p): New.
9049         (add_fork): Adjust.
9050         (free_fork): Delete, folded into fork_info::~fork_info().
9051         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9052         Adjust.
9053         (init_fork_list): Delete.
9054         (linux_fork_killall, linux_fork_mourn_inferior)
9055         (linux_fork_detach, info_checkpoints_command): Adjust.
9056         (_initialize_linux_fork): No longer call init_fork_list.
9057
9058 2019-03-06  Pedro Alves  <palves@redhat.com>
9059
9060         * linux-fork.c (new_fork): New, split out of ...
9061         (add_fork): ... this.  Return void.  Move "first fork" special
9062         case from here, to ...
9063         (checkpoint_command): ... here.
9064         * linux-linux.h (add_fork): Return void.
9065
9066 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9067
9068         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9069
9070 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9071             Chris January  <chris.january@arm.com>
9072             David Lecomber  <david.lecomber@arm.com>
9073
9074         * f-exp.y: New token, UNOP_INTRINSIC.
9075         (exp): New pattern using UNOP_INTRINSIC token.
9076         (f77_keywords): Add 'abs' keyword.
9077         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9078         (value_from_host_double): New function.
9079         (evaluate_subexp_f): Support UNOP_ABS.
9080
9081 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9082
9083         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9084         types.
9085
9086 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9087
9088         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9089         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9090         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9091
9092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9093
9094         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9095
9096 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9097             Chris January  <chris.january@arm.com>
9098
9099         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9100         * f-exp.y: Define 'KIND' token.
9101         (exp): New pattern for KIND expressions.
9102         (ptype): Handle types with a kind extension.
9103         (direct_abs_decl): Extend to spot kind extensions.
9104         (f77_keywords): Add 'kind' to the list.
9105         (push_kind_type): New function.
9106         (convert_to_kind_type): New function.
9107         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9108         * parse.c (operator_length_standard): Likewise.
9109         * parser-defs.h (enum type_pieces): Add tp_kind.
9110         * std-operator.def: Add UNOP_KIND.
9111
9112 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9113
9114         * f-exp.y (f_parse): Set yydebug.
9115
9116 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9117
9118         * f-lang.c (evaluate_subexp_f): New function.
9119         (exp_descriptor_f): New global.
9120         (f_language_defn): Use exp_descriptor_f instead of
9121         exp_descriptor_standard.
9122
9123 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * f-exp.y (struct token): Add comments.
9126         (dot_ops): Remove uppercase versions and the end marker.
9127         (f77_keywords): Likewise.
9128         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9129         entries in the dot_ops array are case insensitive, and use
9130         strncasecmp to compare strings.  Also some whitespace cleanup in
9131         this area.  Similar for the f77_keywords array, except entries in
9132         this list might be case sensitive.
9133
9134 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9135
9136         * f-exp.y (struct f77_boolean_val): Add comments.
9137         (boolean_values): Remove uppercase versions, and end marker.
9138         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9139         and use strncasecmp to achieve case insensitivity.  Additionally,
9140         perform whitespace cleanup around this code.
9141
9142 2019-03-06  Tom Tromey  <tromey@adacore.com>
9143
9144         * remote-sim.c (gdbsim_target_open): Use result of
9145         gdb_argv::release.
9146
9147 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9148         Dirk Schubert  <dirk.schubert@arm.com>
9149         Chris January  <chris.january@arm.com>
9150
9151         * eval.c (evaluate_subexp_standard): Call Fortran argument
9152         wrapping logic.
9153         * f-lang.c (struct value): A value which can be passed into a
9154         Fortran function call.
9155         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9156         where appropriate.
9157         (struct type): Value ready for a Fortran function call.
9158         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9159         is needed.
9160         * f-lang.h (fortran_argument_convert): Declaration.
9161         (fortran_preserve_arg_pointer): Declaration.
9162         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9163
9164 2019-03-05  Tom Tromey  <tromey@adacore.com>
9165
9166         * python/py-prettyprint.c (print_string_repr): Remove #if.
9167         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9168
9169 2019-03-05  Tom Tromey  <tromey@adacore.com>
9170
9171         * target.c (the_dummy_target): Move later.  Change type to
9172         "dummy_target".
9173         (initialize_targets): Don't initialize the_dummy_target.
9174
9175 2019-03-05  Tom Tromey  <tromey@adacore.com>
9176
9177         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9178         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9179
9180 2019-03-05  Tom Tromey  <tromey@adacore.com>
9181
9182         * windows-nat.c (windows_nat_target::attach)
9183         (windows_nat_target::detach): Don't call gdb_flush.
9184         * valprint.c (generic_val_print, val_print, val_print_string):
9185         Don't call gdb_flush.
9186         * utils.c (defaulted_query): Don't call gdb_flush.
9187         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9188         * target.c (target_announce_detach): Don't call gdb_flush.
9189         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9190         * remote.c (extended_remote_target::attach): Don't call
9191         gdb_flush.
9192         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9193         * printcmd.c (do_examine): Don't call gdb_flush.
9194         (info_display_command): Don't call gdb_flush.
9195         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9196         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9197         * memattr.c (info_mem_command): Don't call gdb_flush.
9198         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9199         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9200         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9201         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9202         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9203         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9204         (gnu_nat_target::detach): Don't call gdb_flush.
9205         * f-valprint.c (f_val_print): Don't call gdb_flush.
9206         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9207         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9208         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9209         gdb_flush.
9210         * c-valprint.c (c_val_print): Don't call gdb_flush.
9211         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9212
9213 2019-03-05  Tom Tromey  <tromey@adacore.com>
9214
9215         * varobj.c (update_dynamic_varobj_children): Update.
9216         (install_default_visualizer): Use reset, not release.
9217         * value.c (set_internalvar): Update.
9218         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9219         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9220         ATTRIBUTE_UNUSED_RESULT.
9221
9222 2019-03-05  Tom Tromey  <tromey@adacore.com>
9223
9224         * remote.c (class scoped_remote_fd) <release>: Add
9225         ATTRIBUTE_UNUSED_RESULT.
9226
9227 2019-03-05  Tom Tromey  <tromey@adacore.com>
9228
9229         * macroexp.c (struct macro_buffer) <release>: Add
9230         ATTRIBUTE_UNUSED_RESULT.
9231
9232 2019-03-05  Tom Tromey  <tromey@adacore.com>
9233
9234         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9235         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9236         ATTRIBUTE_UNUSED_RESULT.
9237
9238 2019-03-05  Tom Tromey  <tromey@adacore.com>
9239
9240         * common/scoped_fd.h (class scoped_fd) <release>: Add
9241         ATTRIBUTE_UNUSED_RESULT.
9242
9243 2019-03-05  Tom Tromey  <tromey@adacore.com>
9244
9245         * parser-defs.h (struct parser_state) <release>: Add
9246         ATTRIBUTE_UNUSED_RESULT.
9247
9248 2019-03-05  Tom Tromey  <tromey@adacore.com>
9249
9250         * utils.h (class gdb_argv) <release>: Add
9251         ATTRIBUTE_UNUSED_RESULT.
9252         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9253
9254 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9255
9256         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9257         for-loop range, to avoid compiler warnings.
9258
9259         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9260         avoid compiler warnings about unused variables.
9261
9262         * NEWS: Mention end of support for native debugging on MS-Windows
9263         before XP.
9264
9265         PR gdb/24292
9266         * common/netstuff.c:
9267         * gdbserver/gdbreplay.c
9268         * gdbserver/remote-utils.c:
9269         * ser-tcp.c:
9270         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9271         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9272         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9273         'getaddrinfo' and 'freeaddrinfo' were not available before
9274         Windows XP, and mingw.org's MinGW headers by default define
9275         _WIN32_WINNT to 0x500.
9276
9277 2019-03-01  Gary Benson <gbenson@redhat.com>
9278
9279         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9280
9281 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9282             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9283
9284         PR gdb/8527
9285         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9286         set_sigint_trap, clear_sigint_trap.
9287
9288 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9289
9290         * target.c (target_detach): Clear the regcache and the
9291         frame cache.
9292
9293 2019-02-27  Pedro Alves  <palves@redhat.com>
9294
9295         * utils.c (set_screen_size): When we cap the height/width sizes,
9296         tweak the corresponding command variable to show "unlimited":
9297
9298 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9299             Pedro Alves  <palves@redhat.com>
9300
9301         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9302         before calling rl_set_screen_size.
9303
9304 2019-02-27  Tom Tromey  <tromey@adacore.com>
9305
9306         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9307         define.
9308         * python/py-value.c: Remove Python 2.4 workaround.
9309         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9310         workaround.
9311         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9312         Python 2.4 workaround.
9313         * python/python-internal.h: Remove Python 2.4 comment.
9314         (Py_ssize_t): Don't define.
9315         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9316         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9317         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9318         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9319         * python/python.c (do_start_initialization): Remove Python 2.4
9320         workaround.
9321         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9322         (print_children): Remove Python 2.4 workaround.
9323         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9324         workaround.
9325         (CHARBUFFERPROC_NAME): Remove.
9326         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9327         Python 2.4 workaround.
9328
9329 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9330
9331         * NEWS: Note minimum Python version.
9332
9333 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9334
9335         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9336         code from these functions.  Remove corresponding ifdefs.  Use
9337         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9338         Remove gotos and target of gotos.
9339         (infpy_search_memory): Likewise.
9340
9341 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9342
9343         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9344         (hppa_gdbarch_init): Don't register deleted functions with
9345         gdbarch.
9346
9347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9348
9349         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9350         (h8300_unwind_sp): Delete.
9351         (h8300_dummy_id): Delete.
9352         (h8300_gdbarch_init): Don't register deleted functions with
9353         gdbarch.
9354
9355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9358         (ft32_unwind_pc): Delete.
9359         (ft32_unwind_sp): Delete.
9360         (ft32_gdbarch_init): Don't register deleted functions with
9361         gdbarch.
9362
9363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9364
9365         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9366         (frv_unwind_pc): Delete.
9367         (frv_unwind_sp): Delete.
9368         (frv_gdbarch_init): Don't register deleted functions with
9369         gdbarch.
9370
9371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9372
9373         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9374         (riscv_unwind_pc): Delete.
9375         (riscv_unwind_sp): Delete.
9376         (riscv_gdbarch_init): Don't register deleted functions with
9377         gdbarch.
9378
9379 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9380
9381         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9382         (csky_unwind_pc): Delete.
9383         (csky_unwind_sp): Delete.
9384         (csky_gdbarch_init): Don't register deleted functions with
9385         gdbarch.
9386
9387 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9388
9389         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9390         (cris_unwind_pc): Delete.
9391         (cris_unwind_sp): Delete.
9392         (cris_gdbarch_init): Don't register deleted functions with
9393         gdbarch.
9394
9395 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9396
9397         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9398         (bfin_unwind_pc): Delete.
9399         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9400
9401 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9402
9403         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9404         (arm_unwind_pc): Delete.
9405         (arm_unwind_sp): Delete.
9406         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9407
9408 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9409
9410         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9411         (arc_unwind_pc): Delete.
9412         (arc_unwind_sp): Delete.
9413         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9414
9415 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9416
9417         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9418         (alpha_unwind_pc): Delete.
9419         (alpha_gdbarch_init): Don't register deleted functions with
9420         gdbarch.
9421
9422 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9423
9424         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9425         (aarch64_unwind_pc): Delete.
9426         (aarch64_unwind_sp): Delete.
9427         (aarch64_gdbarch_init): Don't register deleted functions with
9428         gdbarch.
9429
9430 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9431
9432         * gdbtypes.c (type_align): Don't consider static members when
9433         computing structure alignment.
9434
9435 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9436
9437         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9438         return 0 for other types.
9439         * arch-utils.c (default_type_align): Always return 0.
9440         * gdbarch.h: Regenerate.
9441         * gdbarch.sh (type_align): Extend comment.
9442         * gdbtypes.c (type_align): Add additional comments, always call
9443         gdbarch_type_align before applying the default rules.
9444         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9445         generic code will then apply a suitable default.
9446         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9447         types, return 0 for other types.
9448
9449 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9450
9451         * NEWS: Create a new section for the next release branch.
9452         Rename the section of the current branch, now that it has
9453         been cut.
9454
9455 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9456
9457         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9458         * version.in: Bump version to 8.3.50.DATE-git.
9459
9460 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9461
9462         * aix-thread.c (ptid_cmp): Remove unused variable.
9463         (get_signaled_thread): Likewise.
9464         (store_regs_user_thread): Likewise.
9465         (store_regs_kernel_thread): Likewise.
9466         (fetch_regs_kernel_thread): Remove shadowed variable.
9467
9468 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9469
9470         * features/riscv/32bit-cpu.xml: Add register numbers.
9471         * features/riscv/32bit-fpu.c: Regenerate.
9472         * features/riscv/32bit-fpu.xml: Add register numbers.
9473         * features/riscv/64bit-cpu.xml: Add register numbers.
9474         * features/riscv/64bit-fpu.c: Regenerate.
9475         * features/riscv/64bit-fpu.xml: Add register numbers.
9476
9477 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9478
9479         * NEWS: Mention two argument form of gdb.Value constructor.
9480         * python/py-value.c (convert_buffer_and_type_to_value): New
9481         function.
9482         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9483         Add support for handling an optional second argument.  Call
9484         convert_buffer_and_type_to_value as appropriate.
9485         * python/python-internal.h (Py_buffer_deleter): New struct.
9486         (Py_buffer_up): New typedef.
9487
9488 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9489
9490         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9491         instead of releasing ownership.
9492
9493 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9494
9495         * dwarf2read.c (open_and_init_dwp_file): Call
9496         elf_numsections instead of bfd_count_sections to initialize
9497         dwp_file->num_sections.
9498
9499 2019-02-25  Tom Tromey  <tromey@adacore.com>
9500
9501         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9502
9503 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9504
9505         * gcore.in: Add '--readnever' option when invoking GDB.
9506
9507 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9508
9509         * MAINTAINERS: Update my email address.
9510
9511 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9512
9513         * build-id.c (build_id_to_debug_bfd_1): New function.
9514         (build_id_to_debug_bfd): Look for separate debug file in
9515         sysroot.
9516
9517 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9518
9519         * gdbarch.sh: Update the copyright year range that is placed into
9520         generated files.
9521
9522 2019-02-22  Keith Seitz  <keiths@redhat.com>
9523
9524         PR symtab/23853
9525         * linespec.c (create_sals_line_offset): Search for the default
9526         symtab's filename instead of its fullname.
9527
9528 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9529
9530         * NEWS: Update style defaults.
9531
9532 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9533
9534         * main.c (captured_main_1): Disable styling in batch mode.
9535
9536 2019-02-20  Tom Tromey  <tom@tromey.com>
9537
9538         * symtab.c (symtab_symbol_info): Fix typos.
9539
9540 2019-02-20  Tom Tromey  <tromey@adacore.com>
9541
9542         * findcmd.c (_initialize_mem_search): Use upper case for
9543         metasyntactic variables.
9544
9545 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9546
9547         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9548         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9549
9550 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9551
9552         * top.h (source_file_name): Change to std::string.
9553         * top.c (source_file_name): Likewise.
9554         (command_line_input): Adjust.
9555         * cli/cli-script.c (script_from_file): Adjust.
9556
9557 2019-02-19  Tom Tromey  <tromey@adacore.com>
9558
9559         * ravenscar-thread.c
9560         (ravenscar_thread_target::update_thread_list): Don't call
9561         ada_build_task_list.
9562         * ada-lang.h (ada_build_task_list): Don't declare.
9563         * ada-tasks.c (struct ada_tasks_inferior_data)
9564         <task_list_valid_p>: Now bool.
9565         (read_known_tasks, ada_task_list_changed)
9566         (ada_tasks_invalidate_inferior_data): Update.
9567         (read_known_tasks_array): Return bool.
9568         (read_known_tasks_list): Likewise.
9569         (read_known_tasks): Return void.
9570         (ada_build_task_list): Now static.
9571
9572 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9573
9574         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9575         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9576
9577 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9578
9579         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9580         variant for ada_tasks_pspace_data_handle and
9581         ada_tasks_inferior_data_handle.
9582         (ada_tasks_pspace_data_cleanup): New function.
9583         (ada_tasks_inferior_data_cleanup): New function.
9584
9585 2019-02-17  Tom Tromey  <tom@tromey.com>
9586
9587         * macrotab.h (macro_source_fullname): Return a std::string.
9588         * macrotab.c (macro_include, check_for_redefinition)
9589         (macro_undef, macro_lookup_definition, foreach_macro)
9590         (foreach_macro_in_scope): Update.
9591         (macro_source_fullname): Return a std::string.
9592         * macrocmd.c (show_pp_source_pos): Update.
9593
9594 2019-02-17  Tom Tromey  <tom@tromey.com>
9595
9596         * macrocmd.c (show_pp_source_pos): Style the file names.
9597
9598 2019-02-17  Tom Tromey  <tom@tromey.com>
9599
9600         PR tui/24197:
9601         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9602
9603 2019-02-17  Tom Tromey  <tom@tromey.com>
9604
9605         * ada-lang.c (user_select_syms): Use filtered printing.
9606         * utils.c (wrap_style): New global.
9607         (desired_style): Remove.
9608         (emit_style_escape): Add stream parameter.
9609         (set_output_style, reset_terminal_style, prompt_for_continue):
9610         Update.
9611         (flush_wrap_buffer): Only flush gdb_stdout.
9612         (wrap_here): Set wrap_style.
9613         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9614         treat escape sequences as a character.  Change when wrap buffer is
9615         flushed.
9616         (fputs_styled): Do not set the output style when the default is
9617         requested.
9618         * ui-style.h (struct ui_file_style) <is_default>: New method.
9619         * source.c (print_source_lines_base): Emit escape sequences in one
9620         piece.
9621
9622 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9623
9624         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9625         integers and enumeration types.
9626
9627 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9628
9629         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9630         instead of lookup_symbol_in_language
9631         (do_exact_match): New function.
9632         (ada_get_symbol_name_matcher): Return do_exact_match when
9633         doing a verbatim match.
9634
9635 2019-02-15  Tom Tromey  <tromey@adacore.com>
9636
9637         * ravenscar-thread.c (ravenscar_thread_target::resume)
9638         (ravenscar_thread_target::wait): Special case wildcard requests.
9639
9640 2019-02-15  Tom Tromey  <tromey@adacore.com>
9641
9642         * ravenscar-thread.c (base_ptid): Remove.
9643         (struct ravenscar_thread_target) <close>: New method.
9644         <m_base_ptid>: New member.
9645         <update_inferior_ptid, active_task, task_is_currently_active,
9646         runtime_initialized>: Declare methods.
9647         <ravenscar_thread_target>: Add constructor.
9648         (ravenscar_thread_target::task_is_currently_active)
9649         (ravenscar_thread_target::update_inferior_ptid)
9650         (ravenscar_runtime_initialized): Rename.  Now methods.
9651         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9652         (ravenscar_thread_target::update_thread_list): Update.
9653         (ravenscar_thread_target::active_task): Now method.
9654         (ravenscar_thread_target::store_registers)
9655         (ravenscar_thread_target::prepare_to_store)
9656         (ravenscar_thread_target::prepare_to_store)
9657         (ravenscar_thread_target::mourn_inferior): Update.
9658         (ravenscar_inferior_created): Use "new" to create target.
9659         (ravenscar_thread_target::get_ada_task_ptid): Update.
9660         (_initialize_ravenscar): Don't initialize base_ptid.
9661         (ravenscar_ops): Remove global.
9662
9663 2019-02-15  Tom Tromey  <tromey@adacore.com>
9664
9665         * target.h (push_target): Declare new overload.
9666         * target.c (push_target): New overload, taking an rvalue reference.
9667         * remote.c (remote_target::open_1): Use push_target overload.
9668         * corelow.c (core_target_open): Use push_target overload.
9669
9670 2019-02-15  Tom Tromey  <tromey@adacore.com>
9671
9672         * ravenscar-thread.c (is_ravenscar_task)
9673         (ravenscar_task_is_currently_active): Return bool.
9674         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9675         (_initialize_ravenscar): Remove "(void)".
9676         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9677         Return bool.
9678
9679 2019-02-15  Tom Tromey  <tromey@adacore.com>
9680
9681         * ravenscar-thread.c (ravenscar_runtime_initializer)
9682         (has_ravenscar_runtime, get_running_thread_id)
9683         (ravenscar_thread_target::resume): Fix indentation.
9684
9685 2019-02-15  Tom Tromey  <tromey@adacore.com>
9686
9687         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9688         from ravenscar_arch_ops.
9689         (sparc_ravenscar_ops::fetch_registers)
9690         (sparc_ravenscar_ops::store_registers): Now methods.
9691         (sparc_ravenscar_prepare_to_store): Remove.
9692         (sparc_ravenscar_ops): Redefine.
9693         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9694         methods and destructor.  Remove members.
9695         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9696         (ravenscar_thread_target::store_registers)
9697         (ravenscar_thread_target::prepare_to_store): Update.
9698         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9699         Remove.
9700         (struct ppc_ravenscar_powerpc_ops): Derive from
9701         ravenscar_arch_ops.
9702         (ppc_ravenscar_powerpc_ops::fetch_registers)
9703         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9704         (ppc_ravenscar_powerpc_ops): Redefine.
9705         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9706         (ppc_ravenscar_e500_ops::fetch_registers)
9707         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9708         (ppc_ravenscar_e500_ops): Redefine.
9709         * aarch64-ravenscar-thread.c
9710         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9711         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9712         (aarch64_ravenscar_fetch_registers)
9713         (aarch64_ravenscar_store_registers): Now methods.
9714         (aarch64_ravenscar_ops): Redefine.
9715
9716 2019-02-15  Tom Tromey  <tromey@adacore.com>
9717
9718         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9719         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9720         (ravenscar_thread_target::stopped_by_watchpoint)
9721         (ravenscar_thread_target::stopped_data_address)
9722         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9723
9724 2019-02-15  Tom Tromey  <tromey@adacore.com>
9725
9726         * ravenscar-thread.c: Fix some typos.
9727
9728 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9729             Tom Tromey  <tromey@adacore.com>
9730
9731         * ada-lang.c (ada_exception_sal): Change addr_string to a
9732         std::string.
9733         (create_ada_exception_catchpoint): Update.
9734
9735 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9736             Tom Tromey  <tromey@adacore.com>
9737
9738         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9739         (bp_location_ops): Remove.
9740         (base_breakpoint_allocate_location): Update.
9741         (free_bp_location): Update.
9742         * ada-lang.c (class ada_catchpoint_location)
9743         <ada_catchpoint_location>: Remove ops parameter.
9744         (ada_catchpoint_location_dtor): Remove.
9745         (ada_catchpoint_location_ops): Remove.
9746         (allocate_location_exception): Update.
9747         * breakpoint.h (struct bp_location_ops): Remove.
9748         (class bp_location) <bp_location>: Remove bp_location_ops
9749         parameter.
9750         <~bp_location>: Add destructor.
9751         <ops>: Remove.
9752
9753 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9754             Pedro Alves  <palves@redhat.com>
9755
9756         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9757         'PATH_MAX'.
9758
9759 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9760             Samuel Thibault  <samuel.thibault@gnu.org>
9761             Thomas Schwinge  <thomas@codesourcery.com>
9762
9763         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9764         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9765
9766 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9767
9768         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9769         (check_empty): Use "const char *".
9770
9771         * gnu-nat.c (gnu_nat_target::detach): Instead of
9772         'detach_inferior (pid)' call
9773         'detach_inferior (find_inferior_pid (pid))'.
9774
9775         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9776         'nat/fork-inferior.o'.
9777         * gnu-nat.c: #include "nat/fork-inferior.h".
9778
9779         * gnu-nat.c (gnu_nat_target::detach): Instead of
9780         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9781         * gnu-nat.h: #include "inf-child.h".
9782         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9783         'i386_gnu_nat_target::fetch_registers'.
9784         (gnu_store_registers): Rename/move to
9785         'i386_gnu_nat_target::store_registers'.
9786
9787         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9788         * gnu-nat.h (mach_thread_info): New function.
9789         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9790
9791         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9792
9793 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9794
9795         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9796
9797 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9798
9799         * windows-nat.c (windows_add_thread): Add new parameter
9800         "main_thread_p" with default value set to false.  Update
9801         function documentation as well as all callers.
9802         (windows_delete_thread): Likewise.
9803         (fake_create_process): Update call to windows_add_thread.
9804         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9805         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9806         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9807         call to windows_delete_thread.
9808
9809 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9810
9811         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9812
9813 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9814
9815         * symfile.c (find_separate_debug_file): Use canonical path of
9816         sysroot with child_path instead of gdb_sysroot if it is valid.
9817
9818 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9819
9820         * symfile.c (find_separate_debug_file): Use child_path to
9821         determine if an object file is under a sysroot.
9822
9823 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9824
9825         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9826         unittests/child-path-selftests.c.
9827         * common/pathstuff.c (child_path): New function.
9828         * common/pathstuff.h (child_path): New prototype.
9829         * unittests/child-path-selftests.c: New file.
9830
9831 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9832
9833         * symfile.c (find_separate_debug_file): Look for separate debug
9834         files in debug directories under the sysroot.
9835
9836 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9837
9838         * symtab.h (struct minimal_symbol data_p): New const method.
9839         (struct minimal_symbol text_p): Likewise.
9840         * symtab.c (output_source_filename): Use file name style
9841         to print file name.
9842         (print_symbol_info): Likewise.
9843         (print_msymbol_info): Use address style to print addresses.
9844         Use function name style to print executable text symbols.
9845         (expand_symtab_containing_pc): Use data_p.
9846         (find_pc_sect_compunit_symtab): Likewise.
9847
9848 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9849
9850         * breakpoint.c (describe_other_breakpoints): Use address style
9851         to print addresses.
9852         (say_where): Likewise.
9853
9854 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9855
9856         * ada-typeprint.c (print_func_type): Print function name
9857         style to print function name.
9858         * c-typeprint.c (c_print_type_1): Likewise.
9859
9860 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9861
9862         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9863         for execve.
9864
9865 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9866
9867         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9868         type_stack.
9869
9870 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9871
9872         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9873         TYPE_CODE_REF types.
9874
9875 2019-02-08  Jim Wilson  <jimw@sifive.com>
9876
9877         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9878         (riscv_linux_fregset): New.
9879         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9880
9881 2019-02-07  Tom Tromey  <tom@tromey.com>
9882
9883         * thread.c (thread_cancel_execution_command): Update.
9884         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9885         methods.
9886         (struct thread_fsm_ops): Remove.
9887         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9888         (thread_fsm_should_stop, thread_fsm_return_value)
9889         (thread_fsm_set_finished, thread_fsm_finished_p)
9890         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9891         Don't declare.
9892         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9893         * infrun.c (clear_proceed_status_thread)
9894         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9895         (print_stop_event): Update.
9896         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9897         Add constructor.
9898         (step_command_fsm_ops): Remove.
9899         (new_step_command_fsm): Remove.
9900         (step_1): Update.
9901         (step_command_fsm::should_stop): Rename from
9902         step_command_fsm_should_stop.
9903         (step_command_fsm::clean_up): Rename from
9904         step_command_fsm_clean_up.
9905         (step_command_fsm::do_async_reply_reason): Rename from
9906         step_command_fsm_async_reply_reason.
9907         (struct until_next_fsm): Inherit from thread_fsm.  Add
9908         constructor.
9909         (until_next_fsm_ops): Remove.
9910         (new_until_next_fsm): Remove.
9911         (until_next_fsm::should_stop): Rename from
9912         until_next_fsm_should_stop.
9913         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9914         (until_next_fsm::do_async_reply_reason): Rename from
9915         until_next_fsm_async_reply_reason.
9916         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9917         constructor.  Change type of breakpoint.
9918         (finish_command_fsm_ops): Remove.
9919         (new_finish_command_fsm): Remove.
9920         (finish_command_fsm::should_stop): Rename from
9921         finish_command_fsm_should_stop.
9922         (finish_command_fsm::clean_up): Rename from
9923         finish_command_fsm_clean_up.
9924         (finish_command_fsm::return_value): Rename from
9925         finish_command_fsm_return_value.
9926         (finish_command_fsm::do_async_reply_reason): Rename from
9927         finish_command_fsm_async_reply_reason.
9928         (finish_command): Update.
9929         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9930         Add constructor.
9931         (call_thread_fsm_ops): Remove.
9932         (call_thread_fsm::call_thread_fsm): Rename from
9933         new_call_thread_fsm.
9934         (call_thread_fsm::should_stop): Rename from
9935         call_thread_fsm_should_stop.
9936         (call_thread_fsm::should_notify_stop): Rename from
9937         call_thread_fsm_should_notify_stop.
9938         (run_inferior_call, call_function_by_hand_dummy): Update.
9939         * cli/cli-interp.c (should_print_stop_to_console): Update.
9940         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9941         Add constructor.  Change type of location_breakpoint,
9942         caller_breakpoint.
9943         (until_break_fsm_ops): Remove.
9944         (new_until_break_fsm): Remove.
9945         (until_break_fsm::should_stop): Rename from
9946         until_break_fsm_should_stop.
9947         (until_break_fsm::clean_up): Rename from
9948         until_break_fsm_clean_up.
9949         (until_break_fsm::do_async_reply_reason): Rename from
9950         until_break_fsm_async_reply_reason.
9951         (until_break_command): Update.
9952         * thread-fsm.c: Remove.
9953         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9954
9955 2019-02-07  Tom Tromey  <tom@tromey.com>
9956
9957         * yy-remap.h: Add include guard.
9958         * xtensa-tdep.h: Add include guard.
9959         * xcoffread.h: Rename include guard.
9960         * varobj-iter.h: Add include guard.
9961         * tui/tui.h: Rename include guard.
9962         * tui/tui-winsource.h: Rename include guard.
9963         * tui/tui-wingeneral.h: Rename include guard.
9964         * tui/tui-windata.h: Rename include guard.
9965         * tui/tui-win.h: Rename include guard.
9966         * tui/tui-stack.h: Rename include guard.
9967         * tui/tui-source.h: Rename include guard.
9968         * tui/tui-regs.h: Rename include guard.
9969         * tui/tui-out.h: Rename include guard.
9970         * tui/tui-layout.h: Rename include guard.
9971         * tui/tui-io.h: Rename include guard.
9972         * tui/tui-hooks.h: Rename include guard.
9973         * tui/tui-file.h: Rename include guard.
9974         * tui/tui-disasm.h: Rename include guard.
9975         * tui/tui-data.h: Rename include guard.
9976         * tui/tui-command.h: Rename include guard.
9977         * tic6x-tdep.h: Add include guard.
9978         * target/waitstatus.h: Rename include guard.
9979         * target/wait.h: Rename include guard.
9980         * target/target.h: Rename include guard.
9981         * target/resume.h: Rename include guard.
9982         * target-float.h: Rename include guard.
9983         * stabsread.h: Add include guard.
9984         * rs6000-tdep.h: Add include guard.
9985         * riscv-fbsd-tdep.h: Add include guard.
9986         * regformats/regdef.h: Rename include guard.
9987         * record.h: Rename include guard.
9988         * python/python.h: Rename include guard.
9989         * python/python-internal.h: Rename include guard.
9990         * python/py-stopevent.h: Rename include guard.
9991         * python/py-ref.h: Rename include guard.
9992         * python/py-record.h: Rename include guard.
9993         * python/py-record-full.h: Rename include guard.
9994         * python/py-record-btrace.h: Rename include guard.
9995         * python/py-instruction.h: Rename include guard.
9996         * python/py-events.h: Rename include guard.
9997         * python/py-event.h: Rename include guard.
9998         * procfs.h: Add include guard.
9999         * proc-utils.h: Add include guard.
10000         * p-lang.h: Add include guard.
10001         * or1k-tdep.h: Rename include guard.
10002         * observable.h: Rename include guard.
10003         * nto-tdep.h: Rename include guard.
10004         * nat/x86-linux.h: Rename include guard.
10005         * nat/x86-linux-dregs.h: Rename include guard.
10006         * nat/x86-gcc-cpuid.h: Add include guard.
10007         * nat/x86-dregs.h: Rename include guard.
10008         * nat/x86-cpuid.h: Rename include guard.
10009         * nat/ppc-linux.h: Rename include guard.
10010         * nat/mips-linux-watch.h: Rename include guard.
10011         * nat/linux-waitpid.h: Rename include guard.
10012         * nat/linux-ptrace.h: Rename include guard.
10013         * nat/linux-procfs.h: Rename include guard.
10014         * nat/linux-osdata.h: Rename include guard.
10015         * nat/linux-nat.h: Rename include guard.
10016         * nat/linux-namespaces.h: Rename include guard.
10017         * nat/linux-btrace.h: Rename include guard.
10018         * nat/glibc_thread_db.h: Rename include guard.
10019         * nat/gdb_thread_db.h: Rename include guard.
10020         * nat/gdb_ptrace.h: Rename include guard.
10021         * nat/fork-inferior.h: Rename include guard.
10022         * nat/amd64-linux-siginfo.h: Rename include guard.
10023         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10024         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10025         * nat/aarch64-linux.h: Rename include guard.
10026         * nat/aarch64-linux-hw-point.h: Rename include guard.
10027         * mn10300-tdep.h: Add include guard.
10028         * mips-linux-tdep.h: Add include guard.
10029         * mi/mi-parse.h: Rename include guard.
10030         * mi/mi-out.h: Rename include guard.
10031         * mi/mi-main.h: Rename include guard.
10032         * mi/mi-interp.h: Rename include guard.
10033         * mi/mi-getopt.h: Rename include guard.
10034         * mi/mi-console.h: Rename include guard.
10035         * mi/mi-common.h: Rename include guard.
10036         * mi/mi-cmds.h: Rename include guard.
10037         * mi/mi-cmd-break.h: Rename include guard.
10038         * m2-lang.h: Add include guard.
10039         * location.h: Rename include guard.
10040         * linux-record.h: Rename include guard.
10041         * linux-nat.h: Add include guard.
10042         * linux-fork.h: Add include guard.
10043         * i386-darwin-tdep.h: Rename include guard.
10044         * hppa-linux-offsets.h: Add include guard.
10045         * guile/guile.h: Rename include guard.
10046         * guile/guile-internal.h: Rename include guard.
10047         * gnu-nat.h: Rename include guard.
10048         * gdb-stabs.h: Rename include guard.
10049         * frv-tdep.h: Add include guard.
10050         * f-lang.h: Add include guard.
10051         * event-loop.h: Add include guard.
10052         * darwin-nat.h: Rename include guard.
10053         * cp-abi.h: Rename include guard.
10054         * config/sparc/nm-sol2.h: Rename include guard.
10055         * config/nm-nto.h: Rename include guard.
10056         * config/nm-linux.h: Add include guard.
10057         * config/i386/nm-i386gnu.h: Rename include guard.
10058         * config/djgpp/nl_types.h: Rename include guard.
10059         * config/djgpp/langinfo.h: Rename include guard.
10060         * compile/gcc-cp-plugin.h: Add include guard.
10061         * compile/gcc-c-plugin.h: Add include guard.
10062         * compile/compile.h: Rename include guard.
10063         * compile/compile-object-run.h: Rename include guard.
10064         * compile/compile-object-load.h: Rename include guard.
10065         * compile/compile-internal.h: Rename include guard.
10066         * compile/compile-cplus.h: Rename include guard.
10067         * compile/compile-c.h: Rename include guard.
10068         * common/xml-utils.h: Rename include guard.
10069         * common/x86-xstate.h: Rename include guard.
10070         * common/version.h: Rename include guard.
10071         * common/vec.h: Rename include guard.
10072         * common/tdesc.h: Rename include guard.
10073         * common/selftest.h: Rename include guard.
10074         * common/scoped_restore.h: Rename include guard.
10075         * common/scoped_mmap.h: Rename include guard.
10076         * common/scoped_fd.h: Rename include guard.
10077         * common/safe-iterator.h: Rename include guard.
10078         * common/run-time-clock.h: Rename include guard.
10079         * common/refcounted-object.h: Rename include guard.
10080         * common/queue.h: Rename include guard.
10081         * common/ptid.h: Rename include guard.
10082         * common/print-utils.h: Rename include guard.
10083         * common/preprocessor.h: Rename include guard.
10084         * common/pathstuff.h: Rename include guard.
10085         * common/observable.h: Rename include guard.
10086         * common/netstuff.h: Rename include guard.
10087         * common/job-control.h: Rename include guard.
10088         * common/host-defs.h: Rename include guard.
10089         * common/gdb_wait.h: Rename include guard.
10090         * common/gdb_vecs.h: Rename include guard.
10091         * common/gdb_unlinker.h: Rename include guard.
10092         * common/gdb_unique_ptr.h: Rename include guard.
10093         * common/gdb_tilde_expand.h: Rename include guard.
10094         * common/gdb_sys_time.h: Rename include guard.
10095         * common/gdb_string_view.h: Rename include guard.
10096         * common/gdb_splay_tree.h: Rename include guard.
10097         * common/gdb_setjmp.h: Rename include guard.
10098         * common/gdb_ref_ptr.h: Rename include guard.
10099         * common/gdb_optional.h: Rename include guard.
10100         * common/gdb_locale.h: Rename include guard.
10101         * common/gdb_assert.h: Rename include guard.
10102         * common/filtered-iterator.h: Rename include guard.
10103         * common/filestuff.h: Rename include guard.
10104         * common/fileio.h: Rename include guard.
10105         * common/environ.h: Rename include guard.
10106         * common/common-utils.h: Rename include guard.
10107         * common/common-types.h: Rename include guard.
10108         * common/common-regcache.h: Rename include guard.
10109         * common/common-inferior.h: Rename include guard.
10110         * common/common-gdbthread.h: Rename include guard.
10111         * common/common-exceptions.h: Rename include guard.
10112         * common/common-defs.h: Rename include guard.
10113         * common/common-debug.h: Rename include guard.
10114         * common/cleanups.h: Rename include guard.
10115         * common/buffer.h: Rename include guard.
10116         * common/btrace-common.h: Rename include guard.
10117         * common/break-common.h: Rename include guard.
10118         * cli/cli-utils.h: Rename include guard.
10119         * cli/cli-style.h: Rename include guard.
10120         * cli/cli-setshow.h: Rename include guard.
10121         * cli/cli-script.h: Rename include guard.
10122         * cli/cli-interp.h: Rename include guard.
10123         * cli/cli-decode.h: Rename include guard.
10124         * cli/cli-cmds.h: Rename include guard.
10125         * charset-list.h: Add include guard.
10126         * buildsym-legacy.h: Rename include guard.
10127         * bfin-tdep.h: Add include guard.
10128         * ax.h: Rename include guard.
10129         * arm-linux-tdep.h: Add include guard.
10130         * arm-fbsd-tdep.h: Add include guard.
10131         * arch/xtensa.h: Rename include guard.
10132         * arch/tic6x.h: Add include guard.
10133         * arch/i386.h: Add include guard.
10134         * arch/arm.h: Rename include guard.
10135         * arch/arm-linux.h: Rename include guard.
10136         * arch/arm-get-next-pcs.h: Rename include guard.
10137         * arch/amd64.h: Add include guard.
10138         * arch/aarch64-insn.h: Rename include guard.
10139         * arch-utils.h: Rename include guard.
10140         * annotate.h: Add include guard.
10141         * amd64-darwin-tdep.h: Rename include guard.
10142         * aarch64-linux-tdep.h: Add include guard.
10143         * aarch64-fbsd-tdep.h: Add include guard.
10144         * aarch32-linux-nat.h: Add include guard.
10145
10146 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10147
10148         * macrotab.c (macro_define_internal): New function that
10149         factorizes macro_define_object_internal and macro_define_function
10150         code.
10151         (macro_define_object_internal): Use macro_define_internal.
10152         (macro_define_function): Likewise.
10153
10154 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10155
10156         * macrocmd.c (extract_identifier): Return
10157         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10158         callers.
10159
10160 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10161
10162         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10163
10164 2019-02-05  Tom Tromey  <tom@tromey.com>
10165
10166         * target.c (target_stack::unpush): Move assertion earlier.
10167
10168 2019-01-30  Tom Tromey  <tom@tromey.com>
10169
10170         PR python/23615:
10171         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10172         (gdbpy_parse_and_eval): Likewise.
10173         * python/python-internal.h (gdbpy_allow_threads): New class.
10174
10175 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10176
10177         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10178         (aarch64_fbsd_fpregmap): Move earlier.
10179         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10180         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10181         instead of individual calls to trad_frame_set_reg_addr.
10182         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10183         earlier.
10184         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10185         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10186         instead of individual calls to trad_frame_set_reg_addr.
10187
10188 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10189
10190         * CONTRIBUTE: Replace contribution list with wiki link.
10191
10192 2019-01-25  Tom Tromey  <tom@tromey.com>
10193
10194         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10195
10196 2019-01-25  Tom Tromey  <tom@tromey.com>
10197
10198         * xtensa-linux-nat.c: Fix common/ includes.
10199         * xml-support.h: Fix common/ includes.
10200         * xml-support.c: Fix common/ includes.
10201         * x86-linux-nat.c: Fix common/ includes.
10202         * windows-nat.c: Fix common/ includes.
10203         * varobj.h: Fix common/ includes.
10204         * varobj.c: Fix common/ includes.
10205         * value.c: Fix common/ includes.
10206         * valops.c: Fix common/ includes.
10207         * utils.c: Fix common/ includes.
10208         * unittests/xml-utils-selftests.c: Fix common/ includes.
10209         * unittests/utils-selftests.c: Fix common/ includes.
10210         * unittests/unpack-selftests.c: Fix common/ includes.
10211         * unittests/tracepoint-selftests.c: Fix common/ includes.
10212         * unittests/style-selftests.c: Fix common/ includes.
10213         * unittests/string_view-selftests.c: Fix common/ includes.
10214         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10215         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10216         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10217         * unittests/rsp-low-selftests.c: Fix common/ includes.
10218         * unittests/parse-connection-spec-selftests.c: Fix common/
10219         includes.
10220         * unittests/optional-selftests.c: Fix common/ includes.
10221         * unittests/offset-type-selftests.c: Fix common/ includes.
10222         * unittests/observable-selftests.c: Fix common/ includes.
10223         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10224         * unittests/memrange-selftests.c: Fix common/ includes.
10225         * unittests/memory-map-selftests.c: Fix common/ includes.
10226         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10227         * unittests/function-view-selftests.c: Fix common/ includes.
10228         * unittests/environ-selftests.c: Fix common/ includes.
10229         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10230         * unittests/common-utils-selftests.c: Fix common/ includes.
10231         * unittests/cli-utils-selftests.c: Fix common/ includes.
10232         * unittests/array-view-selftests.c: Fix common/ includes.
10233         * ui-file.c: Fix common/ includes.
10234         * tui/tui-io.c: Fix common/ includes.
10235         * tracepoint.h: Fix common/ includes.
10236         * tracepoint.c: Fix common/ includes.
10237         * tracefile-tfile.c: Fix common/ includes.
10238         * top.h: Fix common/ includes.
10239         * top.c: Fix common/ includes.
10240         * thread.c: Fix common/ includes.
10241         * target/waitstatus.h: Fix common/ includes.
10242         * target/waitstatus.c: Fix common/ includes.
10243         * target.h: Fix common/ includes.
10244         * target.c: Fix common/ includes.
10245         * target-memory.c: Fix common/ includes.
10246         * target-descriptions.c: Fix common/ includes.
10247         * symtab.h: Fix common/ includes.
10248         * symfile.c: Fix common/ includes.
10249         * stap-probe.c: Fix common/ includes.
10250         * spu-linux-nat.c: Fix common/ includes.
10251         * sparc-nat.c: Fix common/ includes.
10252         * source.c: Fix common/ includes.
10253         * solib.c: Fix common/ includes.
10254         * solib-target.c: Fix common/ includes.
10255         * ser-unix.c: Fix common/ includes.
10256         * ser-tcp.c: Fix common/ includes.
10257         * ser-pipe.c: Fix common/ includes.
10258         * ser-base.c: Fix common/ includes.
10259         * selftest-arch.c: Fix common/ includes.
10260         * s12z-tdep.c: Fix common/ includes.
10261         * rust-exp.y: Fix common/ includes.
10262         * rs6000-aix-tdep.c: Fix common/ includes.
10263         * riscv-tdep.c: Fix common/ includes.
10264         * remote.c: Fix common/ includes.
10265         * remote-notif.h: Fix common/ includes.
10266         * remote-fileio.h: Fix common/ includes.
10267         * remote-fileio.c: Fix common/ includes.
10268         * regcache.h: Fix common/ includes.
10269         * regcache.c: Fix common/ includes.
10270         * record-btrace.c: Fix common/ includes.
10271         * python/python.c: Fix common/ includes.
10272         * python/py-type.c: Fix common/ includes.
10273         * python/py-inferior.c: Fix common/ includes.
10274         * progspace.h: Fix common/ includes.
10275         * producer.c: Fix common/ includes.
10276         * procfs.c: Fix common/ includes.
10277         * proc-api.c: Fix common/ includes.
10278         * printcmd.c: Fix common/ includes.
10279         * ppc-linux-nat.c: Fix common/ includes.
10280         * parser-defs.h: Fix common/ includes.
10281         * osdata.c: Fix common/ includes.
10282         * obsd-nat.c: Fix common/ includes.
10283         * nat/x86-linux.c: Fix common/ includes.
10284         * nat/x86-linux-dregs.c: Fix common/ includes.
10285         * nat/x86-dregs.h: Fix common/ includes.
10286         * nat/x86-dregs.c: Fix common/ includes.
10287         * nat/ppc-linux.c: Fix common/ includes.
10288         * nat/mips-linux-watch.h: Fix common/ includes.
10289         * nat/mips-linux-watch.c: Fix common/ includes.
10290         * nat/linux-waitpid.c: Fix common/ includes.
10291         * nat/linux-ptrace.h: Fix common/ includes.
10292         * nat/linux-ptrace.c: Fix common/ includes.
10293         * nat/linux-procfs.c: Fix common/ includes.
10294         * nat/linux-personality.c: Fix common/ includes.
10295         * nat/linux-osdata.c: Fix common/ includes.
10296         * nat/linux-namespaces.c: Fix common/ includes.
10297         * nat/linux-btrace.h: Fix common/ includes.
10298         * nat/linux-btrace.c: Fix common/ includes.
10299         * nat/fork-inferior.c: Fix common/ includes.
10300         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10301         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10302         * nat/aarch64-linux.c: Fix common/ includes.
10303         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10304         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10305         * namespace.h: Fix common/ includes.
10306         * mips-linux-tdep.c: Fix common/ includes.
10307         * minsyms.c: Fix common/ includes.
10308         * mi/mi-parse.h: Fix common/ includes.
10309         * mi/mi-main.c: Fix common/ includes.
10310         * mi/mi-cmd-env.c: Fix common/ includes.
10311         * memrange.h: Fix common/ includes.
10312         * memattr.c: Fix common/ includes.
10313         * maint.h: Fix common/ includes.
10314         * maint.c: Fix common/ includes.
10315         * main.c: Fix common/ includes.
10316         * machoread.c: Fix common/ includes.
10317         * location.c: Fix common/ includes.
10318         * linux-thread-db.c: Fix common/ includes.
10319         * linux-nat.c: Fix common/ includes.
10320         * linux-fork.c: Fix common/ includes.
10321         * inline-frame.c: Fix common/ includes.
10322         * infrun.c: Fix common/ includes.
10323         * inflow.c: Fix common/ includes.
10324         * inferior.h: Fix common/ includes.
10325         * inferior.c: Fix common/ includes.
10326         * infcmd.c: Fix common/ includes.
10327         * inf-ptrace.c: Fix common/ includes.
10328         * inf-child.c: Fix common/ includes.
10329         * ia64-linux-nat.c: Fix common/ includes.
10330         * i387-tdep.c: Fix common/ includes.
10331         * i386-tdep.c: Fix common/ includes.
10332         * i386-linux-tdep.c: Fix common/ includes.
10333         * i386-linux-nat.c: Fix common/ includes.
10334         * i386-go32-tdep.c: Fix common/ includes.
10335         * i386-fbsd-tdep.c: Fix common/ includes.
10336         * i386-fbsd-nat.c: Fix common/ includes.
10337         * guile/scm-type.c: Fix common/ includes.
10338         * guile/guile.c: Fix common/ includes.
10339         * go32-nat.c: Fix common/ includes.
10340         * gnu-nat.c: Fix common/ includes.
10341         * gdbthread.h: Fix common/ includes.
10342         * gdbarch-selftests.c: Fix common/ includes.
10343         * gdb_usleep.c: Fix common/ includes.
10344         * gdb_select.h: Fix common/ includes.
10345         * gdb_bfd.c: Fix common/ includes.
10346         * gcore.c: Fix common/ includes.
10347         * fork-child.c: Fix common/ includes.
10348         * findvar.c: Fix common/ includes.
10349         * fbsd-nat.c: Fix common/ includes.
10350         * event-top.c: Fix common/ includes.
10351         * event-loop.c: Fix common/ includes.
10352         * dwarf2read.c: Fix common/ includes.
10353         * dwarf2loc.c: Fix common/ includes.
10354         * dwarf2-frame.c: Fix common/ includes.
10355         * dwarf-index-cache.c: Fix common/ includes.
10356         * dtrace-probe.c: Fix common/ includes.
10357         * disasm-selftests.c: Fix common/ includes.
10358         * defs.h: Fix common/ includes.
10359         * csky-tdep.c: Fix common/ includes.
10360         * cp-valprint.c: Fix common/ includes.
10361         * cp-support.h: Fix common/ includes.
10362         * cp-support.c: Fix common/ includes.
10363         * corelow.c: Fix common/ includes.
10364         * completer.h: Fix common/ includes.
10365         * completer.c: Fix common/ includes.
10366         * compile/compile.c: Fix common/ includes.
10367         * compile/compile-loc2c.c: Fix common/ includes.
10368         * compile/compile-cplus-types.c: Fix common/ includes.
10369         * compile/compile-cplus-symbols.c: Fix common/ includes.
10370         * command.h: Fix common/ includes.
10371         * cli/cli-dump.c: Fix common/ includes.
10372         * cli/cli-cmds.c: Fix common/ includes.
10373         * charset.c: Fix common/ includes.
10374         * build-id.c: Fix common/ includes.
10375         * btrace.h: Fix common/ includes.
10376         * btrace.c: Fix common/ includes.
10377         * breakpoint.h: Fix common/ includes.
10378         * breakpoint.c: Fix common/ includes.
10379         * ax.h:
10380         (enum agent_op): Fix common/ includes.
10381         * ax-general.c (struct aop_map): Fix common/ includes.
10382         * ax-gdb.c: Fix common/ includes.
10383         * auxv.c: Fix common/ includes.
10384         * auto-load.c: Fix common/ includes.
10385         * arm-tdep.c: Fix common/ includes.
10386         * arch/riscv.c: Fix common/ includes.
10387         * arch/ppc-linux-common.c: Fix common/ includes.
10388         * arch/i386.c: Fix common/ includes.
10389         * arch/arm.c: Fix common/ includes.
10390         * arch/arm-linux.c: Fix common/ includes.
10391         * arch/arm-get-next-pcs.c: Fix common/ includes.
10392         * arch/amd64.c: Fix common/ includes.
10393         * arch/aarch64.c: Fix common/ includes.
10394         * arch/aarch64-insn.c: Fix common/ includes.
10395         * arch-utils.c: Fix common/ includes.
10396         * amd64-windows-tdep.c: Fix common/ includes.
10397         * amd64-tdep.c: Fix common/ includes.
10398         * amd64-sol2-tdep.c: Fix common/ includes.
10399         * amd64-obsd-tdep.c: Fix common/ includes.
10400         * amd64-nbsd-tdep.c: Fix common/ includes.
10401         * amd64-linux-tdep.c: Fix common/ includes.
10402         * amd64-linux-nat.c: Fix common/ includes.
10403         * amd64-fbsd-tdep.c: Fix common/ includes.
10404         * amd64-fbsd-nat.c: Fix common/ includes.
10405         * amd64-dicos-tdep.c: Fix common/ includes.
10406         * amd64-darwin-tdep.c: Fix common/ includes.
10407         * agent.c: Fix common/ includes.
10408         * ada-lang.h: Fix common/ includes.
10409         * ada-lang.c: Fix common/ includes.
10410         * aarch64-tdep.c: Fix common/ includes.
10411
10412 2019-01-25  Tom Tromey  <tom@tromey.com>
10413
10414         * common/create-version.sh: Use common/version.h.
10415
10416 2019-01-24  Pedro Alves  <palves@redhat.com>
10417
10418         * infrun.c (signal_stop, signal_print, signal_program)
10419         (signal_catch, signal_pass): Now arrays instead of pointers.
10420         (update_signals_program_target, do_target_resume)
10421         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10422         * linux-nat.c (linux_nat_target::pass_signals)
10423         (linux_nat_target::create_inferior, linux_nat_target::attach):
10424         Adjust.
10425         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10426         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10427         * procfs.c (procfs_target::pass_signals): Adjust.
10428         * record-full.c (record_full_target::resume): Adjust.
10429         * remote.c (remote_target::pass_signals)
10430         (remote_target::program_signals): Adjust.
10431         * target-debug.h (target_debug_print_signals): Now takes a
10432         gdb::array_view as parameter.  Adjust.
10433         * target.h (target_ops) <pass_signals, program_signals>: Replace
10434         pointer and length parameters with gdb::array_view.
10435         (target_pass_signals, target_program_signals): Likewise.
10436         * target-delegates.c: Regenerate.
10437
10438 2019-01-24  Pedro Alves  <palves@redhat.com>
10439
10440         * common/forward-scope-exit.h
10441         (forward_scope_exit::forward_scope_exit): Pass arguments to
10442         m_bind_function directly, instead of creating a std::bind and
10443         copying that.
10444
10445 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10446
10447         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10448         for static members.
10449         (pass_in_v_vfp_candidate): Likewise.
10450
10451 2019-01-23  Tom Tromey  <tom@tromey.com>
10452             Pedro Alves  <palves@redhat.com>
10453
10454         * regcache.c (class regcache_invalidator): Remove.
10455         (regcache::raw_write): Use make_scope_exit.
10456
10457 2019-01-23  Tom Tromey  <tom@tromey.com>
10458
10459         * ui-out.h (class ui_out_emit_type): Update comment.
10460
10461 2019-01-23  Tom Tromey  <tom@tromey.com>
10462
10463         * infrun.c (fetch_inferior_event): Update comment.
10464
10465 2019-01-23  Tom Tromey  <tom@tromey.com>
10466             Pedro Alves  <palves@redhat.com>
10467
10468         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10469         parameter.
10470         (fetch_inferior_event): Use SCOPE_EXIT.
10471
10472
10473 2019-01-23  Tom Tromey  <tom@tromey.com>
10474             Pedro Alves  <palves@redhat.com>
10475
10476         * infrun.c (disable_thread_events): Delete.
10477         (stop_all_threads): Use SCOPE_EXIT.
10478
10479 2019-01-23  Tom Tromey  <tom@tromey.com>
10480             Pedro Alves  <palves@redhat.com>
10481
10482         * symfile.c: Include forward-scope-exit.h.
10483         (clear_symtab_users_cleanup): Replace forward declaration with
10484         a FORWARD_SCOPE_EXIT.
10485         (syms_from_objfile_1): Use the forward_scope_exit and
10486         gdb::optional instead of cleanup_function.
10487         (reread_symbols): Use the forward_scope_exit instead of
10488         cleanup_function.
10489         (clear_symtab_users_cleanup): Remove function.
10490
10491 2019-01-23  Tom Tromey  <tom@tromey.com>
10492             Pedro Alves  <palves@redhat.com>
10493
10494         * linux-nat.c: Include scope-exit.h.
10495         (cleanup_target_stop): Remove.
10496         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10497         SCOPE_EXIT.
10498
10499 2019-01-23  Tom Tromey  <tom@tromey.com>
10500             Pedro Alves  <palves@redhat.com>
10501
10502         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10503         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10504
10505 2019-01-23  Tom Tromey  <tom@tromey.com>
10506             Andrew Burgess  <andrew.burgess@embecosm.com>
10507             Pedro Alves  <palves@redhat.com>
10508
10509         * infrun.c (fetch_inferior_event): Use scope_exit.
10510         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10511         * top.c (execute_command): Use scope_exit.
10512         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10513         * utils.c (do_bpstat_clear_actions_cleanup)
10514         (make_bpstat_clear_actions_cleanup): Remove.
10515
10516 2019-01-23  Tom Tromey  <tom@tromey.com>
10517             Pedro Alves  <palves@redhat.com>
10518
10519         * infrun.c: Include "common/scope-exit.h"
10520         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10521         (wait_for_inferior): Use SCOPE_EXIT.
10522         (fetch_inferior_event): Use scope_exit.
10523
10524 2019-01-23  Tom Tromey  <tom@tromey.com>
10525             Pedro Alves  <palves@redhat.com>
10526
10527         * breakpoint.c (create_breakpoint): Remove cleanup.
10528
10529 2019-01-23  Tom Tromey  <tom@tromey.com>
10530             Andrew Burgess  <andrew.burgess@embecosm.com>
10531             Pedro Alves  <palves@redhat.com>
10532
10533 2019-01-23  Pedro Alves  <palves@redhat.com>
10534
10535         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10536
10537 2019-01-23  Pedro Alves  <palves@redhat.com>
10538             Andrew Burgess  <andrew.burgess@embecosm.com>
10539
10540         * gdbthread.h: Include "common/forward-scope-exit.h".
10541         (scoped_finish_thread_state): Redefine custom class in terms of
10542         forward_scope_exit.
10543
10544 2019-01-23  Pedro Alves  <palves@redhat.com>
10545             Andrew Burgess  <andrew.burgess@embecosm.com>
10546
10547         * common/forward-scope-exit.h: New file.
10548
10549 2019-01-23  Pedro Alves  <palves@redhat.com>
10550             Andrew Burgess  <andrew.burgess@embecosm.com>
10551             Tom Tromey  <tom@tromey.com>
10552
10553         * common/scope-exit.h: New file.
10554
10555 2019-01-23  Pedro Alves  <palves@redhat.com>
10556
10557         * common/preprocessor.h (ESC): Rename to ...
10558         (ESC_PARENS): ... this.
10559         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10560         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10561
10562 2019-01-23  Tom Tromey  <tom@tromey.com>
10563
10564         * language.h (class scoped_switch_to_sym_language_if_auto):
10565         Initialize m_lang in both cases.
10566
10567 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10568
10569         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10570         with XCNEW.
10571
10572 2019-01-22  Tom Tromey  <tom@tromey.com>
10573
10574         * corelow.c: Do not include sys/file.h.
10575
10576 2019-01-22  Tom Tromey  <tom@tromey.com>
10577
10578         * tui/tui-wingeneral.h: Include gdb_curses.h.
10579
10580 2019-01-22  Tom Tromey  <tom@tromey.com>
10581
10582         * source-cache.h (class source_cache) <get_source_lines,
10583         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10584
10585 2019-01-22  Tom Tromey  <tom@tromey.com>
10586
10587         * remote-fileio.h (struct remote_target): Declare.
10588
10589 2019-01-22  Tom Tromey  <tom@tromey.com>
10590
10591         * python/py-arch.c: Do not include py-ref.h.
10592         * python/py-bpevent.c: Do not include py-ref.h.
10593         * python/py-cmd.c: Do not include py-ref.h.
10594         * python/py-continueevent.c: Do not include py-ref.h.
10595         * python/py-event.h: Do not include py-ref.h.
10596         * python/py-evtregistry.c: Do not include py-ref.h.
10597         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10598         * python/py-frame.c: Do not include py-ref.h.
10599         * python/py-framefilter.c: Do not include py-ref.h.
10600         * python/py-function.c: Do not include py-ref.h.
10601         * python/py-infevents.c: Do not include py-ref.h.
10602         * python/py-linetable.c: Do not include py-ref.h.
10603         * python/py-objfile.c: Do not include py-ref.h.
10604         * python/py-param.c: Do not include py-ref.h.
10605         * python/py-prettyprint.c: Do not include py-ref.h.
10606         * python/py-progspace.c: Do not include py-ref.h.
10607         * python/py-symbol.c: Do not include py-ref.h.
10608         * python/py-symtab.c: Do not include py-ref.h.
10609         * python/py-type.c: Do not include py-ref.h.
10610         * python/py-unwind.c: Do not include py-ref.h.
10611         * python/py-utils.c: Do not include py-ref.h.
10612         * python/py-value.c: Do not include py-ref.h.
10613         * python/py-varobj.c: Do not include py-ref.h.
10614         * python/py-xmethods.c: Do not include py-ref.h.
10615         * python/python.c: Do not include py-ref.h.
10616         * varobj.c: Do not include py-ref.h.
10617
10618 2019-01-22  Tom Tromey  <tom@tromey.com>
10619
10620         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10621         keyword for bcache.
10622
10623 2019-01-22  Tom Tromey  <tom@tromey.com>
10624
10625         * compile/compile-cplus-types.c: Remove a comment by #include.
10626
10627 2019-01-22  Tom Tromey  <tom@tromey.com>
10628
10629         * compile/gcc-c-plugin.h: Include compile-internal.h.
10630
10631 2019-01-22  Tom Tromey  <tom@tromey.com>
10632
10633         * stabsread.c (EXTERN): Do not define.
10634         (symnum, next_symbol_text_func, processing_gcc_compilation)
10635         (within_function, global_sym_chain, global_stabs)
10636         (previous_stab_code, this_object_header_files)
10637         (n_this_object_header_files)
10638         (n_allocated_this_object_header_files): Define.
10639         * stabsread.h (EXTERN): Never define.  Use "extern".
10640
10641 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10642
10643         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10644         history_value.
10645
10646 2019-01-21  Tom Tromey  <tom@tromey.com>
10647
10648         * ui-out.c: Fix includes.
10649         * tui/tui-source.c: Fix includes.
10650         * target.c: Fix includes.
10651         * remote.c: Fix includes.
10652         * regcache.c: Fix includes.
10653         * python/py-block.c: Fix includes.
10654         * printcmd.c: Fix includes.
10655         * or1k-tdep.c: Fix includes.
10656         * mi/mi-main.c: Fix includes.
10657         * m32r-tdep.c: Fix includes.
10658         * csky-tdep.c: Fix includes.
10659         * compile/compile-cplus-types.c: Fix includes.
10660         * cli/cli-interp.c: Fix includes.
10661
10662 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10663
10664         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10665         for padding.
10666
10667 2019-01-16  Tom Tromey  <tom@tromey.com>
10668
10669         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10670         earlier.
10671         (struct objfile) <msymbols_range>: Move from top level.
10672         <msymbols>: New method.
10673         (class objfile_msymbols): Remove.
10674         * symtab.c (default_collect_symbol_completion_matches_break_on):
10675         Update.
10676         * symmisc.c (dump_msymbols): Update.
10677         * stabsread.c (scan_file_globals): Update.
10678         * objc-lang.c (info_selectors_command, info_classes_command)
10679         (find_methods): Update.
10680         * minsyms.c (find_solib_trampoline_target): Update.
10681         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10682         * coffread.c (coff_symfile_read): Update.
10683         * ada-lang.c (ada_lookup_simple_minsym)
10684         (ada_collect_symbol_completion_matches): Update.
10685
10686 2019-01-16  Tom Tromey  <tom@tromey.com>
10687
10688         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10689         type.  Remove no-argument constructor.
10690         <iterator::operator++>: Simplify.
10691         <begin>: Update.
10692         <end>: Use minimal_symbol_count.
10693
10694 2019-01-16  Tom Tromey  <tom@tromey.com>
10695
10696         * objfiles.h (struct objfile) <psymtabs>: New method.
10697         (class objfile_psymtabs): Remove.
10698         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10699         typedef.
10700         <range>: New method.
10701         (require_partial_symbols): Change return type.
10702         * psymtab.c (require_partial_symbols)
10703         (psym_expand_symtabs_matching): Update.
10704         * mdebugread.c (parse_partial_symbols): Update.
10705         * dbxread.c (dbx_end_psymtab): Update.
10706
10707 2019-01-15  Tom Tromey  <tom@tromey.com>
10708
10709         * symtab.c (lookup_objfile_from_block)
10710         (lookup_symbol_in_objfile_symtabs)
10711         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10712         (find_line_symtab, info_sources_command)
10713         (default_collect_symbol_completion_matches_break_on)
10714         (make_source_files_completion_list): Update.
10715         * symmisc.c (print_objfile_statistics, dump_objfile)
10716         (maintenance_print_symbols, maintenance_info_symtabs)
10717         (maintenance_check_symtabs, maintenance_info_line_tables):
10718         Update.
10719         * source.c (select_source_symtab)
10720         (forget_cached_source_info_for_objfile): Update.
10721         * objfiles.h (class objfile_compunits): Remove.
10722         (struct objfile) <compunits_range>: New typedef.
10723         (compunits): New method.
10724         * objfiles.c (objfile_relocate1): Update.
10725         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10726         * maint.c (count_symtabs_and_blocks): Update.
10727         * linespec.c (iterate_over_all_matching_symtabs): Update.
10728         * cp-support.c (add_symbol_overload_list_qualified): Update.
10729         * coffread.c (coff_symtab_read): Update.
10730         * ada-lang.c (add_nonlocal_symbols)
10731         (ada_collect_symbol_completion_matches)
10732         (ada_add_global_exceptions): Update.
10733
10734 2019-01-15  Tom Tromey  <tom@tromey.com>
10735
10736         * progspace.h (program_space) <objfiles_safe_range>: New
10737         typedef.
10738         <objfiles_safe>: New method.
10739         * objfiles.h (class all_objfiles_safe): Remove.
10740         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10741         * jit.c (jit_inferior_exit_hook): Update.
10742
10743 2019-01-17  Tom Tromey  <tom@tromey.com>
10744
10745         * progspace.h (program_space) <objfiles_range>: New typedef.
10746         <objfiles>: New method.
10747         <objfiles_head>: Rename from objfiles.
10748         (object_files): Update.
10749         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10750         * guile/scm-pretty-print.c
10751         (ppscm_find_pretty_printer_from_objfiles): Update.
10752         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10753         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10754         Update.
10755         * python/py-progspace.c (pspy_get_objfiles): Update.
10756         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10757         Update.
10758         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10759         (objfpy_lookup_objfile_by_build_id): Update.
10760         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10761         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10762         Update.
10763         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10764         (expand_symtab_containing_pc, lookup_objfile_from_block)
10765         (lookup_static_symbol, basic_lookup_transparent_type)
10766         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10767         (find_line_symtab, info_sources_command)
10768         (default_collect_symbol_completion_matches_break_on)
10769         (make_source_files_completion_list, find_main_name): Update.
10770         * symmisc.c (print_symbol_bcache_statistics)
10771         (print_objfile_statistics, maintenance_print_symbols)
10772         (maintenance_print_msymbols, maintenance_print_objfiles)
10773         (maintenance_info_symtabs, maintenance_check_symtabs)
10774         (maintenance_expand_symtabs, maintenance_info_line_tables):
10775         Update.
10776         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10777         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10778         (map_overlay_command, unmap_overlay_command)
10779         (simple_overlay_update, expand_symtabs_matching)
10780         (map_symbol_filenames): Update.
10781         * symfile-debug.c (set_debug_symfile): Update.
10782         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10783         Update.
10784         * source.c (select_source_symtab, forget_cached_source_info):
10785         Update.
10786         * solib.c (solib_read_symbols): Update.
10787         * solib-spu.c (append_ocl_sos): Update.
10788         * psymtab.c (maintenance_print_psymbols)
10789         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10790         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10791         * printcmd.c (info_symbol_command): Update.
10792         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10793         Update.
10794         * objfiles.h (class all_objfiles): Remove.
10795         * objfiles.c (have_partial_symbols, have_full_symbols)
10796         (have_minimal_symbols, qsort_cmp, update_section_map)
10797         (shared_objfile_contains_address_p)
10798         (default_iterate_over_objfiles_in_search_order): Update.
10799         * objc-lang.c (info_selectors_command, info_classes_command)
10800         (find_methods): Update.
10801         * minsyms.c (find_solib_trampoline_target): Update.
10802         * maint.c (maintenance_info_sections)
10803         (maintenance_translate_address, count_symtabs_and_blocks):
10804         Update.
10805         * main.c (captured_main_1): Update.
10806         * linux-thread-db.c (try_thread_db_load_from_pdir)
10807         (has_libpthread): Update.
10808         * linespec.c (iterate_over_all_matching_symtabs)
10809         (search_minsyms_for_name): Update.
10810         * jit.c (jit_find_objf_with_entry_addr): Update.
10811         * hppa-tdep.c (find_unwind_entry)
10812         (hppa_lookup_stub_minimal_symbol): Update.
10813         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10814         Update.
10815         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10816         (elf_gnu_ifunc_resolve_by_got): Update.
10817         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10818         * dwarf-index-write.c (save_gdb_index_command): Update.
10819         * cp-support.c (add_symbol_overload_list_qualified): Update.
10820         * breakpoint.c (create_overlay_event_breakpoint)
10821         (create_longjmp_master_breakpoint)
10822         (create_std_terminate_master_breakpoint)
10823         (create_exception_master_breakpoint): Update.
10824         * blockframe.c (find_pc_partial_function): Update.
10825         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10826         (ada_collect_symbol_completion_matches)
10827         (ada_add_global_exceptions): Update.
10828
10829 2019-01-17  Tom Tromey  <tom@tromey.com>
10830
10831         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10832         declare VEC.
10833         (solib_target_parse_libraries): Change return type.
10834         (library_list_start_segment, library_list_start_section)
10835         (library_list_end_library, library_list_start_library); Update.
10836         (solib_target_free_library_list): Remove.
10837         (solib_target_parse_libraries): Remove cleanup.  Change return
10838         type.
10839         (solib_target_current_sos): Update.
10840
10841 2019-01-17  Tom Tromey  <tromey@bapiya>
10842
10843         * valprint.c: Replace "the the" with "the".
10844         * symtab.c: Replace "the the" with "the".
10845         * solib.c: Replace "the the" with "the".
10846         * solib-dsbt.c: Replace "the the" with "the".
10847         * linespec.c: Replace "the the" with "the".
10848         * dwarf2loc.h: Replace "the the" with "the".
10849         * amd64-windows-tdep.c: Replace "the the" with "the".
10850         * aarch64-tdep.c: Replace "the the" with "the".
10851
10852 2019-01-16  Keith Seitz  <keiths@redhat.com>
10853
10854         PR gdb/23773
10855         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10856         <builder>: Rename to ..
10857         <m_builder>: ... this and make private.
10858         (dwarf2_cu::get_builder): New method.  Change all users of
10859         `builder' to use this method.
10860         (dwarf2_start_symtab): Move to ...
10861         (dwarf2_cu::start_symtab): ... here.  Update all callers
10862         (setup_type_unit_groups): Move to ...
10863         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10864         callers.
10865         (dwarf2_cu::reset_builder): New method.
10866         (process_full_compunit, process_full_type_unit): Use
10867         dwarf2_cu::reset_builder.
10868         (follow_die_offset): Record the ancestor CU if it is different
10869         from the followed DIE's CU.
10870         (follow_die_sig_1): Likewise.
10871
10872 2019-01-15  Tom Tromey  <tom@tromey.com>
10873
10874         * remote.c (class remote_state) <buf>: Now a char_vector.
10875         <buf_size>: Remove.
10876         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10877         parameter.
10878         (remote_target::getpkt_or_notif_sane_1)
10879         (remote_target::getpkt_sane)
10880         (remote_target::getpkt_or_notif_sane): Likewise.
10881         (class remote_target) <putpkt>: New overload.
10882         (remote_target::read_frame): Change type of "buf_p".  Remove
10883         sizeof_p parameter.
10884         (packet_ok): New overload.
10885         (packet_check_result): New overload.
10886         Update all uses.
10887
10888 2019-01-14  Tom Tromey  <tom@tromey.com>
10889
10890         * remote-notif.c (handle_notification, remote_notif_ack)
10891         (remote_notif_parse): Make "buf" const.
10892         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10893         const.
10894         (remote_notif_parse, remote_notif_ack, handle_notification):
10895         Likewise.
10896         * remote.c (remote_notif_stop_parse): Make "buf" const.
10897         (remote_target::remote_parse_stop_reply): Make "buf" const.
10898         (remote_notif_stop_ack): Make "buf" const.
10899
10900 2019-01-14  Tom Tromey  <tom@tromey.com>
10901
10902         * remote.c (remote_console_output): Make parameter const.
10903
10904 2019-01-14  Tom Tromey  <tom@tromey.com>
10905
10906         * target-debug.h (target_debug_print_signals): Constify.
10907         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10908         * procfs.c (procfs_target::pass_signals): Update.
10909         * linux-nat.c (linux_nat_target::pass_signals): Update.
10910         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10911         * target-delegates.c: Rebuild.
10912         * remote.c (remote_target::program_signals): Update.
10913         (remote_target::pass_signals): Update.
10914         * target.c (target_pass_signals): Constify argument.
10915         (target_program_signals): Likewise.
10916         * target.h (struct target_ops) <pass_signals, program_signals>:
10917         Constify argument.
10918         (target_pass_signals, target_program_signals): Constify argument.
10919
10920 2019-01-14  Tom Tromey  <tom@tromey.com>
10921
10922         PR tui/28819:
10923         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10924
10925 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10926
10927         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10928         field.
10929         * rs6000-tdep.c: Include reggroups.h.
10930         (IS_V_ALIAS_PSEUDOREG): Define.
10931         (rs6000_register_name): Return names for the "vX" aliases.
10932         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10933         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10934         aliases.  Call default_register_reggroup_p for all other
10935         pseudo-registers.
10936         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10937         New functions.
10938         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10939         Handle "vX" aliases.
10940         (v_alias_pseudo_register_collect): New function.
10941         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10942         (rs6000_gdbarch_init): Initialize "vX" aliases as
10943         pseudo-registers.  Restore registration of
10944         rs6000_pseudo_register_reggroup_p with
10945         set_tdesc_pseudo_register_reggroup_p.
10946
10947 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10948
10949         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10950         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10951         set_gdbarch_num_pseudo_regs.
10952
10953 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10954
10955         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10956         Remove arg prefixname, add do_set and do_show.
10957         Add member functions set_list and show_list.
10958         * cli/cli-style.c (class cli_style_option): Update accordingly.
10959         (style_set_list): Move to file scope.
10960         (style_show_list): Likewise.
10961         (set_style): Call help_list.
10962         (show_style): Call cmd_show_list.
10963         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10964         Update to use the new macro.
10965
10966 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10967
10968         * ada-lang.c (_initialize_ada_language): Expand the help text
10969         for the "catch exception" command.
10970
10971 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10972
10973         * symtab.c (matching_obj_sections): Initialize obj,
10974         declare it closer to its usage.
10975
10976 2019-01-10  Tom Tromey  <tom@tromey.com>
10977
10978         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10979         (basic_inf_threads_range): Remove.
10980         (inf_threads_range, inf_non_exited_threads_range)
10981         (safe_inf_threads_range): Use next_adapter.
10982
10983 2019-01-10  Keith Seitz  <keiths@redhat.com>
10984
10985         PR gdb/23712
10986         PR symtab/23010
10987         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10988         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10989
10990 2019-01-10  Keith Seitz  <keiths@redhat.com>
10991
10992         PR gdb/23712
10993         PR symtab/23010
10994         * dictionary.c (pending_to_vector): Remove.
10995         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10996         Remove _1 suffix, replacing functions of the same name.  Update
10997         all callers.
10998         (dict_create_hashed, dict_create_hashed_expandable)
10999         (dict_create_linear, dict_create_linear_expandable, dict_free)
11000         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11001         Make functions static.
11002
11003 2019-01-10  Keith Seitz  <keiths@redhat.com>
11004
11005         PR gdb/23712
11006         PR symtab/23010
11007         * dictionary.h (struct dictionary): Replace declaration with
11008         multidictionary.
11009         (dict_create_hashed, dict_create_hashed_expandable)
11010         (dict_create_linear, dict_create_linear_expandable)
11011         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11012         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11013         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11014         taking multidictionary argument.
11015         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11016         * block.h (struct block) <dict>: Change to multidictionary
11017         and rename `multidict'.
11018         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11019         symmisc.c: Update all dictionary references to multidictionary.
11020
11021 2019-01-10  Keith Seitz  <keiths@redhat.com>
11022
11023         PR gdb/23712
11024         PR symtab/23010
11025         * dictionary.c: Include unordered_map.
11026         (pending_to_vector): New function.
11027         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11028         Rewrite the non-"_1" functions to take vector instead
11029         of linked list.
11030         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11031         "new" _1 versions of the same name.
11032         (multidictionary): Define.
11033         (std::hash<enum language): New definition.
11034         (collate_pending_symbols_by_language, mdict_create_hashed)
11035         (mdict_create_hashed_expandable, mdict_create_linear)
11036         (mdict_create_linear_expandable, mdict_free)
11037         (find_language_dictionary, create_new_language_dictionary)
11038         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11039         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11040         (mdict_size, mdict_empty): New functions.
11041         * dictionary.h (mdict_iterator): Define.
11042
11043 2019-01-10  Pedro Alves  <palves@redhat.com>
11044
11045         * breakpoint.c (read_uploaded_action)
11046         (create_tracepoint_from_upload): Adjust to use
11047         gdb::unique_xmalloc_ptr.
11048         * ctf.c (ctf_write_uploaded_tp):
11049         (SET_ARRAY_FIELD): Use emplace_back.
11050         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11051         * tracefile-tfile.c (tfile_write_uploaded_tp):
11052         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11053         gdb::unique_xmalloc_ptr.
11054         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11055         at_string, cond_string, cmd_strings>: Replace char pointers
11056         with gdb::unique_xmalloc_ptr.
11057
11058 2019-01-10  Pedro Alves  <palves@redhat.com>
11059
11060         * solib-target.c (library_list_start_library): Don't xstrdup name.
11061
11062 2019-01-10  Pedro Alves  <palves@redhat.com>
11063
11064         * mdebugread.c (parse_partial_symbols): Use
11065         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11066
11067 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11068
11069         * linux-fork.c (scoped_switch_fork_info)
11070         <~scoped_switch_fork_info>: Fix incorrect variable name.
11071
11072 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11073
11074         * linux-fork.c (scoped_switch_fork_info)
11075         <scoped_switch_fork_info>: Make explicit.
11076         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11077
11078 2019-01-10  Tom Tromey  <tom@tromey.com>
11079
11080         * objfiles.h (objfile::reset_psymtabs): Update.
11081         * objfiles.c (objfile::objfile): Update.
11082         * psymtab.h (psymtab_storage::obstack): Update.
11083         (psymtab_storage::m_obstack): Use gdb::optional.
11084         (class psymtab_storage): Update comment.  Remove objfile
11085         parameter.
11086         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11087
11088 2019-01-10  Tom Tromey  <tom@tromey.com>
11089
11090         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11091         <free_psymtabs>: Now private.
11092         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11093         (allocate_psymtab): Use new method.
11094
11095 2019-01-10  Tom Tromey  <tom@tromey.com>
11096
11097         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11098         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11099         * mdebugread.c (parse_partial_symbols): Use
11100         allocate_dependencies.
11101         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11102         allocate_dependencies.
11103         (process_psymtab_comp_unit_reader)
11104         (build_type_psymtab_dependencies): Likewise.
11105         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11106
11107 2019-01-10  Tom Tromey  <tom@tromey.com>
11108
11109         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11110         PSYMBOL_SET_LANGUAGE.
11111         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11112
11113 2019-01-10  Tom Tromey  <tom@tromey.com>
11114
11115         * psymtab.h (psymtab_storage::obstack): New method.
11116         <m_obstack>: Rename from obstack; now private.
11117         * psymtab.c (psymtab_storage): Update.
11118         * dwarf2read.c (create_addrmap_from_index)
11119         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11120         Update.
11121
11122 2019-01-10  Tom Tromey  <tom@tromey.com>
11123
11124         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11125         * objfiles.h (objfile::reset_psymtabs): New method.
11126
11127 2019-01-10  Tom Tromey  <tom@tromey.com>
11128
11129         * symmisc.c (print_symbol_bcache_statistics): Update.
11130         (print_objfile_statistics): Update.
11131         * symfile.c (reread_symbols): Update.
11132         * psymtab.h (class psymtab_storage): New.
11133         * psymtab.c (psymtab_storage): New constructor.
11134         (~psymtab_storage): New destructor.
11135         (require_partial_symbols): Update.
11136         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11137         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11138         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11139         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11140         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11141         (start_psymtab_common, end_psymtab_common)
11142         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11143         (allocate_psymtab): Update.
11144         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11145         Update.
11146         (dump_psymtab_addrmap, maintenance_print_psymbols)
11147         (maintenance_check_psymtabs): Update.
11148         (class objfile_psymtabs): Move to objfiles.h.
11149         * psympriv.h (discard_psymtab): Now inline.
11150         (psymtab_discarder::psymtab_discarder): Update.
11151         (psymtab_discarder::~psymtab_discarder): Update.
11152         (ALL_OBJFILE_PSYMTABS): Rewrite.
11153         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11154         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11155         Remove fields.
11156         <partial_symtabs>: New field.
11157         (class objfile_psymtabs): Move from psymtab.h.  Update.
11158         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11159         psymbol_cache.
11160         (objfile::~objfile): Don't destroy psymbol_cache.
11161         * mdebugread.c (parse_partial_symbols): Update.
11162         * dwarf2read.c (create_addrmap_from_index)
11163         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11164         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11165         (add_partial_subprogram, dwarf2_ranges_read): Update.
11166         * dwarf-index-write.c (write_address_map)
11167         (write_one_signatured_type, recursively_write_psymbols)
11168         (class debug_names, class debug_names, write_psymtabs_to_index):
11169         Update.
11170
11171 2019-01-10  Tom Tromey  <tom@tromey.com>
11172
11173         * symtab.h (SYMBOL_SET_NAMES): Update.
11174         (symbol_set_names): Update.
11175         (MSYMBOL_SET_NAMES): Update.
11176         * symtab.c (symbol_set_names): Change argument to be an
11177         objfile_per_bfd_storage.
11178         * psymtab.c (add_psymbol_to_bcache): Update.
11179         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11180
11181 2019-01-10  Tom Tromey  <tom@tromey.com>
11182
11183         * symtab.c (create_demangled_names_hash): Change argument to be an
11184         objfile_per_bfd_storage.
11185         (symbol_set_names): Update.
11186
11187 2019-01-10  Tom Tromey  <tom@tromey.com>
11188
11189         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11190         init_psymbol_list.
11191         * psymtab.c (init_psymbol_list): Do nothing if already called.
11192         * psympriv.h (init_psymbol_list): Add comment.
11193         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11194         init_psymbol_list.
11195         * dbxread.c (dbx_symfile_read): Unconditionally call
11196         init_psymbol_list.
11197
11198 2019-01-10  Tom Tromey  <tom@tromey.com>
11199
11200         * xcoffread.c (scan_xcoff_symtab): Update.
11201         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11202         "where".
11203         * mdebugread.c (parse_partial_symbols)
11204         (handle_psymbol_enumerators): Update.
11205         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11206         * dbxread.c (read_dbx_symtab): Update.
11207         * psympriv.h (psymbol_placement): New enum.
11208         (add_psymbol_to_list): Update.
11209
11210 2019-01-10  Tom Tromey  <tom@tromey.com>
11211
11212         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11213         static_psymbols parameters.
11214         (scan_xcoff_symtab): Update.
11215         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11216         static_psymbols parameters.
11217         * psympriv.h (start_psymtab_common): Update.
11218         * mdebugread.c (parse_partial_symbols): Update.
11219         * dwarf2read.c (create_partial_symtab): Update.
11220         * dbxread.c (read_dbx_symtab): Update.
11221         (start_psymtab): Remove global_psymbols and static_psymbols
11222         parameters.
11223
11224 2019-01-10  Tom Tromey  <tom@tromey.com>
11225
11226         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11227         * psymtab.c (allocate_psymtab): Add comment.
11228         * psympriv.h (allocate_psymtab): Add comment.
11229         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11230         initializations.
11231         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11232
11233 2019-01-10  Tom Tromey  <tom@tromey.com>
11234
11235         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11236         Don't declare.
11237         * mipsread.c: Include mdebugread.h.
11238         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11239         Declare.
11240         * elfread.c: Include mdebugread.h.
11241
11242 2019-01-09  Tom Tromey  <tom@tromey.com>
11243
11244         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11245         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11246         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11247         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11248         (psym_lookup_symbol, psym_find_last_source_symtab)
11249         (psym_forget_cached_source_info, psym_print_stats)
11250         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11251         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11252         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11253         (psym_find_compunit_symtab_by_address)
11254         (maintenance_print_psymbols, maintenance_info_psymtabs)
11255         (maintenance_check_psymtabs): Use ranged for.
11256         * psymtab.h (class objfile_psymtabs): New.
11257         (require_partial_symbols): Return objfile_psymtabs.
11258         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11259
11260 2019-01-09  Tom Tromey  <tom@tromey.com>
11261
11262         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11263         (find_pc_mapped_section, list_overlays_command)
11264         (map_overlay_command, unmap_overlay_command)
11265         (simple_overlay_update): Use all_objfiles.
11266         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11267         * printcmd.c (info_symbol_command): Use all_objfiles.
11268         * objfiles.h (ALL_OBJSECTIONS): Remove.
11269         * maint.c (maintenance_translate_address): Use all_objfiles.
11270         * gcore.c (gcore_create_callback): Use all_objfiles.
11271         (objfile_find_memory_regions): Likewise.
11272
11273 2019-01-09  Tom Tromey  <tom@tromey.com>
11274
11275         * symtab.c (find_line_symtab, info_sources_command)
11276         (make_source_files_completion_list): Use objfile_compunits.
11277         * source.c (select_source_symtab): Use objfile_compunits.
11278         * objfiles.h (struct objfile): Update comment.
11279         (ALL_OBJFILES): Remove.
11280         (ALL_FILETABS): Remove.
11281         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11282         objfile_compunits.
11283
11284 2019-01-09  Tom Tromey  <tom@tromey.com>
11285
11286         * symmisc.c (print_objfile_statistics, dump_objfile)
11287         (maintenance_print_symbols): Use compunit_filetabs.
11288         * source.c (forget_cached_source_info_for_objfile): Use
11289         compunit_filetabs.
11290         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11291         (ALL_FILETABS): Use compunit_filetabs.
11292         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11293         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11294
11295 2019-01-09  Tom Tromey  <tom@tromey.com>
11296
11297         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11298         (compunit_filetabs): New.
11299         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11300         compunit_filetabs.
11301         (info_sources_command, make_source_files_completion_list): Remove
11302         declaration.
11303         * symmisc.c (print_objfile_statistics, dump_objfile)
11304         (maintenance_print_symbols): Remove declaration.
11305         (maintenance_info_symtabs): Use compunit_filetabs.
11306         (maintenance_info_line_tables): Likewise.
11307         * source.c (select_source_symtab): Change local variable name.
11308         (forget_cached_source_info_for_objfile): Remove declaration.
11309         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11310         * objfiles.c (objfile_relocate1): Remove declaration.
11311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11312         declaration.
11313         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11314         * coffread.c (coff_symtab_read): Remove declaration.
11315         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11316         compunit_filetabs.
11317
11318 2019-01-09  Tom Tromey  <tom@tromey.com>
11319
11320         * symtab.c (lookup_objfile_from_block)
11321         (find_pc_sect_compunit_symtab, search_symbols)
11322         (default_collect_symbol_completion_matches_break_on): Use
11323         objfile_compunits.
11324         * objfiles.h (ALL_COMPUNITS): Remove.
11325         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11326         * cp-support.c (add_symbol_overload_list_qualified): Use
11327         objfile_compunits.
11328         * ada-lang.c (ada_collect_symbol_completion_matches)
11329         (ada_add_global_exceptions): Use objfile_compunits.
11330
11331 2019-01-09  Tom Tromey  <tom@tromey.com>
11332
11333         * source.c (select_source_symtab)
11334         (forget_cached_source_info_for_objfile): Remove declaration.
11335         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11336         declaration.
11337         * maint.c (count_symtabs_and_blocks): Remove declaration.
11338         * cp-support.c (add_symbol_overload_list_qualified): Remove
11339         declaration.
11340         * coffread.c (coff_symtab_read): Remove declaration.
11341         * symtab.c (lookup_symbol_in_objfile_symtabs)
11342         (basic_lookup_transparent_type_1): Use objfile_compunits.
11343         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11344         (info_sources_command, search_symbols)
11345         (default_collect_symbol_completion_matches_break_on)
11346         (make_source_files_completion_list): Remove declaration.
11347         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11348         (ada_collect_symbol_completion_matches)
11349         (ada_add_global_exceptions): Remove declaration.
11350         * linespec.c (iterate_over_all_matching_symtabs): Use
11351         objfile_compunits.
11352         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11353         (class objfile_compunits): New.
11354         (ALL_COMPUNITS): Use objfile_compunits.
11355         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11356         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11357         objfile_compunits.
11358         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11359
11360 2019-01-09  Tom Tromey  <tom@tromey.com>
11361
11362         * symtab.c (search_symbols)
11363         (default_collect_symbol_completion_matches_break_on): Use
11364         objfile_msymbols.
11365         * ada-lang.c (ada_lookup_simple_minsym)
11366         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11367         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11368         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11369         objfile_msymbols.
11370         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11371         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11372         * objc-lang.c (find_methods): Use objfile_msymbols.
11373         (info_selectors_command, info_classes_command): Likewise.
11374         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11375         * objfiles.h (class objfile_msymbols): New.
11376         (ALL_OBJFILE_MSYMBOLS): Remove.
11377         (ALL_MSYMBOLS): Remove.
11378
11379 2019-01-09  Tom Tromey  <tom@tromey.com>
11380
11381         * common/next-iterator.h (next_adapter): Add Iterator template
11382         parameter.
11383         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11384         (class all_objfiles_safe): New.
11385         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11386         * objfiles.c (put_objfile_before): Update comment.
11387         (add_separate_debug_objfile): Likewise.
11388         (free_all_objfiles): Use all_objfiles_safe.
11389         (objfile_purge_solibs): Likewise.
11390
11391 2019-01-09  Tom Tromey  <tom@tromey.com>
11392
11393         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11394         (expand_symtab_containing_pc, lookup_static_symbol)
11395         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11396         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11397         all_objfiles.
11398         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11399         * breakpoint.c (create_overlay_event_breakpoint)
11400         (create_longjmp_master_breakpoint)
11401         (create_std_terminate_master_breakpoint)
11402         (create_exception_master_breakpoint): Use all_objfiles.
11403         * linux-thread-db.c (try_thread_db_load_from_pdir)
11404         (has_libpthread): Use all_objfiles.
11405         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11406         * linespec.c (iterate_over_all_matching_symtabs)
11407         (search_minsyms_for_name): Use all_objfiles.
11408         * maint.c (maintenance_info_sections): Use all_objfiles.
11409         * main.c (captured_main_1): Use all_objfiles.
11410         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11411         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11412         * guile/scm-pretty-print.c
11413         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11414         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11415         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11416         (maintenance_print_msymbols): Use all_objfiles.
11417         * source.c (select_source_symtab): Use all_objfiles.
11418         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11419         * symfile.c (remove_symbol_file_command)
11420         (expand_symtabs_matching, map_symbol_filenames): Use
11421         all_objfiles.
11422         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11423         all_objfiles.
11424         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11425         * objc-lang.c (find_methods): Use all_objfiles.
11426         * objfiles.c (have_partial_symbols, have_full_symbols)
11427         (have_minimal_symbols, qsort_cmp)
11428         (default_iterate_over_objfiles_in_search_order): Use
11429         all_objfiles.
11430         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11431         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11432         (maintenance_check_psymtabs): Use all_objfiles.
11433         (ALL_PSYMTABS): Remove.
11434         * compile/compile-object-run.c (do_module_cleanup): Use
11435         all_objfiles.
11436         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11437         * cp-support.c (add_symbol_overload_list_qualified): Use
11438         all_objfiles.
11439         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11440         Use all_objfiles.
11441         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11442         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11443         all_objfiles.
11444         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11445         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11446         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11447         Uses all_objfiles.
11448         * solib.c (solib_read_symbols): Use all_objfiles
11449
11450 2019-01-09  Tom Tromey  <tom@tromey.com>
11451
11452         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11453         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11454         all_objfiles.
11455         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11456         * symmisc.c (print_symbol_bcache_statistics)
11457         (print_objfile_statistics, maintenance_print_objfiles)
11458         (maintenance_info_symtabs, maintenance_check_symtabs)
11459         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11460         all_objfiles.
11461         * source.c (forget_cached_source_info): Use all_objfiles.
11462         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11463         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11464         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11465         * objfiles.c (update_section_map): Use all_objfiles.
11466         (shared_objfile_contains_address_p): Likewise.
11467         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11468         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11469
11470 2019-01-09  Tom Tromey  <tom@tromey.com>
11471
11472         * common/next-iterator.h: New file.
11473         * objfiles.h (class all_objfiles): New.
11474         (struct objfile_iterator): New.
11475
11476 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11477
11478         * NEWS: Move the description of the changed "frame", "select-frame",
11479          and "info frame" commands to the Changed commands section.
11480
11481 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11482
11483         * gdbtypes.c (check_stub_method_group): Remove handling of old
11484         mangling schemes.
11485         * linespec.c (find_methods): Likewise.
11486         * stabsread.c (read_member_functions): Likewise.
11487         * valops.c (search_struct_method): Likewise.
11488         (value_struct_elt_for_reference): Likewise.
11489         * NEWS: Mention this change.
11490
11491 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11492
11493         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11494         print_source_lines.
11495         * source.c (print_source_lines_base): Update line number check.
11496         (print_source_lines): New function.
11497         (source_lines_range::source_lines_range): New function.
11498         * source.h (class source_lines_range): New class.
11499         (print_source_lines): New declaration.
11500
11501 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11502
11503         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11504
11505 2019-01-08  Tom Tromey  <tom@tromey.com>
11506             Simon Marchi  <simon.marchi@ericsson.com>
11507
11508         PR gdb/24060
11509         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11510         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11511         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11512         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11513         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11514         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11515
11516 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11517
11518         * source.c (select_source_symtab): Move header comment to
11519         declaration in source.h.
11520         (forget_cached_source_info_for_objfile): Likewise.
11521         (forget_cached_source_info): Likewise.
11522         (identify_source_line): Likewise.
11523         * source.h (identify_source_line): Move declaration from symtab.h
11524         and add comment from source.c
11525         (print_source_lines): Likewise.
11526         (forget_cached_source_info_for_objfile): Likewise.
11527         (forget_cached_source_info): Likewise.
11528         (select_source_symtab): Likewise.
11529         (enum print_source_lines_flag): Move definition from symtab.h.
11530         * symtab.h (identify_source_line): Move declaration to source.h.
11531         (print_source_lines): Likewise.
11532         (forget_cached_source_info_for_objfile): Likewise.
11533         (forget_cached_source_info): Likewise.
11534         (select_source_symtab): Likewise.
11535         (enum print_source_lines_flag): Move definition to source.h.
11536         * tui/tui-hooks.c: Add 'source.h' include.
11537
11538 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11539
11540         * source.c (print_source_lines_base): Handle requests to print
11541         reverse line number sequences, and guard against empty lines
11542         string.
11543
11544 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11545
11546         * source.c (print_source_lines_base): Fix skip of '\r' if next
11547         character is '\n'.
11548
11549 2019-01-06  Tom Tromey  <tom@tromey.com>
11550
11551         * c-exp.y (struct c_parse_state) <macro_original_text,
11552         expansion_obstack>: New member.
11553         (macro_original_text, expansion_obstack): Remove globals.
11554         (scan_macro_expansion, scanning_macro_expansion)
11555         (finished_macro_expansion): Update.
11556         (scan_macro_cleanup): Remove.
11557         (yylex, c_parse): Update.
11558
11559 2019-01-06  Tom Tromey  <tom@tromey.com>
11560
11561         * c-exp.y (struct c_parse_state) <strings>: New member.
11562         (operator_stoken): Update.
11563
11564 2019-01-06  Tom Tromey  <tom@tromey.com>
11565
11566         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11567         (union type_stack_elt) <typelist_val>: Now a pointer to
11568         std::vector.
11569         (type_stack_cleanup): Don't declare.
11570         (push_typelist): Update.
11571         * parse.c (pop_typelist): Return a std::vector.
11572         (push_typelist): Take a std::vector.
11573         (follow_types): Update.  Do not free args.
11574         (type_stack_cleanup): Remove.
11575         * c-exp.y (struct c_parse_state): New.
11576         (cpstate): New global.
11577         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11578         (nonempty_typelist): Update.
11579         (func_mod): Create a new vector.
11580         (c_parse): Create a c_parse_state.
11581         (check_parameter_typelist): Do not delete params.
11582         (function_method): Update.  Do not delete type_list.
11583
11584 2019-01-06  Tom Tromey  <tom@tromey.com>
11585
11586         PR gdb/28155:
11587         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11588         check_typedef.
11589         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11590         (print_return_value): Likewise.
11591
11592 2019-01-05  Tom Tromey  <tom@tromey.com>
11593
11594         * contrib/cleanup_check.py: Remove.
11595         * contrib/gcc-with-excheck: Remove.
11596         * contrib/exsummary.py: Remove.
11597         * contrib/excheck.py: Remove.
11598
11599 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11600
11601         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11602         NULL. Initialize tpprev to NULL instead of assigning it
11603         to NULL on the next statement.
11604         * windows-nat.c (windows_delete_thread): Remove check for
11605         main_thread_id before printing thread exit notifications.
11606         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11607         Remove thread ID check against main_thread_id.
11608         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11609         windows_delete_thread.
11610         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11611
11612 2019-01-04  Tom Tromey  <tom@tromey.com>
11613
11614         * compile/compile.c (_initialize_compile): Use upper case for
11615         metasyntactic variables.
11616         * symmisc.c (_initialize_symmisc): Use upper case for
11617         metasyntactic variables.
11618         * psymtab.c (_initialize_psymtab): Use upper case for
11619         metasyntactic variables.
11620         * demangle.c (demangle_command): Use upper case for metasyntactic
11621         variables.
11622         (_initialize_demangler): Likewise.
11623         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11624         variables.
11625
11626 2019-01-03  Tom Tromey  <tom@tromey.com>
11627
11628         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11629
11630 2019-01-03  Tom Tromey  <tom@tromey.com>
11631
11632         * python/py-symtab.c (salpy_str): Update.
11633         (struct salpy_sal_object) <symtab>: Now a PyObject.
11634         (salpy_dealloc): Update.
11635         (del_objfile_sal): Use gdbpy_ref.
11636
11637 2019-01-03  Tom Tromey  <tom@tromey.com>
11638
11639         * python/py-type.c (convert_field): Use new_reference.  Return
11640         gdbpy_ref.
11641         (make_fielditem): Return gdbpy_ref.
11642         (typy_fields): Update.
11643         (typy_getitem): Update.
11644         (field_name): Return gdbpy_ref.  Use new_reference.
11645         (typy_iterator_iternext): Update.
11646
11647 2019-01-03  Tom Tromey  <tom@tromey.com>
11648
11649         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11650
11651 2019-01-03  Tom Tromey  <tom@tromey.com>
11652
11653         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11654         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11655         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11656         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11657         (pspy_set_type_printers): Likewise.
11658         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11659         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11660         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11661         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11662         (objfpy_set_type_printers): Likewise.
11663
11664 2019-01-03  Tom Tromey  <tom@tromey.com>
11665
11666         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11667         (gdbpy_print_stack): Use gdbpy_err_fetch.
11668         * python/python-internal.h (class gdbpy_err_fetch): New class.
11669         (class gdbpy_enter) <m_error_type, m_error_value,
11670         m_error_traceback>: Remove.
11671         <m_error>: New member.
11672         (gdbpy_exception_to_string): Don't declare.
11673         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11674         * python/py-value.c (convert_value_from_python): Use
11675         gdbpy_err_fetch.
11676         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11677         gdbpy_exception_to_string.
11678         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11679         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11680         gdbpy_err_fetch.
11681
11682 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11683
11684         * linux-nat.c (delete_lwp_cleanup): Delete.
11685         (struct lwp_deleter): New struct.
11686         (lwp_info_up): New typedef.
11687         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11688         lwp_info_up.
11689
11690 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11691
11692         * linux-fork.c (class scoped_switch_fork_info): New class.
11693         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11694
11695 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11696
11697         * valops.c (find_overload_match): Remove use of null_cleanup, and
11698         calls to do_cleanups.
11699
11700 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11701
11702         * compile/compile-cplus-types.c
11703         (compile_cplus_instance::decl_name): Handle changes to
11704         cp_func_name.
11705         * cp-support.c (cp_func_name): Update header comment, update
11706         return type.
11707         * cp-support.h (cp_func_name): Update return type in declaration.
11708         * valops.c (find_overload_match): Move temp_func local to top
11709         level of function and change its type.  Use temp_func to hold and
11710         delete temporary string obtained from cp_func_name.
11711
11712 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11713
11714         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11715         gdb::char_vector, remove cleanup, and update uses of `msg`.
11716
11717 2019-01-03  Jim Wilson  <jimw@sifive.com>
11718
11719         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11720
11721 2019-01-02  Tom Tromey  <tom@tromey.com>
11722
11723         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11724         (tdesc_parse_xml): Remove cleanups.
11725         * target-descriptions.h (make_cleanup_free_target_description):
11726         Don't declare.
11727         (target_desc_deleter): New struct.
11728         (target_desc_up): New typedef.
11729         * target-descriptions.c (target_desc_deleter::operator()): Rename
11730         from free_target_description.
11731         (make_cleanup_free_target_description): Remove.
11732
11733 2019-01-02  Tom Tromey  <tom@tromey.com>
11734
11735         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11736         constructor, destructor.
11737         (linespec_parser): Remove typedef.
11738         (~linespec_parser): Rename from linespec_parser_delete.
11739         (linespec_lex_to_end, linespec_complete_label)
11740         (linespec_complete): Update.
11741         (decode_line_full): Remove cleanups.
11742         (decode_line_1): Update.
11743
11744 2019-01-02  Tom Tromey  <tom@tromey.com>
11745
11746         * python/python-internal.h (inferior_to_inferior_object): Change
11747         return type.
11748         * python/py-exitedevent.c (create_exited_event_object): Update.
11749         * python/py-inferior.c (inferior_to_inferior_object): Return
11750         gdbpy_ref.
11751         (python_new_inferior, python_inferior_deleted)
11752         (thread_to_thread_object, delete_thread_object)
11753         (build_inferior_list, gdbpy_selected_inferior): Update.
11754         * python/py-infthread.c (create_thread_object): Update.  Also fail
11755         if inferior_to_inferior_object fails.
11756
11757 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11758
11759         * inferior.h (class inferior) <displaced_step_state>: New field.
11760         * infrun.h (struct displaced_step_state): Move here from
11761         infrun.c.  Initialize fields, add constructor.
11762         <inf>: Remove field.
11763         <reset>: New method.
11764         * infrun.c (struct displaced_step_inferior_state): Move to
11765         infrun.h.
11766         (displaced_step_inferior_states): Remove.
11767         (get_displaced_stepping_state): Adust.
11768         (displaced_step_in_progress_any_inferior): Adjust.
11769         (displaced_step_in_progress_thread): Adjust.
11770         (displaced_step_in_progress): Adjust.
11771         (add_displaced_stepping_state): Remove.
11772         (get_displaced_step_closure_by_addr): Adjust.
11773         (remove_displaced_stepping_state): Remove.
11774         (infrun_inferior_exit): Call displaced_step_state.reset.
11775         (use_displaced_stepping): Don't check for NULL.
11776         (displaced_step_prepare_throw): Call
11777         get_displaced_stepping_state.
11778         (displaced_step_fixup): Don't check for NULL.
11779         (prepare_for_detach): Don't check for NULL.
11780
11781 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11782
11783         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11784          in case of call that did not complete.
11785
11786 2019-01-02  Andrey Utkin  <autkin@undo.io>
11787
11788         * symfile.c (find_separate_debug_file): Fix search of debug files for
11789         remote debuggee.
11790
11791 2019-01-02  Tom Tromey  <tom@tromey.com>
11792
11793         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11794         indentation.
11795         * python/py-frame.c (frapy_older): Remove cast.
11796         (frapy_newer): Likewise.
11797         * python/py-breakpoint.c (local_setattro): Remove cast.
11798         * python/py-arch.c (archpy_name): Remove local variable.
11799         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11800
11801 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11802
11803         * unittests/basic_string_view/element_access/char/empty.cc:
11804         Fix year range in copyright header.
11805
11806 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11807
11808         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11809         Delete.
11810         <operator==>: Update with for removed field.
11811         <hash>: Likewise.
11812         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11813         <isa_features>: ...this.
11814         <abi_features>: New field.
11815         (riscv_isa_flen): Update comment.
11816         (riscv_abi_xlen): New declaration.
11817         (riscv_abi_flen): New declaration.
11818         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11819         isa_features.
11820         (riscv_abi_xlen): New function.
11821         (riscv_isa_flen): Update to get answer from isa_features.
11822         (riscv_abi_flen): New function.
11823         (riscv_has_fp_abi): Update to get answer from abi_features.
11824         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11825         xlen and flen.
11826         (riscv_call_info) <xlen, flen>: Update comment.
11827         (riscv_call_arg_struct): Remove invalid assertions
11828         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11829         is removed.
11830         (riscv_gdbarch_init): Gather isa features and abi features
11831         separately, ensure both match on the gdbarch when reusing an old
11832         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11833         a target with 64-bit float hardware.
11834
11835 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11836
11837         * source.c (search_command_helper): Stop reverse search
11838         when line 1 has been searched.
11839
11840 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11841
11842         * record-full.c (record_full_base_target::close): Rewrite
11843         record_full_core_buf_list free logic.
11844
11845 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11846
11847         * break-catch-syscall.c (print_one_catch_syscall): xfree
11848         the last text.
11849
11850 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11851
11852         * top.c (print_gdb_version): Update Copyright year in version
11853         message.
11854
11855 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11856
11857         Update copyright year range in all GDB files.
11858
11859 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11860
11861         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11862
11863 For older changes see ChangeLog-2018.
11864 \f
11865 Local Variables:
11866 mode: change-log
11867 left-margin: 8
11868 fill-column: 74
11869 version-control: never
11870 coding: utf-8
11871 End:
11872