gdb/ChangeLog

   1 2019-12-04  Tom Tromey  <tom@tromey.com>
   2
   3         * valprint.c (val_print_string): Use metadata_style.
   4         * go-valprint.c (print_go_string): Use metadata style.
   5         * p-valprint.c (pascal_object_print_static_field): Use metadata
   6         style.
   7         * cp-valprint.c (cp_print_static_field): Use metadata style.
   8
   9 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
  10             Chris January  <chris.january@arm.com>
  11
  12         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
  13         tokens.
  14         (typebase): New patterns for complex, single/double precision, and
  15         single/double complex.
  16         (f77_keywords): Change token for complex keyword, and add single,
  17         double, and precision keywords.
  18
  19 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
  20
  21         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
  22         "info io_registers".
  23
  24 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
  25
  26         * regcache.c (cooked_read_test): Initialize thread list of
  27         mock_inferior.
  28
  29 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
  30
  31         * aarch64-linux-tdep.c: Remove includes.
  32
  33 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
  34
  35         * aarch64-tdep.c: Remove includes.
  36
  37 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
  38
  39         * filtered-iterator.h (filtered_iterator) <operator==,
  40         operator!=>: Compare wrapped iterators, not wrapped pointers.
  41         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  42         unittests/filtered_iterator-selftests.c.
  43         * unittests/filtered_iterator-selftests.c: New file.
  44
  45 2019-12-04  Tom Tromey  <tromey@adacore.com>
  46
  47         * gdbtypes.c (create_range_type): Inherit endianity
  48         from base type.
  49
  50 2019-12-04  Tom Tromey  <tromey@adacore.com>
  51
  52         * ada-lang.c (decode_constrained_packed_array)
  53         (ada_value_assign, value_assign_to_component): Update.
  54         * dwarf2loc.c (rw_pieced_value, access_memory)
  55         (dwarf2_compile_expr_to_ax): Update.
  56         * dwarf2read.c (dwarf2_add_field): Update.
  57         * eval.c (evaluate_subexp_standard): Update.
  58         * gdbarch.c, gdbarch.h: Rebuild.
  59         * gdbarch.sh (bits_big_endian): Remove.
  60         * gdbtypes.h (union field_location): Update comment.
  61         * target-descriptions.c (make_gdb_type): Update.
  62         * valarith.c (value_bit_index): Update.
  63         * value.c (struct value) <bitpos>: Update comment.
  64         (unpack_bits_as_long, modify_field): Update.
  65         * value.h (value_bitpos): Update comment.
  66
  67 2019-12-04  Tom Tromey  <tromey@adacore.com>
  68
  69         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
  70         endian-ness.
  71
  72 2019-12-04  Tom Tromey  <tromey@adacore.com>
  73
  74         * dwarf2read.c (dwarf2_init_float_type)
  75         (dwarf2_init_complex_target_type): Add byte_order parameter.
  76         (read_base_type): Compute byte order earlier.
  77         * gdbtypes.c (init_float_type): Add byte_order parameter.
  78         * gdbtypes.h (init_float_type): Add byte_order parameter.
  79
  80 2019-12-04  Tom Tromey  <tromey@adacore.com>
  81
  82         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
  83
  84 2019-12-04  Tom Tromey  <tromey@adacore.com>
  85
  86         * dwarf2read.c (process_structure_scope): Initialize
  87         "discr_offset".
  88
  89 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
  90
  91         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
  92         add it into the search spec.
  93         (parse_max_results_option): New function.
  94         (mi_info_functions_or_variables): Parse -max-results flag and pass
  95         it to mi_symbol_info.
  96         (mi_cmd_symbol_info_modules): Likewise.
  97         (mi_cmd_symbol_info_types): Likewise.
  98         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
  99         return type to bool, change result container into a set, and don't
 100         add new results if we have enough already.
 101         (global_symbol_searcher::add_matching_msymbols): Change return
 102         type to bool, and don't add new results if we have enough already.
 103         (sort_search_symbols_remove_dups): Delete.
 104         (global_symbol_searcher::search): Early exit from search loop when
 105         we have enough results.  Use a std::set to collect the results
 106         from calling add_matching_symbols.
 107         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 108         member function.
 109         (global_symbol_searcher) <m_max_search_results>: New member
 110         variable.
 111         (global_symbol_searcher) <add_matching_symbols>: Update header
 112         comment and change return type to bool.
 113         (global_symbol_searcher) <add_matching_msymbols>: Update header
 114         comment and change return type to bool.
 115
 116 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * symtab.c (symbol_search::compare_search_syms): Update header
 119         comment.
 120         (global_symbol_searcher::is_suitable_msymbol): New function.
 121         (global_symbol_searcher::expand_symtabs): New function.
 122         (global_symbol_searcher::add_matching_symbols): New function.
 123         (global_symbol_searcher::add_matching_msymbols): New function.
 124         (global_symbol_searcher::search): Move most of the content
 125         into the new functions above, and call them as needed.
 126         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 127         function.
 128         (global_symbol_searcher) <add_matching_symbols>: New member
 129         function.
 130         (global_symbol_searcher) <add_matching_msymbols>: New member
 131         function.
 132         (global_symbol_searcher) <is_suitable_msymbol>: New member
 133         function.
 134
 135 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 136
 137         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 138         -symbol-info-module-variables entries.
 139         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 140         (mi_cmd_symbol_info_module_variables): Declare.
 141         * mi/mi-symbol-cmds.c
 142         (module_symbol_search_iterator): New typedef.
 143         (output_module_symbols_in_single_module_and_file): New function.
 144         (output_module_symbols_in_single_module): New function.
 145         (mi_info_module_functions_or_variables): New function.
 146         (mi_cmd_symbol_info_module_functions): New function.
 147         (mi_cmd_symbol_info_module_variables): New function.
 148         * NEWS: Mention new MI command.
 149
 150 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 151
 152         * bcache.c (hash): Remove.
 153         (hash_continue): Remove.
 154         * bcache.h (hash): Remove.
 155         (hash_continue): Remove.
 156         (struct bcache) <ctor>: Update.
 157         * psymtab.c (psymbol_hash): Update.
 158         * stabsread.c (hashname): Update.
 159         * utils.h (fast_hash): Add an argument for a start value,
 160         defaulting to zero.
 161
 162 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 163         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 164         (destroy_block_symbol_cache): New function.
 165         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 166         (resize_symbol_cache): Likewise.
 167
 168 2019-12-02  Tom Tromey  <tom@tromey.com>
 169
 170         * unittests/tui-selftests.c (run_tests): Make conditional.
 171         (_initialize_tui_selftest): Make conditional.
 172
 173 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * aix-thread.c (debug_aix_thread): Change type to bool.
 176
 177 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 178
 179         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 180
 181 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 182
 183         * dwarf2read.c (read_tag_string_type): Read the fields required to
 184         make a dynamic string, and possibly create a dynamic range for the
 185         string.
 186         (attr_to_dynamic_prop): Setup is_reference based on the type of
 187         attribute being processed.
 188         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 189         (resolve_dynamic_array): Rename to...
 190         (resolve_dynamic_array_or_string): ...this, update header comment,
 191         and accept TYPE_CODE_STRING.
 192         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 193
 194 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 195
 196         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 197         of its implementation from...
 198         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 199         the new function.
 200
 201 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 202
 203         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 204         create a range with stride where appropriate.
 205         * f-valprint.c: Include 'gdbarch.h'.
 206         (f77_print_array_1): Take the stride into account when walking the
 207         array.  Also convert the stride into addressable units.
 208         * gdbtypes.c (create_range_type): Initialise the stride to
 209         constant zero.
 210         (create_range_type_with_stride): New function, initialise the
 211         range as normal, and then setup the stride.
 212         (has_static_range): Include the stride here.  Also change the
 213         return type to bool.
 214         (create_array_type_with_stride): Consider the range stride if the
 215         array isn't given its own stride.
 216         (resolve_dynamic_range): Resolve the stride if needed.
 217         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 218         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 219         (TYPE_BIT_STRIDE): Define.
 220         (TYPE_ARRAY_BIT_STRIDE): Define.
 221         (create_range_type_with_stride): Declare.
 222         * valarith.c (value_subscripted_rvalue): Take range stride into
 223         account when walking the array.
 224
 225 2019-12-01  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 228         specially.
 229
 230 2019-12-01  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 233         \0.
 234         * unittests/tui-selftests.c: New file.
 235         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 236
 237 2019-12-01  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 240
 241 2019-12-01  Tom Tromey  <tom@tromey.com>
 242
 243         * NEWS: Document new settings.
 244         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 245         * tui/tui-win.c (_initialize_tui_win): Add border style
 246         observers.
 247         * tui/tui-io.h (tui_apply_style): Declare.
 248         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 249         longer static.
 250         (apply_ansi_escape, tui_set_reverse_mode): Update.
 251         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 252         Add "skip_intensity" parameter.
 253         <changed>: New member.
 254         <do_set_value>: Declare.
 255         (tui_border_style, tui_active_border_style): Declare.
 256         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 257         globals.
 258         (cli_style_option): Initialize "changed".
 259         (cli_style_option::do_set_value): New function.
 260         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 261         parameter.  Update.
 262         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 263         (_initialize_cli_style): Update.  Create TUI border style
 264         commands.
 265
 266 2019-12-01  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 269         parameter.
 270         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 271         parameter.
 272         * tui/tui-win.h (compact_source): Declare.
 273         * tui/tui-win.c (compact_source): New global.
 274         (tui_set_compact_source, tui_show_compact_source): New functions.
 275         (_initialize_tui_win): Add "compact-source" setting.
 276         * tui/tui-source.c (tui_source_window::set_contents): Handle
 277         compact_source setting.
 278         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 279         * NEWS: Document new setting.
 280
 281 2019-11-30  Tom Tromey  <tom@tromey.com>
 282
 283         * dwarf2read.c (dwarf2_add_field): Include field offset when
 284         computing variant part length.
 285
 286 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 287         * NEWS:  Mention define-prefix.  Tell that command names can now
 288         contain a . character.
 289
 290 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 291
 292         * command.h (valid_cmd_char_p): Declare.
 293         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 294         the check of valid command char.
 295         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 296         valid_cmd_char_p.
 297         * cli/cli-script.c (validate_comname): Likewise.
 298         * completer.c (gdb_completer_command_word_break_characters):
 299         Do not remove . from the word break char, update comments.
 300         (complete_line_internal_1): Use valid_cmd_char_p.
 301         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 302         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 303
 304 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 305
 306         * cli/cli-script.c (do_define_command): Ensure a redefined
 307         prefix command is kept as a prefix command.
 308         (define_prefix_command): New function.
 309         (show_user_1): Report user defined prefixes.
 310         (_initialize_cli_script):  Create the new 'define-prefix' command.
 311         Add completers for 'define' and 'document'.
 312         * top.c (execute_command):  If command is a user-defined prefix only
 313         command, report the list of commands for this prefix command.
 314
 315 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 316
 317         * valops.c (find_oload_champ): Improve debug output.
 318
 319 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 320
 321         * valops.c (find_oload_champ): Print part of debug messages
 322         before the badness vector is std::move'd.
 323
 324 2019-11-28  Tom Tromey  <tom@tromey.com>
 325
 326         * value.c (creal_internal_fn): Fix comment.
 327
 328 2019-11-28  Tom Tromey  <tom@tromey.com>
 329
 330         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 331         flag_bound_evaluated>: Now unsigned.
 332
 333 2019-11-28  Tom Tromey  <tom@tromey.com>
 334
 335         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 336         declare.
 337
 338 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 339
 340         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 341         debug output.
 342         * jit.c (jit_unregister_code): Add debug print to match
 343         `jit_register_code`.
 344
 345 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 346
 347         * NEWS: Mention the new multithreaded symbol loading.
 348
 349 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 350
 351         * maint.c (n_worker_threads): Default to 0.
 352         (worker_threads_disabled): New function.
 353         * maint.h (worker_threads_disabled): New function.
 354         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 355         here if worker_threads_disabled () is true.
 356         (minimal_symbol_reader::install): Skip all threading if
 357         worker_threads_disabled () is true.
 358
 359 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 360
 361         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 362         hash code if possible.
 363         (add_minsym_to_demangled_hash_table): Likewise.
 364         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 365         on the background thread.
 366         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 367         Add these fields.
 368
 369 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 370
 371         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 372         of the mangled name on the background thread.
 373         * symtab.c (symbol_set_names): Allow passing in the hash of the
 374         linkage_name.
 375         * symtab.h (symbol_set_names): Likewise.
 376
 377 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 378
 379         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 380         physnames are computed for inherited DIEs.
 381
 382 2019-11-27  Tom Tromey  <tromey@adacore.com>
 383
 384         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 385         backslashes.
 386         * cp-support.c: Remove unnecessary backslashes.
 387
 388 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 389
 390         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 391         with sym->set_linkage_name.
 392         * coffread.c (coff_read_enum_type): Likewise.
 393         * mdebugread.c (parse_symbol): Likewise.
 394         * stabsread.c (patch_block_stabs): Likewise.
 395         (define_symbol): Likewise.
 396         (read_enum_type): Likewise.
 397         (common_block_end): Likewise.
 398         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 399         function.
 400         (SYMBOL_SET_LINKAGE_NAME): Remove.
 401         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 402         with sym->set_linkage_name.
 403
 404 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 407         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 408         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 409         * NEWS: Mention new MI command.
 410
 411 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 412
 413         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 414         '-symbol-info-types', and '-symbol-info-variables'.
 415         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 416         (mi_cmd_symbol_info_types): Declare.
 417         (mi_cmd_symbol_info_variables): Declare.
 418         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 419         (output_debug_symbol): New function.
 420         (output_nondebug_symbol): New function.
 421         (mi_symbol_info): New function.
 422         (mi_info_functions_or_variables): New function.
 423         (mi_cmd_symbol_info_functions): New function.
 424         (mi_cmd_symbol_info_types): New function.
 425         (mi_cmd_symbol_info_variables): New function.
 426         * NEWS: Mention new commands.
 427
 428 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 429
 430         * symtab.c (symbol_to_info_string): New function, most content
 431         moved from print_symbol_info, but updated to return a std::string.
 432         (print_symbol_info): Update to use symbol_to_info_string and print
 433         returned string.
 434         * symtab.h (symbol_to_info_string): Declare new function.
 435
 436 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         * python/python.c (gdbpy_rbreak): Convert to using
 439         global_symbol_searcher.
 440         * symtab.c (file_matches): Convert return type to bool, change
 441         file list to std::vector, update header comment.
 442         (search_symbols): Rename to...
 443         (global_symbol_searcher::search): ...this and update now its
 444         a member function of global_symbol_searcher.  Take account of the
 445         changes to file_matches.
 446         (symtab_symbol_info): Convert to using global_symbol_searcher.
 447         (rbreak_command): Likewise.
 448         (search_module_symbols): Likewise.
 449         * symtab.h (enum symbol_search): Update comment.
 450         (search_symbols): Remove declaration.
 451         (class global_symbol_searcher): New class.
 452
 453 2019-11-26  Tom Tromey  <tromey@adacore.com>
 454
 455         * cp-support.c (_initialize_cp_support): Conditionally initialize
 456         gdb_demangle_attempt_core_dump.
 457
 458 2019-11-26  Tom Tromey  <tom@tromey.com>
 459
 460         * python/py-function.c (fnpy_init): Update.
 461         * value.h (add_internal_function): Adjust declaration.
 462         * value.c (function_destroyer): Remove.
 463         (do_add_internal_function): Don't set destroyer or copy name.
 464         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 465         Set name_allocated.
 466         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 467         (cmdpy_init): Set name_allocated.
 468         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 469         member.
 470         (~cmd_list_element): Free "name" if needed.
 471
 472 2019-11-26  Tom Tromey  <tom@tromey.com>
 473
 474         * value.h (add_internal_function): Add new overload.  Move
 475         documentation from value.h.
 476         * value.c (do_add_internal_function): New function.
 477         (add_internal_function): Use it.  Add new overload.
 478         (function_destroyer): Don't free doc.
 479         * python/py-function.c (fnpy_init): Update.
 480
 481 2019-11-26  Tom Tromey  <tom@tromey.com>
 482
 483         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 484         (cmdpy_init): Set "doc_allocated".
 485
 486 2019-11-26  Tom Tromey  <tom@tromey.com>
 487
 488         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 489         name of worker thread.
 490         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 491         pthread_setname_np.
 492         * configure, config.in: Rebuild.
 493
 494 2019-11-26  Tom Tromey  <tom@tromey.com>
 495
 496         * python/python.c (class gdbpy_gil): New.
 497         (struct gdbpy_event): Add constructor, destructor, operator().
 498         (gdbpy_post_event): Use run_on_main_thread.
 499         (gdbpy_initialize_events): Remove.
 500         (do_start_initialization): Update.
 501
 502 2019-11-26  Tom Tromey  <tom@tromey.com>
 503
 504         * NEWS: Add entry.
 505         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 506         commands.  Call update_thread_pool_size.
 507         (update_thread_pool_size, maintenance_set_worker_threads): New
 508         functions.
 509         (n_worker_threads): New global.
 510
 511 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 512             Tom Tromey  <tom@tromey.com>
 513
 514         * minsyms.c (minimal_symbol_reader::install): Use
 515         parallel_for_each.
 516         * gdbsupport/parallel-for.h: New file.
 517         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 518
 519 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 520             Tom Tromey  <tom@tromey.com>
 521
 522         * gdbsupport/thread-pool.h: New file.
 523         * gdbsupport/thread-pool.c: New file.
 524         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 525         (HFILES_NO_SRCDIR): Add thread-pool.h.
 526
 527 2019-11-26  Tom Tromey  <tom@tromey.com>
 528
 529         * event-top.h (thread_local_segv_handler): Declare.
 530         * event-top.c (thread_local_segv_handler): New global.
 531         (install_handle_sigsegv, handle_sigsegv): New functions.
 532         (async_init_signals): Install SIGSEGV handler.
 533         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 534         thread-local.
 535         (report_failed_demangle): New function.
 536         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 537         handler-setting code, instead use segv_handler.  Run warning code
 538         on main thread.
 539
 540 2019-11-26  Tom Tromey  <tom@tromey.com>
 541
 542         * run-on-main-thread.c: New file.
 543         * run-on-main-thread.h: New file.
 544         * unittests/main-thread-selftests.c: New file.
 545         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 546         main-thread-selftests.c.
 547         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 548         (COMMON_SFILES): Add run-on-main-thread.c.
 549
 550 2019-11-26  Tom Tromey  <tom@tromey.com>
 551
 552         * main.c (setup_alternate_signal_stack): Remove.
 553         (captured_main_1): Use gdb::alternate_signal_stack.
 554         * gdbsupport/alt-stack.h: New file.
 555
 556 2019-11-26  Tom Tromey  <tom@tromey.com>
 557
 558         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 559         Remove comment.
 560         (save_original_signals_state, restore_original_signals_state): Use
 561         gdb_sigmask.
 562         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 563         (_initialize_linux_nat): Use gdb_sigmask.
 564         * guile/guile.c (_initialize_guile): Use block_signals.
 565         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 566         * gdbsupport/gdb-sigmask.h: New file.
 567         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 568         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 569         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 570         pthread_sigmask.
 571         * configure, config.in: Rebuild.
 572         * gdbsupport/block-signals.h: New file.
 573
 574 2019-11-26  Tom Tromey  <tom@tromey.com>
 575
 576         * acinclude.m4: Include ax_pthread.m4.
 577         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 578         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 579         (CLIBS): Use PTHREAD_LIBS.
 580         (aclocal_m4_deps): Add ax_pthread.m4.
 581         * config.in, configure: Rebuild.
 582         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 583
 584 2019-11-26  Tom Tromey  <tom@tromey.com>
 585
 586         * symtab.h (struct minimal_symbol) <name_set>: New member.
 587         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 588         Don't call symbol_set_names.
 589         (minimal_symbol_reader::install): Call symbol_set_names.
 590
 591 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 592
 593         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 594         restore_active_ext_lang, as GIL is needed for (indirectly)
 595         called PyOS_InterruptOccurred.
 596
 597 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 598
 599         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 600         definition.
 601
 602 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 603
 604         * remote-sim.c (simulator_command): Make static, remove
 605         declaration.
 606
 607 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 608
 609         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 610         static.
 611         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 612         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 613         (main): Likewise.
 614         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 615         (main): Likewise.
 616         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 617         (main): Likewise.
 618         * unittests/basic_string_view/element_access/char/1.cc (test01):
 619         Likewise.
 620         (main): Likewise.
 621         * unittests/basic_string_view/element_access/char/empty.cc (main):
 622         Likewise.
 623         * unittests/basic_string_view/element_access/char/front_back.cc
 624         (test01): Likewise.
 625         (main): Likewise.
 626         * unittests/basic_string_view/inserters/char/2.cc (test05):
 627         Likewise.
 628         (main): Likewise.
 629         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 630         (test01): Likewise.
 631         (main): Likewise.
 632         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 633         (test01): Likewise.
 634         (main): Likewise.
 635         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 636         Likewise.
 637         * unittests/basic_string_view/operations/compare/char/1.cc
 638         (test01): Likewise.
 639         (main): Likewise.
 640         * unittests/basic_string_view/operations/compare/char/13650.cc
 641         (test01): Likewise.
 642         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 643         Likewise.
 644         (main): Likewise.
 645         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 646         Likewise.
 647         (main): Likewise.
 648         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 649         Likewise.
 650         (main): Likewise.
 651         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 652         Likewise.
 653         (main): Likewise.
 654         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 655         Likewise.
 656         (main): Likewise.
 657         * unittests/basic_string_view/operations/find/char/4.cc (main):
 658         Likewise.
 659         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 660         Likewise.
 661         (main): Likewise.
 662         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 663         Likewise.
 664         (main): Likewise.
 665         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 666         Likewise.
 667         (main): Likewise.
 668         * unittests/basic_string_view/operations/substr/char/1.cc
 669         (test01): Likewise.
 670         (main): Likewise.
 671         * unittests/basic_string_view/operators/char/2.cc (main):
 672         Likewise.
 673         * unittests/optional/assignment/1.cc (test): Likewise.
 674         * unittests/optional/assignment/2.cc (test): Likewise.
 675         * unittests/optional/assignment/3.cc (test): Likewise.
 676         * unittests/optional/assignment/4.cc (test): Likewise.
 677         * unittests/optional/assignment/5.cc (test): Likewise.
 678         * unittests/optional/assignment/6.cc (test): Likewise.
 679         * unittests/optional/assignment/7.cc (test): Likewise.
 680         * unittests/optional/cons/copy.cc (test): Likewise.
 681         * unittests/optional/cons/default.cc (test): Likewise.
 682         * unittests/optional/cons/move.cc (test): Likewise.
 683         * unittests/optional/cons/value.cc (test): Likewise.
 684         * unittests/optional/in_place.cc (test): Likewise.
 685         * unittests/optional/observers/1.cc (test): Likewise.
 686         * unittests/optional/observers/2.cc (test): Likewise.
 687
 688 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 689
 690         * tui-win.h (tui_set_var_cmd): Remove.
 691         * tui-win.c (tui_set_var_cmd): Make static.
 692
 693 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 694
 695         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 696         rbreak_command_wrapper): Remove.
 697         * symtab.c (rbreak_command_wrapper): Remove.
 698
 699 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 700
 701         * inferior.h (info_terminal_command): Remove declaration.
 702         * inflow.c (info_terminal_command): Make static.
 703
 704 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 705
 706         * inferior.c (exit_inferior_silent): Remove.
 707
 708 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 709
 710         * dictionary.c (dict_empty, mdict_empty): Remove.
 711         * dictionary.c (mdict_empty): Remove.
 712
 713 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 714
 715          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 716          (arc_insn_get_memory_offset): Likewise.
 717          (arc_insn_dump): Likewise.
 718          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 719          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 720          * dictionary.c (dict_iterator_next): Likewise.
 721          (dict_iter_match_first): Likewise.
 722          (dict_iter_match_next): Likewise.
 723          * f-lang.c (evaluate_subexp_f): Likewise.
 724          * hppa-tdep.c (hppa_read_pc): Likewise.
 725          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 726          * parse.c (write_exp_elt_msym): Likewise.
 727          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 728          * remote.c (remote_packet_size): Likewise.
 729          (remote_notif_stop_parse): Likewise.
 730          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 731          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 732          * source.c (prepare_path_for_appending): Likewise.
 733          * sparc64-linux-tdep.c
 734          (sparc64_linux_handle_segmentation_fault); Likewise.
 735          * stack.c (frame_selection_by_function_completer): Likewise.
 736
 737 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 738
 739         * completer.c (set_gdb_completion_word_break_characters):
 740         Remove.
 741
 742 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 743
 744         * dwarf-index-write.c: Include dwarf-index-write.h.
 745         * mi/mi-interp.c: Include mi/mi-interp.h.
 746
 747 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 748
 749         * aarch32-tdep.c: Include aarch32-tdep.h.
 750         * aarch32-tdep.h: Forward-declare struct target_desc.
 751
 752 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 753
 754         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 755         strerror.
 756         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 757         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 758
 759 2019-11-25  Tom de Vries  <tdevries@suse.de>
 760
 761         * contrib/words.sh: Add -c option.
 762
 763 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 764
 765         * solib.c (solib_find_1): Change int to bool.
 766         (exec_file_find): Change int to bool.
 767         (solib_find): Change int to bool.
 768         (solib_read_symbols): Change int to bool.
 769         (solib_used): Change int to bool.
 770         (solib_add): Change int to bool.
 771         (info_sharedlibrary_command): Change int to bool.
 772         (solib_contains_address_p): Change int to bool.
 773         (solib_keep_data_in_core): Change int to bool.
 774         (in_solib_dynsym_resolve_code): Change int to bool.
 775         (reload_shared_libraries_1): Change int to bool.
 776         (gdb_sysroot_changed): Change int to bool.
 777         * solib.h (solib_read_symbols): Change int to bool.
 778         (solib_contains_address_p): Change int to bool.
 779         (solib_keep_data_in_core): Change int to bool.
 780         (in_solib_dynsym_resolve_code): Change int to bool.
 781         (libpthread_name_p): Change int to bool.
 782
 783 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 784
 785         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 786         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 787         (remote_packet_max_chars): New static global.
 788         (show_remote_packet_max_chars): New function.
 789         (remote_target::putpkt_binary): Adjust to use new
 790         remote_packet_max_chars option.
 791         (remote_target::getpkt_or_notif_sane_1): Likewise.
 792         (_initialize_remote): Register new remote-packet-max-chars option.
 793
 794 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 795
 796         * m68k-linux-nat.c: Include gdbarch.h.
 797
 798 2019-11-24  Tom Tromey  <tom@tromey.com>
 799
 800         * symfile.c (read_symbols): Update.
 801         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 802         bool.
 803         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 804         (psym_lookup_symbol, psym_find_last_source_symtab)
 805         (psym_forget_cached_source_info, psym_print_stats)
 806         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 807         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 808         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 809         (psym_find_compunit_symtab_by_address)
 810         (maintenance_print_psymbols, maintenance_info_psymtabs)
 811         (maintenance_check_psymtabs): Update.
 812         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 813         bool.
 814
 815 2019-11-22  Tom Tromey  <tom@tromey.com>
 816
 817         * observable.h: Update comments.
 818
 819 2019-11-22  Tom Tromey  <tromey@adacore.com>
 820
 821         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 822         (print_ada_task_info): Don't try to fetch thread id if task is not
 823         alive.
 824
 825 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 826
 827         * ada-exp.y: Update.
 828         * ada-lang.c (sort_choices): Update.
 829         (ada_print_symbol_signature): Update.
 830         (resolve_subexp): Update.
 831         (ada_parse_renaming): Update.
 832         (ada_read_renaming_var_value): Update.
 833         (lesseq_defined_than): Update.
 834         (remove_extra_symbols): Update.
 835         (remove_irrelevant_renamings): Update.
 836         (ada_add_block_symbols): Update.
 837         (ada_collect_symbol_completion_matches): Update.
 838         (ada_is_renaming_symbol): Update.
 839         (aggregate_assign_from_choices): Update.
 840         (ada_evaluate_subexp): Update.
 841         (ada_has_this_exception_support): Update.
 842         (ada_is_non_standard_exception_sym): Update.
 843         (ada_add_exceptions_from_frame): Update.
 844         (ada_add_global_exceptions): Update.
 845         (ada_print_subexp): Update.
 846         * ax-gdb.c (gen_var_ref): Update.
 847         (gen_maybe_namespace_elt): Update.
 848         (gen_expr_for_cast): Update.
 849         (gen_expr): Update.
 850         * block.h: Update.
 851         * blockframe.c (find_pc_partial_function): Update.
 852         * breakpoint.c (print_breakpoint_location): Update.
 853         (update_static_tracepoint): Update.
 854         * btrace.c (ftrace_print_function_name): Update.
 855         (ftrace_function_switched): Update.
 856         * buildsym.c (find_symbol_in_list): Update.
 857         * c-exp.y: Update.
 858         * c-typeprint.c (c_print_typedef): Update.
 859         (c_type_print_template_args): Update.
 860         * cli/cli-cmds.c (edit_command): Update.
 861         (list_command): Update.
 862         (print_sal_location): Update.
 863         * coffread.c (patch_opaque_types): Update.
 864         (process_coff_symbol): Update.
 865         (coff_read_enum_type): Update.
 866         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 867         (convert_one_symbol): Update.
 868         (hash_symname): Update.
 869         (eq_symname): Update.
 870         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 871         * compile/compile-cplus-types.c (debug_print_scope): Update.
 872         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 873         * compile/compile-object-load.c (get_out_value_type): Update.
 874         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 875         (search_symbol_list): Update.
 876         (cp_lookup_symbol_imports_or_template): Update.
 877         * cp-support.c (overload_list_add_symbol): Update.
 878         * ctfread.c (psymtab_to_symtab): Update.
 879         * dbxread.c (cp_set_block_scope): Update.
 880         * dictionary.c (iter_match_first_hashed): Update.
 881         (iter_match_next_hashed): Update.
 882         (insert_symbol_hashed): Update.
 883         (iter_match_next_linear): Update.
 884         * dictionary.h: Update.
 885         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 886         (locexpr_describe_location_piece): Update.
 887         (locexpr_describe_location_1): Update.
 888         (locexpr_generate_c_location): Update.
 889         (loclist_describe_location): Update.
 890         (loclist_generate_c_location): Update.
 891         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 892         (read_func_scope): Update.
 893         (process_enumeration_scope): Update.
 894         (new_symbol): Update.
 895         (dwarf2_const_value): Update.
 896         (dwarf2_symbol_mark_computed): Update.
 897         * eval.c (evaluate_funcall): Update.
 898         (evaluate_subexp_standard): Update.
 899         * expprint.c (print_subexp_standard): Update.
 900         (dump_subexp_body_standard): Update.
 901         * f-valprint.c (info_common_command_for_block): Update.
 902         * findvar.c (get_hosting_frame): Update.
 903         (default_read_var_value): Update.
 904         * go-lang.c (go_symbol_package_name): Update.
 905         * guile/scm-block.c (bkscm_print_block_smob): Update.
 906         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 907         (gdbscm_symbol_name): Update.
 908         (gdbscm_symbol_linkage_name): Update.
 909         (gdbscm_symbol_print_name): Update.
 910         * infcall.c (get_function_name): Update.
 911         * infcmd.c (jump_command): Update.
 912         (finish_command): Update.
 913         * infrun.c (insert_exception_resume_breakpoint): Update.
 914         * linespec.c (canonicalize_linespec): Update.
 915         (create_sals_line_offset): Update.
 916         (convert_linespec_to_sals): Update.
 917         (complete_label): Update.
 918         (find_label_symbols_in_block): Update.
 919         * m2-typeprint.c (m2_print_typedef): Update.
 920         * mdebugread.c (mdebug_reg_to_regnum): Update.
 921         (parse_symbol): Update.
 922         (mylookup_symbol): Update.
 923         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 924         (list_args_or_locals): Update.
 925         * objc-lang.c (compare_selectors): Update.
 926         (info_selectors_command): Update.
 927         (compare_classes): Update.
 928         (info_classes_command): Update.
 929         (find_imps): Update.
 930         * p-typeprint.c (pascal_print_typedef): Update.
 931         * printcmd.c (build_address_symbolic): Update.
 932         (info_address_command): Update.
 933         (print_variable_and_value): Update.
 934         * python/py-framefilter.c (extract_sym): Update.
 935         (py_print_single_arg): Update.
 936         * python/py-symbol.c (sympy_str): Update.
 937         (sympy_get_name): Update.
 938         (sympy_get_linkage_name): Update.
 939         * python/python.c (gdbpy_rbreak): Update.
 940         * record-btrace.c (btrace_get_bfun_name): Update.
 941         (btrace_call_history): Update.
 942         * rust-lang.c (rust_print_typedef): Update.
 943         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 944         * stabsread.c (stab_reg_to_regnum): Update.
 945         (define_symbol): Update.
 946         (read_enum_type): Update.
 947         (common_block_end): Update.
 948         (cleanup_undefined_types_1): Update.
 949         (scan_file_globals): Update.
 950         * stack.c (print_frame_arg): Update.
 951         (print_frame_args): Update.
 952         (find_frame_funname): Update.
 953         (info_frame_command_core): Update.
 954         (iterate_over_block_locals): Update.
 955         (print_block_frame_labels): Update.
 956         (do_print_variable_and_value): Update.
 957         (iterate_over_block_arg_vars): Update.
 958         (return_command): Update.
 959         * symmisc.c (dump_symtab_1): Update.
 960         (print_symbol): Update.
 961         * symtab.c (eq_symbol_entry): Update.
 962         (symbol_cache_dump): Update.
 963         (lookup_language_this): Update.
 964         (find_pc_sect_line): Update.
 965         (skip_prologue_sal): Update.
 966         (symbol_search::compare_search_syms): Update.
 967         (treg_matches_sym_type_name): Update.
 968         (search_symbols): Update.
 969         (print_symbol_info): Update.
 970         (rbreak_command): Update.
 971         (completion_list_add_symbol): Update.
 972         (find_gnu_ifunc): Update.
 973         (get_symbol_address): Update.
 974         (search_module_symbols): Update.
 975         (info_module_subcommand): Update.
 976         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 977         (SYMBOL_LINKAGE_NAME): Remove.
 978         (SYMBOL_DEMANGLED_NAME): Remove.
 979         (SYMBOL_PRINT_NAME): Remove.
 980         (SYMBOL_SEARCH_NAME): Remove.
 981         * tracepoint.c (set_traceframe_context): Update.
 982         (validate_actionline): Update.
 983         (collection_list::collect_symbol): Update.
 984         (encode_actions_1): Update.
 985         (info_scope_command): Update.
 986         (print_one_static_tracepoint_marker): Update.
 987         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 988         * valops.c (address_of_variable): Update.
 989         (find_overload_match): Update.
 990         (find_oload_champ): Update.
 991
 992 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 993
 994         * ada-lang.c (ada_lookup_simple_minsym): Update.
 995         (ada_collect_symbol_completion_matches): Update.
 996         * ada-tasks.c (read_atcb): Update.
 997         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 998         (amd64_windows_skip_trampoline_code): Update.
 999         * arm-tdep.c (skip_prologue_function): Update.
1000         (arm_skip_stack_protector): Update.
1001         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1002         (arm_wince_skip_main_prologue): Update.
1003         * ax-gdb.c (gen_expr): Update.
1004         * block.c (call_site_for_pc): Update.
1005         * blockframe.c (find_pc_partial_function): Update.
1006         * breakpoint.c (set_breakpoint_location_function): Update.
1007         * btrace.c (ftrace_print_function_name): Update.
1008         (ftrace_function_switched): Update.
1009         * c-valprint.c (print_unpacked_pointer): Update.
1010         * coffread.c (coff_symfile_read): Update.
1011         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1012         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1013         * dwarf-index-write.c (write_psymbols): Update.
1014         * dwarf2loc.c (call_site_to_target_addr): Update.
1015         (func_verify_no_selftailcall): Update.
1016         (tailcall_dump): Update.
1017         (call_site_find_chain_1): Update.
1018         (dwarf_expr_reg_to_entry_parameter): Update.
1019         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1020         * eval.c (evaluate_funcall): Update.
1021         (evaluate_subexp_standard): Update.
1022         (evaluate_subexp_for_sizeof): Update.
1023         * expprint.c (print_subexp_standard): Update.
1024         (dump_subexp_body_standard): Update.
1025         * frame.c (get_prev_frame_always_1): Update.
1026         * frv-tdep.c (frv_skip_main_prologue): Update.
1027         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1028         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1029         (gnuv3_get_typename_from_type_info): Update.
1030         (gnuv3_skip_trampoline): Update.
1031         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1032         * i386-tdep.c (i386_skip_main_prologue): Update.
1033         (i386_pe_skip_trampoline_code): Update.
1034         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1035         * infcall.c (get_function_name): Update.
1036         * linespec.c (minsym_found): Update.
1037         * linux-fork.c (info_checkpoints_command): Update.
1038         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1039         (m32c_m16c_pointer_to_address): Update.
1040         * maint.c (maintenance_translate_address): Update.
1041         * minsyms.c (add_minsym_to_hash_table): Update.
1042         (add_minsym_to_demangled_hash_table): Update.
1043         (lookup_minimal_symbol_mangled): Update.
1044         (lookup_minimal_symbol_demangled): Update.
1045         (lookup_minimal_symbol_linkage): Update.
1046         (lookup_minimal_symbol_text): Update.
1047         (lookup_minimal_symbol_by_pc_name): Update.
1048         (minimal_symbol_is_less_than): Update.
1049         (compact_minimal_symbols): Update.
1050         (build_minimal_symbol_hash_tables): Update.
1051         (find_solib_trampoline_target): Update.
1052         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1053         (mips_skip_pic_trampoline_code): Update.
1054         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1055         * objc-lang.c (info_selectors_command): Update.
1056         (info_classes_command): Update.
1057         (find_methods): Update.
1058         (find_imps): Update.
1059         * p-valprint.c (pascal_val_print): Update.
1060         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1061         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1062         * printcmd.c (build_address_symbolic): Update.
1063         (info_symbol_command): Update.
1064         * psymtab.c (psymbol_name_matches): Update.
1065         (match_partial_symbol): Update.
1066         (lookup_partial_symbol): Update.
1067         (print_partial_symbols): Update.
1068         (sort_pst_symbols): Update.
1069         (maintenance_check_psymtabs): Update.
1070         * python/py-framefilter.c (py_print_frame): Update.
1071         * python/python.c (gdbpy_rbreak): Update.
1072         * record-btrace.c (btrace_get_bfun_name): Update.
1073         (btrace_call_history): Update.
1074         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1075         (rs6000_skip_trampoline_code): Update.
1076         * sol-thread.c (info_cb): Update.
1077         * stabsread.c (scan_file_globals): Update.
1078         * stack.c (find_frame_funname): Update.
1079         (info_frame_command_core): Update.
1080         * symmisc.c (dump_msymbols): Update.
1081         * symtab.c (symbol_natural_name): Rename to..,
1082         (general_symbol_info::natural_name): ...this.
1083         (symbol_demangled_name): Rename to...
1084         (general_symbol_info::demangled_name): ...this.
1085         (symbol_search_name): Rename to...
1086         (general_symbol_info::search_name): ...this.
1087         (symbol_matches_search_name): Update.
1088         (find_pc_sect_line): Update.
1089         (skip_prologue_sal): Update.
1090         (search_symbols): Update.
1091         (print_msymbol_info): Update.
1092         (rbreak_command): Update.
1093         (completion_list_add_msymbol): Update.
1094         (completion_list_objc_symbol): Update.
1095         (get_msymbol_address): Update.
1096         * symtab.h (struct general_symbol_info): Add member functions
1097         natural_name (), linkage_name (), print_name (), demangled_name (),
1098         and search_name ().
1099         (SYMBOL_NATURAL_NAME): Update.
1100         (symbol_natural_name): Move to a member function on general_symbol_info.
1101         (SYMBOL_DEMANGLED_NAME): Update.
1102         (symbol_demangled_name): Move to a member function on
1103         general_symbol_info.
1104         (SYMBOL_SEARCH_NAME): Update.
1105         (symbol_search_name): Move to a member function on general_symbol_info.
1106         (MSYMBOL_NATURAL_NAME): Remove.
1107         (MSYMBOL_LINKAGE_NAME): Remove.
1108         (MSYMBOL_PRINT_NAME): Remove.
1109         (MSYMBOL_DEMANGLED_NAME): Remove.
1110         (MSYMBOL_SEARCH_NAME): Remove.
1111         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1112
1113 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1114
1115         * symtab.c (create_demangled_names_hash): Use per_bfd->
1116         minimal_symbol_count for computing the initial size, if greater
1117         than our default size.
1118
1119 2019-11-22  Tom de Vries  <tdevries@suse.de>
1120
1121         * contrib/words.sh: Improve words extraction.
1122
1123 2019-11-22  Tom de Vries  <tdevries@suse.de>
1124
1125         * contrib/words.sh: Combine sed invocations.
1126
1127 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1128
1129         * Makefile.in: Update.
1130         * demangle.c: Rename to...
1131         * gdb-demangle.c: ..this.
1132         (is_cplus_marker): Change return type to bool.
1133         (_initialize_demangler): Rename to...
1134         (_initialize_gdb_demangle): ...this.
1135         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1136         * symtab.h (demangle): Remove declaration; instead include
1137         gdb-demangle.h.
1138
1139 2019-11-21  Tom Tromey  <tromey@adacore.com>
1140
1141         * gdbsupport/format.c (format_pieces): Parse %I64d.
1142         * unittests/format_pieces-selftests.c (test_windows_formats): New
1143         function.
1144         (run_tests): Call it.
1145
1146 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1147
1148         Byte reverse display of variables with DW_END_big, DW_END_little
1149         (DW_AT_endianity) dwarf attributes if different than the native
1150         byte order.
1151         * ada-lang.c (ada_value_binop):
1152         Use type_byte_order instead of gdbarch_byte_order.
1153         * ada-valprint.c (printstr):
1154         (ada_val_print_string):
1155         * ada-lang.c (value_pointer):
1156         (ada_value_binop):
1157         Use type_byte_order instead of gdbarch_byte_order.
1158         * c-lang.c (c_get_string):
1159         Use type_byte_order instead of gdbarch_byte_order.
1160         * c-valprint.c (c_val_print_array):
1161         Use type_byte_order instead of gdbarch_byte_order.
1162         * cp-valprint.c (cp_print_class_member):
1163         Use type_byte_order instead of gdbarch_byte_order.
1164         * dwarf2loc.c (rw_pieced_value):
1165         Use type_byte_order instead of gdbarch_byte_order.
1166         * dwarf2read.c (read_base_type): Handle DW_END_big,
1167         DW_END_little
1168         * f-lang.c (f_get_encoding):
1169         Use type_byte_order instead of gdbarch_byte_order.
1170         * findvar.c (default_read_var_value):
1171         Use type_byte_order instead of gdbarch_byte_order.
1172         * gdbtypes.c (check_types_equal):
1173         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1174         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1175         and TYPE_ENDIANITY_LITTLE if set.
1176         (type_byte_order): new function.
1177         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1178         (struct main_type) <flag_endianity_not_default>:
1179         New field.
1180         (type_byte_order): New function.
1181         * infcmd.c (default_print_one_register_info):
1182         Use type_byte_order instead of gdbarch_byte_order.
1183         * p-lang.c (pascal_printstr):
1184         Use type_byte_order instead of gdbarch_byte_order.
1185         * p-valprint.c (pascal_val_print):
1186         Use type_byte_order instead of gdbarch_byte_order.
1187         * printcmd.c (print_scalar_formatted):
1188         Use type_byte_order instead of gdbarch_byte_order.
1189         * solib-darwin.c (darwin_current_sos):
1190         Use type_byte_order instead of gdbarch_byte_order.
1191         * solib-svr4.c (solib_svr4_r_ldsomap):
1192         Use type_byte_order instead of gdbarch_byte_order.
1193         * stap-probe.c (stap_modify_semaphore):
1194         Use type_byte_order instead of gdbarch_byte_order.
1195         * target-float.c (target_float_same_format_p):
1196         Use type_byte_order instead of gdbarch_byte_order.
1197         * valarith.c (scalar_binop):
1198         (value_bit_index):
1199         Use type_byte_order instead of gdbarch_byte_order.
1200         * valops.c (value_cast):
1201         Use type_byte_order instead of gdbarch_byte_order.
1202         * valprint.c (generic_emit_char):
1203         (generic_printstr):
1204         (val_print_string):
1205         Use type_byte_order instead of gdbarch_byte_order.
1206         * value.c (unpack_long):
1207         (unpack_bits_as_long):
1208         (unpack_value_bitfield):
1209         (modify_field):
1210         (pack_long):
1211         (pack_unsigned_long):
1212         Use type_byte_order instead of gdbarch_byte_order.
1213         * findvar.c (unsigned_pointer_to_address):
1214         (signed_pointer_to_address):
1215         (unsigned_address_to_pointer):
1216         (address_to_signed_pointer):
1217         (default_read_var_value):
1218         (default_value_from_register):
1219         Use type_byte_order instead of gdbarch_byte_order.
1220         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1221         Use type_byte_order instead of gdbarch_byte_order.
1222         * riscv-tdep.c (riscv_print_one_register_info):
1223         Use type_byte_order instead of gdbarch_byte_order.
1224
1225 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1226
1227         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1228         (current_ui_gdb_stdin_ptr): Likewise.
1229         (current_ui_gdb_stderr_ptr): Likewise.
1230         (current_ui_gdb_stdlog_ptr): Likewise.
1231         (current_ui_current_uiout_ptr): Likewise.
1232         (gen_ret_current_ui_field_ptr): Remove.
1233
1234 2019-11-21  Tom de Vries  <tdevries@suse.de>
1235
1236         PR gdb/24956
1237         * cli/cli-script.c (execute_control_command): Only switch to
1238         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1239
1240 2019-11-19  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1243         Now static.  Change type of "name".
1244         (tui_set_win_height_command): Don't copy "arg".
1245         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1246         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1247
1248 2019-11-19  Ali Tamur <tamur@google.com>
1249
1250         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1251         "if (attr != nullptr)".
1252         (dwarf2_find_base_address): Likewise.
1253         (dwarf2_build_include_psymtabs): Likewise.
1254         (read_cutu_die_from_dwo): Likewise.
1255         (read_func_scope): Likewise.
1256         (read_call_site_scope): Likewise.
1257         (dwarf2_get_pc_bounds): Likewise.
1258         (dwarf2_record_block_ranges): Likewise.
1259         (dwarf2_add_field): Likewise.
1260         (dwarf2_add_member_fn): Likewise.
1261         (read_structure_type): Likewise.
1262         (read_enumeration_type): Likewise.
1263         (read_array_type): Likewise.
1264         (read_array_order): Likewise.
1265         (read_set_type): Likewise.
1266         (read_common_block): Likewise.
1267         (read_tag_reference_type): Likewise.
1268         (read_tag_string_type): Likewise.
1269         (read_subroutine_type): Likewise.
1270         (read_base_type): Likewise.
1271         (read_subrange_type): Likewise.
1272         (new_symbol): Likewise.
1273         (prepare_one_comp_unit): Likewise.
1274
1275 2019-11-19  Tom Tromey  <tromey@adacore.com>
1276
1277         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1278         result in error when DebugActiveProcess fails.
1279
1280 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1281             Pedro Alves  <palves@redhat.com>
1282
1283         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1284         * target.c (target_stack::push): Call 'unpush' if there's a
1285         target on top of the stack.
1286
1287 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1288
1289         * python/py-block.c (blpy_dealloc): Call tp_free.
1290         (blpy_block_syms_dealloc): Likewise.
1291         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1292         * python/py-inferior.c (infpy_dealloc): Likewise.
1293         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1294         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1295         * python/py-symbol.c (sympy_dealloc): Likewise.
1296         * python/py-symtab.c (stpy_dealloc): Likewise.
1297         * python/py-type.c (typy_iterator_dealloc): Likewise.
1298
1299 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1300
1301         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1302         constructor instead of using a class initializer.
1303
1304 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1305
1306         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1307         * configure: Regenerate.
1308         * configure.ac: Don't source common.host.
1309         * gdbsupport/common.host: Remove.
1310         * gdbsupport/mingw-strerror.c: Remove.
1311         * gdbsupport/posix-strerror.c: Rename to...
1312         * gdbsupport/safe-strerror.c: ...this.
1313
1314 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1315
1316         * maint.c (scoped_command_stats::print_time): Use localtime_r
1317         instead of localtime (provided through gnulib if necessary).
1318         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1319         of ctime.
1320
1321 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1322
1323         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1324         avoid compile errors.
1325
1326 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1327
1328         * config.in: Regenerate.
1329         * configure: Regenerate.
1330         * gdbsupport/common.m4: No longer check for strerror_r.
1331         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1332         POSIX version of strerror_r, now that gnulib provides it if
1333         necessary.
1334
1335 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1336
1337         * README (`configure' options): Update.
1338
1339 2019-11-14  Tom Tromey  <tromey@adacore.com>
1340
1341         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1342         expected type for the RHS if the LHS is a convenience variable.
1343
1344 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1345
1346         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1347         Provide explicit default and copy constructor.
1348
1349 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1350
1351         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1352         only call Py_INCREF (newbp) in the bppy_pending_object case.
1353
1354 2019-11-13  Tom Tromey  <tromey@adacore.com>
1355
1356         PR build/25182:
1357         * psympriv.h (partial_symbol): Remove static assert.
1358         * symtab.h (general_symbol_info, symbol): Remove static assert.
1359
1360 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * gdbsupport/format.c (format_pieces::format_pieces): Support
1363         printf 'z' size modifier.
1364         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1365         * printcmd.c (ui_printf):  Handle size_t_arg.
1366         * ui-out.c (ui_out::vmessage): Likewise.
1367         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1368         function.
1369         (run_tests): Call test_format_int_sizes.
1370
1371 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1372
1373         * ada-exp.y (write_ambiguous_var): Update.
1374         * buildsym.c (add_symbol_to_list): Update.
1375         * dwarf2read.c (read_variable): Update.
1376         (new_symbol): Update.
1377         * jit.c (finalize_symtab): Update.
1378         * language.c (language_alloc_type_symbol): Update.
1379         * symtab.c (fixup_symbol_section): Update.
1380         (initialize_objfile_symbol_1): Move code to...
1381         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1382         (allocate_symbol): Update.
1383         (allocate_template_symbol): Update.
1384         (get_symbol_address): Update.
1385         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1386         of having as a field, and add a constructor.
1387         (SYMBOL_VALUE): Update.
1388         (SYMBOL_VALUE_ADDRESS): Update.
1389         (SET_SYMBOL_VALUE_ADDRESS): Update.
1390         (SYMBOL_VALUE_BYTES): Update.
1391         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1392         (SYMBOL_BLOCK_VALUE): Update.
1393         (SYMBOL_VALUE_CHAIN): Update.
1394         (SYMBOL_LANGUAGE): Update.
1395         (SYMBOL_SECTION): Update.
1396         (SYMBOL_OBJ_SECTION): Update.
1397         (SYMBOL_SET_LANGUAGE): Update.
1398         (SYMBOL_SET_LINKAGE_NAME): Update.
1399         (SYMBOL_SET_NAMES): Update.
1400         (SYMBOL_NATURAL_NAME): Update.
1401         (SYMBOL_LINKAGE_NAME): Update.
1402         (SYMBOL_DEMANGLED_NAME): Update.
1403         (SYMBOL_SEARCH_NAME): Update.
1404         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1405         (struct symbol): Update.
1406         (struct template_symbol): Update.
1407         (struct rust_vtable_symbol): Update.
1408         * xcoffread.c (SYMBOL_DUP): Update.
1409
1410 2019-11-12  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-layout.c (show_layout): Set current_layout.
1413         (show_source_disasm_command, show_data)
1414         (show_source_or_disasm_and_command): Don't set current_layout.
1415
1416 2019-11-12  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1419
1420 2019-11-12  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-win.c (resize_message): New global.
1423         (show_tui_resize_message): New function.
1424         (tui_async_resize_screen): Print message if requested.
1425         (_initialize_tui_win): Add tui-resize-message setting.
1426         * NEWS: Add entry for new commands.
1427
1428 2019-11-11  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1431         functions.
1432
1433 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1434
1435         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1436
1437 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1438
1439         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1440         function.
1441         * python/python-internal.h (gdbpy_lookup_static_symbols):
1442         Declare new function.
1443         * python/python.c (python_GdbMethods): Add
1444         gdb.lookup_static_symbols method.
1445         * NEWS: Mention gdb.lookup_static_symbols.
1446
1447 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1450         static block of current object file first.  Also fix typo in
1451         header comment.
1452
1453 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * stack.c (set_last_displayed_sal): Delete.
1456         (last_displayed_sal_valid): Delete.
1457         (last_displayed_pspace): Delete.
1458         (last_displayed_addr): Delete.
1459         (last_displayed_symtab): Delete.
1460         (last_displayed_line): Delete.
1461         (class last_displayed_symtab_info_type): New.
1462         (last_displayed_symtab_info): New static global variable.
1463         (print_frame_info): Call methods on last_displayed_symtab_info.
1464         (clear_last_displayed_sal): Update header comment, and make use of
1465         last_displayed_symtab_info.
1466         (last_displayed_sal_is_valid): Likewise.
1467         (get_last_displayed_pspace): Likewise.
1468         (get_last_displayed_addr): Likewise.
1469         (get_last_displayed_symtab): Likewise.
1470         (get_last_displayed_line): Likewise.
1471         (get_last_displayed_sal): Likewise.
1472         * stack.h (clear_last_displayed_sal): Update header comment.
1473         (last_displayed_sal_is_valid): Likewise.
1474         (get_last_displayed_pspace): Likewise.
1475         (get_last_displayed_addr): Likewise.
1476         (get_last_displayed_symtab): Likewise.
1477         (get_last_displayed_line): Likewise.
1478         (get_last_displayed_sal): Likewise.
1479
1480 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * stack.c (frame_show_address): Convert return type to bool.
1483         * stack.h (frame_show_address): Likewise, and update header
1484         comment.
1485
1486 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1487
1488         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1489         * unittests/vec-utils-selftests.c: New file.
1490         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1491
1492 2019-11-10  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1495         (tui_highlight_win): Likewise.
1496         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1497         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1498         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1499         Don't set can_highlight.
1500
1501 2019-11-10  Tom Tromey  <tom@tromey.com>
1502
1503         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1504         Remove unused declaration.
1505
1506 2019-11-08  Tom Tromey  <tromey@adacore.com>
1507
1508         * top.c (read_command_file): Update.
1509         (command_line_input): Make return type const.
1510         * python/py-gdb-readline.c: Update.
1511         * linespec.c (decode_line_2): Update.
1512         * defs.h (command_line_input): Make return type const.
1513         * cli/cli-script.c (read_next_line): Make return type const.
1514         * ada-lang.c (get_selections): Update.
1515
1516 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1517
1518         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1519         * mi/mi-main.c (output_cores): Likewise.
1520         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1521         (linux_xfer_osdata_modules): Likewise.
1522         * remote.c (register_remote_support_xml): Likewise.
1523         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1524         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1525
1526 2019-11-06  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-interp.c: Don't include readline.h.
1529         * tui/tui-hooks.c: Don't include readline.h.
1530         * symmisc.c: Include tilde.h, not readline.h.
1531         * symfile.c: Include tilde.h, not readline.h.
1532         * source.c: Include tilde.h, not readline.h.
1533         * solib.c: Include tilde.h, not readline.h.
1534         * psymtab.c: Include tilde.h, not readline.h.
1535         * exec.c: Include tilde.h, not readline.h.
1536         * corelow.c: Include tilde.h, not readline.h.
1537         * cli/cli-dump.c: Include tilde.h, not readline.h.
1538         * cli/cli-cmds.c: Don't include readline.h.
1539
1540 2019-11-05  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1543         (tui_disassemble): Set addr_size.
1544         (tui_disasm_window::set_contents): Use addr_size.
1545
1546 2019-11-05  Tom Tromey  <tom@tromey.com>
1547
1548         * rust-lang.c (rust_language_defn): Update.
1549         * python/py-value.c (valpy_string): Call c_get_string.
1550         * p-lang.c (pascal_language_defn): Update.
1551         * opencl-lang.c (opencl_language_defn): Update.
1552         * objc-lang.c (objc_language_defn): Update.
1553         * m2-lang.c (m2_language_defn): Update.
1554         * language.c (unknown_language_defn, auto_language_defn): Update.
1555         (default_get_string): Remove.
1556         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1557         * go-lang.c (go_language_defn): Update.
1558         * f-lang.c (f_language_defn): Update.
1559         * d-lang.c (d_language_defn): Update.
1560         * c-lang.c (c_language_defn, cplus_language_defn)
1561         (asm_language_defn, minimal_language_defn): Update.
1562         * ada-lang.c (ada_language_defn): Update.
1563         * language.h (struct language_defn) <la_get_string>: Remove.
1564         (LA_GET_STRING): Remove.
1565         (default_get_string): Don't declare.
1566
1567 2019-11-05  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-source.h (struct tui_source_window): Inline
1570         constructor.  Remove destructor.
1571         <style_changed, m_observable>: Move to superclass.
1572         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1573         (struct tui_source_window_base): Move private members to end.
1574         <style_changed, m_observable>: Move from tui_source_window.
1575         * tui/tui-winsource.c (tui_copy_source_line): Move from
1576         tui-source.c.  Rename from copy_source_line.  Add special handling
1577         for negative line number.
1578         (tui_source_window_base::style_changed): Move from
1579         tui_source_window.
1580         (tui_source_window_base): Register observer.
1581         (~tui_source_window_base): New.
1582         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1583         rename.
1584         (tui_source_window::set_contents): Use tui_copy_source_line.
1585         (tui_source_window::tui_source_window): Move to tui-source.h.
1586         (tui_source_window::~tui_source_window): Remove.
1587         (tui_source_window::style_changed): Move to superclass.
1588         * tui/tui-disasm.c (tui_disassemble): Create string file with
1589         styling, when possible.  Add "addr_size" parameter.
1590         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1591         Don't compute maximum size.
1592         (len_without_escapes): New function
1593
1594 2019-11-05  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1597         std::string.
1598         * tui/tui-winsource.c (tui_show_source_line): Update.
1599         * tui/tui-source.c (tui_source_window::set_contents): Update.
1600         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1601
1602 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1603
1604         * symtab.h (gdb_static_assert): Put && operator at the beginning
1605         of the line instead of the end.
1606
1607 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1608
1609         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1610         and sizeof (symbol).
1611         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1612
1613 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1614
1615         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1616         * configure.host: Mark *-*-solaris2.10* obsolete.
1617         * configure.tgt: Mark Solaris < 11 obsolete.
1618         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1619         Update target triplet.
1620
1621 2019-11-01  Tom Tromey  <tromey@adacore.com>
1622
1623         * utils.c (print_sys_errmsg): Simplify.
1624
1625 2019-11-01  Tom Tromey  <tromey@adacore.com>
1626
1627         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1628
1629 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1630
1631         * configure: Regenerate.
1632         * configure.ac: Remove check for strerror_r.
1633         * gdbsupport/common.m4: Check for strerror_r.
1634
1635 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1636
1637         PR gdb/25124
1638
1639         * arm-tdep.c (arm_per_objfile): Rename to ...
1640         (arm_per_bfd): ... this.
1641         (arm_objfile_data_key): Rename to ...
1642         (arm_bfd_data_key): ... this.
1643         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1644         data.
1645         (arm_record_special_symbol): Likewise.
1646
1647 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1650         end.
1651         * c-typeprint.c (c_print_typedef): Likewise.
1652         * f-typeprint.c (f_print_typedef): Likewise.
1653         * m2-typeprint.c (m2_print_typedef): Likewise.
1654         * p-typeprint.c (pascal_print_typedef): Likewise.
1655         * rust-lang.c (rust_print_typedef): Likewise.
1656         * symtab.c (print_symbol_info): Print a newline after calling
1657         typedef_print.
1658
1659 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * symtab.c (info_module_cmdlist): New variable.
1662         (info_module_command): New function.
1663         (search_module_symbols): New function.
1664         (info_module_subcommand): New function.
1665         (struct info_modules_var_func_options): New struct.
1666         (info_modules_var_func_options_defs): New variable.
1667         (make_info_modules_var_func_options_def_group): New function.
1668         (info_module_functions_command): New function.
1669         (info_module_variables_command): New function.
1670         (info_module_var_func_command_completer): New function.
1671         (_initialize_symtab): Register new 'info module functions' and
1672         'info module variables' commands.
1673         * symtab.h (typedef symbol_search_in_module): New typedef.
1674         (search_module_symbols): Declare new function.
1675         * NEWS: Mention new commands.
1676
1677 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1680         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1681         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1682         MODULES_DOMAIN.
1683         (scan_partial_symbols): Only create partial module symbols for non
1684         declarations.
1685         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1686         and MODULES_DOMAIN.
1687         * symtab.c (search_domain_name): Likewise.
1688         (search_symbols): Likewise.
1689         (print_symbol_info): Likewise.
1690         (symtab_symbol_info): Likewise.
1691         (info_modules_command): New function.
1692         (_initialize_symtab): Register 'info modules' command.
1693         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1694         * NEWS: Mention new 'info modules' command.
1695
1696 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1697
1698         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1699         and $_gdb_maint_setting_str.
1700
1701 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1702
1703         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1704         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1705         (str_value_from_setting, gdb_setting_str_internal_fn)
1706         (gdb_maint_setting_str_internal_fn): New functions.
1707         (_initialize_cli_cmds): Define the new convenience functions.
1708         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1709         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1710
1711 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1712
1713         * agent.c (set_can_use_agent): When the setting is turned on,
1714         look up agent symbols if we don't have them yet.
1715         (agent_new_objfile): Don't look up agent symbols when the agent
1716         setting is off.
1717
1718 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1719
1720         * config.in: Regenerate.
1721
1722 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1723
1724         * configure: Regenerate.
1725         * configure.ac: Check for strerror_r.
1726         * gdbsupport/common-utils.h (safe_strerror): Change return value
1727         to const char * and document that this function is now threadsafe.
1728         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1729         thread_local and call strerror_r, if available.
1730         * utils.c (perror_string): Update.
1731         (print_sys_errmsg): Update.
1732
1733 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1734
1735         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1736         objfile_key.
1737         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1738         objfile to fetch per-bfd data.
1739         (arm_find_exidx_entry): Likewise.
1740
1741 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1742
1743         * gdbsupport/agent.c (debug_agent): Change type to bool.
1744         (use_agent): Likewise.
1745         (all_agent_symbols_look_up): Likewise.
1746         (agent_loaded_p): Change return value to bool.
1747         (agent_look_up_symbols): Update.
1748         (agent_capability_check): Change return value to bool.
1749         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1750         (debug_agent): Change type to bool.
1751         (use_agent): Likewise.
1752         (agent_capability_check): Change return value to bool.
1753
1754 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1755
1756         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1757         (build_minimal_symbol_hash_tables): Code to clear the table moved
1758         to clear_minimal_symbol_hash_tables.
1759         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1760         when needed.
1761
1762 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1763
1764         * infcmd.c: Remove includes.
1765         * infrun.c: Remove includes.
1766
1767 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1768
1769         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1770         (grow_vect): Remove declaration.
1771         (ada_type_of_array): Remove declaration.
1772         (ada_update_initial_language): Remove declaration.
1773         (ada_fold_name): Remove declaration.
1774         (ada_fill_in_ada_prototype): Remove declaration.
1775         (user_select_syms): Remove declaration.
1776         (get_selections): Remove declaration.
1777         (ada_tag_type): Remove declaration.
1778         (ada_value_tag): Remove declaration.
1779         (ada_is_others_clause): Remove declaration.
1780         (ada_in_variant): Remove declaration.
1781         (ada_value_struct_elt): Remove declaration.
1782         (ada_attribute_name): Remove declaration.
1783         (ada_system_address_type): Remove declaration.
1784         * ada-lang.c (ada_watch_location_expression): Make static.
1785         (GROW_VECT): Move here from ada-lang.h.
1786         (grow_vect): Make static.
1787         (ada_update_initial_language): Make static.
1788         (ada_fold_name): Make static.
1789         (ada_type_of_array): Make static.
1790         (encoded_ordered_before): Move up.
1791         (sort_choices): Move up.
1792         (print_signatures): Move up.
1793         (ada_print_symbol_signature): Move up.
1794         (get_selections): Move up and make static.
1795         (user_select_syms): Move up and make static.
1796         (ada_value_struct_elt): Move up and make static.
1797         (ada_tag_type): Make static.
1798         (ada_value_tag): Make static.
1799         (ada_is_others_clause): Make static.
1800         (ada_in_variant): Make static.
1801         (ada_attribute_name): Make static.
1802
1803 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1804
1805         * ada-lang.c: Remove includes.
1806         * ada-typeprint.c: Remove includes.
1807         * ada-valprint.c: Remove includes.
1808
1809 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1810
1811         * addrmap.c: Add static assertions of type size, moved from
1812         _initialize_addrmap.
1813         (_initialize_addrmap): Remove.
1814
1815 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1816
1817         * coffread.c (record_minimal_symbol): Update.
1818         (process_coff_symbol): Update.
1819         * dbxread.c (read_dbx_symtab): Update.
1820         * dwarf2read.c (add_partial_symbol): Update.
1821         (fixup_go_packaging): Update.
1822         (load_partial_dies): Update.
1823         (new_symbol): Update.
1824         * elfread.c (record_minimal_symbol): Change signature to use
1825         gdb::string_view instead of name+len.
1826         (elf_symtab_read): Update.
1827         (elf_rel_plt_read): Update.
1828         * mdebugread.c (parse_partial_symbols): Update.
1829         (handle_psymbol_enumerators): Update.
1830         (new_symbol): Update.
1831         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1832         to use gdb::string_view instead of name+len.
1833         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1834         * psympriv.h (add_psymbol_to_list): Likewise.
1835         * psymtab.c (add_psymbol_to_bcache): Likewise.
1836         (add_psymbol_to_list): Likewise.
1837         * stabsread.c (define_symbol): Update.
1838         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1839         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1840         (symbol_set_names): Likewise.
1841         * xcoffread.c (scan_xcoff_symtab): Update.
1842
1843 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1844
1845         * symtab.h (symbol_set_names): Document that copy_name must be
1846         set to true for non-nullterminated strings.
1847         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1848         linkage_name if the entry was not found and we need to demangle.
1849
1850 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1851
1852         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1853         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1854         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1855         * gdbsupport/gdb_binary_search.h: New file.
1856
1857 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1858
1859         * NEWS: Mention new --with-system-gdbinit-dir option.
1860         * config.in: Regenerate.
1861         * configure: Regenerate.
1862         * configure.ac: Add new option --with-system-gdbinit-dir.
1863         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1864         for a ".gdb" suffix.
1865         * main.c (get_init_files): Change system_gdbinit argument to
1866         a vector and return the files in SYSTEM_GDBINIT_DIR in
1867         addition to SYSTEM_GDBINIT.
1868         (captured_main_1): Update.
1869         (print_gdb_help): Update.
1870         * top.c (print_gdb_configuration): Also print the value of
1871         SYSTEM_GDBINIT_DIR.
1872
1873 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1874
1875         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1876         that takes gdb::string_view arguments.
1877
1878 2019-10-26  Tom de Vries  <tdevries@suse.de>
1879
1880         * aarch64-linux-tdep.c: Fix typos in comments.
1881         * aarch64-tdep.c: Same.
1882         * ada-lang.c: Same.
1883         * amd64-nat.c: Same.
1884         * arc-tdep.c: Same.
1885         * arch/aarch64-insn.c: Same.
1886         * block.c: Same.
1887         * breakpoint.h: Same.
1888         * btrace.h: Same.
1889         * c-varobj.c: Same.
1890         * cli/cli-decode.c: Same.
1891         * cli/cli-script.c: Same.
1892         * cli/cli-utils.h: Same.
1893         * coff-pe-read.c: Same.
1894         * coffread.c: Same.
1895         * compile/compile-cplus-symbols.c: Same.
1896         * compile/compile-object-run.c: Same.
1897         * completer.c: Same.
1898         * corelow.c: Same.
1899         * cp-support.c: Same.
1900         * demangle.c: Same.
1901         * dwarf-index-write.c: Same.
1902         * dwarf2-frame.c: Same.
1903         * dwarf2-frame.h: Same.
1904         * eval.c: Same.
1905         * frame-base.h: Same.
1906         * frame.h: Same.
1907         * gdbcmd.h: Same.
1908         * gdbtypes.h: Same.
1909         * gnu-nat.c: Same.
1910         * guile/scm-objfile.c: Same.
1911         * i386-tdep.c: Same.
1912         * i386-tdep.h: Same.
1913         * infcall.c: Same.
1914         * infcall.h: Same.
1915         * linux-nat.c: Same.
1916         * m68k-tdep.c: Same.
1917         * macroexp.c: Same.
1918         * memattr.c: Same.
1919         * mi/mi-cmd-disas.c: Same.
1920         * mi/mi-getopt.h: Same.
1921         * mi/mi-main.c: Same.
1922         * minsyms.c: Same.
1923         * nat/aarch64-sve-linux-sigcontext.h: Same.
1924         * objfiles.h: Same.
1925         * ppc-linux-nat.c: Same.
1926         * ppc-linux-tdep.c: Same.
1927         * ppc-tdep.h: Same.
1928         * progspace.h: Same.
1929         * prologue-value.h: Same.
1930         * python/py-evtregistry.c: Same.
1931         * python/py-instruction.h: Same.
1932         * record-btrace.c: Same.
1933         * record-full.c: Same.
1934         * remote.c: Same.
1935         * rs6000-tdep.c: Same.
1936         * ser-tcp.c: Same.
1937         * sol-thread.c: Same.
1938         * sparc-sol2-tdep.c: Same.
1939         * sparc64-tdep.c: Same.
1940         * stabsread.c: Same.
1941         * symfile.c: Same.
1942         * symtab.h: Same.
1943         * target.c: Same.
1944         * tracepoint.c: Same.
1945         * tui/tui-data.h: Same.
1946         * tui/tui-io.c: Same.
1947         * tui/tui-win.c: Same.
1948         * tui/tui.c: Same.
1949         * unittests/rsp-low-selftests.c: Same.
1950         * user-regs.h: Same.
1951         * utils.c: Same.
1952         * utils.h: Same.
1953         * valarith.c: Same.
1954         * valops.c: Same.
1955         * valprint.c: Same.
1956         * valprint.h: Same.
1957         * value.c: Same.
1958         * value.h: Same.
1959         * varobj.c: Same.
1960         * x86-nat.h: Same.
1961         * xtensa-tdep.c: Same.
1962
1963 2019-10-25  Ali Tamur <tamur@google.com>
1964
1965         * charset.c (find_charset_names): Reflect API change.
1966
1967 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1968
1969         * symtab.c (struct demangled_name_entry): Change demangled name
1970         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1971         part of the struct anymore.
1972         (symbol_set_names): No longer obstack allocate + copy the demangled
1973         name, just store the allocated name from bfd.
1974
1975 2019-10-25  Tom Tromey  <tromey@adacore.com>
1976
1977         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1978         (bsearch_cie_cmp, add_cie): Remove.
1979         (find_cie): Reimplement.
1980         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1981         (dwarf2_build_frame_info): Update.
1982
1983 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1984
1985         PR gdb/25126
1986         * symfile.c (reread_symbols): Call forget_cached_source_info to
1987         clear the stale source cache.
1988
1989 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1990
1991         * configure: Regenerate.
1992         * configure.ac: Remove code that sets python_has_threads.
1993
1994 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1995
1996         * config.in: Regenerate.
1997         * configure: Regenerate.
1998         * configure.ac: Remove the code that uses sed to get the python
1999         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2000
2001 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2002
2003         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2004         error paths.
2005
2006 2019-10-23  Tom Tromey  <tom@tromey.com>
2007
2008         * arc-tdep.c: Remove ".." from include.
2009         * frv-tdep.c: Remove ".." from include.
2010         * lm32-tdep.c: Remove ".." from include.
2011         * microblaze-tdep.c: Remove ".." from include.
2012         * or1k-tdep.h: Remove ".." from include.
2013         * s12z-tdep.c: Remove ".." from include.
2014         * Makefile.in (OPCODES_CFLAGS): Add comment.
2015         (TOP_CFLAGS): New variable.
2016         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2017
2018 2019-10-23  Tom Tromey  <tom@tromey.com>
2019
2020         * Makefile.in (READLINE_DIR): Update.
2021
2022 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2023
2024         * infcall.c (call_function_by_hand_dummy): Fix the function
2025         comment.  And extract out a code section into...
2026         (reserve_stack_space): ...this new function.
2027
2028 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2029
2030         * infcall.c (value_arg_coerce): Remove an unused parameter.
2031         (call_function_by_hand_dummy): Update the call to
2032         'value_arg_coerce'.
2033
2034 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2035
2036         * infcall.c (call_function_by_hand_dummy): Refactor.
2037
2038 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2039
2040         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2041
2042 2019-10-23  Tom Tromey  <tom@tromey.com>
2043
2044         * configure: Rebuild.
2045         * configure.ac: Don't check for sigprocmask.
2046         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2047
2048 2019-10-23  Tom Tromey  <tom@tromey.com>
2049
2050         * configure: Rebuild.
2051         * acinclude.m4: Use m4_include, not sinclude.
2052
2053 2019-10-23  Tom de Vries  <tdevries@suse.de>
2054
2055         PR breakpoints/24687
2056         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2057
2058 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2059
2060         * symtab.c (struct demangled_name_entry) <language>: Change from
2061         bitfield to regular variable.
2062
2063 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2064
2065         * symtab.c (struct demangled_name_entry): Add a constructor.
2066         (free_demangled_name_entry): New function to call the destructor
2067         for demangled_name_entry.
2068         (create_demangled_names_hash): Pass free_demangled_name_entry to
2069         htab_create_alloc.
2070         (symbol_set_names): Call placement new for demangled_name_entry.
2071         * utils.c: No longer include xxhash.h here, now that fast_hash
2072         is inlined in the header.
2073         * utils.h: Instead, include it here.
2074
2075 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2076
2077         * Makefile.in: Link with libxxhash.
2078         * config.in: Regenerate.
2079         * configure: Regenerate.
2080         * configure.ac: Search for libxxhash.
2081         * utils.c (fast_hash): Use xxhash if present.
2082
2083 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2084
2085         * utils.h (fast_hash): New function.
2086         * symtab.c (hash_demangled_name_entry): Call new function
2087         fast_hash.
2088
2089 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2090
2091         * symtab.c (struct demangled_name_entry): Change type of mangled
2092         to gdb::string_view. Also adds a constructor that takes the
2093         mangled name.
2094         (hash_demangled_name_entry): Update.
2095         (eq_demangled_name_entry): Update.
2096         (free_demangled_name_entry): New function to call the destructor
2097         now that this is not a POD anymore.
2098         (create_demangled_names_hash): Pass free_demangled_name_entry to
2099         htab_create_alloc.
2100         (symbol_set_names): Update.
2101
2102 2019-10-21  Ali Tamur  <tamu@google.com>
2103
2104         * dwarf2read.c (dir_index): Change type.
2105         (file_name_index): Likewise.
2106         (line_header::include_dir_at): Change comment and implementation on
2107         whether it is DWARF 5.
2108         (line_header::is_valid_file_index): New function.
2109         (line_header::file_name_at): Change comment and implementation on
2110         whether it is DWARF 5.
2111         (line_header::file_names): Change to private field renamed as
2112         m_file_names and introduce a new accessor method.
2113         (line_header::file_names_size): New method.
2114         (line_header::include_dirs): Change to private field and rename as
2115         m_include_dirs.
2116         (dw2_get_file_names_reader): Define local var at a smaller scope and
2117         reflect API change.
2118         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2119         (process_structure_scope): Likewise.
2120         (line_header::add_include_dir): Change message and reflect renaming.
2121         (line_header::add_file_name): Likewise.
2122         (read_formatted_entries): Handle DW_FORM_data16.
2123         (dwarf_decode_line_header): Fix line header length calculation.
2124         (psymtab_include_file_name): Change comment and API.
2125         (lnp_state_machine::m_file): Update comment and reflect type change.
2126         (lnp_state_machine::record_line): Reflect type change.
2127         (dwarf_decode_lines): Reflect API change.
2128         (file_file_name): Likewise.
2129         (file_full_name): Likewise.
2130
2131 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2132
2133         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2134
2135 2019-10-21  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2138
2139 2019-10-21  Tom Tromey  <tom@tromey.com>
2140
2141         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2142         NM_H.   Use AC_CONFIG_LINKS.
2143         * configure: Rebuild.
2144         * Makefile.in (NM_H): New variable.
2145         (generated_files): Add NM_H.  Remove gcore.
2146         (nm.h, stamp-nmh): New targets.
2147
2148 2019-10-20  Tom Tromey  <tom@tromey.com>
2149
2150         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2151         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2152         obsolete comment.
2153         (put_objfile_before): Now static.
2154
2155 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2156
2157         * gdbsupport/common-utils.h (startswith): Change return type to
2158         bool.
2159
2160 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2161
2162         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2163         * breakpoint.c (bp_locations_compare): Rename to...
2164         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2165         (update_global_location_list): Use std::sort instead of qsort.
2166         * buildsym.c (compare_line_numbers): Rename to...
2167         (lte_is_less_than): ...this, and change to std::sort semantics.
2168         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2169         instead of qsort.
2170         * disasm.c (compare_lines): Rename to...
2171         (line_is_less_than): ...this, and change to std::sort semantics.
2172         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2173         of qsort.
2174         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2175         (fde_is_less_than): ...this, and change to std::sort semantics.
2176         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2177         * mdebugread.c (compare_blocks):
2178         (block_is_less_than): ...this, and change to std::sort semantics.
2179         (sort_blocks): Call std::sort instead of qsort.
2180         * objfiles.c (qsort_cmp): Rename to...
2181         (sort_cmp): ...this, and change to std::sort semantics.
2182         (update_section_map): Call std::sort instead of qsort.
2183         * remote.c (compare_pnums): Remove.
2184         (map_regcache_remote_table): Call std::sort instead of qsort.
2185         * utils.c (compare_positive_ints): Remove.
2186         * utils.h (compare_positive_ints): Remove.
2187         * xcoffread.c (compare_lte): Remove.
2188         (arrange_linetable): Call std::sort instead of qsort.
2189
2190 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2191
2192         * symfile.c (init_entry_point_info): Fix typo.
2193         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2194
2195 2019-10-18  Tom de Vries  <tdevries@suse.de>
2196
2197         * aarch64-tdep.c: Fix typos in comments.
2198         * ada-lang.c: Same.
2199         * ada-tasks.c: Same.
2200         * alpha-tdep.c: Same.
2201         * alpha-tdep.h: Same.
2202         * amd64-nat.c: Same.
2203         * amd64-windows-tdep.c: Same.
2204         * arc-tdep.c: Same.
2205         * arc-tdep.h: Same.
2206         * arch-utils.c: Same.
2207         * arm-nbsd-tdep.c: Same.
2208         * arm-tdep.c: Same.
2209         * ax-gdb.c: Same.
2210         * blockframe.c: Same.
2211         * btrace.c: Same.
2212         * c-varobj.c: Same.
2213         * coff-pe-read.c: Same.
2214         * coffread.c: Same.
2215         * cris-tdep.c: Same.
2216         * darwin-nat.c: Same.
2217         * dbxread.c: Same.
2218         * dcache.c: Same.
2219         * disasm.c: Same.
2220         * dtrace-probe.c: Same.
2221         * dwarf-index-write.c: Same.
2222         * dwarf2-frame-tailcall.c: Same.
2223         * dwarf2-frame.c: Same.
2224         * dwarf2read.c: Same.
2225         * eval.c: Same.
2226         * exceptions.c: Same.
2227         * fbsd-tdep.c: Same.
2228         * findvar.c: Same.
2229         * frame.c: Same.
2230         * frv-tdep.c: Same.
2231         * gnu-v3-abi.c: Same.
2232         * go32-nat.c: Same.
2233         * h8300-tdep.c: Same.
2234         * hppa-tdep.c: Same.
2235         * i386-linux-tdep.c: Same.
2236         * i386-tdep.c: Same.
2237         * ia64-libunwind-tdep.c: Same.
2238         * ia64-tdep.c: Same.
2239         * infcmd.c: Same.
2240         * infrun.c: Same.
2241         * linespec.c: Same.
2242         * linux-nat.c: Same.
2243         * linux-thread-db.c: Same.
2244         * machoread.c: Same.
2245         * mdebugread.c: Same.
2246         * mep-tdep.c: Same.
2247         * mn10300-tdep.c: Same.
2248         * namespace.c: Same.
2249         * objfiles.c: Same.
2250         * opencl-lang.c: Same.
2251         * or1k-tdep.c: Same.
2252         * osabi.c: Same.
2253         * ppc-linux-nat.c: Same.
2254         * ppc-linux-tdep.c: Same.
2255         * ppc-sysv-tdep.c: Same.
2256         * printcmd.c: Same.
2257         * procfs.c: Same.
2258         * record-btrace.c: Same.
2259         * record-full.c: Same.
2260         * remote-fileio.c: Same.
2261         * remote.c: Same.
2262         * rs6000-tdep.c: Same.
2263         * s12z-tdep.c: Same.
2264         * score-tdep.c: Same.
2265         * ser-base.c: Same.
2266         * ser-go32.c: Same.
2267         * skip.c: Same.
2268         * sol-thread.c: Same.
2269         * solib-svr4.c: Same.
2270         * solib.c: Same.
2271         * source.c: Same.
2272         * sparc-nat.c: Same.
2273         * sparc-sol2-tdep.c: Same.
2274         * sparc-tdep.c: Same.
2275         * sparc64-tdep.c: Same.
2276         * stabsread.c: Same.
2277         * stack.c: Same.
2278         * symfile.c: Same.
2279         * symtab.c: Same.
2280         * target-descriptions.c: Same.
2281         * target-float.c: Same.
2282         * thread.c: Same.
2283         * utils.c: Same.
2284         * valops.c: Same.
2285         * valprint.c: Same.
2286         * value.c: Same.
2287         * varobj.c: Same.
2288         * windows-nat.c: Same.
2289         * xcoffread.c: Same.
2290         * xstormy16-tdep.c: Same.
2291         * xtensa-tdep.c: Same.
2292
2293 2019-10-17  Tom Tromey  <tromey@adacore.com>
2294
2295         * configure: Rebuild.
2296         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2297         in AC_CONFIG_FILES invocation.
2298         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2299         new-style config.status invocation.
2300
2301 2019-10-17  Tom de Vries  <tdevries@suse.de>
2302
2303         * arm-nbsd-nat.c: Fix typos in comments.
2304         * arm-tdep.c: Same.
2305         * darwin-nat-info.c: Same.
2306         * dwarf2read.c: Same.
2307         * elfread.c: Same.
2308         * event-top.c: Same.
2309         * findvar.c: Same.
2310         * gdbtypes.c: Same.
2311         * hppa-tdep.c: Same.
2312         * i386-tdep.c: Same.
2313         * jit.c: Same.
2314         * main.c: Same.
2315         * mdebugread.c: Same.
2316         * moxie-tdep.c: Same.
2317         * nto-procfs.c: Same.
2318         * osabi.c: Same.
2319         * ppc-linux-tdep.c: Same.
2320         * remote.c: Same.
2321         * riscv-tdep.c: Same.
2322         * s390-tdep.c: Same.
2323         * sh-tdep.c: Same.
2324         * sparc-linux-tdep.c: Same.
2325         * sparc-nat.c: Same.
2326         * stack.c: Same.
2327         * target-descriptions.c: Same.
2328         * top.c: Same.
2329         * varobj.c: Same.
2330
2331 2019-10-16  Tom Tromey  <tom@tromey.com>
2332
2333         * objfiles.h (struct objfile) <original_name>: Now const.
2334
2335 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2336
2337         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2338         pass on to sigsetjmp's second argument.
2339         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2340
2341 2019-10-16  Keith Seitz  <keiths@redhat.com>
2342
2343         PR gdb/23567
2344         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2345         sections whose size is greater than the file size.
2346
2347 2019-10-16  Jim Wilson  <jimw@sifive.com>
2348
2349         * riscv-tdep.c (riscv_gcc_target_options): New.
2350         (riscv_gnu_triplet_regexp): New.
2351         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2352         set_gdbarch_gnu_triplet_regexp.
2353
2354 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2355
2356         * Makefile.in: Add xml-builtin.h.
2357         * features/feature_to_c.sh: Add an include for xml-builtin.h
2358         to ensure that the compiler checks that the types match.
2359         * xml-builtin.h: New file.
2360         * xml-support.c (fetch_xml_builtin): Add missing const.
2361         * xml-support.h: Remove declaration of xml_builtins.
2362
2363 2019-10-16  Tom de Vries  <tdevries@suse.de>
2364
2365         PR tdep/25096
2366         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2367         (amd64_classify_aggregate): ... here.
2368         (amd64_classify_aggregate_field): Handled fiels of nested structs
2369         recursively.
2370
2371 2019-10-16  Tom de Vries  <tdevries@suse.de>
2372
2373         PR tdep/24104
2374         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2375         that handles 'theclass'.
2376
2377 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * linespec.c (decode_digits_ordinary): Update comment.
2380         * make-target-delegates: No longer need to handle VEC case.
2381         * memrange.c (normalize_mem_ranges): Update comment.
2382         * namespace.c (add_using_directive): Update comment.
2383         * objc-lang.c (uniquify_strings): Update comment.
2384         * ppc-linux-nat.c (struct thread_points): Update comment.
2385         * probe.h (find_probes_in_objfile): Update comment.
2386         * target.h (enum flash_preserve_mode): Update comment.
2387         * varobj.c (varobj_restrict_range): Update comment.
2388         * varobj.h (varobj_list_children): Update comment.
2389
2390 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * Makefile.in: Remove references to vec.h and vec.c.
2393         * aarch64-tdep.c: No longer include vec.h.
2394         * ada-lang.c: Likewise.
2395         * ada-lang.h: Likewise.
2396         * arm-tdep.c: Likewise.
2397         * ax.h: Likewise.
2398         * breakpoint.h: Likewise.
2399         * charset.c: Likewise.
2400         * cp-support.h: Likewise.
2401         * dtrace-probe.c: Likewise.
2402         * dwarf2read.c: Likewise.
2403         * extension.h: Likewise.
2404         * gdb_bfd.c: Likewise.
2405         * gdbsupport/gdb_vecs.h: Likewise.
2406         * gdbsupport/vec.c: Remove.
2407         * gdbsupport/vec.h: Remove.
2408         * gdbthread.h: Likewise.
2409         * guile/scm-type.c: Likewise.
2410         * inline-frame.c: Likewise.
2411         * machoread.c: Likewise.
2412         * memattr.c: Likewise.
2413         * memrange.h: Likewise.
2414         * namespace.h: Likewise.
2415         * nat/linux-btrace.h: Likewise.
2416         * osdata.c: Likewise.
2417         * parser-defs.h: Likewise.
2418         * progspace.h: Likewise.
2419         * python/py-type.c: Likewise.
2420         * record-btrace.c: Likewise.
2421         * rust-exp.y: Likewise.
2422         * solib-target.c: Likewise.
2423         * stap-probe.c: Likewise.
2424         * target-descriptions.c: Likewise.
2425         * target-memory.c: Likewise.
2426         * target.h: Likewise.
2427         * varobj.c: Likewise.
2428         * varobj.h: Likewise.
2429         * xml-support.h: Likewise.
2430
2431 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2432
2433         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2434         Update for new std::vector based implementation.
2435         (process_psymtab_comp_unit_reader): Likewise.
2436         (scan_partial_symbols): Likewise.
2437         (recursively_compute_inclusions): Likewise.
2438         (compute_compunit_symtab_includes): Likewise.
2439         (process_imported_unit_die): Likewise.
2440         (queue_and_load_dwo_tu): Likewise.
2441         (follow_die_sig_1): Likewise.
2442         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2443         (typedef dwarf2_per_cu_ptr): Remove.
2444         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2445         function.
2446         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2447         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2448         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2449         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2450         std::vector.
2451
2452 2019-10-15  Tom Tromey  <tromey@adacore.com>
2453
2454         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2455         TID.
2456
2457 2019-10-15  Tom Tromey  <tromey@adacore.com>
2458
2459         * windows-nat.c (windows_nat_target::fetch_registers)
2460         (windows_nat_target::store_registers): Rename "pid" to "tid".
2461
2462 2019-10-15  Tom Tromey  <tromey@adacore.com>
2463
2464         * gdbarch.h, gdbarch.c: Rebuild.
2465         * gdbarch.sh (gcc_target_options): Change return type to
2466         std::string.
2467         * compile/compile.c (get_args): Update.
2468         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2469         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2470         std::string.
2471         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2472         std::string.
2473         * arch-utils.c (default_gcc_target_options): Return std::string.
2474         * arch-utils.h (default_gcc_target_options): Return std::string.
2475         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2476
2477 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2478
2479         * breakpoint.c (breakpoint_chain): Make static.
2480         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2481         of accessing breakpoint_chain.
2482
2483 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2484
2485         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2486         to a gdb::function_view and return value to bool.
2487         * breakpoint.h (iterate_over_breakpoints): Likewise.
2488         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2489         (pop_dummy_frame): Update.
2490         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2491         (gdbscm_breakpoints): Update.
2492         * python/py-breakpoint.c (build_bp_list): Update.
2493         (gdbpy_breakpoints): Update.
2494         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2495         Update.
2496         (bpfinishpy_handle_stop): Update.
2497         (bpfinishpy_handle_exit): Update.
2498         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2499         (svr4_update_solib_event_breakpoints): Update.
2500
2501 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2502
2503         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2504         when unwrapping single-field structs.
2505
2506 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2507
2508         * dwarf2read.c: Remove includes.
2509
2510 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2511
2512         * ui-out.c (ui_out::call_do_message): Silence
2513         -Wformat-nonliteral warning.
2514
2515 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2516
2517         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2518         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2519         include: readline/tilde.h.
2520
2521 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2522
2523         * remote.c (remote_target::get_trace_status): Remove declaration of
2524         trace_regblock_size.
2525
2526 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2527
2528         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2529         (show_user): Remove declaration of cmdlist.
2530         * cli/cli-cmds.h (max_user_call_depth): Declare.
2531         * cli/cli-script.c (execute_user_command): Remove declaration
2532         of max_user_call_depth.
2533
2534 2019-10-11  Jim Wilson  <jimw@sifive.com>
2535
2536         * gdbsupport/print-utils.h (pulongest): Fix comment.
2537         (plongest): Likewise.
2538         (phex): Add missing comment, mention leading zeros.
2539         (phex_nz): Add mention of no leading zeros to comment.
2540
2541         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2542         plongest instead of unsigned long long cast.
2543
2544 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2545
2546         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2547         for external_editor_command and gdbtk_test.
2548
2549 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2550
2551         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2552         * varobj.c (varobjdebug): Move comment to...
2553         * varobj.h (varobjdebug): ...here, and declare.
2554
2555 2019-10-09  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2558         erase_data_content.
2559
2560 2019-10-09  Tom Tromey  <tom@tromey.com>
2561
2562         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2563         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2564         * tui/tui-command.c (tui_cmd_window::resize)
2565         (tui_refresh_cmd_win): Update.
2566         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2567         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2568         * tui/tui-data.c (~tui_gen_win_info): Remove.
2569         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2570         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2571         (tui_redisplay_readline, tui_mld_flush)
2572         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2573         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2574         (tui_data_window::erase_data_content)
2575         (tui_data_item_window::rerender)
2576         (tui_data_item_window::refresh_window): Update.
2577         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2578         (box_win, tui_gen_win_info::make_window)
2579         (tui_gen_win_info::make_visible): Update.
2580         (tui_delete_win): Remove.
2581         * tui/tui-winsource.c
2582         (tui_source_window_base::do_erase_source_content): Update.
2583         (tui_show_source_line, tui_source_window_base::update_tab_width)
2584         (tui_source_window_base::update_exec_info): Update.
2585         * tui/tui-data.h (struct curses_deleter): New.
2586         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2587         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2588
2589 2019-10-09  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2592
2593 2019-10-09  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2596         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2597
2598 2019-10-09  Tom Tromey  <tom@tromey.com>
2599
2600         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2601         window height directly.
2602         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2603         declare.
2604         * tui/tui-layout.c (tui_default_win_height): Remove.
2605         (tui_default_win_viewport_height): Remove.
2606
2607 2019-10-09  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui.h: Remove comments.
2610
2611 2019-10-09  Tom de Vries  <tdevries@suse.de>
2612
2613         * python/lib/gdb/printer/bound_registers.py: Use
2614         '^builtin_type_bound128' as regexp argument for
2615         add_builtin_pretty_printer.
2616
2617 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2618
2619         * guile/guile.c (guile_extension_script_ops): Remove forward
2620         declaration and mark as static.
2621         (guile_script_ops): Likewise.
2622         (extension_language_guile): Move further down in the file so
2623         it can reference the definitions for guile_{extension_,}script_ops.
2624
2625 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2626
2627         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2628         except SORTL, DFLTCC, and KDSA.
2629
2630 2019-10-08  Tom Tromey  <tromey@adacore.com>
2631
2632         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2633         (struct safe_symbol_file_add_args): Remove.
2634
2635 2019-10-08  Tom Tromey  <tromey@adacore.com>
2636
2637         * windows-nat.c: Don't include buildsym-legacy.h.
2638
2639 2019-10-08  Tom Tromey  <tromey@adacore.com>
2640
2641         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2642
2643 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2644
2645         * gdbtypes.c (overload_debug): Move comment to header.
2646         * gdbtypes.h (overload_debug): Declare.
2647         * valops.c: Remove declaration of overload_debug, instead
2648         include gdbtypes.h.
2649
2650 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2651
2652         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2653         through _().
2654         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2655         move comment...
2656         * language.h (lang_frame_mismatch_warn): ... here. Also add
2657         declaration.
2658         * top.c (lang_frame_mismatch_warn): Remove declaration.
2659         (check_frame_language_change): Pass lang_frame_mismatch_warn
2660         through _().
2661
2662 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2663
2664         * c-lang.h (vtbl_ptr_name): Declare.
2665         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2666         it from the header.
2667         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2668
2669 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2670
2671         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2672         gdb_static_assert.
2673
2674 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2675
2676         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2677         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2678         * ctfread.c: New file.
2679         * ctfread.h: New file.
2680         * elfread.c: Include ctfread.h.
2681         (struct elfinfo text_p): New member ctfsect.
2682         (elf_locate_sections): Mark CTF section.
2683         (elf_symfile_read): Call elfctf_build_psymtabs.
2684         * Makefile.in (LIBCTF): Add.
2685         (CLIBS): Use it.
2686         (CDEPS): Likewise.
2687         (DIST): Add ctfread.c.
2688
2689 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         * ctfread.c (struct nextfield): Renamed to ...
2692         (struct ctf_nextfield): ... this.
2693         (struct field_info): Renamed to ...
2694         (strut ctf_field_info): ... this.
2695         (attach_fields_to_type): Update for renamed structures.
2696         (ctf_add_member_cb): Likewise.
2697         (ctf_add_enum_member_cb): Likewise.
2698         (process_struct_members): Likewise.
2699         (process_enum_type): Likewise.
2700
2701 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2702
2703         * tracectf.h: Rename, was ctf.h.
2704         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2705         * tracefile.c: Likewise.
2706         * tracepoint.c: Remove unused include ctf.h.
2707         * mi/mi-main.c: Likewise.
2708         * Makefile.in Replace ctf.c with tracectf.c.
2709
2710 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2711
2712         * version.in: Change version number to "9.0.50.DATE-git".
2713
2714 2019-10-03  Tom Tromey  <tom@tromey.com>
2715
2716         PR rust/24976:
2717         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2718
2719 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2720
2721         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2722         cp_search_name_hash.
2723         * NEWS: Add entry about nested function support.
2724
2725 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2726             Andrew Burgess  <andrew.burgess@embecosm.com>
2727
2728         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2729         for nested static variables when searchin VAR_DOMAIN.
2730         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2731         global scope, update comment.
2732         (add_partial_subprogram): Call add_partial_subprogram recursively
2733         for nested subroutines when processinng Fortran.
2734         (load_partial_dies): Process the child entities of a subprogram
2735         when processing Fortran.
2736         (partial_die_parent_scope): Handle building scope
2737         for Fortran nested functions.
2738         (process_die): Record that nested functions have a scope.
2739         (new_symbol): Always record Fortran subprograms on the global
2740         symbol list.
2741         (determine_prefix): How to build the prefix for Fortran
2742         subprograms.
2743
2744 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2747         have just sent the thread a SIGSTOP and are waiting for it to
2748         arrive.
2749
2750 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2751
2752         * btrace.c (btrace_add_pc): Remove whitespace before the template
2753         parameter in 'std::vector <...>'.
2754         (parse_xml_btrace_block): Likewise.
2755         (btrace_maint_decode_pt): Likewise.
2756         (btrace_maint_update_packets): Likewise.
2757         (btrace_maint_print_packets): Likewise.
2758         * btrace.h (struct btrace_maint_info): Likewise.
2759         * dwarf2read.c (struct type_unit_group): Likewise.
2760         (build_type_psymtabs_reader): Likewise.
2761         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2762         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2763         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2764
2765 2019-10-03  Tom de Vries  <tdevries@suse.de>
2766
2767         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2768         the first line of the help text for set/show style metadata.
2769
2770 2019-10-02  Tom Tromey  <tromey@adacore.com>
2771
2772         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2773         * gdbsupport/common-inferior.c: New file.
2774         * infcmd.c (startup_with_shell): Don't define.
2775         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2776         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2777         * inferior.h (startup_with_shell): Don't declare.
2778
2779 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2780
2781         * gdbsupport/gdb_assert.h: Include errors.h.
2782         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2783
2784 2019-10-02  Tom Tromey  <tromey@adacore.com>
2785
2786         * NEWS: Add $_ada_exception entry.
2787         * ada-lang.c (struct ada_catchpoint): Add constructor.
2788         <m_kind>: New member.
2789         (allocate_location_exception, re_set_exception): Remove
2790         "ex" parameter.
2791         (should_stop_exception): Compute $_ada_exception.
2792         (check_status_exception, print_it_exception)
2793         (print_one_exception, print_mention_exception): Remove
2794         "ex" parameter.
2795         (allocate_location_catch_exception, re_set_catch_exception)
2796         (check_status_exception, print_it_catch_exception)
2797         (print_one_catch_exception, print_mention_catch_exception)
2798         (print_recreate_catch_exception)
2799         (allocate_location_catch_exception_unhandled)
2800         (re_set_catch_exception_unhandled)
2801         (check_status_exception, print_it_catch_exception_unhandled)
2802         (print_one_catch_exception_unhandled)
2803         (print_mention_catch_exception_unhandled)
2804         (print_recreate_catch_exception_unhandled)
2805         (allocate_location_catch_assert, re_set_catch_assert)
2806         (check_status_assert, print_it_catch_assert)
2807         (print_one_catch_assert, print_mention_catch_assert)
2808         (print_recreate_catch_assert)
2809         (allocate_location_catch_handlers, re_set_catch_handlers)
2810         (check_status_handlers, print_it_catch_handlers)
2811         (print_one_catch_handlers, print_mention_catch_handlers)
2812         (print_recreate_catch_handlers): Remove.
2813         (create_ada_exception_catchpoint): Update.
2814         (initialize_ada_catchpoint_ops): Update.
2815
2816 2019-10-02  Tom Tromey  <tromey@adacore.com>
2817
2818         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2819         (create_excep_cond_exprs): Simplify exception string computation.
2820         (ada_exception_catchpoint_cond_string): Likewise.
2821
2822 2019-10-02  Tom Tromey  <tromey@adacore.com>
2823
2824         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2825         * ada-lang.c (lesseq_defined_than): Handle
2826         LOC_STATIC.
2827         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2828         parameter.
2829         (dwarf2_has_info): Likewise.
2830         (new_symbol): Set maybe_copied on symbol when
2831         appropriate.
2832         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2833         parameter.
2834         <can_copy>: New member.
2835         * elfread.c (record_minimal_symbol): Set maybe_copied
2836         on symbol when appropriate.
2837         (elf_symfile_read): Update call to dwarf2_has_info.
2838         * minsyms.c (lookup_minimal_symbol_linkage): New
2839         function.
2840         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2841         * symtab.c (get_symbol_address, get_msymbol_address):
2842         New functions.
2843         * symtab.h (get_symbol_address, get_msymbol_address):
2844         Declare.
2845         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2846         maybe_copied.
2847         (struct symbol, struct minimal_symbol) <maybe_copied>:
2848         New member.
2849
2850 2019-10-02  Tom Tromey  <tromey@adacore.com>
2851
2852         * source.c (struct current_source_location): New.
2853         (current_source_key): New global.
2854         (current_source_symtab, current_source_line)
2855         (current_source_pspace): Remove.
2856         (get_source_location): New function.
2857         (get_current_source_symtab_and_line)
2858         (set_default_source_symtab_and_line)
2859         (set_current_source_symtab_and_line)
2860         (clear_current_source_symtab_and_line, select_source_symtab)
2861         (info_source_command, print_source_lines_base)
2862         (info_line_command, search_command_helper, _initialize_source):
2863         Update.
2864
2865 2019-10-02  Tom Tromey  <tromey@adacore.com>
2866
2867         * source.c (select_source_symtab): Don't call
2868         decode_line_with_current_source.
2869
2870 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2871
2872         * symtab.c (lookup_global_symbol): Search global block.
2873
2874 2019-10-02  Tom Tromey  <tromey@adacore.com>
2875
2876         * coffread.c (process_coff_symbol): Update.
2877         * dwarf2read.c (var_decode_location, new_symbol): Update.
2878         * mdebugread.c (parse_symbol): Update.
2879         * objfiles.c (relocate_one_symbol): Update.
2880         * stabsread.c (define_symbol, fix_common_block)
2881         (scan_file_globals): Update.
2882         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2883         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2884         * xcoffread.c (process_xcoff_symbol): Update.
2885
2886 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2887
2888         * MAINTAINERS: Update my email address.
2889
2890 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2891
2892         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2893         std::vector.
2894         (build_type_psymtabs_reader): Update for std::vector.
2895         (build_type_psymtab_dependencies): Likewise.
2896         * dwarf2read.h: Remove use of DEF_VEC_P.
2897         (typedef sig_type_ptr): Delete.
2898
2899 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2902         to std::vector.
2903         (btrace_maint_decode_pt): Likewise, and move allocation of the
2904         vector outside of the loop.
2905         (btrace_maint_update_packets): Update to handle change from VEC to
2906         std::vector.
2907         (btrace_maint_print_packets): Likewise.
2908         (maint_info_btrace_cmd): Likewise.
2909         * btrace.h: Remove use of DEF_VEC_O.
2910         (typedef btrace_pt_packet_s): Delete.
2911         (struct btrace_maint_info) <packets>: Change fromm VEC to
2912         std::vector.
2913         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2914
2915 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2916
2917         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2918         make accesses into the vector constant references.
2919         (btrace_add_pc): Update for std::vector.
2920         (btrace_stitch_bts): Likewise.
2921         (parse_xml_btrace_block): Likewise.
2922         (btrace_maint_update_packets): Likewise.
2923         (btrace_maint_print_packets): Likewise.
2924         (maint_info_btrace_cmd): Likewise.
2925         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2926         std::vector.
2927         (btrace_data::empty): Likewise.
2928         (btrace_data_append): Likewise.
2929         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2930         (typedef btrace_block_s): Delete.
2931         (struct btrace_block): Add constructor.
2932         (struct btrace_data_bts) <blocks>: Change to std::vector.
2933         * nat/linux-btrace.c (perf_event_read_bts): Update for
2934         std::vector.
2935         (linux_read_bts): Likewise.
2936
2937 2019-10-01  Tom Tromey  <tom@tromey.com>
2938
2939         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2940
2941 2019-10-01  Tom Tromey  <tom@tromey.com>
2942
2943         * stack.c (print_frame, info_frame_command_core): Use
2944         styled_string.
2945         * linux-thread-db.c (try_thread_db_load_1)
2946         (try_thread_db_load_from_pdir_1): Use styled_string.
2947         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2948         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2949         (maybe_print_unsupported_script_warning)
2950         (maybe_print_script_not_found_warning): Use styled_string.
2951         * ada-lang.c (user_select_syms): Use styled_string.
2952
2953 2019-10-01  Tom Tromey  <tom@tromey.com>
2954
2955         * p-lang.c (pascal_printstr): Use metadata style.
2956         * value.c (show_convenience): Use metadata style.
2957         * valprint.c (valprint_check_validity, val_print_optimized_out)
2958         (val_print_not_saved, val_print_unavailable)
2959         (val_print_invalid_address, generic_val_print, val_print)
2960         (value_check_printable, val_print_array_elements): Use metadata
2961         style.
2962         * ui-out.h (class ui_out) <field_fmt>: New overload.
2963         <do_field_fmt>: Add style parameter.
2964         * ui-out.c (ui_out::field_fmt): New overload.
2965         * typeprint.c (type_print_unknown_return_type)
2966         (val_print_not_allocated, val_print_not_associated): Use metadata
2967         style.
2968         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2969         parameter.
2970         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2971         * tracepoint.c (tvariables_info_1): Use metadata style.
2972         * stack.c (print_frame_arg, print_frame_info, print_frame)
2973         (info_frame_command_core): Use metadata style.
2974         * skip.c (info_skip_command): Use metadata style.
2975         * rust-lang.c (rust_print_enum): Use metadata style.
2976         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2977         metadata style.
2978         * python/py-framefilter.c (py_print_single_arg): Use metadata
2979         style.
2980         * printcmd.c (do_one_display, print_variable_and_value): Use
2981         metadata style.
2982         * p-valprint.c (pascal_val_print)
2983         (pascal_object_print_value_fields): Use metadata style.
2984         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2985         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2986         parameter.
2987         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2988         * m2-valprint.c (m2_print_long_set): Use metadata style.
2989         * m2-typeprint.c (m2_print_type): Use metadata style.
2990         * infcmd.c (print_return_value_1): Use metadata style.
2991         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2992         * f-valprint.c (info_common_command_for_block): Use metadata
2993         style.
2994         * f-typeprint.c (f_type_print_base): Use metadata style.
2995         * expprint.c (print_subexp_standard): Use metadata style.
2996         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2997         * cli/cli-style.h (class cli_style_option): Add constructor.
2998         (metadata_style): Declare.
2999         * cli/cli-style.c (metadata_style): New global.
3000         (_initialize_cli_style): Register metadata style.
3001         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3002         parameter.
3003         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3004         * c-typeprint.c (c_type_print_base_struct_union)
3005         (c_type_print_base_1): Use metadata style.
3006         * breakpoint.c (watchpoint_value_print)
3007         (print_one_breakpoint_location): Use metadata style.
3008         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3009         style.
3010         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3011         style.
3012         * ada-valprint.c (val_print_packed_array_elements, printstr)
3013         (print_field_values, ada_val_print_ref, ada_val_print): Use
3014         metadata style.
3015         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3016         style.
3017         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3018         style.
3019         * ada-lang.c (user_select_syms): Use metadata style.
3020
3021 2019-10-01  Tom Tromey  <tom@tromey.com>
3022
3023         * cli/cli-cmds.c (pwd_command): Style output.
3024
3025 2019-10-01  Pedro Alves  <palves@redhat.com>
3026             Tom Tromey  <tom@tromey.com>
3027
3028         * symtab.c (print_symbol_info): Use %ps.
3029         (print_msymbol_info): Use %ps.
3030         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3031         * printcmd.c (print_variable_and_value): Use %ps.
3032         * macrocmd.c (show_pp_source_pos): Use %ps.
3033         * infrun.c (print_exited_reason): Use ui_out::message.
3034         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3035         (describe_other_breakpoints): Use ui_out::message and new
3036         formats.
3037         (say_where): Use new formats.
3038         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3039         and new formats.
3040
3041 2019-10-01  Pedro Alves  <palves@redhat.com>
3042             Tom Tromey  <tom@tromey.com>
3043
3044         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3045         (test_gdb_formats): New function.
3046         (run_tests): Call it.
3047         (test_format_specifier): Update.
3048         * utils.h (fputs_filtered): Update comment.
3049         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3050         (fputs_styled_unfiltered): Declare.
3051         * utils.c (fputs_styled_unfiltered): New function.
3052         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3053         (vfprintf_filtered): Update.
3054         (vfprintf_unfiltered, vprintf_filtered): Update.
3055         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3056         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3057         disallow_ui_out_field>: New constants.
3058         (enum class field_kind): New.
3059         (struct base_field_s, struct signed_field_s): New.
3060         (signed_field): New function.
3061         (struct string_field_s): New.
3062         (string_field): New function.
3063         (struct styled_string_s): New.
3064         (styled_string): New function.
3065         (class ui_out) <message>: Add comment.
3066         <vmessage, call_do_message>: New methods.
3067         <do_message>: Add style parameter.
3068         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3069         methods.
3070         (ui_out::message): Rewrite.
3071         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3072         parameter.
3073         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3074         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3075         gdb_extensions parameter.
3076         (class format_piece): Add parameter to constructor.
3077         (n_int_args): New field.
3078         * gdbsupport/format.c (format_pieces::format_pieces): Add
3079         gdb_extensions parameter.  Handle '*'.
3080         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3081         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3082         vfprintf_styled_no_gdbfmt.
3083         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3084         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3085         unfiltered output.
3086         * ui-style.h (struct ui_file_style) <ptr>: New method.
3087
3088 2019-10-01  Tom Tromey  <tom@tromey.com>
3089
3090         * unittests/format_pieces-selftests.c: Update.  Add final format.
3091         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3092         empty literal pieces.
3093
3094 2019-10-01  Tom Tromey  <tom@tromey.com>
3095
3096         * ui-out.h (enum class ui_out_style_kind): Remove.
3097         (class ui_out) <field_string, field_stsream, do_field_string>:
3098         Change type of "style".
3099         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3100         (ui_out::field_string): Update.
3101         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3102         of "style".
3103         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3104         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3105         * stack.c (print_frame_arg, print_frame_info, print_frame):
3106         Update.
3107         * source.c (print_source_lines_base): Update.
3108         * solib.c (info_sharedlibrary_command): Update.
3109         * skip.c (info_skip_command): Update.
3110         * record-btrace.c (btrace_call_history_src_line)
3111         (btrace_call_history): Update.
3112         * python/py-framefilter.c (py_print_frame): Update.
3113         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3114         "style".
3115         * mi/mi-out.c (mi_ui_out::do_table_header)
3116         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3117         (mi_ui_out::do_field_string): Update.
3118         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3119         Update.
3120         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3121         "style".
3122         * cli-out.c (cli_ui_out::do_table_header)
3123         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3124         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3125         (cli_ui_out::do_field_fmt): Update.
3126         * breakpoint.c (print_breakpoint_location): Update.
3127         (update_static_tracepoint): Update.
3128
3129 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3130
3131         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3132         conversion of gdb_datadir.
3133         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3134         remove not needed c_str ().
3135
3136 2019-09-30  Ali Tamur <tamur@google.com>
3137
3138         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3139         (dwarf2_string_attr): Likewise.
3140
3141 2019-09-30  Ali Tamur <tamur@google.com>
3142
3143         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3144         (process_full_type_unit): Likewise.
3145         (dump_die_shallow): Likewise.
3146         (cu_debug_loc_section): Likewise.
3147
3148 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3149
3150         * minsyms.c (compare_minimal_symbols): Rename to...
3151         (minimal_symbol_is_less_than): ...this, and adjust to STL
3152         conventions (return bool, take arguments as references)
3153         (minimal_symbol_reader::install): Call std::sort instead
3154         of qsort.
3155
3156 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3157
3158         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3159         hash and why.
3160         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3161         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3162
3163 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3164
3165         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3166         * psympriv.h (add_psymbol_to_list): Move comment here and update
3167         it.
3168
3169 2019-09-29  Tom de Vries  <tdevries@suse.de>
3170
3171         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3172         Use $tmpdir/$(basename "$output_file").dwz instead of
3173         "${output_file}.dwz".
3174
3175 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3176
3177         PR gdb/25045
3178         * hppa-linux-nat.c: Include gdbarch.h.
3179
3180 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3181
3182         * blockframe.c (find_pc_partial_function): Change return type to bool.
3183         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3184         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3185         (stub_gnu_ifunc_resolve_name): Likewise.
3186         * symtab.c (compare_filenames_for_search): Likewise.
3187         (compare_glob_filenames_for_search): Likewise.
3188         (matching_obj_sections): Likewise.
3189         (symbol_matches_domain): Likewise.
3190         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3191         (find_line_pc): Change return type to bool.
3192         (find_line_pc_range): Likewise.
3193         (producer_is_realview): Likewise.
3194         * symtab.h (symbol_matches_domain): Likewise.
3195         (find_pc_partial_function): Likewise.
3196         (find_pc_line_pc_range): Likewise.
3197         (in_gnu_ifunc_stub): Likewise.
3198         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3199         (find_line_pc): Likewise.
3200         (find_line_pc_range): Likewise.
3201         (matching_obj_sections): Likewise.
3202         (find_line_symtab): Change out parameter to bool.
3203         (producer_is_realview): Change return type to bool.
3204         (compare_filenames_for_search): Likewise.
3205         (compare_glob_filenames_for_search): Likewise.
3206
3207 2019-09-26  Tom Tromey  <tom@tromey.com>
3208
3209         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3210         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3211         * gdb_usleep.h: Remove.
3212         * gdb_usleep.c: Remove.
3213         * utils.c: Don't include gdb_usleep.h.
3214
3215 2019-09-26  Tom Tromey  <tromey@adacore.com>
3216
3217         * python/py-type.c (type_to_type_object): Call check_typedef
3218         for stub types.
3219
3220 2019-09-26  Tom Tromey  <tom@tromey.com>
3221
3222         * utils.h (initialize_utils): Don't declare.
3223         * top.c (gdb_init): Don't call initialize_utils.
3224         * utils.c (initialize_utils): Remove.  Move contents...
3225         (_initialize_utils): ... here.
3226
3227 2019-09-25  Tom Tromey  <tom@tromey.com>
3228
3229         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3230         * utils.h (make_hex_string): Don't declare.
3231         * utils.c (make_hex_string): Remove.
3232
3233 2019-09-24  Tom de Vries  <tdevries@suse.de>
3234
3235         PR gdb/23815
3236         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3237         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3238
3239 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3240
3241         * NEWS: Mention new simulator port for PRU.
3242
3243 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3244
3245         * ada-exp.y (write_object_remaining): Update.
3246         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3247         and eliminate the static buffer.
3248         (ada_decode_symbol): Update.
3249         (ada_la_decode): Update.
3250         (ada_sniff_from_mangled_name): Update.
3251         (is_valid_name_for_wild_match): Update.
3252         (ada_lookup_name_info::matches): Update and simplify.
3253         (name_matches_regex): Update.
3254         (ada_add_global_exceptions): Update.
3255         * ada-lang.h (ada_decode): Update signature.
3256         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3257         * dwarf-index-write.c (debug_names::insert): Update.
3258
3259 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3260
3261         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3262         formatting.
3263
3264 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3265
3266         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3267         Change "nonzero" to "true" in documentation.
3268
3269 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3270
3271         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3272         (_initialize_darwin_solib): Don't set
3273         darwin_so_ops.lookup_lib_global_symbol.
3274         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3275         set_gdbarch_iterate_over_objfiles_in_search_order.
3276         (elf_lookup_lib_symbol): Rename to...
3277         (svr4_iterate_over_objfiles_in_search_order): this, and update
3278         to iterate semantics.
3279         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3280         * solib.c (solib_global_lookup): Remove.
3281         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3282         (solib_global_lookup): Remove.
3283         * symtab.c (lookup_global_or_static_symbol): Remove call to
3284         solib_global_lookup.
3285
3286 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3287
3288         * NEWS: Move entries about default MI version now being
3289         version 3, and about the GDB/MI fix for multi-location
3290         breakpoints to the "since GDB 8.3" section.
3291
3292 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3293
3294         GDB 8.3.1 released.
3295
3296 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3297
3298         * NEWS: Mention that Cell/B.E. debugging support was removed.
3299         * MAINTAINERS: Remove spu target.
3300
3301         * config/djgpp/fnchange.lst: Remove entries for removed files.
3302
3303         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3304         spu-multiarch.o, and spu-tdep.o.
3305         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3306         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3307         spu-multiarch.c, and spu-tdep.c.
3308         * spu-linux-nat.c: Remove file.
3309         * spu-multiarch.c: Remove file.
3310         * spu-tdep.c: Remove file.
3311         * spu-tdep.h: Remove file.
3312         * solib-spu.c: Remove file.
3313         * solib-spu.h: Remove file.
3314
3315         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3316         * configure.nat (spu-linux): Remove.
3317         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3318         solib-multiarch.o from gdb_target_obs.
3319         (spu*-*-*): Remove.
3320
3321         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3322         feature flag.
3323         (ppc_linux_no_features): Update.
3324         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3325         Cell/B.E. support.
3326         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3327         (tdesc_powerpc_cell64l): Likewise.
3328         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3329         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3330         Cell/B.E. support.
3331         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3332         Do not include "features/rs6000/powerpc-cell32l.c" or
3333         "features/rs6000/powerpc-cell64l.c".
3334         (ppc_linux_spu_section): Remove.
3335         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3336         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3337         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3338         (ppc_linux_spe_context_lookup): Remove.
3339         (ppc_linux_spe_context_inferior_created): Remove.
3340         (ppc_linux_spe_context_solib_loaded): Remove.
3341         (ppc_linux_spe_context_solib_unloaded): Remove.
3342         (ppc_linux_spe_context): Remove.
3343         (struct ppu2spu_cache): Remove.
3344         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3345         (struct ppu2spu_data): Remove.
3346         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3347         ppu2spu_unwind): Remove.
3348         (ppc_linux_init_abi): Remove Cell/B.E. support.
3349         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3350
3351         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3352         (rs6000/powerpc-cell64l-expedite): Likewise
3353         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3354         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3355         rs6000/powerpc-cell64l.xml.
3356         * features/rs6000/powerpc-cell32l.xml: Remove.
3357         * features/rs6000/powerpc-cell64l.xml: Likewise.
3358         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3359         * features/rs6000/powerpc-cell64l.c: Likewise.
3360         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3361         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3362         * regformats/reg-spu.dat: Remove.
3363
3364         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3365         * corelow.c (struct spuid_list): Remove.
3366         (add_to_spuid_list): Remove.
3367         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3368         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3369         (remote_protocol_features): Remove associated entries.
3370         (_initialize_remote): No longer initialize them.
3371         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3372         * linux-nat.c (SPUFS_MAGIC): Remove.
3373         (linux_proc_xfer_spu): Remove.
3374         (spu_enumerate_spu_ids): Remove.
3375         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3376         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3377         (linux_make_corefile_notes): No longer call it.
3378
3379         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3380         (cooked_write_test): Likewise.
3381
3382 2019-09-20  Tom Tromey  <tom@tromey.com>
3383
3384         * NEWS: Mention case-sensitivity of TUI commands.
3385         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3386         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3387         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3388
3389 2019-09-20  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-source.c (tui_source_window::set_contents): Use
3392         make_unique_xstrdup.
3393         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3394         make_unique_xstrdup.
3395
3396 2019-09-20  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-data.c: Remove separator comments.
3399         * tui/tui-layout.c: Remove separator comments.
3400         * tui/tui-win.c: Remove separator comments.
3401         * tui/tui-wingeneral.c: Remove separator comments.
3402
3403 2019-09-20  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui.h (strcat_to_buf): Don't declare.
3406         * tui/tui.c (strcat_to_buf): Remove.
3407
3408 2019-09-20  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3411         from "fullname".
3412         * tui/tui-source.c (tui_source_window::set_contents)
3413         (tui_source_window::location_matches_p)
3414         (tui_source_window::maybe_update): Update.
3415
3416 2019-09-20  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3419         Update.
3420         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3421         prefix.
3422         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3423         (tui_data_window::line_from_reg_element_no)
3424         (tui_data_window::first_reg_element_no_inline)
3425         (tui_data_window::show_registers)
3426         (tui_data_window::show_register_group)
3427         (tui_data_window::display_registers_from)
3428         (tui_data_window::display_registers_from_line)
3429         (tui_data_window::first_data_item_displayed)
3430         (tui_data_window::delete_data_content_windows)
3431         (tui_data_window::erase_data_content)
3432         (tui_data_window::do_scroll_vertical)
3433         (tui_data_window::refresh_window)
3434         (tui_data_window::check_register_values): Update.
3435
3436 2019-09-20  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3439         (struct tui_locator_window) <full_name, proc_name>: Now
3440         std::string.
3441         * tui/tui-stack.c (tui_locator_window::make_status_line)
3442         (tui_locator_window::set_locator_fullname)
3443         (tui_locator_window::set_locator_info): Update.
3444         * tui/tui-source.c (tui_source_window::set_contents)
3445         (tui_source_window::showing_source_p): Update.
3446
3447 2019-09-20  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3450         Don't call tui_locator_win_info_ptr.
3451
3452 2019-09-20  Tom Tromey  <tom@tromey.com>
3453
3454         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3455
3456 2019-09-20  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3459         height for locator.
3460         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3461         * tui/tui-layout.c (show_source_disasm_command, show_data)
3462         (show_source_or_disasm_and_command): Use 1 as height for locator.
3463
3464 2019-09-20  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui.c (tui_enable): Update.
3467         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3468         Update.
3469         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3470         Update.
3471         * tui/tui-data.c (win_resized): Now bool.
3472         (tui_win_resized): Return bool.
3473         (tui_set_win_resized_to): Accept a bool.
3474
3475 2019-09-20  Tom Tromey  <tom@tromey.com>
3476
3477         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3478         Change type of "refresh_values_only".
3479         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3480         type of "refresh_values_only".
3481
3482 2019-09-20  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3485         std::string.
3486         (tui_disassemble): Add "pos" parameter.
3487         (tui_disasm_window::set_contents): Simplify.
3488
3489 2019-09-20  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-winsource.h (struct tui_source_window_base)
3492         <show_source_content>: Now private.
3493         * tui/tui-winsource.c
3494         (tui_source_window_base::show_source_content): Don't handle empty
3495         content case.
3496
3497 2019-09-20  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-layout.c (show_source_disasm_command)
3500         (show_source_or_disasm_and_command): Don't call
3501         show_source_content.
3502
3503 2019-09-20  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3506         Declare.
3507         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3508         from tui_make_status_line.
3509         (tui_locator_window::rerender): Update.
3510
3511 2019-09-20  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3514         (tui_locator_window::rerender): Update.
3515
3516 2019-09-20  Tom Tromey  <tom@tromey.com>
3517
3518         * tui/tui-winsource.h (struct tui_source_window_base)
3519         <~tui_source_window_base>: Don't declare.
3520         <fullname>: Remove.
3521         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3522         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3523         member.
3524         * tui/tui-source.c (tui_source_window::set_contents): Update.
3525         (tui_source_window::location_matches_p)
3526         (tui_source_window::maybe_update): Update.
3527
3528 2019-09-20  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-winsource.h (~tui_source_element): Remove.
3531         (tui_source_element): Update.
3532         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3533         * tui/tui-winsource.c (tui_show_source_line): Update.
3534         * tui/tui-source.c (tui_source_window::set_contents): Update.
3535         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3536
3537 2019-09-20  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3540         declare.
3541         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3542         tui_clear_source_windows_detail.
3543         * tui/tui-winsource.h (struct tui_source_window_base)
3544         <clear_detail>: Don't declare.
3545         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3546         Remove.
3547         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3548
3549 2019-09-20  Tom Tromey  <tromey@adacore.com>
3550
3551         PR ada/24919:
3552         * block.c (contained_in): Fix final return value.
3553
3554 2019-09-20  Alan Modra  <amodra@gmail.com>
3555
3556         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3557         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3558         (read_indirect_string_from_dwz): Use bfd accessor.
3559         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3560         * machoread.c (macho_symfile_read_all_oso): Likewise.
3561         * solib.c (solib_bfd_open): Likewise.
3562
3563 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3564
3565         * eval.c: Move declaration of overload_resolution to...
3566         * value.h: ...here.
3567
3568 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3569
3570         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3571         * arm-linux-tdep.c: Likewise.
3572         * arm-nbsd-nat.c: Likewise.
3573         * arm-tdep.h: Declare arm_apcs_32.
3574         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3575
3576 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3577
3578         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3579         * dwarf2read.h: Declare dwarf_always_disassemble.
3580
3581 2019-09-19  Tom de Vries  <tdevries@suse.de>
3582
3583         PR gdb/25009
3584         * source-cache.c (source_cache::ensure): Catch exception thrown during
3585         construction of the highlighter.
3586
3587 2019-09-18  Alan Modra  <amodra@gmail.com>
3588
3589         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3590         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3591         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3592         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3593         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3594         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3595         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3596         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3597         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3598         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3599         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3600         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3601         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3602         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3603         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3604         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3605         * mi/mi-interp.c: Update throughout for bfd section macro and
3606         function changes.
3607         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3608         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3609
3610 2019-09-18  Tom Tromey  <tom@tromey.com>
3611
3612         * NEWS: Add entry.
3613         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3614         call rl_initialize.
3615         (tui_enable): Do not call rl_initialize.
3616
3617 2019-09-18  Christian Groessler  <chris@groessler.org>
3618
3619         * alpha-linux-nat.c: Include gdbarch.h.
3620
3621 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3622
3623         * ui-file.c: Include cli/cli-style.h.
3624         (term_cli_styling): Remove cli_styling declaration.
3625
3626 2019-09-18  Alan Modra  <amodra@gmail.com>
3627
3628         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3629         to bfd_asymbol_section.
3630
3631 2019-09-18  Alan Modra  <amodra@gmail.com>
3632
3633         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3634         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3635         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3636
3637 2019-09-18  Alan Modra  <amodra@gmail.com>
3638
3639         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3640         * spu-linux-nat.c (spu_bfd_open): Likewise.
3641
3642 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3643
3644         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3645         to bool to match definition in dwarf2read.c.
3646
3647 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3648
3649         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3650         (print_signatures): Likewise.
3651         (trust_pad_over_xvs): Likewise.
3652         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3653         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3654         * arm-linux-nat.c (arm_apcs_32): Likewise.
3655         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3656         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3657         * arm-tdep.c (arm_debug): Likewise.
3658         (arm_apcs_32): Likewise.
3659         * auto-load.c (debug_auto_load): Likewise.
3660         (auto_load_gdb_scripts): Likewise.
3661         (global_auto_load): Likewise.
3662         (auto_load_local_gdbinit): Likewise.
3663         (auto_load_local_gdbinit_loaded): Likewise.
3664         * auto-load.h (global_auto_load): Likewise.
3665         (auto_load_local_gdbinit): Likewise.
3666         (auto_load_local_gdbinit_loaded): Likewise.
3667         * breakpoint.c (disconnected_dprintf): Likewise.
3668         (breakpoint_proceeded): Likewise.
3669         (automatic_hardware_breakpoints): Likewise.
3670         (always_inserted_mode): Likewise.
3671         (target_exact_watchpoints): Likewise.
3672         (_initialize_breakpoint): Update.
3673         * breakpoint.h (target_exact_watchpoints): Change to bool.
3674         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3675         * cli/cli-cmds.c (trace_commands): Likewise.
3676         * cli/cli-cmds.h (trace_commands): Likewise.
3677         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3678         to bool*.
3679         * cli/cli-logging.c (logging_overwrite): Change to bool.
3680         (logging_redirect): Likewise.
3681         (debug_redirect): Likewise.
3682         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3683         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3684         to bool.
3685         <boolean_option_def>: Update.
3686         (struct flag_option_def): Change default type of Context to bool
3687         from int.
3688         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3689         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3690         (get_setshow_command_value_string): Likewise.
3691         * cli/cli-style.c (cli_styling): Change to bool.
3692         (source_styling): Likewise.
3693         * cli/cli-style.h (source_styling): Likewise.
3694         (cli_styling): Likewise.
3695         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3696         to bool.
3697         * command.h (var_types): Update comment.
3698         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3699         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3700         bool.
3701         (debug_compile_cplus_scopes): Likewise.
3702         * compile/compile-internal.h (compile_debug): Likewise.
3703         * compile/compile.c (compile_debug): Likewise.
3704         (struct compile_options) <raw>: Likewise.
3705         * cp-support.c (catch_demangler_crashes): Likewise.
3706         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3707         (usr_cmd_cris_dwarf2_cfi): Likewise.
3708         * csky-tdep.c (csky_debug): Likewise.
3709         * darwin-nat.c (enable_mach_exceptions): Likewise.
3710         * dcache.c (dcache_enabled_p): Likewise.
3711         * defs.h (info_verbose): Likewise.
3712         * demangle.c (demangle): Likewise.
3713         (asm_demangle): Likewise.
3714         * dwarf-index-cache.c (debug_index_cache): Likewise.
3715         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3716         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3717         * dwarf2read.c (check_physname): Likewise.
3718         (use_deprecated_index_sections): Likewise.
3719         (dwarf_always_disassemble): Likewise.
3720         * eval.c (overload_resolution): Likewise.
3721         * event-top.c (set_editing_cmd_var): Likewise.
3722         (exec_done_display_p): Likewise.
3723         * event-top.h (set_editing_cmd_var): Likewise.
3724         (exec_done_display_p): Likewise.
3725         * exec.c (write_files): Likewise.
3726         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3727         (debug_fbsd_nat): Likewise.
3728         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3729         Likewise.
3730         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3731         <backtrace_past_entry> Likewise.
3732         * gdb-demangle.h (demangle): Likewise.
3733         (asm_demangle): Likewise.
3734         * gdb_bfd.c (bfd_sharing): Likewise.
3735         * gdbcore.h (write_files): Likewise.
3736         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3737         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3738         * gdbthread.h (print_thread_events): Likewise.
3739         * gdbtypes.c (opaque_type_resolution): Likewise.
3740         (strict_type_checking): Likewise.
3741         * gnu-nat.c (gnu_debug_flag): Likewise.
3742         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3743         * guile/scm-param.c (pascm_variable): Add boolval.
3744         (add_setshow_generic): Update.
3745         (pascm_param_value): Update.
3746         (pascm_set_param_value_x): Update.
3747         * hppa-tdep.c (hppa_debug): Change to bool..
3748         * infcall.c (may_call_functions_p): Likewise.
3749         (coerce_float_to_double_p): Likewise.
3750         (unwind_on_signal_p): Likewise.
3751         (unwind_on_terminating_exception_p): Likewise.
3752         * infcmd.c (startup_with_shell): Likewise.
3753         * inferior.c (print_inferior_events): Likewise.
3754         * inferior.h (startup_with_shell): Likewise.
3755         (print_inferior_events): Likewise.
3756         * infrun.c (step_stop_if_no_debug): Likewise.
3757         (detach_fork): Likewise.
3758         (debug_displaced): Likewise.
3759         (disable_randomization): Likewise.
3760         (non_stop): Likewise.
3761         (non_stop_1): Likewise.
3762         (observer_mode): Likewise.
3763         (observer_mode_1): Likewise.
3764         (set_observer_mode): Update.
3765         (sched_multi): Change to bool.
3766         * infrun.h (debug_displaced): Likewise.
3767         (sched_multi): Likewise.
3768         (step_stop_if_no_debug): Likewise.
3769         (non_stop): Likewise.
3770         (disable_randomization): Likewise.
3771         * linux-tdep.c (use_coredump_filter): Likewise.
3772         (dump_excluded_mappings): Likewise.
3773         * linux-thread-db.c (auto_load_thread_db): Likewise.
3774         (check_thread_db_on_load): Likewise.
3775         * main.c (captured_main_1): Update.
3776         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3777         xx2_opt, boolean_opt>: Change to bool.
3778         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3779         * maint.c (maintenance_profile_p): Likewise.
3780         (per_command_time): Likewise.
3781         (per_command_space): Likewise.
3782         (per_command_symtab): Likewise.
3783         * memattr.c (inaccessible_by_default): Likewise.
3784         * mi/mi-main.c (mi_async): Likewise.
3785         (mi_async_1): Likewise.
3786         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3787         * nat/fork-inferior.h (startup_with_shell): Likewise.
3788         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3789         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3790         * nios2-tdep.c (nios2_debug): Likewise.
3791         * or1k-tdep.c (or1k_debug): Likewise.
3792         * parse.c (parser_debug): Likewise.
3793         * parser-defs.h (parser_debug): Likewise.
3794         * printcmd.c (print_symbol_filename): Likewise.
3795         * proc-api.c (procfs_trace): Likewise.
3796         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3797         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3798         (set_parameter_value): Update.
3799         (add_setshow_generic): Update.
3800         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3801         to bool*.
3802         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3803         int*.
3804         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3805         * record-btrace.c (record_btrace_target::store_registers): Update.
3806         * record-full.c (record_full_memory_query): Change to bool.
3807         (record_full_stop_at_limit): Likewise.
3808         * record-full.h (record_full_memory_query): Likewise.
3809         * remote-notif.c (notif_debug): Likewise.
3810         * remote-notif.h (notif_debug): Likewise.
3811         * remote.c (use_range_stepping): Likewise.
3812         (interrupt_on_connect): Likewise.
3813         (remote_break): Likewise.
3814         * ser-tcp.c (tcp_auto_retry): Likewise.
3815         * ser-unix.c (serial_hwflow): Likewise.
3816         * skip.c (debug_skip): Likewise.
3817         * solib-aix.c (solib_aix_debug): Likewise.
3818         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3819         (spu_auto_flush_cache_p): Likewise.
3820         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3821         Likewise.
3822         (struct info_print_options) <quiet>: Likewise.
3823         * symfile-debug.c (debug_symfile): Likewise.
3824         * symfile.c (auto_solib_add): Likewise.
3825         (separate_debug_file_debug): Likewise.
3826         * symfile.h (auto_solib_add): Likewise.
3827         (separate_debug_file_debug): Likewise.
3828         * symtab.c (basenames_may_differ): Likewise.
3829         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3830         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3831         (struct info_types_options) <quiet>: Likewise.
3832         * symtab.h (demangle): Likewise.
3833         (basenames_may_differ): Likewise.
3834         * target-dcache.c (stack_cache_enabled_1): Likewise.
3835         (code_cache_enabled_1): Likewise.
3836         * target.c (trust_readonly): Likewise.
3837         (may_write_registers): Likewise.
3838         (may_write_memory): Likewise.
3839         (may_insert_breakpoints): Likewise.
3840         (may_insert_tracepoints): Likewise.
3841         (may_insert_fast_tracepoints): Likewise.
3842         (may_stop): Likewise.
3843         (auto_connect_native_target): Likewise.
3844         (target_stop_and_wait): Update.
3845         (target_async_permitted): Change to bool.
3846         (target_async_permitted_1): Likewise.
3847         (may_write_registers_1): Likewise.
3848         (may_write_memory_1): Likewise.
3849         (may_insert_breakpoints_1): Likewise.
3850         (may_insert_tracepoints_1): Likewise.
3851         (may_insert_fast_tracepoints_1): Likewise.
3852         (may_stop_1): Likewise.
3853         * target.h (target_async_permitted): Likewise.
3854         (may_write_registers): Likewise.
3855         (may_write_memory): Likewise.
3856         (may_insert_breakpoints): Likewise.
3857         (may_insert_tracepoints): Likewise.
3858         (may_insert_fast_tracepoints): Likewise.
3859         (may_stop): Likewise.
3860         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3861         (make_thread_apply_all_options_def_group): Change argument from int*
3862         to bool*.
3863         (thread_apply_all_command): Update.
3864         (print_thread_events): Change to bool.
3865         * top.c (confirm): Likewise.
3866         (command_editing_p): Likewise.
3867         (history_expansion_p): Likewise.
3868         (write_history_p): Likewise.
3869         (info_verbose): Likewise.
3870         * top.h (confirm): Likewise.
3871         (history_expansion_p): Likewise.
3872         * tracepoint.c (disconnected_tracing): Likewise.
3873         (circular_trace_buffer): Likewise.
3874         * typeprint.c (print_methods): Likewise.
3875         (print_typedefs): Likewise.
3876         * utils.c (debug_timestamp): Likewise.
3877         (sevenbit_strings): Likewise.
3878         (pagination_enabled): Likewise.
3879         * utils.h (sevenbit_strings): Likewise.
3880         (pagination_enabled): Likewise.
3881         * valops.c (overload_resolution): Likewise.
3882         * valprint.h (struct value_print_options) <prettyformat_arrays,
3883         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3884         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3885         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3886         Likewise.
3887         * windows-nat.c (new_console): Likewise.
3888         (cygwin_exceptions): Likewise.
3889         (new_group): Likewise.
3890         (debug_exec): Likewise.
3891         (debug_events): Likewise.
3892         (debug_memory): Likewise.
3893         (debug_exceptions): Likewise.
3894         (useshell): Likewise.
3895         * windows-tdep.c (maint_display_all_tib): Likewise.
3896         * xml-support.c (debug_xml): Likewise.
3897
3898 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3899
3900         * source.c (prepare_path_for_appending): New function.
3901         (openp): Make use of new function.
3902         (find_and_open_source): Search for the compilation directory and
3903         source file as a relative path beneath the directory search path.
3904
3905 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * source-cache.c (source_cache::get_line_charpos): Catch
3908         exceptions and return false, this matches the behaviour documented
3909         in the header file.
3910
3911 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3912
3913         * ada-tasks.c (info_task): Remove quoting of the task's name.
3914
3915 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3916
3917         * symfile.c (auto_solib_add): Replace comment with a reference
3918         to the header file.
3919
3920 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3921
3922         * NEWS: Mention that gdb can now be compiled with Python 3
3923         on Windows.
3924
3925 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3926
3927         * maint.c (maint_print_section_data::maint_print_section_data):
3928         Force use of 'float log10 (float)' by casting the argument to
3929         float.
3930
3931 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * maint.c: Add 'cmath' include.
3934         (struct maint_print_section_data): New structure.
3935         (print_section_index): New function.
3936         (print_bfd_section_info): Add header comment, small whitespace
3937         cleanup, and update to call new print_section_index function.
3938         (print_objfile_section_info): Likewise.
3939         (maint_obj_section_from_bfd_section): New function.
3940         (print_bfd_section_info_maybe_relocated): New function.
3941         (maintenance_info_sections): Add header comment, always use
3942         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3943
3944 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3945
3946         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3947         inner scope, add check that the objfile has psymtabs before
3948         checking psymtabs_addrmap.
3949         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3950
3951 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3952
3953         * NEWS: Announce that Ada task names are now shown at more places,
3954         and between quotes (except in info task output).
3955         * gdb/ada-tasks.c (task_to_str): New function.
3956         (display_current_task_id): Call task_to_str.
3957         (task_command_1): Likewise.
3958         (print_ada_task_info): In non-mi mode, Properly align headers and data
3959         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3960
3961 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3962
3963         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3964         prstatus.pr_lwp.pr_info instead of making it up.
3965
3966 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3967
3968         * auto-load.c (auto_load_expand_dir_vars): Update.
3969         * defs.h (gdb_datadir): Change to std::string.
3970         (python_libdir): Likewise.
3971         (relocate_gdb_directory): Change return type to std::string.
3972         * guile/guile.c (gdbscm_data_directory): Update.
3973         (initialize_scheme_side): Update.
3974         * jit.c (jit_reader_dir): Change to std::string.
3975         (jit_reader_load_command): Update.
3976         * main.c (gdb_datadir): Change to std::string.
3977         (python_libdir): Likewise.
3978         (set_gdb_data_directory): Update.
3979         (relocate_path): Change to return std::string.
3980         (relocate_gdb_directory): Change to return std::string.
3981         (relocate_gdbinit_path_maybe_in_datadir): Update.
3982         (captured_main_1): Update.
3983         * python/python.c (do_start_initialization): Update.
3984         * top.c (show_gdb_datadir): Update.
3985         * xml-syscall.c (xml_init_syscalls_info): Update.
3986         (init_syscalls_info): Update.
3987
3988 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3989
3990         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3991         out of get_init_files.
3992         (get_init_files): Update.
3993
3994 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3995
3996         * main.c (get_init_files): Change to use std::string.
3997         (captured_main_1): Update.
3998         (print_gdb_help): Update.
3999
4000 2019-09-11  Ali Tamur  <tamur@google.com>
4001
4002         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4003         implementation.
4004
4005 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4006
4007         * dbxread.c (read_dbx_symtab): Update.
4008         * dwarf2read.c (load_partial_dies): Update.
4009         * mdebugread.c (parse_partial_symbols): Update.
4010         (handle_psymbol_enumerators): Update.
4011         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4012         * psymtab.c (add_psymbol_to_bcache): Likewise.
4013         (add_psymbol_to_list): Likewise.
4014         * symtab.c (symbol_set_names): Likewise.
4015         * symtab.h (symbol_set_names): Likewise.
4016         * xcoffread.c (scan_xcoff_symtab): Update.
4017
4018 2019-09-11  Tom Tromey  <tom@tromey.com>
4019
4020         * symfile-mem.c (symbol_file_add_from_memory): Use
4021         bfd_set_filename.
4022         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4023         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4024
4025 2019-09-10  Tom Tromey  <tromey@adacore.com>
4026
4027         * dwarf-index-write.c (write_psymbols): Extend error message.
4028         (debug_names::insert): Add Ada code.
4029         (debug_names::write_psymbols): Remove Ada check.
4030         (debug_names) <m_string_obstack>: New member.
4031         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4032         (gdb_index_symbol_name_matcher::matches): Remove.
4033         (mapped_index_base::find_name_components_bounds): Add "lang"
4034         parameter.
4035         (mapped_index_base::build_name_components): Also split names
4036         according to Ada syntax.
4037         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4038         type of "match_callback".
4039         (check_match, check_find_bounds_finds)
4040         (dw2_expand_symtabs_matching): Update.
4041         (dw2_debug_names_iterator): Add new constructor.
4042         (dw2_debug_names_map_matching_symbols): New function.
4043         (dw2_debug_names_expand_symtabs_matching): Update.
4044         (dwarf2_debug_names_functions): Use
4045         dw2_debug_names_map_matching_symbols.
4046
4047 2019-09-10  Tom Tromey  <tromey@adacore.com>
4048
4049         * dwarf2read.c (dw2_get_file_names_reader): Add the
4050         CU's file name to the results.
4051
4052 2019-09-10  Tom Tromey  <tromey@adacore.com>
4053
4054         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4055         map_matching_symbols.  Update.
4056         * dwarf2read.c (dw2_map_matching_symbols): Update.
4057         * psymtab.c (match_partial_symbol): Change type; update.
4058         (psym_map_matching_symbols): Likewise.
4059         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4060         type; update.
4061         * symfile.h (struct quick_symbol_functions)
4062         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4063         Remove "match".
4064
4065 2019-09-10  Tom Tromey  <tromey@adacore.com>
4066
4067         * psymtab.c (map_block): Remove.
4068         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4069         * symtab.c (iterate_over_symbols_terminated): New function.
4070         * symtab.c (iterate_over_symbols_terminated): Declare.
4071
4072 2019-09-10  Tom Tromey  <tromey@adacore.com>
4073
4074         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4075         * language.h (struct language_defn) <la_iterate_over_symbols>:
4076         Return bool.
4077         * symtab.c (iterate_over_symbols): Return bool.
4078         * symtab.h (iterate_over_symbols): Return bool.
4079
4080 2019-09-10  Tom Tromey  <tromey@adacore.com>
4081
4082         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4083         (add_nonlocal_symbols): Update.
4084         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4085         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4086         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4087         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4088         Change type of "callback".  Remove "data".
4089
4090
4091 2019-09-09  Ali Tamur  <tamur@google.com>
4092
4093         * dwarf2read.c (comp_unit_head): Update comment.
4094         (dwarf2_dwo_name): New function declaration.
4095         (dwarf_unit_type_name): New function declaration.
4096         (read_comp_unit_head): Add support for new compilation units,
4097         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4098         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4099         (currently named as "signature") in their header. Also clarify error
4100         messages.
4101         (lookup_dwo_id): New function. Returns the dwo id of the given
4102         compile unit.
4103         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4104         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4105         functions.
4106         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4107         (dwarf2_dwo_name): Get the dwo name if present.
4108         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4109         purposes.
4110
4111 2019-09-09  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4114
4115 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4116
4117         * python/python.c (do_start_initialization): Make progname_copy static,
4118         to avoid a leak report.
4119
4120 2019-09-08  Tom Tromey  <tom@tromey.com>
4121
4122         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4123
4124 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4125
4126         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4127         Change type to gdb::optional<block_enum>.
4128         (dw2_symtab_iter_init): Change block_index parameter type
4129         to gdb::optional<block_enum>.
4130         (dw2_lookup_symbol): Change block_index parameter
4131         type to block_enum.c
4132         (dw2_debug_names_lookup_symbol): Likewise.
4133         * psymtab.c (psym_lookup_symbol): Likewise.
4134         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4135         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4136         Likewise.
4137
4138 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4139
4140         * defs.h (relocate_gdb_directory): Change int to bool in
4141         signature and rename flag to relocatable.
4142         * main.c (relocate_path): Likewise.
4143         (relocate_gdb_directory): Likewise.
4144
4145 2019-09-06  Alan Modra  <amodra@gmail.com>
4146
4147         * coffread.c (coff_symfile_read): Constify filename variable.
4148         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4149         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4150         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4151         * solib.c (reload_shared_libraries_1): Likewise.
4152         * symfile.c (reread_symbols): Likewise.
4153         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4154         * solib-darwin.c (darwin_bfd_open): Likewise.
4155         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4156
4157 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4160         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4161
4162 2019-09-03  Tom Tromey  <tromey@adacore.com>
4163
4164         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4165         types.
4166         (has_negatives): Unbias a range type bound.
4167         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4168         * gdbtypes.c (operator==): Handle new field.
4169         (create_range_type): Add "bias" parameter.
4170         (create_static_range_type, resolve_dynamic_range): Update.
4171         * gdbtypes.h (struct range_bounds) <bias>: New member.
4172         (create_range_type): Add bias parameter.
4173         * printcmd.c (print_scalar_formatted): Unbias range types.
4174         * value.c (unpack_long): Unbias range types.
4175         (pack_long): Bias range types.
4176
4177 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4178
4179         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4180         probe arguments.
4181
4182 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4183
4184         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4185         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4186         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4187         (compile_probe_arg): Likewise.
4188         * probe.h (get_argument_count): Likewise.
4189         * solib-svr4.c (solib_event_probe_action): Likewise.
4190         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4191
4192 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4193
4194         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4195         code to here...
4196         (svr4_create_solib_event_breakpoints): ...from here.
4197
4198 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4199
4200         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4201         suffix from warning message.
4202
4203 2019-08-30  Tom Tromey  <tom@tromey.com>
4204
4205         * tui/tui-winsource.h (struct tui_source_window_base)
4206         <refresh_all>: Don't declare.
4207         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4208         Remove.
4209         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4210         tui_show_locator_content.
4211         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4212         declare.
4213         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4214         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4215         declare.
4216
4217 2019-08-30  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4220
4221 2019-08-30  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4224         Remove unnecessary forward declarations.
4225
4226 2019-08-30  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4229         rerender.
4230         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4231         tui_show_locator_content.
4232
4233 2019-08-30  Tom Tromey  <tom@tromey.com>
4234
4235         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4236         (tui_locator_window::rerender): Rewrite using body of previous
4237         tui_show_locator_content.
4238
4239 2019-08-30  Tom Tromey  <tom@tromey.com>
4240
4241         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4242         set_locator_fullname>: New methods.
4243         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4244         Rename from tui_set_locator_fullname.
4245         (tui_locator_window::set_locator_info): Rename from
4246         tui_set_locator_info.  Return bool.
4247         (tui_update_locator_fullname, tui_show_frame_info): Update.
4248
4249 2019-08-30  Tom Tromey  <tom@tromey.com>
4250
4251         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4252
4253 2019-08-30  Tom Tromey  <tom@tromey.com>
4254
4255         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4256         call touchwin.
4257
4258 2019-08-30  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-wingeneral.c (box_win): Assume win_info and
4261         win_info->handle cannot be NULL.
4262
4263 2019-08-30  Tom Tromey  <tom@tromey.com>
4264
4265         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4266         refresh_window>: Declare.
4267         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4268         resize.
4269         (tui_data_item_window::rerender): Rename from
4270         tui_display_register.
4271         (tui_data_item_window::refresh_window): New method.
4272         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4273         no-op.
4274
4275 2019-08-30  Tom Tromey  <tom@tromey.com>
4276
4277         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4278         regs_column_count, current_group>: Move later.  Now private.
4279         <get_current_group>: New method.
4280         * tui/tui-regs.c (tui_reg_command): Update.
4281         * tui/tui-layout.c (tui_set_layout): Update.
4282
4283 2019-08-30  Tom Tromey  <tom@tromey.com>
4284
4285         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4286         (tui_data_window::rerender): Don't call
4287         check_and_display_highlight_if_needed.
4288         (tui_data_window::refresh_all): Remove call to
4289         erase_data_content.
4290
4291 2019-08-30  Tom Tromey  <tom@tromey.com>
4292
4293         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4294         (tui_data_window::display_registers_from)
4295         (tui_data_window::display_reg_element_at_line)
4296         (tui_data_window::display_registers_from_line): Remove checks of
4297         "empty".
4298
4299 2019-08-30  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4302         Don't declare.
4303         * tui/tui-regs.c (tui_data_window::show_registers): Call
4304         rerender.
4305         (tui_data_window::rerender): Rename from display_all_data.
4306         (tui_data_window::rerender): Remove old implementation.
4307
4308 2019-08-30  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4311         text.
4312         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4313
4314 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4315             Sergio Durigan Junior  <sergiodj@redhat.com>
4316
4317         PR win32/24284
4318         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4319
4320 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4323         when searching for types.
4324
4325 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4326
4327         * f-lang.c (f_language_defn): Use f_print_typedef.
4328         * f-lang.h (f_print_typedef): Declare.
4329         * f-typeprint.c (f_print_typedef): Define.
4330
4331 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4332
4333         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4334
4335 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4336
4337         * cli/cli-utils.c (info_print_options_defs): Delete.
4338         (make_info_print_options_def_group): Delete.
4339         (extract_info_print_options): Delete.
4340         (info_print_command_completer): Delete.
4341         (info_print_args_help): Add extra parameter, and optionally
4342         include text about -n flag.
4343         * cli/cli-utils.h (struct info_print_options): Delete.
4344         (extract_info_print_options): Delete declaration.
4345         (info_print_command_completer): Delete declaration.
4346         (info_print_args_help): Add extra parameter, extend header
4347         comment.
4348         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4349         search_symbols.
4350         * stack.c (struct info_print_options): New type.
4351         (info_print_options_defs): New file scoped variable.
4352         (make_info_print_options_def_group): New static function.
4353         (info_print_command_completer): New static function.
4354         (info_locals_command): Update to use new local functions.
4355         (info_args_command): Likewise.
4356         (_initialize_stack): Add extra parameter to calls to
4357         info_print_args_help.
4358         * symtab.c (search_symbols): Add extra parameter, use this to
4359         possibly excluse non-debug symbols.
4360         (symtab_symbol_info): Add extra parameter, which is passed on to
4361         search_symbols.
4362         (struct info_print_options): New type.
4363         (info_print_options_defs): New file scoped variable.
4364         (make_info_print_options_def_group): New static function.
4365         (info_print_command_completer): New static function.
4366         (info_variables_command): Update to use local functions, and pass
4367         extra parameter through to symtab_symbol_info.
4368         (info_functions_command): Likewise.
4369         (info_types_command): Pass additional argument through to
4370         symtab_symbol_info.
4371         (rbreak_command): Pass extra argument to search_symbols.
4372         (_initialize_symtab): Add extra arguments for calls to
4373         info_print_args_help, and update help text for 'info variables',
4374         'whereis', and 'info functions' commands.
4375         * symtab.h (search_symbols): Add extra argument to declaration.
4376         * NEWS: Mention new flags.
4377
4378 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4379
4380         * symtab.c (lookup_static_symbol): Call the new function (and move
4381         it down to be next to lookup_global_symbol).
4382         (struct global_sym_lookup_data): Add block_enum member and rename to...
4383         (struct global_or_static_sym_lookup_data): ...this.
4384         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4385         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4386         (lookup_symbol_global_or_static_iterator_cb): ...this.
4387         (lookup_global_or_static_symbol): New function.
4388         (lookup_global_symbol): Call new function.
4389
4390 2019-08-26  Tom de Vries  <tdevries@suse.de>
4391
4392         PR c++/24852
4393         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4394         when pc_probe.prob == NULL.
4395
4396 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4397
4398         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4399         variable symbol_linkage to symbol_linkage_.
4400
4401 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4402
4403         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4404         represent whether the symbol is static, dynamic, or we don't
4405         know.
4406
4407 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4408
4409         * gdb/rx-tdep.c (rx_register_names): New.
4410         (rx_register_name): Delete.
4411         (rx_psw_type): Delete.
4412         (rx_fpsw_type): Delete.
4413         (rx_register_type): Delete.
4414         (rx_gdbarch_init): Convert target-descriptions.
4415         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4416         * gdb/features/Makefile: Add rx.xml.
4417         * gdb/features/rx.xml: New.
4418         * gdb/features/rx.c: Generated.
4419         * gdb/NEWS: Mention target description support.
4420
4421 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4422
4423         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4424         *slot_ptr.
4425
4426 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4427
4428         * configure.ac: Don't check for 'dlfcn.h' (moved to
4429         gdbsupport/common.m4).
4430         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4431         'gdbsupport/'.
4432         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4433         * compile/compile-c-support.c: Include
4434         'gdbsupport/gdb-dlfcn.h'.
4435         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4436         * gdb-dlfcn.c: Move to...
4437         * gdbsupport/gdb-dlfcn.c: ... here.
4438         * gdb-dlfcn.h: Move to...
4439         * gdbsupport/gdb-dlfcn.h: ... here.
4440
4441 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4442
4443         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4444         the offset field signed.
4445
4446 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4447
4448         * python/lib/gdb/__init__.py (_execute_file): New function.
4449         * python/python.c (python_run_simple_file): Call gdb._execute_file
4450         on Windows.
4451
4452 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4453
4454         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4455         all uses as this was never set to anything but a zero value.
4456
4457 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4458
4459         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4460
4461 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4462
4463         * tui/tui-data.h (tui_gen_win_info): Add an =default
4464         move constructor, required by some GCC versions.
4465
4466 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4467
4468         * go32-nat.c (go32_sysinfo): Add hygon_p.
4469
4470 2019-08-20  Tom Tromey  <tom@tromey.com>
4471
4472         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4473         line_from_reg_element_no, first_reg_element_no_inline,
4474         display_all_data, delete_data_content_windows,
4475         erase_data_content>: Now private.
4476
4477 2019-08-20  Tom Tromey  <tom@tromey.com>
4478
4479         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4480         (tui_unhighlight_win, tui_highlight_win)
4481         (tui_win_info::make_window): Update.
4482         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4483
4484 2019-08-20  Tom Tromey  <tom@tromey.com>
4485
4486         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4487         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4488         (MAX_PID_WIDTH): Move to tui-stack.c.
4489         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4490         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4491         (MAX_PID_WIDTH): Move from tui-data.h.
4492
4493 2019-08-20  Tom Tromey  <tom@tromey.com>
4494
4495         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4496         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4497         (box_win): Update.
4498         (tui_gen_win_info::make_window): Rename from tui_make_window.
4499         (tui_win_info::make_window): New method.
4500         (tui_gen_win_info::make_visible): Update.
4501         * tui/tui-source.c (tui_source_window::set_contents): Update.
4502         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4503         (tui_data_window::display_registers_from): Update.
4504         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4505         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4506         Declare.
4507         <can_box>: Remove.
4508         <title>: Remove.
4509         (struct tui_win_info) <make_window>: Declare.
4510         <can_box>: Now virtual.
4511         <title>: New member.
4512         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4513         * tui/tui-command.c (tui_cmd_window::resize): Update.
4514
4515 2019-08-20  Tom Tromey  <tom@tromey.com>
4516
4517         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4518         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4519         (tui_data_window::check_register_values): Update.
4520
4521 2019-08-20  Tom Tromey  <tom@tromey.com>
4522
4523         * tui/tui-regs.h (struct tui_data_window): Use
4524         DISABLE_COPY_AND_ASSIGN.
4525         <regs_content>: Change type, removing unique_ptr.
4526         <tui_data_window>: Add move constructor.
4527         * tui/tui-regs.c (tui_data_window::show_registers)
4528         (tui_data_window::show_register_group)
4529         (tui_data_window::display_registers_from)
4530         (tui_data_window::display_registers_from)
4531         (tui_data_window::first_data_item_displayed)
4532         (tui_data_window::delete_data_content_windows)
4533         (tui_data_window::rerender, tui_data_window::refresh_window)
4534         (tui_data_window::check_register_values): Update.
4535
4536 2019-08-20  Tom Tromey  <tom@tromey.com>
4537
4538         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4539         show_register_group>: Declare.
4540         (tui_show_register_group): Don't declare.
4541         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4542         tui_show_registers.
4543         (tui_data_window::show_register_group): Rename from
4544         tui_show_register_group.
4545         (tui_data_window::check_register_values, tui_reg_command):
4546         Update.
4547         * tui/tui-layout.c (tui_set_layout): Update.
4548
4549 2019-08-20  Tom Tromey  <tom@tromey.com>
4550
4551         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4552         Declare.
4553         (tui_check_register_values): Don't declare.
4554         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4555         from tui_check_register_values.
4556         * tui/tui-hooks.c (tui_register_changed): Update.
4557
4558 2019-08-20  Tom Tromey  <tom@tromey.com>
4559
4560         * tui/tui-regs.c (tui_reg_layout): Move later.
4561         (tui_show_registers): Don't enable TUI mode or change layout.
4562
4563 2019-08-20  Tom Tromey  <tom@tromey.com>
4564
4565         * tui/tui-regs.h (struct tui_data_item_window)
4566         <~tui_data_item_window>: Remove.
4567         <content>: Now a unique_xmalloc_ptr.
4568         * tui/tui-regs.c (tui_register_format): Return a
4569         unique_xmalloc_ptr.
4570         (tui_get_register): Update.
4571         (~tui_data_item_window): Remove.
4572         (tui_data_window::display_registers_from, tui_display_register):
4573         Update.
4574         * tui/tui-io.h (tui_expand_tabs): Update.
4575         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4576         Remove "col" parameter.
4577
4578 2019-08-20  Tom Tromey  <tom@tromey.com>
4579
4580         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4581         field.
4582         * tui/tui-regs.c (~tui_data_item_window): Update.
4583
4584 2019-08-20  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4587         earlier.
4588
4589 2019-08-20  Tom Tromey  <tom@tromey.com>
4590
4591         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4592
4593 2019-08-20  Tom Tromey  <tom@tromey.com>
4594
4595         * tui/tui-source.h (struct tui_source_window): Update.
4596         * tui/tui-regs.c (tui_show_registers): Update.
4597         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4598         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4599         (NO_REGS_STRING): Remove defines.
4600
4601 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4602
4603         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4604         unnecessary thread walk if remote doesn't support the packet.
4605
4606 2019-08-19  Tom Tromey  <tromey@adacore.com>
4607
4608         * python/py-value.c (value_has_field): Fix indentation.
4609
4610 2019-08-19  Tom Tromey  <tromey@adacore.com>
4611
4612         * printcmd.c (do_one_display, info_display_command): Update.
4613         * block.h (contained_in): Return bool.  Add allow_nested
4614         parameter.
4615         * block.c (contained_in): Return bool.  Add allow_nested
4616         parameter.
4617
4618 2019-08-19  Tom Tromey  <tom@tromey.com>
4619
4620         * configure: Rebuild.
4621         * configure.ac: Disallow the combination of -static-libstdc++ and
4622         source highlight.
4623         * source-cache.c (get_language_name): Handle rust.
4624         (source_cache::get_source_lines): Ignore highlighting exceptions.
4625
4626 2019-08-16  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4629         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4630         (struct tui_source_window_base) <make_visible, refresh_window,
4631         resize>: Remove methods.
4632         <execution_info>: Remove field.
4633         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4634         (tui_show_source_line, tui_source_window_base)
4635         (~tui_source_window_base): Update.
4636         (tui_source_window_base::resize)
4637         (tui_source_window_base::make_visible)
4638         (tui_source_window_base::refresh_window): Remove.
4639         (tui_source_window_base::update_exec_info): Update.
4640         * tui/tui-source.c (tui_source_window::set_contents): Update.
4641         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4642
4643 2019-08-16  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4646         deprecated_query_hook.
4647
4648 2019-08-16  Tom Tromey  <tom@tromey.com>
4649
4650         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4651         (tui_update_source_windows_with_line): Update.
4652         * tui/tui-source.h (struct tui_source_window)
4653         <show_symtab_source>: Declare.
4654         (tui_show_symtab_source): Don't declare.
4655         * tui/tui-source.c (tui_show_symtab_source): Rename from
4656         tui_show_symtab_source.
4657
4658 2019-08-16  Tom Tromey  <tom@tromey.com>
4659
4660         * tui/tui-winsource.h (struct tui_source_window_base)
4661         <set_contents>: Declare.
4662         * tui/tui-winsource.c
4663         (tui_source_window_base::update_source_window_as_is): Update.
4664         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4665         Declare.
4666         (tui_set_source_content): Don't declare.
4667         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4668         tui_set_source_content.
4669         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4670         Declare.
4671         (tui_set_disassem_content): Don't declare.
4672         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4673         tui_set_disassem_content.
4674
4675 2019-08-16  Tom Tromey  <tom@tromey.com>
4676
4677         * tui/tui-winsource.h (struct tui_source_window_base)
4678         <update_breakpoint_info>: Declare.
4679         (tui_update_breakpoint_info): Don't declare.
4680         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4681         (tui_update_all_breakpoint_info): Update.
4682         (tui_source_window_base::update_breakpoint_info): Rename from
4683         tui_update_breakpoint_info.
4684         (tui_source_window_base::update_exec_info): Update.
4685
4686 2019-08-16  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-winsource.h (struct tui_source_window_base)
4689         <update_source_window>: Declare.
4690         (tui_update_source_window): Don't declare.
4691         * tui/tui-winsource.c
4692         (tui_source_window_base::update_source_window): Rename from
4693         tui_update_source_window.
4694         (tui_source_window_base::rerender): Update.
4695         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4696         * tui/tui-disasm.c (tui_show_disassem)
4697         (tui_show_disassem_and_update_source)
4698         (tui_disasm_window::maybe_update): Update.
4699
4700 2019-08-16  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-winsource.h (struct tui_source_window_base)
4703         <update_source_window_as_is>: Declare.
4704         (tui_update_source_window_as_is): Don't declare.
4705         * tui/tui-winsource.c (tui_update_source_window): Update
4706         (tui_source_window_base::update_source_window_as_is): Rename from
4707         tui_update_source_window_as_is.
4708         (tui_source_window_base::refill): Update.
4709         * tui/tui-source.c (tui_show_symtab_source): Update.
4710         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4711         Update.
4712
4713 2019-08-16  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-winsource.h (tui_update_source_window)
4716         (tui_update_source_window_as_is): Remove "noerror" parameter.
4717         * tui/tui-winsource.c (tui_update_source_window)
4718         (tui_update_source_window_as_is): Remove "noerror" parameter.
4719         (tui_update_source_windows_with_addr)
4720         (tui_update_source_windows_with_line)
4721         (tui_source_window_base::rerender)
4722         (tui_source_window_base::refill): Update.
4723         * tui/tui-source.h (tui_set_source_content)
4724         (tui_show_symtab_source): Remove "noerror" parameter.
4725         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4726         parameter.
4727         (tui_show_symtab_source): Likewise.
4728         (tui_source_window::maybe_update): Update.
4729         * tui/tui-disasm.c (tui_show_disassem)
4730         (tui_show_disassem_and_update_source)
4731         (tui_disasm_window::do_scroll_vertical)
4732         (tui_disasm_window::maybe_update): Update.
4733
4734 2019-08-16  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui.c (tui_is_window_visible): Update.
4737         * tui/tui-wingeneral.c (tui_make_window)
4738         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4739         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4740         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4741         (tui_set_win_height_command, parse_scrolling_args): Update.
4742         * tui/tui-source.c (tui_source_window::style_changed): Update.
4743         * tui/tui-regs.c (tui_show_registers)
4744         (tui_data_window::first_data_item_displayed)
4745         (tui_data_window::delete_data_content_windows)
4746         (tui_check_register_values, tui_reg_command): Update.
4747         * tui/tui-disasm.c (tui_show_disassem): Update.
4748         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4749         method.
4750         <is_visible>: Remove field.
4751         * tui/tui-data.c (tui_next_win, tui_prev_win)
4752         (tui_delete_invisible_windows): Update.
4753
4754 2019-08-16  Tom Tromey  <tom@tromey.com>
4755
4756         * tui/tui-winsource.h (struct tui_source_window_base)
4757         <m_has_locator>: Remove.
4758         * tui/tui-layout.c (show_source_disasm_command, show_data)
4759         (show_source_or_disasm_and_command): Update.
4760
4761 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4762
4763         * NEWS (Other MI changes): New subsection.
4764         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4765         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4766         * arch-utils.c (default_get_pc_address_flags): New function.
4767         * arch-utils.h (default_get_pc_address_flags): New declaration.
4768         * gdbarch.sh: Add get_pc_address_flags.
4769         * gdbarch.c: Regenerate.
4770         * gdbarch.h: Likewise.
4771         * stack.c (print_pc): New function.
4772         (print_frame_info) (print_frame): Call print_pc.
4773
4774 2019-08-16  Tom de Vries  <tdevries@suse.de>
4775
4776         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4777         print_objfile_section_info.
4778
4779 2019-08-15  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4782         calling update_cmdwin_start_line.
4783         * tui/tui-winsource.h (struct tui_source_window_base)
4784         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4785         <rerender>: Declare.
4786         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4787         Call rerender.
4788         (tui_source_window_base::set_new_height): Remove.
4789         (tui_source_window_base::rerender): Rename from
4790         do_make_visible_with_new_height.
4791         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4792         resize method.
4793         (tui_win_info::make_invisible_and_set_new_height)
4794         (tui_win_info::make_visible_with_new_height): Remove.
4795         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4796         Declare.
4797         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4798         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4799         do_make_visible_with_new_height>: Don't declare.
4800         <rerender>: Declare.
4801         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4802         set_new_height.
4803         (tui_data_window::do_make_visible_with_new_height): Remove.
4804         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4805         call tui_show_locator_content.
4806         (tui_gen_win_info::resize): Call rerender.
4807         (show_source_or_disasm_and_command): Don't call
4808         tui_show_locator_content.
4809         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4810         method.
4811         (struct tui_win_info) <rerender>: Declare.
4812         <set_new_height, make_invisible_and_set_new_height,
4813         make_visible_with_new_height>: Don't declare.
4814         * tui/tui-data.c (tui_win_list::rerender): New method.
4815         * tui/tui-command.h (struct tui_cmd_window)
4816         <do_make_visible_with_new_height>: Don't declare.
4817         * tui/tui-command.c
4818         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4819
4820 2019-08-15  Tom Tromey  <tromey@adacore.com>
4821
4822         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4823         * ada-lang.c (ada_enum_name): Likewise.
4824
4825 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4826
4827         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4828         leading underscore.
4829         (GdbOutputErrorFile): Likewise.
4830         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4831         accordingly.
4832         (execute_unwinders): Rename to have a leading underscore.
4833         (auto_load_packages): Likewise.
4834         (global scope): Adjust call to auto_load_packages accordingly.
4835         (GdbSetPythonDirectory): Likewise.
4836         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4837         instead of execute_unwinders.
4838
4839 2019-08-15  Tom Tromey  <tom@tromey.com>
4840
4841         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4842         (show_data): Don't change window visibility.
4843         (tui_gen_win_info::resize): Remove special case for command
4844         window.  Use wresize, when available.
4845         (show_source_or_disasm_and_command): Don't change window
4846         visibility.
4847         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4848         <make_visible>: New method.
4849         * tui/tui-command.c (tui_cmd_window::resize): New method.
4850
4851 2019-08-15  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4854         (struct tui_source_windows): New.
4855         * tui/tui-winsource.c (tui_display_main): Update.
4856         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4857         (new_height_ok, parse_scrolling_args): Update.
4858         * tui/tui-layout.c (show_layout, show_data): Update.
4859         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4860         (tui_add_to_source_windows): Don't declare.
4861         * tui/tui-data.c (source_windows, tui_source_windows)
4862         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4863
4864 2019-08-15  Tom Tromey  <tom@tromey.com>
4865
4866         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4867         Rename from reset.
4868         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4869         * tui/tui-layout.c (show_source_disasm_command, show_data):
4870         Update.
4871         (tui_gen_win_info::resize): Rename.
4872         (show_source_or_disasm_and_command): Update.
4873         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4874         reset.
4875
4876 2019-08-15  Tom Tromey  <tom@tromey.com>
4877
4878         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4879         * tui/tui-interp.c (tui_interp::init): Don't call
4880         tui_initialize_static_data.
4881         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4882
4883 2019-08-15  Tom Tromey  <tom@tromey.com>
4884
4885         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4886         examine tui_win_list.
4887
4888 2019-08-15  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4891         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4892         tui_clear_source_content.
4893         (tui_clear_source_content): Remove.
4894         (tui_source_window_base::do_erase_source_content): Hoist call to
4895         content.clear().
4896         * tui/tui-stack.c (tui_show_frame_info): Don't call
4897         tui_clear_source_content.
4898
4899 2019-08-15  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-winsource.h (struct tui_source_window_base)
4902         <do_erase_source_content>: New method.
4903         <erase_source_content>: New method.
4904         (tui_erase_source_content): Don't declare.
4905         * tui/tui-winsource.c (tui_clear_source_content): Update.
4906         (tui_source_window_base::do_erase_source_content): Rename from
4907         tui_erase_source_content.
4908         (tui_source_window_base::show_source_content): Update.
4909         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4910         * tui/tui-source.h (struct tui_source_window)
4911         <erase_source_content>: New method.
4912         * tui/tui-disasm.h (struct tui_disasm_window)
4913         <erase_source_content>: New method.
4914
4915 2019-08-15  Tom Tromey  <tom@tromey.com>
4916
4917         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4918         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4919         constructor.
4920         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4921         * tui/tui-source.c (tui_set_source_content): Update.
4922         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4923
4924 2019-08-15  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4927         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4928         tui-source.c.
4929         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4930         Declare.
4931         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4932         method.
4933         (tui_source_window::maybe_update): Update.
4934
4935 2019-08-15  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4938         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4939         tui-disasm.c.
4940         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4941         Declare.
4942         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4943         method.
4944         (tui_disasm_window::maybe_update): Update.
4945
4946 2019-08-15  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-winsource.h (struct tui_source_window_base)
4949         <maybe_update>: Declare.
4950         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4951         method.
4952         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4953         Declare.
4954         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4955         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4956         Declare.
4957         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4958
4959 2019-08-15  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4962
4963 2019-08-15  Tom Tromey  <tom@tromey.com>
4964
4965         * tui/tui-wingeneral.c: Include tui-stack.h.
4966         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4967         (struct tui_locator_window): Move from tui-data.h.
4968         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4969         (tui_initialize_static_data): Move from tui-data.c.
4970         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4971         (struct tui_locator_window): Move to tui-stack.c.
4972         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4973         (tui_initialize_static_data): Move to tui-stack.c.
4974
4975 2019-08-15  Tom Tromey  <tom@tromey.com>
4976
4977         * tui/tui-layout.c (show_source_disasm_command)
4978         (show_source_or_disasm_and_command): Use make_visible method, not
4979         tui_make_window.
4980         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4981         Remove.
4982
4983 2019-08-15  Tom Tromey  <tom@tromey.com>
4984
4985         * tui/tui-wingeneral.h (tui_make_window): Update.
4986         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4987         parameter.
4988         (tui_gen_win_info::make_visible): Update.
4989         * tui/tui-regs.c (tui_data_window::display_registers_from):
4990         Update.
4991         * tui/tui-layout.c (show_source_disasm_command)
4992         (show_source_or_disasm_and_command): Update.
4993         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4994         (enum tui_box): Remove.
4995         (struct tui_win_info) <can_box>: New method.
4996         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4997         method.
4998
4999 2019-08-15  Tom de Vries  <tdevries@suse.de>
5000
5001         * linux-nat-trad.c: Include gdbarch.h.
5002
5003 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5004
5005         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5006         register sizes.
5007
5008 2019-08-14  Tom Tromey  <tromey@adacore.com>
5009
5010         * darwin-nat.c: Include gdbarch.h.
5011         * darwin-nat-info.c: Include gdbarch.h.
5012
5013 2019-08-13  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5016         Remove.
5017         * tui/tui-data.c (tui_initialize_static_data): Update.
5018
5019 2019-08-13  Tom Tromey  <tom@tromey.com>
5020
5021         * tui/tui-winsource.h (struct tui_exec_info_window)
5022         <~tui_exec_info_window, maybe_allocate_content, get_content,
5023         m_content>: Remove.
5024         (struct tui_source_window_base) <set_exec_info_content,
5025         show_exec_info_content>: Don't declare.
5026         * tui/tui-winsource.c
5027         (tui_exec_info_window::maybe_allocate_content): Remove.
5028         (tui_source_window_base::update_exec_info): Rename from
5029         set_exec_info_content.
5030         (tui_source_window_base::show_exec_info_content)
5031         (tui_source_window_base::update_exec_info): Remove.
5032
5033 2019-08-13  Tom Tromey  <tom@tromey.com>
5034
5035         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5036         declare.
5037         * tui/tui-winsource.c (tui_update_source_window_as_is)
5038         (tui_update_source_windows_with_addr, tui_erase_source_content):
5039         Update.
5040         (tui_clear_exec_info_content): Remove.
5041
5042 2019-08-13  Tom Tromey  <tom@tromey.com>
5043
5044         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5045         declare.
5046         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5047         call tui_erase_exec_info_content.
5048         (tui_clear_exec_info_content): Rename from
5049         tui_erase_exec_info_content.
5050         (tui_clear_exec_info_content): Delete.
5051
5052 2019-08-13  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-winsource.h (struct tui_source_window_base)
5055         <show_exec_info_content>: Declare.
5056         (tui_show_exec_info_content): Don't declare.
5057         * tui/tui-winsource.c
5058         (tui_source_window_base::show_exec_info_content): Rename from
5059         tui_show_exec_info_content.
5060         (tui_source_window_base::update_exec_info): Update.
5061
5062 2019-08-13  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5065         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5066         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5067         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5068         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5069         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5070         ... here.
5071
5072 2019-08-13  Tom Tromey  <tom@tromey.com>
5073
5074         * tui/tui-winsource.h (struct tui_source_window_base)
5075         <update_exec_info>: Declare.
5076         (tui_update_exec_info): Don't declare.
5077         * tui/tui-winsource.c (tui_update_source_window_as_is)
5078         (tui_source_window_base::refresh_all)
5079         (tui_update_all_breakpoint_info): Update.
5080         (tui_source_window_base::update_exec_info): Rename from
5081         tui_update_exec_info.
5082         * tui/tui-stack.c (tui_show_frame_info): Update.
5083
5084 2019-08-13  Tom Tromey  <tom@tromey.com>
5085
5086         * tui/tui-winsource.h (struct tui_source_window_base)
5087         <set_exec_info_content>: Declare.
5088         (tui_set_exec_info_content): Don't declare.
5089         * tui/tui-winsource.c
5090         (tui_source_window_base::set_exec_info_content): Rename from
5091         tui_set_exec_info_content.
5092         (tui_update_exec_info): Update.
5093
5094 2019-08-13  Tom Tromey  <tom@tromey.com>
5095
5096         * tui/tui-winsource.h (struct tui_source_window_base)
5097         <show_source_content>: Declare.
5098         (tui_show_source_content): Don't declare.
5099         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5100         (tui_source_window_base::show_source_content): Rename from
5101         tui_show_source_content.
5102         (tui_source_window_base::refresh_all): Update.
5103         * tui/tui-layout.c (show_source_disasm_command)
5104         (show_source_or_disasm_and_command): Update.
5105
5106 2019-08-13  Tom Tromey  <tom@tromey.com>
5107
5108         * tui/tui-winsource.c (tui_erase_source_content)
5109         (tui_show_source_content, tui_source_window_base::refresh_all):
5110         Update.
5111         * tui/tui-wingeneral.h
5112         (tui_check_and_display_highlight_if_needed): Don't declare.
5113         * tui/tui-wingeneral.c
5114         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5115         check_and_display_highlight_if_needed.
5116         * tui/tui-win.c (tui_rehighlight_all)
5117         (tui_win_info::make_visible_with_new_height): Update.
5118         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5119         (tui_data_window::erase_data_content)
5120         (tui_data_window::display_all_data): Update.
5121         * tui/tui-data.h (struct tui_win_info)
5122         <check_and_display_highlight_if_needed>: Declare.
5123
5124 2019-08-13  Tom Tromey  <tom@tromey.com>
5125
5126         * tui/tui-win.c (tui_resize_all): Call
5127         tui_delete_invisible_windows.
5128         * tui/tui-layout.c (show_layout): Call
5129         tui_delete_invisible_windows.
5130         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5131         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5132
5133 2019-08-13  Tom Tromey  <tom@tromey.com>
5134
5135         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5136         tui_add_win_to_layout.
5137
5138 2019-08-13  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5141         * tui/tui-layout.c (tui_default_win_height): Now static.
5142
5143 2019-08-13  Tom Tromey  <tom@tromey.com>
5144
5145         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5146         single switch.
5147         (show_source_disasm_command, show_source_or_disasm_and_command):
5148         Don't check current layout.
5149
5150 2019-08-13  Tom Tromey  <tom@tromey.com>
5151
5152         * tui/tui-wingeneral.c (make_all_visible): Remove.
5153         (tui_make_all_invisible): Simplify.
5154         * tui/tui-layout.c (tui_make_all_invisible): Move from
5155         tui-wingeneral.c; simplify.
5156         (show_layout): Hoist call to tui_make_all_invisible.
5157         (show_data): Don't call tui_make_all_invisible.
5158
5159 2019-08-13  Tom Tromey  <tom@tromey.com>
5160
5161         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5162         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5163
5164 2019-08-13  Tom Tromey  <tom@tromey.com>
5165
5166         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5167         tui-data.c.
5168         (show_source_disasm_command, show_data)
5169         (show_source_or_disasm_and_command): Don't use
5170         tui_set_current_layout_to.
5171         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5172         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5173         tui-layout.c.
5174         (tui_set_current_layout_to): Remove.
5175
5176 2019-08-13  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-layout.c (tui_set_layout): Update.
5179         * tui/tui-data.h (struct tui_layout_def): Remove.
5180         (tui_layout_def): Don't declare.
5181         * tui/tui-data.c (layout_def): Remove.
5182         (tui_layout_def): Remove.
5183
5184 2019-08-13  Tom Tromey  <tom@tromey.com>
5185
5186         * tui/tui-winsource.h (struct tui_source_window_base)
5187         <clear_detail>: No longer "override".
5188         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5189         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5190         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5191         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5192         Remove.
5193         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5194
5195 2019-08-13  Tom Tromey  <tromey@adacore.com>
5196
5197         * tracepoint.c: Don't include readline.h or history.h.
5198
5199 2019-08-12  Tom Tromey  <tom@tromey.com>
5200
5201         * configure: Rebuild.
5202         * configure.ac: Check for readline 7.
5203         * NEWS: Mention readline 7 requirement.
5204         * README: Update.
5205
5206 2019-08-12  Tom Tromey  <tom@tromey.com>
5207
5208         * mingw-hdep.c (gdb_select): Remove readline hack.
5209
5210 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5211
5212         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5213         when the function fails.
5214
5215 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5216
5217         * s390-tdep.c (s390_type_align): New function.
5218         (s390_gdbarch_init): Set it as type_align gdbarch method.
5219
5220 2019-08-09  Tom de Vries  <tdevries@suse.de>
5221
5222         PR gdb/24591
5223         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5224         pc_low with relocation offset.
5225
5226 2019-08-07  Tom Tromey  <tromey@adacore.com>
5227
5228         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5229         (print_frame_args): Update.
5230         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5231         Update.
5232         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5233         * frame.h (struct frame_arg): Add initializers.
5234         <error>: Now a unique_xmalloc_ptr.
5235
5236 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5237
5238         * NEWS: Expand the Pointer Authentication entry.
5239         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5240         (aarch64_frame_unmask_lr): ... to this.
5241         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5242         Call aarch64_frame_unmask_lr.
5243         * frame.c (struct frame_info): Add "masked" variable.
5244         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5245         (fprint_frame): Check for masked pc.
5246         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5247         declarations.
5248         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5249         * stack.c (print_frame): Check for masked pc.
5250
5251 2019-08-06  Tom Tromey  <tom@tromey.com>
5252
5253         * stabsread.c (patch_block_stabs, read_one_struct_field)
5254         (read_enum_type): Use obstack_strndup.
5255         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5256         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5257         * dwarf2read.c (guess_full_die_structure_name)
5258         (anonymous_struct_prefix): Use obstack_strndup.
5259         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5260         * c-exp.y (yylex): Use obstack_strndup.
5261         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5262         (write_var_or_type): Use obstack_strndup.
5263
5264 2019-08-06  Tom Tromey  <tom@tromey.com>
5265
5266         * symfile.c (reread_symbols): Use obstack_strdup.
5267         * stabsread.c (read_type): Use obstack_strdup.
5268         * gdb_obstack.h (obstack_strdup): New overload.
5269         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5270         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5271         (dwarf2_canonicalize_name): Use obstack_strdup.
5272         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5273         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5274         Use obstack_strdup.
5275
5276 2019-08-06  Tom Tromey  <tom@tromey.com>
5277
5278         * gdb_obstack.h (obstack_strdup): Define.
5279         * gdb_obstack.c (obstack_strdup): Don't define.
5280
5281 2019-08-06  Tom Tromey  <tom@tromey.com>
5282
5283         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5284         obstack_strdup.
5285         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5286         obstack_strdup.
5287         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5288         * stabsread.c (common_block_start): Use obstack_strdup.
5289         * objfiles.c (set_objfile_main_name, objfile): Use
5290         obstack_strdup.
5291         * namespace.c (add_using_directive): Use obstack_strdup.
5292         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5293         * jit.c (finalize_symtab): Use obstack_strdup.
5294         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5295         (guess_partial_die_structure_name, partial_die_info::fixup)
5296         (dwarf2_name): Use obstack_strdup.
5297         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5298         obstack_strdup.
5299         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5300         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5301         obstack_strdup.
5302         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5303
5304 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5305
5306         * unittests/help-doc-selftests.c: New file.
5307         * Makefile.in: Add the new file.
5308
5309 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5310
5311         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5312         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5313         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5314         the trailing '.' is not output, and the first character is uppercased.
5315         (print_help_for_command): Update call to print_doc_line.
5316         (print_doc_of_command): Likewise.
5317         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5318         * cli/cli-option.c (append_indented_doc): Do not append newline.
5319         (build_help_option): Append newline after first appended_indented_doc
5320         only if a second call is done.
5321         (build_help): Append 2 new lines before each option, except the first
5322         one.
5323         * compile/compile.c (_initialize_compile): Add new lines after
5324         %OPTIONS%, when not at the end of the help.
5325         Change help doc or code
5326         producing the help doc to respect the invariants.
5327         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5328         Also removed the new line after 'Options:', as all other commands
5329         do not put an empty line between 'Options:' and the first option.
5330         * printcmd.c (_initialize_printcmd): Likewise.
5331         * stack.c (_initialize_stack): Likewise.
5332         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5333         incorrectly telling COMMAND is optional.
5334         * ada-lang.c (_initialize_ada_language): Change help doc or code
5335         producing the help doc to respect the invariants.
5336         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5337         * breakpoint.c (_initialize_breakpoint): Likewise.
5338         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5339         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5340         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5341         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5342         _initialize_cli_style): Likewise.
5343         * corelow.c (core_target_info): Likewise.
5344         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5345         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5346         * filesystem.c (_initialize_filesystem): Likewise.
5347         * frame.c (_initialize_frame): Likewise.
5348         * gnu-nat.c (add_task_commands): Likewise.
5349         * infcall.c (_initialize_infcall): Likewise.
5350         * infcmd.c (_initialize_infcmd): Likewise.
5351         * interps.c (_initialize_interpreter): Likewise.
5352         * language.c (_initialize_language): Likewise.
5353         * linux-fork.c (_initialize_linux_fork): Likewise.
5354         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5355         * maint.c (_initialize_maint_cmds): Likewise.
5356         * memattr.c (_initialize_mem): Likewise.
5357         * printcmd.c (_initialize_printcmd): Likewise.
5358         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5359         _RegEx): Likewise.
5360         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5361         * record-btrace.c (_initialize_record_btrace): Likewise.
5362         * record-full.c (_initialize_record_full): Likewise.
5363         * record.c (_initialize_record): Likewise.
5364         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5365         * regcache.c (_initialize_regcache): Likewise.
5366         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5367         _initialize_remote): Likewise.
5368         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5369         * serial.c (_initialize_serial): Likewise.
5370         * skip.c (_initialize_step_skip): Likewise.
5371         * source.c (_initialize_source): Likewise.
5372         * stack.c (_initialize_stack): Likewise.
5373         * symfile.c (_initialize_symfile): Likewise.
5374         * symtab.c (_initialize_symtab): Likewise.
5375         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5376         * top.c (init_main): Likewise.
5377         * tracefile-tfile.c (tfile_target_info): Likewise.
5378         * tracepoint.c (_initialize_tracepoint): Likewise.
5379         * tui/tui-win.c (_initialize_tui_win): Likewise.
5380         * utils.c (add_internal_problem_command): Likewise.
5381         * valprint.c (value_print_option_defs): Likewise.
5382
5383 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5384
5385         PR build/24886
5386         * configure.ac: Drop enable-libmcheck support.
5387         * configure, config.in: Rebuild.
5388         * libmcheck.m4: Remove.
5389         * acinclude.m4: Don't include it.
5390         * Makefile.in: Don't distribute it.
5391         * top.c (print_gdb_configuration): Don't mention it.
5392
5393 2019-08-06  Tom Tromey  <tom@tromey.com>
5394
5395         * utils.c (set_output_style): Sometimes pass stream to
5396         emit_style_escape.
5397         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5398         * record-btrace.c (btrace_insn_history): Update.
5399         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5400         method.
5401         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5402         Update initializers.
5403         <m_uiout>: New field.
5404         <m_di>: Move lower.
5405         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5406         Remove "uiout" parameter.
5407         (dump_insns): Update.
5408         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5409         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5410
5411 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5412
5413         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5414         (error_in_psymtab_expansion): Likewise.
5415         (lookup_symbol_via_quick_fns): Likewise.
5416         (basic_lookup_transparent_type_quick): Likewise.
5417         (basic_lookup_transparent_type_1): Likewise.
5418
5419 2019-08-06  Tom Tromey  <tromey@adacore.com>
5420
5421         * source.c (last_source_error): Now bool.
5422         (print_source_lines_base): Make "noprint" bool.  Only open
5423         source file when last_source_visited changes.
5424
5425 2019-08-06  Tom Tromey  <tromey@adacore.com>
5426
5427         * annotate.c (annotate_source_line): Use g_source_cache.
5428         * source-cache.c (source_cache::get_plain_source_lines): Change
5429         parameters.  Populate m_offset_cache.
5430         (source_cache::ensure): New method.
5431         (source_cache::get_line_charpos): New method.
5432         (extract_lines): Move lower.  Change parameters.
5433         (source_cache::get_source_lines): Move lower.
5434         * source-cache.h (class source_cache): Update comment.
5435         <get_line_charpos>: New method.
5436         <get_source_lines>: Update comment.
5437         <clear>: Clear m_offset_cache.
5438         <get_plain_source_lines>: Change parameters.
5439         <ensure>: New method
5440         <m_offset_cache>: New member.
5441         * source.c (forget_cached_source_info_for_objfile): Update.
5442         (info_source_command): Use g_source_cache.
5443         (find_source_lines, open_source_file_with_line_charpos): Remove.
5444         (print_source_lines_base, search_command_helper): Use g_source_cache.
5445         * source.h (open_source_file_with_line_charpos): Don't declare.
5446         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5447         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5448         Use g_source_cache.
5449
5450 2019-08-06  Tom Tromey  <tromey@adacore.com>
5451
5452         * source-cache.c (source_cache::get_plain_source_lines):
5453         Remove "first_line" and "last_line" parameters.
5454         (source_cache::get_source_lines): Cache plain text.
5455         * source-cache.h (class source_cache)
5456         <get_plain_source_lines>: Update.
5457
5458 2019-08-06  Tom Tromey  <tromey@adacore.com>
5459
5460         * source-cache.c (extract_lines): No longer a method.
5461         Changed type of parameter.  Include final newline.
5462         (selftests::extract_lines_test): New function.
5463         (_initialize_source_cache): Likewise.
5464         * source-cache.h (class source_cache)
5465         <extract_lines>: Don't declare.
5466
5467 2019-08-06  Tom Tromey  <tromey@adacore.com>
5468
5469         * breakpoint.c (init_breakpoint_sal): Update.
5470         (breakpoint): Update.
5471         * breakpoint.h (struct breakpoint) <filter>: Now a
5472         unique_xmalloc_ptr.
5473
5474 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5475
5476         * NEWS: Mention dictionary access on blocks.
5477         * python/py-block.c (blpy_getitem): New function.
5478         (block_object_as_mapping): New struct.
5479         (block_object_type): Use new struct for tp_as_mapping field.
5480
5481 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5482
5483         * objfiles.h (objfile): Add a comment describing partial symbols.
5484
5485 2019-08-05  Tom Tromey  <tromey@adacore.com>
5486
5487         * compile/compile.c (_initialize_compile): Use _(), not N_().
5488         * thread.c (_initialize_thread): Use _(), not N_().
5489         * stack.c (_initialize_stack): Use _(), not N_().
5490         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5491
5492 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5493
5494         * dwarf2read.c (struct dw2_symtab_iterator):
5495         <want_specific_block>: Remove.
5496         <block_index>: Change type to gdb::optional.
5497         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5498         change type of BLOCK_INDEX parameter to gdb::optional.
5499         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5500         (dw2_lookup_symbol): Don't pass argument for
5501         WANT_SPECIFIC_BLOCK.
5502         (dw2_expand_symtabs_for_function): Don't pass argument for
5503         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5504         (class dw2_debug_names_iterator)
5505         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5506         parameter, change BLOCK_INDEX type to gdb::optional.
5507         <m_want_specific_block>: Remove.
5508         <m_block_index>: Change type to gdb::optional.
5509         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5510         gdb::optional.  Re-write in function of gdb::optional.
5511         (dw2_debug_names_lookup_symbol): Don't pass argument for
5512         WANT_SPECIFIC_BLOCK.
5513         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5514         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5515         BLOCK_INDEX.
5516
5517 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5518
5519         * NEWS: Mention changes to "info sources" command.
5520
5521 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5522
5523         * symtab.c (filename_partial_match_opts): New struct type.
5524         (struct output_source_filename_data): New members
5525         regexp, c_regexp, partial_match.
5526         (output_source_filename): Use new members to decide to print file.
5527         (info_sources_option_defs): New variable.
5528         (make_info_sources_options_def_group, print_info_sources_header,
5529         info_sources_command_completer):
5530         New functions.
5531         (info_sources_command): Read new optional arguments.
5532         (_initialize_symtab): Update info sources help.
5533
5534 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5535
5536         * ada-lang.c (exception_support_info_v0): Renamed from...
5537         (default_exception_support_info): ... this.  Create new
5538         definition for v1.
5539         (ada_has_this_exception_support): Look up catch_handlers_sym.
5540         (ada_exception_support_info_sniffer): Try v0 after default.
5541
5542 2019-08-01  Tom Tromey  <tromey@adacore.com>
5543
5544         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5545         gdbarch.h.
5546
5547 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5548
5549         * s12z-tdep.c: Fix include path for s12z-opc.h.
5550
5551 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5552
5553         * NEWS: Require GNU make 3.82.
5554
5555 2019-07-16  Tom Tromey  <tom@tromey.com>
5556
5557         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5558         declare.
5559
5560 2019-07-30  Tom Tromey  <tromey@adacore.com>
5561
5562         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5563
5564 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5565
5566         * printcmd.c (print_address_symbolic): Print negative offsets.
5567         (build_address_symbolic): Force signed arithmetic when computing
5568         offset.
5569
5570 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5571
5572         PR/24474: Add a function to lookup static variables.
5573         * NEWS: Mention this new function.
5574         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5575         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5576         * python/python.c (python_GdbMethods): Add new function.
5577
5578 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5579
5580         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5581         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5582         (objfpy_lookup_static_symbol): New function.
5583         (objfile_object_methods): Add new functions.
5584
5585 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5586
5587         * NEWS: Mention 'set|show print frame-info'.  Mention new
5588         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5589         backtrace argument.  Mention that python frame filtering code
5590         is now consistent with what 'backtrace' command prints.
5591
5592 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5593
5594         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5595         comments.
5596         (print_frame_info_auto, print_frame_info_source_line,
5597         print_frame_info_location, print_frame_info_source_and_location,
5598         print_frame_info_location_and_address, print_frame_info_short_location):
5599         New declarations.
5600         (struct frame_print_options): New member print_frame_info.
5601         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5602         * stack.h (get_user_print_what_frame_info): New declaration.
5603         (frame_show_address): New declaration.
5604         * stack.c (print_frame_arguments_choices): New value 'presence'.
5605         (print_frame_info_auto, print_frame_info_source_line,
5606         print_frame_info_location, print_frame_info_source_and_location,
5607         print_frame_info_location_and_address, print_frame_info_short_location,
5608         print_frame_info_choices, print_frame_info_print_what): New definitions.
5609         (print_frame_args): Only print dots for args if print frame-arguments
5610         is 'presence'.
5611         (frame_print_option_defs): New element for "frame-info".
5612         (get_user_print_what_frame_info): New function.
5613         (frame_show_address): Make non static.  Move comment to stack.h.
5614         (print_frame_info_to_print_what): New function.
5615         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5616         to decide what to print.
5617         (backtrace_command_1): Handle the new print_frame_arguments_presence
5618         value.
5619         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5620         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5621         (py_print_frame): In non-mi mode, use LOCATION as default for
5622         print_what, similarly to frame information printed directly by
5623         backtrace command. Handle frame-info user option in non MI mode.
5624
5625 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5626
5627         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5628         Add case for debugging 32-bit target on 64-bit host.  Revise
5629         comment.
5630
5631 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5632
5633         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5634         instead of find_function_entry_range_from_pc.
5635
5636 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5637
5638         * stack.c (find_frame_funname): Remove code which preferred
5639         minsym over symtab sym in "certain pathological cases".
5640
5641         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5642         parameter.  Change type of "do_demangle" to bool.
5643         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5644         Pass suitable "prefer_sym_over_minsym" flag to
5645         build_address_symbolic().  Don't output "+" for negative offsets.
5646         * printcmd.c (print_address_symbolic): Update invocation of
5647         build_address_symbolic to include a "prefer_sym_over_minsym"
5648         flag.
5649         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5650         Restrict cases in which use of minimal symbol is preferred to that
5651         of a found symbol.  Update comments.
5652
5653         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5654         for entry pc when entry pc is out of range for that FDE.
5655
5656 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5657
5658         PR gdb/24839:
5659         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5660         type.
5661
5662 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5663
5664         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5665         this function's Python signature.
5666
5667
5668 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5669
5670         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5671         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5672         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5673         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5674         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5675
5676
5677 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5678
5679         * h8300-tdep.c (h8300_register_name_common): New.
5680         h8300_register_name): Use h8300_register_name_common.
5681         (h8300s_register_name): Likewise.
5682         (h8300sx_register_name): Likewise.
5683         (h8300h_register_nam): New.
5684         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5685
5686
5687 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5688
5689         * arm-tdep.c (arm_skip_cmse_entry): New function.
5690         (arm_is_sgstubs_section): New function.
5691         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5692
5693 2019-07-22  Tom Tromey  <tom@tromey.com>
5694
5695         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5696         Don't self-assign.
5697
5698 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5701         type_print.
5702
5703 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5704
5705         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5706         so that GDB doesn't match any msymbols when searching in the
5707         TYPES_DOMAIN.
5708         (print_symbol_info): Print using typedef_print or type_print based
5709         on the type of the symbol.  Add updated FIXME comment moved from...
5710         (_initialize_symtab): ... move and update FIXME comment to above.
5711
5712 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5713
5714         * NEWS: Mention adding -q option to "info types".
5715         * symtab.c (struct info_types_options): New struct.
5716         (info_types_options_defs): New variable.
5717         (make_info_types_options_def_group): New function.
5718         (info_types_command): Use gdb::option framework to parse options.
5719         (info_types_command_completer): New function.
5720         (_initialize_symtab): Extend the help text on "info types" and
5721         register command completer.
5722
5723 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5724
5725         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5726         (lookup_symbol_in_objfile): Change int to block_enum and add a
5727         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5728
5729 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5730
5731         * MAINTAINERS (Write After Approval): Add self.
5732
5733 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5734
5735         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5736         instruction to the dummy code region.
5737
5738 2019-07-19  Tom Tromey  <tromey@adacore.com>
5739
5740         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5741         (ARGSUSED, PARAMS, __func__): Remove rules.
5742
5743 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5744
5745         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5746         * features/arm/arm-with-iwmmxt.c: Remove.
5747         * features/arm/arm-with-iwmmxt.xml: Remove.
5748         * features/arm/arm-with-m-fpa-layout.c: Remove.
5749         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5750         * features/arm/arm-with-m-vfp-d16.c: Remove.
5751         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5752         * features/arm/arm-with-m.c: Remove.
5753         * features/arm/arm-with-m.xml: Remove.
5754         * features/arm/arm-with-neon.c: Remove.
5755         * features/arm/arm-with-neon.xml: Remove.
5756         * features/arm/arm-with-vfpv2.c: Remove.
5757         * features/arm/arm-with-vfpv2.xml: Remove.
5758         * features/arm/arm-with-vfpv3.c: Remove.
5759         * features/arm/arm-with-vfpv3.xml: Remove.
5760
5761 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5762
5763         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5764
5765 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5766
5767         * arch/aarch32.c (aarch32_create_target_description): Create
5768         target descriptions using features.
5769         * arch/arm.c (arm_create_target_description)
5770         (arm_create_mprofile_target_description): Likewise.
5771         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5772
5773 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5774
5775         * Makefile.in: Add new files.
5776         * aarch32-tdep.c: New file.
5777         * aarch32-tdep.h: New file.
5778         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5779         Call aarch32_read_description.
5780         * arch/aarch32.c: New file.
5781         * arch/aarch32.h: New file.
5782         * arch/arm.c (arm_create_target_description)
5783         (arm_create_mprofile_target_description): New function.
5784         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5785         (arm_create_target_description)
5786         (arm_create_mprofile_target_description): New declaration.
5787         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5788         read_description functions.
5789         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5790         Likewise.
5791         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5792         * arm-tdep.c (tdesc_arm_list): New variable.
5793         (arm_register_g_packet_guesses): Call create description functions.
5794         (arm_read_description) (arm_read_mprofile_description): New
5795         function.
5796         * arm-tdep.h (arm_read_description)
5797         (arm_read_mprofile_description): Add declaration.
5798         * configure.tgt: Add new files.
5799
5800 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5801
5802         * top.c (new_ui_command): Open specified terminal just once.
5803
5804 2019-07-18  Tom Tromey  <tromey@adacore.com>
5805
5806         * symtab.c (main_name): Constify return type.
5807         * symfile.c (set_initial_language): Update.
5808         * symtab.h (main_name): Constify return type.
5809
5810 2019-07-17  Tom Tromey  <tom@tromey.com>
5811
5812         * tui/tui-winsource.c (tui_update_source_window)
5813         (tui_update_source_window_as_is)
5814         (tui_update_source_windows_with_line): Remove return.
5815         * tui/tui-disasm.c (tui_show_disassem)
5816         (tui_show_disassem_and_update_source): Remove return.
5817         * tui/tui.c (tui_reset): Remove return.
5818         * tui/tui-wingeneral.c
5819         (tui_check_and_display_highlight_if_needed): Remove return.
5820
5821 2019-07-17  Tom Tromey  <tom@tromey.com>
5822
5823         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5824
5825 2019-07-17  Tom Tromey  <tom@tromey.com>
5826
5827         * tui/tui-winsource.h (struct tui_exec_info_window)
5828         (struct tui_source_window_base): Move from tui-data.h.
5829         * tui/tui-winsource.c: Move many method definitions from
5830         elsewhere.  Remove "structuring" comments.
5831         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5832         (tui_source_window_base::refresh_window): Move to
5833         tui-winsource.c.
5834         * tui/tui-win.c (tui_source_window_base::refresh_all)
5835         (tui_source_window_base::update_tab_width)
5836         (tui_source_window_base::set_new_height)
5837         (tui_source_window_base::do_make_visible_with_new_height): Move to
5838         tui-winsource.c.
5839         * tui/tui-source.h: Update.
5840         * tui/tui-source.c (tui_source_window_base::reset): Move to
5841         tui-winsource.c.
5842         * tui/tui-disasm.h: Update.
5843         * tui/tui-data.h (struct tui_exec_info_window): Move to
5844         tui-winsource.h.
5845         (struct tui_source_window_base): Likewise.
5846         * tui/tui-data.c (tui_source_window_base::clear_detail)
5847         (tui_source_window_base, ~tui_source_window_base): Move to
5848         tui-winsource.c.
5849
5850 2019-07-17  Tom Tromey  <tom@tromey.com>
5851
5852         * tui/tui-win.c (tui_resize_all)
5853         (tui_source_window_base::update_tab_width)
5854         (tui_adjust_win_heights): Update.
5855         (tui_win_info::make_invisible_and_set_new_height): Rename from
5856         make_invisible_and_set_new_height.
5857         * tui/tui-data.h (struct tui_win_info)
5858         <make_invisible_and_set_new_height>: New method.
5859
5860 2019-07-17  Tom Tromey  <tom@tromey.com>
5861
5862         * tui/tui.c: Update.
5863         * tui/tui-source.h (struct tui_source_window): Move from
5864         tui-data.h.
5865         * tui/tui-layout.c: Update.
5866         * tui/tui-disasm.c: Update.
5867         * tui/tui-data.h (struct tui_source_window): Move to
5868         tui-source.h.
5869
5870 2019-07-17  Tom Tromey  <tom@tromey.com>
5871
5872         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5873         tui-data.h.
5874         * tui/tui-data.h (struct tui_disasm_window): Move to
5875         tui-disasm.h.
5876
5877 2019-07-17  Tom Tromey  <tom@tromey.com>
5878
5879         * tui/tui-regs.h (struct tui_data_item_window): Move from
5880         tui-data.h.
5881         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5882         * tui/tui-data.h (struct tui_data_item_window): Move to
5883         tui-regs.h.
5884         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5885
5886 2019-07-17  Tom Tromey  <tom@tromey.com>
5887
5888         * tui/tui.c: Update.
5889         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5890         (tui_cmd_window::max_height): Move to tui-command.c.
5891         * tui/tui-layout.c: Update.
5892         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5893         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5894         tui-command.c.
5895         * tui/tui-command.h (struct tui_cmd_window): Move from
5896         tui-data.h.
5897         * tui/tui-command.c: Remove "structuring" comments.
5898         (tui_cmd_window::clear_detail)
5899         (tui_cmd_window::do_make_visible_with_new_height)
5900         (tui_cmd_window::max_height): Move from elsewhere.
5901
5902 2019-07-17  Tom Tromey  <tom@tromey.com>
5903
5904         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5905         Now static.
5906         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5907         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5908
5909 2019-07-17  Tom Tromey  <tom@tromey.com>
5910
5911         * tui/tui.c: Update.
5912         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5913         tui-regs.c.
5914         * tui/tui-windata.h: Remove file.
5915         * tui/tui-windata.c: Remove file.
5916         * tui/tui-win.c (tui_data_window::set_new_height)
5917         (tui_data_window::do_make_visible_with_new_height): Move to
5918         tui-regs.c.
5919         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5920         * tui/tui-regs.c: Remove "structuring" comments.
5921         (tui_data_window::first_data_item_displayed)
5922         (tui_data_window::delete_data_content_windows)
5923         (tui_data_window::erase_data_content)
5924         (tui_data_window::display_all_data)
5925         (tui_data_window::refresh_all)
5926         (tui_data_window::do_scroll_vertical)
5927         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5928         (tui_data_window::do_make_visible_with_new_height)
5929         (tui_data_window::refresh_window): Move from elsewhere.
5930         (_initialize_tui_regs): Move to end of file.
5931         * tui/tui-layout.c: Update.
5932         * tui/tui-hooks.c: Update.
5933         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5934         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5935         tui-regs.c.
5936         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5937
5938 2019-07-17  Tom Tromey  <tom@tromey.com>
5939
5940         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5941         seen.
5942
5943 2019-07-17  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-win.c (tui_source_window_base::set_new_height)
5946         (tui_source_window_base::do_make_visible_with_new_height): Use
5947         m_has_locator field directly.
5948         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5949         method.
5950         (struct tui_source_window_base) <has_locator>: Likewise.
5951
5952 2019-07-17  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5955         Don't declare.
5956         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5957         Remove.
5958         * tui/tui-win.c (tui_source_window_base::set_new_height)
5959         (tui_source_window_base::set_new_height)
5960         (make_invisible_and_set_new_height)
5961         (tui_source_window_base::do_make_visible_with_new_height)
5962         (tui_source_window_base::do_make_visible_with_new_height):
5963         Update.
5964         * tui/tui-layout.c (show_source_disasm_command, show_data)
5965         (show_source_or_disasm_and_command): Update.
5966         * tui/tui-layout.c (show_layout): Update.
5967
5968 2019-07-17  Tom Tromey  <tom@tromey.com>
5969
5970         * tui/tui-layout.c (make_data_window): Remove.
5971         (show_data): Unify creation and re-initialization cases.
5972
5973 2019-07-17  Tom Tromey  <tom@tromey.com>
5974
5975         * tui/tui-layout.c (make_source_window, make_disasm_window):
5976         Remove.
5977         (show_data): Unify creation and re-initialization cases.
5978
5979 2019-07-17  Tom Tromey  <tom@tromey.com>
5980
5981         * tui/tui-layout.c (make_command_window): Remove.
5982         (show_source_disasm_command, show_source_or_disasm_and_command):
5983         Unify creation and re-initialization cases.
5984
5985 2019-07-17  Tom Tromey  <tom@tromey.com>
5986
5987         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5988         creation and re-initialization cases.
5989
5990 2019-07-17  Tom Tromey  <tom@tromey.com>
5991
5992         * tui/tui-regs.c (tui_get_register): Return void.
5993
5994 2019-07-17  Tom Tromey  <tom@tromey.com>
5995
5996         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5997         Simplify.
5998
5999 2019-07-17  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6002         resetting.
6003
6004 2019-07-17  Tom Tromey  <tom@tromey.com>
6005
6006         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6007         * tui/tui-regs.c (tui_reg_layout): New function.
6008         (tui_show_registers, tui_reg_command): Use it.
6009         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6010         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6011         parameters.
6012         (tui_layout_command): Remove.
6013
6014 2019-07-17  Tom Tromey  <tom@tromey.com>
6015
6016         * tui/tui-layout.h (tui/tui-layout): Return void.
6017         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6018
6019 2019-07-17  Tom Tromey  <tom@tromey.com>
6020
6021         * tui/tui-layout.c (show_source_disasm_command, show_data):
6022         Update.
6023         (reset_locator): Remove.
6024         (show_source_or_disasm_and_command): Update.
6025
6026 2019-07-17  Tom Tromey  <tom@tromey.com>
6027
6028         * tui/tui-source.c (tui_source_window_base::reset): Remove
6029         win_type parameter.
6030         * tui/tui-layout.c (make_command_window, make_source_window)
6031         (make_disasm_window, make_data_window)
6032         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6033         (reset_locator, show_source_or_disasm_and_command): Update.
6034         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6035         win_type parameter.
6036         (struct tui_source_window_base) <reset>: Likewise.
6037
6038 2019-07-17  Tom Tromey  <tom@tromey.com>
6039
6040         * tui/tui-layout.c (show_source_disasm_command): Use
6041         reset_locator.
6042         (reset_locator): New function.
6043         (init_and_make_win): Remove.
6044         (show_source_or_disasm_and_command): Use reset_locator.
6045
6046 2019-07-17  Tom Tromey  <tom@tromey.com>
6047
6048         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6049         condition.
6050         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6051         Remove condition.
6052         * tui/tui-source.c (tui_source_window_base::reset): New method.
6053         * tui/tui-layout.c (make_command_window): Don't call
6054         init_and_make_win.
6055         (make_source_window, make_disasm_window): Don't call
6056         make_source_or_disasm_window.
6057         (make_data_window): Don't call init_and_make_win.  Change calling
6058         convention.
6059         (show_source_disasm_command, show_data): Simplify.
6060         (make_source_or_disasm_window): Remove.
6061         (show_source_or_disasm_and_command): Simplify.
6062         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6063         (struct tui_source_window_base) <reset>: Likewise.
6064         <execution_info>: Remove initializer.
6065         * tui/tui-data.c (tui_source_window_base): Initialize
6066         execution_info.
6067
6068 2019-07-17  Tom Tromey  <tom@tromey.com>
6069
6070         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6071         variable.
6072
6073 2019-07-17  Tom Tromey  <tom@tromey.com>
6074
6075         * tui/tui.c (tui_rl_other_window): Update.
6076         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6077         superclass method first.  Always iterate over regs_content.
6078         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6079         method.
6080         * tui/tui-win.c (tui_set_focus_command): Update.
6081
6082 2019-07-17  Tom Tromey  <tom@tromey.com>
6083
6084         * tui/tui-win.c (tui_set_focus_command): Rename from
6085         tui_set_focus.  Call tui_enable.
6086         (tui_set_focus_command): Remove.
6087
6088 2019-07-17  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6091         refresh_window.
6092         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6093         touchwin.
6094         (tui_data_window::refresh_window): Call refresh_window on data
6095         items.  Always call superclass refresh_window.
6096         (tui_win_info::refresh): Remove.
6097         (tui_source_window_base::refresh_window): Update.
6098         (tui_refresh_all): Update.
6099         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6100         refresh_window.
6101         (show_source_or_disasm_and_command): Likewise.
6102         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6103         (struct tui_source_window_base) <refresh>: Likewise.
6104
6105 2019-07-17  Tom Tromey  <tom@tromey.com>
6106
6107         * tui/tui-winsource.c (tui_clear_source_content)
6108         (tui_show_source_content): Update.
6109         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6110         whether content is empty.
6111         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6112         Remove.
6113
6114 2019-07-17  Tom Tromey  <tom@tromey.com>
6115
6116         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6117         window's contents.
6118         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6119         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6120
6121 2019-07-17  Tom Tromey  <tom@tromey.com>
6122
6123         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6124         (struct tui_data_item_window): Update.
6125
6126 2019-07-17  Tom Tromey  <tom@tromey.com>
6127
6128         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6129         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6130         defines.
6131
6132 2019-07-17  Tom Tromey  <tom@tromey.com>
6133
6134         * tui/tui-winsource.h (tui_erase_source_content)
6135         (tui_clear_source_content): Remove "display_prompt" parameter.
6136         * tui/tui-winsource.c (tui_update_source_window_as_is)
6137         (tui_update_source_windows_with_addr): Update.
6138         (tui_clear_source_content): Remove "display_prompt" parameter.
6139         (tui_erase_source_content): Likewise.  Simplify.
6140         (tui_show_source_content): Update.
6141         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6142         * tui/tui-stack.c (tui_show_frame_info): Update.
6143         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6144         Remove defines.
6145
6146 2019-07-17  Tom Tromey  <tom@tromey.com>
6147
6148         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6149         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6150         parameter.
6151         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6152         parameter.
6153
6154 2019-07-17  Tom Tromey  <tom@tromey.com>
6155
6156         * tui/tui-winsource.c (tui_clear_source_content)
6157         (tui_show_source_content, tui_show_exec_info_content)
6158         (tui_clear_exec_info_content): Update.
6159         * tui/tui-stack.c (tui_show_locator_content): Update.
6160         (tui_show_frame_info): Update.
6161         * tui/tui-source.h (tui_source_window): Don't declare.
6162         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6163         from tui_source_is_displayed.
6164         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6165         Remove field.
6166         (struct tui_source_window_base) <content_in_use>: New field.  Now
6167         bool.
6168         (struct tui_source_window) <showing_source_p>: New method.
6169         (TUI_SRC_WIN): Change cast.
6170         * tui/tui-data.c (tui_initialize_static_data): Update.
6171
6172 2019-07-17  Tom Tromey  <tom@tromey.com>
6173
6174         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6175         location_matches_p.
6176         * tui/tui-source.c (tui_source_window::location_matches_p): New
6177         method.
6178         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6179         method.
6180         * tui/tui-data.h (struct tui_source_window_base)
6181         <location_matches_p>: New method.
6182         (struct tui_source_window, struct tui_disasm_window)
6183         <location_matches_p>: Likewise.
6184
6185 2019-07-17  Tom Tromey  <tom@tromey.com>
6186
6187         * tui/tui-win.c (tui_set_win_height_command): Rename from
6188         tui_set_win_height.
6189         (tui_set_win_height_command): Remove.
6190
6191 2019-07-17  Tom Tromey  <tom@tromey.com>
6192
6193         * tui/tui-source.c (tui_source_window): New constructor.  Add
6194         observer.
6195         (~tui_source_window): New destructor.
6196         (tui_source_window::style_changed): New method.
6197         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6198         (tui_attach_detach_observers): Update.
6199         * tui/tui-data.h (struct tui_source_window): Make constructor not
6200         inline.  Add destructor.
6201         (struct tui_source_window) <style_changed>: New method.
6202         <m_observable>: New member.
6203
6204 2019-07-17  Tom Tromey  <tom@tromey.com>
6205
6206         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6207         * tui/tui-win.c (tui_resize_all): Fix typo.
6208
6209 2019-07-17  Tom Tromey  <tom@tromey.com>
6210
6211         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6212         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6213         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6214         * tui/tui-win.c (window_name_completer): Use foreach.
6215         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6216         (update_tab_width): Likewise.
6217         * tui/tui-layout.c (show_layout): Update.
6218         * tui/tui-data.h (class tui_window_iterator): New.
6219         (struct all_tui_windows): New.
6220         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6221
6222 2019-07-17  Tom Tromey  <tom@tromey.com>
6223
6224         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6225         parameter.  Don't reference globals.
6226         (tui_reg_command): Update.
6227
6228 2019-07-17  Tom Tromey  <tom@tromey.com>
6229
6230         * tui/tui-regs.c (tui_show_registers): Simplify.
6231
6232 2019-07-17  Tom Tromey  <tom@tromey.com>
6233
6234         * tui/tui-regs.c (tui_show_registers): Update.
6235         (tui_show_register_group): Add win_info parameter.
6236
6237 2019-07-17  Tom Tromey  <tom@tromey.com>
6238
6239         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6240         Rename from tui_display_reg_element_at_line.
6241         (tui_data_window::display_registers_from_line): Update.
6242         * tui/tui-data.h (struct tui_data_window)
6243         <display_reg_element_at_line>: New method.
6244
6245 2019-07-17  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-regs.h (tui_display_registers_from)
6248         (tui_display_registers_from_line): Don't declare.
6249         * tui/tui-windata.c (tui_data_window::display_all_data)
6250         (tui_data_window::refresh_all)
6251         (tui_data_window::do_scroll_vertical): Update.
6252         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6253         from tui_display_registers_from.
6254         (tui_display_reg_element_at_line): Update.
6255         (tui_data_window::display_registers_from_line): Rename from
6256         tui_display_registers_from_line.
6257         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6258         display_registers_from_line>: New methods.
6259
6260 2019-07-17  Tom Tromey  <tom@tromey.com>
6261
6262         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6263         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6264         from tui_erase_data_content.
6265         (tui_data_window::display_all_data)
6266         (tui_data_window::refresh_all)
6267         (tui_data_window::do_scroll_vertical): Update.
6268         * tui/tui-regs.c (tui_show_registers): Update.
6269         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6270         New method.
6271
6272 2019-07-17  Tom Tromey  <tom@tromey.com>
6273
6274         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6275         declare.
6276         * tui/tui-windata.c
6277         (tui_data_window::delete_data_content_windows): Rename from
6278         tui_delete_data_content_windows.
6279         (tui_data_window::display_all_data)
6280         (tui_data_window::do_scroll_vertical): Update.
6281         * tui/tui-data.h (struct tui_data_window)
6282         <delete_data_content_windows>: New method.
6283
6284 2019-07-17  Tom Tromey  <tom@tromey.com>
6285
6286         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6287         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6288
6289 2019-07-17  Tom Tromey  <tom@tromey.com>
6290
6291         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6292         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6293         from tui_display_all_data.
6294         * tui/tui-win.c
6295         (tui_data_window::do_make_visible_with_new_height): Update.
6296         * tui/tui-regs.c (tui_show_registers): Update.
6297         * tui/tui-layout.c (tui_set_layout): Update.
6298         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6299         method.
6300
6301 2019-07-17  Tom Tromey  <tom@tromey.com>
6302
6303         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6304         * tui/tui-windata.c (tui_display_data_from): Remove.
6305         (tui_data_window::refresh_all): Update.
6306
6307 2019-07-17  Tom Tromey  <tom@tromey.com>
6308
6309         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6310         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6311         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6312         tui_display_registers_from_line.
6313         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6314         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6315         "force_display" parameter.
6316
6317 2019-07-17  Tom Tromey  <tom@tromey.com>
6318
6319         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6320         declare.
6321         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6322         Rename from tui_first_reg_element_no_inline.
6323         (tui_display_reg_element_at_line)
6324         (tui_display_registers_from_line): Update.
6325         * tui/tui-data.h (struct tui_data_window)
6326         <first_reg_element_no_inline>: New method.
6327
6328 2019-07-17  Tom Tromey  <tom@tromey.com>
6329
6330         * tui/tui-windata.c (tui_display_data_from)
6331         (tui_data_window::do_scroll_vertical): Update.
6332         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6333         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6334         Rename from tui_line_from_reg_element_no.
6335         (tui_display_registers_from_line): Update.
6336         * tui/tui-data.h (struct tui_data_window)
6337         <line_from_reg_element_no>: New method.
6338
6339 2019-07-17  Tom Tromey  <tom@tromey.com>
6340
6341         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6342         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6343         tui_last_regs_line_no.
6344         (tui_display_reg_element_at_line)
6345         (tui_display_registers_from_line): Update.
6346         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6347         method.
6348
6349 2019-07-17  Tom Tromey  <tom@tromey.com>
6350
6351         PR tui/24722:
6352         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6353         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6354         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6355         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6356         (tui_update_breakpoint_info): Likewise.
6357         * tui/tui-hooks.c (tui_event_create_breakpoint)
6358         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6359         Update.
6360
6361 2019-07-17  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6364
6365 2019-07-17  Tom Tromey  <tom@tromey.com>
6366
6367         * tui/tui-winsource.c (tui_update_source_window_as_is)
6368         (tui_update_source_windows_with_addr): Update.
6369         * tui/tui-source.h (tui_set_source_content)
6370         (tui_show_symtab_source): Add "win_info" parameter.
6371         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6372         parameter.
6373         (tui_show_symtab_source): Likewise.
6374
6375 2019-07-17  Tom Tromey  <tom@tromey.com>
6376
6377         * tui/tui-wingeneral.c
6378         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6379
6380 2019-07-17  Tom Tromey  <tom@tromey.com>
6381
6382         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6383         (struct tui_cmd_window) <can_scroll>: New method.
6384         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6385         method.
6386
6387 2019-07-17  Tom Tromey  <tromey@adacore.com>
6388
6389         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6390         do_field_signed>: Rename.  Change type of "value".
6391         * ui-out.c (ui_out::field_signed): Rename from field_int.
6392         Change type of "value".
6393         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6394         type of "value".
6395         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6396         do_field_int.  Change type of "value".
6397         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6398         do_field_int.  Change type of "value".
6399         * tracepoint.c (trace_status_mi, tfind_1)
6400         (print_one_static_tracepoint_marker): Update.
6401         * thread.c (print_thread_info_1, print_selected_thread_frame):
6402         Update.
6403         * stack.c (print_frame, print_frame_info): Update.
6404         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6405         Update.
6406         * source.c (print_source_lines_base): Update.
6407         * skip.c (info_skip_command): Update.
6408         * record-btrace.c (btrace_ui_out_decode_error)
6409         (btrace_call_history_src_line): Update.
6410         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6411         Update.
6412         * progspace.c (print_program_space): Update.
6413         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6414         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6415         do_field_int.  Change type of "value".
6416         * mi/mi-out.c (mi_ui_out::do_table_begin)
6417         (mi_ui_out::do_table_header): Update.
6418         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6419         type of "value".
6420         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6421         (mi_cmd_data_list_changed_registers, output_register)
6422         (mi_cmd_data_read_memory, mi_load_progress)
6423         (mi_cmd_trace_frame_collected): Update.
6424         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6425         Update.
6426         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6427         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6428         (mi_cmd_var_list_children, varobj_update_one): Update.
6429         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6430         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6431         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6432         * inferior.c (print_inferior): Update.
6433         * gdb_bfd.c (print_one_bfd): Update.
6434         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6435         Update.
6436         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6437         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6438         do_field_int.  Change type of "value".
6439         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6440         do_field_int.  Change type of "value".
6441         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6442         (print_one_breakpoint_location, print_it_catch_fork)
6443         (print_one_catch_fork, print_it_catch_vfork)
6444         (print_one_catch_vfork, print_it_catch_solib)
6445         (print_it_catch_exec, print_it_ranged_breakpoint)
6446         (print_mention_watchpoint, print_mention_masked_watchpoint)
6447         (bkpt_print_it, update_static_tracepoint): Update.
6448         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6449         * break-catch-syscall.c (print_it_catch_syscall): Update.
6450         * ada-tasks.c (print_ada_task_info): Update.
6451         * ada-lang.c (print_it_exception, print_mention_exception):
6452         Update.
6453
6454 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         PR breakpoints/24541
6457         * gdbarch.c: Regenerate.
6458         * gdbarch.h: Regenerate.
6459         * gdbarch.sh: Adjust return type and parameter types for
6460         'stap_adjust_register'.
6461         (i386_stap_adjust_register): Adjust signature and return new
6462         register name.
6463         * stap-probe.c (stap_parse_register_operand): Adjust use of
6464         'gdbarch_stap_adjust_register'.
6465
6466 2019-07-17  Tom Tromey  <tromey@adacore.com>
6467
6468         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6469         declare VEC.
6470         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6471         std::vector.
6472         (struct s390_process_info): Add initializers.
6473         (s390_add_process): Use new.
6474         (s390_linux_nat_target::low_forget_process): Use delete.
6475         (s390_linux_nat_target::low_new_fork)
6476         (s390_linux_nat_target::stopped_by_watchpoint)
6477         (s390_linux_nat_target::low_prepare_to_resume)
6478         (s390_linux_nat_target::insert_watchpoint)
6479         (s390_linux_nat_target::insert_hw_breakpoint)
6480         (s390_linux_nat_target::remove_watchpoint)
6481         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6482
6483 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6484
6485         * aarch64-fbsd-nat.c: Include regcache.h.
6486         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6487         argument.
6488         (aarch64_fbsd_nat_target::fetch_registers)
6489         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6490         variable.
6491         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6492
6493 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6494
6495         * fbsd-nat.c: Include gdbarch.h.
6496
6497 2019-07-15  Tom Tromey  <tromey@adacore.com>
6498
6499         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6500
6501 2019-07-15  Tom Tromey  <tromey@adacore.com>
6502
6503         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6504         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6505         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6506         * cli-out.c (cli_ui_out::do_field_int): New method.
6507         * ui-out.c (ui_out::field_unsigned): New method.
6508         * symfile.c (generic_load): Use field_unsigned.
6509         (print_transfer_performance): Likewise.
6510         * record-btrace.c (ui_out_field_uint): Remove.
6511         (btrace_call_history_insn_range, btrace_call_history): Use
6512         field_unsigned.
6513         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6514         field_unsigned.
6515         * ui-out.h (class ui_out) <field_unsigned>: New method.
6516         <do_field_unsigned>: Likewise.
6517
6518 2019-07-15  Tom Tromey  <tromey@adacore.com>
6519
6520         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6521         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6522         * target.c (flash_erase_command): Use field_string.
6523         * infrun.c (print_signal_received_reason): Use field_string.
6524         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6525         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6526         field_string.
6527         * ada-tasks.c (print_ada_task_info): Use field_string.
6528
6529 2019-07-15  Tom Tromey  <tromey@adacore.com>
6530
6531         * target.c (flash_erase_command): Use field_core_addr.
6532         * symfile.c (generic_load): Use field_core_addr.
6533         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6534         Use field_core_addr.
6535         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6536         field_core_addr.
6537
6538 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6539
6540         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6541         value if its desired type is smaller than a CORE_ADDR and signed.
6542
6543 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6544
6545         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6546         of changes to field names, and use new is_reference field to
6547         decide if a property is a reference or not.
6548         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6549         field.
6550         (struct dwarf2_property_baton): Update header comment, rename
6551         'referenced_type' to 'property_type' and update comments.
6552         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6553         default property type, store in property baton, update to take
6554         accound of renamed field.
6555         (read_func_scope): Update call to attr_to_dynamic_prop.
6556         (read_array_type): Likewise.
6557         (dwarf2_per_cu_addr_sized_int_type): New function.
6558         (read_subrange_index_type): Move type finding code to
6559         dwarf2_per_cu_addr_sized_int_type.
6560         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6561         (dwarf2_per_cu_addr_type): New function.
6562         (set_die_type): Update calls to attr_to_dynamic_prop.
6563
6564 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * dwarf2read.c (read_subrange_index_type): New function.
6567         (read_subrange_type): Move code into new function and call it.
6568         * gdbtypes.c (create_range_type): Add some asserts.
6569
6570 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6571
6572         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6573         update return statements.
6574         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6575         declaration, and update comment to match.
6576         * gdbtypes.c (resolve_dynamic_array): Update call to
6577         dwarf2_evaluate_property to match new return type.
6578
6579 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6580
6581         * valarith.c (value_subscripted_rvalue): Change lowerbound
6582         parameter type from int to LONGEST.
6583         * value.h (value_subscripted_rvalue): Likewise in declaration.
6584
6585 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6586
6587         * cli/cli-utils.c (info_print_command_completer): New function.
6588         * cli/cli-utils.h: Add 'completer.h' include, and forward
6589         declaration for 'struct cmd_list_element'.
6590         (info_print_command_completer): Declare.
6591         * stack.c (_initialize_stack): Add completer for 'info locals' and
6592         'info args'.
6593         * symtab.c (_initialize_symtab): Add completer for 'info
6594         variables' and 'info functions'.
6595         * NEWS: Mention completion for additional info commands.
6596
6597 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6598
6599         * cli/cli-utils.c (extract_info_print_args): Delete.
6600         (extract_arg_maybe_quoted): Delete.
6601         (info_print_options_defs): New variable.
6602         (make_info_print_options_def_group): New function.
6603         (extract_info_print_options): Define new function.
6604         * cli/cli-utils.h (extract_info_print_args): Delete.
6605         (struct info_print_options): New structure.
6606         (extract_info_print_options): Declare new function.
6607         * stack.c (info_locals_command): Update to use new
6608         extract_info_print_options, also add a header comment.
6609         (info_args_command): Likewise.
6610         * symtab.c (info_variables_command): Likewise.
6611         (info_functions_command): Likewise.
6612
6613 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6614
6615         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6616         to extract string arguments.
6617         * common/common-utils.c (extract_string_maybe_quoted): New function.
6618         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6619
6620 2019-07-11  Tom Tromey  <tromey@adacore.com>
6621
6622         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6623         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6624         * top.h (gdbinit): Don't declare.
6625         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6626         into...
6627         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6628         * top.c (gdb_init): Don't call init_cli_cmds.
6629         (gdbinit): Remove.
6630         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6631
6632 2019-07-11  Tom Tromey  <tromey@adacore.com>
6633
6634         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6635         after it has been moved.
6636
6637 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6638
6639         * valops.c (value_must_coerce_to_target): Change return type to
6640         bool.
6641         * value.h (value_must_coerce_to_target): Likewise.
6642
6643 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6644
6645         * breakpoint.c (is_hardware_watchpoint): Remove
6646         forward-declaration.
6647         (is_masked_watchpoint): Change return type to bool.
6648         (is_tracepoint): Likewise.
6649         (is_breakpoint): Likewise.
6650         (is_hardware_watchpoint): Likewise.
6651         (is_watchpoint): Likewise.
6652         (is_no_memory_software_watchpoint): Likewise.
6653         (is_catchpoint): Likewise.
6654         (breakpoint_1): Make FILTER parameter's return type bool.
6655         is_masked_watchpoint): Change return type to bool.
6656         (save_breakpoints): Make FILTER parameter's return type bool.
6657         * breakpoint.h (is_breakpoint): Change return type to bool.
6658         (is_watchpoint): Likewise.
6659         (is_catchpoint): Likewise.
6660         (is_tracepoint): Likewise.
6661
6662 2019-07-10  Tom Tromey  <tom@tromey.com>
6663
6664         * defs.h: Don't include gdbarch.h.
6665         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6666         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6667         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6668         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6669         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6670         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6671         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6672         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6673         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6674         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6675         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6676         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6677         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6678         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6679         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6680         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6681         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6682         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6683         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6684         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6685         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6686         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6687         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6688         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6689         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6690         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6691         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6692
6693 2019-07-10  Tom Tromey  <tromey@adacore.com>
6694
6695         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6696         * breakpoint.c (init_ada_exception_breakpoint): Register as
6697         bp_catchpoint.
6698         (print_one_breakpoint_location, print_one_breakpoint): Use
6699         is_ada_exception_catchpoint.
6700         * ada-lang.c (class ada_catchpoint_location): Pass
6701         bp_loc_software_breakpoint to bp_location constructor.
6702         (is_ada_exception_catchpoint): New function.
6703
6704 2019-07-10  Tom Tromey  <tromey@adacore.com>
6705
6706         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6707         VEC.
6708         (struct arm_exidx_entry): New method operator<.
6709         (struct arm_exidx_data) <section_maps>: Change type.
6710         (arm_exidx_data_free): Remove.
6711         (arm_exidx_data_key): Change type.  Move lower.
6712         (arm_exidx_new_objfile): Update.
6713         (arm_compare_exidx_entries): Remove.
6714         (arm_find_exidx_entry, _initialize_arm_tdep)
6715
6716 2019-07-10  Tom Tromey  <tromey@adacore.com>
6717
6718         * solib-spu.c (ocl_program_data_key): Change type.
6719         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6720         Update.
6721
6722 2019-07-10  Tom Tromey  <tromey@adacore.com>
6723
6724         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6725         (struct solib_aix_inferior_data) <library_list>: Change type.
6726         (solib_aix_inferior_data_handle): Change type.
6727         (get_solib_aix_inferior_data): Update.
6728         (solib_aix_free_library_list): Remove.
6729         (library_list_start_library): Update.
6730         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6731         return type.
6732         (solib_aix_get_library_list)
6733         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6734         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6735
6736 2019-07-10  Tom Tromey  <tromey@adacore.com>
6737
6738         * solib-dsbt.c (struct dsbt_info): Add initializers.
6739         (solib_dsbt_pspace_data): Change type.
6740         (dsbt_pspace_data_cleanup): Remove.
6741         (get_dsbt_info, _initialize_dsbt_solib): Update.
6742
6743 2019-07-10  Tom Tromey  <tromey@adacore.com>
6744
6745         * spu-tdep.c (spu_overlay_data): Change type.
6746         (spu_get_overlay_table, spu_overlay_new_objfile)
6747         (_initialize_spu_tdep): Update.
6748
6749 2019-07-10  Tom Tromey  <tromey@adacore.com>
6750
6751         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6752         destructor.
6753         (dbx_objfile_data_key): Change type and declare later.
6754         (DBX_SYMFILE_INFO): Rewrite.
6755         * dbxread.c (dbx_objfile_data_key): Change type.
6756         (dbx_symfile_init): Update.
6757         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6758         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6759         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6760
6761 2019-07-10  Tom Tromey  <tromey@adacore.com>
6762
6763         * jit.c (jit_program_space_key): Change type.  Move lower.
6764         (get_jit_program_space_data): Update.
6765         (jit_program_space_data_cleanup): Remove.
6766         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6767         Update.
6768         (struct jit_program_space_data): Add initializers.
6769
6770 2019-07-10  Tom Tromey  <tromey@adacore.com>
6771
6772         * solib-darwin.c (struct darwin_info): Add initializers.
6773         (solib_darwin_pspace_data): Change type.
6774         (darwin_pspace_data_cleanup): Remove.
6775         (get_darwin_info, _initialize_darwin_solib): Update.
6776
6777 2019-07-10  Tom Tromey  <tromey@adacore.com>
6778
6779         * remote-sim.c (struct sim_inferior_data): Add initializers,
6780         constructor, and destructor.
6781         (sim_inferior_data_key): Change type.  Move lower.
6782         (check_for_duplicate_sim_descriptor): Update.
6783         (get_sim_inferior_data): Use new.  Update.
6784         (~sim_inferior_data_cleanup): Rename from
6785         sim_inferior_data_cleanup.  Simplify.
6786         (gdbsim_close_inferior, simulator_command)
6787         (sim_command_completer, _initialize_remote_sim): Update.
6788         (next_pid, INITIAL_PID): Move earlier.
6789
6790 2019-07-10  Tom Tromey  <tromey@adacore.com>
6791
6792         * python/python-internal.h (create_thread_object): Return
6793         gdbpy_ref.
6794         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6795         * python/py-inferior.c (struct threadlist_entry): Add
6796         constructor.
6797         <thread_obj>: Now a gdbpy_ref.
6798         (thread_to_thread_object): Update.
6799         (add_thread_object): Use new.
6800         (delete_thread_object): Use delete.
6801         (infpy_threads): Update.
6802         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6803         GIL.
6804
6805 2019-07-10  Tom Tromey  <tromey@adacore.com>
6806
6807         * valops.c (value_cast): Specialize error message for Ada.
6808
6809 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6810
6811         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6812
6813 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6814
6815         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6816         bpstat_should_step): Return bool, adjust comments.
6817         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6818         bpstat_should_step): Likewise.
6819
6820 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6821
6822         * features/Makefile: Use feature target descriptions for Arm.
6823         * features/arm/arm-core.c: Generate new file.
6824         * features/arm/arm-fpa.c: Likewise.
6825         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6826         * features/arm/arm-m-profile.c: Likewise.
6827         * features/arm/arm-vfpv2.c: Likewise.
6828         * features/arm/arm-vfpv3.c: Likewise.
6829         * features/arm/xscale-iwmmxt.c: Likewise.
6830         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6831
6832 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6833
6834         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6835         ptrace earlier.
6836
6837 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6838
6839         * features/aarch64-pauth.c: Regenerate.
6840
6841 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6842
6843         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6844         bool.
6845         (bpstat_what): Use false instead of 0.
6846
6847 2019-07-09  Pedro Alves  <palves@redhat.com>
6848
6849         * break-catch-throw.c (is_exception_catchpoint): New.
6850         * breakpoint.c (print_one_breakpoint_location): New parameter
6851         'raw_loc'.  Handle it.  Use
6852         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6853         looking at the breakpoint's type.
6854         (print_one_breakpoint): If handling "maint info breakpoints", also
6855         print locations of exception catchpoints.
6856         * breakpoint.h (is_exception_catchpoint): Declare.
6857
6858 2019-07-09  Pedro Alves  <palves@redhat.com>
6859
6860         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6861         "addr" field.
6862         (allocate_location_exception_catchpoint): New.
6863         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6864         (initialize_throw_catchpoint_ops): Install
6865         allocate_location_exception_catchpoint as allocate_location
6866         method.
6867         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6868         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6869         bp_loc_other.
6870         (breakpoint_address_is_meaningful): Delete.
6871         (bl_address_is_meaningful): New.
6872         (breakpoint_locations_match): Adjust comment.
6873         (bp_location_from_bp_type): New, factored out of...
6874         (bp_location::bp_location(breakpoint *)): ... this.
6875         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6876         factored out of...
6877         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6878         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6879         breakpoint_address_is_meaningful.
6880         (bp_locations_compare): Adjust comment.
6881         (update_global_location_list): Use bl_address_is_meaningful
6882         instead of breakpoint_address_is_meaningful.
6883         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6884         explicit.
6885         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6886         * python/py-breakpoint.c (bppy_get_location): No longer check
6887         whether location is null.
6888
6889 2019-07-09  Pedro Alves  <palves@redhat.com>
6890
6891         PR c++/15468
6892         * breakpoint.c (print_one_breakpoint_location): Remove
6893         single-location assert.
6894
6895 2019-07-09  Tom Tromey  <tom@tromey.com>
6896
6897         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6898         * configure: Rebuild.
6899         * configure.ac: Change common to gdbsupport.
6900         * gdbsupport: Rename from common.
6901         * acinclude.m4: Change common to gdbsupport.
6902         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6903         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6904         gdbsupport.
6905         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6906         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6907         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6908         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6909         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6910         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6911         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6912         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6913         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6914         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6915         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6916         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6917         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6918         coff-pe-read.c, command.h, compile/compile-c-support.c,
6919         compile/compile-c.h, compile/compile-cplus-symbols.c,
6920         compile/compile-cplus-types.c, compile/compile-cplus.h,
6921         compile/compile-loc2c.c, compile/compile.c, completer.c,
6922         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6923         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6924         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6925         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6926         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6927         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6928         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6929         features/aarch64-core.c, features/aarch64-fpu.c,
6930         features/aarch64-pauth.c, features/aarch64-sve.c,
6931         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6932         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6933         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6934         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6935         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6936         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6937         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6938         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6939         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6940         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6941         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6942         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6943         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6944         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6945         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6946         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6947         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6948         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6949         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6950         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6951         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6952         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6953         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6954         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6955         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6956         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6957         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6958         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6959         minsyms.c, mips-linux-tdep.c, namespace.h,
6960         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6961         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6962         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6963         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6964         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6965         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6966         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6967         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6968         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6969         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6970         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6971         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6972         procfs.c, producer.c, progspace.h, psymtab.h,
6973         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6974         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6975         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6976         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6977         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6978         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6979         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6980         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6981         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6982         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6983         target-memory.c, target.c, target.h, target/waitstatus.c,
6984         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6985         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6986         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6987         unittests/array-view-selftests.c,
6988         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6989         unittests/common-utils-selftests.c,
6990         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6991         unittests/format_pieces-selftests.c,
6992         unittests/function-view-selftests.c,
6993         unittests/lookup_name_info-selftests.c,
6994         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6995         unittests/mkdir-recursive-selftests.c,
6996         unittests/observable-selftests.c,
6997         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6998         unittests/parse-connection-spec-selftests.c,
6999         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7000         unittests/scoped_fd-selftests.c,
7001         unittests/scoped_mmap-selftests.c,
7002         unittests/scoped_restore-selftests.c,
7003         unittests/string_view-selftests.c, unittests/style-selftests.c,
7004         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7005         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7006         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7007         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7008         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7009         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7010
7011 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7012
7013         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7014         bool value.
7015         (decode_digits_ordinary): Set explicit_line field in sal.
7016         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7017         symtab_and_line that was set on an explicit line number in
7018         assembler code.  Do always update the recorded symtab and line if
7019         we do skip the prologue.
7020
7021 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7022
7023         * breakpoint.c (set_breakpoint_location_function): Remove
7024         explicit_loc parameter.
7025         (momentary_breakpoint_from_master): Update call to
7026         set_breakpoint_location_function.
7027         (add_location_to_breakpoint): Likewise.
7028
7029 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7032         required features based on default bfd type when no specific bfd
7033         is present.
7034
7035 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7036
7037         * NEWS: Mention that GDB printf and eval commands can now print
7038         C-style and Ada-style convenience var strings without
7039         calling the inferior.
7040         * printcmd.c (printf_c_string): Locally print GDB internal var
7041         instead of transiting via the inferior.
7042         (printf_wide_c_string): Likewise.
7043
7044 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7045
7046         PR breakpoints/25011
7047         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7048
7049 2019-07-04  Tom Tromey  <tom@tromey.com>
7050
7051         PR tui/24724:
7052         * tui/tui-winsource.c (tui_clear_source_content): Update.
7053         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7054         (tui_update_breakpoint_info): Update.
7055         (tui_set_exec_info_content): Update.
7056         * tui/tui-source.c (tui_set_source_content_nil): Update.
7057         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7058         has_break.
7059         * tui/tui-data.h (enum tui_bp_flag): New.
7060         (tui_bp_flags): New enum flags type.
7061         (struct tui_source_element) <break_mode>: Change type.  Rename
7062         from has_break.
7063         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7064         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7065         constants.
7066         * tui/tui-winsource.h: Fix comment.
7067
7068 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7069
7070         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7071         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7072         (store_fpregs_to_thread)
7073         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7074         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7075         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7076         (IWMMXT_REGS_SIZE): Add define.
7077         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7078         (fetch_vfp_regs, store_vfp_regs)
7079         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7080         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7081
7082 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7083
7084         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7085         defines.
7086         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7087         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7088         (ARM_INT_REGISTER_SIZE): ...to this.
7089         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7090         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7091         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7092         (arm_linux_collect_gregset, supply_nwfpe_register)
7093         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7094         defines.
7095         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7096         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7097         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7098         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7099         (arm_return_in_memory, arm_store_return_value)
7100         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7101         (arm_record_ld_st_multiple): Likewise.
7102         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7103         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7104
7105 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7106
7107         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7108         AARCH64_DISPLACED_MODIFIED_INSNS.
7109         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7110         (aarch64_displaced_step_copy_insn): Likewise.
7111         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7112         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7113         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7114         ARM_DISPLACED_MODIFIED_INSNS.
7115         * arm-tdep.c (arm_gdbarch_init): Likewise.
7116         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7117         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7118         (struct arm_displaced_step_closure): Use
7119         ARM_DISPLACED_MODIFIED_INSNS.
7120
7121 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7122
7123         * features/Makefile: Remove unused xml files.
7124         * features/aarch64.xml: Remove.
7125         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7126         * features/i386/amd64-avx-avx512.xml: Remove.
7127         * features/i386/amd64-avx-linux.xml: Remove.
7128         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7129         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7130         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7131         * features/i386/amd64-avx-mpx.xml: Remove.
7132         * features/i386/amd64-avx.xml: Remove.
7133         * features/i386/amd64-linux.xml: Remove.
7134         * features/i386/amd64-mpx-linux.xml: Remove.
7135         * features/i386/amd64-mpx.xml: Remove.
7136         * features/i386/amd64.xml: Remove.
7137         * features/i386/i386-avx-avx512-linux.xml: Remove.
7138         * features/i386/i386-avx-avx512.xml: Remove.
7139         * features/i386/i386-avx-linux.xml: Remove.
7140         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7141         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7142         * features/i386/i386-avx-mpx-linux.xml: Remove.
7143         * features/i386/i386-avx-mpx.xml: Remove.
7144         * features/i386/i386-avx.xml: Remove.
7145         * features/i386/i386-linux.xml: Remove.
7146         * features/i386/i386-mmx-linux.xml: Remove.
7147         * features/i386/i386-mmx.xml: Remove.
7148         * features/i386/i386-mpx-linux.xml: Remove.
7149         * features/i386/i386-mpx.xml: Remove.
7150         * features/i386/i386.xml: Remove.
7151         * features/i386/x32-avx-avx512-linux.xml: Remove.
7152         * features/i386/x32-avx-linux.xml: Remove.
7153         * features/i386/x32-linux.xml: Remove.
7154
7155 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7156
7157         * regformats/aarch64.dat: Remove.
7158         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7159         * regformats/i386/amd64-avx-linux.dat: Remove.
7160         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7161         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7162         * regformats/i386/amd64-linux.dat: Remove.
7163         * regformats/i386/amd64-mpx-linux.dat: Remove.
7164         * regformats/i386/amd64.dat: Remove.
7165         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7166         * regformats/i386/i386-avx-linux.dat: Remove.
7167         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7168         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7169         * regformats/i386/i386-linux.dat: Remove.
7170         * regformats/i386/i386-mmx-linux.dat: Remove.
7171         * regformats/i386/i386-mpx-linux.dat: Remove.
7172         * regformats/i386/i386.dat: Remove.
7173         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7174         * regformats/i386/x32-avx-linux.dat: Remove.
7175         * regformats/i386/x32-linux.dat: Remove.
7176
7177 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7178
7179         * aarch64-tdep.c: Remove xml self tests.
7180         * amd64-linux-tdep.c: Likewise.
7181         * amd64-tdep.c: Likewise.
7182         * i386-linux-tdep.c: Likewise.
7183         * i386-tdep.c: Likewise.
7184
7185 2019-07-03  Pedro Alves  <palves@redhat.com>
7186
7187         PR cli/24732
7188         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7189         (pipe_cmd_option_defs): New.
7190         (make_pipe_cmd_options_def_group): New.
7191         (pipe_command): Use gdb::option::process_options.
7192         (pipe_command_completer): New function.
7193         (_initialize_cli_cmds): Install completer for "pipe" command.
7194
7195 2019-07-03  Pedro Alves  <palves@redhat.com>
7196
7197         * cli/cli-option.c (union option_value) <string>: New field.
7198         (struct option_def_and_value): Add ctor, move ctor, dtor and
7199         use DISABLE_COPY_AND_ASSIGN.
7200         (option_def_and_value::clear_value): New.
7201         (parse_option, save_option_value_in_ctx, get_val_type_str)
7202         (add_setshow_cmds_for_options): Handle var_string.
7203         * cli-option.h (union option_def::var_address) <string>: New
7204         field.
7205         (struct string_option_def): New.
7206         * maint-test-options.c (struct test_options_opts): Add default
7207         ctor and use DISABLE_COPY_AND_ASSIGN.
7208         <string_opt>: New field.
7209         (test_options_opts::~test_options_opts): New.
7210         (test_options_opts::dump): Also dump "-string".
7211         (test_options_option_defs): Install "string.
7212
7213 2019-07-03  Pedro Alves  <palves@redhat.com>
7214
7215         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7216         option_value with a null enumeration.
7217         (complete_options): Save the option values in the context.
7218         (save_option_value_in_ctx): New, factored out from ...
7219         (process_options): ... here.
7220         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7221         of the function.
7222         * maint-test-options.c (test_options_opts::dump): New, factored
7223         out from ...
7224         (maintenance_test_options_command_mode): ... here.
7225         (maintenance_test_options_command_completion_result): Delete.
7226         (maintenance_test_options_command_completion_text): Update
7227         comment.
7228         (maintenance_show_test_options_completion_result): Change
7229         prototype.  Just print
7230         maintenance_test_options_command_completion_text.
7231         (save_completion_result): New.
7232         (maintenance_test_options_completer_mode): Pass options context to
7233         complete_options, and then save a dump.
7234         (_initialize_maint_test_options): Use add_cmd to install "maint
7235         show test-options-completion-result".
7236
7237 2019-07-03  Pedro Alves  <palves@redhat.com>
7238
7239         * NEWS (New commands): Mention "with" and "maint with".
7240         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7241         (with_command, with_command_completer): New.
7242         (pipe_command): Adjust to new repeat_previous
7243         interface.
7244         (_initialize_cli_cmds): Install the "with" command and its "w"
7245         alias.
7246         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7247         declarations.
7248         * cli/cli-setshow.c (parse_cli_var_uinteger)
7249         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7250         argument strings for all var_types.
7251         (get_setshow_command_value_string): New, factored out from ...
7252         (do_show_command): ... this.
7253         * cli/cli-setshow.h: Include <string>.
7254         (get_setshow_command_value_string): Declare.
7255         * command.h (repeat_previous): Now returns const char *.  Adjust
7256         comment.
7257         * maint.c: Include "cli/cli-cmds.h".
7258         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7259         (_initialize_maint_cmds): Register the "maintenance with" command.
7260         * top.c (repeat_previous): Move bits from pipe_command here:
7261         Return the saved command line, if any; error out if there's no
7262         command to relaunch.
7263
7264 2019-07-03  Pedro Alves  <palves@redhat.com>
7265
7266         * NEWS (New commands): Mention "maint set/show test-settings"
7267         instead of "maint test-settings".
7268         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7269         (maintenance_test_settings_set_list): Rename to ...
7270         (maintenance_set_test_settings_list): ... this.
7271         (maintenance_test_settings_show_list): Rename to  ...
7272         (maintenance_show_test_settings_list): ... this.
7273         (maintenance_test_settings_cmd): Delete.
7274         (maintenance_test_settings_set_cmd): ...
7275         (maintenance_set_test_settings_cmd): ... this.
7276         (maintenance_test_settings_show_cmd): ...
7277         (maintenance_show_test_settings_cmd): ... this.
7278         (maintenance_test_settings_show_value_cmd):
7279         (maintenance_show_test_settings_value_cmd): ... this.
7280         (_initialize_maint_test_settings): No longer install the "maint
7281         test-settings" prefix command.  Rename "maint test-settings set"
7282         to "maint set test-settings", and "maint test-settings show" to
7283         "maint show test-settings".  Adjust all subcommands.
7284
7285 2019-07-03  Pedro Alves  <palves@redhat.com>
7286
7287         * maint-test-settings.c: Fix file's intro comment.  Replace all
7288         references to "test-options" with references to "test-settings",
7289         in comments.
7290
7291 2019-07-03  Pedro Alves  <palves@redhat.com>
7292
7293         * maint-test-settings.c (maintenance_test_settings_xxx)
7294         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7295         New.
7296         (maintenance_test_settings_enums): Use them.
7297         (maintenance_test_settings_enum): Default to
7298         maintenance_test_settings_xxx.
7299         (_initialize_maint_test_settings): Initialize
7300         MAINTENANCE_TEST_SETTINGS_FILENAME.
7301
7302 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7303
7304         * breakpoint.h (remove_breakpoints_inf): Change return type to
7305         void, move function documentation here.
7306         * breakpoint.c (remove_breakpoints_inf): Change return type to
7307         void, move function documentation to header.
7308
7309 2019-07-02  Pedro Alves  <palves@redhat.com>
7310
7311         * NEWS (Completion improvements): Mention "info threads".
7312         * thread.c (struct info_threads_opts, info_threads_option_defs)
7313         (make_info_threads_options_def_group): New.
7314         (info_threads_command): Use gdb::option::process_options.
7315         (info_threads_command_completer): New.
7316         (_initialize_thread): Use gdb::option::build_help to build the
7317         help text for "info threads".
7318
7319 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7320
7321         * defs.h (generic_load): Move from here...
7322         * symfile.h (generic_load): ... to here.  Rename name parameter
7323         to args.
7324         * symfile.c (generic_load): Add comment.
7325
7326 2019-07-01  Tom Tromey  <tromey@adacore.com>
7327
7328         * dwarf2read.c
7329         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7330         declaration of without_params.  Fix formatting.
7331
7332 2019-07-01  Tom Tromey  <tromey@adacore.com>
7333
7334         * ada-exp.y (find_primitive_type): Update.
7335         * ada-lang.h (ada_lookup_symbol): Update.
7336         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7337         parameter.
7338         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7339
7340 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7341
7342         PR breakpoints/24541
7343         * gdbarch.c: Regenerate.
7344         * gdbarch.h: Regenerate.
7345         * gdbarch.sh: Add 'stap_adjust_register'.
7346         * i386-tdep.c: Include '<unordered_set>'.
7347         (i386_stap_adjust_register): New function.
7348         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7349         * stap-probe.c (stap_parse_register_operand): Call
7350         'gdbarch_stap_adjust_register'.
7351
7352 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7353
7354         PR python/24742
7355         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7356         * python/python.c (do_start_initialization): Use 'xmalloc'
7357         instead of 'PyMem_Malloc'.
7358
7359 2019-06-28  Tom Tromey  <tromey@adacore.com>
7360
7361         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7362         for Ada.
7363
7364 2019-06-27  Tom Tromey  <tromey@adacore.com>
7365
7366         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7367         objfile_key.
7368         (arm_find_mapping_symbol, arm_record_special_symbol)
7369         (_initialize_arm_tdep): Update.
7370         (arm_objfile_data_free): Remove.
7371
7372 2019-06-27  Tom Tromey  <tromey@adacore.com>
7373
7374         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7375         to cp_print_static_field.
7376
7377 2019-06-26  Tom Tromey  <tromey@adacore.com>
7378
7379         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7380         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7381         declare.
7382
7383 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7384
7385         * features/aarch64-core.c (create_feature_aarch64_core):
7386         Regenerate.
7387         * features/aarch64-core.xml: Add cpsr flags.
7388
7389 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7390
7391         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7392         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7393
7394 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7395
7396         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7397         field.
7398         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7399         use.
7400         (arm_record_special_symbol): Don't insert new symbol in sorted
7401         position, push it at the end.
7402
7403 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7404
7405         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7406         (arm_mapping_symbol_s): Remove.
7407         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7408         (arm_mapping_symbol_vec): New typedef.
7409         (struct arm_per_objfile): Add constructor.
7410         <section_maps>: Change type to
7411         std::unique_ptr<arm_mapping_symbol_vec[]>.
7412         (arm_compare_mapping_symbols): Remove.
7413         (arm_find_mapping_symbol): Adjust to section_maps type change.
7414         (arm_objfile_data_free): Call delete on arm_per_objfile.
7415         (arm_record_special_symbol): Adjust to section_maps type change.
7416         Allocate arm_per_objfile with new.
7417
7418 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7419
7420         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7421         with the command prefix.
7422
7423 2019-06-25  Tom Tromey  <tom@tromey.com>
7424
7425         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7426         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7427
7428 2019-06-25  Tom Tromey  <tom@tromey.com>
7429
7430         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7431         type.
7432         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7433         protected.
7434
7435 2019-06-25  Tom Tromey  <tom@tromey.com>
7436
7437         * tui/tui-winsource.c
7438         (tui_source_window_base::set_is_exec_point_at): Add check against
7439         LOA_ADDRESS.
7440
7441 2019-06-25  Tom Tromey  <tom@tromey.com>
7442
7443         * tui/tui-source.c (tui_set_source_content): Don't check before
7444         xfree.
7445         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7446
7447 2019-06-25  Tom Tromey  <tom@tromey.com>
7448
7449         * tui/tui-winsource.h (tui_update_source_window_as_is)
7450         (tui_alloc_source_buffer, tui_line_is_displayed)
7451         (tui_addr_is_displayed): Change type of win_info.
7452         * tui/tui-winsource.c (tui_update_source_window_as_is)
7453         (tui_clear_source_content, tui_show_source_line)
7454         (tui_show_source_content, tui_source_window_base::refill)
7455         (tui_source_window_base::set_is_exec_point_at)
7456         (tui_source_window_base::set_is_exec_point_at)
7457         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7458         (tui_alloc_source_buffer, tui_line_is_displayed)
7459         (tui_addr_is_displayed): Change type of win_info.  Update.
7460         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7461         (tui_source_window_base::do_make_visible_with_new_height):
7462         Update.
7463         * tui/tui-source.c (tui_set_source_content)
7464         (tui_set_source_content_nil)
7465         (tui_source_window::do_scroll_vertical): Update.
7466         * tui/tui-layout.c (show_layout): Update.
7467         * tui/tui-disasm.c (tui_set_disassem_content)
7468         (tui_disasm_window::do_scroll_vertical): Update.
7469         * tui/tui-data.h (tui_win_content): Remove.
7470         (struct tui_gen_win_info) <content, content_size>: Remove.
7471         (struct tui_source_element): Add initializers and destructor.
7472         (union tui_which_element, struct tui_win_element): Remove.
7473         (struct tui_source_window_base) <content>: New field.
7474         (struct tui_data_window): Remove destructor.
7475         (tui_alloc_content, tui_free_win_content)
7476         (tui_free_all_source_wins_content): Don't declare.
7477         * tui/tui-data.c (tui_initialize_static_data): Update.
7478         (init_content_element, tui_alloc_content): Remove.
7479         (~tui_gen_win_info): Update.
7480         (~tui_data_window, tui_free_all_source_wins_content)
7481         (tui_free_win_content, free_content, free_content_elements):
7482         Remove.
7483
7484 2019-06-25  Tom Tromey  <tom@tromey.com>
7485
7486         * tui/tui-winsource.h (tui_clear_source_content)
7487         (tui_erase_source_content, tui_show_source_content): Change type
7488         of win_info.
7489         * tui/tui-winsource.c (tui_clear_source_content)
7490         (tui_erase_source_content, tui_show_source_content): Change type
7491         of win_info.
7492         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7493         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7494         win_info.
7495         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7496         win_info.
7497         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7498
7499 2019-06-25  Tom Tromey  <tom@tromey.com>
7500
7501         * tui/tui-winsource.c (tui_clear_source_content)
7502         (tui_source_window_base::set_is_exec_point_at): Update.
7503         * tui/tui-source.c (tui_set_source_content_nil): Update.
7504         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7505         a bool.
7506         * tui/tui-data.c (init_content_element): Update.
7507
7508 2019-06-25  Tom Tromey  <tom@tromey.com>
7509
7510         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7511         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7512         * tui/tui-layout.c (init_and_make_win): Update.
7513         * tui/tui.h (enum tui_win_type): Update.
7514         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7515         tui_win_is_auxillary.
7516         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7517         tui_win_is_auxillary.
7518
7519 2019-06-25  Tom Tromey  <tom@tromey.com>
7520
7521         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7522         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7523         (tui_delete_data_content_windows, tui_display_all_data)
7524         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7525         Update.
7526         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7527         * tui/tui-regs.c (tui_last_regs_line_no)
7528         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7529         (tui_show_registers): Update.
7530         (tui_show_register_group): Return void.  Update.
7531         (tui_display_registers_from, tui_display_reg_element_at_line)
7532         (tui_display_registers_from_line, tui_check_register_values):
7533         Update.
7534         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7535         member.
7536         (struct tui_data_window) <regs_content>: Now a std::vector.
7537         <regs_content_count>: Remove.
7538         (tui_add_content_elements, tui_free_data_content): Don't declare.
7539         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7540         (init_content_element): Remove DATA_WIN case.  Add assert.
7541         (tui_add_content_elements): Remove.
7542         (tui_data_window): Update.
7543         (tui_free_data_content): Remove.
7544         (free_content_elements): Remove DATA_WIN case.
7545
7546 2019-06-25  Tom Tromey  <tom@tromey.com>
7547
7548         * tui/tui-data.c (tui_data_item_window): Update.
7549         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7550         * tui/tui-windata.c (tui_display_all_data)
7551         (tui_display_data_from_line): Update.
7552         (tui_check_data_values): Remove.
7553         * tui/tui-regs.c (tui_show_register_group)
7554         (tui_display_reg_element_at_line): Update.
7555         * tui/tui-hooks.c (tui_register_changed)
7556         (tui_refresh_frame_and_register_information): Call
7557         tui_check_register_values.
7558         * tui/tui-data.h (struct tui_data_window) <data_content,
7559         data_content_count, data_type>: Remove.
7560         (enum tui_data_type): Remove.
7561
7562         * tui/tui-data.c (tui_data_window::clear_detail)
7563         (~tui_data_window): Update.
7564
7565 2019-06-25  Tom Tromey  <tom@tromey.com>
7566
7567         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7568         declare.
7569         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7570         Rename from tui_first_data_item_displayed.  Update.
7571         (tui_data_window::refresh_all)
7572         (tui_data_window::do_scroll_vertical): Update.
7573         * tui/tui-data.h (struct tui_data_window)
7574         <first_data_item_displayed>: Declare new method.
7575
7576 2019-06-25  Tom Tromey  <tom@tromey.com>
7577
7578         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7579         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7580         contents...
7581         (tui_initialize_static_data): ...here.
7582
7583 2019-06-25  Tom Tromey  <tom@tromey.com>
7584
7585         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7586         (tui_display_registers_from, tui_check_register_values): Update.
7587         (tui_display_register): Remove win_info parameter; update.
7588         (tui_get_register): Change type of parameters.
7589         * tui/tui-data.h (struct tui_data_element): Remove.
7590         (union tui_which_element) <data>: Remove.
7591         <data_window>: Change type.
7592         (struct tui_data_item_window): New.
7593         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7594         case.  Add assert.
7595         (~tui_data_item_window): New destructor.
7596         (free_content_elements): Remove DATA_ITEM_WIN case.
7597
7598 2019-06-25  Tom Tromey  <tom@tromey.com>
7599
7600         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7601         Remove.
7602
7603 2019-06-25  Tom Tromey  <tom@tromey.com>
7604
7605         * tui/tui-data.h (struct tui_command_element): Remove.
7606         (union tui_which_element) <command>: Remove.
7607         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7608         assert.
7609         (free_content_elements): Remove CMD_WIN case.
7610
7611 2019-06-25  Tom Tromey  <tom@tromey.com>
7612
7613         * tui/tui-layout.c (tui_set_layout): Update.
7614         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7615         * tui/tui-data.c (layout_def): Update.
7616
7617 2019-06-25  Tom Tromey  <tom@tromey.com>
7618
7619         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7620         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7621         (tui_source_window_base::set_new_height): Update.
7622         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7623         Update.
7624         (tui_set_locator_fullname, tui_set_locator_info)
7625         (tui_show_frame_info): Update.
7626         * tui/tui-source.c (tui_set_source_content)
7627         (tui_source_is_displayed): Update.
7628         * tui/tui-layout.c (show_source_disasm_command, show_data)
7629         (show_source_or_disasm_and_command): Update.
7630         * tui/tui-disasm.c (tui_set_disassem_content)
7631         (tui_get_begin_asm_address): Update.
7632         * tui/tui-data.h (struct tui_locator_element): Remove.
7633         (union tui_which_element) <locator>: Remove.
7634         (struct tui_locator_window): New.
7635         (tui_locator_win_info_ptr): Change return type.
7636         * tui/tui-data.c (_locator): Change type.
7637         (tui_locator_win_info_ptr): Change return type.
7638         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7639         (tui_alloc_content): Add assert.
7640
7641 2019-06-25  Tom Tromey  <tom@tromey.com>
7642
7643         * tui/tui-winsource.c
7644         (tui_exec_info_window::maybe_allocate_content): New method.
7645         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7646         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7647         (make_source_or_disasm_window): Add cast.
7648         * tui/tui-data.h (union tui_which_element) <simple_string>:
7649         Remove.
7650         (struct tui_source_info): New.
7651         (struct tui_source_window_base) <execution_info>: Change type.
7652         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7653         case, and add assert.
7654         (tui_alloc_content): Add assert.
7655
7656 2019-06-25  Tom Tromey  <tom@tromey.com>
7657
7658         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7659         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7660         * tui/tui-data.c (tui_alloc_win_info): Remove.
7661
7662 2019-06-25  Tom Tromey  <tom@tromey.com>
7663
7664         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7665         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7666         can_highlight.
7667
7668 2019-06-25  Tom Tromey  <tom@tromey.com>
7669
7670         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7671         make_visible_with_new_height method.
7672         (tui_win_info::make_visible_with_new_height): New method.
7673         (tui_source_window_base::do_make_visible_with_new_height)
7674         (tui_data_window::do_make_visible_with_new_height)
7675         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7676         (make_visible_with_new_height): Remove.
7677         (tui_resize_all, tui_adjust_win_heights): Use
7678         make_visible_with_new_height method.
7679         * tui/tui-data.h (struct tui_win_info)
7680         <do_make_visible_with_new_height, make_visible_with_new_height>:
7681         New methods.
7682         (struct tui_source_window_base, struct tui_data_window)
7683         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7684         methods.
7685
7686 2019-06-25  Tom Tromey  <tom@tromey.com>
7687
7688         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7689         method.
7690         (update_tab_width): Call update_tab_width method.
7691         * tui/tui-data.h (struct tui_win_info)
7692         (struct tui_source_window_base) <update_tab_width>: New methods.
7693
7694 2019-06-25  Tom Tromey  <tom@tromey.com>
7695
7696         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7697         parameter.
7698         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7699         parameter.
7700         (tui_gen_win_info::make_visible): Update.
7701         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7702         parameter.
7703         * tui/tui-data.h (enum tui_box): New enum.
7704         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7705
7706 2019-06-25  Tom Tromey  <tom@tromey.com>
7707
7708         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7709         init_and_make_win for EXEC_INFO_WIN.
7710         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7711         longer inline.
7712         (struct tui_win_info) <~tui_win_info>: Inline.
7713         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7714         Don't declare.
7715         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7716         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7717         Remove.
7718         (tui_initialize_static_data): Update.
7719         (~tui_gen_win_info): Handle more cleanup here.
7720         (~tui_source_window_base): Delete "execution_info".
7721         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7722
7723 2019-06-25  Tom Tromey  <tom@tromey.com>
7724
7725         * tui/tui-layout.c (make_command_window): Don't set
7726         can_highlight.
7727         (show_source_disasm_command): Call the reset method.
7728         (show_data): Don't set can_highlight.  Call the reset method.
7729         (tui_gen_win_info::reset): Rename from init_gen_win_info
7730         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7731         (show_source_or_disasm_and_command): Call the reset method.
7732         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7733         (struct tui_cmd_window): Set can_highlight.
7734
7735 2019-06-25  Tom Tromey  <tom@tromey.com>
7736
7737         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7738         from make_visible.
7739         (tui_make_visible, tui_make_invisible): Rewrite.
7740         (tui_win_info::make_visible): Remove.
7741         (tui_source_window_base::make_visible): Update.
7742         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7743         method.  Moved from...
7744         (struct tui_win_info) <make_visible>: ...here.
7745
7746 2019-06-25  Tom Tromey  <tom@tromey.com>
7747
7748         * tui/tui-winsource.c
7749         (tui_source_window_base::do_scroll_horizontal): Remove direction
7750         parameter.
7751         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7752         direction parameter.
7753         * tui/tui-win.c (tui_win_info::forward_scroll)
7754         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7755         (tui_win_info::right_scroll): Update.
7756         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7757         direction parameter.
7758         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7759         direction parameter.
7760         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7761         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7762         Remove direction parameter.
7763         (struct tui_source_window_base, struct tui_source_window)
7764         (struct tui_disasm_window, struct tui_data_window)
7765         (struct tui_cmd_window): Update.
7766
7767 2019-06-25  Tom Tromey  <tom@tromey.com>
7768
7769         * tui/tui-winsource.h (tui_set_exec_info_content)
7770         (tui_show_exec_info_content, tui_erase_exec_info_content)
7771         (tui_clear_exec_info_content, tui_update_exec_info): Change
7772         argument to tui_source_window_base.
7773         * tui/tui-winsource.c (tui_set_exec_info_content)
7774         (tui_show_exec_info_content, tui_erase_exec_info_content)
7775         (tui_clear_exec_info_content, tui_update_exec_info): Change
7776         argument to tui_source_window_base.
7777
7778 2019-06-25  Tom Tromey  <tom@tromey.com>
7779
7780         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7781         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7782
7783 2019-06-25  Tom Tromey  <tom@tromey.com>
7784
7785         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7786         check.
7787
7788 2019-06-25  Tom Tromey  <tom@tromey.com>
7789
7790         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7791         type to void.
7792         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7793         type to void.
7794         * tui/tui-source.c (tui_set_source_content): Update.
7795         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7796
7797 2019-06-25  Tom Tromey  <tom@tromey.com>
7798
7799         * tui/tui-win.c (window_name_completer, tui_set_focus)
7800         (tui_all_windows_info): Use name method.
7801         * tui/tui-data.h (struct tui_gen_win_info)
7802         (struct tui_source_window, struct tui_disasm_window)
7803         (struct tui_data_window, struct tui_cmd_window) <name>: New
7804         method.
7805         (tui_win_name): Don't declare.
7806         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7807         (tui_win_name): Remove.
7808
7809 2019-06-25  Tom Tromey  <tom@tromey.com>
7810
7811         * tui/tui-winsource.h (tui_update_source_window)
7812         (tui_update_source_window_as_is): Change parameter type.
7813         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7814         to be a tui_source_window_base.
7815         (tui_update_source_window_as_is): Likewise.
7816         * tui/tui-win.c (make_visible_with_new_height): Update.
7817
7818 2019-06-25  Tom Tromey  <tom@tromey.com>
7819
7820         * tui/tui-winsource.c (tui_erase_source_content)
7821         (tui_show_source_content, tui_show_exec_info_content)
7822         (tui_erase_exec_info_content): Use refresh_window method.
7823         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7824         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7825         from tui_refresh_win.
7826         (tui_data_window::refresh_window): New method.
7827         (tui_win_info::refresh, tui_source_window_base::refresh)
7828         (tui_refresh_all): Use refresh_window method.
7829         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7830         method.
7831         * tui/tui-regs.c (tui_display_register): Call refresh_window
7832         method.
7833         * tui/tui-layout.c (show_source_disasm_command)
7834         (show_source_or_disasm_and_command): Call refresh_window method.
7835         * tui/tui-data.h (struct tui_gen_win_info)
7836         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7837         New method.
7838
7839 2019-06-25  Tom Tromey  <tom@tromey.com>
7840
7841         * tui/tui.c (tui_rl_other_window, tui_enable)
7842         (tui_is_window_visible, tui_get_command_dimension): Update.
7843         * tui/tui-winsource.c (tui_update_source_window_as_is)
7844         (tui_clear_source_content, tui_erase_source_content)
7845         (tui_show_source_line, tui_source_window_base::refill)
7846         (tui_source_window_base::do_scroll_horizontal)
7847         (tui_source_window_base::set_is_exec_point_at)
7848         (tui_update_breakpoint_info, tui_set_exec_info_content)
7849         (tui_alloc_source_buffer, tui_line_is_displayed)
7850         (tui_addr_is_displayed): Update.
7851         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7852         (tui_check_and_display_highlight_if_needed)
7853         (tui_win_info::make_visible, tui_win_info::refresh)
7854         (tui_refresh_all): Update.
7855         * tui/tui-windata.c (tui_first_data_item_displayed)
7856         (tui_delete_data_content_windows, tui_erase_data_content)
7857         (tui_display_all_data, tui_data_window::refresh_all)
7858         (tui_check_data_values): Update.
7859         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7860         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7861         (tui_win_info::backward_scroll, tui_refresh_all_win)
7862         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7863         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7864         (tui_source_window_base::set_new_height)
7865         (tui_data_window::set_new_height)
7866         (make_invisible_and_set_new_height)
7867         (make_visible_with_new_height, new_height_ok)
7868         (parse_scrolling_args): Update.
7869         * tui/tui-stack.c (tui_show_frame_info): Update.
7870         * tui/tui-source.c (tui_set_source_content)
7871         (tui_set_source_content_nil, tui_source_is_displayed)
7872         (tui_source_window::do_scroll_vertical): Update.
7873         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7874         (tui_display_registers_from, tui_display_reg_element_at_line)
7875         (tui_check_register_values, tui_reg_command): Update.
7876         * tui/tui-layout.c (tui_default_win_height)
7877         (show_source_disasm_command, show_data, init_and_make_win)
7878         (show_source_or_disasm_and_command): Update.
7879         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7880         (tui_redisplay_readline, tui_mld_flush)
7881         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7882         (tui_getc): Update.
7883         * tui/tui-disasm.c (tui_set_disassem_content)
7884         (tui_disasm_window::do_scroll_vertical): Update.
7885         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7886         Now virtual.
7887         (struct tui_win_info): Derive from tui_gen_win_info.
7888         <~tui_win_info>: Mark as override.
7889         <generic>: Remove member.
7890         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7891         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7892         (~tui_data_window, ~tui_win_info)
7893         (tui_free_all_source_wins_content): Update.
7894         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7895
7896 2019-06-25  Tom Tromey  <tom@tromey.com>
7897
7898         * tui/tui-layout.c (init_and_make_win): Use new.
7899         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7900         destructor, initializers.
7901         (tui_alloc_generic_win_info): Don't declare.
7902         * tui/tui-data.c (_locator): Add argument to constructor.
7903         (source_win, disasm_win): New globals.
7904         (exec_info): Remove.
7905         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7906         Update.
7907         (tui_alloc_generic_win_info): Remove.
7908         (init_content_element): Use new.
7909         (tui_win_info::tui_win_info): Update.
7910         (free_content_elements) <case DATA_WIN>: Use delete.
7911
7912 2019-06-25  Tom Tromey  <tom@tromey.com>
7913
7914         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7915         * tui/tui-windata.c (tui_first_data_item_displayed)
7916         (tui_delete_data_content_windows): Update.
7917         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7918         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7919         (tui_display_registers_from, tui_check_register_values): Update.
7920         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7921         pointer.
7922         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7923         window.
7924         (tui_free_data_content): Update.
7925         (free_content_elements) <case DATA_WIN>: Free the window.
7926
7927 2019-06-25  Tom Tromey  <tom@tromey.com>
7928
7929         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7930         Update.
7931         * tui/tui-layout.c (make_command_window)
7932         (show_source_disasm_command, show_data, init_and_make_win)
7933         (show_source_or_disasm_and_command): Update.
7934         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7935         method.
7936         <can_highight, is_highlighted>: Now bool.
7937         (tui_set_win_highlight): Don't declare.
7938         * tui/tui-data.c (tui_set_win_highlight): Remove.
7939
7940 2019-06-25  Tom Tromey  <tom@tromey.com>
7941
7942         * tui/tui-wingeneral.c (make_visible): Remove check of window
7943         type.
7944
7945 2019-06-25  Tom Tromey  <tom@tromey.com>
7946
7947         * tui/tui-win.c (tui_win_info::max_height)
7948         (tui_cmd_window::max_height): New methods.
7949         (new_height_ok): Call max_height.
7950         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7951         <max_height>: New method.
7952
7953 2019-06-25  Tom Tromey  <tom@tromey.com>
7954
7955         * tui/tui-win.c (tui_source_window_base::set_new_height)
7956         (tui_data_window::set_new_height): New methods.
7957         (make_invisible_and_set_new_height): Call set_new_height method.
7958         * tui/tui-data.h (struct tui_win_info)
7959         (struct tui_source_window_base, struct tui_data_window)
7960         <set_new_height>: New method.
7961
7962 2019-06-25  Tom Tromey  <tom@tromey.com>
7963
7964         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7965         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7966         tui_refresh_data_win.
7967         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7968         method.
7969         (tui_refresh_all_win): Call the refresh_all method.
7970         (tui_set_focus): Likewise.
7971         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7972         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7973         Likewise.
7974
7975 2019-06-25  Tom Tromey  <tom@tromey.com>
7976
7977         * tui/tui-winsource.h (tui_refill_source_window)
7978         (tui_set_is_exec_point_at): Don't declare.
7979         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7980         (tui_source_window_base::refill): Rename from
7981         tui_refill_source_window.
7982         (tui_source_window_base::do_scroll_horizontal): Update.
7983         (tui_source_window_base::set_is_exec_point_at): Rename from
7984         tui_set_is_exec_point_at.
7985         (tui_update_all_breakpoint_info): Update.
7986         * tui/tui-stack.c (tui_show_frame_info): Update.
7987         * tui/tui-layout.c (show_data): Add cast.
7988         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7989         * tui/tui-data.h (struct tui_source_window_base) <refill,
7990         set_is_exec_point_at>: New methods.
7991         (tui_source_windows, tui_add_to_source_windows): Update types.
7992         (tui_add_to_source_windows): Remove redundant declaration.
7993         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7994         (tui_source_windows): Change return type.
7995         (tui_clear_source_windows_detail): Update.
7996         (tui_add_to_source_windows): Change type of parameter.
7997         (tui_free_all_source_wins_content): Update.
7998
7999 2019-06-25  Tom Tromey  <tom@tromey.com>
8000
8001         * tui/tui-wingeneral.c (tui_win_info::refresh)
8002         (tui_source_window_base::refresh): New methods.
8003         (tui_refresh_all): Call the refresh method.
8004         * tui/tui-data.h (struct tui_win_info)
8005         (struct tui_source_window_base) <refresh>: New method.
8006
8007 2019-06-25  Tom Tromey  <tom@tromey.com>
8008
8009         * tui/tui.h (tui_is_window_visible): Return bool.
8010         * tui/tui.c (tui_is_window_visible): Return bool.
8011         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8012         (tui_make_visible, tui_make_invisible)
8013         (tui_win_info::make_visible)
8014         (tui_source_window_base::make_visible, make_all_visible)
8015         (tui_make_all_visible, tui_make_all_invisible): Update.
8016         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8017         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8018         bool.
8019         (struct tui_win_info, struct tui_source_window_base)
8020         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8021         * tui/tui-data.c (tui_init_generic_part): Update.
8022
8023 2019-06-25  Tom Tromey  <tom@tromey.com>
8024
8025         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8026         (tui_source_window_base::make_visible): New methods.
8027         (make_all_visible): Make method call.
8028         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8029         (struct tui_source_window_base, struct tui_cmd_window): Override
8030         make_visible.
8031         (tui_win_is_source_type): Don't declare.
8032         * tui/tui-data.c (tui_win_is_source_type): Remove.
8033
8034 2019-06-25  Tom Tromey  <tom@tromey.com>
8035
8036         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8037         NULL check.
8038
8039 2019-06-25  Tom Tromey  <tom@tromey.com>
8040
8041         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8042         Inline constructor.  Add initializers for members.
8043         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8044         constructors; now inline in class.
8045
8046 2019-06-25  Tom Tromey  <tom@tromey.com>
8047
8048         * tui/tui-regs.c (tui_show_registers): Update.
8049         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8050         bool.
8051         * tui/tui-data.c (tui_data_window::clear_detail)
8052         (tui_data_window): Update.
8053
8054 2019-06-25  Tom Tromey  <tom@tromey.com>
8055
8056         * tui/tui-windata.c (tui_display_all_data)
8057         (tui_display_data_from_line, tui_display_data_from)
8058         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8059         Update.
8060         * tui/tui-regs.c (tui_last_regs_line_no)
8061         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8062         (tui_show_registers, tui_show_register_group)
8063         (tui_display_registers_from, tui_display_reg_element_at_line)
8064         (tui_display_registers_from_line, tui_check_register_values)
8065         (tui_reg_next, tui_reg_prev): Update.
8066         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8067         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8068         tui_data_window.
8069         (struct tui_win_info) <detail>: Remove.  Add new fields from
8070         tui_data_info.
8071         (TUI_DATA_WIN): Add cast.
8072         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8073         (~tui_data_window): Simplify.
8074
8075 2019-06-25  Tom Tromey  <tom@tromey.com>
8076
8077         * tui/tui-layout.c (show_source_disasm_command)
8078         (show_source_or_disasm_and_command): Update.
8079         * tui/tui-io.c (update_cmdwin_start_line)
8080         (tui_redisplay_readline): Update.
8081         * tui/tui-data.h (struct tui_command_info): Remove.
8082         (struct tui_win_info) <detail>: Remove command_info member.
8083         (struct tui_data_window) <start_line>: New member, from
8084         tui_command_info.
8085         (TUI_CMD_WIN): Add casts.
8086
8087 2019-06-25  Tom Tromey  <tom@tromey.com>
8088
8089         * tui/tui-winsource.c (tui_update_source_window)
8090         (tui_refill_source_window)
8091         (tui_source_window_base::do_scroll_horizontal)
8092         (tui_update_breakpoint_info, tui_set_exec_info_content)
8093         (tui_show_exec_info_content, tui_erase_exec_info_content)
8094         (tui_clear_exec_info_content): Update.
8095         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8096         Update.
8097         * tui/tui-win.c (make_invisible_and_set_new_height)
8098         (make_visible_with_new_height): Update.
8099         * tui/tui-source.c (tui_set_source_content)
8100         (tui_show_symtab_source): Update.
8101         * tui/tui-layout.c (extract_display_start_addr)
8102         (show_source_disasm_command, show_data)
8103         (make_source_or_disasm_window)
8104         (show_source_or_disasm_and_command): Update.
8105         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8106         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8107         "gdbarch".
8108         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8109         to tui_source_window_base.
8110         (struct tui_win_info) <detail>: Remove source_info member.
8111         (struct tui_source_window_base) <has_locator>: Inline.
8112         Move contents from tui_source_info; rename has_locator member to
8113         m_has_locator.
8114         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8115         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8116         header file.
8117         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8118         Simplify.
8119         (tui_free_all_source_wins_content): Cast to
8120         tui_source_window_base.
8121
8122 2019-06-25  Tom Tromey  <tom@tromey.com>
8123
8124         * tui/tui-win.c (make_invisible_and_set_new_height)
8125         (make_visible_with_new_height): Call has_locator method.
8126         * tui/tui-layout.c (show_source_disasm_command, show_data)
8127         (show_source_or_disasm_and_command): Update for bool change.
8128         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8129         (tui_win_info) <has_locator>: New method.
8130         (struct tui_source_window_base) <has_locator>: New method.
8131         (tui_win_has_locator): Don't declare.
8132         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8133         from tui_win_has_locator.
8134         (tui_source_window_base): Use false, not FALSE.
8135
8136 2019-06-25  Tom Tromey  <tom@tromey.com>
8137
8138         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8139         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8140         clear_detail method directly.
8141         (tui_clear_win_detail): Remove.
8142
8143 2019-06-25  Tom Tromey  <tom@tromey.com>
8144
8145         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8146         "this", not TUI_DISASM_WIN.
8147
8148 2019-06-25  Tom Tromey  <tom@tromey.com>
8149
8150         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8151         declare.
8152         * tui/tui-winsource.c
8153         (tui_source_window_base::do_scroll_horizontal): Rename from
8154         tui_horizontal_source_scroll.
8155         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8156         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8157         from tui_vertical_data_scroll.
8158         * tui/tui-win.h (tui_scroll): Don't declare.
8159         * tui/tui-win.c (tui_win_info::forward_scroll)
8160         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8161         (tui_win_info::right_scroll): Rename and update.
8162         (tui_scroll_forward_command, tui_scroll_backward_command)
8163         (tui_scroll_left_command, tui_scroll_right_command): Update.
8164         (tui_scroll): Remove.
8165         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8166         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8167         from tui_vertical_source_scroll.
8168         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8169         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8170         from tui_vertical_disassem_scroll.
8171         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8172         do_scroll_horizontal>: New methods.
8173         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8174         Likewise.
8175         (struct tui_source_window_base): Add do_scroll_horizontal.
8176         (struct tui_source_window, struct tui_disasm_window): Add
8177         do_scroll_vertical.
8178         (struct tui_data_window, struct tui_cmd_window): Add
8179         do_scroll_horizontal and do_scroll_vertical.
8180         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8181
8182 2019-06-25  Tom Tromey  <tom@tromey.com>
8183
8184         * tui/tui-data.h (struct tui_source_window_base): New struct.
8185         (struct tui_source_window): Derive from tui_source_window_base.
8186         (struct tui_disasm_window): New struct.
8187         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8188         from tui_source_window::clear_detail.
8189         (tui_source_window_base): Rename from tui_source_window.
8190         (~tui_source_window_base): Rename from ~tui_source_window.
8191         (tui_alloc_win_info): Create a tui_disasm_window.
8192
8193 2019-06-25  Tom Tromey  <tom@tromey.com>
8194
8195         * tui/tui-data.h (struct tui_source_window)
8196         (struct tui_data_window): Declare destructors.
8197         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8198         destructors.
8199         (tui_win_info): Simplify.
8200
8201 2019-06-25  Tom Tromey  <tom@tromey.com>
8202
8203         * tui/tui-winsource.c (tui_display_main)
8204         (tui_update_source_windows_with_addr)
8205         (tui_update_all_breakpoint_info): Update.
8206         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8207         (new_height_ok, parse_scrolling_args): Update.
8208         * tui/tui-stack.c (tui_show_frame_info): Update.
8209         * tui/tui-data.h (struct tui_list): Remove.
8210         (tui_source_windows): Return a reference to a std::vector.
8211         * tui/tui-data.c (source_windows): Now a std::vector.
8212         (tui_source_windows): Change return type.
8213         (tui_clear_source_windows): Rewrite.
8214         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8215         (tui_free_all_source_wins_content): Rewrite.
8216
8217 2019-06-25  Tom Tromey  <tom@tromey.com>
8218
8219         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8220         (struct tui_data_window, struct tui_cmd_window): Declare
8221         clear_detail method.
8222         * tui/tui-data.c (tui_source_window::clear_detail)
8223         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8224         methods.
8225         (tui_clear_win_detail): Simplify.
8226
8227 2019-06-25  Tom Tromey  <tom@tromey.com>
8228
8229         * tui/tui-layout.c (make_source_window, make_disasm_window)
8230         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8231         Return the new window.
8232         (show_source_disasm_command, show_data)
8233         (show_source_or_disasm_and_command): Update.
8234
8235 2019-06-25  Tom Tromey  <tom@tromey.com>
8236
8237         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8238         parameter.  Return the new window.
8239         (show_source_disasm_command): Update and remove NULL check.
8240         (show_source_or_disasm_and_command): Update.
8241
8242 2019-06-25  Tom Tromey  <tom@tromey.com>
8243
8244         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8245
8246 2019-06-25  Tom Tromey  <tom@tromey.com>
8247
8248         * tui/tui-data.h (struct tui_win_info): Make constructor
8249         protected.  Make destructor virtual.  Add initializers.
8250         (tui_source_window, tui_data_window, tui_cmd_window): New
8251         classes.
8252         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8253         constructor.  Add "type" parameter.
8254         (tui_source_window, tui_data_window, tui_cmd_window): New
8255         constructors.
8256         (tui_alloc_win_info): Instantiate the appropriate subclass.
8257
8258 2019-06-25  Tom Tromey  <tom@tromey.com>
8259
8260         * tui/tui-win.c (tui_resize_all): Use delete.
8261         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8262         destructor.
8263         (tui_free_window): Don't declare.
8264         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8265         Update.
8266
8267 2019-06-25  Tom Tromey  <tom@tromey.com>
8268
8269         * tui/tui-data.h (struct tui_win_info): Add constructor.
8270         * tui/tui-data.c (tui_alloc_win_info): Use new.
8271         (tui_free_window): Use delete.
8272
8273 2019-06-22  Tom Tromey  <tom@tromey.com>
8274
8275         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8276         declare.
8277         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8278
8279 2019-06-22  Tom Tromey  <tom@tromey.com>
8280
8281         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8282         declare.
8283         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8284
8285 2019-06-22  Tom de Vries  <tdevries@suse.de>
8286
8287         * dwarf2read.c (create_addrmap_from_aranges)
8288         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8289         instead of '%zu'.
8290
8291 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8292
8293         * dwarf2read.h (dwarf2_section_info_def): Remove.
8294         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8295         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8296         std::vector<dwarf2_section_info>.
8297         (struct dwo_file) <~dwo_file>: Remove.
8298         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8299         types field.
8300         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8301         (dwarf2_read_debug_names): Likewise.
8302         (create_debug_types_hash_table): Change parameter type to
8303         array_view, adjust code accordingly.
8304         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8305         (partial_die_info::fixup): Likewise.
8306         (determine_prefix): Likewise.
8307         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8308
8309 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8310
8311         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8312         gdb_bfd_ref_ptr.
8313         <~dwo_file>: Remove call to gdb_bfd_unref.
8314         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8315         gdb_bfd_ref_ptr::get.
8316
8317 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8318
8319         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8320         type to htab_up.
8321         * dwarf2read.c (struct dwo_file): Initialize fields.
8322         <~dwo_file>: New.
8323         (free_dwo_file): Remove, move content to ~dwo_file.
8324         (struct dwo_file_deleter): Remove.
8325         (dwo_file_up>: Remove custom deleter.
8326         (free_dwo_files): Remove.
8327         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8328         dwo_files.
8329         (process_skeletonless_type_units): Call unique_ptr::get.
8330         (allocate_dwo_file_hash_table): Add deleter to created hash
8331         table.  Change return type to htab_up.
8332         (lookup_dwo_file_slot): Don't memset dwo_file, call
8333         unique_ptr::get.
8334         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8335         (create_dwo_unit_in_dwp_v2): Likewise.
8336         (open_and_init_dwo_file): Likewise.
8337         (free_dwo_file_from_slot): Remove.
8338
8339 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8340
8341         * dwarf2read.h (struct dwarf2_section_info) <readin,
8342         is_virtual>: Change type to bool.
8343         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8344         true instead of 1.
8345
8346 2019-06-19  Tom Tromey  <tom@tromey.com>
8347
8348         * tui/tui-data.h (tui_init_content_element): Don't declare.
8349
8350 2019-06-19  Tom Tromey  <tom@tromey.com>
8351
8352         * tui/tui-data.h (tui_init_win_info): Don't declare.
8353
8354 2019-06-19  Tom de Vries  <tdevries@suse.de>
8355
8356         * dwarf2read.h (abstract_to_concrete): Change type to
8357         std::unordered_map<sect_offset, std::vector<sect_offset>,
8358         gdb::hash_enum<sect_offset>>.
8359
8360 2019-06-19  Tom Tromey  <tromey@adacore.com>
8361
8362         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8363         EVAL_AVOID_SIDE_EFFECTS specially.
8364
8365 2019-06-19  Tom Tromey  <tromey@adacore.com>
8366
8367         * source-cache.c (highlighter): New global.
8368         (source_cache::get_source_lines): Create a highlighter on demand.
8369
8370 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8371
8372         * defs.h (deprecated_interactive_hook): Delete declaration.
8373         * interps.c (clear_interpreter_hooks): Remove use of
8374         deprecated_interactive_hook.
8375         * top.c (deprecated_interactive_hook): Delete definition.
8376         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8377
8378 2019-06-18  Tom de Vries  <tdevries@suse.de>
8379
8380         PR gdb/24515
8381         * dwarf2read.h (abstract_to_concrete): Change type from
8382         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8383         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8384         * dwarf2read.c (read_variable): Update.
8385         (dwarf2_fetch_die_loc_sect_off): Update.
8386
8387 2019-06-17  Tom de Vries  <tdevries@suse.de>
8388
8389         PR gdb/24617
8390         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8391         accessing parent[parent_len - 1].
8392
8393 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8394
8395         PR gdb/24364
8396         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8397         call dtrace_process_dof with NULL dof.
8398
8399 2019-06-16  Tom de Vries  <tdevries@suse.de>
8400
8401         PR gdb/24445
8402         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8403
8404 2019-06-16  Tom Tromey  <tom@tromey.com>
8405
8406         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8407         (make_all_visible): Use address of member.
8408
8409 2019-06-16  Tom Tromey  <tom@tromey.com>
8410
8411         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8412         (tui_free_window, free_content, free_content_elements): Remove
8413         unnecessary cast.
8414         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8415         cast.
8416         * tui/tui-regs.c (tui_show_register_group)
8417         (tui_display_registers_from, tui_display_reg_element_at_line):
8418         Remove unnecessary cast.
8419
8420 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8421
8422         * linux-nat.c (normal_mask): Delete.
8423         (_initialize_linux_nat): Don't initialise normal_mask.
8424
8425 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8426
8427         PR gdb/24445
8428         * dwarf-index-write.h (write_psymtabs_to_index): Add
8429         dwz_basename parameter.
8430         * dwarf-index-write.c (write_gdbindex): Move file writing to
8431         write_gdbindex_1.  Change return type void.
8432         (assert_file_size): Move up, remove filename parameter.
8433         (write_gdbindex_1): New function.
8434         (write_debug_names): Change return type to void, call
8435         assert_file_size.
8436         (struct index_wip_file): New struct.
8437         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8438         file logic to index_wip_file.  Write index for dwz file if
8439         needed.
8440         (save_gdb_index_command): Pass basename of dwz file, if present.
8441         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8442         build-id of dwz file, if present.
8443         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8444         (dwarf2_get_dwz_file): Likewise.
8445         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8446         (dwarf2_get_dwz_file): Likewise.
8447
8448 2019-06-16  Tom Tromey  <tom@tromey.com>
8449
8450         * coffread.c (process_coff_symbol): Use xstrdup.
8451         * value.c (create_internalvar): Use xstrdup.
8452
8453 2019-06-16  Tom Tromey  <tom@tromey.com>
8454
8455         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8456         * breakpoint.c (stopin_command, stopat_command)
8457         (until_break_command, decode_location_default): Remove unnecessary
8458         cast.
8459         * utils.c (subset_compare): Remove unnecessary cast.
8460         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8461         cast.
8462         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8463         cast.
8464         * infcmd.c (path_command): Remove unnecessary cast.
8465         * coffread.c (decode_type): Remove unnecessary cast.
8466         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8467         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8468         * tui/tui-stack.c (tui_show_locator_content)
8469         (tui_show_frame_info): Remove unnecessary cast.
8470         * tui/tui-win.c (tui_scroll_forward_command)
8471         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8472         (parse_scrolling_args): Remove unnecessary cast.
8473         * tui/tui-data.c (init_win_info, tui_del_window)
8474         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8475         (free_content_elements): Remove unnecessary cast.
8476         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8477         unnecessary cast.
8478         * tui/tui-source.c (tui_set_source_content)
8479         (tui_vertical_source_scroll): Remove unnecessary cast.
8480         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8481         cast.
8482         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8483         * tui/tui-regs.c (tui_display_registers_from)
8484         (tui_display_register): Remove unnecessary cast.
8485         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8486         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8487         (make_visible): Remove unnecessary cast.
8488         * tui/tui-winsource.c (tui_erase_source_content)
8489         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8490         unnecessary cast.
8491         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8492         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8493         * stabsread.c (read_type, read_array_type, read_range_type):
8494         Remove unnecessary cast.
8495         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8496         (parse_symbol, parse_type, upgrade_type, parse_external)
8497         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8498         unnecessary cast.
8499         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8500
8501 2019-06-16  Tom Tromey  <tom@tromey.com>
8502
8503         * tui/tui-data.c (tui_alloc_generic_win_info)
8504         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8505         checks.
8506
8507 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8508             Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * f-typeprint.c (f_print_type): Don't return early for not
8511         associated or not allocated types.
8512         (f_type_print_varspec_suffix): Add print_rank parameter and print
8513         ranks of array types in case they dangling.
8514         (f_type_print_base): Add print_rank parameter.
8515
8516 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8517
8518         * NEWS: Mention new MI commands.
8519         * break-catch-throw.c (enum exception_event_kind): Move to
8520         breakpoint.h.
8521         (print_mention_exception_catchpoint): Output text as a single
8522         message.
8523         (catch_exception_command_1): Rename to...
8524         (catch_exception_event): ...this, make non-static, update header
8525         command, and change some parameter types.
8526         (catch_catch_command): Update for changes to
8527         catch_exception_command_1.
8528         (catch_throw_command): Likewise.
8529         (catch_rethrow_command): Likewise.
8530         * breakpoint.c (enum exception_event_kind): Delete.
8531         * breakpoint.h (enum exception_event_kind): Moved here from
8532         break-catch-throw.c.
8533         (catch_exception_event): Declare.
8534         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8535         (mi_cmd_catch_throw): New function.
8536         (mi_cmd_catch_rethrow): New function.
8537         (mi_cmd_catch_catch): New function.
8538         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8539         'catch-catch' entries.
8540         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8541         (mi_cmd_catch_rethrow): Declare.
8542         (mi_cmd_catch_catch): Declare.
8543
8544 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8545
8546         * annotate.c (annotate_source_line): Change return type to void,
8547         update implementation to match.
8548         * annotate.h (annotate_source_line): Change return type to void,
8549         update header comment.
8550         * stack.c (print_frame_info): Don't change what frame information
8551         is printed based on whether annotations are on or not.
8552
8553 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8554
8555         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8556         (annotate_source): Make static.
8557         (annotate_source_line): Moved from source.c and renamed from
8558         identify_source_line.  Update the return type.
8559         * annotate.h (annotate_source): Delete declaration.
8560         (annotate_source_line): Declaration moved from source.h, and
8561         renamed from identify_source_line.  Return type updated.
8562         * source.c (identify_source_line): Moved to annotate.c and renamed
8563         to annotate_source_line.
8564         (info_line_command): Remove check of annotation_level.
8565         * source.h (identify_source_line): Move declaration to annotate.h
8566         and rename to annotate_source_line.
8567         * stack.c: Add 'annotate.h' include.
8568         (print_frame_info): Remove check of annotation_level before
8569         calling annotate_source_line.
8570
8571 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8572
8573         * source-cache.c (source_cache::get_plain_source_lines): Use
8574         open_source_file_with_line_charpos instead of just
8575         open_source_file, remove call to find_source_lines.
8576         (source_cache::get_source_lines): Likewise.
8577         * source.c (find_source_lines): Make static.
8578         (get_filename_and_charpos): Renamed into...
8579         (open_source_file_with_line_charpos): ..this along with changes to
8580         return a scoped_fd, and some other minor clean ups.
8581         (identify_source_line): Use open_source_file_with_line_charpos.
8582         (search_command_helper): Use open_source_file_with_line_charpos
8583         instead of just open_source_file, remove call to
8584         find_source_lines.
8585         * source.h (open_source_file_with_line_charpos): Declare new
8586         function.
8587         (find_source_lines): Delete declaration.
8588
8589 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8590
8591         * source.c (get_filename_and_charpos): Remove fullname
8592         parameter.
8593         (identify_source_line): Update call to get_filename_and_charpos.
8594
8595 2019-06-14  Tom Tromey  <tromey@adacore.com>
8596
8597         PR gdb/24502:
8598         * ui-style.h (skip_ansi_escape): Update comment.
8599         * ui-file.h (class no_terminal_escape_file): New class.
8600         * ui-file.c (no_terminal_escape_file::write)
8601         (no_terminal_escape_file::puts): New methods.
8602         * cli/cli-logging.c (handle_redirections): Use
8603         no_terminal_escape_file.
8604
8605 2019-06-14  Tom Tromey  <tromey@adacore.com>
8606
8607         * NEWS: Move convenience variable news above Python news.
8608
8609 2019-06-14  Tom Tromey  <tom@tromey.com>
8610
8611         * gnulib: Move directory to top-level.
8612         * configure.ac: Don't configure gnulib.
8613         * configure: Rebuild.
8614         * common/common-defs.h: Use new path to gnulib.
8615         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8616         (GNULIB_H): Remove.
8617         (INCGNU): Look in new gnulib location.
8618         (HFILES_NO_SRCDIR): Remove gnulib files.
8619         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8620         (generated_files): Remove GNULIB_H.
8621         ($(LIBGNU), all-lib): Remove targets.
8622         (distclean): Don't mention GNULIB_BUILDDIR.
8623         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8624
8625 2019-06-14  Tom Tromey  <tromey@adacore.com>
8626
8627         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8628         Warn if symbol file does not provide any symbols.
8629
8630 2019-06-14  Tom Tromey  <tromey@adacore.com>
8631
8632         * source.c (find_and_open_source): Respect basenames_may_differ.
8633
8634 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8635
8636         * annotate.c (annotate_breakpoints_invalid): Make use of
8637         scoped_restore_terminal_state.
8638         (annotate_frames_invalid): Likewise.
8639
8640 2019-06-14  Tom Tromey  <tromey@adacore.com>
8641
8642         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8643         allow assignment to an internalvar.
8644
8645 2019-06-14  Tom Tromey  <tromey@adacore.com>
8646
8647         * ada-lex.l: Allow "_" in attribute names.
8648
8649 2019-06-14  Tom Tromey  <tromey@adacore.com>
8650
8651         PR gdb/24653:
8652         * regcache.c (registers_changed): Don't call alloca.
8653         * top.c (execute_command): Don't call alloca.
8654
8655 2019-06-13  Pedro Alves  <palves@redhat.com>
8656
8657         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8658         'expression'.  When parsing an expression, error out if there's
8659         junk after "unlimited".
8660         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8661         (do_set_command): Adjust calls to is_unlimited_literal.
8662
8663 2019-06-13  Pedro Alves  <palves@redhat.com>
8664
8665         * compile/compile.c (make_compile_options_def_group): Add braces
8666         around array_view initializer.
8667         * thread.c (make_thread_apply_all_options_def_group)
8668         (make_thread_apply_all_options_def_group): Likewise.
8669
8670 2019-06-13  Pedro Alves  <palves@redhat.com>
8671
8672         * NEWS (New commands): Mention "maint test-options
8673         require-delimiter", "maint test-options unknown-is-error", "maint
8674         test-options unknown-is-operand" and "maint show
8675         test-options-completion-result".
8676         (New command options, command completion): New section.
8677         (Completion improvements): New section.
8678         Mention that you can abbreviate "unlimited".
8679
8680 2019-06-13  Pedro Alves  <palves@redhat.com>
8681
8682         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8683         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8684         * unittests/cli-utils-selftests.c (test_parse_flags)
8685         (test_parse_flags_qcs): Delete.
8686         (test_cli_utils): Don't call deleted functions.
8687
8688 2019-06-13  Pedro Alves  <palves@redhat.com>
8689
8690         * thread.c: Include "cli/cli-option.h".
8691         (tp_array_compar_ascending): Global.
8692         (tp_array_compar): Delete function.
8693         (tp_array_compar_ascending, tp_array_compar_descending): New
8694         functions.
8695         (ascending_option_def, qcs_flag_option_def)
8696         (thr_qcs_flags_option_defs)
8697         (make_thread_apply_all_options_def_group)
8698         (make_thread_apply_options_def_group): New.
8699         (thread_apply_all_command): Use gdb::option::process_options.
8700         (thread_apply_command_completer)
8701         (thread_apply_all_command_completer): New.
8702         (thread_apply_command): Use gdb::option::process_options.
8703         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8704         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8705         to generate help text of "thread apply".  Adjust "taas"'s help.
8706         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8707         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8708
8709 2019-06-13  Pedro Alves  <palves@redhat.com>
8710
8711         * thread.c (thread_apply_command): Check for invalid TID with
8712         isdigit instead of !isalpha.
8713
8714 2019-06-13  Pedro Alves  <palves@redhat.com>
8715
8716         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8717         (validate_flags_qcs): New.
8718         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8719         (validate_flags_qcs): Declare.
8720         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8721         (make_frame_apply_options_def_group): New.
8722         (frame_apply_command_count): Process options with
8723         gdb::option::process_options.
8724         (frame_apply_completer): New.
8725         (frame_apply_level_completer, frame_apply_all_completer)
8726         (frame_apply_completer): New.
8727         (_initialize_stack): Update help of "frame apply", "frame apply
8728         level", "frame apply all" and "faas" to mention supported options
8729         and install command completers.
8730         * stack.h (frame_apply_all_completer): Declare.
8731         * thread.c: Include "stack.h".
8732         (tfaas_command): Add "--".
8733         (_initialize_thread): Update help "tfaas" to mention supported
8734         options and install command completer.
8735
8736 2019-06-13  Pedro Alves  <palves@redhat.com>
8737
8738         * completer.c (complete_nested_command_line): New.
8739         (gdb_completion_word_break_characters_throw): Add assertion.
8740         * completer.h (complete_nested_command_line): Declare.
8741
8742 2019-06-13  Pedro Alves  <palves@redhat.com>
8743
8744         * stack.c (parse_backtrace_qualifiers): New.
8745         (backtrace_command): Use it.
8746         (backtrace_command_completer): Complete on qualifiers.
8747
8748 2019-06-13  Pedro Alves  <palves@redhat.com>
8749
8750         * frame.c: Include "cli/cli-option.h.
8751         (user_set_backtrace_options): New.
8752         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8753         Delete.
8754         (get_prev_frame): Adjust.
8755         (boolean_option_def, uinteger_option_def)
8756         (set_backtrace_option_defs): New.
8757         (_initialize_frame): Adjust and use
8758         gdb::option::add_setshow_cmds_for_options to install "set
8759         backtrace past-main" and "set backtrace past-entry".
8760         * frame.h: Include "cli/cli-option.h".
8761         (struct frame_print_options): Forward declare.
8762         (print_frame_arguments_all, print_frame_arguments_scalars)
8763         (print_frame_arguments_none): Declare.
8764         (print_entry_values): Delete declaration.
8765         (struct frame_print_options, user_frame_print_options): New.
8766         (struct set_backtrace_options): New.
8767         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8768         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8769         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8770         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8771         (list_args_or_locals): Add frame_print_options parameter.
8772         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8773         * python/py-framefilter.c (enumerate_args): Pass down
8774         USER_FRAME_PRINT_OPTIONS.
8775         * stack.c: Include "cli/cli-option.h".
8776         (print_frame_arguments_all, print_frame_arguments_scalars)
8777         (print_frame_arguments_none): Declare.
8778         (print_raw_frame_arguments, print_entry_values): Delete.
8779         (user_frame_print_options): New.
8780         (boolean_option_def, enum_option_def, frame_print_option_defs):
8781         New.
8782         (struct backtrace_cmd_options): New.
8783         (bt_flag_option_def): New.
8784         (backtrace_command_option_defs): New.
8785         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8786         (print_frame_arg, read_frame_arg, print_frame_args)
8787         (print_frame_info, print_frame): Add frame_print_options parameter
8788         and use it.
8789         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8790         (backtrace_command_1): Add frame_print_options and
8791         backtrace_cmd_options parameters and use them.
8792         (make_backtrace_options_def_group): New.
8793         (backtrace_command): Process command options with
8794         gdb::option::process_options.
8795         (backtrace_command_completer): New.
8796         (_initialize_stack): Extend "backtrace"'s help to mention
8797         supported options.  Install completer for "backtrace".
8798         Install some settings commands with add_setshow_cmds_for_options.
8799
8800 2019-06-13  Pedro Alves  <palves@redhat.com>
8801
8802         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8803         and that "set/show print raw frame-arguments" are now deprecated.
8804
8805         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8806         command.
8807         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8808         * stack.c (_initialize_stack): Install "set/show print
8809         raw-frame-arguments", and deprecate "set/show print raw
8810         frame-arguments".
8811         * valprint.c (_initialize_valprint): Deprecate "set/show print
8812         raw".
8813
8814 2019-06-13  Pedro Alves  <palves@redhat.com>
8815
8816         * compile/compile.c (struct compile_options): New.
8817         (compile_flag_option_def, compile_command_option_defs)
8818         (make_compile_options_def_group): New.
8819         (compile_file_command): Handle options with
8820         gdb::option::process_options.
8821         (compile_file_command_completer): New function.
8822         (compile_code_command): Handle options with
8823         gdb::option::process_options.
8824         (compile_code_command_completer): New function.
8825         (_initialize_compiler): Install completers for "compile code" and
8826         "compile file".  Mention available options in "compile code" and
8827         "compile code"'s help.
8828         * completer.c (advance_to_completion_word): New, factored out from
8829         ...
8830         (advance_to_expression_complete_word_point): ... this.
8831         (advance_to_filename_complete_word_point): New.
8832         * completer.h (advance_to_filename_complete_word_point): New
8833         declaration.
8834
8835 2019-06-13  Pedro Alves  <palves@redhat.com>
8836
8837         * compile/compile.c: Include "cli/cli-option.h".
8838         (compile_print_value): Scope data pointer is now a
8839         value_print_options pointer; adjust.
8840         (compile_print_command): Process options.  Scope data pointer is
8841         now a value_print_options pointer; adjust.
8842         (_initialize_compile): Update "compile print"'s help to include
8843         supported options.  Install a completer for "compile print".
8844         * cp-valprint.c (show_vtblprint, show_objectprint)
8845         (show_static_field_print): Delete.
8846         (_initialize_cp_valprint): Don't install "set print
8847         static-members", "set print vtbl", "set print object" here.
8848         * printcmd.c: Include "cli/cli-option.h" and
8849         "common/gdb_optional.h".
8850         (print_command_parse_format): Rework to fill in a
8851         value_print_options instead of a format_data.
8852         (print_value): Change parameter type from format_data pointer to
8853         value_print_options reference.  Adjust.
8854         (print_command_1): Process options.  Adjust to pass down a
8855         value_print_options.
8856         (print_command_completer): New.
8857         (_initialize_printcmd): Install print_command_completer as
8858         handle_brkchars completer for the "print" command.  Update
8859         "print"'s help to include supported options.
8860         * valprint.c: Include "cli/cli-option.h".
8861         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8862         here from cp-valprint.c.
8863         (boolean_option_def, uinteger_option_def)
8864         (value_print_option_defs, make_value_print_options_def_group):
8865         New.  Use gdb::option::add_setshow_cmds_for_options to install
8866         "set print elements", "set print null-stop", "set print repeats",
8867         "set print pretty", "set print union", "set print array", "set
8868         print address", "set print symbol", "set print array-indexes".
8869         * valprint.h: Include <string> and "cli/cli-option.h".
8870         (make_value_print_options_def_group): Declare.
8871         (print_value): Change parameter type from format_data pointer to
8872         value_print_options reference.
8873         (print_command_completer): Declare.
8874
8875 2019-06-13  Pedro Alves  <palves@redhat.com>
8876
8877         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8878         (COMMON_SFILES): Add maint-test-settings.c.
8879         * cli/cli-decode.c (boolean_enums): New global, factored out from
8880         ...
8881         (add_setshow_boolean_cmd): ... here.
8882         * cli/cli-decode.h (boolean_enums): Declare.
8883         * cli/cli-option.c: New file.
8884         * cli/cli-option.h: New file.
8885         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8886         factored out from ...
8887         (parse_cli_boolean_value(const char *)): ... this.
8888         (is_unlimited_literal): Change parameter type to pointer to
8889         pointer.  Adjust and advance ARG pointer.
8890         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8891         (parse_cli_var_enum): New, factored out from ...
8892         (do_set_command): ... this.  Adjust.
8893         * cli/cli-setshow.h (parse_cli_boolean_value)
8894         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8895         (parse_cli_var_enum): Declare.
8896         * cli/cli-utils.c: Include "cli/cli-option.h".
8897         (get_ulongest): New.
8898         * cli/cli-utils.h (get_ulongest): Declare.
8899         (check_for_argument): New overloads.
8900         * maint-test-options.c: New file.
8901
8902 2019-06-13  Pedro Alves  <palves@redhat.com>
8903
8904         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8905         parse a range if "-" is at the end of the string.
8906
8907 2019-06-13  Pedro Alves  <palves@redhat.com>
8908
8909         * cli/cli-setshow.c (parse_auto_binary_operation)
8910         (parse_cli_boolean_value): Don't allow "o".
8911
8912 2019-06-13  Pedro Alves  <palves@redhat.com>
8913
8914         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8915         * NEWS: Mention maint test-settings KIND.
8916         * maint-test-settings.c: New file.
8917
8918 2019-06-13  Pedro Alves  <palves@redhat.com>
8919
8920         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8921         completer.
8922         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8923         "set" completers.
8924
8925 2019-06-13  Pedro Alves  <palves@redhat.com>
8926
8927         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8928         after item.
8929
8930 2019-06-13  Pedro Alves  <palves@redhat.com>
8931
8932         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8933
8934 2019-06-13  Pedro Alves <palves@redhat.com>
8935
8936         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8937         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8938         call.
8939         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8940         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8941         calls.
8942         (check_for_argument): Skip spaces after argument.
8943
8944 2019-06-13  Pedro Alves  <palves@redhat.com>
8945
8946         * thread.c (thread_apply_command): Adjust TID parsing.
8947         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8948         detected before end of string.
8949         (tid_is_in_list): Error out if LIST is invalid.
8950
8951 2019-06-13  Pedro Alves  <palves@redhat.com>
8952
8953         * completer.c (complete_line_internal_1): Rewind completion word
8954         point.
8955         (completion_tracker::advance_custom_word_point_by): Change
8956         parameter type to int.
8957         * completer.h (completion_tracker::advance_custom_word_point_by):
8958         Likewise.
8959
8960 2019-06-13  Pedro Alves  <palves@redhat.com>
8961
8962         * completer.c (advance_to_completion_word): Handle delimiters.
8963
8964 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8965
8966         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8967
8968 2019-06-11  Tom Tromey  <tom@tromey.com>
8969
8970         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8971         (xmalloc_failed): Move to alloc.c.
8972         * alloc.c: New file.
8973         * Makefile.in (COMMON_SFILES): Add alloc.c.
8974
8975 2019-06-11  Tom Tromey  <tom@tromey.com>
8976
8977         * nat/linux-waitpid.c: Don't include server.h.
8978         (linux_debug): Remove.
8979         (my_waitpid): Update.
8980
8981 2019-06-11  Tom Tromey  <tromey@adacore.com>
8982
8983         * infcall.c (_initialize_infcall): Remove trailing newline from
8984         help.
8985         * user-regs.c (_initialize_user_regs): Remove trailing newline
8986         from help.
8987         * typeprint.c (_initialize_typeprint): Remove trailing newline
8988         from help.
8989         * reverse.c (_initialize_reverse): Remove trailing newlines from
8990         help.
8991         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8992         from help.
8993         * language.c (add_set_language_command): Remove trailing newline
8994         from help.
8995         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8996         help.
8997         * disasm.c (_initialize_disasm): Remove trailing newline from
8998         help.
8999         * top.c (init_main): Remove trailing newline from help.
9000         * interps.c (_initialize_interpreter): Remove trailing newline
9001         from help.
9002         * btrace.c (_initialize_btrace): Remove trailing newlines from
9003         help.
9004         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9005         from help.
9006         * python/python.c (_initialize_python): Remove trailing newline
9007         from help.
9008         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9009         help.
9010         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9011         from help.  Reformat some text.
9012         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9013         from help.
9014         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9015         newline from help.
9016
9017 2019-06-11  Tom Tromey  <tromey@adacore.com>
9018
9019         * darwin-nat.c (darwin_decode_exception_message)
9020         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9021
9022 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9023
9024         * valops.c (value_slice): Check for not allocated or not
9025         associated values.
9026
9027 2019-06-10  Tom de Vries  <tdevries@suse.de>
9028
9029         PR gdb/24618
9030         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9031         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9032         invalid.
9033
9034 2019-06-10  Tom de Vries  <tdevries@suse.de>
9035
9036         PR gdb/24611
9037         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9038         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9039
9040 2019-06-10  Tom de Vries  <tdevries@suse.de>
9041
9042         PR symtab/24545
9043         * symtab.c (struct demangled_name_entry): Add language field.
9044         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9045         static minimal symbol".  Set and use language field.
9046
9047 2019-06-10  Tom Tromey  <tromey@adacore.com>
9048
9049         * ada-lang.c (_initialize_ada_language): Update help text.
9050
9051 2019-06-10  Tom Tromey  <tromey@adacore.com>
9052
9053         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9054         with a newline.
9055         * guile/guile.c (handle_boot_error): Don't end warning with a
9056         newline.
9057         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9058         warning with a newline.
9059         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9060         newline.
9061         (s12z_frame_cache): Likewise.
9062         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9063         a newline.
9064         * solib-svr4.c (disable_probes_interface): Don't end warning with
9065         a newline.
9066         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9067         newline.
9068         * python/python.c (do_finish_initialization): Don't end warning
9069         with a newline.
9070
9071 2019-06-10  Tom Tromey  <tom@tromey.com>
9072
9073         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9074         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9075         gdbpy_enter.
9076
9077 2019-06-10  Tom Tromey  <tromey@adacore.com>
9078
9079         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9080         data.
9081         (elf_new_init): Don't call stabsread_new_init.
9082         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9083         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9084         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9085
9086 2019-06-10  Tom de Vries  <tdevries@suse.de>
9087
9088         PR symtab/16264
9089         PR symtab/24517
9090         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9091
9092 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9093
9094         * source.c (find_and_open_source): Also rewrite relative file
9095         names.
9096
9097 2019-04-26  Amos Bird  <amosbird@gmail.com>
9098
9099         * annotate.c (annotate_thread_exited): Add "thread-exited"
9100         annotation.
9101
9102 2019-06-06  Tom Tromey  <tromey@adacore.com>
9103
9104         * maint.h (class scoped_command_stats): Use
9105         DISABLE_COPY_AND_ASSIGN.
9106         <print_time>: New method.
9107         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9108         print_time.
9109         (scoped_command_stats::print_time): New method.
9110
9111 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9112
9113         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9114         instructions of lengths 6 or 8 bytes.
9115
9116 2019-06-04  Pedro Alves  <palves@redhat.com>
9117
9118         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9119
9120         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9121         * breakpoint.c (condition_completer): Likewise.
9122         * cli/cli-dump.c (scan_expression): Likewise.
9123         * common/filestuff.c (mkdir_recursive): Likewise.
9124         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9125         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9126         (gdb_abspath): Likewise.
9127         * compile/compile-cplus-types.c
9128         (compile_cplus_instance::decl_name): Likewise.
9129         * completer.c (complete_explicit_location):
9130         (signal_completer, reg_or_group_completer_1): Likewise.
9131         * cp-support.c (cp_remove_params_if_any): Likewise.
9132         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9133         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9134         * infcmd.c (strip_bg_char): Likewise.
9135         * linespec.c (copy_token_string): Likewise.
9136         * mi/mi-main.c (output_cores): Likewise.
9137         * psymtab.c (psymtab_search_name):
9138         * symfile.c (test_set_ext_lang_command): Likewise.
9139         * target.c (target_fileio_read_stralloc): Likewise.
9140         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9141         * value.c (complete_internalvar): Likewise.
9142
9143 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9144
9145         Add objfile property to gdb.Type.
9146         * NEWS: Mention Python API addition.
9147         * python/py-type.c (typy_get_objfile): New method.
9148
9149 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9150
9151         * NEWS: Mention the new set|show style [title|highlight].
9152         Mention changes to "show style", "help" and "apropos".
9153
9154 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9155
9156         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9157         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9158         instead of print_help_for_command.
9159         (print_doc_of_command): New function.
9160         (help_list): Add 'apropos -v word' suggestion.
9161         (print_help_for_command): Style the command name using title style.
9162         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9163         (_initialize_cli_cmds): Describe -v in apropos_command help.
9164
9165 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9166
9167         * cli/cli-style.h (cli_style_option): Add name in constructor,
9168         add m_name class member, add constructor with intensity,
9169         add name class function.
9170         (cli_style_option::add_setshow_commands): Remove name argument.
9171         (highlight_style, title_style): New styles.
9172         * cli/cli-style.c (do_show): New function that shows a style
9173         characteristic styling the style name with itself.
9174         (set_style_name): New function.
9175         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9176         Update all callers according to the changes in cli/cli-style.h.
9177         * utils.h (fputs_highlighted): New function.
9178         * utils.c (fputs_highlighted): Likewise.
9179
9180 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9181
9182         * NEWS: Mention new pipe command and new convenience variables.
9183
9184 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9185
9186         * cli/cli-cmds.c (pipe_command): New function.
9187         (_initialize_cli_cmds): Call add_com for pipe_command.
9188         Define | as an alias for pipe.
9189         (exit_status_set_internal_vars): New function.
9190         (shell_escape): Call exit_status_set_internal_vars.
9191         cli/cli-decode.c (find_command_name_length): Recognize | as
9192         a single character command.
9193
9194 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9195
9196         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9197         top.c (execute_command_to_ui_file): New function, mostly a copy
9198         of execute_command_to_string.
9199         (execute_command_to_string): Implement by calling
9200         execute_command_to_ui_file.
9201
9202 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9203
9204         * top.h (saved_command_line): Remove declaration.
9205         * top.c (previous_saved_command_line, previous_repeat_arguments):
9206         New variables.
9207         (saved_command_line): Make static, define together with other
9208         'repeat variables'.
9209         (dont_repeat): Clear repeat_arguments.
9210         (repeat_previous, get_saved_command_line, save_command_line):
9211         New functions.
9212         (gdb_init): Initialize saved_command_line
9213         and previous_saved_command_line.
9214         * main.c (captured_main_1): Remove saved_command_line initialization.
9215         * event-top.c (handle_line_of_input): Update to use
9216         the new 'repeat' related functions instead of direct access to
9217         saved_command_line.
9218         * command.h (repeat_previous, get_saved_command_line,
9219         save_command_line): New declarations.
9220         (dont_repeat): Add comment.
9221
9222 2019-05-30  Tom Tromey  <tromey@adacore.com>
9223
9224         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9225         Fix comment.
9226         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9227
9228 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9229
9230         PR cli/24587
9231         * completer.c (complete): Initialize variable word.
9232
9233 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9234
9235         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9236         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9237         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9238         'body' is NULL to the outter 'if', protecting the '!is_define'
9239         situation as well.
9240
9241 2019-05-29  Tom Tromey  <tromey@adacore.com>
9242
9243         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9244         (dwarf_unknown): New function.
9245         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9246         (dwarf_type_encoding_name): Use dwarf_unknown.
9247
9248 2019-05-29  Tom Tromey  <tromey@adacore.com>
9249
9250         PR c++/20020:
9251         * cp-valprint.c (cp_print_value_fields): Call
9252         cp_print_static_field inside "try".
9253
9254 2019-05-29  Tom Tromey  <tromey@adacore.com>
9255
9256         * inflow.c (struct terminal_info): Add default operator=.
9257         * configure: Rebuild.
9258         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9259         -Wdeprecated-copy-dtor, -Wredundant-move.
9260
9261 2019-05-29  Tom Tromey  <tromey@adacore.com>
9262
9263         * NEWS: Add entry.
9264         * infcmd.c (print_return_value_1): Handle finish_print
9265         option.
9266         (show_print_finish): New function.
9267         (_initialize_infcmd): Add "set/show print finish" commands.
9268         * valprint.c (user_print_options): Initialize new member.
9269         * valprint.h (struct value_print_options) <finish_print>: New
9270         member.
9271
9272 2019-05-28  Tom Tromey  <tromey@adacore.com>
9273
9274         * ada-lang.c (ada_remove_Xbn_suffix)
9275         (find_old_style_renaming_symbol)
9276         (parse_old_style_renaming): Remove.
9277         (ada_find_renaming_symbol): Don't call
9278         find_old_style_renaming_symbol.
9279         (ada_is_renaming_symbol): Rename from
9280         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9281         bool.  Now static.
9282         (ada_read_var_value): Update and simplify.
9283         * ada-exp.y (write_var_or_type): Remove old code.
9284
9285 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9286
9287         PR gdb/25010
9288         * event-top.c: Remove include comment.
9289         * inflow.c (class scoped_ignore_sigttou): Move from here...
9290         * inflow.h (class scoped_ignore_sigttou): ...to here.
9291         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9292         * top.c:  Remove include comment.
9293
9294 2019-05-27  Tom Tromey  <tom@tromey.com>
9295
9296         * NEWS: Fix typo.
9297
9298 2019-05-22  Tom Tromey  <tromey@adacore.com>
9299
9300         * target.c (target_follow_exec): Constify parameter.
9301         * target-delegates.c: Rebuild.
9302         * remote.c (remote_target::follow_exec): Constify parameter.
9303         * infrun.c (follow_exec): Constify parameter.
9304         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9305         (target_follow_exec): Likewise.
9306
9307 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9308
9309         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9310         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9311
9312 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9313
9314         * NEWS: Add debugredirect and testsuite sections.
9315
9316 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9317
9318         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9319         target descriptions using exclusively floating point register name
9320         aliases.
9321
9322 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9323
9324         PR gdb/18644:
9325         * f-lang.c (build_fortran_types): Handle the case where
9326         gdbarch_floatformat_for_type returns a nullptr.
9327
9328 2019-05-21  Tom de Vries  <tdevries@suse.de>
9329
9330         PR cli/24587
9331         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9332
9333 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9334
9335         PR gdb/18644:
9336         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9337         16-byte floats.
9338         * i386-tdep.c (i386_floatformat_for_type): Use
9339         floatformats_ia64_quad for the 16-byte floating point component
9340         within a fortran 32-byte complex number.
9341
9342 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9343
9344         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9345         delete default constructor.
9346         (find_partial_die): Update to return const struct.
9347         (partial_die_parent_scope): Move variable declaration into scope
9348         of its use and change its type to auto.
9349         (guess_partial_die_structure_name): Likewise.
9350         (partial_die_info::fixup): Likewise.
9351
9352 2019-05-17  Tom Tromey  <tromey@adacore.com>
9353
9354         * source.c (find_and_open_source): Remove cast.
9355
9356 2019-05-17  Tom Tromey  <tromey@adacore.com>
9357
9358         * annotate.c (annotate_source): Make "filename" const.
9359         * annotate.h (annotate_source): Use const.
9360
9361 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9362
9363         * disasm.c (set_disassembler_options): Send errors to stderr.
9364
9365 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9366
9367         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9368         (cli_interp_base::set_logging): Check debug_redirect.
9369         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9370         * cli/cli-logging.c (debug_redirect): Add static variable.
9371         (pop_output_files): Add default param.
9372         (handle_redirections): Print debug setting.
9373         (show_logging_command): Likewise.
9374         (_initialize_cli_logging): Add debugredirect command.
9375         * interps.c (current_interp_set_logging): Add debug_redirect
9376         parameter.
9377         * interps.h (set_logging): Add debug_redirect parameter.
9378         (current_interp_set_logging): Likewise.
9379         * mi/mi-common.h: Likewise.
9380         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9381
9382 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9383             Tom Tromey  <tromey@adacore.com>
9384
9385         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9386         directly.
9387         * cli/cli-interp.h (make_logging_output): Remove declaration.
9388         * cli/cli-logging.c (make_logging_output): Remove function.
9389         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9390         directly.
9391         * ui-file.c (tee_file::tee_file): Remove bools.
9392         (tee_file::~tee_file): Remove deletes.
9393         * ui-file.h (tee_file): Remove bools.
9394
9395 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9396
9397         * mi/mi-cmds.h (mi_cmd_complete): New function.
9398         * mi/mi-main.c (mi_cmd_complete): Likewise.
9399         * mi/mi-cmds.c: Define new MI command -complete.
9400         * NEWS: Mention new -complete command.
9401
9402 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9403
9404         * completer.h (complete): New function.
9405         * completer.c (complete): Likewise.
9406         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9407         function defined in completer.h.
9408
9409 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9410
9411         * MAINTAINERS (Write After Approval): Add myself.
9412
9413 2019-05-17  Tom de Vries  <tdevries@suse.de>
9414
9415         PR gdb/24094
9416         * dwarf2read.c (struct cu_partial_die_info): New struct.
9417         (find_partial_die): Return cu_partial_die_info.
9418         (partial_die_parent_scope, guess_partial_die_structure_name)
9419         (partial_die_info::fixup): Handle new return type of find_partial_die.
9420
9421 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9422
9423         PR breakpoints/24541
9424         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9425         "std::string", simplifying the algorithm.
9426
9427 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9428
9429         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9430         (stap_static_probe_ops::get_probes): Likewise.
9431
9432 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9433
9434         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9435         '-')" and "else if".
9436         (stap_parse_single_operand): Join checks for
9437         "gdbarch_stap_parse_special_token_p" and
9438         "gdbarch_stap_parse_special_token" in the same "if" statement.
9439         Invert check when verifying for operation on register
9440         displacement.
9441
9442 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9443
9444         * stap-probe.c (stap_get_opcode): Update comment.
9445         (stap_get_expected_argument_type): Likewise.
9446         (handle_stap_probe): Likewise.
9447
9448 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9449
9450         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9451         return type to 'bool'.  Adjust comment.  Use 'bool' when
9452         appropriate.
9453         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9454         * stap-probe.c (stap_parse_argument_1): Likewise.
9455         (stap_is_operator): Likewise.
9456         (stap_is_generic_prefix): Likewise.
9457         (stap_is_register_prefix): Likewise.
9458         (stap_is_register_indirection_prefix): Likewise.
9459         (stap_is_integer_prefix): Likewise.
9460         (stap_generic_check_suffix): Likewise.
9461         (stap_check_integer_suffix): Likewise.
9462         (stap_check_register_suffix): Likewise.
9463         (stap_check_register_indirection_suffix): Likewise.
9464         (stap_parse_register_operand): Likewise.
9465         (stap_parse_single_operand): Likewise.
9466         (stap_parse_argument_1): Likewise.
9467         (stap_probe::get_argument_count): Likewise.
9468         (stap_is_operator): Likewise.
9469
9470 2019-05-16  Tom Tromey  <tromey@adacore.com>
9471
9472         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9473         keyword to foreach.
9474
9475 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9476
9477         * linux-thread-db.c (try_thread_db_load_1): Change return type
9478         to bool.
9479         (try_thread_db_load): Likewise.
9480         (try_thread_db_load_from_pdir_1): Likewise.
9481         (try_thread_db_load_from_pdir): Likewise.
9482         (try_thread_db_load_from_sdir): Likewise.
9483         (try_thread_db_load_from_dir): Likewise.
9484         (thread_db_load_search): Likewise.
9485         (has_libpthread): Likewise.
9486         (thread_db_load): Likewise.
9487
9488 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9489
9490         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9491         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9492         NULL, and complain/return if that's the case.
9493
9494 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9495
9496         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9497         (advance, posn, abstract_read_memory): New functions.
9498         [struct mem_read_abstraction]: New struct.
9499         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9500
9501 2019-05-14  Tom Tromey  <tromey@adacore.com>
9502
9503         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9504         value is not lval_memory.
9505
9506 2019-05-14  Tom Tromey  <tromey@adacore.com>
9507
9508         * solib.c (info_sharedlibrary_command): Style the file name.
9509
9510 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9511
9512         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9513         (aarch64_vnv_type): Likewise.
9514         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9515         * common/tdesc.c: Likewise.
9516         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9517         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9518         * features/aarch64-fpu.xml: Add ieee half view.
9519         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9520         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9521         * gdbtypes.h (struct builtin_type): Likewise.
9522         (struct objfile_type): Likewise.
9523
9524 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9525
9526         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9527         typo.
9528         * location.h (string_to_event_location): Likewise.
9529
9530 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9531
9532         GDB 8.3 released.
9533
9534 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9535
9536         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9537         New variable declaration.
9538         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9539         New variable.
9540         (print_one_breakpoint): Use ui_out::test_flags and new global
9541         variable to compute use_fixed_output.
9542         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9543         Remove.
9544         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9545         (mi_multi_location_breakpoint_output_fixed): Remove.
9546         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9547         new variable.
9548         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9549         fix_multi_location_breakpoint_output flag if version >= 3.
9550         * ui-out.h (enum ui_out_flag)
9551         <fix_multi_location_breakpoint_output>: New enumerator.
9552
9553 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9554
9555         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9556
9557 2019-05-10  Tom Tromey  <tromey@adacore.com>
9558
9559         * ada-lang.c (catch_ada_completer): New function.
9560         (_initialize_ada_language): Use it.
9561
9562 2019-05-10  Tom Tromey  <tromey@adacore.com>
9563
9564         * thread.c (print_thread_info): Make "requested_threads" const.
9565         * gdbthread.h (print_thread_info): Make "requested_threads"
9566         const.
9567         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9568         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9569
9570 2019-05-08  Tom Tromey  <tom@tromey.com>
9571
9572         * gdbtypes.c (objfile_type_data): Change type.
9573         (objfile_type, _initialize_gdbtypes): Update.
9574
9575 2019-05-08  Tom Tromey  <tom@tromey.com>
9576
9577         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9578         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9579         (_initialize_dwarf2_frame): Update.
9580
9581 2019-05-08  Tom Tromey  <tom@tromey.com>
9582
9583         * objc-lang.c (objc_objfile_data): Change type.
9584         (find_methods): Update.
9585         (_initialize_objc_lang): Remove.
9586
9587 2019-05-08  Tom Tromey  <tom@tromey.com>
9588
9589         * stabsread.c (rs6000_builtin_type_data): Change type.
9590         (rs6000_builtin_type, _initialize_stabsread): Update.
9591
9592 2019-05-08  Tom Tromey  <tom@tromey.com>
9593
9594         * mips-tdep.c (mips_pdr_data): Remove.
9595         (_initialize_mips_tdep): Update.
9596
9597 2019-05-08  Tom Tromey  <tom@tromey.com>
9598
9599         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9600         (hppa_init_objfile_priv_data, read_unwind_info)
9601         (find_unwind_entry, _initialize_hppa_tdep): Update.
9602
9603 2019-05-08  Tom Tromey  <tom@tromey.com>
9604
9605         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9606         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9607         on obstack.
9608         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9609
9610 2019-05-08  Tom Tromey  <tom@tromey.com>
9611
9612         * mdebugread.c (basic_type_data): Change type.
9613         (basic_type, _initialize_mdebugread): Update.
9614
9615 2019-05-08  Tom Tromey  <tom@tromey.com>
9616
9617         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9618
9619 2019-05-08  Tom Tromey  <tom@tromey.com>
9620
9621         * nto-tdep.c (nto_inferior_data_reg): Change type.
9622         (nto_inferior_data): Update.
9623         (nto_inferior_data_cleanup, nto_new_inferior_data)
9624         (_initialize_nto_tdep): Remove.
9625         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9626
9627 2019-05-08  Tom Tromey  <tom@tromey.com>
9628
9629         * ada-lang.c (struct ada_inferior_data): Add initializers.
9630         (ada_inferior_data): Change type.
9631         (ada_inferior_data_cleanup): Remove.
9632         (get_ada_inferior_data, ada_inferior_exit)
9633         (struct ada_pspace_data): Add initializers, destructor.
9634         (ada_pspace_data_handle): Change type.
9635         (get_ada_pspace_data): Update.
9636         (ada_pspace_data_cleanup): Remove.
9637
9638 2019-05-08  Tom Tromey  <tom@tromey.com>
9639
9640         * coffread.c (struct coff_symfile_info): Add initializers.
9641         (coff_objfile_data_key): Move lower.  Change type.
9642         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9643         Update.
9644         (coff_free_info): Remove.
9645
9646 2019-05-08  Tom Tromey  <tom@tromey.com>
9647
9648         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9649         (fbsd_pspace_data_handle): Move lower.  Change type.
9650         (get_fbsd_pspace_data): Update.
9651         (fbsd_pspace_data_cleanup): Remove.
9652         (_initialize_fbsd_tdep): Update.
9653
9654 2019-05-08  Tom Tromey  <tom@tromey.com>
9655
9656         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9657         (get_ada_tasks_pspace_data): Update.
9658         (ada_tasks_pspace_data_cleanup): Remove.
9659         (_initialize_tasks): Update.
9660         (ada_tasks_inferior_data_handle): Change type.
9661         (get_ada_tasks_inferior_data): Update.
9662         (ada_tasks_inferior_data_cleanup): Remove.
9663         (struct ada_tasks_pspace_data): Add initializers.
9664
9665 2019-05-08  Tom Tromey  <tom@tromey.com>
9666
9667         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9668         * symfile-debug.c (debug_sym_get_probes): Change type.
9669         * stap-probe.c (handle_stap_probe):
9670         (stap_static_probe_ops::get_probes): Change type.
9671         * probe.h (class static_probe_ops) <get_probes>: Change type.
9672         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9673         (parse_probes_in_pspace): Update.
9674         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9675         Update.
9676         (any_static_probe_ops::get_probes): Change type.
9677         * elfread.c (elfread_data): New typedef.
9678         (probe_key): Change type.
9679         (elf_get_probes): Likewise.  Update.
9680         (probe_key_free): Remove.
9681         (_initialize_elfread): Update.
9682         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9683         Change type.
9684         (dtrace_process_dof_probe, dtrace_process_dof)
9685         (dtrace_static_probe_ops::get_probe): Change type.
9686
9687 2019-05-08  Tom Tromey  <tom@tromey.com>
9688
9689         * xcoffread.c (struct xcoff_symfile_info): Rename from
9690         coff_symfile_info.  Add initializers.
9691         (xcoff_objfile_data_key): Move lower.  Change type.
9692         (XCOFF_DATA): Rewrite.
9693         (xcoff_free_info): Remove.
9694         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9695         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9696         (xcoff_initial_scan): Update.
9697
9698 2019-05-08  Tom Tromey  <tom@tromey.com>
9699
9700         * solib-svr4.c (struct svr4_info): Add initializers and
9701         destructor.
9702         <probes_table>: Now an htab_up.
9703         (solib_svr4_pspace_data): Change type.
9704         (free_probes_table): Simplify.
9705         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9706         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9707         (probes_table_remove_objfile_probes, register_solib_event_probe)
9708         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9709         (_initialize_svr4_solib): Update.
9710
9711 2019-05-08  Tom Tromey  <tom@tromey.com>
9712
9713         * remote.c (remote_pspace_data): Change type.
9714         (remote_pspace_data_cleanup): Remove.
9715         (get_remote_exec_file, set_pspace_remote_exec_file)
9716         (_initialize_remote): Update.
9717
9718 2019-05-08  Tom Tromey  <tom@tromey.com>
9719
9720         * breakpoint.c (breakpoint_objfile_key): Change type.
9721         (get_breakpoint_objfile_data): Update.
9722         (free_breakpoint_objfile_data): Remove.
9723         (_initialize_breakpoint): Update.
9724
9725 2019-05-08  Tom Tromey  <tom@tromey.com>
9726
9727         * linux-tdep.c (struct linux_info): Add initializers.
9728         (linux_inferior_data): Move.  Change type.
9729         (invalidate_linux_cache_inf): Update.
9730         (linux_inferior_data_cleanup): Remove.
9731         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9732
9733 2019-05-08  Tom Tromey  <tom@tromey.com>
9734
9735         * auxv.c (auxv_inferior_data): Move.  Change type.
9736         (auxv_inferior_data_cleanup): Remove.
9737         (invalidate_auxv_cache_inf): Rewrite.
9738         (get_auxv_inferior_data, _initialize_auxv): Update.
9739
9740 2019-05-08  Tom Tromey  <tom@tromey.com>
9741
9742         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9743         (symfile_debug_objfile_data_key): Change type.
9744         (symfile_debug_installed, debug_qf_has_symbols)
9745         (debug_qf_find_last_source_symtab)
9746         (debug_qf_forget_cached_source_info)
9747         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9748         (debug_qf_print_stats, debug_qf_dump)
9749         (debug_qf_expand_symtabs_for_function)
9750         (debug_qf_expand_all_symtabs)
9751         (debug_qf_expand_symtabs_with_fullname)
9752         (debug_qf_map_matching_symbols)
9753         (debug_qf_expand_symtabs_matching)
9754         (debug_qf_find_pc_sect_compunit_symtab)
9755         (debug_qf_map_symbol_filenames)
9756         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9757         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9758         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9759         (debug_sym_read_linetable, debug_sym_relocate): Update.
9760         (symfile_debug_free_objfile): Remove.
9761         (install_symfile_debug_logging, _initialize_symfile_debug):
9762         Update.
9763
9764 2019-05-08  Tom Tromey  <tom@tromey.com>
9765
9766         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9767         allocate_on_obstack.
9768         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9769         (get_dwarf2_per_objfile): Update.
9770         (set_dwarf2_per_objfile): Remove.
9771         (dwarf2_has_info, dwarf2_get_section_info): Update.
9772         (dwarf2_free_objfile): Remove.
9773         (_initialize_dwarf2_read): Update.
9774
9775 2019-05-08  Tom Tromey  <tom@tromey.com>
9776
9777         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9778         initializers.
9779         <unsupported_script_warning_printed,
9780         script_not_found_warning_printed>: Now bool.
9781         (auto_load_pspace_data): Change type.
9782         (~auto_load_pspace_info): Rename from
9783         auto_load_pspace_data_cleanup.
9784         (get_auto_load_pspace_data, init_loaded_scripts_info)
9785         (clear_section_scripts, maybe_print_unsupported_script_warning)
9786         (maybe_print_script_not_found_warning, _initialize_auto_load):
9787         Update.
9788
9789 2019-05-08  Tom Tromey  <tom@tromey.com>
9790
9791         * objfiles.c (objfile_pspace_info): Add destructor and
9792         initializers.
9793         (objfiles_pspace_data): Change type.
9794         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9795         (get_objfile_pspace_data): Update.
9796         (objfiles_bfd_data): Change type.
9797         (get_objfile_bfd_data): Update.
9798         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9799
9800 2019-05-08  Tom Tromey  <tom@tromey.com>
9801
9802         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9803         Change type.
9804         (get_catch_syscall_inferior_data): Update.
9805         (catch_syscall_inferior_data_cleanup): Remove.
9806         (_initialize_break_catch_syscall): Update.
9807
9808 2019-05-08  Tom Tromey  <tom@tromey.com>
9809
9810         * inflow.c (struct terminal_info): Add destructor and
9811         initializers.
9812         (inflow_inferior_data): Change type.
9813         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9814         (get_inflow_inferior_data, inflow_inferior_exit)
9815         (swap_terminal_info, _initialize_inflow): Update.
9816
9817 2019-05-08  Tom Tromey  <tom@tromey.com>
9818
9819         * target-dcache.c (target_dcache_cleanup): Remove.
9820         (target_dcache_aspace_key): Change type.
9821         (target_dcache_init_p, target_dcache_invalidate)
9822         (target_dcache_get, target_dcache_get_or_init)
9823         (_initialize_target_dcache): Update.
9824         * dcache.h (struct dcache_deleter): New.
9825
9826 2019-05-08  Tom Tromey  <tom@tromey.com>
9827
9828         * symtab.c (struct symbol_cache): Add destructor and
9829         initializers.
9830         (symbol_cache_key): Move.  Change type.
9831         (make_symbol_cache, free_symbol_cache): Remove.
9832         (get_symbol_cache): Update.
9833         (symbol_cache_cleanup): Remove.
9834         (ALL_PSPACES, symbol_cache_flush)
9835         (maintenance_print_symbol_cache)
9836         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9837         Update.
9838
9839 2019-05-08  Tom Tromey  <tom@tromey.com>
9840
9841         * symtab.c (struct main_info): Add destructor and initializers.
9842         (main_progspace_key): Move.  Change type.
9843         (get_main_info): Update.
9844         (main_info_cleanup): Remove.
9845         (_initialize_symtab): Update.
9846
9847 2019-05-08  Tom Tromey  <tom@tromey.com>
9848
9849         * registry.h (DECLARE_REGISTRY): Define the _key class.
9850
9851 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9852
9853         * NEWS: Merge two 'New commands' sections.
9854
9855 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9856
9857         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9858         parameter and use Ada language definition instead.
9859         (ada_val_print_ptr): Remove unused language parameter.
9860         (ada_val_print_num): Remove language parameter and use Ada language
9861         definition instead.
9862         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9863         parameter.
9864         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9865         parameter and use Ada language definition instead.
9866         (ada_val_print_1): Update all ada_val_print_xxx calls.
9867         Remove language parameter.
9868         (ada_val_print): Update ada_val_print_1 call.
9869
9870 2019-05-08  Tom Tromey  <tromey@adacore.com>
9871
9872         * remote.c (remote_hw_watchpoint_limit)
9873         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9874         Now static.
9875
9876 2019-05-08  Tom Tromey  <tromey@adacore.com>
9877
9878         * maint.c (_initialize_maint_cmds): Move initialization code to
9879         remote.c.
9880         (watchdog, show_watchdog): Move to remote.c.
9881         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9882         "watchdog" static.
9883         (_initialize_remote): Move initialization code from maint.c.
9884         * defs.h (watchdog): Don't declare.
9885
9886 2019-05-08  Tom Tromey  <tromey@adacore.com>
9887
9888         * tui/tui-interp.c: Include main.h.
9889         * interps.c: Include main.h.
9890         * main.h (interpreter_p): Declare.
9891         * defs.h (interpreter_p): Don't declare.
9892
9893 2019-05-08  Tom Tromey  <tromey@adacore.com>
9894
9895         * dwarf2loc.c: Include dwarf2read.h.
9896         * defs.h (read_unsigned_leb128): Don't declare.
9897         * dwarf2read.h (read_unsigned_leb128): Declare.
9898
9899 2019-05-08  Tom Tromey  <tromey@adacore.com>
9900
9901         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9902         method.
9903
9904 2019-05-08  Tom Tromey  <tromey@adacore.com>
9905
9906         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9907         when no wrap column is set.
9908
9909 2019-05-08  Tom Tromey  <tromey@adacore.com>
9910
9911         * c-lang.c (c_get_string): Handle non-C-style arrays.
9912
9913 2019-05-08  Tom Tromey  <tromey@adacore.com>
9914
9915         * typeprint.c (print_offset_data::update): Print the bit offset,
9916         not the number of bits remaining.
9917
9918 2019-05-08  Tom Tromey  <tromey@adacore.com>
9919
9920         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9921         padding at end of comment.
9922
9923 2019-05-08  Tom Tromey  <tromey@adacore.com>
9924
9925         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9926         Compare main types.
9927
9928 2019-05-06  Tom Tromey  <tom@tromey.com>
9929
9930         * common/scoped_mmap.c: Include common-defs.h.
9931         * common/scoped_mmap.h: Don't include config.h.
9932
9933 2019-05-04  Tom Tromey  <tom@tromey.com>
9934
9935         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9936         (struct aarch64_call_info): Add initializers.
9937         <si>: Now a std::vector.
9938         (pass_on_stack, aarch64_push_dummy_call): Update.
9939
9940 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9941             Tom Tromey  <tom@tromey.com>
9942
9943         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9944         (ppc_threads): Now a std::vector.  Now static.
9945         (hwdebug_find_thread_points_by_tid)
9946         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9947         Update.
9948
9949 2019-05-04  Tom Tromey  <tom@tromey.com>
9950
9951         * arc-tdep.c (arc_tdesc_init): Return bool.
9952
9953 2019-05-04  Tom Tromey  <tom@tromey.com>
9954
9955         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9956         Use gdb_assert_not_reached.
9957
9958 2019-05-04  Tom Tromey  <tom@tromey.com>
9959
9960         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9961         "false".
9962
9963 2019-05-04  Tom Tromey  <tom@tromey.com>
9964
9965         * arc-tdep.c (arc_tdesc_init): Use bool.
9966
9967 2019-05-04  Tom Tromey  <tom@tromey.com>
9968
9969         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9970
9971 2019-05-04  Tom Tromey  <tom@tromey.com>
9972
9973         * cli/cli-cmds.c (valid_command_p): Return bool.
9974
9975 2019-05-04  Tom Tromey  <tom@tromey.com>
9976
9977         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9978         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9979
9980 2019-05-04  Raul Tambre  <raul@tambre.ee>
9981
9982         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9983         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9984         operator for comparison.
9985
9986 2019-05-04  Tom Tromey  <tom@tromey.com>
9987
9988         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9989         (lookup_partial_symbol, print_partial_symbols)
9990         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9991         (psymbol_compare): Update.
9992         (add_psymbol_to_bcache): Clear the entire psymbol.
9993         (maintenance_check_psymtabs): Update.
9994         * psympriv.h (struct partial_symbol): Don't derive from
9995         general_symbol_info.
9996         <obj_section, unrelocated_address, address,
9997         set_unrelocated_address>: Update.
9998         <ginfo>: New member.
9999         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10000         (debug_names::write_psymbols): Update.
10001
10002 2019-05-04  Tom de Vries  <tdevries@suse.de>
10003
10004         * contrib/cc-with-tweaks.sh: Support -n arg.
10005
10006 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10007
10008         * corelow.c (core_target::detach): Ensure frame cache and
10009         register caches are cleared.
10010         inferior.c (exit_inferior_1): Likewise.
10011
10012 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10013             Tom Tromey  <tom@tromey.com>
10014
10015         * dictionary.c (collate_pending_symbols_by_language): Remove
10016         "struct" from foreach.
10017         * symtab.c (lookup_global_symbol_from_objfile)
10018         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10019         foreach.
10020         * ser-tcp.c (net_open): Remove "struct" from foreach.
10021         * objfiles.c (objfile_relocate, objfile_rebase)
10022         (objfile_has_symbols): Remove "struct" from foreach.
10023         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10024         from foreach.
10025         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10026         foreach.
10027         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10028         "struct" from foreach.
10029         * ada-lang.c (create_excep_cond_exprs)
10030         (ada_exception_catchpoint_cond_string): Remove "struct" from
10031         foreach.
10032
10033 2019-05-03  Tom Tromey  <tromey@adacore.com>
10034
10035         * ada-exp.y (convert_char_literal): Check suffix of each
10036         enumerator.
10037
10038 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10039
10040         PR ada/21406:
10041         * ada-exp.y (yywrap): Don't define.
10042         * ada-lex.l (%option): Add noyywrap
10043         (yywrap): Remove.
10044
10045 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10046
10047         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10048         _WIN32_WINNT to the XP level, unless already defined to a higher
10049         level.
10050
10051         * unittests/parse-connection-spec-selftests.c:
10052         * ser-tcp.c:
10053         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10054         override.
10055
10056         * symfile.c (find_separate_debug_file): Remove colon from the
10057         drive spec of DOS/Windows file names of the target, so that the
10058         file name produced from DEBUGDIR and the target's directory will
10059         be valid on DOS/Windows systems.
10060
10061 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10062
10063         * rust-lang.c (val_print_struct): Handle printing structures
10064         containing strings.
10065
10066 2019-05-02  Tom Tromey  <tromey@adacore.com>
10067
10068         * valarith.c (_initialize_valarith): Remove.
10069
10070 2019-05-01  Tom Tromey  <tromey@adacore.com>
10071
10072         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10073         bitfields.
10074
10075 2019-05-01  Tom Tromey  <tromey@adacore.com>
10076
10077         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10078         for big-endian copies.
10079
10080 2019-04-30  Ali Tamur  <tamur@google.com>
10081         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10082         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10083         (read_3_bytes): New function.
10084
10085 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10086
10087         * windows-nat.c (main_thread_id): Delete.
10088         (handle_output_debug_string): Replace main_thread_id by
10089         current_event.dwThreadId.
10090         (fake_create_process): Likewise.
10091         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10092         Do not set main_thread_id.
10093         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10094         current_event.dwThreadId.
10095         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10096
10097 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10098
10099         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10100         Use current_event.dwThreadId instead of main_thread_id.
10101
10102 2019-04-30  Tom Tromey  <tromey@adacore.com>
10103
10104         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10105         (create_excep_cond_exprs): Iterate over program spaces.
10106         (ada_exception_catchpoint_cond_string): Examine all minimal
10107         symbols for exception types.
10108
10109 2019-04-30  Tom Tromey  <tromey@adacore.com>
10110
10111         PR c++/24470:
10112         * dwarf2read.c (process_structure_scope): Handle case where type
10113         has template parameters but no symbol was created.
10114
10115 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10116             Chris January  <chris.january@arm.com>
10117
10118         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10119         qualifier.
10120         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10121
10122 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10123
10124         * f-typeprint.c (f_print_type): Update rules for printing
10125         whitespace.
10126         (f_type_print_varspec_suffix): Likewise.
10127
10128 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10129             Chris January  <chris.january@arm.com>
10130
10131         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10132         function arguments.
10133
10134 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10135
10136         * f-lang.c (build_fortran_types): Change name of void type to
10137         lower case.
10138         * f-typeprint.c (f_type_print_base): Print the name of the void
10139         type, rather than a fixed string.
10140         * f-valprint.c (f_decorations): Use lower case void string.
10141
10142 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10143             Chris January  <chris.january@arm.com>
10144
10145         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10146         types for Fortran.
10147
10148 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10149             Chris January  <chris.january@arm.com>
10150             David Lecomber  <david.lecomber@arm.com>
10151
10152         * f-exp.y (BINOP_INTRINSIC): New token.
10153         (exp): New parser rule handling BINOP_INTRINSIC.
10154         (f77_keywords): Add new builtin procedures.
10155         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10156         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10157         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10158         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10159         (print_unop_subexp_f): New function.
10160         (print_binop_subexp_f): New function.
10161         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10162         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10163         (dump_subexp_body_f): Likewise.
10164         (operator_check_f): Likewise.
10165         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10166         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10167
10168 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10169
10170         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10171         UNOP_KIND.
10172         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10173         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10174         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10175         (operator_length_f): New fuction.
10176         (print_subexp_f): New function.
10177         (op_name_f): New function.
10178         (dump_subexp_body_f): New function.
10179         (operator_check_f): New function.
10180         (exp_descriptor_f): Replace standard expression handling functions
10181         with new functions.
10182         * gdb/fortran-operator.def: New file.
10183         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10184         * gdb/std-operator.def: Remove UNOP_KIND.
10185
10186 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10187
10188         * std-operator.def: Remove unbalanced, stray double quote
10189         character.
10190
10191 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10192             Chris January  <chris.january@arm.com>
10193             Daniel Everett  <daniel.everett@arm.com>
10194             Nick Forrington  <nick.forrington@arm.com>
10195             Richard Bunt  <richard.bunt@arm.com>
10196
10197         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10198         of depth when printing anonymous structs or unions.
10199         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10200         Don't print either the top-level value, or the children if the
10201         max-depth is exceeded.
10202         (ppscm_print_children): When printing the key of a map, allow one
10203         extra level of depth.
10204         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10205         print either the top-level value, or the children if the max-depth
10206         is exceeded.
10207         (print_children): When printing the key of a map, allow one extra
10208         level of depth.
10209         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10210         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10211         (user_print_options): Initialise max_depth field.
10212         (val_print_scalar_or_string_type_p): New function.
10213         (val_print): Check to see if the max depth has been reached.
10214         (val_print_check_max_depth): Define new function.
10215         (show_print_max_depth): New function.
10216         (_initialize_valprint): Add 'print max-depth' option.
10217         * valprint.h (struct value_print_options) <max_depth>: New field.
10218         (val_print_check_max_depth): Declare new function.
10219         * NEWS: Document new feature.
10220
10221 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10222
10223         * ada-lang.c (ada_language_defn): Initialise new field.
10224         * c-lang.c (c_is_string_type_p): New function.
10225         (c_language_defn): Initialise new field.
10226         (cplus_language_defn): Initialise new field.
10227         (asm_language_defn): Initialise new field.
10228         (minimal_language_defn): Initialise new field.
10229         * c-lang.h (c_is_string_type_p): Declare new function.
10230         * d-lang.c (d_language_defn): Initialise new field.
10231         * f-lang.c (f_is_string_type_p): New function.
10232         (f_language_defn): Initialise new field.
10233         * go-lang.c (go_is_string_type_p): New function.
10234         (go_language_defn): Initialise new field.
10235         * language.c (default_is_string_type_p): New function.
10236         (unknown_language_defn): Initialise new field.
10237         (auto_language_defn): Initialise new field.
10238         * language.h (struct language_defn) <la_is_string_type_p>: New
10239         member variable.
10240         (default_is_string_type_p): Declare new function.
10241         * m2-lang.c (m2_language_defn): Initialise new field.
10242         * objc-lang.c (objc_language_defn): Initialise new field.
10243         * opencl-lang.c (opencl_language_defn): Initialise new field.
10244         * p-lang.c (pascal_is_string_type_p): New function.
10245         (pascal_language_defn): Initialise new field.
10246         * rust-lang.c (rust_is_string_type_p): New function.
10247         (rust_language_defn): Initialise new field.
10248
10249 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10250
10251         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10252         New field.
10253         * ada-lang.c (ada_language_defn): Initialise new field.
10254         * c-lang.c (c_language_defn): Likewise.
10255         (cplus_language_defn): Likewise.
10256         (asm_language_defn): Likewise.
10257         (minimal_language_defn): Likewise.
10258         * d-lang.c (d_language_defn): Likewise.
10259         * f-lang.c (f_language_defn): Likewise.
10260         * go-lang.c (go_language_defn): Likewise.
10261         * language.c (unknown_language_defn): Likewise.
10262         (auto_language_defn): Likewise.
10263         * m2-lang.c (m2_language_defn): Likewise.
10264         * objc-lang.c (objc_language_defn): Likewise.
10265         * opencl-lang.c (opencl_language_defn): Likewise.
10266         * p-lang.c (pascal_language_defn): Likewise.
10267         * rust-lang.c (rust_language_defn): Likewise.
10268
10269 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10270
10271         * ada-lang.c (ada_is_character_type): Change return type to bool.
10272         (ada_is_string_type): Likewise.
10273         * ada-lang.h (ada_is_character_type): Update declaration
10274         (ada_is_string_type): Likewise.
10275
10276 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10277
10278         Support style in 'frame|thread apply'
10279
10280         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10281         * record.c (record_start, record_stop): Update callers of
10282         execute_command_to_string with false.
10283         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10284         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10285         methods.
10286         (class string_file): New constructor with term_out parameter.
10287         Override methods term_out and can_emit_style_escape.  New member
10288         term_out.
10289         (class stdio_file): Override can_emit_style_escape.
10290         (class tee_file): Override term_out and can_emit_style_escape.
10291         * utils.h (can_emit_style_escape): Remove.
10292         * utils.c (can_emit_style_escape): Likewise.
10293         Update all callers of can_emit_style_escape (SOMESTREAM) to
10294         SOMESTREAM->can_emit_style_escape.
10295         * source-cache.c (source_cache::get_source_lines): Likewise.
10296         * stack.c (frame_apply_command_count): Call execute_command_to_string
10297         passing the term_out characteristic of the current gdb_stdout.
10298         * thread.c (thr_try_catch_cmd): Likewise.
10299         * top.c (execute_command_to_string): pass term_out parameter
10300         to construct the string_file for the command output.
10301         * ui-file.c (term_cli_styling): New function (most code moved
10302         from utils.c can_emit_style_escape).
10303         (string_file::string_file, string_file::can_emit_style_escape,
10304         stdio_file::can_emit_style_escape, tee_file::term_out,
10305         tee_file::can_emit_style_escape): New functions.
10306
10307 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10308
10309         * NEWS: Mention the new set|show may-call-functions.
10310         * infcall.c (may_call_functions_p): New variable.
10311         (show_may_call_functions_p): New function.
10312         (call_function_by_hand_dummy): Throws an error if not
10313         may-call-functions.
10314         (_initialize_infcall): Call add_setshow_boolean_cmd for
10315         may-call-functions.
10316
10317 2019-04-25  Keith Seitz  <keiths@redhat.com>
10318
10319         PR c++/24367
10320         * cp-support.c (inspect_type): Don't attempt substitutions
10321         of symbol with the same name.
10322
10323 2019-04-25  Tom Tromey  <tromey@adacore.com>
10324
10325         PR gdb/24475:
10326         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10327         static.
10328
10329 2019-04-25  Tom Tromey  <tromey@adacore.com>
10330
10331         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10332         rvalue reference.
10333         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10334         (gdb_xml_parser::parse): Use std::move.
10335         * python/python-internal.h (gdbpy_convert_exception): Take a const
10336         reference.
10337         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10338         std::move.
10339         * python/py-utils.c (gdbpy_convert_exception): Take a const
10340         reference.
10341         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10342         Use std::move.
10343         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10344         Use std::move.
10345         * mi/mi-main.c (mi_print_exception): Take a const reference.
10346         * main.c (handle_command_errors): Take a const reference.
10347         * linespec.c (parse_linespec): Use std::move.
10348         * infcall.c (run_inferior_call): Use std::move.
10349         (call_function_by_hand_dummy): Use std::move.
10350         * exec.c (try_open_exec_file): Use std::move.
10351         * exceptions.h (exception_print, exception_fprintf)
10352         (exception_print_same): Update.
10353         * exceptions.c (print_exception, exception_print)
10354         (exception_fprintf, exception_print_same): Change parameters to
10355         const reference.
10356         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10357         * common/new-op.c: Use std::move.
10358         * common/common-exceptions.h (struct gdb_exception): Add move
10359         constructor.
10360         (struct gdb_exception_error, struct gdb_exception_quit, struct
10361         gdb_quit_bad_alloc): Change constructor to move constructor.
10362         (throw_exception): Change parameter to rvalue reference.
10363         * common/common-exceptions.c (throw_exception): Take rvalue
10364         reference.
10365         * cli/cli-interp.c (safe_execute_command): Use std::move.
10366         * breakpoint.c (insert_bp_location, location_to_sals): Use
10367         std::move.
10368
10369 2019-04-25  Tom Tromey  <tromey@adacore.com>
10370
10371         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10372         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10373         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10374         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10375         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10376         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10377         guile/scm-value.c: Use unpack.
10378         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10379         gdbscm_gdb_exception.
10380         (gdbscm_throw_gdb_exception): Likewise.
10381         (struct gdbscm_gdb_exception): New.
10382         (unpack): New function.
10383         (gdbscm_wrap): Use unpack.
10384
10385 2019-04-25  Tom Tromey  <tromey@adacore.com>
10386
10387         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10388         (gdb_rl_callback_handler): Use std::move.
10389         * common/common-exceptions.h (struct gdb_exception): Add move
10390         assignment operator.
10391         (throw_exception_sjlj): Change "exception" to const reference.
10392         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10393         (throw_exception_sjlj): Change "exception" to const reference.
10394
10395 2019-04-25  Tom Tromey  <tromey@adacore.com>
10396
10397         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10398         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10399         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10400         Update.
10401         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10402         Update.
10403         * mi/mi-interp.c (mi_interp::exec): Update.
10404         * linespec.c (parse_linespec): Update.
10405         * infcall.c (run_inferior_call): Update.
10406         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10407         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10408         (gdbscm_lookup_global_symbol): Update.
10409         * guile/scm-param.c (gdbscm_parameter_value): Update.
10410         * guile/scm-frame.c (gdbscm_frame_read_register)
10411         (gdbscm_frame_read_var): Update.
10412         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10413         * exec.c (try_open_exec_file): Update.
10414         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10415         (gdb_rl_callback_handler): Update.
10416         * common/common-exceptions.h (exception_none): Don't declare.
10417         * common/common-exceptions.c (exception_none): Don't define.
10418         (struct catcher) <exception>: Update.
10419         * cli/cli-interp.c (safe_execute_command): Update.
10420         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10421
10422 2019-04-25  Ali Tamur  <tamur@google.com>
10423
10424         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10425         (read_attribute_value): Likewise.
10426         (dwarf2_read_addr_index): Update comment.
10427         (read_str_index): Add DW_FORM_strx.
10428         (dwarf2_string_attr): Likewise.
10429         (dwarf2_const_value_attr): Likewise.
10430         (dump_die_shallow): Likewise.
10431         (dwarf2_fetch_constant_bytes): Likewise.
10432         (skip_form_bytes): Likewise.
10433         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10434
10435 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10436
10437         PR corefiles/11608
10438         PR corefiles/18187
10439         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10440         OFFSET.  Verify if current mapping contains an ELF header.
10441         (linux_find_memory_regions_full): Adjust call to
10442         dump_mapping_p.
10443
10444 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10445             Kang Li <kanglictf@gmail.com>
10446
10447         PR gdb/21600
10448
10449         * dwarf2-frame.c (read_initial_length): Be consistent about using
10450         unsigned representation of length.
10451         (decode_frame_entry_1): Likewise.  Check for wraparound of
10452         end pointer as well as buffer overflow.
10453
10454 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10455
10456         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10457         "vq".
10458
10459 2019-04-24  Tom Tromey  <tromey@adacore.com>
10460
10461         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10462
10463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10464
10465         * s12z-tdep.c (s12z_unwind_pc): Delete.
10466         (s12z_unwind_sp): Delete.
10467         (s12z_gdbarch_init): Don't register deleted functions with
10468         gdbarch.
10469
10470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10471
10472         * rl78-tdep.c (rl78_unwind_sp): Delete.
10473         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10474
10475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10476
10477         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10478         (xstormy16_unwind_pc): Delete.
10479         (xstormy16_dummy_id): Delete.
10480         (xstormy16_gdbarch_init): Don't register deleted functions with
10481         gdbarch.
10482
10483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10484
10485         * vax-tdep.c (vax_unwind_pc): Delete.
10486         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10487
10488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10489
10490         * v850-tdep.c (v850_unwind_sp): Delete.
10491         (v850_unwind_pc): Delete.
10492         (v850_dummy_id): Delete.
10493         (v850_gdbarch_init): Don't register deleted functions with
10494         gdbarch.
10495
10496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10497
10498         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10499         (tilegx_unwind_pc): Delete.
10500         (tilegx_unwind_dummy_id): Delete.
10501         (tilegx_gdbarch_init): Don't register deleted functions with
10502         gdbarch.
10503
10504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10505
10506         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10507         (tic6x_dummy_id): Delete.
10508         (tic6x_gdbarch_init): Don't register deleted functions with
10509         gdbarch.
10510
10511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10512
10513         * sparc-tdep.c (sparc_unwind_pc): Delete.
10514         (sparc32_gdbarch_init): Don't register deleted function with
10515         gdbarch.
10516
10517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10518
10519         * sh-tdep.c (sh_unwind_sp): Delete.
10520         (sh_unwind_pc): Delete.
10521         (sh_dummy_id): Delete.
10522         (sh_gdbarch_init): Don't register deleted functions with
10523         gdbarch.
10524
10525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10526
10527         * score-tdep.c (score_unwind_sp): Delete.
10528         (score_unwind_pc): Delete.
10529         (score_dummy_id): Delete.
10530         (score_gdbarch_init): Don't register deleted functions with
10531         gdbarch.
10532
10533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10534
10535         * rx-tdep.c (rx_unwind_pc): Delete.
10536         (rx_unwind_sp): Delete.
10537         (rx_dummy_id): Delete.
10538         (rx_gdbarch_init): Don't register deleted functions with
10539         gdbarch.  Update comment.
10540
10541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10542
10543         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10544         (rs6000_dummy_id): Delete.
10545         (rs6000_gdbarch_init): Don't register deleted functions with
10546         gdbarch.
10547
10548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10549
10550         * or1k-tdep.c (or1k_dummy_id): Delete.
10551         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10552
10553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10554
10555         * nios2-tdep.c (nios2_dummy_id): Delete.
10556         (nios2_unwind_sp): Delete.
10557         (nios2_gdbarch_init): Don't register deleted functions with
10558         gdbarch.
10559
10560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10561
10562         * nds32-tdep.c (nds32_dummy_id): Delete.
10563         (nds32_unwind_pc): Delete.
10564         (nds32_unwind_sp): Delete.
10565         (nds32_gdbarch_init): Don't register deleted functions with
10566         gdbarch.
10567
10568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10569
10570         * msp430-tdep.c (msp430_unwind_pc): Delete.
10571         (msp430_unwind_sp): Delete.
10572         (msp430_dummy_id): Delete.
10573         (msp430_gdbarch_init): Don't register deleted functions with
10574         gdbarch.
10575
10576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10577
10578         * moxie-tdep.c (moxie_unwind_sp): Delete.
10579         (moxie_unwind_pc): Delete.
10580         (moxie_dummy_id): Delete.
10581         (moxie_gdbarch_init): Don't register deleted functions with
10582         gdbarch.
10583
10584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10585
10586         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10587         (mn10300_unwind_pc): Delete.
10588         (mn10300_unwind_sp): Delete.
10589         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10590         mn10300_unwind_sp.
10591         (mn10300_frame_unwind_init): Don't register deleted functions with
10592         gdbarch.
10593
10594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10595
10596         * mep-tdep.c (mep_unwind_pc): Delete.
10597         (mep_unwind_sp): Delete.
10598         (mep_dummy_id): Delete.
10599         (mep_gdbarch_init): Don't register deleted functions with
10600         gdbarch.
10601
10602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10603
10604         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10605         (m68hc11_unwind_sp): Delete.
10606         (m68hc11_gdbarch_init): Don't register deleted functions with
10607         gdbarch.
10608
10609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10610
10611         * m32r-tdep.c (m32r_unwind_sp): Delete.
10612         (m32r_unwind_pc): Delete.
10613         (m32r_dummy_id): Delete.
10614         (m32r_gdbarch_init): Don't register deleted functions with
10615         gdbarch.
10616
10617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10618
10619         * m32c-tdep.c (m32c_unwind_pc): Delete.
10620         (m32c_unwind_sp): Delete.
10621         (m32c_dummy_id): Delete.
10622         (m32c_gdbarch_init): Don't register deleted functions with
10623         gdbarch.
10624
10625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10626
10627         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10628         (lm32_unwind_pc): Delete.
10629         (lm32_dummy_id): Delete.
10630         (lm32_gdbarch_init): Don't register deleted functions with
10631         gdbarch.
10632
10633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10634
10635         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10636         (iq2000_unwind_pc): Delete.
10637         (iq2000_dummy_id): Delete.
10638         (iq2000_gdbarch_init): Don't register deleted functions with
10639         gdbarch.
10640
10641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10642
10643         * nds32-tdep.c (nds32_type_align): Delete.
10644         (nds32_push_dummy_call): Use type_align instead.
10645
10646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10647
10648         * arm-tdep.c (arm_type_align): Only handle vector override case.
10649         (arm_push_dummy_call): Use type_align.
10650         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10651
10652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10653
10654         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10655         case.
10656         (pass_on_stack): Use type_align.
10657         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10658         function.
10659
10660 2019-04-23  Tom Tromey  <tromey@adacore.com>
10661
10662         * dwarf2read.c (line_header::file_name_at): Remove unused
10663         overload.
10664
10665 2019-04-23  Tom de Vries  <tdevries@suse.de>
10666
10667         PR gdb/24438
10668         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10669         invocation.
10670
10671
10672 2019-03-27  Ali Tamur  <tamur@google.com>
10673
10674         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10675         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10676         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10677         (dwarf_expr_context::get_addr_index): Likewise
10678         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10679         (symbol_needs_eval_context::get_addr_index): Likewise
10680         (disassemble_dwarf_expression): Add DW_OP_addrx
10681         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10682         (read_cutu_die_from_dwo): Update comment
10683         (skip_one_die): Add DW_FORM_addrx
10684         (read_attribute_value): Likewise
10685         (var_decode_location): Add DW_OP_addrx
10686         (dwarf2_const_value_attr): Add DW_FORM_addrx
10687         (dump_die_shallow): Likewise
10688         (dwarf2_fetch_constant_bytes): Likewise
10689         (decode_locdesc): Add DW_OP_addrx
10690         (skip_form_bytes): Add DW_FORM_addrx
10691
10692 2019-04-22  Ali Tamur  <tamur@google.com>
10693
10694         * MAINTAINERS (Write After Approval): Add self.
10695
10696 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10697
10698         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10699         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10700         (open_symbol_file_object): Likewise.
10701         (svr4_default_sos): Add info parameter.
10702         (svr4_read_so_list): Likewise.
10703         (svr4_current_sos_direct): Adjust functions calls to pass down
10704         info.
10705         (svr4_current_sos_1): Add info parameter.
10706         (svr4_current_sos): Call get_svr4_info, pass info down to
10707         svr4_current_sos_1.
10708         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10709         get_svr4_info.
10710         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10711         get_svr4_info.
10712         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10713         to get_svr4_info.
10714         (probes_table_remove_objfile_probes): Likewise.
10715         (register_solib_event_probe): Add info parameter.
10716         (solist_update_incremental): Pass info parameter down to
10717         svr4_read_so_list.
10718         (disable_probes_interface): Add info parameter.
10719         (svr4_handle_solib_event): Pass current_program_space to
10720         get_svr4_info.  Adjust disable_probes_interface cleanup.
10721         (svr4_create_probe_breakpoints): Add info parameter, pass it
10722         down to register_solib_event_probe.
10723         (svr4_create_solib_event_breakpoints): Add info parameter,
10724         pass it down to svr4_create_probe_breakpoints.
10725         (enable_break): Pass info down to
10726         svr4_create_solib_event_breakpoints.
10727         (svr4_solib_create_inferior_hook): Pass current_program_space to
10728         get_svr4_info.
10729         (svr4_clear_solib): Likewise.
10730
10731 2019-04-22  Pedro Alves  <palves@redhat.com>
10732
10733         * solib-svr4.c (svr4_free_objfile_observer): New.
10734         (probe_and_action::objfile): New field.
10735         (probes_table_htab_remove_objfile_probes)
10736         (probes_table_remove_objfile_probes): New functions.
10737         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10738         in the new probe_and_action.  Don't store the probe in 'lookup'.
10739         (svr4_create_probe_breakpoints): Pass objfile to
10740         register_solib_event_probe.
10741         (_initialize_svr4_solib): Register a free_objfile observer.
10742
10743 2019-04-19  Tom Tromey  <tom@tromey.com>
10744
10745         * common/queue.h: Remove.
10746
10747 2019-04-19  Tom Tromey  <tom@tromey.com>
10748
10749         * event-loop.c: Don't include "common/queue.h".
10750
10751 2019-04-19  Tom Tromey  <tom@tromey.com>
10752
10753         * remote.c (remote_target): Use delete.
10754         * remote-notif.h: Include <list>, not "common/queue.h".
10755         (notif_client_p): Remove typedef.
10756         (remote_notif_state): Add constructor, destructor, initializer.
10757         <notif_queue>: Now a std::list.
10758         (remote_notif_state_xfree): Don't declare.
10759         * remote-notif.c (remote_notif_process, handle_notification)
10760         (remote_notif_state_allocate): Update.
10761         (~remote_notif_state): Rename from remote_notif_state_xfree.
10762
10763 2019-04-19  Tom Tromey  <tom@tromey.com>
10764
10765         * symfile.c (reread_symbols): Update.
10766         * objfiles.c (objfile_register_static_link)
10767         (objfile_lookup_static_link): Update
10768         (~objfile) Don't delete static_links.
10769         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10770
10771 2019-04-19  Tom Tromey  <tom@tromey.com>
10772
10773         * type-stack.h (struct type_stack) <insert>: Constify string.
10774         * type-stack.c (type_stack::insert): Constify string.
10775         * gdbtypes.h (lookup_template_type): Update.
10776         (address_space_name_to_int): Update.
10777         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10778         const.
10779         (lookup_template_type): Make name const.
10780         * c-exp.y: Update rules.
10781         (lex_one_token, classify_name, classify_inner_name)
10782         (c_print_token): Update.
10783         * p-exp.y: Update rules.
10784         (yylex): Update.
10785         * f-exp.y: Update rules.
10786         (yylex): Update.
10787         * d-exp.y: Update rules.
10788         (lex_one_token, classify_name, classify_inner_name): Update.
10789         * parse.c (write_dollar_variable, copy_name): Return std::string.
10790         * parser-defs.h (copy_name): Change return type.
10791         * m2-exp.y: Update rules.
10792         (yylex): Update.
10793         * go-exp.y (lex_one_token): Update.
10794         Update rules.
10795         (classify_unsafe_function, classify_packaged_name)
10796         (classify_name, yylex): Update.
10797
10798 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10799
10800         * configure.ac: add --enable-source-highlight switch.
10801         * configure: Regenerate.
10802         * top.c (print_gdb_version): plumb --enable-source-highlight
10803         status to "show configuration".
10804
10805 2019-04-19  Tom Tromey  <tromey@adacore.com>
10806
10807         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10808         Check ADA_TYPE_P.
10809         (empty_record, ada_template_to_fixed_record_type_1)
10810         (template_to_static_fixed_type)
10811         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10812         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10813         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10814         macros.
10815
10816 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10817
10818         PR symtab/24423:
10819         * source.c (print_source_lines_base): Advance "iter" when a
10820         control character is seen.
10821
10822 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10823
10824         * inferior.h (struct infcall_suspend_state_deleter):
10825         Catch exception in destructor to avoid crash.
10826
10827 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10828
10829         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10830         close to the add_com "shell".
10831
10832 2019-04-18  Tom Tromey  <tromey@adacore.com>
10833
10834         * process-stratum-target.h (class process_stratum_target)
10835         <stratum>: Add "final".
10836
10837 2019-04-17  Tom Tromey  <tromey@adacore.com>
10838
10839         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10840         against nullptr before use.
10841
10842 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10843
10844         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10845
10846 2019-04-17  Jim Wilson  <jimw@sifive.com>
10847             Andrew Burgess  <andrew.burgess@embecosm.com>
10848
10849         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10850         code read might fail, assume 4-byte breakpoint in that case.
10851
10852 2019-04-15  Leszek Swirski  <leszeks@google.com>
10853
10854         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10855         rather than a hand-rolled POD check when checking for forced MEMORY
10856         classification.
10857
10858 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10859
10860         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10861         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10862         function.
10863         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10864         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10865         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10866         declaration.
10867
10868 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10869
10870         * aarch64-linux-nat.c
10871         (aarch64_linux_nat_target::thread_architecture): Add override.
10872         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10873         each VQ.
10874
10875 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10876
10877         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10878
10879 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10880
10881         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10882         target types of size 96-bits, add some additional comments, and
10883         check that the builtin type we found was the correct size.
10884
10885 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10886
10887         * utils.c (prompt_for_continue): Don't restore the styling at the
10888         end, as applied_style has the wrong value.  This fixes styling in
10889         long lists of file names that are interrupted by the "Continue?"
10890         prompt.
10891
10892 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10893
10894         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10895         * c-lang.c (c_language_defn): Likewise.
10896         (cplus_language_defn): Likewise.
10897         (asm_language_defn): Likewise.
10898         (minimal_language_defn): Likewise.
10899         * d-lang.c (d_language_defn): Likewise.
10900         * f-lang.c (f_language_defn): Likewise.
10901         * go-lang.c (go_language_defn): Likewise.
10902         * language.c (unknown_language_defn): Likewise.
10903         (auto_language_defn): Likewise.
10904         * language.h (struct language_defn): Remove la_magic field.
10905         (LANG_MAGIC): Delete.
10906         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10907         * objc-lang.c (objc_language_defn): Likewise.
10908         * opencl-lang.c (opencl_language_defn): Likewise.
10909         * p-lang.c (pascal_language_defn): Likewise.
10910         * rust-lang.c (rust_language_defn): Likewise.
10911
10912 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10913
10914         * riscv-tdep.c (riscv_type_align): New function.
10915         (riscv_type_alignment): Delete.
10916         (riscv_arg_location): Use 'type_align'.
10917         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10918
10919 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10920
10921         * gdbtypes.c (type_align): A struct with no non-static fields also
10922         has alignment of 1.
10923
10924 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10925
10926         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10927         component to 0.
10928         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10929         member.
10930         (riscv_struct_info::analyse): New implementation using new
10931         analyse_inner member function.
10932         (riscv_struct_info::field_offset): New member function.
10933         (riscv_struct_info::m_offsets): New member variable.
10934         (riscv_struct_info::analyse_inner): New private member function,
10935         takes the old implementation of riscv_struct_info::analyse but
10936         extended to track field offsets.
10937         (riscv_call_arg_struct): Update the struct folding special cases
10938         to handle cases where empty C++ structs, which are non-zero
10939         length, are found.
10940         (riscv_arg_location): Initialise the length of each location, a
10941         non-zero length now indicates the location is in use.
10942         (riscv_push_dummy_call): Allow for the first location having a
10943         non-zero offset when setting up arguments.
10944         (riscv_return_value): Likewise, but for return values.
10945
10946 2019-04-11  Tom Tromey  <tromey@adacore.com>
10947
10948         * utils.c (internal_vproblem): Make "msg" const.
10949
10950 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10951
10952         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10953         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10954         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10955         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10956
10957 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10958
10959         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10960         function.
10961         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10962         of amd64_collect_native_gregset.
10963         (amd64_linux_nat_target::store_registers): Likewise.
10964
10965 2019-04-10  Tom Tromey  <tom@tromey.com>
10966
10967         * symtab.c (lookup_global_symbol_from_objfile)
10968         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10969         * objfiles.h (class separate_debug_iterator): New.
10970         (class separate_debug_range): New.
10971         (struct objfile) <separate_debug_objfiles>: New method.
10972         (objfile_separate_debug_iterate): Don't declare.
10973         * objfiles.c (separate_debug_iterator::operator++): Rename from
10974         objfile_separate_debug_iterate.
10975         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10976         iterator.
10977         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10978         iterator.
10979
10980 2019-04-10  Tom Tromey  <tom@tromey.com>
10981
10982         * symfile.c (reread_symbols): Remove old comment.
10983         * objfiles.c (free_all_objfiles): Fix a typo.
10984
10985 2019-04-10  Tom Tromey  <tom@tromey.com>
10986
10987         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10988         * minsyms.c (lookup_minimal_symbol): Use foreach.
10989         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10990         (lookup_minimal_symbol_solib_trampoline): Likewise.
10991         * symfile.c (reread_symbols): Use foreach.
10992
10993 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10994             Tom Tromey  <tromey@adacore.com>
10995
10996         PR rust/24414:
10997         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10998         (rust_lex_int_test): Change "value" to be LONGEST.
10999         (rust_lex_tests): Add test for long integer literal.
11000
11001 2019-04-09  Tom Tromey  <tromey@adacore.com>
11002
11003         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11004         to bool.
11005         (extended_remote_target::attach): Update.
11006         (remote_target::remote_notice_new_inferior): Update.
11007         (remote_target::add_current_inferior_and_thread): Update.
11008         * inferior.c (exit_inferior_1): Use "false".
11009         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11010
11011 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11012
11013         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11014         the "start" command.
11015
11016 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11017
11018         * python/py-inferior.c (infpy_thread_from_thread_handle):
11019         Adjust comments to reflect renaming of thread_from_thread_handle
11020         to thread_from_handle.  Adjust keywords.  Fix type error message.
11021         (inferior_object_methods): Add thread_from_handle.  Retain
11022         thread_from_thread_handle, but mark it as deprecated.
11023
11024 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11025
11026         * gdbthread.h (find_thread_by_handle): Revise declaration.
11027         * thread.c (find_thread_by_handle): Likewise.  Adjust
11028         implementation too.
11029         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11030         support for buffer objects as handles.
11031
11032 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11033
11034         * python/py-infthread.c (thpy_thread_handle): New function.
11035         (thread_object_methods): Register thpy_thread_handle.
11036
11037 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11038
11039         * gdbthread.h (thread_to_thread_handle): Declare.
11040         * thread.c (gdbtypes.h): Include.
11041         (thread_to_thread_handle): New function.
11042
11043         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11044         (target_thread_info_to_thread_handle): Declare.
11045         * target.c (target_thread_info_to_thread_handle): New function.
11046         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11047         * target-delegates.c: Regenerate.
11048
11049         * linux-thread-db.c (class thread_db_target): Add method
11050         thread_info_to_thread_handle.
11051         (thread_db_target::thread_info_to_thread_handle): Define.
11052         * remote.c (class remote_target): Add new method
11053         thread_info_to_thread_handle.
11054         (remote_target::thread_info_to_thread_handle): Define.
11055
11056 2019-04-08  Pedro Alves  <palves@redhat.com>
11057
11058         * common/common-exceptions.c (throw_exception): Don't create
11059         named object to throw; throw directly.
11060         (throw_it): Likewise.  Don't initialize gdb_exception::message
11061         here, with new; pass FMT and AP to the ctor instead.
11062         * common/common-exceptions.h: Include <string>.
11063         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11064         const char *, va_list)): New ctor.  Use std::make_shared.
11065         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11066         errors)): Delete.
11067         (gdb_exception_error::gdb_exception_error(enum errors, const char
11068         *, va_list)): New.
11069         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11070         Add assertion.
11071         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11072         errors)): Delete.
11073         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11074         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11075         Add assertion.
11076
11077 2019-04-08  Tom Tromey  <tom@tromey.com>
11078
11079         * valops.c (value_rtti_indirect_type): Replace throw_exception
11080         with throw.
11081         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11082         with throw.
11083         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11084         throw.
11085         * target.c (target_translate_tls_address): Replace throw_exception
11086         with throw.
11087         * stack.c (frame_apply_command_count): Replace throw_exception
11088         with throw.
11089         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11090         throw.
11091         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11092         with throw.
11093         * rs6000-tdep.c (rs6000_frame_cache)
11094         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11095         * remote.c: Replace throw_exception with throw.
11096         * record-full.c (record_full_message, record_full_wait_1)
11097         (record_full_restore): Replace throw_exception with throw.
11098         * record-btrace.c:
11099         (get_thread_current_frame_id, record_btrace_start_replaying)
11100         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11101         (cmd_record_btrace_start): Replace throw_exception with throw.
11102         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11103         throw.
11104         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11105         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11106         * linespec.c:
11107         (find_linespec_symbols): Replace throw_exception with throw.
11108         * infrun.c (displaced_step_prepare, resume): Replace
11109         throw_exception with throw.
11110         * infcmd.c (post_create_inferior): Replace throw_exception with
11111         throw.
11112         * inf-loop.c (inferior_event_handler): Replace throw_exception
11113         with throw.
11114         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11115         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11116         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11117         (get_prev_frame_always, get_frame_pc_if_available)
11118         (get_frame_address_in_block_if_available, get_frame_language):
11119         Replace throw_exception with throw.
11120         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11121         throw_exception with throw.
11122         * eval.c (fetch_subexp_value, evaluate_var_value)
11123         (evaluate_funcall, evaluate_subexp_standard): Replace
11124         throw_exception with throw.
11125         * dwarf2loc.c (call_site_find_chain)
11126         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11127         Replace throw_exception with throw.
11128         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11129         with throw.
11130         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11131         throw.
11132         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11133         * completer.c (complete_line_internal): Replace throw_exception
11134         with throw.
11135         * compile/compile-object-run.c (compile_object_run): Replace
11136         throw_exception with throw.
11137         * cli/cli-script.c (process_next_line): Replace throw_exception
11138         with throw.
11139         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11140         (btrace_enable, btrace_maint_update_pt_packets): Replace
11141         throw_exception with throw.
11142         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11143         throw_exception with throw.
11144         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11145         throw_exception with throw.
11146         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11147         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11148         * aarch64-tdep.c (aarch64_make_prologue_cache)
11149         (aarch64_make_stub_cache): Replace throw_exception with throw.
11150
11151 2019-04-08  Tom Tromey  <tom@tromey.com>
11152
11153         * common/common-exceptions.c (throw_exception): Rename from
11154         throw_exception_cxx.  Remove old copy.  Make argument const.
11155         (throw_it): Create and throw exception objects directly.
11156         * common/common-exceptions.h (throw_exception): Make argument
11157         const.
11158         (struct gdb_exception_error): Add constructor.
11159         (struct gdb_exception_quit): Add constructor.
11160
11161 2019-04-08  Tom Tromey  <tom@tromey.com>
11162
11163         * common/common-exceptions.h (exception_rethrow): Don't declare.
11164         (TRY_SJLJ): Update comment.
11165         (TRY, CATCH, END_CATCH): Remove.
11166         * common/common-exceptions.c (exception_rethrow): Remove.
11167
11168 2019-04-08  Tom Tromey  <tom@tromey.com>
11169
11170         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11171         Remove.
11172         (gdb_exception_error): Rename from
11173         gdb_exception_RETURN_MASK_ERROR.
11174         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11175         (gdb_quit_bad_alloc): Update.
11176         * aarch64-tdep.c: Update.
11177         * ada-lang.c: Update.
11178         * ada-typeprint.c: Update.
11179         * ada-valprint.c: Update.
11180         * amd64-tdep.c: Update.
11181         * arch-utils.c: Update.
11182         * break-catch-throw.c: Update.
11183         * breakpoint.c: Update.
11184         * btrace.c: Update.
11185         * c-varobj.c: Update.
11186         * cli/cli-cmds.c: Update.
11187         * cli/cli-interp.c: Update.
11188         * cli/cli-script.c: Update.
11189         * common/common-exceptions.c: Update.
11190         * common/new-op.c: Update.
11191         * common/selftest.c: Update.
11192         * compile/compile-c-symbols.c: Update.
11193         * compile/compile-cplus-symbols.c: Update.
11194         * compile/compile-object-load.c: Update.
11195         * compile/compile-object-run.c: Update.
11196         * completer.c: Update.
11197         * corelow.c: Update.
11198         * cp-abi.c: Update.
11199         * cp-support.c: Update.
11200         * cp-valprint.c: Update.
11201         * darwin-nat.c: Update.
11202         * disasm-selftests.c: Update.
11203         * dtrace-probe.c: Update.
11204         * dwarf-index-cache.c: Update.
11205         * dwarf-index-write.c: Update.
11206         * dwarf2-frame-tailcall.c: Update.
11207         * dwarf2-frame.c: Update.
11208         * dwarf2loc.c: Update.
11209         * dwarf2read.c: Update.
11210         * eval.c: Update.
11211         * event-loop.c: Update.
11212         * event-top.c: Update.
11213         * exec.c: Update.
11214         * f-valprint.c: Update.
11215         * fbsd-tdep.c: Update.
11216         * frame-unwind.c: Update.
11217         * frame.c: Update.
11218         * gdbtypes.c: Update.
11219         * gnu-v3-abi.c: Update.
11220         * guile/guile-internal.h: Update.
11221         * guile/scm-block.c: Update.
11222         * guile/scm-breakpoint.c: Update.
11223         * guile/scm-cmd.c: Update.
11224         * guile/scm-disasm.c: Update.
11225         * guile/scm-frame.c: Update.
11226         * guile/scm-lazy-string.c: Update.
11227         * guile/scm-math.c: Update.
11228         * guile/scm-param.c: Update.
11229         * guile/scm-ports.c: Update.
11230         * guile/scm-pretty-print.c: Update.
11231         * guile/scm-symbol.c: Update.
11232         * guile/scm-symtab.c: Update.
11233         * guile/scm-type.c: Update.
11234         * guile/scm-value.c: Update.
11235         * i386-linux-tdep.c: Update.
11236         * i386-tdep.c: Update.
11237         * inf-loop.c: Update.
11238         * infcall.c: Update.
11239         * infcmd.c: Update.
11240         * infrun.c: Update.
11241         * jit.c: Update.
11242         * language.c: Update.
11243         * linespec.c: Update.
11244         * linux-fork.c: Update.
11245         * linux-nat.c: Update.
11246         * linux-tdep.c: Update.
11247         * linux-thread-db.c: Update.
11248         * main.c: Update.
11249         * mi/mi-cmd-break.c: Update.
11250         * mi/mi-cmd-stack.c: Update.
11251         * mi/mi-interp.c: Update.
11252         * mi/mi-main.c: Update.
11253         * objc-lang.c: Update.
11254         * p-valprint.c: Update.
11255         * parse.c: Update.
11256         * ppc-linux-tdep.c: Update.
11257         * printcmd.c: Update.
11258         * python/py-arch.c: Update.
11259         * python/py-breakpoint.c: Update.
11260         * python/py-cmd.c: Update.
11261         * python/py-finishbreakpoint.c: Update.
11262         * python/py-frame.c: Update.
11263         * python/py-framefilter.c: Update.
11264         * python/py-gdb-readline.c: Update.
11265         * python/py-inferior.c: Update.
11266         * python/py-infthread.c: Update.
11267         * python/py-lazy-string.c: Update.
11268         * python/py-linetable.c: Update.
11269         * python/py-objfile.c: Update.
11270         * python/py-param.c: Update.
11271         * python/py-prettyprint.c: Update.
11272         * python/py-progspace.c: Update.
11273         * python/py-record-btrace.c: Update.
11274         * python/py-record.c: Update.
11275         * python/py-symbol.c: Update.
11276         * python/py-type.c: Update.
11277         * python/py-unwind.c: Update.
11278         * python/py-utils.c: Update.
11279         * python/py-value.c: Update.
11280         * python/python.c: Update.
11281         * record-btrace.c: Update.
11282         * record-full.c: Update.
11283         * remote-fileio.c: Update.
11284         * remote.c: Update.
11285         * riscv-tdep.c: Update.
11286         * rs6000-aix-tdep.c: Update.
11287         * rs6000-tdep.c: Update.
11288         * rust-exp.y: Update.
11289         * rust-lang.c: Update.
11290         * s390-tdep.c: Update.
11291         * selftest-arch.c: Update.
11292         * solib-dsbt.c: Update.
11293         * solib-frv.c: Update.
11294         * solib-spu.c: Update.
11295         * solib-svr4.c: Update.
11296         * solib.c: Update.
11297         * sparc64-linux-tdep.c: Update.
11298         * stack.c: Update.
11299         * symfile-mem.c: Update.
11300         * symmisc.c: Update.
11301         * target.c: Update.
11302         * thread.c: Update.
11303         * top.c: Update.
11304         * tracefile-tfile.c: Update.
11305         * tui/tui.c: Update.
11306         * typeprint.c: Update.
11307         * unittests/cli-utils-selftests.c: Update.
11308         * unittests/parse-connection-spec-selftests.c: Update.
11309         * valops.c: Update.
11310         * valprint.c: Update.
11311         * value.c: Update.
11312         * varobj.c: Update.
11313         * windows-nat.c: Update.
11314         * x86-linux-nat.c: Update.
11315         * xml-support.c: Update.
11316
11317 2019-04-08  Tom Tromey  <tom@tromey.com>
11318
11319         * xml-support.c: Use C++ exception handling.
11320         * x86-linux-nat.c: Use C++ exception handling.
11321         * windows-nat.c: Use C++ exception handling.
11322         * varobj.c: Use C++ exception handling.
11323         * value.c: Use C++ exception handling.
11324         * valprint.c: Use C++ exception handling.
11325         * valops.c: Use C++ exception handling.
11326         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11327         handling.
11328         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11329         * typeprint.c: Use C++ exception handling.
11330         * tui/tui.c: Use C++ exception handling.
11331         * tracefile-tfile.c: Use C++ exception handling.
11332         * top.c: Use C++ exception handling.
11333         * thread.c: Use C++ exception handling.
11334         * target.c: Use C++ exception handling.
11335         * symmisc.c: Use C++ exception handling.
11336         * symfile-mem.c: Use C++ exception handling.
11337         * stack.c: Use C++ exception handling.
11338         * sparc64-linux-tdep.c: Use C++ exception handling.
11339         * solib.c: Use C++ exception handling.
11340         * solib-svr4.c: Use C++ exception handling.
11341         * solib-spu.c: Use C++ exception handling.
11342         * solib-frv.c: Use C++ exception handling.
11343         * solib-dsbt.c: Use C++ exception handling.
11344         * selftest-arch.c: Use C++ exception handling.
11345         * s390-tdep.c: Use C++ exception handling.
11346         * rust-lang.c: Use C++ exception handling.
11347         * rust-exp.y: Use C++ exception handling.
11348         * rs6000-tdep.c: Use C++ exception handling.
11349         * rs6000-aix-tdep.c: Use C++ exception handling.
11350         * riscv-tdep.c: Use C++ exception handling.
11351         * remote.c: Use C++ exception handling.
11352         * remote-fileio.c: Use C++ exception handling.
11353         * record-full.c: Use C++ exception handling.
11354         * record-btrace.c: Use C++ exception handling.
11355         * python/python.c: Use C++ exception handling.
11356         * python/py-value.c: Use C++ exception handling.
11357         * python/py-utils.c: Use C++ exception handling.
11358         * python/py-unwind.c: Use C++ exception handling.
11359         * python/py-type.c: Use C++ exception handling.
11360         * python/py-symbol.c: Use C++ exception handling.
11361         * python/py-record.c: Use C++ exception handling.
11362         * python/py-record-btrace.c: Use C++ exception handling.
11363         * python/py-progspace.c: Use C++ exception handling.
11364         * python/py-prettyprint.c: Use C++ exception handling.
11365         * python/py-param.c: Use C++ exception handling.
11366         * python/py-objfile.c: Use C++ exception handling.
11367         * python/py-linetable.c: Use C++ exception handling.
11368         * python/py-lazy-string.c: Use C++ exception handling.
11369         * python/py-infthread.c: Use C++ exception handling.
11370         * python/py-inferior.c: Use C++ exception handling.
11371         * python/py-gdb-readline.c: Use C++ exception handling.
11372         * python/py-framefilter.c: Use C++ exception handling.
11373         * python/py-frame.c: Use C++ exception handling.
11374         * python/py-finishbreakpoint.c: Use C++ exception handling.
11375         * python/py-cmd.c: Use C++ exception handling.
11376         * python/py-breakpoint.c: Use C++ exception handling.
11377         * python/py-arch.c: Use C++ exception handling.
11378         * printcmd.c: Use C++ exception handling.
11379         * ppc-linux-tdep.c: Use C++ exception handling.
11380         * parse.c: Use C++ exception handling.
11381         * p-valprint.c: Use C++ exception handling.
11382         * objc-lang.c: Use C++ exception handling.
11383         * mi/mi-main.c: Use C++ exception handling.
11384         * mi/mi-interp.c: Use C++ exception handling.
11385         * mi/mi-cmd-stack.c: Use C++ exception handling.
11386         * mi/mi-cmd-break.c: Use C++ exception handling.
11387         * main.c: Use C++ exception handling.
11388         * linux-thread-db.c: Use C++ exception handling.
11389         * linux-tdep.c: Use C++ exception handling.
11390         * linux-nat.c: Use C++ exception handling.
11391         * linux-fork.c: Use C++ exception handling.
11392         * linespec.c: Use C++ exception handling.
11393         * language.c: Use C++ exception handling.
11394         * jit.c: Use C++ exception handling.
11395         * infrun.c: Use C++ exception handling.
11396         * infcmd.c: Use C++ exception handling.
11397         * infcall.c: Use C++ exception handling.
11398         * inf-loop.c: Use C++ exception handling.
11399         * i386-tdep.c: Use C++ exception handling.
11400         * i386-linux-tdep.c: Use C++ exception handling.
11401         * guile/scm-value.c: Use C++ exception handling.
11402         * guile/scm-type.c: Use C++ exception handling.
11403         * guile/scm-symtab.c: Use C++ exception handling.
11404         * guile/scm-symbol.c: Use C++ exception handling.
11405         * guile/scm-pretty-print.c: Use C++ exception handling.
11406         * guile/scm-ports.c: Use C++ exception handling.
11407         * guile/scm-param.c: Use C++ exception handling.
11408         * guile/scm-math.c: Use C++ exception handling.
11409         * guile/scm-lazy-string.c: Use C++ exception handling.
11410         * guile/scm-frame.c: Use C++ exception handling.
11411         * guile/scm-disasm.c: Use C++ exception handling.
11412         * guile/scm-cmd.c: Use C++ exception handling.
11413         * guile/scm-breakpoint.c: Use C++ exception handling.
11414         * guile/scm-block.c: Use C++ exception handling.
11415         * guile/guile-internal.h: Use C++ exception handling.
11416         * gnu-v3-abi.c: Use C++ exception handling.
11417         * gdbtypes.c: Use C++ exception handling.
11418         * frame.c: Use C++ exception handling.
11419         * frame-unwind.c: Use C++ exception handling.
11420         * fbsd-tdep.c: Use C++ exception handling.
11421         * f-valprint.c: Use C++ exception handling.
11422         * exec.c: Use C++ exception handling.
11423         * event-top.c: Use C++ exception handling.
11424         * event-loop.c: Use C++ exception handling.
11425         * eval.c: Use C++ exception handling.
11426         * dwarf2read.c: Use C++ exception handling.
11427         * dwarf2loc.c: Use C++ exception handling.
11428         * dwarf2-frame.c: Use C++ exception handling.
11429         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11430         * dwarf-index-write.c: Use C++ exception handling.
11431         * dwarf-index-cache.c: Use C++ exception handling.
11432         * dtrace-probe.c: Use C++ exception handling.
11433         * disasm-selftests.c: Use C++ exception handling.
11434         * darwin-nat.c: Use C++ exception handling.
11435         * cp-valprint.c: Use C++ exception handling.
11436         * cp-support.c: Use C++ exception handling.
11437         * cp-abi.c: Use C++ exception handling.
11438         * corelow.c: Use C++ exception handling.
11439         * completer.c: Use C++ exception handling.
11440         * compile/compile-object-run.c: Use C++ exception handling.
11441         * compile/compile-object-load.c: Use C++ exception handling.
11442         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11443         * compile/compile-c-symbols.c: Use C++ exception handling.
11444         * common/selftest.c: Use C++ exception handling.
11445         * common/new-op.c: Use C++ exception handling.
11446         * cli/cli-script.c: Use C++ exception handling.
11447         * cli/cli-interp.c: Use C++ exception handling.
11448         * cli/cli-cmds.c: Use C++ exception handling.
11449         * c-varobj.c: Use C++ exception handling.
11450         * btrace.c: Use C++ exception handling.
11451         * breakpoint.c: Use C++ exception handling.
11452         * break-catch-throw.c: Use C++ exception handling.
11453         * arch-utils.c: Use C++ exception handling.
11454         * amd64-tdep.c: Use C++ exception handling.
11455         * ada-valprint.c: Use C++ exception handling.
11456         * ada-typeprint.c: Use C++ exception handling.
11457         * ada-lang.c: Use C++ exception handling.
11458         * aarch64-tdep.c: Use C++ exception handling.
11459
11460 2019-04-08  Tom Tromey  <tom@tromey.com>
11461
11462         * xml-support.c (gdb_xml_parser::parse): Update.
11463         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11464         * value.c (show_convenience): Update.
11465         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11466         (test_parse_flags_qcs): Update.
11467         * thread.c (thr_try_catch_cmd): Update.
11468         * target.c (target_translate_tls_address): Update.
11469         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11470         (info_frame_command_core, frame_apply_command_count): Update.
11471         * rust-exp.y (rust_lex_exception_test): Update.
11472         * riscv-tdep.c (riscv_print_one_register_info): Update.
11473         * remote.c (remote_target::enable_btrace): Update.
11474         * record-btrace.c (record_btrace_enable_warn): Update.
11475         * python/py-utils.c (gdbpy_convert_exception): Update.
11476         * printcmd.c (do_one_display, print_variable_and_value): Update.
11477         * mi/mi-main.c (mi_print_exception): Update.
11478         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11479         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11480         * linux-nat.c (linux_nat_target::attach): Update.
11481         * linux-fork.c (class scoped_switch_fork_info): Update.
11482         * infrun.c (displaced_step_prepare): Update.
11483         * infcall.c (call_function_by_hand_dummy): Update.
11484         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11485         * gnu-v3-abi.c (print_one_vtable): Update.
11486         * frame.c (get_prev_frame_always): Update.
11487         * f-valprint.c (info_common_command_for_block): Update.
11488         * exec.c (try_open_exec_file): Update.
11489         * exceptions.c (print_exception, exception_print)
11490         (exception_fprintf, exception_print_same): Update.
11491         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11492         * dwarf-index-cache.c (index_cache::store)
11493         (index_cache::lookup_gdb_index): Update.
11494         * darwin-nat.c (maybe_cache_shell): Update.
11495         * cp-valprint.c (cp_print_value_fields): Update.
11496         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11497         (gcc_cplus_symbol_address): Update.
11498         * compile/compile-c-symbols.c (gcc_convert_symbol)
11499         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11500         * common/selftest.c: Update.
11501         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11502         a std::string.
11503         (exception_try_scope_entry, exception_try_scope_exit): Don't
11504         declare.
11505         (struct exception_try_scope): Remove.
11506         (TRY): Don't use exception_try_scope.
11507         (struct gdb_exception): Add constructor, operator=.
11508         <what>: New method.
11509         (struct gdb_exception_RETURN_MASK_ALL)
11510         (struct gdb_exception_RETURN_MASK_ERROR)
11511         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11512         (struct gdb_quit_bad_alloc): Update.
11513         * common/common-exceptions.c (exception_none): Change
11514         initializer.
11515         (struct catcher) <state, exception>: Initialize inline.
11516         <prev>: Remove member.
11517         (current_catcher): Remove.
11518         (catchers): New global.
11519         (exceptions_state_mc_init): Simplify.
11520         (catcher_pop): Remove.
11521         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11522         (try_scope_depth, exception_try_scope_entry)
11523         (exception_try_scope_exit): Remove.
11524         (throw_exception_sjlj): Update.
11525         (exception_messages, exception_messages_size): Remove.
11526         (throw_it): Simplify.
11527         (gdb_exception_sliced_copy): Remove.
11528         (throw_exception_cxx): Update.
11529         * cli/cli-script.c (script_from_file): Update.
11530         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11531         Update.
11532         * ada-valprint.c (ada_val_print): Update.
11533         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11534         (create_excep_cond_exprs): Update.
11535
11536 2019-04-08  Tom Tromey  <tom@tromey.com>
11537
11538         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11539         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11540         (TRY, CATCH, END_CATCH): Remove some definitions.
11541         * common/common-exceptions.c: Don't use GDB_XCPT.
11542         (catcher_list_size): Remove.
11543         (throw_exception, throw_it): Simplify.
11544
11545 2019-04-05  Tom Tromey  <tom@tromey.com>
11546
11547         Revert the header-sorting patch.
11548         * ft32-tdep.c: Revert.
11549         * frv-tdep.c: Revert.
11550         * frv-linux-tdep.c: Revert.
11551         * frame.c: Revert.
11552         * frame-unwind.c: Revert.
11553         * frame-base.c: Revert.
11554         * fork-child.c: Revert.
11555         * findvar.c: Revert.
11556         * findcmd.c: Revert.
11557         * filesystem.c: Revert.
11558         * filename-seen-cache.h: Revert.
11559         * filename-seen-cache.c: Revert.
11560         * fbsd-tdep.c: Revert.
11561         * fbsd-nat.h: Revert.
11562         * fbsd-nat.c: Revert.
11563         * f-valprint.c: Revert.
11564         * f-typeprint.c: Revert.
11565         * f-lang.c: Revert.
11566         * extension.h: Revert.
11567         * extension.c: Revert.
11568         * extension-priv.h: Revert.
11569         * expprint.c: Revert.
11570         * exec.h: Revert.
11571         * exec.c: Revert.
11572         * exceptions.c: Revert.
11573         * event-top.c: Revert.
11574         * event-loop.c: Revert.
11575         * eval.c: Revert.
11576         * elfread.c: Revert.
11577         * dwarf2read.h: Revert.
11578         * dwarf2read.c: Revert.
11579         * dwarf2loc.c: Revert.
11580         * dwarf2expr.h: Revert.
11581         * dwarf2expr.c: Revert.
11582         * dwarf2-frame.c: Revert.
11583         * dwarf2-frame-tailcall.c: Revert.
11584         * dwarf-index-write.h: Revert.
11585         * dwarf-index-write.c: Revert.
11586         * dwarf-index-common.c: Revert.
11587         * dwarf-index-cache.h: Revert.
11588         * dwarf-index-cache.c: Revert.
11589         * dummy-frame.c: Revert.
11590         * dtrace-probe.c: Revert.
11591         * disasm.h: Revert.
11592         * disasm.c: Revert.
11593         * disasm-selftests.c: Revert.
11594         * dictionary.c: Revert.
11595         * dicos-tdep.c: Revert.
11596         * demangle.c: Revert.
11597         * dcache.h: Revert.
11598         * dcache.c: Revert.
11599         * darwin-nat.h: Revert.
11600         * darwin-nat.c: Revert.
11601         * darwin-nat-info.c: Revert.
11602         * d-valprint.c: Revert.
11603         * d-namespace.c: Revert.
11604         * d-lang.c: Revert.
11605         * ctf.c: Revert.
11606         * csky-tdep.c: Revert.
11607         * csky-linux-tdep.c: Revert.
11608         * cris-tdep.c: Revert.
11609         * cris-linux-tdep.c: Revert.
11610         * cp-valprint.c: Revert.
11611         * cp-support.c: Revert.
11612         * cp-namespace.c: Revert.
11613         * cp-abi.c: Revert.
11614         * corelow.c: Revert.
11615         * corefile.c: Revert.
11616         * continuations.c: Revert.
11617         * completer.h: Revert.
11618         * completer.c: Revert.
11619         * complaints.c: Revert.
11620         * coffread.c: Revert.
11621         * coff-pe-read.c: Revert.
11622         * cli-out.h: Revert.
11623         * cli-out.c: Revert.
11624         * charset.c: Revert.
11625         * c-varobj.c: Revert.
11626         * c-valprint.c: Revert.
11627         * c-typeprint.c: Revert.
11628         * c-lang.c: Revert.
11629         * buildsym.c: Revert.
11630         * buildsym-legacy.c: Revert.
11631         * build-id.h: Revert.
11632         * build-id.c: Revert.
11633         * btrace.c: Revert.
11634         * bsd-uthread.c: Revert.
11635         * breakpoint.h: Revert.
11636         * breakpoint.c: Revert.
11637         * break-catch-throw.c: Revert.
11638         * break-catch-syscall.c: Revert.
11639         * break-catch-sig.c: Revert.
11640         * blockframe.c: Revert.
11641         * block.c: Revert.
11642         * bfin-tdep.c: Revert.
11643         * bfin-linux-tdep.c: Revert.
11644         * bfd-target.c: Revert.
11645         * bcache.c: Revert.
11646         * ax-general.c: Revert.
11647         * ax-gdb.h: Revert.
11648         * ax-gdb.c: Revert.
11649         * avr-tdep.c: Revert.
11650         * auxv.c: Revert.
11651         * auto-load.c: Revert.
11652         * arm-wince-tdep.c: Revert.
11653         * arm-tdep.c: Revert.
11654         * arm-symbian-tdep.c: Revert.
11655         * arm-pikeos-tdep.c: Revert.
11656         * arm-obsd-tdep.c: Revert.
11657         * arm-nbsd-tdep.c: Revert.
11658         * arm-nbsd-nat.c: Revert.
11659         * arm-linux-tdep.c: Revert.
11660         * arm-linux-nat.c: Revert.
11661         * arm-fbsd-tdep.c: Revert.
11662         * arm-fbsd-nat.c: Revert.
11663         * arm-bsd-tdep.c: Revert.
11664         * arch-utils.c: Revert.
11665         * arc-tdep.c: Revert.
11666         * arc-newlib-tdep.c: Revert.
11667         * annotate.h: Revert.
11668         * annotate.c: Revert.
11669         * amd64-windows-tdep.c: Revert.
11670         * amd64-windows-nat.c: Revert.
11671         * amd64-tdep.c: Revert.
11672         * amd64-sol2-tdep.c: Revert.
11673         * amd64-obsd-tdep.c: Revert.
11674         * amd64-obsd-nat.c: Revert.
11675         * amd64-nbsd-tdep.c: Revert.
11676         * amd64-nbsd-nat.c: Revert.
11677         * amd64-nat.c: Revert.
11678         * amd64-linux-tdep.c: Revert.
11679         * amd64-linux-nat.c: Revert.
11680         * amd64-fbsd-tdep.c: Revert.
11681         * amd64-fbsd-nat.c: Revert.
11682         * amd64-dicos-tdep.c: Revert.
11683         * amd64-darwin-tdep.c: Revert.
11684         * amd64-bsd-nat.c: Revert.
11685         * alpha-tdep.c: Revert.
11686         * alpha-obsd-tdep.c: Revert.
11687         * alpha-nbsd-tdep.c: Revert.
11688         * alpha-mdebug-tdep.c: Revert.
11689         * alpha-linux-tdep.c: Revert.
11690         * alpha-linux-nat.c: Revert.
11691         * alpha-bsd-tdep.c: Revert.
11692         * alpha-bsd-nat.c: Revert.
11693         * aix-thread.c: Revert.
11694         * agent.c: Revert.
11695         * addrmap.c: Revert.
11696         * ada-varobj.c: Revert.
11697         * ada-valprint.c: Revert.
11698         * ada-typeprint.c: Revert.
11699         * ada-tasks.c: Revert.
11700         * ada-lang.c: Revert.
11701         * aarch64-tdep.c: Revert.
11702         * aarch64-ravenscar-thread.c: Revert.
11703         * aarch64-newlib-tdep.c: Revert.
11704         * aarch64-linux-tdep.c: Revert.
11705         * aarch64-linux-nat.c: Revert.
11706         * aarch64-fbsd-tdep.c: Revert.
11707         * aarch64-fbsd-nat.c: Revert.
11708         * aarch32-linux-nat.c: Revert.
11709
11710 2019-04-05  Tom Tromey  <tom@tromey.com>
11711
11712         * ft32-tdep.c: Sort headers.
11713         * frv-tdep.c: Sort headers.
11714         * frv-linux-tdep.c: Sort headers.
11715         * frame.c: Sort headers.
11716         * frame-unwind.c: Sort headers.
11717         * frame-base.c: Sort headers.
11718         * fork-child.c: Sort headers.
11719         * findvar.c: Sort headers.
11720         * findcmd.c: Sort headers.
11721         * filesystem.c: Sort headers.
11722         * filename-seen-cache.h: Sort headers.
11723         * filename-seen-cache.c: Sort headers.
11724         * fbsd-tdep.c: Sort headers.
11725         * fbsd-nat.h: Sort headers.
11726         * fbsd-nat.c: Sort headers.
11727         * f-valprint.c: Sort headers.
11728         * f-typeprint.c: Sort headers.
11729         * f-lang.c: Sort headers.
11730         * extension.h: Sort headers.
11731         * extension.c: Sort headers.
11732         * extension-priv.h: Sort headers.
11733         * expprint.c: Sort headers.
11734         * exec.h: Sort headers.
11735         * exec.c: Sort headers.
11736         * exceptions.c: Sort headers.
11737         * event-top.c: Sort headers.
11738         * event-loop.c: Sort headers.
11739         * eval.c: Sort headers.
11740         * elfread.c: Sort headers.
11741         * dwarf2read.h: Sort headers.
11742         * dwarf2read.c: Sort headers.
11743         * dwarf2loc.c: Sort headers.
11744         * dwarf2expr.h: Sort headers.
11745         * dwarf2expr.c: Sort headers.
11746         * dwarf2-frame.c: Sort headers.
11747         * dwarf2-frame-tailcall.c: Sort headers.
11748         * dwarf-index-write.h: Sort headers.
11749         * dwarf-index-write.c: Sort headers.
11750         * dwarf-index-common.c: Sort headers.
11751         * dwarf-index-cache.h: Sort headers.
11752         * dwarf-index-cache.c: Sort headers.
11753         * dummy-frame.c: Sort headers.
11754         * dtrace-probe.c: Sort headers.
11755         * disasm.h: Sort headers.
11756         * disasm.c: Sort headers.
11757         * disasm-selftests.c: Sort headers.
11758         * dictionary.c: Sort headers.
11759         * dicos-tdep.c: Sort headers.
11760         * demangle.c: Sort headers.
11761         * dcache.h: Sort headers.
11762         * dcache.c: Sort headers.
11763         * darwin-nat.h: Sort headers.
11764         * darwin-nat.c: Sort headers.
11765         * darwin-nat-info.c: Sort headers.
11766         * d-valprint.c: Sort headers.
11767         * d-namespace.c: Sort headers.
11768         * d-lang.c: Sort headers.
11769         * ctf.c: Sort headers.
11770         * csky-tdep.c: Sort headers.
11771         * csky-linux-tdep.c: Sort headers.
11772         * cris-tdep.c: Sort headers.
11773         * cris-linux-tdep.c: Sort headers.
11774         * cp-valprint.c: Sort headers.
11775         * cp-support.c: Sort headers.
11776         * cp-namespace.c: Sort headers.
11777         * cp-abi.c: Sort headers.
11778         * corelow.c: Sort headers.
11779         * corefile.c: Sort headers.
11780         * continuations.c: Sort headers.
11781         * completer.h: Sort headers.
11782         * completer.c: Sort headers.
11783         * complaints.c: Sort headers.
11784         * coffread.c: Sort headers.
11785         * coff-pe-read.c: Sort headers.
11786         * cli-out.h: Sort headers.
11787         * cli-out.c: Sort headers.
11788         * charset.c: Sort headers.
11789         * c-varobj.c: Sort headers.
11790         * c-valprint.c: Sort headers.
11791         * c-typeprint.c: Sort headers.
11792         * c-lang.c: Sort headers.
11793         * buildsym.c: Sort headers.
11794         * buildsym-legacy.c: Sort headers.
11795         * build-id.h: Sort headers.
11796         * build-id.c: Sort headers.
11797         * btrace.c: Sort headers.
11798         * bsd-uthread.c: Sort headers.
11799         * breakpoint.h: Sort headers.
11800         * breakpoint.c: Sort headers.
11801         * break-catch-throw.c: Sort headers.
11802         * break-catch-syscall.c: Sort headers.
11803         * break-catch-sig.c: Sort headers.
11804         * blockframe.c: Sort headers.
11805         * block.c: Sort headers.
11806         * bfin-tdep.c: Sort headers.
11807         * bfin-linux-tdep.c: Sort headers.
11808         * bfd-target.c: Sort headers.
11809         * bcache.c: Sort headers.
11810         * ax-general.c: Sort headers.
11811         * ax-gdb.h: Sort headers.
11812         * ax-gdb.c: Sort headers.
11813         * avr-tdep.c: Sort headers.
11814         * auxv.c: Sort headers.
11815         * auto-load.c: Sort headers.
11816         * arm-wince-tdep.c: Sort headers.
11817         * arm-tdep.c: Sort headers.
11818         * arm-symbian-tdep.c: Sort headers.
11819         * arm-pikeos-tdep.c: Sort headers.
11820         * arm-obsd-tdep.c: Sort headers.
11821         * arm-nbsd-tdep.c: Sort headers.
11822         * arm-nbsd-nat.c: Sort headers.
11823         * arm-linux-tdep.c: Sort headers.
11824         * arm-linux-nat.c: Sort headers.
11825         * arm-fbsd-tdep.c: Sort headers.
11826         * arm-fbsd-nat.c: Sort headers.
11827         * arm-bsd-tdep.c: Sort headers.
11828         * arch-utils.c: Sort headers.
11829         * arc-tdep.c: Sort headers.
11830         * arc-newlib-tdep.c: Sort headers.
11831         * annotate.h: Sort headers.
11832         * annotate.c: Sort headers.
11833         * amd64-windows-tdep.c: Sort headers.
11834         * amd64-windows-nat.c: Sort headers.
11835         * amd64-tdep.c: Sort headers.
11836         * amd64-sol2-tdep.c: Sort headers.
11837         * amd64-obsd-tdep.c: Sort headers.
11838         * amd64-obsd-nat.c: Sort headers.
11839         * amd64-nbsd-tdep.c: Sort headers.
11840         * amd64-nbsd-nat.c: Sort headers.
11841         * amd64-nat.c: Sort headers.
11842         * amd64-linux-tdep.c: Sort headers.
11843         * amd64-linux-nat.c: Sort headers.
11844         * amd64-fbsd-tdep.c: Sort headers.
11845         * amd64-fbsd-nat.c: Sort headers.
11846         * amd64-dicos-tdep.c: Sort headers.
11847         * amd64-darwin-tdep.c: Sort headers.
11848         * amd64-bsd-nat.c: Sort headers.
11849         * alpha-tdep.c: Sort headers.
11850         * alpha-obsd-tdep.c: Sort headers.
11851         * alpha-nbsd-tdep.c: Sort headers.
11852         * alpha-mdebug-tdep.c: Sort headers.
11853         * alpha-linux-tdep.c: Sort headers.
11854         * alpha-linux-nat.c: Sort headers.
11855         * alpha-bsd-tdep.c: Sort headers.
11856         * alpha-bsd-nat.c: Sort headers.
11857         * aix-thread.c: Sort headers.
11858         * agent.c: Sort headers.
11859         * addrmap.c: Sort headers.
11860         * ada-varobj.c: Sort headers.
11861         * ada-valprint.c: Sort headers.
11862         * ada-typeprint.c: Sort headers.
11863         * ada-tasks.c: Sort headers.
11864         * ada-lang.c: Sort headers.
11865         * aarch64-tdep.c: Sort headers.
11866         * aarch64-ravenscar-thread.c: Sort headers.
11867         * aarch64-newlib-tdep.c: Sort headers.
11868         * aarch64-linux-tdep.c: Sort headers.
11869         * aarch64-linux-nat.c: Sort headers.
11870         * aarch64-fbsd-tdep.c: Sort headers.
11871         * aarch64-fbsd-nat.c: Sort headers.
11872         * aarch32-linux-nat.c: Sort headers.
11873
11874 2019-04-04  Tom Tromey  <tom@tromey.com>
11875
11876         * varobj.c (varobj_create): Update.
11877         * rust-exp.y (struct rust_parser) <update_innermost_block,
11878         lookup_symbol>: New methods.
11879         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11880         Rename.
11881         (rust_parser::rust_lookup_type)
11882         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11883         * printcmd.c (display_command, do_one_display): Update.
11884         * parser-defs.h (struct parser_state) <parser_state>: Add
11885         "tracker" parameter.
11886         (block_tracker): New member.
11887         (class innermost_block_tracker) <innermost_block_tracker>: Add
11888         "types" parameter.
11889         <reset>: Remove method.
11890         (innermost_block): Don't declare.
11891         (null_post_parser): Update.
11892         * parse.c (innermost_block): Remove global.
11893         (write_dollar_variable): Update.
11894         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11895         Remove "tracker_types" parameter.
11896         (parse_expression): Add "tracker" parameter.
11897         (parse_expression_for_completion): Update.
11898         (null_post_parser): Add "tracker" parameter.
11899         * p-exp.y: Update rules.
11900         * m2-exp.y: Update rules.
11901         * language.h (struct language_defn) <la_post_parser>: Add
11902         "tracker" parameter.
11903         * go-exp.y: Update rules.
11904         * f-exp.y: Update rules.
11905         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11906         parameter.
11907         * d-exp.y: Update rules.
11908         * c-exp.y: Update rules.
11909         * breakpoint.c (set_breakpoint_condition): Create an
11910         innermost_block_tracker.
11911         (watch_command_1): Likewise.
11912         * ada-lang.c (resolve): Add "tracker" parameter.
11913         (resolve_subexp): Likewise.
11914         * ada-exp.y (write_var_from_sym): Update.
11915
11916 2019-04-04  Tom Tromey  <tom@tromey.com>
11917
11918         * type-stack.h: New file.
11919         * type-stack.c: New file.
11920         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11921         type-stack.h.
11922         (insert_into_type_stack, insert_type, push_type, push_type_int)
11923         (insert_type_address_space, pop_type, pop_type_int)
11924         (pop_typelist, pop_type_stack, append_type_stack)
11925         (push_type_stack, get_type_stack, push_typelist)
11926         (follow_type_instance_flags, follow_types): Don't declare.
11927         * parse.c (type_stack): Remove global.
11928         (parse_exp_in_context): Update.
11929         (insert_into_type_stack, insert_type, push_type, push_type_int)
11930         (insert_type_address_space, pop_type, pop_type_int)
11931         (pop_typelist, pop_type_stack, append_type_stack)
11932         (push_type_stack, get_type_stack, push_typelist)
11933         (follow_type_instance_flags, follow_types): Remove (moved to
11934         type-stack.c).
11935         * f-exp.y (type_stack): New global.
11936         Update rules.
11937         (push_kind_type, f_parse): Update.
11938         * d-exp.y (type_stack): New global.
11939         Update rules.
11940         (d_parse): Update.
11941         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11942         Update rules.
11943         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11944         (HFILES_NO_SRCDIR): Add type-stack.h.
11945
11946 2019-04-04  Tom Tromey  <tom@tromey.com>
11947
11948         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11949         (rust_parser::convert_ast_to_expression, rust_parse)
11950         (rust_lex_test_completion, rust_lex_tests): Update.
11951         * parser-defs.h (struct expr_completion_state): New.
11952         (struct parser_state) <parser_state>: Add completion parameter.
11953         <mark_struct_expression, mark_completion_tag>: New methods.
11954         <parse_completion, m_completion_state>: New members.
11955         (prefixify_expression, null_post_parser): Update.
11956         (mark_struct_expression, mark_completion_tag): Don't declare.
11957         * parse.c (parse_completion, expout_last_struct)
11958         (expout_tag_completion_type, expout_completion_name): Remove
11959         globals.
11960         (parser_state::mark_struct_expression)
11961         (parser_state::mark_completion_tag): Now methods.
11962         (prefixify_expression): Add last_struct parameter.
11963         (prefixify_subexp): Likewise.
11964         (parse_exp_1): Update.
11965         (parse_exp_in_context): Add cstate parameter.  Update.
11966         (parse_expression_for_completion): Create an
11967         expr_completion_state.
11968         (null_post_parser): Add "completion" parameter.
11969         * p-exp.y: Update rules.
11970         (yylex): Update.
11971         * language.h (struct language_defn) <la_post_parser>: Add
11972         "completing" parameter.
11973         * go-exp.y: Update rules.
11974         (lex_one_token): Update.
11975         * expression.h (parse_completion): Don't declare.
11976         * d-exp.y: Update rules.
11977         (lex_one_token): Update rules.
11978         * c-exp.y: Update rules.
11979         (lex_one_token): Update.
11980         * ada-lang.c (resolve): Add "parse_completion" parameter.
11981         (resolve_subexp): Likewise.
11982         (ada_resolve_function): Likewise.
11983
11984 2019-04-04  Tom Tromey  <tom@tromey.com>
11985
11986         * parser-defs.h (struct parser_state) <start_arglist,
11987         end_arglist>: New methods.
11988         <arglist_len, m_funcall_chain>: New members.
11989         (arglist_len, start_arglist, end_arglist): Don't declare.
11990         * parse.c (arglist_len, funcall_chain): Remove global.
11991         (start_arglist, end_arglist): Remove functions.
11992         (parse_exp_in_context): Update.
11993         * p-exp.y: Update rules.
11994         * m2-exp.y: Update rules.
11995         * go-exp.y: Update rules.
11996         * f-exp.y: Update rules.
11997         * d-exp.y: Update rules.
11998         * c-exp.y: Update rules.
11999
12000 2019-04-04  Tom Tromey  <tom@tromey.com>
12001
12002         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12003         lex_operator, push_back>: New methods.
12004         Update all rules.
12005         (rust_parser::lex_hex, lex_escape): Rename and update.
12006         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12007         (rust_parser::lex_operator): Rename and update.
12008         (rust_parser::lex_number, rustyylex, rustyyerror)
12009         (rust_lex_test_init, rust_lex_test_sequence)
12010         (rust_lex_test_push_back, rust_lex_tests): Update.
12011         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12012         parameter.
12013         <lexptr, prev_lexptr>: New members.
12014         (lexptr, prev_lexptr): Don't declare.
12015         * parse.c (lexptr, prev_lexptr): Remove globals.
12016         (parse_exp_in_context): Update.
12017         * p-exp.y (yylex, yyerror): Update.
12018         * m2-exp.y (parse_number, yylex, yyerror): Update.
12019         * go-exp.y (lex_one_token, yyerror): Update.
12020         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12021         * d-exp.y (lex_one_token, yyerror): Update.
12022         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12023         (lex_one_token, yyerror): Update.
12024         * ada-lex.l (YY_INPUT): Update.
12025         (rewind_to_char): Update.
12026         * ada-exp.y (yyerror): Update.
12027
12028 2019-04-04  Tom Tromey  <tom@tromey.com>
12029
12030         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12031         * parser-defs.h (struct parser_state) <parser_state>: Add new
12032         parameter.
12033         <comma_terminates>: New member.
12034         (comma_terminates): Don't declare global.
12035         * parse.c (comma_terminates): Remove global.
12036         (parse_exp_in_context): Update.
12037         * p-exp.y (yylex): Update.
12038         * m2-exp.y (yylex): Update.
12039         * go-exp.y (lex_one_token): Update.
12040         * f-exp.y (yylex): Update.
12041         * d-exp.y (lex_one_token): Update.
12042         * c-exp.y (lex_one_token): Update.
12043         * ada-lex.l: Update.
12044
12045 2019-04-04  Tom Tromey  <tom@tromey.com>
12046
12047         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12048         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12049         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12050         * parser-defs.h (paren_depth): Don't declare.
12051         * parse.c (paren_depth): Remove global.
12052         (parse_exp_in_context): Update.
12053         * p-exp.y (paren_depth): New global.
12054         (pascal_parse): Initialize it.
12055         * m2-exp.y (paren_depth): New global.
12056         (m2_parse): Initialize it.
12057         * go-exp.y (paren_depth): New global.
12058         (go_parse): Initialize it.
12059         * f-exp.y (paren_depth): New global.
12060         (f_parse): Initialize it.
12061         * d-exp.y (paren_depth): New global.
12062         (d_parse): Initialize it.
12063         * c-exp.y (paren_depth): New global.
12064         (c_parse): Initialize it.
12065         * ada-lex.l (paren_depth): New global.
12066         (lexer_init): Initialize it.
12067
12068 2019-04-04  Tom Tromey  <tom@tromey.com>
12069
12070         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12071         (rust_parser::convert_ast_to_type)
12072         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12073         * parser-defs.h (struct parser_state) <parser_state>: Add
12074         parameters.  Initialize new members.
12075         <expression_context_block, expression_context_pc>: New members.
12076         * parse.c (expression_context_block, expression_context_pc):
12077         Remove globals.
12078         (parse_exp_in_context): Update.
12079         * p-exp.y: Update all rules.
12080         (yylex): Update.
12081         * m2-exp.y: Update all rules.
12082         (yylex): Update.
12083         * go-exp.y (yylex): Update.
12084         * f-exp.y (yylex): Update.
12085         * d-exp.y: Update all rules.
12086         (yylex): Update.
12087         * c-exp.y: Update all rules.
12088         (lex_one_token, classify_name, yylex, c_parse): Update.
12089         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12090
12091 2019-04-04  Tom Tromey  <tom@tromey.com>
12092
12093         * gdbarch.h, gdbarch.c: Rebuild.
12094         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12095         * stap-probe.h:
12096         (struct stap_parse_info): Replace "parser_state" with
12097         "expr_builder".
12098         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12099         (parser_state): New class.
12100         * parse.c (expr_builder): Rename.
12101         (expr_builder::release): Rename.
12102         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12103         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12104         (write_exp_elt_longcst, write_exp_elt_floatcst)
12105         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12106         (write_exp_string_vector, write_exp_bitstring)
12107         (write_exp_msymbol, mark_struct_expression)
12108         (write_dollar_variable)
12109         (insert_type_address_space, increase_expout_size): Replace
12110         "parser_state" with "expr_builder".
12111         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12112         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12113         "parser_state" with "expr_builder".
12114
12115 2019-04-04  Tom Tromey  <tom@tromey.com>
12116
12117         * rust-exp.y: Replace "parse_language" with method call.
12118         * p-exp.y:
12119         (yylex): Replace "parse_language" with method call.
12120         * m2-exp.y:
12121         (yylex): Replace "parse_language" with method call.
12122         * go-exp.y (classify_name): Replace "parse_language" with method
12123         call.
12124         * f-exp.y (yylex): Replace "parse_language" with method call.
12125         * d-exp.y (lex_one_token): Replace "parse_language" with method
12126         call.
12127         * c-exp.y:
12128         (lex_one_token, classify_name, yylex): Replace "parse_language"
12129         with method call.
12130         * ada-exp.y (find_primitive_type, type_char)
12131         (type_system_address): Replace "parse_language" with method call.
12132
12133 2019-04-04  Tom Tromey  <tom@tromey.com>
12134
12135         * rust-exp.y: Replace "parse_gdbarch" with method call.
12136         * parse.c (write_dollar_variable, insert_type_address_space):
12137         Replace "parse_gdbarch" with method call.
12138         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12139         call.
12140         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12141         call.
12142         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12143         "parse_gdbarch" with method call.
12144         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12145         with method call.
12146         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12147         "parse_gdbarch" with method call.
12148         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12149         "parse_gdbarch" with method call.
12150         * c-exp.y (parse_type, parse_number, classify_name): Replace
12151         "parse_gdbarch" with method call.
12152         * ada-lex.l: Replace "parse_gdbarch" with method call.
12153         * ada-exp.y (parse_type, find_primitive_type, type_char)
12154         (type_system_address): Replace "parse_gdbarch" with method call.
12155
12156 2019-04-04  Tom Tromey  <tom@tromey.com>
12157
12158         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12159         * stap-probe.c (stap_parse_argument): Update.
12160         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12161         initial_size parameter.
12162         * rust-exp.y (rust_lex_tests): Update.
12163         * parse.c (parser_state): Update.
12164         (parse_exp_in_context): Update.
12165         * parser-defs.h (struct parser_state) <parser_state>: Remove
12166         "initial_size" parameter.
12167
12168 2019-04-04  Tom Tromey  <tom@tromey.com>
12169
12170         * parser-defs.h (increase_expout_size): Don't declare.
12171         * parse.c (increase_expout_size): Now static.
12172
12173 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12174
12175         * gnu-nat.c (gnu_nat_target::wait): Fix
12176         target_waitstatus_to_string call.
12177
12178 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12179
12180         * eval.c (evaluate_subexp_standard): Handle internal functions
12181         during Fortran function call handling.
12182
12183 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12184
12185         * NEWS: Mention new internal functions.
12186         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12187         (read_base_type): Use dwarf2_init_complex_target_type.
12188         * value.c (creal_internal_fn): New function.
12189         (cimag_internal_fn): New function.
12190         (_initialize_values): Register new internal functions.
12191
12192 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12193
12194         * infrun.c (stop_all_threads): If debug_infrun, always
12195         trace the wait status after wait_one, using
12196         target_waitstatus_to_string and target_pid_to_str.
12197         (handle_inferior_event): Replace various trace of
12198         wait status kind by a single trace.
12199         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12200         wait status kind image by target_waitstatus_to_string.
12201         * target/waitstatus.c (target_waitstatus_to_string): Fix
12202         obsolete comment.
12203
12204 2019-04-01  Tom Tromey  <tromey@adacore.com>
12205
12206         PR symtab/23331:
12207         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12208
12209 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12210             Pedro Alves  <palves@redhat.com>
12211
12212         * top.c (quit_force): Call 'finalize_values'.
12213         * value.c (finalize_values): New function.
12214         * value.h (finalize_values): Declare.
12215
12216 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12217
12218         * NEWS: Announce $_gdb_major and $_gdb_minor.
12219
12220         * top.c (init_gdb_version_vars): New function.
12221         (gdb_init): Call init_gdb_version_vars.
12222
12223 2019-03-29  Tom Tromey  <tromey@adacore.com>
12224
12225         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12226         help text.  Remove dead code.
12227
12228 2019-03-29  Keith Seitz  <keiths@redhat.com>
12229
12230         From Siddhesh Poyarekar:
12231         * f-lang.h (f77_get_upperbound): Return LONGEST.
12232         (f77_get_lowerbound): Likewise.
12233         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12234         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12235         print them.
12236         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12237         plongest to format print it.
12238         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12239         (f77_get_upperbound): Likewise.
12240         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12241         LOWER_BOUND to LONGEST.
12242         (f77_create_arrayprint_offset_tbl): Likewise.
12243
12244 2019-03-29  Keith Seitz  <keiths@redhat.com>
12245
12246         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12247         %s/pulongest for TYPE_LENGTH instead of %d in format
12248         strings.
12249         * ada-typerint.c (ada_print_type): Likewise.
12250         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12251         * compile/compile-c-support.c (generate_register_struct): Likewise.
12252         * gdbtypes.c (recursive_dump_type): Likewise.
12253         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12254         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12255         instead of %d in format strings.
12256         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12257         to std::min to ULONGEST.
12258         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12259         instead of %d in format strings.
12260         * tracepoint.c (info_scope_command): Likewise.
12261         * typeprint.c (print_offset_data::update)
12262         (print_offset_data::finish): Likewise.
12263         * xtensa-tdep.c (xtensa_store_return_value)
12264         (xtensa_push_dummy_call): Likewise.
12265
12266 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12267
12268         * windows-nat.c (display_selector): Fixed format specifications
12269         for 64-bit Cygwin.
12270
12271 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12272
12273         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12274
12275 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12276
12277         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12278         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12279         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12280         (nios2_linux_init_abi): Install it.
12281
12282 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12283
12284         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12285
12286 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12287
12288         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12289
12290 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12291             Tom Tromey  <tromey@adacore.com>
12292
12293         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12294
12295 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12296
12297         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12298         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12299         method to compute the bounds of range types. Also print "[evaluated]"
12300         if the bounds' values come from a dynamic evaluation.
12301
12302 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12303
12304         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12305         whitespace when pretty printing is on.
12306
12307 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12308
12309         * ppc-linux-nat.c: Add include.
12310
12311 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12312
12313         * NEWS: Mention AArch64 Pointer Authentication.
12314
12315 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12316
12317         * arm-linux-nat.c: Add include.
12318
12319 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12320
12321         * source-cache.c (source_cache::get_source_lines): Re-read
12322         fullname after calling open_source_file.
12323
12324 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12325
12326         * NEWS: Mention TLS support for FreeBSD.
12327
12328 2019-03-25  Tom Tromey  <tromey@adacore.com>
12329
12330         * minsyms.c (BUNCH_SIZE): Update comment.
12331         (~minimal_symbol_reader): Remove old comment.
12332         (compact_minimal_symbols): Update comment.
12333         (minimal_symbol_reader::install): Remove old comment.  Update
12334         other comments.
12335
12336 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12337
12338         * s390-linux-nat.c: Add include.
12339
12340 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12341
12342         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12343         Call linux_get_hwcap.
12344         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12345         Likewise.
12346         (aarch64_linux_get_hwcap): Remove function.
12347         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12348         declaration.
12349         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12350         linux_get_hwcap.
12351         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12352         * linux-tdep.c (linux_get_hwcap): Add function.
12353         (linux_get_hwcap2): Likewise.
12354         * linux-tdep.h (linux_get_hwcap): Add declaration.
12355         (linux_get_hwcap2): Likewise.
12356         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12357         (ppc_linux_get_hwcap2): Likewise.
12358         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12359         linux_get_hwcap.
12360         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12361         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12362         (ppc_linux_nat_target::read_description): Likewise.
12363         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12364         * s390-linux-nat.c: Likewise.
12365         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12366
12367 2019-03-24  Tom Tromey  <tom@tromey.com>
12368
12369         * ada-lang.c (standard_lookup): Simplify initialization.
12370         (ada_lookup_symbol_nonlocal): Simplify return.
12371         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12372         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12373         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12374         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12375         initialization.
12376         * solib.c (solib_global_lookup): Simplify.
12377         * symtab.c (null_block_symbol): Remove.
12378         (symbol_cache_lookup): Simplify returns.
12379         (lookup_language_this): Simplify returns.
12380         (lookup_symbol_aux): Simplify return.
12381         (lookup_local_symbol): Simplify returns.
12382         (lookup_global_symbol_from_objfile): Simplify return.
12383         (lookup_symbol_in_objfile_symtabs)
12384         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12385         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12386         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12387         * cp-namespace.c (cp_lookup_bare_symbol)
12388         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12389         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12390         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12391         (cp_lookup_symbol_via_imports): Simplify initialization.
12392         (find_symbol_in_baseclass): Likewise.
12393         * symtab.h (null_block_symbol): Remove.
12394         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12395         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12396         (d_lookup_symbol_module): Likewise.
12397         (find_symbol_in_baseclass): Simplify initialization.
12398
12399 2019-03-24  Tom Tromey  <tom@tromey.com>
12400
12401         * expression.h: Don't include symtab.h.
12402         (struct block): Forward declare.
12403
12404 2019-03-24  Tom Tromey  <tom@tromey.com>
12405
12406         * c-exp.y (typebase): Remove casts.
12407         * gdbtypes.c (lookup_unsigned_typename, )
12408         (lookup_signed_typename): Remove cast.
12409         * eval.c (parse_to_comma_and_eval): Remove cast.
12410         * parse.c (write_dollar_variable): Remove cast.
12411         * block.h (struct block) <superblock>: Now const.
12412         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12413         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12414         (map_block): Make "block" const.
12415         * symfile.h (struct quick_symbol_functions)
12416         <map_matching_symbols>: Constify block argument to "callback".
12417         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12418         const.
12419         (find_pc_sect_compunit_symtab): Make "b" const.
12420         (find_symbol_at_address): Likewise.
12421         (search_symbols): Likewise.
12422         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12423         (dw2_debug_names_lookup_symbol): Likewise.
12424         (dw2_map_matching_symbols): Update.
12425         * p-valprint.c (pascal_val_print): Remove "block".
12426         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12427         (aux_add_nonlocal_symbols): Make "block" const.
12428         (resolve_subexp): Remove cast.
12429         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12430         const.
12431         (iterate_over_file_blocks): Likewise.
12432         * f-exp.y (%union) <bval>: Remove.
12433         * coffread.c (patch_opaque_types): Make "b" const.
12434         * spu-tdep.c (spu_catch_start): Make "block" const.
12435         * c-valprint.c (print_unpacked_pointer): Remove "block".
12436         * symmisc.c (dump_symtab_1): Make "b" const.
12437         (block_depth): Make "block" const.
12438         * d-exp.y (%union) <bval>: Remove.
12439         * cp-support.h (cp_lookup_rtti_type): Update.
12440         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12441         * psymtab.c (psym_lookup_symbol): Make "block" const.
12442         (maintenance_check_psymtabs): Make "b" const.
12443         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12444         (enumerate_locals, enumerate_args): Update.
12445         * python/py-symtab.c (stpy_global_block): Make "block" const.
12446         (stpy_static_block): Likewise.
12447         * inline-frame.c (block_starting_point_at): Make "new_block"
12448         const.
12449         * block.c (find_block_in_blockvector): Make return type const.
12450         (blockvector_for_pc_sect): Make "b" const.
12451         (find_block_in_blockvector): Make "b" const.
12452
12453 2019-03-23  Tom Tromey  <tom@tromey.com>
12454
12455         * varobj.c (varobj_create): Update.
12456         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12457         * printcmd.c (display_command, do_one_display): Don't reset
12458         innermost_block.
12459         * parser-defs.h (enum innermost_block_tracker_type): Move to
12460         expression.h.
12461         (innermost_block): Update comment.
12462         * parse.c (parse_exp_1): Add tracker_types parameter.
12463         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12464         tracker_types parameter.  Reset innermost_block.
12465         (parse_exp_in_context): Remove.
12466         (parse_expression_for_completion): Update.
12467         * objfiles.c (~objfile): Don't reset expression_context_block or
12468         innermost_block.
12469         * expression.h (enum innermost_block_tracker_type): Move from
12470         parser-defs.h.
12471         (parse_exp_1): Add tracker_types parameter.
12472         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12473         reset innermost_block.
12474
12475 2019-03-23  Tom Tromey  <tom@tromey.com>
12476
12477         * objfiles.h: Include bcache.h.
12478
12479 2019-03-23  Tom Tromey  <tom@tromey.com>
12480
12481         * linespec.c (get_current_search_block): Use
12482         scoped_restore_current_language.
12483         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12484
12485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12486             Jiong Wang  <jiong.wang@arm.com>
12487
12488         * aarch64-linux-tdep.c
12489         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12490         section.
12491         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12492
12493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12494             Jiong Wang  <jiong.wang@arm.com>
12495
12496         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12497         instructions.
12498         (aarch64_analyze_prologue_test): Add PACIASP test.
12499         (aarch64_prologue_prev_register): Unmask PC value.
12500
12501 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12502             Jiong Wang  <jiong.wang@arm.com>
12503
12504         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12505         (aarch64_dwarf2_prev_register): Unmask PC value.
12506         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12507         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12508         DW_CFA_AARCH64_negate_ra_state.
12509         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12510
12511 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12512             Jiong Wang  <jiong.wang@arm.com>
12513
12514         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12515         registers.
12516         (aarch64_pseudo_register_name): Likewise.
12517         (aarch64_pseudo_register_type): Likewise.
12518         (aarch64_pseudo_register_reggroup_p): Likewise.
12519         (aarch64_gdbarch_init): Add pauth registers.
12520         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12521         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12522         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12523         (struct gdbarch_tdep): Add regnum for ra_state.
12524
12525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12526             Jiong Wang  <jiong.wang@arm.com>
12527
12528         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12529
12530 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12531             Jiong Wang  <jiong.wang@arm.com>
12532
12533         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12534         function.
12535         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12536         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12537         (aarch64_gdbarch_init): Add puth registers.
12538         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12539         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12540         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12541
12542 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12543             Jiong Wang  <jiong.wang@arm.com>
12544
12545         * aarch64-linux-nat.c
12546         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12547         * aarch64-linux-tdep.c
12548         (aarch64_linux_core_read_description): Likewise.
12549         (aarch64_linux_get_hwcap): New function.
12550         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12551         (aarch64_linux_get_hwcap): New declaration.
12552
12553 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12554             Jiong Wang  <jiong.wang@arm.com>
12555
12556         * aarch64-linux-nat.c
12557         (aarch64_linux_nat_target::read_description): Add pauth param.
12558         * aarch64-linux-tdep.c
12559         (aarch64_linux_core_read_description): Likewise.
12560         * aarch64-tdep.c (struct target_desc): Add in pauth.
12561         (aarch64_read_description): Add pauth param.
12562         (aarch64_gdbarch_init): Likewise.
12563         * aarch64-tdep.h (aarch64_read_description): Likewise.
12564         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12565         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12566         * features/Makefile: Add new files.
12567         * features/aarch64-pauth.c: New file.
12568         * features/aarch64-pauth.xml: New file.
12569
12570 2019-03-20  Tom Tromey  <tromey@adacore.com>
12571
12572         * infrun.c (handle_inferior_event): Rename from
12573         handle_inferior_event_1.  Create a scoped_value_mark.
12574         (handle_inferior_event): Remove.
12575
12576 2019-03-19  Tom Tromey  <tromey@adacore.com>
12577
12578         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12579         * infrun.h (print_stop_event): Add "displays" parameter.
12580         * infrun.c (print_stop_event): Add "displays" parameter.
12581
12582 2019-03-19  Pedro Alves  <palves@redhat.com>
12583
12584         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12585         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12586         to -1.  Fix TABs vs spaces.
12587         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12588         * tui/tui-out.h (tui_ui_out) Add intro comments.
12589         <m_line, m_start_of_line>: In-class initialize, and add describing
12590         comment.
12591
12592 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12593
12594         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12595         variable names.
12596         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12597
12598 2019-03-18  Pedro Alves  <palves@redhat.com>
12599             Eli Zaretskii <eliz@gnu.org>
12600
12601         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12602         m_line and m_start_of_line.
12603
12604 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12605
12606         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12607         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12608         it returns a newline.  This fixes a regression in TU mode, whereby
12609         the next line is output on the same screen line as the user input.
12610
12611 2019-03-18  Tom Tromey  <tromey@adacore.com>
12612
12613         * minsyms.c (minimal_symbol_reader::install): Remove call to
12614         obstack_blank.
12615
12616 2019-03-18  Pedro Alves  <palves@redhat.com>
12617
12618         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12619         New globals.
12620         (apply_style): New, factored out from ...
12621         (apply_ansi_escape): ... this.  Handle reverse video mode.
12622         (tui_set_reverse_mode): New function.
12623         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12624         * tui/tui-winsource.c (tui_show_source_line): Use
12625         tui_set_reverse_mode instead of setting A_STANDOUT.
12626         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12627         New setter methods.
12628
12629 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12630
12631         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12632         Handle tabs.
12633
12634 2019-03-18  Tom Tromey  <tromey@adacore.com>
12635
12636         * ada-lang.c (empty_array): Add "high" parameter.
12637         (ada_evaluate_subexp): Update.
12638
12639 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12640
12641         * unittests/string_view-selftests.c: Define
12642         _initialize_string_view_selftests unconditionally.
12643
12644 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12645
12646         PR gdb/24350
12647         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12648
12649 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12650
12651         PR gdb/24351
12652         * windows-nat.c (display_selector): Fix format specifiers.
12653
12654 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12655
12656         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12657         tui_refill_source_window instead of tui_refresh_win, to update the
12658         current execution line.  This fixes redisplay of the current line
12659         when stepping through the code with "next" or "step".
12660
12661 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12662
12663         * source-cache.c (source_cache::get_source_lines): Call
12664         find_source_lines to initialize s->nlines.  This fixes vertical
12665         scrolling of TUI source window when the DOWN arrow is pressed.
12666
12667 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12668
12669         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12670         linux-thread-db.c (_initialize_thread_db): Likewise.
12671
12672 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12673
12674         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12675         wclrtoeol in tui_show_source_line".  This reverts changes made in
12676         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12677
12678 2019-03-15  Tom Tromey  <tom@tromey.com>
12679
12680         * symtab.h (struct minimal_symbol): Derive from
12681         general_symbol_info.
12682         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12683         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12684         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12685         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12686         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12687         (MSYMBOL_SEARCH_NAME): Update.
12688         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12689         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12690         * minsyms.c (minimal_symbol_reader::record_full): Update.
12691
12692 2019-03-15  Tom Tromey  <tom@tromey.com>
12693
12694         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12695
12696 2019-03-15  Tom Tromey  <tom@tromey.com>
12697
12698         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12699         unique_xmalloc_ptr.
12700         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12701         Update.
12702         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12703         (build_minimal_symbol_hash_tables)
12704         (minimal_symbol_reader::install): Update.
12705
12706 2019-03-15  Tom Tromey  <tom@tromey.com>
12707
12708         * symtab.c (create_demangled_names_hash): Update.
12709         (symbol_set_names): Update.
12710         * objfiles.h (struct objfile_per_bfd_storage)
12711         <demangled_names_hash>: Now an htab_up.
12712         * objfiles.c (objfile_per_bfd_storage): Simplify.
12713
12714 2019-03-15  Tom Tromey  <tom@tromey.com>
12715
12716         * objfiles.h (struct objfile_per_bfd_storage): Declare
12717         destructor.
12718         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12719         New.
12720         (get_objfile_bfd_data): Use new.  Don't initialize
12721         language_of_main.
12722         (free_objfile_per_bfd_storage): Remove.
12723         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12724
12725 2019-03-15  Tom Tromey  <tom@tromey.com>
12726
12727         * symfile.c (reread_symbols): Update.
12728         * objfiles.c (objfile::objfile): Update.
12729         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12730         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12731         comment.
12732         (minimal_symbol_reader::install): Update.
12733         (terminate_minimal_symbol_table): Remove.
12734         * jit.c (jit_object_close_impl): Update.
12735
12736 2019-03-15  Tom Tromey  <tom@tromey.com>
12737
12738         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12739         initializations.
12740
12741 2019-03-15  Tom Tromey  <tom@tromey.com>
12742
12743         * objfiles.h (struct objfile_per_bfd_storage)
12744         <demangled_hash_languages>: Now a bitset.
12745         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12746         (lookup_minimal_symbol): Update.
12747
12748 2019-03-15  Tom Tromey  <tom@tromey.com>
12749
12750         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12751         Don't return the symbol.
12752         * coffread.c (record_minimal_symbol): Use record_full.
12753
12754 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12755
12756         The MS-Windows port of ncurses fails to switch to a color pair if
12757         one or both of the colors are the implicit default colors.  This
12758         change records the default colors when TUI is initialized, and
12759         then specifies them explicitly when a color pair uses the default
12760         colors.  This allows color styling in TUI mode on MS-Windows.
12761
12762         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12763         ncurses_norm_attr.
12764         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12765         colors in ncurses_norm_attr.
12766         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12767         "none", replace it with the default color recorded in
12768         ncurses_norm_attr.
12769
12770 2019-03-14  Tom Tromey  <tromey@adacore.com>
12771
12772         * source-cache.h (class source_cache) <get_source_lines>: Return
12773         std::string.
12774         * source-cache.c (source_cache::extract_lines): Handle case where
12775         first_pos==npos.  Return std::string.
12776         (source_cache::get_source_lines): Update.
12777
12778 2019-03-14  Tom Tromey  <tromey@adacore.com>
12779
12780         * NEWS: Add item for "style sources" commands.
12781         * source-cache.c (source_cache::get_source_lines): Check
12782         source_styling.
12783         * cli/cli-style.c (source_styling): New global.
12784         (_initialize_cli_style): Add "style sources" commands.
12785         (show_style_sources): New function.
12786         * cli/cli-style.h (source_styling): Declare.
12787
12788 2019-03-14  Pedro Alves  <palves@redhat.com>
12789             Tom Tromey  <tromey@adacore.com>
12790
12791         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12792         * tui/tui-winsource.c (tui_refill_source_window): New function,
12793         from...
12794         (tui_horizontal_source_scroll): ... here.  Move some logic.
12795         * cli/cli-style.c (set_style_enabled): Notify new observable.
12796         * tui/tui-hooks.c (tui_redisplay_source): New function.
12797         (tui_attach_detach_observers): Attach or detach
12798         tui_redisplay_source.
12799         * observable.h (source_styling_changed): New observable.
12800         * observable.c: Define source_styling_changed observable.
12801
12802 2019-03-13  Tom Tromey  <tromey@adacore.com>
12803
12804         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12805         (i386_gnu_nat_target::store_registers): Update.
12806         * target-debug.h (target_debug_print_std_string): New macro.
12807         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12808         * windows-tdep.c (display_one_tib): Update.
12809         * tui/tui-stack.c (tui_make_status_line): Update.
12810         * top.c (print_inferior_quit_action): Update.
12811         * thread.c (thr_try_catch_cmd): Update.
12812         (add_thread_with_info): Update.
12813         (thread_target_id_str): Update.
12814         (thr_try_catch_cmd): Update.
12815         (thread_command): Update.
12816         (thread_find_command): Update.
12817         * record-btrace.c (record_btrace_target::info_record)
12818         (record_btrace_resume_thread, record_btrace_target::resume)
12819         (record_btrace_cancel_resume, record_btrace_step_thread)
12820         (record_btrace_target::wait, record_btrace_target::wait)
12821         (record_btrace_target::wait, record_btrace_target::stop): Update.
12822         * progspace.c (print_program_space): Update.
12823         * process-stratum-target.c
12824         (process_stratum_target::thread_address_space): Update.
12825         * linux-fork.c (linux_fork_mourn_inferior)
12826         (detach_checkpoint_command, info_checkpoints_command)
12827         (linux_fork_context): Update.
12828         (linux_fork_detach): Update.
12829         (class scoped_switch_fork_info): Update.
12830         (delete_checkpoint_command): Update.
12831         * infrun.c (follow_fork_inferior): Update.
12832         (follow_fork_inferior): Update.
12833         (proceed_after_vfork_done): Update.
12834         (handle_vfork_child_exec_or_exit): Update.
12835         (follow_exec): Update.
12836         (displaced_step_prepare_throw): Update.
12837         (displaced_step_restore): Update.
12838         (start_step_over): Update.
12839         (resume_1): Update.
12840         (clear_proceed_status_thread): Update.
12841         (proceed): Update.
12842         (print_target_wait_results): Update.
12843         (do_target_wait): Update.
12844         (context_switch): Update.
12845         (stop_all_threads): Update.
12846         (restart_threads): Update.
12847         (finish_step_over): Update.
12848         (handle_signal_stop): Update.
12849         (switch_back_to_stepped_thread): Update.
12850         (keep_going_pass_signal): Update.
12851         (print_exited_reason): Update.
12852         (normal_stop): Update.
12853         * inferior.c (inferior_pid_to_str): Change return type.
12854         (print_selected_inferior): Update.
12855         (add_inferior): Update.
12856         (detach_inferior): Update.
12857         * dummy-frame.c (fprint_dummy_frames): Update.
12858         * dcache.c (dcache_info_1): Update.
12859         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12860         (btrace_fetch, btrace_clear): Update.
12861         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12862         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12863         type.
12864         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12865         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12866         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12867         * gdbarch.c, gdbarch.h: Rebuild.
12868         * gdbarch.sh (core_pid_to_str): Change return type.
12869         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12870         return type.
12871         (windows_nat_target::pid_to_str): Change return type.
12872         (windows_delete_thread): Update.
12873         (windows_nat_target::attach): Update.
12874         (windows_nat_target::files_info): Update.
12875         * target-delegates.c: Rebuild.
12876         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12877         return type.
12878         (sol_thread_target::pid_to_str): Change return type.
12879         * remote.c (class remote_target) <pid_to_str>: Change return
12880         type.
12881         (remote_target::pid_to_str): Change return type.
12882         (extended_remote_target::attach, remote_target::remote_stop_ns)
12883         (remote_target::remote_notif_remove_queued_reply)
12884         (remote_target::push_stop_reply, remote_target::disable_btrace):
12885         Update.
12886         (extended_remote_target::attach): Update.
12887         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12888         type.
12889         (gdbsim_target::pid_to_str): Change return type.
12890         * ravenscar-thread.c (struct ravenscar_thread_target)
12891         <pid_to_str>: Change return type.
12892         (ravenscar_thread_target::pid_to_str): Change return type.
12893         * procfs.c (class procfs_target) <pid_to_str>: Change return
12894         type.
12895         (procfs_target::pid_to_str): Change return type.
12896         (procfs_target::attach): Update.
12897         (procfs_target::detach): Update.
12898         (procfs_target::fetch_registers): Update.
12899         (procfs_target::store_registers): Update.
12900         (procfs_target::wait): Update.
12901         (procfs_target::files_info): Update.
12902         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12903         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12904         return type.
12905         (nto_procfs_target::pid_to_str): Change return type.
12906         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12907         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12908         return type.
12909         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12910         (exit_lwp): Update.
12911         (attach_proc_task_lwp_callback, get_detach_signal)
12912         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12913         (linux_nat_target::resume, wait_lwp, stop_callback)
12914         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12915         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12916         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12917         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12918         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12919         type.
12920         (inf_ptrace_target::attach): Update.
12921         (inf_ptrace_target::files_info): Update.
12922         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12923         type.
12924         (go32_nat_target::pid_to_str): Change return type.
12925         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12926         (gnu_nat_target::wait): Update.
12927         (gnu_nat_target::wait): Update.
12928         (gnu_nat_target::resume): Update.
12929         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12930         (fbsd_nat_target::wait): Update.
12931         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12932         type.
12933         (darwin_nat_target::attach): Update.
12934         * corelow.c (class core_target) <pid_to_str>: Change return type.
12935         (core_target::pid_to_str): Change return type.
12936         * target.c (normal_pid_to_str): Change return type.
12937         (default_pid_to_str): Likewise.
12938         (target_pid_to_str): Change return type.
12939         (target_translate_tls_address): Update.
12940         (target_announce_detach): Update.
12941         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12942         return type.
12943         (bsd_uthread_target::pid_to_str): Change return type.
12944         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12945         type.
12946         (bsd_kvm_target::pid_to_str): Change return type.
12947         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12948         return type.
12949         (aix_thread_target::pid_to_str): Change return type.
12950         * target.h (struct target_ops) <pid_to_str>: Change return type.
12951         (target_pid_to_str, normal_pid_to_str): Likewise.
12952         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12953         type.
12954         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12955         type.
12956         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12957         return type.
12958         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12959         type.
12960         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12961         type.
12962         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12963         return type.
12964
12965 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12966
12967         * NEWS: Mention that the new default MI version is 3.  Mention
12968         changes to the output of commands and events that deal with
12969         multi-location breakpoints.
12970         * breakpoint.c: Include "mi/mi-out.h".
12971         (print_one_breakpoint): Change output syntax if using MI version
12972         >= 3.
12973         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12974         New.
12975         (mi_multi_location_breakpoint_output_fixed): New.
12976         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12977         (mi_cmd_fix_multi_location_breakpoint_output): New.
12978         (mi_multi_location_breakpoint_output_fixed): New.
12979         * mi/mi-cmds.c (mi_cmds): Register command
12980         -fix-multi-location-breakpoint-output.
12981         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12982         interpreter "mi".
12983
12984 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12985
12986         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12987         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12988         instantiate mi_ui_out based on interpreter name.
12989         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12990         * mi/mi-main.c (mi_load_progress): Likewise.
12991
12992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12993
12994         * NEWS: Combine separate "New targets" sections for 8.3.
12995
12996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12997
12998         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12999         (ppcfbsd_init_abi): Install gdbarch
13000         "fetch_tls_load_module_address" and "get_thread_local_address"
13001         methods.
13002
13003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13004
13005         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13006         (riscv_fbsd_init_abi): Install gdbarch
13007         "fetch_tls_load_module_address" and "get_thread_local_address"
13008         methods.
13009
13010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13011
13012         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13013         (i386fbsd_init_abi): Install gdbarch
13014         "fetch_tls_load_module_address" and "get_thread_local_address"
13015         methods.
13016
13017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13018
13019         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13020         (amd64fbsd_init_abi): Install gdbarch
13021         "fetch_tls_load_module_address" and "get_thread_local_address"
13022         methods.
13023
13024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13025
13026         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13027         (struct fbsd_pspace_data): New type.
13028         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13029         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13030         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13031         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13032         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13033
13034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13035
13036         * gdbtypes.c (lookup_struct_elt): New function.
13037         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13038         * gdbtypes.h (struct struct_elt): New type.
13039         (lookup_struct_elt): New prototype.
13040
13041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13042
13043         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13044         remove disabled code block.
13045
13046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13047
13048         * gdbarch.sh (get_thread_local_address): New method.
13049         * gdbarch.h, gdbarch.c: Regenerate.
13050         * target.c (target_translate_tls_address): Use
13051         gdbarch_get_thread_local_address if present instead of
13052         target::get_thread_local_address.
13053
13054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13055
13056         * target.h (target::get_thread_local_address): Update comment.
13057
13058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13059
13060         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13061         objfile->separate_debug_objfile_backlink if not NULL.
13062
13063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13064
13065         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13066         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13067         (amd64bsd_store_inferior_registers): Likewise.
13068         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13069         Enable segment base registers.
13070         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13071         PT_GETFSBASE and PT_GETGSBASE.
13072         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13073         PT_SETGSBASE.
13074         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13075         segment base registers.
13076         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13077
13078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13079
13080         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13081         Update calls to i386_target_description to add 'segments'
13082         parameter.
13083         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13084         add segment base registers.
13085         * arch/i386.c (i386_create_target_description): Add 'segments'
13086         parameter to enable segment base registers.
13087         * arch/i386.h (i386_create_target_description): Likewise.
13088         * features/i386/32bit-segments.xml: New file.
13089         * features/i386/32bit-segments.c: Generate.
13090         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13091         call to i386_target_description to add 'segments' parameter.
13092         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13093         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13094         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13095         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13096         if feature is present.
13097         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13098         Add 'segments' parameter to call to i386_target_description.
13099         (i386_target_description): Add 'segments' parameter to enable
13100         segment base registers.
13101         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13102         to call to i386_target_description.
13103         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13104         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13105         Define I386_NUM_REGS.
13106         (i386_target_description): Add 'segments' parameter to enable
13107         segment base registers.
13108
13109 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13110
13111         PR/24325
13112         * source-cache.c: #undef open and close, to avoid unresolved
13113         externals during linking.
13114
13115 2019-03-12  Tom Tromey  <tromey@adacore.com>
13116
13117         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13118         const.  Add initializers.
13119         (_initialize_remote): Don't initialize ptid globals.
13120
13121 2019-03-12  Pedro Alves  <palves@redhat.com>
13122
13123         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13124
13125 2019-03-12  Pedro Alves  <palves@redhat.com>
13126
13127         * cp-name-parser.y (main): Remove unused 'len' variable.
13128
13129 2019-03-12  Tom Tromey  <tromey@adacore.com>
13130
13131         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13132         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13133
13134 2019-03-12  Tom Tromey  <tromey@adacore.com>
13135
13136         * linux-nat.c (iterate_over_lwps): Update.
13137         (stop_callback): Remove parameter.
13138         (stop_wait_callback, detach_callback, resume_set_callback)
13139         (select_singlestep_lwp_callback, set_ignore_sigint)
13140         (status_callback, resumed_callback, resume_clear_callback)
13141         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13142         data parameter.
13143         (linux_nat_target::detach, linux_nat_target::resume)
13144         (linux_stop_and_wait_all_lwps, select_event_lwp)
13145         (linux_nat_filter_event, linux_nat_wait_1)
13146         (linux_nat_target::kill, linux_nat_target::stop)
13147         (linux_nat_target::stop): Update.
13148         (linux_nat_resume_callback): Change type.
13149         (resume_stopped_resumed_lwps, count_events_callback)
13150         (select_event_lwp_callback): Likewise.
13151         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13152         * arm-linux-nat.c (struct update_registers_data): Remove.
13153         (update_registers_callback): Change type.
13154         (arm_linux_insert_hw_breakpoint1): Update.
13155         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13156         parameter.
13157         (x86_linux_dr_set_addr): Update.
13158         (x86_linux_dr_set_control): Update.
13159         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13160         (iterate_over_lwps): Use gdb::function_view.
13161         * nat/aarch64-linux-hw-point.c (struct
13162         aarch64_dr_update_callback_param): Remove.
13163         (debug_reg_change_callback): Change type.
13164         (aarch64_notify_debug_reg_change): Update.
13165         * s390-linux-nat.c (s390_refresh_per_info): Update.
13166
13167 2019-03-11  Tom Tromey  <tromey@adacore.com>
13168
13169         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13170         redundant assignment to "this_cu".
13171
13172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13173
13174         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13175
13176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13177
13178         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13179         from...
13180         (rank_one_type): ... this.
13181
13182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13183
13184         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13185         from...
13186         (rank_one_type): ... this.
13187
13188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13189
13190         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13191         from...
13192         (rank_one_type): ... this.
13193
13194 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13195
13196         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13197         from...
13198         (rank_one_type): ... this.
13199
13200 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13201
13202         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13203         from...
13204         (rank_one_type): ... this.
13205
13206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13207
13208         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13209         from...
13210         (rank_one_type): ... this.
13211
13212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13213
13214         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13215         from...
13216         (rank_one_type): ... this.
13217
13218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13219
13220         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13221         from...
13222         (rank_one_type): ... this.
13223
13224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13225
13226         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13227         from...
13228         (rank_one_type): ... this.
13229
13230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13231
13232         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13233         from...
13234         (rank_one_type): ... this.
13235
13236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13237
13238         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13239         from...
13240         (rank_one_type): ... this.
13241
13242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13243
13244         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13245         from...
13246         (rank_one_type): ... this.
13247
13248 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13249
13250         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13251         inferior-events' shows the example events.
13252
13253 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13254
13255         Support styling on native MS-Windows console
13256
13257         PR/24315
13258         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13259         on MS-Windows if $TERM is not defined.
13260
13261         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13262
13263         * posix-hdep.c (gdb_console_fputs):
13264         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13265         functions.
13266         * ui-file.h (gdb_console_fputs): Add prototype.
13267
13268         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13269         back to fputs only if the former returns zero.
13270
13271 2019-03-07  Tom Tromey  <tom@tromey.com>
13272
13273         * symmisc.c (print_symbol_bcache_statistics): Update.
13274         (print_objfile_statistics): Update.
13275         * symfile.c (allocate_symtab): Update.
13276         * stabsread.c: Don't include bcache.h.
13277         * psymtab.h (struct psymbol_bcache): Don't declare.
13278         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13279         (psymbol_bcache_init, psymbol_bcache_free)
13280         (psymbol_bcache_get_bcache): Don't declare.
13281         * psymtab.c (struct psymbol_bcache): Remove.
13282         (psymtab_storage::psymtab_storage): Update.
13283         (psymtab_storage::~psymtab_storage): Update.
13284         (psymbol_bcache_init, psymbol_bcache_free)
13285         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13286         (add_psymbol_to_bcache): Update.
13287         (allocate_psymtab): Update.
13288         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13289         macro_cache>: No longer pointers.
13290         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13291         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13292         * macrotab.c (macro_bcache): Update.
13293         * macroexp.c: Don't include bcache.h.
13294         * gdbtypes.c (check_types_worklist): Update.
13295         (types_deeply_equal): Remove TRY/CATCH.  Update.
13296         * elfread.c (elf_symtab_read): Update.
13297         * dwarf2read.c: Don't include bcache.h.
13298         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13299         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13300         (print_bcache_statistics, bcache_memory_used): Don't declare.
13301         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13302         methods.  Rename all data members.
13303         * bcache.c (struct bcache): Move to bcache.h.
13304         (bcache::expand_hash_table): Rename from expand_hash_table.
13305         (bcache): Remove.
13306         (bcache::insert): Rename from bcache_full.
13307         (bcache::compare): Rename from bcache_compare.
13308         (bcache_xmalloc): Remove.
13309         (bcache::~bcache): Rename from bcache_xfree.
13310         (bcache::print_statistics): Rename from print_bcache_statistics.
13311         (bcache::memory_used): Rename from bcache_memory_used.
13312
13313 2019-03-07  Pedro Alves  <palves@redhat.com>
13314
13315         * infrun.c (normal_stop): Also check for
13316         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13317
13318 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13319
13320         * f-lang.c (value_from_host_double): Moved to...
13321         * value.c (value_from_host_double): ...here.
13322         * value.h (value_from_host_double): Declare.
13323         * guile/scm-math.c (vlscm_convert_typed_number): Use
13324         value_from_host_double.
13325         (vlscm_convert_number): Likewise.
13326         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13327         * python/py-value.c (convert_value_from_python): Likewise.
13328
13329 2019-03-06  Tom Tromey  <tom@tromey.com>
13330
13331         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13332
13333 2019-03-06  Tom Tromey  <tom@tromey.com>
13334
13335         * utils.h (free_current_contents): Don't declare.
13336         * utils.c (free_current_contents): Remove.
13337
13338 2019-03-06  Tom Tromey  <tom@tromey.com>
13339
13340         * top.c (quit_force): Update.
13341         * main.c (captured_command_loop): Update.
13342         * common/new-op.c (operator new): Update.
13343         * common/common-exceptions.c (struct catcher)
13344         <save_cleanup_chain>: Remove member.
13345         (exceptions_state_mc_init): Update.
13346         (exception_try_scope_entry): Return nullptr.
13347         (exception_try_scope_exit, exception_rethrow)
13348         (throw_exception_sjlj, throw_exception_cxx): Update.
13349         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13350         (all_cleanups, do_cleanups, discard_cleanups)
13351         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13352         (restore_cleanups, restore_final_cleanups): Don't declare.
13353         (do_final_cleanups): Remove parameter.
13354         * common/cleanups.c (cleanup_chain, make_cleanup)
13355         (make_cleanup_dtor, all_cleanups, do_cleanups)
13356         (discard_my_cleanups, discard_cleanups)
13357         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13358         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13359         (null_cleanup): Remove.
13360         (do_final_cleanups): Remove parameter.
13361
13362 2019-03-06  Tom Tromey  <tom@tromey.com>
13363
13364         * remote.c (remote_target::remote_parse_stop_reply): Use
13365         unique_xmalloc_ptr.
13366
13367 2019-03-06  Tom Tromey  <tom@tromey.com>
13368
13369         * stabsread.c (struct stabs_field_info): Rename from field_info.
13370         <list, fnlist>: Add initializers.
13371         <obstack>: New member.
13372         (read_member_functions, read_struct_fields, read_baseclasses):
13373         Allocate on obstack.  Don't use cleanups.
13374         (read_one_struct_field, read_member_functions, read_struct_fields)
13375         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13376         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13377         (read_struct_type): Update.
13378
13379 2019-03-06  Tom Tromey  <tom@tromey.com>
13380
13381         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13382         * common/filestuff.h (make_cleanup_close): Don't declare.
13383         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13384         Remove.
13385
13386 2019-03-06  Tom Tromey  <tom@tromey.com>
13387
13388         * solib-aix.c: Use make_scope_exit.
13389
13390 2019-03-06  Tom Tromey  <tom@tromey.com>
13391
13392         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13393         Use make_scope_exit.
13394
13395 2019-03-06  Tom Tromey  <tom@tromey.com>
13396
13397         * solib-svr4.c (disable_probes_interface): Remove parameter.
13398         (svr4_handle_solib_event): Use make_scope_exit.
13399
13400 2019-03-06  Tom Tromey  <tom@tromey.com>
13401
13402         * remote.c (struct stop_reply_deleter): Remove.
13403         (stop_reply_up): Update.
13404         (struct stop_reply): Derive from notif_event.  Don't typedef.
13405         <regcache>: Now a std::vector.
13406         (stop_reply_xfree): Remove.
13407         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13408         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13409         (remote_target::discard_pending_stop_replies): Use delete.
13410         (remote_target::remote_parse_stop_reply): Update.
13411         (remote_target::process_stop_reply): Update.
13412         * remote-notif.h (struct notif_event): Add virtual destructor.
13413         Remove "dtr" member.
13414         (struct notif_client) <alloc_event>: Return a unique_ptr.
13415         (notif_event_xfree): Don't declare.
13416         (notif_event_up): New typedef.
13417         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13418         (notif_event_xfree, do_notif_event_xfree): Remove.
13419         (remote_notif_state_xfree): Update.
13420
13421 2019-03-06  Tom Tromey  <tom@tromey.com>
13422
13423         * infrun.c (displaced_step_clear_cleanup): Now a
13424         forward_scope_exit type.
13425         (displaced_step_prepare_throw): Update.
13426         (displaced_step_fixup): Update.
13427
13428 2019-03-06  Tom Tromey  <tom@tromey.com>
13429
13430         * inferior.h (class inferior): Update comment.
13431         * gdbthread.h (class thread_info): Update comment.
13432
13433 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13434             Tom Tromey  <tom@tromey.com>
13435
13436         * stabsread.h (struct stab_section_list): Remove.
13437         (coffstab_build_psymtabs): Update.
13438         * dbxread.c (symbuf_sections): Now a std::vector.
13439         (sect_idx): New global.
13440         (fill_symbuf): Update.
13441         (coffstab_build_psymtabs): Change type of stabsects parameter.
13442         Update.
13443         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13444         std::vector.
13445         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13446         (coff_locate_sections): Update.
13447         (coff_symfile_read): Remove cleanups.  Update.
13448         (init_stringtab): Add storage parameter.
13449         (free_stringtab, free_stringtab_cleanup): Remove.
13450         (init_lineno): Add storage parameter.
13451         (free_linetab, free_linetab_cleanup): Remove.
13452
13453 2019-03-06  Pedro Alves  <palves@redhat.com>
13454
13455         * linux-fork.c (fork_info::clobber_regs): Delete.
13456         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13457         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13458         comment.  Adjust.
13459         (scoped_switch_fork_info::scoped_switch_fork_info)
13460         (checkpoint_command, linux_fork_context): Adjust
13461         fork_save_infrun_state calls.
13462
13463 2019-03-06  Pedro Alves  <palves@redhat.com>
13464
13465         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13466         (inf_has_multiple_threads): Return 'bool' and rewrite using
13467         inferior_info::threads().
13468
13469 2019-03-06  Pedro Alves  <palves@redhat.com>
13470
13471         * linux-fork.c: Include <list>.
13472         (fork_list): Now a std::list instance.
13473         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13474         (forks_exist_p, find_last_fork): Adjust.
13475         (new_fork): Delete.
13476         (one_fork_p): New.
13477         (add_fork): Adjust.
13478         (free_fork): Delete, folded into fork_info::~fork_info().
13479         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13480         Adjust.
13481         (init_fork_list): Delete.
13482         (linux_fork_killall, linux_fork_mourn_inferior)
13483         (linux_fork_detach, info_checkpoints_command): Adjust.
13484         (_initialize_linux_fork): No longer call init_fork_list.
13485
13486 2019-03-06  Pedro Alves  <palves@redhat.com>
13487
13488         * linux-fork.c (new_fork): New, split out of ...
13489         (add_fork): ... this.  Return void.  Move "first fork" special
13490         case from here, to ...
13491         (checkpoint_command): ... here.
13492         * linux-linux.h (add_fork): Return void.
13493
13494 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13495
13496         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13497
13498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13499             Chris January  <chris.january@arm.com>
13500             David Lecomber  <david.lecomber@arm.com>
13501
13502         * f-exp.y: New token, UNOP_INTRINSIC.
13503         (exp): New pattern using UNOP_INTRINSIC token.
13504         (f77_keywords): Add 'abs' keyword.
13505         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13506         (value_from_host_double): New function.
13507         (evaluate_subexp_f): Support UNOP_ABS.
13508
13509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13510
13511         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13512         types.
13513
13514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13515
13516         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13517         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13518         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13519
13520 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13521
13522         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13523
13524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13525             Chris January  <chris.january@arm.com>
13526
13527         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13528         * f-exp.y: Define 'KIND' token.
13529         (exp): New pattern for KIND expressions.
13530         (ptype): Handle types with a kind extension.
13531         (direct_abs_decl): Extend to spot kind extensions.
13532         (f77_keywords): Add 'kind' to the list.
13533         (push_kind_type): New function.
13534         (convert_to_kind_type): New function.
13535         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13536         * parse.c (operator_length_standard): Likewise.
13537         * parser-defs.h (enum type_pieces): Add tp_kind.
13538         * std-operator.def: Add UNOP_KIND.
13539
13540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13541
13542         * f-exp.y (f_parse): Set yydebug.
13543
13544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13545
13546         * f-lang.c (evaluate_subexp_f): New function.
13547         (exp_descriptor_f): New global.
13548         (f_language_defn): Use exp_descriptor_f instead of
13549         exp_descriptor_standard.
13550
13551 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13552
13553         * f-exp.y (struct token): Add comments.
13554         (dot_ops): Remove uppercase versions and the end marker.
13555         (f77_keywords): Likewise.
13556         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13557         entries in the dot_ops array are case insensitive, and use
13558         strncasecmp to compare strings.  Also some whitespace cleanup in
13559         this area.  Similar for the f77_keywords array, except entries in
13560         this list might be case sensitive.
13561
13562 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13563
13564         * f-exp.y (struct f77_boolean_val): Add comments.
13565         (boolean_values): Remove uppercase versions, and end marker.
13566         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13567         and use strncasecmp to achieve case insensitivity.  Additionally,
13568         perform whitespace cleanup around this code.
13569
13570 2019-03-06  Tom Tromey  <tromey@adacore.com>
13571
13572         * remote-sim.c (gdbsim_target_open): Use result of
13573         gdb_argv::release.
13574
13575 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13576         Dirk Schubert  <dirk.schubert@arm.com>
13577         Chris January  <chris.january@arm.com>
13578
13579         * eval.c (evaluate_subexp_standard): Call Fortran argument
13580         wrapping logic.
13581         * f-lang.c (struct value): A value which can be passed into a
13582         Fortran function call.
13583         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13584         where appropriate.
13585         (struct type): Value ready for a Fortran function call.
13586         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13587         is needed.
13588         * f-lang.h (fortran_argument_convert): Declaration.
13589         (fortran_preserve_arg_pointer): Declaration.
13590         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13591
13592 2019-03-05  Tom Tromey  <tromey@adacore.com>
13593
13594         * python/py-prettyprint.c (print_string_repr): Remove #if.
13595         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13596
13597 2019-03-05  Tom Tromey  <tromey@adacore.com>
13598
13599         * target.c (the_dummy_target): Move later.  Change type to
13600         "dummy_target".
13601         (initialize_targets): Don't initialize the_dummy_target.
13602
13603 2019-03-05  Tom Tromey  <tromey@adacore.com>
13604
13605         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13606         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13607
13608 2019-03-05  Tom Tromey  <tromey@adacore.com>
13609
13610         * windows-nat.c (windows_nat_target::attach)
13611         (windows_nat_target::detach): Don't call gdb_flush.
13612         * valprint.c (generic_val_print, val_print, val_print_string):
13613         Don't call gdb_flush.
13614         * utils.c (defaulted_query): Don't call gdb_flush.
13615         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13616         * target.c (target_announce_detach): Don't call gdb_flush.
13617         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13618         * remote.c (extended_remote_target::attach): Don't call
13619         gdb_flush.
13620         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13621         * printcmd.c (do_examine): Don't call gdb_flush.
13622         (info_display_command): Don't call gdb_flush.
13623         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13624         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13625         * memattr.c (info_mem_command): Don't call gdb_flush.
13626         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13627         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13628         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13629         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13630         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13631         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13632         (gnu_nat_target::detach): Don't call gdb_flush.
13633         * f-valprint.c (f_val_print): Don't call gdb_flush.
13634         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13635         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13636         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13637         gdb_flush.
13638         * c-valprint.c (c_val_print): Don't call gdb_flush.
13639         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13640
13641 2019-03-05  Tom Tromey  <tromey@adacore.com>
13642
13643         * varobj.c (update_dynamic_varobj_children): Update.
13644         (install_default_visualizer): Use reset, not release.
13645         * value.c (set_internalvar): Update.
13646         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13647         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13648         ATTRIBUTE_UNUSED_RESULT.
13649
13650 2019-03-05  Tom Tromey  <tromey@adacore.com>
13651
13652         * remote.c (class scoped_remote_fd) <release>: Add
13653         ATTRIBUTE_UNUSED_RESULT.
13654
13655 2019-03-05  Tom Tromey  <tromey@adacore.com>
13656
13657         * macroexp.c (struct macro_buffer) <release>: Add
13658         ATTRIBUTE_UNUSED_RESULT.
13659
13660 2019-03-05  Tom Tromey  <tromey@adacore.com>
13661
13662         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13663         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13664         ATTRIBUTE_UNUSED_RESULT.
13665
13666 2019-03-05  Tom Tromey  <tromey@adacore.com>
13667
13668         * common/scoped_fd.h (class scoped_fd) <release>: Add
13669         ATTRIBUTE_UNUSED_RESULT.
13670
13671 2019-03-05  Tom Tromey  <tromey@adacore.com>
13672
13673         * parser-defs.h (struct parser_state) <release>: Add
13674         ATTRIBUTE_UNUSED_RESULT.
13675
13676 2019-03-05  Tom Tromey  <tromey@adacore.com>
13677
13678         * utils.h (class gdb_argv) <release>: Add
13679         ATTRIBUTE_UNUSED_RESULT.
13680         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13681
13682 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13683
13684         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13685         for-loop range, to avoid compiler warnings.
13686
13687         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13688         avoid compiler warnings about unused variables.
13689
13690         * NEWS: Mention end of support for native debugging on MS-Windows
13691         before XP.
13692
13693         PR gdb/24292
13694         * common/netstuff.c:
13695         * gdbserver/gdbreplay.c
13696         * gdbserver/remote-utils.c:
13697         * ser-tcp.c:
13698         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13699         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13700         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13701         'getaddrinfo' and 'freeaddrinfo' were not available before
13702         Windows XP, and mingw.org's MinGW headers by default define
13703         _WIN32_WINNT to 0x500.
13704
13705 2019-03-01  Gary Benson <gbenson@redhat.com>
13706
13707         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13708
13709 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13710             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13711
13712         PR gdb/8527
13713         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13714         set_sigint_trap, clear_sigint_trap.
13715
13716 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13717
13718         * target.c (target_detach): Clear the regcache and the
13719         frame cache.
13720
13721 2019-02-27  Pedro Alves  <palves@redhat.com>
13722
13723         * utils.c (set_screen_size): When we cap the height/width sizes,
13724         tweak the corresponding command variable to show "unlimited":
13725
13726 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13727             Pedro Alves  <palves@redhat.com>
13728
13729         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13730         before calling rl_set_screen_size.
13731
13732 2019-02-27  Tom Tromey  <tromey@adacore.com>
13733
13734         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13735         define.
13736         * python/py-value.c: Remove Python 2.4 workaround.
13737         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13738         workaround.
13739         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13740         Python 2.4 workaround.
13741         * python/python-internal.h: Remove Python 2.4 comment.
13742         (Py_ssize_t): Don't define.
13743         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13744         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13745         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13746         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13747         * python/python.c (do_start_initialization): Remove Python 2.4
13748         workaround.
13749         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13750         (print_children): Remove Python 2.4 workaround.
13751         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13752         workaround.
13753         (CHARBUFFERPROC_NAME): Remove.
13754         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13755         Python 2.4 workaround.
13756
13757 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13758
13759         * NEWS: Note minimum Python version.
13760
13761 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13762
13763         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13764         code from these functions.  Remove corresponding ifdefs.  Use
13765         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13766         Remove gotos and target of gotos.
13767         (infpy_search_memory): Likewise.
13768
13769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13770
13771         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13772         (hppa_gdbarch_init): Don't register deleted functions with
13773         gdbarch.
13774
13775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13776
13777         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13778         (h8300_unwind_sp): Delete.
13779         (h8300_dummy_id): Delete.
13780         (h8300_gdbarch_init): Don't register deleted functions with
13781         gdbarch.
13782
13783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13784
13785         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13786         (ft32_unwind_pc): Delete.
13787         (ft32_unwind_sp): Delete.
13788         (ft32_gdbarch_init): Don't register deleted functions with
13789         gdbarch.
13790
13791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13792
13793         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13794         (frv_unwind_pc): Delete.
13795         (frv_unwind_sp): Delete.
13796         (frv_gdbarch_init): Don't register deleted functions with
13797         gdbarch.
13798
13799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13800
13801         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13802         (riscv_unwind_pc): Delete.
13803         (riscv_unwind_sp): Delete.
13804         (riscv_gdbarch_init): Don't register deleted functions with
13805         gdbarch.
13806
13807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13808
13809         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13810         (csky_unwind_pc): Delete.
13811         (csky_unwind_sp): Delete.
13812         (csky_gdbarch_init): Don't register deleted functions with
13813         gdbarch.
13814
13815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13816
13817         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13818         (cris_unwind_pc): Delete.
13819         (cris_unwind_sp): Delete.
13820         (cris_gdbarch_init): Don't register deleted functions with
13821         gdbarch.
13822
13823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13824
13825         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13826         (bfin_unwind_pc): Delete.
13827         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13828
13829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13830
13831         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13832         (arm_unwind_pc): Delete.
13833         (arm_unwind_sp): Delete.
13834         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13835
13836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13837
13838         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13839         (arc_unwind_pc): Delete.
13840         (arc_unwind_sp): Delete.
13841         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13842
13843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13844
13845         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13846         (alpha_unwind_pc): Delete.
13847         (alpha_gdbarch_init): Don't register deleted functions with
13848         gdbarch.
13849
13850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13851
13852         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13853         (aarch64_unwind_pc): Delete.
13854         (aarch64_unwind_sp): Delete.
13855         (aarch64_gdbarch_init): Don't register deleted functions with
13856         gdbarch.
13857
13858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13859
13860         * gdbtypes.c (type_align): Don't consider static members when
13861         computing structure alignment.
13862
13863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13864
13865         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13866         return 0 for other types.
13867         * arch-utils.c (default_type_align): Always return 0.
13868         * gdbarch.h: Regenerate.
13869         * gdbarch.sh (type_align): Extend comment.
13870         * gdbtypes.c (type_align): Add additional comments, always call
13871         gdbarch_type_align before applying the default rules.
13872         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13873         generic code will then apply a suitable default.
13874         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13875         types, return 0 for other types.
13876
13877 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13878
13879         * NEWS: Create a new section for the next release branch.
13880         Rename the section of the current branch, now that it has
13881         been cut.
13882
13883 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13884
13885         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13886         * version.in: Bump version to 8.3.50.DATE-git.
13887
13888 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13889
13890         * aix-thread.c (ptid_cmp): Remove unused variable.
13891         (get_signaled_thread): Likewise.
13892         (store_regs_user_thread): Likewise.
13893         (store_regs_kernel_thread): Likewise.
13894         (fetch_regs_kernel_thread): Remove shadowed variable.
13895
13896 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13897
13898         * features/riscv/32bit-cpu.xml: Add register numbers.
13899         * features/riscv/32bit-fpu.c: Regenerate.
13900         * features/riscv/32bit-fpu.xml: Add register numbers.
13901         * features/riscv/64bit-cpu.xml: Add register numbers.
13902         * features/riscv/64bit-fpu.c: Regenerate.
13903         * features/riscv/64bit-fpu.xml: Add register numbers.
13904
13905 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13906
13907         * NEWS: Mention two argument form of gdb.Value constructor.
13908         * python/py-value.c (convert_buffer_and_type_to_value): New
13909         function.
13910         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13911         Add support for handling an optional second argument.  Call
13912         convert_buffer_and_type_to_value as appropriate.
13913         * python/python-internal.h (Py_buffer_deleter): New struct.
13914         (Py_buffer_up): New typedef.
13915
13916 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13917
13918         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13919         instead of releasing ownership.
13920
13921 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13922
13923         * dwarf2read.c (open_and_init_dwp_file): Call
13924         elf_numsections instead of bfd_count_sections to initialize
13925         dwp_file->num_sections.
13926
13927 2019-02-25  Tom Tromey  <tromey@adacore.com>
13928
13929         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13930
13931 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13932
13933         * gcore.in: Add '--readnever' option when invoking GDB.
13934
13935 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13936
13937         * MAINTAINERS: Update my email address.
13938
13939 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13940
13941         * build-id.c (build_id_to_debug_bfd_1): New function.
13942         (build_id_to_debug_bfd): Look for separate debug file in
13943         sysroot.
13944
13945 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13946
13947         * gdbarch.sh: Update the copyright year range that is placed into
13948         generated files.
13949
13950 2019-02-22  Keith Seitz  <keiths@redhat.com>
13951
13952         PR symtab/23853
13953         * linespec.c (create_sals_line_offset): Search for the default
13954         symtab's filename instead of its fullname.
13955
13956 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13957
13958         * NEWS: Update style defaults.
13959
13960 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13961
13962         * main.c (captured_main_1): Disable styling in batch mode.
13963
13964 2019-02-20  Tom Tromey  <tom@tromey.com>
13965
13966         * symtab.c (symtab_symbol_info): Fix typos.
13967
13968 2019-02-20  Tom Tromey  <tromey@adacore.com>
13969
13970         * findcmd.c (_initialize_mem_search): Use upper case for
13971         metasyntactic variables.
13972
13973 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13974
13975         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13976         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13977
13978 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13979
13980         * top.h (source_file_name): Change to std::string.
13981         * top.c (source_file_name): Likewise.
13982         (command_line_input): Adjust.
13983         * cli/cli-script.c (script_from_file): Adjust.
13984
13985 2019-02-19  Tom Tromey  <tromey@adacore.com>
13986
13987         * ravenscar-thread.c
13988         (ravenscar_thread_target::update_thread_list): Don't call
13989         ada_build_task_list.
13990         * ada-lang.h (ada_build_task_list): Don't declare.
13991         * ada-tasks.c (struct ada_tasks_inferior_data)
13992         <task_list_valid_p>: Now bool.
13993         (read_known_tasks, ada_task_list_changed)
13994         (ada_tasks_invalidate_inferior_data): Update.
13995         (read_known_tasks_array): Return bool.
13996         (read_known_tasks_list): Likewise.
13997         (read_known_tasks): Return void.
13998         (ada_build_task_list): Now static.
13999
14000 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14001
14002         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14003         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14004
14005 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14006
14007         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14008         variant for ada_tasks_pspace_data_handle and
14009         ada_tasks_inferior_data_handle.
14010         (ada_tasks_pspace_data_cleanup): New function.
14011         (ada_tasks_inferior_data_cleanup): New function.
14012
14013 2019-02-17  Tom Tromey  <tom@tromey.com>
14014
14015         * macrotab.h (macro_source_fullname): Return a std::string.
14016         * macrotab.c (macro_include, check_for_redefinition)
14017         (macro_undef, macro_lookup_definition, foreach_macro)
14018         (foreach_macro_in_scope): Update.
14019         (macro_source_fullname): Return a std::string.
14020         * macrocmd.c (show_pp_source_pos): Update.
14021
14022 2019-02-17  Tom Tromey  <tom@tromey.com>
14023
14024         * macrocmd.c (show_pp_source_pos): Style the file names.
14025
14026 2019-02-17  Tom Tromey  <tom@tromey.com>
14027
14028         PR tui/24197:
14029         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14030
14031 2019-02-17  Tom Tromey  <tom@tromey.com>
14032
14033         * ada-lang.c (user_select_syms): Use filtered printing.
14034         * utils.c (wrap_style): New global.
14035         (desired_style): Remove.
14036         (emit_style_escape): Add stream parameter.
14037         (set_output_style, reset_terminal_style, prompt_for_continue):
14038         Update.
14039         (flush_wrap_buffer): Only flush gdb_stdout.
14040         (wrap_here): Set wrap_style.
14041         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14042         treat escape sequences as a character.  Change when wrap buffer is
14043         flushed.
14044         (fputs_styled): Do not set the output style when the default is
14045         requested.
14046         * ui-style.h (struct ui_file_style) <is_default>: New method.
14047         * source.c (print_source_lines_base): Emit escape sequences in one
14048         piece.
14049
14050 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14051
14052         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14053         integers and enumeration types.
14054
14055 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14056
14057         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14058         instead of lookup_symbol_in_language
14059         (do_exact_match): New function.
14060         (ada_get_symbol_name_matcher): Return do_exact_match when
14061         doing a verbatim match.
14062
14063 2019-02-15  Tom Tromey  <tromey@adacore.com>
14064
14065         * ravenscar-thread.c (ravenscar_thread_target::resume)
14066         (ravenscar_thread_target::wait): Special case wildcard requests.
14067
14068 2019-02-15  Tom Tromey  <tromey@adacore.com>
14069
14070         * ravenscar-thread.c (base_ptid): Remove.
14071         (struct ravenscar_thread_target) <close>: New method.
14072         <m_base_ptid>: New member.
14073         <update_inferior_ptid, active_task, task_is_currently_active,
14074         runtime_initialized>: Declare methods.
14075         <ravenscar_thread_target>: Add constructor.
14076         (ravenscar_thread_target::task_is_currently_active)
14077         (ravenscar_thread_target::update_inferior_ptid)
14078         (ravenscar_runtime_initialized): Rename.  Now methods.
14079         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14080         (ravenscar_thread_target::update_thread_list): Update.
14081         (ravenscar_thread_target::active_task): Now method.
14082         (ravenscar_thread_target::store_registers)
14083         (ravenscar_thread_target::prepare_to_store)
14084         (ravenscar_thread_target::prepare_to_store)
14085         (ravenscar_thread_target::mourn_inferior): Update.
14086         (ravenscar_inferior_created): Use "new" to create target.
14087         (ravenscar_thread_target::get_ada_task_ptid): Update.
14088         (_initialize_ravenscar): Don't initialize base_ptid.
14089         (ravenscar_ops): Remove global.
14090
14091 2019-02-15  Tom Tromey  <tromey@adacore.com>
14092
14093         * target.h (push_target): Declare new overload.
14094         * target.c (push_target): New overload, taking an rvalue reference.
14095         * remote.c (remote_target::open_1): Use push_target overload.
14096         * corelow.c (core_target_open): Use push_target overload.
14097
14098 2019-02-15  Tom Tromey  <tromey@adacore.com>
14099
14100         * ravenscar-thread.c (is_ravenscar_task)
14101         (ravenscar_task_is_currently_active): Return bool.
14102         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14103         (_initialize_ravenscar): Remove "(void)".
14104         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14105         Return bool.
14106
14107 2019-02-15  Tom Tromey  <tromey@adacore.com>
14108
14109         * ravenscar-thread.c (ravenscar_runtime_initializer)
14110         (has_ravenscar_runtime, get_running_thread_id)
14111         (ravenscar_thread_target::resume): Fix indentation.
14112
14113 2019-02-15  Tom Tromey  <tromey@adacore.com>
14114
14115         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14116         from ravenscar_arch_ops.
14117         (sparc_ravenscar_ops::fetch_registers)
14118         (sparc_ravenscar_ops::store_registers): Now methods.
14119         (sparc_ravenscar_prepare_to_store): Remove.
14120         (sparc_ravenscar_ops): Redefine.
14121         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14122         methods and destructor.  Remove members.
14123         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14124         (ravenscar_thread_target::store_registers)
14125         (ravenscar_thread_target::prepare_to_store): Update.
14126         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14127         Remove.
14128         (struct ppc_ravenscar_powerpc_ops): Derive from
14129         ravenscar_arch_ops.
14130         (ppc_ravenscar_powerpc_ops::fetch_registers)
14131         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14132         (ppc_ravenscar_powerpc_ops): Redefine.
14133         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14134         (ppc_ravenscar_e500_ops::fetch_registers)
14135         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14136         (ppc_ravenscar_e500_ops): Redefine.
14137         * aarch64-ravenscar-thread.c
14138         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14139         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14140         (aarch64_ravenscar_fetch_registers)
14141         (aarch64_ravenscar_store_registers): Now methods.
14142         (aarch64_ravenscar_ops): Redefine.
14143
14144 2019-02-15  Tom Tromey  <tromey@adacore.com>
14145
14146         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14147         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14148         (ravenscar_thread_target::stopped_by_watchpoint)
14149         (ravenscar_thread_target::stopped_data_address)
14150         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14151
14152 2019-02-15  Tom Tromey  <tromey@adacore.com>
14153
14154         * ravenscar-thread.c: Fix some typos.
14155
14156 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14157             Tom Tromey  <tromey@adacore.com>
14158
14159         * ada-lang.c (ada_exception_sal): Change addr_string to a
14160         std::string.
14161         (create_ada_exception_catchpoint): Update.
14162
14163 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14164             Tom Tromey  <tromey@adacore.com>
14165
14166         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14167         (bp_location_ops): Remove.
14168         (base_breakpoint_allocate_location): Update.
14169         (free_bp_location): Update.
14170         * ada-lang.c (class ada_catchpoint_location)
14171         <ada_catchpoint_location>: Remove ops parameter.
14172         (ada_catchpoint_location_dtor): Remove.
14173         (ada_catchpoint_location_ops): Remove.
14174         (allocate_location_exception): Update.
14175         * breakpoint.h (struct bp_location_ops): Remove.
14176         (class bp_location) <bp_location>: Remove bp_location_ops
14177         parameter.
14178         <~bp_location>: Add destructor.
14179         <ops>: Remove.
14180
14181 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14182             Pedro Alves  <palves@redhat.com>
14183
14184         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14185         'PATH_MAX'.
14186
14187 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14188             Samuel Thibault  <samuel.thibault@gnu.org>
14189             Thomas Schwinge  <thomas@codesourcery.com>
14190
14191         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14192         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14193
14194 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14195
14196         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14197         (check_empty): Use "const char *".
14198
14199         * gnu-nat.c (gnu_nat_target::detach): Instead of
14200         'detach_inferior (pid)' call
14201         'detach_inferior (find_inferior_pid (pid))'.
14202
14203         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14204         'nat/fork-inferior.o'.
14205         * gnu-nat.c: #include "nat/fork-inferior.h".
14206
14207         * gnu-nat.c (gnu_nat_target::detach): Instead of
14208         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14209         * gnu-nat.h: #include "inf-child.h".
14210         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14211         'i386_gnu_nat_target::fetch_registers'.
14212         (gnu_store_registers): Rename/move to
14213         'i386_gnu_nat_target::store_registers'.
14214
14215         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14216         * gnu-nat.h (mach_thread_info): New function.
14217         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14218
14219         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14220
14221 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14222
14223         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14224
14225 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14226
14227         * windows-nat.c (windows_add_thread): Add new parameter
14228         "main_thread_p" with default value set to false.  Update
14229         function documentation as well as all callers.
14230         (windows_delete_thread): Likewise.
14231         (fake_create_process): Update call to windows_add_thread.
14232         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14233         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14234         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14235         call to windows_delete_thread.
14236
14237 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14238
14239         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14240
14241 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14242
14243         * symfile.c (find_separate_debug_file): Use canonical path of
14244         sysroot with child_path instead of gdb_sysroot if it is valid.
14245
14246 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14247
14248         * symfile.c (find_separate_debug_file): Use child_path to
14249         determine if an object file is under a sysroot.
14250
14251 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14252
14253         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14254         unittests/child-path-selftests.c.
14255         * common/pathstuff.c (child_path): New function.
14256         * common/pathstuff.h (child_path): New prototype.
14257         * unittests/child-path-selftests.c: New file.
14258
14259 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14260
14261         * symfile.c (find_separate_debug_file): Look for separate debug
14262         files in debug directories under the sysroot.
14263
14264 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14265
14266         * symtab.h (struct minimal_symbol data_p): New const method.
14267         (struct minimal_symbol text_p): Likewise.
14268         * symtab.c (output_source_filename): Use file name style
14269         to print file name.
14270         (print_symbol_info): Likewise.
14271         (print_msymbol_info): Use address style to print addresses.
14272         Use function name style to print executable text symbols.
14273         (expand_symtab_containing_pc): Use data_p.
14274         (find_pc_sect_compunit_symtab): Likewise.
14275
14276 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14277
14278         * breakpoint.c (describe_other_breakpoints): Use address style
14279         to print addresses.
14280         (say_where): Likewise.
14281
14282 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14283
14284         * ada-typeprint.c (print_func_type): Print function name
14285         style to print function name.
14286         * c-typeprint.c (c_print_type_1): Likewise.
14287
14288 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14289
14290         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14291         for execve.
14292
14293 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14294
14295         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14296         type_stack.
14297
14298 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14299
14300         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14301         TYPE_CODE_REF types.
14302
14303 2019-02-08  Jim Wilson  <jimw@sifive.com>
14304
14305         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14306         (riscv_linux_fregset): New.
14307         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14308
14309 2019-02-07  Tom Tromey  <tom@tromey.com>
14310
14311         * thread.c (thread_cancel_execution_command): Update.
14312         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14313         methods.
14314         (struct thread_fsm_ops): Remove.
14315         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14316         (thread_fsm_should_stop, thread_fsm_return_value)
14317         (thread_fsm_set_finished, thread_fsm_finished_p)
14318         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14319         Don't declare.
14320         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14321         * infrun.c (clear_proceed_status_thread)
14322         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14323         (print_stop_event): Update.
14324         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14325         Add constructor.
14326         (step_command_fsm_ops): Remove.
14327         (new_step_command_fsm): Remove.
14328         (step_1): Update.
14329         (step_command_fsm::should_stop): Rename from
14330         step_command_fsm_should_stop.
14331         (step_command_fsm::clean_up): Rename from
14332         step_command_fsm_clean_up.
14333         (step_command_fsm::do_async_reply_reason): Rename from
14334         step_command_fsm_async_reply_reason.
14335         (struct until_next_fsm): Inherit from thread_fsm.  Add
14336         constructor.
14337         (until_next_fsm_ops): Remove.
14338         (new_until_next_fsm): Remove.
14339         (until_next_fsm::should_stop): Rename from
14340         until_next_fsm_should_stop.
14341         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14342         (until_next_fsm::do_async_reply_reason): Rename from
14343         until_next_fsm_async_reply_reason.
14344         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14345         constructor.  Change type of breakpoint.
14346         (finish_command_fsm_ops): Remove.
14347         (new_finish_command_fsm): Remove.
14348         (finish_command_fsm::should_stop): Rename from
14349         finish_command_fsm_should_stop.
14350         (finish_command_fsm::clean_up): Rename from
14351         finish_command_fsm_clean_up.
14352         (finish_command_fsm::return_value): Rename from
14353         finish_command_fsm_return_value.
14354         (finish_command_fsm::do_async_reply_reason): Rename from
14355         finish_command_fsm_async_reply_reason.
14356         (finish_command): Update.
14357         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14358         Add constructor.
14359         (call_thread_fsm_ops): Remove.
14360         (call_thread_fsm::call_thread_fsm): Rename from
14361         new_call_thread_fsm.
14362         (call_thread_fsm::should_stop): Rename from
14363         call_thread_fsm_should_stop.
14364         (call_thread_fsm::should_notify_stop): Rename from
14365         call_thread_fsm_should_notify_stop.
14366         (run_inferior_call, call_function_by_hand_dummy): Update.
14367         * cli/cli-interp.c (should_print_stop_to_console): Update.
14368         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14369         Add constructor.  Change type of location_breakpoint,
14370         caller_breakpoint.
14371         (until_break_fsm_ops): Remove.
14372         (new_until_break_fsm): Remove.
14373         (until_break_fsm::should_stop): Rename from
14374         until_break_fsm_should_stop.
14375         (until_break_fsm::clean_up): Rename from
14376         until_break_fsm_clean_up.
14377         (until_break_fsm::do_async_reply_reason): Rename from
14378         until_break_fsm_async_reply_reason.
14379         (until_break_command): Update.
14380         * thread-fsm.c: Remove.
14381         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14382
14383 2019-02-07  Tom Tromey  <tom@tromey.com>
14384
14385         * yy-remap.h: Add include guard.
14386         * xtensa-tdep.h: Add include guard.
14387         * xcoffread.h: Rename include guard.
14388         * varobj-iter.h: Add include guard.
14389         * tui/tui.h: Rename include guard.
14390         * tui/tui-winsource.h: Rename include guard.
14391         * tui/tui-wingeneral.h: Rename include guard.
14392         * tui/tui-windata.h: Rename include guard.
14393         * tui/tui-win.h: Rename include guard.
14394         * tui/tui-stack.h: Rename include guard.
14395         * tui/tui-source.h: Rename include guard.
14396         * tui/tui-regs.h: Rename include guard.
14397         * tui/tui-out.h: Rename include guard.
14398         * tui/tui-layout.h: Rename include guard.
14399         * tui/tui-io.h: Rename include guard.
14400         * tui/tui-hooks.h: Rename include guard.
14401         * tui/tui-file.h: Rename include guard.
14402         * tui/tui-disasm.h: Rename include guard.
14403         * tui/tui-data.h: Rename include guard.
14404         * tui/tui-command.h: Rename include guard.
14405         * tic6x-tdep.h: Add include guard.
14406         * target/waitstatus.h: Rename include guard.
14407         * target/wait.h: Rename include guard.
14408         * target/target.h: Rename include guard.
14409         * target/resume.h: Rename include guard.
14410         * target-float.h: Rename include guard.
14411         * stabsread.h: Add include guard.
14412         * rs6000-tdep.h: Add include guard.
14413         * riscv-fbsd-tdep.h: Add include guard.
14414         * regformats/regdef.h: Rename include guard.
14415         * record.h: Rename include guard.
14416         * python/python.h: Rename include guard.
14417         * python/python-internal.h: Rename include guard.
14418         * python/py-stopevent.h: Rename include guard.
14419         * python/py-ref.h: Rename include guard.
14420         * python/py-record.h: Rename include guard.
14421         * python/py-record-full.h: Rename include guard.
14422         * python/py-record-btrace.h: Rename include guard.
14423         * python/py-instruction.h: Rename include guard.
14424         * python/py-events.h: Rename include guard.
14425         * python/py-event.h: Rename include guard.
14426         * procfs.h: Add include guard.
14427         * proc-utils.h: Add include guard.
14428         * p-lang.h: Add include guard.
14429         * or1k-tdep.h: Rename include guard.
14430         * observable.h: Rename include guard.
14431         * nto-tdep.h: Rename include guard.
14432         * nat/x86-linux.h: Rename include guard.
14433         * nat/x86-linux-dregs.h: Rename include guard.
14434         * nat/x86-gcc-cpuid.h: Add include guard.
14435         * nat/x86-dregs.h: Rename include guard.
14436         * nat/x86-cpuid.h: Rename include guard.
14437         * nat/ppc-linux.h: Rename include guard.
14438         * nat/mips-linux-watch.h: Rename include guard.
14439         * nat/linux-waitpid.h: Rename include guard.
14440         * nat/linux-ptrace.h: Rename include guard.
14441         * nat/linux-procfs.h: Rename include guard.
14442         * nat/linux-osdata.h: Rename include guard.
14443         * nat/linux-nat.h: Rename include guard.
14444         * nat/linux-namespaces.h: Rename include guard.
14445         * nat/linux-btrace.h: Rename include guard.
14446         * nat/glibc_thread_db.h: Rename include guard.
14447         * nat/gdb_thread_db.h: Rename include guard.
14448         * nat/gdb_ptrace.h: Rename include guard.
14449         * nat/fork-inferior.h: Rename include guard.
14450         * nat/amd64-linux-siginfo.h: Rename include guard.
14451         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14452         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14453         * nat/aarch64-linux.h: Rename include guard.
14454         * nat/aarch64-linux-hw-point.h: Rename include guard.
14455         * mn10300-tdep.h: Add include guard.
14456         * mips-linux-tdep.h: Add include guard.
14457         * mi/mi-parse.h: Rename include guard.
14458         * mi/mi-out.h: Rename include guard.
14459         * mi/mi-main.h: Rename include guard.
14460         * mi/mi-interp.h: Rename include guard.
14461         * mi/mi-getopt.h: Rename include guard.
14462         * mi/mi-console.h: Rename include guard.
14463         * mi/mi-common.h: Rename include guard.
14464         * mi/mi-cmds.h: Rename include guard.
14465         * mi/mi-cmd-break.h: Rename include guard.
14466         * m2-lang.h: Add include guard.
14467         * location.h: Rename include guard.
14468         * linux-record.h: Rename include guard.
14469         * linux-nat.h: Add include guard.
14470         * linux-fork.h: Add include guard.
14471         * i386-darwin-tdep.h: Rename include guard.
14472         * hppa-linux-offsets.h: Add include guard.
14473         * guile/guile.h: Rename include guard.
14474         * guile/guile-internal.h: Rename include guard.
14475         * gnu-nat.h: Rename include guard.
14476         * gdb-stabs.h: Rename include guard.
14477         * frv-tdep.h: Add include guard.
14478         * f-lang.h: Add include guard.
14479         * event-loop.h: Add include guard.
14480         * darwin-nat.h: Rename include guard.
14481         * cp-abi.h: Rename include guard.
14482         * config/sparc/nm-sol2.h: Rename include guard.
14483         * config/nm-nto.h: Rename include guard.
14484         * config/nm-linux.h: Add include guard.
14485         * config/i386/nm-i386gnu.h: Rename include guard.
14486         * config/djgpp/nl_types.h: Rename include guard.
14487         * config/djgpp/langinfo.h: Rename include guard.
14488         * compile/gcc-cp-plugin.h: Add include guard.
14489         * compile/gcc-c-plugin.h: Add include guard.
14490         * compile/compile.h: Rename include guard.
14491         * compile/compile-object-run.h: Rename include guard.
14492         * compile/compile-object-load.h: Rename include guard.
14493         * compile/compile-internal.h: Rename include guard.
14494         * compile/compile-cplus.h: Rename include guard.
14495         * compile/compile-c.h: Rename include guard.
14496         * common/xml-utils.h: Rename include guard.
14497         * common/x86-xstate.h: Rename include guard.
14498         * common/version.h: Rename include guard.
14499         * common/vec.h: Rename include guard.
14500         * common/tdesc.h: Rename include guard.
14501         * common/selftest.h: Rename include guard.
14502         * common/scoped_restore.h: Rename include guard.
14503         * common/scoped_mmap.h: Rename include guard.
14504         * common/scoped_fd.h: Rename include guard.
14505         * common/safe-iterator.h: Rename include guard.
14506         * common/run-time-clock.h: Rename include guard.
14507         * common/refcounted-object.h: Rename include guard.
14508         * common/queue.h: Rename include guard.
14509         * common/ptid.h: Rename include guard.
14510         * common/print-utils.h: Rename include guard.
14511         * common/preprocessor.h: Rename include guard.
14512         * common/pathstuff.h: Rename include guard.
14513         * common/observable.h: Rename include guard.
14514         * common/netstuff.h: Rename include guard.
14515         * common/job-control.h: Rename include guard.
14516         * common/host-defs.h: Rename include guard.
14517         * common/gdb_wait.h: Rename include guard.
14518         * common/gdb_vecs.h: Rename include guard.
14519         * common/gdb_unlinker.h: Rename include guard.
14520         * common/gdb_unique_ptr.h: Rename include guard.
14521         * common/gdb_tilde_expand.h: Rename include guard.
14522         * common/gdb_sys_time.h: Rename include guard.
14523         * common/gdb_string_view.h: Rename include guard.
14524         * common/gdb_splay_tree.h: Rename include guard.
14525         * common/gdb_setjmp.h: Rename include guard.
14526         * common/gdb_ref_ptr.h: Rename include guard.
14527         * common/gdb_optional.h: Rename include guard.
14528         * common/gdb_locale.h: Rename include guard.
14529         * common/gdb_assert.h: Rename include guard.
14530         * common/filtered-iterator.h: Rename include guard.
14531         * common/filestuff.h: Rename include guard.
14532         * common/fileio.h: Rename include guard.
14533         * common/environ.h: Rename include guard.
14534         * common/common-utils.h: Rename include guard.
14535         * common/common-types.h: Rename include guard.
14536         * common/common-regcache.h: Rename include guard.
14537         * common/common-inferior.h: Rename include guard.
14538         * common/common-gdbthread.h: Rename include guard.
14539         * common/common-exceptions.h: Rename include guard.
14540         * common/common-defs.h: Rename include guard.
14541         * common/common-debug.h: Rename include guard.
14542         * common/cleanups.h: Rename include guard.
14543         * common/buffer.h: Rename include guard.
14544         * common/btrace-common.h: Rename include guard.
14545         * common/break-common.h: Rename include guard.
14546         * cli/cli-utils.h: Rename include guard.
14547         * cli/cli-style.h: Rename include guard.
14548         * cli/cli-setshow.h: Rename include guard.
14549         * cli/cli-script.h: Rename include guard.
14550         * cli/cli-interp.h: Rename include guard.
14551         * cli/cli-decode.h: Rename include guard.
14552         * cli/cli-cmds.h: Rename include guard.
14553         * charset-list.h: Add include guard.
14554         * buildsym-legacy.h: Rename include guard.
14555         * bfin-tdep.h: Add include guard.
14556         * ax.h: Rename include guard.
14557         * arm-linux-tdep.h: Add include guard.
14558         * arm-fbsd-tdep.h: Add include guard.
14559         * arch/xtensa.h: Rename include guard.
14560         * arch/tic6x.h: Add include guard.
14561         * arch/i386.h: Add include guard.
14562         * arch/arm.h: Rename include guard.
14563         * arch/arm-linux.h: Rename include guard.
14564         * arch/arm-get-next-pcs.h: Rename include guard.
14565         * arch/amd64.h: Add include guard.
14566         * arch/aarch64-insn.h: Rename include guard.
14567         * arch-utils.h: Rename include guard.
14568         * annotate.h: Add include guard.
14569         * amd64-darwin-tdep.h: Rename include guard.
14570         * aarch64-linux-tdep.h: Add include guard.
14571         * aarch64-fbsd-tdep.h: Add include guard.
14572         * aarch32-linux-nat.h: Add include guard.
14573
14574 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14575
14576         * macrotab.c (macro_define_internal): New function that
14577         factorizes macro_define_object_internal and macro_define_function
14578         code.
14579         (macro_define_object_internal): Use macro_define_internal.
14580         (macro_define_function): Likewise.
14581
14582 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14583
14584         * macrocmd.c (extract_identifier): Return
14585         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14586         callers.
14587
14588 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14589
14590         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14591
14592 2019-02-05  Tom Tromey  <tom@tromey.com>
14593
14594         * target.c (target_stack::unpush): Move assertion earlier.
14595
14596 2019-01-30  Tom Tromey  <tom@tromey.com>
14597
14598         PR python/23615:
14599         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14600         (gdbpy_parse_and_eval): Likewise.
14601         * python/python-internal.h (gdbpy_allow_threads): New class.
14602
14603 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14604
14605         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14606         (aarch64_fbsd_fpregmap): Move earlier.
14607         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14608         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14609         instead of individual calls to trad_frame_set_reg_addr.
14610         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14611         earlier.
14612         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14613         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14614         instead of individual calls to trad_frame_set_reg_addr.
14615
14616 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14617
14618         * CONTRIBUTE: Replace contribution list with wiki link.
14619
14620 2019-01-25  Tom Tromey  <tom@tromey.com>
14621
14622         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14623
14624 2019-01-25  Tom Tromey  <tom@tromey.com>
14625
14626         * xtensa-linux-nat.c: Fix common/ includes.
14627         * xml-support.h: Fix common/ includes.
14628         * xml-support.c: Fix common/ includes.
14629         * x86-linux-nat.c: Fix common/ includes.
14630         * windows-nat.c: Fix common/ includes.
14631         * varobj.h: Fix common/ includes.
14632         * varobj.c: Fix common/ includes.
14633         * value.c: Fix common/ includes.
14634         * valops.c: Fix common/ includes.
14635         * utils.c: Fix common/ includes.
14636         * unittests/xml-utils-selftests.c: Fix common/ includes.
14637         * unittests/utils-selftests.c: Fix common/ includes.
14638         * unittests/unpack-selftests.c: Fix common/ includes.
14639         * unittests/tracepoint-selftests.c: Fix common/ includes.
14640         * unittests/style-selftests.c: Fix common/ includes.
14641         * unittests/string_view-selftests.c: Fix common/ includes.
14642         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14643         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14644         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14645         * unittests/rsp-low-selftests.c: Fix common/ includes.
14646         * unittests/parse-connection-spec-selftests.c: Fix common/
14647         includes.
14648         * unittests/optional-selftests.c: Fix common/ includes.
14649         * unittests/offset-type-selftests.c: Fix common/ includes.
14650         * unittests/observable-selftests.c: Fix common/ includes.
14651         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14652         * unittests/memrange-selftests.c: Fix common/ includes.
14653         * unittests/memory-map-selftests.c: Fix common/ includes.
14654         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14655         * unittests/function-view-selftests.c: Fix common/ includes.
14656         * unittests/environ-selftests.c: Fix common/ includes.
14657         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14658         * unittests/common-utils-selftests.c: Fix common/ includes.
14659         * unittests/cli-utils-selftests.c: Fix common/ includes.
14660         * unittests/array-view-selftests.c: Fix common/ includes.
14661         * ui-file.c: Fix common/ includes.
14662         * tui/tui-io.c: Fix common/ includes.
14663         * tracepoint.h: Fix common/ includes.
14664         * tracepoint.c: Fix common/ includes.
14665         * tracefile-tfile.c: Fix common/ includes.
14666         * top.h: Fix common/ includes.
14667         * top.c: Fix common/ includes.
14668         * thread.c: Fix common/ includes.
14669         * target/waitstatus.h: Fix common/ includes.
14670         * target/waitstatus.c: Fix common/ includes.
14671         * target.h: Fix common/ includes.
14672         * target.c: Fix common/ includes.
14673         * target-memory.c: Fix common/ includes.
14674         * target-descriptions.c: Fix common/ includes.
14675         * symtab.h: Fix common/ includes.
14676         * symfile.c: Fix common/ includes.
14677         * stap-probe.c: Fix common/ includes.
14678         * spu-linux-nat.c: Fix common/ includes.
14679         * sparc-nat.c: Fix common/ includes.
14680         * source.c: Fix common/ includes.
14681         * solib.c: Fix common/ includes.
14682         * solib-target.c: Fix common/ includes.
14683         * ser-unix.c: Fix common/ includes.
14684         * ser-tcp.c: Fix common/ includes.
14685         * ser-pipe.c: Fix common/ includes.
14686         * ser-base.c: Fix common/ includes.
14687         * selftest-arch.c: Fix common/ includes.
14688         * s12z-tdep.c: Fix common/ includes.
14689         * rust-exp.y: Fix common/ includes.
14690         * rs6000-aix-tdep.c: Fix common/ includes.
14691         * riscv-tdep.c: Fix common/ includes.
14692         * remote.c: Fix common/ includes.
14693         * remote-notif.h: Fix common/ includes.
14694         * remote-fileio.h: Fix common/ includes.
14695         * remote-fileio.c: Fix common/ includes.
14696         * regcache.h: Fix common/ includes.
14697         * regcache.c: Fix common/ includes.
14698         * record-btrace.c: Fix common/ includes.
14699         * python/python.c: Fix common/ includes.
14700         * python/py-type.c: Fix common/ includes.
14701         * python/py-inferior.c: Fix common/ includes.
14702         * progspace.h: Fix common/ includes.
14703         * producer.c: Fix common/ includes.
14704         * procfs.c: Fix common/ includes.
14705         * proc-api.c: Fix common/ includes.
14706         * printcmd.c: Fix common/ includes.
14707         * ppc-linux-nat.c: Fix common/ includes.
14708         * parser-defs.h: Fix common/ includes.
14709         * osdata.c: Fix common/ includes.
14710         * obsd-nat.c: Fix common/ includes.
14711         * nat/x86-linux.c: Fix common/ includes.
14712         * nat/x86-linux-dregs.c: Fix common/ includes.
14713         * nat/x86-dregs.h: Fix common/ includes.
14714         * nat/x86-dregs.c: Fix common/ includes.
14715         * nat/ppc-linux.c: Fix common/ includes.
14716         * nat/mips-linux-watch.h: Fix common/ includes.
14717         * nat/mips-linux-watch.c: Fix common/ includes.
14718         * nat/linux-waitpid.c: Fix common/ includes.
14719         * nat/linux-ptrace.h: Fix common/ includes.
14720         * nat/linux-ptrace.c: Fix common/ includes.
14721         * nat/linux-procfs.c: Fix common/ includes.
14722         * nat/linux-personality.c: Fix common/ includes.
14723         * nat/linux-osdata.c: Fix common/ includes.
14724         * nat/linux-namespaces.c: Fix common/ includes.
14725         * nat/linux-btrace.h: Fix common/ includes.
14726         * nat/linux-btrace.c: Fix common/ includes.
14727         * nat/fork-inferior.c: Fix common/ includes.
14728         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14729         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14730         * nat/aarch64-linux.c: Fix common/ includes.
14731         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14732         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14733         * namespace.h: Fix common/ includes.
14734         * mips-linux-tdep.c: Fix common/ includes.
14735         * minsyms.c: Fix common/ includes.
14736         * mi/mi-parse.h: Fix common/ includes.
14737         * mi/mi-main.c: Fix common/ includes.
14738         * mi/mi-cmd-env.c: Fix common/ includes.
14739         * memrange.h: Fix common/ includes.
14740         * memattr.c: Fix common/ includes.
14741         * maint.h: Fix common/ includes.
14742         * maint.c: Fix common/ includes.
14743         * main.c: Fix common/ includes.
14744         * machoread.c: Fix common/ includes.
14745         * location.c: Fix common/ includes.
14746         * linux-thread-db.c: Fix common/ includes.
14747         * linux-nat.c: Fix common/ includes.
14748         * linux-fork.c: Fix common/ includes.
14749         * inline-frame.c: Fix common/ includes.
14750         * infrun.c: Fix common/ includes.
14751         * inflow.c: Fix common/ includes.
14752         * inferior.h: Fix common/ includes.
14753         * inferior.c: Fix common/ includes.
14754         * infcmd.c: Fix common/ includes.
14755         * inf-ptrace.c: Fix common/ includes.
14756         * inf-child.c: Fix common/ includes.
14757         * ia64-linux-nat.c: Fix common/ includes.
14758         * i387-tdep.c: Fix common/ includes.
14759         * i386-tdep.c: Fix common/ includes.
14760         * i386-linux-tdep.c: Fix common/ includes.
14761         * i386-linux-nat.c: Fix common/ includes.
14762         * i386-go32-tdep.c: Fix common/ includes.
14763         * i386-fbsd-tdep.c: Fix common/ includes.
14764         * i386-fbsd-nat.c: Fix common/ includes.
14765         * guile/scm-type.c: Fix common/ includes.
14766         * guile/guile.c: Fix common/ includes.
14767         * go32-nat.c: Fix common/ includes.
14768         * gnu-nat.c: Fix common/ includes.
14769         * gdbthread.h: Fix common/ includes.
14770         * gdbarch-selftests.c: Fix common/ includes.
14771         * gdb_usleep.c: Fix common/ includes.
14772         * gdb_select.h: Fix common/ includes.
14773         * gdb_bfd.c: Fix common/ includes.
14774         * gcore.c: Fix common/ includes.
14775         * fork-child.c: Fix common/ includes.
14776         * findvar.c: Fix common/ includes.
14777         * fbsd-nat.c: Fix common/ includes.
14778         * event-top.c: Fix common/ includes.
14779         * event-loop.c: Fix common/ includes.
14780         * dwarf2read.c: Fix common/ includes.
14781         * dwarf2loc.c: Fix common/ includes.
14782         * dwarf2-frame.c: Fix common/ includes.
14783         * dwarf-index-cache.c: Fix common/ includes.
14784         * dtrace-probe.c: Fix common/ includes.
14785         * disasm-selftests.c: Fix common/ includes.
14786         * defs.h: Fix common/ includes.
14787         * csky-tdep.c: Fix common/ includes.
14788         * cp-valprint.c: Fix common/ includes.
14789         * cp-support.h: Fix common/ includes.
14790         * cp-support.c: Fix common/ includes.
14791         * corelow.c: Fix common/ includes.
14792         * completer.h: Fix common/ includes.
14793         * completer.c: Fix common/ includes.
14794         * compile/compile.c: Fix common/ includes.
14795         * compile/compile-loc2c.c: Fix common/ includes.
14796         * compile/compile-cplus-types.c: Fix common/ includes.
14797         * compile/compile-cplus-symbols.c: Fix common/ includes.
14798         * command.h: Fix common/ includes.
14799         * cli/cli-dump.c: Fix common/ includes.
14800         * cli/cli-cmds.c: Fix common/ includes.
14801         * charset.c: Fix common/ includes.
14802         * build-id.c: Fix common/ includes.
14803         * btrace.h: Fix common/ includes.
14804         * btrace.c: Fix common/ includes.
14805         * breakpoint.h: Fix common/ includes.
14806         * breakpoint.c: Fix common/ includes.
14807         * ax.h:
14808         (enum agent_op): Fix common/ includes.
14809         * ax-general.c (struct aop_map): Fix common/ includes.
14810         * ax-gdb.c: Fix common/ includes.
14811         * auxv.c: Fix common/ includes.
14812         * auto-load.c: Fix common/ includes.
14813         * arm-tdep.c: Fix common/ includes.
14814         * arch/riscv.c: Fix common/ includes.
14815         * arch/ppc-linux-common.c: Fix common/ includes.
14816         * arch/i386.c: Fix common/ includes.
14817         * arch/arm.c: Fix common/ includes.
14818         * arch/arm-linux.c: Fix common/ includes.
14819         * arch/arm-get-next-pcs.c: Fix common/ includes.
14820         * arch/amd64.c: Fix common/ includes.
14821         * arch/aarch64.c: Fix common/ includes.
14822         * arch/aarch64-insn.c: Fix common/ includes.
14823         * arch-utils.c: Fix common/ includes.
14824         * amd64-windows-tdep.c: Fix common/ includes.
14825         * amd64-tdep.c: Fix common/ includes.
14826         * amd64-sol2-tdep.c: Fix common/ includes.
14827         * amd64-obsd-tdep.c: Fix common/ includes.
14828         * amd64-nbsd-tdep.c: Fix common/ includes.
14829         * amd64-linux-tdep.c: Fix common/ includes.
14830         * amd64-linux-nat.c: Fix common/ includes.
14831         * amd64-fbsd-tdep.c: Fix common/ includes.
14832         * amd64-fbsd-nat.c: Fix common/ includes.
14833         * amd64-dicos-tdep.c: Fix common/ includes.
14834         * amd64-darwin-tdep.c: Fix common/ includes.
14835         * agent.c: Fix common/ includes.
14836         * ada-lang.h: Fix common/ includes.
14837         * ada-lang.c: Fix common/ includes.
14838         * aarch64-tdep.c: Fix common/ includes.
14839
14840 2019-01-25  Tom Tromey  <tom@tromey.com>
14841
14842         * common/create-version.sh: Use common/version.h.
14843
14844 2019-01-24  Pedro Alves  <palves@redhat.com>
14845
14846         * infrun.c (signal_stop, signal_print, signal_program)
14847         (signal_catch, signal_pass): Now arrays instead of pointers.
14848         (update_signals_program_target, do_target_resume)
14849         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14850         * linux-nat.c (linux_nat_target::pass_signals)
14851         (linux_nat_target::create_inferior, linux_nat_target::attach):
14852         Adjust.
14853         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14854         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14855         * procfs.c (procfs_target::pass_signals): Adjust.
14856         * record-full.c (record_full_target::resume): Adjust.
14857         * remote.c (remote_target::pass_signals)
14858         (remote_target::program_signals): Adjust.
14859         * target-debug.h (target_debug_print_signals): Now takes a
14860         gdb::array_view as parameter.  Adjust.
14861         * target.h (target_ops) <pass_signals, program_signals>: Replace
14862         pointer and length parameters with gdb::array_view.
14863         (target_pass_signals, target_program_signals): Likewise.
14864         * target-delegates.c: Regenerate.
14865
14866 2019-01-24  Pedro Alves  <palves@redhat.com>
14867
14868         * common/forward-scope-exit.h
14869         (forward_scope_exit::forward_scope_exit): Pass arguments to
14870         m_bind_function directly, instead of creating a std::bind and
14871         copying that.
14872
14873 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14874
14875         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14876         for static members.
14877         (pass_in_v_vfp_candidate): Likewise.
14878
14879 2019-01-23  Tom Tromey  <tom@tromey.com>
14880             Pedro Alves  <palves@redhat.com>
14881
14882         * regcache.c (class regcache_invalidator): Remove.
14883         (regcache::raw_write): Use make_scope_exit.
14884
14885 2019-01-23  Tom Tromey  <tom@tromey.com>
14886
14887         * ui-out.h (class ui_out_emit_type): Update comment.
14888
14889 2019-01-23  Tom Tromey  <tom@tromey.com>
14890
14891         * infrun.c (fetch_inferior_event): Update comment.
14892
14893 2019-01-23  Tom Tromey  <tom@tromey.com>
14894             Pedro Alves  <palves@redhat.com>
14895
14896         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14897         parameter.
14898         (fetch_inferior_event): Use SCOPE_EXIT.
14899
14900
14901 2019-01-23  Tom Tromey  <tom@tromey.com>
14902             Pedro Alves  <palves@redhat.com>
14903
14904         * infrun.c (disable_thread_events): Delete.
14905         (stop_all_threads): Use SCOPE_EXIT.
14906
14907 2019-01-23  Tom Tromey  <tom@tromey.com>
14908             Pedro Alves  <palves@redhat.com>
14909
14910         * symfile.c: Include forward-scope-exit.h.
14911         (clear_symtab_users_cleanup): Replace forward declaration with
14912         a FORWARD_SCOPE_EXIT.
14913         (syms_from_objfile_1): Use the forward_scope_exit and
14914         gdb::optional instead of cleanup_function.
14915         (reread_symbols): Use the forward_scope_exit instead of
14916         cleanup_function.
14917         (clear_symtab_users_cleanup): Remove function.
14918
14919 2019-01-23  Tom Tromey  <tom@tromey.com>
14920             Pedro Alves  <palves@redhat.com>
14921
14922         * linux-nat.c: Include scope-exit.h.
14923         (cleanup_target_stop): Remove.
14924         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14925         SCOPE_EXIT.
14926
14927 2019-01-23  Tom Tromey  <tom@tromey.com>
14928             Pedro Alves  <palves@redhat.com>
14929
14930         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14931         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14932
14933 2019-01-23  Tom Tromey  <tom@tromey.com>
14934             Andrew Burgess  <andrew.burgess@embecosm.com>
14935             Pedro Alves  <palves@redhat.com>
14936
14937         * infrun.c (fetch_inferior_event): Use scope_exit.
14938         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14939         * top.c (execute_command): Use scope_exit.
14940         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14941         * utils.c (do_bpstat_clear_actions_cleanup)
14942         (make_bpstat_clear_actions_cleanup): Remove.
14943
14944 2019-01-23  Tom Tromey  <tom@tromey.com>
14945             Pedro Alves  <palves@redhat.com>
14946
14947         * infrun.c: Include "common/scope-exit.h"
14948         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14949         (wait_for_inferior): Use SCOPE_EXIT.
14950         (fetch_inferior_event): Use scope_exit.
14951
14952 2019-01-23  Tom Tromey  <tom@tromey.com>
14953             Pedro Alves  <palves@redhat.com>
14954
14955         * breakpoint.c (create_breakpoint): Remove cleanup.
14956
14957 2019-01-23  Tom Tromey  <tom@tromey.com>
14958             Andrew Burgess  <andrew.burgess@embecosm.com>
14959             Pedro Alves  <palves@redhat.com>
14960
14961 2019-01-23  Pedro Alves  <palves@redhat.com>
14962
14963         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14964
14965 2019-01-23  Pedro Alves  <palves@redhat.com>
14966             Andrew Burgess  <andrew.burgess@embecosm.com>
14967
14968         * gdbthread.h: Include "common/forward-scope-exit.h".
14969         (scoped_finish_thread_state): Redefine custom class in terms of
14970         forward_scope_exit.
14971
14972 2019-01-23  Pedro Alves  <palves@redhat.com>
14973             Andrew Burgess  <andrew.burgess@embecosm.com>
14974
14975         * common/forward-scope-exit.h: New file.
14976
14977 2019-01-23  Pedro Alves  <palves@redhat.com>
14978             Andrew Burgess  <andrew.burgess@embecosm.com>
14979             Tom Tromey  <tom@tromey.com>
14980
14981         * common/scope-exit.h: New file.
14982
14983 2019-01-23  Pedro Alves  <palves@redhat.com>
14984
14985         * common/preprocessor.h (ESC): Rename to ...
14986         (ESC_PARENS): ... this.
14987         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14988         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14989
14990 2019-01-23  Tom Tromey  <tom@tromey.com>
14991
14992         * language.h (class scoped_switch_to_sym_language_if_auto):
14993         Initialize m_lang in both cases.
14994
14995 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14996
14997         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14998         with XCNEW.
14999
15000 2019-01-22  Tom Tromey  <tom@tromey.com>
15001
15002         * corelow.c: Do not include sys/file.h.
15003
15004 2019-01-22  Tom Tromey  <tom@tromey.com>
15005
15006         * tui/tui-wingeneral.h: Include gdb_curses.h.
15007
15008 2019-01-22  Tom Tromey  <tom@tromey.com>
15009
15010         * source-cache.h (class source_cache) <get_source_lines,
15011         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15012
15013 2019-01-22  Tom Tromey  <tom@tromey.com>
15014
15015         * remote-fileio.h (struct remote_target): Declare.
15016
15017 2019-01-22  Tom Tromey  <tom@tromey.com>
15018
15019         * python/py-arch.c: Do not include py-ref.h.
15020         * python/py-bpevent.c: Do not include py-ref.h.
15021         * python/py-cmd.c: Do not include py-ref.h.
15022         * python/py-continueevent.c: Do not include py-ref.h.
15023         * python/py-event.h: Do not include py-ref.h.
15024         * python/py-evtregistry.c: Do not include py-ref.h.
15025         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15026         * python/py-frame.c: Do not include py-ref.h.
15027         * python/py-framefilter.c: Do not include py-ref.h.
15028         * python/py-function.c: Do not include py-ref.h.
15029         * python/py-infevents.c: Do not include py-ref.h.
15030         * python/py-linetable.c: Do not include py-ref.h.
15031         * python/py-objfile.c: Do not include py-ref.h.
15032         * python/py-param.c: Do not include py-ref.h.
15033         * python/py-prettyprint.c: Do not include py-ref.h.
15034         * python/py-progspace.c: Do not include py-ref.h.
15035         * python/py-symbol.c: Do not include py-ref.h.
15036         * python/py-symtab.c: Do not include py-ref.h.
15037         * python/py-type.c: Do not include py-ref.h.
15038         * python/py-unwind.c: Do not include py-ref.h.
15039         * python/py-utils.c: Do not include py-ref.h.
15040         * python/py-value.c: Do not include py-ref.h.
15041         * python/py-varobj.c: Do not include py-ref.h.
15042         * python/py-xmethods.c: Do not include py-ref.h.
15043         * python/python.c: Do not include py-ref.h.
15044         * varobj.c: Do not include py-ref.h.
15045
15046 2019-01-22  Tom Tromey  <tom@tromey.com>
15047
15048         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15049         keyword for bcache.
15050
15051 2019-01-22  Tom Tromey  <tom@tromey.com>
15052
15053         * compile/compile-cplus-types.c: Remove a comment by #include.
15054
15055 2019-01-22  Tom Tromey  <tom@tromey.com>
15056
15057         * compile/gcc-c-plugin.h: Include compile-internal.h.
15058
15059 2019-01-22  Tom Tromey  <tom@tromey.com>
15060
15061         * stabsread.c (EXTERN): Do not define.
15062         (symnum, next_symbol_text_func, processing_gcc_compilation)
15063         (within_function, global_sym_chain, global_stabs)
15064         (previous_stab_code, this_object_header_files)
15065         (n_this_object_header_files)
15066         (n_allocated_this_object_header_files): Define.
15067         * stabsread.h (EXTERN): Never define.  Use "extern".
15068
15069 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15070
15071         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15072         history_value.
15073
15074 2019-01-21  Tom Tromey  <tom@tromey.com>
15075
15076         * ui-out.c: Fix includes.
15077         * tui/tui-source.c: Fix includes.
15078         * target.c: Fix includes.
15079         * remote.c: Fix includes.
15080         * regcache.c: Fix includes.
15081         * python/py-block.c: Fix includes.
15082         * printcmd.c: Fix includes.
15083         * or1k-tdep.c: Fix includes.
15084         * mi/mi-main.c: Fix includes.
15085         * m32r-tdep.c: Fix includes.
15086         * csky-tdep.c: Fix includes.
15087         * compile/compile-cplus-types.c: Fix includes.
15088         * cli/cli-interp.c: Fix includes.
15089
15090 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15091
15092         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15093         for padding.
15094
15095 2019-01-16  Tom Tromey  <tom@tromey.com>
15096
15097         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15098         earlier.
15099         (struct objfile) <msymbols_range>: Move from top level.
15100         <msymbols>: New method.
15101         (class objfile_msymbols): Remove.
15102         * symtab.c (default_collect_symbol_completion_matches_break_on):
15103         Update.
15104         * symmisc.c (dump_msymbols): Update.
15105         * stabsread.c (scan_file_globals): Update.
15106         * objc-lang.c (info_selectors_command, info_classes_command)
15107         (find_methods): Update.
15108         * minsyms.c (find_solib_trampoline_target): Update.
15109         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15110         * coffread.c (coff_symfile_read): Update.
15111         * ada-lang.c (ada_lookup_simple_minsym)
15112         (ada_collect_symbol_completion_matches): Update.
15113
15114 2019-01-16  Tom Tromey  <tom@tromey.com>
15115
15116         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15117         type.  Remove no-argument constructor.
15118         <iterator::operator++>: Simplify.
15119         <begin>: Update.
15120         <end>: Use minimal_symbol_count.
15121
15122 2019-01-16  Tom Tromey  <tom@tromey.com>
15123
15124         * objfiles.h (struct objfile) <psymtabs>: New method.
15125         (class objfile_psymtabs): Remove.
15126         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15127         typedef.
15128         <range>: New method.
15129         (require_partial_symbols): Change return type.
15130         * psymtab.c (require_partial_symbols)
15131         (psym_expand_symtabs_matching): Update.
15132         * mdebugread.c (parse_partial_symbols): Update.
15133         * dbxread.c (dbx_end_psymtab): Update.
15134
15135 2019-01-15  Tom Tromey  <tom@tromey.com>
15136
15137         * symtab.c (lookup_objfile_from_block)
15138         (lookup_symbol_in_objfile_symtabs)
15139         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15140         (find_line_symtab, info_sources_command)
15141         (default_collect_symbol_completion_matches_break_on)
15142         (make_source_files_completion_list): Update.
15143         * symmisc.c (print_objfile_statistics, dump_objfile)
15144         (maintenance_print_symbols, maintenance_info_symtabs)
15145         (maintenance_check_symtabs, maintenance_info_line_tables):
15146         Update.
15147         * source.c (select_source_symtab)
15148         (forget_cached_source_info_for_objfile): Update.
15149         * objfiles.h (class objfile_compunits): Remove.
15150         (struct objfile) <compunits_range>: New typedef.
15151         (compunits): New method.
15152         * objfiles.c (objfile_relocate1): Update.
15153         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15154         * maint.c (count_symtabs_and_blocks): Update.
15155         * linespec.c (iterate_over_all_matching_symtabs): Update.
15156         * cp-support.c (add_symbol_overload_list_qualified): Update.
15157         * coffread.c (coff_symtab_read): Update.
15158         * ada-lang.c (add_nonlocal_symbols)
15159         (ada_collect_symbol_completion_matches)
15160         (ada_add_global_exceptions): Update.
15161
15162 2019-01-15  Tom Tromey  <tom@tromey.com>
15163
15164         * progspace.h (program_space) <objfiles_safe_range>: New
15165         typedef.
15166         <objfiles_safe>: New method.
15167         * objfiles.h (class all_objfiles_safe): Remove.
15168         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15169         * jit.c (jit_inferior_exit_hook): Update.
15170
15171 2019-01-17  Tom Tromey  <tom@tromey.com>
15172
15173         * progspace.h (program_space) <objfiles_range>: New typedef.
15174         <objfiles>: New method.
15175         <objfiles_head>: Rename from objfiles.
15176         (object_files): Update.
15177         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15178         * guile/scm-pretty-print.c
15179         (ppscm_find_pretty_printer_from_objfiles): Update.
15180         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15181         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15182         Update.
15183         * python/py-progspace.c (pspy_get_objfiles): Update.
15184         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15185         Update.
15186         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15187         (objfpy_lookup_objfile_by_build_id): Update.
15188         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15189         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15190         Update.
15191         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15192         (expand_symtab_containing_pc, lookup_objfile_from_block)
15193         (lookup_static_symbol, basic_lookup_transparent_type)
15194         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15195         (find_line_symtab, info_sources_command)
15196         (default_collect_symbol_completion_matches_break_on)
15197         (make_source_files_completion_list, find_main_name): Update.
15198         * symmisc.c (print_symbol_bcache_statistics)
15199         (print_objfile_statistics, maintenance_print_symbols)
15200         (maintenance_print_msymbols, maintenance_print_objfiles)
15201         (maintenance_info_symtabs, maintenance_check_symtabs)
15202         (maintenance_expand_symtabs, maintenance_info_line_tables):
15203         Update.
15204         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15205         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15206         (map_overlay_command, unmap_overlay_command)
15207         (simple_overlay_update, expand_symtabs_matching)
15208         (map_symbol_filenames): Update.
15209         * symfile-debug.c (set_debug_symfile): Update.
15210         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15211         Update.
15212         * source.c (select_source_symtab, forget_cached_source_info):
15213         Update.
15214         * solib.c (solib_read_symbols): Update.
15215         * solib-spu.c (append_ocl_sos): Update.
15216         * psymtab.c (maintenance_print_psymbols)
15217         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15218         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15219         * printcmd.c (info_symbol_command): Update.
15220         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15221         Update.
15222         * objfiles.h (class all_objfiles): Remove.
15223         * objfiles.c (have_partial_symbols, have_full_symbols)
15224         (have_minimal_symbols, qsort_cmp, update_section_map)
15225         (shared_objfile_contains_address_p)
15226         (default_iterate_over_objfiles_in_search_order): Update.
15227         * objc-lang.c (info_selectors_command, info_classes_command)
15228         (find_methods): Update.
15229         * minsyms.c (find_solib_trampoline_target): Update.
15230         * maint.c (maintenance_info_sections)
15231         (maintenance_translate_address, count_symtabs_and_blocks):
15232         Update.
15233         * main.c (captured_main_1): Update.
15234         * linux-thread-db.c (try_thread_db_load_from_pdir)
15235         (has_libpthread): Update.
15236         * linespec.c (iterate_over_all_matching_symtabs)
15237         (search_minsyms_for_name): Update.
15238         * jit.c (jit_find_objf_with_entry_addr): Update.
15239         * hppa-tdep.c (find_unwind_entry)
15240         (hppa_lookup_stub_minimal_symbol): Update.
15241         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15242         Update.
15243         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15244         (elf_gnu_ifunc_resolve_by_got): Update.
15245         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15246         * dwarf-index-write.c (save_gdb_index_command): Update.
15247         * cp-support.c (add_symbol_overload_list_qualified): Update.
15248         * breakpoint.c (create_overlay_event_breakpoint)
15249         (create_longjmp_master_breakpoint)
15250         (create_std_terminate_master_breakpoint)
15251         (create_exception_master_breakpoint): Update.
15252         * blockframe.c (find_pc_partial_function): Update.
15253         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15254         (ada_collect_symbol_completion_matches)
15255         (ada_add_global_exceptions): Update.
15256
15257 2019-01-17  Tom Tromey  <tom@tromey.com>
15258
15259         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15260         declare VEC.
15261         (solib_target_parse_libraries): Change return type.
15262         (library_list_start_segment, library_list_start_section)
15263         (library_list_end_library, library_list_start_library); Update.
15264         (solib_target_free_library_list): Remove.
15265         (solib_target_parse_libraries): Remove cleanup.  Change return
15266         type.
15267         (solib_target_current_sos): Update.
15268
15269 2019-01-17  Tom Tromey  <tromey@bapiya>
15270
15271         * valprint.c: Replace "the the" with "the".
15272         * symtab.c: Replace "the the" with "the".
15273         * solib.c: Replace "the the" with "the".
15274         * solib-dsbt.c: Replace "the the" with "the".
15275         * linespec.c: Replace "the the" with "the".
15276         * dwarf2loc.h: Replace "the the" with "the".
15277         * amd64-windows-tdep.c: Replace "the the" with "the".
15278         * aarch64-tdep.c: Replace "the the" with "the".
15279
15280 2019-01-16  Keith Seitz  <keiths@redhat.com>
15281
15282         PR gdb/23773
15283         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15284         <builder>: Rename to ..
15285         <m_builder>: ... this and make private.
15286         (dwarf2_cu::get_builder): New method.  Change all users of
15287         `builder' to use this method.
15288         (dwarf2_start_symtab): Move to ...
15289         (dwarf2_cu::start_symtab): ... here.  Update all callers
15290         (setup_type_unit_groups): Move to ...
15291         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15292         callers.
15293         (dwarf2_cu::reset_builder): New method.
15294         (process_full_compunit, process_full_type_unit): Use
15295         dwarf2_cu::reset_builder.
15296         (follow_die_offset): Record the ancestor CU if it is different
15297         from the followed DIE's CU.
15298         (follow_die_sig_1): Likewise.
15299
15300 2019-01-15  Tom Tromey  <tom@tromey.com>
15301
15302         * remote.c (class remote_state) <buf>: Now a char_vector.
15303         <buf_size>: Remove.
15304         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15305         parameter.
15306         (remote_target::getpkt_or_notif_sane_1)
15307         (remote_target::getpkt_sane)
15308         (remote_target::getpkt_or_notif_sane): Likewise.
15309         (class remote_target) <putpkt>: New overload.
15310         (remote_target::read_frame): Change type of "buf_p".  Remove
15311         sizeof_p parameter.
15312         (packet_ok): New overload.
15313         (packet_check_result): New overload.
15314         Update all uses.
15315
15316 2019-01-14  Tom Tromey  <tom@tromey.com>
15317
15318         * remote-notif.c (handle_notification, remote_notif_ack)
15319         (remote_notif_parse): Make "buf" const.
15320         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15321         const.
15322         (remote_notif_parse, remote_notif_ack, handle_notification):
15323         Likewise.
15324         * remote.c (remote_notif_stop_parse): Make "buf" const.
15325         (remote_target::remote_parse_stop_reply): Make "buf" const.
15326         (remote_notif_stop_ack): Make "buf" const.
15327
15328 2019-01-14  Tom Tromey  <tom@tromey.com>
15329
15330         * remote.c (remote_console_output): Make parameter const.
15331
15332 2019-01-14  Tom Tromey  <tom@tromey.com>
15333
15334         * target-debug.h (target_debug_print_signals): Constify.
15335         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15336         * procfs.c (procfs_target::pass_signals): Update.
15337         * linux-nat.c (linux_nat_target::pass_signals): Update.
15338         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15339         * target-delegates.c: Rebuild.
15340         * remote.c (remote_target::program_signals): Update.
15341         (remote_target::pass_signals): Update.
15342         * target.c (target_pass_signals): Constify argument.
15343         (target_program_signals): Likewise.
15344         * target.h (struct target_ops) <pass_signals, program_signals>:
15345         Constify argument.
15346         (target_pass_signals, target_program_signals): Constify argument.
15347
15348 2019-01-14  Tom Tromey  <tom@tromey.com>
15349
15350         PR tui/28819:
15351         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15352
15353 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15354
15355         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15356         field.
15357         * rs6000-tdep.c: Include reggroups.h.
15358         (IS_V_ALIAS_PSEUDOREG): Define.
15359         (rs6000_register_name): Return names for the "vX" aliases.
15360         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15361         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15362         aliases.  Call default_register_reggroup_p for all other
15363         pseudo-registers.
15364         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15365         New functions.
15366         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15367         Handle "vX" aliases.
15368         (v_alias_pseudo_register_collect): New function.
15369         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15370         (rs6000_gdbarch_init): Initialize "vX" aliases as
15371         pseudo-registers.  Restore registration of
15372         rs6000_pseudo_register_reggroup_p with
15373         set_tdesc_pseudo_register_reggroup_p.
15374
15375 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15376
15377         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15378         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15379         set_gdbarch_num_pseudo_regs.
15380
15381 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15382
15383         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15384         Remove arg prefixname, add do_set and do_show.
15385         Add member functions set_list and show_list.
15386         * cli/cli-style.c (class cli_style_option): Update accordingly.
15387         (style_set_list): Move to file scope.
15388         (style_show_list): Likewise.
15389         (set_style): Call help_list.
15390         (show_style): Call cmd_show_list.
15391         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15392         Update to use the new macro.
15393
15394 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15395
15396         * ada-lang.c (_initialize_ada_language): Expand the help text
15397         for the "catch exception" command.
15398
15399 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15400
15401         * symtab.c (matching_obj_sections): Initialize obj,
15402         declare it closer to its usage.
15403
15404 2019-01-10  Tom Tromey  <tom@tromey.com>
15405
15406         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15407         (basic_inf_threads_range): Remove.
15408         (inf_threads_range, inf_non_exited_threads_range)
15409         (safe_inf_threads_range): Use next_adapter.
15410
15411 2019-01-10  Keith Seitz  <keiths@redhat.com>
15412
15413         PR gdb/23712
15414         PR symtab/23010
15415         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15416         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15417
15418 2019-01-10  Keith Seitz  <keiths@redhat.com>
15419
15420         PR gdb/23712
15421         PR symtab/23010
15422         * dictionary.c (pending_to_vector): Remove.
15423         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15424         Remove _1 suffix, replacing functions of the same name.  Update
15425         all callers.
15426         (dict_create_hashed, dict_create_hashed_expandable)
15427         (dict_create_linear, dict_create_linear_expandable, dict_free)
15428         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15429         Make functions static.
15430
15431 2019-01-10  Keith Seitz  <keiths@redhat.com>
15432
15433         PR gdb/23712
15434         PR symtab/23010
15435         * dictionary.h (struct dictionary): Replace declaration with
15436         multidictionary.
15437         (dict_create_hashed, dict_create_hashed_expandable)
15438         (dict_create_linear, dict_create_linear_expandable)
15439         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15440         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15441         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15442         taking multidictionary argument.
15443         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15444         * block.h (struct block) <dict>: Change to multidictionary
15445         and rename `multidict'.
15446         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15447         symmisc.c: Update all dictionary references to multidictionary.
15448
15449 2019-01-10  Keith Seitz  <keiths@redhat.com>
15450
15451         PR gdb/23712
15452         PR symtab/23010
15453         * dictionary.c: Include unordered_map.
15454         (pending_to_vector): New function.
15455         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15456         Rewrite the non-"_1" functions to take vector instead
15457         of linked list.
15458         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15459         "new" _1 versions of the same name.
15460         (multidictionary): Define.
15461         (std::hash<enum language): New definition.
15462         (collate_pending_symbols_by_language, mdict_create_hashed)
15463         (mdict_create_hashed_expandable, mdict_create_linear)
15464         (mdict_create_linear_expandable, mdict_free)
15465         (find_language_dictionary, create_new_language_dictionary)
15466         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15467         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15468         (mdict_size, mdict_empty): New functions.
15469         * dictionary.h (mdict_iterator): Define.
15470
15471 2019-01-10  Pedro Alves  <palves@redhat.com>
15472
15473         * breakpoint.c (read_uploaded_action)
15474         (create_tracepoint_from_upload): Adjust to use
15475         gdb::unique_xmalloc_ptr.
15476         * ctf.c (ctf_write_uploaded_tp):
15477         (SET_ARRAY_FIELD): Use emplace_back.
15478         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15479         * tracefile-tfile.c (tfile_write_uploaded_tp):
15480         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15481         gdb::unique_xmalloc_ptr.
15482         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15483         at_string, cond_string, cmd_strings>: Replace char pointers
15484         with gdb::unique_xmalloc_ptr.
15485
15486 2019-01-10  Pedro Alves  <palves@redhat.com>
15487
15488         * solib-target.c (library_list_start_library): Don't xstrdup name.
15489
15490 2019-01-10  Pedro Alves  <palves@redhat.com>
15491
15492         * mdebugread.c (parse_partial_symbols): Use
15493         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15494
15495 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15496
15497         * linux-fork.c (scoped_switch_fork_info)
15498         <~scoped_switch_fork_info>: Fix incorrect variable name.
15499
15500 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15501
15502         * linux-fork.c (scoped_switch_fork_info)
15503         <scoped_switch_fork_info>: Make explicit.
15504         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15505
15506 2019-01-10  Tom Tromey  <tom@tromey.com>
15507
15508         * objfiles.h (objfile::reset_psymtabs): Update.
15509         * objfiles.c (objfile::objfile): Update.
15510         * psymtab.h (psymtab_storage::obstack): Update.
15511         (psymtab_storage::m_obstack): Use gdb::optional.
15512         (class psymtab_storage): Update comment.  Remove objfile
15513         parameter.
15514         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15515
15516 2019-01-10  Tom Tromey  <tom@tromey.com>
15517
15518         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15519         <free_psymtabs>: Now private.
15520         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15521         (allocate_psymtab): Use new method.
15522
15523 2019-01-10  Tom Tromey  <tom@tromey.com>
15524
15525         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15526         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15527         * mdebugread.c (parse_partial_symbols): Use
15528         allocate_dependencies.
15529         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15530         allocate_dependencies.
15531         (process_psymtab_comp_unit_reader)
15532         (build_type_psymtab_dependencies): Likewise.
15533         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15534
15535 2019-01-10  Tom Tromey  <tom@tromey.com>
15536
15537         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15538         PSYMBOL_SET_LANGUAGE.
15539         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15540
15541 2019-01-10  Tom Tromey  <tom@tromey.com>
15542
15543         * psymtab.h (psymtab_storage::obstack): New method.
15544         <m_obstack>: Rename from obstack; now private.
15545         * psymtab.c (psymtab_storage): Update.
15546         * dwarf2read.c (create_addrmap_from_index)
15547         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15548         Update.
15549
15550 2019-01-10  Tom Tromey  <tom@tromey.com>
15551
15552         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15553         * objfiles.h (objfile::reset_psymtabs): New method.
15554
15555 2019-01-10  Tom Tromey  <tom@tromey.com>
15556
15557         * symmisc.c (print_symbol_bcache_statistics): Update.
15558         (print_objfile_statistics): Update.
15559         * symfile.c (reread_symbols): Update.
15560         * psymtab.h (class psymtab_storage): New.
15561         * psymtab.c (psymtab_storage): New constructor.
15562         (~psymtab_storage): New destructor.
15563         (require_partial_symbols): Update.
15564         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15565         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15566         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15567         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15568         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15569         (start_psymtab_common, end_psymtab_common)
15570         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15571         (allocate_psymtab): Update.
15572         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15573         Update.
15574         (dump_psymtab_addrmap, maintenance_print_psymbols)
15575         (maintenance_check_psymtabs): Update.
15576         (class objfile_psymtabs): Move to objfiles.h.
15577         * psympriv.h (discard_psymtab): Now inline.
15578         (psymtab_discarder::psymtab_discarder): Update.
15579         (psymtab_discarder::~psymtab_discarder): Update.
15580         (ALL_OBJFILE_PSYMTABS): Rewrite.
15581         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15582         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15583         Remove fields.
15584         <partial_symtabs>: New field.
15585         (class objfile_psymtabs): Move from psymtab.h.  Update.
15586         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15587         psymbol_cache.
15588         (objfile::~objfile): Don't destroy psymbol_cache.
15589         * mdebugread.c (parse_partial_symbols): Update.
15590         * dwarf2read.c (create_addrmap_from_index)
15591         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15592         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15593         (add_partial_subprogram, dwarf2_ranges_read): Update.
15594         * dwarf-index-write.c (write_address_map)
15595         (write_one_signatured_type, recursively_write_psymbols)
15596         (class debug_names, class debug_names, write_psymtabs_to_index):
15597         Update.
15598
15599 2019-01-10  Tom Tromey  <tom@tromey.com>
15600
15601         * symtab.h (SYMBOL_SET_NAMES): Update.
15602         (symbol_set_names): Update.
15603         (MSYMBOL_SET_NAMES): Update.
15604         * symtab.c (symbol_set_names): Change argument to be an
15605         objfile_per_bfd_storage.
15606         * psymtab.c (add_psymbol_to_bcache): Update.
15607         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15608
15609 2019-01-10  Tom Tromey  <tom@tromey.com>
15610
15611         * symtab.c (create_demangled_names_hash): Change argument to be an
15612         objfile_per_bfd_storage.
15613         (symbol_set_names): Update.
15614
15615 2019-01-10  Tom Tromey  <tom@tromey.com>
15616
15617         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15618         init_psymbol_list.
15619         * psymtab.c (init_psymbol_list): Do nothing if already called.
15620         * psympriv.h (init_psymbol_list): Add comment.
15621         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15622         init_psymbol_list.
15623         * dbxread.c (dbx_symfile_read): Unconditionally call
15624         init_psymbol_list.
15625
15626 2019-01-10  Tom Tromey  <tom@tromey.com>
15627
15628         * xcoffread.c (scan_xcoff_symtab): Update.
15629         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15630         "where".
15631         * mdebugread.c (parse_partial_symbols)
15632         (handle_psymbol_enumerators): Update.
15633         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15634         * dbxread.c (read_dbx_symtab): Update.
15635         * psympriv.h (psymbol_placement): New enum.
15636         (add_psymbol_to_list): Update.
15637
15638 2019-01-10  Tom Tromey  <tom@tromey.com>
15639
15640         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15641         static_psymbols parameters.
15642         (scan_xcoff_symtab): Update.
15643         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15644         static_psymbols parameters.
15645         * psympriv.h (start_psymtab_common): Update.
15646         * mdebugread.c (parse_partial_symbols): Update.
15647         * dwarf2read.c (create_partial_symtab): Update.
15648         * dbxread.c (read_dbx_symtab): Update.
15649         (start_psymtab): Remove global_psymbols and static_psymbols
15650         parameters.
15651
15652 2019-01-10  Tom Tromey  <tom@tromey.com>
15653
15654         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15655         * psymtab.c (allocate_psymtab): Add comment.
15656         * psympriv.h (allocate_psymtab): Add comment.
15657         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15658         initializations.
15659         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15660
15661 2019-01-10  Tom Tromey  <tom@tromey.com>
15662
15663         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15664         Don't declare.
15665         * mipsread.c: Include mdebugread.h.
15666         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15667         Declare.
15668         * elfread.c: Include mdebugread.h.
15669
15670 2019-01-09  Tom Tromey  <tom@tromey.com>
15671
15672         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15673         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15674         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15675         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15676         (psym_lookup_symbol, psym_find_last_source_symtab)
15677         (psym_forget_cached_source_info, psym_print_stats)
15678         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15679         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15680         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15681         (psym_find_compunit_symtab_by_address)
15682         (maintenance_print_psymbols, maintenance_info_psymtabs)
15683         (maintenance_check_psymtabs): Use ranged for.
15684         * psymtab.h (class objfile_psymtabs): New.
15685         (require_partial_symbols): Return objfile_psymtabs.
15686         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15687
15688 2019-01-09  Tom Tromey  <tom@tromey.com>
15689
15690         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15691         (find_pc_mapped_section, list_overlays_command)
15692         (map_overlay_command, unmap_overlay_command)
15693         (simple_overlay_update): Use all_objfiles.
15694         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15695         * printcmd.c (info_symbol_command): Use all_objfiles.
15696         * objfiles.h (ALL_OBJSECTIONS): Remove.
15697         * maint.c (maintenance_translate_address): Use all_objfiles.
15698         * gcore.c (gcore_create_callback): Use all_objfiles.
15699         (objfile_find_memory_regions): Likewise.
15700
15701 2019-01-09  Tom Tromey  <tom@tromey.com>
15702
15703         * symtab.c (find_line_symtab, info_sources_command)
15704         (make_source_files_completion_list): Use objfile_compunits.
15705         * source.c (select_source_symtab): Use objfile_compunits.
15706         * objfiles.h (struct objfile): Update comment.
15707         (ALL_OBJFILES): Remove.
15708         (ALL_FILETABS): Remove.
15709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15710         objfile_compunits.
15711
15712 2019-01-09  Tom Tromey  <tom@tromey.com>
15713
15714         * symmisc.c (print_objfile_statistics, dump_objfile)
15715         (maintenance_print_symbols): Use compunit_filetabs.
15716         * source.c (forget_cached_source_info_for_objfile): Use
15717         compunit_filetabs.
15718         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15719         (ALL_FILETABS): Use compunit_filetabs.
15720         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15721         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15722
15723 2019-01-09  Tom Tromey  <tom@tromey.com>
15724
15725         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15726         (compunit_filetabs): New.
15727         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15728         compunit_filetabs.
15729         (info_sources_command, make_source_files_completion_list): Remove
15730         declaration.
15731         * symmisc.c (print_objfile_statistics, dump_objfile)
15732         (maintenance_print_symbols): Remove declaration.
15733         (maintenance_info_symtabs): Use compunit_filetabs.
15734         (maintenance_info_line_tables): Likewise.
15735         * source.c (select_source_symtab): Change local variable name.
15736         (forget_cached_source_info_for_objfile): Remove declaration.
15737         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15738         * objfiles.c (objfile_relocate1): Remove declaration.
15739         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15740         declaration.
15741         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15742         * coffread.c (coff_symtab_read): Remove declaration.
15743         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15744         compunit_filetabs.
15745
15746 2019-01-09  Tom Tromey  <tom@tromey.com>
15747
15748         * symtab.c (lookup_objfile_from_block)
15749         (find_pc_sect_compunit_symtab, search_symbols)
15750         (default_collect_symbol_completion_matches_break_on): Use
15751         objfile_compunits.
15752         * objfiles.h (ALL_COMPUNITS): Remove.
15753         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15754         * cp-support.c (add_symbol_overload_list_qualified): Use
15755         objfile_compunits.
15756         * ada-lang.c (ada_collect_symbol_completion_matches)
15757         (ada_add_global_exceptions): Use objfile_compunits.
15758
15759 2019-01-09  Tom Tromey  <tom@tromey.com>
15760
15761         * source.c (select_source_symtab)
15762         (forget_cached_source_info_for_objfile): Remove declaration.
15763         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15764         declaration.
15765         * maint.c (count_symtabs_and_blocks): Remove declaration.
15766         * cp-support.c (add_symbol_overload_list_qualified): Remove
15767         declaration.
15768         * coffread.c (coff_symtab_read): Remove declaration.
15769         * symtab.c (lookup_symbol_in_objfile_symtabs)
15770         (basic_lookup_transparent_type_1): Use objfile_compunits.
15771         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15772         (info_sources_command, search_symbols)
15773         (default_collect_symbol_completion_matches_break_on)
15774         (make_source_files_completion_list): Remove declaration.
15775         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15776         (ada_collect_symbol_completion_matches)
15777         (ada_add_global_exceptions): Remove declaration.
15778         * linespec.c (iterate_over_all_matching_symtabs): Use
15779         objfile_compunits.
15780         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15781         (class objfile_compunits): New.
15782         (ALL_COMPUNITS): Use objfile_compunits.
15783         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15784         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15785         objfile_compunits.
15786         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15787
15788 2019-01-09  Tom Tromey  <tom@tromey.com>
15789
15790         * symtab.c (search_symbols)
15791         (default_collect_symbol_completion_matches_break_on): Use
15792         objfile_msymbols.
15793         * ada-lang.c (ada_lookup_simple_minsym)
15794         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15795         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15796         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15797         objfile_msymbols.
15798         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15799         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15800         * objc-lang.c (find_methods): Use objfile_msymbols.
15801         (info_selectors_command, info_classes_command): Likewise.
15802         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15803         * objfiles.h (class objfile_msymbols): New.
15804         (ALL_OBJFILE_MSYMBOLS): Remove.
15805         (ALL_MSYMBOLS): Remove.
15806
15807 2019-01-09  Tom Tromey  <tom@tromey.com>
15808
15809         * common/next-iterator.h (next_adapter): Add Iterator template
15810         parameter.
15811         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15812         (class all_objfiles_safe): New.
15813         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15814         * objfiles.c (put_objfile_before): Update comment.
15815         (add_separate_debug_objfile): Likewise.
15816         (free_all_objfiles): Use all_objfiles_safe.
15817         (objfile_purge_solibs): Likewise.
15818
15819 2019-01-09  Tom Tromey  <tom@tromey.com>
15820
15821         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15822         (expand_symtab_containing_pc, lookup_static_symbol)
15823         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15824         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15825         all_objfiles.
15826         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15827         * breakpoint.c (create_overlay_event_breakpoint)
15828         (create_longjmp_master_breakpoint)
15829         (create_std_terminate_master_breakpoint)
15830         (create_exception_master_breakpoint): Use all_objfiles.
15831         * linux-thread-db.c (try_thread_db_load_from_pdir)
15832         (has_libpthread): Use all_objfiles.
15833         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15834         * linespec.c (iterate_over_all_matching_symtabs)
15835         (search_minsyms_for_name): Use all_objfiles.
15836         * maint.c (maintenance_info_sections): Use all_objfiles.
15837         * main.c (captured_main_1): Use all_objfiles.
15838         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15839         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15840         * guile/scm-pretty-print.c
15841         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15842         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15843         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15844         (maintenance_print_msymbols): Use all_objfiles.
15845         * source.c (select_source_symtab): Use all_objfiles.
15846         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15847         * symfile.c (remove_symbol_file_command)
15848         (expand_symtabs_matching, map_symbol_filenames): Use
15849         all_objfiles.
15850         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15851         all_objfiles.
15852         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15853         * objc-lang.c (find_methods): Use all_objfiles.
15854         * objfiles.c (have_partial_symbols, have_full_symbols)
15855         (have_minimal_symbols, qsort_cmp)
15856         (default_iterate_over_objfiles_in_search_order): Use
15857         all_objfiles.
15858         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15859         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15860         (maintenance_check_psymtabs): Use all_objfiles.
15861         (ALL_PSYMTABS): Remove.
15862         * compile/compile-object-run.c (do_module_cleanup): Use
15863         all_objfiles.
15864         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15865         * cp-support.c (add_symbol_overload_list_qualified): Use
15866         all_objfiles.
15867         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15868         Use all_objfiles.
15869         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15870         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15871         all_objfiles.
15872         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15873         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15874         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15875         Uses all_objfiles.
15876         * solib.c (solib_read_symbols): Use all_objfiles
15877
15878 2019-01-09  Tom Tromey  <tom@tromey.com>
15879
15880         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15881         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15882         all_objfiles.
15883         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15884         * symmisc.c (print_symbol_bcache_statistics)
15885         (print_objfile_statistics, maintenance_print_objfiles)
15886         (maintenance_info_symtabs, maintenance_check_symtabs)
15887         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15888         all_objfiles.
15889         * source.c (forget_cached_source_info): Use all_objfiles.
15890         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15891         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15892         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15893         * objfiles.c (update_section_map): Use all_objfiles.
15894         (shared_objfile_contains_address_p): Likewise.
15895         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15896         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15897
15898 2019-01-09  Tom Tromey  <tom@tromey.com>
15899
15900         * common/next-iterator.h: New file.
15901         * objfiles.h (class all_objfiles): New.
15902         (struct objfile_iterator): New.
15903
15904 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15905
15906         * NEWS: Move the description of the changed "frame", "select-frame",
15907          and "info frame" commands to the Changed commands section.
15908
15909 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15910
15911         * gdbtypes.c (check_stub_method_group): Remove handling of old
15912         mangling schemes.
15913         * linespec.c (find_methods): Likewise.
15914         * stabsread.c (read_member_functions): Likewise.
15915         * valops.c (search_struct_method): Likewise.
15916         (value_struct_elt_for_reference): Likewise.
15917         * NEWS: Mention this change.
15918
15919 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15920
15921         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15922         print_source_lines.
15923         * source.c (print_source_lines_base): Update line number check.
15924         (print_source_lines): New function.
15925         (source_lines_range::source_lines_range): New function.
15926         * source.h (class source_lines_range): New class.
15927         (print_source_lines): New declaration.
15928
15929 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15930
15931         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15932
15933 2019-01-08  Tom Tromey  <tom@tromey.com>
15934             Simon Marchi  <simon.marchi@ericsson.com>
15935
15936         PR gdb/24060
15937         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15938         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15939         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15940         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15941         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15942         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15943
15944 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15945
15946         * source.c (select_source_symtab): Move header comment to
15947         declaration in source.h.
15948         (forget_cached_source_info_for_objfile): Likewise.
15949         (forget_cached_source_info): Likewise.
15950         (identify_source_line): Likewise.
15951         * source.h (identify_source_line): Move declaration from symtab.h
15952         and add comment from source.c
15953         (print_source_lines): Likewise.
15954         (forget_cached_source_info_for_objfile): Likewise.
15955         (forget_cached_source_info): Likewise.
15956         (select_source_symtab): Likewise.
15957         (enum print_source_lines_flag): Move definition from symtab.h.
15958         * symtab.h (identify_source_line): Move declaration to source.h.
15959         (print_source_lines): Likewise.
15960         (forget_cached_source_info_for_objfile): Likewise.
15961         (forget_cached_source_info): Likewise.
15962         (select_source_symtab): Likewise.
15963         (enum print_source_lines_flag): Move definition to source.h.
15964         * tui/tui-hooks.c: Add 'source.h' include.
15965
15966 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15967
15968         * source.c (print_source_lines_base): Handle requests to print
15969         reverse line number sequences, and guard against empty lines
15970         string.
15971
15972 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15973
15974         * source.c (print_source_lines_base): Fix skip of '\r' if next
15975         character is '\n'.
15976
15977 2019-01-06  Tom Tromey  <tom@tromey.com>
15978
15979         * c-exp.y (struct c_parse_state) <macro_original_text,
15980         expansion_obstack>: New member.
15981         (macro_original_text, expansion_obstack): Remove globals.
15982         (scan_macro_expansion, scanning_macro_expansion)
15983         (finished_macro_expansion): Update.
15984         (scan_macro_cleanup): Remove.
15985         (yylex, c_parse): Update.
15986
15987 2019-01-06  Tom Tromey  <tom@tromey.com>
15988
15989         * c-exp.y (struct c_parse_state) <strings>: New member.
15990         (operator_stoken): Update.
15991
15992 2019-01-06  Tom Tromey  <tom@tromey.com>
15993
15994         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15995         (union type_stack_elt) <typelist_val>: Now a pointer to
15996         std::vector.
15997         (type_stack_cleanup): Don't declare.
15998         (push_typelist): Update.
15999         * parse.c (pop_typelist): Return a std::vector.
16000         (push_typelist): Take a std::vector.
16001         (follow_types): Update.  Do not free args.
16002         (type_stack_cleanup): Remove.
16003         * c-exp.y (struct c_parse_state): New.
16004         (cpstate): New global.
16005         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16006         (nonempty_typelist): Update.
16007         (func_mod): Create a new vector.
16008         (c_parse): Create a c_parse_state.
16009         (check_parameter_typelist): Do not delete params.
16010         (function_method): Update.  Do not delete type_list.
16011
16012 2019-01-06  Tom Tromey  <tom@tromey.com>
16013
16014         PR gdb/28155:
16015         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16016         check_typedef.
16017         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16018         (print_return_value): Likewise.
16019
16020 2019-01-05  Tom Tromey  <tom@tromey.com>
16021
16022         * contrib/cleanup_check.py: Remove.
16023         * contrib/gcc-with-excheck: Remove.
16024         * contrib/exsummary.py: Remove.
16025         * contrib/excheck.py: Remove.
16026
16027 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16028
16029         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16030         NULL. Initialize tpprev to NULL instead of assigning it
16031         to NULL on the next statement.
16032         * windows-nat.c (windows_delete_thread): Remove check for
16033         main_thread_id before printing thread exit notifications.
16034         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16035         Remove thread ID check against main_thread_id.
16036         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16037         windows_delete_thread.
16038         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16039
16040 2019-01-04  Tom Tromey  <tom@tromey.com>
16041
16042         * compile/compile.c (_initialize_compile): Use upper case for
16043         metasyntactic variables.
16044         * symmisc.c (_initialize_symmisc): Use upper case for
16045         metasyntactic variables.
16046         * psymtab.c (_initialize_psymtab): Use upper case for
16047         metasyntactic variables.
16048         * demangle.c (demangle_command): Use upper case for metasyntactic
16049         variables.
16050         (_initialize_demangler): Likewise.
16051         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16052         variables.
16053
16054 2019-01-03  Tom Tromey  <tom@tromey.com>
16055
16056         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16057
16058 2019-01-03  Tom Tromey  <tom@tromey.com>
16059
16060         * python/py-symtab.c (salpy_str): Update.
16061         (struct salpy_sal_object) <symtab>: Now a PyObject.
16062         (salpy_dealloc): Update.
16063         (del_objfile_sal): Use gdbpy_ref.
16064
16065 2019-01-03  Tom Tromey  <tom@tromey.com>
16066
16067         * python/py-type.c (convert_field): Use new_reference.  Return
16068         gdbpy_ref.
16069         (make_fielditem): Return gdbpy_ref.
16070         (typy_fields): Update.
16071         (typy_getitem): Update.
16072         (field_name): Return gdbpy_ref.  Use new_reference.
16073         (typy_iterator_iternext): Update.
16074
16075 2019-01-03  Tom Tromey  <tom@tromey.com>
16076
16077         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16078
16079 2019-01-03  Tom Tromey  <tom@tromey.com>
16080
16081         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16082         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16083         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16084         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16085         (pspy_set_type_printers): Likewise.
16086         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16087         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16088         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16089         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16090         (objfpy_set_type_printers): Likewise.
16091
16092 2019-01-03  Tom Tromey  <tom@tromey.com>
16093
16094         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16095         (gdbpy_print_stack): Use gdbpy_err_fetch.
16096         * python/python-internal.h (class gdbpy_err_fetch): New class.
16097         (class gdbpy_enter) <m_error_type, m_error_value,
16098         m_error_traceback>: Remove.
16099         <m_error>: New member.
16100         (gdbpy_exception_to_string): Don't declare.
16101         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16102         * python/py-value.c (convert_value_from_python): Use
16103         gdbpy_err_fetch.
16104         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16105         gdbpy_exception_to_string.
16106         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16107         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16108         gdbpy_err_fetch.
16109
16110 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16111
16112         * linux-nat.c (delete_lwp_cleanup): Delete.
16113         (struct lwp_deleter): New struct.
16114         (lwp_info_up): New typedef.
16115         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16116         lwp_info_up.
16117
16118 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16119
16120         * linux-fork.c (class scoped_switch_fork_info): New class.
16121         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16122
16123 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16124
16125         * valops.c (find_overload_match): Remove use of null_cleanup, and
16126         calls to do_cleanups.
16127
16128 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16129
16130         * compile/compile-cplus-types.c
16131         (compile_cplus_instance::decl_name): Handle changes to
16132         cp_func_name.
16133         * cp-support.c (cp_func_name): Update header comment, update
16134         return type.
16135         * cp-support.h (cp_func_name): Update return type in declaration.
16136         * valops.c (find_overload_match): Move temp_func local to top
16137         level of function and change its type.  Use temp_func to hold and
16138         delete temporary string obtained from cp_func_name.
16139
16140 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16141
16142         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16143         gdb::char_vector, remove cleanup, and update uses of `msg`.
16144
16145 2019-01-03  Jim Wilson  <jimw@sifive.com>
16146
16147         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16148
16149 2019-01-02  Tom Tromey  <tom@tromey.com>
16150
16151         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16152         (tdesc_parse_xml): Remove cleanups.
16153         * target-descriptions.h (make_cleanup_free_target_description):
16154         Don't declare.
16155         (target_desc_deleter): New struct.
16156         (target_desc_up): New typedef.
16157         * target-descriptions.c (target_desc_deleter::operator()): Rename
16158         from free_target_description.
16159         (make_cleanup_free_target_description): Remove.
16160
16161 2019-01-02  Tom Tromey  <tom@tromey.com>
16162
16163         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16164         constructor, destructor.
16165         (linespec_parser): Remove typedef.
16166         (~linespec_parser): Rename from linespec_parser_delete.
16167         (linespec_lex_to_end, linespec_complete_label)
16168         (linespec_complete): Update.
16169         (decode_line_full): Remove cleanups.
16170         (decode_line_1): Update.
16171
16172 2019-01-02  Tom Tromey  <tom@tromey.com>
16173
16174         * python/python-internal.h (inferior_to_inferior_object): Change
16175         return type.
16176         * python/py-exitedevent.c (create_exited_event_object): Update.
16177         * python/py-inferior.c (inferior_to_inferior_object): Return
16178         gdbpy_ref.
16179         (python_new_inferior, python_inferior_deleted)
16180         (thread_to_thread_object, delete_thread_object)
16181         (build_inferior_list, gdbpy_selected_inferior): Update.
16182         * python/py-infthread.c (create_thread_object): Update.  Also fail
16183         if inferior_to_inferior_object fails.
16184
16185 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16186
16187         * inferior.h (class inferior) <displaced_step_state>: New field.
16188         * infrun.h (struct displaced_step_state): Move here from
16189         infrun.c.  Initialize fields, add constructor.
16190         <inf>: Remove field.
16191         <reset>: New method.
16192         * infrun.c (struct displaced_step_inferior_state): Move to
16193         infrun.h.
16194         (displaced_step_inferior_states): Remove.
16195         (get_displaced_stepping_state): Adust.
16196         (displaced_step_in_progress_any_inferior): Adjust.
16197         (displaced_step_in_progress_thread): Adjust.
16198         (displaced_step_in_progress): Adjust.
16199         (add_displaced_stepping_state): Remove.
16200         (get_displaced_step_closure_by_addr): Adjust.
16201         (remove_displaced_stepping_state): Remove.
16202         (infrun_inferior_exit): Call displaced_step_state.reset.
16203         (use_displaced_stepping): Don't check for NULL.
16204         (displaced_step_prepare_throw): Call
16205         get_displaced_stepping_state.
16206         (displaced_step_fixup): Don't check for NULL.
16207         (prepare_for_detach): Don't check for NULL.
16208
16209 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16210
16211         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16212          in case of call that did not complete.
16213
16214 2019-01-02  Andrey Utkin  <autkin@undo.io>
16215
16216         * symfile.c (find_separate_debug_file): Fix search of debug files for
16217         remote debuggee.
16218
16219 2019-01-02  Tom Tromey  <tom@tromey.com>
16220
16221         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16222         indentation.
16223         * python/py-frame.c (frapy_older): Remove cast.
16224         (frapy_newer): Likewise.
16225         * python/py-breakpoint.c (local_setattro): Remove cast.
16226         * python/py-arch.c (archpy_name): Remove local variable.
16227         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16228
16229 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16230
16231         * unittests/basic_string_view/element_access/char/empty.cc:
16232         Fix year range in copyright header.
16233
16234 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16235
16236         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16237         Delete.
16238         <operator==>: Update with for removed field.
16239         <hash>: Likewise.
16240         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16241         <isa_features>: ...this.
16242         <abi_features>: New field.
16243         (riscv_isa_flen): Update comment.
16244         (riscv_abi_xlen): New declaration.
16245         (riscv_abi_flen): New declaration.
16246         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16247         isa_features.
16248         (riscv_abi_xlen): New function.
16249         (riscv_isa_flen): Update to get answer from isa_features.
16250         (riscv_abi_flen): New function.
16251         (riscv_has_fp_abi): Update to get answer from abi_features.
16252         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16253         xlen and flen.
16254         (riscv_call_info) <xlen, flen>: Update comment.
16255         (riscv_call_arg_struct): Remove invalid assertions
16256         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16257         is removed.
16258         (riscv_gdbarch_init): Gather isa features and abi features
16259         separately, ensure both match on the gdbarch when reusing an old
16260         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16261         a target with 64-bit float hardware.
16262
16263 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16264
16265         * source.c (search_command_helper): Stop reverse search
16266         when line 1 has been searched.
16267
16268 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16269
16270         * record-full.c (record_full_base_target::close): Rewrite
16271         record_full_core_buf_list free logic.
16272
16273 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16274
16275         * break-catch-syscall.c (print_one_catch_syscall): xfree
16276         the last text.
16277
16278 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16279
16280         * top.c (print_gdb_version): Update Copyright year in version
16281         message.
16282
16283 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16284
16285         Update copyright year range in all GDB files.
16286
16287 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16288
16289         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16290
16291 For older changes see ChangeLog-2018.
16292 \f
16293 Local Variables:
16294 mode: change-log
16295 left-margin: 8
16296 fill-column: 74
16297 version-control: never
16298 coding: utf-8
16299 End:
16300