gdb/ChangeLog

   1 2019-08-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <update_breakpoint_info>: Declare.
   5         (tui_update_breakpoint_info): Don't declare.
   6         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
   7         (tui_update_all_breakpoint_info): Update.
   8         (tui_source_window_base::update_breakpoint_info): Rename from
   9         tui_update_breakpoint_info.
  10         (tui_source_window_base::update_exec_info): Update.
  11
  12 2019-08-16  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-winsource.h (struct tui_source_window_base)
  15         <update_source_window>: Declare.
  16         (tui_update_source_window): Don't declare.
  17         * tui/tui-winsource.c
  18         (tui_source_window_base::update_source_window): Rename from
  19         tui_update_source_window.
  20         (tui_source_window_base::rerender): Update.
  21         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  22         * tui/tui-disasm.c (tui_show_disassem)
  23         (tui_show_disassem_and_update_source)
  24         (tui_disasm_window::maybe_update): Update.
  25
  26 2019-08-16  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-winsource.h (struct tui_source_window_base)
  29         <update_source_window_as_is>: Declare.
  30         (tui_update_source_window_as_is): Don't declare.
  31         * tui/tui-winsource.c (tui_update_source_window): Update
  32         (tui_source_window_base::update_source_window_as_is): Rename from
  33         tui_update_source_window_as_is.
  34         (tui_source_window_base::refill): Update.
  35         * tui/tui-source.c (tui_show_symtab_source): Update.
  36         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
  37         Update.
  38
  39 2019-08-16  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-winsource.h (tui_update_source_window)
  42         (tui_update_source_window_as_is): Remove "noerror" parameter.
  43         * tui/tui-winsource.c (tui_update_source_window)
  44         (tui_update_source_window_as_is): Remove "noerror" parameter.
  45         (tui_update_source_windows_with_addr)
  46         (tui_update_source_windows_with_line)
  47         (tui_source_window_base::rerender)
  48         (tui_source_window_base::refill): Update.
  49         * tui/tui-source.h (tui_set_source_content)
  50         (tui_show_symtab_source): Remove "noerror" parameter.
  51         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
  52         parameter.
  53         (tui_show_symtab_source): Likewise.
  54         (tui_source_window::maybe_update): Update.
  55         * tui/tui-disasm.c (tui_show_disassem)
  56         (tui_show_disassem_and_update_source)
  57         (tui_disasm_window::do_scroll_vertical)
  58         (tui_disasm_window::maybe_update): Update.
  59
  60 2019-08-16  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui.c (tui_is_window_visible): Update.
  63         * tui/tui-wingeneral.c (tui_make_window)
  64         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
  65         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
  66         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
  67         (tui_set_win_height_command, parse_scrolling_args): Update.
  68         * tui/tui-source.c (tui_source_window::style_changed): Update.
  69         * tui/tui-regs.c (tui_show_registers)
  70         (tui_data_window::first_data_item_displayed)
  71         (tui_data_window::delete_data_content_windows)
  72         (tui_check_register_values, tui_reg_command): Update.
  73         * tui/tui-disasm.c (tui_show_disassem): Update.
  74         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
  75         method.
  76         <is_visible>: Remove field.
  77         * tui/tui-data.c (tui_next_win, tui_prev_win)
  78         (tui_delete_invisible_windows): Update.
  79
  80 2019-08-16  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-winsource.h (struct tui_source_window_base)
  83         <m_has_locator>: Remove.
  84         * tui/tui-layout.c (show_source_disasm_command, show_data)
  85         (show_source_or_disasm_and_command): Update.
  86
  87 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
  88
  89         * NEWS (Other MI changes): New subsection.
  90         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
  91         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
  92         * arch-utils.c (default_get_pc_address_flags): New function.
  93         * arch-utils.h (default_get_pc_address_flags): New declaration.
  94         * gdbarch.sh: Add get_pc_address_flags.
  95         * gdbarch.c: Regenerate.
  96         * gdbarch.h: Likewise.
  97         * stack.c (print_pc): New function.
  98         (print_frame_info) (print_frame): Call print_pc.
  99
 100 2019-08-16  Tom de Vries  <tdevries@suse.de>
 101
 102         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 103         print_objfile_section_info.
 104
 105 2019-08-15  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 108         calling update_cmdwin_start_line.
 109         * tui/tui-winsource.h (struct tui_source_window_base)
 110         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 111         <rerender>: Declare.
 112         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 113         Call rerender.
 114         (tui_source_window_base::set_new_height): Remove.
 115         (tui_source_window_base::rerender): Rename from
 116         do_make_visible_with_new_height.
 117         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 118         resize method.
 119         (tui_win_info::make_invisible_and_set_new_height)
 120         (tui_win_info::make_visible_with_new_height): Remove.
 121         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 122         Declare.
 123         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 124         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 125         do_make_visible_with_new_height>: Don't declare.
 126         <rerender>: Declare.
 127         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 128         set_new_height.
 129         (tui_data_window::do_make_visible_with_new_height): Remove.
 130         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 131         call tui_show_locator_content.
 132         (tui_gen_win_info::resize): Call rerender.
 133         (show_source_or_disasm_and_command): Don't call
 134         tui_show_locator_content.
 135         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 136         method.
 137         (struct tui_win_info) <rerender>: Declare.
 138         <set_new_height, make_invisible_and_set_new_height,
 139         make_visible_with_new_height>: Don't declare.
 140         * tui/tui-data.c (tui_win_list::rerender): New method.
 141         * tui/tui-command.h (struct tui_cmd_window)
 142         <do_make_visible_with_new_height>: Don't declare.
 143         * tui/tui-command.c
 144         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 145
 146 2019-08-15  Tom Tromey  <tromey@adacore.com>
 147
 148         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 149         * ada-lang.c (ada_enum_name): Likewise.
 150
 151 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 152
 153         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 154         leading underscore.
 155         (GdbOutputErrorFile): Likewise.
 156         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 157         accordingly.
 158         (execute_unwinders): Rename to have a leading underscore.
 159         (auto_load_packages): Likewise.
 160         (global scope): Adjust call to auto_load_packages accordingly.
 161         (GdbSetPythonDirectory): Likewise.
 162         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 163         instead of execute_unwinders.
 164
 165 2019-08-15  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 168         (show_data): Don't change window visibility.
 169         (tui_gen_win_info::resize): Remove special case for command
 170         window.  Use wresize, when available.
 171         (show_source_or_disasm_and_command): Don't change window
 172         visibility.
 173         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 174         <make_visible>: New method.
 175         * tui/tui-command.c (tui_cmd_window::resize): New method.
 176
 177 2019-08-15  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 180         (struct tui_source_windows): New.
 181         * tui/tui-winsource.c (tui_display_main): Update.
 182         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 183         (new_height_ok, parse_scrolling_args): Update.
 184         * tui/tui-layout.c (show_layout, show_data): Update.
 185         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 186         (tui_add_to_source_windows): Don't declare.
 187         * tui/tui-data.c (source_windows, tui_source_windows)
 188         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 189
 190 2019-08-15  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 193         Rename from reset.
 194         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 195         * tui/tui-layout.c (show_source_disasm_command, show_data):
 196         Update.
 197         (tui_gen_win_info::resize): Rename.
 198         (show_source_or_disasm_and_command): Update.
 199         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 200         reset.
 201
 202 2019-08-15  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 205         * tui/tui-interp.c (tui_interp::init): Don't call
 206         tui_initialize_static_data.
 207         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 208
 209 2019-08-15  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 212         examine tui_win_list.
 213
 214 2019-08-15  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 217         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 218         tui_clear_source_content.
 219         (tui_clear_source_content): Remove.
 220         (tui_source_window_base::do_erase_source_content): Hoist call to
 221         content.clear().
 222         * tui/tui-stack.c (tui_show_frame_info): Don't call
 223         tui_clear_source_content.
 224
 225 2019-08-15  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-winsource.h (struct tui_source_window_base)
 228         <do_erase_source_content>: New method.
 229         <erase_source_content>: New method.
 230         (tui_erase_source_content): Don't declare.
 231         * tui/tui-winsource.c (tui_clear_source_content): Update.
 232         (tui_source_window_base::do_erase_source_content): Rename from
 233         tui_erase_source_content.
 234         (tui_source_window_base::show_source_content): Update.
 235         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 236         * tui/tui-source.h (struct tui_source_window)
 237         <erase_source_content>: New method.
 238         * tui/tui-disasm.h (struct tui_disasm_window)
 239         <erase_source_content>: New method.
 240
 241 2019-08-15  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 244         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 245         constructor.
 246         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 247         * tui/tui-source.c (tui_set_source_content): Update.
 248         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 249
 250 2019-08-15  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 253         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 254         tui-source.c.
 255         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 256         Declare.
 257         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 258         method.
 259         (tui_source_window::maybe_update): Update.
 260
 261 2019-08-15  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 264         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 265         tui-disasm.c.
 266         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 267         Declare.
 268         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 269         method.
 270         (tui_disasm_window::maybe_update): Update.
 271
 272 2019-08-15  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-winsource.h (struct tui_source_window_base)
 275         <maybe_update>: Declare.
 276         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 277         method.
 278         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 279         Declare.
 280         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 281         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 282         Declare.
 283         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 284
 285 2019-08-15  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 288
 289 2019-08-15  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-wingeneral.c: Include tui-stack.h.
 292         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 293         (struct tui_locator_window): Move from tui-data.h.
 294         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 295         (tui_initialize_static_data): Move from tui-data.c.
 296         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 297         (struct tui_locator_window): Move to tui-stack.c.
 298         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 299         (tui_initialize_static_data): Move to tui-stack.c.
 300
 301 2019-08-15  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-layout.c (show_source_disasm_command)
 304         (show_source_or_disasm_and_command): Use make_visible method, not
 305         tui_make_window.
 306         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 307         Remove.
 308
 309 2019-08-15  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-wingeneral.h (tui_make_window): Update.
 312         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 313         parameter.
 314         (tui_gen_win_info::make_visible): Update.
 315         * tui/tui-regs.c (tui_data_window::display_registers_from):
 316         Update.
 317         * tui/tui-layout.c (show_source_disasm_command)
 318         (show_source_or_disasm_and_command): Update.
 319         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 320         (enum tui_box): Remove.
 321         (struct tui_win_info) <can_box>: New method.
 322         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 323         method.
 324
 325 2019-08-15  Tom de Vries  <tdevries@suse.de>
 326
 327         * linux-nat-trad.c: Include gdbarch.h.
 328
 329 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 330
 331         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 332         register sizes.
 333
 334 2019-08-14  Tom Tromey  <tromey@adacore.com>
 335
 336         * darwin-nat.c: Include gdbarch.h.
 337         * darwin-nat-info.c: Include gdbarch.h.
 338
 339 2019-08-13  Tom Tromey  <tom@tromey.com>
 340
 341         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 342         Remove.
 343         * tui/tui-data.c (tui_initialize_static_data): Update.
 344
 345 2019-08-13  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-winsource.h (struct tui_exec_info_window)
 348         <~tui_exec_info_window, maybe_allocate_content, get_content,
 349         m_content>: Remove.
 350         (struct tui_source_window_base) <set_exec_info_content,
 351         show_exec_info_content>: Don't declare.
 352         * tui/tui-winsource.c
 353         (tui_exec_info_window::maybe_allocate_content): Remove.
 354         (tui_source_window_base::update_exec_info): Rename from
 355         set_exec_info_content.
 356         (tui_source_window_base::show_exec_info_content)
 357         (tui_source_window_base::update_exec_info): Remove.
 358
 359 2019-08-13  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 362         declare.
 363         * tui/tui-winsource.c (tui_update_source_window_as_is)
 364         (tui_update_source_windows_with_addr, tui_erase_source_content):
 365         Update.
 366         (tui_clear_exec_info_content): Remove.
 367
 368 2019-08-13  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 371         declare.
 372         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 373         call tui_erase_exec_info_content.
 374         (tui_clear_exec_info_content): Rename from
 375         tui_erase_exec_info_content.
 376         (tui_clear_exec_info_content): Delete.
 377
 378 2019-08-13  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-winsource.h (struct tui_source_window_base)
 381         <show_exec_info_content>: Declare.
 382         (tui_show_exec_info_content): Don't declare.
 383         * tui/tui-winsource.c
 384         (tui_source_window_base::show_exec_info_content): Rename from
 385         tui_show_exec_info_content.
 386         (tui_source_window_base::update_exec_info): Update.
 387
 388 2019-08-13  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 391         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 392         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 393         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 394         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 395         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 396         ... here.
 397
 398 2019-08-13  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-winsource.h (struct tui_source_window_base)
 401         <update_exec_info>: Declare.
 402         (tui_update_exec_info): Don't declare.
 403         * tui/tui-winsource.c (tui_update_source_window_as_is)
 404         (tui_source_window_base::refresh_all)
 405         (tui_update_all_breakpoint_info): Update.
 406         (tui_source_window_base::update_exec_info): Rename from
 407         tui_update_exec_info.
 408         * tui/tui-stack.c (tui_show_frame_info): Update.
 409
 410 2019-08-13  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-winsource.h (struct tui_source_window_base)
 413         <set_exec_info_content>: Declare.
 414         (tui_set_exec_info_content): Don't declare.
 415         * tui/tui-winsource.c
 416         (tui_source_window_base::set_exec_info_content): Rename from
 417         tui_set_exec_info_content.
 418         (tui_update_exec_info): Update.
 419
 420 2019-08-13  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-winsource.h (struct tui_source_window_base)
 423         <show_source_content>: Declare.
 424         (tui_show_source_content): Don't declare.
 425         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 426         (tui_source_window_base::show_source_content): Rename from
 427         tui_show_source_content.
 428         (tui_source_window_base::refresh_all): Update.
 429         * tui/tui-layout.c (show_source_disasm_command)
 430         (show_source_or_disasm_and_command): Update.
 431
 432 2019-08-13  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.c (tui_erase_source_content)
 435         (tui_show_source_content, tui_source_window_base::refresh_all):
 436         Update.
 437         * tui/tui-wingeneral.h
 438         (tui_check_and_display_highlight_if_needed): Don't declare.
 439         * tui/tui-wingeneral.c
 440         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 441         check_and_display_highlight_if_needed.
 442         * tui/tui-win.c (tui_rehighlight_all)
 443         (tui_win_info::make_visible_with_new_height): Update.
 444         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 445         (tui_data_window::erase_data_content)
 446         (tui_data_window::display_all_data): Update.
 447         * tui/tui-data.h (struct tui_win_info)
 448         <check_and_display_highlight_if_needed>: Declare.
 449
 450 2019-08-13  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-win.c (tui_resize_all): Call
 453         tui_delete_invisible_windows.
 454         * tui/tui-layout.c (show_layout): Call
 455         tui_delete_invisible_windows.
 456         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 457         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 458
 459 2019-08-13  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 462         tui_add_win_to_layout.
 463
 464 2019-08-13  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 467         * tui/tui-layout.c (tui_default_win_height): Now static.
 468
 469 2019-08-13  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 472         single switch.
 473         (show_source_disasm_command, show_source_or_disasm_and_command):
 474         Don't check current layout.
 475
 476 2019-08-13  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-wingeneral.c (make_all_visible): Remove.
 479         (tui_make_all_invisible): Simplify.
 480         * tui/tui-layout.c (tui_make_all_invisible): Move from
 481         tui-wingeneral.c; simplify.
 482         (show_layout): Hoist call to tui_make_all_invisible.
 483         (show_data): Don't call tui_make_all_invisible.
 484
 485 2019-08-13  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 488         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 489
 490 2019-08-13  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 493         tui-data.c.
 494         (show_source_disasm_command, show_data)
 495         (show_source_or_disasm_and_command): Don't use
 496         tui_set_current_layout_to.
 497         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 498         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 499         tui-layout.c.
 500         (tui_set_current_layout_to): Remove.
 501
 502 2019-08-13  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-layout.c (tui_set_layout): Update.
 505         * tui/tui-data.h (struct tui_layout_def): Remove.
 506         (tui_layout_def): Don't declare.
 507         * tui/tui-data.c (layout_def): Remove.
 508         (tui_layout_def): Remove.
 509
 510 2019-08-13  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-winsource.h (struct tui_source_window_base)
 513         <clear_detail>: No longer "override".
 514         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 515         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 516         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 517         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 518         Remove.
 519         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 520
 521 2019-08-13  Tom Tromey  <tromey@adacore.com>
 522
 523         * tracepoint.c: Don't include readline.h or history.h.
 524
 525 2019-08-12  Tom Tromey  <tom@tromey.com>
 526
 527         * configure: Rebuild.
 528         * configure.ac: Check for readline 7.
 529         * NEWS: Mention readline 7 requirement.
 530         * README: Update.
 531
 532 2019-08-12  Tom Tromey  <tom@tromey.com>
 533
 534         * mingw-hdep.c (gdb_select): Remove readline hack.
 535
 536 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 537
 538         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 539         when the function fails.
 540
 541 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 542
 543         * s390-tdep.c (s390_type_align): New function.
 544         (s390_gdbarch_init): Set it as type_align gdbarch method.
 545
 546 2019-08-09  Tom de Vries  <tdevries@suse.de>
 547
 548         PR gdb/24591
 549         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 550         pc_low with relocation offset.
 551
 552 2019-08-07  Tom Tromey  <tromey@adacore.com>
 553
 554         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 555         (print_frame_args): Update.
 556         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 557         Update.
 558         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 559         * frame.h (struct frame_arg): Add initializers.
 560         <error>: Now a unique_xmalloc_ptr.
 561
 562 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 563
 564         * NEWS: Expand the Pointer Authentication entry.
 565         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 566         (aarch64_frame_unmask_lr): ... to this.
 567         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 568         Call aarch64_frame_unmask_lr.
 569         * frame.c (struct frame_info): Add "masked" variable.
 570         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 571         (fprint_frame): Check for masked pc.
 572         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 573         declarations.
 574         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 575         * stack.c (print_frame): Check for masked pc.
 576
 577 2019-08-06  Tom Tromey  <tom@tromey.com>
 578
 579         * stabsread.c (patch_block_stabs, read_one_struct_field)
 580         (read_enum_type): Use obstack_strndup.
 581         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 582         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 583         * dwarf2read.c (guess_full_die_structure_name)
 584         (anonymous_struct_prefix): Use obstack_strndup.
 585         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 586         * c-exp.y (yylex): Use obstack_strndup.
 587         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 588         (write_var_or_type): Use obstack_strndup.
 589
 590 2019-08-06  Tom Tromey  <tom@tromey.com>
 591
 592         * symfile.c (reread_symbols): Use obstack_strdup.
 593         * stabsread.c (read_type): Use obstack_strdup.
 594         * gdb_obstack.h (obstack_strdup): New overload.
 595         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 596         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 597         (dwarf2_canonicalize_name): Use obstack_strdup.
 598         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 599         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 600         Use obstack_strdup.
 601
 602 2019-08-06  Tom Tromey  <tom@tromey.com>
 603
 604         * gdb_obstack.h (obstack_strdup): Define.
 605         * gdb_obstack.c (obstack_strdup): Don't define.
 606
 607 2019-08-06  Tom Tromey  <tom@tromey.com>
 608
 609         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 610         obstack_strdup.
 611         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 612         obstack_strdup.
 613         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 614         * stabsread.c (common_block_start): Use obstack_strdup.
 615         * objfiles.c (set_objfile_main_name, objfile): Use
 616         obstack_strdup.
 617         * namespace.c (add_using_directive): Use obstack_strdup.
 618         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 619         * jit.c (finalize_symtab): Use obstack_strdup.
 620         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 621         (guess_partial_die_structure_name, partial_die_info::fixup)
 622         (dwarf2_name): Use obstack_strdup.
 623         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 624         obstack_strdup.
 625         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 626         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 627         obstack_strdup.
 628         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 629
 630 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 631
 632         * unittests/help-doc-selftests.c: New file.
 633         * Makefile.in: Add the new file.
 634
 635 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 636
 637         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 638         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 639         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 640         the trailing '.' is not output, and the first character is uppercased.
 641         (print_help_for_command): Update call to print_doc_line.
 642         (print_doc_of_command): Likewise.
 643         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 644         * cli/cli-option.c (append_indented_doc): Do not append newline.
 645         (build_help_option): Append newline after first appended_indented_doc
 646         only if a second call is done.
 647         (build_help): Append 2 new lines before each option, except the first
 648         one.
 649         * compile/compile.c (_initialize_compile): Add new lines after
 650         %OPTIONS%, when not at the end of the help.
 651         Change help doc or code
 652         producing the help doc to respect the invariants.
 653         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 654         Also removed the new line after 'Options:', as all other commands
 655         do not put an empty line between 'Options:' and the first option.
 656         * printcmd.c (_initialize_printcmd): Likewise.
 657         * stack.c (_initialize_stack): Likewise.
 658         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 659         incorrectly telling COMMAND is optional.
 660         * ada-lang.c (_initialize_ada_language): Change help doc or code
 661         producing the help doc to respect the invariants.
 662         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 663         * breakpoint.c (_initialize_breakpoint): Likewise.
 664         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 665         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 666         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 667         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 668         _initialize_cli_style): Likewise.
 669         * corelow.c (core_target_info): Likewise.
 670         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 671         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 672         * filesystem.c (_initialize_filesystem): Likewise.
 673         * frame.c (_initialize_frame): Likewise.
 674         * gnu-nat.c (add_task_commands): Likewise.
 675         * infcall.c (_initialize_infcall): Likewise.
 676         * infcmd.c (_initialize_infcmd): Likewise.
 677         * interps.c (_initialize_interpreter): Likewise.
 678         * language.c (_initialize_language): Likewise.
 679         * linux-fork.c (_initialize_linux_fork): Likewise.
 680         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 681         * maint.c (_initialize_maint_cmds): Likewise.
 682         * memattr.c (_initialize_mem): Likewise.
 683         * printcmd.c (_initialize_printcmd): Likewise.
 684         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 685         _RegEx): Likewise.
 686         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 687         * record-btrace.c (_initialize_record_btrace): Likewise.
 688         * record-full.c (_initialize_record_full): Likewise.
 689         * record.c (_initialize_record): Likewise.
 690         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 691         * regcache.c (_initialize_regcache): Likewise.
 692         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 693         _initialize_remote): Likewise.
 694         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 695         * serial.c (_initialize_serial): Likewise.
 696         * skip.c (_initialize_step_skip): Likewise.
 697         * source.c (_initialize_source): Likewise.
 698         * stack.c (_initialize_stack): Likewise.
 699         * symfile.c (_initialize_symfile): Likewise.
 700         * symtab.c (_initialize_symtab): Likewise.
 701         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 702         * top.c (init_main): Likewise.
 703         * tracefile-tfile.c (tfile_target_info): Likewise.
 704         * tracepoint.c (_initialize_tracepoint): Likewise.
 705         * tui/tui-win.c (_initialize_tui_win): Likewise.
 706         * utils.c (add_internal_problem_command): Likewise.
 707         * valprint.c (value_print_option_defs): Likewise.
 708
 709 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 710
 711         PR build/24886
 712         * configure.ac: Drop enable-libmcheck support.
 713         * configure, config.in: Rebuild.
 714         * libmcheck.m4: Remove.
 715         * acinclude.m4: Don't include it.
 716         * Makefile.in: Don't distribute it.
 717         * top.c (print_gdb_configuration): Don't mention it.
 718
 719 2019-08-06  Tom Tromey  <tom@tromey.com>
 720
 721         * utils.c (set_output_style): Sometimes pass stream to
 722         emit_style_escape.
 723         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 724         * record-btrace.c (btrace_insn_history): Update.
 725         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 726         method.
 727         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 728         Update initializers.
 729         <m_uiout>: New field.
 730         <m_di>: Move lower.
 731         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 732         Remove "uiout" parameter.
 733         (dump_insns): Update.
 734         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 735         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 736
 737 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 738
 739         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 740         (error_in_psymtab_expansion): Likewise.
 741         (lookup_symbol_via_quick_fns): Likewise.
 742         (basic_lookup_transparent_type_quick): Likewise.
 743         (basic_lookup_transparent_type_1): Likewise.
 744
 745 2019-08-06  Tom Tromey  <tromey@adacore.com>
 746
 747         * source.c (last_source_error): Now bool.
 748         (print_source_lines_base): Make "noprint" bool.  Only open
 749         source file when last_source_visited changes.
 750
 751 2019-08-06  Tom Tromey  <tromey@adacore.com>
 752
 753         * annotate.c (annotate_source_line): Use g_source_cache.
 754         * source-cache.c (source_cache::get_plain_source_lines): Change
 755         parameters.  Populate m_offset_cache.
 756         (source_cache::ensure): New method.
 757         (source_cache::get_line_charpos): New method.
 758         (extract_lines): Move lower.  Change parameters.
 759         (source_cache::get_source_lines): Move lower.
 760         * source-cache.h (class source_cache): Update comment.
 761         <get_line_charpos>: New method.
 762         <get_source_lines>: Update comment.
 763         <clear>: Clear m_offset_cache.
 764         <get_plain_source_lines>: Change parameters.
 765         <ensure>: New method
 766         <m_offset_cache>: New member.
 767         * source.c (forget_cached_source_info_for_objfile): Update.
 768         (info_source_command): Use g_source_cache.
 769         (find_source_lines, open_source_file_with_line_charpos): Remove.
 770         (print_source_lines_base, search_command_helper): Use g_source_cache.
 771         * source.h (open_source_file_with_line_charpos): Don't declare.
 772         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 773         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 774         Use g_source_cache.
 775
 776 2019-08-06  Tom Tromey  <tromey@adacore.com>
 777
 778         * source-cache.c (source_cache::get_plain_source_lines):
 779         Remove "first_line" and "last_line" parameters.
 780         (source_cache::get_source_lines): Cache plain text.
 781         * source-cache.h (class source_cache)
 782         <get_plain_source_lines>: Update.
 783
 784 2019-08-06  Tom Tromey  <tromey@adacore.com>
 785
 786         * source-cache.c (extract_lines): No longer a method.
 787         Changed type of parameter.  Include final newline.
 788         (selftests::extract_lines_test): New function.
 789         (_initialize_source_cache): Likewise.
 790         * source-cache.h (class source_cache)
 791         <extract_lines>: Don't declare.
 792
 793 2019-08-06  Tom Tromey  <tromey@adacore.com>
 794
 795         * breakpoint.c (init_breakpoint_sal): Update.
 796         (breakpoint): Update.
 797         * breakpoint.h (struct breakpoint) <filter>: Now a
 798         unique_xmalloc_ptr.
 799
 800 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 801
 802         * NEWS: Mention dictionary access on blocks.
 803         * python/py-block.c (blpy_getitem): New function.
 804         (block_object_as_mapping): New struct.
 805         (block_object_type): Use new struct for tp_as_mapping field.
 806
 807 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 808
 809         * objfiles.h (objfile): Add a comment describing partial symbols.
 810
 811 2019-08-05  Tom Tromey  <tromey@adacore.com>
 812
 813         * compile/compile.c (_initialize_compile): Use _(), not N_().
 814         * thread.c (_initialize_thread): Use _(), not N_().
 815         * stack.c (_initialize_stack): Use _(), not N_().
 816         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 817
 818 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 819
 820         * dwarf2read.c (struct dw2_symtab_iterator):
 821         <want_specific_block>: Remove.
 822         <block_index>: Change type to gdb::optional.
 823         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 824         change type of BLOCK_INDEX parameter to gdb::optional.
 825         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 826         (dw2_lookup_symbol): Don't pass argument for
 827         WANT_SPECIFIC_BLOCK.
 828         (dw2_expand_symtabs_for_function): Don't pass argument for
 829         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 830         (class dw2_debug_names_iterator)
 831         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 832         parameter, change BLOCK_INDEX type to gdb::optional.
 833         <m_want_specific_block>: Remove.
 834         <m_block_index>: Change type to gdb::optional.
 835         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 836         gdb::optional.  Re-write in function of gdb::optional.
 837         (dw2_debug_names_lookup_symbol): Don't pass argument for
 838         WANT_SPECIFIC_BLOCK.
 839         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 840         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 841         BLOCK_INDEX.
 842
 843 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 844
 845         * NEWS: Mention changes to "info sources" command.
 846
 847 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 848
 849         * symtab.c (filename_partial_match_opts): New struct type.
 850         (struct output_source_filename_data): New members
 851         regexp, c_regexp, partial_match.
 852         (output_source_filename): Use new members to decide to print file.
 853         (info_sources_option_defs): New variable.
 854         (make_info_sources_options_def_group, print_info_sources_header,
 855         info_sources_command_completer):
 856         New functions.
 857         (info_sources_command): Read new optional arguments.
 858         (_initialize_symtab): Update info sources help.
 859
 860 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 861
 862         * ada-lang.c (exception_support_info_v0): Renamed from...
 863         (default_exception_support_info): ... this.  Create new
 864         definition for v1.
 865         (ada_has_this_exception_support): Look up catch_handlers_sym.
 866         (ada_exception_support_info_sniffer): Try v0 after default.
 867
 868 2019-08-01  Tom Tromey  <tromey@adacore.com>
 869
 870         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 871         gdbarch.h.
 872
 873 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 874
 875         * s12z-tdep.c: Fix include path for s12z-opc.h.
 876
 877 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 878
 879         * NEWS: Require GNU make 3.82.
 880
 881 2019-07-16  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 884         declare.
 885
 886 2019-07-30  Tom Tromey  <tromey@adacore.com>
 887
 888         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 889
 890 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 891
 892         * printcmd.c (print_address_symbolic): Print negative offsets.
 893         (build_address_symbolic): Force signed arithmetic when computing
 894         offset.
 895
 896 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 897
 898         PR/24474: Add a function to lookup static variables.
 899         * NEWS: Mention this new function.
 900         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 901         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 902         * python/python.c (python_GdbMethods): Add new function.
 903
 904 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 905
 906         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 907         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 908         (objfpy_lookup_static_symbol): New function.
 909         (objfile_object_methods): Add new functions.
 910
 911 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 912
 913         * NEWS: Mention 'set|show print frame-info'.  Mention new
 914         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 915         backtrace argument.  Mention that python frame filtering code
 916         is now consistent with what 'backtrace' command prints.
 917
 918 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 919
 920         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 921         comments.
 922         (print_frame_info_auto, print_frame_info_source_line,
 923         print_frame_info_location, print_frame_info_source_and_location,
 924         print_frame_info_location_and_address, print_frame_info_short_location):
 925         New declarations.
 926         (struct frame_print_options): New member print_frame_info.
 927         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 928         * stack.h (get_user_print_what_frame_info): New declaration.
 929         (frame_show_address): New declaration.
 930         * stack.c (print_frame_arguments_choices): New value 'presence'.
 931         (print_frame_info_auto, print_frame_info_source_line,
 932         print_frame_info_location, print_frame_info_source_and_location,
 933         print_frame_info_location_and_address, print_frame_info_short_location,
 934         print_frame_info_choices, print_frame_info_print_what): New definitions.
 935         (print_frame_args): Only print dots for args if print frame-arguments
 936         is 'presence'.
 937         (frame_print_option_defs): New element for "frame-info".
 938         (get_user_print_what_frame_info): New function.
 939         (frame_show_address): Make non static.  Move comment to stack.h.
 940         (print_frame_info_to_print_what): New function.
 941         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 942         to decide what to print.
 943         (backtrace_command_1): Handle the new print_frame_arguments_presence
 944         value.
 945         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 946         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 947         (py_print_frame): In non-mi mode, use LOCATION as default for
 948         print_what, similarly to frame information printed directly by
 949         backtrace command. Handle frame-info user option in non MI mode.
 950
 951 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 952
 953         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 954         Add case for debugging 32-bit target on 64-bit host.  Revise
 955         comment.
 956
 957 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 958
 959         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 960         instead of find_function_entry_range_from_pc.
 961
 962 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 963
 964         * stack.c (find_frame_funname): Remove code which preferred
 965         minsym over symtab sym in "certain pathological cases".
 966
 967         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 968         parameter.  Change type of "do_demangle" to bool.
 969         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 970         Pass suitable "prefer_sym_over_minsym" flag to
 971         build_address_symbolic().  Don't output "+" for negative offsets.
 972         * printcmd.c (print_address_symbolic): Update invocation of
 973         build_address_symbolic to include a "prefer_sym_over_minsym"
 974         flag.
 975         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 976         Restrict cases in which use of minimal symbol is preferred to that
 977         of a found symbol.  Update comments.
 978
 979         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 980         for entry pc when entry pc is out of range for that FDE.
 981
 982 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 983
 984         PR gdb/24839:
 985         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 986         type.
 987
 988 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 989
 990         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 991         this function's Python signature.
 992
 993
 994 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 995
 996         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 997         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 998         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 999         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1000         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1001
1002
1003 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1004
1005         * h8300-tdep.c (h8300_register_name_common): New.
1006         h8300_register_name): Use h8300_register_name_common.
1007         (h8300s_register_name): Likewise.
1008         (h8300sx_register_name): Likewise.
1009         (h8300h_register_nam): New.
1010         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1011
1012
1013 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1014
1015         * arm-tdep.c (arm_skip_cmse_entry): New function.
1016         (arm_is_sgstubs_section): New function.
1017         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1018
1019 2019-07-22  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1022         Don't self-assign.
1023
1024 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1027         type_print.
1028
1029 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1032         so that GDB doesn't match any msymbols when searching in the
1033         TYPES_DOMAIN.
1034         (print_symbol_info): Print using typedef_print or type_print based
1035         on the type of the symbol.  Add updated FIXME comment moved from...
1036         (_initialize_symtab): ... move and update FIXME comment to above.
1037
1038 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * NEWS: Mention adding -q option to "info types".
1041         * symtab.c (struct info_types_options): New struct.
1042         (info_types_options_defs): New variable.
1043         (make_info_types_options_def_group): New function.
1044         (info_types_command): Use gdb::option framework to parse options.
1045         (info_types_command_completer): New function.
1046         (_initialize_symtab): Extend the help text on "info types" and
1047         register command completer.
1048
1049 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1050
1051         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1052         (lookup_symbol_in_objfile): Change int to block_enum and add a
1053         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1054
1055 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1056
1057         * MAINTAINERS (Write After Approval): Add self.
1058
1059 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1062         instruction to the dummy code region.
1063
1064 2019-07-19  Tom Tromey  <tromey@adacore.com>
1065
1066         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1067         (ARGSUSED, PARAMS, __func__): Remove rules.
1068
1069 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1070
1071         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1072         * features/arm/arm-with-iwmmxt.c: Remove.
1073         * features/arm/arm-with-iwmmxt.xml: Remove.
1074         * features/arm/arm-with-m-fpa-layout.c: Remove.
1075         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1076         * features/arm/arm-with-m-vfp-d16.c: Remove.
1077         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1078         * features/arm/arm-with-m.c: Remove.
1079         * features/arm/arm-with-m.xml: Remove.
1080         * features/arm/arm-with-neon.c: Remove.
1081         * features/arm/arm-with-neon.xml: Remove.
1082         * features/arm/arm-with-vfpv2.c: Remove.
1083         * features/arm/arm-with-vfpv2.xml: Remove.
1084         * features/arm/arm-with-vfpv3.c: Remove.
1085         * features/arm/arm-with-vfpv3.xml: Remove.
1086
1087 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1088
1089         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1090
1091 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1092
1093         * arch/aarch32.c (aarch32_create_target_description): Create
1094         target descriptions using features.
1095         * arch/arm.c (arm_create_target_description)
1096         (arm_create_mprofile_target_description): Likewise.
1097         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1098
1099 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1100
1101         * Makefile.in: Add new files.
1102         * aarch32-tdep.c: New file.
1103         * aarch32-tdep.h: New file.
1104         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1105         Call aarch32_read_description.
1106         * arch/aarch32.c: New file.
1107         * arch/aarch32.h: New file.
1108         * arch/arm.c (arm_create_target_description)
1109         (arm_create_mprofile_target_description): New function.
1110         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1111         (arm_create_target_description)
1112         (arm_create_mprofile_target_description): New declaration.
1113         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1114         read_description functions.
1115         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1116         Likewise.
1117         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1118         * arm-tdep.c (tdesc_arm_list): New variable.
1119         (arm_register_g_packet_guesses): Call create description functions.
1120         (arm_read_description) (arm_read_mprofile_description): New
1121         function.
1122         * arm-tdep.h (arm_read_description)
1123         (arm_read_mprofile_description): Add declaration.
1124         * configure.tgt: Add new files.
1125
1126 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1127
1128         * top.c (new_ui_command): Open specified terminal just once.
1129
1130 2019-07-18  Tom Tromey  <tromey@adacore.com>
1131
1132         * symtab.c (main_name): Constify return type.
1133         * symfile.c (set_initial_language): Update.
1134         * symtab.h (main_name): Constify return type.
1135
1136 2019-07-17  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui-winsource.c (tui_update_source_window)
1139         (tui_update_source_window_as_is)
1140         (tui_update_source_windows_with_line): Remove return.
1141         * tui/tui-disasm.c (tui_show_disassem)
1142         (tui_show_disassem_and_update_source): Remove return.
1143         * tui/tui.c (tui_reset): Remove return.
1144         * tui/tui-wingeneral.c
1145         (tui_check_and_display_highlight_if_needed): Remove return.
1146
1147 2019-07-17  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1150
1151 2019-07-17  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-winsource.h (struct tui_exec_info_window)
1154         (struct tui_source_window_base): Move from tui-data.h.
1155         * tui/tui-winsource.c: Move many method definitions from
1156         elsewhere.  Remove "structuring" comments.
1157         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1158         (tui_source_window_base::refresh_window): Move to
1159         tui-winsource.c.
1160         * tui/tui-win.c (tui_source_window_base::refresh_all)
1161         (tui_source_window_base::update_tab_width)
1162         (tui_source_window_base::set_new_height)
1163         (tui_source_window_base::do_make_visible_with_new_height): Move to
1164         tui-winsource.c.
1165         * tui/tui-source.h: Update.
1166         * tui/tui-source.c (tui_source_window_base::reset): Move to
1167         tui-winsource.c.
1168         * tui/tui-disasm.h: Update.
1169         * tui/tui-data.h (struct tui_exec_info_window): Move to
1170         tui-winsource.h.
1171         (struct tui_source_window_base): Likewise.
1172         * tui/tui-data.c (tui_source_window_base::clear_detail)
1173         (tui_source_window_base, ~tui_source_window_base): Move to
1174         tui-winsource.c.
1175
1176 2019-07-17  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-win.c (tui_resize_all)
1179         (tui_source_window_base::update_tab_width)
1180         (tui_adjust_win_heights): Update.
1181         (tui_win_info::make_invisible_and_set_new_height): Rename from
1182         make_invisible_and_set_new_height.
1183         * tui/tui-data.h (struct tui_win_info)
1184         <make_invisible_and_set_new_height>: New method.
1185
1186 2019-07-17  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui.c: Update.
1189         * tui/tui-source.h (struct tui_source_window): Move from
1190         tui-data.h.
1191         * tui/tui-layout.c: Update.
1192         * tui/tui-disasm.c: Update.
1193         * tui/tui-data.h (struct tui_source_window): Move to
1194         tui-source.h.
1195
1196 2019-07-17  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1199         tui-data.h.
1200         * tui/tui-data.h (struct tui_disasm_window): Move to
1201         tui-disasm.h.
1202
1203 2019-07-17  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-regs.h (struct tui_data_item_window): Move from
1206         tui-data.h.
1207         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1208         * tui/tui-data.h (struct tui_data_item_window): Move to
1209         tui-regs.h.
1210         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1211
1212 2019-07-17  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui.c: Update.
1215         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1216         (tui_cmd_window::max_height): Move to tui-command.c.
1217         * tui/tui-layout.c: Update.
1218         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1219         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1220         tui-command.c.
1221         * tui/tui-command.h (struct tui_cmd_window): Move from
1222         tui-data.h.
1223         * tui/tui-command.c: Remove "structuring" comments.
1224         (tui_cmd_window::clear_detail)
1225         (tui_cmd_window::do_make_visible_with_new_height)
1226         (tui_cmd_window::max_height): Move from elsewhere.
1227
1228 2019-07-17  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1231         Now static.
1232         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1233         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1234
1235 2019-07-17  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui.c: Update.
1238         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1239         tui-regs.c.
1240         * tui/tui-windata.h: Remove file.
1241         * tui/tui-windata.c: Remove file.
1242         * tui/tui-win.c (tui_data_window::set_new_height)
1243         (tui_data_window::do_make_visible_with_new_height): Move to
1244         tui-regs.c.
1245         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1246         * tui/tui-regs.c: Remove "structuring" comments.
1247         (tui_data_window::first_data_item_displayed)
1248         (tui_data_window::delete_data_content_windows)
1249         (tui_data_window::erase_data_content)
1250         (tui_data_window::display_all_data)
1251         (tui_data_window::refresh_all)
1252         (tui_data_window::do_scroll_vertical)
1253         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1254         (tui_data_window::do_make_visible_with_new_height)
1255         (tui_data_window::refresh_window): Move from elsewhere.
1256         (_initialize_tui_regs): Move to end of file.
1257         * tui/tui-layout.c: Update.
1258         * tui/tui-hooks.c: Update.
1259         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1260         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1261         tui-regs.c.
1262         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1263
1264 2019-07-17  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1267         seen.
1268
1269 2019-07-17  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-win.c (tui_source_window_base::set_new_height)
1272         (tui_source_window_base::do_make_visible_with_new_height): Use
1273         m_has_locator field directly.
1274         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1275         method.
1276         (struct tui_source_window_base) <has_locator>: Likewise.
1277
1278 2019-07-17  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1281         Don't declare.
1282         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1283         Remove.
1284         * tui/tui-win.c (tui_source_window_base::set_new_height)
1285         (tui_source_window_base::set_new_height)
1286         (make_invisible_and_set_new_height)
1287         (tui_source_window_base::do_make_visible_with_new_height)
1288         (tui_source_window_base::do_make_visible_with_new_height):
1289         Update.
1290         * tui/tui-layout.c (show_source_disasm_command, show_data)
1291         (show_source_or_disasm_and_command): Update.
1292         * tui/tui-layout.c (show_layout): Update.
1293
1294 2019-07-17  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui-layout.c (make_data_window): Remove.
1297         (show_data): Unify creation and re-initialization cases.
1298
1299 2019-07-17  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-layout.c (make_source_window, make_disasm_window):
1302         Remove.
1303         (show_data): Unify creation and re-initialization cases.
1304
1305 2019-07-17  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-layout.c (make_command_window): Remove.
1308         (show_source_disasm_command, show_source_or_disasm_and_command):
1309         Unify creation and re-initialization cases.
1310
1311 2019-07-17  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1314         creation and re-initialization cases.
1315
1316 2019-07-17  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-regs.c (tui_get_register): Return void.
1319
1320 2019-07-17  Tom Tromey  <tom@tromey.com>
1321
1322         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1323         Simplify.
1324
1325 2019-07-17  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1328         resetting.
1329
1330 2019-07-17  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1333         * tui/tui-regs.c (tui_reg_layout): New function.
1334         (tui_show_registers, tui_reg_command): Use it.
1335         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1336         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1337         parameters.
1338         (tui_layout_command): Remove.
1339
1340 2019-07-17  Tom Tromey  <tom@tromey.com>
1341
1342         * tui/tui-layout.h (tui/tui-layout): Return void.
1343         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1344
1345 2019-07-17  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-layout.c (show_source_disasm_command, show_data):
1348         Update.
1349         (reset_locator): Remove.
1350         (show_source_or_disasm_and_command): Update.
1351
1352 2019-07-17  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-source.c (tui_source_window_base::reset): Remove
1355         win_type parameter.
1356         * tui/tui-layout.c (make_command_window, make_source_window)
1357         (make_disasm_window, make_data_window)
1358         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1359         (reset_locator, show_source_or_disasm_and_command): Update.
1360         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1361         win_type parameter.
1362         (struct tui_source_window_base) <reset>: Likewise.
1363
1364 2019-07-17  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-layout.c (show_source_disasm_command): Use
1367         reset_locator.
1368         (reset_locator): New function.
1369         (init_and_make_win): Remove.
1370         (show_source_or_disasm_and_command): Use reset_locator.
1371
1372 2019-07-17  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1375         condition.
1376         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1377         Remove condition.
1378         * tui/tui-source.c (tui_source_window_base::reset): New method.
1379         * tui/tui-layout.c (make_command_window): Don't call
1380         init_and_make_win.
1381         (make_source_window, make_disasm_window): Don't call
1382         make_source_or_disasm_window.
1383         (make_data_window): Don't call init_and_make_win.  Change calling
1384         convention.
1385         (show_source_disasm_command, show_data): Simplify.
1386         (make_source_or_disasm_window): Remove.
1387         (show_source_or_disasm_and_command): Simplify.
1388         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1389         (struct tui_source_window_base) <reset>: Likewise.
1390         <execution_info>: Remove initializer.
1391         * tui/tui-data.c (tui_source_window_base): Initialize
1392         execution_info.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1397         variable.
1398
1399 2019-07-17  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui.c (tui_rl_other_window): Update.
1402         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1403         superclass method first.  Always iterate over regs_content.
1404         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1405         method.
1406         * tui/tui-win.c (tui_set_focus_command): Update.
1407
1408 2019-07-17  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-win.c (tui_set_focus_command): Rename from
1411         tui_set_focus.  Call tui_enable.
1412         (tui_set_focus_command): Remove.
1413
1414 2019-07-17  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1417         refresh_window.
1418         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1419         touchwin.
1420         (tui_data_window::refresh_window): Call refresh_window on data
1421         items.  Always call superclass refresh_window.
1422         (tui_win_info::refresh): Remove.
1423         (tui_source_window_base::refresh_window): Update.
1424         (tui_refresh_all): Update.
1425         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1426         refresh_window.
1427         (show_source_or_disasm_and_command): Likewise.
1428         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1429         (struct tui_source_window_base) <refresh>: Likewise.
1430
1431 2019-07-17  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-winsource.c (tui_clear_source_content)
1434         (tui_show_source_content): Update.
1435         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1436         whether content is empty.
1437         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1438         Remove.
1439
1440 2019-07-17  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1443         window's contents.
1444         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1445         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1446
1447 2019-07-17  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1450         (struct tui_data_item_window): Update.
1451
1452 2019-07-17  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1455         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1456         defines.
1457
1458 2019-07-17  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-winsource.h (tui_erase_source_content)
1461         (tui_clear_source_content): Remove "display_prompt" parameter.
1462         * tui/tui-winsource.c (tui_update_source_window_as_is)
1463         (tui_update_source_windows_with_addr): Update.
1464         (tui_clear_source_content): Remove "display_prompt" parameter.
1465         (tui_erase_source_content): Likewise.  Simplify.
1466         (tui_show_source_content): Update.
1467         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1468         * tui/tui-stack.c (tui_show_frame_info): Update.
1469         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1470         Remove defines.
1471
1472 2019-07-17  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1475         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1476         parameter.
1477         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1478         parameter.
1479
1480 2019-07-17  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-winsource.c (tui_clear_source_content)
1483         (tui_show_source_content, tui_show_exec_info_content)
1484         (tui_clear_exec_info_content): Update.
1485         * tui/tui-stack.c (tui_show_locator_content): Update.
1486         (tui_show_frame_info): Update.
1487         * tui/tui-source.h (tui_source_window): Don't declare.
1488         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1489         from tui_source_is_displayed.
1490         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1491         Remove field.
1492         (struct tui_source_window_base) <content_in_use>: New field.  Now
1493         bool.
1494         (struct tui_source_window) <showing_source_p>: New method.
1495         (TUI_SRC_WIN): Change cast.
1496         * tui/tui-data.c (tui_initialize_static_data): Update.
1497
1498 2019-07-17  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1501         location_matches_p.
1502         * tui/tui-source.c (tui_source_window::location_matches_p): New
1503         method.
1504         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1505         method.
1506         * tui/tui-data.h (struct tui_source_window_base)
1507         <location_matches_p>: New method.
1508         (struct tui_source_window, struct tui_disasm_window)
1509         <location_matches_p>: Likewise.
1510
1511 2019-07-17  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-win.c (tui_set_win_height_command): Rename from
1514         tui_set_win_height.
1515         (tui_set_win_height_command): Remove.
1516
1517 2019-07-17  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-source.c (tui_source_window): New constructor.  Add
1520         observer.
1521         (~tui_source_window): New destructor.
1522         (tui_source_window::style_changed): New method.
1523         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1524         (tui_attach_detach_observers): Update.
1525         * tui/tui-data.h (struct tui_source_window): Make constructor not
1526         inline.  Add destructor.
1527         (struct tui_source_window) <style_changed>: New method.
1528         <m_observable>: New member.
1529
1530 2019-07-17  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1533         * tui/tui-win.c (tui_resize_all): Fix typo.
1534
1535 2019-07-17  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1538         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1539         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1540         * tui/tui-win.c (window_name_completer): Use foreach.
1541         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1542         (update_tab_width): Likewise.
1543         * tui/tui-layout.c (show_layout): Update.
1544         * tui/tui-data.h (class tui_window_iterator): New.
1545         (struct all_tui_windows): New.
1546         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1547
1548 2019-07-17  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1551         parameter.  Don't reference globals.
1552         (tui_reg_command): Update.
1553
1554 2019-07-17  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-regs.c (tui_show_registers): Simplify.
1557
1558 2019-07-17  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-regs.c (tui_show_registers): Update.
1561         (tui_show_register_group): Add win_info parameter.
1562
1563 2019-07-17  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1566         Rename from tui_display_reg_element_at_line.
1567         (tui_data_window::display_registers_from_line): Update.
1568         * tui/tui-data.h (struct tui_data_window)
1569         <display_reg_element_at_line>: New method.
1570
1571 2019-07-17  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-regs.h (tui_display_registers_from)
1574         (tui_display_registers_from_line): Don't declare.
1575         * tui/tui-windata.c (tui_data_window::display_all_data)
1576         (tui_data_window::refresh_all)
1577         (tui_data_window::do_scroll_vertical): Update.
1578         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1579         from tui_display_registers_from.
1580         (tui_display_reg_element_at_line): Update.
1581         (tui_data_window::display_registers_from_line): Rename from
1582         tui_display_registers_from_line.
1583         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1584         display_registers_from_line>: New methods.
1585
1586 2019-07-17  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1589         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1590         from tui_erase_data_content.
1591         (tui_data_window::display_all_data)
1592         (tui_data_window::refresh_all)
1593         (tui_data_window::do_scroll_vertical): Update.
1594         * tui/tui-regs.c (tui_show_registers): Update.
1595         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1596         New method.
1597
1598 2019-07-17  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1601         declare.
1602         * tui/tui-windata.c
1603         (tui_data_window::delete_data_content_windows): Rename from
1604         tui_delete_data_content_windows.
1605         (tui_data_window::display_all_data)
1606         (tui_data_window::do_scroll_vertical): Update.
1607         * tui/tui-data.h (struct tui_data_window)
1608         <delete_data_content_windows>: New method.
1609
1610 2019-07-17  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1613         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1614
1615 2019-07-17  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1618         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1619         from tui_display_all_data.
1620         * tui/tui-win.c
1621         (tui_data_window::do_make_visible_with_new_height): Update.
1622         * tui/tui-regs.c (tui_show_registers): Update.
1623         * tui/tui-layout.c (tui_set_layout): Update.
1624         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1625         method.
1626
1627 2019-07-17  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1630         * tui/tui-windata.c (tui_display_data_from): Remove.
1631         (tui_data_window::refresh_all): Update.
1632
1633 2019-07-17  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1636         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1637         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1638         tui_display_registers_from_line.
1639         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1640         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1641         "force_display" parameter.
1642
1643 2019-07-17  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1646         declare.
1647         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1648         Rename from tui_first_reg_element_no_inline.
1649         (tui_display_reg_element_at_line)
1650         (tui_display_registers_from_line): Update.
1651         * tui/tui-data.h (struct tui_data_window)
1652         <first_reg_element_no_inline>: New method.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-windata.c (tui_display_data_from)
1657         (tui_data_window::do_scroll_vertical): Update.
1658         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1659         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1660         Rename from tui_line_from_reg_element_no.
1661         (tui_display_registers_from_line): Update.
1662         * tui/tui-data.h (struct tui_data_window)
1663         <line_from_reg_element_no>: New method.
1664
1665 2019-07-17  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1668         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1669         tui_last_regs_line_no.
1670         (tui_display_reg_element_at_line)
1671         (tui_display_registers_from_line): Update.
1672         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1673         method.
1674
1675 2019-07-17  Tom Tromey  <tom@tromey.com>
1676
1677         PR tui/24722:
1678         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1679         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1680         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1681         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1682         (tui_update_breakpoint_info): Likewise.
1683         * tui/tui-hooks.c (tui_event_create_breakpoint)
1684         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1685         Update.
1686
1687 2019-07-17  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1690
1691 2019-07-17  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-winsource.c (tui_update_source_window_as_is)
1694         (tui_update_source_windows_with_addr): Update.
1695         * tui/tui-source.h (tui_set_source_content)
1696         (tui_show_symtab_source): Add "win_info" parameter.
1697         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1698         parameter.
1699         (tui_show_symtab_source): Likewise.
1700
1701 2019-07-17  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-wingeneral.c
1704         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1705
1706 2019-07-17  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1709         (struct tui_cmd_window) <can_scroll>: New method.
1710         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1711         method.
1712
1713 2019-07-17  Tom Tromey  <tromey@adacore.com>
1714
1715         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1716         do_field_signed>: Rename.  Change type of "value".
1717         * ui-out.c (ui_out::field_signed): Rename from field_int.
1718         Change type of "value".
1719         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1720         type of "value".
1721         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1722         do_field_int.  Change type of "value".
1723         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1724         do_field_int.  Change type of "value".
1725         * tracepoint.c (trace_status_mi, tfind_1)
1726         (print_one_static_tracepoint_marker): Update.
1727         * thread.c (print_thread_info_1, print_selected_thread_frame):
1728         Update.
1729         * stack.c (print_frame, print_frame_info): Update.
1730         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1731         Update.
1732         * source.c (print_source_lines_base): Update.
1733         * skip.c (info_skip_command): Update.
1734         * record-btrace.c (btrace_ui_out_decode_error)
1735         (btrace_call_history_src_line): Update.
1736         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1737         Update.
1738         * progspace.c (print_program_space): Update.
1739         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1740         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1741         do_field_int.  Change type of "value".
1742         * mi/mi-out.c (mi_ui_out::do_table_begin)
1743         (mi_ui_out::do_table_header): Update.
1744         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1745         type of "value".
1746         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1747         (mi_cmd_data_list_changed_registers, output_register)
1748         (mi_cmd_data_read_memory, mi_load_progress)
1749         (mi_cmd_trace_frame_collected): Update.
1750         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1751         Update.
1752         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1753         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1754         (mi_cmd_var_list_children, varobj_update_one): Update.
1755         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1756         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1757         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1758         * inferior.c (print_inferior): Update.
1759         * gdb_bfd.c (print_one_bfd): Update.
1760         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1761         Update.
1762         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1763         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1764         do_field_int.  Change type of "value".
1765         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1766         do_field_int.  Change type of "value".
1767         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1768         (print_one_breakpoint_location, print_it_catch_fork)
1769         (print_one_catch_fork, print_it_catch_vfork)
1770         (print_one_catch_vfork, print_it_catch_solib)
1771         (print_it_catch_exec, print_it_ranged_breakpoint)
1772         (print_mention_watchpoint, print_mention_masked_watchpoint)
1773         (bkpt_print_it, update_static_tracepoint): Update.
1774         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1775         * break-catch-syscall.c (print_it_catch_syscall): Update.
1776         * ada-tasks.c (print_ada_task_info): Update.
1777         * ada-lang.c (print_it_exception, print_mention_exception):
1778         Update.
1779
1780 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1781
1782         PR breakpoints/24541
1783         * gdbarch.c: Regenerate.
1784         * gdbarch.h: Regenerate.
1785         * gdbarch.sh: Adjust return type and parameter types for
1786         'stap_adjust_register'.
1787         (i386_stap_adjust_register): Adjust signature and return new
1788         register name.
1789         * stap-probe.c (stap_parse_register_operand): Adjust use of
1790         'gdbarch_stap_adjust_register'.
1791
1792 2019-07-17  Tom Tromey  <tromey@adacore.com>
1793
1794         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1795         declare VEC.
1796         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1797         std::vector.
1798         (struct s390_process_info): Add initializers.
1799         (s390_add_process): Use new.
1800         (s390_linux_nat_target::low_forget_process): Use delete.
1801         (s390_linux_nat_target::low_new_fork)
1802         (s390_linux_nat_target::stopped_by_watchpoint)
1803         (s390_linux_nat_target::low_prepare_to_resume)
1804         (s390_linux_nat_target::insert_watchpoint)
1805         (s390_linux_nat_target::insert_hw_breakpoint)
1806         (s390_linux_nat_target::remove_watchpoint)
1807         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1808
1809 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1810
1811         * aarch64-fbsd-nat.c: Include regcache.h.
1812         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1813         argument.
1814         (aarch64_fbsd_nat_target::fetch_registers)
1815         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1816         variable.
1817         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1818
1819 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1820
1821         * fbsd-nat.c: Include gdbarch.h.
1822
1823 2019-07-15  Tom Tromey  <tromey@adacore.com>
1824
1825         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1826
1827 2019-07-15  Tom Tromey  <tromey@adacore.com>
1828
1829         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1830         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1831         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1832         * cli-out.c (cli_ui_out::do_field_int): New method.
1833         * ui-out.c (ui_out::field_unsigned): New method.
1834         * symfile.c (generic_load): Use field_unsigned.
1835         (print_transfer_performance): Likewise.
1836         * record-btrace.c (ui_out_field_uint): Remove.
1837         (btrace_call_history_insn_range, btrace_call_history): Use
1838         field_unsigned.
1839         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1840         field_unsigned.
1841         * ui-out.h (class ui_out) <field_unsigned>: New method.
1842         <do_field_unsigned>: Likewise.
1843
1844 2019-07-15  Tom Tromey  <tromey@adacore.com>
1845
1846         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1847         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1848         * target.c (flash_erase_command): Use field_string.
1849         * infrun.c (print_signal_received_reason): Use field_string.
1850         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1851         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1852         field_string.
1853         * ada-tasks.c (print_ada_task_info): Use field_string.
1854
1855 2019-07-15  Tom Tromey  <tromey@adacore.com>
1856
1857         * target.c (flash_erase_command): Use field_core_addr.
1858         * symfile.c (generic_load): Use field_core_addr.
1859         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1860         Use field_core_addr.
1861         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1862         field_core_addr.
1863
1864 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1865
1866         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1867         value if its desired type is smaller than a CORE_ADDR and signed.
1868
1869 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1872         of changes to field names, and use new is_reference field to
1873         decide if a property is a reference or not.
1874         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1875         field.
1876         (struct dwarf2_property_baton): Update header comment, rename
1877         'referenced_type' to 'property_type' and update comments.
1878         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1879         default property type, store in property baton, update to take
1880         accound of renamed field.
1881         (read_func_scope): Update call to attr_to_dynamic_prop.
1882         (read_array_type): Likewise.
1883         (dwarf2_per_cu_addr_sized_int_type): New function.
1884         (read_subrange_index_type): Move type finding code to
1885         dwarf2_per_cu_addr_sized_int_type.
1886         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1887         (dwarf2_per_cu_addr_type): New function.
1888         (set_die_type): Update calls to attr_to_dynamic_prop.
1889
1890 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * dwarf2read.c (read_subrange_index_type): New function.
1893         (read_subrange_type): Move code into new function and call it.
1894         * gdbtypes.c (create_range_type): Add some asserts.
1895
1896 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1897
1898         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1899         update return statements.
1900         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1901         declaration, and update comment to match.
1902         * gdbtypes.c (resolve_dynamic_array): Update call to
1903         dwarf2_evaluate_property to match new return type.
1904
1905 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * valarith.c (value_subscripted_rvalue): Change lowerbound
1908         parameter type from int to LONGEST.
1909         * value.h (value_subscripted_rvalue): Likewise in declaration.
1910
1911 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1912
1913         * cli/cli-utils.c (info_print_command_completer): New function.
1914         * cli/cli-utils.h: Add 'completer.h' include, and forward
1915         declaration for 'struct cmd_list_element'.
1916         (info_print_command_completer): Declare.
1917         * stack.c (_initialize_stack): Add completer for 'info locals' and
1918         'info args'.
1919         * symtab.c (_initialize_symtab): Add completer for 'info
1920         variables' and 'info functions'.
1921         * NEWS: Mention completion for additional info commands.
1922
1923 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * cli/cli-utils.c (extract_info_print_args): Delete.
1926         (extract_arg_maybe_quoted): Delete.
1927         (info_print_options_defs): New variable.
1928         (make_info_print_options_def_group): New function.
1929         (extract_info_print_options): Define new function.
1930         * cli/cli-utils.h (extract_info_print_args): Delete.
1931         (struct info_print_options): New structure.
1932         (extract_info_print_options): Declare new function.
1933         * stack.c (info_locals_command): Update to use new
1934         extract_info_print_options, also add a header comment.
1935         (info_args_command): Likewise.
1936         * symtab.c (info_variables_command): Likewise.
1937         (info_functions_command): Likewise.
1938
1939 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1942         to extract string arguments.
1943         * common/common-utils.c (extract_string_maybe_quoted): New function.
1944         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1945
1946 2019-07-11  Tom Tromey  <tromey@adacore.com>
1947
1948         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1949         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1950         * top.h (gdbinit): Don't declare.
1951         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1952         into...
1953         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1954         * top.c (gdb_init): Don't call init_cli_cmds.
1955         (gdbinit): Remove.
1956         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1957
1958 2019-07-11  Tom Tromey  <tromey@adacore.com>
1959
1960         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1961         after it has been moved.
1962
1963 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1964
1965         * valops.c (value_must_coerce_to_target): Change return type to
1966         bool.
1967         * value.h (value_must_coerce_to_target): Likewise.
1968
1969 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1970
1971         * breakpoint.c (is_hardware_watchpoint): Remove
1972         forward-declaration.
1973         (is_masked_watchpoint): Change return type to bool.
1974         (is_tracepoint): Likewise.
1975         (is_breakpoint): Likewise.
1976         (is_hardware_watchpoint): Likewise.
1977         (is_watchpoint): Likewise.
1978         (is_no_memory_software_watchpoint): Likewise.
1979         (is_catchpoint): Likewise.
1980         (breakpoint_1): Make FILTER parameter's return type bool.
1981         is_masked_watchpoint): Change return type to bool.
1982         (save_breakpoints): Make FILTER parameter's return type bool.
1983         * breakpoint.h (is_breakpoint): Change return type to bool.
1984         (is_watchpoint): Likewise.
1985         (is_catchpoint): Likewise.
1986         (is_tracepoint): Likewise.
1987
1988 2019-07-10  Tom Tromey  <tom@tromey.com>
1989
1990         * defs.h: Don't include gdbarch.h.
1991         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1992         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1993         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1994         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1995         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1996         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1997         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1998         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1999         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2000         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2001         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2002         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2003         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2004         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2005         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2006         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2007         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2008         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2009         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2010         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2011         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2012         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2013         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2014         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2015         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2016         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2017         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2018
2019 2019-07-10  Tom Tromey  <tromey@adacore.com>
2020
2021         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2022         * breakpoint.c (init_ada_exception_breakpoint): Register as
2023         bp_catchpoint.
2024         (print_one_breakpoint_location, print_one_breakpoint): Use
2025         is_ada_exception_catchpoint.
2026         * ada-lang.c (class ada_catchpoint_location): Pass
2027         bp_loc_software_breakpoint to bp_location constructor.
2028         (is_ada_exception_catchpoint): New function.
2029
2030 2019-07-10  Tom Tromey  <tromey@adacore.com>
2031
2032         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2033         VEC.
2034         (struct arm_exidx_entry): New method operator<.
2035         (struct arm_exidx_data) <section_maps>: Change type.
2036         (arm_exidx_data_free): Remove.
2037         (arm_exidx_data_key): Change type.  Move lower.
2038         (arm_exidx_new_objfile): Update.
2039         (arm_compare_exidx_entries): Remove.
2040         (arm_find_exidx_entry, _initialize_arm_tdep)
2041
2042 2019-07-10  Tom Tromey  <tromey@adacore.com>
2043
2044         * solib-spu.c (ocl_program_data_key): Change type.
2045         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2046         Update.
2047
2048 2019-07-10  Tom Tromey  <tromey@adacore.com>
2049
2050         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2051         (struct solib_aix_inferior_data) <library_list>: Change type.
2052         (solib_aix_inferior_data_handle): Change type.
2053         (get_solib_aix_inferior_data): Update.
2054         (solib_aix_free_library_list): Remove.
2055         (library_list_start_library): Update.
2056         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2057         return type.
2058         (solib_aix_get_library_list)
2059         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2060         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2061
2062 2019-07-10  Tom Tromey  <tromey@adacore.com>
2063
2064         * solib-dsbt.c (struct dsbt_info): Add initializers.
2065         (solib_dsbt_pspace_data): Change type.
2066         (dsbt_pspace_data_cleanup): Remove.
2067         (get_dsbt_info, _initialize_dsbt_solib): Update.
2068
2069 2019-07-10  Tom Tromey  <tromey@adacore.com>
2070
2071         * spu-tdep.c (spu_overlay_data): Change type.
2072         (spu_get_overlay_table, spu_overlay_new_objfile)
2073         (_initialize_spu_tdep): Update.
2074
2075 2019-07-10  Tom Tromey  <tromey@adacore.com>
2076
2077         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2078         destructor.
2079         (dbx_objfile_data_key): Change type and declare later.
2080         (DBX_SYMFILE_INFO): Rewrite.
2081         * dbxread.c (dbx_objfile_data_key): Change type.
2082         (dbx_symfile_init): Update.
2083         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2084         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2085         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2086
2087 2019-07-10  Tom Tromey  <tromey@adacore.com>
2088
2089         * jit.c (jit_program_space_key): Change type.  Move lower.
2090         (get_jit_program_space_data): Update.
2091         (jit_program_space_data_cleanup): Remove.
2092         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2093         Update.
2094         (struct jit_program_space_data): Add initializers.
2095
2096 2019-07-10  Tom Tromey  <tromey@adacore.com>
2097
2098         * solib-darwin.c (struct darwin_info): Add initializers.
2099         (solib_darwin_pspace_data): Change type.
2100         (darwin_pspace_data_cleanup): Remove.
2101         (get_darwin_info, _initialize_darwin_solib): Update.
2102
2103 2019-07-10  Tom Tromey  <tromey@adacore.com>
2104
2105         * remote-sim.c (struct sim_inferior_data): Add initializers,
2106         constructor, and destructor.
2107         (sim_inferior_data_key): Change type.  Move lower.
2108         (check_for_duplicate_sim_descriptor): Update.
2109         (get_sim_inferior_data): Use new.  Update.
2110         (~sim_inferior_data_cleanup): Rename from
2111         sim_inferior_data_cleanup.  Simplify.
2112         (gdbsim_close_inferior, simulator_command)
2113         (sim_command_completer, _initialize_remote_sim): Update.
2114         (next_pid, INITIAL_PID): Move earlier.
2115
2116 2019-07-10  Tom Tromey  <tromey@adacore.com>
2117
2118         * python/python-internal.h (create_thread_object): Return
2119         gdbpy_ref.
2120         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2121         * python/py-inferior.c (struct threadlist_entry): Add
2122         constructor.
2123         <thread_obj>: Now a gdbpy_ref.
2124         (thread_to_thread_object): Update.
2125         (add_thread_object): Use new.
2126         (delete_thread_object): Use delete.
2127         (infpy_threads): Update.
2128         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2129         GIL.
2130
2131 2019-07-10  Tom Tromey  <tromey@adacore.com>
2132
2133         * valops.c (value_cast): Specialize error message for Ada.
2134
2135 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2136
2137         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2138
2139 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2140
2141         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2142         bpstat_should_step): Return bool, adjust comments.
2143         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2144         bpstat_should_step): Likewise.
2145
2146 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2147
2148         * features/Makefile: Use feature target descriptions for Arm.
2149         * features/arm/arm-core.c: Generate new file.
2150         * features/arm/arm-fpa.c: Likewise.
2151         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2152         * features/arm/arm-m-profile.c: Likewise.
2153         * features/arm/arm-vfpv2.c: Likewise.
2154         * features/arm/arm-vfpv3.c: Likewise.
2155         * features/arm/xscale-iwmmxt.c: Likewise.
2156         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2157
2158 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2159
2160         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2161         ptrace earlier.
2162
2163 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2164
2165         * features/aarch64-pauth.c: Regenerate.
2166
2167 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2168
2169         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2170         bool.
2171         (bpstat_what): Use false instead of 0.
2172
2173 2019-07-09  Pedro Alves  <palves@redhat.com>
2174
2175         * break-catch-throw.c (is_exception_catchpoint): New.
2176         * breakpoint.c (print_one_breakpoint_location): New parameter
2177         'raw_loc'.  Handle it.  Use
2178         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2179         looking at the breakpoint's type.
2180         (print_one_breakpoint): If handling "maint info breakpoints", also
2181         print locations of exception catchpoints.
2182         * breakpoint.h (is_exception_catchpoint): Declare.
2183
2184 2019-07-09  Pedro Alves  <palves@redhat.com>
2185
2186         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2187         "addr" field.
2188         (allocate_location_exception_catchpoint): New.
2189         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2190         (initialize_throw_catchpoint_ops): Install
2191         allocate_location_exception_catchpoint as allocate_location
2192         method.
2193         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2194         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2195         bp_loc_other.
2196         (breakpoint_address_is_meaningful): Delete.
2197         (bl_address_is_meaningful): New.
2198         (breakpoint_locations_match): Adjust comment.
2199         (bp_location_from_bp_type): New, factored out of...
2200         (bp_location::bp_location(breakpoint *)): ... this.
2201         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2202         factored out of...
2203         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2204         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2205         breakpoint_address_is_meaningful.
2206         (bp_locations_compare): Adjust comment.
2207         (update_global_location_list): Use bl_address_is_meaningful
2208         instead of breakpoint_address_is_meaningful.
2209         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2210         explicit.
2211         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2212         * python/py-breakpoint.c (bppy_get_location): No longer check
2213         whether location is null.
2214
2215 2019-07-09  Pedro Alves  <palves@redhat.com>
2216
2217         PR c++/15468
2218         * breakpoint.c (print_one_breakpoint_location): Remove
2219         single-location assert.
2220
2221 2019-07-09  Tom Tromey  <tom@tromey.com>
2222
2223         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2224         * configure: Rebuild.
2225         * configure.ac: Change common to gdbsupport.
2226         * gdbsupport: Rename from common.
2227         * acinclude.m4: Change common to gdbsupport.
2228         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2229         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2230         gdbsupport.
2231         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2232         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2233         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2234         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2235         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2236         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2237         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2238         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2239         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2240         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2241         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2242         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2243         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2244         coff-pe-read.c, command.h, compile/compile-c-support.c,
2245         compile/compile-c.h, compile/compile-cplus-symbols.c,
2246         compile/compile-cplus-types.c, compile/compile-cplus.h,
2247         compile/compile-loc2c.c, compile/compile.c, completer.c,
2248         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2249         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2250         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2251         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2252         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2253         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2254         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2255         features/aarch64-core.c, features/aarch64-fpu.c,
2256         features/aarch64-pauth.c, features/aarch64-sve.c,
2257         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2258         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2259         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2260         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2261         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2262         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2263         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2264         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2265         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2266         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2267         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2268         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2269         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2270         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2271         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2272         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2273         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2274         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2275         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2276         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2277         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2278         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2279         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2280         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2281         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2282         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2283         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2284         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2285         minsyms.c, mips-linux-tdep.c, namespace.h,
2286         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2287         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2288         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2289         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2290         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2291         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2292         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2293         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2294         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2295         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2296         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2297         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2298         procfs.c, producer.c, progspace.h, psymtab.h,
2299         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2300         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2301         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2302         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2303         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2304         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2305         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2306         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2307         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2308         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2309         target-memory.c, target.c, target.h, target/waitstatus.c,
2310         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2311         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2312         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2313         unittests/array-view-selftests.c,
2314         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2315         unittests/common-utils-selftests.c,
2316         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2317         unittests/format_pieces-selftests.c,
2318         unittests/function-view-selftests.c,
2319         unittests/lookup_name_info-selftests.c,
2320         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2321         unittests/mkdir-recursive-selftests.c,
2322         unittests/observable-selftests.c,
2323         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2324         unittests/parse-connection-spec-selftests.c,
2325         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2326         unittests/scoped_fd-selftests.c,
2327         unittests/scoped_mmap-selftests.c,
2328         unittests/scoped_restore-selftests.c,
2329         unittests/string_view-selftests.c, unittests/style-selftests.c,
2330         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2331         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2332         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2333         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2334         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2335         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2336
2337 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2340         bool value.
2341         (decode_digits_ordinary): Set explicit_line field in sal.
2342         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2343         symtab_and_line that was set on an explicit line number in
2344         assembler code.  Do always update the recorded symtab and line if
2345         we do skip the prologue.
2346
2347 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * breakpoint.c (set_breakpoint_location_function): Remove
2350         explicit_loc parameter.
2351         (momentary_breakpoint_from_master): Update call to
2352         set_breakpoint_location_function.
2353         (add_location_to_breakpoint): Likewise.
2354
2355 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2356
2357         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2358         required features based on default bfd type when no specific bfd
2359         is present.
2360
2361 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2362
2363         * NEWS: Mention that GDB printf and eval commands can now print
2364         C-style and Ada-style convenience var strings without
2365         calling the inferior.
2366         * printcmd.c (printf_c_string): Locally print GDB internal var
2367         instead of transiting via the inferior.
2368         (printf_wide_c_string): Likewise.
2369
2370 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2371
2372         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2373
2374 2019-07-04  Tom Tromey  <tom@tromey.com>
2375
2376         PR tui/24724:
2377         * tui/tui-winsource.c (tui_clear_source_content): Update.
2378         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2379         (tui_update_breakpoint_info): Update.
2380         (tui_set_exec_info_content): Update.
2381         * tui/tui-source.c (tui_set_source_content_nil): Update.
2382         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2383         has_break.
2384         * tui/tui-data.h (enum tui_bp_flag): New.
2385         (tui_bp_flags): New enum flags type.
2386         (struct tui_source_element) <break_mode>: Change type.  Rename
2387         from has_break.
2388         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2389         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2390         constants.
2391         * tui/tui-winsource.h: Fix comment.
2392
2393 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2394
2395         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2396         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2397         (store_fpregs_to_thread)
2398         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2399         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2400         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2401         (IWMMXT_REGS_SIZE): Add define.
2402         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2403         (fetch_vfp_regs, store_vfp_regs)
2404         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2405         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2406
2407 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2408
2409         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2410         defines.
2411         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2412         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2413         (ARM_INT_REGISTER_SIZE): ...to this.
2414         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2415         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2416         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2417         (arm_linux_collect_gregset, supply_nwfpe_register)
2418         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2419         defines.
2420         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2421         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2422         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2423         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2424         (arm_return_in_memory, arm_store_return_value)
2425         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2426         (arm_record_ld_st_multiple): Likewise.
2427         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2428         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2429
2430 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2431
2432         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2433         AARCH64_DISPLACED_MODIFIED_INSNS.
2434         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2435         (aarch64_displaced_step_copy_insn): Likewise.
2436         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2437         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2438         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2439         ARM_DISPLACED_MODIFIED_INSNS.
2440         * arm-tdep.c (arm_gdbarch_init): Likewise.
2441         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2442         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2443         (struct arm_displaced_step_closure): Use
2444         ARM_DISPLACED_MODIFIED_INSNS.
2445
2446 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2447
2448         * features/Makefile: Remove unused xml files.
2449         * features/aarch64.xml: Remove.
2450         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2451         * features/i386/amd64-avx-avx512.xml: Remove.
2452         * features/i386/amd64-avx-linux.xml: Remove.
2453         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2454         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2455         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2456         * features/i386/amd64-avx-mpx.xml: Remove.
2457         * features/i386/amd64-avx.xml: Remove.
2458         * features/i386/amd64-linux.xml: Remove.
2459         * features/i386/amd64-mpx-linux.xml: Remove.
2460         * features/i386/amd64-mpx.xml: Remove.
2461         * features/i386/amd64.xml: Remove.
2462         * features/i386/i386-avx-avx512-linux.xml: Remove.
2463         * features/i386/i386-avx-avx512.xml: Remove.
2464         * features/i386/i386-avx-linux.xml: Remove.
2465         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2466         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2467         * features/i386/i386-avx-mpx-linux.xml: Remove.
2468         * features/i386/i386-avx-mpx.xml: Remove.
2469         * features/i386/i386-avx.xml: Remove.
2470         * features/i386/i386-linux.xml: Remove.
2471         * features/i386/i386-mmx-linux.xml: Remove.
2472         * features/i386/i386-mmx.xml: Remove.
2473         * features/i386/i386-mpx-linux.xml: Remove.
2474         * features/i386/i386-mpx.xml: Remove.
2475         * features/i386/i386.xml: Remove.
2476         * features/i386/x32-avx-avx512-linux.xml: Remove.
2477         * features/i386/x32-avx-linux.xml: Remove.
2478         * features/i386/x32-linux.xml: Remove.
2479
2480 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2481
2482         * regformats/aarch64.dat: Remove.
2483         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2484         * regformats/i386/amd64-avx-linux.dat: Remove.
2485         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2486         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2487         * regformats/i386/amd64-linux.dat: Remove.
2488         * regformats/i386/amd64-mpx-linux.dat: Remove.
2489         * regformats/i386/amd64.dat: Remove.
2490         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2491         * regformats/i386/i386-avx-linux.dat: Remove.
2492         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2493         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2494         * regformats/i386/i386-linux.dat: Remove.
2495         * regformats/i386/i386-mmx-linux.dat: Remove.
2496         * regformats/i386/i386-mpx-linux.dat: Remove.
2497         * regformats/i386/i386.dat: Remove.
2498         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2499         * regformats/i386/x32-avx-linux.dat: Remove.
2500         * regformats/i386/x32-linux.dat: Remove.
2501
2502 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2503
2504         * aarch64-tdep.c: Remove xml self tests.
2505         * amd64-linux-tdep.c: Likewise.
2506         * amd64-tdep.c: Likewise.
2507         * i386-linux-tdep.c: Likewise.
2508         * i386-tdep.c: Likewise.
2509
2510 2019-07-03  Pedro Alves  <palves@redhat.com>
2511
2512         PR cli/24732
2513         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2514         (pipe_cmd_option_defs): New.
2515         (make_pipe_cmd_options_def_group): New.
2516         (pipe_command): Use gdb::option::process_options.
2517         (pipe_command_completer): New function.
2518         (_initialize_cli_cmds): Install completer for "pipe" command.
2519
2520 2019-07-03  Pedro Alves  <palves@redhat.com>
2521
2522         * cli/cli-option.c (union option_value) <string>: New field.
2523         (struct option_def_and_value): Add ctor, move ctor, dtor and
2524         use DISABLE_COPY_AND_ASSIGN.
2525         (option_def_and_value::clear_value): New.
2526         (parse_option, save_option_value_in_ctx, get_val_type_str)
2527         (add_setshow_cmds_for_options): Handle var_string.
2528         * cli-option.h (union option_def::var_address) <string>: New
2529         field.
2530         (struct string_option_def): New.
2531         * maint-test-options.c (struct test_options_opts): Add default
2532         ctor and use DISABLE_COPY_AND_ASSIGN.
2533         <string_opt>: New field.
2534         (test_options_opts::~test_options_opts): New.
2535         (test_options_opts::dump): Also dump "-string".
2536         (test_options_option_defs): Install "string.
2537
2538 2019-07-03  Pedro Alves  <palves@redhat.com>
2539
2540         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2541         option_value with a null enumeration.
2542         (complete_options): Save the option values in the context.
2543         (save_option_value_in_ctx): New, factored out from ...
2544         (process_options): ... here.
2545         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2546         of the function.
2547         * maint-test-options.c (test_options_opts::dump): New, factored
2548         out from ...
2549         (maintenance_test_options_command_mode): ... here.
2550         (maintenance_test_options_command_completion_result): Delete.
2551         (maintenance_test_options_command_completion_text): Update
2552         comment.
2553         (maintenance_show_test_options_completion_result): Change
2554         prototype.  Just print
2555         maintenance_test_options_command_completion_text.
2556         (save_completion_result): New.
2557         (maintenance_test_options_completer_mode): Pass options context to
2558         complete_options, and then save a dump.
2559         (_initialize_maint_test_options): Use add_cmd to install "maint
2560         show test-options-completion-result".
2561
2562 2019-07-03  Pedro Alves  <palves@redhat.com>
2563
2564         * NEWS (New commands): Mention "with" and "maint with".
2565         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2566         (with_command, with_command_completer): New.
2567         (pipe_command): Adjust to new repeat_previous
2568         interface.
2569         (_initialize_cli_cmds): Install the "with" command and its "w"
2570         alias.
2571         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2572         declarations.
2573         * cli/cli-setshow.c (parse_cli_var_uinteger)
2574         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2575         argument strings for all var_types.
2576         (get_setshow_command_value_string): New, factored out from ...
2577         (do_show_command): ... this.
2578         * cli/cli-setshow.h: Include <string>.
2579         (get_setshow_command_value_string): Declare.
2580         * command.h (repeat_previous): Now returns const char *.  Adjust
2581         comment.
2582         * maint.c: Include "cli/cli-cmds.h".
2583         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2584         (_initialize_maint_cmds): Register the "maintenance with" command.
2585         * top.c (repeat_previous): Move bits from pipe_command here:
2586         Return the saved command line, if any; error out if there's no
2587         command to relaunch.
2588
2589 2019-07-03  Pedro Alves  <palves@redhat.com>
2590
2591         * NEWS (New commands): Mention "maint set/show test-settings"
2592         instead of "maint test-settings".
2593         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2594         (maintenance_test_settings_set_list): Rename to ...
2595         (maintenance_set_test_settings_list): ... this.
2596         (maintenance_test_settings_show_list): Rename to  ...
2597         (maintenance_show_test_settings_list): ... this.
2598         (maintenance_test_settings_cmd): Delete.
2599         (maintenance_test_settings_set_cmd): ...
2600         (maintenance_set_test_settings_cmd): ... this.
2601         (maintenance_test_settings_show_cmd): ...
2602         (maintenance_show_test_settings_cmd): ... this.
2603         (maintenance_test_settings_show_value_cmd):
2604         (maintenance_show_test_settings_value_cmd): ... this.
2605         (_initialize_maint_test_settings): No longer install the "maint
2606         test-settings" prefix command.  Rename "maint test-settings set"
2607         to "maint set test-settings", and "maint test-settings show" to
2608         "maint show test-settings".  Adjust all subcommands.
2609
2610 2019-07-03  Pedro Alves  <palves@redhat.com>
2611
2612         * maint-test-settings.c: Fix file's intro comment.  Replace all
2613         references to "test-options" with references to "test-settings",
2614         in comments.
2615
2616 2019-07-03  Pedro Alves  <palves@redhat.com>
2617
2618         * maint-test-settings.c (maintenance_test_settings_xxx)
2619         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2620         New.
2621         (maintenance_test_settings_enums): Use them.
2622         (maintenance_test_settings_enum): Default to
2623         maintenance_test_settings_xxx.
2624         (_initialize_maint_test_settings): Initialize
2625         MAINTENANCE_TEST_SETTINGS_FILENAME.
2626
2627 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2628
2629         * breakpoint.h (remove_breakpoints_inf): Change return type to
2630         void, move function documentation here.
2631         * breakpoint.c (remove_breakpoints_inf): Change return type to
2632         void, move function documentation to header.
2633
2634 2019-07-02  Pedro Alves  <palves@redhat.com>
2635
2636         * NEWS (Completion improvements): Mention "info threads".
2637         * thread.c (struct info_threads_opts, info_threads_option_defs)
2638         (make_info_threads_options_def_group): New.
2639         (info_threads_command): Use gdb::option::process_options.
2640         (info_threads_command_completer): New.
2641         (_initialize_thread): Use gdb::option::build_help to build the
2642         help text for "info threads".
2643
2644 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2645
2646         * defs.h (generic_load): Move from here...
2647         * symfile.h (generic_load): ... to here.  Rename name parameter
2648         to args.
2649         * symfile.c (generic_load): Add comment.
2650
2651 2019-07-01  Tom Tromey  <tromey@adacore.com>
2652
2653         * dwarf2read.c
2654         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2655         declaration of without_params.  Fix formatting.
2656
2657 2019-07-01  Tom Tromey  <tromey@adacore.com>
2658
2659         * ada-exp.y (find_primitive_type): Update.
2660         * ada-lang.h (ada_lookup_symbol): Update.
2661         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2662         parameter.
2663         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2664
2665 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2666
2667         PR breakpoints/24541
2668         * gdbarch.c: Regenerate.
2669         * gdbarch.h: Regenerate.
2670         * gdbarch.sh: Add 'stap_adjust_register'.
2671         * i386-tdep.c: Include '<unordered_set>'.
2672         (i386_stap_adjust_register): New function.
2673         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2674         * stap-probe.c (stap_parse_register_operand): Call
2675         'gdbarch_stap_adjust_register'.
2676
2677 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2678
2679         PR python/24742
2680         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2681         * python/python.c (do_start_initialization): Use 'xmalloc'
2682         instead of 'PyMem_Malloc'.
2683
2684 2019-06-28  Tom Tromey  <tromey@adacore.com>
2685
2686         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2687         for Ada.
2688
2689 2019-06-27  Tom Tromey  <tromey@adacore.com>
2690
2691         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2692         objfile_key.
2693         (arm_find_mapping_symbol, arm_record_special_symbol)
2694         (_initialize_arm_tdep): Update.
2695         (arm_objfile_data_free): Remove.
2696
2697 2019-06-27  Tom Tromey  <tromey@adacore.com>
2698
2699         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2700         to cp_print_static_field.
2701
2702 2019-06-26  Tom Tromey  <tromey@adacore.com>
2703
2704         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2705         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2706         declare.
2707
2708 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2709
2710         * features/aarch64-core.c (create_feature_aarch64_core):
2711         Regenerate.
2712         * features/aarch64-core.xml: Add cpsr flags.
2713
2714 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2715
2716         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2717         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2718
2719 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2720
2721         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2722         field.
2723         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2724         use.
2725         (arm_record_special_symbol): Don't insert new symbol in sorted
2726         position, push it at the end.
2727
2728 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2729
2730         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2731         (arm_mapping_symbol_s): Remove.
2732         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2733         (arm_mapping_symbol_vec): New typedef.
2734         (struct arm_per_objfile): Add constructor.
2735         <section_maps>: Change type to
2736         std::unique_ptr<arm_mapping_symbol_vec[]>.
2737         (arm_compare_mapping_symbols): Remove.
2738         (arm_find_mapping_symbol): Adjust to section_maps type change.
2739         (arm_objfile_data_free): Call delete on arm_per_objfile.
2740         (arm_record_special_symbol): Adjust to section_maps type change.
2741         Allocate arm_per_objfile with new.
2742
2743 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2744
2745         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2746         with the command prefix.
2747
2748 2019-06-25  Tom Tromey  <tom@tromey.com>
2749
2750         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2751         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2752
2753 2019-06-25  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2756         type.
2757         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2758         protected.
2759
2760 2019-06-25  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-winsource.c
2763         (tui_source_window_base::set_is_exec_point_at): Add check against
2764         LOA_ADDRESS.
2765
2766 2019-06-25  Tom Tromey  <tom@tromey.com>
2767
2768         * tui/tui-source.c (tui_set_source_content): Don't check before
2769         xfree.
2770         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2771
2772 2019-06-25  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-winsource.h (tui_update_source_window_as_is)
2775         (tui_alloc_source_buffer, tui_line_is_displayed)
2776         (tui_addr_is_displayed): Change type of win_info.
2777         * tui/tui-winsource.c (tui_update_source_window_as_is)
2778         (tui_clear_source_content, tui_show_source_line)
2779         (tui_show_source_content, tui_source_window_base::refill)
2780         (tui_source_window_base::set_is_exec_point_at)
2781         (tui_source_window_base::set_is_exec_point_at)
2782         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2783         (tui_alloc_source_buffer, tui_line_is_displayed)
2784         (tui_addr_is_displayed): Change type of win_info.  Update.
2785         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2786         (tui_source_window_base::do_make_visible_with_new_height):
2787         Update.
2788         * tui/tui-source.c (tui_set_source_content)
2789         (tui_set_source_content_nil)
2790         (tui_source_window::do_scroll_vertical): Update.
2791         * tui/tui-layout.c (show_layout): Update.
2792         * tui/tui-disasm.c (tui_set_disassem_content)
2793         (tui_disasm_window::do_scroll_vertical): Update.
2794         * tui/tui-data.h (tui_win_content): Remove.
2795         (struct tui_gen_win_info) <content, content_size>: Remove.
2796         (struct tui_source_element): Add initializers and destructor.
2797         (union tui_which_element, struct tui_win_element): Remove.
2798         (struct tui_source_window_base) <content>: New field.
2799         (struct tui_data_window): Remove destructor.
2800         (tui_alloc_content, tui_free_win_content)
2801         (tui_free_all_source_wins_content): Don't declare.
2802         * tui/tui-data.c (tui_initialize_static_data): Update.
2803         (init_content_element, tui_alloc_content): Remove.
2804         (~tui_gen_win_info): Update.
2805         (~tui_data_window, tui_free_all_source_wins_content)
2806         (tui_free_win_content, free_content, free_content_elements):
2807         Remove.
2808
2809 2019-06-25  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-winsource.h (tui_clear_source_content)
2812         (tui_erase_source_content, tui_show_source_content): Change type
2813         of win_info.
2814         * tui/tui-winsource.c (tui_clear_source_content)
2815         (tui_erase_source_content, tui_show_source_content): Change type
2816         of win_info.
2817         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2818         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2819         win_info.
2820         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2821         win_info.
2822         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2823
2824 2019-06-25  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-winsource.c (tui_clear_source_content)
2827         (tui_source_window_base::set_is_exec_point_at): Update.
2828         * tui/tui-source.c (tui_set_source_content_nil): Update.
2829         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2830         a bool.
2831         * tui/tui-data.c (init_content_element): Update.
2832
2833 2019-06-25  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2836         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2837         * tui/tui-layout.c (init_and_make_win): Update.
2838         * tui/tui.h (enum tui_win_type): Update.
2839         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2840         tui_win_is_auxillary.
2841         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2842         tui_win_is_auxillary.
2843
2844 2019-06-25  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2847         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2848         (tui_delete_data_content_windows, tui_display_all_data)
2849         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2850         Update.
2851         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2852         * tui/tui-regs.c (tui_last_regs_line_no)
2853         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2854         (tui_show_registers): Update.
2855         (tui_show_register_group): Return void.  Update.
2856         (tui_display_registers_from, tui_display_reg_element_at_line)
2857         (tui_display_registers_from_line, tui_check_register_values):
2858         Update.
2859         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2860         member.
2861         (struct tui_data_window) <regs_content>: Now a std::vector.
2862         <regs_content_count>: Remove.
2863         (tui_add_content_elements, tui_free_data_content): Don't declare.
2864         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2865         (init_content_element): Remove DATA_WIN case.  Add assert.
2866         (tui_add_content_elements): Remove.
2867         (tui_data_window): Update.
2868         (tui_free_data_content): Remove.
2869         (free_content_elements): Remove DATA_WIN case.
2870
2871 2019-06-25  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-data.c (tui_data_item_window): Update.
2874         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2875         * tui/tui-windata.c (tui_display_all_data)
2876         (tui_display_data_from_line): Update.
2877         (tui_check_data_values): Remove.
2878         * tui/tui-regs.c (tui_show_register_group)
2879         (tui_display_reg_element_at_line): Update.
2880         * tui/tui-hooks.c (tui_register_changed)
2881         (tui_refresh_frame_and_register_information): Call
2882         tui_check_register_values.
2883         * tui/tui-data.h (struct tui_data_window) <data_content,
2884         data_content_count, data_type>: Remove.
2885         (enum tui_data_type): Remove.
2886
2887         * tui/tui-data.c (tui_data_window::clear_detail)
2888         (~tui_data_window): Update.
2889
2890 2019-06-25  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2893         declare.
2894         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2895         Rename from tui_first_data_item_displayed.  Update.
2896         (tui_data_window::refresh_all)
2897         (tui_data_window::do_scroll_vertical): Update.
2898         * tui/tui-data.h (struct tui_data_window)
2899         <first_data_item_displayed>: Declare new method.
2900
2901 2019-06-25  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2904         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2905         contents...
2906         (tui_initialize_static_data): ...here.
2907
2908 2019-06-25  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2911         (tui_display_registers_from, tui_check_register_values): Update.
2912         (tui_display_register): Remove win_info parameter; update.
2913         (tui_get_register): Change type of parameters.
2914         * tui/tui-data.h (struct tui_data_element): Remove.
2915         (union tui_which_element) <data>: Remove.
2916         <data_window>: Change type.
2917         (struct tui_data_item_window): New.
2918         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2919         case.  Add assert.
2920         (~tui_data_item_window): New destructor.
2921         (free_content_elements): Remove DATA_ITEM_WIN case.
2922
2923 2019-06-25  Tom Tromey  <tom@tromey.com>
2924
2925         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2926         Remove.
2927
2928 2019-06-25  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-data.h (struct tui_command_element): Remove.
2931         (union tui_which_element) <command>: Remove.
2932         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2933         assert.
2934         (free_content_elements): Remove CMD_WIN case.
2935
2936 2019-06-25  Tom Tromey  <tom@tromey.com>
2937
2938         * tui/tui-layout.c (tui_set_layout): Update.
2939         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2940         * tui/tui-data.c (layout_def): Update.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2945         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2946         (tui_source_window_base::set_new_height): Update.
2947         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2948         Update.
2949         (tui_set_locator_fullname, tui_set_locator_info)
2950         (tui_show_frame_info): Update.
2951         * tui/tui-source.c (tui_set_source_content)
2952         (tui_source_is_displayed): Update.
2953         * tui/tui-layout.c (show_source_disasm_command, show_data)
2954         (show_source_or_disasm_and_command): Update.
2955         * tui/tui-disasm.c (tui_set_disassem_content)
2956         (tui_get_begin_asm_address): Update.
2957         * tui/tui-data.h (struct tui_locator_element): Remove.
2958         (union tui_which_element) <locator>: Remove.
2959         (struct tui_locator_window): New.
2960         (tui_locator_win_info_ptr): Change return type.
2961         * tui/tui-data.c (_locator): Change type.
2962         (tui_locator_win_info_ptr): Change return type.
2963         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2964         (tui_alloc_content): Add assert.
2965
2966 2019-06-25  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-winsource.c
2969         (tui_exec_info_window::maybe_allocate_content): New method.
2970         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2971         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2972         (make_source_or_disasm_window): Add cast.
2973         * tui/tui-data.h (union tui_which_element) <simple_string>:
2974         Remove.
2975         (struct tui_source_info): New.
2976         (struct tui_source_window_base) <execution_info>: Change type.
2977         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2978         case, and add assert.
2979         (tui_alloc_content): Add assert.
2980
2981 2019-06-25  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2984         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2985         * tui/tui-data.c (tui_alloc_win_info): Remove.
2986
2987 2019-06-25  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2990         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2991         can_highlight.
2992
2993 2019-06-25  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2996         make_visible_with_new_height method.
2997         (tui_win_info::make_visible_with_new_height): New method.
2998         (tui_source_window_base::do_make_visible_with_new_height)
2999         (tui_data_window::do_make_visible_with_new_height)
3000         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3001         (make_visible_with_new_height): Remove.
3002         (tui_resize_all, tui_adjust_win_heights): Use
3003         make_visible_with_new_height method.
3004         * tui/tui-data.h (struct tui_win_info)
3005         <do_make_visible_with_new_height, make_visible_with_new_height>:
3006         New methods.
3007         (struct tui_source_window_base, struct tui_data_window)
3008         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3009         methods.
3010
3011 2019-06-25  Tom Tromey  <tom@tromey.com>
3012
3013         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3014         method.
3015         (update_tab_width): Call update_tab_width method.
3016         * tui/tui-data.h (struct tui_win_info)
3017         (struct tui_source_window_base) <update_tab_width>: New methods.
3018
3019 2019-06-25  Tom Tromey  <tom@tromey.com>
3020
3021         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3022         parameter.
3023         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3024         parameter.
3025         (tui_gen_win_info::make_visible): Update.
3026         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3027         parameter.
3028         * tui/tui-data.h (enum tui_box): New enum.
3029         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3030
3031 2019-06-25  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3034         init_and_make_win for EXEC_INFO_WIN.
3035         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3036         longer inline.
3037         (struct tui_win_info) <~tui_win_info>: Inline.
3038         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3039         Don't declare.
3040         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3041         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3042         Remove.
3043         (tui_initialize_static_data): Update.
3044         (~tui_gen_win_info): Handle more cleanup here.
3045         (~tui_source_window_base): Delete "execution_info".
3046         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3047
3048 2019-06-25  Tom Tromey  <tom@tromey.com>
3049
3050         * tui/tui-layout.c (make_command_window): Don't set
3051         can_highlight.
3052         (show_source_disasm_command): Call the reset method.
3053         (show_data): Don't set can_highlight.  Call the reset method.
3054         (tui_gen_win_info::reset): Rename from init_gen_win_info
3055         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3056         (show_source_or_disasm_and_command): Call the reset method.
3057         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3058         (struct tui_cmd_window): Set can_highlight.
3059
3060 2019-06-25  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3063         from make_visible.
3064         (tui_make_visible, tui_make_invisible): Rewrite.
3065         (tui_win_info::make_visible): Remove.
3066         (tui_source_window_base::make_visible): Update.
3067         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3068         method.  Moved from...
3069         (struct tui_win_info) <make_visible>: ...here.
3070
3071 2019-06-25  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-winsource.c
3074         (tui_source_window_base::do_scroll_horizontal): Remove direction
3075         parameter.
3076         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3077         direction parameter.
3078         * tui/tui-win.c (tui_win_info::forward_scroll)
3079         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3080         (tui_win_info::right_scroll): Update.
3081         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3082         direction parameter.
3083         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3084         direction parameter.
3085         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3086         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3087         Remove direction parameter.
3088         (struct tui_source_window_base, struct tui_source_window)
3089         (struct tui_disasm_window, struct tui_data_window)
3090         (struct tui_cmd_window): Update.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-winsource.h (tui_set_exec_info_content)
3095         (tui_show_exec_info_content, tui_erase_exec_info_content)
3096         (tui_clear_exec_info_content, tui_update_exec_info): Change
3097         argument to tui_source_window_base.
3098         * tui/tui-winsource.c (tui_set_exec_info_content)
3099         (tui_show_exec_info_content, tui_erase_exec_info_content)
3100         (tui_clear_exec_info_content, tui_update_exec_info): Change
3101         argument to tui_source_window_base.
3102
3103 2019-06-25  Tom Tromey  <tom@tromey.com>
3104
3105         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3106         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3107
3108 2019-06-25  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3111         check.
3112
3113 2019-06-25  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3116         type to void.
3117         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3118         type to void.
3119         * tui/tui-source.c (tui_set_source_content): Update.
3120         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3121
3122 2019-06-25  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-win.c (window_name_completer, tui_set_focus)
3125         (tui_all_windows_info): Use name method.
3126         * tui/tui-data.h (struct tui_gen_win_info)
3127         (struct tui_source_window, struct tui_disasm_window)
3128         (struct tui_data_window, struct tui_cmd_window) <name>: New
3129         method.
3130         (tui_win_name): Don't declare.
3131         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3132         (tui_win_name): Remove.
3133
3134 2019-06-25  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-winsource.h (tui_update_source_window)
3137         (tui_update_source_window_as_is): Change parameter type.
3138         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3139         to be a tui_source_window_base.
3140         (tui_update_source_window_as_is): Likewise.
3141         * tui/tui-win.c (make_visible_with_new_height): Update.
3142
3143 2019-06-25  Tom Tromey  <tom@tromey.com>
3144
3145         * tui/tui-winsource.c (tui_erase_source_content)
3146         (tui_show_source_content, tui_show_exec_info_content)
3147         (tui_erase_exec_info_content): Use refresh_window method.
3148         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3149         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3150         from tui_refresh_win.
3151         (tui_data_window::refresh_window): New method.
3152         (tui_win_info::refresh, tui_source_window_base::refresh)
3153         (tui_refresh_all): Use refresh_window method.
3154         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3155         method.
3156         * tui/tui-regs.c (tui_display_register): Call refresh_window
3157         method.
3158         * tui/tui-layout.c (show_source_disasm_command)
3159         (show_source_or_disasm_and_command): Call refresh_window method.
3160         * tui/tui-data.h (struct tui_gen_win_info)
3161         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3162         New method.
3163
3164 2019-06-25  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui.c (tui_rl_other_window, tui_enable)
3167         (tui_is_window_visible, tui_get_command_dimension): Update.
3168         * tui/tui-winsource.c (tui_update_source_window_as_is)
3169         (tui_clear_source_content, tui_erase_source_content)
3170         (tui_show_source_line, tui_source_window_base::refill)
3171         (tui_source_window_base::do_scroll_horizontal)
3172         (tui_source_window_base::set_is_exec_point_at)
3173         (tui_update_breakpoint_info, tui_set_exec_info_content)
3174         (tui_alloc_source_buffer, tui_line_is_displayed)
3175         (tui_addr_is_displayed): Update.
3176         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3177         (tui_check_and_display_highlight_if_needed)
3178         (tui_win_info::make_visible, tui_win_info::refresh)
3179         (tui_refresh_all): Update.
3180         * tui/tui-windata.c (tui_first_data_item_displayed)
3181         (tui_delete_data_content_windows, tui_erase_data_content)
3182         (tui_display_all_data, tui_data_window::refresh_all)
3183         (tui_check_data_values): Update.
3184         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3185         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3186         (tui_win_info::backward_scroll, tui_refresh_all_win)
3187         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3188         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3189         (tui_source_window_base::set_new_height)
3190         (tui_data_window::set_new_height)
3191         (make_invisible_and_set_new_height)
3192         (make_visible_with_new_height, new_height_ok)
3193         (parse_scrolling_args): Update.
3194         * tui/tui-stack.c (tui_show_frame_info): Update.
3195         * tui/tui-source.c (tui_set_source_content)
3196         (tui_set_source_content_nil, tui_source_is_displayed)
3197         (tui_source_window::do_scroll_vertical): Update.
3198         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3199         (tui_display_registers_from, tui_display_reg_element_at_line)
3200         (tui_check_register_values, tui_reg_command): Update.
3201         * tui/tui-layout.c (tui_default_win_height)
3202         (show_source_disasm_command, show_data, init_and_make_win)
3203         (show_source_or_disasm_and_command): Update.
3204         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3205         (tui_redisplay_readline, tui_mld_flush)
3206         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3207         (tui_getc): Update.
3208         * tui/tui-disasm.c (tui_set_disassem_content)
3209         (tui_disasm_window::do_scroll_vertical): Update.
3210         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3211         Now virtual.
3212         (struct tui_win_info): Derive from tui_gen_win_info.
3213         <~tui_win_info>: Mark as override.
3214         <generic>: Remove member.
3215         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3216         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3217         (~tui_data_window, ~tui_win_info)
3218         (tui_free_all_source_wins_content): Update.
3219         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-layout.c (init_and_make_win): Use new.
3224         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3225         destructor, initializers.
3226         (tui_alloc_generic_win_info): Don't declare.
3227         * tui/tui-data.c (_locator): Add argument to constructor.
3228         (source_win, disasm_win): New globals.
3229         (exec_info): Remove.
3230         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3231         Update.
3232         (tui_alloc_generic_win_info): Remove.
3233         (init_content_element): Use new.
3234         (tui_win_info::tui_win_info): Update.
3235         (free_content_elements) <case DATA_WIN>: Use delete.
3236
3237 2019-06-25  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3240         * tui/tui-windata.c (tui_first_data_item_displayed)
3241         (tui_delete_data_content_windows): Update.
3242         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3243         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3244         (tui_display_registers_from, tui_check_register_values): Update.
3245         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3246         pointer.
3247         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3248         window.
3249         (tui_free_data_content): Update.
3250         (free_content_elements) <case DATA_WIN>: Free the window.
3251
3252 2019-06-25  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3255         Update.
3256         * tui/tui-layout.c (make_command_window)
3257         (show_source_disasm_command, show_data, init_and_make_win)
3258         (show_source_or_disasm_and_command): Update.
3259         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3260         method.
3261         <can_highight, is_highlighted>: Now bool.
3262         (tui_set_win_highlight): Don't declare.
3263         * tui/tui-data.c (tui_set_win_highlight): Remove.
3264
3265 2019-06-25  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-wingeneral.c (make_visible): Remove check of window
3268         type.
3269
3270 2019-06-25  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-win.c (tui_win_info::max_height)
3273         (tui_cmd_window::max_height): New methods.
3274         (new_height_ok): Call max_height.
3275         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3276         <max_height>: New method.
3277
3278 2019-06-25  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-win.c (tui_source_window_base::set_new_height)
3281         (tui_data_window::set_new_height): New methods.
3282         (make_invisible_and_set_new_height): Call set_new_height method.
3283         * tui/tui-data.h (struct tui_win_info)
3284         (struct tui_source_window_base, struct tui_data_window)
3285         <set_new_height>: New method.
3286
3287 2019-06-25  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3290         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3291         tui_refresh_data_win.
3292         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3293         method.
3294         (tui_refresh_all_win): Call the refresh_all method.
3295         (tui_set_focus): Likewise.
3296         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3297         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3298         Likewise.
3299
3300 2019-06-25  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-winsource.h (tui_refill_source_window)
3303         (tui_set_is_exec_point_at): Don't declare.
3304         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3305         (tui_source_window_base::refill): Rename from
3306         tui_refill_source_window.
3307         (tui_source_window_base::do_scroll_horizontal): Update.
3308         (tui_source_window_base::set_is_exec_point_at): Rename from
3309         tui_set_is_exec_point_at.
3310         (tui_update_all_breakpoint_info): Update.
3311         * tui/tui-stack.c (tui_show_frame_info): Update.
3312         * tui/tui-layout.c (show_data): Add cast.
3313         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3314         * tui/tui-data.h (struct tui_source_window_base) <refill,
3315         set_is_exec_point_at>: New methods.
3316         (tui_source_windows, tui_add_to_source_windows): Update types.
3317         (tui_add_to_source_windows): Remove redundant declaration.
3318         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3319         (tui_source_windows): Change return type.
3320         (tui_clear_source_windows_detail): Update.
3321         (tui_add_to_source_windows): Change type of parameter.
3322         (tui_free_all_source_wins_content): Update.
3323
3324 2019-06-25  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui-wingeneral.c (tui_win_info::refresh)
3327         (tui_source_window_base::refresh): New methods.
3328         (tui_refresh_all): Call the refresh method.
3329         * tui/tui-data.h (struct tui_win_info)
3330         (struct tui_source_window_base) <refresh>: New method.
3331
3332 2019-06-25  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui.h (tui_is_window_visible): Return bool.
3335         * tui/tui.c (tui_is_window_visible): Return bool.
3336         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3337         (tui_make_visible, tui_make_invisible)
3338         (tui_win_info::make_visible)
3339         (tui_source_window_base::make_visible, make_all_visible)
3340         (tui_make_all_visible, tui_make_all_invisible): Update.
3341         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3342         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3343         bool.
3344         (struct tui_win_info, struct tui_source_window_base)
3345         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3346         * tui/tui-data.c (tui_init_generic_part): Update.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3351         (tui_source_window_base::make_visible): New methods.
3352         (make_all_visible): Make method call.
3353         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3354         (struct tui_source_window_base, struct tui_cmd_window): Override
3355         make_visible.
3356         (tui_win_is_source_type): Don't declare.
3357         * tui/tui-data.c (tui_win_is_source_type): Remove.
3358
3359 2019-06-25  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3362         NULL check.
3363
3364 2019-06-25  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3367         Inline constructor.  Add initializers for members.
3368         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3369         constructors; now inline in class.
3370
3371 2019-06-25  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-regs.c (tui_show_registers): Update.
3374         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3375         bool.
3376         * tui/tui-data.c (tui_data_window::clear_detail)
3377         (tui_data_window): Update.
3378
3379 2019-06-25  Tom Tromey  <tom@tromey.com>
3380
3381         * tui/tui-windata.c (tui_display_all_data)
3382         (tui_display_data_from_line, tui_display_data_from)
3383         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3384         Update.
3385         * tui/tui-regs.c (tui_last_regs_line_no)
3386         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3387         (tui_show_registers, tui_show_register_group)
3388         (tui_display_registers_from, tui_display_reg_element_at_line)
3389         (tui_display_registers_from_line, tui_check_register_values)
3390         (tui_reg_next, tui_reg_prev): Update.
3391         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3392         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3393         tui_data_window.
3394         (struct tui_win_info) <detail>: Remove.  Add new fields from
3395         tui_data_info.
3396         (TUI_DATA_WIN): Add cast.
3397         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3398         (~tui_data_window): Simplify.
3399
3400 2019-06-25  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui-layout.c (show_source_disasm_command)
3403         (show_source_or_disasm_and_command): Update.
3404         * tui/tui-io.c (update_cmdwin_start_line)
3405         (tui_redisplay_readline): Update.
3406         * tui/tui-data.h (struct tui_command_info): Remove.
3407         (struct tui_win_info) <detail>: Remove command_info member.
3408         (struct tui_data_window) <start_line>: New member, from
3409         tui_command_info.
3410         (TUI_CMD_WIN): Add casts.
3411
3412 2019-06-25  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-winsource.c (tui_update_source_window)
3415         (tui_refill_source_window)
3416         (tui_source_window_base::do_scroll_horizontal)
3417         (tui_update_breakpoint_info, tui_set_exec_info_content)
3418         (tui_show_exec_info_content, tui_erase_exec_info_content)
3419         (tui_clear_exec_info_content): Update.
3420         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3421         Update.
3422         * tui/tui-win.c (make_invisible_and_set_new_height)
3423         (make_visible_with_new_height): Update.
3424         * tui/tui-source.c (tui_set_source_content)
3425         (tui_show_symtab_source): Update.
3426         * tui/tui-layout.c (extract_display_start_addr)
3427         (show_source_disasm_command, show_data)
3428         (make_source_or_disasm_window)
3429         (show_source_or_disasm_and_command): Update.
3430         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3431         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3432         "gdbarch".
3433         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3434         to tui_source_window_base.
3435         (struct tui_win_info) <detail>: Remove source_info member.
3436         (struct tui_source_window_base) <has_locator>: Inline.
3437         Move contents from tui_source_info; rename has_locator member to
3438         m_has_locator.
3439         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3440         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3441         header file.
3442         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3443         Simplify.
3444         (tui_free_all_source_wins_content): Cast to
3445         tui_source_window_base.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-win.c (make_invisible_and_set_new_height)
3450         (make_visible_with_new_height): Call has_locator method.
3451         * tui/tui-layout.c (show_source_disasm_command, show_data)
3452         (show_source_or_disasm_and_command): Update for bool change.
3453         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3454         (tui_win_info) <has_locator>: New method.
3455         (struct tui_source_window_base) <has_locator>: New method.
3456         (tui_win_has_locator): Don't declare.
3457         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3458         from tui_win_has_locator.
3459         (tui_source_window_base): Use false, not FALSE.
3460
3461 2019-06-25  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3464         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3465         clear_detail method directly.
3466         (tui_clear_win_detail): Remove.
3467
3468 2019-06-25  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3471         "this", not TUI_DISASM_WIN.
3472
3473 2019-06-25  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3476         declare.
3477         * tui/tui-winsource.c
3478         (tui_source_window_base::do_scroll_horizontal): Rename from
3479         tui_horizontal_source_scroll.
3480         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3481         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3482         from tui_vertical_data_scroll.
3483         * tui/tui-win.h (tui_scroll): Don't declare.
3484         * tui/tui-win.c (tui_win_info::forward_scroll)
3485         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3486         (tui_win_info::right_scroll): Rename and update.
3487         (tui_scroll_forward_command, tui_scroll_backward_command)
3488         (tui_scroll_left_command, tui_scroll_right_command): Update.
3489         (tui_scroll): Remove.
3490         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3491         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3492         from tui_vertical_source_scroll.
3493         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3494         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3495         from tui_vertical_disassem_scroll.
3496         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3497         do_scroll_horizontal>: New methods.
3498         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3499         Likewise.
3500         (struct tui_source_window_base): Add do_scroll_horizontal.
3501         (struct tui_source_window, struct tui_disasm_window): Add
3502         do_scroll_vertical.
3503         (struct tui_data_window, struct tui_cmd_window): Add
3504         do_scroll_horizontal and do_scroll_vertical.
3505         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3506
3507 2019-06-25  Tom Tromey  <tom@tromey.com>
3508
3509         * tui/tui-data.h (struct tui_source_window_base): New struct.
3510         (struct tui_source_window): Derive from tui_source_window_base.
3511         (struct tui_disasm_window): New struct.
3512         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3513         from tui_source_window::clear_detail.
3514         (tui_source_window_base): Rename from tui_source_window.
3515         (~tui_source_window_base): Rename from ~tui_source_window.
3516         (tui_alloc_win_info): Create a tui_disasm_window.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-data.h (struct tui_source_window)
3521         (struct tui_data_window): Declare destructors.
3522         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3523         destructors.
3524         (tui_win_info): Simplify.
3525
3526 2019-06-25  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-winsource.c (tui_display_main)
3529         (tui_update_source_windows_with_addr)
3530         (tui_update_all_breakpoint_info): Update.
3531         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3532         (new_height_ok, parse_scrolling_args): Update.
3533         * tui/tui-stack.c (tui_show_frame_info): Update.
3534         * tui/tui-data.h (struct tui_list): Remove.
3535         (tui_source_windows): Return a reference to a std::vector.
3536         * tui/tui-data.c (source_windows): Now a std::vector.
3537         (tui_source_windows): Change return type.
3538         (tui_clear_source_windows): Rewrite.
3539         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3540         (tui_free_all_source_wins_content): Rewrite.
3541
3542 2019-06-25  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3545         (struct tui_data_window, struct tui_cmd_window): Declare
3546         clear_detail method.
3547         * tui/tui-data.c (tui_source_window::clear_detail)
3548         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3549         methods.
3550         (tui_clear_win_detail): Simplify.
3551
3552 2019-06-25  Tom Tromey  <tom@tromey.com>
3553
3554         * tui/tui-layout.c (make_source_window, make_disasm_window)
3555         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3556         Return the new window.
3557         (show_source_disasm_command, show_data)
3558         (show_source_or_disasm_and_command): Update.
3559
3560 2019-06-25  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3563         parameter.  Return the new window.
3564         (show_source_disasm_command): Update and remove NULL check.
3565         (show_source_or_disasm_and_command): Update.
3566
3567 2019-06-25  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3570
3571 2019-06-25  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-data.h (struct tui_win_info): Make constructor
3574         protected.  Make destructor virtual.  Add initializers.
3575         (tui_source_window, tui_data_window, tui_cmd_window): New
3576         classes.
3577         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3578         constructor.  Add "type" parameter.
3579         (tui_source_window, tui_data_window, tui_cmd_window): New
3580         constructors.
3581         (tui_alloc_win_info): Instantiate the appropriate subclass.
3582
3583 2019-06-25  Tom Tromey  <tom@tromey.com>
3584
3585         * tui/tui-win.c (tui_resize_all): Use delete.
3586         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3587         destructor.
3588         (tui_free_window): Don't declare.
3589         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3590         Update.
3591
3592 2019-06-25  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-data.h (struct tui_win_info): Add constructor.
3595         * tui/tui-data.c (tui_alloc_win_info): Use new.
3596         (tui_free_window): Use delete.
3597
3598 2019-06-22  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3601         declare.
3602         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3603
3604 2019-06-22  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3607         declare.
3608         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3609
3610 2019-06-22  Tom de Vries  <tdevries@suse.de>
3611
3612         * dwarf2read.c (create_addrmap_from_aranges)
3613         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3614         instead of '%zu'.
3615
3616 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3617
3618         * dwarf2read.h (dwarf2_section_info_def): Remove.
3619         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3620         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3621         std::vector<dwarf2_section_info>.
3622         (struct dwo_file) <~dwo_file>: Remove.
3623         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3624         types field.
3625         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3626         (dwarf2_read_debug_names): Likewise.
3627         (create_debug_types_hash_table): Change parameter type to
3628         array_view, adjust code accordingly.
3629         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3630         (partial_die_info::fixup): Likewise.
3631         (determine_prefix): Likewise.
3632         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3633
3634 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3635
3636         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3637         gdb_bfd_ref_ptr.
3638         <~dwo_file>: Remove call to gdb_bfd_unref.
3639         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3640         gdb_bfd_ref_ptr::get.
3641
3642 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3643
3644         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3645         type to htab_up.
3646         * dwarf2read.c (struct dwo_file): Initialize fields.
3647         <~dwo_file>: New.
3648         (free_dwo_file): Remove, move content to ~dwo_file.
3649         (struct dwo_file_deleter): Remove.
3650         (dwo_file_up>: Remove custom deleter.
3651         (free_dwo_files): Remove.
3652         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3653         dwo_files.
3654         (process_skeletonless_type_units): Call unique_ptr::get.
3655         (allocate_dwo_file_hash_table): Add deleter to created hash
3656         table.  Change return type to htab_up.
3657         (lookup_dwo_file_slot): Don't memset dwo_file, call
3658         unique_ptr::get.
3659         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3660         (create_dwo_unit_in_dwp_v2): Likewise.
3661         (open_and_init_dwo_file): Likewise.
3662         (free_dwo_file_from_slot): Remove.
3663
3664 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3665
3666         * dwarf2read.h (struct dwarf2_section_info) <readin,
3667         is_virtual>: Change type to bool.
3668         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3669         true instead of 1.
3670
3671 2019-06-19  Tom Tromey  <tom@tromey.com>
3672
3673         * tui/tui-data.h (tui_init_content_element): Don't declare.
3674
3675 2019-06-19  Tom Tromey  <tom@tromey.com>
3676
3677         * tui/tui-data.h (tui_init_win_info): Don't declare.
3678
3679 2019-06-19  Tom de Vries  <tdevries@suse.de>
3680
3681         * dwarf2read.h (abstract_to_concrete): Change type to
3682         std::unordered_map<sect_offset, std::vector<sect_offset>,
3683         gdb::hash_enum<sect_offset>>.
3684
3685 2019-06-19  Tom Tromey  <tromey@adacore.com>
3686
3687         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3688         EVAL_AVOID_SIDE_EFFECTS specially.
3689
3690 2019-06-19  Tom Tromey  <tromey@adacore.com>
3691
3692         * source-cache.c (highlighter): New global.
3693         (source_cache::get_source_lines): Create a highlighter on demand.
3694
3695 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * defs.h (deprecated_interactive_hook): Delete declaration.
3698         * interps.c (clear_interpreter_hooks): Remove use of
3699         deprecated_interactive_hook.
3700         * top.c (deprecated_interactive_hook): Delete definition.
3701         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3702
3703 2019-06-18  Tom de Vries  <tdevries@suse.de>
3704
3705         PR gdb/24515
3706         * dwarf2read.h (abstract_to_concrete): Change type from
3707         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3708         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3709         * dwarf2read.c (read_variable): Update.
3710         (dwarf2_fetch_die_loc_sect_off): Update.
3711
3712 2019-06-17  Tom de Vries  <tdevries@suse.de>
3713
3714         PR gdb/24617
3715         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3716         accessing parent[parent_len - 1].
3717
3718 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3719
3720         PR gdb/24364
3721         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3722         call dtrace_process_dof with NULL dof.
3723
3724 2019-06-16  Tom de Vries  <tdevries@suse.de>
3725
3726         PR gdb/24445
3727         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3728
3729 2019-06-16  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3732         (make_all_visible): Use address of member.
3733
3734 2019-06-16  Tom Tromey  <tom@tromey.com>
3735
3736         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3737         (tui_free_window, free_content, free_content_elements): Remove
3738         unnecessary cast.
3739         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3740         cast.
3741         * tui/tui-regs.c (tui_show_register_group)
3742         (tui_display_registers_from, tui_display_reg_element_at_line):
3743         Remove unnecessary cast.
3744
3745 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * linux-nat.c (normal_mask): Delete.
3748         (_initialize_linux_nat): Don't initialise normal_mask.
3749
3750 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3751
3752         PR gdb/24445
3753         * dwarf-index-write.h (write_psymtabs_to_index): Add
3754         dwz_basename parameter.
3755         * dwarf-index-write.c (write_gdbindex): Move file writing to
3756         write_gdbindex_1.  Change return type void.
3757         (assert_file_size): Move up, remove filename parameter.
3758         (write_gdbindex_1): New function.
3759         (write_debug_names): Change return type to void, call
3760         assert_file_size.
3761         (struct index_wip_file): New struct.
3762         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3763         file logic to index_wip_file.  Write index for dwz file if
3764         needed.
3765         (save_gdb_index_command): Pass basename of dwz file, if present.
3766         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3767         build-id of dwz file, if present.
3768         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3769         (dwarf2_get_dwz_file): Likewise.
3770         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3771         (dwarf2_get_dwz_file): Likewise.
3772
3773 2019-06-16  Tom Tromey  <tom@tromey.com>
3774
3775         * coffread.c (process_coff_symbol): Use xstrdup.
3776         * value.c (create_internalvar): Use xstrdup.
3777
3778 2019-06-16  Tom Tromey  <tom@tromey.com>
3779
3780         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3781         * breakpoint.c (stopin_command, stopat_command)
3782         (until_break_command, decode_location_default): Remove unnecessary
3783         cast.
3784         * utils.c (subset_compare): Remove unnecessary cast.
3785         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3786         cast.
3787         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3788         cast.
3789         * infcmd.c (path_command): Remove unnecessary cast.
3790         * coffread.c (decode_type): Remove unnecessary cast.
3791         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3792         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3793         * tui/tui-stack.c (tui_show_locator_content)
3794         (tui_show_frame_info): Remove unnecessary cast.
3795         * tui/tui-win.c (tui_scroll_forward_command)
3796         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3797         (parse_scrolling_args): Remove unnecessary cast.
3798         * tui/tui-data.c (init_win_info, tui_del_window)
3799         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3800         (free_content_elements): Remove unnecessary cast.
3801         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3802         unnecessary cast.
3803         * tui/tui-source.c (tui_set_source_content)
3804         (tui_vertical_source_scroll): Remove unnecessary cast.
3805         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3806         cast.
3807         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3808         * tui/tui-regs.c (tui_display_registers_from)
3809         (tui_display_register): Remove unnecessary cast.
3810         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3811         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3812         (make_visible): Remove unnecessary cast.
3813         * tui/tui-winsource.c (tui_erase_source_content)
3814         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3815         unnecessary cast.
3816         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3817         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3818         * stabsread.c (read_type, read_array_type, read_range_type):
3819         Remove unnecessary cast.
3820         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3821         (parse_symbol, parse_type, upgrade_type, parse_external)
3822         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3823         unnecessary cast.
3824         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3825
3826 2019-06-16  Tom Tromey  <tom@tromey.com>
3827
3828         * tui/tui-data.c (tui_alloc_generic_win_info)
3829         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3830         checks.
3831
3832 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3833             Andrew Burgess  <andrew.burgess@embecosm.com>
3834
3835         * f-typeprint.c (f_print_type): Don't return early for not
3836         associated or not allocated types.
3837         (f_type_print_varspec_suffix): Add print_rank parameter and print
3838         ranks of array types in case they dangling.
3839         (f_type_print_base): Add print_rank parameter.
3840
3841 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3842
3843         * NEWS: Mention new MI commands.
3844         * break-catch-throw.c (enum exception_event_kind): Move to
3845         breakpoint.h.
3846         (print_mention_exception_catchpoint): Output text as a single
3847         message.
3848         (catch_exception_command_1): Rename to...
3849         (catch_exception_event): ...this, make non-static, update header
3850         command, and change some parameter types.
3851         (catch_catch_command): Update for changes to
3852         catch_exception_command_1.
3853         (catch_throw_command): Likewise.
3854         (catch_rethrow_command): Likewise.
3855         * breakpoint.c (enum exception_event_kind): Delete.
3856         * breakpoint.h (enum exception_event_kind): Moved here from
3857         break-catch-throw.c.
3858         (catch_exception_event): Declare.
3859         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3860         (mi_cmd_catch_throw): New function.
3861         (mi_cmd_catch_rethrow): New function.
3862         (mi_cmd_catch_catch): New function.
3863         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3864         'catch-catch' entries.
3865         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3866         (mi_cmd_catch_rethrow): Declare.
3867         (mi_cmd_catch_catch): Declare.
3868
3869 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3870
3871         * annotate.c (annotate_source_line): Change return type to void,
3872         update implementation to match.
3873         * annotate.h (annotate_source_line): Change return type to void,
3874         update header comment.
3875         * stack.c (print_frame_info): Don't change what frame information
3876         is printed based on whether annotations are on or not.
3877
3878 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3879
3880         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3881         (annotate_source): Make static.
3882         (annotate_source_line): Moved from source.c and renamed from
3883         identify_source_line.  Update the return type.
3884         * annotate.h (annotate_source): Delete declaration.
3885         (annotate_source_line): Declaration moved from source.h, and
3886         renamed from identify_source_line.  Return type updated.
3887         * source.c (identify_source_line): Moved to annotate.c and renamed
3888         to annotate_source_line.
3889         (info_line_command): Remove check of annotation_level.
3890         * source.h (identify_source_line): Move declaration to annotate.h
3891         and rename to annotate_source_line.
3892         * stack.c: Add 'annotate.h' include.
3893         (print_frame_info): Remove check of annotation_level before
3894         calling annotate_source_line.
3895
3896 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * source-cache.c (source_cache::get_plain_source_lines): Use
3899         open_source_file_with_line_charpos instead of just
3900         open_source_file, remove call to find_source_lines.
3901         (source_cache::get_source_lines): Likewise.
3902         * source.c (find_source_lines): Make static.
3903         (get_filename_and_charpos): Renamed into...
3904         (open_source_file_with_line_charpos): ..this along with changes to
3905         return a scoped_fd, and some other minor clean ups.
3906         (identify_source_line): Use open_source_file_with_line_charpos.
3907         (search_command_helper): Use open_source_file_with_line_charpos
3908         instead of just open_source_file, remove call to
3909         find_source_lines.
3910         * source.h (open_source_file_with_line_charpos): Declare new
3911         function.
3912         (find_source_lines): Delete declaration.
3913
3914 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3915
3916         * source.c (get_filename_and_charpos): Remove fullname
3917         parameter.
3918         (identify_source_line): Update call to get_filename_and_charpos.
3919
3920 2019-06-14  Tom Tromey  <tromey@adacore.com>
3921
3922         PR gdb/24502:
3923         * ui-style.h (skip_ansi_escape): Update comment.
3924         * ui-file.h (class no_terminal_escape_file): New class.
3925         * ui-file.c (no_terminal_escape_file::write)
3926         (no_terminal_escape_file::puts): New methods.
3927         * cli/cli-logging.c (handle_redirections): Use
3928         no_terminal_escape_file.
3929
3930 2019-06-14  Tom Tromey  <tromey@adacore.com>
3931
3932         * NEWS: Move convenience variable news above Python news.
3933
3934 2019-06-14  Tom Tromey  <tom@tromey.com>
3935
3936         * gnulib: Move directory to top-level.
3937         * configure.ac: Don't configure gnulib.
3938         * configure: Rebuild.
3939         * common/common-defs.h: Use new path to gnulib.
3940         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3941         (GNULIB_H): Remove.
3942         (INCGNU): Look in new gnulib location.
3943         (HFILES_NO_SRCDIR): Remove gnulib files.
3944         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3945         (generated_files): Remove GNULIB_H.
3946         ($(LIBGNU), all-lib): Remove targets.
3947         (distclean): Don't mention GNULIB_BUILDDIR.
3948         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3949
3950 2019-06-14  Tom Tromey  <tromey@adacore.com>
3951
3952         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3953         Warn if symbol file does not provide any symbols.
3954
3955 2019-06-14  Tom Tromey  <tromey@adacore.com>
3956
3957         * source.c (find_and_open_source): Respect basenames_may_differ.
3958
3959 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * annotate.c (annotate_breakpoints_invalid): Make use of
3962         scoped_restore_terminal_state.
3963         (annotate_frames_invalid): Likewise.
3964
3965 2019-06-14  Tom Tromey  <tromey@adacore.com>
3966
3967         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3968         allow assignment to an internalvar.
3969
3970 2019-06-14  Tom Tromey  <tromey@adacore.com>
3971
3972         * ada-lex.l: Allow "_" in attribute names.
3973
3974 2019-06-14  Tom Tromey  <tromey@adacore.com>
3975
3976         PR gdb/24653:
3977         * regcache.c (registers_changed): Don't call alloca.
3978         * top.c (execute_command): Don't call alloca.
3979
3980 2019-06-13  Pedro Alves  <palves@redhat.com>
3981
3982         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3983         'expression'.  When parsing an expression, error out if there's
3984         junk after "unlimited".
3985         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3986         (do_set_command): Adjust calls to is_unlimited_literal.
3987
3988 2019-06-13  Pedro Alves  <palves@redhat.com>
3989
3990         * compile/compile.c (make_compile_options_def_group): Add braces
3991         around array_view initializer.
3992         * thread.c (make_thread_apply_all_options_def_group)
3993         (make_thread_apply_all_options_def_group): Likewise.
3994
3995 2019-06-13  Pedro Alves  <palves@redhat.com>
3996
3997         * NEWS (New commands): Mention "maint test-options
3998         require-delimiter", "maint test-options unknown-is-error", "maint
3999         test-options unknown-is-operand" and "maint show
4000         test-options-completion-result".
4001         (New command options, command completion): New section.
4002         (Completion improvements): New section.
4003         Mention that you can abbreviate "unlimited".
4004
4005 2019-06-13  Pedro Alves  <palves@redhat.com>
4006
4007         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4008         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4009         * unittests/cli-utils-selftests.c (test_parse_flags)
4010         (test_parse_flags_qcs): Delete.
4011         (test_cli_utils): Don't call deleted functions.
4012
4013 2019-06-13  Pedro Alves  <palves@redhat.com>
4014
4015         * thread.c: Include "cli/cli-option.h".
4016         (tp_array_compar_ascending): Global.
4017         (tp_array_compar): Delete function.
4018         (tp_array_compar_ascending, tp_array_compar_descending): New
4019         functions.
4020         (ascending_option_def, qcs_flag_option_def)
4021         (thr_qcs_flags_option_defs)
4022         (make_thread_apply_all_options_def_group)
4023         (make_thread_apply_options_def_group): New.
4024         (thread_apply_all_command): Use gdb::option::process_options.
4025         (thread_apply_command_completer)
4026         (thread_apply_all_command_completer): New.
4027         (thread_apply_command): Use gdb::option::process_options.
4028         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4029         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4030         to generate help text of "thread apply".  Adjust "taas"'s help.
4031         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4032         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4033
4034 2019-06-13  Pedro Alves  <palves@redhat.com>
4035
4036         * thread.c (thread_apply_command): Check for invalid TID with
4037         isdigit instead of !isalpha.
4038
4039 2019-06-13  Pedro Alves  <palves@redhat.com>
4040
4041         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4042         (validate_flags_qcs): New.
4043         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4044         (validate_flags_qcs): Declare.
4045         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4046         (make_frame_apply_options_def_group): New.
4047         (frame_apply_command_count): Process options with
4048         gdb::option::process_options.
4049         (frame_apply_completer): New.
4050         (frame_apply_level_completer, frame_apply_all_completer)
4051         (frame_apply_completer): New.
4052         (_initialize_stack): Update help of "frame apply", "frame apply
4053         level", "frame apply all" and "faas" to mention supported options
4054         and install command completers.
4055         * stack.h (frame_apply_all_completer): Declare.
4056         * thread.c: Include "stack.h".
4057         (tfaas_command): Add "--".
4058         (_initialize_thread): Update help "tfaas" to mention supported
4059         options and install command completer.
4060
4061 2019-06-13  Pedro Alves  <palves@redhat.com>
4062
4063         * completer.c (complete_nested_command_line): New.
4064         (gdb_completion_word_break_characters_throw): Add assertion.
4065         * completer.h (complete_nested_command_line): Declare.
4066
4067 2019-06-13  Pedro Alves  <palves@redhat.com>
4068
4069         * stack.c (parse_backtrace_qualifiers): New.
4070         (backtrace_command): Use it.
4071         (backtrace_command_completer): Complete on qualifiers.
4072
4073 2019-06-13  Pedro Alves  <palves@redhat.com>
4074
4075         * frame.c: Include "cli/cli-option.h.
4076         (user_set_backtrace_options): New.
4077         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4078         Delete.
4079         (get_prev_frame): Adjust.
4080         (boolean_option_def, uinteger_option_def)
4081         (set_backtrace_option_defs): New.
4082         (_initialize_frame): Adjust and use
4083         gdb::option::add_setshow_cmds_for_options to install "set
4084         backtrace past-main" and "set backtrace past-entry".
4085         * frame.h: Include "cli/cli-option.h".
4086         (struct frame_print_options): Forward declare.
4087         (print_frame_arguments_all, print_frame_arguments_scalars)
4088         (print_frame_arguments_none): Declare.
4089         (print_entry_values): Delete declaration.
4090         (struct frame_print_options, user_frame_print_options): New.
4091         (struct set_backtrace_options): New.
4092         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4093         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4094         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4095         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4096         (list_args_or_locals): Add frame_print_options parameter.
4097         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4098         * python/py-framefilter.c (enumerate_args): Pass down
4099         USER_FRAME_PRINT_OPTIONS.
4100         * stack.c: Include "cli/cli-option.h".
4101         (print_frame_arguments_all, print_frame_arguments_scalars)
4102         (print_frame_arguments_none): Declare.
4103         (print_raw_frame_arguments, print_entry_values): Delete.
4104         (user_frame_print_options): New.
4105         (boolean_option_def, enum_option_def, frame_print_option_defs):
4106         New.
4107         (struct backtrace_cmd_options): New.
4108         (bt_flag_option_def): New.
4109         (backtrace_command_option_defs): New.
4110         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4111         (print_frame_arg, read_frame_arg, print_frame_args)
4112         (print_frame_info, print_frame): Add frame_print_options parameter
4113         and use it.
4114         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4115         (backtrace_command_1): Add frame_print_options and
4116         backtrace_cmd_options parameters and use them.
4117         (make_backtrace_options_def_group): New.
4118         (backtrace_command): Process command options with
4119         gdb::option::process_options.
4120         (backtrace_command_completer): New.
4121         (_initialize_stack): Extend "backtrace"'s help to mention
4122         supported options.  Install completer for "backtrace".
4123         Install some settings commands with add_setshow_cmds_for_options.
4124
4125 2019-06-13  Pedro Alves  <palves@redhat.com>
4126
4127         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4128         and that "set/show print raw frame-arguments" are now deprecated.
4129
4130         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4131         command.
4132         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4133         * stack.c (_initialize_stack): Install "set/show print
4134         raw-frame-arguments", and deprecate "set/show print raw
4135         frame-arguments".
4136         * valprint.c (_initialize_valprint): Deprecate "set/show print
4137         raw".
4138
4139 2019-06-13  Pedro Alves  <palves@redhat.com>
4140
4141         * compile/compile.c (struct compile_options): New.
4142         (compile_flag_option_def, compile_command_option_defs)
4143         (make_compile_options_def_group): New.
4144         (compile_file_command): Handle options with
4145         gdb::option::process_options.
4146         (compile_file_command_completer): New function.
4147         (compile_code_command): Handle options with
4148         gdb::option::process_options.
4149         (compile_code_command_completer): New function.
4150         (_initialize_compiler): Install completers for "compile code" and
4151         "compile file".  Mention available options in "compile code" and
4152         "compile code"'s help.
4153         * completer.c (advance_to_completion_word): New, factored out from
4154         ...
4155         (advance_to_expression_complete_word_point): ... this.
4156         (advance_to_filename_complete_word_point): New.
4157         * completer.h (advance_to_filename_complete_word_point): New
4158         declaration.
4159
4160 2019-06-13  Pedro Alves  <palves@redhat.com>
4161
4162         * compile/compile.c: Include "cli/cli-option.h".
4163         (compile_print_value): Scope data pointer is now a
4164         value_print_options pointer; adjust.
4165         (compile_print_command): Process options.  Scope data pointer is
4166         now a value_print_options pointer; adjust.
4167         (_initialize_compile): Update "compile print"'s help to include
4168         supported options.  Install a completer for "compile print".
4169         * cp-valprint.c (show_vtblprint, show_objectprint)
4170         (show_static_field_print): Delete.
4171         (_initialize_cp_valprint): Don't install "set print
4172         static-members", "set print vtbl", "set print object" here.
4173         * printcmd.c: Include "cli/cli-option.h" and
4174         "common/gdb_optional.h".
4175         (print_command_parse_format): Rework to fill in a
4176         value_print_options instead of a format_data.
4177         (print_value): Change parameter type from format_data pointer to
4178         value_print_options reference.  Adjust.
4179         (print_command_1): Process options.  Adjust to pass down a
4180         value_print_options.
4181         (print_command_completer): New.
4182         (_initialize_printcmd): Install print_command_completer as
4183         handle_brkchars completer for the "print" command.  Update
4184         "print"'s help to include supported options.
4185         * valprint.c: Include "cli/cli-option.h".
4186         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4187         here from cp-valprint.c.
4188         (boolean_option_def, uinteger_option_def)
4189         (value_print_option_defs, make_value_print_options_def_group):
4190         New.  Use gdb::option::add_setshow_cmds_for_options to install
4191         "set print elements", "set print null-stop", "set print repeats",
4192         "set print pretty", "set print union", "set print array", "set
4193         print address", "set print symbol", "set print array-indexes".
4194         * valprint.h: Include <string> and "cli/cli-option.h".
4195         (make_value_print_options_def_group): Declare.
4196         (print_value): Change parameter type from format_data pointer to
4197         value_print_options reference.
4198         (print_command_completer): Declare.
4199
4200 2019-06-13  Pedro Alves  <palves@redhat.com>
4201
4202         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4203         (COMMON_SFILES): Add maint-test-settings.c.
4204         * cli/cli-decode.c (boolean_enums): New global, factored out from
4205         ...
4206         (add_setshow_boolean_cmd): ... here.
4207         * cli/cli-decode.h (boolean_enums): Declare.
4208         * cli/cli-option.c: New file.
4209         * cli/cli-option.h: New file.
4210         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4211         factored out from ...
4212         (parse_cli_boolean_value(const char *)): ... this.
4213         (is_unlimited_literal): Change parameter type to pointer to
4214         pointer.  Adjust and advance ARG pointer.
4215         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4216         (parse_cli_var_enum): New, factored out from ...
4217         (do_set_command): ... this.  Adjust.
4218         * cli/cli-setshow.h (parse_cli_boolean_value)
4219         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4220         (parse_cli_var_enum): Declare.
4221         * cli/cli-utils.c: Include "cli/cli-option.h".
4222         (get_ulongest): New.
4223         * cli/cli-utils.h (get_ulongest): Declare.
4224         (check_for_argument): New overloads.
4225         * maint-test-options.c: New file.
4226
4227 2019-06-13  Pedro Alves  <palves@redhat.com>
4228
4229         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4230         parse a range if "-" is at the end of the string.
4231
4232 2019-06-13  Pedro Alves  <palves@redhat.com>
4233
4234         * cli/cli-setshow.c (parse_auto_binary_operation)
4235         (parse_cli_boolean_value): Don't allow "o".
4236
4237 2019-06-13  Pedro Alves  <palves@redhat.com>
4238
4239         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4240         * NEWS: Mention maint test-settings KIND.
4241         * maint-test-settings.c: New file.
4242
4243 2019-06-13  Pedro Alves  <palves@redhat.com>
4244
4245         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4246         completer.
4247         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4248         "set" completers.
4249
4250 2019-06-13  Pedro Alves  <palves@redhat.com>
4251
4252         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4253         after item.
4254
4255 2019-06-13  Pedro Alves  <palves@redhat.com>
4256
4257         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4258
4259 2019-06-13  Pedro Alves <palves@redhat.com>
4260
4261         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4262         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4263         call.
4264         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4265         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4266         calls.
4267         (check_for_argument): Skip spaces after argument.
4268
4269 2019-06-13  Pedro Alves  <palves@redhat.com>
4270
4271         * thread.c (thread_apply_command): Adjust TID parsing.
4272         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4273         detected before end of string.
4274         (tid_is_in_list): Error out if LIST is invalid.
4275
4276 2019-06-13  Pedro Alves  <palves@redhat.com>
4277
4278         * completer.c (complete_line_internal_1): Rewind completion word
4279         point.
4280         (completion_tracker::advance_custom_word_point_by): Change
4281         parameter type to int.
4282         * completer.h (completion_tracker::advance_custom_word_point_by):
4283         Likewise.
4284
4285 2019-06-13  Pedro Alves  <palves@redhat.com>
4286
4287         * completer.c (advance_to_completion_word): Handle delimiters.
4288
4289 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4290
4291         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4292
4293 2019-06-11  Tom Tromey  <tom@tromey.com>
4294
4295         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4296         (xmalloc_failed): Move to alloc.c.
4297         * alloc.c: New file.
4298         * Makefile.in (COMMON_SFILES): Add alloc.c.
4299
4300 2019-06-11  Tom Tromey  <tom@tromey.com>
4301
4302         * nat/linux-waitpid.c: Don't include server.h.
4303         (linux_debug): Remove.
4304         (my_waitpid): Update.
4305
4306 2019-06-11  Tom Tromey  <tromey@adacore.com>
4307
4308         * infcall.c (_initialize_infcall): Remove trailing newline from
4309         help.
4310         * user-regs.c (_initialize_user_regs): Remove trailing newline
4311         from help.
4312         * typeprint.c (_initialize_typeprint): Remove trailing newline
4313         from help.
4314         * reverse.c (_initialize_reverse): Remove trailing newlines from
4315         help.
4316         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4317         from help.
4318         * language.c (add_set_language_command): Remove trailing newline
4319         from help.
4320         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4321         help.
4322         * disasm.c (_initialize_disasm): Remove trailing newline from
4323         help.
4324         * top.c (init_main): Remove trailing newline from help.
4325         * interps.c (_initialize_interpreter): Remove trailing newline
4326         from help.
4327         * btrace.c (_initialize_btrace): Remove trailing newlines from
4328         help.
4329         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4330         from help.
4331         * python/python.c (_initialize_python): Remove trailing newline
4332         from help.
4333         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4334         help.
4335         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4336         from help.  Reformat some text.
4337         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4338         from help.
4339         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4340         newline from help.
4341
4342 2019-06-11  Tom Tromey  <tromey@adacore.com>
4343
4344         * darwin-nat.c (darwin_decode_exception_message)
4345         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4346
4347 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * valops.c (value_slice): Check for not allocated or not
4350         associated values.
4351
4352 2019-06-10  Tom de Vries  <tdevries@suse.de>
4353
4354         PR gdb/24618
4355         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4356         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4357         invalid.
4358
4359 2019-06-10  Tom de Vries  <tdevries@suse.de>
4360
4361         PR gdb/24611
4362         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4363         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4364
4365 2019-06-10  Tom de Vries  <tdevries@suse.de>
4366
4367         PR symtab/24545
4368         * symtab.c (struct demangled_name_entry): Add language field.
4369         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4370         static minimal symbol".  Set and use language field.
4371
4372 2019-06-10  Tom Tromey  <tromey@adacore.com>
4373
4374         * ada-lang.c (_initialize_ada_language): Update help text.
4375
4376 2019-06-10  Tom Tromey  <tromey@adacore.com>
4377
4378         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4379         with a newline.
4380         * guile/guile.c (handle_boot_error): Don't end warning with a
4381         newline.
4382         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4383         warning with a newline.
4384         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4385         newline.
4386         (s12z_frame_cache): Likewise.
4387         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4388         a newline.
4389         * solib-svr4.c (disable_probes_interface): Don't end warning with
4390         a newline.
4391         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4392         newline.
4393         * python/python.c (do_finish_initialization): Don't end warning
4394         with a newline.
4395
4396 2019-06-10  Tom Tromey  <tom@tromey.com>
4397
4398         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4399         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4400         gdbpy_enter.
4401
4402 2019-06-10  Tom Tromey  <tromey@adacore.com>
4403
4404         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4405         data.
4406         (elf_new_init): Don't call stabsread_new_init.
4407         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4408         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4409         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4410
4411 2019-06-10  Tom de Vries  <tdevries@suse.de>
4412
4413         PR symtab/16264
4414         PR symtab/24517
4415         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4416
4417 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4418
4419         * source.c (find_and_open_source): Also rewrite relative file
4420         names.
4421
4422 2019-04-26  Amos Bird  <amosbird@gmail.com>
4423
4424         * annotate.c (annotate_thread_exited): Add "thread-exited"
4425         annotation.
4426
4427 2019-06-06  Tom Tromey  <tromey@adacore.com>
4428
4429         * maint.h (class scoped_command_stats): Use
4430         DISABLE_COPY_AND_ASSIGN.
4431         <print_time>: New method.
4432         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4433         print_time.
4434         (scoped_command_stats::print_time): New method.
4435
4436 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4437
4438         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4439         instructions of lengths 6 or 8 bytes.
4440
4441 2019-06-04  Pedro Alves  <palves@redhat.com>
4442
4443         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4444
4445         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4446         * breakpoint.c (condition_completer): Likewise.
4447         * cli/cli-dump.c (scan_expression): Likewise.
4448         * common/filestuff.c (mkdir_recursive): Likewise.
4449         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4450         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4451         (gdb_abspath): Likewise.
4452         * compile/compile-cplus-types.c
4453         (compile_cplus_instance::decl_name): Likewise.
4454         * completer.c (complete_explicit_location):
4455         (signal_completer, reg_or_group_completer_1): Likewise.
4456         * cp-support.c (cp_remove_params_if_any): Likewise.
4457         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4458         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4459         * infcmd.c (strip_bg_char): Likewise.
4460         * linespec.c (copy_token_string): Likewise.
4461         * mi/mi-main.c (output_cores): Likewise.
4462         * psymtab.c (psymtab_search_name):
4463         * symfile.c (test_set_ext_lang_command): Likewise.
4464         * target.c (target_fileio_read_stralloc): Likewise.
4465         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4466         * value.c (complete_internalvar): Likewise.
4467
4468 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4469
4470         Add objfile property to gdb.Type.
4471         * NEWS: Mention Python API addition.
4472         * python/py-type.c (typy_get_objfile): New method.
4473
4474 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4475
4476         * NEWS: Mention the new set|show style [title|highlight].
4477         Mention changes to "show style", "help" and "apropos".
4478
4479 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4480
4481         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4482         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4483         instead of print_help_for_command.
4484         (print_doc_of_command): New function.
4485         (help_list): Add 'apropos -v word' suggestion.
4486         (print_help_for_command): Style the command name using title style.
4487         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4488         (_initialize_cli_cmds): Describe -v in apropos_command help.
4489
4490 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4491
4492         * cli/cli-style.h (cli_style_option): Add name in constructor,
4493         add m_name class member, add constructor with intensity,
4494         add name class function.
4495         (cli_style_option::add_setshow_commands): Remove name argument.
4496         (highlight_style, title_style): New styles.
4497         * cli/cli-style.c (do_show): New function that shows a style
4498         characteristic styling the style name with itself.
4499         (set_style_name): New function.
4500         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4501         Update all callers according to the changes in cli/cli-style.h.
4502         * utils.h (fputs_highlighted): New function.
4503         * utils.c (fputs_highlighted): Likewise.
4504
4505 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4506
4507         * NEWS: Mention new pipe command and new convenience variables.
4508
4509 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4510
4511         * cli/cli-cmds.c (pipe_command): New function.
4512         (_initialize_cli_cmds): Call add_com for pipe_command.
4513         Define | as an alias for pipe.
4514         (exit_status_set_internal_vars): New function.
4515         (shell_escape): Call exit_status_set_internal_vars.
4516         cli/cli-decode.c (find_command_name_length): Recognize | as
4517         a single character command.
4518
4519 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4520
4521         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4522         top.c (execute_command_to_ui_file): New function, mostly a copy
4523         of execute_command_to_string.
4524         (execute_command_to_string): Implement by calling
4525         execute_command_to_ui_file.
4526
4527 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4528
4529         * top.h (saved_command_line): Remove declaration.
4530         * top.c (previous_saved_command_line, previous_repeat_arguments):
4531         New variables.
4532         (saved_command_line): Make static, define together with other
4533         'repeat variables'.
4534         (dont_repeat): Clear repeat_arguments.
4535         (repeat_previous, get_saved_command_line, save_command_line):
4536         New functions.
4537         (gdb_init): Initialize saved_command_line
4538         and previous_saved_command_line.
4539         * main.c (captured_main_1): Remove saved_command_line initialization.
4540         * event-top.c (handle_line_of_input): Update to use
4541         the new 'repeat' related functions instead of direct access to
4542         saved_command_line.
4543         * command.h (repeat_previous, get_saved_command_line,
4544         save_command_line): New declarations.
4545         (dont_repeat): Add comment.
4546
4547 2019-05-30  Tom Tromey  <tromey@adacore.com>
4548
4549         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4550         Fix comment.
4551         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4552
4553 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4554
4555         PR cli/24587
4556         * completer.c (complete): Initialize variable word.
4557
4558 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4559
4560         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4561         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4562         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4563         'body' is NULL to the outter 'if', protecting the '!is_define'
4564         situation as well.
4565
4566 2019-05-29  Tom Tromey  <tromey@adacore.com>
4567
4568         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4569         (dwarf_unknown): New function.
4570         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4571         (dwarf_type_encoding_name): Use dwarf_unknown.
4572
4573 2019-05-29  Tom Tromey  <tromey@adacore.com>
4574
4575         PR c++/20020:
4576         * cp-valprint.c (cp_print_value_fields): Call
4577         cp_print_static_field inside "try".
4578
4579 2019-05-29  Tom Tromey  <tromey@adacore.com>
4580
4581         * inflow.c (struct terminal_info): Add default operator=.
4582         * configure: Rebuild.
4583         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4584         -Wdeprecated-copy-dtor, -Wredundant-move.
4585
4586 2019-05-29  Tom Tromey  <tromey@adacore.com>
4587
4588         * NEWS: Add entry.
4589         * infcmd.c (print_return_value_1): Handle finish_print
4590         option.
4591         (show_print_finish): New function.
4592         (_initialize_infcmd): Add "set/show print finish" commands.
4593         * valprint.c (user_print_options): Initialize new member.
4594         * valprint.h (struct value_print_options) <finish_print>: New
4595         member.
4596
4597 2019-05-28  Tom Tromey  <tromey@adacore.com>
4598
4599         * ada-lang.c (ada_remove_Xbn_suffix)
4600         (find_old_style_renaming_symbol)
4601         (parse_old_style_renaming): Remove.
4602         (ada_find_renaming_symbol): Don't call
4603         find_old_style_renaming_symbol.
4604         (ada_is_renaming_symbol): Rename from
4605         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4606         bool.  Now static.
4607         (ada_read_var_value): Update and simplify.
4608         * ada-exp.y (write_var_or_type): Remove old code.
4609
4610 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4611
4612         * event-top.c: Remove include comment.
4613         * inflow.c (class scoped_ignore_sigttou): Move from here...
4614         * inflow.h (class scoped_ignore_sigttou): ...to here.
4615         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4616         * top.c:  Remove include comment.
4617
4618 2019-05-27  Tom Tromey  <tom@tromey.com>
4619
4620         * NEWS: Fix typo.
4621
4622 2019-05-22  Tom Tromey  <tromey@adacore.com>
4623
4624         * target.c (target_follow_exec): Constify parameter.
4625         * target-delegates.c: Rebuild.
4626         * remote.c (remote_target::follow_exec): Constify parameter.
4627         * infrun.c (follow_exec): Constify parameter.
4628         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4629         (target_follow_exec): Likewise.
4630
4631 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4632
4633         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4634         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4635
4636 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4637
4638         * NEWS: Add debugredirect and testsuite sections.
4639
4640 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4641
4642         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4643         target descriptions using exclusively floating point register name
4644         aliases.
4645
4646 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4647
4648         PR gdb/18644:
4649         * f-lang.c (build_fortran_types): Handle the case where
4650         gdbarch_floatformat_for_type returns a nullptr.
4651
4652 2019-05-21  Tom de Vries  <tdevries@suse.de>
4653
4654         PR cli/24587
4655         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4656
4657 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4658
4659         PR gdb/18644:
4660         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4661         16-byte floats.
4662         * i386-tdep.c (i386_floatformat_for_type): Use
4663         floatformats_ia64_quad for the 16-byte floating point component
4664         within a fortran 32-byte complex number.
4665
4666 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4667
4668         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4669         delete default constructor.
4670         (find_partial_die): Update to return const struct.
4671         (partial_die_parent_scope): Move variable declaration into scope
4672         of its use and change its type to auto.
4673         (guess_partial_die_structure_name): Likewise.
4674         (partial_die_info::fixup): Likewise.
4675
4676 2019-05-17  Tom Tromey  <tromey@adacore.com>
4677
4678         * source.c (find_and_open_source): Remove cast.
4679
4680 2019-05-17  Tom Tromey  <tromey@adacore.com>
4681
4682         * annotate.c (annotate_source): Make "filename" const.
4683         * annotate.h (annotate_source): Use const.
4684
4685 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4686
4687         * disasm.c (set_disassembler_options): Send errors to stderr.
4688
4689 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4690
4691         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4692         (cli_interp_base::set_logging): Check debug_redirect.
4693         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4694         * cli/cli-logging.c (debug_redirect): Add static variable.
4695         (pop_output_files): Add default param.
4696         (handle_redirections): Print debug setting.
4697         (show_logging_command): Likewise.
4698         (_initialize_cli_logging): Add debugredirect command.
4699         * interps.c (current_interp_set_logging): Add debug_redirect
4700         parameter.
4701         * interps.h (set_logging): Add debug_redirect parameter.
4702         (current_interp_set_logging): Likewise.
4703         * mi/mi-common.h: Likewise.
4704         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4705
4706 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4707             Tom Tromey  <tromey@adacore.com>
4708
4709         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4710         directly.
4711         * cli/cli-interp.h (make_logging_output): Remove declaration.
4712         * cli/cli-logging.c (make_logging_output): Remove function.
4713         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4714         directly.
4715         * ui-file.c (tee_file::tee_file): Remove bools.
4716         (tee_file::~tee_file): Remove deletes.
4717         * ui-file.h (tee_file): Remove bools.
4718
4719 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4720
4721         * mi/mi-cmds.h (mi_cmd_complete): New function.
4722         * mi/mi-main.c (mi_cmd_complete): Likewise.
4723         * mi/mi-cmds.c: Define new MI command -complete.
4724         * NEWS: Mention new -complete command.
4725
4726 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4727
4728         * completer.h (complete): New function.
4729         * completer.c (complete): Likewise.
4730         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4731         function defined in completer.h.
4732
4733 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4734
4735         * MAINTAINERS (Write After Approval): Add myself.
4736
4737 2019-05-17  Tom de Vries  <tdevries@suse.de>
4738
4739         PR gdb/24094
4740         * dwarf2read.c (struct cu_partial_die_info): New struct.
4741         (find_partial_die): Return cu_partial_die_info.
4742         (partial_die_parent_scope, guess_partial_die_structure_name)
4743         (partial_die_info::fixup): Handle new return type of find_partial_die.
4744
4745 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4746
4747         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4748         "std::string", simplifying the algorithm.
4749
4750 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4751
4752         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4753         (stap_static_probe_ops::get_probes): Likewise.
4754
4755 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4756
4757         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4758         '-')" and "else if".
4759         (stap_parse_single_operand): Join checks for
4760         "gdbarch_stap_parse_special_token_p" and
4761         "gdbarch_stap_parse_special_token" in the same "if" statement.
4762         Invert check when verifying for operation on register
4763         displacement.
4764
4765 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4766
4767         * stap-probe.c (stap_get_opcode): Update comment.
4768         (stap_get_expected_argument_type): Likewise.
4769         (handle_stap_probe): Likewise.
4770
4771 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4772
4773         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4774         return type to 'bool'.  Adjust comment.  Use 'bool' when
4775         appropriate.
4776         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4777         * stap-probe.c (stap_parse_argument_1): Likewise.
4778         (stap_is_operator): Likewise.
4779         (stap_is_generic_prefix): Likewise.
4780         (stap_is_register_prefix): Likewise.
4781         (stap_is_register_indirection_prefix): Likewise.
4782         (stap_is_integer_prefix): Likewise.
4783         (stap_generic_check_suffix): Likewise.
4784         (stap_check_integer_suffix): Likewise.
4785         (stap_check_register_suffix): Likewise.
4786         (stap_check_register_indirection_suffix): Likewise.
4787         (stap_parse_register_operand): Likewise.
4788         (stap_parse_single_operand): Likewise.
4789         (stap_parse_argument_1): Likewise.
4790         (stap_probe::get_argument_count): Likewise.
4791         (stap_is_operator): Likewise.
4792
4793 2019-05-16  Tom Tromey  <tromey@adacore.com>
4794
4795         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4796         keyword to foreach.
4797
4798 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4799
4800         * linux-thread-db.c (try_thread_db_load_1): Change return type
4801         to bool.
4802         (try_thread_db_load): Likewise.
4803         (try_thread_db_load_from_pdir_1): Likewise.
4804         (try_thread_db_load_from_pdir): Likewise.
4805         (try_thread_db_load_from_sdir): Likewise.
4806         (try_thread_db_load_from_dir): Likewise.
4807         (thread_db_load_search): Likewise.
4808         (has_libpthread): Likewise.
4809         (thread_db_load): Likewise.
4810
4811 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4812
4813         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4814         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4815         NULL, and complain/return if that's the case.
4816
4817 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4818
4819         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4820         (advance, posn, abstract_read_memory): New functions.
4821         [struct mem_read_abstraction]: New struct.
4822         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4823
4824 2019-05-14  Tom Tromey  <tromey@adacore.com>
4825
4826         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4827         value is not lval_memory.
4828
4829 2019-05-14  Tom Tromey  <tromey@adacore.com>
4830
4831         * solib.c (info_sharedlibrary_command): Style the file name.
4832
4833 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4834
4835         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4836         (aarch64_vnv_type): Likewise.
4837         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4838         * common/tdesc.c: Likewise.
4839         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4840         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4841         * features/aarch64-fpu.xml: Add ieee half view.
4842         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4843         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4844         * gdbtypes.h (struct builtin_type): Likewise.
4845         (struct objfile_type): Likewise.
4846
4847 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4848
4849         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4850         typo.
4851         * location.h (string_to_event_location): Likewise.
4852
4853 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4854
4855         GDB 8.3 released.
4856
4857 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4858
4859         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4860         New variable declaration.
4861         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4862         New variable.
4863         (print_one_breakpoint): Use ui_out::test_flags and new global
4864         variable to compute use_fixed_output.
4865         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4866         Remove.
4867         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4868         (mi_multi_location_breakpoint_output_fixed): Remove.
4869         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4870         new variable.
4871         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4872         fix_multi_location_breakpoint_output flag if version >= 3.
4873         * ui-out.h (enum ui_out_flag)
4874         <fix_multi_location_breakpoint_output>: New enumerator.
4875
4876 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4877
4878         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4879
4880 2019-05-10  Tom Tromey  <tromey@adacore.com>
4881
4882         * ada-lang.c (catch_ada_completer): New function.
4883         (_initialize_ada_language): Use it.
4884
4885 2019-05-10  Tom Tromey  <tromey@adacore.com>
4886
4887         * thread.c (print_thread_info): Make "requested_threads" const.
4888         * gdbthread.h (print_thread_info): Make "requested_threads"
4889         const.
4890         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4891         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4892
4893 2019-05-08  Tom Tromey  <tom@tromey.com>
4894
4895         * gdbtypes.c (objfile_type_data): Change type.
4896         (objfile_type, _initialize_gdbtypes): Update.
4897
4898 2019-05-08  Tom Tromey  <tom@tromey.com>
4899
4900         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4901         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4902         (_initialize_dwarf2_frame): Update.
4903
4904 2019-05-08  Tom Tromey  <tom@tromey.com>
4905
4906         * objc-lang.c (objc_objfile_data): Change type.
4907         (find_methods): Update.
4908         (_initialize_objc_lang): Remove.
4909
4910 2019-05-08  Tom Tromey  <tom@tromey.com>
4911
4912         * stabsread.c (rs6000_builtin_type_data): Change type.
4913         (rs6000_builtin_type, _initialize_stabsread): Update.
4914
4915 2019-05-08  Tom Tromey  <tom@tromey.com>
4916
4917         * mips-tdep.c (mips_pdr_data): Remove.
4918         (_initialize_mips_tdep): Update.
4919
4920 2019-05-08  Tom Tromey  <tom@tromey.com>
4921
4922         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4923         (hppa_init_objfile_priv_data, read_unwind_info)
4924         (find_unwind_entry, _initialize_hppa_tdep): Update.
4925
4926 2019-05-08  Tom Tromey  <tom@tromey.com>
4927
4928         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4929         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4930         on obstack.
4931         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4932
4933 2019-05-08  Tom Tromey  <tom@tromey.com>
4934
4935         * mdebugread.c (basic_type_data): Change type.
4936         (basic_type, _initialize_mdebugread): Update.
4937
4938 2019-05-08  Tom Tromey  <tom@tromey.com>
4939
4940         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4941
4942 2019-05-08  Tom Tromey  <tom@tromey.com>
4943
4944         * nto-tdep.c (nto_inferior_data_reg): Change type.
4945         (nto_inferior_data): Update.
4946         (nto_inferior_data_cleanup, nto_new_inferior_data)
4947         (_initialize_nto_tdep): Remove.
4948         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4949
4950 2019-05-08  Tom Tromey  <tom@tromey.com>
4951
4952         * ada-lang.c (struct ada_inferior_data): Add initializers.
4953         (ada_inferior_data): Change type.
4954         (ada_inferior_data_cleanup): Remove.
4955         (get_ada_inferior_data, ada_inferior_exit)
4956         (struct ada_pspace_data): Add initializers, destructor.
4957         (ada_pspace_data_handle): Change type.
4958         (get_ada_pspace_data): Update.
4959         (ada_pspace_data_cleanup): Remove.
4960
4961 2019-05-08  Tom Tromey  <tom@tromey.com>
4962
4963         * coffread.c (struct coff_symfile_info): Add initializers.
4964         (coff_objfile_data_key): Move lower.  Change type.
4965         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4966         Update.
4967         (coff_free_info): Remove.
4968
4969 2019-05-08  Tom Tromey  <tom@tromey.com>
4970
4971         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4972         (fbsd_pspace_data_handle): Move lower.  Change type.
4973         (get_fbsd_pspace_data): Update.
4974         (fbsd_pspace_data_cleanup): Remove.
4975         (_initialize_fbsd_tdep): Update.
4976
4977 2019-05-08  Tom Tromey  <tom@tromey.com>
4978
4979         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4980         (get_ada_tasks_pspace_data): Update.
4981         (ada_tasks_pspace_data_cleanup): Remove.
4982         (_initialize_tasks): Update.
4983         (ada_tasks_inferior_data_handle): Change type.
4984         (get_ada_tasks_inferior_data): Update.
4985         (ada_tasks_inferior_data_cleanup): Remove.
4986         (struct ada_tasks_pspace_data): Add initializers.
4987
4988 2019-05-08  Tom Tromey  <tom@tromey.com>
4989
4990         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4991         * symfile-debug.c (debug_sym_get_probes): Change type.
4992         * stap-probe.c (handle_stap_probe):
4993         (stap_static_probe_ops::get_probes): Change type.
4994         * probe.h (class static_probe_ops) <get_probes>: Change type.
4995         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4996         (parse_probes_in_pspace): Update.
4997         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4998         Update.
4999         (any_static_probe_ops::get_probes): Change type.
5000         * elfread.c (elfread_data): New typedef.
5001         (probe_key): Change type.
5002         (elf_get_probes): Likewise.  Update.
5003         (probe_key_free): Remove.
5004         (_initialize_elfread): Update.
5005         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5006         Change type.
5007         (dtrace_process_dof_probe, dtrace_process_dof)
5008         (dtrace_static_probe_ops::get_probe): Change type.
5009
5010 2019-05-08  Tom Tromey  <tom@tromey.com>
5011
5012         * xcoffread.c (struct xcoff_symfile_info): Rename from
5013         coff_symfile_info.  Add initializers.
5014         (xcoff_objfile_data_key): Move lower.  Change type.
5015         (XCOFF_DATA): Rewrite.
5016         (xcoff_free_info): Remove.
5017         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5018         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5019         (xcoff_initial_scan): Update.
5020
5021 2019-05-08  Tom Tromey  <tom@tromey.com>
5022
5023         * solib-svr4.c (struct svr4_info): Add initializers and
5024         destructor.
5025         <probes_table>: Now an htab_up.
5026         (solib_svr4_pspace_data): Change type.
5027         (free_probes_table): Simplify.
5028         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5029         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5030         (probes_table_remove_objfile_probes, register_solib_event_probe)
5031         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5032         (_initialize_svr4_solib): Update.
5033
5034 2019-05-08  Tom Tromey  <tom@tromey.com>
5035
5036         * remote.c (remote_pspace_data): Change type.
5037         (remote_pspace_data_cleanup): Remove.
5038         (get_remote_exec_file, set_pspace_remote_exec_file)
5039         (_initialize_remote): Update.
5040
5041 2019-05-08  Tom Tromey  <tom@tromey.com>
5042
5043         * breakpoint.c (breakpoint_objfile_key): Change type.
5044         (get_breakpoint_objfile_data): Update.
5045         (free_breakpoint_objfile_data): Remove.
5046         (_initialize_breakpoint): Update.
5047
5048 2019-05-08  Tom Tromey  <tom@tromey.com>
5049
5050         * linux-tdep.c (struct linux_info): Add initializers.
5051         (linux_inferior_data): Move.  Change type.
5052         (invalidate_linux_cache_inf): Update.
5053         (linux_inferior_data_cleanup): Remove.
5054         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5055
5056 2019-05-08  Tom Tromey  <tom@tromey.com>
5057
5058         * auxv.c (auxv_inferior_data): Move.  Change type.
5059         (auxv_inferior_data_cleanup): Remove.
5060         (invalidate_auxv_cache_inf): Rewrite.
5061         (get_auxv_inferior_data, _initialize_auxv): Update.
5062
5063 2019-05-08  Tom Tromey  <tom@tromey.com>
5064
5065         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5066         (symfile_debug_objfile_data_key): Change type.
5067         (symfile_debug_installed, debug_qf_has_symbols)
5068         (debug_qf_find_last_source_symtab)
5069         (debug_qf_forget_cached_source_info)
5070         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5071         (debug_qf_print_stats, debug_qf_dump)
5072         (debug_qf_expand_symtabs_for_function)
5073         (debug_qf_expand_all_symtabs)
5074         (debug_qf_expand_symtabs_with_fullname)
5075         (debug_qf_map_matching_symbols)
5076         (debug_qf_expand_symtabs_matching)
5077         (debug_qf_find_pc_sect_compunit_symtab)
5078         (debug_qf_map_symbol_filenames)
5079         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5080         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5081         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5082         (debug_sym_read_linetable, debug_sym_relocate): Update.
5083         (symfile_debug_free_objfile): Remove.
5084         (install_symfile_debug_logging, _initialize_symfile_debug):
5085         Update.
5086
5087 2019-05-08  Tom Tromey  <tom@tromey.com>
5088
5089         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5090         allocate_on_obstack.
5091         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5092         (get_dwarf2_per_objfile): Update.
5093         (set_dwarf2_per_objfile): Remove.
5094         (dwarf2_has_info, dwarf2_get_section_info): Update.
5095         (dwarf2_free_objfile): Remove.
5096         (_initialize_dwarf2_read): Update.
5097
5098 2019-05-08  Tom Tromey  <tom@tromey.com>
5099
5100         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5101         initializers.
5102         <unsupported_script_warning_printed,
5103         script_not_found_warning_printed>: Now bool.
5104         (auto_load_pspace_data): Change type.
5105         (~auto_load_pspace_info): Rename from
5106         auto_load_pspace_data_cleanup.
5107         (get_auto_load_pspace_data, init_loaded_scripts_info)
5108         (clear_section_scripts, maybe_print_unsupported_script_warning)
5109         (maybe_print_script_not_found_warning, _initialize_auto_load):
5110         Update.
5111
5112 2019-05-08  Tom Tromey  <tom@tromey.com>
5113
5114         * objfiles.c (objfile_pspace_info): Add destructor and
5115         initializers.
5116         (objfiles_pspace_data): Change type.
5117         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5118         (get_objfile_pspace_data): Update.
5119         (objfiles_bfd_data): Change type.
5120         (get_objfile_bfd_data): Update.
5121         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5122
5123 2019-05-08  Tom Tromey  <tom@tromey.com>
5124
5125         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5126         Change type.
5127         (get_catch_syscall_inferior_data): Update.
5128         (catch_syscall_inferior_data_cleanup): Remove.
5129         (_initialize_break_catch_syscall): Update.
5130
5131 2019-05-08  Tom Tromey  <tom@tromey.com>
5132
5133         * inflow.c (struct terminal_info): Add destructor and
5134         initializers.
5135         (inflow_inferior_data): Change type.
5136         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5137         (get_inflow_inferior_data, inflow_inferior_exit)
5138         (swap_terminal_info, _initialize_inflow): Update.
5139
5140 2019-05-08  Tom Tromey  <tom@tromey.com>
5141
5142         * target-dcache.c (target_dcache_cleanup): Remove.
5143         (target_dcache_aspace_key): Change type.
5144         (target_dcache_init_p, target_dcache_invalidate)
5145         (target_dcache_get, target_dcache_get_or_init)
5146         (_initialize_target_dcache): Update.
5147         * dcache.h (struct dcache_deleter): New.
5148
5149 2019-05-08  Tom Tromey  <tom@tromey.com>
5150
5151         * symtab.c (struct symbol_cache): Add destructor and
5152         initializers.
5153         (symbol_cache_key): Move.  Change type.
5154         (make_symbol_cache, free_symbol_cache): Remove.
5155         (get_symbol_cache): Update.
5156         (symbol_cache_cleanup): Remove.
5157         (ALL_PSPACES, symbol_cache_flush)
5158         (maintenance_print_symbol_cache)
5159         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5160         Update.
5161
5162 2019-05-08  Tom Tromey  <tom@tromey.com>
5163
5164         * symtab.c (struct main_info): Add destructor and initializers.
5165         (main_progspace_key): Move.  Change type.
5166         (get_main_info): Update.
5167         (main_info_cleanup): Remove.
5168         (_initialize_symtab): Update.
5169
5170 2019-05-08  Tom Tromey  <tom@tromey.com>
5171
5172         * registry.h (DECLARE_REGISTRY): Define the _key class.
5173
5174 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5175
5176         * NEWS: Merge two 'New commands' sections.
5177
5178 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5179
5180         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5181         parameter and use Ada language definition instead.
5182         (ada_val_print_ptr): Remove unused language parameter.
5183         (ada_val_print_num): Remove language parameter and use Ada language
5184         definition instead.
5185         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5186         parameter.
5187         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5188         parameter and use Ada language definition instead.
5189         (ada_val_print_1): Update all ada_val_print_xxx calls.
5190         Remove language parameter.
5191         (ada_val_print): Update ada_val_print_1 call.
5192
5193 2019-05-08  Tom Tromey  <tromey@adacore.com>
5194
5195         * remote.c (remote_hw_watchpoint_limit)
5196         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5197         Now static.
5198
5199 2019-05-08  Tom Tromey  <tromey@adacore.com>
5200
5201         * maint.c (_initialize_maint_cmds): Move initialization code to
5202         remote.c.
5203         (watchdog, show_watchdog): Move to remote.c.
5204         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5205         "watchdog" static.
5206         (_initialize_remote): Move initialization code from maint.c.
5207         * defs.h (watchdog): Don't declare.
5208
5209 2019-05-08  Tom Tromey  <tromey@adacore.com>
5210
5211         * tui/tui-interp.c: Include main.h.
5212         * interps.c: Include main.h.
5213         * main.h (interpreter_p): Declare.
5214         * defs.h (interpreter_p): Don't declare.
5215
5216 2019-05-08  Tom Tromey  <tromey@adacore.com>
5217
5218         * dwarf2loc.c: Include dwarf2read.h.
5219         * defs.h (read_unsigned_leb128): Don't declare.
5220         * dwarf2read.h (read_unsigned_leb128): Declare.
5221
5222 2019-05-08  Tom Tromey  <tromey@adacore.com>
5223
5224         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5225         method.
5226
5227 2019-05-08  Tom Tromey  <tromey@adacore.com>
5228
5229         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5230         when no wrap column is set.
5231
5232 2019-05-08  Tom Tromey  <tromey@adacore.com>
5233
5234         * c-lang.c (c_get_string): Handle non-C-style arrays.
5235
5236 2019-05-08  Tom Tromey  <tromey@adacore.com>
5237
5238         * typeprint.c (print_offset_data::update): Print the bit offset,
5239         not the number of bits remaining.
5240
5241 2019-05-08  Tom Tromey  <tromey@adacore.com>
5242
5243         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5244         padding at end of comment.
5245
5246 2019-05-08  Tom Tromey  <tromey@adacore.com>
5247
5248         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5249         Compare main types.
5250
5251 2019-05-06  Tom Tromey  <tom@tromey.com>
5252
5253         * common/scoped_mmap.c: Include common-defs.h.
5254         * common/scoped_mmap.h: Don't include config.h.
5255
5256 2019-05-04  Tom Tromey  <tom@tromey.com>
5257
5258         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5259         (struct aarch64_call_info): Add initializers.
5260         <si>: Now a std::vector.
5261         (pass_on_stack, aarch64_push_dummy_call): Update.
5262
5263 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5264             Tom Tromey  <tom@tromey.com>
5265
5266         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5267         (ppc_threads): Now a std::vector.  Now static.
5268         (hwdebug_find_thread_points_by_tid)
5269         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5270         Update.
5271
5272 2019-05-04  Tom Tromey  <tom@tromey.com>
5273
5274         * arc-tdep.c (arc_tdesc_init): Return bool.
5275
5276 2019-05-04  Tom Tromey  <tom@tromey.com>
5277
5278         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5279         Use gdb_assert_not_reached.
5280
5281 2019-05-04  Tom Tromey  <tom@tromey.com>
5282
5283         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5284         "false".
5285
5286 2019-05-04  Tom Tromey  <tom@tromey.com>
5287
5288         * arc-tdep.c (arc_tdesc_init): Use bool.
5289
5290 2019-05-04  Tom Tromey  <tom@tromey.com>
5291
5292         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5293
5294 2019-05-04  Tom Tromey  <tom@tromey.com>
5295
5296         * cli/cli-cmds.c (valid_command_p): Return bool.
5297
5298 2019-05-04  Tom Tromey  <tom@tromey.com>
5299
5300         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5301         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5302
5303 2019-05-04  Raul Tambre  <raul@tambre.ee>
5304
5305         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5306         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5307         operator for comparison.
5308
5309 2019-05-04  Tom Tromey  <tom@tromey.com>
5310
5311         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5312         (lookup_partial_symbol, print_partial_symbols)
5313         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5314         (psymbol_compare): Update.
5315         (add_psymbol_to_bcache): Clear the entire psymbol.
5316         (maintenance_check_psymtabs): Update.
5317         * psympriv.h (struct partial_symbol): Don't derive from
5318         general_symbol_info.
5319         <obj_section, unrelocated_address, address,
5320         set_unrelocated_address>: Update.
5321         <ginfo>: New member.
5322         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5323         (debug_names::write_psymbols): Update.
5324
5325 2019-05-04  Tom de Vries  <tdevries@suse.de>
5326
5327         * contrib/cc-with-tweaks.sh: Support -n arg.
5328
5329 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5330
5331         * corelow.c (core_target::detach): Ensure frame cache and
5332         register caches are cleared.
5333         inferior.c (exit_inferior_1): Likewise.
5334
5335 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5336             Tom Tromey  <tom@tromey.com>
5337
5338         * dictionary.c (collate_pending_symbols_by_language): Remove
5339         "struct" from foreach.
5340         * symtab.c (lookup_global_symbol_from_objfile)
5341         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5342         foreach.
5343         * ser-tcp.c (net_open): Remove "struct" from foreach.
5344         * objfiles.c (objfile_relocate, objfile_rebase)
5345         (objfile_has_symbols): Remove "struct" from foreach.
5346         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5347         from foreach.
5348         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5349         foreach.
5350         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5351         "struct" from foreach.
5352         * ada-lang.c (create_excep_cond_exprs)
5353         (ada_exception_catchpoint_cond_string): Remove "struct" from
5354         foreach.
5355
5356 2019-05-03  Tom Tromey  <tromey@adacore.com>
5357
5358         * ada-exp.y (convert_char_literal): Check suffix of each
5359         enumerator.
5360
5361 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5362
5363         PR ada/21406:
5364         * ada-exp.y (yywrap): Don't define.
5365         * ada-lex.l (%option): Add noyywrap
5366         (yywrap): Remove.
5367
5368 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5369
5370         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5371         _WIN32_WINNT to the XP level, unless already defined to a higher
5372         level.
5373
5374         * unittests/parse-connection-spec-selftests.c:
5375         * ser-tcp.c:
5376         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5377         override.
5378
5379         * symfile.c (find_separate_debug_file): Remove colon from the
5380         drive spec of DOS/Windows file names of the target, so that the
5381         file name produced from DEBUGDIR and the target's directory will
5382         be valid on DOS/Windows systems.
5383
5384 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5385
5386         * rust-lang.c (val_print_struct): Handle printing structures
5387         containing strings.
5388
5389 2019-05-02  Tom Tromey  <tromey@adacore.com>
5390
5391         * valarith.c (_initialize_valarith): Remove.
5392
5393 2019-05-01  Tom Tromey  <tromey@adacore.com>
5394
5395         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5396         bitfields.
5397
5398 2019-05-01  Tom Tromey  <tromey@adacore.com>
5399
5400         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5401         for big-endian copies.
5402
5403 2019-04-30  Ali Tamur  <tamur@google.com>
5404         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5405         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5406         (read_3_bytes): New function.
5407
5408 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5409
5410         * windows-nat.c (main_thread_id): Delete.
5411         (handle_output_debug_string): Replace main_thread_id by
5412         current_event.dwThreadId.
5413         (fake_create_process): Likewise.
5414         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5415         Do not set main_thread_id.
5416         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5417         current_event.dwThreadId.
5418         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5419
5420 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5421
5422         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5423         Use current_event.dwThreadId instead of main_thread_id.
5424
5425 2019-04-30  Tom Tromey  <tromey@adacore.com>
5426
5427         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5428         (create_excep_cond_exprs): Iterate over program spaces.
5429         (ada_exception_catchpoint_cond_string): Examine all minimal
5430         symbols for exception types.
5431
5432 2019-04-30  Tom Tromey  <tromey@adacore.com>
5433
5434         PR c++/24470:
5435         * dwarf2read.c (process_structure_scope): Handle case where type
5436         has template parameters but no symbol was created.
5437
5438 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5439             Chris January  <chris.january@arm.com>
5440
5441         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5442         qualifier.
5443         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5444
5445 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5446
5447         * f-typeprint.c (f_print_type): Update rules for printing
5448         whitespace.
5449         (f_type_print_varspec_suffix): Likewise.
5450
5451 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5452             Chris January  <chris.january@arm.com>
5453
5454         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5455         function arguments.
5456
5457 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5458
5459         * f-lang.c (build_fortran_types): Change name of void type to
5460         lower case.
5461         * f-typeprint.c (f_type_print_base): Print the name of the void
5462         type, rather than a fixed string.
5463         * f-valprint.c (f_decorations): Use lower case void string.
5464
5465 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5466             Chris January  <chris.january@arm.com>
5467
5468         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5469         types for Fortran.
5470
5471 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5472             Chris January  <chris.january@arm.com>
5473             David Lecomber  <david.lecomber@arm.com>
5474
5475         * f-exp.y (BINOP_INTRINSIC): New token.
5476         (exp): New parser rule handling BINOP_INTRINSIC.
5477         (f77_keywords): Add new builtin procedures.
5478         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5479         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5480         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5481         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5482         (print_unop_subexp_f): New function.
5483         (print_binop_subexp_f): New function.
5484         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5485         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5486         (dump_subexp_body_f): Likewise.
5487         (operator_check_f): Likewise.
5488         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5489         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5490
5491 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5492
5493         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5494         UNOP_KIND.
5495         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5496         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5497         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5498         (operator_length_f): New fuction.
5499         (print_subexp_f): New function.
5500         (op_name_f): New function.
5501         (dump_subexp_body_f): New function.
5502         (operator_check_f): New function.
5503         (exp_descriptor_f): Replace standard expression handling functions
5504         with new functions.
5505         * gdb/fortran-operator.def: New file.
5506         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5507         * gdb/std-operator.def: Remove UNOP_KIND.
5508
5509 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5510
5511         * std-operator.def: Remove unbalanced, stray double quote
5512         character.
5513
5514 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5515             Chris January  <chris.january@arm.com>
5516             Daniel Everett  <daniel.everett@arm.com>
5517             Nick Forrington  <nick.forrington@arm.com>
5518             Richard Bunt  <richard.bunt@arm.com>
5519
5520         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5521         of depth when printing anonymous structs or unions.
5522         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5523         Don't print either the top-level value, or the children if the
5524         max-depth is exceeded.
5525         (ppscm_print_children): When printing the key of a map, allow one
5526         extra level of depth.
5527         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5528         print either the top-level value, or the children if the max-depth
5529         is exceeded.
5530         (print_children): When printing the key of a map, allow one extra
5531         level of depth.
5532         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5533         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5534         (user_print_options): Initialise max_depth field.
5535         (val_print_scalar_or_string_type_p): New function.
5536         (val_print): Check to see if the max depth has been reached.
5537         (val_print_check_max_depth): Define new function.
5538         (show_print_max_depth): New function.
5539         (_initialize_valprint): Add 'print max-depth' option.
5540         * valprint.h (struct value_print_options) <max_depth>: New field.
5541         (val_print_check_max_depth): Declare new function.
5542         * NEWS: Document new feature.
5543
5544 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5545
5546         * ada-lang.c (ada_language_defn): Initialise new field.
5547         * c-lang.c (c_is_string_type_p): New function.
5548         (c_language_defn): Initialise new field.
5549         (cplus_language_defn): Initialise new field.
5550         (asm_language_defn): Initialise new field.
5551         (minimal_language_defn): Initialise new field.
5552         * c-lang.h (c_is_string_type_p): Declare new function.
5553         * d-lang.c (d_language_defn): Initialise new field.
5554         * f-lang.c (f_is_string_type_p): New function.
5555         (f_language_defn): Initialise new field.
5556         * go-lang.c (go_is_string_type_p): New function.
5557         (go_language_defn): Initialise new field.
5558         * language.c (default_is_string_type_p): New function.
5559         (unknown_language_defn): Initialise new field.
5560         (auto_language_defn): Initialise new field.
5561         * language.h (struct language_defn) <la_is_string_type_p>: New
5562         member variable.
5563         (default_is_string_type_p): Declare new function.
5564         * m2-lang.c (m2_language_defn): Initialise new field.
5565         * objc-lang.c (objc_language_defn): Initialise new field.
5566         * opencl-lang.c (opencl_language_defn): Initialise new field.
5567         * p-lang.c (pascal_is_string_type_p): New function.
5568         (pascal_language_defn): Initialise new field.
5569         * rust-lang.c (rust_is_string_type_p): New function.
5570         (rust_language_defn): Initialise new field.
5571
5572 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5573
5574         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5575         New field.
5576         * ada-lang.c (ada_language_defn): Initialise new field.
5577         * c-lang.c (c_language_defn): Likewise.
5578         (cplus_language_defn): Likewise.
5579         (asm_language_defn): Likewise.
5580         (minimal_language_defn): Likewise.
5581         * d-lang.c (d_language_defn): Likewise.
5582         * f-lang.c (f_language_defn): Likewise.
5583         * go-lang.c (go_language_defn): Likewise.
5584         * language.c (unknown_language_defn): Likewise.
5585         (auto_language_defn): Likewise.
5586         * m2-lang.c (m2_language_defn): Likewise.
5587         * objc-lang.c (objc_language_defn): Likewise.
5588         * opencl-lang.c (opencl_language_defn): Likewise.
5589         * p-lang.c (pascal_language_defn): Likewise.
5590         * rust-lang.c (rust_language_defn): Likewise.
5591
5592 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5593
5594         * ada-lang.c (ada_is_character_type): Change return type to bool.
5595         (ada_is_string_type): Likewise.
5596         * ada-lang.h (ada_is_character_type): Update declaration
5597         (ada_is_string_type): Likewise.
5598
5599 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5600
5601         Support style in 'frame|thread apply'
5602
5603         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5604         * record.c (record_start, record_stop): Update callers of
5605         execute_command_to_string with false.
5606         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5607         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5608         methods.
5609         (class string_file): New constructor with term_out parameter.
5610         Override methods term_out and can_emit_style_escape.  New member
5611         term_out.
5612         (class stdio_file): Override can_emit_style_escape.
5613         (class tee_file): Override term_out and can_emit_style_escape.
5614         * utils.h (can_emit_style_escape): Remove.
5615         * utils.c (can_emit_style_escape): Likewise.
5616         Update all callers of can_emit_style_escape (SOMESTREAM) to
5617         SOMESTREAM->can_emit_style_escape.
5618         * source-cache.c (source_cache::get_source_lines): Likewise.
5619         * stack.c (frame_apply_command_count): Call execute_command_to_string
5620         passing the term_out characteristic of the current gdb_stdout.
5621         * thread.c (thr_try_catch_cmd): Likewise.
5622         * top.c (execute_command_to_string): pass term_out parameter
5623         to construct the string_file for the command output.
5624         * ui-file.c (term_cli_styling): New function (most code moved
5625         from utils.c can_emit_style_escape).
5626         (string_file::string_file, string_file::can_emit_style_escape,
5627         stdio_file::can_emit_style_escape, tee_file::term_out,
5628         tee_file::can_emit_style_escape): New functions.
5629
5630 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5631
5632         * NEWS: Mention the new set|show may-call-functions.
5633         * infcall.c (may_call_functions_p): New variable.
5634         (show_may_call_functions_p): New function.
5635         (call_function_by_hand_dummy): Throws an error if not
5636         may-call-functions.
5637         (_initialize_infcall): Call add_setshow_boolean_cmd for
5638         may-call-functions.
5639
5640 2019-04-25  Keith Seitz  <keiths@redhat.com>
5641
5642         PR c++/24367
5643         * cp-support.c (inspect_type): Don't attempt substitutions
5644         of symbol with the same name.
5645
5646 2019-04-25  Tom Tromey  <tromey@adacore.com>
5647
5648         PR gdb/24475:
5649         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5650         static.
5651
5652 2019-04-25  Tom Tromey  <tromey@adacore.com>
5653
5654         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5655         rvalue reference.
5656         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5657         (gdb_xml_parser::parse): Use std::move.
5658         * python/python-internal.h (gdbpy_convert_exception): Take a const
5659         reference.
5660         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5661         std::move.
5662         * python/py-utils.c (gdbpy_convert_exception): Take a const
5663         reference.
5664         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5665         Use std::move.
5666         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5667         Use std::move.
5668         * mi/mi-main.c (mi_print_exception): Take a const reference.
5669         * main.c (handle_command_errors): Take a const reference.
5670         * linespec.c (parse_linespec): Use std::move.
5671         * infcall.c (run_inferior_call): Use std::move.
5672         (call_function_by_hand_dummy): Use std::move.
5673         * exec.c (try_open_exec_file): Use std::move.
5674         * exceptions.h (exception_print, exception_fprintf)
5675         (exception_print_same): Update.
5676         * exceptions.c (print_exception, exception_print)
5677         (exception_fprintf, exception_print_same): Change parameters to
5678         const reference.
5679         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5680         * common/new-op.c: Use std::move.
5681         * common/common-exceptions.h (struct gdb_exception): Add move
5682         constructor.
5683         (struct gdb_exception_error, struct gdb_exception_quit, struct
5684         gdb_quit_bad_alloc): Change constructor to move constructor.
5685         (throw_exception): Change parameter to rvalue reference.
5686         * common/common-exceptions.c (throw_exception): Take rvalue
5687         reference.
5688         * cli/cli-interp.c (safe_execute_command): Use std::move.
5689         * breakpoint.c (insert_bp_location, location_to_sals): Use
5690         std::move.
5691
5692 2019-04-25  Tom Tromey  <tromey@adacore.com>
5693
5694         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5695         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5696         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5697         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5698         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5699         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5700         guile/scm-value.c: Use unpack.
5701         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5702         gdbscm_gdb_exception.
5703         (gdbscm_throw_gdb_exception): Likewise.
5704         (struct gdbscm_gdb_exception): New.
5705         (unpack): New function.
5706         (gdbscm_wrap): Use unpack.
5707
5708 2019-04-25  Tom Tromey  <tromey@adacore.com>
5709
5710         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5711         (gdb_rl_callback_handler): Use std::move.
5712         * common/common-exceptions.h (struct gdb_exception): Add move
5713         assignment operator.
5714         (throw_exception_sjlj): Change "exception" to const reference.
5715         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5716         (throw_exception_sjlj): Change "exception" to const reference.
5717
5718 2019-04-25  Tom Tromey  <tromey@adacore.com>
5719
5720         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5721         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5722         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5723         Update.
5724         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5725         Update.
5726         * mi/mi-interp.c (mi_interp::exec): Update.
5727         * linespec.c (parse_linespec): Update.
5728         * infcall.c (run_inferior_call): Update.
5729         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5730         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5731         (gdbscm_lookup_global_symbol): Update.
5732         * guile/scm-param.c (gdbscm_parameter_value): Update.
5733         * guile/scm-frame.c (gdbscm_frame_read_register)
5734         (gdbscm_frame_read_var): Update.
5735         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5736         * exec.c (try_open_exec_file): Update.
5737         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5738         (gdb_rl_callback_handler): Update.
5739         * common/common-exceptions.h (exception_none): Don't declare.
5740         * common/common-exceptions.c (exception_none): Don't define.
5741         (struct catcher) <exception>: Update.
5742         * cli/cli-interp.c (safe_execute_command): Update.
5743         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5744
5745 2019-04-25  Ali Tamur  <tamur@google.com>
5746
5747         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5748         (read_attribute_value): Likewise.
5749         (dwarf2_read_addr_index): Update comment.
5750         (read_str_index): Add DW_FORM_strx.
5751         (dwarf2_string_attr): Likewise.
5752         (dwarf2_const_value_attr): Likewise.
5753         (dump_die_shallow): Likewise.
5754         (dwarf2_fetch_constant_bytes): Likewise.
5755         (skip_form_bytes): Likewise.
5756         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5757
5758 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5759
5760         PR corefiles/11608
5761         PR corefiles/18187
5762         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5763         OFFSET.  Verify if current mapping contains an ELF header.
5764         (linux_find_memory_regions_full): Adjust call to
5765         dump_mapping_p.
5766
5767 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5768             Kang Li <kanglictf@gmail.com>
5769
5770         PR gdb/21600
5771
5772         * dwarf2-frame.c (read_initial_length): Be consistent about using
5773         unsigned representation of length.
5774         (decode_frame_entry_1): Likewise.  Check for wraparound of
5775         end pointer as well as buffer overflow.
5776
5777 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5778
5779         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5780         "vq".
5781
5782 2019-04-24  Tom Tromey  <tromey@adacore.com>
5783
5784         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5785
5786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5787
5788         * s12z-tdep.c (s12z_unwind_pc): Delete.
5789         (s12z_unwind_sp): Delete.
5790         (s12z_gdbarch_init): Don't register deleted functions with
5791         gdbarch.
5792
5793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5794
5795         * rl78-tdep.c (rl78_unwind_sp): Delete.
5796         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5797
5798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5799
5800         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5801         (xstormy16_unwind_pc): Delete.
5802         (xstormy16_dummy_id): Delete.
5803         (xstormy16_gdbarch_init): Don't register deleted functions with
5804         gdbarch.
5805
5806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * vax-tdep.c (vax_unwind_pc): Delete.
5809         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5810
5811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5812
5813         * v850-tdep.c (v850_unwind_sp): Delete.
5814         (v850_unwind_pc): Delete.
5815         (v850_dummy_id): Delete.
5816         (v850_gdbarch_init): Don't register deleted functions with
5817         gdbarch.
5818
5819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5820
5821         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5822         (tilegx_unwind_pc): Delete.
5823         (tilegx_unwind_dummy_id): Delete.
5824         (tilegx_gdbarch_init): Don't register deleted functions with
5825         gdbarch.
5826
5827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5828
5829         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5830         (tic6x_dummy_id): Delete.
5831         (tic6x_gdbarch_init): Don't register deleted functions with
5832         gdbarch.
5833
5834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5835
5836         * sparc-tdep.c (sparc_unwind_pc): Delete.
5837         (sparc32_gdbarch_init): Don't register deleted function with
5838         gdbarch.
5839
5840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5841
5842         * sh-tdep.c (sh_unwind_sp): Delete.
5843         (sh_unwind_pc): Delete.
5844         (sh_dummy_id): Delete.
5845         (sh_gdbarch_init): Don't register deleted functions with
5846         gdbarch.
5847
5848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5849
5850         * score-tdep.c (score_unwind_sp): Delete.
5851         (score_unwind_pc): Delete.
5852         (score_dummy_id): Delete.
5853         (score_gdbarch_init): Don't register deleted functions with
5854         gdbarch.
5855
5856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5857
5858         * rx-tdep.c (rx_unwind_pc): Delete.
5859         (rx_unwind_sp): Delete.
5860         (rx_dummy_id): Delete.
5861         (rx_gdbarch_init): Don't register deleted functions with
5862         gdbarch.  Update comment.
5863
5864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5865
5866         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5867         (rs6000_dummy_id): Delete.
5868         (rs6000_gdbarch_init): Don't register deleted functions with
5869         gdbarch.
5870
5871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5872
5873         * or1k-tdep.c (or1k_dummy_id): Delete.
5874         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5875
5876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5877
5878         * nios2-tdep.c (nios2_dummy_id): Delete.
5879         (nios2_unwind_sp): Delete.
5880         (nios2_gdbarch_init): Don't register deleted functions with
5881         gdbarch.
5882
5883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5884
5885         * nds32-tdep.c (nds32_dummy_id): Delete.
5886         (nds32_unwind_pc): Delete.
5887         (nds32_unwind_sp): Delete.
5888         (nds32_gdbarch_init): Don't register deleted functions with
5889         gdbarch.
5890
5891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5892
5893         * msp430-tdep.c (msp430_unwind_pc): Delete.
5894         (msp430_unwind_sp): Delete.
5895         (msp430_dummy_id): Delete.
5896         (msp430_gdbarch_init): Don't register deleted functions with
5897         gdbarch.
5898
5899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5900
5901         * moxie-tdep.c (moxie_unwind_sp): Delete.
5902         (moxie_unwind_pc): Delete.
5903         (moxie_dummy_id): Delete.
5904         (moxie_gdbarch_init): Don't register deleted functions with
5905         gdbarch.
5906
5907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5908
5909         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5910         (mn10300_unwind_pc): Delete.
5911         (mn10300_unwind_sp): Delete.
5912         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5913         mn10300_unwind_sp.
5914         (mn10300_frame_unwind_init): Don't register deleted functions with
5915         gdbarch.
5916
5917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5918
5919         * mep-tdep.c (mep_unwind_pc): Delete.
5920         (mep_unwind_sp): Delete.
5921         (mep_dummy_id): Delete.
5922         (mep_gdbarch_init): Don't register deleted functions with
5923         gdbarch.
5924
5925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5928         (m68hc11_unwind_sp): Delete.
5929         (m68hc11_gdbarch_init): Don't register deleted functions with
5930         gdbarch.
5931
5932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         * m32r-tdep.c (m32r_unwind_sp): Delete.
5935         (m32r_unwind_pc): Delete.
5936         (m32r_dummy_id): Delete.
5937         (m32r_gdbarch_init): Don't register deleted functions with
5938         gdbarch.
5939
5940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * m32c-tdep.c (m32c_unwind_pc): Delete.
5943         (m32c_unwind_sp): Delete.
5944         (m32c_dummy_id): Delete.
5945         (m32c_gdbarch_init): Don't register deleted functions with
5946         gdbarch.
5947
5948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5951         (lm32_unwind_pc): Delete.
5952         (lm32_dummy_id): Delete.
5953         (lm32_gdbarch_init): Don't register deleted functions with
5954         gdbarch.
5955
5956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5957
5958         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5959         (iq2000_unwind_pc): Delete.
5960         (iq2000_dummy_id): Delete.
5961         (iq2000_gdbarch_init): Don't register deleted functions with
5962         gdbarch.
5963
5964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5965
5966         * nds32-tdep.c (nds32_type_align): Delete.
5967         (nds32_push_dummy_call): Use type_align instead.
5968
5969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5970
5971         * arm-tdep.c (arm_type_align): Only handle vector override case.
5972         (arm_push_dummy_call): Use type_align.
5973         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5974
5975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5976
5977         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5978         case.
5979         (pass_on_stack): Use type_align.
5980         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5981         function.
5982
5983 2019-04-23  Tom Tromey  <tromey@adacore.com>
5984
5985         * dwarf2read.c (line_header::file_name_at): Remove unused
5986         overload.
5987
5988 2019-04-23  Tom de Vries  <tdevries@suse.de>
5989
5990         PR gdb/24438
5991         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5992         invocation.
5993
5994
5995 2019-03-27  Ali Tamur  <tamur@google.com>
5996
5997         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5998         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5999         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6000         (dwarf_expr_context::get_addr_index): Likewise
6001         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6002         (symbol_needs_eval_context::get_addr_index): Likewise
6003         (disassemble_dwarf_expression): Add DW_OP_addrx
6004         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6005         (read_cutu_die_from_dwo): Update comment
6006         (skip_one_die): Add DW_FORM_addrx
6007         (read_attribute_value): Likewise
6008         (var_decode_location): Add DW_OP_addrx
6009         (dwarf2_const_value_attr): Add DW_FORM_addrx
6010         (dump_die_shallow): Likewise
6011         (dwarf2_fetch_constant_bytes): Likewise
6012         (decode_locdesc): Add DW_OP_addrx
6013         (skip_form_bytes): Add DW_FORM_addrx
6014
6015 2019-04-22  Ali Tamur  <tamur@google.com>
6016
6017         * MAINTAINERS (Write After Approval): Add self.
6018
6019 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6020
6021         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6022         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6023         (open_symbol_file_object): Likewise.
6024         (svr4_default_sos): Add info parameter.
6025         (svr4_read_so_list): Likewise.
6026         (svr4_current_sos_direct): Adjust functions calls to pass down
6027         info.
6028         (svr4_current_sos_1): Add info parameter.
6029         (svr4_current_sos): Call get_svr4_info, pass info down to
6030         svr4_current_sos_1.
6031         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6032         get_svr4_info.
6033         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6034         get_svr4_info.
6035         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6036         to get_svr4_info.
6037         (probes_table_remove_objfile_probes): Likewise.
6038         (register_solib_event_probe): Add info parameter.
6039         (solist_update_incremental): Pass info parameter down to
6040         svr4_read_so_list.
6041         (disable_probes_interface): Add info parameter.
6042         (svr4_handle_solib_event): Pass current_program_space to
6043         get_svr4_info.  Adjust disable_probes_interface cleanup.
6044         (svr4_create_probe_breakpoints): Add info parameter, pass it
6045         down to register_solib_event_probe.
6046         (svr4_create_solib_event_breakpoints): Add info parameter,
6047         pass it down to svr4_create_probe_breakpoints.
6048         (enable_break): Pass info down to
6049         svr4_create_solib_event_breakpoints.
6050         (svr4_solib_create_inferior_hook): Pass current_program_space to
6051         get_svr4_info.
6052         (svr4_clear_solib): Likewise.
6053
6054 2019-04-22  Pedro Alves  <palves@redhat.com>
6055
6056         * solib-svr4.c (svr4_free_objfile_observer): New.
6057         (probe_and_action::objfile): New field.
6058         (probes_table_htab_remove_objfile_probes)
6059         (probes_table_remove_objfile_probes): New functions.
6060         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6061         in the new probe_and_action.  Don't store the probe in 'lookup'.
6062         (svr4_create_probe_breakpoints): Pass objfile to
6063         register_solib_event_probe.
6064         (_initialize_svr4_solib): Register a free_objfile observer.
6065
6066 2019-04-19  Tom Tromey  <tom@tromey.com>
6067
6068         * common/queue.h: Remove.
6069
6070 2019-04-19  Tom Tromey  <tom@tromey.com>
6071
6072         * event-loop.c: Don't include "common/queue.h".
6073
6074 2019-04-19  Tom Tromey  <tom@tromey.com>
6075
6076         * remote.c (remote_target): Use delete.
6077         * remote-notif.h: Include <list>, not "common/queue.h".
6078         (notif_client_p): Remove typedef.
6079         (remote_notif_state): Add constructor, destructor, initializer.
6080         <notif_queue>: Now a std::list.
6081         (remote_notif_state_xfree): Don't declare.
6082         * remote-notif.c (remote_notif_process, handle_notification)
6083         (remote_notif_state_allocate): Update.
6084         (~remote_notif_state): Rename from remote_notif_state_xfree.
6085
6086 2019-04-19  Tom Tromey  <tom@tromey.com>
6087
6088         * symfile.c (reread_symbols): Update.
6089         * objfiles.c (objfile_register_static_link)
6090         (objfile_lookup_static_link): Update
6091         (~objfile) Don't delete static_links.
6092         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6093
6094 2019-04-19  Tom Tromey  <tom@tromey.com>
6095
6096         * type-stack.h (struct type_stack) <insert>: Constify string.
6097         * type-stack.c (type_stack::insert): Constify string.
6098         * gdbtypes.h (lookup_template_type): Update.
6099         (address_space_name_to_int): Update.
6100         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6101         const.
6102         (lookup_template_type): Make name const.
6103         * c-exp.y: Update rules.
6104         (lex_one_token, classify_name, classify_inner_name)
6105         (c_print_token): Update.
6106         * p-exp.y: Update rules.
6107         (yylex): Update.
6108         * f-exp.y: Update rules.
6109         (yylex): Update.
6110         * d-exp.y: Update rules.
6111         (lex_one_token, classify_name, classify_inner_name): Update.
6112         * parse.c (write_dollar_variable, copy_name): Return std::string.
6113         * parser-defs.h (copy_name): Change return type.
6114         * m2-exp.y: Update rules.
6115         (yylex): Update.
6116         * go-exp.y (lex_one_token): Update.
6117         Update rules.
6118         (classify_unsafe_function, classify_packaged_name)
6119         (classify_name, yylex): Update.
6120
6121 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6122
6123         * configure.ac: add --enable-source-highlight switch.
6124         * configure: Regenerate.
6125         * top.c (print_gdb_version): plumb --enable-source-highlight
6126         status to "show configuration".
6127
6128 2019-04-19  Tom Tromey  <tromey@adacore.com>
6129
6130         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6131         Check ADA_TYPE_P.
6132         (empty_record, ada_template_to_fixed_record_type_1)
6133         (template_to_static_fixed_type)
6134         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6135         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6136         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6137         macros.
6138
6139 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6140
6141         PR symtab/24423:
6142         * source.c (print_source_lines_base): Advance "iter" when a
6143         control character is seen.
6144
6145 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6146
6147         * inferior.h (struct infcall_suspend_state_deleter):
6148         Catch exception in destructor to avoid crash.
6149
6150 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6151
6152         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6153         close to the add_com "shell".
6154
6155 2019-04-18  Tom Tromey  <tromey@adacore.com>
6156
6157         * process-stratum-target.h (class process_stratum_target)
6158         <stratum>: Add "final".
6159
6160 2019-04-17  Tom Tromey  <tromey@adacore.com>
6161
6162         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6163         against nullptr before use.
6164
6165 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6166
6167         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6168
6169 2019-04-17  Jim Wilson  <jimw@sifive.com>
6170             Andrew Burgess  <andrew.burgess@embecosm.com>
6171
6172         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6173         code read might fail, assume 4-byte breakpoint in that case.
6174
6175 2019-04-15  Leszek Swirski  <leszeks@google.com>
6176
6177         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6178         rather than a hand-rolled POD check when checking for forced MEMORY
6179         classification.
6180
6181 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6182
6183         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6184         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6185         function.
6186         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6187         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6188         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6189         declaration.
6190
6191 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6192
6193         * aarch64-linux-nat.c
6194         (aarch64_linux_nat_target::thread_architecture): Add override.
6195         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6196         each VQ.
6197
6198 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6199
6200         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6201
6202 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6205         target types of size 96-bits, add some additional comments, and
6206         check that the builtin type we found was the correct size.
6207
6208 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6209
6210         * utils.c (prompt_for_continue): Don't restore the styling at the
6211         end, as applied_style has the wrong value.  This fixes styling in
6212         long lists of file names that are interrupted by the "Continue?"
6213         prompt.
6214
6215 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6218         * c-lang.c (c_language_defn): Likewise.
6219         (cplus_language_defn): Likewise.
6220         (asm_language_defn): Likewise.
6221         (minimal_language_defn): Likewise.
6222         * d-lang.c (d_language_defn): Likewise.
6223         * f-lang.c (f_language_defn): Likewise.
6224         * go-lang.c (go_language_defn): Likewise.
6225         * language.c (unknown_language_defn): Likewise.
6226         (auto_language_defn): Likewise.
6227         * language.h (struct language_defn): Remove la_magic field.
6228         (LANG_MAGIC): Delete.
6229         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6230         * objc-lang.c (objc_language_defn): Likewise.
6231         * opencl-lang.c (opencl_language_defn): Likewise.
6232         * p-lang.c (pascal_language_defn): Likewise.
6233         * rust-lang.c (rust_language_defn): Likewise.
6234
6235 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6236
6237         * riscv-tdep.c (riscv_type_align): New function.
6238         (riscv_type_alignment): Delete.
6239         (riscv_arg_location): Use 'type_align'.
6240         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6241
6242 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * gdbtypes.c (type_align): A struct with no non-static fields also
6245         has alignment of 1.
6246
6247 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6250         component to 0.
6251         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6252         member.
6253         (riscv_struct_info::analyse): New implementation using new
6254         analyse_inner member function.
6255         (riscv_struct_info::field_offset): New member function.
6256         (riscv_struct_info::m_offsets): New member variable.
6257         (riscv_struct_info::analyse_inner): New private member function,
6258         takes the old implementation of riscv_struct_info::analyse but
6259         extended to track field offsets.
6260         (riscv_call_arg_struct): Update the struct folding special cases
6261         to handle cases where empty C++ structs, which are non-zero
6262         length, are found.
6263         (riscv_arg_location): Initialise the length of each location, a
6264         non-zero length now indicates the location is in use.
6265         (riscv_push_dummy_call): Allow for the first location having a
6266         non-zero offset when setting up arguments.
6267         (riscv_return_value): Likewise, but for return values.
6268
6269 2019-04-11  Tom Tromey  <tromey@adacore.com>
6270
6271         * utils.c (internal_vproblem): Make "msg" const.
6272
6273 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6274
6275         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6276         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6277         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6278         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6279
6280 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6281
6282         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6283         function.
6284         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6285         of amd64_collect_native_gregset.
6286         (amd64_linux_nat_target::store_registers): Likewise.
6287
6288 2019-04-10  Tom Tromey  <tom@tromey.com>
6289
6290         * symtab.c (lookup_global_symbol_from_objfile)
6291         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6292         * objfiles.h (class separate_debug_iterator): New.
6293         (class separate_debug_range): New.
6294         (struct objfile) <separate_debug_objfiles>: New method.
6295         (objfile_separate_debug_iterate): Don't declare.
6296         * objfiles.c (separate_debug_iterator::operator++): Rename from
6297         objfile_separate_debug_iterate.
6298         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6299         iterator.
6300         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6301         iterator.
6302
6303 2019-04-10  Tom Tromey  <tom@tromey.com>
6304
6305         * symfile.c (reread_symbols): Remove old comment.
6306         * objfiles.c (free_all_objfiles): Fix a typo.
6307
6308 2019-04-10  Tom Tromey  <tom@tromey.com>
6309
6310         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6311         * minsyms.c (lookup_minimal_symbol): Use foreach.
6312         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6313         (lookup_minimal_symbol_solib_trampoline): Likewise.
6314         * symfile.c (reread_symbols): Use foreach.
6315
6316 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6317             Tom Tromey  <tromey@adacore.com>
6318
6319         PR rust/24414:
6320         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6321         (rust_lex_int_test): Change "value" to be LONGEST.
6322         (rust_lex_tests): Add test for long integer literal.
6323
6324 2019-04-09  Tom Tromey  <tromey@adacore.com>
6325
6326         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6327         to bool.
6328         (extended_remote_target::attach): Update.
6329         (remote_target::remote_notice_new_inferior): Update.
6330         (remote_target::add_current_inferior_and_thread): Update.
6331         * inferior.c (exit_inferior_1): Use "false".
6332         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6333
6334 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6335
6336         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6337         the "start" command.
6338
6339 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6340
6341         * python/py-inferior.c (infpy_thread_from_thread_handle):
6342         Adjust comments to reflect renaming of thread_from_thread_handle
6343         to thread_from_handle.  Adjust keywords.  Fix type error message.
6344         (inferior_object_methods): Add thread_from_handle.  Retain
6345         thread_from_thread_handle, but mark it as deprecated.
6346
6347 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6348
6349         * gdbthread.h (find_thread_by_handle): Revise declaration.
6350         * thread.c (find_thread_by_handle): Likewise.  Adjust
6351         implementation too.
6352         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6353         support for buffer objects as handles.
6354
6355 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6356
6357         * python/py-infthread.c (thpy_thread_handle): New function.
6358         (thread_object_methods): Register thpy_thread_handle.
6359
6360 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6361
6362         * gdbthread.h (thread_to_thread_handle): Declare.
6363         * thread.c (gdbtypes.h): Include.
6364         (thread_to_thread_handle): New function.
6365
6366         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6367         (target_thread_info_to_thread_handle): Declare.
6368         * target.c (target_thread_info_to_thread_handle): New function.
6369         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6370         * target-delegates.c: Regenerate.
6371
6372         * linux-thread-db.c (class thread_db_target): Add method
6373         thread_info_to_thread_handle.
6374         (thread_db_target::thread_info_to_thread_handle): Define.
6375         * remote.c (class remote_target): Add new method
6376         thread_info_to_thread_handle.
6377         (remote_target::thread_info_to_thread_handle): Define.
6378
6379 2019-04-08  Pedro Alves  <palves@redhat.com>
6380
6381         * common/common-exceptions.c (throw_exception): Don't create
6382         named object to throw; throw directly.
6383         (throw_it): Likewise.  Don't initialize gdb_exception::message
6384         here, with new; pass FMT and AP to the ctor instead.
6385         * common/common-exceptions.h: Include <string>.
6386         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6387         const char *, va_list)): New ctor.  Use std::make_shared.
6388         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6389         errors)): Delete.
6390         (gdb_exception_error::gdb_exception_error(enum errors, const char
6391         *, va_list)): New.
6392         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6393         Add assertion.
6394         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6395         errors)): Delete.
6396         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6397         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6398         Add assertion.
6399
6400 2019-04-08  Tom Tromey  <tom@tromey.com>
6401
6402         * valops.c (value_rtti_indirect_type): Replace throw_exception
6403         with throw.
6404         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6405         with throw.
6406         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6407         throw.
6408         * target.c (target_translate_tls_address): Replace throw_exception
6409         with throw.
6410         * stack.c (frame_apply_command_count): Replace throw_exception
6411         with throw.
6412         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6413         throw.
6414         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6415         with throw.
6416         * rs6000-tdep.c (rs6000_frame_cache)
6417         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6418         * remote.c: Replace throw_exception with throw.
6419         * record-full.c (record_full_message, record_full_wait_1)
6420         (record_full_restore): Replace throw_exception with throw.
6421         * record-btrace.c:
6422         (get_thread_current_frame_id, record_btrace_start_replaying)
6423         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6424         (cmd_record_btrace_start): Replace throw_exception with throw.
6425         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6426         throw.
6427         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6428         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6429         * linespec.c:
6430         (find_linespec_symbols): Replace throw_exception with throw.
6431         * infrun.c (displaced_step_prepare, resume): Replace
6432         throw_exception with throw.
6433         * infcmd.c (post_create_inferior): Replace throw_exception with
6434         throw.
6435         * inf-loop.c (inferior_event_handler): Replace throw_exception
6436         with throw.
6437         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6438         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6439         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6440         (get_prev_frame_always, get_frame_pc_if_available)
6441         (get_frame_address_in_block_if_available, get_frame_language):
6442         Replace throw_exception with throw.
6443         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6444         throw_exception with throw.
6445         * eval.c (fetch_subexp_value, evaluate_var_value)
6446         (evaluate_funcall, evaluate_subexp_standard): Replace
6447         throw_exception with throw.
6448         * dwarf2loc.c (call_site_find_chain)
6449         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6450         Replace throw_exception with throw.
6451         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6452         with throw.
6453         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6454         throw.
6455         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6456         * completer.c (complete_line_internal): Replace throw_exception
6457         with throw.
6458         * compile/compile-object-run.c (compile_object_run): Replace
6459         throw_exception with throw.
6460         * cli/cli-script.c (process_next_line): Replace throw_exception
6461         with throw.
6462         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6463         (btrace_enable, btrace_maint_update_pt_packets): Replace
6464         throw_exception with throw.
6465         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6466         throw_exception with throw.
6467         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6468         throw_exception with throw.
6469         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6470         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6471         * aarch64-tdep.c (aarch64_make_prologue_cache)
6472         (aarch64_make_stub_cache): Replace throw_exception with throw.
6473
6474 2019-04-08  Tom Tromey  <tom@tromey.com>
6475
6476         * common/common-exceptions.c (throw_exception): Rename from
6477         throw_exception_cxx.  Remove old copy.  Make argument const.
6478         (throw_it): Create and throw exception objects directly.
6479         * common/common-exceptions.h (throw_exception): Make argument
6480         const.
6481         (struct gdb_exception_error): Add constructor.
6482         (struct gdb_exception_quit): Add constructor.
6483
6484 2019-04-08  Tom Tromey  <tom@tromey.com>
6485
6486         * common/common-exceptions.h (exception_rethrow): Don't declare.
6487         (TRY_SJLJ): Update comment.
6488         (TRY, CATCH, END_CATCH): Remove.
6489         * common/common-exceptions.c (exception_rethrow): Remove.
6490
6491 2019-04-08  Tom Tromey  <tom@tromey.com>
6492
6493         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6494         Remove.
6495         (gdb_exception_error): Rename from
6496         gdb_exception_RETURN_MASK_ERROR.
6497         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6498         (gdb_quit_bad_alloc): Update.
6499         * aarch64-tdep.c: Update.
6500         * ada-lang.c: Update.
6501         * ada-typeprint.c: Update.
6502         * ada-valprint.c: Update.
6503         * amd64-tdep.c: Update.
6504         * arch-utils.c: Update.
6505         * break-catch-throw.c: Update.
6506         * breakpoint.c: Update.
6507         * btrace.c: Update.
6508         * c-varobj.c: Update.
6509         * cli/cli-cmds.c: Update.
6510         * cli/cli-interp.c: Update.
6511         * cli/cli-script.c: Update.
6512         * common/common-exceptions.c: Update.
6513         * common/new-op.c: Update.
6514         * common/selftest.c: Update.
6515         * compile/compile-c-symbols.c: Update.
6516         * compile/compile-cplus-symbols.c: Update.
6517         * compile/compile-object-load.c: Update.
6518         * compile/compile-object-run.c: Update.
6519         * completer.c: Update.
6520         * corelow.c: Update.
6521         * cp-abi.c: Update.
6522         * cp-support.c: Update.
6523         * cp-valprint.c: Update.
6524         * darwin-nat.c: Update.
6525         * disasm-selftests.c: Update.
6526         * dtrace-probe.c: Update.
6527         * dwarf-index-cache.c: Update.
6528         * dwarf-index-write.c: Update.
6529         * dwarf2-frame-tailcall.c: Update.
6530         * dwarf2-frame.c: Update.
6531         * dwarf2loc.c: Update.
6532         * dwarf2read.c: Update.
6533         * eval.c: Update.
6534         * event-loop.c: Update.
6535         * event-top.c: Update.
6536         * exec.c: Update.
6537         * f-valprint.c: Update.
6538         * fbsd-tdep.c: Update.
6539         * frame-unwind.c: Update.
6540         * frame.c: Update.
6541         * gdbtypes.c: Update.
6542         * gnu-v3-abi.c: Update.
6543         * guile/guile-internal.h: Update.
6544         * guile/scm-block.c: Update.
6545         * guile/scm-breakpoint.c: Update.
6546         * guile/scm-cmd.c: Update.
6547         * guile/scm-disasm.c: Update.
6548         * guile/scm-frame.c: Update.
6549         * guile/scm-lazy-string.c: Update.
6550         * guile/scm-math.c: Update.
6551         * guile/scm-param.c: Update.
6552         * guile/scm-ports.c: Update.
6553         * guile/scm-pretty-print.c: Update.
6554         * guile/scm-symbol.c: Update.
6555         * guile/scm-symtab.c: Update.
6556         * guile/scm-type.c: Update.
6557         * guile/scm-value.c: Update.
6558         * i386-linux-tdep.c: Update.
6559         * i386-tdep.c: Update.
6560         * inf-loop.c: Update.
6561         * infcall.c: Update.
6562         * infcmd.c: Update.
6563         * infrun.c: Update.
6564         * jit.c: Update.
6565         * language.c: Update.
6566         * linespec.c: Update.
6567         * linux-fork.c: Update.
6568         * linux-nat.c: Update.
6569         * linux-tdep.c: Update.
6570         * linux-thread-db.c: Update.
6571         * main.c: Update.
6572         * mi/mi-cmd-break.c: Update.
6573         * mi/mi-cmd-stack.c: Update.
6574         * mi/mi-interp.c: Update.
6575         * mi/mi-main.c: Update.
6576         * objc-lang.c: Update.
6577         * p-valprint.c: Update.
6578         * parse.c: Update.
6579         * ppc-linux-tdep.c: Update.
6580         * printcmd.c: Update.
6581         * python/py-arch.c: Update.
6582         * python/py-breakpoint.c: Update.
6583         * python/py-cmd.c: Update.
6584         * python/py-finishbreakpoint.c: Update.
6585         * python/py-frame.c: Update.
6586         * python/py-framefilter.c: Update.
6587         * python/py-gdb-readline.c: Update.
6588         * python/py-inferior.c: Update.
6589         * python/py-infthread.c: Update.
6590         * python/py-lazy-string.c: Update.
6591         * python/py-linetable.c: Update.
6592         * python/py-objfile.c: Update.
6593         * python/py-param.c: Update.
6594         * python/py-prettyprint.c: Update.
6595         * python/py-progspace.c: Update.
6596         * python/py-record-btrace.c: Update.
6597         * python/py-record.c: Update.
6598         * python/py-symbol.c: Update.
6599         * python/py-type.c: Update.
6600         * python/py-unwind.c: Update.
6601         * python/py-utils.c: Update.
6602         * python/py-value.c: Update.
6603         * python/python.c: Update.
6604         * record-btrace.c: Update.
6605         * record-full.c: Update.
6606         * remote-fileio.c: Update.
6607         * remote.c: Update.
6608         * riscv-tdep.c: Update.
6609         * rs6000-aix-tdep.c: Update.
6610         * rs6000-tdep.c: Update.
6611         * rust-exp.y: Update.
6612         * rust-lang.c: Update.
6613         * s390-tdep.c: Update.
6614         * selftest-arch.c: Update.
6615         * solib-dsbt.c: Update.
6616         * solib-frv.c: Update.
6617         * solib-spu.c: Update.
6618         * solib-svr4.c: Update.
6619         * solib.c: Update.
6620         * sparc64-linux-tdep.c: Update.
6621         * stack.c: Update.
6622         * symfile-mem.c: Update.
6623         * symmisc.c: Update.
6624         * target.c: Update.
6625         * thread.c: Update.
6626         * top.c: Update.
6627         * tracefile-tfile.c: Update.
6628         * tui/tui.c: Update.
6629         * typeprint.c: Update.
6630         * unittests/cli-utils-selftests.c: Update.
6631         * unittests/parse-connection-spec-selftests.c: Update.
6632         * valops.c: Update.
6633         * valprint.c: Update.
6634         * value.c: Update.
6635         * varobj.c: Update.
6636         * windows-nat.c: Update.
6637         * x86-linux-nat.c: Update.
6638         * xml-support.c: Update.
6639
6640 2019-04-08  Tom Tromey  <tom@tromey.com>
6641
6642         * xml-support.c: Use C++ exception handling.
6643         * x86-linux-nat.c: Use C++ exception handling.
6644         * windows-nat.c: Use C++ exception handling.
6645         * varobj.c: Use C++ exception handling.
6646         * value.c: Use C++ exception handling.
6647         * valprint.c: Use C++ exception handling.
6648         * valops.c: Use C++ exception handling.
6649         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6650         handling.
6651         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6652         * typeprint.c: Use C++ exception handling.
6653         * tui/tui.c: Use C++ exception handling.
6654         * tracefile-tfile.c: Use C++ exception handling.
6655         * top.c: Use C++ exception handling.
6656         * thread.c: Use C++ exception handling.
6657         * target.c: Use C++ exception handling.
6658         * symmisc.c: Use C++ exception handling.
6659         * symfile-mem.c: Use C++ exception handling.
6660         * stack.c: Use C++ exception handling.
6661         * sparc64-linux-tdep.c: Use C++ exception handling.
6662         * solib.c: Use C++ exception handling.
6663         * solib-svr4.c: Use C++ exception handling.
6664         * solib-spu.c: Use C++ exception handling.
6665         * solib-frv.c: Use C++ exception handling.
6666         * solib-dsbt.c: Use C++ exception handling.
6667         * selftest-arch.c: Use C++ exception handling.
6668         * s390-tdep.c: Use C++ exception handling.
6669         * rust-lang.c: Use C++ exception handling.
6670         * rust-exp.y: Use C++ exception handling.
6671         * rs6000-tdep.c: Use C++ exception handling.
6672         * rs6000-aix-tdep.c: Use C++ exception handling.
6673         * riscv-tdep.c: Use C++ exception handling.
6674         * remote.c: Use C++ exception handling.
6675         * remote-fileio.c: Use C++ exception handling.
6676         * record-full.c: Use C++ exception handling.
6677         * record-btrace.c: Use C++ exception handling.
6678         * python/python.c: Use C++ exception handling.
6679         * python/py-value.c: Use C++ exception handling.
6680         * python/py-utils.c: Use C++ exception handling.
6681         * python/py-unwind.c: Use C++ exception handling.
6682         * python/py-type.c: Use C++ exception handling.
6683         * python/py-symbol.c: Use C++ exception handling.
6684         * python/py-record.c: Use C++ exception handling.
6685         * python/py-record-btrace.c: Use C++ exception handling.
6686         * python/py-progspace.c: Use C++ exception handling.
6687         * python/py-prettyprint.c: Use C++ exception handling.
6688         * python/py-param.c: Use C++ exception handling.
6689         * python/py-objfile.c: Use C++ exception handling.
6690         * python/py-linetable.c: Use C++ exception handling.
6691         * python/py-lazy-string.c: Use C++ exception handling.
6692         * python/py-infthread.c: Use C++ exception handling.
6693         * python/py-inferior.c: Use C++ exception handling.
6694         * python/py-gdb-readline.c: Use C++ exception handling.
6695         * python/py-framefilter.c: Use C++ exception handling.
6696         * python/py-frame.c: Use C++ exception handling.
6697         * python/py-finishbreakpoint.c: Use C++ exception handling.
6698         * python/py-cmd.c: Use C++ exception handling.
6699         * python/py-breakpoint.c: Use C++ exception handling.
6700         * python/py-arch.c: Use C++ exception handling.
6701         * printcmd.c: Use C++ exception handling.
6702         * ppc-linux-tdep.c: Use C++ exception handling.
6703         * parse.c: Use C++ exception handling.
6704         * p-valprint.c: Use C++ exception handling.
6705         * objc-lang.c: Use C++ exception handling.
6706         * mi/mi-main.c: Use C++ exception handling.
6707         * mi/mi-interp.c: Use C++ exception handling.
6708         * mi/mi-cmd-stack.c: Use C++ exception handling.
6709         * mi/mi-cmd-break.c: Use C++ exception handling.
6710         * main.c: Use C++ exception handling.
6711         * linux-thread-db.c: Use C++ exception handling.
6712         * linux-tdep.c: Use C++ exception handling.
6713         * linux-nat.c: Use C++ exception handling.
6714         * linux-fork.c: Use C++ exception handling.
6715         * linespec.c: Use C++ exception handling.
6716         * language.c: Use C++ exception handling.
6717         * jit.c: Use C++ exception handling.
6718         * infrun.c: Use C++ exception handling.
6719         * infcmd.c: Use C++ exception handling.
6720         * infcall.c: Use C++ exception handling.
6721         * inf-loop.c: Use C++ exception handling.
6722         * i386-tdep.c: Use C++ exception handling.
6723         * i386-linux-tdep.c: Use C++ exception handling.
6724         * guile/scm-value.c: Use C++ exception handling.
6725         * guile/scm-type.c: Use C++ exception handling.
6726         * guile/scm-symtab.c: Use C++ exception handling.
6727         * guile/scm-symbol.c: Use C++ exception handling.
6728         * guile/scm-pretty-print.c: Use C++ exception handling.
6729         * guile/scm-ports.c: Use C++ exception handling.
6730         * guile/scm-param.c: Use C++ exception handling.
6731         * guile/scm-math.c: Use C++ exception handling.
6732         * guile/scm-lazy-string.c: Use C++ exception handling.
6733         * guile/scm-frame.c: Use C++ exception handling.
6734         * guile/scm-disasm.c: Use C++ exception handling.
6735         * guile/scm-cmd.c: Use C++ exception handling.
6736         * guile/scm-breakpoint.c: Use C++ exception handling.
6737         * guile/scm-block.c: Use C++ exception handling.
6738         * guile/guile-internal.h: Use C++ exception handling.
6739         * gnu-v3-abi.c: Use C++ exception handling.
6740         * gdbtypes.c: Use C++ exception handling.
6741         * frame.c: Use C++ exception handling.
6742         * frame-unwind.c: Use C++ exception handling.
6743         * fbsd-tdep.c: Use C++ exception handling.
6744         * f-valprint.c: Use C++ exception handling.
6745         * exec.c: Use C++ exception handling.
6746         * event-top.c: Use C++ exception handling.
6747         * event-loop.c: Use C++ exception handling.
6748         * eval.c: Use C++ exception handling.
6749         * dwarf2read.c: Use C++ exception handling.
6750         * dwarf2loc.c: Use C++ exception handling.
6751         * dwarf2-frame.c: Use C++ exception handling.
6752         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6753         * dwarf-index-write.c: Use C++ exception handling.
6754         * dwarf-index-cache.c: Use C++ exception handling.
6755         * dtrace-probe.c: Use C++ exception handling.
6756         * disasm-selftests.c: Use C++ exception handling.
6757         * darwin-nat.c: Use C++ exception handling.
6758         * cp-valprint.c: Use C++ exception handling.
6759         * cp-support.c: Use C++ exception handling.
6760         * cp-abi.c: Use C++ exception handling.
6761         * corelow.c: Use C++ exception handling.
6762         * completer.c: Use C++ exception handling.
6763         * compile/compile-object-run.c: Use C++ exception handling.
6764         * compile/compile-object-load.c: Use C++ exception handling.
6765         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6766         * compile/compile-c-symbols.c: Use C++ exception handling.
6767         * common/selftest.c: Use C++ exception handling.
6768         * common/new-op.c: Use C++ exception handling.
6769         * cli/cli-script.c: Use C++ exception handling.
6770         * cli/cli-interp.c: Use C++ exception handling.
6771         * cli/cli-cmds.c: Use C++ exception handling.
6772         * c-varobj.c: Use C++ exception handling.
6773         * btrace.c: Use C++ exception handling.
6774         * breakpoint.c: Use C++ exception handling.
6775         * break-catch-throw.c: Use C++ exception handling.
6776         * arch-utils.c: Use C++ exception handling.
6777         * amd64-tdep.c: Use C++ exception handling.
6778         * ada-valprint.c: Use C++ exception handling.
6779         * ada-typeprint.c: Use C++ exception handling.
6780         * ada-lang.c: Use C++ exception handling.
6781         * aarch64-tdep.c: Use C++ exception handling.
6782
6783 2019-04-08  Tom Tromey  <tom@tromey.com>
6784
6785         * xml-support.c (gdb_xml_parser::parse): Update.
6786         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6787         * value.c (show_convenience): Update.
6788         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6789         (test_parse_flags_qcs): Update.
6790         * thread.c (thr_try_catch_cmd): Update.
6791         * target.c (target_translate_tls_address): Update.
6792         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6793         (info_frame_command_core, frame_apply_command_count): Update.
6794         * rust-exp.y (rust_lex_exception_test): Update.
6795         * riscv-tdep.c (riscv_print_one_register_info): Update.
6796         * remote.c (remote_target::enable_btrace): Update.
6797         * record-btrace.c (record_btrace_enable_warn): Update.
6798         * python/py-utils.c (gdbpy_convert_exception): Update.
6799         * printcmd.c (do_one_display, print_variable_and_value): Update.
6800         * mi/mi-main.c (mi_print_exception): Update.
6801         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6802         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6803         * linux-nat.c (linux_nat_target::attach): Update.
6804         * linux-fork.c (class scoped_switch_fork_info): Update.
6805         * infrun.c (displaced_step_prepare): Update.
6806         * infcall.c (call_function_by_hand_dummy): Update.
6807         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6808         * gnu-v3-abi.c (print_one_vtable): Update.
6809         * frame.c (get_prev_frame_always): Update.
6810         * f-valprint.c (info_common_command_for_block): Update.
6811         * exec.c (try_open_exec_file): Update.
6812         * exceptions.c (print_exception, exception_print)
6813         (exception_fprintf, exception_print_same): Update.
6814         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6815         * dwarf-index-cache.c (index_cache::store)
6816         (index_cache::lookup_gdb_index): Update.
6817         * darwin-nat.c (maybe_cache_shell): Update.
6818         * cp-valprint.c (cp_print_value_fields): Update.
6819         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6820         (gcc_cplus_symbol_address): Update.
6821         * compile/compile-c-symbols.c (gcc_convert_symbol)
6822         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6823         * common/selftest.c: Update.
6824         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6825         a std::string.
6826         (exception_try_scope_entry, exception_try_scope_exit): Don't
6827         declare.
6828         (struct exception_try_scope): Remove.
6829         (TRY): Don't use exception_try_scope.
6830         (struct gdb_exception): Add constructor, operator=.
6831         <what>: New method.
6832         (struct gdb_exception_RETURN_MASK_ALL)
6833         (struct gdb_exception_RETURN_MASK_ERROR)
6834         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6835         (struct gdb_quit_bad_alloc): Update.
6836         * common/common-exceptions.c (exception_none): Change
6837         initializer.
6838         (struct catcher) <state, exception>: Initialize inline.
6839         <prev>: Remove member.
6840         (current_catcher): Remove.
6841         (catchers): New global.
6842         (exceptions_state_mc_init): Simplify.
6843         (catcher_pop): Remove.
6844         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6845         (try_scope_depth, exception_try_scope_entry)
6846         (exception_try_scope_exit): Remove.
6847         (throw_exception_sjlj): Update.
6848         (exception_messages, exception_messages_size): Remove.
6849         (throw_it): Simplify.
6850         (gdb_exception_sliced_copy): Remove.
6851         (throw_exception_cxx): Update.
6852         * cli/cli-script.c (script_from_file): Update.
6853         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6854         Update.
6855         * ada-valprint.c (ada_val_print): Update.
6856         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6857         (create_excep_cond_exprs): Update.
6858
6859 2019-04-08  Tom Tromey  <tom@tromey.com>
6860
6861         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6862         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6863         (TRY, CATCH, END_CATCH): Remove some definitions.
6864         * common/common-exceptions.c: Don't use GDB_XCPT.
6865         (catcher_list_size): Remove.
6866         (throw_exception, throw_it): Simplify.
6867
6868 2019-04-05  Tom Tromey  <tom@tromey.com>
6869
6870         Revert the header-sorting patch.
6871         * ft32-tdep.c: Revert.
6872         * frv-tdep.c: Revert.
6873         * frv-linux-tdep.c: Revert.
6874         * frame.c: Revert.
6875         * frame-unwind.c: Revert.
6876         * frame-base.c: Revert.
6877         * fork-child.c: Revert.
6878         * findvar.c: Revert.
6879         * findcmd.c: Revert.
6880         * filesystem.c: Revert.
6881         * filename-seen-cache.h: Revert.
6882         * filename-seen-cache.c: Revert.
6883         * fbsd-tdep.c: Revert.
6884         * fbsd-nat.h: Revert.
6885         * fbsd-nat.c: Revert.
6886         * f-valprint.c: Revert.
6887         * f-typeprint.c: Revert.
6888         * f-lang.c: Revert.
6889         * extension.h: Revert.
6890         * extension.c: Revert.
6891         * extension-priv.h: Revert.
6892         * expprint.c: Revert.
6893         * exec.h: Revert.
6894         * exec.c: Revert.
6895         * exceptions.c: Revert.
6896         * event-top.c: Revert.
6897         * event-loop.c: Revert.
6898         * eval.c: Revert.
6899         * elfread.c: Revert.
6900         * dwarf2read.h: Revert.
6901         * dwarf2read.c: Revert.
6902         * dwarf2loc.c: Revert.
6903         * dwarf2expr.h: Revert.
6904         * dwarf2expr.c: Revert.
6905         * dwarf2-frame.c: Revert.
6906         * dwarf2-frame-tailcall.c: Revert.
6907         * dwarf-index-write.h: Revert.
6908         * dwarf-index-write.c: Revert.
6909         * dwarf-index-common.c: Revert.
6910         * dwarf-index-cache.h: Revert.
6911         * dwarf-index-cache.c: Revert.
6912         * dummy-frame.c: Revert.
6913         * dtrace-probe.c: Revert.
6914         * disasm.h: Revert.
6915         * disasm.c: Revert.
6916         * disasm-selftests.c: Revert.
6917         * dictionary.c: Revert.
6918         * dicos-tdep.c: Revert.
6919         * demangle.c: Revert.
6920         * dcache.h: Revert.
6921         * dcache.c: Revert.
6922         * darwin-nat.h: Revert.
6923         * darwin-nat.c: Revert.
6924         * darwin-nat-info.c: Revert.
6925         * d-valprint.c: Revert.
6926         * d-namespace.c: Revert.
6927         * d-lang.c: Revert.
6928         * ctf.c: Revert.
6929         * csky-tdep.c: Revert.
6930         * csky-linux-tdep.c: Revert.
6931         * cris-tdep.c: Revert.
6932         * cris-linux-tdep.c: Revert.
6933         * cp-valprint.c: Revert.
6934         * cp-support.c: Revert.
6935         * cp-namespace.c: Revert.
6936         * cp-abi.c: Revert.
6937         * corelow.c: Revert.
6938         * corefile.c: Revert.
6939         * continuations.c: Revert.
6940         * completer.h: Revert.
6941         * completer.c: Revert.
6942         * complaints.c: Revert.
6943         * coffread.c: Revert.
6944         * coff-pe-read.c: Revert.
6945         * cli-out.h: Revert.
6946         * cli-out.c: Revert.
6947         * charset.c: Revert.
6948         * c-varobj.c: Revert.
6949         * c-valprint.c: Revert.
6950         * c-typeprint.c: Revert.
6951         * c-lang.c: Revert.
6952         * buildsym.c: Revert.
6953         * buildsym-legacy.c: Revert.
6954         * build-id.h: Revert.
6955         * build-id.c: Revert.
6956         * btrace.c: Revert.
6957         * bsd-uthread.c: Revert.
6958         * breakpoint.h: Revert.
6959         * breakpoint.c: Revert.
6960         * break-catch-throw.c: Revert.
6961         * break-catch-syscall.c: Revert.
6962         * break-catch-sig.c: Revert.
6963         * blockframe.c: Revert.
6964         * block.c: Revert.
6965         * bfin-tdep.c: Revert.
6966         * bfin-linux-tdep.c: Revert.
6967         * bfd-target.c: Revert.
6968         * bcache.c: Revert.
6969         * ax-general.c: Revert.
6970         * ax-gdb.h: Revert.
6971         * ax-gdb.c: Revert.
6972         * avr-tdep.c: Revert.
6973         * auxv.c: Revert.
6974         * auto-load.c: Revert.
6975         * arm-wince-tdep.c: Revert.
6976         * arm-tdep.c: Revert.
6977         * arm-symbian-tdep.c: Revert.
6978         * arm-pikeos-tdep.c: Revert.
6979         * arm-obsd-tdep.c: Revert.
6980         * arm-nbsd-tdep.c: Revert.
6981         * arm-nbsd-nat.c: Revert.
6982         * arm-linux-tdep.c: Revert.
6983         * arm-linux-nat.c: Revert.
6984         * arm-fbsd-tdep.c: Revert.
6985         * arm-fbsd-nat.c: Revert.
6986         * arm-bsd-tdep.c: Revert.
6987         * arch-utils.c: Revert.
6988         * arc-tdep.c: Revert.
6989         * arc-newlib-tdep.c: Revert.
6990         * annotate.h: Revert.
6991         * annotate.c: Revert.
6992         * amd64-windows-tdep.c: Revert.
6993         * amd64-windows-nat.c: Revert.
6994         * amd64-tdep.c: Revert.
6995         * amd64-sol2-tdep.c: Revert.
6996         * amd64-obsd-tdep.c: Revert.
6997         * amd64-obsd-nat.c: Revert.
6998         * amd64-nbsd-tdep.c: Revert.
6999         * amd64-nbsd-nat.c: Revert.
7000         * amd64-nat.c: Revert.
7001         * amd64-linux-tdep.c: Revert.
7002         * amd64-linux-nat.c: Revert.
7003         * amd64-fbsd-tdep.c: Revert.
7004         * amd64-fbsd-nat.c: Revert.
7005         * amd64-dicos-tdep.c: Revert.
7006         * amd64-darwin-tdep.c: Revert.
7007         * amd64-bsd-nat.c: Revert.
7008         * alpha-tdep.c: Revert.
7009         * alpha-obsd-tdep.c: Revert.
7010         * alpha-nbsd-tdep.c: Revert.
7011         * alpha-mdebug-tdep.c: Revert.
7012         * alpha-linux-tdep.c: Revert.
7013         * alpha-linux-nat.c: Revert.
7014         * alpha-bsd-tdep.c: Revert.
7015         * alpha-bsd-nat.c: Revert.
7016         * aix-thread.c: Revert.
7017         * agent.c: Revert.
7018         * addrmap.c: Revert.
7019         * ada-varobj.c: Revert.
7020         * ada-valprint.c: Revert.
7021         * ada-typeprint.c: Revert.
7022         * ada-tasks.c: Revert.
7023         * ada-lang.c: Revert.
7024         * aarch64-tdep.c: Revert.
7025         * aarch64-ravenscar-thread.c: Revert.
7026         * aarch64-newlib-tdep.c: Revert.
7027         * aarch64-linux-tdep.c: Revert.
7028         * aarch64-linux-nat.c: Revert.
7029         * aarch64-fbsd-tdep.c: Revert.
7030         * aarch64-fbsd-nat.c: Revert.
7031         * aarch32-linux-nat.c: Revert.
7032
7033 2019-04-05  Tom Tromey  <tom@tromey.com>
7034
7035         * ft32-tdep.c: Sort headers.
7036         * frv-tdep.c: Sort headers.
7037         * frv-linux-tdep.c: Sort headers.
7038         * frame.c: Sort headers.
7039         * frame-unwind.c: Sort headers.
7040         * frame-base.c: Sort headers.
7041         * fork-child.c: Sort headers.
7042         * findvar.c: Sort headers.
7043         * findcmd.c: Sort headers.
7044         * filesystem.c: Sort headers.
7045         * filename-seen-cache.h: Sort headers.
7046         * filename-seen-cache.c: Sort headers.
7047         * fbsd-tdep.c: Sort headers.
7048         * fbsd-nat.h: Sort headers.
7049         * fbsd-nat.c: Sort headers.
7050         * f-valprint.c: Sort headers.
7051         * f-typeprint.c: Sort headers.
7052         * f-lang.c: Sort headers.
7053         * extension.h: Sort headers.
7054         * extension.c: Sort headers.
7055         * extension-priv.h: Sort headers.
7056         * expprint.c: Sort headers.
7057         * exec.h: Sort headers.
7058         * exec.c: Sort headers.
7059         * exceptions.c: Sort headers.
7060         * event-top.c: Sort headers.
7061         * event-loop.c: Sort headers.
7062         * eval.c: Sort headers.
7063         * elfread.c: Sort headers.
7064         * dwarf2read.h: Sort headers.
7065         * dwarf2read.c: Sort headers.
7066         * dwarf2loc.c: Sort headers.
7067         * dwarf2expr.h: Sort headers.
7068         * dwarf2expr.c: Sort headers.
7069         * dwarf2-frame.c: Sort headers.
7070         * dwarf2-frame-tailcall.c: Sort headers.
7071         * dwarf-index-write.h: Sort headers.
7072         * dwarf-index-write.c: Sort headers.
7073         * dwarf-index-common.c: Sort headers.
7074         * dwarf-index-cache.h: Sort headers.
7075         * dwarf-index-cache.c: Sort headers.
7076         * dummy-frame.c: Sort headers.
7077         * dtrace-probe.c: Sort headers.
7078         * disasm.h: Sort headers.
7079         * disasm.c: Sort headers.
7080         * disasm-selftests.c: Sort headers.
7081         * dictionary.c: Sort headers.
7082         * dicos-tdep.c: Sort headers.
7083         * demangle.c: Sort headers.
7084         * dcache.h: Sort headers.
7085         * dcache.c: Sort headers.
7086         * darwin-nat.h: Sort headers.
7087         * darwin-nat.c: Sort headers.
7088         * darwin-nat-info.c: Sort headers.
7089         * d-valprint.c: Sort headers.
7090         * d-namespace.c: Sort headers.
7091         * d-lang.c: Sort headers.
7092         * ctf.c: Sort headers.
7093         * csky-tdep.c: Sort headers.
7094         * csky-linux-tdep.c: Sort headers.
7095         * cris-tdep.c: Sort headers.
7096         * cris-linux-tdep.c: Sort headers.
7097         * cp-valprint.c: Sort headers.
7098         * cp-support.c: Sort headers.
7099         * cp-namespace.c: Sort headers.
7100         * cp-abi.c: Sort headers.
7101         * corelow.c: Sort headers.
7102         * corefile.c: Sort headers.
7103         * continuations.c: Sort headers.
7104         * completer.h: Sort headers.
7105         * completer.c: Sort headers.
7106         * complaints.c: Sort headers.
7107         * coffread.c: Sort headers.
7108         * coff-pe-read.c: Sort headers.
7109         * cli-out.h: Sort headers.
7110         * cli-out.c: Sort headers.
7111         * charset.c: Sort headers.
7112         * c-varobj.c: Sort headers.
7113         * c-valprint.c: Sort headers.
7114         * c-typeprint.c: Sort headers.
7115         * c-lang.c: Sort headers.
7116         * buildsym.c: Sort headers.
7117         * buildsym-legacy.c: Sort headers.
7118         * build-id.h: Sort headers.
7119         * build-id.c: Sort headers.
7120         * btrace.c: Sort headers.
7121         * bsd-uthread.c: Sort headers.
7122         * breakpoint.h: Sort headers.
7123         * breakpoint.c: Sort headers.
7124         * break-catch-throw.c: Sort headers.
7125         * break-catch-syscall.c: Sort headers.
7126         * break-catch-sig.c: Sort headers.
7127         * blockframe.c: Sort headers.
7128         * block.c: Sort headers.
7129         * bfin-tdep.c: Sort headers.
7130         * bfin-linux-tdep.c: Sort headers.
7131         * bfd-target.c: Sort headers.
7132         * bcache.c: Sort headers.
7133         * ax-general.c: Sort headers.
7134         * ax-gdb.h: Sort headers.
7135         * ax-gdb.c: Sort headers.
7136         * avr-tdep.c: Sort headers.
7137         * auxv.c: Sort headers.
7138         * auto-load.c: Sort headers.
7139         * arm-wince-tdep.c: Sort headers.
7140         * arm-tdep.c: Sort headers.
7141         * arm-symbian-tdep.c: Sort headers.
7142         * arm-pikeos-tdep.c: Sort headers.
7143         * arm-obsd-tdep.c: Sort headers.
7144         * arm-nbsd-tdep.c: Sort headers.
7145         * arm-nbsd-nat.c: Sort headers.
7146         * arm-linux-tdep.c: Sort headers.
7147         * arm-linux-nat.c: Sort headers.
7148         * arm-fbsd-tdep.c: Sort headers.
7149         * arm-fbsd-nat.c: Sort headers.
7150         * arm-bsd-tdep.c: Sort headers.
7151         * arch-utils.c: Sort headers.
7152         * arc-tdep.c: Sort headers.
7153         * arc-newlib-tdep.c: Sort headers.
7154         * annotate.h: Sort headers.
7155         * annotate.c: Sort headers.
7156         * amd64-windows-tdep.c: Sort headers.
7157         * amd64-windows-nat.c: Sort headers.
7158         * amd64-tdep.c: Sort headers.
7159         * amd64-sol2-tdep.c: Sort headers.
7160         * amd64-obsd-tdep.c: Sort headers.
7161         * amd64-obsd-nat.c: Sort headers.
7162         * amd64-nbsd-tdep.c: Sort headers.
7163         * amd64-nbsd-nat.c: Sort headers.
7164         * amd64-nat.c: Sort headers.
7165         * amd64-linux-tdep.c: Sort headers.
7166         * amd64-linux-nat.c: Sort headers.
7167         * amd64-fbsd-tdep.c: Sort headers.
7168         * amd64-fbsd-nat.c: Sort headers.
7169         * amd64-dicos-tdep.c: Sort headers.
7170         * amd64-darwin-tdep.c: Sort headers.
7171         * amd64-bsd-nat.c: Sort headers.
7172         * alpha-tdep.c: Sort headers.
7173         * alpha-obsd-tdep.c: Sort headers.
7174         * alpha-nbsd-tdep.c: Sort headers.
7175         * alpha-mdebug-tdep.c: Sort headers.
7176         * alpha-linux-tdep.c: Sort headers.
7177         * alpha-linux-nat.c: Sort headers.
7178         * alpha-bsd-tdep.c: Sort headers.
7179         * alpha-bsd-nat.c: Sort headers.
7180         * aix-thread.c: Sort headers.
7181         * agent.c: Sort headers.
7182         * addrmap.c: Sort headers.
7183         * ada-varobj.c: Sort headers.
7184         * ada-valprint.c: Sort headers.
7185         * ada-typeprint.c: Sort headers.
7186         * ada-tasks.c: Sort headers.
7187         * ada-lang.c: Sort headers.
7188         * aarch64-tdep.c: Sort headers.
7189         * aarch64-ravenscar-thread.c: Sort headers.
7190         * aarch64-newlib-tdep.c: Sort headers.
7191         * aarch64-linux-tdep.c: Sort headers.
7192         * aarch64-linux-nat.c: Sort headers.
7193         * aarch64-fbsd-tdep.c: Sort headers.
7194         * aarch64-fbsd-nat.c: Sort headers.
7195         * aarch32-linux-nat.c: Sort headers.
7196
7197 2019-04-04  Tom Tromey  <tom@tromey.com>
7198
7199         * varobj.c (varobj_create): Update.
7200         * rust-exp.y (struct rust_parser) <update_innermost_block,
7201         lookup_symbol>: New methods.
7202         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7203         Rename.
7204         (rust_parser::rust_lookup_type)
7205         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7206         * printcmd.c (display_command, do_one_display): Update.
7207         * parser-defs.h (struct parser_state) <parser_state>: Add
7208         "tracker" parameter.
7209         (block_tracker): New member.
7210         (class innermost_block_tracker) <innermost_block_tracker>: Add
7211         "types" parameter.
7212         <reset>: Remove method.
7213         (innermost_block): Don't declare.
7214         (null_post_parser): Update.
7215         * parse.c (innermost_block): Remove global.
7216         (write_dollar_variable): Update.
7217         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7218         Remove "tracker_types" parameter.
7219         (parse_expression): Add "tracker" parameter.
7220         (parse_expression_for_completion): Update.
7221         (null_post_parser): Add "tracker" parameter.
7222         * p-exp.y: Update rules.
7223         * m2-exp.y: Update rules.
7224         * language.h (struct language_defn) <la_post_parser>: Add
7225         "tracker" parameter.
7226         * go-exp.y: Update rules.
7227         * f-exp.y: Update rules.
7228         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7229         parameter.
7230         * d-exp.y: Update rules.
7231         * c-exp.y: Update rules.
7232         * breakpoint.c (set_breakpoint_condition): Create an
7233         innermost_block_tracker.
7234         (watch_command_1): Likewise.
7235         * ada-lang.c (resolve): Add "tracker" parameter.
7236         (resolve_subexp): Likewise.
7237         * ada-exp.y (write_var_from_sym): Update.
7238
7239 2019-04-04  Tom Tromey  <tom@tromey.com>
7240
7241         * type-stack.h: New file.
7242         * type-stack.c: New file.
7243         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7244         type-stack.h.
7245         (insert_into_type_stack, insert_type, push_type, push_type_int)
7246         (insert_type_address_space, pop_type, pop_type_int)
7247         (pop_typelist, pop_type_stack, append_type_stack)
7248         (push_type_stack, get_type_stack, push_typelist)
7249         (follow_type_instance_flags, follow_types): Don't declare.
7250         * parse.c (type_stack): Remove global.
7251         (parse_exp_in_context): Update.
7252         (insert_into_type_stack, insert_type, push_type, push_type_int)
7253         (insert_type_address_space, pop_type, pop_type_int)
7254         (pop_typelist, pop_type_stack, append_type_stack)
7255         (push_type_stack, get_type_stack, push_typelist)
7256         (follow_type_instance_flags, follow_types): Remove (moved to
7257         type-stack.c).
7258         * f-exp.y (type_stack): New global.
7259         Update rules.
7260         (push_kind_type, f_parse): Update.
7261         * d-exp.y (type_stack): New global.
7262         Update rules.
7263         (d_parse): Update.
7264         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7265         Update rules.
7266         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7267         (HFILES_NO_SRCDIR): Add type-stack.h.
7268
7269 2019-04-04  Tom Tromey  <tom@tromey.com>
7270
7271         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7272         (rust_parser::convert_ast_to_expression, rust_parse)
7273         (rust_lex_test_completion, rust_lex_tests): Update.
7274         * parser-defs.h (struct expr_completion_state): New.
7275         (struct parser_state) <parser_state>: Add completion parameter.
7276         <mark_struct_expression, mark_completion_tag>: New methods.
7277         <parse_completion, m_completion_state>: New members.
7278         (prefixify_expression, null_post_parser): Update.
7279         (mark_struct_expression, mark_completion_tag): Don't declare.
7280         * parse.c (parse_completion, expout_last_struct)
7281         (expout_tag_completion_type, expout_completion_name): Remove
7282         globals.
7283         (parser_state::mark_struct_expression)
7284         (parser_state::mark_completion_tag): Now methods.
7285         (prefixify_expression): Add last_struct parameter.
7286         (prefixify_subexp): Likewise.
7287         (parse_exp_1): Update.
7288         (parse_exp_in_context): Add cstate parameter.  Update.
7289         (parse_expression_for_completion): Create an
7290         expr_completion_state.
7291         (null_post_parser): Add "completion" parameter.
7292         * p-exp.y: Update rules.
7293         (yylex): Update.
7294         * language.h (struct language_defn) <la_post_parser>: Add
7295         "completing" parameter.
7296         * go-exp.y: Update rules.
7297         (lex_one_token): Update.
7298         * expression.h (parse_completion): Don't declare.
7299         * d-exp.y: Update rules.
7300         (lex_one_token): Update rules.
7301         * c-exp.y: Update rules.
7302         (lex_one_token): Update.
7303         * ada-lang.c (resolve): Add "parse_completion" parameter.
7304         (resolve_subexp): Likewise.
7305         (ada_resolve_function): Likewise.
7306
7307 2019-04-04  Tom Tromey  <tom@tromey.com>
7308
7309         * parser-defs.h (struct parser_state) <start_arglist,
7310         end_arglist>: New methods.
7311         <arglist_len, m_funcall_chain>: New members.
7312         (arglist_len, start_arglist, end_arglist): Don't declare.
7313         * parse.c (arglist_len, funcall_chain): Remove global.
7314         (start_arglist, end_arglist): Remove functions.
7315         (parse_exp_in_context): Update.
7316         * p-exp.y: Update rules.
7317         * m2-exp.y: Update rules.
7318         * go-exp.y: Update rules.
7319         * f-exp.y: Update rules.
7320         * d-exp.y: Update rules.
7321         * c-exp.y: Update rules.
7322
7323 2019-04-04  Tom Tromey  <tom@tromey.com>
7324
7325         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7326         lex_operator, push_back>: New methods.
7327         Update all rules.
7328         (rust_parser::lex_hex, lex_escape): Rename and update.
7329         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7330         (rust_parser::lex_operator): Rename and update.
7331         (rust_parser::lex_number, rustyylex, rustyyerror)
7332         (rust_lex_test_init, rust_lex_test_sequence)
7333         (rust_lex_test_push_back, rust_lex_tests): Update.
7334         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7335         parameter.
7336         <lexptr, prev_lexptr>: New members.
7337         (lexptr, prev_lexptr): Don't declare.
7338         * parse.c (lexptr, prev_lexptr): Remove globals.
7339         (parse_exp_in_context): Update.
7340         * p-exp.y (yylex, yyerror): Update.
7341         * m2-exp.y (parse_number, yylex, yyerror): Update.
7342         * go-exp.y (lex_one_token, yyerror): Update.
7343         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7344         * d-exp.y (lex_one_token, yyerror): Update.
7345         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7346         (lex_one_token, yyerror): Update.
7347         * ada-lex.l (YY_INPUT): Update.
7348         (rewind_to_char): Update.
7349         * ada-exp.y (yyerror): Update.
7350
7351 2019-04-04  Tom Tromey  <tom@tromey.com>
7352
7353         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7354         * parser-defs.h (struct parser_state) <parser_state>: Add new
7355         parameter.
7356         <comma_terminates>: New member.
7357         (comma_terminates): Don't declare global.
7358         * parse.c (comma_terminates): Remove global.
7359         (parse_exp_in_context): Update.
7360         * p-exp.y (yylex): Update.
7361         * m2-exp.y (yylex): Update.
7362         * go-exp.y (lex_one_token): Update.
7363         * f-exp.y (yylex): Update.
7364         * d-exp.y (lex_one_token): Update.
7365         * c-exp.y (lex_one_token): Update.
7366         * ada-lex.l: Update.
7367
7368 2019-04-04  Tom Tromey  <tom@tromey.com>
7369
7370         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7371         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7372         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7373         * parser-defs.h (paren_depth): Don't declare.
7374         * parse.c (paren_depth): Remove global.
7375         (parse_exp_in_context): Update.
7376         * p-exp.y (paren_depth): New global.
7377         (pascal_parse): Initialize it.
7378         * m2-exp.y (paren_depth): New global.
7379         (m2_parse): Initialize it.
7380         * go-exp.y (paren_depth): New global.
7381         (go_parse): Initialize it.
7382         * f-exp.y (paren_depth): New global.
7383         (f_parse): Initialize it.
7384         * d-exp.y (paren_depth): New global.
7385         (d_parse): Initialize it.
7386         * c-exp.y (paren_depth): New global.
7387         (c_parse): Initialize it.
7388         * ada-lex.l (paren_depth): New global.
7389         (lexer_init): Initialize it.
7390
7391 2019-04-04  Tom Tromey  <tom@tromey.com>
7392
7393         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7394         (rust_parser::convert_ast_to_type)
7395         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7396         * parser-defs.h (struct parser_state) <parser_state>: Add
7397         parameters.  Initialize new members.
7398         <expression_context_block, expression_context_pc>: New members.
7399         * parse.c (expression_context_block, expression_context_pc):
7400         Remove globals.
7401         (parse_exp_in_context): Update.
7402         * p-exp.y: Update all rules.
7403         (yylex): Update.
7404         * m2-exp.y: Update all rules.
7405         (yylex): Update.
7406         * go-exp.y (yylex): Update.
7407         * f-exp.y (yylex): Update.
7408         * d-exp.y: Update all rules.
7409         (yylex): Update.
7410         * c-exp.y: Update all rules.
7411         (lex_one_token, classify_name, yylex, c_parse): Update.
7412         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7413
7414 2019-04-04  Tom Tromey  <tom@tromey.com>
7415
7416         * gdbarch.h, gdbarch.c: Rebuild.
7417         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7418         * stap-probe.h:
7419         (struct stap_parse_info): Replace "parser_state" with
7420         "expr_builder".
7421         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7422         (parser_state): New class.
7423         * parse.c (expr_builder): Rename.
7424         (expr_builder::release): Rename.
7425         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7426         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7427         (write_exp_elt_longcst, write_exp_elt_floatcst)
7428         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7429         (write_exp_string_vector, write_exp_bitstring)
7430         (write_exp_msymbol, mark_struct_expression)
7431         (write_dollar_variable)
7432         (insert_type_address_space, increase_expout_size): Replace
7433         "parser_state" with "expr_builder".
7434         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7435         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7436         "parser_state" with "expr_builder".
7437
7438 2019-04-04  Tom Tromey  <tom@tromey.com>
7439
7440         * rust-exp.y: Replace "parse_language" with method call.
7441         * p-exp.y:
7442         (yylex): Replace "parse_language" with method call.
7443         * m2-exp.y:
7444         (yylex): Replace "parse_language" with method call.
7445         * go-exp.y (classify_name): Replace "parse_language" with method
7446         call.
7447         * f-exp.y (yylex): Replace "parse_language" with method call.
7448         * d-exp.y (lex_one_token): Replace "parse_language" with method
7449         call.
7450         * c-exp.y:
7451         (lex_one_token, classify_name, yylex): Replace "parse_language"
7452         with method call.
7453         * ada-exp.y (find_primitive_type, type_char)
7454         (type_system_address): Replace "parse_language" with method call.
7455
7456 2019-04-04  Tom Tromey  <tom@tromey.com>
7457
7458         * rust-exp.y: Replace "parse_gdbarch" with method call.
7459         * parse.c (write_dollar_variable, insert_type_address_space):
7460         Replace "parse_gdbarch" with method call.
7461         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7462         call.
7463         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7464         call.
7465         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7466         "parse_gdbarch" with method call.
7467         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7468         with method call.
7469         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7470         "parse_gdbarch" with method call.
7471         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7472         "parse_gdbarch" with method call.
7473         * c-exp.y (parse_type, parse_number, classify_name): Replace
7474         "parse_gdbarch" with method call.
7475         * ada-lex.l: Replace "parse_gdbarch" with method call.
7476         * ada-exp.y (parse_type, find_primitive_type, type_char)
7477         (type_system_address): Replace "parse_gdbarch" with method call.
7478
7479 2019-04-04  Tom Tromey  <tom@tromey.com>
7480
7481         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7482         * stap-probe.c (stap_parse_argument): Update.
7483         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7484         initial_size parameter.
7485         * rust-exp.y (rust_lex_tests): Update.
7486         * parse.c (parser_state): Update.
7487         (parse_exp_in_context): Update.
7488         * parser-defs.h (struct parser_state) <parser_state>: Remove
7489         "initial_size" parameter.
7490
7491 2019-04-04  Tom Tromey  <tom@tromey.com>
7492
7493         * parser-defs.h (increase_expout_size): Don't declare.
7494         * parse.c (increase_expout_size): Now static.
7495
7496 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7497
7498         * gnu-nat.c (gnu_nat_target::wait): Fix
7499         target_waitstatus_to_string call.
7500
7501 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7502
7503         * eval.c (evaluate_subexp_standard): Handle internal functions
7504         during Fortran function call handling.
7505
7506 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7507
7508         * NEWS: Mention new internal functions.
7509         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7510         (read_base_type): Use dwarf2_init_complex_target_type.
7511         * value.c (creal_internal_fn): New function.
7512         (cimag_internal_fn): New function.
7513         (_initialize_values): Register new internal functions.
7514
7515 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7516
7517         * infrun.c (stop_all_threads): If debug_infrun, always
7518         trace the wait status after wait_one, using
7519         target_waitstatus_to_string and target_pid_to_str.
7520         (handle_inferior_event): Replace various trace of
7521         wait status kind by a single trace.
7522         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7523         wait status kind image by target_waitstatus_to_string.
7524         * target/waitstatus.c (target_waitstatus_to_string): Fix
7525         obsolete comment.
7526
7527 2019-04-01  Tom Tromey  <tromey@adacore.com>
7528
7529         PR symtab/23331:
7530         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7531
7532 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7533             Pedro Alves  <palves@redhat.com>
7534
7535         * top.c (quit_force): Call 'finalize_values'.
7536         * value.c (finalize_values): New function.
7537         * value.h (finalize_values): Declare.
7538
7539 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7540
7541         * NEWS: Announce $_gdb_major and $_gdb_minor.
7542
7543         * top.c (init_gdb_version_vars): New function.
7544         (gdb_init): Call init_gdb_version_vars.
7545
7546 2019-03-29  Tom Tromey  <tromey@adacore.com>
7547
7548         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7549         help text.  Remove dead code.
7550
7551 2019-03-29  Keith Seitz  <keiths@redhat.com>
7552
7553         From Siddhesh Poyarekar:
7554         * f-lang.h (f77_get_upperbound): Return LONGEST.
7555         (f77_get_lowerbound): Likewise.
7556         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7557         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7558         print them.
7559         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7560         plongest to format print it.
7561         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7562         (f77_get_upperbound): Likewise.
7563         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7564         LOWER_BOUND to LONGEST.
7565         (f77_create_arrayprint_offset_tbl): Likewise.
7566
7567 2019-03-29  Keith Seitz  <keiths@redhat.com>
7568
7569         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7570         %s/pulongest for TYPE_LENGTH instead of %d in format
7571         strings.
7572         * ada-typerint.c (ada_print_type): Likewise.
7573         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7574         * compile/compile-c-support.c (generate_register_struct): Likewise.
7575         * gdbtypes.c (recursive_dump_type): Likewise.
7576         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7577         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7578         instead of %d in format strings.
7579         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7580         to std::min to ULONGEST.
7581         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7582         instead of %d in format strings.
7583         * tracepoint.c (info_scope_command): Likewise.
7584         * typeprint.c (print_offset_data::update)
7585         (print_offset_data::finish): Likewise.
7586         * xtensa-tdep.c (xtensa_store_return_value)
7587         (xtensa_push_dummy_call): Likewise.
7588
7589 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7590
7591         * windows-nat.c (display_selector): Fixed format specifications
7592         for 64-bit Cygwin.
7593
7594 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7595
7596         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7597
7598 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7599
7600         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7601         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7602         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7603         (nios2_linux_init_abi): Install it.
7604
7605 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7606
7607         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7608
7609 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7610
7611         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7612
7613 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7614             Tom Tromey  <tromey@adacore.com>
7615
7616         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7617
7618 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7619
7620         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7621         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7622         method to compute the bounds of range types. Also print "[evaluated]"
7623         if the bounds' values come from a dynamic evaluation.
7624
7625 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7628         whitespace when pretty printing is on.
7629
7630 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7631
7632         * ppc-linux-nat.c: Add include.
7633
7634 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7635
7636         * NEWS: Mention AArch64 Pointer Authentication.
7637
7638 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7639
7640         * arm-linux-nat.c: Add include.
7641
7642 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7643
7644         * source-cache.c (source_cache::get_source_lines): Re-read
7645         fullname after calling open_source_file.
7646
7647 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7648
7649         * NEWS: Mention TLS support for FreeBSD.
7650
7651 2019-03-25  Tom Tromey  <tromey@adacore.com>
7652
7653         * minsyms.c (BUNCH_SIZE): Update comment.
7654         (~minimal_symbol_reader): Remove old comment.
7655         (compact_minimal_symbols): Update comment.
7656         (minimal_symbol_reader::install): Remove old comment.  Update
7657         other comments.
7658
7659 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7660
7661         * s390-linux-nat.c: Add include.
7662
7663 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7664
7665         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7666         Call linux_get_hwcap.
7667         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7668         Likewise.
7669         (aarch64_linux_get_hwcap): Remove function.
7670         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7671         declaration.
7672         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7673         linux_get_hwcap.
7674         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7675         * linux-tdep.c (linux_get_hwcap): Add function.
7676         (linux_get_hwcap2): Likewise.
7677         * linux-tdep.h (linux_get_hwcap): Add declaration.
7678         (linux_get_hwcap2): Likewise.
7679         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7680         (ppc_linux_get_hwcap2): Likewise.
7681         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7682         linux_get_hwcap.
7683         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7684         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7685         (ppc_linux_nat_target::read_description): Likewise.
7686         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7687         * s390-linux-nat.c: Likewise.
7688         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7689
7690 2019-03-24  Tom Tromey  <tom@tromey.com>
7691
7692         * ada-lang.c (standard_lookup): Simplify initialization.
7693         (ada_lookup_symbol_nonlocal): Simplify return.
7694         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7695         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7696         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7697         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7698         initialization.
7699         * solib.c (solib_global_lookup): Simplify.
7700         * symtab.c (null_block_symbol): Remove.
7701         (symbol_cache_lookup): Simplify returns.
7702         (lookup_language_this): Simplify returns.
7703         (lookup_symbol_aux): Simplify return.
7704         (lookup_local_symbol): Simplify returns.
7705         (lookup_global_symbol_from_objfile): Simplify return.
7706         (lookup_symbol_in_objfile_symtabs)
7707         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7708         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7709         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7710         * cp-namespace.c (cp_lookup_bare_symbol)
7711         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7712         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7713         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7714         (cp_lookup_symbol_via_imports): Simplify initialization.
7715         (find_symbol_in_baseclass): Likewise.
7716         * symtab.h (null_block_symbol): Remove.
7717         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7718         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7719         (d_lookup_symbol_module): Likewise.
7720         (find_symbol_in_baseclass): Simplify initialization.
7721
7722 2019-03-24  Tom Tromey  <tom@tromey.com>
7723
7724         * expression.h: Don't include symtab.h.
7725         (struct block): Forward declare.
7726
7727 2019-03-24  Tom Tromey  <tom@tromey.com>
7728
7729         * c-exp.y (typebase): Remove casts.
7730         * gdbtypes.c (lookup_unsigned_typename, )
7731         (lookup_signed_typename): Remove cast.
7732         * eval.c (parse_to_comma_and_eval): Remove cast.
7733         * parse.c (write_dollar_variable): Remove cast.
7734         * block.h (struct block) <superblock>: Now const.
7735         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7736         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7737         (map_block): Make "block" const.
7738         * symfile.h (struct quick_symbol_functions)
7739         <map_matching_symbols>: Constify block argument to "callback".
7740         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7741         const.
7742         (find_pc_sect_compunit_symtab): Make "b" const.
7743         (find_symbol_at_address): Likewise.
7744         (search_symbols): Likewise.
7745         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7746         (dw2_debug_names_lookup_symbol): Likewise.
7747         (dw2_map_matching_symbols): Update.
7748         * p-valprint.c (pascal_val_print): Remove "block".
7749         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7750         (aux_add_nonlocal_symbols): Make "block" const.
7751         (resolve_subexp): Remove cast.
7752         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7753         const.
7754         (iterate_over_file_blocks): Likewise.
7755         * f-exp.y (%union) <bval>: Remove.
7756         * coffread.c (patch_opaque_types): Make "b" const.
7757         * spu-tdep.c (spu_catch_start): Make "block" const.
7758         * c-valprint.c (print_unpacked_pointer): Remove "block".
7759         * symmisc.c (dump_symtab_1): Make "b" const.
7760         (block_depth): Make "block" const.
7761         * d-exp.y (%union) <bval>: Remove.
7762         * cp-support.h (cp_lookup_rtti_type): Update.
7763         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7764         * psymtab.c (psym_lookup_symbol): Make "block" const.
7765         (maintenance_check_psymtabs): Make "b" const.
7766         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7767         (enumerate_locals, enumerate_args): Update.
7768         * python/py-symtab.c (stpy_global_block): Make "block" const.
7769         (stpy_static_block): Likewise.
7770         * inline-frame.c (block_starting_point_at): Make "new_block"
7771         const.
7772         * block.c (find_block_in_blockvector): Make return type const.
7773         (blockvector_for_pc_sect): Make "b" const.
7774         (find_block_in_blockvector): Make "b" const.
7775
7776 2019-03-23  Tom Tromey  <tom@tromey.com>
7777
7778         * varobj.c (varobj_create): Update.
7779         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7780         * printcmd.c (display_command, do_one_display): Don't reset
7781         innermost_block.
7782         * parser-defs.h (enum innermost_block_tracker_type): Move to
7783         expression.h.
7784         (innermost_block): Update comment.
7785         * parse.c (parse_exp_1): Add tracker_types parameter.
7786         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7787         tracker_types parameter.  Reset innermost_block.
7788         (parse_exp_in_context): Remove.
7789         (parse_expression_for_completion): Update.
7790         * objfiles.c (~objfile): Don't reset expression_context_block or
7791         innermost_block.
7792         * expression.h (enum innermost_block_tracker_type): Move from
7793         parser-defs.h.
7794         (parse_exp_1): Add tracker_types parameter.
7795         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7796         reset innermost_block.
7797
7798 2019-03-23  Tom Tromey  <tom@tromey.com>
7799
7800         * objfiles.h: Include bcache.h.
7801
7802 2019-03-23  Tom Tromey  <tom@tromey.com>
7803
7804         * linespec.c (get_current_search_block): Use
7805         scoped_restore_current_language.
7806         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7807
7808 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7809             Jiong Wang  <jiong.wang@arm.com>
7810
7811         * aarch64-linux-tdep.c
7812         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7813         section.
7814         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7815
7816 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7817             Jiong Wang  <jiong.wang@arm.com>
7818
7819         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7820         instructions.
7821         (aarch64_analyze_prologue_test): Add PACIASP test.
7822         (aarch64_prologue_prev_register): Unmask PC value.
7823
7824 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7825             Jiong Wang  <jiong.wang@arm.com>
7826
7827         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7828         (aarch64_dwarf2_prev_register): Unmask PC value.
7829         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7830         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7831         DW_CFA_AARCH64_negate_ra_state.
7832         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7833
7834 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7835             Jiong Wang  <jiong.wang@arm.com>
7836
7837         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7838         registers.
7839         (aarch64_pseudo_register_name): Likewise.
7840         (aarch64_pseudo_register_type): Likewise.
7841         (aarch64_pseudo_register_reggroup_p): Likewise.
7842         (aarch64_gdbarch_init): Add pauth registers.
7843         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7844         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7845         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7846         (struct gdbarch_tdep): Add regnum for ra_state.
7847
7848 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7849             Jiong Wang  <jiong.wang@arm.com>
7850
7851         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7852
7853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7854             Jiong Wang  <jiong.wang@arm.com>
7855
7856         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7857         function.
7858         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7859         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7860         (aarch64_gdbarch_init): Add puth registers.
7861         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7862         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7863         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7864
7865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7866             Jiong Wang  <jiong.wang@arm.com>
7867
7868         * aarch64-linux-nat.c
7869         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7870         * aarch64-linux-tdep.c
7871         (aarch64_linux_core_read_description): Likewise.
7872         (aarch64_linux_get_hwcap): New function.
7873         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7874         (aarch64_linux_get_hwcap): New declaration.
7875
7876 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7877             Jiong Wang  <jiong.wang@arm.com>
7878
7879         * aarch64-linux-nat.c
7880         (aarch64_linux_nat_target::read_description): Add pauth param.
7881         * aarch64-linux-tdep.c
7882         (aarch64_linux_core_read_description): Likewise.
7883         * aarch64-tdep.c (struct target_desc): Add in pauth.
7884         (aarch64_read_description): Add pauth param.
7885         (aarch64_gdbarch_init): Likewise.
7886         * aarch64-tdep.h (aarch64_read_description): Likewise.
7887         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7888         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7889         * features/Makefile: Add new files.
7890         * features/aarch64-pauth.c: New file.
7891         * features/aarch64-pauth.xml: New file.
7892
7893 2019-03-20  Tom Tromey  <tromey@adacore.com>
7894
7895         * infrun.c (handle_inferior_event): Rename from
7896         handle_inferior_event_1.  Create a scoped_value_mark.
7897         (handle_inferior_event): Remove.
7898
7899 2019-03-19  Tom Tromey  <tromey@adacore.com>
7900
7901         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7902         * infrun.h (print_stop_event): Add "displays" parameter.
7903         * infrun.c (print_stop_event): Add "displays" parameter.
7904
7905 2019-03-19  Pedro Alves  <palves@redhat.com>
7906
7907         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7908         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7909         to -1.  Fix TABs vs spaces.
7910         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7911         * tui/tui-out.h (tui_ui_out) Add intro comments.
7912         <m_line, m_start_of_line>: In-class initialize, and add describing
7913         comment.
7914
7915 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7916
7917         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7918         variable names.
7919         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7920
7921 2019-03-18  Pedro Alves  <palves@redhat.com>
7922             Eli Zaretskii <eliz@gnu.org>
7923
7924         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7925         m_line and m_start_of_line.
7926
7927 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7928
7929         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7930         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7931         it returns a newline.  This fixes a regression in TU mode, whereby
7932         the next line is output on the same screen line as the user input.
7933
7934 2019-03-18  Tom Tromey  <tromey@adacore.com>
7935
7936         * minsyms.c (minimal_symbol_reader::install): Remove call to
7937         obstack_blank.
7938
7939 2019-03-18  Pedro Alves  <palves@redhat.com>
7940
7941         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7942         New globals.
7943         (apply_style): New, factored out from ...
7944         (apply_ansi_escape): ... this.  Handle reverse video mode.
7945         (tui_set_reverse_mode): New function.
7946         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7947         * tui/tui-winsource.c (tui_show_source_line): Use
7948         tui_set_reverse_mode instead of setting A_STANDOUT.
7949         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7950         New setter methods.
7951
7952 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7953
7954         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7955         Handle tabs.
7956
7957 2019-03-18  Tom Tromey  <tromey@adacore.com>
7958
7959         * ada-lang.c (empty_array): Add "high" parameter.
7960         (ada_evaluate_subexp): Update.
7961
7962 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7963
7964         * unittests/string_view-selftests.c: Define
7965         _initialize_string_view_selftests unconditionally.
7966
7967 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7968
7969         PR gdb/24350
7970         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7971
7972 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7973
7974         PR gdb/24351
7975         * windows-nat.c (display_selector): Fix format specifiers.
7976
7977 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7978
7979         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7980         tui_refill_source_window instead of tui_refresh_win, to update the
7981         current execution line.  This fixes redisplay of the current line
7982         when stepping through the code with "next" or "step".
7983
7984 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7985
7986         * source-cache.c (source_cache::get_source_lines): Call
7987         find_source_lines to initialize s->nlines.  This fixes vertical
7988         scrolling of TUI source window when the DOWN arrow is pressed.
7989
7990 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7991
7992         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7993         linux-thread-db.c (_initialize_thread_db): Likewise.
7994
7995 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7996
7997         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7998         wclrtoeol in tui_show_source_line".  This reverts changes made in
7999         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8000
8001 2019-03-15  Tom Tromey  <tom@tromey.com>
8002
8003         * symtab.h (struct minimal_symbol): Derive from
8004         general_symbol_info.
8005         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8006         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8007         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8008         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8009         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8010         (MSYMBOL_SEARCH_NAME): Update.
8011         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8012         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8013         * minsyms.c (minimal_symbol_reader::record_full): Update.
8014
8015 2019-03-15  Tom Tromey  <tom@tromey.com>
8016
8017         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8018
8019 2019-03-15  Tom Tromey  <tom@tromey.com>
8020
8021         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8022         unique_xmalloc_ptr.
8023         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8024         Update.
8025         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8026         (build_minimal_symbol_hash_tables)
8027         (minimal_symbol_reader::install): Update.
8028
8029 2019-03-15  Tom Tromey  <tom@tromey.com>
8030
8031         * symtab.c (create_demangled_names_hash): Update.
8032         (symbol_set_names): Update.
8033         * objfiles.h (struct objfile_per_bfd_storage)
8034         <demangled_names_hash>: Now an htab_up.
8035         * objfiles.c (objfile_per_bfd_storage): Simplify.
8036
8037 2019-03-15  Tom Tromey  <tom@tromey.com>
8038
8039         * objfiles.h (struct objfile_per_bfd_storage): Declare
8040         destructor.
8041         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8042         New.
8043         (get_objfile_bfd_data): Use new.  Don't initialize
8044         language_of_main.
8045         (free_objfile_per_bfd_storage): Remove.
8046         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8047
8048 2019-03-15  Tom Tromey  <tom@tromey.com>
8049
8050         * symfile.c (reread_symbols): Update.
8051         * objfiles.c (objfile::objfile): Update.
8052         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8053         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8054         comment.
8055         (minimal_symbol_reader::install): Update.
8056         (terminate_minimal_symbol_table): Remove.
8057         * jit.c (jit_object_close_impl): Update.
8058
8059 2019-03-15  Tom Tromey  <tom@tromey.com>
8060
8061         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8062         initializations.
8063
8064 2019-03-15  Tom Tromey  <tom@tromey.com>
8065
8066         * objfiles.h (struct objfile_per_bfd_storage)
8067         <demangled_hash_languages>: Now a bitset.
8068         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8069         (lookup_minimal_symbol): Update.
8070
8071 2019-03-15  Tom Tromey  <tom@tromey.com>
8072
8073         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8074         Don't return the symbol.
8075         * coffread.c (record_minimal_symbol): Use record_full.
8076
8077 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8078
8079         The MS-Windows port of ncurses fails to switch to a color pair if
8080         one or both of the colors are the implicit default colors.  This
8081         change records the default colors when TUI is initialized, and
8082         then specifies them explicitly when a color pair uses the default
8083         colors.  This allows color styling in TUI mode on MS-Windows.
8084
8085         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8086         ncurses_norm_attr.
8087         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8088         colors in ncurses_norm_attr.
8089         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8090         "none", replace it with the default color recorded in
8091         ncurses_norm_attr.
8092
8093 2019-03-14  Tom Tromey  <tromey@adacore.com>
8094
8095         * source-cache.h (class source_cache) <get_source_lines>: Return
8096         std::string.
8097         * source-cache.c (source_cache::extract_lines): Handle case where
8098         first_pos==npos.  Return std::string.
8099         (source_cache::get_source_lines): Update.
8100
8101 2019-03-14  Tom Tromey  <tromey@adacore.com>
8102
8103         * NEWS: Add item for "style sources" commands.
8104         * source-cache.c (source_cache::get_source_lines): Check
8105         source_styling.
8106         * cli/cli-style.c (source_styling): New global.
8107         (_initialize_cli_style): Add "style sources" commands.
8108         (show_style_sources): New function.
8109         * cli/cli-style.h (source_styling): Declare.
8110
8111 2019-03-14  Pedro Alves  <palves@redhat.com>
8112             Tom Tromey  <tromey@adacore.com>
8113
8114         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8115         * tui/tui-winsource.c (tui_refill_source_window): New function,
8116         from...
8117         (tui_horizontal_source_scroll): ... here.  Move some logic.
8118         * cli/cli-style.c (set_style_enabled): Notify new observable.
8119         * tui/tui-hooks.c (tui_redisplay_source): New function.
8120         (tui_attach_detach_observers): Attach or detach
8121         tui_redisplay_source.
8122         * observable.h (source_styling_changed): New observable.
8123         * observable.c: Define source_styling_changed observable.
8124
8125 2019-03-13  Tom Tromey  <tromey@adacore.com>
8126
8127         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8128         (i386_gnu_nat_target::store_registers): Update.
8129         * target-debug.h (target_debug_print_std_string): New macro.
8130         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8131         * windows-tdep.c (display_one_tib): Update.
8132         * tui/tui-stack.c (tui_make_status_line): Update.
8133         * top.c (print_inferior_quit_action): Update.
8134         * thread.c (thr_try_catch_cmd): Update.
8135         (add_thread_with_info): Update.
8136         (thread_target_id_str): Update.
8137         (thr_try_catch_cmd): Update.
8138         (thread_command): Update.
8139         (thread_find_command): Update.
8140         * record-btrace.c (record_btrace_target::info_record)
8141         (record_btrace_resume_thread, record_btrace_target::resume)
8142         (record_btrace_cancel_resume, record_btrace_step_thread)
8143         (record_btrace_target::wait, record_btrace_target::wait)
8144         (record_btrace_target::wait, record_btrace_target::stop): Update.
8145         * progspace.c (print_program_space): Update.
8146         * process-stratum-target.c
8147         (process_stratum_target::thread_address_space): Update.
8148         * linux-fork.c (linux_fork_mourn_inferior)
8149         (detach_checkpoint_command, info_checkpoints_command)
8150         (linux_fork_context): Update.
8151         (linux_fork_detach): Update.
8152         (class scoped_switch_fork_info): Update.
8153         (delete_checkpoint_command): Update.
8154         * infrun.c (follow_fork_inferior): Update.
8155         (follow_fork_inferior): Update.
8156         (proceed_after_vfork_done): Update.
8157         (handle_vfork_child_exec_or_exit): Update.
8158         (follow_exec): Update.
8159         (displaced_step_prepare_throw): Update.
8160         (displaced_step_restore): Update.
8161         (start_step_over): Update.
8162         (resume_1): Update.
8163         (clear_proceed_status_thread): Update.
8164         (proceed): Update.
8165         (print_target_wait_results): Update.
8166         (do_target_wait): Update.
8167         (context_switch): Update.
8168         (stop_all_threads): Update.
8169         (restart_threads): Update.
8170         (finish_step_over): Update.
8171         (handle_signal_stop): Update.
8172         (switch_back_to_stepped_thread): Update.
8173         (keep_going_pass_signal): Update.
8174         (print_exited_reason): Update.
8175         (normal_stop): Update.
8176         * inferior.c (inferior_pid_to_str): Change return type.
8177         (print_selected_inferior): Update.
8178         (add_inferior): Update.
8179         (detach_inferior): Update.
8180         * dummy-frame.c (fprint_dummy_frames): Update.
8181         * dcache.c (dcache_info_1): Update.
8182         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8183         (btrace_fetch, btrace_clear): Update.
8184         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8185         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8186         type.
8187         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8188         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8189         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8190         * gdbarch.c, gdbarch.h: Rebuild.
8191         * gdbarch.sh (core_pid_to_str): Change return type.
8192         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8193         return type.
8194         (windows_nat_target::pid_to_str): Change return type.
8195         (windows_delete_thread): Update.
8196         (windows_nat_target::attach): Update.
8197         (windows_nat_target::files_info): Update.
8198         * target-delegates.c: Rebuild.
8199         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8200         return type.
8201         (sol_thread_target::pid_to_str): Change return type.
8202         * remote.c (class remote_target) <pid_to_str>: Change return
8203         type.
8204         (remote_target::pid_to_str): Change return type.
8205         (extended_remote_target::attach, remote_target::remote_stop_ns)
8206         (remote_target::remote_notif_remove_queued_reply)
8207         (remote_target::push_stop_reply, remote_target::disable_btrace):
8208         Update.
8209         (extended_remote_target::attach): Update.
8210         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8211         type.
8212         (gdbsim_target::pid_to_str): Change return type.
8213         * ravenscar-thread.c (struct ravenscar_thread_target)
8214         <pid_to_str>: Change return type.
8215         (ravenscar_thread_target::pid_to_str): Change return type.
8216         * procfs.c (class procfs_target) <pid_to_str>: Change return
8217         type.
8218         (procfs_target::pid_to_str): Change return type.
8219         (procfs_target::attach): Update.
8220         (procfs_target::detach): Update.
8221         (procfs_target::fetch_registers): Update.
8222         (procfs_target::store_registers): Update.
8223         (procfs_target::wait): Update.
8224         (procfs_target::files_info): Update.
8225         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8226         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8227         return type.
8228         (nto_procfs_target::pid_to_str): Change return type.
8229         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8230         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8231         return type.
8232         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8233         (exit_lwp): Update.
8234         (attach_proc_task_lwp_callback, get_detach_signal)
8235         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8236         (linux_nat_target::resume, wait_lwp, stop_callback)
8237         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8238         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8239         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8240         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8241         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8242         type.
8243         (inf_ptrace_target::attach): Update.
8244         (inf_ptrace_target::files_info): Update.
8245         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8246         type.
8247         (go32_nat_target::pid_to_str): Change return type.
8248         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8249         (gnu_nat_target::wait): Update.
8250         (gnu_nat_target::wait): Update.
8251         (gnu_nat_target::resume): Update.
8252         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8253         (fbsd_nat_target::wait): Update.
8254         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8255         type.
8256         (darwin_nat_target::attach): Update.
8257         * corelow.c (class core_target) <pid_to_str>: Change return type.
8258         (core_target::pid_to_str): Change return type.
8259         * target.c (normal_pid_to_str): Change return type.
8260         (default_pid_to_str): Likewise.
8261         (target_pid_to_str): Change return type.
8262         (target_translate_tls_address): Update.
8263         (target_announce_detach): Update.
8264         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8265         return type.
8266         (bsd_uthread_target::pid_to_str): Change return type.
8267         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8268         type.
8269         (bsd_kvm_target::pid_to_str): Change return type.
8270         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8271         return type.
8272         (aix_thread_target::pid_to_str): Change return type.
8273         * target.h (struct target_ops) <pid_to_str>: Change return type.
8274         (target_pid_to_str, normal_pid_to_str): Likewise.
8275         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8276         type.
8277         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8278         type.
8279         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8280         return type.
8281         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8282         type.
8283         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8284         type.
8285         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8286         return type.
8287
8288 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8289
8290         * NEWS: Mention that the new default MI version is 3.  Mention
8291         changes to the output of commands and events that deal with
8292         multi-location breakpoints.
8293         * breakpoint.c: Include "mi/mi-out.h".
8294         (print_one_breakpoint): Change output syntax if using MI version
8295         >= 3.
8296         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8297         New.
8298         (mi_multi_location_breakpoint_output_fixed): New.
8299         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8300         (mi_cmd_fix_multi_location_breakpoint_output): New.
8301         (mi_multi_location_breakpoint_output_fixed): New.
8302         * mi/mi-cmds.c (mi_cmds): Register command
8303         -fix-multi-location-breakpoint-output.
8304         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8305         interpreter "mi".
8306
8307 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8308
8309         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8310         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8311         instantiate mi_ui_out based on interpreter name.
8312         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8313         * mi/mi-main.c (mi_load_progress): Likewise.
8314
8315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8316
8317         * NEWS: Combine separate "New targets" sections for 8.3.
8318
8319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8320
8321         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8322         (ppcfbsd_init_abi): Install gdbarch
8323         "fetch_tls_load_module_address" and "get_thread_local_address"
8324         methods.
8325
8326 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8327
8328         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8329         (riscv_fbsd_init_abi): Install gdbarch
8330         "fetch_tls_load_module_address" and "get_thread_local_address"
8331         methods.
8332
8333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8334
8335         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8336         (i386fbsd_init_abi): Install gdbarch
8337         "fetch_tls_load_module_address" and "get_thread_local_address"
8338         methods.
8339
8340 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8341
8342         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8343         (amd64fbsd_init_abi): Install gdbarch
8344         "fetch_tls_load_module_address" and "get_thread_local_address"
8345         methods.
8346
8347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8348
8349         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8350         (struct fbsd_pspace_data): New type.
8351         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8352         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8353         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8354         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8355         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8356
8357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8358
8359         * gdbtypes.c (lookup_struct_elt): New function.
8360         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8361         * gdbtypes.h (struct struct_elt): New type.
8362         (lookup_struct_elt): New prototype.
8363
8364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8365
8366         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8367         remove disabled code block.
8368
8369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8370
8371         * gdbarch.sh (get_thread_local_address): New method.
8372         * gdbarch.h, gdbarch.c: Regenerate.
8373         * target.c (target_translate_tls_address): Use
8374         gdbarch_get_thread_local_address if present instead of
8375         target::get_thread_local_address.
8376
8377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8378
8379         * target.h (target::get_thread_local_address): Update comment.
8380
8381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8382
8383         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8384         objfile->separate_debug_objfile_backlink if not NULL.
8385
8386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8387
8388         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8389         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8390         (amd64bsd_store_inferior_registers): Likewise.
8391         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8392         Enable segment base registers.
8393         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8394         PT_GETFSBASE and PT_GETGSBASE.
8395         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8396         PT_SETGSBASE.
8397         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8398         segment base registers.
8399         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8400
8401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8402
8403         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8404         Update calls to i386_target_description to add 'segments'
8405         parameter.
8406         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8407         add segment base registers.
8408         * arch/i386.c (i386_create_target_description): Add 'segments'
8409         parameter to enable segment base registers.
8410         * arch/i386.h (i386_create_target_description): Likewise.
8411         * features/i386/32bit-segments.xml: New file.
8412         * features/i386/32bit-segments.c: Generate.
8413         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8414         call to i386_target_description to add 'segments' parameter.
8415         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8416         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8417         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8418         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8419         if feature is present.
8420         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8421         Add 'segments' parameter to call to i386_target_description.
8422         (i386_target_description): Add 'segments' parameter to enable
8423         segment base registers.
8424         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8425         to call to i386_target_description.
8426         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8427         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8428         Define I386_NUM_REGS.
8429         (i386_target_description): Add 'segments' parameter to enable
8430         segment base registers.
8431
8432 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8433
8434         PR/24325
8435         * source-cache.c: #undef open and close, to avoid unresolved
8436         externals during linking.
8437
8438 2019-03-12  Tom Tromey  <tromey@adacore.com>
8439
8440         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8441         const.  Add initializers.
8442         (_initialize_remote): Don't initialize ptid globals.
8443
8444 2019-03-12  Pedro Alves  <palves@redhat.com>
8445
8446         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8447
8448 2019-03-12  Pedro Alves  <palves@redhat.com>
8449
8450         * cp-name-parser.y (main): Remove unused 'len' variable.
8451
8452 2019-03-12  Tom Tromey  <tromey@adacore.com>
8453
8454         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8455         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8456
8457 2019-03-12  Tom Tromey  <tromey@adacore.com>
8458
8459         * linux-nat.c (iterate_over_lwps): Update.
8460         (stop_callback): Remove parameter.
8461         (stop_wait_callback, detach_callback, resume_set_callback)
8462         (select_singlestep_lwp_callback, set_ignore_sigint)
8463         (status_callback, resumed_callback, resume_clear_callback)
8464         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8465         data parameter.
8466         (linux_nat_target::detach, linux_nat_target::resume)
8467         (linux_stop_and_wait_all_lwps, select_event_lwp)
8468         (linux_nat_filter_event, linux_nat_wait_1)
8469         (linux_nat_target::kill, linux_nat_target::stop)
8470         (linux_nat_target::stop): Update.
8471         (linux_nat_resume_callback): Change type.
8472         (resume_stopped_resumed_lwps, count_events_callback)
8473         (select_event_lwp_callback): Likewise.
8474         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8475         * arm-linux-nat.c (struct update_registers_data): Remove.
8476         (update_registers_callback): Change type.
8477         (arm_linux_insert_hw_breakpoint1): Update.
8478         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8479         parameter.
8480         (x86_linux_dr_set_addr): Update.
8481         (x86_linux_dr_set_control): Update.
8482         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8483         (iterate_over_lwps): Use gdb::function_view.
8484         * nat/aarch64-linux-hw-point.c (struct
8485         aarch64_dr_update_callback_param): Remove.
8486         (debug_reg_change_callback): Change type.
8487         (aarch64_notify_debug_reg_change): Update.
8488         * s390-linux-nat.c (s390_refresh_per_info): Update.
8489
8490 2019-03-11  Tom Tromey  <tromey@adacore.com>
8491
8492         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8493         redundant assignment to "this_cu".
8494
8495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8496
8497         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8498
8499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8500
8501         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8502         from...
8503         (rank_one_type): ... this.
8504
8505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8506
8507         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8508         from...
8509         (rank_one_type): ... this.
8510
8511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8512
8513         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8514         from...
8515         (rank_one_type): ... this.
8516
8517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8518
8519         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8520         from...
8521         (rank_one_type): ... this.
8522
8523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8524
8525         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8526         from...
8527         (rank_one_type): ... this.
8528
8529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8530
8531         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8532         from...
8533         (rank_one_type): ... this.
8534
8535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8536
8537         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8538         from...
8539         (rank_one_type): ... this.
8540
8541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8542
8543         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8544         from...
8545         (rank_one_type): ... this.
8546
8547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8548
8549         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8550         from...
8551         (rank_one_type): ... this.
8552
8553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8554
8555         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8556         from...
8557         (rank_one_type): ... this.
8558
8559 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8560
8561         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8562         from...
8563         (rank_one_type): ... this.
8564
8565 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8566
8567         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8568         from...
8569         (rank_one_type): ... this.
8570
8571 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8572
8573         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8574         inferior-events' shows the example events.
8575
8576 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8577
8578         Support styling on native MS-Windows console
8579
8580         PR/24315
8581         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8582         on MS-Windows if $TERM is not defined.
8583
8584         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8585
8586         * posix-hdep.c (gdb_console_fputs):
8587         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8588         functions.
8589         * ui-file.h (gdb_console_fputs): Add prototype.
8590
8591         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8592         back to fputs only if the former returns zero.
8593
8594 2019-03-07  Tom Tromey  <tom@tromey.com>
8595
8596         * symmisc.c (print_symbol_bcache_statistics): Update.
8597         (print_objfile_statistics): Update.
8598         * symfile.c (allocate_symtab): Update.
8599         * stabsread.c: Don't include bcache.h.
8600         * psymtab.h (struct psymbol_bcache): Don't declare.
8601         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8602         (psymbol_bcache_init, psymbol_bcache_free)
8603         (psymbol_bcache_get_bcache): Don't declare.
8604         * psymtab.c (struct psymbol_bcache): Remove.
8605         (psymtab_storage::psymtab_storage): Update.
8606         (psymtab_storage::~psymtab_storage): Update.
8607         (psymbol_bcache_init, psymbol_bcache_free)
8608         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8609         (add_psymbol_to_bcache): Update.
8610         (allocate_psymtab): Update.
8611         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8612         macro_cache>: No longer pointers.
8613         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8614         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8615         * macrotab.c (macro_bcache): Update.
8616         * macroexp.c: Don't include bcache.h.
8617         * gdbtypes.c (check_types_worklist): Update.
8618         (types_deeply_equal): Remove TRY/CATCH.  Update.
8619         * elfread.c (elf_symtab_read): Update.
8620         * dwarf2read.c: Don't include bcache.h.
8621         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8622         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8623         (print_bcache_statistics, bcache_memory_used): Don't declare.
8624         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8625         methods.  Rename all data members.
8626         * bcache.c (struct bcache): Move to bcache.h.
8627         (bcache::expand_hash_table): Rename from expand_hash_table.
8628         (bcache): Remove.
8629         (bcache::insert): Rename from bcache_full.
8630         (bcache::compare): Rename from bcache_compare.
8631         (bcache_xmalloc): Remove.
8632         (bcache::~bcache): Rename from bcache_xfree.
8633         (bcache::print_statistics): Rename from print_bcache_statistics.
8634         (bcache::memory_used): Rename from bcache_memory_used.
8635
8636 2019-03-07  Pedro Alves  <palves@redhat.com>
8637
8638         * infrun.c (normal_stop): Also check for
8639         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8640
8641 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8642
8643         * f-lang.c (value_from_host_double): Moved to...
8644         * value.c (value_from_host_double): ...here.
8645         * value.h (value_from_host_double): Declare.
8646         * guile/scm-math.c (vlscm_convert_typed_number): Use
8647         value_from_host_double.
8648         (vlscm_convert_number): Likewise.
8649         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8650         * python/py-value.c (convert_value_from_python): Likewise.
8651
8652 2019-03-06  Tom Tromey  <tom@tromey.com>
8653
8654         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8655
8656 2019-03-06  Tom Tromey  <tom@tromey.com>
8657
8658         * utils.h (free_current_contents): Don't declare.
8659         * utils.c (free_current_contents): Remove.
8660
8661 2019-03-06  Tom Tromey  <tom@tromey.com>
8662
8663         * top.c (quit_force): Update.
8664         * main.c (captured_command_loop): Update.
8665         * common/new-op.c (operator new): Update.
8666         * common/common-exceptions.c (struct catcher)
8667         <save_cleanup_chain>: Remove member.
8668         (exceptions_state_mc_init): Update.
8669         (exception_try_scope_entry): Return nullptr.
8670         (exception_try_scope_exit, exception_rethrow)
8671         (throw_exception_sjlj, throw_exception_cxx): Update.
8672         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8673         (all_cleanups, do_cleanups, discard_cleanups)
8674         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8675         (restore_cleanups, restore_final_cleanups): Don't declare.
8676         (do_final_cleanups): Remove parameter.
8677         * common/cleanups.c (cleanup_chain, make_cleanup)
8678         (make_cleanup_dtor, all_cleanups, do_cleanups)
8679         (discard_my_cleanups, discard_cleanups)
8680         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8681         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8682         (null_cleanup): Remove.
8683         (do_final_cleanups): Remove parameter.
8684
8685 2019-03-06  Tom Tromey  <tom@tromey.com>
8686
8687         * remote.c (remote_target::remote_parse_stop_reply): Use
8688         unique_xmalloc_ptr.
8689
8690 2019-03-06  Tom Tromey  <tom@tromey.com>
8691
8692         * stabsread.c (struct stabs_field_info): Rename from field_info.
8693         <list, fnlist>: Add initializers.
8694         <obstack>: New member.
8695         (read_member_functions, read_struct_fields, read_baseclasses):
8696         Allocate on obstack.  Don't use cleanups.
8697         (read_one_struct_field, read_member_functions, read_struct_fields)
8698         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8699         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8700         (read_struct_type): Update.
8701
8702 2019-03-06  Tom Tromey  <tom@tromey.com>
8703
8704         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8705         * common/filestuff.h (make_cleanup_close): Don't declare.
8706         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8707         Remove.
8708
8709 2019-03-06  Tom Tromey  <tom@tromey.com>
8710
8711         * solib-aix.c: Use make_scope_exit.
8712
8713 2019-03-06  Tom Tromey  <tom@tromey.com>
8714
8715         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8716         Use make_scope_exit.
8717
8718 2019-03-06  Tom Tromey  <tom@tromey.com>
8719
8720         * solib-svr4.c (disable_probes_interface): Remove parameter.
8721         (svr4_handle_solib_event): Use make_scope_exit.
8722
8723 2019-03-06  Tom Tromey  <tom@tromey.com>
8724
8725         * remote.c (struct stop_reply_deleter): Remove.
8726         (stop_reply_up): Update.
8727         (struct stop_reply): Derive from notif_event.  Don't typedef.
8728         <regcache>: Now a std::vector.
8729         (stop_reply_xfree): Remove.
8730         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8731         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8732         (remote_target::discard_pending_stop_replies): Use delete.
8733         (remote_target::remote_parse_stop_reply): Update.
8734         (remote_target::process_stop_reply): Update.
8735         * remote-notif.h (struct notif_event): Add virtual destructor.
8736         Remove "dtr" member.
8737         (struct notif_client) <alloc_event>: Return a unique_ptr.
8738         (notif_event_xfree): Don't declare.
8739         (notif_event_up): New typedef.
8740         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8741         (notif_event_xfree, do_notif_event_xfree): Remove.
8742         (remote_notif_state_xfree): Update.
8743
8744 2019-03-06  Tom Tromey  <tom@tromey.com>
8745
8746         * infrun.c (displaced_step_clear_cleanup): Now a
8747         forward_scope_exit type.
8748         (displaced_step_prepare_throw): Update.
8749         (displaced_step_fixup): Update.
8750
8751 2019-03-06  Tom Tromey  <tom@tromey.com>
8752
8753         * inferior.h (class inferior): Update comment.
8754         * gdbthread.h (class thread_info): Update comment.
8755
8756 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8757             Tom Tromey  <tom@tromey.com>
8758
8759         * stabsread.h (struct stab_section_list): Remove.
8760         (coffstab_build_psymtabs): Update.
8761         * dbxread.c (symbuf_sections): Now a std::vector.
8762         (sect_idx): New global.
8763         (fill_symbuf): Update.
8764         (coffstab_build_psymtabs): Change type of stabsects parameter.
8765         Update.
8766         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8767         std::vector.
8768         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8769         (coff_locate_sections): Update.
8770         (coff_symfile_read): Remove cleanups.  Update.
8771         (init_stringtab): Add storage parameter.
8772         (free_stringtab, free_stringtab_cleanup): Remove.
8773         (init_lineno): Add storage parameter.
8774         (free_linetab, free_linetab_cleanup): Remove.
8775
8776 2019-03-06  Pedro Alves  <palves@redhat.com>
8777
8778         * linux-fork.c (fork_info::clobber_regs): Delete.
8779         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8780         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8781         comment.  Adjust.
8782         (scoped_switch_fork_info::scoped_switch_fork_info)
8783         (checkpoint_command, linux_fork_context): Adjust
8784         fork_save_infrun_state calls.
8785
8786 2019-03-06  Pedro Alves  <palves@redhat.com>
8787
8788         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8789         (inf_has_multiple_threads): Return 'bool' and rewrite using
8790         inferior_info::threads().
8791
8792 2019-03-06  Pedro Alves  <palves@redhat.com>
8793
8794         * linux-fork.c: Include <list>.
8795         (fork_list): Now a std::list instance.
8796         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8797         (forks_exist_p, find_last_fork): Adjust.
8798         (new_fork): Delete.
8799         (one_fork_p): New.
8800         (add_fork): Adjust.
8801         (free_fork): Delete, folded into fork_info::~fork_info().
8802         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8803         Adjust.
8804         (init_fork_list): Delete.
8805         (linux_fork_killall, linux_fork_mourn_inferior)
8806         (linux_fork_detach, info_checkpoints_command): Adjust.
8807         (_initialize_linux_fork): No longer call init_fork_list.
8808
8809 2019-03-06  Pedro Alves  <palves@redhat.com>
8810
8811         * linux-fork.c (new_fork): New, split out of ...
8812         (add_fork): ... this.  Return void.  Move "first fork" special
8813         case from here, to ...
8814         (checkpoint_command): ... here.
8815         * linux-linux.h (add_fork): Return void.
8816
8817 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8818
8819         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8820
8821 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8822             Chris January  <chris.january@arm.com>
8823             David Lecomber  <david.lecomber@arm.com>
8824
8825         * f-exp.y: New token, UNOP_INTRINSIC.
8826         (exp): New pattern using UNOP_INTRINSIC token.
8827         (f77_keywords): Add 'abs' keyword.
8828         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8829         (value_from_host_double): New function.
8830         (evaluate_subexp_f): Support UNOP_ABS.
8831
8832 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8835         types.
8836
8837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8838
8839         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8840         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8841         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8842
8843 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8846
8847 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8848             Chris January  <chris.january@arm.com>
8849
8850         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8851         * f-exp.y: Define 'KIND' token.
8852         (exp): New pattern for KIND expressions.
8853         (ptype): Handle types with a kind extension.
8854         (direct_abs_decl): Extend to spot kind extensions.
8855         (f77_keywords): Add 'kind' to the list.
8856         (push_kind_type): New function.
8857         (convert_to_kind_type): New function.
8858         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8859         * parse.c (operator_length_standard): Likewise.
8860         * parser-defs.h (enum type_pieces): Add tp_kind.
8861         * std-operator.def: Add UNOP_KIND.
8862
8863 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8864
8865         * f-exp.y (f_parse): Set yydebug.
8866
8867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8868
8869         * f-lang.c (evaluate_subexp_f): New function.
8870         (exp_descriptor_f): New global.
8871         (f_language_defn): Use exp_descriptor_f instead of
8872         exp_descriptor_standard.
8873
8874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8875
8876         * f-exp.y (struct token): Add comments.
8877         (dot_ops): Remove uppercase versions and the end marker.
8878         (f77_keywords): Likewise.
8879         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8880         entries in the dot_ops array are case insensitive, and use
8881         strncasecmp to compare strings.  Also some whitespace cleanup in
8882         this area.  Similar for the f77_keywords array, except entries in
8883         this list might be case sensitive.
8884
8885 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8886
8887         * f-exp.y (struct f77_boolean_val): Add comments.
8888         (boolean_values): Remove uppercase versions, and end marker.
8889         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8890         and use strncasecmp to achieve case insensitivity.  Additionally,
8891         perform whitespace cleanup around this code.
8892
8893 2019-03-06  Tom Tromey  <tromey@adacore.com>
8894
8895         * remote-sim.c (gdbsim_target_open): Use result of
8896         gdb_argv::release.
8897
8898 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8899         Dirk Schubert  <dirk.schubert@arm.com>
8900         Chris January  <chris.january@arm.com>
8901
8902         * eval.c (evaluate_subexp_standard): Call Fortran argument
8903         wrapping logic.
8904         * f-lang.c (struct value): A value which can be passed into a
8905         Fortran function call.
8906         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8907         where appropriate.
8908         (struct type): Value ready for a Fortran function call.
8909         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8910         is needed.
8911         * f-lang.h (fortran_argument_convert): Declaration.
8912         (fortran_preserve_arg_pointer): Declaration.
8913         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8914
8915 2019-03-05  Tom Tromey  <tromey@adacore.com>
8916
8917         * python/py-prettyprint.c (print_string_repr): Remove #if.
8918         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8919
8920 2019-03-05  Tom Tromey  <tromey@adacore.com>
8921
8922         * target.c (the_dummy_target): Move later.  Change type to
8923         "dummy_target".
8924         (initialize_targets): Don't initialize the_dummy_target.
8925
8926 2019-03-05  Tom Tromey  <tromey@adacore.com>
8927
8928         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8929         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8930
8931 2019-03-05  Tom Tromey  <tromey@adacore.com>
8932
8933         * windows-nat.c (windows_nat_target::attach)
8934         (windows_nat_target::detach): Don't call gdb_flush.
8935         * valprint.c (generic_val_print, val_print, val_print_string):
8936         Don't call gdb_flush.
8937         * utils.c (defaulted_query): Don't call gdb_flush.
8938         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8939         * target.c (target_announce_detach): Don't call gdb_flush.
8940         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8941         * remote.c (extended_remote_target::attach): Don't call
8942         gdb_flush.
8943         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8944         * printcmd.c (do_examine): Don't call gdb_flush.
8945         (info_display_command): Don't call gdb_flush.
8946         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8947         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8948         * memattr.c (info_mem_command): Don't call gdb_flush.
8949         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8950         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8951         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8952         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8953         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8954         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8955         (gnu_nat_target::detach): Don't call gdb_flush.
8956         * f-valprint.c (f_val_print): Don't call gdb_flush.
8957         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8958         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8959         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8960         gdb_flush.
8961         * c-valprint.c (c_val_print): Don't call gdb_flush.
8962         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8963
8964 2019-03-05  Tom Tromey  <tromey@adacore.com>
8965
8966         * varobj.c (update_dynamic_varobj_children): Update.
8967         (install_default_visualizer): Use reset, not release.
8968         * value.c (set_internalvar): Update.
8969         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8970         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8971         ATTRIBUTE_UNUSED_RESULT.
8972
8973 2019-03-05  Tom Tromey  <tromey@adacore.com>
8974
8975         * remote.c (class scoped_remote_fd) <release>: Add
8976         ATTRIBUTE_UNUSED_RESULT.
8977
8978 2019-03-05  Tom Tromey  <tromey@adacore.com>
8979
8980         * macroexp.c (struct macro_buffer) <release>: Add
8981         ATTRIBUTE_UNUSED_RESULT.
8982
8983 2019-03-05  Tom Tromey  <tromey@adacore.com>
8984
8985         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8986         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8987         ATTRIBUTE_UNUSED_RESULT.
8988
8989 2019-03-05  Tom Tromey  <tromey@adacore.com>
8990
8991         * common/scoped_fd.h (class scoped_fd) <release>: Add
8992         ATTRIBUTE_UNUSED_RESULT.
8993
8994 2019-03-05  Tom Tromey  <tromey@adacore.com>
8995
8996         * parser-defs.h (struct parser_state) <release>: Add
8997         ATTRIBUTE_UNUSED_RESULT.
8998
8999 2019-03-05  Tom Tromey  <tromey@adacore.com>
9000
9001         * utils.h (class gdb_argv) <release>: Add
9002         ATTRIBUTE_UNUSED_RESULT.
9003         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9004
9005 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9006
9007         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9008         for-loop range, to avoid compiler warnings.
9009
9010         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9011         avoid compiler warnings about unused variables.
9012
9013         * NEWS: Mention end of support for native debugging on MS-Windows
9014         before XP.
9015
9016         PR gdb/24292
9017         * common/netstuff.c:
9018         * gdbserver/gdbreplay.c
9019         * gdbserver/remote-utils.c:
9020         * ser-tcp.c:
9021         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9022         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9023         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9024         'getaddrinfo' and 'freeaddrinfo' were not available before
9025         Windows XP, and mingw.org's MinGW headers by default define
9026         _WIN32_WINNT to 0x500.
9027
9028 2019-03-01  Gary Benson <gbenson@redhat.com>
9029
9030         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9031
9032 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9033             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9034
9035         PR gdb/8527
9036         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9037         set_sigint_trap, clear_sigint_trap.
9038
9039 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9040
9041         * target.c (target_detach): Clear the regcache and the
9042         frame cache.
9043
9044 2019-02-27  Pedro Alves  <palves@redhat.com>
9045
9046         * utils.c (set_screen_size): When we cap the height/width sizes,
9047         tweak the corresponding command variable to show "unlimited":
9048
9049 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9050             Pedro Alves  <palves@redhat.com>
9051
9052         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9053         before calling rl_set_screen_size.
9054
9055 2019-02-27  Tom Tromey  <tromey@adacore.com>
9056
9057         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9058         define.
9059         * python/py-value.c: Remove Python 2.4 workaround.
9060         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9061         workaround.
9062         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9063         Python 2.4 workaround.
9064         * python/python-internal.h: Remove Python 2.4 comment.
9065         (Py_ssize_t): Don't define.
9066         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9067         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9068         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9069         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9070         * python/python.c (do_start_initialization): Remove Python 2.4
9071         workaround.
9072         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9073         (print_children): Remove Python 2.4 workaround.
9074         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9075         workaround.
9076         (CHARBUFFERPROC_NAME): Remove.
9077         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9078         Python 2.4 workaround.
9079
9080 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9081
9082         * NEWS: Note minimum Python version.
9083
9084 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9085
9086         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9087         code from these functions.  Remove corresponding ifdefs.  Use
9088         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9089         Remove gotos and target of gotos.
9090         (infpy_search_memory): Likewise.
9091
9092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9093
9094         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9095         (hppa_gdbarch_init): Don't register deleted functions with
9096         gdbarch.
9097
9098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9099
9100         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9101         (h8300_unwind_sp): Delete.
9102         (h8300_dummy_id): Delete.
9103         (h8300_gdbarch_init): Don't register deleted functions with
9104         gdbarch.
9105
9106 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9107
9108         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9109         (ft32_unwind_pc): Delete.
9110         (ft32_unwind_sp): Delete.
9111         (ft32_gdbarch_init): Don't register deleted functions with
9112         gdbarch.
9113
9114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9115
9116         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9117         (frv_unwind_pc): Delete.
9118         (frv_unwind_sp): Delete.
9119         (frv_gdbarch_init): Don't register deleted functions with
9120         gdbarch.
9121
9122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9123
9124         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9125         (riscv_unwind_pc): Delete.
9126         (riscv_unwind_sp): Delete.
9127         (riscv_gdbarch_init): Don't register deleted functions with
9128         gdbarch.
9129
9130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9131
9132         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9133         (csky_unwind_pc): Delete.
9134         (csky_unwind_sp): Delete.
9135         (csky_gdbarch_init): Don't register deleted functions with
9136         gdbarch.
9137
9138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9139
9140         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9141         (cris_unwind_pc): Delete.
9142         (cris_unwind_sp): Delete.
9143         (cris_gdbarch_init): Don't register deleted functions with
9144         gdbarch.
9145
9146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9147
9148         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9149         (bfin_unwind_pc): Delete.
9150         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9151
9152 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9153
9154         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9155         (arm_unwind_pc): Delete.
9156         (arm_unwind_sp): Delete.
9157         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9158
9159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9160
9161         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9162         (arc_unwind_pc): Delete.
9163         (arc_unwind_sp): Delete.
9164         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9165
9166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9167
9168         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9169         (alpha_unwind_pc): Delete.
9170         (alpha_gdbarch_init): Don't register deleted functions with
9171         gdbarch.
9172
9173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9174
9175         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9176         (aarch64_unwind_pc): Delete.
9177         (aarch64_unwind_sp): Delete.
9178         (aarch64_gdbarch_init): Don't register deleted functions with
9179         gdbarch.
9180
9181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9182
9183         * gdbtypes.c (type_align): Don't consider static members when
9184         computing structure alignment.
9185
9186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9187
9188         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9189         return 0 for other types.
9190         * arch-utils.c (default_type_align): Always return 0.
9191         * gdbarch.h: Regenerate.
9192         * gdbarch.sh (type_align): Extend comment.
9193         * gdbtypes.c (type_align): Add additional comments, always call
9194         gdbarch_type_align before applying the default rules.
9195         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9196         generic code will then apply a suitable default.
9197         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9198         types, return 0 for other types.
9199
9200 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9201
9202         * NEWS: Create a new section for the next release branch.
9203         Rename the section of the current branch, now that it has
9204         been cut.
9205
9206 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9207
9208         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9209         * version.in: Bump version to 8.3.50.DATE-git.
9210
9211 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9212
9213         * aix-thread.c (ptid_cmp): Remove unused variable.
9214         (get_signaled_thread): Likewise.
9215         (store_regs_user_thread): Likewise.
9216         (store_regs_kernel_thread): Likewise.
9217         (fetch_regs_kernel_thread): Remove shadowed variable.
9218
9219 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9220
9221         * features/riscv/32bit-cpu.xml: Add register numbers.
9222         * features/riscv/32bit-fpu.c: Regenerate.
9223         * features/riscv/32bit-fpu.xml: Add register numbers.
9224         * features/riscv/64bit-cpu.xml: Add register numbers.
9225         * features/riscv/64bit-fpu.c: Regenerate.
9226         * features/riscv/64bit-fpu.xml: Add register numbers.
9227
9228 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9229
9230         * NEWS: Mention two argument form of gdb.Value constructor.
9231         * python/py-value.c (convert_buffer_and_type_to_value): New
9232         function.
9233         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9234         Add support for handling an optional second argument.  Call
9235         convert_buffer_and_type_to_value as appropriate.
9236         * python/python-internal.h (Py_buffer_deleter): New struct.
9237         (Py_buffer_up): New typedef.
9238
9239 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9240
9241         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9242         instead of releasing ownership.
9243
9244 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9245
9246         * dwarf2read.c (open_and_init_dwp_file): Call
9247         elf_numsections instead of bfd_count_sections to initialize
9248         dwp_file->num_sections.
9249
9250 2019-02-25  Tom Tromey  <tromey@adacore.com>
9251
9252         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9253
9254 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9255
9256         * gcore.in: Add '--readnever' option when invoking GDB.
9257
9258 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9259
9260         * MAINTAINERS: Update my email address.
9261
9262 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9263
9264         * build-id.c (build_id_to_debug_bfd_1): New function.
9265         (build_id_to_debug_bfd): Look for separate debug file in
9266         sysroot.
9267
9268 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9269
9270         * gdbarch.sh: Update the copyright year range that is placed into
9271         generated files.
9272
9273 2019-02-22  Keith Seitz  <keiths@redhat.com>
9274
9275         PR symtab/23853
9276         * linespec.c (create_sals_line_offset): Search for the default
9277         symtab's filename instead of its fullname.
9278
9279 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9280
9281         * NEWS: Update style defaults.
9282
9283 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9284
9285         * main.c (captured_main_1): Disable styling in batch mode.
9286
9287 2019-02-20  Tom Tromey  <tom@tromey.com>
9288
9289         * symtab.c (symtab_symbol_info): Fix typos.
9290
9291 2019-02-20  Tom Tromey  <tromey@adacore.com>
9292
9293         * findcmd.c (_initialize_mem_search): Use upper case for
9294         metasyntactic variables.
9295
9296 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9297
9298         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9299         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9300
9301 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9302
9303         * top.h (source_file_name): Change to std::string.
9304         * top.c (source_file_name): Likewise.
9305         (command_line_input): Adjust.
9306         * cli/cli-script.c (script_from_file): Adjust.
9307
9308 2019-02-19  Tom Tromey  <tromey@adacore.com>
9309
9310         * ravenscar-thread.c
9311         (ravenscar_thread_target::update_thread_list): Don't call
9312         ada_build_task_list.
9313         * ada-lang.h (ada_build_task_list): Don't declare.
9314         * ada-tasks.c (struct ada_tasks_inferior_data)
9315         <task_list_valid_p>: Now bool.
9316         (read_known_tasks, ada_task_list_changed)
9317         (ada_tasks_invalidate_inferior_data): Update.
9318         (read_known_tasks_array): Return bool.
9319         (read_known_tasks_list): Likewise.
9320         (read_known_tasks): Return void.
9321         (ada_build_task_list): Now static.
9322
9323 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9324
9325         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9326         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9327
9328 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9329
9330         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9331         variant for ada_tasks_pspace_data_handle and
9332         ada_tasks_inferior_data_handle.
9333         (ada_tasks_pspace_data_cleanup): New function.
9334         (ada_tasks_inferior_data_cleanup): New function.
9335
9336 2019-02-17  Tom Tromey  <tom@tromey.com>
9337
9338         * macrotab.h (macro_source_fullname): Return a std::string.
9339         * macrotab.c (macro_include, check_for_redefinition)
9340         (macro_undef, macro_lookup_definition, foreach_macro)
9341         (foreach_macro_in_scope): Update.
9342         (macro_source_fullname): Return a std::string.
9343         * macrocmd.c (show_pp_source_pos): Update.
9344
9345 2019-02-17  Tom Tromey  <tom@tromey.com>
9346
9347         * macrocmd.c (show_pp_source_pos): Style the file names.
9348
9349 2019-02-17  Tom Tromey  <tom@tromey.com>
9350
9351         PR tui/24197:
9352         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9353
9354 2019-02-17  Tom Tromey  <tom@tromey.com>
9355
9356         * ada-lang.c (user_select_syms): Use filtered printing.
9357         * utils.c (wrap_style): New global.
9358         (desired_style): Remove.
9359         (emit_style_escape): Add stream parameter.
9360         (set_output_style, reset_terminal_style, prompt_for_continue):
9361         Update.
9362         (flush_wrap_buffer): Only flush gdb_stdout.
9363         (wrap_here): Set wrap_style.
9364         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9365         treat escape sequences as a character.  Change when wrap buffer is
9366         flushed.
9367         (fputs_styled): Do not set the output style when the default is
9368         requested.
9369         * ui-style.h (struct ui_file_style) <is_default>: New method.
9370         * source.c (print_source_lines_base): Emit escape sequences in one
9371         piece.
9372
9373 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9374
9375         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9376         integers and enumeration types.
9377
9378 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9379
9380         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9381         instead of lookup_symbol_in_language
9382         (do_exact_match): New function.
9383         (ada_get_symbol_name_matcher): Return do_exact_match when
9384         doing a verbatim match.
9385
9386 2019-02-15  Tom Tromey  <tromey@adacore.com>
9387
9388         * ravenscar-thread.c (ravenscar_thread_target::resume)
9389         (ravenscar_thread_target::wait): Special case wildcard requests.
9390
9391 2019-02-15  Tom Tromey  <tromey@adacore.com>
9392
9393         * ravenscar-thread.c (base_ptid): Remove.
9394         (struct ravenscar_thread_target) <close>: New method.
9395         <m_base_ptid>: New member.
9396         <update_inferior_ptid, active_task, task_is_currently_active,
9397         runtime_initialized>: Declare methods.
9398         <ravenscar_thread_target>: Add constructor.
9399         (ravenscar_thread_target::task_is_currently_active)
9400         (ravenscar_thread_target::update_inferior_ptid)
9401         (ravenscar_runtime_initialized): Rename.  Now methods.
9402         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9403         (ravenscar_thread_target::update_thread_list): Update.
9404         (ravenscar_thread_target::active_task): Now method.
9405         (ravenscar_thread_target::store_registers)
9406         (ravenscar_thread_target::prepare_to_store)
9407         (ravenscar_thread_target::prepare_to_store)
9408         (ravenscar_thread_target::mourn_inferior): Update.
9409         (ravenscar_inferior_created): Use "new" to create target.
9410         (ravenscar_thread_target::get_ada_task_ptid): Update.
9411         (_initialize_ravenscar): Don't initialize base_ptid.
9412         (ravenscar_ops): Remove global.
9413
9414 2019-02-15  Tom Tromey  <tromey@adacore.com>
9415
9416         * target.h (push_target): Declare new overload.
9417         * target.c (push_target): New overload, taking an rvalue reference.
9418         * remote.c (remote_target::open_1): Use push_target overload.
9419         * corelow.c (core_target_open): Use push_target overload.
9420
9421 2019-02-15  Tom Tromey  <tromey@adacore.com>
9422
9423         * ravenscar-thread.c (is_ravenscar_task)
9424         (ravenscar_task_is_currently_active): Return bool.
9425         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9426         (_initialize_ravenscar): Remove "(void)".
9427         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9428         Return bool.
9429
9430 2019-02-15  Tom Tromey  <tromey@adacore.com>
9431
9432         * ravenscar-thread.c (ravenscar_runtime_initializer)
9433         (has_ravenscar_runtime, get_running_thread_id)
9434         (ravenscar_thread_target::resume): Fix indentation.
9435
9436 2019-02-15  Tom Tromey  <tromey@adacore.com>
9437
9438         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9439         from ravenscar_arch_ops.
9440         (sparc_ravenscar_ops::fetch_registers)
9441         (sparc_ravenscar_ops::store_registers): Now methods.
9442         (sparc_ravenscar_prepare_to_store): Remove.
9443         (sparc_ravenscar_ops): Redefine.
9444         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9445         methods and destructor.  Remove members.
9446         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9447         (ravenscar_thread_target::store_registers)
9448         (ravenscar_thread_target::prepare_to_store): Update.
9449         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9450         Remove.
9451         (struct ppc_ravenscar_powerpc_ops): Derive from
9452         ravenscar_arch_ops.
9453         (ppc_ravenscar_powerpc_ops::fetch_registers)
9454         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9455         (ppc_ravenscar_powerpc_ops): Redefine.
9456         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9457         (ppc_ravenscar_e500_ops::fetch_registers)
9458         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9459         (ppc_ravenscar_e500_ops): Redefine.
9460         * aarch64-ravenscar-thread.c
9461         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9462         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9463         (aarch64_ravenscar_fetch_registers)
9464         (aarch64_ravenscar_store_registers): Now methods.
9465         (aarch64_ravenscar_ops): Redefine.
9466
9467 2019-02-15  Tom Tromey  <tromey@adacore.com>
9468
9469         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9470         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9471         (ravenscar_thread_target::stopped_by_watchpoint)
9472         (ravenscar_thread_target::stopped_data_address)
9473         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9474
9475 2019-02-15  Tom Tromey  <tromey@adacore.com>
9476
9477         * ravenscar-thread.c: Fix some typos.
9478
9479 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9480             Tom Tromey  <tromey@adacore.com>
9481
9482         * ada-lang.c (ada_exception_sal): Change addr_string to a
9483         std::string.
9484         (create_ada_exception_catchpoint): Update.
9485
9486 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9487             Tom Tromey  <tromey@adacore.com>
9488
9489         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9490         (bp_location_ops): Remove.
9491         (base_breakpoint_allocate_location): Update.
9492         (free_bp_location): Update.
9493         * ada-lang.c (class ada_catchpoint_location)
9494         <ada_catchpoint_location>: Remove ops parameter.
9495         (ada_catchpoint_location_dtor): Remove.
9496         (ada_catchpoint_location_ops): Remove.
9497         (allocate_location_exception): Update.
9498         * breakpoint.h (struct bp_location_ops): Remove.
9499         (class bp_location) <bp_location>: Remove bp_location_ops
9500         parameter.
9501         <~bp_location>: Add destructor.
9502         <ops>: Remove.
9503
9504 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9505             Pedro Alves  <palves@redhat.com>
9506
9507         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9508         'PATH_MAX'.
9509
9510 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9511             Samuel Thibault  <samuel.thibault@gnu.org>
9512             Thomas Schwinge  <thomas@codesourcery.com>
9513
9514         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9515         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9516
9517 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9518
9519         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9520         (check_empty): Use "const char *".
9521
9522         * gnu-nat.c (gnu_nat_target::detach): Instead of
9523         'detach_inferior (pid)' call
9524         'detach_inferior (find_inferior_pid (pid))'.
9525
9526         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9527         'nat/fork-inferior.o'.
9528         * gnu-nat.c: #include "nat/fork-inferior.h".
9529
9530         * gnu-nat.c (gnu_nat_target::detach): Instead of
9531         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9532         * gnu-nat.h: #include "inf-child.h".
9533         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9534         'i386_gnu_nat_target::fetch_registers'.
9535         (gnu_store_registers): Rename/move to
9536         'i386_gnu_nat_target::store_registers'.
9537
9538         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9539         * gnu-nat.h (mach_thread_info): New function.
9540         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9541
9542         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9543
9544 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9545
9546         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9547
9548 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9549
9550         * windows-nat.c (windows_add_thread): Add new parameter
9551         "main_thread_p" with default value set to false.  Update
9552         function documentation as well as all callers.
9553         (windows_delete_thread): Likewise.
9554         (fake_create_process): Update call to windows_add_thread.
9555         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9556         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9557         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9558         call to windows_delete_thread.
9559
9560 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9561
9562         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9563
9564 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9565
9566         * symfile.c (find_separate_debug_file): Use canonical path of
9567         sysroot with child_path instead of gdb_sysroot if it is valid.
9568
9569 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9570
9571         * symfile.c (find_separate_debug_file): Use child_path to
9572         determine if an object file is under a sysroot.
9573
9574 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9575
9576         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9577         unittests/child-path-selftests.c.
9578         * common/pathstuff.c (child_path): New function.
9579         * common/pathstuff.h (child_path): New prototype.
9580         * unittests/child-path-selftests.c: New file.
9581
9582 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9583
9584         * symfile.c (find_separate_debug_file): Look for separate debug
9585         files in debug directories under the sysroot.
9586
9587 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9588
9589         * symtab.h (struct minimal_symbol data_p): New const method.
9590         (struct minimal_symbol text_p): Likewise.
9591         * symtab.c (output_source_filename): Use file name style
9592         to print file name.
9593         (print_symbol_info): Likewise.
9594         (print_msymbol_info): Use address style to print addresses.
9595         Use function name style to print executable text symbols.
9596         (expand_symtab_containing_pc): Use data_p.
9597         (find_pc_sect_compunit_symtab): Likewise.
9598
9599 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9600
9601         * breakpoint.c (describe_other_breakpoints): Use address style
9602         to print addresses.
9603         (say_where): Likewise.
9604
9605 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9606
9607         * ada-typeprint.c (print_func_type): Print function name
9608         style to print function name.
9609         * c-typeprint.c (c_print_type_1): Likewise.
9610
9611 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9612
9613         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9614         for execve.
9615
9616 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9617
9618         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9619         type_stack.
9620
9621 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9622
9623         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9624         TYPE_CODE_REF types.
9625
9626 2019-02-08  Jim Wilson  <jimw@sifive.com>
9627
9628         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9629         (riscv_linux_fregset): New.
9630         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9631
9632 2019-02-07  Tom Tromey  <tom@tromey.com>
9633
9634         * thread.c (thread_cancel_execution_command): Update.
9635         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9636         methods.
9637         (struct thread_fsm_ops): Remove.
9638         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9639         (thread_fsm_should_stop, thread_fsm_return_value)
9640         (thread_fsm_set_finished, thread_fsm_finished_p)
9641         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9642         Don't declare.
9643         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9644         * infrun.c (clear_proceed_status_thread)
9645         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9646         (print_stop_event): Update.
9647         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9648         Add constructor.
9649         (step_command_fsm_ops): Remove.
9650         (new_step_command_fsm): Remove.
9651         (step_1): Update.
9652         (step_command_fsm::should_stop): Rename from
9653         step_command_fsm_should_stop.
9654         (step_command_fsm::clean_up): Rename from
9655         step_command_fsm_clean_up.
9656         (step_command_fsm::do_async_reply_reason): Rename from
9657         step_command_fsm_async_reply_reason.
9658         (struct until_next_fsm): Inherit from thread_fsm.  Add
9659         constructor.
9660         (until_next_fsm_ops): Remove.
9661         (new_until_next_fsm): Remove.
9662         (until_next_fsm::should_stop): Rename from
9663         until_next_fsm_should_stop.
9664         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9665         (until_next_fsm::do_async_reply_reason): Rename from
9666         until_next_fsm_async_reply_reason.
9667         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9668         constructor.  Change type of breakpoint.
9669         (finish_command_fsm_ops): Remove.
9670         (new_finish_command_fsm): Remove.
9671         (finish_command_fsm::should_stop): Rename from
9672         finish_command_fsm_should_stop.
9673         (finish_command_fsm::clean_up): Rename from
9674         finish_command_fsm_clean_up.
9675         (finish_command_fsm::return_value): Rename from
9676         finish_command_fsm_return_value.
9677         (finish_command_fsm::do_async_reply_reason): Rename from
9678         finish_command_fsm_async_reply_reason.
9679         (finish_command): Update.
9680         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9681         Add constructor.
9682         (call_thread_fsm_ops): Remove.
9683         (call_thread_fsm::call_thread_fsm): Rename from
9684         new_call_thread_fsm.
9685         (call_thread_fsm::should_stop): Rename from
9686         call_thread_fsm_should_stop.
9687         (call_thread_fsm::should_notify_stop): Rename from
9688         call_thread_fsm_should_notify_stop.
9689         (run_inferior_call, call_function_by_hand_dummy): Update.
9690         * cli/cli-interp.c (should_print_stop_to_console): Update.
9691         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9692         Add constructor.  Change type of location_breakpoint,
9693         caller_breakpoint.
9694         (until_break_fsm_ops): Remove.
9695         (new_until_break_fsm): Remove.
9696         (until_break_fsm::should_stop): Rename from
9697         until_break_fsm_should_stop.
9698         (until_break_fsm::clean_up): Rename from
9699         until_break_fsm_clean_up.
9700         (until_break_fsm::do_async_reply_reason): Rename from
9701         until_break_fsm_async_reply_reason.
9702         (until_break_command): Update.
9703         * thread-fsm.c: Remove.
9704         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9705
9706 2019-02-07  Tom Tromey  <tom@tromey.com>
9707
9708         * yy-remap.h: Add include guard.
9709         * xtensa-tdep.h: Add include guard.
9710         * xcoffread.h: Rename include guard.
9711         * varobj-iter.h: Add include guard.
9712         * tui/tui.h: Rename include guard.
9713         * tui/tui-winsource.h: Rename include guard.
9714         * tui/tui-wingeneral.h: Rename include guard.
9715         * tui/tui-windata.h: Rename include guard.
9716         * tui/tui-win.h: Rename include guard.
9717         * tui/tui-stack.h: Rename include guard.
9718         * tui/tui-source.h: Rename include guard.
9719         * tui/tui-regs.h: Rename include guard.
9720         * tui/tui-out.h: Rename include guard.
9721         * tui/tui-layout.h: Rename include guard.
9722         * tui/tui-io.h: Rename include guard.
9723         * tui/tui-hooks.h: Rename include guard.
9724         * tui/tui-file.h: Rename include guard.
9725         * tui/tui-disasm.h: Rename include guard.
9726         * tui/tui-data.h: Rename include guard.
9727         * tui/tui-command.h: Rename include guard.
9728         * tic6x-tdep.h: Add include guard.
9729         * target/waitstatus.h: Rename include guard.
9730         * target/wait.h: Rename include guard.
9731         * target/target.h: Rename include guard.
9732         * target/resume.h: Rename include guard.
9733         * target-float.h: Rename include guard.
9734         * stabsread.h: Add include guard.
9735         * rs6000-tdep.h: Add include guard.
9736         * riscv-fbsd-tdep.h: Add include guard.
9737         * regformats/regdef.h: Rename include guard.
9738         * record.h: Rename include guard.
9739         * python/python.h: Rename include guard.
9740         * python/python-internal.h: Rename include guard.
9741         * python/py-stopevent.h: Rename include guard.
9742         * python/py-ref.h: Rename include guard.
9743         * python/py-record.h: Rename include guard.
9744         * python/py-record-full.h: Rename include guard.
9745         * python/py-record-btrace.h: Rename include guard.
9746         * python/py-instruction.h: Rename include guard.
9747         * python/py-events.h: Rename include guard.
9748         * python/py-event.h: Rename include guard.
9749         * procfs.h: Add include guard.
9750         * proc-utils.h: Add include guard.
9751         * p-lang.h: Add include guard.
9752         * or1k-tdep.h: Rename include guard.
9753         * observable.h: Rename include guard.
9754         * nto-tdep.h: Rename include guard.
9755         * nat/x86-linux.h: Rename include guard.
9756         * nat/x86-linux-dregs.h: Rename include guard.
9757         * nat/x86-gcc-cpuid.h: Add include guard.
9758         * nat/x86-dregs.h: Rename include guard.
9759         * nat/x86-cpuid.h: Rename include guard.
9760         * nat/ppc-linux.h: Rename include guard.
9761         * nat/mips-linux-watch.h: Rename include guard.
9762         * nat/linux-waitpid.h: Rename include guard.
9763         * nat/linux-ptrace.h: Rename include guard.
9764         * nat/linux-procfs.h: Rename include guard.
9765         * nat/linux-osdata.h: Rename include guard.
9766         * nat/linux-nat.h: Rename include guard.
9767         * nat/linux-namespaces.h: Rename include guard.
9768         * nat/linux-btrace.h: Rename include guard.
9769         * nat/glibc_thread_db.h: Rename include guard.
9770         * nat/gdb_thread_db.h: Rename include guard.
9771         * nat/gdb_ptrace.h: Rename include guard.
9772         * nat/fork-inferior.h: Rename include guard.
9773         * nat/amd64-linux-siginfo.h: Rename include guard.
9774         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9775         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9776         * nat/aarch64-linux.h: Rename include guard.
9777         * nat/aarch64-linux-hw-point.h: Rename include guard.
9778         * mn10300-tdep.h: Add include guard.
9779         * mips-linux-tdep.h: Add include guard.
9780         * mi/mi-parse.h: Rename include guard.
9781         * mi/mi-out.h: Rename include guard.
9782         * mi/mi-main.h: Rename include guard.
9783         * mi/mi-interp.h: Rename include guard.
9784         * mi/mi-getopt.h: Rename include guard.
9785         * mi/mi-console.h: Rename include guard.
9786         * mi/mi-common.h: Rename include guard.
9787         * mi/mi-cmds.h: Rename include guard.
9788         * mi/mi-cmd-break.h: Rename include guard.
9789         * m2-lang.h: Add include guard.
9790         * location.h: Rename include guard.
9791         * linux-record.h: Rename include guard.
9792         * linux-nat.h: Add include guard.
9793         * linux-fork.h: Add include guard.
9794         * i386-darwin-tdep.h: Rename include guard.
9795         * hppa-linux-offsets.h: Add include guard.
9796         * guile/guile.h: Rename include guard.
9797         * guile/guile-internal.h: Rename include guard.
9798         * gnu-nat.h: Rename include guard.
9799         * gdb-stabs.h: Rename include guard.
9800         * frv-tdep.h: Add include guard.
9801         * f-lang.h: Add include guard.
9802         * event-loop.h: Add include guard.
9803         * darwin-nat.h: Rename include guard.
9804         * cp-abi.h: Rename include guard.
9805         * config/sparc/nm-sol2.h: Rename include guard.
9806         * config/nm-nto.h: Rename include guard.
9807         * config/nm-linux.h: Add include guard.
9808         * config/i386/nm-i386gnu.h: Rename include guard.
9809         * config/djgpp/nl_types.h: Rename include guard.
9810         * config/djgpp/langinfo.h: Rename include guard.
9811         * compile/gcc-cp-plugin.h: Add include guard.
9812         * compile/gcc-c-plugin.h: Add include guard.
9813         * compile/compile.h: Rename include guard.
9814         * compile/compile-object-run.h: Rename include guard.
9815         * compile/compile-object-load.h: Rename include guard.
9816         * compile/compile-internal.h: Rename include guard.
9817         * compile/compile-cplus.h: Rename include guard.
9818         * compile/compile-c.h: Rename include guard.
9819         * common/xml-utils.h: Rename include guard.
9820         * common/x86-xstate.h: Rename include guard.
9821         * common/version.h: Rename include guard.
9822         * common/vec.h: Rename include guard.
9823         * common/tdesc.h: Rename include guard.
9824         * common/selftest.h: Rename include guard.
9825         * common/scoped_restore.h: Rename include guard.
9826         * common/scoped_mmap.h: Rename include guard.
9827         * common/scoped_fd.h: Rename include guard.
9828         * common/safe-iterator.h: Rename include guard.
9829         * common/run-time-clock.h: Rename include guard.
9830         * common/refcounted-object.h: Rename include guard.
9831         * common/queue.h: Rename include guard.
9832         * common/ptid.h: Rename include guard.
9833         * common/print-utils.h: Rename include guard.
9834         * common/preprocessor.h: Rename include guard.
9835         * common/pathstuff.h: Rename include guard.
9836         * common/observable.h: Rename include guard.
9837         * common/netstuff.h: Rename include guard.
9838         * common/job-control.h: Rename include guard.
9839         * common/host-defs.h: Rename include guard.
9840         * common/gdb_wait.h: Rename include guard.
9841         * common/gdb_vecs.h: Rename include guard.
9842         * common/gdb_unlinker.h: Rename include guard.
9843         * common/gdb_unique_ptr.h: Rename include guard.
9844         * common/gdb_tilde_expand.h: Rename include guard.
9845         * common/gdb_sys_time.h: Rename include guard.
9846         * common/gdb_string_view.h: Rename include guard.
9847         * common/gdb_splay_tree.h: Rename include guard.
9848         * common/gdb_setjmp.h: Rename include guard.
9849         * common/gdb_ref_ptr.h: Rename include guard.
9850         * common/gdb_optional.h: Rename include guard.
9851         * common/gdb_locale.h: Rename include guard.
9852         * common/gdb_assert.h: Rename include guard.
9853         * common/filtered-iterator.h: Rename include guard.
9854         * common/filestuff.h: Rename include guard.
9855         * common/fileio.h: Rename include guard.
9856         * common/environ.h: Rename include guard.
9857         * common/common-utils.h: Rename include guard.
9858         * common/common-types.h: Rename include guard.
9859         * common/common-regcache.h: Rename include guard.
9860         * common/common-inferior.h: Rename include guard.
9861         * common/common-gdbthread.h: Rename include guard.
9862         * common/common-exceptions.h: Rename include guard.
9863         * common/common-defs.h: Rename include guard.
9864         * common/common-debug.h: Rename include guard.
9865         * common/cleanups.h: Rename include guard.
9866         * common/buffer.h: Rename include guard.
9867         * common/btrace-common.h: Rename include guard.
9868         * common/break-common.h: Rename include guard.
9869         * cli/cli-utils.h: Rename include guard.
9870         * cli/cli-style.h: Rename include guard.
9871         * cli/cli-setshow.h: Rename include guard.
9872         * cli/cli-script.h: Rename include guard.
9873         * cli/cli-interp.h: Rename include guard.
9874         * cli/cli-decode.h: Rename include guard.
9875         * cli/cli-cmds.h: Rename include guard.
9876         * charset-list.h: Add include guard.
9877         * buildsym-legacy.h: Rename include guard.
9878         * bfin-tdep.h: Add include guard.
9879         * ax.h: Rename include guard.
9880         * arm-linux-tdep.h: Add include guard.
9881         * arm-fbsd-tdep.h: Add include guard.
9882         * arch/xtensa.h: Rename include guard.
9883         * arch/tic6x.h: Add include guard.
9884         * arch/i386.h: Add include guard.
9885         * arch/arm.h: Rename include guard.
9886         * arch/arm-linux.h: Rename include guard.
9887         * arch/arm-get-next-pcs.h: Rename include guard.
9888         * arch/amd64.h: Add include guard.
9889         * arch/aarch64-insn.h: Rename include guard.
9890         * arch-utils.h: Rename include guard.
9891         * annotate.h: Add include guard.
9892         * amd64-darwin-tdep.h: Rename include guard.
9893         * aarch64-linux-tdep.h: Add include guard.
9894         * aarch64-fbsd-tdep.h: Add include guard.
9895         * aarch32-linux-nat.h: Add include guard.
9896
9897 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9898
9899         * macrotab.c (macro_define_internal): New function that
9900         factorizes macro_define_object_internal and macro_define_function
9901         code.
9902         (macro_define_object_internal): Use macro_define_internal.
9903         (macro_define_function): Likewise.
9904
9905 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9906
9907         * macrocmd.c (extract_identifier): Return
9908         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9909         callers.
9910
9911 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9912
9913         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9914
9915 2019-02-05  Tom Tromey  <tom@tromey.com>
9916
9917         * target.c (target_stack::unpush): Move assertion earlier.
9918
9919 2019-01-30  Tom Tromey  <tom@tromey.com>
9920
9921         PR python/23615:
9922         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9923         (gdbpy_parse_and_eval): Likewise.
9924         * python/python-internal.h (gdbpy_allow_threads): New class.
9925
9926 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9927
9928         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9929         (aarch64_fbsd_fpregmap): Move earlier.
9930         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9931         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9932         instead of individual calls to trad_frame_set_reg_addr.
9933         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9934         earlier.
9935         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9936         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9937         instead of individual calls to trad_frame_set_reg_addr.
9938
9939 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9940
9941         * CONTRIBUTE: Replace contribution list with wiki link.
9942
9943 2019-01-25  Tom Tromey  <tom@tromey.com>
9944
9945         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9946
9947 2019-01-25  Tom Tromey  <tom@tromey.com>
9948
9949         * xtensa-linux-nat.c: Fix common/ includes.
9950         * xml-support.h: Fix common/ includes.
9951         * xml-support.c: Fix common/ includes.
9952         * x86-linux-nat.c: Fix common/ includes.
9953         * windows-nat.c: Fix common/ includes.
9954         * varobj.h: Fix common/ includes.
9955         * varobj.c: Fix common/ includes.
9956         * value.c: Fix common/ includes.
9957         * valops.c: Fix common/ includes.
9958         * utils.c: Fix common/ includes.
9959         * unittests/xml-utils-selftests.c: Fix common/ includes.
9960         * unittests/utils-selftests.c: Fix common/ includes.
9961         * unittests/unpack-selftests.c: Fix common/ includes.
9962         * unittests/tracepoint-selftests.c: Fix common/ includes.
9963         * unittests/style-selftests.c: Fix common/ includes.
9964         * unittests/string_view-selftests.c: Fix common/ includes.
9965         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9966         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9967         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9968         * unittests/rsp-low-selftests.c: Fix common/ includes.
9969         * unittests/parse-connection-spec-selftests.c: Fix common/
9970         includes.
9971         * unittests/optional-selftests.c: Fix common/ includes.
9972         * unittests/offset-type-selftests.c: Fix common/ includes.
9973         * unittests/observable-selftests.c: Fix common/ includes.
9974         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9975         * unittests/memrange-selftests.c: Fix common/ includes.
9976         * unittests/memory-map-selftests.c: Fix common/ includes.
9977         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9978         * unittests/function-view-selftests.c: Fix common/ includes.
9979         * unittests/environ-selftests.c: Fix common/ includes.
9980         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9981         * unittests/common-utils-selftests.c: Fix common/ includes.
9982         * unittests/cli-utils-selftests.c: Fix common/ includes.
9983         * unittests/array-view-selftests.c: Fix common/ includes.
9984         * ui-file.c: Fix common/ includes.
9985         * tui/tui-io.c: Fix common/ includes.
9986         * tracepoint.h: Fix common/ includes.
9987         * tracepoint.c: Fix common/ includes.
9988         * tracefile-tfile.c: Fix common/ includes.
9989         * top.h: Fix common/ includes.
9990         * top.c: Fix common/ includes.
9991         * thread.c: Fix common/ includes.
9992         * target/waitstatus.h: Fix common/ includes.
9993         * target/waitstatus.c: Fix common/ includes.
9994         * target.h: Fix common/ includes.
9995         * target.c: Fix common/ includes.
9996         * target-memory.c: Fix common/ includes.
9997         * target-descriptions.c: Fix common/ includes.
9998         * symtab.h: Fix common/ includes.
9999         * symfile.c: Fix common/ includes.
10000         * stap-probe.c: Fix common/ includes.
10001         * spu-linux-nat.c: Fix common/ includes.
10002         * sparc-nat.c: Fix common/ includes.
10003         * source.c: Fix common/ includes.
10004         * solib.c: Fix common/ includes.
10005         * solib-target.c: Fix common/ includes.
10006         * ser-unix.c: Fix common/ includes.
10007         * ser-tcp.c: Fix common/ includes.
10008         * ser-pipe.c: Fix common/ includes.
10009         * ser-base.c: Fix common/ includes.
10010         * selftest-arch.c: Fix common/ includes.
10011         * s12z-tdep.c: Fix common/ includes.
10012         * rust-exp.y: Fix common/ includes.
10013         * rs6000-aix-tdep.c: Fix common/ includes.
10014         * riscv-tdep.c: Fix common/ includes.
10015         * remote.c: Fix common/ includes.
10016         * remote-notif.h: Fix common/ includes.
10017         * remote-fileio.h: Fix common/ includes.
10018         * remote-fileio.c: Fix common/ includes.
10019         * regcache.h: Fix common/ includes.
10020         * regcache.c: Fix common/ includes.
10021         * record-btrace.c: Fix common/ includes.
10022         * python/python.c: Fix common/ includes.
10023         * python/py-type.c: Fix common/ includes.
10024         * python/py-inferior.c: Fix common/ includes.
10025         * progspace.h: Fix common/ includes.
10026         * producer.c: Fix common/ includes.
10027         * procfs.c: Fix common/ includes.
10028         * proc-api.c: Fix common/ includes.
10029         * printcmd.c: Fix common/ includes.
10030         * ppc-linux-nat.c: Fix common/ includes.
10031         * parser-defs.h: Fix common/ includes.
10032         * osdata.c: Fix common/ includes.
10033         * obsd-nat.c: Fix common/ includes.
10034         * nat/x86-linux.c: Fix common/ includes.
10035         * nat/x86-linux-dregs.c: Fix common/ includes.
10036         * nat/x86-dregs.h: Fix common/ includes.
10037         * nat/x86-dregs.c: Fix common/ includes.
10038         * nat/ppc-linux.c: Fix common/ includes.
10039         * nat/mips-linux-watch.h: Fix common/ includes.
10040         * nat/mips-linux-watch.c: Fix common/ includes.
10041         * nat/linux-waitpid.c: Fix common/ includes.
10042         * nat/linux-ptrace.h: Fix common/ includes.
10043         * nat/linux-ptrace.c: Fix common/ includes.
10044         * nat/linux-procfs.c: Fix common/ includes.
10045         * nat/linux-personality.c: Fix common/ includes.
10046         * nat/linux-osdata.c: Fix common/ includes.
10047         * nat/linux-namespaces.c: Fix common/ includes.
10048         * nat/linux-btrace.h: Fix common/ includes.
10049         * nat/linux-btrace.c: Fix common/ includes.
10050         * nat/fork-inferior.c: Fix common/ includes.
10051         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10052         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10053         * nat/aarch64-linux.c: Fix common/ includes.
10054         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10055         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10056         * namespace.h: Fix common/ includes.
10057         * mips-linux-tdep.c: Fix common/ includes.
10058         * minsyms.c: Fix common/ includes.
10059         * mi/mi-parse.h: Fix common/ includes.
10060         * mi/mi-main.c: Fix common/ includes.
10061         * mi/mi-cmd-env.c: Fix common/ includes.
10062         * memrange.h: Fix common/ includes.
10063         * memattr.c: Fix common/ includes.
10064         * maint.h: Fix common/ includes.
10065         * maint.c: Fix common/ includes.
10066         * main.c: Fix common/ includes.
10067         * machoread.c: Fix common/ includes.
10068         * location.c: Fix common/ includes.
10069         * linux-thread-db.c: Fix common/ includes.
10070         * linux-nat.c: Fix common/ includes.
10071         * linux-fork.c: Fix common/ includes.
10072         * inline-frame.c: Fix common/ includes.
10073         * infrun.c: Fix common/ includes.
10074         * inflow.c: Fix common/ includes.
10075         * inferior.h: Fix common/ includes.
10076         * inferior.c: Fix common/ includes.
10077         * infcmd.c: Fix common/ includes.
10078         * inf-ptrace.c: Fix common/ includes.
10079         * inf-child.c: Fix common/ includes.
10080         * ia64-linux-nat.c: Fix common/ includes.
10081         * i387-tdep.c: Fix common/ includes.
10082         * i386-tdep.c: Fix common/ includes.
10083         * i386-linux-tdep.c: Fix common/ includes.
10084         * i386-linux-nat.c: Fix common/ includes.
10085         * i386-go32-tdep.c: Fix common/ includes.
10086         * i386-fbsd-tdep.c: Fix common/ includes.
10087         * i386-fbsd-nat.c: Fix common/ includes.
10088         * guile/scm-type.c: Fix common/ includes.
10089         * guile/guile.c: Fix common/ includes.
10090         * go32-nat.c: Fix common/ includes.
10091         * gnu-nat.c: Fix common/ includes.
10092         * gdbthread.h: Fix common/ includes.
10093         * gdbarch-selftests.c: Fix common/ includes.
10094         * gdb_usleep.c: Fix common/ includes.
10095         * gdb_select.h: Fix common/ includes.
10096         * gdb_bfd.c: Fix common/ includes.
10097         * gcore.c: Fix common/ includes.
10098         * fork-child.c: Fix common/ includes.
10099         * findvar.c: Fix common/ includes.
10100         * fbsd-nat.c: Fix common/ includes.
10101         * event-top.c: Fix common/ includes.
10102         * event-loop.c: Fix common/ includes.
10103         * dwarf2read.c: Fix common/ includes.
10104         * dwarf2loc.c: Fix common/ includes.
10105         * dwarf2-frame.c: Fix common/ includes.
10106         * dwarf-index-cache.c: Fix common/ includes.
10107         * dtrace-probe.c: Fix common/ includes.
10108         * disasm-selftests.c: Fix common/ includes.
10109         * defs.h: Fix common/ includes.
10110         * csky-tdep.c: Fix common/ includes.
10111         * cp-valprint.c: Fix common/ includes.
10112         * cp-support.h: Fix common/ includes.
10113         * cp-support.c: Fix common/ includes.
10114         * corelow.c: Fix common/ includes.
10115         * completer.h: Fix common/ includes.
10116         * completer.c: Fix common/ includes.
10117         * compile/compile.c: Fix common/ includes.
10118         * compile/compile-loc2c.c: Fix common/ includes.
10119         * compile/compile-cplus-types.c: Fix common/ includes.
10120         * compile/compile-cplus-symbols.c: Fix common/ includes.
10121         * command.h: Fix common/ includes.
10122         * cli/cli-dump.c: Fix common/ includes.
10123         * cli/cli-cmds.c: Fix common/ includes.
10124         * charset.c: Fix common/ includes.
10125         * build-id.c: Fix common/ includes.
10126         * btrace.h: Fix common/ includes.
10127         * btrace.c: Fix common/ includes.
10128         * breakpoint.h: Fix common/ includes.
10129         * breakpoint.c: Fix common/ includes.
10130         * ax.h:
10131         (enum agent_op): Fix common/ includes.
10132         * ax-general.c (struct aop_map): Fix common/ includes.
10133         * ax-gdb.c: Fix common/ includes.
10134         * auxv.c: Fix common/ includes.
10135         * auto-load.c: Fix common/ includes.
10136         * arm-tdep.c: Fix common/ includes.
10137         * arch/riscv.c: Fix common/ includes.
10138         * arch/ppc-linux-common.c: Fix common/ includes.
10139         * arch/i386.c: Fix common/ includes.
10140         * arch/arm.c: Fix common/ includes.
10141         * arch/arm-linux.c: Fix common/ includes.
10142         * arch/arm-get-next-pcs.c: Fix common/ includes.
10143         * arch/amd64.c: Fix common/ includes.
10144         * arch/aarch64.c: Fix common/ includes.
10145         * arch/aarch64-insn.c: Fix common/ includes.
10146         * arch-utils.c: Fix common/ includes.
10147         * amd64-windows-tdep.c: Fix common/ includes.
10148         * amd64-tdep.c: Fix common/ includes.
10149         * amd64-sol2-tdep.c: Fix common/ includes.
10150         * amd64-obsd-tdep.c: Fix common/ includes.
10151         * amd64-nbsd-tdep.c: Fix common/ includes.
10152         * amd64-linux-tdep.c: Fix common/ includes.
10153         * amd64-linux-nat.c: Fix common/ includes.
10154         * amd64-fbsd-tdep.c: Fix common/ includes.
10155         * amd64-fbsd-nat.c: Fix common/ includes.
10156         * amd64-dicos-tdep.c: Fix common/ includes.
10157         * amd64-darwin-tdep.c: Fix common/ includes.
10158         * agent.c: Fix common/ includes.
10159         * ada-lang.h: Fix common/ includes.
10160         * ada-lang.c: Fix common/ includes.
10161         * aarch64-tdep.c: Fix common/ includes.
10162
10163 2019-01-25  Tom Tromey  <tom@tromey.com>
10164
10165         * common/create-version.sh: Use common/version.h.
10166
10167 2019-01-24  Pedro Alves  <palves@redhat.com>
10168
10169         * infrun.c (signal_stop, signal_print, signal_program)
10170         (signal_catch, signal_pass): Now arrays instead of pointers.
10171         (update_signals_program_target, do_target_resume)
10172         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10173         * linux-nat.c (linux_nat_target::pass_signals)
10174         (linux_nat_target::create_inferior, linux_nat_target::attach):
10175         Adjust.
10176         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10177         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10178         * procfs.c (procfs_target::pass_signals): Adjust.
10179         * record-full.c (record_full_target::resume): Adjust.
10180         * remote.c (remote_target::pass_signals)
10181         (remote_target::program_signals): Adjust.
10182         * target-debug.h (target_debug_print_signals): Now takes a
10183         gdb::array_view as parameter.  Adjust.
10184         * target.h (target_ops) <pass_signals, program_signals>: Replace
10185         pointer and length parameters with gdb::array_view.
10186         (target_pass_signals, target_program_signals): Likewise.
10187         * target-delegates.c: Regenerate.
10188
10189 2019-01-24  Pedro Alves  <palves@redhat.com>
10190
10191         * common/forward-scope-exit.h
10192         (forward_scope_exit::forward_scope_exit): Pass arguments to
10193         m_bind_function directly, instead of creating a std::bind and
10194         copying that.
10195
10196 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10197
10198         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10199         for static members.
10200         (pass_in_v_vfp_candidate): Likewise.
10201
10202 2019-01-23  Tom Tromey  <tom@tromey.com>
10203             Pedro Alves  <palves@redhat.com>
10204
10205         * regcache.c (class regcache_invalidator): Remove.
10206         (regcache::raw_write): Use make_scope_exit.
10207
10208 2019-01-23  Tom Tromey  <tom@tromey.com>
10209
10210         * ui-out.h (class ui_out_emit_type): Update comment.
10211
10212 2019-01-23  Tom Tromey  <tom@tromey.com>
10213
10214         * infrun.c (fetch_inferior_event): Update comment.
10215
10216 2019-01-23  Tom Tromey  <tom@tromey.com>
10217             Pedro Alves  <palves@redhat.com>
10218
10219         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10220         parameter.
10221         (fetch_inferior_event): Use SCOPE_EXIT.
10222
10223
10224 2019-01-23  Tom Tromey  <tom@tromey.com>
10225             Pedro Alves  <palves@redhat.com>
10226
10227         * infrun.c (disable_thread_events): Delete.
10228         (stop_all_threads): Use SCOPE_EXIT.
10229
10230 2019-01-23  Tom Tromey  <tom@tromey.com>
10231             Pedro Alves  <palves@redhat.com>
10232
10233         * symfile.c: Include forward-scope-exit.h.
10234         (clear_symtab_users_cleanup): Replace forward declaration with
10235         a FORWARD_SCOPE_EXIT.
10236         (syms_from_objfile_1): Use the forward_scope_exit and
10237         gdb::optional instead of cleanup_function.
10238         (reread_symbols): Use the forward_scope_exit instead of
10239         cleanup_function.
10240         (clear_symtab_users_cleanup): Remove function.
10241
10242 2019-01-23  Tom Tromey  <tom@tromey.com>
10243             Pedro Alves  <palves@redhat.com>
10244
10245         * linux-nat.c: Include scope-exit.h.
10246         (cleanup_target_stop): Remove.
10247         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10248         SCOPE_EXIT.
10249
10250 2019-01-23  Tom Tromey  <tom@tromey.com>
10251             Pedro Alves  <palves@redhat.com>
10252
10253         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10254         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10255
10256 2019-01-23  Tom Tromey  <tom@tromey.com>
10257             Andrew Burgess  <andrew.burgess@embecosm.com>
10258             Pedro Alves  <palves@redhat.com>
10259
10260         * infrun.c (fetch_inferior_event): Use scope_exit.
10261         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10262         * top.c (execute_command): Use scope_exit.
10263         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10264         * utils.c (do_bpstat_clear_actions_cleanup)
10265         (make_bpstat_clear_actions_cleanup): Remove.
10266
10267 2019-01-23  Tom Tromey  <tom@tromey.com>
10268             Pedro Alves  <palves@redhat.com>
10269
10270         * infrun.c: Include "common/scope-exit.h"
10271         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10272         (wait_for_inferior): Use SCOPE_EXIT.
10273         (fetch_inferior_event): Use scope_exit.
10274
10275 2019-01-23  Tom Tromey  <tom@tromey.com>
10276             Pedro Alves  <palves@redhat.com>
10277
10278         * breakpoint.c (create_breakpoint): Remove cleanup.
10279
10280 2019-01-23  Tom Tromey  <tom@tromey.com>
10281             Andrew Burgess  <andrew.burgess@embecosm.com>
10282             Pedro Alves  <palves@redhat.com>
10283
10284 2019-01-23  Pedro Alves  <palves@redhat.com>
10285
10286         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10287
10288 2019-01-23  Pedro Alves  <palves@redhat.com>
10289             Andrew Burgess  <andrew.burgess@embecosm.com>
10290
10291         * gdbthread.h: Include "common/forward-scope-exit.h".
10292         (scoped_finish_thread_state): Redefine custom class in terms of
10293         forward_scope_exit.
10294
10295 2019-01-23  Pedro Alves  <palves@redhat.com>
10296             Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * common/forward-scope-exit.h: New file.
10299
10300 2019-01-23  Pedro Alves  <palves@redhat.com>
10301             Andrew Burgess  <andrew.burgess@embecosm.com>
10302             Tom Tromey  <tom@tromey.com>
10303
10304         * common/scope-exit.h: New file.
10305
10306 2019-01-23  Pedro Alves  <palves@redhat.com>
10307
10308         * common/preprocessor.h (ESC): Rename to ...
10309         (ESC_PARENS): ... this.
10310         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10311         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10312
10313 2019-01-23  Tom Tromey  <tom@tromey.com>
10314
10315         * language.h (class scoped_switch_to_sym_language_if_auto):
10316         Initialize m_lang in both cases.
10317
10318 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10319
10320         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10321         with XCNEW.
10322
10323 2019-01-22  Tom Tromey  <tom@tromey.com>
10324
10325         * corelow.c: Do not include sys/file.h.
10326
10327 2019-01-22  Tom Tromey  <tom@tromey.com>
10328
10329         * tui/tui-wingeneral.h: Include gdb_curses.h.
10330
10331 2019-01-22  Tom Tromey  <tom@tromey.com>
10332
10333         * source-cache.h (class source_cache) <get_source_lines,
10334         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10335
10336 2019-01-22  Tom Tromey  <tom@tromey.com>
10337
10338         * remote-fileio.h (struct remote_target): Declare.
10339
10340 2019-01-22  Tom Tromey  <tom@tromey.com>
10341
10342         * python/py-arch.c: Do not include py-ref.h.
10343         * python/py-bpevent.c: Do not include py-ref.h.
10344         * python/py-cmd.c: Do not include py-ref.h.
10345         * python/py-continueevent.c: Do not include py-ref.h.
10346         * python/py-event.h: Do not include py-ref.h.
10347         * python/py-evtregistry.c: Do not include py-ref.h.
10348         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10349         * python/py-frame.c: Do not include py-ref.h.
10350         * python/py-framefilter.c: Do not include py-ref.h.
10351         * python/py-function.c: Do not include py-ref.h.
10352         * python/py-infevents.c: Do not include py-ref.h.
10353         * python/py-linetable.c: Do not include py-ref.h.
10354         * python/py-objfile.c: Do not include py-ref.h.
10355         * python/py-param.c: Do not include py-ref.h.
10356         * python/py-prettyprint.c: Do not include py-ref.h.
10357         * python/py-progspace.c: Do not include py-ref.h.
10358         * python/py-symbol.c: Do not include py-ref.h.
10359         * python/py-symtab.c: Do not include py-ref.h.
10360         * python/py-type.c: Do not include py-ref.h.
10361         * python/py-unwind.c: Do not include py-ref.h.
10362         * python/py-utils.c: Do not include py-ref.h.
10363         * python/py-value.c: Do not include py-ref.h.
10364         * python/py-varobj.c: Do not include py-ref.h.
10365         * python/py-xmethods.c: Do not include py-ref.h.
10366         * python/python.c: Do not include py-ref.h.
10367         * varobj.c: Do not include py-ref.h.
10368
10369 2019-01-22  Tom Tromey  <tom@tromey.com>
10370
10371         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10372         keyword for bcache.
10373
10374 2019-01-22  Tom Tromey  <tom@tromey.com>
10375
10376         * compile/compile-cplus-types.c: Remove a comment by #include.
10377
10378 2019-01-22  Tom Tromey  <tom@tromey.com>
10379
10380         * compile/gcc-c-plugin.h: Include compile-internal.h.
10381
10382 2019-01-22  Tom Tromey  <tom@tromey.com>
10383
10384         * stabsread.c (EXTERN): Do not define.
10385         (symnum, next_symbol_text_func, processing_gcc_compilation)
10386         (within_function, global_sym_chain, global_stabs)
10387         (previous_stab_code, this_object_header_files)
10388         (n_this_object_header_files)
10389         (n_allocated_this_object_header_files): Define.
10390         * stabsread.h (EXTERN): Never define.  Use "extern".
10391
10392 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10393
10394         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10395         history_value.
10396
10397 2019-01-21  Tom Tromey  <tom@tromey.com>
10398
10399         * ui-out.c: Fix includes.
10400         * tui/tui-source.c: Fix includes.
10401         * target.c: Fix includes.
10402         * remote.c: Fix includes.
10403         * regcache.c: Fix includes.
10404         * python/py-block.c: Fix includes.
10405         * printcmd.c: Fix includes.
10406         * or1k-tdep.c: Fix includes.
10407         * mi/mi-main.c: Fix includes.
10408         * m32r-tdep.c: Fix includes.
10409         * csky-tdep.c: Fix includes.
10410         * compile/compile-cplus-types.c: Fix includes.
10411         * cli/cli-interp.c: Fix includes.
10412
10413 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10414
10415         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10416         for padding.
10417
10418 2019-01-16  Tom Tromey  <tom@tromey.com>
10419
10420         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10421         earlier.
10422         (struct objfile) <msymbols_range>: Move from top level.
10423         <msymbols>: New method.
10424         (class objfile_msymbols): Remove.
10425         * symtab.c (default_collect_symbol_completion_matches_break_on):
10426         Update.
10427         * symmisc.c (dump_msymbols): Update.
10428         * stabsread.c (scan_file_globals): Update.
10429         * objc-lang.c (info_selectors_command, info_classes_command)
10430         (find_methods): Update.
10431         * minsyms.c (find_solib_trampoline_target): Update.
10432         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10433         * coffread.c (coff_symfile_read): Update.
10434         * ada-lang.c (ada_lookup_simple_minsym)
10435         (ada_collect_symbol_completion_matches): Update.
10436
10437 2019-01-16  Tom Tromey  <tom@tromey.com>
10438
10439         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10440         type.  Remove no-argument constructor.
10441         <iterator::operator++>: Simplify.
10442         <begin>: Update.
10443         <end>: Use minimal_symbol_count.
10444
10445 2019-01-16  Tom Tromey  <tom@tromey.com>
10446
10447         * objfiles.h (struct objfile) <psymtabs>: New method.
10448         (class objfile_psymtabs): Remove.
10449         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10450         typedef.
10451         <range>: New method.
10452         (require_partial_symbols): Change return type.
10453         * psymtab.c (require_partial_symbols)
10454         (psym_expand_symtabs_matching): Update.
10455         * mdebugread.c (parse_partial_symbols): Update.
10456         * dbxread.c (dbx_end_psymtab): Update.
10457
10458 2019-01-15  Tom Tromey  <tom@tromey.com>
10459
10460         * symtab.c (lookup_objfile_from_block)
10461         (lookup_symbol_in_objfile_symtabs)
10462         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10463         (find_line_symtab, info_sources_command)
10464         (default_collect_symbol_completion_matches_break_on)
10465         (make_source_files_completion_list): Update.
10466         * symmisc.c (print_objfile_statistics, dump_objfile)
10467         (maintenance_print_symbols, maintenance_info_symtabs)
10468         (maintenance_check_symtabs, maintenance_info_line_tables):
10469         Update.
10470         * source.c (select_source_symtab)
10471         (forget_cached_source_info_for_objfile): Update.
10472         * objfiles.h (class objfile_compunits): Remove.
10473         (struct objfile) <compunits_range>: New typedef.
10474         (compunits): New method.
10475         * objfiles.c (objfile_relocate1): Update.
10476         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10477         * maint.c (count_symtabs_and_blocks): Update.
10478         * linespec.c (iterate_over_all_matching_symtabs): Update.
10479         * cp-support.c (add_symbol_overload_list_qualified): Update.
10480         * coffread.c (coff_symtab_read): Update.
10481         * ada-lang.c (add_nonlocal_symbols)
10482         (ada_collect_symbol_completion_matches)
10483         (ada_add_global_exceptions): Update.
10484
10485 2019-01-15  Tom Tromey  <tom@tromey.com>
10486
10487         * progspace.h (program_space) <objfiles_safe_range>: New
10488         typedef.
10489         <objfiles_safe>: New method.
10490         * objfiles.h (class all_objfiles_safe): Remove.
10491         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10492         * jit.c (jit_inferior_exit_hook): Update.
10493
10494 2019-01-17  Tom Tromey  <tom@tromey.com>
10495
10496         * progspace.h (program_space) <objfiles_range>: New typedef.
10497         <objfiles>: New method.
10498         <objfiles_head>: Rename from objfiles.
10499         (object_files): Update.
10500         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10501         * guile/scm-pretty-print.c
10502         (ppscm_find_pretty_printer_from_objfiles): Update.
10503         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10504         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10505         Update.
10506         * python/py-progspace.c (pspy_get_objfiles): Update.
10507         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10508         Update.
10509         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10510         (objfpy_lookup_objfile_by_build_id): Update.
10511         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10512         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10513         Update.
10514         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10515         (expand_symtab_containing_pc, lookup_objfile_from_block)
10516         (lookup_static_symbol, basic_lookup_transparent_type)
10517         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10518         (find_line_symtab, info_sources_command)
10519         (default_collect_symbol_completion_matches_break_on)
10520         (make_source_files_completion_list, find_main_name): Update.
10521         * symmisc.c (print_symbol_bcache_statistics)
10522         (print_objfile_statistics, maintenance_print_symbols)
10523         (maintenance_print_msymbols, maintenance_print_objfiles)
10524         (maintenance_info_symtabs, maintenance_check_symtabs)
10525         (maintenance_expand_symtabs, maintenance_info_line_tables):
10526         Update.
10527         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10528         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10529         (map_overlay_command, unmap_overlay_command)
10530         (simple_overlay_update, expand_symtabs_matching)
10531         (map_symbol_filenames): Update.
10532         * symfile-debug.c (set_debug_symfile): Update.
10533         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10534         Update.
10535         * source.c (select_source_symtab, forget_cached_source_info):
10536         Update.
10537         * solib.c (solib_read_symbols): Update.
10538         * solib-spu.c (append_ocl_sos): Update.
10539         * psymtab.c (maintenance_print_psymbols)
10540         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10541         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10542         * printcmd.c (info_symbol_command): Update.
10543         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10544         Update.
10545         * objfiles.h (class all_objfiles): Remove.
10546         * objfiles.c (have_partial_symbols, have_full_symbols)
10547         (have_minimal_symbols, qsort_cmp, update_section_map)
10548         (shared_objfile_contains_address_p)
10549         (default_iterate_over_objfiles_in_search_order): Update.
10550         * objc-lang.c (info_selectors_command, info_classes_command)
10551         (find_methods): Update.
10552         * minsyms.c (find_solib_trampoline_target): Update.
10553         * maint.c (maintenance_info_sections)
10554         (maintenance_translate_address, count_symtabs_and_blocks):
10555         Update.
10556         * main.c (captured_main_1): Update.
10557         * linux-thread-db.c (try_thread_db_load_from_pdir)
10558         (has_libpthread): Update.
10559         * linespec.c (iterate_over_all_matching_symtabs)
10560         (search_minsyms_for_name): Update.
10561         * jit.c (jit_find_objf_with_entry_addr): Update.
10562         * hppa-tdep.c (find_unwind_entry)
10563         (hppa_lookup_stub_minimal_symbol): Update.
10564         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10565         Update.
10566         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10567         (elf_gnu_ifunc_resolve_by_got): Update.
10568         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10569         * dwarf-index-write.c (save_gdb_index_command): Update.
10570         * cp-support.c (add_symbol_overload_list_qualified): Update.
10571         * breakpoint.c (create_overlay_event_breakpoint)
10572         (create_longjmp_master_breakpoint)
10573         (create_std_terminate_master_breakpoint)
10574         (create_exception_master_breakpoint): Update.
10575         * blockframe.c (find_pc_partial_function): Update.
10576         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10577         (ada_collect_symbol_completion_matches)
10578         (ada_add_global_exceptions): Update.
10579
10580 2019-01-17  Tom Tromey  <tom@tromey.com>
10581
10582         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10583         declare VEC.
10584         (solib_target_parse_libraries): Change return type.
10585         (library_list_start_segment, library_list_start_section)
10586         (library_list_end_library, library_list_start_library); Update.
10587         (solib_target_free_library_list): Remove.
10588         (solib_target_parse_libraries): Remove cleanup.  Change return
10589         type.
10590         (solib_target_current_sos): Update.
10591
10592 2019-01-17  Tom Tromey  <tromey@bapiya>
10593
10594         * valprint.c: Replace "the the" with "the".
10595         * symtab.c: Replace "the the" with "the".
10596         * solib.c: Replace "the the" with "the".
10597         * solib-dsbt.c: Replace "the the" with "the".
10598         * linespec.c: Replace "the the" with "the".
10599         * dwarf2loc.h: Replace "the the" with "the".
10600         * amd64-windows-tdep.c: Replace "the the" with "the".
10601         * aarch64-tdep.c: Replace "the the" with "the".
10602
10603 2019-01-16  Keith Seitz  <keiths@redhat.com>
10604
10605         PR gdb/23773
10606         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10607         <builder>: Rename to ..
10608         <m_builder>: ... this and make private.
10609         (dwarf2_cu::get_builder): New method.  Change all users of
10610         `builder' to use this method.
10611         (dwarf2_start_symtab): Move to ...
10612         (dwarf2_cu::start_symtab): ... here.  Update all callers
10613         (setup_type_unit_groups): Move to ...
10614         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10615         callers.
10616         (dwarf2_cu::reset_builder): New method.
10617         (process_full_compunit, process_full_type_unit): Use
10618         dwarf2_cu::reset_builder.
10619         (follow_die_offset): Record the ancestor CU if it is different
10620         from the followed DIE's CU.
10621         (follow_die_sig_1): Likewise.
10622
10623 2019-01-15  Tom Tromey  <tom@tromey.com>
10624
10625         * remote.c (class remote_state) <buf>: Now a char_vector.
10626         <buf_size>: Remove.
10627         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10628         parameter.
10629         (remote_target::getpkt_or_notif_sane_1)
10630         (remote_target::getpkt_sane)
10631         (remote_target::getpkt_or_notif_sane): Likewise.
10632         (class remote_target) <putpkt>: New overload.
10633         (remote_target::read_frame): Change type of "buf_p".  Remove
10634         sizeof_p parameter.
10635         (packet_ok): New overload.
10636         (packet_check_result): New overload.
10637         Update all uses.
10638
10639 2019-01-14  Tom Tromey  <tom@tromey.com>
10640
10641         * remote-notif.c (handle_notification, remote_notif_ack)
10642         (remote_notif_parse): Make "buf" const.
10643         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10644         const.
10645         (remote_notif_parse, remote_notif_ack, handle_notification):
10646         Likewise.
10647         * remote.c (remote_notif_stop_parse): Make "buf" const.
10648         (remote_target::remote_parse_stop_reply): Make "buf" const.
10649         (remote_notif_stop_ack): Make "buf" const.
10650
10651 2019-01-14  Tom Tromey  <tom@tromey.com>
10652
10653         * remote.c (remote_console_output): Make parameter const.
10654
10655 2019-01-14  Tom Tromey  <tom@tromey.com>
10656
10657         * target-debug.h (target_debug_print_signals): Constify.
10658         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10659         * procfs.c (procfs_target::pass_signals): Update.
10660         * linux-nat.c (linux_nat_target::pass_signals): Update.
10661         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10662         * target-delegates.c: Rebuild.
10663         * remote.c (remote_target::program_signals): Update.
10664         (remote_target::pass_signals): Update.
10665         * target.c (target_pass_signals): Constify argument.
10666         (target_program_signals): Likewise.
10667         * target.h (struct target_ops) <pass_signals, program_signals>:
10668         Constify argument.
10669         (target_pass_signals, target_program_signals): Constify argument.
10670
10671 2019-01-14  Tom Tromey  <tom@tromey.com>
10672
10673         PR tui/28819:
10674         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10675
10676 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10677
10678         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10679         field.
10680         * rs6000-tdep.c: Include reggroups.h.
10681         (IS_V_ALIAS_PSEUDOREG): Define.
10682         (rs6000_register_name): Return names for the "vX" aliases.
10683         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10684         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10685         aliases.  Call default_register_reggroup_p for all other
10686         pseudo-registers.
10687         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10688         New functions.
10689         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10690         Handle "vX" aliases.
10691         (v_alias_pseudo_register_collect): New function.
10692         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10693         (rs6000_gdbarch_init): Initialize "vX" aliases as
10694         pseudo-registers.  Restore registration of
10695         rs6000_pseudo_register_reggroup_p with
10696         set_tdesc_pseudo_register_reggroup_p.
10697
10698 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10699
10700         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10701         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10702         set_gdbarch_num_pseudo_regs.
10703
10704 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10705
10706         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10707         Remove arg prefixname, add do_set and do_show.
10708         Add member functions set_list and show_list.
10709         * cli/cli-style.c (class cli_style_option): Update accordingly.
10710         (style_set_list): Move to file scope.
10711         (style_show_list): Likewise.
10712         (set_style): Call help_list.
10713         (show_style): Call cmd_show_list.
10714         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10715         Update to use the new macro.
10716
10717 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10718
10719         * ada-lang.c (_initialize_ada_language): Expand the help text
10720         for the "catch exception" command.
10721
10722 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10723
10724         * symtab.c (matching_obj_sections): Initialize obj,
10725         declare it closer to its usage.
10726
10727 2019-01-10  Tom Tromey  <tom@tromey.com>
10728
10729         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10730         (basic_inf_threads_range): Remove.
10731         (inf_threads_range, inf_non_exited_threads_range)
10732         (safe_inf_threads_range): Use next_adapter.
10733
10734 2019-01-10  Keith Seitz  <keiths@redhat.com>
10735
10736         PR gdb/23712
10737         PR symtab/23010
10738         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10739         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10740
10741 2019-01-10  Keith Seitz  <keiths@redhat.com>
10742
10743         PR gdb/23712
10744         PR symtab/23010
10745         * dictionary.c (pending_to_vector): Remove.
10746         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10747         Remove _1 suffix, replacing functions of the same name.  Update
10748         all callers.
10749         (dict_create_hashed, dict_create_hashed_expandable)
10750         (dict_create_linear, dict_create_linear_expandable, dict_free)
10751         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10752         Make functions static.
10753
10754 2019-01-10  Keith Seitz  <keiths@redhat.com>
10755
10756         PR gdb/23712
10757         PR symtab/23010
10758         * dictionary.h (struct dictionary): Replace declaration with
10759         multidictionary.
10760         (dict_create_hashed, dict_create_hashed_expandable)
10761         (dict_create_linear, dict_create_linear_expandable)
10762         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10763         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10764         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10765         taking multidictionary argument.
10766         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10767         * block.h (struct block) <dict>: Change to multidictionary
10768         and rename `multidict'.
10769         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10770         symmisc.c: Update all dictionary references to multidictionary.
10771
10772 2019-01-10  Keith Seitz  <keiths@redhat.com>
10773
10774         PR gdb/23712
10775         PR symtab/23010
10776         * dictionary.c: Include unordered_map.
10777         (pending_to_vector): New function.
10778         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10779         Rewrite the non-"_1" functions to take vector instead
10780         of linked list.
10781         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10782         "new" _1 versions of the same name.
10783         (multidictionary): Define.
10784         (std::hash<enum language): New definition.
10785         (collate_pending_symbols_by_language, mdict_create_hashed)
10786         (mdict_create_hashed_expandable, mdict_create_linear)
10787         (mdict_create_linear_expandable, mdict_free)
10788         (find_language_dictionary, create_new_language_dictionary)
10789         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10790         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10791         (mdict_size, mdict_empty): New functions.
10792         * dictionary.h (mdict_iterator): Define.
10793
10794 2019-01-10  Pedro Alves  <palves@redhat.com>
10795
10796         * breakpoint.c (read_uploaded_action)
10797         (create_tracepoint_from_upload): Adjust to use
10798         gdb::unique_xmalloc_ptr.
10799         * ctf.c (ctf_write_uploaded_tp):
10800         (SET_ARRAY_FIELD): Use emplace_back.
10801         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10802         * tracefile-tfile.c (tfile_write_uploaded_tp):
10803         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10804         gdb::unique_xmalloc_ptr.
10805         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10806         at_string, cond_string, cmd_strings>: Replace char pointers
10807         with gdb::unique_xmalloc_ptr.
10808
10809 2019-01-10  Pedro Alves  <palves@redhat.com>
10810
10811         * solib-target.c (library_list_start_library): Don't xstrdup name.
10812
10813 2019-01-10  Pedro Alves  <palves@redhat.com>
10814
10815         * mdebugread.c (parse_partial_symbols): Use
10816         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10817
10818 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10819
10820         * linux-fork.c (scoped_switch_fork_info)
10821         <~scoped_switch_fork_info>: Fix incorrect variable name.
10822
10823 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10824
10825         * linux-fork.c (scoped_switch_fork_info)
10826         <scoped_switch_fork_info>: Make explicit.
10827         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10828
10829 2019-01-10  Tom Tromey  <tom@tromey.com>
10830
10831         * objfiles.h (objfile::reset_psymtabs): Update.
10832         * objfiles.c (objfile::objfile): Update.
10833         * psymtab.h (psymtab_storage::obstack): Update.
10834         (psymtab_storage::m_obstack): Use gdb::optional.
10835         (class psymtab_storage): Update comment.  Remove objfile
10836         parameter.
10837         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10838
10839 2019-01-10  Tom Tromey  <tom@tromey.com>
10840
10841         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10842         <free_psymtabs>: Now private.
10843         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10844         (allocate_psymtab): Use new method.
10845
10846 2019-01-10  Tom Tromey  <tom@tromey.com>
10847
10848         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10849         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10850         * mdebugread.c (parse_partial_symbols): Use
10851         allocate_dependencies.
10852         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10853         allocate_dependencies.
10854         (process_psymtab_comp_unit_reader)
10855         (build_type_psymtab_dependencies): Likewise.
10856         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10857
10858 2019-01-10  Tom Tromey  <tom@tromey.com>
10859
10860         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10861         PSYMBOL_SET_LANGUAGE.
10862         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10863
10864 2019-01-10  Tom Tromey  <tom@tromey.com>
10865
10866         * psymtab.h (psymtab_storage::obstack): New method.
10867         <m_obstack>: Rename from obstack; now private.
10868         * psymtab.c (psymtab_storage): Update.
10869         * dwarf2read.c (create_addrmap_from_index)
10870         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10871         Update.
10872
10873 2019-01-10  Tom Tromey  <tom@tromey.com>
10874
10875         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10876         * objfiles.h (objfile::reset_psymtabs): New method.
10877
10878 2019-01-10  Tom Tromey  <tom@tromey.com>
10879
10880         * symmisc.c (print_symbol_bcache_statistics): Update.
10881         (print_objfile_statistics): Update.
10882         * symfile.c (reread_symbols): Update.
10883         * psymtab.h (class psymtab_storage): New.
10884         * psymtab.c (psymtab_storage): New constructor.
10885         (~psymtab_storage): New destructor.
10886         (require_partial_symbols): Update.
10887         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10888         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10889         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10890         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10891         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10892         (start_psymtab_common, end_psymtab_common)
10893         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10894         (allocate_psymtab): Update.
10895         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10896         Update.
10897         (dump_psymtab_addrmap, maintenance_print_psymbols)
10898         (maintenance_check_psymtabs): Update.
10899         (class objfile_psymtabs): Move to objfiles.h.
10900         * psympriv.h (discard_psymtab): Now inline.
10901         (psymtab_discarder::psymtab_discarder): Update.
10902         (psymtab_discarder::~psymtab_discarder): Update.
10903         (ALL_OBJFILE_PSYMTABS): Rewrite.
10904         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10905         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10906         Remove fields.
10907         <partial_symtabs>: New field.
10908         (class objfile_psymtabs): Move from psymtab.h.  Update.
10909         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10910         psymbol_cache.
10911         (objfile::~objfile): Don't destroy psymbol_cache.
10912         * mdebugread.c (parse_partial_symbols): Update.
10913         * dwarf2read.c (create_addrmap_from_index)
10914         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10915         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10916         (add_partial_subprogram, dwarf2_ranges_read): Update.
10917         * dwarf-index-write.c (write_address_map)
10918         (write_one_signatured_type, recursively_write_psymbols)
10919         (class debug_names, class debug_names, write_psymtabs_to_index):
10920         Update.
10921
10922 2019-01-10  Tom Tromey  <tom@tromey.com>
10923
10924         * symtab.h (SYMBOL_SET_NAMES): Update.
10925         (symbol_set_names): Update.
10926         (MSYMBOL_SET_NAMES): Update.
10927         * symtab.c (symbol_set_names): Change argument to be an
10928         objfile_per_bfd_storage.
10929         * psymtab.c (add_psymbol_to_bcache): Update.
10930         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10931
10932 2019-01-10  Tom Tromey  <tom@tromey.com>
10933
10934         * symtab.c (create_demangled_names_hash): Change argument to be an
10935         objfile_per_bfd_storage.
10936         (symbol_set_names): Update.
10937
10938 2019-01-10  Tom Tromey  <tom@tromey.com>
10939
10940         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10941         init_psymbol_list.
10942         * psymtab.c (init_psymbol_list): Do nothing if already called.
10943         * psympriv.h (init_psymbol_list): Add comment.
10944         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10945         init_psymbol_list.
10946         * dbxread.c (dbx_symfile_read): Unconditionally call
10947         init_psymbol_list.
10948
10949 2019-01-10  Tom Tromey  <tom@tromey.com>
10950
10951         * xcoffread.c (scan_xcoff_symtab): Update.
10952         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10953         "where".
10954         * mdebugread.c (parse_partial_symbols)
10955         (handle_psymbol_enumerators): Update.
10956         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10957         * dbxread.c (read_dbx_symtab): Update.
10958         * psympriv.h (psymbol_placement): New enum.
10959         (add_psymbol_to_list): Update.
10960
10961 2019-01-10  Tom Tromey  <tom@tromey.com>
10962
10963         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10964         static_psymbols parameters.
10965         (scan_xcoff_symtab): Update.
10966         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10967         static_psymbols parameters.
10968         * psympriv.h (start_psymtab_common): Update.
10969         * mdebugread.c (parse_partial_symbols): Update.
10970         * dwarf2read.c (create_partial_symtab): Update.
10971         * dbxread.c (read_dbx_symtab): Update.
10972         (start_psymtab): Remove global_psymbols and static_psymbols
10973         parameters.
10974
10975 2019-01-10  Tom Tromey  <tom@tromey.com>
10976
10977         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10978         * psymtab.c (allocate_psymtab): Add comment.
10979         * psympriv.h (allocate_psymtab): Add comment.
10980         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10981         initializations.
10982         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10983
10984 2019-01-10  Tom Tromey  <tom@tromey.com>
10985
10986         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10987         Don't declare.
10988         * mipsread.c: Include mdebugread.h.
10989         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10990         Declare.
10991         * elfread.c: Include mdebugread.h.
10992
10993 2019-01-09  Tom Tromey  <tom@tromey.com>
10994
10995         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10996         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10997         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10998         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10999         (psym_lookup_symbol, psym_find_last_source_symtab)
11000         (psym_forget_cached_source_info, psym_print_stats)
11001         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11002         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11003         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11004         (psym_find_compunit_symtab_by_address)
11005         (maintenance_print_psymbols, maintenance_info_psymtabs)
11006         (maintenance_check_psymtabs): Use ranged for.
11007         * psymtab.h (class objfile_psymtabs): New.
11008         (require_partial_symbols): Return objfile_psymtabs.
11009         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11010
11011 2019-01-09  Tom Tromey  <tom@tromey.com>
11012
11013         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11014         (find_pc_mapped_section, list_overlays_command)
11015         (map_overlay_command, unmap_overlay_command)
11016         (simple_overlay_update): Use all_objfiles.
11017         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11018         * printcmd.c (info_symbol_command): Use all_objfiles.
11019         * objfiles.h (ALL_OBJSECTIONS): Remove.
11020         * maint.c (maintenance_translate_address): Use all_objfiles.
11021         * gcore.c (gcore_create_callback): Use all_objfiles.
11022         (objfile_find_memory_regions): Likewise.
11023
11024 2019-01-09  Tom Tromey  <tom@tromey.com>
11025
11026         * symtab.c (find_line_symtab, info_sources_command)
11027         (make_source_files_completion_list): Use objfile_compunits.
11028         * source.c (select_source_symtab): Use objfile_compunits.
11029         * objfiles.h (struct objfile): Update comment.
11030         (ALL_OBJFILES): Remove.
11031         (ALL_FILETABS): Remove.
11032         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11033         objfile_compunits.
11034
11035 2019-01-09  Tom Tromey  <tom@tromey.com>
11036
11037         * symmisc.c (print_objfile_statistics, dump_objfile)
11038         (maintenance_print_symbols): Use compunit_filetabs.
11039         * source.c (forget_cached_source_info_for_objfile): Use
11040         compunit_filetabs.
11041         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11042         (ALL_FILETABS): Use compunit_filetabs.
11043         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11044         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11045
11046 2019-01-09  Tom Tromey  <tom@tromey.com>
11047
11048         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11049         (compunit_filetabs): New.
11050         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11051         compunit_filetabs.
11052         (info_sources_command, make_source_files_completion_list): Remove
11053         declaration.
11054         * symmisc.c (print_objfile_statistics, dump_objfile)
11055         (maintenance_print_symbols): Remove declaration.
11056         (maintenance_info_symtabs): Use compunit_filetabs.
11057         (maintenance_info_line_tables): Likewise.
11058         * source.c (select_source_symtab): Change local variable name.
11059         (forget_cached_source_info_for_objfile): Remove declaration.
11060         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11061         * objfiles.c (objfile_relocate1): Remove declaration.
11062         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11063         declaration.
11064         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11065         * coffread.c (coff_symtab_read): Remove declaration.
11066         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11067         compunit_filetabs.
11068
11069 2019-01-09  Tom Tromey  <tom@tromey.com>
11070
11071         * symtab.c (lookup_objfile_from_block)
11072         (find_pc_sect_compunit_symtab, search_symbols)
11073         (default_collect_symbol_completion_matches_break_on): Use
11074         objfile_compunits.
11075         * objfiles.h (ALL_COMPUNITS): Remove.
11076         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11077         * cp-support.c (add_symbol_overload_list_qualified): Use
11078         objfile_compunits.
11079         * ada-lang.c (ada_collect_symbol_completion_matches)
11080         (ada_add_global_exceptions): Use objfile_compunits.
11081
11082 2019-01-09  Tom Tromey  <tom@tromey.com>
11083
11084         * source.c (select_source_symtab)
11085         (forget_cached_source_info_for_objfile): Remove declaration.
11086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11087         declaration.
11088         * maint.c (count_symtabs_and_blocks): Remove declaration.
11089         * cp-support.c (add_symbol_overload_list_qualified): Remove
11090         declaration.
11091         * coffread.c (coff_symtab_read): Remove declaration.
11092         * symtab.c (lookup_symbol_in_objfile_symtabs)
11093         (basic_lookup_transparent_type_1): Use objfile_compunits.
11094         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11095         (info_sources_command, search_symbols)
11096         (default_collect_symbol_completion_matches_break_on)
11097         (make_source_files_completion_list): Remove declaration.
11098         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11099         (ada_collect_symbol_completion_matches)
11100         (ada_add_global_exceptions): Remove declaration.
11101         * linespec.c (iterate_over_all_matching_symtabs): Use
11102         objfile_compunits.
11103         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11104         (class objfile_compunits): New.
11105         (ALL_COMPUNITS): Use objfile_compunits.
11106         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11107         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11108         objfile_compunits.
11109         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11110
11111 2019-01-09  Tom Tromey  <tom@tromey.com>
11112
11113         * symtab.c (search_symbols)
11114         (default_collect_symbol_completion_matches_break_on): Use
11115         objfile_msymbols.
11116         * ada-lang.c (ada_lookup_simple_minsym)
11117         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11118         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11119         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11120         objfile_msymbols.
11121         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11122         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11123         * objc-lang.c (find_methods): Use objfile_msymbols.
11124         (info_selectors_command, info_classes_command): Likewise.
11125         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11126         * objfiles.h (class objfile_msymbols): New.
11127         (ALL_OBJFILE_MSYMBOLS): Remove.
11128         (ALL_MSYMBOLS): Remove.
11129
11130 2019-01-09  Tom Tromey  <tom@tromey.com>
11131
11132         * common/next-iterator.h (next_adapter): Add Iterator template
11133         parameter.
11134         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11135         (class all_objfiles_safe): New.
11136         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11137         * objfiles.c (put_objfile_before): Update comment.
11138         (add_separate_debug_objfile): Likewise.
11139         (free_all_objfiles): Use all_objfiles_safe.
11140         (objfile_purge_solibs): Likewise.
11141
11142 2019-01-09  Tom Tromey  <tom@tromey.com>
11143
11144         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11145         (expand_symtab_containing_pc, lookup_static_symbol)
11146         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11147         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11148         all_objfiles.
11149         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11150         * breakpoint.c (create_overlay_event_breakpoint)
11151         (create_longjmp_master_breakpoint)
11152         (create_std_terminate_master_breakpoint)
11153         (create_exception_master_breakpoint): Use all_objfiles.
11154         * linux-thread-db.c (try_thread_db_load_from_pdir)
11155         (has_libpthread): Use all_objfiles.
11156         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11157         * linespec.c (iterate_over_all_matching_symtabs)
11158         (search_minsyms_for_name): Use all_objfiles.
11159         * maint.c (maintenance_info_sections): Use all_objfiles.
11160         * main.c (captured_main_1): Use all_objfiles.
11161         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11162         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11163         * guile/scm-pretty-print.c
11164         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11165         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11166         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11167         (maintenance_print_msymbols): Use all_objfiles.
11168         * source.c (select_source_symtab): Use all_objfiles.
11169         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11170         * symfile.c (remove_symbol_file_command)
11171         (expand_symtabs_matching, map_symbol_filenames): Use
11172         all_objfiles.
11173         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11174         all_objfiles.
11175         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11176         * objc-lang.c (find_methods): Use all_objfiles.
11177         * objfiles.c (have_partial_symbols, have_full_symbols)
11178         (have_minimal_symbols, qsort_cmp)
11179         (default_iterate_over_objfiles_in_search_order): Use
11180         all_objfiles.
11181         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11182         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11183         (maintenance_check_psymtabs): Use all_objfiles.
11184         (ALL_PSYMTABS): Remove.
11185         * compile/compile-object-run.c (do_module_cleanup): Use
11186         all_objfiles.
11187         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11188         * cp-support.c (add_symbol_overload_list_qualified): Use
11189         all_objfiles.
11190         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11191         Use all_objfiles.
11192         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11193         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11194         all_objfiles.
11195         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11196         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11197         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11198         Uses all_objfiles.
11199         * solib.c (solib_read_symbols): Use all_objfiles
11200
11201 2019-01-09  Tom Tromey  <tom@tromey.com>
11202
11203         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11204         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11205         all_objfiles.
11206         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11207         * symmisc.c (print_symbol_bcache_statistics)
11208         (print_objfile_statistics, maintenance_print_objfiles)
11209         (maintenance_info_symtabs, maintenance_check_symtabs)
11210         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11211         all_objfiles.
11212         * source.c (forget_cached_source_info): Use all_objfiles.
11213         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11214         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11215         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11216         * objfiles.c (update_section_map): Use all_objfiles.
11217         (shared_objfile_contains_address_p): Likewise.
11218         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11219         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11220
11221 2019-01-09  Tom Tromey  <tom@tromey.com>
11222
11223         * common/next-iterator.h: New file.
11224         * objfiles.h (class all_objfiles): New.
11225         (struct objfile_iterator): New.
11226
11227 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11228
11229         * NEWS: Move the description of the changed "frame", "select-frame",
11230          and "info frame" commands to the Changed commands section.
11231
11232 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11233
11234         * gdbtypes.c (check_stub_method_group): Remove handling of old
11235         mangling schemes.
11236         * linespec.c (find_methods): Likewise.
11237         * stabsread.c (read_member_functions): Likewise.
11238         * valops.c (search_struct_method): Likewise.
11239         (value_struct_elt_for_reference): Likewise.
11240         * NEWS: Mention this change.
11241
11242 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11243
11244         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11245         print_source_lines.
11246         * source.c (print_source_lines_base): Update line number check.
11247         (print_source_lines): New function.
11248         (source_lines_range::source_lines_range): New function.
11249         * source.h (class source_lines_range): New class.
11250         (print_source_lines): New declaration.
11251
11252 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11253
11254         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11255
11256 2019-01-08  Tom Tromey  <tom@tromey.com>
11257             Simon Marchi  <simon.marchi@ericsson.com>
11258
11259         PR gdb/24060
11260         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11261         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11262         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11263         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11264         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11265         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11266
11267 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11268
11269         * source.c (select_source_symtab): Move header comment to
11270         declaration in source.h.
11271         (forget_cached_source_info_for_objfile): Likewise.
11272         (forget_cached_source_info): Likewise.
11273         (identify_source_line): Likewise.
11274         * source.h (identify_source_line): Move declaration from symtab.h
11275         and add comment from source.c
11276         (print_source_lines): Likewise.
11277         (forget_cached_source_info_for_objfile): Likewise.
11278         (forget_cached_source_info): Likewise.
11279         (select_source_symtab): Likewise.
11280         (enum print_source_lines_flag): Move definition from symtab.h.
11281         * symtab.h (identify_source_line): Move declaration to source.h.
11282         (print_source_lines): Likewise.
11283         (forget_cached_source_info_for_objfile): Likewise.
11284         (forget_cached_source_info): Likewise.
11285         (select_source_symtab): Likewise.
11286         (enum print_source_lines_flag): Move definition to source.h.
11287         * tui/tui-hooks.c: Add 'source.h' include.
11288
11289 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11290
11291         * source.c (print_source_lines_base): Handle requests to print
11292         reverse line number sequences, and guard against empty lines
11293         string.
11294
11295 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11296
11297         * source.c (print_source_lines_base): Fix skip of '\r' if next
11298         character is '\n'.
11299
11300 2019-01-06  Tom Tromey  <tom@tromey.com>
11301
11302         * c-exp.y (struct c_parse_state) <macro_original_text,
11303         expansion_obstack>: New member.
11304         (macro_original_text, expansion_obstack): Remove globals.
11305         (scan_macro_expansion, scanning_macro_expansion)
11306         (finished_macro_expansion): Update.
11307         (scan_macro_cleanup): Remove.
11308         (yylex, c_parse): Update.
11309
11310 2019-01-06  Tom Tromey  <tom@tromey.com>
11311
11312         * c-exp.y (struct c_parse_state) <strings>: New member.
11313         (operator_stoken): Update.
11314
11315 2019-01-06  Tom Tromey  <tom@tromey.com>
11316
11317         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11318         (union type_stack_elt) <typelist_val>: Now a pointer to
11319         std::vector.
11320         (type_stack_cleanup): Don't declare.
11321         (push_typelist): Update.
11322         * parse.c (pop_typelist): Return a std::vector.
11323         (push_typelist): Take a std::vector.
11324         (follow_types): Update.  Do not free args.
11325         (type_stack_cleanup): Remove.
11326         * c-exp.y (struct c_parse_state): New.
11327         (cpstate): New global.
11328         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11329         (nonempty_typelist): Update.
11330         (func_mod): Create a new vector.
11331         (c_parse): Create a c_parse_state.
11332         (check_parameter_typelist): Do not delete params.
11333         (function_method): Update.  Do not delete type_list.
11334
11335 2019-01-06  Tom Tromey  <tom@tromey.com>
11336
11337         PR gdb/28155:
11338         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11339         check_typedef.
11340         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11341         (print_return_value): Likewise.
11342
11343 2019-01-05  Tom Tromey  <tom@tromey.com>
11344
11345         * contrib/cleanup_check.py: Remove.
11346         * contrib/gcc-with-excheck: Remove.
11347         * contrib/exsummary.py: Remove.
11348         * contrib/excheck.py: Remove.
11349
11350 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11351
11352         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11353         NULL. Initialize tpprev to NULL instead of assigning it
11354         to NULL on the next statement.
11355         * windows-nat.c (windows_delete_thread): Remove check for
11356         main_thread_id before printing thread exit notifications.
11357         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11358         Remove thread ID check against main_thread_id.
11359         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11360         windows_delete_thread.
11361         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11362
11363 2019-01-04  Tom Tromey  <tom@tromey.com>
11364
11365         * compile/compile.c (_initialize_compile): Use upper case for
11366         metasyntactic variables.
11367         * symmisc.c (_initialize_symmisc): Use upper case for
11368         metasyntactic variables.
11369         * psymtab.c (_initialize_psymtab): Use upper case for
11370         metasyntactic variables.
11371         * demangle.c (demangle_command): Use upper case for metasyntactic
11372         variables.
11373         (_initialize_demangler): Likewise.
11374         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11375         variables.
11376
11377 2019-01-03  Tom Tromey  <tom@tromey.com>
11378
11379         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11380
11381 2019-01-03  Tom Tromey  <tom@tromey.com>
11382
11383         * python/py-symtab.c (salpy_str): Update.
11384         (struct salpy_sal_object) <symtab>: Now a PyObject.
11385         (salpy_dealloc): Update.
11386         (del_objfile_sal): Use gdbpy_ref.
11387
11388 2019-01-03  Tom Tromey  <tom@tromey.com>
11389
11390         * python/py-type.c (convert_field): Use new_reference.  Return
11391         gdbpy_ref.
11392         (make_fielditem): Return gdbpy_ref.
11393         (typy_fields): Update.
11394         (typy_getitem): Update.
11395         (field_name): Return gdbpy_ref.  Use new_reference.
11396         (typy_iterator_iternext): Update.
11397
11398 2019-01-03  Tom Tromey  <tom@tromey.com>
11399
11400         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11401
11402 2019-01-03  Tom Tromey  <tom@tromey.com>
11403
11404         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11405         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11406         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11407         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11408         (pspy_set_type_printers): Likewise.
11409         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11410         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11411         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11412         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11413         (objfpy_set_type_printers): Likewise.
11414
11415 2019-01-03  Tom Tromey  <tom@tromey.com>
11416
11417         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11418         (gdbpy_print_stack): Use gdbpy_err_fetch.
11419         * python/python-internal.h (class gdbpy_err_fetch): New class.
11420         (class gdbpy_enter) <m_error_type, m_error_value,
11421         m_error_traceback>: Remove.
11422         <m_error>: New member.
11423         (gdbpy_exception_to_string): Don't declare.
11424         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11425         * python/py-value.c (convert_value_from_python): Use
11426         gdbpy_err_fetch.
11427         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11428         gdbpy_exception_to_string.
11429         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11430         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11431         gdbpy_err_fetch.
11432
11433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11434
11435         * linux-nat.c (delete_lwp_cleanup): Delete.
11436         (struct lwp_deleter): New struct.
11437         (lwp_info_up): New typedef.
11438         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11439         lwp_info_up.
11440
11441 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11442
11443         * linux-fork.c (class scoped_switch_fork_info): New class.
11444         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11445
11446 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11447
11448         * valops.c (find_overload_match): Remove use of null_cleanup, and
11449         calls to do_cleanups.
11450
11451 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11452
11453         * compile/compile-cplus-types.c
11454         (compile_cplus_instance::decl_name): Handle changes to
11455         cp_func_name.
11456         * cp-support.c (cp_func_name): Update header comment, update
11457         return type.
11458         * cp-support.h (cp_func_name): Update return type in declaration.
11459         * valops.c (find_overload_match): Move temp_func local to top
11460         level of function and change its type.  Use temp_func to hold and
11461         delete temporary string obtained from cp_func_name.
11462
11463 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11464
11465         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11466         gdb::char_vector, remove cleanup, and update uses of `msg`.
11467
11468 2019-01-03  Jim Wilson  <jimw@sifive.com>
11469
11470         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11471
11472 2019-01-02  Tom Tromey  <tom@tromey.com>
11473
11474         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11475         (tdesc_parse_xml): Remove cleanups.
11476         * target-descriptions.h (make_cleanup_free_target_description):
11477         Don't declare.
11478         (target_desc_deleter): New struct.
11479         (target_desc_up): New typedef.
11480         * target-descriptions.c (target_desc_deleter::operator()): Rename
11481         from free_target_description.
11482         (make_cleanup_free_target_description): Remove.
11483
11484 2019-01-02  Tom Tromey  <tom@tromey.com>
11485
11486         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11487         constructor, destructor.
11488         (linespec_parser): Remove typedef.
11489         (~linespec_parser): Rename from linespec_parser_delete.
11490         (linespec_lex_to_end, linespec_complete_label)
11491         (linespec_complete): Update.
11492         (decode_line_full): Remove cleanups.
11493         (decode_line_1): Update.
11494
11495 2019-01-02  Tom Tromey  <tom@tromey.com>
11496
11497         * python/python-internal.h (inferior_to_inferior_object): Change
11498         return type.
11499         * python/py-exitedevent.c (create_exited_event_object): Update.
11500         * python/py-inferior.c (inferior_to_inferior_object): Return
11501         gdbpy_ref.
11502         (python_new_inferior, python_inferior_deleted)
11503         (thread_to_thread_object, delete_thread_object)
11504         (build_inferior_list, gdbpy_selected_inferior): Update.
11505         * python/py-infthread.c (create_thread_object): Update.  Also fail
11506         if inferior_to_inferior_object fails.
11507
11508 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11509
11510         * inferior.h (class inferior) <displaced_step_state>: New field.
11511         * infrun.h (struct displaced_step_state): Move here from
11512         infrun.c.  Initialize fields, add constructor.
11513         <inf>: Remove field.
11514         <reset>: New method.
11515         * infrun.c (struct displaced_step_inferior_state): Move to
11516         infrun.h.
11517         (displaced_step_inferior_states): Remove.
11518         (get_displaced_stepping_state): Adust.
11519         (displaced_step_in_progress_any_inferior): Adjust.
11520         (displaced_step_in_progress_thread): Adjust.
11521         (displaced_step_in_progress): Adjust.
11522         (add_displaced_stepping_state): Remove.
11523         (get_displaced_step_closure_by_addr): Adjust.
11524         (remove_displaced_stepping_state): Remove.
11525         (infrun_inferior_exit): Call displaced_step_state.reset.
11526         (use_displaced_stepping): Don't check for NULL.
11527         (displaced_step_prepare_throw): Call
11528         get_displaced_stepping_state.
11529         (displaced_step_fixup): Don't check for NULL.
11530         (prepare_for_detach): Don't check for NULL.
11531
11532 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11533
11534         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11535          in case of call that did not complete.
11536
11537 2019-01-02  Andrey Utkin  <autkin@undo.io>
11538
11539         * symfile.c (find_separate_debug_file): Fix search of debug files for
11540         remote debuggee.
11541
11542 2019-01-02  Tom Tromey  <tom@tromey.com>
11543
11544         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11545         indentation.
11546         * python/py-frame.c (frapy_older): Remove cast.
11547         (frapy_newer): Likewise.
11548         * python/py-breakpoint.c (local_setattro): Remove cast.
11549         * python/py-arch.c (archpy_name): Remove local variable.
11550         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11551
11552 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11553
11554         * unittests/basic_string_view/element_access/char/empty.cc:
11555         Fix year range in copyright header.
11556
11557 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11558
11559         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11560         Delete.
11561         <operator==>: Update with for removed field.
11562         <hash>: Likewise.
11563         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11564         <isa_features>: ...this.
11565         <abi_features>: New field.
11566         (riscv_isa_flen): Update comment.
11567         (riscv_abi_xlen): New declaration.
11568         (riscv_abi_flen): New declaration.
11569         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11570         isa_features.
11571         (riscv_abi_xlen): New function.
11572         (riscv_isa_flen): Update to get answer from isa_features.
11573         (riscv_abi_flen): New function.
11574         (riscv_has_fp_abi): Update to get answer from abi_features.
11575         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11576         xlen and flen.
11577         (riscv_call_info) <xlen, flen>: Update comment.
11578         (riscv_call_arg_struct): Remove invalid assertions
11579         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11580         is removed.
11581         (riscv_gdbarch_init): Gather isa features and abi features
11582         separately, ensure both match on the gdbarch when reusing an old
11583         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11584         a target with 64-bit float hardware.
11585
11586 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11587
11588         * source.c (search_command_helper): Stop reverse search
11589         when line 1 has been searched.
11590
11591 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11592
11593         * record-full.c (record_full_base_target::close): Rewrite
11594         record_full_core_buf_list free logic.
11595
11596 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11597
11598         * break-catch-syscall.c (print_one_catch_syscall): xfree
11599         the last text.
11600
11601 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11602
11603         * top.c (print_gdb_version): Update Copyright year in version
11604         message.
11605
11606 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11607
11608         Update copyright year range in all GDB files.
11609
11610 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11611
11612         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11613
11614 For older changes see ChangeLog-2018.
11615 \f
11616 Local Variables:
11617 mode: change-log
11618 left-margin: 8
11619 fill-column: 74
11620 version-control: never
11621 coding: utf-8
11622 End:
11623