1 2019-12-26 Ruslan Kabatsayev <b7.10110111@gmail.com>
3 * dwarf2read.c (is_valid_DW_AT_defaulted)
4 (is_valid_DW_AT_calling_convention_for_type)
5 (is_valid_DW_AT_calling_convention_for_subroutine): Fix printing
6 ULONGEST variables on x86-32.
8 2019-12-21 George Barrett <bob@bob131.so>
10 * solib-svr4.c (svr4_handle_solib_event): Add fallback link
11 namespace test for when the debug struct isn't available.
13 2019-12-21 Eli Zaretskii <eliz@gnu.org>
15 * top.c (print_gdb_configuration): Print "--with-xxhash" or
16 "--without-xxhash" according to HAVE_LIBXXHASH.
18 2019-12-20 Weimin Pan <weimin.pan@oracle.com>
19 * ctfread.c (ctf_file_key): Change type to objfile_key.
20 (struct ctf_context): Remove typedef.
21 (get_objfile_text_range): Use ANOFFSET to get text base.
23 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
25 * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine):
27 (read_subroutine_type): Validate the parsed
28 DW_AT_calling_convention value before assigning it to a
29 subroutine's calling_convention attribute.
30 * gdbtypes.h (struct func_type) <calling_convention>: Use
31 an enum bitfield as its type, instead of plain unsigned.
33 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
36 * infcall.c (call_function_by_hand_dummy): Update the argument-
37 passing section for call-by-value parameters.
38 (struct destructor_info): New struct.
39 (call_destructors): New auxiliary function.
41 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
43 * gnu-v3-abi.c (enum definition_style): New enum type.
44 (get_def_style): New function.
45 (is_user_provided_def): New function.
46 (is_implicit_def): New function.
47 (is_copy_or_move_constructor_type): New function.
48 (is_copy_constructor_type): New function.
49 (is_move_constructor_type): New function.
50 (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
53 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
55 * language.h (struct language_pass_by_ref_info): New struct.
56 (struct language_defn)<la_pass_by_reference>: Change the signature
57 to return a language_pass_by_ref_info instead of an int.
58 (language_pass_by_reference): Ditto.
59 (default_pass_by_reference): Ditto.
60 Adjust the users listed below.
61 * arch-utils.c (default_return_in_first_hidden_param_p):
63 * cp-abi.c (cp_pass_by_reference): Update.
64 * cp-abi.h (cp_pass_by_reference): Update declaration.
65 (struct cp_abi_ops)<pass_by_reference>: Update.
66 * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
67 * infcall.c (call_function_by_hand_dummy): Update.
68 * language.c (language_pass_by_reference): Update.
69 (default_pass_by_reference): Update.
70 * tic6x-tdep.c (tic6x_return_value): Update.
72 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
74 * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
75 and DW_AT_deleted attributes of a function.
76 (read_structure_type): Read the DW_AT_calling_convention attribute
78 (is_valid_DW_AT_defaulted): New function.
79 (is_valid_DW_AT_calling_convention_for_type): New function.
80 * gdbtypes.h: Include dwarf2.h.
81 (struct fn_field)<defaulted>: New field to store the
82 DW_AT_defaulted attribute.
83 (struct fn_field)<is_deleted>: New field to store the
84 DW_AT_deleted attribute.
85 (struct cplus_struct_type)<calling_convention>: New field to store
86 the DW_AT_calling_convention attribute.
87 (TYPE_FN_FIELD_DEFAULTED): New macro.
88 (TYPE_FN_FIELD_DELETED): New macro.
89 (TYPE_CPLUS_CALLING_CONVENTION): New macro.
90 * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
92 (print_cplus_stuff): Likewise.
94 2019-12-20 Tom Tromey <tom@tromey.com>
96 * tui/tui.c (tui_show_source): Remove.
97 * tui/tui.h (tui_show_source): Don't declare.
98 * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
101 2019-12-20 Tom Tromey <tom@tromey.com>
103 * tui/tui-stack.h (tui_show_frame_info): Return bool.
104 * tui/tui-stack.c (tui_show_frame_info): Return bool.
105 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
108 2019-12-20 Tom Tromey <tom@tromey.com>
111 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
112 Rename parameters. Handle the not-from-stack-frame case.
113 (from_stack, from_source_symtab): New globals.
114 (tui_before_prompt, tui_normal_stop): Update.
115 (tui_context_changed, tui_symtab_changed): New functions.
116 (tui_attach_detach_observers): Attach new observers.
118 2019-12-20 Tom Tromey <tom@tromey.com>
120 * source.c (struct current_source_location) <set, symtab, line>:
122 <m_symtab, m_line>: Rename. Now private.
123 (get_current_source_symtab_and_line)
124 (set_default_source_symtab_and_line)
125 (set_current_source_symtab_and_line)
126 (clear_current_source_symtab_and_line, select_source_symtab)
127 (info_source_command, print_source_lines_base)
128 (info_line_command, search_command_helper): Update.
129 * observable.h (current_source_symtab_and_line_changed): Declare
131 * observable.c (current_source_symtab_and_line_changed): Define
134 2019-12-20 Tom Tromey <tom@tromey.com>
136 * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
137 (tui_before_prompt, tui_normal_stop): Update.
139 2019-12-20 Tom Tromey <tom@tromey.com>
141 * tui/tui-winsource.c
142 (tui_source_window_base::update_source_window_as_is): Don't call
143 set_current_source_symtab_and_line.
145 2019-12-20 Tom Tromey <tom@tromey.com>
147 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
148 Take a symtab_and_line.
149 * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
151 (tui_show_frame_info): Update.
153 2019-12-20 Tom Tromey <tom@tromey.com>
155 * tui/tui-stack.c (tui_show_frame_info): Don't call
158 2019-12-20 Tom Tromey <tom@tromey.com>
160 * tui/tui.c (tui_enable): Call tui_display_main.
162 2019-12-20 Tom Tromey <tom@tromey.com>
164 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
165 get_current_source_symtab_and_line, and main_name.
167 2019-12-20 Tom Tromey <tom@tromey.com>
169 * tui/tui.c (tui_show_source): Update.
170 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
171 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
172 a symtab_symbol_info, not a separate symtab and line. Simplify.
174 2019-12-20 Tom Tromey <tom@tromey.com>
176 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
179 2019-12-20 Tom Tromey <tom@tromey.com>
181 * tui/tui-winsource.h (struct tui_source_window_base)
182 <set_contents, update_source_window_as_is, update_source_window>:
183 Take a sal, not a separate symtab and tui_line_or_address.
184 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
185 (tui_source_window_base::update_source_window_as_is): Take a sal,
186 not a separate symtab and tui_line_or_address.
187 (tui_update_source_windows_with_addr)
188 (tui_update_source_windows_with_line)
189 (tui_source_window_base::rerender)
190 (tui_source_window_base::refill): Update.
191 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
192 a sal, not a separate symtab and tui_line_or_address.
193 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
194 not a separate symtab and tui_line_or_address.
195 (tui_source_window::maybe_update): Update.
196 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
197 a sal, not a separate symtab and tui_line_or_address.
198 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
199 not a separate symtab and tui_line_or_address.
200 (tui_disasm_window::do_scroll_vertical)
201 (tui_disasm_window::maybe_update): Update.
203 2019-12-20 Tom Tromey <tom@tromey.com>
205 * tui/tui-winsource.c (tui_source_window_base::refill): Use
207 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
209 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
212 2019-12-20 Tom Tromey <tom@tromey.com>
214 * tui/tui-winsource.h (struct tui_source_window_base)
215 <set_contents>: Return bool.
216 * tui/tui-winsource.c
217 (tui_source_window_base::update_source_window_as_is): Update.
218 * tui/tui-source.h (struct tui_source_window) <set_contents>:
220 * tui/tui-source.c (tui_source_window::set_contents): Return
222 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
224 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
227 2019-12-20 Tom Tromey <tom@tromey.com>
229 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
230 (tui_update_source_windows_with_line): Call update_source_window.
231 * tui/tui-source.h (struct tui_source_window)
232 <show_symtab_source>: Don't declare.
233 * tui/tui-source.c (tui_source_window::show_symtab_source):
236 2019-12-20 Tom Tromey <tom@tromey.com>
238 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
239 update_source_window directly.
240 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
241 * tui/tui-disasm.c (tui_show_disassem): Remove.
243 2019-12-20 Tom Tromey <tom@tromey.com>
245 * tui/tui-winsource.c
246 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
247 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
249 2019-12-20 Tom Tromey <tom@tromey.com>
251 * tui/tui-winsource.h (struct tui_source_window_base)
252 <maybe_update>: Remove line_no and addr parameters.
253 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
254 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
256 * tui/tui-source.c (tui_source_window::maybe_update): Remove
257 line_no and addr parameters.
258 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
260 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
261 line_no and addr parameters.
263 2019-12-20 Tom Tromey <tom@tromey.com>
265 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
266 (tui_source_window_base::update_breakpoint_info): Remove asserts.
268 2019-12-20 Tom Tromey <tom@tromey.com>
270 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
272 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
274 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
276 2019-12-20 Tom Tromey <tom@tromey.com>
278 * tui/tui.h (tui_show_source): Remove parameters.
279 * tui/tui.c (tui_show_source): Remove parameters.
280 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
282 2019-12-20 Tom Tromey <tom@tromey.com>
284 * tui/tui.c (tui_show_source): Update.
285 * tui/tui-winsource.c (tui_display_main): Update.
286 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
288 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
290 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
292 2019-12-20 Tom Tromey <tom@tromey.com>
295 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
296 (tui_redisplay_readline): Use rl_display_prompt.
297 (tui_prep_terminal): Update.
299 2019-12-19 Christian Biesinger <cbiesinger@google.com>
301 * configure: Regenerate.
302 * configure.ac: Quote variable arguments of test.
303 * gdbsupport/common.m4: Likewise.
305 2019-12-19 Christian Biesinger <cbiesinger@google.com>
307 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
310 2019-12-19 Christian Biesinger <cbiesinger@google.com>
312 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
313 log10 to double to fix Solaris 11 with gcc 5.5.
315 2019-12-19 Christian Biesinger <cbiesinger@google.com>
317 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
320 2019-12-19 Tom Tromey <tromey@adacore.com>
322 * ui-out.h (enum class field_kind): Fix comment.
324 2019-12-11 Tom Tromey <tromey@adacore.com>
326 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
328 2019-12-18 Tom Tromey <tromey@adacore.com>
331 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
332 type on macOS. Add comment.
334 2019-12-18 Simon Marchi <simon.marchi@efficios.com>
336 * c-lang.c (c_get_string, asm_language_defn): Remove space
339 2019-12-18 Tom Tromey <tromey@adacore.com>
342 * ui-out.c (ui_out::vmessage): Update.
343 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
345 (string_field): Update.
346 (signed_field): Update.
348 2019-12-18 Simon Marchi <simon.marchi@efficios.com>
350 * top.c (print_gdb_configuration): Adjust indentation.
352 2019-12-17 Christian Biesinger <cbiesinger@google.com>
354 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
356 2019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
358 * tui/tui-layout.h (class tui_layout_base): Add virtual
361 2019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
363 * infcmd.c (prepare_one_step): Step over skipped inline functions.
364 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
365 (process_event_stop_test): Keep stepping over skipped inline functions.
367 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
369 * jit.c (struct gdb_block) <next>: Remove field.
370 (struct gdb_symtab) <~gdb_symtab>: Remove.
371 <blocks>: Change type to std::forward_list<gdb_block>.
372 (compare_block): Remove.
373 (jit_block_open_impl): Adjust to std::forward_list. Place the new
374 block at the beginning, don't mind about sorting.
375 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
378 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
380 * jit.c (struct gdb_block): Add constructor, initialize
381 real_block and next fields.
382 <name>: Change type to gdb::unique_xmalloc_ptr.
383 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
384 (jit_block_open_impl): Allocate gdb_block with new.
385 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
387 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
389 * jit.c: Include forward_list.
390 (struct gdb_symtab) <next>: Remove field.
391 (struct gdb_object) <symtabs>: Change type to
392 std::forward_list<gdb_symtab>.
393 (jit_object_open_impl): Allocate gdb_object with new.
394 (jit_symtab_open_impl): Adjust to std::forward_list.
395 (finalize_symtab): Don't delete symtab.
396 (jit_object_close_impl): Adjust to std::forward_list. Free
397 gdb_object with delete.
399 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
401 * jit.c (struct gdb_symtab): Add constructor, destructor,
403 <linetable>: Change type to unique_xmalloc_ptr.
404 <file_name>: Change type to std::string.
405 (jit_symtab_open_impl): Allocate gdb_symtab with new.
406 (jit_symtab_line_mapping_add_impl): Adjust.
407 (finalize_symtab): Adjust, call delete on stab.
409 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
411 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
413 2019-12-16 Tom Tromey <tromey@adacore.com>
415 * windows-nat.c (windows_nat_target::attach): Update.
416 * remote.c (extended_remote_target::attach): Update.
417 * procfs.c (procfs_target::attach): Update.
418 * nto-procfs.c (nto_procfs_target::attach): Update.
419 (nto_procfs_target::create_inferior): Update.
420 * inf-ptrace.c (inf_ptrace_target::attach): Update.
421 * gnu-nat.c (gnu_nat_target::attach): Update.
422 (gnu_nat_target::detach): Update.
423 * darwin-nat.c (darwin_nat_target::attach): Update.
424 * corefile.c (get_exec_file): Constify result. Remove extraneous
426 * bsd-kvm.c (bsd_kvm_target_open): Update.
427 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
429 2019-12-16 Christian Biesinger <cbiesinger@google.com>
431 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
432 (we no longer need to include time.h before pathmax.h)
434 2019-12-15 Christian Biesinger <cbiesinger@google.com>
436 * ada-exp.y (write_ambiguous_var): Update.
437 * coffread.c (process_coff_symbol): Update.
438 * ctfread.c (ctf_add_enum_member_cb): Update.
439 (new_symbol): Update.
440 * dwarf2read.c (fixup_go_packaging): Update.
441 (new_symbol): Update.
442 * language.c (language_alloc_type_symbol): Update.
443 * mdebugread.c (new_symbol): Update.
444 * minsyms.c (minimal_symbol_reader::record_full): Update.
445 * psymtab.c (add_psymbol_to_bcache): Update.
446 * stabsread.c (define_symbol): Update.
447 (read_enum_type): Update.
448 * symtab.c (symbol_set_language): Make this a member function...
449 (general_symbol_info::set_language): ... here.
450 * symtab.h (struct general_symbol_info) <set_language>: New function.
451 (SYMBOL_SET_LANGUAGE): Remove.
452 (symbol_set_language): Remove.
454 2019-12-15 Christian Biesinger <cbiesinger@google.com>
456 * ada-lang.c (ada_add_block_symbols): Update.
457 (ada_collect_symbol_completion_matches): Update.
458 * ax-gdb.c (gen_expr): Update.
459 * block.c (block_lookup_symbol): Update.
460 (block_lookup_symbol_primary): Update.
461 (block_find_symbol): Update.
462 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
463 * dbxread.c (process_one_symbol): Update.
464 * dictionary.c (insert_symbol_hashed): Update.
465 (collate_pending_symbols_by_language): Update.
466 (mdict_add_symbol): Update.
467 * dwarf-index-write.c (write_psymbols): Update.
468 * dwarf2read.c (fixup_go_packaging): Update.
469 * findvar.c (read_var_value): Update.
470 * ft32-tdep.c (ft32_skip_prologue): Update.
471 * go-lang.c (go_symbol_package_name): Update.
472 * language.h (scoped_switch_to_sym_language_if_auto::
473 scoped_switch_to_sym_language_if_auto): Update.
474 * linespec.c (find_method): Update.
475 (find_label_symbols_in_block): Update.
476 * mdebugread.c (parse_symbol): Update.
477 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
478 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
479 (minimal_symbol_reader::install): Update.
480 * moxie-tdep.c (moxie_skip_prologue): Update.
481 * parse.c (parse_exp_in_context): Update.
482 * psymtab.c (psymbol_name_matches): Update.
483 (match_partial_symbol): Update.
484 (lookup_partial_symbol): Update.
485 (psymbol_hash): Update.
486 (psymbol_compare): Update.
487 * python/py-framefilter.c (extract_sym): Update.
488 (py_print_single_arg): Update.
489 * stabsread.c (define_symbol): Update.
490 * stack.c (print_frame_arg): Update.
491 (find_frame_funname): Update.
492 (info_frame_command_core): Update.
493 * symfile.c (set_initial_language): Update.
494 * symtab.c (symbol_set_demangled_name): Update.
495 (symbol_get_demangled_name): Update.
496 (symbol_set_language): Update.
497 (symbol_find_demangled_name): Update.
498 (symbol_set_names): Update.
499 (general_symbol_info::natural_name): Update.
500 (general_symbol_info::demangled_name): Update.
501 (general_symbol_info::search_name): Update.
502 (symbol_matches_search_name): Update.
503 (eq_symbol_entry): Update.
504 (iterate_over_symbols): Update.
505 (completion_list_add_symbol): Update.
506 (completion_list_add_msymbol): Update.
507 (completion_list_add_fields): Update.
508 * symtab.h (struct general_symbol_info) <language>: New function.
509 <language>: Rename to...
510 <m_language>: ...this.
511 (SYMBOL_LANGUAGE): Remove.
512 (MSYMBOL_LANGUAGE): Remove.
513 (struct symbol) <ctor>: Update.
514 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
516 2019-12-15 Christian Biesinger <cbiesinger@google.com>
518 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
519 set the language of sym.
520 * language.c (language_alloc_type_symbol): Likewise.
522 2019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
524 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
526 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
527 * corelow.c: Include 'gdbsupport/pathstuff.h'.
528 (core_target_open): Use 'gdb_abspath'.
529 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
530 'current_directory == NULL' case.
531 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
532 explain what happens when 'current_directory' is NULL.
533 * go32-nat.c (go32_nat_target::wait): Check if
534 'current_directory' is NULL before call to 'chdir'.
535 * source.c (add_path): Use 'gdb_abspath'.
536 * top.c: Include 'gdbsupport/pathstuff.h'.
537 (init_history): Use 'gdb_abspath'.
538 (set_history_filename): Likewise.
539 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
540 (tfile_target_open): Use 'gdb_abspath'.
542 2019-12-13 Tom Tromey <tromey@adacore.com>
544 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
547 2019-12-13 Tom Tromey <tromey@adacore.com>
549 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
551 2019-12-13 Tom Tromey <tromey@adacore.com>
553 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
555 2019-12-13 Tom Tromey <tromey@adacore.com>
557 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
559 2019-12-13 Tom Tromey <tromey@adacore.com>
561 * gdbsupport/common-utils.c (string_printf, string_vprintf)
562 (string_vappendf): Add ARI comment.
564 2019-12-13 Tom Tromey <tromey@adacore.com>
566 * contrib/ari/gdb_ari.sh: Remove "fix" call for
567 floatformat_to_double.
568 * target-float.c (host_float_ops<T>::from_target): Add ARI
571 2019-12-13 Tom Tromey <tromey@adacore.com>
573 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
574 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
576 * event-top.c (handle_sigsegv): Add ARI marker to abort.
578 2019-12-13 Tom Tromey <tromey@adacore.com>
580 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
582 2019-12-13 Tom Tromey <tromey@adacore.com>
584 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
586 2019-12-13 Tom Tromey <tromey@adacore.com>
588 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
591 2019-12-13 Tom Tromey <tromey@adacore.com>
593 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
594 end>: No longer "const".
596 2019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
598 * jit.c: Fix indentation, replace spaces with tabs where
601 2019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
603 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
605 2019-12-12 Tom Tromey <tom@tromey.com>
607 * objfiles.h (struct objfile) <partial_symtabs>: Now a
610 2019-12-12 Tom Tromey <tom@tromey.com>
612 * progspace.h (objfile_list): New typedef.
613 (class unwrapping_objfile_iterator)
614 (struct unwrapping_objfile_range): Newl
615 (struct program_space) <objfiles_range>: Change type.
616 <objfiles>: Change return type.
617 <add_objfile>: Change type of "objfile" parameter.
618 <objfiles_list>: Now a list of shared_ptr.
619 * progspace.c (program_space::add_objfile): Change type of
621 (program_space::remove_objfile): Update.
622 * objfiles.h (struct objfile) <~objfile>: Make public.
623 * objfiles.c (objfile::make): Update.
624 (objfile::unlink): Don't call delete.
626 2019-12-12 Tom Tromey <tom@tromey.com>
628 * symfile.c (symbol_file_clear): Update.
629 * progspace.h (struct program_space) <free_all_objfiles>: Declare
631 * progspace.c (program_space::free_all_objfiles): New method.
632 * objfiles.h (free_all_objfiles): Don't declare.
633 * objfiles.c (free_all_objfiles): Move to program_space.
635 2019-12-12 Tom Tromey <tom@tromey.com>
637 * progspace.c (program_space::add_objfile)
638 (program_space::remove_objfile): Update.
639 (program_space::multi_objfile_p): Remove.
640 * objfiles.h (struct objfile) <next>: Remove.
641 * objfiles.c (objfile::objfile): Update.
642 (put_objfile_before): Update.
643 (unlink_objfile): Update.
644 * progspace.h (object_files): Remove.
645 (struct program_space) <objfiles_head>: Remove.
646 <objfiles_list>: New member.
647 <objfiles_range, objfiles_safe_range>: Change type.
648 (objfiles): Change return type.
649 (objfiles_safe): Update.
650 (multi_objfile_p): Rewrite and inline.
651 (object_files): Remove macro.
653 2019-12-12 Tom Tromey <tom@tromey.com>
655 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
657 (basic_safe_range): New class.
659 2019-12-12 Tom Tromey <tom@tromey.com>
661 * progspace.c (program_space::multi_objfile_p): New method.
662 * printcmd.c (info_symbol_command): Update.
663 * maint.c (maintenance_translate_address): Update.
664 * objfiles.h (MULTI_OBJFILE_P): Remove.
665 * progspace.h (struct program_space) <multi_objfile_p>: New
668 2019-12-12 Tom Tromey <tom@tromey.com>
670 * progspace.h (struct program_space) <remove_objfile>: Declare.
671 * progspace.c (program_space::remove_objfile): New method.
672 * objfiles.c (unlink_objfile): Remove.
673 (objfile::unlink): Call remove_objfile.
674 (objfile): Don't call unlink_objfile.
676 2019-12-12 Tom Tromey <tom@tromey.com>
678 * progspace.h (struct program_space) <add_objfile>: Declare
680 * progspace.c (program_space::add_objfile): New method.
681 * objfiles.c (~objfile): Don't unlink objfile.
682 (put_objfile_before): Remove.
683 (add_separate_debug_objfile): Don't call put_objfile_before.
684 (objfile::make): Call add_objfile. Set new_objfiles_available on
685 the per-program-space data.
687 2019-12-12 Tom Tromey <tom@tromey.com>
689 * symfile.c (syms_from_objfile_1): Use objfile_up.
690 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
692 (reread_symbols): Use objfile_up.
693 * solib.c (update_solib_list, reload_shared_libraries_1): Call
695 * objfiles.h (struct objfile) <~objfile>: Now private.
696 <unlink>: New method.
697 (struct objfile_deleter): New.
698 (objfile_up): New typedef.
699 * objfiles.c (objfile::unlink): New method.
700 (free_objfile_separate_debug, free_all_objfiles)
701 (objfile_purge_solibs): Use it.
702 * jit.c (jit_unregister_code): Remove.
703 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
705 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
707 * compile/compile-object-load.c (compile_object_load): Use
710 2019-12-12 Tom Tromey <tom@tromey.com>
712 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
714 * objfiles.h (struct objjfile) <make>: No longer inline.
715 (add_separate_debug_objfile): Don't declare.
716 * objfiles.c (add_separate_debug_objfile): Now static.
717 (objfile::make): Move from objfiles.h. Call
718 add_separate_debug_objfile. Add "parent" parameter.
720 2019-12-12 Tom Tromey <tom@tromey.com>
722 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
723 * objfiles.h (struct objfile): Make constructor private.
724 <make>: New static method.
725 * jit.c (jit_object_close_impl): Update.
727 2019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
729 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
732 2019-12-12 Tom Tromey <tromey@adacore.com>
734 * xml-support.c (xml_fetch_content_from_file): Don't call
736 * utils.h (class gdb_argv): Remove malloc_failure comment.
737 * utils.c (gdb_argv::reset): Don't call malloc_failure.
739 2019-12-12 Tom Tromey <tromey@adacore.com>
741 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
742 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
743 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
744 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
745 * riscv-ravenscar-thread.c: New file.
746 * riscv-ravenscar-thread.h: New file.
747 * riscv-tdep.c (riscv_gdbarch_init): Call
748 register_riscv_ravenscar_ops.
750 2019-12-12 Tom Tromey <tromey@adacore.com>
752 * gdbsupport/thread-pool.c (set_thread_name): Use
755 2019-12-12 Luis Machado <luis.machado@linaro.org>
757 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
758 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
761 2019-12-11 Tom Tromey <tom@tromey.com>
763 * tui/tui-win.c (tui_set_win_height_command): Call
764 tui_adjust_window_height.
765 (tui_adjust_win_heights, new_height_ok): Remove.
766 * tui/tui-layout.h (tui_adjust_window_height): Declare.
767 * tui/tui-layout.c (tui_adjust_window_height): New function.
769 2019-12-11 Tom Tromey <tom@tromey.com>
771 * tui/tui-win.c (tui_resize_all): Remove code, call
772 tui_apply_current_layout.
774 2019-12-11 Tom Tromey <tom@tromey.com>
776 * tui/tui-layout.h (tui_apply_current_layout): Declare.
777 * tui/tui-layout.c (standard_layouts, applied_layout): New
779 (tui_apply_current_layout): New function.
780 (show_layout): Set applied_layout. Call
781 tui_apply_current_layout.
782 (show_source_command, show_disasm_command)
783 (show_source_disasm_command, show_data)
784 (show_source_or_disasm_and_command): Remove.
785 (initialize_layouts): New function.
786 (_initialize_tui_layout): Call initialize_layouts.
788 2019-12-11 Tom Tromey <tom@tromey.com>
790 * tui/tui-layout.h (class tui_layout_base)
791 (class tui_layout_window, class tui_layout_split): New.
792 * tui/tui-layout.c (tui_get_window_by_name)
793 (tui_layout_window::clone, tui_layout_window::apply)
794 (tui_layout_window::get_sizes, tui_layout_window::add_split)
795 (tui_layout_split::add_window, tui_layout_split::clone)
796 (tui_layout_split::get_sizes)
797 (tui_layout_split::set_weights_from_heights)
798 (tui_layout_split::adjust_size, tui_layout_split::apply): New
800 (tui_layout_split::add_split, tui_layout_split::add_split)
801 (tui_layout_split::set_weights_from_heights)
802 (tui_layout_split::set_weights_from_heights): New functions.
804 2019-12-11 Tom Tromey <tom@tromey.com>
806 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
807 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
808 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
809 * tui/tui-data.h (struct tui_point): Remove.
810 (struct tui_gen_win_info) <origin>: Remove.
812 * tui/tui-command.c (tui_cmd_window::resize): Update.
814 2019-12-11 Tom Tromey <tom@tromey.com>
816 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
818 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
820 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
822 (struct tui_win_info) <min_height>: Implement.
824 2019-12-11 Tom Tromey <tom@tromey.com>
826 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
827 (struct tui_win_info) <can_box>: Update.
829 2019-12-11 Tom Tromey <tom@tromey.com>
831 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
833 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
835 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
837 (struct tui_win_info) <max_height>: Now override.
839 2019-12-11 Joel Brobecker <brobecker@adacore.com>
841 * NEWS: Create a new section for the next release branch.
842 Rename the section of the current branch, now that it has
845 2019-12-11 Joel Brobecker <brobecker@adacore.com>
847 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
848 * version.in: Bump version to 10.0.50.DATE-git.
850 2019-12-11 Tom Tromey <tromey@adacore.com>
853 * gdbsupport/thread-pool.c (set_thread_name): New function.
854 (thread_pool::set_thread_count): Don't call pthread_setname_np.
855 (thread_pool::thread_function): Call set_thread_name.
857 2019-12-11 Tom Tromey <tromey@adacore.com>
859 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
862 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
864 * NEWS: Document -raw-values option and the related setting commands.
865 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
866 only set it on when /r is given.
867 * valprint.c (value_print_option_defs): New element raw-values.
868 * Makefile.in: Add the new file.
870 2019-12-10 Christian Biesinger <cbiesinger@google.com>
872 * gdbsupport/safe-strerror.c: Supress the unused function warning
873 for select_strerror_r.
875 2019-12-10 Christian Biesinger <cbiesinger@google.com>
877 * config.in: Regenerate.
878 * configure: Regenerate.
879 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
880 safe_strerror instead of strerror.
881 * gdbsupport/common.m4: Don't check for strerror.
882 * gdbsupport/safe-strerror.c: Support both the glibc version
883 of strerror_r and the XSI version.
885 2019-12-10 Tom Tromey <tromey@adacore.com>
887 * ada-typeprint.c (print_choices): Use a single "?".
888 (print_variant_part): Print "?" if the discriminant name
891 2019-12-10 George Barrett <bob@bob131.so>
893 Fix scripted probe breakpoints.
894 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
896 (breakpoint_ops_for_event_location_type)
897 (breakpoint_ops_for_event_location): Add function definitions.
898 (break_command_1, trace_command): Use
899 breakpoint_ops_for_event_location.
900 * breakpoint.h (breakpoint_ops_for_event_location): Add function
902 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
903 breakpoint_ops_for_event_location.
904 * python/py-breakpoint.c (bppy_init): Use
905 breakpoint_ops_for_event_location.
907 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
909 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
910 when ranking an lvalue argument for an rvalue parameter.
912 2019-12-08 Wataru Ashihara <wataash@wataash.com>
914 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
915 template argument for scoped_restore_tmpl from bool to int.
917 2019-12-07 Keith Seitz <keiths@redhat.com>
919 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
920 (build_id_to_debug_bfd): Make static, rewriting to use
921 build_id_to_bfd_suffix.
922 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
923 adding `suffix' parameter. Append SUFFIX to file names
924 when searching for matching files.
925 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
926 (build_id_to_exec_bfd): Likewise.
927 * build-id.h (build_id_to_debug_bfd): Clarify that function
928 searches for BFD of debug info file.
929 (build_id_to_exec_bfd): Declare.
930 * corelow.c: Include build-id.h.
931 (locate_exec_from_corefile_build_id): New function.
932 (core_target_open): If no executable BFD is found,
933 search for a core file BFD using build-id.
935 2019-12-06 Christian Biesinger <cbiesinger@google.com>
937 * bcache.c: Put in namespace gdb.
938 * bcache.h: Likewise.
939 * gdbtypes.c (check_types_worklist): Update.
940 (types_deeply_equal): Update.
941 * macrotab.c (struct macro_table) <bcache>: Update.
942 (new_macro_table): Update.
943 * macrotab.h (struct bcache): Put this forward declaration
944 inside namespace gdb.
945 (new_macro_table): Update.
946 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
948 <macro_cache>: Update.
949 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
951 2019-12-06 Tom de Vries <tdevries@suse.de>
954 * block.c (best_symbol, better_symbol): New function.
955 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
958 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
960 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
961 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
962 for ranking see-through reference cases.
964 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
965 * stack.c (faas_command): Check a command is provided.
966 * thread.c (taas_command, tfaas_command): Likewise.
968 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
969 * inferior.c (prune_inferiors): Only call delete_inferior,
970 Do not modify the inferior list.
972 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
974 * c-exp.y: Update calls to lookup_typename,
975 lookup_signed_typename and lookup_unsigned_typename.
976 * c-lang.c (evaluate_subexp_c): Likewise.
977 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
979 * eval.c (binop_promote): Likewise.
980 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
981 (lookup_unsigned_typename): Likewise.
982 (lookup_signed_typename): Likewise.
983 * gdbtypes.h (lookup_unsigned_typename): Likewise.
984 (lookup_signed_typename): Likewise.
985 (lookup_typename): Likewise.
986 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
987 lookup_typename, lookup_signed_typename,
988 lookup_unsigned_typename.
989 * m2-exp.y: Likewise.
990 * printcmd.c (printf_wide_c_string): Likewise.
991 (ui_printf): Likewise.
992 * python/py-type.c (typy_lookup_typename): Likewise.
993 * python/py-xmethods.c (python_xmethod_worker::invoke):
995 * rust-exp.y: Likewise.
997 2019-12-04 Christian Biesinger <cbiesinger@google.com>
999 * configure.nat (obsd64): Add missing files x86-nat.o and
1002 2019-12-04 Tom Tromey <tom@tromey.com>
1004 * valprint.c (val_print_string): Use metadata_style.
1005 * go-valprint.c (print_go_string): Use metadata style.
1006 * p-valprint.c (pascal_object_print_static_field): Use metadata
1008 * cp-valprint.c (cp_print_static_field): Use metadata style.
1010 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1011 Chris January <chris.january@arm.com>
1013 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
1015 (typebase): New patterns for complex, single/double precision, and
1016 single/double complex.
1017 (f77_keywords): Change token for complex keyword, and add single,
1018 double, and precision keywords.
1020 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1022 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
1023 "info io_registers".
1025 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1027 * regcache.c (cooked_read_test): Initialize thread list of
1030 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1032 * aarch64-linux-tdep.c: Remove includes.
1034 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1036 * aarch64-tdep.c: Remove includes.
1038 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
1040 * filtered-iterator.h (filtered_iterator) <operator==,
1041 operator!=>: Compare wrapped iterators, not wrapped pointers.
1042 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1043 unittests/filtered_iterator-selftests.c.
1044 * unittests/filtered_iterator-selftests.c: New file.
1046 2019-12-04 Tom Tromey <tromey@adacore.com>
1048 * gdbtypes.c (create_range_type): Inherit endianity
1051 2019-12-04 Tom Tromey <tromey@adacore.com>
1053 * ada-lang.c (decode_constrained_packed_array)
1054 (ada_value_assign, value_assign_to_component): Update.
1055 * dwarf2loc.c (rw_pieced_value, access_memory)
1056 (dwarf2_compile_expr_to_ax): Update.
1057 * dwarf2read.c (dwarf2_add_field): Update.
1058 * eval.c (evaluate_subexp_standard): Update.
1059 * gdbarch.c, gdbarch.h: Rebuild.
1060 * gdbarch.sh (bits_big_endian): Remove.
1061 * gdbtypes.h (union field_location): Update comment.
1062 * target-descriptions.c (make_gdb_type): Update.
1063 * valarith.c (value_bit_index): Update.
1064 * value.c (struct value) <bitpos>: Update comment.
1065 (unpack_bits_as_long, modify_field): Update.
1066 * value.h (value_bitpos): Update comment.
1068 2019-12-04 Tom Tromey <tromey@adacore.com>
1070 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
1073 2019-12-04 Tom Tromey <tromey@adacore.com>
1075 * dwarf2read.c (dwarf2_init_float_type)
1076 (dwarf2_init_complex_target_type): Add byte_order parameter.
1077 (read_base_type): Compute byte order earlier.
1078 * gdbtypes.c (init_float_type): Add byte_order parameter.
1079 * gdbtypes.h (init_float_type): Add byte_order parameter.
1081 2019-12-04 Tom Tromey <tromey@adacore.com>
1083 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1085 2019-12-04 Tom Tromey <tromey@adacore.com>
1087 * dwarf2read.c (process_structure_scope): Initialize
1090 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1092 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1093 add it into the search spec.
1094 (parse_max_results_option): New function.
1095 (mi_info_functions_or_variables): Parse -max-results flag and pass
1096 it to mi_symbol_info.
1097 (mi_cmd_symbol_info_modules): Likewise.
1098 (mi_cmd_symbol_info_types): Likewise.
1099 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1100 return type to bool, change result container into a set, and don't
1101 add new results if we have enough already.
1102 (global_symbol_searcher::add_matching_msymbols): Change return
1103 type to bool, and don't add new results if we have enough already.
1104 (sort_search_symbols_remove_dups): Delete.
1105 (global_symbol_searcher::search): Early exit from search loop when
1106 we have enough results. Use a std::set to collect the results
1107 from calling add_matching_symbols.
1108 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1110 (global_symbol_searcher) <m_max_search_results>: New member
1112 (global_symbol_searcher) <add_matching_symbols>: Update header
1113 comment and change return type to bool.
1114 (global_symbol_searcher) <add_matching_msymbols>: Update header
1115 comment and change return type to bool.
1117 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1119 * symtab.c (symbol_search::compare_search_syms): Update header
1121 (global_symbol_searcher::is_suitable_msymbol): New function.
1122 (global_symbol_searcher::expand_symtabs): New function.
1123 (global_symbol_searcher::add_matching_symbols): New function.
1124 (global_symbol_searcher::add_matching_msymbols): New function.
1125 (global_symbol_searcher::search): Move most of the content
1126 into the new functions above, and call them as needed.
1127 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1129 (global_symbol_searcher) <add_matching_symbols>: New member
1131 (global_symbol_searcher) <add_matching_msymbols>: New member
1133 (global_symbol_searcher) <is_suitable_msymbol>: New member
1136 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1138 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1139 -symbol-info-module-variables entries.
1140 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1141 (mi_cmd_symbol_info_module_variables): Declare.
1142 * mi/mi-symbol-cmds.c
1143 (module_symbol_search_iterator): New typedef.
1144 (output_module_symbols_in_single_module_and_file): New function.
1145 (output_module_symbols_in_single_module): New function.
1146 (mi_info_module_functions_or_variables): New function.
1147 (mi_cmd_symbol_info_module_functions): New function.
1148 (mi_cmd_symbol_info_module_variables): New function.
1149 * NEWS: Mention new MI command.
1151 2019-12-03 Christian Biesinger <cbiesinger@google.com>
1153 * bcache.c (hash): Remove.
1154 (hash_continue): Remove.
1155 * bcache.h (hash): Remove.
1156 (hash_continue): Remove.
1157 (struct bcache) <ctor>: Update.
1158 * psymtab.c (psymbol_hash): Update.
1159 * stabsread.c (hashname): Update.
1160 * utils.h (fast_hash): Add an argument for a start value,
1163 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1164 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1165 (destroy_block_symbol_cache): New function.
1166 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1167 (resize_symbol_cache): Likewise.
1169 2019-12-02 Tom Tromey <tom@tromey.com>
1171 * unittests/tui-selftests.c (run_tests): Make conditional.
1172 (_initialize_tui_selftest): Make conditional.
1174 2019-12-02 Christian Biesinger <cbiesinger@google.com>
1176 * aix-thread.c (debug_aix_thread): Change type to bool.
1178 2019-12-02 Luis Machado <luis.machado@linaro.org>
1180 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1182 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1184 * dwarf2read.c (read_tag_string_type): Read the fields required to
1185 make a dynamic string, and possibly create a dynamic range for the
1187 (attr_to_dynamic_prop): Setup is_reference based on the type of
1188 attribute being processed.
1189 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1190 (resolve_dynamic_array): Rename to...
1191 (resolve_dynamic_array_or_string): ...this, update header comment,
1192 and accept TYPE_CODE_STRING.
1193 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1195 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1197 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1198 of its implementation from...
1199 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1202 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1204 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1205 create a range with stride where appropriate.
1206 * f-valprint.c: Include 'gdbarch.h'.
1207 (f77_print_array_1): Take the stride into account when walking the
1208 array. Also convert the stride into addressable units.
1209 * gdbtypes.c (create_range_type): Initialise the stride to
1211 (create_range_type_with_stride): New function, initialise the
1212 range as normal, and then setup the stride.
1213 (has_static_range): Include the stride here. Also change the
1214 return type to bool.
1215 (create_array_type_with_stride): Consider the range stride if the
1216 array isn't given its own stride.
1217 (resolve_dynamic_range): Resolve the stride if needed.
1218 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1219 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1220 (TYPE_BIT_STRIDE): Define.
1221 (TYPE_ARRAY_BIT_STRIDE): Define.
1222 (create_range_type_with_stride): Declare.
1223 * valarith.c (value_subscripted_rvalue): Take range stride into
1224 account when walking the array.
1226 2019-12-01 Tom Tromey <tom@tromey.com>
1228 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1231 2019-12-01 Tom Tromey <tom@tromey.com>
1233 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1235 * unittests/tui-selftests.c: New file.
1236 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1238 2019-12-01 Tom Tromey <tom@tromey.com>
1240 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1242 2019-12-01 Tom Tromey <tom@tromey.com>
1244 * NEWS: Document new settings.
1245 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1246 * tui/tui-win.c (_initialize_tui_win): Add border style
1248 * tui/tui-io.h (tui_apply_style): Declare.
1249 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1251 (apply_ansi_escape, tui_set_reverse_mode): Update.
1252 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1253 Add "skip_intensity" parameter.
1254 <changed>: New member.
1255 <do_set_value>: Declare.
1256 (tui_border_style, tui_active_border_style): Declare.
1257 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1259 (cli_style_option): Initialize "changed".
1260 (cli_style_option::do_set_value): New function.
1261 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1263 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1264 (_initialize_cli_style): Update. Create TUI border style
1267 2019-12-01 Tom Tromey <tom@tromey.com>
1269 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1271 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1273 * tui/tui-win.h (compact_source): Declare.
1274 * tui/tui-win.c (compact_source): New global.
1275 (tui_set_compact_source, tui_show_compact_source): New functions.
1276 (_initialize_tui_win): Add "compact-source" setting.
1277 * tui/tui-source.c (tui_source_window::set_contents): Handle
1278 compact_source setting.
1279 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1280 * NEWS: Document new setting.
1282 2019-11-30 Tom Tromey <tom@tromey.com>
1284 * dwarf2read.c (dwarf2_add_field): Include field offset when
1285 computing variant part length.
1287 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1288 * NEWS: Mention define-prefix. Tell that command names can now
1289 contain a . character.
1291 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1293 * command.h (valid_cmd_char_p): Declare.
1294 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1295 the check of valid command char.
1296 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1298 * cli/cli-script.c (validate_comname): Likewise.
1299 * completer.c (gdb_completer_command_word_break_characters):
1300 Do not remove . from the word break char, update comments.
1301 (complete_line_internal_1): Use valid_cmd_char_p.
1302 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1303 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1305 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1307 * cli/cli-script.c (do_define_command): Ensure a redefined
1308 prefix command is kept as a prefix command.
1309 (define_prefix_command): New function.
1310 (show_user_1): Report user defined prefixes.
1311 (_initialize_cli_script): Create the new 'define-prefix' command.
1312 Add completers for 'define' and 'document'.
1313 * top.c (execute_command): If command is a user-defined prefix only
1314 command, report the list of commands for this prefix command.
1316 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1318 * valops.c (find_oload_champ): Improve debug output.
1320 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1322 * valops.c (find_oload_champ): Print part of debug messages
1323 before the badness vector is std::move'd.
1325 2019-11-28 Tom Tromey <tom@tromey.com>
1327 * value.c (creal_internal_fn): Fix comment.
1329 2019-11-28 Tom Tromey <tom@tromey.com>
1331 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1332 flag_bound_evaluated>: Now unsigned.
1334 2019-11-28 Tom Tromey <tom@tromey.com>
1336 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1339 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1341 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1343 * jit.c (jit_unregister_code): Add debug print to match
1344 `jit_register_code`.
1346 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1348 * NEWS: Mention the new multithreaded symbol loading.
1350 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1352 * maint.c (n_worker_threads): Default to 0.
1353 (worker_threads_disabled): New function.
1354 * maint.h (worker_threads_disabled): New function.
1355 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1356 here if worker_threads_disabled () is true.
1357 (minimal_symbol_reader::install): Skip all threading if
1358 worker_threads_disabled () is true.
1360 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1362 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1363 hash code if possible.
1364 (add_minsym_to_demangled_hash_table): Likewise.
1365 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1366 on the background thread.
1367 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1370 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1372 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1373 of the mangled name on the background thread.
1374 * symtab.c (symbol_set_names): Allow passing in the hash of the
1376 * symtab.h (symbol_set_names): Likewise.
1378 2019-11-27 Kevin Buettner <kevinb@redhat.com>
1380 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1381 physnames are computed for inherited DIEs.
1383 2019-11-27 Tom Tromey <tromey@adacore.com>
1385 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1387 * cp-support.c: Remove unnecessary backslashes.
1389 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1391 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1392 with sym->set_linkage_name.
1393 * coffread.c (coff_read_enum_type): Likewise.
1394 * mdebugread.c (parse_symbol): Likewise.
1395 * stabsread.c (patch_block_stabs): Likewise.
1396 (define_symbol): Likewise.
1397 (read_enum_type): Likewise.
1398 (common_block_end): Likewise.
1399 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1401 (SYMBOL_SET_LINKAGE_NAME): Remove.
1402 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1403 with sym->set_linkage_name.
1405 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1407 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1408 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1409 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1410 * NEWS: Mention new MI command.
1412 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1414 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1415 '-symbol-info-types', and '-symbol-info-variables'.
1416 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1417 (mi_cmd_symbol_info_types): Declare.
1418 (mi_cmd_symbol_info_variables): Declare.
1419 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1420 (output_debug_symbol): New function.
1421 (output_nondebug_symbol): New function.
1422 (mi_symbol_info): New function.
1423 (mi_info_functions_or_variables): New function.
1424 (mi_cmd_symbol_info_functions): New function.
1425 (mi_cmd_symbol_info_types): New function.
1426 (mi_cmd_symbol_info_variables): New function.
1427 * NEWS: Mention new commands.
1429 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1431 * symtab.c (symbol_to_info_string): New function, most content
1432 moved from print_symbol_info, but updated to return a std::string.
1433 (print_symbol_info): Update to use symbol_to_info_string and print
1435 * symtab.h (symbol_to_info_string): Declare new function.
1437 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1439 * python/python.c (gdbpy_rbreak): Convert to using
1440 global_symbol_searcher.
1441 * symtab.c (file_matches): Convert return type to bool, change
1442 file list to std::vector, update header comment.
1443 (search_symbols): Rename to...
1444 (global_symbol_searcher::search): ...this and update now its
1445 a member function of global_symbol_searcher. Take account of the
1446 changes to file_matches.
1447 (symtab_symbol_info): Convert to using global_symbol_searcher.
1448 (rbreak_command): Likewise.
1449 (search_module_symbols): Likewise.
1450 * symtab.h (enum symbol_search): Update comment.
1451 (search_symbols): Remove declaration.
1452 (class global_symbol_searcher): New class.
1454 2019-11-26 Tom Tromey <tromey@adacore.com>
1456 * cp-support.c (_initialize_cp_support): Conditionally initialize
1457 gdb_demangle_attempt_core_dump.
1459 2019-11-26 Tom Tromey <tom@tromey.com>
1461 * python/py-function.c (fnpy_init): Update.
1462 * value.h (add_internal_function): Adjust declaration.
1463 * value.c (function_destroyer): Remove.
1464 (do_add_internal_function): Don't set destroyer or copy name.
1465 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1467 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1468 (cmdpy_init): Set name_allocated.
1469 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1471 (~cmd_list_element): Free "name" if needed.
1473 2019-11-26 Tom Tromey <tom@tromey.com>
1475 * value.h (add_internal_function): Add new overload. Move
1476 documentation from value.h.
1477 * value.c (do_add_internal_function): New function.
1478 (add_internal_function): Use it. Add new overload.
1479 (function_destroyer): Don't free doc.
1480 * python/py-function.c (fnpy_init): Update.
1482 2019-11-26 Tom Tromey <tom@tromey.com>
1484 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1485 (cmdpy_init): Set "doc_allocated".
1487 2019-11-26 Tom Tromey <tom@tromey.com>
1489 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1490 name of worker thread.
1491 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1493 * configure, config.in: Rebuild.
1495 2019-11-26 Tom Tromey <tom@tromey.com>
1497 * python/python.c (class gdbpy_gil): New.
1498 (struct gdbpy_event): Add constructor, destructor, operator().
1499 (gdbpy_post_event): Use run_on_main_thread.
1500 (gdbpy_initialize_events): Remove.
1501 (do_start_initialization): Update.
1503 2019-11-26 Tom Tromey <tom@tromey.com>
1506 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1507 commands. Call update_thread_pool_size.
1508 (update_thread_pool_size, maintenance_set_worker_threads): New
1510 (n_worker_threads): New global.
1512 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1513 Tom Tromey <tom@tromey.com>
1515 * minsyms.c (minimal_symbol_reader::install): Use
1517 * gdbsupport/parallel-for.h: New file.
1518 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1520 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1521 Tom Tromey <tom@tromey.com>
1523 * gdbsupport/thread-pool.h: New file.
1524 * gdbsupport/thread-pool.c: New file.
1525 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1526 (HFILES_NO_SRCDIR): Add thread-pool.h.
1528 2019-11-26 Tom Tromey <tom@tromey.com>
1530 * event-top.h (thread_local_segv_handler): Declare.
1531 * event-top.c (thread_local_segv_handler): New global.
1532 (install_handle_sigsegv, handle_sigsegv): New functions.
1533 (async_init_signals): Install SIGSEGV handler.
1534 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1536 (report_failed_demangle): New function.
1537 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1538 handler-setting code, instead use segv_handler. Run warning code
1541 2019-11-26 Tom Tromey <tom@tromey.com>
1543 * run-on-main-thread.c: New file.
1544 * run-on-main-thread.h: New file.
1545 * unittests/main-thread-selftests.c: New file.
1546 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1547 main-thread-selftests.c.
1548 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1549 (COMMON_SFILES): Add run-on-main-thread.c.
1551 2019-11-26 Tom Tromey <tom@tromey.com>
1553 * main.c (setup_alternate_signal_stack): Remove.
1554 (captured_main_1): Use gdb::alternate_signal_stack.
1555 * gdbsupport/alt-stack.h: New file.
1557 2019-11-26 Tom Tromey <tom@tromey.com>
1559 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1561 (save_original_signals_state, restore_original_signals_state): Use
1563 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1564 (_initialize_linux_nat): Use gdb_sigmask.
1565 * guile/guile.c (_initialize_guile): Use block_signals.
1566 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1567 * gdbsupport/gdb-sigmask.h: New file.
1568 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1569 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1570 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1572 * configure, config.in: Rebuild.
1573 * gdbsupport/block-signals.h: New file.
1575 2019-11-26 Tom Tromey <tom@tromey.com>
1577 * acinclude.m4: Include ax_pthread.m4.
1578 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1579 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1580 (CLIBS): Use PTHREAD_LIBS.
1581 (aclocal_m4_deps): Add ax_pthread.m4.
1582 * config.in, configure: Rebuild.
1583 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1585 2019-11-26 Tom Tromey <tom@tromey.com>
1587 * symtab.h (struct minimal_symbol) <name_set>: New member.
1588 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1589 Don't call symbol_set_names.
1590 (minimal_symbol_reader::install): Call symbol_set_names.
1592 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1594 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1595 restore_active_ext_lang, as GIL is needed for (indirectly)
1596 called PyOS_InterruptOccurred.
1598 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1600 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1603 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1605 * remote-sim.c (simulator_command): Make static, remove
1608 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1610 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1612 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1613 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1615 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1617 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1619 * unittests/basic_string_view/element_access/char/1.cc (test01):
1622 * unittests/basic_string_view/element_access/char/empty.cc (main):
1624 * unittests/basic_string_view/element_access/char/front_back.cc
1627 * unittests/basic_string_view/inserters/char/2.cc (test05):
1630 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1633 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1636 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1638 * unittests/basic_string_view/operations/compare/char/1.cc
1641 * unittests/basic_string_view/operations/compare/char/13650.cc
1643 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1646 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1649 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1652 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1655 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1658 * unittests/basic_string_view/operations/find/char/4.cc (main):
1660 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1663 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1666 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1669 * unittests/basic_string_view/operations/substr/char/1.cc
1672 * unittests/basic_string_view/operators/char/2.cc (main):
1674 * unittests/optional/assignment/1.cc (test): Likewise.
1675 * unittests/optional/assignment/2.cc (test): Likewise.
1676 * unittests/optional/assignment/3.cc (test): Likewise.
1677 * unittests/optional/assignment/4.cc (test): Likewise.
1678 * unittests/optional/assignment/5.cc (test): Likewise.
1679 * unittests/optional/assignment/6.cc (test): Likewise.
1680 * unittests/optional/assignment/7.cc (test): Likewise.
1681 * unittests/optional/cons/copy.cc (test): Likewise.
1682 * unittests/optional/cons/default.cc (test): Likewise.
1683 * unittests/optional/cons/move.cc (test): Likewise.
1684 * unittests/optional/cons/value.cc (test): Likewise.
1685 * unittests/optional/in_place.cc (test): Likewise.
1686 * unittests/optional/observers/1.cc (test): Likewise.
1687 * unittests/optional/observers/2.cc (test): Likewise.
1689 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1691 * tui-win.h (tui_set_var_cmd): Remove.
1692 * tui-win.c (tui_set_var_cmd): Make static.
1694 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1696 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1697 rbreak_command_wrapper): Remove.
1698 * symtab.c (rbreak_command_wrapper): Remove.
1700 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1702 * inferior.h (info_terminal_command): Remove declaration.
1703 * inflow.c (info_terminal_command): Make static.
1705 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1707 * inferior.c (exit_inferior_silent): Remove.
1709 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1711 * dictionary.c (dict_empty, mdict_empty): Remove.
1712 * dictionary.c (mdict_empty): Remove.
1714 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1716 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1717 (arc_insn_get_memory_offset): Likewise.
1718 (arc_insn_dump): Likewise.
1719 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1720 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1721 * dictionary.c (dict_iterator_next): Likewise.
1722 (dict_iter_match_first): Likewise.
1723 (dict_iter_match_next): Likewise.
1724 * f-lang.c (evaluate_subexp_f): Likewise.
1725 * hppa-tdep.c (hppa_read_pc): Likewise.
1726 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1727 * parse.c (write_exp_elt_msym): Likewise.
1728 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1729 * remote.c (remote_packet_size): Likewise.
1730 (remote_notif_stop_parse): Likewise.
1731 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1732 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1733 * source.c (prepare_path_for_appending): Likewise.
1734 * sparc64-linux-tdep.c
1735 (sparc64_linux_handle_segmentation_fault); Likewise.
1736 * stack.c (frame_selection_by_function_completer): Likewise.
1738 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1740 * completer.c (set_gdb_completion_word_break_characters):
1743 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1745 * dwarf-index-write.c: Include dwarf-index-write.h.
1746 * mi/mi-interp.c: Include mi/mi-interp.h.
1748 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1750 * aarch32-tdep.c: Include aarch32-tdep.h.
1751 * aarch32-tdep.h: Forward-declare struct target_desc.
1753 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1755 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1757 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1758 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1760 2019-11-25 Tom de Vries <tdevries@suse.de>
1762 * contrib/words.sh: Add -c option.
1764 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1766 * solib.c (solib_find_1): Change int to bool.
1767 (exec_file_find): Change int to bool.
1768 (solib_find): Change int to bool.
1769 (solib_read_symbols): Change int to bool.
1770 (solib_used): Change int to bool.
1771 (solib_add): Change int to bool.
1772 (info_sharedlibrary_command): Change int to bool.
1773 (solib_contains_address_p): Change int to bool.
1774 (solib_keep_data_in_core): Change int to bool.
1775 (in_solib_dynsym_resolve_code): Change int to bool.
1776 (reload_shared_libraries_1): Change int to bool.
1777 (gdb_sysroot_changed): Change int to bool.
1778 * solib.h (solib_read_symbols): Change int to bool.
1779 (solib_contains_address_p): Change int to bool.
1780 (solib_keep_data_in_core): Change int to bool.
1781 (in_solib_dynsym_resolve_code): Change int to bool.
1782 (libpthread_name_p): Change int to bool.
1784 2019-11-25 Luis Machado <luis.machado@linaro.org>
1786 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1787 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1788 (remote_packet_max_chars): New static global.
1789 (show_remote_packet_max_chars): New function.
1790 (remote_target::putpkt_binary): Adjust to use new
1791 remote_packet_max_chars option.
1792 (remote_target::getpkt_or_notif_sane_1): Likewise.
1793 (_initialize_remote): Register new remote-packet-max-chars option.
1795 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1797 * m68k-linux-nat.c: Include gdbarch.h.
1799 2019-11-24 Tom Tromey <tom@tromey.com>
1801 * symfile.c (read_symbols): Update.
1802 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1804 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1805 (psym_lookup_symbol, psym_find_last_source_symtab)
1806 (psym_forget_cached_source_info, psym_print_stats)
1807 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1808 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1809 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1810 (psym_find_compunit_symtab_by_address)
1811 (maintenance_print_psymbols, maintenance_info_psymtabs)
1812 (maintenance_check_psymtabs): Update.
1813 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1816 2019-11-22 Tom Tromey <tom@tromey.com>
1818 * observable.h: Update comments.
1820 2019-11-22 Tom Tromey <tromey@adacore.com>
1822 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1823 (print_ada_task_info): Don't try to fetch thread id if task is not
1826 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1828 * ada-exp.y: Update.
1829 * ada-lang.c (sort_choices): Update.
1830 (ada_print_symbol_signature): Update.
1831 (resolve_subexp): Update.
1832 (ada_parse_renaming): Update.
1833 (ada_read_renaming_var_value): Update.
1834 (lesseq_defined_than): Update.
1835 (remove_extra_symbols): Update.
1836 (remove_irrelevant_renamings): Update.
1837 (ada_add_block_symbols): Update.
1838 (ada_collect_symbol_completion_matches): Update.
1839 (ada_is_renaming_symbol): Update.
1840 (aggregate_assign_from_choices): Update.
1841 (ada_evaluate_subexp): Update.
1842 (ada_has_this_exception_support): Update.
1843 (ada_is_non_standard_exception_sym): Update.
1844 (ada_add_exceptions_from_frame): Update.
1845 (ada_add_global_exceptions): Update.
1846 (ada_print_subexp): Update.
1847 * ax-gdb.c (gen_var_ref): Update.
1848 (gen_maybe_namespace_elt): Update.
1849 (gen_expr_for_cast): Update.
1852 * blockframe.c (find_pc_partial_function): Update.
1853 * breakpoint.c (print_breakpoint_location): Update.
1854 (update_static_tracepoint): Update.
1855 * btrace.c (ftrace_print_function_name): Update.
1856 (ftrace_function_switched): Update.
1857 * buildsym.c (find_symbol_in_list): Update.
1859 * c-typeprint.c (c_print_typedef): Update.
1860 (c_type_print_template_args): Update.
1861 * cli/cli-cmds.c (edit_command): Update.
1862 (list_command): Update.
1863 (print_sal_location): Update.
1864 * coffread.c (patch_opaque_types): Update.
1865 (process_coff_symbol): Update.
1866 (coff_read_enum_type): Update.
1867 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1868 (convert_one_symbol): Update.
1869 (hash_symname): Update.
1870 (eq_symname): Update.
1871 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1872 * compile/compile-cplus-types.c (debug_print_scope): Update.
1873 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1874 * compile/compile-object-load.c (get_out_value_type): Update.
1875 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1876 (search_symbol_list): Update.
1877 (cp_lookup_symbol_imports_or_template): Update.
1878 * cp-support.c (overload_list_add_symbol): Update.
1879 * ctfread.c (psymtab_to_symtab): Update.
1880 * dbxread.c (cp_set_block_scope): Update.
1881 * dictionary.c (iter_match_first_hashed): Update.
1882 (iter_match_next_hashed): Update.
1883 (insert_symbol_hashed): Update.
1884 (iter_match_next_linear): Update.
1885 * dictionary.h: Update.
1886 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1887 (locexpr_describe_location_piece): Update.
1888 (locexpr_describe_location_1): Update.
1889 (locexpr_generate_c_location): Update.
1890 (loclist_describe_location): Update.
1891 (loclist_generate_c_location): Update.
1892 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1893 (read_func_scope): Update.
1894 (process_enumeration_scope): Update.
1895 (new_symbol): Update.
1896 (dwarf2_const_value): Update.
1897 (dwarf2_symbol_mark_computed): Update.
1898 * eval.c (evaluate_funcall): Update.
1899 (evaluate_subexp_standard): Update.
1900 * expprint.c (print_subexp_standard): Update.
1901 (dump_subexp_body_standard): Update.
1902 * f-valprint.c (info_common_command_for_block): Update.
1903 * findvar.c (get_hosting_frame): Update.
1904 (default_read_var_value): Update.
1905 * go-lang.c (go_symbol_package_name): Update.
1906 * guile/scm-block.c (bkscm_print_block_smob): Update.
1907 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1908 (gdbscm_symbol_name): Update.
1909 (gdbscm_symbol_linkage_name): Update.
1910 (gdbscm_symbol_print_name): Update.
1911 * infcall.c (get_function_name): Update.
1912 * infcmd.c (jump_command): Update.
1913 (finish_command): Update.
1914 * infrun.c (insert_exception_resume_breakpoint): Update.
1915 * linespec.c (canonicalize_linespec): Update.
1916 (create_sals_line_offset): Update.
1917 (convert_linespec_to_sals): Update.
1918 (complete_label): Update.
1919 (find_label_symbols_in_block): Update.
1920 * m2-typeprint.c (m2_print_typedef): Update.
1921 * mdebugread.c (mdebug_reg_to_regnum): Update.
1922 (parse_symbol): Update.
1923 (mylookup_symbol): Update.
1924 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1925 (list_args_or_locals): Update.
1926 * objc-lang.c (compare_selectors): Update.
1927 (info_selectors_command): Update.
1928 (compare_classes): Update.
1929 (info_classes_command): Update.
1930 (find_imps): Update.
1931 * p-typeprint.c (pascal_print_typedef): Update.
1932 * printcmd.c (build_address_symbolic): Update.
1933 (info_address_command): Update.
1934 (print_variable_and_value): Update.
1935 * python/py-framefilter.c (extract_sym): Update.
1936 (py_print_single_arg): Update.
1937 * python/py-symbol.c (sympy_str): Update.
1938 (sympy_get_name): Update.
1939 (sympy_get_linkage_name): Update.
1940 * python/python.c (gdbpy_rbreak): Update.
1941 * record-btrace.c (btrace_get_bfun_name): Update.
1942 (btrace_call_history): Update.
1943 * rust-lang.c (rust_print_typedef): Update.
1944 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1945 * stabsread.c (stab_reg_to_regnum): Update.
1946 (define_symbol): Update.
1947 (read_enum_type): Update.
1948 (common_block_end): Update.
1949 (cleanup_undefined_types_1): Update.
1950 (scan_file_globals): Update.
1951 * stack.c (print_frame_arg): Update.
1952 (print_frame_args): Update.
1953 (find_frame_funname): Update.
1954 (info_frame_command_core): Update.
1955 (iterate_over_block_locals): Update.
1956 (print_block_frame_labels): Update.
1957 (do_print_variable_and_value): Update.
1958 (iterate_over_block_arg_vars): Update.
1959 (return_command): Update.
1960 * symmisc.c (dump_symtab_1): Update.
1961 (print_symbol): Update.
1962 * symtab.c (eq_symbol_entry): Update.
1963 (symbol_cache_dump): Update.
1964 (lookup_language_this): Update.
1965 (find_pc_sect_line): Update.
1966 (skip_prologue_sal): Update.
1967 (symbol_search::compare_search_syms): Update.
1968 (treg_matches_sym_type_name): Update.
1969 (search_symbols): Update.
1970 (print_symbol_info): Update.
1971 (rbreak_command): Update.
1972 (completion_list_add_symbol): Update.
1973 (find_gnu_ifunc): Update.
1974 (get_symbol_address): Update.
1975 (search_module_symbols): Update.
1976 (info_module_subcommand): Update.
1977 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1978 (SYMBOL_LINKAGE_NAME): Remove.
1979 (SYMBOL_DEMANGLED_NAME): Remove.
1980 (SYMBOL_PRINT_NAME): Remove.
1981 (SYMBOL_SEARCH_NAME): Remove.
1982 * tracepoint.c (set_traceframe_context): Update.
1983 (validate_actionline): Update.
1984 (collection_list::collect_symbol): Update.
1985 (encode_actions_1): Update.
1986 (info_scope_command): Update.
1987 (print_one_static_tracepoint_marker): Update.
1988 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1989 * valops.c (address_of_variable): Update.
1990 (find_overload_match): Update.
1991 (find_oload_champ): Update.
1993 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1995 * ada-lang.c (ada_lookup_simple_minsym): Update.
1996 (ada_collect_symbol_completion_matches): Update.
1997 * ada-tasks.c (read_atcb): Update.
1998 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1999 (amd64_windows_skip_trampoline_code): Update.
2000 * arm-tdep.c (skip_prologue_function): Update.
2001 (arm_skip_stack_protector): Update.
2002 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
2003 (arm_wince_skip_main_prologue): Update.
2004 * ax-gdb.c (gen_expr): Update.
2005 * block.c (call_site_for_pc): Update.
2006 * blockframe.c (find_pc_partial_function): Update.
2007 * breakpoint.c (set_breakpoint_location_function): Update.
2008 * btrace.c (ftrace_print_function_name): Update.
2009 (ftrace_function_switched): Update.
2010 * c-valprint.c (print_unpacked_pointer): Update.
2011 * coffread.c (coff_symfile_read): Update.
2012 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
2013 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
2014 * dwarf-index-write.c (write_psymbols): Update.
2015 * dwarf2loc.c (call_site_to_target_addr): Update.
2016 (func_verify_no_selftailcall): Update.
2017 (tailcall_dump): Update.
2018 (call_site_find_chain_1): Update.
2019 (dwarf_expr_reg_to_entry_parameter): Update.
2020 * elfread.c (elf_gnu_ifunc_record_cache): Update.
2021 * eval.c (evaluate_funcall): Update.
2022 (evaluate_subexp_standard): Update.
2023 (evaluate_subexp_for_sizeof): Update.
2024 * expprint.c (print_subexp_standard): Update.
2025 (dump_subexp_body_standard): Update.
2026 * frame.c (get_prev_frame_always_1): Update.
2027 * frv-tdep.c (frv_skip_main_prologue): Update.
2028 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
2029 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
2030 (gnuv3_get_typename_from_type_info): Update.
2031 (gnuv3_skip_trampoline): Update.
2032 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2033 * i386-tdep.c (i386_skip_main_prologue): Update.
2034 (i386_pe_skip_trampoline_code): Update.
2035 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2036 * infcall.c (get_function_name): Update.
2037 * linespec.c (minsym_found): Update.
2038 * linux-fork.c (info_checkpoints_command): Update.
2039 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2040 (m32c_m16c_pointer_to_address): Update.
2041 * maint.c (maintenance_translate_address): Update.
2042 * minsyms.c (add_minsym_to_hash_table): Update.
2043 (add_minsym_to_demangled_hash_table): Update.
2044 (lookup_minimal_symbol_mangled): Update.
2045 (lookup_minimal_symbol_demangled): Update.
2046 (lookup_minimal_symbol_linkage): Update.
2047 (lookup_minimal_symbol_text): Update.
2048 (lookup_minimal_symbol_by_pc_name): Update.
2049 (minimal_symbol_is_less_than): Update.
2050 (compact_minimal_symbols): Update.
2051 (build_minimal_symbol_hash_tables): Update.
2052 (find_solib_trampoline_target): Update.
2053 * mips-tdep.c (mips_stub_frame_sniffer): Update.
2054 (mips_skip_pic_trampoline_code): Update.
2055 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2056 * objc-lang.c (info_selectors_command): Update.
2057 (info_classes_command): Update.
2058 (find_methods): Update.
2059 (find_imps): Update.
2060 * p-valprint.c (pascal_val_print): Update.
2061 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2062 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2063 * printcmd.c (build_address_symbolic): Update.
2064 (info_symbol_command): Update.
2065 * psymtab.c (psymbol_name_matches): Update.
2066 (match_partial_symbol): Update.
2067 (lookup_partial_symbol): Update.
2068 (print_partial_symbols): Update.
2069 (sort_pst_symbols): Update.
2070 (maintenance_check_psymtabs): Update.
2071 * python/py-framefilter.c (py_print_frame): Update.
2072 * python/python.c (gdbpy_rbreak): Update.
2073 * record-btrace.c (btrace_get_bfun_name): Update.
2074 (btrace_call_history): Update.
2075 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2076 (rs6000_skip_trampoline_code): Update.
2077 * sol-thread.c (info_cb): Update.
2078 * stabsread.c (scan_file_globals): Update.
2079 * stack.c (find_frame_funname): Update.
2080 (info_frame_command_core): Update.
2081 * symmisc.c (dump_msymbols): Update.
2082 * symtab.c (symbol_natural_name): Rename to..,
2083 (general_symbol_info::natural_name): ...this.
2084 (symbol_demangled_name): Rename to...
2085 (general_symbol_info::demangled_name): ...this.
2086 (symbol_search_name): Rename to...
2087 (general_symbol_info::search_name): ...this.
2088 (symbol_matches_search_name): Update.
2089 (find_pc_sect_line): Update.
2090 (skip_prologue_sal): Update.
2091 (search_symbols): Update.
2092 (print_msymbol_info): Update.
2093 (rbreak_command): Update.
2094 (completion_list_add_msymbol): Update.
2095 (completion_list_objc_symbol): Update.
2096 (get_msymbol_address): Update.
2097 * symtab.h (struct general_symbol_info): Add member functions
2098 natural_name (), linkage_name (), print_name (), demangled_name (),
2100 (SYMBOL_NATURAL_NAME): Update.
2101 (symbol_natural_name): Move to a member function on general_symbol_info.
2102 (SYMBOL_DEMANGLED_NAME): Update.
2103 (symbol_demangled_name): Move to a member function on
2104 general_symbol_info.
2105 (SYMBOL_SEARCH_NAME): Update.
2106 (symbol_search_name): Move to a member function on general_symbol_info.
2107 (MSYMBOL_NATURAL_NAME): Remove.
2108 (MSYMBOL_LINKAGE_NAME): Remove.
2109 (MSYMBOL_PRINT_NAME): Remove.
2110 (MSYMBOL_DEMANGLED_NAME): Remove.
2111 (MSYMBOL_SEARCH_NAME): Remove.
2112 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2114 2019-11-22 Christian Biesinger <cbiesinger@google.com>
2116 * symtab.c (create_demangled_names_hash): Use per_bfd->
2117 minimal_symbol_count for computing the initial size, if greater
2118 than our default size.
2120 2019-11-22 Tom de Vries <tdevries@suse.de>
2122 * contrib/words.sh: Improve words extraction.
2124 2019-11-22 Tom de Vries <tdevries@suse.de>
2126 * contrib/words.sh: Combine sed invocations.
2128 2019-11-21 Christian Biesinger <cbiesinger@google.com>
2130 * Makefile.in: Update.
2131 * demangle.c: Rename to...
2132 * gdb-demangle.c: ..this.
2133 (is_cplus_marker): Change return type to bool.
2134 (_initialize_demangler): Rename to...
2135 (_initialize_gdb_demangle): ...this.
2136 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2137 * symtab.h (demangle): Remove declaration; instead include
2140 2019-11-21 Tom Tromey <tromey@adacore.com>
2142 * gdbsupport/format.c (format_pieces): Parse %I64d.
2143 * unittests/format_pieces-selftests.c (test_windows_formats): New
2145 (run_tests): Call it.
2147 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
2149 Byte reverse display of variables with DW_END_big, DW_END_little
2150 (DW_AT_endianity) dwarf attributes if different than the native
2152 * ada-lang.c (ada_value_binop):
2153 Use type_byte_order instead of gdbarch_byte_order.
2154 * ada-valprint.c (printstr):
2155 (ada_val_print_string):
2156 * ada-lang.c (value_pointer):
2158 Use type_byte_order instead of gdbarch_byte_order.
2159 * c-lang.c (c_get_string):
2160 Use type_byte_order instead of gdbarch_byte_order.
2161 * c-valprint.c (c_val_print_array):
2162 Use type_byte_order instead of gdbarch_byte_order.
2163 * cp-valprint.c (cp_print_class_member):
2164 Use type_byte_order instead of gdbarch_byte_order.
2165 * dwarf2loc.c (rw_pieced_value):
2166 Use type_byte_order instead of gdbarch_byte_order.
2167 * dwarf2read.c (read_base_type): Handle DW_END_big,
2169 * f-lang.c (f_get_encoding):
2170 Use type_byte_order instead of gdbarch_byte_order.
2171 * findvar.c (default_read_var_value):
2172 Use type_byte_order instead of gdbarch_byte_order.
2173 * gdbtypes.c (check_types_equal):
2174 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2175 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2176 and TYPE_ENDIANITY_LITTLE if set.
2177 (type_byte_order): new function.
2178 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2179 (struct main_type) <flag_endianity_not_default>:
2181 (type_byte_order): New function.
2182 * infcmd.c (default_print_one_register_info):
2183 Use type_byte_order instead of gdbarch_byte_order.
2184 * p-lang.c (pascal_printstr):
2185 Use type_byte_order instead of gdbarch_byte_order.
2186 * p-valprint.c (pascal_val_print):
2187 Use type_byte_order instead of gdbarch_byte_order.
2188 * printcmd.c (print_scalar_formatted):
2189 Use type_byte_order instead of gdbarch_byte_order.
2190 * solib-darwin.c (darwin_current_sos):
2191 Use type_byte_order instead of gdbarch_byte_order.
2192 * solib-svr4.c (solib_svr4_r_ldsomap):
2193 Use type_byte_order instead of gdbarch_byte_order.
2194 * stap-probe.c (stap_modify_semaphore):
2195 Use type_byte_order instead of gdbarch_byte_order.
2196 * target-float.c (target_float_same_format_p):
2197 Use type_byte_order instead of gdbarch_byte_order.
2198 * valarith.c (scalar_binop):
2200 Use type_byte_order instead of gdbarch_byte_order.
2201 * valops.c (value_cast):
2202 Use type_byte_order instead of gdbarch_byte_order.
2203 * valprint.c (generic_emit_char):
2206 Use type_byte_order instead of gdbarch_byte_order.
2207 * value.c (unpack_long):
2208 (unpack_bits_as_long):
2209 (unpack_value_bitfield):
2212 (pack_unsigned_long):
2213 Use type_byte_order instead of gdbarch_byte_order.
2214 * findvar.c (unsigned_pointer_to_address):
2215 (signed_pointer_to_address):
2216 (unsigned_address_to_pointer):
2217 (address_to_signed_pointer):
2218 (default_read_var_value):
2219 (default_value_from_register):
2220 Use type_byte_order instead of gdbarch_byte_order.
2221 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2222 Use type_byte_order instead of gdbarch_byte_order.
2223 * riscv-tdep.c (riscv_print_one_register_info):
2224 Use type_byte_order instead of gdbarch_byte_order.
2226 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2228 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2229 (current_ui_gdb_stdin_ptr): Likewise.
2230 (current_ui_gdb_stderr_ptr): Likewise.
2231 (current_ui_gdb_stdlog_ptr): Likewise.
2232 (current_ui_current_uiout_ptr): Likewise.
2233 (gen_ret_current_ui_field_ptr): Remove.
2235 2019-11-21 Tom de Vries <tdevries@suse.de>
2238 * cli/cli-script.c (execute_control_command): Only switch to
2239 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2241 2019-11-19 Tom Tromey <tom@tromey.com>
2243 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2244 Now static. Change type of "name".
2245 (tui_set_win_height_command): Don't copy "arg".
2246 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2247 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2249 2019-11-19 Ali Tamur <tamur@google.com>
2251 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2252 "if (attr != nullptr)".
2253 (dwarf2_find_base_address): Likewise.
2254 (dwarf2_build_include_psymtabs): Likewise.
2255 (read_cutu_die_from_dwo): Likewise.
2256 (read_func_scope): Likewise.
2257 (read_call_site_scope): Likewise.
2258 (dwarf2_get_pc_bounds): Likewise.
2259 (dwarf2_record_block_ranges): Likewise.
2260 (dwarf2_add_field): Likewise.
2261 (dwarf2_add_member_fn): Likewise.
2262 (read_structure_type): Likewise.
2263 (read_enumeration_type): Likewise.
2264 (read_array_type): Likewise.
2265 (read_array_order): Likewise.
2266 (read_set_type): Likewise.
2267 (read_common_block): Likewise.
2268 (read_tag_reference_type): Likewise.
2269 (read_tag_string_type): Likewise.
2270 (read_subroutine_type): Likewise.
2271 (read_base_type): Likewise.
2272 (read_subrange_type): Likewise.
2273 (new_symbol): Likewise.
2274 (prepare_one_comp_unit): Likewise.
2276 2019-11-19 Tom Tromey <tromey@adacore.com>
2278 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2279 result in error when DebugActiveProcess fails.
2281 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2282 Pedro Alves <palves@redhat.com>
2284 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2285 * target.c (target_stack::push): Call 'unpush' if there's a
2286 target on top of the stack.
2288 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2290 * python/py-block.c (blpy_dealloc): Call tp_free.
2291 (blpy_block_syms_dealloc): Likewise.
2292 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2293 * python/py-inferior.c (infpy_dealloc): Likewise.
2294 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2295 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2296 * python/py-symbol.c (sympy_dealloc): Likewise.
2297 * python/py-symtab.c (stpy_dealloc): Likewise.
2298 * python/py-type.c (typy_iterator_dealloc): Likewise.
2300 2019-11-18 Christian Biesinger <cbiesinger@google.com>
2302 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2303 constructor instead of using a class initializer.
2305 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2307 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2308 * configure: Regenerate.
2309 * configure.ac: Don't source common.host.
2310 * gdbsupport/common.host: Remove.
2311 * gdbsupport/mingw-strerror.c: Remove.
2312 * gdbsupport/posix-strerror.c: Rename to...
2313 * gdbsupport/safe-strerror.c: ...this.
2315 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2317 * maint.c (scoped_command_stats::print_time): Use localtime_r
2318 instead of localtime (provided through gnulib if necessary).
2319 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2322 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2324 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2325 avoid compile errors.
2327 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2329 * config.in: Regenerate.
2330 * configure: Regenerate.
2331 * gdbsupport/common.m4: No longer check for strerror_r.
2332 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2333 POSIX version of strerror_r, now that gnulib provides it if
2336 2019-11-14 Christian Biesinger <cbiesinger@google.com>
2338 * README (`configure' options): Update.
2340 2019-11-14 Tom Tromey <tromey@adacore.com>
2342 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2343 expected type for the RHS if the LHS is a convenience variable.
2345 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2347 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2348 Provide explicit default and copy constructor.
2350 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2352 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2353 only call Py_INCREF (newbp) in the bppy_pending_object case.
2355 2019-11-13 Tom Tromey <tromey@adacore.com>
2358 * psympriv.h (partial_symbol): Remove static assert.
2359 * symtab.h (general_symbol_info, symbol): Remove static assert.
2361 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2363 * gdbsupport/format.c (format_pieces::format_pieces): Support
2364 printf 'z' size modifier.
2365 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2366 * printcmd.c (ui_printf): Handle size_t_arg.
2367 * ui-out.c (ui_out::vmessage): Likewise.
2368 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2370 (run_tests): Call test_format_int_sizes.
2372 2019-11-12 Christian Biesinger <cbiesinger@google.com>
2374 * ada-exp.y (write_ambiguous_var): Update.
2375 * buildsym.c (add_symbol_to_list): Update.
2376 * dwarf2read.c (read_variable): Update.
2377 (new_symbol): Update.
2378 * jit.c (finalize_symtab): Update.
2379 * language.c (language_alloc_type_symbol): Update.
2380 * symtab.c (fixup_symbol_section): Update.
2381 (initialize_objfile_symbol_1): Move code to...
2382 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2383 (allocate_symbol): Update.
2384 (allocate_template_symbol): Update.
2385 (get_symbol_address): Update.
2386 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2387 of having as a field, and add a constructor.
2388 (SYMBOL_VALUE): Update.
2389 (SYMBOL_VALUE_ADDRESS): Update.
2390 (SET_SYMBOL_VALUE_ADDRESS): Update.
2391 (SYMBOL_VALUE_BYTES): Update.
2392 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2393 (SYMBOL_BLOCK_VALUE): Update.
2394 (SYMBOL_VALUE_CHAIN): Update.
2395 (SYMBOL_LANGUAGE): Update.
2396 (SYMBOL_SECTION): Update.
2397 (SYMBOL_OBJ_SECTION): Update.
2398 (SYMBOL_SET_LANGUAGE): Update.
2399 (SYMBOL_SET_LINKAGE_NAME): Update.
2400 (SYMBOL_SET_NAMES): Update.
2401 (SYMBOL_NATURAL_NAME): Update.
2402 (SYMBOL_LINKAGE_NAME): Update.
2403 (SYMBOL_DEMANGLED_NAME): Update.
2404 (SYMBOL_SEARCH_NAME): Update.
2405 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2406 (struct symbol): Update.
2407 (struct template_symbol): Update.
2408 (struct rust_vtable_symbol): Update.
2409 * xcoffread.c (SYMBOL_DUP): Update.
2411 2019-11-12 Tom Tromey <tom@tromey.com>
2413 * tui/tui-layout.c (show_layout): Set current_layout.
2414 (show_source_disasm_command, show_data)
2415 (show_source_or_disasm_and_command): Don't set current_layout.
2417 2019-11-12 Tom Tromey <tom@tromey.com>
2419 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2421 2019-11-12 Tom Tromey <tom@tromey.com>
2423 * tui/tui-win.c (resize_message): New global.
2424 (show_tui_resize_message): New function.
2425 (tui_async_resize_screen): Print message if requested.
2426 (_initialize_tui_win): Add tui-resize-message setting.
2427 * NEWS: Add entry for new commands.
2429 2019-11-11 Tom Tromey <tom@tromey.com>
2431 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2434 2019-11-11 Christian Biesinger <cbiesinger@google.com>
2436 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2438 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2440 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2442 * python/python-internal.h (gdbpy_lookup_static_symbols):
2443 Declare new function.
2444 * python/python.c (python_GdbMethods): Add
2445 gdb.lookup_static_symbols method.
2446 * NEWS: Mention gdb.lookup_static_symbols.
2448 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2450 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2451 static block of current object file first. Also fix typo in
2454 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2456 * stack.c (set_last_displayed_sal): Delete.
2457 (last_displayed_sal_valid): Delete.
2458 (last_displayed_pspace): Delete.
2459 (last_displayed_addr): Delete.
2460 (last_displayed_symtab): Delete.
2461 (last_displayed_line): Delete.
2462 (class last_displayed_symtab_info_type): New.
2463 (last_displayed_symtab_info): New static global variable.
2464 (print_frame_info): Call methods on last_displayed_symtab_info.
2465 (clear_last_displayed_sal): Update header comment, and make use of
2466 last_displayed_symtab_info.
2467 (last_displayed_sal_is_valid): Likewise.
2468 (get_last_displayed_pspace): Likewise.
2469 (get_last_displayed_addr): Likewise.
2470 (get_last_displayed_symtab): Likewise.
2471 (get_last_displayed_line): Likewise.
2472 (get_last_displayed_sal): Likewise.
2473 * stack.h (clear_last_displayed_sal): Update header comment.
2474 (last_displayed_sal_is_valid): Likewise.
2475 (get_last_displayed_pspace): Likewise.
2476 (get_last_displayed_addr): Likewise.
2477 (get_last_displayed_symtab): Likewise.
2478 (get_last_displayed_line): Likewise.
2479 (get_last_displayed_sal): Likewise.
2481 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2483 * stack.c (frame_show_address): Convert return type to bool.
2484 * stack.h (frame_show_address): Likewise, and update header
2487 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2489 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2490 * unittests/vec-utils-selftests.c: New file.
2491 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2493 2019-11-10 Tom Tromey <tom@tromey.com>
2495 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2496 (tui_highlight_win): Likewise.
2497 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2498 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2499 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2500 Don't set can_highlight.
2502 2019-11-10 Tom Tromey <tom@tromey.com>
2504 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2505 Remove unused declaration.
2507 2019-11-08 Tom Tromey <tromey@adacore.com>
2509 * top.c (read_command_file): Update.
2510 (command_line_input): Make return type const.
2511 * python/py-gdb-readline.c: Update.
2512 * linespec.c (decode_line_2): Update.
2513 * defs.h (command_line_input): Make return type const.
2514 * cli/cli-script.c (read_next_line): Make return type const.
2515 * ada-lang.c (get_selections): Update.
2517 2019-11-06 Christian Biesinger <cbiesinger@google.com>
2519 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2520 * mi/mi-main.c (output_cores): Likewise.
2521 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2522 (linux_xfer_osdata_modules): Likewise.
2523 * remote.c (register_remote_support_xml): Likewise.
2524 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2525 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2527 2019-11-06 Tom Tromey <tom@tromey.com>
2529 * tui/tui-interp.c: Don't include readline.h.
2530 * tui/tui-hooks.c: Don't include readline.h.
2531 * symmisc.c: Include tilde.h, not readline.h.
2532 * symfile.c: Include tilde.h, not readline.h.
2533 * source.c: Include tilde.h, not readline.h.
2534 * solib.c: Include tilde.h, not readline.h.
2535 * psymtab.c: Include tilde.h, not readline.h.
2536 * exec.c: Include tilde.h, not readline.h.
2537 * corelow.c: Include tilde.h, not readline.h.
2538 * cli/cli-dump.c: Include tilde.h, not readline.h.
2539 * cli/cli-cmds.c: Don't include readline.h.
2541 2019-11-05 Tom Tromey <tom@tromey.com>
2543 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2544 (tui_disassemble): Set addr_size.
2545 (tui_disasm_window::set_contents): Use addr_size.
2547 2019-11-05 Tom Tromey <tom@tromey.com>
2549 * rust-lang.c (rust_language_defn): Update.
2550 * python/py-value.c (valpy_string): Call c_get_string.
2551 * p-lang.c (pascal_language_defn): Update.
2552 * opencl-lang.c (opencl_language_defn): Update.
2553 * objc-lang.c (objc_language_defn): Update.
2554 * m2-lang.c (m2_language_defn): Update.
2555 * language.c (unknown_language_defn, auto_language_defn): Update.
2556 (default_get_string): Remove.
2557 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2558 * go-lang.c (go_language_defn): Update.
2559 * f-lang.c (f_language_defn): Update.
2560 * d-lang.c (d_language_defn): Update.
2561 * c-lang.c (c_language_defn, cplus_language_defn)
2562 (asm_language_defn, minimal_language_defn): Update.
2563 * ada-lang.c (ada_language_defn): Update.
2564 * language.h (struct language_defn) <la_get_string>: Remove.
2565 (LA_GET_STRING): Remove.
2566 (default_get_string): Don't declare.
2568 2019-11-05 Tom Tromey <tom@tromey.com>
2570 * tui/tui-source.h (struct tui_source_window): Inline
2571 constructor. Remove destructor.
2572 <style_changed, m_observable>: Move to superclass.
2573 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2574 (struct tui_source_window_base): Move private members to end.
2575 <style_changed, m_observable>: Move from tui_source_window.
2576 * tui/tui-winsource.c (tui_copy_source_line): Move from
2577 tui-source.c. Rename from copy_source_line. Add special handling
2578 for negative line number.
2579 (tui_source_window_base::style_changed): Move from
2581 (tui_source_window_base): Register observer.
2582 (~tui_source_window_base): New.
2583 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2585 (tui_source_window::set_contents): Use tui_copy_source_line.
2586 (tui_source_window::tui_source_window): Move to tui-source.h.
2587 (tui_source_window::~tui_source_window): Remove.
2588 (tui_source_window::style_changed): Move to superclass.
2589 * tui/tui-disasm.c (tui_disassemble): Create string file with
2590 styling, when possible. Add "addr_size" parameter.
2591 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2592 Don't compute maximum size.
2593 (len_without_escapes): New function
2595 2019-11-05 Tom Tromey <tom@tromey.com>
2597 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2599 * tui/tui-winsource.c (tui_show_source_line): Update.
2600 * tui/tui-source.c (tui_source_window::set_contents): Update.
2601 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2603 2019-11-05 Christian Biesinger <cbiesinger@google.com>
2605 * symtab.h (gdb_static_assert): Put && operator at the beginning
2606 of the line instead of the end.
2608 2019-11-04 Christian Biesinger <cbiesinger@google.com>
2610 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2611 and sizeof (symbol).
2612 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2614 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2616 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2617 * configure.host: Mark *-*-solaris2.10* obsolete.
2618 * configure.tgt: Mark Solaris < 11 obsolete.
2619 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2620 Update target triplet.
2622 2019-11-01 Tom Tromey <tromey@adacore.com>
2624 * utils.c (print_sys_errmsg): Simplify.
2626 2019-11-01 Tom Tromey <tromey@adacore.com>
2628 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2630 2019-11-01 Christian Biesinger <cbiesinger@google.com>
2632 * configure: Regenerate.
2633 * configure.ac: Remove check for strerror_r.
2634 * gdbsupport/common.m4: Check for strerror_r.
2636 2019-11-01 Luis Machado <luis.machado@linaro.org>
2640 * arm-tdep.c (arm_per_objfile): Rename to ...
2641 (arm_per_bfd): ... this.
2642 (arm_objfile_data_key): Rename to ...
2643 (arm_bfd_data_key): ... this.
2644 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2646 (arm_record_special_symbol): Likewise.
2648 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2650 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2652 * c-typeprint.c (c_print_typedef): Likewise.
2653 * f-typeprint.c (f_print_typedef): Likewise.
2654 * m2-typeprint.c (m2_print_typedef): Likewise.
2655 * p-typeprint.c (pascal_print_typedef): Likewise.
2656 * rust-lang.c (rust_print_typedef): Likewise.
2657 * symtab.c (print_symbol_info): Print a newline after calling
2660 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2662 * symtab.c (info_module_cmdlist): New variable.
2663 (info_module_command): New function.
2664 (search_module_symbols): New function.
2665 (info_module_subcommand): New function.
2666 (struct info_modules_var_func_options): New struct.
2667 (info_modules_var_func_options_defs): New variable.
2668 (make_info_modules_var_func_options_def_group): New function.
2669 (info_module_functions_command): New function.
2670 (info_module_variables_command): New function.
2671 (info_module_var_func_command_completer): New function.
2672 (_initialize_symtab): Register new 'info module functions' and
2673 'info module variables' commands.
2674 * symtab.h (typedef symbol_search_in_module): New typedef.
2675 (search_module_symbols): Declare new function.
2676 * NEWS: Mention new commands.
2678 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2680 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2681 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2682 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2684 (scan_partial_symbols): Only create partial module symbols for non
2686 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2688 * symtab.c (search_domain_name): Likewise.
2689 (search_symbols): Likewise.
2690 (print_symbol_info): Likewise.
2691 (symtab_symbol_info): Likewise.
2692 (info_modules_command): New function.
2693 (_initialize_symtab): Register 'info modules' command.
2694 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2695 * NEWS: Mention new 'info modules' command.
2697 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2699 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2700 and $_gdb_maint_setting_str.
2702 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2704 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2705 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2706 (str_value_from_setting, gdb_setting_str_internal_fn)
2707 (gdb_maint_setting_str_internal_fn): New functions.
2708 (_initialize_cli_cmds): Define the new convenience functions.
2709 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2710 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2712 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2714 * agent.c (set_can_use_agent): When the setting is turned on,
2715 look up agent symbols if we don't have them yet.
2716 (agent_new_objfile): Don't look up agent symbols when the agent
2719 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2721 * config.in: Regenerate.
2723 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2725 * configure: Regenerate.
2726 * configure.ac: Check for strerror_r.
2727 * gdbsupport/common-utils.h (safe_strerror): Change return value
2728 to const char * and document that this function is now threadsafe.
2729 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2730 thread_local and call strerror_r, if available.
2731 * utils.c (perror_string): Update.
2732 (print_sys_errmsg): Update.
2734 2019-10-31 Luis Machado <luis.machado@linaro.org>
2736 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2738 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2739 objfile to fetch per-bfd data.
2740 (arm_find_exidx_entry): Likewise.
2742 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2744 * gdbsupport/agent.c (debug_agent): Change type to bool.
2745 (use_agent): Likewise.
2746 (all_agent_symbols_look_up): Likewise.
2747 (agent_loaded_p): Change return value to bool.
2748 (agent_look_up_symbols): Update.
2749 (agent_capability_check): Change return value to bool.
2750 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2751 (debug_agent): Change type to bool.
2752 (use_agent): Likewise.
2753 (agent_capability_check): Change return value to bool.
2755 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2757 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2758 (build_minimal_symbol_hash_tables): Code to clear the table moved
2759 to clear_minimal_symbol_hash_tables.
2760 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2763 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2765 * infcmd.c: Remove includes.
2766 * infrun.c: Remove includes.
2768 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2770 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2771 (grow_vect): Remove declaration.
2772 (ada_type_of_array): Remove declaration.
2773 (ada_update_initial_language): Remove declaration.
2774 (ada_fold_name): Remove declaration.
2775 (ada_fill_in_ada_prototype): Remove declaration.
2776 (user_select_syms): Remove declaration.
2777 (get_selections): Remove declaration.
2778 (ada_tag_type): Remove declaration.
2779 (ada_value_tag): Remove declaration.
2780 (ada_is_others_clause): Remove declaration.
2781 (ada_in_variant): Remove declaration.
2782 (ada_value_struct_elt): Remove declaration.
2783 (ada_attribute_name): Remove declaration.
2784 (ada_system_address_type): Remove declaration.
2785 * ada-lang.c (ada_watch_location_expression): Make static.
2786 (GROW_VECT): Move here from ada-lang.h.
2787 (grow_vect): Make static.
2788 (ada_update_initial_language): Make static.
2789 (ada_fold_name): Make static.
2790 (ada_type_of_array): Make static.
2791 (encoded_ordered_before): Move up.
2792 (sort_choices): Move up.
2793 (print_signatures): Move up.
2794 (ada_print_symbol_signature): Move up.
2795 (get_selections): Move up and make static.
2796 (user_select_syms): Move up and make static.
2797 (ada_value_struct_elt): Move up and make static.
2798 (ada_tag_type): Make static.
2799 (ada_value_tag): Make static.
2800 (ada_is_others_clause): Make static.
2801 (ada_in_variant): Make static.
2802 (ada_attribute_name): Make static.
2804 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2806 * ada-lang.c: Remove includes.
2807 * ada-typeprint.c: Remove includes.
2808 * ada-valprint.c: Remove includes.
2810 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2812 * addrmap.c: Add static assertions of type size, moved from
2813 _initialize_addrmap.
2814 (_initialize_addrmap): Remove.
2816 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2818 * coffread.c (record_minimal_symbol): Update.
2819 (process_coff_symbol): Update.
2820 * dbxread.c (read_dbx_symtab): Update.
2821 * dwarf2read.c (add_partial_symbol): Update.
2822 (fixup_go_packaging): Update.
2823 (load_partial_dies): Update.
2824 (new_symbol): Update.
2825 * elfread.c (record_minimal_symbol): Change signature to use
2826 gdb::string_view instead of name+len.
2827 (elf_symtab_read): Update.
2828 (elf_rel_plt_read): Update.
2829 * mdebugread.c (parse_partial_symbols): Update.
2830 (handle_psymbol_enumerators): Update.
2831 (new_symbol): Update.
2832 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2833 to use gdb::string_view instead of name+len.
2834 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2835 * psympriv.h (add_psymbol_to_list): Likewise.
2836 * psymtab.c (add_psymbol_to_bcache): Likewise.
2837 (add_psymbol_to_list): Likewise.
2838 * stabsread.c (define_symbol): Update.
2839 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2840 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2841 (symbol_set_names): Likewise.
2842 * xcoffread.c (scan_xcoff_symtab): Update.
2844 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2846 * symtab.h (symbol_set_names): Document that copy_name must be
2847 set to true for non-nullterminated strings.
2848 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2849 linkage_name if the entry was not found and we need to demangle.
2851 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2853 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2854 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2855 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2856 * gdbsupport/gdb_binary_search.h: New file.
2858 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2860 * NEWS: Mention new --with-system-gdbinit-dir option.
2861 * config.in: Regenerate.
2862 * configure: Regenerate.
2863 * configure.ac: Add new option --with-system-gdbinit-dir.
2864 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2865 for a ".gdb" suffix.
2866 * main.c (get_init_files): Change system_gdbinit argument to
2867 a vector and return the files in SYSTEM_GDBINIT_DIR in
2868 addition to SYSTEM_GDBINIT.
2869 (captured_main_1): Update.
2870 (print_gdb_help): Update.
2871 * top.c (print_gdb_configuration): Also print the value of
2874 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2876 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2877 that takes gdb::string_view arguments.
2879 2019-10-26 Tom de Vries <tdevries@suse.de>
2881 * aarch64-linux-tdep.c: Fix typos in comments.
2882 * aarch64-tdep.c: Same.
2884 * amd64-nat.c: Same.
2886 * arch/aarch64-insn.c: Same.
2888 * breakpoint.h: Same.
2891 * cli/cli-decode.c: Same.
2892 * cli/cli-script.c: Same.
2893 * cli/cli-utils.h: Same.
2894 * coff-pe-read.c: Same.
2896 * compile/compile-cplus-symbols.c: Same.
2897 * compile/compile-object-run.c: Same.
2898 * completer.c: Same.
2900 * cp-support.c: Same.
2902 * dwarf-index-write.c: Same.
2903 * dwarf2-frame.c: Same.
2904 * dwarf2-frame.h: Same.
2906 * frame-base.h: Same.
2911 * guile/scm-objfile.c: Same.
2912 * i386-tdep.c: Same.
2913 * i386-tdep.h: Same.
2916 * linux-nat.c: Same.
2917 * m68k-tdep.c: Same.
2920 * mi/mi-cmd-disas.c: Same.
2921 * mi/mi-getopt.h: Same.
2922 * mi/mi-main.c: Same.
2924 * nat/aarch64-sve-linux-sigcontext.h: Same.
2926 * ppc-linux-nat.c: Same.
2927 * ppc-linux-tdep.c: Same.
2929 * progspace.h: Same.
2930 * prologue-value.h: Same.
2931 * python/py-evtregistry.c: Same.
2932 * python/py-instruction.h: Same.
2933 * record-btrace.c: Same.
2934 * record-full.c: Same.
2936 * rs6000-tdep.c: Same.
2938 * sol-thread.c: Same.
2939 * sparc-sol2-tdep.c: Same.
2940 * sparc64-tdep.c: Same.
2941 * stabsread.c: Same.
2945 * tracepoint.c: Same.
2946 * tui/tui-data.h: Same.
2947 * tui/tui-io.c: Same.
2948 * tui/tui-win.c: Same.
2950 * unittests/rsp-low-selftests.c: Same.
2951 * user-regs.h: Same.
2962 * xtensa-tdep.c: Same.
2964 2019-10-25 Ali Tamur <tamur@google.com>
2966 * charset.c (find_charset_names): Reflect API change.
2968 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2970 * symtab.c (struct demangled_name_entry): Change demangled name
2971 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2972 part of the struct anymore.
2973 (symbol_set_names): No longer obstack allocate + copy the demangled
2974 name, just store the allocated name from bfd.
2976 2019-10-25 Tom Tromey <tromey@adacore.com>
2978 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2979 (bsearch_cie_cmp, add_cie): Remove.
2980 (find_cie): Reimplement.
2981 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2982 (dwarf2_build_frame_info): Update.
2984 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2987 * symfile.c (reread_symbols): Call forget_cached_source_info to
2988 clear the stale source cache.
2990 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2992 * configure: Regenerate.
2993 * configure.ac: Remove code that sets python_has_threads.
2995 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2997 * config.in: Regenerate.
2998 * configure: Regenerate.
2999 * configure.ac: Remove the code that uses sed to get the python
3000 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
3002 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
3004 * python/py-progspace.c (pspy_block_for_pc): Return None for all
3007 2019-10-23 Tom Tromey <tom@tromey.com>
3009 * arc-tdep.c: Remove ".." from include.
3010 * frv-tdep.c: Remove ".." from include.
3011 * lm32-tdep.c: Remove ".." from include.
3012 * microblaze-tdep.c: Remove ".." from include.
3013 * or1k-tdep.h: Remove ".." from include.
3014 * s12z-tdep.c: Remove ".." from include.
3015 * Makefile.in (OPCODES_CFLAGS): Add comment.
3016 (TOP_CFLAGS): New variable.
3017 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
3019 2019-10-23 Tom Tromey <tom@tromey.com>
3021 * Makefile.in (READLINE_DIR): Update.
3023 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3025 * infcall.c (call_function_by_hand_dummy): Fix the function
3026 comment. And extract out a code section into...
3027 (reserve_stack_space): ...this new function.
3029 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3031 * infcall.c (value_arg_coerce): Remove an unused parameter.
3032 (call_function_by_hand_dummy): Update the call to
3035 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3037 * infcall.c (call_function_by_hand_dummy): Refactor.
3039 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3041 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3043 2019-10-23 Tom Tromey <tom@tromey.com>
3045 * configure: Rebuild.
3046 * configure.ac: Don't check for sigprocmask.
3047 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3049 2019-10-23 Tom Tromey <tom@tromey.com>
3051 * configure: Rebuild.
3052 * acinclude.m4: Use m4_include, not sinclude.
3054 2019-10-23 Tom de Vries <tdevries@suse.de>
3056 PR breakpoints/24687
3057 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3059 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3061 * symtab.c (struct demangled_name_entry) <language>: Change from
3062 bitfield to regular variable.
3064 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3066 * symtab.c (struct demangled_name_entry): Add a constructor.
3067 (free_demangled_name_entry): New function to call the destructor
3068 for demangled_name_entry.
3069 (create_demangled_names_hash): Pass free_demangled_name_entry to
3071 (symbol_set_names): Call placement new for demangled_name_entry.
3072 * utils.c: No longer include xxhash.h here, now that fast_hash
3073 is inlined in the header.
3074 * utils.h: Instead, include it here.
3076 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3078 * Makefile.in: Link with libxxhash.
3079 * config.in: Regenerate.
3080 * configure: Regenerate.
3081 * configure.ac: Search for libxxhash.
3082 * utils.c (fast_hash): Use xxhash if present.
3084 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3086 * utils.h (fast_hash): New function.
3087 * symtab.c (hash_demangled_name_entry): Call new function
3090 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3092 * symtab.c (struct demangled_name_entry): Change type of mangled
3093 to gdb::string_view. Also adds a constructor that takes the
3095 (hash_demangled_name_entry): Update.
3096 (eq_demangled_name_entry): Update.
3097 (free_demangled_name_entry): New function to call the destructor
3098 now that this is not a POD anymore.
3099 (create_demangled_names_hash): Pass free_demangled_name_entry to
3101 (symbol_set_names): Update.
3103 2019-10-21 Ali Tamur <tamu@google.com>
3105 * dwarf2read.c (dir_index): Change type.
3106 (file_name_index): Likewise.
3107 (line_header::include_dir_at): Change comment and implementation on
3108 whether it is DWARF 5.
3109 (line_header::is_valid_file_index): New function.
3110 (line_header::file_name_at): Change comment and implementation on
3111 whether it is DWARF 5.
3112 (line_header::file_names): Change to private field renamed as
3113 m_file_names and introduce a new accessor method.
3114 (line_header::file_names_size): New method.
3115 (line_header::include_dirs): Change to private field and rename as
3117 (dw2_get_file_names_reader): Define local var at a smaller scope and
3119 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3120 (process_structure_scope): Likewise.
3121 (line_header::add_include_dir): Change message and reflect renaming.
3122 (line_header::add_file_name): Likewise.
3123 (read_formatted_entries): Handle DW_FORM_data16.
3124 (dwarf_decode_line_header): Fix line header length calculation.
3125 (psymtab_include_file_name): Change comment and API.
3126 (lnp_state_machine::m_file): Update comment and reflect type change.
3127 (lnp_state_machine::record_line): Reflect type change.
3128 (dwarf_decode_lines): Reflect API change.
3129 (file_file_name): Likewise.
3130 (file_full_name): Likewise.
3132 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
3134 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3136 2019-10-21 Tom Tromey <tom@tromey.com>
3138 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3140 2019-10-21 Tom Tromey <tom@tromey.com>
3142 * configure.ac (nm.h): Conditionally create nm.h link. Subst
3143 NM_H. Use AC_CONFIG_LINKS.
3144 * configure: Rebuild.
3145 * Makefile.in (NM_H): New variable.
3146 (generated_files): Add NM_H. Remove gcore.
3147 (nm.h, stamp-nmh): New targets.
3149 2019-10-20 Tom Tromey <tom@tromey.com>
3151 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3152 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
3154 (put_objfile_before): Now static.
3156 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3158 * gdbsupport/common-utils.h (startswith): Change return type to
3161 2019-10-19 Christian Biesinger <cbiesinger@google.com>
3163 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3164 * breakpoint.c (bp_locations_compare): Rename to...
3165 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3166 (update_global_location_list): Use std::sort instead of qsort.
3167 * buildsym.c (compare_line_numbers): Rename to...
3168 (lte_is_less_than): ...this, and change to std::sort semantics.
3169 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3171 * disasm.c (compare_lines): Rename to...
3172 (line_is_less_than): ...this, and change to std::sort semantics.
3173 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3175 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3176 (fde_is_less_than): ...this, and change to std::sort semantics.
3177 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3178 * mdebugread.c (compare_blocks):
3179 (block_is_less_than): ...this, and change to std::sort semantics.
3180 (sort_blocks): Call std::sort instead of qsort.
3181 * objfiles.c (qsort_cmp): Rename to...
3182 (sort_cmp): ...this, and change to std::sort semantics.
3183 (update_section_map): Call std::sort instead of qsort.
3184 * remote.c (compare_pnums): Remove.
3185 (map_regcache_remote_table): Call std::sort instead of qsort.
3186 * utils.c (compare_positive_ints): Remove.
3187 * utils.h (compare_positive_ints): Remove.
3188 * xcoffread.c (compare_lte): Remove.
3189 (arrange_linetable): Call std::sort instead of qsort.
3191 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3193 * symfile.c (init_entry_point_info): Fix typo.
3194 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3196 2019-10-18 Tom de Vries <tdevries@suse.de>
3198 * aarch64-tdep.c: Fix typos in comments.
3200 * ada-tasks.c: Same.
3201 * alpha-tdep.c: Same.
3202 * alpha-tdep.h: Same.
3203 * amd64-nat.c: Same.
3204 * amd64-windows-tdep.c: Same.
3207 * arch-utils.c: Same.
3208 * arm-nbsd-tdep.c: Same.
3211 * blockframe.c: Same.
3214 * coff-pe-read.c: Same.
3216 * cris-tdep.c: Same.
3217 * darwin-nat.c: Same.
3221 * dtrace-probe.c: Same.
3222 * dwarf-index-write.c: Same.
3223 * dwarf2-frame-tailcall.c: Same.
3224 * dwarf2-frame.c: Same.
3225 * dwarf2read.c: Same.
3227 * exceptions.c: Same.
3228 * fbsd-tdep.c: Same.
3232 * gnu-v3-abi.c: Same.
3234 * h8300-tdep.c: Same.
3235 * hppa-tdep.c: Same.
3236 * i386-linux-tdep.c: Same.
3237 * i386-tdep.c: Same.
3238 * ia64-libunwind-tdep.c: Same.
3239 * ia64-tdep.c: Same.
3243 * linux-nat.c: Same.
3244 * linux-thread-db.c: Same.
3245 * machoread.c: Same.
3246 * mdebugread.c: Same.
3248 * mn10300-tdep.c: Same.
3249 * namespace.c: Same.
3251 * opencl-lang.c: Same.
3252 * or1k-tdep.c: Same.
3254 * ppc-linux-nat.c: Same.
3255 * ppc-linux-tdep.c: Same.
3256 * ppc-sysv-tdep.c: Same.
3259 * record-btrace.c: Same.
3260 * record-full.c: Same.
3261 * remote-fileio.c: Same.
3263 * rs6000-tdep.c: Same.
3264 * s12z-tdep.c: Same.
3265 * score-tdep.c: Same.
3269 * sol-thread.c: Same.
3270 * solib-svr4.c: Same.
3273 * sparc-nat.c: Same.
3274 * sparc-sol2-tdep.c: Same.
3275 * sparc-tdep.c: Same.
3276 * sparc64-tdep.c: Same.
3277 * stabsread.c: Same.
3281 * target-descriptions.c: Same.
3282 * target-float.c: Same.
3289 * windows-nat.c: Same.
3290 * xcoffread.c: Same.
3291 * xstormy16-tdep.c: Same.
3292 * xtensa-tdep.c: Same.
3294 2019-10-17 Tom Tromey <tromey@adacore.com>
3296 * configure: Rebuild.
3297 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3298 in AC_CONFIG_FILES invocation.
3299 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3300 new-style config.status invocation.
3302 2019-10-17 Tom de Vries <tdevries@suse.de>
3304 * arm-nbsd-nat.c: Fix typos in comments.
3306 * darwin-nat-info.c: Same.
3307 * dwarf2read.c: Same.
3309 * event-top.c: Same.
3312 * hppa-tdep.c: Same.
3313 * i386-tdep.c: Same.
3316 * mdebugread.c: Same.
3317 * moxie-tdep.c: Same.
3318 * nto-procfs.c: Same.
3320 * ppc-linux-tdep.c: Same.
3322 * riscv-tdep.c: Same.
3323 * s390-tdep.c: Same.
3325 * sparc-linux-tdep.c: Same.
3326 * sparc-nat.c: Same.
3328 * target-descriptions.c: Same.
3332 2019-10-16 Tom Tromey <tom@tromey.com>
3334 * objfiles.h (struct objfile) <original_name>: Now const.
3336 2019-10-16 Christian Biesinger <cbiesinger@google.com>
3338 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3339 pass on to sigsetjmp's second argument.
3340 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3342 2019-10-16 Keith Seitz <keiths@redhat.com>
3345 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3346 sections whose size is greater than the file size.
3348 2019-10-16 Jim Wilson <jimw@sifive.com>
3350 * riscv-tdep.c (riscv_gcc_target_options): New.
3351 (riscv_gnu_triplet_regexp): New.
3352 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3353 set_gdbarch_gnu_triplet_regexp.
3355 2019-10-16 Christian Biesinger <cbiesinger@google.com>
3357 * Makefile.in: Add xml-builtin.h.
3358 * features/feature_to_c.sh: Add an include for xml-builtin.h
3359 to ensure that the compiler checks that the types match.
3360 * xml-builtin.h: New file.
3361 * xml-support.c (fetch_xml_builtin): Add missing const.
3362 * xml-support.h: Remove declaration of xml_builtins.
3364 2019-10-16 Tom de Vries <tdevries@suse.de>
3367 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3368 (amd64_classify_aggregate): ... here.
3369 (amd64_classify_aggregate_field): Handled fiels of nested structs
3372 2019-10-16 Tom de Vries <tdevries@suse.de>
3375 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3376 that handles 'theclass'.
3378 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3380 * linespec.c (decode_digits_ordinary): Update comment.
3381 * make-target-delegates: No longer need to handle VEC case.
3382 * memrange.c (normalize_mem_ranges): Update comment.
3383 * namespace.c (add_using_directive): Update comment.
3384 * objc-lang.c (uniquify_strings): Update comment.
3385 * ppc-linux-nat.c (struct thread_points): Update comment.
3386 * probe.h (find_probes_in_objfile): Update comment.
3387 * target.h (enum flash_preserve_mode): Update comment.
3388 * varobj.c (varobj_restrict_range): Update comment.
3389 * varobj.h (varobj_list_children): Update comment.
3391 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3393 * Makefile.in: Remove references to vec.h and vec.c.
3394 * aarch64-tdep.c: No longer include vec.h.
3395 * ada-lang.c: Likewise.
3396 * ada-lang.h: Likewise.
3397 * arm-tdep.c: Likewise.
3399 * breakpoint.h: Likewise.
3400 * charset.c: Likewise.
3401 * cp-support.h: Likewise.
3402 * dtrace-probe.c: Likewise.
3403 * dwarf2read.c: Likewise.
3404 * extension.h: Likewise.
3405 * gdb_bfd.c: Likewise.
3406 * gdbsupport/gdb_vecs.h: Likewise.
3407 * gdbsupport/vec.c: Remove.
3408 * gdbsupport/vec.h: Remove.
3409 * gdbthread.h: Likewise.
3410 * guile/scm-type.c: Likewise.
3411 * inline-frame.c: Likewise.
3412 * machoread.c: Likewise.
3413 * memattr.c: Likewise.
3414 * memrange.h: Likewise.
3415 * namespace.h: Likewise.
3416 * nat/linux-btrace.h: Likewise.
3417 * osdata.c: Likewise.
3418 * parser-defs.h: Likewise.
3419 * progspace.h: Likewise.
3420 * python/py-type.c: Likewise.
3421 * record-btrace.c: Likewise.
3422 * rust-exp.y: Likewise.
3423 * solib-target.c: Likewise.
3424 * stap-probe.c: Likewise.
3425 * target-descriptions.c: Likewise.
3426 * target-memory.c: Likewise.
3427 * target.h: Likewise.
3428 * varobj.c: Likewise.
3429 * varobj.h: Likewise.
3430 * xml-support.h: Likewise.
3432 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3434 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3435 Update for new std::vector based implementation.
3436 (process_psymtab_comp_unit_reader): Likewise.
3437 (scan_partial_symbols): Likewise.
3438 (recursively_compute_inclusions): Likewise.
3439 (compute_compunit_symtab_includes): Likewise.
3440 (process_imported_unit_die): Likewise.
3441 (queue_and_load_dwo_tu): Likewise.
3442 (follow_die_sig_1): Likewise.
3443 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3444 (typedef dwarf2_per_cu_ptr): Remove.
3445 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3447 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3448 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3449 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3450 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3453 2019-10-15 Tom Tromey <tromey@adacore.com>
3455 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3458 2019-10-15 Tom Tromey <tromey@adacore.com>
3460 * windows-nat.c (windows_nat_target::fetch_registers)
3461 (windows_nat_target::store_registers): Rename "pid" to "tid".
3463 2019-10-15 Tom Tromey <tromey@adacore.com>
3465 * gdbarch.h, gdbarch.c: Rebuild.
3466 * gdbarch.sh (gcc_target_options): Change return type to
3468 * compile/compile.c (get_args): Update.
3469 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3470 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3472 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3474 * arch-utils.c (default_gcc_target_options): Return std::string.
3475 * arch-utils.h (default_gcc_target_options): Return std::string.
3476 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3478 2019-10-15 Christian Biesinger <cbiesinger@google.com>
3480 * breakpoint.c (breakpoint_chain): Make static.
3481 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3482 of accessing breakpoint_chain.
3484 2019-10-15 Christian Biesinger <cbiesinger@google.com>
3486 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3487 to a gdb::function_view and return value to bool.
3488 * breakpoint.h (iterate_over_breakpoints): Likewise.
3489 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3490 (pop_dummy_frame): Update.
3491 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3492 (gdbscm_breakpoints): Update.
3493 * python/py-breakpoint.c (build_bp_list): Update.
3494 (gdbpy_breakpoints): Update.
3495 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3497 (bpfinishpy_handle_stop): Update.
3498 (bpfinishpy_handle_exit): Update.
3499 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3500 (svr4_update_solib_event_breakpoints): Update.
3502 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3504 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3505 when unwrapping single-field structs.
3507 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3509 * dwarf2read.c: Remove includes.
3511 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3513 * ui-out.c (ui_out::call_do_message): Silence
3514 -Wformat-nonliteral warning.
3516 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3518 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3519 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3520 include: readline/tilde.h.
3522 2019-10-12 Christian Biesinger <cbiesinger@google.com>
3524 * remote.c (remote_target::get_trace_status): Remove declaration of
3525 trace_regblock_size.
3527 2019-10-12 Christian Biesinger <cbiesinger@google.com>
3529 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3530 (show_user): Remove declaration of cmdlist.
3531 * cli/cli-cmds.h (max_user_call_depth): Declare.
3532 * cli/cli-script.c (execute_user_command): Remove declaration
3533 of max_user_call_depth.
3535 2019-10-11 Jim Wilson <jimw@sifive.com>
3537 * gdbsupport/print-utils.h (pulongest): Fix comment.
3538 (plongest): Likewise.
3539 (phex): Add missing comment, mention leading zeros.
3540 (phex_nz): Add mention of no leading zeros to comment.
3542 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3543 plongest instead of unsigned long long cast.
3545 2019-10-10 Christian Biesinger <cbiesinger@google.com>
3547 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3548 for external_editor_command and gdbtk_test.
3550 2019-10-10 Christian Biesinger <cbiesinger@google.com>
3552 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3553 * varobj.c (varobjdebug): Move comment to...
3554 * varobj.h (varobjdebug): ...here, and declare.
3556 2019-10-09 Tom Tromey <tom@tromey.com>
3558 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3561 2019-10-09 Tom Tromey <tom@tromey.com>
3563 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3564 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3565 * tui/tui-command.c (tui_cmd_window::resize)
3566 (tui_refresh_cmd_win): Update.
3567 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3568 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3569 * tui/tui-data.c (~tui_gen_win_info): Remove.
3570 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3571 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3572 (tui_redisplay_readline, tui_mld_flush)
3573 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3574 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3575 (tui_data_window::erase_data_content)
3576 (tui_data_item_window::rerender)
3577 (tui_data_item_window::refresh_window): Update.
3578 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3579 (box_win, tui_gen_win_info::make_window)
3580 (tui_gen_win_info::make_visible): Update.
3581 (tui_delete_win): Remove.
3582 * tui/tui-winsource.c
3583 (tui_source_window_base::do_erase_source_content): Update.
3584 (tui_show_source_line, tui_source_window_base::update_tab_width)
3585 (tui_source_window_base::update_exec_info): Update.
3586 * tui/tui-data.h (struct curses_deleter): New.
3587 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3588 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3590 2019-10-09 Tom Tromey <tom@tromey.com>
3592 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3594 2019-10-09 Tom Tromey <tom@tromey.com>
3596 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3597 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3599 2019-10-09 Tom Tromey <tom@tromey.com>
3601 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3602 window height directly.
3603 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3605 * tui/tui-layout.c (tui_default_win_height): Remove.
3606 (tui_default_win_viewport_height): Remove.
3608 2019-10-09 Tom Tromey <tom@tromey.com>
3610 * tui/tui.h: Remove comments.
3612 2019-10-09 Tom de Vries <tdevries@suse.de>
3614 * python/lib/gdb/printer/bound_registers.py: Use
3615 '^builtin_type_bound128' as regexp argument for
3616 add_builtin_pretty_printer.
3618 2019-10-09 Christian Biesinger <cbiesinger@google.com>
3620 * guile/guile.c (guile_extension_script_ops): Remove forward
3621 declaration and mark as static.
3622 (guile_script_ops): Likewise.
3623 (extension_language_guile): Move further down in the file so
3624 it can reference the definitions for guile_{extension_,}script_ops.
3626 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3628 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3629 except SORTL, DFLTCC, and KDSA.
3631 2019-10-08 Tom Tromey <tromey@adacore.com>
3633 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3634 (struct safe_symbol_file_add_args): Remove.
3636 2019-10-08 Tom Tromey <tromey@adacore.com>
3638 * windows-nat.c: Don't include buildsym-legacy.h.
3640 2019-10-08 Tom Tromey <tromey@adacore.com>
3642 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3644 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3646 * gdbtypes.c (overload_debug): Move comment to header.
3647 * gdbtypes.h (overload_debug): Declare.
3648 * valops.c: Remove declaration of overload_debug, instead
3651 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3653 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3655 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3657 * language.h (lang_frame_mismatch_warn): ... here. Also add
3659 * top.c (lang_frame_mismatch_warn): Remove declaration.
3660 (check_frame_language_change): Pass lang_frame_mismatch_warn
3663 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3665 * c-lang.h (vtbl_ptr_name): Declare.
3666 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3668 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3670 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3672 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3675 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3677 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3678 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3679 * ctfread.c: New file.
3680 * ctfread.h: New file.
3681 * elfread.c: Include ctfread.h.
3682 (struct elfinfo text_p): New member ctfsect.
3683 (elf_locate_sections): Mark CTF section.
3684 (elf_symfile_read): Call elfctf_build_psymtabs.
3685 * Makefile.in (LIBCTF): Add.
3688 (DIST): Add ctfread.c.
3690 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3692 * ctfread.c (struct nextfield): Renamed to ...
3693 (struct ctf_nextfield): ... this.
3694 (struct field_info): Renamed to ...
3695 (strut ctf_field_info): ... this.
3696 (attach_fields_to_type): Update for renamed structures.
3697 (ctf_add_member_cb): Likewise.
3698 (ctf_add_enum_member_cb): Likewise.
3699 (process_struct_members): Likewise.
3700 (process_enum_type): Likewise.
3702 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3704 * tracectf.h: Rename, was ctf.h.
3705 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3706 * tracefile.c: Likewise.
3707 * tracepoint.c: Remove unused include ctf.h.
3708 * mi/mi-main.c: Likewise.
3709 * Makefile.in Replace ctf.c with tracectf.c.
3711 2019-10-06 Joel Brobecker <brobecker@adacore.com>
3713 * version.in: Change version number to "9.0.50.DATE-git".
3715 2019-10-03 Tom Tromey <tom@tromey.com>
3718 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3720 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3722 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3723 cp_search_name_hash.
3724 * NEWS: Add entry about nested function support.
3726 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3727 Andrew Burgess <andrew.burgess@embecosm.com>
3729 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3730 for nested static variables when searchin VAR_DOMAIN.
3731 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3732 global scope, update comment.
3733 (add_partial_subprogram): Call add_partial_subprogram recursively
3734 for nested subroutines when processinng Fortran.
3735 (load_partial_dies): Process the child entities of a subprogram
3736 when processing Fortran.
3737 (partial_die_parent_scope): Handle building scope
3738 for Fortran nested functions.
3739 (process_die): Record that nested functions have a scope.
3740 (new_symbol): Always record Fortran subprograms on the global
3742 (determine_prefix): How to build the prefix for Fortran
3745 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3747 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3748 have just sent the thread a SIGSTOP and are waiting for it to
3751 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3753 * btrace.c (btrace_add_pc): Remove whitespace before the template
3754 parameter in 'std::vector <...>'.
3755 (parse_xml_btrace_block): Likewise.
3756 (btrace_maint_decode_pt): Likewise.
3757 (btrace_maint_update_packets): Likewise.
3758 (btrace_maint_print_packets): Likewise.
3759 * btrace.h (struct btrace_maint_info): Likewise.
3760 * dwarf2read.c (struct type_unit_group): Likewise.
3761 (build_type_psymtabs_reader): Likewise.
3762 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3763 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3764 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3766 2019-10-03 Tom de Vries <tdevries@suse.de>
3768 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3769 the first line of the help text for set/show style metadata.
3771 2019-10-02 Tom Tromey <tromey@adacore.com>
3773 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3774 * gdbsupport/common-inferior.c: New file.
3775 * infcmd.c (startup_with_shell): Don't define.
3776 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3777 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3778 * inferior.h (startup_with_shell): Don't declare.
3780 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3782 * gdbsupport/gdb_assert.h: Include errors.h.
3783 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3785 2019-10-02 Tom Tromey <tromey@adacore.com>
3787 * NEWS: Add $_ada_exception entry.
3788 * ada-lang.c (struct ada_catchpoint): Add constructor.
3789 <m_kind>: New member.
3790 (allocate_location_exception, re_set_exception): Remove
3792 (should_stop_exception): Compute $_ada_exception.
3793 (check_status_exception, print_it_exception)
3794 (print_one_exception, print_mention_exception): Remove
3796 (allocate_location_catch_exception, re_set_catch_exception)
3797 (check_status_exception, print_it_catch_exception)
3798 (print_one_catch_exception, print_mention_catch_exception)
3799 (print_recreate_catch_exception)
3800 (allocate_location_catch_exception_unhandled)
3801 (re_set_catch_exception_unhandled)
3802 (check_status_exception, print_it_catch_exception_unhandled)
3803 (print_one_catch_exception_unhandled)
3804 (print_mention_catch_exception_unhandled)
3805 (print_recreate_catch_exception_unhandled)
3806 (allocate_location_catch_assert, re_set_catch_assert)
3807 (check_status_assert, print_it_catch_assert)
3808 (print_one_catch_assert, print_mention_catch_assert)
3809 (print_recreate_catch_assert)
3810 (allocate_location_catch_handlers, re_set_catch_handlers)
3811 (check_status_handlers, print_it_catch_handlers)
3812 (print_one_catch_handlers, print_mention_catch_handlers)
3813 (print_recreate_catch_handlers): Remove.
3814 (create_ada_exception_catchpoint): Update.
3815 (initialize_ada_catchpoint_ops): Update.
3817 2019-10-02 Tom Tromey <tromey@adacore.com>
3819 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3820 (create_excep_cond_exprs): Simplify exception string computation.
3821 (ada_exception_catchpoint_cond_string): Likewise.
3823 2019-10-02 Tom Tromey <tromey@adacore.com>
3825 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3826 * ada-lang.c (lesseq_defined_than): Handle
3828 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3830 (dwarf2_has_info): Likewise.
3831 (new_symbol): Set maybe_copied on symbol when
3833 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3835 <can_copy>: New member.
3836 * elfread.c (record_minimal_symbol): Set maybe_copied
3837 on symbol when appropriate.
3838 (elf_symfile_read): Update call to dwarf2_has_info.
3839 * minsyms.c (lookup_minimal_symbol_linkage): New
3841 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3842 * symtab.c (get_symbol_address, get_msymbol_address):
3844 * symtab.h (get_symbol_address, get_msymbol_address):
3846 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3848 (struct symbol, struct minimal_symbol) <maybe_copied>:
3851 2019-10-02 Tom Tromey <tromey@adacore.com>
3853 * source.c (struct current_source_location): New.
3854 (current_source_key): New global.
3855 (current_source_symtab, current_source_line)
3856 (current_source_pspace): Remove.
3857 (get_source_location): New function.
3858 (get_current_source_symtab_and_line)
3859 (set_default_source_symtab_and_line)
3860 (set_current_source_symtab_and_line)
3861 (clear_current_source_symtab_and_line, select_source_symtab)
3862 (info_source_command, print_source_lines_base)
3863 (info_line_command, search_command_helper, _initialize_source):
3866 2019-10-02 Tom Tromey <tromey@adacore.com>
3868 * source.c (select_source_symtab): Don't call
3869 decode_line_with_current_source.
3871 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3873 * symtab.c (lookup_global_symbol): Search global block.
3875 2019-10-02 Tom Tromey <tromey@adacore.com>
3877 * coffread.c (process_coff_symbol): Update.
3878 * dwarf2read.c (var_decode_location, new_symbol): Update.
3879 * mdebugread.c (parse_symbol): Update.
3880 * objfiles.c (relocate_one_symbol): Update.
3881 * stabsread.c (define_symbol, fix_common_block)
3882 (scan_file_globals): Update.
3883 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3884 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3885 * xcoffread.c (process_xcoff_symbol): Update.
3887 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3889 * MAINTAINERS: Update my email address.
3891 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3893 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3895 (build_type_psymtabs_reader): Update for std::vector.
3896 (build_type_psymtab_dependencies): Likewise.
3897 * dwarf2read.h: Remove use of DEF_VEC_P.
3898 (typedef sig_type_ptr): Delete.
3900 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3902 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3904 (btrace_maint_decode_pt): Likewise, and move allocation of the
3905 vector outside of the loop.
3906 (btrace_maint_update_packets): Update to handle change from VEC to
3908 (btrace_maint_print_packets): Likewise.
3909 (maint_info_btrace_cmd): Likewise.
3910 * btrace.h: Remove use of DEF_VEC_O.
3911 (typedef btrace_pt_packet_s): Delete.
3912 (struct btrace_maint_info) <packets>: Change fromm VEC to
3914 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3916 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3918 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3919 make accesses into the vector constant references.
3920 (btrace_add_pc): Update for std::vector.
3921 (btrace_stitch_bts): Likewise.
3922 (parse_xml_btrace_block): Likewise.
3923 (btrace_maint_update_packets): Likewise.
3924 (btrace_maint_print_packets): Likewise.
3925 (maint_info_btrace_cmd): Likewise.
3926 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3928 (btrace_data::empty): Likewise.
3929 (btrace_data_append): Likewise.
3930 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3931 (typedef btrace_block_s): Delete.
3932 (struct btrace_block): Add constructor.
3933 (struct btrace_data_bts) <blocks>: Change to std::vector.
3934 * nat/linux-btrace.c (perf_event_read_bts): Update for
3936 (linux_read_bts): Likewise.
3938 2019-10-01 Tom Tromey <tom@tromey.com>
3940 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3942 2019-10-01 Tom Tromey <tom@tromey.com>
3944 * stack.c (print_frame, info_frame_command_core): Use
3946 * linux-thread-db.c (try_thread_db_load_1)
3947 (try_thread_db_load_from_pdir_1): Use styled_string.
3948 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3949 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3950 (maybe_print_unsupported_script_warning)
3951 (maybe_print_script_not_found_warning): Use styled_string.
3952 * ada-lang.c (user_select_syms): Use styled_string.
3954 2019-10-01 Tom Tromey <tom@tromey.com>
3956 * p-lang.c (pascal_printstr): Use metadata style.
3957 * value.c (show_convenience): Use metadata style.
3958 * valprint.c (valprint_check_validity, val_print_optimized_out)
3959 (val_print_not_saved, val_print_unavailable)
3960 (val_print_invalid_address, generic_val_print, val_print)
3961 (value_check_printable, val_print_array_elements): Use metadata
3963 * ui-out.h (class ui_out) <field_fmt>: New overload.
3964 <do_field_fmt>: Add style parameter.
3965 * ui-out.c (ui_out::field_fmt): New overload.
3966 * typeprint.c (type_print_unknown_return_type)
3967 (val_print_not_allocated, val_print_not_associated): Use metadata
3969 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3971 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3972 * tracepoint.c (tvariables_info_1): Use metadata style.
3973 * stack.c (print_frame_arg, print_frame_info, print_frame)
3974 (info_frame_command_core): Use metadata style.
3975 * skip.c (info_skip_command): Use metadata style.
3976 * rust-lang.c (rust_print_enum): Use metadata style.
3977 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3979 * python/py-framefilter.c (py_print_single_arg): Use metadata
3981 * printcmd.c (do_one_display, print_variable_and_value): Use
3983 * p-valprint.c (pascal_val_print)
3984 (pascal_object_print_value_fields): Use metadata style.
3985 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3986 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3988 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3989 * m2-valprint.c (m2_print_long_set): Use metadata style.
3990 * m2-typeprint.c (m2_print_type): Use metadata style.
3991 * infcmd.c (print_return_value_1): Use metadata style.
3992 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3993 * f-valprint.c (info_common_command_for_block): Use metadata
3995 * f-typeprint.c (f_type_print_base): Use metadata style.
3996 * expprint.c (print_subexp_standard): Use metadata style.
3997 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3998 * cli/cli-style.h (class cli_style_option): Add constructor.
3999 (metadata_style): Declare.
4000 * cli/cli-style.c (metadata_style): New global.
4001 (_initialize_cli_style): Register metadata style.
4002 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
4004 * cli-out.c (cli_ui_out::do_field_fmt): Update.
4005 * c-typeprint.c (c_type_print_base_struct_union)
4006 (c_type_print_base_1): Use metadata style.
4007 * breakpoint.c (watchpoint_value_print)
4008 (print_one_breakpoint_location): Use metadata style.
4009 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
4011 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
4013 * ada-valprint.c (val_print_packed_array_elements, printstr)
4014 (print_field_values, ada_val_print_ref, ada_val_print): Use
4016 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
4018 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
4020 * ada-lang.c (user_select_syms): Use metadata style.
4022 2019-10-01 Tom Tromey <tom@tromey.com>
4024 * cli/cli-cmds.c (pwd_command): Style output.
4026 2019-10-01 Pedro Alves <palves@redhat.com>
4027 Tom Tromey <tom@tromey.com>
4029 * symtab.c (print_symbol_info): Use %ps.
4030 (print_msymbol_info): Use %ps.
4031 * symfile.c (symbol_file_add_with_addrs): Use %ps.
4032 * printcmd.c (print_variable_and_value): Use %ps.
4033 * macrocmd.c (show_pp_source_pos): Use %ps.
4034 * infrun.c (print_exited_reason): Use ui_out::message.
4035 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4036 (describe_other_breakpoints): Use ui_out::message and new
4038 (say_where): Use new formats.
4039 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4042 2019-10-01 Pedro Alves <palves@redhat.com>
4043 Tom Tromey <tom@tromey.com>
4045 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4046 (test_gdb_formats): New function.
4047 (run_tests): Call it.
4048 (test_format_specifier): Update.
4049 * utils.h (fputs_filtered): Update comment.
4050 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4051 (fputs_styled_unfiltered): Declare.
4052 * utils.c (fputs_styled_unfiltered): New function.
4053 (vfprintf_maybe_filtered): Add gdbfmt parameter.
4054 (vfprintf_filtered): Update.
4055 (vfprintf_unfiltered, vprintf_filtered): Update.
4056 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4057 * ui-out.h (enum ui_out_flag) <unfiltered_output,
4058 disallow_ui_out_field>: New constants.
4059 (enum class field_kind): New.
4060 (struct base_field_s, struct signed_field_s): New.
4061 (signed_field): New function.
4062 (struct string_field_s): New.
4063 (string_field): New function.
4064 (struct styled_string_s): New.
4065 (styled_string): New function.
4066 (class ui_out) <message>: Add comment.
4067 <vmessage, call_do_message>: New methods.
4068 <do_message>: Add style parameter.
4069 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4071 (ui_out::message): Rewrite.
4072 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4074 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4075 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4076 gdb_extensions parameter.
4077 (class format_piece): Add parameter to constructor.
4078 (n_int_args): New field.
4079 * gdbsupport/format.c (format_pieces::format_pieces): Add
4080 gdb_extensions parameter. Handle '*'.
4081 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4082 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
4083 vfprintf_styled_no_gdbfmt.
4084 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4085 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4087 * ui-style.h (struct ui_file_style) <ptr>: New method.
4089 2019-10-01 Tom Tromey <tom@tromey.com>
4091 * unittests/format_pieces-selftests.c: Update. Add final format.
4092 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4093 empty literal pieces.
4095 2019-10-01 Tom Tromey <tom@tromey.com>
4097 * ui-out.h (enum class ui_out_style_kind): Remove.
4098 (class ui_out) <field_string, field_stsream, do_field_string>:
4099 Change type of "style".
4100 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4101 (ui_out::field_string): Update.
4102 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4104 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4105 * tracepoint.c (print_one_static_tracepoint_marker): Update.
4106 * stack.c (print_frame_arg, print_frame_info, print_frame):
4108 * source.c (print_source_lines_base): Update.
4109 * solib.c (info_sharedlibrary_command): Update.
4110 * skip.c (info_skip_command): Update.
4111 * record-btrace.c (btrace_call_history_src_line)
4112 (btrace_call_history): Update.
4113 * python/py-framefilter.c (py_print_frame): Update.
4114 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4116 * mi/mi-out.c (mi_ui_out::do_table_header)
4117 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4118 (mi_ui_out::do_field_string): Update.
4119 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4121 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4123 * cli-out.c (cli_ui_out::do_table_header)
4124 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4125 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4126 (cli_ui_out::do_field_fmt): Update.
4127 * breakpoint.c (print_breakpoint_location): Update.
4128 (update_static_tracepoint): Update.
4130 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4132 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4133 conversion of gdb_datadir.
4134 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4135 remove not needed c_str ().
4137 2019-09-30 Ali Tamur <tamur@google.com>
4139 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4140 (dwarf2_string_attr): Likewise.
4142 2019-09-30 Ali Tamur <tamur@google.com>
4144 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4145 (process_full_type_unit): Likewise.
4146 (dump_die_shallow): Likewise.
4147 (cu_debug_loc_section): Likewise.
4149 2019-09-28 Christian Biesinger <cbiesinger@google.com>
4151 * minsyms.c (compare_minimal_symbols): Rename to...
4152 (minimal_symbol_is_less_than): ...this, and adjust to STL
4153 conventions (return bool, take arguments as references)
4154 (minimal_symbol_reader::install): Call std::sort instead
4157 2019-09-29 Christian Biesinger <cbiesinger@google.com>
4159 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4161 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4162 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4164 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4166 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4167 * psympriv.h (add_psymbol_to_list): Move comment here and update
4170 2019-09-29 Tom de Vries <tdevries@suse.de>
4172 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4173 Use $tmpdir/$(basename "$output_file").dwz instead of
4174 "${output_file}.dwz".
4176 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4179 * hppa-linux-nat.c: Include gdbarch.h.
4181 2019-09-26 Christian Biesinger <cbiesinger@google.com>
4183 * blockframe.c (find_pc_partial_function): Change return type to bool.
4184 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4185 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4186 (stub_gnu_ifunc_resolve_name): Likewise.
4187 * symtab.c (compare_filenames_for_search): Likewise.
4188 (compare_glob_filenames_for_search): Likewise.
4189 (matching_obj_sections): Likewise.
4190 (symbol_matches_domain): Likewise.
4191 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4192 (find_line_pc): Change return type to bool.
4193 (find_line_pc_range): Likewise.
4194 (producer_is_realview): Likewise.
4195 * symtab.h (symbol_matches_domain): Likewise.
4196 (find_pc_partial_function): Likewise.
4197 (find_pc_line_pc_range): Likewise.
4198 (in_gnu_ifunc_stub): Likewise.
4199 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4200 (find_line_pc): Likewise.
4201 (find_line_pc_range): Likewise.
4202 (matching_obj_sections): Likewise.
4203 (find_line_symtab): Change out parameter to bool.
4204 (producer_is_realview): Change return type to bool.
4205 (compare_filenames_for_search): Likewise.
4206 (compare_glob_filenames_for_search): Likewise.
4208 2019-09-26 Tom Tromey <tom@tromey.com>
4210 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4211 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4212 * gdb_usleep.h: Remove.
4213 * gdb_usleep.c: Remove.
4214 * utils.c: Don't include gdb_usleep.h.
4216 2019-09-26 Tom Tromey <tromey@adacore.com>
4218 * python/py-type.c (type_to_type_object): Call check_typedef
4221 2019-09-26 Tom Tromey <tom@tromey.com>
4223 * utils.h (initialize_utils): Don't declare.
4224 * top.c (gdb_init): Don't call initialize_utils.
4225 * utils.c (initialize_utils): Remove. Move contents...
4226 (_initialize_utils): ... here.
4228 2019-09-25 Tom Tromey <tom@tromey.com>
4230 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4231 * utils.h (make_hex_string): Don't declare.
4232 * utils.c (make_hex_string): Remove.
4234 2019-09-24 Tom de Vries <tdevries@suse.de>
4237 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4238 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4240 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4242 * NEWS: Mention new simulator port for PRU.
4244 2019-09-23 Christian Biesinger <cbiesinger@google.com>
4246 * ada-exp.y (write_object_remaining): Update.
4247 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4248 and eliminate the static buffer.
4249 (ada_decode_symbol): Update.
4250 (ada_la_decode): Update.
4251 (ada_sniff_from_mangled_name): Update.
4252 (is_valid_name_for_wild_match): Update.
4253 (ada_lookup_name_info::matches): Update and simplify.
4254 (name_matches_regex): Update.
4255 (ada_add_global_exceptions): Update.
4256 * ada-lang.h (ada_decode): Update signature.
4257 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4258 * dwarf-index-write.c (debug_names::insert): Update.
4260 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4262 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4265 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4267 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4268 Change "nonzero" to "true" in documentation.
4270 2019-09-20 Christian Biesinger <cbiesinger@google.com>
4272 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4273 (_initialize_darwin_solib): Don't set
4274 darwin_so_ops.lookup_lib_global_symbol.
4275 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4276 set_gdbarch_iterate_over_objfiles_in_search_order.
4277 (elf_lookup_lib_symbol): Rename to...
4278 (svr4_iterate_over_objfiles_in_search_order): this, and update
4279 to iterate semantics.
4280 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4281 * solib.c (solib_global_lookup): Remove.
4282 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4283 (solib_global_lookup): Remove.
4284 * symtab.c (lookup_global_or_static_symbol): Remove call to
4285 solib_global_lookup.
4287 2019-09-20 Joel Brobecker <brobecker@adacore.com>
4289 * NEWS: Move entries about default MI version now being
4290 version 3, and about the GDB/MI fix for multi-location
4291 breakpoints to the "since GDB 8.3" section.
4293 2019-09-20 Joel Brobecker <brobecker@adacore.com>
4297 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4299 * NEWS: Mention that Cell/B.E. debugging support was removed.
4300 * MAINTAINERS: Remove spu target.
4302 * config/djgpp/fnchange.lst: Remove entries for removed files.
4304 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4305 spu-multiarch.o, and spu-tdep.o.
4306 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4307 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4308 spu-multiarch.c, and spu-tdep.c.
4309 * spu-linux-nat.c: Remove file.
4310 * spu-multiarch.c: Remove file.
4311 * spu-tdep.c: Remove file.
4312 * spu-tdep.h: Remove file.
4313 * solib-spu.c: Remove file.
4314 * solib-spu.h: Remove file.
4316 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4317 * configure.nat (spu-linux): Remove.
4318 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4319 solib-multiarch.o from gdb_target_obs.
4322 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4324 (ppc_linux_no_features): Update.
4325 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4327 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4328 (tdesc_powerpc_cell64l): Likewise.
4329 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4330 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4332 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4333 Do not include "features/rs6000/powerpc-cell32l.c" or
4334 "features/rs6000/powerpc-cell64l.c".
4335 (ppc_linux_spu_section): Remove.
4336 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4337 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4338 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4339 (ppc_linux_spe_context_lookup): Remove.
4340 (ppc_linux_spe_context_inferior_created): Remove.
4341 (ppc_linux_spe_context_solib_loaded): Remove.
4342 (ppc_linux_spe_context_solib_unloaded): Remove.
4343 (ppc_linux_spe_context): Remove.
4344 (struct ppu2spu_cache): Remove.
4345 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4346 (struct ppu2spu_data): Remove.
4347 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4348 ppu2spu_unwind): Remove.
4349 (ppc_linux_init_abi): Remove Cell/B.E. support.
4350 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4352 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4353 (rs6000/powerpc-cell64l-expedite): Likewise
4354 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4355 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4356 rs6000/powerpc-cell64l.xml.
4357 * features/rs6000/powerpc-cell32l.xml: Remove.
4358 * features/rs6000/powerpc-cell64l.xml: Likewise.
4359 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4360 * features/rs6000/powerpc-cell64l.c: Likewise.
4361 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4362 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4363 * regformats/reg-spu.dat: Remove.
4365 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4366 * corelow.c (struct spuid_list): Remove.
4367 (add_to_spuid_list): Remove.
4368 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4369 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4370 (remote_protocol_features): Remove associated entries.
4371 (_initialize_remote): No longer initialize them.
4372 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4373 * linux-nat.c (SPUFS_MAGIC): Remove.
4374 (linux_proc_xfer_spu): Remove.
4375 (spu_enumerate_spu_ids): Remove.
4376 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4377 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4378 (linux_make_corefile_notes): No longer call it.
4380 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4381 (cooked_write_test): Likewise.
4383 2019-09-20 Tom Tromey <tom@tromey.com>
4385 * NEWS: Mention case-sensitivity of TUI commands.
4386 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4387 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4388 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4390 2019-09-20 Tom Tromey <tom@tromey.com>
4392 * tui/tui-source.c (tui_source_window::set_contents): Use
4393 make_unique_xstrdup.
4394 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4395 make_unique_xstrdup.
4397 2019-09-20 Tom Tromey <tom@tromey.com>
4399 * tui/tui-data.c: Remove separator comments.
4400 * tui/tui-layout.c: Remove separator comments.
4401 * tui/tui-win.c: Remove separator comments.
4402 * tui/tui-wingeneral.c: Remove separator comments.
4404 2019-09-20 Tom Tromey <tom@tromey.com>
4406 * tui/tui.h (strcat_to_buf): Don't declare.
4407 * tui/tui.c (strcat_to_buf): Remove.
4409 2019-09-20 Tom Tromey <tom@tromey.com>
4411 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4413 * tui/tui-source.c (tui_source_window::set_contents)
4414 (tui_source_window::location_matches_p)
4415 (tui_source_window::maybe_update): Update.
4417 2019-09-20 Tom Tromey <tom@tromey.com>
4419 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4421 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4423 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4424 (tui_data_window::line_from_reg_element_no)
4425 (tui_data_window::first_reg_element_no_inline)
4426 (tui_data_window::show_registers)
4427 (tui_data_window::show_register_group)
4428 (tui_data_window::display_registers_from)
4429 (tui_data_window::display_registers_from_line)
4430 (tui_data_window::first_data_item_displayed)
4431 (tui_data_window::delete_data_content_windows)
4432 (tui_data_window::erase_data_content)
4433 (tui_data_window::do_scroll_vertical)
4434 (tui_data_window::refresh_window)
4435 (tui_data_window::check_register_values): Update.
4437 2019-09-20 Tom Tromey <tom@tromey.com>
4439 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4440 (struct tui_locator_window) <full_name, proc_name>: Now
4442 * tui/tui-stack.c (tui_locator_window::make_status_line)
4443 (tui_locator_window::set_locator_fullname)
4444 (tui_locator_window::set_locator_info): Update.
4445 * tui/tui-source.c (tui_source_window::set_contents)
4446 (tui_source_window::showing_source_p): Update.
4448 2019-09-20 Tom Tromey <tom@tromey.com>
4450 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4451 Don't call tui_locator_win_info_ptr.
4453 2019-09-20 Tom Tromey <tom@tromey.com>
4455 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4457 2019-09-20 Tom Tromey <tom@tromey.com>
4459 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4461 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4462 * tui/tui-layout.c (show_source_disasm_command, show_data)
4463 (show_source_or_disasm_and_command): Use 1 as height for locator.
4465 2019-09-20 Tom Tromey <tom@tromey.com>
4467 * tui/tui.c (tui_enable): Update.
4468 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4470 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4472 * tui/tui-data.c (win_resized): Now bool.
4473 (tui_win_resized): Return bool.
4474 (tui_set_win_resized_to): Accept a bool.
4476 2019-09-20 Tom Tromey <tom@tromey.com>
4478 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4479 Change type of "refresh_values_only".
4480 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4481 type of "refresh_values_only".
4483 2019-09-20 Tom Tromey <tom@tromey.com>
4485 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4487 (tui_disassemble): Add "pos" parameter.
4488 (tui_disasm_window::set_contents): Simplify.
4490 2019-09-20 Tom Tromey <tom@tromey.com>
4492 * tui/tui-winsource.h (struct tui_source_window_base)
4493 <show_source_content>: Now private.
4494 * tui/tui-winsource.c
4495 (tui_source_window_base::show_source_content): Don't handle empty
4498 2019-09-20 Tom Tromey <tom@tromey.com>
4500 * tui/tui-layout.c (show_source_disasm_command)
4501 (show_source_or_disasm_and_command): Don't call
4502 show_source_content.
4504 2019-09-20 Tom Tromey <tom@tromey.com>
4506 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4508 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4509 from tui_make_status_line.
4510 (tui_locator_window::rerender): Update.
4512 2019-09-20 Tom Tromey <tom@tromey.com>
4514 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4515 (tui_locator_window::rerender): Update.
4517 2019-09-20 Tom Tromey <tom@tromey.com>
4519 * tui/tui-winsource.h (struct tui_source_window_base)
4520 <~tui_source_window_base>: Don't declare.
4522 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4523 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4525 * tui/tui-source.c (tui_source_window::set_contents): Update.
4526 (tui_source_window::location_matches_p)
4527 (tui_source_window::maybe_update): Update.
4529 2019-09-20 Tom Tromey <tom@tromey.com>
4531 * tui/tui-winsource.h (~tui_source_element): Remove.
4532 (tui_source_element): Update.
4533 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4534 * tui/tui-winsource.c (tui_show_source_line): Update.
4535 * tui/tui-source.c (tui_source_window::set_contents): Update.
4536 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4538 2019-09-20 Tom Tromey <tom@tromey.com>
4540 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4542 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4543 tui_clear_source_windows_detail.
4544 * tui/tui-winsource.h (struct tui_source_window_base)
4545 <clear_detail>: Don't declare.
4546 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4548 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4550 2019-09-20 Tom Tromey <tromey@adacore.com>
4553 * block.c (contained_in): Fix final return value.
4555 2019-09-20 Alan Modra <amodra@gmail.com>
4557 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4558 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4559 (read_indirect_string_from_dwz): Use bfd accessor.
4560 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4561 * machoread.c (macho_symfile_read_all_oso): Likewise.
4562 * solib.c (solib_bfd_open): Likewise.
4564 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4566 * eval.c: Move declaration of overload_resolution to...
4569 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4571 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4572 * arm-linux-tdep.c: Likewise.
4573 * arm-nbsd-nat.c: Likewise.
4574 * arm-tdep.h: Declare arm_apcs_32.
4575 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4577 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4579 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4580 * dwarf2read.h: Declare dwarf_always_disassemble.
4582 2019-09-19 Tom de Vries <tdevries@suse.de>
4585 * source-cache.c (source_cache::ensure): Catch exception thrown during
4586 construction of the highlighter.
4588 2019-09-18 Alan Modra <amodra@gmail.com>
4590 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4591 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4592 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4593 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4594 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4595 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4596 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4597 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4598 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4599 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4600 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4601 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4602 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4603 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4604 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4605 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4606 * mi/mi-interp.c: Update throughout for bfd section macro and
4608 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4609 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4611 2019-09-18 Tom Tromey <tom@tromey.com>
4614 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4616 (tui_enable): Do not call rl_initialize.
4618 2019-09-18 Christian Groessler <chris@groessler.org>
4620 * alpha-linux-nat.c: Include gdbarch.h.
4622 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4624 * ui-file.c: Include cli/cli-style.h.
4625 (term_cli_styling): Remove cli_styling declaration.
4627 2019-09-18 Alan Modra <amodra@gmail.com>
4629 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4630 to bfd_asymbol_section.
4632 2019-09-18 Alan Modra <amodra@gmail.com>
4634 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4635 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4636 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4638 2019-09-18 Alan Modra <amodra@gmail.com>
4640 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4641 * spu-linux-nat.c (spu_bfd_open): Likewise.
4643 2019-09-18 Christian Biesinger <cbiesinger@google.com>
4645 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4646 to bool to match definition in dwarf2read.c.
4648 2019-09-17 Christian Biesinger <cbiesinger@google.com>
4650 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4651 (print_signatures): Likewise.
4652 (trust_pad_over_xvs): Likewise.
4653 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4654 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4655 * arm-linux-nat.c (arm_apcs_32): Likewise.
4656 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4657 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4658 * arm-tdep.c (arm_debug): Likewise.
4659 (arm_apcs_32): Likewise.
4660 * auto-load.c (debug_auto_load): Likewise.
4661 (auto_load_gdb_scripts): Likewise.
4662 (global_auto_load): Likewise.
4663 (auto_load_local_gdbinit): Likewise.
4664 (auto_load_local_gdbinit_loaded): Likewise.
4665 * auto-load.h (global_auto_load): Likewise.
4666 (auto_load_local_gdbinit): Likewise.
4667 (auto_load_local_gdbinit_loaded): Likewise.
4668 * breakpoint.c (disconnected_dprintf): Likewise.
4669 (breakpoint_proceeded): Likewise.
4670 (automatic_hardware_breakpoints): Likewise.
4671 (always_inserted_mode): Likewise.
4672 (target_exact_watchpoints): Likewise.
4673 (_initialize_breakpoint): Update.
4674 * breakpoint.h (target_exact_watchpoints): Change to bool.
4675 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4676 * cli/cli-cmds.c (trace_commands): Likewise.
4677 * cli/cli-cmds.h (trace_commands): Likewise.
4678 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4680 * cli/cli-logging.c (logging_overwrite): Change to bool.
4681 (logging_redirect): Likewise.
4682 (debug_redirect): Likewise.
4683 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4684 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4686 <boolean_option_def>: Update.
4687 (struct flag_option_def): Change default type of Context to bool
4689 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4690 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4691 (get_setshow_command_value_string): Likewise.
4692 * cli/cli-style.c (cli_styling): Change to bool.
4693 (source_styling): Likewise.
4694 * cli/cli-style.h (source_styling): Likewise.
4695 (cli_styling): Likewise.
4696 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4698 * command.h (var_types): Update comment.
4699 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4700 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4702 (debug_compile_cplus_scopes): Likewise.
4703 * compile/compile-internal.h (compile_debug): Likewise.
4704 * compile/compile.c (compile_debug): Likewise.
4705 (struct compile_options) <raw>: Likewise.
4706 * cp-support.c (catch_demangler_crashes): Likewise.
4707 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4708 (usr_cmd_cris_dwarf2_cfi): Likewise.
4709 * csky-tdep.c (csky_debug): Likewise.
4710 * darwin-nat.c (enable_mach_exceptions): Likewise.
4711 * dcache.c (dcache_enabled_p): Likewise.
4712 * defs.h (info_verbose): Likewise.
4713 * demangle.c (demangle): Likewise.
4714 (asm_demangle): Likewise.
4715 * dwarf-index-cache.c (debug_index_cache): Likewise.
4716 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4717 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4718 * dwarf2read.c (check_physname): Likewise.
4719 (use_deprecated_index_sections): Likewise.
4720 (dwarf_always_disassemble): Likewise.
4721 * eval.c (overload_resolution): Likewise.
4722 * event-top.c (set_editing_cmd_var): Likewise.
4723 (exec_done_display_p): Likewise.
4724 * event-top.h (set_editing_cmd_var): Likewise.
4725 (exec_done_display_p): Likewise.
4726 * exec.c (write_files): Likewise.
4727 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4728 (debug_fbsd_nat): Likewise.
4729 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4731 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4732 <backtrace_past_entry> Likewise.
4733 * gdb-demangle.h (demangle): Likewise.
4734 (asm_demangle): Likewise.
4735 * gdb_bfd.c (bfd_sharing): Likewise.
4736 * gdbcore.h (write_files): Likewise.
4737 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4738 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4739 * gdbthread.h (print_thread_events): Likewise.
4740 * gdbtypes.c (opaque_type_resolution): Likewise.
4741 (strict_type_checking): Likewise.
4742 * gnu-nat.c (gnu_debug_flag): Likewise.
4743 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4744 * guile/scm-param.c (pascm_variable): Add boolval.
4745 (add_setshow_generic): Update.
4746 (pascm_param_value): Update.
4747 (pascm_set_param_value_x): Update.
4748 * hppa-tdep.c (hppa_debug): Change to bool..
4749 * infcall.c (may_call_functions_p): Likewise.
4750 (coerce_float_to_double_p): Likewise.
4751 (unwind_on_signal_p): Likewise.
4752 (unwind_on_terminating_exception_p): Likewise.
4753 * infcmd.c (startup_with_shell): Likewise.
4754 * inferior.c (print_inferior_events): Likewise.
4755 * inferior.h (startup_with_shell): Likewise.
4756 (print_inferior_events): Likewise.
4757 * infrun.c (step_stop_if_no_debug): Likewise.
4758 (detach_fork): Likewise.
4759 (debug_displaced): Likewise.
4760 (disable_randomization): Likewise.
4761 (non_stop): Likewise.
4762 (non_stop_1): Likewise.
4763 (observer_mode): Likewise.
4764 (observer_mode_1): Likewise.
4765 (set_observer_mode): Update.
4766 (sched_multi): Change to bool.
4767 * infrun.h (debug_displaced): Likewise.
4768 (sched_multi): Likewise.
4769 (step_stop_if_no_debug): Likewise.
4770 (non_stop): Likewise.
4771 (disable_randomization): Likewise.
4772 * linux-tdep.c (use_coredump_filter): Likewise.
4773 (dump_excluded_mappings): Likewise.
4774 * linux-thread-db.c (auto_load_thread_db): Likewise.
4775 (check_thread_db_on_load): Likewise.
4776 * main.c (captured_main_1): Update.
4777 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4778 xx2_opt, boolean_opt>: Change to bool.
4779 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4780 * maint.c (maintenance_profile_p): Likewise.
4781 (per_command_time): Likewise.
4782 (per_command_space): Likewise.
4783 (per_command_symtab): Likewise.
4784 * memattr.c (inaccessible_by_default): Likewise.
4785 * mi/mi-main.c (mi_async): Likewise.
4786 (mi_async_1): Likewise.
4787 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4788 * nat/fork-inferior.h (startup_with_shell): Likewise.
4789 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4790 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4791 * nios2-tdep.c (nios2_debug): Likewise.
4792 * or1k-tdep.c (or1k_debug): Likewise.
4793 * parse.c (parser_debug): Likewise.
4794 * parser-defs.h (parser_debug): Likewise.
4795 * printcmd.c (print_symbol_filename): Likewise.
4796 * proc-api.c (procfs_trace): Likewise.
4797 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4798 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4799 (set_parameter_value): Update.
4800 (add_setshow_generic): Update.
4801 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4803 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4805 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4806 * record-btrace.c (record_btrace_target::store_registers): Update.
4807 * record-full.c (record_full_memory_query): Change to bool.
4808 (record_full_stop_at_limit): Likewise.
4809 * record-full.h (record_full_memory_query): Likewise.
4810 * remote-notif.c (notif_debug): Likewise.
4811 * remote-notif.h (notif_debug): Likewise.
4812 * remote.c (use_range_stepping): Likewise.
4813 (interrupt_on_connect): Likewise.
4814 (remote_break): Likewise.
4815 * ser-tcp.c (tcp_auto_retry): Likewise.
4816 * ser-unix.c (serial_hwflow): Likewise.
4817 * skip.c (debug_skip): Likewise.
4818 * solib-aix.c (solib_aix_debug): Likewise.
4819 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4820 (spu_auto_flush_cache_p): Likewise.
4821 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4823 (struct info_print_options) <quiet>: Likewise.
4824 * symfile-debug.c (debug_symfile): Likewise.
4825 * symfile.c (auto_solib_add): Likewise.
4826 (separate_debug_file_debug): Likewise.
4827 * symfile.h (auto_solib_add): Likewise.
4828 (separate_debug_file_debug): Likewise.
4829 * symtab.c (basenames_may_differ): Likewise.
4830 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4831 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4832 (struct info_types_options) <quiet>: Likewise.
4833 * symtab.h (demangle): Likewise.
4834 (basenames_may_differ): Likewise.
4835 * target-dcache.c (stack_cache_enabled_1): Likewise.
4836 (code_cache_enabled_1): Likewise.
4837 * target.c (trust_readonly): Likewise.
4838 (may_write_registers): Likewise.
4839 (may_write_memory): Likewise.
4840 (may_insert_breakpoints): Likewise.
4841 (may_insert_tracepoints): Likewise.
4842 (may_insert_fast_tracepoints): Likewise.
4843 (may_stop): Likewise.
4844 (auto_connect_native_target): Likewise.
4845 (target_stop_and_wait): Update.
4846 (target_async_permitted): Change to bool.
4847 (target_async_permitted_1): Likewise.
4848 (may_write_registers_1): Likewise.
4849 (may_write_memory_1): Likewise.
4850 (may_insert_breakpoints_1): Likewise.
4851 (may_insert_tracepoints_1): Likewise.
4852 (may_insert_fast_tracepoints_1): Likewise.
4853 (may_stop_1): Likewise.
4854 * target.h (target_async_permitted): Likewise.
4855 (may_write_registers): Likewise.
4856 (may_write_memory): Likewise.
4857 (may_insert_breakpoints): Likewise.
4858 (may_insert_tracepoints): Likewise.
4859 (may_insert_fast_tracepoints): Likewise.
4860 (may_stop): Likewise.
4861 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4862 (make_thread_apply_all_options_def_group): Change argument from int*
4864 (thread_apply_all_command): Update.
4865 (print_thread_events): Change to bool.
4866 * top.c (confirm): Likewise.
4867 (command_editing_p): Likewise.
4868 (history_expansion_p): Likewise.
4869 (write_history_p): Likewise.
4870 (info_verbose): Likewise.
4871 * top.h (confirm): Likewise.
4872 (history_expansion_p): Likewise.
4873 * tracepoint.c (disconnected_tracing): Likewise.
4874 (circular_trace_buffer): Likewise.
4875 * typeprint.c (print_methods): Likewise.
4876 (print_typedefs): Likewise.
4877 * utils.c (debug_timestamp): Likewise.
4878 (sevenbit_strings): Likewise.
4879 (pagination_enabled): Likewise.
4880 * utils.h (sevenbit_strings): Likewise.
4881 (pagination_enabled): Likewise.
4882 * valops.c (overload_resolution): Likewise.
4883 * valprint.h (struct value_print_options) <prettyformat_arrays,
4884 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4885 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4886 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4888 * windows-nat.c (new_console): Likewise.
4889 (cygwin_exceptions): Likewise.
4890 (new_group): Likewise.
4891 (debug_exec): Likewise.
4892 (debug_events): Likewise.
4893 (debug_memory): Likewise.
4894 (debug_exceptions): Likewise.
4895 (useshell): Likewise.
4896 * windows-tdep.c (maint_display_all_tib): Likewise.
4897 * xml-support.c (debug_xml): Likewise.
4899 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4901 * source.c (prepare_path_for_appending): New function.
4902 (openp): Make use of new function.
4903 (find_and_open_source): Search for the compilation directory and
4904 source file as a relative path beneath the directory search path.
4906 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4908 * source-cache.c (source_cache::get_line_charpos): Catch
4909 exceptions and return false, this matches the behaviour documented
4912 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4914 * ada-tasks.c (info_task): Remove quoting of the task's name.
4916 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4918 * symfile.c (auto_solib_add): Replace comment with a reference
4921 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4923 * NEWS: Mention that gdb can now be compiled with Python 3
4926 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4928 * maint.c (maint_print_section_data::maint_print_section_data):
4929 Force use of 'float log10 (float)' by casting the argument to
4932 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4934 * maint.c: Add 'cmath' include.
4935 (struct maint_print_section_data): New structure.
4936 (print_section_index): New function.
4937 (print_bfd_section_info): Add header comment, small whitespace
4938 cleanup, and update to call new print_section_index function.
4939 (print_objfile_section_info): Likewise.
4940 (maint_obj_section_from_bfd_section): New function.
4941 (print_bfd_section_info_maybe_relocated): New function.
4942 (maintenance_info_sections): Add header comment, always use
4943 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4945 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4947 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4948 inner scope, add check that the objfile has psymtabs before
4949 checking psymtabs_addrmap.
4950 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4952 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4954 * NEWS: Announce that Ada task names are now shown at more places,
4955 and between quotes (except in info task output).
4956 * gdb/ada-tasks.c (task_to_str): New function.
4957 (display_current_task_id): Call task_to_str.
4958 (task_command_1): Likewise.
4959 (print_ada_task_info): In non-mi mode, Properly align headers and data
4960 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4962 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4964 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4965 prstatus.pr_lwp.pr_info instead of making it up.
4967 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4969 * auto-load.c (auto_load_expand_dir_vars): Update.
4970 * defs.h (gdb_datadir): Change to std::string.
4971 (python_libdir): Likewise.
4972 (relocate_gdb_directory): Change return type to std::string.
4973 * guile/guile.c (gdbscm_data_directory): Update.
4974 (initialize_scheme_side): Update.
4975 * jit.c (jit_reader_dir): Change to std::string.
4976 (jit_reader_load_command): Update.
4977 * main.c (gdb_datadir): Change to std::string.
4978 (python_libdir): Likewise.
4979 (set_gdb_data_directory): Update.
4980 (relocate_path): Change to return std::string.
4981 (relocate_gdb_directory): Change to return std::string.
4982 (relocate_gdbinit_path_maybe_in_datadir): Update.
4983 (captured_main_1): Update.
4984 * python/python.c (do_start_initialization): Update.
4985 * top.c (show_gdb_datadir): Update.
4986 * xml-syscall.c (xml_init_syscalls_info): Update.
4987 (init_syscalls_info): Update.
4989 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4991 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4992 out of get_init_files.
4993 (get_init_files): Update.
4995 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4997 * main.c (get_init_files): Change to use std::string.
4998 (captured_main_1): Update.
4999 (print_gdb_help): Update.
5001 2019-09-11 Ali Tamur <tamur@google.com>
5003 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
5006 2019-09-11 Christian Biesinger <cbiesinger@google.com>
5008 * dbxread.c (read_dbx_symtab): Update.
5009 * dwarf2read.c (load_partial_dies): Update.
5010 * mdebugread.c (parse_partial_symbols): Update.
5011 (handle_psymbol_enumerators): Update.
5012 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
5013 * psymtab.c (add_psymbol_to_bcache): Likewise.
5014 (add_psymbol_to_list): Likewise.
5015 * symtab.c (symbol_set_names): Likewise.
5016 * symtab.h (symbol_set_names): Likewise.
5017 * xcoffread.c (scan_xcoff_symtab): Update.
5019 2019-09-11 Tom Tromey <tom@tromey.com>
5021 * symfile-mem.c (symbol_file_add_from_memory): Use
5023 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
5024 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
5026 2019-09-10 Tom Tromey <tromey@adacore.com>
5028 * dwarf-index-write.c (write_psymbols): Extend error message.
5029 (debug_names::insert): Add Ada code.
5030 (debug_names::write_psymbols): Remove Ada check.
5031 (debug_names) <m_string_obstack>: New member.
5032 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5033 (gdb_index_symbol_name_matcher::matches): Remove.
5034 (mapped_index_base::find_name_components_bounds): Add "lang"
5036 (mapped_index_base::build_name_components): Also split names
5037 according to Ada syntax.
5038 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
5039 type of "match_callback".
5040 (check_match, check_find_bounds_finds)
5041 (dw2_expand_symtabs_matching): Update.
5042 (dw2_debug_names_iterator): Add new constructor.
5043 (dw2_debug_names_map_matching_symbols): New function.
5044 (dw2_debug_names_expand_symtabs_matching): Update.
5045 (dwarf2_debug_names_functions): Use
5046 dw2_debug_names_map_matching_symbols.
5048 2019-09-10 Tom Tromey <tromey@adacore.com>
5050 * dwarf2read.c (dw2_get_file_names_reader): Add the
5051 CU's file name to the results.
5053 2019-09-10 Tom Tromey <tromey@adacore.com>
5055 * ada-lang.c (add_nonlocal_symbols): Combine calls to
5056 map_matching_symbols. Update.
5057 * dwarf2read.c (dw2_map_matching_symbols): Update.
5058 * psymtab.c (match_partial_symbol): Change type; update.
5059 (psym_map_matching_symbols): Likewise.
5060 * symfile-debug.c (debug_qf_map_matching_symbols): Change
5062 * symfile.h (struct quick_symbol_functions)
5063 <map_matching_symbols>: Change "name" to be a lookup_name_info.
5066 2019-09-10 Tom Tromey <tromey@adacore.com>
5068 * psymtab.c (map_block): Remove.
5069 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5070 * symtab.c (iterate_over_symbols_terminated): New function.
5071 * symtab.c (iterate_over_symbols_terminated): Declare.
5073 2019-09-10 Tom Tromey <tromey@adacore.com>
5075 * ada-lang.c (ada_iterate_over_symbols): Return bool.
5076 * language.h (struct language_defn) <la_iterate_over_symbols>:
5078 * symtab.c (iterate_over_symbols): Return bool.
5079 * symtab.h (iterate_over_symbols): Return bool.
5081 2019-09-10 Tom Tromey <tromey@adacore.com>
5083 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5084 (add_nonlocal_symbols): Update.
5085 * dwarf2read.c (dw2_map_matching_symbols): Change type.
5086 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5087 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5088 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5089 Change type of "callback". Remove "data".
5092 2019-09-09 Ali Tamur <tamur@google.com>
5094 * dwarf2read.c (comp_unit_head): Update comment.
5095 (dwarf2_dwo_name): New function declaration.
5096 (dwarf_unit_type_name): New function declaration.
5097 (read_comp_unit_head): Add support for new compilation units,
5098 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5099 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5100 (currently named as "signature") in their header. Also clarify error
5102 (lookup_dwo_id): New function. Returns the dwo id of the given
5104 (lookup_dwo_unit): Use the new lookup_dwo_id function.
5105 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5107 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5108 (dwarf2_dwo_name): Get the dwo name if present.
5109 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5112 2019-09-09 Tom Tromey <tom@tromey.com>
5114 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5116 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5118 * python/python.c (do_start_initialization): Make progname_copy static,
5119 to avoid a leak report.
5121 2019-09-08 Tom Tromey <tom@tromey.com>
5123 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5125 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
5127 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5128 Change type to gdb::optional<block_enum>.
5129 (dw2_symtab_iter_init): Change block_index parameter type
5130 to gdb::optional<block_enum>.
5131 (dw2_lookup_symbol): Change block_index parameter
5132 type to block_enum.c
5133 (dw2_debug_names_lookup_symbol): Likewise.
5134 * psymtab.c (psym_lookup_symbol): Likewise.
5135 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5136 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5139 2019-09-06 Christian Biesinger <cbiesinger@google.com>
5141 * defs.h (relocate_gdb_directory): Change int to bool in
5142 signature and rename flag to relocatable.
5143 * main.c (relocate_path): Likewise.
5144 (relocate_gdb_directory): Likewise.
5146 2019-09-06 Alan Modra <amodra@gmail.com>
5148 * coffread.c (coff_symfile_read): Constify filename variable.
5149 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5150 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5151 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5152 * solib.c (reload_shared_libraries_1): Likewise.
5153 * symfile.c (reread_symbols): Likewise.
5154 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5155 * solib-darwin.c (darwin_bfd_open): Likewise.
5156 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5158 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5160 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5161 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5163 2019-09-03 Tom Tromey <tromey@adacore.com>
5165 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5167 (has_negatives): Unbias a range type bound.
5168 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5169 * gdbtypes.c (operator==): Handle new field.
5170 (create_range_type): Add "bias" parameter.
5171 (create_static_range_type, resolve_dynamic_range): Update.
5172 * gdbtypes.h (struct range_bounds) <bias>: New member.
5173 (create_range_type): Add bias parameter.
5174 * printcmd.c (print_scalar_formatted): Unbias range types.
5175 * value.c (unpack_long): Unbias range types.
5176 (pack_long): Bias range types.
5178 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5180 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5183 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5185 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5186 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5187 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5188 (compile_probe_arg): Likewise.
5189 * probe.h (get_argument_count): Likewise.
5190 * solib-svr4.c (solib_event_probe_action): Likewise.
5191 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5193 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5195 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5197 (svr4_create_solib_event_breakpoints): ...from here.
5199 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5201 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5202 suffix from warning message.
5204 2019-08-30 Tom Tromey <tom@tromey.com>
5206 * tui/tui-winsource.h (struct tui_source_window_base)
5207 <refresh_all>: Don't declare.
5208 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5210 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5211 tui_show_locator_content.
5212 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5214 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5215 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5218 2019-08-30 Tom Tromey <tom@tromey.com>
5220 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5222 2019-08-30 Tom Tromey <tom@tromey.com>
5224 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5225 Remove unnecessary forward declarations.
5227 2019-08-30 Tom Tromey <tom@tromey.com>
5229 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5231 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5232 tui_show_locator_content.
5234 2019-08-30 Tom Tromey <tom@tromey.com>
5236 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5237 (tui_locator_window::rerender): Rewrite using body of previous
5238 tui_show_locator_content.
5240 2019-08-30 Tom Tromey <tom@tromey.com>
5242 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5243 set_locator_fullname>: New methods.
5244 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5245 Rename from tui_set_locator_fullname.
5246 (tui_locator_window::set_locator_info): Rename from
5247 tui_set_locator_info. Return bool.
5248 (tui_update_locator_fullname, tui_show_frame_info): Update.
5250 2019-08-30 Tom Tromey <tom@tromey.com>
5252 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5254 2019-08-30 Tom Tromey <tom@tromey.com>
5256 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5259 2019-08-30 Tom Tromey <tom@tromey.com>
5261 * tui/tui-wingeneral.c (box_win): Assume win_info and
5262 win_info->handle cannot be NULL.
5264 2019-08-30 Tom Tromey <tom@tromey.com>
5266 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5267 refresh_window>: Declare.
5268 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5270 (tui_data_item_window::rerender): Rename from
5271 tui_display_register.
5272 (tui_data_item_window::refresh_window): New method.
5273 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5276 2019-08-30 Tom Tromey <tom@tromey.com>
5278 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5279 regs_column_count, current_group>: Move later. Now private.
5280 <get_current_group>: New method.
5281 * tui/tui-regs.c (tui_reg_command): Update.
5282 * tui/tui-layout.c (tui_set_layout): Update.
5284 2019-08-30 Tom Tromey <tom@tromey.com>
5286 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5287 (tui_data_window::rerender): Don't call
5288 check_and_display_highlight_if_needed.
5289 (tui_data_window::refresh_all): Remove call to
5292 2019-08-30 Tom Tromey <tom@tromey.com>
5294 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5295 (tui_data_window::display_registers_from)
5296 (tui_data_window::display_reg_element_at_line)
5297 (tui_data_window::display_registers_from_line): Remove checks of
5300 2019-08-30 Tom Tromey <tom@tromey.com>
5302 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5304 * tui/tui-regs.c (tui_data_window::show_registers): Call
5306 (tui_data_window::rerender): Rename from display_all_data.
5307 (tui_data_window::rerender): Remove old implementation.
5309 2019-08-30 Tom Tromey <tom@tromey.com>
5311 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5313 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5315 2019-08-29 Bernhard Wodok <barto@gmx.net>
5316 Sergio Durigan Junior <sergiodj@redhat.com>
5319 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5321 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5323 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5324 when searching for types.
5326 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5328 * f-lang.c (f_language_defn): Use f_print_typedef.
5329 * f-lang.h (f_print_typedef): Declare.
5330 * f-typeprint.c (f_print_typedef): Define.
5332 2019-08-27 Christian Biesinger <cbiesinger@google.com>
5334 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5336 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5338 * cli/cli-utils.c (info_print_options_defs): Delete.
5339 (make_info_print_options_def_group): Delete.
5340 (extract_info_print_options): Delete.
5341 (info_print_command_completer): Delete.
5342 (info_print_args_help): Add extra parameter, and optionally
5343 include text about -n flag.
5344 * cli/cli-utils.h (struct info_print_options): Delete.
5345 (extract_info_print_options): Delete declaration.
5346 (info_print_command_completer): Delete declaration.
5347 (info_print_args_help): Add extra parameter, extend header
5349 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5351 * stack.c (struct info_print_options): New type.
5352 (info_print_options_defs): New file scoped variable.
5353 (make_info_print_options_def_group): New static function.
5354 (info_print_command_completer): New static function.
5355 (info_locals_command): Update to use new local functions.
5356 (info_args_command): Likewise.
5357 (_initialize_stack): Add extra parameter to calls to
5358 info_print_args_help.
5359 * symtab.c (search_symbols): Add extra parameter, use this to
5360 possibly excluse non-debug symbols.
5361 (symtab_symbol_info): Add extra parameter, which is passed on to
5363 (struct info_print_options): New type.
5364 (info_print_options_defs): New file scoped variable.
5365 (make_info_print_options_def_group): New static function.
5366 (info_print_command_completer): New static function.
5367 (info_variables_command): Update to use local functions, and pass
5368 extra parameter through to symtab_symbol_info.
5369 (info_functions_command): Likewise.
5370 (info_types_command): Pass additional argument through to
5372 (rbreak_command): Pass extra argument to search_symbols.
5373 (_initialize_symtab): Add extra arguments for calls to
5374 info_print_args_help, and update help text for 'info variables',
5375 'whereis', and 'info functions' commands.
5376 * symtab.h (search_symbols): Add extra argument to declaration.
5377 * NEWS: Mention new flags.
5379 2019-08-26 Christian Biesinger <cbiesinger@google.com>
5381 * symtab.c (lookup_static_symbol): Call the new function (and move
5382 it down to be next to lookup_global_symbol).
5383 (struct global_sym_lookup_data): Add block_enum member and rename to...
5384 (struct global_or_static_sym_lookup_data): ...this.
5385 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5386 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5387 (lookup_symbol_global_or_static_iterator_cb): ...this.
5388 (lookup_global_or_static_symbol): New function.
5389 (lookup_global_symbol): Call new function.
5391 2019-08-26 Tom de Vries <tdevries@suse.de>
5394 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5395 when pc_probe.prob == NULL.
5397 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
5399 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5400 variable symbol_linkage to symbol_linkage_.
5402 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
5404 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5405 represent whether the symbol is static, dynamic, or we don't
5408 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5410 * gdb/rx-tdep.c (rx_register_names): New.
5411 (rx_register_name): Delete.
5412 (rx_psw_type): Delete.
5413 (rx_fpsw_type): Delete.
5414 (rx_register_type): Delete.
5415 (rx_gdbarch_init): Convert target-descriptions.
5416 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5417 * gdb/features/Makefile: Add rx.xml.
5418 * gdb/features/rx.xml: New.
5419 * gdb/features/rx.c: Generated.
5420 * gdb/NEWS: Mention target description support.
5422 2019-08-22 Christian Biesinger <cbiesinger@google.com>
5424 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5427 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5429 * configure.ac: Don't check for 'dlfcn.h' (moved to
5430 gdbsupport/common.m4).
5431 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5433 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5434 * compile/compile-c-support.c: Include
5435 'gdbsupport/gdb-dlfcn.h'.
5436 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5437 * gdb-dlfcn.c: Move to...
5438 * gdbsupport/gdb-dlfcn.c: ... here.
5439 * gdb-dlfcn.h: Move to...
5440 * gdbsupport/gdb-dlfcn.h: ... here.
5442 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5444 * nios2-tdep.c (struct reg_value): Improve comments. Make
5445 the offset field signed.
5447 2019-08-22 Christian Biesinger <cbiesinger@google.com>
5449 * python/lib/gdb/__init__.py (_execute_file): New function.
5450 * python/python.c (python_run_simple_file): Call gdb._execute_file
5453 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5455 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5456 all uses as this was never set to anything but a zero value.
5458 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5460 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5462 2019-08-21 Christian Biesinger <cbiesinger@google.com>
5464 * tui/tui-data.h (tui_gen_win_info): Add an =default
5465 move constructor, required by some GCC versions.
5467 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
5469 * go32-nat.c (go32_sysinfo): Add hygon_p.
5471 2019-08-20 Tom Tromey <tom@tromey.com>
5473 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5474 line_from_reg_element_no, first_reg_element_no_inline,
5475 display_all_data, delete_data_content_windows,
5476 erase_data_content>: Now private.
5478 2019-08-20 Tom Tromey <tom@tromey.com>
5480 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5481 (tui_unhighlight_win, tui_highlight_win)
5482 (tui_win_info::make_window): Update.
5483 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5485 2019-08-20 Tom Tromey <tom@tromey.com>
5487 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5488 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5489 (MAX_PID_WIDTH): Move to tui-stack.c.
5490 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5491 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5492 (MAX_PID_WIDTH): Move from tui-data.h.
5494 2019-08-20 Tom Tromey <tom@tromey.com>
5496 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5497 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5499 (tui_gen_win_info::make_window): Rename from tui_make_window.
5500 (tui_win_info::make_window): New method.
5501 (tui_gen_win_info::make_visible): Update.
5502 * tui/tui-source.c (tui_source_window::set_contents): Update.
5503 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5504 (tui_data_window::display_registers_from): Update.
5505 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5506 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5510 (struct tui_win_info) <make_window>: Declare.
5511 <can_box>: Now virtual.
5512 <title>: New member.
5513 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5514 * tui/tui-command.c (tui_cmd_window::resize): Update.
5516 2019-08-20 Tom Tromey <tom@tromey.com>
5518 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5519 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5520 (tui_data_window::check_register_values): Update.
5522 2019-08-20 Tom Tromey <tom@tromey.com>
5524 * tui/tui-regs.h (struct tui_data_window): Use
5525 DISABLE_COPY_AND_ASSIGN.
5526 <regs_content>: Change type, removing unique_ptr.
5527 <tui_data_window>: Add move constructor.
5528 * tui/tui-regs.c (tui_data_window::show_registers)
5529 (tui_data_window::show_register_group)
5530 (tui_data_window::display_registers_from)
5531 (tui_data_window::display_registers_from)
5532 (tui_data_window::first_data_item_displayed)
5533 (tui_data_window::delete_data_content_windows)
5534 (tui_data_window::rerender, tui_data_window::refresh_window)
5535 (tui_data_window::check_register_values): Update.
5537 2019-08-20 Tom Tromey <tom@tromey.com>
5539 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5540 show_register_group>: Declare.
5541 (tui_show_register_group): Don't declare.
5542 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5544 (tui_data_window::show_register_group): Rename from
5545 tui_show_register_group.
5546 (tui_data_window::check_register_values, tui_reg_command):
5548 * tui/tui-layout.c (tui_set_layout): Update.
5550 2019-08-20 Tom Tromey <tom@tromey.com>
5552 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5554 (tui_check_register_values): Don't declare.
5555 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5556 from tui_check_register_values.
5557 * tui/tui-hooks.c (tui_register_changed): Update.
5559 2019-08-20 Tom Tromey <tom@tromey.com>
5561 * tui/tui-regs.c (tui_reg_layout): Move later.
5562 (tui_show_registers): Don't enable TUI mode or change layout.
5564 2019-08-20 Tom Tromey <tom@tromey.com>
5566 * tui/tui-regs.h (struct tui_data_item_window)
5567 <~tui_data_item_window>: Remove.
5568 <content>: Now a unique_xmalloc_ptr.
5569 * tui/tui-regs.c (tui_register_format): Return a
5571 (tui_get_register): Update.
5572 (~tui_data_item_window): Remove.
5573 (tui_data_window::display_registers_from, tui_display_register):
5575 * tui/tui-io.h (tui_expand_tabs): Update.
5576 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5577 Remove "col" parameter.
5579 2019-08-20 Tom Tromey <tom@tromey.com>
5581 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5583 * tui/tui-regs.c (~tui_data_item_window): Update.
5585 2019-08-20 Tom Tromey <tom@tromey.com>
5587 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5590 2019-08-20 Tom Tromey <tom@tromey.com>
5592 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5594 2019-08-20 Tom Tromey <tom@tromey.com>
5596 * tui/tui-source.h (struct tui_source_window): Update.
5597 * tui/tui-regs.c (tui_show_registers): Update.
5598 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5599 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5600 (NO_REGS_STRING): Remove defines.
5602 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
5604 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5605 unnecessary thread walk if remote doesn't support the packet.
5607 2019-08-19 Tom Tromey <tromey@adacore.com>
5609 * python/py-value.c (value_has_field): Fix indentation.
5611 2019-08-19 Tom Tromey <tromey@adacore.com>
5613 * printcmd.c (do_one_display, info_display_command): Update.
5614 * block.h (contained_in): Return bool. Add allow_nested
5616 * block.c (contained_in): Return bool. Add allow_nested
5619 2019-08-19 Tom Tromey <tom@tromey.com>
5621 * configure: Rebuild.
5622 * configure.ac: Disallow the combination of -static-libstdc++ and
5624 * source-cache.c (get_language_name): Handle rust.
5625 (source_cache::get_source_lines): Ignore highlighting exceptions.
5627 2019-08-16 Tom Tromey <tom@tromey.com>
5629 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5630 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5631 (struct tui_source_window_base) <make_visible, refresh_window,
5632 resize>: Remove methods.
5633 <execution_info>: Remove field.
5634 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5635 (tui_show_source_line, tui_source_window_base)
5636 (~tui_source_window_base): Update.
5637 (tui_source_window_base::resize)
5638 (tui_source_window_base::make_visible)
5639 (tui_source_window_base::refresh_window): Remove.
5640 (tui_source_window_base::update_exec_info): Update.
5641 * tui/tui-source.c (tui_source_window::set_contents): Update.
5642 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5644 2019-08-16 Tom Tromey <tom@tromey.com>
5646 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5647 deprecated_query_hook.
5649 2019-08-16 Tom Tromey <tom@tromey.com>
5651 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5652 (tui_update_source_windows_with_line): Update.
5653 * tui/tui-source.h (struct tui_source_window)
5654 <show_symtab_source>: Declare.
5655 (tui_show_symtab_source): Don't declare.
5656 * tui/tui-source.c (tui_show_symtab_source): Rename from
5657 tui_show_symtab_source.
5659 2019-08-16 Tom Tromey <tom@tromey.com>
5661 * tui/tui-winsource.h (struct tui_source_window_base)
5662 <set_contents>: Declare.
5663 * tui/tui-winsource.c
5664 (tui_source_window_base::update_source_window_as_is): Update.
5665 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5667 (tui_set_source_content): Don't declare.
5668 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5669 tui_set_source_content.
5670 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5672 (tui_set_disassem_content): Don't declare.
5673 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5674 tui_set_disassem_content.
5676 2019-08-16 Tom Tromey <tom@tromey.com>
5678 * tui/tui-winsource.h (struct tui_source_window_base)
5679 <update_breakpoint_info>: Declare.
5680 (tui_update_breakpoint_info): Don't declare.
5681 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5682 (tui_update_all_breakpoint_info): Update.
5683 (tui_source_window_base::update_breakpoint_info): Rename from
5684 tui_update_breakpoint_info.
5685 (tui_source_window_base::update_exec_info): Update.
5687 2019-08-16 Tom Tromey <tom@tromey.com>
5689 * tui/tui-winsource.h (struct tui_source_window_base)
5690 <update_source_window>: Declare.
5691 (tui_update_source_window): Don't declare.
5692 * tui/tui-winsource.c
5693 (tui_source_window_base::update_source_window): Rename from
5694 tui_update_source_window.
5695 (tui_source_window_base::rerender): Update.
5696 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5697 * tui/tui-disasm.c (tui_show_disassem)
5698 (tui_show_disassem_and_update_source)
5699 (tui_disasm_window::maybe_update): Update.
5701 2019-08-16 Tom Tromey <tom@tromey.com>
5703 * tui/tui-winsource.h (struct tui_source_window_base)
5704 <update_source_window_as_is>: Declare.
5705 (tui_update_source_window_as_is): Don't declare.
5706 * tui/tui-winsource.c (tui_update_source_window): Update
5707 (tui_source_window_base::update_source_window_as_is): Rename from
5708 tui_update_source_window_as_is.
5709 (tui_source_window_base::refill): Update.
5710 * tui/tui-source.c (tui_show_symtab_source): Update.
5711 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5714 2019-08-16 Tom Tromey <tom@tromey.com>
5716 * tui/tui-winsource.h (tui_update_source_window)
5717 (tui_update_source_window_as_is): Remove "noerror" parameter.
5718 * tui/tui-winsource.c (tui_update_source_window)
5719 (tui_update_source_window_as_is): Remove "noerror" parameter.
5720 (tui_update_source_windows_with_addr)
5721 (tui_update_source_windows_with_line)
5722 (tui_source_window_base::rerender)
5723 (tui_source_window_base::refill): Update.
5724 * tui/tui-source.h (tui_set_source_content)
5725 (tui_show_symtab_source): Remove "noerror" parameter.
5726 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5728 (tui_show_symtab_source): Likewise.
5729 (tui_source_window::maybe_update): Update.
5730 * tui/tui-disasm.c (tui_show_disassem)
5731 (tui_show_disassem_and_update_source)
5732 (tui_disasm_window::do_scroll_vertical)
5733 (tui_disasm_window::maybe_update): Update.
5735 2019-08-16 Tom Tromey <tom@tromey.com>
5737 * tui/tui.c (tui_is_window_visible): Update.
5738 * tui/tui-wingeneral.c (tui_make_window)
5739 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5740 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5741 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5742 (tui_set_win_height_command, parse_scrolling_args): Update.
5743 * tui/tui-source.c (tui_source_window::style_changed): Update.
5744 * tui/tui-regs.c (tui_show_registers)
5745 (tui_data_window::first_data_item_displayed)
5746 (tui_data_window::delete_data_content_windows)
5747 (tui_check_register_values, tui_reg_command): Update.
5748 * tui/tui-disasm.c (tui_show_disassem): Update.
5749 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5751 <is_visible>: Remove field.
5752 * tui/tui-data.c (tui_next_win, tui_prev_win)
5753 (tui_delete_invisible_windows): Update.
5755 2019-08-16 Tom Tromey <tom@tromey.com>
5757 * tui/tui-winsource.h (struct tui_source_window_base)
5758 <m_has_locator>: Remove.
5759 * tui/tui-layout.c (show_source_disasm_command, show_data)
5760 (show_source_or_disasm_and_command): Update.
5762 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5764 * NEWS (Other MI changes): New subsection.
5765 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5766 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5767 * arch-utils.c (default_get_pc_address_flags): New function.
5768 * arch-utils.h (default_get_pc_address_flags): New declaration.
5769 * gdbarch.sh: Add get_pc_address_flags.
5770 * gdbarch.c: Regenerate.
5771 * gdbarch.h: Likewise.
5772 * stack.c (print_pc): New function.
5773 (print_frame_info) (print_frame): Call print_pc.
5775 2019-08-16 Tom de Vries <tdevries@suse.de>
5777 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5778 print_objfile_section_info.
5780 2019-08-15 Tom Tromey <tom@tromey.com>
5782 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5783 calling update_cmdwin_start_line.
5784 * tui/tui-winsource.h (struct tui_source_window_base)
5785 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5786 <rerender>: Declare.
5787 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5789 (tui_source_window_base::set_new_height): Remove.
5790 (tui_source_window_base::rerender): Rename from
5791 do_make_visible_with_new_height.
5792 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5794 (tui_win_info::make_invisible_and_set_new_height)
5795 (tui_win_info::make_visible_with_new_height): Remove.
5796 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5798 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5799 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5800 do_make_visible_with_new_height>: Don't declare.
5801 <rerender>: Declare.
5802 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5804 (tui_data_window::do_make_visible_with_new_height): Remove.
5805 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5806 call tui_show_locator_content.
5807 (tui_gen_win_info::resize): Call rerender.
5808 (show_source_or_disasm_and_command): Don't call
5809 tui_show_locator_content.
5810 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5812 (struct tui_win_info) <rerender>: Declare.
5813 <set_new_height, make_invisible_and_set_new_height,
5814 make_visible_with_new_height>: Don't declare.
5815 * tui/tui-data.c (tui_win_list::rerender): New method.
5816 * tui/tui-command.h (struct tui_cmd_window)
5817 <do_make_visible_with_new_height>: Don't declare.
5819 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5821 2019-08-15 Tom Tromey <tromey@adacore.com>
5823 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5824 * ada-lang.c (ada_enum_name): Likewise.
5826 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5828 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5830 (GdbOutputErrorFile): Likewise.
5831 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5833 (execute_unwinders): Rename to have a leading underscore.
5834 (auto_load_packages): Likewise.
5835 (global scope): Adjust call to auto_load_packages accordingly.
5836 (GdbSetPythonDirectory): Likewise.
5837 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5838 instead of execute_unwinders.
5840 2019-08-15 Tom Tromey <tom@tromey.com>
5842 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5843 (show_data): Don't change window visibility.
5844 (tui_gen_win_info::resize): Remove special case for command
5845 window. Use wresize, when available.
5846 (show_source_or_disasm_and_command): Don't change window
5848 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5849 <make_visible>: New method.
5850 * tui/tui-command.c (tui_cmd_window::resize): New method.
5852 2019-08-15 Tom Tromey <tom@tromey.com>
5854 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5855 (struct tui_source_windows): New.
5856 * tui/tui-winsource.c (tui_display_main): Update.
5857 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5858 (new_height_ok, parse_scrolling_args): Update.
5859 * tui/tui-layout.c (show_layout, show_data): Update.
5860 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5861 (tui_add_to_source_windows): Don't declare.
5862 * tui/tui-data.c (source_windows, tui_source_windows)
5863 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5865 2019-08-15 Tom Tromey <tom@tromey.com>
5867 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5869 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5870 * tui/tui-layout.c (show_source_disasm_command, show_data):
5872 (tui_gen_win_info::resize): Rename.
5873 (show_source_or_disasm_and_command): Update.
5874 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5877 2019-08-15 Tom Tromey <tom@tromey.com>
5879 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5880 * tui/tui-interp.c (tui_interp::init): Don't call
5881 tui_initialize_static_data.
5882 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5884 2019-08-15 Tom Tromey <tom@tromey.com>
5886 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5887 examine tui_win_list.
5889 2019-08-15 Tom Tromey <tom@tromey.com>
5891 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5892 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5893 tui_clear_source_content.
5894 (tui_clear_source_content): Remove.
5895 (tui_source_window_base::do_erase_source_content): Hoist call to
5897 * tui/tui-stack.c (tui_show_frame_info): Don't call
5898 tui_clear_source_content.
5900 2019-08-15 Tom Tromey <tom@tromey.com>
5902 * tui/tui-winsource.h (struct tui_source_window_base)
5903 <do_erase_source_content>: New method.
5904 <erase_source_content>: New method.
5905 (tui_erase_source_content): Don't declare.
5906 * tui/tui-winsource.c (tui_clear_source_content): Update.
5907 (tui_source_window_base::do_erase_source_content): Rename from
5908 tui_erase_source_content.
5909 (tui_source_window_base::show_source_content): Update.
5910 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5911 * tui/tui-source.h (struct tui_source_window)
5912 <erase_source_content>: New method.
5913 * tui/tui-disasm.h (struct tui_disasm_window)
5914 <erase_source_content>: New method.
5916 2019-08-15 Tom Tromey <tom@tromey.com>
5918 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5919 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5921 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5922 * tui/tui-source.c (tui_set_source_content): Update.
5923 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5925 2019-08-15 Tom Tromey <tom@tromey.com>
5927 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5928 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5930 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5932 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5934 (tui_source_window::maybe_update): Update.
5936 2019-08-15 Tom Tromey <tom@tromey.com>
5938 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5939 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5941 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5943 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5945 (tui_disasm_window::maybe_update): Update.
5947 2019-08-15 Tom Tromey <tom@tromey.com>
5949 * tui/tui-winsource.h (struct tui_source_window_base)
5950 <maybe_update>: Declare.
5951 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5953 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5955 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5956 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5958 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5960 2019-08-15 Tom Tromey <tom@tromey.com>
5962 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5964 2019-08-15 Tom Tromey <tom@tromey.com>
5966 * tui/tui-wingeneral.c: Include tui-stack.h.
5967 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5968 (struct tui_locator_window): Move from tui-data.h.
5969 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5970 (tui_initialize_static_data): Move from tui-data.c.
5971 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5972 (struct tui_locator_window): Move to tui-stack.c.
5973 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5974 (tui_initialize_static_data): Move to tui-stack.c.
5976 2019-08-15 Tom Tromey <tom@tromey.com>
5978 * tui/tui-layout.c (show_source_disasm_command)
5979 (show_source_or_disasm_and_command): Use make_visible method, not
5981 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5984 2019-08-15 Tom Tromey <tom@tromey.com>
5986 * tui/tui-wingeneral.h (tui_make_window): Update.
5987 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5989 (tui_gen_win_info::make_visible): Update.
5990 * tui/tui-regs.c (tui_data_window::display_registers_from):
5992 * tui/tui-layout.c (show_source_disasm_command)
5993 (show_source_or_disasm_and_command): Update.
5994 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5995 (enum tui_box): Remove.
5996 (struct tui_win_info) <can_box>: New method.
5997 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
6000 2019-08-15 Tom de Vries <tdevries@suse.de>
6002 * linux-nat-trad.c: Include gdbarch.h.
6004 2019-08-14 Alan Hayward <alan.hayward@arm.com>
6006 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
6009 2019-08-14 Tom Tromey <tromey@adacore.com>
6011 * darwin-nat.c: Include gdbarch.h.
6012 * darwin-nat-info.c: Include gdbarch.h.
6014 2019-08-13 Tom Tromey <tom@tromey.com>
6016 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
6018 * tui/tui-data.c (tui_initialize_static_data): Update.
6020 2019-08-13 Tom Tromey <tom@tromey.com>
6022 * tui/tui-winsource.h (struct tui_exec_info_window)
6023 <~tui_exec_info_window, maybe_allocate_content, get_content,
6025 (struct tui_source_window_base) <set_exec_info_content,
6026 show_exec_info_content>: Don't declare.
6027 * tui/tui-winsource.c
6028 (tui_exec_info_window::maybe_allocate_content): Remove.
6029 (tui_source_window_base::update_exec_info): Rename from
6030 set_exec_info_content.
6031 (tui_source_window_base::show_exec_info_content)
6032 (tui_source_window_base::update_exec_info): Remove.
6034 2019-08-13 Tom Tromey <tom@tromey.com>
6036 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6038 * tui/tui-winsource.c (tui_update_source_window_as_is)
6039 (tui_update_source_windows_with_addr, tui_erase_source_content):
6041 (tui_clear_exec_info_content): Remove.
6043 2019-08-13 Tom Tromey <tom@tromey.com>
6045 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6047 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6048 call tui_erase_exec_info_content.
6049 (tui_clear_exec_info_content): Rename from
6050 tui_erase_exec_info_content.
6051 (tui_clear_exec_info_content): Delete.
6053 2019-08-13 Tom Tromey <tom@tromey.com>
6055 * tui/tui-winsource.h (struct tui_source_window_base)
6056 <show_exec_info_content>: Declare.
6057 (tui_show_exec_info_content): Don't declare.
6058 * tui/tui-winsource.c
6059 (tui_source_window_base::show_exec_info_content): Rename from
6060 tui_show_exec_info_content.
6061 (tui_source_window_base::update_exec_info): Update.
6063 2019-08-13 Tom Tromey <tom@tromey.com>
6065 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6066 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6067 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6068 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6069 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6070 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6073 2019-08-13 Tom Tromey <tom@tromey.com>
6075 * tui/tui-winsource.h (struct tui_source_window_base)
6076 <update_exec_info>: Declare.
6077 (tui_update_exec_info): Don't declare.
6078 * tui/tui-winsource.c (tui_update_source_window_as_is)
6079 (tui_source_window_base::refresh_all)
6080 (tui_update_all_breakpoint_info): Update.
6081 (tui_source_window_base::update_exec_info): Rename from
6082 tui_update_exec_info.
6083 * tui/tui-stack.c (tui_show_frame_info): Update.
6085 2019-08-13 Tom Tromey <tom@tromey.com>
6087 * tui/tui-winsource.h (struct tui_source_window_base)
6088 <set_exec_info_content>: Declare.
6089 (tui_set_exec_info_content): Don't declare.
6090 * tui/tui-winsource.c
6091 (tui_source_window_base::set_exec_info_content): Rename from
6092 tui_set_exec_info_content.
6093 (tui_update_exec_info): Update.
6095 2019-08-13 Tom Tromey <tom@tromey.com>
6097 * tui/tui-winsource.h (struct tui_source_window_base)
6098 <show_source_content>: Declare.
6099 (tui_show_source_content): Don't declare.
6100 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6101 (tui_source_window_base::show_source_content): Rename from
6102 tui_show_source_content.
6103 (tui_source_window_base::refresh_all): Update.
6104 * tui/tui-layout.c (show_source_disasm_command)
6105 (show_source_or_disasm_and_command): Update.
6107 2019-08-13 Tom Tromey <tom@tromey.com>
6109 * tui/tui-winsource.c (tui_erase_source_content)
6110 (tui_show_source_content, tui_source_window_base::refresh_all):
6112 * tui/tui-wingeneral.h
6113 (tui_check_and_display_highlight_if_needed): Don't declare.
6114 * tui/tui-wingeneral.c
6115 (tui_win_info::check_and_display_highlight_if_needed): Rename from
6116 check_and_display_highlight_if_needed.
6117 * tui/tui-win.c (tui_rehighlight_all)
6118 (tui_win_info::make_visible_with_new_height): Update.
6119 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6120 (tui_data_window::erase_data_content)
6121 (tui_data_window::display_all_data): Update.
6122 * tui/tui-data.h (struct tui_win_info)
6123 <check_and_display_highlight_if_needed>: Declare.
6125 2019-08-13 Tom Tromey <tom@tromey.com>
6127 * tui/tui-win.c (tui_resize_all): Call
6128 tui_delete_invisible_windows.
6129 * tui/tui-layout.c (show_layout): Call
6130 tui_delete_invisible_windows.
6131 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6132 * tui/tui-data.c (tui_delete_invisible_windows): New function.
6134 2019-08-13 Tom Tromey <tom@tromey.com>
6136 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
6137 tui_add_win_to_layout.
6139 2019-08-13 Tom Tromey <tom@tromey.com>
6141 * tui/tui-layout.h (tui_default_win_height): Don't declare.
6142 * tui/tui-layout.c (tui_default_win_height): Now static.
6144 2019-08-13 Tom Tromey <tom@tromey.com>
6146 * tui/tui-layout.c (show_layout): Unify all layout cases into a
6148 (show_source_disasm_command, show_source_or_disasm_and_command):
6149 Don't check current layout.
6151 2019-08-13 Tom Tromey <tom@tromey.com>
6153 * tui/tui-wingeneral.c (make_all_visible): Remove.
6154 (tui_make_all_invisible): Simplify.
6155 * tui/tui-layout.c (tui_make_all_invisible): Move from
6156 tui-wingeneral.c; simplify.
6157 (show_layout): Hoist call to tui_make_all_invisible.
6158 (show_data): Don't call tui_make_all_invisible.
6160 2019-08-13 Tom Tromey <tom@tromey.com>
6162 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6163 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6165 2019-08-13 Tom Tromey <tom@tromey.com>
6167 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6169 (show_source_disasm_command, show_data)
6170 (show_source_or_disasm_and_command): Don't use
6171 tui_set_current_layout_to.
6172 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6173 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6175 (tui_set_current_layout_to): Remove.
6177 2019-08-13 Tom Tromey <tom@tromey.com>
6179 * tui/tui-layout.c (tui_set_layout): Update.
6180 * tui/tui-data.h (struct tui_layout_def): Remove.
6181 (tui_layout_def): Don't declare.
6182 * tui/tui-data.c (layout_def): Remove.
6183 (tui_layout_def): Remove.
6185 2019-08-13 Tom Tromey <tom@tromey.com>
6187 * tui/tui-winsource.h (struct tui_source_window_base)
6188 <clear_detail>: No longer "override".
6189 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6190 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6191 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6192 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6194 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6196 2019-08-13 Tom Tromey <tromey@adacore.com>
6198 * tracepoint.c: Don't include readline.h or history.h.
6200 2019-08-12 Tom Tromey <tom@tromey.com>
6202 * configure: Rebuild.
6203 * configure.ac: Check for readline 7.
6204 * NEWS: Mention readline 7 requirement.
6207 2019-08-12 Tom Tromey <tom@tromey.com>
6209 * mingw-hdep.c (gdb_select): Remove readline hack.
6211 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6213 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6214 when the function fails.
6216 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6218 * s390-tdep.c (s390_type_align): New function.
6219 (s390_gdbarch_init): Set it as type_align gdbarch method.
6221 2019-08-09 Tom de Vries <tdevries@suse.de>
6224 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6225 pc_low with relocation offset.
6227 2019-08-07 Tom Tromey <tromey@adacore.com>
6229 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6230 (print_frame_args): Update.
6231 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6233 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6234 * frame.h (struct frame_arg): Add initializers.
6235 <error>: Now a unique_xmalloc_ptr.
6237 2019-08-07 Alan Hayward <alan.hayward@arm.com>
6239 * NEWS: Expand the Pointer Authentication entry.
6240 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6241 (aarch64_frame_unmask_lr): ... to this.
6242 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6243 Call aarch64_frame_unmask_lr.
6244 * frame.c (struct frame_info): Add "masked" variable.
6245 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6246 (fprint_frame): Check for masked pc.
6247 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6249 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6250 * stack.c (print_frame): Check for masked pc.
6252 2019-08-06 Tom Tromey <tom@tromey.com>
6254 * stabsread.c (patch_block_stabs, read_one_struct_field)
6255 (read_enum_type): Use obstack_strndup.
6256 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6257 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6258 * dwarf2read.c (guess_full_die_structure_name)
6259 (anonymous_struct_prefix): Use obstack_strndup.
6260 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6261 * c-exp.y (yylex): Use obstack_strndup.
6262 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6263 (write_var_or_type): Use obstack_strndup.
6265 2019-08-06 Tom Tromey <tom@tromey.com>
6267 * symfile.c (reread_symbols): Use obstack_strdup.
6268 * stabsread.c (read_type): Use obstack_strdup.
6269 * gdb_obstack.h (obstack_strdup): New overload.
6270 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6271 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6272 (dwarf2_canonicalize_name): Use obstack_strdup.
6273 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6274 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6277 2019-08-06 Tom Tromey <tom@tromey.com>
6279 * gdb_obstack.h (obstack_strdup): Define.
6280 * gdb_obstack.c (obstack_strdup): Don't define.
6282 2019-08-06 Tom Tromey <tom@tromey.com>
6284 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6286 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6288 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6289 * stabsread.c (common_block_start): Use obstack_strdup.
6290 * objfiles.c (set_objfile_main_name, objfile): Use
6292 * namespace.c (add_using_directive): Use obstack_strdup.
6293 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6294 * jit.c (finalize_symtab): Use obstack_strdup.
6295 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6296 (guess_partial_die_structure_name, partial_die_info::fixup)
6297 (dwarf2_name): Use obstack_strdup.
6298 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6300 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6301 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6303 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6305 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6307 * unittests/help-doc-selftests.c: New file.
6308 * Makefile.in: Add the new file.
6310 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6312 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6313 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6314 the full first line, except when FOR_VALUE_PREFIX. In this case,
6315 the trailing '.' is not output, and the first character is uppercased.
6316 (print_help_for_command): Update call to print_doc_line.
6317 (print_doc_of_command): Likewise.
6318 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6319 * cli/cli-option.c (append_indented_doc): Do not append newline.
6320 (build_help_option): Append newline after first appended_indented_doc
6321 only if a second call is done.
6322 (build_help): Append 2 new lines before each option, except the first
6324 * compile/compile.c (_initialize_compile): Add new lines after
6325 %OPTIONS%, when not at the end of the help.
6326 Change help doc or code
6327 producing the help doc to respect the invariants.
6328 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6329 Also removed the new line after 'Options:', as all other commands
6330 do not put an empty line between 'Options:' and the first option.
6331 * printcmd.c (_initialize_printcmd): Likewise.
6332 * stack.c (_initialize_stack): Likewise.
6333 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6334 incorrectly telling COMMAND is optional.
6335 * ada-lang.c (_initialize_ada_language): Change help doc or code
6336 producing the help doc to respect the invariants.
6337 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6338 * breakpoint.c (_initialize_breakpoint): Likewise.
6339 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6340 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6341 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6342 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6343 _initialize_cli_style): Likewise.
6344 * corelow.c (core_target_info): Likewise.
6345 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6346 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6347 * filesystem.c (_initialize_filesystem): Likewise.
6348 * frame.c (_initialize_frame): Likewise.
6349 * gnu-nat.c (add_task_commands): Likewise.
6350 * infcall.c (_initialize_infcall): Likewise.
6351 * infcmd.c (_initialize_infcmd): Likewise.
6352 * interps.c (_initialize_interpreter): Likewise.
6353 * language.c (_initialize_language): Likewise.
6354 * linux-fork.c (_initialize_linux_fork): Likewise.
6355 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6356 * maint.c (_initialize_maint_cmds): Likewise.
6357 * memattr.c (_initialize_mem): Likewise.
6358 * printcmd.c (_initialize_printcmd): Likewise.
6359 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6361 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6362 * record-btrace.c (_initialize_record_btrace): Likewise.
6363 * record-full.c (_initialize_record_full): Likewise.
6364 * record.c (_initialize_record): Likewise.
6365 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6366 * regcache.c (_initialize_regcache): Likewise.
6367 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6368 _initialize_remote): Likewise.
6369 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6370 * serial.c (_initialize_serial): Likewise.
6371 * skip.c (_initialize_step_skip): Likewise.
6372 * source.c (_initialize_source): Likewise.
6373 * stack.c (_initialize_stack): Likewise.
6374 * symfile.c (_initialize_symfile): Likewise.
6375 * symtab.c (_initialize_symtab): Likewise.
6376 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6377 * top.c (init_main): Likewise.
6378 * tracefile-tfile.c (tfile_target_info): Likewise.
6379 * tracepoint.c (_initialize_tracepoint): Likewise.
6380 * tui/tui-win.c (_initialize_tui_win): Likewise.
6381 * utils.c (add_internal_problem_command): Likewise.
6382 * valprint.c (value_print_option_defs): Likewise.
6384 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
6387 * configure.ac: Drop enable-libmcheck support.
6388 * configure, config.in: Rebuild.
6389 * libmcheck.m4: Remove.
6390 * acinclude.m4: Don't include it.
6391 * Makefile.in: Don't distribute it.
6392 * top.c (print_gdb_configuration): Don't mention it.
6394 2019-08-06 Tom Tromey <tom@tromey.com>
6396 * utils.c (set_output_style): Sometimes pass stream to
6398 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6399 * record-btrace.c (btrace_insn_history): Update.
6400 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6402 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6403 Update initializers.
6404 <m_uiout>: New field.
6406 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6407 Remove "uiout" parameter.
6408 (dump_insns): Update.
6409 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6410 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6412 2019-08-06 Christian Biesinger <cbiesinger@google.com>
6414 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6415 (error_in_psymtab_expansion): Likewise.
6416 (lookup_symbol_via_quick_fns): Likewise.
6417 (basic_lookup_transparent_type_quick): Likewise.
6418 (basic_lookup_transparent_type_1): Likewise.
6420 2019-08-06 Tom Tromey <tromey@adacore.com>
6422 * source.c (last_source_error): Now bool.
6423 (print_source_lines_base): Make "noprint" bool. Only open
6424 source file when last_source_visited changes.
6426 2019-08-06 Tom Tromey <tromey@adacore.com>
6428 * annotate.c (annotate_source_line): Use g_source_cache.
6429 * source-cache.c (source_cache::get_plain_source_lines): Change
6430 parameters. Populate m_offset_cache.
6431 (source_cache::ensure): New method.
6432 (source_cache::get_line_charpos): New method.
6433 (extract_lines): Move lower. Change parameters.
6434 (source_cache::get_source_lines): Move lower.
6435 * source-cache.h (class source_cache): Update comment.
6436 <get_line_charpos>: New method.
6437 <get_source_lines>: Update comment.
6438 <clear>: Clear m_offset_cache.
6439 <get_plain_source_lines>: Change parameters.
6440 <ensure>: New method
6441 <m_offset_cache>: New member.
6442 * source.c (forget_cached_source_info_for_objfile): Update.
6443 (info_source_command): Use g_source_cache.
6444 (find_source_lines, open_source_file_with_line_charpos): Remove.
6445 (print_source_lines_base, search_command_helper): Use g_source_cache.
6446 * source.h (open_source_file_with_line_charpos): Don't declare.
6447 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6448 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6451 2019-08-06 Tom Tromey <tromey@adacore.com>
6453 * source-cache.c (source_cache::get_plain_source_lines):
6454 Remove "first_line" and "last_line" parameters.
6455 (source_cache::get_source_lines): Cache plain text.
6456 * source-cache.h (class source_cache)
6457 <get_plain_source_lines>: Update.
6459 2019-08-06 Tom Tromey <tromey@adacore.com>
6461 * source-cache.c (extract_lines): No longer a method.
6462 Changed type of parameter. Include final newline.
6463 (selftests::extract_lines_test): New function.
6464 (_initialize_source_cache): Likewise.
6465 * source-cache.h (class source_cache)
6466 <extract_lines>: Don't declare.
6468 2019-08-06 Tom Tromey <tromey@adacore.com>
6470 * breakpoint.c (init_breakpoint_sal): Update.
6471 (breakpoint): Update.
6472 * breakpoint.h (struct breakpoint) <filter>: Now a
6475 2019-08-05 Christian Biesinger <cbiesinger@google.com>
6477 * NEWS: Mention dictionary access on blocks.
6478 * python/py-block.c (blpy_getitem): New function.
6479 (block_object_as_mapping): New struct.
6480 (block_object_type): Use new struct for tp_as_mapping field.
6482 2019-08-05 Christian Biesinger <cbiesinger@google.com>
6484 * objfiles.h (objfile): Add a comment describing partial symbols.
6486 2019-08-05 Tom Tromey <tromey@adacore.com>
6488 * compile/compile.c (_initialize_compile): Use _(), not N_().
6489 * thread.c (_initialize_thread): Use _(), not N_().
6490 * stack.c (_initialize_stack): Use _(), not N_().
6491 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6493 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6495 * dwarf2read.c (struct dw2_symtab_iterator):
6496 <want_specific_block>: Remove.
6497 <block_index>: Change type to gdb::optional.
6498 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6499 change type of BLOCK_INDEX parameter to gdb::optional.
6500 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6501 (dw2_lookup_symbol): Don't pass argument for
6502 WANT_SPECIFIC_BLOCK.
6503 (dw2_expand_symtabs_for_function): Don't pass argument for
6504 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6505 (class dw2_debug_names_iterator)
6506 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6507 parameter, change BLOCK_INDEX type to gdb::optional.
6508 <m_want_specific_block>: Remove.
6509 <m_block_index>: Change type to gdb::optional.
6510 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6511 gdb::optional. Re-write in function of gdb::optional.
6512 (dw2_debug_names_lookup_symbol): Don't pass argument for
6513 WANT_SPECIFIC_BLOCK.
6514 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6515 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6518 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6520 * NEWS: Mention changes to "info sources" command.
6522 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6524 * symtab.c (filename_partial_match_opts): New struct type.
6525 (struct output_source_filename_data): New members
6526 regexp, c_regexp, partial_match.
6527 (output_source_filename): Use new members to decide to print file.
6528 (info_sources_option_defs): New variable.
6529 (make_info_sources_options_def_group, print_info_sources_header,
6530 info_sources_command_completer):
6532 (info_sources_command): Read new optional arguments.
6533 (_initialize_symtab): Update info sources help.
6535 2019-08-02 Alexandre Oliva <oliva@adacore.com>
6537 * ada-lang.c (exception_support_info_v0): Renamed from...
6538 (default_exception_support_info): ... this. Create new
6540 (ada_has_this_exception_support): Look up catch_handlers_sym.
6541 (ada_exception_support_info_sniffer): Try v0 after default.
6543 2019-08-01 Tom Tromey <tromey@adacore.com>
6545 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6548 2019-08-01 Christian Biesinger <cbiesinger@google.com>
6550 * s12z-tdep.c: Fix include path for s12z-opc.h.
6552 2019-08-01 Alan Hayward <alan.hayward@arm.com>
6554 * NEWS: Require GNU make 3.82.
6556 2019-07-16 Tom Tromey <tom@tromey.com>
6558 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6561 2019-07-30 Tom Tromey <tromey@adacore.com>
6563 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6565 2019-07-30 Kevin Buettner <kevinb@redhat.com>
6567 * printcmd.c (print_address_symbolic): Print negative offsets.
6568 (build_address_symbolic): Force signed arithmetic when computing
6571 2019-07-30 Christian Biesinger <cbiesinger@google.com>
6573 PR/24474: Add a function to lookup static variables.
6574 * NEWS: Mention this new function.
6575 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6576 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6577 * python/python.c (python_GdbMethods): Add new function.
6579 2019-07-29 Christian Biesinger <cbiesinger@google.com>
6581 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6582 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6583 (objfpy_lookup_static_symbol): New function.
6584 (objfile_object_methods): Add new functions.
6586 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6588 * NEWS: Mention 'set|show print frame-info'. Mention new
6589 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6590 backtrace argument. Mention that python frame filtering code
6591 is now consistent with what 'backtrace' command prints.
6593 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6595 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6597 (print_frame_info_auto, print_frame_info_source_line,
6598 print_frame_info_location, print_frame_info_source_and_location,
6599 print_frame_info_location_and_address, print_frame_info_short_location):
6601 (struct frame_print_options): New member print_frame_info.
6602 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6603 * stack.h (get_user_print_what_frame_info): New declaration.
6604 (frame_show_address): New declaration.
6605 * stack.c (print_frame_arguments_choices): New value 'presence'.
6606 (print_frame_info_auto, print_frame_info_source_line,
6607 print_frame_info_location, print_frame_info_source_and_location,
6608 print_frame_info_location_and_address, print_frame_info_short_location,
6609 print_frame_info_choices, print_frame_info_print_what): New definitions.
6610 (print_frame_args): Only print dots for args if print frame-arguments
6612 (frame_print_option_defs): New element for "frame-info".
6613 (get_user_print_what_frame_info): New function.
6614 (frame_show_address): Make non static. Move comment to stack.h.
6615 (print_frame_info_to_print_what): New function.
6616 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6617 to decide what to print.
6618 (backtrace_command_1): Handle the new print_frame_arguments_presence
6620 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6621 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6622 (py_print_frame): In non-mi mode, use LOCATION as default for
6623 print_what, similarly to frame information printed directly by
6624 backtrace command. Handle frame-info user option in non MI mode.
6626 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6628 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6629 Add case for debugging 32-bit target on 64-bit host. Revise
6632 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6634 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6635 instead of find_function_entry_range_from_pc.
6637 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6639 * stack.c (find_frame_funname): Remove code which preferred
6640 minsym over symtab sym in "certain pathological cases".
6642 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6643 parameter. Change type of "do_demangle" to bool.
6644 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6645 Pass suitable "prefer_sym_over_minsym" flag to
6646 build_address_symbolic(). Don't output "+" for negative offsets.
6647 * printcmd.c (print_address_symbolic): Update invocation of
6648 build_address_symbolic to include a "prefer_sym_over_minsym"
6650 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6651 Restrict cases in which use of minimal symbol is preferred to that
6652 of a found symbol. Update comments.
6654 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6655 for entry pc when entry pc is out of range for that FDE.
6657 2019-07-26 Brian Callahan <bcallah@openbsd.org>
6660 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6663 2019-07-25 Christian Biesinger <cbiesinger@google.com>
6665 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6666 this function's Python signature.
6669 2019-07-24 Christian Biesinger <cbiesinger@google.com>
6671 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6672 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6673 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6674 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6675 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6678 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6680 * h8300-tdep.c (h8300_register_name_common): New.
6681 h8300_register_name): Use h8300_register_name_common.
6682 (h8300s_register_name): Likewise.
6683 (h8300sx_register_name): Likewise.
6684 (h8300h_register_nam): New.
6685 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6688 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6690 * arm-tdep.c (arm_skip_cmse_entry): New function.
6691 (arm_is_sgstubs_section): New function.
6692 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6694 2019-07-22 Tom Tromey <tom@tromey.com>
6696 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6699 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6701 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6704 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6706 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6707 so that GDB doesn't match any msymbols when searching in the
6709 (print_symbol_info): Print using typedef_print or type_print based
6710 on the type of the symbol. Add updated FIXME comment moved from...
6711 (_initialize_symtab): ... move and update FIXME comment to above.
6713 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6715 * NEWS: Mention adding -q option to "info types".
6716 * symtab.c (struct info_types_options): New struct.
6717 (info_types_options_defs): New variable.
6718 (make_info_types_options_def_group): New function.
6719 (info_types_command): Use gdb::option framework to parse options.
6720 (info_types_command_completer): New function.
6721 (_initialize_symtab): Extend the help text on "info types" and
6722 register command completer.
6724 2019-07-21 Christian Biesinger <cbiesinger@google.com>
6726 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6727 (lookup_symbol_in_objfile): Change int to block_enum and add a
6728 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6730 2019-07-20 Christian Biesinger <cbiesinger@google.com>
6732 * MAINTAINERS (Write After Approval): Add self.
6734 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6736 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6737 instruction to the dummy code region.
6739 2019-07-19 Tom Tromey <tromey@adacore.com>
6741 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6742 (ARGSUSED, PARAMS, __func__): Remove rules.
6744 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6746 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6747 * features/arm/arm-with-iwmmxt.c: Remove.
6748 * features/arm/arm-with-iwmmxt.xml: Remove.
6749 * features/arm/arm-with-m-fpa-layout.c: Remove.
6750 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6751 * features/arm/arm-with-m-vfp-d16.c: Remove.
6752 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6753 * features/arm/arm-with-m.c: Remove.
6754 * features/arm/arm-with-m.xml: Remove.
6755 * features/arm/arm-with-neon.c: Remove.
6756 * features/arm/arm-with-neon.xml: Remove.
6757 * features/arm/arm-with-vfpv2.c: Remove.
6758 * features/arm/arm-with-vfpv2.xml: Remove.
6759 * features/arm/arm-with-vfpv3.c: Remove.
6760 * features/arm/arm-with-vfpv3.xml: Remove.
6762 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6764 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6766 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6768 * arch/aarch32.c (aarch32_create_target_description): Create
6769 target descriptions using features.
6770 * arch/arm.c (arm_create_target_description)
6771 (arm_create_mprofile_target_description): Likewise.
6772 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6774 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6776 * Makefile.in: Add new files.
6777 * aarch32-tdep.c: New file.
6778 * aarch32-tdep.h: New file.
6779 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6780 Call aarch32_read_description.
6781 * arch/aarch32.c: New file.
6782 * arch/aarch32.h: New file.
6783 * arch/arm.c (arm_create_target_description)
6784 (arm_create_mprofile_target_description): New function.
6785 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6786 (arm_create_target_description)
6787 (arm_create_mprofile_target_description): New declaration.
6788 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6789 read_description functions.
6790 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6792 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6793 * arm-tdep.c (tdesc_arm_list): New variable.
6794 (arm_register_g_packet_guesses): Call create description functions.
6795 (arm_read_description) (arm_read_mprofile_description): New
6797 * arm-tdep.h (arm_read_description)
6798 (arm_read_mprofile_description): Add declaration.
6799 * configure.tgt: Add new files.
6801 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6803 * top.c (new_ui_command): Open specified terminal just once.
6805 2019-07-18 Tom Tromey <tromey@adacore.com>
6807 * symtab.c (main_name): Constify return type.
6808 * symfile.c (set_initial_language): Update.
6809 * symtab.h (main_name): Constify return type.
6811 2019-07-17 Tom Tromey <tom@tromey.com>
6813 * tui/tui-winsource.c (tui_update_source_window)
6814 (tui_update_source_window_as_is)
6815 (tui_update_source_windows_with_line): Remove return.
6816 * tui/tui-disasm.c (tui_show_disassem)
6817 (tui_show_disassem_and_update_source): Remove return.
6818 * tui/tui.c (tui_reset): Remove return.
6819 * tui/tui-wingeneral.c
6820 (tui_check_and_display_highlight_if_needed): Remove return.
6822 2019-07-17 Tom Tromey <tom@tromey.com>
6824 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6826 2019-07-17 Tom Tromey <tom@tromey.com>
6828 * tui/tui-winsource.h (struct tui_exec_info_window)
6829 (struct tui_source_window_base): Move from tui-data.h.
6830 * tui/tui-winsource.c: Move many method definitions from
6831 elsewhere. Remove "structuring" comments.
6832 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6833 (tui_source_window_base::refresh_window): Move to
6835 * tui/tui-win.c (tui_source_window_base::refresh_all)
6836 (tui_source_window_base::update_tab_width)
6837 (tui_source_window_base::set_new_height)
6838 (tui_source_window_base::do_make_visible_with_new_height): Move to
6840 * tui/tui-source.h: Update.
6841 * tui/tui-source.c (tui_source_window_base::reset): Move to
6843 * tui/tui-disasm.h: Update.
6844 * tui/tui-data.h (struct tui_exec_info_window): Move to
6846 (struct tui_source_window_base): Likewise.
6847 * tui/tui-data.c (tui_source_window_base::clear_detail)
6848 (tui_source_window_base, ~tui_source_window_base): Move to
6851 2019-07-17 Tom Tromey <tom@tromey.com>
6853 * tui/tui-win.c (tui_resize_all)
6854 (tui_source_window_base::update_tab_width)
6855 (tui_adjust_win_heights): Update.
6856 (tui_win_info::make_invisible_and_set_new_height): Rename from
6857 make_invisible_and_set_new_height.
6858 * tui/tui-data.h (struct tui_win_info)
6859 <make_invisible_and_set_new_height>: New method.
6861 2019-07-17 Tom Tromey <tom@tromey.com>
6863 * tui/tui.c: Update.
6864 * tui/tui-source.h (struct tui_source_window): Move from
6866 * tui/tui-layout.c: Update.
6867 * tui/tui-disasm.c: Update.
6868 * tui/tui-data.h (struct tui_source_window): Move to
6871 2019-07-17 Tom Tromey <tom@tromey.com>
6873 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6875 * tui/tui-data.h (struct tui_disasm_window): Move to
6878 2019-07-17 Tom Tromey <tom@tromey.com>
6880 * tui/tui-regs.h (struct tui_data_item_window): Move from
6882 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6883 * tui/tui-data.h (struct tui_data_item_window): Move to
6885 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6887 2019-07-17 Tom Tromey <tom@tromey.com>
6889 * tui/tui.c: Update.
6890 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6891 (tui_cmd_window::max_height): Move to tui-command.c.
6892 * tui/tui-layout.c: Update.
6893 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6894 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6896 * tui/tui-command.h (struct tui_cmd_window): Move from
6898 * tui/tui-command.c: Remove "structuring" comments.
6899 (tui_cmd_window::clear_detail)
6900 (tui_cmd_window::do_make_visible_with_new_height)
6901 (tui_cmd_window::max_height): Move from elsewhere.
6903 2019-07-17 Tom Tromey <tom@tromey.com>
6905 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6907 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6908 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6910 2019-07-17 Tom Tromey <tom@tromey.com>
6912 * tui/tui.c: Update.
6913 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6915 * tui/tui-windata.h: Remove file.
6916 * tui/tui-windata.c: Remove file.
6917 * tui/tui-win.c (tui_data_window::set_new_height)
6918 (tui_data_window::do_make_visible_with_new_height): Move to
6920 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6921 * tui/tui-regs.c: Remove "structuring" comments.
6922 (tui_data_window::first_data_item_displayed)
6923 (tui_data_window::delete_data_content_windows)
6924 (tui_data_window::erase_data_content)
6925 (tui_data_window::display_all_data)
6926 (tui_data_window::refresh_all)
6927 (tui_data_window::do_scroll_vertical)
6928 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6929 (tui_data_window::do_make_visible_with_new_height)
6930 (tui_data_window::refresh_window): Move from elsewhere.
6931 (_initialize_tui_regs): Move to end of file.
6932 * tui/tui-layout.c: Update.
6933 * tui/tui-hooks.c: Update.
6934 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6935 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6937 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6939 2019-07-17 Tom Tromey <tom@tromey.com>
6941 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6944 2019-07-17 Tom Tromey <tom@tromey.com>
6946 * tui/tui-win.c (tui_source_window_base::set_new_height)
6947 (tui_source_window_base::do_make_visible_with_new_height): Use
6948 m_has_locator field directly.
6949 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6951 (struct tui_source_window_base) <has_locator>: Likewise.
6953 2019-07-17 Tom Tromey <tom@tromey.com>
6955 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6957 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6959 * tui/tui-win.c (tui_source_window_base::set_new_height)
6960 (tui_source_window_base::set_new_height)
6961 (make_invisible_and_set_new_height)
6962 (tui_source_window_base::do_make_visible_with_new_height)
6963 (tui_source_window_base::do_make_visible_with_new_height):
6965 * tui/tui-layout.c (show_source_disasm_command, show_data)
6966 (show_source_or_disasm_and_command): Update.
6967 * tui/tui-layout.c (show_layout): Update.
6969 2019-07-17 Tom Tromey <tom@tromey.com>
6971 * tui/tui-layout.c (make_data_window): Remove.
6972 (show_data): Unify creation and re-initialization cases.
6974 2019-07-17 Tom Tromey <tom@tromey.com>
6976 * tui/tui-layout.c (make_source_window, make_disasm_window):
6978 (show_data): Unify creation and re-initialization cases.
6980 2019-07-17 Tom Tromey <tom@tromey.com>
6982 * tui/tui-layout.c (make_command_window): Remove.
6983 (show_source_disasm_command, show_source_or_disasm_and_command):
6984 Unify creation and re-initialization cases.
6986 2019-07-17 Tom Tromey <tom@tromey.com>
6988 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6989 creation and re-initialization cases.
6991 2019-07-17 Tom Tromey <tom@tromey.com>
6993 * tui/tui-regs.c (tui_get_register): Return void.
6995 2019-07-17 Tom Tromey <tom@tromey.com>
6997 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
7000 2019-07-17 Tom Tromey <tom@tromey.com>
7002 * tui/tui-layout.c (show_source_disasm_command): Simplify window
7005 2019-07-17 Tom Tromey <tom@tromey.com>
7007 * tui/tui.h (tui_set_layout_by_name): Don't declare.
7008 * tui/tui-regs.c (tui_reg_layout): New function.
7009 (tui_show_registers, tui_reg_command): Use it.
7010 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
7011 (tui_layout_command): Rename from tui_set_layout_by_name. Change
7013 (tui_layout_command): Remove.
7015 2019-07-17 Tom Tromey <tom@tromey.com>
7017 * tui/tui-layout.h (tui/tui-layout): Return void.
7018 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
7020 2019-07-17 Tom Tromey <tom@tromey.com>
7022 * tui/tui-layout.c (show_source_disasm_command, show_data):
7024 (reset_locator): Remove.
7025 (show_source_or_disasm_and_command): Update.
7027 2019-07-17 Tom Tromey <tom@tromey.com>
7029 * tui/tui-source.c (tui_source_window_base::reset): Remove
7031 * tui/tui-layout.c (make_command_window, make_source_window)
7032 (make_disasm_window, make_data_window)
7033 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7034 (reset_locator, show_source_or_disasm_and_command): Update.
7035 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7037 (struct tui_source_window_base) <reset>: Likewise.
7039 2019-07-17 Tom Tromey <tom@tromey.com>
7041 * tui/tui-layout.c (show_source_disasm_command): Use
7043 (reset_locator): New function.
7044 (init_and_make_win): Remove.
7045 (show_source_or_disasm_and_command): Use reset_locator.
7047 2019-07-17 Tom Tromey <tom@tromey.com>
7049 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7051 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7053 * tui/tui-source.c (tui_source_window_base::reset): New method.
7054 * tui/tui-layout.c (make_command_window): Don't call
7056 (make_source_window, make_disasm_window): Don't call
7057 make_source_or_disasm_window.
7058 (make_data_window): Don't call init_and_make_win. Change calling
7060 (show_source_disasm_command, show_data): Simplify.
7061 (make_source_or_disasm_window): Remove.
7062 (show_source_or_disasm_and_command): Simplify.
7063 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7064 (struct tui_source_window_base) <reset>: Likewise.
7065 <execution_info>: Remove initializer.
7066 * tui/tui-data.c (tui_source_window_base): Initialize
7069 2019-07-17 Tom Tromey <tom@tromey.com>
7071 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7074 2019-07-17 Tom Tromey <tom@tromey.com>
7076 * tui/tui.c (tui_rl_other_window): Update.
7077 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7078 superclass method first. Always iterate over regs_content.
7079 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7081 * tui/tui-win.c (tui_set_focus_command): Update.
7083 2019-07-17 Tom Tromey <tom@tromey.com>
7085 * tui/tui-win.c (tui_set_focus_command): Rename from
7086 tui_set_focus. Call tui_enable.
7087 (tui_set_focus_command): Remove.
7089 2019-07-17 Tom Tromey <tom@tromey.com>
7091 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7093 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7095 (tui_data_window::refresh_window): Call refresh_window on data
7096 items. Always call superclass refresh_window.
7097 (tui_win_info::refresh): Remove.
7098 (tui_source_window_base::refresh_window): Update.
7099 (tui_refresh_all): Update.
7100 * tui/tui-layout.c (show_source_disasm_command): Remove call to
7102 (show_source_or_disasm_and_command): Likewise.
7103 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7104 (struct tui_source_window_base) <refresh>: Likewise.
7106 2019-07-17 Tom Tromey <tom@tromey.com>
7108 * tui/tui-winsource.c (tui_clear_source_content)
7109 (tui_show_source_content): Update.
7110 * tui/tui-source.c (tui_source_window::showing_source_p): Check
7111 whether content is empty.
7112 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7115 2019-07-17 Tom Tromey <tom@tromey.com>
7117 * tui/tui-winsource.c (tui_erase_source_content): Clear the
7119 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7120 * tui/tui-source.c (tui_set_source_content_nil): Remove.
7122 2019-07-17 Tom Tromey <tom@tromey.com>
7124 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7125 (struct tui_data_item_window): Update.
7127 2019-07-17 Tom Tromey <tom@tromey.com>
7129 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7130 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7133 2019-07-17 Tom Tromey <tom@tromey.com>
7135 * tui/tui-winsource.h (tui_erase_source_content)
7136 (tui_clear_source_content): Remove "display_prompt" parameter.
7137 * tui/tui-winsource.c (tui_update_source_window_as_is)
7138 (tui_update_source_windows_with_addr): Update.
7139 (tui_clear_source_content): Remove "display_prompt" parameter.
7140 (tui_erase_source_content): Likewise. Simplify.
7141 (tui_show_source_content): Update.
7142 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7143 * tui/tui-stack.c (tui_show_frame_info): Update.
7144 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7147 2019-07-17 Tom Tromey <tom@tromey.com>
7149 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7150 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7152 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7155 2019-07-17 Tom Tromey <tom@tromey.com>
7157 * tui/tui-winsource.c (tui_clear_source_content)
7158 (tui_show_source_content, tui_show_exec_info_content)
7159 (tui_clear_exec_info_content): Update.
7160 * tui/tui-stack.c (tui_show_locator_content): Update.
7161 (tui_show_frame_info): Update.
7162 * tui/tui-source.h (tui_source_window): Don't declare.
7163 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7164 from tui_source_is_displayed.
7165 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7167 (struct tui_source_window_base) <content_in_use>: New field. Now
7169 (struct tui_source_window) <showing_source_p>: New method.
7170 (TUI_SRC_WIN): Change cast.
7171 * tui/tui-data.c (tui_initialize_static_data): Update.
7173 2019-07-17 Tom Tromey <tom@tromey.com>
7175 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7177 * tui/tui-source.c (tui_source_window::location_matches_p): New
7179 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7181 * tui/tui-data.h (struct tui_source_window_base)
7182 <location_matches_p>: New method.
7183 (struct tui_source_window, struct tui_disasm_window)
7184 <location_matches_p>: Likewise.
7186 2019-07-17 Tom Tromey <tom@tromey.com>
7188 * tui/tui-win.c (tui_set_win_height_command): Rename from
7190 (tui_set_win_height_command): Remove.
7192 2019-07-17 Tom Tromey <tom@tromey.com>
7194 * tui/tui-source.c (tui_source_window): New constructor. Add
7196 (~tui_source_window): New destructor.
7197 (tui_source_window::style_changed): New method.
7198 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7199 (tui_attach_detach_observers): Update.
7200 * tui/tui-data.h (struct tui_source_window): Make constructor not
7201 inline. Add destructor.
7202 (struct tui_source_window) <style_changed>: New method.
7203 <m_observable>: New member.
7205 2019-07-17 Tom Tromey <tom@tromey.com>
7207 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7208 * tui/tui-win.c (tui_resize_all): Fix typo.
7210 2019-07-17 Tom Tromey <tom@tromey.com>
7212 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7213 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7214 (tui_refresh_all): Remove "list" parameter. Use foreach.
7215 * tui/tui-win.c (window_name_completer): Use foreach.
7216 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7217 (update_tab_width): Likewise.
7218 * tui/tui-layout.c (show_layout): Update.
7219 * tui/tui-data.h (class tui_window_iterator): New.
7220 (struct all_tui_windows): New.
7221 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7223 2019-07-17 Tom Tromey <tom@tromey.com>
7225 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7226 parameter. Don't reference globals.
7227 (tui_reg_command): Update.
7229 2019-07-17 Tom Tromey <tom@tromey.com>
7231 * tui/tui-regs.c (tui_show_registers): Simplify.
7233 2019-07-17 Tom Tromey <tom@tromey.com>
7235 * tui/tui-regs.c (tui_show_registers): Update.
7236 (tui_show_register_group): Add win_info parameter.
7238 2019-07-17 Tom Tromey <tom@tromey.com>
7240 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7241 Rename from tui_display_reg_element_at_line.
7242 (tui_data_window::display_registers_from_line): Update.
7243 * tui/tui-data.h (struct tui_data_window)
7244 <display_reg_element_at_line>: New method.
7246 2019-07-17 Tom Tromey <tom@tromey.com>
7248 * tui/tui-regs.h (tui_display_registers_from)
7249 (tui_display_registers_from_line): Don't declare.
7250 * tui/tui-windata.c (tui_data_window::display_all_data)
7251 (tui_data_window::refresh_all)
7252 (tui_data_window::do_scroll_vertical): Update.
7253 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7254 from tui_display_registers_from.
7255 (tui_display_reg_element_at_line): Update.
7256 (tui_data_window::display_registers_from_line): Rename from
7257 tui_display_registers_from_line.
7258 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7259 display_registers_from_line>: New methods.
7261 2019-07-17 Tom Tromey <tom@tromey.com>
7263 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7264 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7265 from tui_erase_data_content.
7266 (tui_data_window::display_all_data)
7267 (tui_data_window::refresh_all)
7268 (tui_data_window::do_scroll_vertical): Update.
7269 * tui/tui-regs.c (tui_show_registers): Update.
7270 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7273 2019-07-17 Tom Tromey <tom@tromey.com>
7275 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7278 (tui_data_window::delete_data_content_windows): Rename from
7279 tui_delete_data_content_windows.
7280 (tui_data_window::display_all_data)
7281 (tui_data_window::do_scroll_vertical): Update.
7282 * tui/tui-data.h (struct tui_data_window)
7283 <delete_data_content_windows>: New method.
7285 2019-07-17 Tom Tromey <tom@tromey.com>
7287 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7288 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7290 2019-07-17 Tom Tromey <tom@tromey.com>
7292 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7293 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7294 from tui_display_all_data.
7296 (tui_data_window::do_make_visible_with_new_height): Update.
7297 * tui/tui-regs.c (tui_show_registers): Update.
7298 * tui/tui-layout.c (tui_set_layout): Update.
7299 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7302 2019-07-17 Tom Tromey <tom@tromey.com>
7304 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7305 * tui/tui-windata.c (tui_display_data_from): Remove.
7306 (tui_data_window::refresh_all): Update.
7308 2019-07-17 Tom Tromey <tom@tromey.com>
7310 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7311 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7312 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7313 tui_display_registers_from_line.
7314 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7315 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7316 "force_display" parameter.
7318 2019-07-17 Tom Tromey <tom@tromey.com>
7320 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7322 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7323 Rename from tui_first_reg_element_no_inline.
7324 (tui_display_reg_element_at_line)
7325 (tui_display_registers_from_line): Update.
7326 * tui/tui-data.h (struct tui_data_window)
7327 <first_reg_element_no_inline>: New method.
7329 2019-07-17 Tom Tromey <tom@tromey.com>
7331 * tui/tui-windata.c (tui_display_data_from)
7332 (tui_data_window::do_scroll_vertical): Update.
7333 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7334 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7335 Rename from tui_line_from_reg_element_no.
7336 (tui_display_registers_from_line): Update.
7337 * tui/tui-data.h (struct tui_data_window)
7338 <line_from_reg_element_no>: New method.
7340 2019-07-17 Tom Tromey <tom@tromey.com>
7342 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7343 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7344 tui_last_regs_line_no.
7345 (tui_display_reg_element_at_line)
7346 (tui_display_registers_from_line): Update.
7347 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7350 2019-07-17 Tom Tromey <tom@tromey.com>
7353 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7354 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7355 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7356 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7357 (tui_update_breakpoint_info): Likewise.
7358 * tui/tui-hooks.c (tui_event_create_breakpoint)
7359 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7362 2019-07-17 Tom Tromey <tom@tromey.com>
7364 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7366 2019-07-17 Tom Tromey <tom@tromey.com>
7368 * tui/tui-winsource.c (tui_update_source_window_as_is)
7369 (tui_update_source_windows_with_addr): Update.
7370 * tui/tui-source.h (tui_set_source_content)
7371 (tui_show_symtab_source): Add "win_info" parameter.
7372 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7374 (tui_show_symtab_source): Likewise.
7376 2019-07-17 Tom Tromey <tom@tromey.com>
7378 * tui/tui-wingeneral.c
7379 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7381 2019-07-17 Tom Tromey <tom@tromey.com>
7383 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7384 (struct tui_cmd_window) <can_scroll>: New method.
7385 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7388 2019-07-17 Tom Tromey <tromey@adacore.com>
7390 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7391 do_field_signed>: Rename. Change type of "value".
7392 * ui-out.c (ui_out::field_signed): Rename from field_int.
7393 Change type of "value".
7394 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7396 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7397 do_field_int. Change type of "value".
7398 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7399 do_field_int. Change type of "value".
7400 * tracepoint.c (trace_status_mi, tfind_1)
7401 (print_one_static_tracepoint_marker): Update.
7402 * thread.c (print_thread_info_1, print_selected_thread_frame):
7404 * stack.c (print_frame, print_frame_info): Update.
7405 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7407 * source.c (print_source_lines_base): Update.
7408 * skip.c (info_skip_command): Update.
7409 * record-btrace.c (btrace_ui_out_decode_error)
7410 (btrace_call_history_src_line): Update.
7411 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7413 * progspace.c (print_program_space): Update.
7414 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7415 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7416 do_field_int. Change type of "value".
7417 * mi/mi-out.c (mi_ui_out::do_table_begin)
7418 (mi_ui_out::do_table_header): Update.
7419 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7421 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7422 (mi_cmd_data_list_changed_registers, output_register)
7423 (mi_cmd_data_read_memory, mi_load_progress)
7424 (mi_cmd_trace_frame_collected): Update.
7425 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7427 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7428 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7429 (mi_cmd_var_list_children, varobj_update_one): Update.
7430 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7431 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7432 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7433 * inferior.c (print_inferior): Update.
7434 * gdb_bfd.c (print_one_bfd): Update.
7435 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7437 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7438 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7439 do_field_int. Change type of "value".
7440 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7441 do_field_int. Change type of "value".
7442 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7443 (print_one_breakpoint_location, print_it_catch_fork)
7444 (print_one_catch_fork, print_it_catch_vfork)
7445 (print_one_catch_vfork, print_it_catch_solib)
7446 (print_it_catch_exec, print_it_ranged_breakpoint)
7447 (print_mention_watchpoint, print_mention_masked_watchpoint)
7448 (bkpt_print_it, update_static_tracepoint): Update.
7449 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7450 * break-catch-syscall.c (print_it_catch_syscall): Update.
7451 * ada-tasks.c (print_ada_task_info): Update.
7452 * ada-lang.c (print_it_exception, print_mention_exception):
7455 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7457 PR breakpoints/24541
7458 * gdbarch.c: Regenerate.
7459 * gdbarch.h: Regenerate.
7460 * gdbarch.sh: Adjust return type and parameter types for
7461 'stap_adjust_register'.
7462 (i386_stap_adjust_register): Adjust signature and return new
7464 * stap-probe.c (stap_parse_register_operand): Adjust use of
7465 'gdbarch_stap_adjust_register'.
7467 2019-07-17 Tom Tromey <tromey@adacore.com>
7469 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7471 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7473 (struct s390_process_info): Add initializers.
7474 (s390_add_process): Use new.
7475 (s390_linux_nat_target::low_forget_process): Use delete.
7476 (s390_linux_nat_target::low_new_fork)
7477 (s390_linux_nat_target::stopped_by_watchpoint)
7478 (s390_linux_nat_target::low_prepare_to_resume)
7479 (s390_linux_nat_target::insert_watchpoint)
7480 (s390_linux_nat_target::insert_hw_breakpoint)
7481 (s390_linux_nat_target::remove_watchpoint)
7482 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7484 2019-07-16 John Baldwin <jhb@FreeBSD.org>
7486 * aarch64-fbsd-nat.c: Include regcache.h.
7487 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7489 (aarch64_fbsd_nat_target::fetch_registers)
7490 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7492 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7494 2019-07-16 John Baldwin <jhb@FreeBSD.org>
7496 * fbsd-nat.c: Include gdbarch.h.
7498 2019-07-15 Tom Tromey <tromey@adacore.com>
7500 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7502 2019-07-15 Tom Tromey <tromey@adacore.com>
7504 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7505 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7506 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7507 * cli-out.c (cli_ui_out::do_field_int): New method.
7508 * ui-out.c (ui_out::field_unsigned): New method.
7509 * symfile.c (generic_load): Use field_unsigned.
7510 (print_transfer_performance): Likewise.
7511 * record-btrace.c (ui_out_field_uint): Remove.
7512 (btrace_call_history_insn_range, btrace_call_history): Use
7514 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7516 * ui-out.h (class ui_out) <field_unsigned>: New method.
7517 <do_field_unsigned>: Likewise.
7519 2019-07-15 Tom Tromey <tromey@adacore.com>
7521 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7522 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7523 * target.c (flash_erase_command): Use field_string.
7524 * infrun.c (print_signal_received_reason): Use field_string.
7525 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7526 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7528 * ada-tasks.c (print_ada_task_info): Use field_string.
7530 2019-07-15 Tom Tromey <tromey@adacore.com>
7532 * target.c (flash_erase_command): Use field_core_addr.
7533 * symfile.c (generic_load): Use field_core_addr.
7534 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7535 Use field_core_addr.
7536 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7539 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7541 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7542 value if its desired type is smaller than a CORE_ADDR and signed.
7544 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7546 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7547 of changes to field names, and use new is_reference field to
7548 decide if a property is a reference or not.
7549 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7551 (struct dwarf2_property_baton): Update header comment, rename
7552 'referenced_type' to 'property_type' and update comments.
7553 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7554 default property type, store in property baton, update to take
7555 accound of renamed field.
7556 (read_func_scope): Update call to attr_to_dynamic_prop.
7557 (read_array_type): Likewise.
7558 (dwarf2_per_cu_addr_sized_int_type): New function.
7559 (read_subrange_index_type): Move type finding code to
7560 dwarf2_per_cu_addr_sized_int_type.
7561 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7562 (dwarf2_per_cu_addr_type): New function.
7563 (set_die_type): Update calls to attr_to_dynamic_prop.
7565 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7567 * dwarf2read.c (read_subrange_index_type): New function.
7568 (read_subrange_type): Move code into new function and call it.
7569 * gdbtypes.c (create_range_type): Add some asserts.
7571 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7573 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7574 update return statements.
7575 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7576 declaration, and update comment to match.
7577 * gdbtypes.c (resolve_dynamic_array): Update call to
7578 dwarf2_evaluate_property to match new return type.
7580 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7582 * valarith.c (value_subscripted_rvalue): Change lowerbound
7583 parameter type from int to LONGEST.
7584 * value.h (value_subscripted_rvalue): Likewise in declaration.
7586 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7588 * cli/cli-utils.c (info_print_command_completer): New function.
7589 * cli/cli-utils.h: Add 'completer.h' include, and forward
7590 declaration for 'struct cmd_list_element'.
7591 (info_print_command_completer): Declare.
7592 * stack.c (_initialize_stack): Add completer for 'info locals' and
7594 * symtab.c (_initialize_symtab): Add completer for 'info
7595 variables' and 'info functions'.
7596 * NEWS: Mention completion for additional info commands.
7598 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7600 * cli/cli-utils.c (extract_info_print_args): Delete.
7601 (extract_arg_maybe_quoted): Delete.
7602 (info_print_options_defs): New variable.
7603 (make_info_print_options_def_group): New function.
7604 (extract_info_print_options): Define new function.
7605 * cli/cli-utils.h (extract_info_print_args): Delete.
7606 (struct info_print_options): New structure.
7607 (extract_info_print_options): Declare new function.
7608 * stack.c (info_locals_command): Update to use new
7609 extract_info_print_options, also add a header comment.
7610 (info_args_command): Likewise.
7611 * symtab.c (info_variables_command): Likewise.
7612 (info_functions_command): Likewise.
7614 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7616 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7617 to extract string arguments.
7618 * common/common-utils.c (extract_string_maybe_quoted): New function.
7619 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7621 2019-07-11 Tom Tromey <tromey@adacore.com>
7623 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7624 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7625 * top.h (gdbinit): Don't declare.
7626 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7628 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7629 * top.c (gdb_init): Don't call init_cli_cmds.
7631 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7633 2019-07-11 Tom Tromey <tromey@adacore.com>
7635 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7636 after it has been moved.
7638 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7640 * valops.c (value_must_coerce_to_target): Change return type to
7642 * value.h (value_must_coerce_to_target): Likewise.
7644 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
7646 * breakpoint.c (is_hardware_watchpoint): Remove
7647 forward-declaration.
7648 (is_masked_watchpoint): Change return type to bool.
7649 (is_tracepoint): Likewise.
7650 (is_breakpoint): Likewise.
7651 (is_hardware_watchpoint): Likewise.
7652 (is_watchpoint): Likewise.
7653 (is_no_memory_software_watchpoint): Likewise.
7654 (is_catchpoint): Likewise.
7655 (breakpoint_1): Make FILTER parameter's return type bool.
7656 is_masked_watchpoint): Change return type to bool.
7657 (save_breakpoints): Make FILTER parameter's return type bool.
7658 * breakpoint.h (is_breakpoint): Change return type to bool.
7659 (is_watchpoint): Likewise.
7660 (is_catchpoint): Likewise.
7661 (is_tracepoint): Likewise.
7663 2019-07-10 Tom Tromey <tom@tromey.com>
7665 * defs.h: Don't include gdbarch.h.
7666 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7667 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7668 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7669 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7670 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7671 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7672 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7673 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7674 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7675 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7676 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7677 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7678 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7679 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7680 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7681 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7682 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7683 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7684 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7685 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7686 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7687 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7688 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7689 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7690 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7691 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7692 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7694 2019-07-10 Tom Tromey <tromey@adacore.com>
7696 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7697 * breakpoint.c (init_ada_exception_breakpoint): Register as
7699 (print_one_breakpoint_location, print_one_breakpoint): Use
7700 is_ada_exception_catchpoint.
7701 * ada-lang.c (class ada_catchpoint_location): Pass
7702 bp_loc_software_breakpoint to bp_location constructor.
7703 (is_ada_exception_catchpoint): New function.
7705 2019-07-10 Tom Tromey <tromey@adacore.com>
7707 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7709 (struct arm_exidx_entry): New method operator<.
7710 (struct arm_exidx_data) <section_maps>: Change type.
7711 (arm_exidx_data_free): Remove.
7712 (arm_exidx_data_key): Change type. Move lower.
7713 (arm_exidx_new_objfile): Update.
7714 (arm_compare_exidx_entries): Remove.
7715 (arm_find_exidx_entry, _initialize_arm_tdep)
7717 2019-07-10 Tom Tromey <tromey@adacore.com>
7719 * solib-spu.c (ocl_program_data_key): Change type.
7720 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7723 2019-07-10 Tom Tromey <tromey@adacore.com>
7725 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7726 (struct solib_aix_inferior_data) <library_list>: Change type.
7727 (solib_aix_inferior_data_handle): Change type.
7728 (get_solib_aix_inferior_data): Update.
7729 (solib_aix_free_library_list): Remove.
7730 (library_list_start_library): Update.
7731 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7733 (solib_aix_get_library_list)
7734 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7735 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7737 2019-07-10 Tom Tromey <tromey@adacore.com>
7739 * solib-dsbt.c (struct dsbt_info): Add initializers.
7740 (solib_dsbt_pspace_data): Change type.
7741 (dsbt_pspace_data_cleanup): Remove.
7742 (get_dsbt_info, _initialize_dsbt_solib): Update.
7744 2019-07-10 Tom Tromey <tromey@adacore.com>
7746 * spu-tdep.c (spu_overlay_data): Change type.
7747 (spu_get_overlay_table, spu_overlay_new_objfile)
7748 (_initialize_spu_tdep): Update.
7750 2019-07-10 Tom Tromey <tromey@adacore.com>
7752 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7754 (dbx_objfile_data_key): Change type and declare later.
7755 (DBX_SYMFILE_INFO): Rewrite.
7756 * dbxread.c (dbx_objfile_data_key): Change type.
7757 (dbx_symfile_init): Update.
7758 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7759 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7760 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7762 2019-07-10 Tom Tromey <tromey@adacore.com>
7764 * jit.c (jit_program_space_key): Change type. Move lower.
7765 (get_jit_program_space_data): Update.
7766 (jit_program_space_data_cleanup): Remove.
7767 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7769 (struct jit_program_space_data): Add initializers.
7771 2019-07-10 Tom Tromey <tromey@adacore.com>
7773 * solib-darwin.c (struct darwin_info): Add initializers.
7774 (solib_darwin_pspace_data): Change type.
7775 (darwin_pspace_data_cleanup): Remove.
7776 (get_darwin_info, _initialize_darwin_solib): Update.
7778 2019-07-10 Tom Tromey <tromey@adacore.com>
7780 * remote-sim.c (struct sim_inferior_data): Add initializers,
7781 constructor, and destructor.
7782 (sim_inferior_data_key): Change type. Move lower.
7783 (check_for_duplicate_sim_descriptor): Update.
7784 (get_sim_inferior_data): Use new. Update.
7785 (~sim_inferior_data_cleanup): Rename from
7786 sim_inferior_data_cleanup. Simplify.
7787 (gdbsim_close_inferior, simulator_command)
7788 (sim_command_completer, _initialize_remote_sim): Update.
7789 (next_pid, INITIAL_PID): Move earlier.
7791 2019-07-10 Tom Tromey <tromey@adacore.com>
7793 * python/python-internal.h (create_thread_object): Return
7795 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7796 * python/py-inferior.c (struct threadlist_entry): Add
7798 <thread_obj>: Now a gdbpy_ref.
7799 (thread_to_thread_object): Update.
7800 (add_thread_object): Use new.
7801 (delete_thread_object): Use delete.
7802 (infpy_threads): Update.
7803 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7806 2019-07-10 Tom Tromey <tromey@adacore.com>
7808 * valops.c (value_cast): Specialize error message for Ada.
7810 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7812 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7814 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7816 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7817 bpstat_should_step): Return bool, adjust comments.
7818 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7819 bpstat_should_step): Likewise.
7821 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7823 * features/Makefile: Use feature target descriptions for Arm.
7824 * features/arm/arm-core.c: Generate new file.
7825 * features/arm/arm-fpa.c: Likewise.
7826 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7827 * features/arm/arm-m-profile.c: Likewise.
7828 * features/arm/arm-vfpv2.c: Likewise.
7829 * features/arm/arm-vfpv3.c: Likewise.
7830 * features/arm/xscale-iwmmxt.c: Likewise.
7831 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7833 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7835 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7838 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7840 * features/aarch64-pauth.c: Regenerate.
7842 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7844 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7846 (bpstat_what): Use false instead of 0.
7848 2019-07-09 Pedro Alves <palves@redhat.com>
7850 * break-catch-throw.c (is_exception_catchpoint): New.
7851 * breakpoint.c (print_one_breakpoint_location): New parameter
7852 'raw_loc'. Handle it. Use
7853 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7854 looking at the breakpoint's type.
7855 (print_one_breakpoint): If handling "maint info breakpoints", also
7856 print locations of exception catchpoints.
7857 * breakpoint.h (is_exception_catchpoint): Declare.
7859 2019-07-09 Pedro Alves <palves@redhat.com>
7861 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7863 (allocate_location_exception_catchpoint): New.
7864 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7865 (initialize_throw_catchpoint_ops): Install
7866 allocate_location_exception_catchpoint as allocate_location
7868 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7869 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7871 (breakpoint_address_is_meaningful): Delete.
7872 (bl_address_is_meaningful): New.
7873 (breakpoint_locations_match): Adjust comment.
7874 (bp_location_from_bp_type): New, factored out of...
7875 (bp_location::bp_location(breakpoint *)): ... this.
7876 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7878 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7879 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7880 breakpoint_address_is_meaningful.
7881 (bp_locations_compare): Adjust comment.
7882 (update_global_location_list): Use bl_address_is_meaningful
7883 instead of breakpoint_address_is_meaningful.
7884 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7886 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7887 * python/py-breakpoint.c (bppy_get_location): No longer check
7888 whether location is null.
7890 2019-07-09 Pedro Alves <palves@redhat.com>
7893 * breakpoint.c (print_one_breakpoint_location): Remove
7894 single-location assert.
7896 2019-07-09 Tom Tromey <tom@tromey.com>
7898 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7899 * configure: Rebuild.
7900 * configure.ac: Change common to gdbsupport.
7901 * gdbsupport: Rename from common.
7902 * acinclude.m4: Change common to gdbsupport.
7903 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7904 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7906 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7907 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7908 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7909 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7910 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7911 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7912 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7913 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7914 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7915 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7916 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7917 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7918 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7919 coff-pe-read.c, command.h, compile/compile-c-support.c,
7920 compile/compile-c.h, compile/compile-cplus-symbols.c,
7921 compile/compile-cplus-types.c, compile/compile-cplus.h,
7922 compile/compile-loc2c.c, compile/compile.c, completer.c,
7923 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7924 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7925 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7926 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7927 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7928 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7929 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7930 features/aarch64-core.c, features/aarch64-fpu.c,
7931 features/aarch64-pauth.c, features/aarch64-sve.c,
7932 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7933 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7934 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7935 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7936 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7937 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7938 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7939 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7940 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7941 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7942 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7943 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7944 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7945 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7946 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7947 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7948 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7949 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7950 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7951 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7952 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7953 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7954 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7955 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7956 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7957 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7958 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7959 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7960 minsyms.c, mips-linux-tdep.c, namespace.h,
7961 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7962 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7963 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7964 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7965 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7966 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7967 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7968 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7969 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7970 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7971 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7972 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7973 procfs.c, producer.c, progspace.h, psymtab.h,
7974 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7975 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7976 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7977 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7978 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7979 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7980 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7981 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7982 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7983 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7984 target-memory.c, target.c, target.h, target/waitstatus.c,
7985 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7986 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7987 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7988 unittests/array-view-selftests.c,
7989 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7990 unittests/common-utils-selftests.c,
7991 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7992 unittests/format_pieces-selftests.c,
7993 unittests/function-view-selftests.c,
7994 unittests/lookup_name_info-selftests.c,
7995 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7996 unittests/mkdir-recursive-selftests.c,
7997 unittests/observable-selftests.c,
7998 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7999 unittests/parse-connection-spec-selftests.c,
8000 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
8001 unittests/scoped_fd-selftests.c,
8002 unittests/scoped_mmap-selftests.c,
8003 unittests/scoped_restore-selftests.c,
8004 unittests/string_view-selftests.c, unittests/style-selftests.c,
8005 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
8006 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
8007 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
8008 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
8009 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
8010 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
8012 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8014 * linespec.c (decode_digits_list_mode): Set explicit_line to a
8016 (decode_digits_ordinary): Set explicit_line field in sal.
8017 * symtab.c (skip_prologue_sal): Don't skip prologue for a
8018 symtab_and_line that was set on an explicit line number in
8019 assembler code. Do always update the recorded symtab and line if
8020 we do skip the prologue.
8022 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8024 * breakpoint.c (set_breakpoint_location_function): Remove
8025 explicit_loc parameter.
8026 (momentary_breakpoint_from_master): Update call to
8027 set_breakpoint_location_function.
8028 (add_location_to_breakpoint): Likewise.
8030 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8032 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8033 required features based on default bfd type when no specific bfd
8036 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8038 * NEWS: Mention that GDB printf and eval commands can now print
8039 C-style and Ada-style convenience var strings without
8040 calling the inferior.
8041 * printcmd.c (printf_c_string): Locally print GDB internal var
8042 instead of transiting via the inferior.
8043 (printf_wide_c_string): Likewise.
8045 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8047 PR breakpoints/25011
8048 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8050 2019-07-04 Tom Tromey <tom@tromey.com>
8053 * tui/tui-winsource.c (tui_clear_source_content): Update.
8054 (tui_source_window_base::set_is_exec_point_at): Fix comment.
8055 (tui_update_breakpoint_info): Update.
8056 (tui_set_exec_info_content): Update.
8057 * tui/tui-source.c (tui_set_source_content_nil): Update.
8058 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8060 * tui/tui-data.h (enum tui_bp_flag): New.
8061 (tui_bp_flags): New enum flags type.
8062 (struct tui_source_element) <break_mode>: Change type. Rename
8064 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8065 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
8067 * tui/tui-winsource.h: Fix comment.
8069 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8071 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8072 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8073 (store_fpregs_to_thread)
8074 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8075 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8076 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8077 (IWMMXT_REGS_SIZE): Add define.
8078 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8079 (fetch_vfp_regs, store_vfp_regs)
8080 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8081 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8083 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8085 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8087 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8088 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8089 (ARM_INT_REGISTER_SIZE): ...to this.
8090 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8091 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8092 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8093 (arm_linux_collect_gregset, supply_nwfpe_register)
8094 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8096 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8097 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8098 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8099 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8100 (arm_return_in_memory, arm_store_return_value)
8101 (arm_get_longjmp_target, arm_register_g_packet_guesses)
8102 (arm_record_ld_st_multiple): Likewise.
8103 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8104 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8106 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8108 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8109 AARCH64_DISPLACED_MODIFIED_INSNS.
8110 * aarch64-tdep.c (struct aarch64_displaced_step_data)
8111 (aarch64_displaced_step_copy_insn): Likewise.
8112 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8113 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8114 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8115 ARM_DISPLACED_MODIFIED_INSNS.
8116 * arm-tdep.c (arm_gdbarch_init): Likewise.
8117 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8118 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8119 (struct arm_displaced_step_closure): Use
8120 ARM_DISPLACED_MODIFIED_INSNS.
8122 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8124 * features/Makefile: Remove unused xml files.
8125 * features/aarch64.xml: Remove.
8126 * features/i386/amd64-avx-avx512-linux.xml: Remove.
8127 * features/i386/amd64-avx-avx512.xml: Remove.
8128 * features/i386/amd64-avx-linux.xml: Remove.
8129 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8130 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8131 * features/i386/amd64-avx-mpx-linux.xml: Remove.
8132 * features/i386/amd64-avx-mpx.xml: Remove.
8133 * features/i386/amd64-avx.xml: Remove.
8134 * features/i386/amd64-linux.xml: Remove.
8135 * features/i386/amd64-mpx-linux.xml: Remove.
8136 * features/i386/amd64-mpx.xml: Remove.
8137 * features/i386/amd64.xml: Remove.
8138 * features/i386/i386-avx-avx512-linux.xml: Remove.
8139 * features/i386/i386-avx-avx512.xml: Remove.
8140 * features/i386/i386-avx-linux.xml: Remove.
8141 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8142 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8143 * features/i386/i386-avx-mpx-linux.xml: Remove.
8144 * features/i386/i386-avx-mpx.xml: Remove.
8145 * features/i386/i386-avx.xml: Remove.
8146 * features/i386/i386-linux.xml: Remove.
8147 * features/i386/i386-mmx-linux.xml: Remove.
8148 * features/i386/i386-mmx.xml: Remove.
8149 * features/i386/i386-mpx-linux.xml: Remove.
8150 * features/i386/i386-mpx.xml: Remove.
8151 * features/i386/i386.xml: Remove.
8152 * features/i386/x32-avx-avx512-linux.xml: Remove.
8153 * features/i386/x32-avx-linux.xml: Remove.
8154 * features/i386/x32-linux.xml: Remove.
8156 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8158 * regformats/aarch64.dat: Remove.
8159 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8160 * regformats/i386/amd64-avx-linux.dat: Remove.
8161 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8162 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8163 * regformats/i386/amd64-linux.dat: Remove.
8164 * regformats/i386/amd64-mpx-linux.dat: Remove.
8165 * regformats/i386/amd64.dat: Remove.
8166 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8167 * regformats/i386/i386-avx-linux.dat: Remove.
8168 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8169 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8170 * regformats/i386/i386-linux.dat: Remove.
8171 * regformats/i386/i386-mmx-linux.dat: Remove.
8172 * regformats/i386/i386-mpx-linux.dat: Remove.
8173 * regformats/i386/i386.dat: Remove.
8174 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8175 * regformats/i386/x32-avx-linux.dat: Remove.
8176 * regformats/i386/x32-linux.dat: Remove.
8178 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8180 * aarch64-tdep.c: Remove xml self tests.
8181 * amd64-linux-tdep.c: Likewise.
8182 * amd64-tdep.c: Likewise.
8183 * i386-linux-tdep.c: Likewise.
8184 * i386-tdep.c: Likewise.
8186 2019-07-03 Pedro Alves <palves@redhat.com>
8189 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8190 (pipe_cmd_option_defs): New.
8191 (make_pipe_cmd_options_def_group): New.
8192 (pipe_command): Use gdb::option::process_options.
8193 (pipe_command_completer): New function.
8194 (_initialize_cli_cmds): Install completer for "pipe" command.
8196 2019-07-03 Pedro Alves <palves@redhat.com>
8198 * cli/cli-option.c (union option_value) <string>: New field.
8199 (struct option_def_and_value): Add ctor, move ctor, dtor and
8200 use DISABLE_COPY_AND_ASSIGN.
8201 (option_def_and_value::clear_value): New.
8202 (parse_option, save_option_value_in_ctx, get_val_type_str)
8203 (add_setshow_cmds_for_options): Handle var_string.
8204 * cli-option.h (union option_def::var_address) <string>: New
8206 (struct string_option_def): New.
8207 * maint-test-options.c (struct test_options_opts): Add default
8208 ctor and use DISABLE_COPY_AND_ASSIGN.
8209 <string_opt>: New field.
8210 (test_options_opts::~test_options_opts): New.
8211 (test_options_opts::dump): Also dump "-string".
8212 (test_options_option_defs): Install "string.
8214 2019-07-03 Pedro Alves <palves@redhat.com>
8216 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8217 option_value with a null enumeration.
8218 (complete_options): Save the option values in the context.
8219 (save_option_value_in_ctx): New, factored out from ...
8220 (process_options): ... here.
8221 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8223 * maint-test-options.c (test_options_opts::dump): New, factored
8225 (maintenance_test_options_command_mode): ... here.
8226 (maintenance_test_options_command_completion_result): Delete.
8227 (maintenance_test_options_command_completion_text): Update
8229 (maintenance_show_test_options_completion_result): Change
8230 prototype. Just print
8231 maintenance_test_options_command_completion_text.
8232 (save_completion_result): New.
8233 (maintenance_test_options_completer_mode): Pass options context to
8234 complete_options, and then save a dump.
8235 (_initialize_maint_test_options): Use add_cmd to install "maint
8236 show test-options-completion-result".
8238 2019-07-03 Pedro Alves <palves@redhat.com>
8240 * NEWS (New commands): Mention "with" and "maint with".
8241 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8242 (with_command, with_command_completer): New.
8243 (pipe_command): Adjust to new repeat_previous
8245 (_initialize_cli_cmds): Install the "with" command and its "w"
8247 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8249 * cli/cli-setshow.c (parse_cli_var_uinteger)
8250 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8251 argument strings for all var_types.
8252 (get_setshow_command_value_string): New, factored out from ...
8253 (do_show_command): ... this.
8254 * cli/cli-setshow.h: Include <string>.
8255 (get_setshow_command_value_string): Declare.
8256 * command.h (repeat_previous): Now returns const char *. Adjust
8258 * maint.c: Include "cli/cli-cmds.h".
8259 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8260 (_initialize_maint_cmds): Register the "maintenance with" command.
8261 * top.c (repeat_previous): Move bits from pipe_command here:
8262 Return the saved command line, if any; error out if there's no
8263 command to relaunch.
8265 2019-07-03 Pedro Alves <palves@redhat.com>
8267 * NEWS (New commands): Mention "maint set/show test-settings"
8268 instead of "maint test-settings".
8269 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8270 (maintenance_test_settings_set_list): Rename to ...
8271 (maintenance_set_test_settings_list): ... this.
8272 (maintenance_test_settings_show_list): Rename to ...
8273 (maintenance_show_test_settings_list): ... this.
8274 (maintenance_test_settings_cmd): Delete.
8275 (maintenance_test_settings_set_cmd): ...
8276 (maintenance_set_test_settings_cmd): ... this.
8277 (maintenance_test_settings_show_cmd): ...
8278 (maintenance_show_test_settings_cmd): ... this.
8279 (maintenance_test_settings_show_value_cmd):
8280 (maintenance_show_test_settings_value_cmd): ... this.
8281 (_initialize_maint_test_settings): No longer install the "maint
8282 test-settings" prefix command. Rename "maint test-settings set"
8283 to "maint set test-settings", and "maint test-settings show" to
8284 "maint show test-settings". Adjust all subcommands.
8286 2019-07-03 Pedro Alves <palves@redhat.com>
8288 * maint-test-settings.c: Fix file's intro comment. Replace all
8289 references to "test-options" with references to "test-settings",
8292 2019-07-03 Pedro Alves <palves@redhat.com>
8294 * maint-test-settings.c (maintenance_test_settings_xxx)
8295 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8297 (maintenance_test_settings_enums): Use them.
8298 (maintenance_test_settings_enum): Default to
8299 maintenance_test_settings_xxx.
8300 (_initialize_maint_test_settings): Initialize
8301 MAINTENANCE_TEST_SETTINGS_FILENAME.
8303 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8305 * breakpoint.h (remove_breakpoints_inf): Change return type to
8306 void, move function documentation here.
8307 * breakpoint.c (remove_breakpoints_inf): Change return type to
8308 void, move function documentation to header.
8310 2019-07-02 Pedro Alves <palves@redhat.com>
8312 * NEWS (Completion improvements): Mention "info threads".
8313 * thread.c (struct info_threads_opts, info_threads_option_defs)
8314 (make_info_threads_options_def_group): New.
8315 (info_threads_command): Use gdb::option::process_options.
8316 (info_threads_command_completer): New.
8317 (_initialize_thread): Use gdb::option::build_help to build the
8318 help text for "info threads".
8320 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8322 * defs.h (generic_load): Move from here...
8323 * symfile.h (generic_load): ... to here. Rename name parameter
8325 * symfile.c (generic_load): Add comment.
8327 2019-07-01 Tom Tromey <tromey@adacore.com>
8330 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8331 declaration of without_params. Fix formatting.
8333 2019-07-01 Tom Tromey <tromey@adacore.com>
8335 * ada-exp.y (find_primitive_type): Update.
8336 * ada-lang.h (ada_lookup_symbol): Update.
8337 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8339 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8341 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8343 PR breakpoints/24541
8344 * gdbarch.c: Regenerate.
8345 * gdbarch.h: Regenerate.
8346 * gdbarch.sh: Add 'stap_adjust_register'.
8347 * i386-tdep.c: Include '<unordered_set>'.
8348 (i386_stap_adjust_register): New function.
8349 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8350 * stap-probe.c (stap_parse_register_operand): Call
8351 'gdbarch_stap_adjust_register'.
8353 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8356 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8357 * python/python.c (do_start_initialization): Use 'xmalloc'
8358 instead of 'PyMem_Malloc'.
8360 2019-06-28 Tom Tromey <tromey@adacore.com>
8362 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8365 2019-06-27 Tom Tromey <tromey@adacore.com>
8367 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8369 (arm_find_mapping_symbol, arm_record_special_symbol)
8370 (_initialize_arm_tdep): Update.
8371 (arm_objfile_data_free): Remove.
8373 2019-06-27 Tom Tromey <tromey@adacore.com>
8375 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8376 to cp_print_static_field.
8378 2019-06-26 Tom Tromey <tromey@adacore.com>
8380 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8381 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8384 2019-06-26 Alan Hayward <alan.hayward@arm.com>
8386 * features/aarch64-core.c (create_feature_aarch64_core):
8388 * features/aarch64-core.xml: Add cpsr flags.
8390 2019-06-26 Alan Hayward <alan.hayward@arm.com>
8392 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8393 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8395 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8397 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8399 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8401 (arm_record_special_symbol): Don't insert new symbol in sorted
8402 position, push it at the end.
8404 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8406 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8407 (arm_mapping_symbol_s): Remove.
8408 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8409 (arm_mapping_symbol_vec): New typedef.
8410 (struct arm_per_objfile): Add constructor.
8411 <section_maps>: Change type to
8412 std::unique_ptr<arm_mapping_symbol_vec[]>.
8413 (arm_compare_mapping_symbols): Remove.
8414 (arm_find_mapping_symbol): Adjust to section_maps type change.
8415 (arm_objfile_data_free): Call delete on arm_per_objfile.
8416 (arm_record_special_symbol): Adjust to section_maps type change.
8417 Allocate arm_per_objfile with new.
8419 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8421 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8422 with the command prefix.
8424 2019-06-25 Tom Tromey <tom@tromey.com>
8426 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8427 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8429 2019-06-25 Tom Tromey <tom@tromey.com>
8431 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8433 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8436 2019-06-25 Tom Tromey <tom@tromey.com>
8438 * tui/tui-winsource.c
8439 (tui_source_window_base::set_is_exec_point_at): Add check against
8442 2019-06-25 Tom Tromey <tom@tromey.com>
8444 * tui/tui-source.c (tui_set_source_content): Don't check before
8446 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8448 2019-06-25 Tom Tromey <tom@tromey.com>
8450 * tui/tui-winsource.h (tui_update_source_window_as_is)
8451 (tui_alloc_source_buffer, tui_line_is_displayed)
8452 (tui_addr_is_displayed): Change type of win_info.
8453 * tui/tui-winsource.c (tui_update_source_window_as_is)
8454 (tui_clear_source_content, tui_show_source_line)
8455 (tui_show_source_content, tui_source_window_base::refill)
8456 (tui_source_window_base::set_is_exec_point_at)
8457 (tui_source_window_base::set_is_exec_point_at)
8458 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8459 (tui_alloc_source_buffer, tui_line_is_displayed)
8460 (tui_addr_is_displayed): Change type of win_info. Update.
8461 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8462 (tui_source_window_base::do_make_visible_with_new_height):
8464 * tui/tui-source.c (tui_set_source_content)
8465 (tui_set_source_content_nil)
8466 (tui_source_window::do_scroll_vertical): Update.
8467 * tui/tui-layout.c (show_layout): Update.
8468 * tui/tui-disasm.c (tui_set_disassem_content)
8469 (tui_disasm_window::do_scroll_vertical): Update.
8470 * tui/tui-data.h (tui_win_content): Remove.
8471 (struct tui_gen_win_info) <content, content_size>: Remove.
8472 (struct tui_source_element): Add initializers and destructor.
8473 (union tui_which_element, struct tui_win_element): Remove.
8474 (struct tui_source_window_base) <content>: New field.
8475 (struct tui_data_window): Remove destructor.
8476 (tui_alloc_content, tui_free_win_content)
8477 (tui_free_all_source_wins_content): Don't declare.
8478 * tui/tui-data.c (tui_initialize_static_data): Update.
8479 (init_content_element, tui_alloc_content): Remove.
8480 (~tui_gen_win_info): Update.
8481 (~tui_data_window, tui_free_all_source_wins_content)
8482 (tui_free_win_content, free_content, free_content_elements):
8485 2019-06-25 Tom Tromey <tom@tromey.com>
8487 * tui/tui-winsource.h (tui_clear_source_content)
8488 (tui_erase_source_content, tui_show_source_content): Change type
8490 * tui/tui-winsource.c (tui_clear_source_content)
8491 (tui_erase_source_content, tui_show_source_content): Change type
8493 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8494 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8496 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8498 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8500 2019-06-25 Tom Tromey <tom@tromey.com>
8502 * tui/tui-winsource.c (tui_clear_source_content)
8503 (tui_source_window_base::set_is_exec_point_at): Update.
8504 * tui/tui-source.c (tui_set_source_content_nil): Update.
8505 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8507 * tui/tui-data.c (init_content_element): Update.
8509 2019-06-25 Tom Tromey <tom@tromey.com>
8511 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8512 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8513 * tui/tui-layout.c (init_and_make_win): Update.
8514 * tui/tui.h (enum tui_win_type): Update.
8515 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8516 tui_win_is_auxillary.
8517 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8518 tui_win_is_auxillary.
8520 2019-06-25 Tom Tromey <tom@tromey.com>
8522 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8523 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8524 (tui_delete_data_content_windows, tui_display_all_data)
8525 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8527 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8528 * tui/tui-regs.c (tui_last_regs_line_no)
8529 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8530 (tui_show_registers): Update.
8531 (tui_show_register_group): Return void. Update.
8532 (tui_display_registers_from, tui_display_reg_element_at_line)
8533 (tui_display_registers_from_line, tui_check_register_values):
8535 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8537 (struct tui_data_window) <regs_content>: Now a std::vector.
8538 <regs_content_count>: Remove.
8539 (tui_add_content_elements, tui_free_data_content): Don't declare.
8540 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8541 (init_content_element): Remove DATA_WIN case. Add assert.
8542 (tui_add_content_elements): Remove.
8543 (tui_data_window): Update.
8544 (tui_free_data_content): Remove.
8545 (free_content_elements): Remove DATA_WIN case.
8547 2019-06-25 Tom Tromey <tom@tromey.com>
8549 * tui/tui-data.c (tui_data_item_window): Update.
8550 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8551 * tui/tui-windata.c (tui_display_all_data)
8552 (tui_display_data_from_line): Update.
8553 (tui_check_data_values): Remove.
8554 * tui/tui-regs.c (tui_show_register_group)
8555 (tui_display_reg_element_at_line): Update.
8556 * tui/tui-hooks.c (tui_register_changed)
8557 (tui_refresh_frame_and_register_information): Call
8558 tui_check_register_values.
8559 * tui/tui-data.h (struct tui_data_window) <data_content,
8560 data_content_count, data_type>: Remove.
8561 (enum tui_data_type): Remove.
8563 * tui/tui-data.c (tui_data_window::clear_detail)
8564 (~tui_data_window): Update.
8566 2019-06-25 Tom Tromey <tom@tromey.com>
8568 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8570 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8571 Rename from tui_first_data_item_displayed. Update.
8572 (tui_data_window::refresh_all)
8573 (tui_data_window::do_scroll_vertical): Update.
8574 * tui/tui-data.h (struct tui_data_window)
8575 <first_data_item_displayed>: Declare new method.
8577 2019-06-25 Tom Tromey <tom@tromey.com>
8579 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8580 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8582 (tui_initialize_static_data): ...here.
8584 2019-06-25 Tom Tromey <tom@tromey.com>
8586 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8587 (tui_display_registers_from, tui_check_register_values): Update.
8588 (tui_display_register): Remove win_info parameter; update.
8589 (tui_get_register): Change type of parameters.
8590 * tui/tui-data.h (struct tui_data_element): Remove.
8591 (union tui_which_element) <data>: Remove.
8592 <data_window>: Change type.
8593 (struct tui_data_item_window): New.
8594 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8596 (~tui_data_item_window): New destructor.
8597 (free_content_elements): Remove DATA_ITEM_WIN case.
8599 2019-06-25 Tom Tromey <tom@tromey.com>
8601 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8604 2019-06-25 Tom Tromey <tom@tromey.com>
8606 * tui/tui-data.h (struct tui_command_element): Remove.
8607 (union tui_which_element) <command>: Remove.
8608 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8610 (free_content_elements): Remove CMD_WIN case.
8612 2019-06-25 Tom Tromey <tom@tromey.com>
8614 * tui/tui-layout.c (tui_set_layout): Update.
8615 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8616 * tui/tui-data.c (layout_def): Update.
8618 2019-06-25 Tom Tromey <tom@tromey.com>
8620 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8621 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8622 (tui_source_window_base::set_new_height): Update.
8623 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8625 (tui_set_locator_fullname, tui_set_locator_info)
8626 (tui_show_frame_info): Update.
8627 * tui/tui-source.c (tui_set_source_content)
8628 (tui_source_is_displayed): Update.
8629 * tui/tui-layout.c (show_source_disasm_command, show_data)
8630 (show_source_or_disasm_and_command): Update.
8631 * tui/tui-disasm.c (tui_set_disassem_content)
8632 (tui_get_begin_asm_address): Update.
8633 * tui/tui-data.h (struct tui_locator_element): Remove.
8634 (union tui_which_element) <locator>: Remove.
8635 (struct tui_locator_window): New.
8636 (tui_locator_win_info_ptr): Change return type.
8637 * tui/tui-data.c (_locator): Change type.
8638 (tui_locator_win_info_ptr): Change return type.
8639 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8640 (tui_alloc_content): Add assert.
8642 2019-06-25 Tom Tromey <tom@tromey.com>
8644 * tui/tui-winsource.c
8645 (tui_exec_info_window::maybe_allocate_content): New method.
8646 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8647 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8648 (make_source_or_disasm_window): Add cast.
8649 * tui/tui-data.h (union tui_which_element) <simple_string>:
8651 (struct tui_source_info): New.
8652 (struct tui_source_window_base) <execution_info>: Change type.
8653 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8654 case, and add assert.
8655 (tui_alloc_content): Add assert.
8657 2019-06-25 Tom Tromey <tom@tromey.com>
8659 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8660 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8661 * tui/tui-data.c (tui_alloc_win_info): Remove.
8663 2019-06-25 Tom Tromey <tom@tromey.com>
8665 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8666 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8669 2019-06-25 Tom Tromey <tom@tromey.com>
8671 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8672 make_visible_with_new_height method.
8673 (tui_win_info::make_visible_with_new_height): New method.
8674 (tui_source_window_base::do_make_visible_with_new_height)
8675 (tui_data_window::do_make_visible_with_new_height)
8676 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8677 (make_visible_with_new_height): Remove.
8678 (tui_resize_all, tui_adjust_win_heights): Use
8679 make_visible_with_new_height method.
8680 * tui/tui-data.h (struct tui_win_info)
8681 <do_make_visible_with_new_height, make_visible_with_new_height>:
8683 (struct tui_source_window_base, struct tui_data_window)
8684 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8687 2019-06-25 Tom Tromey <tom@tromey.com>
8689 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8691 (update_tab_width): Call update_tab_width method.
8692 * tui/tui-data.h (struct tui_win_info)
8693 (struct tui_source_window_base) <update_tab_width>: New methods.
8695 2019-06-25 Tom Tromey <tom@tromey.com>
8697 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8699 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8701 (tui_gen_win_info::make_visible): Update.
8702 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8704 * tui/tui-data.h (enum tui_box): New enum.
8705 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8707 2019-06-25 Tom Tromey <tom@tromey.com>
8709 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8710 init_and_make_win for EXEC_INFO_WIN.
8711 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8713 (struct tui_win_info) <~tui_win_info>: Inline.
8714 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8716 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8717 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8719 (tui_initialize_static_data): Update.
8720 (~tui_gen_win_info): Handle more cleanup here.
8721 (~tui_source_window_base): Delete "execution_info".
8722 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8724 2019-06-25 Tom Tromey <tom@tromey.com>
8726 * tui/tui-layout.c (make_command_window): Don't set
8728 (show_source_disasm_command): Call the reset method.
8729 (show_data): Don't set can_highlight. Call the reset method.
8730 (tui_gen_win_info::reset): Rename from init_gen_win_info
8731 (init_and_make_win): Simplify. Return tui_gen_win_info.
8732 (show_source_or_disasm_and_command): Call the reset method.
8733 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8734 (struct tui_cmd_window): Set can_highlight.
8736 2019-06-25 Tom Tromey <tom@tromey.com>
8738 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8740 (tui_make_visible, tui_make_invisible): Rewrite.
8741 (tui_win_info::make_visible): Remove.
8742 (tui_source_window_base::make_visible): Update.
8743 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8744 method. Moved from...
8745 (struct tui_win_info) <make_visible>: ...here.
8747 2019-06-25 Tom Tromey <tom@tromey.com>
8749 * tui/tui-winsource.c
8750 (tui_source_window_base::do_scroll_horizontal): Remove direction
8752 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8753 direction parameter.
8754 * tui/tui-win.c (tui_win_info::forward_scroll)
8755 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8756 (tui_win_info::right_scroll): Update.
8757 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8758 direction parameter.
8759 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8760 direction parameter.
8761 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8762 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8763 Remove direction parameter.
8764 (struct tui_source_window_base, struct tui_source_window)
8765 (struct tui_disasm_window, struct tui_data_window)
8766 (struct tui_cmd_window): Update.
8768 2019-06-25 Tom Tromey <tom@tromey.com>
8770 * tui/tui-winsource.h (tui_set_exec_info_content)
8771 (tui_show_exec_info_content, tui_erase_exec_info_content)
8772 (tui_clear_exec_info_content, tui_update_exec_info): Change
8773 argument to tui_source_window_base.
8774 * tui/tui-winsource.c (tui_set_exec_info_content)
8775 (tui_show_exec_info_content, tui_erase_exec_info_content)
8776 (tui_clear_exec_info_content, tui_update_exec_info): Change
8777 argument to tui_source_window_base.
8779 2019-06-25 Tom Tromey <tom@tromey.com>
8781 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8782 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8784 2019-06-25 Tom Tromey <tom@tromey.com>
8786 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8789 2019-06-25 Tom Tromey <tom@tromey.com>
8791 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8793 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8795 * tui/tui-source.c (tui_set_source_content): Update.
8796 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8798 2019-06-25 Tom Tromey <tom@tromey.com>
8800 * tui/tui-win.c (window_name_completer, tui_set_focus)
8801 (tui_all_windows_info): Use name method.
8802 * tui/tui-data.h (struct tui_gen_win_info)
8803 (struct tui_source_window, struct tui_disasm_window)
8804 (struct tui_data_window, struct tui_cmd_window) <name>: New
8806 (tui_win_name): Don't declare.
8807 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8808 (tui_win_name): Remove.
8810 2019-06-25 Tom Tromey <tom@tromey.com>
8812 * tui/tui-winsource.h (tui_update_source_window)
8813 (tui_update_source_window_as_is): Change parameter type.
8814 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8815 to be a tui_source_window_base.
8816 (tui_update_source_window_as_is): Likewise.
8817 * tui/tui-win.c (make_visible_with_new_height): Update.
8819 2019-06-25 Tom Tromey <tom@tromey.com>
8821 * tui/tui-winsource.c (tui_erase_source_content)
8822 (tui_show_source_content, tui_show_exec_info_content)
8823 (tui_erase_exec_info_content): Use refresh_window method.
8824 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8825 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8826 from tui_refresh_win.
8827 (tui_data_window::refresh_window): New method.
8828 (tui_win_info::refresh, tui_source_window_base::refresh)
8829 (tui_refresh_all): Use refresh_window method.
8830 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8832 * tui/tui-regs.c (tui_display_register): Call refresh_window
8834 * tui/tui-layout.c (show_source_disasm_command)
8835 (show_source_or_disasm_and_command): Call refresh_window method.
8836 * tui/tui-data.h (struct tui_gen_win_info)
8837 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8840 2019-06-25 Tom Tromey <tom@tromey.com>
8842 * tui/tui.c (tui_rl_other_window, tui_enable)
8843 (tui_is_window_visible, tui_get_command_dimension): Update.
8844 * tui/tui-winsource.c (tui_update_source_window_as_is)
8845 (tui_clear_source_content, tui_erase_source_content)
8846 (tui_show_source_line, tui_source_window_base::refill)
8847 (tui_source_window_base::do_scroll_horizontal)
8848 (tui_source_window_base::set_is_exec_point_at)
8849 (tui_update_breakpoint_info, tui_set_exec_info_content)
8850 (tui_alloc_source_buffer, tui_line_is_displayed)
8851 (tui_addr_is_displayed): Update.
8852 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8853 (tui_check_and_display_highlight_if_needed)
8854 (tui_win_info::make_visible, tui_win_info::refresh)
8855 (tui_refresh_all): Update.
8856 * tui/tui-windata.c (tui_first_data_item_displayed)
8857 (tui_delete_data_content_windows, tui_erase_data_content)
8858 (tui_display_all_data, tui_data_window::refresh_all)
8859 (tui_check_data_values): Update.
8860 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8861 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8862 (tui_win_info::backward_scroll, tui_refresh_all_win)
8863 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8864 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8865 (tui_source_window_base::set_new_height)
8866 (tui_data_window::set_new_height)
8867 (make_invisible_and_set_new_height)
8868 (make_visible_with_new_height, new_height_ok)
8869 (parse_scrolling_args): Update.
8870 * tui/tui-stack.c (tui_show_frame_info): Update.
8871 * tui/tui-source.c (tui_set_source_content)
8872 (tui_set_source_content_nil, tui_source_is_displayed)
8873 (tui_source_window::do_scroll_vertical): Update.
8874 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8875 (tui_display_registers_from, tui_display_reg_element_at_line)
8876 (tui_check_register_values, tui_reg_command): Update.
8877 * tui/tui-layout.c (tui_default_win_height)
8878 (show_source_disasm_command, show_data, init_and_make_win)
8879 (show_source_or_disasm_and_command): Update.
8880 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8881 (tui_redisplay_readline, tui_mld_flush)
8882 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8884 * tui/tui-disasm.c (tui_set_disassem_content)
8885 (tui_disasm_window::do_scroll_vertical): Update.
8886 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8888 (struct tui_win_info): Derive from tui_gen_win_info.
8889 <~tui_win_info>: Mark as override.
8890 <generic>: Remove member.
8891 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8892 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8893 (~tui_data_window, ~tui_win_info)
8894 (tui_free_all_source_wins_content): Update.
8895 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8897 2019-06-25 Tom Tromey <tom@tromey.com>
8899 * tui/tui-layout.c (init_and_make_win): Use new.
8900 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8901 destructor, initializers.
8902 (tui_alloc_generic_win_info): Don't declare.
8903 * tui/tui-data.c (_locator): Add argument to constructor.
8904 (source_win, disasm_win): New globals.
8905 (exec_info): Remove.
8906 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8908 (tui_alloc_generic_win_info): Remove.
8909 (init_content_element): Use new.
8910 (tui_win_info::tui_win_info): Update.
8911 (free_content_elements) <case DATA_WIN>: Use delete.
8913 2019-06-25 Tom Tromey <tom@tromey.com>
8915 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8916 * tui/tui-windata.c (tui_first_data_item_displayed)
8917 (tui_delete_data_content_windows): Update.
8918 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8919 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8920 (tui_display_registers_from, tui_check_register_values): Update.
8921 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8923 * tui/tui-data.c (init_content_element): Update. Allocate the new
8925 (tui_free_data_content): Update.
8926 (free_content_elements) <case DATA_WIN>: Free the window.
8928 2019-06-25 Tom Tromey <tom@tromey.com>
8930 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8932 * tui/tui-layout.c (make_command_window)
8933 (show_source_disasm_command, show_data, init_and_make_win)
8934 (show_source_or_disasm_and_command): Update.
8935 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8937 <can_highight, is_highlighted>: Now bool.
8938 (tui_set_win_highlight): Don't declare.
8939 * tui/tui-data.c (tui_set_win_highlight): Remove.
8941 2019-06-25 Tom Tromey <tom@tromey.com>
8943 * tui/tui-wingeneral.c (make_visible): Remove check of window
8946 2019-06-25 Tom Tromey <tom@tromey.com>
8948 * tui/tui-win.c (tui_win_info::max_height)
8949 (tui_cmd_window::max_height): New methods.
8950 (new_height_ok): Call max_height.
8951 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8952 <max_height>: New method.
8954 2019-06-25 Tom Tromey <tom@tromey.com>
8956 * tui/tui-win.c (tui_source_window_base::set_new_height)
8957 (tui_data_window::set_new_height): New methods.
8958 (make_invisible_and_set_new_height): Call set_new_height method.
8959 * tui/tui-data.h (struct tui_win_info)
8960 (struct tui_source_window_base, struct tui_data_window)
8961 <set_new_height>: New method.
8963 2019-06-25 Tom Tromey <tom@tromey.com>
8965 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8966 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8967 tui_refresh_data_win.
8968 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8970 (tui_refresh_all_win): Call the refresh_all method.
8971 (tui_set_focus): Likewise.
8972 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8973 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8976 2019-06-25 Tom Tromey <tom@tromey.com>
8978 * tui/tui-winsource.h (tui_refill_source_window)
8979 (tui_set_is_exec_point_at): Don't declare.
8980 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8981 (tui_source_window_base::refill): Rename from
8982 tui_refill_source_window.
8983 (tui_source_window_base::do_scroll_horizontal): Update.
8984 (tui_source_window_base::set_is_exec_point_at): Rename from
8985 tui_set_is_exec_point_at.
8986 (tui_update_all_breakpoint_info): Update.
8987 * tui/tui-stack.c (tui_show_frame_info): Update.
8988 * tui/tui-layout.c (show_data): Add cast.
8989 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8990 * tui/tui-data.h (struct tui_source_window_base) <refill,
8991 set_is_exec_point_at>: New methods.
8992 (tui_source_windows, tui_add_to_source_windows): Update types.
8993 (tui_add_to_source_windows): Remove redundant declaration.
8994 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8995 (tui_source_windows): Change return type.
8996 (tui_clear_source_windows_detail): Update.
8997 (tui_add_to_source_windows): Change type of parameter.
8998 (tui_free_all_source_wins_content): Update.
9000 2019-06-25 Tom Tromey <tom@tromey.com>
9002 * tui/tui-wingeneral.c (tui_win_info::refresh)
9003 (tui_source_window_base::refresh): New methods.
9004 (tui_refresh_all): Call the refresh method.
9005 * tui/tui-data.h (struct tui_win_info)
9006 (struct tui_source_window_base) <refresh>: New method.
9008 2019-06-25 Tom Tromey <tom@tromey.com>
9010 * tui/tui.h (tui_is_window_visible): Return bool.
9011 * tui/tui.c (tui_is_window_visible): Return bool.
9012 * tui/tui-wingeneral.c (tui_make_window, make_visible)
9013 (tui_make_visible, tui_make_invisible)
9014 (tui_win_info::make_visible)
9015 (tui_source_window_base::make_visible, make_all_visible)
9016 (tui_make_all_visible, tui_make_all_invisible): Update.
9017 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
9018 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
9020 (struct tui_win_info, struct tui_source_window_base)
9021 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
9022 * tui/tui-data.c (tui_init_generic_part): Update.
9024 2019-06-25 Tom Tromey <tom@tromey.com>
9026 * tui/tui-wingeneral.c (tui_win_info::make_visible)
9027 (tui_source_window_base::make_visible): New methods.
9028 (make_all_visible): Make method call.
9029 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
9030 (struct tui_source_window_base, struct tui_cmd_window): Override
9032 (tui_win_is_source_type): Don't declare.
9033 * tui/tui-data.c (tui_win_is_source_type): Remove.
9035 2019-06-25 Tom Tromey <tom@tromey.com>
9037 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9040 2019-06-25 Tom Tromey <tom@tromey.com>
9042 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9043 Inline constructor. Add initializers for members.
9044 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9045 constructors; now inline in class.
9047 2019-06-25 Tom Tromey <tom@tromey.com>
9049 * tui/tui-regs.c (tui_show_registers): Update.
9050 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9052 * tui/tui-data.c (tui_data_window::clear_detail)
9053 (tui_data_window): Update.
9055 2019-06-25 Tom Tromey <tom@tromey.com>
9057 * tui/tui-windata.c (tui_display_all_data)
9058 (tui_display_data_from_line, tui_display_data_from)
9059 (tui_check_data_values, tui_data_window::do_scroll_vertical):
9061 * tui/tui-regs.c (tui_last_regs_line_no)
9062 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9063 (tui_show_registers, tui_show_register_group)
9064 (tui_display_registers_from, tui_display_reg_element_at_line)
9065 (tui_display_registers_from_line, tui_check_register_values)
9066 (tui_reg_next, tui_reg_prev): Update.
9067 * tui/tui-layout.c (tui_set_layout, show_data): Update.
9068 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
9070 (struct tui_win_info) <detail>: Remove. Add new fields from
9072 (TUI_DATA_WIN): Add cast.
9073 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9074 (~tui_data_window): Simplify.
9076 2019-06-25 Tom Tromey <tom@tromey.com>
9078 * tui/tui-layout.c (show_source_disasm_command)
9079 (show_source_or_disasm_and_command): Update.
9080 * tui/tui-io.c (update_cmdwin_start_line)
9081 (tui_redisplay_readline): Update.
9082 * tui/tui-data.h (struct tui_command_info): Remove.
9083 (struct tui_win_info) <detail>: Remove command_info member.
9084 (struct tui_data_window) <start_line>: New member, from
9086 (TUI_CMD_WIN): Add casts.
9088 2019-06-25 Tom Tromey <tom@tromey.com>
9090 * tui/tui-winsource.c (tui_update_source_window)
9091 (tui_refill_source_window)
9092 (tui_source_window_base::do_scroll_horizontal)
9093 (tui_update_breakpoint_info, tui_set_exec_info_content)
9094 (tui_show_exec_info_content, tui_erase_exec_info_content)
9095 (tui_clear_exec_info_content): Update.
9096 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9098 * tui/tui-win.c (make_invisible_and_set_new_height)
9099 (make_visible_with_new_height): Update.
9100 * tui/tui-source.c (tui_set_source_content)
9101 (tui_show_symtab_source): Update.
9102 * tui/tui-layout.c (extract_display_start_addr)
9103 (show_source_disasm_command, show_data)
9104 (make_source_or_disasm_window)
9105 (show_source_or_disasm_and_command): Update.
9106 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9107 (tui_disasm_window::do_scroll_vertical): Remove shadowing
9109 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
9110 to tui_source_window_base.
9111 (struct tui_win_info) <detail>: Remove source_info member.
9112 (struct tui_source_window_base) <has_locator>: Inline.
9113 Move contents from tui_source_info; rename has_locator member to
9115 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9116 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9118 (tui_source_window_base::clear_detail, ~tui_source_window_base):
9120 (tui_free_all_source_wins_content): Cast to
9121 tui_source_window_base.
9123 2019-06-25 Tom Tromey <tom@tromey.com>
9125 * tui/tui-win.c (make_invisible_and_set_new_height)
9126 (make_visible_with_new_height): Call has_locator method.
9127 * tui/tui-layout.c (show_source_disasm_command, show_data)
9128 (show_source_or_disasm_and_command): Update for bool change.
9129 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9130 (tui_win_info) <has_locator>: New method.
9131 (struct tui_source_window_base) <has_locator>: New method.
9132 (tui_win_has_locator): Don't declare.
9133 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9134 from tui_win_has_locator.
9135 (tui_source_window_base): Use false, not FALSE.
9137 2019-06-25 Tom Tromey <tom@tromey.com>
9139 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9140 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9141 clear_detail method directly.
9142 (tui_clear_win_detail): Remove.
9144 2019-06-25 Tom Tromey <tom@tromey.com>
9146 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9147 "this", not TUI_DISASM_WIN.
9149 2019-06-25 Tom Tromey <tom@tromey.com>
9151 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
9153 * tui/tui-winsource.c
9154 (tui_source_window_base::do_scroll_horizontal): Rename from
9155 tui_horizontal_source_scroll.
9156 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9157 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9158 from tui_vertical_data_scroll.
9159 * tui/tui-win.h (tui_scroll): Don't declare.
9160 * tui/tui-win.c (tui_win_info::forward_scroll)
9161 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9162 (tui_win_info::right_scroll): Rename and update.
9163 (tui_scroll_forward_command, tui_scroll_backward_command)
9164 (tui_scroll_left_command, tui_scroll_right_command): Update.
9165 (tui_scroll): Remove.
9166 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9167 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9168 from tui_vertical_source_scroll.
9169 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9170 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9171 from tui_vertical_disassem_scroll.
9172 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9173 do_scroll_horizontal>: New methods.
9174 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9176 (struct tui_source_window_base): Add do_scroll_horizontal.
9177 (struct tui_source_window, struct tui_disasm_window): Add
9179 (struct tui_data_window, struct tui_cmd_window): Add
9180 do_scroll_horizontal and do_scroll_vertical.
9181 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9183 2019-06-25 Tom Tromey <tom@tromey.com>
9185 * tui/tui-data.h (struct tui_source_window_base): New struct.
9186 (struct tui_source_window): Derive from tui_source_window_base.
9187 (struct tui_disasm_window): New struct.
9188 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9189 from tui_source_window::clear_detail.
9190 (tui_source_window_base): Rename from tui_source_window.
9191 (~tui_source_window_base): Rename from ~tui_source_window.
9192 (tui_alloc_win_info): Create a tui_disasm_window.
9194 2019-06-25 Tom Tromey <tom@tromey.com>
9196 * tui/tui-data.h (struct tui_source_window)
9197 (struct tui_data_window): Declare destructors.
9198 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9200 (tui_win_info): Simplify.
9202 2019-06-25 Tom Tromey <tom@tromey.com>
9204 * tui/tui-winsource.c (tui_display_main)
9205 (tui_update_source_windows_with_addr)
9206 (tui_update_all_breakpoint_info): Update.
9207 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9208 (new_height_ok, parse_scrolling_args): Update.
9209 * tui/tui-stack.c (tui_show_frame_info): Update.
9210 * tui/tui-data.h (struct tui_list): Remove.
9211 (tui_source_windows): Return a reference to a std::vector.
9212 * tui/tui-data.c (source_windows): Now a std::vector.
9213 (tui_source_windows): Change return type.
9214 (tui_clear_source_windows): Rewrite.
9215 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9216 (tui_free_all_source_wins_content): Rewrite.
9218 2019-06-25 Tom Tromey <tom@tromey.com>
9220 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9221 (struct tui_data_window, struct tui_cmd_window): Declare
9222 clear_detail method.
9223 * tui/tui-data.c (tui_source_window::clear_detail)
9224 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9226 (tui_clear_win_detail): Simplify.
9228 2019-06-25 Tom Tromey <tom@tromey.com>
9230 * tui/tui-layout.c (make_source_window, make_disasm_window)
9231 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9232 Return the new window.
9233 (show_source_disasm_command, show_data)
9234 (show_source_or_disasm_and_command): Update.
9236 2019-06-25 Tom Tromey <tom@tromey.com>
9238 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9239 parameter. Return the new window.
9240 (show_source_disasm_command): Update and remove NULL check.
9241 (show_source_or_disasm_and_command): Update.
9243 2019-06-25 Tom Tromey <tom@tromey.com>
9245 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9247 2019-06-25 Tom Tromey <tom@tromey.com>
9249 * tui/tui-data.h (struct tui_win_info): Make constructor
9250 protected. Make destructor virtual. Add initializers.
9251 (tui_source_window, tui_data_window, tui_cmd_window): New
9253 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9254 constructor. Add "type" parameter.
9255 (tui_source_window, tui_data_window, tui_cmd_window): New
9257 (tui_alloc_win_info): Instantiate the appropriate subclass.
9259 2019-06-25 Tom Tromey <tom@tromey.com>
9261 * tui/tui-win.c (tui_resize_all): Use delete.
9262 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9264 (tui_free_window): Don't declare.
9265 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9268 2019-06-25 Tom Tromey <tom@tromey.com>
9270 * tui/tui-data.h (struct tui_win_info): Add constructor.
9271 * tui/tui-data.c (tui_alloc_win_info): Use new.
9272 (tui_free_window): Use delete.
9274 2019-06-22 Tom Tromey <tom@tromey.com>
9276 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9278 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9280 2019-06-22 Tom Tromey <tom@tromey.com>
9282 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9284 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9286 2019-06-22 Tom de Vries <tdevries@suse.de>
9288 * dwarf2read.c (create_addrmap_from_aranges)
9289 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9292 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
9294 * dwarf2read.h (dwarf2_section_info_def): Remove.
9295 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9296 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9297 std::vector<dwarf2_section_info>.
9298 (struct dwo_file) <~dwo_file>: Remove.
9299 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9301 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9302 (dwarf2_read_debug_names): Likewise.
9303 (create_debug_types_hash_table): Change parameter type to
9304 array_view, adjust code accordingly.
9305 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9306 (partial_die_info::fixup): Likewise.
9307 (determine_prefix): Likewise.
9308 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9310 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9312 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9314 <~dwo_file>: Remove call to gdb_bfd_unref.
9315 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9316 gdb_bfd_ref_ptr::get.
9318 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9320 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9322 * dwarf2read.c (struct dwo_file): Initialize fields.
9324 (free_dwo_file): Remove, move content to ~dwo_file.
9325 (struct dwo_file_deleter): Remove.
9326 (dwo_file_up>: Remove custom deleter.
9327 (free_dwo_files): Remove.
9328 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9330 (process_skeletonless_type_units): Call unique_ptr::get.
9331 (allocate_dwo_file_hash_table): Add deleter to created hash
9332 table. Change return type to htab_up.
9333 (lookup_dwo_file_slot): Don't memset dwo_file, call
9335 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9336 (create_dwo_unit_in_dwp_v2): Likewise.
9337 (open_and_init_dwo_file): Likewise.
9338 (free_dwo_file_from_slot): Remove.
9340 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9342 * dwarf2read.h (struct dwarf2_section_info) <readin,
9343 is_virtual>: Change type to bool.
9344 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9347 2019-06-19 Tom Tromey <tom@tromey.com>
9349 * tui/tui-data.h (tui_init_content_element): Don't declare.
9351 2019-06-19 Tom Tromey <tom@tromey.com>
9353 * tui/tui-data.h (tui_init_win_info): Don't declare.
9355 2019-06-19 Tom de Vries <tdevries@suse.de>
9357 * dwarf2read.h (abstract_to_concrete): Change type to
9358 std::unordered_map<sect_offset, std::vector<sect_offset>,
9359 gdb::hash_enum<sect_offset>>.
9361 2019-06-19 Tom Tromey <tromey@adacore.com>
9363 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9364 EVAL_AVOID_SIDE_EFFECTS specially.
9366 2019-06-19 Tom Tromey <tromey@adacore.com>
9368 * source-cache.c (highlighter): New global.
9369 (source_cache::get_source_lines): Create a highlighter on demand.
9371 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9373 * defs.h (deprecated_interactive_hook): Delete declaration.
9374 * interps.c (clear_interpreter_hooks): Remove use of
9375 deprecated_interactive_hook.
9376 * top.c (deprecated_interactive_hook): Delete definition.
9377 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9379 2019-06-18 Tom de Vries <tdevries@suse.de>
9382 * dwarf2read.h (abstract_to_concrete): Change type from
9383 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9384 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9385 * dwarf2read.c (read_variable): Update.
9386 (dwarf2_fetch_die_loc_sect_off): Update.
9388 2019-06-17 Tom de Vries <tdevries@suse.de>
9391 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9392 accessing parent[parent_len - 1].
9394 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9397 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9398 call dtrace_process_dof with NULL dof.
9400 2019-06-16 Tom de Vries <tdevries@suse.de>
9403 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9405 2019-06-16 Tom Tromey <tom@tromey.com>
9407 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9408 (make_all_visible): Use address of member.
9410 2019-06-16 Tom Tromey <tom@tromey.com>
9412 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9413 (tui_free_window, free_content, free_content_elements): Remove
9415 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9417 * tui/tui-regs.c (tui_show_register_group)
9418 (tui_display_registers_from, tui_display_reg_element_at_line):
9419 Remove unnecessary cast.
9421 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9423 * linux-nat.c (normal_mask): Delete.
9424 (_initialize_linux_nat): Don't initialise normal_mask.
9426 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9429 * dwarf-index-write.h (write_psymtabs_to_index): Add
9430 dwz_basename parameter.
9431 * dwarf-index-write.c (write_gdbindex): Move file writing to
9432 write_gdbindex_1. Change return type void.
9433 (assert_file_size): Move up, remove filename parameter.
9434 (write_gdbindex_1): New function.
9435 (write_debug_names): Change return type to void, call
9437 (struct index_wip_file): New struct.
9438 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9439 file logic to index_wip_file. Write index for dwz file if
9441 (save_gdb_index_command): Pass basename of dwz file, if present.
9442 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9443 build-id of dwz file, if present.
9444 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9445 (dwarf2_get_dwz_file): Likewise.
9446 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9447 (dwarf2_get_dwz_file): Likewise.
9449 2019-06-16 Tom Tromey <tom@tromey.com>
9451 * coffread.c (process_coff_symbol): Use xstrdup.
9452 * value.c (create_internalvar): Use xstrdup.
9454 2019-06-16 Tom Tromey <tom@tromey.com>
9456 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9457 * breakpoint.c (stopin_command, stopat_command)
9458 (until_break_command, decode_location_default): Remove unnecessary
9460 * utils.c (subset_compare): Remove unnecessary cast.
9461 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9463 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9465 * infcmd.c (path_command): Remove unnecessary cast.
9466 * coffread.c (decode_type): Remove unnecessary cast.
9467 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9468 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9469 * tui/tui-stack.c (tui_show_locator_content)
9470 (tui_show_frame_info): Remove unnecessary cast.
9471 * tui/tui-win.c (tui_scroll_forward_command)
9472 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9473 (parse_scrolling_args): Remove unnecessary cast.
9474 * tui/tui-data.c (init_win_info, tui_del_window)
9475 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9476 (free_content_elements): Remove unnecessary cast.
9477 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9479 * tui/tui-source.c (tui_set_source_content)
9480 (tui_vertical_source_scroll): Remove unnecessary cast.
9481 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9483 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9484 * tui/tui-regs.c (tui_display_registers_from)
9485 (tui_display_register): Remove unnecessary cast.
9486 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9487 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9488 (make_visible): Remove unnecessary cast.
9489 * tui/tui-winsource.c (tui_erase_source_content)
9490 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9492 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9493 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9494 * stabsread.c (read_type, read_array_type, read_range_type):
9495 Remove unnecessary cast.
9496 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9497 (parse_symbol, parse_type, upgrade_type, parse_external)
9498 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9500 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9502 2019-06-16 Tom Tromey <tom@tromey.com>
9504 * tui/tui-data.c (tui_alloc_generic_win_info)
9505 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9508 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9509 Andrew Burgess <andrew.burgess@embecosm.com>
9511 * f-typeprint.c (f_print_type): Don't return early for not
9512 associated or not allocated types.
9513 (f_type_print_varspec_suffix): Add print_rank parameter and print
9514 ranks of array types in case they dangling.
9515 (f_type_print_base): Add print_rank parameter.
9517 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9519 * NEWS: Mention new MI commands.
9520 * break-catch-throw.c (enum exception_event_kind): Move to
9522 (print_mention_exception_catchpoint): Output text as a single
9524 (catch_exception_command_1): Rename to...
9525 (catch_exception_event): ...this, make non-static, update header
9526 command, and change some parameter types.
9527 (catch_catch_command): Update for changes to
9528 catch_exception_command_1.
9529 (catch_throw_command): Likewise.
9530 (catch_rethrow_command): Likewise.
9531 * breakpoint.c (enum exception_event_kind): Delete.
9532 * breakpoint.h (enum exception_event_kind): Moved here from
9533 break-catch-throw.c.
9534 (catch_exception_event): Declare.
9535 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9536 (mi_cmd_catch_throw): New function.
9537 (mi_cmd_catch_rethrow): New function.
9538 (mi_cmd_catch_catch): New function.
9539 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9540 'catch-catch' entries.
9541 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9542 (mi_cmd_catch_rethrow): Declare.
9543 (mi_cmd_catch_catch): Declare.
9545 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9547 * annotate.c (annotate_source_line): Change return type to void,
9548 update implementation to match.
9549 * annotate.h (annotate_source_line): Change return type to void,
9550 update header comment.
9551 * stack.c (print_frame_info): Don't change what frame information
9552 is printed based on whether annotations are on or not.
9554 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9556 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9557 (annotate_source): Make static.
9558 (annotate_source_line): Moved from source.c and renamed from
9559 identify_source_line. Update the return type.
9560 * annotate.h (annotate_source): Delete declaration.
9561 (annotate_source_line): Declaration moved from source.h, and
9562 renamed from identify_source_line. Return type updated.
9563 * source.c (identify_source_line): Moved to annotate.c and renamed
9564 to annotate_source_line.
9565 (info_line_command): Remove check of annotation_level.
9566 * source.h (identify_source_line): Move declaration to annotate.h
9567 and rename to annotate_source_line.
9568 * stack.c: Add 'annotate.h' include.
9569 (print_frame_info): Remove check of annotation_level before
9570 calling annotate_source_line.
9572 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9574 * source-cache.c (source_cache::get_plain_source_lines): Use
9575 open_source_file_with_line_charpos instead of just
9576 open_source_file, remove call to find_source_lines.
9577 (source_cache::get_source_lines): Likewise.
9578 * source.c (find_source_lines): Make static.
9579 (get_filename_and_charpos): Renamed into...
9580 (open_source_file_with_line_charpos): ..this along with changes to
9581 return a scoped_fd, and some other minor clean ups.
9582 (identify_source_line): Use open_source_file_with_line_charpos.
9583 (search_command_helper): Use open_source_file_with_line_charpos
9584 instead of just open_source_file, remove call to
9586 * source.h (open_source_file_with_line_charpos): Declare new
9588 (find_source_lines): Delete declaration.
9590 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9592 * source.c (get_filename_and_charpos): Remove fullname
9594 (identify_source_line): Update call to get_filename_and_charpos.
9596 2019-06-14 Tom Tromey <tromey@adacore.com>
9599 * ui-style.h (skip_ansi_escape): Update comment.
9600 * ui-file.h (class no_terminal_escape_file): New class.
9601 * ui-file.c (no_terminal_escape_file::write)
9602 (no_terminal_escape_file::puts): New methods.
9603 * cli/cli-logging.c (handle_redirections): Use
9604 no_terminal_escape_file.
9606 2019-06-14 Tom Tromey <tromey@adacore.com>
9608 * NEWS: Move convenience variable news above Python news.
9610 2019-06-14 Tom Tromey <tom@tromey.com>
9612 * gnulib: Move directory to top-level.
9613 * configure.ac: Don't configure gnulib.
9614 * configure: Rebuild.
9615 * common/common-defs.h: Use new path to gnulib.
9616 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9618 (INCGNU): Look in new gnulib location.
9619 (HFILES_NO_SRCDIR): Remove gnulib files.
9620 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9621 (generated_files): Remove GNULIB_H.
9622 ($(LIBGNU), all-lib): Remove targets.
9623 (distclean): Don't mention GNULIB_BUILDDIR.
9624 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9626 2019-06-14 Tom Tromey <tromey@adacore.com>
9628 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9629 Warn if symbol file does not provide any symbols.
9631 2019-06-14 Tom Tromey <tromey@adacore.com>
9633 * source.c (find_and_open_source): Respect basenames_may_differ.
9635 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9637 * annotate.c (annotate_breakpoints_invalid): Make use of
9638 scoped_restore_terminal_state.
9639 (annotate_frames_invalid): Likewise.
9641 2019-06-14 Tom Tromey <tromey@adacore.com>
9643 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9644 allow assignment to an internalvar.
9646 2019-06-14 Tom Tromey <tromey@adacore.com>
9648 * ada-lex.l: Allow "_" in attribute names.
9650 2019-06-14 Tom Tromey <tromey@adacore.com>
9653 * regcache.c (registers_changed): Don't call alloca.
9654 * top.c (execute_command): Don't call alloca.
9656 2019-06-13 Pedro Alves <palves@redhat.com>
9658 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9659 'expression'. When parsing an expression, error out if there's
9660 junk after "unlimited".
9661 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9662 (do_set_command): Adjust calls to is_unlimited_literal.
9664 2019-06-13 Pedro Alves <palves@redhat.com>
9666 * compile/compile.c (make_compile_options_def_group): Add braces
9667 around array_view initializer.
9668 * thread.c (make_thread_apply_all_options_def_group)
9669 (make_thread_apply_all_options_def_group): Likewise.
9671 2019-06-13 Pedro Alves <palves@redhat.com>
9673 * NEWS (New commands): Mention "maint test-options
9674 require-delimiter", "maint test-options unknown-is-error", "maint
9675 test-options unknown-is-operand" and "maint show
9676 test-options-completion-result".
9677 (New command options, command completion): New section.
9678 (Completion improvements): New section.
9679 Mention that you can abbreviate "unlimited".
9681 2019-06-13 Pedro Alves <palves@redhat.com>
9683 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9684 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9685 * unittests/cli-utils-selftests.c (test_parse_flags)
9686 (test_parse_flags_qcs): Delete.
9687 (test_cli_utils): Don't call deleted functions.
9689 2019-06-13 Pedro Alves <palves@redhat.com>
9691 * thread.c: Include "cli/cli-option.h".
9692 (tp_array_compar_ascending): Global.
9693 (tp_array_compar): Delete function.
9694 (tp_array_compar_ascending, tp_array_compar_descending): New
9696 (ascending_option_def, qcs_flag_option_def)
9697 (thr_qcs_flags_option_defs)
9698 (make_thread_apply_all_options_def_group)
9699 (make_thread_apply_options_def_group): New.
9700 (thread_apply_all_command): Use gdb::option::process_options.
9701 (thread_apply_command_completer)
9702 (thread_apply_all_command_completer): New.
9703 (thread_apply_command): Use gdb::option::process_options.
9704 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9705 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9706 to generate help text of "thread apply". Adjust "taas"'s help.
9707 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9708 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9710 2019-06-13 Pedro Alves <palves@redhat.com>
9712 * thread.c (thread_apply_command): Check for invalid TID with
9713 isdigit instead of !isalpha.
9715 2019-06-13 Pedro Alves <palves@redhat.com>
9717 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9718 (validate_flags_qcs): New.
9719 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9720 (validate_flags_qcs): Declare.
9721 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9722 (make_frame_apply_options_def_group): New.
9723 (frame_apply_command_count): Process options with
9724 gdb::option::process_options.
9725 (frame_apply_completer): New.
9726 (frame_apply_level_completer, frame_apply_all_completer)
9727 (frame_apply_completer): New.
9728 (_initialize_stack): Update help of "frame apply", "frame apply
9729 level", "frame apply all" and "faas" to mention supported options
9730 and install command completers.
9731 * stack.h (frame_apply_all_completer): Declare.
9732 * thread.c: Include "stack.h".
9733 (tfaas_command): Add "--".
9734 (_initialize_thread): Update help "tfaas" to mention supported
9735 options and install command completer.
9737 2019-06-13 Pedro Alves <palves@redhat.com>
9739 * completer.c (complete_nested_command_line): New.
9740 (gdb_completion_word_break_characters_throw): Add assertion.
9741 * completer.h (complete_nested_command_line): Declare.
9743 2019-06-13 Pedro Alves <palves@redhat.com>
9745 * stack.c (parse_backtrace_qualifiers): New.
9746 (backtrace_command): Use it.
9747 (backtrace_command_completer): Complete on qualifiers.
9749 2019-06-13 Pedro Alves <palves@redhat.com>
9751 * frame.c: Include "cli/cli-option.h.
9752 (user_set_backtrace_options): New.
9753 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9755 (get_prev_frame): Adjust.
9756 (boolean_option_def, uinteger_option_def)
9757 (set_backtrace_option_defs): New.
9758 (_initialize_frame): Adjust and use
9759 gdb::option::add_setshow_cmds_for_options to install "set
9760 backtrace past-main" and "set backtrace past-entry".
9761 * frame.h: Include "cli/cli-option.h".
9762 (struct frame_print_options): Forward declare.
9763 (print_frame_arguments_all, print_frame_arguments_scalars)
9764 (print_frame_arguments_none): Declare.
9765 (print_entry_values): Delete declaration.
9766 (struct frame_print_options, user_frame_print_options): New.
9767 (struct set_backtrace_options): New.
9768 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9769 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9770 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9771 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9772 (list_args_or_locals): Add frame_print_options parameter.
9773 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9774 * python/py-framefilter.c (enumerate_args): Pass down
9775 USER_FRAME_PRINT_OPTIONS.
9776 * stack.c: Include "cli/cli-option.h".
9777 (print_frame_arguments_all, print_frame_arguments_scalars)
9778 (print_frame_arguments_none): Declare.
9779 (print_raw_frame_arguments, print_entry_values): Delete.
9780 (user_frame_print_options): New.
9781 (boolean_option_def, enum_option_def, frame_print_option_defs):
9783 (struct backtrace_cmd_options): New.
9784 (bt_flag_option_def): New.
9785 (backtrace_command_option_defs): New.
9786 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9787 (print_frame_arg, read_frame_arg, print_frame_args)
9788 (print_frame_info, print_frame): Add frame_print_options parameter
9790 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9791 (backtrace_command_1): Add frame_print_options and
9792 backtrace_cmd_options parameters and use them.
9793 (make_backtrace_options_def_group): New.
9794 (backtrace_command): Process command options with
9795 gdb::option::process_options.
9796 (backtrace_command_completer): New.
9797 (_initialize_stack): Extend "backtrace"'s help to mention
9798 supported options. Install completer for "backtrace".
9799 Install some settings commands with add_setshow_cmds_for_options.
9801 2019-06-13 Pedro Alves <palves@redhat.com>
9803 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9804 and that "set/show print raw frame-arguments" are now deprecated.
9806 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9808 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9809 * stack.c (_initialize_stack): Install "set/show print
9810 raw-frame-arguments", and deprecate "set/show print raw
9812 * valprint.c (_initialize_valprint): Deprecate "set/show print
9815 2019-06-13 Pedro Alves <palves@redhat.com>
9817 * compile/compile.c (struct compile_options): New.
9818 (compile_flag_option_def, compile_command_option_defs)
9819 (make_compile_options_def_group): New.
9820 (compile_file_command): Handle options with
9821 gdb::option::process_options.
9822 (compile_file_command_completer): New function.
9823 (compile_code_command): Handle options with
9824 gdb::option::process_options.
9825 (compile_code_command_completer): New function.
9826 (_initialize_compiler): Install completers for "compile code" and
9827 "compile file". Mention available options in "compile code" and
9828 "compile code"'s help.
9829 * completer.c (advance_to_completion_word): New, factored out from
9831 (advance_to_expression_complete_word_point): ... this.
9832 (advance_to_filename_complete_word_point): New.
9833 * completer.h (advance_to_filename_complete_word_point): New
9836 2019-06-13 Pedro Alves <palves@redhat.com>
9838 * compile/compile.c: Include "cli/cli-option.h".
9839 (compile_print_value): Scope data pointer is now a
9840 value_print_options pointer; adjust.
9841 (compile_print_command): Process options. Scope data pointer is
9842 now a value_print_options pointer; adjust.
9843 (_initialize_compile): Update "compile print"'s help to include
9844 supported options. Install a completer for "compile print".
9845 * cp-valprint.c (show_vtblprint, show_objectprint)
9846 (show_static_field_print): Delete.
9847 (_initialize_cp_valprint): Don't install "set print
9848 static-members", "set print vtbl", "set print object" here.
9849 * printcmd.c: Include "cli/cli-option.h" and
9850 "common/gdb_optional.h".
9851 (print_command_parse_format): Rework to fill in a
9852 value_print_options instead of a format_data.
9853 (print_value): Change parameter type from format_data pointer to
9854 value_print_options reference. Adjust.
9855 (print_command_1): Process options. Adjust to pass down a
9856 value_print_options.
9857 (print_command_completer): New.
9858 (_initialize_printcmd): Install print_command_completer as
9859 handle_brkchars completer for the "print" command. Update
9860 "print"'s help to include supported options.
9861 * valprint.c: Include "cli/cli-option.h".
9862 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9863 here from cp-valprint.c.
9864 (boolean_option_def, uinteger_option_def)
9865 (value_print_option_defs, make_value_print_options_def_group):
9866 New. Use gdb::option::add_setshow_cmds_for_options to install
9867 "set print elements", "set print null-stop", "set print repeats",
9868 "set print pretty", "set print union", "set print array", "set
9869 print address", "set print symbol", "set print array-indexes".
9870 * valprint.h: Include <string> and "cli/cli-option.h".
9871 (make_value_print_options_def_group): Declare.
9872 (print_value): Change parameter type from format_data pointer to
9873 value_print_options reference.
9874 (print_command_completer): Declare.
9876 2019-06-13 Pedro Alves <palves@redhat.com>
9878 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9879 (COMMON_SFILES): Add maint-test-settings.c.
9880 * cli/cli-decode.c (boolean_enums): New global, factored out from
9882 (add_setshow_boolean_cmd): ... here.
9883 * cli/cli-decode.h (boolean_enums): Declare.
9884 * cli/cli-option.c: New file.
9885 * cli/cli-option.h: New file.
9886 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9887 factored out from ...
9888 (parse_cli_boolean_value(const char *)): ... this.
9889 (is_unlimited_literal): Change parameter type to pointer to
9890 pointer. Adjust and advance ARG pointer.
9891 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9892 (parse_cli_var_enum): New, factored out from ...
9893 (do_set_command): ... this. Adjust.
9894 * cli/cli-setshow.h (parse_cli_boolean_value)
9895 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9896 (parse_cli_var_enum): Declare.
9897 * cli/cli-utils.c: Include "cli/cli-option.h".
9898 (get_ulongest): New.
9899 * cli/cli-utils.h (get_ulongest): Declare.
9900 (check_for_argument): New overloads.
9901 * maint-test-options.c: New file.
9903 2019-06-13 Pedro Alves <palves@redhat.com>
9905 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9906 parse a range if "-" is at the end of the string.
9908 2019-06-13 Pedro Alves <palves@redhat.com>
9910 * cli/cli-setshow.c (parse_auto_binary_operation)
9911 (parse_cli_boolean_value): Don't allow "o".
9913 2019-06-13 Pedro Alves <palves@redhat.com>
9915 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9916 * NEWS: Mention maint test-settings KIND.
9917 * maint-test-settings.c: New file.
9919 2019-06-13 Pedro Alves <palves@redhat.com>
9921 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9923 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9926 2019-06-13 Pedro Alves <palves@redhat.com>
9928 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9931 2019-06-13 Pedro Alves <palves@redhat.com>
9933 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9935 2019-06-13 Pedro Alves <palves@redhat.com>
9937 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9938 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9940 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9941 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9943 (check_for_argument): Skip spaces after argument.
9945 2019-06-13 Pedro Alves <palves@redhat.com>
9947 * thread.c (thread_apply_command): Adjust TID parsing.
9948 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9949 detected before end of string.
9950 (tid_is_in_list): Error out if LIST is invalid.
9952 2019-06-13 Pedro Alves <palves@redhat.com>
9954 * completer.c (complete_line_internal_1): Rewind completion word
9956 (completion_tracker::advance_custom_word_point_by): Change
9957 parameter type to int.
9958 * completer.h (completion_tracker::advance_custom_word_point_by):
9961 2019-06-13 Pedro Alves <palves@redhat.com>
9963 * completer.c (advance_to_completion_word): Handle delimiters.
9965 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9967 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9969 2019-06-11 Tom Tromey <tom@tromey.com>
9971 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9972 (xmalloc_failed): Move to alloc.c.
9973 * alloc.c: New file.
9974 * Makefile.in (COMMON_SFILES): Add alloc.c.
9976 2019-06-11 Tom Tromey <tom@tromey.com>
9978 * nat/linux-waitpid.c: Don't include server.h.
9979 (linux_debug): Remove.
9980 (my_waitpid): Update.
9982 2019-06-11 Tom Tromey <tromey@adacore.com>
9984 * infcall.c (_initialize_infcall): Remove trailing newline from
9986 * user-regs.c (_initialize_user_regs): Remove trailing newline
9988 * typeprint.c (_initialize_typeprint): Remove trailing newline
9990 * reverse.c (_initialize_reverse): Remove trailing newlines from
9992 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9994 * language.c (add_set_language_command): Remove trailing newline
9996 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9998 * disasm.c (_initialize_disasm): Remove trailing newline from
10000 * top.c (init_main): Remove trailing newline from help.
10001 * interps.c (_initialize_interpreter): Remove trailing newline
10003 * btrace.c (_initialize_btrace): Remove trailing newlines from
10005 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
10007 * python/python.c (_initialize_python): Remove trailing newline
10009 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
10011 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
10012 from help. Reformat some text.
10013 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
10015 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
10018 2019-06-11 Tom Tromey <tromey@adacore.com>
10020 * darwin-nat.c (darwin_decode_exception_message)
10021 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
10023 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
10025 * valops.c (value_slice): Check for not allocated or not
10028 2019-06-10 Tom de Vries <tdevries@suse.de>
10031 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10032 sure an empty slot (defined by a 32-bit zero pair) is recognized as
10035 2019-06-10 Tom de Vries <tdevries@suse.de>
10038 * linespec.c (linespec_lexer_lex_string): Remove incorrect
10039 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
10041 2019-06-10 Tom de Vries <tdevries@suse.de>
10044 * symtab.c (struct demangled_name_entry): Add language field.
10045 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
10046 static minimal symbol". Set and use language field.
10048 2019-06-10 Tom Tromey <tromey@adacore.com>
10050 * ada-lang.c (_initialize_ada_language): Update help text.
10052 2019-06-10 Tom Tromey <tromey@adacore.com>
10054 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10056 * guile/guile.c (handle_boot_error): Don't end warning with a
10058 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10059 warning with a newline.
10060 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10062 (s12z_frame_cache): Likewise.
10063 * dwarf-index-cache.c (index_cache::store): Don't end warning with
10065 * solib-svr4.c (disable_probes_interface): Don't end warning with
10067 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10069 * python/python.c (do_finish_initialization): Don't end warning
10072 2019-06-10 Tom Tromey <tom@tromey.com>
10074 * python/py-breakpoint.c (gdbpy_breakpoint_created)
10075 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10078 2019-06-10 Tom Tromey <tromey@adacore.com>
10080 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10082 (elf_new_init): Don't call stabsread_new_init.
10083 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10084 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
10085 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10087 2019-06-10 Tom de Vries <tdevries@suse.de>
10091 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10093 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
10095 * source.c (find_and_open_source): Also rewrite relative file
10098 2019-04-26 Amos Bird <amosbird@gmail.com>
10100 * annotate.c (annotate_thread_exited): Add "thread-exited"
10103 2019-06-06 Tom Tromey <tromey@adacore.com>
10105 * maint.h (class scoped_command_stats): Use
10106 DISABLE_COPY_AND_ASSIGN.
10107 <print_time>: New method.
10108 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10110 (scoped_command_stats::print_time): New method.
10112 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
10114 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10115 instructions of lengths 6 or 8 bytes.
10117 2019-06-04 Pedro Alves <palves@redhat.com>
10119 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10121 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10122 * breakpoint.c (condition_completer): Likewise.
10123 * cli/cli-dump.c (scan_expression): Likewise.
10124 * common/filestuff.c (mkdir_recursive): Likewise.
10125 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10126 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10127 (gdb_abspath): Likewise.
10128 * compile/compile-cplus-types.c
10129 (compile_cplus_instance::decl_name): Likewise.
10130 * completer.c (complete_explicit_location):
10131 (signal_completer, reg_or_group_completer_1): Likewise.
10132 * cp-support.c (cp_remove_params_if_any): Likewise.
10133 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10134 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10135 * infcmd.c (strip_bg_char): Likewise.
10136 * linespec.c (copy_token_string): Likewise.
10137 * mi/mi-main.c (output_cores): Likewise.
10138 * psymtab.c (psymtab_search_name):
10139 * symfile.c (test_set_ext_lang_command): Likewise.
10140 * target.c (target_fileio_read_stralloc): Likewise.
10141 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10142 * value.c (complete_internalvar): Likewise.
10144 2019-06-04 Christian Biesinger <cbiesinger@google.com>
10146 Add objfile property to gdb.Type.
10147 * NEWS: Mention Python API addition.
10148 * python/py-type.c (typy_get_objfile): New method.
10150 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10152 * NEWS: Mention the new set|show style [title|highlight].
10153 Mention changes to "show style", "help" and "apropos".
10155 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10157 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10158 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10159 instead of print_help_for_command.
10160 (print_doc_of_command): New function.
10161 (help_list): Add 'apropos -v word' suggestion.
10162 (print_help_for_command): Style the command name using title style.
10163 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10164 (_initialize_cli_cmds): Describe -v in apropos_command help.
10166 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10168 * cli/cli-style.h (cli_style_option): Add name in constructor,
10169 add m_name class member, add constructor with intensity,
10170 add name class function.
10171 (cli_style_option::add_setshow_commands): Remove name argument.
10172 (highlight_style, title_style): New styles.
10173 * cli/cli-style.c (do_show): New function that shows a style
10174 characteristic styling the style name with itself.
10175 (set_style_name): New function.
10176 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10177 Update all callers according to the changes in cli/cli-style.h.
10178 * utils.h (fputs_highlighted): New function.
10179 * utils.c (fputs_highlighted): Likewise.
10181 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10183 * NEWS: Mention new pipe command and new convenience variables.
10185 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10187 * cli/cli-cmds.c (pipe_command): New function.
10188 (_initialize_cli_cmds): Call add_com for pipe_command.
10189 Define | as an alias for pipe.
10190 (exit_status_set_internal_vars): New function.
10191 (shell_escape): Call exit_status_set_internal_vars.
10192 cli/cli-decode.c (find_command_name_length): Recognize | as
10193 a single character command.
10195 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10197 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10198 top.c (execute_command_to_ui_file): New function, mostly a copy
10199 of execute_command_to_string.
10200 (execute_command_to_string): Implement by calling
10201 execute_command_to_ui_file.
10203 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10205 * top.h (saved_command_line): Remove declaration.
10206 * top.c (previous_saved_command_line, previous_repeat_arguments):
10208 (saved_command_line): Make static, define together with other
10209 'repeat variables'.
10210 (dont_repeat): Clear repeat_arguments.
10211 (repeat_previous, get_saved_command_line, save_command_line):
10213 (gdb_init): Initialize saved_command_line
10214 and previous_saved_command_line.
10215 * main.c (captured_main_1): Remove saved_command_line initialization.
10216 * event-top.c (handle_line_of_input): Update to use
10217 the new 'repeat' related functions instead of direct access to
10218 saved_command_line.
10219 * command.h (repeat_previous, get_saved_command_line,
10220 save_command_line): New declarations.
10221 (dont_repeat): Add comment.
10223 2019-05-30 Tom Tromey <tromey@adacore.com>
10225 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10227 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10229 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10232 * completer.c (complete): Initialize variable word.
10234 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10236 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10237 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10238 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10239 'body' is NULL to the outter 'if', protecting the '!is_define'
10242 2019-05-29 Tom Tromey <tromey@adacore.com>
10244 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10245 (dwarf_unknown): New function.
10246 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10247 (dwarf_type_encoding_name): Use dwarf_unknown.
10249 2019-05-29 Tom Tromey <tromey@adacore.com>
10252 * cp-valprint.c (cp_print_value_fields): Call
10253 cp_print_static_field inside "try".
10255 2019-05-29 Tom Tromey <tromey@adacore.com>
10257 * inflow.c (struct terminal_info): Add default operator=.
10258 * configure: Rebuild.
10259 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10260 -Wdeprecated-copy-dtor, -Wredundant-move.
10262 2019-05-29 Tom Tromey <tromey@adacore.com>
10265 * infcmd.c (print_return_value_1): Handle finish_print
10267 (show_print_finish): New function.
10268 (_initialize_infcmd): Add "set/show print finish" commands.
10269 * valprint.c (user_print_options): Initialize new member.
10270 * valprint.h (struct value_print_options) <finish_print>: New
10273 2019-05-28 Tom Tromey <tromey@adacore.com>
10275 * ada-lang.c (ada_remove_Xbn_suffix)
10276 (find_old_style_renaming_symbol)
10277 (parse_old_style_renaming): Remove.
10278 (ada_find_renaming_symbol): Don't call
10279 find_old_style_renaming_symbol.
10280 (ada_is_renaming_symbol): Rename from
10281 ada_find_renaming_symbol. Remove "block" parameter. Return
10283 (ada_read_var_value): Update and simplify.
10284 * ada-exp.y (write_var_or_type): Remove old code.
10286 2019-05-28 Alan Hayward <alan.hayward@arm.com>
10289 * event-top.c: Remove include comment.
10290 * inflow.c (class scoped_ignore_sigttou): Move from here...
10291 * inflow.h (class scoped_ignore_sigttou): ...to here.
10292 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10293 * top.c: Remove include comment.
10295 2019-05-27 Tom Tromey <tom@tromey.com>
10299 2019-05-22 Tom Tromey <tromey@adacore.com>
10301 * target.c (target_follow_exec): Constify parameter.
10302 * target-delegates.c: Rebuild.
10303 * remote.c (remote_target::follow_exec): Constify parameter.
10304 * infrun.c (follow_exec): Constify parameter.
10305 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10306 (target_follow_exec): Likewise.
10308 2019-05-22 Alan Hayward <alan.hayward@arm.com>
10310 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10311 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10313 2019-05-22 Alan Hayward <alan.hayward@arm.com>
10315 * NEWS: Add debugredirect and testsuite sections.
10317 2019-05-22 Simon Cook <simon.cook@embecosm.com>
10319 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10320 target descriptions using exclusively floating point register name
10323 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10326 * f-lang.c (build_fortran_types): Handle the case where
10327 gdbarch_floatformat_for_type returns a nullptr.
10329 2019-05-21 Tom de Vries <tdevries@suse.de>
10332 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10334 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10337 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10339 * i386-tdep.c (i386_floatformat_for_type): Use
10340 floatformats_ia64_quad for the 16-byte floating point component
10341 within a fortran 32-byte complex number.
10343 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10345 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10346 delete default constructor.
10347 (find_partial_die): Update to return const struct.
10348 (partial_die_parent_scope): Move variable declaration into scope
10349 of its use and change its type to auto.
10350 (guess_partial_die_structure_name): Likewise.
10351 (partial_die_info::fixup): Likewise.
10353 2019-05-17 Tom Tromey <tromey@adacore.com>
10355 * source.c (find_and_open_source): Remove cast.
10357 2019-05-17 Tom Tromey <tromey@adacore.com>
10359 * annotate.c (annotate_source): Make "filename" const.
10360 * annotate.h (annotate_source): Use const.
10362 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10364 * disasm.c (set_disassembler_options): Send errors to stderr.
10366 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10368 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10369 (cli_interp_base::set_logging): Check debug_redirect.
10370 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10371 * cli/cli-logging.c (debug_redirect): Add static variable.
10372 (pop_output_files): Add default param.
10373 (handle_redirections): Print debug setting.
10374 (show_logging_command): Likewise.
10375 (_initialize_cli_logging): Add debugredirect command.
10376 * interps.c (current_interp_set_logging): Add debug_redirect
10378 * interps.h (set_logging): Add debug_redirect parameter.
10379 (current_interp_set_logging): Likewise.
10380 * mi/mi-common.h: Likewise.
10381 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10383 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10384 Tom Tromey <tromey@adacore.com>
10386 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10388 * cli/cli-interp.h (make_logging_output): Remove declaration.
10389 * cli/cli-logging.c (make_logging_output): Remove function.
10390 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10392 * ui-file.c (tee_file::tee_file): Remove bools.
10393 (tee_file::~tee_file): Remove deletes.
10394 * ui-file.h (tee_file): Remove bools.
10396 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10398 * mi/mi-cmds.h (mi_cmd_complete): New function.
10399 * mi/mi-main.c (mi_cmd_complete): Likewise.
10400 * mi/mi-cmds.c: Define new MI command -complete.
10401 * NEWS: Mention new -complete command.
10403 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10405 * completer.h (complete): New function.
10406 * completer.c (complete): Likewise.
10407 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10408 function defined in completer.h.
10410 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10412 * MAINTAINERS (Write After Approval): Add myself.
10414 2019-05-17 Tom de Vries <tdevries@suse.de>
10417 * dwarf2read.c (struct cu_partial_die_info): New struct.
10418 (find_partial_die): Return cu_partial_die_info.
10419 (partial_die_parent_scope, guess_partial_die_structure_name)
10420 (partial_die_info::fixup): Handle new return type of find_partial_die.
10422 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10424 PR breakpoints/24541
10425 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10426 "std::string", simplifying the algorithm.
10428 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10430 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10431 (stap_static_probe_ops::get_probes): Likewise.
10433 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10435 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10436 '-')" and "else if".
10437 (stap_parse_single_operand): Join checks for
10438 "gdbarch_stap_parse_special_token_p" and
10439 "gdbarch_stap_parse_special_token" in the same "if" statement.
10440 Invert check when verifying for operation on register
10443 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10445 * stap-probe.c (stap_get_opcode): Update comment.
10446 (stap_get_expected_argument_type): Likewise.
10447 (handle_stap_probe): Likewise.
10449 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10451 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10452 return type to 'bool'. Adjust comment. Use 'bool' when
10454 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10455 * stap-probe.c (stap_parse_argument_1): Likewise.
10456 (stap_is_operator): Likewise.
10457 (stap_is_generic_prefix): Likewise.
10458 (stap_is_register_prefix): Likewise.
10459 (stap_is_register_indirection_prefix): Likewise.
10460 (stap_is_integer_prefix): Likewise.
10461 (stap_generic_check_suffix): Likewise.
10462 (stap_check_integer_suffix): Likewise.
10463 (stap_check_register_suffix): Likewise.
10464 (stap_check_register_indirection_suffix): Likewise.
10465 (stap_parse_register_operand): Likewise.
10466 (stap_parse_single_operand): Likewise.
10467 (stap_parse_argument_1): Likewise.
10468 (stap_probe::get_argument_count): Likewise.
10469 (stap_is_operator): Likewise.
10471 2019-05-16 Tom Tromey <tromey@adacore.com>
10473 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10474 keyword to foreach.
10476 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
10478 * linux-thread-db.c (try_thread_db_load_1): Change return type
10480 (try_thread_db_load): Likewise.
10481 (try_thread_db_load_from_pdir_1): Likewise.
10482 (try_thread_db_load_from_pdir): Likewise.
10483 (try_thread_db_load_from_sdir): Likewise.
10484 (try_thread_db_load_from_dir): Likewise.
10485 (thread_db_load_search): Likewise.
10486 (has_libpthread): Likewise.
10487 (thread_db_load): Likewise.
10489 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10491 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10492 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10493 NULL, and complain/return if that's the case.
10495 2019-05-15 John Darrington <john@darrington.wattle.id.au>
10497 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10498 (advance, posn, abstract_read_memory): New functions.
10499 [struct mem_read_abstraction]: New struct.
10500 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10502 2019-05-14 Tom Tromey <tromey@adacore.com>
10504 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10505 value is not lval_memory.
10507 2019-05-14 Tom Tromey <tromey@adacore.com>
10509 * solib.c (info_sharedlibrary_command): Style the file name.
10511 2019-05-14 Alan Hayward <alan.hayward@arm.com>
10513 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10514 (aarch64_vnv_type): Likewise.
10515 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10516 * common/tdesc.c: Likewise.
10517 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10518 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10519 * features/aarch64-fpu.xml: Add ieee half view.
10520 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10521 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10522 * gdbtypes.h (struct builtin_type): Likewise.
10523 (struct objfile_type): Likewise.
10525 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
10527 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10529 * location.h (string_to_event_location): Likewise.
10531 2019-05-11 Joel Brobecker <brobecker@adacore.com>
10535 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
10537 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10538 New variable declaration.
10539 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10541 (print_one_breakpoint): Use ui_out::test_flags and new global
10542 variable to compute use_fixed_output.
10543 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10545 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10546 (mi_multi_location_breakpoint_output_fixed): Remove.
10547 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10549 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10550 fix_multi_location_breakpoint_output flag if version >= 3.
10551 * ui-out.h (enum ui_out_flag)
10552 <fix_multi_location_breakpoint_output>: New enumerator.
10554 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
10556 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10558 2019-05-10 Tom Tromey <tromey@adacore.com>
10560 * ada-lang.c (catch_ada_completer): New function.
10561 (_initialize_ada_language): Use it.
10563 2019-05-10 Tom Tromey <tromey@adacore.com>
10565 * thread.c (print_thread_info): Make "requested_threads" const.
10566 * gdbthread.h (print_thread_info): Make "requested_threads"
10568 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10569 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10571 2019-05-08 Tom Tromey <tom@tromey.com>
10573 * gdbtypes.c (objfile_type_data): Change type.
10574 (objfile_type, _initialize_gdbtypes): Update.
10576 2019-05-08 Tom Tromey <tom@tromey.com>
10578 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10579 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10580 (_initialize_dwarf2_frame): Update.
10582 2019-05-08 Tom Tromey <tom@tromey.com>
10584 * objc-lang.c (objc_objfile_data): Change type.
10585 (find_methods): Update.
10586 (_initialize_objc_lang): Remove.
10588 2019-05-08 Tom Tromey <tom@tromey.com>
10590 * stabsread.c (rs6000_builtin_type_data): Change type.
10591 (rs6000_builtin_type, _initialize_stabsread): Update.
10593 2019-05-08 Tom Tromey <tom@tromey.com>
10595 * mips-tdep.c (mips_pdr_data): Remove.
10596 (_initialize_mips_tdep): Update.
10598 2019-05-08 Tom Tromey <tom@tromey.com>
10600 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10601 (hppa_init_objfile_priv_data, read_unwind_info)
10602 (find_unwind_entry, _initialize_hppa_tdep): Update.
10604 2019-05-08 Tom Tromey <tom@tromey.com>
10606 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10607 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10609 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10611 2019-05-08 Tom Tromey <tom@tromey.com>
10613 * mdebugread.c (basic_type_data): Change type.
10614 (basic_type, _initialize_mdebugread): Update.
10616 2019-05-08 Tom Tromey <tom@tromey.com>
10618 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10620 2019-05-08 Tom Tromey <tom@tromey.com>
10622 * nto-tdep.c (nto_inferior_data_reg): Change type.
10623 (nto_inferior_data): Update.
10624 (nto_inferior_data_cleanup, nto_new_inferior_data)
10625 (_initialize_nto_tdep): Remove.
10626 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10628 2019-05-08 Tom Tromey <tom@tromey.com>
10630 * ada-lang.c (struct ada_inferior_data): Add initializers.
10631 (ada_inferior_data): Change type.
10632 (ada_inferior_data_cleanup): Remove.
10633 (get_ada_inferior_data, ada_inferior_exit)
10634 (struct ada_pspace_data): Add initializers, destructor.
10635 (ada_pspace_data_handle): Change type.
10636 (get_ada_pspace_data): Update.
10637 (ada_pspace_data_cleanup): Remove.
10639 2019-05-08 Tom Tromey <tom@tromey.com>
10641 * coffread.c (struct coff_symfile_info): Add initializers.
10642 (coff_objfile_data_key): Move lower. Change type.
10643 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10645 (coff_free_info): Remove.
10647 2019-05-08 Tom Tromey <tom@tromey.com>
10649 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10650 (fbsd_pspace_data_handle): Move lower. Change type.
10651 (get_fbsd_pspace_data): Update.
10652 (fbsd_pspace_data_cleanup): Remove.
10653 (_initialize_fbsd_tdep): Update.
10655 2019-05-08 Tom Tromey <tom@tromey.com>
10657 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10658 (get_ada_tasks_pspace_data): Update.
10659 (ada_tasks_pspace_data_cleanup): Remove.
10660 (_initialize_tasks): Update.
10661 (ada_tasks_inferior_data_handle): Change type.
10662 (get_ada_tasks_inferior_data): Update.
10663 (ada_tasks_inferior_data_cleanup): Remove.
10664 (struct ada_tasks_pspace_data): Add initializers.
10666 2019-05-08 Tom Tromey <tom@tromey.com>
10668 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10669 * symfile-debug.c (debug_sym_get_probes): Change type.
10670 * stap-probe.c (handle_stap_probe):
10671 (stap_static_probe_ops::get_probes): Change type.
10672 * probe.h (class static_probe_ops) <get_probes>: Change type.
10673 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10674 (parse_probes_in_pspace): Update.
10675 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10677 (any_static_probe_ops::get_probes): Change type.
10678 * elfread.c (elfread_data): New typedef.
10679 (probe_key): Change type.
10680 (elf_get_probes): Likewise. Update.
10681 (probe_key_free): Remove.
10682 (_initialize_elfread): Update.
10683 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10685 (dtrace_process_dof_probe, dtrace_process_dof)
10686 (dtrace_static_probe_ops::get_probe): Change type.
10688 2019-05-08 Tom Tromey <tom@tromey.com>
10690 * xcoffread.c (struct xcoff_symfile_info): Rename from
10691 coff_symfile_info. Add initializers.
10692 (xcoff_objfile_data_key): Move lower. Change type.
10693 (XCOFF_DATA): Rewrite.
10694 (xcoff_free_info): Remove.
10695 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10696 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10697 (xcoff_initial_scan): Update.
10699 2019-05-08 Tom Tromey <tom@tromey.com>
10701 * solib-svr4.c (struct svr4_info): Add initializers and
10703 <probes_table>: Now an htab_up.
10704 (solib_svr4_pspace_data): Change type.
10705 (free_probes_table): Simplify.
10706 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10707 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10708 (probes_table_remove_objfile_probes, register_solib_event_probe)
10709 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10710 (_initialize_svr4_solib): Update.
10712 2019-05-08 Tom Tromey <tom@tromey.com>
10714 * remote.c (remote_pspace_data): Change type.
10715 (remote_pspace_data_cleanup): Remove.
10716 (get_remote_exec_file, set_pspace_remote_exec_file)
10717 (_initialize_remote): Update.
10719 2019-05-08 Tom Tromey <tom@tromey.com>
10721 * breakpoint.c (breakpoint_objfile_key): Change type.
10722 (get_breakpoint_objfile_data): Update.
10723 (free_breakpoint_objfile_data): Remove.
10724 (_initialize_breakpoint): Update.
10726 2019-05-08 Tom Tromey <tom@tromey.com>
10728 * linux-tdep.c (struct linux_info): Add initializers.
10729 (linux_inferior_data): Move. Change type.
10730 (invalidate_linux_cache_inf): Update.
10731 (linux_inferior_data_cleanup): Remove.
10732 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10734 2019-05-08 Tom Tromey <tom@tromey.com>
10736 * auxv.c (auxv_inferior_data): Move. Change type.
10737 (auxv_inferior_data_cleanup): Remove.
10738 (invalidate_auxv_cache_inf): Rewrite.
10739 (get_auxv_inferior_data, _initialize_auxv): Update.
10741 2019-05-08 Tom Tromey <tom@tromey.com>
10743 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10744 (symfile_debug_objfile_data_key): Change type.
10745 (symfile_debug_installed, debug_qf_has_symbols)
10746 (debug_qf_find_last_source_symtab)
10747 (debug_qf_forget_cached_source_info)
10748 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10749 (debug_qf_print_stats, debug_qf_dump)
10750 (debug_qf_expand_symtabs_for_function)
10751 (debug_qf_expand_all_symtabs)
10752 (debug_qf_expand_symtabs_with_fullname)
10753 (debug_qf_map_matching_symbols)
10754 (debug_qf_expand_symtabs_matching)
10755 (debug_qf_find_pc_sect_compunit_symtab)
10756 (debug_qf_map_symbol_filenames)
10757 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10758 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10759 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10760 (debug_sym_read_linetable, debug_sym_relocate): Update.
10761 (symfile_debug_free_objfile): Remove.
10762 (install_symfile_debug_logging, _initialize_symfile_debug):
10765 2019-05-08 Tom Tromey <tom@tromey.com>
10767 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10768 allocate_on_obstack.
10769 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10770 (get_dwarf2_per_objfile): Update.
10771 (set_dwarf2_per_objfile): Remove.
10772 (dwarf2_has_info, dwarf2_get_section_info): Update.
10773 (dwarf2_free_objfile): Remove.
10774 (_initialize_dwarf2_read): Update.
10776 2019-05-08 Tom Tromey <tom@tromey.com>
10778 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10780 <unsupported_script_warning_printed,
10781 script_not_found_warning_printed>: Now bool.
10782 (auto_load_pspace_data): Change type.
10783 (~auto_load_pspace_info): Rename from
10784 auto_load_pspace_data_cleanup.
10785 (get_auto_load_pspace_data, init_loaded_scripts_info)
10786 (clear_section_scripts, maybe_print_unsupported_script_warning)
10787 (maybe_print_script_not_found_warning, _initialize_auto_load):
10790 2019-05-08 Tom Tromey <tom@tromey.com>
10792 * objfiles.c (objfile_pspace_info): Add destructor and
10794 (objfiles_pspace_data): Change type.
10795 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10796 (get_objfile_pspace_data): Update.
10797 (objfiles_bfd_data): Change type.
10798 (get_objfile_bfd_data): Update.
10799 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10801 2019-05-08 Tom Tromey <tom@tromey.com>
10803 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10805 (get_catch_syscall_inferior_data): Update.
10806 (catch_syscall_inferior_data_cleanup): Remove.
10807 (_initialize_break_catch_syscall): Update.
10809 2019-05-08 Tom Tromey <tom@tromey.com>
10811 * inflow.c (struct terminal_info): Add destructor and
10813 (inflow_inferior_data): Change type.
10814 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10815 (get_inflow_inferior_data, inflow_inferior_exit)
10816 (swap_terminal_info, _initialize_inflow): Update.
10818 2019-05-08 Tom Tromey <tom@tromey.com>
10820 * target-dcache.c (target_dcache_cleanup): Remove.
10821 (target_dcache_aspace_key): Change type.
10822 (target_dcache_init_p, target_dcache_invalidate)
10823 (target_dcache_get, target_dcache_get_or_init)
10824 (_initialize_target_dcache): Update.
10825 * dcache.h (struct dcache_deleter): New.
10827 2019-05-08 Tom Tromey <tom@tromey.com>
10829 * symtab.c (struct symbol_cache): Add destructor and
10831 (symbol_cache_key): Move. Change type.
10832 (make_symbol_cache, free_symbol_cache): Remove.
10833 (get_symbol_cache): Update.
10834 (symbol_cache_cleanup): Remove.
10835 (ALL_PSPACES, symbol_cache_flush)
10836 (maintenance_print_symbol_cache)
10837 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10840 2019-05-08 Tom Tromey <tom@tromey.com>
10842 * symtab.c (struct main_info): Add destructor and initializers.
10843 (main_progspace_key): Move. Change type.
10844 (get_main_info): Update.
10845 (main_info_cleanup): Remove.
10846 (_initialize_symtab): Update.
10848 2019-05-08 Tom Tromey <tom@tromey.com>
10850 * registry.h (DECLARE_REGISTRY): Define the _key class.
10852 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10854 * NEWS: Merge two 'New commands' sections.
10856 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10858 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10859 parameter and use Ada language definition instead.
10860 (ada_val_print_ptr): Remove unused language parameter.
10861 (ada_val_print_num): Remove language parameter and use Ada language
10862 definition instead.
10863 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10865 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10866 parameter and use Ada language definition instead.
10867 (ada_val_print_1): Update all ada_val_print_xxx calls.
10868 Remove language parameter.
10869 (ada_val_print): Update ada_val_print_1 call.
10871 2019-05-08 Tom Tromey <tromey@adacore.com>
10873 * remote.c (remote_hw_watchpoint_limit)
10874 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10877 2019-05-08 Tom Tromey <tromey@adacore.com>
10879 * maint.c (_initialize_maint_cmds): Move initialization code to
10881 (watchdog, show_watchdog): Move to remote.c.
10882 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10884 (_initialize_remote): Move initialization code from maint.c.
10885 * defs.h (watchdog): Don't declare.
10887 2019-05-08 Tom Tromey <tromey@adacore.com>
10889 * tui/tui-interp.c: Include main.h.
10890 * interps.c: Include main.h.
10891 * main.h (interpreter_p): Declare.
10892 * defs.h (interpreter_p): Don't declare.
10894 2019-05-08 Tom Tromey <tromey@adacore.com>
10896 * dwarf2loc.c: Include dwarf2read.h.
10897 * defs.h (read_unsigned_leb128): Don't declare.
10898 * dwarf2read.h (read_unsigned_leb128): Declare.
10900 2019-05-08 Tom Tromey <tromey@adacore.com>
10902 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10905 2019-05-08 Tom Tromey <tromey@adacore.com>
10907 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10908 when no wrap column is set.
10910 2019-05-08 Tom Tromey <tromey@adacore.com>
10912 * c-lang.c (c_get_string): Handle non-C-style arrays.
10914 2019-05-08 Tom Tromey <tromey@adacore.com>
10916 * typeprint.c (print_offset_data::update): Print the bit offset,
10917 not the number of bits remaining.
10919 2019-05-08 Tom Tromey <tromey@adacore.com>
10921 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10922 padding at end of comment.
10924 2019-05-08 Tom Tromey <tromey@adacore.com>
10926 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10927 Compare main types.
10929 2019-05-06 Tom Tromey <tom@tromey.com>
10931 * common/scoped_mmap.c: Include common-defs.h.
10932 * common/scoped_mmap.h: Don't include config.h.
10934 2019-05-04 Tom Tromey <tom@tromey.com>
10936 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10937 (struct aarch64_call_info): Add initializers.
10938 <si>: Now a std::vector.
10939 (pass_on_stack, aarch64_push_dummy_call): Update.
10941 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10942 Tom Tromey <tom@tromey.com>
10944 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10945 (ppc_threads): Now a std::vector. Now static.
10946 (hwdebug_find_thread_points_by_tid)
10947 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10950 2019-05-04 Tom Tromey <tom@tromey.com>
10952 * arc-tdep.c (arc_tdesc_init): Return bool.
10954 2019-05-04 Tom Tromey <tom@tromey.com>
10956 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10957 Use gdb_assert_not_reached.
10959 2019-05-04 Tom Tromey <tom@tromey.com>
10961 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10964 2019-05-04 Tom Tromey <tom@tromey.com>
10966 * arc-tdep.c (arc_tdesc_init): Use bool.
10968 2019-05-04 Tom Tromey <tom@tromey.com>
10970 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10972 2019-05-04 Tom Tromey <tom@tromey.com>
10974 * cli/cli-cmds.c (valid_command_p): Return bool.
10976 2019-05-04 Tom Tromey <tom@tromey.com>
10978 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10979 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10981 2019-05-04 Raul Tambre <raul@tambre.ee>
10983 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10984 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10985 operator for comparison.
10987 2019-05-04 Tom Tromey <tom@tromey.com>
10989 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10990 (lookup_partial_symbol, print_partial_symbols)
10991 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10992 (psymbol_compare): Update.
10993 (add_psymbol_to_bcache): Clear the entire psymbol.
10994 (maintenance_check_psymtabs): Update.
10995 * psympriv.h (struct partial_symbol): Don't derive from
10996 general_symbol_info.
10997 <obj_section, unrelocated_address, address,
10998 set_unrelocated_address>: Update.
10999 <ginfo>: New member.
11000 * dwarf-index-write.c (write_psymbols, debug_names::insert)
11001 (debug_names::write_psymbols): Update.
11003 2019-05-04 Tom de Vries <tdevries@suse.de>
11005 * contrib/cc-with-tweaks.sh: Support -n arg.
11007 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11009 * corelow.c (core_target::detach): Ensure frame cache and
11010 register caches are cleared.
11011 inferior.c (exit_inferior_1): Likewise.
11013 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
11014 Tom Tromey <tom@tromey.com>
11016 * dictionary.c (collate_pending_symbols_by_language): Remove
11017 "struct" from foreach.
11018 * symtab.c (lookup_global_symbol_from_objfile)
11019 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
11021 * ser-tcp.c (net_open): Remove "struct" from foreach.
11022 * objfiles.c (objfile_relocate, objfile_rebase)
11023 (objfile_has_symbols): Remove "struct" from foreach.
11024 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
11026 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
11028 * darwin-nat.c (thread_info_from_private_thread_info): Remove
11029 "struct" from foreach.
11030 * ada-lang.c (create_excep_cond_exprs)
11031 (ada_exception_catchpoint_cond_string): Remove "struct" from
11034 2019-05-03 Tom Tromey <tromey@adacore.com>
11036 * ada-exp.y (convert_char_literal): Check suffix of each
11039 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
11042 * ada-exp.y (yywrap): Don't define.
11043 * ada-lex.l (%option): Add noyywrap
11046 2019-05-03 Eli Zaretskii <eliz@gnu.org>
11048 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11049 _WIN32_WINNT to the XP level, unless already defined to a higher
11052 * unittests/parse-connection-spec-selftests.c:
11054 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
11057 * symfile.c (find_separate_debug_file): Remove colon from the
11058 drive spec of DOS/Windows file names of the target, so that the
11059 file name produced from DEBUGDIR and the target's directory will
11060 be valid on DOS/Windows systems.
11062 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
11064 * rust-lang.c (val_print_struct): Handle printing structures
11065 containing strings.
11067 2019-05-02 Tom Tromey <tromey@adacore.com>
11069 * valarith.c (_initialize_valarith): Remove.
11071 2019-05-01 Tom Tromey <tromey@adacore.com>
11073 * ada-lang.c (ada_value_primitive_field): Treat more fields as
11076 2019-05-01 Tom Tromey <tromey@adacore.com>
11078 * ada-lang.c (ada_value_assign): Correctly compute starting offset
11079 for big-endian copies.
11081 2019-04-30 Ali Tamur <tamur@google.com>
11082 * gdb/dwarf2read.c (read_3_bytes): New declaration.
11083 (read_attribute_value): Added DW_FORM_strx1-4 cases.
11084 (read_3_bytes): New function.
11086 2019-04-30 Joel Brobecker <brobecker@adacore.com>
11088 * windows-nat.c (main_thread_id): Delete.
11089 (handle_output_debug_string): Replace main_thread_id by
11090 current_event.dwThreadId.
11091 (fake_create_process): Likewise.
11092 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11093 Do not set main_thread_id.
11094 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11095 current_event.dwThreadId.
11096 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11098 2019-04-30 Joel Brobecker <brobecker@adacore.com>
11100 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11101 Use current_event.dwThreadId instead of main_thread_id.
11103 2019-04-30 Tom Tromey <tromey@adacore.com>
11105 * ada-lang.c (ada_lookup_simple_minsyms): New function.
11106 (create_excep_cond_exprs): Iterate over program spaces.
11107 (ada_exception_catchpoint_cond_string): Examine all minimal
11108 symbols for exception types.
11110 2019-04-30 Tom Tromey <tromey@adacore.com>
11113 * dwarf2read.c (process_structure_scope): Handle case where type
11114 has template parameters but no symbol was created.
11116 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11117 Chris January <chris.january@arm.com>
11119 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11121 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11123 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11125 * f-typeprint.c (f_print_type): Update rules for printing
11127 (f_type_print_varspec_suffix): Likewise.
11129 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11130 Chris January <chris.january@arm.com>
11132 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11133 function arguments.
11135 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11137 * f-lang.c (build_fortran_types): Change name of void type to
11139 * f-typeprint.c (f_type_print_base): Print the name of the void
11140 type, rather than a fixed string.
11141 * f-valprint.c (f_decorations): Use lower case void string.
11143 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11144 Chris January <chris.january@arm.com>
11146 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11149 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11150 Chris January <chris.january@arm.com>
11151 David Lecomber <david.lecomber@arm.com>
11153 * f-exp.y (BINOP_INTRINSIC): New token.
11154 (exp): New parser rule handling BINOP_INTRINSIC.
11155 (f77_keywords): Add new builtin procedures.
11156 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11157 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11158 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11159 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11160 (print_unop_subexp_f): New function.
11161 (print_binop_subexp_f): New function.
11162 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11163 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11164 (dump_subexp_body_f): Likewise.
11165 (operator_check_f): Likewise.
11166 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11167 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11169 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11171 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11173 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11174 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11175 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11176 (operator_length_f): New fuction.
11177 (print_subexp_f): New function.
11178 (op_name_f): New function.
11179 (dump_subexp_body_f): New function.
11180 (operator_check_f): New function.
11181 (exp_descriptor_f): Replace standard expression handling functions
11182 with new functions.
11183 * gdb/fortran-operator.def: New file.
11184 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11185 * gdb/std-operator.def: Remove UNOP_KIND.
11187 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11189 * std-operator.def: Remove unbalanced, stray double quote
11192 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11193 Chris January <chris.january@arm.com>
11194 Daniel Everett <daniel.everett@arm.com>
11195 Nick Forrington <nick.forrington@arm.com>
11196 Richard Bunt <richard.bunt@arm.com>
11198 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11199 of depth when printing anonymous structs or unions.
11200 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11201 Don't print either the top-level value, or the children if the
11202 max-depth is exceeded.
11203 (ppscm_print_children): When printing the key of a map, allow one
11204 extra level of depth.
11205 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11206 print either the top-level value, or the children if the max-depth
11208 (print_children): When printing the key of a map, allow one extra
11210 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11211 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11212 (user_print_options): Initialise max_depth field.
11213 (val_print_scalar_or_string_type_p): New function.
11214 (val_print): Check to see if the max depth has been reached.
11215 (val_print_check_max_depth): Define new function.
11216 (show_print_max_depth): New function.
11217 (_initialize_valprint): Add 'print max-depth' option.
11218 * valprint.h (struct value_print_options) <max_depth>: New field.
11219 (val_print_check_max_depth): Declare new function.
11220 * NEWS: Document new feature.
11222 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11224 * ada-lang.c (ada_language_defn): Initialise new field.
11225 * c-lang.c (c_is_string_type_p): New function.
11226 (c_language_defn): Initialise new field.
11227 (cplus_language_defn): Initialise new field.
11228 (asm_language_defn): Initialise new field.
11229 (minimal_language_defn): Initialise new field.
11230 * c-lang.h (c_is_string_type_p): Declare new function.
11231 * d-lang.c (d_language_defn): Initialise new field.
11232 * f-lang.c (f_is_string_type_p): New function.
11233 (f_language_defn): Initialise new field.
11234 * go-lang.c (go_is_string_type_p): New function.
11235 (go_language_defn): Initialise new field.
11236 * language.c (default_is_string_type_p): New function.
11237 (unknown_language_defn): Initialise new field.
11238 (auto_language_defn): Initialise new field.
11239 * language.h (struct language_defn) <la_is_string_type_p>: New
11241 (default_is_string_type_p): Declare new function.
11242 * m2-lang.c (m2_language_defn): Initialise new field.
11243 * objc-lang.c (objc_language_defn): Initialise new field.
11244 * opencl-lang.c (opencl_language_defn): Initialise new field.
11245 * p-lang.c (pascal_is_string_type_p): New function.
11246 (pascal_language_defn): Initialise new field.
11247 * rust-lang.c (rust_is_string_type_p): New function.
11248 (rust_language_defn): Initialise new field.
11250 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11252 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11254 * ada-lang.c (ada_language_defn): Initialise new field.
11255 * c-lang.c (c_language_defn): Likewise.
11256 (cplus_language_defn): Likewise.
11257 (asm_language_defn): Likewise.
11258 (minimal_language_defn): Likewise.
11259 * d-lang.c (d_language_defn): Likewise.
11260 * f-lang.c (f_language_defn): Likewise.
11261 * go-lang.c (go_language_defn): Likewise.
11262 * language.c (unknown_language_defn): Likewise.
11263 (auto_language_defn): Likewise.
11264 * m2-lang.c (m2_language_defn): Likewise.
11265 * objc-lang.c (objc_language_defn): Likewise.
11266 * opencl-lang.c (opencl_language_defn): Likewise.
11267 * p-lang.c (pascal_language_defn): Likewise.
11268 * rust-lang.c (rust_language_defn): Likewise.
11270 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11272 * ada-lang.c (ada_is_character_type): Change return type to bool.
11273 (ada_is_string_type): Likewise.
11274 * ada-lang.h (ada_is_character_type): Update declaration
11275 (ada_is_string_type): Likewise.
11277 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11279 Support style in 'frame|thread apply'
11281 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11282 * record.c (record_start, record_stop): Update callers of
11283 execute_command_to_string with false.
11284 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11285 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11287 (class string_file): New constructor with term_out parameter.
11288 Override methods term_out and can_emit_style_escape. New member
11290 (class stdio_file): Override can_emit_style_escape.
11291 (class tee_file): Override term_out and can_emit_style_escape.
11292 * utils.h (can_emit_style_escape): Remove.
11293 * utils.c (can_emit_style_escape): Likewise.
11294 Update all callers of can_emit_style_escape (SOMESTREAM) to
11295 SOMESTREAM->can_emit_style_escape.
11296 * source-cache.c (source_cache::get_source_lines): Likewise.
11297 * stack.c (frame_apply_command_count): Call execute_command_to_string
11298 passing the term_out characteristic of the current gdb_stdout.
11299 * thread.c (thr_try_catch_cmd): Likewise.
11300 * top.c (execute_command_to_string): pass term_out parameter
11301 to construct the string_file for the command output.
11302 * ui-file.c (term_cli_styling): New function (most code moved
11303 from utils.c can_emit_style_escape).
11304 (string_file::string_file, string_file::can_emit_style_escape,
11305 stdio_file::can_emit_style_escape, tee_file::term_out,
11306 tee_file::can_emit_style_escape): New functions.
11308 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11310 * NEWS: Mention the new set|show may-call-functions.
11311 * infcall.c (may_call_functions_p): New variable.
11312 (show_may_call_functions_p): New function.
11313 (call_function_by_hand_dummy): Throws an error if not
11314 may-call-functions.
11315 (_initialize_infcall): Call add_setshow_boolean_cmd for
11316 may-call-functions.
11318 2019-04-25 Keith Seitz <keiths@redhat.com>
11321 * cp-support.c (inspect_type): Don't attempt substitutions
11322 of symbol with the same name.
11324 2019-04-25 Tom Tromey <tromey@adacore.com>
11327 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11330 2019-04-25 Tom Tromey <tromey@adacore.com>
11332 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11334 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11335 (gdb_xml_parser::parse): Use std::move.
11336 * python/python-internal.h (gdbpy_convert_exception): Take a const
11338 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11340 * python/py-utils.c (gdbpy_convert_exception): Take a const
11342 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11344 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11346 * mi/mi-main.c (mi_print_exception): Take a const reference.
11347 * main.c (handle_command_errors): Take a const reference.
11348 * linespec.c (parse_linespec): Use std::move.
11349 * infcall.c (run_inferior_call): Use std::move.
11350 (call_function_by_hand_dummy): Use std::move.
11351 * exec.c (try_open_exec_file): Use std::move.
11352 * exceptions.h (exception_print, exception_fprintf)
11353 (exception_print_same): Update.
11354 * exceptions.c (print_exception, exception_print)
11355 (exception_fprintf, exception_print_same): Change parameters to
11357 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11358 * common/new-op.c: Use std::move.
11359 * common/common-exceptions.h (struct gdb_exception): Add move
11361 (struct gdb_exception_error, struct gdb_exception_quit, struct
11362 gdb_quit_bad_alloc): Change constructor to move constructor.
11363 (throw_exception): Change parameter to rvalue reference.
11364 * common/common-exceptions.c (throw_exception): Take rvalue
11366 * cli/cli-interp.c (safe_execute_command): Use std::move.
11367 * breakpoint.c (insert_bp_location, location_to_sals): Use
11370 2019-04-25 Tom Tromey <tromey@adacore.com>
11372 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11373 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11374 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11375 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11376 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11377 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11378 guile/scm-value.c: Use unpack.
11379 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11380 gdbscm_gdb_exception.
11381 (gdbscm_throw_gdb_exception): Likewise.
11382 (struct gdbscm_gdb_exception): New.
11383 (unpack): New function.
11384 (gdbscm_wrap): Use unpack.
11386 2019-04-25 Tom Tromey <tromey@adacore.com>
11388 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11389 (gdb_rl_callback_handler): Use std::move.
11390 * common/common-exceptions.h (struct gdb_exception): Add move
11391 assignment operator.
11392 (throw_exception_sjlj): Change "exception" to const reference.
11393 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11394 (throw_exception_sjlj): Change "exception" to const reference.
11396 2019-04-25 Tom Tromey <tromey@adacore.com>
11398 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11399 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11400 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11402 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11404 * mi/mi-interp.c (mi_interp::exec): Update.
11405 * linespec.c (parse_linespec): Update.
11406 * infcall.c (run_inferior_call): Update.
11407 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11408 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11409 (gdbscm_lookup_global_symbol): Update.
11410 * guile/scm-param.c (gdbscm_parameter_value): Update.
11411 * guile/scm-frame.c (gdbscm_frame_read_register)
11412 (gdbscm_frame_read_var): Update.
11413 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11414 * exec.c (try_open_exec_file): Update.
11415 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11416 (gdb_rl_callback_handler): Update.
11417 * common/common-exceptions.h (exception_none): Don't declare.
11418 * common/common-exceptions.c (exception_none): Don't define.
11419 (struct catcher) <exception>: Update.
11420 * cli/cli-interp.c (safe_execute_command): Update.
11421 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11423 2019-04-25 Ali Tamur <tamur@google.com>
11425 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11426 (read_attribute_value): Likewise.
11427 (dwarf2_read_addr_index): Update comment.
11428 (read_str_index): Add DW_FORM_strx.
11429 (dwarf2_string_attr): Likewise.
11430 (dwarf2_const_value_attr): Likewise.
11431 (dump_die_shallow): Likewise.
11432 (dwarf2_fetch_constant_bytes): Likewise.
11433 (skip_form_bytes): Likewise.
11434 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11436 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11440 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11441 OFFSET. Verify if current mapping contains an ELF header.
11442 (linux_find_memory_regions_full): Adjust call to
11445 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11446 Kang Li <kanglictf@gmail.com>
11450 * dwarf2-frame.c (read_initial_length): Be consistent about using
11451 unsigned representation of length.
11452 (decode_frame_entry_1): Likewise. Check for wraparound of
11453 end pointer as well as buffer overflow.
11455 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11457 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11460 2019-04-24 Tom Tromey <tromey@adacore.com>
11462 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11464 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11466 * s12z-tdep.c (s12z_unwind_pc): Delete.
11467 (s12z_unwind_sp): Delete.
11468 (s12z_gdbarch_init): Don't register deleted functions with
11471 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11473 * rl78-tdep.c (rl78_unwind_sp): Delete.
11474 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11476 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11478 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11479 (xstormy16_unwind_pc): Delete.
11480 (xstormy16_dummy_id): Delete.
11481 (xstormy16_gdbarch_init): Don't register deleted functions with
11484 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11486 * vax-tdep.c (vax_unwind_pc): Delete.
11487 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11489 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11491 * v850-tdep.c (v850_unwind_sp): Delete.
11492 (v850_unwind_pc): Delete.
11493 (v850_dummy_id): Delete.
11494 (v850_gdbarch_init): Don't register deleted functions with
11497 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11499 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11500 (tilegx_unwind_pc): Delete.
11501 (tilegx_unwind_dummy_id): Delete.
11502 (tilegx_gdbarch_init): Don't register deleted functions with
11505 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11507 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11508 (tic6x_dummy_id): Delete.
11509 (tic6x_gdbarch_init): Don't register deleted functions with
11512 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11514 * sparc-tdep.c (sparc_unwind_pc): Delete.
11515 (sparc32_gdbarch_init): Don't register deleted function with
11518 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11520 * sh-tdep.c (sh_unwind_sp): Delete.
11521 (sh_unwind_pc): Delete.
11522 (sh_dummy_id): Delete.
11523 (sh_gdbarch_init): Don't register deleted functions with
11526 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11528 * score-tdep.c (score_unwind_sp): Delete.
11529 (score_unwind_pc): Delete.
11530 (score_dummy_id): Delete.
11531 (score_gdbarch_init): Don't register deleted functions with
11534 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11536 * rx-tdep.c (rx_unwind_pc): Delete.
11537 (rx_unwind_sp): Delete.
11538 (rx_dummy_id): Delete.
11539 (rx_gdbarch_init): Don't register deleted functions with
11540 gdbarch. Update comment.
11542 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11544 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11545 (rs6000_dummy_id): Delete.
11546 (rs6000_gdbarch_init): Don't register deleted functions with
11549 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11551 * or1k-tdep.c (or1k_dummy_id): Delete.
11552 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11554 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11556 * nios2-tdep.c (nios2_dummy_id): Delete.
11557 (nios2_unwind_sp): Delete.
11558 (nios2_gdbarch_init): Don't register deleted functions with
11561 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11563 * nds32-tdep.c (nds32_dummy_id): Delete.
11564 (nds32_unwind_pc): Delete.
11565 (nds32_unwind_sp): Delete.
11566 (nds32_gdbarch_init): Don't register deleted functions with
11569 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11571 * msp430-tdep.c (msp430_unwind_pc): Delete.
11572 (msp430_unwind_sp): Delete.
11573 (msp430_dummy_id): Delete.
11574 (msp430_gdbarch_init): Don't register deleted functions with
11577 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11579 * moxie-tdep.c (moxie_unwind_sp): Delete.
11580 (moxie_unwind_pc): Delete.
11581 (moxie_dummy_id): Delete.
11582 (moxie_gdbarch_init): Don't register deleted functions with
11585 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11587 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11588 (mn10300_unwind_pc): Delete.
11589 (mn10300_unwind_sp): Delete.
11590 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11592 (mn10300_frame_unwind_init): Don't register deleted functions with
11595 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11597 * mep-tdep.c (mep_unwind_pc): Delete.
11598 (mep_unwind_sp): Delete.
11599 (mep_dummy_id): Delete.
11600 (mep_gdbarch_init): Don't register deleted functions with
11603 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11605 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11606 (m68hc11_unwind_sp): Delete.
11607 (m68hc11_gdbarch_init): Don't register deleted functions with
11610 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11612 * m32r-tdep.c (m32r_unwind_sp): Delete.
11613 (m32r_unwind_pc): Delete.
11614 (m32r_dummy_id): Delete.
11615 (m32r_gdbarch_init): Don't register deleted functions with
11618 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11620 * m32c-tdep.c (m32c_unwind_pc): Delete.
11621 (m32c_unwind_sp): Delete.
11622 (m32c_dummy_id): Delete.
11623 (m32c_gdbarch_init): Don't register deleted functions with
11626 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11628 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11629 (lm32_unwind_pc): Delete.
11630 (lm32_dummy_id): Delete.
11631 (lm32_gdbarch_init): Don't register deleted functions with
11634 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11636 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11637 (iq2000_unwind_pc): Delete.
11638 (iq2000_dummy_id): Delete.
11639 (iq2000_gdbarch_init): Don't register deleted functions with
11642 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11644 * nds32-tdep.c (nds32_type_align): Delete.
11645 (nds32_push_dummy_call): Use type_align instead.
11647 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11649 * arm-tdep.c (arm_type_align): Only handle vector override case.
11650 (arm_push_dummy_call): Use type_align.
11651 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11653 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11655 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11657 (pass_on_stack): Use type_align.
11658 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11661 2019-04-23 Tom Tromey <tromey@adacore.com>
11663 * dwarf2read.c (line_header::file_name_at): Remove unused
11666 2019-04-23 Tom de Vries <tdevries@suse.de>
11669 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11673 2019-03-27 Ali Tamur <tamur@google.com>
11675 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11676 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11677 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11678 (dwarf_expr_context::get_addr_index): Likewise
11679 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11680 (symbol_needs_eval_context::get_addr_index): Likewise
11681 (disassemble_dwarf_expression): Add DW_OP_addrx
11682 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11683 (read_cutu_die_from_dwo): Update comment
11684 (skip_one_die): Add DW_FORM_addrx
11685 (read_attribute_value): Likewise
11686 (var_decode_location): Add DW_OP_addrx
11687 (dwarf2_const_value_attr): Add DW_FORM_addrx
11688 (dump_die_shallow): Likewise
11689 (dwarf2_fetch_constant_bytes): Likewise
11690 (decode_locdesc): Add DW_OP_addrx
11691 (skip_form_bytes): Add DW_FORM_addrx
11693 2019-04-22 Ali Tamur <tamur@google.com>
11695 * MAINTAINERS (Write After Approval): Add self.
11697 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
11699 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11700 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11701 (open_symbol_file_object): Likewise.
11702 (svr4_default_sos): Add info parameter.
11703 (svr4_read_so_list): Likewise.
11704 (svr4_current_sos_direct): Adjust functions calls to pass down
11706 (svr4_current_sos_1): Add info parameter.
11707 (svr4_current_sos): Call get_svr4_info, pass info down to
11708 svr4_current_sos_1.
11709 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11711 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11713 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11715 (probes_table_remove_objfile_probes): Likewise.
11716 (register_solib_event_probe): Add info parameter.
11717 (solist_update_incremental): Pass info parameter down to
11719 (disable_probes_interface): Add info parameter.
11720 (svr4_handle_solib_event): Pass current_program_space to
11721 get_svr4_info. Adjust disable_probes_interface cleanup.
11722 (svr4_create_probe_breakpoints): Add info parameter, pass it
11723 down to register_solib_event_probe.
11724 (svr4_create_solib_event_breakpoints): Add info parameter,
11725 pass it down to svr4_create_probe_breakpoints.
11726 (enable_break): Pass info down to
11727 svr4_create_solib_event_breakpoints.
11728 (svr4_solib_create_inferior_hook): Pass current_program_space to
11730 (svr4_clear_solib): Likewise.
11732 2019-04-22 Pedro Alves <palves@redhat.com>
11734 * solib-svr4.c (svr4_free_objfile_observer): New.
11735 (probe_and_action::objfile): New field.
11736 (probes_table_htab_remove_objfile_probes)
11737 (probes_table_remove_objfile_probes): New functions.
11738 (register_solib_event_probe): Add 'objfile' parameter. Store it
11739 in the new probe_and_action. Don't store the probe in 'lookup'.
11740 (svr4_create_probe_breakpoints): Pass objfile to
11741 register_solib_event_probe.
11742 (_initialize_svr4_solib): Register a free_objfile observer.
11744 2019-04-19 Tom Tromey <tom@tromey.com>
11746 * common/queue.h: Remove.
11748 2019-04-19 Tom Tromey <tom@tromey.com>
11750 * event-loop.c: Don't include "common/queue.h".
11752 2019-04-19 Tom Tromey <tom@tromey.com>
11754 * remote.c (remote_target): Use delete.
11755 * remote-notif.h: Include <list>, not "common/queue.h".
11756 (notif_client_p): Remove typedef.
11757 (remote_notif_state): Add constructor, destructor, initializer.
11758 <notif_queue>: Now a std::list.
11759 (remote_notif_state_xfree): Don't declare.
11760 * remote-notif.c (remote_notif_process, handle_notification)
11761 (remote_notif_state_allocate): Update.
11762 (~remote_notif_state): Rename from remote_notif_state_xfree.
11764 2019-04-19 Tom Tromey <tom@tromey.com>
11766 * symfile.c (reread_symbols): Update.
11767 * objfiles.c (objfile_register_static_link)
11768 (objfile_lookup_static_link): Update
11769 (~objfile) Don't delete static_links.
11770 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11772 2019-04-19 Tom Tromey <tom@tromey.com>
11774 * type-stack.h (struct type_stack) <insert>: Constify string.
11775 * type-stack.c (type_stack::insert): Constify string.
11776 * gdbtypes.h (lookup_template_type): Update.
11777 (address_space_name_to_int): Update.
11778 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11780 (lookup_template_type): Make name const.
11781 * c-exp.y: Update rules.
11782 (lex_one_token, classify_name, classify_inner_name)
11783 (c_print_token): Update.
11784 * p-exp.y: Update rules.
11786 * f-exp.y: Update rules.
11788 * d-exp.y: Update rules.
11789 (lex_one_token, classify_name, classify_inner_name): Update.
11790 * parse.c (write_dollar_variable, copy_name): Return std::string.
11791 * parser-defs.h (copy_name): Change return type.
11792 * m2-exp.y: Update rules.
11794 * go-exp.y (lex_one_token): Update.
11796 (classify_unsafe_function, classify_packaged_name)
11797 (classify_name, yylex): Update.
11799 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11801 * configure.ac: add --enable-source-highlight switch.
11802 * configure: Regenerate.
11803 * top.c (print_gdb_version): plumb --enable-source-highlight
11804 status to "show configuration".
11806 2019-04-19 Tom Tromey <tromey@adacore.com>
11808 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11810 (empty_record, ada_template_to_fixed_record_type_1)
11811 (template_to_static_fixed_type)
11812 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11813 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11814 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11817 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11820 * source.c (print_source_lines_base): Advance "iter" when a
11821 control character is seen.
11823 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11825 * inferior.h (struct infcall_suspend_state_deleter):
11826 Catch exception in destructor to avoid crash.
11828 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11830 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11831 close to the add_com "shell".
11833 2019-04-18 Tom Tromey <tromey@adacore.com>
11835 * process-stratum-target.h (class process_stratum_target)
11836 <stratum>: Add "final".
11838 2019-04-17 Tom Tromey <tromey@adacore.com>
11840 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11841 against nullptr before use.
11843 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11845 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11847 2019-04-17 Jim Wilson <jimw@sifive.com>
11848 Andrew Burgess <andrew.burgess@embecosm.com>
11850 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11851 code read might fail, assume 4-byte breakpoint in that case.
11853 2019-04-15 Leszek Swirski <leszeks@google.com>
11855 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11856 rather than a hand-rolled POD check when checking for forced MEMORY
11859 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11861 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11862 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11864 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11865 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11866 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11869 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11871 * aarch64-linux-nat.c
11872 (aarch64_linux_nat_target::thread_architecture): Add override.
11873 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11876 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11878 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11880 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11882 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11883 target types of size 96-bits, add some additional comments, and
11884 check that the builtin type we found was the correct size.
11886 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11888 * utils.c (prompt_for_continue): Don't restore the styling at the
11889 end, as applied_style has the wrong value. This fixes styling in
11890 long lists of file names that are interrupted by the "Continue?"
11893 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11895 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11896 * c-lang.c (c_language_defn): Likewise.
11897 (cplus_language_defn): Likewise.
11898 (asm_language_defn): Likewise.
11899 (minimal_language_defn): Likewise.
11900 * d-lang.c (d_language_defn): Likewise.
11901 * f-lang.c (f_language_defn): Likewise.
11902 * go-lang.c (go_language_defn): Likewise.
11903 * language.c (unknown_language_defn): Likewise.
11904 (auto_language_defn): Likewise.
11905 * language.h (struct language_defn): Remove la_magic field.
11906 (LANG_MAGIC): Delete.
11907 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11908 * objc-lang.c (objc_language_defn): Likewise.
11909 * opencl-lang.c (opencl_language_defn): Likewise.
11910 * p-lang.c (pascal_language_defn): Likewise.
11911 * rust-lang.c (rust_language_defn): Likewise.
11913 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11915 * riscv-tdep.c (riscv_type_align): New function.
11916 (riscv_type_alignment): Delete.
11917 (riscv_arg_location): Use 'type_align'.
11918 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11920 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11922 * gdbtypes.c (type_align): A struct with no non-static fields also
11923 has alignment of 1.
11925 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11927 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11929 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11931 (riscv_struct_info::analyse): New implementation using new
11932 analyse_inner member function.
11933 (riscv_struct_info::field_offset): New member function.
11934 (riscv_struct_info::m_offsets): New member variable.
11935 (riscv_struct_info::analyse_inner): New private member function,
11936 takes the old implementation of riscv_struct_info::analyse but
11937 extended to track field offsets.
11938 (riscv_call_arg_struct): Update the struct folding special cases
11939 to handle cases where empty C++ structs, which are non-zero
11941 (riscv_arg_location): Initialise the length of each location, a
11942 non-zero length now indicates the location is in use.
11943 (riscv_push_dummy_call): Allow for the first location having a
11944 non-zero offset when setting up arguments.
11945 (riscv_return_value): Likewise, but for return values.
11947 2019-04-11 Tom Tromey <tromey@adacore.com>
11949 * utils.c (internal_vproblem): Make "msg" const.
11951 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11953 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11954 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11955 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11956 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11958 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11960 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11962 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11963 of amd64_collect_native_gregset.
11964 (amd64_linux_nat_target::store_registers): Likewise.
11966 2019-04-10 Tom Tromey <tom@tromey.com>
11968 * symtab.c (lookup_global_symbol_from_objfile)
11969 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11970 * objfiles.h (class separate_debug_iterator): New.
11971 (class separate_debug_range): New.
11972 (struct objfile) <separate_debug_objfiles>: New method.
11973 (objfile_separate_debug_iterate): Don't declare.
11974 * objfiles.c (separate_debug_iterator::operator++): Rename from
11975 objfile_separate_debug_iterate.
11976 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11978 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11981 2019-04-10 Tom Tromey <tom@tromey.com>
11983 * symfile.c (reread_symbols): Remove old comment.
11984 * objfiles.c (free_all_objfiles): Fix a typo.
11986 2019-04-10 Tom Tromey <tom@tromey.com>
11988 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11989 * minsyms.c (lookup_minimal_symbol): Use foreach.
11990 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11991 (lookup_minimal_symbol_solib_trampoline): Likewise.
11992 * symfile.c (reread_symbols): Use foreach.
11994 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11995 Tom Tromey <tromey@adacore.com>
11998 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11999 (rust_lex_int_test): Change "value" to be LONGEST.
12000 (rust_lex_tests): Add test for long integer literal.
12002 2019-04-09 Tom Tromey <tromey@adacore.com>
12004 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
12006 (extended_remote_target::attach): Update.
12007 (remote_target::remote_notice_new_inferior): Update.
12008 (remote_target::add_current_inferior_and_thread): Update.
12009 * inferior.c (exit_inferior_1): Use "false".
12010 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
12012 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
12014 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
12015 the "start" command.
12017 2019-04-08 Kevin Buettner <kevinb@redhat.com>
12019 * python/py-inferior.c (infpy_thread_from_thread_handle):
12020 Adjust comments to reflect renaming of thread_from_thread_handle
12021 to thread_from_handle. Adjust keywords. Fix type error message.
12022 (inferior_object_methods): Add thread_from_handle. Retain
12023 thread_from_thread_handle, but mark it as deprecated.
12025 2019-04-08 Kevin Buettner <kevinb@redhat.com>
12027 * gdbthread.h (find_thread_by_handle): Revise declaration.
12028 * thread.c (find_thread_by_handle): Likewise. Adjust
12029 implementation too.
12030 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
12031 support for buffer objects as handles.
12033 2019-04-08 Kevin Buettner <kevinb@redhat.com>
12035 * python/py-infthread.c (thpy_thread_handle): New function.
12036 (thread_object_methods): Register thpy_thread_handle.
12038 2019-04-08 Kevin Buettner <kevinb@redhat.com>
12040 * gdbthread.h (thread_to_thread_handle): Declare.
12041 * thread.c (gdbtypes.h): Include.
12042 (thread_to_thread_handle): New function.
12044 * target.h (struct target_ops): Add thread_info_to_thread_handle.
12045 (target_thread_info_to_thread_handle): Declare.
12046 * target.c (target_thread_info_to_thread_handle): New function.
12047 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12048 * target-delegates.c: Regenerate.
12050 * linux-thread-db.c (class thread_db_target): Add method
12051 thread_info_to_thread_handle.
12052 (thread_db_target::thread_info_to_thread_handle): Define.
12053 * remote.c (class remote_target): Add new method
12054 thread_info_to_thread_handle.
12055 (remote_target::thread_info_to_thread_handle): Define.
12057 2019-04-08 Pedro Alves <palves@redhat.com>
12059 * common/common-exceptions.c (throw_exception): Don't create
12060 named object to throw; throw directly.
12061 (throw_it): Likewise. Don't initialize gdb_exception::message
12062 here, with new; pass FMT and AP to the ctor instead.
12063 * common/common-exceptions.h: Include <string>.
12064 (gdb_exception::gdb_exception(enum return_reason, enum errors,
12065 const char *, va_list)): New ctor. Use std::make_shared.
12066 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12068 (gdb_exception_error::gdb_exception_error(enum errors, const char
12070 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12072 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12074 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12075 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12078 2019-04-08 Tom Tromey <tom@tromey.com>
12080 * valops.c (value_rtti_indirect_type): Replace throw_exception
12082 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12084 * thread.c (thr_try_catch_cmd): Replace throw_exception with
12086 * target.c (target_translate_tls_address): Replace throw_exception
12088 * stack.c (frame_apply_command_count): Replace throw_exception
12090 * solib-spu.c (append_ocl_sos): Replace throw_exception with
12092 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12094 * rs6000-tdep.c (rs6000_frame_cache)
12095 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12096 * remote.c: Replace throw_exception with throw.
12097 * record-full.c (record_full_message, record_full_wait_1)
12098 (record_full_restore): Replace throw_exception with throw.
12100 (get_thread_current_frame_id, record_btrace_start_replaying)
12101 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12102 (cmd_record_btrace_start): Replace throw_exception with throw.
12103 * parse.c (parse_exp_in_context_1): Replace throw_exception with
12105 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12106 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12108 (find_linespec_symbols): Replace throw_exception with throw.
12109 * infrun.c (displaced_step_prepare, resume): Replace
12110 throw_exception with throw.
12111 * infcmd.c (post_create_inferior): Replace throw_exception with
12113 * inf-loop.c (inferior_event_handler): Replace throw_exception
12115 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12116 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12117 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12118 (get_prev_frame_always, get_frame_pc_if_available)
12119 (get_frame_address_in_block_if_available, get_frame_language):
12120 Replace throw_exception with throw.
12121 * frame-unwind.c (frame_unwind_try_unwinder): Replace
12122 throw_exception with throw.
12123 * eval.c (fetch_subexp_value, evaluate_var_value)
12124 (evaluate_funcall, evaluate_subexp_standard): Replace
12125 throw_exception with throw.
12126 * dwarf2loc.c (call_site_find_chain)
12127 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12128 Replace throw_exception with throw.
12129 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12131 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12133 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12134 * completer.c (complete_line_internal): Replace throw_exception
12136 * compile/compile-object-run.c (compile_object_run): Replace
12137 throw_exception with throw.
12138 * cli/cli-script.c (process_next_line): Replace throw_exception
12140 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12141 (btrace_enable, btrace_maint_update_pt_packets): Replace
12142 throw_exception with throw.
12143 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12144 throw_exception with throw.
12145 * break-catch-throw.c (re_set_exception_catchpoint): Replace
12146 throw_exception with throw.
12147 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12148 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12149 * aarch64-tdep.c (aarch64_make_prologue_cache)
12150 (aarch64_make_stub_cache): Replace throw_exception with throw.
12152 2019-04-08 Tom Tromey <tom@tromey.com>
12154 * common/common-exceptions.c (throw_exception): Rename from
12155 throw_exception_cxx. Remove old copy. Make argument const.
12156 (throw_it): Create and throw exception objects directly.
12157 * common/common-exceptions.h (throw_exception): Make argument
12159 (struct gdb_exception_error): Add constructor.
12160 (struct gdb_exception_quit): Add constructor.
12162 2019-04-08 Tom Tromey <tom@tromey.com>
12164 * common/common-exceptions.h (exception_rethrow): Don't declare.
12165 (TRY_SJLJ): Update comment.
12166 (TRY, CATCH, END_CATCH): Remove.
12167 * common/common-exceptions.c (exception_rethrow): Remove.
12169 2019-04-08 Tom Tromey <tom@tromey.com>
12171 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12173 (gdb_exception_error): Rename from
12174 gdb_exception_RETURN_MASK_ERROR.
12175 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12176 (gdb_quit_bad_alloc): Update.
12177 * aarch64-tdep.c: Update.
12178 * ada-lang.c: Update.
12179 * ada-typeprint.c: Update.
12180 * ada-valprint.c: Update.
12181 * amd64-tdep.c: Update.
12182 * arch-utils.c: Update.
12183 * break-catch-throw.c: Update.
12184 * breakpoint.c: Update.
12185 * btrace.c: Update.
12186 * c-varobj.c: Update.
12187 * cli/cli-cmds.c: Update.
12188 * cli/cli-interp.c: Update.
12189 * cli/cli-script.c: Update.
12190 * common/common-exceptions.c: Update.
12191 * common/new-op.c: Update.
12192 * common/selftest.c: Update.
12193 * compile/compile-c-symbols.c: Update.
12194 * compile/compile-cplus-symbols.c: Update.
12195 * compile/compile-object-load.c: Update.
12196 * compile/compile-object-run.c: Update.
12197 * completer.c: Update.
12198 * corelow.c: Update.
12199 * cp-abi.c: Update.
12200 * cp-support.c: Update.
12201 * cp-valprint.c: Update.
12202 * darwin-nat.c: Update.
12203 * disasm-selftests.c: Update.
12204 * dtrace-probe.c: Update.
12205 * dwarf-index-cache.c: Update.
12206 * dwarf-index-write.c: Update.
12207 * dwarf2-frame-tailcall.c: Update.
12208 * dwarf2-frame.c: Update.
12209 * dwarf2loc.c: Update.
12210 * dwarf2read.c: Update.
12212 * event-loop.c: Update.
12213 * event-top.c: Update.
12215 * f-valprint.c: Update.
12216 * fbsd-tdep.c: Update.
12217 * frame-unwind.c: Update.
12219 * gdbtypes.c: Update.
12220 * gnu-v3-abi.c: Update.
12221 * guile/guile-internal.h: Update.
12222 * guile/scm-block.c: Update.
12223 * guile/scm-breakpoint.c: Update.
12224 * guile/scm-cmd.c: Update.
12225 * guile/scm-disasm.c: Update.
12226 * guile/scm-frame.c: Update.
12227 * guile/scm-lazy-string.c: Update.
12228 * guile/scm-math.c: Update.
12229 * guile/scm-param.c: Update.
12230 * guile/scm-ports.c: Update.
12231 * guile/scm-pretty-print.c: Update.
12232 * guile/scm-symbol.c: Update.
12233 * guile/scm-symtab.c: Update.
12234 * guile/scm-type.c: Update.
12235 * guile/scm-value.c: Update.
12236 * i386-linux-tdep.c: Update.
12237 * i386-tdep.c: Update.
12238 * inf-loop.c: Update.
12239 * infcall.c: Update.
12240 * infcmd.c: Update.
12241 * infrun.c: Update.
12243 * language.c: Update.
12244 * linespec.c: Update.
12245 * linux-fork.c: Update.
12246 * linux-nat.c: Update.
12247 * linux-tdep.c: Update.
12248 * linux-thread-db.c: Update.
12250 * mi/mi-cmd-break.c: Update.
12251 * mi/mi-cmd-stack.c: Update.
12252 * mi/mi-interp.c: Update.
12253 * mi/mi-main.c: Update.
12254 * objc-lang.c: Update.
12255 * p-valprint.c: Update.
12257 * ppc-linux-tdep.c: Update.
12258 * printcmd.c: Update.
12259 * python/py-arch.c: Update.
12260 * python/py-breakpoint.c: Update.
12261 * python/py-cmd.c: Update.
12262 * python/py-finishbreakpoint.c: Update.
12263 * python/py-frame.c: Update.
12264 * python/py-framefilter.c: Update.
12265 * python/py-gdb-readline.c: Update.
12266 * python/py-inferior.c: Update.
12267 * python/py-infthread.c: Update.
12268 * python/py-lazy-string.c: Update.
12269 * python/py-linetable.c: Update.
12270 * python/py-objfile.c: Update.
12271 * python/py-param.c: Update.
12272 * python/py-prettyprint.c: Update.
12273 * python/py-progspace.c: Update.
12274 * python/py-record-btrace.c: Update.
12275 * python/py-record.c: Update.
12276 * python/py-symbol.c: Update.
12277 * python/py-type.c: Update.
12278 * python/py-unwind.c: Update.
12279 * python/py-utils.c: Update.
12280 * python/py-value.c: Update.
12281 * python/python.c: Update.
12282 * record-btrace.c: Update.
12283 * record-full.c: Update.
12284 * remote-fileio.c: Update.
12285 * remote.c: Update.
12286 * riscv-tdep.c: Update.
12287 * rs6000-aix-tdep.c: Update.
12288 * rs6000-tdep.c: Update.
12289 * rust-exp.y: Update.
12290 * rust-lang.c: Update.
12291 * s390-tdep.c: Update.
12292 * selftest-arch.c: Update.
12293 * solib-dsbt.c: Update.
12294 * solib-frv.c: Update.
12295 * solib-spu.c: Update.
12296 * solib-svr4.c: Update.
12298 * sparc64-linux-tdep.c: Update.
12300 * symfile-mem.c: Update.
12301 * symmisc.c: Update.
12302 * target.c: Update.
12303 * thread.c: Update.
12305 * tracefile-tfile.c: Update.
12306 * tui/tui.c: Update.
12307 * typeprint.c: Update.
12308 * unittests/cli-utils-selftests.c: Update.
12309 * unittests/parse-connection-spec-selftests.c: Update.
12310 * valops.c: Update.
12311 * valprint.c: Update.
12313 * varobj.c: Update.
12314 * windows-nat.c: Update.
12315 * x86-linux-nat.c: Update.
12316 * xml-support.c: Update.
12318 2019-04-08 Tom Tromey <tom@tromey.com>
12320 * xml-support.c: Use C++ exception handling.
12321 * x86-linux-nat.c: Use C++ exception handling.
12322 * windows-nat.c: Use C++ exception handling.
12323 * varobj.c: Use C++ exception handling.
12324 * value.c: Use C++ exception handling.
12325 * valprint.c: Use C++ exception handling.
12326 * valops.c: Use C++ exception handling.
12327 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12329 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12330 * typeprint.c: Use C++ exception handling.
12331 * tui/tui.c: Use C++ exception handling.
12332 * tracefile-tfile.c: Use C++ exception handling.
12333 * top.c: Use C++ exception handling.
12334 * thread.c: Use C++ exception handling.
12335 * target.c: Use C++ exception handling.
12336 * symmisc.c: Use C++ exception handling.
12337 * symfile-mem.c: Use C++ exception handling.
12338 * stack.c: Use C++ exception handling.
12339 * sparc64-linux-tdep.c: Use C++ exception handling.
12340 * solib.c: Use C++ exception handling.
12341 * solib-svr4.c: Use C++ exception handling.
12342 * solib-spu.c: Use C++ exception handling.
12343 * solib-frv.c: Use C++ exception handling.
12344 * solib-dsbt.c: Use C++ exception handling.
12345 * selftest-arch.c: Use C++ exception handling.
12346 * s390-tdep.c: Use C++ exception handling.
12347 * rust-lang.c: Use C++ exception handling.
12348 * rust-exp.y: Use C++ exception handling.
12349 * rs6000-tdep.c: Use C++ exception handling.
12350 * rs6000-aix-tdep.c: Use C++ exception handling.
12351 * riscv-tdep.c: Use C++ exception handling.
12352 * remote.c: Use C++ exception handling.
12353 * remote-fileio.c: Use C++ exception handling.
12354 * record-full.c: Use C++ exception handling.
12355 * record-btrace.c: Use C++ exception handling.
12356 * python/python.c: Use C++ exception handling.
12357 * python/py-value.c: Use C++ exception handling.
12358 * python/py-utils.c: Use C++ exception handling.
12359 * python/py-unwind.c: Use C++ exception handling.
12360 * python/py-type.c: Use C++ exception handling.
12361 * python/py-symbol.c: Use C++ exception handling.
12362 * python/py-record.c: Use C++ exception handling.
12363 * python/py-record-btrace.c: Use C++ exception handling.
12364 * python/py-progspace.c: Use C++ exception handling.
12365 * python/py-prettyprint.c: Use C++ exception handling.
12366 * python/py-param.c: Use C++ exception handling.
12367 * python/py-objfile.c: Use C++ exception handling.
12368 * python/py-linetable.c: Use C++ exception handling.
12369 * python/py-lazy-string.c: Use C++ exception handling.
12370 * python/py-infthread.c: Use C++ exception handling.
12371 * python/py-inferior.c: Use C++ exception handling.
12372 * python/py-gdb-readline.c: Use C++ exception handling.
12373 * python/py-framefilter.c: Use C++ exception handling.
12374 * python/py-frame.c: Use C++ exception handling.
12375 * python/py-finishbreakpoint.c: Use C++ exception handling.
12376 * python/py-cmd.c: Use C++ exception handling.
12377 * python/py-breakpoint.c: Use C++ exception handling.
12378 * python/py-arch.c: Use C++ exception handling.
12379 * printcmd.c: Use C++ exception handling.
12380 * ppc-linux-tdep.c: Use C++ exception handling.
12381 * parse.c: Use C++ exception handling.
12382 * p-valprint.c: Use C++ exception handling.
12383 * objc-lang.c: Use C++ exception handling.
12384 * mi/mi-main.c: Use C++ exception handling.
12385 * mi/mi-interp.c: Use C++ exception handling.
12386 * mi/mi-cmd-stack.c: Use C++ exception handling.
12387 * mi/mi-cmd-break.c: Use C++ exception handling.
12388 * main.c: Use C++ exception handling.
12389 * linux-thread-db.c: Use C++ exception handling.
12390 * linux-tdep.c: Use C++ exception handling.
12391 * linux-nat.c: Use C++ exception handling.
12392 * linux-fork.c: Use C++ exception handling.
12393 * linespec.c: Use C++ exception handling.
12394 * language.c: Use C++ exception handling.
12395 * jit.c: Use C++ exception handling.
12396 * infrun.c: Use C++ exception handling.
12397 * infcmd.c: Use C++ exception handling.
12398 * infcall.c: Use C++ exception handling.
12399 * inf-loop.c: Use C++ exception handling.
12400 * i386-tdep.c: Use C++ exception handling.
12401 * i386-linux-tdep.c: Use C++ exception handling.
12402 * guile/scm-value.c: Use C++ exception handling.
12403 * guile/scm-type.c: Use C++ exception handling.
12404 * guile/scm-symtab.c: Use C++ exception handling.
12405 * guile/scm-symbol.c: Use C++ exception handling.
12406 * guile/scm-pretty-print.c: Use C++ exception handling.
12407 * guile/scm-ports.c: Use C++ exception handling.
12408 * guile/scm-param.c: Use C++ exception handling.
12409 * guile/scm-math.c: Use C++ exception handling.
12410 * guile/scm-lazy-string.c: Use C++ exception handling.
12411 * guile/scm-frame.c: Use C++ exception handling.
12412 * guile/scm-disasm.c: Use C++ exception handling.
12413 * guile/scm-cmd.c: Use C++ exception handling.
12414 * guile/scm-breakpoint.c: Use C++ exception handling.
12415 * guile/scm-block.c: Use C++ exception handling.
12416 * guile/guile-internal.h: Use C++ exception handling.
12417 * gnu-v3-abi.c: Use C++ exception handling.
12418 * gdbtypes.c: Use C++ exception handling.
12419 * frame.c: Use C++ exception handling.
12420 * frame-unwind.c: Use C++ exception handling.
12421 * fbsd-tdep.c: Use C++ exception handling.
12422 * f-valprint.c: Use C++ exception handling.
12423 * exec.c: Use C++ exception handling.
12424 * event-top.c: Use C++ exception handling.
12425 * event-loop.c: Use C++ exception handling.
12426 * eval.c: Use C++ exception handling.
12427 * dwarf2read.c: Use C++ exception handling.
12428 * dwarf2loc.c: Use C++ exception handling.
12429 * dwarf2-frame.c: Use C++ exception handling.
12430 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12431 * dwarf-index-write.c: Use C++ exception handling.
12432 * dwarf-index-cache.c: Use C++ exception handling.
12433 * dtrace-probe.c: Use C++ exception handling.
12434 * disasm-selftests.c: Use C++ exception handling.
12435 * darwin-nat.c: Use C++ exception handling.
12436 * cp-valprint.c: Use C++ exception handling.
12437 * cp-support.c: Use C++ exception handling.
12438 * cp-abi.c: Use C++ exception handling.
12439 * corelow.c: Use C++ exception handling.
12440 * completer.c: Use C++ exception handling.
12441 * compile/compile-object-run.c: Use C++ exception handling.
12442 * compile/compile-object-load.c: Use C++ exception handling.
12443 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12444 * compile/compile-c-symbols.c: Use C++ exception handling.
12445 * common/selftest.c: Use C++ exception handling.
12446 * common/new-op.c: Use C++ exception handling.
12447 * cli/cli-script.c: Use C++ exception handling.
12448 * cli/cli-interp.c: Use C++ exception handling.
12449 * cli/cli-cmds.c: Use C++ exception handling.
12450 * c-varobj.c: Use C++ exception handling.
12451 * btrace.c: Use C++ exception handling.
12452 * breakpoint.c: Use C++ exception handling.
12453 * break-catch-throw.c: Use C++ exception handling.
12454 * arch-utils.c: Use C++ exception handling.
12455 * amd64-tdep.c: Use C++ exception handling.
12456 * ada-valprint.c: Use C++ exception handling.
12457 * ada-typeprint.c: Use C++ exception handling.
12458 * ada-lang.c: Use C++ exception handling.
12459 * aarch64-tdep.c: Use C++ exception handling.
12461 2019-04-08 Tom Tromey <tom@tromey.com>
12463 * xml-support.c (gdb_xml_parser::parse): Update.
12464 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12465 * value.c (show_convenience): Update.
12466 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12467 (test_parse_flags_qcs): Update.
12468 * thread.c (thr_try_catch_cmd): Update.
12469 * target.c (target_translate_tls_address): Update.
12470 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12471 (info_frame_command_core, frame_apply_command_count): Update.
12472 * rust-exp.y (rust_lex_exception_test): Update.
12473 * riscv-tdep.c (riscv_print_one_register_info): Update.
12474 * remote.c (remote_target::enable_btrace): Update.
12475 * record-btrace.c (record_btrace_enable_warn): Update.
12476 * python/py-utils.c (gdbpy_convert_exception): Update.
12477 * printcmd.c (do_one_display, print_variable_and_value): Update.
12478 * mi/mi-main.c (mi_print_exception): Update.
12479 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12480 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12481 * linux-nat.c (linux_nat_target::attach): Update.
12482 * linux-fork.c (class scoped_switch_fork_info): Update.
12483 * infrun.c (displaced_step_prepare): Update.
12484 * infcall.c (call_function_by_hand_dummy): Update.
12485 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12486 * gnu-v3-abi.c (print_one_vtable): Update.
12487 * frame.c (get_prev_frame_always): Update.
12488 * f-valprint.c (info_common_command_for_block): Update.
12489 * exec.c (try_open_exec_file): Update.
12490 * exceptions.c (print_exception, exception_print)
12491 (exception_fprintf, exception_print_same): Update.
12492 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12493 * dwarf-index-cache.c (index_cache::store)
12494 (index_cache::lookup_gdb_index): Update.
12495 * darwin-nat.c (maybe_cache_shell): Update.
12496 * cp-valprint.c (cp_print_value_fields): Update.
12497 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12498 (gcc_cplus_symbol_address): Update.
12499 * compile/compile-c-symbols.c (gcc_convert_symbol)
12500 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12501 * common/selftest.c: Update.
12502 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12504 (exception_try_scope_entry, exception_try_scope_exit): Don't
12506 (struct exception_try_scope): Remove.
12507 (TRY): Don't use exception_try_scope.
12508 (struct gdb_exception): Add constructor, operator=.
12509 <what>: New method.
12510 (struct gdb_exception_RETURN_MASK_ALL)
12511 (struct gdb_exception_RETURN_MASK_ERROR)
12512 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12513 (struct gdb_quit_bad_alloc): Update.
12514 * common/common-exceptions.c (exception_none): Change
12516 (struct catcher) <state, exception>: Initialize inline.
12517 <prev>: Remove member.
12518 (current_catcher): Remove.
12519 (catchers): New global.
12520 (exceptions_state_mc_init): Simplify.
12521 (catcher_pop): Remove.
12522 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12523 (try_scope_depth, exception_try_scope_entry)
12524 (exception_try_scope_exit): Remove.
12525 (throw_exception_sjlj): Update.
12526 (exception_messages, exception_messages_size): Remove.
12527 (throw_it): Simplify.
12528 (gdb_exception_sliced_copy): Remove.
12529 (throw_exception_cxx): Update.
12530 * cli/cli-script.c (script_from_file): Update.
12531 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12533 * ada-valprint.c (ada_val_print): Update.
12534 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12535 (create_excep_cond_exprs): Update.
12537 2019-04-08 Tom Tromey <tom@tromey.com>
12539 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12540 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12541 (TRY, CATCH, END_CATCH): Remove some definitions.
12542 * common/common-exceptions.c: Don't use GDB_XCPT.
12543 (catcher_list_size): Remove.
12544 (throw_exception, throw_it): Simplify.
12546 2019-04-05 Tom Tromey <tom@tromey.com>
12548 Revert the header-sorting patch.
12549 * ft32-tdep.c: Revert.
12550 * frv-tdep.c: Revert.
12551 * frv-linux-tdep.c: Revert.
12553 * frame-unwind.c: Revert.
12554 * frame-base.c: Revert.
12555 * fork-child.c: Revert.
12556 * findvar.c: Revert.
12557 * findcmd.c: Revert.
12558 * filesystem.c: Revert.
12559 * filename-seen-cache.h: Revert.
12560 * filename-seen-cache.c: Revert.
12561 * fbsd-tdep.c: Revert.
12562 * fbsd-nat.h: Revert.
12563 * fbsd-nat.c: Revert.
12564 * f-valprint.c: Revert.
12565 * f-typeprint.c: Revert.
12566 * f-lang.c: Revert.
12567 * extension.h: Revert.
12568 * extension.c: Revert.
12569 * extension-priv.h: Revert.
12570 * expprint.c: Revert.
12573 * exceptions.c: Revert.
12574 * event-top.c: Revert.
12575 * event-loop.c: Revert.
12577 * elfread.c: Revert.
12578 * dwarf2read.h: Revert.
12579 * dwarf2read.c: Revert.
12580 * dwarf2loc.c: Revert.
12581 * dwarf2expr.h: Revert.
12582 * dwarf2expr.c: Revert.
12583 * dwarf2-frame.c: Revert.
12584 * dwarf2-frame-tailcall.c: Revert.
12585 * dwarf-index-write.h: Revert.
12586 * dwarf-index-write.c: Revert.
12587 * dwarf-index-common.c: Revert.
12588 * dwarf-index-cache.h: Revert.
12589 * dwarf-index-cache.c: Revert.
12590 * dummy-frame.c: Revert.
12591 * dtrace-probe.c: Revert.
12592 * disasm.h: Revert.
12593 * disasm.c: Revert.
12594 * disasm-selftests.c: Revert.
12595 * dictionary.c: Revert.
12596 * dicos-tdep.c: Revert.
12597 * demangle.c: Revert.
12598 * dcache.h: Revert.
12599 * dcache.c: Revert.
12600 * darwin-nat.h: Revert.
12601 * darwin-nat.c: Revert.
12602 * darwin-nat-info.c: Revert.
12603 * d-valprint.c: Revert.
12604 * d-namespace.c: Revert.
12605 * d-lang.c: Revert.
12607 * csky-tdep.c: Revert.
12608 * csky-linux-tdep.c: Revert.
12609 * cris-tdep.c: Revert.
12610 * cris-linux-tdep.c: Revert.
12611 * cp-valprint.c: Revert.
12612 * cp-support.c: Revert.
12613 * cp-namespace.c: Revert.
12614 * cp-abi.c: Revert.
12615 * corelow.c: Revert.
12616 * corefile.c: Revert.
12617 * continuations.c: Revert.
12618 * completer.h: Revert.
12619 * completer.c: Revert.
12620 * complaints.c: Revert.
12621 * coffread.c: Revert.
12622 * coff-pe-read.c: Revert.
12623 * cli-out.h: Revert.
12624 * cli-out.c: Revert.
12625 * charset.c: Revert.
12626 * c-varobj.c: Revert.
12627 * c-valprint.c: Revert.
12628 * c-typeprint.c: Revert.
12629 * c-lang.c: Revert.
12630 * buildsym.c: Revert.
12631 * buildsym-legacy.c: Revert.
12632 * build-id.h: Revert.
12633 * build-id.c: Revert.
12634 * btrace.c: Revert.
12635 * bsd-uthread.c: Revert.
12636 * breakpoint.h: Revert.
12637 * breakpoint.c: Revert.
12638 * break-catch-throw.c: Revert.
12639 * break-catch-syscall.c: Revert.
12640 * break-catch-sig.c: Revert.
12641 * blockframe.c: Revert.
12643 * bfin-tdep.c: Revert.
12644 * bfin-linux-tdep.c: Revert.
12645 * bfd-target.c: Revert.
12646 * bcache.c: Revert.
12647 * ax-general.c: Revert.
12648 * ax-gdb.h: Revert.
12649 * ax-gdb.c: Revert.
12650 * avr-tdep.c: Revert.
12652 * auto-load.c: Revert.
12653 * arm-wince-tdep.c: Revert.
12654 * arm-tdep.c: Revert.
12655 * arm-symbian-tdep.c: Revert.
12656 * arm-pikeos-tdep.c: Revert.
12657 * arm-obsd-tdep.c: Revert.
12658 * arm-nbsd-tdep.c: Revert.
12659 * arm-nbsd-nat.c: Revert.
12660 * arm-linux-tdep.c: Revert.
12661 * arm-linux-nat.c: Revert.
12662 * arm-fbsd-tdep.c: Revert.
12663 * arm-fbsd-nat.c: Revert.
12664 * arm-bsd-tdep.c: Revert.
12665 * arch-utils.c: Revert.
12666 * arc-tdep.c: Revert.
12667 * arc-newlib-tdep.c: Revert.
12668 * annotate.h: Revert.
12669 * annotate.c: Revert.
12670 * amd64-windows-tdep.c: Revert.
12671 * amd64-windows-nat.c: Revert.
12672 * amd64-tdep.c: Revert.
12673 * amd64-sol2-tdep.c: Revert.
12674 * amd64-obsd-tdep.c: Revert.
12675 * amd64-obsd-nat.c: Revert.
12676 * amd64-nbsd-tdep.c: Revert.
12677 * amd64-nbsd-nat.c: Revert.
12678 * amd64-nat.c: Revert.
12679 * amd64-linux-tdep.c: Revert.
12680 * amd64-linux-nat.c: Revert.
12681 * amd64-fbsd-tdep.c: Revert.
12682 * amd64-fbsd-nat.c: Revert.
12683 * amd64-dicos-tdep.c: Revert.
12684 * amd64-darwin-tdep.c: Revert.
12685 * amd64-bsd-nat.c: Revert.
12686 * alpha-tdep.c: Revert.
12687 * alpha-obsd-tdep.c: Revert.
12688 * alpha-nbsd-tdep.c: Revert.
12689 * alpha-mdebug-tdep.c: Revert.
12690 * alpha-linux-tdep.c: Revert.
12691 * alpha-linux-nat.c: Revert.
12692 * alpha-bsd-tdep.c: Revert.
12693 * alpha-bsd-nat.c: Revert.
12694 * aix-thread.c: Revert.
12696 * addrmap.c: Revert.
12697 * ada-varobj.c: Revert.
12698 * ada-valprint.c: Revert.
12699 * ada-typeprint.c: Revert.
12700 * ada-tasks.c: Revert.
12701 * ada-lang.c: Revert.
12702 * aarch64-tdep.c: Revert.
12703 * aarch64-ravenscar-thread.c: Revert.
12704 * aarch64-newlib-tdep.c: Revert.
12705 * aarch64-linux-tdep.c: Revert.
12706 * aarch64-linux-nat.c: Revert.
12707 * aarch64-fbsd-tdep.c: Revert.
12708 * aarch64-fbsd-nat.c: Revert.
12709 * aarch32-linux-nat.c: Revert.
12711 2019-04-05 Tom Tromey <tom@tromey.com>
12713 * ft32-tdep.c: Sort headers.
12714 * frv-tdep.c: Sort headers.
12715 * frv-linux-tdep.c: Sort headers.
12716 * frame.c: Sort headers.
12717 * frame-unwind.c: Sort headers.
12718 * frame-base.c: Sort headers.
12719 * fork-child.c: Sort headers.
12720 * findvar.c: Sort headers.
12721 * findcmd.c: Sort headers.
12722 * filesystem.c: Sort headers.
12723 * filename-seen-cache.h: Sort headers.
12724 * filename-seen-cache.c: Sort headers.
12725 * fbsd-tdep.c: Sort headers.
12726 * fbsd-nat.h: Sort headers.
12727 * fbsd-nat.c: Sort headers.
12728 * f-valprint.c: Sort headers.
12729 * f-typeprint.c: Sort headers.
12730 * f-lang.c: Sort headers.
12731 * extension.h: Sort headers.
12732 * extension.c: Sort headers.
12733 * extension-priv.h: Sort headers.
12734 * expprint.c: Sort headers.
12735 * exec.h: Sort headers.
12736 * exec.c: Sort headers.
12737 * exceptions.c: Sort headers.
12738 * event-top.c: Sort headers.
12739 * event-loop.c: Sort headers.
12740 * eval.c: Sort headers.
12741 * elfread.c: Sort headers.
12742 * dwarf2read.h: Sort headers.
12743 * dwarf2read.c: Sort headers.
12744 * dwarf2loc.c: Sort headers.
12745 * dwarf2expr.h: Sort headers.
12746 * dwarf2expr.c: Sort headers.
12747 * dwarf2-frame.c: Sort headers.
12748 * dwarf2-frame-tailcall.c: Sort headers.
12749 * dwarf-index-write.h: Sort headers.
12750 * dwarf-index-write.c: Sort headers.
12751 * dwarf-index-common.c: Sort headers.
12752 * dwarf-index-cache.h: Sort headers.
12753 * dwarf-index-cache.c: Sort headers.
12754 * dummy-frame.c: Sort headers.
12755 * dtrace-probe.c: Sort headers.
12756 * disasm.h: Sort headers.
12757 * disasm.c: Sort headers.
12758 * disasm-selftests.c: Sort headers.
12759 * dictionary.c: Sort headers.
12760 * dicos-tdep.c: Sort headers.
12761 * demangle.c: Sort headers.
12762 * dcache.h: Sort headers.
12763 * dcache.c: Sort headers.
12764 * darwin-nat.h: Sort headers.
12765 * darwin-nat.c: Sort headers.
12766 * darwin-nat-info.c: Sort headers.
12767 * d-valprint.c: Sort headers.
12768 * d-namespace.c: Sort headers.
12769 * d-lang.c: Sort headers.
12770 * ctf.c: Sort headers.
12771 * csky-tdep.c: Sort headers.
12772 * csky-linux-tdep.c: Sort headers.
12773 * cris-tdep.c: Sort headers.
12774 * cris-linux-tdep.c: Sort headers.
12775 * cp-valprint.c: Sort headers.
12776 * cp-support.c: Sort headers.
12777 * cp-namespace.c: Sort headers.
12778 * cp-abi.c: Sort headers.
12779 * corelow.c: Sort headers.
12780 * corefile.c: Sort headers.
12781 * continuations.c: Sort headers.
12782 * completer.h: Sort headers.
12783 * completer.c: Sort headers.
12784 * complaints.c: Sort headers.
12785 * coffread.c: Sort headers.
12786 * coff-pe-read.c: Sort headers.
12787 * cli-out.h: Sort headers.
12788 * cli-out.c: Sort headers.
12789 * charset.c: Sort headers.
12790 * c-varobj.c: Sort headers.
12791 * c-valprint.c: Sort headers.
12792 * c-typeprint.c: Sort headers.
12793 * c-lang.c: Sort headers.
12794 * buildsym.c: Sort headers.
12795 * buildsym-legacy.c: Sort headers.
12796 * build-id.h: Sort headers.
12797 * build-id.c: Sort headers.
12798 * btrace.c: Sort headers.
12799 * bsd-uthread.c: Sort headers.
12800 * breakpoint.h: Sort headers.
12801 * breakpoint.c: Sort headers.
12802 * break-catch-throw.c: Sort headers.
12803 * break-catch-syscall.c: Sort headers.
12804 * break-catch-sig.c: Sort headers.
12805 * blockframe.c: Sort headers.
12806 * block.c: Sort headers.
12807 * bfin-tdep.c: Sort headers.
12808 * bfin-linux-tdep.c: Sort headers.
12809 * bfd-target.c: Sort headers.
12810 * bcache.c: Sort headers.
12811 * ax-general.c: Sort headers.
12812 * ax-gdb.h: Sort headers.
12813 * ax-gdb.c: Sort headers.
12814 * avr-tdep.c: Sort headers.
12815 * auxv.c: Sort headers.
12816 * auto-load.c: Sort headers.
12817 * arm-wince-tdep.c: Sort headers.
12818 * arm-tdep.c: Sort headers.
12819 * arm-symbian-tdep.c: Sort headers.
12820 * arm-pikeos-tdep.c: Sort headers.
12821 * arm-obsd-tdep.c: Sort headers.
12822 * arm-nbsd-tdep.c: Sort headers.
12823 * arm-nbsd-nat.c: Sort headers.
12824 * arm-linux-tdep.c: Sort headers.
12825 * arm-linux-nat.c: Sort headers.
12826 * arm-fbsd-tdep.c: Sort headers.
12827 * arm-fbsd-nat.c: Sort headers.
12828 * arm-bsd-tdep.c: Sort headers.
12829 * arch-utils.c: Sort headers.
12830 * arc-tdep.c: Sort headers.
12831 * arc-newlib-tdep.c: Sort headers.
12832 * annotate.h: Sort headers.
12833 * annotate.c: Sort headers.
12834 * amd64-windows-tdep.c: Sort headers.
12835 * amd64-windows-nat.c: Sort headers.
12836 * amd64-tdep.c: Sort headers.
12837 * amd64-sol2-tdep.c: Sort headers.
12838 * amd64-obsd-tdep.c: Sort headers.
12839 * amd64-obsd-nat.c: Sort headers.
12840 * amd64-nbsd-tdep.c: Sort headers.
12841 * amd64-nbsd-nat.c: Sort headers.
12842 * amd64-nat.c: Sort headers.
12843 * amd64-linux-tdep.c: Sort headers.
12844 * amd64-linux-nat.c: Sort headers.
12845 * amd64-fbsd-tdep.c: Sort headers.
12846 * amd64-fbsd-nat.c: Sort headers.
12847 * amd64-dicos-tdep.c: Sort headers.
12848 * amd64-darwin-tdep.c: Sort headers.
12849 * amd64-bsd-nat.c: Sort headers.
12850 * alpha-tdep.c: Sort headers.
12851 * alpha-obsd-tdep.c: Sort headers.
12852 * alpha-nbsd-tdep.c: Sort headers.
12853 * alpha-mdebug-tdep.c: Sort headers.
12854 * alpha-linux-tdep.c: Sort headers.
12855 * alpha-linux-nat.c: Sort headers.
12856 * alpha-bsd-tdep.c: Sort headers.
12857 * alpha-bsd-nat.c: Sort headers.
12858 * aix-thread.c: Sort headers.
12859 * agent.c: Sort headers.
12860 * addrmap.c: Sort headers.
12861 * ada-varobj.c: Sort headers.
12862 * ada-valprint.c: Sort headers.
12863 * ada-typeprint.c: Sort headers.
12864 * ada-tasks.c: Sort headers.
12865 * ada-lang.c: Sort headers.
12866 * aarch64-tdep.c: Sort headers.
12867 * aarch64-ravenscar-thread.c: Sort headers.
12868 * aarch64-newlib-tdep.c: Sort headers.
12869 * aarch64-linux-tdep.c: Sort headers.
12870 * aarch64-linux-nat.c: Sort headers.
12871 * aarch64-fbsd-tdep.c: Sort headers.
12872 * aarch64-fbsd-nat.c: Sort headers.
12873 * aarch32-linux-nat.c: Sort headers.
12875 2019-04-04 Tom Tromey <tom@tromey.com>
12877 * varobj.c (varobj_create): Update.
12878 * rust-exp.y (struct rust_parser) <update_innermost_block,
12879 lookup_symbol>: New methods.
12880 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12882 (rust_parser::rust_lookup_type)
12883 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12884 * printcmd.c (display_command, do_one_display): Update.
12885 * parser-defs.h (struct parser_state) <parser_state>: Add
12886 "tracker" parameter.
12887 (block_tracker): New member.
12888 (class innermost_block_tracker) <innermost_block_tracker>: Add
12890 <reset>: Remove method.
12891 (innermost_block): Don't declare.
12892 (null_post_parser): Update.
12893 * parse.c (innermost_block): Remove global.
12894 (write_dollar_variable): Update.
12895 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12896 Remove "tracker_types" parameter.
12897 (parse_expression): Add "tracker" parameter.
12898 (parse_expression_for_completion): Update.
12899 (null_post_parser): Add "tracker" parameter.
12900 * p-exp.y: Update rules.
12901 * m2-exp.y: Update rules.
12902 * language.h (struct language_defn) <la_post_parser>: Add
12903 "tracker" parameter.
12904 * go-exp.y: Update rules.
12905 * f-exp.y: Update rules.
12906 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12908 * d-exp.y: Update rules.
12909 * c-exp.y: Update rules.
12910 * breakpoint.c (set_breakpoint_condition): Create an
12911 innermost_block_tracker.
12912 (watch_command_1): Likewise.
12913 * ada-lang.c (resolve): Add "tracker" parameter.
12914 (resolve_subexp): Likewise.
12915 * ada-exp.y (write_var_from_sym): Update.
12917 2019-04-04 Tom Tromey <tom@tromey.com>
12919 * type-stack.h: New file.
12920 * type-stack.c: New file.
12921 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12923 (insert_into_type_stack, insert_type, push_type, push_type_int)
12924 (insert_type_address_space, pop_type, pop_type_int)
12925 (pop_typelist, pop_type_stack, append_type_stack)
12926 (push_type_stack, get_type_stack, push_typelist)
12927 (follow_type_instance_flags, follow_types): Don't declare.
12928 * parse.c (type_stack): Remove global.
12929 (parse_exp_in_context): Update.
12930 (insert_into_type_stack, insert_type, push_type, push_type_int)
12931 (insert_type_address_space, pop_type, pop_type_int)
12932 (pop_typelist, pop_type_stack, append_type_stack)
12933 (push_type_stack, get_type_stack, push_typelist)
12934 (follow_type_instance_flags, follow_types): Remove (moved to
12936 * f-exp.y (type_stack): New global.
12938 (push_kind_type, f_parse): Update.
12939 * d-exp.y (type_stack): New global.
12942 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12944 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12945 (HFILES_NO_SRCDIR): Add type-stack.h.
12947 2019-04-04 Tom Tromey <tom@tromey.com>
12949 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12950 (rust_parser::convert_ast_to_expression, rust_parse)
12951 (rust_lex_test_completion, rust_lex_tests): Update.
12952 * parser-defs.h (struct expr_completion_state): New.
12953 (struct parser_state) <parser_state>: Add completion parameter.
12954 <mark_struct_expression, mark_completion_tag>: New methods.
12955 <parse_completion, m_completion_state>: New members.
12956 (prefixify_expression, null_post_parser): Update.
12957 (mark_struct_expression, mark_completion_tag): Don't declare.
12958 * parse.c (parse_completion, expout_last_struct)
12959 (expout_tag_completion_type, expout_completion_name): Remove
12961 (parser_state::mark_struct_expression)
12962 (parser_state::mark_completion_tag): Now methods.
12963 (prefixify_expression): Add last_struct parameter.
12964 (prefixify_subexp): Likewise.
12965 (parse_exp_1): Update.
12966 (parse_exp_in_context): Add cstate parameter. Update.
12967 (parse_expression_for_completion): Create an
12968 expr_completion_state.
12969 (null_post_parser): Add "completion" parameter.
12970 * p-exp.y: Update rules.
12972 * language.h (struct language_defn) <la_post_parser>: Add
12973 "completing" parameter.
12974 * go-exp.y: Update rules.
12975 (lex_one_token): Update.
12976 * expression.h (parse_completion): Don't declare.
12977 * d-exp.y: Update rules.
12978 (lex_one_token): Update rules.
12979 * c-exp.y: Update rules.
12980 (lex_one_token): Update.
12981 * ada-lang.c (resolve): Add "parse_completion" parameter.
12982 (resolve_subexp): Likewise.
12983 (ada_resolve_function): Likewise.
12985 2019-04-04 Tom Tromey <tom@tromey.com>
12987 * parser-defs.h (struct parser_state) <start_arglist,
12988 end_arglist>: New methods.
12989 <arglist_len, m_funcall_chain>: New members.
12990 (arglist_len, start_arglist, end_arglist): Don't declare.
12991 * parse.c (arglist_len, funcall_chain): Remove global.
12992 (start_arglist, end_arglist): Remove functions.
12993 (parse_exp_in_context): Update.
12994 * p-exp.y: Update rules.
12995 * m2-exp.y: Update rules.
12996 * go-exp.y: Update rules.
12997 * f-exp.y: Update rules.
12998 * d-exp.y: Update rules.
12999 * c-exp.y: Update rules.
13001 2019-04-04 Tom Tromey <tom@tromey.com>
13003 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
13004 lex_operator, push_back>: New methods.
13006 (rust_parser::lex_hex, lex_escape): Rename and update.
13007 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
13008 (rust_parser::lex_operator): Rename and update.
13009 (rust_parser::lex_number, rustyylex, rustyyerror)
13010 (rust_lex_test_init, rust_lex_test_sequence)
13011 (rust_lex_test_push_back, rust_lex_tests): Update.
13012 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
13014 <lexptr, prev_lexptr>: New members.
13015 (lexptr, prev_lexptr): Don't declare.
13016 * parse.c (lexptr, prev_lexptr): Remove globals.
13017 (parse_exp_in_context): Update.
13018 * p-exp.y (yylex, yyerror): Update.
13019 * m2-exp.y (parse_number, yylex, yyerror): Update.
13020 * go-exp.y (lex_one_token, yyerror): Update.
13021 * f-exp.y (match_string_literal, yylex, yyerror): Update.
13022 * d-exp.y (lex_one_token, yyerror): Update.
13023 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
13024 (lex_one_token, yyerror): Update.
13025 * ada-lex.l (YY_INPUT): Update.
13026 (rewind_to_char): Update.
13027 * ada-exp.y (yyerror): Update.
13029 2019-04-04 Tom Tromey <tom@tromey.com>
13031 * rust-exp.y (rustyylex, rust_lex_tests): Update.
13032 * parser-defs.h (struct parser_state) <parser_state>: Add new
13034 <comma_terminates>: New member.
13035 (comma_terminates): Don't declare global.
13036 * parse.c (comma_terminates): Remove global.
13037 (parse_exp_in_context): Update.
13038 * p-exp.y (yylex): Update.
13039 * m2-exp.y (yylex): Update.
13040 * go-exp.y (lex_one_token): Update.
13041 * f-exp.y (yylex): Update.
13042 * d-exp.y (lex_one_token): Update.
13043 * c-exp.y (lex_one_token): Update.
13044 * ada-lex.l: Update.
13046 2019-04-04 Tom Tromey <tom@tromey.com>
13048 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13049 (rustyylex, rust_lex_test_init, rust_lex_test_one)
13050 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13051 * parser-defs.h (paren_depth): Don't declare.
13052 * parse.c (paren_depth): Remove global.
13053 (parse_exp_in_context): Update.
13054 * p-exp.y (paren_depth): New global.
13055 (pascal_parse): Initialize it.
13056 * m2-exp.y (paren_depth): New global.
13057 (m2_parse): Initialize it.
13058 * go-exp.y (paren_depth): New global.
13059 (go_parse): Initialize it.
13060 * f-exp.y (paren_depth): New global.
13061 (f_parse): Initialize it.
13062 * d-exp.y (paren_depth): New global.
13063 (d_parse): Initialize it.
13064 * c-exp.y (paren_depth): New global.
13065 (c_parse): Initialize it.
13066 * ada-lex.l (paren_depth): New global.
13067 (lexer_init): Initialize it.
13069 2019-04-04 Tom Tromey <tom@tromey.com>
13071 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13072 (rust_parser::convert_ast_to_type)
13073 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13074 * parser-defs.h (struct parser_state) <parser_state>: Add
13075 parameters. Initialize new members.
13076 <expression_context_block, expression_context_pc>: New members.
13077 * parse.c (expression_context_block, expression_context_pc):
13079 (parse_exp_in_context): Update.
13080 * p-exp.y: Update all rules.
13082 * m2-exp.y: Update all rules.
13084 * go-exp.y (yylex): Update.
13085 * f-exp.y (yylex): Update.
13086 * d-exp.y: Update all rules.
13088 * c-exp.y: Update all rules.
13089 (lex_one_token, classify_name, yylex, c_parse): Update.
13090 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13092 2019-04-04 Tom Tromey <tom@tromey.com>
13094 * gdbarch.h, gdbarch.c: Rebuild.
13095 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13097 (struct stap_parse_info): Replace "parser_state" with
13099 * parser-defs.h (struct expr_builder): Rename from "parser_state".
13100 (parser_state): New class.
13101 * parse.c (expr_builder): Rename.
13102 (expr_builder::release): Rename.
13103 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13104 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13105 (write_exp_elt_longcst, write_exp_elt_floatcst)
13106 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13107 (write_exp_string_vector, write_exp_bitstring)
13108 (write_exp_msymbol, mark_struct_expression)
13109 (write_dollar_variable)
13110 (insert_type_address_space, increase_expout_size): Replace
13111 "parser_state" with "expr_builder".
13112 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13113 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13114 "parser_state" with "expr_builder".
13116 2019-04-04 Tom Tromey <tom@tromey.com>
13118 * rust-exp.y: Replace "parse_language" with method call.
13120 (yylex): Replace "parse_language" with method call.
13122 (yylex): Replace "parse_language" with method call.
13123 * go-exp.y (classify_name): Replace "parse_language" with method
13125 * f-exp.y (yylex): Replace "parse_language" with method call.
13126 * d-exp.y (lex_one_token): Replace "parse_language" with method
13129 (lex_one_token, classify_name, yylex): Replace "parse_language"
13131 * ada-exp.y (find_primitive_type, type_char)
13132 (type_system_address): Replace "parse_language" with method call.
13134 2019-04-04 Tom Tromey <tom@tromey.com>
13136 * rust-exp.y: Replace "parse_gdbarch" with method call.
13137 * parse.c (write_dollar_variable, insert_type_address_space):
13138 Replace "parse_gdbarch" with method call.
13139 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13141 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13143 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13144 "parse_gdbarch" with method call.
13145 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13147 * f-exp.y (parse_type, parse_f_type, yylex): Replace
13148 "parse_gdbarch" with method call.
13149 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13150 "parse_gdbarch" with method call.
13151 * c-exp.y (parse_type, parse_number, classify_name): Replace
13152 "parse_gdbarch" with method call.
13153 * ada-lex.l: Replace "parse_gdbarch" with method call.
13154 * ada-exp.y (parse_type, find_primitive_type, type_char)
13155 (type_system_address): Replace "parse_gdbarch" with method call.
13157 2019-04-04 Tom Tromey <tom@tromey.com>
13159 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13160 * stap-probe.c (stap_parse_argument): Update.
13161 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13162 initial_size parameter.
13163 * rust-exp.y (rust_lex_tests): Update.
13164 * parse.c (parser_state): Update.
13165 (parse_exp_in_context): Update.
13166 * parser-defs.h (struct parser_state) <parser_state>: Remove
13167 "initial_size" parameter.
13169 2019-04-04 Tom Tromey <tom@tromey.com>
13171 * parser-defs.h (increase_expout_size): Don't declare.
13172 * parse.c (increase_expout_size): Now static.
13174 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13176 * gnu-nat.c (gnu_nat_target::wait): Fix
13177 target_waitstatus_to_string call.
13179 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13181 * eval.c (evaluate_subexp_standard): Handle internal functions
13182 during Fortran function call handling.
13184 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13186 * NEWS: Mention new internal functions.
13187 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13188 (read_base_type): Use dwarf2_init_complex_target_type.
13189 * value.c (creal_internal_fn): New function.
13190 (cimag_internal_fn): New function.
13191 (_initialize_values): Register new internal functions.
13193 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13195 * infrun.c (stop_all_threads): If debug_infrun, always
13196 trace the wait status after wait_one, using
13197 target_waitstatus_to_string and target_pid_to_str.
13198 (handle_inferior_event): Replace various trace of
13199 wait status kind by a single trace.
13200 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13201 wait status kind image by target_waitstatus_to_string.
13202 * target/waitstatus.c (target_waitstatus_to_string): Fix
13205 2019-04-01 Tom Tromey <tromey@adacore.com>
13208 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13210 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13211 Pedro Alves <palves@redhat.com>
13213 * top.c (quit_force): Call 'finalize_values'.
13214 * value.c (finalize_values): New function.
13215 * value.h (finalize_values): Declare.
13217 2019-03-30 Eli Zaretskii <eliz@gnu.org>
13219 * NEWS: Announce $_gdb_major and $_gdb_minor.
13221 * top.c (init_gdb_version_vars): New function.
13222 (gdb_init): Call init_gdb_version_vars.
13224 2019-03-29 Tom Tromey <tromey@adacore.com>
13226 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13227 help text. Remove dead code.
13229 2019-03-29 Keith Seitz <keiths@redhat.com>
13231 From Siddhesh Poyarekar:
13232 * f-lang.h (f77_get_upperbound): Return LONGEST.
13233 (f77_get_lowerbound): Likewise.
13234 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13235 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13237 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13238 plongest to format print it.
13239 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13240 (f77_get_upperbound): Likewise.
13241 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13242 LOWER_BOUND to LONGEST.
13243 (f77_create_arrayprint_offset_tbl): Likewise.
13245 2019-03-29 Keith Seitz <keiths@redhat.com>
13247 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13248 %s/pulongest for TYPE_LENGTH instead of %d in format
13250 * ada-typerint.c (ada_print_type): Likewise.
13251 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13252 * compile/compile-c-support.c (generate_register_struct): Likewise.
13253 * gdbtypes.c (recursive_dump_type): Likewise.
13254 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13255 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13256 instead of %d in format strings.
13257 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13258 to std::min to ULONGEST.
13259 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13260 instead of %d in format strings.
13261 * tracepoint.c (info_scope_command): Likewise.
13262 * typeprint.c (print_offset_data::update)
13263 (print_offset_data::finish): Likewise.
13264 * xtensa-tdep.c (xtensa_store_return_value)
13265 (xtensa_push_dummy_call): Likewise.
13267 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13269 * windows-nat.c (display_selector): Fixed format specifications
13272 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13274 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13276 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13278 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13279 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13280 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13281 (nios2_linux_init_abi): Install it.
13283 2019-03-28 Alan Hayward <alan.hayward@arm.com>
13285 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13287 2019-03-28 Alan Hayward <alan.hayward@arm.com>
13289 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13291 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13292 Tom Tromey <tromey@adacore.com>
13294 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13296 2019-03-26 Joel Brobecker <brobecker@adacore.com>
13298 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13299 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13300 method to compute the bounds of range types. Also print "[evaluated]"
13301 if the bounds' values come from a dynamic evaluation.
13303 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13305 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13306 whitespace when pretty printing is on.
13308 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13310 * ppc-linux-nat.c: Add include.
13312 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13314 * NEWS: Mention AArch64 Pointer Authentication.
13316 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13318 * arm-linux-nat.c: Add include.
13320 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13322 * source-cache.c (source_cache::get_source_lines): Re-read
13323 fullname after calling open_source_file.
13325 2019-03-25 John Baldwin <jhb@FreeBSD.org>
13327 * NEWS: Mention TLS support for FreeBSD.
13329 2019-03-25 Tom Tromey <tromey@adacore.com>
13331 * minsyms.c (BUNCH_SIZE): Update comment.
13332 (~minimal_symbol_reader): Remove old comment.
13333 (compact_minimal_symbols): Update comment.
13334 (minimal_symbol_reader::install): Remove old comment. Update
13337 2019-03-25 Alan Hayward <alan.hayward@arm.com>
13339 * s390-linux-nat.c: Add include.
13341 2019-03-25 Alan Hayward <alan.hayward@arm.com>
13343 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13344 Call linux_get_hwcap.
13345 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13347 (aarch64_linux_get_hwcap): Remove function.
13348 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13350 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13352 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13353 * linux-tdep.c (linux_get_hwcap): Add function.
13354 (linux_get_hwcap2): Likewise.
13355 * linux-tdep.h (linux_get_hwcap): Add declaration.
13356 (linux_get_hwcap2): Likewise.
13357 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13358 (ppc_linux_get_hwcap2): Likewise.
13359 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13361 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13362 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13363 (ppc_linux_nat_target::read_description): Likewise.
13364 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13365 * s390-linux-nat.c: Likewise.
13366 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13368 2019-03-24 Tom Tromey <tom@tromey.com>
13370 * ada-lang.c (standard_lookup): Simplify initialization.
13371 (ada_lookup_symbol_nonlocal): Simplify return.
13372 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13373 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13374 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13375 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13377 * solib.c (solib_global_lookup): Simplify.
13378 * symtab.c (null_block_symbol): Remove.
13379 (symbol_cache_lookup): Simplify returns.
13380 (lookup_language_this): Simplify returns.
13381 (lookup_symbol_aux): Simplify return.
13382 (lookup_local_symbol): Simplify returns.
13383 (lookup_global_symbol_from_objfile): Simplify return.
13384 (lookup_symbol_in_objfile_symtabs)
13385 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13386 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13387 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13388 * cp-namespace.c (cp_lookup_bare_symbol)
13389 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13390 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13391 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13392 (cp_lookup_symbol_via_imports): Simplify initialization.
13393 (find_symbol_in_baseclass): Likewise.
13394 * symtab.h (null_block_symbol): Remove.
13395 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13396 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13397 (d_lookup_symbol_module): Likewise.
13398 (find_symbol_in_baseclass): Simplify initialization.
13400 2019-03-24 Tom Tromey <tom@tromey.com>
13402 * expression.h: Don't include symtab.h.
13403 (struct block): Forward declare.
13405 2019-03-24 Tom Tromey <tom@tromey.com>
13407 * c-exp.y (typebase): Remove casts.
13408 * gdbtypes.c (lookup_unsigned_typename, )
13409 (lookup_signed_typename): Remove cast.
13410 * eval.c (parse_to_comma_and_eval): Remove cast.
13411 * parse.c (write_dollar_variable): Remove cast.
13412 * block.h (struct block) <superblock>: Now const.
13413 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13414 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13415 (map_block): Make "block" const.
13416 * symfile.h (struct quick_symbol_functions)
13417 <map_matching_symbols>: Constify block argument to "callback".
13418 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13420 (find_pc_sect_compunit_symtab): Make "b" const.
13421 (find_symbol_at_address): Likewise.
13422 (search_symbols): Likewise.
13423 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13424 (dw2_debug_names_lookup_symbol): Likewise.
13425 (dw2_map_matching_symbols): Update.
13426 * p-valprint.c (pascal_val_print): Remove "block".
13427 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13428 (aux_add_nonlocal_symbols): Make "block" const.
13429 (resolve_subexp): Remove cast.
13430 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13432 (iterate_over_file_blocks): Likewise.
13433 * f-exp.y (%union) <bval>: Remove.
13434 * coffread.c (patch_opaque_types): Make "b" const.
13435 * spu-tdep.c (spu_catch_start): Make "block" const.
13436 * c-valprint.c (print_unpacked_pointer): Remove "block".
13437 * symmisc.c (dump_symtab_1): Make "b" const.
13438 (block_depth): Make "block" const.
13439 * d-exp.y (%union) <bval>: Remove.
13440 * cp-support.h (cp_lookup_rtti_type): Update.
13441 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13442 * psymtab.c (psym_lookup_symbol): Make "block" const.
13443 (maintenance_check_psymtabs): Make "b" const.
13444 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13445 (enumerate_locals, enumerate_args): Update.
13446 * python/py-symtab.c (stpy_global_block): Make "block" const.
13447 (stpy_static_block): Likewise.
13448 * inline-frame.c (block_starting_point_at): Make "new_block"
13450 * block.c (find_block_in_blockvector): Make return type const.
13451 (blockvector_for_pc_sect): Make "b" const.
13452 (find_block_in_blockvector): Make "b" const.
13454 2019-03-23 Tom Tromey <tom@tromey.com>
13456 * varobj.c (varobj_create): Update.
13457 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13458 * printcmd.c (display_command, do_one_display): Don't reset
13460 * parser-defs.h (enum innermost_block_tracker_type): Move to
13462 (innermost_block): Update comment.
13463 * parse.c (parse_exp_1): Add tracker_types parameter.
13464 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13465 tracker_types parameter. Reset innermost_block.
13466 (parse_exp_in_context): Remove.
13467 (parse_expression_for_completion): Update.
13468 * objfiles.c (~objfile): Don't reset expression_context_block or
13470 * expression.h (enum innermost_block_tracker_type): Move from
13472 (parse_exp_1): Add tracker_types parameter.
13473 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13474 reset innermost_block.
13476 2019-03-23 Tom Tromey <tom@tromey.com>
13478 * objfiles.h: Include bcache.h.
13480 2019-03-23 Tom Tromey <tom@tromey.com>
13482 * linespec.c (get_current_search_block): Use
13483 scoped_restore_current_language.
13484 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13486 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13487 Jiong Wang <jiong.wang@arm.com>
13489 * aarch64-linux-tdep.c
13490 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13492 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13494 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13495 Jiong Wang <jiong.wang@arm.com>
13497 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13499 (aarch64_analyze_prologue_test): Add PACIASP test.
13500 (aarch64_prologue_prev_register): Unmask PC value.
13502 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13503 Jiong Wang <jiong.wang@arm.com>
13505 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13506 (aarch64_dwarf2_prev_register): Unmask PC value.
13507 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13508 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13509 DW_CFA_AARCH64_negate_ra_state.
13510 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13512 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13513 Jiong Wang <jiong.wang@arm.com>
13515 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13517 (aarch64_pseudo_register_name): Likewise.
13518 (aarch64_pseudo_register_type): Likewise.
13519 (aarch64_pseudo_register_reggroup_p): Likewise.
13520 (aarch64_gdbarch_init): Add pauth registers.
13521 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13522 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13523 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13524 (struct gdbarch_tdep): Add regnum for ra_state.
13526 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13527 Jiong Wang <jiong.wang@arm.com>
13529 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13531 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13532 Jiong Wang <jiong.wang@arm.com>
13534 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13536 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13537 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13538 (aarch64_gdbarch_init): Add puth registers.
13539 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13540 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13541 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13543 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13544 Jiong Wang <jiong.wang@arm.com>
13546 * aarch64-linux-nat.c
13547 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13548 * aarch64-linux-tdep.c
13549 (aarch64_linux_core_read_description): Likewise.
13550 (aarch64_linux_get_hwcap): New function.
13551 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13552 (aarch64_linux_get_hwcap): New declaration.
13554 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13555 Jiong Wang <jiong.wang@arm.com>
13557 * aarch64-linux-nat.c
13558 (aarch64_linux_nat_target::read_description): Add pauth param.
13559 * aarch64-linux-tdep.c
13560 (aarch64_linux_core_read_description): Likewise.
13561 * aarch64-tdep.c (struct target_desc): Add in pauth.
13562 (aarch64_read_description): Add pauth param.
13563 (aarch64_gdbarch_init): Likewise.
13564 * aarch64-tdep.h (aarch64_read_description): Likewise.
13565 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13566 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13567 * features/Makefile: Add new files.
13568 * features/aarch64-pauth.c: New file.
13569 * features/aarch64-pauth.xml: New file.
13571 2019-03-20 Tom Tromey <tromey@adacore.com>
13573 * infrun.c (handle_inferior_event): Rename from
13574 handle_inferior_event_1. Create a scoped_value_mark.
13575 (handle_inferior_event): Remove.
13577 2019-03-19 Tom Tromey <tromey@adacore.com>
13579 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13580 * infrun.h (print_stop_event): Add "displays" parameter.
13581 * infrun.c (print_stop_event): Add "displays" parameter.
13583 2019-03-19 Pedro Alves <palves@redhat.com>
13585 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13586 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13587 to -1. Fix TABs vs spaces.
13588 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13589 * tui/tui-out.h (tui_ui_out) Add intro comments.
13590 <m_line, m_start_of_line>: In-class initialize, and add describing
13593 2019-03-18 Alan Hayward <alan.hayward@arm.com>
13595 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13597 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13599 2019-03-18 Pedro Alves <palves@redhat.com>
13600 Eli Zaretskii <eliz@gnu.org>
13602 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13603 m_line and m_start_of_line.
13605 2019-03-18 Eli Zaretskii <eliz@gnu.org>
13607 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13608 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13609 it returns a newline. This fixes a regression in TU mode, whereby
13610 the next line is output on the same screen line as the user input.
13612 2019-03-18 Tom Tromey <tromey@adacore.com>
13614 * minsyms.c (minimal_symbol_reader::install): Remove call to
13617 2019-03-18 Pedro Alves <palves@redhat.com>
13619 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13621 (apply_style): New, factored out from ...
13622 (apply_ansi_escape): ... this. Handle reverse video mode.
13623 (tui_set_reverse_mode): New function.
13624 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13625 * tui/tui-winsource.c (tui_show_source_line): Use
13626 tui_set_reverse_mode instead of setting A_STANDOUT.
13627 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13628 New setter methods.
13630 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
13632 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13635 2019-03-18 Tom Tromey <tromey@adacore.com>
13637 * ada-lang.c (empty_array): Add "high" parameter.
13638 (ada_evaluate_subexp): Update.
13640 2019-03-17 Sergei Trofimovich <siarheit@google.com>
13642 * unittests/string_view-selftests.c: Define
13643 _initialize_string_view_selftests unconditionally.
13645 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13648 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13650 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13653 * windows-nat.c (display_selector): Fix format specifiers.
13655 2019-03-17 Eli Zaretskii <eliz@gnu.org>
13657 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13658 tui_refill_source_window instead of tui_refresh_win, to update the
13659 current execution line. This fixes redisplay of the current line
13660 when stepping through the code with "next" or "step".
13662 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13664 * source-cache.c (source_cache::get_source_lines): Call
13665 find_source_lines to initialize s->nlines. This fixes vertical
13666 scrolling of TUI source window when the DOWN arrow is pressed.
13668 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13670 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13671 linux-thread-db.c (_initialize_thread_db): Likewise.
13673 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13675 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13676 wclrtoeol in tui_show_source_line". This reverts changes made in
13677 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13679 2019-03-15 Tom Tromey <tom@tromey.com>
13681 * symtab.h (struct minimal_symbol): Derive from
13682 general_symbol_info.
13683 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13684 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13685 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13686 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13687 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13688 (MSYMBOL_SEARCH_NAME): Update.
13689 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13690 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13691 * minsyms.c (minimal_symbol_reader::record_full): Update.
13693 2019-03-15 Tom Tromey <tom@tromey.com>
13695 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13697 2019-03-15 Tom Tromey <tom@tromey.com>
13699 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13700 unique_xmalloc_ptr.
13701 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13703 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13704 (build_minimal_symbol_hash_tables)
13705 (minimal_symbol_reader::install): Update.
13707 2019-03-15 Tom Tromey <tom@tromey.com>
13709 * symtab.c (create_demangled_names_hash): Update.
13710 (symbol_set_names): Update.
13711 * objfiles.h (struct objfile_per_bfd_storage)
13712 <demangled_names_hash>: Now an htab_up.
13713 * objfiles.c (objfile_per_bfd_storage): Simplify.
13715 2019-03-15 Tom Tromey <tom@tromey.com>
13717 * objfiles.h (struct objfile_per_bfd_storage): Declare
13719 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13721 (get_objfile_bfd_data): Use new. Don't initialize
13723 (free_objfile_per_bfd_storage): Remove.
13724 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13726 2019-03-15 Tom Tromey <tom@tromey.com>
13728 * symfile.c (reread_symbols): Update.
13729 * objfiles.c (objfile::objfile): Update.
13730 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13731 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13733 (minimal_symbol_reader::install): Update.
13734 (terminate_minimal_symbol_table): Remove.
13735 * jit.c (jit_object_close_impl): Update.
13737 2019-03-15 Tom Tromey <tom@tromey.com>
13739 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13742 2019-03-15 Tom Tromey <tom@tromey.com>
13744 * objfiles.h (struct objfile_per_bfd_storage)
13745 <demangled_hash_languages>: Now a bitset.
13746 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13747 (lookup_minimal_symbol): Update.
13749 2019-03-15 Tom Tromey <tom@tromey.com>
13751 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13752 Don't return the symbol.
13753 * coffread.c (record_minimal_symbol): Use record_full.
13755 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13757 The MS-Windows port of ncurses fails to switch to a color pair if
13758 one or both of the colors are the implicit default colors. This
13759 change records the default colors when TUI is initialized, and
13760 then specifies them explicitly when a color pair uses the default
13761 colors. This allows color styling in TUI mode on MS-Windows.
13763 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13765 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13766 colors in ncurses_norm_attr.
13767 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13768 "none", replace it with the default color recorded in
13771 2019-03-14 Tom Tromey <tromey@adacore.com>
13773 * source-cache.h (class source_cache) <get_source_lines>: Return
13775 * source-cache.c (source_cache::extract_lines): Handle case where
13776 first_pos==npos. Return std::string.
13777 (source_cache::get_source_lines): Update.
13779 2019-03-14 Tom Tromey <tromey@adacore.com>
13781 * NEWS: Add item for "style sources" commands.
13782 * source-cache.c (source_cache::get_source_lines): Check
13784 * cli/cli-style.c (source_styling): New global.
13785 (_initialize_cli_style): Add "style sources" commands.
13786 (show_style_sources): New function.
13787 * cli/cli-style.h (source_styling): Declare.
13789 2019-03-14 Pedro Alves <palves@redhat.com>
13790 Tom Tromey <tromey@adacore.com>
13792 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13793 * tui/tui-winsource.c (tui_refill_source_window): New function,
13795 (tui_horizontal_source_scroll): ... here. Move some logic.
13796 * cli/cli-style.c (set_style_enabled): Notify new observable.
13797 * tui/tui-hooks.c (tui_redisplay_source): New function.
13798 (tui_attach_detach_observers): Attach or detach
13799 tui_redisplay_source.
13800 * observable.h (source_styling_changed): New observable.
13801 * observable.c: Define source_styling_changed observable.
13803 2019-03-13 Tom Tromey <tromey@adacore.com>
13805 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13806 (i386_gnu_nat_target::store_registers): Update.
13807 * target-debug.h (target_debug_print_std_string): New macro.
13808 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13809 * windows-tdep.c (display_one_tib): Update.
13810 * tui/tui-stack.c (tui_make_status_line): Update.
13811 * top.c (print_inferior_quit_action): Update.
13812 * thread.c (thr_try_catch_cmd): Update.
13813 (add_thread_with_info): Update.
13814 (thread_target_id_str): Update.
13815 (thr_try_catch_cmd): Update.
13816 (thread_command): Update.
13817 (thread_find_command): Update.
13818 * record-btrace.c (record_btrace_target::info_record)
13819 (record_btrace_resume_thread, record_btrace_target::resume)
13820 (record_btrace_cancel_resume, record_btrace_step_thread)
13821 (record_btrace_target::wait, record_btrace_target::wait)
13822 (record_btrace_target::wait, record_btrace_target::stop): Update.
13823 * progspace.c (print_program_space): Update.
13824 * process-stratum-target.c
13825 (process_stratum_target::thread_address_space): Update.
13826 * linux-fork.c (linux_fork_mourn_inferior)
13827 (detach_checkpoint_command, info_checkpoints_command)
13828 (linux_fork_context): Update.
13829 (linux_fork_detach): Update.
13830 (class scoped_switch_fork_info): Update.
13831 (delete_checkpoint_command): Update.
13832 * infrun.c (follow_fork_inferior): Update.
13833 (follow_fork_inferior): Update.
13834 (proceed_after_vfork_done): Update.
13835 (handle_vfork_child_exec_or_exit): Update.
13836 (follow_exec): Update.
13837 (displaced_step_prepare_throw): Update.
13838 (displaced_step_restore): Update.
13839 (start_step_over): Update.
13840 (resume_1): Update.
13841 (clear_proceed_status_thread): Update.
13843 (print_target_wait_results): Update.
13844 (do_target_wait): Update.
13845 (context_switch): Update.
13846 (stop_all_threads): Update.
13847 (restart_threads): Update.
13848 (finish_step_over): Update.
13849 (handle_signal_stop): Update.
13850 (switch_back_to_stepped_thread): Update.
13851 (keep_going_pass_signal): Update.
13852 (print_exited_reason): Update.
13853 (normal_stop): Update.
13854 * inferior.c (inferior_pid_to_str): Change return type.
13855 (print_selected_inferior): Update.
13856 (add_inferior): Update.
13857 (detach_inferior): Update.
13858 * dummy-frame.c (fprint_dummy_frames): Update.
13859 * dcache.c (dcache_info_1): Update.
13860 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13861 (btrace_fetch, btrace_clear): Update.
13862 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13863 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13865 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13866 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13867 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13868 * gdbarch.c, gdbarch.h: Rebuild.
13869 * gdbarch.sh (core_pid_to_str): Change return type.
13870 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13872 (windows_nat_target::pid_to_str): Change return type.
13873 (windows_delete_thread): Update.
13874 (windows_nat_target::attach): Update.
13875 (windows_nat_target::files_info): Update.
13876 * target-delegates.c: Rebuild.
13877 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13879 (sol_thread_target::pid_to_str): Change return type.
13880 * remote.c (class remote_target) <pid_to_str>: Change return
13882 (remote_target::pid_to_str): Change return type.
13883 (extended_remote_target::attach, remote_target::remote_stop_ns)
13884 (remote_target::remote_notif_remove_queued_reply)
13885 (remote_target::push_stop_reply, remote_target::disable_btrace):
13887 (extended_remote_target::attach): Update.
13888 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13890 (gdbsim_target::pid_to_str): Change return type.
13891 * ravenscar-thread.c (struct ravenscar_thread_target)
13892 <pid_to_str>: Change return type.
13893 (ravenscar_thread_target::pid_to_str): Change return type.
13894 * procfs.c (class procfs_target) <pid_to_str>: Change return
13896 (procfs_target::pid_to_str): Change return type.
13897 (procfs_target::attach): Update.
13898 (procfs_target::detach): Update.
13899 (procfs_target::fetch_registers): Update.
13900 (procfs_target::store_registers): Update.
13901 (procfs_target::wait): Update.
13902 (procfs_target::files_info): Update.
13903 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13904 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13906 (nto_procfs_target::pid_to_str): Change return type.
13907 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13908 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13910 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13911 (exit_lwp): Update.
13912 (attach_proc_task_lwp_callback, get_detach_signal)
13913 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13914 (linux_nat_target::resume, wait_lwp, stop_callback)
13915 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13916 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13917 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13918 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13919 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13921 (inf_ptrace_target::attach): Update.
13922 (inf_ptrace_target::files_info): Update.
13923 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13925 (go32_nat_target::pid_to_str): Change return type.
13926 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13927 (gnu_nat_target::wait): Update.
13928 (gnu_nat_target::wait): Update.
13929 (gnu_nat_target::resume): Update.
13930 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13931 (fbsd_nat_target::wait): Update.
13932 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13934 (darwin_nat_target::attach): Update.
13935 * corelow.c (class core_target) <pid_to_str>: Change return type.
13936 (core_target::pid_to_str): Change return type.
13937 * target.c (normal_pid_to_str): Change return type.
13938 (default_pid_to_str): Likewise.
13939 (target_pid_to_str): Change return type.
13940 (target_translate_tls_address): Update.
13941 (target_announce_detach): Update.
13942 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13944 (bsd_uthread_target::pid_to_str): Change return type.
13945 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13947 (bsd_kvm_target::pid_to_str): Change return type.
13948 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13950 (aix_thread_target::pid_to_str): Change return type.
13951 * target.h (struct target_ops) <pid_to_str>: Change return type.
13952 (target_pid_to_str, normal_pid_to_str): Likewise.
13953 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13955 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13957 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13959 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13961 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13963 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13966 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13968 * NEWS: Mention that the new default MI version is 3. Mention
13969 changes to the output of commands and events that deal with
13970 multi-location breakpoints.
13971 * breakpoint.c: Include "mi/mi-out.h".
13972 (print_one_breakpoint): Change output syntax if using MI version
13974 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13976 (mi_multi_location_breakpoint_output_fixed): New.
13977 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13978 (mi_cmd_fix_multi_location_breakpoint_output): New.
13979 (mi_multi_location_breakpoint_output_fixed): New.
13980 * mi/mi-cmds.c (mi_cmds): Register command
13981 -fix-multi-location-breakpoint-output.
13982 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13985 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13987 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13988 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13989 instantiate mi_ui_out based on interpreter name.
13990 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13991 * mi/mi-main.c (mi_load_progress): Likewise.
13993 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13995 * NEWS: Combine separate "New targets" sections for 8.3.
13997 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13999 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
14000 (ppcfbsd_init_abi): Install gdbarch
14001 "fetch_tls_load_module_address" and "get_thread_local_address"
14004 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14006 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
14007 (riscv_fbsd_init_abi): Install gdbarch
14008 "fetch_tls_load_module_address" and "get_thread_local_address"
14011 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14013 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
14014 (i386fbsd_init_abi): Install gdbarch
14015 "fetch_tls_load_module_address" and "get_thread_local_address"
14018 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14020 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
14021 (amd64fbsd_init_abi): Install gdbarch
14022 "fetch_tls_load_module_address" and "get_thread_local_address"
14025 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14027 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
14028 (struct fbsd_pspace_data): New type.
14029 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
14030 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
14031 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14032 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14033 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14035 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14037 * gdbtypes.c (lookup_struct_elt): New function.
14038 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14039 * gdbtypes.h (struct struct_elt): New type.
14040 (lookup_struct_elt): New prototype.
14042 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14044 * gdbtypes.c (lookup_struct_elt_type): Update comment and
14045 remove disabled code block.
14047 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14049 * gdbarch.sh (get_thread_local_address): New method.
14050 * gdbarch.h, gdbarch.c: Regenerate.
14051 * target.c (target_translate_tls_address): Use
14052 gdbarch_get_thread_local_address if present instead of
14053 target::get_thread_local_address.
14055 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14057 * target.h (target::get_thread_local_address): Update comment.
14059 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14061 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14062 objfile->separate_debug_objfile_backlink if not NULL.
14064 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14066 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14067 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14068 (amd64bsd_store_inferior_registers): Likewise.
14069 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14070 Enable segment base registers.
14071 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14072 PT_GETFSBASE and PT_GETGSBASE.
14073 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14075 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14076 segment base registers.
14077 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14079 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14081 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14082 Update calls to i386_target_description to add 'segments'
14084 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
14085 add segment base registers.
14086 * arch/i386.c (i386_create_target_description): Add 'segments'
14087 parameter to enable segment base registers.
14088 * arch/i386.h (i386_create_target_description): Likewise.
14089 * features/i386/32bit-segments.xml: New file.
14090 * features/i386/32bit-segments.c: Generate.
14091 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14092 call to i386_target_description to add 'segments' parameter.
14093 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14094 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14095 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14096 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14097 if feature is present.
14098 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14099 Add 'segments' parameter to call to i386_target_description.
14100 (i386_target_description): Add 'segments' parameter to enable
14101 segment base registers.
14102 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14103 to call to i386_target_description.
14104 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14105 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14106 Define I386_NUM_REGS.
14107 (i386_target_description): Add 'segments' parameter to enable
14108 segment base registers.
14110 2019-03-12 Eli Zaretskii <eliz@gnu.org>
14113 * source-cache.c: #undef open and close, to avoid unresolved
14114 externals during linking.
14116 2019-03-12 Tom Tromey <tromey@adacore.com>
14118 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14119 const. Add initializers.
14120 (_initialize_remote): Don't initialize ptid globals.
14122 2019-03-12 Pedro Alves <palves@redhat.com>
14124 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14126 2019-03-12 Pedro Alves <palves@redhat.com>
14128 * cp-name-parser.y (main): Remove unused 'len' variable.
14130 2019-03-12 Tom Tromey <tromey@adacore.com>
14132 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14133 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14135 2019-03-12 Tom Tromey <tromey@adacore.com>
14137 * linux-nat.c (iterate_over_lwps): Update.
14138 (stop_callback): Remove parameter.
14139 (stop_wait_callback, detach_callback, resume_set_callback)
14140 (select_singlestep_lwp_callback, set_ignore_sigint)
14141 (status_callback, resumed_callback, resume_clear_callback)
14142 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14144 (linux_nat_target::detach, linux_nat_target::resume)
14145 (linux_stop_and_wait_all_lwps, select_event_lwp)
14146 (linux_nat_filter_event, linux_nat_wait_1)
14147 (linux_nat_target::kill, linux_nat_target::stop)
14148 (linux_nat_target::stop): Update.
14149 (linux_nat_resume_callback): Change type.
14150 (resume_stopped_resumed_lwps, count_events_callback)
14151 (select_event_lwp_callback): Likewise.
14152 (linux_stop_lwp, linux_nat_stop_lwp): Update.
14153 * arm-linux-nat.c (struct update_registers_data): Remove.
14154 (update_registers_callback): Change type.
14155 (arm_linux_insert_hw_breakpoint1): Update.
14156 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14158 (x86_linux_dr_set_addr): Update.
14159 (x86_linux_dr_set_control): Update.
14160 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14161 (iterate_over_lwps): Use gdb::function_view.
14162 * nat/aarch64-linux-hw-point.c (struct
14163 aarch64_dr_update_callback_param): Remove.
14164 (debug_reg_change_callback): Change type.
14165 (aarch64_notify_debug_reg_change): Update.
14166 * s390-linux-nat.c (s390_refresh_per_info): Update.
14168 2019-03-11 Tom Tromey <tromey@adacore.com>
14170 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14171 redundant assignment to "this_cu".
14173 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14175 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14177 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14179 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14181 (rank_one_type): ... this.
14183 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14185 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14187 (rank_one_type): ... this.
14189 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14191 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14193 (rank_one_type): ... this.
14195 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14197 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14199 (rank_one_type): ... this.
14201 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14203 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14205 (rank_one_type): ... this.
14207 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14209 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14211 (rank_one_type): ... this.
14213 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14215 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14217 (rank_one_type): ... this.
14219 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14221 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14223 (rank_one_type): ... this.
14225 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14227 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14229 (rank_one_type): ... this.
14231 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14233 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14235 (rank_one_type): ... this.
14237 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14239 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14241 (rank_one_type): ... this.
14243 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14245 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14247 (rank_one_type): ... this.
14249 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14251 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14252 inferior-events' shows the example events.
14254 2019-03-08 Eli Zaretskii <eliz@gnu.org>
14256 Support styling on native MS-Windows console
14259 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14260 on MS-Windows if $TERM is not defined.
14262 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14264 * posix-hdep.c (gdb_console_fputs):
14265 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14267 * ui-file.h (gdb_console_fputs): Add prototype.
14269 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14270 back to fputs only if the former returns zero.
14272 2019-03-07 Tom Tromey <tom@tromey.com>
14274 * symmisc.c (print_symbol_bcache_statistics): Update.
14275 (print_objfile_statistics): Update.
14276 * symfile.c (allocate_symtab): Update.
14277 * stabsread.c: Don't include bcache.h.
14278 * psymtab.h (struct psymbol_bcache): Don't declare.
14279 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14280 (psymbol_bcache_init, psymbol_bcache_free)
14281 (psymbol_bcache_get_bcache): Don't declare.
14282 * psymtab.c (struct psymbol_bcache): Remove.
14283 (psymtab_storage::psymtab_storage): Update.
14284 (psymtab_storage::~psymtab_storage): Update.
14285 (psymbol_bcache_init, psymbol_bcache_free)
14286 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14287 (add_psymbol_to_bcache): Update.
14288 (allocate_psymtab): Update.
14289 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14290 macro_cache>: No longer pointers.
14291 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14292 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14293 * macrotab.c (macro_bcache): Update.
14294 * macroexp.c: Don't include bcache.h.
14295 * gdbtypes.c (check_types_worklist): Update.
14296 (types_deeply_equal): Remove TRY/CATCH. Update.
14297 * elfread.c (elf_symtab_read): Update.
14298 * dwarf2read.c: Don't include bcache.h.
14299 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14300 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14301 (print_bcache_statistics, bcache_memory_used): Don't declare.
14302 (struct bcache): Move from bcache.c. Add constructor, destructor,
14303 methods. Rename all data members.
14304 * bcache.c (struct bcache): Move to bcache.h.
14305 (bcache::expand_hash_table): Rename from expand_hash_table.
14307 (bcache::insert): Rename from bcache_full.
14308 (bcache::compare): Rename from bcache_compare.
14309 (bcache_xmalloc): Remove.
14310 (bcache::~bcache): Rename from bcache_xfree.
14311 (bcache::print_statistics): Rename from print_bcache_statistics.
14312 (bcache::memory_used): Rename from bcache_memory_used.
14314 2019-03-07 Pedro Alves <palves@redhat.com>
14316 * infrun.c (normal_stop): Also check for
14317 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14319 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14321 * f-lang.c (value_from_host_double): Moved to...
14322 * value.c (value_from_host_double): ...here.
14323 * value.h (value_from_host_double): Declare.
14324 * guile/scm-math.c (vlscm_convert_typed_number): Use
14325 value_from_host_double.
14326 (vlscm_convert_number): Likewise.
14327 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14328 * python/py-value.c (convert_value_from_python): Likewise.
14330 2019-03-06 Tom Tromey <tom@tromey.com>
14332 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14334 2019-03-06 Tom Tromey <tom@tromey.com>
14336 * utils.h (free_current_contents): Don't declare.
14337 * utils.c (free_current_contents): Remove.
14339 2019-03-06 Tom Tromey <tom@tromey.com>
14341 * top.c (quit_force): Update.
14342 * main.c (captured_command_loop): Update.
14343 * common/new-op.c (operator new): Update.
14344 * common/common-exceptions.c (struct catcher)
14345 <save_cleanup_chain>: Remove member.
14346 (exceptions_state_mc_init): Update.
14347 (exception_try_scope_entry): Return nullptr.
14348 (exception_try_scope_exit, exception_rethrow)
14349 (throw_exception_sjlj, throw_exception_cxx): Update.
14350 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14351 (all_cleanups, do_cleanups, discard_cleanups)
14352 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14353 (restore_cleanups, restore_final_cleanups): Don't declare.
14354 (do_final_cleanups): Remove parameter.
14355 * common/cleanups.c (cleanup_chain, make_cleanup)
14356 (make_cleanup_dtor, all_cleanups, do_cleanups)
14357 (discard_my_cleanups, discard_cleanups)
14358 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14359 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14360 (null_cleanup): Remove.
14361 (do_final_cleanups): Remove parameter.
14363 2019-03-06 Tom Tromey <tom@tromey.com>
14365 * remote.c (remote_target::remote_parse_stop_reply): Use
14366 unique_xmalloc_ptr.
14368 2019-03-06 Tom Tromey <tom@tromey.com>
14370 * stabsread.c (struct stabs_field_info): Rename from field_info.
14371 <list, fnlist>: Add initializers.
14372 <obstack>: New member.
14373 (read_member_functions, read_struct_fields, read_baseclasses):
14374 Allocate on obstack. Don't use cleanups.
14375 (read_one_struct_field, read_member_functions, read_struct_fields)
14376 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14377 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14378 (read_struct_type): Update.
14380 2019-03-06 Tom Tromey <tom@tromey.com>
14382 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14383 * common/filestuff.h (make_cleanup_close): Don't declare.
14384 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14387 2019-03-06 Tom Tromey <tom@tromey.com>
14389 * solib-aix.c: Use make_scope_exit.
14391 2019-03-06 Tom Tromey <tom@tromey.com>
14393 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14394 Use make_scope_exit.
14396 2019-03-06 Tom Tromey <tom@tromey.com>
14398 * solib-svr4.c (disable_probes_interface): Remove parameter.
14399 (svr4_handle_solib_event): Use make_scope_exit.
14401 2019-03-06 Tom Tromey <tom@tromey.com>
14403 * remote.c (struct stop_reply_deleter): Remove.
14404 (stop_reply_up): Update.
14405 (struct stop_reply): Derive from notif_event. Don't typedef.
14406 <regcache>: Now a std::vector.
14407 (stop_reply_xfree): Remove.
14408 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14409 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14410 (remote_target::discard_pending_stop_replies): Use delete.
14411 (remote_target::remote_parse_stop_reply): Update.
14412 (remote_target::process_stop_reply): Update.
14413 * remote-notif.h (struct notif_event): Add virtual destructor.
14414 Remove "dtr" member.
14415 (struct notif_client) <alloc_event>: Return a unique_ptr.
14416 (notif_event_xfree): Don't declare.
14417 (notif_event_up): New typedef.
14418 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14419 (notif_event_xfree, do_notif_event_xfree): Remove.
14420 (remote_notif_state_xfree): Update.
14422 2019-03-06 Tom Tromey <tom@tromey.com>
14424 * infrun.c (displaced_step_clear_cleanup): Now a
14425 forward_scope_exit type.
14426 (displaced_step_prepare_throw): Update.
14427 (displaced_step_fixup): Update.
14429 2019-03-06 Tom Tromey <tom@tromey.com>
14431 * inferior.h (class inferior): Update comment.
14432 * gdbthread.h (class thread_info): Update comment.
14434 2019-03-06 Joel Brobecker <brobecker@adacore.com>
14435 Tom Tromey <tom@tromey.com>
14437 * stabsread.h (struct stab_section_list): Remove.
14438 (coffstab_build_psymtabs): Update.
14439 * dbxread.c (symbuf_sections): Now a std::vector.
14440 (sect_idx): New global.
14441 (fill_symbuf): Update.
14442 (coffstab_build_psymtabs): Change type of stabsects parameter.
14444 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14446 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14447 (coff_locate_sections): Update.
14448 (coff_symfile_read): Remove cleanups. Update.
14449 (init_stringtab): Add storage parameter.
14450 (free_stringtab, free_stringtab_cleanup): Remove.
14451 (init_lineno): Add storage parameter.
14452 (free_linetab, free_linetab_cleanup): Remove.
14454 2019-03-06 Pedro Alves <palves@redhat.com>
14456 * linux-fork.c (fork_info::clobber_regs): Delete.
14457 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14458 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14460 (scoped_switch_fork_info::scoped_switch_fork_info)
14461 (checkpoint_command, linux_fork_context): Adjust
14462 fork_save_infrun_state calls.
14464 2019-03-06 Pedro Alves <palves@redhat.com>
14466 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14467 (inf_has_multiple_threads): Return 'bool' and rewrite using
14468 inferior_info::threads().
14470 2019-03-06 Pedro Alves <palves@redhat.com>
14472 * linux-fork.c: Include <list>.
14473 (fork_list): Now a std::list instance.
14474 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14475 (forks_exist_p, find_last_fork): Adjust.
14476 (new_fork): Delete.
14478 (add_fork): Adjust.
14479 (free_fork): Delete, folded into fork_info::~fork_info().
14480 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14482 (init_fork_list): Delete.
14483 (linux_fork_killall, linux_fork_mourn_inferior)
14484 (linux_fork_detach, info_checkpoints_command): Adjust.
14485 (_initialize_linux_fork): No longer call init_fork_list.
14487 2019-03-06 Pedro Alves <palves@redhat.com>
14489 * linux-fork.c (new_fork): New, split out of ...
14490 (add_fork): ... this. Return void. Move "first fork" special
14491 case from here, to ...
14492 (checkpoint_command): ... here.
14493 * linux-linux.h (add_fork): Return void.
14495 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14497 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14499 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14500 Chris January <chris.january@arm.com>
14501 David Lecomber <david.lecomber@arm.com>
14503 * f-exp.y: New token, UNOP_INTRINSIC.
14504 (exp): New pattern using UNOP_INTRINSIC token.
14505 (f77_keywords): Add 'abs' keyword.
14506 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14507 (value_from_host_double): New function.
14508 (evaluate_subexp_f): Support UNOP_ABS.
14510 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14512 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14515 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14517 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14518 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14519 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14521 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14523 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14525 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14526 Chris January <chris.january@arm.com>
14528 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14529 * f-exp.y: Define 'KIND' token.
14530 (exp): New pattern for KIND expressions.
14531 (ptype): Handle types with a kind extension.
14532 (direct_abs_decl): Extend to spot kind extensions.
14533 (f77_keywords): Add 'kind' to the list.
14534 (push_kind_type): New function.
14535 (convert_to_kind_type): New function.
14536 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14537 * parse.c (operator_length_standard): Likewise.
14538 * parser-defs.h (enum type_pieces): Add tp_kind.
14539 * std-operator.def: Add UNOP_KIND.
14541 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14543 * f-exp.y (f_parse): Set yydebug.
14545 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14547 * f-lang.c (evaluate_subexp_f): New function.
14548 (exp_descriptor_f): New global.
14549 (f_language_defn): Use exp_descriptor_f instead of
14550 exp_descriptor_standard.
14552 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14554 * f-exp.y (struct token): Add comments.
14555 (dot_ops): Remove uppercase versions and the end marker.
14556 (f77_keywords): Likewise.
14557 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14558 entries in the dot_ops array are case insensitive, and use
14559 strncasecmp to compare strings. Also some whitespace cleanup in
14560 this area. Similar for the f77_keywords array, except entries in
14561 this list might be case sensitive.
14563 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14565 * f-exp.y (struct f77_boolean_val): Add comments.
14566 (boolean_values): Remove uppercase versions, and end marker.
14567 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14568 and use strncasecmp to achieve case insensitivity. Additionally,
14569 perform whitespace cleanup around this code.
14571 2019-03-06 Tom Tromey <tromey@adacore.com>
14573 * remote-sim.c (gdbsim_target_open): Use result of
14576 2019-03-06 Richard Bunt <richard.bunt@arm.com>
14577 Dirk Schubert <dirk.schubert@arm.com>
14578 Chris January <chris.january@arm.com>
14580 * eval.c (evaluate_subexp_standard): Call Fortran argument
14582 * f-lang.c (struct value): A value which can be passed into a
14583 Fortran function call.
14584 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14586 (struct type): Value ready for a Fortran function call.
14587 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14589 * f-lang.h (fortran_argument_convert): Declaration.
14590 (fortran_preserve_arg_pointer): Declaration.
14591 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14593 2019-03-05 Tom Tromey <tromey@adacore.com>
14595 * python/py-prettyprint.c (print_string_repr): Remove #if.
14596 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14598 2019-03-05 Tom Tromey <tromey@adacore.com>
14600 * target.c (the_dummy_target): Move later. Change type to
14602 (initialize_targets): Don't initialize the_dummy_target.
14604 2019-03-05 Tom Tromey <tromey@adacore.com>
14606 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14607 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14609 2019-03-05 Tom Tromey <tromey@adacore.com>
14611 * windows-nat.c (windows_nat_target::attach)
14612 (windows_nat_target::detach): Don't call gdb_flush.
14613 * valprint.c (generic_val_print, val_print, val_print_string):
14614 Don't call gdb_flush.
14615 * utils.c (defaulted_query): Don't call gdb_flush.
14616 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14617 * target.c (target_announce_detach): Don't call gdb_flush.
14618 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14619 * remote.c (extended_remote_target::attach): Don't call
14621 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14622 * printcmd.c (do_examine): Don't call gdb_flush.
14623 (info_display_command): Don't call gdb_flush.
14624 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14625 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14626 * memattr.c (info_mem_command): Don't call gdb_flush.
14627 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14628 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14629 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14630 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14631 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14632 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14633 (gnu_nat_target::detach): Don't call gdb_flush.
14634 * f-valprint.c (f_val_print): Don't call gdb_flush.
14635 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14636 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14637 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14639 * c-valprint.c (c_val_print): Don't call gdb_flush.
14640 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14642 2019-03-05 Tom Tromey <tromey@adacore.com>
14644 * varobj.c (update_dynamic_varobj_children): Update.
14645 (install_default_visualizer): Use reset, not release.
14646 * value.c (set_internalvar): Update.
14647 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14648 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14649 ATTRIBUTE_UNUSED_RESULT.
14651 2019-03-05 Tom Tromey <tromey@adacore.com>
14653 * remote.c (class scoped_remote_fd) <release>: Add
14654 ATTRIBUTE_UNUSED_RESULT.
14656 2019-03-05 Tom Tromey <tromey@adacore.com>
14658 * macroexp.c (struct macro_buffer) <release>: Add
14659 ATTRIBUTE_UNUSED_RESULT.
14661 2019-03-05 Tom Tromey <tromey@adacore.com>
14663 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14664 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14665 ATTRIBUTE_UNUSED_RESULT.
14667 2019-03-05 Tom Tromey <tromey@adacore.com>
14669 * common/scoped_fd.h (class scoped_fd) <release>: Add
14670 ATTRIBUTE_UNUSED_RESULT.
14672 2019-03-05 Tom Tromey <tromey@adacore.com>
14674 * parser-defs.h (struct parser_state) <release>: Add
14675 ATTRIBUTE_UNUSED_RESULT.
14677 2019-03-05 Tom Tromey <tromey@adacore.com>
14679 * utils.h (class gdb_argv) <release>: Add
14680 ATTRIBUTE_UNUSED_RESULT.
14681 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14683 2019-03-02 Eli Zaretskii <eliz@gnu.org>
14685 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14686 for-loop range, to avoid compiler warnings.
14688 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14689 avoid compiler warnings about unused variables.
14691 * NEWS: Mention end of support for native debugging on MS-Windows
14695 * common/netstuff.c:
14696 * gdbserver/gdbreplay.c
14697 * gdbserver/remote-utils.c:
14699 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14700 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14701 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14702 'getaddrinfo' and 'freeaddrinfo' were not available before
14703 Windows XP, and mingw.org's MinGW headers by default define
14704 _WIN32_WINNT to 0x500.
14706 2019-03-01 Gary Benson <gbenson@redhat.com>
14708 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14710 2019-02-28 Brian Vandenberg <phantall@gmail.com>
14711 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14714 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14715 set_sigint_trap, clear_sigint_trap.
14717 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14719 * target.c (target_detach): Clear the regcache and the
14722 2019-02-27 Pedro Alves <palves@redhat.com>
14724 * utils.c (set_screen_size): When we cap the height/width sizes,
14725 tweak the corresponding command variable to show "unlimited":
14727 2019-02-27 Saagar Jha <saagar@saagarjha.com>
14728 Pedro Alves <palves@redhat.com>
14730 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14731 before calling rl_set_screen_size.
14733 2019-02-27 Tom Tromey <tromey@adacore.com>
14735 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14737 * python/py-value.c: Remove Python 2.4 workaround.
14738 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14740 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14741 Python 2.4 workaround.
14742 * python/python-internal.h: Remove Python 2.4 comment.
14743 (Py_ssize_t): Don't define.
14744 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14745 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14746 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14747 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14748 * python/python.c (do_start_initialization): Remove Python 2.4
14750 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14751 (print_children): Remove Python 2.4 workaround.
14752 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14754 (CHARBUFFERPROC_NAME): Remove.
14755 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14756 Python 2.4 workaround.
14758 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14760 * NEWS: Note minimum Python version.
14762 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14764 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14765 code from these functions. Remove corresponding ifdefs. Use
14766 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14767 Remove gotos and target of gotos.
14768 (infpy_search_memory): Likewise.
14770 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14772 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14773 (hppa_gdbarch_init): Don't register deleted functions with
14776 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14778 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14779 (h8300_unwind_sp): Delete.
14780 (h8300_dummy_id): Delete.
14781 (h8300_gdbarch_init): Don't register deleted functions with
14784 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14786 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14787 (ft32_unwind_pc): Delete.
14788 (ft32_unwind_sp): Delete.
14789 (ft32_gdbarch_init): Don't register deleted functions with
14792 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14794 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14795 (frv_unwind_pc): Delete.
14796 (frv_unwind_sp): Delete.
14797 (frv_gdbarch_init): Don't register deleted functions with
14800 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14802 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14803 (riscv_unwind_pc): Delete.
14804 (riscv_unwind_sp): Delete.
14805 (riscv_gdbarch_init): Don't register deleted functions with
14808 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14810 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14811 (csky_unwind_pc): Delete.
14812 (csky_unwind_sp): Delete.
14813 (csky_gdbarch_init): Don't register deleted functions with
14816 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14818 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14819 (cris_unwind_pc): Delete.
14820 (cris_unwind_sp): Delete.
14821 (cris_gdbarch_init): Don't register deleted functions with
14824 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14826 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14827 (bfin_unwind_pc): Delete.
14828 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14830 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14832 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14833 (arm_unwind_pc): Delete.
14834 (arm_unwind_sp): Delete.
14835 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14837 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14839 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14840 (arc_unwind_pc): Delete.
14841 (arc_unwind_sp): Delete.
14842 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14844 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14846 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14847 (alpha_unwind_pc): Delete.
14848 (alpha_gdbarch_init): Don't register deleted functions with
14851 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14853 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14854 (aarch64_unwind_pc): Delete.
14855 (aarch64_unwind_sp): Delete.
14856 (aarch64_gdbarch_init): Don't register deleted functions with
14859 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14861 * gdbtypes.c (type_align): Don't consider static members when
14862 computing structure alignment.
14864 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14866 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14867 return 0 for other types.
14868 * arch-utils.c (default_type_align): Always return 0.
14869 * gdbarch.h: Regenerate.
14870 * gdbarch.sh (type_align): Extend comment.
14871 * gdbtypes.c (type_align): Add additional comments, always call
14872 gdbarch_type_align before applying the default rules.
14873 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14874 generic code will then apply a suitable default.
14875 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14876 types, return 0 for other types.
14878 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14880 * NEWS: Create a new section for the next release branch.
14881 Rename the section of the current branch, now that it has
14884 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14886 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14887 * version.in: Bump version to 8.3.50.DATE-git.
14889 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14891 * aix-thread.c (ptid_cmp): Remove unused variable.
14892 (get_signaled_thread): Likewise.
14893 (store_regs_user_thread): Likewise.
14894 (store_regs_kernel_thread): Likewise.
14895 (fetch_regs_kernel_thread): Remove shadowed variable.
14897 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14899 * features/riscv/32bit-cpu.xml: Add register numbers.
14900 * features/riscv/32bit-fpu.c: Regenerate.
14901 * features/riscv/32bit-fpu.xml: Add register numbers.
14902 * features/riscv/64bit-cpu.xml: Add register numbers.
14903 * features/riscv/64bit-fpu.c: Regenerate.
14904 * features/riscv/64bit-fpu.xml: Add register numbers.
14906 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14908 * NEWS: Mention two argument form of gdb.Value constructor.
14909 * python/py-value.c (convert_buffer_and_type_to_value): New
14911 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14912 Add support for handling an optional second argument. Call
14913 convert_buffer_and_type_to_value as appropriate.
14914 * python/python-internal.h (Py_buffer_deleter): New struct.
14915 (Py_buffer_up): New typedef.
14917 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14919 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14920 instead of releasing ownership.
14922 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14924 * dwarf2read.c (open_and_init_dwp_file): Call
14925 elf_numsections instead of bfd_count_sections to initialize
14926 dwp_file->num_sections.
14928 2019-02-25 Tom Tromey <tromey@adacore.com>
14930 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14932 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14934 * gcore.in: Add '--readnever' option when invoking GDB.
14936 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14938 * MAINTAINERS: Update my email address.
14940 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14942 * build-id.c (build_id_to_debug_bfd_1): New function.
14943 (build_id_to_debug_bfd): Look for separate debug file in
14946 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14948 * gdbarch.sh: Update the copyright year range that is placed into
14951 2019-02-22 Keith Seitz <keiths@redhat.com>
14954 * linespec.c (create_sals_line_offset): Search for the default
14955 symtab's filename instead of its fullname.
14957 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14959 * NEWS: Update style defaults.
14961 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14963 * main.c (captured_main_1): Disable styling in batch mode.
14965 2019-02-20 Tom Tromey <tom@tromey.com>
14967 * symtab.c (symtab_symbol_info): Fix typos.
14969 2019-02-20 Tom Tromey <tromey@adacore.com>
14971 * findcmd.c (_initialize_mem_search): Use upper case for
14972 metasyntactic variables.
14974 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14976 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14977 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14979 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14981 * top.h (source_file_name): Change to std::string.
14982 * top.c (source_file_name): Likewise.
14983 (command_line_input): Adjust.
14984 * cli/cli-script.c (script_from_file): Adjust.
14986 2019-02-19 Tom Tromey <tromey@adacore.com>
14988 * ravenscar-thread.c
14989 (ravenscar_thread_target::update_thread_list): Don't call
14990 ada_build_task_list.
14991 * ada-lang.h (ada_build_task_list): Don't declare.
14992 * ada-tasks.c (struct ada_tasks_inferior_data)
14993 <task_list_valid_p>: Now bool.
14994 (read_known_tasks, ada_task_list_changed)
14995 (ada_tasks_invalidate_inferior_data): Update.
14996 (read_known_tasks_array): Return bool.
14997 (read_known_tasks_list): Likewise.
14998 (read_known_tasks): Return void.
14999 (ada_build_task_list): Now static.
15001 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
15003 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
15004 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
15006 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15008 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
15009 variant for ada_tasks_pspace_data_handle and
15010 ada_tasks_inferior_data_handle.
15011 (ada_tasks_pspace_data_cleanup): New function.
15012 (ada_tasks_inferior_data_cleanup): New function.
15014 2019-02-17 Tom Tromey <tom@tromey.com>
15016 * macrotab.h (macro_source_fullname): Return a std::string.
15017 * macrotab.c (macro_include, check_for_redefinition)
15018 (macro_undef, macro_lookup_definition, foreach_macro)
15019 (foreach_macro_in_scope): Update.
15020 (macro_source_fullname): Return a std::string.
15021 * macrocmd.c (show_pp_source_pos): Update.
15023 2019-02-17 Tom Tromey <tom@tromey.com>
15025 * macrocmd.c (show_pp_source_pos): Style the file names.
15027 2019-02-17 Tom Tromey <tom@tromey.com>
15030 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
15032 2019-02-17 Tom Tromey <tom@tromey.com>
15034 * ada-lang.c (user_select_syms): Use filtered printing.
15035 * utils.c (wrap_style): New global.
15036 (desired_style): Remove.
15037 (emit_style_escape): Add stream parameter.
15038 (set_output_style, reset_terminal_style, prompt_for_continue):
15040 (flush_wrap_buffer): Only flush gdb_stdout.
15041 (wrap_here): Set wrap_style.
15042 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
15043 treat escape sequences as a character. Change when wrap buffer is
15045 (fputs_styled): Do not set the output style when the default is
15047 * ui-style.h (struct ui_file_style) <is_default>: New method.
15048 * source.c (print_source_lines_base): Emit escape sequences in one
15051 2019-02-17 Joel Brobecker <brobecker@adacore.com>
15053 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15054 integers and enumeration types.
15056 2019-02-17 Joel Brobecker <brobecker@adacore.com>
15058 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15059 instead of lookup_symbol_in_language
15060 (do_exact_match): New function.
15061 (ada_get_symbol_name_matcher): Return do_exact_match when
15062 doing a verbatim match.
15064 2019-02-15 Tom Tromey <tromey@adacore.com>
15066 * ravenscar-thread.c (ravenscar_thread_target::resume)
15067 (ravenscar_thread_target::wait): Special case wildcard requests.
15069 2019-02-15 Tom Tromey <tromey@adacore.com>
15071 * ravenscar-thread.c (base_ptid): Remove.
15072 (struct ravenscar_thread_target) <close>: New method.
15073 <m_base_ptid>: New member.
15074 <update_inferior_ptid, active_task, task_is_currently_active,
15075 runtime_initialized>: Declare methods.
15076 <ravenscar_thread_target>: Add constructor.
15077 (ravenscar_thread_target::task_is_currently_active)
15078 (ravenscar_thread_target::update_inferior_ptid)
15079 (ravenscar_runtime_initialized): Rename. Now methods.
15080 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15081 (ravenscar_thread_target::update_thread_list): Update.
15082 (ravenscar_thread_target::active_task): Now method.
15083 (ravenscar_thread_target::store_registers)
15084 (ravenscar_thread_target::prepare_to_store)
15085 (ravenscar_thread_target::prepare_to_store)
15086 (ravenscar_thread_target::mourn_inferior): Update.
15087 (ravenscar_inferior_created): Use "new" to create target.
15088 (ravenscar_thread_target::get_ada_task_ptid): Update.
15089 (_initialize_ravenscar): Don't initialize base_ptid.
15090 (ravenscar_ops): Remove global.
15092 2019-02-15 Tom Tromey <tromey@adacore.com>
15094 * target.h (push_target): Declare new overload.
15095 * target.c (push_target): New overload, taking an rvalue reference.
15096 * remote.c (remote_target::open_1): Use push_target overload.
15097 * corelow.c (core_target_open): Use push_target overload.
15099 2019-02-15 Tom Tromey <tromey@adacore.com>
15101 * ravenscar-thread.c (is_ravenscar_task)
15102 (ravenscar_task_is_currently_active): Return bool.
15103 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15104 (_initialize_ravenscar): Remove "(void)".
15105 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15108 2019-02-15 Tom Tromey <tromey@adacore.com>
15110 * ravenscar-thread.c (ravenscar_runtime_initializer)
15111 (has_ravenscar_runtime, get_running_thread_id)
15112 (ravenscar_thread_target::resume): Fix indentation.
15114 2019-02-15 Tom Tromey <tromey@adacore.com>
15116 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15117 from ravenscar_arch_ops.
15118 (sparc_ravenscar_ops::fetch_registers)
15119 (sparc_ravenscar_ops::store_registers): Now methods.
15120 (sparc_ravenscar_prepare_to_store): Remove.
15121 (sparc_ravenscar_ops): Redefine.
15122 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15123 methods and destructor. Remove members.
15124 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15125 (ravenscar_thread_target::store_registers)
15126 (ravenscar_thread_target::prepare_to_store): Update.
15127 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15129 (struct ppc_ravenscar_powerpc_ops): Derive from
15130 ravenscar_arch_ops.
15131 (ppc_ravenscar_powerpc_ops::fetch_registers)
15132 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15133 (ppc_ravenscar_powerpc_ops): Redefine.
15134 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15135 (ppc_ravenscar_e500_ops::fetch_registers)
15136 (ppc_ravenscar_e500_ops::store_registers): Now methods.
15137 (ppc_ravenscar_e500_ops): Redefine.
15138 * aarch64-ravenscar-thread.c
15139 (aarch64_ravenscar_generic_prepare_to_store): Remove.
15140 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15141 (aarch64_ravenscar_fetch_registers)
15142 (aarch64_ravenscar_store_registers): Now methods.
15143 (aarch64_ravenscar_ops): Redefine.
15145 2019-02-15 Tom Tromey <tromey@adacore.com>
15147 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15148 (ravenscar_thread_target::stopped_by_hw_breakpoint)
15149 (ravenscar_thread_target::stopped_by_watchpoint)
15150 (ravenscar_thread_target::stopped_data_address)
15151 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15153 2019-02-15 Tom Tromey <tromey@adacore.com>
15155 * ravenscar-thread.c: Fix some typos.
15157 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15158 Tom Tromey <tromey@adacore.com>
15160 * ada-lang.c (ada_exception_sal): Change addr_string to a
15162 (create_ada_exception_catchpoint): Update.
15164 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15165 Tom Tromey <tromey@adacore.com>
15167 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15168 (bp_location_ops): Remove.
15169 (base_breakpoint_allocate_location): Update.
15170 (free_bp_location): Update.
15171 * ada-lang.c (class ada_catchpoint_location)
15172 <ada_catchpoint_location>: Remove ops parameter.
15173 (ada_catchpoint_location_dtor): Remove.
15174 (ada_catchpoint_location_ops): Remove.
15175 (allocate_location_exception): Update.
15176 * breakpoint.h (struct bp_location_ops): Remove.
15177 (class bp_location) <bp_location>: Remove bp_location_ops
15179 <~bp_location>: Add destructor.
15182 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15183 Pedro Alves <palves@redhat.com>
15185 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15188 2019-02-14 David Michael <fedora.dm0@gmail.com>
15189 Samuel Thibault <samuel.thibault@gnu.org>
15190 Thomas Schwinge <thomas@codesourcery.com>
15192 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15193 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15195 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15197 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15198 (check_empty): Use "const char *".
15200 * gnu-nat.c (gnu_nat_target::detach): Instead of
15201 'detach_inferior (pid)' call
15202 'detach_inferior (find_inferior_pid (pid))'.
15204 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15205 'nat/fork-inferior.o'.
15206 * gnu-nat.c: #include "nat/fork-inferior.h".
15208 * gnu-nat.c (gnu_nat_target::detach): Instead of
15209 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15210 * gnu-nat.h: #include "inf-child.h".
15211 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15212 'i386_gnu_nat_target::fetch_registers'.
15213 (gnu_store_registers): Rename/move to
15214 'i386_gnu_nat_target::store_registers'.
15216 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15217 * gnu-nat.h (mach_thread_info): New function.
15218 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15220 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15222 2019-02-14 Frederic Konrad <konrad@adacore.com>
15224 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15226 2019-02-14 Joel Brobecker <brobecker@adacore.com>
15228 * windows-nat.c (windows_add_thread): Add new parameter
15229 "main_thread_p" with default value set to false. Update
15230 function documentation as well as all callers.
15231 (windows_delete_thread): Likewise.
15232 (fake_create_process): Update call to windows_add_thread.
15233 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15234 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15235 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15236 call to windows_delete_thread.
15238 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15240 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15242 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15244 * symfile.c (find_separate_debug_file): Use canonical path of
15245 sysroot with child_path instead of gdb_sysroot if it is valid.
15247 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15249 * symfile.c (find_separate_debug_file): Use child_path to
15250 determine if an object file is under a sysroot.
15252 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15254 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15255 unittests/child-path-selftests.c.
15256 * common/pathstuff.c (child_path): New function.
15257 * common/pathstuff.h (child_path): New prototype.
15258 * unittests/child-path-selftests.c: New file.
15260 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15262 * symfile.c (find_separate_debug_file): Look for separate debug
15263 files in debug directories under the sysroot.
15265 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15267 * symtab.h (struct minimal_symbol data_p): New const method.
15268 (struct minimal_symbol text_p): Likewise.
15269 * symtab.c (output_source_filename): Use file name style
15270 to print file name.
15271 (print_symbol_info): Likewise.
15272 (print_msymbol_info): Use address style to print addresses.
15273 Use function name style to print executable text symbols.
15274 (expand_symtab_containing_pc): Use data_p.
15275 (find_pc_sect_compunit_symtab): Likewise.
15277 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15279 * breakpoint.c (describe_other_breakpoints): Use address style
15280 to print addresses.
15281 (say_where): Likewise.
15283 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15285 * ada-typeprint.c (print_func_type): Print function name
15286 style to print function name.
15287 * c-typeprint.c (c_print_type_1): Likewise.
15289 2019-02-11 Alan Hayward <alan.hayward@arm.com>
15291 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15294 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15296 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15299 2019-02-10 Joel Brobecker <brobecker@adacore.com>
15301 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15302 TYPE_CODE_REF types.
15304 2019-02-08 Jim Wilson <jimw@sifive.com>
15306 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15307 (riscv_linux_fregset): New.
15308 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15310 2019-02-07 Tom Tromey <tom@tromey.com>
15312 * thread.c (thread_cancel_execution_command): Update.
15313 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15315 (struct thread_fsm_ops): Remove.
15316 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15317 (thread_fsm_should_stop, thread_fsm_return_value)
15318 (thread_fsm_set_finished, thread_fsm_finished_p)
15319 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15321 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15322 * infrun.c (clear_proceed_status_thread)
15323 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15324 (print_stop_event): Update.
15325 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15327 (step_command_fsm_ops): Remove.
15328 (new_step_command_fsm): Remove.
15330 (step_command_fsm::should_stop): Rename from
15331 step_command_fsm_should_stop.
15332 (step_command_fsm::clean_up): Rename from
15333 step_command_fsm_clean_up.
15334 (step_command_fsm::do_async_reply_reason): Rename from
15335 step_command_fsm_async_reply_reason.
15336 (struct until_next_fsm): Inherit from thread_fsm. Add
15338 (until_next_fsm_ops): Remove.
15339 (new_until_next_fsm): Remove.
15340 (until_next_fsm::should_stop): Rename from
15341 until_next_fsm_should_stop.
15342 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15343 (until_next_fsm::do_async_reply_reason): Rename from
15344 until_next_fsm_async_reply_reason.
15345 (struct finish_command_fsm): Inherit from thread_fsm. Add
15346 constructor. Change type of breakpoint.
15347 (finish_command_fsm_ops): Remove.
15348 (new_finish_command_fsm): Remove.
15349 (finish_command_fsm::should_stop): Rename from
15350 finish_command_fsm_should_stop.
15351 (finish_command_fsm::clean_up): Rename from
15352 finish_command_fsm_clean_up.
15353 (finish_command_fsm::return_value): Rename from
15354 finish_command_fsm_return_value.
15355 (finish_command_fsm::do_async_reply_reason): Rename from
15356 finish_command_fsm_async_reply_reason.
15357 (finish_command): Update.
15358 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15360 (call_thread_fsm_ops): Remove.
15361 (call_thread_fsm::call_thread_fsm): Rename from
15362 new_call_thread_fsm.
15363 (call_thread_fsm::should_stop): Rename from
15364 call_thread_fsm_should_stop.
15365 (call_thread_fsm::should_notify_stop): Rename from
15366 call_thread_fsm_should_notify_stop.
15367 (run_inferior_call, call_function_by_hand_dummy): Update.
15368 * cli/cli-interp.c (should_print_stop_to_console): Update.
15369 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15370 Add constructor. Change type of location_breakpoint,
15372 (until_break_fsm_ops): Remove.
15373 (new_until_break_fsm): Remove.
15374 (until_break_fsm::should_stop): Rename from
15375 until_break_fsm_should_stop.
15376 (until_break_fsm::clean_up): Rename from
15377 until_break_fsm_clean_up.
15378 (until_break_fsm::do_async_reply_reason): Rename from
15379 until_break_fsm_async_reply_reason.
15380 (until_break_command): Update.
15381 * thread-fsm.c: Remove.
15382 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15384 2019-02-07 Tom Tromey <tom@tromey.com>
15386 * yy-remap.h: Add include guard.
15387 * xtensa-tdep.h: Add include guard.
15388 * xcoffread.h: Rename include guard.
15389 * varobj-iter.h: Add include guard.
15390 * tui/tui.h: Rename include guard.
15391 * tui/tui-winsource.h: Rename include guard.
15392 * tui/tui-wingeneral.h: Rename include guard.
15393 * tui/tui-windata.h: Rename include guard.
15394 * tui/tui-win.h: Rename include guard.
15395 * tui/tui-stack.h: Rename include guard.
15396 * tui/tui-source.h: Rename include guard.
15397 * tui/tui-regs.h: Rename include guard.
15398 * tui/tui-out.h: Rename include guard.
15399 * tui/tui-layout.h: Rename include guard.
15400 * tui/tui-io.h: Rename include guard.
15401 * tui/tui-hooks.h: Rename include guard.
15402 * tui/tui-file.h: Rename include guard.
15403 * tui/tui-disasm.h: Rename include guard.
15404 * tui/tui-data.h: Rename include guard.
15405 * tui/tui-command.h: Rename include guard.
15406 * tic6x-tdep.h: Add include guard.
15407 * target/waitstatus.h: Rename include guard.
15408 * target/wait.h: Rename include guard.
15409 * target/target.h: Rename include guard.
15410 * target/resume.h: Rename include guard.
15411 * target-float.h: Rename include guard.
15412 * stabsread.h: Add include guard.
15413 * rs6000-tdep.h: Add include guard.
15414 * riscv-fbsd-tdep.h: Add include guard.
15415 * regformats/regdef.h: Rename include guard.
15416 * record.h: Rename include guard.
15417 * python/python.h: Rename include guard.
15418 * python/python-internal.h: Rename include guard.
15419 * python/py-stopevent.h: Rename include guard.
15420 * python/py-ref.h: Rename include guard.
15421 * python/py-record.h: Rename include guard.
15422 * python/py-record-full.h: Rename include guard.
15423 * python/py-record-btrace.h: Rename include guard.
15424 * python/py-instruction.h: Rename include guard.
15425 * python/py-events.h: Rename include guard.
15426 * python/py-event.h: Rename include guard.
15427 * procfs.h: Add include guard.
15428 * proc-utils.h: Add include guard.
15429 * p-lang.h: Add include guard.
15430 * or1k-tdep.h: Rename include guard.
15431 * observable.h: Rename include guard.
15432 * nto-tdep.h: Rename include guard.
15433 * nat/x86-linux.h: Rename include guard.
15434 * nat/x86-linux-dregs.h: Rename include guard.
15435 * nat/x86-gcc-cpuid.h: Add include guard.
15436 * nat/x86-dregs.h: Rename include guard.
15437 * nat/x86-cpuid.h: Rename include guard.
15438 * nat/ppc-linux.h: Rename include guard.
15439 * nat/mips-linux-watch.h: Rename include guard.
15440 * nat/linux-waitpid.h: Rename include guard.
15441 * nat/linux-ptrace.h: Rename include guard.
15442 * nat/linux-procfs.h: Rename include guard.
15443 * nat/linux-osdata.h: Rename include guard.
15444 * nat/linux-nat.h: Rename include guard.
15445 * nat/linux-namespaces.h: Rename include guard.
15446 * nat/linux-btrace.h: Rename include guard.
15447 * nat/glibc_thread_db.h: Rename include guard.
15448 * nat/gdb_thread_db.h: Rename include guard.
15449 * nat/gdb_ptrace.h: Rename include guard.
15450 * nat/fork-inferior.h: Rename include guard.
15451 * nat/amd64-linux-siginfo.h: Rename include guard.
15452 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15453 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15454 * nat/aarch64-linux.h: Rename include guard.
15455 * nat/aarch64-linux-hw-point.h: Rename include guard.
15456 * mn10300-tdep.h: Add include guard.
15457 * mips-linux-tdep.h: Add include guard.
15458 * mi/mi-parse.h: Rename include guard.
15459 * mi/mi-out.h: Rename include guard.
15460 * mi/mi-main.h: Rename include guard.
15461 * mi/mi-interp.h: Rename include guard.
15462 * mi/mi-getopt.h: Rename include guard.
15463 * mi/mi-console.h: Rename include guard.
15464 * mi/mi-common.h: Rename include guard.
15465 * mi/mi-cmds.h: Rename include guard.
15466 * mi/mi-cmd-break.h: Rename include guard.
15467 * m2-lang.h: Add include guard.
15468 * location.h: Rename include guard.
15469 * linux-record.h: Rename include guard.
15470 * linux-nat.h: Add include guard.
15471 * linux-fork.h: Add include guard.
15472 * i386-darwin-tdep.h: Rename include guard.
15473 * hppa-linux-offsets.h: Add include guard.
15474 * guile/guile.h: Rename include guard.
15475 * guile/guile-internal.h: Rename include guard.
15476 * gnu-nat.h: Rename include guard.
15477 * gdb-stabs.h: Rename include guard.
15478 * frv-tdep.h: Add include guard.
15479 * f-lang.h: Add include guard.
15480 * event-loop.h: Add include guard.
15481 * darwin-nat.h: Rename include guard.
15482 * cp-abi.h: Rename include guard.
15483 * config/sparc/nm-sol2.h: Rename include guard.
15484 * config/nm-nto.h: Rename include guard.
15485 * config/nm-linux.h: Add include guard.
15486 * config/i386/nm-i386gnu.h: Rename include guard.
15487 * config/djgpp/nl_types.h: Rename include guard.
15488 * config/djgpp/langinfo.h: Rename include guard.
15489 * compile/gcc-cp-plugin.h: Add include guard.
15490 * compile/gcc-c-plugin.h: Add include guard.
15491 * compile/compile.h: Rename include guard.
15492 * compile/compile-object-run.h: Rename include guard.
15493 * compile/compile-object-load.h: Rename include guard.
15494 * compile/compile-internal.h: Rename include guard.
15495 * compile/compile-cplus.h: Rename include guard.
15496 * compile/compile-c.h: Rename include guard.
15497 * common/xml-utils.h: Rename include guard.
15498 * common/x86-xstate.h: Rename include guard.
15499 * common/version.h: Rename include guard.
15500 * common/vec.h: Rename include guard.
15501 * common/tdesc.h: Rename include guard.
15502 * common/selftest.h: Rename include guard.
15503 * common/scoped_restore.h: Rename include guard.
15504 * common/scoped_mmap.h: Rename include guard.
15505 * common/scoped_fd.h: Rename include guard.
15506 * common/safe-iterator.h: Rename include guard.
15507 * common/run-time-clock.h: Rename include guard.
15508 * common/refcounted-object.h: Rename include guard.
15509 * common/queue.h: Rename include guard.
15510 * common/ptid.h: Rename include guard.
15511 * common/print-utils.h: Rename include guard.
15512 * common/preprocessor.h: Rename include guard.
15513 * common/pathstuff.h: Rename include guard.
15514 * common/observable.h: Rename include guard.
15515 * common/netstuff.h: Rename include guard.
15516 * common/job-control.h: Rename include guard.
15517 * common/host-defs.h: Rename include guard.
15518 * common/gdb_wait.h: Rename include guard.
15519 * common/gdb_vecs.h: Rename include guard.
15520 * common/gdb_unlinker.h: Rename include guard.
15521 * common/gdb_unique_ptr.h: Rename include guard.
15522 * common/gdb_tilde_expand.h: Rename include guard.
15523 * common/gdb_sys_time.h: Rename include guard.
15524 * common/gdb_string_view.h: Rename include guard.
15525 * common/gdb_splay_tree.h: Rename include guard.
15526 * common/gdb_setjmp.h: Rename include guard.
15527 * common/gdb_ref_ptr.h: Rename include guard.
15528 * common/gdb_optional.h: Rename include guard.
15529 * common/gdb_locale.h: Rename include guard.
15530 * common/gdb_assert.h: Rename include guard.
15531 * common/filtered-iterator.h: Rename include guard.
15532 * common/filestuff.h: Rename include guard.
15533 * common/fileio.h: Rename include guard.
15534 * common/environ.h: Rename include guard.
15535 * common/common-utils.h: Rename include guard.
15536 * common/common-types.h: Rename include guard.
15537 * common/common-regcache.h: Rename include guard.
15538 * common/common-inferior.h: Rename include guard.
15539 * common/common-gdbthread.h: Rename include guard.
15540 * common/common-exceptions.h: Rename include guard.
15541 * common/common-defs.h: Rename include guard.
15542 * common/common-debug.h: Rename include guard.
15543 * common/cleanups.h: Rename include guard.
15544 * common/buffer.h: Rename include guard.
15545 * common/btrace-common.h: Rename include guard.
15546 * common/break-common.h: Rename include guard.
15547 * cli/cli-utils.h: Rename include guard.
15548 * cli/cli-style.h: Rename include guard.
15549 * cli/cli-setshow.h: Rename include guard.
15550 * cli/cli-script.h: Rename include guard.
15551 * cli/cli-interp.h: Rename include guard.
15552 * cli/cli-decode.h: Rename include guard.
15553 * cli/cli-cmds.h: Rename include guard.
15554 * charset-list.h: Add include guard.
15555 * buildsym-legacy.h: Rename include guard.
15556 * bfin-tdep.h: Add include guard.
15557 * ax.h: Rename include guard.
15558 * arm-linux-tdep.h: Add include guard.
15559 * arm-fbsd-tdep.h: Add include guard.
15560 * arch/xtensa.h: Rename include guard.
15561 * arch/tic6x.h: Add include guard.
15562 * arch/i386.h: Add include guard.
15563 * arch/arm.h: Rename include guard.
15564 * arch/arm-linux.h: Rename include guard.
15565 * arch/arm-get-next-pcs.h: Rename include guard.
15566 * arch/amd64.h: Add include guard.
15567 * arch/aarch64-insn.h: Rename include guard.
15568 * arch-utils.h: Rename include guard.
15569 * annotate.h: Add include guard.
15570 * amd64-darwin-tdep.h: Rename include guard.
15571 * aarch64-linux-tdep.h: Add include guard.
15572 * aarch64-fbsd-tdep.h: Add include guard.
15573 * aarch32-linux-nat.h: Add include guard.
15575 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15577 * macrotab.c (macro_define_internal): New function that
15578 factorizes macro_define_object_internal and macro_define_function
15580 (macro_define_object_internal): Use macro_define_internal.
15581 (macro_define_function): Likewise.
15583 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15585 * macrocmd.c (extract_identifier): Return
15586 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15589 2019-02-06 John Baldwin <jhb@FreeBSD.org>
15591 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15593 2019-02-05 Tom Tromey <tom@tromey.com>
15595 * target.c (target_stack::unpush): Move assertion earlier.
15597 2019-01-30 Tom Tromey <tom@tromey.com>
15600 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15601 (gdbpy_parse_and_eval): Likewise.
15602 * python/python-internal.h (gdbpy_allow_threads): New class.
15604 2019-01-28 John Baldwin <jhb@FreeBSD.org>
15606 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15607 (aarch64_fbsd_fpregmap): Move earlier.
15608 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15609 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15610 instead of individual calls to trad_frame_set_reg_addr.
15611 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15613 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15614 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15615 instead of individual calls to trad_frame_set_reg_addr.
15617 2019-01-28 Alan Hayward <alan.hayward@arm.com>
15619 * CONTRIBUTE: Replace contribution list with wiki link.
15621 2019-01-25 Tom Tromey <tom@tromey.com>
15623 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15625 2019-01-25 Tom Tromey <tom@tromey.com>
15627 * xtensa-linux-nat.c: Fix common/ includes.
15628 * xml-support.h: Fix common/ includes.
15629 * xml-support.c: Fix common/ includes.
15630 * x86-linux-nat.c: Fix common/ includes.
15631 * windows-nat.c: Fix common/ includes.
15632 * varobj.h: Fix common/ includes.
15633 * varobj.c: Fix common/ includes.
15634 * value.c: Fix common/ includes.
15635 * valops.c: Fix common/ includes.
15636 * utils.c: Fix common/ includes.
15637 * unittests/xml-utils-selftests.c: Fix common/ includes.
15638 * unittests/utils-selftests.c: Fix common/ includes.
15639 * unittests/unpack-selftests.c: Fix common/ includes.
15640 * unittests/tracepoint-selftests.c: Fix common/ includes.
15641 * unittests/style-selftests.c: Fix common/ includes.
15642 * unittests/string_view-selftests.c: Fix common/ includes.
15643 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15644 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15645 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15646 * unittests/rsp-low-selftests.c: Fix common/ includes.
15647 * unittests/parse-connection-spec-selftests.c: Fix common/
15649 * unittests/optional-selftests.c: Fix common/ includes.
15650 * unittests/offset-type-selftests.c: Fix common/ includes.
15651 * unittests/observable-selftests.c: Fix common/ includes.
15652 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15653 * unittests/memrange-selftests.c: Fix common/ includes.
15654 * unittests/memory-map-selftests.c: Fix common/ includes.
15655 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15656 * unittests/function-view-selftests.c: Fix common/ includes.
15657 * unittests/environ-selftests.c: Fix common/ includes.
15658 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15659 * unittests/common-utils-selftests.c: Fix common/ includes.
15660 * unittests/cli-utils-selftests.c: Fix common/ includes.
15661 * unittests/array-view-selftests.c: Fix common/ includes.
15662 * ui-file.c: Fix common/ includes.
15663 * tui/tui-io.c: Fix common/ includes.
15664 * tracepoint.h: Fix common/ includes.
15665 * tracepoint.c: Fix common/ includes.
15666 * tracefile-tfile.c: Fix common/ includes.
15667 * top.h: Fix common/ includes.
15668 * top.c: Fix common/ includes.
15669 * thread.c: Fix common/ includes.
15670 * target/waitstatus.h: Fix common/ includes.
15671 * target/waitstatus.c: Fix common/ includes.
15672 * target.h: Fix common/ includes.
15673 * target.c: Fix common/ includes.
15674 * target-memory.c: Fix common/ includes.
15675 * target-descriptions.c: Fix common/ includes.
15676 * symtab.h: Fix common/ includes.
15677 * symfile.c: Fix common/ includes.
15678 * stap-probe.c: Fix common/ includes.
15679 * spu-linux-nat.c: Fix common/ includes.
15680 * sparc-nat.c: Fix common/ includes.
15681 * source.c: Fix common/ includes.
15682 * solib.c: Fix common/ includes.
15683 * solib-target.c: Fix common/ includes.
15684 * ser-unix.c: Fix common/ includes.
15685 * ser-tcp.c: Fix common/ includes.
15686 * ser-pipe.c: Fix common/ includes.
15687 * ser-base.c: Fix common/ includes.
15688 * selftest-arch.c: Fix common/ includes.
15689 * s12z-tdep.c: Fix common/ includes.
15690 * rust-exp.y: Fix common/ includes.
15691 * rs6000-aix-tdep.c: Fix common/ includes.
15692 * riscv-tdep.c: Fix common/ includes.
15693 * remote.c: Fix common/ includes.
15694 * remote-notif.h: Fix common/ includes.
15695 * remote-fileio.h: Fix common/ includes.
15696 * remote-fileio.c: Fix common/ includes.
15697 * regcache.h: Fix common/ includes.
15698 * regcache.c: Fix common/ includes.
15699 * record-btrace.c: Fix common/ includes.
15700 * python/python.c: Fix common/ includes.
15701 * python/py-type.c: Fix common/ includes.
15702 * python/py-inferior.c: Fix common/ includes.
15703 * progspace.h: Fix common/ includes.
15704 * producer.c: Fix common/ includes.
15705 * procfs.c: Fix common/ includes.
15706 * proc-api.c: Fix common/ includes.
15707 * printcmd.c: Fix common/ includes.
15708 * ppc-linux-nat.c: Fix common/ includes.
15709 * parser-defs.h: Fix common/ includes.
15710 * osdata.c: Fix common/ includes.
15711 * obsd-nat.c: Fix common/ includes.
15712 * nat/x86-linux.c: Fix common/ includes.
15713 * nat/x86-linux-dregs.c: Fix common/ includes.
15714 * nat/x86-dregs.h: Fix common/ includes.
15715 * nat/x86-dregs.c: Fix common/ includes.
15716 * nat/ppc-linux.c: Fix common/ includes.
15717 * nat/mips-linux-watch.h: Fix common/ includes.
15718 * nat/mips-linux-watch.c: Fix common/ includes.
15719 * nat/linux-waitpid.c: Fix common/ includes.
15720 * nat/linux-ptrace.h: Fix common/ includes.
15721 * nat/linux-ptrace.c: Fix common/ includes.
15722 * nat/linux-procfs.c: Fix common/ includes.
15723 * nat/linux-personality.c: Fix common/ includes.
15724 * nat/linux-osdata.c: Fix common/ includes.
15725 * nat/linux-namespaces.c: Fix common/ includes.
15726 * nat/linux-btrace.h: Fix common/ includes.
15727 * nat/linux-btrace.c: Fix common/ includes.
15728 * nat/fork-inferior.c: Fix common/ includes.
15729 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15730 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15731 * nat/aarch64-linux.c: Fix common/ includes.
15732 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15733 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15734 * namespace.h: Fix common/ includes.
15735 * mips-linux-tdep.c: Fix common/ includes.
15736 * minsyms.c: Fix common/ includes.
15737 * mi/mi-parse.h: Fix common/ includes.
15738 * mi/mi-main.c: Fix common/ includes.
15739 * mi/mi-cmd-env.c: Fix common/ includes.
15740 * memrange.h: Fix common/ includes.
15741 * memattr.c: Fix common/ includes.
15742 * maint.h: Fix common/ includes.
15743 * maint.c: Fix common/ includes.
15744 * main.c: Fix common/ includes.
15745 * machoread.c: Fix common/ includes.
15746 * location.c: Fix common/ includes.
15747 * linux-thread-db.c: Fix common/ includes.
15748 * linux-nat.c: Fix common/ includes.
15749 * linux-fork.c: Fix common/ includes.
15750 * inline-frame.c: Fix common/ includes.
15751 * infrun.c: Fix common/ includes.
15752 * inflow.c: Fix common/ includes.
15753 * inferior.h: Fix common/ includes.
15754 * inferior.c: Fix common/ includes.
15755 * infcmd.c: Fix common/ includes.
15756 * inf-ptrace.c: Fix common/ includes.
15757 * inf-child.c: Fix common/ includes.
15758 * ia64-linux-nat.c: Fix common/ includes.
15759 * i387-tdep.c: Fix common/ includes.
15760 * i386-tdep.c: Fix common/ includes.
15761 * i386-linux-tdep.c: Fix common/ includes.
15762 * i386-linux-nat.c: Fix common/ includes.
15763 * i386-go32-tdep.c: Fix common/ includes.
15764 * i386-fbsd-tdep.c: Fix common/ includes.
15765 * i386-fbsd-nat.c: Fix common/ includes.
15766 * guile/scm-type.c: Fix common/ includes.
15767 * guile/guile.c: Fix common/ includes.
15768 * go32-nat.c: Fix common/ includes.
15769 * gnu-nat.c: Fix common/ includes.
15770 * gdbthread.h: Fix common/ includes.
15771 * gdbarch-selftests.c: Fix common/ includes.
15772 * gdb_usleep.c: Fix common/ includes.
15773 * gdb_select.h: Fix common/ includes.
15774 * gdb_bfd.c: Fix common/ includes.
15775 * gcore.c: Fix common/ includes.
15776 * fork-child.c: Fix common/ includes.
15777 * findvar.c: Fix common/ includes.
15778 * fbsd-nat.c: Fix common/ includes.
15779 * event-top.c: Fix common/ includes.
15780 * event-loop.c: Fix common/ includes.
15781 * dwarf2read.c: Fix common/ includes.
15782 * dwarf2loc.c: Fix common/ includes.
15783 * dwarf2-frame.c: Fix common/ includes.
15784 * dwarf-index-cache.c: Fix common/ includes.
15785 * dtrace-probe.c: Fix common/ includes.
15786 * disasm-selftests.c: Fix common/ includes.
15787 * defs.h: Fix common/ includes.
15788 * csky-tdep.c: Fix common/ includes.
15789 * cp-valprint.c: Fix common/ includes.
15790 * cp-support.h: Fix common/ includes.
15791 * cp-support.c: Fix common/ includes.
15792 * corelow.c: Fix common/ includes.
15793 * completer.h: Fix common/ includes.
15794 * completer.c: Fix common/ includes.
15795 * compile/compile.c: Fix common/ includes.
15796 * compile/compile-loc2c.c: Fix common/ includes.
15797 * compile/compile-cplus-types.c: Fix common/ includes.
15798 * compile/compile-cplus-symbols.c: Fix common/ includes.
15799 * command.h: Fix common/ includes.
15800 * cli/cli-dump.c: Fix common/ includes.
15801 * cli/cli-cmds.c: Fix common/ includes.
15802 * charset.c: Fix common/ includes.
15803 * build-id.c: Fix common/ includes.
15804 * btrace.h: Fix common/ includes.
15805 * btrace.c: Fix common/ includes.
15806 * breakpoint.h: Fix common/ includes.
15807 * breakpoint.c: Fix common/ includes.
15809 (enum agent_op): Fix common/ includes.
15810 * ax-general.c (struct aop_map): Fix common/ includes.
15811 * ax-gdb.c: Fix common/ includes.
15812 * auxv.c: Fix common/ includes.
15813 * auto-load.c: Fix common/ includes.
15814 * arm-tdep.c: Fix common/ includes.
15815 * arch/riscv.c: Fix common/ includes.
15816 * arch/ppc-linux-common.c: Fix common/ includes.
15817 * arch/i386.c: Fix common/ includes.
15818 * arch/arm.c: Fix common/ includes.
15819 * arch/arm-linux.c: Fix common/ includes.
15820 * arch/arm-get-next-pcs.c: Fix common/ includes.
15821 * arch/amd64.c: Fix common/ includes.
15822 * arch/aarch64.c: Fix common/ includes.
15823 * arch/aarch64-insn.c: Fix common/ includes.
15824 * arch-utils.c: Fix common/ includes.
15825 * amd64-windows-tdep.c: Fix common/ includes.
15826 * amd64-tdep.c: Fix common/ includes.
15827 * amd64-sol2-tdep.c: Fix common/ includes.
15828 * amd64-obsd-tdep.c: Fix common/ includes.
15829 * amd64-nbsd-tdep.c: Fix common/ includes.
15830 * amd64-linux-tdep.c: Fix common/ includes.
15831 * amd64-linux-nat.c: Fix common/ includes.
15832 * amd64-fbsd-tdep.c: Fix common/ includes.
15833 * amd64-fbsd-nat.c: Fix common/ includes.
15834 * amd64-dicos-tdep.c: Fix common/ includes.
15835 * amd64-darwin-tdep.c: Fix common/ includes.
15836 * agent.c: Fix common/ includes.
15837 * ada-lang.h: Fix common/ includes.
15838 * ada-lang.c: Fix common/ includes.
15839 * aarch64-tdep.c: Fix common/ includes.
15841 2019-01-25 Tom Tromey <tom@tromey.com>
15843 * common/create-version.sh: Use common/version.h.
15845 2019-01-24 Pedro Alves <palves@redhat.com>
15847 * infrun.c (signal_stop, signal_print, signal_program)
15848 (signal_catch, signal_pass): Now arrays instead of pointers.
15849 (update_signals_program_target, do_target_resume)
15850 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15851 * linux-nat.c (linux_nat_target::pass_signals)
15852 (linux_nat_target::create_inferior, linux_nat_target::attach):
15854 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15855 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15856 * procfs.c (procfs_target::pass_signals): Adjust.
15857 * record-full.c (record_full_target::resume): Adjust.
15858 * remote.c (remote_target::pass_signals)
15859 (remote_target::program_signals): Adjust.
15860 * target-debug.h (target_debug_print_signals): Now takes a
15861 gdb::array_view as parameter. Adjust.
15862 * target.h (target_ops) <pass_signals, program_signals>: Replace
15863 pointer and length parameters with gdb::array_view.
15864 (target_pass_signals, target_program_signals): Likewise.
15865 * target-delegates.c: Regenerate.
15867 2019-01-24 Pedro Alves <palves@redhat.com>
15869 * common/forward-scope-exit.h
15870 (forward_scope_exit::forward_scope_exit): Pass arguments to
15871 m_bind_function directly, instead of creating a std::bind and
15874 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15876 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15877 for static members.
15878 (pass_in_v_vfp_candidate): Likewise.
15880 2019-01-23 Tom Tromey <tom@tromey.com>
15881 Pedro Alves <palves@redhat.com>
15883 * regcache.c (class regcache_invalidator): Remove.
15884 (regcache::raw_write): Use make_scope_exit.
15886 2019-01-23 Tom Tromey <tom@tromey.com>
15888 * ui-out.h (class ui_out_emit_type): Update comment.
15890 2019-01-23 Tom Tromey <tom@tromey.com>
15892 * infrun.c (fetch_inferior_event): Update comment.
15894 2019-01-23 Tom Tromey <tom@tromey.com>
15895 Pedro Alves <palves@redhat.com>
15897 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15899 (fetch_inferior_event): Use SCOPE_EXIT.
15902 2019-01-23 Tom Tromey <tom@tromey.com>
15903 Pedro Alves <palves@redhat.com>
15905 * infrun.c (disable_thread_events): Delete.
15906 (stop_all_threads): Use SCOPE_EXIT.
15908 2019-01-23 Tom Tromey <tom@tromey.com>
15909 Pedro Alves <palves@redhat.com>
15911 * symfile.c: Include forward-scope-exit.h.
15912 (clear_symtab_users_cleanup): Replace forward declaration with
15913 a FORWARD_SCOPE_EXIT.
15914 (syms_from_objfile_1): Use the forward_scope_exit and
15915 gdb::optional instead of cleanup_function.
15916 (reread_symbols): Use the forward_scope_exit instead of
15918 (clear_symtab_users_cleanup): Remove function.
15920 2019-01-23 Tom Tromey <tom@tromey.com>
15921 Pedro Alves <palves@redhat.com>
15923 * linux-nat.c: Include scope-exit.h.
15924 (cleanup_target_stop): Remove.
15925 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15928 2019-01-23 Tom Tromey <tom@tromey.com>
15929 Pedro Alves <palves@redhat.com>
15931 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15932 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15934 2019-01-23 Tom Tromey <tom@tromey.com>
15935 Andrew Burgess <andrew.burgess@embecosm.com>
15936 Pedro Alves <palves@redhat.com>
15938 * infrun.c (fetch_inferior_event): Use scope_exit.
15939 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15940 * top.c (execute_command): Use scope_exit.
15941 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15942 * utils.c (do_bpstat_clear_actions_cleanup)
15943 (make_bpstat_clear_actions_cleanup): Remove.
15945 2019-01-23 Tom Tromey <tom@tromey.com>
15946 Pedro Alves <palves@redhat.com>
15948 * infrun.c: Include "common/scope-exit.h"
15949 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15950 (wait_for_inferior): Use SCOPE_EXIT.
15951 (fetch_inferior_event): Use scope_exit.
15953 2019-01-23 Tom Tromey <tom@tromey.com>
15954 Pedro Alves <palves@redhat.com>
15956 * breakpoint.c (create_breakpoint): Remove cleanup.
15958 2019-01-23 Tom Tromey <tom@tromey.com>
15959 Andrew Burgess <andrew.burgess@embecosm.com>
15960 Pedro Alves <palves@redhat.com>
15962 2019-01-23 Pedro Alves <palves@redhat.com>
15964 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15966 2019-01-23 Pedro Alves <palves@redhat.com>
15967 Andrew Burgess <andrew.burgess@embecosm.com>
15969 * gdbthread.h: Include "common/forward-scope-exit.h".
15970 (scoped_finish_thread_state): Redefine custom class in terms of
15971 forward_scope_exit.
15973 2019-01-23 Pedro Alves <palves@redhat.com>
15974 Andrew Burgess <andrew.burgess@embecosm.com>
15976 * common/forward-scope-exit.h: New file.
15978 2019-01-23 Pedro Alves <palves@redhat.com>
15979 Andrew Burgess <andrew.burgess@embecosm.com>
15980 Tom Tromey <tom@tromey.com>
15982 * common/scope-exit.h: New file.
15984 2019-01-23 Pedro Alves <palves@redhat.com>
15986 * common/preprocessor.h (ESC): Rename to ...
15987 (ESC_PARENS): ... this.
15988 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15989 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15991 2019-01-23 Tom Tromey <tom@tromey.com>
15993 * language.h (class scoped_switch_to_sym_language_if_auto):
15994 Initialize m_lang in both cases.
15996 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15998 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
16001 2019-01-22 Tom Tromey <tom@tromey.com>
16003 * corelow.c: Do not include sys/file.h.
16005 2019-01-22 Tom Tromey <tom@tromey.com>
16007 * tui/tui-wingeneral.h: Include gdb_curses.h.
16009 2019-01-22 Tom Tromey <tom@tromey.com>
16011 * source-cache.h (class source_cache) <get_source_lines,
16012 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
16014 2019-01-22 Tom Tromey <tom@tromey.com>
16016 * remote-fileio.h (struct remote_target): Declare.
16018 2019-01-22 Tom Tromey <tom@tromey.com>
16020 * python/py-arch.c: Do not include py-ref.h.
16021 * python/py-bpevent.c: Do not include py-ref.h.
16022 * python/py-cmd.c: Do not include py-ref.h.
16023 * python/py-continueevent.c: Do not include py-ref.h.
16024 * python/py-event.h: Do not include py-ref.h.
16025 * python/py-evtregistry.c: Do not include py-ref.h.
16026 * python/py-finishbreakpoint.c: Do not include py-ref.h.
16027 * python/py-frame.c: Do not include py-ref.h.
16028 * python/py-framefilter.c: Do not include py-ref.h.
16029 * python/py-function.c: Do not include py-ref.h.
16030 * python/py-infevents.c: Do not include py-ref.h.
16031 * python/py-linetable.c: Do not include py-ref.h.
16032 * python/py-objfile.c: Do not include py-ref.h.
16033 * python/py-param.c: Do not include py-ref.h.
16034 * python/py-prettyprint.c: Do not include py-ref.h.
16035 * python/py-progspace.c: Do not include py-ref.h.
16036 * python/py-symbol.c: Do not include py-ref.h.
16037 * python/py-symtab.c: Do not include py-ref.h.
16038 * python/py-type.c: Do not include py-ref.h.
16039 * python/py-unwind.c: Do not include py-ref.h.
16040 * python/py-utils.c: Do not include py-ref.h.
16041 * python/py-value.c: Do not include py-ref.h.
16042 * python/py-varobj.c: Do not include py-ref.h.
16043 * python/py-xmethods.c: Do not include py-ref.h.
16044 * python/python.c: Do not include py-ref.h.
16045 * varobj.c: Do not include py-ref.h.
16047 2019-01-22 Tom Tromey <tom@tromey.com>
16049 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16050 keyword for bcache.
16052 2019-01-22 Tom Tromey <tom@tromey.com>
16054 * compile/compile-cplus-types.c: Remove a comment by #include.
16056 2019-01-22 Tom Tromey <tom@tromey.com>
16058 * compile/gcc-c-plugin.h: Include compile-internal.h.
16060 2019-01-22 Tom Tromey <tom@tromey.com>
16062 * stabsread.c (EXTERN): Do not define.
16063 (symnum, next_symbol_text_func, processing_gcc_compilation)
16064 (within_function, global_sym_chain, global_stabs)
16065 (previous_stab_code, this_object_header_files)
16066 (n_this_object_header_files)
16067 (n_allocated_this_object_header_files): Define.
16068 * stabsread.h (EXTERN): Never define. Use "extern".
16070 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16072 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16075 2019-01-21 Tom Tromey <tom@tromey.com>
16077 * ui-out.c: Fix includes.
16078 * tui/tui-source.c: Fix includes.
16079 * target.c: Fix includes.
16080 * remote.c: Fix includes.
16081 * regcache.c: Fix includes.
16082 * python/py-block.c: Fix includes.
16083 * printcmd.c: Fix includes.
16084 * or1k-tdep.c: Fix includes.
16085 * mi/mi-main.c: Fix includes.
16086 * m32r-tdep.c: Fix includes.
16087 * csky-tdep.c: Fix includes.
16088 * compile/compile-cplus-types.c: Fix includes.
16089 * cli/cli-interp.c: Fix includes.
16091 2019-01-21 Alan Hayward <alan.hayward@arm.com>
16093 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16096 2019-01-16 Tom Tromey <tom@tromey.com>
16098 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
16100 (struct objfile) <msymbols_range>: Move from top level.
16101 <msymbols>: New method.
16102 (class objfile_msymbols): Remove.
16103 * symtab.c (default_collect_symbol_completion_matches_break_on):
16105 * symmisc.c (dump_msymbols): Update.
16106 * stabsread.c (scan_file_globals): Update.
16107 * objc-lang.c (info_selectors_command, info_classes_command)
16108 (find_methods): Update.
16109 * minsyms.c (find_solib_trampoline_target): Update.
16110 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16111 * coffread.c (coff_symfile_read): Update.
16112 * ada-lang.c (ada_lookup_simple_minsym)
16113 (ada_collect_symbol_completion_matches): Update.
16115 2019-01-16 Tom Tromey <tom@tromey.com>
16117 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16118 type. Remove no-argument constructor.
16119 <iterator::operator++>: Simplify.
16121 <end>: Use minimal_symbol_count.
16123 2019-01-16 Tom Tromey <tom@tromey.com>
16125 * objfiles.h (struct objfile) <psymtabs>: New method.
16126 (class objfile_psymtabs): Remove.
16127 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16129 <range>: New method.
16130 (require_partial_symbols): Change return type.
16131 * psymtab.c (require_partial_symbols)
16132 (psym_expand_symtabs_matching): Update.
16133 * mdebugread.c (parse_partial_symbols): Update.
16134 * dbxread.c (dbx_end_psymtab): Update.
16136 2019-01-15 Tom Tromey <tom@tromey.com>
16138 * symtab.c (lookup_objfile_from_block)
16139 (lookup_symbol_in_objfile_symtabs)
16140 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16141 (find_line_symtab, info_sources_command)
16142 (default_collect_symbol_completion_matches_break_on)
16143 (make_source_files_completion_list): Update.
16144 * symmisc.c (print_objfile_statistics, dump_objfile)
16145 (maintenance_print_symbols, maintenance_info_symtabs)
16146 (maintenance_check_symtabs, maintenance_info_line_tables):
16148 * source.c (select_source_symtab)
16149 (forget_cached_source_info_for_objfile): Update.
16150 * objfiles.h (class objfile_compunits): Remove.
16151 (struct objfile) <compunits_range>: New typedef.
16152 (compunits): New method.
16153 * objfiles.c (objfile_relocate1): Update.
16154 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16155 * maint.c (count_symtabs_and_blocks): Update.
16156 * linespec.c (iterate_over_all_matching_symtabs): Update.
16157 * cp-support.c (add_symbol_overload_list_qualified): Update.
16158 * coffread.c (coff_symtab_read): Update.
16159 * ada-lang.c (add_nonlocal_symbols)
16160 (ada_collect_symbol_completion_matches)
16161 (ada_add_global_exceptions): Update.
16163 2019-01-15 Tom Tromey <tom@tromey.com>
16165 * progspace.h (program_space) <objfiles_safe_range>: New
16167 <objfiles_safe>: New method.
16168 * objfiles.h (class all_objfiles_safe): Remove.
16169 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16170 * jit.c (jit_inferior_exit_hook): Update.
16172 2019-01-17 Tom Tromey <tom@tromey.com>
16174 * progspace.h (program_space) <objfiles_range>: New typedef.
16175 <objfiles>: New method.
16176 <objfiles_head>: Rename from objfiles.
16177 (object_files): Update.
16178 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16179 * guile/scm-pretty-print.c
16180 (ppscm_find_pretty_printer_from_objfiles): Update.
16181 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16182 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16184 * python/py-progspace.c (pspy_get_objfiles): Update.
16185 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16187 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16188 (objfpy_lookup_objfile_by_build_id): Update.
16189 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16190 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16192 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16193 (expand_symtab_containing_pc, lookup_objfile_from_block)
16194 (lookup_static_symbol, basic_lookup_transparent_type)
16195 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16196 (find_line_symtab, info_sources_command)
16197 (default_collect_symbol_completion_matches_break_on)
16198 (make_source_files_completion_list, find_main_name): Update.
16199 * symmisc.c (print_symbol_bcache_statistics)
16200 (print_objfile_statistics, maintenance_print_symbols)
16201 (maintenance_print_msymbols, maintenance_print_objfiles)
16202 (maintenance_info_symtabs, maintenance_check_symtabs)
16203 (maintenance_expand_symtabs, maintenance_info_line_tables):
16205 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16206 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16207 (map_overlay_command, unmap_overlay_command)
16208 (simple_overlay_update, expand_symtabs_matching)
16209 (map_symbol_filenames): Update.
16210 * symfile-debug.c (set_debug_symfile): Update.
16211 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16213 * source.c (select_source_symtab, forget_cached_source_info):
16215 * solib.c (solib_read_symbols): Update.
16216 * solib-spu.c (append_ocl_sos): Update.
16217 * psymtab.c (maintenance_print_psymbols)
16218 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16219 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16220 * printcmd.c (info_symbol_command): Update.
16221 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16223 * objfiles.h (class all_objfiles): Remove.
16224 * objfiles.c (have_partial_symbols, have_full_symbols)
16225 (have_minimal_symbols, qsort_cmp, update_section_map)
16226 (shared_objfile_contains_address_p)
16227 (default_iterate_over_objfiles_in_search_order): Update.
16228 * objc-lang.c (info_selectors_command, info_classes_command)
16229 (find_methods): Update.
16230 * minsyms.c (find_solib_trampoline_target): Update.
16231 * maint.c (maintenance_info_sections)
16232 (maintenance_translate_address, count_symtabs_and_blocks):
16234 * main.c (captured_main_1): Update.
16235 * linux-thread-db.c (try_thread_db_load_from_pdir)
16236 (has_libpthread): Update.
16237 * linespec.c (iterate_over_all_matching_symtabs)
16238 (search_minsyms_for_name): Update.
16239 * jit.c (jit_find_objf_with_entry_addr): Update.
16240 * hppa-tdep.c (find_unwind_entry)
16241 (hppa_lookup_stub_minimal_symbol): Update.
16242 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16244 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16245 (elf_gnu_ifunc_resolve_by_got): Update.
16246 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16247 * dwarf-index-write.c (save_gdb_index_command): Update.
16248 * cp-support.c (add_symbol_overload_list_qualified): Update.
16249 * breakpoint.c (create_overlay_event_breakpoint)
16250 (create_longjmp_master_breakpoint)
16251 (create_std_terminate_master_breakpoint)
16252 (create_exception_master_breakpoint): Update.
16253 * blockframe.c (find_pc_partial_function): Update.
16254 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16255 (ada_collect_symbol_completion_matches)
16256 (ada_add_global_exceptions): Update.
16258 2019-01-17 Tom Tromey <tom@tromey.com>
16260 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16262 (solib_target_parse_libraries): Change return type.
16263 (library_list_start_segment, library_list_start_section)
16264 (library_list_end_library, library_list_start_library); Update.
16265 (solib_target_free_library_list): Remove.
16266 (solib_target_parse_libraries): Remove cleanup. Change return
16268 (solib_target_current_sos): Update.
16270 2019-01-17 Tom Tromey <tromey@bapiya>
16272 * valprint.c: Replace "the the" with "the".
16273 * symtab.c: Replace "the the" with "the".
16274 * solib.c: Replace "the the" with "the".
16275 * solib-dsbt.c: Replace "the the" with "the".
16276 * linespec.c: Replace "the the" with "the".
16277 * dwarf2loc.h: Replace "the the" with "the".
16278 * amd64-windows-tdep.c: Replace "the the" with "the".
16279 * aarch64-tdep.c: Replace "the the" with "the".
16281 2019-01-16 Keith Seitz <keiths@redhat.com>
16284 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16285 <builder>: Rename to ..
16286 <m_builder>: ... this and make private.
16287 (dwarf2_cu::get_builder): New method. Change all users of
16288 `builder' to use this method.
16289 (dwarf2_start_symtab): Move to ...
16290 (dwarf2_cu::start_symtab): ... here. Update all callers
16291 (setup_type_unit_groups): Move to ...
16292 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16294 (dwarf2_cu::reset_builder): New method.
16295 (process_full_compunit, process_full_type_unit): Use
16296 dwarf2_cu::reset_builder.
16297 (follow_die_offset): Record the ancestor CU if it is different
16298 from the followed DIE's CU.
16299 (follow_die_sig_1): Likewise.
16301 2019-01-15 Tom Tromey <tom@tromey.com>
16303 * remote.c (class remote_state) <buf>: Now a char_vector.
16304 <buf_size>: Remove.
16305 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16307 (remote_target::getpkt_or_notif_sane_1)
16308 (remote_target::getpkt_sane)
16309 (remote_target::getpkt_or_notif_sane): Likewise.
16310 (class remote_target) <putpkt>: New overload.
16311 (remote_target::read_frame): Change type of "buf_p". Remove
16312 sizeof_p parameter.
16313 (packet_ok): New overload.
16314 (packet_check_result): New overload.
16317 2019-01-14 Tom Tromey <tom@tromey.com>
16319 * remote-notif.c (handle_notification, remote_notif_ack)
16320 (remote_notif_parse): Make "buf" const.
16321 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16323 (remote_notif_parse, remote_notif_ack, handle_notification):
16325 * remote.c (remote_notif_stop_parse): Make "buf" const.
16326 (remote_target::remote_parse_stop_reply): Make "buf" const.
16327 (remote_notif_stop_ack): Make "buf" const.
16329 2019-01-14 Tom Tromey <tom@tromey.com>
16331 * remote.c (remote_console_output): Make parameter const.
16333 2019-01-14 Tom Tromey <tom@tromey.com>
16335 * target-debug.h (target_debug_print_signals): Constify.
16336 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16337 * procfs.c (procfs_target::pass_signals): Update.
16338 * linux-nat.c (linux_nat_target::pass_signals): Update.
16339 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16340 * target-delegates.c: Rebuild.
16341 * remote.c (remote_target::program_signals): Update.
16342 (remote_target::pass_signals): Update.
16343 * target.c (target_pass_signals): Constify argument.
16344 (target_program_signals): Likewise.
16345 * target.h (struct target_ops) <pass_signals, program_signals>:
16347 (target_pass_signals, target_program_signals): Constify argument.
16349 2019-01-14 Tom Tromey <tom@tromey.com>
16352 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16354 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16356 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16358 * rs6000-tdep.c: Include reggroups.h.
16359 (IS_V_ALIAS_PSEUDOREG): Define.
16360 (rs6000_register_name): Return names for the "vX" aliases.
16361 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16362 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16363 aliases. Call default_register_reggroup_p for all other
16365 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16367 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16368 Handle "vX" aliases.
16369 (v_alias_pseudo_register_collect): New function.
16370 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16371 (rs6000_gdbarch_init): Initialize "vX" aliases as
16372 pseudo-registers. Restore registration of
16373 rs6000_pseudo_register_reggroup_p with
16374 set_tdesc_pseudo_register_reggroup_p.
16376 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16378 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16379 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16380 set_gdbarch_num_pseudo_regs.
16382 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16384 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16385 Remove arg prefixname, add do_set and do_show.
16386 Add member functions set_list and show_list.
16387 * cli/cli-style.c (class cli_style_option): Update accordingly.
16388 (style_set_list): Move to file scope.
16389 (style_show_list): Likewise.
16390 (set_style): Call help_list.
16391 (show_style): Call cmd_show_list.
16392 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16393 Update to use the new macro.
16395 2019-10-12 Joel Brobecker <brobecker@adacore.com>
16397 * ada-lang.c (_initialize_ada_language): Expand the help text
16398 for the "catch exception" command.
16400 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16402 * symtab.c (matching_obj_sections): Initialize obj,
16403 declare it closer to its usage.
16405 2019-01-10 Tom Tromey <tom@tromey.com>
16407 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16408 (basic_inf_threads_range): Remove.
16409 (inf_threads_range, inf_non_exited_threads_range)
16410 (safe_inf_threads_range): Use next_adapter.
16412 2019-01-10 Keith Seitz <keiths@redhat.com>
16416 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16417 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16419 2019-01-10 Keith Seitz <keiths@redhat.com>
16423 * dictionary.c (pending_to_vector): Remove.
16424 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16425 Remove _1 suffix, replacing functions of the same name. Update
16427 (dict_create_hashed, dict_create_hashed_expandable)
16428 (dict_create_linear, dict_create_linear_expandable, dict_free)
16429 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16430 Make functions static.
16432 2019-01-10 Keith Seitz <keiths@redhat.com>
16436 * dictionary.h (struct dictionary): Replace declaration with
16438 (dict_create_hashed, dict_create_hashed_expandable)
16439 (dict_create_linear, dict_create_linear_expandable)
16440 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16441 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16442 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16443 taking multidictionary argument.
16444 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16445 * block.h (struct block) <dict>: Change to multidictionary
16446 and rename `multidict'.
16447 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16448 symmisc.c: Update all dictionary references to multidictionary.
16450 2019-01-10 Keith Seitz <keiths@redhat.com>
16454 * dictionary.c: Include unordered_map.
16455 (pending_to_vector): New function.
16456 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16457 Rewrite the non-"_1" functions to take vector instead
16459 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16460 "new" _1 versions of the same name.
16461 (multidictionary): Define.
16462 (std::hash<enum language): New definition.
16463 (collate_pending_symbols_by_language, mdict_create_hashed)
16464 (mdict_create_hashed_expandable, mdict_create_linear)
16465 (mdict_create_linear_expandable, mdict_free)
16466 (find_language_dictionary, create_new_language_dictionary)
16467 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16468 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16469 (mdict_size, mdict_empty): New functions.
16470 * dictionary.h (mdict_iterator): Define.
16472 2019-01-10 Pedro Alves <palves@redhat.com>
16474 * breakpoint.c (read_uploaded_action)
16475 (create_tracepoint_from_upload): Adjust to use
16476 gdb::unique_xmalloc_ptr.
16477 * ctf.c (ctf_write_uploaded_tp):
16478 (SET_ARRAY_FIELD): Use emplace_back.
16479 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16480 * tracefile-tfile.c (tfile_write_uploaded_tp):
16481 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16482 gdb::unique_xmalloc_ptr.
16483 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16484 at_string, cond_string, cmd_strings>: Replace char pointers
16485 with gdb::unique_xmalloc_ptr.
16487 2019-01-10 Pedro Alves <palves@redhat.com>
16489 * solib-target.c (library_list_start_library): Don't xstrdup name.
16491 2019-01-10 Pedro Alves <palves@redhat.com>
16493 * mdebugread.c (parse_partial_symbols): Use
16494 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16496 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16498 * linux-fork.c (scoped_switch_fork_info)
16499 <~scoped_switch_fork_info>: Fix incorrect variable name.
16501 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16503 * linux-fork.c (scoped_switch_fork_info)
16504 <scoped_switch_fork_info>: Make explicit.
16505 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16507 2019-01-10 Tom Tromey <tom@tromey.com>
16509 * objfiles.h (objfile::reset_psymtabs): Update.
16510 * objfiles.c (objfile::objfile): Update.
16511 * psymtab.h (psymtab_storage::obstack): Update.
16512 (psymtab_storage::m_obstack): Use gdb::optional.
16513 (class psymtab_storage): Update comment. Remove objfile
16515 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16517 2019-01-10 Tom Tromey <tom@tromey.com>
16519 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16520 <free_psymtabs>: Now private.
16521 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16522 (allocate_psymtab): Use new method.
16524 2019-01-10 Tom Tromey <tom@tromey.com>
16526 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16527 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16528 * mdebugread.c (parse_partial_symbols): Use
16529 allocate_dependencies.
16530 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16531 allocate_dependencies.
16532 (process_psymtab_comp_unit_reader)
16533 (build_type_psymtab_dependencies): Likewise.
16534 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16536 2019-01-10 Tom Tromey <tom@tromey.com>
16538 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16539 PSYMBOL_SET_LANGUAGE.
16540 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16542 2019-01-10 Tom Tromey <tom@tromey.com>
16544 * psymtab.h (psymtab_storage::obstack): New method.
16545 <m_obstack>: Rename from obstack; now private.
16546 * psymtab.c (psymtab_storage): Update.
16547 * dwarf2read.c (create_addrmap_from_index)
16548 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16551 2019-01-10 Tom Tromey <tom@tromey.com>
16553 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16554 * objfiles.h (objfile::reset_psymtabs): New method.
16556 2019-01-10 Tom Tromey <tom@tromey.com>
16558 * symmisc.c (print_symbol_bcache_statistics): Update.
16559 (print_objfile_statistics): Update.
16560 * symfile.c (reread_symbols): Update.
16561 * psymtab.h (class psymtab_storage): New.
16562 * psymtab.c (psymtab_storage): New constructor.
16563 (~psymtab_storage): New destructor.
16564 (require_partial_symbols): Update.
16565 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16566 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16567 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16568 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16569 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16570 (start_psymtab_common, end_psymtab_common)
16571 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16572 (allocate_psymtab): Update.
16573 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16575 (dump_psymtab_addrmap, maintenance_print_psymbols)
16576 (maintenance_check_psymtabs): Update.
16577 (class objfile_psymtabs): Move to objfiles.h.
16578 * psympriv.h (discard_psymtab): Now inline.
16579 (psymtab_discarder::psymtab_discarder): Update.
16580 (psymtab_discarder::~psymtab_discarder): Update.
16581 (ALL_OBJFILE_PSYMTABS): Rewrite.
16582 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16583 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16585 <partial_symtabs>: New field.
16586 (class objfile_psymtabs): Move from psymtab.h. Update.
16587 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16589 (objfile::~objfile): Don't destroy psymbol_cache.
16590 * mdebugread.c (parse_partial_symbols): Update.
16591 * dwarf2read.c (create_addrmap_from_index)
16592 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16593 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16594 (add_partial_subprogram, dwarf2_ranges_read): Update.
16595 * dwarf-index-write.c (write_address_map)
16596 (write_one_signatured_type, recursively_write_psymbols)
16597 (class debug_names, class debug_names, write_psymtabs_to_index):
16600 2019-01-10 Tom Tromey <tom@tromey.com>
16602 * symtab.h (SYMBOL_SET_NAMES): Update.
16603 (symbol_set_names): Update.
16604 (MSYMBOL_SET_NAMES): Update.
16605 * symtab.c (symbol_set_names): Change argument to be an
16606 objfile_per_bfd_storage.
16607 * psymtab.c (add_psymbol_to_bcache): Update.
16608 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16610 2019-01-10 Tom Tromey <tom@tromey.com>
16612 * symtab.c (create_demangled_names_hash): Change argument to be an
16613 objfile_per_bfd_storage.
16614 (symbol_set_names): Update.
16616 2019-01-10 Tom Tromey <tom@tromey.com>
16618 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16620 * psymtab.c (init_psymbol_list): Do nothing if already called.
16621 * psympriv.h (init_psymbol_list): Add comment.
16622 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16624 * dbxread.c (dbx_symfile_read): Unconditionally call
16627 2019-01-10 Tom Tromey <tom@tromey.com>
16629 * xcoffread.c (scan_xcoff_symtab): Update.
16630 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16632 * mdebugread.c (parse_partial_symbols)
16633 (handle_psymbol_enumerators): Update.
16634 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16635 * dbxread.c (read_dbx_symtab): Update.
16636 * psympriv.h (psymbol_placement): New enum.
16637 (add_psymbol_to_list): Update.
16639 2019-01-10 Tom Tromey <tom@tromey.com>
16641 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16642 static_psymbols parameters.
16643 (scan_xcoff_symtab): Update.
16644 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16645 static_psymbols parameters.
16646 * psympriv.h (start_psymtab_common): Update.
16647 * mdebugread.c (parse_partial_symbols): Update.
16648 * dwarf2read.c (create_partial_symtab): Update.
16649 * dbxread.c (read_dbx_symtab): Update.
16650 (start_psymtab): Remove global_psymbols and static_psymbols
16653 2019-01-10 Tom Tromey <tom@tromey.com>
16655 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16656 * psymtab.c (allocate_psymtab): Add comment.
16657 * psympriv.h (allocate_psymtab): Add comment.
16658 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16660 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16662 2019-01-10 Tom Tromey <tom@tromey.com>
16664 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16666 * mipsread.c: Include mdebugread.h.
16667 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16669 * elfread.c: Include mdebugread.h.
16671 2019-01-09 Tom Tromey <tom@tromey.com>
16673 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16674 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16675 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16676 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16677 (psym_lookup_symbol, psym_find_last_source_symtab)
16678 (psym_forget_cached_source_info, psym_print_stats)
16679 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16680 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16681 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16682 (psym_find_compunit_symtab_by_address)
16683 (maintenance_print_psymbols, maintenance_info_psymtabs)
16684 (maintenance_check_psymtabs): Use ranged for.
16685 * psymtab.h (class objfile_psymtabs): New.
16686 (require_partial_symbols): Return objfile_psymtabs.
16687 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16689 2019-01-09 Tom Tromey <tom@tromey.com>
16691 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16692 (find_pc_mapped_section, list_overlays_command)
16693 (map_overlay_command, unmap_overlay_command)
16694 (simple_overlay_update): Use all_objfiles.
16695 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16696 * printcmd.c (info_symbol_command): Use all_objfiles.
16697 * objfiles.h (ALL_OBJSECTIONS): Remove.
16698 * maint.c (maintenance_translate_address): Use all_objfiles.
16699 * gcore.c (gcore_create_callback): Use all_objfiles.
16700 (objfile_find_memory_regions): Likewise.
16702 2019-01-09 Tom Tromey <tom@tromey.com>
16704 * symtab.c (find_line_symtab, info_sources_command)
16705 (make_source_files_completion_list): Use objfile_compunits.
16706 * source.c (select_source_symtab): Use objfile_compunits.
16707 * objfiles.h (struct objfile): Update comment.
16708 (ALL_OBJFILES): Remove.
16709 (ALL_FILETABS): Remove.
16710 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16713 2019-01-09 Tom Tromey <tom@tromey.com>
16715 * symmisc.c (print_objfile_statistics, dump_objfile)
16716 (maintenance_print_symbols): Use compunit_filetabs.
16717 * source.c (forget_cached_source_info_for_objfile): Use
16719 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16720 (ALL_FILETABS): Use compunit_filetabs.
16721 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16722 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16724 2019-01-09 Tom Tromey <tom@tromey.com>
16726 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16727 (compunit_filetabs): New.
16728 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16730 (info_sources_command, make_source_files_completion_list): Remove
16732 * symmisc.c (print_objfile_statistics, dump_objfile)
16733 (maintenance_print_symbols): Remove declaration.
16734 (maintenance_info_symtabs): Use compunit_filetabs.
16735 (maintenance_info_line_tables): Likewise.
16736 * source.c (select_source_symtab): Change local variable name.
16737 (forget_cached_source_info_for_objfile): Remove declaration.
16738 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16739 * objfiles.c (objfile_relocate1): Remove declaration.
16740 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16742 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16743 * coffread.c (coff_symtab_read): Remove declaration.
16744 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16747 2019-01-09 Tom Tromey <tom@tromey.com>
16749 * symtab.c (lookup_objfile_from_block)
16750 (find_pc_sect_compunit_symtab, search_symbols)
16751 (default_collect_symbol_completion_matches_break_on): Use
16753 * objfiles.h (ALL_COMPUNITS): Remove.
16754 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16755 * cp-support.c (add_symbol_overload_list_qualified): Use
16757 * ada-lang.c (ada_collect_symbol_completion_matches)
16758 (ada_add_global_exceptions): Use objfile_compunits.
16760 2019-01-09 Tom Tromey <tom@tromey.com>
16762 * source.c (select_source_symtab)
16763 (forget_cached_source_info_for_objfile): Remove declaration.
16764 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16766 * maint.c (count_symtabs_and_blocks): Remove declaration.
16767 * cp-support.c (add_symbol_overload_list_qualified): Remove
16769 * coffread.c (coff_symtab_read): Remove declaration.
16770 * symtab.c (lookup_symbol_in_objfile_symtabs)
16771 (basic_lookup_transparent_type_1): Use objfile_compunits.
16772 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16773 (info_sources_command, search_symbols)
16774 (default_collect_symbol_completion_matches_break_on)
16775 (make_source_files_completion_list): Remove declaration.
16776 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16777 (ada_collect_symbol_completion_matches)
16778 (ada_add_global_exceptions): Remove declaration.
16779 * linespec.c (iterate_over_all_matching_symtabs): Use
16781 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16782 (class objfile_compunits): New.
16783 (ALL_COMPUNITS): Use objfile_compunits.
16784 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16785 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16787 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16789 2019-01-09 Tom Tromey <tom@tromey.com>
16791 * symtab.c (search_symbols)
16792 (default_collect_symbol_completion_matches_break_on): Use
16794 * ada-lang.c (ada_lookup_simple_minsym)
16795 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16796 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16797 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16799 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16800 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16801 * objc-lang.c (find_methods): Use objfile_msymbols.
16802 (info_selectors_command, info_classes_command): Likewise.
16803 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16804 * objfiles.h (class objfile_msymbols): New.
16805 (ALL_OBJFILE_MSYMBOLS): Remove.
16806 (ALL_MSYMBOLS): Remove.
16808 2019-01-09 Tom Tromey <tom@tromey.com>
16810 * common/next-iterator.h (next_adapter): Add Iterator template
16812 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16813 (class all_objfiles_safe): New.
16814 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16815 * objfiles.c (put_objfile_before): Update comment.
16816 (add_separate_debug_objfile): Likewise.
16817 (free_all_objfiles): Use all_objfiles_safe.
16818 (objfile_purge_solibs): Likewise.
16820 2019-01-09 Tom Tromey <tom@tromey.com>
16822 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16823 (expand_symtab_containing_pc, lookup_static_symbol)
16824 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16825 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16827 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16828 * breakpoint.c (create_overlay_event_breakpoint)
16829 (create_longjmp_master_breakpoint)
16830 (create_std_terminate_master_breakpoint)
16831 (create_exception_master_breakpoint): Use all_objfiles.
16832 * linux-thread-db.c (try_thread_db_load_from_pdir)
16833 (has_libpthread): Use all_objfiles.
16834 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16835 * linespec.c (iterate_over_all_matching_symtabs)
16836 (search_minsyms_for_name): Use all_objfiles.
16837 * maint.c (maintenance_info_sections): Use all_objfiles.
16838 * main.c (captured_main_1): Use all_objfiles.
16839 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16840 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16841 * guile/scm-pretty-print.c
16842 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16843 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16844 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16845 (maintenance_print_msymbols): Use all_objfiles.
16846 * source.c (select_source_symtab): Use all_objfiles.
16847 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16848 * symfile.c (remove_symbol_file_command)
16849 (expand_symtabs_matching, map_symbol_filenames): Use
16851 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16853 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16854 * objc-lang.c (find_methods): Use all_objfiles.
16855 * objfiles.c (have_partial_symbols, have_full_symbols)
16856 (have_minimal_symbols, qsort_cmp)
16857 (default_iterate_over_objfiles_in_search_order): Use
16859 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16860 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16861 (maintenance_check_psymtabs): Use all_objfiles.
16862 (ALL_PSYMTABS): Remove.
16863 * compile/compile-object-run.c (do_module_cleanup): Use
16865 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16866 * cp-support.c (add_symbol_overload_list_qualified): Use
16868 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16870 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16871 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16873 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16874 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16875 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16877 * solib.c (solib_read_symbols): Use all_objfiles
16879 2019-01-09 Tom Tromey <tom@tromey.com>
16881 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16882 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16884 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16885 * symmisc.c (print_symbol_bcache_statistics)
16886 (print_objfile_statistics, maintenance_print_objfiles)
16887 (maintenance_info_symtabs, maintenance_check_symtabs)
16888 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16890 * source.c (forget_cached_source_info): Use all_objfiles.
16891 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16892 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16893 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16894 * objfiles.c (update_section_map): Use all_objfiles.
16895 (shared_objfile_contains_address_p): Likewise.
16896 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16897 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16899 2019-01-09 Tom Tromey <tom@tromey.com>
16901 * common/next-iterator.h: New file.
16902 * objfiles.h (class all_objfiles): New.
16903 (struct objfile_iterator): New.
16905 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16907 * NEWS: Move the description of the changed "frame", "select-frame",
16908 and "info frame" commands to the Changed commands section.
16910 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16912 * gdbtypes.c (check_stub_method_group): Remove handling of old
16914 * linespec.c (find_methods): Likewise.
16915 * stabsread.c (read_member_functions): Likewise.
16916 * valops.c (search_struct_method): Likewise.
16917 (value_struct_elt_for_reference): Likewise.
16918 * NEWS: Mention this change.
16920 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16922 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16923 print_source_lines.
16924 * source.c (print_source_lines_base): Update line number check.
16925 (print_source_lines): New function.
16926 (source_lines_range::source_lines_range): New function.
16927 * source.h (class source_lines_range): New class.
16928 (print_source_lines): New declaration.
16930 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16932 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16934 2019-01-08 Tom Tromey <tom@tromey.com>
16935 Simon Marchi <simon.marchi@ericsson.com>
16938 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16939 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16940 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16941 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16942 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16943 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16945 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16947 * source.c (select_source_symtab): Move header comment to
16948 declaration in source.h.
16949 (forget_cached_source_info_for_objfile): Likewise.
16950 (forget_cached_source_info): Likewise.
16951 (identify_source_line): Likewise.
16952 * source.h (identify_source_line): Move declaration from symtab.h
16953 and add comment from source.c
16954 (print_source_lines): Likewise.
16955 (forget_cached_source_info_for_objfile): Likewise.
16956 (forget_cached_source_info): Likewise.
16957 (select_source_symtab): Likewise.
16958 (enum print_source_lines_flag): Move definition from symtab.h.
16959 * symtab.h (identify_source_line): Move declaration to source.h.
16960 (print_source_lines): Likewise.
16961 (forget_cached_source_info_for_objfile): Likewise.
16962 (forget_cached_source_info): Likewise.
16963 (select_source_symtab): Likewise.
16964 (enum print_source_lines_flag): Move definition to source.h.
16965 * tui/tui-hooks.c: Add 'source.h' include.
16967 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16969 * source.c (print_source_lines_base): Handle requests to print
16970 reverse line number sequences, and guard against empty lines
16973 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16975 * source.c (print_source_lines_base): Fix skip of '\r' if next
16978 2019-01-06 Tom Tromey <tom@tromey.com>
16980 * c-exp.y (struct c_parse_state) <macro_original_text,
16981 expansion_obstack>: New member.
16982 (macro_original_text, expansion_obstack): Remove globals.
16983 (scan_macro_expansion, scanning_macro_expansion)
16984 (finished_macro_expansion): Update.
16985 (scan_macro_cleanup): Remove.
16986 (yylex, c_parse): Update.
16988 2019-01-06 Tom Tromey <tom@tromey.com>
16990 * c-exp.y (struct c_parse_state) <strings>: New member.
16991 (operator_stoken): Update.
16993 2019-01-06 Tom Tromey <tom@tromey.com>
16995 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16996 (union type_stack_elt) <typelist_val>: Now a pointer to
16998 (type_stack_cleanup): Don't declare.
16999 (push_typelist): Update.
17000 * parse.c (pop_typelist): Return a std::vector.
17001 (push_typelist): Take a std::vector.
17002 (follow_types): Update. Do not free args.
17003 (type_stack_cleanup): Remove.
17004 * c-exp.y (struct c_parse_state): New.
17005 (cpstate): New global.
17006 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
17007 (nonempty_typelist): Update.
17008 (func_mod): Create a new vector.
17009 (c_parse): Create a c_parse_state.
17010 (check_parameter_typelist): Do not delete params.
17011 (function_method): Update. Do not delete type_list.
17013 2019-01-06 Tom Tromey <tom@tromey.com>
17016 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
17018 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
17019 (print_return_value): Likewise.
17021 2019-01-05 Tom Tromey <tom@tromey.com>
17023 * contrib/cleanup_check.py: Remove.
17024 * contrib/gcc-with-excheck: Remove.
17025 * contrib/exsummary.py: Remove.
17026 * contrib/excheck.py: Remove.
17028 2019-01-05 Joel Brobecker <brobecker@adacore.com>
17030 * thread.c (delete_thread_1): Add gdb_assert that THR is not
17031 NULL. Initialize tpprev to NULL instead of assigning it
17032 to NULL on the next statement.
17033 * windows-nat.c (windows_delete_thread): Remove check for
17034 main_thread_id before printing thread exit notifications.
17035 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17036 Remove thread ID check against main_thread_id.
17037 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17038 windows_delete_thread.
17039 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17041 2019-01-04 Tom Tromey <tom@tromey.com>
17043 * compile/compile.c (_initialize_compile): Use upper case for
17044 metasyntactic variables.
17045 * symmisc.c (_initialize_symmisc): Use upper case for
17046 metasyntactic variables.
17047 * psymtab.c (_initialize_psymtab): Use upper case for
17048 metasyntactic variables.
17049 * demangle.c (demangle_command): Use upper case for metasyntactic
17051 (_initialize_demangler): Likewise.
17052 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17055 2019-01-03 Tom Tromey <tom@tromey.com>
17057 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17059 2019-01-03 Tom Tromey <tom@tromey.com>
17061 * python/py-symtab.c (salpy_str): Update.
17062 (struct salpy_sal_object) <symtab>: Now a PyObject.
17063 (salpy_dealloc): Update.
17064 (del_objfile_sal): Use gdbpy_ref.
17066 2019-01-03 Tom Tromey <tom@tromey.com>
17068 * python/py-type.c (convert_field): Use new_reference. Return
17070 (make_fielditem): Return gdbpy_ref.
17071 (typy_fields): Update.
17072 (typy_getitem): Update.
17073 (field_name): Return gdbpy_ref. Use new_reference.
17074 (typy_iterator_iternext): Update.
17076 2019-01-03 Tom Tromey <tom@tromey.com>
17078 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17080 2019-01-03 Tom Tromey <tom@tromey.com>
17082 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17083 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17084 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17085 (pspy_set_frame_filters, pspy_set_frame_unwinders)
17086 (pspy_set_type_printers): Likewise.
17087 * python/py-function.c (fnpy_init): Use gdbpy_ref.
17088 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17089 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17090 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17091 (objfpy_set_type_printers): Likewise.
17093 2019-01-03 Tom Tromey <tom@tromey.com>
17095 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17096 (gdbpy_print_stack): Use gdbpy_err_fetch.
17097 * python/python-internal.h (class gdbpy_err_fetch): New class.
17098 (class gdbpy_enter) <m_error_type, m_error_value,
17099 m_error_traceback>: Remove.
17100 <m_error>: New member.
17101 (gdbpy_exception_to_string): Don't declare.
17102 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17103 * python/py-value.c (convert_value_from_python): Use
17105 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17106 gdbpy_exception_to_string.
17107 (gdbpy_handle_exception): Use gdbpy_err_fetch.
17108 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17111 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17113 * linux-nat.c (delete_lwp_cleanup): Delete.
17114 (struct lwp_deleter): New struct.
17115 (lwp_info_up): New typedef.
17116 (linux_nat_target::follow_fork): Delete cleanup, and make use of
17119 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17121 * linux-fork.c (class scoped_switch_fork_info): New class.
17122 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17124 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17126 * valops.c (find_overload_match): Remove use of null_cleanup, and
17127 calls to do_cleanups.
17129 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17131 * compile/compile-cplus-types.c
17132 (compile_cplus_instance::decl_name): Handle changes to
17134 * cp-support.c (cp_func_name): Update header comment, update
17136 * cp-support.h (cp_func_name): Update return type in declaration.
17137 * valops.c (find_overload_match): Move temp_func local to top
17138 level of function and change its type. Use temp_func to hold and
17139 delete temporary string obtained from cp_func_name.
17141 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17143 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17144 gdb::char_vector, remove cleanup, and update uses of `msg`.
17146 2019-01-03 Jim Wilson <jimw@sifive.com>
17148 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17150 2019-01-02 Tom Tromey <tom@tromey.com>
17152 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17153 (tdesc_parse_xml): Remove cleanups.
17154 * target-descriptions.h (make_cleanup_free_target_description):
17156 (target_desc_deleter): New struct.
17157 (target_desc_up): New typedef.
17158 * target-descriptions.c (target_desc_deleter::operator()): Rename
17159 from free_target_description.
17160 (make_cleanup_free_target_description): Remove.
17162 2019-01-02 Tom Tromey <tom@tromey.com>
17164 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17165 constructor, destructor.
17166 (linespec_parser): Remove typedef.
17167 (~linespec_parser): Rename from linespec_parser_delete.
17168 (linespec_lex_to_end, linespec_complete_label)
17169 (linespec_complete): Update.
17170 (decode_line_full): Remove cleanups.
17171 (decode_line_1): Update.
17173 2019-01-02 Tom Tromey <tom@tromey.com>
17175 * python/python-internal.h (inferior_to_inferior_object): Change
17177 * python/py-exitedevent.c (create_exited_event_object): Update.
17178 * python/py-inferior.c (inferior_to_inferior_object): Return
17180 (python_new_inferior, python_inferior_deleted)
17181 (thread_to_thread_object, delete_thread_object)
17182 (build_inferior_list, gdbpy_selected_inferior): Update.
17183 * python/py-infthread.c (create_thread_object): Update. Also fail
17184 if inferior_to_inferior_object fails.
17186 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17188 * inferior.h (class inferior) <displaced_step_state>: New field.
17189 * infrun.h (struct displaced_step_state): Move here from
17190 infrun.c. Initialize fields, add constructor.
17191 <inf>: Remove field.
17192 <reset>: New method.
17193 * infrun.c (struct displaced_step_inferior_state): Move to
17195 (displaced_step_inferior_states): Remove.
17196 (get_displaced_stepping_state): Adust.
17197 (displaced_step_in_progress_any_inferior): Adjust.
17198 (displaced_step_in_progress_thread): Adjust.
17199 (displaced_step_in_progress): Adjust.
17200 (add_displaced_stepping_state): Remove.
17201 (get_displaced_step_closure_by_addr): Adjust.
17202 (remove_displaced_stepping_state): Remove.
17203 (infrun_inferior_exit): Call displaced_step_state.reset.
17204 (use_displaced_stepping): Don't check for NULL.
17205 (displaced_step_prepare_throw): Call
17206 get_displaced_stepping_state.
17207 (displaced_step_fixup): Don't check for NULL.
17208 (prepare_for_detach): Don't check for NULL.
17210 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17212 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17213 in case of call that did not complete.
17215 2019-01-02 Andrey Utkin <autkin@undo.io>
17217 * symfile.c (find_separate_debug_file): Fix search of debug files for
17220 2019-01-02 Tom Tromey <tom@tromey.com>
17222 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17224 * python/py-frame.c (frapy_older): Remove cast.
17225 (frapy_newer): Likewise.
17226 * python/py-breakpoint.c (local_setattro): Remove cast.
17227 * python/py-arch.c (archpy_name): Remove local variable.
17228 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17230 2019-01-02 Joel Brobecker <brobecker@adacore.com>
17232 * unittests/basic_string_view/element_access/char/empty.cc:
17233 Fix year range in copyright header.
17235 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17237 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17239 <operator==>: Update with for removed field.
17241 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17242 <isa_features>: ...this.
17243 <abi_features>: New field.
17244 (riscv_isa_flen): Update comment.
17245 (riscv_abi_xlen): New declaration.
17246 (riscv_abi_flen): New declaration.
17247 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17249 (riscv_abi_xlen): New function.
17250 (riscv_isa_flen): Update to get answer from isa_features.
17251 (riscv_abi_flen): New function.
17252 (riscv_has_fp_abi): Update to get answer from abi_features.
17253 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17255 (riscv_call_info) <xlen, flen>: Update comment.
17256 (riscv_call_arg_struct): Remove invalid assertions
17257 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17259 (riscv_gdbarch_init): Gather isa features and abi features
17260 separately, ensure both match on the gdbarch when reusing an old
17261 gdbarch. Relax an error check to allow 32-bit abi float to run on
17262 a target with 64-bit float hardware.
17264 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17266 * source.c (search_command_helper): Stop reverse search
17267 when line 1 has been searched.
17269 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17271 * record-full.c (record_full_base_target::close): Rewrite
17272 record_full_core_buf_list free logic.
17274 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17276 * break-catch-syscall.c (print_one_catch_syscall): xfree
17279 2019-01-01 Joel Brobecker <brobecker@adacore.com>
17281 * top.c (print_gdb_version): Update Copyright year in version
17284 2019-01-01 Joel Brobecker <brobecker@adacore.com>
17286 Update copyright year range in all GDB files.
17288 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
17290 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17292 For older changes see ChangeLog-2018.
17298 version-control: never