gdb/ChangeLog

   1 2019-07-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * mi/mi-main.c (list_available_thread_groups): Use field_string.
   4         * mi/mi-interp.c (mi_memory_changed): Use field_string.
   5         * target.c (flash_erase_command): Use field_string.
   6         * infrun.c (print_signal_received_reason): Use field_string.
   7         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
   8         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
   9         field_string.
  10         * ada-tasks.c (print_ada_task_info): Use field_string.
  11
  12 2019-07-15  Tom Tromey  <tromey@adacore.com>
  13
  14         * target.c (flash_erase_command): Use field_core_addr.
  15         * symfile.c (generic_load): Use field_core_addr.
  16         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
  17         Use field_core_addr.
  18         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
  19         field_core_addr.
  20
  21 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  22
  23         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
  24         value if its desired type is smaller than a CORE_ADDR and signed.
  25
  26 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
  29         of changes to field names, and use new is_reference field to
  30         decide if a property is a reference or not.
  31         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
  32         field.
  33         (struct dwarf2_property_baton): Update header comment, rename
  34         'referenced_type' to 'property_type' and update comments.
  35         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
  36         default property type, store in property baton, update to take
  37         accound of renamed field.
  38         (read_func_scope): Update call to attr_to_dynamic_prop.
  39         (read_array_type): Likewise.
  40         (dwarf2_per_cu_addr_sized_int_type): New function.
  41         (read_subrange_index_type): Move type finding code to
  42         dwarf2_per_cu_addr_sized_int_type.
  43         (read_subrange_type): Update calls to attr_to_dynamic_prop.
  44         (dwarf2_per_cu_addr_type): New function.
  45         (set_die_type): Update calls to attr_to_dynamic_prop.
  46
  47 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * dwarf2read.c (read_subrange_index_type): New function.
  50         (read_subrange_type): Move code into new function and call it.
  51         * gdbtypes.c (create_range_type): Add some asserts.
  52
  53 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  54
  55         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
  56         update return statements.
  57         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
  58         declaration, and update comment to match.
  59         * gdbtypes.c (resolve_dynamic_array): Update call to
  60         dwarf2_evaluate_property to match new return type.
  61
  62 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  63
  64         * valarith.c (value_subscripted_rvalue): Change lowerbound
  65         parameter type from int to LONGEST.
  66         * value.h (value_subscripted_rvalue): Likewise in declaration.
  67
  68 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  69
  70         * cli/cli-utils.c (info_print_command_completer): New function.
  71         * cli/cli-utils.h: Add 'completer.h' include, and forward
  72         declaration for 'struct cmd_list_element'.
  73         (info_print_command_completer): Declare.
  74         * stack.c (_initialize_stack): Add completer for 'info locals' and
  75         'info args'.
  76         * symtab.c (_initialize_symtab): Add completer for 'info
  77         variables' and 'info functions'.
  78         * NEWS: Mention completion for additional info commands.
  79
  80 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  81
  82         * cli/cli-utils.c (extract_info_print_args): Delete.
  83         (extract_arg_maybe_quoted): Delete.
  84         (info_print_options_defs): New variable.
  85         (make_info_print_options_def_group): New function.
  86         (extract_info_print_options): Define new function.
  87         * cli/cli-utils.h (extract_info_print_args): Delete.
  88         (struct info_print_options): New structure.
  89         (extract_info_print_options): Declare new function.
  90         * stack.c (info_locals_command): Update to use new
  91         extract_info_print_options, also add a header comment.
  92         (info_args_command): Likewise.
  93         * symtab.c (info_variables_command): Likewise.
  94         (info_functions_command): Likewise.
  95
  96 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  97
  98         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
  99         to extract string arguments.
 100         * common/common-utils.c (extract_string_maybe_quoted): New function.
 101         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 102
 103 2019-07-11  Tom Tromey  <tromey@adacore.com>
 104
 105         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 106         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 107         * top.h (gdbinit): Don't declare.
 108         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 109         into...
 110         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 111         * top.c (gdb_init): Don't call init_cli_cmds.
 112         (gdbinit): Remove.
 113         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 114
 115 2019-07-11  Tom Tromey  <tromey@adacore.com>
 116
 117         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 118         after it has been moved.
 119
 120 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 121
 122         * valops.c (value_must_coerce_to_target): Change return type to
 123         bool.
 124         * value.h (value_must_coerce_to_target): Likewise.
 125
 126 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 127
 128         * breakpoint.c (is_hardware_watchpoint): Remove
 129         forward-declaration.
 130         (is_masked_watchpoint): Change return type to bool.
 131         (is_tracepoint): Likewise.
 132         (is_breakpoint): Likewise.
 133         (is_hardware_watchpoint): Likewise.
 134         (is_watchpoint): Likewise.
 135         (is_no_memory_software_watchpoint): Likewise.
 136         (is_catchpoint): Likewise.
 137         (breakpoint_1): Make FILTER parameter's return type bool.
 138         is_masked_watchpoint): Change return type to bool.
 139         (save_breakpoints): Make FILTER parameter's return type bool.
 140         * breakpoint.h (is_breakpoint): Change return type to bool.
 141         (is_watchpoint): Likewise.
 142         (is_catchpoint): Likewise.
 143         (is_tracepoint): Likewise.
 144
 145 2019-07-10  Tom Tromey  <tom@tromey.com>
 146
 147         * defs.h: Don't include gdbarch.h.
 148         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 149         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 150         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 151         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 152         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 153         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 154         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 155         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 156         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 157         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 158         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 159         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 160         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 161         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 162         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 163         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 164         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 165         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 166         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 167         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 168         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 169         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 170         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 171         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 172         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 173         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 174         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 175
 176 2019-07-10  Tom Tromey  <tromey@adacore.com>
 177
 178         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 179         * breakpoint.c (init_ada_exception_breakpoint): Register as
 180         bp_catchpoint.
 181         (print_one_breakpoint_location, print_one_breakpoint): Use
 182         is_ada_exception_catchpoint.
 183         * ada-lang.c (class ada_catchpoint_location): Pass
 184         bp_loc_software_breakpoint to bp_location constructor.
 185         (is_ada_exception_catchpoint): New function.
 186
 187 2019-07-10  Tom Tromey  <tromey@adacore.com>
 188
 189         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 190         VEC.
 191         (struct arm_exidx_entry): New method operator<.
 192         (struct arm_exidx_data) <section_maps>: Change type.
 193         (arm_exidx_data_free): Remove.
 194         (arm_exidx_data_key): Change type.  Move lower.
 195         (arm_exidx_new_objfile): Update.
 196         (arm_compare_exidx_entries): Remove.
 197         (arm_find_exidx_entry, _initialize_arm_tdep)
 198
 199 2019-07-10  Tom Tromey  <tromey@adacore.com>
 200
 201         * solib-spu.c (ocl_program_data_key): Change type.
 202         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 203         Update.
 204
 205 2019-07-10  Tom Tromey  <tromey@adacore.com>
 206
 207         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 208         (struct solib_aix_inferior_data) <library_list>: Change type.
 209         (solib_aix_inferior_data_handle): Change type.
 210         (get_solib_aix_inferior_data): Update.
 211         (solib_aix_free_library_list): Remove.
 212         (library_list_start_library): Update.
 213         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 214         return type.
 215         (solib_aix_get_library_list)
 216         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 217         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 218
 219 2019-07-10  Tom Tromey  <tromey@adacore.com>
 220
 221         * solib-dsbt.c (struct dsbt_info): Add initializers.
 222         (solib_dsbt_pspace_data): Change type.
 223         (dsbt_pspace_data_cleanup): Remove.
 224         (get_dsbt_info, _initialize_dsbt_solib): Update.
 225
 226 2019-07-10  Tom Tromey  <tromey@adacore.com>
 227
 228         * spu-tdep.c (spu_overlay_data): Change type.
 229         (spu_get_overlay_table, spu_overlay_new_objfile)
 230         (_initialize_spu_tdep): Update.
 231
 232 2019-07-10  Tom Tromey  <tromey@adacore.com>
 233
 234         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 235         destructor.
 236         (dbx_objfile_data_key): Change type and declare later.
 237         (DBX_SYMFILE_INFO): Rewrite.
 238         * dbxread.c (dbx_objfile_data_key): Change type.
 239         (dbx_symfile_init): Update.
 240         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 241         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 242         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 243
 244 2019-07-10  Tom Tromey  <tromey@adacore.com>
 245
 246         * jit.c (jit_program_space_key): Change type.  Move lower.
 247         (get_jit_program_space_data): Update.
 248         (jit_program_space_data_cleanup): Remove.
 249         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 250         Update.
 251         (struct jit_program_space_data): Add initializers.
 252
 253 2019-07-10  Tom Tromey  <tromey@adacore.com>
 254
 255         * solib-darwin.c (struct darwin_info): Add initializers.
 256         (solib_darwin_pspace_data): Change type.
 257         (darwin_pspace_data_cleanup): Remove.
 258         (get_darwin_info, _initialize_darwin_solib): Update.
 259
 260 2019-07-10  Tom Tromey  <tromey@adacore.com>
 261
 262         * remote-sim.c (struct sim_inferior_data): Add initializers,
 263         constructor, and destructor.
 264         (sim_inferior_data_key): Change type.  Move lower.
 265         (check_for_duplicate_sim_descriptor): Update.
 266         (get_sim_inferior_data): Use new.  Update.
 267         (~sim_inferior_data_cleanup): Rename from
 268         sim_inferior_data_cleanup.  Simplify.
 269         (gdbsim_close_inferior, simulator_command)
 270         (sim_command_completer, _initialize_remote_sim): Update.
 271         (next_pid, INITIAL_PID): Move earlier.
 272
 273 2019-07-10  Tom Tromey  <tromey@adacore.com>
 274
 275         * python/python-internal.h (create_thread_object): Return
 276         gdbpy_ref.
 277         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 278         * python/py-inferior.c (struct threadlist_entry): Add
 279         constructor.
 280         <thread_obj>: Now a gdbpy_ref.
 281         (thread_to_thread_object): Update.
 282         (add_thread_object): Use new.
 283         (delete_thread_object): Use delete.
 284         (infpy_threads): Update.
 285         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 286         GIL.
 287
 288 2019-07-10  Tom Tromey  <tromey@adacore.com>
 289
 290         * valops.c (value_cast): Specialize error message for Ada.
 291
 292 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 293
 294         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 295
 296 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 297
 298         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 299         bpstat_should_step): Return bool, adjust comments.
 300         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 301         bpstat_should_step): Likewise.
 302
 303 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 304
 305         * features/Makefile: Use feature target descriptions for Arm.
 306         * features/arm/arm-core.c: Generate new file.
 307         * features/arm/arm-fpa.c: Likewise.
 308         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 309         * features/arm/arm-m-profile.c: Likewise.
 310         * features/arm/arm-vfpv2.c: Likewise.
 311         * features/arm/arm-vfpv3.c: Likewise.
 312         * features/arm/xscale-iwmmxt.c: Likewise.
 313         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 314
 315 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 316
 317         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 318         ptrace earlier.
 319
 320 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 321
 322         * features/aarch64-pauth.c: Regenerate.
 323
 324 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 325
 326         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 327         bool.
 328         (bpstat_what): Use false instead of 0.
 329
 330 2019-07-09  Pedro Alves  <palves@redhat.com>
 331
 332         * break-catch-throw.c (is_exception_catchpoint): New.
 333         * breakpoint.c (print_one_breakpoint_location): New parameter
 334         'raw_loc'.  Handle it.  Use
 335         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 336         looking at the breakpoint's type.
 337         (print_one_breakpoint): If handling "maint info breakpoints", also
 338         print locations of exception catchpoints.
 339         * breakpoint.h (is_exception_catchpoint): Declare.
 340
 341 2019-07-09  Pedro Alves  <palves@redhat.com>
 342
 343         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 344         "addr" field.
 345         (allocate_location_exception_catchpoint): New.
 346         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 347         (initialize_throw_catchpoint_ops): Install
 348         allocate_location_exception_catchpoint as allocate_location
 349         method.
 350         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 351         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 352         bp_loc_other.
 353         (breakpoint_address_is_meaningful): Delete.
 354         (bl_address_is_meaningful): New.
 355         (breakpoint_locations_match): Adjust comment.
 356         (bp_location_from_bp_type): New, factored out of...
 357         (bp_location::bp_location(breakpoint *)): ... this.
 358         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 359         factored out of...
 360         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 361         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 362         breakpoint_address_is_meaningful.
 363         (bp_locations_compare): Adjust comment.
 364         (update_global_location_list): Use bl_address_is_meaningful
 365         instead of breakpoint_address_is_meaningful.
 366         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 367         explicit.
 368         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 369         * python/py-breakpoint.c (bppy_get_location): No longer check
 370         whether location is null.
 371
 372 2019-07-09  Pedro Alves  <palves@redhat.com>
 373
 374         PR c++/15468
 375         * breakpoint.c (print_one_breakpoint_location): Remove
 376         single-location assert.
 377
 378 2019-07-09  Tom Tromey  <tom@tromey.com>
 379
 380         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 381         * configure: Rebuild.
 382         * configure.ac: Change common to gdbsupport.
 383         * gdbsupport: Rename from common.
 384         * acinclude.m4: Change common to gdbsupport.
 385         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 386         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 387         gdbsupport.
 388         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 389         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 390         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 391         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 392         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 393         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 394         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 395         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 396         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 397         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 398         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 399         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 400         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 401         coff-pe-read.c, command.h, compile/compile-c-support.c,
 402         compile/compile-c.h, compile/compile-cplus-symbols.c,
 403         compile/compile-cplus-types.c, compile/compile-cplus.h,
 404         compile/compile-loc2c.c, compile/compile.c, completer.c,
 405         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 406         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 407         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 408         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 409         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 410         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 411         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 412         features/aarch64-core.c, features/aarch64-fpu.c,
 413         features/aarch64-pauth.c, features/aarch64-sve.c,
 414         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 415         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 416         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 417         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 418         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 419         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 420         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 421         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 422         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 423         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 424         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 425         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 426         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 427         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 428         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 429         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 430         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 431         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 432         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 433         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 434         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 435         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 436         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 437         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 438         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 439         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 440         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 441         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 442         minsyms.c, mips-linux-tdep.c, namespace.h,
 443         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 444         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 445         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 446         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 447         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 448         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 449         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 450         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 451         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 452         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 453         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 454         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 455         procfs.c, producer.c, progspace.h, psymtab.h,
 456         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 457         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 458         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 459         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 460         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 461         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 462         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 463         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 464         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 465         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 466         target-memory.c, target.c, target.h, target/waitstatus.c,
 467         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 468         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 469         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 470         unittests/array-view-selftests.c,
 471         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 472         unittests/common-utils-selftests.c,
 473         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 474         unittests/format_pieces-selftests.c,
 475         unittests/function-view-selftests.c,
 476         unittests/lookup_name_info-selftests.c,
 477         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 478         unittests/mkdir-recursive-selftests.c,
 479         unittests/observable-selftests.c,
 480         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 481         unittests/parse-connection-spec-selftests.c,
 482         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 483         unittests/scoped_fd-selftests.c,
 484         unittests/scoped_mmap-selftests.c,
 485         unittests/scoped_restore-selftests.c,
 486         unittests/string_view-selftests.c, unittests/style-selftests.c,
 487         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 488         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 489         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 490         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 491         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 492         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 493
 494 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 495
 496         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 497         bool value.
 498         (decode_digits_ordinary): Set explicit_line field in sal.
 499         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 500         symtab_and_line that was set on an explicit line number in
 501         assembler code.  Do always update the recorded symtab and line if
 502         we do skip the prologue.
 503
 504 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * breakpoint.c (set_breakpoint_location_function): Remove
 507         explicit_loc parameter.
 508         (momentary_breakpoint_from_master): Update call to
 509         set_breakpoint_location_function.
 510         (add_location_to_breakpoint): Likewise.
 511
 512 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 513
 514         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 515         required features based on default bfd type when no specific bfd
 516         is present.
 517
 518 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 519
 520         * NEWS: Mention that GDB printf and eval commands can now print
 521         C-style and Ada-style convenience var strings without
 522         calling the inferior.
 523         * printcmd.c (printf_c_string): Locally print GDB internal var
 524         instead of transiting via the inferior.
 525         (printf_wide_c_string): Likewise.
 526
 527 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 528
 529         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 530
 531 2019-07-04  Tom Tromey  <tom@tromey.com>
 532
 533         PR tui/24724:
 534         * tui/tui-winsource.c (tui_clear_source_content): Update.
 535         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 536         (tui_update_breakpoint_info): Update.
 537         (tui_set_exec_info_content): Update.
 538         * tui/tui-source.c (tui_set_source_content_nil): Update.
 539         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 540         has_break.
 541         * tui/tui-data.h (enum tui_bp_flag): New.
 542         (tui_bp_flags): New enum flags type.
 543         (struct tui_source_element) <break_mode>: Change type.  Rename
 544         from has_break.
 545         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 546         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 547         constants.
 548         * tui/tui-winsource.h: Fix comment.
 549
 550 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 551
 552         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 553         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 554         (store_fpregs_to_thread)
 555         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 556         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 557         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 558         (IWMMXT_REGS_SIZE): Add define.
 559         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 560         (fetch_vfp_regs, store_vfp_regs)
 561         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 562         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 563
 564 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 565
 566         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 567         defines.
 568         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 569         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 570         (ARM_INT_REGISTER_SIZE): ...to this.
 571         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 572         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 573         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 574         (arm_linux_collect_gregset, supply_nwfpe_register)
 575         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 576         defines.
 577         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 578         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 579         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 580         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 581         (arm_return_in_memory, arm_store_return_value)
 582         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 583         (arm_record_ld_st_multiple): Likewise.
 584         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 585         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 586
 587 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 588
 589         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 590         AARCH64_DISPLACED_MODIFIED_INSNS.
 591         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 592         (aarch64_displaced_step_copy_insn): Likewise.
 593         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 594         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 595         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 596         ARM_DISPLACED_MODIFIED_INSNS.
 597         * arm-tdep.c (arm_gdbarch_init): Likewise.
 598         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 599         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 600         (struct arm_displaced_step_closure): Use
 601         ARM_DISPLACED_MODIFIED_INSNS.
 602
 603 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 604
 605         * features/Makefile: Remove unused xml files.
 606         * features/aarch64.xml: Remove.
 607         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 608         * features/i386/amd64-avx-avx512.xml: Remove.
 609         * features/i386/amd64-avx-linux.xml: Remove.
 610         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 611         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 612         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 613         * features/i386/amd64-avx-mpx.xml: Remove.
 614         * features/i386/amd64-avx.xml: Remove.
 615         * features/i386/amd64-linux.xml: Remove.
 616         * features/i386/amd64-mpx-linux.xml: Remove.
 617         * features/i386/amd64-mpx.xml: Remove.
 618         * features/i386/amd64.xml: Remove.
 619         * features/i386/i386-avx-avx512-linux.xml: Remove.
 620         * features/i386/i386-avx-avx512.xml: Remove.
 621         * features/i386/i386-avx-linux.xml: Remove.
 622         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 623         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 624         * features/i386/i386-avx-mpx-linux.xml: Remove.
 625         * features/i386/i386-avx-mpx.xml: Remove.
 626         * features/i386/i386-avx.xml: Remove.
 627         * features/i386/i386-linux.xml: Remove.
 628         * features/i386/i386-mmx-linux.xml: Remove.
 629         * features/i386/i386-mmx.xml: Remove.
 630         * features/i386/i386-mpx-linux.xml: Remove.
 631         * features/i386/i386-mpx.xml: Remove.
 632         * features/i386/i386.xml: Remove.
 633         * features/i386/x32-avx-avx512-linux.xml: Remove.
 634         * features/i386/x32-avx-linux.xml: Remove.
 635         * features/i386/x32-linux.xml: Remove.
 636
 637 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 638
 639         * regformats/aarch64.dat: Remove.
 640         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 641         * regformats/i386/amd64-avx-linux.dat: Remove.
 642         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 643         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 644         * regformats/i386/amd64-linux.dat: Remove.
 645         * regformats/i386/amd64-mpx-linux.dat: Remove.
 646         * regformats/i386/amd64.dat: Remove.
 647         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 648         * regformats/i386/i386-avx-linux.dat: Remove.
 649         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 650         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 651         * regformats/i386/i386-linux.dat: Remove.
 652         * regformats/i386/i386-mmx-linux.dat: Remove.
 653         * regformats/i386/i386-mpx-linux.dat: Remove.
 654         * regformats/i386/i386.dat: Remove.
 655         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 656         * regformats/i386/x32-avx-linux.dat: Remove.
 657         * regformats/i386/x32-linux.dat: Remove.
 658
 659 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 660
 661         * aarch64-tdep.c: Remove xml self tests.
 662         * amd64-linux-tdep.c: Likewise.
 663         * amd64-tdep.c: Likewise.
 664         * i386-linux-tdep.c: Likewise.
 665         * i386-tdep.c: Likewise.
 666
 667 2019-07-03  Pedro Alves  <palves@redhat.com>
 668
 669         PR cli/24732
 670         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 671         (pipe_cmd_option_defs): New.
 672         (make_pipe_cmd_options_def_group): New.
 673         (pipe_command): Use gdb::option::process_options.
 674         (pipe_command_completer): New function.
 675         (_initialize_cli_cmds): Install completer for "pipe" command.
 676
 677 2019-07-03  Pedro Alves  <palves@redhat.com>
 678
 679         * cli/cli-option.c (union option_value) <string>: New field.
 680         (struct option_def_and_value): Add ctor, move ctor, dtor and
 681         use DISABLE_COPY_AND_ASSIGN.
 682         (option_def_and_value::clear_value): New.
 683         (parse_option, save_option_value_in_ctx, get_val_type_str)
 684         (add_setshow_cmds_for_options): Handle var_string.
 685         * cli-option.h (union option_def::var_address) <string>: New
 686         field.
 687         (struct string_option_def): New.
 688         * maint-test-options.c (struct test_options_opts): Add default
 689         ctor and use DISABLE_COPY_AND_ASSIGN.
 690         <string_opt>: New field.
 691         (test_options_opts::~test_options_opts): New.
 692         (test_options_opts::dump): Also dump "-string".
 693         (test_options_option_defs): Install "string.
 694
 695 2019-07-03  Pedro Alves  <palves@redhat.com>
 696
 697         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 698         option_value with a null enumeration.
 699         (complete_options): Save the option values in the context.
 700         (save_option_value_in_ctx): New, factored out from ...
 701         (process_options): ... here.
 702         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 703         of the function.
 704         * maint-test-options.c (test_options_opts::dump): New, factored
 705         out from ...
 706         (maintenance_test_options_command_mode): ... here.
 707         (maintenance_test_options_command_completion_result): Delete.
 708         (maintenance_test_options_command_completion_text): Update
 709         comment.
 710         (maintenance_show_test_options_completion_result): Change
 711         prototype.  Just print
 712         maintenance_test_options_command_completion_text.
 713         (save_completion_result): New.
 714         (maintenance_test_options_completer_mode): Pass options context to
 715         complete_options, and then save a dump.
 716         (_initialize_maint_test_options): Use add_cmd to install "maint
 717         show test-options-completion-result".
 718
 719 2019-07-03  Pedro Alves  <palves@redhat.com>
 720
 721         * NEWS (New commands): Mention "with" and "maint with".
 722         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 723         (with_command, with_command_completer): New.
 724         (pipe_command): Adjust to new repeat_previous
 725         interface.
 726         (_initialize_cli_cmds): Install the "with" command and its "w"
 727         alias.
 728         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 729         declarations.
 730         * cli/cli-setshow.c (parse_cli_var_uinteger)
 731         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 732         argument strings for all var_types.
 733         (get_setshow_command_value_string): New, factored out from ...
 734         (do_show_command): ... this.
 735         * cli/cli-setshow.h: Include <string>.
 736         (get_setshow_command_value_string): Declare.
 737         * command.h (repeat_previous): Now returns const char *.  Adjust
 738         comment.
 739         * maint.c: Include "cli/cli-cmds.h".
 740         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 741         (_initialize_maint_cmds): Register the "maintenance with" command.
 742         * top.c (repeat_previous): Move bits from pipe_command here:
 743         Return the saved command line, if any; error out if there's no
 744         command to relaunch.
 745
 746 2019-07-03  Pedro Alves  <palves@redhat.com>
 747
 748         * NEWS (New commands): Mention "maint set/show test-settings"
 749         instead of "maint test-settings".
 750         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 751         (maintenance_test_settings_set_list): Rename to ...
 752         (maintenance_set_test_settings_list): ... this.
 753         (maintenance_test_settings_show_list): Rename to  ...
 754         (maintenance_show_test_settings_list): ... this.
 755         (maintenance_test_settings_cmd): Delete.
 756         (maintenance_test_settings_set_cmd): ...
 757         (maintenance_set_test_settings_cmd): ... this.
 758         (maintenance_test_settings_show_cmd): ...
 759         (maintenance_show_test_settings_cmd): ... this.
 760         (maintenance_test_settings_show_value_cmd):
 761         (maintenance_show_test_settings_value_cmd): ... this.
 762         (_initialize_maint_test_settings): No longer install the "maint
 763         test-settings" prefix command.  Rename "maint test-settings set"
 764         to "maint set test-settings", and "maint test-settings show" to
 765         "maint show test-settings".  Adjust all subcommands.
 766
 767 2019-07-03  Pedro Alves  <palves@redhat.com>
 768
 769         * maint-test-settings.c: Fix file's intro comment.  Replace all
 770         references to "test-options" with references to "test-settings",
 771         in comments.
 772
 773 2019-07-03  Pedro Alves  <palves@redhat.com>
 774
 775         * maint-test-settings.c (maintenance_test_settings_xxx)
 776         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 777         New.
 778         (maintenance_test_settings_enums): Use them.
 779         (maintenance_test_settings_enum): Default to
 780         maintenance_test_settings_xxx.
 781         (_initialize_maint_test_settings): Initialize
 782         MAINTENANCE_TEST_SETTINGS_FILENAME.
 783
 784 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 785
 786         * breakpoint.h (remove_breakpoints_inf): Change return type to
 787         void, move function documentation here.
 788         * breakpoint.c (remove_breakpoints_inf): Change return type to
 789         void, move function documentation to header.
 790
 791 2019-07-02  Pedro Alves  <palves@redhat.com>
 792
 793         * NEWS (Completion improvements): Mention "info threads".
 794         * thread.c (struct info_threads_opts, info_threads_option_defs)
 795         (make_info_threads_options_def_group): New.
 796         (info_threads_command): Use gdb::option::process_options.
 797         (info_threads_command_completer): New.
 798         (_initialize_thread): Use gdb::option::build_help to build the
 799         help text for "info threads".
 800
 801 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 802
 803         * defs.h (generic_load): Move from here...
 804         * symfile.h (generic_load): ... to here.  Rename name parameter
 805         to args.
 806         * symfile.c (generic_load): Add comment.
 807
 808 2019-07-01  Tom Tromey  <tromey@adacore.com>
 809
 810         * dwarf2read.c
 811         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 812         declaration of without_params.  Fix formatting.
 813
 814 2019-07-01  Tom Tromey  <tromey@adacore.com>
 815
 816         * ada-exp.y (find_primitive_type): Update.
 817         * ada-lang.h (ada_lookup_symbol): Update.
 818         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 819         parameter.
 820         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 821
 822 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 823
 824         PR breakpoints/24541
 825         * gdbarch.c: Regenerate.
 826         * gdbarch.h: Regenerate.
 827         * gdbarch.sh: Add 'stap_adjust_register'.
 828         * i386-tdep.c: Include '<unordered_set>'.
 829         (i386_stap_adjust_register): New function.
 830         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 831         * stap-probe.c (stap_parse_register_operand): Call
 832         'gdbarch_stap_adjust_register'.
 833
 834 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 835
 836         PR python/24742
 837         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 838         * python/python.c (do_start_initialization): Use 'xmalloc'
 839         instead of 'PyMem_Malloc'.
 840
 841 2019-06-28  Tom Tromey  <tromey@adacore.com>
 842
 843         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 844         for Ada.
 845
 846 2019-06-27  Tom Tromey  <tromey@adacore.com>
 847
 848         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 849         objfile_key.
 850         (arm_find_mapping_symbol, arm_record_special_symbol)
 851         (_initialize_arm_tdep): Update.
 852         (arm_objfile_data_free): Remove.
 853
 854 2019-06-27  Tom Tromey  <tromey@adacore.com>
 855
 856         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 857         to cp_print_static_field.
 858
 859 2019-06-26  Tom Tromey  <tromey@adacore.com>
 860
 861         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 862         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 863         declare.
 864
 865 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 866
 867         * features/aarch64-core.c (create_feature_aarch64_core):
 868         Regenerate.
 869         * features/aarch64-core.xml: Add cpsr flags.
 870
 871 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 872
 873         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 874         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 875
 876 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 877
 878         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 879         field.
 880         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 881         use.
 882         (arm_record_special_symbol): Don't insert new symbol in sorted
 883         position, push it at the end.
 884
 885 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 886
 887         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 888         (arm_mapping_symbol_s): Remove.
 889         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 890         (arm_mapping_symbol_vec): New typedef.
 891         (struct arm_per_objfile): Add constructor.
 892         <section_maps>: Change type to
 893         std::unique_ptr<arm_mapping_symbol_vec[]>.
 894         (arm_compare_mapping_symbols): Remove.
 895         (arm_find_mapping_symbol): Adjust to section_maps type change.
 896         (arm_objfile_data_free): Call delete on arm_per_objfile.
 897         (arm_record_special_symbol): Adjust to section_maps type change.
 898         Allocate arm_per_objfile with new.
 899
 900 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 901
 902         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 903         with the command prefix.
 904
 905 2019-06-25  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 908         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 909
 910 2019-06-25  Tom Tromey  <tom@tromey.com>
 911
 912         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 913         type.
 914         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 915         protected.
 916
 917 2019-06-25  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-winsource.c
 920         (tui_source_window_base::set_is_exec_point_at): Add check against
 921         LOA_ADDRESS.
 922
 923 2019-06-25  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-source.c (tui_set_source_content): Don't check before
 926         xfree.
 927         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 928
 929 2019-06-25  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui-winsource.h (tui_update_source_window_as_is)
 932         (tui_alloc_source_buffer, tui_line_is_displayed)
 933         (tui_addr_is_displayed): Change type of win_info.
 934         * tui/tui-winsource.c (tui_update_source_window_as_is)
 935         (tui_clear_source_content, tui_show_source_line)
 936         (tui_show_source_content, tui_source_window_base::refill)
 937         (tui_source_window_base::set_is_exec_point_at)
 938         (tui_source_window_base::set_is_exec_point_at)
 939         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 940         (tui_alloc_source_buffer, tui_line_is_displayed)
 941         (tui_addr_is_displayed): Change type of win_info.  Update.
 942         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 943         (tui_source_window_base::do_make_visible_with_new_height):
 944         Update.
 945         * tui/tui-source.c (tui_set_source_content)
 946         (tui_set_source_content_nil)
 947         (tui_source_window::do_scroll_vertical): Update.
 948         * tui/tui-layout.c (show_layout): Update.
 949         * tui/tui-disasm.c (tui_set_disassem_content)
 950         (tui_disasm_window::do_scroll_vertical): Update.
 951         * tui/tui-data.h (tui_win_content): Remove.
 952         (struct tui_gen_win_info) <content, content_size>: Remove.
 953         (struct tui_source_element): Add initializers and destructor.
 954         (union tui_which_element, struct tui_win_element): Remove.
 955         (struct tui_source_window_base) <content>: New field.
 956         (struct tui_data_window): Remove destructor.
 957         (tui_alloc_content, tui_free_win_content)
 958         (tui_free_all_source_wins_content): Don't declare.
 959         * tui/tui-data.c (tui_initialize_static_data): Update.
 960         (init_content_element, tui_alloc_content): Remove.
 961         (~tui_gen_win_info): Update.
 962         (~tui_data_window, tui_free_all_source_wins_content)
 963         (tui_free_win_content, free_content, free_content_elements):
 964         Remove.
 965
 966 2019-06-25  Tom Tromey  <tom@tromey.com>
 967
 968         * tui/tui-winsource.h (tui_clear_source_content)
 969         (tui_erase_source_content, tui_show_source_content): Change type
 970         of win_info.
 971         * tui/tui-winsource.c (tui_clear_source_content)
 972         (tui_erase_source_content, tui_show_source_content): Change type
 973         of win_info.
 974         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 975         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 976         win_info.
 977         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 978         win_info.
 979         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 980
 981 2019-06-25  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-winsource.c (tui_clear_source_content)
 984         (tui_source_window_base::set_is_exec_point_at): Update.
 985         * tui/tui-source.c (tui_set_source_content_nil): Update.
 986         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 987         a bool.
 988         * tui/tui-data.c (init_content_element): Update.
 989
 990 2019-06-25  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 993         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 994         * tui/tui-layout.c (init_and_make_win): Update.
 995         * tui/tui.h (enum tui_win_type): Update.
 996         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 997         tui_win_is_auxillary.
 998         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 999         tui_win_is_auxillary.
1000
1001 2019-06-25  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1004         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1005         (tui_delete_data_content_windows, tui_display_all_data)
1006         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1007         Update.
1008         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1009         * tui/tui-regs.c (tui_last_regs_line_no)
1010         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1011         (tui_show_registers): Update.
1012         (tui_show_register_group): Return void.  Update.
1013         (tui_display_registers_from, tui_display_reg_element_at_line)
1014         (tui_display_registers_from_line, tui_check_register_values):
1015         Update.
1016         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1017         member.
1018         (struct tui_data_window) <regs_content>: Now a std::vector.
1019         <regs_content_count>: Remove.
1020         (tui_add_content_elements, tui_free_data_content): Don't declare.
1021         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1022         (init_content_element): Remove DATA_WIN case.  Add assert.
1023         (tui_add_content_elements): Remove.
1024         (tui_data_window): Update.
1025         (tui_free_data_content): Remove.
1026         (free_content_elements): Remove DATA_WIN case.
1027
1028 2019-06-25  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-data.c (tui_data_item_window): Update.
1031         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1032         * tui/tui-windata.c (tui_display_all_data)
1033         (tui_display_data_from_line): Update.
1034         (tui_check_data_values): Remove.
1035         * tui/tui-regs.c (tui_show_register_group)
1036         (tui_display_reg_element_at_line): Update.
1037         * tui/tui-hooks.c (tui_register_changed)
1038         (tui_refresh_frame_and_register_information): Call
1039         tui_check_register_values.
1040         * tui/tui-data.h (struct tui_data_window) <data_content,
1041         data_content_count, data_type>: Remove.
1042         (enum tui_data_type): Remove.
1043
1044         * tui/tui-data.c (tui_data_window::clear_detail)
1045         (~tui_data_window): Update.
1046
1047 2019-06-25  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1050         declare.
1051         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1052         Rename from tui_first_data_item_displayed.  Update.
1053         (tui_data_window::refresh_all)
1054         (tui_data_window::do_scroll_vertical): Update.
1055         * tui/tui-data.h (struct tui_data_window)
1056         <first_data_item_displayed>: Declare new method.
1057
1058 2019-06-25  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1061         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1062         contents...
1063         (tui_initialize_static_data): ...here.
1064
1065 2019-06-25  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1068         (tui_display_registers_from, tui_check_register_values): Update.
1069         (tui_display_register): Remove win_info parameter; update.
1070         (tui_get_register): Change type of parameters.
1071         * tui/tui-data.h (struct tui_data_element): Remove.
1072         (union tui_which_element) <data>: Remove.
1073         <data_window>: Change type.
1074         (struct tui_data_item_window): New.
1075         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1076         case.  Add assert.
1077         (~tui_data_item_window): New destructor.
1078         (free_content_elements): Remove DATA_ITEM_WIN case.
1079
1080 2019-06-25  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1083         Remove.
1084
1085 2019-06-25  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-data.h (struct tui_command_element): Remove.
1088         (union tui_which_element) <command>: Remove.
1089         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1090         assert.
1091         (free_content_elements): Remove CMD_WIN case.
1092
1093 2019-06-25  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-layout.c (tui_set_layout): Update.
1096         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1097         * tui/tui-data.c (layout_def): Update.
1098
1099 2019-06-25  Tom Tromey  <tom@tromey.com>
1100
1101         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1102         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1103         (tui_source_window_base::set_new_height): Update.
1104         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1105         Update.
1106         (tui_set_locator_fullname, tui_set_locator_info)
1107         (tui_show_frame_info): Update.
1108         * tui/tui-source.c (tui_set_source_content)
1109         (tui_source_is_displayed): Update.
1110         * tui/tui-layout.c (show_source_disasm_command, show_data)
1111         (show_source_or_disasm_and_command): Update.
1112         * tui/tui-disasm.c (tui_set_disassem_content)
1113         (tui_get_begin_asm_address): Update.
1114         * tui/tui-data.h (struct tui_locator_element): Remove.
1115         (union tui_which_element) <locator>: Remove.
1116         (struct tui_locator_window): New.
1117         (tui_locator_win_info_ptr): Change return type.
1118         * tui/tui-data.c (_locator): Change type.
1119         (tui_locator_win_info_ptr): Change return type.
1120         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1121         (tui_alloc_content): Add assert.
1122
1123 2019-06-25  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-winsource.c
1126         (tui_exec_info_window::maybe_allocate_content): New method.
1127         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1128         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1129         (make_source_or_disasm_window): Add cast.
1130         * tui/tui-data.h (union tui_which_element) <simple_string>:
1131         Remove.
1132         (struct tui_source_info): New.
1133         (struct tui_source_window_base) <execution_info>: Change type.
1134         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1135         case, and add assert.
1136         (tui_alloc_content): Add assert.
1137
1138 2019-06-25  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1141         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1142         * tui/tui-data.c (tui_alloc_win_info): Remove.
1143
1144 2019-06-25  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1147         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1148         can_highlight.
1149
1150 2019-06-25  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1153         make_visible_with_new_height method.
1154         (tui_win_info::make_visible_with_new_height): New method.
1155         (tui_source_window_base::do_make_visible_with_new_height)
1156         (tui_data_window::do_make_visible_with_new_height)
1157         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1158         (make_visible_with_new_height): Remove.
1159         (tui_resize_all, tui_adjust_win_heights): Use
1160         make_visible_with_new_height method.
1161         * tui/tui-data.h (struct tui_win_info)
1162         <do_make_visible_with_new_height, make_visible_with_new_height>:
1163         New methods.
1164         (struct tui_source_window_base, struct tui_data_window)
1165         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1166         methods.
1167
1168 2019-06-25  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1171         method.
1172         (update_tab_width): Call update_tab_width method.
1173         * tui/tui-data.h (struct tui_win_info)
1174         (struct tui_source_window_base) <update_tab_width>: New methods.
1175
1176 2019-06-25  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1179         parameter.
1180         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1181         parameter.
1182         (tui_gen_win_info::make_visible): Update.
1183         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1184         parameter.
1185         * tui/tui-data.h (enum tui_box): New enum.
1186         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1187
1188 2019-06-25  Tom Tromey  <tom@tromey.com>
1189
1190         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1191         init_and_make_win for EXEC_INFO_WIN.
1192         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1193         longer inline.
1194         (struct tui_win_info) <~tui_win_info>: Inline.
1195         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1196         Don't declare.
1197         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1198         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1199         Remove.
1200         (tui_initialize_static_data): Update.
1201         (~tui_gen_win_info): Handle more cleanup here.
1202         (~tui_source_window_base): Delete "execution_info".
1203         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1204
1205 2019-06-25  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-layout.c (make_command_window): Don't set
1208         can_highlight.
1209         (show_source_disasm_command): Call the reset method.
1210         (show_data): Don't set can_highlight.  Call the reset method.
1211         (tui_gen_win_info::reset): Rename from init_gen_win_info
1212         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1213         (show_source_or_disasm_and_command): Call the reset method.
1214         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1215         (struct tui_cmd_window): Set can_highlight.
1216
1217 2019-06-25  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1220         from make_visible.
1221         (tui_make_visible, tui_make_invisible): Rewrite.
1222         (tui_win_info::make_visible): Remove.
1223         (tui_source_window_base::make_visible): Update.
1224         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1225         method.  Moved from...
1226         (struct tui_win_info) <make_visible>: ...here.
1227
1228 2019-06-25  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-winsource.c
1231         (tui_source_window_base::do_scroll_horizontal): Remove direction
1232         parameter.
1233         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1234         direction parameter.
1235         * tui/tui-win.c (tui_win_info::forward_scroll)
1236         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1237         (tui_win_info::right_scroll): Update.
1238         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1239         direction parameter.
1240         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1241         direction parameter.
1242         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1243         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1244         Remove direction parameter.
1245         (struct tui_source_window_base, struct tui_source_window)
1246         (struct tui_disasm_window, struct tui_data_window)
1247         (struct tui_cmd_window): Update.
1248
1249 2019-06-25  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-winsource.h (tui_set_exec_info_content)
1252         (tui_show_exec_info_content, tui_erase_exec_info_content)
1253         (tui_clear_exec_info_content, tui_update_exec_info): Change
1254         argument to tui_source_window_base.
1255         * tui/tui-winsource.c (tui_set_exec_info_content)
1256         (tui_show_exec_info_content, tui_erase_exec_info_content)
1257         (tui_clear_exec_info_content, tui_update_exec_info): Change
1258         argument to tui_source_window_base.
1259
1260 2019-06-25  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1263         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1264
1265 2019-06-25  Tom Tromey  <tom@tromey.com>
1266
1267         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1268         check.
1269
1270 2019-06-25  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1273         type to void.
1274         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1275         type to void.
1276         * tui/tui-source.c (tui_set_source_content): Update.
1277         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1278
1279 2019-06-25  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-win.c (window_name_completer, tui_set_focus)
1282         (tui_all_windows_info): Use name method.
1283         * tui/tui-data.h (struct tui_gen_win_info)
1284         (struct tui_source_window, struct tui_disasm_window)
1285         (struct tui_data_window, struct tui_cmd_window) <name>: New
1286         method.
1287         (tui_win_name): Don't declare.
1288         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1289         (tui_win_name): Remove.
1290
1291 2019-06-25  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-winsource.h (tui_update_source_window)
1294         (tui_update_source_window_as_is): Change parameter type.
1295         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1296         to be a tui_source_window_base.
1297         (tui_update_source_window_as_is): Likewise.
1298         * tui/tui-win.c (make_visible_with_new_height): Update.
1299
1300 2019-06-25  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-winsource.c (tui_erase_source_content)
1303         (tui_show_source_content, tui_show_exec_info_content)
1304         (tui_erase_exec_info_content): Use refresh_window method.
1305         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1306         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1307         from tui_refresh_win.
1308         (tui_data_window::refresh_window): New method.
1309         (tui_win_info::refresh, tui_source_window_base::refresh)
1310         (tui_refresh_all): Use refresh_window method.
1311         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1312         method.
1313         * tui/tui-regs.c (tui_display_register): Call refresh_window
1314         method.
1315         * tui/tui-layout.c (show_source_disasm_command)
1316         (show_source_or_disasm_and_command): Call refresh_window method.
1317         * tui/tui-data.h (struct tui_gen_win_info)
1318         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1319         New method.
1320
1321 2019-06-25  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui.c (tui_rl_other_window, tui_enable)
1324         (tui_is_window_visible, tui_get_command_dimension): Update.
1325         * tui/tui-winsource.c (tui_update_source_window_as_is)
1326         (tui_clear_source_content, tui_erase_source_content)
1327         (tui_show_source_line, tui_source_window_base::refill)
1328         (tui_source_window_base::do_scroll_horizontal)
1329         (tui_source_window_base::set_is_exec_point_at)
1330         (tui_update_breakpoint_info, tui_set_exec_info_content)
1331         (tui_alloc_source_buffer, tui_line_is_displayed)
1332         (tui_addr_is_displayed): Update.
1333         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1334         (tui_check_and_display_highlight_if_needed)
1335         (tui_win_info::make_visible, tui_win_info::refresh)
1336         (tui_refresh_all): Update.
1337         * tui/tui-windata.c (tui_first_data_item_displayed)
1338         (tui_delete_data_content_windows, tui_erase_data_content)
1339         (tui_display_all_data, tui_data_window::refresh_all)
1340         (tui_check_data_values): Update.
1341         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1342         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1343         (tui_win_info::backward_scroll, tui_refresh_all_win)
1344         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1345         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1346         (tui_source_window_base::set_new_height)
1347         (tui_data_window::set_new_height)
1348         (make_invisible_and_set_new_height)
1349         (make_visible_with_new_height, new_height_ok)
1350         (parse_scrolling_args): Update.
1351         * tui/tui-stack.c (tui_show_frame_info): Update.
1352         * tui/tui-source.c (tui_set_source_content)
1353         (tui_set_source_content_nil, tui_source_is_displayed)
1354         (tui_source_window::do_scroll_vertical): Update.
1355         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1356         (tui_display_registers_from, tui_display_reg_element_at_line)
1357         (tui_check_register_values, tui_reg_command): Update.
1358         * tui/tui-layout.c (tui_default_win_height)
1359         (show_source_disasm_command, show_data, init_and_make_win)
1360         (show_source_or_disasm_and_command): Update.
1361         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1362         (tui_redisplay_readline, tui_mld_flush)
1363         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1364         (tui_getc): Update.
1365         * tui/tui-disasm.c (tui_set_disassem_content)
1366         (tui_disasm_window::do_scroll_vertical): Update.
1367         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1368         Now virtual.
1369         (struct tui_win_info): Derive from tui_gen_win_info.
1370         <~tui_win_info>: Mark as override.
1371         <generic>: Remove member.
1372         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1373         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1374         (~tui_data_window, ~tui_win_info)
1375         (tui_free_all_source_wins_content): Update.
1376         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1377
1378 2019-06-25  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-layout.c (init_and_make_win): Use new.
1381         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1382         destructor, initializers.
1383         (tui_alloc_generic_win_info): Don't declare.
1384         * tui/tui-data.c (_locator): Add argument to constructor.
1385         (source_win, disasm_win): New globals.
1386         (exec_info): Remove.
1387         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1388         Update.
1389         (tui_alloc_generic_win_info): Remove.
1390         (init_content_element): Use new.
1391         (tui_win_info::tui_win_info): Update.
1392         (free_content_elements) <case DATA_WIN>: Use delete.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1397         * tui/tui-windata.c (tui_first_data_item_displayed)
1398         (tui_delete_data_content_windows): Update.
1399         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1400         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1401         (tui_display_registers_from, tui_check_register_values): Update.
1402         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1403         pointer.
1404         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1405         window.
1406         (tui_free_data_content): Update.
1407         (free_content_elements) <case DATA_WIN>: Free the window.
1408
1409 2019-06-25  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1412         Update.
1413         * tui/tui-layout.c (make_command_window)
1414         (show_source_disasm_command, show_data, init_and_make_win)
1415         (show_source_or_disasm_and_command): Update.
1416         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1417         method.
1418         <can_highight, is_highlighted>: Now bool.
1419         (tui_set_win_highlight): Don't declare.
1420         * tui/tui-data.c (tui_set_win_highlight): Remove.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-wingeneral.c (make_visible): Remove check of window
1425         type.
1426
1427 2019-06-25  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-win.c (tui_win_info::max_height)
1430         (tui_cmd_window::max_height): New methods.
1431         (new_height_ok): Call max_height.
1432         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1433         <max_height>: New method.
1434
1435 2019-06-25  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-win.c (tui_source_window_base::set_new_height)
1438         (tui_data_window::set_new_height): New methods.
1439         (make_invisible_and_set_new_height): Call set_new_height method.
1440         * tui/tui-data.h (struct tui_win_info)
1441         (struct tui_source_window_base, struct tui_data_window)
1442         <set_new_height>: New method.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1447         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1448         tui_refresh_data_win.
1449         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1450         method.
1451         (tui_refresh_all_win): Call the refresh_all method.
1452         (tui_set_focus): Likewise.
1453         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1454         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1455         Likewise.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-winsource.h (tui_refill_source_window)
1460         (tui_set_is_exec_point_at): Don't declare.
1461         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1462         (tui_source_window_base::refill): Rename from
1463         tui_refill_source_window.
1464         (tui_source_window_base::do_scroll_horizontal): Update.
1465         (tui_source_window_base::set_is_exec_point_at): Rename from
1466         tui_set_is_exec_point_at.
1467         (tui_update_all_breakpoint_info): Update.
1468         * tui/tui-stack.c (tui_show_frame_info): Update.
1469         * tui/tui-layout.c (show_data): Add cast.
1470         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1471         * tui/tui-data.h (struct tui_source_window_base) <refill,
1472         set_is_exec_point_at>: New methods.
1473         (tui_source_windows, tui_add_to_source_windows): Update types.
1474         (tui_add_to_source_windows): Remove redundant declaration.
1475         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1476         (tui_source_windows): Change return type.
1477         (tui_clear_source_windows_detail): Update.
1478         (tui_add_to_source_windows): Change type of parameter.
1479         (tui_free_all_source_wins_content): Update.
1480
1481 2019-06-25  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-wingeneral.c (tui_win_info::refresh)
1484         (tui_source_window_base::refresh): New methods.
1485         (tui_refresh_all): Call the refresh method.
1486         * tui/tui-data.h (struct tui_win_info)
1487         (struct tui_source_window_base) <refresh>: New method.
1488
1489 2019-06-25  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui.h (tui_is_window_visible): Return bool.
1492         * tui/tui.c (tui_is_window_visible): Return bool.
1493         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1494         (tui_make_visible, tui_make_invisible)
1495         (tui_win_info::make_visible)
1496         (tui_source_window_base::make_visible, make_all_visible)
1497         (tui_make_all_visible, tui_make_all_invisible): Update.
1498         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1499         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1500         bool.
1501         (struct tui_win_info, struct tui_source_window_base)
1502         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1503         * tui/tui-data.c (tui_init_generic_part): Update.
1504
1505 2019-06-25  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1508         (tui_source_window_base::make_visible): New methods.
1509         (make_all_visible): Make method call.
1510         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1511         (struct tui_source_window_base, struct tui_cmd_window): Override
1512         make_visible.
1513         (tui_win_is_source_type): Don't declare.
1514         * tui/tui-data.c (tui_win_is_source_type): Remove.
1515
1516 2019-06-25  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1519         NULL check.
1520
1521 2019-06-25  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1524         Inline constructor.  Add initializers for members.
1525         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1526         constructors; now inline in class.
1527
1528 2019-06-25  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-regs.c (tui_show_registers): Update.
1531         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1532         bool.
1533         * tui/tui-data.c (tui_data_window::clear_detail)
1534         (tui_data_window): Update.
1535
1536 2019-06-25  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-windata.c (tui_display_all_data)
1539         (tui_display_data_from_line, tui_display_data_from)
1540         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1541         Update.
1542         * tui/tui-regs.c (tui_last_regs_line_no)
1543         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1544         (tui_show_registers, tui_show_register_group)
1545         (tui_display_registers_from, tui_display_reg_element_at_line)
1546         (tui_display_registers_from_line, tui_check_register_values)
1547         (tui_reg_next, tui_reg_prev): Update.
1548         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1549         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1550         tui_data_window.
1551         (struct tui_win_info) <detail>: Remove.  Add new fields from
1552         tui_data_info.
1553         (TUI_DATA_WIN): Add cast.
1554         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1555         (~tui_data_window): Simplify.
1556
1557 2019-06-25  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-layout.c (show_source_disasm_command)
1560         (show_source_or_disasm_and_command): Update.
1561         * tui/tui-io.c (update_cmdwin_start_line)
1562         (tui_redisplay_readline): Update.
1563         * tui/tui-data.h (struct tui_command_info): Remove.
1564         (struct tui_win_info) <detail>: Remove command_info member.
1565         (struct tui_data_window) <start_line>: New member, from
1566         tui_command_info.
1567         (TUI_CMD_WIN): Add casts.
1568
1569 2019-06-25  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-winsource.c (tui_update_source_window)
1572         (tui_refill_source_window)
1573         (tui_source_window_base::do_scroll_horizontal)
1574         (tui_update_breakpoint_info, tui_set_exec_info_content)
1575         (tui_show_exec_info_content, tui_erase_exec_info_content)
1576         (tui_clear_exec_info_content): Update.
1577         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1578         Update.
1579         * tui/tui-win.c (make_invisible_and_set_new_height)
1580         (make_visible_with_new_height): Update.
1581         * tui/tui-source.c (tui_set_source_content)
1582         (tui_show_symtab_source): Update.
1583         * tui/tui-layout.c (extract_display_start_addr)
1584         (show_source_disasm_command, show_data)
1585         (make_source_or_disasm_window)
1586         (show_source_or_disasm_and_command): Update.
1587         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1588         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1589         "gdbarch".
1590         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1591         to tui_source_window_base.
1592         (struct tui_win_info) <detail>: Remove source_info member.
1593         (struct tui_source_window_base) <has_locator>: Inline.
1594         Move contents from tui_source_info; rename has_locator member to
1595         m_has_locator.
1596         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1597         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1598         header file.
1599         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1600         Simplify.
1601         (tui_free_all_source_wins_content): Cast to
1602         tui_source_window_base.
1603
1604 2019-06-25  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-win.c (make_invisible_and_set_new_height)
1607         (make_visible_with_new_height): Call has_locator method.
1608         * tui/tui-layout.c (show_source_disasm_command, show_data)
1609         (show_source_or_disasm_and_command): Update for bool change.
1610         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1611         (tui_win_info) <has_locator>: New method.
1612         (struct tui_source_window_base) <has_locator>: New method.
1613         (tui_win_has_locator): Don't declare.
1614         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1615         from tui_win_has_locator.
1616         (tui_source_window_base): Use false, not FALSE.
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1621         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1622         clear_detail method directly.
1623         (tui_clear_win_detail): Remove.
1624
1625 2019-06-25  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1628         "this", not TUI_DISASM_WIN.
1629
1630 2019-06-25  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1633         declare.
1634         * tui/tui-winsource.c
1635         (tui_source_window_base::do_scroll_horizontal): Rename from
1636         tui_horizontal_source_scroll.
1637         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1638         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1639         from tui_vertical_data_scroll.
1640         * tui/tui-win.h (tui_scroll): Don't declare.
1641         * tui/tui-win.c (tui_win_info::forward_scroll)
1642         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1643         (tui_win_info::right_scroll): Rename and update.
1644         (tui_scroll_forward_command, tui_scroll_backward_command)
1645         (tui_scroll_left_command, tui_scroll_right_command): Update.
1646         (tui_scroll): Remove.
1647         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1648         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1649         from tui_vertical_source_scroll.
1650         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1651         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1652         from tui_vertical_disassem_scroll.
1653         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1654         do_scroll_horizontal>: New methods.
1655         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1656         Likewise.
1657         (struct tui_source_window_base): Add do_scroll_horizontal.
1658         (struct tui_source_window, struct tui_disasm_window): Add
1659         do_scroll_vertical.
1660         (struct tui_data_window, struct tui_cmd_window): Add
1661         do_scroll_horizontal and do_scroll_vertical.
1662         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-data.h (struct tui_source_window_base): New struct.
1667         (struct tui_source_window): Derive from tui_source_window_base.
1668         (struct tui_disasm_window): New struct.
1669         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1670         from tui_source_window::clear_detail.
1671         (tui_source_window_base): Rename from tui_source_window.
1672         (~tui_source_window_base): Rename from ~tui_source_window.
1673         (tui_alloc_win_info): Create a tui_disasm_window.
1674
1675 2019-06-25  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-data.h (struct tui_source_window)
1678         (struct tui_data_window): Declare destructors.
1679         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1680         destructors.
1681         (tui_win_info): Simplify.
1682
1683 2019-06-25  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-winsource.c (tui_display_main)
1686         (tui_update_source_windows_with_addr)
1687         (tui_update_all_breakpoint_info): Update.
1688         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1689         (new_height_ok, parse_scrolling_args): Update.
1690         * tui/tui-stack.c (tui_show_frame_info): Update.
1691         * tui/tui-data.h (struct tui_list): Remove.
1692         (tui_source_windows): Return a reference to a std::vector.
1693         * tui/tui-data.c (source_windows): Now a std::vector.
1694         (tui_source_windows): Change return type.
1695         (tui_clear_source_windows): Rewrite.
1696         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1697         (tui_free_all_source_wins_content): Rewrite.
1698
1699 2019-06-25  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1702         (struct tui_data_window, struct tui_cmd_window): Declare
1703         clear_detail method.
1704         * tui/tui-data.c (tui_source_window::clear_detail)
1705         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1706         methods.
1707         (tui_clear_win_detail): Simplify.
1708
1709 2019-06-25  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-layout.c (make_source_window, make_disasm_window)
1712         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1713         Return the new window.
1714         (show_source_disasm_command, show_data)
1715         (show_source_or_disasm_and_command): Update.
1716
1717 2019-06-25  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1720         parameter.  Return the new window.
1721         (show_source_disasm_command): Update and remove NULL check.
1722         (show_source_or_disasm_and_command): Update.
1723
1724 2019-06-25  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1727
1728 2019-06-25  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-data.h (struct tui_win_info): Make constructor
1731         protected.  Make destructor virtual.  Add initializers.
1732         (tui_source_window, tui_data_window, tui_cmd_window): New
1733         classes.
1734         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1735         constructor.  Add "type" parameter.
1736         (tui_source_window, tui_data_window, tui_cmd_window): New
1737         constructors.
1738         (tui_alloc_win_info): Instantiate the appropriate subclass.
1739
1740 2019-06-25  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-win.c (tui_resize_all): Use delete.
1743         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1744         destructor.
1745         (tui_free_window): Don't declare.
1746         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1747         Update.
1748
1749 2019-06-25  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-data.h (struct tui_win_info): Add constructor.
1752         * tui/tui-data.c (tui_alloc_win_info): Use new.
1753         (tui_free_window): Use delete.
1754
1755 2019-06-22  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1758         declare.
1759         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1760
1761 2019-06-22  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1764         declare.
1765         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1766
1767 2019-06-22  Tom de Vries  <tdevries@suse.de>
1768
1769         * dwarf2read.c (create_addrmap_from_aranges)
1770         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1771         instead of '%zu'.
1772
1773 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1774
1775         * dwarf2read.h (dwarf2_section_info_def): Remove.
1776         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1777         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1778         std::vector<dwarf2_section_info>.
1779         (struct dwo_file) <~dwo_file>: Remove.
1780         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1781         types field.
1782         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1783         (dwarf2_read_debug_names): Likewise.
1784         (create_debug_types_hash_table): Change parameter type to
1785         array_view, adjust code accordingly.
1786         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1787         (partial_die_info::fixup): Likewise.
1788         (determine_prefix): Likewise.
1789         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1790
1791 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1792
1793         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1794         gdb_bfd_ref_ptr.
1795         <~dwo_file>: Remove call to gdb_bfd_unref.
1796         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1797         gdb_bfd_ref_ptr::get.
1798
1799 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1800
1801         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1802         type to htab_up.
1803         * dwarf2read.c (struct dwo_file): Initialize fields.
1804         <~dwo_file>: New.
1805         (free_dwo_file): Remove, move content to ~dwo_file.
1806         (struct dwo_file_deleter): Remove.
1807         (dwo_file_up>: Remove custom deleter.
1808         (free_dwo_files): Remove.
1809         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1810         dwo_files.
1811         (process_skeletonless_type_units): Call unique_ptr::get.
1812         (allocate_dwo_file_hash_table): Add deleter to created hash
1813         table.  Change return type to htab_up.
1814         (lookup_dwo_file_slot): Don't memset dwo_file, call
1815         unique_ptr::get.
1816         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1817         (create_dwo_unit_in_dwp_v2): Likewise.
1818         (open_and_init_dwo_file): Likewise.
1819         (free_dwo_file_from_slot): Remove.
1820
1821 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1822
1823         * dwarf2read.h (struct dwarf2_section_info) <readin,
1824         is_virtual>: Change type to bool.
1825         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1826         true instead of 1.
1827
1828 2019-06-19  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-data.h (tui_init_content_element): Don't declare.
1831
1832 2019-06-19  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-data.h (tui_init_win_info): Don't declare.
1835
1836 2019-06-19  Tom de Vries  <tdevries@suse.de>
1837
1838         * dwarf2read.h (abstract_to_concrete): Change type to
1839         std::unordered_map<sect_offset, std::vector<sect_offset>,
1840         gdb::hash_enum<sect_offset>>.
1841
1842 2019-06-19  Tom Tromey  <tromey@adacore.com>
1843
1844         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1845         EVAL_AVOID_SIDE_EFFECTS specially.
1846
1847 2019-06-19  Tom Tromey  <tromey@adacore.com>
1848
1849         * source-cache.c (highlighter): New global.
1850         (source_cache::get_source_lines): Create a highlighter on demand.
1851
1852 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1853
1854         * defs.h (deprecated_interactive_hook): Delete declaration.
1855         * interps.c (clear_interpreter_hooks): Remove use of
1856         deprecated_interactive_hook.
1857         * top.c (deprecated_interactive_hook): Delete definition.
1858         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1859
1860 2019-06-18  Tom de Vries  <tdevries@suse.de>
1861
1862         PR gdb/24515
1863         * dwarf2read.h (abstract_to_concrete): Change type from
1864         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1865         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1866         * dwarf2read.c (read_variable): Update.
1867         (dwarf2_fetch_die_loc_sect_off): Update.
1868
1869 2019-06-17  Tom de Vries  <tdevries@suse.de>
1870
1871         PR gdb/24617
1872         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1873         accessing parent[parent_len - 1].
1874
1875 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1876
1877         PR gdb/24364
1878         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1879         call dtrace_process_dof with NULL dof.
1880
1881 2019-06-16  Tom de Vries  <tdevries@suse.de>
1882
1883         PR gdb/24445
1884         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1885
1886 2019-06-16  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1889         (make_all_visible): Use address of member.
1890
1891 2019-06-16  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1894         (tui_free_window, free_content, free_content_elements): Remove
1895         unnecessary cast.
1896         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1897         cast.
1898         * tui/tui-regs.c (tui_show_register_group)
1899         (tui_display_registers_from, tui_display_reg_element_at_line):
1900         Remove unnecessary cast.
1901
1902 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * linux-nat.c (normal_mask): Delete.
1905         (_initialize_linux_nat): Don't initialise normal_mask.
1906
1907 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1908
1909         PR gdb/24445
1910         * dwarf-index-write.h (write_psymtabs_to_index): Add
1911         dwz_basename parameter.
1912         * dwarf-index-write.c (write_gdbindex): Move file writing to
1913         write_gdbindex_1.  Change return type void.
1914         (assert_file_size): Move up, remove filename parameter.
1915         (write_gdbindex_1): New function.
1916         (write_debug_names): Change return type to void, call
1917         assert_file_size.
1918         (struct index_wip_file): New struct.
1919         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1920         file logic to index_wip_file.  Write index for dwz file if
1921         needed.
1922         (save_gdb_index_command): Pass basename of dwz file, if present.
1923         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1924         build-id of dwz file, if present.
1925         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1926         (dwarf2_get_dwz_file): Likewise.
1927         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1928         (dwarf2_get_dwz_file): Likewise.
1929
1930 2019-06-16  Tom Tromey  <tom@tromey.com>
1931
1932         * coffread.c (process_coff_symbol): Use xstrdup.
1933         * value.c (create_internalvar): Use xstrdup.
1934
1935 2019-06-16  Tom Tromey  <tom@tromey.com>
1936
1937         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1938         * breakpoint.c (stopin_command, stopat_command)
1939         (until_break_command, decode_location_default): Remove unnecessary
1940         cast.
1941         * utils.c (subset_compare): Remove unnecessary cast.
1942         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1943         cast.
1944         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1945         cast.
1946         * infcmd.c (path_command): Remove unnecessary cast.
1947         * coffread.c (decode_type): Remove unnecessary cast.
1948         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1949         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1950         * tui/tui-stack.c (tui_show_locator_content)
1951         (tui_show_frame_info): Remove unnecessary cast.
1952         * tui/tui-win.c (tui_scroll_forward_command)
1953         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1954         (parse_scrolling_args): Remove unnecessary cast.
1955         * tui/tui-data.c (init_win_info, tui_del_window)
1956         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1957         (free_content_elements): Remove unnecessary cast.
1958         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1959         unnecessary cast.
1960         * tui/tui-source.c (tui_set_source_content)
1961         (tui_vertical_source_scroll): Remove unnecessary cast.
1962         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1963         cast.
1964         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1965         * tui/tui-regs.c (tui_display_registers_from)
1966         (tui_display_register): Remove unnecessary cast.
1967         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1968         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1969         (make_visible): Remove unnecessary cast.
1970         * tui/tui-winsource.c (tui_erase_source_content)
1971         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1972         unnecessary cast.
1973         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1974         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1975         * stabsread.c (read_type, read_array_type, read_range_type):
1976         Remove unnecessary cast.
1977         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1978         (parse_symbol, parse_type, upgrade_type, parse_external)
1979         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1980         unnecessary cast.
1981         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1982
1983 2019-06-16  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-data.c (tui_alloc_generic_win_info)
1986         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1987         checks.
1988
1989 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1990             Andrew Burgess  <andrew.burgess@embecosm.com>
1991
1992         * f-typeprint.c (f_print_type): Don't return early for not
1993         associated or not allocated types.
1994         (f_type_print_varspec_suffix): Add print_rank parameter and print
1995         ranks of array types in case they dangling.
1996         (f_type_print_base): Add print_rank parameter.
1997
1998 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1999
2000         * NEWS: Mention new MI commands.
2001         * break-catch-throw.c (enum exception_event_kind): Move to
2002         breakpoint.h.
2003         (print_mention_exception_catchpoint): Output text as a single
2004         message.
2005         (catch_exception_command_1): Rename to...
2006         (catch_exception_event): ...this, make non-static, update header
2007         command, and change some parameter types.
2008         (catch_catch_command): Update for changes to
2009         catch_exception_command_1.
2010         (catch_throw_command): Likewise.
2011         (catch_rethrow_command): Likewise.
2012         * breakpoint.c (enum exception_event_kind): Delete.
2013         * breakpoint.h (enum exception_event_kind): Moved here from
2014         break-catch-throw.c.
2015         (catch_exception_event): Declare.
2016         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2017         (mi_cmd_catch_throw): New function.
2018         (mi_cmd_catch_rethrow): New function.
2019         (mi_cmd_catch_catch): New function.
2020         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2021         'catch-catch' entries.
2022         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2023         (mi_cmd_catch_rethrow): Declare.
2024         (mi_cmd_catch_catch): Declare.
2025
2026 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2027
2028         * annotate.c (annotate_source_line): Change return type to void,
2029         update implementation to match.
2030         * annotate.h (annotate_source_line): Change return type to void,
2031         update header comment.
2032         * stack.c (print_frame_info): Don't change what frame information
2033         is printed based on whether annotations are on or not.
2034
2035 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2036
2037         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2038         (annotate_source): Make static.
2039         (annotate_source_line): Moved from source.c and renamed from
2040         identify_source_line.  Update the return type.
2041         * annotate.h (annotate_source): Delete declaration.
2042         (annotate_source_line): Declaration moved from source.h, and
2043         renamed from identify_source_line.  Return type updated.
2044         * source.c (identify_source_line): Moved to annotate.c and renamed
2045         to annotate_source_line.
2046         (info_line_command): Remove check of annotation_level.
2047         * source.h (identify_source_line): Move declaration to annotate.h
2048         and rename to annotate_source_line.
2049         * stack.c: Add 'annotate.h' include.
2050         (print_frame_info): Remove check of annotation_level before
2051         calling annotate_source_line.
2052
2053 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2054
2055         * source-cache.c (source_cache::get_plain_source_lines): Use
2056         open_source_file_with_line_charpos instead of just
2057         open_source_file, remove call to find_source_lines.
2058         (source_cache::get_source_lines): Likewise.
2059         * source.c (find_source_lines): Make static.
2060         (get_filename_and_charpos): Renamed into...
2061         (open_source_file_with_line_charpos): ..this along with changes to
2062         return a scoped_fd, and some other minor clean ups.
2063         (identify_source_line): Use open_source_file_with_line_charpos.
2064         (search_command_helper): Use open_source_file_with_line_charpos
2065         instead of just open_source_file, remove call to
2066         find_source_lines.
2067         * source.h (open_source_file_with_line_charpos): Declare new
2068         function.
2069         (find_source_lines): Delete declaration.
2070
2071 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2072
2073         * source.c (get_filename_and_charpos): Remove fullname
2074         parameter.
2075         (identify_source_line): Update call to get_filename_and_charpos.
2076
2077 2019-06-14  Tom Tromey  <tromey@adacore.com>
2078
2079         PR gdb/24502:
2080         * ui-style.h (skip_ansi_escape): Update comment.
2081         * ui-file.h (class no_terminal_escape_file): New class.
2082         * ui-file.c (no_terminal_escape_file::write)
2083         (no_terminal_escape_file::puts): New methods.
2084         * cli/cli-logging.c (handle_redirections): Use
2085         no_terminal_escape_file.
2086
2087 2019-06-14  Tom Tromey  <tromey@adacore.com>
2088
2089         * NEWS: Move convenience variable news above Python news.
2090
2091 2019-06-14  Tom Tromey  <tom@tromey.com>
2092
2093         * gnulib: Move directory to top-level.
2094         * configure.ac: Don't configure gnulib.
2095         * configure: Rebuild.
2096         * common/common-defs.h: Use new path to gnulib.
2097         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2098         (GNULIB_H): Remove.
2099         (INCGNU): Look in new gnulib location.
2100         (HFILES_NO_SRCDIR): Remove gnulib files.
2101         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2102         (generated_files): Remove GNULIB_H.
2103         ($(LIBGNU), all-lib): Remove targets.
2104         (distclean): Don't mention GNULIB_BUILDDIR.
2105         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2106
2107 2019-06-14  Tom Tromey  <tromey@adacore.com>
2108
2109         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2110         Warn if symbol file does not provide any symbols.
2111
2112 2019-06-14  Tom Tromey  <tromey@adacore.com>
2113
2114         * source.c (find_and_open_source): Respect basenames_may_differ.
2115
2116 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2117
2118         * annotate.c (annotate_breakpoints_invalid): Make use of
2119         scoped_restore_terminal_state.
2120         (annotate_frames_invalid): Likewise.
2121
2122 2019-06-14  Tom Tromey  <tromey@adacore.com>
2123
2124         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2125         allow assignment to an internalvar.
2126
2127 2019-06-14  Tom Tromey  <tromey@adacore.com>
2128
2129         * ada-lex.l: Allow "_" in attribute names.
2130
2131 2019-06-14  Tom Tromey  <tromey@adacore.com>
2132
2133         PR gdb/24653:
2134         * regcache.c (registers_changed): Don't call alloca.
2135         * top.c (execute_command): Don't call alloca.
2136
2137 2019-06-13  Pedro Alves  <palves@redhat.com>
2138
2139         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2140         'expression'.  When parsing an expression, error out if there's
2141         junk after "unlimited".
2142         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2143         (do_set_command): Adjust calls to is_unlimited_literal.
2144
2145 2019-06-13  Pedro Alves  <palves@redhat.com>
2146
2147         * compile/compile.c (make_compile_options_def_group): Add braces
2148         around array_view initializer.
2149         * thread.c (make_thread_apply_all_options_def_group)
2150         (make_thread_apply_all_options_def_group): Likewise.
2151
2152 2019-06-13  Pedro Alves  <palves@redhat.com>
2153
2154         * NEWS (New commands): Mention "maint test-options
2155         require-delimiter", "maint test-options unknown-is-error", "maint
2156         test-options unknown-is-operand" and "maint show
2157         test-options-completion-result".
2158         (New command options, command completion): New section.
2159         (Completion improvements): New section.
2160         Mention that you can abbreviate "unlimited".
2161
2162 2019-06-13  Pedro Alves  <palves@redhat.com>
2163
2164         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2165         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2166         * unittests/cli-utils-selftests.c (test_parse_flags)
2167         (test_parse_flags_qcs): Delete.
2168         (test_cli_utils): Don't call deleted functions.
2169
2170 2019-06-13  Pedro Alves  <palves@redhat.com>
2171
2172         * thread.c: Include "cli/cli-option.h".
2173         (tp_array_compar_ascending): Global.
2174         (tp_array_compar): Delete function.
2175         (tp_array_compar_ascending, tp_array_compar_descending): New
2176         functions.
2177         (ascending_option_def, qcs_flag_option_def)
2178         (thr_qcs_flags_option_defs)
2179         (make_thread_apply_all_options_def_group)
2180         (make_thread_apply_options_def_group): New.
2181         (thread_apply_all_command): Use gdb::option::process_options.
2182         (thread_apply_command_completer)
2183         (thread_apply_all_command_completer): New.
2184         (thread_apply_command): Use gdb::option::process_options.
2185         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2186         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2187         to generate help text of "thread apply".  Adjust "taas"'s help.
2188         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2189         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2190
2191 2019-06-13  Pedro Alves  <palves@redhat.com>
2192
2193         * thread.c (thread_apply_command): Check for invalid TID with
2194         isdigit instead of !isalpha.
2195
2196 2019-06-13  Pedro Alves  <palves@redhat.com>
2197
2198         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2199         (validate_flags_qcs): New.
2200         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2201         (validate_flags_qcs): Declare.
2202         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2203         (make_frame_apply_options_def_group): New.
2204         (frame_apply_command_count): Process options with
2205         gdb::option::process_options.
2206         (frame_apply_completer): New.
2207         (frame_apply_level_completer, frame_apply_all_completer)
2208         (frame_apply_completer): New.
2209         (_initialize_stack): Update help of "frame apply", "frame apply
2210         level", "frame apply all" and "faas" to mention supported options
2211         and install command completers.
2212         * stack.h (frame_apply_all_completer): Declare.
2213         * thread.c: Include "stack.h".
2214         (tfaas_command): Add "--".
2215         (_initialize_thread): Update help "tfaas" to mention supported
2216         options and install command completer.
2217
2218 2019-06-13  Pedro Alves  <palves@redhat.com>
2219
2220         * completer.c (complete_nested_command_line): New.
2221         (gdb_completion_word_break_characters_throw): Add assertion.
2222         * completer.h (complete_nested_command_line): Declare.
2223
2224 2019-06-13  Pedro Alves  <palves@redhat.com>
2225
2226         * stack.c (parse_backtrace_qualifiers): New.
2227         (backtrace_command): Use it.
2228         (backtrace_command_completer): Complete on qualifiers.
2229
2230 2019-06-13  Pedro Alves  <palves@redhat.com>
2231
2232         * frame.c: Include "cli/cli-option.h.
2233         (user_set_backtrace_options): New.
2234         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2235         Delete.
2236         (get_prev_frame): Adjust.
2237         (boolean_option_def, uinteger_option_def)
2238         (set_backtrace_option_defs): New.
2239         (_initialize_frame): Adjust and use
2240         gdb::option::add_setshow_cmds_for_options to install "set
2241         backtrace past-main" and "set backtrace past-entry".
2242         * frame.h: Include "cli/cli-option.h".
2243         (struct frame_print_options): Forward declare.
2244         (print_frame_arguments_all, print_frame_arguments_scalars)
2245         (print_frame_arguments_none): Declare.
2246         (print_entry_values): Delete declaration.
2247         (struct frame_print_options, user_frame_print_options): New.
2248         (struct set_backtrace_options): New.
2249         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2250         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2251         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2252         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2253         (list_args_or_locals): Add frame_print_options parameter.
2254         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2255         * python/py-framefilter.c (enumerate_args): Pass down
2256         USER_FRAME_PRINT_OPTIONS.
2257         * stack.c: Include "cli/cli-option.h".
2258         (print_frame_arguments_all, print_frame_arguments_scalars)
2259         (print_frame_arguments_none): Declare.
2260         (print_raw_frame_arguments, print_entry_values): Delete.
2261         (user_frame_print_options): New.
2262         (boolean_option_def, enum_option_def, frame_print_option_defs):
2263         New.
2264         (struct backtrace_cmd_options): New.
2265         (bt_flag_option_def): New.
2266         (backtrace_command_option_defs): New.
2267         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2268         (print_frame_arg, read_frame_arg, print_frame_args)
2269         (print_frame_info, print_frame): Add frame_print_options parameter
2270         and use it.
2271         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2272         (backtrace_command_1): Add frame_print_options and
2273         backtrace_cmd_options parameters and use them.
2274         (make_backtrace_options_def_group): New.
2275         (backtrace_command): Process command options with
2276         gdb::option::process_options.
2277         (backtrace_command_completer): New.
2278         (_initialize_stack): Extend "backtrace"'s help to mention
2279         supported options.  Install completer for "backtrace".
2280         Install some settings commands with add_setshow_cmds_for_options.
2281
2282 2019-06-13  Pedro Alves  <palves@redhat.com>
2283
2284         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2285         and that "set/show print raw frame-arguments" are now deprecated.
2286
2287         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2288         command.
2289         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2290         * stack.c (_initialize_stack): Install "set/show print
2291         raw-frame-arguments", and deprecate "set/show print raw
2292         frame-arguments".
2293         * valprint.c (_initialize_valprint): Deprecate "set/show print
2294         raw".
2295
2296 2019-06-13  Pedro Alves  <palves@redhat.com>
2297
2298         * compile/compile.c (struct compile_options): New.
2299         (compile_flag_option_def, compile_command_option_defs)
2300         (make_compile_options_def_group): New.
2301         (compile_file_command): Handle options with
2302         gdb::option::process_options.
2303         (compile_file_command_completer): New function.
2304         (compile_code_command): Handle options with
2305         gdb::option::process_options.
2306         (compile_code_command_completer): New function.
2307         (_initialize_compiler): Install completers for "compile code" and
2308         "compile file".  Mention available options in "compile code" and
2309         "compile code"'s help.
2310         * completer.c (advance_to_completion_word): New, factored out from
2311         ...
2312         (advance_to_expression_complete_word_point): ... this.
2313         (advance_to_filename_complete_word_point): New.
2314         * completer.h (advance_to_filename_complete_word_point): New
2315         declaration.
2316
2317 2019-06-13  Pedro Alves  <palves@redhat.com>
2318
2319         * compile/compile.c: Include "cli/cli-option.h".
2320         (compile_print_value): Scope data pointer is now a
2321         value_print_options pointer; adjust.
2322         (compile_print_command): Process options.  Scope data pointer is
2323         now a value_print_options pointer; adjust.
2324         (_initialize_compile): Update "compile print"'s help to include
2325         supported options.  Install a completer for "compile print".
2326         * cp-valprint.c (show_vtblprint, show_objectprint)
2327         (show_static_field_print): Delete.
2328         (_initialize_cp_valprint): Don't install "set print
2329         static-members", "set print vtbl", "set print object" here.
2330         * printcmd.c: Include "cli/cli-option.h" and
2331         "common/gdb_optional.h".
2332         (print_command_parse_format): Rework to fill in a
2333         value_print_options instead of a format_data.
2334         (print_value): Change parameter type from format_data pointer to
2335         value_print_options reference.  Adjust.
2336         (print_command_1): Process options.  Adjust to pass down a
2337         value_print_options.
2338         (print_command_completer): New.
2339         (_initialize_printcmd): Install print_command_completer as
2340         handle_brkchars completer for the "print" command.  Update
2341         "print"'s help to include supported options.
2342         * valprint.c: Include "cli/cli-option.h".
2343         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2344         here from cp-valprint.c.
2345         (boolean_option_def, uinteger_option_def)
2346         (value_print_option_defs, make_value_print_options_def_group):
2347         New.  Use gdb::option::add_setshow_cmds_for_options to install
2348         "set print elements", "set print null-stop", "set print repeats",
2349         "set print pretty", "set print union", "set print array", "set
2350         print address", "set print symbol", "set print array-indexes".
2351         * valprint.h: Include <string> and "cli/cli-option.h".
2352         (make_value_print_options_def_group): Declare.
2353         (print_value): Change parameter type from format_data pointer to
2354         value_print_options reference.
2355         (print_command_completer): Declare.
2356
2357 2019-06-13  Pedro Alves  <palves@redhat.com>
2358
2359         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2360         (COMMON_SFILES): Add maint-test-settings.c.
2361         * cli/cli-decode.c (boolean_enums): New global, factored out from
2362         ...
2363         (add_setshow_boolean_cmd): ... here.
2364         * cli/cli-decode.h (boolean_enums): Declare.
2365         * cli/cli-option.c: New file.
2366         * cli/cli-option.h: New file.
2367         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2368         factored out from ...
2369         (parse_cli_boolean_value(const char *)): ... this.
2370         (is_unlimited_literal): Change parameter type to pointer to
2371         pointer.  Adjust and advance ARG pointer.
2372         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2373         (parse_cli_var_enum): New, factored out from ...
2374         (do_set_command): ... this.  Adjust.
2375         * cli/cli-setshow.h (parse_cli_boolean_value)
2376         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2377         (parse_cli_var_enum): Declare.
2378         * cli/cli-utils.c: Include "cli/cli-option.h".
2379         (get_ulongest): New.
2380         * cli/cli-utils.h (get_ulongest): Declare.
2381         (check_for_argument): New overloads.
2382         * maint-test-options.c: New file.
2383
2384 2019-06-13  Pedro Alves  <palves@redhat.com>
2385
2386         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2387         parse a range if "-" is at the end of the string.
2388
2389 2019-06-13  Pedro Alves  <palves@redhat.com>
2390
2391         * cli/cli-setshow.c (parse_auto_binary_operation)
2392         (parse_cli_boolean_value): Don't allow "o".
2393
2394 2019-06-13  Pedro Alves  <palves@redhat.com>
2395
2396         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2397         * NEWS: Mention maint test-settings KIND.
2398         * maint-test-settings.c: New file.
2399
2400 2019-06-13  Pedro Alves  <palves@redhat.com>
2401
2402         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2403         completer.
2404         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2405         "set" completers.
2406
2407 2019-06-13  Pedro Alves  <palves@redhat.com>
2408
2409         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2410         after item.
2411
2412 2019-06-13  Pedro Alves  <palves@redhat.com>
2413
2414         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2415
2416 2019-06-13  Pedro Alves <palves@redhat.com>
2417
2418         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2419         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2420         call.
2421         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2422         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2423         calls.
2424         (check_for_argument): Skip spaces after argument.
2425
2426 2019-06-13  Pedro Alves  <palves@redhat.com>
2427
2428         * thread.c (thread_apply_command): Adjust TID parsing.
2429         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2430         detected before end of string.
2431         (tid_is_in_list): Error out if LIST is invalid.
2432
2433 2019-06-13  Pedro Alves  <palves@redhat.com>
2434
2435         * completer.c (complete_line_internal_1): Rewind completion word
2436         point.
2437         (completion_tracker::advance_custom_word_point_by): Change
2438         parameter type to int.
2439         * completer.h (completion_tracker::advance_custom_word_point_by):
2440         Likewise.
2441
2442 2019-06-13  Pedro Alves  <palves@redhat.com>
2443
2444         * completer.c (advance_to_completion_word): Handle delimiters.
2445
2446 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2447
2448         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2449
2450 2019-06-11  Tom Tromey  <tom@tromey.com>
2451
2452         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2453         (xmalloc_failed): Move to alloc.c.
2454         * alloc.c: New file.
2455         * Makefile.in (COMMON_SFILES): Add alloc.c.
2456
2457 2019-06-11  Tom Tromey  <tom@tromey.com>
2458
2459         * nat/linux-waitpid.c: Don't include server.h.
2460         (linux_debug): Remove.
2461         (my_waitpid): Update.
2462
2463 2019-06-11  Tom Tromey  <tromey@adacore.com>
2464
2465         * infcall.c (_initialize_infcall): Remove trailing newline from
2466         help.
2467         * user-regs.c (_initialize_user_regs): Remove trailing newline
2468         from help.
2469         * typeprint.c (_initialize_typeprint): Remove trailing newline
2470         from help.
2471         * reverse.c (_initialize_reverse): Remove trailing newlines from
2472         help.
2473         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2474         from help.
2475         * language.c (add_set_language_command): Remove trailing newline
2476         from help.
2477         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2478         help.
2479         * disasm.c (_initialize_disasm): Remove trailing newline from
2480         help.
2481         * top.c (init_main): Remove trailing newline from help.
2482         * interps.c (_initialize_interpreter): Remove trailing newline
2483         from help.
2484         * btrace.c (_initialize_btrace): Remove trailing newlines from
2485         help.
2486         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2487         from help.
2488         * python/python.c (_initialize_python): Remove trailing newline
2489         from help.
2490         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2491         help.
2492         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2493         from help.  Reformat some text.
2494         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2495         from help.
2496         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2497         newline from help.
2498
2499 2019-06-11  Tom Tromey  <tromey@adacore.com>
2500
2501         * darwin-nat.c (darwin_decode_exception_message)
2502         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2503
2504 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * valops.c (value_slice): Check for not allocated or not
2507         associated values.
2508
2509 2019-06-10  Tom de Vries  <tdevries@suse.de>
2510
2511         PR gdb/24618
2512         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2513         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2514         invalid.
2515
2516 2019-06-10  Tom de Vries  <tdevries@suse.de>
2517
2518         PR gdb/24611
2519         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2520         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2521
2522 2019-06-10  Tom de Vries  <tdevries@suse.de>
2523
2524         PR symtab/24545
2525         * symtab.c (struct demangled_name_entry): Add language field.
2526         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2527         static minimal symbol".  Set and use language field.
2528
2529 2019-06-10  Tom Tromey  <tromey@adacore.com>
2530
2531         * ada-lang.c (_initialize_ada_language): Update help text.
2532
2533 2019-06-10  Tom Tromey  <tromey@adacore.com>
2534
2535         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2536         with a newline.
2537         * guile/guile.c (handle_boot_error): Don't end warning with a
2538         newline.
2539         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2540         warning with a newline.
2541         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2542         newline.
2543         (s12z_frame_cache): Likewise.
2544         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2545         a newline.
2546         * solib-svr4.c (disable_probes_interface): Don't end warning with
2547         a newline.
2548         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2549         newline.
2550         * python/python.c (do_finish_initialization): Don't end warning
2551         with a newline.
2552
2553 2019-06-10  Tom Tromey  <tom@tromey.com>
2554
2555         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2556         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2557         gdbpy_enter.
2558
2559 2019-06-10  Tom Tromey  <tromey@adacore.com>
2560
2561         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2562         data.
2563         (elf_new_init): Don't call stabsread_new_init.
2564         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2565         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2566         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2567
2568 2019-06-10  Tom de Vries  <tdevries@suse.de>
2569
2570         PR symtab/16264
2571         PR symtab/24517
2572         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2573
2574 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2575
2576         * source.c (find_and_open_source): Also rewrite relative file
2577         names.
2578
2579 2019-04-26  Amos Bird  <amosbird@gmail.com>
2580
2581         * annotate.c (annotate_thread_exited): Add "thread-exited"
2582         annotation.
2583
2584 2019-06-06  Tom Tromey  <tromey@adacore.com>
2585
2586         * maint.h (class scoped_command_stats): Use
2587         DISABLE_COPY_AND_ASSIGN.
2588         <print_time>: New method.
2589         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2590         print_time.
2591         (scoped_command_stats::print_time): New method.
2592
2593 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2594
2595         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2596         instructions of lengths 6 or 8 bytes.
2597
2598 2019-06-04  Pedro Alves  <palves@redhat.com>
2599
2600         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2601
2602         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2603         * breakpoint.c (condition_completer): Likewise.
2604         * cli/cli-dump.c (scan_expression): Likewise.
2605         * common/filestuff.c (mkdir_recursive): Likewise.
2606         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2607         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2608         (gdb_abspath): Likewise.
2609         * compile/compile-cplus-types.c
2610         (compile_cplus_instance::decl_name): Likewise.
2611         * completer.c (complete_explicit_location):
2612         (signal_completer, reg_or_group_completer_1): Likewise.
2613         * cp-support.c (cp_remove_params_if_any): Likewise.
2614         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2615         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2616         * infcmd.c (strip_bg_char): Likewise.
2617         * linespec.c (copy_token_string): Likewise.
2618         * mi/mi-main.c (output_cores): Likewise.
2619         * psymtab.c (psymtab_search_name):
2620         * symfile.c (test_set_ext_lang_command): Likewise.
2621         * target.c (target_fileio_read_stralloc): Likewise.
2622         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2623         * value.c (complete_internalvar): Likewise.
2624
2625 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2626
2627         Add objfile property to gdb.Type.
2628         * NEWS: Mention Python API addition.
2629         * python/py-type.c (typy_get_objfile): New method.
2630
2631 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2632
2633         * NEWS: Mention the new set|show style [title|highlight].
2634         Mention changes to "show style", "help" and "apropos".
2635
2636 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2637
2638         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2639         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2640         instead of print_help_for_command.
2641         (print_doc_of_command): New function.
2642         (help_list): Add 'apropos -v word' suggestion.
2643         (print_help_for_command): Style the command name using title style.
2644         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2645         (_initialize_cli_cmds): Describe -v in apropos_command help.
2646
2647 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2648
2649         * cli/cli-style.h (cli_style_option): Add name in constructor,
2650         add m_name class member, add constructor with intensity,
2651         add name class function.
2652         (cli_style_option::add_setshow_commands): Remove name argument.
2653         (highlight_style, title_style): New styles.
2654         * cli/cli-style.c (do_show): New function that shows a style
2655         characteristic styling the style name with itself.
2656         (set_style_name): New function.
2657         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2658         Update all callers according to the changes in cli/cli-style.h.
2659         * utils.h (fputs_highlighted): New function.
2660         * utils.c (fputs_highlighted): Likewise.
2661
2662 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2663
2664         * NEWS: Mention new pipe command and new convenience variables.
2665
2666 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2667
2668         * cli/cli-cmds.c (pipe_command): New function.
2669         (_initialize_cli_cmds): Call add_com for pipe_command.
2670         Define | as an alias for pipe.
2671         (exit_status_set_internal_vars): New function.
2672         (shell_escape): Call exit_status_set_internal_vars.
2673         cli/cli-decode.c (find_command_name_length): Recognize | as
2674         a single character command.
2675
2676 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2677
2678         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2679         top.c (execute_command_to_ui_file): New function, mostly a copy
2680         of execute_command_to_string.
2681         (execute_command_to_string): Implement by calling
2682         execute_command_to_ui_file.
2683
2684 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2685
2686         * top.h (saved_command_line): Remove declaration.
2687         * top.c (previous_saved_command_line, previous_repeat_arguments):
2688         New variables.
2689         (saved_command_line): Make static, define together with other
2690         'repeat variables'.
2691         (dont_repeat): Clear repeat_arguments.
2692         (repeat_previous, get_saved_command_line, save_command_line):
2693         New functions.
2694         (gdb_init): Initialize saved_command_line
2695         and previous_saved_command_line.
2696         * main.c (captured_main_1): Remove saved_command_line initialization.
2697         * event-top.c (handle_line_of_input): Update to use
2698         the new 'repeat' related functions instead of direct access to
2699         saved_command_line.
2700         * command.h (repeat_previous, get_saved_command_line,
2701         save_command_line): New declarations.
2702         (dont_repeat): Add comment.
2703
2704 2019-05-30  Tom Tromey  <tromey@adacore.com>
2705
2706         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2707         Fix comment.
2708         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2709
2710 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2711
2712         PR cli/24587
2713         * completer.c (complete): Initialize variable word.
2714
2715 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2716
2717         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2718         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2719         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2720         'body' is NULL to the outter 'if', protecting the '!is_define'
2721         situation as well.
2722
2723 2019-05-29  Tom Tromey  <tromey@adacore.com>
2724
2725         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2726         (dwarf_unknown): New function.
2727         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2728         (dwarf_type_encoding_name): Use dwarf_unknown.
2729
2730 2019-05-29  Tom Tromey  <tromey@adacore.com>
2731
2732         PR c++/20020:
2733         * cp-valprint.c (cp_print_value_fields): Call
2734         cp_print_static_field inside "try".
2735
2736 2019-05-29  Tom Tromey  <tromey@adacore.com>
2737
2738         * inflow.c (struct terminal_info): Add default operator=.
2739         * configure: Rebuild.
2740         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2741         -Wdeprecated-copy-dtor, -Wredundant-move.
2742
2743 2019-05-29  Tom Tromey  <tromey@adacore.com>
2744
2745         * NEWS: Add entry.
2746         * infcmd.c (print_return_value_1): Handle finish_print
2747         option.
2748         (show_print_finish): New function.
2749         (_initialize_infcmd): Add "set/show print finish" commands.
2750         * valprint.c (user_print_options): Initialize new member.
2751         * valprint.h (struct value_print_options) <finish_print>: New
2752         member.
2753
2754 2019-05-28  Tom Tromey  <tromey@adacore.com>
2755
2756         * ada-lang.c (ada_remove_Xbn_suffix)
2757         (find_old_style_renaming_symbol)
2758         (parse_old_style_renaming): Remove.
2759         (ada_find_renaming_symbol): Don't call
2760         find_old_style_renaming_symbol.
2761         (ada_is_renaming_symbol): Rename from
2762         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2763         bool.  Now static.
2764         (ada_read_var_value): Update and simplify.
2765         * ada-exp.y (write_var_or_type): Remove old code.
2766
2767 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2768
2769         * event-top.c: Remove include comment.
2770         * inflow.c (class scoped_ignore_sigttou): Move from here...
2771         * inflow.h (class scoped_ignore_sigttou): ...to here.
2772         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2773         * top.c:  Remove include comment.
2774
2775 2019-05-27  Tom Tromey  <tom@tromey.com>
2776
2777         * NEWS: Fix typo.
2778
2779 2019-05-22  Tom Tromey  <tromey@adacore.com>
2780
2781         * target.c (target_follow_exec): Constify parameter.
2782         * target-delegates.c: Rebuild.
2783         * remote.c (remote_target::follow_exec): Constify parameter.
2784         * infrun.c (follow_exec): Constify parameter.
2785         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2786         (target_follow_exec): Likewise.
2787
2788 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2789
2790         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2791         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2792
2793 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2794
2795         * NEWS: Add debugredirect and testsuite sections.
2796
2797 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2798
2799         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2800         target descriptions using exclusively floating point register name
2801         aliases.
2802
2803 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2804
2805         PR gdb/18644:
2806         * f-lang.c (build_fortran_types): Handle the case where
2807         gdbarch_floatformat_for_type returns a nullptr.
2808
2809 2019-05-21  Tom de Vries  <tdevries@suse.de>
2810
2811         PR cli/24587
2812         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2813
2814 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         PR gdb/18644:
2817         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2818         16-byte floats.
2819         * i386-tdep.c (i386_floatformat_for_type): Use
2820         floatformats_ia64_quad for the 16-byte floating point component
2821         within a fortran 32-byte complex number.
2822
2823 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2826         delete default constructor.
2827         (find_partial_die): Update to return const struct.
2828         (partial_die_parent_scope): Move variable declaration into scope
2829         of its use and change its type to auto.
2830         (guess_partial_die_structure_name): Likewise.
2831         (partial_die_info::fixup): Likewise.
2832
2833 2019-05-17  Tom Tromey  <tromey@adacore.com>
2834
2835         * source.c (find_and_open_source): Remove cast.
2836
2837 2019-05-17  Tom Tromey  <tromey@adacore.com>
2838
2839         * annotate.c (annotate_source): Make "filename" const.
2840         * annotate.h (annotate_source): Use const.
2841
2842 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2843
2844         * disasm.c (set_disassembler_options): Send errors to stderr.
2845
2846 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2847
2848         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2849         (cli_interp_base::set_logging): Check debug_redirect.
2850         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2851         * cli/cli-logging.c (debug_redirect): Add static variable.
2852         (pop_output_files): Add default param.
2853         (handle_redirections): Print debug setting.
2854         (show_logging_command): Likewise.
2855         (_initialize_cli_logging): Add debugredirect command.
2856         * interps.c (current_interp_set_logging): Add debug_redirect
2857         parameter.
2858         * interps.h (set_logging): Add debug_redirect parameter.
2859         (current_interp_set_logging): Likewise.
2860         * mi/mi-common.h: Likewise.
2861         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2862
2863 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2864             Tom Tromey  <tromey@adacore.com>
2865
2866         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2867         directly.
2868         * cli/cli-interp.h (make_logging_output): Remove declaration.
2869         * cli/cli-logging.c (make_logging_output): Remove function.
2870         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2871         directly.
2872         * ui-file.c (tee_file::tee_file): Remove bools.
2873         (tee_file::~tee_file): Remove deletes.
2874         * ui-file.h (tee_file): Remove bools.
2875
2876 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2877
2878         * mi/mi-cmds.h (mi_cmd_complete): New function.
2879         * mi/mi-main.c (mi_cmd_complete): Likewise.
2880         * mi/mi-cmds.c: Define new MI command -complete.
2881         * NEWS: Mention new -complete command.
2882
2883 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2884
2885         * completer.h (complete): New function.
2886         * completer.c (complete): Likewise.
2887         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2888         function defined in completer.h.
2889
2890 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2891
2892         * MAINTAINERS (Write After Approval): Add myself.
2893
2894 2019-05-17  Tom de Vries  <tdevries@suse.de>
2895
2896         PR gdb/24094
2897         * dwarf2read.c (struct cu_partial_die_info): New struct.
2898         (find_partial_die): Return cu_partial_die_info.
2899         (partial_die_parent_scope, guess_partial_die_structure_name)
2900         (partial_die_info::fixup): Handle new return type of find_partial_die.
2901
2902 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2903
2904         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2905         "std::string", simplifying the algorithm.
2906
2907 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2908
2909         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2910         (stap_static_probe_ops::get_probes): Likewise.
2911
2912 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2913
2914         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2915         '-')" and "else if".
2916         (stap_parse_single_operand): Join checks for
2917         "gdbarch_stap_parse_special_token_p" and
2918         "gdbarch_stap_parse_special_token" in the same "if" statement.
2919         Invert check when verifying for operation on register
2920         displacement.
2921
2922 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2923
2924         * stap-probe.c (stap_get_opcode): Update comment.
2925         (stap_get_expected_argument_type): Likewise.
2926         (handle_stap_probe): Likewise.
2927
2928 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2929
2930         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2931         return type to 'bool'.  Adjust comment.  Use 'bool' when
2932         appropriate.
2933         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2934         * stap-probe.c (stap_parse_argument_1): Likewise.
2935         (stap_is_operator): Likewise.
2936         (stap_is_generic_prefix): Likewise.
2937         (stap_is_register_prefix): Likewise.
2938         (stap_is_register_indirection_prefix): Likewise.
2939         (stap_is_integer_prefix): Likewise.
2940         (stap_generic_check_suffix): Likewise.
2941         (stap_check_integer_suffix): Likewise.
2942         (stap_check_register_suffix): Likewise.
2943         (stap_check_register_indirection_suffix): Likewise.
2944         (stap_parse_register_operand): Likewise.
2945         (stap_parse_single_operand): Likewise.
2946         (stap_parse_argument_1): Likewise.
2947         (stap_probe::get_argument_count): Likewise.
2948         (stap_is_operator): Likewise.
2949
2950 2019-05-16  Tom Tromey  <tromey@adacore.com>
2951
2952         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2953         keyword to foreach.
2954
2955 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2956
2957         * linux-thread-db.c (try_thread_db_load_1): Change return type
2958         to bool.
2959         (try_thread_db_load): Likewise.
2960         (try_thread_db_load_from_pdir_1): Likewise.
2961         (try_thread_db_load_from_pdir): Likewise.
2962         (try_thread_db_load_from_sdir): Likewise.
2963         (try_thread_db_load_from_dir): Likewise.
2964         (thread_db_load_search): Likewise.
2965         (has_libpthread): Likewise.
2966         (thread_db_load): Likewise.
2967
2968 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2969
2970         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2971         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2972         NULL, and complain/return if that's the case.
2973
2974 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2975
2976         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2977         (advance, posn, abstract_read_memory): New functions.
2978         [struct mem_read_abstraction]: New struct.
2979         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2980
2981 2019-05-14  Tom Tromey  <tromey@adacore.com>
2982
2983         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2984         value is not lval_memory.
2985
2986 2019-05-14  Tom Tromey  <tromey@adacore.com>
2987
2988         * solib.c (info_sharedlibrary_command): Style the file name.
2989
2990 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2991
2992         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2993         (aarch64_vnv_type): Likewise.
2994         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2995         * common/tdesc.c: Likewise.
2996         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2997         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2998         * features/aarch64-fpu.xml: Add ieee half view.
2999         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3000         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3001         * gdbtypes.h (struct builtin_type): Likewise.
3002         (struct objfile_type): Likewise.
3003
3004 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3005
3006         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3007         typo.
3008         * location.h (string_to_event_location): Likewise.
3009
3010 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3011
3012         GDB 8.3 released.
3013
3014 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3015
3016         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3017         New variable declaration.
3018         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3019         New variable.
3020         (print_one_breakpoint): Use ui_out::test_flags and new global
3021         variable to compute use_fixed_output.
3022         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3023         Remove.
3024         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3025         (mi_multi_location_breakpoint_output_fixed): Remove.
3026         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3027         new variable.
3028         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3029         fix_multi_location_breakpoint_output flag if version >= 3.
3030         * ui-out.h (enum ui_out_flag)
3031         <fix_multi_location_breakpoint_output>: New enumerator.
3032
3033 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3034
3035         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3036
3037 2019-05-10  Tom Tromey  <tromey@adacore.com>
3038
3039         * ada-lang.c (catch_ada_completer): New function.
3040         (_initialize_ada_language): Use it.
3041
3042 2019-05-10  Tom Tromey  <tromey@adacore.com>
3043
3044         * thread.c (print_thread_info): Make "requested_threads" const.
3045         * gdbthread.h (print_thread_info): Make "requested_threads"
3046         const.
3047         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3048         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3049
3050 2019-05-08  Tom Tromey  <tom@tromey.com>
3051
3052         * gdbtypes.c (objfile_type_data): Change type.
3053         (objfile_type, _initialize_gdbtypes): Update.
3054
3055 2019-05-08  Tom Tromey  <tom@tromey.com>
3056
3057         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3058         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3059         (_initialize_dwarf2_frame): Update.
3060
3061 2019-05-08  Tom Tromey  <tom@tromey.com>
3062
3063         * objc-lang.c (objc_objfile_data): Change type.
3064         (find_methods): Update.
3065         (_initialize_objc_lang): Remove.
3066
3067 2019-05-08  Tom Tromey  <tom@tromey.com>
3068
3069         * stabsread.c (rs6000_builtin_type_data): Change type.
3070         (rs6000_builtin_type, _initialize_stabsread): Update.
3071
3072 2019-05-08  Tom Tromey  <tom@tromey.com>
3073
3074         * mips-tdep.c (mips_pdr_data): Remove.
3075         (_initialize_mips_tdep): Update.
3076
3077 2019-05-08  Tom Tromey  <tom@tromey.com>
3078
3079         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3080         (hppa_init_objfile_priv_data, read_unwind_info)
3081         (find_unwind_entry, _initialize_hppa_tdep): Update.
3082
3083 2019-05-08  Tom Tromey  <tom@tromey.com>
3084
3085         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3086         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3087         on obstack.
3088         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3089
3090 2019-05-08  Tom Tromey  <tom@tromey.com>
3091
3092         * mdebugread.c (basic_type_data): Change type.
3093         (basic_type, _initialize_mdebugread): Update.
3094
3095 2019-05-08  Tom Tromey  <tom@tromey.com>
3096
3097         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3098
3099 2019-05-08  Tom Tromey  <tom@tromey.com>
3100
3101         * nto-tdep.c (nto_inferior_data_reg): Change type.
3102         (nto_inferior_data): Update.
3103         (nto_inferior_data_cleanup, nto_new_inferior_data)
3104         (_initialize_nto_tdep): Remove.
3105         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3106
3107 2019-05-08  Tom Tromey  <tom@tromey.com>
3108
3109         * ada-lang.c (struct ada_inferior_data): Add initializers.
3110         (ada_inferior_data): Change type.
3111         (ada_inferior_data_cleanup): Remove.
3112         (get_ada_inferior_data, ada_inferior_exit)
3113         (struct ada_pspace_data): Add initializers, destructor.
3114         (ada_pspace_data_handle): Change type.
3115         (get_ada_pspace_data): Update.
3116         (ada_pspace_data_cleanup): Remove.
3117
3118 2019-05-08  Tom Tromey  <tom@tromey.com>
3119
3120         * coffread.c (struct coff_symfile_info): Add initializers.
3121         (coff_objfile_data_key): Move lower.  Change type.
3122         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3123         Update.
3124         (coff_free_info): Remove.
3125
3126 2019-05-08  Tom Tromey  <tom@tromey.com>
3127
3128         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3129         (fbsd_pspace_data_handle): Move lower.  Change type.
3130         (get_fbsd_pspace_data): Update.
3131         (fbsd_pspace_data_cleanup): Remove.
3132         (_initialize_fbsd_tdep): Update.
3133
3134 2019-05-08  Tom Tromey  <tom@tromey.com>
3135
3136         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3137         (get_ada_tasks_pspace_data): Update.
3138         (ada_tasks_pspace_data_cleanup): Remove.
3139         (_initialize_tasks): Update.
3140         (ada_tasks_inferior_data_handle): Change type.
3141         (get_ada_tasks_inferior_data): Update.
3142         (ada_tasks_inferior_data_cleanup): Remove.
3143         (struct ada_tasks_pspace_data): Add initializers.
3144
3145 2019-05-08  Tom Tromey  <tom@tromey.com>
3146
3147         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3148         * symfile-debug.c (debug_sym_get_probes): Change type.
3149         * stap-probe.c (handle_stap_probe):
3150         (stap_static_probe_ops::get_probes): Change type.
3151         * probe.h (class static_probe_ops) <get_probes>: Change type.
3152         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3153         (parse_probes_in_pspace): Update.
3154         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3155         Update.
3156         (any_static_probe_ops::get_probes): Change type.
3157         * elfread.c (elfread_data): New typedef.
3158         (probe_key): Change type.
3159         (elf_get_probes): Likewise.  Update.
3160         (probe_key_free): Remove.
3161         (_initialize_elfread): Update.
3162         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3163         Change type.
3164         (dtrace_process_dof_probe, dtrace_process_dof)
3165         (dtrace_static_probe_ops::get_probe): Change type.
3166
3167 2019-05-08  Tom Tromey  <tom@tromey.com>
3168
3169         * xcoffread.c (struct xcoff_symfile_info): Rename from
3170         coff_symfile_info.  Add initializers.
3171         (xcoff_objfile_data_key): Move lower.  Change type.
3172         (XCOFF_DATA): Rewrite.
3173         (xcoff_free_info): Remove.
3174         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3175         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3176         (xcoff_initial_scan): Update.
3177
3178 2019-05-08  Tom Tromey  <tom@tromey.com>
3179
3180         * solib-svr4.c (struct svr4_info): Add initializers and
3181         destructor.
3182         <probes_table>: Now an htab_up.
3183         (solib_svr4_pspace_data): Change type.
3184         (free_probes_table): Simplify.
3185         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3186         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3187         (probes_table_remove_objfile_probes, register_solib_event_probe)
3188         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3189         (_initialize_svr4_solib): Update.
3190
3191 2019-05-08  Tom Tromey  <tom@tromey.com>
3192
3193         * remote.c (remote_pspace_data): Change type.
3194         (remote_pspace_data_cleanup): Remove.
3195         (get_remote_exec_file, set_pspace_remote_exec_file)
3196         (_initialize_remote): Update.
3197
3198 2019-05-08  Tom Tromey  <tom@tromey.com>
3199
3200         * breakpoint.c (breakpoint_objfile_key): Change type.
3201         (get_breakpoint_objfile_data): Update.
3202         (free_breakpoint_objfile_data): Remove.
3203         (_initialize_breakpoint): Update.
3204
3205 2019-05-08  Tom Tromey  <tom@tromey.com>
3206
3207         * linux-tdep.c (struct linux_info): Add initializers.
3208         (linux_inferior_data): Move.  Change type.
3209         (invalidate_linux_cache_inf): Update.
3210         (linux_inferior_data_cleanup): Remove.
3211         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3212
3213 2019-05-08  Tom Tromey  <tom@tromey.com>
3214
3215         * auxv.c (auxv_inferior_data): Move.  Change type.
3216         (auxv_inferior_data_cleanup): Remove.
3217         (invalidate_auxv_cache_inf): Rewrite.
3218         (get_auxv_inferior_data, _initialize_auxv): Update.
3219
3220 2019-05-08  Tom Tromey  <tom@tromey.com>
3221
3222         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3223         (symfile_debug_objfile_data_key): Change type.
3224         (symfile_debug_installed, debug_qf_has_symbols)
3225         (debug_qf_find_last_source_symtab)
3226         (debug_qf_forget_cached_source_info)
3227         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3228         (debug_qf_print_stats, debug_qf_dump)
3229         (debug_qf_expand_symtabs_for_function)
3230         (debug_qf_expand_all_symtabs)
3231         (debug_qf_expand_symtabs_with_fullname)
3232         (debug_qf_map_matching_symbols)
3233         (debug_qf_expand_symtabs_matching)
3234         (debug_qf_find_pc_sect_compunit_symtab)
3235         (debug_qf_map_symbol_filenames)
3236         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3237         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3238         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3239         (debug_sym_read_linetable, debug_sym_relocate): Update.
3240         (symfile_debug_free_objfile): Remove.
3241         (install_symfile_debug_logging, _initialize_symfile_debug):
3242         Update.
3243
3244 2019-05-08  Tom Tromey  <tom@tromey.com>
3245
3246         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3247         allocate_on_obstack.
3248         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3249         (get_dwarf2_per_objfile): Update.
3250         (set_dwarf2_per_objfile): Remove.
3251         (dwarf2_has_info, dwarf2_get_section_info): Update.
3252         (dwarf2_free_objfile): Remove.
3253         (_initialize_dwarf2_read): Update.
3254
3255 2019-05-08  Tom Tromey  <tom@tromey.com>
3256
3257         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3258         initializers.
3259         <unsupported_script_warning_printed,
3260         script_not_found_warning_printed>: Now bool.
3261         (auto_load_pspace_data): Change type.
3262         (~auto_load_pspace_info): Rename from
3263         auto_load_pspace_data_cleanup.
3264         (get_auto_load_pspace_data, init_loaded_scripts_info)
3265         (clear_section_scripts, maybe_print_unsupported_script_warning)
3266         (maybe_print_script_not_found_warning, _initialize_auto_load):
3267         Update.
3268
3269 2019-05-08  Tom Tromey  <tom@tromey.com>
3270
3271         * objfiles.c (objfile_pspace_info): Add destructor and
3272         initializers.
3273         (objfiles_pspace_data): Change type.
3274         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3275         (get_objfile_pspace_data): Update.
3276         (objfiles_bfd_data): Change type.
3277         (get_objfile_bfd_data): Update.
3278         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3279
3280 2019-05-08  Tom Tromey  <tom@tromey.com>
3281
3282         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3283         Change type.
3284         (get_catch_syscall_inferior_data): Update.
3285         (catch_syscall_inferior_data_cleanup): Remove.
3286         (_initialize_break_catch_syscall): Update.
3287
3288 2019-05-08  Tom Tromey  <tom@tromey.com>
3289
3290         * inflow.c (struct terminal_info): Add destructor and
3291         initializers.
3292         (inflow_inferior_data): Change type.
3293         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3294         (get_inflow_inferior_data, inflow_inferior_exit)
3295         (swap_terminal_info, _initialize_inflow): Update.
3296
3297 2019-05-08  Tom Tromey  <tom@tromey.com>
3298
3299         * target-dcache.c (target_dcache_cleanup): Remove.
3300         (target_dcache_aspace_key): Change type.
3301         (target_dcache_init_p, target_dcache_invalidate)
3302         (target_dcache_get, target_dcache_get_or_init)
3303         (_initialize_target_dcache): Update.
3304         * dcache.h (struct dcache_deleter): New.
3305
3306 2019-05-08  Tom Tromey  <tom@tromey.com>
3307
3308         * symtab.c (struct symbol_cache): Add destructor and
3309         initializers.
3310         (symbol_cache_key): Move.  Change type.
3311         (make_symbol_cache, free_symbol_cache): Remove.
3312         (get_symbol_cache): Update.
3313         (symbol_cache_cleanup): Remove.
3314         (ALL_PSPACES, symbol_cache_flush)
3315         (maintenance_print_symbol_cache)
3316         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3317         Update.
3318
3319 2019-05-08  Tom Tromey  <tom@tromey.com>
3320
3321         * symtab.c (struct main_info): Add destructor and initializers.
3322         (main_progspace_key): Move.  Change type.
3323         (get_main_info): Update.
3324         (main_info_cleanup): Remove.
3325         (_initialize_symtab): Update.
3326
3327 2019-05-08  Tom Tromey  <tom@tromey.com>
3328
3329         * registry.h (DECLARE_REGISTRY): Define the _key class.
3330
3331 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3332
3333         * NEWS: Merge two 'New commands' sections.
3334
3335 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3336
3337         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3338         parameter and use Ada language definition instead.
3339         (ada_val_print_ptr): Remove unused language parameter.
3340         (ada_val_print_num): Remove language parameter and use Ada language
3341         definition instead.
3342         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3343         parameter.
3344         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3345         parameter and use Ada language definition instead.
3346         (ada_val_print_1): Update all ada_val_print_xxx calls.
3347         Remove language parameter.
3348         (ada_val_print): Update ada_val_print_1 call.
3349
3350 2019-05-08  Tom Tromey  <tromey@adacore.com>
3351
3352         * remote.c (remote_hw_watchpoint_limit)
3353         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3354         Now static.
3355
3356 2019-05-08  Tom Tromey  <tromey@adacore.com>
3357
3358         * maint.c (_initialize_maint_cmds): Move initialization code to
3359         remote.c.
3360         (watchdog, show_watchdog): Move to remote.c.
3361         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3362         "watchdog" static.
3363         (_initialize_remote): Move initialization code from maint.c.
3364         * defs.h (watchdog): Don't declare.
3365
3366 2019-05-08  Tom Tromey  <tromey@adacore.com>
3367
3368         * tui/tui-interp.c: Include main.h.
3369         * interps.c: Include main.h.
3370         * main.h (interpreter_p): Declare.
3371         * defs.h (interpreter_p): Don't declare.
3372
3373 2019-05-08  Tom Tromey  <tromey@adacore.com>
3374
3375         * dwarf2loc.c: Include dwarf2read.h.
3376         * defs.h (read_unsigned_leb128): Don't declare.
3377         * dwarf2read.h (read_unsigned_leb128): Declare.
3378
3379 2019-05-08  Tom Tromey  <tromey@adacore.com>
3380
3381         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3382         method.
3383
3384 2019-05-08  Tom Tromey  <tromey@adacore.com>
3385
3386         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3387         when no wrap column is set.
3388
3389 2019-05-08  Tom Tromey  <tromey@adacore.com>
3390
3391         * c-lang.c (c_get_string): Handle non-C-style arrays.
3392
3393 2019-05-08  Tom Tromey  <tromey@adacore.com>
3394
3395         * typeprint.c (print_offset_data::update): Print the bit offset,
3396         not the number of bits remaining.
3397
3398 2019-05-08  Tom Tromey  <tromey@adacore.com>
3399
3400         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3401         padding at end of comment.
3402
3403 2019-05-08  Tom Tromey  <tromey@adacore.com>
3404
3405         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3406         Compare main types.
3407
3408 2019-05-06  Tom Tromey  <tom@tromey.com>
3409
3410         * common/scoped_mmap.c: Include common-defs.h.
3411         * common/scoped_mmap.h: Don't include config.h.
3412
3413 2019-05-04  Tom Tromey  <tom@tromey.com>
3414
3415         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3416         (struct aarch64_call_info): Add initializers.
3417         <si>: Now a std::vector.
3418         (pass_on_stack, aarch64_push_dummy_call): Update.
3419
3420 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3421             Tom Tromey  <tom@tromey.com>
3422
3423         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3424         (ppc_threads): Now a std::vector.  Now static.
3425         (hwdebug_find_thread_points_by_tid)
3426         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3427         Update.
3428
3429 2019-05-04  Tom Tromey  <tom@tromey.com>
3430
3431         * arc-tdep.c (arc_tdesc_init): Return bool.
3432
3433 2019-05-04  Tom Tromey  <tom@tromey.com>
3434
3435         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3436         Use gdb_assert_not_reached.
3437
3438 2019-05-04  Tom Tromey  <tom@tromey.com>
3439
3440         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3441         "false".
3442
3443 2019-05-04  Tom Tromey  <tom@tromey.com>
3444
3445         * arc-tdep.c (arc_tdesc_init): Use bool.
3446
3447 2019-05-04  Tom Tromey  <tom@tromey.com>
3448
3449         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3450
3451 2019-05-04  Tom Tromey  <tom@tromey.com>
3452
3453         * cli/cli-cmds.c (valid_command_p): Return bool.
3454
3455 2019-05-04  Tom Tromey  <tom@tromey.com>
3456
3457         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3458         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3459
3460 2019-05-04  Raul Tambre  <raul@tambre.ee>
3461
3462         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3463         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3464         operator for comparison.
3465
3466 2019-05-04  Tom Tromey  <tom@tromey.com>
3467
3468         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3469         (lookup_partial_symbol, print_partial_symbols)
3470         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3471         (psymbol_compare): Update.
3472         (add_psymbol_to_bcache): Clear the entire psymbol.
3473         (maintenance_check_psymtabs): Update.
3474         * psympriv.h (struct partial_symbol): Don't derive from
3475         general_symbol_info.
3476         <obj_section, unrelocated_address, address,
3477         set_unrelocated_address>: Update.
3478         <ginfo>: New member.
3479         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3480         (debug_names::write_psymbols): Update.
3481
3482 2019-05-04  Tom de Vries  <tdevries@suse.de>
3483
3484         * contrib/cc-with-tweaks.sh: Support -n arg.
3485
3486 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3487
3488         * corelow.c (core_target::detach): Ensure frame cache and
3489         register caches are cleared.
3490         inferior.c (exit_inferior_1): Likewise.
3491
3492 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3493             Tom Tromey  <tom@tromey.com>
3494
3495         * dictionary.c (collate_pending_symbols_by_language): Remove
3496         "struct" from foreach.
3497         * symtab.c (lookup_global_symbol_from_objfile)
3498         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3499         foreach.
3500         * ser-tcp.c (net_open): Remove "struct" from foreach.
3501         * objfiles.c (objfile_relocate, objfile_rebase)
3502         (objfile_has_symbols): Remove "struct" from foreach.
3503         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3504         from foreach.
3505         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3506         foreach.
3507         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3508         "struct" from foreach.
3509         * ada-lang.c (create_excep_cond_exprs)
3510         (ada_exception_catchpoint_cond_string): Remove "struct" from
3511         foreach.
3512
3513 2019-05-03  Tom Tromey  <tromey@adacore.com>
3514
3515         * ada-exp.y (convert_char_literal): Check suffix of each
3516         enumerator.
3517
3518 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3519
3520         PR ada/21406:
3521         * ada-exp.y (yywrap): Don't define.
3522         * ada-lex.l (%option): Add noyywrap
3523         (yywrap): Remove.
3524
3525 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3526
3527         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3528         _WIN32_WINNT to the XP level, unless already defined to a higher
3529         level.
3530
3531         * unittests/parse-connection-spec-selftests.c:
3532         * ser-tcp.c:
3533         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3534         override.
3535
3536         * symfile.c (find_separate_debug_file): Remove colon from the
3537         drive spec of DOS/Windows file names of the target, so that the
3538         file name produced from DEBUGDIR and the target's directory will
3539         be valid on DOS/Windows systems.
3540
3541 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3542
3543         * rust-lang.c (val_print_struct): Handle printing structures
3544         containing strings.
3545
3546 2019-05-02  Tom Tromey  <tromey@adacore.com>
3547
3548         * valarith.c (_initialize_valarith): Remove.
3549
3550 2019-05-01  Tom Tromey  <tromey@adacore.com>
3551
3552         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3553         bitfields.
3554
3555 2019-05-01  Tom Tromey  <tromey@adacore.com>
3556
3557         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3558         for big-endian copies.
3559
3560 2019-04-30  Ali Tamur  <tamur@google.com>
3561         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3562         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3563         (read_3_bytes): New function.
3564
3565 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3566
3567         * windows-nat.c (main_thread_id): Delete.
3568         (handle_output_debug_string): Replace main_thread_id by
3569         current_event.dwThreadId.
3570         (fake_create_process): Likewise.
3571         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3572         Do not set main_thread_id.
3573         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3574         current_event.dwThreadId.
3575         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3576
3577 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3578
3579         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3580         Use current_event.dwThreadId instead of main_thread_id.
3581
3582 2019-04-30  Tom Tromey  <tromey@adacore.com>
3583
3584         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3585         (create_excep_cond_exprs): Iterate over program spaces.
3586         (ada_exception_catchpoint_cond_string): Examine all minimal
3587         symbols for exception types.
3588
3589 2019-04-30  Tom Tromey  <tromey@adacore.com>
3590
3591         PR c++/24470:
3592         * dwarf2read.c (process_structure_scope): Handle case where type
3593         has template parameters but no symbol was created.
3594
3595 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3596             Chris January  <chris.january@arm.com>
3597
3598         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3599         qualifier.
3600         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3601
3602 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * f-typeprint.c (f_print_type): Update rules for printing
3605         whitespace.
3606         (f_type_print_varspec_suffix): Likewise.
3607
3608 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3609             Chris January  <chris.january@arm.com>
3610
3611         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3612         function arguments.
3613
3614 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3615
3616         * f-lang.c (build_fortran_types): Change name of void type to
3617         lower case.
3618         * f-typeprint.c (f_type_print_base): Print the name of the void
3619         type, rather than a fixed string.
3620         * f-valprint.c (f_decorations): Use lower case void string.
3621
3622 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3623             Chris January  <chris.january@arm.com>
3624
3625         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3626         types for Fortran.
3627
3628 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3629             Chris January  <chris.january@arm.com>
3630             David Lecomber  <david.lecomber@arm.com>
3631
3632         * f-exp.y (BINOP_INTRINSIC): New token.
3633         (exp): New parser rule handling BINOP_INTRINSIC.
3634         (f77_keywords): Add new builtin procedures.
3635         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3636         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3637         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3638         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3639         (print_unop_subexp_f): New function.
3640         (print_binop_subexp_f): New function.
3641         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3642         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3643         (dump_subexp_body_f): Likewise.
3644         (operator_check_f): Likewise.
3645         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3646         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3647
3648 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3651         UNOP_KIND.
3652         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3653         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3654         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3655         (operator_length_f): New fuction.
3656         (print_subexp_f): New function.
3657         (op_name_f): New function.
3658         (dump_subexp_body_f): New function.
3659         (operator_check_f): New function.
3660         (exp_descriptor_f): Replace standard expression handling functions
3661         with new functions.
3662         * gdb/fortran-operator.def: New file.
3663         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3664         * gdb/std-operator.def: Remove UNOP_KIND.
3665
3666 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * std-operator.def: Remove unbalanced, stray double quote
3669         character.
3670
3671 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3672             Chris January  <chris.january@arm.com>
3673             Daniel Everett  <daniel.everett@arm.com>
3674             Nick Forrington  <nick.forrington@arm.com>
3675             Richard Bunt  <richard.bunt@arm.com>
3676
3677         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3678         of depth when printing anonymous structs or unions.
3679         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3680         Don't print either the top-level value, or the children if the
3681         max-depth is exceeded.
3682         (ppscm_print_children): When printing the key of a map, allow one
3683         extra level of depth.
3684         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3685         print either the top-level value, or the children if the max-depth
3686         is exceeded.
3687         (print_children): When printing the key of a map, allow one extra
3688         level of depth.
3689         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3690         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3691         (user_print_options): Initialise max_depth field.
3692         (val_print_scalar_or_string_type_p): New function.
3693         (val_print): Check to see if the max depth has been reached.
3694         (val_print_check_max_depth): Define new function.
3695         (show_print_max_depth): New function.
3696         (_initialize_valprint): Add 'print max-depth' option.
3697         * valprint.h (struct value_print_options) <max_depth>: New field.
3698         (val_print_check_max_depth): Declare new function.
3699         * NEWS: Document new feature.
3700
3701 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3702
3703         * ada-lang.c (ada_language_defn): Initialise new field.
3704         * c-lang.c (c_is_string_type_p): New function.
3705         (c_language_defn): Initialise new field.
3706         (cplus_language_defn): Initialise new field.
3707         (asm_language_defn): Initialise new field.
3708         (minimal_language_defn): Initialise new field.
3709         * c-lang.h (c_is_string_type_p): Declare new function.
3710         * d-lang.c (d_language_defn): Initialise new field.
3711         * f-lang.c (f_is_string_type_p): New function.
3712         (f_language_defn): Initialise new field.
3713         * go-lang.c (go_is_string_type_p): New function.
3714         (go_language_defn): Initialise new field.
3715         * language.c (default_is_string_type_p): New function.
3716         (unknown_language_defn): Initialise new field.
3717         (auto_language_defn): Initialise new field.
3718         * language.h (struct language_defn) <la_is_string_type_p>: New
3719         member variable.
3720         (default_is_string_type_p): Declare new function.
3721         * m2-lang.c (m2_language_defn): Initialise new field.
3722         * objc-lang.c (objc_language_defn): Initialise new field.
3723         * opencl-lang.c (opencl_language_defn): Initialise new field.
3724         * p-lang.c (pascal_is_string_type_p): New function.
3725         (pascal_language_defn): Initialise new field.
3726         * rust-lang.c (rust_is_string_type_p): New function.
3727         (rust_language_defn): Initialise new field.
3728
3729 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3730
3731         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3732         New field.
3733         * ada-lang.c (ada_language_defn): Initialise new field.
3734         * c-lang.c (c_language_defn): Likewise.
3735         (cplus_language_defn): Likewise.
3736         (asm_language_defn): Likewise.
3737         (minimal_language_defn): Likewise.
3738         * d-lang.c (d_language_defn): Likewise.
3739         * f-lang.c (f_language_defn): Likewise.
3740         * go-lang.c (go_language_defn): Likewise.
3741         * language.c (unknown_language_defn): Likewise.
3742         (auto_language_defn): Likewise.
3743         * m2-lang.c (m2_language_defn): Likewise.
3744         * objc-lang.c (objc_language_defn): Likewise.
3745         * opencl-lang.c (opencl_language_defn): Likewise.
3746         * p-lang.c (pascal_language_defn): Likewise.
3747         * rust-lang.c (rust_language_defn): Likewise.
3748
3749 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * ada-lang.c (ada_is_character_type): Change return type to bool.
3752         (ada_is_string_type): Likewise.
3753         * ada-lang.h (ada_is_character_type): Update declaration
3754         (ada_is_string_type): Likewise.
3755
3756 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3757
3758         Support style in 'frame|thread apply'
3759
3760         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3761         * record.c (record_start, record_stop): Update callers of
3762         execute_command_to_string with false.
3763         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3764         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3765         methods.
3766         (class string_file): New constructor with term_out parameter.
3767         Override methods term_out and can_emit_style_escape.  New member
3768         term_out.
3769         (class stdio_file): Override can_emit_style_escape.
3770         (class tee_file): Override term_out and can_emit_style_escape.
3771         * utils.h (can_emit_style_escape): Remove.
3772         * utils.c (can_emit_style_escape): Likewise.
3773         Update all callers of can_emit_style_escape (SOMESTREAM) to
3774         SOMESTREAM->can_emit_style_escape.
3775         * source-cache.c (source_cache::get_source_lines): Likewise.
3776         * stack.c (frame_apply_command_count): Call execute_command_to_string
3777         passing the term_out characteristic of the current gdb_stdout.
3778         * thread.c (thr_try_catch_cmd): Likewise.
3779         * top.c (execute_command_to_string): pass term_out parameter
3780         to construct the string_file for the command output.
3781         * ui-file.c (term_cli_styling): New function (most code moved
3782         from utils.c can_emit_style_escape).
3783         (string_file::string_file, string_file::can_emit_style_escape,
3784         stdio_file::can_emit_style_escape, tee_file::term_out,
3785         tee_file::can_emit_style_escape): New functions.
3786
3787 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3788
3789         * NEWS: Mention the new set|show may-call-functions.
3790         * infcall.c (may_call_functions_p): New variable.
3791         (show_may_call_functions_p): New function.
3792         (call_function_by_hand_dummy): Throws an error if not
3793         may-call-functions.
3794         (_initialize_infcall): Call add_setshow_boolean_cmd for
3795         may-call-functions.
3796
3797 2019-04-25  Keith Seitz  <keiths@redhat.com>
3798
3799         PR c++/24367
3800         * cp-support.c (inspect_type): Don't attempt substitutions
3801         of symbol with the same name.
3802
3803 2019-04-25  Tom Tromey  <tromey@adacore.com>
3804
3805         PR gdb/24475:
3806         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3807         static.
3808
3809 2019-04-25  Tom Tromey  <tromey@adacore.com>
3810
3811         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3812         rvalue reference.
3813         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3814         (gdb_xml_parser::parse): Use std::move.
3815         * python/python-internal.h (gdbpy_convert_exception): Take a const
3816         reference.
3817         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3818         std::move.
3819         * python/py-utils.c (gdbpy_convert_exception): Take a const
3820         reference.
3821         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3822         Use std::move.
3823         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3824         Use std::move.
3825         * mi/mi-main.c (mi_print_exception): Take a const reference.
3826         * main.c (handle_command_errors): Take a const reference.
3827         * linespec.c (parse_linespec): Use std::move.
3828         * infcall.c (run_inferior_call): Use std::move.
3829         (call_function_by_hand_dummy): Use std::move.
3830         * exec.c (try_open_exec_file): Use std::move.
3831         * exceptions.h (exception_print, exception_fprintf)
3832         (exception_print_same): Update.
3833         * exceptions.c (print_exception, exception_print)
3834         (exception_fprintf, exception_print_same): Change parameters to
3835         const reference.
3836         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3837         * common/new-op.c: Use std::move.
3838         * common/common-exceptions.h (struct gdb_exception): Add move
3839         constructor.
3840         (struct gdb_exception_error, struct gdb_exception_quit, struct
3841         gdb_quit_bad_alloc): Change constructor to move constructor.
3842         (throw_exception): Change parameter to rvalue reference.
3843         * common/common-exceptions.c (throw_exception): Take rvalue
3844         reference.
3845         * cli/cli-interp.c (safe_execute_command): Use std::move.
3846         * breakpoint.c (insert_bp_location, location_to_sals): Use
3847         std::move.
3848
3849 2019-04-25  Tom Tromey  <tromey@adacore.com>
3850
3851         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3852         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3853         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3854         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3855         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3856         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3857         guile/scm-value.c: Use unpack.
3858         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3859         gdbscm_gdb_exception.
3860         (gdbscm_throw_gdb_exception): Likewise.
3861         (struct gdbscm_gdb_exception): New.
3862         (unpack): New function.
3863         (gdbscm_wrap): Use unpack.
3864
3865 2019-04-25  Tom Tromey  <tromey@adacore.com>
3866
3867         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3868         (gdb_rl_callback_handler): Use std::move.
3869         * common/common-exceptions.h (struct gdb_exception): Add move
3870         assignment operator.
3871         (throw_exception_sjlj): Change "exception" to const reference.
3872         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3873         (throw_exception_sjlj): Change "exception" to const reference.
3874
3875 2019-04-25  Tom Tromey  <tromey@adacore.com>
3876
3877         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3878         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3879         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3880         Update.
3881         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3882         Update.
3883         * mi/mi-interp.c (mi_interp::exec): Update.
3884         * linespec.c (parse_linespec): Update.
3885         * infcall.c (run_inferior_call): Update.
3886         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3887         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3888         (gdbscm_lookup_global_symbol): Update.
3889         * guile/scm-param.c (gdbscm_parameter_value): Update.
3890         * guile/scm-frame.c (gdbscm_frame_read_register)
3891         (gdbscm_frame_read_var): Update.
3892         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3893         * exec.c (try_open_exec_file): Update.
3894         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3895         (gdb_rl_callback_handler): Update.
3896         * common/common-exceptions.h (exception_none): Don't declare.
3897         * common/common-exceptions.c (exception_none): Don't define.
3898         (struct catcher) <exception>: Update.
3899         * cli/cli-interp.c (safe_execute_command): Update.
3900         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3901
3902 2019-04-25  Ali Tamur  <tamur@google.com>
3903
3904         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3905         (read_attribute_value): Likewise.
3906         (dwarf2_read_addr_index): Update comment.
3907         (read_str_index): Add DW_FORM_strx.
3908         (dwarf2_string_attr): Likewise.
3909         (dwarf2_const_value_attr): Likewise.
3910         (dump_die_shallow): Likewise.
3911         (dwarf2_fetch_constant_bytes): Likewise.
3912         (skip_form_bytes): Likewise.
3913         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3914
3915 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3916
3917         PR corefiles/11608
3918         PR corefiles/18187
3919         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3920         OFFSET.  Verify if current mapping contains an ELF header.
3921         (linux_find_memory_regions_full): Adjust call to
3922         dump_mapping_p.
3923
3924 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3925             Kang Li <kanglictf@gmail.com>
3926
3927         PR gdb/21600
3928
3929         * dwarf2-frame.c (read_initial_length): Be consistent about using
3930         unsigned representation of length.
3931         (decode_frame_entry_1): Likewise.  Check for wraparound of
3932         end pointer as well as buffer overflow.
3933
3934 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3935
3936         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3937         "vq".
3938
3939 2019-04-24  Tom Tromey  <tromey@adacore.com>
3940
3941         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3942
3943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3944
3945         * s12z-tdep.c (s12z_unwind_pc): Delete.
3946         (s12z_unwind_sp): Delete.
3947         (s12z_gdbarch_init): Don't register deleted functions with
3948         gdbarch.
3949
3950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3951
3952         * rl78-tdep.c (rl78_unwind_sp): Delete.
3953         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3954
3955 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3956
3957         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3958         (xstormy16_unwind_pc): Delete.
3959         (xstormy16_dummy_id): Delete.
3960         (xstormy16_gdbarch_init): Don't register deleted functions with
3961         gdbarch.
3962
3963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * vax-tdep.c (vax_unwind_pc): Delete.
3966         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3967
3968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * v850-tdep.c (v850_unwind_sp): Delete.
3971         (v850_unwind_pc): Delete.
3972         (v850_dummy_id): Delete.
3973         (v850_gdbarch_init): Don't register deleted functions with
3974         gdbarch.
3975
3976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3977
3978         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3979         (tilegx_unwind_pc): Delete.
3980         (tilegx_unwind_dummy_id): Delete.
3981         (tilegx_gdbarch_init): Don't register deleted functions with
3982         gdbarch.
3983
3984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3985
3986         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3987         (tic6x_dummy_id): Delete.
3988         (tic6x_gdbarch_init): Don't register deleted functions with
3989         gdbarch.
3990
3991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * sparc-tdep.c (sparc_unwind_pc): Delete.
3994         (sparc32_gdbarch_init): Don't register deleted function with
3995         gdbarch.
3996
3997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3998
3999         * sh-tdep.c (sh_unwind_sp): Delete.
4000         (sh_unwind_pc): Delete.
4001         (sh_dummy_id): Delete.
4002         (sh_gdbarch_init): Don't register deleted functions with
4003         gdbarch.
4004
4005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4006
4007         * score-tdep.c (score_unwind_sp): Delete.
4008         (score_unwind_pc): Delete.
4009         (score_dummy_id): Delete.
4010         (score_gdbarch_init): Don't register deleted functions with
4011         gdbarch.
4012
4013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4014
4015         * rx-tdep.c (rx_unwind_pc): Delete.
4016         (rx_unwind_sp): Delete.
4017         (rx_dummy_id): Delete.
4018         (rx_gdbarch_init): Don't register deleted functions with
4019         gdbarch.  Update comment.
4020
4021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4022
4023         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4024         (rs6000_dummy_id): Delete.
4025         (rs6000_gdbarch_init): Don't register deleted functions with
4026         gdbarch.
4027
4028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * or1k-tdep.c (or1k_dummy_id): Delete.
4031         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4032
4033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * nios2-tdep.c (nios2_dummy_id): Delete.
4036         (nios2_unwind_sp): Delete.
4037         (nios2_gdbarch_init): Don't register deleted functions with
4038         gdbarch.
4039
4040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * nds32-tdep.c (nds32_dummy_id): Delete.
4043         (nds32_unwind_pc): Delete.
4044         (nds32_unwind_sp): Delete.
4045         (nds32_gdbarch_init): Don't register deleted functions with
4046         gdbarch.
4047
4048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4049
4050         * msp430-tdep.c (msp430_unwind_pc): Delete.
4051         (msp430_unwind_sp): Delete.
4052         (msp430_dummy_id): Delete.
4053         (msp430_gdbarch_init): Don't register deleted functions with
4054         gdbarch.
4055
4056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * moxie-tdep.c (moxie_unwind_sp): Delete.
4059         (moxie_unwind_pc): Delete.
4060         (moxie_dummy_id): Delete.
4061         (moxie_gdbarch_init): Don't register deleted functions with
4062         gdbarch.
4063
4064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4065
4066         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4067         (mn10300_unwind_pc): Delete.
4068         (mn10300_unwind_sp): Delete.
4069         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4070         mn10300_unwind_sp.
4071         (mn10300_frame_unwind_init): Don't register deleted functions with
4072         gdbarch.
4073
4074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * mep-tdep.c (mep_unwind_pc): Delete.
4077         (mep_unwind_sp): Delete.
4078         (mep_dummy_id): Delete.
4079         (mep_gdbarch_init): Don't register deleted functions with
4080         gdbarch.
4081
4082 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4083
4084         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4085         (m68hc11_unwind_sp): Delete.
4086         (m68hc11_gdbarch_init): Don't register deleted functions with
4087         gdbarch.
4088
4089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4090
4091         * m32r-tdep.c (m32r_unwind_sp): Delete.
4092         (m32r_unwind_pc): Delete.
4093         (m32r_dummy_id): Delete.
4094         (m32r_gdbarch_init): Don't register deleted functions with
4095         gdbarch.
4096
4097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * m32c-tdep.c (m32c_unwind_pc): Delete.
4100         (m32c_unwind_sp): Delete.
4101         (m32c_dummy_id): Delete.
4102         (m32c_gdbarch_init): Don't register deleted functions with
4103         gdbarch.
4104
4105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4108         (lm32_unwind_pc): Delete.
4109         (lm32_dummy_id): Delete.
4110         (lm32_gdbarch_init): Don't register deleted functions with
4111         gdbarch.
4112
4113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4116         (iq2000_unwind_pc): Delete.
4117         (iq2000_dummy_id): Delete.
4118         (iq2000_gdbarch_init): Don't register deleted functions with
4119         gdbarch.
4120
4121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * nds32-tdep.c (nds32_type_align): Delete.
4124         (nds32_push_dummy_call): Use type_align instead.
4125
4126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * arm-tdep.c (arm_type_align): Only handle vector override case.
4129         (arm_push_dummy_call): Use type_align.
4130         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4131
4132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4135         case.
4136         (pass_on_stack): Use type_align.
4137         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4138         function.
4139
4140 2019-04-23  Tom Tromey  <tromey@adacore.com>
4141
4142         * dwarf2read.c (line_header::file_name_at): Remove unused
4143         overload.
4144
4145 2019-04-23  Tom de Vries  <tdevries@suse.de>
4146
4147         PR gdb/24438
4148         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4149         invocation.
4150
4151
4152 2019-03-27  Ali Tamur  <tamur@google.com>
4153
4154         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4155         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4156         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4157         (dwarf_expr_context::get_addr_index): Likewise
4158         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4159         (symbol_needs_eval_context::get_addr_index): Likewise
4160         (disassemble_dwarf_expression): Add DW_OP_addrx
4161         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4162         (read_cutu_die_from_dwo): Update comment
4163         (skip_one_die): Add DW_FORM_addrx
4164         (read_attribute_value): Likewise
4165         (var_decode_location): Add DW_OP_addrx
4166         (dwarf2_const_value_attr): Add DW_FORM_addrx
4167         (dump_die_shallow): Likewise
4168         (dwarf2_fetch_constant_bytes): Likewise
4169         (decode_locdesc): Add DW_OP_addrx
4170         (skip_form_bytes): Add DW_FORM_addrx
4171
4172 2019-04-22  Ali Tamur  <tamur@google.com>
4173
4174         * MAINTAINERS (Write After Approval): Add self.
4175
4176 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4177
4178         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4179         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4180         (open_symbol_file_object): Likewise.
4181         (svr4_default_sos): Add info parameter.
4182         (svr4_read_so_list): Likewise.
4183         (svr4_current_sos_direct): Adjust functions calls to pass down
4184         info.
4185         (svr4_current_sos_1): Add info parameter.
4186         (svr4_current_sos): Call get_svr4_info, pass info down to
4187         svr4_current_sos_1.
4188         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4189         get_svr4_info.
4190         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4191         get_svr4_info.
4192         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4193         to get_svr4_info.
4194         (probes_table_remove_objfile_probes): Likewise.
4195         (register_solib_event_probe): Add info parameter.
4196         (solist_update_incremental): Pass info parameter down to
4197         svr4_read_so_list.
4198         (disable_probes_interface): Add info parameter.
4199         (svr4_handle_solib_event): Pass current_program_space to
4200         get_svr4_info.  Adjust disable_probes_interface cleanup.
4201         (svr4_create_probe_breakpoints): Add info parameter, pass it
4202         down to register_solib_event_probe.
4203         (svr4_create_solib_event_breakpoints): Add info parameter,
4204         pass it down to svr4_create_probe_breakpoints.
4205         (enable_break): Pass info down to
4206         svr4_create_solib_event_breakpoints.
4207         (svr4_solib_create_inferior_hook): Pass current_program_space to
4208         get_svr4_info.
4209         (svr4_clear_solib): Likewise.
4210
4211 2019-04-22  Pedro Alves  <palves@redhat.com>
4212
4213         * solib-svr4.c (svr4_free_objfile_observer): New.
4214         (probe_and_action::objfile): New field.
4215         (probes_table_htab_remove_objfile_probes)
4216         (probes_table_remove_objfile_probes): New functions.
4217         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4218         in the new probe_and_action.  Don't store the probe in 'lookup'.
4219         (svr4_create_probe_breakpoints): Pass objfile to
4220         register_solib_event_probe.
4221         (_initialize_svr4_solib): Register a free_objfile observer.
4222
4223 2019-04-19  Tom Tromey  <tom@tromey.com>
4224
4225         * common/queue.h: Remove.
4226
4227 2019-04-19  Tom Tromey  <tom@tromey.com>
4228
4229         * event-loop.c: Don't include "common/queue.h".
4230
4231 2019-04-19  Tom Tromey  <tom@tromey.com>
4232
4233         * remote.c (remote_target): Use delete.
4234         * remote-notif.h: Include <list>, not "common/queue.h".
4235         (notif_client_p): Remove typedef.
4236         (remote_notif_state): Add constructor, destructor, initializer.
4237         <notif_queue>: Now a std::list.
4238         (remote_notif_state_xfree): Don't declare.
4239         * remote-notif.c (remote_notif_process, handle_notification)
4240         (remote_notif_state_allocate): Update.
4241         (~remote_notif_state): Rename from remote_notif_state_xfree.
4242
4243 2019-04-19  Tom Tromey  <tom@tromey.com>
4244
4245         * symfile.c (reread_symbols): Update.
4246         * objfiles.c (objfile_register_static_link)
4247         (objfile_lookup_static_link): Update
4248         (~objfile) Don't delete static_links.
4249         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4250
4251 2019-04-19  Tom Tromey  <tom@tromey.com>
4252
4253         * type-stack.h (struct type_stack) <insert>: Constify string.
4254         * type-stack.c (type_stack::insert): Constify string.
4255         * gdbtypes.h (lookup_template_type): Update.
4256         (address_space_name_to_int): Update.
4257         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4258         const.
4259         (lookup_template_type): Make name const.
4260         * c-exp.y: Update rules.
4261         (lex_one_token, classify_name, classify_inner_name)
4262         (c_print_token): Update.
4263         * p-exp.y: Update rules.
4264         (yylex): Update.
4265         * f-exp.y: Update rules.
4266         (yylex): Update.
4267         * d-exp.y: Update rules.
4268         (lex_one_token, classify_name, classify_inner_name): Update.
4269         * parse.c (write_dollar_variable, copy_name): Return std::string.
4270         * parser-defs.h (copy_name): Change return type.
4271         * m2-exp.y: Update rules.
4272         (yylex): Update.
4273         * go-exp.y (lex_one_token): Update.
4274         Update rules.
4275         (classify_unsafe_function, classify_packaged_name)
4276         (classify_name, yylex): Update.
4277
4278 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4279
4280         * configure.ac: add --enable-source-highlight switch.
4281         * configure: Regenerate.
4282         * top.c (print_gdb_version): plumb --enable-source-highlight
4283         status to "show configuration".
4284
4285 2019-04-19  Tom Tromey  <tromey@adacore.com>
4286
4287         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4288         Check ADA_TYPE_P.
4289         (empty_record, ada_template_to_fixed_record_type_1)
4290         (template_to_static_fixed_type)
4291         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4292         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4293         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4294         macros.
4295
4296 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4297
4298         PR symtab/24423:
4299         * source.c (print_source_lines_base): Advance "iter" when a
4300         control character is seen.
4301
4302 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4303
4304         * inferior.h (struct infcall_suspend_state_deleter):
4305         Catch exception in destructor to avoid crash.
4306
4307 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4308
4309         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4310         close to the add_com "shell".
4311
4312 2019-04-18  Tom Tromey  <tromey@adacore.com>
4313
4314         * process-stratum-target.h (class process_stratum_target)
4315         <stratum>: Add "final".
4316
4317 2019-04-17  Tom Tromey  <tromey@adacore.com>
4318
4319         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4320         against nullptr before use.
4321
4322 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4323
4324         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4325
4326 2019-04-17  Jim Wilson  <jimw@sifive.com>
4327             Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4330         code read might fail, assume 4-byte breakpoint in that case.
4331
4332 2019-04-15  Leszek Swirski  <leszeks@google.com>
4333
4334         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4335         rather than a hand-rolled POD check when checking for forced MEMORY
4336         classification.
4337
4338 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4339
4340         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4341         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4342         function.
4343         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4344         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4345         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4346         declaration.
4347
4348 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4349
4350         * aarch64-linux-nat.c
4351         (aarch64_linux_nat_target::thread_architecture): Add override.
4352         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4353         each VQ.
4354
4355 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4356
4357         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4358
4359 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4362         target types of size 96-bits, add some additional comments, and
4363         check that the builtin type we found was the correct size.
4364
4365 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4366
4367         * utils.c (prompt_for_continue): Don't restore the styling at the
4368         end, as applied_style has the wrong value.  This fixes styling in
4369         long lists of file names that are interrupted by the "Continue?"
4370         prompt.
4371
4372 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4373
4374         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4375         * c-lang.c (c_language_defn): Likewise.
4376         (cplus_language_defn): Likewise.
4377         (asm_language_defn): Likewise.
4378         (minimal_language_defn): Likewise.
4379         * d-lang.c (d_language_defn): Likewise.
4380         * f-lang.c (f_language_defn): Likewise.
4381         * go-lang.c (go_language_defn): Likewise.
4382         * language.c (unknown_language_defn): Likewise.
4383         (auto_language_defn): Likewise.
4384         * language.h (struct language_defn): Remove la_magic field.
4385         (LANG_MAGIC): Delete.
4386         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4387         * objc-lang.c (objc_language_defn): Likewise.
4388         * opencl-lang.c (opencl_language_defn): Likewise.
4389         * p-lang.c (pascal_language_defn): Likewise.
4390         * rust-lang.c (rust_language_defn): Likewise.
4391
4392 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4393
4394         * riscv-tdep.c (riscv_type_align): New function.
4395         (riscv_type_alignment): Delete.
4396         (riscv_arg_location): Use 'type_align'.
4397         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4398
4399 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * gdbtypes.c (type_align): A struct with no non-static fields also
4402         has alignment of 1.
4403
4404 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4405
4406         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4407         component to 0.
4408         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4409         member.
4410         (riscv_struct_info::analyse): New implementation using new
4411         analyse_inner member function.
4412         (riscv_struct_info::field_offset): New member function.
4413         (riscv_struct_info::m_offsets): New member variable.
4414         (riscv_struct_info::analyse_inner): New private member function,
4415         takes the old implementation of riscv_struct_info::analyse but
4416         extended to track field offsets.
4417         (riscv_call_arg_struct): Update the struct folding special cases
4418         to handle cases where empty C++ structs, which are non-zero
4419         length, are found.
4420         (riscv_arg_location): Initialise the length of each location, a
4421         non-zero length now indicates the location is in use.
4422         (riscv_push_dummy_call): Allow for the first location having a
4423         non-zero offset when setting up arguments.
4424         (riscv_return_value): Likewise, but for return values.
4425
4426 2019-04-11  Tom Tromey  <tromey@adacore.com>
4427
4428         * utils.c (internal_vproblem): Make "msg" const.
4429
4430 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4431
4432         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4433         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4434         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4435         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4436
4437 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4438
4439         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4440         function.
4441         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4442         of amd64_collect_native_gregset.
4443         (amd64_linux_nat_target::store_registers): Likewise.
4444
4445 2019-04-10  Tom Tromey  <tom@tromey.com>
4446
4447         * symtab.c (lookup_global_symbol_from_objfile)
4448         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4449         * objfiles.h (class separate_debug_iterator): New.
4450         (class separate_debug_range): New.
4451         (struct objfile) <separate_debug_objfiles>: New method.
4452         (objfile_separate_debug_iterate): Don't declare.
4453         * objfiles.c (separate_debug_iterator::operator++): Rename from
4454         objfile_separate_debug_iterate.
4455         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4456         iterator.
4457         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4458         iterator.
4459
4460 2019-04-10  Tom Tromey  <tom@tromey.com>
4461
4462         * symfile.c (reread_symbols): Remove old comment.
4463         * objfiles.c (free_all_objfiles): Fix a typo.
4464
4465 2019-04-10  Tom Tromey  <tom@tromey.com>
4466
4467         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4468         * minsyms.c (lookup_minimal_symbol): Use foreach.
4469         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4470         (lookup_minimal_symbol_solib_trampoline): Likewise.
4471         * symfile.c (reread_symbols): Use foreach.
4472
4473 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4474             Tom Tromey  <tromey@adacore.com>
4475
4476         PR rust/24414:
4477         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4478         (rust_lex_int_test): Change "value" to be LONGEST.
4479         (rust_lex_tests): Add test for long integer literal.
4480
4481 2019-04-09  Tom Tromey  <tromey@adacore.com>
4482
4483         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4484         to bool.
4485         (extended_remote_target::attach): Update.
4486         (remote_target::remote_notice_new_inferior): Update.
4487         (remote_target::add_current_inferior_and_thread): Update.
4488         * inferior.c (exit_inferior_1): Use "false".
4489         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4490
4491 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4492
4493         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4494         the "start" command.
4495
4496 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4497
4498         * python/py-inferior.c (infpy_thread_from_thread_handle):
4499         Adjust comments to reflect renaming of thread_from_thread_handle
4500         to thread_from_handle.  Adjust keywords.  Fix type error message.
4501         (inferior_object_methods): Add thread_from_handle.  Retain
4502         thread_from_thread_handle, but mark it as deprecated.
4503
4504 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4505
4506         * gdbthread.h (find_thread_by_handle): Revise declaration.
4507         * thread.c (find_thread_by_handle): Likewise.  Adjust
4508         implementation too.
4509         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4510         support for buffer objects as handles.
4511
4512 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4513
4514         * python/py-infthread.c (thpy_thread_handle): New function.
4515         (thread_object_methods): Register thpy_thread_handle.
4516
4517 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4518
4519         * gdbthread.h (thread_to_thread_handle): Declare.
4520         * thread.c (gdbtypes.h): Include.
4521         (thread_to_thread_handle): New function.
4522
4523         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4524         (target_thread_info_to_thread_handle): Declare.
4525         * target.c (target_thread_info_to_thread_handle): New function.
4526         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4527         * target-delegates.c: Regenerate.
4528
4529         * linux-thread-db.c (class thread_db_target): Add method
4530         thread_info_to_thread_handle.
4531         (thread_db_target::thread_info_to_thread_handle): Define.
4532         * remote.c (class remote_target): Add new method
4533         thread_info_to_thread_handle.
4534         (remote_target::thread_info_to_thread_handle): Define.
4535
4536 2019-04-08  Pedro Alves  <palves@redhat.com>
4537
4538         * common/common-exceptions.c (throw_exception): Don't create
4539         named object to throw; throw directly.
4540         (throw_it): Likewise.  Don't initialize gdb_exception::message
4541         here, with new; pass FMT and AP to the ctor instead.
4542         * common/common-exceptions.h: Include <string>.
4543         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4544         const char *, va_list)): New ctor.  Use std::make_shared.
4545         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4546         errors)): Delete.
4547         (gdb_exception_error::gdb_exception_error(enum errors, const char
4548         *, va_list)): New.
4549         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4550         Add assertion.
4551         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4552         errors)): Delete.
4553         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4554         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4555         Add assertion.
4556
4557 2019-04-08  Tom Tromey  <tom@tromey.com>
4558
4559         * valops.c (value_rtti_indirect_type): Replace throw_exception
4560         with throw.
4561         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4562         with throw.
4563         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4564         throw.
4565         * target.c (target_translate_tls_address): Replace throw_exception
4566         with throw.
4567         * stack.c (frame_apply_command_count): Replace throw_exception
4568         with throw.
4569         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4570         throw.
4571         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4572         with throw.
4573         * rs6000-tdep.c (rs6000_frame_cache)
4574         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4575         * remote.c: Replace throw_exception with throw.
4576         * record-full.c (record_full_message, record_full_wait_1)
4577         (record_full_restore): Replace throw_exception with throw.
4578         * record-btrace.c:
4579         (get_thread_current_frame_id, record_btrace_start_replaying)
4580         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4581         (cmd_record_btrace_start): Replace throw_exception with throw.
4582         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4583         throw.
4584         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4585         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4586         * linespec.c:
4587         (find_linespec_symbols): Replace throw_exception with throw.
4588         * infrun.c (displaced_step_prepare, resume): Replace
4589         throw_exception with throw.
4590         * infcmd.c (post_create_inferior): Replace throw_exception with
4591         throw.
4592         * inf-loop.c (inferior_event_handler): Replace throw_exception
4593         with throw.
4594         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4595         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4596         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4597         (get_prev_frame_always, get_frame_pc_if_available)
4598         (get_frame_address_in_block_if_available, get_frame_language):
4599         Replace throw_exception with throw.
4600         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4601         throw_exception with throw.
4602         * eval.c (fetch_subexp_value, evaluate_var_value)
4603         (evaluate_funcall, evaluate_subexp_standard): Replace
4604         throw_exception with throw.
4605         * dwarf2loc.c (call_site_find_chain)
4606         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4607         Replace throw_exception with throw.
4608         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4609         with throw.
4610         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4611         throw.
4612         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4613         * completer.c (complete_line_internal): Replace throw_exception
4614         with throw.
4615         * compile/compile-object-run.c (compile_object_run): Replace
4616         throw_exception with throw.
4617         * cli/cli-script.c (process_next_line): Replace throw_exception
4618         with throw.
4619         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4620         (btrace_enable, btrace_maint_update_pt_packets): Replace
4621         throw_exception with throw.
4622         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4623         throw_exception with throw.
4624         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4625         throw_exception with throw.
4626         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4627         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4628         * aarch64-tdep.c (aarch64_make_prologue_cache)
4629         (aarch64_make_stub_cache): Replace throw_exception with throw.
4630
4631 2019-04-08  Tom Tromey  <tom@tromey.com>
4632
4633         * common/common-exceptions.c (throw_exception): Rename from
4634         throw_exception_cxx.  Remove old copy.  Make argument const.
4635         (throw_it): Create and throw exception objects directly.
4636         * common/common-exceptions.h (throw_exception): Make argument
4637         const.
4638         (struct gdb_exception_error): Add constructor.
4639         (struct gdb_exception_quit): Add constructor.
4640
4641 2019-04-08  Tom Tromey  <tom@tromey.com>
4642
4643         * common/common-exceptions.h (exception_rethrow): Don't declare.
4644         (TRY_SJLJ): Update comment.
4645         (TRY, CATCH, END_CATCH): Remove.
4646         * common/common-exceptions.c (exception_rethrow): Remove.
4647
4648 2019-04-08  Tom Tromey  <tom@tromey.com>
4649
4650         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4651         Remove.
4652         (gdb_exception_error): Rename from
4653         gdb_exception_RETURN_MASK_ERROR.
4654         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4655         (gdb_quit_bad_alloc): Update.
4656         * aarch64-tdep.c: Update.
4657         * ada-lang.c: Update.
4658         * ada-typeprint.c: Update.
4659         * ada-valprint.c: Update.
4660         * amd64-tdep.c: Update.
4661         * arch-utils.c: Update.
4662         * break-catch-throw.c: Update.
4663         * breakpoint.c: Update.
4664         * btrace.c: Update.
4665         * c-varobj.c: Update.
4666         * cli/cli-cmds.c: Update.
4667         * cli/cli-interp.c: Update.
4668         * cli/cli-script.c: Update.
4669         * common/common-exceptions.c: Update.
4670         * common/new-op.c: Update.
4671         * common/selftest.c: Update.
4672         * compile/compile-c-symbols.c: Update.
4673         * compile/compile-cplus-symbols.c: Update.
4674         * compile/compile-object-load.c: Update.
4675         * compile/compile-object-run.c: Update.
4676         * completer.c: Update.
4677         * corelow.c: Update.
4678         * cp-abi.c: Update.
4679         * cp-support.c: Update.
4680         * cp-valprint.c: Update.
4681         * darwin-nat.c: Update.
4682         * disasm-selftests.c: Update.
4683         * dtrace-probe.c: Update.
4684         * dwarf-index-cache.c: Update.
4685         * dwarf-index-write.c: Update.
4686         * dwarf2-frame-tailcall.c: Update.
4687         * dwarf2-frame.c: Update.
4688         * dwarf2loc.c: Update.
4689         * dwarf2read.c: Update.
4690         * eval.c: Update.
4691         * event-loop.c: Update.
4692         * event-top.c: Update.
4693         * exec.c: Update.
4694         * f-valprint.c: Update.
4695         * fbsd-tdep.c: Update.
4696         * frame-unwind.c: Update.
4697         * frame.c: Update.
4698         * gdbtypes.c: Update.
4699         * gnu-v3-abi.c: Update.
4700         * guile/guile-internal.h: Update.
4701         * guile/scm-block.c: Update.
4702         * guile/scm-breakpoint.c: Update.
4703         * guile/scm-cmd.c: Update.
4704         * guile/scm-disasm.c: Update.
4705         * guile/scm-frame.c: Update.
4706         * guile/scm-lazy-string.c: Update.
4707         * guile/scm-math.c: Update.
4708         * guile/scm-param.c: Update.
4709         * guile/scm-ports.c: Update.
4710         * guile/scm-pretty-print.c: Update.
4711         * guile/scm-symbol.c: Update.
4712         * guile/scm-symtab.c: Update.
4713         * guile/scm-type.c: Update.
4714         * guile/scm-value.c: Update.
4715         * i386-linux-tdep.c: Update.
4716         * i386-tdep.c: Update.
4717         * inf-loop.c: Update.
4718         * infcall.c: Update.
4719         * infcmd.c: Update.
4720         * infrun.c: Update.
4721         * jit.c: Update.
4722         * language.c: Update.
4723         * linespec.c: Update.
4724         * linux-fork.c: Update.
4725         * linux-nat.c: Update.
4726         * linux-tdep.c: Update.
4727         * linux-thread-db.c: Update.
4728         * main.c: Update.
4729         * mi/mi-cmd-break.c: Update.
4730         * mi/mi-cmd-stack.c: Update.
4731         * mi/mi-interp.c: Update.
4732         * mi/mi-main.c: Update.
4733         * objc-lang.c: Update.
4734         * p-valprint.c: Update.
4735         * parse.c: Update.
4736         * ppc-linux-tdep.c: Update.
4737         * printcmd.c: Update.
4738         * python/py-arch.c: Update.
4739         * python/py-breakpoint.c: Update.
4740         * python/py-cmd.c: Update.
4741         * python/py-finishbreakpoint.c: Update.
4742         * python/py-frame.c: Update.
4743         * python/py-framefilter.c: Update.
4744         * python/py-gdb-readline.c: Update.
4745         * python/py-inferior.c: Update.
4746         * python/py-infthread.c: Update.
4747         * python/py-lazy-string.c: Update.
4748         * python/py-linetable.c: Update.
4749         * python/py-objfile.c: Update.
4750         * python/py-param.c: Update.
4751         * python/py-prettyprint.c: Update.
4752         * python/py-progspace.c: Update.
4753         * python/py-record-btrace.c: Update.
4754         * python/py-record.c: Update.
4755         * python/py-symbol.c: Update.
4756         * python/py-type.c: Update.
4757         * python/py-unwind.c: Update.
4758         * python/py-utils.c: Update.
4759         * python/py-value.c: Update.
4760         * python/python.c: Update.
4761         * record-btrace.c: Update.
4762         * record-full.c: Update.
4763         * remote-fileio.c: Update.
4764         * remote.c: Update.
4765         * riscv-tdep.c: Update.
4766         * rs6000-aix-tdep.c: Update.
4767         * rs6000-tdep.c: Update.
4768         * rust-exp.y: Update.
4769         * rust-lang.c: Update.
4770         * s390-tdep.c: Update.
4771         * selftest-arch.c: Update.
4772         * solib-dsbt.c: Update.
4773         * solib-frv.c: Update.
4774         * solib-spu.c: Update.
4775         * solib-svr4.c: Update.
4776         * solib.c: Update.
4777         * sparc64-linux-tdep.c: Update.
4778         * stack.c: Update.
4779         * symfile-mem.c: Update.
4780         * symmisc.c: Update.
4781         * target.c: Update.
4782         * thread.c: Update.
4783         * top.c: Update.
4784         * tracefile-tfile.c: Update.
4785         * tui/tui.c: Update.
4786         * typeprint.c: Update.
4787         * unittests/cli-utils-selftests.c: Update.
4788         * unittests/parse-connection-spec-selftests.c: Update.
4789         * valops.c: Update.
4790         * valprint.c: Update.
4791         * value.c: Update.
4792         * varobj.c: Update.
4793         * windows-nat.c: Update.
4794         * x86-linux-nat.c: Update.
4795         * xml-support.c: Update.
4796
4797 2019-04-08  Tom Tromey  <tom@tromey.com>
4798
4799         * xml-support.c: Use C++ exception handling.
4800         * x86-linux-nat.c: Use C++ exception handling.
4801         * windows-nat.c: Use C++ exception handling.
4802         * varobj.c: Use C++ exception handling.
4803         * value.c: Use C++ exception handling.
4804         * valprint.c: Use C++ exception handling.
4805         * valops.c: Use C++ exception handling.
4806         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4807         handling.
4808         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4809         * typeprint.c: Use C++ exception handling.
4810         * tui/tui.c: Use C++ exception handling.
4811         * tracefile-tfile.c: Use C++ exception handling.
4812         * top.c: Use C++ exception handling.
4813         * thread.c: Use C++ exception handling.
4814         * target.c: Use C++ exception handling.
4815         * symmisc.c: Use C++ exception handling.
4816         * symfile-mem.c: Use C++ exception handling.
4817         * stack.c: Use C++ exception handling.
4818         * sparc64-linux-tdep.c: Use C++ exception handling.
4819         * solib.c: Use C++ exception handling.
4820         * solib-svr4.c: Use C++ exception handling.
4821         * solib-spu.c: Use C++ exception handling.
4822         * solib-frv.c: Use C++ exception handling.
4823         * solib-dsbt.c: Use C++ exception handling.
4824         * selftest-arch.c: Use C++ exception handling.
4825         * s390-tdep.c: Use C++ exception handling.
4826         * rust-lang.c: Use C++ exception handling.
4827         * rust-exp.y: Use C++ exception handling.
4828         * rs6000-tdep.c: Use C++ exception handling.
4829         * rs6000-aix-tdep.c: Use C++ exception handling.
4830         * riscv-tdep.c: Use C++ exception handling.
4831         * remote.c: Use C++ exception handling.
4832         * remote-fileio.c: Use C++ exception handling.
4833         * record-full.c: Use C++ exception handling.
4834         * record-btrace.c: Use C++ exception handling.
4835         * python/python.c: Use C++ exception handling.
4836         * python/py-value.c: Use C++ exception handling.
4837         * python/py-utils.c: Use C++ exception handling.
4838         * python/py-unwind.c: Use C++ exception handling.
4839         * python/py-type.c: Use C++ exception handling.
4840         * python/py-symbol.c: Use C++ exception handling.
4841         * python/py-record.c: Use C++ exception handling.
4842         * python/py-record-btrace.c: Use C++ exception handling.
4843         * python/py-progspace.c: Use C++ exception handling.
4844         * python/py-prettyprint.c: Use C++ exception handling.
4845         * python/py-param.c: Use C++ exception handling.
4846         * python/py-objfile.c: Use C++ exception handling.
4847         * python/py-linetable.c: Use C++ exception handling.
4848         * python/py-lazy-string.c: Use C++ exception handling.
4849         * python/py-infthread.c: Use C++ exception handling.
4850         * python/py-inferior.c: Use C++ exception handling.
4851         * python/py-gdb-readline.c: Use C++ exception handling.
4852         * python/py-framefilter.c: Use C++ exception handling.
4853         * python/py-frame.c: Use C++ exception handling.
4854         * python/py-finishbreakpoint.c: Use C++ exception handling.
4855         * python/py-cmd.c: Use C++ exception handling.
4856         * python/py-breakpoint.c: Use C++ exception handling.
4857         * python/py-arch.c: Use C++ exception handling.
4858         * printcmd.c: Use C++ exception handling.
4859         * ppc-linux-tdep.c: Use C++ exception handling.
4860         * parse.c: Use C++ exception handling.
4861         * p-valprint.c: Use C++ exception handling.
4862         * objc-lang.c: Use C++ exception handling.
4863         * mi/mi-main.c: Use C++ exception handling.
4864         * mi/mi-interp.c: Use C++ exception handling.
4865         * mi/mi-cmd-stack.c: Use C++ exception handling.
4866         * mi/mi-cmd-break.c: Use C++ exception handling.
4867         * main.c: Use C++ exception handling.
4868         * linux-thread-db.c: Use C++ exception handling.
4869         * linux-tdep.c: Use C++ exception handling.
4870         * linux-nat.c: Use C++ exception handling.
4871         * linux-fork.c: Use C++ exception handling.
4872         * linespec.c: Use C++ exception handling.
4873         * language.c: Use C++ exception handling.
4874         * jit.c: Use C++ exception handling.
4875         * infrun.c: Use C++ exception handling.
4876         * infcmd.c: Use C++ exception handling.
4877         * infcall.c: Use C++ exception handling.
4878         * inf-loop.c: Use C++ exception handling.
4879         * i386-tdep.c: Use C++ exception handling.
4880         * i386-linux-tdep.c: Use C++ exception handling.
4881         * guile/scm-value.c: Use C++ exception handling.
4882         * guile/scm-type.c: Use C++ exception handling.
4883         * guile/scm-symtab.c: Use C++ exception handling.
4884         * guile/scm-symbol.c: Use C++ exception handling.
4885         * guile/scm-pretty-print.c: Use C++ exception handling.
4886         * guile/scm-ports.c: Use C++ exception handling.
4887         * guile/scm-param.c: Use C++ exception handling.
4888         * guile/scm-math.c: Use C++ exception handling.
4889         * guile/scm-lazy-string.c: Use C++ exception handling.
4890         * guile/scm-frame.c: Use C++ exception handling.
4891         * guile/scm-disasm.c: Use C++ exception handling.
4892         * guile/scm-cmd.c: Use C++ exception handling.
4893         * guile/scm-breakpoint.c: Use C++ exception handling.
4894         * guile/scm-block.c: Use C++ exception handling.
4895         * guile/guile-internal.h: Use C++ exception handling.
4896         * gnu-v3-abi.c: Use C++ exception handling.
4897         * gdbtypes.c: Use C++ exception handling.
4898         * frame.c: Use C++ exception handling.
4899         * frame-unwind.c: Use C++ exception handling.
4900         * fbsd-tdep.c: Use C++ exception handling.
4901         * f-valprint.c: Use C++ exception handling.
4902         * exec.c: Use C++ exception handling.
4903         * event-top.c: Use C++ exception handling.
4904         * event-loop.c: Use C++ exception handling.
4905         * eval.c: Use C++ exception handling.
4906         * dwarf2read.c: Use C++ exception handling.
4907         * dwarf2loc.c: Use C++ exception handling.
4908         * dwarf2-frame.c: Use C++ exception handling.
4909         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4910         * dwarf-index-write.c: Use C++ exception handling.
4911         * dwarf-index-cache.c: Use C++ exception handling.
4912         * dtrace-probe.c: Use C++ exception handling.
4913         * disasm-selftests.c: Use C++ exception handling.
4914         * darwin-nat.c: Use C++ exception handling.
4915         * cp-valprint.c: Use C++ exception handling.
4916         * cp-support.c: Use C++ exception handling.
4917         * cp-abi.c: Use C++ exception handling.
4918         * corelow.c: Use C++ exception handling.
4919         * completer.c: Use C++ exception handling.
4920         * compile/compile-object-run.c: Use C++ exception handling.
4921         * compile/compile-object-load.c: Use C++ exception handling.
4922         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4923         * compile/compile-c-symbols.c: Use C++ exception handling.
4924         * common/selftest.c: Use C++ exception handling.
4925         * common/new-op.c: Use C++ exception handling.
4926         * cli/cli-script.c: Use C++ exception handling.
4927         * cli/cli-interp.c: Use C++ exception handling.
4928         * cli/cli-cmds.c: Use C++ exception handling.
4929         * c-varobj.c: Use C++ exception handling.
4930         * btrace.c: Use C++ exception handling.
4931         * breakpoint.c: Use C++ exception handling.
4932         * break-catch-throw.c: Use C++ exception handling.
4933         * arch-utils.c: Use C++ exception handling.
4934         * amd64-tdep.c: Use C++ exception handling.
4935         * ada-valprint.c: Use C++ exception handling.
4936         * ada-typeprint.c: Use C++ exception handling.
4937         * ada-lang.c: Use C++ exception handling.
4938         * aarch64-tdep.c: Use C++ exception handling.
4939
4940 2019-04-08  Tom Tromey  <tom@tromey.com>
4941
4942         * xml-support.c (gdb_xml_parser::parse): Update.
4943         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4944         * value.c (show_convenience): Update.
4945         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4946         (test_parse_flags_qcs): Update.
4947         * thread.c (thr_try_catch_cmd): Update.
4948         * target.c (target_translate_tls_address): Update.
4949         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4950         (info_frame_command_core, frame_apply_command_count): Update.
4951         * rust-exp.y (rust_lex_exception_test): Update.
4952         * riscv-tdep.c (riscv_print_one_register_info): Update.
4953         * remote.c (remote_target::enable_btrace): Update.
4954         * record-btrace.c (record_btrace_enable_warn): Update.
4955         * python/py-utils.c (gdbpy_convert_exception): Update.
4956         * printcmd.c (do_one_display, print_variable_and_value): Update.
4957         * mi/mi-main.c (mi_print_exception): Update.
4958         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4959         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4960         * linux-nat.c (linux_nat_target::attach): Update.
4961         * linux-fork.c (class scoped_switch_fork_info): Update.
4962         * infrun.c (displaced_step_prepare): Update.
4963         * infcall.c (call_function_by_hand_dummy): Update.
4964         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4965         * gnu-v3-abi.c (print_one_vtable): Update.
4966         * frame.c (get_prev_frame_always): Update.
4967         * f-valprint.c (info_common_command_for_block): Update.
4968         * exec.c (try_open_exec_file): Update.
4969         * exceptions.c (print_exception, exception_print)
4970         (exception_fprintf, exception_print_same): Update.
4971         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4972         * dwarf-index-cache.c (index_cache::store)
4973         (index_cache::lookup_gdb_index): Update.
4974         * darwin-nat.c (maybe_cache_shell): Update.
4975         * cp-valprint.c (cp_print_value_fields): Update.
4976         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4977         (gcc_cplus_symbol_address): Update.
4978         * compile/compile-c-symbols.c (gcc_convert_symbol)
4979         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4980         * common/selftest.c: Update.
4981         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4982         a std::string.
4983         (exception_try_scope_entry, exception_try_scope_exit): Don't
4984         declare.
4985         (struct exception_try_scope): Remove.
4986         (TRY): Don't use exception_try_scope.
4987         (struct gdb_exception): Add constructor, operator=.
4988         <what>: New method.
4989         (struct gdb_exception_RETURN_MASK_ALL)
4990         (struct gdb_exception_RETURN_MASK_ERROR)
4991         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4992         (struct gdb_quit_bad_alloc): Update.
4993         * common/common-exceptions.c (exception_none): Change
4994         initializer.
4995         (struct catcher) <state, exception>: Initialize inline.
4996         <prev>: Remove member.
4997         (current_catcher): Remove.
4998         (catchers): New global.
4999         (exceptions_state_mc_init): Simplify.
5000         (catcher_pop): Remove.
5001         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5002         (try_scope_depth, exception_try_scope_entry)
5003         (exception_try_scope_exit): Remove.
5004         (throw_exception_sjlj): Update.
5005         (exception_messages, exception_messages_size): Remove.
5006         (throw_it): Simplify.
5007         (gdb_exception_sliced_copy): Remove.
5008         (throw_exception_cxx): Update.
5009         * cli/cli-script.c (script_from_file): Update.
5010         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5011         Update.
5012         * ada-valprint.c (ada_val_print): Update.
5013         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5014         (create_excep_cond_exprs): Update.
5015
5016 2019-04-08  Tom Tromey  <tom@tromey.com>
5017
5018         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5019         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5020         (TRY, CATCH, END_CATCH): Remove some definitions.
5021         * common/common-exceptions.c: Don't use GDB_XCPT.
5022         (catcher_list_size): Remove.
5023         (throw_exception, throw_it): Simplify.
5024
5025 2019-04-05  Tom Tromey  <tom@tromey.com>
5026
5027         Revert the header-sorting patch.
5028         * ft32-tdep.c: Revert.
5029         * frv-tdep.c: Revert.
5030         * frv-linux-tdep.c: Revert.
5031         * frame.c: Revert.
5032         * frame-unwind.c: Revert.
5033         * frame-base.c: Revert.
5034         * fork-child.c: Revert.
5035         * findvar.c: Revert.
5036         * findcmd.c: Revert.
5037         * filesystem.c: Revert.
5038         * filename-seen-cache.h: Revert.
5039         * filename-seen-cache.c: Revert.
5040         * fbsd-tdep.c: Revert.
5041         * fbsd-nat.h: Revert.
5042         * fbsd-nat.c: Revert.
5043         * f-valprint.c: Revert.
5044         * f-typeprint.c: Revert.
5045         * f-lang.c: Revert.
5046         * extension.h: Revert.
5047         * extension.c: Revert.
5048         * extension-priv.h: Revert.
5049         * expprint.c: Revert.
5050         * exec.h: Revert.
5051         * exec.c: Revert.
5052         * exceptions.c: Revert.
5053         * event-top.c: Revert.
5054         * event-loop.c: Revert.
5055         * eval.c: Revert.
5056         * elfread.c: Revert.
5057         * dwarf2read.h: Revert.
5058         * dwarf2read.c: Revert.
5059         * dwarf2loc.c: Revert.
5060         * dwarf2expr.h: Revert.
5061         * dwarf2expr.c: Revert.
5062         * dwarf2-frame.c: Revert.
5063         * dwarf2-frame-tailcall.c: Revert.
5064         * dwarf-index-write.h: Revert.
5065         * dwarf-index-write.c: Revert.
5066         * dwarf-index-common.c: Revert.
5067         * dwarf-index-cache.h: Revert.
5068         * dwarf-index-cache.c: Revert.
5069         * dummy-frame.c: Revert.
5070         * dtrace-probe.c: Revert.
5071         * disasm.h: Revert.
5072         * disasm.c: Revert.
5073         * disasm-selftests.c: Revert.
5074         * dictionary.c: Revert.
5075         * dicos-tdep.c: Revert.
5076         * demangle.c: Revert.
5077         * dcache.h: Revert.
5078         * dcache.c: Revert.
5079         * darwin-nat.h: Revert.
5080         * darwin-nat.c: Revert.
5081         * darwin-nat-info.c: Revert.
5082         * d-valprint.c: Revert.
5083         * d-namespace.c: Revert.
5084         * d-lang.c: Revert.
5085         * ctf.c: Revert.
5086         * csky-tdep.c: Revert.
5087         * csky-linux-tdep.c: Revert.
5088         * cris-tdep.c: Revert.
5089         * cris-linux-tdep.c: Revert.
5090         * cp-valprint.c: Revert.
5091         * cp-support.c: Revert.
5092         * cp-namespace.c: Revert.
5093         * cp-abi.c: Revert.
5094         * corelow.c: Revert.
5095         * corefile.c: Revert.
5096         * continuations.c: Revert.
5097         * completer.h: Revert.
5098         * completer.c: Revert.
5099         * complaints.c: Revert.
5100         * coffread.c: Revert.
5101         * coff-pe-read.c: Revert.
5102         * cli-out.h: Revert.
5103         * cli-out.c: Revert.
5104         * charset.c: Revert.
5105         * c-varobj.c: Revert.
5106         * c-valprint.c: Revert.
5107         * c-typeprint.c: Revert.
5108         * c-lang.c: Revert.
5109         * buildsym.c: Revert.
5110         * buildsym-legacy.c: Revert.
5111         * build-id.h: Revert.
5112         * build-id.c: Revert.
5113         * btrace.c: Revert.
5114         * bsd-uthread.c: Revert.
5115         * breakpoint.h: Revert.
5116         * breakpoint.c: Revert.
5117         * break-catch-throw.c: Revert.
5118         * break-catch-syscall.c: Revert.
5119         * break-catch-sig.c: Revert.
5120         * blockframe.c: Revert.
5121         * block.c: Revert.
5122         * bfin-tdep.c: Revert.
5123         * bfin-linux-tdep.c: Revert.
5124         * bfd-target.c: Revert.
5125         * bcache.c: Revert.
5126         * ax-general.c: Revert.
5127         * ax-gdb.h: Revert.
5128         * ax-gdb.c: Revert.
5129         * avr-tdep.c: Revert.
5130         * auxv.c: Revert.
5131         * auto-load.c: Revert.
5132         * arm-wince-tdep.c: Revert.
5133         * arm-tdep.c: Revert.
5134         * arm-symbian-tdep.c: Revert.
5135         * arm-pikeos-tdep.c: Revert.
5136         * arm-obsd-tdep.c: Revert.
5137         * arm-nbsd-tdep.c: Revert.
5138         * arm-nbsd-nat.c: Revert.
5139         * arm-linux-tdep.c: Revert.
5140         * arm-linux-nat.c: Revert.
5141         * arm-fbsd-tdep.c: Revert.
5142         * arm-fbsd-nat.c: Revert.
5143         * arm-bsd-tdep.c: Revert.
5144         * arch-utils.c: Revert.
5145         * arc-tdep.c: Revert.
5146         * arc-newlib-tdep.c: Revert.
5147         * annotate.h: Revert.
5148         * annotate.c: Revert.
5149         * amd64-windows-tdep.c: Revert.
5150         * amd64-windows-nat.c: Revert.
5151         * amd64-tdep.c: Revert.
5152         * amd64-sol2-tdep.c: Revert.
5153         * amd64-obsd-tdep.c: Revert.
5154         * amd64-obsd-nat.c: Revert.
5155         * amd64-nbsd-tdep.c: Revert.
5156         * amd64-nbsd-nat.c: Revert.
5157         * amd64-nat.c: Revert.
5158         * amd64-linux-tdep.c: Revert.
5159         * amd64-linux-nat.c: Revert.
5160         * amd64-fbsd-tdep.c: Revert.
5161         * amd64-fbsd-nat.c: Revert.
5162         * amd64-dicos-tdep.c: Revert.
5163         * amd64-darwin-tdep.c: Revert.
5164         * amd64-bsd-nat.c: Revert.
5165         * alpha-tdep.c: Revert.
5166         * alpha-obsd-tdep.c: Revert.
5167         * alpha-nbsd-tdep.c: Revert.
5168         * alpha-mdebug-tdep.c: Revert.
5169         * alpha-linux-tdep.c: Revert.
5170         * alpha-linux-nat.c: Revert.
5171         * alpha-bsd-tdep.c: Revert.
5172         * alpha-bsd-nat.c: Revert.
5173         * aix-thread.c: Revert.
5174         * agent.c: Revert.
5175         * addrmap.c: Revert.
5176         * ada-varobj.c: Revert.
5177         * ada-valprint.c: Revert.
5178         * ada-typeprint.c: Revert.
5179         * ada-tasks.c: Revert.
5180         * ada-lang.c: Revert.
5181         * aarch64-tdep.c: Revert.
5182         * aarch64-ravenscar-thread.c: Revert.
5183         * aarch64-newlib-tdep.c: Revert.
5184         * aarch64-linux-tdep.c: Revert.
5185         * aarch64-linux-nat.c: Revert.
5186         * aarch64-fbsd-tdep.c: Revert.
5187         * aarch64-fbsd-nat.c: Revert.
5188         * aarch32-linux-nat.c: Revert.
5189
5190 2019-04-05  Tom Tromey  <tom@tromey.com>
5191
5192         * ft32-tdep.c: Sort headers.
5193         * frv-tdep.c: Sort headers.
5194         * frv-linux-tdep.c: Sort headers.
5195         * frame.c: Sort headers.
5196         * frame-unwind.c: Sort headers.
5197         * frame-base.c: Sort headers.
5198         * fork-child.c: Sort headers.
5199         * findvar.c: Sort headers.
5200         * findcmd.c: Sort headers.
5201         * filesystem.c: Sort headers.
5202         * filename-seen-cache.h: Sort headers.
5203         * filename-seen-cache.c: Sort headers.
5204         * fbsd-tdep.c: Sort headers.
5205         * fbsd-nat.h: Sort headers.
5206         * fbsd-nat.c: Sort headers.
5207         * f-valprint.c: Sort headers.
5208         * f-typeprint.c: Sort headers.
5209         * f-lang.c: Sort headers.
5210         * extension.h: Sort headers.
5211         * extension.c: Sort headers.
5212         * extension-priv.h: Sort headers.
5213         * expprint.c: Sort headers.
5214         * exec.h: Sort headers.
5215         * exec.c: Sort headers.
5216         * exceptions.c: Sort headers.
5217         * event-top.c: Sort headers.
5218         * event-loop.c: Sort headers.
5219         * eval.c: Sort headers.
5220         * elfread.c: Sort headers.
5221         * dwarf2read.h: Sort headers.
5222         * dwarf2read.c: Sort headers.
5223         * dwarf2loc.c: Sort headers.
5224         * dwarf2expr.h: Sort headers.
5225         * dwarf2expr.c: Sort headers.
5226         * dwarf2-frame.c: Sort headers.
5227         * dwarf2-frame-tailcall.c: Sort headers.
5228         * dwarf-index-write.h: Sort headers.
5229         * dwarf-index-write.c: Sort headers.
5230         * dwarf-index-common.c: Sort headers.
5231         * dwarf-index-cache.h: Sort headers.
5232         * dwarf-index-cache.c: Sort headers.
5233         * dummy-frame.c: Sort headers.
5234         * dtrace-probe.c: Sort headers.
5235         * disasm.h: Sort headers.
5236         * disasm.c: Sort headers.
5237         * disasm-selftests.c: Sort headers.
5238         * dictionary.c: Sort headers.
5239         * dicos-tdep.c: Sort headers.
5240         * demangle.c: Sort headers.
5241         * dcache.h: Sort headers.
5242         * dcache.c: Sort headers.
5243         * darwin-nat.h: Sort headers.
5244         * darwin-nat.c: Sort headers.
5245         * darwin-nat-info.c: Sort headers.
5246         * d-valprint.c: Sort headers.
5247         * d-namespace.c: Sort headers.
5248         * d-lang.c: Sort headers.
5249         * ctf.c: Sort headers.
5250         * csky-tdep.c: Sort headers.
5251         * csky-linux-tdep.c: Sort headers.
5252         * cris-tdep.c: Sort headers.
5253         * cris-linux-tdep.c: Sort headers.
5254         * cp-valprint.c: Sort headers.
5255         * cp-support.c: Sort headers.
5256         * cp-namespace.c: Sort headers.
5257         * cp-abi.c: Sort headers.
5258         * corelow.c: Sort headers.
5259         * corefile.c: Sort headers.
5260         * continuations.c: Sort headers.
5261         * completer.h: Sort headers.
5262         * completer.c: Sort headers.
5263         * complaints.c: Sort headers.
5264         * coffread.c: Sort headers.
5265         * coff-pe-read.c: Sort headers.
5266         * cli-out.h: Sort headers.
5267         * cli-out.c: Sort headers.
5268         * charset.c: Sort headers.
5269         * c-varobj.c: Sort headers.
5270         * c-valprint.c: Sort headers.
5271         * c-typeprint.c: Sort headers.
5272         * c-lang.c: Sort headers.
5273         * buildsym.c: Sort headers.
5274         * buildsym-legacy.c: Sort headers.
5275         * build-id.h: Sort headers.
5276         * build-id.c: Sort headers.
5277         * btrace.c: Sort headers.
5278         * bsd-uthread.c: Sort headers.
5279         * breakpoint.h: Sort headers.
5280         * breakpoint.c: Sort headers.
5281         * break-catch-throw.c: Sort headers.
5282         * break-catch-syscall.c: Sort headers.
5283         * break-catch-sig.c: Sort headers.
5284         * blockframe.c: Sort headers.
5285         * block.c: Sort headers.
5286         * bfin-tdep.c: Sort headers.
5287         * bfin-linux-tdep.c: Sort headers.
5288         * bfd-target.c: Sort headers.
5289         * bcache.c: Sort headers.
5290         * ax-general.c: Sort headers.
5291         * ax-gdb.h: Sort headers.
5292         * ax-gdb.c: Sort headers.
5293         * avr-tdep.c: Sort headers.
5294         * auxv.c: Sort headers.
5295         * auto-load.c: Sort headers.
5296         * arm-wince-tdep.c: Sort headers.
5297         * arm-tdep.c: Sort headers.
5298         * arm-symbian-tdep.c: Sort headers.
5299         * arm-pikeos-tdep.c: Sort headers.
5300         * arm-obsd-tdep.c: Sort headers.
5301         * arm-nbsd-tdep.c: Sort headers.
5302         * arm-nbsd-nat.c: Sort headers.
5303         * arm-linux-tdep.c: Sort headers.
5304         * arm-linux-nat.c: Sort headers.
5305         * arm-fbsd-tdep.c: Sort headers.
5306         * arm-fbsd-nat.c: Sort headers.
5307         * arm-bsd-tdep.c: Sort headers.
5308         * arch-utils.c: Sort headers.
5309         * arc-tdep.c: Sort headers.
5310         * arc-newlib-tdep.c: Sort headers.
5311         * annotate.h: Sort headers.
5312         * annotate.c: Sort headers.
5313         * amd64-windows-tdep.c: Sort headers.
5314         * amd64-windows-nat.c: Sort headers.
5315         * amd64-tdep.c: Sort headers.
5316         * amd64-sol2-tdep.c: Sort headers.
5317         * amd64-obsd-tdep.c: Sort headers.
5318         * amd64-obsd-nat.c: Sort headers.
5319         * amd64-nbsd-tdep.c: Sort headers.
5320         * amd64-nbsd-nat.c: Sort headers.
5321         * amd64-nat.c: Sort headers.
5322         * amd64-linux-tdep.c: Sort headers.
5323         * amd64-linux-nat.c: Sort headers.
5324         * amd64-fbsd-tdep.c: Sort headers.
5325         * amd64-fbsd-nat.c: Sort headers.
5326         * amd64-dicos-tdep.c: Sort headers.
5327         * amd64-darwin-tdep.c: Sort headers.
5328         * amd64-bsd-nat.c: Sort headers.
5329         * alpha-tdep.c: Sort headers.
5330         * alpha-obsd-tdep.c: Sort headers.
5331         * alpha-nbsd-tdep.c: Sort headers.
5332         * alpha-mdebug-tdep.c: Sort headers.
5333         * alpha-linux-tdep.c: Sort headers.
5334         * alpha-linux-nat.c: Sort headers.
5335         * alpha-bsd-tdep.c: Sort headers.
5336         * alpha-bsd-nat.c: Sort headers.
5337         * aix-thread.c: Sort headers.
5338         * agent.c: Sort headers.
5339         * addrmap.c: Sort headers.
5340         * ada-varobj.c: Sort headers.
5341         * ada-valprint.c: Sort headers.
5342         * ada-typeprint.c: Sort headers.
5343         * ada-tasks.c: Sort headers.
5344         * ada-lang.c: Sort headers.
5345         * aarch64-tdep.c: Sort headers.
5346         * aarch64-ravenscar-thread.c: Sort headers.
5347         * aarch64-newlib-tdep.c: Sort headers.
5348         * aarch64-linux-tdep.c: Sort headers.
5349         * aarch64-linux-nat.c: Sort headers.
5350         * aarch64-fbsd-tdep.c: Sort headers.
5351         * aarch64-fbsd-nat.c: Sort headers.
5352         * aarch32-linux-nat.c: Sort headers.
5353
5354 2019-04-04  Tom Tromey  <tom@tromey.com>
5355
5356         * varobj.c (varobj_create): Update.
5357         * rust-exp.y (struct rust_parser) <update_innermost_block,
5358         lookup_symbol>: New methods.
5359         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5360         Rename.
5361         (rust_parser::rust_lookup_type)
5362         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5363         * printcmd.c (display_command, do_one_display): Update.
5364         * parser-defs.h (struct parser_state) <parser_state>: Add
5365         "tracker" parameter.
5366         (block_tracker): New member.
5367         (class innermost_block_tracker) <innermost_block_tracker>: Add
5368         "types" parameter.
5369         <reset>: Remove method.
5370         (innermost_block): Don't declare.
5371         (null_post_parser): Update.
5372         * parse.c (innermost_block): Remove global.
5373         (write_dollar_variable): Update.
5374         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5375         Remove "tracker_types" parameter.
5376         (parse_expression): Add "tracker" parameter.
5377         (parse_expression_for_completion): Update.
5378         (null_post_parser): Add "tracker" parameter.
5379         * p-exp.y: Update rules.
5380         * m2-exp.y: Update rules.
5381         * language.h (struct language_defn) <la_post_parser>: Add
5382         "tracker" parameter.
5383         * go-exp.y: Update rules.
5384         * f-exp.y: Update rules.
5385         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5386         parameter.
5387         * d-exp.y: Update rules.
5388         * c-exp.y: Update rules.
5389         * breakpoint.c (set_breakpoint_condition): Create an
5390         innermost_block_tracker.
5391         (watch_command_1): Likewise.
5392         * ada-lang.c (resolve): Add "tracker" parameter.
5393         (resolve_subexp): Likewise.
5394         * ada-exp.y (write_var_from_sym): Update.
5395
5396 2019-04-04  Tom Tromey  <tom@tromey.com>
5397
5398         * type-stack.h: New file.
5399         * type-stack.c: New file.
5400         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5401         type-stack.h.
5402         (insert_into_type_stack, insert_type, push_type, push_type_int)
5403         (insert_type_address_space, pop_type, pop_type_int)
5404         (pop_typelist, pop_type_stack, append_type_stack)
5405         (push_type_stack, get_type_stack, push_typelist)
5406         (follow_type_instance_flags, follow_types): Don't declare.
5407         * parse.c (type_stack): Remove global.
5408         (parse_exp_in_context): Update.
5409         (insert_into_type_stack, insert_type, push_type, push_type_int)
5410         (insert_type_address_space, pop_type, pop_type_int)
5411         (pop_typelist, pop_type_stack, append_type_stack)
5412         (push_type_stack, get_type_stack, push_typelist)
5413         (follow_type_instance_flags, follow_types): Remove (moved to
5414         type-stack.c).
5415         * f-exp.y (type_stack): New global.
5416         Update rules.
5417         (push_kind_type, f_parse): Update.
5418         * d-exp.y (type_stack): New global.
5419         Update rules.
5420         (d_parse): Update.
5421         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5422         Update rules.
5423         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5424         (HFILES_NO_SRCDIR): Add type-stack.h.
5425
5426 2019-04-04  Tom Tromey  <tom@tromey.com>
5427
5428         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5429         (rust_parser::convert_ast_to_expression, rust_parse)
5430         (rust_lex_test_completion, rust_lex_tests): Update.
5431         * parser-defs.h (struct expr_completion_state): New.
5432         (struct parser_state) <parser_state>: Add completion parameter.
5433         <mark_struct_expression, mark_completion_tag>: New methods.
5434         <parse_completion, m_completion_state>: New members.
5435         (prefixify_expression, null_post_parser): Update.
5436         (mark_struct_expression, mark_completion_tag): Don't declare.
5437         * parse.c (parse_completion, expout_last_struct)
5438         (expout_tag_completion_type, expout_completion_name): Remove
5439         globals.
5440         (parser_state::mark_struct_expression)
5441         (parser_state::mark_completion_tag): Now methods.
5442         (prefixify_expression): Add last_struct parameter.
5443         (prefixify_subexp): Likewise.
5444         (parse_exp_1): Update.
5445         (parse_exp_in_context): Add cstate parameter.  Update.
5446         (parse_expression_for_completion): Create an
5447         expr_completion_state.
5448         (null_post_parser): Add "completion" parameter.
5449         * p-exp.y: Update rules.
5450         (yylex): Update.
5451         * language.h (struct language_defn) <la_post_parser>: Add
5452         "completing" parameter.
5453         * go-exp.y: Update rules.
5454         (lex_one_token): Update.
5455         * expression.h (parse_completion): Don't declare.
5456         * d-exp.y: Update rules.
5457         (lex_one_token): Update rules.
5458         * c-exp.y: Update rules.
5459         (lex_one_token): Update.
5460         * ada-lang.c (resolve): Add "parse_completion" parameter.
5461         (resolve_subexp): Likewise.
5462         (ada_resolve_function): Likewise.
5463
5464 2019-04-04  Tom Tromey  <tom@tromey.com>
5465
5466         * parser-defs.h (struct parser_state) <start_arglist,
5467         end_arglist>: New methods.
5468         <arglist_len, m_funcall_chain>: New members.
5469         (arglist_len, start_arglist, end_arglist): Don't declare.
5470         * parse.c (arglist_len, funcall_chain): Remove global.
5471         (start_arglist, end_arglist): Remove functions.
5472         (parse_exp_in_context): Update.
5473         * p-exp.y: Update rules.
5474         * m2-exp.y: Update rules.
5475         * go-exp.y: Update rules.
5476         * f-exp.y: Update rules.
5477         * d-exp.y: Update rules.
5478         * c-exp.y: Update rules.
5479
5480 2019-04-04  Tom Tromey  <tom@tromey.com>
5481
5482         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5483         lex_operator, push_back>: New methods.
5484         Update all rules.
5485         (rust_parser::lex_hex, lex_escape): Rename and update.
5486         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5487         (rust_parser::lex_operator): Rename and update.
5488         (rust_parser::lex_number, rustyylex, rustyyerror)
5489         (rust_lex_test_init, rust_lex_test_sequence)
5490         (rust_lex_test_push_back, rust_lex_tests): Update.
5491         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5492         parameter.
5493         <lexptr, prev_lexptr>: New members.
5494         (lexptr, prev_lexptr): Don't declare.
5495         * parse.c (lexptr, prev_lexptr): Remove globals.
5496         (parse_exp_in_context): Update.
5497         * p-exp.y (yylex, yyerror): Update.
5498         * m2-exp.y (parse_number, yylex, yyerror): Update.
5499         * go-exp.y (lex_one_token, yyerror): Update.
5500         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5501         * d-exp.y (lex_one_token, yyerror): Update.
5502         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5503         (lex_one_token, yyerror): Update.
5504         * ada-lex.l (YY_INPUT): Update.
5505         (rewind_to_char): Update.
5506         * ada-exp.y (yyerror): Update.
5507
5508 2019-04-04  Tom Tromey  <tom@tromey.com>
5509
5510         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5511         * parser-defs.h (struct parser_state) <parser_state>: Add new
5512         parameter.
5513         <comma_terminates>: New member.
5514         (comma_terminates): Don't declare global.
5515         * parse.c (comma_terminates): Remove global.
5516         (parse_exp_in_context): Update.
5517         * p-exp.y (yylex): Update.
5518         * m2-exp.y (yylex): Update.
5519         * go-exp.y (lex_one_token): Update.
5520         * f-exp.y (yylex): Update.
5521         * d-exp.y (lex_one_token): Update.
5522         * c-exp.y (lex_one_token): Update.
5523         * ada-lex.l: Update.
5524
5525 2019-04-04  Tom Tromey  <tom@tromey.com>
5526
5527         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5528         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5529         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5530         * parser-defs.h (paren_depth): Don't declare.
5531         * parse.c (paren_depth): Remove global.
5532         (parse_exp_in_context): Update.
5533         * p-exp.y (paren_depth): New global.
5534         (pascal_parse): Initialize it.
5535         * m2-exp.y (paren_depth): New global.
5536         (m2_parse): Initialize it.
5537         * go-exp.y (paren_depth): New global.
5538         (go_parse): Initialize it.
5539         * f-exp.y (paren_depth): New global.
5540         (f_parse): Initialize it.
5541         * d-exp.y (paren_depth): New global.
5542         (d_parse): Initialize it.
5543         * c-exp.y (paren_depth): New global.
5544         (c_parse): Initialize it.
5545         * ada-lex.l (paren_depth): New global.
5546         (lexer_init): Initialize it.
5547
5548 2019-04-04  Tom Tromey  <tom@tromey.com>
5549
5550         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5551         (rust_parser::convert_ast_to_type)
5552         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5553         * parser-defs.h (struct parser_state) <parser_state>: Add
5554         parameters.  Initialize new members.
5555         <expression_context_block, expression_context_pc>: New members.
5556         * parse.c (expression_context_block, expression_context_pc):
5557         Remove globals.
5558         (parse_exp_in_context): Update.
5559         * p-exp.y: Update all rules.
5560         (yylex): Update.
5561         * m2-exp.y: Update all rules.
5562         (yylex): Update.
5563         * go-exp.y (yylex): Update.
5564         * f-exp.y (yylex): Update.
5565         * d-exp.y: Update all rules.
5566         (yylex): Update.
5567         * c-exp.y: Update all rules.
5568         (lex_one_token, classify_name, yylex, c_parse): Update.
5569         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5570
5571 2019-04-04  Tom Tromey  <tom@tromey.com>
5572
5573         * gdbarch.h, gdbarch.c: Rebuild.
5574         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5575         * stap-probe.h:
5576         (struct stap_parse_info): Replace "parser_state" with
5577         "expr_builder".
5578         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5579         (parser_state): New class.
5580         * parse.c (expr_builder): Rename.
5581         (expr_builder::release): Rename.
5582         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5583         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5584         (write_exp_elt_longcst, write_exp_elt_floatcst)
5585         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5586         (write_exp_string_vector, write_exp_bitstring)
5587         (write_exp_msymbol, mark_struct_expression)
5588         (write_dollar_variable)
5589         (insert_type_address_space, increase_expout_size): Replace
5590         "parser_state" with "expr_builder".
5591         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5592         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5593         "parser_state" with "expr_builder".
5594
5595 2019-04-04  Tom Tromey  <tom@tromey.com>
5596
5597         * rust-exp.y: Replace "parse_language" with method call.
5598         * p-exp.y:
5599         (yylex): Replace "parse_language" with method call.
5600         * m2-exp.y:
5601         (yylex): Replace "parse_language" with method call.
5602         * go-exp.y (classify_name): Replace "parse_language" with method
5603         call.
5604         * f-exp.y (yylex): Replace "parse_language" with method call.
5605         * d-exp.y (lex_one_token): Replace "parse_language" with method
5606         call.
5607         * c-exp.y:
5608         (lex_one_token, classify_name, yylex): Replace "parse_language"
5609         with method call.
5610         * ada-exp.y (find_primitive_type, type_char)
5611         (type_system_address): Replace "parse_language" with method call.
5612
5613 2019-04-04  Tom Tromey  <tom@tromey.com>
5614
5615         * rust-exp.y: Replace "parse_gdbarch" with method call.
5616         * parse.c (write_dollar_variable, insert_type_address_space):
5617         Replace "parse_gdbarch" with method call.
5618         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5619         call.
5620         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5621         call.
5622         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5623         "parse_gdbarch" with method call.
5624         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5625         with method call.
5626         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5627         "parse_gdbarch" with method call.
5628         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5629         "parse_gdbarch" with method call.
5630         * c-exp.y (parse_type, parse_number, classify_name): Replace
5631         "parse_gdbarch" with method call.
5632         * ada-lex.l: Replace "parse_gdbarch" with method call.
5633         * ada-exp.y (parse_type, find_primitive_type, type_char)
5634         (type_system_address): Replace "parse_gdbarch" with method call.
5635
5636 2019-04-04  Tom Tromey  <tom@tromey.com>
5637
5638         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5639         * stap-probe.c (stap_parse_argument): Update.
5640         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5641         initial_size parameter.
5642         * rust-exp.y (rust_lex_tests): Update.
5643         * parse.c (parser_state): Update.
5644         (parse_exp_in_context): Update.
5645         * parser-defs.h (struct parser_state) <parser_state>: Remove
5646         "initial_size" parameter.
5647
5648 2019-04-04  Tom Tromey  <tom@tromey.com>
5649
5650         * parser-defs.h (increase_expout_size): Don't declare.
5651         * parse.c (increase_expout_size): Now static.
5652
5653 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5654
5655         * gnu-nat.c (gnu_nat_target::wait): Fix
5656         target_waitstatus_to_string call.
5657
5658 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5659
5660         * eval.c (evaluate_subexp_standard): Handle internal functions
5661         during Fortran function call handling.
5662
5663 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5664
5665         * NEWS: Mention new internal functions.
5666         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5667         (read_base_type): Use dwarf2_init_complex_target_type.
5668         * value.c (creal_internal_fn): New function.
5669         (cimag_internal_fn): New function.
5670         (_initialize_values): Register new internal functions.
5671
5672 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5673
5674         * infrun.c (stop_all_threads): If debug_infrun, always
5675         trace the wait status after wait_one, using
5676         target_waitstatus_to_string and target_pid_to_str.
5677         (handle_inferior_event): Replace various trace of
5678         wait status kind by a single trace.
5679         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5680         wait status kind image by target_waitstatus_to_string.
5681         * target/waitstatus.c (target_waitstatus_to_string): Fix
5682         obsolete comment.
5683
5684 2019-04-01  Tom Tromey  <tromey@adacore.com>
5685
5686         PR symtab/23331:
5687         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5688
5689 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5690             Pedro Alves  <palves@redhat.com>
5691
5692         * top.c (quit_force): Call 'finalize_values'.
5693         * value.c (finalize_values): New function.
5694         * value.h (finalize_values): Declare.
5695
5696 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5697
5698         * NEWS: Announce $_gdb_major and $_gdb_minor.
5699
5700         * top.c (init_gdb_version_vars): New function.
5701         (gdb_init): Call init_gdb_version_vars.
5702
5703 2019-03-29  Tom Tromey  <tromey@adacore.com>
5704
5705         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5706         help text.  Remove dead code.
5707
5708 2019-03-29  Keith Seitz  <keiths@redhat.com>
5709
5710         From Siddhesh Poyarekar:
5711         * f-lang.h (f77_get_upperbound): Return LONGEST.
5712         (f77_get_lowerbound): Likewise.
5713         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5714         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5715         print them.
5716         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5717         plongest to format print it.
5718         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5719         (f77_get_upperbound): Likewise.
5720         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5721         LOWER_BOUND to LONGEST.
5722         (f77_create_arrayprint_offset_tbl): Likewise.
5723
5724 2019-03-29  Keith Seitz  <keiths@redhat.com>
5725
5726         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5727         %s/pulongest for TYPE_LENGTH instead of %d in format
5728         strings.
5729         * ada-typerint.c (ada_print_type): Likewise.
5730         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5731         * compile/compile-c-support.c (generate_register_struct): Likewise.
5732         * gdbtypes.c (recursive_dump_type): Likewise.
5733         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5734         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5735         instead of %d in format strings.
5736         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5737         to std::min to ULONGEST.
5738         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5739         instead of %d in format strings.
5740         * tracepoint.c (info_scope_command): Likewise.
5741         * typeprint.c (print_offset_data::update)
5742         (print_offset_data::finish): Likewise.
5743         * xtensa-tdep.c (xtensa_store_return_value)
5744         (xtensa_push_dummy_call): Likewise.
5745
5746 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5747
5748         * windows-nat.c (display_selector): Fixed format specifications
5749         for 64-bit Cygwin.
5750
5751 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5752
5753         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5754
5755 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5756
5757         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5758         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5759         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5760         (nios2_linux_init_abi): Install it.
5761
5762 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5763
5764         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5765
5766 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5767
5768         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5769
5770 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5771             Tom Tromey  <tromey@adacore.com>
5772
5773         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5774
5775 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5776
5777         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5778         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5779         method to compute the bounds of range types. Also print "[evaluated]"
5780         if the bounds' values come from a dynamic evaluation.
5781
5782 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5785         whitespace when pretty printing is on.
5786
5787 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5788
5789         * ppc-linux-nat.c: Add include.
5790
5791 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5792
5793         * NEWS: Mention AArch64 Pointer Authentication.
5794
5795 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5796
5797         * arm-linux-nat.c: Add include.
5798
5799 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5800
5801         * source-cache.c (source_cache::get_source_lines): Re-read
5802         fullname after calling open_source_file.
5803
5804 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5805
5806         * NEWS: Mention TLS support for FreeBSD.
5807
5808 2019-03-25  Tom Tromey  <tromey@adacore.com>
5809
5810         * minsyms.c (BUNCH_SIZE): Update comment.
5811         (~minimal_symbol_reader): Remove old comment.
5812         (compact_minimal_symbols): Update comment.
5813         (minimal_symbol_reader::install): Remove old comment.  Update
5814         other comments.
5815
5816 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5817
5818         * s390-linux-nat.c: Add include.
5819
5820 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5821
5822         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5823         Call linux_get_hwcap.
5824         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5825         Likewise.
5826         (aarch64_linux_get_hwcap): Remove function.
5827         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5828         declaration.
5829         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5830         linux_get_hwcap.
5831         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5832         * linux-tdep.c (linux_get_hwcap): Add function.
5833         (linux_get_hwcap2): Likewise.
5834         * linux-tdep.h (linux_get_hwcap): Add declaration.
5835         (linux_get_hwcap2): Likewise.
5836         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5837         (ppc_linux_get_hwcap2): Likewise.
5838         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5839         linux_get_hwcap.
5840         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5841         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5842         (ppc_linux_nat_target::read_description): Likewise.
5843         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5844         * s390-linux-nat.c: Likewise.
5845         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5846
5847 2019-03-24  Tom Tromey  <tom@tromey.com>
5848
5849         * ada-lang.c (standard_lookup): Simplify initialization.
5850         (ada_lookup_symbol_nonlocal): Simplify return.
5851         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5852         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5853         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5854         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5855         initialization.
5856         * solib.c (solib_global_lookup): Simplify.
5857         * symtab.c (null_block_symbol): Remove.
5858         (symbol_cache_lookup): Simplify returns.
5859         (lookup_language_this): Simplify returns.
5860         (lookup_symbol_aux): Simplify return.
5861         (lookup_local_symbol): Simplify returns.
5862         (lookup_global_symbol_from_objfile): Simplify return.
5863         (lookup_symbol_in_objfile_symtabs)
5864         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5865         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5866         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5867         * cp-namespace.c (cp_lookup_bare_symbol)
5868         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5869         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5870         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5871         (cp_lookup_symbol_via_imports): Simplify initialization.
5872         (find_symbol_in_baseclass): Likewise.
5873         * symtab.h (null_block_symbol): Remove.
5874         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5875         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5876         (d_lookup_symbol_module): Likewise.
5877         (find_symbol_in_baseclass): Simplify initialization.
5878
5879 2019-03-24  Tom Tromey  <tom@tromey.com>
5880
5881         * expression.h: Don't include symtab.h.
5882         (struct block): Forward declare.
5883
5884 2019-03-24  Tom Tromey  <tom@tromey.com>
5885
5886         * c-exp.y (typebase): Remove casts.
5887         * gdbtypes.c (lookup_unsigned_typename, )
5888         (lookup_signed_typename): Remove cast.
5889         * eval.c (parse_to_comma_and_eval): Remove cast.
5890         * parse.c (write_dollar_variable): Remove cast.
5891         * block.h (struct block) <superblock>: Now const.
5892         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5893         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5894         (map_block): Make "block" const.
5895         * symfile.h (struct quick_symbol_functions)
5896         <map_matching_symbols>: Constify block argument to "callback".
5897         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5898         const.
5899         (find_pc_sect_compunit_symtab): Make "b" const.
5900         (find_symbol_at_address): Likewise.
5901         (search_symbols): Likewise.
5902         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5903         (dw2_debug_names_lookup_symbol): Likewise.
5904         (dw2_map_matching_symbols): Update.
5905         * p-valprint.c (pascal_val_print): Remove "block".
5906         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5907         (aux_add_nonlocal_symbols): Make "block" const.
5908         (resolve_subexp): Remove cast.
5909         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5910         const.
5911         (iterate_over_file_blocks): Likewise.
5912         * f-exp.y (%union) <bval>: Remove.
5913         * coffread.c (patch_opaque_types): Make "b" const.
5914         * spu-tdep.c (spu_catch_start): Make "block" const.
5915         * c-valprint.c (print_unpacked_pointer): Remove "block".
5916         * symmisc.c (dump_symtab_1): Make "b" const.
5917         (block_depth): Make "block" const.
5918         * d-exp.y (%union) <bval>: Remove.
5919         * cp-support.h (cp_lookup_rtti_type): Update.
5920         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5921         * psymtab.c (psym_lookup_symbol): Make "block" const.
5922         (maintenance_check_psymtabs): Make "b" const.
5923         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5924         (enumerate_locals, enumerate_args): Update.
5925         * python/py-symtab.c (stpy_global_block): Make "block" const.
5926         (stpy_static_block): Likewise.
5927         * inline-frame.c (block_starting_point_at): Make "new_block"
5928         const.
5929         * block.c (find_block_in_blockvector): Make return type const.
5930         (blockvector_for_pc_sect): Make "b" const.
5931         (find_block_in_blockvector): Make "b" const.
5932
5933 2019-03-23  Tom Tromey  <tom@tromey.com>
5934
5935         * varobj.c (varobj_create): Update.
5936         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5937         * printcmd.c (display_command, do_one_display): Don't reset
5938         innermost_block.
5939         * parser-defs.h (enum innermost_block_tracker_type): Move to
5940         expression.h.
5941         (innermost_block): Update comment.
5942         * parse.c (parse_exp_1): Add tracker_types parameter.
5943         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5944         tracker_types parameter.  Reset innermost_block.
5945         (parse_exp_in_context): Remove.
5946         (parse_expression_for_completion): Update.
5947         * objfiles.c (~objfile): Don't reset expression_context_block or
5948         innermost_block.
5949         * expression.h (enum innermost_block_tracker_type): Move from
5950         parser-defs.h.
5951         (parse_exp_1): Add tracker_types parameter.
5952         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5953         reset innermost_block.
5954
5955 2019-03-23  Tom Tromey  <tom@tromey.com>
5956
5957         * objfiles.h: Include bcache.h.
5958
5959 2019-03-23  Tom Tromey  <tom@tromey.com>
5960
5961         * linespec.c (get_current_search_block): Use
5962         scoped_restore_current_language.
5963         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5964
5965 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5966             Jiong Wang  <jiong.wang@arm.com>
5967
5968         * aarch64-linux-tdep.c
5969         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5970         section.
5971         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5972
5973 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5974             Jiong Wang  <jiong.wang@arm.com>
5975
5976         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5977         instructions.
5978         (aarch64_analyze_prologue_test): Add PACIASP test.
5979         (aarch64_prologue_prev_register): Unmask PC value.
5980
5981 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5982             Jiong Wang  <jiong.wang@arm.com>
5983
5984         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5985         (aarch64_dwarf2_prev_register): Unmask PC value.
5986         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5987         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5988         DW_CFA_AARCH64_negate_ra_state.
5989         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5990
5991 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5992             Jiong Wang  <jiong.wang@arm.com>
5993
5994         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5995         registers.
5996         (aarch64_pseudo_register_name): Likewise.
5997         (aarch64_pseudo_register_type): Likewise.
5998         (aarch64_pseudo_register_reggroup_p): Likewise.
5999         (aarch64_gdbarch_init): Add pauth registers.
6000         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6001         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6002         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6003         (struct gdbarch_tdep): Add regnum for ra_state.
6004
6005 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6006             Jiong Wang  <jiong.wang@arm.com>
6007
6008         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6009
6010 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6011             Jiong Wang  <jiong.wang@arm.com>
6012
6013         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6014         function.
6015         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6016         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6017         (aarch64_gdbarch_init): Add puth registers.
6018         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6019         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6020         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6021
6022 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6023             Jiong Wang  <jiong.wang@arm.com>
6024
6025         * aarch64-linux-nat.c
6026         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6027         * aarch64-linux-tdep.c
6028         (aarch64_linux_core_read_description): Likewise.
6029         (aarch64_linux_get_hwcap): New function.
6030         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6031         (aarch64_linux_get_hwcap): New declaration.
6032
6033 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6034             Jiong Wang  <jiong.wang@arm.com>
6035
6036         * aarch64-linux-nat.c
6037         (aarch64_linux_nat_target::read_description): Add pauth param.
6038         * aarch64-linux-tdep.c
6039         (aarch64_linux_core_read_description): Likewise.
6040         * aarch64-tdep.c (struct target_desc): Add in pauth.
6041         (aarch64_read_description): Add pauth param.
6042         (aarch64_gdbarch_init): Likewise.
6043         * aarch64-tdep.h (aarch64_read_description): Likewise.
6044         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6045         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6046         * features/Makefile: Add new files.
6047         * features/aarch64-pauth.c: New file.
6048         * features/aarch64-pauth.xml: New file.
6049
6050 2019-03-20  Tom Tromey  <tromey@adacore.com>
6051
6052         * infrun.c (handle_inferior_event): Rename from
6053         handle_inferior_event_1.  Create a scoped_value_mark.
6054         (handle_inferior_event): Remove.
6055
6056 2019-03-19  Tom Tromey  <tromey@adacore.com>
6057
6058         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6059         * infrun.h (print_stop_event): Add "displays" parameter.
6060         * infrun.c (print_stop_event): Add "displays" parameter.
6061
6062 2019-03-19  Pedro Alves  <palves@redhat.com>
6063
6064         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6065         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6066         to -1.  Fix TABs vs spaces.
6067         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6068         * tui/tui-out.h (tui_ui_out) Add intro comments.
6069         <m_line, m_start_of_line>: In-class initialize, and add describing
6070         comment.
6071
6072 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6073
6074         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6075         variable names.
6076         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6077
6078 2019-03-18  Pedro Alves  <palves@redhat.com>
6079             Eli Zaretskii <eliz@gnu.org>
6080
6081         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6082         m_line and m_start_of_line.
6083
6084 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6085
6086         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6087         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6088         it returns a newline.  This fixes a regression in TU mode, whereby
6089         the next line is output on the same screen line as the user input.
6090
6091 2019-03-18  Tom Tromey  <tromey@adacore.com>
6092
6093         * minsyms.c (minimal_symbol_reader::install): Remove call to
6094         obstack_blank.
6095
6096 2019-03-18  Pedro Alves  <palves@redhat.com>
6097
6098         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6099         New globals.
6100         (apply_style): New, factored out from ...
6101         (apply_ansi_escape): ... this.  Handle reverse video mode.
6102         (tui_set_reverse_mode): New function.
6103         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6104         * tui/tui-winsource.c (tui_show_source_line): Use
6105         tui_set_reverse_mode instead of setting A_STANDOUT.
6106         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6107         New setter methods.
6108
6109 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6110
6111         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6112         Handle tabs.
6113
6114 2019-03-18  Tom Tromey  <tromey@adacore.com>
6115
6116         * ada-lang.c (empty_array): Add "high" parameter.
6117         (ada_evaluate_subexp): Update.
6118
6119 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6120
6121         * unittests/string_view-selftests.c: Define
6122         _initialize_string_view_selftests unconditionally.
6123
6124 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6125
6126         PR gdb/24350
6127         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6128
6129 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6130
6131         PR gdb/24351
6132         * windows-nat.c (display_selector): Fix format specifiers.
6133
6134 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6135
6136         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6137         tui_refill_source_window instead of tui_refresh_win, to update the
6138         current execution line.  This fixes redisplay of the current line
6139         when stepping through the code with "next" or "step".
6140
6141 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6142
6143         * source-cache.c (source_cache::get_source_lines): Call
6144         find_source_lines to initialize s->nlines.  This fixes vertical
6145         scrolling of TUI source window when the DOWN arrow is pressed.
6146
6147 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6148
6149         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6150         linux-thread-db.c (_initialize_thread_db): Likewise.
6151
6152 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6153
6154         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6155         wclrtoeol in tui_show_source_line".  This reverts changes made in
6156         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6157
6158 2019-03-15  Tom Tromey  <tom@tromey.com>
6159
6160         * symtab.h (struct minimal_symbol): Derive from
6161         general_symbol_info.
6162         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6163         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6164         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6165         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6166         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6167         (MSYMBOL_SEARCH_NAME): Update.
6168         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6169         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6170         * minsyms.c (minimal_symbol_reader::record_full): Update.
6171
6172 2019-03-15  Tom Tromey  <tom@tromey.com>
6173
6174         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6175
6176 2019-03-15  Tom Tromey  <tom@tromey.com>
6177
6178         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6179         unique_xmalloc_ptr.
6180         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6181         Update.
6182         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6183         (build_minimal_symbol_hash_tables)
6184         (minimal_symbol_reader::install): Update.
6185
6186 2019-03-15  Tom Tromey  <tom@tromey.com>
6187
6188         * symtab.c (create_demangled_names_hash): Update.
6189         (symbol_set_names): Update.
6190         * objfiles.h (struct objfile_per_bfd_storage)
6191         <demangled_names_hash>: Now an htab_up.
6192         * objfiles.c (objfile_per_bfd_storage): Simplify.
6193
6194 2019-03-15  Tom Tromey  <tom@tromey.com>
6195
6196         * objfiles.h (struct objfile_per_bfd_storage): Declare
6197         destructor.
6198         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6199         New.
6200         (get_objfile_bfd_data): Use new.  Don't initialize
6201         language_of_main.
6202         (free_objfile_per_bfd_storage): Remove.
6203         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6204
6205 2019-03-15  Tom Tromey  <tom@tromey.com>
6206
6207         * symfile.c (reread_symbols): Update.
6208         * objfiles.c (objfile::objfile): Update.
6209         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6210         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6211         comment.
6212         (minimal_symbol_reader::install): Update.
6213         (terminate_minimal_symbol_table): Remove.
6214         * jit.c (jit_object_close_impl): Update.
6215
6216 2019-03-15  Tom Tromey  <tom@tromey.com>
6217
6218         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6219         initializations.
6220
6221 2019-03-15  Tom Tromey  <tom@tromey.com>
6222
6223         * objfiles.h (struct objfile_per_bfd_storage)
6224         <demangled_hash_languages>: Now a bitset.
6225         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6226         (lookup_minimal_symbol): Update.
6227
6228 2019-03-15  Tom Tromey  <tom@tromey.com>
6229
6230         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6231         Don't return the symbol.
6232         * coffread.c (record_minimal_symbol): Use record_full.
6233
6234 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6235
6236         The MS-Windows port of ncurses fails to switch to a color pair if
6237         one or both of the colors are the implicit default colors.  This
6238         change records the default colors when TUI is initialized, and
6239         then specifies them explicitly when a color pair uses the default
6240         colors.  This allows color styling in TUI mode on MS-Windows.
6241
6242         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6243         ncurses_norm_attr.
6244         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6245         colors in ncurses_norm_attr.
6246         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6247         "none", replace it with the default color recorded in
6248         ncurses_norm_attr.
6249
6250 2019-03-14  Tom Tromey  <tromey@adacore.com>
6251
6252         * source-cache.h (class source_cache) <get_source_lines>: Return
6253         std::string.
6254         * source-cache.c (source_cache::extract_lines): Handle case where
6255         first_pos==npos.  Return std::string.
6256         (source_cache::get_source_lines): Update.
6257
6258 2019-03-14  Tom Tromey  <tromey@adacore.com>
6259
6260         * NEWS: Add item for "style sources" commands.
6261         * source-cache.c (source_cache::get_source_lines): Check
6262         source_styling.
6263         * cli/cli-style.c (source_styling): New global.
6264         (_initialize_cli_style): Add "style sources" commands.
6265         (show_style_sources): New function.
6266         * cli/cli-style.h (source_styling): Declare.
6267
6268 2019-03-14  Pedro Alves  <palves@redhat.com>
6269             Tom Tromey  <tromey@adacore.com>
6270
6271         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6272         * tui/tui-winsource.c (tui_refill_source_window): New function,
6273         from...
6274         (tui_horizontal_source_scroll): ... here.  Move some logic.
6275         * cli/cli-style.c (set_style_enabled): Notify new observable.
6276         * tui/tui-hooks.c (tui_redisplay_source): New function.
6277         (tui_attach_detach_observers): Attach or detach
6278         tui_redisplay_source.
6279         * observable.h (source_styling_changed): New observable.
6280         * observable.c: Define source_styling_changed observable.
6281
6282 2019-03-13  Tom Tromey  <tromey@adacore.com>
6283
6284         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6285         (i386_gnu_nat_target::store_registers): Update.
6286         * target-debug.h (target_debug_print_std_string): New macro.
6287         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6288         * windows-tdep.c (display_one_tib): Update.
6289         * tui/tui-stack.c (tui_make_status_line): Update.
6290         * top.c (print_inferior_quit_action): Update.
6291         * thread.c (thr_try_catch_cmd): Update.
6292         (add_thread_with_info): Update.
6293         (thread_target_id_str): Update.
6294         (thr_try_catch_cmd): Update.
6295         (thread_command): Update.
6296         (thread_find_command): Update.
6297         * record-btrace.c (record_btrace_target::info_record)
6298         (record_btrace_resume_thread, record_btrace_target::resume)
6299         (record_btrace_cancel_resume, record_btrace_step_thread)
6300         (record_btrace_target::wait, record_btrace_target::wait)
6301         (record_btrace_target::wait, record_btrace_target::stop): Update.
6302         * progspace.c (print_program_space): Update.
6303         * process-stratum-target.c
6304         (process_stratum_target::thread_address_space): Update.
6305         * linux-fork.c (linux_fork_mourn_inferior)
6306         (detach_checkpoint_command, info_checkpoints_command)
6307         (linux_fork_context): Update.
6308         (linux_fork_detach): Update.
6309         (class scoped_switch_fork_info): Update.
6310         (delete_checkpoint_command): Update.
6311         * infrun.c (follow_fork_inferior): Update.
6312         (follow_fork_inferior): Update.
6313         (proceed_after_vfork_done): Update.
6314         (handle_vfork_child_exec_or_exit): Update.
6315         (follow_exec): Update.
6316         (displaced_step_prepare_throw): Update.
6317         (displaced_step_restore): Update.
6318         (start_step_over): Update.
6319         (resume_1): Update.
6320         (clear_proceed_status_thread): Update.
6321         (proceed): Update.
6322         (print_target_wait_results): Update.
6323         (do_target_wait): Update.
6324         (context_switch): Update.
6325         (stop_all_threads): Update.
6326         (restart_threads): Update.
6327         (finish_step_over): Update.
6328         (handle_signal_stop): Update.
6329         (switch_back_to_stepped_thread): Update.
6330         (keep_going_pass_signal): Update.
6331         (print_exited_reason): Update.
6332         (normal_stop): Update.
6333         * inferior.c (inferior_pid_to_str): Change return type.
6334         (print_selected_inferior): Update.
6335         (add_inferior): Update.
6336         (detach_inferior): Update.
6337         * dummy-frame.c (fprint_dummy_frames): Update.
6338         * dcache.c (dcache_info_1): Update.
6339         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6340         (btrace_fetch, btrace_clear): Update.
6341         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6342         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6343         type.
6344         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6345         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6346         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6347         * gdbarch.c, gdbarch.h: Rebuild.
6348         * gdbarch.sh (core_pid_to_str): Change return type.
6349         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6350         return type.
6351         (windows_nat_target::pid_to_str): Change return type.
6352         (windows_delete_thread): Update.
6353         (windows_nat_target::attach): Update.
6354         (windows_nat_target::files_info): Update.
6355         * target-delegates.c: Rebuild.
6356         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6357         return type.
6358         (sol_thread_target::pid_to_str): Change return type.
6359         * remote.c (class remote_target) <pid_to_str>: Change return
6360         type.
6361         (remote_target::pid_to_str): Change return type.
6362         (extended_remote_target::attach, remote_target::remote_stop_ns)
6363         (remote_target::remote_notif_remove_queued_reply)
6364         (remote_target::push_stop_reply, remote_target::disable_btrace):
6365         Update.
6366         (extended_remote_target::attach): Update.
6367         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6368         type.
6369         (gdbsim_target::pid_to_str): Change return type.
6370         * ravenscar-thread.c (struct ravenscar_thread_target)
6371         <pid_to_str>: Change return type.
6372         (ravenscar_thread_target::pid_to_str): Change return type.
6373         * procfs.c (class procfs_target) <pid_to_str>: Change return
6374         type.
6375         (procfs_target::pid_to_str): Change return type.
6376         (procfs_target::attach): Update.
6377         (procfs_target::detach): Update.
6378         (procfs_target::fetch_registers): Update.
6379         (procfs_target::store_registers): Update.
6380         (procfs_target::wait): Update.
6381         (procfs_target::files_info): Update.
6382         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6383         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6384         return type.
6385         (nto_procfs_target::pid_to_str): Change return type.
6386         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6387         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6388         return type.
6389         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6390         (exit_lwp): Update.
6391         (attach_proc_task_lwp_callback, get_detach_signal)
6392         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6393         (linux_nat_target::resume, wait_lwp, stop_callback)
6394         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6395         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6396         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6397         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6398         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6399         type.
6400         (inf_ptrace_target::attach): Update.
6401         (inf_ptrace_target::files_info): Update.
6402         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6403         type.
6404         (go32_nat_target::pid_to_str): Change return type.
6405         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6406         (gnu_nat_target::wait): Update.
6407         (gnu_nat_target::wait): Update.
6408         (gnu_nat_target::resume): Update.
6409         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6410         (fbsd_nat_target::wait): Update.
6411         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6412         type.
6413         (darwin_nat_target::attach): Update.
6414         * corelow.c (class core_target) <pid_to_str>: Change return type.
6415         (core_target::pid_to_str): Change return type.
6416         * target.c (normal_pid_to_str): Change return type.
6417         (default_pid_to_str): Likewise.
6418         (target_pid_to_str): Change return type.
6419         (target_translate_tls_address): Update.
6420         (target_announce_detach): Update.
6421         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6422         return type.
6423         (bsd_uthread_target::pid_to_str): Change return type.
6424         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6425         type.
6426         (bsd_kvm_target::pid_to_str): Change return type.
6427         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6428         return type.
6429         (aix_thread_target::pid_to_str): Change return type.
6430         * target.h (struct target_ops) <pid_to_str>: Change return type.
6431         (target_pid_to_str, normal_pid_to_str): Likewise.
6432         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6433         type.
6434         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6435         type.
6436         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6437         return type.
6438         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6439         type.
6440         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6441         type.
6442         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6443         return type.
6444
6445 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6446
6447         * NEWS: Mention that the new default MI version is 3.  Mention
6448         changes to the output of commands and events that deal with
6449         multi-location breakpoints.
6450         * breakpoint.c: Include "mi/mi-out.h".
6451         (print_one_breakpoint): Change output syntax if using MI version
6452         >= 3.
6453         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6454         New.
6455         (mi_multi_location_breakpoint_output_fixed): New.
6456         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6457         (mi_cmd_fix_multi_location_breakpoint_output): New.
6458         (mi_multi_location_breakpoint_output_fixed): New.
6459         * mi/mi-cmds.c (mi_cmds): Register command
6460         -fix-multi-location-breakpoint-output.
6461         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6462         interpreter "mi".
6463
6464 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6465
6466         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6467         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6468         instantiate mi_ui_out based on interpreter name.
6469         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6470         * mi/mi-main.c (mi_load_progress): Likewise.
6471
6472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6473
6474         * NEWS: Combine separate "New targets" sections for 8.3.
6475
6476 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6477
6478         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6479         (ppcfbsd_init_abi): Install gdbarch
6480         "fetch_tls_load_module_address" and "get_thread_local_address"
6481         methods.
6482
6483 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6484
6485         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6486         (riscv_fbsd_init_abi): Install gdbarch
6487         "fetch_tls_load_module_address" and "get_thread_local_address"
6488         methods.
6489
6490 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6491
6492         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6493         (i386fbsd_init_abi): Install gdbarch
6494         "fetch_tls_load_module_address" and "get_thread_local_address"
6495         methods.
6496
6497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6498
6499         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6500         (amd64fbsd_init_abi): Install gdbarch
6501         "fetch_tls_load_module_address" and "get_thread_local_address"
6502         methods.
6503
6504 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6505
6506         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6507         (struct fbsd_pspace_data): New type.
6508         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6509         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6510         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6511         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6512         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6513
6514 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6515
6516         * gdbtypes.c (lookup_struct_elt): New function.
6517         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6518         * gdbtypes.h (struct struct_elt): New type.
6519         (lookup_struct_elt): New prototype.
6520
6521 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6522
6523         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6524         remove disabled code block.
6525
6526 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6527
6528         * gdbarch.sh (get_thread_local_address): New method.
6529         * gdbarch.h, gdbarch.c: Regenerate.
6530         * target.c (target_translate_tls_address): Use
6531         gdbarch_get_thread_local_address if present instead of
6532         target::get_thread_local_address.
6533
6534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6535
6536         * target.h (target::get_thread_local_address): Update comment.
6537
6538 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6539
6540         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6541         objfile->separate_debug_objfile_backlink if not NULL.
6542
6543 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6544
6545         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6546         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6547         (amd64bsd_store_inferior_registers): Likewise.
6548         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6549         Enable segment base registers.
6550         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6551         PT_GETFSBASE and PT_GETGSBASE.
6552         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6553         PT_SETGSBASE.
6554         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6555         segment base registers.
6556         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6557
6558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6559
6560         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6561         Update calls to i386_target_description to add 'segments'
6562         parameter.
6563         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6564         add segment base registers.
6565         * arch/i386.c (i386_create_target_description): Add 'segments'
6566         parameter to enable segment base registers.
6567         * arch/i386.h (i386_create_target_description): Likewise.
6568         * features/i386/32bit-segments.xml: New file.
6569         * features/i386/32bit-segments.c: Generate.
6570         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6571         call to i386_target_description to add 'segments' parameter.
6572         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6573         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6574         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6575         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6576         if feature is present.
6577         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6578         Add 'segments' parameter to call to i386_target_description.
6579         (i386_target_description): Add 'segments' parameter to enable
6580         segment base registers.
6581         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6582         to call to i386_target_description.
6583         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6584         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6585         Define I386_NUM_REGS.
6586         (i386_target_description): Add 'segments' parameter to enable
6587         segment base registers.
6588
6589 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6590
6591         PR/24325
6592         * source-cache.c: #undef open and close, to avoid unresolved
6593         externals during linking.
6594
6595 2019-03-12  Tom Tromey  <tromey@adacore.com>
6596
6597         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6598         const.  Add initializers.
6599         (_initialize_remote): Don't initialize ptid globals.
6600
6601 2019-03-12  Pedro Alves  <palves@redhat.com>
6602
6603         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6604
6605 2019-03-12  Pedro Alves  <palves@redhat.com>
6606
6607         * cp-name-parser.y (main): Remove unused 'len' variable.
6608
6609 2019-03-12  Tom Tromey  <tromey@adacore.com>
6610
6611         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6612         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6613
6614 2019-03-12  Tom Tromey  <tromey@adacore.com>
6615
6616         * linux-nat.c (iterate_over_lwps): Update.
6617         (stop_callback): Remove parameter.
6618         (stop_wait_callback, detach_callback, resume_set_callback)
6619         (select_singlestep_lwp_callback, set_ignore_sigint)
6620         (status_callback, resumed_callback, resume_clear_callback)
6621         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6622         data parameter.
6623         (linux_nat_target::detach, linux_nat_target::resume)
6624         (linux_stop_and_wait_all_lwps, select_event_lwp)
6625         (linux_nat_filter_event, linux_nat_wait_1)
6626         (linux_nat_target::kill, linux_nat_target::stop)
6627         (linux_nat_target::stop): Update.
6628         (linux_nat_resume_callback): Change type.
6629         (resume_stopped_resumed_lwps, count_events_callback)
6630         (select_event_lwp_callback): Likewise.
6631         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6632         * arm-linux-nat.c (struct update_registers_data): Remove.
6633         (update_registers_callback): Change type.
6634         (arm_linux_insert_hw_breakpoint1): Update.
6635         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6636         parameter.
6637         (x86_linux_dr_set_addr): Update.
6638         (x86_linux_dr_set_control): Update.
6639         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6640         (iterate_over_lwps): Use gdb::function_view.
6641         * nat/aarch64-linux-hw-point.c (struct
6642         aarch64_dr_update_callback_param): Remove.
6643         (debug_reg_change_callback): Change type.
6644         (aarch64_notify_debug_reg_change): Update.
6645         * s390-linux-nat.c (s390_refresh_per_info): Update.
6646
6647 2019-03-11  Tom Tromey  <tromey@adacore.com>
6648
6649         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6650         redundant assignment to "this_cu".
6651
6652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6653
6654         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6655
6656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6657
6658         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6659         from...
6660         (rank_one_type): ... this.
6661
6662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6663
6664         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6665         from...
6666         (rank_one_type): ... this.
6667
6668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6669
6670         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6671         from...
6672         (rank_one_type): ... this.
6673
6674 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6675
6676         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6677         from...
6678         (rank_one_type): ... this.
6679
6680 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6681
6682         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6683         from...
6684         (rank_one_type): ... this.
6685
6686 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6687
6688         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6689         from...
6690         (rank_one_type): ... this.
6691
6692 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6693
6694         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6695         from...
6696         (rank_one_type): ... this.
6697
6698 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6699
6700         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6701         from...
6702         (rank_one_type): ... this.
6703
6704 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6705
6706         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6707         from...
6708         (rank_one_type): ... this.
6709
6710 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6711
6712         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6713         from...
6714         (rank_one_type): ... this.
6715
6716 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6717
6718         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6719         from...
6720         (rank_one_type): ... this.
6721
6722 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6723
6724         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6725         from...
6726         (rank_one_type): ... this.
6727
6728 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6729
6730         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6731         inferior-events' shows the example events.
6732
6733 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6734
6735         Support styling on native MS-Windows console
6736
6737         PR/24315
6738         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6739         on MS-Windows if $TERM is not defined.
6740
6741         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6742
6743         * posix-hdep.c (gdb_console_fputs):
6744         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6745         functions.
6746         * ui-file.h (gdb_console_fputs): Add prototype.
6747
6748         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6749         back to fputs only if the former returns zero.
6750
6751 2019-03-07  Tom Tromey  <tom@tromey.com>
6752
6753         * symmisc.c (print_symbol_bcache_statistics): Update.
6754         (print_objfile_statistics): Update.
6755         * symfile.c (allocate_symtab): Update.
6756         * stabsread.c: Don't include bcache.h.
6757         * psymtab.h (struct psymbol_bcache): Don't declare.
6758         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6759         (psymbol_bcache_init, psymbol_bcache_free)
6760         (psymbol_bcache_get_bcache): Don't declare.
6761         * psymtab.c (struct psymbol_bcache): Remove.
6762         (psymtab_storage::psymtab_storage): Update.
6763         (psymtab_storage::~psymtab_storage): Update.
6764         (psymbol_bcache_init, psymbol_bcache_free)
6765         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6766         (add_psymbol_to_bcache): Update.
6767         (allocate_psymtab): Update.
6768         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6769         macro_cache>: No longer pointers.
6770         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6771         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6772         * macrotab.c (macro_bcache): Update.
6773         * macroexp.c: Don't include bcache.h.
6774         * gdbtypes.c (check_types_worklist): Update.
6775         (types_deeply_equal): Remove TRY/CATCH.  Update.
6776         * elfread.c (elf_symtab_read): Update.
6777         * dwarf2read.c: Don't include bcache.h.
6778         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6779         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6780         (print_bcache_statistics, bcache_memory_used): Don't declare.
6781         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6782         methods.  Rename all data members.
6783         * bcache.c (struct bcache): Move to bcache.h.
6784         (bcache::expand_hash_table): Rename from expand_hash_table.
6785         (bcache): Remove.
6786         (bcache::insert): Rename from bcache_full.
6787         (bcache::compare): Rename from bcache_compare.
6788         (bcache_xmalloc): Remove.
6789         (bcache::~bcache): Rename from bcache_xfree.
6790         (bcache::print_statistics): Rename from print_bcache_statistics.
6791         (bcache::memory_used): Rename from bcache_memory_used.
6792
6793 2019-03-07  Pedro Alves  <palves@redhat.com>
6794
6795         * infrun.c (normal_stop): Also check for
6796         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6797
6798 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6799
6800         * f-lang.c (value_from_host_double): Moved to...
6801         * value.c (value_from_host_double): ...here.
6802         * value.h (value_from_host_double): Declare.
6803         * guile/scm-math.c (vlscm_convert_typed_number): Use
6804         value_from_host_double.
6805         (vlscm_convert_number): Likewise.
6806         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6807         * python/py-value.c (convert_value_from_python): Likewise.
6808
6809 2019-03-06  Tom Tromey  <tom@tromey.com>
6810
6811         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6812
6813 2019-03-06  Tom Tromey  <tom@tromey.com>
6814
6815         * utils.h (free_current_contents): Don't declare.
6816         * utils.c (free_current_contents): Remove.
6817
6818 2019-03-06  Tom Tromey  <tom@tromey.com>
6819
6820         * top.c (quit_force): Update.
6821         * main.c (captured_command_loop): Update.
6822         * common/new-op.c (operator new): Update.
6823         * common/common-exceptions.c (struct catcher)
6824         <save_cleanup_chain>: Remove member.
6825         (exceptions_state_mc_init): Update.
6826         (exception_try_scope_entry): Return nullptr.
6827         (exception_try_scope_exit, exception_rethrow)
6828         (throw_exception_sjlj, throw_exception_cxx): Update.
6829         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6830         (all_cleanups, do_cleanups, discard_cleanups)
6831         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6832         (restore_cleanups, restore_final_cleanups): Don't declare.
6833         (do_final_cleanups): Remove parameter.
6834         * common/cleanups.c (cleanup_chain, make_cleanup)
6835         (make_cleanup_dtor, all_cleanups, do_cleanups)
6836         (discard_my_cleanups, discard_cleanups)
6837         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6838         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6839         (null_cleanup): Remove.
6840         (do_final_cleanups): Remove parameter.
6841
6842 2019-03-06  Tom Tromey  <tom@tromey.com>
6843
6844         * remote.c (remote_target::remote_parse_stop_reply): Use
6845         unique_xmalloc_ptr.
6846
6847 2019-03-06  Tom Tromey  <tom@tromey.com>
6848
6849         * stabsread.c (struct stabs_field_info): Rename from field_info.
6850         <list, fnlist>: Add initializers.
6851         <obstack>: New member.
6852         (read_member_functions, read_struct_fields, read_baseclasses):
6853         Allocate on obstack.  Don't use cleanups.
6854         (read_one_struct_field, read_member_functions, read_struct_fields)
6855         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6856         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6857         (read_struct_type): Update.
6858
6859 2019-03-06  Tom Tromey  <tom@tromey.com>
6860
6861         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6862         * common/filestuff.h (make_cleanup_close): Don't declare.
6863         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6864         Remove.
6865
6866 2019-03-06  Tom Tromey  <tom@tromey.com>
6867
6868         * solib-aix.c: Use make_scope_exit.
6869
6870 2019-03-06  Tom Tromey  <tom@tromey.com>
6871
6872         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6873         Use make_scope_exit.
6874
6875 2019-03-06  Tom Tromey  <tom@tromey.com>
6876
6877         * solib-svr4.c (disable_probes_interface): Remove parameter.
6878         (svr4_handle_solib_event): Use make_scope_exit.
6879
6880 2019-03-06  Tom Tromey  <tom@tromey.com>
6881
6882         * remote.c (struct stop_reply_deleter): Remove.
6883         (stop_reply_up): Update.
6884         (struct stop_reply): Derive from notif_event.  Don't typedef.
6885         <regcache>: Now a std::vector.
6886         (stop_reply_xfree): Remove.
6887         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6888         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6889         (remote_target::discard_pending_stop_replies): Use delete.
6890         (remote_target::remote_parse_stop_reply): Update.
6891         (remote_target::process_stop_reply): Update.
6892         * remote-notif.h (struct notif_event): Add virtual destructor.
6893         Remove "dtr" member.
6894         (struct notif_client) <alloc_event>: Return a unique_ptr.
6895         (notif_event_xfree): Don't declare.
6896         (notif_event_up): New typedef.
6897         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6898         (notif_event_xfree, do_notif_event_xfree): Remove.
6899         (remote_notif_state_xfree): Update.
6900
6901 2019-03-06  Tom Tromey  <tom@tromey.com>
6902
6903         * infrun.c (displaced_step_clear_cleanup): Now a
6904         forward_scope_exit type.
6905         (displaced_step_prepare_throw): Update.
6906         (displaced_step_fixup): Update.
6907
6908 2019-03-06  Tom Tromey  <tom@tromey.com>
6909
6910         * inferior.h (class inferior): Update comment.
6911         * gdbthread.h (class thread_info): Update comment.
6912
6913 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6914             Tom Tromey  <tom@tromey.com>
6915
6916         * stabsread.h (struct stab_section_list): Remove.
6917         (coffstab_build_psymtabs): Update.
6918         * dbxread.c (symbuf_sections): Now a std::vector.
6919         (sect_idx): New global.
6920         (fill_symbuf): Update.
6921         (coffstab_build_psymtabs): Change type of stabsects parameter.
6922         Update.
6923         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6924         std::vector.
6925         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6926         (coff_locate_sections): Update.
6927         (coff_symfile_read): Remove cleanups.  Update.
6928         (init_stringtab): Add storage parameter.
6929         (free_stringtab, free_stringtab_cleanup): Remove.
6930         (init_lineno): Add storage parameter.
6931         (free_linetab, free_linetab_cleanup): Remove.
6932
6933 2019-03-06  Pedro Alves  <palves@redhat.com>
6934
6935         * linux-fork.c (fork_info::clobber_regs): Delete.
6936         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6937         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6938         comment.  Adjust.
6939         (scoped_switch_fork_info::scoped_switch_fork_info)
6940         (checkpoint_command, linux_fork_context): Adjust
6941         fork_save_infrun_state calls.
6942
6943 2019-03-06  Pedro Alves  <palves@redhat.com>
6944
6945         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6946         (inf_has_multiple_threads): Return 'bool' and rewrite using
6947         inferior_info::threads().
6948
6949 2019-03-06  Pedro Alves  <palves@redhat.com>
6950
6951         * linux-fork.c: Include <list>.
6952         (fork_list): Now a std::list instance.
6953         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6954         (forks_exist_p, find_last_fork): Adjust.
6955         (new_fork): Delete.
6956         (one_fork_p): New.
6957         (add_fork): Adjust.
6958         (free_fork): Delete, folded into fork_info::~fork_info().
6959         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6960         Adjust.
6961         (init_fork_list): Delete.
6962         (linux_fork_killall, linux_fork_mourn_inferior)
6963         (linux_fork_detach, info_checkpoints_command): Adjust.
6964         (_initialize_linux_fork): No longer call init_fork_list.
6965
6966 2019-03-06  Pedro Alves  <palves@redhat.com>
6967
6968         * linux-fork.c (new_fork): New, split out of ...
6969         (add_fork): ... this.  Return void.  Move "first fork" special
6970         case from here, to ...
6971         (checkpoint_command): ... here.
6972         * linux-linux.h (add_fork): Return void.
6973
6974 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6975
6976         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6977
6978 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6979             Chris January  <chris.january@arm.com>
6980             David Lecomber  <david.lecomber@arm.com>
6981
6982         * f-exp.y: New token, UNOP_INTRINSIC.
6983         (exp): New pattern using UNOP_INTRINSIC token.
6984         (f77_keywords): Add 'abs' keyword.
6985         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6986         (value_from_host_double): New function.
6987         (evaluate_subexp_f): Support UNOP_ABS.
6988
6989 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6990
6991         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6992         types.
6993
6994 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6995
6996         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6997         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6998         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6999
7000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7001
7002         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7003
7004 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7005             Chris January  <chris.january@arm.com>
7006
7007         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7008         * f-exp.y: Define 'KIND' token.
7009         (exp): New pattern for KIND expressions.
7010         (ptype): Handle types with a kind extension.
7011         (direct_abs_decl): Extend to spot kind extensions.
7012         (f77_keywords): Add 'kind' to the list.
7013         (push_kind_type): New function.
7014         (convert_to_kind_type): New function.
7015         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7016         * parse.c (operator_length_standard): Likewise.
7017         * parser-defs.h (enum type_pieces): Add tp_kind.
7018         * std-operator.def: Add UNOP_KIND.
7019
7020 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7021
7022         * f-exp.y (f_parse): Set yydebug.
7023
7024 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * f-lang.c (evaluate_subexp_f): New function.
7027         (exp_descriptor_f): New global.
7028         (f_language_defn): Use exp_descriptor_f instead of
7029         exp_descriptor_standard.
7030
7031 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * f-exp.y (struct token): Add comments.
7034         (dot_ops): Remove uppercase versions and the end marker.
7035         (f77_keywords): Likewise.
7036         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7037         entries in the dot_ops array are case insensitive, and use
7038         strncasecmp to compare strings.  Also some whitespace cleanup in
7039         this area.  Similar for the f77_keywords array, except entries in
7040         this list might be case sensitive.
7041
7042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7043
7044         * f-exp.y (struct f77_boolean_val): Add comments.
7045         (boolean_values): Remove uppercase versions, and end marker.
7046         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7047         and use strncasecmp to achieve case insensitivity.  Additionally,
7048         perform whitespace cleanup around this code.
7049
7050 2019-03-06  Tom Tromey  <tromey@adacore.com>
7051
7052         * remote-sim.c (gdbsim_target_open): Use result of
7053         gdb_argv::release.
7054
7055 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7056         Dirk Schubert  <dirk.schubert@arm.com>
7057         Chris January  <chris.january@arm.com>
7058
7059         * eval.c (evaluate_subexp_standard): Call Fortran argument
7060         wrapping logic.
7061         * f-lang.c (struct value): A value which can be passed into a
7062         Fortran function call.
7063         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7064         where appropriate.
7065         (struct type): Value ready for a Fortran function call.
7066         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7067         is needed.
7068         * f-lang.h (fortran_argument_convert): Declaration.
7069         (fortran_preserve_arg_pointer): Declaration.
7070         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7071
7072 2019-03-05  Tom Tromey  <tromey@adacore.com>
7073
7074         * python/py-prettyprint.c (print_string_repr): Remove #if.
7075         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7076
7077 2019-03-05  Tom Tromey  <tromey@adacore.com>
7078
7079         * target.c (the_dummy_target): Move later.  Change type to
7080         "dummy_target".
7081         (initialize_targets): Don't initialize the_dummy_target.
7082
7083 2019-03-05  Tom Tromey  <tromey@adacore.com>
7084
7085         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7086         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7087
7088 2019-03-05  Tom Tromey  <tromey@adacore.com>
7089
7090         * windows-nat.c (windows_nat_target::attach)
7091         (windows_nat_target::detach): Don't call gdb_flush.
7092         * valprint.c (generic_val_print, val_print, val_print_string):
7093         Don't call gdb_flush.
7094         * utils.c (defaulted_query): Don't call gdb_flush.
7095         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7096         * target.c (target_announce_detach): Don't call gdb_flush.
7097         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7098         * remote.c (extended_remote_target::attach): Don't call
7099         gdb_flush.
7100         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7101         * printcmd.c (do_examine): Don't call gdb_flush.
7102         (info_display_command): Don't call gdb_flush.
7103         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7104         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7105         * memattr.c (info_mem_command): Don't call gdb_flush.
7106         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7107         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7108         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7109         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7110         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7111         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7112         (gnu_nat_target::detach): Don't call gdb_flush.
7113         * f-valprint.c (f_val_print): Don't call gdb_flush.
7114         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7115         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7116         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7117         gdb_flush.
7118         * c-valprint.c (c_val_print): Don't call gdb_flush.
7119         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7120
7121 2019-03-05  Tom Tromey  <tromey@adacore.com>
7122
7123         * varobj.c (update_dynamic_varobj_children): Update.
7124         (install_default_visualizer): Use reset, not release.
7125         * value.c (set_internalvar): Update.
7126         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7127         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7128         ATTRIBUTE_UNUSED_RESULT.
7129
7130 2019-03-05  Tom Tromey  <tromey@adacore.com>
7131
7132         * remote.c (class scoped_remote_fd) <release>: Add
7133         ATTRIBUTE_UNUSED_RESULT.
7134
7135 2019-03-05  Tom Tromey  <tromey@adacore.com>
7136
7137         * macroexp.c (struct macro_buffer) <release>: Add
7138         ATTRIBUTE_UNUSED_RESULT.
7139
7140 2019-03-05  Tom Tromey  <tromey@adacore.com>
7141
7142         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7143         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7144         ATTRIBUTE_UNUSED_RESULT.
7145
7146 2019-03-05  Tom Tromey  <tromey@adacore.com>
7147
7148         * common/scoped_fd.h (class scoped_fd) <release>: Add
7149         ATTRIBUTE_UNUSED_RESULT.
7150
7151 2019-03-05  Tom Tromey  <tromey@adacore.com>
7152
7153         * parser-defs.h (struct parser_state) <release>: Add
7154         ATTRIBUTE_UNUSED_RESULT.
7155
7156 2019-03-05  Tom Tromey  <tromey@adacore.com>
7157
7158         * utils.h (class gdb_argv) <release>: Add
7159         ATTRIBUTE_UNUSED_RESULT.
7160         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7161
7162 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7163
7164         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7165         for-loop range, to avoid compiler warnings.
7166
7167         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7168         avoid compiler warnings about unused variables.
7169
7170         * NEWS: Mention end of support for native debugging on MS-Windows
7171         before XP.
7172
7173         PR gdb/24292
7174         * common/netstuff.c:
7175         * gdbserver/gdbreplay.c
7176         * gdbserver/remote-utils.c:
7177         * ser-tcp.c:
7178         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7179         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7180         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7181         'getaddrinfo' and 'freeaddrinfo' were not available before
7182         Windows XP, and mingw.org's MinGW headers by default define
7183         _WIN32_WINNT to 0x500.
7184
7185 2019-03-01  Gary Benson <gbenson@redhat.com>
7186
7187         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7188
7189 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7190             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7191
7192         PR gdb/8527
7193         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7194         set_sigint_trap, clear_sigint_trap.
7195
7196 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7197
7198         * target.c (target_detach): Clear the regcache and the
7199         frame cache.
7200
7201 2019-02-27  Pedro Alves  <palves@redhat.com>
7202
7203         * utils.c (set_screen_size): When we cap the height/width sizes,
7204         tweak the corresponding command variable to show "unlimited":
7205
7206 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7207             Pedro Alves  <palves@redhat.com>
7208
7209         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7210         before calling rl_set_screen_size.
7211
7212 2019-02-27  Tom Tromey  <tromey@adacore.com>
7213
7214         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7215         define.
7216         * python/py-value.c: Remove Python 2.4 workaround.
7217         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7218         workaround.
7219         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7220         Python 2.4 workaround.
7221         * python/python-internal.h: Remove Python 2.4 comment.
7222         (Py_ssize_t): Don't define.
7223         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7224         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7225         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7226         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7227         * python/python.c (do_start_initialization): Remove Python 2.4
7228         workaround.
7229         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7230         (print_children): Remove Python 2.4 workaround.
7231         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7232         workaround.
7233         (CHARBUFFERPROC_NAME): Remove.
7234         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7235         Python 2.4 workaround.
7236
7237 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7238
7239         * NEWS: Note minimum Python version.
7240
7241 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7242
7243         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7244         code from these functions.  Remove corresponding ifdefs.  Use
7245         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7246         Remove gotos and target of gotos.
7247         (infpy_search_memory): Likewise.
7248
7249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7250
7251         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7252         (hppa_gdbarch_init): Don't register deleted functions with
7253         gdbarch.
7254
7255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7256
7257         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7258         (h8300_unwind_sp): Delete.
7259         (h8300_dummy_id): Delete.
7260         (h8300_gdbarch_init): Don't register deleted functions with
7261         gdbarch.
7262
7263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7266         (ft32_unwind_pc): Delete.
7267         (ft32_unwind_sp): Delete.
7268         (ft32_gdbarch_init): Don't register deleted functions with
7269         gdbarch.
7270
7271 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7272
7273         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7274         (frv_unwind_pc): Delete.
7275         (frv_unwind_sp): Delete.
7276         (frv_gdbarch_init): Don't register deleted functions with
7277         gdbarch.
7278
7279 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7280
7281         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7282         (riscv_unwind_pc): Delete.
7283         (riscv_unwind_sp): Delete.
7284         (riscv_gdbarch_init): Don't register deleted functions with
7285         gdbarch.
7286
7287 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7288
7289         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7290         (csky_unwind_pc): Delete.
7291         (csky_unwind_sp): Delete.
7292         (csky_gdbarch_init): Don't register deleted functions with
7293         gdbarch.
7294
7295 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7296
7297         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7298         (cris_unwind_pc): Delete.
7299         (cris_unwind_sp): Delete.
7300         (cris_gdbarch_init): Don't register deleted functions with
7301         gdbarch.
7302
7303 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7304
7305         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7306         (bfin_unwind_pc): Delete.
7307         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7308
7309 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7310
7311         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7312         (arm_unwind_pc): Delete.
7313         (arm_unwind_sp): Delete.
7314         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7315
7316 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7317
7318         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7319         (arc_unwind_pc): Delete.
7320         (arc_unwind_sp): Delete.
7321         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7322
7323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7324
7325         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7326         (alpha_unwind_pc): Delete.
7327         (alpha_gdbarch_init): Don't register deleted functions with
7328         gdbarch.
7329
7330 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7331
7332         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7333         (aarch64_unwind_pc): Delete.
7334         (aarch64_unwind_sp): Delete.
7335         (aarch64_gdbarch_init): Don't register deleted functions with
7336         gdbarch.
7337
7338 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * gdbtypes.c (type_align): Don't consider static members when
7341         computing structure alignment.
7342
7343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7344
7345         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7346         return 0 for other types.
7347         * arch-utils.c (default_type_align): Always return 0.
7348         * gdbarch.h: Regenerate.
7349         * gdbarch.sh (type_align): Extend comment.
7350         * gdbtypes.c (type_align): Add additional comments, always call
7351         gdbarch_type_align before applying the default rules.
7352         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7353         generic code will then apply a suitable default.
7354         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7355         types, return 0 for other types.
7356
7357 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7358
7359         * NEWS: Create a new section for the next release branch.
7360         Rename the section of the current branch, now that it has
7361         been cut.
7362
7363 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7364
7365         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7366         * version.in: Bump version to 8.3.50.DATE-git.
7367
7368 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7369
7370         * aix-thread.c (ptid_cmp): Remove unused variable.
7371         (get_signaled_thread): Likewise.
7372         (store_regs_user_thread): Likewise.
7373         (store_regs_kernel_thread): Likewise.
7374         (fetch_regs_kernel_thread): Remove shadowed variable.
7375
7376 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7377
7378         * features/riscv/32bit-cpu.xml: Add register numbers.
7379         * features/riscv/32bit-fpu.c: Regenerate.
7380         * features/riscv/32bit-fpu.xml: Add register numbers.
7381         * features/riscv/64bit-cpu.xml: Add register numbers.
7382         * features/riscv/64bit-fpu.c: Regenerate.
7383         * features/riscv/64bit-fpu.xml: Add register numbers.
7384
7385 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7386
7387         * NEWS: Mention two argument form of gdb.Value constructor.
7388         * python/py-value.c (convert_buffer_and_type_to_value): New
7389         function.
7390         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7391         Add support for handling an optional second argument.  Call
7392         convert_buffer_and_type_to_value as appropriate.
7393         * python/python-internal.h (Py_buffer_deleter): New struct.
7394         (Py_buffer_up): New typedef.
7395
7396 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7397
7398         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7399         instead of releasing ownership.
7400
7401 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7402
7403         * dwarf2read.c (open_and_init_dwp_file): Call
7404         elf_numsections instead of bfd_count_sections to initialize
7405         dwp_file->num_sections.
7406
7407 2019-02-25  Tom Tromey  <tromey@adacore.com>
7408
7409         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7410
7411 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7412
7413         * gcore.in: Add '--readnever' option when invoking GDB.
7414
7415 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7416
7417         * MAINTAINERS: Update my email address.
7418
7419 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7420
7421         * build-id.c (build_id_to_debug_bfd_1): New function.
7422         (build_id_to_debug_bfd): Look for separate debug file in
7423         sysroot.
7424
7425 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7426
7427         * gdbarch.sh: Update the copyright year range that is placed into
7428         generated files.
7429
7430 2019-02-22  Keith Seitz  <keiths@redhat.com>
7431
7432         PR symtab/23853
7433         * linespec.c (create_sals_line_offset): Search for the default
7434         symtab's filename instead of its fullname.
7435
7436 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7437
7438         * NEWS: Update style defaults.
7439
7440 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7441
7442         * main.c (captured_main_1): Disable styling in batch mode.
7443
7444 2019-02-20  Tom Tromey  <tom@tromey.com>
7445
7446         * symtab.c (symtab_symbol_info): Fix typos.
7447
7448 2019-02-20  Tom Tromey  <tromey@adacore.com>
7449
7450         * findcmd.c (_initialize_mem_search): Use upper case for
7451         metasyntactic variables.
7452
7453 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7454
7455         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7456         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7457
7458 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7459
7460         * top.h (source_file_name): Change to std::string.
7461         * top.c (source_file_name): Likewise.
7462         (command_line_input): Adjust.
7463         * cli/cli-script.c (script_from_file): Adjust.
7464
7465 2019-02-19  Tom Tromey  <tromey@adacore.com>
7466
7467         * ravenscar-thread.c
7468         (ravenscar_thread_target::update_thread_list): Don't call
7469         ada_build_task_list.
7470         * ada-lang.h (ada_build_task_list): Don't declare.
7471         * ada-tasks.c (struct ada_tasks_inferior_data)
7472         <task_list_valid_p>: Now bool.
7473         (read_known_tasks, ada_task_list_changed)
7474         (ada_tasks_invalidate_inferior_data): Update.
7475         (read_known_tasks_array): Return bool.
7476         (read_known_tasks_list): Likewise.
7477         (read_known_tasks): Return void.
7478         (ada_build_task_list): Now static.
7479
7480 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7481
7482         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7483         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7484
7485 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7486
7487         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7488         variant for ada_tasks_pspace_data_handle and
7489         ada_tasks_inferior_data_handle.
7490         (ada_tasks_pspace_data_cleanup): New function.
7491         (ada_tasks_inferior_data_cleanup): New function.
7492
7493 2019-02-17  Tom Tromey  <tom@tromey.com>
7494
7495         * macrotab.h (macro_source_fullname): Return a std::string.
7496         * macrotab.c (macro_include, check_for_redefinition)
7497         (macro_undef, macro_lookup_definition, foreach_macro)
7498         (foreach_macro_in_scope): Update.
7499         (macro_source_fullname): Return a std::string.
7500         * macrocmd.c (show_pp_source_pos): Update.
7501
7502 2019-02-17  Tom Tromey  <tom@tromey.com>
7503
7504         * macrocmd.c (show_pp_source_pos): Style the file names.
7505
7506 2019-02-17  Tom Tromey  <tom@tromey.com>
7507
7508         PR tui/24197:
7509         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7510
7511 2019-02-17  Tom Tromey  <tom@tromey.com>
7512
7513         * ada-lang.c (user_select_syms): Use filtered printing.
7514         * utils.c (wrap_style): New global.
7515         (desired_style): Remove.
7516         (emit_style_escape): Add stream parameter.
7517         (set_output_style, reset_terminal_style, prompt_for_continue):
7518         Update.
7519         (flush_wrap_buffer): Only flush gdb_stdout.
7520         (wrap_here): Set wrap_style.
7521         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7522         treat escape sequences as a character.  Change when wrap buffer is
7523         flushed.
7524         (fputs_styled): Do not set the output style when the default is
7525         requested.
7526         * ui-style.h (struct ui_file_style) <is_default>: New method.
7527         * source.c (print_source_lines_base): Emit escape sequences in one
7528         piece.
7529
7530 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7531
7532         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7533         integers and enumeration types.
7534
7535 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7536
7537         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7538         instead of lookup_symbol_in_language
7539         (do_exact_match): New function.
7540         (ada_get_symbol_name_matcher): Return do_exact_match when
7541         doing a verbatim match.
7542
7543 2019-02-15  Tom Tromey  <tromey@adacore.com>
7544
7545         * ravenscar-thread.c (ravenscar_thread_target::resume)
7546         (ravenscar_thread_target::wait): Special case wildcard requests.
7547
7548 2019-02-15  Tom Tromey  <tromey@adacore.com>
7549
7550         * ravenscar-thread.c (base_ptid): Remove.
7551         (struct ravenscar_thread_target) <close>: New method.
7552         <m_base_ptid>: New member.
7553         <update_inferior_ptid, active_task, task_is_currently_active,
7554         runtime_initialized>: Declare methods.
7555         <ravenscar_thread_target>: Add constructor.
7556         (ravenscar_thread_target::task_is_currently_active)
7557         (ravenscar_thread_target::update_inferior_ptid)
7558         (ravenscar_runtime_initialized): Rename.  Now methods.
7559         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7560         (ravenscar_thread_target::update_thread_list): Update.
7561         (ravenscar_thread_target::active_task): Now method.
7562         (ravenscar_thread_target::store_registers)
7563         (ravenscar_thread_target::prepare_to_store)
7564         (ravenscar_thread_target::prepare_to_store)
7565         (ravenscar_thread_target::mourn_inferior): Update.
7566         (ravenscar_inferior_created): Use "new" to create target.
7567         (ravenscar_thread_target::get_ada_task_ptid): Update.
7568         (_initialize_ravenscar): Don't initialize base_ptid.
7569         (ravenscar_ops): Remove global.
7570
7571 2019-02-15  Tom Tromey  <tromey@adacore.com>
7572
7573         * target.h (push_target): Declare new overload.
7574         * target.c (push_target): New overload, taking an rvalue reference.
7575         * remote.c (remote_target::open_1): Use push_target overload.
7576         * corelow.c (core_target_open): Use push_target overload.
7577
7578 2019-02-15  Tom Tromey  <tromey@adacore.com>
7579
7580         * ravenscar-thread.c (is_ravenscar_task)
7581         (ravenscar_task_is_currently_active): Return bool.
7582         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7583         (_initialize_ravenscar): Remove "(void)".
7584         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7585         Return bool.
7586
7587 2019-02-15  Tom Tromey  <tromey@adacore.com>
7588
7589         * ravenscar-thread.c (ravenscar_runtime_initializer)
7590         (has_ravenscar_runtime, get_running_thread_id)
7591         (ravenscar_thread_target::resume): Fix indentation.
7592
7593 2019-02-15  Tom Tromey  <tromey@adacore.com>
7594
7595         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7596         from ravenscar_arch_ops.
7597         (sparc_ravenscar_ops::fetch_registers)
7598         (sparc_ravenscar_ops::store_registers): Now methods.
7599         (sparc_ravenscar_prepare_to_store): Remove.
7600         (sparc_ravenscar_ops): Redefine.
7601         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7602         methods and destructor.  Remove members.
7603         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7604         (ravenscar_thread_target::store_registers)
7605         (ravenscar_thread_target::prepare_to_store): Update.
7606         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7607         Remove.
7608         (struct ppc_ravenscar_powerpc_ops): Derive from
7609         ravenscar_arch_ops.
7610         (ppc_ravenscar_powerpc_ops::fetch_registers)
7611         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7612         (ppc_ravenscar_powerpc_ops): Redefine.
7613         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7614         (ppc_ravenscar_e500_ops::fetch_registers)
7615         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7616         (ppc_ravenscar_e500_ops): Redefine.
7617         * aarch64-ravenscar-thread.c
7618         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7619         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7620         (aarch64_ravenscar_fetch_registers)
7621         (aarch64_ravenscar_store_registers): Now methods.
7622         (aarch64_ravenscar_ops): Redefine.
7623
7624 2019-02-15  Tom Tromey  <tromey@adacore.com>
7625
7626         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7627         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7628         (ravenscar_thread_target::stopped_by_watchpoint)
7629         (ravenscar_thread_target::stopped_data_address)
7630         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7631
7632 2019-02-15  Tom Tromey  <tromey@adacore.com>
7633
7634         * ravenscar-thread.c: Fix some typos.
7635
7636 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7637             Tom Tromey  <tromey@adacore.com>
7638
7639         * ada-lang.c (ada_exception_sal): Change addr_string to a
7640         std::string.
7641         (create_ada_exception_catchpoint): Update.
7642
7643 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7644             Tom Tromey  <tromey@adacore.com>
7645
7646         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7647         (bp_location_ops): Remove.
7648         (base_breakpoint_allocate_location): Update.
7649         (free_bp_location): Update.
7650         * ada-lang.c (class ada_catchpoint_location)
7651         <ada_catchpoint_location>: Remove ops parameter.
7652         (ada_catchpoint_location_dtor): Remove.
7653         (ada_catchpoint_location_ops): Remove.
7654         (allocate_location_exception): Update.
7655         * breakpoint.h (struct bp_location_ops): Remove.
7656         (class bp_location) <bp_location>: Remove bp_location_ops
7657         parameter.
7658         <~bp_location>: Add destructor.
7659         <ops>: Remove.
7660
7661 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7662             Pedro Alves  <palves@redhat.com>
7663
7664         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7665         'PATH_MAX'.
7666
7667 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7668             Samuel Thibault  <samuel.thibault@gnu.org>
7669             Thomas Schwinge  <thomas@codesourcery.com>
7670
7671         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7672         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7673
7674 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7675
7676         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7677         (check_empty): Use "const char *".
7678
7679         * gnu-nat.c (gnu_nat_target::detach): Instead of
7680         'detach_inferior (pid)' call
7681         'detach_inferior (find_inferior_pid (pid))'.
7682
7683         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7684         'nat/fork-inferior.o'.
7685         * gnu-nat.c: #include "nat/fork-inferior.h".
7686
7687         * gnu-nat.c (gnu_nat_target::detach): Instead of
7688         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7689         * gnu-nat.h: #include "inf-child.h".
7690         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7691         'i386_gnu_nat_target::fetch_registers'.
7692         (gnu_store_registers): Rename/move to
7693         'i386_gnu_nat_target::store_registers'.
7694
7695         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7696         * gnu-nat.h (mach_thread_info): New function.
7697         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7698
7699         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7700
7701 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7702
7703         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7704
7705 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7706
7707         * windows-nat.c (windows_add_thread): Add new parameter
7708         "main_thread_p" with default value set to false.  Update
7709         function documentation as well as all callers.
7710         (windows_delete_thread): Likewise.
7711         (fake_create_process): Update call to windows_add_thread.
7712         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7713         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7714         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7715         call to windows_delete_thread.
7716
7717 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7718
7719         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7720
7721 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7722
7723         * symfile.c (find_separate_debug_file): Use canonical path of
7724         sysroot with child_path instead of gdb_sysroot if it is valid.
7725
7726 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7727
7728         * symfile.c (find_separate_debug_file): Use child_path to
7729         determine if an object file is under a sysroot.
7730
7731 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7732
7733         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7734         unittests/child-path-selftests.c.
7735         * common/pathstuff.c (child_path): New function.
7736         * common/pathstuff.h (child_path): New prototype.
7737         * unittests/child-path-selftests.c: New file.
7738
7739 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7740
7741         * symfile.c (find_separate_debug_file): Look for separate debug
7742         files in debug directories under the sysroot.
7743
7744 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7745
7746         * symtab.h (struct minimal_symbol data_p): New const method.
7747         (struct minimal_symbol text_p): Likewise.
7748         * symtab.c (output_source_filename): Use file name style
7749         to print file name.
7750         (print_symbol_info): Likewise.
7751         (print_msymbol_info): Use address style to print addresses.
7752         Use function name style to print executable text symbols.
7753         (expand_symtab_containing_pc): Use data_p.
7754         (find_pc_sect_compunit_symtab): Likewise.
7755
7756 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7757
7758         * breakpoint.c (describe_other_breakpoints): Use address style
7759         to print addresses.
7760         (say_where): Likewise.
7761
7762 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7763
7764         * ada-typeprint.c (print_func_type): Print function name
7765         style to print function name.
7766         * c-typeprint.c (c_print_type_1): Likewise.
7767
7768 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7769
7770         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7771         for execve.
7772
7773 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7774
7775         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7776         type_stack.
7777
7778 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7779
7780         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7781         TYPE_CODE_REF types.
7782
7783 2019-02-08  Jim Wilson  <jimw@sifive.com>
7784
7785         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7786         (riscv_linux_fregset): New.
7787         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7788
7789 2019-02-07  Tom Tromey  <tom@tromey.com>
7790
7791         * thread.c (thread_cancel_execution_command): Update.
7792         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7793         methods.
7794         (struct thread_fsm_ops): Remove.
7795         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7796         (thread_fsm_should_stop, thread_fsm_return_value)
7797         (thread_fsm_set_finished, thread_fsm_finished_p)
7798         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7799         Don't declare.
7800         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7801         * infrun.c (clear_proceed_status_thread)
7802         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7803         (print_stop_event): Update.
7804         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7805         Add constructor.
7806         (step_command_fsm_ops): Remove.
7807         (new_step_command_fsm): Remove.
7808         (step_1): Update.
7809         (step_command_fsm::should_stop): Rename from
7810         step_command_fsm_should_stop.
7811         (step_command_fsm::clean_up): Rename from
7812         step_command_fsm_clean_up.
7813         (step_command_fsm::do_async_reply_reason): Rename from
7814         step_command_fsm_async_reply_reason.
7815         (struct until_next_fsm): Inherit from thread_fsm.  Add
7816         constructor.
7817         (until_next_fsm_ops): Remove.
7818         (new_until_next_fsm): Remove.
7819         (until_next_fsm::should_stop): Rename from
7820         until_next_fsm_should_stop.
7821         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7822         (until_next_fsm::do_async_reply_reason): Rename from
7823         until_next_fsm_async_reply_reason.
7824         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7825         constructor.  Change type of breakpoint.
7826         (finish_command_fsm_ops): Remove.
7827         (new_finish_command_fsm): Remove.
7828         (finish_command_fsm::should_stop): Rename from
7829         finish_command_fsm_should_stop.
7830         (finish_command_fsm::clean_up): Rename from
7831         finish_command_fsm_clean_up.
7832         (finish_command_fsm::return_value): Rename from
7833         finish_command_fsm_return_value.
7834         (finish_command_fsm::do_async_reply_reason): Rename from
7835         finish_command_fsm_async_reply_reason.
7836         (finish_command): Update.
7837         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7838         Add constructor.
7839         (call_thread_fsm_ops): Remove.
7840         (call_thread_fsm::call_thread_fsm): Rename from
7841         new_call_thread_fsm.
7842         (call_thread_fsm::should_stop): Rename from
7843         call_thread_fsm_should_stop.
7844         (call_thread_fsm::should_notify_stop): Rename from
7845         call_thread_fsm_should_notify_stop.
7846         (run_inferior_call, call_function_by_hand_dummy): Update.
7847         * cli/cli-interp.c (should_print_stop_to_console): Update.
7848         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7849         Add constructor.  Change type of location_breakpoint,
7850         caller_breakpoint.
7851         (until_break_fsm_ops): Remove.
7852         (new_until_break_fsm): Remove.
7853         (until_break_fsm::should_stop): Rename from
7854         until_break_fsm_should_stop.
7855         (until_break_fsm::clean_up): Rename from
7856         until_break_fsm_clean_up.
7857         (until_break_fsm::do_async_reply_reason): Rename from
7858         until_break_fsm_async_reply_reason.
7859         (until_break_command): Update.
7860         * thread-fsm.c: Remove.
7861         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7862
7863 2019-02-07  Tom Tromey  <tom@tromey.com>
7864
7865         * yy-remap.h: Add include guard.
7866         * xtensa-tdep.h: Add include guard.
7867         * xcoffread.h: Rename include guard.
7868         * varobj-iter.h: Add include guard.
7869         * tui/tui.h: Rename include guard.
7870         * tui/tui-winsource.h: Rename include guard.
7871         * tui/tui-wingeneral.h: Rename include guard.
7872         * tui/tui-windata.h: Rename include guard.
7873         * tui/tui-win.h: Rename include guard.
7874         * tui/tui-stack.h: Rename include guard.
7875         * tui/tui-source.h: Rename include guard.
7876         * tui/tui-regs.h: Rename include guard.
7877         * tui/tui-out.h: Rename include guard.
7878         * tui/tui-layout.h: Rename include guard.
7879         * tui/tui-io.h: Rename include guard.
7880         * tui/tui-hooks.h: Rename include guard.
7881         * tui/tui-file.h: Rename include guard.
7882         * tui/tui-disasm.h: Rename include guard.
7883         * tui/tui-data.h: Rename include guard.
7884         * tui/tui-command.h: Rename include guard.
7885         * tic6x-tdep.h: Add include guard.
7886         * target/waitstatus.h: Rename include guard.
7887         * target/wait.h: Rename include guard.
7888         * target/target.h: Rename include guard.
7889         * target/resume.h: Rename include guard.
7890         * target-float.h: Rename include guard.
7891         * stabsread.h: Add include guard.
7892         * rs6000-tdep.h: Add include guard.
7893         * riscv-fbsd-tdep.h: Add include guard.
7894         * regformats/regdef.h: Rename include guard.
7895         * record.h: Rename include guard.
7896         * python/python.h: Rename include guard.
7897         * python/python-internal.h: Rename include guard.
7898         * python/py-stopevent.h: Rename include guard.
7899         * python/py-ref.h: Rename include guard.
7900         * python/py-record.h: Rename include guard.
7901         * python/py-record-full.h: Rename include guard.
7902         * python/py-record-btrace.h: Rename include guard.
7903         * python/py-instruction.h: Rename include guard.
7904         * python/py-events.h: Rename include guard.
7905         * python/py-event.h: Rename include guard.
7906         * procfs.h: Add include guard.
7907         * proc-utils.h: Add include guard.
7908         * p-lang.h: Add include guard.
7909         * or1k-tdep.h: Rename include guard.
7910         * observable.h: Rename include guard.
7911         * nto-tdep.h: Rename include guard.
7912         * nat/x86-linux.h: Rename include guard.
7913         * nat/x86-linux-dregs.h: Rename include guard.
7914         * nat/x86-gcc-cpuid.h: Add include guard.
7915         * nat/x86-dregs.h: Rename include guard.
7916         * nat/x86-cpuid.h: Rename include guard.
7917         * nat/ppc-linux.h: Rename include guard.
7918         * nat/mips-linux-watch.h: Rename include guard.
7919         * nat/linux-waitpid.h: Rename include guard.
7920         * nat/linux-ptrace.h: Rename include guard.
7921         * nat/linux-procfs.h: Rename include guard.
7922         * nat/linux-osdata.h: Rename include guard.
7923         * nat/linux-nat.h: Rename include guard.
7924         * nat/linux-namespaces.h: Rename include guard.
7925         * nat/linux-btrace.h: Rename include guard.
7926         * nat/glibc_thread_db.h: Rename include guard.
7927         * nat/gdb_thread_db.h: Rename include guard.
7928         * nat/gdb_ptrace.h: Rename include guard.
7929         * nat/fork-inferior.h: Rename include guard.
7930         * nat/amd64-linux-siginfo.h: Rename include guard.
7931         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7932         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7933         * nat/aarch64-linux.h: Rename include guard.
7934         * nat/aarch64-linux-hw-point.h: Rename include guard.
7935         * mn10300-tdep.h: Add include guard.
7936         * mips-linux-tdep.h: Add include guard.
7937         * mi/mi-parse.h: Rename include guard.
7938         * mi/mi-out.h: Rename include guard.
7939         * mi/mi-main.h: Rename include guard.
7940         * mi/mi-interp.h: Rename include guard.
7941         * mi/mi-getopt.h: Rename include guard.
7942         * mi/mi-console.h: Rename include guard.
7943         * mi/mi-common.h: Rename include guard.
7944         * mi/mi-cmds.h: Rename include guard.
7945         * mi/mi-cmd-break.h: Rename include guard.
7946         * m2-lang.h: Add include guard.
7947         * location.h: Rename include guard.
7948         * linux-record.h: Rename include guard.
7949         * linux-nat.h: Add include guard.
7950         * linux-fork.h: Add include guard.
7951         * i386-darwin-tdep.h: Rename include guard.
7952         * hppa-linux-offsets.h: Add include guard.
7953         * guile/guile.h: Rename include guard.
7954         * guile/guile-internal.h: Rename include guard.
7955         * gnu-nat.h: Rename include guard.
7956         * gdb-stabs.h: Rename include guard.
7957         * frv-tdep.h: Add include guard.
7958         * f-lang.h: Add include guard.
7959         * event-loop.h: Add include guard.
7960         * darwin-nat.h: Rename include guard.
7961         * cp-abi.h: Rename include guard.
7962         * config/sparc/nm-sol2.h: Rename include guard.
7963         * config/nm-nto.h: Rename include guard.
7964         * config/nm-linux.h: Add include guard.
7965         * config/i386/nm-i386gnu.h: Rename include guard.
7966         * config/djgpp/nl_types.h: Rename include guard.
7967         * config/djgpp/langinfo.h: Rename include guard.
7968         * compile/gcc-cp-plugin.h: Add include guard.
7969         * compile/gcc-c-plugin.h: Add include guard.
7970         * compile/compile.h: Rename include guard.
7971         * compile/compile-object-run.h: Rename include guard.
7972         * compile/compile-object-load.h: Rename include guard.
7973         * compile/compile-internal.h: Rename include guard.
7974         * compile/compile-cplus.h: Rename include guard.
7975         * compile/compile-c.h: Rename include guard.
7976         * common/xml-utils.h: Rename include guard.
7977         * common/x86-xstate.h: Rename include guard.
7978         * common/version.h: Rename include guard.
7979         * common/vec.h: Rename include guard.
7980         * common/tdesc.h: Rename include guard.
7981         * common/selftest.h: Rename include guard.
7982         * common/scoped_restore.h: Rename include guard.
7983         * common/scoped_mmap.h: Rename include guard.
7984         * common/scoped_fd.h: Rename include guard.
7985         * common/safe-iterator.h: Rename include guard.
7986         * common/run-time-clock.h: Rename include guard.
7987         * common/refcounted-object.h: Rename include guard.
7988         * common/queue.h: Rename include guard.
7989         * common/ptid.h: Rename include guard.
7990         * common/print-utils.h: Rename include guard.
7991         * common/preprocessor.h: Rename include guard.
7992         * common/pathstuff.h: Rename include guard.
7993         * common/observable.h: Rename include guard.
7994         * common/netstuff.h: Rename include guard.
7995         * common/job-control.h: Rename include guard.
7996         * common/host-defs.h: Rename include guard.
7997         * common/gdb_wait.h: Rename include guard.
7998         * common/gdb_vecs.h: Rename include guard.
7999         * common/gdb_unlinker.h: Rename include guard.
8000         * common/gdb_unique_ptr.h: Rename include guard.
8001         * common/gdb_tilde_expand.h: Rename include guard.
8002         * common/gdb_sys_time.h: Rename include guard.
8003         * common/gdb_string_view.h: Rename include guard.
8004         * common/gdb_splay_tree.h: Rename include guard.
8005         * common/gdb_setjmp.h: Rename include guard.
8006         * common/gdb_ref_ptr.h: Rename include guard.
8007         * common/gdb_optional.h: Rename include guard.
8008         * common/gdb_locale.h: Rename include guard.
8009         * common/gdb_assert.h: Rename include guard.
8010         * common/filtered-iterator.h: Rename include guard.
8011         * common/filestuff.h: Rename include guard.
8012         * common/fileio.h: Rename include guard.
8013         * common/environ.h: Rename include guard.
8014         * common/common-utils.h: Rename include guard.
8015         * common/common-types.h: Rename include guard.
8016         * common/common-regcache.h: Rename include guard.
8017         * common/common-inferior.h: Rename include guard.
8018         * common/common-gdbthread.h: Rename include guard.
8019         * common/common-exceptions.h: Rename include guard.
8020         * common/common-defs.h: Rename include guard.
8021         * common/common-debug.h: Rename include guard.
8022         * common/cleanups.h: Rename include guard.
8023         * common/buffer.h: Rename include guard.
8024         * common/btrace-common.h: Rename include guard.
8025         * common/break-common.h: Rename include guard.
8026         * cli/cli-utils.h: Rename include guard.
8027         * cli/cli-style.h: Rename include guard.
8028         * cli/cli-setshow.h: Rename include guard.
8029         * cli/cli-script.h: Rename include guard.
8030         * cli/cli-interp.h: Rename include guard.
8031         * cli/cli-decode.h: Rename include guard.
8032         * cli/cli-cmds.h: Rename include guard.
8033         * charset-list.h: Add include guard.
8034         * buildsym-legacy.h: Rename include guard.
8035         * bfin-tdep.h: Add include guard.
8036         * ax.h: Rename include guard.
8037         * arm-linux-tdep.h: Add include guard.
8038         * arm-fbsd-tdep.h: Add include guard.
8039         * arch/xtensa.h: Rename include guard.
8040         * arch/tic6x.h: Add include guard.
8041         * arch/i386.h: Add include guard.
8042         * arch/arm.h: Rename include guard.
8043         * arch/arm-linux.h: Rename include guard.
8044         * arch/arm-get-next-pcs.h: Rename include guard.
8045         * arch/amd64.h: Add include guard.
8046         * arch/aarch64-insn.h: Rename include guard.
8047         * arch-utils.h: Rename include guard.
8048         * annotate.h: Add include guard.
8049         * amd64-darwin-tdep.h: Rename include guard.
8050         * aarch64-linux-tdep.h: Add include guard.
8051         * aarch64-fbsd-tdep.h: Add include guard.
8052         * aarch32-linux-nat.h: Add include guard.
8053
8054 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8055
8056         * macrotab.c (macro_define_internal): New function that
8057         factorizes macro_define_object_internal and macro_define_function
8058         code.
8059         (macro_define_object_internal): Use macro_define_internal.
8060         (macro_define_function): Likewise.
8061
8062 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8063
8064         * macrocmd.c (extract_identifier): Return
8065         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8066         callers.
8067
8068 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8069
8070         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8071
8072 2019-02-05  Tom Tromey  <tom@tromey.com>
8073
8074         * target.c (target_stack::unpush): Move assertion earlier.
8075
8076 2019-01-30  Tom Tromey  <tom@tromey.com>
8077
8078         PR python/23615:
8079         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8080         (gdbpy_parse_and_eval): Likewise.
8081         * python/python-internal.h (gdbpy_allow_threads): New class.
8082
8083 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8084
8085         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8086         (aarch64_fbsd_fpregmap): Move earlier.
8087         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8088         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8089         instead of individual calls to trad_frame_set_reg_addr.
8090         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8091         earlier.
8092         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8093         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8094         instead of individual calls to trad_frame_set_reg_addr.
8095
8096 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8097
8098         * CONTRIBUTE: Replace contribution list with wiki link.
8099
8100 2019-01-25  Tom Tromey  <tom@tromey.com>
8101
8102         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8103
8104 2019-01-25  Tom Tromey  <tom@tromey.com>
8105
8106         * xtensa-linux-nat.c: Fix common/ includes.
8107         * xml-support.h: Fix common/ includes.
8108         * xml-support.c: Fix common/ includes.
8109         * x86-linux-nat.c: Fix common/ includes.
8110         * windows-nat.c: Fix common/ includes.
8111         * varobj.h: Fix common/ includes.
8112         * varobj.c: Fix common/ includes.
8113         * value.c: Fix common/ includes.
8114         * valops.c: Fix common/ includes.
8115         * utils.c: Fix common/ includes.
8116         * unittests/xml-utils-selftests.c: Fix common/ includes.
8117         * unittests/utils-selftests.c: Fix common/ includes.
8118         * unittests/unpack-selftests.c: Fix common/ includes.
8119         * unittests/tracepoint-selftests.c: Fix common/ includes.
8120         * unittests/style-selftests.c: Fix common/ includes.
8121         * unittests/string_view-selftests.c: Fix common/ includes.
8122         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8123         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8124         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8125         * unittests/rsp-low-selftests.c: Fix common/ includes.
8126         * unittests/parse-connection-spec-selftests.c: Fix common/
8127         includes.
8128         * unittests/optional-selftests.c: Fix common/ includes.
8129         * unittests/offset-type-selftests.c: Fix common/ includes.
8130         * unittests/observable-selftests.c: Fix common/ includes.
8131         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8132         * unittests/memrange-selftests.c: Fix common/ includes.
8133         * unittests/memory-map-selftests.c: Fix common/ includes.
8134         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8135         * unittests/function-view-selftests.c: Fix common/ includes.
8136         * unittests/environ-selftests.c: Fix common/ includes.
8137         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8138         * unittests/common-utils-selftests.c: Fix common/ includes.
8139         * unittests/cli-utils-selftests.c: Fix common/ includes.
8140         * unittests/array-view-selftests.c: Fix common/ includes.
8141         * ui-file.c: Fix common/ includes.
8142         * tui/tui-io.c: Fix common/ includes.
8143         * tracepoint.h: Fix common/ includes.
8144         * tracepoint.c: Fix common/ includes.
8145         * tracefile-tfile.c: Fix common/ includes.
8146         * top.h: Fix common/ includes.
8147         * top.c: Fix common/ includes.
8148         * thread.c: Fix common/ includes.
8149         * target/waitstatus.h: Fix common/ includes.
8150         * target/waitstatus.c: Fix common/ includes.
8151         * target.h: Fix common/ includes.
8152         * target.c: Fix common/ includes.
8153         * target-memory.c: Fix common/ includes.
8154         * target-descriptions.c: Fix common/ includes.
8155         * symtab.h: Fix common/ includes.
8156         * symfile.c: Fix common/ includes.
8157         * stap-probe.c: Fix common/ includes.
8158         * spu-linux-nat.c: Fix common/ includes.
8159         * sparc-nat.c: Fix common/ includes.
8160         * source.c: Fix common/ includes.
8161         * solib.c: Fix common/ includes.
8162         * solib-target.c: Fix common/ includes.
8163         * ser-unix.c: Fix common/ includes.
8164         * ser-tcp.c: Fix common/ includes.
8165         * ser-pipe.c: Fix common/ includes.
8166         * ser-base.c: Fix common/ includes.
8167         * selftest-arch.c: Fix common/ includes.
8168         * s12z-tdep.c: Fix common/ includes.
8169         * rust-exp.y: Fix common/ includes.
8170         * rs6000-aix-tdep.c: Fix common/ includes.
8171         * riscv-tdep.c: Fix common/ includes.
8172         * remote.c: Fix common/ includes.
8173         * remote-notif.h: Fix common/ includes.
8174         * remote-fileio.h: Fix common/ includes.
8175         * remote-fileio.c: Fix common/ includes.
8176         * regcache.h: Fix common/ includes.
8177         * regcache.c: Fix common/ includes.
8178         * record-btrace.c: Fix common/ includes.
8179         * python/python.c: Fix common/ includes.
8180         * python/py-type.c: Fix common/ includes.
8181         * python/py-inferior.c: Fix common/ includes.
8182         * progspace.h: Fix common/ includes.
8183         * producer.c: Fix common/ includes.
8184         * procfs.c: Fix common/ includes.
8185         * proc-api.c: Fix common/ includes.
8186         * printcmd.c: Fix common/ includes.
8187         * ppc-linux-nat.c: Fix common/ includes.
8188         * parser-defs.h: Fix common/ includes.
8189         * osdata.c: Fix common/ includes.
8190         * obsd-nat.c: Fix common/ includes.
8191         * nat/x86-linux.c: Fix common/ includes.
8192         * nat/x86-linux-dregs.c: Fix common/ includes.
8193         * nat/x86-dregs.h: Fix common/ includes.
8194         * nat/x86-dregs.c: Fix common/ includes.
8195         * nat/ppc-linux.c: Fix common/ includes.
8196         * nat/mips-linux-watch.h: Fix common/ includes.
8197         * nat/mips-linux-watch.c: Fix common/ includes.
8198         * nat/linux-waitpid.c: Fix common/ includes.
8199         * nat/linux-ptrace.h: Fix common/ includes.
8200         * nat/linux-ptrace.c: Fix common/ includes.
8201         * nat/linux-procfs.c: Fix common/ includes.
8202         * nat/linux-personality.c: Fix common/ includes.
8203         * nat/linux-osdata.c: Fix common/ includes.
8204         * nat/linux-namespaces.c: Fix common/ includes.
8205         * nat/linux-btrace.h: Fix common/ includes.
8206         * nat/linux-btrace.c: Fix common/ includes.
8207         * nat/fork-inferior.c: Fix common/ includes.
8208         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8209         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8210         * nat/aarch64-linux.c: Fix common/ includes.
8211         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8212         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8213         * namespace.h: Fix common/ includes.
8214         * mips-linux-tdep.c: Fix common/ includes.
8215         * minsyms.c: Fix common/ includes.
8216         * mi/mi-parse.h: Fix common/ includes.
8217         * mi/mi-main.c: Fix common/ includes.
8218         * mi/mi-cmd-env.c: Fix common/ includes.
8219         * memrange.h: Fix common/ includes.
8220         * memattr.c: Fix common/ includes.
8221         * maint.h: Fix common/ includes.
8222         * maint.c: Fix common/ includes.
8223         * main.c: Fix common/ includes.
8224         * machoread.c: Fix common/ includes.
8225         * location.c: Fix common/ includes.
8226         * linux-thread-db.c: Fix common/ includes.
8227         * linux-nat.c: Fix common/ includes.
8228         * linux-fork.c: Fix common/ includes.
8229         * inline-frame.c: Fix common/ includes.
8230         * infrun.c: Fix common/ includes.
8231         * inflow.c: Fix common/ includes.
8232         * inferior.h: Fix common/ includes.
8233         * inferior.c: Fix common/ includes.
8234         * infcmd.c: Fix common/ includes.
8235         * inf-ptrace.c: Fix common/ includes.
8236         * inf-child.c: Fix common/ includes.
8237         * ia64-linux-nat.c: Fix common/ includes.
8238         * i387-tdep.c: Fix common/ includes.
8239         * i386-tdep.c: Fix common/ includes.
8240         * i386-linux-tdep.c: Fix common/ includes.
8241         * i386-linux-nat.c: Fix common/ includes.
8242         * i386-go32-tdep.c: Fix common/ includes.
8243         * i386-fbsd-tdep.c: Fix common/ includes.
8244         * i386-fbsd-nat.c: Fix common/ includes.
8245         * guile/scm-type.c: Fix common/ includes.
8246         * guile/guile.c: Fix common/ includes.
8247         * go32-nat.c: Fix common/ includes.
8248         * gnu-nat.c: Fix common/ includes.
8249         * gdbthread.h: Fix common/ includes.
8250         * gdbarch-selftests.c: Fix common/ includes.
8251         * gdb_usleep.c: Fix common/ includes.
8252         * gdb_select.h: Fix common/ includes.
8253         * gdb_bfd.c: Fix common/ includes.
8254         * gcore.c: Fix common/ includes.
8255         * fork-child.c: Fix common/ includes.
8256         * findvar.c: Fix common/ includes.
8257         * fbsd-nat.c: Fix common/ includes.
8258         * event-top.c: Fix common/ includes.
8259         * event-loop.c: Fix common/ includes.
8260         * dwarf2read.c: Fix common/ includes.
8261         * dwarf2loc.c: Fix common/ includes.
8262         * dwarf2-frame.c: Fix common/ includes.
8263         * dwarf-index-cache.c: Fix common/ includes.
8264         * dtrace-probe.c: Fix common/ includes.
8265         * disasm-selftests.c: Fix common/ includes.
8266         * defs.h: Fix common/ includes.
8267         * csky-tdep.c: Fix common/ includes.
8268         * cp-valprint.c: Fix common/ includes.
8269         * cp-support.h: Fix common/ includes.
8270         * cp-support.c: Fix common/ includes.
8271         * corelow.c: Fix common/ includes.
8272         * completer.h: Fix common/ includes.
8273         * completer.c: Fix common/ includes.
8274         * compile/compile.c: Fix common/ includes.
8275         * compile/compile-loc2c.c: Fix common/ includes.
8276         * compile/compile-cplus-types.c: Fix common/ includes.
8277         * compile/compile-cplus-symbols.c: Fix common/ includes.
8278         * command.h: Fix common/ includes.
8279         * cli/cli-dump.c: Fix common/ includes.
8280         * cli/cli-cmds.c: Fix common/ includes.
8281         * charset.c: Fix common/ includes.
8282         * build-id.c: Fix common/ includes.
8283         * btrace.h: Fix common/ includes.
8284         * btrace.c: Fix common/ includes.
8285         * breakpoint.h: Fix common/ includes.
8286         * breakpoint.c: Fix common/ includes.
8287         * ax.h:
8288         (enum agent_op): Fix common/ includes.
8289         * ax-general.c (struct aop_map): Fix common/ includes.
8290         * ax-gdb.c: Fix common/ includes.
8291         * auxv.c: Fix common/ includes.
8292         * auto-load.c: Fix common/ includes.
8293         * arm-tdep.c: Fix common/ includes.
8294         * arch/riscv.c: Fix common/ includes.
8295         * arch/ppc-linux-common.c: Fix common/ includes.
8296         * arch/i386.c: Fix common/ includes.
8297         * arch/arm.c: Fix common/ includes.
8298         * arch/arm-linux.c: Fix common/ includes.
8299         * arch/arm-get-next-pcs.c: Fix common/ includes.
8300         * arch/amd64.c: Fix common/ includes.
8301         * arch/aarch64.c: Fix common/ includes.
8302         * arch/aarch64-insn.c: Fix common/ includes.
8303         * arch-utils.c: Fix common/ includes.
8304         * amd64-windows-tdep.c: Fix common/ includes.
8305         * amd64-tdep.c: Fix common/ includes.
8306         * amd64-sol2-tdep.c: Fix common/ includes.
8307         * amd64-obsd-tdep.c: Fix common/ includes.
8308         * amd64-nbsd-tdep.c: Fix common/ includes.
8309         * amd64-linux-tdep.c: Fix common/ includes.
8310         * amd64-linux-nat.c: Fix common/ includes.
8311         * amd64-fbsd-tdep.c: Fix common/ includes.
8312         * amd64-fbsd-nat.c: Fix common/ includes.
8313         * amd64-dicos-tdep.c: Fix common/ includes.
8314         * amd64-darwin-tdep.c: Fix common/ includes.
8315         * agent.c: Fix common/ includes.
8316         * ada-lang.h: Fix common/ includes.
8317         * ada-lang.c: Fix common/ includes.
8318         * aarch64-tdep.c: Fix common/ includes.
8319
8320 2019-01-25  Tom Tromey  <tom@tromey.com>
8321
8322         * common/create-version.sh: Use common/version.h.
8323
8324 2019-01-24  Pedro Alves  <palves@redhat.com>
8325
8326         * infrun.c (signal_stop, signal_print, signal_program)
8327         (signal_catch, signal_pass): Now arrays instead of pointers.
8328         (update_signals_program_target, do_target_resume)
8329         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8330         * linux-nat.c (linux_nat_target::pass_signals)
8331         (linux_nat_target::create_inferior, linux_nat_target::attach):
8332         Adjust.
8333         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8334         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8335         * procfs.c (procfs_target::pass_signals): Adjust.
8336         * record-full.c (record_full_target::resume): Adjust.
8337         * remote.c (remote_target::pass_signals)
8338         (remote_target::program_signals): Adjust.
8339         * target-debug.h (target_debug_print_signals): Now takes a
8340         gdb::array_view as parameter.  Adjust.
8341         * target.h (target_ops) <pass_signals, program_signals>: Replace
8342         pointer and length parameters with gdb::array_view.
8343         (target_pass_signals, target_program_signals): Likewise.
8344         * target-delegates.c: Regenerate.
8345
8346 2019-01-24  Pedro Alves  <palves@redhat.com>
8347
8348         * common/forward-scope-exit.h
8349         (forward_scope_exit::forward_scope_exit): Pass arguments to
8350         m_bind_function directly, instead of creating a std::bind and
8351         copying that.
8352
8353 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8354
8355         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8356         for static members.
8357         (pass_in_v_vfp_candidate): Likewise.
8358
8359 2019-01-23  Tom Tromey  <tom@tromey.com>
8360             Pedro Alves  <palves@redhat.com>
8361
8362         * regcache.c (class regcache_invalidator): Remove.
8363         (regcache::raw_write): Use make_scope_exit.
8364
8365 2019-01-23  Tom Tromey  <tom@tromey.com>
8366
8367         * ui-out.h (class ui_out_emit_type): Update comment.
8368
8369 2019-01-23  Tom Tromey  <tom@tromey.com>
8370
8371         * infrun.c (fetch_inferior_event): Update comment.
8372
8373 2019-01-23  Tom Tromey  <tom@tromey.com>
8374             Pedro Alves  <palves@redhat.com>
8375
8376         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8377         parameter.
8378         (fetch_inferior_event): Use SCOPE_EXIT.
8379
8380
8381 2019-01-23  Tom Tromey  <tom@tromey.com>
8382             Pedro Alves  <palves@redhat.com>
8383
8384         * infrun.c (disable_thread_events): Delete.
8385         (stop_all_threads): Use SCOPE_EXIT.
8386
8387 2019-01-23  Tom Tromey  <tom@tromey.com>
8388             Pedro Alves  <palves@redhat.com>
8389
8390         * symfile.c: Include forward-scope-exit.h.
8391         (clear_symtab_users_cleanup): Replace forward declaration with
8392         a FORWARD_SCOPE_EXIT.
8393         (syms_from_objfile_1): Use the forward_scope_exit and
8394         gdb::optional instead of cleanup_function.
8395         (reread_symbols): Use the forward_scope_exit instead of
8396         cleanup_function.
8397         (clear_symtab_users_cleanup): Remove function.
8398
8399 2019-01-23  Tom Tromey  <tom@tromey.com>
8400             Pedro Alves  <palves@redhat.com>
8401
8402         * linux-nat.c: Include scope-exit.h.
8403         (cleanup_target_stop): Remove.
8404         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8405         SCOPE_EXIT.
8406
8407 2019-01-23  Tom Tromey  <tom@tromey.com>
8408             Pedro Alves  <palves@redhat.com>
8409
8410         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8411         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8412
8413 2019-01-23  Tom Tromey  <tom@tromey.com>
8414             Andrew Burgess  <andrew.burgess@embecosm.com>
8415             Pedro Alves  <palves@redhat.com>
8416
8417         * infrun.c (fetch_inferior_event): Use scope_exit.
8418         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8419         * top.c (execute_command): Use scope_exit.
8420         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8421         * utils.c (do_bpstat_clear_actions_cleanup)
8422         (make_bpstat_clear_actions_cleanup): Remove.
8423
8424 2019-01-23  Tom Tromey  <tom@tromey.com>
8425             Pedro Alves  <palves@redhat.com>
8426
8427         * infrun.c: Include "common/scope-exit.h"
8428         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8429         (wait_for_inferior): Use SCOPE_EXIT.
8430         (fetch_inferior_event): Use scope_exit.
8431
8432 2019-01-23  Tom Tromey  <tom@tromey.com>
8433             Pedro Alves  <palves@redhat.com>
8434
8435         * breakpoint.c (create_breakpoint): Remove cleanup.
8436
8437 2019-01-23  Tom Tromey  <tom@tromey.com>
8438             Andrew Burgess  <andrew.burgess@embecosm.com>
8439             Pedro Alves  <palves@redhat.com>
8440
8441 2019-01-23  Pedro Alves  <palves@redhat.com>
8442
8443         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8444
8445 2019-01-23  Pedro Alves  <palves@redhat.com>
8446             Andrew Burgess  <andrew.burgess@embecosm.com>
8447
8448         * gdbthread.h: Include "common/forward-scope-exit.h".
8449         (scoped_finish_thread_state): Redefine custom class in terms of
8450         forward_scope_exit.
8451
8452 2019-01-23  Pedro Alves  <palves@redhat.com>
8453             Andrew Burgess  <andrew.burgess@embecosm.com>
8454
8455         * common/forward-scope-exit.h: New file.
8456
8457 2019-01-23  Pedro Alves  <palves@redhat.com>
8458             Andrew Burgess  <andrew.burgess@embecosm.com>
8459             Tom Tromey  <tom@tromey.com>
8460
8461         * common/scope-exit.h: New file.
8462
8463 2019-01-23  Pedro Alves  <palves@redhat.com>
8464
8465         * common/preprocessor.h (ESC): Rename to ...
8466         (ESC_PARENS): ... this.
8467         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8468         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8469
8470 2019-01-23  Tom Tromey  <tom@tromey.com>
8471
8472         * language.h (class scoped_switch_to_sym_language_if_auto):
8473         Initialize m_lang in both cases.
8474
8475 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8476
8477         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8478         with XCNEW.
8479
8480 2019-01-22  Tom Tromey  <tom@tromey.com>
8481
8482         * corelow.c: Do not include sys/file.h.
8483
8484 2019-01-22  Tom Tromey  <tom@tromey.com>
8485
8486         * tui/tui-wingeneral.h: Include gdb_curses.h.
8487
8488 2019-01-22  Tom Tromey  <tom@tromey.com>
8489
8490         * source-cache.h (class source_cache) <get_source_lines,
8491         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8492
8493 2019-01-22  Tom Tromey  <tom@tromey.com>
8494
8495         * remote-fileio.h (struct remote_target): Declare.
8496
8497 2019-01-22  Tom Tromey  <tom@tromey.com>
8498
8499         * python/py-arch.c: Do not include py-ref.h.
8500         * python/py-bpevent.c: Do not include py-ref.h.
8501         * python/py-cmd.c: Do not include py-ref.h.
8502         * python/py-continueevent.c: Do not include py-ref.h.
8503         * python/py-event.h: Do not include py-ref.h.
8504         * python/py-evtregistry.c: Do not include py-ref.h.
8505         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8506         * python/py-frame.c: Do not include py-ref.h.
8507         * python/py-framefilter.c: Do not include py-ref.h.
8508         * python/py-function.c: Do not include py-ref.h.
8509         * python/py-infevents.c: Do not include py-ref.h.
8510         * python/py-linetable.c: Do not include py-ref.h.
8511         * python/py-objfile.c: Do not include py-ref.h.
8512         * python/py-param.c: Do not include py-ref.h.
8513         * python/py-prettyprint.c: Do not include py-ref.h.
8514         * python/py-progspace.c: Do not include py-ref.h.
8515         * python/py-symbol.c: Do not include py-ref.h.
8516         * python/py-symtab.c: Do not include py-ref.h.
8517         * python/py-type.c: Do not include py-ref.h.
8518         * python/py-unwind.c: Do not include py-ref.h.
8519         * python/py-utils.c: Do not include py-ref.h.
8520         * python/py-value.c: Do not include py-ref.h.
8521         * python/py-varobj.c: Do not include py-ref.h.
8522         * python/py-xmethods.c: Do not include py-ref.h.
8523         * python/python.c: Do not include py-ref.h.
8524         * varobj.c: Do not include py-ref.h.
8525
8526 2019-01-22  Tom Tromey  <tom@tromey.com>
8527
8528         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8529         keyword for bcache.
8530
8531 2019-01-22  Tom Tromey  <tom@tromey.com>
8532
8533         * compile/compile-cplus-types.c: Remove a comment by #include.
8534
8535 2019-01-22  Tom Tromey  <tom@tromey.com>
8536
8537         * compile/gcc-c-plugin.h: Include compile-internal.h.
8538
8539 2019-01-22  Tom Tromey  <tom@tromey.com>
8540
8541         * stabsread.c (EXTERN): Do not define.
8542         (symnum, next_symbol_text_func, processing_gcc_compilation)
8543         (within_function, global_sym_chain, global_stabs)
8544         (previous_stab_code, this_object_header_files)
8545         (n_this_object_header_files)
8546         (n_allocated_this_object_header_files): Define.
8547         * stabsread.h (EXTERN): Never define.  Use "extern".
8548
8549 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8550
8551         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8552         history_value.
8553
8554 2019-01-21  Tom Tromey  <tom@tromey.com>
8555
8556         * ui-out.c: Fix includes.
8557         * tui/tui-source.c: Fix includes.
8558         * target.c: Fix includes.
8559         * remote.c: Fix includes.
8560         * regcache.c: Fix includes.
8561         * python/py-block.c: Fix includes.
8562         * printcmd.c: Fix includes.
8563         * or1k-tdep.c: Fix includes.
8564         * mi/mi-main.c: Fix includes.
8565         * m32r-tdep.c: Fix includes.
8566         * csky-tdep.c: Fix includes.
8567         * compile/compile-cplus-types.c: Fix includes.
8568         * cli/cli-interp.c: Fix includes.
8569
8570 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8571
8572         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8573         for padding.
8574
8575 2019-01-16  Tom Tromey  <tom@tromey.com>
8576
8577         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8578         earlier.
8579         (struct objfile) <msymbols_range>: Move from top level.
8580         <msymbols>: New method.
8581         (class objfile_msymbols): Remove.
8582         * symtab.c (default_collect_symbol_completion_matches_break_on):
8583         Update.
8584         * symmisc.c (dump_msymbols): Update.
8585         * stabsread.c (scan_file_globals): Update.
8586         * objc-lang.c (info_selectors_command, info_classes_command)
8587         (find_methods): Update.
8588         * minsyms.c (find_solib_trampoline_target): Update.
8589         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8590         * coffread.c (coff_symfile_read): Update.
8591         * ada-lang.c (ada_lookup_simple_minsym)
8592         (ada_collect_symbol_completion_matches): Update.
8593
8594 2019-01-16  Tom Tromey  <tom@tromey.com>
8595
8596         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8597         type.  Remove no-argument constructor.
8598         <iterator::operator++>: Simplify.
8599         <begin>: Update.
8600         <end>: Use minimal_symbol_count.
8601
8602 2019-01-16  Tom Tromey  <tom@tromey.com>
8603
8604         * objfiles.h (struct objfile) <psymtabs>: New method.
8605         (class objfile_psymtabs): Remove.
8606         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8607         typedef.
8608         <range>: New method.
8609         (require_partial_symbols): Change return type.
8610         * psymtab.c (require_partial_symbols)
8611         (psym_expand_symtabs_matching): Update.
8612         * mdebugread.c (parse_partial_symbols): Update.
8613         * dbxread.c (dbx_end_psymtab): Update.
8614
8615 2019-01-15  Tom Tromey  <tom@tromey.com>
8616
8617         * symtab.c (lookup_objfile_from_block)
8618         (lookup_symbol_in_objfile_symtabs)
8619         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8620         (find_line_symtab, info_sources_command)
8621         (default_collect_symbol_completion_matches_break_on)
8622         (make_source_files_completion_list): Update.
8623         * symmisc.c (print_objfile_statistics, dump_objfile)
8624         (maintenance_print_symbols, maintenance_info_symtabs)
8625         (maintenance_check_symtabs, maintenance_info_line_tables):
8626         Update.
8627         * source.c (select_source_symtab)
8628         (forget_cached_source_info_for_objfile): Update.
8629         * objfiles.h (class objfile_compunits): Remove.
8630         (struct objfile) <compunits_range>: New typedef.
8631         (compunits): New method.
8632         * objfiles.c (objfile_relocate1): Update.
8633         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8634         * maint.c (count_symtabs_and_blocks): Update.
8635         * linespec.c (iterate_over_all_matching_symtabs): Update.
8636         * cp-support.c (add_symbol_overload_list_qualified): Update.
8637         * coffread.c (coff_symtab_read): Update.
8638         * ada-lang.c (add_nonlocal_symbols)
8639         (ada_collect_symbol_completion_matches)
8640         (ada_add_global_exceptions): Update.
8641
8642 2019-01-15  Tom Tromey  <tom@tromey.com>
8643
8644         * progspace.h (program_space) <objfiles_safe_range>: New
8645         typedef.
8646         <objfiles_safe>: New method.
8647         * objfiles.h (class all_objfiles_safe): Remove.
8648         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8649         * jit.c (jit_inferior_exit_hook): Update.
8650
8651 2019-01-17  Tom Tromey  <tom@tromey.com>
8652
8653         * progspace.h (program_space) <objfiles_range>: New typedef.
8654         <objfiles>: New method.
8655         <objfiles_head>: Rename from objfiles.
8656         (object_files): Update.
8657         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8658         * guile/scm-pretty-print.c
8659         (ppscm_find_pretty_printer_from_objfiles): Update.
8660         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8661         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8662         Update.
8663         * python/py-progspace.c (pspy_get_objfiles): Update.
8664         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8665         Update.
8666         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8667         (objfpy_lookup_objfile_by_build_id): Update.
8668         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8669         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8670         Update.
8671         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8672         (expand_symtab_containing_pc, lookup_objfile_from_block)
8673         (lookup_static_symbol, basic_lookup_transparent_type)
8674         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8675         (find_line_symtab, info_sources_command)
8676         (default_collect_symbol_completion_matches_break_on)
8677         (make_source_files_completion_list, find_main_name): Update.
8678         * symmisc.c (print_symbol_bcache_statistics)
8679         (print_objfile_statistics, maintenance_print_symbols)
8680         (maintenance_print_msymbols, maintenance_print_objfiles)
8681         (maintenance_info_symtabs, maintenance_check_symtabs)
8682         (maintenance_expand_symtabs, maintenance_info_line_tables):
8683         Update.
8684         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8685         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8686         (map_overlay_command, unmap_overlay_command)
8687         (simple_overlay_update, expand_symtabs_matching)
8688         (map_symbol_filenames): Update.
8689         * symfile-debug.c (set_debug_symfile): Update.
8690         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8691         Update.
8692         * source.c (select_source_symtab, forget_cached_source_info):
8693         Update.
8694         * solib.c (solib_read_symbols): Update.
8695         * solib-spu.c (append_ocl_sos): Update.
8696         * psymtab.c (maintenance_print_psymbols)
8697         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8698         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8699         * printcmd.c (info_symbol_command): Update.
8700         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8701         Update.
8702         * objfiles.h (class all_objfiles): Remove.
8703         * objfiles.c (have_partial_symbols, have_full_symbols)
8704         (have_minimal_symbols, qsort_cmp, update_section_map)
8705         (shared_objfile_contains_address_p)
8706         (default_iterate_over_objfiles_in_search_order): Update.
8707         * objc-lang.c (info_selectors_command, info_classes_command)
8708         (find_methods): Update.
8709         * minsyms.c (find_solib_trampoline_target): Update.
8710         * maint.c (maintenance_info_sections)
8711         (maintenance_translate_address, count_symtabs_and_blocks):
8712         Update.
8713         * main.c (captured_main_1): Update.
8714         * linux-thread-db.c (try_thread_db_load_from_pdir)
8715         (has_libpthread): Update.
8716         * linespec.c (iterate_over_all_matching_symtabs)
8717         (search_minsyms_for_name): Update.
8718         * jit.c (jit_find_objf_with_entry_addr): Update.
8719         * hppa-tdep.c (find_unwind_entry)
8720         (hppa_lookup_stub_minimal_symbol): Update.
8721         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8722         Update.
8723         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8724         (elf_gnu_ifunc_resolve_by_got): Update.
8725         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8726         * dwarf-index-write.c (save_gdb_index_command): Update.
8727         * cp-support.c (add_symbol_overload_list_qualified): Update.
8728         * breakpoint.c (create_overlay_event_breakpoint)
8729         (create_longjmp_master_breakpoint)
8730         (create_std_terminate_master_breakpoint)
8731         (create_exception_master_breakpoint): Update.
8732         * blockframe.c (find_pc_partial_function): Update.
8733         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8734         (ada_collect_symbol_completion_matches)
8735         (ada_add_global_exceptions): Update.
8736
8737 2019-01-17  Tom Tromey  <tom@tromey.com>
8738
8739         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8740         declare VEC.
8741         (solib_target_parse_libraries): Change return type.
8742         (library_list_start_segment, library_list_start_section)
8743         (library_list_end_library, library_list_start_library); Update.
8744         (solib_target_free_library_list): Remove.
8745         (solib_target_parse_libraries): Remove cleanup.  Change return
8746         type.
8747         (solib_target_current_sos): Update.
8748
8749 2019-01-17  Tom Tromey  <tromey@bapiya>
8750
8751         * valprint.c: Replace "the the" with "the".
8752         * symtab.c: Replace "the the" with "the".
8753         * solib.c: Replace "the the" with "the".
8754         * solib-dsbt.c: Replace "the the" with "the".
8755         * linespec.c: Replace "the the" with "the".
8756         * dwarf2loc.h: Replace "the the" with "the".
8757         * amd64-windows-tdep.c: Replace "the the" with "the".
8758         * aarch64-tdep.c: Replace "the the" with "the".
8759
8760 2019-01-16  Keith Seitz  <keiths@redhat.com>
8761
8762         PR gdb/23773
8763         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8764         <builder>: Rename to ..
8765         <m_builder>: ... this and make private.
8766         (dwarf2_cu::get_builder): New method.  Change all users of
8767         `builder' to use this method.
8768         (dwarf2_start_symtab): Move to ...
8769         (dwarf2_cu::start_symtab): ... here.  Update all callers
8770         (setup_type_unit_groups): Move to ...
8771         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8772         callers.
8773         (dwarf2_cu::reset_builder): New method.
8774         (process_full_compunit, process_full_type_unit): Use
8775         dwarf2_cu::reset_builder.
8776         (follow_die_offset): Record the ancestor CU if it is different
8777         from the followed DIE's CU.
8778         (follow_die_sig_1): Likewise.
8779
8780 2019-01-15  Tom Tromey  <tom@tromey.com>
8781
8782         * remote.c (class remote_state) <buf>: Now a char_vector.
8783         <buf_size>: Remove.
8784         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8785         parameter.
8786         (remote_target::getpkt_or_notif_sane_1)
8787         (remote_target::getpkt_sane)
8788         (remote_target::getpkt_or_notif_sane): Likewise.
8789         (class remote_target) <putpkt>: New overload.
8790         (remote_target::read_frame): Change type of "buf_p".  Remove
8791         sizeof_p parameter.
8792         (packet_ok): New overload.
8793         (packet_check_result): New overload.
8794         Update all uses.
8795
8796 2019-01-14  Tom Tromey  <tom@tromey.com>
8797
8798         * remote-notif.c (handle_notification, remote_notif_ack)
8799         (remote_notif_parse): Make "buf" const.
8800         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8801         const.
8802         (remote_notif_parse, remote_notif_ack, handle_notification):
8803         Likewise.
8804         * remote.c (remote_notif_stop_parse): Make "buf" const.
8805         (remote_target::remote_parse_stop_reply): Make "buf" const.
8806         (remote_notif_stop_ack): Make "buf" const.
8807
8808 2019-01-14  Tom Tromey  <tom@tromey.com>
8809
8810         * remote.c (remote_console_output): Make parameter const.
8811
8812 2019-01-14  Tom Tromey  <tom@tromey.com>
8813
8814         * target-debug.h (target_debug_print_signals): Constify.
8815         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8816         * procfs.c (procfs_target::pass_signals): Update.
8817         * linux-nat.c (linux_nat_target::pass_signals): Update.
8818         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8819         * target-delegates.c: Rebuild.
8820         * remote.c (remote_target::program_signals): Update.
8821         (remote_target::pass_signals): Update.
8822         * target.c (target_pass_signals): Constify argument.
8823         (target_program_signals): Likewise.
8824         * target.h (struct target_ops) <pass_signals, program_signals>:
8825         Constify argument.
8826         (target_pass_signals, target_program_signals): Constify argument.
8827
8828 2019-01-14  Tom Tromey  <tom@tromey.com>
8829
8830         PR tui/28819:
8831         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8832
8833 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8834
8835         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8836         field.
8837         * rs6000-tdep.c: Include reggroups.h.
8838         (IS_V_ALIAS_PSEUDOREG): Define.
8839         (rs6000_register_name): Return names for the "vX" aliases.
8840         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8841         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8842         aliases.  Call default_register_reggroup_p for all other
8843         pseudo-registers.
8844         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8845         New functions.
8846         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8847         Handle "vX" aliases.
8848         (v_alias_pseudo_register_collect): New function.
8849         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8850         (rs6000_gdbarch_init): Initialize "vX" aliases as
8851         pseudo-registers.  Restore registration of
8852         rs6000_pseudo_register_reggroup_p with
8853         set_tdesc_pseudo_register_reggroup_p.
8854
8855 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8856
8857         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8858         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8859         set_gdbarch_num_pseudo_regs.
8860
8861 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8862
8863         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8864         Remove arg prefixname, add do_set and do_show.
8865         Add member functions set_list and show_list.
8866         * cli/cli-style.c (class cli_style_option): Update accordingly.
8867         (style_set_list): Move to file scope.
8868         (style_show_list): Likewise.
8869         (set_style): Call help_list.
8870         (show_style): Call cmd_show_list.
8871         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8872         Update to use the new macro.
8873
8874 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8875
8876         * ada-lang.c (_initialize_ada_language): Expand the help text
8877         for the "catch exception" command.
8878
8879 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8880
8881         * symtab.c (matching_obj_sections): Initialize obj,
8882         declare it closer to its usage.
8883
8884 2019-01-10  Tom Tromey  <tom@tromey.com>
8885
8886         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8887         (basic_inf_threads_range): Remove.
8888         (inf_threads_range, inf_non_exited_threads_range)
8889         (safe_inf_threads_range): Use next_adapter.
8890
8891 2019-01-10  Keith Seitz  <keiths@redhat.com>
8892
8893         PR gdb/23712
8894         PR symtab/23010
8895         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8896         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8897
8898 2019-01-10  Keith Seitz  <keiths@redhat.com>
8899
8900         PR gdb/23712
8901         PR symtab/23010
8902         * dictionary.c (pending_to_vector): Remove.
8903         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8904         Remove _1 suffix, replacing functions of the same name.  Update
8905         all callers.
8906         (dict_create_hashed, dict_create_hashed_expandable)
8907         (dict_create_linear, dict_create_linear_expandable, dict_free)
8908         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8909         Make functions static.
8910
8911 2019-01-10  Keith Seitz  <keiths@redhat.com>
8912
8913         PR gdb/23712
8914         PR symtab/23010
8915         * dictionary.h (struct dictionary): Replace declaration with
8916         multidictionary.
8917         (dict_create_hashed, dict_create_hashed_expandable)
8918         (dict_create_linear, dict_create_linear_expandable)
8919         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8920         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8921         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8922         taking multidictionary argument.
8923         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8924         * block.h (struct block) <dict>: Change to multidictionary
8925         and rename `multidict'.
8926         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8927         symmisc.c: Update all dictionary references to multidictionary.
8928
8929 2019-01-10  Keith Seitz  <keiths@redhat.com>
8930
8931         PR gdb/23712
8932         PR symtab/23010
8933         * dictionary.c: Include unordered_map.
8934         (pending_to_vector): New function.
8935         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8936         Rewrite the non-"_1" functions to take vector instead
8937         of linked list.
8938         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8939         "new" _1 versions of the same name.
8940         (multidictionary): Define.
8941         (std::hash<enum language): New definition.
8942         (collate_pending_symbols_by_language, mdict_create_hashed)
8943         (mdict_create_hashed_expandable, mdict_create_linear)
8944         (mdict_create_linear_expandable, mdict_free)
8945         (find_language_dictionary, create_new_language_dictionary)
8946         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8947         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8948         (mdict_size, mdict_empty): New functions.
8949         * dictionary.h (mdict_iterator): Define.
8950
8951 2019-01-10  Pedro Alves  <palves@redhat.com>
8952
8953         * breakpoint.c (read_uploaded_action)
8954         (create_tracepoint_from_upload): Adjust to use
8955         gdb::unique_xmalloc_ptr.
8956         * ctf.c (ctf_write_uploaded_tp):
8957         (SET_ARRAY_FIELD): Use emplace_back.
8958         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8959         * tracefile-tfile.c (tfile_write_uploaded_tp):
8960         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8961         gdb::unique_xmalloc_ptr.
8962         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8963         at_string, cond_string, cmd_strings>: Replace char pointers
8964         with gdb::unique_xmalloc_ptr.
8965
8966 2019-01-10  Pedro Alves  <palves@redhat.com>
8967
8968         * solib-target.c (library_list_start_library): Don't xstrdup name.
8969
8970 2019-01-10  Pedro Alves  <palves@redhat.com>
8971
8972         * mdebugread.c (parse_partial_symbols): Use
8973         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8974
8975 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8976
8977         * linux-fork.c (scoped_switch_fork_info)
8978         <~scoped_switch_fork_info>: Fix incorrect variable name.
8979
8980 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8981
8982         * linux-fork.c (scoped_switch_fork_info)
8983         <scoped_switch_fork_info>: Make explicit.
8984         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8985
8986 2019-01-10  Tom Tromey  <tom@tromey.com>
8987
8988         * objfiles.h (objfile::reset_psymtabs): Update.
8989         * objfiles.c (objfile::objfile): Update.
8990         * psymtab.h (psymtab_storage::obstack): Update.
8991         (psymtab_storage::m_obstack): Use gdb::optional.
8992         (class psymtab_storage): Update comment.  Remove objfile
8993         parameter.
8994         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8995
8996 2019-01-10  Tom Tromey  <tom@tromey.com>
8997
8998         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8999         <free_psymtabs>: Now private.
9000         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9001         (allocate_psymtab): Use new method.
9002
9003 2019-01-10  Tom Tromey  <tom@tromey.com>
9004
9005         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9006         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9007         * mdebugread.c (parse_partial_symbols): Use
9008         allocate_dependencies.
9009         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9010         allocate_dependencies.
9011         (process_psymtab_comp_unit_reader)
9012         (build_type_psymtab_dependencies): Likewise.
9013         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9014
9015 2019-01-10  Tom Tromey  <tom@tromey.com>
9016
9017         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9018         PSYMBOL_SET_LANGUAGE.
9019         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9020
9021 2019-01-10  Tom Tromey  <tom@tromey.com>
9022
9023         * psymtab.h (psymtab_storage::obstack): New method.
9024         <m_obstack>: Rename from obstack; now private.
9025         * psymtab.c (psymtab_storage): Update.
9026         * dwarf2read.c (create_addrmap_from_index)
9027         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9028         Update.
9029
9030 2019-01-10  Tom Tromey  <tom@tromey.com>
9031
9032         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9033         * objfiles.h (objfile::reset_psymtabs): New method.
9034
9035 2019-01-10  Tom Tromey  <tom@tromey.com>
9036
9037         * symmisc.c (print_symbol_bcache_statistics): Update.
9038         (print_objfile_statistics): Update.
9039         * symfile.c (reread_symbols): Update.
9040         * psymtab.h (class psymtab_storage): New.
9041         * psymtab.c (psymtab_storage): New constructor.
9042         (~psymtab_storage): New destructor.
9043         (require_partial_symbols): Update.
9044         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9045         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9046         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9047         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9048         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9049         (start_psymtab_common, end_psymtab_common)
9050         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9051         (allocate_psymtab): Update.
9052         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9053         Update.
9054         (dump_psymtab_addrmap, maintenance_print_psymbols)
9055         (maintenance_check_psymtabs): Update.
9056         (class objfile_psymtabs): Move to objfiles.h.
9057         * psympriv.h (discard_psymtab): Now inline.
9058         (psymtab_discarder::psymtab_discarder): Update.
9059         (psymtab_discarder::~psymtab_discarder): Update.
9060         (ALL_OBJFILE_PSYMTABS): Rewrite.
9061         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9062         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9063         Remove fields.
9064         <partial_symtabs>: New field.
9065         (class objfile_psymtabs): Move from psymtab.h.  Update.
9066         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9067         psymbol_cache.
9068         (objfile::~objfile): Don't destroy psymbol_cache.
9069         * mdebugread.c (parse_partial_symbols): Update.
9070         * dwarf2read.c (create_addrmap_from_index)
9071         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9072         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9073         (add_partial_subprogram, dwarf2_ranges_read): Update.
9074         * dwarf-index-write.c (write_address_map)
9075         (write_one_signatured_type, recursively_write_psymbols)
9076         (class debug_names, class debug_names, write_psymtabs_to_index):
9077         Update.
9078
9079 2019-01-10  Tom Tromey  <tom@tromey.com>
9080
9081         * symtab.h (SYMBOL_SET_NAMES): Update.
9082         (symbol_set_names): Update.
9083         (MSYMBOL_SET_NAMES): Update.
9084         * symtab.c (symbol_set_names): Change argument to be an
9085         objfile_per_bfd_storage.
9086         * psymtab.c (add_psymbol_to_bcache): Update.
9087         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9088
9089 2019-01-10  Tom Tromey  <tom@tromey.com>
9090
9091         * symtab.c (create_demangled_names_hash): Change argument to be an
9092         objfile_per_bfd_storage.
9093         (symbol_set_names): Update.
9094
9095 2019-01-10  Tom Tromey  <tom@tromey.com>
9096
9097         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9098         init_psymbol_list.
9099         * psymtab.c (init_psymbol_list): Do nothing if already called.
9100         * psympriv.h (init_psymbol_list): Add comment.
9101         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9102         init_psymbol_list.
9103         * dbxread.c (dbx_symfile_read): Unconditionally call
9104         init_psymbol_list.
9105
9106 2019-01-10  Tom Tromey  <tom@tromey.com>
9107
9108         * xcoffread.c (scan_xcoff_symtab): Update.
9109         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9110         "where".
9111         * mdebugread.c (parse_partial_symbols)
9112         (handle_psymbol_enumerators): Update.
9113         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9114         * dbxread.c (read_dbx_symtab): Update.
9115         * psympriv.h (psymbol_placement): New enum.
9116         (add_psymbol_to_list): Update.
9117
9118 2019-01-10  Tom Tromey  <tom@tromey.com>
9119
9120         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9121         static_psymbols parameters.
9122         (scan_xcoff_symtab): Update.
9123         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9124         static_psymbols parameters.
9125         * psympriv.h (start_psymtab_common): Update.
9126         * mdebugread.c (parse_partial_symbols): Update.
9127         * dwarf2read.c (create_partial_symtab): Update.
9128         * dbxread.c (read_dbx_symtab): Update.
9129         (start_psymtab): Remove global_psymbols and static_psymbols
9130         parameters.
9131
9132 2019-01-10  Tom Tromey  <tom@tromey.com>
9133
9134         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9135         * psymtab.c (allocate_psymtab): Add comment.
9136         * psympriv.h (allocate_psymtab): Add comment.
9137         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9138         initializations.
9139         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9140
9141 2019-01-10  Tom Tromey  <tom@tromey.com>
9142
9143         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9144         Don't declare.
9145         * mipsread.c: Include mdebugread.h.
9146         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9147         Declare.
9148         * elfread.c: Include mdebugread.h.
9149
9150 2019-01-09  Tom Tromey  <tom@tromey.com>
9151
9152         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9153         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9154         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9155         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9156         (psym_lookup_symbol, psym_find_last_source_symtab)
9157         (psym_forget_cached_source_info, psym_print_stats)
9158         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9159         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9160         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9161         (psym_find_compunit_symtab_by_address)
9162         (maintenance_print_psymbols, maintenance_info_psymtabs)
9163         (maintenance_check_psymtabs): Use ranged for.
9164         * psymtab.h (class objfile_psymtabs): New.
9165         (require_partial_symbols): Return objfile_psymtabs.
9166         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9167
9168 2019-01-09  Tom Tromey  <tom@tromey.com>
9169
9170         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9171         (find_pc_mapped_section, list_overlays_command)
9172         (map_overlay_command, unmap_overlay_command)
9173         (simple_overlay_update): Use all_objfiles.
9174         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9175         * printcmd.c (info_symbol_command): Use all_objfiles.
9176         * objfiles.h (ALL_OBJSECTIONS): Remove.
9177         * maint.c (maintenance_translate_address): Use all_objfiles.
9178         * gcore.c (gcore_create_callback): Use all_objfiles.
9179         (objfile_find_memory_regions): Likewise.
9180
9181 2019-01-09  Tom Tromey  <tom@tromey.com>
9182
9183         * symtab.c (find_line_symtab, info_sources_command)
9184         (make_source_files_completion_list): Use objfile_compunits.
9185         * source.c (select_source_symtab): Use objfile_compunits.
9186         * objfiles.h (struct objfile): Update comment.
9187         (ALL_OBJFILES): Remove.
9188         (ALL_FILETABS): Remove.
9189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9190         objfile_compunits.
9191
9192 2019-01-09  Tom Tromey  <tom@tromey.com>
9193
9194         * symmisc.c (print_objfile_statistics, dump_objfile)
9195         (maintenance_print_symbols): Use compunit_filetabs.
9196         * source.c (forget_cached_source_info_for_objfile): Use
9197         compunit_filetabs.
9198         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9199         (ALL_FILETABS): Use compunit_filetabs.
9200         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9201         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9202
9203 2019-01-09  Tom Tromey  <tom@tromey.com>
9204
9205         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9206         (compunit_filetabs): New.
9207         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9208         compunit_filetabs.
9209         (info_sources_command, make_source_files_completion_list): Remove
9210         declaration.
9211         * symmisc.c (print_objfile_statistics, dump_objfile)
9212         (maintenance_print_symbols): Remove declaration.
9213         (maintenance_info_symtabs): Use compunit_filetabs.
9214         (maintenance_info_line_tables): Likewise.
9215         * source.c (select_source_symtab): Change local variable name.
9216         (forget_cached_source_info_for_objfile): Remove declaration.
9217         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9218         * objfiles.c (objfile_relocate1): Remove declaration.
9219         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9220         declaration.
9221         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9222         * coffread.c (coff_symtab_read): Remove declaration.
9223         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9224         compunit_filetabs.
9225
9226 2019-01-09  Tom Tromey  <tom@tromey.com>
9227
9228         * symtab.c (lookup_objfile_from_block)
9229         (find_pc_sect_compunit_symtab, search_symbols)
9230         (default_collect_symbol_completion_matches_break_on): Use
9231         objfile_compunits.
9232         * objfiles.h (ALL_COMPUNITS): Remove.
9233         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9234         * cp-support.c (add_symbol_overload_list_qualified): Use
9235         objfile_compunits.
9236         * ada-lang.c (ada_collect_symbol_completion_matches)
9237         (ada_add_global_exceptions): Use objfile_compunits.
9238
9239 2019-01-09  Tom Tromey  <tom@tromey.com>
9240
9241         * source.c (select_source_symtab)
9242         (forget_cached_source_info_for_objfile): Remove declaration.
9243         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9244         declaration.
9245         * maint.c (count_symtabs_and_blocks): Remove declaration.
9246         * cp-support.c (add_symbol_overload_list_qualified): Remove
9247         declaration.
9248         * coffread.c (coff_symtab_read): Remove declaration.
9249         * symtab.c (lookup_symbol_in_objfile_symtabs)
9250         (basic_lookup_transparent_type_1): Use objfile_compunits.
9251         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9252         (info_sources_command, search_symbols)
9253         (default_collect_symbol_completion_matches_break_on)
9254         (make_source_files_completion_list): Remove declaration.
9255         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9256         (ada_collect_symbol_completion_matches)
9257         (ada_add_global_exceptions): Remove declaration.
9258         * linespec.c (iterate_over_all_matching_symtabs): Use
9259         objfile_compunits.
9260         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9261         (class objfile_compunits): New.
9262         (ALL_COMPUNITS): Use objfile_compunits.
9263         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9264         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9265         objfile_compunits.
9266         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9267
9268 2019-01-09  Tom Tromey  <tom@tromey.com>
9269
9270         * symtab.c (search_symbols)
9271         (default_collect_symbol_completion_matches_break_on): Use
9272         objfile_msymbols.
9273         * ada-lang.c (ada_lookup_simple_minsym)
9274         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9275         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9276         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9277         objfile_msymbols.
9278         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9279         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9280         * objc-lang.c (find_methods): Use objfile_msymbols.
9281         (info_selectors_command, info_classes_command): Likewise.
9282         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9283         * objfiles.h (class objfile_msymbols): New.
9284         (ALL_OBJFILE_MSYMBOLS): Remove.
9285         (ALL_MSYMBOLS): Remove.
9286
9287 2019-01-09  Tom Tromey  <tom@tromey.com>
9288
9289         * common/next-iterator.h (next_adapter): Add Iterator template
9290         parameter.
9291         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9292         (class all_objfiles_safe): New.
9293         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9294         * objfiles.c (put_objfile_before): Update comment.
9295         (add_separate_debug_objfile): Likewise.
9296         (free_all_objfiles): Use all_objfiles_safe.
9297         (objfile_purge_solibs): Likewise.
9298
9299 2019-01-09  Tom Tromey  <tom@tromey.com>
9300
9301         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9302         (expand_symtab_containing_pc, lookup_static_symbol)
9303         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9304         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9305         all_objfiles.
9306         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9307         * breakpoint.c (create_overlay_event_breakpoint)
9308         (create_longjmp_master_breakpoint)
9309         (create_std_terminate_master_breakpoint)
9310         (create_exception_master_breakpoint): Use all_objfiles.
9311         * linux-thread-db.c (try_thread_db_load_from_pdir)
9312         (has_libpthread): Use all_objfiles.
9313         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9314         * linespec.c (iterate_over_all_matching_symtabs)
9315         (search_minsyms_for_name): Use all_objfiles.
9316         * maint.c (maintenance_info_sections): Use all_objfiles.
9317         * main.c (captured_main_1): Use all_objfiles.
9318         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9319         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9320         * guile/scm-pretty-print.c
9321         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9322         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9323         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9324         (maintenance_print_msymbols): Use all_objfiles.
9325         * source.c (select_source_symtab): Use all_objfiles.
9326         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9327         * symfile.c (remove_symbol_file_command)
9328         (expand_symtabs_matching, map_symbol_filenames): Use
9329         all_objfiles.
9330         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9331         all_objfiles.
9332         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9333         * objc-lang.c (find_methods): Use all_objfiles.
9334         * objfiles.c (have_partial_symbols, have_full_symbols)
9335         (have_minimal_symbols, qsort_cmp)
9336         (default_iterate_over_objfiles_in_search_order): Use
9337         all_objfiles.
9338         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9339         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9340         (maintenance_check_psymtabs): Use all_objfiles.
9341         (ALL_PSYMTABS): Remove.
9342         * compile/compile-object-run.c (do_module_cleanup): Use
9343         all_objfiles.
9344         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9345         * cp-support.c (add_symbol_overload_list_qualified): Use
9346         all_objfiles.
9347         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9348         Use all_objfiles.
9349         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9350         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9351         all_objfiles.
9352         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9353         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9354         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9355         Uses all_objfiles.
9356         * solib.c (solib_read_symbols): Use all_objfiles
9357
9358 2019-01-09  Tom Tromey  <tom@tromey.com>
9359
9360         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9361         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9362         all_objfiles.
9363         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9364         * symmisc.c (print_symbol_bcache_statistics)
9365         (print_objfile_statistics, maintenance_print_objfiles)
9366         (maintenance_info_symtabs, maintenance_check_symtabs)
9367         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9368         all_objfiles.
9369         * source.c (forget_cached_source_info): Use all_objfiles.
9370         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9371         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9372         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9373         * objfiles.c (update_section_map): Use all_objfiles.
9374         (shared_objfile_contains_address_p): Likewise.
9375         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9376         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9377
9378 2019-01-09  Tom Tromey  <tom@tromey.com>
9379
9380         * common/next-iterator.h: New file.
9381         * objfiles.h (class all_objfiles): New.
9382         (struct objfile_iterator): New.
9383
9384 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9385
9386         * NEWS: Move the description of the changed "frame", "select-frame",
9387          and "info frame" commands to the Changed commands section.
9388
9389 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9390
9391         * gdbtypes.c (check_stub_method_group): Remove handling of old
9392         mangling schemes.
9393         * linespec.c (find_methods): Likewise.
9394         * stabsread.c (read_member_functions): Likewise.
9395         * valops.c (search_struct_method): Likewise.
9396         (value_struct_elt_for_reference): Likewise.
9397         * NEWS: Mention this change.
9398
9399 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9400
9401         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9402         print_source_lines.
9403         * source.c (print_source_lines_base): Update line number check.
9404         (print_source_lines): New function.
9405         (source_lines_range::source_lines_range): New function.
9406         * source.h (class source_lines_range): New class.
9407         (print_source_lines): New declaration.
9408
9409 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9410
9411         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9412
9413 2019-01-08  Tom Tromey  <tom@tromey.com>
9414             Simon Marchi  <simon.marchi@ericsson.com>
9415
9416         PR gdb/24060
9417         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9418         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9419         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9420         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9421         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9422         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9423
9424 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9425
9426         * source.c (select_source_symtab): Move header comment to
9427         declaration in source.h.
9428         (forget_cached_source_info_for_objfile): Likewise.
9429         (forget_cached_source_info): Likewise.
9430         (identify_source_line): Likewise.
9431         * source.h (identify_source_line): Move declaration from symtab.h
9432         and add comment from source.c
9433         (print_source_lines): Likewise.
9434         (forget_cached_source_info_for_objfile): Likewise.
9435         (forget_cached_source_info): Likewise.
9436         (select_source_symtab): Likewise.
9437         (enum print_source_lines_flag): Move definition from symtab.h.
9438         * symtab.h (identify_source_line): Move declaration to source.h.
9439         (print_source_lines): Likewise.
9440         (forget_cached_source_info_for_objfile): Likewise.
9441         (forget_cached_source_info): Likewise.
9442         (select_source_symtab): Likewise.
9443         (enum print_source_lines_flag): Move definition to source.h.
9444         * tui/tui-hooks.c: Add 'source.h' include.
9445
9446 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9447
9448         * source.c (print_source_lines_base): Handle requests to print
9449         reverse line number sequences, and guard against empty lines
9450         string.
9451
9452 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9453
9454         * source.c (print_source_lines_base): Fix skip of '\r' if next
9455         character is '\n'.
9456
9457 2019-01-06  Tom Tromey  <tom@tromey.com>
9458
9459         * c-exp.y (struct c_parse_state) <macro_original_text,
9460         expansion_obstack>: New member.
9461         (macro_original_text, expansion_obstack): Remove globals.
9462         (scan_macro_expansion, scanning_macro_expansion)
9463         (finished_macro_expansion): Update.
9464         (scan_macro_cleanup): Remove.
9465         (yylex, c_parse): Update.
9466
9467 2019-01-06  Tom Tromey  <tom@tromey.com>
9468
9469         * c-exp.y (struct c_parse_state) <strings>: New member.
9470         (operator_stoken): Update.
9471
9472 2019-01-06  Tom Tromey  <tom@tromey.com>
9473
9474         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9475         (union type_stack_elt) <typelist_val>: Now a pointer to
9476         std::vector.
9477         (type_stack_cleanup): Don't declare.
9478         (push_typelist): Update.
9479         * parse.c (pop_typelist): Return a std::vector.
9480         (push_typelist): Take a std::vector.
9481         (follow_types): Update.  Do not free args.
9482         (type_stack_cleanup): Remove.
9483         * c-exp.y (struct c_parse_state): New.
9484         (cpstate): New global.
9485         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9486         (nonempty_typelist): Update.
9487         (func_mod): Create a new vector.
9488         (c_parse): Create a c_parse_state.
9489         (check_parameter_typelist): Do not delete params.
9490         (function_method): Update.  Do not delete type_list.
9491
9492 2019-01-06  Tom Tromey  <tom@tromey.com>
9493
9494         PR gdb/28155:
9495         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9496         check_typedef.
9497         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9498         (print_return_value): Likewise.
9499
9500 2019-01-05  Tom Tromey  <tom@tromey.com>
9501
9502         * contrib/cleanup_check.py: Remove.
9503         * contrib/gcc-with-excheck: Remove.
9504         * contrib/exsummary.py: Remove.
9505         * contrib/excheck.py: Remove.
9506
9507 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9508
9509         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9510         NULL. Initialize tpprev to NULL instead of assigning it
9511         to NULL on the next statement.
9512         * windows-nat.c (windows_delete_thread): Remove check for
9513         main_thread_id before printing thread exit notifications.
9514         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9515         Remove thread ID check against main_thread_id.
9516         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9517         windows_delete_thread.
9518         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9519
9520 2019-01-04  Tom Tromey  <tom@tromey.com>
9521
9522         * compile/compile.c (_initialize_compile): Use upper case for
9523         metasyntactic variables.
9524         * symmisc.c (_initialize_symmisc): Use upper case for
9525         metasyntactic variables.
9526         * psymtab.c (_initialize_psymtab): Use upper case for
9527         metasyntactic variables.
9528         * demangle.c (demangle_command): Use upper case for metasyntactic
9529         variables.
9530         (_initialize_demangler): Likewise.
9531         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9532         variables.
9533
9534 2019-01-03  Tom Tromey  <tom@tromey.com>
9535
9536         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9537
9538 2019-01-03  Tom Tromey  <tom@tromey.com>
9539
9540         * python/py-symtab.c (salpy_str): Update.
9541         (struct salpy_sal_object) <symtab>: Now a PyObject.
9542         (salpy_dealloc): Update.
9543         (del_objfile_sal): Use gdbpy_ref.
9544
9545 2019-01-03  Tom Tromey  <tom@tromey.com>
9546
9547         * python/py-type.c (convert_field): Use new_reference.  Return
9548         gdbpy_ref.
9549         (make_fielditem): Return gdbpy_ref.
9550         (typy_fields): Update.
9551         (typy_getitem): Update.
9552         (field_name): Return gdbpy_ref.  Use new_reference.
9553         (typy_iterator_iternext): Update.
9554
9555 2019-01-03  Tom Tromey  <tom@tromey.com>
9556
9557         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9558
9559 2019-01-03  Tom Tromey  <tom@tromey.com>
9560
9561         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9562         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9563         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9564         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9565         (pspy_set_type_printers): Likewise.
9566         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9567         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9568         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9569         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9570         (objfpy_set_type_printers): Likewise.
9571
9572 2019-01-03  Tom Tromey  <tom@tromey.com>
9573
9574         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9575         (gdbpy_print_stack): Use gdbpy_err_fetch.
9576         * python/python-internal.h (class gdbpy_err_fetch): New class.
9577         (class gdbpy_enter) <m_error_type, m_error_value,
9578         m_error_traceback>: Remove.
9579         <m_error>: New member.
9580         (gdbpy_exception_to_string): Don't declare.
9581         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9582         * python/py-value.c (convert_value_from_python): Use
9583         gdbpy_err_fetch.
9584         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9585         gdbpy_exception_to_string.
9586         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9587         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9588         gdbpy_err_fetch.
9589
9590 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9591
9592         * linux-nat.c (delete_lwp_cleanup): Delete.
9593         (struct lwp_deleter): New struct.
9594         (lwp_info_up): New typedef.
9595         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9596         lwp_info_up.
9597
9598 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9599
9600         * linux-fork.c (class scoped_switch_fork_info): New class.
9601         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9602
9603 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9604
9605         * valops.c (find_overload_match): Remove use of null_cleanup, and
9606         calls to do_cleanups.
9607
9608 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9609
9610         * compile/compile-cplus-types.c
9611         (compile_cplus_instance::decl_name): Handle changes to
9612         cp_func_name.
9613         * cp-support.c (cp_func_name): Update header comment, update
9614         return type.
9615         * cp-support.h (cp_func_name): Update return type in declaration.
9616         * valops.c (find_overload_match): Move temp_func local to top
9617         level of function and change its type.  Use temp_func to hold and
9618         delete temporary string obtained from cp_func_name.
9619
9620 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9621
9622         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9623         gdb::char_vector, remove cleanup, and update uses of `msg`.
9624
9625 2019-01-03  Jim Wilson  <jimw@sifive.com>
9626
9627         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9628
9629 2019-01-02  Tom Tromey  <tom@tromey.com>
9630
9631         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9632         (tdesc_parse_xml): Remove cleanups.
9633         * target-descriptions.h (make_cleanup_free_target_description):
9634         Don't declare.
9635         (target_desc_deleter): New struct.
9636         (target_desc_up): New typedef.
9637         * target-descriptions.c (target_desc_deleter::operator()): Rename
9638         from free_target_description.
9639         (make_cleanup_free_target_description): Remove.
9640
9641 2019-01-02  Tom Tromey  <tom@tromey.com>
9642
9643         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9644         constructor, destructor.
9645         (linespec_parser): Remove typedef.
9646         (~linespec_parser): Rename from linespec_parser_delete.
9647         (linespec_lex_to_end, linespec_complete_label)
9648         (linespec_complete): Update.
9649         (decode_line_full): Remove cleanups.
9650         (decode_line_1): Update.
9651
9652 2019-01-02  Tom Tromey  <tom@tromey.com>
9653
9654         * python/python-internal.h (inferior_to_inferior_object): Change
9655         return type.
9656         * python/py-exitedevent.c (create_exited_event_object): Update.
9657         * python/py-inferior.c (inferior_to_inferior_object): Return
9658         gdbpy_ref.
9659         (python_new_inferior, python_inferior_deleted)
9660         (thread_to_thread_object, delete_thread_object)
9661         (build_inferior_list, gdbpy_selected_inferior): Update.
9662         * python/py-infthread.c (create_thread_object): Update.  Also fail
9663         if inferior_to_inferior_object fails.
9664
9665 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9666
9667         * inferior.h (class inferior) <displaced_step_state>: New field.
9668         * infrun.h (struct displaced_step_state): Move here from
9669         infrun.c.  Initialize fields, add constructor.
9670         <inf>: Remove field.
9671         <reset>: New method.
9672         * infrun.c (struct displaced_step_inferior_state): Move to
9673         infrun.h.
9674         (displaced_step_inferior_states): Remove.
9675         (get_displaced_stepping_state): Adust.
9676         (displaced_step_in_progress_any_inferior): Adjust.
9677         (displaced_step_in_progress_thread): Adjust.
9678         (displaced_step_in_progress): Adjust.
9679         (add_displaced_stepping_state): Remove.
9680         (get_displaced_step_closure_by_addr): Adjust.
9681         (remove_displaced_stepping_state): Remove.
9682         (infrun_inferior_exit): Call displaced_step_state.reset.
9683         (use_displaced_stepping): Don't check for NULL.
9684         (displaced_step_prepare_throw): Call
9685         get_displaced_stepping_state.
9686         (displaced_step_fixup): Don't check for NULL.
9687         (prepare_for_detach): Don't check for NULL.
9688
9689 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9690
9691         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9692          in case of call that did not complete.
9693
9694 2019-01-02  Andrey Utkin  <autkin@undo.io>
9695
9696         * symfile.c (find_separate_debug_file): Fix search of debug files for
9697         remote debuggee.
9698
9699 2019-01-02  Tom Tromey  <tom@tromey.com>
9700
9701         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9702         indentation.
9703         * python/py-frame.c (frapy_older): Remove cast.
9704         (frapy_newer): Likewise.
9705         * python/py-breakpoint.c (local_setattro): Remove cast.
9706         * python/py-arch.c (archpy_name): Remove local variable.
9707         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9708
9709 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9710
9711         * unittests/basic_string_view/element_access/char/empty.cc:
9712         Fix year range in copyright header.
9713
9714 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9715
9716         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9717         Delete.
9718         <operator==>: Update with for removed field.
9719         <hash>: Likewise.
9720         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9721         <isa_features>: ...this.
9722         <abi_features>: New field.
9723         (riscv_isa_flen): Update comment.
9724         (riscv_abi_xlen): New declaration.
9725         (riscv_abi_flen): New declaration.
9726         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9727         isa_features.
9728         (riscv_abi_xlen): New function.
9729         (riscv_isa_flen): Update to get answer from isa_features.
9730         (riscv_abi_flen): New function.
9731         (riscv_has_fp_abi): Update to get answer from abi_features.
9732         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9733         xlen and flen.
9734         (riscv_call_info) <xlen, flen>: Update comment.
9735         (riscv_call_arg_struct): Remove invalid assertions
9736         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9737         is removed.
9738         (riscv_gdbarch_init): Gather isa features and abi features
9739         separately, ensure both match on the gdbarch when reusing an old
9740         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9741         a target with 64-bit float hardware.
9742
9743 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9744
9745         * source.c (search_command_helper): Stop reverse search
9746         when line 1 has been searched.
9747
9748 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9749
9750         * record-full.c (record_full_base_target::close): Rewrite
9751         record_full_core_buf_list free logic.
9752
9753 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9754
9755         * break-catch-syscall.c (print_one_catch_syscall): xfree
9756         the last text.
9757
9758 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9759
9760         * top.c (print_gdb_version): Update Copyright year in version
9761         message.
9762
9763 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9764
9765         Update copyright year range in all GDB files.
9766
9767 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9768
9769         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9770
9771 For older changes see ChangeLog-2018.
9772 \f
9773 Local Variables:
9774 mode: change-log
9775 left-margin: 8
9776 fill-column: 74
9777 version-control: never
9778 coding: utf-8
9779 End:
9780