1 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3 * infcall.c (call_function_by_hand_dummy): Refactor.
5 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
7 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
9 2019-10-23 Tom Tromey <tom@tromey.com>
12 * configure.ac: Don't check for sigprocmask.
13 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
15 2019-10-23 Tom Tromey <tom@tromey.com>
18 * acinclude.m4: Use m4_include, not sinclude.
20 2019-10-23 Tom de Vries <tdevries@suse.de>
23 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
25 2019-10-22 Christian Biesinger <cbiesinger@google.com>
27 * symtab.c (struct demangled_name_entry) <language>: Change from
28 bitfield to regular variable.
30 2019-10-22 Christian Biesinger <cbiesinger@google.com>
32 * symtab.c (struct demangled_name_entry): Add a constructor.
33 (free_demangled_name_entry): New function to call the destructor
34 for demangled_name_entry.
35 (create_demangled_names_hash): Pass free_demangled_name_entry to
37 (symbol_set_names): Call placement new for demangled_name_entry.
38 * utils.c: No longer include xxhash.h here, now that fast_hash
39 is inlined in the header.
40 * utils.h: Instead, include it here.
42 2019-10-22 Christian Biesinger <cbiesinger@google.com>
44 * Makefile.in: Link with libxxhash.
45 * config.in: Regenerate.
46 * configure: Regenerate.
47 * configure.ac: Search for libxxhash.
48 * utils.c (fast_hash): Use xxhash if present.
50 2019-10-22 Christian Biesinger <cbiesinger@google.com>
52 * utils.h (fast_hash): New function.
53 * symtab.c (hash_demangled_name_entry): Call new function
56 2019-10-22 Christian Biesinger <cbiesinger@google.com>
58 * symtab.c (struct demangled_name_entry): Change type of mangled
59 to gdb::string_view. Also adds a constructor that takes the
61 (hash_demangled_name_entry): Update.
62 (eq_demangled_name_entry): Update.
63 (free_demangled_name_entry): New function to call the destructor
64 now that this is not a POD anymore.
65 (create_demangled_names_hash): Pass free_demangled_name_entry to
67 (symbol_set_names): Update.
69 2019-10-21 Ali Tamur <tamu@google.com>
71 * dwarf2read.c (dir_index): Change type.
72 (file_name_index): Likewise.
73 (line_header::include_dir_at): Change comment and implementation on
74 whether it is DWARF 5.
75 (line_header::is_valid_file_index): New function.
76 (line_header::file_name_at): Change comment and implementation on
77 whether it is DWARF 5.
78 (line_header::file_names): Change to private field renamed as
79 m_file_names and introduce a new accessor method.
80 (line_header::file_names_size): New method.
81 (line_header::include_dirs): Change to private field and rename as
83 (dw2_get_file_names_reader): Define local var at a smaller scope and
85 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
86 (process_structure_scope): Likewise.
87 (line_header::add_include_dir): Change message and reflect renaming.
88 (line_header::add_file_name): Likewise.
89 (read_formatted_entries): Handle DW_FORM_data16.
90 (dwarf_decode_line_header): Fix line header length calculation.
91 (psymtab_include_file_name): Change comment and API.
92 (lnp_state_machine::m_file): Update comment and reflect type change.
93 (lnp_state_machine::record_line): Reflect type change.
94 (dwarf_decode_lines): Reflect API change.
95 (file_file_name): Likewise.
96 (file_full_name): Likewise.
98 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
100 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
102 2019-10-21 Tom Tromey <tom@tromey.com>
104 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
106 2019-10-21 Tom Tromey <tom@tromey.com>
108 * configure.ac (nm.h): Conditionally create nm.h link. Subst
109 NM_H. Use AC_CONFIG_LINKS.
110 * configure: Rebuild.
111 * Makefile.in (NM_H): New variable.
112 (generated_files): Add NM_H. Remove gcore.
113 (nm.h, stamp-nmh): New targets.
115 2019-10-20 Tom Tromey <tom@tromey.com>
117 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
118 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
120 (put_objfile_before): Now static.
122 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
124 * gdbsupport/common-utils.h (startswith): Change return type to
127 2019-10-19 Christian Biesinger <cbiesinger@google.com>
129 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
130 * breakpoint.c (bp_locations_compare): Rename to...
131 (bp_location_is_less_than): ...this, and change to std::sort semantics.
132 (update_global_location_list): Use std::sort instead of qsort.
133 * buildsym.c (compare_line_numbers): Rename to...
134 (lte_is_less_than): ...this, and change to std::sort semantics.
135 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
137 * disasm.c (compare_lines): Rename to...
138 (line_is_less_than): ...this, and change to std::sort semantics.
139 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
141 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
142 (fde_is_less_than): ...this, and change to std::sort semantics.
143 (dwarf2_build_frame_info): Call std::sort instead of qsort.
144 * mdebugread.c (compare_blocks):
145 (block_is_less_than): ...this, and change to std::sort semantics.
146 (sort_blocks): Call std::sort instead of qsort.
147 * objfiles.c (qsort_cmp): Rename to...
148 (sort_cmp): ...this, and change to std::sort semantics.
149 (update_section_map): Call std::sort instead of qsort.
150 * remote.c (compare_pnums): Remove.
151 (map_regcache_remote_table): Call std::sort instead of qsort.
152 * utils.c (compare_positive_ints): Remove.
153 * utils.h (compare_positive_ints): Remove.
154 * xcoffread.c (compare_lte): Remove.
155 (arrange_linetable): Call std::sort instead of qsort.
157 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
159 * symfile.c (init_entry_point_info): Fix typo.
160 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
162 2019-10-18 Tom de Vries <tdevries@suse.de>
164 * aarch64-tdep.c: Fix typos in comments.
167 * alpha-tdep.c: Same.
168 * alpha-tdep.h: Same.
170 * amd64-windows-tdep.c: Same.
173 * arch-utils.c: Same.
174 * arm-nbsd-tdep.c: Same.
177 * blockframe.c: Same.
180 * coff-pe-read.c: Same.
183 * darwin-nat.c: Same.
187 * dtrace-probe.c: Same.
188 * dwarf-index-write.c: Same.
189 * dwarf2-frame-tailcall.c: Same.
190 * dwarf2-frame.c: Same.
191 * dwarf2read.c: Same.
193 * exceptions.c: Same.
198 * gnu-v3-abi.c: Same.
200 * h8300-tdep.c: Same.
202 * i386-linux-tdep.c: Same.
204 * ia64-libunwind-tdep.c: Same.
210 * linux-thread-db.c: Same.
212 * mdebugread.c: Same.
214 * mn10300-tdep.c: Same.
217 * opencl-lang.c: Same.
220 * ppc-linux-nat.c: Same.
221 * ppc-linux-tdep.c: Same.
222 * ppc-sysv-tdep.c: Same.
225 * record-btrace.c: Same.
226 * record-full.c: Same.
227 * remote-fileio.c: Same.
229 * rs6000-tdep.c: Same.
231 * score-tdep.c: Same.
235 * sol-thread.c: Same.
236 * solib-svr4.c: Same.
240 * sparc-sol2-tdep.c: Same.
241 * sparc-tdep.c: Same.
242 * sparc64-tdep.c: Same.
247 * target-descriptions.c: Same.
248 * target-float.c: Same.
255 * windows-nat.c: Same.
257 * xstormy16-tdep.c: Same.
258 * xtensa-tdep.c: Same.
260 2019-10-17 Tom Tromey <tromey@adacore.com>
262 * configure: Rebuild.
263 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
264 in AC_CONFIG_FILES invocation.
265 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
266 new-style config.status invocation.
268 2019-10-17 Tom de Vries <tdevries@suse.de>
270 * arm-nbsd-nat.c: Fix typos in comments.
272 * darwin-nat-info.c: Same.
273 * dwarf2read.c: Same.
282 * mdebugread.c: Same.
283 * moxie-tdep.c: Same.
284 * nto-procfs.c: Same.
286 * ppc-linux-tdep.c: Same.
288 * riscv-tdep.c: Same.
291 * sparc-linux-tdep.c: Same.
294 * target-descriptions.c: Same.
298 2019-10-16 Tom Tromey <tom@tromey.com>
300 * objfiles.h (struct objfile) <original_name>: Now const.
302 2019-10-16 Christian Biesinger <cbiesinger@google.com>
304 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
305 pass on to sigsetjmp's second argument.
306 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
308 2019-10-16 Keith Seitz <keiths@redhat.com>
311 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
312 sections whose size is greater than the file size.
314 2019-10-16 Jim Wilson <jimw@sifive.com>
316 * riscv-tdep.c (riscv_gcc_target_options): New.
317 (riscv_gnu_triplet_regexp): New.
318 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
319 set_gdbarch_gnu_triplet_regexp.
321 2019-10-16 Christian Biesinger <cbiesinger@google.com>
323 * Makefile.in: Add xml-builtin.h.
324 * features/feature_to_c.sh: Add an include for xml-builtin.h
325 to ensure that the compiler checks that the types match.
326 * xml-builtin.h: New file.
327 * xml-support.c (fetch_xml_builtin): Add missing const.
328 * xml-support.h: Remove declaration of xml_builtins.
330 2019-10-16 Tom de Vries <tdevries@suse.de>
333 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
334 (amd64_classify_aggregate): ... here.
335 (amd64_classify_aggregate_field): Handled fiels of nested structs
338 2019-10-16 Tom de Vries <tdevries@suse.de>
341 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
342 that handles 'theclass'.
344 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
346 * linespec.c (decode_digits_ordinary): Update comment.
347 * make-target-delegates: No longer need to handle VEC case.
348 * memrange.c (normalize_mem_ranges): Update comment.
349 * namespace.c (add_using_directive): Update comment.
350 * objc-lang.c (uniquify_strings): Update comment.
351 * ppc-linux-nat.c (struct thread_points): Update comment.
352 * probe.h (find_probes_in_objfile): Update comment.
353 * target.h (enum flash_preserve_mode): Update comment.
354 * varobj.c (varobj_restrict_range): Update comment.
355 * varobj.h (varobj_list_children): Update comment.
357 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
359 * Makefile.in: Remove references to vec.h and vec.c.
360 * aarch64-tdep.c: No longer include vec.h.
361 * ada-lang.c: Likewise.
362 * ada-lang.h: Likewise.
363 * arm-tdep.c: Likewise.
365 * breakpoint.h: Likewise.
366 * charset.c: Likewise.
367 * cp-support.h: Likewise.
368 * dtrace-probe.c: Likewise.
369 * dwarf2read.c: Likewise.
370 * extension.h: Likewise.
371 * gdb_bfd.c: Likewise.
372 * gdbsupport/gdb_vecs.h: Likewise.
373 * gdbsupport/vec.c: Remove.
374 * gdbsupport/vec.h: Remove.
375 * gdbthread.h: Likewise.
376 * guile/scm-type.c: Likewise.
377 * inline-frame.c: Likewise.
378 * machoread.c: Likewise.
379 * memattr.c: Likewise.
380 * memrange.h: Likewise.
381 * namespace.h: Likewise.
382 * nat/linux-btrace.h: Likewise.
383 * osdata.c: Likewise.
384 * parser-defs.h: Likewise.
385 * progspace.h: Likewise.
386 * python/py-type.c: Likewise.
387 * record-btrace.c: Likewise.
388 * rust-exp.y: Likewise.
389 * solib-target.c: Likewise.
390 * stap-probe.c: Likewise.
391 * target-descriptions.c: Likewise.
392 * target-memory.c: Likewise.
393 * target.h: Likewise.
394 * varobj.c: Likewise.
395 * varobj.h: Likewise.
396 * xml-support.h: Likewise.
398 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
400 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
401 Update for new std::vector based implementation.
402 (process_psymtab_comp_unit_reader): Likewise.
403 (scan_partial_symbols): Likewise.
404 (recursively_compute_inclusions): Likewise.
405 (compute_compunit_symtab_includes): Likewise.
406 (process_imported_unit_die): Likewise.
407 (queue_and_load_dwo_tu): Likewise.
408 (follow_die_sig_1): Likewise.
409 * gdb/dwarf2read.h: Remove DEF_VEC_P.
410 (typedef dwarf2_per_cu_ptr): Remove.
411 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
413 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
414 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
415 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
416 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
419 2019-10-15 Tom Tromey <tromey@adacore.com>
421 * windows-nat.c (windows_nat_target::resume): Use %x when logging
424 2019-10-15 Tom Tromey <tromey@adacore.com>
426 * windows-nat.c (windows_nat_target::fetch_registers)
427 (windows_nat_target::store_registers): Rename "pid" to "tid".
429 2019-10-15 Tom Tromey <tromey@adacore.com>
431 * gdbarch.h, gdbarch.c: Rebuild.
432 * gdbarch.sh (gcc_target_options): Change return type to
434 * compile/compile.c (get_args): Update.
435 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
436 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
438 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
440 * arch-utils.c (default_gcc_target_options): Return std::string.
441 * arch-utils.h (default_gcc_target_options): Return std::string.
442 * s390-tdep.c (s390_gcc_target_options): Return std::string.
444 2019-10-15 Christian Biesinger <cbiesinger@google.com>
446 * breakpoint.c (breakpoint_chain): Make static.
447 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
448 of accessing breakpoint_chain.
450 2019-10-15 Christian Biesinger <cbiesinger@google.com>
452 * breakpoint.c (iterate_over_breakpoints): Change function pointer
453 to a gdb::function_view and return value to bool.
454 * breakpoint.h (iterate_over_breakpoints): Likewise.
455 * dummy-frame.c (pop_dummy_frame_bpt): Update.
456 (pop_dummy_frame): Update.
457 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
458 (gdbscm_breakpoints): Update.
459 * python/py-breakpoint.c (build_bp_list): Update.
460 (gdbpy_breakpoints): Update.
461 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
463 (bpfinishpy_handle_stop): Update.
464 (bpfinishpy_handle_exit): Update.
465 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
466 (svr4_update_solib_event_breakpoints): Update.
468 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
470 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
471 when unwrapping single-field structs.
473 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
475 * dwarf2read.c: Remove includes.
477 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
479 * ui-out.c (ui_out::call_do_message): Silence
480 -Wformat-nonliteral warning.
482 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
484 * breakpoint.c: Remove some includes: continuations.h, skip.h,
485 mi/mi-main.h, readline/readline.h, readline/history.h. Add
486 include: readline/tilde.h.
488 2019-10-12 Christian Biesinger <cbiesinger@google.com>
490 * remote.c (remote_target::get_trace_status): Remove declaration of
493 2019-10-12 Christian Biesinger <cbiesinger@google.com>
495 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
496 (show_user): Remove declaration of cmdlist.
497 * cli/cli-cmds.h (max_user_call_depth): Declare.
498 * cli/cli-script.c (execute_user_command): Remove declaration
499 of max_user_call_depth.
501 2019-10-11 Jim Wilson <jimw@sifive.com>
503 * gdbsupport/print-utils.h (pulongest): Fix comment.
504 (plongest): Likewise.
505 (phex): Add missing comment, mention leading zeros.
506 (phex_nz): Add mention of no leading zeros to comment.
508 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
509 plongest instead of unsigned long long cast.
511 2019-10-10 Christian Biesinger <cbiesinger@google.com>
513 * main.c (captured_main_1): Include gdbtk.h and remove declarations
514 for external_editor_command and gdbtk_test.
516 2019-10-10 Christian Biesinger <cbiesinger@google.com>
518 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
519 * varobj.c (varobjdebug): Move comment to...
520 * varobj.h (varobjdebug): ...here, and declare.
522 2019-10-09 Tom Tromey <tom@tromey.com>
524 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
527 2019-10-09 Tom Tromey <tom@tromey.com>
529 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
530 * tui/tui-stack.c (tui_locator_window::rerender): Update.
531 * tui/tui-command.c (tui_cmd_window::resize)
532 (tui_refresh_cmd_win): Update.
533 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
534 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
535 * tui/tui-data.c (~tui_gen_win_info): Remove.
536 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
537 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
538 (tui_redisplay_readline, tui_mld_flush)
539 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
540 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
541 (tui_data_window::erase_data_content)
542 (tui_data_item_window::rerender)
543 (tui_data_item_window::refresh_window): Update.
544 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
545 (box_win, tui_gen_win_info::make_window)
546 (tui_gen_win_info::make_visible): Update.
547 (tui_delete_win): Remove.
548 * tui/tui-winsource.c
549 (tui_source_window_base::do_erase_source_content): Update.
550 (tui_show_source_line, tui_source_window_base::update_tab_width)
551 (tui_source_window_base::update_exec_info): Update.
552 * tui/tui-data.h (struct curses_deleter): New.
553 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
554 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
556 2019-10-09 Tom Tromey <tom@tromey.com>
558 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
560 2019-10-09 Tom Tromey <tom@tromey.com>
562 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
563 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
565 2019-10-09 Tom Tromey <tom@tromey.com>
567 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
568 window height directly.
569 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
571 * tui/tui-layout.c (tui_default_win_height): Remove.
572 (tui_default_win_viewport_height): Remove.
574 2019-10-09 Tom Tromey <tom@tromey.com>
576 * tui/tui.h: Remove comments.
578 2019-10-09 Tom de Vries <tdevries@suse.de>
580 * python/lib/gdb/printer/bound_registers.py: Use
581 '^builtin_type_bound128' as regexp argument for
582 add_builtin_pretty_printer.
584 2019-10-09 Christian Biesinger <cbiesinger@google.com>
586 * guile/guile.c (guile_extension_script_ops): Remove forward
587 declaration and mark as static.
588 (guile_script_ops): Likewise.
589 (extension_language_guile): Move further down in the file so
590 it can reference the definitions for guile_{extension_,}script_ops.
592 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
594 * s390-tdep.c (390_process_record): Handle new arch13 instructions
595 except SORTL, DFLTCC, and KDSA.
597 2019-10-08 Tom Tromey <tromey@adacore.com>
599 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
600 (struct safe_symbol_file_add_args): Remove.
602 2019-10-08 Tom Tromey <tromey@adacore.com>
604 * windows-nat.c: Don't include buildsym-legacy.h.
606 2019-10-08 Tom Tromey <tromey@adacore.com>
608 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
610 2019-10-08 Christian Biesinger <cbiesinger@google.com>
612 * gdbtypes.c (overload_debug): Move comment to header.
613 * gdbtypes.h (overload_debug): Declare.
614 * valops.c: Remove declaration of overload_debug, instead
617 2019-10-08 Christian Biesinger <cbiesinger@google.com>
619 * language.c (show_language_command): Pass lang_frame_mismatch_warn
621 (lang_frame_mismatch_warn): Make const, mark with N_(), and
623 * language.h (lang_frame_mismatch_warn): ... here. Also add
625 * top.c (lang_frame_mismatch_warn): Remove declaration.
626 (check_frame_language_change): Pass lang_frame_mismatch_warn
629 2019-10-07 Christian Biesinger <cbiesinger@google.com>
631 * c-lang.h (vtbl_ptr_name): Declare.
632 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
634 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
636 2019-10-07 Christian Biesinger <cbiesinger@google.com>
638 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
641 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
643 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
644 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
645 * ctfread.c: New file.
646 * ctfread.h: New file.
647 * elfread.c: Include ctfread.h.
648 (struct elfinfo text_p): New member ctfsect.
649 (elf_locate_sections): Mark CTF section.
650 (elf_symfile_read): Call elfctf_build_psymtabs.
651 * Makefile.in (LIBCTF): Add.
654 (DIST): Add ctfread.c.
656 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
658 * ctfread.c (struct nextfield): Renamed to ...
659 (struct ctf_nextfield): ... this.
660 (struct field_info): Renamed to ...
661 (strut ctf_field_info): ... this.
662 (attach_fields_to_type): Update for renamed structures.
663 (ctf_add_member_cb): Likewise.
664 (ctf_add_enum_member_cb): Likewise.
665 (process_struct_members): Likewise.
666 (process_enum_type): Likewise.
668 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
670 * tracectf.h: Rename, was ctf.h.
671 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
672 * tracefile.c: Likewise.
673 * tracepoint.c: Remove unused include ctf.h.
674 * mi/mi-main.c: Likewise.
675 * Makefile.in Replace ctf.c with tracectf.c.
677 2019-10-06 Joel Brobecker <brobecker@adacore.com>
679 * version.in: Change version number to "9.0.50.DATE-git".
681 2019-10-03 Tom Tromey <tom@tromey.com>
684 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
686 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
688 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
690 * NEWS: Add entry about nested function support.
692 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
693 Andrew Burgess <andrew.burgess@embecosm.com>
695 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
696 for nested static variables when searchin VAR_DOMAIN.
697 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
698 global scope, update comment.
699 (add_partial_subprogram): Call add_partial_subprogram recursively
700 for nested subroutines when processinng Fortran.
701 (load_partial_dies): Process the child entities of a subprogram
702 when processing Fortran.
703 (partial_die_parent_scope): Handle building scope
704 for Fortran nested functions.
705 (process_die): Record that nested functions have a scope.
706 (new_symbol): Always record Fortran subprograms on the global
708 (determine_prefix): How to build the prefix for Fortran
711 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
713 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
714 have just sent the thread a SIGSTOP and are waiting for it to
717 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
719 * btrace.c (btrace_add_pc): Remove whitespace before the template
720 parameter in 'std::vector <...>'.
721 (parse_xml_btrace_block): Likewise.
722 (btrace_maint_decode_pt): Likewise.
723 (btrace_maint_update_packets): Likewise.
724 (btrace_maint_print_packets): Likewise.
725 * btrace.h (struct btrace_maint_info): Likewise.
726 * dwarf2read.c (struct type_unit_group): Likewise.
727 (build_type_psymtabs_reader): Likewise.
728 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
729 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
730 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
732 2019-10-03 Tom de Vries <tdevries@suse.de>
734 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
735 the first line of the help text for set/show style metadata.
737 2019-10-02 Tom Tromey <tromey@adacore.com>
739 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
740 * gdbsupport/common-inferior.c: New file.
741 * infcmd.c (startup_with_shell): Don't define.
742 * nat/fork-inferior.h (startup_with_shell): Don't declare.
743 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
744 * inferior.h (startup_with_shell): Don't declare.
746 2019-10-02 Christian Biesinger <cbiesinger@google.com>
748 * gdbsupport/gdb_assert.h: Include errors.h.
749 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
751 2019-10-02 Tom Tromey <tromey@adacore.com>
753 * NEWS: Add $_ada_exception entry.
754 * ada-lang.c (struct ada_catchpoint): Add constructor.
755 <m_kind>: New member.
756 (allocate_location_exception, re_set_exception): Remove
758 (should_stop_exception): Compute $_ada_exception.
759 (check_status_exception, print_it_exception)
760 (print_one_exception, print_mention_exception): Remove
762 (allocate_location_catch_exception, re_set_catch_exception)
763 (check_status_exception, print_it_catch_exception)
764 (print_one_catch_exception, print_mention_catch_exception)
765 (print_recreate_catch_exception)
766 (allocate_location_catch_exception_unhandled)
767 (re_set_catch_exception_unhandled)
768 (check_status_exception, print_it_catch_exception_unhandled)
769 (print_one_catch_exception_unhandled)
770 (print_mention_catch_exception_unhandled)
771 (print_recreate_catch_exception_unhandled)
772 (allocate_location_catch_assert, re_set_catch_assert)
773 (check_status_assert, print_it_catch_assert)
774 (print_one_catch_assert, print_mention_catch_assert)
775 (print_recreate_catch_assert)
776 (allocate_location_catch_handlers, re_set_catch_handlers)
777 (check_status_handlers, print_it_catch_handlers)
778 (print_one_catch_handlers, print_mention_catch_handlers)
779 (print_recreate_catch_handlers): Remove.
780 (create_ada_exception_catchpoint): Update.
781 (initialize_ada_catchpoint_ops): Update.
783 2019-10-02 Tom Tromey <tromey@adacore.com>
785 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
786 (create_excep_cond_exprs): Simplify exception string computation.
787 (ada_exception_catchpoint_cond_string): Likewise.
789 2019-10-02 Tom Tromey <tromey@adacore.com>
791 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
792 * ada-lang.c (lesseq_defined_than): Handle
794 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
796 (dwarf2_has_info): Likewise.
797 (new_symbol): Set maybe_copied on symbol when
799 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
801 <can_copy>: New member.
802 * elfread.c (record_minimal_symbol): Set maybe_copied
803 on symbol when appropriate.
804 (elf_symfile_read): Update call to dwarf2_has_info.
805 * minsyms.c (lookup_minimal_symbol_linkage): New
807 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
808 * symtab.c (get_symbol_address, get_msymbol_address):
810 * symtab.h (get_symbol_address, get_msymbol_address):
812 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
814 (struct symbol, struct minimal_symbol) <maybe_copied>:
817 2019-10-02 Tom Tromey <tromey@adacore.com>
819 * source.c (struct current_source_location): New.
820 (current_source_key): New global.
821 (current_source_symtab, current_source_line)
822 (current_source_pspace): Remove.
823 (get_source_location): New function.
824 (get_current_source_symtab_and_line)
825 (set_default_source_symtab_and_line)
826 (set_current_source_symtab_and_line)
827 (clear_current_source_symtab_and_line, select_source_symtab)
828 (info_source_command, print_source_lines_base)
829 (info_line_command, search_command_helper, _initialize_source):
832 2019-10-02 Tom Tromey <tromey@adacore.com>
834 * source.c (select_source_symtab): Don't call
835 decode_line_with_current_source.
837 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
839 * symtab.c (lookup_global_symbol): Search global block.
841 2019-10-02 Tom Tromey <tromey@adacore.com>
843 * coffread.c (process_coff_symbol): Update.
844 * dwarf2read.c (var_decode_location, new_symbol): Update.
845 * mdebugread.c (parse_symbol): Update.
846 * objfiles.c (relocate_one_symbol): Update.
847 * stabsread.c (define_symbol, fix_common_block)
848 (scan_file_globals): Update.
849 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
850 (SET_SYMBOL_VALUE_ADDRESS): New macro.
851 * xcoffread.c (process_xcoff_symbol): Update.
853 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
855 * MAINTAINERS: Update my email address.
857 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
859 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
861 (build_type_psymtabs_reader): Update for std::vector.
862 (build_type_psymtab_dependencies): Likewise.
863 * dwarf2read.h: Remove use of DEF_VEC_P.
864 (typedef sig_type_ptr): Delete.
866 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
868 * btrace.c (btrace_maint_clear): Update to handle change from VEC
870 (btrace_maint_decode_pt): Likewise, and move allocation of the
871 vector outside of the loop.
872 (btrace_maint_update_packets): Update to handle change from VEC to
874 (btrace_maint_print_packets): Likewise.
875 (maint_info_btrace_cmd): Likewise.
876 * btrace.h: Remove use of DEF_VEC_O.
877 (typedef btrace_pt_packet_s): Delete.
878 (struct btrace_maint_info) <packets>: Change fromm VEC to
880 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
882 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
884 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
885 make accesses into the vector constant references.
886 (btrace_add_pc): Update for std::vector.
887 (btrace_stitch_bts): Likewise.
888 (parse_xml_btrace_block): Likewise.
889 (btrace_maint_update_packets): Likewise.
890 (btrace_maint_print_packets): Likewise.
891 (maint_info_btrace_cmd): Likewise.
892 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
894 (btrace_data::empty): Likewise.
895 (btrace_data_append): Likewise.
896 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
897 (typedef btrace_block_s): Delete.
898 (struct btrace_block): Add constructor.
899 (struct btrace_data_bts) <blocks>: Change to std::vector.
900 * nat/linux-btrace.c (perf_event_read_bts): Update for
902 (linux_read_bts): Likewise.
904 2019-10-01 Tom Tromey <tom@tromey.com>
906 * cli/cli-logging.c (show_logging_filename): Use styled_string.
908 2019-10-01 Tom Tromey <tom@tromey.com>
910 * stack.c (print_frame, info_frame_command_core): Use
912 * linux-thread-db.c (try_thread_db_load_1)
913 (try_thread_db_load_from_pdir_1): Use styled_string.
914 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
915 (auto_load_section_scripts, info_auto_load_local_gdbinit)
916 (maybe_print_unsupported_script_warning)
917 (maybe_print_script_not_found_warning): Use styled_string.
918 * ada-lang.c (user_select_syms): Use styled_string.
920 2019-10-01 Tom Tromey <tom@tromey.com>
922 * p-lang.c (pascal_printstr): Use metadata style.
923 * value.c (show_convenience): Use metadata style.
924 * valprint.c (valprint_check_validity, val_print_optimized_out)
925 (val_print_not_saved, val_print_unavailable)
926 (val_print_invalid_address, generic_val_print, val_print)
927 (value_check_printable, val_print_array_elements): Use metadata
929 * ui-out.h (class ui_out) <field_fmt>: New overload.
930 <do_field_fmt>: Add style parameter.
931 * ui-out.c (ui_out::field_fmt): New overload.
932 * typeprint.c (type_print_unknown_return_type)
933 (val_print_not_allocated, val_print_not_associated): Use metadata
935 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
937 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
938 * tracepoint.c (tvariables_info_1): Use metadata style.
939 * stack.c (print_frame_arg, print_frame_info, print_frame)
940 (info_frame_command_core): Use metadata style.
941 * skip.c (info_skip_command): Use metadata style.
942 * rust-lang.c (rust_print_enum): Use metadata style.
943 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
945 * python/py-framefilter.c (py_print_single_arg): Use metadata
947 * printcmd.c (do_one_display, print_variable_and_value): Use
949 * p-valprint.c (pascal_val_print)
950 (pascal_object_print_value_fields): Use metadata style.
951 * p-typeprint.c (pascal_type_print_base): Use metadata style.
952 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
954 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
955 * m2-valprint.c (m2_print_long_set): Use metadata style.
956 * m2-typeprint.c (m2_print_type): Use metadata style.
957 * infcmd.c (print_return_value_1): Use metadata style.
958 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
959 * f-valprint.c (info_common_command_for_block): Use metadata
961 * f-typeprint.c (f_type_print_base): Use metadata style.
962 * expprint.c (print_subexp_standard): Use metadata style.
963 * cp-valprint.c (cp_print_value_fields): Use metadata style.
964 * cli/cli-style.h (class cli_style_option): Add constructor.
965 (metadata_style): Declare.
966 * cli/cli-style.c (metadata_style): New global.
967 (_initialize_cli_style): Register metadata style.
968 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
970 * cli-out.c (cli_ui_out::do_field_fmt): Update.
971 * c-typeprint.c (c_type_print_base_struct_union)
972 (c_type_print_base_1): Use metadata style.
973 * breakpoint.c (watchpoint_value_print)
974 (print_one_breakpoint_location): Use metadata style.
975 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
977 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
979 * ada-valprint.c (val_print_packed_array_elements, printstr)
980 (print_field_values, ada_val_print_ref, ada_val_print): Use
982 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
984 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
986 * ada-lang.c (user_select_syms): Use metadata style.
988 2019-10-01 Tom Tromey <tom@tromey.com>
990 * cli/cli-cmds.c (pwd_command): Style output.
992 2019-10-01 Pedro Alves <palves@redhat.com>
993 Tom Tromey <tom@tromey.com>
995 * symtab.c (print_symbol_info): Use %ps.
996 (print_msymbol_info): Use %ps.
997 * symfile.c (symbol_file_add_with_addrs): Use %ps.
998 * printcmd.c (print_variable_and_value): Use %ps.
999 * macrocmd.c (show_pp_source_pos): Use %ps.
1000 * infrun.c (print_exited_reason): Use ui_out::message.
1001 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1002 (describe_other_breakpoints): Use ui_out::message and new
1004 (say_where): Use new formats.
1005 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1008 2019-10-01 Pedro Alves <palves@redhat.com>
1009 Tom Tromey <tom@tromey.com>
1011 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1012 (test_gdb_formats): New function.
1013 (run_tests): Call it.
1014 (test_format_specifier): Update.
1015 * utils.h (fputs_filtered): Update comment.
1016 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1017 (fputs_styled_unfiltered): Declare.
1018 * utils.c (fputs_styled_unfiltered): New function.
1019 (vfprintf_maybe_filtered): Add gdbfmt parameter.
1020 (vfprintf_filtered): Update.
1021 (vfprintf_unfiltered, vprintf_filtered): Update.
1022 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1023 * ui-out.h (enum ui_out_flag) <unfiltered_output,
1024 disallow_ui_out_field>: New constants.
1025 (enum class field_kind): New.
1026 (struct base_field_s, struct signed_field_s): New.
1027 (signed_field): New function.
1028 (struct string_field_s): New.
1029 (string_field): New function.
1030 (struct styled_string_s): New.
1031 (styled_string): New function.
1032 (class ui_out) <message>: Add comment.
1033 <vmessage, call_do_message>: New methods.
1034 <do_message>: Add style parameter.
1035 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1037 (ui_out::message): Rewrite.
1038 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1040 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1041 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1042 gdb_extensions parameter.
1043 (class format_piece): Add parameter to constructor.
1044 (n_int_args): New field.
1045 * gdbsupport/format.c (format_pieces::format_pieces): Add
1046 gdb_extensions parameter. Handle '*'.
1047 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1048 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
1049 vfprintf_styled_no_gdbfmt.
1050 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1051 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1053 * ui-style.h (struct ui_file_style) <ptr>: New method.
1055 2019-10-01 Tom Tromey <tom@tromey.com>
1057 * unittests/format_pieces-selftests.c: Update. Add final format.
1058 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1059 empty literal pieces.
1061 2019-10-01 Tom Tromey <tom@tromey.com>
1063 * ui-out.h (enum class ui_out_style_kind): Remove.
1064 (class ui_out) <field_string, field_stsream, do_field_string>:
1065 Change type of "style".
1066 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1067 (ui_out::field_string): Update.
1068 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1070 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1071 * tracepoint.c (print_one_static_tracepoint_marker): Update.
1072 * stack.c (print_frame_arg, print_frame_info, print_frame):
1074 * source.c (print_source_lines_base): Update.
1075 * solib.c (info_sharedlibrary_command): Update.
1076 * skip.c (info_skip_command): Update.
1077 * record-btrace.c (btrace_call_history_src_line)
1078 (btrace_call_history): Update.
1079 * python/py-framefilter.c (py_print_frame): Update.
1080 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1082 * mi/mi-out.c (mi_ui_out::do_table_header)
1083 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1084 (mi_ui_out::do_field_string): Update.
1085 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1087 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1089 * cli-out.c (cli_ui_out::do_table_header)
1090 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1091 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1092 (cli_ui_out::do_field_fmt): Update.
1093 * breakpoint.c (print_breakpoint_location): Update.
1094 (update_static_tracepoint): Update.
1096 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1098 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1099 conversion of gdb_datadir.
1100 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1101 remove not needed c_str ().
1103 2019-09-30 Ali Tamur <tamur@google.com>
1105 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1106 (dwarf2_string_attr): Likewise.
1108 2019-09-30 Ali Tamur <tamur@google.com>
1110 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1111 (process_full_type_unit): Likewise.
1112 (dump_die_shallow): Likewise.
1113 (cu_debug_loc_section): Likewise.
1115 2019-09-28 Christian Biesinger <cbiesinger@google.com>
1117 * minsyms.c (compare_minimal_symbols): Rename to...
1118 (minimal_symbol_is_less_than): ...this, and adjust to STL
1119 conventions (return bool, take arguments as references)
1120 (minimal_symbol_reader::install): Call std::sort instead
1123 2019-09-29 Christian Biesinger <cbiesinger@google.com>
1125 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1127 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1128 msymbol_hash, msymbol_demangled_hash>: Improve comments.
1130 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
1132 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1133 * psympriv.h (add_psymbol_to_list): Move comment here and update
1136 2019-09-29 Tom de Vries <tdevries@suse.de>
1138 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1139 Use $tmpdir/$(basename "$output_file").dwz instead of
1140 "${output_file}.dwz".
1142 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
1145 * hppa-linux-nat.c: Include gdbarch.h.
1147 2019-09-26 Christian Biesinger <cbiesinger@google.com>
1149 * blockframe.c (find_pc_partial_function): Change return type to bool.
1150 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1151 * minsyms.c (in_gnu_ifunc_stub): Likewise.
1152 (stub_gnu_ifunc_resolve_name): Likewise.
1153 * symtab.c (compare_filenames_for_search): Likewise.
1154 (compare_glob_filenames_for_search): Likewise.
1155 (matching_obj_sections): Likewise.
1156 (symbol_matches_domain): Likewise.
1157 (find_line_symtab): Change out param EXACT_MATCH to bool *.
1158 (find_line_pc): Change return type to bool.
1159 (find_line_pc_range): Likewise.
1160 (producer_is_realview): Likewise.
1161 * symtab.h (symbol_matches_domain): Likewise.
1162 (find_pc_partial_function): Likewise.
1163 (find_pc_line_pc_range): Likewise.
1164 (in_gnu_ifunc_stub): Likewise.
1165 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1166 (find_line_pc): Likewise.
1167 (find_line_pc_range): Likewise.
1168 (matching_obj_sections): Likewise.
1169 (find_line_symtab): Change out parameter to bool.
1170 (producer_is_realview): Change return type to bool.
1171 (compare_filenames_for_search): Likewise.
1172 (compare_glob_filenames_for_search): Likewise.
1174 2019-09-26 Tom Tromey <tom@tromey.com>
1176 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1177 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1178 * gdb_usleep.h: Remove.
1179 * gdb_usleep.c: Remove.
1180 * utils.c: Don't include gdb_usleep.h.
1182 2019-09-26 Tom Tromey <tromey@adacore.com>
1184 * python/py-type.c (type_to_type_object): Call check_typedef
1187 2019-09-26 Tom Tromey <tom@tromey.com>
1189 * utils.h (initialize_utils): Don't declare.
1190 * top.c (gdb_init): Don't call initialize_utils.
1191 * utils.c (initialize_utils): Remove. Move contents...
1192 (_initialize_utils): ... here.
1194 2019-09-25 Tom Tromey <tom@tromey.com>
1196 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1197 * utils.h (make_hex_string): Don't declare.
1198 * utils.c (make_hex_string): Remove.
1200 2019-09-24 Tom de Vries <tdevries@suse.de>
1203 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1204 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1206 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
1208 * NEWS: Mention new simulator port for PRU.
1210 2019-09-23 Christian Biesinger <cbiesinger@google.com>
1212 * ada-exp.y (write_object_remaining): Update.
1213 * ada-lang.c (ada_decode): Return a std::string instead of a char*
1214 and eliminate the static buffer.
1215 (ada_decode_symbol): Update.
1216 (ada_la_decode): Update.
1217 (ada_sniff_from_mangled_name): Update.
1218 (is_valid_name_for_wild_match): Update.
1219 (ada_lookup_name_info::matches): Update and simplify.
1220 (name_matches_regex): Update.
1221 (ada_add_global_exceptions): Update.
1222 * ada-lang.h (ada_decode): Update signature.
1223 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1224 * dwarf-index-write.c (debug_names::insert): Update.
1226 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
1228 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1231 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
1233 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1234 Change "nonzero" to "true" in documentation.
1236 2019-09-20 Christian Biesinger <cbiesinger@google.com>
1238 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1239 (_initialize_darwin_solib): Don't set
1240 darwin_so_ops.lookup_lib_global_symbol.
1241 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1242 set_gdbarch_iterate_over_objfiles_in_search_order.
1243 (elf_lookup_lib_symbol): Rename to...
1244 (svr4_iterate_over_objfiles_in_search_order): this, and update
1245 to iterate semantics.
1246 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1247 * solib.c (solib_global_lookup): Remove.
1248 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1249 (solib_global_lookup): Remove.
1250 * symtab.c (lookup_global_or_static_symbol): Remove call to
1251 solib_global_lookup.
1253 2019-09-20 Joel Brobecker <brobecker@adacore.com>
1255 * NEWS: Move entries about default MI version now being
1256 version 3, and about the GDB/MI fix for multi-location
1257 breakpoints to the "since GDB 8.3" section.
1259 2019-09-20 Joel Brobecker <brobecker@adacore.com>
1263 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
1265 * NEWS: Mention that Cell/B.E. debugging support was removed.
1266 * MAINTAINERS: Remove spu target.
1268 * config/djgpp/fnchange.lst: Remove entries for removed files.
1270 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1271 spu-multiarch.o, and spu-tdep.o.
1272 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1273 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1274 spu-multiarch.c, and spu-tdep.c.
1275 * spu-linux-nat.c: Remove file.
1276 * spu-multiarch.c: Remove file.
1277 * spu-tdep.c: Remove file.
1278 * spu-tdep.h: Remove file.
1279 * solib-spu.c: Remove file.
1280 * solib-spu.h: Remove file.
1282 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1283 * configure.nat (spu-linux): Remove.
1284 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1285 solib-multiarch.o from gdb_target_obs.
1288 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1290 (ppc_linux_no_features): Update.
1291 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1293 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1294 (tdesc_powerpc_cell64l): Likewise.
1295 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1296 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1298 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1299 Do not include "features/rs6000/powerpc-cell32l.c" or
1300 "features/rs6000/powerpc-cell64l.c".
1301 (ppc_linux_spu_section): Remove.
1302 (ppc_linux_core_read_description): Remove Cell/B.E. support.
1303 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1304 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1305 (ppc_linux_spe_context_lookup): Remove.
1306 (ppc_linux_spe_context_inferior_created): Remove.
1307 (ppc_linux_spe_context_solib_loaded): Remove.
1308 (ppc_linux_spe_context_solib_unloaded): Remove.
1309 (ppc_linux_spe_context): Remove.
1310 (struct ppu2spu_cache): Remove.
1311 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1312 (struct ppu2spu_data): Remove.
1313 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1314 ppu2spu_unwind): Remove.
1315 (ppc_linux_init_abi): Remove Cell/B.E. support.
1316 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1318 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1319 (rs6000/powerpc-cell64l-expedite): Likewise
1320 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1321 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1322 rs6000/powerpc-cell64l.xml.
1323 * features/rs6000/powerpc-cell32l.xml: Remove.
1324 * features/rs6000/powerpc-cell64l.xml: Likewise.
1325 * features/rs6000/powerpc-cell32l.c: Remove generated file.
1326 * features/rs6000/powerpc-cell64l.c: Likewise.
1327 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1328 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1329 * regformats/reg-spu.dat: Remove.
1331 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1332 * corelow.c (struct spuid_list): Remove.
1333 (add_to_spuid_list): Remove.
1334 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1335 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1336 (remote_protocol_features): Remove associated entries.
1337 (_initialize_remote): No longer initialize them.
1338 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1339 * linux-nat.c (SPUFS_MAGIC): Remove.
1340 (linux_proc_xfer_spu): Remove.
1341 (spu_enumerate_spu_ids): Remove.
1342 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1343 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1344 (linux_make_corefile_notes): No longer call it.
1346 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1347 (cooked_write_test): Likewise.
1349 2019-09-20 Tom Tromey <tom@tromey.com>
1351 * NEWS: Mention case-sensitivity of TUI commands.
1352 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1353 (tui_set_win_height_command, parse_scrolling_args): Likewise.
1354 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1356 2019-09-20 Tom Tromey <tom@tromey.com>
1358 * tui/tui-source.c (tui_source_window::set_contents): Use
1359 make_unique_xstrdup.
1360 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1361 make_unique_xstrdup.
1363 2019-09-20 Tom Tromey <tom@tromey.com>
1365 * tui/tui-data.c: Remove separator comments.
1366 * tui/tui-layout.c: Remove separator comments.
1367 * tui/tui-win.c: Remove separator comments.
1368 * tui/tui-wingeneral.c: Remove separator comments.
1370 2019-09-20 Tom Tromey <tom@tromey.com>
1372 * tui/tui.h (strcat_to_buf): Don't declare.
1373 * tui/tui.c (strcat_to_buf): Remove.
1375 2019-09-20 Tom Tromey <tom@tromey.com>
1377 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1379 * tui/tui-source.c (tui_source_window::set_contents)
1380 (tui_source_window::location_matches_p)
1381 (tui_source_window::maybe_update): Update.
1383 2019-09-20 Tom Tromey <tom@tromey.com>
1385 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1387 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1389 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1390 (tui_data_window::line_from_reg_element_no)
1391 (tui_data_window::first_reg_element_no_inline)
1392 (tui_data_window::show_registers)
1393 (tui_data_window::show_register_group)
1394 (tui_data_window::display_registers_from)
1395 (tui_data_window::display_registers_from_line)
1396 (tui_data_window::first_data_item_displayed)
1397 (tui_data_window::delete_data_content_windows)
1398 (tui_data_window::erase_data_content)
1399 (tui_data_window::do_scroll_vertical)
1400 (tui_data_window::refresh_window)
1401 (tui_data_window::check_register_values): Update.
1403 2019-09-20 Tom Tromey <tom@tromey.com>
1405 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1406 (struct tui_locator_window) <full_name, proc_name>: Now
1408 * tui/tui-stack.c (tui_locator_window::make_status_line)
1409 (tui_locator_window::set_locator_fullname)
1410 (tui_locator_window::set_locator_info): Update.
1411 * tui/tui-source.c (tui_source_window::set_contents)
1412 (tui_source_window::showing_source_p): Update.
1414 2019-09-20 Tom Tromey <tom@tromey.com>
1416 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1417 Don't call tui_locator_win_info_ptr.
1419 2019-09-20 Tom Tromey <tom@tromey.com>
1421 * tui/tui-win.c (tui_resize_all): Don't call refresh.
1423 2019-09-20 Tom Tromey <tom@tromey.com>
1425 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1427 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1428 * tui/tui-layout.c (show_source_disasm_command, show_data)
1429 (show_source_or_disasm_and_command): Use 1 as height for locator.
1431 2019-09-20 Tom Tromey <tom@tromey.com>
1433 * tui/tui.c (tui_enable): Update.
1434 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1436 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1438 * tui/tui-data.c (win_resized): Now bool.
1439 (tui_win_resized): Return bool.
1440 (tui_set_win_resized_to): Accept a bool.
1442 2019-09-20 Tom Tromey <tom@tromey.com>
1444 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1445 Change type of "refresh_values_only".
1446 * tui/tui-regs.c (tui_data_window::show_register_group): Change
1447 type of "refresh_values_only".
1449 2019-09-20 Tom Tromey <tom@tromey.com>
1451 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1453 (tui_disassemble): Add "pos" parameter.
1454 (tui_disasm_window::set_contents): Simplify.
1456 2019-09-20 Tom Tromey <tom@tromey.com>
1458 * tui/tui-winsource.h (struct tui_source_window_base)
1459 <show_source_content>: Now private.
1460 * tui/tui-winsource.c
1461 (tui_source_window_base::show_source_content): Don't handle empty
1464 2019-09-20 Tom Tromey <tom@tromey.com>
1466 * tui/tui-layout.c (show_source_disasm_command)
1467 (show_source_or_disasm_and_command): Don't call
1468 show_source_content.
1470 2019-09-20 Tom Tromey <tom@tromey.com>
1472 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1474 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1475 from tui_make_status_line.
1476 (tui_locator_window::rerender): Update.
1478 2019-09-20 Tom Tromey <tom@tromey.com>
1480 * tui/tui-stack.c (tui_make_status_line): Return std::string.
1481 (tui_locator_window::rerender): Update.
1483 2019-09-20 Tom Tromey <tom@tromey.com>
1485 * tui/tui-winsource.h (struct tui_source_window_base)
1486 <~tui_source_window_base>: Don't declare.
1488 * tui/tui-winsource.c (~tui_source_window_base): Remove.
1489 * tui/tui-source.h (struct tui_source_window) <fullname>: New
1491 * tui/tui-source.c (tui_source_window::set_contents): Update.
1492 (tui_source_window::location_matches_p)
1493 (tui_source_window::maybe_update): Update.
1495 2019-09-20 Tom Tromey <tom@tromey.com>
1497 * tui/tui-winsource.h (~tui_source_element): Remove.
1498 (tui_source_element): Update.
1499 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1500 * tui/tui-winsource.c (tui_show_source_line): Update.
1501 * tui/tui-source.c (tui_source_window::set_contents): Update.
1502 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1504 2019-09-20 Tom Tromey <tom@tromey.com>
1506 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1508 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1509 tui_clear_source_windows_detail.
1510 * tui/tui-winsource.h (struct tui_source_window_base)
1511 <clear_detail>: Don't declare.
1512 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1514 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1516 2019-09-20 Tom Tromey <tromey@adacore.com>
1519 * block.c (contained_in): Fix final return value.
1521 2019-09-20 Alan Modra <amodra@gmail.com>
1523 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1524 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1525 (read_indirect_string_from_dwz): Use bfd accessor.
1526 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1527 * machoread.c (macho_symfile_read_all_oso): Likewise.
1528 * solib.c (solib_bfd_open): Likewise.
1530 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1532 * eval.c: Move declaration of overload_resolution to...
1535 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1537 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1538 * arm-linux-tdep.c: Likewise.
1539 * arm-nbsd-nat.c: Likewise.
1540 * arm-tdep.h: Declare arm_apcs_32.
1541 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1543 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1545 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1546 * dwarf2read.h: Declare dwarf_always_disassemble.
1548 2019-09-19 Tom de Vries <tdevries@suse.de>
1551 * source-cache.c (source_cache::ensure): Catch exception thrown during
1552 construction of the highlighter.
1554 2019-09-18 Alan Modra <amodra@gmail.com>
1556 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1557 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1558 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1559 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1560 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1561 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1562 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1563 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1564 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1565 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1566 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1567 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1568 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1569 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1570 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1571 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1572 * mi/mi-interp.c: Update throughout for bfd section macro and
1574 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1575 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1577 2019-09-18 Tom Tromey <tom@tromey.com>
1580 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1582 (tui_enable): Do not call rl_initialize.
1584 2019-09-18 Christian Groessler <chris@groessler.org>
1586 * alpha-linux-nat.c: Include gdbarch.h.
1588 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1590 * ui-file.c: Include cli/cli-style.h.
1591 (term_cli_styling): Remove cli_styling declaration.
1593 2019-09-18 Alan Modra <amodra@gmail.com>
1595 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1596 to bfd_asymbol_section.
1598 2019-09-18 Alan Modra <amodra@gmail.com>
1600 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1601 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1602 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1604 2019-09-18 Alan Modra <amodra@gmail.com>
1606 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1607 * spu-linux-nat.c (spu_bfd_open): Likewise.
1609 2019-09-18 Christian Biesinger <cbiesinger@google.com>
1611 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1612 to bool to match definition in dwarf2read.c.
1614 2019-09-17 Christian Biesinger <cbiesinger@google.com>
1616 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1617 (print_signatures): Likewise.
1618 (trust_pad_over_xvs): Likewise.
1619 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1620 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1621 * arm-linux-nat.c (arm_apcs_32): Likewise.
1622 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1623 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1624 * arm-tdep.c (arm_debug): Likewise.
1625 (arm_apcs_32): Likewise.
1626 * auto-load.c (debug_auto_load): Likewise.
1627 (auto_load_gdb_scripts): Likewise.
1628 (global_auto_load): Likewise.
1629 (auto_load_local_gdbinit): Likewise.
1630 (auto_load_local_gdbinit_loaded): Likewise.
1631 * auto-load.h (global_auto_load): Likewise.
1632 (auto_load_local_gdbinit): Likewise.
1633 (auto_load_local_gdbinit_loaded): Likewise.
1634 * breakpoint.c (disconnected_dprintf): Likewise.
1635 (breakpoint_proceeded): Likewise.
1636 (automatic_hardware_breakpoints): Likewise.
1637 (always_inserted_mode): Likewise.
1638 (target_exact_watchpoints): Likewise.
1639 (_initialize_breakpoint): Update.
1640 * breakpoint.h (target_exact_watchpoints): Change to bool.
1641 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1642 * cli/cli-cmds.c (trace_commands): Likewise.
1643 * cli/cli-cmds.h (trace_commands): Likewise.
1644 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1646 * cli/cli-logging.c (logging_overwrite): Change to bool.
1647 (logging_redirect): Likewise.
1648 (debug_redirect): Likewise.
1649 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1650 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1652 <boolean_option_def>: Update.
1653 (struct flag_option_def): Change default type of Context to bool
1655 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1656 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1657 (get_setshow_command_value_string): Likewise.
1658 * cli/cli-style.c (cli_styling): Change to bool.
1659 (source_styling): Likewise.
1660 * cli/cli-style.h (source_styling): Likewise.
1661 (cli_styling): Likewise.
1662 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1664 * command.h (var_types): Update comment.
1665 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1666 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1668 (debug_compile_cplus_scopes): Likewise.
1669 * compile/compile-internal.h (compile_debug): Likewise.
1670 * compile/compile.c (compile_debug): Likewise.
1671 (struct compile_options) <raw>: Likewise.
1672 * cp-support.c (catch_demangler_crashes): Likewise.
1673 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1674 (usr_cmd_cris_dwarf2_cfi): Likewise.
1675 * csky-tdep.c (csky_debug): Likewise.
1676 * darwin-nat.c (enable_mach_exceptions): Likewise.
1677 * dcache.c (dcache_enabled_p): Likewise.
1678 * defs.h (info_verbose): Likewise.
1679 * demangle.c (demangle): Likewise.
1680 (asm_demangle): Likewise.
1681 * dwarf-index-cache.c (debug_index_cache): Likewise.
1682 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1683 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1684 * dwarf2read.c (check_physname): Likewise.
1685 (use_deprecated_index_sections): Likewise.
1686 (dwarf_always_disassemble): Likewise.
1687 * eval.c (overload_resolution): Likewise.
1688 * event-top.c (set_editing_cmd_var): Likewise.
1689 (exec_done_display_p): Likewise.
1690 * event-top.h (set_editing_cmd_var): Likewise.
1691 (exec_done_display_p): Likewise.
1692 * exec.c (write_files): Likewise.
1693 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1694 (debug_fbsd_nat): Likewise.
1695 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1697 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1698 <backtrace_past_entry> Likewise.
1699 * gdb-demangle.h (demangle): Likewise.
1700 (asm_demangle): Likewise.
1701 * gdb_bfd.c (bfd_sharing): Likewise.
1702 * gdbcore.h (write_files): Likewise.
1703 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1704 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1705 * gdbthread.h (print_thread_events): Likewise.
1706 * gdbtypes.c (opaque_type_resolution): Likewise.
1707 (strict_type_checking): Likewise.
1708 * gnu-nat.c (gnu_debug_flag): Likewise.
1709 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1710 * guile/scm-param.c (pascm_variable): Add boolval.
1711 (add_setshow_generic): Update.
1712 (pascm_param_value): Update.
1713 (pascm_set_param_value_x): Update.
1714 * hppa-tdep.c (hppa_debug): Change to bool..
1715 * infcall.c (may_call_functions_p): Likewise.
1716 (coerce_float_to_double_p): Likewise.
1717 (unwind_on_signal_p): Likewise.
1718 (unwind_on_terminating_exception_p): Likewise.
1719 * infcmd.c (startup_with_shell): Likewise.
1720 * inferior.c (print_inferior_events): Likewise.
1721 * inferior.h (startup_with_shell): Likewise.
1722 (print_inferior_events): Likewise.
1723 * infrun.c (step_stop_if_no_debug): Likewise.
1724 (detach_fork): Likewise.
1725 (debug_displaced): Likewise.
1726 (disable_randomization): Likewise.
1727 (non_stop): Likewise.
1728 (non_stop_1): Likewise.
1729 (observer_mode): Likewise.
1730 (observer_mode_1): Likewise.
1731 (set_observer_mode): Update.
1732 (sched_multi): Change to bool.
1733 * infrun.h (debug_displaced): Likewise.
1734 (sched_multi): Likewise.
1735 (step_stop_if_no_debug): Likewise.
1736 (non_stop): Likewise.
1737 (disable_randomization): Likewise.
1738 * linux-tdep.c (use_coredump_filter): Likewise.
1739 (dump_excluded_mappings): Likewise.
1740 * linux-thread-db.c (auto_load_thread_db): Likewise.
1741 (check_thread_db_on_load): Likewise.
1742 * main.c (captured_main_1): Update.
1743 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1744 xx2_opt, boolean_opt>: Change to bool.
1745 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1746 * maint.c (maintenance_profile_p): Likewise.
1747 (per_command_time): Likewise.
1748 (per_command_space): Likewise.
1749 (per_command_symtab): Likewise.
1750 * memattr.c (inaccessible_by_default): Likewise.
1751 * mi/mi-main.c (mi_async): Likewise.
1752 (mi_async_1): Likewise.
1753 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1754 * nat/fork-inferior.h (startup_with_shell): Likewise.
1755 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1756 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1757 * nios2-tdep.c (nios2_debug): Likewise.
1758 * or1k-tdep.c (or1k_debug): Likewise.
1759 * parse.c (parser_debug): Likewise.
1760 * parser-defs.h (parser_debug): Likewise.
1761 * printcmd.c (print_symbol_filename): Likewise.
1762 * proc-api.c (procfs_trace): Likewise.
1763 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1764 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1765 (set_parameter_value): Update.
1766 (add_setshow_generic): Update.
1767 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1769 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1771 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1772 * record-btrace.c (record_btrace_target::store_registers): Update.
1773 * record-full.c (record_full_memory_query): Change to bool.
1774 (record_full_stop_at_limit): Likewise.
1775 * record-full.h (record_full_memory_query): Likewise.
1776 * remote-notif.c (notif_debug): Likewise.
1777 * remote-notif.h (notif_debug): Likewise.
1778 * remote.c (use_range_stepping): Likewise.
1779 (interrupt_on_connect): Likewise.
1780 (remote_break): Likewise.
1781 * ser-tcp.c (tcp_auto_retry): Likewise.
1782 * ser-unix.c (serial_hwflow): Likewise.
1783 * skip.c (debug_skip): Likewise.
1784 * solib-aix.c (solib_aix_debug): Likewise.
1785 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1786 (spu_auto_flush_cache_p): Likewise.
1787 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1789 (struct info_print_options) <quiet>: Likewise.
1790 * symfile-debug.c (debug_symfile): Likewise.
1791 * symfile.c (auto_solib_add): Likewise.
1792 (separate_debug_file_debug): Likewise.
1793 * symfile.h (auto_solib_add): Likewise.
1794 (separate_debug_file_debug): Likewise.
1795 * symtab.c (basenames_may_differ): Likewise.
1796 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1797 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1798 (struct info_types_options) <quiet>: Likewise.
1799 * symtab.h (demangle): Likewise.
1800 (basenames_may_differ): Likewise.
1801 * target-dcache.c (stack_cache_enabled_1): Likewise.
1802 (code_cache_enabled_1): Likewise.
1803 * target.c (trust_readonly): Likewise.
1804 (may_write_registers): Likewise.
1805 (may_write_memory): Likewise.
1806 (may_insert_breakpoints): Likewise.
1807 (may_insert_tracepoints): Likewise.
1808 (may_insert_fast_tracepoints): Likewise.
1809 (may_stop): Likewise.
1810 (auto_connect_native_target): Likewise.
1811 (target_stop_and_wait): Update.
1812 (target_async_permitted): Change to bool.
1813 (target_async_permitted_1): Likewise.
1814 (may_write_registers_1): Likewise.
1815 (may_write_memory_1): Likewise.
1816 (may_insert_breakpoints_1): Likewise.
1817 (may_insert_tracepoints_1): Likewise.
1818 (may_insert_fast_tracepoints_1): Likewise.
1819 (may_stop_1): Likewise.
1820 * target.h (target_async_permitted): Likewise.
1821 (may_write_registers): Likewise.
1822 (may_write_memory): Likewise.
1823 (may_insert_breakpoints): Likewise.
1824 (may_insert_tracepoints): Likewise.
1825 (may_insert_fast_tracepoints): Likewise.
1826 (may_stop): Likewise.
1827 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1828 (make_thread_apply_all_options_def_group): Change argument from int*
1830 (thread_apply_all_command): Update.
1831 (print_thread_events): Change to bool.
1832 * top.c (confirm): Likewise.
1833 (command_editing_p): Likewise.
1834 (history_expansion_p): Likewise.
1835 (write_history_p): Likewise.
1836 (info_verbose): Likewise.
1837 * top.h (confirm): Likewise.
1838 (history_expansion_p): Likewise.
1839 * tracepoint.c (disconnected_tracing): Likewise.
1840 (circular_trace_buffer): Likewise.
1841 * typeprint.c (print_methods): Likewise.
1842 (print_typedefs): Likewise.
1843 * utils.c (debug_timestamp): Likewise.
1844 (sevenbit_strings): Likewise.
1845 (pagination_enabled): Likewise.
1846 * utils.h (sevenbit_strings): Likewise.
1847 (pagination_enabled): Likewise.
1848 * valops.c (overload_resolution): Likewise.
1849 * valprint.h (struct value_print_options) <prettyformat_arrays,
1850 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1851 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1852 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1854 * windows-nat.c (new_console): Likewise.
1855 (cygwin_exceptions): Likewise.
1856 (new_group): Likewise.
1857 (debug_exec): Likewise.
1858 (debug_events): Likewise.
1859 (debug_memory): Likewise.
1860 (debug_exceptions): Likewise.
1861 (useshell): Likewise.
1862 * windows-tdep.c (maint_display_all_tib): Likewise.
1863 * xml-support.c (debug_xml): Likewise.
1865 2019-09-17 Mike Gulick <mgulick@mathworks.com>
1867 * source.c (prepare_path_for_appending): New function.
1868 (openp): Make use of new function.
1869 (find_and_open_source): Search for the compilation directory and
1870 source file as a relative path beneath the directory search path.
1872 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1874 * source-cache.c (source_cache::get_line_charpos): Catch
1875 exceptions and return false, this matches the behaviour documented
1878 2019-09-17 Joel Brobecker <brobecker@adacore.com>
1880 * ada-tasks.c (info_task): Remove quoting of the task's name.
1882 2019-09-16 Christian Biesinger <cbiesinger@google.com>
1884 * symfile.c (auto_solib_add): Replace comment with a reference
1887 2019-09-14 Christian Biesinger <cbiesinger@google.com>
1889 * NEWS: Mention that gdb can now be compiled with Python 3
1892 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1894 * maint.c (maint_print_section_data::maint_print_section_data):
1895 Force use of 'float log10 (float)' by casting the argument to
1898 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1900 * maint.c: Add 'cmath' include.
1901 (struct maint_print_section_data): New structure.
1902 (print_section_index): New function.
1903 (print_bfd_section_info): Add header comment, small whitespace
1904 cleanup, and update to call new print_section_index function.
1905 (print_objfile_section_info): Likewise.
1906 (maint_obj_section_from_bfd_section): New function.
1907 (print_bfd_section_info_maybe_relocated): New function.
1908 (maintenance_info_sections): Add header comment, always use
1909 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1911 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1913 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1914 inner scope, add check that the objfile has psymtabs before
1915 checking psymtabs_addrmap.
1916 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1918 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1920 * NEWS: Announce that Ada task names are now shown at more places,
1921 and between quotes (except in info task output).
1922 * gdb/ada-tasks.c (task_to_str): New function.
1923 (display_current_task_id): Call task_to_str.
1924 (task_command_1): Likewise.
1925 (print_ada_task_info): In non-mi mode, Properly align headers and data
1926 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1928 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1930 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1931 prstatus.pr_lwp.pr_info instead of making it up.
1933 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1935 * auto-load.c (auto_load_expand_dir_vars): Update.
1936 * defs.h (gdb_datadir): Change to std::string.
1937 (python_libdir): Likewise.
1938 (relocate_gdb_directory): Change return type to std::string.
1939 * guile/guile.c (gdbscm_data_directory): Update.
1940 (initialize_scheme_side): Update.
1941 * jit.c (jit_reader_dir): Change to std::string.
1942 (jit_reader_load_command): Update.
1943 * main.c (gdb_datadir): Change to std::string.
1944 (python_libdir): Likewise.
1945 (set_gdb_data_directory): Update.
1946 (relocate_path): Change to return std::string.
1947 (relocate_gdb_directory): Change to return std::string.
1948 (relocate_gdbinit_path_maybe_in_datadir): Update.
1949 (captured_main_1): Update.
1950 * python/python.c (do_start_initialization): Update.
1951 * top.c (show_gdb_datadir): Update.
1952 * xml-syscall.c (xml_init_syscalls_info): Update.
1953 (init_syscalls_info): Update.
1955 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1957 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1958 out of get_init_files.
1959 (get_init_files): Update.
1961 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1963 * main.c (get_init_files): Change to use std::string.
1964 (captured_main_1): Update.
1965 (print_gdb_help): Update.
1967 2019-09-11 Ali Tamur <tamur@google.com>
1969 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1972 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1974 * dbxread.c (read_dbx_symtab): Update.
1975 * dwarf2read.c (load_partial_dies): Update.
1976 * mdebugread.c (parse_partial_symbols): Update.
1977 (handle_psymbol_enumerators): Update.
1978 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1979 * psymtab.c (add_psymbol_to_bcache): Likewise.
1980 (add_psymbol_to_list): Likewise.
1981 * symtab.c (symbol_set_names): Likewise.
1982 * symtab.h (symbol_set_names): Likewise.
1983 * xcoffread.c (scan_xcoff_symtab): Update.
1985 2019-09-11 Tom Tromey <tom@tromey.com>
1987 * symfile-mem.c (symbol_file_add_from_memory): Use
1989 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1990 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1992 2019-09-10 Tom Tromey <tromey@adacore.com>
1994 * dwarf-index-write.c (write_psymbols): Extend error message.
1995 (debug_names::insert): Add Ada code.
1996 (debug_names::write_psymbols): Remove Ada check.
1997 (debug_names) <m_string_obstack>: New member.
1998 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1999 (gdb_index_symbol_name_matcher::matches): Remove.
2000 (mapped_index_base::find_name_components_bounds): Add "lang"
2002 (mapped_index_base::build_name_components): Also split names
2003 according to Ada syntax.
2004 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
2005 type of "match_callback".
2006 (check_match, check_find_bounds_finds)
2007 (dw2_expand_symtabs_matching): Update.
2008 (dw2_debug_names_iterator): Add new constructor.
2009 (dw2_debug_names_map_matching_symbols): New function.
2010 (dw2_debug_names_expand_symtabs_matching): Update.
2011 (dwarf2_debug_names_functions): Use
2012 dw2_debug_names_map_matching_symbols.
2014 2019-09-10 Tom Tromey <tromey@adacore.com>
2016 * dwarf2read.c (dw2_get_file_names_reader): Add the
2017 CU's file name to the results.
2019 2019-09-10 Tom Tromey <tromey@adacore.com>
2021 * ada-lang.c (add_nonlocal_symbols): Combine calls to
2022 map_matching_symbols. Update.
2023 * dwarf2read.c (dw2_map_matching_symbols): Update.
2024 * psymtab.c (match_partial_symbol): Change type; update.
2025 (psym_map_matching_symbols): Likewise.
2026 * symfile-debug.c (debug_qf_map_matching_symbols): Change
2028 * symfile.h (struct quick_symbol_functions)
2029 <map_matching_symbols>: Change "name" to be a lookup_name_info.
2032 2019-09-10 Tom Tromey <tromey@adacore.com>
2034 * psymtab.c (map_block): Remove.
2035 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2036 * symtab.c (iterate_over_symbols_terminated): New function.
2037 * symtab.c (iterate_over_symbols_terminated): Declare.
2039 2019-09-10 Tom Tromey <tromey@adacore.com>
2041 * ada-lang.c (ada_iterate_over_symbols): Return bool.
2042 * language.h (struct language_defn) <la_iterate_over_symbols>:
2044 * symtab.c (iterate_over_symbols): Return bool.
2045 * symtab.h (iterate_over_symbols): Return bool.
2047 2019-09-10 Tom Tromey <tromey@adacore.com>
2049 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2050 (add_nonlocal_symbols): Update.
2051 * dwarf2read.c (dw2_map_matching_symbols): Change type.
2052 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2053 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2054 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2055 Change type of "callback". Remove "data".
2058 2019-09-09 Ali Tamur <tamur@google.com>
2060 * dwarf2read.c (comp_unit_head): Update comment.
2061 (dwarf2_dwo_name): New function declaration.
2062 (dwarf_unit_type_name): New function declaration.
2063 (read_comp_unit_head): Add support for new compilation units,
2064 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2065 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2066 (currently named as "signature") in their header. Also clarify error
2068 (lookup_dwo_id): New function. Returns the dwo id of the given
2070 (lookup_dwo_unit): Use the new lookup_dwo_id function.
2071 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2073 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2074 (dwarf2_dwo_name): Get the dwo name if present.
2075 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2078 2019-09-09 Tom Tromey <tom@tromey.com>
2080 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2082 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2084 * python/python.c (do_start_initialization): Make progname_copy static,
2085 to avoid a leak report.
2087 2019-09-08 Tom Tromey <tom@tromey.com>
2089 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2091 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
2093 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2094 Change type to gdb::optional<block_enum>.
2095 (dw2_symtab_iter_init): Change block_index parameter type
2096 to gdb::optional<block_enum>.
2097 (dw2_lookup_symbol): Change block_index parameter
2098 type to block_enum.c
2099 (dw2_debug_names_lookup_symbol): Likewise.
2100 * psymtab.c (psym_lookup_symbol): Likewise.
2101 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2102 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2105 2019-09-06 Christian Biesinger <cbiesinger@google.com>
2107 * defs.h (relocate_gdb_directory): Change int to bool in
2108 signature and rename flag to relocatable.
2109 * main.c (relocate_path): Likewise.
2110 (relocate_gdb_directory): Likewise.
2112 2019-09-06 Alan Modra <amodra@gmail.com>
2114 * coffread.c (coff_symfile_read): Constify filename variable.
2115 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2116 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2117 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2118 * solib.c (reload_shared_libraries_1): Likewise.
2119 * symfile.c (reread_symbols): Likewise.
2120 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2121 * solib-darwin.c (darwin_bfd_open): Likewise.
2122 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2124 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
2126 * psymtab.c (print_partial_symbols): Handle missing domain_enum
2127 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2129 2019-09-03 Tom Tromey <tromey@adacore.com>
2131 * ada-valprint.c (ada_val_print_num): Don't recurse for range
2133 (has_negatives): Unbias a range type bound.
2134 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2135 * gdbtypes.c (operator==): Handle new field.
2136 (create_range_type): Add "bias" parameter.
2137 (create_static_range_type, resolve_dynamic_range): Update.
2138 * gdbtypes.h (struct range_bounds) <bias>: New member.
2139 (create_range_type): Add bias parameter.
2140 * printcmd.c (print_scalar_formatted): Unbias range types.
2141 * value.c (unpack_long): Unbias range types.
2142 (pack_long): Bias range types.
2144 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2146 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2149 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2151 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2152 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2153 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2154 (compile_probe_arg): Likewise.
2155 * probe.h (get_argument_count): Likewise.
2156 * solib-svr4.c (solib_event_probe_action): Likewise.
2157 * stap-probe.c (stap_probe::get_argument_count): Likewise.
2159 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2161 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2163 (svr4_create_solib_event_breakpoints): ...from here.
2165 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
2167 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2168 suffix from warning message.
2170 2019-08-30 Tom Tromey <tom@tromey.com>
2172 * tui/tui-winsource.h (struct tui_source_window_base)
2173 <refresh_all>: Don't declare.
2174 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2176 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2177 tui_show_locator_content.
2178 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2180 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2181 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2184 2019-08-30 Tom Tromey <tom@tromey.com>
2186 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2188 2019-08-30 Tom Tromey <tom@tromey.com>
2190 * tui/tui-stack.c (_initialize_tui_stack): Move later.
2191 Remove unnecessary forward declarations.
2193 2019-08-30 Tom Tromey <tom@tromey.com>
2195 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2197 (tui_update_locator_fullname, tui_show_frame_info): Don't call
2198 tui_show_locator_content.
2200 2019-08-30 Tom Tromey <tom@tromey.com>
2202 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
2203 (tui_locator_window::rerender): Rewrite using body of previous
2204 tui_show_locator_content.
2206 2019-08-30 Tom Tromey <tom@tromey.com>
2208 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2209 set_locator_fullname>: New methods.
2210 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2211 Rename from tui_set_locator_fullname.
2212 (tui_locator_window::set_locator_info): Rename from
2213 tui_set_locator_info. Return bool.
2214 (tui_update_locator_fullname, tui_show_frame_info): Update.
2216 2019-08-30 Tom Tromey <tom@tromey.com>
2218 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2220 2019-08-30 Tom Tromey <tom@tromey.com>
2222 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2225 2019-08-30 Tom Tromey <tom@tromey.com>
2227 * tui/tui-wingeneral.c (box_win): Assume win_info and
2228 win_info->handle cannot be NULL.
2230 2019-08-30 Tom Tromey <tom@tromey.com>
2232 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2233 refresh_window>: Declare.
2234 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2236 (tui_data_item_window::rerender): Rename from
2237 tui_display_register.
2238 (tui_data_item_window::refresh_window): New method.
2239 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2242 2019-08-30 Tom Tromey <tom@tromey.com>
2244 * tui/tui-regs.h (struct tui_data_window) <regs_content,
2245 regs_column_count, current_group>: Move later. Now private.
2246 <get_current_group>: New method.
2247 * tui/tui-regs.c (tui_reg_command): Update.
2248 * tui/tui-layout.c (tui_set_layout): Update.
2250 2019-08-30 Tom Tromey <tom@tromey.com>
2252 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2253 (tui_data_window::rerender): Don't call
2254 check_and_display_highlight_if_needed.
2255 (tui_data_window::refresh_all): Remove call to
2258 2019-08-30 Tom Tromey <tom@tromey.com>
2260 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2261 (tui_data_window::display_registers_from)
2262 (tui_data_window::display_reg_element_at_line)
2263 (tui_data_window::display_registers_from_line): Remove checks of
2266 2019-08-30 Tom Tromey <tom@tromey.com>
2268 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2270 * tui/tui-regs.c (tui_data_window::show_registers): Call
2272 (tui_data_window::rerender): Rename from display_all_data.
2273 (tui_data_window::rerender): Remove old implementation.
2275 2019-08-30 Tom Tromey <tom@tromey.com>
2277 * tui/tui-regs.c (tui_data_window::display_all_data): Change
2279 * tui/tui-data.h (NO_DATA_STRING): Remove define.
2281 2019-08-29 Bernhard Wodok <barto@gmx.net>
2282 Sergio Durigan Junior <sergiodj@redhat.com>
2285 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2287 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
2289 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2290 when searching for types.
2292 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
2294 * f-lang.c (f_language_defn): Use f_print_typedef.
2295 * f-lang.h (f_print_typedef): Declare.
2296 * f-typeprint.c (f_print_typedef): Define.
2298 2019-08-27 Christian Biesinger <cbiesinger@google.com>
2300 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2302 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
2304 * cli/cli-utils.c (info_print_options_defs): Delete.
2305 (make_info_print_options_def_group): Delete.
2306 (extract_info_print_options): Delete.
2307 (info_print_command_completer): Delete.
2308 (info_print_args_help): Add extra parameter, and optionally
2309 include text about -n flag.
2310 * cli/cli-utils.h (struct info_print_options): Delete.
2311 (extract_info_print_options): Delete declaration.
2312 (info_print_command_completer): Delete declaration.
2313 (info_print_args_help): Add extra parameter, extend header
2315 * python/python.c (gdbpy_rbreak): Pass additional parameter to
2317 * stack.c (struct info_print_options): New type.
2318 (info_print_options_defs): New file scoped variable.
2319 (make_info_print_options_def_group): New static function.
2320 (info_print_command_completer): New static function.
2321 (info_locals_command): Update to use new local functions.
2322 (info_args_command): Likewise.
2323 (_initialize_stack): Add extra parameter to calls to
2324 info_print_args_help.
2325 * symtab.c (search_symbols): Add extra parameter, use this to
2326 possibly excluse non-debug symbols.
2327 (symtab_symbol_info): Add extra parameter, which is passed on to
2329 (struct info_print_options): New type.
2330 (info_print_options_defs): New file scoped variable.
2331 (make_info_print_options_def_group): New static function.
2332 (info_print_command_completer): New static function.
2333 (info_variables_command): Update to use local functions, and pass
2334 extra parameter through to symtab_symbol_info.
2335 (info_functions_command): Likewise.
2336 (info_types_command): Pass additional argument through to
2338 (rbreak_command): Pass extra argument to search_symbols.
2339 (_initialize_symtab): Add extra arguments for calls to
2340 info_print_args_help, and update help text for 'info variables',
2341 'whereis', and 'info functions' commands.
2342 * symtab.h (search_symbols): Add extra argument to declaration.
2343 * NEWS: Mention new flags.
2345 2019-08-26 Christian Biesinger <cbiesinger@google.com>
2347 * symtab.c (lookup_static_symbol): Call the new function (and move
2348 it down to be next to lookup_global_symbol).
2349 (struct global_sym_lookup_data): Add block_enum member and rename to...
2350 (struct global_or_static_sym_lookup_data): ...this.
2351 (lookup_symbol_global_iterator_cb): Pass block_index instead of
2352 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2353 (lookup_symbol_global_or_static_iterator_cb): ...this.
2354 (lookup_global_or_static_symbol): New function.
2355 (lookup_global_symbol): Call new function.
2357 2019-08-26 Tom de Vries <tdevries@suse.de>
2360 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2361 when pc_probe.prob == NULL.
2363 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
2365 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2366 variable symbol_linkage to symbol_linkage_.
2368 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
2370 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2371 represent whether the symbol is static, dynamic, or we don't
2374 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
2376 * gdb/rx-tdep.c (rx_register_names): New.
2377 (rx_register_name): Delete.
2378 (rx_psw_type): Delete.
2379 (rx_fpsw_type): Delete.
2380 (rx_register_type): Delete.
2381 (rx_gdbarch_init): Convert target-descriptions.
2382 (_initialize_rx_tdep): Add initialize_tdesc_rx.
2383 * gdb/features/Makefile: Add rx.xml.
2384 * gdb/features/rx.xml: New.
2385 * gdb/features/rx.c: Generated.
2386 * gdb/NEWS: Mention target description support.
2388 2019-08-22 Christian Biesinger <cbiesinger@google.com>
2390 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2393 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
2395 * configure.ac: Don't check for 'dlfcn.h' (moved to
2396 gdbsupport/common.m4).
2397 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2399 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2400 * compile/compile-c-support.c: Include
2401 'gdbsupport/gdb-dlfcn.h'.
2402 * gdbsupport/common.m4: Check for 'dlfcn.h'.
2403 * gdb-dlfcn.c: Move to...
2404 * gdbsupport/gdb-dlfcn.c: ... here.
2405 * gdb-dlfcn.h: Move to...
2406 * gdbsupport/gdb-dlfcn.h: ... here.
2408 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
2410 * nios2-tdep.c (struct reg_value): Improve comments. Make
2411 the offset field signed.
2413 2019-08-22 Christian Biesinger <cbiesinger@google.com>
2415 * python/lib/gdb/__init__.py (_execute_file): New function.
2416 * python/python.c (python_run_simple_file): Call gdb._execute_file
2419 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
2421 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2422 all uses as this was never set to anything but a zero value.
2424 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
2426 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2428 2019-08-21 Christian Biesinger <cbiesinger@google.com>
2430 * tui/tui-data.h (tui_gen_win_info): Add an =default
2431 move constructor, required by some GCC versions.
2433 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
2435 * go32-nat.c (go32_sysinfo): Add hygon_p.
2437 2019-08-20 Tom Tromey <tom@tromey.com>
2439 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2440 line_from_reg_element_no, first_reg_element_no_inline,
2441 display_all_data, delete_data_content_windows,
2442 erase_data_content>: Now private.
2444 2019-08-20 Tom Tromey <tom@tromey.com>
2446 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2447 (tui_unhighlight_win, tui_highlight_win)
2448 (tui_win_info::make_window): Update.
2449 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2451 2019-08-20 Tom Tromey <tom@tromey.com>
2453 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2454 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2455 (MAX_PID_WIDTH): Move to tui-stack.c.
2456 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2457 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2458 (MAX_PID_WIDTH): Move from tui-data.h.
2460 2019-08-20 Tom Tromey <tom@tromey.com>
2462 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2463 * tui/tui-wingeneral.c (box_win): Change type of win_info.
2465 (tui_gen_win_info::make_window): Rename from tui_make_window.
2466 (tui_win_info::make_window): New method.
2467 (tui_gen_win_info::make_visible): Update.
2468 * tui/tui-source.c (tui_source_window::set_contents): Update.
2469 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2470 (tui_data_window::display_registers_from): Update.
2471 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2472 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2476 (struct tui_win_info) <make_window>: Declare.
2477 <can_box>: Now virtual.
2478 <title>: New member.
2479 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2480 * tui/tui-command.c (tui_cmd_window::resize): Update.
2482 2019-08-20 Tom Tromey <tom@tromey.com>
2484 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2485 * tui/tui-regs.c (tui_data_window::show_registers): Update.
2486 (tui_data_window::check_register_values): Update.
2488 2019-08-20 Tom Tromey <tom@tromey.com>
2490 * tui/tui-regs.h (struct tui_data_window): Use
2491 DISABLE_COPY_AND_ASSIGN.
2492 <regs_content>: Change type, removing unique_ptr.
2493 <tui_data_window>: Add move constructor.
2494 * tui/tui-regs.c (tui_data_window::show_registers)
2495 (tui_data_window::show_register_group)
2496 (tui_data_window::display_registers_from)
2497 (tui_data_window::display_registers_from)
2498 (tui_data_window::first_data_item_displayed)
2499 (tui_data_window::delete_data_content_windows)
2500 (tui_data_window::rerender, tui_data_window::refresh_window)
2501 (tui_data_window::check_register_values): Update.
2503 2019-08-20 Tom Tromey <tom@tromey.com>
2505 * tui/tui-regs.h (struct tui_data_window) <show_registers,
2506 show_register_group>: Declare.
2507 (tui_show_register_group): Don't declare.
2508 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2510 (tui_data_window::show_register_group): Rename from
2511 tui_show_register_group.
2512 (tui_data_window::check_register_values, tui_reg_command):
2514 * tui/tui-layout.c (tui_set_layout): Update.
2516 2019-08-20 Tom Tromey <tom@tromey.com>
2518 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2520 (tui_check_register_values): Don't declare.
2521 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2522 from tui_check_register_values.
2523 * tui/tui-hooks.c (tui_register_changed): Update.
2525 2019-08-20 Tom Tromey <tom@tromey.com>
2527 * tui/tui-regs.c (tui_reg_layout): Move later.
2528 (tui_show_registers): Don't enable TUI mode or change layout.
2530 2019-08-20 Tom Tromey <tom@tromey.com>
2532 * tui/tui-regs.h (struct tui_data_item_window)
2533 <~tui_data_item_window>: Remove.
2534 <content>: Now a unique_xmalloc_ptr.
2535 * tui/tui-regs.c (tui_register_format): Return a
2537 (tui_get_register): Update.
2538 (~tui_data_item_window): Remove.
2539 (tui_data_window::display_registers_from, tui_display_register):
2541 * tui/tui-io.h (tui_expand_tabs): Update.
2542 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2543 Remove "col" parameter.
2545 2019-08-20 Tom Tromey <tom@tromey.com>
2547 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2549 * tui/tui-regs.c (~tui_data_item_window): Update.
2551 2019-08-20 Tom Tromey <tom@tromey.com>
2553 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2556 2019-08-20 Tom Tromey <tom@tromey.com>
2558 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2560 2019-08-20 Tom Tromey <tom@tromey.com>
2562 * tui/tui-source.h (struct tui_source_window): Update.
2563 * tui/tui-regs.c (tui_show_registers): Update.
2564 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2565 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2566 (NO_REGS_STRING): Remove defines.
2568 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
2570 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2571 unnecessary thread walk if remote doesn't support the packet.
2573 2019-08-19 Tom Tromey <tromey@adacore.com>
2575 * python/py-value.c (value_has_field): Fix indentation.
2577 2019-08-19 Tom Tromey <tromey@adacore.com>
2579 * printcmd.c (do_one_display, info_display_command): Update.
2580 * block.h (contained_in): Return bool. Add allow_nested
2582 * block.c (contained_in): Return bool. Add allow_nested
2585 2019-08-19 Tom Tromey <tom@tromey.com>
2587 * configure: Rebuild.
2588 * configure.ac: Disallow the combination of -static-libstdc++ and
2590 * source-cache.c (get_language_name): Handle rust.
2591 (source_cache::get_source_lines): Ignore highlighting exceptions.
2593 2019-08-16 Tom Tromey <tom@tromey.com>
2595 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2596 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2597 (struct tui_source_window_base) <make_visible, refresh_window,
2598 resize>: Remove methods.
2599 <execution_info>: Remove field.
2600 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2601 (tui_show_source_line, tui_source_window_base)
2602 (~tui_source_window_base): Update.
2603 (tui_source_window_base::resize)
2604 (tui_source_window_base::make_visible)
2605 (tui_source_window_base::refresh_window): Remove.
2606 (tui_source_window_base::update_exec_info): Update.
2607 * tui/tui-source.c (tui_source_window::set_contents): Update.
2608 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2610 2019-08-16 Tom Tromey <tom@tromey.com>
2612 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2613 deprecated_query_hook.
2615 2019-08-16 Tom Tromey <tom@tromey.com>
2617 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2618 (tui_update_source_windows_with_line): Update.
2619 * tui/tui-source.h (struct tui_source_window)
2620 <show_symtab_source>: Declare.
2621 (tui_show_symtab_source): Don't declare.
2622 * tui/tui-source.c (tui_show_symtab_source): Rename from
2623 tui_show_symtab_source.
2625 2019-08-16 Tom Tromey <tom@tromey.com>
2627 * tui/tui-winsource.h (struct tui_source_window_base)
2628 <set_contents>: Declare.
2629 * tui/tui-winsource.c
2630 (tui_source_window_base::update_source_window_as_is): Update.
2631 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2633 (tui_set_source_content): Don't declare.
2634 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2635 tui_set_source_content.
2636 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2638 (tui_set_disassem_content): Don't declare.
2639 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2640 tui_set_disassem_content.
2642 2019-08-16 Tom Tromey <tom@tromey.com>
2644 * tui/tui-winsource.h (struct tui_source_window_base)
2645 <update_breakpoint_info>: Declare.
2646 (tui_update_breakpoint_info): Don't declare.
2647 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2648 (tui_update_all_breakpoint_info): Update.
2649 (tui_source_window_base::update_breakpoint_info): Rename from
2650 tui_update_breakpoint_info.
2651 (tui_source_window_base::update_exec_info): Update.
2653 2019-08-16 Tom Tromey <tom@tromey.com>
2655 * tui/tui-winsource.h (struct tui_source_window_base)
2656 <update_source_window>: Declare.
2657 (tui_update_source_window): Don't declare.
2658 * tui/tui-winsource.c
2659 (tui_source_window_base::update_source_window): Rename from
2660 tui_update_source_window.
2661 (tui_source_window_base::rerender): Update.
2662 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2663 * tui/tui-disasm.c (tui_show_disassem)
2664 (tui_show_disassem_and_update_source)
2665 (tui_disasm_window::maybe_update): Update.
2667 2019-08-16 Tom Tromey <tom@tromey.com>
2669 * tui/tui-winsource.h (struct tui_source_window_base)
2670 <update_source_window_as_is>: Declare.
2671 (tui_update_source_window_as_is): Don't declare.
2672 * tui/tui-winsource.c (tui_update_source_window): Update
2673 (tui_source_window_base::update_source_window_as_is): Rename from
2674 tui_update_source_window_as_is.
2675 (tui_source_window_base::refill): Update.
2676 * tui/tui-source.c (tui_show_symtab_source): Update.
2677 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2680 2019-08-16 Tom Tromey <tom@tromey.com>
2682 * tui/tui-winsource.h (tui_update_source_window)
2683 (tui_update_source_window_as_is): Remove "noerror" parameter.
2684 * tui/tui-winsource.c (tui_update_source_window)
2685 (tui_update_source_window_as_is): Remove "noerror" parameter.
2686 (tui_update_source_windows_with_addr)
2687 (tui_update_source_windows_with_line)
2688 (tui_source_window_base::rerender)
2689 (tui_source_window_base::refill): Update.
2690 * tui/tui-source.h (tui_set_source_content)
2691 (tui_show_symtab_source): Remove "noerror" parameter.
2692 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2694 (tui_show_symtab_source): Likewise.
2695 (tui_source_window::maybe_update): Update.
2696 * tui/tui-disasm.c (tui_show_disassem)
2697 (tui_show_disassem_and_update_source)
2698 (tui_disasm_window::do_scroll_vertical)
2699 (tui_disasm_window::maybe_update): Update.
2701 2019-08-16 Tom Tromey <tom@tromey.com>
2703 * tui/tui.c (tui_is_window_visible): Update.
2704 * tui/tui-wingeneral.c (tui_make_window)
2705 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2706 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2707 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2708 (tui_set_win_height_command, parse_scrolling_args): Update.
2709 * tui/tui-source.c (tui_source_window::style_changed): Update.
2710 * tui/tui-regs.c (tui_show_registers)
2711 (tui_data_window::first_data_item_displayed)
2712 (tui_data_window::delete_data_content_windows)
2713 (tui_check_register_values, tui_reg_command): Update.
2714 * tui/tui-disasm.c (tui_show_disassem): Update.
2715 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2717 <is_visible>: Remove field.
2718 * tui/tui-data.c (tui_next_win, tui_prev_win)
2719 (tui_delete_invisible_windows): Update.
2721 2019-08-16 Tom Tromey <tom@tromey.com>
2723 * tui/tui-winsource.h (struct tui_source_window_base)
2724 <m_has_locator>: Remove.
2725 * tui/tui-layout.c (show_source_disasm_command, show_data)
2726 (show_source_or_disasm_and_command): Update.
2728 2019-08-16 Alan Hayward <alan.hayward@arm.com>
2730 * NEWS (Other MI changes): New subsection.
2731 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2732 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2733 * arch-utils.c (default_get_pc_address_flags): New function.
2734 * arch-utils.h (default_get_pc_address_flags): New declaration.
2735 * gdbarch.sh: Add get_pc_address_flags.
2736 * gdbarch.c: Regenerate.
2737 * gdbarch.h: Likewise.
2738 * stack.c (print_pc): New function.
2739 (print_frame_info) (print_frame): Call print_pc.
2741 2019-08-16 Tom de Vries <tdevries@suse.de>
2743 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2744 print_objfile_section_info.
2746 2019-08-15 Tom Tromey <tom@tromey.com>
2748 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2749 calling update_cmdwin_start_line.
2750 * tui/tui-winsource.h (struct tui_source_window_base)
2751 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2752 <rerender>: Declare.
2753 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2755 (tui_source_window_base::set_new_height): Remove.
2756 (tui_source_window_base::rerender): Rename from
2757 do_make_visible_with_new_height.
2758 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2760 (tui_win_info::make_invisible_and_set_new_height)
2761 (tui_win_info::make_visible_with_new_height): Remove.
2762 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2764 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2765 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2766 do_make_visible_with_new_height>: Don't declare.
2767 <rerender>: Declare.
2768 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2770 (tui_data_window::do_make_visible_with_new_height): Remove.
2771 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2772 call tui_show_locator_content.
2773 (tui_gen_win_info::resize): Call rerender.
2774 (show_source_or_disasm_and_command): Don't call
2775 tui_show_locator_content.
2776 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2778 (struct tui_win_info) <rerender>: Declare.
2779 <set_new_height, make_invisible_and_set_new_height,
2780 make_visible_with_new_height>: Don't declare.
2781 * tui/tui-data.c (tui_win_list::rerender): New method.
2782 * tui/tui-command.h (struct tui_cmd_window)
2783 <do_make_visible_with_new_height>: Don't declare.
2785 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2787 2019-08-15 Tom Tromey <tromey@adacore.com>
2789 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2790 * ada-lang.c (ada_enum_name): Likewise.
2792 2019-08-15 Christian Biesinger <cbiesinger@google.com>
2794 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2796 (GdbOutputErrorFile): Likewise.
2797 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2799 (execute_unwinders): Rename to have a leading underscore.
2800 (auto_load_packages): Likewise.
2801 (global scope): Adjust call to auto_load_packages accordingly.
2802 (GdbSetPythonDirectory): Likewise.
2803 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2804 instead of execute_unwinders.
2806 2019-08-15 Tom Tromey <tom@tromey.com>
2808 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2809 (show_data): Don't change window visibility.
2810 (tui_gen_win_info::resize): Remove special case for command
2811 window. Use wresize, when available.
2812 (show_source_or_disasm_and_command): Don't change window
2814 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2815 <make_visible>: New method.
2816 * tui/tui-command.c (tui_cmd_window::resize): New method.
2818 2019-08-15 Tom Tromey <tom@tromey.com>
2820 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2821 (struct tui_source_windows): New.
2822 * tui/tui-winsource.c (tui_display_main): Update.
2823 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2824 (new_height_ok, parse_scrolling_args): Update.
2825 * tui/tui-layout.c (show_layout, show_data): Update.
2826 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2827 (tui_add_to_source_windows): Don't declare.
2828 * tui/tui-data.c (source_windows, tui_source_windows)
2829 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2831 2019-08-15 Tom Tromey <tom@tromey.com>
2833 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2835 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2836 * tui/tui-layout.c (show_source_disasm_command, show_data):
2838 (tui_gen_win_info::resize): Rename.
2839 (show_source_or_disasm_and_command): Update.
2840 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2843 2019-08-15 Tom Tromey <tom@tromey.com>
2845 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2846 * tui/tui-interp.c (tui_interp::init): Don't call
2847 tui_initialize_static_data.
2848 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2850 2019-08-15 Tom Tromey <tom@tromey.com>
2852 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2853 examine tui_win_list.
2855 2019-08-15 Tom Tromey <tom@tromey.com>
2857 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2858 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2859 tui_clear_source_content.
2860 (tui_clear_source_content): Remove.
2861 (tui_source_window_base::do_erase_source_content): Hoist call to
2863 * tui/tui-stack.c (tui_show_frame_info): Don't call
2864 tui_clear_source_content.
2866 2019-08-15 Tom Tromey <tom@tromey.com>
2868 * tui/tui-winsource.h (struct tui_source_window_base)
2869 <do_erase_source_content>: New method.
2870 <erase_source_content>: New method.
2871 (tui_erase_source_content): Don't declare.
2872 * tui/tui-winsource.c (tui_clear_source_content): Update.
2873 (tui_source_window_base::do_erase_source_content): Rename from
2874 tui_erase_source_content.
2875 (tui_source_window_base::show_source_content): Update.
2876 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2877 * tui/tui-source.h (struct tui_source_window)
2878 <erase_source_content>: New method.
2879 * tui/tui-disasm.h (struct tui_disasm_window)
2880 <erase_source_content>: New method.
2882 2019-08-15 Tom Tromey <tom@tromey.com>
2884 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2885 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2887 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2888 * tui/tui-source.c (tui_set_source_content): Update.
2889 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2891 2019-08-15 Tom Tromey <tom@tromey.com>
2893 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2894 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2896 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2898 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2900 (tui_source_window::maybe_update): Update.
2902 2019-08-15 Tom Tromey <tom@tromey.com>
2904 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2905 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2907 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2909 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2911 (tui_disasm_window::maybe_update): Update.
2913 2019-08-15 Tom Tromey <tom@tromey.com>
2915 * tui/tui-winsource.h (struct tui_source_window_base)
2916 <maybe_update>: Declare.
2917 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2919 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2921 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2922 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2924 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2926 2019-08-15 Tom Tromey <tom@tromey.com>
2928 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2930 2019-08-15 Tom Tromey <tom@tromey.com>
2932 * tui/tui-wingeneral.c: Include tui-stack.h.
2933 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2934 (struct tui_locator_window): Move from tui-data.h.
2935 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2936 (tui_initialize_static_data): Move from tui-data.c.
2937 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2938 (struct tui_locator_window): Move to tui-stack.c.
2939 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2940 (tui_initialize_static_data): Move to tui-stack.c.
2942 2019-08-15 Tom Tromey <tom@tromey.com>
2944 * tui/tui-layout.c (show_source_disasm_command)
2945 (show_source_or_disasm_and_command): Use make_visible method, not
2947 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2950 2019-08-15 Tom Tromey <tom@tromey.com>
2952 * tui/tui-wingeneral.h (tui_make_window): Update.
2953 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2955 (tui_gen_win_info::make_visible): Update.
2956 * tui/tui-regs.c (tui_data_window::display_registers_from):
2958 * tui/tui-layout.c (show_source_disasm_command)
2959 (show_source_or_disasm_and_command): Update.
2960 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2961 (enum tui_box): Remove.
2962 (struct tui_win_info) <can_box>: New method.
2963 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2966 2019-08-15 Tom de Vries <tdevries@suse.de>
2968 * linux-nat-trad.c: Include gdbarch.h.
2970 2019-08-14 Alan Hayward <alan.hayward@arm.com>
2972 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2975 2019-08-14 Tom Tromey <tromey@adacore.com>
2977 * darwin-nat.c: Include gdbarch.h.
2978 * darwin-nat-info.c: Include gdbarch.h.
2980 2019-08-13 Tom Tromey <tom@tromey.com>
2982 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2984 * tui/tui-data.c (tui_initialize_static_data): Update.
2986 2019-08-13 Tom Tromey <tom@tromey.com>
2988 * tui/tui-winsource.h (struct tui_exec_info_window)
2989 <~tui_exec_info_window, maybe_allocate_content, get_content,
2991 (struct tui_source_window_base) <set_exec_info_content,
2992 show_exec_info_content>: Don't declare.
2993 * tui/tui-winsource.c
2994 (tui_exec_info_window::maybe_allocate_content): Remove.
2995 (tui_source_window_base::update_exec_info): Rename from
2996 set_exec_info_content.
2997 (tui_source_window_base::show_exec_info_content)
2998 (tui_source_window_base::update_exec_info): Remove.
3000 2019-08-13 Tom Tromey <tom@tromey.com>
3002 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3004 * tui/tui-winsource.c (tui_update_source_window_as_is)
3005 (tui_update_source_windows_with_addr, tui_erase_source_content):
3007 (tui_clear_exec_info_content): Remove.
3009 2019-08-13 Tom Tromey <tom@tromey.com>
3011 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3013 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3014 call tui_erase_exec_info_content.
3015 (tui_clear_exec_info_content): Rename from
3016 tui_erase_exec_info_content.
3017 (tui_clear_exec_info_content): Delete.
3019 2019-08-13 Tom Tromey <tom@tromey.com>
3021 * tui/tui-winsource.h (struct tui_source_window_base)
3022 <show_exec_info_content>: Declare.
3023 (tui_show_exec_info_content): Don't declare.
3024 * tui/tui-winsource.c
3025 (tui_source_window_base::show_exec_info_content): Rename from
3026 tui_show_exec_info_content.
3027 (tui_source_window_base::update_exec_info): Update.
3029 2019-08-13 Tom Tromey <tom@tromey.com>
3031 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3032 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3033 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3034 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3035 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3036 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3039 2019-08-13 Tom Tromey <tom@tromey.com>
3041 * tui/tui-winsource.h (struct tui_source_window_base)
3042 <update_exec_info>: Declare.
3043 (tui_update_exec_info): Don't declare.
3044 * tui/tui-winsource.c (tui_update_source_window_as_is)
3045 (tui_source_window_base::refresh_all)
3046 (tui_update_all_breakpoint_info): Update.
3047 (tui_source_window_base::update_exec_info): Rename from
3048 tui_update_exec_info.
3049 * tui/tui-stack.c (tui_show_frame_info): Update.
3051 2019-08-13 Tom Tromey <tom@tromey.com>
3053 * tui/tui-winsource.h (struct tui_source_window_base)
3054 <set_exec_info_content>: Declare.
3055 (tui_set_exec_info_content): Don't declare.
3056 * tui/tui-winsource.c
3057 (tui_source_window_base::set_exec_info_content): Rename from
3058 tui_set_exec_info_content.
3059 (tui_update_exec_info): Update.
3061 2019-08-13 Tom Tromey <tom@tromey.com>
3063 * tui/tui-winsource.h (struct tui_source_window_base)
3064 <show_source_content>: Declare.
3065 (tui_show_source_content): Don't declare.
3066 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3067 (tui_source_window_base::show_source_content): Rename from
3068 tui_show_source_content.
3069 (tui_source_window_base::refresh_all): Update.
3070 * tui/tui-layout.c (show_source_disasm_command)
3071 (show_source_or_disasm_and_command): Update.
3073 2019-08-13 Tom Tromey <tom@tromey.com>
3075 * tui/tui-winsource.c (tui_erase_source_content)
3076 (tui_show_source_content, tui_source_window_base::refresh_all):
3078 * tui/tui-wingeneral.h
3079 (tui_check_and_display_highlight_if_needed): Don't declare.
3080 * tui/tui-wingeneral.c
3081 (tui_win_info::check_and_display_highlight_if_needed): Rename from
3082 check_and_display_highlight_if_needed.
3083 * tui/tui-win.c (tui_rehighlight_all)
3084 (tui_win_info::make_visible_with_new_height): Update.
3085 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3086 (tui_data_window::erase_data_content)
3087 (tui_data_window::display_all_data): Update.
3088 * tui/tui-data.h (struct tui_win_info)
3089 <check_and_display_highlight_if_needed>: Declare.
3091 2019-08-13 Tom Tromey <tom@tromey.com>
3093 * tui/tui-win.c (tui_resize_all): Call
3094 tui_delete_invisible_windows.
3095 * tui/tui-layout.c (show_layout): Call
3096 tui_delete_invisible_windows.
3097 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3098 * tui/tui-data.c (tui_delete_invisible_windows): New function.
3100 2019-08-13 Tom Tromey <tom@tromey.com>
3102 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
3103 tui_add_win_to_layout.
3105 2019-08-13 Tom Tromey <tom@tromey.com>
3107 * tui/tui-layout.h (tui_default_win_height): Don't declare.
3108 * tui/tui-layout.c (tui_default_win_height): Now static.
3110 2019-08-13 Tom Tromey <tom@tromey.com>
3112 * tui/tui-layout.c (show_layout): Unify all layout cases into a
3114 (show_source_disasm_command, show_source_or_disasm_and_command):
3115 Don't check current layout.
3117 2019-08-13 Tom Tromey <tom@tromey.com>
3119 * tui/tui-wingeneral.c (make_all_visible): Remove.
3120 (tui_make_all_invisible): Simplify.
3121 * tui/tui-layout.c (tui_make_all_invisible): Move from
3122 tui-wingeneral.c; simplify.
3123 (show_layout): Hoist call to tui_make_all_invisible.
3124 (show_data): Don't call tui_make_all_invisible.
3126 2019-08-13 Tom Tromey <tom@tromey.com>
3128 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3129 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3131 2019-08-13 Tom Tromey <tom@tromey.com>
3133 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3135 (show_source_disasm_command, show_data)
3136 (show_source_or_disasm_and_command): Don't use
3137 tui_set_current_layout_to.
3138 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3139 * tui/tui-data.c (current_layout, tui_current_layout): Move to
3141 (tui_set_current_layout_to): Remove.
3143 2019-08-13 Tom Tromey <tom@tromey.com>
3145 * tui/tui-layout.c (tui_set_layout): Update.
3146 * tui/tui-data.h (struct tui_layout_def): Remove.
3147 (tui_layout_def): Don't declare.
3148 * tui/tui-data.c (layout_def): Remove.
3149 (tui_layout_def): Remove.
3151 2019-08-13 Tom Tromey <tom@tromey.com>
3153 * tui/tui-winsource.h (struct tui_source_window_base)
3154 <clear_detail>: No longer "override".
3155 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3156 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3157 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3158 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3160 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3162 2019-08-13 Tom Tromey <tromey@adacore.com>
3164 * tracepoint.c: Don't include readline.h or history.h.
3166 2019-08-12 Tom Tromey <tom@tromey.com>
3168 * configure: Rebuild.
3169 * configure.ac: Check for readline 7.
3170 * NEWS: Mention readline 7 requirement.
3173 2019-08-12 Tom Tromey <tom@tromey.com>
3175 * mingw-hdep.c (gdb_select): Remove readline hack.
3177 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
3179 * blockframe.c (find_pc_partial_function): Set *block to nullptr
3180 when the function fails.
3182 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
3184 * s390-tdep.c (s390_type_align): New function.
3185 (s390_gdbarch_init): Set it as type_align gdbarch method.
3187 2019-08-09 Tom de Vries <tdevries@suse.de>
3190 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3191 pc_low with relocation offset.
3193 2019-08-07 Tom Tromey <tromey@adacore.com>
3195 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3196 (print_frame_args): Update.
3197 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3199 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3200 * frame.h (struct frame_arg): Add initializers.
3201 <error>: Now a unique_xmalloc_ptr.
3203 2019-08-07 Alan Hayward <alan.hayward@arm.com>
3205 * NEWS: Expand the Pointer Authentication entry.
3206 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3207 (aarch64_frame_unmask_lr): ... to this.
3208 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3209 Call aarch64_frame_unmask_lr.
3210 * frame.c (struct frame_info): Add "masked" variable.
3211 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3212 (fprint_frame): Check for masked pc.
3213 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3215 * python/py-framefilter.c (py_print_frame): Check for masked pc.
3216 * stack.c (print_frame): Check for masked pc.
3218 2019-08-06 Tom Tromey <tom@tromey.com>
3220 * stabsread.c (patch_block_stabs, read_one_struct_field)
3221 (read_enum_type): Use obstack_strndup.
3222 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3223 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3224 * dwarf2read.c (guess_full_die_structure_name)
3225 (anonymous_struct_prefix): Use obstack_strndup.
3226 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3227 * c-exp.y (yylex): Use obstack_strndup.
3228 * ada-exp.y (write_object_renaming, write_ambiguous_var)
3229 (write_var_or_type): Use obstack_strndup.
3231 2019-08-06 Tom Tromey <tom@tromey.com>
3233 * symfile.c (reread_symbols): Use obstack_strdup.
3234 * stabsread.c (read_type): Use obstack_strdup.
3235 * gdb_obstack.h (obstack_strdup): New overload.
3236 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3237 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3238 (dwarf2_canonicalize_name): Use obstack_strdup.
3239 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3240 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3243 2019-08-06 Tom Tromey <tom@tromey.com>
3245 * gdb_obstack.h (obstack_strdup): Define.
3246 * gdb_obstack.c (obstack_strdup): Don't define.
3248 2019-08-06 Tom Tromey <tom@tromey.com>
3250 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3252 * typeprint.c (typedef_hash_table::find_global_typedef): Use
3254 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3255 * stabsread.c (common_block_start): Use obstack_strdup.
3256 * objfiles.c (set_objfile_main_name, objfile): Use
3258 * namespace.c (add_using_directive): Use obstack_strdup.
3259 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3260 * jit.c (finalize_symtab): Use obstack_strdup.
3261 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3262 (guess_partial_die_structure_name, partial_die_info::fixup)
3263 (dwarf2_name): Use obstack_strdup.
3264 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3266 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3267 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3269 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3271 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3273 * unittests/help-doc-selftests.c: New file.
3274 * Makefile.in: Add the new file.
3276 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3278 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3279 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
3280 the full first line, except when FOR_VALUE_PREFIX. In this case,
3281 the trailing '.' is not output, and the first character is uppercased.
3282 (print_help_for_command): Update call to print_doc_line.
3283 (print_doc_of_command): Likewise.
3284 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3285 * cli/cli-option.c (append_indented_doc): Do not append newline.
3286 (build_help_option): Append newline after first appended_indented_doc
3287 only if a second call is done.
3288 (build_help): Append 2 new lines before each option, except the first
3290 * compile/compile.c (_initialize_compile): Add new lines after
3291 %OPTIONS%, when not at the end of the help.
3292 Change help doc or code
3293 producing the help doc to respect the invariants.
3294 * maint-test-options.c (_initialize_maint_test_options): Likewise.
3295 Also removed the new line after 'Options:', as all other commands
3296 do not put an empty line between 'Options:' and the first option.
3297 * printcmd.c (_initialize_printcmd): Likewise.
3298 * stack.c (_initialize_stack): Likewise.
3299 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3300 incorrectly telling COMMAND is optional.
3301 * ada-lang.c (_initialize_ada_language): Change help doc or code
3302 producing the help doc to respect the invariants.
3303 * ada-tasks.c (_initialize_ada_tasks): Likewise.
3304 * breakpoint.c (_initialize_breakpoint): Likewise.
3305 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3306 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3307 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3308 * cli/cli-style.c (cli_style_option::add_setshow_commands,
3309 _initialize_cli_style): Likewise.
3310 * corelow.c (core_target_info): Likewise.
3311 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3312 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3313 * filesystem.c (_initialize_filesystem): Likewise.
3314 * frame.c (_initialize_frame): Likewise.
3315 * gnu-nat.c (add_task_commands): Likewise.
3316 * infcall.c (_initialize_infcall): Likewise.
3317 * infcmd.c (_initialize_infcmd): Likewise.
3318 * interps.c (_initialize_interpreter): Likewise.
3319 * language.c (_initialize_language): Likewise.
3320 * linux-fork.c (_initialize_linux_fork): Likewise.
3321 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3322 * maint.c (_initialize_maint_cmds): Likewise.
3323 * memattr.c (_initialize_mem): Likewise.
3324 * printcmd.c (_initialize_printcmd): Likewise.
3325 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3327 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3328 * record-btrace.c (_initialize_record_btrace): Likewise.
3329 * record-full.c (_initialize_record_full): Likewise.
3330 * record.c (_initialize_record): Likewise.
3331 * regcache-dump.c (_initialize_regcache_dump): Likewise.
3332 * regcache.c (_initialize_regcache): Likewise.
3333 * remote.c (add_packet_config_cmd, init_remote_threadtests,
3334 _initialize_remote): Likewise.
3335 * ser-tcp.c (_initialize_ser_tcp): Likewise.
3336 * serial.c (_initialize_serial): Likewise.
3337 * skip.c (_initialize_step_skip): Likewise.
3338 * source.c (_initialize_source): Likewise.
3339 * stack.c (_initialize_stack): Likewise.
3340 * symfile.c (_initialize_symfile): Likewise.
3341 * symtab.c (_initialize_symtab): Likewise.
3342 * target-descriptions.c (_initialize_target_descriptions): Likewise.
3343 * top.c (init_main): Likewise.
3344 * tracefile-tfile.c (tfile_target_info): Likewise.
3345 * tracepoint.c (_initialize_tracepoint): Likewise.
3346 * tui/tui-win.c (_initialize_tui_win): Likewise.
3347 * utils.c (add_internal_problem_command): Likewise.
3348 * valprint.c (value_print_option_defs): Likewise.
3350 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
3353 * configure.ac: Drop enable-libmcheck support.
3354 * configure, config.in: Rebuild.
3355 * libmcheck.m4: Remove.
3356 * acinclude.m4: Don't include it.
3357 * Makefile.in: Don't distribute it.
3358 * top.c (print_gdb_configuration): Don't mention it.
3360 2019-08-06 Tom Tromey <tom@tromey.com>
3362 * utils.c (set_output_style): Sometimes pass stream to
3364 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3365 * record-btrace.c (btrace_insn_history): Update.
3366 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3368 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3369 Update initializers.
3370 <m_uiout>: New field.
3372 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3373 Remove "uiout" parameter.
3374 (dump_insns): Update.
3375 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3376 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3378 2019-08-06 Christian Biesinger <cbiesinger@google.com>
3380 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3381 (error_in_psymtab_expansion): Likewise.
3382 (lookup_symbol_via_quick_fns): Likewise.
3383 (basic_lookup_transparent_type_quick): Likewise.
3384 (basic_lookup_transparent_type_1): Likewise.
3386 2019-08-06 Tom Tromey <tromey@adacore.com>
3388 * source.c (last_source_error): Now bool.
3389 (print_source_lines_base): Make "noprint" bool. Only open
3390 source file when last_source_visited changes.
3392 2019-08-06 Tom Tromey <tromey@adacore.com>
3394 * annotate.c (annotate_source_line): Use g_source_cache.
3395 * source-cache.c (source_cache::get_plain_source_lines): Change
3396 parameters. Populate m_offset_cache.
3397 (source_cache::ensure): New method.
3398 (source_cache::get_line_charpos): New method.
3399 (extract_lines): Move lower. Change parameters.
3400 (source_cache::get_source_lines): Move lower.
3401 * source-cache.h (class source_cache): Update comment.
3402 <get_line_charpos>: New method.
3403 <get_source_lines>: Update comment.
3404 <clear>: Clear m_offset_cache.
3405 <get_plain_source_lines>: Change parameters.
3406 <ensure>: New method
3407 <m_offset_cache>: New member.
3408 * source.c (forget_cached_source_info_for_objfile): Update.
3409 (info_source_command): Use g_source_cache.
3410 (find_source_lines, open_source_file_with_line_charpos): Remove.
3411 (print_source_lines_base, search_command_helper): Use g_source_cache.
3412 * source.h (open_source_file_with_line_charpos): Don't declare.
3413 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3414 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3417 2019-08-06 Tom Tromey <tromey@adacore.com>
3419 * source-cache.c (source_cache::get_plain_source_lines):
3420 Remove "first_line" and "last_line" parameters.
3421 (source_cache::get_source_lines): Cache plain text.
3422 * source-cache.h (class source_cache)
3423 <get_plain_source_lines>: Update.
3425 2019-08-06 Tom Tromey <tromey@adacore.com>
3427 * source-cache.c (extract_lines): No longer a method.
3428 Changed type of parameter. Include final newline.
3429 (selftests::extract_lines_test): New function.
3430 (_initialize_source_cache): Likewise.
3431 * source-cache.h (class source_cache)
3432 <extract_lines>: Don't declare.
3434 2019-08-06 Tom Tromey <tromey@adacore.com>
3436 * breakpoint.c (init_breakpoint_sal): Update.
3437 (breakpoint): Update.
3438 * breakpoint.h (struct breakpoint) <filter>: Now a
3441 2019-08-05 Christian Biesinger <cbiesinger@google.com>
3443 * NEWS: Mention dictionary access on blocks.
3444 * python/py-block.c (blpy_getitem): New function.
3445 (block_object_as_mapping): New struct.
3446 (block_object_type): Use new struct for tp_as_mapping field.
3448 2019-08-05 Christian Biesinger <cbiesinger@google.com>
3450 * objfiles.h (objfile): Add a comment describing partial symbols.
3452 2019-08-05 Tom Tromey <tromey@adacore.com>
3454 * compile/compile.c (_initialize_compile): Use _(), not N_().
3455 * thread.c (_initialize_thread): Use _(), not N_().
3456 * stack.c (_initialize_stack): Use _(), not N_().
3457 * printcmd.c (_initialize_printcmd): Use _(), not N_().
3459 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
3461 * dwarf2read.c (struct dw2_symtab_iterator):
3462 <want_specific_block>: Remove.
3463 <block_index>: Change type to gdb::optional.
3464 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3465 change type of BLOCK_INDEX parameter to gdb::optional.
3466 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3467 (dw2_lookup_symbol): Don't pass argument for
3468 WANT_SPECIFIC_BLOCK.
3469 (dw2_expand_symtabs_for_function): Don't pass argument for
3470 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3471 (class dw2_debug_names_iterator)
3472 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3473 parameter, change BLOCK_INDEX type to gdb::optional.
3474 <m_want_specific_block>: Remove.
3475 <m_block_index>: Change type to gdb::optional.
3476 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3477 gdb::optional. Re-write in function of gdb::optional.
3478 (dw2_debug_names_lookup_symbol): Don't pass argument for
3479 WANT_SPECIFIC_BLOCK.
3480 (dw2_debug_names_expand_symtabs_for_function): Don't pass
3481 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3484 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3486 * NEWS: Mention changes to "info sources" command.
3488 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3490 * symtab.c (filename_partial_match_opts): New struct type.
3491 (struct output_source_filename_data): New members
3492 regexp, c_regexp, partial_match.
3493 (output_source_filename): Use new members to decide to print file.
3494 (info_sources_option_defs): New variable.
3495 (make_info_sources_options_def_group, print_info_sources_header,
3496 info_sources_command_completer):
3498 (info_sources_command): Read new optional arguments.
3499 (_initialize_symtab): Update info sources help.
3501 2019-08-02 Alexandre Oliva <oliva@adacore.com>
3503 * ada-lang.c (exception_support_info_v0): Renamed from...
3504 (default_exception_support_info): ... this. Create new
3506 (ada_has_this_exception_support): Look up catch_handlers_sym.
3507 (ada_exception_support_info_sniffer): Try v0 after default.
3509 2019-08-01 Tom Tromey <tromey@adacore.com>
3511 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3514 2019-08-01 Christian Biesinger <cbiesinger@google.com>
3516 * s12z-tdep.c: Fix include path for s12z-opc.h.
3518 2019-08-01 Alan Hayward <alan.hayward@arm.com>
3520 * NEWS: Require GNU make 3.82.
3522 2019-07-16 Tom Tromey <tom@tromey.com>
3524 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3527 2019-07-30 Tom Tromey <tromey@adacore.com>
3529 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3531 2019-07-30 Kevin Buettner <kevinb@redhat.com>
3533 * printcmd.c (print_address_symbolic): Print negative offsets.
3534 (build_address_symbolic): Force signed arithmetic when computing
3537 2019-07-30 Christian Biesinger <cbiesinger@google.com>
3539 PR/24474: Add a function to lookup static variables.
3540 * NEWS: Mention this new function.
3541 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3542 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3543 * python/python.c (python_GdbMethods): Add new function.
3545 2019-07-29 Christian Biesinger <cbiesinger@google.com>
3547 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3548 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3549 (objfpy_lookup_static_symbol): New function.
3550 (objfile_object_methods): Add new functions.
3552 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3554 * NEWS: Mention 'set|show print frame-info'. Mention new
3555 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3556 backtrace argument. Mention that python frame filtering code
3557 is now consistent with what 'backtrace' command prints.
3559 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3561 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3563 (print_frame_info_auto, print_frame_info_source_line,
3564 print_frame_info_location, print_frame_info_source_and_location,
3565 print_frame_info_location_and_address, print_frame_info_short_location):
3567 (struct frame_print_options): New member print_frame_info.
3568 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3569 * stack.h (get_user_print_what_frame_info): New declaration.
3570 (frame_show_address): New declaration.
3571 * stack.c (print_frame_arguments_choices): New value 'presence'.
3572 (print_frame_info_auto, print_frame_info_source_line,
3573 print_frame_info_location, print_frame_info_source_and_location,
3574 print_frame_info_location_and_address, print_frame_info_short_location,
3575 print_frame_info_choices, print_frame_info_print_what): New definitions.
3576 (print_frame_args): Only print dots for args if print frame-arguments
3578 (frame_print_option_defs): New element for "frame-info".
3579 (get_user_print_what_frame_info): New function.
3580 (frame_show_address): Make non static. Move comment to stack.h.
3581 (print_frame_info_to_print_what): New function.
3582 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3583 to decide what to print.
3584 (backtrace_command_1): Handle the new print_frame_arguments_presence
3586 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3587 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3588 (py_print_frame): In non-mi mode, use LOCATION as default for
3589 print_what, similarly to frame information printed directly by
3590 backtrace command. Handle frame-info user option in non MI mode.
3592 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3594 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3595 Add case for debugging 32-bit target on 64-bit host. Revise
3598 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3600 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3601 instead of find_function_entry_range_from_pc.
3603 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3605 * stack.c (find_frame_funname): Remove code which preferred
3606 minsym over symtab sym in "certain pathological cases".
3608 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3609 parameter. Change type of "do_demangle" to bool.
3610 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3611 Pass suitable "prefer_sym_over_minsym" flag to
3612 build_address_symbolic(). Don't output "+" for negative offsets.
3613 * printcmd.c (print_address_symbolic): Update invocation of
3614 build_address_symbolic to include a "prefer_sym_over_minsym"
3616 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3617 Restrict cases in which use of minimal symbol is preferred to that
3618 of a found symbol. Update comments.
3620 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3621 for entry pc when entry pc is out of range for that FDE.
3623 2019-07-26 Brian Callahan <bcallah@openbsd.org>
3626 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3629 2019-07-25 Christian Biesinger <cbiesinger@google.com>
3631 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3632 this function's Python signature.
3635 2019-07-24 Christian Biesinger <cbiesinger@google.com>
3637 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3638 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3639 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3640 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3641 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3644 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3646 * h8300-tdep.c (h8300_register_name_common): New.
3647 h8300_register_name): Use h8300_register_name_common.
3648 (h8300s_register_name): Likewise.
3649 (h8300sx_register_name): Likewise.
3650 (h8300h_register_nam): New.
3651 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3654 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3656 * arm-tdep.c (arm_skip_cmse_entry): New function.
3657 (arm_is_sgstubs_section): New function.
3658 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3660 2019-07-22 Tom Tromey <tom@tromey.com>
3662 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3665 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3667 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3670 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3672 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3673 so that GDB doesn't match any msymbols when searching in the
3675 (print_symbol_info): Print using typedef_print or type_print based
3676 on the type of the symbol. Add updated FIXME comment moved from...
3677 (_initialize_symtab): ... move and update FIXME comment to above.
3679 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3681 * NEWS: Mention adding -q option to "info types".
3682 * symtab.c (struct info_types_options): New struct.
3683 (info_types_options_defs): New variable.
3684 (make_info_types_options_def_group): New function.
3685 (info_types_command): Use gdb::option framework to parse options.
3686 (info_types_command_completer): New function.
3687 (_initialize_symtab): Extend the help text on "info types" and
3688 register command completer.
3690 2019-07-21 Christian Biesinger <cbiesinger@google.com>
3692 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3693 (lookup_symbol_in_objfile): Change int to block_enum and add a
3694 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3696 2019-07-20 Christian Biesinger <cbiesinger@google.com>
3698 * MAINTAINERS (Write After Approval): Add self.
3700 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3702 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3703 instruction to the dummy code region.
3705 2019-07-19 Tom Tromey <tromey@adacore.com>
3707 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3708 (ARGSUSED, PARAMS, __func__): Remove rules.
3710 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3712 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3713 * features/arm/arm-with-iwmmxt.c: Remove.
3714 * features/arm/arm-with-iwmmxt.xml: Remove.
3715 * features/arm/arm-with-m-fpa-layout.c: Remove.
3716 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3717 * features/arm/arm-with-m-vfp-d16.c: Remove.
3718 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3719 * features/arm/arm-with-m.c: Remove.
3720 * features/arm/arm-with-m.xml: Remove.
3721 * features/arm/arm-with-neon.c: Remove.
3722 * features/arm/arm-with-neon.xml: Remove.
3723 * features/arm/arm-with-vfpv2.c: Remove.
3724 * features/arm/arm-with-vfpv2.xml: Remove.
3725 * features/arm/arm-with-vfpv3.c: Remove.
3726 * features/arm/arm-with-vfpv3.xml: Remove.
3728 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3730 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3732 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3734 * arch/aarch32.c (aarch32_create_target_description): Create
3735 target descriptions using features.
3736 * arch/arm.c (arm_create_target_description)
3737 (arm_create_mprofile_target_description): Likewise.
3738 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3740 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3742 * Makefile.in: Add new files.
3743 * aarch32-tdep.c: New file.
3744 * aarch32-tdep.h: New file.
3745 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3746 Call aarch32_read_description.
3747 * arch/aarch32.c: New file.
3748 * arch/aarch32.h: New file.
3749 * arch/arm.c (arm_create_target_description)
3750 (arm_create_mprofile_target_description): New function.
3751 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3752 (arm_create_target_description)
3753 (arm_create_mprofile_target_description): New declaration.
3754 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3755 read_description functions.
3756 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3758 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3759 * arm-tdep.c (tdesc_arm_list): New variable.
3760 (arm_register_g_packet_guesses): Call create description functions.
3761 (arm_read_description) (arm_read_mprofile_description): New
3763 * arm-tdep.h (arm_read_description)
3764 (arm_read_mprofile_description): Add declaration.
3765 * configure.tgt: Add new files.
3767 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3769 * top.c (new_ui_command): Open specified terminal just once.
3771 2019-07-18 Tom Tromey <tromey@adacore.com>
3773 * symtab.c (main_name): Constify return type.
3774 * symfile.c (set_initial_language): Update.
3775 * symtab.h (main_name): Constify return type.
3777 2019-07-17 Tom Tromey <tom@tromey.com>
3779 * tui/tui-winsource.c (tui_update_source_window)
3780 (tui_update_source_window_as_is)
3781 (tui_update_source_windows_with_line): Remove return.
3782 * tui/tui-disasm.c (tui_show_disassem)
3783 (tui_show_disassem_and_update_source): Remove return.
3784 * tui/tui.c (tui_reset): Remove return.
3785 * tui/tui-wingeneral.c
3786 (tui_check_and_display_highlight_if_needed): Remove return.
3788 2019-07-17 Tom Tromey <tom@tromey.com>
3790 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3792 2019-07-17 Tom Tromey <tom@tromey.com>
3794 * tui/tui-winsource.h (struct tui_exec_info_window)
3795 (struct tui_source_window_base): Move from tui-data.h.
3796 * tui/tui-winsource.c: Move many method definitions from
3797 elsewhere. Remove "structuring" comments.
3798 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3799 (tui_source_window_base::refresh_window): Move to
3801 * tui/tui-win.c (tui_source_window_base::refresh_all)
3802 (tui_source_window_base::update_tab_width)
3803 (tui_source_window_base::set_new_height)
3804 (tui_source_window_base::do_make_visible_with_new_height): Move to
3806 * tui/tui-source.h: Update.
3807 * tui/tui-source.c (tui_source_window_base::reset): Move to
3809 * tui/tui-disasm.h: Update.
3810 * tui/tui-data.h (struct tui_exec_info_window): Move to
3812 (struct tui_source_window_base): Likewise.
3813 * tui/tui-data.c (tui_source_window_base::clear_detail)
3814 (tui_source_window_base, ~tui_source_window_base): Move to
3817 2019-07-17 Tom Tromey <tom@tromey.com>
3819 * tui/tui-win.c (tui_resize_all)
3820 (tui_source_window_base::update_tab_width)
3821 (tui_adjust_win_heights): Update.
3822 (tui_win_info::make_invisible_and_set_new_height): Rename from
3823 make_invisible_and_set_new_height.
3824 * tui/tui-data.h (struct tui_win_info)
3825 <make_invisible_and_set_new_height>: New method.
3827 2019-07-17 Tom Tromey <tom@tromey.com>
3829 * tui/tui.c: Update.
3830 * tui/tui-source.h (struct tui_source_window): Move from
3832 * tui/tui-layout.c: Update.
3833 * tui/tui-disasm.c: Update.
3834 * tui/tui-data.h (struct tui_source_window): Move to
3837 2019-07-17 Tom Tromey <tom@tromey.com>
3839 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3841 * tui/tui-data.h (struct tui_disasm_window): Move to
3844 2019-07-17 Tom Tromey <tom@tromey.com>
3846 * tui/tui-regs.h (struct tui_data_item_window): Move from
3848 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3849 * tui/tui-data.h (struct tui_data_item_window): Move to
3851 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3853 2019-07-17 Tom Tromey <tom@tromey.com>
3855 * tui/tui.c: Update.
3856 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3857 (tui_cmd_window::max_height): Move to tui-command.c.
3858 * tui/tui-layout.c: Update.
3859 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3860 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3862 * tui/tui-command.h (struct tui_cmd_window): Move from
3864 * tui/tui-command.c: Remove "structuring" comments.
3865 (tui_cmd_window::clear_detail)
3866 (tui_cmd_window::do_make_visible_with_new_height)
3867 (tui_cmd_window::max_height): Move from elsewhere.
3869 2019-07-17 Tom Tromey <tom@tromey.com>
3871 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3873 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3874 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3876 2019-07-17 Tom Tromey <tom@tromey.com>
3878 * tui/tui.c: Update.
3879 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3881 * tui/tui-windata.h: Remove file.
3882 * tui/tui-windata.c: Remove file.
3883 * tui/tui-win.c (tui_data_window::set_new_height)
3884 (tui_data_window::do_make_visible_with_new_height): Move to
3886 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3887 * tui/tui-regs.c: Remove "structuring" comments.
3888 (tui_data_window::first_data_item_displayed)
3889 (tui_data_window::delete_data_content_windows)
3890 (tui_data_window::erase_data_content)
3891 (tui_data_window::display_all_data)
3892 (tui_data_window::refresh_all)
3893 (tui_data_window::do_scroll_vertical)
3894 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3895 (tui_data_window::do_make_visible_with_new_height)
3896 (tui_data_window::refresh_window): Move from elsewhere.
3897 (_initialize_tui_regs): Move to end of file.
3898 * tui/tui-layout.c: Update.
3899 * tui/tui-hooks.c: Update.
3900 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3901 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3903 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3905 2019-07-17 Tom Tromey <tom@tromey.com>
3907 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3910 2019-07-17 Tom Tromey <tom@tromey.com>
3912 * tui/tui-win.c (tui_source_window_base::set_new_height)
3913 (tui_source_window_base::do_make_visible_with_new_height): Use
3914 m_has_locator field directly.
3915 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3917 (struct tui_source_window_base) <has_locator>: Likewise.
3919 2019-07-17 Tom Tromey <tom@tromey.com>
3921 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3923 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3925 * tui/tui-win.c (tui_source_window_base::set_new_height)
3926 (tui_source_window_base::set_new_height)
3927 (make_invisible_and_set_new_height)
3928 (tui_source_window_base::do_make_visible_with_new_height)
3929 (tui_source_window_base::do_make_visible_with_new_height):
3931 * tui/tui-layout.c (show_source_disasm_command, show_data)
3932 (show_source_or_disasm_and_command): Update.
3933 * tui/tui-layout.c (show_layout): Update.
3935 2019-07-17 Tom Tromey <tom@tromey.com>
3937 * tui/tui-layout.c (make_data_window): Remove.
3938 (show_data): Unify creation and re-initialization cases.
3940 2019-07-17 Tom Tromey <tom@tromey.com>
3942 * tui/tui-layout.c (make_source_window, make_disasm_window):
3944 (show_data): Unify creation and re-initialization cases.
3946 2019-07-17 Tom Tromey <tom@tromey.com>
3948 * tui/tui-layout.c (make_command_window): Remove.
3949 (show_source_disasm_command, show_source_or_disasm_and_command):
3950 Unify creation and re-initialization cases.
3952 2019-07-17 Tom Tromey <tom@tromey.com>
3954 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3955 creation and re-initialization cases.
3957 2019-07-17 Tom Tromey <tom@tromey.com>
3959 * tui/tui-regs.c (tui_get_register): Return void.
3961 2019-07-17 Tom Tromey <tom@tromey.com>
3963 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3966 2019-07-17 Tom Tromey <tom@tromey.com>
3968 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3971 2019-07-17 Tom Tromey <tom@tromey.com>
3973 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3974 * tui/tui-regs.c (tui_reg_layout): New function.
3975 (tui_show_registers, tui_reg_command): Use it.
3976 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3977 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3979 (tui_layout_command): Remove.
3981 2019-07-17 Tom Tromey <tom@tromey.com>
3983 * tui/tui-layout.h (tui/tui-layout): Return void.
3984 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3986 2019-07-17 Tom Tromey <tom@tromey.com>
3988 * tui/tui-layout.c (show_source_disasm_command, show_data):
3990 (reset_locator): Remove.
3991 (show_source_or_disasm_and_command): Update.
3993 2019-07-17 Tom Tromey <tom@tromey.com>
3995 * tui/tui-source.c (tui_source_window_base::reset): Remove
3997 * tui/tui-layout.c (make_command_window, make_source_window)
3998 (make_disasm_window, make_data_window)
3999 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4000 (reset_locator, show_source_or_disasm_and_command): Update.
4001 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4003 (struct tui_source_window_base) <reset>: Likewise.
4005 2019-07-17 Tom Tromey <tom@tromey.com>
4007 * tui/tui-layout.c (show_source_disasm_command): Use
4009 (reset_locator): New function.
4010 (init_and_make_win): Remove.
4011 (show_source_or_disasm_and_command): Use reset_locator.
4013 2019-07-17 Tom Tromey <tom@tromey.com>
4015 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4017 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4019 * tui/tui-source.c (tui_source_window_base::reset): New method.
4020 * tui/tui-layout.c (make_command_window): Don't call
4022 (make_source_window, make_disasm_window): Don't call
4023 make_source_or_disasm_window.
4024 (make_data_window): Don't call init_and_make_win. Change calling
4026 (show_source_disasm_command, show_data): Simplify.
4027 (make_source_or_disasm_window): Remove.
4028 (show_source_or_disasm_and_command): Simplify.
4029 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4030 (struct tui_source_window_base) <reset>: Likewise.
4031 <execution_info>: Remove initializer.
4032 * tui/tui-data.c (tui_source_window_base): Initialize
4035 2019-07-17 Tom Tromey <tom@tromey.com>
4037 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4040 2019-07-17 Tom Tromey <tom@tromey.com>
4042 * tui/tui.c (tui_rl_other_window): Update.
4043 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4044 superclass method first. Always iterate over regs_content.
4045 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4047 * tui/tui-win.c (tui_set_focus_command): Update.
4049 2019-07-17 Tom Tromey <tom@tromey.com>
4051 * tui/tui-win.c (tui_set_focus_command): Rename from
4052 tui_set_focus. Call tui_enable.
4053 (tui_set_focus_command): Remove.
4055 2019-07-17 Tom Tromey <tom@tromey.com>
4057 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4059 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4061 (tui_data_window::refresh_window): Call refresh_window on data
4062 items. Always call superclass refresh_window.
4063 (tui_win_info::refresh): Remove.
4064 (tui_source_window_base::refresh_window): Update.
4065 (tui_refresh_all): Update.
4066 * tui/tui-layout.c (show_source_disasm_command): Remove call to
4068 (show_source_or_disasm_and_command): Likewise.
4069 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4070 (struct tui_source_window_base) <refresh>: Likewise.
4072 2019-07-17 Tom Tromey <tom@tromey.com>
4074 * tui/tui-winsource.c (tui_clear_source_content)
4075 (tui_show_source_content): Update.
4076 * tui/tui-source.c (tui_source_window::showing_source_p): Check
4077 whether content is empty.
4078 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4081 2019-07-17 Tom Tromey <tom@tromey.com>
4083 * tui/tui-winsource.c (tui_erase_source_content): Clear the
4085 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4086 * tui/tui-source.c (tui_set_source_content_nil): Remove.
4088 2019-07-17 Tom Tromey <tom@tromey.com>
4090 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4091 (struct tui_data_item_window): Update.
4093 2019-07-17 Tom Tromey <tom@tromey.com>
4095 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4096 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4099 2019-07-17 Tom Tromey <tom@tromey.com>
4101 * tui/tui-winsource.h (tui_erase_source_content)
4102 (tui_clear_source_content): Remove "display_prompt" parameter.
4103 * tui/tui-winsource.c (tui_update_source_window_as_is)
4104 (tui_update_source_windows_with_addr): Update.
4105 (tui_clear_source_content): Remove "display_prompt" parameter.
4106 (tui_erase_source_content): Likewise. Simplify.
4107 (tui_show_source_content): Update.
4108 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4109 * tui/tui-stack.c (tui_show_frame_info): Update.
4110 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4113 2019-07-17 Tom Tromey <tom@tromey.com>
4115 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4116 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4118 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4121 2019-07-17 Tom Tromey <tom@tromey.com>
4123 * tui/tui-winsource.c (tui_clear_source_content)
4124 (tui_show_source_content, tui_show_exec_info_content)
4125 (tui_clear_exec_info_content): Update.
4126 * tui/tui-stack.c (tui_show_locator_content): Update.
4127 (tui_show_frame_info): Update.
4128 * tui/tui-source.h (tui_source_window): Don't declare.
4129 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4130 from tui_source_is_displayed.
4131 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4133 (struct tui_source_window_base) <content_in_use>: New field. Now
4135 (struct tui_source_window) <showing_source_p>: New method.
4136 (TUI_SRC_WIN): Change cast.
4137 * tui/tui-data.c (tui_initialize_static_data): Update.
4139 2019-07-17 Tom Tromey <tom@tromey.com>
4141 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4143 * tui/tui-source.c (tui_source_window::location_matches_p): New
4145 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4147 * tui/tui-data.h (struct tui_source_window_base)
4148 <location_matches_p>: New method.
4149 (struct tui_source_window, struct tui_disasm_window)
4150 <location_matches_p>: Likewise.
4152 2019-07-17 Tom Tromey <tom@tromey.com>
4154 * tui/tui-win.c (tui_set_win_height_command): Rename from
4156 (tui_set_win_height_command): Remove.
4158 2019-07-17 Tom Tromey <tom@tromey.com>
4160 * tui/tui-source.c (tui_source_window): New constructor. Add
4162 (~tui_source_window): New destructor.
4163 (tui_source_window::style_changed): New method.
4164 * tui/tui-hooks.c (tui_redisplay_source): Remove.
4165 (tui_attach_detach_observers): Update.
4166 * tui/tui-data.h (struct tui_source_window): Make constructor not
4167 inline. Add destructor.
4168 (struct tui_source_window) <style_changed>: New method.
4169 <m_observable>: New member.
4171 2019-07-17 Tom Tromey <tom@tromey.com>
4173 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4174 * tui/tui-win.c (tui_resize_all): Fix typo.
4176 2019-07-17 Tom Tromey <tom@tromey.com>
4178 * tui/tui-wingeneral.h (tui_refresh_all): Update.
4179 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4180 (tui_refresh_all): Remove "list" parameter. Use foreach.
4181 * tui/tui-win.c (window_name_completer): Use foreach.
4182 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4183 (update_tab_width): Likewise.
4184 * tui/tui-layout.c (show_layout): Update.
4185 * tui/tui-data.h (class tui_window_iterator): New.
4186 (struct all_tui_windows): New.
4187 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4189 2019-07-17 Tom Tromey <tom@tromey.com>
4191 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4192 parameter. Don't reference globals.
4193 (tui_reg_command): Update.
4195 2019-07-17 Tom Tromey <tom@tromey.com>
4197 * tui/tui-regs.c (tui_show_registers): Simplify.
4199 2019-07-17 Tom Tromey <tom@tromey.com>
4201 * tui/tui-regs.c (tui_show_registers): Update.
4202 (tui_show_register_group): Add win_info parameter.
4204 2019-07-17 Tom Tromey <tom@tromey.com>
4206 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4207 Rename from tui_display_reg_element_at_line.
4208 (tui_data_window::display_registers_from_line): Update.
4209 * tui/tui-data.h (struct tui_data_window)
4210 <display_reg_element_at_line>: New method.
4212 2019-07-17 Tom Tromey <tom@tromey.com>
4214 * tui/tui-regs.h (tui_display_registers_from)
4215 (tui_display_registers_from_line): Don't declare.
4216 * tui/tui-windata.c (tui_data_window::display_all_data)
4217 (tui_data_window::refresh_all)
4218 (tui_data_window::do_scroll_vertical): Update.
4219 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4220 from tui_display_registers_from.
4221 (tui_display_reg_element_at_line): Update.
4222 (tui_data_window::display_registers_from_line): Rename from
4223 tui_display_registers_from_line.
4224 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4225 display_registers_from_line>: New methods.
4227 2019-07-17 Tom Tromey <tom@tromey.com>
4229 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4230 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4231 from tui_erase_data_content.
4232 (tui_data_window::display_all_data)
4233 (tui_data_window::refresh_all)
4234 (tui_data_window::do_scroll_vertical): Update.
4235 * tui/tui-regs.c (tui_show_registers): Update.
4236 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4239 2019-07-17 Tom Tromey <tom@tromey.com>
4241 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4244 (tui_data_window::delete_data_content_windows): Rename from
4245 tui_delete_data_content_windows.
4246 (tui_data_window::display_all_data)
4247 (tui_data_window::do_scroll_vertical): Update.
4248 * tui/tui-data.h (struct tui_data_window)
4249 <delete_data_content_windows>: New method.
4251 2019-07-17 Tom Tromey <tom@tromey.com>
4253 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4254 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4256 2019-07-17 Tom Tromey <tom@tromey.com>
4258 * tui/tui-windata.h (tui_display_all_data): Don't declare.
4259 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4260 from tui_display_all_data.
4262 (tui_data_window::do_make_visible_with_new_height): Update.
4263 * tui/tui-regs.c (tui_show_registers): Update.
4264 * tui/tui-layout.c (tui_set_layout): Update.
4265 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4268 2019-07-17 Tom Tromey <tom@tromey.com>
4270 * tui/tui-windata.h (tui_display_data_from): Don't declare.
4271 * tui/tui-windata.c (tui_display_data_from): Remove.
4272 (tui_data_window::refresh_all): Update.
4274 2019-07-17 Tom Tromey <tom@tromey.com>
4276 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4277 * tui/tui-windata.c (tui_display_data_from_line): Remove.
4278 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4279 tui_display_registers_from_line.
4280 * tui/tui-regs.h (tui_display_registers_from_line): Update.
4281 * tui/tui-regs.c (tui_display_registers_from_line): Remove
4282 "force_display" parameter.
4284 2019-07-17 Tom Tromey <tom@tromey.com>
4286 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4288 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4289 Rename from tui_first_reg_element_no_inline.
4290 (tui_display_reg_element_at_line)
4291 (tui_display_registers_from_line): Update.
4292 * tui/tui-data.h (struct tui_data_window)
4293 <first_reg_element_no_inline>: New method.
4295 2019-07-17 Tom Tromey <tom@tromey.com>
4297 * tui/tui-windata.c (tui_display_data_from)
4298 (tui_data_window::do_scroll_vertical): Update.
4299 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4300 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4301 Rename from tui_line_from_reg_element_no.
4302 (tui_display_registers_from_line): Update.
4303 * tui/tui-data.h (struct tui_data_window)
4304 <line_from_reg_element_no>: New method.
4306 2019-07-17 Tom Tromey <tom@tromey.com>
4308 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4309 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4310 tui_last_regs_line_no.
4311 (tui_display_reg_element_at_line)
4312 (tui_display_registers_from_line): Update.
4313 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4316 2019-07-17 Tom Tromey <tom@tromey.com>
4319 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4320 (tui_update_breakpoint_info): Add "being_deleted" parameter.
4321 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4322 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4323 (tui_update_breakpoint_info): Likewise.
4324 * tui/tui-hooks.c (tui_event_create_breakpoint)
4325 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4328 2019-07-17 Tom Tromey <tom@tromey.com>
4330 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4332 2019-07-17 Tom Tromey <tom@tromey.com>
4334 * tui/tui-winsource.c (tui_update_source_window_as_is)
4335 (tui_update_source_windows_with_addr): Update.
4336 * tui/tui-source.h (tui_set_source_content)
4337 (tui_show_symtab_source): Add "win_info" parameter.
4338 * tui/tui-source.c (tui_set_source_content): Add "win_info"
4340 (tui_show_symtab_source): Likewise.
4342 2019-07-17 Tom Tromey <tom@tromey.com>
4344 * tui/tui-wingeneral.c
4345 (tui_check_and_display_highlight_if_needed): Check can_highlight.
4347 2019-07-17 Tom Tromey <tom@tromey.com>
4349 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4350 (struct tui_cmd_window) <can_scroll>: New method.
4351 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4354 2019-07-17 Tom Tromey <tromey@adacore.com>
4356 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4357 do_field_signed>: Rename. Change type of "value".
4358 * ui-out.c (ui_out::field_signed): Rename from field_int.
4359 Change type of "value".
4360 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
4362 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4363 do_field_int. Change type of "value".
4364 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4365 do_field_int. Change type of "value".
4366 * tracepoint.c (trace_status_mi, tfind_1)
4367 (print_one_static_tracepoint_marker): Update.
4368 * thread.c (print_thread_info_1, print_selected_thread_frame):
4370 * stack.c (print_frame, print_frame_info): Update.
4371 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4373 * source.c (print_source_lines_base): Update.
4374 * skip.c (info_skip_command): Update.
4375 * record-btrace.c (btrace_ui_out_decode_error)
4376 (btrace_call_history_src_line): Update.
4377 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4379 * progspace.c (print_program_space): Update.
4380 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4381 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4382 do_field_int. Change type of "value".
4383 * mi/mi-out.c (mi_ui_out::do_table_begin)
4384 (mi_ui_out::do_table_header): Update.
4385 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
4387 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4388 (mi_cmd_data_list_changed_registers, output_register)
4389 (mi_cmd_data_read_memory, mi_load_progress)
4390 (mi_cmd_trace_frame_collected): Update.
4391 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4393 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4394 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4395 (mi_cmd_var_list_children, varobj_update_one): Update.
4396 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4397 (mi_cmd_stack_list_args, list_arg_or_local): Update.
4398 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4399 * inferior.c (print_inferior): Update.
4400 * gdb_bfd.c (print_one_bfd): Update.
4401 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4403 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4404 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4405 do_field_int. Change type of "value".
4406 * cli-out.c (cli_ui_out::do_field_signed): Rename from
4407 do_field_int. Change type of "value".
4408 * breakpoint.c (watchpoint_check, print_breakpoint_location)
4409 (print_one_breakpoint_location, print_it_catch_fork)
4410 (print_one_catch_fork, print_it_catch_vfork)
4411 (print_one_catch_vfork, print_it_catch_solib)
4412 (print_it_catch_exec, print_it_ranged_breakpoint)
4413 (print_mention_watchpoint, print_mention_masked_watchpoint)
4414 (bkpt_print_it, update_static_tracepoint): Update.
4415 * break-catch-throw.c (print_it_exception_catchpoint): Update.
4416 * break-catch-syscall.c (print_it_catch_syscall): Update.
4417 * ada-tasks.c (print_ada_task_info): Update.
4418 * ada-lang.c (print_it_exception, print_mention_exception):
4421 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
4423 PR breakpoints/24541
4424 * gdbarch.c: Regenerate.
4425 * gdbarch.h: Regenerate.
4426 * gdbarch.sh: Adjust return type and parameter types for
4427 'stap_adjust_register'.
4428 (i386_stap_adjust_register): Adjust signature and return new
4430 * stap-probe.c (stap_parse_register_operand): Adjust use of
4431 'gdbarch_stap_adjust_register'.
4433 2019-07-17 Tom Tromey <tromey@adacore.com>
4435 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
4437 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4439 (struct s390_process_info): Add initializers.
4440 (s390_add_process): Use new.
4441 (s390_linux_nat_target::low_forget_process): Use delete.
4442 (s390_linux_nat_target::low_new_fork)
4443 (s390_linux_nat_target::stopped_by_watchpoint)
4444 (s390_linux_nat_target::low_prepare_to_resume)
4445 (s390_linux_nat_target::insert_watchpoint)
4446 (s390_linux_nat_target::insert_hw_breakpoint)
4447 (s390_linux_nat_target::remove_watchpoint)
4448 (s390_linux_nat_target::remove_hw_breakpoint): Update.
4450 2019-07-16 John Baldwin <jhb@FreeBSD.org>
4452 * aarch64-fbsd-nat.c: Include regcache.h.
4453 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4455 (aarch64_fbsd_nat_target::fetch_registers)
4456 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4458 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4460 2019-07-16 John Baldwin <jhb@FreeBSD.org>
4462 * fbsd-nat.c: Include gdbarch.h.
4464 2019-07-15 Tom Tromey <tromey@adacore.com>
4466 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4468 2019-07-15 Tom Tromey <tromey@adacore.com>
4470 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4471 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4472 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4473 * cli-out.c (cli_ui_out::do_field_int): New method.
4474 * ui-out.c (ui_out::field_unsigned): New method.
4475 * symfile.c (generic_load): Use field_unsigned.
4476 (print_transfer_performance): Likewise.
4477 * record-btrace.c (ui_out_field_uint): Remove.
4478 (btrace_call_history_insn_range, btrace_call_history): Use
4480 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4482 * ui-out.h (class ui_out) <field_unsigned>: New method.
4483 <do_field_unsigned>: Likewise.
4485 2019-07-15 Tom Tromey <tromey@adacore.com>
4487 * mi/mi-main.c (list_available_thread_groups): Use field_string.
4488 * mi/mi-interp.c (mi_memory_changed): Use field_string.
4489 * target.c (flash_erase_command): Use field_string.
4490 * infrun.c (print_signal_received_reason): Use field_string.
4491 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4492 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4494 * ada-tasks.c (print_ada_task_info): Use field_string.
4496 2019-07-15 Tom Tromey <tromey@adacore.com>
4498 * target.c (flash_erase_command): Use field_core_addr.
4499 * symfile.c (generic_load): Use field_core_addr.
4500 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4501 Use field_core_addr.
4502 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4505 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4507 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4508 value if its desired type is smaller than a CORE_ADDR and signed.
4510 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4512 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4513 of changes to field names, and use new is_reference field to
4514 decide if a property is a reference or not.
4515 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4517 (struct dwarf2_property_baton): Update header comment, rename
4518 'referenced_type' to 'property_type' and update comments.
4519 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4520 default property type, store in property baton, update to take
4521 accound of renamed field.
4522 (read_func_scope): Update call to attr_to_dynamic_prop.
4523 (read_array_type): Likewise.
4524 (dwarf2_per_cu_addr_sized_int_type): New function.
4525 (read_subrange_index_type): Move type finding code to
4526 dwarf2_per_cu_addr_sized_int_type.
4527 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4528 (dwarf2_per_cu_addr_type): New function.
4529 (set_die_type): Update calls to attr_to_dynamic_prop.
4531 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4533 * dwarf2read.c (read_subrange_index_type): New function.
4534 (read_subrange_type): Move code into new function and call it.
4535 * gdbtypes.c (create_range_type): Add some asserts.
4537 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4539 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4540 update return statements.
4541 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4542 declaration, and update comment to match.
4543 * gdbtypes.c (resolve_dynamic_array): Update call to
4544 dwarf2_evaluate_property to match new return type.
4546 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4548 * valarith.c (value_subscripted_rvalue): Change lowerbound
4549 parameter type from int to LONGEST.
4550 * value.h (value_subscripted_rvalue): Likewise in declaration.
4552 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4554 * cli/cli-utils.c (info_print_command_completer): New function.
4555 * cli/cli-utils.h: Add 'completer.h' include, and forward
4556 declaration for 'struct cmd_list_element'.
4557 (info_print_command_completer): Declare.
4558 * stack.c (_initialize_stack): Add completer for 'info locals' and
4560 * symtab.c (_initialize_symtab): Add completer for 'info
4561 variables' and 'info functions'.
4562 * NEWS: Mention completion for additional info commands.
4564 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4566 * cli/cli-utils.c (extract_info_print_args): Delete.
4567 (extract_arg_maybe_quoted): Delete.
4568 (info_print_options_defs): New variable.
4569 (make_info_print_options_def_group): New function.
4570 (extract_info_print_options): Define new function.
4571 * cli/cli-utils.h (extract_info_print_args): Delete.
4572 (struct info_print_options): New structure.
4573 (extract_info_print_options): Declare new function.
4574 * stack.c (info_locals_command): Update to use new
4575 extract_info_print_options, also add a header comment.
4576 (info_args_command): Likewise.
4577 * symtab.c (info_variables_command): Likewise.
4578 (info_functions_command): Likewise.
4580 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4582 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4583 to extract string arguments.
4584 * common/common-utils.c (extract_string_maybe_quoted): New function.
4585 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4587 2019-07-11 Tom Tromey <tromey@adacore.com>
4589 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4590 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4591 * top.h (gdbinit): Don't declare.
4592 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4594 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4595 * top.c (gdb_init): Don't call init_cli_cmds.
4597 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4599 2019-07-11 Tom Tromey <tromey@adacore.com>
4601 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4602 after it has been moved.
4604 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4606 * valops.c (value_must_coerce_to_target): Change return type to
4608 * value.h (value_must_coerce_to_target): Likewise.
4610 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
4612 * breakpoint.c (is_hardware_watchpoint): Remove
4613 forward-declaration.
4614 (is_masked_watchpoint): Change return type to bool.
4615 (is_tracepoint): Likewise.
4616 (is_breakpoint): Likewise.
4617 (is_hardware_watchpoint): Likewise.
4618 (is_watchpoint): Likewise.
4619 (is_no_memory_software_watchpoint): Likewise.
4620 (is_catchpoint): Likewise.
4621 (breakpoint_1): Make FILTER parameter's return type bool.
4622 is_masked_watchpoint): Change return type to bool.
4623 (save_breakpoints): Make FILTER parameter's return type bool.
4624 * breakpoint.h (is_breakpoint): Change return type to bool.
4625 (is_watchpoint): Likewise.
4626 (is_catchpoint): Likewise.
4627 (is_tracepoint): Likewise.
4629 2019-07-10 Tom Tromey <tom@tromey.com>
4631 * defs.h: Don't include gdbarch.h.
4632 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4633 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4634 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4635 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4636 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4637 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4638 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4639 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4640 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4641 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4642 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4643 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4644 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4645 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4646 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4647 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4648 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4649 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4650 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4651 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4652 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4653 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4654 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4655 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4656 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4657 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4658 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4660 2019-07-10 Tom Tromey <tromey@adacore.com>
4662 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4663 * breakpoint.c (init_ada_exception_breakpoint): Register as
4665 (print_one_breakpoint_location, print_one_breakpoint): Use
4666 is_ada_exception_catchpoint.
4667 * ada-lang.c (class ada_catchpoint_location): Pass
4668 bp_loc_software_breakpoint to bp_location constructor.
4669 (is_ada_exception_catchpoint): New function.
4671 2019-07-10 Tom Tromey <tromey@adacore.com>
4673 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4675 (struct arm_exidx_entry): New method operator<.
4676 (struct arm_exidx_data) <section_maps>: Change type.
4677 (arm_exidx_data_free): Remove.
4678 (arm_exidx_data_key): Change type. Move lower.
4679 (arm_exidx_new_objfile): Update.
4680 (arm_compare_exidx_entries): Remove.
4681 (arm_find_exidx_entry, _initialize_arm_tdep)
4683 2019-07-10 Tom Tromey <tromey@adacore.com>
4685 * solib-spu.c (ocl_program_data_key): Change type.
4686 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4689 2019-07-10 Tom Tromey <tromey@adacore.com>
4691 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4692 (struct solib_aix_inferior_data) <library_list>: Change type.
4693 (solib_aix_inferior_data_handle): Change type.
4694 (get_solib_aix_inferior_data): Update.
4695 (solib_aix_free_library_list): Remove.
4696 (library_list_start_library): Update.
4697 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4699 (solib_aix_get_library_list)
4700 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4701 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4703 2019-07-10 Tom Tromey <tromey@adacore.com>
4705 * solib-dsbt.c (struct dsbt_info): Add initializers.
4706 (solib_dsbt_pspace_data): Change type.
4707 (dsbt_pspace_data_cleanup): Remove.
4708 (get_dsbt_info, _initialize_dsbt_solib): Update.
4710 2019-07-10 Tom Tromey <tromey@adacore.com>
4712 * spu-tdep.c (spu_overlay_data): Change type.
4713 (spu_get_overlay_table, spu_overlay_new_objfile)
4714 (_initialize_spu_tdep): Update.
4716 2019-07-10 Tom Tromey <tromey@adacore.com>
4718 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4720 (dbx_objfile_data_key): Change type and declare later.
4721 (DBX_SYMFILE_INFO): Rewrite.
4722 * dbxread.c (dbx_objfile_data_key): Change type.
4723 (dbx_symfile_init): Update.
4724 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4725 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4726 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4728 2019-07-10 Tom Tromey <tromey@adacore.com>
4730 * jit.c (jit_program_space_key): Change type. Move lower.
4731 (get_jit_program_space_data): Update.
4732 (jit_program_space_data_cleanup): Remove.
4733 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4735 (struct jit_program_space_data): Add initializers.
4737 2019-07-10 Tom Tromey <tromey@adacore.com>
4739 * solib-darwin.c (struct darwin_info): Add initializers.
4740 (solib_darwin_pspace_data): Change type.
4741 (darwin_pspace_data_cleanup): Remove.
4742 (get_darwin_info, _initialize_darwin_solib): Update.
4744 2019-07-10 Tom Tromey <tromey@adacore.com>
4746 * remote-sim.c (struct sim_inferior_data): Add initializers,
4747 constructor, and destructor.
4748 (sim_inferior_data_key): Change type. Move lower.
4749 (check_for_duplicate_sim_descriptor): Update.
4750 (get_sim_inferior_data): Use new. Update.
4751 (~sim_inferior_data_cleanup): Rename from
4752 sim_inferior_data_cleanup. Simplify.
4753 (gdbsim_close_inferior, simulator_command)
4754 (sim_command_completer, _initialize_remote_sim): Update.
4755 (next_pid, INITIAL_PID): Move earlier.
4757 2019-07-10 Tom Tromey <tromey@adacore.com>
4759 * python/python-internal.h (create_thread_object): Return
4761 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4762 * python/py-inferior.c (struct threadlist_entry): Add
4764 <thread_obj>: Now a gdbpy_ref.
4765 (thread_to_thread_object): Update.
4766 (add_thread_object): Use new.
4767 (delete_thread_object): Use delete.
4768 (infpy_threads): Update.
4769 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4772 2019-07-10 Tom Tromey <tromey@adacore.com>
4774 * valops.c (value_cast): Specialize error message for Ada.
4776 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4778 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4780 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4782 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4783 bpstat_should_step): Return bool, adjust comments.
4784 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4785 bpstat_should_step): Likewise.
4787 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4789 * features/Makefile: Use feature target descriptions for Arm.
4790 * features/arm/arm-core.c: Generate new file.
4791 * features/arm/arm-fpa.c: Likewise.
4792 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4793 * features/arm/arm-m-profile.c: Likewise.
4794 * features/arm/arm-vfpv2.c: Likewise.
4795 * features/arm/arm-vfpv3.c: Likewise.
4796 * features/arm/xscale-iwmmxt.c: Likewise.
4797 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4799 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4801 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4804 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4806 * features/aarch64-pauth.c: Regenerate.
4808 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4810 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4812 (bpstat_what): Use false instead of 0.
4814 2019-07-09 Pedro Alves <palves@redhat.com>
4816 * break-catch-throw.c (is_exception_catchpoint): New.
4817 * breakpoint.c (print_one_breakpoint_location): New parameter
4818 'raw_loc'. Handle it. Use
4819 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4820 looking at the breakpoint's type.
4821 (print_one_breakpoint): If handling "maint info breakpoints", also
4822 print locations of exception catchpoints.
4823 * breakpoint.h (is_exception_catchpoint): Declare.
4825 2019-07-09 Pedro Alves <palves@redhat.com>
4827 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4829 (allocate_location_exception_catchpoint): New.
4830 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4831 (initialize_throw_catchpoint_ops): Install
4832 allocate_location_exception_catchpoint as allocate_location
4834 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4835 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4837 (breakpoint_address_is_meaningful): Delete.
4838 (bl_address_is_meaningful): New.
4839 (breakpoint_locations_match): Adjust comment.
4840 (bp_location_from_bp_type): New, factored out of...
4841 (bp_location::bp_location(breakpoint *)): ... this.
4842 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4844 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4845 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4846 breakpoint_address_is_meaningful.
4847 (bp_locations_compare): Adjust comment.
4848 (update_global_location_list): Use bl_address_is_meaningful
4849 instead of breakpoint_address_is_meaningful.
4850 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4852 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4853 * python/py-breakpoint.c (bppy_get_location): No longer check
4854 whether location is null.
4856 2019-07-09 Pedro Alves <palves@redhat.com>
4859 * breakpoint.c (print_one_breakpoint_location): Remove
4860 single-location assert.
4862 2019-07-09 Tom Tromey <tom@tromey.com>
4864 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4865 * configure: Rebuild.
4866 * configure.ac: Change common to gdbsupport.
4867 * gdbsupport: Rename from common.
4868 * acinclude.m4: Change common to gdbsupport.
4869 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4870 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4872 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4873 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4874 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4875 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4876 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4877 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4878 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4879 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4880 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4881 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4882 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4883 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4884 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4885 coff-pe-read.c, command.h, compile/compile-c-support.c,
4886 compile/compile-c.h, compile/compile-cplus-symbols.c,
4887 compile/compile-cplus-types.c, compile/compile-cplus.h,
4888 compile/compile-loc2c.c, compile/compile.c, completer.c,
4889 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4890 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4891 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4892 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4893 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4894 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4895 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4896 features/aarch64-core.c, features/aarch64-fpu.c,
4897 features/aarch64-pauth.c, features/aarch64-sve.c,
4898 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4899 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4900 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4901 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4902 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4903 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4904 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4905 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4906 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4907 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4908 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4909 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4910 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4911 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4912 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4913 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4914 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4915 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4916 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4917 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4918 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4919 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4920 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4921 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4922 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4923 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4924 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4925 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4926 minsyms.c, mips-linux-tdep.c, namespace.h,
4927 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4928 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4929 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4930 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4931 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4932 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4933 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4934 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4935 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4936 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4937 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4938 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4939 procfs.c, producer.c, progspace.h, psymtab.h,
4940 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4941 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4942 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4943 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4944 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4945 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4946 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4947 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4948 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4949 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4950 target-memory.c, target.c, target.h, target/waitstatus.c,
4951 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4952 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4953 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4954 unittests/array-view-selftests.c,
4955 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4956 unittests/common-utils-selftests.c,
4957 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4958 unittests/format_pieces-selftests.c,
4959 unittests/function-view-selftests.c,
4960 unittests/lookup_name_info-selftests.c,
4961 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4962 unittests/mkdir-recursive-selftests.c,
4963 unittests/observable-selftests.c,
4964 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4965 unittests/parse-connection-spec-selftests.c,
4966 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4967 unittests/scoped_fd-selftests.c,
4968 unittests/scoped_mmap-selftests.c,
4969 unittests/scoped_restore-selftests.c,
4970 unittests/string_view-selftests.c, unittests/style-selftests.c,
4971 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4972 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4973 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4974 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4975 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4976 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4978 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4980 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4982 (decode_digits_ordinary): Set explicit_line field in sal.
4983 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4984 symtab_and_line that was set on an explicit line number in
4985 assembler code. Do always update the recorded symtab and line if
4986 we do skip the prologue.
4988 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4990 * breakpoint.c (set_breakpoint_location_function): Remove
4991 explicit_loc parameter.
4992 (momentary_breakpoint_from_master): Update call to
4993 set_breakpoint_location_function.
4994 (add_location_to_breakpoint): Likewise.
4996 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4998 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4999 required features based on default bfd type when no specific bfd
5002 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5004 * NEWS: Mention that GDB printf and eval commands can now print
5005 C-style and Ada-style convenience var strings without
5006 calling the inferior.
5007 * printcmd.c (printf_c_string): Locally print GDB internal var
5008 instead of transiting via the inferior.
5009 (printf_wide_c_string): Likewise.
5011 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5013 PR breakpoints/25011
5014 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5016 2019-07-04 Tom Tromey <tom@tromey.com>
5019 * tui/tui-winsource.c (tui_clear_source_content): Update.
5020 (tui_source_window_base::set_is_exec_point_at): Fix comment.
5021 (tui_update_breakpoint_info): Update.
5022 (tui_set_exec_info_content): Update.
5023 * tui/tui-source.c (tui_set_source_content_nil): Update.
5024 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5026 * tui/tui-data.h (enum tui_bp_flag): New.
5027 (tui_bp_flags): New enum flags type.
5028 (struct tui_source_element) <break_mode>: Change type. Rename
5030 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5031 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
5033 * tui/tui-winsource.h: Fix comment.
5035 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5037 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5038 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5039 (store_fpregs_to_thread)
5040 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5041 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5042 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5043 (IWMMXT_REGS_SIZE): Add define.
5044 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5045 (fetch_vfp_regs, store_vfp_regs)
5046 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5047 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5049 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5051 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5053 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5054 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5055 (ARM_INT_REGISTER_SIZE): ...to this.
5056 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5057 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5058 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5059 (arm_linux_collect_gregset, supply_nwfpe_register)
5060 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5062 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5063 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5064 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5065 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5066 (arm_return_in_memory, arm_store_return_value)
5067 (arm_get_longjmp_target, arm_register_g_packet_guesses)
5068 (arm_record_ld_st_multiple): Likewise.
5069 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5070 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5072 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5074 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5075 AARCH64_DISPLACED_MODIFIED_INSNS.
5076 * aarch64-tdep.c (struct aarch64_displaced_step_data)
5077 (aarch64_displaced_step_copy_insn): Likewise.
5078 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5079 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5080 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5081 ARM_DISPLACED_MODIFIED_INSNS.
5082 * arm-tdep.c (arm_gdbarch_init): Likewise.
5083 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5084 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5085 (struct arm_displaced_step_closure): Use
5086 ARM_DISPLACED_MODIFIED_INSNS.
5088 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5090 * features/Makefile: Remove unused xml files.
5091 * features/aarch64.xml: Remove.
5092 * features/i386/amd64-avx-avx512-linux.xml: Remove.
5093 * features/i386/amd64-avx-avx512.xml: Remove.
5094 * features/i386/amd64-avx-linux.xml: Remove.
5095 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5096 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5097 * features/i386/amd64-avx-mpx-linux.xml: Remove.
5098 * features/i386/amd64-avx-mpx.xml: Remove.
5099 * features/i386/amd64-avx.xml: Remove.
5100 * features/i386/amd64-linux.xml: Remove.
5101 * features/i386/amd64-mpx-linux.xml: Remove.
5102 * features/i386/amd64-mpx.xml: Remove.
5103 * features/i386/amd64.xml: Remove.
5104 * features/i386/i386-avx-avx512-linux.xml: Remove.
5105 * features/i386/i386-avx-avx512.xml: Remove.
5106 * features/i386/i386-avx-linux.xml: Remove.
5107 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5108 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5109 * features/i386/i386-avx-mpx-linux.xml: Remove.
5110 * features/i386/i386-avx-mpx.xml: Remove.
5111 * features/i386/i386-avx.xml: Remove.
5112 * features/i386/i386-linux.xml: Remove.
5113 * features/i386/i386-mmx-linux.xml: Remove.
5114 * features/i386/i386-mmx.xml: Remove.
5115 * features/i386/i386-mpx-linux.xml: Remove.
5116 * features/i386/i386-mpx.xml: Remove.
5117 * features/i386/i386.xml: Remove.
5118 * features/i386/x32-avx-avx512-linux.xml: Remove.
5119 * features/i386/x32-avx-linux.xml: Remove.
5120 * features/i386/x32-linux.xml: Remove.
5122 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5124 * regformats/aarch64.dat: Remove.
5125 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5126 * regformats/i386/amd64-avx-linux.dat: Remove.
5127 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5128 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5129 * regformats/i386/amd64-linux.dat: Remove.
5130 * regformats/i386/amd64-mpx-linux.dat: Remove.
5131 * regformats/i386/amd64.dat: Remove.
5132 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5133 * regformats/i386/i386-avx-linux.dat: Remove.
5134 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5135 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5136 * regformats/i386/i386-linux.dat: Remove.
5137 * regformats/i386/i386-mmx-linux.dat: Remove.
5138 * regformats/i386/i386-mpx-linux.dat: Remove.
5139 * regformats/i386/i386.dat: Remove.
5140 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5141 * regformats/i386/x32-avx-linux.dat: Remove.
5142 * regformats/i386/x32-linux.dat: Remove.
5144 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5146 * aarch64-tdep.c: Remove xml self tests.
5147 * amd64-linux-tdep.c: Likewise.
5148 * amd64-tdep.c: Likewise.
5149 * i386-linux-tdep.c: Likewise.
5150 * i386-tdep.c: Likewise.
5152 2019-07-03 Pedro Alves <palves@redhat.com>
5155 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5156 (pipe_cmd_option_defs): New.
5157 (make_pipe_cmd_options_def_group): New.
5158 (pipe_command): Use gdb::option::process_options.
5159 (pipe_command_completer): New function.
5160 (_initialize_cli_cmds): Install completer for "pipe" command.
5162 2019-07-03 Pedro Alves <palves@redhat.com>
5164 * cli/cli-option.c (union option_value) <string>: New field.
5165 (struct option_def_and_value): Add ctor, move ctor, dtor and
5166 use DISABLE_COPY_AND_ASSIGN.
5167 (option_def_and_value::clear_value): New.
5168 (parse_option, save_option_value_in_ctx, get_val_type_str)
5169 (add_setshow_cmds_for_options): Handle var_string.
5170 * cli-option.h (union option_def::var_address) <string>: New
5172 (struct string_option_def): New.
5173 * maint-test-options.c (struct test_options_opts): Add default
5174 ctor and use DISABLE_COPY_AND_ASSIGN.
5175 <string_opt>: New field.
5176 (test_options_opts::~test_options_opts): New.
5177 (test_options_opts::dump): Also dump "-string".
5178 (test_options_option_defs): Install "string.
5180 2019-07-03 Pedro Alves <palves@redhat.com>
5182 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5183 option_value with a null enumeration.
5184 (complete_options): Save the option values in the context.
5185 (save_option_value_in_ctx): New, factored out from ...
5186 (process_options): ... here.
5187 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5189 * maint-test-options.c (test_options_opts::dump): New, factored
5191 (maintenance_test_options_command_mode): ... here.
5192 (maintenance_test_options_command_completion_result): Delete.
5193 (maintenance_test_options_command_completion_text): Update
5195 (maintenance_show_test_options_completion_result): Change
5196 prototype. Just print
5197 maintenance_test_options_command_completion_text.
5198 (save_completion_result): New.
5199 (maintenance_test_options_completer_mode): Pass options context to
5200 complete_options, and then save a dump.
5201 (_initialize_maint_test_options): Use add_cmd to install "maint
5202 show test-options-completion-result".
5204 2019-07-03 Pedro Alves <palves@redhat.com>
5206 * NEWS (New commands): Mention "with" and "maint with".
5207 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5208 (with_command, with_command_completer): New.
5209 (pipe_command): Adjust to new repeat_previous
5211 (_initialize_cli_cmds): Install the "with" command and its "w"
5213 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5215 * cli/cli-setshow.c (parse_cli_var_uinteger)
5216 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5217 argument strings for all var_types.
5218 (get_setshow_command_value_string): New, factored out from ...
5219 (do_show_command): ... this.
5220 * cli/cli-setshow.h: Include <string>.
5221 (get_setshow_command_value_string): Declare.
5222 * command.h (repeat_previous): Now returns const char *. Adjust
5224 * maint.c: Include "cli/cli-cmds.h".
5225 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5226 (_initialize_maint_cmds): Register the "maintenance with" command.
5227 * top.c (repeat_previous): Move bits from pipe_command here:
5228 Return the saved command line, if any; error out if there's no
5229 command to relaunch.
5231 2019-07-03 Pedro Alves <palves@redhat.com>
5233 * NEWS (New commands): Mention "maint set/show test-settings"
5234 instead of "maint test-settings".
5235 * maint-test-settings.c (maintenance_test_settings_list): Delete.
5236 (maintenance_test_settings_set_list): Rename to ...
5237 (maintenance_set_test_settings_list): ... this.
5238 (maintenance_test_settings_show_list): Rename to ...
5239 (maintenance_show_test_settings_list): ... this.
5240 (maintenance_test_settings_cmd): Delete.
5241 (maintenance_test_settings_set_cmd): ...
5242 (maintenance_set_test_settings_cmd): ... this.
5243 (maintenance_test_settings_show_cmd): ...
5244 (maintenance_show_test_settings_cmd): ... this.
5245 (maintenance_test_settings_show_value_cmd):
5246 (maintenance_show_test_settings_value_cmd): ... this.
5247 (_initialize_maint_test_settings): No longer install the "maint
5248 test-settings" prefix command. Rename "maint test-settings set"
5249 to "maint set test-settings", and "maint test-settings show" to
5250 "maint show test-settings". Adjust all subcommands.
5252 2019-07-03 Pedro Alves <palves@redhat.com>
5254 * maint-test-settings.c: Fix file's intro comment. Replace all
5255 references to "test-options" with references to "test-settings",
5258 2019-07-03 Pedro Alves <palves@redhat.com>
5260 * maint-test-settings.c (maintenance_test_settings_xxx)
5261 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5263 (maintenance_test_settings_enums): Use them.
5264 (maintenance_test_settings_enum): Default to
5265 maintenance_test_settings_xxx.
5266 (_initialize_maint_test_settings): Initialize
5267 MAINTENANCE_TEST_SETTINGS_FILENAME.
5269 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
5271 * breakpoint.h (remove_breakpoints_inf): Change return type to
5272 void, move function documentation here.
5273 * breakpoint.c (remove_breakpoints_inf): Change return type to
5274 void, move function documentation to header.
5276 2019-07-02 Pedro Alves <palves@redhat.com>
5278 * NEWS (Completion improvements): Mention "info threads".
5279 * thread.c (struct info_threads_opts, info_threads_option_defs)
5280 (make_info_threads_options_def_group): New.
5281 (info_threads_command): Use gdb::option::process_options.
5282 (info_threads_command_completer): New.
5283 (_initialize_thread): Use gdb::option::build_help to build the
5284 help text for "info threads".
5286 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
5288 * defs.h (generic_load): Move from here...
5289 * symfile.h (generic_load): ... to here. Rename name parameter
5291 * symfile.c (generic_load): Add comment.
5293 2019-07-01 Tom Tromey <tromey@adacore.com>
5296 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5297 declaration of without_params. Fix formatting.
5299 2019-07-01 Tom Tromey <tromey@adacore.com>
5301 * ada-exp.y (find_primitive_type): Update.
5302 * ada-lang.h (ada_lookup_symbol): Update.
5303 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5305 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5307 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
5309 PR breakpoints/24541
5310 * gdbarch.c: Regenerate.
5311 * gdbarch.h: Regenerate.
5312 * gdbarch.sh: Add 'stap_adjust_register'.
5313 * i386-tdep.c: Include '<unordered_set>'.
5314 (i386_stap_adjust_register): New function.
5315 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5316 * stap-probe.c (stap_parse_register_operand): Call
5317 'gdbarch_stap_adjust_register'.
5319 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
5322 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5323 * python/python.c (do_start_initialization): Use 'xmalloc'
5324 instead of 'PyMem_Malloc'.
5326 2019-06-28 Tom Tromey <tromey@adacore.com>
5328 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5331 2019-06-27 Tom Tromey <tromey@adacore.com>
5333 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
5335 (arm_find_mapping_symbol, arm_record_special_symbol)
5336 (_initialize_arm_tdep): Update.
5337 (arm_objfile_data_free): Remove.
5339 2019-06-27 Tom Tromey <tromey@adacore.com>
5341 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5342 to cp_print_static_field.
5344 2019-06-26 Tom Tromey <tromey@adacore.com>
5346 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5347 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5350 2019-06-26 Alan Hayward <alan.hayward@arm.com>
5352 * features/aarch64-core.c (create_feature_aarch64_core):
5354 * features/aarch64-core.xml: Add cpsr flags.
5356 2019-06-26 Alan Hayward <alan.hayward@arm.com>
5358 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5359 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5361 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
5363 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5365 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5367 (arm_record_special_symbol): Don't insert new symbol in sorted
5368 position, push it at the end.
5370 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
5372 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5373 (arm_mapping_symbol_s): Remove.
5374 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5375 (arm_mapping_symbol_vec): New typedef.
5376 (struct arm_per_objfile): Add constructor.
5377 <section_maps>: Change type to
5378 std::unique_ptr<arm_mapping_symbol_vec[]>.
5379 (arm_compare_mapping_symbols): Remove.
5380 (arm_find_mapping_symbol): Adjust to section_maps type change.
5381 (arm_objfile_data_free): Call delete on arm_per_objfile.
5382 (arm_record_special_symbol): Adjust to section_maps type change.
5383 Allocate arm_per_objfile with new.
5385 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5387 * cli/cli-cmds.c (alias_command): Compare the alias prefix
5388 with the command prefix.
5390 2019-06-25 Tom Tromey <tom@tromey.com>
5392 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5393 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5395 2019-06-25 Tom Tromey <tom@tromey.com>
5397 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5399 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5402 2019-06-25 Tom Tromey <tom@tromey.com>
5404 * tui/tui-winsource.c
5405 (tui_source_window_base::set_is_exec_point_at): Add check against
5408 2019-06-25 Tom Tromey <tom@tromey.com>
5410 * tui/tui-source.c (tui_set_source_content): Don't check before
5412 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5414 2019-06-25 Tom Tromey <tom@tromey.com>
5416 * tui/tui-winsource.h (tui_update_source_window_as_is)
5417 (tui_alloc_source_buffer, tui_line_is_displayed)
5418 (tui_addr_is_displayed): Change type of win_info.
5419 * tui/tui-winsource.c (tui_update_source_window_as_is)
5420 (tui_clear_source_content, tui_show_source_line)
5421 (tui_show_source_content, tui_source_window_base::refill)
5422 (tui_source_window_base::set_is_exec_point_at)
5423 (tui_source_window_base::set_is_exec_point_at)
5424 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5425 (tui_alloc_source_buffer, tui_line_is_displayed)
5426 (tui_addr_is_displayed): Change type of win_info. Update.
5427 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5428 (tui_source_window_base::do_make_visible_with_new_height):
5430 * tui/tui-source.c (tui_set_source_content)
5431 (tui_set_source_content_nil)
5432 (tui_source_window::do_scroll_vertical): Update.
5433 * tui/tui-layout.c (show_layout): Update.
5434 * tui/tui-disasm.c (tui_set_disassem_content)
5435 (tui_disasm_window::do_scroll_vertical): Update.
5436 * tui/tui-data.h (tui_win_content): Remove.
5437 (struct tui_gen_win_info) <content, content_size>: Remove.
5438 (struct tui_source_element): Add initializers and destructor.
5439 (union tui_which_element, struct tui_win_element): Remove.
5440 (struct tui_source_window_base) <content>: New field.
5441 (struct tui_data_window): Remove destructor.
5442 (tui_alloc_content, tui_free_win_content)
5443 (tui_free_all_source_wins_content): Don't declare.
5444 * tui/tui-data.c (tui_initialize_static_data): Update.
5445 (init_content_element, tui_alloc_content): Remove.
5446 (~tui_gen_win_info): Update.
5447 (~tui_data_window, tui_free_all_source_wins_content)
5448 (tui_free_win_content, free_content, free_content_elements):
5451 2019-06-25 Tom Tromey <tom@tromey.com>
5453 * tui/tui-winsource.h (tui_clear_source_content)
5454 (tui_erase_source_content, tui_show_source_content): Change type
5456 * tui/tui-winsource.c (tui_clear_source_content)
5457 (tui_erase_source_content, tui_show_source_content): Change type
5459 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5460 * tui/tui-source.h (tui_set_source_content_nil): Change type of
5462 * tui/tui-source.c (tui_set_source_content_nil): Change type of
5464 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5466 2019-06-25 Tom Tromey <tom@tromey.com>
5468 * tui/tui-winsource.c (tui_clear_source_content)
5469 (tui_source_window_base::set_is_exec_point_at): Update.
5470 * tui/tui-source.c (tui_set_source_content_nil): Update.
5471 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5473 * tui/tui-data.c (init_content_element): Update.
5475 2019-06-25 Tom Tromey <tom@tromey.com>
5477 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5478 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5479 * tui/tui-layout.c (init_and_make_win): Update.
5480 * tui/tui.h (enum tui_win_type): Update.
5481 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5482 tui_win_is_auxillary.
5483 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5484 tui_win_is_auxillary.
5486 2019-06-25 Tom Tromey <tom@tromey.com>
5488 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5489 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5490 (tui_delete_data_content_windows, tui_display_all_data)
5491 (tui_data_window::do_scroll_vertical, tui_display_data_from):
5493 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5494 * tui/tui-regs.c (tui_last_regs_line_no)
5495 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5496 (tui_show_registers): Update.
5497 (tui_show_register_group): Return void. Update.
5498 (tui_display_registers_from, tui_display_reg_element_at_line)
5499 (tui_display_registers_from_line, tui_check_register_values):
5501 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5503 (struct tui_data_window) <regs_content>: Now a std::vector.
5504 <regs_content_count>: Remove.
5505 (tui_add_content_elements, tui_free_data_content): Don't declare.
5506 * tui/tui-data.c (tui_data_window::clear_detail): Update.
5507 (init_content_element): Remove DATA_WIN case. Add assert.
5508 (tui_add_content_elements): Remove.
5509 (tui_data_window): Update.
5510 (tui_free_data_content): Remove.
5511 (free_content_elements): Remove DATA_WIN case.
5513 2019-06-25 Tom Tromey <tom@tromey.com>
5515 * tui/tui-data.c (tui_data_item_window): Update.
5516 * tui/tui-windata.h (tui_check_data_values): Don't declare.
5517 * tui/tui-windata.c (tui_display_all_data)
5518 (tui_display_data_from_line): Update.
5519 (tui_check_data_values): Remove.
5520 * tui/tui-regs.c (tui_show_register_group)
5521 (tui_display_reg_element_at_line): Update.
5522 * tui/tui-hooks.c (tui_register_changed)
5523 (tui_refresh_frame_and_register_information): Call
5524 tui_check_register_values.
5525 * tui/tui-data.h (struct tui_data_window) <data_content,
5526 data_content_count, data_type>: Remove.
5527 (enum tui_data_type): Remove.
5529 * tui/tui-data.c (tui_data_window::clear_detail)
5530 (~tui_data_window): Update.
5532 2019-06-25 Tom Tromey <tom@tromey.com>
5534 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5536 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5537 Rename from tui_first_data_item_displayed. Update.
5538 (tui_data_window::refresh_all)
5539 (tui_data_window::do_scroll_vertical): Update.
5540 * tui/tui-data.h (struct tui_data_window)
5541 <first_data_item_displayed>: Declare new method.
5543 2019-06-25 Tom Tromey <tom@tromey.com>
5545 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5546 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5548 (tui_initialize_static_data): ...here.
5550 2019-06-25 Tom Tromey <tom@tromey.com>
5552 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5553 (tui_display_registers_from, tui_check_register_values): Update.
5554 (tui_display_register): Remove win_info parameter; update.
5555 (tui_get_register): Change type of parameters.
5556 * tui/tui-data.h (struct tui_data_element): Remove.
5557 (union tui_which_element) <data>: Remove.
5558 <data_window>: Change type.
5559 (struct tui_data_item_window): New.
5560 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5562 (~tui_data_item_window): New destructor.
5563 (free_content_elements): Remove DATA_ITEM_WIN case.
5565 2019-06-25 Tom Tromey <tom@tromey.com>
5567 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5570 2019-06-25 Tom Tromey <tom@tromey.com>
5572 * tui/tui-data.h (struct tui_command_element): Remove.
5573 (union tui_which_element) <command>: Remove.
5574 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5576 (free_content_elements): Remove CMD_WIN case.
5578 2019-06-25 Tom Tromey <tom@tromey.com>
5580 * tui/tui-layout.c (tui_set_layout): Update.
5581 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5582 * tui/tui-data.c (layout_def): Update.
5584 2019-06-25 Tom Tromey <tom@tromey.com>
5586 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5587 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5588 (tui_source_window_base::set_new_height): Update.
5589 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5591 (tui_set_locator_fullname, tui_set_locator_info)
5592 (tui_show_frame_info): Update.
5593 * tui/tui-source.c (tui_set_source_content)
5594 (tui_source_is_displayed): Update.
5595 * tui/tui-layout.c (show_source_disasm_command, show_data)
5596 (show_source_or_disasm_and_command): Update.
5597 * tui/tui-disasm.c (tui_set_disassem_content)
5598 (tui_get_begin_asm_address): Update.
5599 * tui/tui-data.h (struct tui_locator_element): Remove.
5600 (union tui_which_element) <locator>: Remove.
5601 (struct tui_locator_window): New.
5602 (tui_locator_win_info_ptr): Change return type.
5603 * tui/tui-data.c (_locator): Change type.
5604 (tui_locator_win_info_ptr): Change return type.
5605 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5606 (tui_alloc_content): Add assert.
5608 2019-06-25 Tom Tromey <tom@tromey.com>
5610 * tui/tui-winsource.c
5611 (tui_exec_info_window::maybe_allocate_content): New method.
5612 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5613 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5614 (make_source_or_disasm_window): Add cast.
5615 * tui/tui-data.h (union tui_which_element) <simple_string>:
5617 (struct tui_source_info): New.
5618 (struct tui_source_window_base) <execution_info>: Change type.
5619 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5620 case, and add assert.
5621 (tui_alloc_content): Add assert.
5623 2019-06-25 Tom Tromey <tom@tromey.com>
5625 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5626 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5627 * tui/tui-data.c (tui_alloc_win_info): Remove.
5629 2019-06-25 Tom Tromey <tom@tromey.com>
5631 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5632 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5635 2019-06-25 Tom Tromey <tom@tromey.com>
5637 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5638 make_visible_with_new_height method.
5639 (tui_win_info::make_visible_with_new_height): New method.
5640 (tui_source_window_base::do_make_visible_with_new_height)
5641 (tui_data_window::do_make_visible_with_new_height)
5642 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5643 (make_visible_with_new_height): Remove.
5644 (tui_resize_all, tui_adjust_win_heights): Use
5645 make_visible_with_new_height method.
5646 * tui/tui-data.h (struct tui_win_info)
5647 <do_make_visible_with_new_height, make_visible_with_new_height>:
5649 (struct tui_source_window_base, struct tui_data_window)
5650 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5653 2019-06-25 Tom Tromey <tom@tromey.com>
5655 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5657 (update_tab_width): Call update_tab_width method.
5658 * tui/tui-data.h (struct tui_win_info)
5659 (struct tui_source_window_base) <update_tab_width>: New methods.
5661 2019-06-25 Tom Tromey <tom@tromey.com>
5663 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5665 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5667 (tui_gen_win_info::make_visible): Update.
5668 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5670 * tui/tui-data.h (enum tui_box): New enum.
5671 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5673 2019-06-25 Tom Tromey <tom@tromey.com>
5675 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5676 init_and_make_win for EXEC_INFO_WIN.
5677 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5679 (struct tui_win_info) <~tui_win_info>: Inline.
5680 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5682 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5683 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5685 (tui_initialize_static_data): Update.
5686 (~tui_gen_win_info): Handle more cleanup here.
5687 (~tui_source_window_base): Delete "execution_info".
5688 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5690 2019-06-25 Tom Tromey <tom@tromey.com>
5692 * tui/tui-layout.c (make_command_window): Don't set
5694 (show_source_disasm_command): Call the reset method.
5695 (show_data): Don't set can_highlight. Call the reset method.
5696 (tui_gen_win_info::reset): Rename from init_gen_win_info
5697 (init_and_make_win): Simplify. Return tui_gen_win_info.
5698 (show_source_or_disasm_and_command): Call the reset method.
5699 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5700 (struct tui_cmd_window): Set can_highlight.
5702 2019-06-25 Tom Tromey <tom@tromey.com>
5704 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5706 (tui_make_visible, tui_make_invisible): Rewrite.
5707 (tui_win_info::make_visible): Remove.
5708 (tui_source_window_base::make_visible): Update.
5709 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5710 method. Moved from...
5711 (struct tui_win_info) <make_visible>: ...here.
5713 2019-06-25 Tom Tromey <tom@tromey.com>
5715 * tui/tui-winsource.c
5716 (tui_source_window_base::do_scroll_horizontal): Remove direction
5718 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5719 direction parameter.
5720 * tui/tui-win.c (tui_win_info::forward_scroll)
5721 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5722 (tui_win_info::right_scroll): Update.
5723 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5724 direction parameter.
5725 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5726 direction parameter.
5727 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5728 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5729 Remove direction parameter.
5730 (struct tui_source_window_base, struct tui_source_window)
5731 (struct tui_disasm_window, struct tui_data_window)
5732 (struct tui_cmd_window): Update.
5734 2019-06-25 Tom Tromey <tom@tromey.com>
5736 * tui/tui-winsource.h (tui_set_exec_info_content)
5737 (tui_show_exec_info_content, tui_erase_exec_info_content)
5738 (tui_clear_exec_info_content, tui_update_exec_info): Change
5739 argument to tui_source_window_base.
5740 * tui/tui-winsource.c (tui_set_exec_info_content)
5741 (tui_show_exec_info_content, tui_erase_exec_info_content)
5742 (tui_clear_exec_info_content, tui_update_exec_info): Change
5743 argument to tui_source_window_base.
5745 2019-06-25 Tom Tromey <tom@tromey.com>
5747 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5748 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5750 2019-06-25 Tom Tromey <tom@tromey.com>
5752 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5755 2019-06-25 Tom Tromey <tom@tromey.com>
5757 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5759 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5761 * tui/tui-source.c (tui_set_source_content): Update.
5762 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5764 2019-06-25 Tom Tromey <tom@tromey.com>
5766 * tui/tui-win.c (window_name_completer, tui_set_focus)
5767 (tui_all_windows_info): Use name method.
5768 * tui/tui-data.h (struct tui_gen_win_info)
5769 (struct tui_source_window, struct tui_disasm_window)
5770 (struct tui_data_window, struct tui_cmd_window) <name>: New
5772 (tui_win_name): Don't declare.
5773 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5774 (tui_win_name): Remove.
5776 2019-06-25 Tom Tromey <tom@tromey.com>
5778 * tui/tui-winsource.h (tui_update_source_window)
5779 (tui_update_source_window_as_is): Change parameter type.
5780 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5781 to be a tui_source_window_base.
5782 (tui_update_source_window_as_is): Likewise.
5783 * tui/tui-win.c (make_visible_with_new_height): Update.
5785 2019-06-25 Tom Tromey <tom@tromey.com>
5787 * tui/tui-winsource.c (tui_erase_source_content)
5788 (tui_show_source_content, tui_show_exec_info_content)
5789 (tui_erase_exec_info_content): Use refresh_window method.
5790 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5791 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5792 from tui_refresh_win.
5793 (tui_data_window::refresh_window): New method.
5794 (tui_win_info::refresh, tui_source_window_base::refresh)
5795 (tui_refresh_all): Use refresh_window method.
5796 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5798 * tui/tui-regs.c (tui_display_register): Call refresh_window
5800 * tui/tui-layout.c (show_source_disasm_command)
5801 (show_source_or_disasm_and_command): Call refresh_window method.
5802 * tui/tui-data.h (struct tui_gen_win_info)
5803 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5806 2019-06-25 Tom Tromey <tom@tromey.com>
5808 * tui/tui.c (tui_rl_other_window, tui_enable)
5809 (tui_is_window_visible, tui_get_command_dimension): Update.
5810 * tui/tui-winsource.c (tui_update_source_window_as_is)
5811 (tui_clear_source_content, tui_erase_source_content)
5812 (tui_show_source_line, tui_source_window_base::refill)
5813 (tui_source_window_base::do_scroll_horizontal)
5814 (tui_source_window_base::set_is_exec_point_at)
5815 (tui_update_breakpoint_info, tui_set_exec_info_content)
5816 (tui_alloc_source_buffer, tui_line_is_displayed)
5817 (tui_addr_is_displayed): Update.
5818 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5819 (tui_check_and_display_highlight_if_needed)
5820 (tui_win_info::make_visible, tui_win_info::refresh)
5821 (tui_refresh_all): Update.
5822 * tui/tui-windata.c (tui_first_data_item_displayed)
5823 (tui_delete_data_content_windows, tui_erase_data_content)
5824 (tui_display_all_data, tui_data_window::refresh_all)
5825 (tui_check_data_values): Update.
5826 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5827 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5828 (tui_win_info::backward_scroll, tui_refresh_all_win)
5829 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5830 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5831 (tui_source_window_base::set_new_height)
5832 (tui_data_window::set_new_height)
5833 (make_invisible_and_set_new_height)
5834 (make_visible_with_new_height, new_height_ok)
5835 (parse_scrolling_args): Update.
5836 * tui/tui-stack.c (tui_show_frame_info): Update.
5837 * tui/tui-source.c (tui_set_source_content)
5838 (tui_set_source_content_nil, tui_source_is_displayed)
5839 (tui_source_window::do_scroll_vertical): Update.
5840 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5841 (tui_display_registers_from, tui_display_reg_element_at_line)
5842 (tui_check_register_values, tui_reg_command): Update.
5843 * tui/tui-layout.c (tui_default_win_height)
5844 (show_source_disasm_command, show_data, init_and_make_win)
5845 (show_source_or_disasm_and_command): Update.
5846 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5847 (tui_redisplay_readline, tui_mld_flush)
5848 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5850 * tui/tui-disasm.c (tui_set_disassem_content)
5851 (tui_disasm_window::do_scroll_vertical): Update.
5852 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5854 (struct tui_win_info): Derive from tui_gen_win_info.
5855 <~tui_win_info>: Mark as override.
5856 <generic>: Remove member.
5857 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5858 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5859 (~tui_data_window, ~tui_win_info)
5860 (tui_free_all_source_wins_content): Update.
5861 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5863 2019-06-25 Tom Tromey <tom@tromey.com>
5865 * tui/tui-layout.c (init_and_make_win): Use new.
5866 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5867 destructor, initializers.
5868 (tui_alloc_generic_win_info): Don't declare.
5869 * tui/tui-data.c (_locator): Add argument to constructor.
5870 (source_win, disasm_win): New globals.
5871 (exec_info): Remove.
5872 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5874 (tui_alloc_generic_win_info): Remove.
5875 (init_content_element): Use new.
5876 (tui_win_info::tui_win_info): Update.
5877 (free_content_elements) <case DATA_WIN>: Use delete.
5879 2019-06-25 Tom Tromey <tom@tromey.com>
5881 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5882 * tui/tui-windata.c (tui_first_data_item_displayed)
5883 (tui_delete_data_content_windows): Update.
5884 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5885 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5886 (tui_display_registers_from, tui_check_register_values): Update.
5887 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5889 * tui/tui-data.c (init_content_element): Update. Allocate the new
5891 (tui_free_data_content): Update.
5892 (free_content_elements) <case DATA_WIN>: Free the window.
5894 2019-06-25 Tom Tromey <tom@tromey.com>
5896 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5898 * tui/tui-layout.c (make_command_window)
5899 (show_source_disasm_command, show_data, init_and_make_win)
5900 (show_source_or_disasm_and_command): Update.
5901 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5903 <can_highight, is_highlighted>: Now bool.
5904 (tui_set_win_highlight): Don't declare.
5905 * tui/tui-data.c (tui_set_win_highlight): Remove.
5907 2019-06-25 Tom Tromey <tom@tromey.com>
5909 * tui/tui-wingeneral.c (make_visible): Remove check of window
5912 2019-06-25 Tom Tromey <tom@tromey.com>
5914 * tui/tui-win.c (tui_win_info::max_height)
5915 (tui_cmd_window::max_height): New methods.
5916 (new_height_ok): Call max_height.
5917 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5918 <max_height>: New method.
5920 2019-06-25 Tom Tromey <tom@tromey.com>
5922 * tui/tui-win.c (tui_source_window_base::set_new_height)
5923 (tui_data_window::set_new_height): New methods.
5924 (make_invisible_and_set_new_height): Call set_new_height method.
5925 * tui/tui-data.h (struct tui_win_info)
5926 (struct tui_source_window_base, struct tui_data_window)
5927 <set_new_height>: New method.
5929 2019-06-25 Tom Tromey <tom@tromey.com>
5931 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5932 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5933 tui_refresh_data_win.
5934 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5936 (tui_refresh_all_win): Call the refresh_all method.
5937 (tui_set_focus): Likewise.
5938 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5939 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5942 2019-06-25 Tom Tromey <tom@tromey.com>
5944 * tui/tui-winsource.h (tui_refill_source_window)
5945 (tui_set_is_exec_point_at): Don't declare.
5946 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5947 (tui_source_window_base::refill): Rename from
5948 tui_refill_source_window.
5949 (tui_source_window_base::do_scroll_horizontal): Update.
5950 (tui_source_window_base::set_is_exec_point_at): Rename from
5951 tui_set_is_exec_point_at.
5952 (tui_update_all_breakpoint_info): Update.
5953 * tui/tui-stack.c (tui_show_frame_info): Update.
5954 * tui/tui-layout.c (show_data): Add cast.
5955 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5956 * tui/tui-data.h (struct tui_source_window_base) <refill,
5957 set_is_exec_point_at>: New methods.
5958 (tui_source_windows, tui_add_to_source_windows): Update types.
5959 (tui_add_to_source_windows): Remove redundant declaration.
5960 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5961 (tui_source_windows): Change return type.
5962 (tui_clear_source_windows_detail): Update.
5963 (tui_add_to_source_windows): Change type of parameter.
5964 (tui_free_all_source_wins_content): Update.
5966 2019-06-25 Tom Tromey <tom@tromey.com>
5968 * tui/tui-wingeneral.c (tui_win_info::refresh)
5969 (tui_source_window_base::refresh): New methods.
5970 (tui_refresh_all): Call the refresh method.
5971 * tui/tui-data.h (struct tui_win_info)
5972 (struct tui_source_window_base) <refresh>: New method.
5974 2019-06-25 Tom Tromey <tom@tromey.com>
5976 * tui/tui.h (tui_is_window_visible): Return bool.
5977 * tui/tui.c (tui_is_window_visible): Return bool.
5978 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5979 (tui_make_visible, tui_make_invisible)
5980 (tui_win_info::make_visible)
5981 (tui_source_window_base::make_visible, make_all_visible)
5982 (tui_make_all_visible, tui_make_all_invisible): Update.
5983 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5984 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5986 (struct tui_win_info, struct tui_source_window_base)
5987 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5988 * tui/tui-data.c (tui_init_generic_part): Update.
5990 2019-06-25 Tom Tromey <tom@tromey.com>
5992 * tui/tui-wingeneral.c (tui_win_info::make_visible)
5993 (tui_source_window_base::make_visible): New methods.
5994 (make_all_visible): Make method call.
5995 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5996 (struct tui_source_window_base, struct tui_cmd_window): Override
5998 (tui_win_is_source_type): Don't declare.
5999 * tui/tui-data.c (tui_win_is_source_type): Remove.
6001 2019-06-25 Tom Tromey <tom@tromey.com>
6003 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6006 2019-06-25 Tom Tromey <tom@tromey.com>
6008 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6009 Inline constructor. Add initializers for members.
6010 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6011 constructors; now inline in class.
6013 2019-06-25 Tom Tromey <tom@tromey.com>
6015 * tui/tui-regs.c (tui_show_registers): Update.
6016 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6018 * tui/tui-data.c (tui_data_window::clear_detail)
6019 (tui_data_window): Update.
6021 2019-06-25 Tom Tromey <tom@tromey.com>
6023 * tui/tui-windata.c (tui_display_all_data)
6024 (tui_display_data_from_line, tui_display_data_from)
6025 (tui_check_data_values, tui_data_window::do_scroll_vertical):
6027 * tui/tui-regs.c (tui_last_regs_line_no)
6028 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6029 (tui_show_registers, tui_show_register_group)
6030 (tui_display_registers_from, tui_display_reg_element_at_line)
6031 (tui_display_registers_from_line, tui_check_register_values)
6032 (tui_reg_next, tui_reg_prev): Update.
6033 * tui/tui-layout.c (tui_set_layout, show_data): Update.
6034 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
6036 (struct tui_win_info) <detail>: Remove. Add new fields from
6038 (TUI_DATA_WIN): Add cast.
6039 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6040 (~tui_data_window): Simplify.
6042 2019-06-25 Tom Tromey <tom@tromey.com>
6044 * tui/tui-layout.c (show_source_disasm_command)
6045 (show_source_or_disasm_and_command): Update.
6046 * tui/tui-io.c (update_cmdwin_start_line)
6047 (tui_redisplay_readline): Update.
6048 * tui/tui-data.h (struct tui_command_info): Remove.
6049 (struct tui_win_info) <detail>: Remove command_info member.
6050 (struct tui_data_window) <start_line>: New member, from
6052 (TUI_CMD_WIN): Add casts.
6054 2019-06-25 Tom Tromey <tom@tromey.com>
6056 * tui/tui-winsource.c (tui_update_source_window)
6057 (tui_refill_source_window)
6058 (tui_source_window_base::do_scroll_horizontal)
6059 (tui_update_breakpoint_info, tui_set_exec_info_content)
6060 (tui_show_exec_info_content, tui_erase_exec_info_content)
6061 (tui_clear_exec_info_content): Update.
6062 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6064 * tui/tui-win.c (make_invisible_and_set_new_height)
6065 (make_visible_with_new_height): Update.
6066 * tui/tui-source.c (tui_set_source_content)
6067 (tui_show_symtab_source): Update.
6068 * tui/tui-layout.c (extract_display_start_addr)
6069 (show_source_disasm_command, show_data)
6070 (make_source_or_disasm_window)
6071 (show_source_or_disasm_and_command): Update.
6072 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6073 (tui_disasm_window::do_scroll_vertical): Remove shadowing
6075 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
6076 to tui_source_window_base.
6077 (struct tui_win_info) <detail>: Remove source_info member.
6078 (struct tui_source_window_base) <has_locator>: Inline.
6079 Move contents from tui_source_info; rename has_locator member to
6081 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6082 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6084 (tui_source_window_base::clear_detail, ~tui_source_window_base):
6086 (tui_free_all_source_wins_content): Cast to
6087 tui_source_window_base.
6089 2019-06-25 Tom Tromey <tom@tromey.com>
6091 * tui/tui-win.c (make_invisible_and_set_new_height)
6092 (make_visible_with_new_height): Call has_locator method.
6093 * tui/tui-layout.c (show_source_disasm_command, show_data)
6094 (show_source_or_disasm_and_command): Update for bool change.
6095 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6096 (tui_win_info) <has_locator>: New method.
6097 (struct tui_source_window_base) <has_locator>: New method.
6098 (tui_win_has_locator): Don't declare.
6099 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6100 from tui_win_has_locator.
6101 (tui_source_window_base): Use false, not FALSE.
6103 2019-06-25 Tom Tromey <tom@tromey.com>
6105 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6106 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6107 clear_detail method directly.
6108 (tui_clear_win_detail): Remove.
6110 2019-06-25 Tom Tromey <tom@tromey.com>
6112 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6113 "this", not TUI_DISASM_WIN.
6115 2019-06-25 Tom Tromey <tom@tromey.com>
6117 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
6119 * tui/tui-winsource.c
6120 (tui_source_window_base::do_scroll_horizontal): Rename from
6121 tui_horizontal_source_scroll.
6122 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6123 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6124 from tui_vertical_data_scroll.
6125 * tui/tui-win.h (tui_scroll): Don't declare.
6126 * tui/tui-win.c (tui_win_info::forward_scroll)
6127 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6128 (tui_win_info::right_scroll): Rename and update.
6129 (tui_scroll_forward_command, tui_scroll_backward_command)
6130 (tui_scroll_left_command, tui_scroll_right_command): Update.
6131 (tui_scroll): Remove.
6132 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6133 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6134 from tui_vertical_source_scroll.
6135 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6136 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6137 from tui_vertical_disassem_scroll.
6138 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6139 do_scroll_horizontal>: New methods.
6140 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6142 (struct tui_source_window_base): Add do_scroll_horizontal.
6143 (struct tui_source_window, struct tui_disasm_window): Add
6145 (struct tui_data_window, struct tui_cmd_window): Add
6146 do_scroll_horizontal and do_scroll_vertical.
6147 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6149 2019-06-25 Tom Tromey <tom@tromey.com>
6151 * tui/tui-data.h (struct tui_source_window_base): New struct.
6152 (struct tui_source_window): Derive from tui_source_window_base.
6153 (struct tui_disasm_window): New struct.
6154 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6155 from tui_source_window::clear_detail.
6156 (tui_source_window_base): Rename from tui_source_window.
6157 (~tui_source_window_base): Rename from ~tui_source_window.
6158 (tui_alloc_win_info): Create a tui_disasm_window.
6160 2019-06-25 Tom Tromey <tom@tromey.com>
6162 * tui/tui-data.h (struct tui_source_window)
6163 (struct tui_data_window): Declare destructors.
6164 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6166 (tui_win_info): Simplify.
6168 2019-06-25 Tom Tromey <tom@tromey.com>
6170 * tui/tui-winsource.c (tui_display_main)
6171 (tui_update_source_windows_with_addr)
6172 (tui_update_all_breakpoint_info): Update.
6173 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6174 (new_height_ok, parse_scrolling_args): Update.
6175 * tui/tui-stack.c (tui_show_frame_info): Update.
6176 * tui/tui-data.h (struct tui_list): Remove.
6177 (tui_source_windows): Return a reference to a std::vector.
6178 * tui/tui-data.c (source_windows): Now a std::vector.
6179 (tui_source_windows): Change return type.
6180 (tui_clear_source_windows): Rewrite.
6181 (tui_clear_source_windows_detail, tui_add_to_source_windows)
6182 (tui_free_all_source_wins_content): Rewrite.
6184 2019-06-25 Tom Tromey <tom@tromey.com>
6186 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6187 (struct tui_data_window, struct tui_cmd_window): Declare
6188 clear_detail method.
6189 * tui/tui-data.c (tui_source_window::clear_detail)
6190 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6192 (tui_clear_win_detail): Simplify.
6194 2019-06-25 Tom Tromey <tom@tromey.com>
6196 * tui/tui-layout.c (make_source_window, make_disasm_window)
6197 (make_source_or_disasm_window): Remove win_info_ptr parameter.
6198 Return the new window.
6199 (show_source_disasm_command, show_data)
6200 (show_source_or_disasm_and_command): Update.
6202 2019-06-25 Tom Tromey <tom@tromey.com>
6204 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6205 parameter. Return the new window.
6206 (show_source_disasm_command): Update and remove NULL check.
6207 (show_source_or_disasm_and_command): Update.
6209 2019-06-25 Tom Tromey <tom@tromey.com>
6211 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6213 2019-06-25 Tom Tromey <tom@tromey.com>
6215 * tui/tui-data.h (struct tui_win_info): Make constructor
6216 protected. Make destructor virtual. Add initializers.
6217 (tui_source_window, tui_data_window, tui_cmd_window): New
6219 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
6220 constructor. Add "type" parameter.
6221 (tui_source_window, tui_data_window, tui_cmd_window): New
6223 (tui_alloc_win_info): Instantiate the appropriate subclass.
6225 2019-06-25 Tom Tromey <tom@tromey.com>
6227 * tui/tui-win.c (tui_resize_all): Use delete.
6228 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6230 (tui_free_window): Don't declare.
6231 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6234 2019-06-25 Tom Tromey <tom@tromey.com>
6236 * tui/tui-data.h (struct tui_win_info): Add constructor.
6237 * tui/tui-data.c (tui_alloc_win_info): Use new.
6238 (tui_free_window): Use delete.
6240 2019-06-22 Tom Tromey <tom@tromey.com>
6242 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6244 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6246 2019-06-22 Tom Tromey <tom@tromey.com>
6248 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6250 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6252 2019-06-22 Tom de Vries <tdevries@suse.de>
6254 * dwarf2read.c (create_addrmap_from_aranges)
6255 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6258 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
6260 * dwarf2read.h (dwarf2_section_info_def): Remove.
6261 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6262 * dwarf2read.c (struct dwo_sections) <types>: Change type to
6263 std::vector<dwarf2_section_info>.
6264 (struct dwo_file) <~dwo_file>: Remove.
6265 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6267 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6268 (dwarf2_read_debug_names): Likewise.
6269 (create_debug_types_hash_table): Change parameter type to
6270 array_view, adjust code accordingly.
6271 (dwarf2_locate_dwo_sections): Adjust to std::vector.
6272 (partial_die_info::fixup): Likewise.
6273 (determine_prefix): Likewise.
6274 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6276 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6278 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6280 <~dwo_file>: Remove call to gdb_bfd_unref.
6281 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6282 gdb_bfd_ref_ptr::get.
6284 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6286 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6288 * dwarf2read.c (struct dwo_file): Initialize fields.
6290 (free_dwo_file): Remove, move content to ~dwo_file.
6291 (struct dwo_file_deleter): Remove.
6292 (dwo_file_up>: Remove custom deleter.
6293 (free_dwo_files): Remove.
6294 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6296 (process_skeletonless_type_units): Call unique_ptr::get.
6297 (allocate_dwo_file_hash_table): Add deleter to created hash
6298 table. Change return type to htab_up.
6299 (lookup_dwo_file_slot): Don't memset dwo_file, call
6301 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6302 (create_dwo_unit_in_dwp_v2): Likewise.
6303 (open_and_init_dwo_file): Likewise.
6304 (free_dwo_file_from_slot): Remove.
6306 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6308 * dwarf2read.h (struct dwarf2_section_info) <readin,
6309 is_virtual>: Change type to bool.
6310 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6313 2019-06-19 Tom Tromey <tom@tromey.com>
6315 * tui/tui-data.h (tui_init_content_element): Don't declare.
6317 2019-06-19 Tom Tromey <tom@tromey.com>
6319 * tui/tui-data.h (tui_init_win_info): Don't declare.
6321 2019-06-19 Tom de Vries <tdevries@suse.de>
6323 * dwarf2read.h (abstract_to_concrete): Change type to
6324 std::unordered_map<sect_offset, std::vector<sect_offset>,
6325 gdb::hash_enum<sect_offset>>.
6327 2019-06-19 Tom Tromey <tromey@adacore.com>
6329 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6330 EVAL_AVOID_SIDE_EFFECTS specially.
6332 2019-06-19 Tom Tromey <tromey@adacore.com>
6334 * source-cache.c (highlighter): New global.
6335 (source_cache::get_source_lines): Create a highlighter on demand.
6337 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
6339 * defs.h (deprecated_interactive_hook): Delete declaration.
6340 * interps.c (clear_interpreter_hooks): Remove use of
6341 deprecated_interactive_hook.
6342 * top.c (deprecated_interactive_hook): Delete definition.
6343 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6345 2019-06-18 Tom de Vries <tdevries@suse.de>
6348 * dwarf2read.h (abstract_to_concrete): Change type from
6349 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6350 std::unordered_map<sect_offset, std::vector<sect_offset>>.
6351 * dwarf2read.c (read_variable): Update.
6352 (dwarf2_fetch_die_loc_sect_off): Update.
6354 2019-06-17 Tom de Vries <tdevries@suse.de>
6357 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6358 accessing parent[parent_len - 1].
6360 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
6363 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6364 call dtrace_process_dof with NULL dof.
6366 2019-06-16 Tom de Vries <tdevries@suse.de>
6369 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6371 2019-06-16 Tom Tromey <tom@tromey.com>
6373 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6374 (make_all_visible): Use address of member.
6376 2019-06-16 Tom Tromey <tom@tromey.com>
6378 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6379 (tui_free_window, free_content, free_content_elements): Remove
6381 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6383 * tui/tui-regs.c (tui_show_register_group)
6384 (tui_display_registers_from, tui_display_reg_element_at_line):
6385 Remove unnecessary cast.
6387 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
6389 * linux-nat.c (normal_mask): Delete.
6390 (_initialize_linux_nat): Don't initialise normal_mask.
6392 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
6395 * dwarf-index-write.h (write_psymtabs_to_index): Add
6396 dwz_basename parameter.
6397 * dwarf-index-write.c (write_gdbindex): Move file writing to
6398 write_gdbindex_1. Change return type void.
6399 (assert_file_size): Move up, remove filename parameter.
6400 (write_gdbindex_1): New function.
6401 (write_debug_names): Change return type to void, call
6403 (struct index_wip_file): New struct.
6404 (write_psymtabs_to_index): Add dwz_basename parameter. Move
6405 file logic to index_wip_file. Write index for dwz file if
6407 (save_gdb_index_command): Pass basename of dwz file, if present.
6408 * dwarf-index-cache.c (index_cache::store): Obtain and pass
6409 build-id of dwz file, if present.
6410 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6411 (dwarf2_get_dwz_file): Likewise.
6412 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6413 (dwarf2_get_dwz_file): Likewise.
6415 2019-06-16 Tom Tromey <tom@tromey.com>
6417 * coffread.c (process_coff_symbol): Use xstrdup.
6418 * value.c (create_internalvar): Use xstrdup.
6420 2019-06-16 Tom Tromey <tom@tromey.com>
6422 * valops.c (value_cast, value_slice): Remove unnecessary cast.
6423 * breakpoint.c (stopin_command, stopat_command)
6424 (until_break_command, decode_location_default): Remove unnecessary
6426 * utils.c (subset_compare): Remove unnecessary cast.
6427 * ada-lang.c (ada_update_initial_language): Remove unnecessary
6429 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6431 * infcmd.c (path_command): Remove unnecessary cast.
6432 * coffread.c (decode_type): Remove unnecessary cast.
6433 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6434 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6435 * tui/tui-stack.c (tui_show_locator_content)
6436 (tui_show_frame_info): Remove unnecessary cast.
6437 * tui/tui-win.c (tui_scroll_forward_command)
6438 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6439 (parse_scrolling_args): Remove unnecessary cast.
6440 * tui/tui-data.c (init_win_info, tui_del_window)
6441 (tui_free_window, tui_del_data_windows, tui_free_data_content)
6442 (free_content_elements): Remove unnecessary cast.
6443 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6445 * tui/tui-source.c (tui_set_source_content)
6446 (tui_vertical_source_scroll): Remove unnecessary cast.
6447 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6449 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6450 * tui/tui-regs.c (tui_display_registers_from)
6451 (tui_display_register): Remove unnecessary cast.
6452 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6453 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6454 (make_visible): Remove unnecessary cast.
6455 * tui/tui-winsource.c (tui_erase_source_content)
6456 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6458 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6459 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6460 * stabsread.c (read_type, read_array_type, read_range_type):
6461 Remove unnecessary cast.
6462 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6463 (parse_symbol, parse_type, upgrade_type, parse_external)
6464 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6466 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6468 2019-06-16 Tom Tromey <tom@tromey.com>
6470 * tui/tui-data.c (tui_alloc_generic_win_info)
6471 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6474 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
6475 Andrew Burgess <andrew.burgess@embecosm.com>
6477 * f-typeprint.c (f_print_type): Don't return early for not
6478 associated or not allocated types.
6479 (f_type_print_varspec_suffix): Add print_rank parameter and print
6480 ranks of array types in case they dangling.
6481 (f_type_print_base): Add print_rank parameter.
6483 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6485 * NEWS: Mention new MI commands.
6486 * break-catch-throw.c (enum exception_event_kind): Move to
6488 (print_mention_exception_catchpoint): Output text as a single
6490 (catch_exception_command_1): Rename to...
6491 (catch_exception_event): ...this, make non-static, update header
6492 command, and change some parameter types.
6493 (catch_catch_command): Update for changes to
6494 catch_exception_command_1.
6495 (catch_throw_command): Likewise.
6496 (catch_rethrow_command): Likewise.
6497 * breakpoint.c (enum exception_event_kind): Delete.
6498 * breakpoint.h (enum exception_event_kind): Moved here from
6499 break-catch-throw.c.
6500 (catch_exception_event): Declare.
6501 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6502 (mi_cmd_catch_throw): New function.
6503 (mi_cmd_catch_rethrow): New function.
6504 (mi_cmd_catch_catch): New function.
6505 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6506 'catch-catch' entries.
6507 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6508 (mi_cmd_catch_rethrow): Declare.
6509 (mi_cmd_catch_catch): Declare.
6511 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6513 * annotate.c (annotate_source_line): Change return type to void,
6514 update implementation to match.
6515 * annotate.h (annotate_source_line): Change return type to void,
6516 update header comment.
6517 * stack.c (print_frame_info): Don't change what frame information
6518 is printed based on whether annotations are on or not.
6520 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6522 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6523 (annotate_source): Make static.
6524 (annotate_source_line): Moved from source.c and renamed from
6525 identify_source_line. Update the return type.
6526 * annotate.h (annotate_source): Delete declaration.
6527 (annotate_source_line): Declaration moved from source.h, and
6528 renamed from identify_source_line. Return type updated.
6529 * source.c (identify_source_line): Moved to annotate.c and renamed
6530 to annotate_source_line.
6531 (info_line_command): Remove check of annotation_level.
6532 * source.h (identify_source_line): Move declaration to annotate.h
6533 and rename to annotate_source_line.
6534 * stack.c: Add 'annotate.h' include.
6535 (print_frame_info): Remove check of annotation_level before
6536 calling annotate_source_line.
6538 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6540 * source-cache.c (source_cache::get_plain_source_lines): Use
6541 open_source_file_with_line_charpos instead of just
6542 open_source_file, remove call to find_source_lines.
6543 (source_cache::get_source_lines): Likewise.
6544 * source.c (find_source_lines): Make static.
6545 (get_filename_and_charpos): Renamed into...
6546 (open_source_file_with_line_charpos): ..this along with changes to
6547 return a scoped_fd, and some other minor clean ups.
6548 (identify_source_line): Use open_source_file_with_line_charpos.
6549 (search_command_helper): Use open_source_file_with_line_charpos
6550 instead of just open_source_file, remove call to
6552 * source.h (open_source_file_with_line_charpos): Declare new
6554 (find_source_lines): Delete declaration.
6556 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6558 * source.c (get_filename_and_charpos): Remove fullname
6560 (identify_source_line): Update call to get_filename_and_charpos.
6562 2019-06-14 Tom Tromey <tromey@adacore.com>
6565 * ui-style.h (skip_ansi_escape): Update comment.
6566 * ui-file.h (class no_terminal_escape_file): New class.
6567 * ui-file.c (no_terminal_escape_file::write)
6568 (no_terminal_escape_file::puts): New methods.
6569 * cli/cli-logging.c (handle_redirections): Use
6570 no_terminal_escape_file.
6572 2019-06-14 Tom Tromey <tromey@adacore.com>
6574 * NEWS: Move convenience variable news above Python news.
6576 2019-06-14 Tom Tromey <tom@tromey.com>
6578 * gnulib: Move directory to top-level.
6579 * configure.ac: Don't configure gnulib.
6580 * configure: Rebuild.
6581 * common/common-defs.h: Use new path to gnulib.
6582 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6584 (INCGNU): Look in new gnulib location.
6585 (HFILES_NO_SRCDIR): Remove gnulib files.
6586 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6587 (generated_files): Remove GNULIB_H.
6588 ($(LIBGNU), all-lib): Remove targets.
6589 (distclean): Don't mention GNULIB_BUILDDIR.
6590 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6592 2019-06-14 Tom Tromey <tromey@adacore.com>
6594 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6595 Warn if symbol file does not provide any symbols.
6597 2019-06-14 Tom Tromey <tromey@adacore.com>
6599 * source.c (find_and_open_source): Respect basenames_may_differ.
6601 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6603 * annotate.c (annotate_breakpoints_invalid): Make use of
6604 scoped_restore_terminal_state.
6605 (annotate_frames_invalid): Likewise.
6607 2019-06-14 Tom Tromey <tromey@adacore.com>
6609 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6610 allow assignment to an internalvar.
6612 2019-06-14 Tom Tromey <tromey@adacore.com>
6614 * ada-lex.l: Allow "_" in attribute names.
6616 2019-06-14 Tom Tromey <tromey@adacore.com>
6619 * regcache.c (registers_changed): Don't call alloca.
6620 * top.c (execute_command): Don't call alloca.
6622 2019-06-13 Pedro Alves <palves@redhat.com>
6624 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6625 'expression'. When parsing an expression, error out if there's
6626 junk after "unlimited".
6627 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6628 (do_set_command): Adjust calls to is_unlimited_literal.
6630 2019-06-13 Pedro Alves <palves@redhat.com>
6632 * compile/compile.c (make_compile_options_def_group): Add braces
6633 around array_view initializer.
6634 * thread.c (make_thread_apply_all_options_def_group)
6635 (make_thread_apply_all_options_def_group): Likewise.
6637 2019-06-13 Pedro Alves <palves@redhat.com>
6639 * NEWS (New commands): Mention "maint test-options
6640 require-delimiter", "maint test-options unknown-is-error", "maint
6641 test-options unknown-is-operand" and "maint show
6642 test-options-completion-result".
6643 (New command options, command completion): New section.
6644 (Completion improvements): New section.
6645 Mention that you can abbreviate "unlimited".
6647 2019-06-13 Pedro Alves <palves@redhat.com>
6649 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6650 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6651 * unittests/cli-utils-selftests.c (test_parse_flags)
6652 (test_parse_flags_qcs): Delete.
6653 (test_cli_utils): Don't call deleted functions.
6655 2019-06-13 Pedro Alves <palves@redhat.com>
6657 * thread.c: Include "cli/cli-option.h".
6658 (tp_array_compar_ascending): Global.
6659 (tp_array_compar): Delete function.
6660 (tp_array_compar_ascending, tp_array_compar_descending): New
6662 (ascending_option_def, qcs_flag_option_def)
6663 (thr_qcs_flags_option_defs)
6664 (make_thread_apply_all_options_def_group)
6665 (make_thread_apply_options_def_group): New.
6666 (thread_apply_all_command): Use gdb::option::process_options.
6667 (thread_apply_command_completer)
6668 (thread_apply_all_command_completer): New.
6669 (thread_apply_command): Use gdb::option::process_options.
6670 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6671 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6672 to generate help text of "thread apply". Adjust "taas"'s help.
6673 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6674 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6676 2019-06-13 Pedro Alves <palves@redhat.com>
6678 * thread.c (thread_apply_command): Check for invalid TID with
6679 isdigit instead of !isalpha.
6681 2019-06-13 Pedro Alves <palves@redhat.com>
6683 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6684 (validate_flags_qcs): New.
6685 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6686 (validate_flags_qcs): Declare.
6687 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6688 (make_frame_apply_options_def_group): New.
6689 (frame_apply_command_count): Process options with
6690 gdb::option::process_options.
6691 (frame_apply_completer): New.
6692 (frame_apply_level_completer, frame_apply_all_completer)
6693 (frame_apply_completer): New.
6694 (_initialize_stack): Update help of "frame apply", "frame apply
6695 level", "frame apply all" and "faas" to mention supported options
6696 and install command completers.
6697 * stack.h (frame_apply_all_completer): Declare.
6698 * thread.c: Include "stack.h".
6699 (tfaas_command): Add "--".
6700 (_initialize_thread): Update help "tfaas" to mention supported
6701 options and install command completer.
6703 2019-06-13 Pedro Alves <palves@redhat.com>
6705 * completer.c (complete_nested_command_line): New.
6706 (gdb_completion_word_break_characters_throw): Add assertion.
6707 * completer.h (complete_nested_command_line): Declare.
6709 2019-06-13 Pedro Alves <palves@redhat.com>
6711 * stack.c (parse_backtrace_qualifiers): New.
6712 (backtrace_command): Use it.
6713 (backtrace_command_completer): Complete on qualifiers.
6715 2019-06-13 Pedro Alves <palves@redhat.com>
6717 * frame.c: Include "cli/cli-option.h.
6718 (user_set_backtrace_options): New.
6719 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6721 (get_prev_frame): Adjust.
6722 (boolean_option_def, uinteger_option_def)
6723 (set_backtrace_option_defs): New.
6724 (_initialize_frame): Adjust and use
6725 gdb::option::add_setshow_cmds_for_options to install "set
6726 backtrace past-main" and "set backtrace past-entry".
6727 * frame.h: Include "cli/cli-option.h".
6728 (struct frame_print_options): Forward declare.
6729 (print_frame_arguments_all, print_frame_arguments_scalars)
6730 (print_frame_arguments_none): Declare.
6731 (print_entry_values): Delete declaration.
6732 (struct frame_print_options, user_frame_print_options): New.
6733 (struct set_backtrace_options): New.
6734 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6735 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6736 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6737 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6738 (list_args_or_locals): Add frame_print_options parameter.
6739 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6740 * python/py-framefilter.c (enumerate_args): Pass down
6741 USER_FRAME_PRINT_OPTIONS.
6742 * stack.c: Include "cli/cli-option.h".
6743 (print_frame_arguments_all, print_frame_arguments_scalars)
6744 (print_frame_arguments_none): Declare.
6745 (print_raw_frame_arguments, print_entry_values): Delete.
6746 (user_frame_print_options): New.
6747 (boolean_option_def, enum_option_def, frame_print_option_defs):
6749 (struct backtrace_cmd_options): New.
6750 (bt_flag_option_def): New.
6751 (backtrace_command_option_defs): New.
6752 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6753 (print_frame_arg, read_frame_arg, print_frame_args)
6754 (print_frame_info, print_frame): Add frame_print_options parameter
6756 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6757 (backtrace_command_1): Add frame_print_options and
6758 backtrace_cmd_options parameters and use them.
6759 (make_backtrace_options_def_group): New.
6760 (backtrace_command): Process command options with
6761 gdb::option::process_options.
6762 (backtrace_command_completer): New.
6763 (_initialize_stack): Extend "backtrace"'s help to mention
6764 supported options. Install completer for "backtrace".
6765 Install some settings commands with add_setshow_cmds_for_options.
6767 2019-06-13 Pedro Alves <palves@redhat.com>
6769 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6770 and that "set/show print raw frame-arguments" are now deprecated.
6772 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6774 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6775 * stack.c (_initialize_stack): Install "set/show print
6776 raw-frame-arguments", and deprecate "set/show print raw
6778 * valprint.c (_initialize_valprint): Deprecate "set/show print
6781 2019-06-13 Pedro Alves <palves@redhat.com>
6783 * compile/compile.c (struct compile_options): New.
6784 (compile_flag_option_def, compile_command_option_defs)
6785 (make_compile_options_def_group): New.
6786 (compile_file_command): Handle options with
6787 gdb::option::process_options.
6788 (compile_file_command_completer): New function.
6789 (compile_code_command): Handle options with
6790 gdb::option::process_options.
6791 (compile_code_command_completer): New function.
6792 (_initialize_compiler): Install completers for "compile code" and
6793 "compile file". Mention available options in "compile code" and
6794 "compile code"'s help.
6795 * completer.c (advance_to_completion_word): New, factored out from
6797 (advance_to_expression_complete_word_point): ... this.
6798 (advance_to_filename_complete_word_point): New.
6799 * completer.h (advance_to_filename_complete_word_point): New
6802 2019-06-13 Pedro Alves <palves@redhat.com>
6804 * compile/compile.c: Include "cli/cli-option.h".
6805 (compile_print_value): Scope data pointer is now a
6806 value_print_options pointer; adjust.
6807 (compile_print_command): Process options. Scope data pointer is
6808 now a value_print_options pointer; adjust.
6809 (_initialize_compile): Update "compile print"'s help to include
6810 supported options. Install a completer for "compile print".
6811 * cp-valprint.c (show_vtblprint, show_objectprint)
6812 (show_static_field_print): Delete.
6813 (_initialize_cp_valprint): Don't install "set print
6814 static-members", "set print vtbl", "set print object" here.
6815 * printcmd.c: Include "cli/cli-option.h" and
6816 "common/gdb_optional.h".
6817 (print_command_parse_format): Rework to fill in a
6818 value_print_options instead of a format_data.
6819 (print_value): Change parameter type from format_data pointer to
6820 value_print_options reference. Adjust.
6821 (print_command_1): Process options. Adjust to pass down a
6822 value_print_options.
6823 (print_command_completer): New.
6824 (_initialize_printcmd): Install print_command_completer as
6825 handle_brkchars completer for the "print" command. Update
6826 "print"'s help to include supported options.
6827 * valprint.c: Include "cli/cli-option.h".
6828 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6829 here from cp-valprint.c.
6830 (boolean_option_def, uinteger_option_def)
6831 (value_print_option_defs, make_value_print_options_def_group):
6832 New. Use gdb::option::add_setshow_cmds_for_options to install
6833 "set print elements", "set print null-stop", "set print repeats",
6834 "set print pretty", "set print union", "set print array", "set
6835 print address", "set print symbol", "set print array-indexes".
6836 * valprint.h: Include <string> and "cli/cli-option.h".
6837 (make_value_print_options_def_group): Declare.
6838 (print_value): Change parameter type from format_data pointer to
6839 value_print_options reference.
6840 (print_command_completer): Declare.
6842 2019-06-13 Pedro Alves <palves@redhat.com>
6844 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6845 (COMMON_SFILES): Add maint-test-settings.c.
6846 * cli/cli-decode.c (boolean_enums): New global, factored out from
6848 (add_setshow_boolean_cmd): ... here.
6849 * cli/cli-decode.h (boolean_enums): Declare.
6850 * cli/cli-option.c: New file.
6851 * cli/cli-option.h: New file.
6852 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6853 factored out from ...
6854 (parse_cli_boolean_value(const char *)): ... this.
6855 (is_unlimited_literal): Change parameter type to pointer to
6856 pointer. Adjust and advance ARG pointer.
6857 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6858 (parse_cli_var_enum): New, factored out from ...
6859 (do_set_command): ... this. Adjust.
6860 * cli/cli-setshow.h (parse_cli_boolean_value)
6861 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6862 (parse_cli_var_enum): Declare.
6863 * cli/cli-utils.c: Include "cli/cli-option.h".
6864 (get_ulongest): New.
6865 * cli/cli-utils.h (get_ulongest): Declare.
6866 (check_for_argument): New overloads.
6867 * maint-test-options.c: New file.
6869 2019-06-13 Pedro Alves <palves@redhat.com>
6871 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6872 parse a range if "-" is at the end of the string.
6874 2019-06-13 Pedro Alves <palves@redhat.com>
6876 * cli/cli-setshow.c (parse_auto_binary_operation)
6877 (parse_cli_boolean_value): Don't allow "o".
6879 2019-06-13 Pedro Alves <palves@redhat.com>
6881 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6882 * NEWS: Mention maint test-settings KIND.
6883 * maint-test-settings.c: New file.
6885 2019-06-13 Pedro Alves <palves@redhat.com>
6887 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6889 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6892 2019-06-13 Pedro Alves <palves@redhat.com>
6894 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6897 2019-06-13 Pedro Alves <palves@redhat.com>
6899 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6901 2019-06-13 Pedro Alves <palves@redhat.com>
6903 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6904 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6906 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6907 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6909 (check_for_argument): Skip spaces after argument.
6911 2019-06-13 Pedro Alves <palves@redhat.com>
6913 * thread.c (thread_apply_command): Adjust TID parsing.
6914 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6915 detected before end of string.
6916 (tid_is_in_list): Error out if LIST is invalid.
6918 2019-06-13 Pedro Alves <palves@redhat.com>
6920 * completer.c (complete_line_internal_1): Rewind completion word
6922 (completion_tracker::advance_custom_word_point_by): Change
6923 parameter type to int.
6924 * completer.h (completion_tracker::advance_custom_word_point_by):
6927 2019-06-13 Pedro Alves <palves@redhat.com>
6929 * completer.c (advance_to_completion_word): Handle delimiters.
6931 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6933 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6935 2019-06-11 Tom Tromey <tom@tromey.com>
6937 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6938 (xmalloc_failed): Move to alloc.c.
6939 * alloc.c: New file.
6940 * Makefile.in (COMMON_SFILES): Add alloc.c.
6942 2019-06-11 Tom Tromey <tom@tromey.com>
6944 * nat/linux-waitpid.c: Don't include server.h.
6945 (linux_debug): Remove.
6946 (my_waitpid): Update.
6948 2019-06-11 Tom Tromey <tromey@adacore.com>
6950 * infcall.c (_initialize_infcall): Remove trailing newline from
6952 * user-regs.c (_initialize_user_regs): Remove trailing newline
6954 * typeprint.c (_initialize_typeprint): Remove trailing newline
6956 * reverse.c (_initialize_reverse): Remove trailing newlines from
6958 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6960 * language.c (add_set_language_command): Remove trailing newline
6962 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6964 * disasm.c (_initialize_disasm): Remove trailing newline from
6966 * top.c (init_main): Remove trailing newline from help.
6967 * interps.c (_initialize_interpreter): Remove trailing newline
6969 * btrace.c (_initialize_btrace): Remove trailing newlines from
6971 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6973 * python/python.c (_initialize_python): Remove trailing newline
6975 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6977 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6978 from help. Reformat some text.
6979 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6981 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6984 2019-06-11 Tom Tromey <tromey@adacore.com>
6986 * darwin-nat.c (darwin_decode_exception_message)
6987 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6989 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
6991 * valops.c (value_slice): Check for not allocated or not
6994 2019-06-10 Tom de Vries <tdevries@suse.de>
6997 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6998 sure an empty slot (defined by a 32-bit zero pair) is recognized as
7001 2019-06-10 Tom de Vries <tdevries@suse.de>
7004 * linespec.c (linespec_lexer_lex_string): Remove incorrect
7005 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
7007 2019-06-10 Tom de Vries <tdevries@suse.de>
7010 * symtab.c (struct demangled_name_entry): Add language field.
7011 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
7012 static minimal symbol". Set and use language field.
7014 2019-06-10 Tom Tromey <tromey@adacore.com>
7016 * ada-lang.c (_initialize_ada_language): Update help text.
7018 2019-06-10 Tom Tromey <tromey@adacore.com>
7020 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7022 * guile/guile.c (handle_boot_error): Don't end warning with a
7024 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7025 warning with a newline.
7026 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7028 (s12z_frame_cache): Likewise.
7029 * dwarf-index-cache.c (index_cache::store): Don't end warning with
7031 * solib-svr4.c (disable_probes_interface): Don't end warning with
7033 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7035 * python/python.c (do_finish_initialization): Don't end warning
7038 2019-06-10 Tom Tromey <tom@tromey.com>
7040 * python/py-breakpoint.c (gdbpy_breakpoint_created)
7041 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7044 2019-06-10 Tom Tromey <tromey@adacore.com>
7046 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7048 (elf_new_init): Don't call stabsread_new_init.
7049 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7050 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
7051 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7053 2019-06-10 Tom de Vries <tdevries@suse.de>
7057 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7059 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
7061 * source.c (find_and_open_source): Also rewrite relative file
7064 2019-04-26 Amos Bird <amosbird@gmail.com>
7066 * annotate.c (annotate_thread_exited): Add "thread-exited"
7069 2019-06-06 Tom Tromey <tromey@adacore.com>
7071 * maint.h (class scoped_command_stats): Use
7072 DISABLE_COPY_AND_ASSIGN.
7073 <print_time>: New method.
7074 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7076 (scoped_command_stats::print_time): New method.
7078 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
7080 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7081 instructions of lengths 6 or 8 bytes.
7083 2019-06-04 Pedro Alves <palves@redhat.com>
7085 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7087 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7088 * breakpoint.c (condition_completer): Likewise.
7089 * cli/cli-dump.c (scan_expression): Likewise.
7090 * common/filestuff.c (mkdir_recursive): Likewise.
7091 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7092 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7093 (gdb_abspath): Likewise.
7094 * compile/compile-cplus-types.c
7095 (compile_cplus_instance::decl_name): Likewise.
7096 * completer.c (complete_explicit_location):
7097 (signal_completer, reg_or_group_completer_1): Likewise.
7098 * cp-support.c (cp_remove_params_if_any): Likewise.
7099 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7100 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7101 * infcmd.c (strip_bg_char): Likewise.
7102 * linespec.c (copy_token_string): Likewise.
7103 * mi/mi-main.c (output_cores): Likewise.
7104 * psymtab.c (psymtab_search_name):
7105 * symfile.c (test_set_ext_lang_command): Likewise.
7106 * target.c (target_fileio_read_stralloc): Likewise.
7107 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7108 * value.c (complete_internalvar): Likewise.
7110 2019-06-04 Christian Biesinger <cbiesinger@google.com>
7112 Add objfile property to gdb.Type.
7113 * NEWS: Mention Python API addition.
7114 * python/py-type.c (typy_get_objfile): New method.
7116 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7118 * NEWS: Mention the new set|show style [title|highlight].
7119 Mention changes to "show style", "help" and "apropos".
7121 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7123 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7124 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
7125 instead of print_help_for_command.
7126 (print_doc_of_command): New function.
7127 (help_list): Add 'apropos -v word' suggestion.
7128 (print_help_for_command): Style the command name using title style.
7129 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7130 (_initialize_cli_cmds): Describe -v in apropos_command help.
7132 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7134 * cli/cli-style.h (cli_style_option): Add name in constructor,
7135 add m_name class member, add constructor with intensity,
7136 add name class function.
7137 (cli_style_option::add_setshow_commands): Remove name argument.
7138 (highlight_style, title_style): New styles.
7139 * cli/cli-style.c (do_show): New function that shows a style
7140 characteristic styling the style name with itself.
7141 (set_style_name): New function.
7142 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7143 Update all callers according to the changes in cli/cli-style.h.
7144 * utils.h (fputs_highlighted): New function.
7145 * utils.c (fputs_highlighted): Likewise.
7147 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7149 * NEWS: Mention new pipe command and new convenience variables.
7151 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7153 * cli/cli-cmds.c (pipe_command): New function.
7154 (_initialize_cli_cmds): Call add_com for pipe_command.
7155 Define | as an alias for pipe.
7156 (exit_status_set_internal_vars): New function.
7157 (shell_escape): Call exit_status_set_internal_vars.
7158 cli/cli-decode.c (find_command_name_length): Recognize | as
7159 a single character command.
7161 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7163 * gdbcmd.h (execute_command_to_ui_file): New declaration.
7164 top.c (execute_command_to_ui_file): New function, mostly a copy
7165 of execute_command_to_string.
7166 (execute_command_to_string): Implement by calling
7167 execute_command_to_ui_file.
7169 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7171 * top.h (saved_command_line): Remove declaration.
7172 * top.c (previous_saved_command_line, previous_repeat_arguments):
7174 (saved_command_line): Make static, define together with other
7176 (dont_repeat): Clear repeat_arguments.
7177 (repeat_previous, get_saved_command_line, save_command_line):
7179 (gdb_init): Initialize saved_command_line
7180 and previous_saved_command_line.
7181 * main.c (captured_main_1): Remove saved_command_line initialization.
7182 * event-top.c (handle_line_of_input): Update to use
7183 the new 'repeat' related functions instead of direct access to
7185 * command.h (repeat_previous, get_saved_command_line,
7186 save_command_line): New declarations.
7187 (dont_repeat): Add comment.
7189 2019-05-30 Tom Tromey <tromey@adacore.com>
7191 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7193 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7195 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
7198 * completer.c (complete): Initialize variable word.
7200 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
7202 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7203 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7204 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7205 'body' is NULL to the outter 'if', protecting the '!is_define'
7208 2019-05-29 Tom Tromey <tromey@adacore.com>
7210 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7211 (dwarf_unknown): New function.
7212 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7213 (dwarf_type_encoding_name): Use dwarf_unknown.
7215 2019-05-29 Tom Tromey <tromey@adacore.com>
7218 * cp-valprint.c (cp_print_value_fields): Call
7219 cp_print_static_field inside "try".
7221 2019-05-29 Tom Tromey <tromey@adacore.com>
7223 * inflow.c (struct terminal_info): Add default operator=.
7224 * configure: Rebuild.
7225 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7226 -Wdeprecated-copy-dtor, -Wredundant-move.
7228 2019-05-29 Tom Tromey <tromey@adacore.com>
7231 * infcmd.c (print_return_value_1): Handle finish_print
7233 (show_print_finish): New function.
7234 (_initialize_infcmd): Add "set/show print finish" commands.
7235 * valprint.c (user_print_options): Initialize new member.
7236 * valprint.h (struct value_print_options) <finish_print>: New
7239 2019-05-28 Tom Tromey <tromey@adacore.com>
7241 * ada-lang.c (ada_remove_Xbn_suffix)
7242 (find_old_style_renaming_symbol)
7243 (parse_old_style_renaming): Remove.
7244 (ada_find_renaming_symbol): Don't call
7245 find_old_style_renaming_symbol.
7246 (ada_is_renaming_symbol): Rename from
7247 ada_find_renaming_symbol. Remove "block" parameter. Return
7249 (ada_read_var_value): Update and simplify.
7250 * ada-exp.y (write_var_or_type): Remove old code.
7252 2019-05-28 Alan Hayward <alan.hayward@arm.com>
7255 * event-top.c: Remove include comment.
7256 * inflow.c (class scoped_ignore_sigttou): Move from here...
7257 * inflow.h (class scoped_ignore_sigttou): ...to here.
7258 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7259 * top.c: Remove include comment.
7261 2019-05-27 Tom Tromey <tom@tromey.com>
7265 2019-05-22 Tom Tromey <tromey@adacore.com>
7267 * target.c (target_follow_exec): Constify parameter.
7268 * target-delegates.c: Rebuild.
7269 * remote.c (remote_target::follow_exec): Constify parameter.
7270 * infrun.c (follow_exec): Constify parameter.
7271 * target.h (struct target_ops) <follow_exec>: Constify parameter.
7272 (target_follow_exec): Likewise.
7274 2019-05-22 Alan Hayward <alan.hayward@arm.com>
7276 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7277 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7279 2019-05-22 Alan Hayward <alan.hayward@arm.com>
7281 * NEWS: Add debugredirect and testsuite sections.
7283 2019-05-22 Simon Cook <simon.cook@embecosm.com>
7285 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7286 target descriptions using exclusively floating point register name
7289 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
7292 * f-lang.c (build_fortran_types): Handle the case where
7293 gdbarch_floatformat_for_type returns a nullptr.
7295 2019-05-21 Tom de Vries <tdevries@suse.de>
7298 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7300 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
7303 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7305 * i386-tdep.c (i386_floatformat_for_type): Use
7306 floatformats_ia64_quad for the 16-byte floating point component
7307 within a fortran 32-byte complex number.
7309 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
7311 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7312 delete default constructor.
7313 (find_partial_die): Update to return const struct.
7314 (partial_die_parent_scope): Move variable declaration into scope
7315 of its use and change its type to auto.
7316 (guess_partial_die_structure_name): Likewise.
7317 (partial_die_info::fixup): Likewise.
7319 2019-05-17 Tom Tromey <tromey@adacore.com>
7321 * source.c (find_and_open_source): Remove cast.
7323 2019-05-17 Tom Tromey <tromey@adacore.com>
7325 * annotate.c (annotate_source): Make "filename" const.
7326 * annotate.h (annotate_source): Use const.
7328 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7330 * disasm.c (set_disassembler_options): Send errors to stderr.
7332 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7334 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7335 (cli_interp_base::set_logging): Check debug_redirect.
7336 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7337 * cli/cli-logging.c (debug_redirect): Add static variable.
7338 (pop_output_files): Add default param.
7339 (handle_redirections): Print debug setting.
7340 (show_logging_command): Likewise.
7341 (_initialize_cli_logging): Add debugredirect command.
7342 * interps.c (current_interp_set_logging): Add debug_redirect
7344 * interps.h (set_logging): Add debug_redirect parameter.
7345 (current_interp_set_logging): Likewise.
7346 * mi/mi-common.h: Likewise.
7347 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7349 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7350 Tom Tromey <tromey@adacore.com>
7352 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7354 * cli/cli-interp.h (make_logging_output): Remove declaration.
7355 * cli/cli-logging.c (make_logging_output): Remove function.
7356 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7358 * ui-file.c (tee_file::tee_file): Remove bools.
7359 (tee_file::~tee_file): Remove deletes.
7360 * ui-file.h (tee_file): Remove bools.
7362 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
7364 * mi/mi-cmds.h (mi_cmd_complete): New function.
7365 * mi/mi-main.c (mi_cmd_complete): Likewise.
7366 * mi/mi-cmds.c: Define new MI command -complete.
7367 * NEWS: Mention new -complete command.
7369 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
7371 * completer.h (complete): New function.
7372 * completer.c (complete): Likewise.
7373 * cli/cli-cmds.c: (complete_command): Update to use new complete()
7374 function defined in completer.h.
7376 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
7378 * MAINTAINERS (Write After Approval): Add myself.
7380 2019-05-17 Tom de Vries <tdevries@suse.de>
7383 * dwarf2read.c (struct cu_partial_die_info): New struct.
7384 (find_partial_die): Return cu_partial_die_info.
7385 (partial_die_parent_scope, guess_partial_die_structure_name)
7386 (partial_die_info::fixup): Handle new return type of find_partial_die.
7388 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7390 PR breakpoints/24541
7391 * stap-probe.c (stap_parse_register_operand): Make "regname" an
7392 "std::string", simplifying the algorithm.
7394 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7396 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7397 (stap_static_probe_ops::get_probes): Likewise.
7399 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7401 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7402 '-')" and "else if".
7403 (stap_parse_single_operand): Join checks for
7404 "gdbarch_stap_parse_special_token_p" and
7405 "gdbarch_stap_parse_special_token" in the same "if" statement.
7406 Invert check when verifying for operation on register
7409 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7411 * stap-probe.c (stap_get_opcode): Update comment.
7412 (stap_get_expected_argument_type): Likewise.
7413 (handle_stap_probe): Likewise.
7415 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7417 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7418 return type to 'bool'. Adjust comment. Use 'bool' when
7420 (i386_stap_parse_special_token_three_arg_disp): Likewise.
7421 * stap-probe.c (stap_parse_argument_1): Likewise.
7422 (stap_is_operator): Likewise.
7423 (stap_is_generic_prefix): Likewise.
7424 (stap_is_register_prefix): Likewise.
7425 (stap_is_register_indirection_prefix): Likewise.
7426 (stap_is_integer_prefix): Likewise.
7427 (stap_generic_check_suffix): Likewise.
7428 (stap_check_integer_suffix): Likewise.
7429 (stap_check_register_suffix): Likewise.
7430 (stap_check_register_indirection_suffix): Likewise.
7431 (stap_parse_register_operand): Likewise.
7432 (stap_parse_single_operand): Likewise.
7433 (stap_parse_argument_1): Likewise.
7434 (stap_probe::get_argument_count): Likewise.
7435 (stap_is_operator): Likewise.
7437 2019-05-16 Tom Tromey <tromey@adacore.com>
7439 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7442 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
7444 * linux-thread-db.c (try_thread_db_load_1): Change return type
7446 (try_thread_db_load): Likewise.
7447 (try_thread_db_load_from_pdir_1): Likewise.
7448 (try_thread_db_load_from_pdir): Likewise.
7449 (try_thread_db_load_from_sdir): Likewise.
7450 (try_thread_db_load_from_dir): Likewise.
7451 (thread_db_load_search): Likewise.
7452 (has_libpthread): Likewise.
7453 (thread_db_load): Likewise.
7455 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
7457 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7458 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7459 NULL, and complain/return if that's the case.
7461 2019-05-15 John Darrington <john@darrington.wattle.id.au>
7463 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7464 (advance, posn, abstract_read_memory): New functions.
7465 [struct mem_read_abstraction]: New struct.
7466 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7468 2019-05-14 Tom Tromey <tromey@adacore.com>
7470 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7471 value is not lval_memory.
7473 2019-05-14 Tom Tromey <tromey@adacore.com>
7475 * solib.c (info_sharedlibrary_command): Style the file name.
7477 2019-05-14 Alan Hayward <alan.hayward@arm.com>
7479 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7480 (aarch64_vnv_type): Likewise.
7481 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7482 * common/tdesc.c: Likewise.
7483 * common/tdesc.h (enum tdesc_type_kind): Likewise.
7484 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7485 * features/aarch64-fpu.xml: Add ieee half view.
7486 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7487 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7488 * gdbtypes.h (struct builtin_type): Likewise.
7489 (struct objfile_type): Likewise.
7491 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
7493 * language.c (language_sniff_from_mangled_name): Fix "langauge"
7495 * location.h (string_to_event_location): Likewise.
7497 2019-05-11 Joel Brobecker <brobecker@adacore.com>
7501 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
7503 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7504 New variable declaration.
7505 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7507 (print_one_breakpoint): Use ui_out::test_flags and new global
7508 variable to compute use_fixed_output.
7509 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7511 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7512 (mi_multi_location_breakpoint_output_fixed): Remove.
7513 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7515 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7516 fix_multi_location_breakpoint_output flag if version >= 3.
7517 * ui-out.h (enum ui_out_flag)
7518 <fix_multi_location_breakpoint_output>: New enumerator.
7520 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
7522 * contrib/cc-with-tweaks.sh: Validate dwz's work.
7524 2019-05-10 Tom Tromey <tromey@adacore.com>
7526 * ada-lang.c (catch_ada_completer): New function.
7527 (_initialize_ada_language): Use it.
7529 2019-05-10 Tom Tromey <tromey@adacore.com>
7531 * thread.c (print_thread_info): Make "requested_threads" const.
7532 * gdbthread.h (print_thread_info): Make "requested_threads"
7534 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7535 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7537 2019-05-08 Tom Tromey <tom@tromey.com>
7539 * gdbtypes.c (objfile_type_data): Change type.
7540 (objfile_type, _initialize_gdbtypes): Update.
7542 2019-05-08 Tom Tromey <tom@tromey.com>
7544 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7545 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7546 (_initialize_dwarf2_frame): Update.
7548 2019-05-08 Tom Tromey <tom@tromey.com>
7550 * objc-lang.c (objc_objfile_data): Change type.
7551 (find_methods): Update.
7552 (_initialize_objc_lang): Remove.
7554 2019-05-08 Tom Tromey <tom@tromey.com>
7556 * stabsread.c (rs6000_builtin_type_data): Change type.
7557 (rs6000_builtin_type, _initialize_stabsread): Update.
7559 2019-05-08 Tom Tromey <tom@tromey.com>
7561 * mips-tdep.c (mips_pdr_data): Remove.
7562 (_initialize_mips_tdep): Update.
7564 2019-05-08 Tom Tromey <tom@tromey.com>
7566 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7567 (hppa_init_objfile_priv_data, read_unwind_info)
7568 (find_unwind_entry, _initialize_hppa_tdep): Update.
7570 2019-05-08 Tom Tromey <tom@tromey.com>
7572 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7573 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7575 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7577 2019-05-08 Tom Tromey <tom@tromey.com>
7579 * mdebugread.c (basic_type_data): Change type.
7580 (basic_type, _initialize_mdebugread): Update.
7582 2019-05-08 Tom Tromey <tom@tromey.com>
7584 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7586 2019-05-08 Tom Tromey <tom@tromey.com>
7588 * nto-tdep.c (nto_inferior_data_reg): Change type.
7589 (nto_inferior_data): Update.
7590 (nto_inferior_data_cleanup, nto_new_inferior_data)
7591 (_initialize_nto_tdep): Remove.
7592 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7594 2019-05-08 Tom Tromey <tom@tromey.com>
7596 * ada-lang.c (struct ada_inferior_data): Add initializers.
7597 (ada_inferior_data): Change type.
7598 (ada_inferior_data_cleanup): Remove.
7599 (get_ada_inferior_data, ada_inferior_exit)
7600 (struct ada_pspace_data): Add initializers, destructor.
7601 (ada_pspace_data_handle): Change type.
7602 (get_ada_pspace_data): Update.
7603 (ada_pspace_data_cleanup): Remove.
7605 2019-05-08 Tom Tromey <tom@tromey.com>
7607 * coffread.c (struct coff_symfile_info): Add initializers.
7608 (coff_objfile_data_key): Move lower. Change type.
7609 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7611 (coff_free_info): Remove.
7613 2019-05-08 Tom Tromey <tom@tromey.com>
7615 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7616 (fbsd_pspace_data_handle): Move lower. Change type.
7617 (get_fbsd_pspace_data): Update.
7618 (fbsd_pspace_data_cleanup): Remove.
7619 (_initialize_fbsd_tdep): Update.
7621 2019-05-08 Tom Tromey <tom@tromey.com>
7623 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7624 (get_ada_tasks_pspace_data): Update.
7625 (ada_tasks_pspace_data_cleanup): Remove.
7626 (_initialize_tasks): Update.
7627 (ada_tasks_inferior_data_handle): Change type.
7628 (get_ada_tasks_inferior_data): Update.
7629 (ada_tasks_inferior_data_cleanup): Remove.
7630 (struct ada_tasks_pspace_data): Add initializers.
7632 2019-05-08 Tom Tromey <tom@tromey.com>
7634 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7635 * symfile-debug.c (debug_sym_get_probes): Change type.
7636 * stap-probe.c (handle_stap_probe):
7637 (stap_static_probe_ops::get_probes): Change type.
7638 * probe.h (class static_probe_ops) <get_probes>: Change type.
7639 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7640 (parse_probes_in_pspace): Update.
7641 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7643 (any_static_probe_ops::get_probes): Change type.
7644 * elfread.c (elfread_data): New typedef.
7645 (probe_key): Change type.
7646 (elf_get_probes): Likewise. Update.
7647 (probe_key_free): Remove.
7648 (_initialize_elfread): Update.
7649 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7651 (dtrace_process_dof_probe, dtrace_process_dof)
7652 (dtrace_static_probe_ops::get_probe): Change type.
7654 2019-05-08 Tom Tromey <tom@tromey.com>
7656 * xcoffread.c (struct xcoff_symfile_info): Rename from
7657 coff_symfile_info. Add initializers.
7658 (xcoff_objfile_data_key): Move lower. Change type.
7659 (XCOFF_DATA): Rewrite.
7660 (xcoff_free_info): Remove.
7661 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7662 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7663 (xcoff_initial_scan): Update.
7665 2019-05-08 Tom Tromey <tom@tromey.com>
7667 * solib-svr4.c (struct svr4_info): Add initializers and
7669 <probes_table>: Now an htab_up.
7670 (solib_svr4_pspace_data): Change type.
7671 (free_probes_table): Simplify.
7672 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7673 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7674 (probes_table_remove_objfile_probes, register_solib_event_probe)
7675 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7676 (_initialize_svr4_solib): Update.
7678 2019-05-08 Tom Tromey <tom@tromey.com>
7680 * remote.c (remote_pspace_data): Change type.
7681 (remote_pspace_data_cleanup): Remove.
7682 (get_remote_exec_file, set_pspace_remote_exec_file)
7683 (_initialize_remote): Update.
7685 2019-05-08 Tom Tromey <tom@tromey.com>
7687 * breakpoint.c (breakpoint_objfile_key): Change type.
7688 (get_breakpoint_objfile_data): Update.
7689 (free_breakpoint_objfile_data): Remove.
7690 (_initialize_breakpoint): Update.
7692 2019-05-08 Tom Tromey <tom@tromey.com>
7694 * linux-tdep.c (struct linux_info): Add initializers.
7695 (linux_inferior_data): Move. Change type.
7696 (invalidate_linux_cache_inf): Update.
7697 (linux_inferior_data_cleanup): Remove.
7698 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7700 2019-05-08 Tom Tromey <tom@tromey.com>
7702 * auxv.c (auxv_inferior_data): Move. Change type.
7703 (auxv_inferior_data_cleanup): Remove.
7704 (invalidate_auxv_cache_inf): Rewrite.
7705 (get_auxv_inferior_data, _initialize_auxv): Update.
7707 2019-05-08 Tom Tromey <tom@tromey.com>
7709 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7710 (symfile_debug_objfile_data_key): Change type.
7711 (symfile_debug_installed, debug_qf_has_symbols)
7712 (debug_qf_find_last_source_symtab)
7713 (debug_qf_forget_cached_source_info)
7714 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7715 (debug_qf_print_stats, debug_qf_dump)
7716 (debug_qf_expand_symtabs_for_function)
7717 (debug_qf_expand_all_symtabs)
7718 (debug_qf_expand_symtabs_with_fullname)
7719 (debug_qf_map_matching_symbols)
7720 (debug_qf_expand_symtabs_matching)
7721 (debug_qf_find_pc_sect_compunit_symtab)
7722 (debug_qf_map_symbol_filenames)
7723 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7724 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7725 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7726 (debug_sym_read_linetable, debug_sym_relocate): Update.
7727 (symfile_debug_free_objfile): Remove.
7728 (install_symfile_debug_logging, _initialize_symfile_debug):
7731 2019-05-08 Tom Tromey <tom@tromey.com>
7733 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7734 allocate_on_obstack.
7735 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7736 (get_dwarf2_per_objfile): Update.
7737 (set_dwarf2_per_objfile): Remove.
7738 (dwarf2_has_info, dwarf2_get_section_info): Update.
7739 (dwarf2_free_objfile): Remove.
7740 (_initialize_dwarf2_read): Update.
7742 2019-05-08 Tom Tromey <tom@tromey.com>
7744 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7746 <unsupported_script_warning_printed,
7747 script_not_found_warning_printed>: Now bool.
7748 (auto_load_pspace_data): Change type.
7749 (~auto_load_pspace_info): Rename from
7750 auto_load_pspace_data_cleanup.
7751 (get_auto_load_pspace_data, init_loaded_scripts_info)
7752 (clear_section_scripts, maybe_print_unsupported_script_warning)
7753 (maybe_print_script_not_found_warning, _initialize_auto_load):
7756 2019-05-08 Tom Tromey <tom@tromey.com>
7758 * objfiles.c (objfile_pspace_info): Add destructor and
7760 (objfiles_pspace_data): Change type.
7761 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7762 (get_objfile_pspace_data): Update.
7763 (objfiles_bfd_data): Change type.
7764 (get_objfile_bfd_data): Update.
7765 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7767 2019-05-08 Tom Tromey <tom@tromey.com>
7769 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7771 (get_catch_syscall_inferior_data): Update.
7772 (catch_syscall_inferior_data_cleanup): Remove.
7773 (_initialize_break_catch_syscall): Update.
7775 2019-05-08 Tom Tromey <tom@tromey.com>
7777 * inflow.c (struct terminal_info): Add destructor and
7779 (inflow_inferior_data): Change type.
7780 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7781 (get_inflow_inferior_data, inflow_inferior_exit)
7782 (swap_terminal_info, _initialize_inflow): Update.
7784 2019-05-08 Tom Tromey <tom@tromey.com>
7786 * target-dcache.c (target_dcache_cleanup): Remove.
7787 (target_dcache_aspace_key): Change type.
7788 (target_dcache_init_p, target_dcache_invalidate)
7789 (target_dcache_get, target_dcache_get_or_init)
7790 (_initialize_target_dcache): Update.
7791 * dcache.h (struct dcache_deleter): New.
7793 2019-05-08 Tom Tromey <tom@tromey.com>
7795 * symtab.c (struct symbol_cache): Add destructor and
7797 (symbol_cache_key): Move. Change type.
7798 (make_symbol_cache, free_symbol_cache): Remove.
7799 (get_symbol_cache): Update.
7800 (symbol_cache_cleanup): Remove.
7801 (ALL_PSPACES, symbol_cache_flush)
7802 (maintenance_print_symbol_cache)
7803 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7806 2019-05-08 Tom Tromey <tom@tromey.com>
7808 * symtab.c (struct main_info): Add destructor and initializers.
7809 (main_progspace_key): Move. Change type.
7810 (get_main_info): Update.
7811 (main_info_cleanup): Remove.
7812 (_initialize_symtab): Update.
7814 2019-05-08 Tom Tromey <tom@tromey.com>
7816 * registry.h (DECLARE_REGISTRY): Define the _key class.
7818 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7820 * NEWS: Merge two 'New commands' sections.
7822 2019-05-08 Joel Brobecker <brobecker@adacore.com>
7824 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7825 parameter and use Ada language definition instead.
7826 (ada_val_print_ptr): Remove unused language parameter.
7827 (ada_val_print_num): Remove language parameter and use Ada language
7829 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7831 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7832 parameter and use Ada language definition instead.
7833 (ada_val_print_1): Update all ada_val_print_xxx calls.
7834 Remove language parameter.
7835 (ada_val_print): Update ada_val_print_1 call.
7837 2019-05-08 Tom Tromey <tromey@adacore.com>
7839 * remote.c (remote_hw_watchpoint_limit)
7840 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7843 2019-05-08 Tom Tromey <tromey@adacore.com>
7845 * maint.c (_initialize_maint_cmds): Move initialization code to
7847 (watchdog, show_watchdog): Move to remote.c.
7848 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7850 (_initialize_remote): Move initialization code from maint.c.
7851 * defs.h (watchdog): Don't declare.
7853 2019-05-08 Tom Tromey <tromey@adacore.com>
7855 * tui/tui-interp.c: Include main.h.
7856 * interps.c: Include main.h.
7857 * main.h (interpreter_p): Declare.
7858 * defs.h (interpreter_p): Don't declare.
7860 2019-05-08 Tom Tromey <tromey@adacore.com>
7862 * dwarf2loc.c: Include dwarf2read.h.
7863 * defs.h (read_unsigned_leb128): Don't declare.
7864 * dwarf2read.h (read_unsigned_leb128): Declare.
7866 2019-05-08 Tom Tromey <tromey@adacore.com>
7868 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7871 2019-05-08 Tom Tromey <tromey@adacore.com>
7873 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7874 when no wrap column is set.
7876 2019-05-08 Tom Tromey <tromey@adacore.com>
7878 * c-lang.c (c_get_string): Handle non-C-style arrays.
7880 2019-05-08 Tom Tromey <tromey@adacore.com>
7882 * typeprint.c (print_offset_data::update): Print the bit offset,
7883 not the number of bits remaining.
7885 2019-05-08 Tom Tromey <tromey@adacore.com>
7887 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7888 padding at end of comment.
7890 2019-05-08 Tom Tromey <tromey@adacore.com>
7892 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7895 2019-05-06 Tom Tromey <tom@tromey.com>
7897 * common/scoped_mmap.c: Include common-defs.h.
7898 * common/scoped_mmap.h: Don't include config.h.
7900 2019-05-04 Tom Tromey <tom@tromey.com>
7902 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7903 (struct aarch64_call_info): Add initializers.
7904 <si>: Now a std::vector.
7905 (pass_on_stack, aarch64_push_dummy_call): Update.
7907 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
7908 Tom Tromey <tom@tromey.com>
7910 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7911 (ppc_threads): Now a std::vector. Now static.
7912 (hwdebug_find_thread_points_by_tid)
7913 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7916 2019-05-04 Tom Tromey <tom@tromey.com>
7918 * arc-tdep.c (arc_tdesc_init): Return bool.
7920 2019-05-04 Tom Tromey <tom@tromey.com>
7922 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7923 Use gdb_assert_not_reached.
7925 2019-05-04 Tom Tromey <tom@tromey.com>
7927 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7930 2019-05-04 Tom Tromey <tom@tromey.com>
7932 * arc-tdep.c (arc_tdesc_init): Use bool.
7934 2019-05-04 Tom Tromey <tom@tromey.com>
7936 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7938 2019-05-04 Tom Tromey <tom@tromey.com>
7940 * cli/cli-cmds.c (valid_command_p): Return bool.
7942 2019-05-04 Tom Tromey <tom@tromey.com>
7944 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7945 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7947 2019-05-04 Raul Tambre <raul@tambre.ee>
7949 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7950 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7951 operator for comparison.
7953 2019-05-04 Tom Tromey <tom@tromey.com>
7955 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7956 (lookup_partial_symbol, print_partial_symbols)
7957 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7958 (psymbol_compare): Update.
7959 (add_psymbol_to_bcache): Clear the entire psymbol.
7960 (maintenance_check_psymtabs): Update.
7961 * psympriv.h (struct partial_symbol): Don't derive from
7962 general_symbol_info.
7963 <obj_section, unrelocated_address, address,
7964 set_unrelocated_address>: Update.
7965 <ginfo>: New member.
7966 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7967 (debug_names::write_psymbols): Update.
7969 2019-05-04 Tom de Vries <tdevries@suse.de>
7971 * contrib/cc-with-tweaks.sh: Support -n arg.
7973 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7975 * corelow.c (core_target::detach): Ensure frame cache and
7976 register caches are cleared.
7977 inferior.c (exit_inferior_1): Likewise.
7979 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7980 Tom Tromey <tom@tromey.com>
7982 * dictionary.c (collate_pending_symbols_by_language): Remove
7983 "struct" from foreach.
7984 * symtab.c (lookup_global_symbol_from_objfile)
7985 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7987 * ser-tcp.c (net_open): Remove "struct" from foreach.
7988 * objfiles.c (objfile_relocate, objfile_rebase)
7989 (objfile_has_symbols): Remove "struct" from foreach.
7990 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7992 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7994 * darwin-nat.c (thread_info_from_private_thread_info): Remove
7995 "struct" from foreach.
7996 * ada-lang.c (create_excep_cond_exprs)
7997 (ada_exception_catchpoint_cond_string): Remove "struct" from
8000 2019-05-03 Tom Tromey <tromey@adacore.com>
8002 * ada-exp.y (convert_char_literal): Check suffix of each
8005 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
8008 * ada-exp.y (yywrap): Don't define.
8009 * ada-lex.l (%option): Add noyywrap
8012 2019-05-03 Eli Zaretskii <eliz@gnu.org>
8014 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8015 _WIN32_WINNT to the XP level, unless already defined to a higher
8018 * unittests/parse-connection-spec-selftests.c:
8020 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
8023 * symfile.c (find_separate_debug_file): Remove colon from the
8024 drive spec of DOS/Windows file names of the target, so that the
8025 file name produced from DEBUGDIR and the target's directory will
8026 be valid on DOS/Windows systems.
8028 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
8030 * rust-lang.c (val_print_struct): Handle printing structures
8033 2019-05-02 Tom Tromey <tromey@adacore.com>
8035 * valarith.c (_initialize_valarith): Remove.
8037 2019-05-01 Tom Tromey <tromey@adacore.com>
8039 * ada-lang.c (ada_value_primitive_field): Treat more fields as
8042 2019-05-01 Tom Tromey <tromey@adacore.com>
8044 * ada-lang.c (ada_value_assign): Correctly compute starting offset
8045 for big-endian copies.
8047 2019-04-30 Ali Tamur <tamur@google.com>
8048 * gdb/dwarf2read.c (read_3_bytes): New declaration.
8049 (read_attribute_value): Added DW_FORM_strx1-4 cases.
8050 (read_3_bytes): New function.
8052 2019-04-30 Joel Brobecker <brobecker@adacore.com>
8054 * windows-nat.c (main_thread_id): Delete.
8055 (handle_output_debug_string): Replace main_thread_id by
8056 current_event.dwThreadId.
8057 (fake_create_process): Likewise.
8058 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8059 Do not set main_thread_id.
8060 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8061 current_event.dwThreadId.
8062 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8064 2019-04-30 Joel Brobecker <brobecker@adacore.com>
8066 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8067 Use current_event.dwThreadId instead of main_thread_id.
8069 2019-04-30 Tom Tromey <tromey@adacore.com>
8071 * ada-lang.c (ada_lookup_simple_minsyms): New function.
8072 (create_excep_cond_exprs): Iterate over program spaces.
8073 (ada_exception_catchpoint_cond_string): Examine all minimal
8074 symbols for exception types.
8076 2019-04-30 Tom Tromey <tromey@adacore.com>
8079 * dwarf2read.c (process_structure_scope): Handle case where type
8080 has template parameters but no symbol was created.
8082 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8083 Chris January <chris.january@arm.com>
8085 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8087 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8089 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8091 * f-typeprint.c (f_print_type): Update rules for printing
8093 (f_type_print_varspec_suffix): Likewise.
8095 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8096 Chris January <chris.january@arm.com>
8098 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8101 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8103 * f-lang.c (build_fortran_types): Change name of void type to
8105 * f-typeprint.c (f_type_print_base): Print the name of the void
8106 type, rather than a fixed string.
8107 * f-valprint.c (f_decorations): Use lower case void string.
8109 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8110 Chris January <chris.january@arm.com>
8112 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8115 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8116 Chris January <chris.january@arm.com>
8117 David Lecomber <david.lecomber@arm.com>
8119 * f-exp.y (BINOP_INTRINSIC): New token.
8120 (exp): New parser rule handling BINOP_INTRINSIC.
8121 (f77_keywords): Add new builtin procedures.
8122 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8123 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8124 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8125 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8126 (print_unop_subexp_f): New function.
8127 (print_binop_subexp_f): New function.
8128 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8129 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8130 (dump_subexp_body_f): Likewise.
8131 (operator_check_f): Likewise.
8132 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8133 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8135 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8137 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8139 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8140 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8141 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8142 (operator_length_f): New fuction.
8143 (print_subexp_f): New function.
8144 (op_name_f): New function.
8145 (dump_subexp_body_f): New function.
8146 (operator_check_f): New function.
8147 (exp_descriptor_f): Replace standard expression handling functions
8149 * gdb/fortran-operator.def: New file.
8150 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8151 * gdb/std-operator.def: Remove UNOP_KIND.
8153 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8155 * std-operator.def: Remove unbalanced, stray double quote
8158 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8159 Chris January <chris.january@arm.com>
8160 Daniel Everett <daniel.everett@arm.com>
8161 Nick Forrington <nick.forrington@arm.com>
8162 Richard Bunt <richard.bunt@arm.com>
8164 * cp-valprint.c (cp_print_value_fields): Allow an additional level
8165 of depth when printing anonymous structs or unions.
8166 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8167 Don't print either the top-level value, or the children if the
8168 max-depth is exceeded.
8169 (ppscm_print_children): When printing the key of a map, allow one
8170 extra level of depth.
8171 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8172 print either the top-level value, or the children if the max-depth
8174 (print_children): When printing the key of a map, allow one extra
8176 * python/py-value.c (valpy_format_string): Add max_depth keyword.
8177 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8178 (user_print_options): Initialise max_depth field.
8179 (val_print_scalar_or_string_type_p): New function.
8180 (val_print): Check to see if the max depth has been reached.
8181 (val_print_check_max_depth): Define new function.
8182 (show_print_max_depth): New function.
8183 (_initialize_valprint): Add 'print max-depth' option.
8184 * valprint.h (struct value_print_options) <max_depth>: New field.
8185 (val_print_check_max_depth): Declare new function.
8186 * NEWS: Document new feature.
8188 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8190 * ada-lang.c (ada_language_defn): Initialise new field.
8191 * c-lang.c (c_is_string_type_p): New function.
8192 (c_language_defn): Initialise new field.
8193 (cplus_language_defn): Initialise new field.
8194 (asm_language_defn): Initialise new field.
8195 (minimal_language_defn): Initialise new field.
8196 * c-lang.h (c_is_string_type_p): Declare new function.
8197 * d-lang.c (d_language_defn): Initialise new field.
8198 * f-lang.c (f_is_string_type_p): New function.
8199 (f_language_defn): Initialise new field.
8200 * go-lang.c (go_is_string_type_p): New function.
8201 (go_language_defn): Initialise new field.
8202 * language.c (default_is_string_type_p): New function.
8203 (unknown_language_defn): Initialise new field.
8204 (auto_language_defn): Initialise new field.
8205 * language.h (struct language_defn) <la_is_string_type_p>: New
8207 (default_is_string_type_p): Declare new function.
8208 * m2-lang.c (m2_language_defn): Initialise new field.
8209 * objc-lang.c (objc_language_defn): Initialise new field.
8210 * opencl-lang.c (opencl_language_defn): Initialise new field.
8211 * p-lang.c (pascal_is_string_type_p): New function.
8212 (pascal_language_defn): Initialise new field.
8213 * rust-lang.c (rust_is_string_type_p): New function.
8214 (rust_language_defn): Initialise new field.
8216 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8218 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8220 * ada-lang.c (ada_language_defn): Initialise new field.
8221 * c-lang.c (c_language_defn): Likewise.
8222 (cplus_language_defn): Likewise.
8223 (asm_language_defn): Likewise.
8224 (minimal_language_defn): Likewise.
8225 * d-lang.c (d_language_defn): Likewise.
8226 * f-lang.c (f_language_defn): Likewise.
8227 * go-lang.c (go_language_defn): Likewise.
8228 * language.c (unknown_language_defn): Likewise.
8229 (auto_language_defn): Likewise.
8230 * m2-lang.c (m2_language_defn): Likewise.
8231 * objc-lang.c (objc_language_defn): Likewise.
8232 * opencl-lang.c (opencl_language_defn): Likewise.
8233 * p-lang.c (pascal_language_defn): Likewise.
8234 * rust-lang.c (rust_language_defn): Likewise.
8236 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8238 * ada-lang.c (ada_is_character_type): Change return type to bool.
8239 (ada_is_string_type): Likewise.
8240 * ada-lang.h (ada_is_character_type): Update declaration
8241 (ada_is_string_type): Likewise.
8243 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8245 Support style in 'frame|thread apply'
8247 * gdbcmd.h (execute_command_to_string): New term_out parameter.
8248 * record.c (record_start, record_stop): Update callers of
8249 execute_command_to_string with false.
8250 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8251 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8253 (class string_file): New constructor with term_out parameter.
8254 Override methods term_out and can_emit_style_escape. New member
8256 (class stdio_file): Override can_emit_style_escape.
8257 (class tee_file): Override term_out and can_emit_style_escape.
8258 * utils.h (can_emit_style_escape): Remove.
8259 * utils.c (can_emit_style_escape): Likewise.
8260 Update all callers of can_emit_style_escape (SOMESTREAM) to
8261 SOMESTREAM->can_emit_style_escape.
8262 * source-cache.c (source_cache::get_source_lines): Likewise.
8263 * stack.c (frame_apply_command_count): Call execute_command_to_string
8264 passing the term_out characteristic of the current gdb_stdout.
8265 * thread.c (thr_try_catch_cmd): Likewise.
8266 * top.c (execute_command_to_string): pass term_out parameter
8267 to construct the string_file for the command output.
8268 * ui-file.c (term_cli_styling): New function (most code moved
8269 from utils.c can_emit_style_escape).
8270 (string_file::string_file, string_file::can_emit_style_escape,
8271 stdio_file::can_emit_style_escape, tee_file::term_out,
8272 tee_file::can_emit_style_escape): New functions.
8274 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8276 * NEWS: Mention the new set|show may-call-functions.
8277 * infcall.c (may_call_functions_p): New variable.
8278 (show_may_call_functions_p): New function.
8279 (call_function_by_hand_dummy): Throws an error if not
8281 (_initialize_infcall): Call add_setshow_boolean_cmd for
8284 2019-04-25 Keith Seitz <keiths@redhat.com>
8287 * cp-support.c (inspect_type): Don't attempt substitutions
8288 of symbol with the same name.
8290 2019-04-25 Tom Tromey <tromey@adacore.com>
8293 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8296 2019-04-25 Tom Tromey <tromey@adacore.com>
8298 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8300 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8301 (gdb_xml_parser::parse): Use std::move.
8302 * python/python-internal.h (gdbpy_convert_exception): Take a const
8304 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8306 * python/py-utils.c (gdbpy_convert_exception): Take a const
8308 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8310 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8312 * mi/mi-main.c (mi_print_exception): Take a const reference.
8313 * main.c (handle_command_errors): Take a const reference.
8314 * linespec.c (parse_linespec): Use std::move.
8315 * infcall.c (run_inferior_call): Use std::move.
8316 (call_function_by_hand_dummy): Use std::move.
8317 * exec.c (try_open_exec_file): Use std::move.
8318 * exceptions.h (exception_print, exception_fprintf)
8319 (exception_print_same): Update.
8320 * exceptions.c (print_exception, exception_print)
8321 (exception_fprintf, exception_print_same): Change parameters to
8323 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8324 * common/new-op.c: Use std::move.
8325 * common/common-exceptions.h (struct gdb_exception): Add move
8327 (struct gdb_exception_error, struct gdb_exception_quit, struct
8328 gdb_quit_bad_alloc): Change constructor to move constructor.
8329 (throw_exception): Change parameter to rvalue reference.
8330 * common/common-exceptions.c (throw_exception): Take rvalue
8332 * cli/cli-interp.c (safe_execute_command): Use std::move.
8333 * breakpoint.c (insert_bp_location, location_to_sals): Use
8336 2019-04-25 Tom Tromey <tromey@adacore.com>
8338 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8339 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8340 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8341 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8342 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8343 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8344 guile/scm-value.c: Use unpack.
8345 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8346 gdbscm_gdb_exception.
8347 (gdbscm_throw_gdb_exception): Likewise.
8348 (struct gdbscm_gdb_exception): New.
8349 (unpack): New function.
8350 (gdbscm_wrap): Use unpack.
8352 2019-04-25 Tom Tromey <tromey@adacore.com>
8354 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8355 (gdb_rl_callback_handler): Use std::move.
8356 * common/common-exceptions.h (struct gdb_exception): Add move
8357 assignment operator.
8358 (throw_exception_sjlj): Change "exception" to const reference.
8359 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8360 (throw_exception_sjlj): Change "exception" to const reference.
8362 2019-04-25 Tom Tromey <tromey@adacore.com>
8364 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8365 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8366 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8368 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8370 * mi/mi-interp.c (mi_interp::exec): Update.
8371 * linespec.c (parse_linespec): Update.
8372 * infcall.c (run_inferior_call): Update.
8373 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8374 * guile/scm-symbol.c (gdbscm_lookup_symbol)
8375 (gdbscm_lookup_global_symbol): Update.
8376 * guile/scm-param.c (gdbscm_parameter_value): Update.
8377 * guile/scm-frame.c (gdbscm_frame_read_register)
8378 (gdbscm_frame_read_var): Update.
8379 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8380 * exec.c (try_open_exec_file): Update.
8381 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8382 (gdb_rl_callback_handler): Update.
8383 * common/common-exceptions.h (exception_none): Don't declare.
8384 * common/common-exceptions.c (exception_none): Don't define.
8385 (struct catcher) <exception>: Update.
8386 * cli/cli-interp.c (safe_execute_command): Update.
8387 * breakpoint.c (insert_bp_location, location_to_sals): Update.
8389 2019-04-25 Ali Tamur <tamur@google.com>
8391 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8392 (read_attribute_value): Likewise.
8393 (dwarf2_read_addr_index): Update comment.
8394 (read_str_index): Add DW_FORM_strx.
8395 (dwarf2_string_attr): Likewise.
8396 (dwarf2_const_value_attr): Likewise.
8397 (dump_die_shallow): Likewise.
8398 (dwarf2_fetch_constant_bytes): Likewise.
8399 (skip_form_bytes): Likewise.
8400 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8402 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
8406 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8407 OFFSET. Verify if current mapping contains an ELF header.
8408 (linux_find_memory_regions_full): Adjust call to
8411 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
8412 Kang Li <kanglictf@gmail.com>
8416 * dwarf2-frame.c (read_initial_length): Be consistent about using
8417 unsigned representation of length.
8418 (decode_frame_entry_1): Likewise. Check for wraparound of
8419 end pointer as well as buffer overflow.
8421 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
8423 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8426 2019-04-24 Tom Tromey <tromey@adacore.com>
8428 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8430 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8432 * s12z-tdep.c (s12z_unwind_pc): Delete.
8433 (s12z_unwind_sp): Delete.
8434 (s12z_gdbarch_init): Don't register deleted functions with
8437 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8439 * rl78-tdep.c (rl78_unwind_sp): Delete.
8440 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8442 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8444 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8445 (xstormy16_unwind_pc): Delete.
8446 (xstormy16_dummy_id): Delete.
8447 (xstormy16_gdbarch_init): Don't register deleted functions with
8450 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8452 * vax-tdep.c (vax_unwind_pc): Delete.
8453 (vax_gdbarch_init): Don't register deleted function with gdbarch.
8455 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8457 * v850-tdep.c (v850_unwind_sp): Delete.
8458 (v850_unwind_pc): Delete.
8459 (v850_dummy_id): Delete.
8460 (v850_gdbarch_init): Don't register deleted functions with
8463 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8465 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8466 (tilegx_unwind_pc): Delete.
8467 (tilegx_unwind_dummy_id): Delete.
8468 (tilegx_gdbarch_init): Don't register deleted functions with
8471 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8473 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8474 (tic6x_dummy_id): Delete.
8475 (tic6x_gdbarch_init): Don't register deleted functions with
8478 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8480 * sparc-tdep.c (sparc_unwind_pc): Delete.
8481 (sparc32_gdbarch_init): Don't register deleted function with
8484 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8486 * sh-tdep.c (sh_unwind_sp): Delete.
8487 (sh_unwind_pc): Delete.
8488 (sh_dummy_id): Delete.
8489 (sh_gdbarch_init): Don't register deleted functions with
8492 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8494 * score-tdep.c (score_unwind_sp): Delete.
8495 (score_unwind_pc): Delete.
8496 (score_dummy_id): Delete.
8497 (score_gdbarch_init): Don't register deleted functions with
8500 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8502 * rx-tdep.c (rx_unwind_pc): Delete.
8503 (rx_unwind_sp): Delete.
8504 (rx_dummy_id): Delete.
8505 (rx_gdbarch_init): Don't register deleted functions with
8506 gdbarch. Update comment.
8508 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8510 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8511 (rs6000_dummy_id): Delete.
8512 (rs6000_gdbarch_init): Don't register deleted functions with
8515 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8517 * or1k-tdep.c (or1k_dummy_id): Delete.
8518 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8520 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8522 * nios2-tdep.c (nios2_dummy_id): Delete.
8523 (nios2_unwind_sp): Delete.
8524 (nios2_gdbarch_init): Don't register deleted functions with
8527 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8529 * nds32-tdep.c (nds32_dummy_id): Delete.
8530 (nds32_unwind_pc): Delete.
8531 (nds32_unwind_sp): Delete.
8532 (nds32_gdbarch_init): Don't register deleted functions with
8535 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8537 * msp430-tdep.c (msp430_unwind_pc): Delete.
8538 (msp430_unwind_sp): Delete.
8539 (msp430_dummy_id): Delete.
8540 (msp430_gdbarch_init): Don't register deleted functions with
8543 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8545 * moxie-tdep.c (moxie_unwind_sp): Delete.
8546 (moxie_unwind_pc): Delete.
8547 (moxie_dummy_id): Delete.
8548 (moxie_gdbarch_init): Don't register deleted functions with
8551 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8553 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8554 (mn10300_unwind_pc): Delete.
8555 (mn10300_unwind_sp): Delete.
8556 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8558 (mn10300_frame_unwind_init): Don't register deleted functions with
8561 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8563 * mep-tdep.c (mep_unwind_pc): Delete.
8564 (mep_unwind_sp): Delete.
8565 (mep_dummy_id): Delete.
8566 (mep_gdbarch_init): Don't register deleted functions with
8569 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8571 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8572 (m68hc11_unwind_sp): Delete.
8573 (m68hc11_gdbarch_init): Don't register deleted functions with
8576 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8578 * m32r-tdep.c (m32r_unwind_sp): Delete.
8579 (m32r_unwind_pc): Delete.
8580 (m32r_dummy_id): Delete.
8581 (m32r_gdbarch_init): Don't register deleted functions with
8584 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8586 * m32c-tdep.c (m32c_unwind_pc): Delete.
8587 (m32c_unwind_sp): Delete.
8588 (m32c_dummy_id): Delete.
8589 (m32c_gdbarch_init): Don't register deleted functions with
8592 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8594 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8595 (lm32_unwind_pc): Delete.
8596 (lm32_dummy_id): Delete.
8597 (lm32_gdbarch_init): Don't register deleted functions with
8600 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8602 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8603 (iq2000_unwind_pc): Delete.
8604 (iq2000_dummy_id): Delete.
8605 (iq2000_gdbarch_init): Don't register deleted functions with
8608 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8610 * nds32-tdep.c (nds32_type_align): Delete.
8611 (nds32_push_dummy_call): Use type_align instead.
8613 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8615 * arm-tdep.c (arm_type_align): Only handle vector override case.
8616 (arm_push_dummy_call): Use type_align.
8617 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8619 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8621 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8623 (pass_on_stack): Use type_align.
8624 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8627 2019-04-23 Tom Tromey <tromey@adacore.com>
8629 * dwarf2read.c (line_header::file_name_at): Remove unused
8632 2019-04-23 Tom de Vries <tdevries@suse.de>
8635 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8639 2019-03-27 Ali Tamur <tamur@google.com>
8641 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8642 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8643 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8644 (dwarf_expr_context::get_addr_index): Likewise
8645 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8646 (symbol_needs_eval_context::get_addr_index): Likewise
8647 (disassemble_dwarf_expression): Add DW_OP_addrx
8648 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8649 (read_cutu_die_from_dwo): Update comment
8650 (skip_one_die): Add DW_FORM_addrx
8651 (read_attribute_value): Likewise
8652 (var_decode_location): Add DW_OP_addrx
8653 (dwarf2_const_value_attr): Add DW_FORM_addrx
8654 (dump_die_shallow): Likewise
8655 (dwarf2_fetch_constant_bytes): Likewise
8656 (decode_locdesc): Add DW_OP_addrx
8657 (skip_form_bytes): Add DW_FORM_addrx
8659 2019-04-22 Ali Tamur <tamur@google.com>
8661 * MAINTAINERS (Write After Approval): Add self.
8663 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
8665 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8666 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8667 (open_symbol_file_object): Likewise.
8668 (svr4_default_sos): Add info parameter.
8669 (svr4_read_so_list): Likewise.
8670 (svr4_current_sos_direct): Adjust functions calls to pass down
8672 (svr4_current_sos_1): Add info parameter.
8673 (svr4_current_sos): Call get_svr4_info, pass info down to
8675 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8677 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8679 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8681 (probes_table_remove_objfile_probes): Likewise.
8682 (register_solib_event_probe): Add info parameter.
8683 (solist_update_incremental): Pass info parameter down to
8685 (disable_probes_interface): Add info parameter.
8686 (svr4_handle_solib_event): Pass current_program_space to
8687 get_svr4_info. Adjust disable_probes_interface cleanup.
8688 (svr4_create_probe_breakpoints): Add info parameter, pass it
8689 down to register_solib_event_probe.
8690 (svr4_create_solib_event_breakpoints): Add info parameter,
8691 pass it down to svr4_create_probe_breakpoints.
8692 (enable_break): Pass info down to
8693 svr4_create_solib_event_breakpoints.
8694 (svr4_solib_create_inferior_hook): Pass current_program_space to
8696 (svr4_clear_solib): Likewise.
8698 2019-04-22 Pedro Alves <palves@redhat.com>
8700 * solib-svr4.c (svr4_free_objfile_observer): New.
8701 (probe_and_action::objfile): New field.
8702 (probes_table_htab_remove_objfile_probes)
8703 (probes_table_remove_objfile_probes): New functions.
8704 (register_solib_event_probe): Add 'objfile' parameter. Store it
8705 in the new probe_and_action. Don't store the probe in 'lookup'.
8706 (svr4_create_probe_breakpoints): Pass objfile to
8707 register_solib_event_probe.
8708 (_initialize_svr4_solib): Register a free_objfile observer.
8710 2019-04-19 Tom Tromey <tom@tromey.com>
8712 * common/queue.h: Remove.
8714 2019-04-19 Tom Tromey <tom@tromey.com>
8716 * event-loop.c: Don't include "common/queue.h".
8718 2019-04-19 Tom Tromey <tom@tromey.com>
8720 * remote.c (remote_target): Use delete.
8721 * remote-notif.h: Include <list>, not "common/queue.h".
8722 (notif_client_p): Remove typedef.
8723 (remote_notif_state): Add constructor, destructor, initializer.
8724 <notif_queue>: Now a std::list.
8725 (remote_notif_state_xfree): Don't declare.
8726 * remote-notif.c (remote_notif_process, handle_notification)
8727 (remote_notif_state_allocate): Update.
8728 (~remote_notif_state): Rename from remote_notif_state_xfree.
8730 2019-04-19 Tom Tromey <tom@tromey.com>
8732 * symfile.c (reread_symbols): Update.
8733 * objfiles.c (objfile_register_static_link)
8734 (objfile_lookup_static_link): Update
8735 (~objfile) Don't delete static_links.
8736 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8738 2019-04-19 Tom Tromey <tom@tromey.com>
8740 * type-stack.h (struct type_stack) <insert>: Constify string.
8741 * type-stack.c (type_stack::insert): Constify string.
8742 * gdbtypes.h (lookup_template_type): Update.
8743 (address_space_name_to_int): Update.
8744 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8746 (lookup_template_type): Make name const.
8747 * c-exp.y: Update rules.
8748 (lex_one_token, classify_name, classify_inner_name)
8749 (c_print_token): Update.
8750 * p-exp.y: Update rules.
8752 * f-exp.y: Update rules.
8754 * d-exp.y: Update rules.
8755 (lex_one_token, classify_name, classify_inner_name): Update.
8756 * parse.c (write_dollar_variable, copy_name): Return std::string.
8757 * parser-defs.h (copy_name): Change return type.
8758 * m2-exp.y: Update rules.
8760 * go-exp.y (lex_one_token): Update.
8762 (classify_unsafe_function, classify_packaged_name)
8763 (classify_name, yylex): Update.
8765 2019-04-19 Sergei Trofimovich <siarheit@google.com>
8767 * configure.ac: add --enable-source-highlight switch.
8768 * configure: Regenerate.
8769 * top.c (print_gdb_version): plumb --enable-source-highlight
8770 status to "show configuration".
8772 2019-04-19 Tom Tromey <tromey@adacore.com>
8774 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8776 (empty_record, ada_template_to_fixed_record_type_1)
8777 (template_to_static_fixed_type)
8778 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8779 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8780 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8783 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8786 * source.c (print_source_lines_base): Advance "iter" when a
8787 control character is seen.
8789 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8791 * inferior.h (struct infcall_suspend_state_deleter):
8792 Catch exception in destructor to avoid crash.
8794 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8796 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8797 close to the add_com "shell".
8799 2019-04-18 Tom Tromey <tromey@adacore.com>
8801 * process-stratum-target.h (class process_stratum_target)
8802 <stratum>: Add "final".
8804 2019-04-17 Tom Tromey <tromey@adacore.com>
8806 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8807 against nullptr before use.
8809 2019-04-17 Alan Hayward <alan.hayward@arm.com>
8811 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8813 2019-04-17 Jim Wilson <jimw@sifive.com>
8814 Andrew Burgess <andrew.burgess@embecosm.com>
8816 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8817 code read might fail, assume 4-byte breakpoint in that case.
8819 2019-04-15 Leszek Swirski <leszeks@google.com>
8821 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8822 rather than a hand-rolled POD check when checking for forced MEMORY
8825 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8827 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8828 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8830 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8831 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8832 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8835 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8837 * aarch64-linux-nat.c
8838 (aarch64_linux_nat_target::thread_architecture): Add override.
8839 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8842 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8844 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8846 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8848 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8849 target types of size 96-bits, add some additional comments, and
8850 check that the builtin type we found was the correct size.
8852 2019-04-12 Eli Zaretskii <eliz@gnu.org>
8854 * utils.c (prompt_for_continue): Don't restore the styling at the
8855 end, as applied_style has the wrong value. This fixes styling in
8856 long lists of file names that are interrupted by the "Continue?"
8859 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8861 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8862 * c-lang.c (c_language_defn): Likewise.
8863 (cplus_language_defn): Likewise.
8864 (asm_language_defn): Likewise.
8865 (minimal_language_defn): Likewise.
8866 * d-lang.c (d_language_defn): Likewise.
8867 * f-lang.c (f_language_defn): Likewise.
8868 * go-lang.c (go_language_defn): Likewise.
8869 * language.c (unknown_language_defn): Likewise.
8870 (auto_language_defn): Likewise.
8871 * language.h (struct language_defn): Remove la_magic field.
8872 (LANG_MAGIC): Delete.
8873 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8874 * objc-lang.c (objc_language_defn): Likewise.
8875 * opencl-lang.c (opencl_language_defn): Likewise.
8876 * p-lang.c (pascal_language_defn): Likewise.
8877 * rust-lang.c (rust_language_defn): Likewise.
8879 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8881 * riscv-tdep.c (riscv_type_align): New function.
8882 (riscv_type_alignment): Delete.
8883 (riscv_arg_location): Use 'type_align'.
8884 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8886 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8888 * gdbtypes.c (type_align): A struct with no non-static fields also
8891 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8893 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8895 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8897 (riscv_struct_info::analyse): New implementation using new
8898 analyse_inner member function.
8899 (riscv_struct_info::field_offset): New member function.
8900 (riscv_struct_info::m_offsets): New member variable.
8901 (riscv_struct_info::analyse_inner): New private member function,
8902 takes the old implementation of riscv_struct_info::analyse but
8903 extended to track field offsets.
8904 (riscv_call_arg_struct): Update the struct folding special cases
8905 to handle cases where empty C++ structs, which are non-zero
8907 (riscv_arg_location): Initialise the length of each location, a
8908 non-zero length now indicates the location is in use.
8909 (riscv_push_dummy_call): Allow for the first location having a
8910 non-zero offset when setting up arguments.
8911 (riscv_return_value): Likewise, but for return values.
8913 2019-04-11 Tom Tromey <tromey@adacore.com>
8915 * utils.c (internal_vproblem): Make "msg" const.
8917 2019-04-11 Alan Hayward <alan.hayward@arm.com>
8919 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8920 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8921 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8922 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8924 2019-04-10 Kevin Buettner <kevinb@redhat.com>
8926 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8928 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8929 of amd64_collect_native_gregset.
8930 (amd64_linux_nat_target::store_registers): Likewise.
8932 2019-04-10 Tom Tromey <tom@tromey.com>
8934 * symtab.c (lookup_global_symbol_from_objfile)
8935 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8936 * objfiles.h (class separate_debug_iterator): New.
8937 (class separate_debug_range): New.
8938 (struct objfile) <separate_debug_objfiles>: New method.
8939 (objfile_separate_debug_iterate): Don't declare.
8940 * objfiles.c (separate_debug_iterator::operator++): Rename from
8941 objfile_separate_debug_iterate.
8942 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8944 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8947 2019-04-10 Tom Tromey <tom@tromey.com>
8949 * symfile.c (reread_symbols): Remove old comment.
8950 * objfiles.c (free_all_objfiles): Fix a typo.
8952 2019-04-10 Tom Tromey <tom@tromey.com>
8954 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8955 * minsyms.c (lookup_minimal_symbol): Use foreach.
8956 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8957 (lookup_minimal_symbol_solib_trampoline): Likewise.
8958 * symfile.c (reread_symbols): Use foreach.
8960 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
8961 Tom Tromey <tromey@adacore.com>
8964 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8965 (rust_lex_int_test): Change "value" to be LONGEST.
8966 (rust_lex_tests): Add test for long integer literal.
8968 2019-04-09 Tom Tromey <tromey@adacore.com>
8970 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8972 (extended_remote_target::attach): Update.
8973 (remote_target::remote_notice_new_inferior): Update.
8974 (remote_target::add_current_inferior_and_thread): Update.
8975 * inferior.c (exit_inferior_1): Use "false".
8976 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8978 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
8980 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8981 the "start" command.
8983 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8985 * python/py-inferior.c (infpy_thread_from_thread_handle):
8986 Adjust comments to reflect renaming of thread_from_thread_handle
8987 to thread_from_handle. Adjust keywords. Fix type error message.
8988 (inferior_object_methods): Add thread_from_handle. Retain
8989 thread_from_thread_handle, but mark it as deprecated.
8991 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8993 * gdbthread.h (find_thread_by_handle): Revise declaration.
8994 * thread.c (find_thread_by_handle): Likewise. Adjust
8996 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8997 support for buffer objects as handles.
8999 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9001 * python/py-infthread.c (thpy_thread_handle): New function.
9002 (thread_object_methods): Register thpy_thread_handle.
9004 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9006 * gdbthread.h (thread_to_thread_handle): Declare.
9007 * thread.c (gdbtypes.h): Include.
9008 (thread_to_thread_handle): New function.
9010 * target.h (struct target_ops): Add thread_info_to_thread_handle.
9011 (target_thread_info_to_thread_handle): Declare.
9012 * target.c (target_thread_info_to_thread_handle): New function.
9013 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9014 * target-delegates.c: Regenerate.
9016 * linux-thread-db.c (class thread_db_target): Add method
9017 thread_info_to_thread_handle.
9018 (thread_db_target::thread_info_to_thread_handle): Define.
9019 * remote.c (class remote_target): Add new method
9020 thread_info_to_thread_handle.
9021 (remote_target::thread_info_to_thread_handle): Define.
9023 2019-04-08 Pedro Alves <palves@redhat.com>
9025 * common/common-exceptions.c (throw_exception): Don't create
9026 named object to throw; throw directly.
9027 (throw_it): Likewise. Don't initialize gdb_exception::message
9028 here, with new; pass FMT and AP to the ctor instead.
9029 * common/common-exceptions.h: Include <string>.
9030 (gdb_exception::gdb_exception(enum return_reason, enum errors,
9031 const char *, va_list)): New ctor. Use std::make_shared.
9032 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9034 (gdb_exception_error::gdb_exception_error(enum errors, const char
9036 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9038 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9040 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9041 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9044 2019-04-08 Tom Tromey <tom@tromey.com>
9046 * valops.c (value_rtti_indirect_type): Replace throw_exception
9048 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9050 * thread.c (thr_try_catch_cmd): Replace throw_exception with
9052 * target.c (target_translate_tls_address): Replace throw_exception
9054 * stack.c (frame_apply_command_count): Replace throw_exception
9056 * solib-spu.c (append_ocl_sos): Replace throw_exception with
9058 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9060 * rs6000-tdep.c (rs6000_frame_cache)
9061 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9062 * remote.c: Replace throw_exception with throw.
9063 * record-full.c (record_full_message, record_full_wait_1)
9064 (record_full_restore): Replace throw_exception with throw.
9066 (get_thread_current_frame_id, record_btrace_start_replaying)
9067 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9068 (cmd_record_btrace_start): Replace throw_exception with throw.
9069 * parse.c (parse_exp_in_context_1): Replace throw_exception with
9071 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9072 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9074 (find_linespec_symbols): Replace throw_exception with throw.
9075 * infrun.c (displaced_step_prepare, resume): Replace
9076 throw_exception with throw.
9077 * infcmd.c (post_create_inferior): Replace throw_exception with
9079 * inf-loop.c (inferior_event_handler): Replace throw_exception
9081 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9082 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9083 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9084 (get_prev_frame_always, get_frame_pc_if_available)
9085 (get_frame_address_in_block_if_available, get_frame_language):
9086 Replace throw_exception with throw.
9087 * frame-unwind.c (frame_unwind_try_unwinder): Replace
9088 throw_exception with throw.
9089 * eval.c (fetch_subexp_value, evaluate_var_value)
9090 (evaluate_funcall, evaluate_subexp_standard): Replace
9091 throw_exception with throw.
9092 * dwarf2loc.c (call_site_find_chain)
9093 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9094 Replace throw_exception with throw.
9095 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9097 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9099 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9100 * completer.c (complete_line_internal): Replace throw_exception
9102 * compile/compile-object-run.c (compile_object_run): Replace
9103 throw_exception with throw.
9104 * cli/cli-script.c (process_next_line): Replace throw_exception
9106 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9107 (btrace_enable, btrace_maint_update_pt_packets): Replace
9108 throw_exception with throw.
9109 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9110 throw_exception with throw.
9111 * break-catch-throw.c (re_set_exception_catchpoint): Replace
9112 throw_exception with throw.
9113 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9114 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9115 * aarch64-tdep.c (aarch64_make_prologue_cache)
9116 (aarch64_make_stub_cache): Replace throw_exception with throw.
9118 2019-04-08 Tom Tromey <tom@tromey.com>
9120 * common/common-exceptions.c (throw_exception): Rename from
9121 throw_exception_cxx. Remove old copy. Make argument const.
9122 (throw_it): Create and throw exception objects directly.
9123 * common/common-exceptions.h (throw_exception): Make argument
9125 (struct gdb_exception_error): Add constructor.
9126 (struct gdb_exception_quit): Add constructor.
9128 2019-04-08 Tom Tromey <tom@tromey.com>
9130 * common/common-exceptions.h (exception_rethrow): Don't declare.
9131 (TRY_SJLJ): Update comment.
9132 (TRY, CATCH, END_CATCH): Remove.
9133 * common/common-exceptions.c (exception_rethrow): Remove.
9135 2019-04-08 Tom Tromey <tom@tromey.com>
9137 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9139 (gdb_exception_error): Rename from
9140 gdb_exception_RETURN_MASK_ERROR.
9141 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9142 (gdb_quit_bad_alloc): Update.
9143 * aarch64-tdep.c: Update.
9144 * ada-lang.c: Update.
9145 * ada-typeprint.c: Update.
9146 * ada-valprint.c: Update.
9147 * amd64-tdep.c: Update.
9148 * arch-utils.c: Update.
9149 * break-catch-throw.c: Update.
9150 * breakpoint.c: Update.
9152 * c-varobj.c: Update.
9153 * cli/cli-cmds.c: Update.
9154 * cli/cli-interp.c: Update.
9155 * cli/cli-script.c: Update.
9156 * common/common-exceptions.c: Update.
9157 * common/new-op.c: Update.
9158 * common/selftest.c: Update.
9159 * compile/compile-c-symbols.c: Update.
9160 * compile/compile-cplus-symbols.c: Update.
9161 * compile/compile-object-load.c: Update.
9162 * compile/compile-object-run.c: Update.
9163 * completer.c: Update.
9164 * corelow.c: Update.
9166 * cp-support.c: Update.
9167 * cp-valprint.c: Update.
9168 * darwin-nat.c: Update.
9169 * disasm-selftests.c: Update.
9170 * dtrace-probe.c: Update.
9171 * dwarf-index-cache.c: Update.
9172 * dwarf-index-write.c: Update.
9173 * dwarf2-frame-tailcall.c: Update.
9174 * dwarf2-frame.c: Update.
9175 * dwarf2loc.c: Update.
9176 * dwarf2read.c: Update.
9178 * event-loop.c: Update.
9179 * event-top.c: Update.
9181 * f-valprint.c: Update.
9182 * fbsd-tdep.c: Update.
9183 * frame-unwind.c: Update.
9185 * gdbtypes.c: Update.
9186 * gnu-v3-abi.c: Update.
9187 * guile/guile-internal.h: Update.
9188 * guile/scm-block.c: Update.
9189 * guile/scm-breakpoint.c: Update.
9190 * guile/scm-cmd.c: Update.
9191 * guile/scm-disasm.c: Update.
9192 * guile/scm-frame.c: Update.
9193 * guile/scm-lazy-string.c: Update.
9194 * guile/scm-math.c: Update.
9195 * guile/scm-param.c: Update.
9196 * guile/scm-ports.c: Update.
9197 * guile/scm-pretty-print.c: Update.
9198 * guile/scm-symbol.c: Update.
9199 * guile/scm-symtab.c: Update.
9200 * guile/scm-type.c: Update.
9201 * guile/scm-value.c: Update.
9202 * i386-linux-tdep.c: Update.
9203 * i386-tdep.c: Update.
9204 * inf-loop.c: Update.
9205 * infcall.c: Update.
9209 * language.c: Update.
9210 * linespec.c: Update.
9211 * linux-fork.c: Update.
9212 * linux-nat.c: Update.
9213 * linux-tdep.c: Update.
9214 * linux-thread-db.c: Update.
9216 * mi/mi-cmd-break.c: Update.
9217 * mi/mi-cmd-stack.c: Update.
9218 * mi/mi-interp.c: Update.
9219 * mi/mi-main.c: Update.
9220 * objc-lang.c: Update.
9221 * p-valprint.c: Update.
9223 * ppc-linux-tdep.c: Update.
9224 * printcmd.c: Update.
9225 * python/py-arch.c: Update.
9226 * python/py-breakpoint.c: Update.
9227 * python/py-cmd.c: Update.
9228 * python/py-finishbreakpoint.c: Update.
9229 * python/py-frame.c: Update.
9230 * python/py-framefilter.c: Update.
9231 * python/py-gdb-readline.c: Update.
9232 * python/py-inferior.c: Update.
9233 * python/py-infthread.c: Update.
9234 * python/py-lazy-string.c: Update.
9235 * python/py-linetable.c: Update.
9236 * python/py-objfile.c: Update.
9237 * python/py-param.c: Update.
9238 * python/py-prettyprint.c: Update.
9239 * python/py-progspace.c: Update.
9240 * python/py-record-btrace.c: Update.
9241 * python/py-record.c: Update.
9242 * python/py-symbol.c: Update.
9243 * python/py-type.c: Update.
9244 * python/py-unwind.c: Update.
9245 * python/py-utils.c: Update.
9246 * python/py-value.c: Update.
9247 * python/python.c: Update.
9248 * record-btrace.c: Update.
9249 * record-full.c: Update.
9250 * remote-fileio.c: Update.
9252 * riscv-tdep.c: Update.
9253 * rs6000-aix-tdep.c: Update.
9254 * rs6000-tdep.c: Update.
9255 * rust-exp.y: Update.
9256 * rust-lang.c: Update.
9257 * s390-tdep.c: Update.
9258 * selftest-arch.c: Update.
9259 * solib-dsbt.c: Update.
9260 * solib-frv.c: Update.
9261 * solib-spu.c: Update.
9262 * solib-svr4.c: Update.
9264 * sparc64-linux-tdep.c: Update.
9266 * symfile-mem.c: Update.
9267 * symmisc.c: Update.
9271 * tracefile-tfile.c: Update.
9272 * tui/tui.c: Update.
9273 * typeprint.c: Update.
9274 * unittests/cli-utils-selftests.c: Update.
9275 * unittests/parse-connection-spec-selftests.c: Update.
9277 * valprint.c: Update.
9280 * windows-nat.c: Update.
9281 * x86-linux-nat.c: Update.
9282 * xml-support.c: Update.
9284 2019-04-08 Tom Tromey <tom@tromey.com>
9286 * xml-support.c: Use C++ exception handling.
9287 * x86-linux-nat.c: Use C++ exception handling.
9288 * windows-nat.c: Use C++ exception handling.
9289 * varobj.c: Use C++ exception handling.
9290 * value.c: Use C++ exception handling.
9291 * valprint.c: Use C++ exception handling.
9292 * valops.c: Use C++ exception handling.
9293 * unittests/parse-connection-spec-selftests.c: Use C++ exception
9295 * unittests/cli-utils-selftests.c: Use C++ exception handling.
9296 * typeprint.c: Use C++ exception handling.
9297 * tui/tui.c: Use C++ exception handling.
9298 * tracefile-tfile.c: Use C++ exception handling.
9299 * top.c: Use C++ exception handling.
9300 * thread.c: Use C++ exception handling.
9301 * target.c: Use C++ exception handling.
9302 * symmisc.c: Use C++ exception handling.
9303 * symfile-mem.c: Use C++ exception handling.
9304 * stack.c: Use C++ exception handling.
9305 * sparc64-linux-tdep.c: Use C++ exception handling.
9306 * solib.c: Use C++ exception handling.
9307 * solib-svr4.c: Use C++ exception handling.
9308 * solib-spu.c: Use C++ exception handling.
9309 * solib-frv.c: Use C++ exception handling.
9310 * solib-dsbt.c: Use C++ exception handling.
9311 * selftest-arch.c: Use C++ exception handling.
9312 * s390-tdep.c: Use C++ exception handling.
9313 * rust-lang.c: Use C++ exception handling.
9314 * rust-exp.y: Use C++ exception handling.
9315 * rs6000-tdep.c: Use C++ exception handling.
9316 * rs6000-aix-tdep.c: Use C++ exception handling.
9317 * riscv-tdep.c: Use C++ exception handling.
9318 * remote.c: Use C++ exception handling.
9319 * remote-fileio.c: Use C++ exception handling.
9320 * record-full.c: Use C++ exception handling.
9321 * record-btrace.c: Use C++ exception handling.
9322 * python/python.c: Use C++ exception handling.
9323 * python/py-value.c: Use C++ exception handling.
9324 * python/py-utils.c: Use C++ exception handling.
9325 * python/py-unwind.c: Use C++ exception handling.
9326 * python/py-type.c: Use C++ exception handling.
9327 * python/py-symbol.c: Use C++ exception handling.
9328 * python/py-record.c: Use C++ exception handling.
9329 * python/py-record-btrace.c: Use C++ exception handling.
9330 * python/py-progspace.c: Use C++ exception handling.
9331 * python/py-prettyprint.c: Use C++ exception handling.
9332 * python/py-param.c: Use C++ exception handling.
9333 * python/py-objfile.c: Use C++ exception handling.
9334 * python/py-linetable.c: Use C++ exception handling.
9335 * python/py-lazy-string.c: Use C++ exception handling.
9336 * python/py-infthread.c: Use C++ exception handling.
9337 * python/py-inferior.c: Use C++ exception handling.
9338 * python/py-gdb-readline.c: Use C++ exception handling.
9339 * python/py-framefilter.c: Use C++ exception handling.
9340 * python/py-frame.c: Use C++ exception handling.
9341 * python/py-finishbreakpoint.c: Use C++ exception handling.
9342 * python/py-cmd.c: Use C++ exception handling.
9343 * python/py-breakpoint.c: Use C++ exception handling.
9344 * python/py-arch.c: Use C++ exception handling.
9345 * printcmd.c: Use C++ exception handling.
9346 * ppc-linux-tdep.c: Use C++ exception handling.
9347 * parse.c: Use C++ exception handling.
9348 * p-valprint.c: Use C++ exception handling.
9349 * objc-lang.c: Use C++ exception handling.
9350 * mi/mi-main.c: Use C++ exception handling.
9351 * mi/mi-interp.c: Use C++ exception handling.
9352 * mi/mi-cmd-stack.c: Use C++ exception handling.
9353 * mi/mi-cmd-break.c: Use C++ exception handling.
9354 * main.c: Use C++ exception handling.
9355 * linux-thread-db.c: Use C++ exception handling.
9356 * linux-tdep.c: Use C++ exception handling.
9357 * linux-nat.c: Use C++ exception handling.
9358 * linux-fork.c: Use C++ exception handling.
9359 * linespec.c: Use C++ exception handling.
9360 * language.c: Use C++ exception handling.
9361 * jit.c: Use C++ exception handling.
9362 * infrun.c: Use C++ exception handling.
9363 * infcmd.c: Use C++ exception handling.
9364 * infcall.c: Use C++ exception handling.
9365 * inf-loop.c: Use C++ exception handling.
9366 * i386-tdep.c: Use C++ exception handling.
9367 * i386-linux-tdep.c: Use C++ exception handling.
9368 * guile/scm-value.c: Use C++ exception handling.
9369 * guile/scm-type.c: Use C++ exception handling.
9370 * guile/scm-symtab.c: Use C++ exception handling.
9371 * guile/scm-symbol.c: Use C++ exception handling.
9372 * guile/scm-pretty-print.c: Use C++ exception handling.
9373 * guile/scm-ports.c: Use C++ exception handling.
9374 * guile/scm-param.c: Use C++ exception handling.
9375 * guile/scm-math.c: Use C++ exception handling.
9376 * guile/scm-lazy-string.c: Use C++ exception handling.
9377 * guile/scm-frame.c: Use C++ exception handling.
9378 * guile/scm-disasm.c: Use C++ exception handling.
9379 * guile/scm-cmd.c: Use C++ exception handling.
9380 * guile/scm-breakpoint.c: Use C++ exception handling.
9381 * guile/scm-block.c: Use C++ exception handling.
9382 * guile/guile-internal.h: Use C++ exception handling.
9383 * gnu-v3-abi.c: Use C++ exception handling.
9384 * gdbtypes.c: Use C++ exception handling.
9385 * frame.c: Use C++ exception handling.
9386 * frame-unwind.c: Use C++ exception handling.
9387 * fbsd-tdep.c: Use C++ exception handling.
9388 * f-valprint.c: Use C++ exception handling.
9389 * exec.c: Use C++ exception handling.
9390 * event-top.c: Use C++ exception handling.
9391 * event-loop.c: Use C++ exception handling.
9392 * eval.c: Use C++ exception handling.
9393 * dwarf2read.c: Use C++ exception handling.
9394 * dwarf2loc.c: Use C++ exception handling.
9395 * dwarf2-frame.c: Use C++ exception handling.
9396 * dwarf2-frame-tailcall.c: Use C++ exception handling.
9397 * dwarf-index-write.c: Use C++ exception handling.
9398 * dwarf-index-cache.c: Use C++ exception handling.
9399 * dtrace-probe.c: Use C++ exception handling.
9400 * disasm-selftests.c: Use C++ exception handling.
9401 * darwin-nat.c: Use C++ exception handling.
9402 * cp-valprint.c: Use C++ exception handling.
9403 * cp-support.c: Use C++ exception handling.
9404 * cp-abi.c: Use C++ exception handling.
9405 * corelow.c: Use C++ exception handling.
9406 * completer.c: Use C++ exception handling.
9407 * compile/compile-object-run.c: Use C++ exception handling.
9408 * compile/compile-object-load.c: Use C++ exception handling.
9409 * compile/compile-cplus-symbols.c: Use C++ exception handling.
9410 * compile/compile-c-symbols.c: Use C++ exception handling.
9411 * common/selftest.c: Use C++ exception handling.
9412 * common/new-op.c: Use C++ exception handling.
9413 * cli/cli-script.c: Use C++ exception handling.
9414 * cli/cli-interp.c: Use C++ exception handling.
9415 * cli/cli-cmds.c: Use C++ exception handling.
9416 * c-varobj.c: Use C++ exception handling.
9417 * btrace.c: Use C++ exception handling.
9418 * breakpoint.c: Use C++ exception handling.
9419 * break-catch-throw.c: Use C++ exception handling.
9420 * arch-utils.c: Use C++ exception handling.
9421 * amd64-tdep.c: Use C++ exception handling.
9422 * ada-valprint.c: Use C++ exception handling.
9423 * ada-typeprint.c: Use C++ exception handling.
9424 * ada-lang.c: Use C++ exception handling.
9425 * aarch64-tdep.c: Use C++ exception handling.
9427 2019-04-08 Tom Tromey <tom@tromey.com>
9429 * xml-support.c (gdb_xml_parser::parse): Update.
9430 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9431 * value.c (show_convenience): Update.
9432 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9433 (test_parse_flags_qcs): Update.
9434 * thread.c (thr_try_catch_cmd): Update.
9435 * target.c (target_translate_tls_address): Update.
9436 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9437 (info_frame_command_core, frame_apply_command_count): Update.
9438 * rust-exp.y (rust_lex_exception_test): Update.
9439 * riscv-tdep.c (riscv_print_one_register_info): Update.
9440 * remote.c (remote_target::enable_btrace): Update.
9441 * record-btrace.c (record_btrace_enable_warn): Update.
9442 * python/py-utils.c (gdbpy_convert_exception): Update.
9443 * printcmd.c (do_one_display, print_variable_and_value): Update.
9444 * mi/mi-main.c (mi_print_exception): Update.
9445 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9446 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9447 * linux-nat.c (linux_nat_target::attach): Update.
9448 * linux-fork.c (class scoped_switch_fork_info): Update.
9449 * infrun.c (displaced_step_prepare): Update.
9450 * infcall.c (call_function_by_hand_dummy): Update.
9451 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9452 * gnu-v3-abi.c (print_one_vtable): Update.
9453 * frame.c (get_prev_frame_always): Update.
9454 * f-valprint.c (info_common_command_for_block): Update.
9455 * exec.c (try_open_exec_file): Update.
9456 * exceptions.c (print_exception, exception_print)
9457 (exception_fprintf, exception_print_same): Update.
9458 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9459 * dwarf-index-cache.c (index_cache::store)
9460 (index_cache::lookup_gdb_index): Update.
9461 * darwin-nat.c (maybe_cache_shell): Update.
9462 * cp-valprint.c (cp_print_value_fields): Update.
9463 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9464 (gcc_cplus_symbol_address): Update.
9465 * compile/compile-c-symbols.c (gcc_convert_symbol)
9466 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9467 * common/selftest.c: Update.
9468 * common/common-exceptions.h (struct gdb_exception) <message>: Now
9470 (exception_try_scope_entry, exception_try_scope_exit): Don't
9472 (struct exception_try_scope): Remove.
9473 (TRY): Don't use exception_try_scope.
9474 (struct gdb_exception): Add constructor, operator=.
9476 (struct gdb_exception_RETURN_MASK_ALL)
9477 (struct gdb_exception_RETURN_MASK_ERROR)
9478 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9479 (struct gdb_quit_bad_alloc): Update.
9480 * common/common-exceptions.c (exception_none): Change
9482 (struct catcher) <state, exception>: Initialize inline.
9483 <prev>: Remove member.
9484 (current_catcher): Remove.
9485 (catchers): New global.
9486 (exceptions_state_mc_init): Simplify.
9487 (catcher_pop): Remove.
9488 (exceptions_state_mc, exceptions_state_mc_catch): Update.
9489 (try_scope_depth, exception_try_scope_entry)
9490 (exception_try_scope_exit): Remove.
9491 (throw_exception_sjlj): Update.
9492 (exception_messages, exception_messages_size): Remove.
9493 (throw_it): Simplify.
9494 (gdb_exception_sliced_copy): Remove.
9495 (throw_exception_cxx): Update.
9496 * cli/cli-script.c (script_from_file): Update.
9497 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9499 * ada-valprint.c (ada_val_print): Update.
9500 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9501 (create_excep_cond_exprs): Update.
9503 2019-04-08 Tom Tromey <tom@tromey.com>
9505 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9506 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9507 (TRY, CATCH, END_CATCH): Remove some definitions.
9508 * common/common-exceptions.c: Don't use GDB_XCPT.
9509 (catcher_list_size): Remove.
9510 (throw_exception, throw_it): Simplify.
9512 2019-04-05 Tom Tromey <tom@tromey.com>
9514 Revert the header-sorting patch.
9515 * ft32-tdep.c: Revert.
9516 * frv-tdep.c: Revert.
9517 * frv-linux-tdep.c: Revert.
9519 * frame-unwind.c: Revert.
9520 * frame-base.c: Revert.
9521 * fork-child.c: Revert.
9522 * findvar.c: Revert.
9523 * findcmd.c: Revert.
9524 * filesystem.c: Revert.
9525 * filename-seen-cache.h: Revert.
9526 * filename-seen-cache.c: Revert.
9527 * fbsd-tdep.c: Revert.
9528 * fbsd-nat.h: Revert.
9529 * fbsd-nat.c: Revert.
9530 * f-valprint.c: Revert.
9531 * f-typeprint.c: Revert.
9533 * extension.h: Revert.
9534 * extension.c: Revert.
9535 * extension-priv.h: Revert.
9536 * expprint.c: Revert.
9539 * exceptions.c: Revert.
9540 * event-top.c: Revert.
9541 * event-loop.c: Revert.
9543 * elfread.c: Revert.
9544 * dwarf2read.h: Revert.
9545 * dwarf2read.c: Revert.
9546 * dwarf2loc.c: Revert.
9547 * dwarf2expr.h: Revert.
9548 * dwarf2expr.c: Revert.
9549 * dwarf2-frame.c: Revert.
9550 * dwarf2-frame-tailcall.c: Revert.
9551 * dwarf-index-write.h: Revert.
9552 * dwarf-index-write.c: Revert.
9553 * dwarf-index-common.c: Revert.
9554 * dwarf-index-cache.h: Revert.
9555 * dwarf-index-cache.c: Revert.
9556 * dummy-frame.c: Revert.
9557 * dtrace-probe.c: Revert.
9560 * disasm-selftests.c: Revert.
9561 * dictionary.c: Revert.
9562 * dicos-tdep.c: Revert.
9563 * demangle.c: Revert.
9566 * darwin-nat.h: Revert.
9567 * darwin-nat.c: Revert.
9568 * darwin-nat-info.c: Revert.
9569 * d-valprint.c: Revert.
9570 * d-namespace.c: Revert.
9573 * csky-tdep.c: Revert.
9574 * csky-linux-tdep.c: Revert.
9575 * cris-tdep.c: Revert.
9576 * cris-linux-tdep.c: Revert.
9577 * cp-valprint.c: Revert.
9578 * cp-support.c: Revert.
9579 * cp-namespace.c: Revert.
9581 * corelow.c: Revert.
9582 * corefile.c: Revert.
9583 * continuations.c: Revert.
9584 * completer.h: Revert.
9585 * completer.c: Revert.
9586 * complaints.c: Revert.
9587 * coffread.c: Revert.
9588 * coff-pe-read.c: Revert.
9589 * cli-out.h: Revert.
9590 * cli-out.c: Revert.
9591 * charset.c: Revert.
9592 * c-varobj.c: Revert.
9593 * c-valprint.c: Revert.
9594 * c-typeprint.c: Revert.
9596 * buildsym.c: Revert.
9597 * buildsym-legacy.c: Revert.
9598 * build-id.h: Revert.
9599 * build-id.c: Revert.
9601 * bsd-uthread.c: Revert.
9602 * breakpoint.h: Revert.
9603 * breakpoint.c: Revert.
9604 * break-catch-throw.c: Revert.
9605 * break-catch-syscall.c: Revert.
9606 * break-catch-sig.c: Revert.
9607 * blockframe.c: Revert.
9609 * bfin-tdep.c: Revert.
9610 * bfin-linux-tdep.c: Revert.
9611 * bfd-target.c: Revert.
9613 * ax-general.c: Revert.
9616 * avr-tdep.c: Revert.
9618 * auto-load.c: Revert.
9619 * arm-wince-tdep.c: Revert.
9620 * arm-tdep.c: Revert.
9621 * arm-symbian-tdep.c: Revert.
9622 * arm-pikeos-tdep.c: Revert.
9623 * arm-obsd-tdep.c: Revert.
9624 * arm-nbsd-tdep.c: Revert.
9625 * arm-nbsd-nat.c: Revert.
9626 * arm-linux-tdep.c: Revert.
9627 * arm-linux-nat.c: Revert.
9628 * arm-fbsd-tdep.c: Revert.
9629 * arm-fbsd-nat.c: Revert.
9630 * arm-bsd-tdep.c: Revert.
9631 * arch-utils.c: Revert.
9632 * arc-tdep.c: Revert.
9633 * arc-newlib-tdep.c: Revert.
9634 * annotate.h: Revert.
9635 * annotate.c: Revert.
9636 * amd64-windows-tdep.c: Revert.
9637 * amd64-windows-nat.c: Revert.
9638 * amd64-tdep.c: Revert.
9639 * amd64-sol2-tdep.c: Revert.
9640 * amd64-obsd-tdep.c: Revert.
9641 * amd64-obsd-nat.c: Revert.
9642 * amd64-nbsd-tdep.c: Revert.
9643 * amd64-nbsd-nat.c: Revert.
9644 * amd64-nat.c: Revert.
9645 * amd64-linux-tdep.c: Revert.
9646 * amd64-linux-nat.c: Revert.
9647 * amd64-fbsd-tdep.c: Revert.
9648 * amd64-fbsd-nat.c: Revert.
9649 * amd64-dicos-tdep.c: Revert.
9650 * amd64-darwin-tdep.c: Revert.
9651 * amd64-bsd-nat.c: Revert.
9652 * alpha-tdep.c: Revert.
9653 * alpha-obsd-tdep.c: Revert.
9654 * alpha-nbsd-tdep.c: Revert.
9655 * alpha-mdebug-tdep.c: Revert.
9656 * alpha-linux-tdep.c: Revert.
9657 * alpha-linux-nat.c: Revert.
9658 * alpha-bsd-tdep.c: Revert.
9659 * alpha-bsd-nat.c: Revert.
9660 * aix-thread.c: Revert.
9662 * addrmap.c: Revert.
9663 * ada-varobj.c: Revert.
9664 * ada-valprint.c: Revert.
9665 * ada-typeprint.c: Revert.
9666 * ada-tasks.c: Revert.
9667 * ada-lang.c: Revert.
9668 * aarch64-tdep.c: Revert.
9669 * aarch64-ravenscar-thread.c: Revert.
9670 * aarch64-newlib-tdep.c: Revert.
9671 * aarch64-linux-tdep.c: Revert.
9672 * aarch64-linux-nat.c: Revert.
9673 * aarch64-fbsd-tdep.c: Revert.
9674 * aarch64-fbsd-nat.c: Revert.
9675 * aarch32-linux-nat.c: Revert.
9677 2019-04-05 Tom Tromey <tom@tromey.com>
9679 * ft32-tdep.c: Sort headers.
9680 * frv-tdep.c: Sort headers.
9681 * frv-linux-tdep.c: Sort headers.
9682 * frame.c: Sort headers.
9683 * frame-unwind.c: Sort headers.
9684 * frame-base.c: Sort headers.
9685 * fork-child.c: Sort headers.
9686 * findvar.c: Sort headers.
9687 * findcmd.c: Sort headers.
9688 * filesystem.c: Sort headers.
9689 * filename-seen-cache.h: Sort headers.
9690 * filename-seen-cache.c: Sort headers.
9691 * fbsd-tdep.c: Sort headers.
9692 * fbsd-nat.h: Sort headers.
9693 * fbsd-nat.c: Sort headers.
9694 * f-valprint.c: Sort headers.
9695 * f-typeprint.c: Sort headers.
9696 * f-lang.c: Sort headers.
9697 * extension.h: Sort headers.
9698 * extension.c: Sort headers.
9699 * extension-priv.h: Sort headers.
9700 * expprint.c: Sort headers.
9701 * exec.h: Sort headers.
9702 * exec.c: Sort headers.
9703 * exceptions.c: Sort headers.
9704 * event-top.c: Sort headers.
9705 * event-loop.c: Sort headers.
9706 * eval.c: Sort headers.
9707 * elfread.c: Sort headers.
9708 * dwarf2read.h: Sort headers.
9709 * dwarf2read.c: Sort headers.
9710 * dwarf2loc.c: Sort headers.
9711 * dwarf2expr.h: Sort headers.
9712 * dwarf2expr.c: Sort headers.
9713 * dwarf2-frame.c: Sort headers.
9714 * dwarf2-frame-tailcall.c: Sort headers.
9715 * dwarf-index-write.h: Sort headers.
9716 * dwarf-index-write.c: Sort headers.
9717 * dwarf-index-common.c: Sort headers.
9718 * dwarf-index-cache.h: Sort headers.
9719 * dwarf-index-cache.c: Sort headers.
9720 * dummy-frame.c: Sort headers.
9721 * dtrace-probe.c: Sort headers.
9722 * disasm.h: Sort headers.
9723 * disasm.c: Sort headers.
9724 * disasm-selftests.c: Sort headers.
9725 * dictionary.c: Sort headers.
9726 * dicos-tdep.c: Sort headers.
9727 * demangle.c: Sort headers.
9728 * dcache.h: Sort headers.
9729 * dcache.c: Sort headers.
9730 * darwin-nat.h: Sort headers.
9731 * darwin-nat.c: Sort headers.
9732 * darwin-nat-info.c: Sort headers.
9733 * d-valprint.c: Sort headers.
9734 * d-namespace.c: Sort headers.
9735 * d-lang.c: Sort headers.
9736 * ctf.c: Sort headers.
9737 * csky-tdep.c: Sort headers.
9738 * csky-linux-tdep.c: Sort headers.
9739 * cris-tdep.c: Sort headers.
9740 * cris-linux-tdep.c: Sort headers.
9741 * cp-valprint.c: Sort headers.
9742 * cp-support.c: Sort headers.
9743 * cp-namespace.c: Sort headers.
9744 * cp-abi.c: Sort headers.
9745 * corelow.c: Sort headers.
9746 * corefile.c: Sort headers.
9747 * continuations.c: Sort headers.
9748 * completer.h: Sort headers.
9749 * completer.c: Sort headers.
9750 * complaints.c: Sort headers.
9751 * coffread.c: Sort headers.
9752 * coff-pe-read.c: Sort headers.
9753 * cli-out.h: Sort headers.
9754 * cli-out.c: Sort headers.
9755 * charset.c: Sort headers.
9756 * c-varobj.c: Sort headers.
9757 * c-valprint.c: Sort headers.
9758 * c-typeprint.c: Sort headers.
9759 * c-lang.c: Sort headers.
9760 * buildsym.c: Sort headers.
9761 * buildsym-legacy.c: Sort headers.
9762 * build-id.h: Sort headers.
9763 * build-id.c: Sort headers.
9764 * btrace.c: Sort headers.
9765 * bsd-uthread.c: Sort headers.
9766 * breakpoint.h: Sort headers.
9767 * breakpoint.c: Sort headers.
9768 * break-catch-throw.c: Sort headers.
9769 * break-catch-syscall.c: Sort headers.
9770 * break-catch-sig.c: Sort headers.
9771 * blockframe.c: Sort headers.
9772 * block.c: Sort headers.
9773 * bfin-tdep.c: Sort headers.
9774 * bfin-linux-tdep.c: Sort headers.
9775 * bfd-target.c: Sort headers.
9776 * bcache.c: Sort headers.
9777 * ax-general.c: Sort headers.
9778 * ax-gdb.h: Sort headers.
9779 * ax-gdb.c: Sort headers.
9780 * avr-tdep.c: Sort headers.
9781 * auxv.c: Sort headers.
9782 * auto-load.c: Sort headers.
9783 * arm-wince-tdep.c: Sort headers.
9784 * arm-tdep.c: Sort headers.
9785 * arm-symbian-tdep.c: Sort headers.
9786 * arm-pikeos-tdep.c: Sort headers.
9787 * arm-obsd-tdep.c: Sort headers.
9788 * arm-nbsd-tdep.c: Sort headers.
9789 * arm-nbsd-nat.c: Sort headers.
9790 * arm-linux-tdep.c: Sort headers.
9791 * arm-linux-nat.c: Sort headers.
9792 * arm-fbsd-tdep.c: Sort headers.
9793 * arm-fbsd-nat.c: Sort headers.
9794 * arm-bsd-tdep.c: Sort headers.
9795 * arch-utils.c: Sort headers.
9796 * arc-tdep.c: Sort headers.
9797 * arc-newlib-tdep.c: Sort headers.
9798 * annotate.h: Sort headers.
9799 * annotate.c: Sort headers.
9800 * amd64-windows-tdep.c: Sort headers.
9801 * amd64-windows-nat.c: Sort headers.
9802 * amd64-tdep.c: Sort headers.
9803 * amd64-sol2-tdep.c: Sort headers.
9804 * amd64-obsd-tdep.c: Sort headers.
9805 * amd64-obsd-nat.c: Sort headers.
9806 * amd64-nbsd-tdep.c: Sort headers.
9807 * amd64-nbsd-nat.c: Sort headers.
9808 * amd64-nat.c: Sort headers.
9809 * amd64-linux-tdep.c: Sort headers.
9810 * amd64-linux-nat.c: Sort headers.
9811 * amd64-fbsd-tdep.c: Sort headers.
9812 * amd64-fbsd-nat.c: Sort headers.
9813 * amd64-dicos-tdep.c: Sort headers.
9814 * amd64-darwin-tdep.c: Sort headers.
9815 * amd64-bsd-nat.c: Sort headers.
9816 * alpha-tdep.c: Sort headers.
9817 * alpha-obsd-tdep.c: Sort headers.
9818 * alpha-nbsd-tdep.c: Sort headers.
9819 * alpha-mdebug-tdep.c: Sort headers.
9820 * alpha-linux-tdep.c: Sort headers.
9821 * alpha-linux-nat.c: Sort headers.
9822 * alpha-bsd-tdep.c: Sort headers.
9823 * alpha-bsd-nat.c: Sort headers.
9824 * aix-thread.c: Sort headers.
9825 * agent.c: Sort headers.
9826 * addrmap.c: Sort headers.
9827 * ada-varobj.c: Sort headers.
9828 * ada-valprint.c: Sort headers.
9829 * ada-typeprint.c: Sort headers.
9830 * ada-tasks.c: Sort headers.
9831 * ada-lang.c: Sort headers.
9832 * aarch64-tdep.c: Sort headers.
9833 * aarch64-ravenscar-thread.c: Sort headers.
9834 * aarch64-newlib-tdep.c: Sort headers.
9835 * aarch64-linux-tdep.c: Sort headers.
9836 * aarch64-linux-nat.c: Sort headers.
9837 * aarch64-fbsd-tdep.c: Sort headers.
9838 * aarch64-fbsd-nat.c: Sort headers.
9839 * aarch32-linux-nat.c: Sort headers.
9841 2019-04-04 Tom Tromey <tom@tromey.com>
9843 * varobj.c (varobj_create): Update.
9844 * rust-exp.y (struct rust_parser) <update_innermost_block,
9845 lookup_symbol>: New methods.
9846 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9848 (rust_parser::rust_lookup_type)
9849 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9850 * printcmd.c (display_command, do_one_display): Update.
9851 * parser-defs.h (struct parser_state) <parser_state>: Add
9852 "tracker" parameter.
9853 (block_tracker): New member.
9854 (class innermost_block_tracker) <innermost_block_tracker>: Add
9856 <reset>: Remove method.
9857 (innermost_block): Don't declare.
9858 (null_post_parser): Update.
9859 * parse.c (innermost_block): Remove global.
9860 (write_dollar_variable): Update.
9861 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9862 Remove "tracker_types" parameter.
9863 (parse_expression): Add "tracker" parameter.
9864 (parse_expression_for_completion): Update.
9865 (null_post_parser): Add "tracker" parameter.
9866 * p-exp.y: Update rules.
9867 * m2-exp.y: Update rules.
9868 * language.h (struct language_defn) <la_post_parser>: Add
9869 "tracker" parameter.
9870 * go-exp.y: Update rules.
9871 * f-exp.y: Update rules.
9872 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9874 * d-exp.y: Update rules.
9875 * c-exp.y: Update rules.
9876 * breakpoint.c (set_breakpoint_condition): Create an
9877 innermost_block_tracker.
9878 (watch_command_1): Likewise.
9879 * ada-lang.c (resolve): Add "tracker" parameter.
9880 (resolve_subexp): Likewise.
9881 * ada-exp.y (write_var_from_sym): Update.
9883 2019-04-04 Tom Tromey <tom@tromey.com>
9885 * type-stack.h: New file.
9886 * type-stack.c: New file.
9887 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9889 (insert_into_type_stack, insert_type, push_type, push_type_int)
9890 (insert_type_address_space, pop_type, pop_type_int)
9891 (pop_typelist, pop_type_stack, append_type_stack)
9892 (push_type_stack, get_type_stack, push_typelist)
9893 (follow_type_instance_flags, follow_types): Don't declare.
9894 * parse.c (type_stack): Remove global.
9895 (parse_exp_in_context): Update.
9896 (insert_into_type_stack, insert_type, push_type, push_type_int)
9897 (insert_type_address_space, pop_type, pop_type_int)
9898 (pop_typelist, pop_type_stack, append_type_stack)
9899 (push_type_stack, get_type_stack, push_typelist)
9900 (follow_type_instance_flags, follow_types): Remove (moved to
9902 * f-exp.y (type_stack): New global.
9904 (push_kind_type, f_parse): Update.
9905 * d-exp.y (type_stack): New global.
9908 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9910 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9911 (HFILES_NO_SRCDIR): Add type-stack.h.
9913 2019-04-04 Tom Tromey <tom@tromey.com>
9915 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9916 (rust_parser::convert_ast_to_expression, rust_parse)
9917 (rust_lex_test_completion, rust_lex_tests): Update.
9918 * parser-defs.h (struct expr_completion_state): New.
9919 (struct parser_state) <parser_state>: Add completion parameter.
9920 <mark_struct_expression, mark_completion_tag>: New methods.
9921 <parse_completion, m_completion_state>: New members.
9922 (prefixify_expression, null_post_parser): Update.
9923 (mark_struct_expression, mark_completion_tag): Don't declare.
9924 * parse.c (parse_completion, expout_last_struct)
9925 (expout_tag_completion_type, expout_completion_name): Remove
9927 (parser_state::mark_struct_expression)
9928 (parser_state::mark_completion_tag): Now methods.
9929 (prefixify_expression): Add last_struct parameter.
9930 (prefixify_subexp): Likewise.
9931 (parse_exp_1): Update.
9932 (parse_exp_in_context): Add cstate parameter. Update.
9933 (parse_expression_for_completion): Create an
9934 expr_completion_state.
9935 (null_post_parser): Add "completion" parameter.
9936 * p-exp.y: Update rules.
9938 * language.h (struct language_defn) <la_post_parser>: Add
9939 "completing" parameter.
9940 * go-exp.y: Update rules.
9941 (lex_one_token): Update.
9942 * expression.h (parse_completion): Don't declare.
9943 * d-exp.y: Update rules.
9944 (lex_one_token): Update rules.
9945 * c-exp.y: Update rules.
9946 (lex_one_token): Update.
9947 * ada-lang.c (resolve): Add "parse_completion" parameter.
9948 (resolve_subexp): Likewise.
9949 (ada_resolve_function): Likewise.
9951 2019-04-04 Tom Tromey <tom@tromey.com>
9953 * parser-defs.h (struct parser_state) <start_arglist,
9954 end_arglist>: New methods.
9955 <arglist_len, m_funcall_chain>: New members.
9956 (arglist_len, start_arglist, end_arglist): Don't declare.
9957 * parse.c (arglist_len, funcall_chain): Remove global.
9958 (start_arglist, end_arglist): Remove functions.
9959 (parse_exp_in_context): Update.
9960 * p-exp.y: Update rules.
9961 * m2-exp.y: Update rules.
9962 * go-exp.y: Update rules.
9963 * f-exp.y: Update rules.
9964 * d-exp.y: Update rules.
9965 * c-exp.y: Update rules.
9967 2019-04-04 Tom Tromey <tom@tromey.com>
9969 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9970 lex_operator, push_back>: New methods.
9972 (rust_parser::lex_hex, lex_escape): Rename and update.
9973 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9974 (rust_parser::lex_operator): Rename and update.
9975 (rust_parser::lex_number, rustyylex, rustyyerror)
9976 (rust_lex_test_init, rust_lex_test_sequence)
9977 (rust_lex_test_push_back, rust_lex_tests): Update.
9978 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9980 <lexptr, prev_lexptr>: New members.
9981 (lexptr, prev_lexptr): Don't declare.
9982 * parse.c (lexptr, prev_lexptr): Remove globals.
9983 (parse_exp_in_context): Update.
9984 * p-exp.y (yylex, yyerror): Update.
9985 * m2-exp.y (parse_number, yylex, yyerror): Update.
9986 * go-exp.y (lex_one_token, yyerror): Update.
9987 * f-exp.y (match_string_literal, yylex, yyerror): Update.
9988 * d-exp.y (lex_one_token, yyerror): Update.
9989 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9990 (lex_one_token, yyerror): Update.
9991 * ada-lex.l (YY_INPUT): Update.
9992 (rewind_to_char): Update.
9993 * ada-exp.y (yyerror): Update.
9995 2019-04-04 Tom Tromey <tom@tromey.com>
9997 * rust-exp.y (rustyylex, rust_lex_tests): Update.
9998 * parser-defs.h (struct parser_state) <parser_state>: Add new
10000 <comma_terminates>: New member.
10001 (comma_terminates): Don't declare global.
10002 * parse.c (comma_terminates): Remove global.
10003 (parse_exp_in_context): Update.
10004 * p-exp.y (yylex): Update.
10005 * m2-exp.y (yylex): Update.
10006 * go-exp.y (lex_one_token): Update.
10007 * f-exp.y (yylex): Update.
10008 * d-exp.y (lex_one_token): Update.
10009 * c-exp.y (lex_one_token): Update.
10010 * ada-lex.l: Update.
10012 2019-04-04 Tom Tromey <tom@tromey.com>
10014 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10015 (rustyylex, rust_lex_test_init, rust_lex_test_one)
10016 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10017 * parser-defs.h (paren_depth): Don't declare.
10018 * parse.c (paren_depth): Remove global.
10019 (parse_exp_in_context): Update.
10020 * p-exp.y (paren_depth): New global.
10021 (pascal_parse): Initialize it.
10022 * m2-exp.y (paren_depth): New global.
10023 (m2_parse): Initialize it.
10024 * go-exp.y (paren_depth): New global.
10025 (go_parse): Initialize it.
10026 * f-exp.y (paren_depth): New global.
10027 (f_parse): Initialize it.
10028 * d-exp.y (paren_depth): New global.
10029 (d_parse): Initialize it.
10030 * c-exp.y (paren_depth): New global.
10031 (c_parse): Initialize it.
10032 * ada-lex.l (paren_depth): New global.
10033 (lexer_init): Initialize it.
10035 2019-04-04 Tom Tromey <tom@tromey.com>
10037 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10038 (rust_parser::convert_ast_to_type)
10039 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10040 * parser-defs.h (struct parser_state) <parser_state>: Add
10041 parameters. Initialize new members.
10042 <expression_context_block, expression_context_pc>: New members.
10043 * parse.c (expression_context_block, expression_context_pc):
10045 (parse_exp_in_context): Update.
10046 * p-exp.y: Update all rules.
10048 * m2-exp.y: Update all rules.
10050 * go-exp.y (yylex): Update.
10051 * f-exp.y (yylex): Update.
10052 * d-exp.y: Update all rules.
10054 * c-exp.y: Update all rules.
10055 (lex_one_token, classify_name, yylex, c_parse): Update.
10056 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10058 2019-04-04 Tom Tromey <tom@tromey.com>
10060 * gdbarch.h, gdbarch.c: Rebuild.
10061 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10063 (struct stap_parse_info): Replace "parser_state" with
10065 * parser-defs.h (struct expr_builder): Rename from "parser_state".
10066 (parser_state): New class.
10067 * parse.c (expr_builder): Rename.
10068 (expr_builder::release): Rename.
10069 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10070 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10071 (write_exp_elt_longcst, write_exp_elt_floatcst)
10072 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10073 (write_exp_string_vector, write_exp_bitstring)
10074 (write_exp_msymbol, mark_struct_expression)
10075 (write_dollar_variable)
10076 (insert_type_address_space, increase_expout_size): Replace
10077 "parser_state" with "expr_builder".
10078 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10079 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10080 "parser_state" with "expr_builder".
10082 2019-04-04 Tom Tromey <tom@tromey.com>
10084 * rust-exp.y: Replace "parse_language" with method call.
10086 (yylex): Replace "parse_language" with method call.
10088 (yylex): Replace "parse_language" with method call.
10089 * go-exp.y (classify_name): Replace "parse_language" with method
10091 * f-exp.y (yylex): Replace "parse_language" with method call.
10092 * d-exp.y (lex_one_token): Replace "parse_language" with method
10095 (lex_one_token, classify_name, yylex): Replace "parse_language"
10097 * ada-exp.y (find_primitive_type, type_char)
10098 (type_system_address): Replace "parse_language" with method call.
10100 2019-04-04 Tom Tromey <tom@tromey.com>
10102 * rust-exp.y: Replace "parse_gdbarch" with method call.
10103 * parse.c (write_dollar_variable, insert_type_address_space):
10104 Replace "parse_gdbarch" with method call.
10105 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10107 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10109 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10110 "parse_gdbarch" with method call.
10111 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10113 * f-exp.y (parse_type, parse_f_type, yylex): Replace
10114 "parse_gdbarch" with method call.
10115 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10116 "parse_gdbarch" with method call.
10117 * c-exp.y (parse_type, parse_number, classify_name): Replace
10118 "parse_gdbarch" with method call.
10119 * ada-lex.l: Replace "parse_gdbarch" with method call.
10120 * ada-exp.y (parse_type, find_primitive_type, type_char)
10121 (type_system_address): Replace "parse_gdbarch" with method call.
10123 2019-04-04 Tom Tromey <tom@tromey.com>
10125 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10126 * stap-probe.c (stap_parse_argument): Update.
10127 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10128 initial_size parameter.
10129 * rust-exp.y (rust_lex_tests): Update.
10130 * parse.c (parser_state): Update.
10131 (parse_exp_in_context): Update.
10132 * parser-defs.h (struct parser_state) <parser_state>: Remove
10133 "initial_size" parameter.
10135 2019-04-04 Tom Tromey <tom@tromey.com>
10137 * parser-defs.h (increase_expout_size): Don't declare.
10138 * parse.c (increase_expout_size): Now static.
10140 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
10142 * gnu-nat.c (gnu_nat_target::wait): Fix
10143 target_waitstatus_to_string call.
10145 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
10147 * eval.c (evaluate_subexp_standard): Handle internal functions
10148 during Fortran function call handling.
10150 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
10152 * NEWS: Mention new internal functions.
10153 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10154 (read_base_type): Use dwarf2_init_complex_target_type.
10155 * value.c (creal_internal_fn): New function.
10156 (cimag_internal_fn): New function.
10157 (_initialize_values): Register new internal functions.
10159 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10161 * infrun.c (stop_all_threads): If debug_infrun, always
10162 trace the wait status after wait_one, using
10163 target_waitstatus_to_string and target_pid_to_str.
10164 (handle_inferior_event): Replace various trace of
10165 wait status kind by a single trace.
10166 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10167 wait status kind image by target_waitstatus_to_string.
10168 * target/waitstatus.c (target_waitstatus_to_string): Fix
10171 2019-04-01 Tom Tromey <tromey@adacore.com>
10174 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10176 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
10177 Pedro Alves <palves@redhat.com>
10179 * top.c (quit_force): Call 'finalize_values'.
10180 * value.c (finalize_values): New function.
10181 * value.h (finalize_values): Declare.
10183 2019-03-30 Eli Zaretskii <eliz@gnu.org>
10185 * NEWS: Announce $_gdb_major and $_gdb_minor.
10187 * top.c (init_gdb_version_vars): New function.
10188 (gdb_init): Call init_gdb_version_vars.
10190 2019-03-29 Tom Tromey <tromey@adacore.com>
10192 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
10193 help text. Remove dead code.
10195 2019-03-29 Keith Seitz <keiths@redhat.com>
10197 From Siddhesh Poyarekar:
10198 * f-lang.h (f77_get_upperbound): Return LONGEST.
10199 (f77_get_lowerbound): Likewise.
10200 * f-typeprint.c (f_type_print_varspec_suffix): Expand
10201 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
10203 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
10204 plongest to format print it.
10205 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10206 (f77_get_upperbound): Likewise.
10207 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10208 LOWER_BOUND to LONGEST.
10209 (f77_create_arrayprint_offset_tbl): Likewise.
10211 2019-03-29 Keith Seitz <keiths@redhat.com>
10213 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10214 %s/pulongest for TYPE_LENGTH instead of %d in format
10216 * ada-typerint.c (ada_print_type): Likewise.
10217 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10218 * compile/compile-c-support.c (generate_register_struct): Likewise.
10219 * gdbtypes.c (recursive_dump_type): Likewise.
10220 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10221 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
10222 instead of %d in format strings.
10223 * riscv-tdep.c (riscv_type_alignment): Cast second argument
10224 to std::min to ULONGEST.
10225 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10226 instead of %d in format strings.
10227 * tracepoint.c (info_scope_command): Likewise.
10228 * typeprint.c (print_offset_data::update)
10229 (print_offset_data::finish): Likewise.
10230 * xtensa-tdep.c (xtensa_store_return_value)
10231 (xtensa_push_dummy_call): Likewise.
10233 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
10235 * windows-nat.c (display_selector): Fixed format specifications
10238 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10240 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10242 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
10244 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10245 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10246 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10247 (nios2_linux_init_abi): Install it.
10249 2019-03-28 Alan Hayward <alan.hayward@arm.com>
10251 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10253 2019-03-28 Alan Hayward <alan.hayward@arm.com>
10255 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10257 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10258 Tom Tromey <tromey@adacore.com>
10260 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10262 2019-03-26 Joel Brobecker <brobecker@adacore.com>
10264 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10265 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10266 method to compute the bounds of range types. Also print "[evaluated]"
10267 if the bounds' values come from a dynamic evaluation.
10269 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
10271 * cp-valprint.c (cp_print_value_fields): Don't print trailing
10272 whitespace when pretty printing is on.
10274 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10276 * ppc-linux-nat.c: Add include.
10278 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10280 * NEWS: Mention AArch64 Pointer Authentication.
10282 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10284 * arm-linux-nat.c: Add include.
10286 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
10288 * source-cache.c (source_cache::get_source_lines): Re-read
10289 fullname after calling open_source_file.
10291 2019-03-25 John Baldwin <jhb@FreeBSD.org>
10293 * NEWS: Mention TLS support for FreeBSD.
10295 2019-03-25 Tom Tromey <tromey@adacore.com>
10297 * minsyms.c (BUNCH_SIZE): Update comment.
10298 (~minimal_symbol_reader): Remove old comment.
10299 (compact_minimal_symbols): Update comment.
10300 (minimal_symbol_reader::install): Remove old comment. Update
10303 2019-03-25 Alan Hayward <alan.hayward@arm.com>
10305 * s390-linux-nat.c: Add include.
10307 2019-03-25 Alan Hayward <alan.hayward@arm.com>
10309 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10310 Call linux_get_hwcap.
10311 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10313 (aarch64_linux_get_hwcap): Remove function.
10314 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10316 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10318 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10319 * linux-tdep.c (linux_get_hwcap): Add function.
10320 (linux_get_hwcap2): Likewise.
10321 * linux-tdep.h (linux_get_hwcap): Add declaration.
10322 (linux_get_hwcap2): Likewise.
10323 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10324 (ppc_linux_get_hwcap2): Likewise.
10325 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10327 (ppc_linux_nat_target::insert_watchpoint): Likewise.
10328 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10329 (ppc_linux_nat_target::read_description): Likewise.
10330 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10331 * s390-linux-nat.c: Likewise.
10332 * s390-linux-tdep.c (s390_core_read_description): Likewise.
10334 2019-03-24 Tom Tromey <tom@tromey.com>
10336 * ada-lang.c (standard_lookup): Simplify initialization.
10337 (ada_lookup_symbol_nonlocal): Simplify return.
10338 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10339 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10340 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10341 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10343 * solib.c (solib_global_lookup): Simplify.
10344 * symtab.c (null_block_symbol): Remove.
10345 (symbol_cache_lookup): Simplify returns.
10346 (lookup_language_this): Simplify returns.
10347 (lookup_symbol_aux): Simplify return.
10348 (lookup_local_symbol): Simplify returns.
10349 (lookup_global_symbol_from_objfile): Simplify return.
10350 (lookup_symbol_in_objfile_symtabs)
10351 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10352 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10353 (lookup_static_symbol, lookup_global_symbol): Simplify return.
10354 * cp-namespace.c (cp_lookup_bare_symbol)
10355 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10356 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10357 (cp_lookup_nested_symbol): Don't use null_block_symbol.
10358 (cp_lookup_symbol_via_imports): Simplify initialization.
10359 (find_symbol_in_baseclass): Likewise.
10360 * symtab.h (null_block_symbol): Remove.
10361 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10362 (d_lookup_nested_symbol, d_lookup_symbol_imports)
10363 (d_lookup_symbol_module): Likewise.
10364 (find_symbol_in_baseclass): Simplify initialization.
10366 2019-03-24 Tom Tromey <tom@tromey.com>
10368 * expression.h: Don't include symtab.h.
10369 (struct block): Forward declare.
10371 2019-03-24 Tom Tromey <tom@tromey.com>
10373 * c-exp.y (typebase): Remove casts.
10374 * gdbtypes.c (lookup_unsigned_typename, )
10375 (lookup_signed_typename): Remove cast.
10376 * eval.c (parse_to_comma_and_eval): Remove cast.
10377 * parse.c (write_dollar_variable): Remove cast.
10378 * block.h (struct block) <superblock>: Now const.
10379 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10380 * psymtab.c (psym_map_matching_symbols): Make "block" const.
10381 (map_block): Make "block" const.
10382 * symfile.h (struct quick_symbol_functions)
10383 <map_matching_symbols>: Constify block argument to "callback".
10384 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10386 (find_pc_sect_compunit_symtab): Make "b" const.
10387 (find_symbol_at_address): Likewise.
10388 (search_symbols): Likewise.
10389 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10390 (dw2_debug_names_lookup_symbol): Likewise.
10391 (dw2_map_matching_symbols): Update.
10392 * p-valprint.c (pascal_val_print): Remove "block".
10393 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10394 (aux_add_nonlocal_symbols): Make "block" const.
10395 (resolve_subexp): Remove cast.
10396 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10398 (iterate_over_file_blocks): Likewise.
10399 * f-exp.y (%union) <bval>: Remove.
10400 * coffread.c (patch_opaque_types): Make "b" const.
10401 * spu-tdep.c (spu_catch_start): Make "block" const.
10402 * c-valprint.c (print_unpacked_pointer): Remove "block".
10403 * symmisc.c (dump_symtab_1): Make "b" const.
10404 (block_depth): Make "block" const.
10405 * d-exp.y (%union) <bval>: Remove.
10406 * cp-support.h (cp_lookup_rtti_type): Update.
10407 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10408 * psymtab.c (psym_lookup_symbol): Make "block" const.
10409 (maintenance_check_psymtabs): Make "b" const.
10410 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10411 (enumerate_locals, enumerate_args): Update.
10412 * python/py-symtab.c (stpy_global_block): Make "block" const.
10413 (stpy_static_block): Likewise.
10414 * inline-frame.c (block_starting_point_at): Make "new_block"
10416 * block.c (find_block_in_blockvector): Make return type const.
10417 (blockvector_for_pc_sect): Make "b" const.
10418 (find_block_in_blockvector): Make "b" const.
10420 2019-03-23 Tom Tromey <tom@tromey.com>
10422 * varobj.c (varobj_create): Update.
10423 * symfile.c (clear_symtab_users): Don't reset innermost_block.
10424 * printcmd.c (display_command, do_one_display): Don't reset
10426 * parser-defs.h (enum innermost_block_tracker_type): Move to
10428 (innermost_block): Update comment.
10429 * parse.c (parse_exp_1): Add tracker_types parameter.
10430 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
10431 tracker_types parameter. Reset innermost_block.
10432 (parse_exp_in_context): Remove.
10433 (parse_expression_for_completion): Update.
10434 * objfiles.c (~objfile): Don't reset expression_context_block or
10436 * expression.h (enum innermost_block_tracker_type): Move from
10438 (parse_exp_1): Add tracker_types parameter.
10439 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10440 reset innermost_block.
10442 2019-03-23 Tom Tromey <tom@tromey.com>
10444 * objfiles.h: Include bcache.h.
10446 2019-03-23 Tom Tromey <tom@tromey.com>
10448 * linespec.c (get_current_search_block): Use
10449 scoped_restore_current_language.
10450 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10452 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10453 Jiong Wang <jiong.wang@arm.com>
10455 * aarch64-linux-tdep.c
10456 (aarch64_linux_iterate_over_regset_sections): Check for pauth
10458 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10460 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10461 Jiong Wang <jiong.wang@arm.com>
10463 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10465 (aarch64_analyze_prologue_test): Add PACIASP test.
10466 (aarch64_prologue_prev_register): Unmask PC value.
10468 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10469 Jiong Wang <jiong.wang@arm.com>
10471 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10472 (aarch64_dwarf2_prev_register): Unmask PC value.
10473 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10474 (aarch64_execute_dwarf_cfa_vendor_op): Check for
10475 DW_CFA_AARCH64_negate_ra_state.
10476 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10478 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10479 Jiong Wang <jiong.wang@arm.com>
10481 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10483 (aarch64_pseudo_register_name): Likewise.
10484 (aarch64_pseudo_register_type): Likewise.
10485 (aarch64_pseudo_register_reggroup_p): Likewise.
10486 (aarch64_gdbarch_init): Add pauth registers.
10487 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10488 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10489 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10490 (struct gdbarch_tdep): Add regnum for ra_state.
10492 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10493 Jiong Wang <jiong.wang@arm.com>
10495 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10497 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10498 Jiong Wang <jiong.wang@arm.com>
10500 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10502 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10503 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10504 (aarch64_gdbarch_init): Add puth registers.
10505 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10506 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10507 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10509 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10510 Jiong Wang <jiong.wang@arm.com>
10512 * aarch64-linux-nat.c
10513 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10514 * aarch64-linux-tdep.c
10515 (aarch64_linux_core_read_description): Likewise.
10516 (aarch64_linux_get_hwcap): New function.
10517 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10518 (aarch64_linux_get_hwcap): New declaration.
10520 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10521 Jiong Wang <jiong.wang@arm.com>
10523 * aarch64-linux-nat.c
10524 (aarch64_linux_nat_target::read_description): Add pauth param.
10525 * aarch64-linux-tdep.c
10526 (aarch64_linux_core_read_description): Likewise.
10527 * aarch64-tdep.c (struct target_desc): Add in pauth.
10528 (aarch64_read_description): Add pauth param.
10529 (aarch64_gdbarch_init): Likewise.
10530 * aarch64-tdep.h (aarch64_read_description): Likewise.
10531 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10532 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10533 * features/Makefile: Add new files.
10534 * features/aarch64-pauth.c: New file.
10535 * features/aarch64-pauth.xml: New file.
10537 2019-03-20 Tom Tromey <tromey@adacore.com>
10539 * infrun.c (handle_inferior_event): Rename from
10540 handle_inferior_event_1. Create a scoped_value_mark.
10541 (handle_inferior_event): Remove.
10543 2019-03-19 Tom Tromey <tromey@adacore.com>
10545 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10546 * infrun.h (print_stop_event): Add "displays" parameter.
10547 * infrun.c (print_stop_event): Add "displays" parameter.
10549 2019-03-19 Pedro Alves <palves@redhat.com>
10551 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10552 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10553 to -1. Fix TABs vs spaces.
10554 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10555 * tui/tui-out.h (tui_ui_out) Add intro comments.
10556 <m_line, m_start_of_line>: In-class initialize, and add describing
10559 2019-03-18 Alan Hayward <alan.hayward@arm.com>
10561 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10563 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10565 2019-03-18 Pedro Alves <palves@redhat.com>
10566 Eli Zaretskii <eliz@gnu.org>
10568 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10569 m_line and m_start_of_line.
10571 2019-03-18 Eli Zaretskii <eliz@gnu.org>
10573 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10574 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10575 it returns a newline. This fixes a regression in TU mode, whereby
10576 the next line is output on the same screen line as the user input.
10578 2019-03-18 Tom Tromey <tromey@adacore.com>
10580 * minsyms.c (minimal_symbol_reader::install): Remove call to
10583 2019-03-18 Pedro Alves <palves@redhat.com>
10585 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10587 (apply_style): New, factored out from ...
10588 (apply_ansi_escape): ... this. Handle reverse video mode.
10589 (tui_set_reverse_mode): New function.
10590 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10591 * tui/tui-winsource.c (tui_show_source_line): Use
10592 tui_set_reverse_mode instead of setting A_STANDOUT.
10593 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10594 New setter methods.
10596 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
10598 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10601 2019-03-18 Tom Tromey <tromey@adacore.com>
10603 * ada-lang.c (empty_array): Add "high" parameter.
10604 (ada_evaluate_subexp): Update.
10606 2019-03-17 Sergei Trofimovich <siarheit@google.com>
10608 * unittests/string_view-selftests.c: Define
10609 _initialize_string_view_selftests unconditionally.
10611 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10614 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10616 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10619 * windows-nat.c (display_selector): Fix format specifiers.
10621 2019-03-17 Eli Zaretskii <eliz@gnu.org>
10623 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10624 tui_refill_source_window instead of tui_refresh_win, to update the
10625 current execution line. This fixes redisplay of the current line
10626 when stepping through the code with "next" or "step".
10628 2019-03-16 Eli Zaretskii <eliz@gnu.org>
10630 * source-cache.c (source_cache::get_source_lines): Call
10631 find_source_lines to initialize s->nlines. This fixes vertical
10632 scrolling of TUI source window when the DOWN arrow is pressed.
10634 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10636 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10637 linux-thread-db.c (_initialize_thread_db): Likewise.
10639 2019-03-16 Eli Zaretskii <eliz@gnu.org>
10641 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10642 wclrtoeol in tui_show_source_line". This reverts changes made in
10643 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10645 2019-03-15 Tom Tromey <tom@tromey.com>
10647 * symtab.h (struct minimal_symbol): Derive from
10648 general_symbol_info.
10649 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10650 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10651 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10652 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10653 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10654 (MSYMBOL_SEARCH_NAME): Update.
10655 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10656 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10657 * minsyms.c (minimal_symbol_reader::record_full): Update.
10659 2019-03-15 Tom Tromey <tom@tromey.com>
10661 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10663 2019-03-15 Tom Tromey <tom@tromey.com>
10665 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10666 unique_xmalloc_ptr.
10667 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10669 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10670 (build_minimal_symbol_hash_tables)
10671 (minimal_symbol_reader::install): Update.
10673 2019-03-15 Tom Tromey <tom@tromey.com>
10675 * symtab.c (create_demangled_names_hash): Update.
10676 (symbol_set_names): Update.
10677 * objfiles.h (struct objfile_per_bfd_storage)
10678 <demangled_names_hash>: Now an htab_up.
10679 * objfiles.c (objfile_per_bfd_storage): Simplify.
10681 2019-03-15 Tom Tromey <tom@tromey.com>
10683 * objfiles.h (struct objfile_per_bfd_storage): Declare
10685 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10687 (get_objfile_bfd_data): Use new. Don't initialize
10689 (free_objfile_per_bfd_storage): Remove.
10690 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10692 2019-03-15 Tom Tromey <tom@tromey.com>
10694 * symfile.c (reread_symbols): Update.
10695 * objfiles.c (objfile::objfile): Update.
10696 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10697 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10699 (minimal_symbol_reader::install): Update.
10700 (terminate_minimal_symbol_table): Remove.
10701 * jit.c (jit_object_close_impl): Update.
10703 2019-03-15 Tom Tromey <tom@tromey.com>
10705 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10708 2019-03-15 Tom Tromey <tom@tromey.com>
10710 * objfiles.h (struct objfile_per_bfd_storage)
10711 <demangled_hash_languages>: Now a bitset.
10712 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10713 (lookup_minimal_symbol): Update.
10715 2019-03-15 Tom Tromey <tom@tromey.com>
10717 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10718 Don't return the symbol.
10719 * coffread.c (record_minimal_symbol): Use record_full.
10721 2019-03-14 Eli Zaretskii <eliz@gnu.org>
10723 The MS-Windows port of ncurses fails to switch to a color pair if
10724 one or both of the colors are the implicit default colors. This
10725 change records the default colors when TUI is initialized, and
10726 then specifies them explicitly when a color pair uses the default
10727 colors. This allows color styling in TUI mode on MS-Windows.
10729 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10731 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10732 colors in ncurses_norm_attr.
10733 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10734 "none", replace it with the default color recorded in
10737 2019-03-14 Tom Tromey <tromey@adacore.com>
10739 * source-cache.h (class source_cache) <get_source_lines>: Return
10741 * source-cache.c (source_cache::extract_lines): Handle case where
10742 first_pos==npos. Return std::string.
10743 (source_cache::get_source_lines): Update.
10745 2019-03-14 Tom Tromey <tromey@adacore.com>
10747 * NEWS: Add item for "style sources" commands.
10748 * source-cache.c (source_cache::get_source_lines): Check
10750 * cli/cli-style.c (source_styling): New global.
10751 (_initialize_cli_style): Add "style sources" commands.
10752 (show_style_sources): New function.
10753 * cli/cli-style.h (source_styling): Declare.
10755 2019-03-14 Pedro Alves <palves@redhat.com>
10756 Tom Tromey <tromey@adacore.com>
10758 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10759 * tui/tui-winsource.c (tui_refill_source_window): New function,
10761 (tui_horizontal_source_scroll): ... here. Move some logic.
10762 * cli/cli-style.c (set_style_enabled): Notify new observable.
10763 * tui/tui-hooks.c (tui_redisplay_source): New function.
10764 (tui_attach_detach_observers): Attach or detach
10765 tui_redisplay_source.
10766 * observable.h (source_styling_changed): New observable.
10767 * observable.c: Define source_styling_changed observable.
10769 2019-03-13 Tom Tromey <tromey@adacore.com>
10771 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10772 (i386_gnu_nat_target::store_registers): Update.
10773 * target-debug.h (target_debug_print_std_string): New macro.
10774 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10775 * windows-tdep.c (display_one_tib): Update.
10776 * tui/tui-stack.c (tui_make_status_line): Update.
10777 * top.c (print_inferior_quit_action): Update.
10778 * thread.c (thr_try_catch_cmd): Update.
10779 (add_thread_with_info): Update.
10780 (thread_target_id_str): Update.
10781 (thr_try_catch_cmd): Update.
10782 (thread_command): Update.
10783 (thread_find_command): Update.
10784 * record-btrace.c (record_btrace_target::info_record)
10785 (record_btrace_resume_thread, record_btrace_target::resume)
10786 (record_btrace_cancel_resume, record_btrace_step_thread)
10787 (record_btrace_target::wait, record_btrace_target::wait)
10788 (record_btrace_target::wait, record_btrace_target::stop): Update.
10789 * progspace.c (print_program_space): Update.
10790 * process-stratum-target.c
10791 (process_stratum_target::thread_address_space): Update.
10792 * linux-fork.c (linux_fork_mourn_inferior)
10793 (detach_checkpoint_command, info_checkpoints_command)
10794 (linux_fork_context): Update.
10795 (linux_fork_detach): Update.
10796 (class scoped_switch_fork_info): Update.
10797 (delete_checkpoint_command): Update.
10798 * infrun.c (follow_fork_inferior): Update.
10799 (follow_fork_inferior): Update.
10800 (proceed_after_vfork_done): Update.
10801 (handle_vfork_child_exec_or_exit): Update.
10802 (follow_exec): Update.
10803 (displaced_step_prepare_throw): Update.
10804 (displaced_step_restore): Update.
10805 (start_step_over): Update.
10806 (resume_1): Update.
10807 (clear_proceed_status_thread): Update.
10809 (print_target_wait_results): Update.
10810 (do_target_wait): Update.
10811 (context_switch): Update.
10812 (stop_all_threads): Update.
10813 (restart_threads): Update.
10814 (finish_step_over): Update.
10815 (handle_signal_stop): Update.
10816 (switch_back_to_stepped_thread): Update.
10817 (keep_going_pass_signal): Update.
10818 (print_exited_reason): Update.
10819 (normal_stop): Update.
10820 * inferior.c (inferior_pid_to_str): Change return type.
10821 (print_selected_inferior): Update.
10822 (add_inferior): Update.
10823 (detach_inferior): Update.
10824 * dummy-frame.c (fprint_dummy_frames): Update.
10825 * dcache.c (dcache_info_1): Update.
10826 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10827 (btrace_fetch, btrace_clear): Update.
10828 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10829 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10831 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10832 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10833 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10834 * gdbarch.c, gdbarch.h: Rebuild.
10835 * gdbarch.sh (core_pid_to_str): Change return type.
10836 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10838 (windows_nat_target::pid_to_str): Change return type.
10839 (windows_delete_thread): Update.
10840 (windows_nat_target::attach): Update.
10841 (windows_nat_target::files_info): Update.
10842 * target-delegates.c: Rebuild.
10843 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10845 (sol_thread_target::pid_to_str): Change return type.
10846 * remote.c (class remote_target) <pid_to_str>: Change return
10848 (remote_target::pid_to_str): Change return type.
10849 (extended_remote_target::attach, remote_target::remote_stop_ns)
10850 (remote_target::remote_notif_remove_queued_reply)
10851 (remote_target::push_stop_reply, remote_target::disable_btrace):
10853 (extended_remote_target::attach): Update.
10854 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10856 (gdbsim_target::pid_to_str): Change return type.
10857 * ravenscar-thread.c (struct ravenscar_thread_target)
10858 <pid_to_str>: Change return type.
10859 (ravenscar_thread_target::pid_to_str): Change return type.
10860 * procfs.c (class procfs_target) <pid_to_str>: Change return
10862 (procfs_target::pid_to_str): Change return type.
10863 (procfs_target::attach): Update.
10864 (procfs_target::detach): Update.
10865 (procfs_target::fetch_registers): Update.
10866 (procfs_target::store_registers): Update.
10867 (procfs_target::wait): Update.
10868 (procfs_target::files_info): Update.
10869 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10870 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10872 (nto_procfs_target::pid_to_str): Change return type.
10873 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10874 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10876 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10877 (exit_lwp): Update.
10878 (attach_proc_task_lwp_callback, get_detach_signal)
10879 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10880 (linux_nat_target::resume, wait_lwp, stop_callback)
10881 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10882 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10883 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10884 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10885 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10887 (inf_ptrace_target::attach): Update.
10888 (inf_ptrace_target::files_info): Update.
10889 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10891 (go32_nat_target::pid_to_str): Change return type.
10892 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10893 (gnu_nat_target::wait): Update.
10894 (gnu_nat_target::wait): Update.
10895 (gnu_nat_target::resume): Update.
10896 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10897 (fbsd_nat_target::wait): Update.
10898 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10900 (darwin_nat_target::attach): Update.
10901 * corelow.c (class core_target) <pid_to_str>: Change return type.
10902 (core_target::pid_to_str): Change return type.
10903 * target.c (normal_pid_to_str): Change return type.
10904 (default_pid_to_str): Likewise.
10905 (target_pid_to_str): Change return type.
10906 (target_translate_tls_address): Update.
10907 (target_announce_detach): Update.
10908 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10910 (bsd_uthread_target::pid_to_str): Change return type.
10911 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10913 (bsd_kvm_target::pid_to_str): Change return type.
10914 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10916 (aix_thread_target::pid_to_str): Change return type.
10917 * target.h (struct target_ops) <pid_to_str>: Change return type.
10918 (target_pid_to_str, normal_pid_to_str): Likewise.
10919 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10921 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10923 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10925 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10927 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10929 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10932 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10934 * NEWS: Mention that the new default MI version is 3. Mention
10935 changes to the output of commands and events that deal with
10936 multi-location breakpoints.
10937 * breakpoint.c: Include "mi/mi-out.h".
10938 (print_one_breakpoint): Change output syntax if using MI version
10940 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10942 (mi_multi_location_breakpoint_output_fixed): New.
10943 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10944 (mi_cmd_fix_multi_location_breakpoint_output): New.
10945 (mi_multi_location_breakpoint_output_fixed): New.
10946 * mi/mi-cmds.c (mi_cmds): Register command
10947 -fix-multi-location-breakpoint-output.
10948 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10951 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10953 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10954 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10955 instantiate mi_ui_out based on interpreter name.
10956 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10957 * mi/mi-main.c (mi_load_progress): Likewise.
10959 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10961 * NEWS: Combine separate "New targets" sections for 8.3.
10963 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10965 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10966 (ppcfbsd_init_abi): Install gdbarch
10967 "fetch_tls_load_module_address" and "get_thread_local_address"
10970 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10972 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10973 (riscv_fbsd_init_abi): Install gdbarch
10974 "fetch_tls_load_module_address" and "get_thread_local_address"
10977 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10979 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10980 (i386fbsd_init_abi): Install gdbarch
10981 "fetch_tls_load_module_address" and "get_thread_local_address"
10984 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10986 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10987 (amd64fbsd_init_abi): Install gdbarch
10988 "fetch_tls_load_module_address" and "get_thread_local_address"
10991 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10993 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10994 (struct fbsd_pspace_data): New type.
10995 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10996 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10997 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10998 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10999 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11001 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11003 * gdbtypes.c (lookup_struct_elt): New function.
11004 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11005 * gdbtypes.h (struct struct_elt): New type.
11006 (lookup_struct_elt): New prototype.
11008 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11010 * gdbtypes.c (lookup_struct_elt_type): Update comment and
11011 remove disabled code block.
11013 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11015 * gdbarch.sh (get_thread_local_address): New method.
11016 * gdbarch.h, gdbarch.c: Regenerate.
11017 * target.c (target_translate_tls_address): Use
11018 gdbarch_get_thread_local_address if present instead of
11019 target::get_thread_local_address.
11021 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11023 * target.h (target::get_thread_local_address): Update comment.
11025 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11027 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11028 objfile->separate_debug_objfile_backlink if not NULL.
11030 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11032 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11033 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11034 (amd64bsd_store_inferior_registers): Likewise.
11035 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11036 Enable segment base registers.
11037 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11038 PT_GETFSBASE and PT_GETGSBASE.
11039 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11041 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11042 segment base registers.
11043 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11045 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11047 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11048 Update calls to i386_target_description to add 'segments'
11050 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
11051 add segment base registers.
11052 * arch/i386.c (i386_create_target_description): Add 'segments'
11053 parameter to enable segment base registers.
11054 * arch/i386.h (i386_create_target_description): Likewise.
11055 * features/i386/32bit-segments.xml: New file.
11056 * features/i386/32bit-segments.c: Generate.
11057 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11058 call to i386_target_description to add 'segments' parameter.
11059 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11060 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11061 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11062 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11063 if feature is present.
11064 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11065 Add 'segments' parameter to call to i386_target_description.
11066 (i386_target_description): Add 'segments' parameter to enable
11067 segment base registers.
11068 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11069 to call to i386_target_description.
11070 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11071 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11072 Define I386_NUM_REGS.
11073 (i386_target_description): Add 'segments' parameter to enable
11074 segment base registers.
11076 2019-03-12 Eli Zaretskii <eliz@gnu.org>
11079 * source-cache.c: #undef open and close, to avoid unresolved
11080 externals during linking.
11082 2019-03-12 Tom Tromey <tromey@adacore.com>
11084 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11085 const. Add initializers.
11086 (_initialize_remote): Don't initialize ptid globals.
11088 2019-03-12 Pedro Alves <palves@redhat.com>
11090 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11092 2019-03-12 Pedro Alves <palves@redhat.com>
11094 * cp-name-parser.y (main): Remove unused 'len' variable.
11096 2019-03-12 Tom Tromey <tromey@adacore.com>
11098 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11099 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11101 2019-03-12 Tom Tromey <tromey@adacore.com>
11103 * linux-nat.c (iterate_over_lwps): Update.
11104 (stop_callback): Remove parameter.
11105 (stop_wait_callback, detach_callback, resume_set_callback)
11106 (select_singlestep_lwp_callback, set_ignore_sigint)
11107 (status_callback, resumed_callback, resume_clear_callback)
11108 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11110 (linux_nat_target::detach, linux_nat_target::resume)
11111 (linux_stop_and_wait_all_lwps, select_event_lwp)
11112 (linux_nat_filter_event, linux_nat_wait_1)
11113 (linux_nat_target::kill, linux_nat_target::stop)
11114 (linux_nat_target::stop): Update.
11115 (linux_nat_resume_callback): Change type.
11116 (resume_stopped_resumed_lwps, count_events_callback)
11117 (select_event_lwp_callback): Likewise.
11118 (linux_stop_lwp, linux_nat_stop_lwp): Update.
11119 * arm-linux-nat.c (struct update_registers_data): Remove.
11120 (update_registers_callback): Change type.
11121 (arm_linux_insert_hw_breakpoint1): Update.
11122 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11124 (x86_linux_dr_set_addr): Update.
11125 (x86_linux_dr_set_control): Update.
11126 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11127 (iterate_over_lwps): Use gdb::function_view.
11128 * nat/aarch64-linux-hw-point.c (struct
11129 aarch64_dr_update_callback_param): Remove.
11130 (debug_reg_change_callback): Change type.
11131 (aarch64_notify_debug_reg_change): Update.
11132 * s390-linux-nat.c (s390_refresh_per_info): Update.
11134 2019-03-11 Tom Tromey <tromey@adacore.com>
11136 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11137 redundant assignment to "this_cu".
11139 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11141 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11143 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11145 * gdbtypes.c (rank_one_type_parm_set): New function extracted
11147 (rank_one_type): ... this.
11149 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11151 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11153 (rank_one_type): ... this.
11155 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11157 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11159 (rank_one_type): ... this.
11161 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11163 * gdbtypes.c (rank_one_type_parm_float): New function extracted
11165 (rank_one_type): ... this.
11167 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11169 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11171 (rank_one_type): ... this.
11173 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11175 * gdbtypes.c (rank_one_type_parm_range): New function extracted
11177 (rank_one_type): ... this.
11179 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11181 * gdbtypes.c (rank_one_type_parm_char): New function extracted
11183 (rank_one_type): ... this.
11185 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11187 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11189 (rank_one_type): ... this.
11191 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11193 * gdbtypes.c (rank_one_type_parm_int): New function extracted
11195 (rank_one_type): ... this.
11197 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11199 * gdbtypes.c (rank_one_type_parm_func): New function extracted
11201 (rank_one_type): ... this.
11203 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11205 * gdbtypes.c (rank_one_type_parm_array): New function extracted
11207 (rank_one_type): ... this.
11209 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11211 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11213 (rank_one_type): ... this.
11215 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11217 * inferior.c (initialize_inferiors): Ensure 'help set/show print
11218 inferior-events' shows the example events.
11220 2019-03-08 Eli Zaretskii <eliz@gnu.org>
11222 Support styling on native MS-Windows console
11225 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11226 on MS-Windows if $TERM is not defined.
11228 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11230 * posix-hdep.c (gdb_console_fputs):
11231 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11233 * ui-file.h (gdb_console_fputs): Add prototype.
11235 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11236 back to fputs only if the former returns zero.
11238 2019-03-07 Tom Tromey <tom@tromey.com>
11240 * symmisc.c (print_symbol_bcache_statistics): Update.
11241 (print_objfile_statistics): Update.
11242 * symfile.c (allocate_symtab): Update.
11243 * stabsread.c: Don't include bcache.h.
11244 * psymtab.h (struct psymbol_bcache): Don't declare.
11245 (class psymtab_storage) <psymbol_cache>: Now a bcache.
11246 (psymbol_bcache_init, psymbol_bcache_free)
11247 (psymbol_bcache_get_bcache): Don't declare.
11248 * psymtab.c (struct psymbol_bcache): Remove.
11249 (psymtab_storage::psymtab_storage): Update.
11250 (psymtab_storage::~psymtab_storage): Update.
11251 (psymbol_bcache_init, psymbol_bcache_free)
11252 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11253 (add_psymbol_to_bcache): Update.
11254 (allocate_psymtab): Update.
11255 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11256 macro_cache>: No longer pointers.
11257 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11258 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11259 * macrotab.c (macro_bcache): Update.
11260 * macroexp.c: Don't include bcache.h.
11261 * gdbtypes.c (check_types_worklist): Update.
11262 (types_deeply_equal): Remove TRY/CATCH. Update.
11263 * elfread.c (elf_symtab_read): Update.
11264 * dwarf2read.c: Don't include bcache.h.
11265 * buildsym.c (buildsym_compunit::get_macro_table): Update.
11266 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11267 (print_bcache_statistics, bcache_memory_used): Don't declare.
11268 (struct bcache): Move from bcache.c. Add constructor, destructor,
11269 methods. Rename all data members.
11270 * bcache.c (struct bcache): Move to bcache.h.
11271 (bcache::expand_hash_table): Rename from expand_hash_table.
11273 (bcache::insert): Rename from bcache_full.
11274 (bcache::compare): Rename from bcache_compare.
11275 (bcache_xmalloc): Remove.
11276 (bcache::~bcache): Rename from bcache_xfree.
11277 (bcache::print_statistics): Rename from print_bcache_statistics.
11278 (bcache::memory_used): Rename from bcache_memory_used.
11280 2019-03-07 Pedro Alves <palves@redhat.com>
11282 * infrun.c (normal_stop): Also check for
11283 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11285 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
11287 * f-lang.c (value_from_host_double): Moved to...
11288 * value.c (value_from_host_double): ...here.
11289 * value.h (value_from_host_double): Declare.
11290 * guile/scm-math.c (vlscm_convert_typed_number): Use
11291 value_from_host_double.
11292 (vlscm_convert_number): Likewise.
11293 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11294 * python/py-value.c (convert_value_from_python): Likewise.
11296 2019-03-06 Tom Tromey <tom@tromey.com>
11298 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11300 2019-03-06 Tom Tromey <tom@tromey.com>
11302 * utils.h (free_current_contents): Don't declare.
11303 * utils.c (free_current_contents): Remove.
11305 2019-03-06 Tom Tromey <tom@tromey.com>
11307 * top.c (quit_force): Update.
11308 * main.c (captured_command_loop): Update.
11309 * common/new-op.c (operator new): Update.
11310 * common/common-exceptions.c (struct catcher)
11311 <save_cleanup_chain>: Remove member.
11312 (exceptions_state_mc_init): Update.
11313 (exception_try_scope_entry): Return nullptr.
11314 (exception_try_scope_exit, exception_rethrow)
11315 (throw_exception_sjlj, throw_exception_cxx): Update.
11316 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11317 (all_cleanups, do_cleanups, discard_cleanups)
11318 (discard_final_cleanups, save_cleanups, save_final_cleanups)
11319 (restore_cleanups, restore_final_cleanups): Don't declare.
11320 (do_final_cleanups): Remove parameter.
11321 * common/cleanups.c (cleanup_chain, make_cleanup)
11322 (make_cleanup_dtor, all_cleanups, do_cleanups)
11323 (discard_my_cleanups, discard_cleanups)
11324 (discard_final_cleanups, save_my_cleanups, save_cleanups)
11325 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11326 (null_cleanup): Remove.
11327 (do_final_cleanups): Remove parameter.
11329 2019-03-06 Tom Tromey <tom@tromey.com>
11331 * remote.c (remote_target::remote_parse_stop_reply): Use
11332 unique_xmalloc_ptr.
11334 2019-03-06 Tom Tromey <tom@tromey.com>
11336 * stabsread.c (struct stabs_field_info): Rename from field_info.
11337 <list, fnlist>: Add initializers.
11338 <obstack>: New member.
11339 (read_member_functions, read_struct_fields, read_baseclasses):
11340 Allocate on obstack. Don't use cleanups.
11341 (read_one_struct_field, read_member_functions, read_struct_fields)
11342 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11343 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11344 (read_struct_type): Update.
11346 2019-03-06 Tom Tromey <tom@tromey.com>
11348 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11349 * common/filestuff.h (make_cleanup_close): Don't declare.
11350 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11353 2019-03-06 Tom Tromey <tom@tromey.com>
11355 * solib-aix.c: Use make_scope_exit.
11357 2019-03-06 Tom Tromey <tom@tromey.com>
11359 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11360 Use make_scope_exit.
11362 2019-03-06 Tom Tromey <tom@tromey.com>
11364 * solib-svr4.c (disable_probes_interface): Remove parameter.
11365 (svr4_handle_solib_event): Use make_scope_exit.
11367 2019-03-06 Tom Tromey <tom@tromey.com>
11369 * remote.c (struct stop_reply_deleter): Remove.
11370 (stop_reply_up): Update.
11371 (struct stop_reply): Derive from notif_event. Don't typedef.
11372 <regcache>: Now a std::vector.
11373 (stop_reply_xfree): Remove.
11374 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11375 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
11376 (remote_target::discard_pending_stop_replies): Use delete.
11377 (remote_target::remote_parse_stop_reply): Update.
11378 (remote_target::process_stop_reply): Update.
11379 * remote-notif.h (struct notif_event): Add virtual destructor.
11380 Remove "dtr" member.
11381 (struct notif_client) <alloc_event>: Return a unique_ptr.
11382 (notif_event_xfree): Don't declare.
11383 (notif_event_up): New typedef.
11384 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11385 (notif_event_xfree, do_notif_event_xfree): Remove.
11386 (remote_notif_state_xfree): Update.
11388 2019-03-06 Tom Tromey <tom@tromey.com>
11390 * infrun.c (displaced_step_clear_cleanup): Now a
11391 forward_scope_exit type.
11392 (displaced_step_prepare_throw): Update.
11393 (displaced_step_fixup): Update.
11395 2019-03-06 Tom Tromey <tom@tromey.com>
11397 * inferior.h (class inferior): Update comment.
11398 * gdbthread.h (class thread_info): Update comment.
11400 2019-03-06 Joel Brobecker <brobecker@adacore.com>
11401 Tom Tromey <tom@tromey.com>
11403 * stabsread.h (struct stab_section_list): Remove.
11404 (coffstab_build_psymtabs): Update.
11405 * dbxread.c (symbuf_sections): Now a std::vector.
11406 (sect_idx): New global.
11407 (fill_symbuf): Update.
11408 (coffstab_build_psymtabs): Change type of stabsects parameter.
11410 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11412 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11413 (coff_locate_sections): Update.
11414 (coff_symfile_read): Remove cleanups. Update.
11415 (init_stringtab): Add storage parameter.
11416 (free_stringtab, free_stringtab_cleanup): Remove.
11417 (init_lineno): Add storage parameter.
11418 (free_linetab, free_linetab_cleanup): Remove.
11420 2019-03-06 Pedro Alves <palves@redhat.com>
11422 * linux-fork.c (fork_info::clobber_regs): Delete.
11423 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11424 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
11426 (scoped_switch_fork_info::scoped_switch_fork_info)
11427 (checkpoint_command, linux_fork_context): Adjust
11428 fork_save_infrun_state calls.
11430 2019-03-06 Pedro Alves <palves@redhat.com>
11432 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11433 (inf_has_multiple_threads): Return 'bool' and rewrite using
11434 inferior_info::threads().
11436 2019-03-06 Pedro Alves <palves@redhat.com>
11438 * linux-fork.c: Include <list>.
11439 (fork_list): Now a std::list instance.
11440 (fork_info): Add ctor, dtor, and in-class initialize all fields.
11441 (forks_exist_p, find_last_fork): Adjust.
11442 (new_fork): Delete.
11444 (add_fork): Adjust.
11445 (free_fork): Delete, folded into fork_info::~fork_info().
11446 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11448 (init_fork_list): Delete.
11449 (linux_fork_killall, linux_fork_mourn_inferior)
11450 (linux_fork_detach, info_checkpoints_command): Adjust.
11451 (_initialize_linux_fork): No longer call init_fork_list.
11453 2019-03-06 Pedro Alves <palves@redhat.com>
11455 * linux-fork.c (new_fork): New, split out of ...
11456 (add_fork): ... this. Return void. Move "first fork" special
11457 case from here, to ...
11458 (checkpoint_command): ... here.
11459 * linux-linux.h (add_fork): Return void.
11461 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11463 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11465 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11466 Chris January <chris.january@arm.com>
11467 David Lecomber <david.lecomber@arm.com>
11469 * f-exp.y: New token, UNOP_INTRINSIC.
11470 (exp): New pattern using UNOP_INTRINSIC token.
11471 (f77_keywords): Add 'abs' keyword.
11472 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11473 (value_from_host_double): New function.
11474 (evaluate_subexp_f): Support UNOP_ABS.
11476 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11478 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11481 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11483 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11484 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11485 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11487 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11489 * f-exp.y (convert_to_kind_type): Handle more type kinds.
11491 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11492 Chris January <chris.january@arm.com>
11494 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11495 * f-exp.y: Define 'KIND' token.
11496 (exp): New pattern for KIND expressions.
11497 (ptype): Handle types with a kind extension.
11498 (direct_abs_decl): Extend to spot kind extensions.
11499 (f77_keywords): Add 'kind' to the list.
11500 (push_kind_type): New function.
11501 (convert_to_kind_type): New function.
11502 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11503 * parse.c (operator_length_standard): Likewise.
11504 * parser-defs.h (enum type_pieces): Add tp_kind.
11505 * std-operator.def: Add UNOP_KIND.
11507 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11509 * f-exp.y (f_parse): Set yydebug.
11511 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11513 * f-lang.c (evaluate_subexp_f): New function.
11514 (exp_descriptor_f): New global.
11515 (f_language_defn): Use exp_descriptor_f instead of
11516 exp_descriptor_standard.
11518 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11520 * f-exp.y (struct token): Add comments.
11521 (dot_ops): Remove uppercase versions and the end marker.
11522 (f77_keywords): Likewise.
11523 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11524 entries in the dot_ops array are case insensitive, and use
11525 strncasecmp to compare strings. Also some whitespace cleanup in
11526 this area. Similar for the f77_keywords array, except entries in
11527 this list might be case sensitive.
11529 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11531 * f-exp.y (struct f77_boolean_val): Add comments.
11532 (boolean_values): Remove uppercase versions, and end marker.
11533 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11534 and use strncasecmp to achieve case insensitivity. Additionally,
11535 perform whitespace cleanup around this code.
11537 2019-03-06 Tom Tromey <tromey@adacore.com>
11539 * remote-sim.c (gdbsim_target_open): Use result of
11542 2019-03-06 Richard Bunt <richard.bunt@arm.com>
11543 Dirk Schubert <dirk.schubert@arm.com>
11544 Chris January <chris.january@arm.com>
11546 * eval.c (evaluate_subexp_standard): Call Fortran argument
11548 * f-lang.c (struct value): A value which can be passed into a
11549 Fortran function call.
11550 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11552 (struct type): Value ready for a Fortran function call.
11553 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11555 * f-lang.h (fortran_argument_convert): Declaration.
11556 (fortran_preserve_arg_pointer): Declaration.
11557 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11559 2019-03-05 Tom Tromey <tromey@adacore.com>
11561 * python/py-prettyprint.c (print_string_repr): Remove #if.
11562 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11564 2019-03-05 Tom Tromey <tromey@adacore.com>
11566 * target.c (the_dummy_target): Move later. Change type to
11568 (initialize_targets): Don't initialize the_dummy_target.
11570 2019-03-05 Tom Tromey <tromey@adacore.com>
11572 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11573 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11575 2019-03-05 Tom Tromey <tromey@adacore.com>
11577 * windows-nat.c (windows_nat_target::attach)
11578 (windows_nat_target::detach): Don't call gdb_flush.
11579 * valprint.c (generic_val_print, val_print, val_print_string):
11580 Don't call gdb_flush.
11581 * utils.c (defaulted_query): Don't call gdb_flush.
11582 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11583 * target.c (target_announce_detach): Don't call gdb_flush.
11584 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11585 * remote.c (extended_remote_target::attach): Don't call
11587 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11588 * printcmd.c (do_examine): Don't call gdb_flush.
11589 (info_display_command): Don't call gdb_flush.
11590 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11591 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11592 * memattr.c (info_mem_command): Don't call gdb_flush.
11593 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11594 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11595 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11596 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11597 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11598 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11599 (gnu_nat_target::detach): Don't call gdb_flush.
11600 * f-valprint.c (f_val_print): Don't call gdb_flush.
11601 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11602 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11603 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11605 * c-valprint.c (c_val_print): Don't call gdb_flush.
11606 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11608 2019-03-05 Tom Tromey <tromey@adacore.com>
11610 * varobj.c (update_dynamic_varobj_children): Update.
11611 (install_default_visualizer): Use reset, not release.
11612 * value.c (set_internalvar): Update.
11613 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11614 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11615 ATTRIBUTE_UNUSED_RESULT.
11617 2019-03-05 Tom Tromey <tromey@adacore.com>
11619 * remote.c (class scoped_remote_fd) <release>: Add
11620 ATTRIBUTE_UNUSED_RESULT.
11622 2019-03-05 Tom Tromey <tromey@adacore.com>
11624 * macroexp.c (struct macro_buffer) <release>: Add
11625 ATTRIBUTE_UNUSED_RESULT.
11627 2019-03-05 Tom Tromey <tromey@adacore.com>
11629 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11630 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11631 ATTRIBUTE_UNUSED_RESULT.
11633 2019-03-05 Tom Tromey <tromey@adacore.com>
11635 * common/scoped_fd.h (class scoped_fd) <release>: Add
11636 ATTRIBUTE_UNUSED_RESULT.
11638 2019-03-05 Tom Tromey <tromey@adacore.com>
11640 * parser-defs.h (struct parser_state) <release>: Add
11641 ATTRIBUTE_UNUSED_RESULT.
11643 2019-03-05 Tom Tromey <tromey@adacore.com>
11645 * utils.h (class gdb_argv) <release>: Add
11646 ATTRIBUTE_UNUSED_RESULT.
11647 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11649 2019-03-02 Eli Zaretskii <eliz@gnu.org>
11651 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11652 for-loop range, to avoid compiler warnings.
11654 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11655 avoid compiler warnings about unused variables.
11657 * NEWS: Mention end of support for native debugging on MS-Windows
11661 * common/netstuff.c:
11662 * gdbserver/gdbreplay.c
11663 * gdbserver/remote-utils.c:
11665 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11666 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11667 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11668 'getaddrinfo' and 'freeaddrinfo' were not available before
11669 Windows XP, and mingw.org's MinGW headers by default define
11670 _WIN32_WINNT to 0x500.
11672 2019-03-01 Gary Benson <gbenson@redhat.com>
11674 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11676 2019-02-28 Brian Vandenberg <phantall@gmail.com>
11677 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11680 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11681 set_sigint_trap, clear_sigint_trap.
11683 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11685 * target.c (target_detach): Clear the regcache and the
11688 2019-02-27 Pedro Alves <palves@redhat.com>
11690 * utils.c (set_screen_size): When we cap the height/width sizes,
11691 tweak the corresponding command variable to show "unlimited":
11693 2019-02-27 Saagar Jha <saagar@saagarjha.com>
11694 Pedro Alves <palves@redhat.com>
11696 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11697 before calling rl_set_screen_size.
11699 2019-02-27 Tom Tromey <tromey@adacore.com>
11701 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11703 * python/py-value.c: Remove Python 2.4 workaround.
11704 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11706 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11707 Python 2.4 workaround.
11708 * python/python-internal.h: Remove Python 2.4 comment.
11709 (Py_ssize_t): Don't define.
11710 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11711 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11712 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11713 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11714 * python/python.c (do_start_initialization): Remove Python 2.4
11716 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11717 (print_children): Remove Python 2.4 workaround.
11718 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11720 (CHARBUFFERPROC_NAME): Remove.
11721 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11722 Python 2.4 workaround.
11724 2019-02-27 Kevin Buettner <kevinb@redhat.com>
11726 * NEWS: Note minimum Python version.
11728 2019-02-27 Kevin Buettner <kevinb@redhat.com>
11730 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11731 code from these functions. Remove corresponding ifdefs. Use
11732 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11733 Remove gotos and target of gotos.
11734 (infpy_search_memory): Likewise.
11736 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11738 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11739 (hppa_gdbarch_init): Don't register deleted functions with
11742 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11744 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11745 (h8300_unwind_sp): Delete.
11746 (h8300_dummy_id): Delete.
11747 (h8300_gdbarch_init): Don't register deleted functions with
11750 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11752 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11753 (ft32_unwind_pc): Delete.
11754 (ft32_unwind_sp): Delete.
11755 (ft32_gdbarch_init): Don't register deleted functions with
11758 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11760 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11761 (frv_unwind_pc): Delete.
11762 (frv_unwind_sp): Delete.
11763 (frv_gdbarch_init): Don't register deleted functions with
11766 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11768 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11769 (riscv_unwind_pc): Delete.
11770 (riscv_unwind_sp): Delete.
11771 (riscv_gdbarch_init): Don't register deleted functions with
11774 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11776 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11777 (csky_unwind_pc): Delete.
11778 (csky_unwind_sp): Delete.
11779 (csky_gdbarch_init): Don't register deleted functions with
11782 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11784 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11785 (cris_unwind_pc): Delete.
11786 (cris_unwind_sp): Delete.
11787 (cris_gdbarch_init): Don't register deleted functions with
11790 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11792 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11793 (bfin_unwind_pc): Delete.
11794 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11796 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11798 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11799 (arm_unwind_pc): Delete.
11800 (arm_unwind_sp): Delete.
11801 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11803 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11805 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11806 (arc_unwind_pc): Delete.
11807 (arc_unwind_sp): Delete.
11808 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11810 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11812 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11813 (alpha_unwind_pc): Delete.
11814 (alpha_gdbarch_init): Don't register deleted functions with
11817 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11819 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11820 (aarch64_unwind_pc): Delete.
11821 (aarch64_unwind_sp): Delete.
11822 (aarch64_gdbarch_init): Don't register deleted functions with
11825 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11827 * gdbtypes.c (type_align): Don't consider static members when
11828 computing structure alignment.
11830 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11832 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11833 return 0 for other types.
11834 * arch-utils.c (default_type_align): Always return 0.
11835 * gdbarch.h: Regenerate.
11836 * gdbarch.sh (type_align): Extend comment.
11837 * gdbtypes.c (type_align): Add additional comments, always call
11838 gdbarch_type_align before applying the default rules.
11839 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11840 generic code will then apply a suitable default.
11841 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11842 types, return 0 for other types.
11844 2019-02-27 Joel Brobecker <brobecker@adacore.com>
11846 * NEWS: Create a new section for the next release branch.
11847 Rename the section of the current branch, now that it has
11850 2019-02-27 Joel Brobecker <brobecker@adacore.com>
11852 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11853 * version.in: Bump version to 8.3.50.DATE-git.
11855 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
11857 * aix-thread.c (ptid_cmp): Remove unused variable.
11858 (get_signaled_thread): Likewise.
11859 (store_regs_user_thread): Likewise.
11860 (store_regs_kernel_thread): Likewise.
11861 (fetch_regs_kernel_thread): Remove shadowed variable.
11863 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11865 * features/riscv/32bit-cpu.xml: Add register numbers.
11866 * features/riscv/32bit-fpu.c: Regenerate.
11867 * features/riscv/32bit-fpu.xml: Add register numbers.
11868 * features/riscv/64bit-cpu.xml: Add register numbers.
11869 * features/riscv/64bit-fpu.c: Regenerate.
11870 * features/riscv/64bit-fpu.xml: Add register numbers.
11872 2019-02-26 Kevin Buettner <kevinb@redhat.com>
11874 * NEWS: Mention two argument form of gdb.Value constructor.
11875 * python/py-value.c (convert_buffer_and_type_to_value): New
11877 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11878 Add support for handling an optional second argument. Call
11879 convert_buffer_and_type_to_value as appropriate.
11880 * python/python-internal.h (Py_buffer_deleter): New struct.
11881 (Py_buffer_up): New typedef.
11883 2019-02-25 John Baldwin <jhb@FreeBSD.org>
11885 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11886 instead of releasing ownership.
11888 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
11890 * dwarf2read.c (open_and_init_dwp_file): Call
11891 elf_numsections instead of bfd_count_sections to initialize
11892 dwp_file->num_sections.
11894 2019-02-25 Tom Tromey <tromey@adacore.com>
11896 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11898 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11900 * gcore.in: Add '--readnever' option when invoking GDB.
11902 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11904 * MAINTAINERS: Update my email address.
11906 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11908 * build-id.c (build_id_to_debug_bfd_1): New function.
11909 (build_id_to_debug_bfd): Look for separate debug file in
11912 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11914 * gdbarch.sh: Update the copyright year range that is placed into
11917 2019-02-22 Keith Seitz <keiths@redhat.com>
11920 * linespec.c (create_sals_line_offset): Search for the default
11921 symtab's filename instead of its fullname.
11923 2019-02-21 Alan Hayward <alan.hayward@arm.com>
11925 * NEWS: Update style defaults.
11927 2019-02-21 Alan Hayward <alan.hayward@arm.com>
11929 * main.c (captured_main_1): Disable styling in batch mode.
11931 2019-02-20 Tom Tromey <tom@tromey.com>
11933 * symtab.c (symtab_symbol_info): Fix typos.
11935 2019-02-20 Tom Tromey <tromey@adacore.com>
11937 * findcmd.c (_initialize_mem_search): Use upper case for
11938 metasyntactic variables.
11940 2019-02-20 Alan Hayward <alan.hayward@arm.com>
11942 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11943 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11945 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11947 * top.h (source_file_name): Change to std::string.
11948 * top.c (source_file_name): Likewise.
11949 (command_line_input): Adjust.
11950 * cli/cli-script.c (script_from_file): Adjust.
11952 2019-02-19 Tom Tromey <tromey@adacore.com>
11954 * ravenscar-thread.c
11955 (ravenscar_thread_target::update_thread_list): Don't call
11956 ada_build_task_list.
11957 * ada-lang.h (ada_build_task_list): Don't declare.
11958 * ada-tasks.c (struct ada_tasks_inferior_data)
11959 <task_list_valid_p>: Now bool.
11960 (read_known_tasks, ada_task_list_changed)
11961 (ada_tasks_invalidate_inferior_data): Update.
11962 (read_known_tasks_array): Return bool.
11963 (read_known_tasks_list): Likewise.
11964 (read_known_tasks): Return void.
11965 (ada_build_task_list): Now static.
11967 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11969 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11970 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11972 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11974 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11975 variant for ada_tasks_pspace_data_handle and
11976 ada_tasks_inferior_data_handle.
11977 (ada_tasks_pspace_data_cleanup): New function.
11978 (ada_tasks_inferior_data_cleanup): New function.
11980 2019-02-17 Tom Tromey <tom@tromey.com>
11982 * macrotab.h (macro_source_fullname): Return a std::string.
11983 * macrotab.c (macro_include, check_for_redefinition)
11984 (macro_undef, macro_lookup_definition, foreach_macro)
11985 (foreach_macro_in_scope): Update.
11986 (macro_source_fullname): Return a std::string.
11987 * macrocmd.c (show_pp_source_pos): Update.
11989 2019-02-17 Tom Tromey <tom@tromey.com>
11991 * macrocmd.c (show_pp_source_pos): Style the file names.
11993 2019-02-17 Tom Tromey <tom@tromey.com>
11996 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11998 2019-02-17 Tom Tromey <tom@tromey.com>
12000 * ada-lang.c (user_select_syms): Use filtered printing.
12001 * utils.c (wrap_style): New global.
12002 (desired_style): Remove.
12003 (emit_style_escape): Add stream parameter.
12004 (set_output_style, reset_terminal_style, prompt_for_continue):
12006 (flush_wrap_buffer): Only flush gdb_stdout.
12007 (wrap_here): Set wrap_style.
12008 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
12009 treat escape sequences as a character. Change when wrap buffer is
12011 (fputs_styled): Do not set the output style when the default is
12013 * ui-style.h (struct ui_file_style) <is_default>: New method.
12014 * source.c (print_source_lines_base): Emit escape sequences in one
12017 2019-02-17 Joel Brobecker <brobecker@adacore.com>
12019 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12020 integers and enumeration types.
12022 2019-02-17 Joel Brobecker <brobecker@adacore.com>
12024 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12025 instead of lookup_symbol_in_language
12026 (do_exact_match): New function.
12027 (ada_get_symbol_name_matcher): Return do_exact_match when
12028 doing a verbatim match.
12030 2019-02-15 Tom Tromey <tromey@adacore.com>
12032 * ravenscar-thread.c (ravenscar_thread_target::resume)
12033 (ravenscar_thread_target::wait): Special case wildcard requests.
12035 2019-02-15 Tom Tromey <tromey@adacore.com>
12037 * ravenscar-thread.c (base_ptid): Remove.
12038 (struct ravenscar_thread_target) <close>: New method.
12039 <m_base_ptid>: New member.
12040 <update_inferior_ptid, active_task, task_is_currently_active,
12041 runtime_initialized>: Declare methods.
12042 <ravenscar_thread_target>: Add constructor.
12043 (ravenscar_thread_target::task_is_currently_active)
12044 (ravenscar_thread_target::update_inferior_ptid)
12045 (ravenscar_runtime_initialized): Rename. Now methods.
12046 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12047 (ravenscar_thread_target::update_thread_list): Update.
12048 (ravenscar_thread_target::active_task): Now method.
12049 (ravenscar_thread_target::store_registers)
12050 (ravenscar_thread_target::prepare_to_store)
12051 (ravenscar_thread_target::prepare_to_store)
12052 (ravenscar_thread_target::mourn_inferior): Update.
12053 (ravenscar_inferior_created): Use "new" to create target.
12054 (ravenscar_thread_target::get_ada_task_ptid): Update.
12055 (_initialize_ravenscar): Don't initialize base_ptid.
12056 (ravenscar_ops): Remove global.
12058 2019-02-15 Tom Tromey <tromey@adacore.com>
12060 * target.h (push_target): Declare new overload.
12061 * target.c (push_target): New overload, taking an rvalue reference.
12062 * remote.c (remote_target::open_1): Use push_target overload.
12063 * corelow.c (core_target_open): Use push_target overload.
12065 2019-02-15 Tom Tromey <tromey@adacore.com>
12067 * ravenscar-thread.c (is_ravenscar_task)
12068 (ravenscar_task_is_currently_active): Return bool.
12069 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12070 (_initialize_ravenscar): Remove "(void)".
12071 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12074 2019-02-15 Tom Tromey <tromey@adacore.com>
12076 * ravenscar-thread.c (ravenscar_runtime_initializer)
12077 (has_ravenscar_runtime, get_running_thread_id)
12078 (ravenscar_thread_target::resume): Fix indentation.
12080 2019-02-15 Tom Tromey <tromey@adacore.com>
12082 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12083 from ravenscar_arch_ops.
12084 (sparc_ravenscar_ops::fetch_registers)
12085 (sparc_ravenscar_ops::store_registers): Now methods.
12086 (sparc_ravenscar_prepare_to_store): Remove.
12087 (sparc_ravenscar_ops): Redefine.
12088 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12089 methods and destructor. Remove members.
12090 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12091 (ravenscar_thread_target::store_registers)
12092 (ravenscar_thread_target::prepare_to_store): Update.
12093 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12095 (struct ppc_ravenscar_powerpc_ops): Derive from
12096 ravenscar_arch_ops.
12097 (ppc_ravenscar_powerpc_ops::fetch_registers)
12098 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12099 (ppc_ravenscar_powerpc_ops): Redefine.
12100 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12101 (ppc_ravenscar_e500_ops::fetch_registers)
12102 (ppc_ravenscar_e500_ops::store_registers): Now methods.
12103 (ppc_ravenscar_e500_ops): Redefine.
12104 * aarch64-ravenscar-thread.c
12105 (aarch64_ravenscar_generic_prepare_to_store): Remove.
12106 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12107 (aarch64_ravenscar_fetch_registers)
12108 (aarch64_ravenscar_store_registers): Now methods.
12109 (aarch64_ravenscar_ops): Redefine.
12111 2019-02-15 Tom Tromey <tromey@adacore.com>
12113 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12114 (ravenscar_thread_target::stopped_by_hw_breakpoint)
12115 (ravenscar_thread_target::stopped_by_watchpoint)
12116 (ravenscar_thread_target::stopped_data_address)
12117 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12119 2019-02-15 Tom Tromey <tromey@adacore.com>
12121 * ravenscar-thread.c: Fix some typos.
12123 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12124 Tom Tromey <tromey@adacore.com>
12126 * ada-lang.c (ada_exception_sal): Change addr_string to a
12128 (create_ada_exception_catchpoint): Update.
12130 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12131 Tom Tromey <tromey@adacore.com>
12133 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12134 (bp_location_ops): Remove.
12135 (base_breakpoint_allocate_location): Update.
12136 (free_bp_location): Update.
12137 * ada-lang.c (class ada_catchpoint_location)
12138 <ada_catchpoint_location>: Remove ops parameter.
12139 (ada_catchpoint_location_dtor): Remove.
12140 (ada_catchpoint_location_ops): Remove.
12141 (allocate_location_exception): Update.
12142 * breakpoint.h (struct bp_location_ops): Remove.
12143 (class bp_location) <bp_location>: Remove bp_location_ops
12145 <~bp_location>: Add destructor.
12148 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
12149 Pedro Alves <palves@redhat.com>
12151 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12154 2019-02-14 David Michael <fedora.dm0@gmail.com>
12155 Samuel Thibault <samuel.thibault@gnu.org>
12156 Thomas Schwinge <thomas@codesourcery.com>
12158 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12159 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12161 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
12163 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12164 (check_empty): Use "const char *".
12166 * gnu-nat.c (gnu_nat_target::detach): Instead of
12167 'detach_inferior (pid)' call
12168 'detach_inferior (find_inferior_pid (pid))'.
12170 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12171 'nat/fork-inferior.o'.
12172 * gnu-nat.c: #include "nat/fork-inferior.h".
12174 * gnu-nat.c (gnu_nat_target::detach): Instead of
12175 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12176 * gnu-nat.h: #include "inf-child.h".
12177 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12178 'i386_gnu_nat_target::fetch_registers'.
12179 (gnu_store_registers): Rename/move to
12180 'i386_gnu_nat_target::store_registers'.
12182 * config/i386/nm-i386gnu.h: Don't "#include" any files.
12183 * gnu-nat.h (mach_thread_info): New function.
12184 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12186 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12188 2019-02-14 Frederic Konrad <konrad@adacore.com>
12190 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12192 2019-02-14 Joel Brobecker <brobecker@adacore.com>
12194 * windows-nat.c (windows_add_thread): Add new parameter
12195 "main_thread_p" with default value set to false. Update
12196 function documentation as well as all callers.
12197 (windows_delete_thread): Likewise.
12198 (fake_create_process): Update call to windows_add_thread.
12199 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12200 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12201 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12202 call to windows_delete_thread.
12204 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
12206 * MAINTAINERS: Add Andrew Burgess as global maintainer.
12208 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12210 * symfile.c (find_separate_debug_file): Use canonical path of
12211 sysroot with child_path instead of gdb_sysroot if it is valid.
12213 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12215 * symfile.c (find_separate_debug_file): Use child_path to
12216 determine if an object file is under a sysroot.
12218 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12220 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12221 unittests/child-path-selftests.c.
12222 * common/pathstuff.c (child_path): New function.
12223 * common/pathstuff.h (child_path): New prototype.
12224 * unittests/child-path-selftests.c: New file.
12226 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12228 * symfile.c (find_separate_debug_file): Look for separate debug
12229 files in debug directories under the sysroot.
12231 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12233 * symtab.h (struct minimal_symbol data_p): New const method.
12234 (struct minimal_symbol text_p): Likewise.
12235 * symtab.c (output_source_filename): Use file name style
12236 to print file name.
12237 (print_symbol_info): Likewise.
12238 (print_msymbol_info): Use address style to print addresses.
12239 Use function name style to print executable text symbols.
12240 (expand_symtab_containing_pc): Use data_p.
12241 (find_pc_sect_compunit_symtab): Likewise.
12243 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12245 * breakpoint.c (describe_other_breakpoints): Use address style
12246 to print addresses.
12247 (say_where): Likewise.
12249 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12251 * ada-typeprint.c (print_func_type): Print function name
12252 style to print function name.
12253 * c-typeprint.c (c_print_type_1): Likewise.
12255 2019-02-11 Alan Hayward <alan.hayward@arm.com>
12257 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12260 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12262 * c-exp.y (direct_abs_decl): Use emplace_back to record the
12265 2019-02-10 Joel Brobecker <brobecker@adacore.com>
12267 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12268 TYPE_CODE_REF types.
12270 2019-02-08 Jim Wilson <jimw@sifive.com>
12272 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12273 (riscv_linux_fregset): New.
12274 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12276 2019-02-07 Tom Tromey <tom@tromey.com>
12278 * thread.c (thread_cancel_execution_command): Update.
12279 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12281 (struct thread_fsm_ops): Remove.
12282 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12283 (thread_fsm_should_stop, thread_fsm_return_value)
12284 (thread_fsm_set_finished, thread_fsm_finished_p)
12285 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12287 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12288 * infrun.c (clear_proceed_status_thread)
12289 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12290 (print_stop_event): Update.
12291 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12293 (step_command_fsm_ops): Remove.
12294 (new_step_command_fsm): Remove.
12296 (step_command_fsm::should_stop): Rename from
12297 step_command_fsm_should_stop.
12298 (step_command_fsm::clean_up): Rename from
12299 step_command_fsm_clean_up.
12300 (step_command_fsm::do_async_reply_reason): Rename from
12301 step_command_fsm_async_reply_reason.
12302 (struct until_next_fsm): Inherit from thread_fsm. Add
12304 (until_next_fsm_ops): Remove.
12305 (new_until_next_fsm): Remove.
12306 (until_next_fsm::should_stop): Rename from
12307 until_next_fsm_should_stop.
12308 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12309 (until_next_fsm::do_async_reply_reason): Rename from
12310 until_next_fsm_async_reply_reason.
12311 (struct finish_command_fsm): Inherit from thread_fsm. Add
12312 constructor. Change type of breakpoint.
12313 (finish_command_fsm_ops): Remove.
12314 (new_finish_command_fsm): Remove.
12315 (finish_command_fsm::should_stop): Rename from
12316 finish_command_fsm_should_stop.
12317 (finish_command_fsm::clean_up): Rename from
12318 finish_command_fsm_clean_up.
12319 (finish_command_fsm::return_value): Rename from
12320 finish_command_fsm_return_value.
12321 (finish_command_fsm::do_async_reply_reason): Rename from
12322 finish_command_fsm_async_reply_reason.
12323 (finish_command): Update.
12324 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12326 (call_thread_fsm_ops): Remove.
12327 (call_thread_fsm::call_thread_fsm): Rename from
12328 new_call_thread_fsm.
12329 (call_thread_fsm::should_stop): Rename from
12330 call_thread_fsm_should_stop.
12331 (call_thread_fsm::should_notify_stop): Rename from
12332 call_thread_fsm_should_notify_stop.
12333 (run_inferior_call, call_function_by_hand_dummy): Update.
12334 * cli/cli-interp.c (should_print_stop_to_console): Update.
12335 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12336 Add constructor. Change type of location_breakpoint,
12338 (until_break_fsm_ops): Remove.
12339 (new_until_break_fsm): Remove.
12340 (until_break_fsm::should_stop): Rename from
12341 until_break_fsm_should_stop.
12342 (until_break_fsm::clean_up): Rename from
12343 until_break_fsm_clean_up.
12344 (until_break_fsm::do_async_reply_reason): Rename from
12345 until_break_fsm_async_reply_reason.
12346 (until_break_command): Update.
12347 * thread-fsm.c: Remove.
12348 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12350 2019-02-07 Tom Tromey <tom@tromey.com>
12352 * yy-remap.h: Add include guard.
12353 * xtensa-tdep.h: Add include guard.
12354 * xcoffread.h: Rename include guard.
12355 * varobj-iter.h: Add include guard.
12356 * tui/tui.h: Rename include guard.
12357 * tui/tui-winsource.h: Rename include guard.
12358 * tui/tui-wingeneral.h: Rename include guard.
12359 * tui/tui-windata.h: Rename include guard.
12360 * tui/tui-win.h: Rename include guard.
12361 * tui/tui-stack.h: Rename include guard.
12362 * tui/tui-source.h: Rename include guard.
12363 * tui/tui-regs.h: Rename include guard.
12364 * tui/tui-out.h: Rename include guard.
12365 * tui/tui-layout.h: Rename include guard.
12366 * tui/tui-io.h: Rename include guard.
12367 * tui/tui-hooks.h: Rename include guard.
12368 * tui/tui-file.h: Rename include guard.
12369 * tui/tui-disasm.h: Rename include guard.
12370 * tui/tui-data.h: Rename include guard.
12371 * tui/tui-command.h: Rename include guard.
12372 * tic6x-tdep.h: Add include guard.
12373 * target/waitstatus.h: Rename include guard.
12374 * target/wait.h: Rename include guard.
12375 * target/target.h: Rename include guard.
12376 * target/resume.h: Rename include guard.
12377 * target-float.h: Rename include guard.
12378 * stabsread.h: Add include guard.
12379 * rs6000-tdep.h: Add include guard.
12380 * riscv-fbsd-tdep.h: Add include guard.
12381 * regformats/regdef.h: Rename include guard.
12382 * record.h: Rename include guard.
12383 * python/python.h: Rename include guard.
12384 * python/python-internal.h: Rename include guard.
12385 * python/py-stopevent.h: Rename include guard.
12386 * python/py-ref.h: Rename include guard.
12387 * python/py-record.h: Rename include guard.
12388 * python/py-record-full.h: Rename include guard.
12389 * python/py-record-btrace.h: Rename include guard.
12390 * python/py-instruction.h: Rename include guard.
12391 * python/py-events.h: Rename include guard.
12392 * python/py-event.h: Rename include guard.
12393 * procfs.h: Add include guard.
12394 * proc-utils.h: Add include guard.
12395 * p-lang.h: Add include guard.
12396 * or1k-tdep.h: Rename include guard.
12397 * observable.h: Rename include guard.
12398 * nto-tdep.h: Rename include guard.
12399 * nat/x86-linux.h: Rename include guard.
12400 * nat/x86-linux-dregs.h: Rename include guard.
12401 * nat/x86-gcc-cpuid.h: Add include guard.
12402 * nat/x86-dregs.h: Rename include guard.
12403 * nat/x86-cpuid.h: Rename include guard.
12404 * nat/ppc-linux.h: Rename include guard.
12405 * nat/mips-linux-watch.h: Rename include guard.
12406 * nat/linux-waitpid.h: Rename include guard.
12407 * nat/linux-ptrace.h: Rename include guard.
12408 * nat/linux-procfs.h: Rename include guard.
12409 * nat/linux-osdata.h: Rename include guard.
12410 * nat/linux-nat.h: Rename include guard.
12411 * nat/linux-namespaces.h: Rename include guard.
12412 * nat/linux-btrace.h: Rename include guard.
12413 * nat/glibc_thread_db.h: Rename include guard.
12414 * nat/gdb_thread_db.h: Rename include guard.
12415 * nat/gdb_ptrace.h: Rename include guard.
12416 * nat/fork-inferior.h: Rename include guard.
12417 * nat/amd64-linux-siginfo.h: Rename include guard.
12418 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12419 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12420 * nat/aarch64-linux.h: Rename include guard.
12421 * nat/aarch64-linux-hw-point.h: Rename include guard.
12422 * mn10300-tdep.h: Add include guard.
12423 * mips-linux-tdep.h: Add include guard.
12424 * mi/mi-parse.h: Rename include guard.
12425 * mi/mi-out.h: Rename include guard.
12426 * mi/mi-main.h: Rename include guard.
12427 * mi/mi-interp.h: Rename include guard.
12428 * mi/mi-getopt.h: Rename include guard.
12429 * mi/mi-console.h: Rename include guard.
12430 * mi/mi-common.h: Rename include guard.
12431 * mi/mi-cmds.h: Rename include guard.
12432 * mi/mi-cmd-break.h: Rename include guard.
12433 * m2-lang.h: Add include guard.
12434 * location.h: Rename include guard.
12435 * linux-record.h: Rename include guard.
12436 * linux-nat.h: Add include guard.
12437 * linux-fork.h: Add include guard.
12438 * i386-darwin-tdep.h: Rename include guard.
12439 * hppa-linux-offsets.h: Add include guard.
12440 * guile/guile.h: Rename include guard.
12441 * guile/guile-internal.h: Rename include guard.
12442 * gnu-nat.h: Rename include guard.
12443 * gdb-stabs.h: Rename include guard.
12444 * frv-tdep.h: Add include guard.
12445 * f-lang.h: Add include guard.
12446 * event-loop.h: Add include guard.
12447 * darwin-nat.h: Rename include guard.
12448 * cp-abi.h: Rename include guard.
12449 * config/sparc/nm-sol2.h: Rename include guard.
12450 * config/nm-nto.h: Rename include guard.
12451 * config/nm-linux.h: Add include guard.
12452 * config/i386/nm-i386gnu.h: Rename include guard.
12453 * config/djgpp/nl_types.h: Rename include guard.
12454 * config/djgpp/langinfo.h: Rename include guard.
12455 * compile/gcc-cp-plugin.h: Add include guard.
12456 * compile/gcc-c-plugin.h: Add include guard.
12457 * compile/compile.h: Rename include guard.
12458 * compile/compile-object-run.h: Rename include guard.
12459 * compile/compile-object-load.h: Rename include guard.
12460 * compile/compile-internal.h: Rename include guard.
12461 * compile/compile-cplus.h: Rename include guard.
12462 * compile/compile-c.h: Rename include guard.
12463 * common/xml-utils.h: Rename include guard.
12464 * common/x86-xstate.h: Rename include guard.
12465 * common/version.h: Rename include guard.
12466 * common/vec.h: Rename include guard.
12467 * common/tdesc.h: Rename include guard.
12468 * common/selftest.h: Rename include guard.
12469 * common/scoped_restore.h: Rename include guard.
12470 * common/scoped_mmap.h: Rename include guard.
12471 * common/scoped_fd.h: Rename include guard.
12472 * common/safe-iterator.h: Rename include guard.
12473 * common/run-time-clock.h: Rename include guard.
12474 * common/refcounted-object.h: Rename include guard.
12475 * common/queue.h: Rename include guard.
12476 * common/ptid.h: Rename include guard.
12477 * common/print-utils.h: Rename include guard.
12478 * common/preprocessor.h: Rename include guard.
12479 * common/pathstuff.h: Rename include guard.
12480 * common/observable.h: Rename include guard.
12481 * common/netstuff.h: Rename include guard.
12482 * common/job-control.h: Rename include guard.
12483 * common/host-defs.h: Rename include guard.
12484 * common/gdb_wait.h: Rename include guard.
12485 * common/gdb_vecs.h: Rename include guard.
12486 * common/gdb_unlinker.h: Rename include guard.
12487 * common/gdb_unique_ptr.h: Rename include guard.
12488 * common/gdb_tilde_expand.h: Rename include guard.
12489 * common/gdb_sys_time.h: Rename include guard.
12490 * common/gdb_string_view.h: Rename include guard.
12491 * common/gdb_splay_tree.h: Rename include guard.
12492 * common/gdb_setjmp.h: Rename include guard.
12493 * common/gdb_ref_ptr.h: Rename include guard.
12494 * common/gdb_optional.h: Rename include guard.
12495 * common/gdb_locale.h: Rename include guard.
12496 * common/gdb_assert.h: Rename include guard.
12497 * common/filtered-iterator.h: Rename include guard.
12498 * common/filestuff.h: Rename include guard.
12499 * common/fileio.h: Rename include guard.
12500 * common/environ.h: Rename include guard.
12501 * common/common-utils.h: Rename include guard.
12502 * common/common-types.h: Rename include guard.
12503 * common/common-regcache.h: Rename include guard.
12504 * common/common-inferior.h: Rename include guard.
12505 * common/common-gdbthread.h: Rename include guard.
12506 * common/common-exceptions.h: Rename include guard.
12507 * common/common-defs.h: Rename include guard.
12508 * common/common-debug.h: Rename include guard.
12509 * common/cleanups.h: Rename include guard.
12510 * common/buffer.h: Rename include guard.
12511 * common/btrace-common.h: Rename include guard.
12512 * common/break-common.h: Rename include guard.
12513 * cli/cli-utils.h: Rename include guard.
12514 * cli/cli-style.h: Rename include guard.
12515 * cli/cli-setshow.h: Rename include guard.
12516 * cli/cli-script.h: Rename include guard.
12517 * cli/cli-interp.h: Rename include guard.
12518 * cli/cli-decode.h: Rename include guard.
12519 * cli/cli-cmds.h: Rename include guard.
12520 * charset-list.h: Add include guard.
12521 * buildsym-legacy.h: Rename include guard.
12522 * bfin-tdep.h: Add include guard.
12523 * ax.h: Rename include guard.
12524 * arm-linux-tdep.h: Add include guard.
12525 * arm-fbsd-tdep.h: Add include guard.
12526 * arch/xtensa.h: Rename include guard.
12527 * arch/tic6x.h: Add include guard.
12528 * arch/i386.h: Add include guard.
12529 * arch/arm.h: Rename include guard.
12530 * arch/arm-linux.h: Rename include guard.
12531 * arch/arm-get-next-pcs.h: Rename include guard.
12532 * arch/amd64.h: Add include guard.
12533 * arch/aarch64-insn.h: Rename include guard.
12534 * arch-utils.h: Rename include guard.
12535 * annotate.h: Add include guard.
12536 * amd64-darwin-tdep.h: Rename include guard.
12537 * aarch64-linux-tdep.h: Add include guard.
12538 * aarch64-fbsd-tdep.h: Add include guard.
12539 * aarch32-linux-nat.h: Add include guard.
12541 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12543 * macrotab.c (macro_define_internal): New function that
12544 factorizes macro_define_object_internal and macro_define_function
12546 (macro_define_object_internal): Use macro_define_internal.
12547 (macro_define_function): Likewise.
12549 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12551 * macrocmd.c (extract_identifier): Return
12552 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12555 2019-02-06 John Baldwin <jhb@FreeBSD.org>
12557 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12559 2019-02-05 Tom Tromey <tom@tromey.com>
12561 * target.c (target_stack::unpush): Move assertion earlier.
12563 2019-01-30 Tom Tromey <tom@tromey.com>
12566 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12567 (gdbpy_parse_and_eval): Likewise.
12568 * python/python-internal.h (gdbpy_allow_threads): New class.
12570 2019-01-28 John Baldwin <jhb@FreeBSD.org>
12572 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12573 (aarch64_fbsd_fpregmap): Move earlier.
12574 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12575 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12576 instead of individual calls to trad_frame_set_reg_addr.
12577 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12579 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12580 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12581 instead of individual calls to trad_frame_set_reg_addr.
12583 2019-01-28 Alan Hayward <alan.hayward@arm.com>
12585 * CONTRIBUTE: Replace contribution list with wiki link.
12587 2019-01-25 Tom Tromey <tom@tromey.com>
12589 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12591 2019-01-25 Tom Tromey <tom@tromey.com>
12593 * xtensa-linux-nat.c: Fix common/ includes.
12594 * xml-support.h: Fix common/ includes.
12595 * xml-support.c: Fix common/ includes.
12596 * x86-linux-nat.c: Fix common/ includes.
12597 * windows-nat.c: Fix common/ includes.
12598 * varobj.h: Fix common/ includes.
12599 * varobj.c: Fix common/ includes.
12600 * value.c: Fix common/ includes.
12601 * valops.c: Fix common/ includes.
12602 * utils.c: Fix common/ includes.
12603 * unittests/xml-utils-selftests.c: Fix common/ includes.
12604 * unittests/utils-selftests.c: Fix common/ includes.
12605 * unittests/unpack-selftests.c: Fix common/ includes.
12606 * unittests/tracepoint-selftests.c: Fix common/ includes.
12607 * unittests/style-selftests.c: Fix common/ includes.
12608 * unittests/string_view-selftests.c: Fix common/ includes.
12609 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12610 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12611 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12612 * unittests/rsp-low-selftests.c: Fix common/ includes.
12613 * unittests/parse-connection-spec-selftests.c: Fix common/
12615 * unittests/optional-selftests.c: Fix common/ includes.
12616 * unittests/offset-type-selftests.c: Fix common/ includes.
12617 * unittests/observable-selftests.c: Fix common/ includes.
12618 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12619 * unittests/memrange-selftests.c: Fix common/ includes.
12620 * unittests/memory-map-selftests.c: Fix common/ includes.
12621 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12622 * unittests/function-view-selftests.c: Fix common/ includes.
12623 * unittests/environ-selftests.c: Fix common/ includes.
12624 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12625 * unittests/common-utils-selftests.c: Fix common/ includes.
12626 * unittests/cli-utils-selftests.c: Fix common/ includes.
12627 * unittests/array-view-selftests.c: Fix common/ includes.
12628 * ui-file.c: Fix common/ includes.
12629 * tui/tui-io.c: Fix common/ includes.
12630 * tracepoint.h: Fix common/ includes.
12631 * tracepoint.c: Fix common/ includes.
12632 * tracefile-tfile.c: Fix common/ includes.
12633 * top.h: Fix common/ includes.
12634 * top.c: Fix common/ includes.
12635 * thread.c: Fix common/ includes.
12636 * target/waitstatus.h: Fix common/ includes.
12637 * target/waitstatus.c: Fix common/ includes.
12638 * target.h: Fix common/ includes.
12639 * target.c: Fix common/ includes.
12640 * target-memory.c: Fix common/ includes.
12641 * target-descriptions.c: Fix common/ includes.
12642 * symtab.h: Fix common/ includes.
12643 * symfile.c: Fix common/ includes.
12644 * stap-probe.c: Fix common/ includes.
12645 * spu-linux-nat.c: Fix common/ includes.
12646 * sparc-nat.c: Fix common/ includes.
12647 * source.c: Fix common/ includes.
12648 * solib.c: Fix common/ includes.
12649 * solib-target.c: Fix common/ includes.
12650 * ser-unix.c: Fix common/ includes.
12651 * ser-tcp.c: Fix common/ includes.
12652 * ser-pipe.c: Fix common/ includes.
12653 * ser-base.c: Fix common/ includes.
12654 * selftest-arch.c: Fix common/ includes.
12655 * s12z-tdep.c: Fix common/ includes.
12656 * rust-exp.y: Fix common/ includes.
12657 * rs6000-aix-tdep.c: Fix common/ includes.
12658 * riscv-tdep.c: Fix common/ includes.
12659 * remote.c: Fix common/ includes.
12660 * remote-notif.h: Fix common/ includes.
12661 * remote-fileio.h: Fix common/ includes.
12662 * remote-fileio.c: Fix common/ includes.
12663 * regcache.h: Fix common/ includes.
12664 * regcache.c: Fix common/ includes.
12665 * record-btrace.c: Fix common/ includes.
12666 * python/python.c: Fix common/ includes.
12667 * python/py-type.c: Fix common/ includes.
12668 * python/py-inferior.c: Fix common/ includes.
12669 * progspace.h: Fix common/ includes.
12670 * producer.c: Fix common/ includes.
12671 * procfs.c: Fix common/ includes.
12672 * proc-api.c: Fix common/ includes.
12673 * printcmd.c: Fix common/ includes.
12674 * ppc-linux-nat.c: Fix common/ includes.
12675 * parser-defs.h: Fix common/ includes.
12676 * osdata.c: Fix common/ includes.
12677 * obsd-nat.c: Fix common/ includes.
12678 * nat/x86-linux.c: Fix common/ includes.
12679 * nat/x86-linux-dregs.c: Fix common/ includes.
12680 * nat/x86-dregs.h: Fix common/ includes.
12681 * nat/x86-dregs.c: Fix common/ includes.
12682 * nat/ppc-linux.c: Fix common/ includes.
12683 * nat/mips-linux-watch.h: Fix common/ includes.
12684 * nat/mips-linux-watch.c: Fix common/ includes.
12685 * nat/linux-waitpid.c: Fix common/ includes.
12686 * nat/linux-ptrace.h: Fix common/ includes.
12687 * nat/linux-ptrace.c: Fix common/ includes.
12688 * nat/linux-procfs.c: Fix common/ includes.
12689 * nat/linux-personality.c: Fix common/ includes.
12690 * nat/linux-osdata.c: Fix common/ includes.
12691 * nat/linux-namespaces.c: Fix common/ includes.
12692 * nat/linux-btrace.h: Fix common/ includes.
12693 * nat/linux-btrace.c: Fix common/ includes.
12694 * nat/fork-inferior.c: Fix common/ includes.
12695 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12696 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12697 * nat/aarch64-linux.c: Fix common/ includes.
12698 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12699 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12700 * namespace.h: Fix common/ includes.
12701 * mips-linux-tdep.c: Fix common/ includes.
12702 * minsyms.c: Fix common/ includes.
12703 * mi/mi-parse.h: Fix common/ includes.
12704 * mi/mi-main.c: Fix common/ includes.
12705 * mi/mi-cmd-env.c: Fix common/ includes.
12706 * memrange.h: Fix common/ includes.
12707 * memattr.c: Fix common/ includes.
12708 * maint.h: Fix common/ includes.
12709 * maint.c: Fix common/ includes.
12710 * main.c: Fix common/ includes.
12711 * machoread.c: Fix common/ includes.
12712 * location.c: Fix common/ includes.
12713 * linux-thread-db.c: Fix common/ includes.
12714 * linux-nat.c: Fix common/ includes.
12715 * linux-fork.c: Fix common/ includes.
12716 * inline-frame.c: Fix common/ includes.
12717 * infrun.c: Fix common/ includes.
12718 * inflow.c: Fix common/ includes.
12719 * inferior.h: Fix common/ includes.
12720 * inferior.c: Fix common/ includes.
12721 * infcmd.c: Fix common/ includes.
12722 * inf-ptrace.c: Fix common/ includes.
12723 * inf-child.c: Fix common/ includes.
12724 * ia64-linux-nat.c: Fix common/ includes.
12725 * i387-tdep.c: Fix common/ includes.
12726 * i386-tdep.c: Fix common/ includes.
12727 * i386-linux-tdep.c: Fix common/ includes.
12728 * i386-linux-nat.c: Fix common/ includes.
12729 * i386-go32-tdep.c: Fix common/ includes.
12730 * i386-fbsd-tdep.c: Fix common/ includes.
12731 * i386-fbsd-nat.c: Fix common/ includes.
12732 * guile/scm-type.c: Fix common/ includes.
12733 * guile/guile.c: Fix common/ includes.
12734 * go32-nat.c: Fix common/ includes.
12735 * gnu-nat.c: Fix common/ includes.
12736 * gdbthread.h: Fix common/ includes.
12737 * gdbarch-selftests.c: Fix common/ includes.
12738 * gdb_usleep.c: Fix common/ includes.
12739 * gdb_select.h: Fix common/ includes.
12740 * gdb_bfd.c: Fix common/ includes.
12741 * gcore.c: Fix common/ includes.
12742 * fork-child.c: Fix common/ includes.
12743 * findvar.c: Fix common/ includes.
12744 * fbsd-nat.c: Fix common/ includes.
12745 * event-top.c: Fix common/ includes.
12746 * event-loop.c: Fix common/ includes.
12747 * dwarf2read.c: Fix common/ includes.
12748 * dwarf2loc.c: Fix common/ includes.
12749 * dwarf2-frame.c: Fix common/ includes.
12750 * dwarf-index-cache.c: Fix common/ includes.
12751 * dtrace-probe.c: Fix common/ includes.
12752 * disasm-selftests.c: Fix common/ includes.
12753 * defs.h: Fix common/ includes.
12754 * csky-tdep.c: Fix common/ includes.
12755 * cp-valprint.c: Fix common/ includes.
12756 * cp-support.h: Fix common/ includes.
12757 * cp-support.c: Fix common/ includes.
12758 * corelow.c: Fix common/ includes.
12759 * completer.h: Fix common/ includes.
12760 * completer.c: Fix common/ includes.
12761 * compile/compile.c: Fix common/ includes.
12762 * compile/compile-loc2c.c: Fix common/ includes.
12763 * compile/compile-cplus-types.c: Fix common/ includes.
12764 * compile/compile-cplus-symbols.c: Fix common/ includes.
12765 * command.h: Fix common/ includes.
12766 * cli/cli-dump.c: Fix common/ includes.
12767 * cli/cli-cmds.c: Fix common/ includes.
12768 * charset.c: Fix common/ includes.
12769 * build-id.c: Fix common/ includes.
12770 * btrace.h: Fix common/ includes.
12771 * btrace.c: Fix common/ includes.
12772 * breakpoint.h: Fix common/ includes.
12773 * breakpoint.c: Fix common/ includes.
12775 (enum agent_op): Fix common/ includes.
12776 * ax-general.c (struct aop_map): Fix common/ includes.
12777 * ax-gdb.c: Fix common/ includes.
12778 * auxv.c: Fix common/ includes.
12779 * auto-load.c: Fix common/ includes.
12780 * arm-tdep.c: Fix common/ includes.
12781 * arch/riscv.c: Fix common/ includes.
12782 * arch/ppc-linux-common.c: Fix common/ includes.
12783 * arch/i386.c: Fix common/ includes.
12784 * arch/arm.c: Fix common/ includes.
12785 * arch/arm-linux.c: Fix common/ includes.
12786 * arch/arm-get-next-pcs.c: Fix common/ includes.
12787 * arch/amd64.c: Fix common/ includes.
12788 * arch/aarch64.c: Fix common/ includes.
12789 * arch/aarch64-insn.c: Fix common/ includes.
12790 * arch-utils.c: Fix common/ includes.
12791 * amd64-windows-tdep.c: Fix common/ includes.
12792 * amd64-tdep.c: Fix common/ includes.
12793 * amd64-sol2-tdep.c: Fix common/ includes.
12794 * amd64-obsd-tdep.c: Fix common/ includes.
12795 * amd64-nbsd-tdep.c: Fix common/ includes.
12796 * amd64-linux-tdep.c: Fix common/ includes.
12797 * amd64-linux-nat.c: Fix common/ includes.
12798 * amd64-fbsd-tdep.c: Fix common/ includes.
12799 * amd64-fbsd-nat.c: Fix common/ includes.
12800 * amd64-dicos-tdep.c: Fix common/ includes.
12801 * amd64-darwin-tdep.c: Fix common/ includes.
12802 * agent.c: Fix common/ includes.
12803 * ada-lang.h: Fix common/ includes.
12804 * ada-lang.c: Fix common/ includes.
12805 * aarch64-tdep.c: Fix common/ includes.
12807 2019-01-25 Tom Tromey <tom@tromey.com>
12809 * common/create-version.sh: Use common/version.h.
12811 2019-01-24 Pedro Alves <palves@redhat.com>
12813 * infrun.c (signal_stop, signal_print, signal_program)
12814 (signal_catch, signal_pass): Now arrays instead of pointers.
12815 (update_signals_program_target, do_target_resume)
12816 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12817 * linux-nat.c (linux_nat_target::pass_signals)
12818 (linux_nat_target::create_inferior, linux_nat_target::attach):
12820 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12821 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12822 * procfs.c (procfs_target::pass_signals): Adjust.
12823 * record-full.c (record_full_target::resume): Adjust.
12824 * remote.c (remote_target::pass_signals)
12825 (remote_target::program_signals): Adjust.
12826 * target-debug.h (target_debug_print_signals): Now takes a
12827 gdb::array_view as parameter. Adjust.
12828 * target.h (target_ops) <pass_signals, program_signals>: Replace
12829 pointer and length parameters with gdb::array_view.
12830 (target_pass_signals, target_program_signals): Likewise.
12831 * target-delegates.c: Regenerate.
12833 2019-01-24 Pedro Alves <palves@redhat.com>
12835 * common/forward-scope-exit.h
12836 (forward_scope_exit::forward_scope_exit): Pass arguments to
12837 m_bind_function directly, instead of creating a std::bind and
12840 2019-01-24 Alan Hayward <alan.hayward@arm.com>
12842 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12843 for static members.
12844 (pass_in_v_vfp_candidate): Likewise.
12846 2019-01-23 Tom Tromey <tom@tromey.com>
12847 Pedro Alves <palves@redhat.com>
12849 * regcache.c (class regcache_invalidator): Remove.
12850 (regcache::raw_write): Use make_scope_exit.
12852 2019-01-23 Tom Tromey <tom@tromey.com>
12854 * ui-out.h (class ui_out_emit_type): Update comment.
12856 2019-01-23 Tom Tromey <tom@tromey.com>
12858 * infrun.c (fetch_inferior_event): Update comment.
12860 2019-01-23 Tom Tromey <tom@tromey.com>
12861 Pedro Alves <palves@redhat.com>
12863 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12865 (fetch_inferior_event): Use SCOPE_EXIT.
12868 2019-01-23 Tom Tromey <tom@tromey.com>
12869 Pedro Alves <palves@redhat.com>
12871 * infrun.c (disable_thread_events): Delete.
12872 (stop_all_threads): Use SCOPE_EXIT.
12874 2019-01-23 Tom Tromey <tom@tromey.com>
12875 Pedro Alves <palves@redhat.com>
12877 * symfile.c: Include forward-scope-exit.h.
12878 (clear_symtab_users_cleanup): Replace forward declaration with
12879 a FORWARD_SCOPE_EXIT.
12880 (syms_from_objfile_1): Use the forward_scope_exit and
12881 gdb::optional instead of cleanup_function.
12882 (reread_symbols): Use the forward_scope_exit instead of
12884 (clear_symtab_users_cleanup): Remove function.
12886 2019-01-23 Tom Tromey <tom@tromey.com>
12887 Pedro Alves <palves@redhat.com>
12889 * linux-nat.c: Include scope-exit.h.
12890 (cleanup_target_stop): Remove.
12891 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12894 2019-01-23 Tom Tromey <tom@tromey.com>
12895 Pedro Alves <palves@redhat.com>
12897 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12898 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12900 2019-01-23 Tom Tromey <tom@tromey.com>
12901 Andrew Burgess <andrew.burgess@embecosm.com>
12902 Pedro Alves <palves@redhat.com>
12904 * infrun.c (fetch_inferior_event): Use scope_exit.
12905 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12906 * top.c (execute_command): Use scope_exit.
12907 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12908 * utils.c (do_bpstat_clear_actions_cleanup)
12909 (make_bpstat_clear_actions_cleanup): Remove.
12911 2019-01-23 Tom Tromey <tom@tromey.com>
12912 Pedro Alves <palves@redhat.com>
12914 * infrun.c: Include "common/scope-exit.h"
12915 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12916 (wait_for_inferior): Use SCOPE_EXIT.
12917 (fetch_inferior_event): Use scope_exit.
12919 2019-01-23 Tom Tromey <tom@tromey.com>
12920 Pedro Alves <palves@redhat.com>
12922 * breakpoint.c (create_breakpoint): Remove cleanup.
12924 2019-01-23 Tom Tromey <tom@tromey.com>
12925 Andrew Burgess <andrew.burgess@embecosm.com>
12926 Pedro Alves <palves@redhat.com>
12928 2019-01-23 Pedro Alves <palves@redhat.com>
12930 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12932 2019-01-23 Pedro Alves <palves@redhat.com>
12933 Andrew Burgess <andrew.burgess@embecosm.com>
12935 * gdbthread.h: Include "common/forward-scope-exit.h".
12936 (scoped_finish_thread_state): Redefine custom class in terms of
12937 forward_scope_exit.
12939 2019-01-23 Pedro Alves <palves@redhat.com>
12940 Andrew Burgess <andrew.burgess@embecosm.com>
12942 * common/forward-scope-exit.h: New file.
12944 2019-01-23 Pedro Alves <palves@redhat.com>
12945 Andrew Burgess <andrew.burgess@embecosm.com>
12946 Tom Tromey <tom@tromey.com>
12948 * common/scope-exit.h: New file.
12950 2019-01-23 Pedro Alves <palves@redhat.com>
12952 * common/preprocessor.h (ESC): Rename to ...
12953 (ESC_PARENS): ... this.
12954 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12955 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12957 2019-01-23 Tom Tromey <tom@tromey.com>
12959 * language.h (class scoped_switch_to_sym_language_if_auto):
12960 Initialize m_lang in both cases.
12962 2019-01-23 Alan Hayward <alan.hayward@arm.com>
12964 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12967 2019-01-22 Tom Tromey <tom@tromey.com>
12969 * corelow.c: Do not include sys/file.h.
12971 2019-01-22 Tom Tromey <tom@tromey.com>
12973 * tui/tui-wingeneral.h: Include gdb_curses.h.
12975 2019-01-22 Tom Tromey <tom@tromey.com>
12977 * source-cache.h (class source_cache) <get_source_lines,
12978 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12980 2019-01-22 Tom Tromey <tom@tromey.com>
12982 * remote-fileio.h (struct remote_target): Declare.
12984 2019-01-22 Tom Tromey <tom@tromey.com>
12986 * python/py-arch.c: Do not include py-ref.h.
12987 * python/py-bpevent.c: Do not include py-ref.h.
12988 * python/py-cmd.c: Do not include py-ref.h.
12989 * python/py-continueevent.c: Do not include py-ref.h.
12990 * python/py-event.h: Do not include py-ref.h.
12991 * python/py-evtregistry.c: Do not include py-ref.h.
12992 * python/py-finishbreakpoint.c: Do not include py-ref.h.
12993 * python/py-frame.c: Do not include py-ref.h.
12994 * python/py-framefilter.c: Do not include py-ref.h.
12995 * python/py-function.c: Do not include py-ref.h.
12996 * python/py-infevents.c: Do not include py-ref.h.
12997 * python/py-linetable.c: Do not include py-ref.h.
12998 * python/py-objfile.c: Do not include py-ref.h.
12999 * python/py-param.c: Do not include py-ref.h.
13000 * python/py-prettyprint.c: Do not include py-ref.h.
13001 * python/py-progspace.c: Do not include py-ref.h.
13002 * python/py-symbol.c: Do not include py-ref.h.
13003 * python/py-symtab.c: Do not include py-ref.h.
13004 * python/py-type.c: Do not include py-ref.h.
13005 * python/py-unwind.c: Do not include py-ref.h.
13006 * python/py-utils.c: Do not include py-ref.h.
13007 * python/py-value.c: Do not include py-ref.h.
13008 * python/py-varobj.c: Do not include py-ref.h.
13009 * python/py-xmethods.c: Do not include py-ref.h.
13010 * python/python.c: Do not include py-ref.h.
13011 * varobj.c: Do not include py-ref.h.
13013 2019-01-22 Tom Tromey <tom@tromey.com>
13015 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13016 keyword for bcache.
13018 2019-01-22 Tom Tromey <tom@tromey.com>
13020 * compile/compile-cplus-types.c: Remove a comment by #include.
13022 2019-01-22 Tom Tromey <tom@tromey.com>
13024 * compile/gcc-c-plugin.h: Include compile-internal.h.
13026 2019-01-22 Tom Tromey <tom@tromey.com>
13028 * stabsread.c (EXTERN): Do not define.
13029 (symnum, next_symbol_text_func, processing_gcc_compilation)
13030 (within_function, global_sym_chain, global_stabs)
13031 (previous_stab_code, this_object_header_files)
13032 (n_this_object_header_files)
13033 (n_allocated_this_object_header_files): Define.
13034 * stabsread.h (EXTERN): Never define. Use "extern".
13036 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13038 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13041 2019-01-21 Tom Tromey <tom@tromey.com>
13043 * ui-out.c: Fix includes.
13044 * tui/tui-source.c: Fix includes.
13045 * target.c: Fix includes.
13046 * remote.c: Fix includes.
13047 * regcache.c: Fix includes.
13048 * python/py-block.c: Fix includes.
13049 * printcmd.c: Fix includes.
13050 * or1k-tdep.c: Fix includes.
13051 * mi/mi-main.c: Fix includes.
13052 * m32r-tdep.c: Fix includes.
13053 * csky-tdep.c: Fix includes.
13054 * compile/compile-cplus-types.c: Fix includes.
13055 * cli/cli-interp.c: Fix includes.
13057 2019-01-21 Alan Hayward <alan.hayward@arm.com>
13059 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13062 2019-01-16 Tom Tromey <tom@tromey.com>
13064 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
13066 (struct objfile) <msymbols_range>: Move from top level.
13067 <msymbols>: New method.
13068 (class objfile_msymbols): Remove.
13069 * symtab.c (default_collect_symbol_completion_matches_break_on):
13071 * symmisc.c (dump_msymbols): Update.
13072 * stabsread.c (scan_file_globals): Update.
13073 * objc-lang.c (info_selectors_command, info_classes_command)
13074 (find_methods): Update.
13075 * minsyms.c (find_solib_trampoline_target): Update.
13076 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13077 * coffread.c (coff_symfile_read): Update.
13078 * ada-lang.c (ada_lookup_simple_minsym)
13079 (ada_collect_symbol_completion_matches): Update.
13081 2019-01-16 Tom Tromey <tom@tromey.com>
13083 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13084 type. Remove no-argument constructor.
13085 <iterator::operator++>: Simplify.
13087 <end>: Use minimal_symbol_count.
13089 2019-01-16 Tom Tromey <tom@tromey.com>
13091 * objfiles.h (struct objfile) <psymtabs>: New method.
13092 (class objfile_psymtabs): Remove.
13093 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13095 <range>: New method.
13096 (require_partial_symbols): Change return type.
13097 * psymtab.c (require_partial_symbols)
13098 (psym_expand_symtabs_matching): Update.
13099 * mdebugread.c (parse_partial_symbols): Update.
13100 * dbxread.c (dbx_end_psymtab): Update.
13102 2019-01-15 Tom Tromey <tom@tromey.com>
13104 * symtab.c (lookup_objfile_from_block)
13105 (lookup_symbol_in_objfile_symtabs)
13106 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13107 (find_line_symtab, info_sources_command)
13108 (default_collect_symbol_completion_matches_break_on)
13109 (make_source_files_completion_list): Update.
13110 * symmisc.c (print_objfile_statistics, dump_objfile)
13111 (maintenance_print_symbols, maintenance_info_symtabs)
13112 (maintenance_check_symtabs, maintenance_info_line_tables):
13114 * source.c (select_source_symtab)
13115 (forget_cached_source_info_for_objfile): Update.
13116 * objfiles.h (class objfile_compunits): Remove.
13117 (struct objfile) <compunits_range>: New typedef.
13118 (compunits): New method.
13119 * objfiles.c (objfile_relocate1): Update.
13120 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13121 * maint.c (count_symtabs_and_blocks): Update.
13122 * linespec.c (iterate_over_all_matching_symtabs): Update.
13123 * cp-support.c (add_symbol_overload_list_qualified): Update.
13124 * coffread.c (coff_symtab_read): Update.
13125 * ada-lang.c (add_nonlocal_symbols)
13126 (ada_collect_symbol_completion_matches)
13127 (ada_add_global_exceptions): Update.
13129 2019-01-15 Tom Tromey <tom@tromey.com>
13131 * progspace.h (program_space) <objfiles_safe_range>: New
13133 <objfiles_safe>: New method.
13134 * objfiles.h (class all_objfiles_safe): Remove.
13135 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13136 * jit.c (jit_inferior_exit_hook): Update.
13138 2019-01-17 Tom Tromey <tom@tromey.com>
13140 * progspace.h (program_space) <objfiles_range>: New typedef.
13141 <objfiles>: New method.
13142 <objfiles_head>: Rename from objfiles.
13143 (object_files): Update.
13144 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13145 * guile/scm-pretty-print.c
13146 (ppscm_find_pretty_printer_from_objfiles): Update.
13147 * guile/scm-objfile.c (gdbscm_objfiles): Update.
13148 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13150 * python/py-progspace.c (pspy_get_objfiles): Update.
13151 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13153 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13154 (objfpy_lookup_objfile_by_build_id): Update.
13155 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13156 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13158 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13159 (expand_symtab_containing_pc, lookup_objfile_from_block)
13160 (lookup_static_symbol, basic_lookup_transparent_type)
13161 (find_pc_sect_compunit_symtab, find_symbol_at_address)
13162 (find_line_symtab, info_sources_command)
13163 (default_collect_symbol_completion_matches_break_on)
13164 (make_source_files_completion_list, find_main_name): Update.
13165 * symmisc.c (print_symbol_bcache_statistics)
13166 (print_objfile_statistics, maintenance_print_symbols)
13167 (maintenance_print_msymbols, maintenance_print_objfiles)
13168 (maintenance_info_symtabs, maintenance_check_symtabs)
13169 (maintenance_expand_symtabs, maintenance_info_line_tables):
13171 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13172 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13173 (map_overlay_command, unmap_overlay_command)
13174 (simple_overlay_update, expand_symtabs_matching)
13175 (map_symbol_filenames): Update.
13176 * symfile-debug.c (set_debug_symfile): Update.
13177 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13179 * source.c (select_source_symtab, forget_cached_source_info):
13181 * solib.c (solib_read_symbols): Update.
13182 * solib-spu.c (append_ocl_sos): Update.
13183 * psymtab.c (maintenance_print_psymbols)
13184 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13185 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13186 * printcmd.c (info_symbol_command): Update.
13187 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13189 * objfiles.h (class all_objfiles): Remove.
13190 * objfiles.c (have_partial_symbols, have_full_symbols)
13191 (have_minimal_symbols, qsort_cmp, update_section_map)
13192 (shared_objfile_contains_address_p)
13193 (default_iterate_over_objfiles_in_search_order): Update.
13194 * objc-lang.c (info_selectors_command, info_classes_command)
13195 (find_methods): Update.
13196 * minsyms.c (find_solib_trampoline_target): Update.
13197 * maint.c (maintenance_info_sections)
13198 (maintenance_translate_address, count_symtabs_and_blocks):
13200 * main.c (captured_main_1): Update.
13201 * linux-thread-db.c (try_thread_db_load_from_pdir)
13202 (has_libpthread): Update.
13203 * linespec.c (iterate_over_all_matching_symtabs)
13204 (search_minsyms_for_name): Update.
13205 * jit.c (jit_find_objf_with_entry_addr): Update.
13206 * hppa-tdep.c (find_unwind_entry)
13207 (hppa_lookup_stub_minimal_symbol): Update.
13208 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13210 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13211 (elf_gnu_ifunc_resolve_by_got): Update.
13212 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13213 * dwarf-index-write.c (save_gdb_index_command): Update.
13214 * cp-support.c (add_symbol_overload_list_qualified): Update.
13215 * breakpoint.c (create_overlay_event_breakpoint)
13216 (create_longjmp_master_breakpoint)
13217 (create_std_terminate_master_breakpoint)
13218 (create_exception_master_breakpoint): Update.
13219 * blockframe.c (find_pc_partial_function): Update.
13220 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13221 (ada_collect_symbol_completion_matches)
13222 (ada_add_global_exceptions): Update.
13224 2019-01-17 Tom Tromey <tom@tromey.com>
13226 * solib-target.c (lm_info_target_p): Remove typedef. Don't
13228 (solib_target_parse_libraries): Change return type.
13229 (library_list_start_segment, library_list_start_section)
13230 (library_list_end_library, library_list_start_library); Update.
13231 (solib_target_free_library_list): Remove.
13232 (solib_target_parse_libraries): Remove cleanup. Change return
13234 (solib_target_current_sos): Update.
13236 2019-01-17 Tom Tromey <tromey@bapiya>
13238 * valprint.c: Replace "the the" with "the".
13239 * symtab.c: Replace "the the" with "the".
13240 * solib.c: Replace "the the" with "the".
13241 * solib-dsbt.c: Replace "the the" with "the".
13242 * linespec.c: Replace "the the" with "the".
13243 * dwarf2loc.h: Replace "the the" with "the".
13244 * amd64-windows-tdep.c: Replace "the the" with "the".
13245 * aarch64-tdep.c: Replace "the the" with "the".
13247 2019-01-16 Keith Seitz <keiths@redhat.com>
13250 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13251 <builder>: Rename to ..
13252 <m_builder>: ... this and make private.
13253 (dwarf2_cu::get_builder): New method. Change all users of
13254 `builder' to use this method.
13255 (dwarf2_start_symtab): Move to ...
13256 (dwarf2_cu::start_symtab): ... here. Update all callers
13257 (setup_type_unit_groups): Move to ...
13258 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
13260 (dwarf2_cu::reset_builder): New method.
13261 (process_full_compunit, process_full_type_unit): Use
13262 dwarf2_cu::reset_builder.
13263 (follow_die_offset): Record the ancestor CU if it is different
13264 from the followed DIE's CU.
13265 (follow_die_sig_1): Likewise.
13267 2019-01-15 Tom Tromey <tom@tromey.com>
13269 * remote.c (class remote_state) <buf>: Now a char_vector.
13270 <buf_size>: Remove.
13271 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
13273 (remote_target::getpkt_or_notif_sane_1)
13274 (remote_target::getpkt_sane)
13275 (remote_target::getpkt_or_notif_sane): Likewise.
13276 (class remote_target) <putpkt>: New overload.
13277 (remote_target::read_frame): Change type of "buf_p". Remove
13278 sizeof_p parameter.
13279 (packet_ok): New overload.
13280 (packet_check_result): New overload.
13283 2019-01-14 Tom Tromey <tom@tromey.com>
13285 * remote-notif.c (handle_notification, remote_notif_ack)
13286 (remote_notif_parse): Make "buf" const.
13287 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13289 (remote_notif_parse, remote_notif_ack, handle_notification):
13291 * remote.c (remote_notif_stop_parse): Make "buf" const.
13292 (remote_target::remote_parse_stop_reply): Make "buf" const.
13293 (remote_notif_stop_ack): Make "buf" const.
13295 2019-01-14 Tom Tromey <tom@tromey.com>
13297 * remote.c (remote_console_output): Make parameter const.
13299 2019-01-14 Tom Tromey <tom@tromey.com>
13301 * target-debug.h (target_debug_print_signals): Constify.
13302 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13303 * procfs.c (procfs_target::pass_signals): Update.
13304 * linux-nat.c (linux_nat_target::pass_signals): Update.
13305 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13306 * target-delegates.c: Rebuild.
13307 * remote.c (remote_target::program_signals): Update.
13308 (remote_target::pass_signals): Update.
13309 * target.c (target_pass_signals): Constify argument.
13310 (target_program_signals): Likewise.
13311 * target.h (struct target_ops) <pass_signals, program_signals>:
13313 (target_pass_signals, target_program_signals): Constify argument.
13315 2019-01-14 Tom Tromey <tom@tromey.com>
13318 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13320 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
13322 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13324 * rs6000-tdep.c: Include reggroups.h.
13325 (IS_V_ALIAS_PSEUDOREG): Define.
13326 (rs6000_register_name): Return names for the "vX" aliases.
13327 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13328 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
13329 aliases. Call default_register_reggroup_p for all other
13331 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13333 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13334 Handle "vX" aliases.
13335 (v_alias_pseudo_register_collect): New function.
13336 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13337 (rs6000_gdbarch_init): Initialize "vX" aliases as
13338 pseudo-registers. Restore registration of
13339 rs6000_pseudo_register_reggroup_p with
13340 set_tdesc_pseudo_register_reggroup_p.
13342 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
13344 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13345 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13346 set_gdbarch_num_pseudo_regs.
13348 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13350 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13351 Remove arg prefixname, add do_set and do_show.
13352 Add member functions set_list and show_list.
13353 * cli/cli-style.c (class cli_style_option): Update accordingly.
13354 (style_set_list): Move to file scope.
13355 (style_show_list): Likewise.
13356 (set_style): Call help_list.
13357 (show_style): Call cmd_show_list.
13358 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13359 Update to use the new macro.
13361 2019-10-12 Joel Brobecker <brobecker@adacore.com>
13363 * ada-lang.c (_initialize_ada_language): Expand the help text
13364 for the "catch exception" command.
13366 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13368 * symtab.c (matching_obj_sections): Initialize obj,
13369 declare it closer to its usage.
13371 2019-01-10 Tom Tromey <tom@tromey.com>
13373 * thread-iter.h (inf_threads_iterator): Use next_iterator.
13374 (basic_inf_threads_range): Remove.
13375 (inf_threads_range, inf_non_exited_threads_range)
13376 (safe_inf_threads_range): Use next_adapter.
13378 2019-01-10 Keith Seitz <keiths@redhat.com>
13382 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13383 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13385 2019-01-10 Keith Seitz <keiths@redhat.com>
13389 * dictionary.c (pending_to_vector): Remove.
13390 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13391 Remove _1 suffix, replacing functions of the same name. Update
13393 (dict_create_hashed, dict_create_hashed_expandable)
13394 (dict_create_linear, dict_create_linear_expandable, dict_free)
13395 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13396 Make functions static.
13398 2019-01-10 Keith Seitz <keiths@redhat.com>
13402 * dictionary.h (struct dictionary): Replace declaration with
13404 (dict_create_hashed, dict_create_hashed_expandable)
13405 (dict_create_linear, dict_create_linear_expandable)
13406 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13407 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13408 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13409 taking multidictionary argument.
13410 [ALL_DICT_SYMBOLS]: Update for multidictionary.
13411 * block.h (struct block) <dict>: Change to multidictionary
13412 and rename `multidict'.
13413 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13414 symmisc.c: Update all dictionary references to multidictionary.
13416 2019-01-10 Keith Seitz <keiths@redhat.com>
13420 * dictionary.c: Include unordered_map.
13421 (pending_to_vector): New function.
13422 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13423 Rewrite the non-"_1" functions to take vector instead
13425 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13426 "new" _1 versions of the same name.
13427 (multidictionary): Define.
13428 (std::hash<enum language): New definition.
13429 (collate_pending_symbols_by_language, mdict_create_hashed)
13430 (mdict_create_hashed_expandable, mdict_create_linear)
13431 (mdict_create_linear_expandable, mdict_free)
13432 (find_language_dictionary, create_new_language_dictionary)
13433 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13434 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13435 (mdict_size, mdict_empty): New functions.
13436 * dictionary.h (mdict_iterator): Define.
13438 2019-01-10 Pedro Alves <palves@redhat.com>
13440 * breakpoint.c (read_uploaded_action)
13441 (create_tracepoint_from_upload): Adjust to use
13442 gdb::unique_xmalloc_ptr.
13443 * ctf.c (ctf_write_uploaded_tp):
13444 (SET_ARRAY_FIELD): Use emplace_back.
13445 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13446 * tracefile-tfile.c (tfile_write_uploaded_tp):
13447 * tracepoint.c (parse_tracepoint_definition): Adjust to use
13448 gdb::unique_xmalloc_ptr.
13449 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13450 at_string, cond_string, cmd_strings>: Replace char pointers
13451 with gdb::unique_xmalloc_ptr.
13453 2019-01-10 Pedro Alves <palves@redhat.com>
13455 * solib-target.c (library_list_start_library): Don't xstrdup name.
13457 2019-01-10 Pedro Alves <palves@redhat.com>
13459 * mdebugread.c (parse_partial_symbols): Use
13460 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13462 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
13464 * linux-fork.c (scoped_switch_fork_info)
13465 <~scoped_switch_fork_info>: Fix incorrect variable name.
13467 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
13469 * linux-fork.c (scoped_switch_fork_info)
13470 <scoped_switch_fork_info>: Make explicit.
13471 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13473 2019-01-10 Tom Tromey <tom@tromey.com>
13475 * objfiles.h (objfile::reset_psymtabs): Update.
13476 * objfiles.c (objfile::objfile): Update.
13477 * psymtab.h (psymtab_storage::obstack): Update.
13478 (psymtab_storage::m_obstack): Use gdb::optional.
13479 (class psymtab_storage): Update comment. Remove objfile
13481 * psymtab.c (psymtab_storage::psymtab_storage): Update.
13483 2019-01-10 Tom Tromey <tom@tromey.com>
13485 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13486 <free_psymtabs>: Now private.
13487 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13488 (allocate_psymtab): Use new method.
13490 2019-01-10 Tom Tromey <tom@tromey.com>
13492 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13493 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13494 * mdebugread.c (parse_partial_symbols): Use
13495 allocate_dependencies.
13496 * dwarf2read.c (dwarf2_create_include_psymtab): Use
13497 allocate_dependencies.
13498 (process_psymtab_comp_unit_reader)
13499 (build_type_psymtab_dependencies): Likewise.
13500 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13502 2019-01-10 Tom Tromey <tom@tromey.com>
13504 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13505 PSYMBOL_SET_LANGUAGE.
13506 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13508 2019-01-10 Tom Tromey <tom@tromey.com>
13510 * psymtab.h (psymtab_storage::obstack): New method.
13511 <m_obstack>: Rename from obstack; now private.
13512 * psymtab.c (psymtab_storage): Update.
13513 * dwarf2read.c (create_addrmap_from_index)
13514 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13517 2019-01-10 Tom Tromey <tom@tromey.com>
13519 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13520 * objfiles.h (objfile::reset_psymtabs): New method.
13522 2019-01-10 Tom Tromey <tom@tromey.com>
13524 * symmisc.c (print_symbol_bcache_statistics): Update.
13525 (print_objfile_statistics): Update.
13526 * symfile.c (reread_symbols): Update.
13527 * psymtab.h (class psymtab_storage): New.
13528 * psymtab.c (psymtab_storage): New constructor.
13529 (~psymtab_storage): New destructor.
13530 (require_partial_symbols): Update.
13531 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13532 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13533 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13534 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13535 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13536 (start_psymtab_common, end_psymtab_common)
13537 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13538 (allocate_psymtab): Update.
13539 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13541 (dump_psymtab_addrmap, maintenance_print_psymbols)
13542 (maintenance_check_psymtabs): Update.
13543 (class objfile_psymtabs): Move to objfiles.h.
13544 * psympriv.h (discard_psymtab): Now inline.
13545 (psymtab_discarder::psymtab_discarder): Update.
13546 (psymtab_discarder::~psymtab_discarder): Update.
13547 (ALL_OBJFILE_PSYMTABS): Rewrite.
13548 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13549 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13551 <partial_symtabs>: New field.
13552 (class objfile_psymtabs): Move from psymtab.h. Update.
13553 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13555 (objfile::~objfile): Don't destroy psymbol_cache.
13556 * mdebugread.c (parse_partial_symbols): Update.
13557 * dwarf2read.c (create_addrmap_from_index)
13558 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13559 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13560 (add_partial_subprogram, dwarf2_ranges_read): Update.
13561 * dwarf-index-write.c (write_address_map)
13562 (write_one_signatured_type, recursively_write_psymbols)
13563 (class debug_names, class debug_names, write_psymtabs_to_index):
13566 2019-01-10 Tom Tromey <tom@tromey.com>
13568 * symtab.h (SYMBOL_SET_NAMES): Update.
13569 (symbol_set_names): Update.
13570 (MSYMBOL_SET_NAMES): Update.
13571 * symtab.c (symbol_set_names): Change argument to be an
13572 objfile_per_bfd_storage.
13573 * psymtab.c (add_psymbol_to_bcache): Update.
13574 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13576 2019-01-10 Tom Tromey <tom@tromey.com>
13578 * symtab.c (create_demangled_names_hash): Change argument to be an
13579 objfile_per_bfd_storage.
13580 (symbol_set_names): Update.
13582 2019-01-10 Tom Tromey <tom@tromey.com>
13584 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13586 * psymtab.c (init_psymbol_list): Do nothing if already called.
13587 * psympriv.h (init_psymbol_list): Add comment.
13588 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13590 * dbxread.c (dbx_symfile_read): Unconditionally call
13593 2019-01-10 Tom Tromey <tom@tromey.com>
13595 * xcoffread.c (scan_xcoff_symtab): Update.
13596 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13598 * mdebugread.c (parse_partial_symbols)
13599 (handle_psymbol_enumerators): Update.
13600 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13601 * dbxread.c (read_dbx_symtab): Update.
13602 * psympriv.h (psymbol_placement): New enum.
13603 (add_psymbol_to_list): Update.
13605 2019-01-10 Tom Tromey <tom@tromey.com>
13607 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13608 static_psymbols parameters.
13609 (scan_xcoff_symtab): Update.
13610 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13611 static_psymbols parameters.
13612 * psympriv.h (start_psymtab_common): Update.
13613 * mdebugread.c (parse_partial_symbols): Update.
13614 * dwarf2read.c (create_partial_symtab): Update.
13615 * dbxread.c (read_dbx_symtab): Update.
13616 (start_psymtab): Remove global_psymbols and static_psymbols
13619 2019-01-10 Tom Tromey <tom@tromey.com>
13621 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13622 * psymtab.c (allocate_psymtab): Add comment.
13623 * psympriv.h (allocate_psymtab): Add comment.
13624 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13626 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13628 2019-01-10 Tom Tromey <tom@tromey.com>
13630 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13632 * mipsread.c: Include mdebugread.h.
13633 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13635 * elfread.c: Include mdebugread.h.
13637 2019-01-09 Tom Tromey <tom@tromey.com>
13639 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13640 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13641 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13642 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13643 (psym_lookup_symbol, psym_find_last_source_symtab)
13644 (psym_forget_cached_source_info, psym_print_stats)
13645 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13646 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13647 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13648 (psym_find_compunit_symtab_by_address)
13649 (maintenance_print_psymbols, maintenance_info_psymtabs)
13650 (maintenance_check_psymtabs): Use ranged for.
13651 * psymtab.h (class objfile_psymtabs): New.
13652 (require_partial_symbols): Return objfile_psymtabs.
13653 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13655 2019-01-09 Tom Tromey <tom@tromey.com>
13657 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13658 (find_pc_mapped_section, list_overlays_command)
13659 (map_overlay_command, unmap_overlay_command)
13660 (simple_overlay_update): Use all_objfiles.
13661 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13662 * printcmd.c (info_symbol_command): Use all_objfiles.
13663 * objfiles.h (ALL_OBJSECTIONS): Remove.
13664 * maint.c (maintenance_translate_address): Use all_objfiles.
13665 * gcore.c (gcore_create_callback): Use all_objfiles.
13666 (objfile_find_memory_regions): Likewise.
13668 2019-01-09 Tom Tromey <tom@tromey.com>
13670 * symtab.c (find_line_symtab, info_sources_command)
13671 (make_source_files_completion_list): Use objfile_compunits.
13672 * source.c (select_source_symtab): Use objfile_compunits.
13673 * objfiles.h (struct objfile): Update comment.
13674 (ALL_OBJFILES): Remove.
13675 (ALL_FILETABS): Remove.
13676 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13679 2019-01-09 Tom Tromey <tom@tromey.com>
13681 * symmisc.c (print_objfile_statistics, dump_objfile)
13682 (maintenance_print_symbols): Use compunit_filetabs.
13683 * source.c (forget_cached_source_info_for_objfile): Use
13685 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13686 (ALL_FILETABS): Use compunit_filetabs.
13687 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13688 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13690 2019-01-09 Tom Tromey <tom@tromey.com>
13692 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13693 (compunit_filetabs): New.
13694 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13696 (info_sources_command, make_source_files_completion_list): Remove
13698 * symmisc.c (print_objfile_statistics, dump_objfile)
13699 (maintenance_print_symbols): Remove declaration.
13700 (maintenance_info_symtabs): Use compunit_filetabs.
13701 (maintenance_info_line_tables): Likewise.
13702 * source.c (select_source_symtab): Change local variable name.
13703 (forget_cached_source_info_for_objfile): Remove declaration.
13704 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13705 * objfiles.c (objfile_relocate1): Remove declaration.
13706 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13708 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13709 * coffread.c (coff_symtab_read): Remove declaration.
13710 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13713 2019-01-09 Tom Tromey <tom@tromey.com>
13715 * symtab.c (lookup_objfile_from_block)
13716 (find_pc_sect_compunit_symtab, search_symbols)
13717 (default_collect_symbol_completion_matches_break_on): Use
13719 * objfiles.h (ALL_COMPUNITS): Remove.
13720 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13721 * cp-support.c (add_symbol_overload_list_qualified): Use
13723 * ada-lang.c (ada_collect_symbol_completion_matches)
13724 (ada_add_global_exceptions): Use objfile_compunits.
13726 2019-01-09 Tom Tromey <tom@tromey.com>
13728 * source.c (select_source_symtab)
13729 (forget_cached_source_info_for_objfile): Remove declaration.
13730 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13732 * maint.c (count_symtabs_and_blocks): Remove declaration.
13733 * cp-support.c (add_symbol_overload_list_qualified): Remove
13735 * coffread.c (coff_symtab_read): Remove declaration.
13736 * symtab.c (lookup_symbol_in_objfile_symtabs)
13737 (basic_lookup_transparent_type_1): Use objfile_compunits.
13738 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13739 (info_sources_command, search_symbols)
13740 (default_collect_symbol_completion_matches_break_on)
13741 (make_source_files_completion_list): Remove declaration.
13742 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13743 (ada_collect_symbol_completion_matches)
13744 (ada_add_global_exceptions): Remove declaration.
13745 * linespec.c (iterate_over_all_matching_symtabs): Use
13747 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13748 (class objfile_compunits): New.
13749 (ALL_COMPUNITS): Use objfile_compunits.
13750 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13751 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13753 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13755 2019-01-09 Tom Tromey <tom@tromey.com>
13757 * symtab.c (search_symbols)
13758 (default_collect_symbol_completion_matches_break_on): Use
13760 * ada-lang.c (ada_lookup_simple_minsym)
13761 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13762 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13763 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13765 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13766 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13767 * objc-lang.c (find_methods): Use objfile_msymbols.
13768 (info_selectors_command, info_classes_command): Likewise.
13769 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13770 * objfiles.h (class objfile_msymbols): New.
13771 (ALL_OBJFILE_MSYMBOLS): Remove.
13772 (ALL_MSYMBOLS): Remove.
13774 2019-01-09 Tom Tromey <tom@tromey.com>
13776 * common/next-iterator.h (next_adapter): Add Iterator template
13778 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13779 (class all_objfiles_safe): New.
13780 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13781 * objfiles.c (put_objfile_before): Update comment.
13782 (add_separate_debug_objfile): Likewise.
13783 (free_all_objfiles): Use all_objfiles_safe.
13784 (objfile_purge_solibs): Likewise.
13786 2019-01-09 Tom Tromey <tom@tromey.com>
13788 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13789 (expand_symtab_containing_pc, lookup_static_symbol)
13790 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13791 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13793 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13794 * breakpoint.c (create_overlay_event_breakpoint)
13795 (create_longjmp_master_breakpoint)
13796 (create_std_terminate_master_breakpoint)
13797 (create_exception_master_breakpoint): Use all_objfiles.
13798 * linux-thread-db.c (try_thread_db_load_from_pdir)
13799 (has_libpthread): Use all_objfiles.
13800 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13801 * linespec.c (iterate_over_all_matching_symtabs)
13802 (search_minsyms_for_name): Use all_objfiles.
13803 * maint.c (maintenance_info_sections): Use all_objfiles.
13804 * main.c (captured_main_1): Use all_objfiles.
13805 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13806 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13807 * guile/scm-pretty-print.c
13808 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13809 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13810 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13811 (maintenance_print_msymbols): Use all_objfiles.
13812 * source.c (select_source_symtab): Use all_objfiles.
13813 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13814 * symfile.c (remove_symbol_file_command)
13815 (expand_symtabs_matching, map_symbol_filenames): Use
13817 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13819 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13820 * objc-lang.c (find_methods): Use all_objfiles.
13821 * objfiles.c (have_partial_symbols, have_full_symbols)
13822 (have_minimal_symbols, qsort_cmp)
13823 (default_iterate_over_objfiles_in_search_order): Use
13825 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13826 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13827 (maintenance_check_psymtabs): Use all_objfiles.
13828 (ALL_PSYMTABS): Remove.
13829 * compile/compile-object-run.c (do_module_cleanup): Use
13831 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13832 * cp-support.c (add_symbol_overload_list_qualified): Use
13834 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13836 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13837 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13839 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13840 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13841 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13843 * solib.c (solib_read_symbols): Use all_objfiles
13845 2019-01-09 Tom Tromey <tom@tromey.com>
13847 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13848 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13850 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13851 * symmisc.c (print_symbol_bcache_statistics)
13852 (print_objfile_statistics, maintenance_print_objfiles)
13853 (maintenance_info_symtabs, maintenance_check_symtabs)
13854 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13856 * source.c (forget_cached_source_info): Use all_objfiles.
13857 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13858 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13859 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13860 * objfiles.c (update_section_map): Use all_objfiles.
13861 (shared_objfile_contains_address_p): Likewise.
13862 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13863 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13865 2019-01-09 Tom Tromey <tom@tromey.com>
13867 * common/next-iterator.h: New file.
13868 * objfiles.h (class all_objfiles): New.
13869 (struct objfile_iterator): New.
13871 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13873 * NEWS: Move the description of the changed "frame", "select-frame",
13874 and "info frame" commands to the Changed commands section.
13876 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13878 * gdbtypes.c (check_stub_method_group): Remove handling of old
13880 * linespec.c (find_methods): Likewise.
13881 * stabsread.c (read_member_functions): Likewise.
13882 * valops.c (search_struct_method): Likewise.
13883 (value_struct_elt_for_reference): Likewise.
13884 * NEWS: Mention this change.
13886 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13888 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13889 print_source_lines.
13890 * source.c (print_source_lines_base): Update line number check.
13891 (print_source_lines): New function.
13892 (source_lines_range::source_lines_range): New function.
13893 * source.h (class source_lines_range): New class.
13894 (print_source_lines): New declaration.
13896 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13898 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13900 2019-01-08 Tom Tromey <tom@tromey.com>
13901 Simon Marchi <simon.marchi@ericsson.com>
13904 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13905 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13906 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13907 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13908 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13909 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13911 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13913 * source.c (select_source_symtab): Move header comment to
13914 declaration in source.h.
13915 (forget_cached_source_info_for_objfile): Likewise.
13916 (forget_cached_source_info): Likewise.
13917 (identify_source_line): Likewise.
13918 * source.h (identify_source_line): Move declaration from symtab.h
13919 and add comment from source.c
13920 (print_source_lines): Likewise.
13921 (forget_cached_source_info_for_objfile): Likewise.
13922 (forget_cached_source_info): Likewise.
13923 (select_source_symtab): Likewise.
13924 (enum print_source_lines_flag): Move definition from symtab.h.
13925 * symtab.h (identify_source_line): Move declaration to source.h.
13926 (print_source_lines): Likewise.
13927 (forget_cached_source_info_for_objfile): Likewise.
13928 (forget_cached_source_info): Likewise.
13929 (select_source_symtab): Likewise.
13930 (enum print_source_lines_flag): Move definition to source.h.
13931 * tui/tui-hooks.c: Add 'source.h' include.
13933 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13935 * source.c (print_source_lines_base): Handle requests to print
13936 reverse line number sequences, and guard against empty lines
13939 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13941 * source.c (print_source_lines_base): Fix skip of '\r' if next
13944 2019-01-06 Tom Tromey <tom@tromey.com>
13946 * c-exp.y (struct c_parse_state) <macro_original_text,
13947 expansion_obstack>: New member.
13948 (macro_original_text, expansion_obstack): Remove globals.
13949 (scan_macro_expansion, scanning_macro_expansion)
13950 (finished_macro_expansion): Update.
13951 (scan_macro_cleanup): Remove.
13952 (yylex, c_parse): Update.
13954 2019-01-06 Tom Tromey <tom@tromey.com>
13956 * c-exp.y (struct c_parse_state) <strings>: New member.
13957 (operator_stoken): Update.
13959 2019-01-06 Tom Tromey <tom@tromey.com>
13961 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13962 (union type_stack_elt) <typelist_val>: Now a pointer to
13964 (type_stack_cleanup): Don't declare.
13965 (push_typelist): Update.
13966 * parse.c (pop_typelist): Return a std::vector.
13967 (push_typelist): Take a std::vector.
13968 (follow_types): Update. Do not free args.
13969 (type_stack_cleanup): Remove.
13970 * c-exp.y (struct c_parse_state): New.
13971 (cpstate): New global.
13972 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13973 (nonempty_typelist): Update.
13974 (func_mod): Create a new vector.
13975 (c_parse): Create a c_parse_state.
13976 (check_parameter_typelist): Do not delete params.
13977 (function_method): Update. Do not delete type_list.
13979 2019-01-06 Tom Tromey <tom@tromey.com>
13982 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13984 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13985 (print_return_value): Likewise.
13987 2019-01-05 Tom Tromey <tom@tromey.com>
13989 * contrib/cleanup_check.py: Remove.
13990 * contrib/gcc-with-excheck: Remove.
13991 * contrib/exsummary.py: Remove.
13992 * contrib/excheck.py: Remove.
13994 2019-01-05 Joel Brobecker <brobecker@adacore.com>
13996 * thread.c (delete_thread_1): Add gdb_assert that THR is not
13997 NULL. Initialize tpprev to NULL instead of assigning it
13998 to NULL on the next statement.
13999 * windows-nat.c (windows_delete_thread): Remove check for
14000 main_thread_id before printing thread exit notifications.
14001 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14002 Remove thread ID check against main_thread_id.
14003 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14004 windows_delete_thread.
14005 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14007 2019-01-04 Tom Tromey <tom@tromey.com>
14009 * compile/compile.c (_initialize_compile): Use upper case for
14010 metasyntactic variables.
14011 * symmisc.c (_initialize_symmisc): Use upper case for
14012 metasyntactic variables.
14013 * psymtab.c (_initialize_psymtab): Use upper case for
14014 metasyntactic variables.
14015 * demangle.c (demangle_command): Use upper case for metasyntactic
14017 (_initialize_demangler): Likewise.
14018 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14021 2019-01-03 Tom Tromey <tom@tromey.com>
14023 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14025 2019-01-03 Tom Tromey <tom@tromey.com>
14027 * python/py-symtab.c (salpy_str): Update.
14028 (struct salpy_sal_object) <symtab>: Now a PyObject.
14029 (salpy_dealloc): Update.
14030 (del_objfile_sal): Use gdbpy_ref.
14032 2019-01-03 Tom Tromey <tom@tromey.com>
14034 * python/py-type.c (convert_field): Use new_reference. Return
14036 (make_fielditem): Return gdbpy_ref.
14037 (typy_fields): Update.
14038 (typy_getitem): Update.
14039 (field_name): Return gdbpy_ref. Use new_reference.
14040 (typy_iterator_iternext): Update.
14042 2019-01-03 Tom Tromey <tom@tromey.com>
14044 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14046 2019-01-03 Tom Tromey <tom@tromey.com>
14048 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14049 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14050 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14051 (pspy_set_frame_filters, pspy_set_frame_unwinders)
14052 (pspy_set_type_printers): Likewise.
14053 * python/py-function.c (fnpy_init): Use gdbpy_ref.
14054 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14055 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14056 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14057 (objfpy_set_type_printers): Likewise.
14059 2019-01-03 Tom Tromey <tom@tromey.com>
14061 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14062 (gdbpy_print_stack): Use gdbpy_err_fetch.
14063 * python/python-internal.h (class gdbpy_err_fetch): New class.
14064 (class gdbpy_enter) <m_error_type, m_error_value,
14065 m_error_traceback>: Remove.
14066 <m_error>: New member.
14067 (gdbpy_exception_to_string): Don't declare.
14068 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14069 * python/py-value.c (convert_value_from_python): Use
14071 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14072 gdbpy_exception_to_string.
14073 (gdbpy_handle_exception): Use gdbpy_err_fetch.
14074 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14077 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14079 * linux-nat.c (delete_lwp_cleanup): Delete.
14080 (struct lwp_deleter): New struct.
14081 (lwp_info_up): New typedef.
14082 (linux_nat_target::follow_fork): Delete cleanup, and make use of
14085 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14087 * linux-fork.c (class scoped_switch_fork_info): New class.
14088 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14090 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14092 * valops.c (find_overload_match): Remove use of null_cleanup, and
14093 calls to do_cleanups.
14095 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14097 * compile/compile-cplus-types.c
14098 (compile_cplus_instance::decl_name): Handle changes to
14100 * cp-support.c (cp_func_name): Update header comment, update
14102 * cp-support.h (cp_func_name): Update return type in declaration.
14103 * valops.c (find_overload_match): Move temp_func local to top
14104 level of function and change its type. Use temp_func to hold and
14105 delete temporary string obtained from cp_func_name.
14107 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14109 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14110 gdb::char_vector, remove cleanup, and update uses of `msg`.
14112 2019-01-03 Jim Wilson <jimw@sifive.com>
14114 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14116 2019-01-02 Tom Tromey <tom@tromey.com>
14118 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14119 (tdesc_parse_xml): Remove cleanups.
14120 * target-descriptions.h (make_cleanup_free_target_description):
14122 (target_desc_deleter): New struct.
14123 (target_desc_up): New typedef.
14124 * target-descriptions.c (target_desc_deleter::operator()): Rename
14125 from free_target_description.
14126 (make_cleanup_free_target_description): Remove.
14128 2019-01-02 Tom Tromey <tom@tromey.com>
14130 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
14131 constructor, destructor.
14132 (linespec_parser): Remove typedef.
14133 (~linespec_parser): Rename from linespec_parser_delete.
14134 (linespec_lex_to_end, linespec_complete_label)
14135 (linespec_complete): Update.
14136 (decode_line_full): Remove cleanups.
14137 (decode_line_1): Update.
14139 2019-01-02 Tom Tromey <tom@tromey.com>
14141 * python/python-internal.h (inferior_to_inferior_object): Change
14143 * python/py-exitedevent.c (create_exited_event_object): Update.
14144 * python/py-inferior.c (inferior_to_inferior_object): Return
14146 (python_new_inferior, python_inferior_deleted)
14147 (thread_to_thread_object, delete_thread_object)
14148 (build_inferior_list, gdbpy_selected_inferior): Update.
14149 * python/py-infthread.c (create_thread_object): Update. Also fail
14150 if inferior_to_inferior_object fails.
14152 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
14154 * inferior.h (class inferior) <displaced_step_state>: New field.
14155 * infrun.h (struct displaced_step_state): Move here from
14156 infrun.c. Initialize fields, add constructor.
14157 <inf>: Remove field.
14158 <reset>: New method.
14159 * infrun.c (struct displaced_step_inferior_state): Move to
14161 (displaced_step_inferior_states): Remove.
14162 (get_displaced_stepping_state): Adust.
14163 (displaced_step_in_progress_any_inferior): Adjust.
14164 (displaced_step_in_progress_thread): Adjust.
14165 (displaced_step_in_progress): Adjust.
14166 (add_displaced_stepping_state): Remove.
14167 (get_displaced_step_closure_by_addr): Adjust.
14168 (remove_displaced_stepping_state): Remove.
14169 (infrun_inferior_exit): Call displaced_step_state.reset.
14170 (use_displaced_stepping): Don't check for NULL.
14171 (displaced_step_prepare_throw): Call
14172 get_displaced_stepping_state.
14173 (displaced_step_fixup): Don't check for NULL.
14174 (prepare_for_detach): Don't check for NULL.
14176 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14178 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14179 in case of call that did not complete.
14181 2019-01-02 Andrey Utkin <autkin@undo.io>
14183 * symfile.c (find_separate_debug_file): Fix search of debug files for
14186 2019-01-02 Tom Tromey <tom@tromey.com>
14188 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14190 * python/py-frame.c (frapy_older): Remove cast.
14191 (frapy_newer): Likewise.
14192 * python/py-breakpoint.c (local_setattro): Remove cast.
14193 * python/py-arch.c (archpy_name): Remove local variable.
14194 * python/py-type.c (gdbpy_lookup_type): Remove cast.
14196 2019-01-02 Joel Brobecker <brobecker@adacore.com>
14198 * unittests/basic_string_view/element_access/char/empty.cc:
14199 Fix year range in copyright header.
14201 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
14203 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14205 <operator==>: Update with for removed field.
14207 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14208 <isa_features>: ...this.
14209 <abi_features>: New field.
14210 (riscv_isa_flen): Update comment.
14211 (riscv_abi_xlen): New declaration.
14212 (riscv_abi_flen): New declaration.
14213 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14215 (riscv_abi_xlen): New function.
14216 (riscv_isa_flen): Update to get answer from isa_features.
14217 (riscv_abi_flen): New function.
14218 (riscv_has_fp_abi): Update to get answer from abi_features.
14219 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14221 (riscv_call_info) <xlen, flen>: Update comment.
14222 (riscv_call_arg_struct): Remove invalid assertions
14223 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14225 (riscv_gdbarch_init): Gather isa features and abi features
14226 separately, ensure both match on the gdbarch when reusing an old
14227 gdbarch. Relax an error check to allow 32-bit abi float to run on
14228 a target with 64-bit float hardware.
14230 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14232 * source.c (search_command_helper): Stop reverse search
14233 when line 1 has been searched.
14235 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14237 * record-full.c (record_full_base_target::close): Rewrite
14238 record_full_core_buf_list free logic.
14240 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14242 * break-catch-syscall.c (print_one_catch_syscall): xfree
14245 2019-01-01 Joel Brobecker <brobecker@adacore.com>
14247 * top.c (print_gdb_version): Update Copyright year in version
14250 2019-01-01 Joel Brobecker <brobecker@adacore.com>
14252 Update copyright year range in all GDB files.
14254 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
14256 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14258 For older changes see ChangeLog-2018.
14264 version-control: never