gdb/ChangeLog

   1 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * symtab.c (struct demangled_name_entry): Add a constructor.
   4         (free_demangled_name_entry): New function to call the destructor
   5         for demangled_name_entry.
   6         (create_demangled_names_hash): Pass free_demangled_name_entry to
   7         htab_create_alloc.
   8         (symbol_set_names): Call placement new for demangled_name_entry.
   9         * utils.c: No longer include xxhash.h here, now that fast_hash
  10         is inlined in the header.
  11         * utils.h: Instead, include it here.
  12
  13 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  14
  15         * Makefile.in: Link with libxxhash.
  16         * config.in: Regenerate.
  17         * configure: Regenerate.
  18         * configure.ac: Search for libxxhash.
  19         * utils.c (fast_hash): Use xxhash if present.
  20
  21 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  22
  23         * utils.h (fast_hash): New function.
  24         * symtab.c (hash_demangled_name_entry): Call new function
  25         fast_hash.
  26
  27 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  28
  29         * symtab.c (struct demangled_name_entry): Change type of mangled
  30         to gdb::string_view. Also adds a constructor that takes the
  31         mangled name.
  32         (hash_demangled_name_entry): Update.
  33         (eq_demangled_name_entry): Update.
  34         (free_demangled_name_entry): New function to call the destructor
  35         now that this is not a POD anymore.
  36         (create_demangled_names_hash): Pass free_demangled_name_entry to
  37         htab_create_alloc.
  38         (symbol_set_names): Update.
  39
  40 2019-10-21  Ali Tamur  <tamu@google.com>
  41
  42         * dwarf2read.c (dir_index): Change type.
  43         (file_name_index): Likewise.
  44         (line_header::include_dir_at): Change comment and implementation on
  45         whether it is DWARF 5.
  46         (line_header::is_valid_file_index): New function.
  47         (line_header::file_name_at): Change comment and implementation on
  48         whether it is DWARF 5.
  49         (line_header::file_names): Change to private field renamed as
  50         m_file_names and introduce a new accessor method.
  51         (line_header::file_names_size): New method.
  52         (line_header::include_dirs): Change to private field and rename as
  53         m_include_dirs.
  54         (dw2_get_file_names_reader): Define local var at a smaller scope and
  55         reflect API change.
  56         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
  57         (process_structure_scope): Likewise.
  58         (line_header::add_include_dir): Change message and reflect renaming.
  59         (line_header::add_file_name): Likewise.
  60         (read_formatted_entries): Handle DW_FORM_data16.
  61         (dwarf_decode_line_header): Fix line header length calculation.
  62         (psymtab_include_file_name): Change comment and API.
  63         (lnp_state_machine::m_file): Update comment and reflect type change.
  64         (lnp_state_machine::record_line): Reflect type change.
  65         (dwarf_decode_lines): Reflect API change.
  66         (file_file_name): Likewise.
  67         (file_full_name): Likewise.
  68
  69 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  70
  71         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
  72
  73 2019-10-21  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
  76
  77 2019-10-21  Tom Tromey  <tom@tromey.com>
  78
  79         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
  80         NM_H.   Use AC_CONFIG_LINKS.
  81         * configure: Rebuild.
  82         * Makefile.in (NM_H): New variable.
  83         (generated_files): Add NM_H.  Remove gcore.
  84         (nm.h, stamp-nmh): New targets.
  85
  86 2019-10-20  Tom Tromey  <tom@tromey.com>
  87
  88         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
  89         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
  90         obsolete comment.
  91         (put_objfile_before): Now static.
  92
  93 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
  94
  95         * gdbsupport/common-utils.h (startswith): Change return type to
  96         bool.
  97
  98 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
  99
 100         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 101         * breakpoint.c (bp_locations_compare): Rename to...
 102         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 103         (update_global_location_list): Use std::sort instead of qsort.
 104         * buildsym.c (compare_line_numbers): Rename to...
 105         (lte_is_less_than): ...this, and change to std::sort semantics.
 106         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 107         instead of qsort.
 108         * disasm.c (compare_lines): Rename to...
 109         (line_is_less_than): ...this, and change to std::sort semantics.
 110         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 111         of qsort.
 112         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 113         (fde_is_less_than): ...this, and change to std::sort semantics.
 114         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 115         * mdebugread.c (compare_blocks):
 116         (block_is_less_than): ...this, and change to std::sort semantics.
 117         (sort_blocks): Call std::sort instead of qsort.
 118         * objfiles.c (qsort_cmp): Rename to...
 119         (sort_cmp): ...this, and change to std::sort semantics.
 120         (update_section_map): Call std::sort instead of qsort.
 121         * remote.c (compare_pnums): Remove.
 122         (map_regcache_remote_table): Call std::sort instead of qsort.
 123         * utils.c (compare_positive_ints): Remove.
 124         * utils.h (compare_positive_ints): Remove.
 125         * xcoffread.c (compare_lte): Remove.
 126         (arrange_linetable): Call std::sort instead of qsort.
 127
 128 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 129
 130         * symfile.c (init_entry_point_info): Fix typo.
 131         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 132
 133 2019-10-18  Tom de Vries  <tdevries@suse.de>
 134
 135         * aarch64-tdep.c: Fix typos in comments.
 136         * ada-lang.c: Same.
 137         * ada-tasks.c: Same.
 138         * alpha-tdep.c: Same.
 139         * alpha-tdep.h: Same.
 140         * amd64-nat.c: Same.
 141         * amd64-windows-tdep.c: Same.
 142         * arc-tdep.c: Same.
 143         * arc-tdep.h: Same.
 144         * arch-utils.c: Same.
 145         * arm-nbsd-tdep.c: Same.
 146         * arm-tdep.c: Same.
 147         * ax-gdb.c: Same.
 148         * blockframe.c: Same.
 149         * btrace.c: Same.
 150         * c-varobj.c: Same.
 151         * coff-pe-read.c: Same.
 152         * coffread.c: Same.
 153         * cris-tdep.c: Same.
 154         * darwin-nat.c: Same.
 155         * dbxread.c: Same.
 156         * dcache.c: Same.
 157         * disasm.c: Same.
 158         * dtrace-probe.c: Same.
 159         * dwarf-index-write.c: Same.
 160         * dwarf2-frame-tailcall.c: Same.
 161         * dwarf2-frame.c: Same.
 162         * dwarf2read.c: Same.
 163         * eval.c: Same.
 164         * exceptions.c: Same.
 165         * fbsd-tdep.c: Same.
 166         * findvar.c: Same.
 167         * frame.c: Same.
 168         * frv-tdep.c: Same.
 169         * gnu-v3-abi.c: Same.
 170         * go32-nat.c: Same.
 171         * h8300-tdep.c: Same.
 172         * hppa-tdep.c: Same.
 173         * i386-linux-tdep.c: Same.
 174         * i386-tdep.c: Same.
 175         * ia64-libunwind-tdep.c: Same.
 176         * ia64-tdep.c: Same.
 177         * infcmd.c: Same.
 178         * infrun.c: Same.
 179         * linespec.c: Same.
 180         * linux-nat.c: Same.
 181         * linux-thread-db.c: Same.
 182         * machoread.c: Same.
 183         * mdebugread.c: Same.
 184         * mep-tdep.c: Same.
 185         * mn10300-tdep.c: Same.
 186         * namespace.c: Same.
 187         * objfiles.c: Same.
 188         * opencl-lang.c: Same.
 189         * or1k-tdep.c: Same.
 190         * osabi.c: Same.
 191         * ppc-linux-nat.c: Same.
 192         * ppc-linux-tdep.c: Same.
 193         * ppc-sysv-tdep.c: Same.
 194         * printcmd.c: Same.
 195         * procfs.c: Same.
 196         * record-btrace.c: Same.
 197         * record-full.c: Same.
 198         * remote-fileio.c: Same.
 199         * remote.c: Same.
 200         * rs6000-tdep.c: Same.
 201         * s12z-tdep.c: Same.
 202         * score-tdep.c: Same.
 203         * ser-base.c: Same.
 204         * ser-go32.c: Same.
 205         * skip.c: Same.
 206         * sol-thread.c: Same.
 207         * solib-svr4.c: Same.
 208         * solib.c: Same.
 209         * source.c: Same.
 210         * sparc-nat.c: Same.
 211         * sparc-sol2-tdep.c: Same.
 212         * sparc-tdep.c: Same.
 213         * sparc64-tdep.c: Same.
 214         * stabsread.c: Same.
 215         * stack.c: Same.
 216         * symfile.c: Same.
 217         * symtab.c: Same.
 218         * target-descriptions.c: Same.
 219         * target-float.c: Same.
 220         * thread.c: Same.
 221         * utils.c: Same.
 222         * valops.c: Same.
 223         * valprint.c: Same.
 224         * value.c: Same.
 225         * varobj.c: Same.
 226         * windows-nat.c: Same.
 227         * xcoffread.c: Same.
 228         * xstormy16-tdep.c: Same.
 229         * xtensa-tdep.c: Same.
 230
 231 2019-10-17  Tom Tromey  <tromey@adacore.com>
 232
 233         * configure: Rebuild.
 234         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 235         in AC_CONFIG_FILES invocation.
 236         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 237         new-style config.status invocation.
 238
 239 2019-10-17  Tom de Vries  <tdevries@suse.de>
 240
 241         * arm-nbsd-nat.c: Fix typos in comments.
 242         * arm-tdep.c: Same.
 243         * darwin-nat-info.c: Same.
 244         * dwarf2read.c: Same.
 245         * elfread.c: Same.
 246         * event-top.c: Same.
 247         * findvar.c: Same.
 248         * gdbtypes.c: Same.
 249         * hppa-tdep.c: Same.
 250         * i386-tdep.c: Same.
 251         * jit.c: Same.
 252         * main.c: Same.
 253         * mdebugread.c: Same.
 254         * moxie-tdep.c: Same.
 255         * nto-procfs.c: Same.
 256         * osabi.c: Same.
 257         * ppc-linux-tdep.c: Same.
 258         * remote.c: Same.
 259         * riscv-tdep.c: Same.
 260         * s390-tdep.c: Same.
 261         * sh-tdep.c: Same.
 262         * sparc-linux-tdep.c: Same.
 263         * sparc-nat.c: Same.
 264         * stack.c: Same.
 265         * target-descriptions.c: Same.
 266         * top.c: Same.
 267         * varobj.c: Same.
 268
 269 2019-10-16  Tom Tromey  <tom@tromey.com>
 270
 271         * objfiles.h (struct objfile) <original_name>: Now const.
 272
 273 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 274
 275         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 276         pass on to sigsetjmp's second argument.
 277         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 278
 279 2019-10-16  Keith Seitz  <keiths@redhat.com>
 280
 281         PR gdb/23567
 282         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 283         sections whose size is greater than the file size.
 284
 285 2019-10-16  Jim Wilson  <jimw@sifive.com>
 286
 287         * riscv-tdep.c (riscv_gcc_target_options): New.
 288         (riscv_gnu_triplet_regexp): New.
 289         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 290         set_gdbarch_gnu_triplet_regexp.
 291
 292 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 293
 294         * Makefile.in: Add xml-builtin.h.
 295         * features/feature_to_c.sh: Add an include for xml-builtin.h
 296         to ensure that the compiler checks that the types match.
 297         * xml-builtin.h: New file.
 298         * xml-support.c (fetch_xml_builtin): Add missing const.
 299         * xml-support.h: Remove declaration of xml_builtins.
 300
 301 2019-10-16  Tom de Vries  <tdevries@suse.de>
 302
 303         PR tdep/25096
 304         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 305         (amd64_classify_aggregate): ... here.
 306         (amd64_classify_aggregate_field): Handled fiels of nested structs
 307         recursively.
 308
 309 2019-10-16  Tom de Vries  <tdevries@suse.de>
 310
 311         PR tdep/24104
 312         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 313         that handles 'theclass'.
 314
 315 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 316
 317         * linespec.c (decode_digits_ordinary): Update comment.
 318         * make-target-delegates: No longer need to handle VEC case.
 319         * memrange.c (normalize_mem_ranges): Update comment.
 320         * namespace.c (add_using_directive): Update comment.
 321         * objc-lang.c (uniquify_strings): Update comment.
 322         * ppc-linux-nat.c (struct thread_points): Update comment.
 323         * probe.h (find_probes_in_objfile): Update comment.
 324         * target.h (enum flash_preserve_mode): Update comment.
 325         * varobj.c (varobj_restrict_range): Update comment.
 326         * varobj.h (varobj_list_children): Update comment.
 327
 328 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 329
 330         * Makefile.in: Remove references to vec.h and vec.c.
 331         * aarch64-tdep.c: No longer include vec.h.
 332         * ada-lang.c: Likewise.
 333         * ada-lang.h: Likewise.
 334         * arm-tdep.c: Likewise.
 335         * ax.h: Likewise.
 336         * breakpoint.h: Likewise.
 337         * charset.c: Likewise.
 338         * cp-support.h: Likewise.
 339         * dtrace-probe.c: Likewise.
 340         * dwarf2read.c: Likewise.
 341         * extension.h: Likewise.
 342         * gdb_bfd.c: Likewise.
 343         * gdbsupport/gdb_vecs.h: Likewise.
 344         * gdbsupport/vec.c: Remove.
 345         * gdbsupport/vec.h: Remove.
 346         * gdbthread.h: Likewise.
 347         * guile/scm-type.c: Likewise.
 348         * inline-frame.c: Likewise.
 349         * machoread.c: Likewise.
 350         * memattr.c: Likewise.
 351         * memrange.h: Likewise.
 352         * namespace.h: Likewise.
 353         * nat/linux-btrace.h: Likewise.
 354         * osdata.c: Likewise.
 355         * parser-defs.h: Likewise.
 356         * progspace.h: Likewise.
 357         * python/py-type.c: Likewise.
 358         * record-btrace.c: Likewise.
 359         * rust-exp.y: Likewise.
 360         * solib-target.c: Likewise.
 361         * stap-probe.c: Likewise.
 362         * target-descriptions.c: Likewise.
 363         * target-memory.c: Likewise.
 364         * target.h: Likewise.
 365         * varobj.c: Likewise.
 366         * varobj.h: Likewise.
 367         * xml-support.h: Likewise.
 368
 369 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 372         Update for new std::vector based implementation.
 373         (process_psymtab_comp_unit_reader): Likewise.
 374         (scan_partial_symbols): Likewise.
 375         (recursively_compute_inclusions): Likewise.
 376         (compute_compunit_symtab_includes): Likewise.
 377         (process_imported_unit_die): Likewise.
 378         (queue_and_load_dwo_tu): Likewise.
 379         (follow_die_sig_1): Likewise.
 380         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 381         (typedef dwarf2_per_cu_ptr): Remove.
 382         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 383         function.
 384         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 385         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 386         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 387         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 388         std::vector.
 389
 390 2019-10-15  Tom Tromey  <tromey@adacore.com>
 391
 392         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 393         TID.
 394
 395 2019-10-15  Tom Tromey  <tromey@adacore.com>
 396
 397         * windows-nat.c (windows_nat_target::fetch_registers)
 398         (windows_nat_target::store_registers): Rename "pid" to "tid".
 399
 400 2019-10-15  Tom Tromey  <tromey@adacore.com>
 401
 402         * gdbarch.h, gdbarch.c: Rebuild.
 403         * gdbarch.sh (gcc_target_options): Change return type to
 404         std::string.
 405         * compile/compile.c (get_args): Update.
 406         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 407         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 408         std::string.
 409         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 410         std::string.
 411         * arch-utils.c (default_gcc_target_options): Return std::string.
 412         * arch-utils.h (default_gcc_target_options): Return std::string.
 413         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 414
 415 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 416
 417         * breakpoint.c (breakpoint_chain): Make static.
 418         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 419         of accessing breakpoint_chain.
 420
 421 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 422
 423         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 424         to a gdb::function_view and return value to bool.
 425         * breakpoint.h (iterate_over_breakpoints): Likewise.
 426         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 427         (pop_dummy_frame): Update.
 428         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 429         (gdbscm_breakpoints): Update.
 430         * python/py-breakpoint.c (build_bp_list): Update.
 431         (gdbpy_breakpoints): Update.
 432         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 433         Update.
 434         (bpfinishpy_handle_stop): Update.
 435         (bpfinishpy_handle_exit): Update.
 436         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 437         (svr4_update_solib_event_breakpoints): Update.
 438
 439 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 440
 441         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 442         when unwrapping single-field structs.
 443
 444 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 445
 446         * dwarf2read.c: Remove includes.
 447
 448 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 449
 450         * ui-out.c (ui_out::call_do_message): Silence
 451         -Wformat-nonliteral warning.
 452
 453 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 454
 455         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 456         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 457         include: readline/tilde.h.
 458
 459 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 460
 461         * remote.c (remote_target::get_trace_status): Remove declaration of
 462         trace_regblock_size.
 463
 464 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 465
 466         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 467         (show_user): Remove declaration of cmdlist.
 468         * cli/cli-cmds.h (max_user_call_depth): Declare.
 469         * cli/cli-script.c (execute_user_command): Remove declaration
 470         of max_user_call_depth.
 471
 472 2019-10-11  Jim Wilson  <jimw@sifive.com>
 473
 474         * gdbsupport/print-utils.h (pulongest): Fix comment.
 475         (plongest): Likewise.
 476         (phex): Add missing comment, mention leading zeros.
 477         (phex_nz): Add mention of no leading zeros to comment.
 478
 479         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 480         plongest instead of unsigned long long cast.
 481
 482 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 483
 484         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 485         for external_editor_command and gdbtk_test.
 486
 487 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 488
 489         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 490         * varobj.c (varobjdebug): Move comment to...
 491         * varobj.h (varobjdebug): ...here, and declare.
 492
 493 2019-10-09  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 496         erase_data_content.
 497
 498 2019-10-09  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 501         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 502         * tui/tui-command.c (tui_cmd_window::resize)
 503         (tui_refresh_cmd_win): Update.
 504         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 505         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 506         * tui/tui-data.c (~tui_gen_win_info): Remove.
 507         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 508         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 509         (tui_redisplay_readline, tui_mld_flush)
 510         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 511         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 512         (tui_data_window::erase_data_content)
 513         (tui_data_item_window::rerender)
 514         (tui_data_item_window::refresh_window): Update.
 515         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 516         (box_win, tui_gen_win_info::make_window)
 517         (tui_gen_win_info::make_visible): Update.
 518         (tui_delete_win): Remove.
 519         * tui/tui-winsource.c
 520         (tui_source_window_base::do_erase_source_content): Update.
 521         (tui_show_source_line, tui_source_window_base::update_tab_width)
 522         (tui_source_window_base::update_exec_info): Update.
 523         * tui/tui-data.h (struct curses_deleter): New.
 524         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 525         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 526
 527 2019-10-09  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 530
 531 2019-10-09  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 534         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 535
 536 2019-10-09  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 539         window height directly.
 540         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 541         declare.
 542         * tui/tui-layout.c (tui_default_win_height): Remove.
 543         (tui_default_win_viewport_height): Remove.
 544
 545 2019-10-09  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui.h: Remove comments.
 548
 549 2019-10-09  Tom de Vries  <tdevries@suse.de>
 550
 551         * python/lib/gdb/printer/bound_registers.py: Use
 552         '^builtin_type_bound128' as regexp argument for
 553         add_builtin_pretty_printer.
 554
 555 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 556
 557         * guile/guile.c (guile_extension_script_ops): Remove forward
 558         declaration and mark as static.
 559         (guile_script_ops): Likewise.
 560         (extension_language_guile): Move further down in the file so
 561         it can reference the definitions for guile_{extension_,}script_ops.
 562
 563 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 564
 565         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 566         except SORTL, DFLTCC, and KDSA.
 567
 568 2019-10-08  Tom Tromey  <tromey@adacore.com>
 569
 570         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 571         (struct safe_symbol_file_add_args): Remove.
 572
 573 2019-10-08  Tom Tromey  <tromey@adacore.com>
 574
 575         * windows-nat.c: Don't include buildsym-legacy.h.
 576
 577 2019-10-08  Tom Tromey  <tromey@adacore.com>
 578
 579         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 580
 581 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 582
 583         * gdbtypes.c (overload_debug): Move comment to header.
 584         * gdbtypes.h (overload_debug): Declare.
 585         * valops.c: Remove declaration of overload_debug, instead
 586         include gdbtypes.h.
 587
 588 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 589
 590         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 591         through _().
 592         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 593         move comment...
 594         * language.h (lang_frame_mismatch_warn): ... here. Also add
 595         declaration.
 596         * top.c (lang_frame_mismatch_warn): Remove declaration.
 597         (check_frame_language_change): Pass lang_frame_mismatch_warn
 598         through _().
 599
 600 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 601
 602         * c-lang.h (vtbl_ptr_name): Declare.
 603         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 604         it from the header.
 605         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 606
 607 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 608
 609         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 610         gdb_static_assert.
 611
 612 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 613
 614         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 615         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 616         * ctfread.c: New file.
 617         * ctfread.h: New file.
 618         * elfread.c: Include ctfread.h.
 619         (struct elfinfo text_p): New member ctfsect.
 620         (elf_locate_sections): Mark CTF section.
 621         (elf_symfile_read): Call elfctf_build_psymtabs.
 622         * Makefile.in (LIBCTF): Add.
 623         (CLIBS): Use it.
 624         (CDEPS): Likewise.
 625         (DIST): Add ctfread.c.
 626
 627 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 628
 629         * ctfread.c (struct nextfield): Renamed to ...
 630         (struct ctf_nextfield): ... this.
 631         (struct field_info): Renamed to ...
 632         (strut ctf_field_info): ... this.
 633         (attach_fields_to_type): Update for renamed structures.
 634         (ctf_add_member_cb): Likewise.
 635         (ctf_add_enum_member_cb): Likewise.
 636         (process_struct_members): Likewise.
 637         (process_enum_type): Likewise.
 638
 639 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 640
 641         * tracectf.h: Rename, was ctf.h.
 642         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 643         * tracefile.c: Likewise.
 644         * tracepoint.c: Remove unused include ctf.h.
 645         * mi/mi-main.c: Likewise.
 646         * Makefile.in Replace ctf.c with tracectf.c.
 647
 648 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 649
 650         * version.in: Change version number to "9.0.50.DATE-git".
 651
 652 2019-10-03  Tom Tromey  <tom@tromey.com>
 653
 654         PR rust/24976:
 655         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 656
 657 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 658
 659         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 660         cp_search_name_hash.
 661         * NEWS: Add entry about nested function support.
 662
 663 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 664             Andrew Burgess  <andrew.burgess@embecosm.com>
 665
 666         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 667         for nested static variables when searchin VAR_DOMAIN.
 668         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 669         global scope, update comment.
 670         (add_partial_subprogram): Call add_partial_subprogram recursively
 671         for nested subroutines when processinng Fortran.
 672         (load_partial_dies): Process the child entities of a subprogram
 673         when processing Fortran.
 674         (partial_die_parent_scope): Handle building scope
 675         for Fortran nested functions.
 676         (process_die): Record that nested functions have a scope.
 677         (new_symbol): Always record Fortran subprograms on the global
 678         symbol list.
 679         (determine_prefix): How to build the prefix for Fortran
 680         subprograms.
 681
 682 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 685         have just sent the thread a SIGSTOP and are waiting for it to
 686         arrive.
 687
 688 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 689
 690         * btrace.c (btrace_add_pc): Remove whitespace before the template
 691         parameter in 'std::vector <...>'.
 692         (parse_xml_btrace_block): Likewise.
 693         (btrace_maint_decode_pt): Likewise.
 694         (btrace_maint_update_packets): Likewise.
 695         (btrace_maint_print_packets): Likewise.
 696         * btrace.h (struct btrace_maint_info): Likewise.
 697         * dwarf2read.c (struct type_unit_group): Likewise.
 698         (build_type_psymtabs_reader): Likewise.
 699         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 700         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 701         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 702
 703 2019-10-03  Tom de Vries  <tdevries@suse.de>
 704
 705         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 706         the first line of the help text for set/show style metadata.
 707
 708 2019-10-02  Tom Tromey  <tromey@adacore.com>
 709
 710         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 711         * gdbsupport/common-inferior.c: New file.
 712         * infcmd.c (startup_with_shell): Don't define.
 713         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 714         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 715         * inferior.h (startup_with_shell): Don't declare.
 716
 717 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 718
 719         * gdbsupport/gdb_assert.h: Include errors.h.
 720         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 721
 722 2019-10-02  Tom Tromey  <tromey@adacore.com>
 723
 724         * NEWS: Add $_ada_exception entry.
 725         * ada-lang.c (struct ada_catchpoint): Add constructor.
 726         <m_kind>: New member.
 727         (allocate_location_exception, re_set_exception): Remove
 728         "ex" parameter.
 729         (should_stop_exception): Compute $_ada_exception.
 730         (check_status_exception, print_it_exception)
 731         (print_one_exception, print_mention_exception): Remove
 732         "ex" parameter.
 733         (allocate_location_catch_exception, re_set_catch_exception)
 734         (check_status_exception, print_it_catch_exception)
 735         (print_one_catch_exception, print_mention_catch_exception)
 736         (print_recreate_catch_exception)
 737         (allocate_location_catch_exception_unhandled)
 738         (re_set_catch_exception_unhandled)
 739         (check_status_exception, print_it_catch_exception_unhandled)
 740         (print_one_catch_exception_unhandled)
 741         (print_mention_catch_exception_unhandled)
 742         (print_recreate_catch_exception_unhandled)
 743         (allocate_location_catch_assert, re_set_catch_assert)
 744         (check_status_assert, print_it_catch_assert)
 745         (print_one_catch_assert, print_mention_catch_assert)
 746         (print_recreate_catch_assert)
 747         (allocate_location_catch_handlers, re_set_catch_handlers)
 748         (check_status_handlers, print_it_catch_handlers)
 749         (print_one_catch_handlers, print_mention_catch_handlers)
 750         (print_recreate_catch_handlers): Remove.
 751         (create_ada_exception_catchpoint): Update.
 752         (initialize_ada_catchpoint_ops): Update.
 753
 754 2019-10-02  Tom Tromey  <tromey@adacore.com>
 755
 756         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 757         (create_excep_cond_exprs): Simplify exception string computation.
 758         (ada_exception_catchpoint_cond_string): Likewise.
 759
 760 2019-10-02  Tom Tromey  <tromey@adacore.com>
 761
 762         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 763         * ada-lang.c (lesseq_defined_than): Handle
 764         LOC_STATIC.
 765         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 766         parameter.
 767         (dwarf2_has_info): Likewise.
 768         (new_symbol): Set maybe_copied on symbol when
 769         appropriate.
 770         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 771         parameter.
 772         <can_copy>: New member.
 773         * elfread.c (record_minimal_symbol): Set maybe_copied
 774         on symbol when appropriate.
 775         (elf_symfile_read): Update call to dwarf2_has_info.
 776         * minsyms.c (lookup_minimal_symbol_linkage): New
 777         function.
 778         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 779         * symtab.c (get_symbol_address, get_msymbol_address):
 780         New functions.
 781         * symtab.h (get_symbol_address, get_msymbol_address):
 782         Declare.
 783         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 784         maybe_copied.
 785         (struct symbol, struct minimal_symbol) <maybe_copied>:
 786         New member.
 787
 788 2019-10-02  Tom Tromey  <tromey@adacore.com>
 789
 790         * source.c (struct current_source_location): New.
 791         (current_source_key): New global.
 792         (current_source_symtab, current_source_line)
 793         (current_source_pspace): Remove.
 794         (get_source_location): New function.
 795         (get_current_source_symtab_and_line)
 796         (set_default_source_symtab_and_line)
 797         (set_current_source_symtab_and_line)
 798         (clear_current_source_symtab_and_line, select_source_symtab)
 799         (info_source_command, print_source_lines_base)
 800         (info_line_command, search_command_helper, _initialize_source):
 801         Update.
 802
 803 2019-10-02  Tom Tromey  <tromey@adacore.com>
 804
 805         * source.c (select_source_symtab): Don't call
 806         decode_line_with_current_source.
 807
 808 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * symtab.c (lookup_global_symbol): Search global block.
 811
 812 2019-10-02  Tom Tromey  <tromey@adacore.com>
 813
 814         * coffread.c (process_coff_symbol): Update.
 815         * dwarf2read.c (var_decode_location, new_symbol): Update.
 816         * mdebugread.c (parse_symbol): Update.
 817         * objfiles.c (relocate_one_symbol): Update.
 818         * stabsread.c (define_symbol, fix_common_block)
 819         (scan_file_globals): Update.
 820         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 821         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 822         * xcoffread.c (process_xcoff_symbol): Update.
 823
 824 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 825
 826         * MAINTAINERS: Update my email address.
 827
 828 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 831         std::vector.
 832         (build_type_psymtabs_reader): Update for std::vector.
 833         (build_type_psymtab_dependencies): Likewise.
 834         * dwarf2read.h: Remove use of DEF_VEC_P.
 835         (typedef sig_type_ptr): Delete.
 836
 837 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 840         to std::vector.
 841         (btrace_maint_decode_pt): Likewise, and move allocation of the
 842         vector outside of the loop.
 843         (btrace_maint_update_packets): Update to handle change from VEC to
 844         std::vector.
 845         (btrace_maint_print_packets): Likewise.
 846         (maint_info_btrace_cmd): Likewise.
 847         * btrace.h: Remove use of DEF_VEC_O.
 848         (typedef btrace_pt_packet_s): Delete.
 849         (struct btrace_maint_info) <packets>: Change fromm VEC to
 850         std::vector.
 851         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 852
 853 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 856         make accesses into the vector constant references.
 857         (btrace_add_pc): Update for std::vector.
 858         (btrace_stitch_bts): Likewise.
 859         (parse_xml_btrace_block): Likewise.
 860         (btrace_maint_update_packets): Likewise.
 861         (btrace_maint_print_packets): Likewise.
 862         (maint_info_btrace_cmd): Likewise.
 863         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 864         std::vector.
 865         (btrace_data::empty): Likewise.
 866         (btrace_data_append): Likewise.
 867         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 868         (typedef btrace_block_s): Delete.
 869         (struct btrace_block): Add constructor.
 870         (struct btrace_data_bts) <blocks>: Change to std::vector.
 871         * nat/linux-btrace.c (perf_event_read_bts): Update for
 872         std::vector.
 873         (linux_read_bts): Likewise.
 874
 875 2019-10-01  Tom Tromey  <tom@tromey.com>
 876
 877         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 878
 879 2019-10-01  Tom Tromey  <tom@tromey.com>
 880
 881         * stack.c (print_frame, info_frame_command_core): Use
 882         styled_string.
 883         * linux-thread-db.c (try_thread_db_load_1)
 884         (try_thread_db_load_from_pdir_1): Use styled_string.
 885         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 886         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 887         (maybe_print_unsupported_script_warning)
 888         (maybe_print_script_not_found_warning): Use styled_string.
 889         * ada-lang.c (user_select_syms): Use styled_string.
 890
 891 2019-10-01  Tom Tromey  <tom@tromey.com>
 892
 893         * p-lang.c (pascal_printstr): Use metadata style.
 894         * value.c (show_convenience): Use metadata style.
 895         * valprint.c (valprint_check_validity, val_print_optimized_out)
 896         (val_print_not_saved, val_print_unavailable)
 897         (val_print_invalid_address, generic_val_print, val_print)
 898         (value_check_printable, val_print_array_elements): Use metadata
 899         style.
 900         * ui-out.h (class ui_out) <field_fmt>: New overload.
 901         <do_field_fmt>: Add style parameter.
 902         * ui-out.c (ui_out::field_fmt): New overload.
 903         * typeprint.c (type_print_unknown_return_type)
 904         (val_print_not_allocated, val_print_not_associated): Use metadata
 905         style.
 906         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 907         parameter.
 908         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 909         * tracepoint.c (tvariables_info_1): Use metadata style.
 910         * stack.c (print_frame_arg, print_frame_info, print_frame)
 911         (info_frame_command_core): Use metadata style.
 912         * skip.c (info_skip_command): Use metadata style.
 913         * rust-lang.c (rust_print_enum): Use metadata style.
 914         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 915         metadata style.
 916         * python/py-framefilter.c (py_print_single_arg): Use metadata
 917         style.
 918         * printcmd.c (do_one_display, print_variable_and_value): Use
 919         metadata style.
 920         * p-valprint.c (pascal_val_print)
 921         (pascal_object_print_value_fields): Use metadata style.
 922         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 923         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 924         parameter.
 925         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 926         * m2-valprint.c (m2_print_long_set): Use metadata style.
 927         * m2-typeprint.c (m2_print_type): Use metadata style.
 928         * infcmd.c (print_return_value_1): Use metadata style.
 929         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 930         * f-valprint.c (info_common_command_for_block): Use metadata
 931         style.
 932         * f-typeprint.c (f_type_print_base): Use metadata style.
 933         * expprint.c (print_subexp_standard): Use metadata style.
 934         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 935         * cli/cli-style.h (class cli_style_option): Add constructor.
 936         (metadata_style): Declare.
 937         * cli/cli-style.c (metadata_style): New global.
 938         (_initialize_cli_style): Register metadata style.
 939         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 940         parameter.
 941         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 942         * c-typeprint.c (c_type_print_base_struct_union)
 943         (c_type_print_base_1): Use metadata style.
 944         * breakpoint.c (watchpoint_value_print)
 945         (print_one_breakpoint_location): Use metadata style.
 946         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 947         style.
 948         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 949         style.
 950         * ada-valprint.c (val_print_packed_array_elements, printstr)
 951         (print_field_values, ada_val_print_ref, ada_val_print): Use
 952         metadata style.
 953         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 954         style.
 955         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 956         style.
 957         * ada-lang.c (user_select_syms): Use metadata style.
 958
 959 2019-10-01  Tom Tromey  <tom@tromey.com>
 960
 961         * cli/cli-cmds.c (pwd_command): Style output.
 962
 963 2019-10-01  Pedro Alves  <palves@redhat.com>
 964             Tom Tromey  <tom@tromey.com>
 965
 966         * symtab.c (print_symbol_info): Use %ps.
 967         (print_msymbol_info): Use %ps.
 968         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 969         * printcmd.c (print_variable_and_value): Use %ps.
 970         * macrocmd.c (show_pp_source_pos): Use %ps.
 971         * infrun.c (print_exited_reason): Use ui_out::message.
 972         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 973         (describe_other_breakpoints): Use ui_out::message and new
 974         formats.
 975         (say_where): Use new formats.
 976         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 977         and new formats.
 978
 979 2019-10-01  Pedro Alves  <palves@redhat.com>
 980             Tom Tromey  <tom@tromey.com>
 981
 982         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 983         (test_gdb_formats): New function.
 984         (run_tests): Call it.
 985         (test_format_specifier): Update.
 986         * utils.h (fputs_filtered): Update comment.
 987         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 988         (fputs_styled_unfiltered): Declare.
 989         * utils.c (fputs_styled_unfiltered): New function.
 990         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 991         (vfprintf_filtered): Update.
 992         (vfprintf_unfiltered, vprintf_filtered): Update.
 993         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 994         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 995         disallow_ui_out_field>: New constants.
 996         (enum class field_kind): New.
 997         (struct base_field_s, struct signed_field_s): New.
 998         (signed_field): New function.
 999         (struct string_field_s): New.
1000         (string_field): New function.
1001         (struct styled_string_s): New.
1002         (styled_string): New function.
1003         (class ui_out) <message>: Add comment.
1004         <vmessage, call_do_message>: New methods.
1005         <do_message>: Add style parameter.
1006         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1007         methods.
1008         (ui_out::message): Rewrite.
1009         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1010         parameter.
1011         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1012         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1013         gdb_extensions parameter.
1014         (class format_piece): Add parameter to constructor.
1015         (n_int_args): New field.
1016         * gdbsupport/format.c (format_pieces::format_pieces): Add
1017         gdb_extensions parameter.  Handle '*'.
1018         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1019         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1020         vfprintf_styled_no_gdbfmt.
1021         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1022         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1023         unfiltered output.
1024         * ui-style.h (struct ui_file_style) <ptr>: New method.
1025
1026 2019-10-01  Tom Tromey  <tom@tromey.com>
1027
1028         * unittests/format_pieces-selftests.c: Update.  Add final format.
1029         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1030         empty literal pieces.
1031
1032 2019-10-01  Tom Tromey  <tom@tromey.com>
1033
1034         * ui-out.h (enum class ui_out_style_kind): Remove.
1035         (class ui_out) <field_string, field_stsream, do_field_string>:
1036         Change type of "style".
1037         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1038         (ui_out::field_string): Update.
1039         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1040         of "style".
1041         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1042         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1043         * stack.c (print_frame_arg, print_frame_info, print_frame):
1044         Update.
1045         * source.c (print_source_lines_base): Update.
1046         * solib.c (info_sharedlibrary_command): Update.
1047         * skip.c (info_skip_command): Update.
1048         * record-btrace.c (btrace_call_history_src_line)
1049         (btrace_call_history): Update.
1050         * python/py-framefilter.c (py_print_frame): Update.
1051         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1052         "style".
1053         * mi/mi-out.c (mi_ui_out::do_table_header)
1054         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1055         (mi_ui_out::do_field_string): Update.
1056         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1057         Update.
1058         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1059         "style".
1060         * cli-out.c (cli_ui_out::do_table_header)
1061         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1062         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1063         (cli_ui_out::do_field_fmt): Update.
1064         * breakpoint.c (print_breakpoint_location): Update.
1065         (update_static_tracepoint): Update.
1066
1067 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1068
1069         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1070         conversion of gdb_datadir.
1071         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1072         remove not needed c_str ().
1073
1074 2019-09-30  Ali Tamur <tamur@google.com>
1075
1076         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1077         (dwarf2_string_attr): Likewise.
1078
1079 2019-09-30  Ali Tamur <tamur@google.com>
1080
1081         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1082         (process_full_type_unit): Likewise.
1083         (dump_die_shallow): Likewise.
1084         (cu_debug_loc_section): Likewise.
1085
1086 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1087
1088         * minsyms.c (compare_minimal_symbols): Rename to...
1089         (minimal_symbol_is_less_than): ...this, and adjust to STL
1090         conventions (return bool, take arguments as references)
1091         (minimal_symbol_reader::install): Call std::sort instead
1092         of qsort.
1093
1094 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1095
1096         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1097         hash and why.
1098         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1099         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1100
1101 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1102
1103         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1104         * psympriv.h (add_psymbol_to_list): Move comment here and update
1105         it.
1106
1107 2019-09-29  Tom de Vries  <tdevries@suse.de>
1108
1109         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1110         Use $tmpdir/$(basename "$output_file").dwz instead of
1111         "${output_file}.dwz".
1112
1113 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1114
1115         PR gdb/25045
1116         * hppa-linux-nat.c: Include gdbarch.h.
1117
1118 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1119
1120         * blockframe.c (find_pc_partial_function): Change return type to bool.
1121         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1122         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1123         (stub_gnu_ifunc_resolve_name): Likewise.
1124         * symtab.c (compare_filenames_for_search): Likewise.
1125         (compare_glob_filenames_for_search): Likewise.
1126         (matching_obj_sections): Likewise.
1127         (symbol_matches_domain): Likewise.
1128         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1129         (find_line_pc): Change return type to bool.
1130         (find_line_pc_range): Likewise.
1131         (producer_is_realview): Likewise.
1132         * symtab.h (symbol_matches_domain): Likewise.
1133         (find_pc_partial_function): Likewise.
1134         (find_pc_line_pc_range): Likewise.
1135         (in_gnu_ifunc_stub): Likewise.
1136         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1137         (find_line_pc): Likewise.
1138         (find_line_pc_range): Likewise.
1139         (matching_obj_sections): Likewise.
1140         (find_line_symtab): Change out parameter to bool.
1141         (producer_is_realview): Change return type to bool.
1142         (compare_filenames_for_search): Likewise.
1143         (compare_glob_filenames_for_search): Likewise.
1144
1145 2019-09-26  Tom Tromey  <tom@tromey.com>
1146
1147         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1148         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1149         * gdb_usleep.h: Remove.
1150         * gdb_usleep.c: Remove.
1151         * utils.c: Don't include gdb_usleep.h.
1152
1153 2019-09-26  Tom Tromey  <tromey@adacore.com>
1154
1155         * python/py-type.c (type_to_type_object): Call check_typedef
1156         for stub types.
1157
1158 2019-09-26  Tom Tromey  <tom@tromey.com>
1159
1160         * utils.h (initialize_utils): Don't declare.
1161         * top.c (gdb_init): Don't call initialize_utils.
1162         * utils.c (initialize_utils): Remove.  Move contents...
1163         (_initialize_utils): ... here.
1164
1165 2019-09-25  Tom Tromey  <tom@tromey.com>
1166
1167         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1168         * utils.h (make_hex_string): Don't declare.
1169         * utils.c (make_hex_string): Remove.
1170
1171 2019-09-24  Tom de Vries  <tdevries@suse.de>
1172
1173         PR gdb/23815
1174         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1175         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1176
1177 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1178
1179         * NEWS: Mention new simulator port for PRU.
1180
1181 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1182
1183         * ada-exp.y (write_object_remaining): Update.
1184         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1185         and eliminate the static buffer.
1186         (ada_decode_symbol): Update.
1187         (ada_la_decode): Update.
1188         (ada_sniff_from_mangled_name): Update.
1189         (is_valid_name_for_wild_match): Update.
1190         (ada_lookup_name_info::matches): Update and simplify.
1191         (name_matches_regex): Update.
1192         (ada_add_global_exceptions): Update.
1193         * ada-lang.h (ada_decode): Update signature.
1194         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1195         * dwarf-index-write.c (debug_names::insert): Update.
1196
1197 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1198
1199         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1200         formatting.
1201
1202 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1203
1204         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1205         Change "nonzero" to "true" in documentation.
1206
1207 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1208
1209         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1210         (_initialize_darwin_solib): Don't set
1211         darwin_so_ops.lookup_lib_global_symbol.
1212         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1213         set_gdbarch_iterate_over_objfiles_in_search_order.
1214         (elf_lookup_lib_symbol): Rename to...
1215         (svr4_iterate_over_objfiles_in_search_order): this, and update
1216         to iterate semantics.
1217         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1218         * solib.c (solib_global_lookup): Remove.
1219         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1220         (solib_global_lookup): Remove.
1221         * symtab.c (lookup_global_or_static_symbol): Remove call to
1222         solib_global_lookup.
1223
1224 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1225
1226         * NEWS: Move entries about default MI version now being
1227         version 3, and about the GDB/MI fix for multi-location
1228         breakpoints to the "since GDB 8.3" section.
1229
1230 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1231
1232         GDB 8.3.1 released.
1233
1234 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1235
1236         * NEWS: Mention that Cell/B.E. debugging support was removed.
1237         * MAINTAINERS: Remove spu target.
1238
1239         * config/djgpp/fnchange.lst: Remove entries for removed files.
1240
1241         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1242         spu-multiarch.o, and spu-tdep.o.
1243         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1244         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1245         spu-multiarch.c, and spu-tdep.c.
1246         * spu-linux-nat.c: Remove file.
1247         * spu-multiarch.c: Remove file.
1248         * spu-tdep.c: Remove file.
1249         * spu-tdep.h: Remove file.
1250         * solib-spu.c: Remove file.
1251         * solib-spu.h: Remove file.
1252
1253         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1254         * configure.nat (spu-linux): Remove.
1255         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1256         solib-multiarch.o from gdb_target_obs.
1257         (spu*-*-*): Remove.
1258
1259         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1260         feature flag.
1261         (ppc_linux_no_features): Update.
1262         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1263         Cell/B.E. support.
1264         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1265         (tdesc_powerpc_cell64l): Likewise.
1266         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1267         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1268         Cell/B.E. support.
1269         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1270         Do not include "features/rs6000/powerpc-cell32l.c" or
1271         "features/rs6000/powerpc-cell64l.c".
1272         (ppc_linux_spu_section): Remove.
1273         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1274         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1275         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1276         (ppc_linux_spe_context_lookup): Remove.
1277         (ppc_linux_spe_context_inferior_created): Remove.
1278         (ppc_linux_spe_context_solib_loaded): Remove.
1279         (ppc_linux_spe_context_solib_unloaded): Remove.
1280         (ppc_linux_spe_context): Remove.
1281         (struct ppu2spu_cache): Remove.
1282         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1283         (struct ppu2spu_data): Remove.
1284         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1285         ppu2spu_unwind): Remove.
1286         (ppc_linux_init_abi): Remove Cell/B.E. support.
1287         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1288
1289         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1290         (rs6000/powerpc-cell64l-expedite): Likewise
1291         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1292         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1293         rs6000/powerpc-cell64l.xml.
1294         * features/rs6000/powerpc-cell32l.xml: Remove.
1295         * features/rs6000/powerpc-cell64l.xml: Likewise.
1296         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1297         * features/rs6000/powerpc-cell64l.c: Likewise.
1298         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1299         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1300         * regformats/reg-spu.dat: Remove.
1301
1302         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1303         * corelow.c (struct spuid_list): Remove.
1304         (add_to_spuid_list): Remove.
1305         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1306         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1307         (remote_protocol_features): Remove associated entries.
1308         (_initialize_remote): No longer initialize them.
1309         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1310         * linux-nat.c (SPUFS_MAGIC): Remove.
1311         (linux_proc_xfer_spu): Remove.
1312         (spu_enumerate_spu_ids): Remove.
1313         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1314         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1315         (linux_make_corefile_notes): No longer call it.
1316
1317         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1318         (cooked_write_test): Likewise.
1319
1320 2019-09-20  Tom Tromey  <tom@tromey.com>
1321
1322         * NEWS: Mention case-sensitivity of TUI commands.
1323         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1324         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1325         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1326
1327 2019-09-20  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-source.c (tui_source_window::set_contents): Use
1330         make_unique_xstrdup.
1331         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1332         make_unique_xstrdup.
1333
1334 2019-09-20  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-data.c: Remove separator comments.
1337         * tui/tui-layout.c: Remove separator comments.
1338         * tui/tui-win.c: Remove separator comments.
1339         * tui/tui-wingeneral.c: Remove separator comments.
1340
1341 2019-09-20  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui.h (strcat_to_buf): Don't declare.
1344         * tui/tui.c (strcat_to_buf): Remove.
1345
1346 2019-09-20  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1349         from "fullname".
1350         * tui/tui-source.c (tui_source_window::set_contents)
1351         (tui_source_window::location_matches_p)
1352         (tui_source_window::maybe_update): Update.
1353
1354 2019-09-20  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1357         Update.
1358         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1359         prefix.
1360         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1361         (tui_data_window::line_from_reg_element_no)
1362         (tui_data_window::first_reg_element_no_inline)
1363         (tui_data_window::show_registers)
1364         (tui_data_window::show_register_group)
1365         (tui_data_window::display_registers_from)
1366         (tui_data_window::display_registers_from_line)
1367         (tui_data_window::first_data_item_displayed)
1368         (tui_data_window::delete_data_content_windows)
1369         (tui_data_window::erase_data_content)
1370         (tui_data_window::do_scroll_vertical)
1371         (tui_data_window::refresh_window)
1372         (tui_data_window::check_register_values): Update.
1373
1374 2019-09-20  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1377         (struct tui_locator_window) <full_name, proc_name>: Now
1378         std::string.
1379         * tui/tui-stack.c (tui_locator_window::make_status_line)
1380         (tui_locator_window::set_locator_fullname)
1381         (tui_locator_window::set_locator_info): Update.
1382         * tui/tui-source.c (tui_source_window::set_contents)
1383         (tui_source_window::showing_source_p): Update.
1384
1385 2019-09-20  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1388         Don't call tui_locator_win_info_ptr.
1389
1390 2019-09-20  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1393
1394 2019-09-20  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1397         height for locator.
1398         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1399         * tui/tui-layout.c (show_source_disasm_command, show_data)
1400         (show_source_or_disasm_and_command): Use 1 as height for locator.
1401
1402 2019-09-20  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui.c (tui_enable): Update.
1405         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1406         Update.
1407         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1408         Update.
1409         * tui/tui-data.c (win_resized): Now bool.
1410         (tui_win_resized): Return bool.
1411         (tui_set_win_resized_to): Accept a bool.
1412
1413 2019-09-20  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1416         Change type of "refresh_values_only".
1417         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1418         type of "refresh_values_only".
1419
1420 2019-09-20  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1423         std::string.
1424         (tui_disassemble): Add "pos" parameter.
1425         (tui_disasm_window::set_contents): Simplify.
1426
1427 2019-09-20  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-winsource.h (struct tui_source_window_base)
1430         <show_source_content>: Now private.
1431         * tui/tui-winsource.c
1432         (tui_source_window_base::show_source_content): Don't handle empty
1433         content case.
1434
1435 2019-09-20  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-layout.c (show_source_disasm_command)
1438         (show_source_or_disasm_and_command): Don't call
1439         show_source_content.
1440
1441 2019-09-20  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1444         Declare.
1445         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1446         from tui_make_status_line.
1447         (tui_locator_window::rerender): Update.
1448
1449 2019-09-20  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1452         (tui_locator_window::rerender): Update.
1453
1454 2019-09-20  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-winsource.h (struct tui_source_window_base)
1457         <~tui_source_window_base>: Don't declare.
1458         <fullname>: Remove.
1459         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1460         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1461         member.
1462         * tui/tui-source.c (tui_source_window::set_contents): Update.
1463         (tui_source_window::location_matches_p)
1464         (tui_source_window::maybe_update): Update.
1465
1466 2019-09-20  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-winsource.h (~tui_source_element): Remove.
1469         (tui_source_element): Update.
1470         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1471         * tui/tui-winsource.c (tui_show_source_line): Update.
1472         * tui/tui-source.c (tui_source_window::set_contents): Update.
1473         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1474
1475 2019-09-20  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1478         declare.
1479         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1480         tui_clear_source_windows_detail.
1481         * tui/tui-winsource.h (struct tui_source_window_base)
1482         <clear_detail>: Don't declare.
1483         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1484         Remove.
1485         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1486
1487 2019-09-20  Tom Tromey  <tromey@adacore.com>
1488
1489         PR ada/24919:
1490         * block.c (contained_in): Fix final return value.
1491
1492 2019-09-20  Alan Modra  <amodra@gmail.com>
1493
1494         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1495         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1496         (read_indirect_string_from_dwz): Use bfd accessor.
1497         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1498         * machoread.c (macho_symfile_read_all_oso): Likewise.
1499         * solib.c (solib_bfd_open): Likewise.
1500
1501 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1502
1503         * eval.c: Move declaration of overload_resolution to...
1504         * value.h: ...here.
1505
1506 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1507
1508         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1509         * arm-linux-tdep.c: Likewise.
1510         * arm-nbsd-nat.c: Likewise.
1511         * arm-tdep.h: Declare arm_apcs_32.
1512         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1513
1514 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1515
1516         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1517         * dwarf2read.h: Declare dwarf_always_disassemble.
1518
1519 2019-09-19  Tom de Vries  <tdevries@suse.de>
1520
1521         PR gdb/25009
1522         * source-cache.c (source_cache::ensure): Catch exception thrown during
1523         construction of the highlighter.
1524
1525 2019-09-18  Alan Modra  <amodra@gmail.com>
1526
1527         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1528         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1529         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1530         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1531         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1532         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1533         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1534         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1535         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1536         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1537         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1538         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1539         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1540         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1541         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1542         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1543         * mi/mi-interp.c: Update throughout for bfd section macro and
1544         function changes.
1545         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1546         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1547
1548 2019-09-18  Tom Tromey  <tom@tromey.com>
1549
1550         * NEWS: Add entry.
1551         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1552         call rl_initialize.
1553         (tui_enable): Do not call rl_initialize.
1554
1555 2019-09-18  Christian Groessler  <chris@groessler.org>
1556
1557         * alpha-linux-nat.c: Include gdbarch.h.
1558
1559 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1560
1561         * ui-file.c: Include cli/cli-style.h.
1562         (term_cli_styling): Remove cli_styling declaration.
1563
1564 2019-09-18  Alan Modra  <amodra@gmail.com>
1565
1566         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1567         to bfd_asymbol_section.
1568
1569 2019-09-18  Alan Modra  <amodra@gmail.com>
1570
1571         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1572         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1573         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1574
1575 2019-09-18  Alan Modra  <amodra@gmail.com>
1576
1577         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1578         * spu-linux-nat.c (spu_bfd_open): Likewise.
1579
1580 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1581
1582         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1583         to bool to match definition in dwarf2read.c.
1584
1585 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1586
1587         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1588         (print_signatures): Likewise.
1589         (trust_pad_over_xvs): Likewise.
1590         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1591         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1592         * arm-linux-nat.c (arm_apcs_32): Likewise.
1593         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1594         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1595         * arm-tdep.c (arm_debug): Likewise.
1596         (arm_apcs_32): Likewise.
1597         * auto-load.c (debug_auto_load): Likewise.
1598         (auto_load_gdb_scripts): Likewise.
1599         (global_auto_load): Likewise.
1600         (auto_load_local_gdbinit): Likewise.
1601         (auto_load_local_gdbinit_loaded): Likewise.
1602         * auto-load.h (global_auto_load): Likewise.
1603         (auto_load_local_gdbinit): Likewise.
1604         (auto_load_local_gdbinit_loaded): Likewise.
1605         * breakpoint.c (disconnected_dprintf): Likewise.
1606         (breakpoint_proceeded): Likewise.
1607         (automatic_hardware_breakpoints): Likewise.
1608         (always_inserted_mode): Likewise.
1609         (target_exact_watchpoints): Likewise.
1610         (_initialize_breakpoint): Update.
1611         * breakpoint.h (target_exact_watchpoints): Change to bool.
1612         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1613         * cli/cli-cmds.c (trace_commands): Likewise.
1614         * cli/cli-cmds.h (trace_commands): Likewise.
1615         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1616         to bool*.
1617         * cli/cli-logging.c (logging_overwrite): Change to bool.
1618         (logging_redirect): Likewise.
1619         (debug_redirect): Likewise.
1620         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1621         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1622         to bool.
1623         <boolean_option_def>: Update.
1624         (struct flag_option_def): Change default type of Context to bool
1625         from int.
1626         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1627         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1628         (get_setshow_command_value_string): Likewise.
1629         * cli/cli-style.c (cli_styling): Change to bool.
1630         (source_styling): Likewise.
1631         * cli/cli-style.h (source_styling): Likewise.
1632         (cli_styling): Likewise.
1633         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1634         to bool.
1635         * command.h (var_types): Update comment.
1636         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1637         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1638         bool.
1639         (debug_compile_cplus_scopes): Likewise.
1640         * compile/compile-internal.h (compile_debug): Likewise.
1641         * compile/compile.c (compile_debug): Likewise.
1642         (struct compile_options) <raw>: Likewise.
1643         * cp-support.c (catch_demangler_crashes): Likewise.
1644         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1645         (usr_cmd_cris_dwarf2_cfi): Likewise.
1646         * csky-tdep.c (csky_debug): Likewise.
1647         * darwin-nat.c (enable_mach_exceptions): Likewise.
1648         * dcache.c (dcache_enabled_p): Likewise.
1649         * defs.h (info_verbose): Likewise.
1650         * demangle.c (demangle): Likewise.
1651         (asm_demangle): Likewise.
1652         * dwarf-index-cache.c (debug_index_cache): Likewise.
1653         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1654         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1655         * dwarf2read.c (check_physname): Likewise.
1656         (use_deprecated_index_sections): Likewise.
1657         (dwarf_always_disassemble): Likewise.
1658         * eval.c (overload_resolution): Likewise.
1659         * event-top.c (set_editing_cmd_var): Likewise.
1660         (exec_done_display_p): Likewise.
1661         * event-top.h (set_editing_cmd_var): Likewise.
1662         (exec_done_display_p): Likewise.
1663         * exec.c (write_files): Likewise.
1664         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1665         (debug_fbsd_nat): Likewise.
1666         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1667         Likewise.
1668         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1669         <backtrace_past_entry> Likewise.
1670         * gdb-demangle.h (demangle): Likewise.
1671         (asm_demangle): Likewise.
1672         * gdb_bfd.c (bfd_sharing): Likewise.
1673         * gdbcore.h (write_files): Likewise.
1674         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1675         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1676         * gdbthread.h (print_thread_events): Likewise.
1677         * gdbtypes.c (opaque_type_resolution): Likewise.
1678         (strict_type_checking): Likewise.
1679         * gnu-nat.c (gnu_debug_flag): Likewise.
1680         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1681         * guile/scm-param.c (pascm_variable): Add boolval.
1682         (add_setshow_generic): Update.
1683         (pascm_param_value): Update.
1684         (pascm_set_param_value_x): Update.
1685         * hppa-tdep.c (hppa_debug): Change to bool..
1686         * infcall.c (may_call_functions_p): Likewise.
1687         (coerce_float_to_double_p): Likewise.
1688         (unwind_on_signal_p): Likewise.
1689         (unwind_on_terminating_exception_p): Likewise.
1690         * infcmd.c (startup_with_shell): Likewise.
1691         * inferior.c (print_inferior_events): Likewise.
1692         * inferior.h (startup_with_shell): Likewise.
1693         (print_inferior_events): Likewise.
1694         * infrun.c (step_stop_if_no_debug): Likewise.
1695         (detach_fork): Likewise.
1696         (debug_displaced): Likewise.
1697         (disable_randomization): Likewise.
1698         (non_stop): Likewise.
1699         (non_stop_1): Likewise.
1700         (observer_mode): Likewise.
1701         (observer_mode_1): Likewise.
1702         (set_observer_mode): Update.
1703         (sched_multi): Change to bool.
1704         * infrun.h (debug_displaced): Likewise.
1705         (sched_multi): Likewise.
1706         (step_stop_if_no_debug): Likewise.
1707         (non_stop): Likewise.
1708         (disable_randomization): Likewise.
1709         * linux-tdep.c (use_coredump_filter): Likewise.
1710         (dump_excluded_mappings): Likewise.
1711         * linux-thread-db.c (auto_load_thread_db): Likewise.
1712         (check_thread_db_on_load): Likewise.
1713         * main.c (captured_main_1): Update.
1714         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1715         xx2_opt, boolean_opt>: Change to bool.
1716         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1717         * maint.c (maintenance_profile_p): Likewise.
1718         (per_command_time): Likewise.
1719         (per_command_space): Likewise.
1720         (per_command_symtab): Likewise.
1721         * memattr.c (inaccessible_by_default): Likewise.
1722         * mi/mi-main.c (mi_async): Likewise.
1723         (mi_async_1): Likewise.
1724         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1725         * nat/fork-inferior.h (startup_with_shell): Likewise.
1726         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1727         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1728         * nios2-tdep.c (nios2_debug): Likewise.
1729         * or1k-tdep.c (or1k_debug): Likewise.
1730         * parse.c (parser_debug): Likewise.
1731         * parser-defs.h (parser_debug): Likewise.
1732         * printcmd.c (print_symbol_filename): Likewise.
1733         * proc-api.c (procfs_trace): Likewise.
1734         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1735         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1736         (set_parameter_value): Update.
1737         (add_setshow_generic): Update.
1738         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1739         to bool*.
1740         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1741         int*.
1742         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1743         * record-btrace.c (record_btrace_target::store_registers): Update.
1744         * record-full.c (record_full_memory_query): Change to bool.
1745         (record_full_stop_at_limit): Likewise.
1746         * record-full.h (record_full_memory_query): Likewise.
1747         * remote-notif.c (notif_debug): Likewise.
1748         * remote-notif.h (notif_debug): Likewise.
1749         * remote.c (use_range_stepping): Likewise.
1750         (interrupt_on_connect): Likewise.
1751         (remote_break): Likewise.
1752         * ser-tcp.c (tcp_auto_retry): Likewise.
1753         * ser-unix.c (serial_hwflow): Likewise.
1754         * skip.c (debug_skip): Likewise.
1755         * solib-aix.c (solib_aix_debug): Likewise.
1756         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1757         (spu_auto_flush_cache_p): Likewise.
1758         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1759         Likewise.
1760         (struct info_print_options) <quiet>: Likewise.
1761         * symfile-debug.c (debug_symfile): Likewise.
1762         * symfile.c (auto_solib_add): Likewise.
1763         (separate_debug_file_debug): Likewise.
1764         * symfile.h (auto_solib_add): Likewise.
1765         (separate_debug_file_debug): Likewise.
1766         * symtab.c (basenames_may_differ): Likewise.
1767         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1768         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1769         (struct info_types_options) <quiet>: Likewise.
1770         * symtab.h (demangle): Likewise.
1771         (basenames_may_differ): Likewise.
1772         * target-dcache.c (stack_cache_enabled_1): Likewise.
1773         (code_cache_enabled_1): Likewise.
1774         * target.c (trust_readonly): Likewise.
1775         (may_write_registers): Likewise.
1776         (may_write_memory): Likewise.
1777         (may_insert_breakpoints): Likewise.
1778         (may_insert_tracepoints): Likewise.
1779         (may_insert_fast_tracepoints): Likewise.
1780         (may_stop): Likewise.
1781         (auto_connect_native_target): Likewise.
1782         (target_stop_and_wait): Update.
1783         (target_async_permitted): Change to bool.
1784         (target_async_permitted_1): Likewise.
1785         (may_write_registers_1): Likewise.
1786         (may_write_memory_1): Likewise.
1787         (may_insert_breakpoints_1): Likewise.
1788         (may_insert_tracepoints_1): Likewise.
1789         (may_insert_fast_tracepoints_1): Likewise.
1790         (may_stop_1): Likewise.
1791         * target.h (target_async_permitted): Likewise.
1792         (may_write_registers): Likewise.
1793         (may_write_memory): Likewise.
1794         (may_insert_breakpoints): Likewise.
1795         (may_insert_tracepoints): Likewise.
1796         (may_insert_fast_tracepoints): Likewise.
1797         (may_stop): Likewise.
1798         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1799         (make_thread_apply_all_options_def_group): Change argument from int*
1800         to bool*.
1801         (thread_apply_all_command): Update.
1802         (print_thread_events): Change to bool.
1803         * top.c (confirm): Likewise.
1804         (command_editing_p): Likewise.
1805         (history_expansion_p): Likewise.
1806         (write_history_p): Likewise.
1807         (info_verbose): Likewise.
1808         * top.h (confirm): Likewise.
1809         (history_expansion_p): Likewise.
1810         * tracepoint.c (disconnected_tracing): Likewise.
1811         (circular_trace_buffer): Likewise.
1812         * typeprint.c (print_methods): Likewise.
1813         (print_typedefs): Likewise.
1814         * utils.c (debug_timestamp): Likewise.
1815         (sevenbit_strings): Likewise.
1816         (pagination_enabled): Likewise.
1817         * utils.h (sevenbit_strings): Likewise.
1818         (pagination_enabled): Likewise.
1819         * valops.c (overload_resolution): Likewise.
1820         * valprint.h (struct value_print_options) <prettyformat_arrays,
1821         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1822         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1823         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1824         Likewise.
1825         * windows-nat.c (new_console): Likewise.
1826         (cygwin_exceptions): Likewise.
1827         (new_group): Likewise.
1828         (debug_exec): Likewise.
1829         (debug_events): Likewise.
1830         (debug_memory): Likewise.
1831         (debug_exceptions): Likewise.
1832         (useshell): Likewise.
1833         * windows-tdep.c (maint_display_all_tib): Likewise.
1834         * xml-support.c (debug_xml): Likewise.
1835
1836 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1837
1838         * source.c (prepare_path_for_appending): New function.
1839         (openp): Make use of new function.
1840         (find_and_open_source): Search for the compilation directory and
1841         source file as a relative path beneath the directory search path.
1842
1843 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * source-cache.c (source_cache::get_line_charpos): Catch
1846         exceptions and return false, this matches the behaviour documented
1847         in the header file.
1848
1849 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1850
1851         * ada-tasks.c (info_task): Remove quoting of the task's name.
1852
1853 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1854
1855         * symfile.c (auto_solib_add): Replace comment with a reference
1856         to the header file.
1857
1858 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1859
1860         * NEWS: Mention that gdb can now be compiled with Python 3
1861         on Windows.
1862
1863 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1864
1865         * maint.c (maint_print_section_data::maint_print_section_data):
1866         Force use of 'float log10 (float)' by casting the argument to
1867         float.
1868
1869 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * maint.c: Add 'cmath' include.
1872         (struct maint_print_section_data): New structure.
1873         (print_section_index): New function.
1874         (print_bfd_section_info): Add header comment, small whitespace
1875         cleanup, and update to call new print_section_index function.
1876         (print_objfile_section_info): Likewise.
1877         (maint_obj_section_from_bfd_section): New function.
1878         (print_bfd_section_info_maybe_relocated): New function.
1879         (maintenance_info_sections): Add header comment, always use
1880         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1881
1882 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1883
1884         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1885         inner scope, add check that the objfile has psymtabs before
1886         checking psymtabs_addrmap.
1887         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1888
1889 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1890
1891         * NEWS: Announce that Ada task names are now shown at more places,
1892         and between quotes (except in info task output).
1893         * gdb/ada-tasks.c (task_to_str): New function.
1894         (display_current_task_id): Call task_to_str.
1895         (task_command_1): Likewise.
1896         (print_ada_task_info): In non-mi mode, Properly align headers and data
1897         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1898
1899 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1900
1901         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1902         prstatus.pr_lwp.pr_info instead of making it up.
1903
1904 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1905
1906         * auto-load.c (auto_load_expand_dir_vars): Update.
1907         * defs.h (gdb_datadir): Change to std::string.
1908         (python_libdir): Likewise.
1909         (relocate_gdb_directory): Change return type to std::string.
1910         * guile/guile.c (gdbscm_data_directory): Update.
1911         (initialize_scheme_side): Update.
1912         * jit.c (jit_reader_dir): Change to std::string.
1913         (jit_reader_load_command): Update.
1914         * main.c (gdb_datadir): Change to std::string.
1915         (python_libdir): Likewise.
1916         (set_gdb_data_directory): Update.
1917         (relocate_path): Change to return std::string.
1918         (relocate_gdb_directory): Change to return std::string.
1919         (relocate_gdbinit_path_maybe_in_datadir): Update.
1920         (captured_main_1): Update.
1921         * python/python.c (do_start_initialization): Update.
1922         * top.c (show_gdb_datadir): Update.
1923         * xml-syscall.c (xml_init_syscalls_info): Update.
1924         (init_syscalls_info): Update.
1925
1926 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1927
1928         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1929         out of get_init_files.
1930         (get_init_files): Update.
1931
1932 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1933
1934         * main.c (get_init_files): Change to use std::string.
1935         (captured_main_1): Update.
1936         (print_gdb_help): Update.
1937
1938 2019-09-11  Ali Tamur  <tamur@google.com>
1939
1940         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1941         implementation.
1942
1943 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1944
1945         * dbxread.c (read_dbx_symtab): Update.
1946         * dwarf2read.c (load_partial_dies): Update.
1947         * mdebugread.c (parse_partial_symbols): Update.
1948         (handle_psymbol_enumerators): Update.
1949         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1950         * psymtab.c (add_psymbol_to_bcache): Likewise.
1951         (add_psymbol_to_list): Likewise.
1952         * symtab.c (symbol_set_names): Likewise.
1953         * symtab.h (symbol_set_names): Likewise.
1954         * xcoffread.c (scan_xcoff_symtab): Update.
1955
1956 2019-09-11  Tom Tromey  <tom@tromey.com>
1957
1958         * symfile-mem.c (symbol_file_add_from_memory): Use
1959         bfd_set_filename.
1960         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1961         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1962
1963 2019-09-10  Tom Tromey  <tromey@adacore.com>
1964
1965         * dwarf-index-write.c (write_psymbols): Extend error message.
1966         (debug_names::insert): Add Ada code.
1967         (debug_names::write_psymbols): Remove Ada check.
1968         (debug_names) <m_string_obstack>: New member.
1969         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1970         (gdb_index_symbol_name_matcher::matches): Remove.
1971         (mapped_index_base::find_name_components_bounds): Add "lang"
1972         parameter.
1973         (mapped_index_base::build_name_components): Also split names
1974         according to Ada syntax.
1975         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1976         type of "match_callback".
1977         (check_match, check_find_bounds_finds)
1978         (dw2_expand_symtabs_matching): Update.
1979         (dw2_debug_names_iterator): Add new constructor.
1980         (dw2_debug_names_map_matching_symbols): New function.
1981         (dw2_debug_names_expand_symtabs_matching): Update.
1982         (dwarf2_debug_names_functions): Use
1983         dw2_debug_names_map_matching_symbols.
1984
1985 2019-09-10  Tom Tromey  <tromey@adacore.com>
1986
1987         * dwarf2read.c (dw2_get_file_names_reader): Add the
1988         CU's file name to the results.
1989
1990 2019-09-10  Tom Tromey  <tromey@adacore.com>
1991
1992         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1993         map_matching_symbols.  Update.
1994         * dwarf2read.c (dw2_map_matching_symbols): Update.
1995         * psymtab.c (match_partial_symbol): Change type; update.
1996         (psym_map_matching_symbols): Likewise.
1997         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1998         type; update.
1999         * symfile.h (struct quick_symbol_functions)
2000         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2001         Remove "match".
2002
2003 2019-09-10  Tom Tromey  <tromey@adacore.com>
2004
2005         * psymtab.c (map_block): Remove.
2006         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2007         * symtab.c (iterate_over_symbols_terminated): New function.
2008         * symtab.c (iterate_over_symbols_terminated): Declare.
2009
2010 2019-09-10  Tom Tromey  <tromey@adacore.com>
2011
2012         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2013         * language.h (struct language_defn) <la_iterate_over_symbols>:
2014         Return bool.
2015         * symtab.c (iterate_over_symbols): Return bool.
2016         * symtab.h (iterate_over_symbols): Return bool.
2017
2018 2019-09-10  Tom Tromey  <tromey@adacore.com>
2019
2020         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2021         (add_nonlocal_symbols): Update.
2022         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2023         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2024         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2025         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2026         Change type of "callback".  Remove "data".
2027
2028
2029 2019-09-09  Ali Tamur  <tamur@google.com>
2030
2031         * dwarf2read.c (comp_unit_head): Update comment.
2032         (dwarf2_dwo_name): New function declaration.
2033         (dwarf_unit_type_name): New function declaration.
2034         (read_comp_unit_head): Add support for new compilation units,
2035         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2036         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2037         (currently named as "signature") in their header. Also clarify error
2038         messages.
2039         (lookup_dwo_id): New function. Returns the dwo id of the given
2040         compile unit.
2041         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2042         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2043         functions.
2044         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2045         (dwarf2_dwo_name): Get the dwo name if present.
2046         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2047         purposes.
2048
2049 2019-09-09  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2052
2053 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2054
2055         * python/python.c (do_start_initialization): Make progname_copy static,
2056         to avoid a leak report.
2057
2058 2019-09-08  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2061
2062 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2063
2064         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2065         Change type to gdb::optional<block_enum>.
2066         (dw2_symtab_iter_init): Change block_index parameter type
2067         to gdb::optional<block_enum>.
2068         (dw2_lookup_symbol): Change block_index parameter
2069         type to block_enum.c
2070         (dw2_debug_names_lookup_symbol): Likewise.
2071         * psymtab.c (psym_lookup_symbol): Likewise.
2072         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2073         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2074         Likewise.
2075
2076 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2077
2078         * defs.h (relocate_gdb_directory): Change int to bool in
2079         signature and rename flag to relocatable.
2080         * main.c (relocate_path): Likewise.
2081         (relocate_gdb_directory): Likewise.
2082
2083 2019-09-06  Alan Modra  <amodra@gmail.com>
2084
2085         * coffread.c (coff_symfile_read): Constify filename variable.
2086         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2087         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2088         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2089         * solib.c (reload_shared_libraries_1): Likewise.
2090         * symfile.c (reread_symbols): Likewise.
2091         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2092         * solib-darwin.c (darwin_bfd_open): Likewise.
2093         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2094
2095 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2096
2097         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2098         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2099
2100 2019-09-03  Tom Tromey  <tromey@adacore.com>
2101
2102         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2103         types.
2104         (has_negatives): Unbias a range type bound.
2105         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2106         * gdbtypes.c (operator==): Handle new field.
2107         (create_range_type): Add "bias" parameter.
2108         (create_static_range_type, resolve_dynamic_range): Update.
2109         * gdbtypes.h (struct range_bounds) <bias>: New member.
2110         (create_range_type): Add bias parameter.
2111         * printcmd.c (print_scalar_formatted): Unbias range types.
2112         * value.c (unpack_long): Unbias range types.
2113         (pack_long): Bias range types.
2114
2115 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2116
2117         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2118         probe arguments.
2119
2120 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2121
2122         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2123         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2124         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2125         (compile_probe_arg): Likewise.
2126         * probe.h (get_argument_count): Likewise.
2127         * solib-svr4.c (solib_event_probe_action): Likewise.
2128         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2129
2130 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2131
2132         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2133         code to here...
2134         (svr4_create_solib_event_breakpoints): ...from here.
2135
2136 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2137
2138         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2139         suffix from warning message.
2140
2141 2019-08-30  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-winsource.h (struct tui_source_window_base)
2144         <refresh_all>: Don't declare.
2145         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2146         Remove.
2147         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2148         tui_show_locator_content.
2149         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2150         declare.
2151         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2152         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2153         declare.
2154
2155 2019-08-30  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2158
2159 2019-08-30  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2162         Remove unnecessary forward declarations.
2163
2164 2019-08-30  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2167         rerender.
2168         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2169         tui_show_locator_content.
2170
2171 2019-08-30  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2174         (tui_locator_window::rerender): Rewrite using body of previous
2175         tui_show_locator_content.
2176
2177 2019-08-30  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2180         set_locator_fullname>: New methods.
2181         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2182         Rename from tui_set_locator_fullname.
2183         (tui_locator_window::set_locator_info): Rename from
2184         tui_set_locator_info.  Return bool.
2185         (tui_update_locator_fullname, tui_show_frame_info): Update.
2186
2187 2019-08-30  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2190
2191 2019-08-30  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2194         call touchwin.
2195
2196 2019-08-30  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-wingeneral.c (box_win): Assume win_info and
2199         win_info->handle cannot be NULL.
2200
2201 2019-08-30  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2204         refresh_window>: Declare.
2205         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2206         resize.
2207         (tui_data_item_window::rerender): Rename from
2208         tui_display_register.
2209         (tui_data_item_window::refresh_window): New method.
2210         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2211         no-op.
2212
2213 2019-08-30  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2216         regs_column_count, current_group>: Move later.  Now private.
2217         <get_current_group>: New method.
2218         * tui/tui-regs.c (tui_reg_command): Update.
2219         * tui/tui-layout.c (tui_set_layout): Update.
2220
2221 2019-08-30  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2224         (tui_data_window::rerender): Don't call
2225         check_and_display_highlight_if_needed.
2226         (tui_data_window::refresh_all): Remove call to
2227         erase_data_content.
2228
2229 2019-08-30  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2232         (tui_data_window::display_registers_from)
2233         (tui_data_window::display_reg_element_at_line)
2234         (tui_data_window::display_registers_from_line): Remove checks of
2235         "empty".
2236
2237 2019-08-30  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2240         Don't declare.
2241         * tui/tui-regs.c (tui_data_window::show_registers): Call
2242         rerender.
2243         (tui_data_window::rerender): Rename from display_all_data.
2244         (tui_data_window::rerender): Remove old implementation.
2245
2246 2019-08-30  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2249         text.
2250         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2251
2252 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2253             Sergio Durigan Junior  <sergiodj@redhat.com>
2254
2255         PR win32/24284
2256         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2257
2258 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2261         when searching for types.
2262
2263 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2264
2265         * f-lang.c (f_language_defn): Use f_print_typedef.
2266         * f-lang.h (f_print_typedef): Declare.
2267         * f-typeprint.c (f_print_typedef): Define.
2268
2269 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2270
2271         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2272
2273 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * cli/cli-utils.c (info_print_options_defs): Delete.
2276         (make_info_print_options_def_group): Delete.
2277         (extract_info_print_options): Delete.
2278         (info_print_command_completer): Delete.
2279         (info_print_args_help): Add extra parameter, and optionally
2280         include text about -n flag.
2281         * cli/cli-utils.h (struct info_print_options): Delete.
2282         (extract_info_print_options): Delete declaration.
2283         (info_print_command_completer): Delete declaration.
2284         (info_print_args_help): Add extra parameter, extend header
2285         comment.
2286         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2287         search_symbols.
2288         * stack.c (struct info_print_options): New type.
2289         (info_print_options_defs): New file scoped variable.
2290         (make_info_print_options_def_group): New static function.
2291         (info_print_command_completer): New static function.
2292         (info_locals_command): Update to use new local functions.
2293         (info_args_command): Likewise.
2294         (_initialize_stack): Add extra parameter to calls to
2295         info_print_args_help.
2296         * symtab.c (search_symbols): Add extra parameter, use this to
2297         possibly excluse non-debug symbols.
2298         (symtab_symbol_info): Add extra parameter, which is passed on to
2299         search_symbols.
2300         (struct info_print_options): New type.
2301         (info_print_options_defs): New file scoped variable.
2302         (make_info_print_options_def_group): New static function.
2303         (info_print_command_completer): New static function.
2304         (info_variables_command): Update to use local functions, and pass
2305         extra parameter through to symtab_symbol_info.
2306         (info_functions_command): Likewise.
2307         (info_types_command): Pass additional argument through to
2308         symtab_symbol_info.
2309         (rbreak_command): Pass extra argument to search_symbols.
2310         (_initialize_symtab): Add extra arguments for calls to
2311         info_print_args_help, and update help text for 'info variables',
2312         'whereis', and 'info functions' commands.
2313         * symtab.h (search_symbols): Add extra argument to declaration.
2314         * NEWS: Mention new flags.
2315
2316 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2317
2318         * symtab.c (lookup_static_symbol): Call the new function (and move
2319         it down to be next to lookup_global_symbol).
2320         (struct global_sym_lookup_data): Add block_enum member and rename to...
2321         (struct global_or_static_sym_lookup_data): ...this.
2322         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2323         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2324         (lookup_symbol_global_or_static_iterator_cb): ...this.
2325         (lookup_global_or_static_symbol): New function.
2326         (lookup_global_symbol): Call new function.
2327
2328 2019-08-26  Tom de Vries  <tdevries@suse.de>
2329
2330         PR c++/24852
2331         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2332         when pc_probe.prob == NULL.
2333
2334 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2335
2336         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2337         variable symbol_linkage to symbol_linkage_.
2338
2339 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2340
2341         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2342         represent whether the symbol is static, dynamic, or we don't
2343         know.
2344
2345 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2346
2347         * gdb/rx-tdep.c (rx_register_names): New.
2348         (rx_register_name): Delete.
2349         (rx_psw_type): Delete.
2350         (rx_fpsw_type): Delete.
2351         (rx_register_type): Delete.
2352         (rx_gdbarch_init): Convert target-descriptions.
2353         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2354         * gdb/features/Makefile: Add rx.xml.
2355         * gdb/features/rx.xml: New.
2356         * gdb/features/rx.c: Generated.
2357         * gdb/NEWS: Mention target description support.
2358
2359 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2360
2361         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2362         *slot_ptr.
2363
2364 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2365
2366         * configure.ac: Don't check for 'dlfcn.h' (moved to
2367         gdbsupport/common.m4).
2368         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2369         'gdbsupport/'.
2370         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2371         * compile/compile-c-support.c: Include
2372         'gdbsupport/gdb-dlfcn.h'.
2373         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2374         * gdb-dlfcn.c: Move to...
2375         * gdbsupport/gdb-dlfcn.c: ... here.
2376         * gdb-dlfcn.h: Move to...
2377         * gdbsupport/gdb-dlfcn.h: ... here.
2378
2379 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2380
2381         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2382         the offset field signed.
2383
2384 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2385
2386         * python/lib/gdb/__init__.py (_execute_file): New function.
2387         * python/python.c (python_run_simple_file): Call gdb._execute_file
2388         on Windows.
2389
2390 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2393         all uses as this was never set to anything but a zero value.
2394
2395 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2396
2397         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2398
2399 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2400
2401         * tui/tui-data.h (tui_gen_win_info): Add an =default
2402         move constructor, required by some GCC versions.
2403
2404 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2405
2406         * go32-nat.c (go32_sysinfo): Add hygon_p.
2407
2408 2019-08-20  Tom Tromey  <tom@tromey.com>
2409
2410         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2411         line_from_reg_element_no, first_reg_element_no_inline,
2412         display_all_data, delete_data_content_windows,
2413         erase_data_content>: Now private.
2414
2415 2019-08-20  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2418         (tui_unhighlight_win, tui_highlight_win)
2419         (tui_win_info::make_window): Update.
2420         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2421
2422 2019-08-20  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2425         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2426         (MAX_PID_WIDTH): Move to tui-stack.c.
2427         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2428         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2429         (MAX_PID_WIDTH): Move from tui-data.h.
2430
2431 2019-08-20  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2434         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2435         (box_win): Update.
2436         (tui_gen_win_info::make_window): Rename from tui_make_window.
2437         (tui_win_info::make_window): New method.
2438         (tui_gen_win_info::make_visible): Update.
2439         * tui/tui-source.c (tui_source_window::set_contents): Update.
2440         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2441         (tui_data_window::display_registers_from): Update.
2442         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2443         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2444         Declare.
2445         <can_box>: Remove.
2446         <title>: Remove.
2447         (struct tui_win_info) <make_window>: Declare.
2448         <can_box>: Now virtual.
2449         <title>: New member.
2450         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2451         * tui/tui-command.c (tui_cmd_window::resize): Update.
2452
2453 2019-08-20  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2456         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2457         (tui_data_window::check_register_values): Update.
2458
2459 2019-08-20  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-regs.h (struct tui_data_window): Use
2462         DISABLE_COPY_AND_ASSIGN.
2463         <regs_content>: Change type, removing unique_ptr.
2464         <tui_data_window>: Add move constructor.
2465         * tui/tui-regs.c (tui_data_window::show_registers)
2466         (tui_data_window::show_register_group)
2467         (tui_data_window::display_registers_from)
2468         (tui_data_window::display_registers_from)
2469         (tui_data_window::first_data_item_displayed)
2470         (tui_data_window::delete_data_content_windows)
2471         (tui_data_window::rerender, tui_data_window::refresh_window)
2472         (tui_data_window::check_register_values): Update.
2473
2474 2019-08-20  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2477         show_register_group>: Declare.
2478         (tui_show_register_group): Don't declare.
2479         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2480         tui_show_registers.
2481         (tui_data_window::show_register_group): Rename from
2482         tui_show_register_group.
2483         (tui_data_window::check_register_values, tui_reg_command):
2484         Update.
2485         * tui/tui-layout.c (tui_set_layout): Update.
2486
2487 2019-08-20  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2490         Declare.
2491         (tui_check_register_values): Don't declare.
2492         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2493         from tui_check_register_values.
2494         * tui/tui-hooks.c (tui_register_changed): Update.
2495
2496 2019-08-20  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-regs.c (tui_reg_layout): Move later.
2499         (tui_show_registers): Don't enable TUI mode or change layout.
2500
2501 2019-08-20  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-regs.h (struct tui_data_item_window)
2504         <~tui_data_item_window>: Remove.
2505         <content>: Now a unique_xmalloc_ptr.
2506         * tui/tui-regs.c (tui_register_format): Return a
2507         unique_xmalloc_ptr.
2508         (tui_get_register): Update.
2509         (~tui_data_item_window): Remove.
2510         (tui_data_window::display_registers_from, tui_display_register):
2511         Update.
2512         * tui/tui-io.h (tui_expand_tabs): Update.
2513         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2514         Remove "col" parameter.
2515
2516 2019-08-20  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2519         field.
2520         * tui/tui-regs.c (~tui_data_item_window): Update.
2521
2522 2019-08-20  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2525         earlier.
2526
2527 2019-08-20  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2530
2531 2019-08-20  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-source.h (struct tui_source_window): Update.
2534         * tui/tui-regs.c (tui_show_registers): Update.
2535         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2536         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2537         (NO_REGS_STRING): Remove defines.
2538
2539 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2540
2541         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2542         unnecessary thread walk if remote doesn't support the packet.
2543
2544 2019-08-19  Tom Tromey  <tromey@adacore.com>
2545
2546         * python/py-value.c (value_has_field): Fix indentation.
2547
2548 2019-08-19  Tom Tromey  <tromey@adacore.com>
2549
2550         * printcmd.c (do_one_display, info_display_command): Update.
2551         * block.h (contained_in): Return bool.  Add allow_nested
2552         parameter.
2553         * block.c (contained_in): Return bool.  Add allow_nested
2554         parameter.
2555
2556 2019-08-19  Tom Tromey  <tom@tromey.com>
2557
2558         * configure: Rebuild.
2559         * configure.ac: Disallow the combination of -static-libstdc++ and
2560         source highlight.
2561         * source-cache.c (get_language_name): Handle rust.
2562         (source_cache::get_source_lines): Ignore highlighting exceptions.
2563
2564 2019-08-16  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2567         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2568         (struct tui_source_window_base) <make_visible, refresh_window,
2569         resize>: Remove methods.
2570         <execution_info>: Remove field.
2571         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2572         (tui_show_source_line, tui_source_window_base)
2573         (~tui_source_window_base): Update.
2574         (tui_source_window_base::resize)
2575         (tui_source_window_base::make_visible)
2576         (tui_source_window_base::refresh_window): Remove.
2577         (tui_source_window_base::update_exec_info): Update.
2578         * tui/tui-source.c (tui_source_window::set_contents): Update.
2579         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2580
2581 2019-08-16  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2584         deprecated_query_hook.
2585
2586 2019-08-16  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2589         (tui_update_source_windows_with_line): Update.
2590         * tui/tui-source.h (struct tui_source_window)
2591         <show_symtab_source>: Declare.
2592         (tui_show_symtab_source): Don't declare.
2593         * tui/tui-source.c (tui_show_symtab_source): Rename from
2594         tui_show_symtab_source.
2595
2596 2019-08-16  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-winsource.h (struct tui_source_window_base)
2599         <set_contents>: Declare.
2600         * tui/tui-winsource.c
2601         (tui_source_window_base::update_source_window_as_is): Update.
2602         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2603         Declare.
2604         (tui_set_source_content): Don't declare.
2605         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2606         tui_set_source_content.
2607         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2608         Declare.
2609         (tui_set_disassem_content): Don't declare.
2610         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2611         tui_set_disassem_content.
2612
2613 2019-08-16  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-winsource.h (struct tui_source_window_base)
2616         <update_breakpoint_info>: Declare.
2617         (tui_update_breakpoint_info): Don't declare.
2618         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2619         (tui_update_all_breakpoint_info): Update.
2620         (tui_source_window_base::update_breakpoint_info): Rename from
2621         tui_update_breakpoint_info.
2622         (tui_source_window_base::update_exec_info): Update.
2623
2624 2019-08-16  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-winsource.h (struct tui_source_window_base)
2627         <update_source_window>: Declare.
2628         (tui_update_source_window): Don't declare.
2629         * tui/tui-winsource.c
2630         (tui_source_window_base::update_source_window): Rename from
2631         tui_update_source_window.
2632         (tui_source_window_base::rerender): Update.
2633         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2634         * tui/tui-disasm.c (tui_show_disassem)
2635         (tui_show_disassem_and_update_source)
2636         (tui_disasm_window::maybe_update): Update.
2637
2638 2019-08-16  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-winsource.h (struct tui_source_window_base)
2641         <update_source_window_as_is>: Declare.
2642         (tui_update_source_window_as_is): Don't declare.
2643         * tui/tui-winsource.c (tui_update_source_window): Update
2644         (tui_source_window_base::update_source_window_as_is): Rename from
2645         tui_update_source_window_as_is.
2646         (tui_source_window_base::refill): Update.
2647         * tui/tui-source.c (tui_show_symtab_source): Update.
2648         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2649         Update.
2650
2651 2019-08-16  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-winsource.h (tui_update_source_window)
2654         (tui_update_source_window_as_is): Remove "noerror" parameter.
2655         * tui/tui-winsource.c (tui_update_source_window)
2656         (tui_update_source_window_as_is): Remove "noerror" parameter.
2657         (tui_update_source_windows_with_addr)
2658         (tui_update_source_windows_with_line)
2659         (tui_source_window_base::rerender)
2660         (tui_source_window_base::refill): Update.
2661         * tui/tui-source.h (tui_set_source_content)
2662         (tui_show_symtab_source): Remove "noerror" parameter.
2663         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2664         parameter.
2665         (tui_show_symtab_source): Likewise.
2666         (tui_source_window::maybe_update): Update.
2667         * tui/tui-disasm.c (tui_show_disassem)
2668         (tui_show_disassem_and_update_source)
2669         (tui_disasm_window::do_scroll_vertical)
2670         (tui_disasm_window::maybe_update): Update.
2671
2672 2019-08-16  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui.c (tui_is_window_visible): Update.
2675         * tui/tui-wingeneral.c (tui_make_window)
2676         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2677         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2678         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2679         (tui_set_win_height_command, parse_scrolling_args): Update.
2680         * tui/tui-source.c (tui_source_window::style_changed): Update.
2681         * tui/tui-regs.c (tui_show_registers)
2682         (tui_data_window::first_data_item_displayed)
2683         (tui_data_window::delete_data_content_windows)
2684         (tui_check_register_values, tui_reg_command): Update.
2685         * tui/tui-disasm.c (tui_show_disassem): Update.
2686         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2687         method.
2688         <is_visible>: Remove field.
2689         * tui/tui-data.c (tui_next_win, tui_prev_win)
2690         (tui_delete_invisible_windows): Update.
2691
2692 2019-08-16  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-winsource.h (struct tui_source_window_base)
2695         <m_has_locator>: Remove.
2696         * tui/tui-layout.c (show_source_disasm_command, show_data)
2697         (show_source_or_disasm_and_command): Update.
2698
2699 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2700
2701         * NEWS (Other MI changes): New subsection.
2702         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2703         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2704         * arch-utils.c (default_get_pc_address_flags): New function.
2705         * arch-utils.h (default_get_pc_address_flags): New declaration.
2706         * gdbarch.sh: Add get_pc_address_flags.
2707         * gdbarch.c: Regenerate.
2708         * gdbarch.h: Likewise.
2709         * stack.c (print_pc): New function.
2710         (print_frame_info) (print_frame): Call print_pc.
2711
2712 2019-08-16  Tom de Vries  <tdevries@suse.de>
2713
2714         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2715         print_objfile_section_info.
2716
2717 2019-08-15  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2720         calling update_cmdwin_start_line.
2721         * tui/tui-winsource.h (struct tui_source_window_base)
2722         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2723         <rerender>: Declare.
2724         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2725         Call rerender.
2726         (tui_source_window_base::set_new_height): Remove.
2727         (tui_source_window_base::rerender): Rename from
2728         do_make_visible_with_new_height.
2729         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2730         resize method.
2731         (tui_win_info::make_invisible_and_set_new_height)
2732         (tui_win_info::make_visible_with_new_height): Remove.
2733         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2734         Declare.
2735         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2736         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2737         do_make_visible_with_new_height>: Don't declare.
2738         <rerender>: Declare.
2739         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2740         set_new_height.
2741         (tui_data_window::do_make_visible_with_new_height): Remove.
2742         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2743         call tui_show_locator_content.
2744         (tui_gen_win_info::resize): Call rerender.
2745         (show_source_or_disasm_and_command): Don't call
2746         tui_show_locator_content.
2747         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2748         method.
2749         (struct tui_win_info) <rerender>: Declare.
2750         <set_new_height, make_invisible_and_set_new_height,
2751         make_visible_with_new_height>: Don't declare.
2752         * tui/tui-data.c (tui_win_list::rerender): New method.
2753         * tui/tui-command.h (struct tui_cmd_window)
2754         <do_make_visible_with_new_height>: Don't declare.
2755         * tui/tui-command.c
2756         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2757
2758 2019-08-15  Tom Tromey  <tromey@adacore.com>
2759
2760         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2761         * ada-lang.c (ada_enum_name): Likewise.
2762
2763 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2764
2765         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2766         leading underscore.
2767         (GdbOutputErrorFile): Likewise.
2768         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2769         accordingly.
2770         (execute_unwinders): Rename to have a leading underscore.
2771         (auto_load_packages): Likewise.
2772         (global scope): Adjust call to auto_load_packages accordingly.
2773         (GdbSetPythonDirectory): Likewise.
2774         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2775         instead of execute_unwinders.
2776
2777 2019-08-15  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2780         (show_data): Don't change window visibility.
2781         (tui_gen_win_info::resize): Remove special case for command
2782         window.  Use wresize, when available.
2783         (show_source_or_disasm_and_command): Don't change window
2784         visibility.
2785         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2786         <make_visible>: New method.
2787         * tui/tui-command.c (tui_cmd_window::resize): New method.
2788
2789 2019-08-15  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2792         (struct tui_source_windows): New.
2793         * tui/tui-winsource.c (tui_display_main): Update.
2794         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2795         (new_height_ok, parse_scrolling_args): Update.
2796         * tui/tui-layout.c (show_layout, show_data): Update.
2797         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2798         (tui_add_to_source_windows): Don't declare.
2799         * tui/tui-data.c (source_windows, tui_source_windows)
2800         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2801
2802 2019-08-15  Tom Tromey  <tom@tromey.com>
2803
2804         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2805         Rename from reset.
2806         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2807         * tui/tui-layout.c (show_source_disasm_command, show_data):
2808         Update.
2809         (tui_gen_win_info::resize): Rename.
2810         (show_source_or_disasm_and_command): Update.
2811         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2812         reset.
2813
2814 2019-08-15  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2817         * tui/tui-interp.c (tui_interp::init): Don't call
2818         tui_initialize_static_data.
2819         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2820
2821 2019-08-15  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2824         examine tui_win_list.
2825
2826 2019-08-15  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2829         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2830         tui_clear_source_content.
2831         (tui_clear_source_content): Remove.
2832         (tui_source_window_base::do_erase_source_content): Hoist call to
2833         content.clear().
2834         * tui/tui-stack.c (tui_show_frame_info): Don't call
2835         tui_clear_source_content.
2836
2837 2019-08-15  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-winsource.h (struct tui_source_window_base)
2840         <do_erase_source_content>: New method.
2841         <erase_source_content>: New method.
2842         (tui_erase_source_content): Don't declare.
2843         * tui/tui-winsource.c (tui_clear_source_content): Update.
2844         (tui_source_window_base::do_erase_source_content): Rename from
2845         tui_erase_source_content.
2846         (tui_source_window_base::show_source_content): Update.
2847         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2848         * tui/tui-source.h (struct tui_source_window)
2849         <erase_source_content>: New method.
2850         * tui/tui-disasm.h (struct tui_disasm_window)
2851         <erase_source_content>: New method.
2852
2853 2019-08-15  Tom Tromey  <tom@tromey.com>
2854
2855         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2856         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2857         constructor.
2858         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2859         * tui/tui-source.c (tui_set_source_content): Update.
2860         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2861
2862 2019-08-15  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2865         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2866         tui-source.c.
2867         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2868         Declare.
2869         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2870         method.
2871         (tui_source_window::maybe_update): Update.
2872
2873 2019-08-15  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2876         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2877         tui-disasm.c.
2878         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2879         Declare.
2880         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2881         method.
2882         (tui_disasm_window::maybe_update): Update.
2883
2884 2019-08-15  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-winsource.h (struct tui_source_window_base)
2887         <maybe_update>: Declare.
2888         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2889         method.
2890         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2891         Declare.
2892         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2893         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2894         Declare.
2895         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2896
2897 2019-08-15  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2900
2901 2019-08-15  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-wingeneral.c: Include tui-stack.h.
2904         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2905         (struct tui_locator_window): Move from tui-data.h.
2906         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2907         (tui_initialize_static_data): Move from tui-data.c.
2908         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2909         (struct tui_locator_window): Move to tui-stack.c.
2910         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2911         (tui_initialize_static_data): Move to tui-stack.c.
2912
2913 2019-08-15  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-layout.c (show_source_disasm_command)
2916         (show_source_or_disasm_and_command): Use make_visible method, not
2917         tui_make_window.
2918         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2919         Remove.
2920
2921 2019-08-15  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-wingeneral.h (tui_make_window): Update.
2924         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2925         parameter.
2926         (tui_gen_win_info::make_visible): Update.
2927         * tui/tui-regs.c (tui_data_window::display_registers_from):
2928         Update.
2929         * tui/tui-layout.c (show_source_disasm_command)
2930         (show_source_or_disasm_and_command): Update.
2931         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2932         (enum tui_box): Remove.
2933         (struct tui_win_info) <can_box>: New method.
2934         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2935         method.
2936
2937 2019-08-15  Tom de Vries  <tdevries@suse.de>
2938
2939         * linux-nat-trad.c: Include gdbarch.h.
2940
2941 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2942
2943         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2944         register sizes.
2945
2946 2019-08-14  Tom Tromey  <tromey@adacore.com>
2947
2948         * darwin-nat.c: Include gdbarch.h.
2949         * darwin-nat-info.c: Include gdbarch.h.
2950
2951 2019-08-13  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2954         Remove.
2955         * tui/tui-data.c (tui_initialize_static_data): Update.
2956
2957 2019-08-13  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-winsource.h (struct tui_exec_info_window)
2960         <~tui_exec_info_window, maybe_allocate_content, get_content,
2961         m_content>: Remove.
2962         (struct tui_source_window_base) <set_exec_info_content,
2963         show_exec_info_content>: Don't declare.
2964         * tui/tui-winsource.c
2965         (tui_exec_info_window::maybe_allocate_content): Remove.
2966         (tui_source_window_base::update_exec_info): Rename from
2967         set_exec_info_content.
2968         (tui_source_window_base::show_exec_info_content)
2969         (tui_source_window_base::update_exec_info): Remove.
2970
2971 2019-08-13  Tom Tromey  <tom@tromey.com>
2972
2973         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2974         declare.
2975         * tui/tui-winsource.c (tui_update_source_window_as_is)
2976         (tui_update_source_windows_with_addr, tui_erase_source_content):
2977         Update.
2978         (tui_clear_exec_info_content): Remove.
2979
2980 2019-08-13  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2983         declare.
2984         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2985         call tui_erase_exec_info_content.
2986         (tui_clear_exec_info_content): Rename from
2987         tui_erase_exec_info_content.
2988         (tui_clear_exec_info_content): Delete.
2989
2990 2019-08-13  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-winsource.h (struct tui_source_window_base)
2993         <show_exec_info_content>: Declare.
2994         (tui_show_exec_info_content): Don't declare.
2995         * tui/tui-winsource.c
2996         (tui_source_window_base::show_exec_info_content): Rename from
2997         tui_show_exec_info_content.
2998         (tui_source_window_base::update_exec_info): Update.
2999
3000 2019-08-13  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3003         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3004         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3005         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3006         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3007         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3008         ... here.
3009
3010 2019-08-13  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-winsource.h (struct tui_source_window_base)
3013         <update_exec_info>: Declare.
3014         (tui_update_exec_info): Don't declare.
3015         * tui/tui-winsource.c (tui_update_source_window_as_is)
3016         (tui_source_window_base::refresh_all)
3017         (tui_update_all_breakpoint_info): Update.
3018         (tui_source_window_base::update_exec_info): Rename from
3019         tui_update_exec_info.
3020         * tui/tui-stack.c (tui_show_frame_info): Update.
3021
3022 2019-08-13  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-winsource.h (struct tui_source_window_base)
3025         <set_exec_info_content>: Declare.
3026         (tui_set_exec_info_content): Don't declare.
3027         * tui/tui-winsource.c
3028         (tui_source_window_base::set_exec_info_content): Rename from
3029         tui_set_exec_info_content.
3030         (tui_update_exec_info): Update.
3031
3032 2019-08-13  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-winsource.h (struct tui_source_window_base)
3035         <show_source_content>: Declare.
3036         (tui_show_source_content): Don't declare.
3037         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3038         (tui_source_window_base::show_source_content): Rename from
3039         tui_show_source_content.
3040         (tui_source_window_base::refresh_all): Update.
3041         * tui/tui-layout.c (show_source_disasm_command)
3042         (show_source_or_disasm_and_command): Update.
3043
3044 2019-08-13  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-winsource.c (tui_erase_source_content)
3047         (tui_show_source_content, tui_source_window_base::refresh_all):
3048         Update.
3049         * tui/tui-wingeneral.h
3050         (tui_check_and_display_highlight_if_needed): Don't declare.
3051         * tui/tui-wingeneral.c
3052         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3053         check_and_display_highlight_if_needed.
3054         * tui/tui-win.c (tui_rehighlight_all)
3055         (tui_win_info::make_visible_with_new_height): Update.
3056         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3057         (tui_data_window::erase_data_content)
3058         (tui_data_window::display_all_data): Update.
3059         * tui/tui-data.h (struct tui_win_info)
3060         <check_and_display_highlight_if_needed>: Declare.
3061
3062 2019-08-13  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-win.c (tui_resize_all): Call
3065         tui_delete_invisible_windows.
3066         * tui/tui-layout.c (show_layout): Call
3067         tui_delete_invisible_windows.
3068         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3069         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3070
3071 2019-08-13  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3074         tui_add_win_to_layout.
3075
3076 2019-08-13  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3079         * tui/tui-layout.c (tui_default_win_height): Now static.
3080
3081 2019-08-13  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3084         single switch.
3085         (show_source_disasm_command, show_source_or_disasm_and_command):
3086         Don't check current layout.
3087
3088 2019-08-13  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-wingeneral.c (make_all_visible): Remove.
3091         (tui_make_all_invisible): Simplify.
3092         * tui/tui-layout.c (tui_make_all_invisible): Move from
3093         tui-wingeneral.c; simplify.
3094         (show_layout): Hoist call to tui_make_all_invisible.
3095         (show_data): Don't call tui_make_all_invisible.
3096
3097 2019-08-13  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3100         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3101
3102 2019-08-13  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3105         tui-data.c.
3106         (show_source_disasm_command, show_data)
3107         (show_source_or_disasm_and_command): Don't use
3108         tui_set_current_layout_to.
3109         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3110         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3111         tui-layout.c.
3112         (tui_set_current_layout_to): Remove.
3113
3114 2019-08-13  Tom Tromey  <tom@tromey.com>
3115
3116         * tui/tui-layout.c (tui_set_layout): Update.
3117         * tui/tui-data.h (struct tui_layout_def): Remove.
3118         (tui_layout_def): Don't declare.
3119         * tui/tui-data.c (layout_def): Remove.
3120         (tui_layout_def): Remove.
3121
3122 2019-08-13  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-winsource.h (struct tui_source_window_base)
3125         <clear_detail>: No longer "override".
3126         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3127         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3128         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3129         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3130         Remove.
3131         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3132
3133 2019-08-13  Tom Tromey  <tromey@adacore.com>
3134
3135         * tracepoint.c: Don't include readline.h or history.h.
3136
3137 2019-08-12  Tom Tromey  <tom@tromey.com>
3138
3139         * configure: Rebuild.
3140         * configure.ac: Check for readline 7.
3141         * NEWS: Mention readline 7 requirement.
3142         * README: Update.
3143
3144 2019-08-12  Tom Tromey  <tom@tromey.com>
3145
3146         * mingw-hdep.c (gdb_select): Remove readline hack.
3147
3148 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3149
3150         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3151         when the function fails.
3152
3153 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3154
3155         * s390-tdep.c (s390_type_align): New function.
3156         (s390_gdbarch_init): Set it as type_align gdbarch method.
3157
3158 2019-08-09  Tom de Vries  <tdevries@suse.de>
3159
3160         PR gdb/24591
3161         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3162         pc_low with relocation offset.
3163
3164 2019-08-07  Tom Tromey  <tromey@adacore.com>
3165
3166         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3167         (print_frame_args): Update.
3168         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3169         Update.
3170         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3171         * frame.h (struct frame_arg): Add initializers.
3172         <error>: Now a unique_xmalloc_ptr.
3173
3174 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3175
3176         * NEWS: Expand the Pointer Authentication entry.
3177         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3178         (aarch64_frame_unmask_lr): ... to this.
3179         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3180         Call aarch64_frame_unmask_lr.
3181         * frame.c (struct frame_info): Add "masked" variable.
3182         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3183         (fprint_frame): Check for masked pc.
3184         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3185         declarations.
3186         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3187         * stack.c (print_frame): Check for masked pc.
3188
3189 2019-08-06  Tom Tromey  <tom@tromey.com>
3190
3191         * stabsread.c (patch_block_stabs, read_one_struct_field)
3192         (read_enum_type): Use obstack_strndup.
3193         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3194         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3195         * dwarf2read.c (guess_full_die_structure_name)
3196         (anonymous_struct_prefix): Use obstack_strndup.
3197         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3198         * c-exp.y (yylex): Use obstack_strndup.
3199         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3200         (write_var_or_type): Use obstack_strndup.
3201
3202 2019-08-06  Tom Tromey  <tom@tromey.com>
3203
3204         * symfile.c (reread_symbols): Use obstack_strdup.
3205         * stabsread.c (read_type): Use obstack_strdup.
3206         * gdb_obstack.h (obstack_strdup): New overload.
3207         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3208         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3209         (dwarf2_canonicalize_name): Use obstack_strdup.
3210         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3211         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3212         Use obstack_strdup.
3213
3214 2019-08-06  Tom Tromey  <tom@tromey.com>
3215
3216         * gdb_obstack.h (obstack_strdup): Define.
3217         * gdb_obstack.c (obstack_strdup): Don't define.
3218
3219 2019-08-06  Tom Tromey  <tom@tromey.com>
3220
3221         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3222         obstack_strdup.
3223         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3224         obstack_strdup.
3225         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3226         * stabsread.c (common_block_start): Use obstack_strdup.
3227         * objfiles.c (set_objfile_main_name, objfile): Use
3228         obstack_strdup.
3229         * namespace.c (add_using_directive): Use obstack_strdup.
3230         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3231         * jit.c (finalize_symtab): Use obstack_strdup.
3232         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3233         (guess_partial_die_structure_name, partial_die_info::fixup)
3234         (dwarf2_name): Use obstack_strdup.
3235         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3236         obstack_strdup.
3237         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3238         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3239         obstack_strdup.
3240         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3241
3242 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3243
3244         * unittests/help-doc-selftests.c: New file.
3245         * Makefile.in: Add the new file.
3246
3247 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3248
3249         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3250         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3251         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3252         the trailing '.' is not output, and the first character is uppercased.
3253         (print_help_for_command): Update call to print_doc_line.
3254         (print_doc_of_command): Likewise.
3255         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3256         * cli/cli-option.c (append_indented_doc): Do not append newline.
3257         (build_help_option): Append newline after first appended_indented_doc
3258         only if a second call is done.
3259         (build_help): Append 2 new lines before each option, except the first
3260         one.
3261         * compile/compile.c (_initialize_compile): Add new lines after
3262         %OPTIONS%, when not at the end of the help.
3263         Change help doc or code
3264         producing the help doc to respect the invariants.
3265         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3266         Also removed the new line after 'Options:', as all other commands
3267         do not put an empty line between 'Options:' and the first option.
3268         * printcmd.c (_initialize_printcmd): Likewise.
3269         * stack.c (_initialize_stack): Likewise.
3270         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3271         incorrectly telling COMMAND is optional.
3272         * ada-lang.c (_initialize_ada_language): Change help doc or code
3273         producing the help doc to respect the invariants.
3274         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3275         * breakpoint.c (_initialize_breakpoint): Likewise.
3276         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3277         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3278         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3279         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3280         _initialize_cli_style): Likewise.
3281         * corelow.c (core_target_info): Likewise.
3282         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3283         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3284         * filesystem.c (_initialize_filesystem): Likewise.
3285         * frame.c (_initialize_frame): Likewise.
3286         * gnu-nat.c (add_task_commands): Likewise.
3287         * infcall.c (_initialize_infcall): Likewise.
3288         * infcmd.c (_initialize_infcmd): Likewise.
3289         * interps.c (_initialize_interpreter): Likewise.
3290         * language.c (_initialize_language): Likewise.
3291         * linux-fork.c (_initialize_linux_fork): Likewise.
3292         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3293         * maint.c (_initialize_maint_cmds): Likewise.
3294         * memattr.c (_initialize_mem): Likewise.
3295         * printcmd.c (_initialize_printcmd): Likewise.
3296         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3297         _RegEx): Likewise.
3298         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3299         * record-btrace.c (_initialize_record_btrace): Likewise.
3300         * record-full.c (_initialize_record_full): Likewise.
3301         * record.c (_initialize_record): Likewise.
3302         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3303         * regcache.c (_initialize_regcache): Likewise.
3304         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3305         _initialize_remote): Likewise.
3306         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3307         * serial.c (_initialize_serial): Likewise.
3308         * skip.c (_initialize_step_skip): Likewise.
3309         * source.c (_initialize_source): Likewise.
3310         * stack.c (_initialize_stack): Likewise.
3311         * symfile.c (_initialize_symfile): Likewise.
3312         * symtab.c (_initialize_symtab): Likewise.
3313         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3314         * top.c (init_main): Likewise.
3315         * tracefile-tfile.c (tfile_target_info): Likewise.
3316         * tracepoint.c (_initialize_tracepoint): Likewise.
3317         * tui/tui-win.c (_initialize_tui_win): Likewise.
3318         * utils.c (add_internal_problem_command): Likewise.
3319         * valprint.c (value_print_option_defs): Likewise.
3320
3321 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3322
3323         PR build/24886
3324         * configure.ac: Drop enable-libmcheck support.
3325         * configure, config.in: Rebuild.
3326         * libmcheck.m4: Remove.
3327         * acinclude.m4: Don't include it.
3328         * Makefile.in: Don't distribute it.
3329         * top.c (print_gdb_configuration): Don't mention it.
3330
3331 2019-08-06  Tom Tromey  <tom@tromey.com>
3332
3333         * utils.c (set_output_style): Sometimes pass stream to
3334         emit_style_escape.
3335         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3336         * record-btrace.c (btrace_insn_history): Update.
3337         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3338         method.
3339         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3340         Update initializers.
3341         <m_uiout>: New field.
3342         <m_di>: Move lower.
3343         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3344         Remove "uiout" parameter.
3345         (dump_insns): Update.
3346         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3347         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3348
3349 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3350
3351         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3352         (error_in_psymtab_expansion): Likewise.
3353         (lookup_symbol_via_quick_fns): Likewise.
3354         (basic_lookup_transparent_type_quick): Likewise.
3355         (basic_lookup_transparent_type_1): Likewise.
3356
3357 2019-08-06  Tom Tromey  <tromey@adacore.com>
3358
3359         * source.c (last_source_error): Now bool.
3360         (print_source_lines_base): Make "noprint" bool.  Only open
3361         source file when last_source_visited changes.
3362
3363 2019-08-06  Tom Tromey  <tromey@adacore.com>
3364
3365         * annotate.c (annotate_source_line): Use g_source_cache.
3366         * source-cache.c (source_cache::get_plain_source_lines): Change
3367         parameters.  Populate m_offset_cache.
3368         (source_cache::ensure): New method.
3369         (source_cache::get_line_charpos): New method.
3370         (extract_lines): Move lower.  Change parameters.
3371         (source_cache::get_source_lines): Move lower.
3372         * source-cache.h (class source_cache): Update comment.
3373         <get_line_charpos>: New method.
3374         <get_source_lines>: Update comment.
3375         <clear>: Clear m_offset_cache.
3376         <get_plain_source_lines>: Change parameters.
3377         <ensure>: New method
3378         <m_offset_cache>: New member.
3379         * source.c (forget_cached_source_info_for_objfile): Update.
3380         (info_source_command): Use g_source_cache.
3381         (find_source_lines, open_source_file_with_line_charpos): Remove.
3382         (print_source_lines_base, search_command_helper): Use g_source_cache.
3383         * source.h (open_source_file_with_line_charpos): Don't declare.
3384         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3385         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3386         Use g_source_cache.
3387
3388 2019-08-06  Tom Tromey  <tromey@adacore.com>
3389
3390         * source-cache.c (source_cache::get_plain_source_lines):
3391         Remove "first_line" and "last_line" parameters.
3392         (source_cache::get_source_lines): Cache plain text.
3393         * source-cache.h (class source_cache)
3394         <get_plain_source_lines>: Update.
3395
3396 2019-08-06  Tom Tromey  <tromey@adacore.com>
3397
3398         * source-cache.c (extract_lines): No longer a method.
3399         Changed type of parameter.  Include final newline.
3400         (selftests::extract_lines_test): New function.
3401         (_initialize_source_cache): Likewise.
3402         * source-cache.h (class source_cache)
3403         <extract_lines>: Don't declare.
3404
3405 2019-08-06  Tom Tromey  <tromey@adacore.com>
3406
3407         * breakpoint.c (init_breakpoint_sal): Update.
3408         (breakpoint): Update.
3409         * breakpoint.h (struct breakpoint) <filter>: Now a
3410         unique_xmalloc_ptr.
3411
3412 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3413
3414         * NEWS: Mention dictionary access on blocks.
3415         * python/py-block.c (blpy_getitem): New function.
3416         (block_object_as_mapping): New struct.
3417         (block_object_type): Use new struct for tp_as_mapping field.
3418
3419 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3420
3421         * objfiles.h (objfile): Add a comment describing partial symbols.
3422
3423 2019-08-05  Tom Tromey  <tromey@adacore.com>
3424
3425         * compile/compile.c (_initialize_compile): Use _(), not N_().
3426         * thread.c (_initialize_thread): Use _(), not N_().
3427         * stack.c (_initialize_stack): Use _(), not N_().
3428         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3429
3430 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3431
3432         * dwarf2read.c (struct dw2_symtab_iterator):
3433         <want_specific_block>: Remove.
3434         <block_index>: Change type to gdb::optional.
3435         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3436         change type of BLOCK_INDEX parameter to gdb::optional.
3437         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3438         (dw2_lookup_symbol): Don't pass argument for
3439         WANT_SPECIFIC_BLOCK.
3440         (dw2_expand_symtabs_for_function): Don't pass argument for
3441         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3442         (class dw2_debug_names_iterator)
3443         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3444         parameter, change BLOCK_INDEX type to gdb::optional.
3445         <m_want_specific_block>: Remove.
3446         <m_block_index>: Change type to gdb::optional.
3447         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3448         gdb::optional.  Re-write in function of gdb::optional.
3449         (dw2_debug_names_lookup_symbol): Don't pass argument for
3450         WANT_SPECIFIC_BLOCK.
3451         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3452         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3453         BLOCK_INDEX.
3454
3455 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3456
3457         * NEWS: Mention changes to "info sources" command.
3458
3459 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3460
3461         * symtab.c (filename_partial_match_opts): New struct type.
3462         (struct output_source_filename_data): New members
3463         regexp, c_regexp, partial_match.
3464         (output_source_filename): Use new members to decide to print file.
3465         (info_sources_option_defs): New variable.
3466         (make_info_sources_options_def_group, print_info_sources_header,
3467         info_sources_command_completer):
3468         New functions.
3469         (info_sources_command): Read new optional arguments.
3470         (_initialize_symtab): Update info sources help.
3471
3472 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3473
3474         * ada-lang.c (exception_support_info_v0): Renamed from...
3475         (default_exception_support_info): ... this.  Create new
3476         definition for v1.
3477         (ada_has_this_exception_support): Look up catch_handlers_sym.
3478         (ada_exception_support_info_sniffer): Try v0 after default.
3479
3480 2019-08-01  Tom Tromey  <tromey@adacore.com>
3481
3482         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3483         gdbarch.h.
3484
3485 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3486
3487         * s12z-tdep.c: Fix include path for s12z-opc.h.
3488
3489 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3490
3491         * NEWS: Require GNU make 3.82.
3492
3493 2019-07-16  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3496         declare.
3497
3498 2019-07-30  Tom Tromey  <tromey@adacore.com>
3499
3500         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3501
3502 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3503
3504         * printcmd.c (print_address_symbolic): Print negative offsets.
3505         (build_address_symbolic): Force signed arithmetic when computing
3506         offset.
3507
3508 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3509
3510         PR/24474: Add a function to lookup static variables.
3511         * NEWS: Mention this new function.
3512         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3513         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3514         * python/python.c (python_GdbMethods): Add new function.
3515
3516 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3517
3518         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3519         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3520         (objfpy_lookup_static_symbol): New function.
3521         (objfile_object_methods): Add new functions.
3522
3523 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3524
3525         * NEWS: Mention 'set|show print frame-info'.  Mention new
3526         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3527         backtrace argument.  Mention that python frame filtering code
3528         is now consistent with what 'backtrace' command prints.
3529
3530 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3531
3532         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3533         comments.
3534         (print_frame_info_auto, print_frame_info_source_line,
3535         print_frame_info_location, print_frame_info_source_and_location,
3536         print_frame_info_location_and_address, print_frame_info_short_location):
3537         New declarations.
3538         (struct frame_print_options): New member print_frame_info.
3539         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3540         * stack.h (get_user_print_what_frame_info): New declaration.
3541         (frame_show_address): New declaration.
3542         * stack.c (print_frame_arguments_choices): New value 'presence'.
3543         (print_frame_info_auto, print_frame_info_source_line,
3544         print_frame_info_location, print_frame_info_source_and_location,
3545         print_frame_info_location_and_address, print_frame_info_short_location,
3546         print_frame_info_choices, print_frame_info_print_what): New definitions.
3547         (print_frame_args): Only print dots for args if print frame-arguments
3548         is 'presence'.
3549         (frame_print_option_defs): New element for "frame-info".
3550         (get_user_print_what_frame_info): New function.
3551         (frame_show_address): Make non static.  Move comment to stack.h.
3552         (print_frame_info_to_print_what): New function.
3553         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3554         to decide what to print.
3555         (backtrace_command_1): Handle the new print_frame_arguments_presence
3556         value.
3557         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3558         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3559         (py_print_frame): In non-mi mode, use LOCATION as default for
3560         print_what, similarly to frame information printed directly by
3561         backtrace command. Handle frame-info user option in non MI mode.
3562
3563 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3564
3565         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3566         Add case for debugging 32-bit target on 64-bit host.  Revise
3567         comment.
3568
3569 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3570
3571         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3572         instead of find_function_entry_range_from_pc.
3573
3574 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3575
3576         * stack.c (find_frame_funname): Remove code which preferred
3577         minsym over symtab sym in "certain pathological cases".
3578
3579         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3580         parameter.  Change type of "do_demangle" to bool.
3581         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3582         Pass suitable "prefer_sym_over_minsym" flag to
3583         build_address_symbolic().  Don't output "+" for negative offsets.
3584         * printcmd.c (print_address_symbolic): Update invocation of
3585         build_address_symbolic to include a "prefer_sym_over_minsym"
3586         flag.
3587         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3588         Restrict cases in which use of minimal symbol is preferred to that
3589         of a found symbol.  Update comments.
3590
3591         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3592         for entry pc when entry pc is out of range for that FDE.
3593
3594 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3595
3596         PR gdb/24839:
3597         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3598         type.
3599
3600 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3601
3602         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3603         this function's Python signature.
3604
3605
3606 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3607
3608         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3609         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3610         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3611         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3612         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3613
3614
3615 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3616
3617         * h8300-tdep.c (h8300_register_name_common): New.
3618         h8300_register_name): Use h8300_register_name_common.
3619         (h8300s_register_name): Likewise.
3620         (h8300sx_register_name): Likewise.
3621         (h8300h_register_nam): New.
3622         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3623
3624
3625 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3626
3627         * arm-tdep.c (arm_skip_cmse_entry): New function.
3628         (arm_is_sgstubs_section): New function.
3629         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3630
3631 2019-07-22  Tom Tromey  <tom@tromey.com>
3632
3633         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3634         Don't self-assign.
3635
3636 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3637
3638         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3639         type_print.
3640
3641 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3642
3643         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3644         so that GDB doesn't match any msymbols when searching in the
3645         TYPES_DOMAIN.
3646         (print_symbol_info): Print using typedef_print or type_print based
3647         on the type of the symbol.  Add updated FIXME comment moved from...
3648         (_initialize_symtab): ... move and update FIXME comment to above.
3649
3650 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3651
3652         * NEWS: Mention adding -q option to "info types".
3653         * symtab.c (struct info_types_options): New struct.
3654         (info_types_options_defs): New variable.
3655         (make_info_types_options_def_group): New function.
3656         (info_types_command): Use gdb::option framework to parse options.
3657         (info_types_command_completer): New function.
3658         (_initialize_symtab): Extend the help text on "info types" and
3659         register command completer.
3660
3661 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3662
3663         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3664         (lookup_symbol_in_objfile): Change int to block_enum and add a
3665         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3666
3667 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3668
3669         * MAINTAINERS (Write After Approval): Add self.
3670
3671 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3672
3673         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3674         instruction to the dummy code region.
3675
3676 2019-07-19  Tom Tromey  <tromey@adacore.com>
3677
3678         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3679         (ARGSUSED, PARAMS, __func__): Remove rules.
3680
3681 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3682
3683         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3684         * features/arm/arm-with-iwmmxt.c: Remove.
3685         * features/arm/arm-with-iwmmxt.xml: Remove.
3686         * features/arm/arm-with-m-fpa-layout.c: Remove.
3687         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3688         * features/arm/arm-with-m-vfp-d16.c: Remove.
3689         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3690         * features/arm/arm-with-m.c: Remove.
3691         * features/arm/arm-with-m.xml: Remove.
3692         * features/arm/arm-with-neon.c: Remove.
3693         * features/arm/arm-with-neon.xml: Remove.
3694         * features/arm/arm-with-vfpv2.c: Remove.
3695         * features/arm/arm-with-vfpv2.xml: Remove.
3696         * features/arm/arm-with-vfpv3.c: Remove.
3697         * features/arm/arm-with-vfpv3.xml: Remove.
3698
3699 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3700
3701         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3702
3703 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3704
3705         * arch/aarch32.c (aarch32_create_target_description): Create
3706         target descriptions using features.
3707         * arch/arm.c (arm_create_target_description)
3708         (arm_create_mprofile_target_description): Likewise.
3709         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3710
3711 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3712
3713         * Makefile.in: Add new files.
3714         * aarch32-tdep.c: New file.
3715         * aarch32-tdep.h: New file.
3716         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3717         Call aarch32_read_description.
3718         * arch/aarch32.c: New file.
3719         * arch/aarch32.h: New file.
3720         * arch/arm.c (arm_create_target_description)
3721         (arm_create_mprofile_target_description): New function.
3722         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3723         (arm_create_target_description)
3724         (arm_create_mprofile_target_description): New declaration.
3725         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3726         read_description functions.
3727         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3728         Likewise.
3729         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3730         * arm-tdep.c (tdesc_arm_list): New variable.
3731         (arm_register_g_packet_guesses): Call create description functions.
3732         (arm_read_description) (arm_read_mprofile_description): New
3733         function.
3734         * arm-tdep.h (arm_read_description)
3735         (arm_read_mprofile_description): Add declaration.
3736         * configure.tgt: Add new files.
3737
3738 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3739
3740         * top.c (new_ui_command): Open specified terminal just once.
3741
3742 2019-07-18  Tom Tromey  <tromey@adacore.com>
3743
3744         * symtab.c (main_name): Constify return type.
3745         * symfile.c (set_initial_language): Update.
3746         * symtab.h (main_name): Constify return type.
3747
3748 2019-07-17  Tom Tromey  <tom@tromey.com>
3749
3750         * tui/tui-winsource.c (tui_update_source_window)
3751         (tui_update_source_window_as_is)
3752         (tui_update_source_windows_with_line): Remove return.
3753         * tui/tui-disasm.c (tui_show_disassem)
3754         (tui_show_disassem_and_update_source): Remove return.
3755         * tui/tui.c (tui_reset): Remove return.
3756         * tui/tui-wingeneral.c
3757         (tui_check_and_display_highlight_if_needed): Remove return.
3758
3759 2019-07-17  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3762
3763 2019-07-17  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-winsource.h (struct tui_exec_info_window)
3766         (struct tui_source_window_base): Move from tui-data.h.
3767         * tui/tui-winsource.c: Move many method definitions from
3768         elsewhere.  Remove "structuring" comments.
3769         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3770         (tui_source_window_base::refresh_window): Move to
3771         tui-winsource.c.
3772         * tui/tui-win.c (tui_source_window_base::refresh_all)
3773         (tui_source_window_base::update_tab_width)
3774         (tui_source_window_base::set_new_height)
3775         (tui_source_window_base::do_make_visible_with_new_height): Move to
3776         tui-winsource.c.
3777         * tui/tui-source.h: Update.
3778         * tui/tui-source.c (tui_source_window_base::reset): Move to
3779         tui-winsource.c.
3780         * tui/tui-disasm.h: Update.
3781         * tui/tui-data.h (struct tui_exec_info_window): Move to
3782         tui-winsource.h.
3783         (struct tui_source_window_base): Likewise.
3784         * tui/tui-data.c (tui_source_window_base::clear_detail)
3785         (tui_source_window_base, ~tui_source_window_base): Move to
3786         tui-winsource.c.
3787
3788 2019-07-17  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-win.c (tui_resize_all)
3791         (tui_source_window_base::update_tab_width)
3792         (tui_adjust_win_heights): Update.
3793         (tui_win_info::make_invisible_and_set_new_height): Rename from
3794         make_invisible_and_set_new_height.
3795         * tui/tui-data.h (struct tui_win_info)
3796         <make_invisible_and_set_new_height>: New method.
3797
3798 2019-07-17  Tom Tromey  <tom@tromey.com>
3799
3800         * tui/tui.c: Update.
3801         * tui/tui-source.h (struct tui_source_window): Move from
3802         tui-data.h.
3803         * tui/tui-layout.c: Update.
3804         * tui/tui-disasm.c: Update.
3805         * tui/tui-data.h (struct tui_source_window): Move to
3806         tui-source.h.
3807
3808 2019-07-17  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3811         tui-data.h.
3812         * tui/tui-data.h (struct tui_disasm_window): Move to
3813         tui-disasm.h.
3814
3815 2019-07-17  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-regs.h (struct tui_data_item_window): Move from
3818         tui-data.h.
3819         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3820         * tui/tui-data.h (struct tui_data_item_window): Move to
3821         tui-regs.h.
3822         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3823
3824 2019-07-17  Tom Tromey  <tom@tromey.com>
3825
3826         * tui/tui.c: Update.
3827         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3828         (tui_cmd_window::max_height): Move to tui-command.c.
3829         * tui/tui-layout.c: Update.
3830         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3831         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3832         tui-command.c.
3833         * tui/tui-command.h (struct tui_cmd_window): Move from
3834         tui-data.h.
3835         * tui/tui-command.c: Remove "structuring" comments.
3836         (tui_cmd_window::clear_detail)
3837         (tui_cmd_window::do_make_visible_with_new_height)
3838         (tui_cmd_window::max_height): Move from elsewhere.
3839
3840 2019-07-17  Tom Tromey  <tom@tromey.com>
3841
3842         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3843         Now static.
3844         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3845         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3846
3847 2019-07-17  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui.c: Update.
3850         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3851         tui-regs.c.
3852         * tui/tui-windata.h: Remove file.
3853         * tui/tui-windata.c: Remove file.
3854         * tui/tui-win.c (tui_data_window::set_new_height)
3855         (tui_data_window::do_make_visible_with_new_height): Move to
3856         tui-regs.c.
3857         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3858         * tui/tui-regs.c: Remove "structuring" comments.
3859         (tui_data_window::first_data_item_displayed)
3860         (tui_data_window::delete_data_content_windows)
3861         (tui_data_window::erase_data_content)
3862         (tui_data_window::display_all_data)
3863         (tui_data_window::refresh_all)
3864         (tui_data_window::do_scroll_vertical)
3865         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3866         (tui_data_window::do_make_visible_with_new_height)
3867         (tui_data_window::refresh_window): Move from elsewhere.
3868         (_initialize_tui_regs): Move to end of file.
3869         * tui/tui-layout.c: Update.
3870         * tui/tui-hooks.c: Update.
3871         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3872         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3873         tui-regs.c.
3874         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3875
3876 2019-07-17  Tom Tromey  <tom@tromey.com>
3877
3878         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3879         seen.
3880
3881 2019-07-17  Tom Tromey  <tom@tromey.com>
3882
3883         * tui/tui-win.c (tui_source_window_base::set_new_height)
3884         (tui_source_window_base::do_make_visible_with_new_height): Use
3885         m_has_locator field directly.
3886         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3887         method.
3888         (struct tui_source_window_base) <has_locator>: Likewise.
3889
3890 2019-07-17  Tom Tromey  <tom@tromey.com>
3891
3892         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3893         Don't declare.
3894         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3895         Remove.
3896         * tui/tui-win.c (tui_source_window_base::set_new_height)
3897         (tui_source_window_base::set_new_height)
3898         (make_invisible_and_set_new_height)
3899         (tui_source_window_base::do_make_visible_with_new_height)
3900         (tui_source_window_base::do_make_visible_with_new_height):
3901         Update.
3902         * tui/tui-layout.c (show_source_disasm_command, show_data)
3903         (show_source_or_disasm_and_command): Update.
3904         * tui/tui-layout.c (show_layout): Update.
3905
3906 2019-07-17  Tom Tromey  <tom@tromey.com>
3907
3908         * tui/tui-layout.c (make_data_window): Remove.
3909         (show_data): Unify creation and re-initialization cases.
3910
3911 2019-07-17  Tom Tromey  <tom@tromey.com>
3912
3913         * tui/tui-layout.c (make_source_window, make_disasm_window):
3914         Remove.
3915         (show_data): Unify creation and re-initialization cases.
3916
3917 2019-07-17  Tom Tromey  <tom@tromey.com>
3918
3919         * tui/tui-layout.c (make_command_window): Remove.
3920         (show_source_disasm_command, show_source_or_disasm_and_command):
3921         Unify creation and re-initialization cases.
3922
3923 2019-07-17  Tom Tromey  <tom@tromey.com>
3924
3925         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3926         creation and re-initialization cases.
3927
3928 2019-07-17  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-regs.c (tui_get_register): Return void.
3931
3932 2019-07-17  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3935         Simplify.
3936
3937 2019-07-17  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3940         resetting.
3941
3942 2019-07-17  Tom Tromey  <tom@tromey.com>
3943
3944         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3945         * tui/tui-regs.c (tui_reg_layout): New function.
3946         (tui_show_registers, tui_reg_command): Use it.
3947         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3948         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3949         parameters.
3950         (tui_layout_command): Remove.
3951
3952 2019-07-17  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-layout.h (tui/tui-layout): Return void.
3955         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3956
3957 2019-07-17  Tom Tromey  <tom@tromey.com>
3958
3959         * tui/tui-layout.c (show_source_disasm_command, show_data):
3960         Update.
3961         (reset_locator): Remove.
3962         (show_source_or_disasm_and_command): Update.
3963
3964 2019-07-17  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-source.c (tui_source_window_base::reset): Remove
3967         win_type parameter.
3968         * tui/tui-layout.c (make_command_window, make_source_window)
3969         (make_disasm_window, make_data_window)
3970         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3971         (reset_locator, show_source_or_disasm_and_command): Update.
3972         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3973         win_type parameter.
3974         (struct tui_source_window_base) <reset>: Likewise.
3975
3976 2019-07-17  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-layout.c (show_source_disasm_command): Use
3979         reset_locator.
3980         (reset_locator): New function.
3981         (init_and_make_win): Remove.
3982         (show_source_or_disasm_and_command): Use reset_locator.
3983
3984 2019-07-17  Tom Tromey  <tom@tromey.com>
3985
3986         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3987         condition.
3988         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3989         Remove condition.
3990         * tui/tui-source.c (tui_source_window_base::reset): New method.
3991         * tui/tui-layout.c (make_command_window): Don't call
3992         init_and_make_win.
3993         (make_source_window, make_disasm_window): Don't call
3994         make_source_or_disasm_window.
3995         (make_data_window): Don't call init_and_make_win.  Change calling
3996         convention.
3997         (show_source_disasm_command, show_data): Simplify.
3998         (make_source_or_disasm_window): Remove.
3999         (show_source_or_disasm_and_command): Simplify.
4000         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4001         (struct tui_source_window_base) <reset>: Likewise.
4002         <execution_info>: Remove initializer.
4003         * tui/tui-data.c (tui_source_window_base): Initialize
4004         execution_info.
4005
4006 2019-07-17  Tom Tromey  <tom@tromey.com>
4007
4008         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4009         variable.
4010
4011 2019-07-17  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui.c (tui_rl_other_window): Update.
4014         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4015         superclass method first.  Always iterate over regs_content.
4016         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4017         method.
4018         * tui/tui-win.c (tui_set_focus_command): Update.
4019
4020 2019-07-17  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-win.c (tui_set_focus_command): Rename from
4023         tui_set_focus.  Call tui_enable.
4024         (tui_set_focus_command): Remove.
4025
4026 2019-07-17  Tom Tromey  <tom@tromey.com>
4027
4028         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4029         refresh_window.
4030         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4031         touchwin.
4032         (tui_data_window::refresh_window): Call refresh_window on data
4033         items.  Always call superclass refresh_window.
4034         (tui_win_info::refresh): Remove.
4035         (tui_source_window_base::refresh_window): Update.
4036         (tui_refresh_all): Update.
4037         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4038         refresh_window.
4039         (show_source_or_disasm_and_command): Likewise.
4040         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4041         (struct tui_source_window_base) <refresh>: Likewise.
4042
4043 2019-07-17  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui-winsource.c (tui_clear_source_content)
4046         (tui_show_source_content): Update.
4047         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4048         whether content is empty.
4049         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4050         Remove.
4051
4052 2019-07-17  Tom Tromey  <tom@tromey.com>
4053
4054         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4055         window's contents.
4056         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4057         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4058
4059 2019-07-17  Tom Tromey  <tom@tromey.com>
4060
4061         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4062         (struct tui_data_item_window): Update.
4063
4064 2019-07-17  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4067         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4068         defines.
4069
4070 2019-07-17  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui-winsource.h (tui_erase_source_content)
4073         (tui_clear_source_content): Remove "display_prompt" parameter.
4074         * tui/tui-winsource.c (tui_update_source_window_as_is)
4075         (tui_update_source_windows_with_addr): Update.
4076         (tui_clear_source_content): Remove "display_prompt" parameter.
4077         (tui_erase_source_content): Likewise.  Simplify.
4078         (tui_show_source_content): Update.
4079         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4080         * tui/tui-stack.c (tui_show_frame_info): Update.
4081         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4082         Remove defines.
4083
4084 2019-07-17  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4087         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4088         parameter.
4089         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4090         parameter.
4091
4092 2019-07-17  Tom Tromey  <tom@tromey.com>
4093
4094         * tui/tui-winsource.c (tui_clear_source_content)
4095         (tui_show_source_content, tui_show_exec_info_content)
4096         (tui_clear_exec_info_content): Update.
4097         * tui/tui-stack.c (tui_show_locator_content): Update.
4098         (tui_show_frame_info): Update.
4099         * tui/tui-source.h (tui_source_window): Don't declare.
4100         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4101         from tui_source_is_displayed.
4102         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4103         Remove field.
4104         (struct tui_source_window_base) <content_in_use>: New field.  Now
4105         bool.
4106         (struct tui_source_window) <showing_source_p>: New method.
4107         (TUI_SRC_WIN): Change cast.
4108         * tui/tui-data.c (tui_initialize_static_data): Update.
4109
4110 2019-07-17  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4113         location_matches_p.
4114         * tui/tui-source.c (tui_source_window::location_matches_p): New
4115         method.
4116         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4117         method.
4118         * tui/tui-data.h (struct tui_source_window_base)
4119         <location_matches_p>: New method.
4120         (struct tui_source_window, struct tui_disasm_window)
4121         <location_matches_p>: Likewise.
4122
4123 2019-07-17  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui-win.c (tui_set_win_height_command): Rename from
4126         tui_set_win_height.
4127         (tui_set_win_height_command): Remove.
4128
4129 2019-07-17  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-source.c (tui_source_window): New constructor.  Add
4132         observer.
4133         (~tui_source_window): New destructor.
4134         (tui_source_window::style_changed): New method.
4135         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4136         (tui_attach_detach_observers): Update.
4137         * tui/tui-data.h (struct tui_source_window): Make constructor not
4138         inline.  Add destructor.
4139         (struct tui_source_window) <style_changed>: New method.
4140         <m_observable>: New member.
4141
4142 2019-07-17  Tom Tromey  <tom@tromey.com>
4143
4144         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4145         * tui/tui-win.c (tui_resize_all): Fix typo.
4146
4147 2019-07-17  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4150         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4151         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4152         * tui/tui-win.c (window_name_completer): Use foreach.
4153         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4154         (update_tab_width): Likewise.
4155         * tui/tui-layout.c (show_layout): Update.
4156         * tui/tui-data.h (class tui_window_iterator): New.
4157         (struct all_tui_windows): New.
4158         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4159
4160 2019-07-17  Tom Tromey  <tom@tromey.com>
4161
4162         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4163         parameter.  Don't reference globals.
4164         (tui_reg_command): Update.
4165
4166 2019-07-17  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-regs.c (tui_show_registers): Simplify.
4169
4170 2019-07-17  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui-regs.c (tui_show_registers): Update.
4173         (tui_show_register_group): Add win_info parameter.
4174
4175 2019-07-17  Tom Tromey  <tom@tromey.com>
4176
4177         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4178         Rename from tui_display_reg_element_at_line.
4179         (tui_data_window::display_registers_from_line): Update.
4180         * tui/tui-data.h (struct tui_data_window)
4181         <display_reg_element_at_line>: New method.
4182
4183 2019-07-17  Tom Tromey  <tom@tromey.com>
4184
4185         * tui/tui-regs.h (tui_display_registers_from)
4186         (tui_display_registers_from_line): Don't declare.
4187         * tui/tui-windata.c (tui_data_window::display_all_data)
4188         (tui_data_window::refresh_all)
4189         (tui_data_window::do_scroll_vertical): Update.
4190         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4191         from tui_display_registers_from.
4192         (tui_display_reg_element_at_line): Update.
4193         (tui_data_window::display_registers_from_line): Rename from
4194         tui_display_registers_from_line.
4195         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4196         display_registers_from_line>: New methods.
4197
4198 2019-07-17  Tom Tromey  <tom@tromey.com>
4199
4200         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4201         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4202         from tui_erase_data_content.
4203         (tui_data_window::display_all_data)
4204         (tui_data_window::refresh_all)
4205         (tui_data_window::do_scroll_vertical): Update.
4206         * tui/tui-regs.c (tui_show_registers): Update.
4207         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4208         New method.
4209
4210 2019-07-17  Tom Tromey  <tom@tromey.com>
4211
4212         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4213         declare.
4214         * tui/tui-windata.c
4215         (tui_data_window::delete_data_content_windows): Rename from
4216         tui_delete_data_content_windows.
4217         (tui_data_window::display_all_data)
4218         (tui_data_window::do_scroll_vertical): Update.
4219         * tui/tui-data.h (struct tui_data_window)
4220         <delete_data_content_windows>: New method.
4221
4222 2019-07-17  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4225         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4226
4227 2019-07-17  Tom Tromey  <tom@tromey.com>
4228
4229         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4230         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4231         from tui_display_all_data.
4232         * tui/tui-win.c
4233         (tui_data_window::do_make_visible_with_new_height): Update.
4234         * tui/tui-regs.c (tui_show_registers): Update.
4235         * tui/tui-layout.c (tui_set_layout): Update.
4236         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4237         method.
4238
4239 2019-07-17  Tom Tromey  <tom@tromey.com>
4240
4241         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4242         * tui/tui-windata.c (tui_display_data_from): Remove.
4243         (tui_data_window::refresh_all): Update.
4244
4245 2019-07-17  Tom Tromey  <tom@tromey.com>
4246
4247         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4248         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4249         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4250         tui_display_registers_from_line.
4251         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4252         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4253         "force_display" parameter.
4254
4255 2019-07-17  Tom Tromey  <tom@tromey.com>
4256
4257         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4258         declare.
4259         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4260         Rename from tui_first_reg_element_no_inline.
4261         (tui_display_reg_element_at_line)
4262         (tui_display_registers_from_line): Update.
4263         * tui/tui-data.h (struct tui_data_window)
4264         <first_reg_element_no_inline>: New method.
4265
4266 2019-07-17  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui-windata.c (tui_display_data_from)
4269         (tui_data_window::do_scroll_vertical): Update.
4270         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4271         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4272         Rename from tui_line_from_reg_element_no.
4273         (tui_display_registers_from_line): Update.
4274         * tui/tui-data.h (struct tui_data_window)
4275         <line_from_reg_element_no>: New method.
4276
4277 2019-07-17  Tom Tromey  <tom@tromey.com>
4278
4279         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4280         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4281         tui_last_regs_line_no.
4282         (tui_display_reg_element_at_line)
4283         (tui_display_registers_from_line): Update.
4284         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4285         method.
4286
4287 2019-07-17  Tom Tromey  <tom@tromey.com>
4288
4289         PR tui/24722:
4290         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4291         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4292         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4293         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4294         (tui_update_breakpoint_info): Likewise.
4295         * tui/tui-hooks.c (tui_event_create_breakpoint)
4296         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4297         Update.
4298
4299 2019-07-17  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4302
4303 2019-07-17  Tom Tromey  <tom@tromey.com>
4304
4305         * tui/tui-winsource.c (tui_update_source_window_as_is)
4306         (tui_update_source_windows_with_addr): Update.
4307         * tui/tui-source.h (tui_set_source_content)
4308         (tui_show_symtab_source): Add "win_info" parameter.
4309         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4310         parameter.
4311         (tui_show_symtab_source): Likewise.
4312
4313 2019-07-17  Tom Tromey  <tom@tromey.com>
4314
4315         * tui/tui-wingeneral.c
4316         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4317
4318 2019-07-17  Tom Tromey  <tom@tromey.com>
4319
4320         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4321         (struct tui_cmd_window) <can_scroll>: New method.
4322         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4323         method.
4324
4325 2019-07-17  Tom Tromey  <tromey@adacore.com>
4326
4327         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4328         do_field_signed>: Rename.  Change type of "value".
4329         * ui-out.c (ui_out::field_signed): Rename from field_int.
4330         Change type of "value".
4331         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4332         type of "value".
4333         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4334         do_field_int.  Change type of "value".
4335         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4336         do_field_int.  Change type of "value".
4337         * tracepoint.c (trace_status_mi, tfind_1)
4338         (print_one_static_tracepoint_marker): Update.
4339         * thread.c (print_thread_info_1, print_selected_thread_frame):
4340         Update.
4341         * stack.c (print_frame, print_frame_info): Update.
4342         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4343         Update.
4344         * source.c (print_source_lines_base): Update.
4345         * skip.c (info_skip_command): Update.
4346         * record-btrace.c (btrace_ui_out_decode_error)
4347         (btrace_call_history_src_line): Update.
4348         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4349         Update.
4350         * progspace.c (print_program_space): Update.
4351         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4352         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4353         do_field_int.  Change type of "value".
4354         * mi/mi-out.c (mi_ui_out::do_table_begin)
4355         (mi_ui_out::do_table_header): Update.
4356         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4357         type of "value".
4358         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4359         (mi_cmd_data_list_changed_registers, output_register)
4360         (mi_cmd_data_read_memory, mi_load_progress)
4361         (mi_cmd_trace_frame_collected): Update.
4362         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4363         Update.
4364         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4365         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4366         (mi_cmd_var_list_children, varobj_update_one): Update.
4367         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4368         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4369         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4370         * inferior.c (print_inferior): Update.
4371         * gdb_bfd.c (print_one_bfd): Update.
4372         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4373         Update.
4374         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4375         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4376         do_field_int.  Change type of "value".
4377         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4378         do_field_int.  Change type of "value".
4379         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4380         (print_one_breakpoint_location, print_it_catch_fork)
4381         (print_one_catch_fork, print_it_catch_vfork)
4382         (print_one_catch_vfork, print_it_catch_solib)
4383         (print_it_catch_exec, print_it_ranged_breakpoint)
4384         (print_mention_watchpoint, print_mention_masked_watchpoint)
4385         (bkpt_print_it, update_static_tracepoint): Update.
4386         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4387         * break-catch-syscall.c (print_it_catch_syscall): Update.
4388         * ada-tasks.c (print_ada_task_info): Update.
4389         * ada-lang.c (print_it_exception, print_mention_exception):
4390         Update.
4391
4392 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4393
4394         PR breakpoints/24541
4395         * gdbarch.c: Regenerate.
4396         * gdbarch.h: Regenerate.
4397         * gdbarch.sh: Adjust return type and parameter types for
4398         'stap_adjust_register'.
4399         (i386_stap_adjust_register): Adjust signature and return new
4400         register name.
4401         * stap-probe.c (stap_parse_register_operand): Adjust use of
4402         'gdbarch_stap_adjust_register'.
4403
4404 2019-07-17  Tom Tromey  <tromey@adacore.com>
4405
4406         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4407         declare VEC.
4408         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4409         std::vector.
4410         (struct s390_process_info): Add initializers.
4411         (s390_add_process): Use new.
4412         (s390_linux_nat_target::low_forget_process): Use delete.
4413         (s390_linux_nat_target::low_new_fork)
4414         (s390_linux_nat_target::stopped_by_watchpoint)
4415         (s390_linux_nat_target::low_prepare_to_resume)
4416         (s390_linux_nat_target::insert_watchpoint)
4417         (s390_linux_nat_target::insert_hw_breakpoint)
4418         (s390_linux_nat_target::remove_watchpoint)
4419         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4420
4421 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4422
4423         * aarch64-fbsd-nat.c: Include regcache.h.
4424         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4425         argument.
4426         (aarch64_fbsd_nat_target::fetch_registers)
4427         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4428         variable.
4429         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4430
4431 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4432
4433         * fbsd-nat.c: Include gdbarch.h.
4434
4435 2019-07-15  Tom Tromey  <tromey@adacore.com>
4436
4437         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4438
4439 2019-07-15  Tom Tromey  <tromey@adacore.com>
4440
4441         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4442         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4443         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4444         * cli-out.c (cli_ui_out::do_field_int): New method.
4445         * ui-out.c (ui_out::field_unsigned): New method.
4446         * symfile.c (generic_load): Use field_unsigned.
4447         (print_transfer_performance): Likewise.
4448         * record-btrace.c (ui_out_field_uint): Remove.
4449         (btrace_call_history_insn_range, btrace_call_history): Use
4450         field_unsigned.
4451         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4452         field_unsigned.
4453         * ui-out.h (class ui_out) <field_unsigned>: New method.
4454         <do_field_unsigned>: Likewise.
4455
4456 2019-07-15  Tom Tromey  <tromey@adacore.com>
4457
4458         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4459         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4460         * target.c (flash_erase_command): Use field_string.
4461         * infrun.c (print_signal_received_reason): Use field_string.
4462         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4463         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4464         field_string.
4465         * ada-tasks.c (print_ada_task_info): Use field_string.
4466
4467 2019-07-15  Tom Tromey  <tromey@adacore.com>
4468
4469         * target.c (flash_erase_command): Use field_core_addr.
4470         * symfile.c (generic_load): Use field_core_addr.
4471         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4472         Use field_core_addr.
4473         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4474         field_core_addr.
4475
4476 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4479         value if its desired type is smaller than a CORE_ADDR and signed.
4480
4481 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4484         of changes to field names, and use new is_reference field to
4485         decide if a property is a reference or not.
4486         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4487         field.
4488         (struct dwarf2_property_baton): Update header comment, rename
4489         'referenced_type' to 'property_type' and update comments.
4490         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4491         default property type, store in property baton, update to take
4492         accound of renamed field.
4493         (read_func_scope): Update call to attr_to_dynamic_prop.
4494         (read_array_type): Likewise.
4495         (dwarf2_per_cu_addr_sized_int_type): New function.
4496         (read_subrange_index_type): Move type finding code to
4497         dwarf2_per_cu_addr_sized_int_type.
4498         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4499         (dwarf2_per_cu_addr_type): New function.
4500         (set_die_type): Update calls to attr_to_dynamic_prop.
4501
4502 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4503
4504         * dwarf2read.c (read_subrange_index_type): New function.
4505         (read_subrange_type): Move code into new function and call it.
4506         * gdbtypes.c (create_range_type): Add some asserts.
4507
4508 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4511         update return statements.
4512         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4513         declaration, and update comment to match.
4514         * gdbtypes.c (resolve_dynamic_array): Update call to
4515         dwarf2_evaluate_property to match new return type.
4516
4517 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * valarith.c (value_subscripted_rvalue): Change lowerbound
4520         parameter type from int to LONGEST.
4521         * value.h (value_subscripted_rvalue): Likewise in declaration.
4522
4523 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * cli/cli-utils.c (info_print_command_completer): New function.
4526         * cli/cli-utils.h: Add 'completer.h' include, and forward
4527         declaration for 'struct cmd_list_element'.
4528         (info_print_command_completer): Declare.
4529         * stack.c (_initialize_stack): Add completer for 'info locals' and
4530         'info args'.
4531         * symtab.c (_initialize_symtab): Add completer for 'info
4532         variables' and 'info functions'.
4533         * NEWS: Mention completion for additional info commands.
4534
4535 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * cli/cli-utils.c (extract_info_print_args): Delete.
4538         (extract_arg_maybe_quoted): Delete.
4539         (info_print_options_defs): New variable.
4540         (make_info_print_options_def_group): New function.
4541         (extract_info_print_options): Define new function.
4542         * cli/cli-utils.h (extract_info_print_args): Delete.
4543         (struct info_print_options): New structure.
4544         (extract_info_print_options): Declare new function.
4545         * stack.c (info_locals_command): Update to use new
4546         extract_info_print_options, also add a header comment.
4547         (info_args_command): Likewise.
4548         * symtab.c (info_variables_command): Likewise.
4549         (info_functions_command): Likewise.
4550
4551 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4554         to extract string arguments.
4555         * common/common-utils.c (extract_string_maybe_quoted): New function.
4556         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4557
4558 2019-07-11  Tom Tromey  <tromey@adacore.com>
4559
4560         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4561         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4562         * top.h (gdbinit): Don't declare.
4563         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4564         into...
4565         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4566         * top.c (gdb_init): Don't call init_cli_cmds.
4567         (gdbinit): Remove.
4568         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4569
4570 2019-07-11  Tom Tromey  <tromey@adacore.com>
4571
4572         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4573         after it has been moved.
4574
4575 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4576
4577         * valops.c (value_must_coerce_to_target): Change return type to
4578         bool.
4579         * value.h (value_must_coerce_to_target): Likewise.
4580
4581 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4582
4583         * breakpoint.c (is_hardware_watchpoint): Remove
4584         forward-declaration.
4585         (is_masked_watchpoint): Change return type to bool.
4586         (is_tracepoint): Likewise.
4587         (is_breakpoint): Likewise.
4588         (is_hardware_watchpoint): Likewise.
4589         (is_watchpoint): Likewise.
4590         (is_no_memory_software_watchpoint): Likewise.
4591         (is_catchpoint): Likewise.
4592         (breakpoint_1): Make FILTER parameter's return type bool.
4593         is_masked_watchpoint): Change return type to bool.
4594         (save_breakpoints): Make FILTER parameter's return type bool.
4595         * breakpoint.h (is_breakpoint): Change return type to bool.
4596         (is_watchpoint): Likewise.
4597         (is_catchpoint): Likewise.
4598         (is_tracepoint): Likewise.
4599
4600 2019-07-10  Tom Tromey  <tom@tromey.com>
4601
4602         * defs.h: Don't include gdbarch.h.
4603         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4604         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4605         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4606         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4607         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4608         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4609         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4610         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4611         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4612         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4613         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4614         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4615         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4616         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4617         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4618         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4619         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4620         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4621         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4622         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4623         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4624         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4625         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4626         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4627         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4628         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4629         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4630
4631 2019-07-10  Tom Tromey  <tromey@adacore.com>
4632
4633         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4634         * breakpoint.c (init_ada_exception_breakpoint): Register as
4635         bp_catchpoint.
4636         (print_one_breakpoint_location, print_one_breakpoint): Use
4637         is_ada_exception_catchpoint.
4638         * ada-lang.c (class ada_catchpoint_location): Pass
4639         bp_loc_software_breakpoint to bp_location constructor.
4640         (is_ada_exception_catchpoint): New function.
4641
4642 2019-07-10  Tom Tromey  <tromey@adacore.com>
4643
4644         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4645         VEC.
4646         (struct arm_exidx_entry): New method operator<.
4647         (struct arm_exidx_data) <section_maps>: Change type.
4648         (arm_exidx_data_free): Remove.
4649         (arm_exidx_data_key): Change type.  Move lower.
4650         (arm_exidx_new_objfile): Update.
4651         (arm_compare_exidx_entries): Remove.
4652         (arm_find_exidx_entry, _initialize_arm_tdep)
4653
4654 2019-07-10  Tom Tromey  <tromey@adacore.com>
4655
4656         * solib-spu.c (ocl_program_data_key): Change type.
4657         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4658         Update.
4659
4660 2019-07-10  Tom Tromey  <tromey@adacore.com>
4661
4662         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4663         (struct solib_aix_inferior_data) <library_list>: Change type.
4664         (solib_aix_inferior_data_handle): Change type.
4665         (get_solib_aix_inferior_data): Update.
4666         (solib_aix_free_library_list): Remove.
4667         (library_list_start_library): Update.
4668         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4669         return type.
4670         (solib_aix_get_library_list)
4671         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4672         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4673
4674 2019-07-10  Tom Tromey  <tromey@adacore.com>
4675
4676         * solib-dsbt.c (struct dsbt_info): Add initializers.
4677         (solib_dsbt_pspace_data): Change type.
4678         (dsbt_pspace_data_cleanup): Remove.
4679         (get_dsbt_info, _initialize_dsbt_solib): Update.
4680
4681 2019-07-10  Tom Tromey  <tromey@adacore.com>
4682
4683         * spu-tdep.c (spu_overlay_data): Change type.
4684         (spu_get_overlay_table, spu_overlay_new_objfile)
4685         (_initialize_spu_tdep): Update.
4686
4687 2019-07-10  Tom Tromey  <tromey@adacore.com>
4688
4689         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4690         destructor.
4691         (dbx_objfile_data_key): Change type and declare later.
4692         (DBX_SYMFILE_INFO): Rewrite.
4693         * dbxread.c (dbx_objfile_data_key): Change type.
4694         (dbx_symfile_init): Update.
4695         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4696         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4697         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4698
4699 2019-07-10  Tom Tromey  <tromey@adacore.com>
4700
4701         * jit.c (jit_program_space_key): Change type.  Move lower.
4702         (get_jit_program_space_data): Update.
4703         (jit_program_space_data_cleanup): Remove.
4704         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4705         Update.
4706         (struct jit_program_space_data): Add initializers.
4707
4708 2019-07-10  Tom Tromey  <tromey@adacore.com>
4709
4710         * solib-darwin.c (struct darwin_info): Add initializers.
4711         (solib_darwin_pspace_data): Change type.
4712         (darwin_pspace_data_cleanup): Remove.
4713         (get_darwin_info, _initialize_darwin_solib): Update.
4714
4715 2019-07-10  Tom Tromey  <tromey@adacore.com>
4716
4717         * remote-sim.c (struct sim_inferior_data): Add initializers,
4718         constructor, and destructor.
4719         (sim_inferior_data_key): Change type.  Move lower.
4720         (check_for_duplicate_sim_descriptor): Update.
4721         (get_sim_inferior_data): Use new.  Update.
4722         (~sim_inferior_data_cleanup): Rename from
4723         sim_inferior_data_cleanup.  Simplify.
4724         (gdbsim_close_inferior, simulator_command)
4725         (sim_command_completer, _initialize_remote_sim): Update.
4726         (next_pid, INITIAL_PID): Move earlier.
4727
4728 2019-07-10  Tom Tromey  <tromey@adacore.com>
4729
4730         * python/python-internal.h (create_thread_object): Return
4731         gdbpy_ref.
4732         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4733         * python/py-inferior.c (struct threadlist_entry): Add
4734         constructor.
4735         <thread_obj>: Now a gdbpy_ref.
4736         (thread_to_thread_object): Update.
4737         (add_thread_object): Use new.
4738         (delete_thread_object): Use delete.
4739         (infpy_threads): Update.
4740         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4741         GIL.
4742
4743 2019-07-10  Tom Tromey  <tromey@adacore.com>
4744
4745         * valops.c (value_cast): Specialize error message for Ada.
4746
4747 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4748
4749         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4750
4751 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4752
4753         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4754         bpstat_should_step): Return bool, adjust comments.
4755         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4756         bpstat_should_step): Likewise.
4757
4758 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4759
4760         * features/Makefile: Use feature target descriptions for Arm.
4761         * features/arm/arm-core.c: Generate new file.
4762         * features/arm/arm-fpa.c: Likewise.
4763         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4764         * features/arm/arm-m-profile.c: Likewise.
4765         * features/arm/arm-vfpv2.c: Likewise.
4766         * features/arm/arm-vfpv3.c: Likewise.
4767         * features/arm/xscale-iwmmxt.c: Likewise.
4768         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4769
4770 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4771
4772         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4773         ptrace earlier.
4774
4775 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4776
4777         * features/aarch64-pauth.c: Regenerate.
4778
4779 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4780
4781         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4782         bool.
4783         (bpstat_what): Use false instead of 0.
4784
4785 2019-07-09  Pedro Alves  <palves@redhat.com>
4786
4787         * break-catch-throw.c (is_exception_catchpoint): New.
4788         * breakpoint.c (print_one_breakpoint_location): New parameter
4789         'raw_loc'.  Handle it.  Use
4790         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4791         looking at the breakpoint's type.
4792         (print_one_breakpoint): If handling "maint info breakpoints", also
4793         print locations of exception catchpoints.
4794         * breakpoint.h (is_exception_catchpoint): Declare.
4795
4796 2019-07-09  Pedro Alves  <palves@redhat.com>
4797
4798         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4799         "addr" field.
4800         (allocate_location_exception_catchpoint): New.
4801         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4802         (initialize_throw_catchpoint_ops): Install
4803         allocate_location_exception_catchpoint as allocate_location
4804         method.
4805         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4806         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4807         bp_loc_other.
4808         (breakpoint_address_is_meaningful): Delete.
4809         (bl_address_is_meaningful): New.
4810         (breakpoint_locations_match): Adjust comment.
4811         (bp_location_from_bp_type): New, factored out of...
4812         (bp_location::bp_location(breakpoint *)): ... this.
4813         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4814         factored out of...
4815         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4816         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4817         breakpoint_address_is_meaningful.
4818         (bp_locations_compare): Adjust comment.
4819         (update_global_location_list): Use bl_address_is_meaningful
4820         instead of breakpoint_address_is_meaningful.
4821         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4822         explicit.
4823         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4824         * python/py-breakpoint.c (bppy_get_location): No longer check
4825         whether location is null.
4826
4827 2019-07-09  Pedro Alves  <palves@redhat.com>
4828
4829         PR c++/15468
4830         * breakpoint.c (print_one_breakpoint_location): Remove
4831         single-location assert.
4832
4833 2019-07-09  Tom Tromey  <tom@tromey.com>
4834
4835         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4836         * configure: Rebuild.
4837         * configure.ac: Change common to gdbsupport.
4838         * gdbsupport: Rename from common.
4839         * acinclude.m4: Change common to gdbsupport.
4840         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4841         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4842         gdbsupport.
4843         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4844         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4845         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4846         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4847         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4848         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4849         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4850         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4851         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4852         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4853         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4854         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4855         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4856         coff-pe-read.c, command.h, compile/compile-c-support.c,
4857         compile/compile-c.h, compile/compile-cplus-symbols.c,
4858         compile/compile-cplus-types.c, compile/compile-cplus.h,
4859         compile/compile-loc2c.c, compile/compile.c, completer.c,
4860         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4861         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4862         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4863         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4864         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4865         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4866         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4867         features/aarch64-core.c, features/aarch64-fpu.c,
4868         features/aarch64-pauth.c, features/aarch64-sve.c,
4869         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4870         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4871         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4872         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4873         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4874         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4875         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4876         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4877         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4878         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4879         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4880         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4881         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4882         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4883         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4884         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4885         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4886         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4887         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4888         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4889         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4890         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4891         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4892         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4893         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4894         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4895         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4896         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4897         minsyms.c, mips-linux-tdep.c, namespace.h,
4898         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4899         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4900         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4901         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4902         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4903         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4904         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4905         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4906         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4907         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4908         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4909         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4910         procfs.c, producer.c, progspace.h, psymtab.h,
4911         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4912         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4913         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4914         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4915         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4916         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4917         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4918         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4919         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4920         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4921         target-memory.c, target.c, target.h, target/waitstatus.c,
4922         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4923         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4924         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4925         unittests/array-view-selftests.c,
4926         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4927         unittests/common-utils-selftests.c,
4928         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4929         unittests/format_pieces-selftests.c,
4930         unittests/function-view-selftests.c,
4931         unittests/lookup_name_info-selftests.c,
4932         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4933         unittests/mkdir-recursive-selftests.c,
4934         unittests/observable-selftests.c,
4935         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4936         unittests/parse-connection-spec-selftests.c,
4937         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4938         unittests/scoped_fd-selftests.c,
4939         unittests/scoped_mmap-selftests.c,
4940         unittests/scoped_restore-selftests.c,
4941         unittests/string_view-selftests.c, unittests/style-selftests.c,
4942         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4943         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4944         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4945         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4946         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4947         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4948
4949 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4952         bool value.
4953         (decode_digits_ordinary): Set explicit_line field in sal.
4954         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4955         symtab_and_line that was set on an explicit line number in
4956         assembler code.  Do always update the recorded symtab and line if
4957         we do skip the prologue.
4958
4959 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4960
4961         * breakpoint.c (set_breakpoint_location_function): Remove
4962         explicit_loc parameter.
4963         (momentary_breakpoint_from_master): Update call to
4964         set_breakpoint_location_function.
4965         (add_location_to_breakpoint): Likewise.
4966
4967 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4970         required features based on default bfd type when no specific bfd
4971         is present.
4972
4973 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4974
4975         * NEWS: Mention that GDB printf and eval commands can now print
4976         C-style and Ada-style convenience var strings without
4977         calling the inferior.
4978         * printcmd.c (printf_c_string): Locally print GDB internal var
4979         instead of transiting via the inferior.
4980         (printf_wide_c_string): Likewise.
4981
4982 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4983
4984         PR breakpoints/25011
4985         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4986
4987 2019-07-04  Tom Tromey  <tom@tromey.com>
4988
4989         PR tui/24724:
4990         * tui/tui-winsource.c (tui_clear_source_content): Update.
4991         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4992         (tui_update_breakpoint_info): Update.
4993         (tui_set_exec_info_content): Update.
4994         * tui/tui-source.c (tui_set_source_content_nil): Update.
4995         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4996         has_break.
4997         * tui/tui-data.h (enum tui_bp_flag): New.
4998         (tui_bp_flags): New enum flags type.
4999         (struct tui_source_element) <break_mode>: Change type.  Rename
5000         from has_break.
5001         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5002         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5003         constants.
5004         * tui/tui-winsource.h: Fix comment.
5005
5006 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5007
5008         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5009         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5010         (store_fpregs_to_thread)
5011         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5012         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5013         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5014         (IWMMXT_REGS_SIZE): Add define.
5015         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5016         (fetch_vfp_regs, store_vfp_regs)
5017         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5018         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5019
5020 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5021
5022         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5023         defines.
5024         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5025         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5026         (ARM_INT_REGISTER_SIZE): ...to this.
5027         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5028         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5029         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5030         (arm_linux_collect_gregset, supply_nwfpe_register)
5031         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5032         defines.
5033         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5034         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5035         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5036         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5037         (arm_return_in_memory, arm_store_return_value)
5038         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5039         (arm_record_ld_st_multiple): Likewise.
5040         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5041         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5042
5043 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5044
5045         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5046         AARCH64_DISPLACED_MODIFIED_INSNS.
5047         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5048         (aarch64_displaced_step_copy_insn): Likewise.
5049         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5050         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5051         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5052         ARM_DISPLACED_MODIFIED_INSNS.
5053         * arm-tdep.c (arm_gdbarch_init): Likewise.
5054         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5055         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5056         (struct arm_displaced_step_closure): Use
5057         ARM_DISPLACED_MODIFIED_INSNS.
5058
5059 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5060
5061         * features/Makefile: Remove unused xml files.
5062         * features/aarch64.xml: Remove.
5063         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5064         * features/i386/amd64-avx-avx512.xml: Remove.
5065         * features/i386/amd64-avx-linux.xml: Remove.
5066         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5067         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5068         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5069         * features/i386/amd64-avx-mpx.xml: Remove.
5070         * features/i386/amd64-avx.xml: Remove.
5071         * features/i386/amd64-linux.xml: Remove.
5072         * features/i386/amd64-mpx-linux.xml: Remove.
5073         * features/i386/amd64-mpx.xml: Remove.
5074         * features/i386/amd64.xml: Remove.
5075         * features/i386/i386-avx-avx512-linux.xml: Remove.
5076         * features/i386/i386-avx-avx512.xml: Remove.
5077         * features/i386/i386-avx-linux.xml: Remove.
5078         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5079         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5080         * features/i386/i386-avx-mpx-linux.xml: Remove.
5081         * features/i386/i386-avx-mpx.xml: Remove.
5082         * features/i386/i386-avx.xml: Remove.
5083         * features/i386/i386-linux.xml: Remove.
5084         * features/i386/i386-mmx-linux.xml: Remove.
5085         * features/i386/i386-mmx.xml: Remove.
5086         * features/i386/i386-mpx-linux.xml: Remove.
5087         * features/i386/i386-mpx.xml: Remove.
5088         * features/i386/i386.xml: Remove.
5089         * features/i386/x32-avx-avx512-linux.xml: Remove.
5090         * features/i386/x32-avx-linux.xml: Remove.
5091         * features/i386/x32-linux.xml: Remove.
5092
5093 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5094
5095         * regformats/aarch64.dat: Remove.
5096         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5097         * regformats/i386/amd64-avx-linux.dat: Remove.
5098         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5099         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5100         * regformats/i386/amd64-linux.dat: Remove.
5101         * regformats/i386/amd64-mpx-linux.dat: Remove.
5102         * regformats/i386/amd64.dat: Remove.
5103         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5104         * regformats/i386/i386-avx-linux.dat: Remove.
5105         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5106         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5107         * regformats/i386/i386-linux.dat: Remove.
5108         * regformats/i386/i386-mmx-linux.dat: Remove.
5109         * regformats/i386/i386-mpx-linux.dat: Remove.
5110         * regformats/i386/i386.dat: Remove.
5111         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5112         * regformats/i386/x32-avx-linux.dat: Remove.
5113         * regformats/i386/x32-linux.dat: Remove.
5114
5115 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5116
5117         * aarch64-tdep.c: Remove xml self tests.
5118         * amd64-linux-tdep.c: Likewise.
5119         * amd64-tdep.c: Likewise.
5120         * i386-linux-tdep.c: Likewise.
5121         * i386-tdep.c: Likewise.
5122
5123 2019-07-03  Pedro Alves  <palves@redhat.com>
5124
5125         PR cli/24732
5126         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5127         (pipe_cmd_option_defs): New.
5128         (make_pipe_cmd_options_def_group): New.
5129         (pipe_command): Use gdb::option::process_options.
5130         (pipe_command_completer): New function.
5131         (_initialize_cli_cmds): Install completer for "pipe" command.
5132
5133 2019-07-03  Pedro Alves  <palves@redhat.com>
5134
5135         * cli/cli-option.c (union option_value) <string>: New field.
5136         (struct option_def_and_value): Add ctor, move ctor, dtor and
5137         use DISABLE_COPY_AND_ASSIGN.
5138         (option_def_and_value::clear_value): New.
5139         (parse_option, save_option_value_in_ctx, get_val_type_str)
5140         (add_setshow_cmds_for_options): Handle var_string.
5141         * cli-option.h (union option_def::var_address) <string>: New
5142         field.
5143         (struct string_option_def): New.
5144         * maint-test-options.c (struct test_options_opts): Add default
5145         ctor and use DISABLE_COPY_AND_ASSIGN.
5146         <string_opt>: New field.
5147         (test_options_opts::~test_options_opts): New.
5148         (test_options_opts::dump): Also dump "-string".
5149         (test_options_option_defs): Install "string.
5150
5151 2019-07-03  Pedro Alves  <palves@redhat.com>
5152
5153         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5154         option_value with a null enumeration.
5155         (complete_options): Save the option values in the context.
5156         (save_option_value_in_ctx): New, factored out from ...
5157         (process_options): ... here.
5158         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5159         of the function.
5160         * maint-test-options.c (test_options_opts::dump): New, factored
5161         out from ...
5162         (maintenance_test_options_command_mode): ... here.
5163         (maintenance_test_options_command_completion_result): Delete.
5164         (maintenance_test_options_command_completion_text): Update
5165         comment.
5166         (maintenance_show_test_options_completion_result): Change
5167         prototype.  Just print
5168         maintenance_test_options_command_completion_text.
5169         (save_completion_result): New.
5170         (maintenance_test_options_completer_mode): Pass options context to
5171         complete_options, and then save a dump.
5172         (_initialize_maint_test_options): Use add_cmd to install "maint
5173         show test-options-completion-result".
5174
5175 2019-07-03  Pedro Alves  <palves@redhat.com>
5176
5177         * NEWS (New commands): Mention "with" and "maint with".
5178         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5179         (with_command, with_command_completer): New.
5180         (pipe_command): Adjust to new repeat_previous
5181         interface.
5182         (_initialize_cli_cmds): Install the "with" command and its "w"
5183         alias.
5184         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5185         declarations.
5186         * cli/cli-setshow.c (parse_cli_var_uinteger)
5187         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5188         argument strings for all var_types.
5189         (get_setshow_command_value_string): New, factored out from ...
5190         (do_show_command): ... this.
5191         * cli/cli-setshow.h: Include <string>.
5192         (get_setshow_command_value_string): Declare.
5193         * command.h (repeat_previous): Now returns const char *.  Adjust
5194         comment.
5195         * maint.c: Include "cli/cli-cmds.h".
5196         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5197         (_initialize_maint_cmds): Register the "maintenance with" command.
5198         * top.c (repeat_previous): Move bits from pipe_command here:
5199         Return the saved command line, if any; error out if there's no
5200         command to relaunch.
5201
5202 2019-07-03  Pedro Alves  <palves@redhat.com>
5203
5204         * NEWS (New commands): Mention "maint set/show test-settings"
5205         instead of "maint test-settings".
5206         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5207         (maintenance_test_settings_set_list): Rename to ...
5208         (maintenance_set_test_settings_list): ... this.
5209         (maintenance_test_settings_show_list): Rename to  ...
5210         (maintenance_show_test_settings_list): ... this.
5211         (maintenance_test_settings_cmd): Delete.
5212         (maintenance_test_settings_set_cmd): ...
5213         (maintenance_set_test_settings_cmd): ... this.
5214         (maintenance_test_settings_show_cmd): ...
5215         (maintenance_show_test_settings_cmd): ... this.
5216         (maintenance_test_settings_show_value_cmd):
5217         (maintenance_show_test_settings_value_cmd): ... this.
5218         (_initialize_maint_test_settings): No longer install the "maint
5219         test-settings" prefix command.  Rename "maint test-settings set"
5220         to "maint set test-settings", and "maint test-settings show" to
5221         "maint show test-settings".  Adjust all subcommands.
5222
5223 2019-07-03  Pedro Alves  <palves@redhat.com>
5224
5225         * maint-test-settings.c: Fix file's intro comment.  Replace all
5226         references to "test-options" with references to "test-settings",
5227         in comments.
5228
5229 2019-07-03  Pedro Alves  <palves@redhat.com>
5230
5231         * maint-test-settings.c (maintenance_test_settings_xxx)
5232         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5233         New.
5234         (maintenance_test_settings_enums): Use them.
5235         (maintenance_test_settings_enum): Default to
5236         maintenance_test_settings_xxx.
5237         (_initialize_maint_test_settings): Initialize
5238         MAINTENANCE_TEST_SETTINGS_FILENAME.
5239
5240 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5241
5242         * breakpoint.h (remove_breakpoints_inf): Change return type to
5243         void, move function documentation here.
5244         * breakpoint.c (remove_breakpoints_inf): Change return type to
5245         void, move function documentation to header.
5246
5247 2019-07-02  Pedro Alves  <palves@redhat.com>
5248
5249         * NEWS (Completion improvements): Mention "info threads".
5250         * thread.c (struct info_threads_opts, info_threads_option_defs)
5251         (make_info_threads_options_def_group): New.
5252         (info_threads_command): Use gdb::option::process_options.
5253         (info_threads_command_completer): New.
5254         (_initialize_thread): Use gdb::option::build_help to build the
5255         help text for "info threads".
5256
5257 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5258
5259         * defs.h (generic_load): Move from here...
5260         * symfile.h (generic_load): ... to here.  Rename name parameter
5261         to args.
5262         * symfile.c (generic_load): Add comment.
5263
5264 2019-07-01  Tom Tromey  <tromey@adacore.com>
5265
5266         * dwarf2read.c
5267         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5268         declaration of without_params.  Fix formatting.
5269
5270 2019-07-01  Tom Tromey  <tromey@adacore.com>
5271
5272         * ada-exp.y (find_primitive_type): Update.
5273         * ada-lang.h (ada_lookup_symbol): Update.
5274         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5275         parameter.
5276         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5277
5278 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5279
5280         PR breakpoints/24541
5281         * gdbarch.c: Regenerate.
5282         * gdbarch.h: Regenerate.
5283         * gdbarch.sh: Add 'stap_adjust_register'.
5284         * i386-tdep.c: Include '<unordered_set>'.
5285         (i386_stap_adjust_register): New function.
5286         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5287         * stap-probe.c (stap_parse_register_operand): Call
5288         'gdbarch_stap_adjust_register'.
5289
5290 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5291
5292         PR python/24742
5293         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5294         * python/python.c (do_start_initialization): Use 'xmalloc'
5295         instead of 'PyMem_Malloc'.
5296
5297 2019-06-28  Tom Tromey  <tromey@adacore.com>
5298
5299         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5300         for Ada.
5301
5302 2019-06-27  Tom Tromey  <tromey@adacore.com>
5303
5304         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5305         objfile_key.
5306         (arm_find_mapping_symbol, arm_record_special_symbol)
5307         (_initialize_arm_tdep): Update.
5308         (arm_objfile_data_free): Remove.
5309
5310 2019-06-27  Tom Tromey  <tromey@adacore.com>
5311
5312         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5313         to cp_print_static_field.
5314
5315 2019-06-26  Tom Tromey  <tromey@adacore.com>
5316
5317         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5318         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5319         declare.
5320
5321 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5322
5323         * features/aarch64-core.c (create_feature_aarch64_core):
5324         Regenerate.
5325         * features/aarch64-core.xml: Add cpsr flags.
5326
5327 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5328
5329         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5330         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5331
5332 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5333
5334         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5335         field.
5336         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5337         use.
5338         (arm_record_special_symbol): Don't insert new symbol in sorted
5339         position, push it at the end.
5340
5341 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5342
5343         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5344         (arm_mapping_symbol_s): Remove.
5345         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5346         (arm_mapping_symbol_vec): New typedef.
5347         (struct arm_per_objfile): Add constructor.
5348         <section_maps>: Change type to
5349         std::unique_ptr<arm_mapping_symbol_vec[]>.
5350         (arm_compare_mapping_symbols): Remove.
5351         (arm_find_mapping_symbol): Adjust to section_maps type change.
5352         (arm_objfile_data_free): Call delete on arm_per_objfile.
5353         (arm_record_special_symbol): Adjust to section_maps type change.
5354         Allocate arm_per_objfile with new.
5355
5356 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5357
5358         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5359         with the command prefix.
5360
5361 2019-06-25  Tom Tromey  <tom@tromey.com>
5362
5363         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5364         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5365
5366 2019-06-25  Tom Tromey  <tom@tromey.com>
5367
5368         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5369         type.
5370         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5371         protected.
5372
5373 2019-06-25  Tom Tromey  <tom@tromey.com>
5374
5375         * tui/tui-winsource.c
5376         (tui_source_window_base::set_is_exec_point_at): Add check against
5377         LOA_ADDRESS.
5378
5379 2019-06-25  Tom Tromey  <tom@tromey.com>
5380
5381         * tui/tui-source.c (tui_set_source_content): Don't check before
5382         xfree.
5383         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5384
5385 2019-06-25  Tom Tromey  <tom@tromey.com>
5386
5387         * tui/tui-winsource.h (tui_update_source_window_as_is)
5388         (tui_alloc_source_buffer, tui_line_is_displayed)
5389         (tui_addr_is_displayed): Change type of win_info.
5390         * tui/tui-winsource.c (tui_update_source_window_as_is)
5391         (tui_clear_source_content, tui_show_source_line)
5392         (tui_show_source_content, tui_source_window_base::refill)
5393         (tui_source_window_base::set_is_exec_point_at)
5394         (tui_source_window_base::set_is_exec_point_at)
5395         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5396         (tui_alloc_source_buffer, tui_line_is_displayed)
5397         (tui_addr_is_displayed): Change type of win_info.  Update.
5398         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5399         (tui_source_window_base::do_make_visible_with_new_height):
5400         Update.
5401         * tui/tui-source.c (tui_set_source_content)
5402         (tui_set_source_content_nil)
5403         (tui_source_window::do_scroll_vertical): Update.
5404         * tui/tui-layout.c (show_layout): Update.
5405         * tui/tui-disasm.c (tui_set_disassem_content)
5406         (tui_disasm_window::do_scroll_vertical): Update.
5407         * tui/tui-data.h (tui_win_content): Remove.
5408         (struct tui_gen_win_info) <content, content_size>: Remove.
5409         (struct tui_source_element): Add initializers and destructor.
5410         (union tui_which_element, struct tui_win_element): Remove.
5411         (struct tui_source_window_base) <content>: New field.
5412         (struct tui_data_window): Remove destructor.
5413         (tui_alloc_content, tui_free_win_content)
5414         (tui_free_all_source_wins_content): Don't declare.
5415         * tui/tui-data.c (tui_initialize_static_data): Update.
5416         (init_content_element, tui_alloc_content): Remove.
5417         (~tui_gen_win_info): Update.
5418         (~tui_data_window, tui_free_all_source_wins_content)
5419         (tui_free_win_content, free_content, free_content_elements):
5420         Remove.
5421
5422 2019-06-25  Tom Tromey  <tom@tromey.com>
5423
5424         * tui/tui-winsource.h (tui_clear_source_content)
5425         (tui_erase_source_content, tui_show_source_content): Change type
5426         of win_info.
5427         * tui/tui-winsource.c (tui_clear_source_content)
5428         (tui_erase_source_content, tui_show_source_content): Change type
5429         of win_info.
5430         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5431         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5432         win_info.
5433         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5434         win_info.
5435         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5436
5437 2019-06-25  Tom Tromey  <tom@tromey.com>
5438
5439         * tui/tui-winsource.c (tui_clear_source_content)
5440         (tui_source_window_base::set_is_exec_point_at): Update.
5441         * tui/tui-source.c (tui_set_source_content_nil): Update.
5442         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5443         a bool.
5444         * tui/tui-data.c (init_content_element): Update.
5445
5446 2019-06-25  Tom Tromey  <tom@tromey.com>
5447
5448         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5449         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5450         * tui/tui-layout.c (init_and_make_win): Update.
5451         * tui/tui.h (enum tui_win_type): Update.
5452         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5453         tui_win_is_auxillary.
5454         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5455         tui_win_is_auxillary.
5456
5457 2019-06-25  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5460         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5461         (tui_delete_data_content_windows, tui_display_all_data)
5462         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5463         Update.
5464         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5465         * tui/tui-regs.c (tui_last_regs_line_no)
5466         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5467         (tui_show_registers): Update.
5468         (tui_show_register_group): Return void.  Update.
5469         (tui_display_registers_from, tui_display_reg_element_at_line)
5470         (tui_display_registers_from_line, tui_check_register_values):
5471         Update.
5472         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5473         member.
5474         (struct tui_data_window) <regs_content>: Now a std::vector.
5475         <regs_content_count>: Remove.
5476         (tui_add_content_elements, tui_free_data_content): Don't declare.
5477         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5478         (init_content_element): Remove DATA_WIN case.  Add assert.
5479         (tui_add_content_elements): Remove.
5480         (tui_data_window): Update.
5481         (tui_free_data_content): Remove.
5482         (free_content_elements): Remove DATA_WIN case.
5483
5484 2019-06-25  Tom Tromey  <tom@tromey.com>
5485
5486         * tui/tui-data.c (tui_data_item_window): Update.
5487         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5488         * tui/tui-windata.c (tui_display_all_data)
5489         (tui_display_data_from_line): Update.
5490         (tui_check_data_values): Remove.
5491         * tui/tui-regs.c (tui_show_register_group)
5492         (tui_display_reg_element_at_line): Update.
5493         * tui/tui-hooks.c (tui_register_changed)
5494         (tui_refresh_frame_and_register_information): Call
5495         tui_check_register_values.
5496         * tui/tui-data.h (struct tui_data_window) <data_content,
5497         data_content_count, data_type>: Remove.
5498         (enum tui_data_type): Remove.
5499
5500         * tui/tui-data.c (tui_data_window::clear_detail)
5501         (~tui_data_window): Update.
5502
5503 2019-06-25  Tom Tromey  <tom@tromey.com>
5504
5505         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5506         declare.
5507         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5508         Rename from tui_first_data_item_displayed.  Update.
5509         (tui_data_window::refresh_all)
5510         (tui_data_window::do_scroll_vertical): Update.
5511         * tui/tui-data.h (struct tui_data_window)
5512         <first_data_item_displayed>: Declare new method.
5513
5514 2019-06-25  Tom Tromey  <tom@tromey.com>
5515
5516         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5517         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5518         contents...
5519         (tui_initialize_static_data): ...here.
5520
5521 2019-06-25  Tom Tromey  <tom@tromey.com>
5522
5523         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5524         (tui_display_registers_from, tui_check_register_values): Update.
5525         (tui_display_register): Remove win_info parameter; update.
5526         (tui_get_register): Change type of parameters.
5527         * tui/tui-data.h (struct tui_data_element): Remove.
5528         (union tui_which_element) <data>: Remove.
5529         <data_window>: Change type.
5530         (struct tui_data_item_window): New.
5531         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5532         case.  Add assert.
5533         (~tui_data_item_window): New destructor.
5534         (free_content_elements): Remove DATA_ITEM_WIN case.
5535
5536 2019-06-25  Tom Tromey  <tom@tromey.com>
5537
5538         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5539         Remove.
5540
5541 2019-06-25  Tom Tromey  <tom@tromey.com>
5542
5543         * tui/tui-data.h (struct tui_command_element): Remove.
5544         (union tui_which_element) <command>: Remove.
5545         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5546         assert.
5547         (free_content_elements): Remove CMD_WIN case.
5548
5549 2019-06-25  Tom Tromey  <tom@tromey.com>
5550
5551         * tui/tui-layout.c (tui_set_layout): Update.
5552         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5553         * tui/tui-data.c (layout_def): Update.
5554
5555 2019-06-25  Tom Tromey  <tom@tromey.com>
5556
5557         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5558         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5559         (tui_source_window_base::set_new_height): Update.
5560         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5561         Update.
5562         (tui_set_locator_fullname, tui_set_locator_info)
5563         (tui_show_frame_info): Update.
5564         * tui/tui-source.c (tui_set_source_content)
5565         (tui_source_is_displayed): Update.
5566         * tui/tui-layout.c (show_source_disasm_command, show_data)
5567         (show_source_or_disasm_and_command): Update.
5568         * tui/tui-disasm.c (tui_set_disassem_content)
5569         (tui_get_begin_asm_address): Update.
5570         * tui/tui-data.h (struct tui_locator_element): Remove.
5571         (union tui_which_element) <locator>: Remove.
5572         (struct tui_locator_window): New.
5573         (tui_locator_win_info_ptr): Change return type.
5574         * tui/tui-data.c (_locator): Change type.
5575         (tui_locator_win_info_ptr): Change return type.
5576         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5577         (tui_alloc_content): Add assert.
5578
5579 2019-06-25  Tom Tromey  <tom@tromey.com>
5580
5581         * tui/tui-winsource.c
5582         (tui_exec_info_window::maybe_allocate_content): New method.
5583         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5584         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5585         (make_source_or_disasm_window): Add cast.
5586         * tui/tui-data.h (union tui_which_element) <simple_string>:
5587         Remove.
5588         (struct tui_source_info): New.
5589         (struct tui_source_window_base) <execution_info>: Change type.
5590         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5591         case, and add assert.
5592         (tui_alloc_content): Add assert.
5593
5594 2019-06-25  Tom Tromey  <tom@tromey.com>
5595
5596         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5597         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5598         * tui/tui-data.c (tui_alloc_win_info): Remove.
5599
5600 2019-06-25  Tom Tromey  <tom@tromey.com>
5601
5602         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5603         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5604         can_highlight.
5605
5606 2019-06-25  Tom Tromey  <tom@tromey.com>
5607
5608         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5609         make_visible_with_new_height method.
5610         (tui_win_info::make_visible_with_new_height): New method.
5611         (tui_source_window_base::do_make_visible_with_new_height)
5612         (tui_data_window::do_make_visible_with_new_height)
5613         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5614         (make_visible_with_new_height): Remove.
5615         (tui_resize_all, tui_adjust_win_heights): Use
5616         make_visible_with_new_height method.
5617         * tui/tui-data.h (struct tui_win_info)
5618         <do_make_visible_with_new_height, make_visible_with_new_height>:
5619         New methods.
5620         (struct tui_source_window_base, struct tui_data_window)
5621         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5622         methods.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5627         method.
5628         (update_tab_width): Call update_tab_width method.
5629         * tui/tui-data.h (struct tui_win_info)
5630         (struct tui_source_window_base) <update_tab_width>: New methods.
5631
5632 2019-06-25  Tom Tromey  <tom@tromey.com>
5633
5634         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5635         parameter.
5636         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5637         parameter.
5638         (tui_gen_win_info::make_visible): Update.
5639         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5640         parameter.
5641         * tui/tui-data.h (enum tui_box): New enum.
5642         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5643
5644 2019-06-25  Tom Tromey  <tom@tromey.com>
5645
5646         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5647         init_and_make_win for EXEC_INFO_WIN.
5648         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5649         longer inline.
5650         (struct tui_win_info) <~tui_win_info>: Inline.
5651         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5652         Don't declare.
5653         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5654         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5655         Remove.
5656         (tui_initialize_static_data): Update.
5657         (~tui_gen_win_info): Handle more cleanup here.
5658         (~tui_source_window_base): Delete "execution_info".
5659         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5660
5661 2019-06-25  Tom Tromey  <tom@tromey.com>
5662
5663         * tui/tui-layout.c (make_command_window): Don't set
5664         can_highlight.
5665         (show_source_disasm_command): Call the reset method.
5666         (show_data): Don't set can_highlight.  Call the reset method.
5667         (tui_gen_win_info::reset): Rename from init_gen_win_info
5668         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5669         (show_source_or_disasm_and_command): Call the reset method.
5670         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5671         (struct tui_cmd_window): Set can_highlight.
5672
5673 2019-06-25  Tom Tromey  <tom@tromey.com>
5674
5675         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5676         from make_visible.
5677         (tui_make_visible, tui_make_invisible): Rewrite.
5678         (tui_win_info::make_visible): Remove.
5679         (tui_source_window_base::make_visible): Update.
5680         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5681         method.  Moved from...
5682         (struct tui_win_info) <make_visible>: ...here.
5683
5684 2019-06-25  Tom Tromey  <tom@tromey.com>
5685
5686         * tui/tui-winsource.c
5687         (tui_source_window_base::do_scroll_horizontal): Remove direction
5688         parameter.
5689         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5690         direction parameter.
5691         * tui/tui-win.c (tui_win_info::forward_scroll)
5692         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5693         (tui_win_info::right_scroll): Update.
5694         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5695         direction parameter.
5696         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5697         direction parameter.
5698         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5699         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5700         Remove direction parameter.
5701         (struct tui_source_window_base, struct tui_source_window)
5702         (struct tui_disasm_window, struct tui_data_window)
5703         (struct tui_cmd_window): Update.
5704
5705 2019-06-25  Tom Tromey  <tom@tromey.com>
5706
5707         * tui/tui-winsource.h (tui_set_exec_info_content)
5708         (tui_show_exec_info_content, tui_erase_exec_info_content)
5709         (tui_clear_exec_info_content, tui_update_exec_info): Change
5710         argument to tui_source_window_base.
5711         * tui/tui-winsource.c (tui_set_exec_info_content)
5712         (tui_show_exec_info_content, tui_erase_exec_info_content)
5713         (tui_clear_exec_info_content, tui_update_exec_info): Change
5714         argument to tui_source_window_base.
5715
5716 2019-06-25  Tom Tromey  <tom@tromey.com>
5717
5718         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5719         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5720
5721 2019-06-25  Tom Tromey  <tom@tromey.com>
5722
5723         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5724         check.
5725
5726 2019-06-25  Tom Tromey  <tom@tromey.com>
5727
5728         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5729         type to void.
5730         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5731         type to void.
5732         * tui/tui-source.c (tui_set_source_content): Update.
5733         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5734
5735 2019-06-25  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-win.c (window_name_completer, tui_set_focus)
5738         (tui_all_windows_info): Use name method.
5739         * tui/tui-data.h (struct tui_gen_win_info)
5740         (struct tui_source_window, struct tui_disasm_window)
5741         (struct tui_data_window, struct tui_cmd_window) <name>: New
5742         method.
5743         (tui_win_name): Don't declare.
5744         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5745         (tui_win_name): Remove.
5746
5747 2019-06-25  Tom Tromey  <tom@tromey.com>
5748
5749         * tui/tui-winsource.h (tui_update_source_window)
5750         (tui_update_source_window_as_is): Change parameter type.
5751         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5752         to be a tui_source_window_base.
5753         (tui_update_source_window_as_is): Likewise.
5754         * tui/tui-win.c (make_visible_with_new_height): Update.
5755
5756 2019-06-25  Tom Tromey  <tom@tromey.com>
5757
5758         * tui/tui-winsource.c (tui_erase_source_content)
5759         (tui_show_source_content, tui_show_exec_info_content)
5760         (tui_erase_exec_info_content): Use refresh_window method.
5761         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5762         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5763         from tui_refresh_win.
5764         (tui_data_window::refresh_window): New method.
5765         (tui_win_info::refresh, tui_source_window_base::refresh)
5766         (tui_refresh_all): Use refresh_window method.
5767         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5768         method.
5769         * tui/tui-regs.c (tui_display_register): Call refresh_window
5770         method.
5771         * tui/tui-layout.c (show_source_disasm_command)
5772         (show_source_or_disasm_and_command): Call refresh_window method.
5773         * tui/tui-data.h (struct tui_gen_win_info)
5774         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5775         New method.
5776
5777 2019-06-25  Tom Tromey  <tom@tromey.com>
5778
5779         * tui/tui.c (tui_rl_other_window, tui_enable)
5780         (tui_is_window_visible, tui_get_command_dimension): Update.
5781         * tui/tui-winsource.c (tui_update_source_window_as_is)
5782         (tui_clear_source_content, tui_erase_source_content)
5783         (tui_show_source_line, tui_source_window_base::refill)
5784         (tui_source_window_base::do_scroll_horizontal)
5785         (tui_source_window_base::set_is_exec_point_at)
5786         (tui_update_breakpoint_info, tui_set_exec_info_content)
5787         (tui_alloc_source_buffer, tui_line_is_displayed)
5788         (tui_addr_is_displayed): Update.
5789         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5790         (tui_check_and_display_highlight_if_needed)
5791         (tui_win_info::make_visible, tui_win_info::refresh)
5792         (tui_refresh_all): Update.
5793         * tui/tui-windata.c (tui_first_data_item_displayed)
5794         (tui_delete_data_content_windows, tui_erase_data_content)
5795         (tui_display_all_data, tui_data_window::refresh_all)
5796         (tui_check_data_values): Update.
5797         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5798         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5799         (tui_win_info::backward_scroll, tui_refresh_all_win)
5800         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5801         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5802         (tui_source_window_base::set_new_height)
5803         (tui_data_window::set_new_height)
5804         (make_invisible_and_set_new_height)
5805         (make_visible_with_new_height, new_height_ok)
5806         (parse_scrolling_args): Update.
5807         * tui/tui-stack.c (tui_show_frame_info): Update.
5808         * tui/tui-source.c (tui_set_source_content)
5809         (tui_set_source_content_nil, tui_source_is_displayed)
5810         (tui_source_window::do_scroll_vertical): Update.
5811         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5812         (tui_display_registers_from, tui_display_reg_element_at_line)
5813         (tui_check_register_values, tui_reg_command): Update.
5814         * tui/tui-layout.c (tui_default_win_height)
5815         (show_source_disasm_command, show_data, init_and_make_win)
5816         (show_source_or_disasm_and_command): Update.
5817         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5818         (tui_redisplay_readline, tui_mld_flush)
5819         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5820         (tui_getc): Update.
5821         * tui/tui-disasm.c (tui_set_disassem_content)
5822         (tui_disasm_window::do_scroll_vertical): Update.
5823         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5824         Now virtual.
5825         (struct tui_win_info): Derive from tui_gen_win_info.
5826         <~tui_win_info>: Mark as override.
5827         <generic>: Remove member.
5828         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5829         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5830         (~tui_data_window, ~tui_win_info)
5831         (tui_free_all_source_wins_content): Update.
5832         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5833
5834 2019-06-25  Tom Tromey  <tom@tromey.com>
5835
5836         * tui/tui-layout.c (init_and_make_win): Use new.
5837         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5838         destructor, initializers.
5839         (tui_alloc_generic_win_info): Don't declare.
5840         * tui/tui-data.c (_locator): Add argument to constructor.
5841         (source_win, disasm_win): New globals.
5842         (exec_info): Remove.
5843         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5844         Update.
5845         (tui_alloc_generic_win_info): Remove.
5846         (init_content_element): Use new.
5847         (tui_win_info::tui_win_info): Update.
5848         (free_content_elements) <case DATA_WIN>: Use delete.
5849
5850 2019-06-25  Tom Tromey  <tom@tromey.com>
5851
5852         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5853         * tui/tui-windata.c (tui_first_data_item_displayed)
5854         (tui_delete_data_content_windows): Update.
5855         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5856         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5857         (tui_display_registers_from, tui_check_register_values): Update.
5858         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5859         pointer.
5860         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5861         window.
5862         (tui_free_data_content): Update.
5863         (free_content_elements) <case DATA_WIN>: Free the window.
5864
5865 2019-06-25  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5868         Update.
5869         * tui/tui-layout.c (make_command_window)
5870         (show_source_disasm_command, show_data, init_and_make_win)
5871         (show_source_or_disasm_and_command): Update.
5872         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5873         method.
5874         <can_highight, is_highlighted>: Now bool.
5875         (tui_set_win_highlight): Don't declare.
5876         * tui/tui-data.c (tui_set_win_highlight): Remove.
5877
5878 2019-06-25  Tom Tromey  <tom@tromey.com>
5879
5880         * tui/tui-wingeneral.c (make_visible): Remove check of window
5881         type.
5882
5883 2019-06-25  Tom Tromey  <tom@tromey.com>
5884
5885         * tui/tui-win.c (tui_win_info::max_height)
5886         (tui_cmd_window::max_height): New methods.
5887         (new_height_ok): Call max_height.
5888         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5889         <max_height>: New method.
5890
5891 2019-06-25  Tom Tromey  <tom@tromey.com>
5892
5893         * tui/tui-win.c (tui_source_window_base::set_new_height)
5894         (tui_data_window::set_new_height): New methods.
5895         (make_invisible_and_set_new_height): Call set_new_height method.
5896         * tui/tui-data.h (struct tui_win_info)
5897         (struct tui_source_window_base, struct tui_data_window)
5898         <set_new_height>: New method.
5899
5900 2019-06-25  Tom Tromey  <tom@tromey.com>
5901
5902         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5903         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5904         tui_refresh_data_win.
5905         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5906         method.
5907         (tui_refresh_all_win): Call the refresh_all method.
5908         (tui_set_focus): Likewise.
5909         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5910         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5911         Likewise.
5912
5913 2019-06-25  Tom Tromey  <tom@tromey.com>
5914
5915         * tui/tui-winsource.h (tui_refill_source_window)
5916         (tui_set_is_exec_point_at): Don't declare.
5917         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5918         (tui_source_window_base::refill): Rename from
5919         tui_refill_source_window.
5920         (tui_source_window_base::do_scroll_horizontal): Update.
5921         (tui_source_window_base::set_is_exec_point_at): Rename from
5922         tui_set_is_exec_point_at.
5923         (tui_update_all_breakpoint_info): Update.
5924         * tui/tui-stack.c (tui_show_frame_info): Update.
5925         * tui/tui-layout.c (show_data): Add cast.
5926         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5927         * tui/tui-data.h (struct tui_source_window_base) <refill,
5928         set_is_exec_point_at>: New methods.
5929         (tui_source_windows, tui_add_to_source_windows): Update types.
5930         (tui_add_to_source_windows): Remove redundant declaration.
5931         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5932         (tui_source_windows): Change return type.
5933         (tui_clear_source_windows_detail): Update.
5934         (tui_add_to_source_windows): Change type of parameter.
5935         (tui_free_all_source_wins_content): Update.
5936
5937 2019-06-25  Tom Tromey  <tom@tromey.com>
5938
5939         * tui/tui-wingeneral.c (tui_win_info::refresh)
5940         (tui_source_window_base::refresh): New methods.
5941         (tui_refresh_all): Call the refresh method.
5942         * tui/tui-data.h (struct tui_win_info)
5943         (struct tui_source_window_base) <refresh>: New method.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui.h (tui_is_window_visible): Return bool.
5948         * tui/tui.c (tui_is_window_visible): Return bool.
5949         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5950         (tui_make_visible, tui_make_invisible)
5951         (tui_win_info::make_visible)
5952         (tui_source_window_base::make_visible, make_all_visible)
5953         (tui_make_all_visible, tui_make_all_invisible): Update.
5954         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5955         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5956         bool.
5957         (struct tui_win_info, struct tui_source_window_base)
5958         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5959         * tui/tui-data.c (tui_init_generic_part): Update.
5960
5961 2019-06-25  Tom Tromey  <tom@tromey.com>
5962
5963         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5964         (tui_source_window_base::make_visible): New methods.
5965         (make_all_visible): Make method call.
5966         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5967         (struct tui_source_window_base, struct tui_cmd_window): Override
5968         make_visible.
5969         (tui_win_is_source_type): Don't declare.
5970         * tui/tui-data.c (tui_win_is_source_type): Remove.
5971
5972 2019-06-25  Tom Tromey  <tom@tromey.com>
5973
5974         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5975         NULL check.
5976
5977 2019-06-25  Tom Tromey  <tom@tromey.com>
5978
5979         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5980         Inline constructor.  Add initializers for members.
5981         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5982         constructors; now inline in class.
5983
5984 2019-06-25  Tom Tromey  <tom@tromey.com>
5985
5986         * tui/tui-regs.c (tui_show_registers): Update.
5987         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5988         bool.
5989         * tui/tui-data.c (tui_data_window::clear_detail)
5990         (tui_data_window): Update.
5991
5992 2019-06-25  Tom Tromey  <tom@tromey.com>
5993
5994         * tui/tui-windata.c (tui_display_all_data)
5995         (tui_display_data_from_line, tui_display_data_from)
5996         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5997         Update.
5998         * tui/tui-regs.c (tui_last_regs_line_no)
5999         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6000         (tui_show_registers, tui_show_register_group)
6001         (tui_display_registers_from, tui_display_reg_element_at_line)
6002         (tui_display_registers_from_line, tui_check_register_values)
6003         (tui_reg_next, tui_reg_prev): Update.
6004         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6005         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6006         tui_data_window.
6007         (struct tui_win_info) <detail>: Remove.  Add new fields from
6008         tui_data_info.
6009         (TUI_DATA_WIN): Add cast.
6010         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6011         (~tui_data_window): Simplify.
6012
6013 2019-06-25  Tom Tromey  <tom@tromey.com>
6014
6015         * tui/tui-layout.c (show_source_disasm_command)
6016         (show_source_or_disasm_and_command): Update.
6017         * tui/tui-io.c (update_cmdwin_start_line)
6018         (tui_redisplay_readline): Update.
6019         * tui/tui-data.h (struct tui_command_info): Remove.
6020         (struct tui_win_info) <detail>: Remove command_info member.
6021         (struct tui_data_window) <start_line>: New member, from
6022         tui_command_info.
6023         (TUI_CMD_WIN): Add casts.
6024
6025 2019-06-25  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui-winsource.c (tui_update_source_window)
6028         (tui_refill_source_window)
6029         (tui_source_window_base::do_scroll_horizontal)
6030         (tui_update_breakpoint_info, tui_set_exec_info_content)
6031         (tui_show_exec_info_content, tui_erase_exec_info_content)
6032         (tui_clear_exec_info_content): Update.
6033         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6034         Update.
6035         * tui/tui-win.c (make_invisible_and_set_new_height)
6036         (make_visible_with_new_height): Update.
6037         * tui/tui-source.c (tui_set_source_content)
6038         (tui_show_symtab_source): Update.
6039         * tui/tui-layout.c (extract_display_start_addr)
6040         (show_source_disasm_command, show_data)
6041         (make_source_or_disasm_window)
6042         (show_source_or_disasm_and_command): Update.
6043         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6044         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6045         "gdbarch".
6046         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6047         to tui_source_window_base.
6048         (struct tui_win_info) <detail>: Remove source_info member.
6049         (struct tui_source_window_base) <has_locator>: Inline.
6050         Move contents from tui_source_info; rename has_locator member to
6051         m_has_locator.
6052         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6053         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6054         header file.
6055         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6056         Simplify.
6057         (tui_free_all_source_wins_content): Cast to
6058         tui_source_window_base.
6059
6060 2019-06-25  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-win.c (make_invisible_and_set_new_height)
6063         (make_visible_with_new_height): Call has_locator method.
6064         * tui/tui-layout.c (show_source_disasm_command, show_data)
6065         (show_source_or_disasm_and_command): Update for bool change.
6066         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6067         (tui_win_info) <has_locator>: New method.
6068         (struct tui_source_window_base) <has_locator>: New method.
6069         (tui_win_has_locator): Don't declare.
6070         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6071         from tui_win_has_locator.
6072         (tui_source_window_base): Use false, not FALSE.
6073
6074 2019-06-25  Tom Tromey  <tom@tromey.com>
6075
6076         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6077         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6078         clear_detail method directly.
6079         (tui_clear_win_detail): Remove.
6080
6081 2019-06-25  Tom Tromey  <tom@tromey.com>
6082
6083         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6084         "this", not TUI_DISASM_WIN.
6085
6086 2019-06-25  Tom Tromey  <tom@tromey.com>
6087
6088         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6089         declare.
6090         * tui/tui-winsource.c
6091         (tui_source_window_base::do_scroll_horizontal): Rename from
6092         tui_horizontal_source_scroll.
6093         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6094         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6095         from tui_vertical_data_scroll.
6096         * tui/tui-win.h (tui_scroll): Don't declare.
6097         * tui/tui-win.c (tui_win_info::forward_scroll)
6098         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6099         (tui_win_info::right_scroll): Rename and update.
6100         (tui_scroll_forward_command, tui_scroll_backward_command)
6101         (tui_scroll_left_command, tui_scroll_right_command): Update.
6102         (tui_scroll): Remove.
6103         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6104         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6105         from tui_vertical_source_scroll.
6106         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6107         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6108         from tui_vertical_disassem_scroll.
6109         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6110         do_scroll_horizontal>: New methods.
6111         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6112         Likewise.
6113         (struct tui_source_window_base): Add do_scroll_horizontal.
6114         (struct tui_source_window, struct tui_disasm_window): Add
6115         do_scroll_vertical.
6116         (struct tui_data_window, struct tui_cmd_window): Add
6117         do_scroll_horizontal and do_scroll_vertical.
6118         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6119
6120 2019-06-25  Tom Tromey  <tom@tromey.com>
6121
6122         * tui/tui-data.h (struct tui_source_window_base): New struct.
6123         (struct tui_source_window): Derive from tui_source_window_base.
6124         (struct tui_disasm_window): New struct.
6125         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6126         from tui_source_window::clear_detail.
6127         (tui_source_window_base): Rename from tui_source_window.
6128         (~tui_source_window_base): Rename from ~tui_source_window.
6129         (tui_alloc_win_info): Create a tui_disasm_window.
6130
6131 2019-06-25  Tom Tromey  <tom@tromey.com>
6132
6133         * tui/tui-data.h (struct tui_source_window)
6134         (struct tui_data_window): Declare destructors.
6135         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6136         destructors.
6137         (tui_win_info): Simplify.
6138
6139 2019-06-25  Tom Tromey  <tom@tromey.com>
6140
6141         * tui/tui-winsource.c (tui_display_main)
6142         (tui_update_source_windows_with_addr)
6143         (tui_update_all_breakpoint_info): Update.
6144         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6145         (new_height_ok, parse_scrolling_args): Update.
6146         * tui/tui-stack.c (tui_show_frame_info): Update.
6147         * tui/tui-data.h (struct tui_list): Remove.
6148         (tui_source_windows): Return a reference to a std::vector.
6149         * tui/tui-data.c (source_windows): Now a std::vector.
6150         (tui_source_windows): Change return type.
6151         (tui_clear_source_windows): Rewrite.
6152         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6153         (tui_free_all_source_wins_content): Rewrite.
6154
6155 2019-06-25  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6158         (struct tui_data_window, struct tui_cmd_window): Declare
6159         clear_detail method.
6160         * tui/tui-data.c (tui_source_window::clear_detail)
6161         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6162         methods.
6163         (tui_clear_win_detail): Simplify.
6164
6165 2019-06-25  Tom Tromey  <tom@tromey.com>
6166
6167         * tui/tui-layout.c (make_source_window, make_disasm_window)
6168         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6169         Return the new window.
6170         (show_source_disasm_command, show_data)
6171         (show_source_or_disasm_and_command): Update.
6172
6173 2019-06-25  Tom Tromey  <tom@tromey.com>
6174
6175         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6176         parameter.  Return the new window.
6177         (show_source_disasm_command): Update and remove NULL check.
6178         (show_source_or_disasm_and_command): Update.
6179
6180 2019-06-25  Tom Tromey  <tom@tromey.com>
6181
6182         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6183
6184 2019-06-25  Tom Tromey  <tom@tromey.com>
6185
6186         * tui/tui-data.h (struct tui_win_info): Make constructor
6187         protected.  Make destructor virtual.  Add initializers.
6188         (tui_source_window, tui_data_window, tui_cmd_window): New
6189         classes.
6190         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6191         constructor.  Add "type" parameter.
6192         (tui_source_window, tui_data_window, tui_cmd_window): New
6193         constructors.
6194         (tui_alloc_win_info): Instantiate the appropriate subclass.
6195
6196 2019-06-25  Tom Tromey  <tom@tromey.com>
6197
6198         * tui/tui-win.c (tui_resize_all): Use delete.
6199         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6200         destructor.
6201         (tui_free_window): Don't declare.
6202         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6203         Update.
6204
6205 2019-06-25  Tom Tromey  <tom@tromey.com>
6206
6207         * tui/tui-data.h (struct tui_win_info): Add constructor.
6208         * tui/tui-data.c (tui_alloc_win_info): Use new.
6209         (tui_free_window): Use delete.
6210
6211 2019-06-22  Tom Tromey  <tom@tromey.com>
6212
6213         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6214         declare.
6215         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6216
6217 2019-06-22  Tom Tromey  <tom@tromey.com>
6218
6219         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6220         declare.
6221         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6222
6223 2019-06-22  Tom de Vries  <tdevries@suse.de>
6224
6225         * dwarf2read.c (create_addrmap_from_aranges)
6226         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6227         instead of '%zu'.
6228
6229 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6230
6231         * dwarf2read.h (dwarf2_section_info_def): Remove.
6232         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6233         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6234         std::vector<dwarf2_section_info>.
6235         (struct dwo_file) <~dwo_file>: Remove.
6236         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6237         types field.
6238         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6239         (dwarf2_read_debug_names): Likewise.
6240         (create_debug_types_hash_table): Change parameter type to
6241         array_view, adjust code accordingly.
6242         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6243         (partial_die_info::fixup): Likewise.
6244         (determine_prefix): Likewise.
6245         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6246
6247 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6248
6249         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6250         gdb_bfd_ref_ptr.
6251         <~dwo_file>: Remove call to gdb_bfd_unref.
6252         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6253         gdb_bfd_ref_ptr::get.
6254
6255 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6256
6257         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6258         type to htab_up.
6259         * dwarf2read.c (struct dwo_file): Initialize fields.
6260         <~dwo_file>: New.
6261         (free_dwo_file): Remove, move content to ~dwo_file.
6262         (struct dwo_file_deleter): Remove.
6263         (dwo_file_up>: Remove custom deleter.
6264         (free_dwo_files): Remove.
6265         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6266         dwo_files.
6267         (process_skeletonless_type_units): Call unique_ptr::get.
6268         (allocate_dwo_file_hash_table): Add deleter to created hash
6269         table.  Change return type to htab_up.
6270         (lookup_dwo_file_slot): Don't memset dwo_file, call
6271         unique_ptr::get.
6272         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6273         (create_dwo_unit_in_dwp_v2): Likewise.
6274         (open_and_init_dwo_file): Likewise.
6275         (free_dwo_file_from_slot): Remove.
6276
6277 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6278
6279         * dwarf2read.h (struct dwarf2_section_info) <readin,
6280         is_virtual>: Change type to bool.
6281         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6282         true instead of 1.
6283
6284 2019-06-19  Tom Tromey  <tom@tromey.com>
6285
6286         * tui/tui-data.h (tui_init_content_element): Don't declare.
6287
6288 2019-06-19  Tom Tromey  <tom@tromey.com>
6289
6290         * tui/tui-data.h (tui_init_win_info): Don't declare.
6291
6292 2019-06-19  Tom de Vries  <tdevries@suse.de>
6293
6294         * dwarf2read.h (abstract_to_concrete): Change type to
6295         std::unordered_map<sect_offset, std::vector<sect_offset>,
6296         gdb::hash_enum<sect_offset>>.
6297
6298 2019-06-19  Tom Tromey  <tromey@adacore.com>
6299
6300         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6301         EVAL_AVOID_SIDE_EFFECTS specially.
6302
6303 2019-06-19  Tom Tromey  <tromey@adacore.com>
6304
6305         * source-cache.c (highlighter): New global.
6306         (source_cache::get_source_lines): Create a highlighter on demand.
6307
6308 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6309
6310         * defs.h (deprecated_interactive_hook): Delete declaration.
6311         * interps.c (clear_interpreter_hooks): Remove use of
6312         deprecated_interactive_hook.
6313         * top.c (deprecated_interactive_hook): Delete definition.
6314         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6315
6316 2019-06-18  Tom de Vries  <tdevries@suse.de>
6317
6318         PR gdb/24515
6319         * dwarf2read.h (abstract_to_concrete): Change type from
6320         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6321         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6322         * dwarf2read.c (read_variable): Update.
6323         (dwarf2_fetch_die_loc_sect_off): Update.
6324
6325 2019-06-17  Tom de Vries  <tdevries@suse.de>
6326
6327         PR gdb/24617
6328         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6329         accessing parent[parent_len - 1].
6330
6331 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6332
6333         PR gdb/24364
6334         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6335         call dtrace_process_dof with NULL dof.
6336
6337 2019-06-16  Tom de Vries  <tdevries@suse.de>
6338
6339         PR gdb/24445
6340         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6341
6342 2019-06-16  Tom Tromey  <tom@tromey.com>
6343
6344         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6345         (make_all_visible): Use address of member.
6346
6347 2019-06-16  Tom Tromey  <tom@tromey.com>
6348
6349         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6350         (tui_free_window, free_content, free_content_elements): Remove
6351         unnecessary cast.
6352         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6353         cast.
6354         * tui/tui-regs.c (tui_show_register_group)
6355         (tui_display_registers_from, tui_display_reg_element_at_line):
6356         Remove unnecessary cast.
6357
6358 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * linux-nat.c (normal_mask): Delete.
6361         (_initialize_linux_nat): Don't initialise normal_mask.
6362
6363 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6364
6365         PR gdb/24445
6366         * dwarf-index-write.h (write_psymtabs_to_index): Add
6367         dwz_basename parameter.
6368         * dwarf-index-write.c (write_gdbindex): Move file writing to
6369         write_gdbindex_1.  Change return type void.
6370         (assert_file_size): Move up, remove filename parameter.
6371         (write_gdbindex_1): New function.
6372         (write_debug_names): Change return type to void, call
6373         assert_file_size.
6374         (struct index_wip_file): New struct.
6375         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6376         file logic to index_wip_file.  Write index for dwz file if
6377         needed.
6378         (save_gdb_index_command): Pass basename of dwz file, if present.
6379         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6380         build-id of dwz file, if present.
6381         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6382         (dwarf2_get_dwz_file): Likewise.
6383         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6384         (dwarf2_get_dwz_file): Likewise.
6385
6386 2019-06-16  Tom Tromey  <tom@tromey.com>
6387
6388         * coffread.c (process_coff_symbol): Use xstrdup.
6389         * value.c (create_internalvar): Use xstrdup.
6390
6391 2019-06-16  Tom Tromey  <tom@tromey.com>
6392
6393         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6394         * breakpoint.c (stopin_command, stopat_command)
6395         (until_break_command, decode_location_default): Remove unnecessary
6396         cast.
6397         * utils.c (subset_compare): Remove unnecessary cast.
6398         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6399         cast.
6400         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6401         cast.
6402         * infcmd.c (path_command): Remove unnecessary cast.
6403         * coffread.c (decode_type): Remove unnecessary cast.
6404         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6405         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6406         * tui/tui-stack.c (tui_show_locator_content)
6407         (tui_show_frame_info): Remove unnecessary cast.
6408         * tui/tui-win.c (tui_scroll_forward_command)
6409         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6410         (parse_scrolling_args): Remove unnecessary cast.
6411         * tui/tui-data.c (init_win_info, tui_del_window)
6412         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6413         (free_content_elements): Remove unnecessary cast.
6414         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6415         unnecessary cast.
6416         * tui/tui-source.c (tui_set_source_content)
6417         (tui_vertical_source_scroll): Remove unnecessary cast.
6418         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6419         cast.
6420         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6421         * tui/tui-regs.c (tui_display_registers_from)
6422         (tui_display_register): Remove unnecessary cast.
6423         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6424         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6425         (make_visible): Remove unnecessary cast.
6426         * tui/tui-winsource.c (tui_erase_source_content)
6427         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6428         unnecessary cast.
6429         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6430         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6431         * stabsread.c (read_type, read_array_type, read_range_type):
6432         Remove unnecessary cast.
6433         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6434         (parse_symbol, parse_type, upgrade_type, parse_external)
6435         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6436         unnecessary cast.
6437         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6438
6439 2019-06-16  Tom Tromey  <tom@tromey.com>
6440
6441         * tui/tui-data.c (tui_alloc_generic_win_info)
6442         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6443         checks.
6444
6445 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6446             Andrew Burgess  <andrew.burgess@embecosm.com>
6447
6448         * f-typeprint.c (f_print_type): Don't return early for not
6449         associated or not allocated types.
6450         (f_type_print_varspec_suffix): Add print_rank parameter and print
6451         ranks of array types in case they dangling.
6452         (f_type_print_base): Add print_rank parameter.
6453
6454 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * NEWS: Mention new MI commands.
6457         * break-catch-throw.c (enum exception_event_kind): Move to
6458         breakpoint.h.
6459         (print_mention_exception_catchpoint): Output text as a single
6460         message.
6461         (catch_exception_command_1): Rename to...
6462         (catch_exception_event): ...this, make non-static, update header
6463         command, and change some parameter types.
6464         (catch_catch_command): Update for changes to
6465         catch_exception_command_1.
6466         (catch_throw_command): Likewise.
6467         (catch_rethrow_command): Likewise.
6468         * breakpoint.c (enum exception_event_kind): Delete.
6469         * breakpoint.h (enum exception_event_kind): Moved here from
6470         break-catch-throw.c.
6471         (catch_exception_event): Declare.
6472         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6473         (mi_cmd_catch_throw): New function.
6474         (mi_cmd_catch_rethrow): New function.
6475         (mi_cmd_catch_catch): New function.
6476         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6477         'catch-catch' entries.
6478         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6479         (mi_cmd_catch_rethrow): Declare.
6480         (mi_cmd_catch_catch): Declare.
6481
6482 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6483
6484         * annotate.c (annotate_source_line): Change return type to void,
6485         update implementation to match.
6486         * annotate.h (annotate_source_line): Change return type to void,
6487         update header comment.
6488         * stack.c (print_frame_info): Don't change what frame information
6489         is printed based on whether annotations are on or not.
6490
6491 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6492
6493         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6494         (annotate_source): Make static.
6495         (annotate_source_line): Moved from source.c and renamed from
6496         identify_source_line.  Update the return type.
6497         * annotate.h (annotate_source): Delete declaration.
6498         (annotate_source_line): Declaration moved from source.h, and
6499         renamed from identify_source_line.  Return type updated.
6500         * source.c (identify_source_line): Moved to annotate.c and renamed
6501         to annotate_source_line.
6502         (info_line_command): Remove check of annotation_level.
6503         * source.h (identify_source_line): Move declaration to annotate.h
6504         and rename to annotate_source_line.
6505         * stack.c: Add 'annotate.h' include.
6506         (print_frame_info): Remove check of annotation_level before
6507         calling annotate_source_line.
6508
6509 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * source-cache.c (source_cache::get_plain_source_lines): Use
6512         open_source_file_with_line_charpos instead of just
6513         open_source_file, remove call to find_source_lines.
6514         (source_cache::get_source_lines): Likewise.
6515         * source.c (find_source_lines): Make static.
6516         (get_filename_and_charpos): Renamed into...
6517         (open_source_file_with_line_charpos): ..this along with changes to
6518         return a scoped_fd, and some other minor clean ups.
6519         (identify_source_line): Use open_source_file_with_line_charpos.
6520         (search_command_helper): Use open_source_file_with_line_charpos
6521         instead of just open_source_file, remove call to
6522         find_source_lines.
6523         * source.h (open_source_file_with_line_charpos): Declare new
6524         function.
6525         (find_source_lines): Delete declaration.
6526
6527 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6528
6529         * source.c (get_filename_and_charpos): Remove fullname
6530         parameter.
6531         (identify_source_line): Update call to get_filename_and_charpos.
6532
6533 2019-06-14  Tom Tromey  <tromey@adacore.com>
6534
6535         PR gdb/24502:
6536         * ui-style.h (skip_ansi_escape): Update comment.
6537         * ui-file.h (class no_terminal_escape_file): New class.
6538         * ui-file.c (no_terminal_escape_file::write)
6539         (no_terminal_escape_file::puts): New methods.
6540         * cli/cli-logging.c (handle_redirections): Use
6541         no_terminal_escape_file.
6542
6543 2019-06-14  Tom Tromey  <tromey@adacore.com>
6544
6545         * NEWS: Move convenience variable news above Python news.
6546
6547 2019-06-14  Tom Tromey  <tom@tromey.com>
6548
6549         * gnulib: Move directory to top-level.
6550         * configure.ac: Don't configure gnulib.
6551         * configure: Rebuild.
6552         * common/common-defs.h: Use new path to gnulib.
6553         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6554         (GNULIB_H): Remove.
6555         (INCGNU): Look in new gnulib location.
6556         (HFILES_NO_SRCDIR): Remove gnulib files.
6557         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6558         (generated_files): Remove GNULIB_H.
6559         ($(LIBGNU), all-lib): Remove targets.
6560         (distclean): Don't mention GNULIB_BUILDDIR.
6561         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6562
6563 2019-06-14  Tom Tromey  <tromey@adacore.com>
6564
6565         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6566         Warn if symbol file does not provide any symbols.
6567
6568 2019-06-14  Tom Tromey  <tromey@adacore.com>
6569
6570         * source.c (find_and_open_source): Respect basenames_may_differ.
6571
6572 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6573
6574         * annotate.c (annotate_breakpoints_invalid): Make use of
6575         scoped_restore_terminal_state.
6576         (annotate_frames_invalid): Likewise.
6577
6578 2019-06-14  Tom Tromey  <tromey@adacore.com>
6579
6580         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6581         allow assignment to an internalvar.
6582
6583 2019-06-14  Tom Tromey  <tromey@adacore.com>
6584
6585         * ada-lex.l: Allow "_" in attribute names.
6586
6587 2019-06-14  Tom Tromey  <tromey@adacore.com>
6588
6589         PR gdb/24653:
6590         * regcache.c (registers_changed): Don't call alloca.
6591         * top.c (execute_command): Don't call alloca.
6592
6593 2019-06-13  Pedro Alves  <palves@redhat.com>
6594
6595         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6596         'expression'.  When parsing an expression, error out if there's
6597         junk after "unlimited".
6598         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6599         (do_set_command): Adjust calls to is_unlimited_literal.
6600
6601 2019-06-13  Pedro Alves  <palves@redhat.com>
6602
6603         * compile/compile.c (make_compile_options_def_group): Add braces
6604         around array_view initializer.
6605         * thread.c (make_thread_apply_all_options_def_group)
6606         (make_thread_apply_all_options_def_group): Likewise.
6607
6608 2019-06-13  Pedro Alves  <palves@redhat.com>
6609
6610         * NEWS (New commands): Mention "maint test-options
6611         require-delimiter", "maint test-options unknown-is-error", "maint
6612         test-options unknown-is-operand" and "maint show
6613         test-options-completion-result".
6614         (New command options, command completion): New section.
6615         (Completion improvements): New section.
6616         Mention that you can abbreviate "unlimited".
6617
6618 2019-06-13  Pedro Alves  <palves@redhat.com>
6619
6620         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6621         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6622         * unittests/cli-utils-selftests.c (test_parse_flags)
6623         (test_parse_flags_qcs): Delete.
6624         (test_cli_utils): Don't call deleted functions.
6625
6626 2019-06-13  Pedro Alves  <palves@redhat.com>
6627
6628         * thread.c: Include "cli/cli-option.h".
6629         (tp_array_compar_ascending): Global.
6630         (tp_array_compar): Delete function.
6631         (tp_array_compar_ascending, tp_array_compar_descending): New
6632         functions.
6633         (ascending_option_def, qcs_flag_option_def)
6634         (thr_qcs_flags_option_defs)
6635         (make_thread_apply_all_options_def_group)
6636         (make_thread_apply_options_def_group): New.
6637         (thread_apply_all_command): Use gdb::option::process_options.
6638         (thread_apply_command_completer)
6639         (thread_apply_all_command_completer): New.
6640         (thread_apply_command): Use gdb::option::process_options.
6641         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6642         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6643         to generate help text of "thread apply".  Adjust "taas"'s help.
6644         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6645         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6646
6647 2019-06-13  Pedro Alves  <palves@redhat.com>
6648
6649         * thread.c (thread_apply_command): Check for invalid TID with
6650         isdigit instead of !isalpha.
6651
6652 2019-06-13  Pedro Alves  <palves@redhat.com>
6653
6654         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6655         (validate_flags_qcs): New.
6656         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6657         (validate_flags_qcs): Declare.
6658         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6659         (make_frame_apply_options_def_group): New.
6660         (frame_apply_command_count): Process options with
6661         gdb::option::process_options.
6662         (frame_apply_completer): New.
6663         (frame_apply_level_completer, frame_apply_all_completer)
6664         (frame_apply_completer): New.
6665         (_initialize_stack): Update help of "frame apply", "frame apply
6666         level", "frame apply all" and "faas" to mention supported options
6667         and install command completers.
6668         * stack.h (frame_apply_all_completer): Declare.
6669         * thread.c: Include "stack.h".
6670         (tfaas_command): Add "--".
6671         (_initialize_thread): Update help "tfaas" to mention supported
6672         options and install command completer.
6673
6674 2019-06-13  Pedro Alves  <palves@redhat.com>
6675
6676         * completer.c (complete_nested_command_line): New.
6677         (gdb_completion_word_break_characters_throw): Add assertion.
6678         * completer.h (complete_nested_command_line): Declare.
6679
6680 2019-06-13  Pedro Alves  <palves@redhat.com>
6681
6682         * stack.c (parse_backtrace_qualifiers): New.
6683         (backtrace_command): Use it.
6684         (backtrace_command_completer): Complete on qualifiers.
6685
6686 2019-06-13  Pedro Alves  <palves@redhat.com>
6687
6688         * frame.c: Include "cli/cli-option.h.
6689         (user_set_backtrace_options): New.
6690         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6691         Delete.
6692         (get_prev_frame): Adjust.
6693         (boolean_option_def, uinteger_option_def)
6694         (set_backtrace_option_defs): New.
6695         (_initialize_frame): Adjust and use
6696         gdb::option::add_setshow_cmds_for_options to install "set
6697         backtrace past-main" and "set backtrace past-entry".
6698         * frame.h: Include "cli/cli-option.h".
6699         (struct frame_print_options): Forward declare.
6700         (print_frame_arguments_all, print_frame_arguments_scalars)
6701         (print_frame_arguments_none): Declare.
6702         (print_entry_values): Delete declaration.
6703         (struct frame_print_options, user_frame_print_options): New.
6704         (struct set_backtrace_options): New.
6705         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6706         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6707         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6708         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6709         (list_args_or_locals): Add frame_print_options parameter.
6710         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6711         * python/py-framefilter.c (enumerate_args): Pass down
6712         USER_FRAME_PRINT_OPTIONS.
6713         * stack.c: Include "cli/cli-option.h".
6714         (print_frame_arguments_all, print_frame_arguments_scalars)
6715         (print_frame_arguments_none): Declare.
6716         (print_raw_frame_arguments, print_entry_values): Delete.
6717         (user_frame_print_options): New.
6718         (boolean_option_def, enum_option_def, frame_print_option_defs):
6719         New.
6720         (struct backtrace_cmd_options): New.
6721         (bt_flag_option_def): New.
6722         (backtrace_command_option_defs): New.
6723         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6724         (print_frame_arg, read_frame_arg, print_frame_args)
6725         (print_frame_info, print_frame): Add frame_print_options parameter
6726         and use it.
6727         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6728         (backtrace_command_1): Add frame_print_options and
6729         backtrace_cmd_options parameters and use them.
6730         (make_backtrace_options_def_group): New.
6731         (backtrace_command): Process command options with
6732         gdb::option::process_options.
6733         (backtrace_command_completer): New.
6734         (_initialize_stack): Extend "backtrace"'s help to mention
6735         supported options.  Install completer for "backtrace".
6736         Install some settings commands with add_setshow_cmds_for_options.
6737
6738 2019-06-13  Pedro Alves  <palves@redhat.com>
6739
6740         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6741         and that "set/show print raw frame-arguments" are now deprecated.
6742
6743         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6744         command.
6745         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6746         * stack.c (_initialize_stack): Install "set/show print
6747         raw-frame-arguments", and deprecate "set/show print raw
6748         frame-arguments".
6749         * valprint.c (_initialize_valprint): Deprecate "set/show print
6750         raw".
6751
6752 2019-06-13  Pedro Alves  <palves@redhat.com>
6753
6754         * compile/compile.c (struct compile_options): New.
6755         (compile_flag_option_def, compile_command_option_defs)
6756         (make_compile_options_def_group): New.
6757         (compile_file_command): Handle options with
6758         gdb::option::process_options.
6759         (compile_file_command_completer): New function.
6760         (compile_code_command): Handle options with
6761         gdb::option::process_options.
6762         (compile_code_command_completer): New function.
6763         (_initialize_compiler): Install completers for "compile code" and
6764         "compile file".  Mention available options in "compile code" and
6765         "compile code"'s help.
6766         * completer.c (advance_to_completion_word): New, factored out from
6767         ...
6768         (advance_to_expression_complete_word_point): ... this.
6769         (advance_to_filename_complete_word_point): New.
6770         * completer.h (advance_to_filename_complete_word_point): New
6771         declaration.
6772
6773 2019-06-13  Pedro Alves  <palves@redhat.com>
6774
6775         * compile/compile.c: Include "cli/cli-option.h".
6776         (compile_print_value): Scope data pointer is now a
6777         value_print_options pointer; adjust.
6778         (compile_print_command): Process options.  Scope data pointer is
6779         now a value_print_options pointer; adjust.
6780         (_initialize_compile): Update "compile print"'s help to include
6781         supported options.  Install a completer for "compile print".
6782         * cp-valprint.c (show_vtblprint, show_objectprint)
6783         (show_static_field_print): Delete.
6784         (_initialize_cp_valprint): Don't install "set print
6785         static-members", "set print vtbl", "set print object" here.
6786         * printcmd.c: Include "cli/cli-option.h" and
6787         "common/gdb_optional.h".
6788         (print_command_parse_format): Rework to fill in a
6789         value_print_options instead of a format_data.
6790         (print_value): Change parameter type from format_data pointer to
6791         value_print_options reference.  Adjust.
6792         (print_command_1): Process options.  Adjust to pass down a
6793         value_print_options.
6794         (print_command_completer): New.
6795         (_initialize_printcmd): Install print_command_completer as
6796         handle_brkchars completer for the "print" command.  Update
6797         "print"'s help to include supported options.
6798         * valprint.c: Include "cli/cli-option.h".
6799         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6800         here from cp-valprint.c.
6801         (boolean_option_def, uinteger_option_def)
6802         (value_print_option_defs, make_value_print_options_def_group):
6803         New.  Use gdb::option::add_setshow_cmds_for_options to install
6804         "set print elements", "set print null-stop", "set print repeats",
6805         "set print pretty", "set print union", "set print array", "set
6806         print address", "set print symbol", "set print array-indexes".
6807         * valprint.h: Include <string> and "cli/cli-option.h".
6808         (make_value_print_options_def_group): Declare.
6809         (print_value): Change parameter type from format_data pointer to
6810         value_print_options reference.
6811         (print_command_completer): Declare.
6812
6813 2019-06-13  Pedro Alves  <palves@redhat.com>
6814
6815         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6816         (COMMON_SFILES): Add maint-test-settings.c.
6817         * cli/cli-decode.c (boolean_enums): New global, factored out from
6818         ...
6819         (add_setshow_boolean_cmd): ... here.
6820         * cli/cli-decode.h (boolean_enums): Declare.
6821         * cli/cli-option.c: New file.
6822         * cli/cli-option.h: New file.
6823         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6824         factored out from ...
6825         (parse_cli_boolean_value(const char *)): ... this.
6826         (is_unlimited_literal): Change parameter type to pointer to
6827         pointer.  Adjust and advance ARG pointer.
6828         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6829         (parse_cli_var_enum): New, factored out from ...
6830         (do_set_command): ... this.  Adjust.
6831         * cli/cli-setshow.h (parse_cli_boolean_value)
6832         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6833         (parse_cli_var_enum): Declare.
6834         * cli/cli-utils.c: Include "cli/cli-option.h".
6835         (get_ulongest): New.
6836         * cli/cli-utils.h (get_ulongest): Declare.
6837         (check_for_argument): New overloads.
6838         * maint-test-options.c: New file.
6839
6840 2019-06-13  Pedro Alves  <palves@redhat.com>
6841
6842         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6843         parse a range if "-" is at the end of the string.
6844
6845 2019-06-13  Pedro Alves  <palves@redhat.com>
6846
6847         * cli/cli-setshow.c (parse_auto_binary_operation)
6848         (parse_cli_boolean_value): Don't allow "o".
6849
6850 2019-06-13  Pedro Alves  <palves@redhat.com>
6851
6852         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6853         * NEWS: Mention maint test-settings KIND.
6854         * maint-test-settings.c: New file.
6855
6856 2019-06-13  Pedro Alves  <palves@redhat.com>
6857
6858         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6859         completer.
6860         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6861         "set" completers.
6862
6863 2019-06-13  Pedro Alves  <palves@redhat.com>
6864
6865         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6866         after item.
6867
6868 2019-06-13  Pedro Alves  <palves@redhat.com>
6869
6870         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6871
6872 2019-06-13  Pedro Alves <palves@redhat.com>
6873
6874         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6875         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6876         call.
6877         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6878         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6879         calls.
6880         (check_for_argument): Skip spaces after argument.
6881
6882 2019-06-13  Pedro Alves  <palves@redhat.com>
6883
6884         * thread.c (thread_apply_command): Adjust TID parsing.
6885         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6886         detected before end of string.
6887         (tid_is_in_list): Error out if LIST is invalid.
6888
6889 2019-06-13  Pedro Alves  <palves@redhat.com>
6890
6891         * completer.c (complete_line_internal_1): Rewind completion word
6892         point.
6893         (completion_tracker::advance_custom_word_point_by): Change
6894         parameter type to int.
6895         * completer.h (completion_tracker::advance_custom_word_point_by):
6896         Likewise.
6897
6898 2019-06-13  Pedro Alves  <palves@redhat.com>
6899
6900         * completer.c (advance_to_completion_word): Handle delimiters.
6901
6902 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6903
6904         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6905
6906 2019-06-11  Tom Tromey  <tom@tromey.com>
6907
6908         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6909         (xmalloc_failed): Move to alloc.c.
6910         * alloc.c: New file.
6911         * Makefile.in (COMMON_SFILES): Add alloc.c.
6912
6913 2019-06-11  Tom Tromey  <tom@tromey.com>
6914
6915         * nat/linux-waitpid.c: Don't include server.h.
6916         (linux_debug): Remove.
6917         (my_waitpid): Update.
6918
6919 2019-06-11  Tom Tromey  <tromey@adacore.com>
6920
6921         * infcall.c (_initialize_infcall): Remove trailing newline from
6922         help.
6923         * user-regs.c (_initialize_user_regs): Remove trailing newline
6924         from help.
6925         * typeprint.c (_initialize_typeprint): Remove trailing newline
6926         from help.
6927         * reverse.c (_initialize_reverse): Remove trailing newlines from
6928         help.
6929         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6930         from help.
6931         * language.c (add_set_language_command): Remove trailing newline
6932         from help.
6933         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6934         help.
6935         * disasm.c (_initialize_disasm): Remove trailing newline from
6936         help.
6937         * top.c (init_main): Remove trailing newline from help.
6938         * interps.c (_initialize_interpreter): Remove trailing newline
6939         from help.
6940         * btrace.c (_initialize_btrace): Remove trailing newlines from
6941         help.
6942         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6943         from help.
6944         * python/python.c (_initialize_python): Remove trailing newline
6945         from help.
6946         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6947         help.
6948         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6949         from help.  Reformat some text.
6950         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6951         from help.
6952         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6953         newline from help.
6954
6955 2019-06-11  Tom Tromey  <tromey@adacore.com>
6956
6957         * darwin-nat.c (darwin_decode_exception_message)
6958         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6959
6960 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6961
6962         * valops.c (value_slice): Check for not allocated or not
6963         associated values.
6964
6965 2019-06-10  Tom de Vries  <tdevries@suse.de>
6966
6967         PR gdb/24618
6968         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6969         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6970         invalid.
6971
6972 2019-06-10  Tom de Vries  <tdevries@suse.de>
6973
6974         PR gdb/24611
6975         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6976         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6977
6978 2019-06-10  Tom de Vries  <tdevries@suse.de>
6979
6980         PR symtab/24545
6981         * symtab.c (struct demangled_name_entry): Add language field.
6982         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6983         static minimal symbol".  Set and use language field.
6984
6985 2019-06-10  Tom Tromey  <tromey@adacore.com>
6986
6987         * ada-lang.c (_initialize_ada_language): Update help text.
6988
6989 2019-06-10  Tom Tromey  <tromey@adacore.com>
6990
6991         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6992         with a newline.
6993         * guile/guile.c (handle_boot_error): Don't end warning with a
6994         newline.
6995         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6996         warning with a newline.
6997         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6998         newline.
6999         (s12z_frame_cache): Likewise.
7000         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7001         a newline.
7002         * solib-svr4.c (disable_probes_interface): Don't end warning with
7003         a newline.
7004         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7005         newline.
7006         * python/python.c (do_finish_initialization): Don't end warning
7007         with a newline.
7008
7009 2019-06-10  Tom Tromey  <tom@tromey.com>
7010
7011         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7012         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7013         gdbpy_enter.
7014
7015 2019-06-10  Tom Tromey  <tromey@adacore.com>
7016
7017         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7018         data.
7019         (elf_new_init): Don't call stabsread_new_init.
7020         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7021         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7022         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7023
7024 2019-06-10  Tom de Vries  <tdevries@suse.de>
7025
7026         PR symtab/16264
7027         PR symtab/24517
7028         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7029
7030 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7031
7032         * source.c (find_and_open_source): Also rewrite relative file
7033         names.
7034
7035 2019-04-26  Amos Bird  <amosbird@gmail.com>
7036
7037         * annotate.c (annotate_thread_exited): Add "thread-exited"
7038         annotation.
7039
7040 2019-06-06  Tom Tromey  <tromey@adacore.com>
7041
7042         * maint.h (class scoped_command_stats): Use
7043         DISABLE_COPY_AND_ASSIGN.
7044         <print_time>: New method.
7045         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7046         print_time.
7047         (scoped_command_stats::print_time): New method.
7048
7049 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7050
7051         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7052         instructions of lengths 6 or 8 bytes.
7053
7054 2019-06-04  Pedro Alves  <palves@redhat.com>
7055
7056         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7057
7058         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7059         * breakpoint.c (condition_completer): Likewise.
7060         * cli/cli-dump.c (scan_expression): Likewise.
7061         * common/filestuff.c (mkdir_recursive): Likewise.
7062         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7063         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7064         (gdb_abspath): Likewise.
7065         * compile/compile-cplus-types.c
7066         (compile_cplus_instance::decl_name): Likewise.
7067         * completer.c (complete_explicit_location):
7068         (signal_completer, reg_or_group_completer_1): Likewise.
7069         * cp-support.c (cp_remove_params_if_any): Likewise.
7070         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7071         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7072         * infcmd.c (strip_bg_char): Likewise.
7073         * linespec.c (copy_token_string): Likewise.
7074         * mi/mi-main.c (output_cores): Likewise.
7075         * psymtab.c (psymtab_search_name):
7076         * symfile.c (test_set_ext_lang_command): Likewise.
7077         * target.c (target_fileio_read_stralloc): Likewise.
7078         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7079         * value.c (complete_internalvar): Likewise.
7080
7081 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7082
7083         Add objfile property to gdb.Type.
7084         * NEWS: Mention Python API addition.
7085         * python/py-type.c (typy_get_objfile): New method.
7086
7087 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7088
7089         * NEWS: Mention the new set|show style [title|highlight].
7090         Mention changes to "show style", "help" and "apropos".
7091
7092 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7093
7094         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7095         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7096         instead of print_help_for_command.
7097         (print_doc_of_command): New function.
7098         (help_list): Add 'apropos -v word' suggestion.
7099         (print_help_for_command): Style the command name using title style.
7100         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7101         (_initialize_cli_cmds): Describe -v in apropos_command help.
7102
7103 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7104
7105         * cli/cli-style.h (cli_style_option): Add name in constructor,
7106         add m_name class member, add constructor with intensity,
7107         add name class function.
7108         (cli_style_option::add_setshow_commands): Remove name argument.
7109         (highlight_style, title_style): New styles.
7110         * cli/cli-style.c (do_show): New function that shows a style
7111         characteristic styling the style name with itself.
7112         (set_style_name): New function.
7113         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7114         Update all callers according to the changes in cli/cli-style.h.
7115         * utils.h (fputs_highlighted): New function.
7116         * utils.c (fputs_highlighted): Likewise.
7117
7118 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7119
7120         * NEWS: Mention new pipe command and new convenience variables.
7121
7122 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7123
7124         * cli/cli-cmds.c (pipe_command): New function.
7125         (_initialize_cli_cmds): Call add_com for pipe_command.
7126         Define | as an alias for pipe.
7127         (exit_status_set_internal_vars): New function.
7128         (shell_escape): Call exit_status_set_internal_vars.
7129         cli/cli-decode.c (find_command_name_length): Recognize | as
7130         a single character command.
7131
7132 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7133
7134         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7135         top.c (execute_command_to_ui_file): New function, mostly a copy
7136         of execute_command_to_string.
7137         (execute_command_to_string): Implement by calling
7138         execute_command_to_ui_file.
7139
7140 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7141
7142         * top.h (saved_command_line): Remove declaration.
7143         * top.c (previous_saved_command_line, previous_repeat_arguments):
7144         New variables.
7145         (saved_command_line): Make static, define together with other
7146         'repeat variables'.
7147         (dont_repeat): Clear repeat_arguments.
7148         (repeat_previous, get_saved_command_line, save_command_line):
7149         New functions.
7150         (gdb_init): Initialize saved_command_line
7151         and previous_saved_command_line.
7152         * main.c (captured_main_1): Remove saved_command_line initialization.
7153         * event-top.c (handle_line_of_input): Update to use
7154         the new 'repeat' related functions instead of direct access to
7155         saved_command_line.
7156         * command.h (repeat_previous, get_saved_command_line,
7157         save_command_line): New declarations.
7158         (dont_repeat): Add comment.
7159
7160 2019-05-30  Tom Tromey  <tromey@adacore.com>
7161
7162         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7163         Fix comment.
7164         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7165
7166 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7167
7168         PR cli/24587
7169         * completer.c (complete): Initialize variable word.
7170
7171 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7172
7173         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7174         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7175         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7176         'body' is NULL to the outter 'if', protecting the '!is_define'
7177         situation as well.
7178
7179 2019-05-29  Tom Tromey  <tromey@adacore.com>
7180
7181         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7182         (dwarf_unknown): New function.
7183         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7184         (dwarf_type_encoding_name): Use dwarf_unknown.
7185
7186 2019-05-29  Tom Tromey  <tromey@adacore.com>
7187
7188         PR c++/20020:
7189         * cp-valprint.c (cp_print_value_fields): Call
7190         cp_print_static_field inside "try".
7191
7192 2019-05-29  Tom Tromey  <tromey@adacore.com>
7193
7194         * inflow.c (struct terminal_info): Add default operator=.
7195         * configure: Rebuild.
7196         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7197         -Wdeprecated-copy-dtor, -Wredundant-move.
7198
7199 2019-05-29  Tom Tromey  <tromey@adacore.com>
7200
7201         * NEWS: Add entry.
7202         * infcmd.c (print_return_value_1): Handle finish_print
7203         option.
7204         (show_print_finish): New function.
7205         (_initialize_infcmd): Add "set/show print finish" commands.
7206         * valprint.c (user_print_options): Initialize new member.
7207         * valprint.h (struct value_print_options) <finish_print>: New
7208         member.
7209
7210 2019-05-28  Tom Tromey  <tromey@adacore.com>
7211
7212         * ada-lang.c (ada_remove_Xbn_suffix)
7213         (find_old_style_renaming_symbol)
7214         (parse_old_style_renaming): Remove.
7215         (ada_find_renaming_symbol): Don't call
7216         find_old_style_renaming_symbol.
7217         (ada_is_renaming_symbol): Rename from
7218         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7219         bool.  Now static.
7220         (ada_read_var_value): Update and simplify.
7221         * ada-exp.y (write_var_or_type): Remove old code.
7222
7223 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7224
7225         PR gdb/25010
7226         * event-top.c: Remove include comment.
7227         * inflow.c (class scoped_ignore_sigttou): Move from here...
7228         * inflow.h (class scoped_ignore_sigttou): ...to here.
7229         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7230         * top.c:  Remove include comment.
7231
7232 2019-05-27  Tom Tromey  <tom@tromey.com>
7233
7234         * NEWS: Fix typo.
7235
7236 2019-05-22  Tom Tromey  <tromey@adacore.com>
7237
7238         * target.c (target_follow_exec): Constify parameter.
7239         * target-delegates.c: Rebuild.
7240         * remote.c (remote_target::follow_exec): Constify parameter.
7241         * infrun.c (follow_exec): Constify parameter.
7242         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7243         (target_follow_exec): Likewise.
7244
7245 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7246
7247         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7248         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7249
7250 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7251
7252         * NEWS: Add debugredirect and testsuite sections.
7253
7254 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7255
7256         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7257         target descriptions using exclusively floating point register name
7258         aliases.
7259
7260 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7261
7262         PR gdb/18644:
7263         * f-lang.c (build_fortran_types): Handle the case where
7264         gdbarch_floatformat_for_type returns a nullptr.
7265
7266 2019-05-21  Tom de Vries  <tdevries@suse.de>
7267
7268         PR cli/24587
7269         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7270
7271 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7272
7273         PR gdb/18644:
7274         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7275         16-byte floats.
7276         * i386-tdep.c (i386_floatformat_for_type): Use
7277         floatformats_ia64_quad for the 16-byte floating point component
7278         within a fortran 32-byte complex number.
7279
7280 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7281
7282         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7283         delete default constructor.
7284         (find_partial_die): Update to return const struct.
7285         (partial_die_parent_scope): Move variable declaration into scope
7286         of its use and change its type to auto.
7287         (guess_partial_die_structure_name): Likewise.
7288         (partial_die_info::fixup): Likewise.
7289
7290 2019-05-17  Tom Tromey  <tromey@adacore.com>
7291
7292         * source.c (find_and_open_source): Remove cast.
7293
7294 2019-05-17  Tom Tromey  <tromey@adacore.com>
7295
7296         * annotate.c (annotate_source): Make "filename" const.
7297         * annotate.h (annotate_source): Use const.
7298
7299 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7300
7301         * disasm.c (set_disassembler_options): Send errors to stderr.
7302
7303 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7304
7305         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7306         (cli_interp_base::set_logging): Check debug_redirect.
7307         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7308         * cli/cli-logging.c (debug_redirect): Add static variable.
7309         (pop_output_files): Add default param.
7310         (handle_redirections): Print debug setting.
7311         (show_logging_command): Likewise.
7312         (_initialize_cli_logging): Add debugredirect command.
7313         * interps.c (current_interp_set_logging): Add debug_redirect
7314         parameter.
7315         * interps.h (set_logging): Add debug_redirect parameter.
7316         (current_interp_set_logging): Likewise.
7317         * mi/mi-common.h: Likewise.
7318         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7319
7320 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7321             Tom Tromey  <tromey@adacore.com>
7322
7323         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7324         directly.
7325         * cli/cli-interp.h (make_logging_output): Remove declaration.
7326         * cli/cli-logging.c (make_logging_output): Remove function.
7327         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7328         directly.
7329         * ui-file.c (tee_file::tee_file): Remove bools.
7330         (tee_file::~tee_file): Remove deletes.
7331         * ui-file.h (tee_file): Remove bools.
7332
7333 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7334
7335         * mi/mi-cmds.h (mi_cmd_complete): New function.
7336         * mi/mi-main.c (mi_cmd_complete): Likewise.
7337         * mi/mi-cmds.c: Define new MI command -complete.
7338         * NEWS: Mention new -complete command.
7339
7340 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7341
7342         * completer.h (complete): New function.
7343         * completer.c (complete): Likewise.
7344         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7345         function defined in completer.h.
7346
7347 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7348
7349         * MAINTAINERS (Write After Approval): Add myself.
7350
7351 2019-05-17  Tom de Vries  <tdevries@suse.de>
7352
7353         PR gdb/24094
7354         * dwarf2read.c (struct cu_partial_die_info): New struct.
7355         (find_partial_die): Return cu_partial_die_info.
7356         (partial_die_parent_scope, guess_partial_die_structure_name)
7357         (partial_die_info::fixup): Handle new return type of find_partial_die.
7358
7359 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7360
7361         PR breakpoints/24541
7362         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7363         "std::string", simplifying the algorithm.
7364
7365 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7366
7367         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7368         (stap_static_probe_ops::get_probes): Likewise.
7369
7370 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7371
7372         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7373         '-')" and "else if".
7374         (stap_parse_single_operand): Join checks for
7375         "gdbarch_stap_parse_special_token_p" and
7376         "gdbarch_stap_parse_special_token" in the same "if" statement.
7377         Invert check when verifying for operation on register
7378         displacement.
7379
7380 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7381
7382         * stap-probe.c (stap_get_opcode): Update comment.
7383         (stap_get_expected_argument_type): Likewise.
7384         (handle_stap_probe): Likewise.
7385
7386 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7387
7388         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7389         return type to 'bool'.  Adjust comment.  Use 'bool' when
7390         appropriate.
7391         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7392         * stap-probe.c (stap_parse_argument_1): Likewise.
7393         (stap_is_operator): Likewise.
7394         (stap_is_generic_prefix): Likewise.
7395         (stap_is_register_prefix): Likewise.
7396         (stap_is_register_indirection_prefix): Likewise.
7397         (stap_is_integer_prefix): Likewise.
7398         (stap_generic_check_suffix): Likewise.
7399         (stap_check_integer_suffix): Likewise.
7400         (stap_check_register_suffix): Likewise.
7401         (stap_check_register_indirection_suffix): Likewise.
7402         (stap_parse_register_operand): Likewise.
7403         (stap_parse_single_operand): Likewise.
7404         (stap_parse_argument_1): Likewise.
7405         (stap_probe::get_argument_count): Likewise.
7406         (stap_is_operator): Likewise.
7407
7408 2019-05-16  Tom Tromey  <tromey@adacore.com>
7409
7410         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7411         keyword to foreach.
7412
7413 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7414
7415         * linux-thread-db.c (try_thread_db_load_1): Change return type
7416         to bool.
7417         (try_thread_db_load): Likewise.
7418         (try_thread_db_load_from_pdir_1): Likewise.
7419         (try_thread_db_load_from_pdir): Likewise.
7420         (try_thread_db_load_from_sdir): Likewise.
7421         (try_thread_db_load_from_dir): Likewise.
7422         (thread_db_load_search): Likewise.
7423         (has_libpthread): Likewise.
7424         (thread_db_load): Likewise.
7425
7426 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7427
7428         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7429         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7430         NULL, and complain/return if that's the case.
7431
7432 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7433
7434         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7435         (advance, posn, abstract_read_memory): New functions.
7436         [struct mem_read_abstraction]: New struct.
7437         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7438
7439 2019-05-14  Tom Tromey  <tromey@adacore.com>
7440
7441         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7442         value is not lval_memory.
7443
7444 2019-05-14  Tom Tromey  <tromey@adacore.com>
7445
7446         * solib.c (info_sharedlibrary_command): Style the file name.
7447
7448 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7449
7450         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7451         (aarch64_vnv_type): Likewise.
7452         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7453         * common/tdesc.c: Likewise.
7454         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7455         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7456         * features/aarch64-fpu.xml: Add ieee half view.
7457         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7458         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7459         * gdbtypes.h (struct builtin_type): Likewise.
7460         (struct objfile_type): Likewise.
7461
7462 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7463
7464         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7465         typo.
7466         * location.h (string_to_event_location): Likewise.
7467
7468 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7469
7470         GDB 8.3 released.
7471
7472 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7473
7474         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7475         New variable declaration.
7476         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7477         New variable.
7478         (print_one_breakpoint): Use ui_out::test_flags and new global
7479         variable to compute use_fixed_output.
7480         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7481         Remove.
7482         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7483         (mi_multi_location_breakpoint_output_fixed): Remove.
7484         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7485         new variable.
7486         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7487         fix_multi_location_breakpoint_output flag if version >= 3.
7488         * ui-out.h (enum ui_out_flag)
7489         <fix_multi_location_breakpoint_output>: New enumerator.
7490
7491 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7492
7493         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7494
7495 2019-05-10  Tom Tromey  <tromey@adacore.com>
7496
7497         * ada-lang.c (catch_ada_completer): New function.
7498         (_initialize_ada_language): Use it.
7499
7500 2019-05-10  Tom Tromey  <tromey@adacore.com>
7501
7502         * thread.c (print_thread_info): Make "requested_threads" const.
7503         * gdbthread.h (print_thread_info): Make "requested_threads"
7504         const.
7505         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7506         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7507
7508 2019-05-08  Tom Tromey  <tom@tromey.com>
7509
7510         * gdbtypes.c (objfile_type_data): Change type.
7511         (objfile_type, _initialize_gdbtypes): Update.
7512
7513 2019-05-08  Tom Tromey  <tom@tromey.com>
7514
7515         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7516         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7517         (_initialize_dwarf2_frame): Update.
7518
7519 2019-05-08  Tom Tromey  <tom@tromey.com>
7520
7521         * objc-lang.c (objc_objfile_data): Change type.
7522         (find_methods): Update.
7523         (_initialize_objc_lang): Remove.
7524
7525 2019-05-08  Tom Tromey  <tom@tromey.com>
7526
7527         * stabsread.c (rs6000_builtin_type_data): Change type.
7528         (rs6000_builtin_type, _initialize_stabsread): Update.
7529
7530 2019-05-08  Tom Tromey  <tom@tromey.com>
7531
7532         * mips-tdep.c (mips_pdr_data): Remove.
7533         (_initialize_mips_tdep): Update.
7534
7535 2019-05-08  Tom Tromey  <tom@tromey.com>
7536
7537         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7538         (hppa_init_objfile_priv_data, read_unwind_info)
7539         (find_unwind_entry, _initialize_hppa_tdep): Update.
7540
7541 2019-05-08  Tom Tromey  <tom@tromey.com>
7542
7543         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7544         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7545         on obstack.
7546         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7547
7548 2019-05-08  Tom Tromey  <tom@tromey.com>
7549
7550         * mdebugread.c (basic_type_data): Change type.
7551         (basic_type, _initialize_mdebugread): Update.
7552
7553 2019-05-08  Tom Tromey  <tom@tromey.com>
7554
7555         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7556
7557 2019-05-08  Tom Tromey  <tom@tromey.com>
7558
7559         * nto-tdep.c (nto_inferior_data_reg): Change type.
7560         (nto_inferior_data): Update.
7561         (nto_inferior_data_cleanup, nto_new_inferior_data)
7562         (_initialize_nto_tdep): Remove.
7563         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7564
7565 2019-05-08  Tom Tromey  <tom@tromey.com>
7566
7567         * ada-lang.c (struct ada_inferior_data): Add initializers.
7568         (ada_inferior_data): Change type.
7569         (ada_inferior_data_cleanup): Remove.
7570         (get_ada_inferior_data, ada_inferior_exit)
7571         (struct ada_pspace_data): Add initializers, destructor.
7572         (ada_pspace_data_handle): Change type.
7573         (get_ada_pspace_data): Update.
7574         (ada_pspace_data_cleanup): Remove.
7575
7576 2019-05-08  Tom Tromey  <tom@tromey.com>
7577
7578         * coffread.c (struct coff_symfile_info): Add initializers.
7579         (coff_objfile_data_key): Move lower.  Change type.
7580         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7581         Update.
7582         (coff_free_info): Remove.
7583
7584 2019-05-08  Tom Tromey  <tom@tromey.com>
7585
7586         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7587         (fbsd_pspace_data_handle): Move lower.  Change type.
7588         (get_fbsd_pspace_data): Update.
7589         (fbsd_pspace_data_cleanup): Remove.
7590         (_initialize_fbsd_tdep): Update.
7591
7592 2019-05-08  Tom Tromey  <tom@tromey.com>
7593
7594         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7595         (get_ada_tasks_pspace_data): Update.
7596         (ada_tasks_pspace_data_cleanup): Remove.
7597         (_initialize_tasks): Update.
7598         (ada_tasks_inferior_data_handle): Change type.
7599         (get_ada_tasks_inferior_data): Update.
7600         (ada_tasks_inferior_data_cleanup): Remove.
7601         (struct ada_tasks_pspace_data): Add initializers.
7602
7603 2019-05-08  Tom Tromey  <tom@tromey.com>
7604
7605         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7606         * symfile-debug.c (debug_sym_get_probes): Change type.
7607         * stap-probe.c (handle_stap_probe):
7608         (stap_static_probe_ops::get_probes): Change type.
7609         * probe.h (class static_probe_ops) <get_probes>: Change type.
7610         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7611         (parse_probes_in_pspace): Update.
7612         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7613         Update.
7614         (any_static_probe_ops::get_probes): Change type.
7615         * elfread.c (elfread_data): New typedef.
7616         (probe_key): Change type.
7617         (elf_get_probes): Likewise.  Update.
7618         (probe_key_free): Remove.
7619         (_initialize_elfread): Update.
7620         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7621         Change type.
7622         (dtrace_process_dof_probe, dtrace_process_dof)
7623         (dtrace_static_probe_ops::get_probe): Change type.
7624
7625 2019-05-08  Tom Tromey  <tom@tromey.com>
7626
7627         * xcoffread.c (struct xcoff_symfile_info): Rename from
7628         coff_symfile_info.  Add initializers.
7629         (xcoff_objfile_data_key): Move lower.  Change type.
7630         (XCOFF_DATA): Rewrite.
7631         (xcoff_free_info): Remove.
7632         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7633         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7634         (xcoff_initial_scan): Update.
7635
7636 2019-05-08  Tom Tromey  <tom@tromey.com>
7637
7638         * solib-svr4.c (struct svr4_info): Add initializers and
7639         destructor.
7640         <probes_table>: Now an htab_up.
7641         (solib_svr4_pspace_data): Change type.
7642         (free_probes_table): Simplify.
7643         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7644         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7645         (probes_table_remove_objfile_probes, register_solib_event_probe)
7646         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7647         (_initialize_svr4_solib): Update.
7648
7649 2019-05-08  Tom Tromey  <tom@tromey.com>
7650
7651         * remote.c (remote_pspace_data): Change type.
7652         (remote_pspace_data_cleanup): Remove.
7653         (get_remote_exec_file, set_pspace_remote_exec_file)
7654         (_initialize_remote): Update.
7655
7656 2019-05-08  Tom Tromey  <tom@tromey.com>
7657
7658         * breakpoint.c (breakpoint_objfile_key): Change type.
7659         (get_breakpoint_objfile_data): Update.
7660         (free_breakpoint_objfile_data): Remove.
7661         (_initialize_breakpoint): Update.
7662
7663 2019-05-08  Tom Tromey  <tom@tromey.com>
7664
7665         * linux-tdep.c (struct linux_info): Add initializers.
7666         (linux_inferior_data): Move.  Change type.
7667         (invalidate_linux_cache_inf): Update.
7668         (linux_inferior_data_cleanup): Remove.
7669         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7670
7671 2019-05-08  Tom Tromey  <tom@tromey.com>
7672
7673         * auxv.c (auxv_inferior_data): Move.  Change type.
7674         (auxv_inferior_data_cleanup): Remove.
7675         (invalidate_auxv_cache_inf): Rewrite.
7676         (get_auxv_inferior_data, _initialize_auxv): Update.
7677
7678 2019-05-08  Tom Tromey  <tom@tromey.com>
7679
7680         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7681         (symfile_debug_objfile_data_key): Change type.
7682         (symfile_debug_installed, debug_qf_has_symbols)
7683         (debug_qf_find_last_source_symtab)
7684         (debug_qf_forget_cached_source_info)
7685         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7686         (debug_qf_print_stats, debug_qf_dump)
7687         (debug_qf_expand_symtabs_for_function)
7688         (debug_qf_expand_all_symtabs)
7689         (debug_qf_expand_symtabs_with_fullname)
7690         (debug_qf_map_matching_symbols)
7691         (debug_qf_expand_symtabs_matching)
7692         (debug_qf_find_pc_sect_compunit_symtab)
7693         (debug_qf_map_symbol_filenames)
7694         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7695         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7696         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7697         (debug_sym_read_linetable, debug_sym_relocate): Update.
7698         (symfile_debug_free_objfile): Remove.
7699         (install_symfile_debug_logging, _initialize_symfile_debug):
7700         Update.
7701
7702 2019-05-08  Tom Tromey  <tom@tromey.com>
7703
7704         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7705         allocate_on_obstack.
7706         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7707         (get_dwarf2_per_objfile): Update.
7708         (set_dwarf2_per_objfile): Remove.
7709         (dwarf2_has_info, dwarf2_get_section_info): Update.
7710         (dwarf2_free_objfile): Remove.
7711         (_initialize_dwarf2_read): Update.
7712
7713 2019-05-08  Tom Tromey  <tom@tromey.com>
7714
7715         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7716         initializers.
7717         <unsupported_script_warning_printed,
7718         script_not_found_warning_printed>: Now bool.
7719         (auto_load_pspace_data): Change type.
7720         (~auto_load_pspace_info): Rename from
7721         auto_load_pspace_data_cleanup.
7722         (get_auto_load_pspace_data, init_loaded_scripts_info)
7723         (clear_section_scripts, maybe_print_unsupported_script_warning)
7724         (maybe_print_script_not_found_warning, _initialize_auto_load):
7725         Update.
7726
7727 2019-05-08  Tom Tromey  <tom@tromey.com>
7728
7729         * objfiles.c (objfile_pspace_info): Add destructor and
7730         initializers.
7731         (objfiles_pspace_data): Change type.
7732         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7733         (get_objfile_pspace_data): Update.
7734         (objfiles_bfd_data): Change type.
7735         (get_objfile_bfd_data): Update.
7736         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7737
7738 2019-05-08  Tom Tromey  <tom@tromey.com>
7739
7740         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7741         Change type.
7742         (get_catch_syscall_inferior_data): Update.
7743         (catch_syscall_inferior_data_cleanup): Remove.
7744         (_initialize_break_catch_syscall): Update.
7745
7746 2019-05-08  Tom Tromey  <tom@tromey.com>
7747
7748         * inflow.c (struct terminal_info): Add destructor and
7749         initializers.
7750         (inflow_inferior_data): Change type.
7751         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7752         (get_inflow_inferior_data, inflow_inferior_exit)
7753         (swap_terminal_info, _initialize_inflow): Update.
7754
7755 2019-05-08  Tom Tromey  <tom@tromey.com>
7756
7757         * target-dcache.c (target_dcache_cleanup): Remove.
7758         (target_dcache_aspace_key): Change type.
7759         (target_dcache_init_p, target_dcache_invalidate)
7760         (target_dcache_get, target_dcache_get_or_init)
7761         (_initialize_target_dcache): Update.
7762         * dcache.h (struct dcache_deleter): New.
7763
7764 2019-05-08  Tom Tromey  <tom@tromey.com>
7765
7766         * symtab.c (struct symbol_cache): Add destructor and
7767         initializers.
7768         (symbol_cache_key): Move.  Change type.
7769         (make_symbol_cache, free_symbol_cache): Remove.
7770         (get_symbol_cache): Update.
7771         (symbol_cache_cleanup): Remove.
7772         (ALL_PSPACES, symbol_cache_flush)
7773         (maintenance_print_symbol_cache)
7774         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7775         Update.
7776
7777 2019-05-08  Tom Tromey  <tom@tromey.com>
7778
7779         * symtab.c (struct main_info): Add destructor and initializers.
7780         (main_progspace_key): Move.  Change type.
7781         (get_main_info): Update.
7782         (main_info_cleanup): Remove.
7783         (_initialize_symtab): Update.
7784
7785 2019-05-08  Tom Tromey  <tom@tromey.com>
7786
7787         * registry.h (DECLARE_REGISTRY): Define the _key class.
7788
7789 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * NEWS: Merge two 'New commands' sections.
7792
7793 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7794
7795         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7796         parameter and use Ada language definition instead.
7797         (ada_val_print_ptr): Remove unused language parameter.
7798         (ada_val_print_num): Remove language parameter and use Ada language
7799         definition instead.
7800         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7801         parameter.
7802         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7803         parameter and use Ada language definition instead.
7804         (ada_val_print_1): Update all ada_val_print_xxx calls.
7805         Remove language parameter.
7806         (ada_val_print): Update ada_val_print_1 call.
7807
7808 2019-05-08  Tom Tromey  <tromey@adacore.com>
7809
7810         * remote.c (remote_hw_watchpoint_limit)
7811         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7812         Now static.
7813
7814 2019-05-08  Tom Tromey  <tromey@adacore.com>
7815
7816         * maint.c (_initialize_maint_cmds): Move initialization code to
7817         remote.c.
7818         (watchdog, show_watchdog): Move to remote.c.
7819         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7820         "watchdog" static.
7821         (_initialize_remote): Move initialization code from maint.c.
7822         * defs.h (watchdog): Don't declare.
7823
7824 2019-05-08  Tom Tromey  <tromey@adacore.com>
7825
7826         * tui/tui-interp.c: Include main.h.
7827         * interps.c: Include main.h.
7828         * main.h (interpreter_p): Declare.
7829         * defs.h (interpreter_p): Don't declare.
7830
7831 2019-05-08  Tom Tromey  <tromey@adacore.com>
7832
7833         * dwarf2loc.c: Include dwarf2read.h.
7834         * defs.h (read_unsigned_leb128): Don't declare.
7835         * dwarf2read.h (read_unsigned_leb128): Declare.
7836
7837 2019-05-08  Tom Tromey  <tromey@adacore.com>
7838
7839         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7840         method.
7841
7842 2019-05-08  Tom Tromey  <tromey@adacore.com>
7843
7844         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7845         when no wrap column is set.
7846
7847 2019-05-08  Tom Tromey  <tromey@adacore.com>
7848
7849         * c-lang.c (c_get_string): Handle non-C-style arrays.
7850
7851 2019-05-08  Tom Tromey  <tromey@adacore.com>
7852
7853         * typeprint.c (print_offset_data::update): Print the bit offset,
7854         not the number of bits remaining.
7855
7856 2019-05-08  Tom Tromey  <tromey@adacore.com>
7857
7858         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7859         padding at end of comment.
7860
7861 2019-05-08  Tom Tromey  <tromey@adacore.com>
7862
7863         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7864         Compare main types.
7865
7866 2019-05-06  Tom Tromey  <tom@tromey.com>
7867
7868         * common/scoped_mmap.c: Include common-defs.h.
7869         * common/scoped_mmap.h: Don't include config.h.
7870
7871 2019-05-04  Tom Tromey  <tom@tromey.com>
7872
7873         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7874         (struct aarch64_call_info): Add initializers.
7875         <si>: Now a std::vector.
7876         (pass_on_stack, aarch64_push_dummy_call): Update.
7877
7878 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7879             Tom Tromey  <tom@tromey.com>
7880
7881         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7882         (ppc_threads): Now a std::vector.  Now static.
7883         (hwdebug_find_thread_points_by_tid)
7884         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7885         Update.
7886
7887 2019-05-04  Tom Tromey  <tom@tromey.com>
7888
7889         * arc-tdep.c (arc_tdesc_init): Return bool.
7890
7891 2019-05-04  Tom Tromey  <tom@tromey.com>
7892
7893         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7894         Use gdb_assert_not_reached.
7895
7896 2019-05-04  Tom Tromey  <tom@tromey.com>
7897
7898         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7899         "false".
7900
7901 2019-05-04  Tom Tromey  <tom@tromey.com>
7902
7903         * arc-tdep.c (arc_tdesc_init): Use bool.
7904
7905 2019-05-04  Tom Tromey  <tom@tromey.com>
7906
7907         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7908
7909 2019-05-04  Tom Tromey  <tom@tromey.com>
7910
7911         * cli/cli-cmds.c (valid_command_p): Return bool.
7912
7913 2019-05-04  Tom Tromey  <tom@tromey.com>
7914
7915         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7916         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7917
7918 2019-05-04  Raul Tambre  <raul@tambre.ee>
7919
7920         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7921         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7922         operator for comparison.
7923
7924 2019-05-04  Tom Tromey  <tom@tromey.com>
7925
7926         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7927         (lookup_partial_symbol, print_partial_symbols)
7928         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7929         (psymbol_compare): Update.
7930         (add_psymbol_to_bcache): Clear the entire psymbol.
7931         (maintenance_check_psymtabs): Update.
7932         * psympriv.h (struct partial_symbol): Don't derive from
7933         general_symbol_info.
7934         <obj_section, unrelocated_address, address,
7935         set_unrelocated_address>: Update.
7936         <ginfo>: New member.
7937         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7938         (debug_names::write_psymbols): Update.
7939
7940 2019-05-04  Tom de Vries  <tdevries@suse.de>
7941
7942         * contrib/cc-with-tweaks.sh: Support -n arg.
7943
7944 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7945
7946         * corelow.c (core_target::detach): Ensure frame cache and
7947         register caches are cleared.
7948         inferior.c (exit_inferior_1): Likewise.
7949
7950 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7951             Tom Tromey  <tom@tromey.com>
7952
7953         * dictionary.c (collate_pending_symbols_by_language): Remove
7954         "struct" from foreach.
7955         * symtab.c (lookup_global_symbol_from_objfile)
7956         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7957         foreach.
7958         * ser-tcp.c (net_open): Remove "struct" from foreach.
7959         * objfiles.c (objfile_relocate, objfile_rebase)
7960         (objfile_has_symbols): Remove "struct" from foreach.
7961         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7962         from foreach.
7963         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7964         foreach.
7965         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7966         "struct" from foreach.
7967         * ada-lang.c (create_excep_cond_exprs)
7968         (ada_exception_catchpoint_cond_string): Remove "struct" from
7969         foreach.
7970
7971 2019-05-03  Tom Tromey  <tromey@adacore.com>
7972
7973         * ada-exp.y (convert_char_literal): Check suffix of each
7974         enumerator.
7975
7976 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7977
7978         PR ada/21406:
7979         * ada-exp.y (yywrap): Don't define.
7980         * ada-lex.l (%option): Add noyywrap
7981         (yywrap): Remove.
7982
7983 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7984
7985         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7986         _WIN32_WINNT to the XP level, unless already defined to a higher
7987         level.
7988
7989         * unittests/parse-connection-spec-selftests.c:
7990         * ser-tcp.c:
7991         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7992         override.
7993
7994         * symfile.c (find_separate_debug_file): Remove colon from the
7995         drive spec of DOS/Windows file names of the target, so that the
7996         file name produced from DEBUGDIR and the target's directory will
7997         be valid on DOS/Windows systems.
7998
7999 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8000
8001         * rust-lang.c (val_print_struct): Handle printing structures
8002         containing strings.
8003
8004 2019-05-02  Tom Tromey  <tromey@adacore.com>
8005
8006         * valarith.c (_initialize_valarith): Remove.
8007
8008 2019-05-01  Tom Tromey  <tromey@adacore.com>
8009
8010         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8011         bitfields.
8012
8013 2019-05-01  Tom Tromey  <tromey@adacore.com>
8014
8015         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8016         for big-endian copies.
8017
8018 2019-04-30  Ali Tamur  <tamur@google.com>
8019         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8020         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8021         (read_3_bytes): New function.
8022
8023 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8024
8025         * windows-nat.c (main_thread_id): Delete.
8026         (handle_output_debug_string): Replace main_thread_id by
8027         current_event.dwThreadId.
8028         (fake_create_process): Likewise.
8029         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8030         Do not set main_thread_id.
8031         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8032         current_event.dwThreadId.
8033         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8034
8035 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8036
8037         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8038         Use current_event.dwThreadId instead of main_thread_id.
8039
8040 2019-04-30  Tom Tromey  <tromey@adacore.com>
8041
8042         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8043         (create_excep_cond_exprs): Iterate over program spaces.
8044         (ada_exception_catchpoint_cond_string): Examine all minimal
8045         symbols for exception types.
8046
8047 2019-04-30  Tom Tromey  <tromey@adacore.com>
8048
8049         PR c++/24470:
8050         * dwarf2read.c (process_structure_scope): Handle case where type
8051         has template parameters but no symbol was created.
8052
8053 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8054             Chris January  <chris.january@arm.com>
8055
8056         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8057         qualifier.
8058         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8059
8060 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8061
8062         * f-typeprint.c (f_print_type): Update rules for printing
8063         whitespace.
8064         (f_type_print_varspec_suffix): Likewise.
8065
8066 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8067             Chris January  <chris.january@arm.com>
8068
8069         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8070         function arguments.
8071
8072 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8073
8074         * f-lang.c (build_fortran_types): Change name of void type to
8075         lower case.
8076         * f-typeprint.c (f_type_print_base): Print the name of the void
8077         type, rather than a fixed string.
8078         * f-valprint.c (f_decorations): Use lower case void string.
8079
8080 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8081             Chris January  <chris.january@arm.com>
8082
8083         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8084         types for Fortran.
8085
8086 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8087             Chris January  <chris.january@arm.com>
8088             David Lecomber  <david.lecomber@arm.com>
8089
8090         * f-exp.y (BINOP_INTRINSIC): New token.
8091         (exp): New parser rule handling BINOP_INTRINSIC.
8092         (f77_keywords): Add new builtin procedures.
8093         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8094         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8095         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8096         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8097         (print_unop_subexp_f): New function.
8098         (print_binop_subexp_f): New function.
8099         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8100         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8101         (dump_subexp_body_f): Likewise.
8102         (operator_check_f): Likewise.
8103         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8104         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8105
8106 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8107
8108         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8109         UNOP_KIND.
8110         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8111         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8112         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8113         (operator_length_f): New fuction.
8114         (print_subexp_f): New function.
8115         (op_name_f): New function.
8116         (dump_subexp_body_f): New function.
8117         (operator_check_f): New function.
8118         (exp_descriptor_f): Replace standard expression handling functions
8119         with new functions.
8120         * gdb/fortran-operator.def: New file.
8121         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8122         * gdb/std-operator.def: Remove UNOP_KIND.
8123
8124 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8125
8126         * std-operator.def: Remove unbalanced, stray double quote
8127         character.
8128
8129 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8130             Chris January  <chris.january@arm.com>
8131             Daniel Everett  <daniel.everett@arm.com>
8132             Nick Forrington  <nick.forrington@arm.com>
8133             Richard Bunt  <richard.bunt@arm.com>
8134
8135         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8136         of depth when printing anonymous structs or unions.
8137         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8138         Don't print either the top-level value, or the children if the
8139         max-depth is exceeded.
8140         (ppscm_print_children): When printing the key of a map, allow one
8141         extra level of depth.
8142         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8143         print either the top-level value, or the children if the max-depth
8144         is exceeded.
8145         (print_children): When printing the key of a map, allow one extra
8146         level of depth.
8147         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8148         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8149         (user_print_options): Initialise max_depth field.
8150         (val_print_scalar_or_string_type_p): New function.
8151         (val_print): Check to see if the max depth has been reached.
8152         (val_print_check_max_depth): Define new function.
8153         (show_print_max_depth): New function.
8154         (_initialize_valprint): Add 'print max-depth' option.
8155         * valprint.h (struct value_print_options) <max_depth>: New field.
8156         (val_print_check_max_depth): Declare new function.
8157         * NEWS: Document new feature.
8158
8159 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8160
8161         * ada-lang.c (ada_language_defn): Initialise new field.
8162         * c-lang.c (c_is_string_type_p): New function.
8163         (c_language_defn): Initialise new field.
8164         (cplus_language_defn): Initialise new field.
8165         (asm_language_defn): Initialise new field.
8166         (minimal_language_defn): Initialise new field.
8167         * c-lang.h (c_is_string_type_p): Declare new function.
8168         * d-lang.c (d_language_defn): Initialise new field.
8169         * f-lang.c (f_is_string_type_p): New function.
8170         (f_language_defn): Initialise new field.
8171         * go-lang.c (go_is_string_type_p): New function.
8172         (go_language_defn): Initialise new field.
8173         * language.c (default_is_string_type_p): New function.
8174         (unknown_language_defn): Initialise new field.
8175         (auto_language_defn): Initialise new field.
8176         * language.h (struct language_defn) <la_is_string_type_p>: New
8177         member variable.
8178         (default_is_string_type_p): Declare new function.
8179         * m2-lang.c (m2_language_defn): Initialise new field.
8180         * objc-lang.c (objc_language_defn): Initialise new field.
8181         * opencl-lang.c (opencl_language_defn): Initialise new field.
8182         * p-lang.c (pascal_is_string_type_p): New function.
8183         (pascal_language_defn): Initialise new field.
8184         * rust-lang.c (rust_is_string_type_p): New function.
8185         (rust_language_defn): Initialise new field.
8186
8187 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8190         New field.
8191         * ada-lang.c (ada_language_defn): Initialise new field.
8192         * c-lang.c (c_language_defn): Likewise.
8193         (cplus_language_defn): Likewise.
8194         (asm_language_defn): Likewise.
8195         (minimal_language_defn): Likewise.
8196         * d-lang.c (d_language_defn): Likewise.
8197         * f-lang.c (f_language_defn): Likewise.
8198         * go-lang.c (go_language_defn): Likewise.
8199         * language.c (unknown_language_defn): Likewise.
8200         (auto_language_defn): Likewise.
8201         * m2-lang.c (m2_language_defn): Likewise.
8202         * objc-lang.c (objc_language_defn): Likewise.
8203         * opencl-lang.c (opencl_language_defn): Likewise.
8204         * p-lang.c (pascal_language_defn): Likewise.
8205         * rust-lang.c (rust_language_defn): Likewise.
8206
8207 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8208
8209         * ada-lang.c (ada_is_character_type): Change return type to bool.
8210         (ada_is_string_type): Likewise.
8211         * ada-lang.h (ada_is_character_type): Update declaration
8212         (ada_is_string_type): Likewise.
8213
8214 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8215
8216         Support style in 'frame|thread apply'
8217
8218         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8219         * record.c (record_start, record_stop): Update callers of
8220         execute_command_to_string with false.
8221         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8222         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8223         methods.
8224         (class string_file): New constructor with term_out parameter.
8225         Override methods term_out and can_emit_style_escape.  New member
8226         term_out.
8227         (class stdio_file): Override can_emit_style_escape.
8228         (class tee_file): Override term_out and can_emit_style_escape.
8229         * utils.h (can_emit_style_escape): Remove.
8230         * utils.c (can_emit_style_escape): Likewise.
8231         Update all callers of can_emit_style_escape (SOMESTREAM) to
8232         SOMESTREAM->can_emit_style_escape.
8233         * source-cache.c (source_cache::get_source_lines): Likewise.
8234         * stack.c (frame_apply_command_count): Call execute_command_to_string
8235         passing the term_out characteristic of the current gdb_stdout.
8236         * thread.c (thr_try_catch_cmd): Likewise.
8237         * top.c (execute_command_to_string): pass term_out parameter
8238         to construct the string_file for the command output.
8239         * ui-file.c (term_cli_styling): New function (most code moved
8240         from utils.c can_emit_style_escape).
8241         (string_file::string_file, string_file::can_emit_style_escape,
8242         stdio_file::can_emit_style_escape, tee_file::term_out,
8243         tee_file::can_emit_style_escape): New functions.
8244
8245 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8246
8247         * NEWS: Mention the new set|show may-call-functions.
8248         * infcall.c (may_call_functions_p): New variable.
8249         (show_may_call_functions_p): New function.
8250         (call_function_by_hand_dummy): Throws an error if not
8251         may-call-functions.
8252         (_initialize_infcall): Call add_setshow_boolean_cmd for
8253         may-call-functions.
8254
8255 2019-04-25  Keith Seitz  <keiths@redhat.com>
8256
8257         PR c++/24367
8258         * cp-support.c (inspect_type): Don't attempt substitutions
8259         of symbol with the same name.
8260
8261 2019-04-25  Tom Tromey  <tromey@adacore.com>
8262
8263         PR gdb/24475:
8264         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8265         static.
8266
8267 2019-04-25  Tom Tromey  <tromey@adacore.com>
8268
8269         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8270         rvalue reference.
8271         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8272         (gdb_xml_parser::parse): Use std::move.
8273         * python/python-internal.h (gdbpy_convert_exception): Take a const
8274         reference.
8275         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8276         std::move.
8277         * python/py-utils.c (gdbpy_convert_exception): Take a const
8278         reference.
8279         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8280         Use std::move.
8281         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8282         Use std::move.
8283         * mi/mi-main.c (mi_print_exception): Take a const reference.
8284         * main.c (handle_command_errors): Take a const reference.
8285         * linespec.c (parse_linespec): Use std::move.
8286         * infcall.c (run_inferior_call): Use std::move.
8287         (call_function_by_hand_dummy): Use std::move.
8288         * exec.c (try_open_exec_file): Use std::move.
8289         * exceptions.h (exception_print, exception_fprintf)
8290         (exception_print_same): Update.
8291         * exceptions.c (print_exception, exception_print)
8292         (exception_fprintf, exception_print_same): Change parameters to
8293         const reference.
8294         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8295         * common/new-op.c: Use std::move.
8296         * common/common-exceptions.h (struct gdb_exception): Add move
8297         constructor.
8298         (struct gdb_exception_error, struct gdb_exception_quit, struct
8299         gdb_quit_bad_alloc): Change constructor to move constructor.
8300         (throw_exception): Change parameter to rvalue reference.
8301         * common/common-exceptions.c (throw_exception): Take rvalue
8302         reference.
8303         * cli/cli-interp.c (safe_execute_command): Use std::move.
8304         * breakpoint.c (insert_bp_location, location_to_sals): Use
8305         std::move.
8306
8307 2019-04-25  Tom Tromey  <tromey@adacore.com>
8308
8309         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8310         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8311         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8312         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8313         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8314         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8315         guile/scm-value.c: Use unpack.
8316         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8317         gdbscm_gdb_exception.
8318         (gdbscm_throw_gdb_exception): Likewise.
8319         (struct gdbscm_gdb_exception): New.
8320         (unpack): New function.
8321         (gdbscm_wrap): Use unpack.
8322
8323 2019-04-25  Tom Tromey  <tromey@adacore.com>
8324
8325         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8326         (gdb_rl_callback_handler): Use std::move.
8327         * common/common-exceptions.h (struct gdb_exception): Add move
8328         assignment operator.
8329         (throw_exception_sjlj): Change "exception" to const reference.
8330         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8331         (throw_exception_sjlj): Change "exception" to const reference.
8332
8333 2019-04-25  Tom Tromey  <tromey@adacore.com>
8334
8335         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8336         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8337         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8338         Update.
8339         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8340         Update.
8341         * mi/mi-interp.c (mi_interp::exec): Update.
8342         * linespec.c (parse_linespec): Update.
8343         * infcall.c (run_inferior_call): Update.
8344         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8345         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8346         (gdbscm_lookup_global_symbol): Update.
8347         * guile/scm-param.c (gdbscm_parameter_value): Update.
8348         * guile/scm-frame.c (gdbscm_frame_read_register)
8349         (gdbscm_frame_read_var): Update.
8350         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8351         * exec.c (try_open_exec_file): Update.
8352         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8353         (gdb_rl_callback_handler): Update.
8354         * common/common-exceptions.h (exception_none): Don't declare.
8355         * common/common-exceptions.c (exception_none): Don't define.
8356         (struct catcher) <exception>: Update.
8357         * cli/cli-interp.c (safe_execute_command): Update.
8358         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8359
8360 2019-04-25  Ali Tamur  <tamur@google.com>
8361
8362         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8363         (read_attribute_value): Likewise.
8364         (dwarf2_read_addr_index): Update comment.
8365         (read_str_index): Add DW_FORM_strx.
8366         (dwarf2_string_attr): Likewise.
8367         (dwarf2_const_value_attr): Likewise.
8368         (dump_die_shallow): Likewise.
8369         (dwarf2_fetch_constant_bytes): Likewise.
8370         (skip_form_bytes): Likewise.
8371         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8372
8373 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8374
8375         PR corefiles/11608
8376         PR corefiles/18187
8377         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8378         OFFSET.  Verify if current mapping contains an ELF header.
8379         (linux_find_memory_regions_full): Adjust call to
8380         dump_mapping_p.
8381
8382 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8383             Kang Li <kanglictf@gmail.com>
8384
8385         PR gdb/21600
8386
8387         * dwarf2-frame.c (read_initial_length): Be consistent about using
8388         unsigned representation of length.
8389         (decode_frame_entry_1): Likewise.  Check for wraparound of
8390         end pointer as well as buffer overflow.
8391
8392 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8393
8394         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8395         "vq".
8396
8397 2019-04-24  Tom Tromey  <tromey@adacore.com>
8398
8399         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8400
8401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8402
8403         * s12z-tdep.c (s12z_unwind_pc): Delete.
8404         (s12z_unwind_sp): Delete.
8405         (s12z_gdbarch_init): Don't register deleted functions with
8406         gdbarch.
8407
8408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8409
8410         * rl78-tdep.c (rl78_unwind_sp): Delete.
8411         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8412
8413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8414
8415         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8416         (xstormy16_unwind_pc): Delete.
8417         (xstormy16_dummy_id): Delete.
8418         (xstormy16_gdbarch_init): Don't register deleted functions with
8419         gdbarch.
8420
8421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8422
8423         * vax-tdep.c (vax_unwind_pc): Delete.
8424         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8425
8426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8427
8428         * v850-tdep.c (v850_unwind_sp): Delete.
8429         (v850_unwind_pc): Delete.
8430         (v850_dummy_id): Delete.
8431         (v850_gdbarch_init): Don't register deleted functions with
8432         gdbarch.
8433
8434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8435
8436         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8437         (tilegx_unwind_pc): Delete.
8438         (tilegx_unwind_dummy_id): Delete.
8439         (tilegx_gdbarch_init): Don't register deleted functions with
8440         gdbarch.
8441
8442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8443
8444         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8445         (tic6x_dummy_id): Delete.
8446         (tic6x_gdbarch_init): Don't register deleted functions with
8447         gdbarch.
8448
8449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8450
8451         * sparc-tdep.c (sparc_unwind_pc): Delete.
8452         (sparc32_gdbarch_init): Don't register deleted function with
8453         gdbarch.
8454
8455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8456
8457         * sh-tdep.c (sh_unwind_sp): Delete.
8458         (sh_unwind_pc): Delete.
8459         (sh_dummy_id): Delete.
8460         (sh_gdbarch_init): Don't register deleted functions with
8461         gdbarch.
8462
8463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8464
8465         * score-tdep.c (score_unwind_sp): Delete.
8466         (score_unwind_pc): Delete.
8467         (score_dummy_id): Delete.
8468         (score_gdbarch_init): Don't register deleted functions with
8469         gdbarch.
8470
8471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8472
8473         * rx-tdep.c (rx_unwind_pc): Delete.
8474         (rx_unwind_sp): Delete.
8475         (rx_dummy_id): Delete.
8476         (rx_gdbarch_init): Don't register deleted functions with
8477         gdbarch.  Update comment.
8478
8479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8480
8481         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8482         (rs6000_dummy_id): Delete.
8483         (rs6000_gdbarch_init): Don't register deleted functions with
8484         gdbarch.
8485
8486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8487
8488         * or1k-tdep.c (or1k_dummy_id): Delete.
8489         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8490
8491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8492
8493         * nios2-tdep.c (nios2_dummy_id): Delete.
8494         (nios2_unwind_sp): Delete.
8495         (nios2_gdbarch_init): Don't register deleted functions with
8496         gdbarch.
8497
8498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8499
8500         * nds32-tdep.c (nds32_dummy_id): Delete.
8501         (nds32_unwind_pc): Delete.
8502         (nds32_unwind_sp): Delete.
8503         (nds32_gdbarch_init): Don't register deleted functions with
8504         gdbarch.
8505
8506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8507
8508         * msp430-tdep.c (msp430_unwind_pc): Delete.
8509         (msp430_unwind_sp): Delete.
8510         (msp430_dummy_id): Delete.
8511         (msp430_gdbarch_init): Don't register deleted functions with
8512         gdbarch.
8513
8514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8515
8516         * moxie-tdep.c (moxie_unwind_sp): Delete.
8517         (moxie_unwind_pc): Delete.
8518         (moxie_dummy_id): Delete.
8519         (moxie_gdbarch_init): Don't register deleted functions with
8520         gdbarch.
8521
8522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8523
8524         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8525         (mn10300_unwind_pc): Delete.
8526         (mn10300_unwind_sp): Delete.
8527         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8528         mn10300_unwind_sp.
8529         (mn10300_frame_unwind_init): Don't register deleted functions with
8530         gdbarch.
8531
8532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8533
8534         * mep-tdep.c (mep_unwind_pc): Delete.
8535         (mep_unwind_sp): Delete.
8536         (mep_dummy_id): Delete.
8537         (mep_gdbarch_init): Don't register deleted functions with
8538         gdbarch.
8539
8540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8541
8542         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8543         (m68hc11_unwind_sp): Delete.
8544         (m68hc11_gdbarch_init): Don't register deleted functions with
8545         gdbarch.
8546
8547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8548
8549         * m32r-tdep.c (m32r_unwind_sp): Delete.
8550         (m32r_unwind_pc): Delete.
8551         (m32r_dummy_id): Delete.
8552         (m32r_gdbarch_init): Don't register deleted functions with
8553         gdbarch.
8554
8555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8556
8557         * m32c-tdep.c (m32c_unwind_pc): Delete.
8558         (m32c_unwind_sp): Delete.
8559         (m32c_dummy_id): Delete.
8560         (m32c_gdbarch_init): Don't register deleted functions with
8561         gdbarch.
8562
8563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8564
8565         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8566         (lm32_unwind_pc): Delete.
8567         (lm32_dummy_id): Delete.
8568         (lm32_gdbarch_init): Don't register deleted functions with
8569         gdbarch.
8570
8571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8572
8573         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8574         (iq2000_unwind_pc): Delete.
8575         (iq2000_dummy_id): Delete.
8576         (iq2000_gdbarch_init): Don't register deleted functions with
8577         gdbarch.
8578
8579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8580
8581         * nds32-tdep.c (nds32_type_align): Delete.
8582         (nds32_push_dummy_call): Use type_align instead.
8583
8584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8585
8586         * arm-tdep.c (arm_type_align): Only handle vector override case.
8587         (arm_push_dummy_call): Use type_align.
8588         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8589
8590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8591
8592         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8593         case.
8594         (pass_on_stack): Use type_align.
8595         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8596         function.
8597
8598 2019-04-23  Tom Tromey  <tromey@adacore.com>
8599
8600         * dwarf2read.c (line_header::file_name_at): Remove unused
8601         overload.
8602
8603 2019-04-23  Tom de Vries  <tdevries@suse.de>
8604
8605         PR gdb/24438
8606         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8607         invocation.
8608
8609
8610 2019-03-27  Ali Tamur  <tamur@google.com>
8611
8612         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8613         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8614         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8615         (dwarf_expr_context::get_addr_index): Likewise
8616         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8617         (symbol_needs_eval_context::get_addr_index): Likewise
8618         (disassemble_dwarf_expression): Add DW_OP_addrx
8619         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8620         (read_cutu_die_from_dwo): Update comment
8621         (skip_one_die): Add DW_FORM_addrx
8622         (read_attribute_value): Likewise
8623         (var_decode_location): Add DW_OP_addrx
8624         (dwarf2_const_value_attr): Add DW_FORM_addrx
8625         (dump_die_shallow): Likewise
8626         (dwarf2_fetch_constant_bytes): Likewise
8627         (decode_locdesc): Add DW_OP_addrx
8628         (skip_form_bytes): Add DW_FORM_addrx
8629
8630 2019-04-22  Ali Tamur  <tamur@google.com>
8631
8632         * MAINTAINERS (Write After Approval): Add self.
8633
8634 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8635
8636         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8637         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8638         (open_symbol_file_object): Likewise.
8639         (svr4_default_sos): Add info parameter.
8640         (svr4_read_so_list): Likewise.
8641         (svr4_current_sos_direct): Adjust functions calls to pass down
8642         info.
8643         (svr4_current_sos_1): Add info parameter.
8644         (svr4_current_sos): Call get_svr4_info, pass info down to
8645         svr4_current_sos_1.
8646         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8647         get_svr4_info.
8648         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8649         get_svr4_info.
8650         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8651         to get_svr4_info.
8652         (probes_table_remove_objfile_probes): Likewise.
8653         (register_solib_event_probe): Add info parameter.
8654         (solist_update_incremental): Pass info parameter down to
8655         svr4_read_so_list.
8656         (disable_probes_interface): Add info parameter.
8657         (svr4_handle_solib_event): Pass current_program_space to
8658         get_svr4_info.  Adjust disable_probes_interface cleanup.
8659         (svr4_create_probe_breakpoints): Add info parameter, pass it
8660         down to register_solib_event_probe.
8661         (svr4_create_solib_event_breakpoints): Add info parameter,
8662         pass it down to svr4_create_probe_breakpoints.
8663         (enable_break): Pass info down to
8664         svr4_create_solib_event_breakpoints.
8665         (svr4_solib_create_inferior_hook): Pass current_program_space to
8666         get_svr4_info.
8667         (svr4_clear_solib): Likewise.
8668
8669 2019-04-22  Pedro Alves  <palves@redhat.com>
8670
8671         * solib-svr4.c (svr4_free_objfile_observer): New.
8672         (probe_and_action::objfile): New field.
8673         (probes_table_htab_remove_objfile_probes)
8674         (probes_table_remove_objfile_probes): New functions.
8675         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8676         in the new probe_and_action.  Don't store the probe in 'lookup'.
8677         (svr4_create_probe_breakpoints): Pass objfile to
8678         register_solib_event_probe.
8679         (_initialize_svr4_solib): Register a free_objfile observer.
8680
8681 2019-04-19  Tom Tromey  <tom@tromey.com>
8682
8683         * common/queue.h: Remove.
8684
8685 2019-04-19  Tom Tromey  <tom@tromey.com>
8686
8687         * event-loop.c: Don't include "common/queue.h".
8688
8689 2019-04-19  Tom Tromey  <tom@tromey.com>
8690
8691         * remote.c (remote_target): Use delete.
8692         * remote-notif.h: Include <list>, not "common/queue.h".
8693         (notif_client_p): Remove typedef.
8694         (remote_notif_state): Add constructor, destructor, initializer.
8695         <notif_queue>: Now a std::list.
8696         (remote_notif_state_xfree): Don't declare.
8697         * remote-notif.c (remote_notif_process, handle_notification)
8698         (remote_notif_state_allocate): Update.
8699         (~remote_notif_state): Rename from remote_notif_state_xfree.
8700
8701 2019-04-19  Tom Tromey  <tom@tromey.com>
8702
8703         * symfile.c (reread_symbols): Update.
8704         * objfiles.c (objfile_register_static_link)
8705         (objfile_lookup_static_link): Update
8706         (~objfile) Don't delete static_links.
8707         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8708
8709 2019-04-19  Tom Tromey  <tom@tromey.com>
8710
8711         * type-stack.h (struct type_stack) <insert>: Constify string.
8712         * type-stack.c (type_stack::insert): Constify string.
8713         * gdbtypes.h (lookup_template_type): Update.
8714         (address_space_name_to_int): Update.
8715         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8716         const.
8717         (lookup_template_type): Make name const.
8718         * c-exp.y: Update rules.
8719         (lex_one_token, classify_name, classify_inner_name)
8720         (c_print_token): Update.
8721         * p-exp.y: Update rules.
8722         (yylex): Update.
8723         * f-exp.y: Update rules.
8724         (yylex): Update.
8725         * d-exp.y: Update rules.
8726         (lex_one_token, classify_name, classify_inner_name): Update.
8727         * parse.c (write_dollar_variable, copy_name): Return std::string.
8728         * parser-defs.h (copy_name): Change return type.
8729         * m2-exp.y: Update rules.
8730         (yylex): Update.
8731         * go-exp.y (lex_one_token): Update.
8732         Update rules.
8733         (classify_unsafe_function, classify_packaged_name)
8734         (classify_name, yylex): Update.
8735
8736 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8737
8738         * configure.ac: add --enable-source-highlight switch.
8739         * configure: Regenerate.
8740         * top.c (print_gdb_version): plumb --enable-source-highlight
8741         status to "show configuration".
8742
8743 2019-04-19  Tom Tromey  <tromey@adacore.com>
8744
8745         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8746         Check ADA_TYPE_P.
8747         (empty_record, ada_template_to_fixed_record_type_1)
8748         (template_to_static_fixed_type)
8749         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8750         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8751         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8752         macros.
8753
8754 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8755
8756         PR symtab/24423:
8757         * source.c (print_source_lines_base): Advance "iter" when a
8758         control character is seen.
8759
8760 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8761
8762         * inferior.h (struct infcall_suspend_state_deleter):
8763         Catch exception in destructor to avoid crash.
8764
8765 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8766
8767         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8768         close to the add_com "shell".
8769
8770 2019-04-18  Tom Tromey  <tromey@adacore.com>
8771
8772         * process-stratum-target.h (class process_stratum_target)
8773         <stratum>: Add "final".
8774
8775 2019-04-17  Tom Tromey  <tromey@adacore.com>
8776
8777         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8778         against nullptr before use.
8779
8780 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8781
8782         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8783
8784 2019-04-17  Jim Wilson  <jimw@sifive.com>
8785             Andrew Burgess  <andrew.burgess@embecosm.com>
8786
8787         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8788         code read might fail, assume 4-byte breakpoint in that case.
8789
8790 2019-04-15  Leszek Swirski  <leszeks@google.com>
8791
8792         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8793         rather than a hand-rolled POD check when checking for forced MEMORY
8794         classification.
8795
8796 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8797
8798         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8799         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8800         function.
8801         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8802         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8803         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8804         declaration.
8805
8806 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8807
8808         * aarch64-linux-nat.c
8809         (aarch64_linux_nat_target::thread_architecture): Add override.
8810         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8811         each VQ.
8812
8813 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8814
8815         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8816
8817 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8818
8819         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8820         target types of size 96-bits, add some additional comments, and
8821         check that the builtin type we found was the correct size.
8822
8823 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8824
8825         * utils.c (prompt_for_continue): Don't restore the styling at the
8826         end, as applied_style has the wrong value.  This fixes styling in
8827         long lists of file names that are interrupted by the "Continue?"
8828         prompt.
8829
8830 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8833         * c-lang.c (c_language_defn): Likewise.
8834         (cplus_language_defn): Likewise.
8835         (asm_language_defn): Likewise.
8836         (minimal_language_defn): Likewise.
8837         * d-lang.c (d_language_defn): Likewise.
8838         * f-lang.c (f_language_defn): Likewise.
8839         * go-lang.c (go_language_defn): Likewise.
8840         * language.c (unknown_language_defn): Likewise.
8841         (auto_language_defn): Likewise.
8842         * language.h (struct language_defn): Remove la_magic field.
8843         (LANG_MAGIC): Delete.
8844         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8845         * objc-lang.c (objc_language_defn): Likewise.
8846         * opencl-lang.c (opencl_language_defn): Likewise.
8847         * p-lang.c (pascal_language_defn): Likewise.
8848         * rust-lang.c (rust_language_defn): Likewise.
8849
8850 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * riscv-tdep.c (riscv_type_align): New function.
8853         (riscv_type_alignment): Delete.
8854         (riscv_arg_location): Use 'type_align'.
8855         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8856
8857 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8858
8859         * gdbtypes.c (type_align): A struct with no non-static fields also
8860         has alignment of 1.
8861
8862 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8863
8864         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8865         component to 0.
8866         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8867         member.
8868         (riscv_struct_info::analyse): New implementation using new
8869         analyse_inner member function.
8870         (riscv_struct_info::field_offset): New member function.
8871         (riscv_struct_info::m_offsets): New member variable.
8872         (riscv_struct_info::analyse_inner): New private member function,
8873         takes the old implementation of riscv_struct_info::analyse but
8874         extended to track field offsets.
8875         (riscv_call_arg_struct): Update the struct folding special cases
8876         to handle cases where empty C++ structs, which are non-zero
8877         length, are found.
8878         (riscv_arg_location): Initialise the length of each location, a
8879         non-zero length now indicates the location is in use.
8880         (riscv_push_dummy_call): Allow for the first location having a
8881         non-zero offset when setting up arguments.
8882         (riscv_return_value): Likewise, but for return values.
8883
8884 2019-04-11  Tom Tromey  <tromey@adacore.com>
8885
8886         * utils.c (internal_vproblem): Make "msg" const.
8887
8888 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8889
8890         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8891         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8892         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8893         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8894
8895 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8896
8897         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8898         function.
8899         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8900         of amd64_collect_native_gregset.
8901         (amd64_linux_nat_target::store_registers): Likewise.
8902
8903 2019-04-10  Tom Tromey  <tom@tromey.com>
8904
8905         * symtab.c (lookup_global_symbol_from_objfile)
8906         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8907         * objfiles.h (class separate_debug_iterator): New.
8908         (class separate_debug_range): New.
8909         (struct objfile) <separate_debug_objfiles>: New method.
8910         (objfile_separate_debug_iterate): Don't declare.
8911         * objfiles.c (separate_debug_iterator::operator++): Rename from
8912         objfile_separate_debug_iterate.
8913         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8914         iterator.
8915         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8916         iterator.
8917
8918 2019-04-10  Tom Tromey  <tom@tromey.com>
8919
8920         * symfile.c (reread_symbols): Remove old comment.
8921         * objfiles.c (free_all_objfiles): Fix a typo.
8922
8923 2019-04-10  Tom Tromey  <tom@tromey.com>
8924
8925         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8926         * minsyms.c (lookup_minimal_symbol): Use foreach.
8927         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8928         (lookup_minimal_symbol_solib_trampoline): Likewise.
8929         * symfile.c (reread_symbols): Use foreach.
8930
8931 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8932             Tom Tromey  <tromey@adacore.com>
8933
8934         PR rust/24414:
8935         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8936         (rust_lex_int_test): Change "value" to be LONGEST.
8937         (rust_lex_tests): Add test for long integer literal.
8938
8939 2019-04-09  Tom Tromey  <tromey@adacore.com>
8940
8941         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8942         to bool.
8943         (extended_remote_target::attach): Update.
8944         (remote_target::remote_notice_new_inferior): Update.
8945         (remote_target::add_current_inferior_and_thread): Update.
8946         * inferior.c (exit_inferior_1): Use "false".
8947         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8948
8949 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8950
8951         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8952         the "start" command.
8953
8954 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8955
8956         * python/py-inferior.c (infpy_thread_from_thread_handle):
8957         Adjust comments to reflect renaming of thread_from_thread_handle
8958         to thread_from_handle.  Adjust keywords.  Fix type error message.
8959         (inferior_object_methods): Add thread_from_handle.  Retain
8960         thread_from_thread_handle, but mark it as deprecated.
8961
8962 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8963
8964         * gdbthread.h (find_thread_by_handle): Revise declaration.
8965         * thread.c (find_thread_by_handle): Likewise.  Adjust
8966         implementation too.
8967         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8968         support for buffer objects as handles.
8969
8970 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8971
8972         * python/py-infthread.c (thpy_thread_handle): New function.
8973         (thread_object_methods): Register thpy_thread_handle.
8974
8975 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8976
8977         * gdbthread.h (thread_to_thread_handle): Declare.
8978         * thread.c (gdbtypes.h): Include.
8979         (thread_to_thread_handle): New function.
8980
8981         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8982         (target_thread_info_to_thread_handle): Declare.
8983         * target.c (target_thread_info_to_thread_handle): New function.
8984         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8985         * target-delegates.c: Regenerate.
8986
8987         * linux-thread-db.c (class thread_db_target): Add method
8988         thread_info_to_thread_handle.
8989         (thread_db_target::thread_info_to_thread_handle): Define.
8990         * remote.c (class remote_target): Add new method
8991         thread_info_to_thread_handle.
8992         (remote_target::thread_info_to_thread_handle): Define.
8993
8994 2019-04-08  Pedro Alves  <palves@redhat.com>
8995
8996         * common/common-exceptions.c (throw_exception): Don't create
8997         named object to throw; throw directly.
8998         (throw_it): Likewise.  Don't initialize gdb_exception::message
8999         here, with new; pass FMT and AP to the ctor instead.
9000         * common/common-exceptions.h: Include <string>.
9001         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9002         const char *, va_list)): New ctor.  Use std::make_shared.
9003         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9004         errors)): Delete.
9005         (gdb_exception_error::gdb_exception_error(enum errors, const char
9006         *, va_list)): New.
9007         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9008         Add assertion.
9009         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9010         errors)): Delete.
9011         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9012         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9013         Add assertion.
9014
9015 2019-04-08  Tom Tromey  <tom@tromey.com>
9016
9017         * valops.c (value_rtti_indirect_type): Replace throw_exception
9018         with throw.
9019         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9020         with throw.
9021         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9022         throw.
9023         * target.c (target_translate_tls_address): Replace throw_exception
9024         with throw.
9025         * stack.c (frame_apply_command_count): Replace throw_exception
9026         with throw.
9027         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9028         throw.
9029         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9030         with throw.
9031         * rs6000-tdep.c (rs6000_frame_cache)
9032         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9033         * remote.c: Replace throw_exception with throw.
9034         * record-full.c (record_full_message, record_full_wait_1)
9035         (record_full_restore): Replace throw_exception with throw.
9036         * record-btrace.c:
9037         (get_thread_current_frame_id, record_btrace_start_replaying)
9038         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9039         (cmd_record_btrace_start): Replace throw_exception with throw.
9040         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9041         throw.
9042         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9043         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9044         * linespec.c:
9045         (find_linespec_symbols): Replace throw_exception with throw.
9046         * infrun.c (displaced_step_prepare, resume): Replace
9047         throw_exception with throw.
9048         * infcmd.c (post_create_inferior): Replace throw_exception with
9049         throw.
9050         * inf-loop.c (inferior_event_handler): Replace throw_exception
9051         with throw.
9052         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9053         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9054         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9055         (get_prev_frame_always, get_frame_pc_if_available)
9056         (get_frame_address_in_block_if_available, get_frame_language):
9057         Replace throw_exception with throw.
9058         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9059         throw_exception with throw.
9060         * eval.c (fetch_subexp_value, evaluate_var_value)
9061         (evaluate_funcall, evaluate_subexp_standard): Replace
9062         throw_exception with throw.
9063         * dwarf2loc.c (call_site_find_chain)
9064         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9065         Replace throw_exception with throw.
9066         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9067         with throw.
9068         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9069         throw.
9070         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9071         * completer.c (complete_line_internal): Replace throw_exception
9072         with throw.
9073         * compile/compile-object-run.c (compile_object_run): Replace
9074         throw_exception with throw.
9075         * cli/cli-script.c (process_next_line): Replace throw_exception
9076         with throw.
9077         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9078         (btrace_enable, btrace_maint_update_pt_packets): Replace
9079         throw_exception with throw.
9080         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9081         throw_exception with throw.
9082         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9083         throw_exception with throw.
9084         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9085         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9086         * aarch64-tdep.c (aarch64_make_prologue_cache)
9087         (aarch64_make_stub_cache): Replace throw_exception with throw.
9088
9089 2019-04-08  Tom Tromey  <tom@tromey.com>
9090
9091         * common/common-exceptions.c (throw_exception): Rename from
9092         throw_exception_cxx.  Remove old copy.  Make argument const.
9093         (throw_it): Create and throw exception objects directly.
9094         * common/common-exceptions.h (throw_exception): Make argument
9095         const.
9096         (struct gdb_exception_error): Add constructor.
9097         (struct gdb_exception_quit): Add constructor.
9098
9099 2019-04-08  Tom Tromey  <tom@tromey.com>
9100
9101         * common/common-exceptions.h (exception_rethrow): Don't declare.
9102         (TRY_SJLJ): Update comment.
9103         (TRY, CATCH, END_CATCH): Remove.
9104         * common/common-exceptions.c (exception_rethrow): Remove.
9105
9106 2019-04-08  Tom Tromey  <tom@tromey.com>
9107
9108         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9109         Remove.
9110         (gdb_exception_error): Rename from
9111         gdb_exception_RETURN_MASK_ERROR.
9112         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9113         (gdb_quit_bad_alloc): Update.
9114         * aarch64-tdep.c: Update.
9115         * ada-lang.c: Update.
9116         * ada-typeprint.c: Update.
9117         * ada-valprint.c: Update.
9118         * amd64-tdep.c: Update.
9119         * arch-utils.c: Update.
9120         * break-catch-throw.c: Update.
9121         * breakpoint.c: Update.
9122         * btrace.c: Update.
9123         * c-varobj.c: Update.
9124         * cli/cli-cmds.c: Update.
9125         * cli/cli-interp.c: Update.
9126         * cli/cli-script.c: Update.
9127         * common/common-exceptions.c: Update.
9128         * common/new-op.c: Update.
9129         * common/selftest.c: Update.
9130         * compile/compile-c-symbols.c: Update.
9131         * compile/compile-cplus-symbols.c: Update.
9132         * compile/compile-object-load.c: Update.
9133         * compile/compile-object-run.c: Update.
9134         * completer.c: Update.
9135         * corelow.c: Update.
9136         * cp-abi.c: Update.
9137         * cp-support.c: Update.
9138         * cp-valprint.c: Update.
9139         * darwin-nat.c: Update.
9140         * disasm-selftests.c: Update.
9141         * dtrace-probe.c: Update.
9142         * dwarf-index-cache.c: Update.
9143         * dwarf-index-write.c: Update.
9144         * dwarf2-frame-tailcall.c: Update.
9145         * dwarf2-frame.c: Update.
9146         * dwarf2loc.c: Update.
9147         * dwarf2read.c: Update.
9148         * eval.c: Update.
9149         * event-loop.c: Update.
9150         * event-top.c: Update.
9151         * exec.c: Update.
9152         * f-valprint.c: Update.
9153         * fbsd-tdep.c: Update.
9154         * frame-unwind.c: Update.
9155         * frame.c: Update.
9156         * gdbtypes.c: Update.
9157         * gnu-v3-abi.c: Update.
9158         * guile/guile-internal.h: Update.
9159         * guile/scm-block.c: Update.
9160         * guile/scm-breakpoint.c: Update.
9161         * guile/scm-cmd.c: Update.
9162         * guile/scm-disasm.c: Update.
9163         * guile/scm-frame.c: Update.
9164         * guile/scm-lazy-string.c: Update.
9165         * guile/scm-math.c: Update.
9166         * guile/scm-param.c: Update.
9167         * guile/scm-ports.c: Update.
9168         * guile/scm-pretty-print.c: Update.
9169         * guile/scm-symbol.c: Update.
9170         * guile/scm-symtab.c: Update.
9171         * guile/scm-type.c: Update.
9172         * guile/scm-value.c: Update.
9173         * i386-linux-tdep.c: Update.
9174         * i386-tdep.c: Update.
9175         * inf-loop.c: Update.
9176         * infcall.c: Update.
9177         * infcmd.c: Update.
9178         * infrun.c: Update.
9179         * jit.c: Update.
9180         * language.c: Update.
9181         * linespec.c: Update.
9182         * linux-fork.c: Update.
9183         * linux-nat.c: Update.
9184         * linux-tdep.c: Update.
9185         * linux-thread-db.c: Update.
9186         * main.c: Update.
9187         * mi/mi-cmd-break.c: Update.
9188         * mi/mi-cmd-stack.c: Update.
9189         * mi/mi-interp.c: Update.
9190         * mi/mi-main.c: Update.
9191         * objc-lang.c: Update.
9192         * p-valprint.c: Update.
9193         * parse.c: Update.
9194         * ppc-linux-tdep.c: Update.
9195         * printcmd.c: Update.
9196         * python/py-arch.c: Update.
9197         * python/py-breakpoint.c: Update.
9198         * python/py-cmd.c: Update.
9199         * python/py-finishbreakpoint.c: Update.
9200         * python/py-frame.c: Update.
9201         * python/py-framefilter.c: Update.
9202         * python/py-gdb-readline.c: Update.
9203         * python/py-inferior.c: Update.
9204         * python/py-infthread.c: Update.
9205         * python/py-lazy-string.c: Update.
9206         * python/py-linetable.c: Update.
9207         * python/py-objfile.c: Update.
9208         * python/py-param.c: Update.
9209         * python/py-prettyprint.c: Update.
9210         * python/py-progspace.c: Update.
9211         * python/py-record-btrace.c: Update.
9212         * python/py-record.c: Update.
9213         * python/py-symbol.c: Update.
9214         * python/py-type.c: Update.
9215         * python/py-unwind.c: Update.
9216         * python/py-utils.c: Update.
9217         * python/py-value.c: Update.
9218         * python/python.c: Update.
9219         * record-btrace.c: Update.
9220         * record-full.c: Update.
9221         * remote-fileio.c: Update.
9222         * remote.c: Update.
9223         * riscv-tdep.c: Update.
9224         * rs6000-aix-tdep.c: Update.
9225         * rs6000-tdep.c: Update.
9226         * rust-exp.y: Update.
9227         * rust-lang.c: Update.
9228         * s390-tdep.c: Update.
9229         * selftest-arch.c: Update.
9230         * solib-dsbt.c: Update.
9231         * solib-frv.c: Update.
9232         * solib-spu.c: Update.
9233         * solib-svr4.c: Update.
9234         * solib.c: Update.
9235         * sparc64-linux-tdep.c: Update.
9236         * stack.c: Update.
9237         * symfile-mem.c: Update.
9238         * symmisc.c: Update.
9239         * target.c: Update.
9240         * thread.c: Update.
9241         * top.c: Update.
9242         * tracefile-tfile.c: Update.
9243         * tui/tui.c: Update.
9244         * typeprint.c: Update.
9245         * unittests/cli-utils-selftests.c: Update.
9246         * unittests/parse-connection-spec-selftests.c: Update.
9247         * valops.c: Update.
9248         * valprint.c: Update.
9249         * value.c: Update.
9250         * varobj.c: Update.
9251         * windows-nat.c: Update.
9252         * x86-linux-nat.c: Update.
9253         * xml-support.c: Update.
9254
9255 2019-04-08  Tom Tromey  <tom@tromey.com>
9256
9257         * xml-support.c: Use C++ exception handling.
9258         * x86-linux-nat.c: Use C++ exception handling.
9259         * windows-nat.c: Use C++ exception handling.
9260         * varobj.c: Use C++ exception handling.
9261         * value.c: Use C++ exception handling.
9262         * valprint.c: Use C++ exception handling.
9263         * valops.c: Use C++ exception handling.
9264         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9265         handling.
9266         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9267         * typeprint.c: Use C++ exception handling.
9268         * tui/tui.c: Use C++ exception handling.
9269         * tracefile-tfile.c: Use C++ exception handling.
9270         * top.c: Use C++ exception handling.
9271         * thread.c: Use C++ exception handling.
9272         * target.c: Use C++ exception handling.
9273         * symmisc.c: Use C++ exception handling.
9274         * symfile-mem.c: Use C++ exception handling.
9275         * stack.c: Use C++ exception handling.
9276         * sparc64-linux-tdep.c: Use C++ exception handling.
9277         * solib.c: Use C++ exception handling.
9278         * solib-svr4.c: Use C++ exception handling.
9279         * solib-spu.c: Use C++ exception handling.
9280         * solib-frv.c: Use C++ exception handling.
9281         * solib-dsbt.c: Use C++ exception handling.
9282         * selftest-arch.c: Use C++ exception handling.
9283         * s390-tdep.c: Use C++ exception handling.
9284         * rust-lang.c: Use C++ exception handling.
9285         * rust-exp.y: Use C++ exception handling.
9286         * rs6000-tdep.c: Use C++ exception handling.
9287         * rs6000-aix-tdep.c: Use C++ exception handling.
9288         * riscv-tdep.c: Use C++ exception handling.
9289         * remote.c: Use C++ exception handling.
9290         * remote-fileio.c: Use C++ exception handling.
9291         * record-full.c: Use C++ exception handling.
9292         * record-btrace.c: Use C++ exception handling.
9293         * python/python.c: Use C++ exception handling.
9294         * python/py-value.c: Use C++ exception handling.
9295         * python/py-utils.c: Use C++ exception handling.
9296         * python/py-unwind.c: Use C++ exception handling.
9297         * python/py-type.c: Use C++ exception handling.
9298         * python/py-symbol.c: Use C++ exception handling.
9299         * python/py-record.c: Use C++ exception handling.
9300         * python/py-record-btrace.c: Use C++ exception handling.
9301         * python/py-progspace.c: Use C++ exception handling.
9302         * python/py-prettyprint.c: Use C++ exception handling.
9303         * python/py-param.c: Use C++ exception handling.
9304         * python/py-objfile.c: Use C++ exception handling.
9305         * python/py-linetable.c: Use C++ exception handling.
9306         * python/py-lazy-string.c: Use C++ exception handling.
9307         * python/py-infthread.c: Use C++ exception handling.
9308         * python/py-inferior.c: Use C++ exception handling.
9309         * python/py-gdb-readline.c: Use C++ exception handling.
9310         * python/py-framefilter.c: Use C++ exception handling.
9311         * python/py-frame.c: Use C++ exception handling.
9312         * python/py-finishbreakpoint.c: Use C++ exception handling.
9313         * python/py-cmd.c: Use C++ exception handling.
9314         * python/py-breakpoint.c: Use C++ exception handling.
9315         * python/py-arch.c: Use C++ exception handling.
9316         * printcmd.c: Use C++ exception handling.
9317         * ppc-linux-tdep.c: Use C++ exception handling.
9318         * parse.c: Use C++ exception handling.
9319         * p-valprint.c: Use C++ exception handling.
9320         * objc-lang.c: Use C++ exception handling.
9321         * mi/mi-main.c: Use C++ exception handling.
9322         * mi/mi-interp.c: Use C++ exception handling.
9323         * mi/mi-cmd-stack.c: Use C++ exception handling.
9324         * mi/mi-cmd-break.c: Use C++ exception handling.
9325         * main.c: Use C++ exception handling.
9326         * linux-thread-db.c: Use C++ exception handling.
9327         * linux-tdep.c: Use C++ exception handling.
9328         * linux-nat.c: Use C++ exception handling.
9329         * linux-fork.c: Use C++ exception handling.
9330         * linespec.c: Use C++ exception handling.
9331         * language.c: Use C++ exception handling.
9332         * jit.c: Use C++ exception handling.
9333         * infrun.c: Use C++ exception handling.
9334         * infcmd.c: Use C++ exception handling.
9335         * infcall.c: Use C++ exception handling.
9336         * inf-loop.c: Use C++ exception handling.
9337         * i386-tdep.c: Use C++ exception handling.
9338         * i386-linux-tdep.c: Use C++ exception handling.
9339         * guile/scm-value.c: Use C++ exception handling.
9340         * guile/scm-type.c: Use C++ exception handling.
9341         * guile/scm-symtab.c: Use C++ exception handling.
9342         * guile/scm-symbol.c: Use C++ exception handling.
9343         * guile/scm-pretty-print.c: Use C++ exception handling.
9344         * guile/scm-ports.c: Use C++ exception handling.
9345         * guile/scm-param.c: Use C++ exception handling.
9346         * guile/scm-math.c: Use C++ exception handling.
9347         * guile/scm-lazy-string.c: Use C++ exception handling.
9348         * guile/scm-frame.c: Use C++ exception handling.
9349         * guile/scm-disasm.c: Use C++ exception handling.
9350         * guile/scm-cmd.c: Use C++ exception handling.
9351         * guile/scm-breakpoint.c: Use C++ exception handling.
9352         * guile/scm-block.c: Use C++ exception handling.
9353         * guile/guile-internal.h: Use C++ exception handling.
9354         * gnu-v3-abi.c: Use C++ exception handling.
9355         * gdbtypes.c: Use C++ exception handling.
9356         * frame.c: Use C++ exception handling.
9357         * frame-unwind.c: Use C++ exception handling.
9358         * fbsd-tdep.c: Use C++ exception handling.
9359         * f-valprint.c: Use C++ exception handling.
9360         * exec.c: Use C++ exception handling.
9361         * event-top.c: Use C++ exception handling.
9362         * event-loop.c: Use C++ exception handling.
9363         * eval.c: Use C++ exception handling.
9364         * dwarf2read.c: Use C++ exception handling.
9365         * dwarf2loc.c: Use C++ exception handling.
9366         * dwarf2-frame.c: Use C++ exception handling.
9367         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9368         * dwarf-index-write.c: Use C++ exception handling.
9369         * dwarf-index-cache.c: Use C++ exception handling.
9370         * dtrace-probe.c: Use C++ exception handling.
9371         * disasm-selftests.c: Use C++ exception handling.
9372         * darwin-nat.c: Use C++ exception handling.
9373         * cp-valprint.c: Use C++ exception handling.
9374         * cp-support.c: Use C++ exception handling.
9375         * cp-abi.c: Use C++ exception handling.
9376         * corelow.c: Use C++ exception handling.
9377         * completer.c: Use C++ exception handling.
9378         * compile/compile-object-run.c: Use C++ exception handling.
9379         * compile/compile-object-load.c: Use C++ exception handling.
9380         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9381         * compile/compile-c-symbols.c: Use C++ exception handling.
9382         * common/selftest.c: Use C++ exception handling.
9383         * common/new-op.c: Use C++ exception handling.
9384         * cli/cli-script.c: Use C++ exception handling.
9385         * cli/cli-interp.c: Use C++ exception handling.
9386         * cli/cli-cmds.c: Use C++ exception handling.
9387         * c-varobj.c: Use C++ exception handling.
9388         * btrace.c: Use C++ exception handling.
9389         * breakpoint.c: Use C++ exception handling.
9390         * break-catch-throw.c: Use C++ exception handling.
9391         * arch-utils.c: Use C++ exception handling.
9392         * amd64-tdep.c: Use C++ exception handling.
9393         * ada-valprint.c: Use C++ exception handling.
9394         * ada-typeprint.c: Use C++ exception handling.
9395         * ada-lang.c: Use C++ exception handling.
9396         * aarch64-tdep.c: Use C++ exception handling.
9397
9398 2019-04-08  Tom Tromey  <tom@tromey.com>
9399
9400         * xml-support.c (gdb_xml_parser::parse): Update.
9401         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9402         * value.c (show_convenience): Update.
9403         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9404         (test_parse_flags_qcs): Update.
9405         * thread.c (thr_try_catch_cmd): Update.
9406         * target.c (target_translate_tls_address): Update.
9407         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9408         (info_frame_command_core, frame_apply_command_count): Update.
9409         * rust-exp.y (rust_lex_exception_test): Update.
9410         * riscv-tdep.c (riscv_print_one_register_info): Update.
9411         * remote.c (remote_target::enable_btrace): Update.
9412         * record-btrace.c (record_btrace_enable_warn): Update.
9413         * python/py-utils.c (gdbpy_convert_exception): Update.
9414         * printcmd.c (do_one_display, print_variable_and_value): Update.
9415         * mi/mi-main.c (mi_print_exception): Update.
9416         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9417         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9418         * linux-nat.c (linux_nat_target::attach): Update.
9419         * linux-fork.c (class scoped_switch_fork_info): Update.
9420         * infrun.c (displaced_step_prepare): Update.
9421         * infcall.c (call_function_by_hand_dummy): Update.
9422         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9423         * gnu-v3-abi.c (print_one_vtable): Update.
9424         * frame.c (get_prev_frame_always): Update.
9425         * f-valprint.c (info_common_command_for_block): Update.
9426         * exec.c (try_open_exec_file): Update.
9427         * exceptions.c (print_exception, exception_print)
9428         (exception_fprintf, exception_print_same): Update.
9429         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9430         * dwarf-index-cache.c (index_cache::store)
9431         (index_cache::lookup_gdb_index): Update.
9432         * darwin-nat.c (maybe_cache_shell): Update.
9433         * cp-valprint.c (cp_print_value_fields): Update.
9434         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9435         (gcc_cplus_symbol_address): Update.
9436         * compile/compile-c-symbols.c (gcc_convert_symbol)
9437         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9438         * common/selftest.c: Update.
9439         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9440         a std::string.
9441         (exception_try_scope_entry, exception_try_scope_exit): Don't
9442         declare.
9443         (struct exception_try_scope): Remove.
9444         (TRY): Don't use exception_try_scope.
9445         (struct gdb_exception): Add constructor, operator=.
9446         <what>: New method.
9447         (struct gdb_exception_RETURN_MASK_ALL)
9448         (struct gdb_exception_RETURN_MASK_ERROR)
9449         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9450         (struct gdb_quit_bad_alloc): Update.
9451         * common/common-exceptions.c (exception_none): Change
9452         initializer.
9453         (struct catcher) <state, exception>: Initialize inline.
9454         <prev>: Remove member.
9455         (current_catcher): Remove.
9456         (catchers): New global.
9457         (exceptions_state_mc_init): Simplify.
9458         (catcher_pop): Remove.
9459         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9460         (try_scope_depth, exception_try_scope_entry)
9461         (exception_try_scope_exit): Remove.
9462         (throw_exception_sjlj): Update.
9463         (exception_messages, exception_messages_size): Remove.
9464         (throw_it): Simplify.
9465         (gdb_exception_sliced_copy): Remove.
9466         (throw_exception_cxx): Update.
9467         * cli/cli-script.c (script_from_file): Update.
9468         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9469         Update.
9470         * ada-valprint.c (ada_val_print): Update.
9471         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9472         (create_excep_cond_exprs): Update.
9473
9474 2019-04-08  Tom Tromey  <tom@tromey.com>
9475
9476         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9477         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9478         (TRY, CATCH, END_CATCH): Remove some definitions.
9479         * common/common-exceptions.c: Don't use GDB_XCPT.
9480         (catcher_list_size): Remove.
9481         (throw_exception, throw_it): Simplify.
9482
9483 2019-04-05  Tom Tromey  <tom@tromey.com>
9484
9485         Revert the header-sorting patch.
9486         * ft32-tdep.c: Revert.
9487         * frv-tdep.c: Revert.
9488         * frv-linux-tdep.c: Revert.
9489         * frame.c: Revert.
9490         * frame-unwind.c: Revert.
9491         * frame-base.c: Revert.
9492         * fork-child.c: Revert.
9493         * findvar.c: Revert.
9494         * findcmd.c: Revert.
9495         * filesystem.c: Revert.
9496         * filename-seen-cache.h: Revert.
9497         * filename-seen-cache.c: Revert.
9498         * fbsd-tdep.c: Revert.
9499         * fbsd-nat.h: Revert.
9500         * fbsd-nat.c: Revert.
9501         * f-valprint.c: Revert.
9502         * f-typeprint.c: Revert.
9503         * f-lang.c: Revert.
9504         * extension.h: Revert.
9505         * extension.c: Revert.
9506         * extension-priv.h: Revert.
9507         * expprint.c: Revert.
9508         * exec.h: Revert.
9509         * exec.c: Revert.
9510         * exceptions.c: Revert.
9511         * event-top.c: Revert.
9512         * event-loop.c: Revert.
9513         * eval.c: Revert.
9514         * elfread.c: Revert.
9515         * dwarf2read.h: Revert.
9516         * dwarf2read.c: Revert.
9517         * dwarf2loc.c: Revert.
9518         * dwarf2expr.h: Revert.
9519         * dwarf2expr.c: Revert.
9520         * dwarf2-frame.c: Revert.
9521         * dwarf2-frame-tailcall.c: Revert.
9522         * dwarf-index-write.h: Revert.
9523         * dwarf-index-write.c: Revert.
9524         * dwarf-index-common.c: Revert.
9525         * dwarf-index-cache.h: Revert.
9526         * dwarf-index-cache.c: Revert.
9527         * dummy-frame.c: Revert.
9528         * dtrace-probe.c: Revert.
9529         * disasm.h: Revert.
9530         * disasm.c: Revert.
9531         * disasm-selftests.c: Revert.
9532         * dictionary.c: Revert.
9533         * dicos-tdep.c: Revert.
9534         * demangle.c: Revert.
9535         * dcache.h: Revert.
9536         * dcache.c: Revert.
9537         * darwin-nat.h: Revert.
9538         * darwin-nat.c: Revert.
9539         * darwin-nat-info.c: Revert.
9540         * d-valprint.c: Revert.
9541         * d-namespace.c: Revert.
9542         * d-lang.c: Revert.
9543         * ctf.c: Revert.
9544         * csky-tdep.c: Revert.
9545         * csky-linux-tdep.c: Revert.
9546         * cris-tdep.c: Revert.
9547         * cris-linux-tdep.c: Revert.
9548         * cp-valprint.c: Revert.
9549         * cp-support.c: Revert.
9550         * cp-namespace.c: Revert.
9551         * cp-abi.c: Revert.
9552         * corelow.c: Revert.
9553         * corefile.c: Revert.
9554         * continuations.c: Revert.
9555         * completer.h: Revert.
9556         * completer.c: Revert.
9557         * complaints.c: Revert.
9558         * coffread.c: Revert.
9559         * coff-pe-read.c: Revert.
9560         * cli-out.h: Revert.
9561         * cli-out.c: Revert.
9562         * charset.c: Revert.
9563         * c-varobj.c: Revert.
9564         * c-valprint.c: Revert.
9565         * c-typeprint.c: Revert.
9566         * c-lang.c: Revert.
9567         * buildsym.c: Revert.
9568         * buildsym-legacy.c: Revert.
9569         * build-id.h: Revert.
9570         * build-id.c: Revert.
9571         * btrace.c: Revert.
9572         * bsd-uthread.c: Revert.
9573         * breakpoint.h: Revert.
9574         * breakpoint.c: Revert.
9575         * break-catch-throw.c: Revert.
9576         * break-catch-syscall.c: Revert.
9577         * break-catch-sig.c: Revert.
9578         * blockframe.c: Revert.
9579         * block.c: Revert.
9580         * bfin-tdep.c: Revert.
9581         * bfin-linux-tdep.c: Revert.
9582         * bfd-target.c: Revert.
9583         * bcache.c: Revert.
9584         * ax-general.c: Revert.
9585         * ax-gdb.h: Revert.
9586         * ax-gdb.c: Revert.
9587         * avr-tdep.c: Revert.
9588         * auxv.c: Revert.
9589         * auto-load.c: Revert.
9590         * arm-wince-tdep.c: Revert.
9591         * arm-tdep.c: Revert.
9592         * arm-symbian-tdep.c: Revert.
9593         * arm-pikeos-tdep.c: Revert.
9594         * arm-obsd-tdep.c: Revert.
9595         * arm-nbsd-tdep.c: Revert.
9596         * arm-nbsd-nat.c: Revert.
9597         * arm-linux-tdep.c: Revert.
9598         * arm-linux-nat.c: Revert.
9599         * arm-fbsd-tdep.c: Revert.
9600         * arm-fbsd-nat.c: Revert.
9601         * arm-bsd-tdep.c: Revert.
9602         * arch-utils.c: Revert.
9603         * arc-tdep.c: Revert.
9604         * arc-newlib-tdep.c: Revert.
9605         * annotate.h: Revert.
9606         * annotate.c: Revert.
9607         * amd64-windows-tdep.c: Revert.
9608         * amd64-windows-nat.c: Revert.
9609         * amd64-tdep.c: Revert.
9610         * amd64-sol2-tdep.c: Revert.
9611         * amd64-obsd-tdep.c: Revert.
9612         * amd64-obsd-nat.c: Revert.
9613         * amd64-nbsd-tdep.c: Revert.
9614         * amd64-nbsd-nat.c: Revert.
9615         * amd64-nat.c: Revert.
9616         * amd64-linux-tdep.c: Revert.
9617         * amd64-linux-nat.c: Revert.
9618         * amd64-fbsd-tdep.c: Revert.
9619         * amd64-fbsd-nat.c: Revert.
9620         * amd64-dicos-tdep.c: Revert.
9621         * amd64-darwin-tdep.c: Revert.
9622         * amd64-bsd-nat.c: Revert.
9623         * alpha-tdep.c: Revert.
9624         * alpha-obsd-tdep.c: Revert.
9625         * alpha-nbsd-tdep.c: Revert.
9626         * alpha-mdebug-tdep.c: Revert.
9627         * alpha-linux-tdep.c: Revert.
9628         * alpha-linux-nat.c: Revert.
9629         * alpha-bsd-tdep.c: Revert.
9630         * alpha-bsd-nat.c: Revert.
9631         * aix-thread.c: Revert.
9632         * agent.c: Revert.
9633         * addrmap.c: Revert.
9634         * ada-varobj.c: Revert.
9635         * ada-valprint.c: Revert.
9636         * ada-typeprint.c: Revert.
9637         * ada-tasks.c: Revert.
9638         * ada-lang.c: Revert.
9639         * aarch64-tdep.c: Revert.
9640         * aarch64-ravenscar-thread.c: Revert.
9641         * aarch64-newlib-tdep.c: Revert.
9642         * aarch64-linux-tdep.c: Revert.
9643         * aarch64-linux-nat.c: Revert.
9644         * aarch64-fbsd-tdep.c: Revert.
9645         * aarch64-fbsd-nat.c: Revert.
9646         * aarch32-linux-nat.c: Revert.
9647
9648 2019-04-05  Tom Tromey  <tom@tromey.com>
9649
9650         * ft32-tdep.c: Sort headers.
9651         * frv-tdep.c: Sort headers.
9652         * frv-linux-tdep.c: Sort headers.
9653         * frame.c: Sort headers.
9654         * frame-unwind.c: Sort headers.
9655         * frame-base.c: Sort headers.
9656         * fork-child.c: Sort headers.
9657         * findvar.c: Sort headers.
9658         * findcmd.c: Sort headers.
9659         * filesystem.c: Sort headers.
9660         * filename-seen-cache.h: Sort headers.
9661         * filename-seen-cache.c: Sort headers.
9662         * fbsd-tdep.c: Sort headers.
9663         * fbsd-nat.h: Sort headers.
9664         * fbsd-nat.c: Sort headers.
9665         * f-valprint.c: Sort headers.
9666         * f-typeprint.c: Sort headers.
9667         * f-lang.c: Sort headers.
9668         * extension.h: Sort headers.
9669         * extension.c: Sort headers.
9670         * extension-priv.h: Sort headers.
9671         * expprint.c: Sort headers.
9672         * exec.h: Sort headers.
9673         * exec.c: Sort headers.
9674         * exceptions.c: Sort headers.
9675         * event-top.c: Sort headers.
9676         * event-loop.c: Sort headers.
9677         * eval.c: Sort headers.
9678         * elfread.c: Sort headers.
9679         * dwarf2read.h: Sort headers.
9680         * dwarf2read.c: Sort headers.
9681         * dwarf2loc.c: Sort headers.
9682         * dwarf2expr.h: Sort headers.
9683         * dwarf2expr.c: Sort headers.
9684         * dwarf2-frame.c: Sort headers.
9685         * dwarf2-frame-tailcall.c: Sort headers.
9686         * dwarf-index-write.h: Sort headers.
9687         * dwarf-index-write.c: Sort headers.
9688         * dwarf-index-common.c: Sort headers.
9689         * dwarf-index-cache.h: Sort headers.
9690         * dwarf-index-cache.c: Sort headers.
9691         * dummy-frame.c: Sort headers.
9692         * dtrace-probe.c: Sort headers.
9693         * disasm.h: Sort headers.
9694         * disasm.c: Sort headers.
9695         * disasm-selftests.c: Sort headers.
9696         * dictionary.c: Sort headers.
9697         * dicos-tdep.c: Sort headers.
9698         * demangle.c: Sort headers.
9699         * dcache.h: Sort headers.
9700         * dcache.c: Sort headers.
9701         * darwin-nat.h: Sort headers.
9702         * darwin-nat.c: Sort headers.
9703         * darwin-nat-info.c: Sort headers.
9704         * d-valprint.c: Sort headers.
9705         * d-namespace.c: Sort headers.
9706         * d-lang.c: Sort headers.
9707         * ctf.c: Sort headers.
9708         * csky-tdep.c: Sort headers.
9709         * csky-linux-tdep.c: Sort headers.
9710         * cris-tdep.c: Sort headers.
9711         * cris-linux-tdep.c: Sort headers.
9712         * cp-valprint.c: Sort headers.
9713         * cp-support.c: Sort headers.
9714         * cp-namespace.c: Sort headers.
9715         * cp-abi.c: Sort headers.
9716         * corelow.c: Sort headers.
9717         * corefile.c: Sort headers.
9718         * continuations.c: Sort headers.
9719         * completer.h: Sort headers.
9720         * completer.c: Sort headers.
9721         * complaints.c: Sort headers.
9722         * coffread.c: Sort headers.
9723         * coff-pe-read.c: Sort headers.
9724         * cli-out.h: Sort headers.
9725         * cli-out.c: Sort headers.
9726         * charset.c: Sort headers.
9727         * c-varobj.c: Sort headers.
9728         * c-valprint.c: Sort headers.
9729         * c-typeprint.c: Sort headers.
9730         * c-lang.c: Sort headers.
9731         * buildsym.c: Sort headers.
9732         * buildsym-legacy.c: Sort headers.
9733         * build-id.h: Sort headers.
9734         * build-id.c: Sort headers.
9735         * btrace.c: Sort headers.
9736         * bsd-uthread.c: Sort headers.
9737         * breakpoint.h: Sort headers.
9738         * breakpoint.c: Sort headers.
9739         * break-catch-throw.c: Sort headers.
9740         * break-catch-syscall.c: Sort headers.
9741         * break-catch-sig.c: Sort headers.
9742         * blockframe.c: Sort headers.
9743         * block.c: Sort headers.
9744         * bfin-tdep.c: Sort headers.
9745         * bfin-linux-tdep.c: Sort headers.
9746         * bfd-target.c: Sort headers.
9747         * bcache.c: Sort headers.
9748         * ax-general.c: Sort headers.
9749         * ax-gdb.h: Sort headers.
9750         * ax-gdb.c: Sort headers.
9751         * avr-tdep.c: Sort headers.
9752         * auxv.c: Sort headers.
9753         * auto-load.c: Sort headers.
9754         * arm-wince-tdep.c: Sort headers.
9755         * arm-tdep.c: Sort headers.
9756         * arm-symbian-tdep.c: Sort headers.
9757         * arm-pikeos-tdep.c: Sort headers.
9758         * arm-obsd-tdep.c: Sort headers.
9759         * arm-nbsd-tdep.c: Sort headers.
9760         * arm-nbsd-nat.c: Sort headers.
9761         * arm-linux-tdep.c: Sort headers.
9762         * arm-linux-nat.c: Sort headers.
9763         * arm-fbsd-tdep.c: Sort headers.
9764         * arm-fbsd-nat.c: Sort headers.
9765         * arm-bsd-tdep.c: Sort headers.
9766         * arch-utils.c: Sort headers.
9767         * arc-tdep.c: Sort headers.
9768         * arc-newlib-tdep.c: Sort headers.
9769         * annotate.h: Sort headers.
9770         * annotate.c: Sort headers.
9771         * amd64-windows-tdep.c: Sort headers.
9772         * amd64-windows-nat.c: Sort headers.
9773         * amd64-tdep.c: Sort headers.
9774         * amd64-sol2-tdep.c: Sort headers.
9775         * amd64-obsd-tdep.c: Sort headers.
9776         * amd64-obsd-nat.c: Sort headers.
9777         * amd64-nbsd-tdep.c: Sort headers.
9778         * amd64-nbsd-nat.c: Sort headers.
9779         * amd64-nat.c: Sort headers.
9780         * amd64-linux-tdep.c: Sort headers.
9781         * amd64-linux-nat.c: Sort headers.
9782         * amd64-fbsd-tdep.c: Sort headers.
9783         * amd64-fbsd-nat.c: Sort headers.
9784         * amd64-dicos-tdep.c: Sort headers.
9785         * amd64-darwin-tdep.c: Sort headers.
9786         * amd64-bsd-nat.c: Sort headers.
9787         * alpha-tdep.c: Sort headers.
9788         * alpha-obsd-tdep.c: Sort headers.
9789         * alpha-nbsd-tdep.c: Sort headers.
9790         * alpha-mdebug-tdep.c: Sort headers.
9791         * alpha-linux-tdep.c: Sort headers.
9792         * alpha-linux-nat.c: Sort headers.
9793         * alpha-bsd-tdep.c: Sort headers.
9794         * alpha-bsd-nat.c: Sort headers.
9795         * aix-thread.c: Sort headers.
9796         * agent.c: Sort headers.
9797         * addrmap.c: Sort headers.
9798         * ada-varobj.c: Sort headers.
9799         * ada-valprint.c: Sort headers.
9800         * ada-typeprint.c: Sort headers.
9801         * ada-tasks.c: Sort headers.
9802         * ada-lang.c: Sort headers.
9803         * aarch64-tdep.c: Sort headers.
9804         * aarch64-ravenscar-thread.c: Sort headers.
9805         * aarch64-newlib-tdep.c: Sort headers.
9806         * aarch64-linux-tdep.c: Sort headers.
9807         * aarch64-linux-nat.c: Sort headers.
9808         * aarch64-fbsd-tdep.c: Sort headers.
9809         * aarch64-fbsd-nat.c: Sort headers.
9810         * aarch32-linux-nat.c: Sort headers.
9811
9812 2019-04-04  Tom Tromey  <tom@tromey.com>
9813
9814         * varobj.c (varobj_create): Update.
9815         * rust-exp.y (struct rust_parser) <update_innermost_block,
9816         lookup_symbol>: New methods.
9817         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9818         Rename.
9819         (rust_parser::rust_lookup_type)
9820         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9821         * printcmd.c (display_command, do_one_display): Update.
9822         * parser-defs.h (struct parser_state) <parser_state>: Add
9823         "tracker" parameter.
9824         (block_tracker): New member.
9825         (class innermost_block_tracker) <innermost_block_tracker>: Add
9826         "types" parameter.
9827         <reset>: Remove method.
9828         (innermost_block): Don't declare.
9829         (null_post_parser): Update.
9830         * parse.c (innermost_block): Remove global.
9831         (write_dollar_variable): Update.
9832         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9833         Remove "tracker_types" parameter.
9834         (parse_expression): Add "tracker" parameter.
9835         (parse_expression_for_completion): Update.
9836         (null_post_parser): Add "tracker" parameter.
9837         * p-exp.y: Update rules.
9838         * m2-exp.y: Update rules.
9839         * language.h (struct language_defn) <la_post_parser>: Add
9840         "tracker" parameter.
9841         * go-exp.y: Update rules.
9842         * f-exp.y: Update rules.
9843         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9844         parameter.
9845         * d-exp.y: Update rules.
9846         * c-exp.y: Update rules.
9847         * breakpoint.c (set_breakpoint_condition): Create an
9848         innermost_block_tracker.
9849         (watch_command_1): Likewise.
9850         * ada-lang.c (resolve): Add "tracker" parameter.
9851         (resolve_subexp): Likewise.
9852         * ada-exp.y (write_var_from_sym): Update.
9853
9854 2019-04-04  Tom Tromey  <tom@tromey.com>
9855
9856         * type-stack.h: New file.
9857         * type-stack.c: New file.
9858         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9859         type-stack.h.
9860         (insert_into_type_stack, insert_type, push_type, push_type_int)
9861         (insert_type_address_space, pop_type, pop_type_int)
9862         (pop_typelist, pop_type_stack, append_type_stack)
9863         (push_type_stack, get_type_stack, push_typelist)
9864         (follow_type_instance_flags, follow_types): Don't declare.
9865         * parse.c (type_stack): Remove global.
9866         (parse_exp_in_context): Update.
9867         (insert_into_type_stack, insert_type, push_type, push_type_int)
9868         (insert_type_address_space, pop_type, pop_type_int)
9869         (pop_typelist, pop_type_stack, append_type_stack)
9870         (push_type_stack, get_type_stack, push_typelist)
9871         (follow_type_instance_flags, follow_types): Remove (moved to
9872         type-stack.c).
9873         * f-exp.y (type_stack): New global.
9874         Update rules.
9875         (push_kind_type, f_parse): Update.
9876         * d-exp.y (type_stack): New global.
9877         Update rules.
9878         (d_parse): Update.
9879         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9880         Update rules.
9881         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9882         (HFILES_NO_SRCDIR): Add type-stack.h.
9883
9884 2019-04-04  Tom Tromey  <tom@tromey.com>
9885
9886         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9887         (rust_parser::convert_ast_to_expression, rust_parse)
9888         (rust_lex_test_completion, rust_lex_tests): Update.
9889         * parser-defs.h (struct expr_completion_state): New.
9890         (struct parser_state) <parser_state>: Add completion parameter.
9891         <mark_struct_expression, mark_completion_tag>: New methods.
9892         <parse_completion, m_completion_state>: New members.
9893         (prefixify_expression, null_post_parser): Update.
9894         (mark_struct_expression, mark_completion_tag): Don't declare.
9895         * parse.c (parse_completion, expout_last_struct)
9896         (expout_tag_completion_type, expout_completion_name): Remove
9897         globals.
9898         (parser_state::mark_struct_expression)
9899         (parser_state::mark_completion_tag): Now methods.
9900         (prefixify_expression): Add last_struct parameter.
9901         (prefixify_subexp): Likewise.
9902         (parse_exp_1): Update.
9903         (parse_exp_in_context): Add cstate parameter.  Update.
9904         (parse_expression_for_completion): Create an
9905         expr_completion_state.
9906         (null_post_parser): Add "completion" parameter.
9907         * p-exp.y: Update rules.
9908         (yylex): Update.
9909         * language.h (struct language_defn) <la_post_parser>: Add
9910         "completing" parameter.
9911         * go-exp.y: Update rules.
9912         (lex_one_token): Update.
9913         * expression.h (parse_completion): Don't declare.
9914         * d-exp.y: Update rules.
9915         (lex_one_token): Update rules.
9916         * c-exp.y: Update rules.
9917         (lex_one_token): Update.
9918         * ada-lang.c (resolve): Add "parse_completion" parameter.
9919         (resolve_subexp): Likewise.
9920         (ada_resolve_function): Likewise.
9921
9922 2019-04-04  Tom Tromey  <tom@tromey.com>
9923
9924         * parser-defs.h (struct parser_state) <start_arglist,
9925         end_arglist>: New methods.
9926         <arglist_len, m_funcall_chain>: New members.
9927         (arglist_len, start_arglist, end_arglist): Don't declare.
9928         * parse.c (arglist_len, funcall_chain): Remove global.
9929         (start_arglist, end_arglist): Remove functions.
9930         (parse_exp_in_context): Update.
9931         * p-exp.y: Update rules.
9932         * m2-exp.y: Update rules.
9933         * go-exp.y: Update rules.
9934         * f-exp.y: Update rules.
9935         * d-exp.y: Update rules.
9936         * c-exp.y: Update rules.
9937
9938 2019-04-04  Tom Tromey  <tom@tromey.com>
9939
9940         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9941         lex_operator, push_back>: New methods.
9942         Update all rules.
9943         (rust_parser::lex_hex, lex_escape): Rename and update.
9944         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9945         (rust_parser::lex_operator): Rename and update.
9946         (rust_parser::lex_number, rustyylex, rustyyerror)
9947         (rust_lex_test_init, rust_lex_test_sequence)
9948         (rust_lex_test_push_back, rust_lex_tests): Update.
9949         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9950         parameter.
9951         <lexptr, prev_lexptr>: New members.
9952         (lexptr, prev_lexptr): Don't declare.
9953         * parse.c (lexptr, prev_lexptr): Remove globals.
9954         (parse_exp_in_context): Update.
9955         * p-exp.y (yylex, yyerror): Update.
9956         * m2-exp.y (parse_number, yylex, yyerror): Update.
9957         * go-exp.y (lex_one_token, yyerror): Update.
9958         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9959         * d-exp.y (lex_one_token, yyerror): Update.
9960         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9961         (lex_one_token, yyerror): Update.
9962         * ada-lex.l (YY_INPUT): Update.
9963         (rewind_to_char): Update.
9964         * ada-exp.y (yyerror): Update.
9965
9966 2019-04-04  Tom Tromey  <tom@tromey.com>
9967
9968         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9969         * parser-defs.h (struct parser_state) <parser_state>: Add new
9970         parameter.
9971         <comma_terminates>: New member.
9972         (comma_terminates): Don't declare global.
9973         * parse.c (comma_terminates): Remove global.
9974         (parse_exp_in_context): Update.
9975         * p-exp.y (yylex): Update.
9976         * m2-exp.y (yylex): Update.
9977         * go-exp.y (lex_one_token): Update.
9978         * f-exp.y (yylex): Update.
9979         * d-exp.y (lex_one_token): Update.
9980         * c-exp.y (lex_one_token): Update.
9981         * ada-lex.l: Update.
9982
9983 2019-04-04  Tom Tromey  <tom@tromey.com>
9984
9985         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9986         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9987         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9988         * parser-defs.h (paren_depth): Don't declare.
9989         * parse.c (paren_depth): Remove global.
9990         (parse_exp_in_context): Update.
9991         * p-exp.y (paren_depth): New global.
9992         (pascal_parse): Initialize it.
9993         * m2-exp.y (paren_depth): New global.
9994         (m2_parse): Initialize it.
9995         * go-exp.y (paren_depth): New global.
9996         (go_parse): Initialize it.
9997         * f-exp.y (paren_depth): New global.
9998         (f_parse): Initialize it.
9999         * d-exp.y (paren_depth): New global.
10000         (d_parse): Initialize it.
10001         * c-exp.y (paren_depth): New global.
10002         (c_parse): Initialize it.
10003         * ada-lex.l (paren_depth): New global.
10004         (lexer_init): Initialize it.
10005
10006 2019-04-04  Tom Tromey  <tom@tromey.com>
10007
10008         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10009         (rust_parser::convert_ast_to_type)
10010         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10011         * parser-defs.h (struct parser_state) <parser_state>: Add
10012         parameters.  Initialize new members.
10013         <expression_context_block, expression_context_pc>: New members.
10014         * parse.c (expression_context_block, expression_context_pc):
10015         Remove globals.
10016         (parse_exp_in_context): Update.
10017         * p-exp.y: Update all rules.
10018         (yylex): Update.
10019         * m2-exp.y: Update all rules.
10020         (yylex): Update.
10021         * go-exp.y (yylex): Update.
10022         * f-exp.y (yylex): Update.
10023         * d-exp.y: Update all rules.
10024         (yylex): Update.
10025         * c-exp.y: Update all rules.
10026         (lex_one_token, classify_name, yylex, c_parse): Update.
10027         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10028
10029 2019-04-04  Tom Tromey  <tom@tromey.com>
10030
10031         * gdbarch.h, gdbarch.c: Rebuild.
10032         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10033         * stap-probe.h:
10034         (struct stap_parse_info): Replace "parser_state" with
10035         "expr_builder".
10036         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10037         (parser_state): New class.
10038         * parse.c (expr_builder): Rename.
10039         (expr_builder::release): Rename.
10040         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10041         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10042         (write_exp_elt_longcst, write_exp_elt_floatcst)
10043         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10044         (write_exp_string_vector, write_exp_bitstring)
10045         (write_exp_msymbol, mark_struct_expression)
10046         (write_dollar_variable)
10047         (insert_type_address_space, increase_expout_size): Replace
10048         "parser_state" with "expr_builder".
10049         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10050         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10051         "parser_state" with "expr_builder".
10052
10053 2019-04-04  Tom Tromey  <tom@tromey.com>
10054
10055         * rust-exp.y: Replace "parse_language" with method call.
10056         * p-exp.y:
10057         (yylex): Replace "parse_language" with method call.
10058         * m2-exp.y:
10059         (yylex): Replace "parse_language" with method call.
10060         * go-exp.y (classify_name): Replace "parse_language" with method
10061         call.
10062         * f-exp.y (yylex): Replace "parse_language" with method call.
10063         * d-exp.y (lex_one_token): Replace "parse_language" with method
10064         call.
10065         * c-exp.y:
10066         (lex_one_token, classify_name, yylex): Replace "parse_language"
10067         with method call.
10068         * ada-exp.y (find_primitive_type, type_char)
10069         (type_system_address): Replace "parse_language" with method call.
10070
10071 2019-04-04  Tom Tromey  <tom@tromey.com>
10072
10073         * rust-exp.y: Replace "parse_gdbarch" with method call.
10074         * parse.c (write_dollar_variable, insert_type_address_space):
10075         Replace "parse_gdbarch" with method call.
10076         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10077         call.
10078         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10079         call.
10080         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10081         "parse_gdbarch" with method call.
10082         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10083         with method call.
10084         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10085         "parse_gdbarch" with method call.
10086         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10087         "parse_gdbarch" with method call.
10088         * c-exp.y (parse_type, parse_number, classify_name): Replace
10089         "parse_gdbarch" with method call.
10090         * ada-lex.l: Replace "parse_gdbarch" with method call.
10091         * ada-exp.y (parse_type, find_primitive_type, type_char)
10092         (type_system_address): Replace "parse_gdbarch" with method call.
10093
10094 2019-04-04  Tom Tromey  <tom@tromey.com>
10095
10096         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10097         * stap-probe.c (stap_parse_argument): Update.
10098         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10099         initial_size parameter.
10100         * rust-exp.y (rust_lex_tests): Update.
10101         * parse.c (parser_state): Update.
10102         (parse_exp_in_context): Update.
10103         * parser-defs.h (struct parser_state) <parser_state>: Remove
10104         "initial_size" parameter.
10105
10106 2019-04-04  Tom Tromey  <tom@tromey.com>
10107
10108         * parser-defs.h (increase_expout_size): Don't declare.
10109         * parse.c (increase_expout_size): Now static.
10110
10111 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10112
10113         * gnu-nat.c (gnu_nat_target::wait): Fix
10114         target_waitstatus_to_string call.
10115
10116 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10117
10118         * eval.c (evaluate_subexp_standard): Handle internal functions
10119         during Fortran function call handling.
10120
10121 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10122
10123         * NEWS: Mention new internal functions.
10124         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10125         (read_base_type): Use dwarf2_init_complex_target_type.
10126         * value.c (creal_internal_fn): New function.
10127         (cimag_internal_fn): New function.
10128         (_initialize_values): Register new internal functions.
10129
10130 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10131
10132         * infrun.c (stop_all_threads): If debug_infrun, always
10133         trace the wait status after wait_one, using
10134         target_waitstatus_to_string and target_pid_to_str.
10135         (handle_inferior_event): Replace various trace of
10136         wait status kind by a single trace.
10137         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10138         wait status kind image by target_waitstatus_to_string.
10139         * target/waitstatus.c (target_waitstatus_to_string): Fix
10140         obsolete comment.
10141
10142 2019-04-01  Tom Tromey  <tromey@adacore.com>
10143
10144         PR symtab/23331:
10145         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10146
10147 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10148             Pedro Alves  <palves@redhat.com>
10149
10150         * top.c (quit_force): Call 'finalize_values'.
10151         * value.c (finalize_values): New function.
10152         * value.h (finalize_values): Declare.
10153
10154 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10155
10156         * NEWS: Announce $_gdb_major and $_gdb_minor.
10157
10158         * top.c (init_gdb_version_vars): New function.
10159         (gdb_init): Call init_gdb_version_vars.
10160
10161 2019-03-29  Tom Tromey  <tromey@adacore.com>
10162
10163         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10164         help text.  Remove dead code.
10165
10166 2019-03-29  Keith Seitz  <keiths@redhat.com>
10167
10168         From Siddhesh Poyarekar:
10169         * f-lang.h (f77_get_upperbound): Return LONGEST.
10170         (f77_get_lowerbound): Likewise.
10171         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10172         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10173         print them.
10174         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10175         plongest to format print it.
10176         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10177         (f77_get_upperbound): Likewise.
10178         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10179         LOWER_BOUND to LONGEST.
10180         (f77_create_arrayprint_offset_tbl): Likewise.
10181
10182 2019-03-29  Keith Seitz  <keiths@redhat.com>
10183
10184         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10185         %s/pulongest for TYPE_LENGTH instead of %d in format
10186         strings.
10187         * ada-typerint.c (ada_print_type): Likewise.
10188         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10189         * compile/compile-c-support.c (generate_register_struct): Likewise.
10190         * gdbtypes.c (recursive_dump_type): Likewise.
10191         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10192         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10193         instead of %d in format strings.
10194         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10195         to std::min to ULONGEST.
10196         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10197         instead of %d in format strings.
10198         * tracepoint.c (info_scope_command): Likewise.
10199         * typeprint.c (print_offset_data::update)
10200         (print_offset_data::finish): Likewise.
10201         * xtensa-tdep.c (xtensa_store_return_value)
10202         (xtensa_push_dummy_call): Likewise.
10203
10204 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10205
10206         * windows-nat.c (display_selector): Fixed format specifications
10207         for 64-bit Cygwin.
10208
10209 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10210
10211         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10212
10213 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10214
10215         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10216         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10217         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10218         (nios2_linux_init_abi): Install it.
10219
10220 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10221
10222         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10223
10224 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10225
10226         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10227
10228 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10229             Tom Tromey  <tromey@adacore.com>
10230
10231         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10232
10233 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10234
10235         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10236         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10237         method to compute the bounds of range types. Also print "[evaluated]"
10238         if the bounds' values come from a dynamic evaluation.
10239
10240 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10241
10242         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10243         whitespace when pretty printing is on.
10244
10245 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10246
10247         * ppc-linux-nat.c: Add include.
10248
10249 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10250
10251         * NEWS: Mention AArch64 Pointer Authentication.
10252
10253 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10254
10255         * arm-linux-nat.c: Add include.
10256
10257 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10258
10259         * source-cache.c (source_cache::get_source_lines): Re-read
10260         fullname after calling open_source_file.
10261
10262 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10263
10264         * NEWS: Mention TLS support for FreeBSD.
10265
10266 2019-03-25  Tom Tromey  <tromey@adacore.com>
10267
10268         * minsyms.c (BUNCH_SIZE): Update comment.
10269         (~minimal_symbol_reader): Remove old comment.
10270         (compact_minimal_symbols): Update comment.
10271         (minimal_symbol_reader::install): Remove old comment.  Update
10272         other comments.
10273
10274 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10275
10276         * s390-linux-nat.c: Add include.
10277
10278 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10279
10280         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10281         Call linux_get_hwcap.
10282         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10283         Likewise.
10284         (aarch64_linux_get_hwcap): Remove function.
10285         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10286         declaration.
10287         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10288         linux_get_hwcap.
10289         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10290         * linux-tdep.c (linux_get_hwcap): Add function.
10291         (linux_get_hwcap2): Likewise.
10292         * linux-tdep.h (linux_get_hwcap): Add declaration.
10293         (linux_get_hwcap2): Likewise.
10294         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10295         (ppc_linux_get_hwcap2): Likewise.
10296         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10297         linux_get_hwcap.
10298         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10299         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10300         (ppc_linux_nat_target::read_description): Likewise.
10301         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10302         * s390-linux-nat.c: Likewise.
10303         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10304
10305 2019-03-24  Tom Tromey  <tom@tromey.com>
10306
10307         * ada-lang.c (standard_lookup): Simplify initialization.
10308         (ada_lookup_symbol_nonlocal): Simplify return.
10309         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10310         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10311         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10312         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10313         initialization.
10314         * solib.c (solib_global_lookup): Simplify.
10315         * symtab.c (null_block_symbol): Remove.
10316         (symbol_cache_lookup): Simplify returns.
10317         (lookup_language_this): Simplify returns.
10318         (lookup_symbol_aux): Simplify return.
10319         (lookup_local_symbol): Simplify returns.
10320         (lookup_global_symbol_from_objfile): Simplify return.
10321         (lookup_symbol_in_objfile_symtabs)
10322         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10323         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10324         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10325         * cp-namespace.c (cp_lookup_bare_symbol)
10326         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10327         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10328         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10329         (cp_lookup_symbol_via_imports): Simplify initialization.
10330         (find_symbol_in_baseclass): Likewise.
10331         * symtab.h (null_block_symbol): Remove.
10332         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10333         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10334         (d_lookup_symbol_module): Likewise.
10335         (find_symbol_in_baseclass): Simplify initialization.
10336
10337 2019-03-24  Tom Tromey  <tom@tromey.com>
10338
10339         * expression.h: Don't include symtab.h.
10340         (struct block): Forward declare.
10341
10342 2019-03-24  Tom Tromey  <tom@tromey.com>
10343
10344         * c-exp.y (typebase): Remove casts.
10345         * gdbtypes.c (lookup_unsigned_typename, )
10346         (lookup_signed_typename): Remove cast.
10347         * eval.c (parse_to_comma_and_eval): Remove cast.
10348         * parse.c (write_dollar_variable): Remove cast.
10349         * block.h (struct block) <superblock>: Now const.
10350         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10351         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10352         (map_block): Make "block" const.
10353         * symfile.h (struct quick_symbol_functions)
10354         <map_matching_symbols>: Constify block argument to "callback".
10355         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10356         const.
10357         (find_pc_sect_compunit_symtab): Make "b" const.
10358         (find_symbol_at_address): Likewise.
10359         (search_symbols): Likewise.
10360         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10361         (dw2_debug_names_lookup_symbol): Likewise.
10362         (dw2_map_matching_symbols): Update.
10363         * p-valprint.c (pascal_val_print): Remove "block".
10364         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10365         (aux_add_nonlocal_symbols): Make "block" const.
10366         (resolve_subexp): Remove cast.
10367         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10368         const.
10369         (iterate_over_file_blocks): Likewise.
10370         * f-exp.y (%union) <bval>: Remove.
10371         * coffread.c (patch_opaque_types): Make "b" const.
10372         * spu-tdep.c (spu_catch_start): Make "block" const.
10373         * c-valprint.c (print_unpacked_pointer): Remove "block".
10374         * symmisc.c (dump_symtab_1): Make "b" const.
10375         (block_depth): Make "block" const.
10376         * d-exp.y (%union) <bval>: Remove.
10377         * cp-support.h (cp_lookup_rtti_type): Update.
10378         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10379         * psymtab.c (psym_lookup_symbol): Make "block" const.
10380         (maintenance_check_psymtabs): Make "b" const.
10381         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10382         (enumerate_locals, enumerate_args): Update.
10383         * python/py-symtab.c (stpy_global_block): Make "block" const.
10384         (stpy_static_block): Likewise.
10385         * inline-frame.c (block_starting_point_at): Make "new_block"
10386         const.
10387         * block.c (find_block_in_blockvector): Make return type const.
10388         (blockvector_for_pc_sect): Make "b" const.
10389         (find_block_in_blockvector): Make "b" const.
10390
10391 2019-03-23  Tom Tromey  <tom@tromey.com>
10392
10393         * varobj.c (varobj_create): Update.
10394         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10395         * printcmd.c (display_command, do_one_display): Don't reset
10396         innermost_block.
10397         * parser-defs.h (enum innermost_block_tracker_type): Move to
10398         expression.h.
10399         (innermost_block): Update comment.
10400         * parse.c (parse_exp_1): Add tracker_types parameter.
10401         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10402         tracker_types parameter.  Reset innermost_block.
10403         (parse_exp_in_context): Remove.
10404         (parse_expression_for_completion): Update.
10405         * objfiles.c (~objfile): Don't reset expression_context_block or
10406         innermost_block.
10407         * expression.h (enum innermost_block_tracker_type): Move from
10408         parser-defs.h.
10409         (parse_exp_1): Add tracker_types parameter.
10410         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10411         reset innermost_block.
10412
10413 2019-03-23  Tom Tromey  <tom@tromey.com>
10414
10415         * objfiles.h: Include bcache.h.
10416
10417 2019-03-23  Tom Tromey  <tom@tromey.com>
10418
10419         * linespec.c (get_current_search_block): Use
10420         scoped_restore_current_language.
10421         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10422
10423 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10424             Jiong Wang  <jiong.wang@arm.com>
10425
10426         * aarch64-linux-tdep.c
10427         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10428         section.
10429         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10430
10431 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10432             Jiong Wang  <jiong.wang@arm.com>
10433
10434         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10435         instructions.
10436         (aarch64_analyze_prologue_test): Add PACIASP test.
10437         (aarch64_prologue_prev_register): Unmask PC value.
10438
10439 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10440             Jiong Wang  <jiong.wang@arm.com>
10441
10442         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10443         (aarch64_dwarf2_prev_register): Unmask PC value.
10444         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10445         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10446         DW_CFA_AARCH64_negate_ra_state.
10447         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10448
10449 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10450             Jiong Wang  <jiong.wang@arm.com>
10451
10452         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10453         registers.
10454         (aarch64_pseudo_register_name): Likewise.
10455         (aarch64_pseudo_register_type): Likewise.
10456         (aarch64_pseudo_register_reggroup_p): Likewise.
10457         (aarch64_gdbarch_init): Add pauth registers.
10458         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10459         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10460         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10461         (struct gdbarch_tdep): Add regnum for ra_state.
10462
10463 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10464             Jiong Wang  <jiong.wang@arm.com>
10465
10466         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10467
10468 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10469             Jiong Wang  <jiong.wang@arm.com>
10470
10471         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10472         function.
10473         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10474         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10475         (aarch64_gdbarch_init): Add puth registers.
10476         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10477         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10478         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10479
10480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10481             Jiong Wang  <jiong.wang@arm.com>
10482
10483         * aarch64-linux-nat.c
10484         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10485         * aarch64-linux-tdep.c
10486         (aarch64_linux_core_read_description): Likewise.
10487         (aarch64_linux_get_hwcap): New function.
10488         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10489         (aarch64_linux_get_hwcap): New declaration.
10490
10491 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10492             Jiong Wang  <jiong.wang@arm.com>
10493
10494         * aarch64-linux-nat.c
10495         (aarch64_linux_nat_target::read_description): Add pauth param.
10496         * aarch64-linux-tdep.c
10497         (aarch64_linux_core_read_description): Likewise.
10498         * aarch64-tdep.c (struct target_desc): Add in pauth.
10499         (aarch64_read_description): Add pauth param.
10500         (aarch64_gdbarch_init): Likewise.
10501         * aarch64-tdep.h (aarch64_read_description): Likewise.
10502         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10503         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10504         * features/Makefile: Add new files.
10505         * features/aarch64-pauth.c: New file.
10506         * features/aarch64-pauth.xml: New file.
10507
10508 2019-03-20  Tom Tromey  <tromey@adacore.com>
10509
10510         * infrun.c (handle_inferior_event): Rename from
10511         handle_inferior_event_1.  Create a scoped_value_mark.
10512         (handle_inferior_event): Remove.
10513
10514 2019-03-19  Tom Tromey  <tromey@adacore.com>
10515
10516         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10517         * infrun.h (print_stop_event): Add "displays" parameter.
10518         * infrun.c (print_stop_event): Add "displays" parameter.
10519
10520 2019-03-19  Pedro Alves  <palves@redhat.com>
10521
10522         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10523         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10524         to -1.  Fix TABs vs spaces.
10525         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10526         * tui/tui-out.h (tui_ui_out) Add intro comments.
10527         <m_line, m_start_of_line>: In-class initialize, and add describing
10528         comment.
10529
10530 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10531
10532         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10533         variable names.
10534         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10535
10536 2019-03-18  Pedro Alves  <palves@redhat.com>
10537             Eli Zaretskii <eliz@gnu.org>
10538
10539         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10540         m_line and m_start_of_line.
10541
10542 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10543
10544         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10545         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10546         it returns a newline.  This fixes a regression in TU mode, whereby
10547         the next line is output on the same screen line as the user input.
10548
10549 2019-03-18  Tom Tromey  <tromey@adacore.com>
10550
10551         * minsyms.c (minimal_symbol_reader::install): Remove call to
10552         obstack_blank.
10553
10554 2019-03-18  Pedro Alves  <palves@redhat.com>
10555
10556         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10557         New globals.
10558         (apply_style): New, factored out from ...
10559         (apply_ansi_escape): ... this.  Handle reverse video mode.
10560         (tui_set_reverse_mode): New function.
10561         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10562         * tui/tui-winsource.c (tui_show_source_line): Use
10563         tui_set_reverse_mode instead of setting A_STANDOUT.
10564         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10565         New setter methods.
10566
10567 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10568
10569         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10570         Handle tabs.
10571
10572 2019-03-18  Tom Tromey  <tromey@adacore.com>
10573
10574         * ada-lang.c (empty_array): Add "high" parameter.
10575         (ada_evaluate_subexp): Update.
10576
10577 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10578
10579         * unittests/string_view-selftests.c: Define
10580         _initialize_string_view_selftests unconditionally.
10581
10582 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10583
10584         PR gdb/24350
10585         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10586
10587 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10588
10589         PR gdb/24351
10590         * windows-nat.c (display_selector): Fix format specifiers.
10591
10592 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10593
10594         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10595         tui_refill_source_window instead of tui_refresh_win, to update the
10596         current execution line.  This fixes redisplay of the current line
10597         when stepping through the code with "next" or "step".
10598
10599 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10600
10601         * source-cache.c (source_cache::get_source_lines): Call
10602         find_source_lines to initialize s->nlines.  This fixes vertical
10603         scrolling of TUI source window when the DOWN arrow is pressed.
10604
10605 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10606
10607         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10608         linux-thread-db.c (_initialize_thread_db): Likewise.
10609
10610 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10611
10612         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10613         wclrtoeol in tui_show_source_line".  This reverts changes made in
10614         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10615
10616 2019-03-15  Tom Tromey  <tom@tromey.com>
10617
10618         * symtab.h (struct minimal_symbol): Derive from
10619         general_symbol_info.
10620         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10621         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10622         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10623         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10624         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10625         (MSYMBOL_SEARCH_NAME): Update.
10626         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10627         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10628         * minsyms.c (minimal_symbol_reader::record_full): Update.
10629
10630 2019-03-15  Tom Tromey  <tom@tromey.com>
10631
10632         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10633
10634 2019-03-15  Tom Tromey  <tom@tromey.com>
10635
10636         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10637         unique_xmalloc_ptr.
10638         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10639         Update.
10640         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10641         (build_minimal_symbol_hash_tables)
10642         (minimal_symbol_reader::install): Update.
10643
10644 2019-03-15  Tom Tromey  <tom@tromey.com>
10645
10646         * symtab.c (create_demangled_names_hash): Update.
10647         (symbol_set_names): Update.
10648         * objfiles.h (struct objfile_per_bfd_storage)
10649         <demangled_names_hash>: Now an htab_up.
10650         * objfiles.c (objfile_per_bfd_storage): Simplify.
10651
10652 2019-03-15  Tom Tromey  <tom@tromey.com>
10653
10654         * objfiles.h (struct objfile_per_bfd_storage): Declare
10655         destructor.
10656         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10657         New.
10658         (get_objfile_bfd_data): Use new.  Don't initialize
10659         language_of_main.
10660         (free_objfile_per_bfd_storage): Remove.
10661         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10662
10663 2019-03-15  Tom Tromey  <tom@tromey.com>
10664
10665         * symfile.c (reread_symbols): Update.
10666         * objfiles.c (objfile::objfile): Update.
10667         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10668         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10669         comment.
10670         (minimal_symbol_reader::install): Update.
10671         (terminate_minimal_symbol_table): Remove.
10672         * jit.c (jit_object_close_impl): Update.
10673
10674 2019-03-15  Tom Tromey  <tom@tromey.com>
10675
10676         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10677         initializations.
10678
10679 2019-03-15  Tom Tromey  <tom@tromey.com>
10680
10681         * objfiles.h (struct objfile_per_bfd_storage)
10682         <demangled_hash_languages>: Now a bitset.
10683         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10684         (lookup_minimal_symbol): Update.
10685
10686 2019-03-15  Tom Tromey  <tom@tromey.com>
10687
10688         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10689         Don't return the symbol.
10690         * coffread.c (record_minimal_symbol): Use record_full.
10691
10692 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10693
10694         The MS-Windows port of ncurses fails to switch to a color pair if
10695         one or both of the colors are the implicit default colors.  This
10696         change records the default colors when TUI is initialized, and
10697         then specifies them explicitly when a color pair uses the default
10698         colors.  This allows color styling in TUI mode on MS-Windows.
10699
10700         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10701         ncurses_norm_attr.
10702         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10703         colors in ncurses_norm_attr.
10704         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10705         "none", replace it with the default color recorded in
10706         ncurses_norm_attr.
10707
10708 2019-03-14  Tom Tromey  <tromey@adacore.com>
10709
10710         * source-cache.h (class source_cache) <get_source_lines>: Return
10711         std::string.
10712         * source-cache.c (source_cache::extract_lines): Handle case where
10713         first_pos==npos.  Return std::string.
10714         (source_cache::get_source_lines): Update.
10715
10716 2019-03-14  Tom Tromey  <tromey@adacore.com>
10717
10718         * NEWS: Add item for "style sources" commands.
10719         * source-cache.c (source_cache::get_source_lines): Check
10720         source_styling.
10721         * cli/cli-style.c (source_styling): New global.
10722         (_initialize_cli_style): Add "style sources" commands.
10723         (show_style_sources): New function.
10724         * cli/cli-style.h (source_styling): Declare.
10725
10726 2019-03-14  Pedro Alves  <palves@redhat.com>
10727             Tom Tromey  <tromey@adacore.com>
10728
10729         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10730         * tui/tui-winsource.c (tui_refill_source_window): New function,
10731         from...
10732         (tui_horizontal_source_scroll): ... here.  Move some logic.
10733         * cli/cli-style.c (set_style_enabled): Notify new observable.
10734         * tui/tui-hooks.c (tui_redisplay_source): New function.
10735         (tui_attach_detach_observers): Attach or detach
10736         tui_redisplay_source.
10737         * observable.h (source_styling_changed): New observable.
10738         * observable.c: Define source_styling_changed observable.
10739
10740 2019-03-13  Tom Tromey  <tromey@adacore.com>
10741
10742         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10743         (i386_gnu_nat_target::store_registers): Update.
10744         * target-debug.h (target_debug_print_std_string): New macro.
10745         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10746         * windows-tdep.c (display_one_tib): Update.
10747         * tui/tui-stack.c (tui_make_status_line): Update.
10748         * top.c (print_inferior_quit_action): Update.
10749         * thread.c (thr_try_catch_cmd): Update.
10750         (add_thread_with_info): Update.
10751         (thread_target_id_str): Update.
10752         (thr_try_catch_cmd): Update.
10753         (thread_command): Update.
10754         (thread_find_command): Update.
10755         * record-btrace.c (record_btrace_target::info_record)
10756         (record_btrace_resume_thread, record_btrace_target::resume)
10757         (record_btrace_cancel_resume, record_btrace_step_thread)
10758         (record_btrace_target::wait, record_btrace_target::wait)
10759         (record_btrace_target::wait, record_btrace_target::stop): Update.
10760         * progspace.c (print_program_space): Update.
10761         * process-stratum-target.c
10762         (process_stratum_target::thread_address_space): Update.
10763         * linux-fork.c (linux_fork_mourn_inferior)
10764         (detach_checkpoint_command, info_checkpoints_command)
10765         (linux_fork_context): Update.
10766         (linux_fork_detach): Update.
10767         (class scoped_switch_fork_info): Update.
10768         (delete_checkpoint_command): Update.
10769         * infrun.c (follow_fork_inferior): Update.
10770         (follow_fork_inferior): Update.
10771         (proceed_after_vfork_done): Update.
10772         (handle_vfork_child_exec_or_exit): Update.
10773         (follow_exec): Update.
10774         (displaced_step_prepare_throw): Update.
10775         (displaced_step_restore): Update.
10776         (start_step_over): Update.
10777         (resume_1): Update.
10778         (clear_proceed_status_thread): Update.
10779         (proceed): Update.
10780         (print_target_wait_results): Update.
10781         (do_target_wait): Update.
10782         (context_switch): Update.
10783         (stop_all_threads): Update.
10784         (restart_threads): Update.
10785         (finish_step_over): Update.
10786         (handle_signal_stop): Update.
10787         (switch_back_to_stepped_thread): Update.
10788         (keep_going_pass_signal): Update.
10789         (print_exited_reason): Update.
10790         (normal_stop): Update.
10791         * inferior.c (inferior_pid_to_str): Change return type.
10792         (print_selected_inferior): Update.
10793         (add_inferior): Update.
10794         (detach_inferior): Update.
10795         * dummy-frame.c (fprint_dummy_frames): Update.
10796         * dcache.c (dcache_info_1): Update.
10797         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10798         (btrace_fetch, btrace_clear): Update.
10799         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10800         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10801         type.
10802         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10803         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10804         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10805         * gdbarch.c, gdbarch.h: Rebuild.
10806         * gdbarch.sh (core_pid_to_str): Change return type.
10807         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10808         return type.
10809         (windows_nat_target::pid_to_str): Change return type.
10810         (windows_delete_thread): Update.
10811         (windows_nat_target::attach): Update.
10812         (windows_nat_target::files_info): Update.
10813         * target-delegates.c: Rebuild.
10814         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10815         return type.
10816         (sol_thread_target::pid_to_str): Change return type.
10817         * remote.c (class remote_target) <pid_to_str>: Change return
10818         type.
10819         (remote_target::pid_to_str): Change return type.
10820         (extended_remote_target::attach, remote_target::remote_stop_ns)
10821         (remote_target::remote_notif_remove_queued_reply)
10822         (remote_target::push_stop_reply, remote_target::disable_btrace):
10823         Update.
10824         (extended_remote_target::attach): Update.
10825         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10826         type.
10827         (gdbsim_target::pid_to_str): Change return type.
10828         * ravenscar-thread.c (struct ravenscar_thread_target)
10829         <pid_to_str>: Change return type.
10830         (ravenscar_thread_target::pid_to_str): Change return type.
10831         * procfs.c (class procfs_target) <pid_to_str>: Change return
10832         type.
10833         (procfs_target::pid_to_str): Change return type.
10834         (procfs_target::attach): Update.
10835         (procfs_target::detach): Update.
10836         (procfs_target::fetch_registers): Update.
10837         (procfs_target::store_registers): Update.
10838         (procfs_target::wait): Update.
10839         (procfs_target::files_info): Update.
10840         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10841         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10842         return type.
10843         (nto_procfs_target::pid_to_str): Change return type.
10844         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10845         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10846         return type.
10847         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10848         (exit_lwp): Update.
10849         (attach_proc_task_lwp_callback, get_detach_signal)
10850         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10851         (linux_nat_target::resume, wait_lwp, stop_callback)
10852         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10853         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10854         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10855         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10856         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10857         type.
10858         (inf_ptrace_target::attach): Update.
10859         (inf_ptrace_target::files_info): Update.
10860         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10861         type.
10862         (go32_nat_target::pid_to_str): Change return type.
10863         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10864         (gnu_nat_target::wait): Update.
10865         (gnu_nat_target::wait): Update.
10866         (gnu_nat_target::resume): Update.
10867         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10868         (fbsd_nat_target::wait): Update.
10869         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10870         type.
10871         (darwin_nat_target::attach): Update.
10872         * corelow.c (class core_target) <pid_to_str>: Change return type.
10873         (core_target::pid_to_str): Change return type.
10874         * target.c (normal_pid_to_str): Change return type.
10875         (default_pid_to_str): Likewise.
10876         (target_pid_to_str): Change return type.
10877         (target_translate_tls_address): Update.
10878         (target_announce_detach): Update.
10879         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10880         return type.
10881         (bsd_uthread_target::pid_to_str): Change return type.
10882         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10883         type.
10884         (bsd_kvm_target::pid_to_str): Change return type.
10885         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10886         return type.
10887         (aix_thread_target::pid_to_str): Change return type.
10888         * target.h (struct target_ops) <pid_to_str>: Change return type.
10889         (target_pid_to_str, normal_pid_to_str): Likewise.
10890         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10891         type.
10892         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10893         type.
10894         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10895         return type.
10896         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10897         type.
10898         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10899         type.
10900         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10901         return type.
10902
10903 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10904
10905         * NEWS: Mention that the new default MI version is 3.  Mention
10906         changes to the output of commands and events that deal with
10907         multi-location breakpoints.
10908         * breakpoint.c: Include "mi/mi-out.h".
10909         (print_one_breakpoint): Change output syntax if using MI version
10910         >= 3.
10911         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10912         New.
10913         (mi_multi_location_breakpoint_output_fixed): New.
10914         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10915         (mi_cmd_fix_multi_location_breakpoint_output): New.
10916         (mi_multi_location_breakpoint_output_fixed): New.
10917         * mi/mi-cmds.c (mi_cmds): Register command
10918         -fix-multi-location-breakpoint-output.
10919         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10920         interpreter "mi".
10921
10922 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10923
10924         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10925         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10926         instantiate mi_ui_out based on interpreter name.
10927         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10928         * mi/mi-main.c (mi_load_progress): Likewise.
10929
10930 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10931
10932         * NEWS: Combine separate "New targets" sections for 8.3.
10933
10934 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10935
10936         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10937         (ppcfbsd_init_abi): Install gdbarch
10938         "fetch_tls_load_module_address" and "get_thread_local_address"
10939         methods.
10940
10941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10942
10943         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10944         (riscv_fbsd_init_abi): Install gdbarch
10945         "fetch_tls_load_module_address" and "get_thread_local_address"
10946         methods.
10947
10948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10949
10950         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10951         (i386fbsd_init_abi): Install gdbarch
10952         "fetch_tls_load_module_address" and "get_thread_local_address"
10953         methods.
10954
10955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10956
10957         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10958         (amd64fbsd_init_abi): Install gdbarch
10959         "fetch_tls_load_module_address" and "get_thread_local_address"
10960         methods.
10961
10962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10963
10964         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10965         (struct fbsd_pspace_data): New type.
10966         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10967         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10968         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10969         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10970         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10971
10972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10973
10974         * gdbtypes.c (lookup_struct_elt): New function.
10975         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10976         * gdbtypes.h (struct struct_elt): New type.
10977         (lookup_struct_elt): New prototype.
10978
10979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10980
10981         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10982         remove disabled code block.
10983
10984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10985
10986         * gdbarch.sh (get_thread_local_address): New method.
10987         * gdbarch.h, gdbarch.c: Regenerate.
10988         * target.c (target_translate_tls_address): Use
10989         gdbarch_get_thread_local_address if present instead of
10990         target::get_thread_local_address.
10991
10992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10993
10994         * target.h (target::get_thread_local_address): Update comment.
10995
10996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10997
10998         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10999         objfile->separate_debug_objfile_backlink if not NULL.
11000
11001 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11002
11003         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11004         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11005         (amd64bsd_store_inferior_registers): Likewise.
11006         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11007         Enable segment base registers.
11008         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11009         PT_GETFSBASE and PT_GETGSBASE.
11010         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11011         PT_SETGSBASE.
11012         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11013         segment base registers.
11014         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11015
11016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11017
11018         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11019         Update calls to i386_target_description to add 'segments'
11020         parameter.
11021         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11022         add segment base registers.
11023         * arch/i386.c (i386_create_target_description): Add 'segments'
11024         parameter to enable segment base registers.
11025         * arch/i386.h (i386_create_target_description): Likewise.
11026         * features/i386/32bit-segments.xml: New file.
11027         * features/i386/32bit-segments.c: Generate.
11028         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11029         call to i386_target_description to add 'segments' parameter.
11030         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11031         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11032         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11033         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11034         if feature is present.
11035         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11036         Add 'segments' parameter to call to i386_target_description.
11037         (i386_target_description): Add 'segments' parameter to enable
11038         segment base registers.
11039         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11040         to call to i386_target_description.
11041         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11042         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11043         Define I386_NUM_REGS.
11044         (i386_target_description): Add 'segments' parameter to enable
11045         segment base registers.
11046
11047 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11048
11049         PR/24325
11050         * source-cache.c: #undef open and close, to avoid unresolved
11051         externals during linking.
11052
11053 2019-03-12  Tom Tromey  <tromey@adacore.com>
11054
11055         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11056         const.  Add initializers.
11057         (_initialize_remote): Don't initialize ptid globals.
11058
11059 2019-03-12  Pedro Alves  <palves@redhat.com>
11060
11061         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11062
11063 2019-03-12  Pedro Alves  <palves@redhat.com>
11064
11065         * cp-name-parser.y (main): Remove unused 'len' variable.
11066
11067 2019-03-12  Tom Tromey  <tromey@adacore.com>
11068
11069         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11070         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11071
11072 2019-03-12  Tom Tromey  <tromey@adacore.com>
11073
11074         * linux-nat.c (iterate_over_lwps): Update.
11075         (stop_callback): Remove parameter.
11076         (stop_wait_callback, detach_callback, resume_set_callback)
11077         (select_singlestep_lwp_callback, set_ignore_sigint)
11078         (status_callback, resumed_callback, resume_clear_callback)
11079         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11080         data parameter.
11081         (linux_nat_target::detach, linux_nat_target::resume)
11082         (linux_stop_and_wait_all_lwps, select_event_lwp)
11083         (linux_nat_filter_event, linux_nat_wait_1)
11084         (linux_nat_target::kill, linux_nat_target::stop)
11085         (linux_nat_target::stop): Update.
11086         (linux_nat_resume_callback): Change type.
11087         (resume_stopped_resumed_lwps, count_events_callback)
11088         (select_event_lwp_callback): Likewise.
11089         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11090         * arm-linux-nat.c (struct update_registers_data): Remove.
11091         (update_registers_callback): Change type.
11092         (arm_linux_insert_hw_breakpoint1): Update.
11093         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11094         parameter.
11095         (x86_linux_dr_set_addr): Update.
11096         (x86_linux_dr_set_control): Update.
11097         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11098         (iterate_over_lwps): Use gdb::function_view.
11099         * nat/aarch64-linux-hw-point.c (struct
11100         aarch64_dr_update_callback_param): Remove.
11101         (debug_reg_change_callback): Change type.
11102         (aarch64_notify_debug_reg_change): Update.
11103         * s390-linux-nat.c (s390_refresh_per_info): Update.
11104
11105 2019-03-11  Tom Tromey  <tromey@adacore.com>
11106
11107         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11108         redundant assignment to "this_cu".
11109
11110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11111
11112         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11113
11114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11115
11116         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11117         from...
11118         (rank_one_type): ... this.
11119
11120 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11121
11122         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11123         from...
11124         (rank_one_type): ... this.
11125
11126 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11127
11128         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11129         from...
11130         (rank_one_type): ... this.
11131
11132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11133
11134         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11135         from...
11136         (rank_one_type): ... this.
11137
11138 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11139
11140         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11141         from...
11142         (rank_one_type): ... this.
11143
11144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11145
11146         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11147         from...
11148         (rank_one_type): ... this.
11149
11150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11151
11152         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11153         from...
11154         (rank_one_type): ... this.
11155
11156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11157
11158         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11159         from...
11160         (rank_one_type): ... this.
11161
11162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11163
11164         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11165         from...
11166         (rank_one_type): ... this.
11167
11168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11169
11170         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11171         from...
11172         (rank_one_type): ... this.
11173
11174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11175
11176         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11177         from...
11178         (rank_one_type): ... this.
11179
11180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11181
11182         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11183         from...
11184         (rank_one_type): ... this.
11185
11186 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11187
11188         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11189         inferior-events' shows the example events.
11190
11191 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11192
11193         Support styling on native MS-Windows console
11194
11195         PR/24315
11196         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11197         on MS-Windows if $TERM is not defined.
11198
11199         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11200
11201         * posix-hdep.c (gdb_console_fputs):
11202         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11203         functions.
11204         * ui-file.h (gdb_console_fputs): Add prototype.
11205
11206         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11207         back to fputs only if the former returns zero.
11208
11209 2019-03-07  Tom Tromey  <tom@tromey.com>
11210
11211         * symmisc.c (print_symbol_bcache_statistics): Update.
11212         (print_objfile_statistics): Update.
11213         * symfile.c (allocate_symtab): Update.
11214         * stabsread.c: Don't include bcache.h.
11215         * psymtab.h (struct psymbol_bcache): Don't declare.
11216         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11217         (psymbol_bcache_init, psymbol_bcache_free)
11218         (psymbol_bcache_get_bcache): Don't declare.
11219         * psymtab.c (struct psymbol_bcache): Remove.
11220         (psymtab_storage::psymtab_storage): Update.
11221         (psymtab_storage::~psymtab_storage): Update.
11222         (psymbol_bcache_init, psymbol_bcache_free)
11223         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11224         (add_psymbol_to_bcache): Update.
11225         (allocate_psymtab): Update.
11226         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11227         macro_cache>: No longer pointers.
11228         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11229         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11230         * macrotab.c (macro_bcache): Update.
11231         * macroexp.c: Don't include bcache.h.
11232         * gdbtypes.c (check_types_worklist): Update.
11233         (types_deeply_equal): Remove TRY/CATCH.  Update.
11234         * elfread.c (elf_symtab_read): Update.
11235         * dwarf2read.c: Don't include bcache.h.
11236         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11237         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11238         (print_bcache_statistics, bcache_memory_used): Don't declare.
11239         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11240         methods.  Rename all data members.
11241         * bcache.c (struct bcache): Move to bcache.h.
11242         (bcache::expand_hash_table): Rename from expand_hash_table.
11243         (bcache): Remove.
11244         (bcache::insert): Rename from bcache_full.
11245         (bcache::compare): Rename from bcache_compare.
11246         (bcache_xmalloc): Remove.
11247         (bcache::~bcache): Rename from bcache_xfree.
11248         (bcache::print_statistics): Rename from print_bcache_statistics.
11249         (bcache::memory_used): Rename from bcache_memory_used.
11250
11251 2019-03-07  Pedro Alves  <palves@redhat.com>
11252
11253         * infrun.c (normal_stop): Also check for
11254         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11255
11256 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11257
11258         * f-lang.c (value_from_host_double): Moved to...
11259         * value.c (value_from_host_double): ...here.
11260         * value.h (value_from_host_double): Declare.
11261         * guile/scm-math.c (vlscm_convert_typed_number): Use
11262         value_from_host_double.
11263         (vlscm_convert_number): Likewise.
11264         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11265         * python/py-value.c (convert_value_from_python): Likewise.
11266
11267 2019-03-06  Tom Tromey  <tom@tromey.com>
11268
11269         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11270
11271 2019-03-06  Tom Tromey  <tom@tromey.com>
11272
11273         * utils.h (free_current_contents): Don't declare.
11274         * utils.c (free_current_contents): Remove.
11275
11276 2019-03-06  Tom Tromey  <tom@tromey.com>
11277
11278         * top.c (quit_force): Update.
11279         * main.c (captured_command_loop): Update.
11280         * common/new-op.c (operator new): Update.
11281         * common/common-exceptions.c (struct catcher)
11282         <save_cleanup_chain>: Remove member.
11283         (exceptions_state_mc_init): Update.
11284         (exception_try_scope_entry): Return nullptr.
11285         (exception_try_scope_exit, exception_rethrow)
11286         (throw_exception_sjlj, throw_exception_cxx): Update.
11287         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11288         (all_cleanups, do_cleanups, discard_cleanups)
11289         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11290         (restore_cleanups, restore_final_cleanups): Don't declare.
11291         (do_final_cleanups): Remove parameter.
11292         * common/cleanups.c (cleanup_chain, make_cleanup)
11293         (make_cleanup_dtor, all_cleanups, do_cleanups)
11294         (discard_my_cleanups, discard_cleanups)
11295         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11296         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11297         (null_cleanup): Remove.
11298         (do_final_cleanups): Remove parameter.
11299
11300 2019-03-06  Tom Tromey  <tom@tromey.com>
11301
11302         * remote.c (remote_target::remote_parse_stop_reply): Use
11303         unique_xmalloc_ptr.
11304
11305 2019-03-06  Tom Tromey  <tom@tromey.com>
11306
11307         * stabsread.c (struct stabs_field_info): Rename from field_info.
11308         <list, fnlist>: Add initializers.
11309         <obstack>: New member.
11310         (read_member_functions, read_struct_fields, read_baseclasses):
11311         Allocate on obstack.  Don't use cleanups.
11312         (read_one_struct_field, read_member_functions, read_struct_fields)
11313         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11314         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11315         (read_struct_type): Update.
11316
11317 2019-03-06  Tom Tromey  <tom@tromey.com>
11318
11319         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11320         * common/filestuff.h (make_cleanup_close): Don't declare.
11321         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11322         Remove.
11323
11324 2019-03-06  Tom Tromey  <tom@tromey.com>
11325
11326         * solib-aix.c: Use make_scope_exit.
11327
11328 2019-03-06  Tom Tromey  <tom@tromey.com>
11329
11330         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11331         Use make_scope_exit.
11332
11333 2019-03-06  Tom Tromey  <tom@tromey.com>
11334
11335         * solib-svr4.c (disable_probes_interface): Remove parameter.
11336         (svr4_handle_solib_event): Use make_scope_exit.
11337
11338 2019-03-06  Tom Tromey  <tom@tromey.com>
11339
11340         * remote.c (struct stop_reply_deleter): Remove.
11341         (stop_reply_up): Update.
11342         (struct stop_reply): Derive from notif_event.  Don't typedef.
11343         <regcache>: Now a std::vector.
11344         (stop_reply_xfree): Remove.
11345         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11346         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11347         (remote_target::discard_pending_stop_replies): Use delete.
11348         (remote_target::remote_parse_stop_reply): Update.
11349         (remote_target::process_stop_reply): Update.
11350         * remote-notif.h (struct notif_event): Add virtual destructor.
11351         Remove "dtr" member.
11352         (struct notif_client) <alloc_event>: Return a unique_ptr.
11353         (notif_event_xfree): Don't declare.
11354         (notif_event_up): New typedef.
11355         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11356         (notif_event_xfree, do_notif_event_xfree): Remove.
11357         (remote_notif_state_xfree): Update.
11358
11359 2019-03-06  Tom Tromey  <tom@tromey.com>
11360
11361         * infrun.c (displaced_step_clear_cleanup): Now a
11362         forward_scope_exit type.
11363         (displaced_step_prepare_throw): Update.
11364         (displaced_step_fixup): Update.
11365
11366 2019-03-06  Tom Tromey  <tom@tromey.com>
11367
11368         * inferior.h (class inferior): Update comment.
11369         * gdbthread.h (class thread_info): Update comment.
11370
11371 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11372             Tom Tromey  <tom@tromey.com>
11373
11374         * stabsread.h (struct stab_section_list): Remove.
11375         (coffstab_build_psymtabs): Update.
11376         * dbxread.c (symbuf_sections): Now a std::vector.
11377         (sect_idx): New global.
11378         (fill_symbuf): Update.
11379         (coffstab_build_psymtabs): Change type of stabsects parameter.
11380         Update.
11381         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11382         std::vector.
11383         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11384         (coff_locate_sections): Update.
11385         (coff_symfile_read): Remove cleanups.  Update.
11386         (init_stringtab): Add storage parameter.
11387         (free_stringtab, free_stringtab_cleanup): Remove.
11388         (init_lineno): Add storage parameter.
11389         (free_linetab, free_linetab_cleanup): Remove.
11390
11391 2019-03-06  Pedro Alves  <palves@redhat.com>
11392
11393         * linux-fork.c (fork_info::clobber_regs): Delete.
11394         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11395         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11396         comment.  Adjust.
11397         (scoped_switch_fork_info::scoped_switch_fork_info)
11398         (checkpoint_command, linux_fork_context): Adjust
11399         fork_save_infrun_state calls.
11400
11401 2019-03-06  Pedro Alves  <palves@redhat.com>
11402
11403         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11404         (inf_has_multiple_threads): Return 'bool' and rewrite using
11405         inferior_info::threads().
11406
11407 2019-03-06  Pedro Alves  <palves@redhat.com>
11408
11409         * linux-fork.c: Include <list>.
11410         (fork_list): Now a std::list instance.
11411         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11412         (forks_exist_p, find_last_fork): Adjust.
11413         (new_fork): Delete.
11414         (one_fork_p): New.
11415         (add_fork): Adjust.
11416         (free_fork): Delete, folded into fork_info::~fork_info().
11417         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11418         Adjust.
11419         (init_fork_list): Delete.
11420         (linux_fork_killall, linux_fork_mourn_inferior)
11421         (linux_fork_detach, info_checkpoints_command): Adjust.
11422         (_initialize_linux_fork): No longer call init_fork_list.
11423
11424 2019-03-06  Pedro Alves  <palves@redhat.com>
11425
11426         * linux-fork.c (new_fork): New, split out of ...
11427         (add_fork): ... this.  Return void.  Move "first fork" special
11428         case from here, to ...
11429         (checkpoint_command): ... here.
11430         * linux-linux.h (add_fork): Return void.
11431
11432 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11433
11434         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11435
11436 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11437             Chris January  <chris.january@arm.com>
11438             David Lecomber  <david.lecomber@arm.com>
11439
11440         * f-exp.y: New token, UNOP_INTRINSIC.
11441         (exp): New pattern using UNOP_INTRINSIC token.
11442         (f77_keywords): Add 'abs' keyword.
11443         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11444         (value_from_host_double): New function.
11445         (evaluate_subexp_f): Support UNOP_ABS.
11446
11447 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11448
11449         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11450         types.
11451
11452 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11453
11454         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11455         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11456         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11457
11458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11459
11460         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11461
11462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11463             Chris January  <chris.january@arm.com>
11464
11465         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11466         * f-exp.y: Define 'KIND' token.
11467         (exp): New pattern for KIND expressions.
11468         (ptype): Handle types with a kind extension.
11469         (direct_abs_decl): Extend to spot kind extensions.
11470         (f77_keywords): Add 'kind' to the list.
11471         (push_kind_type): New function.
11472         (convert_to_kind_type): New function.
11473         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11474         * parse.c (operator_length_standard): Likewise.
11475         * parser-defs.h (enum type_pieces): Add tp_kind.
11476         * std-operator.def: Add UNOP_KIND.
11477
11478 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11479
11480         * f-exp.y (f_parse): Set yydebug.
11481
11482 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11483
11484         * f-lang.c (evaluate_subexp_f): New function.
11485         (exp_descriptor_f): New global.
11486         (f_language_defn): Use exp_descriptor_f instead of
11487         exp_descriptor_standard.
11488
11489 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11490
11491         * f-exp.y (struct token): Add comments.
11492         (dot_ops): Remove uppercase versions and the end marker.
11493         (f77_keywords): Likewise.
11494         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11495         entries in the dot_ops array are case insensitive, and use
11496         strncasecmp to compare strings.  Also some whitespace cleanup in
11497         this area.  Similar for the f77_keywords array, except entries in
11498         this list might be case sensitive.
11499
11500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11501
11502         * f-exp.y (struct f77_boolean_val): Add comments.
11503         (boolean_values): Remove uppercase versions, and end marker.
11504         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11505         and use strncasecmp to achieve case insensitivity.  Additionally,
11506         perform whitespace cleanup around this code.
11507
11508 2019-03-06  Tom Tromey  <tromey@adacore.com>
11509
11510         * remote-sim.c (gdbsim_target_open): Use result of
11511         gdb_argv::release.
11512
11513 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11514         Dirk Schubert  <dirk.schubert@arm.com>
11515         Chris January  <chris.january@arm.com>
11516
11517         * eval.c (evaluate_subexp_standard): Call Fortran argument
11518         wrapping logic.
11519         * f-lang.c (struct value): A value which can be passed into a
11520         Fortran function call.
11521         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11522         where appropriate.
11523         (struct type): Value ready for a Fortran function call.
11524         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11525         is needed.
11526         * f-lang.h (fortran_argument_convert): Declaration.
11527         (fortran_preserve_arg_pointer): Declaration.
11528         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11529
11530 2019-03-05  Tom Tromey  <tromey@adacore.com>
11531
11532         * python/py-prettyprint.c (print_string_repr): Remove #if.
11533         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11534
11535 2019-03-05  Tom Tromey  <tromey@adacore.com>
11536
11537         * target.c (the_dummy_target): Move later.  Change type to
11538         "dummy_target".
11539         (initialize_targets): Don't initialize the_dummy_target.
11540
11541 2019-03-05  Tom Tromey  <tromey@adacore.com>
11542
11543         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11544         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11545
11546 2019-03-05  Tom Tromey  <tromey@adacore.com>
11547
11548         * windows-nat.c (windows_nat_target::attach)
11549         (windows_nat_target::detach): Don't call gdb_flush.
11550         * valprint.c (generic_val_print, val_print, val_print_string):
11551         Don't call gdb_flush.
11552         * utils.c (defaulted_query): Don't call gdb_flush.
11553         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11554         * target.c (target_announce_detach): Don't call gdb_flush.
11555         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11556         * remote.c (extended_remote_target::attach): Don't call
11557         gdb_flush.
11558         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11559         * printcmd.c (do_examine): Don't call gdb_flush.
11560         (info_display_command): Don't call gdb_flush.
11561         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11562         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11563         * memattr.c (info_mem_command): Don't call gdb_flush.
11564         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11565         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11566         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11567         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11568         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11569         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11570         (gnu_nat_target::detach): Don't call gdb_flush.
11571         * f-valprint.c (f_val_print): Don't call gdb_flush.
11572         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11573         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11574         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11575         gdb_flush.
11576         * c-valprint.c (c_val_print): Don't call gdb_flush.
11577         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11578
11579 2019-03-05  Tom Tromey  <tromey@adacore.com>
11580
11581         * varobj.c (update_dynamic_varobj_children): Update.
11582         (install_default_visualizer): Use reset, not release.
11583         * value.c (set_internalvar): Update.
11584         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11585         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11586         ATTRIBUTE_UNUSED_RESULT.
11587
11588 2019-03-05  Tom Tromey  <tromey@adacore.com>
11589
11590         * remote.c (class scoped_remote_fd) <release>: Add
11591         ATTRIBUTE_UNUSED_RESULT.
11592
11593 2019-03-05  Tom Tromey  <tromey@adacore.com>
11594
11595         * macroexp.c (struct macro_buffer) <release>: Add
11596         ATTRIBUTE_UNUSED_RESULT.
11597
11598 2019-03-05  Tom Tromey  <tromey@adacore.com>
11599
11600         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11601         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11602         ATTRIBUTE_UNUSED_RESULT.
11603
11604 2019-03-05  Tom Tromey  <tromey@adacore.com>
11605
11606         * common/scoped_fd.h (class scoped_fd) <release>: Add
11607         ATTRIBUTE_UNUSED_RESULT.
11608
11609 2019-03-05  Tom Tromey  <tromey@adacore.com>
11610
11611         * parser-defs.h (struct parser_state) <release>: Add
11612         ATTRIBUTE_UNUSED_RESULT.
11613
11614 2019-03-05  Tom Tromey  <tromey@adacore.com>
11615
11616         * utils.h (class gdb_argv) <release>: Add
11617         ATTRIBUTE_UNUSED_RESULT.
11618         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11619
11620 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11621
11622         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11623         for-loop range, to avoid compiler warnings.
11624
11625         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11626         avoid compiler warnings about unused variables.
11627
11628         * NEWS: Mention end of support for native debugging on MS-Windows
11629         before XP.
11630
11631         PR gdb/24292
11632         * common/netstuff.c:
11633         * gdbserver/gdbreplay.c
11634         * gdbserver/remote-utils.c:
11635         * ser-tcp.c:
11636         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11637         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11638         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11639         'getaddrinfo' and 'freeaddrinfo' were not available before
11640         Windows XP, and mingw.org's MinGW headers by default define
11641         _WIN32_WINNT to 0x500.
11642
11643 2019-03-01  Gary Benson <gbenson@redhat.com>
11644
11645         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11646
11647 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11648             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11649
11650         PR gdb/8527
11651         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11652         set_sigint_trap, clear_sigint_trap.
11653
11654 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11655
11656         * target.c (target_detach): Clear the regcache and the
11657         frame cache.
11658
11659 2019-02-27  Pedro Alves  <palves@redhat.com>
11660
11661         * utils.c (set_screen_size): When we cap the height/width sizes,
11662         tweak the corresponding command variable to show "unlimited":
11663
11664 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11665             Pedro Alves  <palves@redhat.com>
11666
11667         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11668         before calling rl_set_screen_size.
11669
11670 2019-02-27  Tom Tromey  <tromey@adacore.com>
11671
11672         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11673         define.
11674         * python/py-value.c: Remove Python 2.4 workaround.
11675         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11676         workaround.
11677         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11678         Python 2.4 workaround.
11679         * python/python-internal.h: Remove Python 2.4 comment.
11680         (Py_ssize_t): Don't define.
11681         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11682         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11683         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11684         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11685         * python/python.c (do_start_initialization): Remove Python 2.4
11686         workaround.
11687         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11688         (print_children): Remove Python 2.4 workaround.
11689         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11690         workaround.
11691         (CHARBUFFERPROC_NAME): Remove.
11692         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11693         Python 2.4 workaround.
11694
11695 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11696
11697         * NEWS: Note minimum Python version.
11698
11699 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11700
11701         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11702         code from these functions.  Remove corresponding ifdefs.  Use
11703         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11704         Remove gotos and target of gotos.
11705         (infpy_search_memory): Likewise.
11706
11707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11708
11709         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11710         (hppa_gdbarch_init): Don't register deleted functions with
11711         gdbarch.
11712
11713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11714
11715         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11716         (h8300_unwind_sp): Delete.
11717         (h8300_dummy_id): Delete.
11718         (h8300_gdbarch_init): Don't register deleted functions with
11719         gdbarch.
11720
11721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11722
11723         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11724         (ft32_unwind_pc): Delete.
11725         (ft32_unwind_sp): Delete.
11726         (ft32_gdbarch_init): Don't register deleted functions with
11727         gdbarch.
11728
11729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11730
11731         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11732         (frv_unwind_pc): Delete.
11733         (frv_unwind_sp): Delete.
11734         (frv_gdbarch_init): Don't register deleted functions with
11735         gdbarch.
11736
11737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11738
11739         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11740         (riscv_unwind_pc): Delete.
11741         (riscv_unwind_sp): Delete.
11742         (riscv_gdbarch_init): Don't register deleted functions with
11743         gdbarch.
11744
11745 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11746
11747         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11748         (csky_unwind_pc): Delete.
11749         (csky_unwind_sp): Delete.
11750         (csky_gdbarch_init): Don't register deleted functions with
11751         gdbarch.
11752
11753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11754
11755         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11756         (cris_unwind_pc): Delete.
11757         (cris_unwind_sp): Delete.
11758         (cris_gdbarch_init): Don't register deleted functions with
11759         gdbarch.
11760
11761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11762
11763         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11764         (bfin_unwind_pc): Delete.
11765         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11766
11767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11768
11769         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11770         (arm_unwind_pc): Delete.
11771         (arm_unwind_sp): Delete.
11772         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11773
11774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11775
11776         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11777         (arc_unwind_pc): Delete.
11778         (arc_unwind_sp): Delete.
11779         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11780
11781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11782
11783         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11784         (alpha_unwind_pc): Delete.
11785         (alpha_gdbarch_init): Don't register deleted functions with
11786         gdbarch.
11787
11788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11789
11790         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11791         (aarch64_unwind_pc): Delete.
11792         (aarch64_unwind_sp): Delete.
11793         (aarch64_gdbarch_init): Don't register deleted functions with
11794         gdbarch.
11795
11796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11797
11798         * gdbtypes.c (type_align): Don't consider static members when
11799         computing structure alignment.
11800
11801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11802
11803         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11804         return 0 for other types.
11805         * arch-utils.c (default_type_align): Always return 0.
11806         * gdbarch.h: Regenerate.
11807         * gdbarch.sh (type_align): Extend comment.
11808         * gdbtypes.c (type_align): Add additional comments, always call
11809         gdbarch_type_align before applying the default rules.
11810         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11811         generic code will then apply a suitable default.
11812         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11813         types, return 0 for other types.
11814
11815 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11816
11817         * NEWS: Create a new section for the next release branch.
11818         Rename the section of the current branch, now that it has
11819         been cut.
11820
11821 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11822
11823         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11824         * version.in: Bump version to 8.3.50.DATE-git.
11825
11826 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11827
11828         * aix-thread.c (ptid_cmp): Remove unused variable.
11829         (get_signaled_thread): Likewise.
11830         (store_regs_user_thread): Likewise.
11831         (store_regs_kernel_thread): Likewise.
11832         (fetch_regs_kernel_thread): Remove shadowed variable.
11833
11834 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11835
11836         * features/riscv/32bit-cpu.xml: Add register numbers.
11837         * features/riscv/32bit-fpu.c: Regenerate.
11838         * features/riscv/32bit-fpu.xml: Add register numbers.
11839         * features/riscv/64bit-cpu.xml: Add register numbers.
11840         * features/riscv/64bit-fpu.c: Regenerate.
11841         * features/riscv/64bit-fpu.xml: Add register numbers.
11842
11843 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11844
11845         * NEWS: Mention two argument form of gdb.Value constructor.
11846         * python/py-value.c (convert_buffer_and_type_to_value): New
11847         function.
11848         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11849         Add support for handling an optional second argument.  Call
11850         convert_buffer_and_type_to_value as appropriate.
11851         * python/python-internal.h (Py_buffer_deleter): New struct.
11852         (Py_buffer_up): New typedef.
11853
11854 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11855
11856         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11857         instead of releasing ownership.
11858
11859 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11860
11861         * dwarf2read.c (open_and_init_dwp_file): Call
11862         elf_numsections instead of bfd_count_sections to initialize
11863         dwp_file->num_sections.
11864
11865 2019-02-25  Tom Tromey  <tromey@adacore.com>
11866
11867         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11868
11869 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11870
11871         * gcore.in: Add '--readnever' option when invoking GDB.
11872
11873 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11874
11875         * MAINTAINERS: Update my email address.
11876
11877 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11878
11879         * build-id.c (build_id_to_debug_bfd_1): New function.
11880         (build_id_to_debug_bfd): Look for separate debug file in
11881         sysroot.
11882
11883 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11884
11885         * gdbarch.sh: Update the copyright year range that is placed into
11886         generated files.
11887
11888 2019-02-22  Keith Seitz  <keiths@redhat.com>
11889
11890         PR symtab/23853
11891         * linespec.c (create_sals_line_offset): Search for the default
11892         symtab's filename instead of its fullname.
11893
11894 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11895
11896         * NEWS: Update style defaults.
11897
11898 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11899
11900         * main.c (captured_main_1): Disable styling in batch mode.
11901
11902 2019-02-20  Tom Tromey  <tom@tromey.com>
11903
11904         * symtab.c (symtab_symbol_info): Fix typos.
11905
11906 2019-02-20  Tom Tromey  <tromey@adacore.com>
11907
11908         * findcmd.c (_initialize_mem_search): Use upper case for
11909         metasyntactic variables.
11910
11911 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11912
11913         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11914         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11915
11916 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11917
11918         * top.h (source_file_name): Change to std::string.
11919         * top.c (source_file_name): Likewise.
11920         (command_line_input): Adjust.
11921         * cli/cli-script.c (script_from_file): Adjust.
11922
11923 2019-02-19  Tom Tromey  <tromey@adacore.com>
11924
11925         * ravenscar-thread.c
11926         (ravenscar_thread_target::update_thread_list): Don't call
11927         ada_build_task_list.
11928         * ada-lang.h (ada_build_task_list): Don't declare.
11929         * ada-tasks.c (struct ada_tasks_inferior_data)
11930         <task_list_valid_p>: Now bool.
11931         (read_known_tasks, ada_task_list_changed)
11932         (ada_tasks_invalidate_inferior_data): Update.
11933         (read_known_tasks_array): Return bool.
11934         (read_known_tasks_list): Likewise.
11935         (read_known_tasks): Return void.
11936         (ada_build_task_list): Now static.
11937
11938 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11939
11940         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11941         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11942
11943 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11944
11945         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11946         variant for ada_tasks_pspace_data_handle and
11947         ada_tasks_inferior_data_handle.
11948         (ada_tasks_pspace_data_cleanup): New function.
11949         (ada_tasks_inferior_data_cleanup): New function.
11950
11951 2019-02-17  Tom Tromey  <tom@tromey.com>
11952
11953         * macrotab.h (macro_source_fullname): Return a std::string.
11954         * macrotab.c (macro_include, check_for_redefinition)
11955         (macro_undef, macro_lookup_definition, foreach_macro)
11956         (foreach_macro_in_scope): Update.
11957         (macro_source_fullname): Return a std::string.
11958         * macrocmd.c (show_pp_source_pos): Update.
11959
11960 2019-02-17  Tom Tromey  <tom@tromey.com>
11961
11962         * macrocmd.c (show_pp_source_pos): Style the file names.
11963
11964 2019-02-17  Tom Tromey  <tom@tromey.com>
11965
11966         PR tui/24197:
11967         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11968
11969 2019-02-17  Tom Tromey  <tom@tromey.com>
11970
11971         * ada-lang.c (user_select_syms): Use filtered printing.
11972         * utils.c (wrap_style): New global.
11973         (desired_style): Remove.
11974         (emit_style_escape): Add stream parameter.
11975         (set_output_style, reset_terminal_style, prompt_for_continue):
11976         Update.
11977         (flush_wrap_buffer): Only flush gdb_stdout.
11978         (wrap_here): Set wrap_style.
11979         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11980         treat escape sequences as a character.  Change when wrap buffer is
11981         flushed.
11982         (fputs_styled): Do not set the output style when the default is
11983         requested.
11984         * ui-style.h (struct ui_file_style) <is_default>: New method.
11985         * source.c (print_source_lines_base): Emit escape sequences in one
11986         piece.
11987
11988 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11989
11990         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11991         integers and enumeration types.
11992
11993 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11994
11995         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11996         instead of lookup_symbol_in_language
11997         (do_exact_match): New function.
11998         (ada_get_symbol_name_matcher): Return do_exact_match when
11999         doing a verbatim match.
12000
12001 2019-02-15  Tom Tromey  <tromey@adacore.com>
12002
12003         * ravenscar-thread.c (ravenscar_thread_target::resume)
12004         (ravenscar_thread_target::wait): Special case wildcard requests.
12005
12006 2019-02-15  Tom Tromey  <tromey@adacore.com>
12007
12008         * ravenscar-thread.c (base_ptid): Remove.
12009         (struct ravenscar_thread_target) <close>: New method.
12010         <m_base_ptid>: New member.
12011         <update_inferior_ptid, active_task, task_is_currently_active,
12012         runtime_initialized>: Declare methods.
12013         <ravenscar_thread_target>: Add constructor.
12014         (ravenscar_thread_target::task_is_currently_active)
12015         (ravenscar_thread_target::update_inferior_ptid)
12016         (ravenscar_runtime_initialized): Rename.  Now methods.
12017         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12018         (ravenscar_thread_target::update_thread_list): Update.
12019         (ravenscar_thread_target::active_task): Now method.
12020         (ravenscar_thread_target::store_registers)
12021         (ravenscar_thread_target::prepare_to_store)
12022         (ravenscar_thread_target::prepare_to_store)
12023         (ravenscar_thread_target::mourn_inferior): Update.
12024         (ravenscar_inferior_created): Use "new" to create target.
12025         (ravenscar_thread_target::get_ada_task_ptid): Update.
12026         (_initialize_ravenscar): Don't initialize base_ptid.
12027         (ravenscar_ops): Remove global.
12028
12029 2019-02-15  Tom Tromey  <tromey@adacore.com>
12030
12031         * target.h (push_target): Declare new overload.
12032         * target.c (push_target): New overload, taking an rvalue reference.
12033         * remote.c (remote_target::open_1): Use push_target overload.
12034         * corelow.c (core_target_open): Use push_target overload.
12035
12036 2019-02-15  Tom Tromey  <tromey@adacore.com>
12037
12038         * ravenscar-thread.c (is_ravenscar_task)
12039         (ravenscar_task_is_currently_active): Return bool.
12040         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12041         (_initialize_ravenscar): Remove "(void)".
12042         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12043         Return bool.
12044
12045 2019-02-15  Tom Tromey  <tromey@adacore.com>
12046
12047         * ravenscar-thread.c (ravenscar_runtime_initializer)
12048         (has_ravenscar_runtime, get_running_thread_id)
12049         (ravenscar_thread_target::resume): Fix indentation.
12050
12051 2019-02-15  Tom Tromey  <tromey@adacore.com>
12052
12053         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12054         from ravenscar_arch_ops.
12055         (sparc_ravenscar_ops::fetch_registers)
12056         (sparc_ravenscar_ops::store_registers): Now methods.
12057         (sparc_ravenscar_prepare_to_store): Remove.
12058         (sparc_ravenscar_ops): Redefine.
12059         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12060         methods and destructor.  Remove members.
12061         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12062         (ravenscar_thread_target::store_registers)
12063         (ravenscar_thread_target::prepare_to_store): Update.
12064         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12065         Remove.
12066         (struct ppc_ravenscar_powerpc_ops): Derive from
12067         ravenscar_arch_ops.
12068         (ppc_ravenscar_powerpc_ops::fetch_registers)
12069         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12070         (ppc_ravenscar_powerpc_ops): Redefine.
12071         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12072         (ppc_ravenscar_e500_ops::fetch_registers)
12073         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12074         (ppc_ravenscar_e500_ops): Redefine.
12075         * aarch64-ravenscar-thread.c
12076         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12077         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12078         (aarch64_ravenscar_fetch_registers)
12079         (aarch64_ravenscar_store_registers): Now methods.
12080         (aarch64_ravenscar_ops): Redefine.
12081
12082 2019-02-15  Tom Tromey  <tromey@adacore.com>
12083
12084         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12085         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12086         (ravenscar_thread_target::stopped_by_watchpoint)
12087         (ravenscar_thread_target::stopped_data_address)
12088         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12089
12090 2019-02-15  Tom Tromey  <tromey@adacore.com>
12091
12092         * ravenscar-thread.c: Fix some typos.
12093
12094 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12095             Tom Tromey  <tromey@adacore.com>
12096
12097         * ada-lang.c (ada_exception_sal): Change addr_string to a
12098         std::string.
12099         (create_ada_exception_catchpoint): Update.
12100
12101 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12102             Tom Tromey  <tromey@adacore.com>
12103
12104         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12105         (bp_location_ops): Remove.
12106         (base_breakpoint_allocate_location): Update.
12107         (free_bp_location): Update.
12108         * ada-lang.c (class ada_catchpoint_location)
12109         <ada_catchpoint_location>: Remove ops parameter.
12110         (ada_catchpoint_location_dtor): Remove.
12111         (ada_catchpoint_location_ops): Remove.
12112         (allocate_location_exception): Update.
12113         * breakpoint.h (struct bp_location_ops): Remove.
12114         (class bp_location) <bp_location>: Remove bp_location_ops
12115         parameter.
12116         <~bp_location>: Add destructor.
12117         <ops>: Remove.
12118
12119 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12120             Pedro Alves  <palves@redhat.com>
12121
12122         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12123         'PATH_MAX'.
12124
12125 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12126             Samuel Thibault  <samuel.thibault@gnu.org>
12127             Thomas Schwinge  <thomas@codesourcery.com>
12128
12129         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12130         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12131
12132 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12133
12134         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12135         (check_empty): Use "const char *".
12136
12137         * gnu-nat.c (gnu_nat_target::detach): Instead of
12138         'detach_inferior (pid)' call
12139         'detach_inferior (find_inferior_pid (pid))'.
12140
12141         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12142         'nat/fork-inferior.o'.
12143         * gnu-nat.c: #include "nat/fork-inferior.h".
12144
12145         * gnu-nat.c (gnu_nat_target::detach): Instead of
12146         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12147         * gnu-nat.h: #include "inf-child.h".
12148         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12149         'i386_gnu_nat_target::fetch_registers'.
12150         (gnu_store_registers): Rename/move to
12151         'i386_gnu_nat_target::store_registers'.
12152
12153         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12154         * gnu-nat.h (mach_thread_info): New function.
12155         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12156
12157         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12158
12159 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12160
12161         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12162
12163 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12164
12165         * windows-nat.c (windows_add_thread): Add new parameter
12166         "main_thread_p" with default value set to false.  Update
12167         function documentation as well as all callers.
12168         (windows_delete_thread): Likewise.
12169         (fake_create_process): Update call to windows_add_thread.
12170         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12171         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12172         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12173         call to windows_delete_thread.
12174
12175 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12176
12177         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12178
12179 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12180
12181         * symfile.c (find_separate_debug_file): Use canonical path of
12182         sysroot with child_path instead of gdb_sysroot if it is valid.
12183
12184 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12185
12186         * symfile.c (find_separate_debug_file): Use child_path to
12187         determine if an object file is under a sysroot.
12188
12189 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12190
12191         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12192         unittests/child-path-selftests.c.
12193         * common/pathstuff.c (child_path): New function.
12194         * common/pathstuff.h (child_path): New prototype.
12195         * unittests/child-path-selftests.c: New file.
12196
12197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12198
12199         * symfile.c (find_separate_debug_file): Look for separate debug
12200         files in debug directories under the sysroot.
12201
12202 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12203
12204         * symtab.h (struct minimal_symbol data_p): New const method.
12205         (struct minimal_symbol text_p): Likewise.
12206         * symtab.c (output_source_filename): Use file name style
12207         to print file name.
12208         (print_symbol_info): Likewise.
12209         (print_msymbol_info): Use address style to print addresses.
12210         Use function name style to print executable text symbols.
12211         (expand_symtab_containing_pc): Use data_p.
12212         (find_pc_sect_compunit_symtab): Likewise.
12213
12214 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12215
12216         * breakpoint.c (describe_other_breakpoints): Use address style
12217         to print addresses.
12218         (say_where): Likewise.
12219
12220 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12221
12222         * ada-typeprint.c (print_func_type): Print function name
12223         style to print function name.
12224         * c-typeprint.c (c_print_type_1): Likewise.
12225
12226 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12227
12228         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12229         for execve.
12230
12231 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12232
12233         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12234         type_stack.
12235
12236 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12237
12238         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12239         TYPE_CODE_REF types.
12240
12241 2019-02-08  Jim Wilson  <jimw@sifive.com>
12242
12243         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12244         (riscv_linux_fregset): New.
12245         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12246
12247 2019-02-07  Tom Tromey  <tom@tromey.com>
12248
12249         * thread.c (thread_cancel_execution_command): Update.
12250         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12251         methods.
12252         (struct thread_fsm_ops): Remove.
12253         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12254         (thread_fsm_should_stop, thread_fsm_return_value)
12255         (thread_fsm_set_finished, thread_fsm_finished_p)
12256         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12257         Don't declare.
12258         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12259         * infrun.c (clear_proceed_status_thread)
12260         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12261         (print_stop_event): Update.
12262         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12263         Add constructor.
12264         (step_command_fsm_ops): Remove.
12265         (new_step_command_fsm): Remove.
12266         (step_1): Update.
12267         (step_command_fsm::should_stop): Rename from
12268         step_command_fsm_should_stop.
12269         (step_command_fsm::clean_up): Rename from
12270         step_command_fsm_clean_up.
12271         (step_command_fsm::do_async_reply_reason): Rename from
12272         step_command_fsm_async_reply_reason.
12273         (struct until_next_fsm): Inherit from thread_fsm.  Add
12274         constructor.
12275         (until_next_fsm_ops): Remove.
12276         (new_until_next_fsm): Remove.
12277         (until_next_fsm::should_stop): Rename from
12278         until_next_fsm_should_stop.
12279         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12280         (until_next_fsm::do_async_reply_reason): Rename from
12281         until_next_fsm_async_reply_reason.
12282         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12283         constructor.  Change type of breakpoint.
12284         (finish_command_fsm_ops): Remove.
12285         (new_finish_command_fsm): Remove.
12286         (finish_command_fsm::should_stop): Rename from
12287         finish_command_fsm_should_stop.
12288         (finish_command_fsm::clean_up): Rename from
12289         finish_command_fsm_clean_up.
12290         (finish_command_fsm::return_value): Rename from
12291         finish_command_fsm_return_value.
12292         (finish_command_fsm::do_async_reply_reason): Rename from
12293         finish_command_fsm_async_reply_reason.
12294         (finish_command): Update.
12295         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12296         Add constructor.
12297         (call_thread_fsm_ops): Remove.
12298         (call_thread_fsm::call_thread_fsm): Rename from
12299         new_call_thread_fsm.
12300         (call_thread_fsm::should_stop): Rename from
12301         call_thread_fsm_should_stop.
12302         (call_thread_fsm::should_notify_stop): Rename from
12303         call_thread_fsm_should_notify_stop.
12304         (run_inferior_call, call_function_by_hand_dummy): Update.
12305         * cli/cli-interp.c (should_print_stop_to_console): Update.
12306         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12307         Add constructor.  Change type of location_breakpoint,
12308         caller_breakpoint.
12309         (until_break_fsm_ops): Remove.
12310         (new_until_break_fsm): Remove.
12311         (until_break_fsm::should_stop): Rename from
12312         until_break_fsm_should_stop.
12313         (until_break_fsm::clean_up): Rename from
12314         until_break_fsm_clean_up.
12315         (until_break_fsm::do_async_reply_reason): Rename from
12316         until_break_fsm_async_reply_reason.
12317         (until_break_command): Update.
12318         * thread-fsm.c: Remove.
12319         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12320
12321 2019-02-07  Tom Tromey  <tom@tromey.com>
12322
12323         * yy-remap.h: Add include guard.
12324         * xtensa-tdep.h: Add include guard.
12325         * xcoffread.h: Rename include guard.
12326         * varobj-iter.h: Add include guard.
12327         * tui/tui.h: Rename include guard.
12328         * tui/tui-winsource.h: Rename include guard.
12329         * tui/tui-wingeneral.h: Rename include guard.
12330         * tui/tui-windata.h: Rename include guard.
12331         * tui/tui-win.h: Rename include guard.
12332         * tui/tui-stack.h: Rename include guard.
12333         * tui/tui-source.h: Rename include guard.
12334         * tui/tui-regs.h: Rename include guard.
12335         * tui/tui-out.h: Rename include guard.
12336         * tui/tui-layout.h: Rename include guard.
12337         * tui/tui-io.h: Rename include guard.
12338         * tui/tui-hooks.h: Rename include guard.
12339         * tui/tui-file.h: Rename include guard.
12340         * tui/tui-disasm.h: Rename include guard.
12341         * tui/tui-data.h: Rename include guard.
12342         * tui/tui-command.h: Rename include guard.
12343         * tic6x-tdep.h: Add include guard.
12344         * target/waitstatus.h: Rename include guard.
12345         * target/wait.h: Rename include guard.
12346         * target/target.h: Rename include guard.
12347         * target/resume.h: Rename include guard.
12348         * target-float.h: Rename include guard.
12349         * stabsread.h: Add include guard.
12350         * rs6000-tdep.h: Add include guard.
12351         * riscv-fbsd-tdep.h: Add include guard.
12352         * regformats/regdef.h: Rename include guard.
12353         * record.h: Rename include guard.
12354         * python/python.h: Rename include guard.
12355         * python/python-internal.h: Rename include guard.
12356         * python/py-stopevent.h: Rename include guard.
12357         * python/py-ref.h: Rename include guard.
12358         * python/py-record.h: Rename include guard.
12359         * python/py-record-full.h: Rename include guard.
12360         * python/py-record-btrace.h: Rename include guard.
12361         * python/py-instruction.h: Rename include guard.
12362         * python/py-events.h: Rename include guard.
12363         * python/py-event.h: Rename include guard.
12364         * procfs.h: Add include guard.
12365         * proc-utils.h: Add include guard.
12366         * p-lang.h: Add include guard.
12367         * or1k-tdep.h: Rename include guard.
12368         * observable.h: Rename include guard.
12369         * nto-tdep.h: Rename include guard.
12370         * nat/x86-linux.h: Rename include guard.
12371         * nat/x86-linux-dregs.h: Rename include guard.
12372         * nat/x86-gcc-cpuid.h: Add include guard.
12373         * nat/x86-dregs.h: Rename include guard.
12374         * nat/x86-cpuid.h: Rename include guard.
12375         * nat/ppc-linux.h: Rename include guard.
12376         * nat/mips-linux-watch.h: Rename include guard.
12377         * nat/linux-waitpid.h: Rename include guard.
12378         * nat/linux-ptrace.h: Rename include guard.
12379         * nat/linux-procfs.h: Rename include guard.
12380         * nat/linux-osdata.h: Rename include guard.
12381         * nat/linux-nat.h: Rename include guard.
12382         * nat/linux-namespaces.h: Rename include guard.
12383         * nat/linux-btrace.h: Rename include guard.
12384         * nat/glibc_thread_db.h: Rename include guard.
12385         * nat/gdb_thread_db.h: Rename include guard.
12386         * nat/gdb_ptrace.h: Rename include guard.
12387         * nat/fork-inferior.h: Rename include guard.
12388         * nat/amd64-linux-siginfo.h: Rename include guard.
12389         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12390         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12391         * nat/aarch64-linux.h: Rename include guard.
12392         * nat/aarch64-linux-hw-point.h: Rename include guard.
12393         * mn10300-tdep.h: Add include guard.
12394         * mips-linux-tdep.h: Add include guard.
12395         * mi/mi-parse.h: Rename include guard.
12396         * mi/mi-out.h: Rename include guard.
12397         * mi/mi-main.h: Rename include guard.
12398         * mi/mi-interp.h: Rename include guard.
12399         * mi/mi-getopt.h: Rename include guard.
12400         * mi/mi-console.h: Rename include guard.
12401         * mi/mi-common.h: Rename include guard.
12402         * mi/mi-cmds.h: Rename include guard.
12403         * mi/mi-cmd-break.h: Rename include guard.
12404         * m2-lang.h: Add include guard.
12405         * location.h: Rename include guard.
12406         * linux-record.h: Rename include guard.
12407         * linux-nat.h: Add include guard.
12408         * linux-fork.h: Add include guard.
12409         * i386-darwin-tdep.h: Rename include guard.
12410         * hppa-linux-offsets.h: Add include guard.
12411         * guile/guile.h: Rename include guard.
12412         * guile/guile-internal.h: Rename include guard.
12413         * gnu-nat.h: Rename include guard.
12414         * gdb-stabs.h: Rename include guard.
12415         * frv-tdep.h: Add include guard.
12416         * f-lang.h: Add include guard.
12417         * event-loop.h: Add include guard.
12418         * darwin-nat.h: Rename include guard.
12419         * cp-abi.h: Rename include guard.
12420         * config/sparc/nm-sol2.h: Rename include guard.
12421         * config/nm-nto.h: Rename include guard.
12422         * config/nm-linux.h: Add include guard.
12423         * config/i386/nm-i386gnu.h: Rename include guard.
12424         * config/djgpp/nl_types.h: Rename include guard.
12425         * config/djgpp/langinfo.h: Rename include guard.
12426         * compile/gcc-cp-plugin.h: Add include guard.
12427         * compile/gcc-c-plugin.h: Add include guard.
12428         * compile/compile.h: Rename include guard.
12429         * compile/compile-object-run.h: Rename include guard.
12430         * compile/compile-object-load.h: Rename include guard.
12431         * compile/compile-internal.h: Rename include guard.
12432         * compile/compile-cplus.h: Rename include guard.
12433         * compile/compile-c.h: Rename include guard.
12434         * common/xml-utils.h: Rename include guard.
12435         * common/x86-xstate.h: Rename include guard.
12436         * common/version.h: Rename include guard.
12437         * common/vec.h: Rename include guard.
12438         * common/tdesc.h: Rename include guard.
12439         * common/selftest.h: Rename include guard.
12440         * common/scoped_restore.h: Rename include guard.
12441         * common/scoped_mmap.h: Rename include guard.
12442         * common/scoped_fd.h: Rename include guard.
12443         * common/safe-iterator.h: Rename include guard.
12444         * common/run-time-clock.h: Rename include guard.
12445         * common/refcounted-object.h: Rename include guard.
12446         * common/queue.h: Rename include guard.
12447         * common/ptid.h: Rename include guard.
12448         * common/print-utils.h: Rename include guard.
12449         * common/preprocessor.h: Rename include guard.
12450         * common/pathstuff.h: Rename include guard.
12451         * common/observable.h: Rename include guard.
12452         * common/netstuff.h: Rename include guard.
12453         * common/job-control.h: Rename include guard.
12454         * common/host-defs.h: Rename include guard.
12455         * common/gdb_wait.h: Rename include guard.
12456         * common/gdb_vecs.h: Rename include guard.
12457         * common/gdb_unlinker.h: Rename include guard.
12458         * common/gdb_unique_ptr.h: Rename include guard.
12459         * common/gdb_tilde_expand.h: Rename include guard.
12460         * common/gdb_sys_time.h: Rename include guard.
12461         * common/gdb_string_view.h: Rename include guard.
12462         * common/gdb_splay_tree.h: Rename include guard.
12463         * common/gdb_setjmp.h: Rename include guard.
12464         * common/gdb_ref_ptr.h: Rename include guard.
12465         * common/gdb_optional.h: Rename include guard.
12466         * common/gdb_locale.h: Rename include guard.
12467         * common/gdb_assert.h: Rename include guard.
12468         * common/filtered-iterator.h: Rename include guard.
12469         * common/filestuff.h: Rename include guard.
12470         * common/fileio.h: Rename include guard.
12471         * common/environ.h: Rename include guard.
12472         * common/common-utils.h: Rename include guard.
12473         * common/common-types.h: Rename include guard.
12474         * common/common-regcache.h: Rename include guard.
12475         * common/common-inferior.h: Rename include guard.
12476         * common/common-gdbthread.h: Rename include guard.
12477         * common/common-exceptions.h: Rename include guard.
12478         * common/common-defs.h: Rename include guard.
12479         * common/common-debug.h: Rename include guard.
12480         * common/cleanups.h: Rename include guard.
12481         * common/buffer.h: Rename include guard.
12482         * common/btrace-common.h: Rename include guard.
12483         * common/break-common.h: Rename include guard.
12484         * cli/cli-utils.h: Rename include guard.
12485         * cli/cli-style.h: Rename include guard.
12486         * cli/cli-setshow.h: Rename include guard.
12487         * cli/cli-script.h: Rename include guard.
12488         * cli/cli-interp.h: Rename include guard.
12489         * cli/cli-decode.h: Rename include guard.
12490         * cli/cli-cmds.h: Rename include guard.
12491         * charset-list.h: Add include guard.
12492         * buildsym-legacy.h: Rename include guard.
12493         * bfin-tdep.h: Add include guard.
12494         * ax.h: Rename include guard.
12495         * arm-linux-tdep.h: Add include guard.
12496         * arm-fbsd-tdep.h: Add include guard.
12497         * arch/xtensa.h: Rename include guard.
12498         * arch/tic6x.h: Add include guard.
12499         * arch/i386.h: Add include guard.
12500         * arch/arm.h: Rename include guard.
12501         * arch/arm-linux.h: Rename include guard.
12502         * arch/arm-get-next-pcs.h: Rename include guard.
12503         * arch/amd64.h: Add include guard.
12504         * arch/aarch64-insn.h: Rename include guard.
12505         * arch-utils.h: Rename include guard.
12506         * annotate.h: Add include guard.
12507         * amd64-darwin-tdep.h: Rename include guard.
12508         * aarch64-linux-tdep.h: Add include guard.
12509         * aarch64-fbsd-tdep.h: Add include guard.
12510         * aarch32-linux-nat.h: Add include guard.
12511
12512 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12513
12514         * macrotab.c (macro_define_internal): New function that
12515         factorizes macro_define_object_internal and macro_define_function
12516         code.
12517         (macro_define_object_internal): Use macro_define_internal.
12518         (macro_define_function): Likewise.
12519
12520 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12521
12522         * macrocmd.c (extract_identifier): Return
12523         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12524         callers.
12525
12526 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12527
12528         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12529
12530 2019-02-05  Tom Tromey  <tom@tromey.com>
12531
12532         * target.c (target_stack::unpush): Move assertion earlier.
12533
12534 2019-01-30  Tom Tromey  <tom@tromey.com>
12535
12536         PR python/23615:
12537         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12538         (gdbpy_parse_and_eval): Likewise.
12539         * python/python-internal.h (gdbpy_allow_threads): New class.
12540
12541 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12542
12543         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12544         (aarch64_fbsd_fpregmap): Move earlier.
12545         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12546         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12547         instead of individual calls to trad_frame_set_reg_addr.
12548         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12549         earlier.
12550         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12551         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12552         instead of individual calls to trad_frame_set_reg_addr.
12553
12554 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12555
12556         * CONTRIBUTE: Replace contribution list with wiki link.
12557
12558 2019-01-25  Tom Tromey  <tom@tromey.com>
12559
12560         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12561
12562 2019-01-25  Tom Tromey  <tom@tromey.com>
12563
12564         * xtensa-linux-nat.c: Fix common/ includes.
12565         * xml-support.h: Fix common/ includes.
12566         * xml-support.c: Fix common/ includes.
12567         * x86-linux-nat.c: Fix common/ includes.
12568         * windows-nat.c: Fix common/ includes.
12569         * varobj.h: Fix common/ includes.
12570         * varobj.c: Fix common/ includes.
12571         * value.c: Fix common/ includes.
12572         * valops.c: Fix common/ includes.
12573         * utils.c: Fix common/ includes.
12574         * unittests/xml-utils-selftests.c: Fix common/ includes.
12575         * unittests/utils-selftests.c: Fix common/ includes.
12576         * unittests/unpack-selftests.c: Fix common/ includes.
12577         * unittests/tracepoint-selftests.c: Fix common/ includes.
12578         * unittests/style-selftests.c: Fix common/ includes.
12579         * unittests/string_view-selftests.c: Fix common/ includes.
12580         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12581         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12582         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12583         * unittests/rsp-low-selftests.c: Fix common/ includes.
12584         * unittests/parse-connection-spec-selftests.c: Fix common/
12585         includes.
12586         * unittests/optional-selftests.c: Fix common/ includes.
12587         * unittests/offset-type-selftests.c: Fix common/ includes.
12588         * unittests/observable-selftests.c: Fix common/ includes.
12589         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12590         * unittests/memrange-selftests.c: Fix common/ includes.
12591         * unittests/memory-map-selftests.c: Fix common/ includes.
12592         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12593         * unittests/function-view-selftests.c: Fix common/ includes.
12594         * unittests/environ-selftests.c: Fix common/ includes.
12595         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12596         * unittests/common-utils-selftests.c: Fix common/ includes.
12597         * unittests/cli-utils-selftests.c: Fix common/ includes.
12598         * unittests/array-view-selftests.c: Fix common/ includes.
12599         * ui-file.c: Fix common/ includes.
12600         * tui/tui-io.c: Fix common/ includes.
12601         * tracepoint.h: Fix common/ includes.
12602         * tracepoint.c: Fix common/ includes.
12603         * tracefile-tfile.c: Fix common/ includes.
12604         * top.h: Fix common/ includes.
12605         * top.c: Fix common/ includes.
12606         * thread.c: Fix common/ includes.
12607         * target/waitstatus.h: Fix common/ includes.
12608         * target/waitstatus.c: Fix common/ includes.
12609         * target.h: Fix common/ includes.
12610         * target.c: Fix common/ includes.
12611         * target-memory.c: Fix common/ includes.
12612         * target-descriptions.c: Fix common/ includes.
12613         * symtab.h: Fix common/ includes.
12614         * symfile.c: Fix common/ includes.
12615         * stap-probe.c: Fix common/ includes.
12616         * spu-linux-nat.c: Fix common/ includes.
12617         * sparc-nat.c: Fix common/ includes.
12618         * source.c: Fix common/ includes.
12619         * solib.c: Fix common/ includes.
12620         * solib-target.c: Fix common/ includes.
12621         * ser-unix.c: Fix common/ includes.
12622         * ser-tcp.c: Fix common/ includes.
12623         * ser-pipe.c: Fix common/ includes.
12624         * ser-base.c: Fix common/ includes.
12625         * selftest-arch.c: Fix common/ includes.
12626         * s12z-tdep.c: Fix common/ includes.
12627         * rust-exp.y: Fix common/ includes.
12628         * rs6000-aix-tdep.c: Fix common/ includes.
12629         * riscv-tdep.c: Fix common/ includes.
12630         * remote.c: Fix common/ includes.
12631         * remote-notif.h: Fix common/ includes.
12632         * remote-fileio.h: Fix common/ includes.
12633         * remote-fileio.c: Fix common/ includes.
12634         * regcache.h: Fix common/ includes.
12635         * regcache.c: Fix common/ includes.
12636         * record-btrace.c: Fix common/ includes.
12637         * python/python.c: Fix common/ includes.
12638         * python/py-type.c: Fix common/ includes.
12639         * python/py-inferior.c: Fix common/ includes.
12640         * progspace.h: Fix common/ includes.
12641         * producer.c: Fix common/ includes.
12642         * procfs.c: Fix common/ includes.
12643         * proc-api.c: Fix common/ includes.
12644         * printcmd.c: Fix common/ includes.
12645         * ppc-linux-nat.c: Fix common/ includes.
12646         * parser-defs.h: Fix common/ includes.
12647         * osdata.c: Fix common/ includes.
12648         * obsd-nat.c: Fix common/ includes.
12649         * nat/x86-linux.c: Fix common/ includes.
12650         * nat/x86-linux-dregs.c: Fix common/ includes.
12651         * nat/x86-dregs.h: Fix common/ includes.
12652         * nat/x86-dregs.c: Fix common/ includes.
12653         * nat/ppc-linux.c: Fix common/ includes.
12654         * nat/mips-linux-watch.h: Fix common/ includes.
12655         * nat/mips-linux-watch.c: Fix common/ includes.
12656         * nat/linux-waitpid.c: Fix common/ includes.
12657         * nat/linux-ptrace.h: Fix common/ includes.
12658         * nat/linux-ptrace.c: Fix common/ includes.
12659         * nat/linux-procfs.c: Fix common/ includes.
12660         * nat/linux-personality.c: Fix common/ includes.
12661         * nat/linux-osdata.c: Fix common/ includes.
12662         * nat/linux-namespaces.c: Fix common/ includes.
12663         * nat/linux-btrace.h: Fix common/ includes.
12664         * nat/linux-btrace.c: Fix common/ includes.
12665         * nat/fork-inferior.c: Fix common/ includes.
12666         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12667         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12668         * nat/aarch64-linux.c: Fix common/ includes.
12669         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12670         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12671         * namespace.h: Fix common/ includes.
12672         * mips-linux-tdep.c: Fix common/ includes.
12673         * minsyms.c: Fix common/ includes.
12674         * mi/mi-parse.h: Fix common/ includes.
12675         * mi/mi-main.c: Fix common/ includes.
12676         * mi/mi-cmd-env.c: Fix common/ includes.
12677         * memrange.h: Fix common/ includes.
12678         * memattr.c: Fix common/ includes.
12679         * maint.h: Fix common/ includes.
12680         * maint.c: Fix common/ includes.
12681         * main.c: Fix common/ includes.
12682         * machoread.c: Fix common/ includes.
12683         * location.c: Fix common/ includes.
12684         * linux-thread-db.c: Fix common/ includes.
12685         * linux-nat.c: Fix common/ includes.
12686         * linux-fork.c: Fix common/ includes.
12687         * inline-frame.c: Fix common/ includes.
12688         * infrun.c: Fix common/ includes.
12689         * inflow.c: Fix common/ includes.
12690         * inferior.h: Fix common/ includes.
12691         * inferior.c: Fix common/ includes.
12692         * infcmd.c: Fix common/ includes.
12693         * inf-ptrace.c: Fix common/ includes.
12694         * inf-child.c: Fix common/ includes.
12695         * ia64-linux-nat.c: Fix common/ includes.
12696         * i387-tdep.c: Fix common/ includes.
12697         * i386-tdep.c: Fix common/ includes.
12698         * i386-linux-tdep.c: Fix common/ includes.
12699         * i386-linux-nat.c: Fix common/ includes.
12700         * i386-go32-tdep.c: Fix common/ includes.
12701         * i386-fbsd-tdep.c: Fix common/ includes.
12702         * i386-fbsd-nat.c: Fix common/ includes.
12703         * guile/scm-type.c: Fix common/ includes.
12704         * guile/guile.c: Fix common/ includes.
12705         * go32-nat.c: Fix common/ includes.
12706         * gnu-nat.c: Fix common/ includes.
12707         * gdbthread.h: Fix common/ includes.
12708         * gdbarch-selftests.c: Fix common/ includes.
12709         * gdb_usleep.c: Fix common/ includes.
12710         * gdb_select.h: Fix common/ includes.
12711         * gdb_bfd.c: Fix common/ includes.
12712         * gcore.c: Fix common/ includes.
12713         * fork-child.c: Fix common/ includes.
12714         * findvar.c: Fix common/ includes.
12715         * fbsd-nat.c: Fix common/ includes.
12716         * event-top.c: Fix common/ includes.
12717         * event-loop.c: Fix common/ includes.
12718         * dwarf2read.c: Fix common/ includes.
12719         * dwarf2loc.c: Fix common/ includes.
12720         * dwarf2-frame.c: Fix common/ includes.
12721         * dwarf-index-cache.c: Fix common/ includes.
12722         * dtrace-probe.c: Fix common/ includes.
12723         * disasm-selftests.c: Fix common/ includes.
12724         * defs.h: Fix common/ includes.
12725         * csky-tdep.c: Fix common/ includes.
12726         * cp-valprint.c: Fix common/ includes.
12727         * cp-support.h: Fix common/ includes.
12728         * cp-support.c: Fix common/ includes.
12729         * corelow.c: Fix common/ includes.
12730         * completer.h: Fix common/ includes.
12731         * completer.c: Fix common/ includes.
12732         * compile/compile.c: Fix common/ includes.
12733         * compile/compile-loc2c.c: Fix common/ includes.
12734         * compile/compile-cplus-types.c: Fix common/ includes.
12735         * compile/compile-cplus-symbols.c: Fix common/ includes.
12736         * command.h: Fix common/ includes.
12737         * cli/cli-dump.c: Fix common/ includes.
12738         * cli/cli-cmds.c: Fix common/ includes.
12739         * charset.c: Fix common/ includes.
12740         * build-id.c: Fix common/ includes.
12741         * btrace.h: Fix common/ includes.
12742         * btrace.c: Fix common/ includes.
12743         * breakpoint.h: Fix common/ includes.
12744         * breakpoint.c: Fix common/ includes.
12745         * ax.h:
12746         (enum agent_op): Fix common/ includes.
12747         * ax-general.c (struct aop_map): Fix common/ includes.
12748         * ax-gdb.c: Fix common/ includes.
12749         * auxv.c: Fix common/ includes.
12750         * auto-load.c: Fix common/ includes.
12751         * arm-tdep.c: Fix common/ includes.
12752         * arch/riscv.c: Fix common/ includes.
12753         * arch/ppc-linux-common.c: Fix common/ includes.
12754         * arch/i386.c: Fix common/ includes.
12755         * arch/arm.c: Fix common/ includes.
12756         * arch/arm-linux.c: Fix common/ includes.
12757         * arch/arm-get-next-pcs.c: Fix common/ includes.
12758         * arch/amd64.c: Fix common/ includes.
12759         * arch/aarch64.c: Fix common/ includes.
12760         * arch/aarch64-insn.c: Fix common/ includes.
12761         * arch-utils.c: Fix common/ includes.
12762         * amd64-windows-tdep.c: Fix common/ includes.
12763         * amd64-tdep.c: Fix common/ includes.
12764         * amd64-sol2-tdep.c: Fix common/ includes.
12765         * amd64-obsd-tdep.c: Fix common/ includes.
12766         * amd64-nbsd-tdep.c: Fix common/ includes.
12767         * amd64-linux-tdep.c: Fix common/ includes.
12768         * amd64-linux-nat.c: Fix common/ includes.
12769         * amd64-fbsd-tdep.c: Fix common/ includes.
12770         * amd64-fbsd-nat.c: Fix common/ includes.
12771         * amd64-dicos-tdep.c: Fix common/ includes.
12772         * amd64-darwin-tdep.c: Fix common/ includes.
12773         * agent.c: Fix common/ includes.
12774         * ada-lang.h: Fix common/ includes.
12775         * ada-lang.c: Fix common/ includes.
12776         * aarch64-tdep.c: Fix common/ includes.
12777
12778 2019-01-25  Tom Tromey  <tom@tromey.com>
12779
12780         * common/create-version.sh: Use common/version.h.
12781
12782 2019-01-24  Pedro Alves  <palves@redhat.com>
12783
12784         * infrun.c (signal_stop, signal_print, signal_program)
12785         (signal_catch, signal_pass): Now arrays instead of pointers.
12786         (update_signals_program_target, do_target_resume)
12787         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12788         * linux-nat.c (linux_nat_target::pass_signals)
12789         (linux_nat_target::create_inferior, linux_nat_target::attach):
12790         Adjust.
12791         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12792         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12793         * procfs.c (procfs_target::pass_signals): Adjust.
12794         * record-full.c (record_full_target::resume): Adjust.
12795         * remote.c (remote_target::pass_signals)
12796         (remote_target::program_signals): Adjust.
12797         * target-debug.h (target_debug_print_signals): Now takes a
12798         gdb::array_view as parameter.  Adjust.
12799         * target.h (target_ops) <pass_signals, program_signals>: Replace
12800         pointer and length parameters with gdb::array_view.
12801         (target_pass_signals, target_program_signals): Likewise.
12802         * target-delegates.c: Regenerate.
12803
12804 2019-01-24  Pedro Alves  <palves@redhat.com>
12805
12806         * common/forward-scope-exit.h
12807         (forward_scope_exit::forward_scope_exit): Pass arguments to
12808         m_bind_function directly, instead of creating a std::bind and
12809         copying that.
12810
12811 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12812
12813         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12814         for static members.
12815         (pass_in_v_vfp_candidate): Likewise.
12816
12817 2019-01-23  Tom Tromey  <tom@tromey.com>
12818             Pedro Alves  <palves@redhat.com>
12819
12820         * regcache.c (class regcache_invalidator): Remove.
12821         (regcache::raw_write): Use make_scope_exit.
12822
12823 2019-01-23  Tom Tromey  <tom@tromey.com>
12824
12825         * ui-out.h (class ui_out_emit_type): Update comment.
12826
12827 2019-01-23  Tom Tromey  <tom@tromey.com>
12828
12829         * infrun.c (fetch_inferior_event): Update comment.
12830
12831 2019-01-23  Tom Tromey  <tom@tromey.com>
12832             Pedro Alves  <palves@redhat.com>
12833
12834         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12835         parameter.
12836         (fetch_inferior_event): Use SCOPE_EXIT.
12837
12838
12839 2019-01-23  Tom Tromey  <tom@tromey.com>
12840             Pedro Alves  <palves@redhat.com>
12841
12842         * infrun.c (disable_thread_events): Delete.
12843         (stop_all_threads): Use SCOPE_EXIT.
12844
12845 2019-01-23  Tom Tromey  <tom@tromey.com>
12846             Pedro Alves  <palves@redhat.com>
12847
12848         * symfile.c: Include forward-scope-exit.h.
12849         (clear_symtab_users_cleanup): Replace forward declaration with
12850         a FORWARD_SCOPE_EXIT.
12851         (syms_from_objfile_1): Use the forward_scope_exit and
12852         gdb::optional instead of cleanup_function.
12853         (reread_symbols): Use the forward_scope_exit instead of
12854         cleanup_function.
12855         (clear_symtab_users_cleanup): Remove function.
12856
12857 2019-01-23  Tom Tromey  <tom@tromey.com>
12858             Pedro Alves  <palves@redhat.com>
12859
12860         * linux-nat.c: Include scope-exit.h.
12861         (cleanup_target_stop): Remove.
12862         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12863         SCOPE_EXIT.
12864
12865 2019-01-23  Tom Tromey  <tom@tromey.com>
12866             Pedro Alves  <palves@redhat.com>
12867
12868         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12869         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12870
12871 2019-01-23  Tom Tromey  <tom@tromey.com>
12872             Andrew Burgess  <andrew.burgess@embecosm.com>
12873             Pedro Alves  <palves@redhat.com>
12874
12875         * infrun.c (fetch_inferior_event): Use scope_exit.
12876         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12877         * top.c (execute_command): Use scope_exit.
12878         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12879         * utils.c (do_bpstat_clear_actions_cleanup)
12880         (make_bpstat_clear_actions_cleanup): Remove.
12881
12882 2019-01-23  Tom Tromey  <tom@tromey.com>
12883             Pedro Alves  <palves@redhat.com>
12884
12885         * infrun.c: Include "common/scope-exit.h"
12886         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12887         (wait_for_inferior): Use SCOPE_EXIT.
12888         (fetch_inferior_event): Use scope_exit.
12889
12890 2019-01-23  Tom Tromey  <tom@tromey.com>
12891             Pedro Alves  <palves@redhat.com>
12892
12893         * breakpoint.c (create_breakpoint): Remove cleanup.
12894
12895 2019-01-23  Tom Tromey  <tom@tromey.com>
12896             Andrew Burgess  <andrew.burgess@embecosm.com>
12897             Pedro Alves  <palves@redhat.com>
12898
12899 2019-01-23  Pedro Alves  <palves@redhat.com>
12900
12901         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12902
12903 2019-01-23  Pedro Alves  <palves@redhat.com>
12904             Andrew Burgess  <andrew.burgess@embecosm.com>
12905
12906         * gdbthread.h: Include "common/forward-scope-exit.h".
12907         (scoped_finish_thread_state): Redefine custom class in terms of
12908         forward_scope_exit.
12909
12910 2019-01-23  Pedro Alves  <palves@redhat.com>
12911             Andrew Burgess  <andrew.burgess@embecosm.com>
12912
12913         * common/forward-scope-exit.h: New file.
12914
12915 2019-01-23  Pedro Alves  <palves@redhat.com>
12916             Andrew Burgess  <andrew.burgess@embecosm.com>
12917             Tom Tromey  <tom@tromey.com>
12918
12919         * common/scope-exit.h: New file.
12920
12921 2019-01-23  Pedro Alves  <palves@redhat.com>
12922
12923         * common/preprocessor.h (ESC): Rename to ...
12924         (ESC_PARENS): ... this.
12925         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12926         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12927
12928 2019-01-23  Tom Tromey  <tom@tromey.com>
12929
12930         * language.h (class scoped_switch_to_sym_language_if_auto):
12931         Initialize m_lang in both cases.
12932
12933 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12934
12935         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12936         with XCNEW.
12937
12938 2019-01-22  Tom Tromey  <tom@tromey.com>
12939
12940         * corelow.c: Do not include sys/file.h.
12941
12942 2019-01-22  Tom Tromey  <tom@tromey.com>
12943
12944         * tui/tui-wingeneral.h: Include gdb_curses.h.
12945
12946 2019-01-22  Tom Tromey  <tom@tromey.com>
12947
12948         * source-cache.h (class source_cache) <get_source_lines,
12949         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12950
12951 2019-01-22  Tom Tromey  <tom@tromey.com>
12952
12953         * remote-fileio.h (struct remote_target): Declare.
12954
12955 2019-01-22  Tom Tromey  <tom@tromey.com>
12956
12957         * python/py-arch.c: Do not include py-ref.h.
12958         * python/py-bpevent.c: Do not include py-ref.h.
12959         * python/py-cmd.c: Do not include py-ref.h.
12960         * python/py-continueevent.c: Do not include py-ref.h.
12961         * python/py-event.h: Do not include py-ref.h.
12962         * python/py-evtregistry.c: Do not include py-ref.h.
12963         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12964         * python/py-frame.c: Do not include py-ref.h.
12965         * python/py-framefilter.c: Do not include py-ref.h.
12966         * python/py-function.c: Do not include py-ref.h.
12967         * python/py-infevents.c: Do not include py-ref.h.
12968         * python/py-linetable.c: Do not include py-ref.h.
12969         * python/py-objfile.c: Do not include py-ref.h.
12970         * python/py-param.c: Do not include py-ref.h.
12971         * python/py-prettyprint.c: Do not include py-ref.h.
12972         * python/py-progspace.c: Do not include py-ref.h.
12973         * python/py-symbol.c: Do not include py-ref.h.
12974         * python/py-symtab.c: Do not include py-ref.h.
12975         * python/py-type.c: Do not include py-ref.h.
12976         * python/py-unwind.c: Do not include py-ref.h.
12977         * python/py-utils.c: Do not include py-ref.h.
12978         * python/py-value.c: Do not include py-ref.h.
12979         * python/py-varobj.c: Do not include py-ref.h.
12980         * python/py-xmethods.c: Do not include py-ref.h.
12981         * python/python.c: Do not include py-ref.h.
12982         * varobj.c: Do not include py-ref.h.
12983
12984 2019-01-22  Tom Tromey  <tom@tromey.com>
12985
12986         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12987         keyword for bcache.
12988
12989 2019-01-22  Tom Tromey  <tom@tromey.com>
12990
12991         * compile/compile-cplus-types.c: Remove a comment by #include.
12992
12993 2019-01-22  Tom Tromey  <tom@tromey.com>
12994
12995         * compile/gcc-c-plugin.h: Include compile-internal.h.
12996
12997 2019-01-22  Tom Tromey  <tom@tromey.com>
12998
12999         * stabsread.c (EXTERN): Do not define.
13000         (symnum, next_symbol_text_func, processing_gcc_compilation)
13001         (within_function, global_sym_chain, global_stabs)
13002         (previous_stab_code, this_object_header_files)
13003         (n_this_object_header_files)
13004         (n_allocated_this_object_header_files): Define.
13005         * stabsread.h (EXTERN): Never define.  Use "extern".
13006
13007 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13008
13009         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13010         history_value.
13011
13012 2019-01-21  Tom Tromey  <tom@tromey.com>
13013
13014         * ui-out.c: Fix includes.
13015         * tui/tui-source.c: Fix includes.
13016         * target.c: Fix includes.
13017         * remote.c: Fix includes.
13018         * regcache.c: Fix includes.
13019         * python/py-block.c: Fix includes.
13020         * printcmd.c: Fix includes.
13021         * or1k-tdep.c: Fix includes.
13022         * mi/mi-main.c: Fix includes.
13023         * m32r-tdep.c: Fix includes.
13024         * csky-tdep.c: Fix includes.
13025         * compile/compile-cplus-types.c: Fix includes.
13026         * cli/cli-interp.c: Fix includes.
13027
13028 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13029
13030         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13031         for padding.
13032
13033 2019-01-16  Tom Tromey  <tom@tromey.com>
13034
13035         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13036         earlier.
13037         (struct objfile) <msymbols_range>: Move from top level.
13038         <msymbols>: New method.
13039         (class objfile_msymbols): Remove.
13040         * symtab.c (default_collect_symbol_completion_matches_break_on):
13041         Update.
13042         * symmisc.c (dump_msymbols): Update.
13043         * stabsread.c (scan_file_globals): Update.
13044         * objc-lang.c (info_selectors_command, info_classes_command)
13045         (find_methods): Update.
13046         * minsyms.c (find_solib_trampoline_target): Update.
13047         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13048         * coffread.c (coff_symfile_read): Update.
13049         * ada-lang.c (ada_lookup_simple_minsym)
13050         (ada_collect_symbol_completion_matches): Update.
13051
13052 2019-01-16  Tom Tromey  <tom@tromey.com>
13053
13054         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13055         type.  Remove no-argument constructor.
13056         <iterator::operator++>: Simplify.
13057         <begin>: Update.
13058         <end>: Use minimal_symbol_count.
13059
13060 2019-01-16  Tom Tromey  <tom@tromey.com>
13061
13062         * objfiles.h (struct objfile) <psymtabs>: New method.
13063         (class objfile_psymtabs): Remove.
13064         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13065         typedef.
13066         <range>: New method.
13067         (require_partial_symbols): Change return type.
13068         * psymtab.c (require_partial_symbols)
13069         (psym_expand_symtabs_matching): Update.
13070         * mdebugread.c (parse_partial_symbols): Update.
13071         * dbxread.c (dbx_end_psymtab): Update.
13072
13073 2019-01-15  Tom Tromey  <tom@tromey.com>
13074
13075         * symtab.c (lookup_objfile_from_block)
13076         (lookup_symbol_in_objfile_symtabs)
13077         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13078         (find_line_symtab, info_sources_command)
13079         (default_collect_symbol_completion_matches_break_on)
13080         (make_source_files_completion_list): Update.
13081         * symmisc.c (print_objfile_statistics, dump_objfile)
13082         (maintenance_print_symbols, maintenance_info_symtabs)
13083         (maintenance_check_symtabs, maintenance_info_line_tables):
13084         Update.
13085         * source.c (select_source_symtab)
13086         (forget_cached_source_info_for_objfile): Update.
13087         * objfiles.h (class objfile_compunits): Remove.
13088         (struct objfile) <compunits_range>: New typedef.
13089         (compunits): New method.
13090         * objfiles.c (objfile_relocate1): Update.
13091         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13092         * maint.c (count_symtabs_and_blocks): Update.
13093         * linespec.c (iterate_over_all_matching_symtabs): Update.
13094         * cp-support.c (add_symbol_overload_list_qualified): Update.
13095         * coffread.c (coff_symtab_read): Update.
13096         * ada-lang.c (add_nonlocal_symbols)
13097         (ada_collect_symbol_completion_matches)
13098         (ada_add_global_exceptions): Update.
13099
13100 2019-01-15  Tom Tromey  <tom@tromey.com>
13101
13102         * progspace.h (program_space) <objfiles_safe_range>: New
13103         typedef.
13104         <objfiles_safe>: New method.
13105         * objfiles.h (class all_objfiles_safe): Remove.
13106         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13107         * jit.c (jit_inferior_exit_hook): Update.
13108
13109 2019-01-17  Tom Tromey  <tom@tromey.com>
13110
13111         * progspace.h (program_space) <objfiles_range>: New typedef.
13112         <objfiles>: New method.
13113         <objfiles_head>: Rename from objfiles.
13114         (object_files): Update.
13115         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13116         * guile/scm-pretty-print.c
13117         (ppscm_find_pretty_printer_from_objfiles): Update.
13118         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13119         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13120         Update.
13121         * python/py-progspace.c (pspy_get_objfiles): Update.
13122         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13123         Update.
13124         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13125         (objfpy_lookup_objfile_by_build_id): Update.
13126         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13127         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13128         Update.
13129         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13130         (expand_symtab_containing_pc, lookup_objfile_from_block)
13131         (lookup_static_symbol, basic_lookup_transparent_type)
13132         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13133         (find_line_symtab, info_sources_command)
13134         (default_collect_symbol_completion_matches_break_on)
13135         (make_source_files_completion_list, find_main_name): Update.
13136         * symmisc.c (print_symbol_bcache_statistics)
13137         (print_objfile_statistics, maintenance_print_symbols)
13138         (maintenance_print_msymbols, maintenance_print_objfiles)
13139         (maintenance_info_symtabs, maintenance_check_symtabs)
13140         (maintenance_expand_symtabs, maintenance_info_line_tables):
13141         Update.
13142         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13143         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13144         (map_overlay_command, unmap_overlay_command)
13145         (simple_overlay_update, expand_symtabs_matching)
13146         (map_symbol_filenames): Update.
13147         * symfile-debug.c (set_debug_symfile): Update.
13148         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13149         Update.
13150         * source.c (select_source_symtab, forget_cached_source_info):
13151         Update.
13152         * solib.c (solib_read_symbols): Update.
13153         * solib-spu.c (append_ocl_sos): Update.
13154         * psymtab.c (maintenance_print_psymbols)
13155         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13156         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13157         * printcmd.c (info_symbol_command): Update.
13158         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13159         Update.
13160         * objfiles.h (class all_objfiles): Remove.
13161         * objfiles.c (have_partial_symbols, have_full_symbols)
13162         (have_minimal_symbols, qsort_cmp, update_section_map)
13163         (shared_objfile_contains_address_p)
13164         (default_iterate_over_objfiles_in_search_order): Update.
13165         * objc-lang.c (info_selectors_command, info_classes_command)
13166         (find_methods): Update.
13167         * minsyms.c (find_solib_trampoline_target): Update.
13168         * maint.c (maintenance_info_sections)
13169         (maintenance_translate_address, count_symtabs_and_blocks):
13170         Update.
13171         * main.c (captured_main_1): Update.
13172         * linux-thread-db.c (try_thread_db_load_from_pdir)
13173         (has_libpthread): Update.
13174         * linespec.c (iterate_over_all_matching_symtabs)
13175         (search_minsyms_for_name): Update.
13176         * jit.c (jit_find_objf_with_entry_addr): Update.
13177         * hppa-tdep.c (find_unwind_entry)
13178         (hppa_lookup_stub_minimal_symbol): Update.
13179         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13180         Update.
13181         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13182         (elf_gnu_ifunc_resolve_by_got): Update.
13183         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13184         * dwarf-index-write.c (save_gdb_index_command): Update.
13185         * cp-support.c (add_symbol_overload_list_qualified): Update.
13186         * breakpoint.c (create_overlay_event_breakpoint)
13187         (create_longjmp_master_breakpoint)
13188         (create_std_terminate_master_breakpoint)
13189         (create_exception_master_breakpoint): Update.
13190         * blockframe.c (find_pc_partial_function): Update.
13191         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13192         (ada_collect_symbol_completion_matches)
13193         (ada_add_global_exceptions): Update.
13194
13195 2019-01-17  Tom Tromey  <tom@tromey.com>
13196
13197         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13198         declare VEC.
13199         (solib_target_parse_libraries): Change return type.
13200         (library_list_start_segment, library_list_start_section)
13201         (library_list_end_library, library_list_start_library); Update.
13202         (solib_target_free_library_list): Remove.
13203         (solib_target_parse_libraries): Remove cleanup.  Change return
13204         type.
13205         (solib_target_current_sos): Update.
13206
13207 2019-01-17  Tom Tromey  <tromey@bapiya>
13208
13209         * valprint.c: Replace "the the" with "the".
13210         * symtab.c: Replace "the the" with "the".
13211         * solib.c: Replace "the the" with "the".
13212         * solib-dsbt.c: Replace "the the" with "the".
13213         * linespec.c: Replace "the the" with "the".
13214         * dwarf2loc.h: Replace "the the" with "the".
13215         * amd64-windows-tdep.c: Replace "the the" with "the".
13216         * aarch64-tdep.c: Replace "the the" with "the".
13217
13218 2019-01-16  Keith Seitz  <keiths@redhat.com>
13219
13220         PR gdb/23773
13221         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13222         <builder>: Rename to ..
13223         <m_builder>: ... this and make private.
13224         (dwarf2_cu::get_builder): New method.  Change all users of
13225         `builder' to use this method.
13226         (dwarf2_start_symtab): Move to ...
13227         (dwarf2_cu::start_symtab): ... here.  Update all callers
13228         (setup_type_unit_groups): Move to ...
13229         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13230         callers.
13231         (dwarf2_cu::reset_builder): New method.
13232         (process_full_compunit, process_full_type_unit): Use
13233         dwarf2_cu::reset_builder.
13234         (follow_die_offset): Record the ancestor CU if it is different
13235         from the followed DIE's CU.
13236         (follow_die_sig_1): Likewise.
13237
13238 2019-01-15  Tom Tromey  <tom@tromey.com>
13239
13240         * remote.c (class remote_state) <buf>: Now a char_vector.
13241         <buf_size>: Remove.
13242         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13243         parameter.
13244         (remote_target::getpkt_or_notif_sane_1)
13245         (remote_target::getpkt_sane)
13246         (remote_target::getpkt_or_notif_sane): Likewise.
13247         (class remote_target) <putpkt>: New overload.
13248         (remote_target::read_frame): Change type of "buf_p".  Remove
13249         sizeof_p parameter.
13250         (packet_ok): New overload.
13251         (packet_check_result): New overload.
13252         Update all uses.
13253
13254 2019-01-14  Tom Tromey  <tom@tromey.com>
13255
13256         * remote-notif.c (handle_notification, remote_notif_ack)
13257         (remote_notif_parse): Make "buf" const.
13258         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13259         const.
13260         (remote_notif_parse, remote_notif_ack, handle_notification):
13261         Likewise.
13262         * remote.c (remote_notif_stop_parse): Make "buf" const.
13263         (remote_target::remote_parse_stop_reply): Make "buf" const.
13264         (remote_notif_stop_ack): Make "buf" const.
13265
13266 2019-01-14  Tom Tromey  <tom@tromey.com>
13267
13268         * remote.c (remote_console_output): Make parameter const.
13269
13270 2019-01-14  Tom Tromey  <tom@tromey.com>
13271
13272         * target-debug.h (target_debug_print_signals): Constify.
13273         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13274         * procfs.c (procfs_target::pass_signals): Update.
13275         * linux-nat.c (linux_nat_target::pass_signals): Update.
13276         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13277         * target-delegates.c: Rebuild.
13278         * remote.c (remote_target::program_signals): Update.
13279         (remote_target::pass_signals): Update.
13280         * target.c (target_pass_signals): Constify argument.
13281         (target_program_signals): Likewise.
13282         * target.h (struct target_ops) <pass_signals, program_signals>:
13283         Constify argument.
13284         (target_pass_signals, target_program_signals): Constify argument.
13285
13286 2019-01-14  Tom Tromey  <tom@tromey.com>
13287
13288         PR tui/28819:
13289         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13290
13291 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13292
13293         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13294         field.
13295         * rs6000-tdep.c: Include reggroups.h.
13296         (IS_V_ALIAS_PSEUDOREG): Define.
13297         (rs6000_register_name): Return names for the "vX" aliases.
13298         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13299         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13300         aliases.  Call default_register_reggroup_p for all other
13301         pseudo-registers.
13302         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13303         New functions.
13304         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13305         Handle "vX" aliases.
13306         (v_alias_pseudo_register_collect): New function.
13307         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13308         (rs6000_gdbarch_init): Initialize "vX" aliases as
13309         pseudo-registers.  Restore registration of
13310         rs6000_pseudo_register_reggroup_p with
13311         set_tdesc_pseudo_register_reggroup_p.
13312
13313 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13314
13315         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13316         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13317         set_gdbarch_num_pseudo_regs.
13318
13319 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13320
13321         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13322         Remove arg prefixname, add do_set and do_show.
13323         Add member functions set_list and show_list.
13324         * cli/cli-style.c (class cli_style_option): Update accordingly.
13325         (style_set_list): Move to file scope.
13326         (style_show_list): Likewise.
13327         (set_style): Call help_list.
13328         (show_style): Call cmd_show_list.
13329         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13330         Update to use the new macro.
13331
13332 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13333
13334         * ada-lang.c (_initialize_ada_language): Expand the help text
13335         for the "catch exception" command.
13336
13337 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13338
13339         * symtab.c (matching_obj_sections): Initialize obj,
13340         declare it closer to its usage.
13341
13342 2019-01-10  Tom Tromey  <tom@tromey.com>
13343
13344         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13345         (basic_inf_threads_range): Remove.
13346         (inf_threads_range, inf_non_exited_threads_range)
13347         (safe_inf_threads_range): Use next_adapter.
13348
13349 2019-01-10  Keith Seitz  <keiths@redhat.com>
13350
13351         PR gdb/23712
13352         PR symtab/23010
13353         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13354         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13355
13356 2019-01-10  Keith Seitz  <keiths@redhat.com>
13357
13358         PR gdb/23712
13359         PR symtab/23010
13360         * dictionary.c (pending_to_vector): Remove.
13361         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13362         Remove _1 suffix, replacing functions of the same name.  Update
13363         all callers.
13364         (dict_create_hashed, dict_create_hashed_expandable)
13365         (dict_create_linear, dict_create_linear_expandable, dict_free)
13366         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13367         Make functions static.
13368
13369 2019-01-10  Keith Seitz  <keiths@redhat.com>
13370
13371         PR gdb/23712
13372         PR symtab/23010
13373         * dictionary.h (struct dictionary): Replace declaration with
13374         multidictionary.
13375         (dict_create_hashed, dict_create_hashed_expandable)
13376         (dict_create_linear, dict_create_linear_expandable)
13377         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13378         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13379         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13380         taking multidictionary argument.
13381         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13382         * block.h (struct block) <dict>: Change to multidictionary
13383         and rename `multidict'.
13384         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13385         symmisc.c: Update all dictionary references to multidictionary.
13386
13387 2019-01-10  Keith Seitz  <keiths@redhat.com>
13388
13389         PR gdb/23712
13390         PR symtab/23010
13391         * dictionary.c: Include unordered_map.
13392         (pending_to_vector): New function.
13393         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13394         Rewrite the non-"_1" functions to take vector instead
13395         of linked list.
13396         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13397         "new" _1 versions of the same name.
13398         (multidictionary): Define.
13399         (std::hash<enum language): New definition.
13400         (collate_pending_symbols_by_language, mdict_create_hashed)
13401         (mdict_create_hashed_expandable, mdict_create_linear)
13402         (mdict_create_linear_expandable, mdict_free)
13403         (find_language_dictionary, create_new_language_dictionary)
13404         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13405         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13406         (mdict_size, mdict_empty): New functions.
13407         * dictionary.h (mdict_iterator): Define.
13408
13409 2019-01-10  Pedro Alves  <palves@redhat.com>
13410
13411         * breakpoint.c (read_uploaded_action)
13412         (create_tracepoint_from_upload): Adjust to use
13413         gdb::unique_xmalloc_ptr.
13414         * ctf.c (ctf_write_uploaded_tp):
13415         (SET_ARRAY_FIELD): Use emplace_back.
13416         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13417         * tracefile-tfile.c (tfile_write_uploaded_tp):
13418         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13419         gdb::unique_xmalloc_ptr.
13420         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13421         at_string, cond_string, cmd_strings>: Replace char pointers
13422         with gdb::unique_xmalloc_ptr.
13423
13424 2019-01-10  Pedro Alves  <palves@redhat.com>
13425
13426         * solib-target.c (library_list_start_library): Don't xstrdup name.
13427
13428 2019-01-10  Pedro Alves  <palves@redhat.com>
13429
13430         * mdebugread.c (parse_partial_symbols): Use
13431         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13432
13433 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13434
13435         * linux-fork.c (scoped_switch_fork_info)
13436         <~scoped_switch_fork_info>: Fix incorrect variable name.
13437
13438 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13439
13440         * linux-fork.c (scoped_switch_fork_info)
13441         <scoped_switch_fork_info>: Make explicit.
13442         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13443
13444 2019-01-10  Tom Tromey  <tom@tromey.com>
13445
13446         * objfiles.h (objfile::reset_psymtabs): Update.
13447         * objfiles.c (objfile::objfile): Update.
13448         * psymtab.h (psymtab_storage::obstack): Update.
13449         (psymtab_storage::m_obstack): Use gdb::optional.
13450         (class psymtab_storage): Update comment.  Remove objfile
13451         parameter.
13452         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13453
13454 2019-01-10  Tom Tromey  <tom@tromey.com>
13455
13456         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13457         <free_psymtabs>: Now private.
13458         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13459         (allocate_psymtab): Use new method.
13460
13461 2019-01-10  Tom Tromey  <tom@tromey.com>
13462
13463         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13464         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13465         * mdebugread.c (parse_partial_symbols): Use
13466         allocate_dependencies.
13467         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13468         allocate_dependencies.
13469         (process_psymtab_comp_unit_reader)
13470         (build_type_psymtab_dependencies): Likewise.
13471         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13472
13473 2019-01-10  Tom Tromey  <tom@tromey.com>
13474
13475         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13476         PSYMBOL_SET_LANGUAGE.
13477         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13478
13479 2019-01-10  Tom Tromey  <tom@tromey.com>
13480
13481         * psymtab.h (psymtab_storage::obstack): New method.
13482         <m_obstack>: Rename from obstack; now private.
13483         * psymtab.c (psymtab_storage): Update.
13484         * dwarf2read.c (create_addrmap_from_index)
13485         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13486         Update.
13487
13488 2019-01-10  Tom Tromey  <tom@tromey.com>
13489
13490         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13491         * objfiles.h (objfile::reset_psymtabs): New method.
13492
13493 2019-01-10  Tom Tromey  <tom@tromey.com>
13494
13495         * symmisc.c (print_symbol_bcache_statistics): Update.
13496         (print_objfile_statistics): Update.
13497         * symfile.c (reread_symbols): Update.
13498         * psymtab.h (class psymtab_storage): New.
13499         * psymtab.c (psymtab_storage): New constructor.
13500         (~psymtab_storage): New destructor.
13501         (require_partial_symbols): Update.
13502         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13503         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13504         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13505         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13506         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13507         (start_psymtab_common, end_psymtab_common)
13508         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13509         (allocate_psymtab): Update.
13510         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13511         Update.
13512         (dump_psymtab_addrmap, maintenance_print_psymbols)
13513         (maintenance_check_psymtabs): Update.
13514         (class objfile_psymtabs): Move to objfiles.h.
13515         * psympriv.h (discard_psymtab): Now inline.
13516         (psymtab_discarder::psymtab_discarder): Update.
13517         (psymtab_discarder::~psymtab_discarder): Update.
13518         (ALL_OBJFILE_PSYMTABS): Rewrite.
13519         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13520         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13521         Remove fields.
13522         <partial_symtabs>: New field.
13523         (class objfile_psymtabs): Move from psymtab.h.  Update.
13524         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13525         psymbol_cache.
13526         (objfile::~objfile): Don't destroy psymbol_cache.
13527         * mdebugread.c (parse_partial_symbols): Update.
13528         * dwarf2read.c (create_addrmap_from_index)
13529         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13530         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13531         (add_partial_subprogram, dwarf2_ranges_read): Update.
13532         * dwarf-index-write.c (write_address_map)
13533         (write_one_signatured_type, recursively_write_psymbols)
13534         (class debug_names, class debug_names, write_psymtabs_to_index):
13535         Update.
13536
13537 2019-01-10  Tom Tromey  <tom@tromey.com>
13538
13539         * symtab.h (SYMBOL_SET_NAMES): Update.
13540         (symbol_set_names): Update.
13541         (MSYMBOL_SET_NAMES): Update.
13542         * symtab.c (symbol_set_names): Change argument to be an
13543         objfile_per_bfd_storage.
13544         * psymtab.c (add_psymbol_to_bcache): Update.
13545         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13546
13547 2019-01-10  Tom Tromey  <tom@tromey.com>
13548
13549         * symtab.c (create_demangled_names_hash): Change argument to be an
13550         objfile_per_bfd_storage.
13551         (symbol_set_names): Update.
13552
13553 2019-01-10  Tom Tromey  <tom@tromey.com>
13554
13555         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13556         init_psymbol_list.
13557         * psymtab.c (init_psymbol_list): Do nothing if already called.
13558         * psympriv.h (init_psymbol_list): Add comment.
13559         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13560         init_psymbol_list.
13561         * dbxread.c (dbx_symfile_read): Unconditionally call
13562         init_psymbol_list.
13563
13564 2019-01-10  Tom Tromey  <tom@tromey.com>
13565
13566         * xcoffread.c (scan_xcoff_symtab): Update.
13567         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13568         "where".
13569         * mdebugread.c (parse_partial_symbols)
13570         (handle_psymbol_enumerators): Update.
13571         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13572         * dbxread.c (read_dbx_symtab): Update.
13573         * psympriv.h (psymbol_placement): New enum.
13574         (add_psymbol_to_list): Update.
13575
13576 2019-01-10  Tom Tromey  <tom@tromey.com>
13577
13578         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13579         static_psymbols parameters.
13580         (scan_xcoff_symtab): Update.
13581         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13582         static_psymbols parameters.
13583         * psympriv.h (start_psymtab_common): Update.
13584         * mdebugread.c (parse_partial_symbols): Update.
13585         * dwarf2read.c (create_partial_symtab): Update.
13586         * dbxread.c (read_dbx_symtab): Update.
13587         (start_psymtab): Remove global_psymbols and static_psymbols
13588         parameters.
13589
13590 2019-01-10  Tom Tromey  <tom@tromey.com>
13591
13592         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13593         * psymtab.c (allocate_psymtab): Add comment.
13594         * psympriv.h (allocate_psymtab): Add comment.
13595         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13596         initializations.
13597         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13598
13599 2019-01-10  Tom Tromey  <tom@tromey.com>
13600
13601         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13602         Don't declare.
13603         * mipsread.c: Include mdebugread.h.
13604         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13605         Declare.
13606         * elfread.c: Include mdebugread.h.
13607
13608 2019-01-09  Tom Tromey  <tom@tromey.com>
13609
13610         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13611         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13612         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13613         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13614         (psym_lookup_symbol, psym_find_last_source_symtab)
13615         (psym_forget_cached_source_info, psym_print_stats)
13616         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13617         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13618         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13619         (psym_find_compunit_symtab_by_address)
13620         (maintenance_print_psymbols, maintenance_info_psymtabs)
13621         (maintenance_check_psymtabs): Use ranged for.
13622         * psymtab.h (class objfile_psymtabs): New.
13623         (require_partial_symbols): Return objfile_psymtabs.
13624         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13625
13626 2019-01-09  Tom Tromey  <tom@tromey.com>
13627
13628         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13629         (find_pc_mapped_section, list_overlays_command)
13630         (map_overlay_command, unmap_overlay_command)
13631         (simple_overlay_update): Use all_objfiles.
13632         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13633         * printcmd.c (info_symbol_command): Use all_objfiles.
13634         * objfiles.h (ALL_OBJSECTIONS): Remove.
13635         * maint.c (maintenance_translate_address): Use all_objfiles.
13636         * gcore.c (gcore_create_callback): Use all_objfiles.
13637         (objfile_find_memory_regions): Likewise.
13638
13639 2019-01-09  Tom Tromey  <tom@tromey.com>
13640
13641         * symtab.c (find_line_symtab, info_sources_command)
13642         (make_source_files_completion_list): Use objfile_compunits.
13643         * source.c (select_source_symtab): Use objfile_compunits.
13644         * objfiles.h (struct objfile): Update comment.
13645         (ALL_OBJFILES): Remove.
13646         (ALL_FILETABS): Remove.
13647         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13648         objfile_compunits.
13649
13650 2019-01-09  Tom Tromey  <tom@tromey.com>
13651
13652         * symmisc.c (print_objfile_statistics, dump_objfile)
13653         (maintenance_print_symbols): Use compunit_filetabs.
13654         * source.c (forget_cached_source_info_for_objfile): Use
13655         compunit_filetabs.
13656         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13657         (ALL_FILETABS): Use compunit_filetabs.
13658         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13659         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13660
13661 2019-01-09  Tom Tromey  <tom@tromey.com>
13662
13663         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13664         (compunit_filetabs): New.
13665         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13666         compunit_filetabs.
13667         (info_sources_command, make_source_files_completion_list): Remove
13668         declaration.
13669         * symmisc.c (print_objfile_statistics, dump_objfile)
13670         (maintenance_print_symbols): Remove declaration.
13671         (maintenance_info_symtabs): Use compunit_filetabs.
13672         (maintenance_info_line_tables): Likewise.
13673         * source.c (select_source_symtab): Change local variable name.
13674         (forget_cached_source_info_for_objfile): Remove declaration.
13675         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13676         * objfiles.c (objfile_relocate1): Remove declaration.
13677         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13678         declaration.
13679         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13680         * coffread.c (coff_symtab_read): Remove declaration.
13681         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13682         compunit_filetabs.
13683
13684 2019-01-09  Tom Tromey  <tom@tromey.com>
13685
13686         * symtab.c (lookup_objfile_from_block)
13687         (find_pc_sect_compunit_symtab, search_symbols)
13688         (default_collect_symbol_completion_matches_break_on): Use
13689         objfile_compunits.
13690         * objfiles.h (ALL_COMPUNITS): Remove.
13691         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13692         * cp-support.c (add_symbol_overload_list_qualified): Use
13693         objfile_compunits.
13694         * ada-lang.c (ada_collect_symbol_completion_matches)
13695         (ada_add_global_exceptions): Use objfile_compunits.
13696
13697 2019-01-09  Tom Tromey  <tom@tromey.com>
13698
13699         * source.c (select_source_symtab)
13700         (forget_cached_source_info_for_objfile): Remove declaration.
13701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13702         declaration.
13703         * maint.c (count_symtabs_and_blocks): Remove declaration.
13704         * cp-support.c (add_symbol_overload_list_qualified): Remove
13705         declaration.
13706         * coffread.c (coff_symtab_read): Remove declaration.
13707         * symtab.c (lookup_symbol_in_objfile_symtabs)
13708         (basic_lookup_transparent_type_1): Use objfile_compunits.
13709         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13710         (info_sources_command, search_symbols)
13711         (default_collect_symbol_completion_matches_break_on)
13712         (make_source_files_completion_list): Remove declaration.
13713         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13714         (ada_collect_symbol_completion_matches)
13715         (ada_add_global_exceptions): Remove declaration.
13716         * linespec.c (iterate_over_all_matching_symtabs): Use
13717         objfile_compunits.
13718         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13719         (class objfile_compunits): New.
13720         (ALL_COMPUNITS): Use objfile_compunits.
13721         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13722         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13723         objfile_compunits.
13724         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13725
13726 2019-01-09  Tom Tromey  <tom@tromey.com>
13727
13728         * symtab.c (search_symbols)
13729         (default_collect_symbol_completion_matches_break_on): Use
13730         objfile_msymbols.
13731         * ada-lang.c (ada_lookup_simple_minsym)
13732         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13733         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13734         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13735         objfile_msymbols.
13736         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13737         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13738         * objc-lang.c (find_methods): Use objfile_msymbols.
13739         (info_selectors_command, info_classes_command): Likewise.
13740         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13741         * objfiles.h (class objfile_msymbols): New.
13742         (ALL_OBJFILE_MSYMBOLS): Remove.
13743         (ALL_MSYMBOLS): Remove.
13744
13745 2019-01-09  Tom Tromey  <tom@tromey.com>
13746
13747         * common/next-iterator.h (next_adapter): Add Iterator template
13748         parameter.
13749         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13750         (class all_objfiles_safe): New.
13751         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13752         * objfiles.c (put_objfile_before): Update comment.
13753         (add_separate_debug_objfile): Likewise.
13754         (free_all_objfiles): Use all_objfiles_safe.
13755         (objfile_purge_solibs): Likewise.
13756
13757 2019-01-09  Tom Tromey  <tom@tromey.com>
13758
13759         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13760         (expand_symtab_containing_pc, lookup_static_symbol)
13761         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13762         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13763         all_objfiles.
13764         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13765         * breakpoint.c (create_overlay_event_breakpoint)
13766         (create_longjmp_master_breakpoint)
13767         (create_std_terminate_master_breakpoint)
13768         (create_exception_master_breakpoint): Use all_objfiles.
13769         * linux-thread-db.c (try_thread_db_load_from_pdir)
13770         (has_libpthread): Use all_objfiles.
13771         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13772         * linespec.c (iterate_over_all_matching_symtabs)
13773         (search_minsyms_for_name): Use all_objfiles.
13774         * maint.c (maintenance_info_sections): Use all_objfiles.
13775         * main.c (captured_main_1): Use all_objfiles.
13776         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13777         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13778         * guile/scm-pretty-print.c
13779         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13780         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13781         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13782         (maintenance_print_msymbols): Use all_objfiles.
13783         * source.c (select_source_symtab): Use all_objfiles.
13784         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13785         * symfile.c (remove_symbol_file_command)
13786         (expand_symtabs_matching, map_symbol_filenames): Use
13787         all_objfiles.
13788         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13789         all_objfiles.
13790         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13791         * objc-lang.c (find_methods): Use all_objfiles.
13792         * objfiles.c (have_partial_symbols, have_full_symbols)
13793         (have_minimal_symbols, qsort_cmp)
13794         (default_iterate_over_objfiles_in_search_order): Use
13795         all_objfiles.
13796         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13797         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13798         (maintenance_check_psymtabs): Use all_objfiles.
13799         (ALL_PSYMTABS): Remove.
13800         * compile/compile-object-run.c (do_module_cleanup): Use
13801         all_objfiles.
13802         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13803         * cp-support.c (add_symbol_overload_list_qualified): Use
13804         all_objfiles.
13805         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13806         Use all_objfiles.
13807         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13808         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13809         all_objfiles.
13810         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13811         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13812         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13813         Uses all_objfiles.
13814         * solib.c (solib_read_symbols): Use all_objfiles
13815
13816 2019-01-09  Tom Tromey  <tom@tromey.com>
13817
13818         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13819         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13820         all_objfiles.
13821         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13822         * symmisc.c (print_symbol_bcache_statistics)
13823         (print_objfile_statistics, maintenance_print_objfiles)
13824         (maintenance_info_symtabs, maintenance_check_symtabs)
13825         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13826         all_objfiles.
13827         * source.c (forget_cached_source_info): Use all_objfiles.
13828         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13829         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13830         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13831         * objfiles.c (update_section_map): Use all_objfiles.
13832         (shared_objfile_contains_address_p): Likewise.
13833         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13834         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13835
13836 2019-01-09  Tom Tromey  <tom@tromey.com>
13837
13838         * common/next-iterator.h: New file.
13839         * objfiles.h (class all_objfiles): New.
13840         (struct objfile_iterator): New.
13841
13842 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13843
13844         * NEWS: Move the description of the changed "frame", "select-frame",
13845          and "info frame" commands to the Changed commands section.
13846
13847 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13848
13849         * gdbtypes.c (check_stub_method_group): Remove handling of old
13850         mangling schemes.
13851         * linespec.c (find_methods): Likewise.
13852         * stabsread.c (read_member_functions): Likewise.
13853         * valops.c (search_struct_method): Likewise.
13854         (value_struct_elt_for_reference): Likewise.
13855         * NEWS: Mention this change.
13856
13857 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13858
13859         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13860         print_source_lines.
13861         * source.c (print_source_lines_base): Update line number check.
13862         (print_source_lines): New function.
13863         (source_lines_range::source_lines_range): New function.
13864         * source.h (class source_lines_range): New class.
13865         (print_source_lines): New declaration.
13866
13867 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13868
13869         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13870
13871 2019-01-08  Tom Tromey  <tom@tromey.com>
13872             Simon Marchi  <simon.marchi@ericsson.com>
13873
13874         PR gdb/24060
13875         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13876         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13877         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13878         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13879         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13880         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13881
13882 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13883
13884         * source.c (select_source_symtab): Move header comment to
13885         declaration in source.h.
13886         (forget_cached_source_info_for_objfile): Likewise.
13887         (forget_cached_source_info): Likewise.
13888         (identify_source_line): Likewise.
13889         * source.h (identify_source_line): Move declaration from symtab.h
13890         and add comment from source.c
13891         (print_source_lines): Likewise.
13892         (forget_cached_source_info_for_objfile): Likewise.
13893         (forget_cached_source_info): Likewise.
13894         (select_source_symtab): Likewise.
13895         (enum print_source_lines_flag): Move definition from symtab.h.
13896         * symtab.h (identify_source_line): Move declaration to source.h.
13897         (print_source_lines): Likewise.
13898         (forget_cached_source_info_for_objfile): Likewise.
13899         (forget_cached_source_info): Likewise.
13900         (select_source_symtab): Likewise.
13901         (enum print_source_lines_flag): Move definition to source.h.
13902         * tui/tui-hooks.c: Add 'source.h' include.
13903
13904 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13905
13906         * source.c (print_source_lines_base): Handle requests to print
13907         reverse line number sequences, and guard against empty lines
13908         string.
13909
13910 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13911
13912         * source.c (print_source_lines_base): Fix skip of '\r' if next
13913         character is '\n'.
13914
13915 2019-01-06  Tom Tromey  <tom@tromey.com>
13916
13917         * c-exp.y (struct c_parse_state) <macro_original_text,
13918         expansion_obstack>: New member.
13919         (macro_original_text, expansion_obstack): Remove globals.
13920         (scan_macro_expansion, scanning_macro_expansion)
13921         (finished_macro_expansion): Update.
13922         (scan_macro_cleanup): Remove.
13923         (yylex, c_parse): Update.
13924
13925 2019-01-06  Tom Tromey  <tom@tromey.com>
13926
13927         * c-exp.y (struct c_parse_state) <strings>: New member.
13928         (operator_stoken): Update.
13929
13930 2019-01-06  Tom Tromey  <tom@tromey.com>
13931
13932         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13933         (union type_stack_elt) <typelist_val>: Now a pointer to
13934         std::vector.
13935         (type_stack_cleanup): Don't declare.
13936         (push_typelist): Update.
13937         * parse.c (pop_typelist): Return a std::vector.
13938         (push_typelist): Take a std::vector.
13939         (follow_types): Update.  Do not free args.
13940         (type_stack_cleanup): Remove.
13941         * c-exp.y (struct c_parse_state): New.
13942         (cpstate): New global.
13943         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13944         (nonempty_typelist): Update.
13945         (func_mod): Create a new vector.
13946         (c_parse): Create a c_parse_state.
13947         (check_parameter_typelist): Do not delete params.
13948         (function_method): Update.  Do not delete type_list.
13949
13950 2019-01-06  Tom Tromey  <tom@tromey.com>
13951
13952         PR gdb/28155:
13953         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13954         check_typedef.
13955         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13956         (print_return_value): Likewise.
13957
13958 2019-01-05  Tom Tromey  <tom@tromey.com>
13959
13960         * contrib/cleanup_check.py: Remove.
13961         * contrib/gcc-with-excheck: Remove.
13962         * contrib/exsummary.py: Remove.
13963         * contrib/excheck.py: Remove.
13964
13965 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13966
13967         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13968         NULL. Initialize tpprev to NULL instead of assigning it
13969         to NULL on the next statement.
13970         * windows-nat.c (windows_delete_thread): Remove check for
13971         main_thread_id before printing thread exit notifications.
13972         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13973         Remove thread ID check against main_thread_id.
13974         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13975         windows_delete_thread.
13976         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13977
13978 2019-01-04  Tom Tromey  <tom@tromey.com>
13979
13980         * compile/compile.c (_initialize_compile): Use upper case for
13981         metasyntactic variables.
13982         * symmisc.c (_initialize_symmisc): Use upper case for
13983         metasyntactic variables.
13984         * psymtab.c (_initialize_psymtab): Use upper case for
13985         metasyntactic variables.
13986         * demangle.c (demangle_command): Use upper case for metasyntactic
13987         variables.
13988         (_initialize_demangler): Likewise.
13989         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13990         variables.
13991
13992 2019-01-03  Tom Tromey  <tom@tromey.com>
13993
13994         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13995
13996 2019-01-03  Tom Tromey  <tom@tromey.com>
13997
13998         * python/py-symtab.c (salpy_str): Update.
13999         (struct salpy_sal_object) <symtab>: Now a PyObject.
14000         (salpy_dealloc): Update.
14001         (del_objfile_sal): Use gdbpy_ref.
14002
14003 2019-01-03  Tom Tromey  <tom@tromey.com>
14004
14005         * python/py-type.c (convert_field): Use new_reference.  Return
14006         gdbpy_ref.
14007         (make_fielditem): Return gdbpy_ref.
14008         (typy_fields): Update.
14009         (typy_getitem): Update.
14010         (field_name): Return gdbpy_ref.  Use new_reference.
14011         (typy_iterator_iternext): Update.
14012
14013 2019-01-03  Tom Tromey  <tom@tromey.com>
14014
14015         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14016
14017 2019-01-03  Tom Tromey  <tom@tromey.com>
14018
14019         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14020         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14021         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14022         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14023         (pspy_set_type_printers): Likewise.
14024         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14025         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14026         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14027         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14028         (objfpy_set_type_printers): Likewise.
14029
14030 2019-01-03  Tom Tromey  <tom@tromey.com>
14031
14032         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14033         (gdbpy_print_stack): Use gdbpy_err_fetch.
14034         * python/python-internal.h (class gdbpy_err_fetch): New class.
14035         (class gdbpy_enter) <m_error_type, m_error_value,
14036         m_error_traceback>: Remove.
14037         <m_error>: New member.
14038         (gdbpy_exception_to_string): Don't declare.
14039         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14040         * python/py-value.c (convert_value_from_python): Use
14041         gdbpy_err_fetch.
14042         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14043         gdbpy_exception_to_string.
14044         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14045         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14046         gdbpy_err_fetch.
14047
14048 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14049
14050         * linux-nat.c (delete_lwp_cleanup): Delete.
14051         (struct lwp_deleter): New struct.
14052         (lwp_info_up): New typedef.
14053         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14054         lwp_info_up.
14055
14056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14057
14058         * linux-fork.c (class scoped_switch_fork_info): New class.
14059         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14060
14061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14062
14063         * valops.c (find_overload_match): Remove use of null_cleanup, and
14064         calls to do_cleanups.
14065
14066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14067
14068         * compile/compile-cplus-types.c
14069         (compile_cplus_instance::decl_name): Handle changes to
14070         cp_func_name.
14071         * cp-support.c (cp_func_name): Update header comment, update
14072         return type.
14073         * cp-support.h (cp_func_name): Update return type in declaration.
14074         * valops.c (find_overload_match): Move temp_func local to top
14075         level of function and change its type.  Use temp_func to hold and
14076         delete temporary string obtained from cp_func_name.
14077
14078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14079
14080         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14081         gdb::char_vector, remove cleanup, and update uses of `msg`.
14082
14083 2019-01-03  Jim Wilson  <jimw@sifive.com>
14084
14085         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14086
14087 2019-01-02  Tom Tromey  <tom@tromey.com>
14088
14089         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14090         (tdesc_parse_xml): Remove cleanups.
14091         * target-descriptions.h (make_cleanup_free_target_description):
14092         Don't declare.
14093         (target_desc_deleter): New struct.
14094         (target_desc_up): New typedef.
14095         * target-descriptions.c (target_desc_deleter::operator()): Rename
14096         from free_target_description.
14097         (make_cleanup_free_target_description): Remove.
14098
14099 2019-01-02  Tom Tromey  <tom@tromey.com>
14100
14101         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14102         constructor, destructor.
14103         (linespec_parser): Remove typedef.
14104         (~linespec_parser): Rename from linespec_parser_delete.
14105         (linespec_lex_to_end, linespec_complete_label)
14106         (linespec_complete): Update.
14107         (decode_line_full): Remove cleanups.
14108         (decode_line_1): Update.
14109
14110 2019-01-02  Tom Tromey  <tom@tromey.com>
14111
14112         * python/python-internal.h (inferior_to_inferior_object): Change
14113         return type.
14114         * python/py-exitedevent.c (create_exited_event_object): Update.
14115         * python/py-inferior.c (inferior_to_inferior_object): Return
14116         gdbpy_ref.
14117         (python_new_inferior, python_inferior_deleted)
14118         (thread_to_thread_object, delete_thread_object)
14119         (build_inferior_list, gdbpy_selected_inferior): Update.
14120         * python/py-infthread.c (create_thread_object): Update.  Also fail
14121         if inferior_to_inferior_object fails.
14122
14123 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14124
14125         * inferior.h (class inferior) <displaced_step_state>: New field.
14126         * infrun.h (struct displaced_step_state): Move here from
14127         infrun.c.  Initialize fields, add constructor.
14128         <inf>: Remove field.
14129         <reset>: New method.
14130         * infrun.c (struct displaced_step_inferior_state): Move to
14131         infrun.h.
14132         (displaced_step_inferior_states): Remove.
14133         (get_displaced_stepping_state): Adust.
14134         (displaced_step_in_progress_any_inferior): Adjust.
14135         (displaced_step_in_progress_thread): Adjust.
14136         (displaced_step_in_progress): Adjust.
14137         (add_displaced_stepping_state): Remove.
14138         (get_displaced_step_closure_by_addr): Adjust.
14139         (remove_displaced_stepping_state): Remove.
14140         (infrun_inferior_exit): Call displaced_step_state.reset.
14141         (use_displaced_stepping): Don't check for NULL.
14142         (displaced_step_prepare_throw): Call
14143         get_displaced_stepping_state.
14144         (displaced_step_fixup): Don't check for NULL.
14145         (prepare_for_detach): Don't check for NULL.
14146
14147 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14148
14149         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14150          in case of call that did not complete.
14151
14152 2019-01-02  Andrey Utkin  <autkin@undo.io>
14153
14154         * symfile.c (find_separate_debug_file): Fix search of debug files for
14155         remote debuggee.
14156
14157 2019-01-02  Tom Tromey  <tom@tromey.com>
14158
14159         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14160         indentation.
14161         * python/py-frame.c (frapy_older): Remove cast.
14162         (frapy_newer): Likewise.
14163         * python/py-breakpoint.c (local_setattro): Remove cast.
14164         * python/py-arch.c (archpy_name): Remove local variable.
14165         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14166
14167 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14168
14169         * unittests/basic_string_view/element_access/char/empty.cc:
14170         Fix year range in copyright header.
14171
14172 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14173
14174         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14175         Delete.
14176         <operator==>: Update with for removed field.
14177         <hash>: Likewise.
14178         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14179         <isa_features>: ...this.
14180         <abi_features>: New field.
14181         (riscv_isa_flen): Update comment.
14182         (riscv_abi_xlen): New declaration.
14183         (riscv_abi_flen): New declaration.
14184         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14185         isa_features.
14186         (riscv_abi_xlen): New function.
14187         (riscv_isa_flen): Update to get answer from isa_features.
14188         (riscv_abi_flen): New function.
14189         (riscv_has_fp_abi): Update to get answer from abi_features.
14190         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14191         xlen and flen.
14192         (riscv_call_info) <xlen, flen>: Update comment.
14193         (riscv_call_arg_struct): Remove invalid assertions
14194         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14195         is removed.
14196         (riscv_gdbarch_init): Gather isa features and abi features
14197         separately, ensure both match on the gdbarch when reusing an old
14198         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14199         a target with 64-bit float hardware.
14200
14201 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14202
14203         * source.c (search_command_helper): Stop reverse search
14204         when line 1 has been searched.
14205
14206 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14207
14208         * record-full.c (record_full_base_target::close): Rewrite
14209         record_full_core_buf_list free logic.
14210
14211 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14212
14213         * break-catch-syscall.c (print_one_catch_syscall): xfree
14214         the last text.
14215
14216 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14217
14218         * top.c (print_gdb_version): Update Copyright year in version
14219         message.
14220
14221 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14222
14223         Update copyright year range in all GDB files.
14224
14225 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14226
14227         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14228
14229 For older changes see ChangeLog-2018.
14230 \f
14231 Local Variables:
14232 mode: change-log
14233 left-margin: 8
14234 fill-column: 74
14235 version-control: never
14236 coding: utf-8
14237 End:
14238