gdb/ChangeLog

   1 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * NEWS: Expand the Pointer Authentication entry.
   4         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
   5         (aarch64_frame_unmask_lr): ... to this.
   6         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
   7         Call aarch64_frame_unmask_lr.
   8         * frame.c (struct frame_info): Add "masked" variable.
   9         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
  10         (fprint_frame): Check for masked pc.
  11         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
  12         declarations.
  13         * python/py-framefilter.c (py_print_frame): Check for masked pc.
  14         * stack.c (print_frame): Check for masked pc.
  15
  16 2019-08-06  Tom Tromey  <tom@tromey.com>
  17
  18         * stabsread.c (patch_block_stabs, read_one_struct_field)
  19         (read_enum_type): Use obstack_strndup.
  20         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
  21         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
  22         * dwarf2read.c (guess_full_die_structure_name)
  23         (anonymous_struct_prefix): Use obstack_strndup.
  24         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
  25         * c-exp.y (yylex): Use obstack_strndup.
  26         * ada-exp.y (write_object_renaming, write_ambiguous_var)
  27         (write_var_or_type): Use obstack_strndup.
  28
  29 2019-08-06  Tom Tromey  <tom@tromey.com>
  30
  31         * symfile.c (reread_symbols): Use obstack_strdup.
  32         * stabsread.c (read_type): Use obstack_strdup.
  33         * gdb_obstack.h (obstack_strdup): New overload.
  34         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
  35         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
  36         (dwarf2_canonicalize_name): Use obstack_strdup.
  37         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
  38         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
  39         Use obstack_strdup.
  40
  41 2019-08-06  Tom Tromey  <tom@tromey.com>
  42
  43         * gdb_obstack.h (obstack_strdup): Define.
  44         * gdb_obstack.c (obstack_strdup): Don't define.
  45
  46 2019-08-06  Tom Tromey  <tom@tromey.com>
  47
  48         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
  49         obstack_strdup.
  50         * typeprint.c (typedef_hash_table::find_global_typedef): Use
  51         obstack_strdup.
  52         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
  53         * stabsread.c (common_block_start): Use obstack_strdup.
  54         * objfiles.c (set_objfile_main_name, objfile): Use
  55         obstack_strdup.
  56         * namespace.c (add_using_directive): Use obstack_strdup.
  57         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
  58         * jit.c (finalize_symtab): Use obstack_strdup.
  59         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
  60         (guess_partial_die_structure_name, partial_die_info::fixup)
  61         (dwarf2_name): Use obstack_strdup.
  62         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
  63         obstack_strdup.
  64         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
  65         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
  66         obstack_strdup.
  67         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
  68
  69 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  70
  71         * unittests/help-doc-selftests.c: New file.
  72         * Makefile.in: Add the new file.
  73
  74 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  75
  76         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
  77         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
  78         the full first line, except when FOR_VALUE_PREFIX.  In this case,
  79         the trailing '.' is not output, and the first character is uppercased.
  80         (print_help_for_command): Update call to print_doc_line.
  81         (print_doc_of_command): Likewise.
  82         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
  83         * cli/cli-option.c (append_indented_doc): Do not append newline.
  84         (build_help_option): Append newline after first appended_indented_doc
  85         only if a second call is done.
  86         (build_help): Append 2 new lines before each option, except the first
  87         one.
  88         * compile/compile.c (_initialize_compile): Add new lines after
  89         %OPTIONS%, when not at the end of the help.
  90         Change help doc or code
  91         producing the help doc to respect the invariants.
  92         * maint-test-options.c (_initialize_maint_test_options): Likewise.
  93         Also removed the new line after 'Options:', as all other commands
  94         do not put an empty line between 'Options:' and the first option.
  95         * printcmd.c (_initialize_printcmd): Likewise.
  96         * stack.c (_initialize_stack): Likewise.
  97         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
  98         incorrectly telling COMMAND is optional.
  99         * ada-lang.c (_initialize_ada_language): Change help doc or code
 100         producing the help doc to respect the invariants.
 101         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 102         * breakpoint.c (_initialize_breakpoint): Likewise.
 103         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 104         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 105         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 106         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 107         _initialize_cli_style): Likewise.
 108         * corelow.c (core_target_info): Likewise.
 109         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 110         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 111         * filesystem.c (_initialize_filesystem): Likewise.
 112         * frame.c (_initialize_frame): Likewise.
 113         * gnu-nat.c (add_task_commands): Likewise.
 114         * infcall.c (_initialize_infcall): Likewise.
 115         * infcmd.c (_initialize_infcmd): Likewise.
 116         * interps.c (_initialize_interpreter): Likewise.
 117         * language.c (_initialize_language): Likewise.
 118         * linux-fork.c (_initialize_linux_fork): Likewise.
 119         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 120         * maint.c (_initialize_maint_cmds): Likewise.
 121         * memattr.c (_initialize_mem): Likewise.
 122         * printcmd.c (_initialize_printcmd): Likewise.
 123         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 124         _RegEx): Likewise.
 125         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 126         * record-btrace.c (_initialize_record_btrace): Likewise.
 127         * record-full.c (_initialize_record_full): Likewise.
 128         * record.c (_initialize_record): Likewise.
 129         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 130         * regcache.c (_initialize_regcache): Likewise.
 131         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 132         _initialize_remote): Likewise.
 133         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 134         * serial.c (_initialize_serial): Likewise.
 135         * skip.c (_initialize_step_skip): Likewise.
 136         * source.c (_initialize_source): Likewise.
 137         * stack.c (_initialize_stack): Likewise.
 138         * symfile.c (_initialize_symfile): Likewise.
 139         * symtab.c (_initialize_symtab): Likewise.
 140         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 141         * top.c (init_main): Likewise.
 142         * tracefile-tfile.c (tfile_target_info): Likewise.
 143         * tracepoint.c (_initialize_tracepoint): Likewise.
 144         * tui/tui-win.c (_initialize_tui_win): Likewise.
 145         * utils.c (add_internal_problem_command): Likewise.
 146         * valprint.c (value_print_option_defs): Likewise.
 147
 148 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 149
 150         PR build/24886
 151         * configure.ac: Drop enable-libmcheck support.
 152         * configure, config.in: Rebuild.
 153         * libmcheck.m4: Remove.
 154         * acinclude.m4: Don't include it.
 155         * Makefile.in: Don't distribute it.
 156         * top.c (print_gdb_configuration): Don't mention it.
 157
 158 2019-08-06  Tom Tromey  <tom@tromey.com>
 159
 160         * utils.c (set_output_style): Sometimes pass stream to
 161         emit_style_escape.
 162         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 163         * record-btrace.c (btrace_insn_history): Update.
 164         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 165         method.
 166         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 167         Update initializers.
 168         <m_uiout>: New field.
 169         <m_di>: Move lower.
 170         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 171         Remove "uiout" parameter.
 172         (dump_insns): Update.
 173         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 174         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 175
 176 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 177
 178         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 179         (error_in_psymtab_expansion): Likewise.
 180         (lookup_symbol_via_quick_fns): Likewise.
 181         (basic_lookup_transparent_type_quick): Likewise.
 182         (basic_lookup_transparent_type_1): Likewise.
 183
 184 2019-08-06  Tom Tromey  <tromey@adacore.com>
 185
 186         * source.c (last_source_error): Now bool.
 187         (print_source_lines_base): Make "noprint" bool.  Only open
 188         source file when last_source_visited changes.
 189
 190 2019-08-06  Tom Tromey  <tromey@adacore.com>
 191
 192         * annotate.c (annotate_source_line): Use g_source_cache.
 193         * source-cache.c (source_cache::get_plain_source_lines): Change
 194         parameters.  Populate m_offset_cache.
 195         (source_cache::ensure): New method.
 196         (source_cache::get_line_charpos): New method.
 197         (extract_lines): Move lower.  Change parameters.
 198         (source_cache::get_source_lines): Move lower.
 199         * source-cache.h (class source_cache): Update comment.
 200         <get_line_charpos>: New method.
 201         <get_source_lines>: Update comment.
 202         <clear>: Clear m_offset_cache.
 203         <get_plain_source_lines>: Change parameters.
 204         <ensure>: New method
 205         <m_offset_cache>: New member.
 206         * source.c (forget_cached_source_info_for_objfile): Update.
 207         (info_source_command): Use g_source_cache.
 208         (find_source_lines, open_source_file_with_line_charpos): Remove.
 209         (print_source_lines_base, search_command_helper): Use g_source_cache.
 210         * source.h (open_source_file_with_line_charpos): Don't declare.
 211         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 212         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 213         Use g_source_cache.
 214
 215 2019-08-06  Tom Tromey  <tromey@adacore.com>
 216
 217         * source-cache.c (source_cache::get_plain_source_lines):
 218         Remove "first_line" and "last_line" parameters.
 219         (source_cache::get_source_lines): Cache plain text.
 220         * source-cache.h (class source_cache)
 221         <get_plain_source_lines>: Update.
 222
 223 2019-08-06  Tom Tromey  <tromey@adacore.com>
 224
 225         * source-cache.c (extract_lines): No longer a method.
 226         Changed type of parameter.  Include final newline.
 227         (selftests::extract_lines_test): New function.
 228         (_initialize_source_cache): Likewise.
 229         * source-cache.h (class source_cache)
 230         <extract_lines>: Don't declare.
 231
 232 2019-08-06  Tom Tromey  <tromey@adacore.com>
 233
 234         * breakpoint.c (init_breakpoint_sal): Update.
 235         (breakpoint): Update.
 236         * breakpoint.h (struct breakpoint) <filter>: Now a
 237         unique_xmalloc_ptr.
 238
 239 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 240
 241         * NEWS: Mention dictionary access on blocks.
 242         * python/py-block.c (blpy_getitem): New function.
 243         (block_object_as_mapping): New struct.
 244         (block_object_type): Use new struct for tp_as_mapping field.
 245
 246 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 247
 248         * objfiles.h (objfile): Add a comment describing partial symbols.
 249
 250 2019-08-05  Tom Tromey  <tromey@adacore.com>
 251
 252         * compile/compile.c (_initialize_compile): Use _(), not N_().
 253         * thread.c (_initialize_thread): Use _(), not N_().
 254         * stack.c (_initialize_stack): Use _(), not N_().
 255         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 256
 257 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 258
 259         * dwarf2read.c (struct dw2_symtab_iterator):
 260         <want_specific_block>: Remove.
 261         <block_index>: Change type to gdb::optional.
 262         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 263         change type of BLOCK_INDEX parameter to gdb::optional.
 264         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 265         (dw2_lookup_symbol): Don't pass argument for
 266         WANT_SPECIFIC_BLOCK.
 267         (dw2_expand_symtabs_for_function): Don't pass argument for
 268         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 269         (class dw2_debug_names_iterator)
 270         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 271         parameter, change BLOCK_INDEX type to gdb::optional.
 272         <m_want_specific_block>: Remove.
 273         <m_block_index>: Change type to gdb::optional.
 274         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 275         gdb::optional.  Re-write in function of gdb::optional.
 276         (dw2_debug_names_lookup_symbol): Don't pass argument for
 277         WANT_SPECIFIC_BLOCK.
 278         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 279         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 280         BLOCK_INDEX.
 281
 282 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 283
 284         * NEWS: Mention changes to "info sources" command.
 285
 286 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 287
 288         * symtab.c (filename_partial_match_opts): New struct type.
 289         (struct output_source_filename_data): New members
 290         regexp, c_regexp, partial_match.
 291         (output_source_filename): Use new members to decide to print file.
 292         (info_sources_option_defs): New variable.
 293         (make_info_sources_options_def_group, print_info_sources_header,
 294         info_sources_command_completer):
 295         New functions.
 296         (info_sources_command): Read new optional arguments.
 297         (_initialize_symtab): Update info sources help.
 298
 299 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 300
 301         * ada-lang.c (exception_support_info_v0): Renamed from...
 302         (default_exception_support_info): ... this.  Create new
 303         definition for v1.
 304         (ada_has_this_exception_support): Look up catch_handlers_sym.
 305         (ada_exception_support_info_sniffer): Try v0 after default.
 306
 307 2019-08-01  Tom Tromey  <tromey@adacore.com>
 308
 309         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 310         gdbarch.h.
 311
 312 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 313
 314         * s12z-tdep.c: Fix include path for s12z-opc.h.
 315
 316 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 317
 318         * NEWS: Require GNU make 3.82.
 319
 320 2019-07-16  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 323         declare.
 324
 325 2019-07-30  Tom Tromey  <tromey@adacore.com>
 326
 327         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 328
 329 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 330
 331         * printcmd.c (print_address_symbolic): Print negative offsets.
 332         (build_address_symbolic): Force signed arithmetic when computing
 333         offset.
 334
 335 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 336
 337         PR/24474: Add a function to lookup static variables.
 338         * NEWS: Mention this new function.
 339         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 340         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 341         * python/python.c (python_GdbMethods): Add new function.
 342
 343 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 344
 345         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 346         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 347         (objfpy_lookup_static_symbol): New function.
 348         (objfile_object_methods): Add new functions.
 349
 350 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 351
 352         * NEWS: Mention 'set|show print frame-info'.  Mention new
 353         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 354         backtrace argument.  Mention that python frame filtering code
 355         is now consistent with what 'backtrace' command prints.
 356
 357 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 358
 359         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 360         comments.
 361         (print_frame_info_auto, print_frame_info_source_line,
 362         print_frame_info_location, print_frame_info_source_and_location,
 363         print_frame_info_location_and_address, print_frame_info_short_location):
 364         New declarations.
 365         (struct frame_print_options): New member print_frame_info.
 366         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 367         * stack.h (get_user_print_what_frame_info): New declaration.
 368         (frame_show_address): New declaration.
 369         * stack.c (print_frame_arguments_choices): New value 'presence'.
 370         (print_frame_info_auto, print_frame_info_source_line,
 371         print_frame_info_location, print_frame_info_source_and_location,
 372         print_frame_info_location_and_address, print_frame_info_short_location,
 373         print_frame_info_choices, print_frame_info_print_what): New definitions.
 374         (print_frame_args): Only print dots for args if print frame-arguments
 375         is 'presence'.
 376         (frame_print_option_defs): New element for "frame-info".
 377         (get_user_print_what_frame_info): New function.
 378         (frame_show_address): Make non static.  Move comment to stack.h.
 379         (print_frame_info_to_print_what): New function.
 380         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 381         to decide what to print.
 382         (backtrace_command_1): Handle the new print_frame_arguments_presence
 383         value.
 384         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 385         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 386         (py_print_frame): In non-mi mode, use LOCATION as default for
 387         print_what, similarly to frame information printed directly by
 388         backtrace command. Handle frame-info user option in non MI mode.
 389
 390 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 391
 392         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 393         Add case for debugging 32-bit target on 64-bit host.  Revise
 394         comment.
 395
 396 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 397
 398         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 399         instead of find_function_entry_range_from_pc.
 400
 401 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 402
 403         * stack.c (find_frame_funname): Remove code which preferred
 404         minsym over symtab sym in "certain pathological cases".
 405
 406         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 407         parameter.  Change type of "do_demangle" to bool.
 408         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 409         Pass suitable "prefer_sym_over_minsym" flag to
 410         build_address_symbolic().  Don't output "+" for negative offsets.
 411         * printcmd.c (print_address_symbolic): Update invocation of
 412         build_address_symbolic to include a "prefer_sym_over_minsym"
 413         flag.
 414         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 415         Restrict cases in which use of minimal symbol is preferred to that
 416         of a found symbol.  Update comments.
 417
 418         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 419         for entry pc when entry pc is out of range for that FDE.
 420
 421 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 422
 423         PR gdb/24839:
 424         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 425         type.
 426
 427 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 428
 429         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 430         this function's Python signature.
 431
 432
 433 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 434
 435         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 436         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 437         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 438         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 439         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 440
 441
 442 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 443
 444         * h8300-tdep.c (h8300_register_name_common): New.
 445         h8300_register_name): Use h8300_register_name_common.
 446         (h8300s_register_name): Likewise.
 447         (h8300sx_register_name): Likewise.
 448         (h8300h_register_nam): New.
 449         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 450
 451
 452 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 453
 454         * arm-tdep.c (arm_skip_cmse_entry): New function.
 455         (arm_is_sgstubs_section): New function.
 456         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 457
 458 2019-07-22  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 461         Don't self-assign.
 462
 463 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 464
 465         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 466         type_print.
 467
 468 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 469
 470         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 471         so that GDB doesn't match any msymbols when searching in the
 472         TYPES_DOMAIN.
 473         (print_symbol_info): Print using typedef_print or type_print based
 474         on the type of the symbol.  Add updated FIXME comment moved from...
 475         (_initialize_symtab): ... move and update FIXME comment to above.
 476
 477 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 478
 479         * NEWS: Mention adding -q option to "info types".
 480         * symtab.c (struct info_types_options): New struct.
 481         (info_types_options_defs): New variable.
 482         (make_info_types_options_def_group): New function.
 483         (info_types_command): Use gdb::option framework to parse options.
 484         (info_types_command_completer): New function.
 485         (_initialize_symtab): Extend the help text on "info types" and
 486         register command completer.
 487
 488 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 489
 490         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 491         (lookup_symbol_in_objfile): Change int to block_enum and add a
 492         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 493
 494 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 495
 496         * MAINTAINERS (Write After Approval): Add self.
 497
 498 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 501         instruction to the dummy code region.
 502
 503 2019-07-19  Tom Tromey  <tromey@adacore.com>
 504
 505         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 506         (ARGSUSED, PARAMS, __func__): Remove rules.
 507
 508 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 509
 510         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 511         * features/arm/arm-with-iwmmxt.c: Remove.
 512         * features/arm/arm-with-iwmmxt.xml: Remove.
 513         * features/arm/arm-with-m-fpa-layout.c: Remove.
 514         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 515         * features/arm/arm-with-m-vfp-d16.c: Remove.
 516         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 517         * features/arm/arm-with-m.c: Remove.
 518         * features/arm/arm-with-m.xml: Remove.
 519         * features/arm/arm-with-neon.c: Remove.
 520         * features/arm/arm-with-neon.xml: Remove.
 521         * features/arm/arm-with-vfpv2.c: Remove.
 522         * features/arm/arm-with-vfpv2.xml: Remove.
 523         * features/arm/arm-with-vfpv3.c: Remove.
 524         * features/arm/arm-with-vfpv3.xml: Remove.
 525
 526 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 527
 528         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 529
 530 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 531
 532         * arch/aarch32.c (aarch32_create_target_description): Create
 533         target descriptions using features.
 534         * arch/arm.c (arm_create_target_description)
 535         (arm_create_mprofile_target_description): Likewise.
 536         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 537
 538 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 539
 540         * Makefile.in: Add new files.
 541         * aarch32-tdep.c: New file.
 542         * aarch32-tdep.h: New file.
 543         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 544         Call aarch32_read_description.
 545         * arch/aarch32.c: New file.
 546         * arch/aarch32.h: New file.
 547         * arch/arm.c (arm_create_target_description)
 548         (arm_create_mprofile_target_description): New function.
 549         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 550         (arm_create_target_description)
 551         (arm_create_mprofile_target_description): New declaration.
 552         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 553         read_description functions.
 554         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 555         Likewise.
 556         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 557         * arm-tdep.c (tdesc_arm_list): New variable.
 558         (arm_register_g_packet_guesses): Call create description functions.
 559         (arm_read_description) (arm_read_mprofile_description): New
 560         function.
 561         * arm-tdep.h (arm_read_description)
 562         (arm_read_mprofile_description): Add declaration.
 563         * configure.tgt: Add new files.
 564
 565 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 566
 567         * top.c (new_ui_command): Open specified terminal just once.
 568
 569 2019-07-18  Tom Tromey  <tromey@adacore.com>
 570
 571         * symtab.c (main_name): Constify return type.
 572         * symfile.c (set_initial_language): Update.
 573         * symtab.h (main_name): Constify return type.
 574
 575 2019-07-17  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-winsource.c (tui_update_source_window)
 578         (tui_update_source_window_as_is)
 579         (tui_update_source_windows_with_line): Remove return.
 580         * tui/tui-disasm.c (tui_show_disassem)
 581         (tui_show_disassem_and_update_source): Remove return.
 582         * tui/tui.c (tui_reset): Remove return.
 583         * tui/tui-wingeneral.c
 584         (tui_check_and_display_highlight_if_needed): Remove return.
 585
 586 2019-07-17  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 589
 590 2019-07-17  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-winsource.h (struct tui_exec_info_window)
 593         (struct tui_source_window_base): Move from tui-data.h.
 594         * tui/tui-winsource.c: Move many method definitions from
 595         elsewhere.  Remove "structuring" comments.
 596         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 597         (tui_source_window_base::refresh_window): Move to
 598         tui-winsource.c.
 599         * tui/tui-win.c (tui_source_window_base::refresh_all)
 600         (tui_source_window_base::update_tab_width)
 601         (tui_source_window_base::set_new_height)
 602         (tui_source_window_base::do_make_visible_with_new_height): Move to
 603         tui-winsource.c.
 604         * tui/tui-source.h: Update.
 605         * tui/tui-source.c (tui_source_window_base::reset): Move to
 606         tui-winsource.c.
 607         * tui/tui-disasm.h: Update.
 608         * tui/tui-data.h (struct tui_exec_info_window): Move to
 609         tui-winsource.h.
 610         (struct tui_source_window_base): Likewise.
 611         * tui/tui-data.c (tui_source_window_base::clear_detail)
 612         (tui_source_window_base, ~tui_source_window_base): Move to
 613         tui-winsource.c.
 614
 615 2019-07-17  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-win.c (tui_resize_all)
 618         (tui_source_window_base::update_tab_width)
 619         (tui_adjust_win_heights): Update.
 620         (tui_win_info::make_invisible_and_set_new_height): Rename from
 621         make_invisible_and_set_new_height.
 622         * tui/tui-data.h (struct tui_win_info)
 623         <make_invisible_and_set_new_height>: New method.
 624
 625 2019-07-17  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui.c: Update.
 628         * tui/tui-source.h (struct tui_source_window): Move from
 629         tui-data.h.
 630         * tui/tui-layout.c: Update.
 631         * tui/tui-disasm.c: Update.
 632         * tui/tui-data.h (struct tui_source_window): Move to
 633         tui-source.h.
 634
 635 2019-07-17  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 638         tui-data.h.
 639         * tui/tui-data.h (struct tui_disasm_window): Move to
 640         tui-disasm.h.
 641
 642 2019-07-17  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-regs.h (struct tui_data_item_window): Move from
 645         tui-data.h.
 646         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 647         * tui/tui-data.h (struct tui_data_item_window): Move to
 648         tui-regs.h.
 649         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 650
 651 2019-07-17  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui.c: Update.
 654         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 655         (tui_cmd_window::max_height): Move to tui-command.c.
 656         * tui/tui-layout.c: Update.
 657         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 658         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 659         tui-command.c.
 660         * tui/tui-command.h (struct tui_cmd_window): Move from
 661         tui-data.h.
 662         * tui/tui-command.c: Remove "structuring" comments.
 663         (tui_cmd_window::clear_detail)
 664         (tui_cmd_window::do_make_visible_with_new_height)
 665         (tui_cmd_window::max_height): Move from elsewhere.
 666
 667 2019-07-17  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 670         Now static.
 671         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 672         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 673
 674 2019-07-17  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui.c: Update.
 677         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 678         tui-regs.c.
 679         * tui/tui-windata.h: Remove file.
 680         * tui/tui-windata.c: Remove file.
 681         * tui/tui-win.c (tui_data_window::set_new_height)
 682         (tui_data_window::do_make_visible_with_new_height): Move to
 683         tui-regs.c.
 684         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 685         * tui/tui-regs.c: Remove "structuring" comments.
 686         (tui_data_window::first_data_item_displayed)
 687         (tui_data_window::delete_data_content_windows)
 688         (tui_data_window::erase_data_content)
 689         (tui_data_window::display_all_data)
 690         (tui_data_window::refresh_all)
 691         (tui_data_window::do_scroll_vertical)
 692         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 693         (tui_data_window::do_make_visible_with_new_height)
 694         (tui_data_window::refresh_window): Move from elsewhere.
 695         (_initialize_tui_regs): Move to end of file.
 696         * tui/tui-layout.c: Update.
 697         * tui/tui-hooks.c: Update.
 698         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 699         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 700         tui-regs.c.
 701         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 702
 703 2019-07-17  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 706         seen.
 707
 708 2019-07-17  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-win.c (tui_source_window_base::set_new_height)
 711         (tui_source_window_base::do_make_visible_with_new_height): Use
 712         m_has_locator field directly.
 713         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 714         method.
 715         (struct tui_source_window_base) <has_locator>: Likewise.
 716
 717 2019-07-17  Tom Tromey  <tom@tromey.com>
 718
 719         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 720         Don't declare.
 721         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 722         Remove.
 723         * tui/tui-win.c (tui_source_window_base::set_new_height)
 724         (tui_source_window_base::set_new_height)
 725         (make_invisible_and_set_new_height)
 726         (tui_source_window_base::do_make_visible_with_new_height)
 727         (tui_source_window_base::do_make_visible_with_new_height):
 728         Update.
 729         * tui/tui-layout.c (show_source_disasm_command, show_data)
 730         (show_source_or_disasm_and_command): Update.
 731         * tui/tui-layout.c (show_layout): Update.
 732
 733 2019-07-17  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-layout.c (make_data_window): Remove.
 736         (show_data): Unify creation and re-initialization cases.
 737
 738 2019-07-17  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-layout.c (make_source_window, make_disasm_window):
 741         Remove.
 742         (show_data): Unify creation and re-initialization cases.
 743
 744 2019-07-17  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-layout.c (make_command_window): Remove.
 747         (show_source_disasm_command, show_source_or_disasm_and_command):
 748         Unify creation and re-initialization cases.
 749
 750 2019-07-17  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 753         creation and re-initialization cases.
 754
 755 2019-07-17  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-regs.c (tui_get_register): Return void.
 758
 759 2019-07-17  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 762         Simplify.
 763
 764 2019-07-17  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 767         resetting.
 768
 769 2019-07-17  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 772         * tui/tui-regs.c (tui_reg_layout): New function.
 773         (tui_show_registers, tui_reg_command): Use it.
 774         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 775         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 776         parameters.
 777         (tui_layout_command): Remove.
 778
 779 2019-07-17  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-layout.h (tui/tui-layout): Return void.
 782         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 783
 784 2019-07-17  Tom Tromey  <tom@tromey.com>
 785
 786         * tui/tui-layout.c (show_source_disasm_command, show_data):
 787         Update.
 788         (reset_locator): Remove.
 789         (show_source_or_disasm_and_command): Update.
 790
 791 2019-07-17  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-source.c (tui_source_window_base::reset): Remove
 794         win_type parameter.
 795         * tui/tui-layout.c (make_command_window, make_source_window)
 796         (make_disasm_window, make_data_window)
 797         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 798         (reset_locator, show_source_or_disasm_and_command): Update.
 799         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 800         win_type parameter.
 801         (struct tui_source_window_base) <reset>: Likewise.
 802
 803 2019-07-17  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-layout.c (show_source_disasm_command): Use
 806         reset_locator.
 807         (reset_locator): New function.
 808         (init_and_make_win): Remove.
 809         (show_source_or_disasm_and_command): Use reset_locator.
 810
 811 2019-07-17  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 814         condition.
 815         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 816         Remove condition.
 817         * tui/tui-source.c (tui_source_window_base::reset): New method.
 818         * tui/tui-layout.c (make_command_window): Don't call
 819         init_and_make_win.
 820         (make_source_window, make_disasm_window): Don't call
 821         make_source_or_disasm_window.
 822         (make_data_window): Don't call init_and_make_win.  Change calling
 823         convention.
 824         (show_source_disasm_command, show_data): Simplify.
 825         (make_source_or_disasm_window): Remove.
 826         (show_source_or_disasm_and_command): Simplify.
 827         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 828         (struct tui_source_window_base) <reset>: Likewise.
 829         <execution_info>: Remove initializer.
 830         * tui/tui-data.c (tui_source_window_base): Initialize
 831         execution_info.
 832
 833 2019-07-17  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 836         variable.
 837
 838 2019-07-17  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui.c (tui_rl_other_window): Update.
 841         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 842         superclass method first.  Always iterate over regs_content.
 843         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 844         method.
 845         * tui/tui-win.c (tui_set_focus_command): Update.
 846
 847 2019-07-17  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-win.c (tui_set_focus_command): Rename from
 850         tui_set_focus.  Call tui_enable.
 851         (tui_set_focus_command): Remove.
 852
 853 2019-07-17  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 856         refresh_window.
 857         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 858         touchwin.
 859         (tui_data_window::refresh_window): Call refresh_window on data
 860         items.  Always call superclass refresh_window.
 861         (tui_win_info::refresh): Remove.
 862         (tui_source_window_base::refresh_window): Update.
 863         (tui_refresh_all): Update.
 864         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 865         refresh_window.
 866         (show_source_or_disasm_and_command): Likewise.
 867         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 868         (struct tui_source_window_base) <refresh>: Likewise.
 869
 870 2019-07-17  Tom Tromey  <tom@tromey.com>
 871
 872         * tui/tui-winsource.c (tui_clear_source_content)
 873         (tui_show_source_content): Update.
 874         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 875         whether content is empty.
 876         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 877         Remove.
 878
 879 2019-07-17  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 882         window's contents.
 883         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 884         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 885
 886 2019-07-17  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 889         (struct tui_data_item_window): Update.
 890
 891 2019-07-17  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 894         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 895         defines.
 896
 897 2019-07-17  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-winsource.h (tui_erase_source_content)
 900         (tui_clear_source_content): Remove "display_prompt" parameter.
 901         * tui/tui-winsource.c (tui_update_source_window_as_is)
 902         (tui_update_source_windows_with_addr): Update.
 903         (tui_clear_source_content): Remove "display_prompt" parameter.
 904         (tui_erase_source_content): Likewise.  Simplify.
 905         (tui_show_source_content): Update.
 906         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 907         * tui/tui-stack.c (tui_show_frame_info): Update.
 908         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 909         Remove defines.
 910
 911 2019-07-17  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 914         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 915         parameter.
 916         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 917         parameter.
 918
 919 2019-07-17  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-winsource.c (tui_clear_source_content)
 922         (tui_show_source_content, tui_show_exec_info_content)
 923         (tui_clear_exec_info_content): Update.
 924         * tui/tui-stack.c (tui_show_locator_content): Update.
 925         (tui_show_frame_info): Update.
 926         * tui/tui-source.h (tui_source_window): Don't declare.
 927         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 928         from tui_source_is_displayed.
 929         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 930         Remove field.
 931         (struct tui_source_window_base) <content_in_use>: New field.  Now
 932         bool.
 933         (struct tui_source_window) <showing_source_p>: New method.
 934         (TUI_SRC_WIN): Change cast.
 935         * tui/tui-data.c (tui_initialize_static_data): Update.
 936
 937 2019-07-17  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 940         location_matches_p.
 941         * tui/tui-source.c (tui_source_window::location_matches_p): New
 942         method.
 943         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 944         method.
 945         * tui/tui-data.h (struct tui_source_window_base)
 946         <location_matches_p>: New method.
 947         (struct tui_source_window, struct tui_disasm_window)
 948         <location_matches_p>: Likewise.
 949
 950 2019-07-17  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-win.c (tui_set_win_height_command): Rename from
 953         tui_set_win_height.
 954         (tui_set_win_height_command): Remove.
 955
 956 2019-07-17  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-source.c (tui_source_window): New constructor.  Add
 959         observer.
 960         (~tui_source_window): New destructor.
 961         (tui_source_window::style_changed): New method.
 962         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 963         (tui_attach_detach_observers): Update.
 964         * tui/tui-data.h (struct tui_source_window): Make constructor not
 965         inline.  Add destructor.
 966         (struct tui_source_window) <style_changed>: New method.
 967         <m_observable>: New member.
 968
 969 2019-07-17  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 972         * tui/tui-win.c (tui_resize_all): Fix typo.
 973
 974 2019-07-17  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 977         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 978         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 979         * tui/tui-win.c (window_name_completer): Use foreach.
 980         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 981         (update_tab_width): Likewise.
 982         * tui/tui-layout.c (show_layout): Update.
 983         * tui/tui-data.h (class tui_window_iterator): New.
 984         (struct all_tui_windows): New.
 985         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 986
 987 2019-07-17  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 990         parameter.  Don't reference globals.
 991         (tui_reg_command): Update.
 992
 993 2019-07-17  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-regs.c (tui_show_registers): Simplify.
 996
 997 2019-07-17  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-regs.c (tui_show_registers): Update.
1000         (tui_show_register_group): Add win_info parameter.
1001
1002 2019-07-17  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1005         Rename from tui_display_reg_element_at_line.
1006         (tui_data_window::display_registers_from_line): Update.
1007         * tui/tui-data.h (struct tui_data_window)
1008         <display_reg_element_at_line>: New method.
1009
1010 2019-07-17  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-regs.h (tui_display_registers_from)
1013         (tui_display_registers_from_line): Don't declare.
1014         * tui/tui-windata.c (tui_data_window::display_all_data)
1015         (tui_data_window::refresh_all)
1016         (tui_data_window::do_scroll_vertical): Update.
1017         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1018         from tui_display_registers_from.
1019         (tui_display_reg_element_at_line): Update.
1020         (tui_data_window::display_registers_from_line): Rename from
1021         tui_display_registers_from_line.
1022         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1023         display_registers_from_line>: New methods.
1024
1025 2019-07-17  Tom Tromey  <tom@tromey.com>
1026
1027         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1028         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1029         from tui_erase_data_content.
1030         (tui_data_window::display_all_data)
1031         (tui_data_window::refresh_all)
1032         (tui_data_window::do_scroll_vertical): Update.
1033         * tui/tui-regs.c (tui_show_registers): Update.
1034         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1035         New method.
1036
1037 2019-07-17  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1040         declare.
1041         * tui/tui-windata.c
1042         (tui_data_window::delete_data_content_windows): Rename from
1043         tui_delete_data_content_windows.
1044         (tui_data_window::display_all_data)
1045         (tui_data_window::do_scroll_vertical): Update.
1046         * tui/tui-data.h (struct tui_data_window)
1047         <delete_data_content_windows>: New method.
1048
1049 2019-07-17  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1052         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1053
1054 2019-07-17  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1057         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1058         from tui_display_all_data.
1059         * tui/tui-win.c
1060         (tui_data_window::do_make_visible_with_new_height): Update.
1061         * tui/tui-regs.c (tui_show_registers): Update.
1062         * tui/tui-layout.c (tui_set_layout): Update.
1063         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1064         method.
1065
1066 2019-07-17  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1069         * tui/tui-windata.c (tui_display_data_from): Remove.
1070         (tui_data_window::refresh_all): Update.
1071
1072 2019-07-17  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1075         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1076         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1077         tui_display_registers_from_line.
1078         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1079         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1080         "force_display" parameter.
1081
1082 2019-07-17  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1085         declare.
1086         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1087         Rename from tui_first_reg_element_no_inline.
1088         (tui_display_reg_element_at_line)
1089         (tui_display_registers_from_line): Update.
1090         * tui/tui-data.h (struct tui_data_window)
1091         <first_reg_element_no_inline>: New method.
1092
1093 2019-07-17  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-windata.c (tui_display_data_from)
1096         (tui_data_window::do_scroll_vertical): Update.
1097         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1098         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1099         Rename from tui_line_from_reg_element_no.
1100         (tui_display_registers_from_line): Update.
1101         * tui/tui-data.h (struct tui_data_window)
1102         <line_from_reg_element_no>: New method.
1103
1104 2019-07-17  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1107         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1108         tui_last_regs_line_no.
1109         (tui_display_reg_element_at_line)
1110         (tui_display_registers_from_line): Update.
1111         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1112         method.
1113
1114 2019-07-17  Tom Tromey  <tom@tromey.com>
1115
1116         PR tui/24722:
1117         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1118         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1119         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1120         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1121         (tui_update_breakpoint_info): Likewise.
1122         * tui/tui-hooks.c (tui_event_create_breakpoint)
1123         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1124         Update.
1125
1126 2019-07-17  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1129
1130 2019-07-17  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-winsource.c (tui_update_source_window_as_is)
1133         (tui_update_source_windows_with_addr): Update.
1134         * tui/tui-source.h (tui_set_source_content)
1135         (tui_show_symtab_source): Add "win_info" parameter.
1136         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1137         parameter.
1138         (tui_show_symtab_source): Likewise.
1139
1140 2019-07-17  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-wingeneral.c
1143         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1144
1145 2019-07-17  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1148         (struct tui_cmd_window) <can_scroll>: New method.
1149         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1150         method.
1151
1152 2019-07-17  Tom Tromey  <tromey@adacore.com>
1153
1154         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1155         do_field_signed>: Rename.  Change type of "value".
1156         * ui-out.c (ui_out::field_signed): Rename from field_int.
1157         Change type of "value".
1158         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1159         type of "value".
1160         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1161         do_field_int.  Change type of "value".
1162         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1163         do_field_int.  Change type of "value".
1164         * tracepoint.c (trace_status_mi, tfind_1)
1165         (print_one_static_tracepoint_marker): Update.
1166         * thread.c (print_thread_info_1, print_selected_thread_frame):
1167         Update.
1168         * stack.c (print_frame, print_frame_info): Update.
1169         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1170         Update.
1171         * source.c (print_source_lines_base): Update.
1172         * skip.c (info_skip_command): Update.
1173         * record-btrace.c (btrace_ui_out_decode_error)
1174         (btrace_call_history_src_line): Update.
1175         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1176         Update.
1177         * progspace.c (print_program_space): Update.
1178         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1179         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1180         do_field_int.  Change type of "value".
1181         * mi/mi-out.c (mi_ui_out::do_table_begin)
1182         (mi_ui_out::do_table_header): Update.
1183         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1184         type of "value".
1185         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1186         (mi_cmd_data_list_changed_registers, output_register)
1187         (mi_cmd_data_read_memory, mi_load_progress)
1188         (mi_cmd_trace_frame_collected): Update.
1189         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1190         Update.
1191         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1192         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1193         (mi_cmd_var_list_children, varobj_update_one): Update.
1194         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1195         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1196         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1197         * inferior.c (print_inferior): Update.
1198         * gdb_bfd.c (print_one_bfd): Update.
1199         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1200         Update.
1201         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1202         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1203         do_field_int.  Change type of "value".
1204         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1205         do_field_int.  Change type of "value".
1206         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1207         (print_one_breakpoint_location, print_it_catch_fork)
1208         (print_one_catch_fork, print_it_catch_vfork)
1209         (print_one_catch_vfork, print_it_catch_solib)
1210         (print_it_catch_exec, print_it_ranged_breakpoint)
1211         (print_mention_watchpoint, print_mention_masked_watchpoint)
1212         (bkpt_print_it, update_static_tracepoint): Update.
1213         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1214         * break-catch-syscall.c (print_it_catch_syscall): Update.
1215         * ada-tasks.c (print_ada_task_info): Update.
1216         * ada-lang.c (print_it_exception, print_mention_exception):
1217         Update.
1218
1219 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         PR breakpoints/24541
1222         * gdbarch.c: Regenerate.
1223         * gdbarch.h: Regenerate.
1224         * gdbarch.sh: Adjust return type and parameter types for
1225         'stap_adjust_register'.
1226         (i386_stap_adjust_register): Adjust signature and return new
1227         register name.
1228         * stap-probe.c (stap_parse_register_operand): Adjust use of
1229         'gdbarch_stap_adjust_register'.
1230
1231 2019-07-17  Tom Tromey  <tromey@adacore.com>
1232
1233         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1234         declare VEC.
1235         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1236         std::vector.
1237         (struct s390_process_info): Add initializers.
1238         (s390_add_process): Use new.
1239         (s390_linux_nat_target::low_forget_process): Use delete.
1240         (s390_linux_nat_target::low_new_fork)
1241         (s390_linux_nat_target::stopped_by_watchpoint)
1242         (s390_linux_nat_target::low_prepare_to_resume)
1243         (s390_linux_nat_target::insert_watchpoint)
1244         (s390_linux_nat_target::insert_hw_breakpoint)
1245         (s390_linux_nat_target::remove_watchpoint)
1246         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1247
1248 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1249
1250         * aarch64-fbsd-nat.c: Include regcache.h.
1251         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1252         argument.
1253         (aarch64_fbsd_nat_target::fetch_registers)
1254         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1255         variable.
1256         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1257
1258 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1259
1260         * fbsd-nat.c: Include gdbarch.h.
1261
1262 2019-07-15  Tom Tromey  <tromey@adacore.com>
1263
1264         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1265
1266 2019-07-15  Tom Tromey  <tromey@adacore.com>
1267
1268         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1269         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1270         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1271         * cli-out.c (cli_ui_out::do_field_int): New method.
1272         * ui-out.c (ui_out::field_unsigned): New method.
1273         * symfile.c (generic_load): Use field_unsigned.
1274         (print_transfer_performance): Likewise.
1275         * record-btrace.c (ui_out_field_uint): Remove.
1276         (btrace_call_history_insn_range, btrace_call_history): Use
1277         field_unsigned.
1278         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1279         field_unsigned.
1280         * ui-out.h (class ui_out) <field_unsigned>: New method.
1281         <do_field_unsigned>: Likewise.
1282
1283 2019-07-15  Tom Tromey  <tromey@adacore.com>
1284
1285         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1286         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1287         * target.c (flash_erase_command): Use field_string.
1288         * infrun.c (print_signal_received_reason): Use field_string.
1289         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1290         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1291         field_string.
1292         * ada-tasks.c (print_ada_task_info): Use field_string.
1293
1294 2019-07-15  Tom Tromey  <tromey@adacore.com>
1295
1296         * target.c (flash_erase_command): Use field_core_addr.
1297         * symfile.c (generic_load): Use field_core_addr.
1298         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1299         Use field_core_addr.
1300         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1301         field_core_addr.
1302
1303 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1306         value if its desired type is smaller than a CORE_ADDR and signed.
1307
1308 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1311         of changes to field names, and use new is_reference field to
1312         decide if a property is a reference or not.
1313         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1314         field.
1315         (struct dwarf2_property_baton): Update header comment, rename
1316         'referenced_type' to 'property_type' and update comments.
1317         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1318         default property type, store in property baton, update to take
1319         accound of renamed field.
1320         (read_func_scope): Update call to attr_to_dynamic_prop.
1321         (read_array_type): Likewise.
1322         (dwarf2_per_cu_addr_sized_int_type): New function.
1323         (read_subrange_index_type): Move type finding code to
1324         dwarf2_per_cu_addr_sized_int_type.
1325         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1326         (dwarf2_per_cu_addr_type): New function.
1327         (set_die_type): Update calls to attr_to_dynamic_prop.
1328
1329 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * dwarf2read.c (read_subrange_index_type): New function.
1332         (read_subrange_type): Move code into new function and call it.
1333         * gdbtypes.c (create_range_type): Add some asserts.
1334
1335 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1338         update return statements.
1339         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1340         declaration, and update comment to match.
1341         * gdbtypes.c (resolve_dynamic_array): Update call to
1342         dwarf2_evaluate_property to match new return type.
1343
1344 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1345
1346         * valarith.c (value_subscripted_rvalue): Change lowerbound
1347         parameter type from int to LONGEST.
1348         * value.h (value_subscripted_rvalue): Likewise in declaration.
1349
1350 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * cli/cli-utils.c (info_print_command_completer): New function.
1353         * cli/cli-utils.h: Add 'completer.h' include, and forward
1354         declaration for 'struct cmd_list_element'.
1355         (info_print_command_completer): Declare.
1356         * stack.c (_initialize_stack): Add completer for 'info locals' and
1357         'info args'.
1358         * symtab.c (_initialize_symtab): Add completer for 'info
1359         variables' and 'info functions'.
1360         * NEWS: Mention completion for additional info commands.
1361
1362 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1363
1364         * cli/cli-utils.c (extract_info_print_args): Delete.
1365         (extract_arg_maybe_quoted): Delete.
1366         (info_print_options_defs): New variable.
1367         (make_info_print_options_def_group): New function.
1368         (extract_info_print_options): Define new function.
1369         * cli/cli-utils.h (extract_info_print_args): Delete.
1370         (struct info_print_options): New structure.
1371         (extract_info_print_options): Declare new function.
1372         * stack.c (info_locals_command): Update to use new
1373         extract_info_print_options, also add a header comment.
1374         (info_args_command): Likewise.
1375         * symtab.c (info_variables_command): Likewise.
1376         (info_functions_command): Likewise.
1377
1378 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1379
1380         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1381         to extract string arguments.
1382         * common/common-utils.c (extract_string_maybe_quoted): New function.
1383         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1384
1385 2019-07-11  Tom Tromey  <tromey@adacore.com>
1386
1387         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1388         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1389         * top.h (gdbinit): Don't declare.
1390         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1391         into...
1392         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1393         * top.c (gdb_init): Don't call init_cli_cmds.
1394         (gdbinit): Remove.
1395         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1396
1397 2019-07-11  Tom Tromey  <tromey@adacore.com>
1398
1399         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1400         after it has been moved.
1401
1402 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1403
1404         * valops.c (value_must_coerce_to_target): Change return type to
1405         bool.
1406         * value.h (value_must_coerce_to_target): Likewise.
1407
1408 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1409
1410         * breakpoint.c (is_hardware_watchpoint): Remove
1411         forward-declaration.
1412         (is_masked_watchpoint): Change return type to bool.
1413         (is_tracepoint): Likewise.
1414         (is_breakpoint): Likewise.
1415         (is_hardware_watchpoint): Likewise.
1416         (is_watchpoint): Likewise.
1417         (is_no_memory_software_watchpoint): Likewise.
1418         (is_catchpoint): Likewise.
1419         (breakpoint_1): Make FILTER parameter's return type bool.
1420         is_masked_watchpoint): Change return type to bool.
1421         (save_breakpoints): Make FILTER parameter's return type bool.
1422         * breakpoint.h (is_breakpoint): Change return type to bool.
1423         (is_watchpoint): Likewise.
1424         (is_catchpoint): Likewise.
1425         (is_tracepoint): Likewise.
1426
1427 2019-07-10  Tom Tromey  <tom@tromey.com>
1428
1429         * defs.h: Don't include gdbarch.h.
1430         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1431         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1432         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1433         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1434         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1435         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1436         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1437         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1438         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1439         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1440         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1441         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1442         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1443         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1444         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1445         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1446         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1447         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1448         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1449         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1450         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1451         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1452         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1453         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1454         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1455         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1456         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1457
1458 2019-07-10  Tom Tromey  <tromey@adacore.com>
1459
1460         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1461         * breakpoint.c (init_ada_exception_breakpoint): Register as
1462         bp_catchpoint.
1463         (print_one_breakpoint_location, print_one_breakpoint): Use
1464         is_ada_exception_catchpoint.
1465         * ada-lang.c (class ada_catchpoint_location): Pass
1466         bp_loc_software_breakpoint to bp_location constructor.
1467         (is_ada_exception_catchpoint): New function.
1468
1469 2019-07-10  Tom Tromey  <tromey@adacore.com>
1470
1471         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1472         VEC.
1473         (struct arm_exidx_entry): New method operator<.
1474         (struct arm_exidx_data) <section_maps>: Change type.
1475         (arm_exidx_data_free): Remove.
1476         (arm_exidx_data_key): Change type.  Move lower.
1477         (arm_exidx_new_objfile): Update.
1478         (arm_compare_exidx_entries): Remove.
1479         (arm_find_exidx_entry, _initialize_arm_tdep)
1480
1481 2019-07-10  Tom Tromey  <tromey@adacore.com>
1482
1483         * solib-spu.c (ocl_program_data_key): Change type.
1484         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1485         Update.
1486
1487 2019-07-10  Tom Tromey  <tromey@adacore.com>
1488
1489         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1490         (struct solib_aix_inferior_data) <library_list>: Change type.
1491         (solib_aix_inferior_data_handle): Change type.
1492         (get_solib_aix_inferior_data): Update.
1493         (solib_aix_free_library_list): Remove.
1494         (library_list_start_library): Update.
1495         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1496         return type.
1497         (solib_aix_get_library_list)
1498         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1499         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1500
1501 2019-07-10  Tom Tromey  <tromey@adacore.com>
1502
1503         * solib-dsbt.c (struct dsbt_info): Add initializers.
1504         (solib_dsbt_pspace_data): Change type.
1505         (dsbt_pspace_data_cleanup): Remove.
1506         (get_dsbt_info, _initialize_dsbt_solib): Update.
1507
1508 2019-07-10  Tom Tromey  <tromey@adacore.com>
1509
1510         * spu-tdep.c (spu_overlay_data): Change type.
1511         (spu_get_overlay_table, spu_overlay_new_objfile)
1512         (_initialize_spu_tdep): Update.
1513
1514 2019-07-10  Tom Tromey  <tromey@adacore.com>
1515
1516         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1517         destructor.
1518         (dbx_objfile_data_key): Change type and declare later.
1519         (DBX_SYMFILE_INFO): Rewrite.
1520         * dbxread.c (dbx_objfile_data_key): Change type.
1521         (dbx_symfile_init): Update.
1522         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1523         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1524         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1525
1526 2019-07-10  Tom Tromey  <tromey@adacore.com>
1527
1528         * jit.c (jit_program_space_key): Change type.  Move lower.
1529         (get_jit_program_space_data): Update.
1530         (jit_program_space_data_cleanup): Remove.
1531         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1532         Update.
1533         (struct jit_program_space_data): Add initializers.
1534
1535 2019-07-10  Tom Tromey  <tromey@adacore.com>
1536
1537         * solib-darwin.c (struct darwin_info): Add initializers.
1538         (solib_darwin_pspace_data): Change type.
1539         (darwin_pspace_data_cleanup): Remove.
1540         (get_darwin_info, _initialize_darwin_solib): Update.
1541
1542 2019-07-10  Tom Tromey  <tromey@adacore.com>
1543
1544         * remote-sim.c (struct sim_inferior_data): Add initializers,
1545         constructor, and destructor.
1546         (sim_inferior_data_key): Change type.  Move lower.
1547         (check_for_duplicate_sim_descriptor): Update.
1548         (get_sim_inferior_data): Use new.  Update.
1549         (~sim_inferior_data_cleanup): Rename from
1550         sim_inferior_data_cleanup.  Simplify.
1551         (gdbsim_close_inferior, simulator_command)
1552         (sim_command_completer, _initialize_remote_sim): Update.
1553         (next_pid, INITIAL_PID): Move earlier.
1554
1555 2019-07-10  Tom Tromey  <tromey@adacore.com>
1556
1557         * python/python-internal.h (create_thread_object): Return
1558         gdbpy_ref.
1559         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1560         * python/py-inferior.c (struct threadlist_entry): Add
1561         constructor.
1562         <thread_obj>: Now a gdbpy_ref.
1563         (thread_to_thread_object): Update.
1564         (add_thread_object): Use new.
1565         (delete_thread_object): Use delete.
1566         (infpy_threads): Update.
1567         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1568         GIL.
1569
1570 2019-07-10  Tom Tromey  <tromey@adacore.com>
1571
1572         * valops.c (value_cast): Specialize error message for Ada.
1573
1574 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1575
1576         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1577
1578 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1579
1580         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1581         bpstat_should_step): Return bool, adjust comments.
1582         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1583         bpstat_should_step): Likewise.
1584
1585 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1586
1587         * features/Makefile: Use feature target descriptions for Arm.
1588         * features/arm/arm-core.c: Generate new file.
1589         * features/arm/arm-fpa.c: Likewise.
1590         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1591         * features/arm/arm-m-profile.c: Likewise.
1592         * features/arm/arm-vfpv2.c: Likewise.
1593         * features/arm/arm-vfpv3.c: Likewise.
1594         * features/arm/xscale-iwmmxt.c: Likewise.
1595         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1596
1597 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1598
1599         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1600         ptrace earlier.
1601
1602 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1603
1604         * features/aarch64-pauth.c: Regenerate.
1605
1606 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1607
1608         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1609         bool.
1610         (bpstat_what): Use false instead of 0.
1611
1612 2019-07-09  Pedro Alves  <palves@redhat.com>
1613
1614         * break-catch-throw.c (is_exception_catchpoint): New.
1615         * breakpoint.c (print_one_breakpoint_location): New parameter
1616         'raw_loc'.  Handle it.  Use
1617         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1618         looking at the breakpoint's type.
1619         (print_one_breakpoint): If handling "maint info breakpoints", also
1620         print locations of exception catchpoints.
1621         * breakpoint.h (is_exception_catchpoint): Declare.
1622
1623 2019-07-09  Pedro Alves  <palves@redhat.com>
1624
1625         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1626         "addr" field.
1627         (allocate_location_exception_catchpoint): New.
1628         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1629         (initialize_throw_catchpoint_ops): Install
1630         allocate_location_exception_catchpoint as allocate_location
1631         method.
1632         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1633         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1634         bp_loc_other.
1635         (breakpoint_address_is_meaningful): Delete.
1636         (bl_address_is_meaningful): New.
1637         (breakpoint_locations_match): Adjust comment.
1638         (bp_location_from_bp_type): New, factored out of...
1639         (bp_location::bp_location(breakpoint *)): ... this.
1640         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1641         factored out of...
1642         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1643         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1644         breakpoint_address_is_meaningful.
1645         (bp_locations_compare): Adjust comment.
1646         (update_global_location_list): Use bl_address_is_meaningful
1647         instead of breakpoint_address_is_meaningful.
1648         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1649         explicit.
1650         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1651         * python/py-breakpoint.c (bppy_get_location): No longer check
1652         whether location is null.
1653
1654 2019-07-09  Pedro Alves  <palves@redhat.com>
1655
1656         PR c++/15468
1657         * breakpoint.c (print_one_breakpoint_location): Remove
1658         single-location assert.
1659
1660 2019-07-09  Tom Tromey  <tom@tromey.com>
1661
1662         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1663         * configure: Rebuild.
1664         * configure.ac: Change common to gdbsupport.
1665         * gdbsupport: Rename from common.
1666         * acinclude.m4: Change common to gdbsupport.
1667         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1668         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1669         gdbsupport.
1670         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1671         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1672         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1673         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1674         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1675         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1676         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1677         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1678         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1679         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1680         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1681         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1682         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1683         coff-pe-read.c, command.h, compile/compile-c-support.c,
1684         compile/compile-c.h, compile/compile-cplus-symbols.c,
1685         compile/compile-cplus-types.c, compile/compile-cplus.h,
1686         compile/compile-loc2c.c, compile/compile.c, completer.c,
1687         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1688         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1689         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1690         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1691         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1692         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1693         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1694         features/aarch64-core.c, features/aarch64-fpu.c,
1695         features/aarch64-pauth.c, features/aarch64-sve.c,
1696         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1697         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1698         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1699         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1700         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1701         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1702         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1703         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1704         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1705         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1706         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1707         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1708         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1709         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1710         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1711         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1712         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1713         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1714         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1715         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1716         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1717         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1718         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1719         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1720         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1721         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1722         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1723         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1724         minsyms.c, mips-linux-tdep.c, namespace.h,
1725         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1726         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1727         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1728         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1729         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1730         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1731         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1732         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1733         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1734         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1735         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1736         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1737         procfs.c, producer.c, progspace.h, psymtab.h,
1738         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1739         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1740         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1741         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1742         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1743         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1744         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1745         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1746         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1747         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1748         target-memory.c, target.c, target.h, target/waitstatus.c,
1749         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1750         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1751         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1752         unittests/array-view-selftests.c,
1753         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1754         unittests/common-utils-selftests.c,
1755         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1756         unittests/format_pieces-selftests.c,
1757         unittests/function-view-selftests.c,
1758         unittests/lookup_name_info-selftests.c,
1759         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1760         unittests/mkdir-recursive-selftests.c,
1761         unittests/observable-selftests.c,
1762         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1763         unittests/parse-connection-spec-selftests.c,
1764         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1765         unittests/scoped_fd-selftests.c,
1766         unittests/scoped_mmap-selftests.c,
1767         unittests/scoped_restore-selftests.c,
1768         unittests/string_view-selftests.c, unittests/style-selftests.c,
1769         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1770         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1771         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1772         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1773         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1774         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1775
1776 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1779         bool value.
1780         (decode_digits_ordinary): Set explicit_line field in sal.
1781         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1782         symtab_and_line that was set on an explicit line number in
1783         assembler code.  Do always update the recorded symtab and line if
1784         we do skip the prologue.
1785
1786 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1787
1788         * breakpoint.c (set_breakpoint_location_function): Remove
1789         explicit_loc parameter.
1790         (momentary_breakpoint_from_master): Update call to
1791         set_breakpoint_location_function.
1792         (add_location_to_breakpoint): Likewise.
1793
1794 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1797         required features based on default bfd type when no specific bfd
1798         is present.
1799
1800 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1801
1802         * NEWS: Mention that GDB printf and eval commands can now print
1803         C-style and Ada-style convenience var strings without
1804         calling the inferior.
1805         * printcmd.c (printf_c_string): Locally print GDB internal var
1806         instead of transiting via the inferior.
1807         (printf_wide_c_string): Likewise.
1808
1809 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1810
1811         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1812
1813 2019-07-04  Tom Tromey  <tom@tromey.com>
1814
1815         PR tui/24724:
1816         * tui/tui-winsource.c (tui_clear_source_content): Update.
1817         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1818         (tui_update_breakpoint_info): Update.
1819         (tui_set_exec_info_content): Update.
1820         * tui/tui-source.c (tui_set_source_content_nil): Update.
1821         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1822         has_break.
1823         * tui/tui-data.h (enum tui_bp_flag): New.
1824         (tui_bp_flags): New enum flags type.
1825         (struct tui_source_element) <break_mode>: Change type.  Rename
1826         from has_break.
1827         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1828         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1829         constants.
1830         * tui/tui-winsource.h: Fix comment.
1831
1832 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1833
1834         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1835         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1836         (store_fpregs_to_thread)
1837         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1838         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1839         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1840         (IWMMXT_REGS_SIZE): Add define.
1841         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1842         (fetch_vfp_regs, store_vfp_regs)
1843         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1844         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1845
1846 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1847
1848         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1849         defines.
1850         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1851         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1852         (ARM_INT_REGISTER_SIZE): ...to this.
1853         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1854         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1855         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1856         (arm_linux_collect_gregset, supply_nwfpe_register)
1857         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1858         defines.
1859         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1860         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1861         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1862         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1863         (arm_return_in_memory, arm_store_return_value)
1864         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1865         (arm_record_ld_st_multiple): Likewise.
1866         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1867         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1868
1869 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1870
1871         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1872         AARCH64_DISPLACED_MODIFIED_INSNS.
1873         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1874         (aarch64_displaced_step_copy_insn): Likewise.
1875         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1876         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1877         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1878         ARM_DISPLACED_MODIFIED_INSNS.
1879         * arm-tdep.c (arm_gdbarch_init): Likewise.
1880         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1881         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1882         (struct arm_displaced_step_closure): Use
1883         ARM_DISPLACED_MODIFIED_INSNS.
1884
1885 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1886
1887         * features/Makefile: Remove unused xml files.
1888         * features/aarch64.xml: Remove.
1889         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1890         * features/i386/amd64-avx-avx512.xml: Remove.
1891         * features/i386/amd64-avx-linux.xml: Remove.
1892         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1893         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1894         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1895         * features/i386/amd64-avx-mpx.xml: Remove.
1896         * features/i386/amd64-avx.xml: Remove.
1897         * features/i386/amd64-linux.xml: Remove.
1898         * features/i386/amd64-mpx-linux.xml: Remove.
1899         * features/i386/amd64-mpx.xml: Remove.
1900         * features/i386/amd64.xml: Remove.
1901         * features/i386/i386-avx-avx512-linux.xml: Remove.
1902         * features/i386/i386-avx-avx512.xml: Remove.
1903         * features/i386/i386-avx-linux.xml: Remove.
1904         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1905         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1906         * features/i386/i386-avx-mpx-linux.xml: Remove.
1907         * features/i386/i386-avx-mpx.xml: Remove.
1908         * features/i386/i386-avx.xml: Remove.
1909         * features/i386/i386-linux.xml: Remove.
1910         * features/i386/i386-mmx-linux.xml: Remove.
1911         * features/i386/i386-mmx.xml: Remove.
1912         * features/i386/i386-mpx-linux.xml: Remove.
1913         * features/i386/i386-mpx.xml: Remove.
1914         * features/i386/i386.xml: Remove.
1915         * features/i386/x32-avx-avx512-linux.xml: Remove.
1916         * features/i386/x32-avx-linux.xml: Remove.
1917         * features/i386/x32-linux.xml: Remove.
1918
1919 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1920
1921         * regformats/aarch64.dat: Remove.
1922         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1923         * regformats/i386/amd64-avx-linux.dat: Remove.
1924         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1925         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1926         * regformats/i386/amd64-linux.dat: Remove.
1927         * regformats/i386/amd64-mpx-linux.dat: Remove.
1928         * regformats/i386/amd64.dat: Remove.
1929         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1930         * regformats/i386/i386-avx-linux.dat: Remove.
1931         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1932         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1933         * regformats/i386/i386-linux.dat: Remove.
1934         * regformats/i386/i386-mmx-linux.dat: Remove.
1935         * regformats/i386/i386-mpx-linux.dat: Remove.
1936         * regformats/i386/i386.dat: Remove.
1937         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1938         * regformats/i386/x32-avx-linux.dat: Remove.
1939         * regformats/i386/x32-linux.dat: Remove.
1940
1941 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1942
1943         * aarch64-tdep.c: Remove xml self tests.
1944         * amd64-linux-tdep.c: Likewise.
1945         * amd64-tdep.c: Likewise.
1946         * i386-linux-tdep.c: Likewise.
1947         * i386-tdep.c: Likewise.
1948
1949 2019-07-03  Pedro Alves  <palves@redhat.com>
1950
1951         PR cli/24732
1952         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1953         (pipe_cmd_option_defs): New.
1954         (make_pipe_cmd_options_def_group): New.
1955         (pipe_command): Use gdb::option::process_options.
1956         (pipe_command_completer): New function.
1957         (_initialize_cli_cmds): Install completer for "pipe" command.
1958
1959 2019-07-03  Pedro Alves  <palves@redhat.com>
1960
1961         * cli/cli-option.c (union option_value) <string>: New field.
1962         (struct option_def_and_value): Add ctor, move ctor, dtor and
1963         use DISABLE_COPY_AND_ASSIGN.
1964         (option_def_and_value::clear_value): New.
1965         (parse_option, save_option_value_in_ctx, get_val_type_str)
1966         (add_setshow_cmds_for_options): Handle var_string.
1967         * cli-option.h (union option_def::var_address) <string>: New
1968         field.
1969         (struct string_option_def): New.
1970         * maint-test-options.c (struct test_options_opts): Add default
1971         ctor and use DISABLE_COPY_AND_ASSIGN.
1972         <string_opt>: New field.
1973         (test_options_opts::~test_options_opts): New.
1974         (test_options_opts::dump): Also dump "-string".
1975         (test_options_option_defs): Install "string.
1976
1977 2019-07-03  Pedro Alves  <palves@redhat.com>
1978
1979         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1980         option_value with a null enumeration.
1981         (complete_options): Save the option values in the context.
1982         (save_option_value_in_ctx): New, factored out from ...
1983         (process_options): ... here.
1984         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1985         of the function.
1986         * maint-test-options.c (test_options_opts::dump): New, factored
1987         out from ...
1988         (maintenance_test_options_command_mode): ... here.
1989         (maintenance_test_options_command_completion_result): Delete.
1990         (maintenance_test_options_command_completion_text): Update
1991         comment.
1992         (maintenance_show_test_options_completion_result): Change
1993         prototype.  Just print
1994         maintenance_test_options_command_completion_text.
1995         (save_completion_result): New.
1996         (maintenance_test_options_completer_mode): Pass options context to
1997         complete_options, and then save a dump.
1998         (_initialize_maint_test_options): Use add_cmd to install "maint
1999         show test-options-completion-result".
2000
2001 2019-07-03  Pedro Alves  <palves@redhat.com>
2002
2003         * NEWS (New commands): Mention "with" and "maint with".
2004         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2005         (with_command, with_command_completer): New.
2006         (pipe_command): Adjust to new repeat_previous
2007         interface.
2008         (_initialize_cli_cmds): Install the "with" command and its "w"
2009         alias.
2010         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2011         declarations.
2012         * cli/cli-setshow.c (parse_cli_var_uinteger)
2013         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2014         argument strings for all var_types.
2015         (get_setshow_command_value_string): New, factored out from ...
2016         (do_show_command): ... this.
2017         * cli/cli-setshow.h: Include <string>.
2018         (get_setshow_command_value_string): Declare.
2019         * command.h (repeat_previous): Now returns const char *.  Adjust
2020         comment.
2021         * maint.c: Include "cli/cli-cmds.h".
2022         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2023         (_initialize_maint_cmds): Register the "maintenance with" command.
2024         * top.c (repeat_previous): Move bits from pipe_command here:
2025         Return the saved command line, if any; error out if there's no
2026         command to relaunch.
2027
2028 2019-07-03  Pedro Alves  <palves@redhat.com>
2029
2030         * NEWS (New commands): Mention "maint set/show test-settings"
2031         instead of "maint test-settings".
2032         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2033         (maintenance_test_settings_set_list): Rename to ...
2034         (maintenance_set_test_settings_list): ... this.
2035         (maintenance_test_settings_show_list): Rename to  ...
2036         (maintenance_show_test_settings_list): ... this.
2037         (maintenance_test_settings_cmd): Delete.
2038         (maintenance_test_settings_set_cmd): ...
2039         (maintenance_set_test_settings_cmd): ... this.
2040         (maintenance_test_settings_show_cmd): ...
2041         (maintenance_show_test_settings_cmd): ... this.
2042         (maintenance_test_settings_show_value_cmd):
2043         (maintenance_show_test_settings_value_cmd): ... this.
2044         (_initialize_maint_test_settings): No longer install the "maint
2045         test-settings" prefix command.  Rename "maint test-settings set"
2046         to "maint set test-settings", and "maint test-settings show" to
2047         "maint show test-settings".  Adjust all subcommands.
2048
2049 2019-07-03  Pedro Alves  <palves@redhat.com>
2050
2051         * maint-test-settings.c: Fix file's intro comment.  Replace all
2052         references to "test-options" with references to "test-settings",
2053         in comments.
2054
2055 2019-07-03  Pedro Alves  <palves@redhat.com>
2056
2057         * maint-test-settings.c (maintenance_test_settings_xxx)
2058         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2059         New.
2060         (maintenance_test_settings_enums): Use them.
2061         (maintenance_test_settings_enum): Default to
2062         maintenance_test_settings_xxx.
2063         (_initialize_maint_test_settings): Initialize
2064         MAINTENANCE_TEST_SETTINGS_FILENAME.
2065
2066 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2067
2068         * breakpoint.h (remove_breakpoints_inf): Change return type to
2069         void, move function documentation here.
2070         * breakpoint.c (remove_breakpoints_inf): Change return type to
2071         void, move function documentation to header.
2072
2073 2019-07-02  Pedro Alves  <palves@redhat.com>
2074
2075         * NEWS (Completion improvements): Mention "info threads".
2076         * thread.c (struct info_threads_opts, info_threads_option_defs)
2077         (make_info_threads_options_def_group): New.
2078         (info_threads_command): Use gdb::option::process_options.
2079         (info_threads_command_completer): New.
2080         (_initialize_thread): Use gdb::option::build_help to build the
2081         help text for "info threads".
2082
2083 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2084
2085         * defs.h (generic_load): Move from here...
2086         * symfile.h (generic_load): ... to here.  Rename name parameter
2087         to args.
2088         * symfile.c (generic_load): Add comment.
2089
2090 2019-07-01  Tom Tromey  <tromey@adacore.com>
2091
2092         * dwarf2read.c
2093         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2094         declaration of without_params.  Fix formatting.
2095
2096 2019-07-01  Tom Tromey  <tromey@adacore.com>
2097
2098         * ada-exp.y (find_primitive_type): Update.
2099         * ada-lang.h (ada_lookup_symbol): Update.
2100         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2101         parameter.
2102         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2103
2104 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2105
2106         PR breakpoints/24541
2107         * gdbarch.c: Regenerate.
2108         * gdbarch.h: Regenerate.
2109         * gdbarch.sh: Add 'stap_adjust_register'.
2110         * i386-tdep.c: Include '<unordered_set>'.
2111         (i386_stap_adjust_register): New function.
2112         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2113         * stap-probe.c (stap_parse_register_operand): Call
2114         'gdbarch_stap_adjust_register'.
2115
2116 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2117
2118         PR python/24742
2119         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2120         * python/python.c (do_start_initialization): Use 'xmalloc'
2121         instead of 'PyMem_Malloc'.
2122
2123 2019-06-28  Tom Tromey  <tromey@adacore.com>
2124
2125         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2126         for Ada.
2127
2128 2019-06-27  Tom Tromey  <tromey@adacore.com>
2129
2130         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2131         objfile_key.
2132         (arm_find_mapping_symbol, arm_record_special_symbol)
2133         (_initialize_arm_tdep): Update.
2134         (arm_objfile_data_free): Remove.
2135
2136 2019-06-27  Tom Tromey  <tromey@adacore.com>
2137
2138         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2139         to cp_print_static_field.
2140
2141 2019-06-26  Tom Tromey  <tromey@adacore.com>
2142
2143         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2144         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2145         declare.
2146
2147 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2148
2149         * features/aarch64-core.c (create_feature_aarch64_core):
2150         Regenerate.
2151         * features/aarch64-core.xml: Add cpsr flags.
2152
2153 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2154
2155         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2156         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2157
2158 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2159
2160         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2161         field.
2162         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2163         use.
2164         (arm_record_special_symbol): Don't insert new symbol in sorted
2165         position, push it at the end.
2166
2167 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2168
2169         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2170         (arm_mapping_symbol_s): Remove.
2171         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2172         (arm_mapping_symbol_vec): New typedef.
2173         (struct arm_per_objfile): Add constructor.
2174         <section_maps>: Change type to
2175         std::unique_ptr<arm_mapping_symbol_vec[]>.
2176         (arm_compare_mapping_symbols): Remove.
2177         (arm_find_mapping_symbol): Adjust to section_maps type change.
2178         (arm_objfile_data_free): Call delete on arm_per_objfile.
2179         (arm_record_special_symbol): Adjust to section_maps type change.
2180         Allocate arm_per_objfile with new.
2181
2182 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2183
2184         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2185         with the command prefix.
2186
2187 2019-06-25  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2190         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2191
2192 2019-06-25  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2195         type.
2196         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2197         protected.
2198
2199 2019-06-25  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-winsource.c
2202         (tui_source_window_base::set_is_exec_point_at): Add check against
2203         LOA_ADDRESS.
2204
2205 2019-06-25  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-source.c (tui_set_source_content): Don't check before
2208         xfree.
2209         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2210
2211 2019-06-25  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-winsource.h (tui_update_source_window_as_is)
2214         (tui_alloc_source_buffer, tui_line_is_displayed)
2215         (tui_addr_is_displayed): Change type of win_info.
2216         * tui/tui-winsource.c (tui_update_source_window_as_is)
2217         (tui_clear_source_content, tui_show_source_line)
2218         (tui_show_source_content, tui_source_window_base::refill)
2219         (tui_source_window_base::set_is_exec_point_at)
2220         (tui_source_window_base::set_is_exec_point_at)
2221         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2222         (tui_alloc_source_buffer, tui_line_is_displayed)
2223         (tui_addr_is_displayed): Change type of win_info.  Update.
2224         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2225         (tui_source_window_base::do_make_visible_with_new_height):
2226         Update.
2227         * tui/tui-source.c (tui_set_source_content)
2228         (tui_set_source_content_nil)
2229         (tui_source_window::do_scroll_vertical): Update.
2230         * tui/tui-layout.c (show_layout): Update.
2231         * tui/tui-disasm.c (tui_set_disassem_content)
2232         (tui_disasm_window::do_scroll_vertical): Update.
2233         * tui/tui-data.h (tui_win_content): Remove.
2234         (struct tui_gen_win_info) <content, content_size>: Remove.
2235         (struct tui_source_element): Add initializers and destructor.
2236         (union tui_which_element, struct tui_win_element): Remove.
2237         (struct tui_source_window_base) <content>: New field.
2238         (struct tui_data_window): Remove destructor.
2239         (tui_alloc_content, tui_free_win_content)
2240         (tui_free_all_source_wins_content): Don't declare.
2241         * tui/tui-data.c (tui_initialize_static_data): Update.
2242         (init_content_element, tui_alloc_content): Remove.
2243         (~tui_gen_win_info): Update.
2244         (~tui_data_window, tui_free_all_source_wins_content)
2245         (tui_free_win_content, free_content, free_content_elements):
2246         Remove.
2247
2248 2019-06-25  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-winsource.h (tui_clear_source_content)
2251         (tui_erase_source_content, tui_show_source_content): Change type
2252         of win_info.
2253         * tui/tui-winsource.c (tui_clear_source_content)
2254         (tui_erase_source_content, tui_show_source_content): Change type
2255         of win_info.
2256         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2257         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2258         win_info.
2259         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2260         win_info.
2261         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-winsource.c (tui_clear_source_content)
2266         (tui_source_window_base::set_is_exec_point_at): Update.
2267         * tui/tui-source.c (tui_set_source_content_nil): Update.
2268         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2269         a bool.
2270         * tui/tui-data.c (init_content_element): Update.
2271
2272 2019-06-25  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2275         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2276         * tui/tui-layout.c (init_and_make_win): Update.
2277         * tui/tui.h (enum tui_win_type): Update.
2278         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2279         tui_win_is_auxillary.
2280         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2281         tui_win_is_auxillary.
2282
2283 2019-06-25  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2286         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2287         (tui_delete_data_content_windows, tui_display_all_data)
2288         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2289         Update.
2290         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2291         * tui/tui-regs.c (tui_last_regs_line_no)
2292         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2293         (tui_show_registers): Update.
2294         (tui_show_register_group): Return void.  Update.
2295         (tui_display_registers_from, tui_display_reg_element_at_line)
2296         (tui_display_registers_from_line, tui_check_register_values):
2297         Update.
2298         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2299         member.
2300         (struct tui_data_window) <regs_content>: Now a std::vector.
2301         <regs_content_count>: Remove.
2302         (tui_add_content_elements, tui_free_data_content): Don't declare.
2303         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2304         (init_content_element): Remove DATA_WIN case.  Add assert.
2305         (tui_add_content_elements): Remove.
2306         (tui_data_window): Update.
2307         (tui_free_data_content): Remove.
2308         (free_content_elements): Remove DATA_WIN case.
2309
2310 2019-06-25  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-data.c (tui_data_item_window): Update.
2313         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2314         * tui/tui-windata.c (tui_display_all_data)
2315         (tui_display_data_from_line): Update.
2316         (tui_check_data_values): Remove.
2317         * tui/tui-regs.c (tui_show_register_group)
2318         (tui_display_reg_element_at_line): Update.
2319         * tui/tui-hooks.c (tui_register_changed)
2320         (tui_refresh_frame_and_register_information): Call
2321         tui_check_register_values.
2322         * tui/tui-data.h (struct tui_data_window) <data_content,
2323         data_content_count, data_type>: Remove.
2324         (enum tui_data_type): Remove.
2325
2326         * tui/tui-data.c (tui_data_window::clear_detail)
2327         (~tui_data_window): Update.
2328
2329 2019-06-25  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2332         declare.
2333         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2334         Rename from tui_first_data_item_displayed.  Update.
2335         (tui_data_window::refresh_all)
2336         (tui_data_window::do_scroll_vertical): Update.
2337         * tui/tui-data.h (struct tui_data_window)
2338         <first_data_item_displayed>: Declare new method.
2339
2340 2019-06-25  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2343         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2344         contents...
2345         (tui_initialize_static_data): ...here.
2346
2347 2019-06-25  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2350         (tui_display_registers_from, tui_check_register_values): Update.
2351         (tui_display_register): Remove win_info parameter; update.
2352         (tui_get_register): Change type of parameters.
2353         * tui/tui-data.h (struct tui_data_element): Remove.
2354         (union tui_which_element) <data>: Remove.
2355         <data_window>: Change type.
2356         (struct tui_data_item_window): New.
2357         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2358         case.  Add assert.
2359         (~tui_data_item_window): New destructor.
2360         (free_content_elements): Remove DATA_ITEM_WIN case.
2361
2362 2019-06-25  Tom Tromey  <tom@tromey.com>
2363
2364         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2365         Remove.
2366
2367 2019-06-25  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-data.h (struct tui_command_element): Remove.
2370         (union tui_which_element) <command>: Remove.
2371         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2372         assert.
2373         (free_content_elements): Remove CMD_WIN case.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-layout.c (tui_set_layout): Update.
2378         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2379         * tui/tui-data.c (layout_def): Update.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2384         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2385         (tui_source_window_base::set_new_height): Update.
2386         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2387         Update.
2388         (tui_set_locator_fullname, tui_set_locator_info)
2389         (tui_show_frame_info): Update.
2390         * tui/tui-source.c (tui_set_source_content)
2391         (tui_source_is_displayed): Update.
2392         * tui/tui-layout.c (show_source_disasm_command, show_data)
2393         (show_source_or_disasm_and_command): Update.
2394         * tui/tui-disasm.c (tui_set_disassem_content)
2395         (tui_get_begin_asm_address): Update.
2396         * tui/tui-data.h (struct tui_locator_element): Remove.
2397         (union tui_which_element) <locator>: Remove.
2398         (struct tui_locator_window): New.
2399         (tui_locator_win_info_ptr): Change return type.
2400         * tui/tui-data.c (_locator): Change type.
2401         (tui_locator_win_info_ptr): Change return type.
2402         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2403         (tui_alloc_content): Add assert.
2404
2405 2019-06-25  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-winsource.c
2408         (tui_exec_info_window::maybe_allocate_content): New method.
2409         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2410         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2411         (make_source_or_disasm_window): Add cast.
2412         * tui/tui-data.h (union tui_which_element) <simple_string>:
2413         Remove.
2414         (struct tui_source_info): New.
2415         (struct tui_source_window_base) <execution_info>: Change type.
2416         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2417         case, and add assert.
2418         (tui_alloc_content): Add assert.
2419
2420 2019-06-25  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2423         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2424         * tui/tui-data.c (tui_alloc_win_info): Remove.
2425
2426 2019-06-25  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2429         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2430         can_highlight.
2431
2432 2019-06-25  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2435         make_visible_with_new_height method.
2436         (tui_win_info::make_visible_with_new_height): New method.
2437         (tui_source_window_base::do_make_visible_with_new_height)
2438         (tui_data_window::do_make_visible_with_new_height)
2439         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2440         (make_visible_with_new_height): Remove.
2441         (tui_resize_all, tui_adjust_win_heights): Use
2442         make_visible_with_new_height method.
2443         * tui/tui-data.h (struct tui_win_info)
2444         <do_make_visible_with_new_height, make_visible_with_new_height>:
2445         New methods.
2446         (struct tui_source_window_base, struct tui_data_window)
2447         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2448         methods.
2449
2450 2019-06-25  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2453         method.
2454         (update_tab_width): Call update_tab_width method.
2455         * tui/tui-data.h (struct tui_win_info)
2456         (struct tui_source_window_base) <update_tab_width>: New methods.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2461         parameter.
2462         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2463         parameter.
2464         (tui_gen_win_info::make_visible): Update.
2465         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2466         parameter.
2467         * tui/tui-data.h (enum tui_box): New enum.
2468         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2469
2470 2019-06-25  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2473         init_and_make_win for EXEC_INFO_WIN.
2474         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2475         longer inline.
2476         (struct tui_win_info) <~tui_win_info>: Inline.
2477         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2478         Don't declare.
2479         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2480         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2481         Remove.
2482         (tui_initialize_static_data): Update.
2483         (~tui_gen_win_info): Handle more cleanup here.
2484         (~tui_source_window_base): Delete "execution_info".
2485         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2486
2487 2019-06-25  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-layout.c (make_command_window): Don't set
2490         can_highlight.
2491         (show_source_disasm_command): Call the reset method.
2492         (show_data): Don't set can_highlight.  Call the reset method.
2493         (tui_gen_win_info::reset): Rename from init_gen_win_info
2494         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2495         (show_source_or_disasm_and_command): Call the reset method.
2496         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2497         (struct tui_cmd_window): Set can_highlight.
2498
2499 2019-06-25  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2502         from make_visible.
2503         (tui_make_visible, tui_make_invisible): Rewrite.
2504         (tui_win_info::make_visible): Remove.
2505         (tui_source_window_base::make_visible): Update.
2506         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2507         method.  Moved from...
2508         (struct tui_win_info) <make_visible>: ...here.
2509
2510 2019-06-25  Tom Tromey  <tom@tromey.com>
2511
2512         * tui/tui-winsource.c
2513         (tui_source_window_base::do_scroll_horizontal): Remove direction
2514         parameter.
2515         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2516         direction parameter.
2517         * tui/tui-win.c (tui_win_info::forward_scroll)
2518         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2519         (tui_win_info::right_scroll): Update.
2520         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2521         direction parameter.
2522         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2523         direction parameter.
2524         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2525         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2526         Remove direction parameter.
2527         (struct tui_source_window_base, struct tui_source_window)
2528         (struct tui_disasm_window, struct tui_data_window)
2529         (struct tui_cmd_window): Update.
2530
2531 2019-06-25  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-winsource.h (tui_set_exec_info_content)
2534         (tui_show_exec_info_content, tui_erase_exec_info_content)
2535         (tui_clear_exec_info_content, tui_update_exec_info): Change
2536         argument to tui_source_window_base.
2537         * tui/tui-winsource.c (tui_set_exec_info_content)
2538         (tui_show_exec_info_content, tui_erase_exec_info_content)
2539         (tui_clear_exec_info_content, tui_update_exec_info): Change
2540         argument to tui_source_window_base.
2541
2542 2019-06-25  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2545         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2546
2547 2019-06-25  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2550         check.
2551
2552 2019-06-25  Tom Tromey  <tom@tromey.com>
2553
2554         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2555         type to void.
2556         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2557         type to void.
2558         * tui/tui-source.c (tui_set_source_content): Update.
2559         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2560
2561 2019-06-25  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-win.c (window_name_completer, tui_set_focus)
2564         (tui_all_windows_info): Use name method.
2565         * tui/tui-data.h (struct tui_gen_win_info)
2566         (struct tui_source_window, struct tui_disasm_window)
2567         (struct tui_data_window, struct tui_cmd_window) <name>: New
2568         method.
2569         (tui_win_name): Don't declare.
2570         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2571         (tui_win_name): Remove.
2572
2573 2019-06-25  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-winsource.h (tui_update_source_window)
2576         (tui_update_source_window_as_is): Change parameter type.
2577         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2578         to be a tui_source_window_base.
2579         (tui_update_source_window_as_is): Likewise.
2580         * tui/tui-win.c (make_visible_with_new_height): Update.
2581
2582 2019-06-25  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-winsource.c (tui_erase_source_content)
2585         (tui_show_source_content, tui_show_exec_info_content)
2586         (tui_erase_exec_info_content): Use refresh_window method.
2587         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2588         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2589         from tui_refresh_win.
2590         (tui_data_window::refresh_window): New method.
2591         (tui_win_info::refresh, tui_source_window_base::refresh)
2592         (tui_refresh_all): Use refresh_window method.
2593         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2594         method.
2595         * tui/tui-regs.c (tui_display_register): Call refresh_window
2596         method.
2597         * tui/tui-layout.c (show_source_disasm_command)
2598         (show_source_or_disasm_and_command): Call refresh_window method.
2599         * tui/tui-data.h (struct tui_gen_win_info)
2600         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2601         New method.
2602
2603 2019-06-25  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui.c (tui_rl_other_window, tui_enable)
2606         (tui_is_window_visible, tui_get_command_dimension): Update.
2607         * tui/tui-winsource.c (tui_update_source_window_as_is)
2608         (tui_clear_source_content, tui_erase_source_content)
2609         (tui_show_source_line, tui_source_window_base::refill)
2610         (tui_source_window_base::do_scroll_horizontal)
2611         (tui_source_window_base::set_is_exec_point_at)
2612         (tui_update_breakpoint_info, tui_set_exec_info_content)
2613         (tui_alloc_source_buffer, tui_line_is_displayed)
2614         (tui_addr_is_displayed): Update.
2615         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2616         (tui_check_and_display_highlight_if_needed)
2617         (tui_win_info::make_visible, tui_win_info::refresh)
2618         (tui_refresh_all): Update.
2619         * tui/tui-windata.c (tui_first_data_item_displayed)
2620         (tui_delete_data_content_windows, tui_erase_data_content)
2621         (tui_display_all_data, tui_data_window::refresh_all)
2622         (tui_check_data_values): Update.
2623         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2624         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2625         (tui_win_info::backward_scroll, tui_refresh_all_win)
2626         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2627         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2628         (tui_source_window_base::set_new_height)
2629         (tui_data_window::set_new_height)
2630         (make_invisible_and_set_new_height)
2631         (make_visible_with_new_height, new_height_ok)
2632         (parse_scrolling_args): Update.
2633         * tui/tui-stack.c (tui_show_frame_info): Update.
2634         * tui/tui-source.c (tui_set_source_content)
2635         (tui_set_source_content_nil, tui_source_is_displayed)
2636         (tui_source_window::do_scroll_vertical): Update.
2637         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2638         (tui_display_registers_from, tui_display_reg_element_at_line)
2639         (tui_check_register_values, tui_reg_command): Update.
2640         * tui/tui-layout.c (tui_default_win_height)
2641         (show_source_disasm_command, show_data, init_and_make_win)
2642         (show_source_or_disasm_and_command): Update.
2643         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2644         (tui_redisplay_readline, tui_mld_flush)
2645         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2646         (tui_getc): Update.
2647         * tui/tui-disasm.c (tui_set_disassem_content)
2648         (tui_disasm_window::do_scroll_vertical): Update.
2649         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2650         Now virtual.
2651         (struct tui_win_info): Derive from tui_gen_win_info.
2652         <~tui_win_info>: Mark as override.
2653         <generic>: Remove member.
2654         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2655         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2656         (~tui_data_window, ~tui_win_info)
2657         (tui_free_all_source_wins_content): Update.
2658         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2659
2660 2019-06-25  Tom Tromey  <tom@tromey.com>
2661
2662         * tui/tui-layout.c (init_and_make_win): Use new.
2663         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2664         destructor, initializers.
2665         (tui_alloc_generic_win_info): Don't declare.
2666         * tui/tui-data.c (_locator): Add argument to constructor.
2667         (source_win, disasm_win): New globals.
2668         (exec_info): Remove.
2669         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2670         Update.
2671         (tui_alloc_generic_win_info): Remove.
2672         (init_content_element): Use new.
2673         (tui_win_info::tui_win_info): Update.
2674         (free_content_elements) <case DATA_WIN>: Use delete.
2675
2676 2019-06-25  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2679         * tui/tui-windata.c (tui_first_data_item_displayed)
2680         (tui_delete_data_content_windows): Update.
2681         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2682         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2683         (tui_display_registers_from, tui_check_register_values): Update.
2684         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2685         pointer.
2686         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2687         window.
2688         (tui_free_data_content): Update.
2689         (free_content_elements) <case DATA_WIN>: Free the window.
2690
2691 2019-06-25  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2694         Update.
2695         * tui/tui-layout.c (make_command_window)
2696         (show_source_disasm_command, show_data, init_and_make_win)
2697         (show_source_or_disasm_and_command): Update.
2698         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2699         method.
2700         <can_highight, is_highlighted>: Now bool.
2701         (tui_set_win_highlight): Don't declare.
2702         * tui/tui-data.c (tui_set_win_highlight): Remove.
2703
2704 2019-06-25  Tom Tromey  <tom@tromey.com>
2705
2706         * tui/tui-wingeneral.c (make_visible): Remove check of window
2707         type.
2708
2709 2019-06-25  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-win.c (tui_win_info::max_height)
2712         (tui_cmd_window::max_height): New methods.
2713         (new_height_ok): Call max_height.
2714         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2715         <max_height>: New method.
2716
2717 2019-06-25  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-win.c (tui_source_window_base::set_new_height)
2720         (tui_data_window::set_new_height): New methods.
2721         (make_invisible_and_set_new_height): Call set_new_height method.
2722         * tui/tui-data.h (struct tui_win_info)
2723         (struct tui_source_window_base, struct tui_data_window)
2724         <set_new_height>: New method.
2725
2726 2019-06-25  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2729         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2730         tui_refresh_data_win.
2731         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2732         method.
2733         (tui_refresh_all_win): Call the refresh_all method.
2734         (tui_set_focus): Likewise.
2735         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2736         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2737         Likewise.
2738
2739 2019-06-25  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-winsource.h (tui_refill_source_window)
2742         (tui_set_is_exec_point_at): Don't declare.
2743         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2744         (tui_source_window_base::refill): Rename from
2745         tui_refill_source_window.
2746         (tui_source_window_base::do_scroll_horizontal): Update.
2747         (tui_source_window_base::set_is_exec_point_at): Rename from
2748         tui_set_is_exec_point_at.
2749         (tui_update_all_breakpoint_info): Update.
2750         * tui/tui-stack.c (tui_show_frame_info): Update.
2751         * tui/tui-layout.c (show_data): Add cast.
2752         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2753         * tui/tui-data.h (struct tui_source_window_base) <refill,
2754         set_is_exec_point_at>: New methods.
2755         (tui_source_windows, tui_add_to_source_windows): Update types.
2756         (tui_add_to_source_windows): Remove redundant declaration.
2757         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2758         (tui_source_windows): Change return type.
2759         (tui_clear_source_windows_detail): Update.
2760         (tui_add_to_source_windows): Change type of parameter.
2761         (tui_free_all_source_wins_content): Update.
2762
2763 2019-06-25  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-wingeneral.c (tui_win_info::refresh)
2766         (tui_source_window_base::refresh): New methods.
2767         (tui_refresh_all): Call the refresh method.
2768         * tui/tui-data.h (struct tui_win_info)
2769         (struct tui_source_window_base) <refresh>: New method.
2770
2771 2019-06-25  Tom Tromey  <tom@tromey.com>
2772
2773         * tui/tui.h (tui_is_window_visible): Return bool.
2774         * tui/tui.c (tui_is_window_visible): Return bool.
2775         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2776         (tui_make_visible, tui_make_invisible)
2777         (tui_win_info::make_visible)
2778         (tui_source_window_base::make_visible, make_all_visible)
2779         (tui_make_all_visible, tui_make_all_invisible): Update.
2780         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2781         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2782         bool.
2783         (struct tui_win_info, struct tui_source_window_base)
2784         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2785         * tui/tui-data.c (tui_init_generic_part): Update.
2786
2787 2019-06-25  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2790         (tui_source_window_base::make_visible): New methods.
2791         (make_all_visible): Make method call.
2792         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2793         (struct tui_source_window_base, struct tui_cmd_window): Override
2794         make_visible.
2795         (tui_win_is_source_type): Don't declare.
2796         * tui/tui-data.c (tui_win_is_source_type): Remove.
2797
2798 2019-06-25  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2801         NULL check.
2802
2803 2019-06-25  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2806         Inline constructor.  Add initializers for members.
2807         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2808         constructors; now inline in class.
2809
2810 2019-06-25  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-regs.c (tui_show_registers): Update.
2813         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2814         bool.
2815         * tui/tui-data.c (tui_data_window::clear_detail)
2816         (tui_data_window): Update.
2817
2818 2019-06-25  Tom Tromey  <tom@tromey.com>
2819
2820         * tui/tui-windata.c (tui_display_all_data)
2821         (tui_display_data_from_line, tui_display_data_from)
2822         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2823         Update.
2824         * tui/tui-regs.c (tui_last_regs_line_no)
2825         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2826         (tui_show_registers, tui_show_register_group)
2827         (tui_display_registers_from, tui_display_reg_element_at_line)
2828         (tui_display_registers_from_line, tui_check_register_values)
2829         (tui_reg_next, tui_reg_prev): Update.
2830         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2831         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2832         tui_data_window.
2833         (struct tui_win_info) <detail>: Remove.  Add new fields from
2834         tui_data_info.
2835         (TUI_DATA_WIN): Add cast.
2836         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2837         (~tui_data_window): Simplify.
2838
2839 2019-06-25  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-layout.c (show_source_disasm_command)
2842         (show_source_or_disasm_and_command): Update.
2843         * tui/tui-io.c (update_cmdwin_start_line)
2844         (tui_redisplay_readline): Update.
2845         * tui/tui-data.h (struct tui_command_info): Remove.
2846         (struct tui_win_info) <detail>: Remove command_info member.
2847         (struct tui_data_window) <start_line>: New member, from
2848         tui_command_info.
2849         (TUI_CMD_WIN): Add casts.
2850
2851 2019-06-25  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-winsource.c (tui_update_source_window)
2854         (tui_refill_source_window)
2855         (tui_source_window_base::do_scroll_horizontal)
2856         (tui_update_breakpoint_info, tui_set_exec_info_content)
2857         (tui_show_exec_info_content, tui_erase_exec_info_content)
2858         (tui_clear_exec_info_content): Update.
2859         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2860         Update.
2861         * tui/tui-win.c (make_invisible_and_set_new_height)
2862         (make_visible_with_new_height): Update.
2863         * tui/tui-source.c (tui_set_source_content)
2864         (tui_show_symtab_source): Update.
2865         * tui/tui-layout.c (extract_display_start_addr)
2866         (show_source_disasm_command, show_data)
2867         (make_source_or_disasm_window)
2868         (show_source_or_disasm_and_command): Update.
2869         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2870         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2871         "gdbarch".
2872         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2873         to tui_source_window_base.
2874         (struct tui_win_info) <detail>: Remove source_info member.
2875         (struct tui_source_window_base) <has_locator>: Inline.
2876         Move contents from tui_source_info; rename has_locator member to
2877         m_has_locator.
2878         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2879         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2880         header file.
2881         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2882         Simplify.
2883         (tui_free_all_source_wins_content): Cast to
2884         tui_source_window_base.
2885
2886 2019-06-25  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-win.c (make_invisible_and_set_new_height)
2889         (make_visible_with_new_height): Call has_locator method.
2890         * tui/tui-layout.c (show_source_disasm_command, show_data)
2891         (show_source_or_disasm_and_command): Update for bool change.
2892         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2893         (tui_win_info) <has_locator>: New method.
2894         (struct tui_source_window_base) <has_locator>: New method.
2895         (tui_win_has_locator): Don't declare.
2896         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2897         from tui_win_has_locator.
2898         (tui_source_window_base): Use false, not FALSE.
2899
2900 2019-06-25  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2903         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2904         clear_detail method directly.
2905         (tui_clear_win_detail): Remove.
2906
2907 2019-06-25  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2910         "this", not TUI_DISASM_WIN.
2911
2912 2019-06-25  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2915         declare.
2916         * tui/tui-winsource.c
2917         (tui_source_window_base::do_scroll_horizontal): Rename from
2918         tui_horizontal_source_scroll.
2919         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2920         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2921         from tui_vertical_data_scroll.
2922         * tui/tui-win.h (tui_scroll): Don't declare.
2923         * tui/tui-win.c (tui_win_info::forward_scroll)
2924         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2925         (tui_win_info::right_scroll): Rename and update.
2926         (tui_scroll_forward_command, tui_scroll_backward_command)
2927         (tui_scroll_left_command, tui_scroll_right_command): Update.
2928         (tui_scroll): Remove.
2929         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2930         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2931         from tui_vertical_source_scroll.
2932         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2933         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2934         from tui_vertical_disassem_scroll.
2935         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2936         do_scroll_horizontal>: New methods.
2937         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2938         Likewise.
2939         (struct tui_source_window_base): Add do_scroll_horizontal.
2940         (struct tui_source_window, struct tui_disasm_window): Add
2941         do_scroll_vertical.
2942         (struct tui_data_window, struct tui_cmd_window): Add
2943         do_scroll_horizontal and do_scroll_vertical.
2944         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2945
2946 2019-06-25  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-data.h (struct tui_source_window_base): New struct.
2949         (struct tui_source_window): Derive from tui_source_window_base.
2950         (struct tui_disasm_window): New struct.
2951         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2952         from tui_source_window::clear_detail.
2953         (tui_source_window_base): Rename from tui_source_window.
2954         (~tui_source_window_base): Rename from ~tui_source_window.
2955         (tui_alloc_win_info): Create a tui_disasm_window.
2956
2957 2019-06-25  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-data.h (struct tui_source_window)
2960         (struct tui_data_window): Declare destructors.
2961         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2962         destructors.
2963         (tui_win_info): Simplify.
2964
2965 2019-06-25  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-winsource.c (tui_display_main)
2968         (tui_update_source_windows_with_addr)
2969         (tui_update_all_breakpoint_info): Update.
2970         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2971         (new_height_ok, parse_scrolling_args): Update.
2972         * tui/tui-stack.c (tui_show_frame_info): Update.
2973         * tui/tui-data.h (struct tui_list): Remove.
2974         (tui_source_windows): Return a reference to a std::vector.
2975         * tui/tui-data.c (source_windows): Now a std::vector.
2976         (tui_source_windows): Change return type.
2977         (tui_clear_source_windows): Rewrite.
2978         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2979         (tui_free_all_source_wins_content): Rewrite.
2980
2981 2019-06-25  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2984         (struct tui_data_window, struct tui_cmd_window): Declare
2985         clear_detail method.
2986         * tui/tui-data.c (tui_source_window::clear_detail)
2987         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2988         methods.
2989         (tui_clear_win_detail): Simplify.
2990
2991 2019-06-25  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-layout.c (make_source_window, make_disasm_window)
2994         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2995         Return the new window.
2996         (show_source_disasm_command, show_data)
2997         (show_source_or_disasm_and_command): Update.
2998
2999 2019-06-25  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3002         parameter.  Return the new window.
3003         (show_source_disasm_command): Update and remove NULL check.
3004         (show_source_or_disasm_and_command): Update.
3005
3006 2019-06-25  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3009
3010 2019-06-25  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-data.h (struct tui_win_info): Make constructor
3013         protected.  Make destructor virtual.  Add initializers.
3014         (tui_source_window, tui_data_window, tui_cmd_window): New
3015         classes.
3016         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3017         constructor.  Add "type" parameter.
3018         (tui_source_window, tui_data_window, tui_cmd_window): New
3019         constructors.
3020         (tui_alloc_win_info): Instantiate the appropriate subclass.
3021
3022 2019-06-25  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-win.c (tui_resize_all): Use delete.
3025         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3026         destructor.
3027         (tui_free_window): Don't declare.
3028         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3029         Update.
3030
3031 2019-06-25  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-data.h (struct tui_win_info): Add constructor.
3034         * tui/tui-data.c (tui_alloc_win_info): Use new.
3035         (tui_free_window): Use delete.
3036
3037 2019-06-22  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3040         declare.
3041         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3042
3043 2019-06-22  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3046         declare.
3047         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3048
3049 2019-06-22  Tom de Vries  <tdevries@suse.de>
3050
3051         * dwarf2read.c (create_addrmap_from_aranges)
3052         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3053         instead of '%zu'.
3054
3055 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3056
3057         * dwarf2read.h (dwarf2_section_info_def): Remove.
3058         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3059         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3060         std::vector<dwarf2_section_info>.
3061         (struct dwo_file) <~dwo_file>: Remove.
3062         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3063         types field.
3064         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3065         (dwarf2_read_debug_names): Likewise.
3066         (create_debug_types_hash_table): Change parameter type to
3067         array_view, adjust code accordingly.
3068         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3069         (partial_die_info::fixup): Likewise.
3070         (determine_prefix): Likewise.
3071         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3072
3073 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3074
3075         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3076         gdb_bfd_ref_ptr.
3077         <~dwo_file>: Remove call to gdb_bfd_unref.
3078         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3079         gdb_bfd_ref_ptr::get.
3080
3081 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3082
3083         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3084         type to htab_up.
3085         * dwarf2read.c (struct dwo_file): Initialize fields.
3086         <~dwo_file>: New.
3087         (free_dwo_file): Remove, move content to ~dwo_file.
3088         (struct dwo_file_deleter): Remove.
3089         (dwo_file_up>: Remove custom deleter.
3090         (free_dwo_files): Remove.
3091         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3092         dwo_files.
3093         (process_skeletonless_type_units): Call unique_ptr::get.
3094         (allocate_dwo_file_hash_table): Add deleter to created hash
3095         table.  Change return type to htab_up.
3096         (lookup_dwo_file_slot): Don't memset dwo_file, call
3097         unique_ptr::get.
3098         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3099         (create_dwo_unit_in_dwp_v2): Likewise.
3100         (open_and_init_dwo_file): Likewise.
3101         (free_dwo_file_from_slot): Remove.
3102
3103 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3104
3105         * dwarf2read.h (struct dwarf2_section_info) <readin,
3106         is_virtual>: Change type to bool.
3107         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3108         true instead of 1.
3109
3110 2019-06-19  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-data.h (tui_init_content_element): Don't declare.
3113
3114 2019-06-19  Tom Tromey  <tom@tromey.com>
3115
3116         * tui/tui-data.h (tui_init_win_info): Don't declare.
3117
3118 2019-06-19  Tom de Vries  <tdevries@suse.de>
3119
3120         * dwarf2read.h (abstract_to_concrete): Change type to
3121         std::unordered_map<sect_offset, std::vector<sect_offset>,
3122         gdb::hash_enum<sect_offset>>.
3123
3124 2019-06-19  Tom Tromey  <tromey@adacore.com>
3125
3126         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3127         EVAL_AVOID_SIDE_EFFECTS specially.
3128
3129 2019-06-19  Tom Tromey  <tromey@adacore.com>
3130
3131         * source-cache.c (highlighter): New global.
3132         (source_cache::get_source_lines): Create a highlighter on demand.
3133
3134 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3135
3136         * defs.h (deprecated_interactive_hook): Delete declaration.
3137         * interps.c (clear_interpreter_hooks): Remove use of
3138         deprecated_interactive_hook.
3139         * top.c (deprecated_interactive_hook): Delete definition.
3140         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3141
3142 2019-06-18  Tom de Vries  <tdevries@suse.de>
3143
3144         PR gdb/24515
3145         * dwarf2read.h (abstract_to_concrete): Change type from
3146         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3147         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3148         * dwarf2read.c (read_variable): Update.
3149         (dwarf2_fetch_die_loc_sect_off): Update.
3150
3151 2019-06-17  Tom de Vries  <tdevries@suse.de>
3152
3153         PR gdb/24617
3154         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3155         accessing parent[parent_len - 1].
3156
3157 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3158
3159         PR gdb/24364
3160         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3161         call dtrace_process_dof with NULL dof.
3162
3163 2019-06-16  Tom de Vries  <tdevries@suse.de>
3164
3165         PR gdb/24445
3166         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3167
3168 2019-06-16  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3171         (make_all_visible): Use address of member.
3172
3173 2019-06-16  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3176         (tui_free_window, free_content, free_content_elements): Remove
3177         unnecessary cast.
3178         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3179         cast.
3180         * tui/tui-regs.c (tui_show_register_group)
3181         (tui_display_registers_from, tui_display_reg_element_at_line):
3182         Remove unnecessary cast.
3183
3184 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * linux-nat.c (normal_mask): Delete.
3187         (_initialize_linux_nat): Don't initialise normal_mask.
3188
3189 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3190
3191         PR gdb/24445
3192         * dwarf-index-write.h (write_psymtabs_to_index): Add
3193         dwz_basename parameter.
3194         * dwarf-index-write.c (write_gdbindex): Move file writing to
3195         write_gdbindex_1.  Change return type void.
3196         (assert_file_size): Move up, remove filename parameter.
3197         (write_gdbindex_1): New function.
3198         (write_debug_names): Change return type to void, call
3199         assert_file_size.
3200         (struct index_wip_file): New struct.
3201         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3202         file logic to index_wip_file.  Write index for dwz file if
3203         needed.
3204         (save_gdb_index_command): Pass basename of dwz file, if present.
3205         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3206         build-id of dwz file, if present.
3207         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3208         (dwarf2_get_dwz_file): Likewise.
3209         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3210         (dwarf2_get_dwz_file): Likewise.
3211
3212 2019-06-16  Tom Tromey  <tom@tromey.com>
3213
3214         * coffread.c (process_coff_symbol): Use xstrdup.
3215         * value.c (create_internalvar): Use xstrdup.
3216
3217 2019-06-16  Tom Tromey  <tom@tromey.com>
3218
3219         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3220         * breakpoint.c (stopin_command, stopat_command)
3221         (until_break_command, decode_location_default): Remove unnecessary
3222         cast.
3223         * utils.c (subset_compare): Remove unnecessary cast.
3224         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3225         cast.
3226         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3227         cast.
3228         * infcmd.c (path_command): Remove unnecessary cast.
3229         * coffread.c (decode_type): Remove unnecessary cast.
3230         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3231         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3232         * tui/tui-stack.c (tui_show_locator_content)
3233         (tui_show_frame_info): Remove unnecessary cast.
3234         * tui/tui-win.c (tui_scroll_forward_command)
3235         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3236         (parse_scrolling_args): Remove unnecessary cast.
3237         * tui/tui-data.c (init_win_info, tui_del_window)
3238         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3239         (free_content_elements): Remove unnecessary cast.
3240         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3241         unnecessary cast.
3242         * tui/tui-source.c (tui_set_source_content)
3243         (tui_vertical_source_scroll): Remove unnecessary cast.
3244         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3245         cast.
3246         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3247         * tui/tui-regs.c (tui_display_registers_from)
3248         (tui_display_register): Remove unnecessary cast.
3249         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3250         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3251         (make_visible): Remove unnecessary cast.
3252         * tui/tui-winsource.c (tui_erase_source_content)
3253         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3254         unnecessary cast.
3255         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3256         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3257         * stabsread.c (read_type, read_array_type, read_range_type):
3258         Remove unnecessary cast.
3259         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3260         (parse_symbol, parse_type, upgrade_type, parse_external)
3261         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3262         unnecessary cast.
3263         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3264
3265 2019-06-16  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-data.c (tui_alloc_generic_win_info)
3268         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3269         checks.
3270
3271 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3272             Andrew Burgess  <andrew.burgess@embecosm.com>
3273
3274         * f-typeprint.c (f_print_type): Don't return early for not
3275         associated or not allocated types.
3276         (f_type_print_varspec_suffix): Add print_rank parameter and print
3277         ranks of array types in case they dangling.
3278         (f_type_print_base): Add print_rank parameter.
3279
3280 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3281
3282         * NEWS: Mention new MI commands.
3283         * break-catch-throw.c (enum exception_event_kind): Move to
3284         breakpoint.h.
3285         (print_mention_exception_catchpoint): Output text as a single
3286         message.
3287         (catch_exception_command_1): Rename to...
3288         (catch_exception_event): ...this, make non-static, update header
3289         command, and change some parameter types.
3290         (catch_catch_command): Update for changes to
3291         catch_exception_command_1.
3292         (catch_throw_command): Likewise.
3293         (catch_rethrow_command): Likewise.
3294         * breakpoint.c (enum exception_event_kind): Delete.
3295         * breakpoint.h (enum exception_event_kind): Moved here from
3296         break-catch-throw.c.
3297         (catch_exception_event): Declare.
3298         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3299         (mi_cmd_catch_throw): New function.
3300         (mi_cmd_catch_rethrow): New function.
3301         (mi_cmd_catch_catch): New function.
3302         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3303         'catch-catch' entries.
3304         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3305         (mi_cmd_catch_rethrow): Declare.
3306         (mi_cmd_catch_catch): Declare.
3307
3308 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3309
3310         * annotate.c (annotate_source_line): Change return type to void,
3311         update implementation to match.
3312         * annotate.h (annotate_source_line): Change return type to void,
3313         update header comment.
3314         * stack.c (print_frame_info): Don't change what frame information
3315         is printed based on whether annotations are on or not.
3316
3317 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3318
3319         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3320         (annotate_source): Make static.
3321         (annotate_source_line): Moved from source.c and renamed from
3322         identify_source_line.  Update the return type.
3323         * annotate.h (annotate_source): Delete declaration.
3324         (annotate_source_line): Declaration moved from source.h, and
3325         renamed from identify_source_line.  Return type updated.
3326         * source.c (identify_source_line): Moved to annotate.c and renamed
3327         to annotate_source_line.
3328         (info_line_command): Remove check of annotation_level.
3329         * source.h (identify_source_line): Move declaration to annotate.h
3330         and rename to annotate_source_line.
3331         * stack.c: Add 'annotate.h' include.
3332         (print_frame_info): Remove check of annotation_level before
3333         calling annotate_source_line.
3334
3335 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3336
3337         * source-cache.c (source_cache::get_plain_source_lines): Use
3338         open_source_file_with_line_charpos instead of just
3339         open_source_file, remove call to find_source_lines.
3340         (source_cache::get_source_lines): Likewise.
3341         * source.c (find_source_lines): Make static.
3342         (get_filename_and_charpos): Renamed into...
3343         (open_source_file_with_line_charpos): ..this along with changes to
3344         return a scoped_fd, and some other minor clean ups.
3345         (identify_source_line): Use open_source_file_with_line_charpos.
3346         (search_command_helper): Use open_source_file_with_line_charpos
3347         instead of just open_source_file, remove call to
3348         find_source_lines.
3349         * source.h (open_source_file_with_line_charpos): Declare new
3350         function.
3351         (find_source_lines): Delete declaration.
3352
3353 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         * source.c (get_filename_and_charpos): Remove fullname
3356         parameter.
3357         (identify_source_line): Update call to get_filename_and_charpos.
3358
3359 2019-06-14  Tom Tromey  <tromey@adacore.com>
3360
3361         PR gdb/24502:
3362         * ui-style.h (skip_ansi_escape): Update comment.
3363         * ui-file.h (class no_terminal_escape_file): New class.
3364         * ui-file.c (no_terminal_escape_file::write)
3365         (no_terminal_escape_file::puts): New methods.
3366         * cli/cli-logging.c (handle_redirections): Use
3367         no_terminal_escape_file.
3368
3369 2019-06-14  Tom Tromey  <tromey@adacore.com>
3370
3371         * NEWS: Move convenience variable news above Python news.
3372
3373 2019-06-14  Tom Tromey  <tom@tromey.com>
3374
3375         * gnulib: Move directory to top-level.
3376         * configure.ac: Don't configure gnulib.
3377         * configure: Rebuild.
3378         * common/common-defs.h: Use new path to gnulib.
3379         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3380         (GNULIB_H): Remove.
3381         (INCGNU): Look in new gnulib location.
3382         (HFILES_NO_SRCDIR): Remove gnulib files.
3383         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3384         (generated_files): Remove GNULIB_H.
3385         ($(LIBGNU), all-lib): Remove targets.
3386         (distclean): Don't mention GNULIB_BUILDDIR.
3387         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3388
3389 2019-06-14  Tom Tromey  <tromey@adacore.com>
3390
3391         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3392         Warn if symbol file does not provide any symbols.
3393
3394 2019-06-14  Tom Tromey  <tromey@adacore.com>
3395
3396         * source.c (find_and_open_source): Respect basenames_may_differ.
3397
3398 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * annotate.c (annotate_breakpoints_invalid): Make use of
3401         scoped_restore_terminal_state.
3402         (annotate_frames_invalid): Likewise.
3403
3404 2019-06-14  Tom Tromey  <tromey@adacore.com>
3405
3406         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3407         allow assignment to an internalvar.
3408
3409 2019-06-14  Tom Tromey  <tromey@adacore.com>
3410
3411         * ada-lex.l: Allow "_" in attribute names.
3412
3413 2019-06-14  Tom Tromey  <tromey@adacore.com>
3414
3415         PR gdb/24653:
3416         * regcache.c (registers_changed): Don't call alloca.
3417         * top.c (execute_command): Don't call alloca.
3418
3419 2019-06-13  Pedro Alves  <palves@redhat.com>
3420
3421         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3422         'expression'.  When parsing an expression, error out if there's
3423         junk after "unlimited".
3424         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3425         (do_set_command): Adjust calls to is_unlimited_literal.
3426
3427 2019-06-13  Pedro Alves  <palves@redhat.com>
3428
3429         * compile/compile.c (make_compile_options_def_group): Add braces
3430         around array_view initializer.
3431         * thread.c (make_thread_apply_all_options_def_group)
3432         (make_thread_apply_all_options_def_group): Likewise.
3433
3434 2019-06-13  Pedro Alves  <palves@redhat.com>
3435
3436         * NEWS (New commands): Mention "maint test-options
3437         require-delimiter", "maint test-options unknown-is-error", "maint
3438         test-options unknown-is-operand" and "maint show
3439         test-options-completion-result".
3440         (New command options, command completion): New section.
3441         (Completion improvements): New section.
3442         Mention that you can abbreviate "unlimited".
3443
3444 2019-06-13  Pedro Alves  <palves@redhat.com>
3445
3446         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3447         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3448         * unittests/cli-utils-selftests.c (test_parse_flags)
3449         (test_parse_flags_qcs): Delete.
3450         (test_cli_utils): Don't call deleted functions.
3451
3452 2019-06-13  Pedro Alves  <palves@redhat.com>
3453
3454         * thread.c: Include "cli/cli-option.h".
3455         (tp_array_compar_ascending): Global.
3456         (tp_array_compar): Delete function.
3457         (tp_array_compar_ascending, tp_array_compar_descending): New
3458         functions.
3459         (ascending_option_def, qcs_flag_option_def)
3460         (thr_qcs_flags_option_defs)
3461         (make_thread_apply_all_options_def_group)
3462         (make_thread_apply_options_def_group): New.
3463         (thread_apply_all_command): Use gdb::option::process_options.
3464         (thread_apply_command_completer)
3465         (thread_apply_all_command_completer): New.
3466         (thread_apply_command): Use gdb::option::process_options.
3467         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3468         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3469         to generate help text of "thread apply".  Adjust "taas"'s help.
3470         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3471         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3472
3473 2019-06-13  Pedro Alves  <palves@redhat.com>
3474
3475         * thread.c (thread_apply_command): Check for invalid TID with
3476         isdigit instead of !isalpha.
3477
3478 2019-06-13  Pedro Alves  <palves@redhat.com>
3479
3480         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3481         (validate_flags_qcs): New.
3482         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3483         (validate_flags_qcs): Declare.
3484         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3485         (make_frame_apply_options_def_group): New.
3486         (frame_apply_command_count): Process options with
3487         gdb::option::process_options.
3488         (frame_apply_completer): New.
3489         (frame_apply_level_completer, frame_apply_all_completer)
3490         (frame_apply_completer): New.
3491         (_initialize_stack): Update help of "frame apply", "frame apply
3492         level", "frame apply all" and "faas" to mention supported options
3493         and install command completers.
3494         * stack.h (frame_apply_all_completer): Declare.
3495         * thread.c: Include "stack.h".
3496         (tfaas_command): Add "--".
3497         (_initialize_thread): Update help "tfaas" to mention supported
3498         options and install command completer.
3499
3500 2019-06-13  Pedro Alves  <palves@redhat.com>
3501
3502         * completer.c (complete_nested_command_line): New.
3503         (gdb_completion_word_break_characters_throw): Add assertion.
3504         * completer.h (complete_nested_command_line): Declare.
3505
3506 2019-06-13  Pedro Alves  <palves@redhat.com>
3507
3508         * stack.c (parse_backtrace_qualifiers): New.
3509         (backtrace_command): Use it.
3510         (backtrace_command_completer): Complete on qualifiers.
3511
3512 2019-06-13  Pedro Alves  <palves@redhat.com>
3513
3514         * frame.c: Include "cli/cli-option.h.
3515         (user_set_backtrace_options): New.
3516         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3517         Delete.
3518         (get_prev_frame): Adjust.
3519         (boolean_option_def, uinteger_option_def)
3520         (set_backtrace_option_defs): New.
3521         (_initialize_frame): Adjust and use
3522         gdb::option::add_setshow_cmds_for_options to install "set
3523         backtrace past-main" and "set backtrace past-entry".
3524         * frame.h: Include "cli/cli-option.h".
3525         (struct frame_print_options): Forward declare.
3526         (print_frame_arguments_all, print_frame_arguments_scalars)
3527         (print_frame_arguments_none): Declare.
3528         (print_entry_values): Delete declaration.
3529         (struct frame_print_options, user_frame_print_options): New.
3530         (struct set_backtrace_options): New.
3531         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3532         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3533         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3534         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3535         (list_args_or_locals): Add frame_print_options parameter.
3536         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3537         * python/py-framefilter.c (enumerate_args): Pass down
3538         USER_FRAME_PRINT_OPTIONS.
3539         * stack.c: Include "cli/cli-option.h".
3540         (print_frame_arguments_all, print_frame_arguments_scalars)
3541         (print_frame_arguments_none): Declare.
3542         (print_raw_frame_arguments, print_entry_values): Delete.
3543         (user_frame_print_options): New.
3544         (boolean_option_def, enum_option_def, frame_print_option_defs):
3545         New.
3546         (struct backtrace_cmd_options): New.
3547         (bt_flag_option_def): New.
3548         (backtrace_command_option_defs): New.
3549         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3550         (print_frame_arg, read_frame_arg, print_frame_args)
3551         (print_frame_info, print_frame): Add frame_print_options parameter
3552         and use it.
3553         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3554         (backtrace_command_1): Add frame_print_options and
3555         backtrace_cmd_options parameters and use them.
3556         (make_backtrace_options_def_group): New.
3557         (backtrace_command): Process command options with
3558         gdb::option::process_options.
3559         (backtrace_command_completer): New.
3560         (_initialize_stack): Extend "backtrace"'s help to mention
3561         supported options.  Install completer for "backtrace".
3562         Install some settings commands with add_setshow_cmds_for_options.
3563
3564 2019-06-13  Pedro Alves  <palves@redhat.com>
3565
3566         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3567         and that "set/show print raw frame-arguments" are now deprecated.
3568
3569         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3570         command.
3571         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3572         * stack.c (_initialize_stack): Install "set/show print
3573         raw-frame-arguments", and deprecate "set/show print raw
3574         frame-arguments".
3575         * valprint.c (_initialize_valprint): Deprecate "set/show print
3576         raw".
3577
3578 2019-06-13  Pedro Alves  <palves@redhat.com>
3579
3580         * compile/compile.c (struct compile_options): New.
3581         (compile_flag_option_def, compile_command_option_defs)
3582         (make_compile_options_def_group): New.
3583         (compile_file_command): Handle options with
3584         gdb::option::process_options.
3585         (compile_file_command_completer): New function.
3586         (compile_code_command): Handle options with
3587         gdb::option::process_options.
3588         (compile_code_command_completer): New function.
3589         (_initialize_compiler): Install completers for "compile code" and
3590         "compile file".  Mention available options in "compile code" and
3591         "compile code"'s help.
3592         * completer.c (advance_to_completion_word): New, factored out from
3593         ...
3594         (advance_to_expression_complete_word_point): ... this.
3595         (advance_to_filename_complete_word_point): New.
3596         * completer.h (advance_to_filename_complete_word_point): New
3597         declaration.
3598
3599 2019-06-13  Pedro Alves  <palves@redhat.com>
3600
3601         * compile/compile.c: Include "cli/cli-option.h".
3602         (compile_print_value): Scope data pointer is now a
3603         value_print_options pointer; adjust.
3604         (compile_print_command): Process options.  Scope data pointer is
3605         now a value_print_options pointer; adjust.
3606         (_initialize_compile): Update "compile print"'s help to include
3607         supported options.  Install a completer for "compile print".
3608         * cp-valprint.c (show_vtblprint, show_objectprint)
3609         (show_static_field_print): Delete.
3610         (_initialize_cp_valprint): Don't install "set print
3611         static-members", "set print vtbl", "set print object" here.
3612         * printcmd.c: Include "cli/cli-option.h" and
3613         "common/gdb_optional.h".
3614         (print_command_parse_format): Rework to fill in a
3615         value_print_options instead of a format_data.
3616         (print_value): Change parameter type from format_data pointer to
3617         value_print_options reference.  Adjust.
3618         (print_command_1): Process options.  Adjust to pass down a
3619         value_print_options.
3620         (print_command_completer): New.
3621         (_initialize_printcmd): Install print_command_completer as
3622         handle_brkchars completer for the "print" command.  Update
3623         "print"'s help to include supported options.
3624         * valprint.c: Include "cli/cli-option.h".
3625         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3626         here from cp-valprint.c.
3627         (boolean_option_def, uinteger_option_def)
3628         (value_print_option_defs, make_value_print_options_def_group):
3629         New.  Use gdb::option::add_setshow_cmds_for_options to install
3630         "set print elements", "set print null-stop", "set print repeats",
3631         "set print pretty", "set print union", "set print array", "set
3632         print address", "set print symbol", "set print array-indexes".
3633         * valprint.h: Include <string> and "cli/cli-option.h".
3634         (make_value_print_options_def_group): Declare.
3635         (print_value): Change parameter type from format_data pointer to
3636         value_print_options reference.
3637         (print_command_completer): Declare.
3638
3639 2019-06-13  Pedro Alves  <palves@redhat.com>
3640
3641         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3642         (COMMON_SFILES): Add maint-test-settings.c.
3643         * cli/cli-decode.c (boolean_enums): New global, factored out from
3644         ...
3645         (add_setshow_boolean_cmd): ... here.
3646         * cli/cli-decode.h (boolean_enums): Declare.
3647         * cli/cli-option.c: New file.
3648         * cli/cli-option.h: New file.
3649         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3650         factored out from ...
3651         (parse_cli_boolean_value(const char *)): ... this.
3652         (is_unlimited_literal): Change parameter type to pointer to
3653         pointer.  Adjust and advance ARG pointer.
3654         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3655         (parse_cli_var_enum): New, factored out from ...
3656         (do_set_command): ... this.  Adjust.
3657         * cli/cli-setshow.h (parse_cli_boolean_value)
3658         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3659         (parse_cli_var_enum): Declare.
3660         * cli/cli-utils.c: Include "cli/cli-option.h".
3661         (get_ulongest): New.
3662         * cli/cli-utils.h (get_ulongest): Declare.
3663         (check_for_argument): New overloads.
3664         * maint-test-options.c: New file.
3665
3666 2019-06-13  Pedro Alves  <palves@redhat.com>
3667
3668         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3669         parse a range if "-" is at the end of the string.
3670
3671 2019-06-13  Pedro Alves  <palves@redhat.com>
3672
3673         * cli/cli-setshow.c (parse_auto_binary_operation)
3674         (parse_cli_boolean_value): Don't allow "o".
3675
3676 2019-06-13  Pedro Alves  <palves@redhat.com>
3677
3678         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3679         * NEWS: Mention maint test-settings KIND.
3680         * maint-test-settings.c: New file.
3681
3682 2019-06-13  Pedro Alves  <palves@redhat.com>
3683
3684         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3685         completer.
3686         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3687         "set" completers.
3688
3689 2019-06-13  Pedro Alves  <palves@redhat.com>
3690
3691         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3692         after item.
3693
3694 2019-06-13  Pedro Alves  <palves@redhat.com>
3695
3696         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3697
3698 2019-06-13  Pedro Alves <palves@redhat.com>
3699
3700         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3701         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3702         call.
3703         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3704         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3705         calls.
3706         (check_for_argument): Skip spaces after argument.
3707
3708 2019-06-13  Pedro Alves  <palves@redhat.com>
3709
3710         * thread.c (thread_apply_command): Adjust TID parsing.
3711         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3712         detected before end of string.
3713         (tid_is_in_list): Error out if LIST is invalid.
3714
3715 2019-06-13  Pedro Alves  <palves@redhat.com>
3716
3717         * completer.c (complete_line_internal_1): Rewind completion word
3718         point.
3719         (completion_tracker::advance_custom_word_point_by): Change
3720         parameter type to int.
3721         * completer.h (completion_tracker::advance_custom_word_point_by):
3722         Likewise.
3723
3724 2019-06-13  Pedro Alves  <palves@redhat.com>
3725
3726         * completer.c (advance_to_completion_word): Handle delimiters.
3727
3728 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3729
3730         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3731
3732 2019-06-11  Tom Tromey  <tom@tromey.com>
3733
3734         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3735         (xmalloc_failed): Move to alloc.c.
3736         * alloc.c: New file.
3737         * Makefile.in (COMMON_SFILES): Add alloc.c.
3738
3739 2019-06-11  Tom Tromey  <tom@tromey.com>
3740
3741         * nat/linux-waitpid.c: Don't include server.h.
3742         (linux_debug): Remove.
3743         (my_waitpid): Update.
3744
3745 2019-06-11  Tom Tromey  <tromey@adacore.com>
3746
3747         * infcall.c (_initialize_infcall): Remove trailing newline from
3748         help.
3749         * user-regs.c (_initialize_user_regs): Remove trailing newline
3750         from help.
3751         * typeprint.c (_initialize_typeprint): Remove trailing newline
3752         from help.
3753         * reverse.c (_initialize_reverse): Remove trailing newlines from
3754         help.
3755         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3756         from help.
3757         * language.c (add_set_language_command): Remove trailing newline
3758         from help.
3759         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3760         help.
3761         * disasm.c (_initialize_disasm): Remove trailing newline from
3762         help.
3763         * top.c (init_main): Remove trailing newline from help.
3764         * interps.c (_initialize_interpreter): Remove trailing newline
3765         from help.
3766         * btrace.c (_initialize_btrace): Remove trailing newlines from
3767         help.
3768         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3769         from help.
3770         * python/python.c (_initialize_python): Remove trailing newline
3771         from help.
3772         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3773         help.
3774         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3775         from help.  Reformat some text.
3776         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3777         from help.
3778         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3779         newline from help.
3780
3781 2019-06-11  Tom Tromey  <tromey@adacore.com>
3782
3783         * darwin-nat.c (darwin_decode_exception_message)
3784         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3785
3786 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * valops.c (value_slice): Check for not allocated or not
3789         associated values.
3790
3791 2019-06-10  Tom de Vries  <tdevries@suse.de>
3792
3793         PR gdb/24618
3794         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3795         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3796         invalid.
3797
3798 2019-06-10  Tom de Vries  <tdevries@suse.de>
3799
3800         PR gdb/24611
3801         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3802         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3803
3804 2019-06-10  Tom de Vries  <tdevries@suse.de>
3805
3806         PR symtab/24545
3807         * symtab.c (struct demangled_name_entry): Add language field.
3808         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3809         static minimal symbol".  Set and use language field.
3810
3811 2019-06-10  Tom Tromey  <tromey@adacore.com>
3812
3813         * ada-lang.c (_initialize_ada_language): Update help text.
3814
3815 2019-06-10  Tom Tromey  <tromey@adacore.com>
3816
3817         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3818         with a newline.
3819         * guile/guile.c (handle_boot_error): Don't end warning with a
3820         newline.
3821         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3822         warning with a newline.
3823         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3824         newline.
3825         (s12z_frame_cache): Likewise.
3826         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3827         a newline.
3828         * solib-svr4.c (disable_probes_interface): Don't end warning with
3829         a newline.
3830         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3831         newline.
3832         * python/python.c (do_finish_initialization): Don't end warning
3833         with a newline.
3834
3835 2019-06-10  Tom Tromey  <tom@tromey.com>
3836
3837         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3838         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3839         gdbpy_enter.
3840
3841 2019-06-10  Tom Tromey  <tromey@adacore.com>
3842
3843         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3844         data.
3845         (elf_new_init): Don't call stabsread_new_init.
3846         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3847         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3848         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3849
3850 2019-06-10  Tom de Vries  <tdevries@suse.de>
3851
3852         PR symtab/16264
3853         PR symtab/24517
3854         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3855
3856 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3857
3858         * source.c (find_and_open_source): Also rewrite relative file
3859         names.
3860
3861 2019-04-26  Amos Bird  <amosbird@gmail.com>
3862
3863         * annotate.c (annotate_thread_exited): Add "thread-exited"
3864         annotation.
3865
3866 2019-06-06  Tom Tromey  <tromey@adacore.com>
3867
3868         * maint.h (class scoped_command_stats): Use
3869         DISABLE_COPY_AND_ASSIGN.
3870         <print_time>: New method.
3871         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3872         print_time.
3873         (scoped_command_stats::print_time): New method.
3874
3875 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3878         instructions of lengths 6 or 8 bytes.
3879
3880 2019-06-04  Pedro Alves  <palves@redhat.com>
3881
3882         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3883
3884         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3885         * breakpoint.c (condition_completer): Likewise.
3886         * cli/cli-dump.c (scan_expression): Likewise.
3887         * common/filestuff.c (mkdir_recursive): Likewise.
3888         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3889         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3890         (gdb_abspath): Likewise.
3891         * compile/compile-cplus-types.c
3892         (compile_cplus_instance::decl_name): Likewise.
3893         * completer.c (complete_explicit_location):
3894         (signal_completer, reg_or_group_completer_1): Likewise.
3895         * cp-support.c (cp_remove_params_if_any): Likewise.
3896         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3897         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3898         * infcmd.c (strip_bg_char): Likewise.
3899         * linespec.c (copy_token_string): Likewise.
3900         * mi/mi-main.c (output_cores): Likewise.
3901         * psymtab.c (psymtab_search_name):
3902         * symfile.c (test_set_ext_lang_command): Likewise.
3903         * target.c (target_fileio_read_stralloc): Likewise.
3904         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3905         * value.c (complete_internalvar): Likewise.
3906
3907 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3908
3909         Add objfile property to gdb.Type.
3910         * NEWS: Mention Python API addition.
3911         * python/py-type.c (typy_get_objfile): New method.
3912
3913 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3914
3915         * NEWS: Mention the new set|show style [title|highlight].
3916         Mention changes to "show style", "help" and "apropos".
3917
3918 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3919
3920         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3921         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3922         instead of print_help_for_command.
3923         (print_doc_of_command): New function.
3924         (help_list): Add 'apropos -v word' suggestion.
3925         (print_help_for_command): Style the command name using title style.
3926         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3927         (_initialize_cli_cmds): Describe -v in apropos_command help.
3928
3929 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3930
3931         * cli/cli-style.h (cli_style_option): Add name in constructor,
3932         add m_name class member, add constructor with intensity,
3933         add name class function.
3934         (cli_style_option::add_setshow_commands): Remove name argument.
3935         (highlight_style, title_style): New styles.
3936         * cli/cli-style.c (do_show): New function that shows a style
3937         characteristic styling the style name with itself.
3938         (set_style_name): New function.
3939         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3940         Update all callers according to the changes in cli/cli-style.h.
3941         * utils.h (fputs_highlighted): New function.
3942         * utils.c (fputs_highlighted): Likewise.
3943
3944 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3945
3946         * NEWS: Mention new pipe command and new convenience variables.
3947
3948 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3949
3950         * cli/cli-cmds.c (pipe_command): New function.
3951         (_initialize_cli_cmds): Call add_com for pipe_command.
3952         Define | as an alias for pipe.
3953         (exit_status_set_internal_vars): New function.
3954         (shell_escape): Call exit_status_set_internal_vars.
3955         cli/cli-decode.c (find_command_name_length): Recognize | as
3956         a single character command.
3957
3958 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3959
3960         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3961         top.c (execute_command_to_ui_file): New function, mostly a copy
3962         of execute_command_to_string.
3963         (execute_command_to_string): Implement by calling
3964         execute_command_to_ui_file.
3965
3966 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3967
3968         * top.h (saved_command_line): Remove declaration.
3969         * top.c (previous_saved_command_line, previous_repeat_arguments):
3970         New variables.
3971         (saved_command_line): Make static, define together with other
3972         'repeat variables'.
3973         (dont_repeat): Clear repeat_arguments.
3974         (repeat_previous, get_saved_command_line, save_command_line):
3975         New functions.
3976         (gdb_init): Initialize saved_command_line
3977         and previous_saved_command_line.
3978         * main.c (captured_main_1): Remove saved_command_line initialization.
3979         * event-top.c (handle_line_of_input): Update to use
3980         the new 'repeat' related functions instead of direct access to
3981         saved_command_line.
3982         * command.h (repeat_previous, get_saved_command_line,
3983         save_command_line): New declarations.
3984         (dont_repeat): Add comment.
3985
3986 2019-05-30  Tom Tromey  <tromey@adacore.com>
3987
3988         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3989         Fix comment.
3990         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3991
3992 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3993
3994         PR cli/24587
3995         * completer.c (complete): Initialize variable word.
3996
3997 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3998
3999         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4000         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4001         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4002         'body' is NULL to the outter 'if', protecting the '!is_define'
4003         situation as well.
4004
4005 2019-05-29  Tom Tromey  <tromey@adacore.com>
4006
4007         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4008         (dwarf_unknown): New function.
4009         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4010         (dwarf_type_encoding_name): Use dwarf_unknown.
4011
4012 2019-05-29  Tom Tromey  <tromey@adacore.com>
4013
4014         PR c++/20020:
4015         * cp-valprint.c (cp_print_value_fields): Call
4016         cp_print_static_field inside "try".
4017
4018 2019-05-29  Tom Tromey  <tromey@adacore.com>
4019
4020         * inflow.c (struct terminal_info): Add default operator=.
4021         * configure: Rebuild.
4022         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4023         -Wdeprecated-copy-dtor, -Wredundant-move.
4024
4025 2019-05-29  Tom Tromey  <tromey@adacore.com>
4026
4027         * NEWS: Add entry.
4028         * infcmd.c (print_return_value_1): Handle finish_print
4029         option.
4030         (show_print_finish): New function.
4031         (_initialize_infcmd): Add "set/show print finish" commands.
4032         * valprint.c (user_print_options): Initialize new member.
4033         * valprint.h (struct value_print_options) <finish_print>: New
4034         member.
4035
4036 2019-05-28  Tom Tromey  <tromey@adacore.com>
4037
4038         * ada-lang.c (ada_remove_Xbn_suffix)
4039         (find_old_style_renaming_symbol)
4040         (parse_old_style_renaming): Remove.
4041         (ada_find_renaming_symbol): Don't call
4042         find_old_style_renaming_symbol.
4043         (ada_is_renaming_symbol): Rename from
4044         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4045         bool.  Now static.
4046         (ada_read_var_value): Update and simplify.
4047         * ada-exp.y (write_var_or_type): Remove old code.
4048
4049 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4050
4051         * event-top.c: Remove include comment.
4052         * inflow.c (class scoped_ignore_sigttou): Move from here...
4053         * inflow.h (class scoped_ignore_sigttou): ...to here.
4054         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4055         * top.c:  Remove include comment.
4056
4057 2019-05-27  Tom Tromey  <tom@tromey.com>
4058
4059         * NEWS: Fix typo.
4060
4061 2019-05-22  Tom Tromey  <tromey@adacore.com>
4062
4063         * target.c (target_follow_exec): Constify parameter.
4064         * target-delegates.c: Rebuild.
4065         * remote.c (remote_target::follow_exec): Constify parameter.
4066         * infrun.c (follow_exec): Constify parameter.
4067         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4068         (target_follow_exec): Likewise.
4069
4070 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4071
4072         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4073         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4074
4075 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4076
4077         * NEWS: Add debugredirect and testsuite sections.
4078
4079 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4080
4081         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4082         target descriptions using exclusively floating point register name
4083         aliases.
4084
4085 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         PR gdb/18644:
4088         * f-lang.c (build_fortran_types): Handle the case where
4089         gdbarch_floatformat_for_type returns a nullptr.
4090
4091 2019-05-21  Tom de Vries  <tdevries@suse.de>
4092
4093         PR cli/24587
4094         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4095
4096 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         PR gdb/18644:
4099         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4100         16-byte floats.
4101         * i386-tdep.c (i386_floatformat_for_type): Use
4102         floatformats_ia64_quad for the 16-byte floating point component
4103         within a fortran 32-byte complex number.
4104
4105 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4108         delete default constructor.
4109         (find_partial_die): Update to return const struct.
4110         (partial_die_parent_scope): Move variable declaration into scope
4111         of its use and change its type to auto.
4112         (guess_partial_die_structure_name): Likewise.
4113         (partial_die_info::fixup): Likewise.
4114
4115 2019-05-17  Tom Tromey  <tromey@adacore.com>
4116
4117         * source.c (find_and_open_source): Remove cast.
4118
4119 2019-05-17  Tom Tromey  <tromey@adacore.com>
4120
4121         * annotate.c (annotate_source): Make "filename" const.
4122         * annotate.h (annotate_source): Use const.
4123
4124 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4125
4126         * disasm.c (set_disassembler_options): Send errors to stderr.
4127
4128 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4129
4130         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4131         (cli_interp_base::set_logging): Check debug_redirect.
4132         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4133         * cli/cli-logging.c (debug_redirect): Add static variable.
4134         (pop_output_files): Add default param.
4135         (handle_redirections): Print debug setting.
4136         (show_logging_command): Likewise.
4137         (_initialize_cli_logging): Add debugredirect command.
4138         * interps.c (current_interp_set_logging): Add debug_redirect
4139         parameter.
4140         * interps.h (set_logging): Add debug_redirect parameter.
4141         (current_interp_set_logging): Likewise.
4142         * mi/mi-common.h: Likewise.
4143         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4144
4145 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4146             Tom Tromey  <tromey@adacore.com>
4147
4148         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4149         directly.
4150         * cli/cli-interp.h (make_logging_output): Remove declaration.
4151         * cli/cli-logging.c (make_logging_output): Remove function.
4152         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4153         directly.
4154         * ui-file.c (tee_file::tee_file): Remove bools.
4155         (tee_file::~tee_file): Remove deletes.
4156         * ui-file.h (tee_file): Remove bools.
4157
4158 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4159
4160         * mi/mi-cmds.h (mi_cmd_complete): New function.
4161         * mi/mi-main.c (mi_cmd_complete): Likewise.
4162         * mi/mi-cmds.c: Define new MI command -complete.
4163         * NEWS: Mention new -complete command.
4164
4165 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4166
4167         * completer.h (complete): New function.
4168         * completer.c (complete): Likewise.
4169         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4170         function defined in completer.h.
4171
4172 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4173
4174         * MAINTAINERS (Write After Approval): Add myself.
4175
4176 2019-05-17  Tom de Vries  <tdevries@suse.de>
4177
4178         PR gdb/24094
4179         * dwarf2read.c (struct cu_partial_die_info): New struct.
4180         (find_partial_die): Return cu_partial_die_info.
4181         (partial_die_parent_scope, guess_partial_die_structure_name)
4182         (partial_die_info::fixup): Handle new return type of find_partial_die.
4183
4184 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4185
4186         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4187         "std::string", simplifying the algorithm.
4188
4189 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4190
4191         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4192         (stap_static_probe_ops::get_probes): Likewise.
4193
4194 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4195
4196         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4197         '-')" and "else if".
4198         (stap_parse_single_operand): Join checks for
4199         "gdbarch_stap_parse_special_token_p" and
4200         "gdbarch_stap_parse_special_token" in the same "if" statement.
4201         Invert check when verifying for operation on register
4202         displacement.
4203
4204 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4205
4206         * stap-probe.c (stap_get_opcode): Update comment.
4207         (stap_get_expected_argument_type): Likewise.
4208         (handle_stap_probe): Likewise.
4209
4210 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4211
4212         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4213         return type to 'bool'.  Adjust comment.  Use 'bool' when
4214         appropriate.
4215         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4216         * stap-probe.c (stap_parse_argument_1): Likewise.
4217         (stap_is_operator): Likewise.
4218         (stap_is_generic_prefix): Likewise.
4219         (stap_is_register_prefix): Likewise.
4220         (stap_is_register_indirection_prefix): Likewise.
4221         (stap_is_integer_prefix): Likewise.
4222         (stap_generic_check_suffix): Likewise.
4223         (stap_check_integer_suffix): Likewise.
4224         (stap_check_register_suffix): Likewise.
4225         (stap_check_register_indirection_suffix): Likewise.
4226         (stap_parse_register_operand): Likewise.
4227         (stap_parse_single_operand): Likewise.
4228         (stap_parse_argument_1): Likewise.
4229         (stap_probe::get_argument_count): Likewise.
4230         (stap_is_operator): Likewise.
4231
4232 2019-05-16  Tom Tromey  <tromey@adacore.com>
4233
4234         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4235         keyword to foreach.
4236
4237 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4238
4239         * linux-thread-db.c (try_thread_db_load_1): Change return type
4240         to bool.
4241         (try_thread_db_load): Likewise.
4242         (try_thread_db_load_from_pdir_1): Likewise.
4243         (try_thread_db_load_from_pdir): Likewise.
4244         (try_thread_db_load_from_sdir): Likewise.
4245         (try_thread_db_load_from_dir): Likewise.
4246         (thread_db_load_search): Likewise.
4247         (has_libpthread): Likewise.
4248         (thread_db_load): Likewise.
4249
4250 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4251
4252         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4253         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4254         NULL, and complain/return if that's the case.
4255
4256 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4257
4258         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4259         (advance, posn, abstract_read_memory): New functions.
4260         [struct mem_read_abstraction]: New struct.
4261         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4262
4263 2019-05-14  Tom Tromey  <tromey@adacore.com>
4264
4265         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4266         value is not lval_memory.
4267
4268 2019-05-14  Tom Tromey  <tromey@adacore.com>
4269
4270         * solib.c (info_sharedlibrary_command): Style the file name.
4271
4272 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4273
4274         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4275         (aarch64_vnv_type): Likewise.
4276         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4277         * common/tdesc.c: Likewise.
4278         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4279         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4280         * features/aarch64-fpu.xml: Add ieee half view.
4281         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4282         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4283         * gdbtypes.h (struct builtin_type): Likewise.
4284         (struct objfile_type): Likewise.
4285
4286 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4287
4288         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4289         typo.
4290         * location.h (string_to_event_location): Likewise.
4291
4292 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4293
4294         GDB 8.3 released.
4295
4296 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4297
4298         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4299         New variable declaration.
4300         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4301         New variable.
4302         (print_one_breakpoint): Use ui_out::test_flags and new global
4303         variable to compute use_fixed_output.
4304         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4305         Remove.
4306         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4307         (mi_multi_location_breakpoint_output_fixed): Remove.
4308         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4309         new variable.
4310         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4311         fix_multi_location_breakpoint_output flag if version >= 3.
4312         * ui-out.h (enum ui_out_flag)
4313         <fix_multi_location_breakpoint_output>: New enumerator.
4314
4315 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4316
4317         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4318
4319 2019-05-10  Tom Tromey  <tromey@adacore.com>
4320
4321         * ada-lang.c (catch_ada_completer): New function.
4322         (_initialize_ada_language): Use it.
4323
4324 2019-05-10  Tom Tromey  <tromey@adacore.com>
4325
4326         * thread.c (print_thread_info): Make "requested_threads" const.
4327         * gdbthread.h (print_thread_info): Make "requested_threads"
4328         const.
4329         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4330         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4331
4332 2019-05-08  Tom Tromey  <tom@tromey.com>
4333
4334         * gdbtypes.c (objfile_type_data): Change type.
4335         (objfile_type, _initialize_gdbtypes): Update.
4336
4337 2019-05-08  Tom Tromey  <tom@tromey.com>
4338
4339         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4340         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4341         (_initialize_dwarf2_frame): Update.
4342
4343 2019-05-08  Tom Tromey  <tom@tromey.com>
4344
4345         * objc-lang.c (objc_objfile_data): Change type.
4346         (find_methods): Update.
4347         (_initialize_objc_lang): Remove.
4348
4349 2019-05-08  Tom Tromey  <tom@tromey.com>
4350
4351         * stabsread.c (rs6000_builtin_type_data): Change type.
4352         (rs6000_builtin_type, _initialize_stabsread): Update.
4353
4354 2019-05-08  Tom Tromey  <tom@tromey.com>
4355
4356         * mips-tdep.c (mips_pdr_data): Remove.
4357         (_initialize_mips_tdep): Update.
4358
4359 2019-05-08  Tom Tromey  <tom@tromey.com>
4360
4361         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4362         (hppa_init_objfile_priv_data, read_unwind_info)
4363         (find_unwind_entry, _initialize_hppa_tdep): Update.
4364
4365 2019-05-08  Tom Tromey  <tom@tromey.com>
4366
4367         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4368         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4369         on obstack.
4370         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4371
4372 2019-05-08  Tom Tromey  <tom@tromey.com>
4373
4374         * mdebugread.c (basic_type_data): Change type.
4375         (basic_type, _initialize_mdebugread): Update.
4376
4377 2019-05-08  Tom Tromey  <tom@tromey.com>
4378
4379         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4380
4381 2019-05-08  Tom Tromey  <tom@tromey.com>
4382
4383         * nto-tdep.c (nto_inferior_data_reg): Change type.
4384         (nto_inferior_data): Update.
4385         (nto_inferior_data_cleanup, nto_new_inferior_data)
4386         (_initialize_nto_tdep): Remove.
4387         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4388
4389 2019-05-08  Tom Tromey  <tom@tromey.com>
4390
4391         * ada-lang.c (struct ada_inferior_data): Add initializers.
4392         (ada_inferior_data): Change type.
4393         (ada_inferior_data_cleanup): Remove.
4394         (get_ada_inferior_data, ada_inferior_exit)
4395         (struct ada_pspace_data): Add initializers, destructor.
4396         (ada_pspace_data_handle): Change type.
4397         (get_ada_pspace_data): Update.
4398         (ada_pspace_data_cleanup): Remove.
4399
4400 2019-05-08  Tom Tromey  <tom@tromey.com>
4401
4402         * coffread.c (struct coff_symfile_info): Add initializers.
4403         (coff_objfile_data_key): Move lower.  Change type.
4404         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4405         Update.
4406         (coff_free_info): Remove.
4407
4408 2019-05-08  Tom Tromey  <tom@tromey.com>
4409
4410         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4411         (fbsd_pspace_data_handle): Move lower.  Change type.
4412         (get_fbsd_pspace_data): Update.
4413         (fbsd_pspace_data_cleanup): Remove.
4414         (_initialize_fbsd_tdep): Update.
4415
4416 2019-05-08  Tom Tromey  <tom@tromey.com>
4417
4418         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4419         (get_ada_tasks_pspace_data): Update.
4420         (ada_tasks_pspace_data_cleanup): Remove.
4421         (_initialize_tasks): Update.
4422         (ada_tasks_inferior_data_handle): Change type.
4423         (get_ada_tasks_inferior_data): Update.
4424         (ada_tasks_inferior_data_cleanup): Remove.
4425         (struct ada_tasks_pspace_data): Add initializers.
4426
4427 2019-05-08  Tom Tromey  <tom@tromey.com>
4428
4429         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4430         * symfile-debug.c (debug_sym_get_probes): Change type.
4431         * stap-probe.c (handle_stap_probe):
4432         (stap_static_probe_ops::get_probes): Change type.
4433         * probe.h (class static_probe_ops) <get_probes>: Change type.
4434         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4435         (parse_probes_in_pspace): Update.
4436         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4437         Update.
4438         (any_static_probe_ops::get_probes): Change type.
4439         * elfread.c (elfread_data): New typedef.
4440         (probe_key): Change type.
4441         (elf_get_probes): Likewise.  Update.
4442         (probe_key_free): Remove.
4443         (_initialize_elfread): Update.
4444         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4445         Change type.
4446         (dtrace_process_dof_probe, dtrace_process_dof)
4447         (dtrace_static_probe_ops::get_probe): Change type.
4448
4449 2019-05-08  Tom Tromey  <tom@tromey.com>
4450
4451         * xcoffread.c (struct xcoff_symfile_info): Rename from
4452         coff_symfile_info.  Add initializers.
4453         (xcoff_objfile_data_key): Move lower.  Change type.
4454         (XCOFF_DATA): Rewrite.
4455         (xcoff_free_info): Remove.
4456         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4457         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4458         (xcoff_initial_scan): Update.
4459
4460 2019-05-08  Tom Tromey  <tom@tromey.com>
4461
4462         * solib-svr4.c (struct svr4_info): Add initializers and
4463         destructor.
4464         <probes_table>: Now an htab_up.
4465         (solib_svr4_pspace_data): Change type.
4466         (free_probes_table): Simplify.
4467         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4468         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4469         (probes_table_remove_objfile_probes, register_solib_event_probe)
4470         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4471         (_initialize_svr4_solib): Update.
4472
4473 2019-05-08  Tom Tromey  <tom@tromey.com>
4474
4475         * remote.c (remote_pspace_data): Change type.
4476         (remote_pspace_data_cleanup): Remove.
4477         (get_remote_exec_file, set_pspace_remote_exec_file)
4478         (_initialize_remote): Update.
4479
4480 2019-05-08  Tom Tromey  <tom@tromey.com>
4481
4482         * breakpoint.c (breakpoint_objfile_key): Change type.
4483         (get_breakpoint_objfile_data): Update.
4484         (free_breakpoint_objfile_data): Remove.
4485         (_initialize_breakpoint): Update.
4486
4487 2019-05-08  Tom Tromey  <tom@tromey.com>
4488
4489         * linux-tdep.c (struct linux_info): Add initializers.
4490         (linux_inferior_data): Move.  Change type.
4491         (invalidate_linux_cache_inf): Update.
4492         (linux_inferior_data_cleanup): Remove.
4493         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4494
4495 2019-05-08  Tom Tromey  <tom@tromey.com>
4496
4497         * auxv.c (auxv_inferior_data): Move.  Change type.
4498         (auxv_inferior_data_cleanup): Remove.
4499         (invalidate_auxv_cache_inf): Rewrite.
4500         (get_auxv_inferior_data, _initialize_auxv): Update.
4501
4502 2019-05-08  Tom Tromey  <tom@tromey.com>
4503
4504         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4505         (symfile_debug_objfile_data_key): Change type.
4506         (symfile_debug_installed, debug_qf_has_symbols)
4507         (debug_qf_find_last_source_symtab)
4508         (debug_qf_forget_cached_source_info)
4509         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4510         (debug_qf_print_stats, debug_qf_dump)
4511         (debug_qf_expand_symtabs_for_function)
4512         (debug_qf_expand_all_symtabs)
4513         (debug_qf_expand_symtabs_with_fullname)
4514         (debug_qf_map_matching_symbols)
4515         (debug_qf_expand_symtabs_matching)
4516         (debug_qf_find_pc_sect_compunit_symtab)
4517         (debug_qf_map_symbol_filenames)
4518         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4519         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4520         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4521         (debug_sym_read_linetable, debug_sym_relocate): Update.
4522         (symfile_debug_free_objfile): Remove.
4523         (install_symfile_debug_logging, _initialize_symfile_debug):
4524         Update.
4525
4526 2019-05-08  Tom Tromey  <tom@tromey.com>
4527
4528         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4529         allocate_on_obstack.
4530         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4531         (get_dwarf2_per_objfile): Update.
4532         (set_dwarf2_per_objfile): Remove.
4533         (dwarf2_has_info, dwarf2_get_section_info): Update.
4534         (dwarf2_free_objfile): Remove.
4535         (_initialize_dwarf2_read): Update.
4536
4537 2019-05-08  Tom Tromey  <tom@tromey.com>
4538
4539         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4540         initializers.
4541         <unsupported_script_warning_printed,
4542         script_not_found_warning_printed>: Now bool.
4543         (auto_load_pspace_data): Change type.
4544         (~auto_load_pspace_info): Rename from
4545         auto_load_pspace_data_cleanup.
4546         (get_auto_load_pspace_data, init_loaded_scripts_info)
4547         (clear_section_scripts, maybe_print_unsupported_script_warning)
4548         (maybe_print_script_not_found_warning, _initialize_auto_load):
4549         Update.
4550
4551 2019-05-08  Tom Tromey  <tom@tromey.com>
4552
4553         * objfiles.c (objfile_pspace_info): Add destructor and
4554         initializers.
4555         (objfiles_pspace_data): Change type.
4556         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4557         (get_objfile_pspace_data): Update.
4558         (objfiles_bfd_data): Change type.
4559         (get_objfile_bfd_data): Update.
4560         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4561
4562 2019-05-08  Tom Tromey  <tom@tromey.com>
4563
4564         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4565         Change type.
4566         (get_catch_syscall_inferior_data): Update.
4567         (catch_syscall_inferior_data_cleanup): Remove.
4568         (_initialize_break_catch_syscall): Update.
4569
4570 2019-05-08  Tom Tromey  <tom@tromey.com>
4571
4572         * inflow.c (struct terminal_info): Add destructor and
4573         initializers.
4574         (inflow_inferior_data): Change type.
4575         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4576         (get_inflow_inferior_data, inflow_inferior_exit)
4577         (swap_terminal_info, _initialize_inflow): Update.
4578
4579 2019-05-08  Tom Tromey  <tom@tromey.com>
4580
4581         * target-dcache.c (target_dcache_cleanup): Remove.
4582         (target_dcache_aspace_key): Change type.
4583         (target_dcache_init_p, target_dcache_invalidate)
4584         (target_dcache_get, target_dcache_get_or_init)
4585         (_initialize_target_dcache): Update.
4586         * dcache.h (struct dcache_deleter): New.
4587
4588 2019-05-08  Tom Tromey  <tom@tromey.com>
4589
4590         * symtab.c (struct symbol_cache): Add destructor and
4591         initializers.
4592         (symbol_cache_key): Move.  Change type.
4593         (make_symbol_cache, free_symbol_cache): Remove.
4594         (get_symbol_cache): Update.
4595         (symbol_cache_cleanup): Remove.
4596         (ALL_PSPACES, symbol_cache_flush)
4597         (maintenance_print_symbol_cache)
4598         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4599         Update.
4600
4601 2019-05-08  Tom Tromey  <tom@tromey.com>
4602
4603         * symtab.c (struct main_info): Add destructor and initializers.
4604         (main_progspace_key): Move.  Change type.
4605         (get_main_info): Update.
4606         (main_info_cleanup): Remove.
4607         (_initialize_symtab): Update.
4608
4609 2019-05-08  Tom Tromey  <tom@tromey.com>
4610
4611         * registry.h (DECLARE_REGISTRY): Define the _key class.
4612
4613 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * NEWS: Merge two 'New commands' sections.
4616
4617 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4618
4619         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4620         parameter and use Ada language definition instead.
4621         (ada_val_print_ptr): Remove unused language parameter.
4622         (ada_val_print_num): Remove language parameter and use Ada language
4623         definition instead.
4624         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4625         parameter.
4626         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4627         parameter and use Ada language definition instead.
4628         (ada_val_print_1): Update all ada_val_print_xxx calls.
4629         Remove language parameter.
4630         (ada_val_print): Update ada_val_print_1 call.
4631
4632 2019-05-08  Tom Tromey  <tromey@adacore.com>
4633
4634         * remote.c (remote_hw_watchpoint_limit)
4635         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4636         Now static.
4637
4638 2019-05-08  Tom Tromey  <tromey@adacore.com>
4639
4640         * maint.c (_initialize_maint_cmds): Move initialization code to
4641         remote.c.
4642         (watchdog, show_watchdog): Move to remote.c.
4643         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4644         "watchdog" static.
4645         (_initialize_remote): Move initialization code from maint.c.
4646         * defs.h (watchdog): Don't declare.
4647
4648 2019-05-08  Tom Tromey  <tromey@adacore.com>
4649
4650         * tui/tui-interp.c: Include main.h.
4651         * interps.c: Include main.h.
4652         * main.h (interpreter_p): Declare.
4653         * defs.h (interpreter_p): Don't declare.
4654
4655 2019-05-08  Tom Tromey  <tromey@adacore.com>
4656
4657         * dwarf2loc.c: Include dwarf2read.h.
4658         * defs.h (read_unsigned_leb128): Don't declare.
4659         * dwarf2read.h (read_unsigned_leb128): Declare.
4660
4661 2019-05-08  Tom Tromey  <tromey@adacore.com>
4662
4663         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4664         method.
4665
4666 2019-05-08  Tom Tromey  <tromey@adacore.com>
4667
4668         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4669         when no wrap column is set.
4670
4671 2019-05-08  Tom Tromey  <tromey@adacore.com>
4672
4673         * c-lang.c (c_get_string): Handle non-C-style arrays.
4674
4675 2019-05-08  Tom Tromey  <tromey@adacore.com>
4676
4677         * typeprint.c (print_offset_data::update): Print the bit offset,
4678         not the number of bits remaining.
4679
4680 2019-05-08  Tom Tromey  <tromey@adacore.com>
4681
4682         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4683         padding at end of comment.
4684
4685 2019-05-08  Tom Tromey  <tromey@adacore.com>
4686
4687         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4688         Compare main types.
4689
4690 2019-05-06  Tom Tromey  <tom@tromey.com>
4691
4692         * common/scoped_mmap.c: Include common-defs.h.
4693         * common/scoped_mmap.h: Don't include config.h.
4694
4695 2019-05-04  Tom Tromey  <tom@tromey.com>
4696
4697         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4698         (struct aarch64_call_info): Add initializers.
4699         <si>: Now a std::vector.
4700         (pass_on_stack, aarch64_push_dummy_call): Update.
4701
4702 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4703             Tom Tromey  <tom@tromey.com>
4704
4705         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4706         (ppc_threads): Now a std::vector.  Now static.
4707         (hwdebug_find_thread_points_by_tid)
4708         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4709         Update.
4710
4711 2019-05-04  Tom Tromey  <tom@tromey.com>
4712
4713         * arc-tdep.c (arc_tdesc_init): Return bool.
4714
4715 2019-05-04  Tom Tromey  <tom@tromey.com>
4716
4717         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4718         Use gdb_assert_not_reached.
4719
4720 2019-05-04  Tom Tromey  <tom@tromey.com>
4721
4722         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4723         "false".
4724
4725 2019-05-04  Tom Tromey  <tom@tromey.com>
4726
4727         * arc-tdep.c (arc_tdesc_init): Use bool.
4728
4729 2019-05-04  Tom Tromey  <tom@tromey.com>
4730
4731         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4732
4733 2019-05-04  Tom Tromey  <tom@tromey.com>
4734
4735         * cli/cli-cmds.c (valid_command_p): Return bool.
4736
4737 2019-05-04  Tom Tromey  <tom@tromey.com>
4738
4739         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4740         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4741
4742 2019-05-04  Raul Tambre  <raul@tambre.ee>
4743
4744         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4745         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4746         operator for comparison.
4747
4748 2019-05-04  Tom Tromey  <tom@tromey.com>
4749
4750         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4751         (lookup_partial_symbol, print_partial_symbols)
4752         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4753         (psymbol_compare): Update.
4754         (add_psymbol_to_bcache): Clear the entire psymbol.
4755         (maintenance_check_psymtabs): Update.
4756         * psympriv.h (struct partial_symbol): Don't derive from
4757         general_symbol_info.
4758         <obj_section, unrelocated_address, address,
4759         set_unrelocated_address>: Update.
4760         <ginfo>: New member.
4761         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4762         (debug_names::write_psymbols): Update.
4763
4764 2019-05-04  Tom de Vries  <tdevries@suse.de>
4765
4766         * contrib/cc-with-tweaks.sh: Support -n arg.
4767
4768 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4769
4770         * corelow.c (core_target::detach): Ensure frame cache and
4771         register caches are cleared.
4772         inferior.c (exit_inferior_1): Likewise.
4773
4774 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4775             Tom Tromey  <tom@tromey.com>
4776
4777         * dictionary.c (collate_pending_symbols_by_language): Remove
4778         "struct" from foreach.
4779         * symtab.c (lookup_global_symbol_from_objfile)
4780         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4781         foreach.
4782         * ser-tcp.c (net_open): Remove "struct" from foreach.
4783         * objfiles.c (objfile_relocate, objfile_rebase)
4784         (objfile_has_symbols): Remove "struct" from foreach.
4785         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4786         from foreach.
4787         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4788         foreach.
4789         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4790         "struct" from foreach.
4791         * ada-lang.c (create_excep_cond_exprs)
4792         (ada_exception_catchpoint_cond_string): Remove "struct" from
4793         foreach.
4794
4795 2019-05-03  Tom Tromey  <tromey@adacore.com>
4796
4797         * ada-exp.y (convert_char_literal): Check suffix of each
4798         enumerator.
4799
4800 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4801
4802         PR ada/21406:
4803         * ada-exp.y (yywrap): Don't define.
4804         * ada-lex.l (%option): Add noyywrap
4805         (yywrap): Remove.
4806
4807 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4808
4809         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4810         _WIN32_WINNT to the XP level, unless already defined to a higher
4811         level.
4812
4813         * unittests/parse-connection-spec-selftests.c:
4814         * ser-tcp.c:
4815         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4816         override.
4817
4818         * symfile.c (find_separate_debug_file): Remove colon from the
4819         drive spec of DOS/Windows file names of the target, so that the
4820         file name produced from DEBUGDIR and the target's directory will
4821         be valid on DOS/Windows systems.
4822
4823 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4824
4825         * rust-lang.c (val_print_struct): Handle printing structures
4826         containing strings.
4827
4828 2019-05-02  Tom Tromey  <tromey@adacore.com>
4829
4830         * valarith.c (_initialize_valarith): Remove.
4831
4832 2019-05-01  Tom Tromey  <tromey@adacore.com>
4833
4834         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4835         bitfields.
4836
4837 2019-05-01  Tom Tromey  <tromey@adacore.com>
4838
4839         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4840         for big-endian copies.
4841
4842 2019-04-30  Ali Tamur  <tamur@google.com>
4843         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4844         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4845         (read_3_bytes): New function.
4846
4847 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4848
4849         * windows-nat.c (main_thread_id): Delete.
4850         (handle_output_debug_string): Replace main_thread_id by
4851         current_event.dwThreadId.
4852         (fake_create_process): Likewise.
4853         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4854         Do not set main_thread_id.
4855         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4856         current_event.dwThreadId.
4857         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4858
4859 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4860
4861         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4862         Use current_event.dwThreadId instead of main_thread_id.
4863
4864 2019-04-30  Tom Tromey  <tromey@adacore.com>
4865
4866         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4867         (create_excep_cond_exprs): Iterate over program spaces.
4868         (ada_exception_catchpoint_cond_string): Examine all minimal
4869         symbols for exception types.
4870
4871 2019-04-30  Tom Tromey  <tromey@adacore.com>
4872
4873         PR c++/24470:
4874         * dwarf2read.c (process_structure_scope): Handle case where type
4875         has template parameters but no symbol was created.
4876
4877 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4878             Chris January  <chris.january@arm.com>
4879
4880         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4881         qualifier.
4882         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4883
4884 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * f-typeprint.c (f_print_type): Update rules for printing
4887         whitespace.
4888         (f_type_print_varspec_suffix): Likewise.
4889
4890 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4891             Chris January  <chris.january@arm.com>
4892
4893         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4894         function arguments.
4895
4896 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * f-lang.c (build_fortran_types): Change name of void type to
4899         lower case.
4900         * f-typeprint.c (f_type_print_base): Print the name of the void
4901         type, rather than a fixed string.
4902         * f-valprint.c (f_decorations): Use lower case void string.
4903
4904 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4905             Chris January  <chris.january@arm.com>
4906
4907         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4908         types for Fortran.
4909
4910 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4911             Chris January  <chris.january@arm.com>
4912             David Lecomber  <david.lecomber@arm.com>
4913
4914         * f-exp.y (BINOP_INTRINSIC): New token.
4915         (exp): New parser rule handling BINOP_INTRINSIC.
4916         (f77_keywords): Add new builtin procedures.
4917         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4918         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4919         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4920         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4921         (print_unop_subexp_f): New function.
4922         (print_binop_subexp_f): New function.
4923         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4924         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4925         (dump_subexp_body_f): Likewise.
4926         (operator_check_f): Likewise.
4927         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4928         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4929
4930 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4933         UNOP_KIND.
4934         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4935         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4936         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4937         (operator_length_f): New fuction.
4938         (print_subexp_f): New function.
4939         (op_name_f): New function.
4940         (dump_subexp_body_f): New function.
4941         (operator_check_f): New function.
4942         (exp_descriptor_f): Replace standard expression handling functions
4943         with new functions.
4944         * gdb/fortran-operator.def: New file.
4945         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4946         * gdb/std-operator.def: Remove UNOP_KIND.
4947
4948 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4949
4950         * std-operator.def: Remove unbalanced, stray double quote
4951         character.
4952
4953 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4954             Chris January  <chris.january@arm.com>
4955             Daniel Everett  <daniel.everett@arm.com>
4956             Nick Forrington  <nick.forrington@arm.com>
4957             Richard Bunt  <richard.bunt@arm.com>
4958
4959         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4960         of depth when printing anonymous structs or unions.
4961         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4962         Don't print either the top-level value, or the children if the
4963         max-depth is exceeded.
4964         (ppscm_print_children): When printing the key of a map, allow one
4965         extra level of depth.
4966         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4967         print either the top-level value, or the children if the max-depth
4968         is exceeded.
4969         (print_children): When printing the key of a map, allow one extra
4970         level of depth.
4971         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4972         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4973         (user_print_options): Initialise max_depth field.
4974         (val_print_scalar_or_string_type_p): New function.
4975         (val_print): Check to see if the max depth has been reached.
4976         (val_print_check_max_depth): Define new function.
4977         (show_print_max_depth): New function.
4978         (_initialize_valprint): Add 'print max-depth' option.
4979         * valprint.h (struct value_print_options) <max_depth>: New field.
4980         (val_print_check_max_depth): Declare new function.
4981         * NEWS: Document new feature.
4982
4983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4984
4985         * ada-lang.c (ada_language_defn): Initialise new field.
4986         * c-lang.c (c_is_string_type_p): New function.
4987         (c_language_defn): Initialise new field.
4988         (cplus_language_defn): Initialise new field.
4989         (asm_language_defn): Initialise new field.
4990         (minimal_language_defn): Initialise new field.
4991         * c-lang.h (c_is_string_type_p): Declare new function.
4992         * d-lang.c (d_language_defn): Initialise new field.
4993         * f-lang.c (f_is_string_type_p): New function.
4994         (f_language_defn): Initialise new field.
4995         * go-lang.c (go_is_string_type_p): New function.
4996         (go_language_defn): Initialise new field.
4997         * language.c (default_is_string_type_p): New function.
4998         (unknown_language_defn): Initialise new field.
4999         (auto_language_defn): Initialise new field.
5000         * language.h (struct language_defn) <la_is_string_type_p>: New
5001         member variable.
5002         (default_is_string_type_p): Declare new function.
5003         * m2-lang.c (m2_language_defn): Initialise new field.
5004         * objc-lang.c (objc_language_defn): Initialise new field.
5005         * opencl-lang.c (opencl_language_defn): Initialise new field.
5006         * p-lang.c (pascal_is_string_type_p): New function.
5007         (pascal_language_defn): Initialise new field.
5008         * rust-lang.c (rust_is_string_type_p): New function.
5009         (rust_language_defn): Initialise new field.
5010
5011 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5014         New field.
5015         * ada-lang.c (ada_language_defn): Initialise new field.
5016         * c-lang.c (c_language_defn): Likewise.
5017         (cplus_language_defn): Likewise.
5018         (asm_language_defn): Likewise.
5019         (minimal_language_defn): Likewise.
5020         * d-lang.c (d_language_defn): Likewise.
5021         * f-lang.c (f_language_defn): Likewise.
5022         * go-lang.c (go_language_defn): Likewise.
5023         * language.c (unknown_language_defn): Likewise.
5024         (auto_language_defn): Likewise.
5025         * m2-lang.c (m2_language_defn): Likewise.
5026         * objc-lang.c (objc_language_defn): Likewise.
5027         * opencl-lang.c (opencl_language_defn): Likewise.
5028         * p-lang.c (pascal_language_defn): Likewise.
5029         * rust-lang.c (rust_language_defn): Likewise.
5030
5031 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * ada-lang.c (ada_is_character_type): Change return type to bool.
5034         (ada_is_string_type): Likewise.
5035         * ada-lang.h (ada_is_character_type): Update declaration
5036         (ada_is_string_type): Likewise.
5037
5038 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5039
5040         Support style in 'frame|thread apply'
5041
5042         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5043         * record.c (record_start, record_stop): Update callers of
5044         execute_command_to_string with false.
5045         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5046         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5047         methods.
5048         (class string_file): New constructor with term_out parameter.
5049         Override methods term_out and can_emit_style_escape.  New member
5050         term_out.
5051         (class stdio_file): Override can_emit_style_escape.
5052         (class tee_file): Override term_out and can_emit_style_escape.
5053         * utils.h (can_emit_style_escape): Remove.
5054         * utils.c (can_emit_style_escape): Likewise.
5055         Update all callers of can_emit_style_escape (SOMESTREAM) to
5056         SOMESTREAM->can_emit_style_escape.
5057         * source-cache.c (source_cache::get_source_lines): Likewise.
5058         * stack.c (frame_apply_command_count): Call execute_command_to_string
5059         passing the term_out characteristic of the current gdb_stdout.
5060         * thread.c (thr_try_catch_cmd): Likewise.
5061         * top.c (execute_command_to_string): pass term_out parameter
5062         to construct the string_file for the command output.
5063         * ui-file.c (term_cli_styling): New function (most code moved
5064         from utils.c can_emit_style_escape).
5065         (string_file::string_file, string_file::can_emit_style_escape,
5066         stdio_file::can_emit_style_escape, tee_file::term_out,
5067         tee_file::can_emit_style_escape): New functions.
5068
5069 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5070
5071         * NEWS: Mention the new set|show may-call-functions.
5072         * infcall.c (may_call_functions_p): New variable.
5073         (show_may_call_functions_p): New function.
5074         (call_function_by_hand_dummy): Throws an error if not
5075         may-call-functions.
5076         (_initialize_infcall): Call add_setshow_boolean_cmd for
5077         may-call-functions.
5078
5079 2019-04-25  Keith Seitz  <keiths@redhat.com>
5080
5081         PR c++/24367
5082         * cp-support.c (inspect_type): Don't attempt substitutions
5083         of symbol with the same name.
5084
5085 2019-04-25  Tom Tromey  <tromey@adacore.com>
5086
5087         PR gdb/24475:
5088         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5089         static.
5090
5091 2019-04-25  Tom Tromey  <tromey@adacore.com>
5092
5093         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5094         rvalue reference.
5095         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5096         (gdb_xml_parser::parse): Use std::move.
5097         * python/python-internal.h (gdbpy_convert_exception): Take a const
5098         reference.
5099         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5100         std::move.
5101         * python/py-utils.c (gdbpy_convert_exception): Take a const
5102         reference.
5103         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5104         Use std::move.
5105         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5106         Use std::move.
5107         * mi/mi-main.c (mi_print_exception): Take a const reference.
5108         * main.c (handle_command_errors): Take a const reference.
5109         * linespec.c (parse_linespec): Use std::move.
5110         * infcall.c (run_inferior_call): Use std::move.
5111         (call_function_by_hand_dummy): Use std::move.
5112         * exec.c (try_open_exec_file): Use std::move.
5113         * exceptions.h (exception_print, exception_fprintf)
5114         (exception_print_same): Update.
5115         * exceptions.c (print_exception, exception_print)
5116         (exception_fprintf, exception_print_same): Change parameters to
5117         const reference.
5118         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5119         * common/new-op.c: Use std::move.
5120         * common/common-exceptions.h (struct gdb_exception): Add move
5121         constructor.
5122         (struct gdb_exception_error, struct gdb_exception_quit, struct
5123         gdb_quit_bad_alloc): Change constructor to move constructor.
5124         (throw_exception): Change parameter to rvalue reference.
5125         * common/common-exceptions.c (throw_exception): Take rvalue
5126         reference.
5127         * cli/cli-interp.c (safe_execute_command): Use std::move.
5128         * breakpoint.c (insert_bp_location, location_to_sals): Use
5129         std::move.
5130
5131 2019-04-25  Tom Tromey  <tromey@adacore.com>
5132
5133         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5134         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5135         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5136         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5137         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5138         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5139         guile/scm-value.c: Use unpack.
5140         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5141         gdbscm_gdb_exception.
5142         (gdbscm_throw_gdb_exception): Likewise.
5143         (struct gdbscm_gdb_exception): New.
5144         (unpack): New function.
5145         (gdbscm_wrap): Use unpack.
5146
5147 2019-04-25  Tom Tromey  <tromey@adacore.com>
5148
5149         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5150         (gdb_rl_callback_handler): Use std::move.
5151         * common/common-exceptions.h (struct gdb_exception): Add move
5152         assignment operator.
5153         (throw_exception_sjlj): Change "exception" to const reference.
5154         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5155         (throw_exception_sjlj): Change "exception" to const reference.
5156
5157 2019-04-25  Tom Tromey  <tromey@adacore.com>
5158
5159         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5160         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5161         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5162         Update.
5163         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5164         Update.
5165         * mi/mi-interp.c (mi_interp::exec): Update.
5166         * linespec.c (parse_linespec): Update.
5167         * infcall.c (run_inferior_call): Update.
5168         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5169         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5170         (gdbscm_lookup_global_symbol): Update.
5171         * guile/scm-param.c (gdbscm_parameter_value): Update.
5172         * guile/scm-frame.c (gdbscm_frame_read_register)
5173         (gdbscm_frame_read_var): Update.
5174         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5175         * exec.c (try_open_exec_file): Update.
5176         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5177         (gdb_rl_callback_handler): Update.
5178         * common/common-exceptions.h (exception_none): Don't declare.
5179         * common/common-exceptions.c (exception_none): Don't define.
5180         (struct catcher) <exception>: Update.
5181         * cli/cli-interp.c (safe_execute_command): Update.
5182         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5183
5184 2019-04-25  Ali Tamur  <tamur@google.com>
5185
5186         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5187         (read_attribute_value): Likewise.
5188         (dwarf2_read_addr_index): Update comment.
5189         (read_str_index): Add DW_FORM_strx.
5190         (dwarf2_string_attr): Likewise.
5191         (dwarf2_const_value_attr): Likewise.
5192         (dump_die_shallow): Likewise.
5193         (dwarf2_fetch_constant_bytes): Likewise.
5194         (skip_form_bytes): Likewise.
5195         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5196
5197 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5198
5199         PR corefiles/11608
5200         PR corefiles/18187
5201         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5202         OFFSET.  Verify if current mapping contains an ELF header.
5203         (linux_find_memory_regions_full): Adjust call to
5204         dump_mapping_p.
5205
5206 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5207             Kang Li <kanglictf@gmail.com>
5208
5209         PR gdb/21600
5210
5211         * dwarf2-frame.c (read_initial_length): Be consistent about using
5212         unsigned representation of length.
5213         (decode_frame_entry_1): Likewise.  Check for wraparound of
5214         end pointer as well as buffer overflow.
5215
5216 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5217
5218         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5219         "vq".
5220
5221 2019-04-24  Tom Tromey  <tromey@adacore.com>
5222
5223         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5224
5225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5226
5227         * s12z-tdep.c (s12z_unwind_pc): Delete.
5228         (s12z_unwind_sp): Delete.
5229         (s12z_gdbarch_init): Don't register deleted functions with
5230         gdbarch.
5231
5232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5233
5234         * rl78-tdep.c (rl78_unwind_sp): Delete.
5235         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5236
5237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5238
5239         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5240         (xstormy16_unwind_pc): Delete.
5241         (xstormy16_dummy_id): Delete.
5242         (xstormy16_gdbarch_init): Don't register deleted functions with
5243         gdbarch.
5244
5245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * vax-tdep.c (vax_unwind_pc): Delete.
5248         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5249
5250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5251
5252         * v850-tdep.c (v850_unwind_sp): Delete.
5253         (v850_unwind_pc): Delete.
5254         (v850_dummy_id): Delete.
5255         (v850_gdbarch_init): Don't register deleted functions with
5256         gdbarch.
5257
5258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5261         (tilegx_unwind_pc): Delete.
5262         (tilegx_unwind_dummy_id): Delete.
5263         (tilegx_gdbarch_init): Don't register deleted functions with
5264         gdbarch.
5265
5266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5269         (tic6x_dummy_id): Delete.
5270         (tic6x_gdbarch_init): Don't register deleted functions with
5271         gdbarch.
5272
5273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5274
5275         * sparc-tdep.c (sparc_unwind_pc): Delete.
5276         (sparc32_gdbarch_init): Don't register deleted function with
5277         gdbarch.
5278
5279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5280
5281         * sh-tdep.c (sh_unwind_sp): Delete.
5282         (sh_unwind_pc): Delete.
5283         (sh_dummy_id): Delete.
5284         (sh_gdbarch_init): Don't register deleted functions with
5285         gdbarch.
5286
5287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * score-tdep.c (score_unwind_sp): Delete.
5290         (score_unwind_pc): Delete.
5291         (score_dummy_id): Delete.
5292         (score_gdbarch_init): Don't register deleted functions with
5293         gdbarch.
5294
5295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5296
5297         * rx-tdep.c (rx_unwind_pc): Delete.
5298         (rx_unwind_sp): Delete.
5299         (rx_dummy_id): Delete.
5300         (rx_gdbarch_init): Don't register deleted functions with
5301         gdbarch.  Update comment.
5302
5303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5304
5305         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5306         (rs6000_dummy_id): Delete.
5307         (rs6000_gdbarch_init): Don't register deleted functions with
5308         gdbarch.
5309
5310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5311
5312         * or1k-tdep.c (or1k_dummy_id): Delete.
5313         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5314
5315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5316
5317         * nios2-tdep.c (nios2_dummy_id): Delete.
5318         (nios2_unwind_sp): Delete.
5319         (nios2_gdbarch_init): Don't register deleted functions with
5320         gdbarch.
5321
5322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5323
5324         * nds32-tdep.c (nds32_dummy_id): Delete.
5325         (nds32_unwind_pc): Delete.
5326         (nds32_unwind_sp): Delete.
5327         (nds32_gdbarch_init): Don't register deleted functions with
5328         gdbarch.
5329
5330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5331
5332         * msp430-tdep.c (msp430_unwind_pc): Delete.
5333         (msp430_unwind_sp): Delete.
5334         (msp430_dummy_id): Delete.
5335         (msp430_gdbarch_init): Don't register deleted functions with
5336         gdbarch.
5337
5338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5339
5340         * moxie-tdep.c (moxie_unwind_sp): Delete.
5341         (moxie_unwind_pc): Delete.
5342         (moxie_dummy_id): Delete.
5343         (moxie_gdbarch_init): Don't register deleted functions with
5344         gdbarch.
5345
5346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5347
5348         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5349         (mn10300_unwind_pc): Delete.
5350         (mn10300_unwind_sp): Delete.
5351         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5352         mn10300_unwind_sp.
5353         (mn10300_frame_unwind_init): Don't register deleted functions with
5354         gdbarch.
5355
5356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * mep-tdep.c (mep_unwind_pc): Delete.
5359         (mep_unwind_sp): Delete.
5360         (mep_dummy_id): Delete.
5361         (mep_gdbarch_init): Don't register deleted functions with
5362         gdbarch.
5363
5364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5367         (m68hc11_unwind_sp): Delete.
5368         (m68hc11_gdbarch_init): Don't register deleted functions with
5369         gdbarch.
5370
5371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * m32r-tdep.c (m32r_unwind_sp): Delete.
5374         (m32r_unwind_pc): Delete.
5375         (m32r_dummy_id): Delete.
5376         (m32r_gdbarch_init): Don't register deleted functions with
5377         gdbarch.
5378
5379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5380
5381         * m32c-tdep.c (m32c_unwind_pc): Delete.
5382         (m32c_unwind_sp): Delete.
5383         (m32c_dummy_id): Delete.
5384         (m32c_gdbarch_init): Don't register deleted functions with
5385         gdbarch.
5386
5387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5388
5389         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5390         (lm32_unwind_pc): Delete.
5391         (lm32_dummy_id): Delete.
5392         (lm32_gdbarch_init): Don't register deleted functions with
5393         gdbarch.
5394
5395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5396
5397         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5398         (iq2000_unwind_pc): Delete.
5399         (iq2000_dummy_id): Delete.
5400         (iq2000_gdbarch_init): Don't register deleted functions with
5401         gdbarch.
5402
5403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5404
5405         * nds32-tdep.c (nds32_type_align): Delete.
5406         (nds32_push_dummy_call): Use type_align instead.
5407
5408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5409
5410         * arm-tdep.c (arm_type_align): Only handle vector override case.
5411         (arm_push_dummy_call): Use type_align.
5412         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5413
5414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5415
5416         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5417         case.
5418         (pass_on_stack): Use type_align.
5419         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5420         function.
5421
5422 2019-04-23  Tom Tromey  <tromey@adacore.com>
5423
5424         * dwarf2read.c (line_header::file_name_at): Remove unused
5425         overload.
5426
5427 2019-04-23  Tom de Vries  <tdevries@suse.de>
5428
5429         PR gdb/24438
5430         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5431         invocation.
5432
5433
5434 2019-03-27  Ali Tamur  <tamur@google.com>
5435
5436         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5437         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5438         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5439         (dwarf_expr_context::get_addr_index): Likewise
5440         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5441         (symbol_needs_eval_context::get_addr_index): Likewise
5442         (disassemble_dwarf_expression): Add DW_OP_addrx
5443         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5444         (read_cutu_die_from_dwo): Update comment
5445         (skip_one_die): Add DW_FORM_addrx
5446         (read_attribute_value): Likewise
5447         (var_decode_location): Add DW_OP_addrx
5448         (dwarf2_const_value_attr): Add DW_FORM_addrx
5449         (dump_die_shallow): Likewise
5450         (dwarf2_fetch_constant_bytes): Likewise
5451         (decode_locdesc): Add DW_OP_addrx
5452         (skip_form_bytes): Add DW_FORM_addrx
5453
5454 2019-04-22  Ali Tamur  <tamur@google.com>
5455
5456         * MAINTAINERS (Write After Approval): Add self.
5457
5458 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5459
5460         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5461         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5462         (open_symbol_file_object): Likewise.
5463         (svr4_default_sos): Add info parameter.
5464         (svr4_read_so_list): Likewise.
5465         (svr4_current_sos_direct): Adjust functions calls to pass down
5466         info.
5467         (svr4_current_sos_1): Add info parameter.
5468         (svr4_current_sos): Call get_svr4_info, pass info down to
5469         svr4_current_sos_1.
5470         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5471         get_svr4_info.
5472         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5473         get_svr4_info.
5474         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5475         to get_svr4_info.
5476         (probes_table_remove_objfile_probes): Likewise.
5477         (register_solib_event_probe): Add info parameter.
5478         (solist_update_incremental): Pass info parameter down to
5479         svr4_read_so_list.
5480         (disable_probes_interface): Add info parameter.
5481         (svr4_handle_solib_event): Pass current_program_space to
5482         get_svr4_info.  Adjust disable_probes_interface cleanup.
5483         (svr4_create_probe_breakpoints): Add info parameter, pass it
5484         down to register_solib_event_probe.
5485         (svr4_create_solib_event_breakpoints): Add info parameter,
5486         pass it down to svr4_create_probe_breakpoints.
5487         (enable_break): Pass info down to
5488         svr4_create_solib_event_breakpoints.
5489         (svr4_solib_create_inferior_hook): Pass current_program_space to
5490         get_svr4_info.
5491         (svr4_clear_solib): Likewise.
5492
5493 2019-04-22  Pedro Alves  <palves@redhat.com>
5494
5495         * solib-svr4.c (svr4_free_objfile_observer): New.
5496         (probe_and_action::objfile): New field.
5497         (probes_table_htab_remove_objfile_probes)
5498         (probes_table_remove_objfile_probes): New functions.
5499         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5500         in the new probe_and_action.  Don't store the probe in 'lookup'.
5501         (svr4_create_probe_breakpoints): Pass objfile to
5502         register_solib_event_probe.
5503         (_initialize_svr4_solib): Register a free_objfile observer.
5504
5505 2019-04-19  Tom Tromey  <tom@tromey.com>
5506
5507         * common/queue.h: Remove.
5508
5509 2019-04-19  Tom Tromey  <tom@tromey.com>
5510
5511         * event-loop.c: Don't include "common/queue.h".
5512
5513 2019-04-19  Tom Tromey  <tom@tromey.com>
5514
5515         * remote.c (remote_target): Use delete.
5516         * remote-notif.h: Include <list>, not "common/queue.h".
5517         (notif_client_p): Remove typedef.
5518         (remote_notif_state): Add constructor, destructor, initializer.
5519         <notif_queue>: Now a std::list.
5520         (remote_notif_state_xfree): Don't declare.
5521         * remote-notif.c (remote_notif_process, handle_notification)
5522         (remote_notif_state_allocate): Update.
5523         (~remote_notif_state): Rename from remote_notif_state_xfree.
5524
5525 2019-04-19  Tom Tromey  <tom@tromey.com>
5526
5527         * symfile.c (reread_symbols): Update.
5528         * objfiles.c (objfile_register_static_link)
5529         (objfile_lookup_static_link): Update
5530         (~objfile) Don't delete static_links.
5531         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5532
5533 2019-04-19  Tom Tromey  <tom@tromey.com>
5534
5535         * type-stack.h (struct type_stack) <insert>: Constify string.
5536         * type-stack.c (type_stack::insert): Constify string.
5537         * gdbtypes.h (lookup_template_type): Update.
5538         (address_space_name_to_int): Update.
5539         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5540         const.
5541         (lookup_template_type): Make name const.
5542         * c-exp.y: Update rules.
5543         (lex_one_token, classify_name, classify_inner_name)
5544         (c_print_token): Update.
5545         * p-exp.y: Update rules.
5546         (yylex): Update.
5547         * f-exp.y: Update rules.
5548         (yylex): Update.
5549         * d-exp.y: Update rules.
5550         (lex_one_token, classify_name, classify_inner_name): Update.
5551         * parse.c (write_dollar_variable, copy_name): Return std::string.
5552         * parser-defs.h (copy_name): Change return type.
5553         * m2-exp.y: Update rules.
5554         (yylex): Update.
5555         * go-exp.y (lex_one_token): Update.
5556         Update rules.
5557         (classify_unsafe_function, classify_packaged_name)
5558         (classify_name, yylex): Update.
5559
5560 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5561
5562         * configure.ac: add --enable-source-highlight switch.
5563         * configure: Regenerate.
5564         * top.c (print_gdb_version): plumb --enable-source-highlight
5565         status to "show configuration".
5566
5567 2019-04-19  Tom Tromey  <tromey@adacore.com>
5568
5569         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5570         Check ADA_TYPE_P.
5571         (empty_record, ada_template_to_fixed_record_type_1)
5572         (template_to_static_fixed_type)
5573         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5574         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5575         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5576         macros.
5577
5578 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5579
5580         PR symtab/24423:
5581         * source.c (print_source_lines_base): Advance "iter" when a
5582         control character is seen.
5583
5584 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5585
5586         * inferior.h (struct infcall_suspend_state_deleter):
5587         Catch exception in destructor to avoid crash.
5588
5589 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5590
5591         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5592         close to the add_com "shell".
5593
5594 2019-04-18  Tom Tromey  <tromey@adacore.com>
5595
5596         * process-stratum-target.h (class process_stratum_target)
5597         <stratum>: Add "final".
5598
5599 2019-04-17  Tom Tromey  <tromey@adacore.com>
5600
5601         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5602         against nullptr before use.
5603
5604 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5605
5606         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5607
5608 2019-04-17  Jim Wilson  <jimw@sifive.com>
5609             Andrew Burgess  <andrew.burgess@embecosm.com>
5610
5611         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5612         code read might fail, assume 4-byte breakpoint in that case.
5613
5614 2019-04-15  Leszek Swirski  <leszeks@google.com>
5615
5616         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5617         rather than a hand-rolled POD check when checking for forced MEMORY
5618         classification.
5619
5620 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5621
5622         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5623         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5624         function.
5625         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5626         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5627         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5628         declaration.
5629
5630 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5631
5632         * aarch64-linux-nat.c
5633         (aarch64_linux_nat_target::thread_architecture): Add override.
5634         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5635         each VQ.
5636
5637 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5638
5639         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5640
5641 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5644         target types of size 96-bits, add some additional comments, and
5645         check that the builtin type we found was the correct size.
5646
5647 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5648
5649         * utils.c (prompt_for_continue): Don't restore the styling at the
5650         end, as applied_style has the wrong value.  This fixes styling in
5651         long lists of file names that are interrupted by the "Continue?"
5652         prompt.
5653
5654 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5655
5656         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5657         * c-lang.c (c_language_defn): Likewise.
5658         (cplus_language_defn): Likewise.
5659         (asm_language_defn): Likewise.
5660         (minimal_language_defn): Likewise.
5661         * d-lang.c (d_language_defn): Likewise.
5662         * f-lang.c (f_language_defn): Likewise.
5663         * go-lang.c (go_language_defn): Likewise.
5664         * language.c (unknown_language_defn): Likewise.
5665         (auto_language_defn): Likewise.
5666         * language.h (struct language_defn): Remove la_magic field.
5667         (LANG_MAGIC): Delete.
5668         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5669         * objc-lang.c (objc_language_defn): Likewise.
5670         * opencl-lang.c (opencl_language_defn): Likewise.
5671         * p-lang.c (pascal_language_defn): Likewise.
5672         * rust-lang.c (rust_language_defn): Likewise.
5673
5674 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5675
5676         * riscv-tdep.c (riscv_type_align): New function.
5677         (riscv_type_alignment): Delete.
5678         (riscv_arg_location): Use 'type_align'.
5679         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5680
5681 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5682
5683         * gdbtypes.c (type_align): A struct with no non-static fields also
5684         has alignment of 1.
5685
5686 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5687
5688         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5689         component to 0.
5690         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5691         member.
5692         (riscv_struct_info::analyse): New implementation using new
5693         analyse_inner member function.
5694         (riscv_struct_info::field_offset): New member function.
5695         (riscv_struct_info::m_offsets): New member variable.
5696         (riscv_struct_info::analyse_inner): New private member function,
5697         takes the old implementation of riscv_struct_info::analyse but
5698         extended to track field offsets.
5699         (riscv_call_arg_struct): Update the struct folding special cases
5700         to handle cases where empty C++ structs, which are non-zero
5701         length, are found.
5702         (riscv_arg_location): Initialise the length of each location, a
5703         non-zero length now indicates the location is in use.
5704         (riscv_push_dummy_call): Allow for the first location having a
5705         non-zero offset when setting up arguments.
5706         (riscv_return_value): Likewise, but for return values.
5707
5708 2019-04-11  Tom Tromey  <tromey@adacore.com>
5709
5710         * utils.c (internal_vproblem): Make "msg" const.
5711
5712 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5713
5714         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5715         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5716         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5717         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5718
5719 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5720
5721         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5722         function.
5723         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5724         of amd64_collect_native_gregset.
5725         (amd64_linux_nat_target::store_registers): Likewise.
5726
5727 2019-04-10  Tom Tromey  <tom@tromey.com>
5728
5729         * symtab.c (lookup_global_symbol_from_objfile)
5730         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5731         * objfiles.h (class separate_debug_iterator): New.
5732         (class separate_debug_range): New.
5733         (struct objfile) <separate_debug_objfiles>: New method.
5734         (objfile_separate_debug_iterate): Don't declare.
5735         * objfiles.c (separate_debug_iterator::operator++): Rename from
5736         objfile_separate_debug_iterate.
5737         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5738         iterator.
5739         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5740         iterator.
5741
5742 2019-04-10  Tom Tromey  <tom@tromey.com>
5743
5744         * symfile.c (reread_symbols): Remove old comment.
5745         * objfiles.c (free_all_objfiles): Fix a typo.
5746
5747 2019-04-10  Tom Tromey  <tom@tromey.com>
5748
5749         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5750         * minsyms.c (lookup_minimal_symbol): Use foreach.
5751         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5752         (lookup_minimal_symbol_solib_trampoline): Likewise.
5753         * symfile.c (reread_symbols): Use foreach.
5754
5755 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5756             Tom Tromey  <tromey@adacore.com>
5757
5758         PR rust/24414:
5759         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5760         (rust_lex_int_test): Change "value" to be LONGEST.
5761         (rust_lex_tests): Add test for long integer literal.
5762
5763 2019-04-09  Tom Tromey  <tromey@adacore.com>
5764
5765         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5766         to bool.
5767         (extended_remote_target::attach): Update.
5768         (remote_target::remote_notice_new_inferior): Update.
5769         (remote_target::add_current_inferior_and_thread): Update.
5770         * inferior.c (exit_inferior_1): Use "false".
5771         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5772
5773 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5774
5775         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5776         the "start" command.
5777
5778 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5779
5780         * python/py-inferior.c (infpy_thread_from_thread_handle):
5781         Adjust comments to reflect renaming of thread_from_thread_handle
5782         to thread_from_handle.  Adjust keywords.  Fix type error message.
5783         (inferior_object_methods): Add thread_from_handle.  Retain
5784         thread_from_thread_handle, but mark it as deprecated.
5785
5786 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5787
5788         * gdbthread.h (find_thread_by_handle): Revise declaration.
5789         * thread.c (find_thread_by_handle): Likewise.  Adjust
5790         implementation too.
5791         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5792         support for buffer objects as handles.
5793
5794 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5795
5796         * python/py-infthread.c (thpy_thread_handle): New function.
5797         (thread_object_methods): Register thpy_thread_handle.
5798
5799 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5800
5801         * gdbthread.h (thread_to_thread_handle): Declare.
5802         * thread.c (gdbtypes.h): Include.
5803         (thread_to_thread_handle): New function.
5804
5805         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5806         (target_thread_info_to_thread_handle): Declare.
5807         * target.c (target_thread_info_to_thread_handle): New function.
5808         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5809         * target-delegates.c: Regenerate.
5810
5811         * linux-thread-db.c (class thread_db_target): Add method
5812         thread_info_to_thread_handle.
5813         (thread_db_target::thread_info_to_thread_handle): Define.
5814         * remote.c (class remote_target): Add new method
5815         thread_info_to_thread_handle.
5816         (remote_target::thread_info_to_thread_handle): Define.
5817
5818 2019-04-08  Pedro Alves  <palves@redhat.com>
5819
5820         * common/common-exceptions.c (throw_exception): Don't create
5821         named object to throw; throw directly.
5822         (throw_it): Likewise.  Don't initialize gdb_exception::message
5823         here, with new; pass FMT and AP to the ctor instead.
5824         * common/common-exceptions.h: Include <string>.
5825         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5826         const char *, va_list)): New ctor.  Use std::make_shared.
5827         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5828         errors)): Delete.
5829         (gdb_exception_error::gdb_exception_error(enum errors, const char
5830         *, va_list)): New.
5831         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5832         Add assertion.
5833         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5834         errors)): Delete.
5835         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5836         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5837         Add assertion.
5838
5839 2019-04-08  Tom Tromey  <tom@tromey.com>
5840
5841         * valops.c (value_rtti_indirect_type): Replace throw_exception
5842         with throw.
5843         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5844         with throw.
5845         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5846         throw.
5847         * target.c (target_translate_tls_address): Replace throw_exception
5848         with throw.
5849         * stack.c (frame_apply_command_count): Replace throw_exception
5850         with throw.
5851         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5852         throw.
5853         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5854         with throw.
5855         * rs6000-tdep.c (rs6000_frame_cache)
5856         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5857         * remote.c: Replace throw_exception with throw.
5858         * record-full.c (record_full_message, record_full_wait_1)
5859         (record_full_restore): Replace throw_exception with throw.
5860         * record-btrace.c:
5861         (get_thread_current_frame_id, record_btrace_start_replaying)
5862         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5863         (cmd_record_btrace_start): Replace throw_exception with throw.
5864         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5865         throw.
5866         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5867         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5868         * linespec.c:
5869         (find_linespec_symbols): Replace throw_exception with throw.
5870         * infrun.c (displaced_step_prepare, resume): Replace
5871         throw_exception with throw.
5872         * infcmd.c (post_create_inferior): Replace throw_exception with
5873         throw.
5874         * inf-loop.c (inferior_event_handler): Replace throw_exception
5875         with throw.
5876         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5877         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5878         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5879         (get_prev_frame_always, get_frame_pc_if_available)
5880         (get_frame_address_in_block_if_available, get_frame_language):
5881         Replace throw_exception with throw.
5882         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5883         throw_exception with throw.
5884         * eval.c (fetch_subexp_value, evaluate_var_value)
5885         (evaluate_funcall, evaluate_subexp_standard): Replace
5886         throw_exception with throw.
5887         * dwarf2loc.c (call_site_find_chain)
5888         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5889         Replace throw_exception with throw.
5890         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5891         with throw.
5892         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5893         throw.
5894         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5895         * completer.c (complete_line_internal): Replace throw_exception
5896         with throw.
5897         * compile/compile-object-run.c (compile_object_run): Replace
5898         throw_exception with throw.
5899         * cli/cli-script.c (process_next_line): Replace throw_exception
5900         with throw.
5901         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5902         (btrace_enable, btrace_maint_update_pt_packets): Replace
5903         throw_exception with throw.
5904         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5905         throw_exception with throw.
5906         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5907         throw_exception with throw.
5908         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5909         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5910         * aarch64-tdep.c (aarch64_make_prologue_cache)
5911         (aarch64_make_stub_cache): Replace throw_exception with throw.
5912
5913 2019-04-08  Tom Tromey  <tom@tromey.com>
5914
5915         * common/common-exceptions.c (throw_exception): Rename from
5916         throw_exception_cxx.  Remove old copy.  Make argument const.
5917         (throw_it): Create and throw exception objects directly.
5918         * common/common-exceptions.h (throw_exception): Make argument
5919         const.
5920         (struct gdb_exception_error): Add constructor.
5921         (struct gdb_exception_quit): Add constructor.
5922
5923 2019-04-08  Tom Tromey  <tom@tromey.com>
5924
5925         * common/common-exceptions.h (exception_rethrow): Don't declare.
5926         (TRY_SJLJ): Update comment.
5927         (TRY, CATCH, END_CATCH): Remove.
5928         * common/common-exceptions.c (exception_rethrow): Remove.
5929
5930 2019-04-08  Tom Tromey  <tom@tromey.com>
5931
5932         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5933         Remove.
5934         (gdb_exception_error): Rename from
5935         gdb_exception_RETURN_MASK_ERROR.
5936         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5937         (gdb_quit_bad_alloc): Update.
5938         * aarch64-tdep.c: Update.
5939         * ada-lang.c: Update.
5940         * ada-typeprint.c: Update.
5941         * ada-valprint.c: Update.
5942         * amd64-tdep.c: Update.
5943         * arch-utils.c: Update.
5944         * break-catch-throw.c: Update.
5945         * breakpoint.c: Update.
5946         * btrace.c: Update.
5947         * c-varobj.c: Update.
5948         * cli/cli-cmds.c: Update.
5949         * cli/cli-interp.c: Update.
5950         * cli/cli-script.c: Update.
5951         * common/common-exceptions.c: Update.
5952         * common/new-op.c: Update.
5953         * common/selftest.c: Update.
5954         * compile/compile-c-symbols.c: Update.
5955         * compile/compile-cplus-symbols.c: Update.
5956         * compile/compile-object-load.c: Update.
5957         * compile/compile-object-run.c: Update.
5958         * completer.c: Update.
5959         * corelow.c: Update.
5960         * cp-abi.c: Update.
5961         * cp-support.c: Update.
5962         * cp-valprint.c: Update.
5963         * darwin-nat.c: Update.
5964         * disasm-selftests.c: Update.
5965         * dtrace-probe.c: Update.
5966         * dwarf-index-cache.c: Update.
5967         * dwarf-index-write.c: Update.
5968         * dwarf2-frame-tailcall.c: Update.
5969         * dwarf2-frame.c: Update.
5970         * dwarf2loc.c: Update.
5971         * dwarf2read.c: Update.
5972         * eval.c: Update.
5973         * event-loop.c: Update.
5974         * event-top.c: Update.
5975         * exec.c: Update.
5976         * f-valprint.c: Update.
5977         * fbsd-tdep.c: Update.
5978         * frame-unwind.c: Update.
5979         * frame.c: Update.
5980         * gdbtypes.c: Update.
5981         * gnu-v3-abi.c: Update.
5982         * guile/guile-internal.h: Update.
5983         * guile/scm-block.c: Update.
5984         * guile/scm-breakpoint.c: Update.
5985         * guile/scm-cmd.c: Update.
5986         * guile/scm-disasm.c: Update.
5987         * guile/scm-frame.c: Update.
5988         * guile/scm-lazy-string.c: Update.
5989         * guile/scm-math.c: Update.
5990         * guile/scm-param.c: Update.
5991         * guile/scm-ports.c: Update.
5992         * guile/scm-pretty-print.c: Update.
5993         * guile/scm-symbol.c: Update.
5994         * guile/scm-symtab.c: Update.
5995         * guile/scm-type.c: Update.
5996         * guile/scm-value.c: Update.
5997         * i386-linux-tdep.c: Update.
5998         * i386-tdep.c: Update.
5999         * inf-loop.c: Update.
6000         * infcall.c: Update.
6001         * infcmd.c: Update.
6002         * infrun.c: Update.
6003         * jit.c: Update.
6004         * language.c: Update.
6005         * linespec.c: Update.
6006         * linux-fork.c: Update.
6007         * linux-nat.c: Update.
6008         * linux-tdep.c: Update.
6009         * linux-thread-db.c: Update.
6010         * main.c: Update.
6011         * mi/mi-cmd-break.c: Update.
6012         * mi/mi-cmd-stack.c: Update.
6013         * mi/mi-interp.c: Update.
6014         * mi/mi-main.c: Update.
6015         * objc-lang.c: Update.
6016         * p-valprint.c: Update.
6017         * parse.c: Update.
6018         * ppc-linux-tdep.c: Update.
6019         * printcmd.c: Update.
6020         * python/py-arch.c: Update.
6021         * python/py-breakpoint.c: Update.
6022         * python/py-cmd.c: Update.
6023         * python/py-finishbreakpoint.c: Update.
6024         * python/py-frame.c: Update.
6025         * python/py-framefilter.c: Update.
6026         * python/py-gdb-readline.c: Update.
6027         * python/py-inferior.c: Update.
6028         * python/py-infthread.c: Update.
6029         * python/py-lazy-string.c: Update.
6030         * python/py-linetable.c: Update.
6031         * python/py-objfile.c: Update.
6032         * python/py-param.c: Update.
6033         * python/py-prettyprint.c: Update.
6034         * python/py-progspace.c: Update.
6035         * python/py-record-btrace.c: Update.
6036         * python/py-record.c: Update.
6037         * python/py-symbol.c: Update.
6038         * python/py-type.c: Update.
6039         * python/py-unwind.c: Update.
6040         * python/py-utils.c: Update.
6041         * python/py-value.c: Update.
6042         * python/python.c: Update.
6043         * record-btrace.c: Update.
6044         * record-full.c: Update.
6045         * remote-fileio.c: Update.
6046         * remote.c: Update.
6047         * riscv-tdep.c: Update.
6048         * rs6000-aix-tdep.c: Update.
6049         * rs6000-tdep.c: Update.
6050         * rust-exp.y: Update.
6051         * rust-lang.c: Update.
6052         * s390-tdep.c: Update.
6053         * selftest-arch.c: Update.
6054         * solib-dsbt.c: Update.
6055         * solib-frv.c: Update.
6056         * solib-spu.c: Update.
6057         * solib-svr4.c: Update.
6058         * solib.c: Update.
6059         * sparc64-linux-tdep.c: Update.
6060         * stack.c: Update.
6061         * symfile-mem.c: Update.
6062         * symmisc.c: Update.
6063         * target.c: Update.
6064         * thread.c: Update.
6065         * top.c: Update.
6066         * tracefile-tfile.c: Update.
6067         * tui/tui.c: Update.
6068         * typeprint.c: Update.
6069         * unittests/cli-utils-selftests.c: Update.
6070         * unittests/parse-connection-spec-selftests.c: Update.
6071         * valops.c: Update.
6072         * valprint.c: Update.
6073         * value.c: Update.
6074         * varobj.c: Update.
6075         * windows-nat.c: Update.
6076         * x86-linux-nat.c: Update.
6077         * xml-support.c: Update.
6078
6079 2019-04-08  Tom Tromey  <tom@tromey.com>
6080
6081         * xml-support.c: Use C++ exception handling.
6082         * x86-linux-nat.c: Use C++ exception handling.
6083         * windows-nat.c: Use C++ exception handling.
6084         * varobj.c: Use C++ exception handling.
6085         * value.c: Use C++ exception handling.
6086         * valprint.c: Use C++ exception handling.
6087         * valops.c: Use C++ exception handling.
6088         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6089         handling.
6090         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6091         * typeprint.c: Use C++ exception handling.
6092         * tui/tui.c: Use C++ exception handling.
6093         * tracefile-tfile.c: Use C++ exception handling.
6094         * top.c: Use C++ exception handling.
6095         * thread.c: Use C++ exception handling.
6096         * target.c: Use C++ exception handling.
6097         * symmisc.c: Use C++ exception handling.
6098         * symfile-mem.c: Use C++ exception handling.
6099         * stack.c: Use C++ exception handling.
6100         * sparc64-linux-tdep.c: Use C++ exception handling.
6101         * solib.c: Use C++ exception handling.
6102         * solib-svr4.c: Use C++ exception handling.
6103         * solib-spu.c: Use C++ exception handling.
6104         * solib-frv.c: Use C++ exception handling.
6105         * solib-dsbt.c: Use C++ exception handling.
6106         * selftest-arch.c: Use C++ exception handling.
6107         * s390-tdep.c: Use C++ exception handling.
6108         * rust-lang.c: Use C++ exception handling.
6109         * rust-exp.y: Use C++ exception handling.
6110         * rs6000-tdep.c: Use C++ exception handling.
6111         * rs6000-aix-tdep.c: Use C++ exception handling.
6112         * riscv-tdep.c: Use C++ exception handling.
6113         * remote.c: Use C++ exception handling.
6114         * remote-fileio.c: Use C++ exception handling.
6115         * record-full.c: Use C++ exception handling.
6116         * record-btrace.c: Use C++ exception handling.
6117         * python/python.c: Use C++ exception handling.
6118         * python/py-value.c: Use C++ exception handling.
6119         * python/py-utils.c: Use C++ exception handling.
6120         * python/py-unwind.c: Use C++ exception handling.
6121         * python/py-type.c: Use C++ exception handling.
6122         * python/py-symbol.c: Use C++ exception handling.
6123         * python/py-record.c: Use C++ exception handling.
6124         * python/py-record-btrace.c: Use C++ exception handling.
6125         * python/py-progspace.c: Use C++ exception handling.
6126         * python/py-prettyprint.c: Use C++ exception handling.
6127         * python/py-param.c: Use C++ exception handling.
6128         * python/py-objfile.c: Use C++ exception handling.
6129         * python/py-linetable.c: Use C++ exception handling.
6130         * python/py-lazy-string.c: Use C++ exception handling.
6131         * python/py-infthread.c: Use C++ exception handling.
6132         * python/py-inferior.c: Use C++ exception handling.
6133         * python/py-gdb-readline.c: Use C++ exception handling.
6134         * python/py-framefilter.c: Use C++ exception handling.
6135         * python/py-frame.c: Use C++ exception handling.
6136         * python/py-finishbreakpoint.c: Use C++ exception handling.
6137         * python/py-cmd.c: Use C++ exception handling.
6138         * python/py-breakpoint.c: Use C++ exception handling.
6139         * python/py-arch.c: Use C++ exception handling.
6140         * printcmd.c: Use C++ exception handling.
6141         * ppc-linux-tdep.c: Use C++ exception handling.
6142         * parse.c: Use C++ exception handling.
6143         * p-valprint.c: Use C++ exception handling.
6144         * objc-lang.c: Use C++ exception handling.
6145         * mi/mi-main.c: Use C++ exception handling.
6146         * mi/mi-interp.c: Use C++ exception handling.
6147         * mi/mi-cmd-stack.c: Use C++ exception handling.
6148         * mi/mi-cmd-break.c: Use C++ exception handling.
6149         * main.c: Use C++ exception handling.
6150         * linux-thread-db.c: Use C++ exception handling.
6151         * linux-tdep.c: Use C++ exception handling.
6152         * linux-nat.c: Use C++ exception handling.
6153         * linux-fork.c: Use C++ exception handling.
6154         * linespec.c: Use C++ exception handling.
6155         * language.c: Use C++ exception handling.
6156         * jit.c: Use C++ exception handling.
6157         * infrun.c: Use C++ exception handling.
6158         * infcmd.c: Use C++ exception handling.
6159         * infcall.c: Use C++ exception handling.
6160         * inf-loop.c: Use C++ exception handling.
6161         * i386-tdep.c: Use C++ exception handling.
6162         * i386-linux-tdep.c: Use C++ exception handling.
6163         * guile/scm-value.c: Use C++ exception handling.
6164         * guile/scm-type.c: Use C++ exception handling.
6165         * guile/scm-symtab.c: Use C++ exception handling.
6166         * guile/scm-symbol.c: Use C++ exception handling.
6167         * guile/scm-pretty-print.c: Use C++ exception handling.
6168         * guile/scm-ports.c: Use C++ exception handling.
6169         * guile/scm-param.c: Use C++ exception handling.
6170         * guile/scm-math.c: Use C++ exception handling.
6171         * guile/scm-lazy-string.c: Use C++ exception handling.
6172         * guile/scm-frame.c: Use C++ exception handling.
6173         * guile/scm-disasm.c: Use C++ exception handling.
6174         * guile/scm-cmd.c: Use C++ exception handling.
6175         * guile/scm-breakpoint.c: Use C++ exception handling.
6176         * guile/scm-block.c: Use C++ exception handling.
6177         * guile/guile-internal.h: Use C++ exception handling.
6178         * gnu-v3-abi.c: Use C++ exception handling.
6179         * gdbtypes.c: Use C++ exception handling.
6180         * frame.c: Use C++ exception handling.
6181         * frame-unwind.c: Use C++ exception handling.
6182         * fbsd-tdep.c: Use C++ exception handling.
6183         * f-valprint.c: Use C++ exception handling.
6184         * exec.c: Use C++ exception handling.
6185         * event-top.c: Use C++ exception handling.
6186         * event-loop.c: Use C++ exception handling.
6187         * eval.c: Use C++ exception handling.
6188         * dwarf2read.c: Use C++ exception handling.
6189         * dwarf2loc.c: Use C++ exception handling.
6190         * dwarf2-frame.c: Use C++ exception handling.
6191         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6192         * dwarf-index-write.c: Use C++ exception handling.
6193         * dwarf-index-cache.c: Use C++ exception handling.
6194         * dtrace-probe.c: Use C++ exception handling.
6195         * disasm-selftests.c: Use C++ exception handling.
6196         * darwin-nat.c: Use C++ exception handling.
6197         * cp-valprint.c: Use C++ exception handling.
6198         * cp-support.c: Use C++ exception handling.
6199         * cp-abi.c: Use C++ exception handling.
6200         * corelow.c: Use C++ exception handling.
6201         * completer.c: Use C++ exception handling.
6202         * compile/compile-object-run.c: Use C++ exception handling.
6203         * compile/compile-object-load.c: Use C++ exception handling.
6204         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6205         * compile/compile-c-symbols.c: Use C++ exception handling.
6206         * common/selftest.c: Use C++ exception handling.
6207         * common/new-op.c: Use C++ exception handling.
6208         * cli/cli-script.c: Use C++ exception handling.
6209         * cli/cli-interp.c: Use C++ exception handling.
6210         * cli/cli-cmds.c: Use C++ exception handling.
6211         * c-varobj.c: Use C++ exception handling.
6212         * btrace.c: Use C++ exception handling.
6213         * breakpoint.c: Use C++ exception handling.
6214         * break-catch-throw.c: Use C++ exception handling.
6215         * arch-utils.c: Use C++ exception handling.
6216         * amd64-tdep.c: Use C++ exception handling.
6217         * ada-valprint.c: Use C++ exception handling.
6218         * ada-typeprint.c: Use C++ exception handling.
6219         * ada-lang.c: Use C++ exception handling.
6220         * aarch64-tdep.c: Use C++ exception handling.
6221
6222 2019-04-08  Tom Tromey  <tom@tromey.com>
6223
6224         * xml-support.c (gdb_xml_parser::parse): Update.
6225         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6226         * value.c (show_convenience): Update.
6227         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6228         (test_parse_flags_qcs): Update.
6229         * thread.c (thr_try_catch_cmd): Update.
6230         * target.c (target_translate_tls_address): Update.
6231         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6232         (info_frame_command_core, frame_apply_command_count): Update.
6233         * rust-exp.y (rust_lex_exception_test): Update.
6234         * riscv-tdep.c (riscv_print_one_register_info): Update.
6235         * remote.c (remote_target::enable_btrace): Update.
6236         * record-btrace.c (record_btrace_enable_warn): Update.
6237         * python/py-utils.c (gdbpy_convert_exception): Update.
6238         * printcmd.c (do_one_display, print_variable_and_value): Update.
6239         * mi/mi-main.c (mi_print_exception): Update.
6240         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6241         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6242         * linux-nat.c (linux_nat_target::attach): Update.
6243         * linux-fork.c (class scoped_switch_fork_info): Update.
6244         * infrun.c (displaced_step_prepare): Update.
6245         * infcall.c (call_function_by_hand_dummy): Update.
6246         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6247         * gnu-v3-abi.c (print_one_vtable): Update.
6248         * frame.c (get_prev_frame_always): Update.
6249         * f-valprint.c (info_common_command_for_block): Update.
6250         * exec.c (try_open_exec_file): Update.
6251         * exceptions.c (print_exception, exception_print)
6252         (exception_fprintf, exception_print_same): Update.
6253         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6254         * dwarf-index-cache.c (index_cache::store)
6255         (index_cache::lookup_gdb_index): Update.
6256         * darwin-nat.c (maybe_cache_shell): Update.
6257         * cp-valprint.c (cp_print_value_fields): Update.
6258         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6259         (gcc_cplus_symbol_address): Update.
6260         * compile/compile-c-symbols.c (gcc_convert_symbol)
6261         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6262         * common/selftest.c: Update.
6263         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6264         a std::string.
6265         (exception_try_scope_entry, exception_try_scope_exit): Don't
6266         declare.
6267         (struct exception_try_scope): Remove.
6268         (TRY): Don't use exception_try_scope.
6269         (struct gdb_exception): Add constructor, operator=.
6270         <what>: New method.
6271         (struct gdb_exception_RETURN_MASK_ALL)
6272         (struct gdb_exception_RETURN_MASK_ERROR)
6273         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6274         (struct gdb_quit_bad_alloc): Update.
6275         * common/common-exceptions.c (exception_none): Change
6276         initializer.
6277         (struct catcher) <state, exception>: Initialize inline.
6278         <prev>: Remove member.
6279         (current_catcher): Remove.
6280         (catchers): New global.
6281         (exceptions_state_mc_init): Simplify.
6282         (catcher_pop): Remove.
6283         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6284         (try_scope_depth, exception_try_scope_entry)
6285         (exception_try_scope_exit): Remove.
6286         (throw_exception_sjlj): Update.
6287         (exception_messages, exception_messages_size): Remove.
6288         (throw_it): Simplify.
6289         (gdb_exception_sliced_copy): Remove.
6290         (throw_exception_cxx): Update.
6291         * cli/cli-script.c (script_from_file): Update.
6292         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6293         Update.
6294         * ada-valprint.c (ada_val_print): Update.
6295         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6296         (create_excep_cond_exprs): Update.
6297
6298 2019-04-08  Tom Tromey  <tom@tromey.com>
6299
6300         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6301         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6302         (TRY, CATCH, END_CATCH): Remove some definitions.
6303         * common/common-exceptions.c: Don't use GDB_XCPT.
6304         (catcher_list_size): Remove.
6305         (throw_exception, throw_it): Simplify.
6306
6307 2019-04-05  Tom Tromey  <tom@tromey.com>
6308
6309         Revert the header-sorting patch.
6310         * ft32-tdep.c: Revert.
6311         * frv-tdep.c: Revert.
6312         * frv-linux-tdep.c: Revert.
6313         * frame.c: Revert.
6314         * frame-unwind.c: Revert.
6315         * frame-base.c: Revert.
6316         * fork-child.c: Revert.
6317         * findvar.c: Revert.
6318         * findcmd.c: Revert.
6319         * filesystem.c: Revert.
6320         * filename-seen-cache.h: Revert.
6321         * filename-seen-cache.c: Revert.
6322         * fbsd-tdep.c: Revert.
6323         * fbsd-nat.h: Revert.
6324         * fbsd-nat.c: Revert.
6325         * f-valprint.c: Revert.
6326         * f-typeprint.c: Revert.
6327         * f-lang.c: Revert.
6328         * extension.h: Revert.
6329         * extension.c: Revert.
6330         * extension-priv.h: Revert.
6331         * expprint.c: Revert.
6332         * exec.h: Revert.
6333         * exec.c: Revert.
6334         * exceptions.c: Revert.
6335         * event-top.c: Revert.
6336         * event-loop.c: Revert.
6337         * eval.c: Revert.
6338         * elfread.c: Revert.
6339         * dwarf2read.h: Revert.
6340         * dwarf2read.c: Revert.
6341         * dwarf2loc.c: Revert.
6342         * dwarf2expr.h: Revert.
6343         * dwarf2expr.c: Revert.
6344         * dwarf2-frame.c: Revert.
6345         * dwarf2-frame-tailcall.c: Revert.
6346         * dwarf-index-write.h: Revert.
6347         * dwarf-index-write.c: Revert.
6348         * dwarf-index-common.c: Revert.
6349         * dwarf-index-cache.h: Revert.
6350         * dwarf-index-cache.c: Revert.
6351         * dummy-frame.c: Revert.
6352         * dtrace-probe.c: Revert.
6353         * disasm.h: Revert.
6354         * disasm.c: Revert.
6355         * disasm-selftests.c: Revert.
6356         * dictionary.c: Revert.
6357         * dicos-tdep.c: Revert.
6358         * demangle.c: Revert.
6359         * dcache.h: Revert.
6360         * dcache.c: Revert.
6361         * darwin-nat.h: Revert.
6362         * darwin-nat.c: Revert.
6363         * darwin-nat-info.c: Revert.
6364         * d-valprint.c: Revert.
6365         * d-namespace.c: Revert.
6366         * d-lang.c: Revert.
6367         * ctf.c: Revert.
6368         * csky-tdep.c: Revert.
6369         * csky-linux-tdep.c: Revert.
6370         * cris-tdep.c: Revert.
6371         * cris-linux-tdep.c: Revert.
6372         * cp-valprint.c: Revert.
6373         * cp-support.c: Revert.
6374         * cp-namespace.c: Revert.
6375         * cp-abi.c: Revert.
6376         * corelow.c: Revert.
6377         * corefile.c: Revert.
6378         * continuations.c: Revert.
6379         * completer.h: Revert.
6380         * completer.c: Revert.
6381         * complaints.c: Revert.
6382         * coffread.c: Revert.
6383         * coff-pe-read.c: Revert.
6384         * cli-out.h: Revert.
6385         * cli-out.c: Revert.
6386         * charset.c: Revert.
6387         * c-varobj.c: Revert.
6388         * c-valprint.c: Revert.
6389         * c-typeprint.c: Revert.
6390         * c-lang.c: Revert.
6391         * buildsym.c: Revert.
6392         * buildsym-legacy.c: Revert.
6393         * build-id.h: Revert.
6394         * build-id.c: Revert.
6395         * btrace.c: Revert.
6396         * bsd-uthread.c: Revert.
6397         * breakpoint.h: Revert.
6398         * breakpoint.c: Revert.
6399         * break-catch-throw.c: Revert.
6400         * break-catch-syscall.c: Revert.
6401         * break-catch-sig.c: Revert.
6402         * blockframe.c: Revert.
6403         * block.c: Revert.
6404         * bfin-tdep.c: Revert.
6405         * bfin-linux-tdep.c: Revert.
6406         * bfd-target.c: Revert.
6407         * bcache.c: Revert.
6408         * ax-general.c: Revert.
6409         * ax-gdb.h: Revert.
6410         * ax-gdb.c: Revert.
6411         * avr-tdep.c: Revert.
6412         * auxv.c: Revert.
6413         * auto-load.c: Revert.
6414         * arm-wince-tdep.c: Revert.
6415         * arm-tdep.c: Revert.
6416         * arm-symbian-tdep.c: Revert.
6417         * arm-pikeos-tdep.c: Revert.
6418         * arm-obsd-tdep.c: Revert.
6419         * arm-nbsd-tdep.c: Revert.
6420         * arm-nbsd-nat.c: Revert.
6421         * arm-linux-tdep.c: Revert.
6422         * arm-linux-nat.c: Revert.
6423         * arm-fbsd-tdep.c: Revert.
6424         * arm-fbsd-nat.c: Revert.
6425         * arm-bsd-tdep.c: Revert.
6426         * arch-utils.c: Revert.
6427         * arc-tdep.c: Revert.
6428         * arc-newlib-tdep.c: Revert.
6429         * annotate.h: Revert.
6430         * annotate.c: Revert.
6431         * amd64-windows-tdep.c: Revert.
6432         * amd64-windows-nat.c: Revert.
6433         * amd64-tdep.c: Revert.
6434         * amd64-sol2-tdep.c: Revert.
6435         * amd64-obsd-tdep.c: Revert.
6436         * amd64-obsd-nat.c: Revert.
6437         * amd64-nbsd-tdep.c: Revert.
6438         * amd64-nbsd-nat.c: Revert.
6439         * amd64-nat.c: Revert.
6440         * amd64-linux-tdep.c: Revert.
6441         * amd64-linux-nat.c: Revert.
6442         * amd64-fbsd-tdep.c: Revert.
6443         * amd64-fbsd-nat.c: Revert.
6444         * amd64-dicos-tdep.c: Revert.
6445         * amd64-darwin-tdep.c: Revert.
6446         * amd64-bsd-nat.c: Revert.
6447         * alpha-tdep.c: Revert.
6448         * alpha-obsd-tdep.c: Revert.
6449         * alpha-nbsd-tdep.c: Revert.
6450         * alpha-mdebug-tdep.c: Revert.
6451         * alpha-linux-tdep.c: Revert.
6452         * alpha-linux-nat.c: Revert.
6453         * alpha-bsd-tdep.c: Revert.
6454         * alpha-bsd-nat.c: Revert.
6455         * aix-thread.c: Revert.
6456         * agent.c: Revert.
6457         * addrmap.c: Revert.
6458         * ada-varobj.c: Revert.
6459         * ada-valprint.c: Revert.
6460         * ada-typeprint.c: Revert.
6461         * ada-tasks.c: Revert.
6462         * ada-lang.c: Revert.
6463         * aarch64-tdep.c: Revert.
6464         * aarch64-ravenscar-thread.c: Revert.
6465         * aarch64-newlib-tdep.c: Revert.
6466         * aarch64-linux-tdep.c: Revert.
6467         * aarch64-linux-nat.c: Revert.
6468         * aarch64-fbsd-tdep.c: Revert.
6469         * aarch64-fbsd-nat.c: Revert.
6470         * aarch32-linux-nat.c: Revert.
6471
6472 2019-04-05  Tom Tromey  <tom@tromey.com>
6473
6474         * ft32-tdep.c: Sort headers.
6475         * frv-tdep.c: Sort headers.
6476         * frv-linux-tdep.c: Sort headers.
6477         * frame.c: Sort headers.
6478         * frame-unwind.c: Sort headers.
6479         * frame-base.c: Sort headers.
6480         * fork-child.c: Sort headers.
6481         * findvar.c: Sort headers.
6482         * findcmd.c: Sort headers.
6483         * filesystem.c: Sort headers.
6484         * filename-seen-cache.h: Sort headers.
6485         * filename-seen-cache.c: Sort headers.
6486         * fbsd-tdep.c: Sort headers.
6487         * fbsd-nat.h: Sort headers.
6488         * fbsd-nat.c: Sort headers.
6489         * f-valprint.c: Sort headers.
6490         * f-typeprint.c: Sort headers.
6491         * f-lang.c: Sort headers.
6492         * extension.h: Sort headers.
6493         * extension.c: Sort headers.
6494         * extension-priv.h: Sort headers.
6495         * expprint.c: Sort headers.
6496         * exec.h: Sort headers.
6497         * exec.c: Sort headers.
6498         * exceptions.c: Sort headers.
6499         * event-top.c: Sort headers.
6500         * event-loop.c: Sort headers.
6501         * eval.c: Sort headers.
6502         * elfread.c: Sort headers.
6503         * dwarf2read.h: Sort headers.
6504         * dwarf2read.c: Sort headers.
6505         * dwarf2loc.c: Sort headers.
6506         * dwarf2expr.h: Sort headers.
6507         * dwarf2expr.c: Sort headers.
6508         * dwarf2-frame.c: Sort headers.
6509         * dwarf2-frame-tailcall.c: Sort headers.
6510         * dwarf-index-write.h: Sort headers.
6511         * dwarf-index-write.c: Sort headers.
6512         * dwarf-index-common.c: Sort headers.
6513         * dwarf-index-cache.h: Sort headers.
6514         * dwarf-index-cache.c: Sort headers.
6515         * dummy-frame.c: Sort headers.
6516         * dtrace-probe.c: Sort headers.
6517         * disasm.h: Sort headers.
6518         * disasm.c: Sort headers.
6519         * disasm-selftests.c: Sort headers.
6520         * dictionary.c: Sort headers.
6521         * dicos-tdep.c: Sort headers.
6522         * demangle.c: Sort headers.
6523         * dcache.h: Sort headers.
6524         * dcache.c: Sort headers.
6525         * darwin-nat.h: Sort headers.
6526         * darwin-nat.c: Sort headers.
6527         * darwin-nat-info.c: Sort headers.
6528         * d-valprint.c: Sort headers.
6529         * d-namespace.c: Sort headers.
6530         * d-lang.c: Sort headers.
6531         * ctf.c: Sort headers.
6532         * csky-tdep.c: Sort headers.
6533         * csky-linux-tdep.c: Sort headers.
6534         * cris-tdep.c: Sort headers.
6535         * cris-linux-tdep.c: Sort headers.
6536         * cp-valprint.c: Sort headers.
6537         * cp-support.c: Sort headers.
6538         * cp-namespace.c: Sort headers.
6539         * cp-abi.c: Sort headers.
6540         * corelow.c: Sort headers.
6541         * corefile.c: Sort headers.
6542         * continuations.c: Sort headers.
6543         * completer.h: Sort headers.
6544         * completer.c: Sort headers.
6545         * complaints.c: Sort headers.
6546         * coffread.c: Sort headers.
6547         * coff-pe-read.c: Sort headers.
6548         * cli-out.h: Sort headers.
6549         * cli-out.c: Sort headers.
6550         * charset.c: Sort headers.
6551         * c-varobj.c: Sort headers.
6552         * c-valprint.c: Sort headers.
6553         * c-typeprint.c: Sort headers.
6554         * c-lang.c: Sort headers.
6555         * buildsym.c: Sort headers.
6556         * buildsym-legacy.c: Sort headers.
6557         * build-id.h: Sort headers.
6558         * build-id.c: Sort headers.
6559         * btrace.c: Sort headers.
6560         * bsd-uthread.c: Sort headers.
6561         * breakpoint.h: Sort headers.
6562         * breakpoint.c: Sort headers.
6563         * break-catch-throw.c: Sort headers.
6564         * break-catch-syscall.c: Sort headers.
6565         * break-catch-sig.c: Sort headers.
6566         * blockframe.c: Sort headers.
6567         * block.c: Sort headers.
6568         * bfin-tdep.c: Sort headers.
6569         * bfin-linux-tdep.c: Sort headers.
6570         * bfd-target.c: Sort headers.
6571         * bcache.c: Sort headers.
6572         * ax-general.c: Sort headers.
6573         * ax-gdb.h: Sort headers.
6574         * ax-gdb.c: Sort headers.
6575         * avr-tdep.c: Sort headers.
6576         * auxv.c: Sort headers.
6577         * auto-load.c: Sort headers.
6578         * arm-wince-tdep.c: Sort headers.
6579         * arm-tdep.c: Sort headers.
6580         * arm-symbian-tdep.c: Sort headers.
6581         * arm-pikeos-tdep.c: Sort headers.
6582         * arm-obsd-tdep.c: Sort headers.
6583         * arm-nbsd-tdep.c: Sort headers.
6584         * arm-nbsd-nat.c: Sort headers.
6585         * arm-linux-tdep.c: Sort headers.
6586         * arm-linux-nat.c: Sort headers.
6587         * arm-fbsd-tdep.c: Sort headers.
6588         * arm-fbsd-nat.c: Sort headers.
6589         * arm-bsd-tdep.c: Sort headers.
6590         * arch-utils.c: Sort headers.
6591         * arc-tdep.c: Sort headers.
6592         * arc-newlib-tdep.c: Sort headers.
6593         * annotate.h: Sort headers.
6594         * annotate.c: Sort headers.
6595         * amd64-windows-tdep.c: Sort headers.
6596         * amd64-windows-nat.c: Sort headers.
6597         * amd64-tdep.c: Sort headers.
6598         * amd64-sol2-tdep.c: Sort headers.
6599         * amd64-obsd-tdep.c: Sort headers.
6600         * amd64-obsd-nat.c: Sort headers.
6601         * amd64-nbsd-tdep.c: Sort headers.
6602         * amd64-nbsd-nat.c: Sort headers.
6603         * amd64-nat.c: Sort headers.
6604         * amd64-linux-tdep.c: Sort headers.
6605         * amd64-linux-nat.c: Sort headers.
6606         * amd64-fbsd-tdep.c: Sort headers.
6607         * amd64-fbsd-nat.c: Sort headers.
6608         * amd64-dicos-tdep.c: Sort headers.
6609         * amd64-darwin-tdep.c: Sort headers.
6610         * amd64-bsd-nat.c: Sort headers.
6611         * alpha-tdep.c: Sort headers.
6612         * alpha-obsd-tdep.c: Sort headers.
6613         * alpha-nbsd-tdep.c: Sort headers.
6614         * alpha-mdebug-tdep.c: Sort headers.
6615         * alpha-linux-tdep.c: Sort headers.
6616         * alpha-linux-nat.c: Sort headers.
6617         * alpha-bsd-tdep.c: Sort headers.
6618         * alpha-bsd-nat.c: Sort headers.
6619         * aix-thread.c: Sort headers.
6620         * agent.c: Sort headers.
6621         * addrmap.c: Sort headers.
6622         * ada-varobj.c: Sort headers.
6623         * ada-valprint.c: Sort headers.
6624         * ada-typeprint.c: Sort headers.
6625         * ada-tasks.c: Sort headers.
6626         * ada-lang.c: Sort headers.
6627         * aarch64-tdep.c: Sort headers.
6628         * aarch64-ravenscar-thread.c: Sort headers.
6629         * aarch64-newlib-tdep.c: Sort headers.
6630         * aarch64-linux-tdep.c: Sort headers.
6631         * aarch64-linux-nat.c: Sort headers.
6632         * aarch64-fbsd-tdep.c: Sort headers.
6633         * aarch64-fbsd-nat.c: Sort headers.
6634         * aarch32-linux-nat.c: Sort headers.
6635
6636 2019-04-04  Tom Tromey  <tom@tromey.com>
6637
6638         * varobj.c (varobj_create): Update.
6639         * rust-exp.y (struct rust_parser) <update_innermost_block,
6640         lookup_symbol>: New methods.
6641         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6642         Rename.
6643         (rust_parser::rust_lookup_type)
6644         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6645         * printcmd.c (display_command, do_one_display): Update.
6646         * parser-defs.h (struct parser_state) <parser_state>: Add
6647         "tracker" parameter.
6648         (block_tracker): New member.
6649         (class innermost_block_tracker) <innermost_block_tracker>: Add
6650         "types" parameter.
6651         <reset>: Remove method.
6652         (innermost_block): Don't declare.
6653         (null_post_parser): Update.
6654         * parse.c (innermost_block): Remove global.
6655         (write_dollar_variable): Update.
6656         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6657         Remove "tracker_types" parameter.
6658         (parse_expression): Add "tracker" parameter.
6659         (parse_expression_for_completion): Update.
6660         (null_post_parser): Add "tracker" parameter.
6661         * p-exp.y: Update rules.
6662         * m2-exp.y: Update rules.
6663         * language.h (struct language_defn) <la_post_parser>: Add
6664         "tracker" parameter.
6665         * go-exp.y: Update rules.
6666         * f-exp.y: Update rules.
6667         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6668         parameter.
6669         * d-exp.y: Update rules.
6670         * c-exp.y: Update rules.
6671         * breakpoint.c (set_breakpoint_condition): Create an
6672         innermost_block_tracker.
6673         (watch_command_1): Likewise.
6674         * ada-lang.c (resolve): Add "tracker" parameter.
6675         (resolve_subexp): Likewise.
6676         * ada-exp.y (write_var_from_sym): Update.
6677
6678 2019-04-04  Tom Tromey  <tom@tromey.com>
6679
6680         * type-stack.h: New file.
6681         * type-stack.c: New file.
6682         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6683         type-stack.h.
6684         (insert_into_type_stack, insert_type, push_type, push_type_int)
6685         (insert_type_address_space, pop_type, pop_type_int)
6686         (pop_typelist, pop_type_stack, append_type_stack)
6687         (push_type_stack, get_type_stack, push_typelist)
6688         (follow_type_instance_flags, follow_types): Don't declare.
6689         * parse.c (type_stack): Remove global.
6690         (parse_exp_in_context): Update.
6691         (insert_into_type_stack, insert_type, push_type, push_type_int)
6692         (insert_type_address_space, pop_type, pop_type_int)
6693         (pop_typelist, pop_type_stack, append_type_stack)
6694         (push_type_stack, get_type_stack, push_typelist)
6695         (follow_type_instance_flags, follow_types): Remove (moved to
6696         type-stack.c).
6697         * f-exp.y (type_stack): New global.
6698         Update rules.
6699         (push_kind_type, f_parse): Update.
6700         * d-exp.y (type_stack): New global.
6701         Update rules.
6702         (d_parse): Update.
6703         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6704         Update rules.
6705         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6706         (HFILES_NO_SRCDIR): Add type-stack.h.
6707
6708 2019-04-04  Tom Tromey  <tom@tromey.com>
6709
6710         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6711         (rust_parser::convert_ast_to_expression, rust_parse)
6712         (rust_lex_test_completion, rust_lex_tests): Update.
6713         * parser-defs.h (struct expr_completion_state): New.
6714         (struct parser_state) <parser_state>: Add completion parameter.
6715         <mark_struct_expression, mark_completion_tag>: New methods.
6716         <parse_completion, m_completion_state>: New members.
6717         (prefixify_expression, null_post_parser): Update.
6718         (mark_struct_expression, mark_completion_tag): Don't declare.
6719         * parse.c (parse_completion, expout_last_struct)
6720         (expout_tag_completion_type, expout_completion_name): Remove
6721         globals.
6722         (parser_state::mark_struct_expression)
6723         (parser_state::mark_completion_tag): Now methods.
6724         (prefixify_expression): Add last_struct parameter.
6725         (prefixify_subexp): Likewise.
6726         (parse_exp_1): Update.
6727         (parse_exp_in_context): Add cstate parameter.  Update.
6728         (parse_expression_for_completion): Create an
6729         expr_completion_state.
6730         (null_post_parser): Add "completion" parameter.
6731         * p-exp.y: Update rules.
6732         (yylex): Update.
6733         * language.h (struct language_defn) <la_post_parser>: Add
6734         "completing" parameter.
6735         * go-exp.y: Update rules.
6736         (lex_one_token): Update.
6737         * expression.h (parse_completion): Don't declare.
6738         * d-exp.y: Update rules.
6739         (lex_one_token): Update rules.
6740         * c-exp.y: Update rules.
6741         (lex_one_token): Update.
6742         * ada-lang.c (resolve): Add "parse_completion" parameter.
6743         (resolve_subexp): Likewise.
6744         (ada_resolve_function): Likewise.
6745
6746 2019-04-04  Tom Tromey  <tom@tromey.com>
6747
6748         * parser-defs.h (struct parser_state) <start_arglist,
6749         end_arglist>: New methods.
6750         <arglist_len, m_funcall_chain>: New members.
6751         (arglist_len, start_arglist, end_arglist): Don't declare.
6752         * parse.c (arglist_len, funcall_chain): Remove global.
6753         (start_arglist, end_arglist): Remove functions.
6754         (parse_exp_in_context): Update.
6755         * p-exp.y: Update rules.
6756         * m2-exp.y: Update rules.
6757         * go-exp.y: Update rules.
6758         * f-exp.y: Update rules.
6759         * d-exp.y: Update rules.
6760         * c-exp.y: Update rules.
6761
6762 2019-04-04  Tom Tromey  <tom@tromey.com>
6763
6764         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6765         lex_operator, push_back>: New methods.
6766         Update all rules.
6767         (rust_parser::lex_hex, lex_escape): Rename and update.
6768         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6769         (rust_parser::lex_operator): Rename and update.
6770         (rust_parser::lex_number, rustyylex, rustyyerror)
6771         (rust_lex_test_init, rust_lex_test_sequence)
6772         (rust_lex_test_push_back, rust_lex_tests): Update.
6773         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6774         parameter.
6775         <lexptr, prev_lexptr>: New members.
6776         (lexptr, prev_lexptr): Don't declare.
6777         * parse.c (lexptr, prev_lexptr): Remove globals.
6778         (parse_exp_in_context): Update.
6779         * p-exp.y (yylex, yyerror): Update.
6780         * m2-exp.y (parse_number, yylex, yyerror): Update.
6781         * go-exp.y (lex_one_token, yyerror): Update.
6782         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6783         * d-exp.y (lex_one_token, yyerror): Update.
6784         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6785         (lex_one_token, yyerror): Update.
6786         * ada-lex.l (YY_INPUT): Update.
6787         (rewind_to_char): Update.
6788         * ada-exp.y (yyerror): Update.
6789
6790 2019-04-04  Tom Tromey  <tom@tromey.com>
6791
6792         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6793         * parser-defs.h (struct parser_state) <parser_state>: Add new
6794         parameter.
6795         <comma_terminates>: New member.
6796         (comma_terminates): Don't declare global.
6797         * parse.c (comma_terminates): Remove global.
6798         (parse_exp_in_context): Update.
6799         * p-exp.y (yylex): Update.
6800         * m2-exp.y (yylex): Update.
6801         * go-exp.y (lex_one_token): Update.
6802         * f-exp.y (yylex): Update.
6803         * d-exp.y (lex_one_token): Update.
6804         * c-exp.y (lex_one_token): Update.
6805         * ada-lex.l: Update.
6806
6807 2019-04-04  Tom Tromey  <tom@tromey.com>
6808
6809         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6810         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6811         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6812         * parser-defs.h (paren_depth): Don't declare.
6813         * parse.c (paren_depth): Remove global.
6814         (parse_exp_in_context): Update.
6815         * p-exp.y (paren_depth): New global.
6816         (pascal_parse): Initialize it.
6817         * m2-exp.y (paren_depth): New global.
6818         (m2_parse): Initialize it.
6819         * go-exp.y (paren_depth): New global.
6820         (go_parse): Initialize it.
6821         * f-exp.y (paren_depth): New global.
6822         (f_parse): Initialize it.
6823         * d-exp.y (paren_depth): New global.
6824         (d_parse): Initialize it.
6825         * c-exp.y (paren_depth): New global.
6826         (c_parse): Initialize it.
6827         * ada-lex.l (paren_depth): New global.
6828         (lexer_init): Initialize it.
6829
6830 2019-04-04  Tom Tromey  <tom@tromey.com>
6831
6832         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6833         (rust_parser::convert_ast_to_type)
6834         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6835         * parser-defs.h (struct parser_state) <parser_state>: Add
6836         parameters.  Initialize new members.
6837         <expression_context_block, expression_context_pc>: New members.
6838         * parse.c (expression_context_block, expression_context_pc):
6839         Remove globals.
6840         (parse_exp_in_context): Update.
6841         * p-exp.y: Update all rules.
6842         (yylex): Update.
6843         * m2-exp.y: Update all rules.
6844         (yylex): Update.
6845         * go-exp.y (yylex): Update.
6846         * f-exp.y (yylex): Update.
6847         * d-exp.y: Update all rules.
6848         (yylex): Update.
6849         * c-exp.y: Update all rules.
6850         (lex_one_token, classify_name, yylex, c_parse): Update.
6851         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6852
6853 2019-04-04  Tom Tromey  <tom@tromey.com>
6854
6855         * gdbarch.h, gdbarch.c: Rebuild.
6856         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6857         * stap-probe.h:
6858         (struct stap_parse_info): Replace "parser_state" with
6859         "expr_builder".
6860         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6861         (parser_state): New class.
6862         * parse.c (expr_builder): Rename.
6863         (expr_builder::release): Rename.
6864         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6865         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6866         (write_exp_elt_longcst, write_exp_elt_floatcst)
6867         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6868         (write_exp_string_vector, write_exp_bitstring)
6869         (write_exp_msymbol, mark_struct_expression)
6870         (write_dollar_variable)
6871         (insert_type_address_space, increase_expout_size): Replace
6872         "parser_state" with "expr_builder".
6873         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6874         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6875         "parser_state" with "expr_builder".
6876
6877 2019-04-04  Tom Tromey  <tom@tromey.com>
6878
6879         * rust-exp.y: Replace "parse_language" with method call.
6880         * p-exp.y:
6881         (yylex): Replace "parse_language" with method call.
6882         * m2-exp.y:
6883         (yylex): Replace "parse_language" with method call.
6884         * go-exp.y (classify_name): Replace "parse_language" with method
6885         call.
6886         * f-exp.y (yylex): Replace "parse_language" with method call.
6887         * d-exp.y (lex_one_token): Replace "parse_language" with method
6888         call.
6889         * c-exp.y:
6890         (lex_one_token, classify_name, yylex): Replace "parse_language"
6891         with method call.
6892         * ada-exp.y (find_primitive_type, type_char)
6893         (type_system_address): Replace "parse_language" with method call.
6894
6895 2019-04-04  Tom Tromey  <tom@tromey.com>
6896
6897         * rust-exp.y: Replace "parse_gdbarch" with method call.
6898         * parse.c (write_dollar_variable, insert_type_address_space):
6899         Replace "parse_gdbarch" with method call.
6900         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6901         call.
6902         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6903         call.
6904         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6905         "parse_gdbarch" with method call.
6906         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6907         with method call.
6908         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6909         "parse_gdbarch" with method call.
6910         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6911         "parse_gdbarch" with method call.
6912         * c-exp.y (parse_type, parse_number, classify_name): Replace
6913         "parse_gdbarch" with method call.
6914         * ada-lex.l: Replace "parse_gdbarch" with method call.
6915         * ada-exp.y (parse_type, find_primitive_type, type_char)
6916         (type_system_address): Replace "parse_gdbarch" with method call.
6917
6918 2019-04-04  Tom Tromey  <tom@tromey.com>
6919
6920         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6921         * stap-probe.c (stap_parse_argument): Update.
6922         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6923         initial_size parameter.
6924         * rust-exp.y (rust_lex_tests): Update.
6925         * parse.c (parser_state): Update.
6926         (parse_exp_in_context): Update.
6927         * parser-defs.h (struct parser_state) <parser_state>: Remove
6928         "initial_size" parameter.
6929
6930 2019-04-04  Tom Tromey  <tom@tromey.com>
6931
6932         * parser-defs.h (increase_expout_size): Don't declare.
6933         * parse.c (increase_expout_size): Now static.
6934
6935 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6936
6937         * gnu-nat.c (gnu_nat_target::wait): Fix
6938         target_waitstatus_to_string call.
6939
6940 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6941
6942         * eval.c (evaluate_subexp_standard): Handle internal functions
6943         during Fortran function call handling.
6944
6945 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6946
6947         * NEWS: Mention new internal functions.
6948         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6949         (read_base_type): Use dwarf2_init_complex_target_type.
6950         * value.c (creal_internal_fn): New function.
6951         (cimag_internal_fn): New function.
6952         (_initialize_values): Register new internal functions.
6953
6954 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6955
6956         * infrun.c (stop_all_threads): If debug_infrun, always
6957         trace the wait status after wait_one, using
6958         target_waitstatus_to_string and target_pid_to_str.
6959         (handle_inferior_event): Replace various trace of
6960         wait status kind by a single trace.
6961         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6962         wait status kind image by target_waitstatus_to_string.
6963         * target/waitstatus.c (target_waitstatus_to_string): Fix
6964         obsolete comment.
6965
6966 2019-04-01  Tom Tromey  <tromey@adacore.com>
6967
6968         PR symtab/23331:
6969         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6970
6971 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6972             Pedro Alves  <palves@redhat.com>
6973
6974         * top.c (quit_force): Call 'finalize_values'.
6975         * value.c (finalize_values): New function.
6976         * value.h (finalize_values): Declare.
6977
6978 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6979
6980         * NEWS: Announce $_gdb_major and $_gdb_minor.
6981
6982         * top.c (init_gdb_version_vars): New function.
6983         (gdb_init): Call init_gdb_version_vars.
6984
6985 2019-03-29  Tom Tromey  <tromey@adacore.com>
6986
6987         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6988         help text.  Remove dead code.
6989
6990 2019-03-29  Keith Seitz  <keiths@redhat.com>
6991
6992         From Siddhesh Poyarekar:
6993         * f-lang.h (f77_get_upperbound): Return LONGEST.
6994         (f77_get_lowerbound): Likewise.
6995         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6996         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6997         print them.
6998         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6999         plongest to format print it.
7000         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7001         (f77_get_upperbound): Likewise.
7002         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7003         LOWER_BOUND to LONGEST.
7004         (f77_create_arrayprint_offset_tbl): Likewise.
7005
7006 2019-03-29  Keith Seitz  <keiths@redhat.com>
7007
7008         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7009         %s/pulongest for TYPE_LENGTH instead of %d in format
7010         strings.
7011         * ada-typerint.c (ada_print_type): Likewise.
7012         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7013         * compile/compile-c-support.c (generate_register_struct): Likewise.
7014         * gdbtypes.c (recursive_dump_type): Likewise.
7015         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7016         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7017         instead of %d in format strings.
7018         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7019         to std::min to ULONGEST.
7020         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7021         instead of %d in format strings.
7022         * tracepoint.c (info_scope_command): Likewise.
7023         * typeprint.c (print_offset_data::update)
7024         (print_offset_data::finish): Likewise.
7025         * xtensa-tdep.c (xtensa_store_return_value)
7026         (xtensa_push_dummy_call): Likewise.
7027
7028 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7029
7030         * windows-nat.c (display_selector): Fixed format specifications
7031         for 64-bit Cygwin.
7032
7033 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7034
7035         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7036
7037 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7038
7039         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7040         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7041         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7042         (nios2_linux_init_abi): Install it.
7043
7044 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7045
7046         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7047
7048 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7049
7050         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7051
7052 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7053             Tom Tromey  <tromey@adacore.com>
7054
7055         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7056
7057 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7058
7059         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7060         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7061         method to compute the bounds of range types. Also print "[evaluated]"
7062         if the bounds' values come from a dynamic evaluation.
7063
7064 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7067         whitespace when pretty printing is on.
7068
7069 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7070
7071         * ppc-linux-nat.c: Add include.
7072
7073 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7074
7075         * NEWS: Mention AArch64 Pointer Authentication.
7076
7077 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7078
7079         * arm-linux-nat.c: Add include.
7080
7081 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7082
7083         * source-cache.c (source_cache::get_source_lines): Re-read
7084         fullname after calling open_source_file.
7085
7086 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7087
7088         * NEWS: Mention TLS support for FreeBSD.
7089
7090 2019-03-25  Tom Tromey  <tromey@adacore.com>
7091
7092         * minsyms.c (BUNCH_SIZE): Update comment.
7093         (~minimal_symbol_reader): Remove old comment.
7094         (compact_minimal_symbols): Update comment.
7095         (minimal_symbol_reader::install): Remove old comment.  Update
7096         other comments.
7097
7098 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7099
7100         * s390-linux-nat.c: Add include.
7101
7102 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7103
7104         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7105         Call linux_get_hwcap.
7106         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7107         Likewise.
7108         (aarch64_linux_get_hwcap): Remove function.
7109         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7110         declaration.
7111         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7112         linux_get_hwcap.
7113         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7114         * linux-tdep.c (linux_get_hwcap): Add function.
7115         (linux_get_hwcap2): Likewise.
7116         * linux-tdep.h (linux_get_hwcap): Add declaration.
7117         (linux_get_hwcap2): Likewise.
7118         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7119         (ppc_linux_get_hwcap2): Likewise.
7120         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7121         linux_get_hwcap.
7122         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7123         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7124         (ppc_linux_nat_target::read_description): Likewise.
7125         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7126         * s390-linux-nat.c: Likewise.
7127         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7128
7129 2019-03-24  Tom Tromey  <tom@tromey.com>
7130
7131         * ada-lang.c (standard_lookup): Simplify initialization.
7132         (ada_lookup_symbol_nonlocal): Simplify return.
7133         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7134         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7135         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7136         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7137         initialization.
7138         * solib.c (solib_global_lookup): Simplify.
7139         * symtab.c (null_block_symbol): Remove.
7140         (symbol_cache_lookup): Simplify returns.
7141         (lookup_language_this): Simplify returns.
7142         (lookup_symbol_aux): Simplify return.
7143         (lookup_local_symbol): Simplify returns.
7144         (lookup_global_symbol_from_objfile): Simplify return.
7145         (lookup_symbol_in_objfile_symtabs)
7146         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7147         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7148         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7149         * cp-namespace.c (cp_lookup_bare_symbol)
7150         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7151         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7152         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7153         (cp_lookup_symbol_via_imports): Simplify initialization.
7154         (find_symbol_in_baseclass): Likewise.
7155         * symtab.h (null_block_symbol): Remove.
7156         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7157         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7158         (d_lookup_symbol_module): Likewise.
7159         (find_symbol_in_baseclass): Simplify initialization.
7160
7161 2019-03-24  Tom Tromey  <tom@tromey.com>
7162
7163         * expression.h: Don't include symtab.h.
7164         (struct block): Forward declare.
7165
7166 2019-03-24  Tom Tromey  <tom@tromey.com>
7167
7168         * c-exp.y (typebase): Remove casts.
7169         * gdbtypes.c (lookup_unsigned_typename, )
7170         (lookup_signed_typename): Remove cast.
7171         * eval.c (parse_to_comma_and_eval): Remove cast.
7172         * parse.c (write_dollar_variable): Remove cast.
7173         * block.h (struct block) <superblock>: Now const.
7174         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7175         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7176         (map_block): Make "block" const.
7177         * symfile.h (struct quick_symbol_functions)
7178         <map_matching_symbols>: Constify block argument to "callback".
7179         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7180         const.
7181         (find_pc_sect_compunit_symtab): Make "b" const.
7182         (find_symbol_at_address): Likewise.
7183         (search_symbols): Likewise.
7184         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7185         (dw2_debug_names_lookup_symbol): Likewise.
7186         (dw2_map_matching_symbols): Update.
7187         * p-valprint.c (pascal_val_print): Remove "block".
7188         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7189         (aux_add_nonlocal_symbols): Make "block" const.
7190         (resolve_subexp): Remove cast.
7191         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7192         const.
7193         (iterate_over_file_blocks): Likewise.
7194         * f-exp.y (%union) <bval>: Remove.
7195         * coffread.c (patch_opaque_types): Make "b" const.
7196         * spu-tdep.c (spu_catch_start): Make "block" const.
7197         * c-valprint.c (print_unpacked_pointer): Remove "block".
7198         * symmisc.c (dump_symtab_1): Make "b" const.
7199         (block_depth): Make "block" const.
7200         * d-exp.y (%union) <bval>: Remove.
7201         * cp-support.h (cp_lookup_rtti_type): Update.
7202         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7203         * psymtab.c (psym_lookup_symbol): Make "block" const.
7204         (maintenance_check_psymtabs): Make "b" const.
7205         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7206         (enumerate_locals, enumerate_args): Update.
7207         * python/py-symtab.c (stpy_global_block): Make "block" const.
7208         (stpy_static_block): Likewise.
7209         * inline-frame.c (block_starting_point_at): Make "new_block"
7210         const.
7211         * block.c (find_block_in_blockvector): Make return type const.
7212         (blockvector_for_pc_sect): Make "b" const.
7213         (find_block_in_blockvector): Make "b" const.
7214
7215 2019-03-23  Tom Tromey  <tom@tromey.com>
7216
7217         * varobj.c (varobj_create): Update.
7218         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7219         * printcmd.c (display_command, do_one_display): Don't reset
7220         innermost_block.
7221         * parser-defs.h (enum innermost_block_tracker_type): Move to
7222         expression.h.
7223         (innermost_block): Update comment.
7224         * parse.c (parse_exp_1): Add tracker_types parameter.
7225         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7226         tracker_types parameter.  Reset innermost_block.
7227         (parse_exp_in_context): Remove.
7228         (parse_expression_for_completion): Update.
7229         * objfiles.c (~objfile): Don't reset expression_context_block or
7230         innermost_block.
7231         * expression.h (enum innermost_block_tracker_type): Move from
7232         parser-defs.h.
7233         (parse_exp_1): Add tracker_types parameter.
7234         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7235         reset innermost_block.
7236
7237 2019-03-23  Tom Tromey  <tom@tromey.com>
7238
7239         * objfiles.h: Include bcache.h.
7240
7241 2019-03-23  Tom Tromey  <tom@tromey.com>
7242
7243         * linespec.c (get_current_search_block): Use
7244         scoped_restore_current_language.
7245         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7246
7247 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7248             Jiong Wang  <jiong.wang@arm.com>
7249
7250         * aarch64-linux-tdep.c
7251         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7252         section.
7253         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7254
7255 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7256             Jiong Wang  <jiong.wang@arm.com>
7257
7258         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7259         instructions.
7260         (aarch64_analyze_prologue_test): Add PACIASP test.
7261         (aarch64_prologue_prev_register): Unmask PC value.
7262
7263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7264             Jiong Wang  <jiong.wang@arm.com>
7265
7266         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7267         (aarch64_dwarf2_prev_register): Unmask PC value.
7268         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7269         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7270         DW_CFA_AARCH64_negate_ra_state.
7271         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7272
7273 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7274             Jiong Wang  <jiong.wang@arm.com>
7275
7276         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7277         registers.
7278         (aarch64_pseudo_register_name): Likewise.
7279         (aarch64_pseudo_register_type): Likewise.
7280         (aarch64_pseudo_register_reggroup_p): Likewise.
7281         (aarch64_gdbarch_init): Add pauth registers.
7282         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7283         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7284         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7285         (struct gdbarch_tdep): Add regnum for ra_state.
7286
7287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7288             Jiong Wang  <jiong.wang@arm.com>
7289
7290         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7291
7292 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7293             Jiong Wang  <jiong.wang@arm.com>
7294
7295         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7296         function.
7297         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7298         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7299         (aarch64_gdbarch_init): Add puth registers.
7300         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7301         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7302         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7303
7304 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7305             Jiong Wang  <jiong.wang@arm.com>
7306
7307         * aarch64-linux-nat.c
7308         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7309         * aarch64-linux-tdep.c
7310         (aarch64_linux_core_read_description): Likewise.
7311         (aarch64_linux_get_hwcap): New function.
7312         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7313         (aarch64_linux_get_hwcap): New declaration.
7314
7315 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7316             Jiong Wang  <jiong.wang@arm.com>
7317
7318         * aarch64-linux-nat.c
7319         (aarch64_linux_nat_target::read_description): Add pauth param.
7320         * aarch64-linux-tdep.c
7321         (aarch64_linux_core_read_description): Likewise.
7322         * aarch64-tdep.c (struct target_desc): Add in pauth.
7323         (aarch64_read_description): Add pauth param.
7324         (aarch64_gdbarch_init): Likewise.
7325         * aarch64-tdep.h (aarch64_read_description): Likewise.
7326         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7327         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7328         * features/Makefile: Add new files.
7329         * features/aarch64-pauth.c: New file.
7330         * features/aarch64-pauth.xml: New file.
7331
7332 2019-03-20  Tom Tromey  <tromey@adacore.com>
7333
7334         * infrun.c (handle_inferior_event): Rename from
7335         handle_inferior_event_1.  Create a scoped_value_mark.
7336         (handle_inferior_event): Remove.
7337
7338 2019-03-19  Tom Tromey  <tromey@adacore.com>
7339
7340         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7341         * infrun.h (print_stop_event): Add "displays" parameter.
7342         * infrun.c (print_stop_event): Add "displays" parameter.
7343
7344 2019-03-19  Pedro Alves  <palves@redhat.com>
7345
7346         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7347         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7348         to -1.  Fix TABs vs spaces.
7349         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7350         * tui/tui-out.h (tui_ui_out) Add intro comments.
7351         <m_line, m_start_of_line>: In-class initialize, and add describing
7352         comment.
7353
7354 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7355
7356         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7357         variable names.
7358         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7359
7360 2019-03-18  Pedro Alves  <palves@redhat.com>
7361             Eli Zaretskii <eliz@gnu.org>
7362
7363         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7364         m_line and m_start_of_line.
7365
7366 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7367
7368         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7369         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7370         it returns a newline.  This fixes a regression in TU mode, whereby
7371         the next line is output on the same screen line as the user input.
7372
7373 2019-03-18  Tom Tromey  <tromey@adacore.com>
7374
7375         * minsyms.c (minimal_symbol_reader::install): Remove call to
7376         obstack_blank.
7377
7378 2019-03-18  Pedro Alves  <palves@redhat.com>
7379
7380         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7381         New globals.
7382         (apply_style): New, factored out from ...
7383         (apply_ansi_escape): ... this.  Handle reverse video mode.
7384         (tui_set_reverse_mode): New function.
7385         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7386         * tui/tui-winsource.c (tui_show_source_line): Use
7387         tui_set_reverse_mode instead of setting A_STANDOUT.
7388         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7389         New setter methods.
7390
7391 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7392
7393         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7394         Handle tabs.
7395
7396 2019-03-18  Tom Tromey  <tromey@adacore.com>
7397
7398         * ada-lang.c (empty_array): Add "high" parameter.
7399         (ada_evaluate_subexp): Update.
7400
7401 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7402
7403         * unittests/string_view-selftests.c: Define
7404         _initialize_string_view_selftests unconditionally.
7405
7406 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7407
7408         PR gdb/24350
7409         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7410
7411 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7412
7413         PR gdb/24351
7414         * windows-nat.c (display_selector): Fix format specifiers.
7415
7416 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7417
7418         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7419         tui_refill_source_window instead of tui_refresh_win, to update the
7420         current execution line.  This fixes redisplay of the current line
7421         when stepping through the code with "next" or "step".
7422
7423 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7424
7425         * source-cache.c (source_cache::get_source_lines): Call
7426         find_source_lines to initialize s->nlines.  This fixes vertical
7427         scrolling of TUI source window when the DOWN arrow is pressed.
7428
7429 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7430
7431         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7432         linux-thread-db.c (_initialize_thread_db): Likewise.
7433
7434 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7435
7436         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7437         wclrtoeol in tui_show_source_line".  This reverts changes made in
7438         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7439
7440 2019-03-15  Tom Tromey  <tom@tromey.com>
7441
7442         * symtab.h (struct minimal_symbol): Derive from
7443         general_symbol_info.
7444         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7445         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7446         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7447         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7448         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7449         (MSYMBOL_SEARCH_NAME): Update.
7450         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7451         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7452         * minsyms.c (minimal_symbol_reader::record_full): Update.
7453
7454 2019-03-15  Tom Tromey  <tom@tromey.com>
7455
7456         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7457
7458 2019-03-15  Tom Tromey  <tom@tromey.com>
7459
7460         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7461         unique_xmalloc_ptr.
7462         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7463         Update.
7464         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7465         (build_minimal_symbol_hash_tables)
7466         (minimal_symbol_reader::install): Update.
7467
7468 2019-03-15  Tom Tromey  <tom@tromey.com>
7469
7470         * symtab.c (create_demangled_names_hash): Update.
7471         (symbol_set_names): Update.
7472         * objfiles.h (struct objfile_per_bfd_storage)
7473         <demangled_names_hash>: Now an htab_up.
7474         * objfiles.c (objfile_per_bfd_storage): Simplify.
7475
7476 2019-03-15  Tom Tromey  <tom@tromey.com>
7477
7478         * objfiles.h (struct objfile_per_bfd_storage): Declare
7479         destructor.
7480         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7481         New.
7482         (get_objfile_bfd_data): Use new.  Don't initialize
7483         language_of_main.
7484         (free_objfile_per_bfd_storage): Remove.
7485         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7486
7487 2019-03-15  Tom Tromey  <tom@tromey.com>
7488
7489         * symfile.c (reread_symbols): Update.
7490         * objfiles.c (objfile::objfile): Update.
7491         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7492         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7493         comment.
7494         (minimal_symbol_reader::install): Update.
7495         (terminate_minimal_symbol_table): Remove.
7496         * jit.c (jit_object_close_impl): Update.
7497
7498 2019-03-15  Tom Tromey  <tom@tromey.com>
7499
7500         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7501         initializations.
7502
7503 2019-03-15  Tom Tromey  <tom@tromey.com>
7504
7505         * objfiles.h (struct objfile_per_bfd_storage)
7506         <demangled_hash_languages>: Now a bitset.
7507         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7508         (lookup_minimal_symbol): Update.
7509
7510 2019-03-15  Tom Tromey  <tom@tromey.com>
7511
7512         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7513         Don't return the symbol.
7514         * coffread.c (record_minimal_symbol): Use record_full.
7515
7516 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7517
7518         The MS-Windows port of ncurses fails to switch to a color pair if
7519         one or both of the colors are the implicit default colors.  This
7520         change records the default colors when TUI is initialized, and
7521         then specifies them explicitly when a color pair uses the default
7522         colors.  This allows color styling in TUI mode on MS-Windows.
7523
7524         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7525         ncurses_norm_attr.
7526         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7527         colors in ncurses_norm_attr.
7528         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7529         "none", replace it with the default color recorded in
7530         ncurses_norm_attr.
7531
7532 2019-03-14  Tom Tromey  <tromey@adacore.com>
7533
7534         * source-cache.h (class source_cache) <get_source_lines>: Return
7535         std::string.
7536         * source-cache.c (source_cache::extract_lines): Handle case where
7537         first_pos==npos.  Return std::string.
7538         (source_cache::get_source_lines): Update.
7539
7540 2019-03-14  Tom Tromey  <tromey@adacore.com>
7541
7542         * NEWS: Add item for "style sources" commands.
7543         * source-cache.c (source_cache::get_source_lines): Check
7544         source_styling.
7545         * cli/cli-style.c (source_styling): New global.
7546         (_initialize_cli_style): Add "style sources" commands.
7547         (show_style_sources): New function.
7548         * cli/cli-style.h (source_styling): Declare.
7549
7550 2019-03-14  Pedro Alves  <palves@redhat.com>
7551             Tom Tromey  <tromey@adacore.com>
7552
7553         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7554         * tui/tui-winsource.c (tui_refill_source_window): New function,
7555         from...
7556         (tui_horizontal_source_scroll): ... here.  Move some logic.
7557         * cli/cli-style.c (set_style_enabled): Notify new observable.
7558         * tui/tui-hooks.c (tui_redisplay_source): New function.
7559         (tui_attach_detach_observers): Attach or detach
7560         tui_redisplay_source.
7561         * observable.h (source_styling_changed): New observable.
7562         * observable.c: Define source_styling_changed observable.
7563
7564 2019-03-13  Tom Tromey  <tromey@adacore.com>
7565
7566         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7567         (i386_gnu_nat_target::store_registers): Update.
7568         * target-debug.h (target_debug_print_std_string): New macro.
7569         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7570         * windows-tdep.c (display_one_tib): Update.
7571         * tui/tui-stack.c (tui_make_status_line): Update.
7572         * top.c (print_inferior_quit_action): Update.
7573         * thread.c (thr_try_catch_cmd): Update.
7574         (add_thread_with_info): Update.
7575         (thread_target_id_str): Update.
7576         (thr_try_catch_cmd): Update.
7577         (thread_command): Update.
7578         (thread_find_command): Update.
7579         * record-btrace.c (record_btrace_target::info_record)
7580         (record_btrace_resume_thread, record_btrace_target::resume)
7581         (record_btrace_cancel_resume, record_btrace_step_thread)
7582         (record_btrace_target::wait, record_btrace_target::wait)
7583         (record_btrace_target::wait, record_btrace_target::stop): Update.
7584         * progspace.c (print_program_space): Update.
7585         * process-stratum-target.c
7586         (process_stratum_target::thread_address_space): Update.
7587         * linux-fork.c (linux_fork_mourn_inferior)
7588         (detach_checkpoint_command, info_checkpoints_command)
7589         (linux_fork_context): Update.
7590         (linux_fork_detach): Update.
7591         (class scoped_switch_fork_info): Update.
7592         (delete_checkpoint_command): Update.
7593         * infrun.c (follow_fork_inferior): Update.
7594         (follow_fork_inferior): Update.
7595         (proceed_after_vfork_done): Update.
7596         (handle_vfork_child_exec_or_exit): Update.
7597         (follow_exec): Update.
7598         (displaced_step_prepare_throw): Update.
7599         (displaced_step_restore): Update.
7600         (start_step_over): Update.
7601         (resume_1): Update.
7602         (clear_proceed_status_thread): Update.
7603         (proceed): Update.
7604         (print_target_wait_results): Update.
7605         (do_target_wait): Update.
7606         (context_switch): Update.
7607         (stop_all_threads): Update.
7608         (restart_threads): Update.
7609         (finish_step_over): Update.
7610         (handle_signal_stop): Update.
7611         (switch_back_to_stepped_thread): Update.
7612         (keep_going_pass_signal): Update.
7613         (print_exited_reason): Update.
7614         (normal_stop): Update.
7615         * inferior.c (inferior_pid_to_str): Change return type.
7616         (print_selected_inferior): Update.
7617         (add_inferior): Update.
7618         (detach_inferior): Update.
7619         * dummy-frame.c (fprint_dummy_frames): Update.
7620         * dcache.c (dcache_info_1): Update.
7621         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7622         (btrace_fetch, btrace_clear): Update.
7623         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7624         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7625         type.
7626         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7627         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7628         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7629         * gdbarch.c, gdbarch.h: Rebuild.
7630         * gdbarch.sh (core_pid_to_str): Change return type.
7631         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7632         return type.
7633         (windows_nat_target::pid_to_str): Change return type.
7634         (windows_delete_thread): Update.
7635         (windows_nat_target::attach): Update.
7636         (windows_nat_target::files_info): Update.
7637         * target-delegates.c: Rebuild.
7638         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7639         return type.
7640         (sol_thread_target::pid_to_str): Change return type.
7641         * remote.c (class remote_target) <pid_to_str>: Change return
7642         type.
7643         (remote_target::pid_to_str): Change return type.
7644         (extended_remote_target::attach, remote_target::remote_stop_ns)
7645         (remote_target::remote_notif_remove_queued_reply)
7646         (remote_target::push_stop_reply, remote_target::disable_btrace):
7647         Update.
7648         (extended_remote_target::attach): Update.
7649         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7650         type.
7651         (gdbsim_target::pid_to_str): Change return type.
7652         * ravenscar-thread.c (struct ravenscar_thread_target)
7653         <pid_to_str>: Change return type.
7654         (ravenscar_thread_target::pid_to_str): Change return type.
7655         * procfs.c (class procfs_target) <pid_to_str>: Change return
7656         type.
7657         (procfs_target::pid_to_str): Change return type.
7658         (procfs_target::attach): Update.
7659         (procfs_target::detach): Update.
7660         (procfs_target::fetch_registers): Update.
7661         (procfs_target::store_registers): Update.
7662         (procfs_target::wait): Update.
7663         (procfs_target::files_info): Update.
7664         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7665         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7666         return type.
7667         (nto_procfs_target::pid_to_str): Change return type.
7668         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7669         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7670         return type.
7671         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7672         (exit_lwp): Update.
7673         (attach_proc_task_lwp_callback, get_detach_signal)
7674         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7675         (linux_nat_target::resume, wait_lwp, stop_callback)
7676         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7677         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7678         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7679         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7680         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7681         type.
7682         (inf_ptrace_target::attach): Update.
7683         (inf_ptrace_target::files_info): Update.
7684         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7685         type.
7686         (go32_nat_target::pid_to_str): Change return type.
7687         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7688         (gnu_nat_target::wait): Update.
7689         (gnu_nat_target::wait): Update.
7690         (gnu_nat_target::resume): Update.
7691         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7692         (fbsd_nat_target::wait): Update.
7693         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7694         type.
7695         (darwin_nat_target::attach): Update.
7696         * corelow.c (class core_target) <pid_to_str>: Change return type.
7697         (core_target::pid_to_str): Change return type.
7698         * target.c (normal_pid_to_str): Change return type.
7699         (default_pid_to_str): Likewise.
7700         (target_pid_to_str): Change return type.
7701         (target_translate_tls_address): Update.
7702         (target_announce_detach): Update.
7703         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7704         return type.
7705         (bsd_uthread_target::pid_to_str): Change return type.
7706         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7707         type.
7708         (bsd_kvm_target::pid_to_str): Change return type.
7709         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7710         return type.
7711         (aix_thread_target::pid_to_str): Change return type.
7712         * target.h (struct target_ops) <pid_to_str>: Change return type.
7713         (target_pid_to_str, normal_pid_to_str): Likewise.
7714         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7715         type.
7716         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7717         type.
7718         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7719         return type.
7720         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7721         type.
7722         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7723         type.
7724         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7725         return type.
7726
7727 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7728
7729         * NEWS: Mention that the new default MI version is 3.  Mention
7730         changes to the output of commands and events that deal with
7731         multi-location breakpoints.
7732         * breakpoint.c: Include "mi/mi-out.h".
7733         (print_one_breakpoint): Change output syntax if using MI version
7734         >= 3.
7735         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7736         New.
7737         (mi_multi_location_breakpoint_output_fixed): New.
7738         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7739         (mi_cmd_fix_multi_location_breakpoint_output): New.
7740         (mi_multi_location_breakpoint_output_fixed): New.
7741         * mi/mi-cmds.c (mi_cmds): Register command
7742         -fix-multi-location-breakpoint-output.
7743         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7744         interpreter "mi".
7745
7746 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7747
7748         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7749         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7750         instantiate mi_ui_out based on interpreter name.
7751         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7752         * mi/mi-main.c (mi_load_progress): Likewise.
7753
7754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7755
7756         * NEWS: Combine separate "New targets" sections for 8.3.
7757
7758 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7759
7760         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7761         (ppcfbsd_init_abi): Install gdbarch
7762         "fetch_tls_load_module_address" and "get_thread_local_address"
7763         methods.
7764
7765 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7766
7767         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7768         (riscv_fbsd_init_abi): Install gdbarch
7769         "fetch_tls_load_module_address" and "get_thread_local_address"
7770         methods.
7771
7772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7773
7774         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7775         (i386fbsd_init_abi): Install gdbarch
7776         "fetch_tls_load_module_address" and "get_thread_local_address"
7777         methods.
7778
7779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7780
7781         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7782         (amd64fbsd_init_abi): Install gdbarch
7783         "fetch_tls_load_module_address" and "get_thread_local_address"
7784         methods.
7785
7786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7787
7788         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7789         (struct fbsd_pspace_data): New type.
7790         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7791         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7792         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7793         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7794         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7795
7796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7797
7798         * gdbtypes.c (lookup_struct_elt): New function.
7799         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7800         * gdbtypes.h (struct struct_elt): New type.
7801         (lookup_struct_elt): New prototype.
7802
7803 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7804
7805         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7806         remove disabled code block.
7807
7808 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7809
7810         * gdbarch.sh (get_thread_local_address): New method.
7811         * gdbarch.h, gdbarch.c: Regenerate.
7812         * target.c (target_translate_tls_address): Use
7813         gdbarch_get_thread_local_address if present instead of
7814         target::get_thread_local_address.
7815
7816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7817
7818         * target.h (target::get_thread_local_address): Update comment.
7819
7820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7821
7822         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7823         objfile->separate_debug_objfile_backlink if not NULL.
7824
7825 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7826
7827         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7828         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7829         (amd64bsd_store_inferior_registers): Likewise.
7830         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7831         Enable segment base registers.
7832         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7833         PT_GETFSBASE and PT_GETGSBASE.
7834         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7835         PT_SETGSBASE.
7836         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7837         segment base registers.
7838         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7839
7840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7841
7842         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7843         Update calls to i386_target_description to add 'segments'
7844         parameter.
7845         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7846         add segment base registers.
7847         * arch/i386.c (i386_create_target_description): Add 'segments'
7848         parameter to enable segment base registers.
7849         * arch/i386.h (i386_create_target_description): Likewise.
7850         * features/i386/32bit-segments.xml: New file.
7851         * features/i386/32bit-segments.c: Generate.
7852         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7853         call to i386_target_description to add 'segments' parameter.
7854         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7855         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7856         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7857         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7858         if feature is present.
7859         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7860         Add 'segments' parameter to call to i386_target_description.
7861         (i386_target_description): Add 'segments' parameter to enable
7862         segment base registers.
7863         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7864         to call to i386_target_description.
7865         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7866         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7867         Define I386_NUM_REGS.
7868         (i386_target_description): Add 'segments' parameter to enable
7869         segment base registers.
7870
7871 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7872
7873         PR/24325
7874         * source-cache.c: #undef open and close, to avoid unresolved
7875         externals during linking.
7876
7877 2019-03-12  Tom Tromey  <tromey@adacore.com>
7878
7879         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7880         const.  Add initializers.
7881         (_initialize_remote): Don't initialize ptid globals.
7882
7883 2019-03-12  Pedro Alves  <palves@redhat.com>
7884
7885         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7886
7887 2019-03-12  Pedro Alves  <palves@redhat.com>
7888
7889         * cp-name-parser.y (main): Remove unused 'len' variable.
7890
7891 2019-03-12  Tom Tromey  <tromey@adacore.com>
7892
7893         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7894         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7895
7896 2019-03-12  Tom Tromey  <tromey@adacore.com>
7897
7898         * linux-nat.c (iterate_over_lwps): Update.
7899         (stop_callback): Remove parameter.
7900         (stop_wait_callback, detach_callback, resume_set_callback)
7901         (select_singlestep_lwp_callback, set_ignore_sigint)
7902         (status_callback, resumed_callback, resume_clear_callback)
7903         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7904         data parameter.
7905         (linux_nat_target::detach, linux_nat_target::resume)
7906         (linux_stop_and_wait_all_lwps, select_event_lwp)
7907         (linux_nat_filter_event, linux_nat_wait_1)
7908         (linux_nat_target::kill, linux_nat_target::stop)
7909         (linux_nat_target::stop): Update.
7910         (linux_nat_resume_callback): Change type.
7911         (resume_stopped_resumed_lwps, count_events_callback)
7912         (select_event_lwp_callback): Likewise.
7913         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7914         * arm-linux-nat.c (struct update_registers_data): Remove.
7915         (update_registers_callback): Change type.
7916         (arm_linux_insert_hw_breakpoint1): Update.
7917         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7918         parameter.
7919         (x86_linux_dr_set_addr): Update.
7920         (x86_linux_dr_set_control): Update.
7921         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7922         (iterate_over_lwps): Use gdb::function_view.
7923         * nat/aarch64-linux-hw-point.c (struct
7924         aarch64_dr_update_callback_param): Remove.
7925         (debug_reg_change_callback): Change type.
7926         (aarch64_notify_debug_reg_change): Update.
7927         * s390-linux-nat.c (s390_refresh_per_info): Update.
7928
7929 2019-03-11  Tom Tromey  <tromey@adacore.com>
7930
7931         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7932         redundant assignment to "this_cu".
7933
7934 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7935
7936         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7937
7938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7939
7940         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7941         from...
7942         (rank_one_type): ... this.
7943
7944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7945
7946         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7947         from...
7948         (rank_one_type): ... this.
7949
7950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7951
7952         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7953         from...
7954         (rank_one_type): ... this.
7955
7956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7957
7958         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7959         from...
7960         (rank_one_type): ... this.
7961
7962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7963
7964         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7965         from...
7966         (rank_one_type): ... this.
7967
7968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7969
7970         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7971         from...
7972         (rank_one_type): ... this.
7973
7974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7975
7976         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7977         from...
7978         (rank_one_type): ... this.
7979
7980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7981
7982         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7983         from...
7984         (rank_one_type): ... this.
7985
7986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7987
7988         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7989         from...
7990         (rank_one_type): ... this.
7991
7992 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7993
7994         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7995         from...
7996         (rank_one_type): ... this.
7997
7998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7999
8000         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8001         from...
8002         (rank_one_type): ... this.
8003
8004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8005
8006         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8007         from...
8008         (rank_one_type): ... this.
8009
8010 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8011
8012         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8013         inferior-events' shows the example events.
8014
8015 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8016
8017         Support styling on native MS-Windows console
8018
8019         PR/24315
8020         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8021         on MS-Windows if $TERM is not defined.
8022
8023         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8024
8025         * posix-hdep.c (gdb_console_fputs):
8026         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8027         functions.
8028         * ui-file.h (gdb_console_fputs): Add prototype.
8029
8030         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8031         back to fputs only if the former returns zero.
8032
8033 2019-03-07  Tom Tromey  <tom@tromey.com>
8034
8035         * symmisc.c (print_symbol_bcache_statistics): Update.
8036         (print_objfile_statistics): Update.
8037         * symfile.c (allocate_symtab): Update.
8038         * stabsread.c: Don't include bcache.h.
8039         * psymtab.h (struct psymbol_bcache): Don't declare.
8040         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8041         (psymbol_bcache_init, psymbol_bcache_free)
8042         (psymbol_bcache_get_bcache): Don't declare.
8043         * psymtab.c (struct psymbol_bcache): Remove.
8044         (psymtab_storage::psymtab_storage): Update.
8045         (psymtab_storage::~psymtab_storage): Update.
8046         (psymbol_bcache_init, psymbol_bcache_free)
8047         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8048         (add_psymbol_to_bcache): Update.
8049         (allocate_psymtab): Update.
8050         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8051         macro_cache>: No longer pointers.
8052         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8053         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8054         * macrotab.c (macro_bcache): Update.
8055         * macroexp.c: Don't include bcache.h.
8056         * gdbtypes.c (check_types_worklist): Update.
8057         (types_deeply_equal): Remove TRY/CATCH.  Update.
8058         * elfread.c (elf_symtab_read): Update.
8059         * dwarf2read.c: Don't include bcache.h.
8060         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8061         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8062         (print_bcache_statistics, bcache_memory_used): Don't declare.
8063         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8064         methods.  Rename all data members.
8065         * bcache.c (struct bcache): Move to bcache.h.
8066         (bcache::expand_hash_table): Rename from expand_hash_table.
8067         (bcache): Remove.
8068         (bcache::insert): Rename from bcache_full.
8069         (bcache::compare): Rename from bcache_compare.
8070         (bcache_xmalloc): Remove.
8071         (bcache::~bcache): Rename from bcache_xfree.
8072         (bcache::print_statistics): Rename from print_bcache_statistics.
8073         (bcache::memory_used): Rename from bcache_memory_used.
8074
8075 2019-03-07  Pedro Alves  <palves@redhat.com>
8076
8077         * infrun.c (normal_stop): Also check for
8078         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8079
8080 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8081
8082         * f-lang.c (value_from_host_double): Moved to...
8083         * value.c (value_from_host_double): ...here.
8084         * value.h (value_from_host_double): Declare.
8085         * guile/scm-math.c (vlscm_convert_typed_number): Use
8086         value_from_host_double.
8087         (vlscm_convert_number): Likewise.
8088         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8089         * python/py-value.c (convert_value_from_python): Likewise.
8090
8091 2019-03-06  Tom Tromey  <tom@tromey.com>
8092
8093         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8094
8095 2019-03-06  Tom Tromey  <tom@tromey.com>
8096
8097         * utils.h (free_current_contents): Don't declare.
8098         * utils.c (free_current_contents): Remove.
8099
8100 2019-03-06  Tom Tromey  <tom@tromey.com>
8101
8102         * top.c (quit_force): Update.
8103         * main.c (captured_command_loop): Update.
8104         * common/new-op.c (operator new): Update.
8105         * common/common-exceptions.c (struct catcher)
8106         <save_cleanup_chain>: Remove member.
8107         (exceptions_state_mc_init): Update.
8108         (exception_try_scope_entry): Return nullptr.
8109         (exception_try_scope_exit, exception_rethrow)
8110         (throw_exception_sjlj, throw_exception_cxx): Update.
8111         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8112         (all_cleanups, do_cleanups, discard_cleanups)
8113         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8114         (restore_cleanups, restore_final_cleanups): Don't declare.
8115         (do_final_cleanups): Remove parameter.
8116         * common/cleanups.c (cleanup_chain, make_cleanup)
8117         (make_cleanup_dtor, all_cleanups, do_cleanups)
8118         (discard_my_cleanups, discard_cleanups)
8119         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8120         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8121         (null_cleanup): Remove.
8122         (do_final_cleanups): Remove parameter.
8123
8124 2019-03-06  Tom Tromey  <tom@tromey.com>
8125
8126         * remote.c (remote_target::remote_parse_stop_reply): Use
8127         unique_xmalloc_ptr.
8128
8129 2019-03-06  Tom Tromey  <tom@tromey.com>
8130
8131         * stabsread.c (struct stabs_field_info): Rename from field_info.
8132         <list, fnlist>: Add initializers.
8133         <obstack>: New member.
8134         (read_member_functions, read_struct_fields, read_baseclasses):
8135         Allocate on obstack.  Don't use cleanups.
8136         (read_one_struct_field, read_member_functions, read_struct_fields)
8137         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8138         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8139         (read_struct_type): Update.
8140
8141 2019-03-06  Tom Tromey  <tom@tromey.com>
8142
8143         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8144         * common/filestuff.h (make_cleanup_close): Don't declare.
8145         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8146         Remove.
8147
8148 2019-03-06  Tom Tromey  <tom@tromey.com>
8149
8150         * solib-aix.c: Use make_scope_exit.
8151
8152 2019-03-06  Tom Tromey  <tom@tromey.com>
8153
8154         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8155         Use make_scope_exit.
8156
8157 2019-03-06  Tom Tromey  <tom@tromey.com>
8158
8159         * solib-svr4.c (disable_probes_interface): Remove parameter.
8160         (svr4_handle_solib_event): Use make_scope_exit.
8161
8162 2019-03-06  Tom Tromey  <tom@tromey.com>
8163
8164         * remote.c (struct stop_reply_deleter): Remove.
8165         (stop_reply_up): Update.
8166         (struct stop_reply): Derive from notif_event.  Don't typedef.
8167         <regcache>: Now a std::vector.
8168         (stop_reply_xfree): Remove.
8169         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8170         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8171         (remote_target::discard_pending_stop_replies): Use delete.
8172         (remote_target::remote_parse_stop_reply): Update.
8173         (remote_target::process_stop_reply): Update.
8174         * remote-notif.h (struct notif_event): Add virtual destructor.
8175         Remove "dtr" member.
8176         (struct notif_client) <alloc_event>: Return a unique_ptr.
8177         (notif_event_xfree): Don't declare.
8178         (notif_event_up): New typedef.
8179         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8180         (notif_event_xfree, do_notif_event_xfree): Remove.
8181         (remote_notif_state_xfree): Update.
8182
8183 2019-03-06  Tom Tromey  <tom@tromey.com>
8184
8185         * infrun.c (displaced_step_clear_cleanup): Now a
8186         forward_scope_exit type.
8187         (displaced_step_prepare_throw): Update.
8188         (displaced_step_fixup): Update.
8189
8190 2019-03-06  Tom Tromey  <tom@tromey.com>
8191
8192         * inferior.h (class inferior): Update comment.
8193         * gdbthread.h (class thread_info): Update comment.
8194
8195 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8196             Tom Tromey  <tom@tromey.com>
8197
8198         * stabsread.h (struct stab_section_list): Remove.
8199         (coffstab_build_psymtabs): Update.
8200         * dbxread.c (symbuf_sections): Now a std::vector.
8201         (sect_idx): New global.
8202         (fill_symbuf): Update.
8203         (coffstab_build_psymtabs): Change type of stabsects parameter.
8204         Update.
8205         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8206         std::vector.
8207         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8208         (coff_locate_sections): Update.
8209         (coff_symfile_read): Remove cleanups.  Update.
8210         (init_stringtab): Add storage parameter.
8211         (free_stringtab, free_stringtab_cleanup): Remove.
8212         (init_lineno): Add storage parameter.
8213         (free_linetab, free_linetab_cleanup): Remove.
8214
8215 2019-03-06  Pedro Alves  <palves@redhat.com>
8216
8217         * linux-fork.c (fork_info::clobber_regs): Delete.
8218         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8219         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8220         comment.  Adjust.
8221         (scoped_switch_fork_info::scoped_switch_fork_info)
8222         (checkpoint_command, linux_fork_context): Adjust
8223         fork_save_infrun_state calls.
8224
8225 2019-03-06  Pedro Alves  <palves@redhat.com>
8226
8227         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8228         (inf_has_multiple_threads): Return 'bool' and rewrite using
8229         inferior_info::threads().
8230
8231 2019-03-06  Pedro Alves  <palves@redhat.com>
8232
8233         * linux-fork.c: Include <list>.
8234         (fork_list): Now a std::list instance.
8235         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8236         (forks_exist_p, find_last_fork): Adjust.
8237         (new_fork): Delete.
8238         (one_fork_p): New.
8239         (add_fork): Adjust.
8240         (free_fork): Delete, folded into fork_info::~fork_info().
8241         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8242         Adjust.
8243         (init_fork_list): Delete.
8244         (linux_fork_killall, linux_fork_mourn_inferior)
8245         (linux_fork_detach, info_checkpoints_command): Adjust.
8246         (_initialize_linux_fork): No longer call init_fork_list.
8247
8248 2019-03-06  Pedro Alves  <palves@redhat.com>
8249
8250         * linux-fork.c (new_fork): New, split out of ...
8251         (add_fork): ... this.  Return void.  Move "first fork" special
8252         case from here, to ...
8253         (checkpoint_command): ... here.
8254         * linux-linux.h (add_fork): Return void.
8255
8256 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8257
8258         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8259
8260 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8261             Chris January  <chris.january@arm.com>
8262             David Lecomber  <david.lecomber@arm.com>
8263
8264         * f-exp.y: New token, UNOP_INTRINSIC.
8265         (exp): New pattern using UNOP_INTRINSIC token.
8266         (f77_keywords): Add 'abs' keyword.
8267         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8268         (value_from_host_double): New function.
8269         (evaluate_subexp_f): Support UNOP_ABS.
8270
8271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8272
8273         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8274         types.
8275
8276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8277
8278         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8279         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8280         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8281
8282 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8283
8284         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8285
8286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8287             Chris January  <chris.january@arm.com>
8288
8289         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8290         * f-exp.y: Define 'KIND' token.
8291         (exp): New pattern for KIND expressions.
8292         (ptype): Handle types with a kind extension.
8293         (direct_abs_decl): Extend to spot kind extensions.
8294         (f77_keywords): Add 'kind' to the list.
8295         (push_kind_type): New function.
8296         (convert_to_kind_type): New function.
8297         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8298         * parse.c (operator_length_standard): Likewise.
8299         * parser-defs.h (enum type_pieces): Add tp_kind.
8300         * std-operator.def: Add UNOP_KIND.
8301
8302 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8303
8304         * f-exp.y (f_parse): Set yydebug.
8305
8306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * f-lang.c (evaluate_subexp_f): New function.
8309         (exp_descriptor_f): New global.
8310         (f_language_defn): Use exp_descriptor_f instead of
8311         exp_descriptor_standard.
8312
8313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8314
8315         * f-exp.y (struct token): Add comments.
8316         (dot_ops): Remove uppercase versions and the end marker.
8317         (f77_keywords): Likewise.
8318         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8319         entries in the dot_ops array are case insensitive, and use
8320         strncasecmp to compare strings.  Also some whitespace cleanup in
8321         this area.  Similar for the f77_keywords array, except entries in
8322         this list might be case sensitive.
8323
8324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8325
8326         * f-exp.y (struct f77_boolean_val): Add comments.
8327         (boolean_values): Remove uppercase versions, and end marker.
8328         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8329         and use strncasecmp to achieve case insensitivity.  Additionally,
8330         perform whitespace cleanup around this code.
8331
8332 2019-03-06  Tom Tromey  <tromey@adacore.com>
8333
8334         * remote-sim.c (gdbsim_target_open): Use result of
8335         gdb_argv::release.
8336
8337 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8338         Dirk Schubert  <dirk.schubert@arm.com>
8339         Chris January  <chris.january@arm.com>
8340
8341         * eval.c (evaluate_subexp_standard): Call Fortran argument
8342         wrapping logic.
8343         * f-lang.c (struct value): A value which can be passed into a
8344         Fortran function call.
8345         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8346         where appropriate.
8347         (struct type): Value ready for a Fortran function call.
8348         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8349         is needed.
8350         * f-lang.h (fortran_argument_convert): Declaration.
8351         (fortran_preserve_arg_pointer): Declaration.
8352         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8353
8354 2019-03-05  Tom Tromey  <tromey@adacore.com>
8355
8356         * python/py-prettyprint.c (print_string_repr): Remove #if.
8357         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8358
8359 2019-03-05  Tom Tromey  <tromey@adacore.com>
8360
8361         * target.c (the_dummy_target): Move later.  Change type to
8362         "dummy_target".
8363         (initialize_targets): Don't initialize the_dummy_target.
8364
8365 2019-03-05  Tom Tromey  <tromey@adacore.com>
8366
8367         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8368         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8369
8370 2019-03-05  Tom Tromey  <tromey@adacore.com>
8371
8372         * windows-nat.c (windows_nat_target::attach)
8373         (windows_nat_target::detach): Don't call gdb_flush.
8374         * valprint.c (generic_val_print, val_print, val_print_string):
8375         Don't call gdb_flush.
8376         * utils.c (defaulted_query): Don't call gdb_flush.
8377         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8378         * target.c (target_announce_detach): Don't call gdb_flush.
8379         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8380         * remote.c (extended_remote_target::attach): Don't call
8381         gdb_flush.
8382         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8383         * printcmd.c (do_examine): Don't call gdb_flush.
8384         (info_display_command): Don't call gdb_flush.
8385         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8386         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8387         * memattr.c (info_mem_command): Don't call gdb_flush.
8388         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8389         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8390         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8391         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8392         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8393         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8394         (gnu_nat_target::detach): Don't call gdb_flush.
8395         * f-valprint.c (f_val_print): Don't call gdb_flush.
8396         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8397         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8398         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8399         gdb_flush.
8400         * c-valprint.c (c_val_print): Don't call gdb_flush.
8401         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8402
8403 2019-03-05  Tom Tromey  <tromey@adacore.com>
8404
8405         * varobj.c (update_dynamic_varobj_children): Update.
8406         (install_default_visualizer): Use reset, not release.
8407         * value.c (set_internalvar): Update.
8408         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8409         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8410         ATTRIBUTE_UNUSED_RESULT.
8411
8412 2019-03-05  Tom Tromey  <tromey@adacore.com>
8413
8414         * remote.c (class scoped_remote_fd) <release>: Add
8415         ATTRIBUTE_UNUSED_RESULT.
8416
8417 2019-03-05  Tom Tromey  <tromey@adacore.com>
8418
8419         * macroexp.c (struct macro_buffer) <release>: Add
8420         ATTRIBUTE_UNUSED_RESULT.
8421
8422 2019-03-05  Tom Tromey  <tromey@adacore.com>
8423
8424         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8425         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8426         ATTRIBUTE_UNUSED_RESULT.
8427
8428 2019-03-05  Tom Tromey  <tromey@adacore.com>
8429
8430         * common/scoped_fd.h (class scoped_fd) <release>: Add
8431         ATTRIBUTE_UNUSED_RESULT.
8432
8433 2019-03-05  Tom Tromey  <tromey@adacore.com>
8434
8435         * parser-defs.h (struct parser_state) <release>: Add
8436         ATTRIBUTE_UNUSED_RESULT.
8437
8438 2019-03-05  Tom Tromey  <tromey@adacore.com>
8439
8440         * utils.h (class gdb_argv) <release>: Add
8441         ATTRIBUTE_UNUSED_RESULT.
8442         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8443
8444 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8445
8446         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8447         for-loop range, to avoid compiler warnings.
8448
8449         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8450         avoid compiler warnings about unused variables.
8451
8452         * NEWS: Mention end of support for native debugging on MS-Windows
8453         before XP.
8454
8455         PR gdb/24292
8456         * common/netstuff.c:
8457         * gdbserver/gdbreplay.c
8458         * gdbserver/remote-utils.c:
8459         * ser-tcp.c:
8460         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8461         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8462         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8463         'getaddrinfo' and 'freeaddrinfo' were not available before
8464         Windows XP, and mingw.org's MinGW headers by default define
8465         _WIN32_WINNT to 0x500.
8466
8467 2019-03-01  Gary Benson <gbenson@redhat.com>
8468
8469         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8470
8471 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8472             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8473
8474         PR gdb/8527
8475         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8476         set_sigint_trap, clear_sigint_trap.
8477
8478 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8479
8480         * target.c (target_detach): Clear the regcache and the
8481         frame cache.
8482
8483 2019-02-27  Pedro Alves  <palves@redhat.com>
8484
8485         * utils.c (set_screen_size): When we cap the height/width sizes,
8486         tweak the corresponding command variable to show "unlimited":
8487
8488 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8489             Pedro Alves  <palves@redhat.com>
8490
8491         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8492         before calling rl_set_screen_size.
8493
8494 2019-02-27  Tom Tromey  <tromey@adacore.com>
8495
8496         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8497         define.
8498         * python/py-value.c: Remove Python 2.4 workaround.
8499         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8500         workaround.
8501         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8502         Python 2.4 workaround.
8503         * python/python-internal.h: Remove Python 2.4 comment.
8504         (Py_ssize_t): Don't define.
8505         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8506         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8507         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8508         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8509         * python/python.c (do_start_initialization): Remove Python 2.4
8510         workaround.
8511         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8512         (print_children): Remove Python 2.4 workaround.
8513         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8514         workaround.
8515         (CHARBUFFERPROC_NAME): Remove.
8516         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8517         Python 2.4 workaround.
8518
8519 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8520
8521         * NEWS: Note minimum Python version.
8522
8523 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8524
8525         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8526         code from these functions.  Remove corresponding ifdefs.  Use
8527         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8528         Remove gotos and target of gotos.
8529         (infpy_search_memory): Likewise.
8530
8531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8532
8533         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8534         (hppa_gdbarch_init): Don't register deleted functions with
8535         gdbarch.
8536
8537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8538
8539         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8540         (h8300_unwind_sp): Delete.
8541         (h8300_dummy_id): Delete.
8542         (h8300_gdbarch_init): Don't register deleted functions with
8543         gdbarch.
8544
8545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8546
8547         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8548         (ft32_unwind_pc): Delete.
8549         (ft32_unwind_sp): Delete.
8550         (ft32_gdbarch_init): Don't register deleted functions with
8551         gdbarch.
8552
8553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8554
8555         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8556         (frv_unwind_pc): Delete.
8557         (frv_unwind_sp): Delete.
8558         (frv_gdbarch_init): Don't register deleted functions with
8559         gdbarch.
8560
8561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8562
8563         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8564         (riscv_unwind_pc): Delete.
8565         (riscv_unwind_sp): Delete.
8566         (riscv_gdbarch_init): Don't register deleted functions with
8567         gdbarch.
8568
8569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8570
8571         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8572         (csky_unwind_pc): Delete.
8573         (csky_unwind_sp): Delete.
8574         (csky_gdbarch_init): Don't register deleted functions with
8575         gdbarch.
8576
8577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8580         (cris_unwind_pc): Delete.
8581         (cris_unwind_sp): Delete.
8582         (cris_gdbarch_init): Don't register deleted functions with
8583         gdbarch.
8584
8585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8586
8587         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8588         (bfin_unwind_pc): Delete.
8589         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8590
8591 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8592
8593         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8594         (arm_unwind_pc): Delete.
8595         (arm_unwind_sp): Delete.
8596         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8597
8598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8599
8600         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8601         (arc_unwind_pc): Delete.
8602         (arc_unwind_sp): Delete.
8603         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8604
8605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8606
8607         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8608         (alpha_unwind_pc): Delete.
8609         (alpha_gdbarch_init): Don't register deleted functions with
8610         gdbarch.
8611
8612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8613
8614         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8615         (aarch64_unwind_pc): Delete.
8616         (aarch64_unwind_sp): Delete.
8617         (aarch64_gdbarch_init): Don't register deleted functions with
8618         gdbarch.
8619
8620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8621
8622         * gdbtypes.c (type_align): Don't consider static members when
8623         computing structure alignment.
8624
8625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8626
8627         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8628         return 0 for other types.
8629         * arch-utils.c (default_type_align): Always return 0.
8630         * gdbarch.h: Regenerate.
8631         * gdbarch.sh (type_align): Extend comment.
8632         * gdbtypes.c (type_align): Add additional comments, always call
8633         gdbarch_type_align before applying the default rules.
8634         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8635         generic code will then apply a suitable default.
8636         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8637         types, return 0 for other types.
8638
8639 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8640
8641         * NEWS: Create a new section for the next release branch.
8642         Rename the section of the current branch, now that it has
8643         been cut.
8644
8645 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8646
8647         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8648         * version.in: Bump version to 8.3.50.DATE-git.
8649
8650 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8651
8652         * aix-thread.c (ptid_cmp): Remove unused variable.
8653         (get_signaled_thread): Likewise.
8654         (store_regs_user_thread): Likewise.
8655         (store_regs_kernel_thread): Likewise.
8656         (fetch_regs_kernel_thread): Remove shadowed variable.
8657
8658 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8659
8660         * features/riscv/32bit-cpu.xml: Add register numbers.
8661         * features/riscv/32bit-fpu.c: Regenerate.
8662         * features/riscv/32bit-fpu.xml: Add register numbers.
8663         * features/riscv/64bit-cpu.xml: Add register numbers.
8664         * features/riscv/64bit-fpu.c: Regenerate.
8665         * features/riscv/64bit-fpu.xml: Add register numbers.
8666
8667 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8668
8669         * NEWS: Mention two argument form of gdb.Value constructor.
8670         * python/py-value.c (convert_buffer_and_type_to_value): New
8671         function.
8672         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8673         Add support for handling an optional second argument.  Call
8674         convert_buffer_and_type_to_value as appropriate.
8675         * python/python-internal.h (Py_buffer_deleter): New struct.
8676         (Py_buffer_up): New typedef.
8677
8678 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8679
8680         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8681         instead of releasing ownership.
8682
8683 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8684
8685         * dwarf2read.c (open_and_init_dwp_file): Call
8686         elf_numsections instead of bfd_count_sections to initialize
8687         dwp_file->num_sections.
8688
8689 2019-02-25  Tom Tromey  <tromey@adacore.com>
8690
8691         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8692
8693 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8694
8695         * gcore.in: Add '--readnever' option when invoking GDB.
8696
8697 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8698
8699         * MAINTAINERS: Update my email address.
8700
8701 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8702
8703         * build-id.c (build_id_to_debug_bfd_1): New function.
8704         (build_id_to_debug_bfd): Look for separate debug file in
8705         sysroot.
8706
8707 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8708
8709         * gdbarch.sh: Update the copyright year range that is placed into
8710         generated files.
8711
8712 2019-02-22  Keith Seitz  <keiths@redhat.com>
8713
8714         PR symtab/23853
8715         * linespec.c (create_sals_line_offset): Search for the default
8716         symtab's filename instead of its fullname.
8717
8718 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8719
8720         * NEWS: Update style defaults.
8721
8722 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8723
8724         * main.c (captured_main_1): Disable styling in batch mode.
8725
8726 2019-02-20  Tom Tromey  <tom@tromey.com>
8727
8728         * symtab.c (symtab_symbol_info): Fix typos.
8729
8730 2019-02-20  Tom Tromey  <tromey@adacore.com>
8731
8732         * findcmd.c (_initialize_mem_search): Use upper case for
8733         metasyntactic variables.
8734
8735 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8736
8737         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8738         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8739
8740 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8741
8742         * top.h (source_file_name): Change to std::string.
8743         * top.c (source_file_name): Likewise.
8744         (command_line_input): Adjust.
8745         * cli/cli-script.c (script_from_file): Adjust.
8746
8747 2019-02-19  Tom Tromey  <tromey@adacore.com>
8748
8749         * ravenscar-thread.c
8750         (ravenscar_thread_target::update_thread_list): Don't call
8751         ada_build_task_list.
8752         * ada-lang.h (ada_build_task_list): Don't declare.
8753         * ada-tasks.c (struct ada_tasks_inferior_data)
8754         <task_list_valid_p>: Now bool.
8755         (read_known_tasks, ada_task_list_changed)
8756         (ada_tasks_invalidate_inferior_data): Update.
8757         (read_known_tasks_array): Return bool.
8758         (read_known_tasks_list): Likewise.
8759         (read_known_tasks): Return void.
8760         (ada_build_task_list): Now static.
8761
8762 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8763
8764         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8765         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8766
8767 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8768
8769         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8770         variant for ada_tasks_pspace_data_handle and
8771         ada_tasks_inferior_data_handle.
8772         (ada_tasks_pspace_data_cleanup): New function.
8773         (ada_tasks_inferior_data_cleanup): New function.
8774
8775 2019-02-17  Tom Tromey  <tom@tromey.com>
8776
8777         * macrotab.h (macro_source_fullname): Return a std::string.
8778         * macrotab.c (macro_include, check_for_redefinition)
8779         (macro_undef, macro_lookup_definition, foreach_macro)
8780         (foreach_macro_in_scope): Update.
8781         (macro_source_fullname): Return a std::string.
8782         * macrocmd.c (show_pp_source_pos): Update.
8783
8784 2019-02-17  Tom Tromey  <tom@tromey.com>
8785
8786         * macrocmd.c (show_pp_source_pos): Style the file names.
8787
8788 2019-02-17  Tom Tromey  <tom@tromey.com>
8789
8790         PR tui/24197:
8791         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8792
8793 2019-02-17  Tom Tromey  <tom@tromey.com>
8794
8795         * ada-lang.c (user_select_syms): Use filtered printing.
8796         * utils.c (wrap_style): New global.
8797         (desired_style): Remove.
8798         (emit_style_escape): Add stream parameter.
8799         (set_output_style, reset_terminal_style, prompt_for_continue):
8800         Update.
8801         (flush_wrap_buffer): Only flush gdb_stdout.
8802         (wrap_here): Set wrap_style.
8803         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8804         treat escape sequences as a character.  Change when wrap buffer is
8805         flushed.
8806         (fputs_styled): Do not set the output style when the default is
8807         requested.
8808         * ui-style.h (struct ui_file_style) <is_default>: New method.
8809         * source.c (print_source_lines_base): Emit escape sequences in one
8810         piece.
8811
8812 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8813
8814         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8815         integers and enumeration types.
8816
8817 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8818
8819         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8820         instead of lookup_symbol_in_language
8821         (do_exact_match): New function.
8822         (ada_get_symbol_name_matcher): Return do_exact_match when
8823         doing a verbatim match.
8824
8825 2019-02-15  Tom Tromey  <tromey@adacore.com>
8826
8827         * ravenscar-thread.c (ravenscar_thread_target::resume)
8828         (ravenscar_thread_target::wait): Special case wildcard requests.
8829
8830 2019-02-15  Tom Tromey  <tromey@adacore.com>
8831
8832         * ravenscar-thread.c (base_ptid): Remove.
8833         (struct ravenscar_thread_target) <close>: New method.
8834         <m_base_ptid>: New member.
8835         <update_inferior_ptid, active_task, task_is_currently_active,
8836         runtime_initialized>: Declare methods.
8837         <ravenscar_thread_target>: Add constructor.
8838         (ravenscar_thread_target::task_is_currently_active)
8839         (ravenscar_thread_target::update_inferior_ptid)
8840         (ravenscar_runtime_initialized): Rename.  Now methods.
8841         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8842         (ravenscar_thread_target::update_thread_list): Update.
8843         (ravenscar_thread_target::active_task): Now method.
8844         (ravenscar_thread_target::store_registers)
8845         (ravenscar_thread_target::prepare_to_store)
8846         (ravenscar_thread_target::prepare_to_store)
8847         (ravenscar_thread_target::mourn_inferior): Update.
8848         (ravenscar_inferior_created): Use "new" to create target.
8849         (ravenscar_thread_target::get_ada_task_ptid): Update.
8850         (_initialize_ravenscar): Don't initialize base_ptid.
8851         (ravenscar_ops): Remove global.
8852
8853 2019-02-15  Tom Tromey  <tromey@adacore.com>
8854
8855         * target.h (push_target): Declare new overload.
8856         * target.c (push_target): New overload, taking an rvalue reference.
8857         * remote.c (remote_target::open_1): Use push_target overload.
8858         * corelow.c (core_target_open): Use push_target overload.
8859
8860 2019-02-15  Tom Tromey  <tromey@adacore.com>
8861
8862         * ravenscar-thread.c (is_ravenscar_task)
8863         (ravenscar_task_is_currently_active): Return bool.
8864         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8865         (_initialize_ravenscar): Remove "(void)".
8866         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8867         Return bool.
8868
8869 2019-02-15  Tom Tromey  <tromey@adacore.com>
8870
8871         * ravenscar-thread.c (ravenscar_runtime_initializer)
8872         (has_ravenscar_runtime, get_running_thread_id)
8873         (ravenscar_thread_target::resume): Fix indentation.
8874
8875 2019-02-15  Tom Tromey  <tromey@adacore.com>
8876
8877         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8878         from ravenscar_arch_ops.
8879         (sparc_ravenscar_ops::fetch_registers)
8880         (sparc_ravenscar_ops::store_registers): Now methods.
8881         (sparc_ravenscar_prepare_to_store): Remove.
8882         (sparc_ravenscar_ops): Redefine.
8883         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8884         methods and destructor.  Remove members.
8885         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8886         (ravenscar_thread_target::store_registers)
8887         (ravenscar_thread_target::prepare_to_store): Update.
8888         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8889         Remove.
8890         (struct ppc_ravenscar_powerpc_ops): Derive from
8891         ravenscar_arch_ops.
8892         (ppc_ravenscar_powerpc_ops::fetch_registers)
8893         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8894         (ppc_ravenscar_powerpc_ops): Redefine.
8895         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8896         (ppc_ravenscar_e500_ops::fetch_registers)
8897         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8898         (ppc_ravenscar_e500_ops): Redefine.
8899         * aarch64-ravenscar-thread.c
8900         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8901         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8902         (aarch64_ravenscar_fetch_registers)
8903         (aarch64_ravenscar_store_registers): Now methods.
8904         (aarch64_ravenscar_ops): Redefine.
8905
8906 2019-02-15  Tom Tromey  <tromey@adacore.com>
8907
8908         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8909         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8910         (ravenscar_thread_target::stopped_by_watchpoint)
8911         (ravenscar_thread_target::stopped_data_address)
8912         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8913
8914 2019-02-15  Tom Tromey  <tromey@adacore.com>
8915
8916         * ravenscar-thread.c: Fix some typos.
8917
8918 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8919             Tom Tromey  <tromey@adacore.com>
8920
8921         * ada-lang.c (ada_exception_sal): Change addr_string to a
8922         std::string.
8923         (create_ada_exception_catchpoint): Update.
8924
8925 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8926             Tom Tromey  <tromey@adacore.com>
8927
8928         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8929         (bp_location_ops): Remove.
8930         (base_breakpoint_allocate_location): Update.
8931         (free_bp_location): Update.
8932         * ada-lang.c (class ada_catchpoint_location)
8933         <ada_catchpoint_location>: Remove ops parameter.
8934         (ada_catchpoint_location_dtor): Remove.
8935         (ada_catchpoint_location_ops): Remove.
8936         (allocate_location_exception): Update.
8937         * breakpoint.h (struct bp_location_ops): Remove.
8938         (class bp_location) <bp_location>: Remove bp_location_ops
8939         parameter.
8940         <~bp_location>: Add destructor.
8941         <ops>: Remove.
8942
8943 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8944             Pedro Alves  <palves@redhat.com>
8945
8946         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8947         'PATH_MAX'.
8948
8949 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8950             Samuel Thibault  <samuel.thibault@gnu.org>
8951             Thomas Schwinge  <thomas@codesourcery.com>
8952
8953         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8954         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8955
8956 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8957
8958         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8959         (check_empty): Use "const char *".
8960
8961         * gnu-nat.c (gnu_nat_target::detach): Instead of
8962         'detach_inferior (pid)' call
8963         'detach_inferior (find_inferior_pid (pid))'.
8964
8965         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8966         'nat/fork-inferior.o'.
8967         * gnu-nat.c: #include "nat/fork-inferior.h".
8968
8969         * gnu-nat.c (gnu_nat_target::detach): Instead of
8970         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8971         * gnu-nat.h: #include "inf-child.h".
8972         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8973         'i386_gnu_nat_target::fetch_registers'.
8974         (gnu_store_registers): Rename/move to
8975         'i386_gnu_nat_target::store_registers'.
8976
8977         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8978         * gnu-nat.h (mach_thread_info): New function.
8979         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8980
8981         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8982
8983 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8984
8985         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8986
8987 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8988
8989         * windows-nat.c (windows_add_thread): Add new parameter
8990         "main_thread_p" with default value set to false.  Update
8991         function documentation as well as all callers.
8992         (windows_delete_thread): Likewise.
8993         (fake_create_process): Update call to windows_add_thread.
8994         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8995         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8996         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8997         call to windows_delete_thread.
8998
8999 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9000
9001         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9002
9003 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9004
9005         * symfile.c (find_separate_debug_file): Use canonical path of
9006         sysroot with child_path instead of gdb_sysroot if it is valid.
9007
9008 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9009
9010         * symfile.c (find_separate_debug_file): Use child_path to
9011         determine if an object file is under a sysroot.
9012
9013 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9014
9015         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9016         unittests/child-path-selftests.c.
9017         * common/pathstuff.c (child_path): New function.
9018         * common/pathstuff.h (child_path): New prototype.
9019         * unittests/child-path-selftests.c: New file.
9020
9021 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9022
9023         * symfile.c (find_separate_debug_file): Look for separate debug
9024         files in debug directories under the sysroot.
9025
9026 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9027
9028         * symtab.h (struct minimal_symbol data_p): New const method.
9029         (struct minimal_symbol text_p): Likewise.
9030         * symtab.c (output_source_filename): Use file name style
9031         to print file name.
9032         (print_symbol_info): Likewise.
9033         (print_msymbol_info): Use address style to print addresses.
9034         Use function name style to print executable text symbols.
9035         (expand_symtab_containing_pc): Use data_p.
9036         (find_pc_sect_compunit_symtab): Likewise.
9037
9038 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9039
9040         * breakpoint.c (describe_other_breakpoints): Use address style
9041         to print addresses.
9042         (say_where): Likewise.
9043
9044 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9045
9046         * ada-typeprint.c (print_func_type): Print function name
9047         style to print function name.
9048         * c-typeprint.c (c_print_type_1): Likewise.
9049
9050 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9051
9052         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9053         for execve.
9054
9055 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9056
9057         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9058         type_stack.
9059
9060 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9061
9062         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9063         TYPE_CODE_REF types.
9064
9065 2019-02-08  Jim Wilson  <jimw@sifive.com>
9066
9067         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9068         (riscv_linux_fregset): New.
9069         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9070
9071 2019-02-07  Tom Tromey  <tom@tromey.com>
9072
9073         * thread.c (thread_cancel_execution_command): Update.
9074         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9075         methods.
9076         (struct thread_fsm_ops): Remove.
9077         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9078         (thread_fsm_should_stop, thread_fsm_return_value)
9079         (thread_fsm_set_finished, thread_fsm_finished_p)
9080         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9081         Don't declare.
9082         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9083         * infrun.c (clear_proceed_status_thread)
9084         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9085         (print_stop_event): Update.
9086         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9087         Add constructor.
9088         (step_command_fsm_ops): Remove.
9089         (new_step_command_fsm): Remove.
9090         (step_1): Update.
9091         (step_command_fsm::should_stop): Rename from
9092         step_command_fsm_should_stop.
9093         (step_command_fsm::clean_up): Rename from
9094         step_command_fsm_clean_up.
9095         (step_command_fsm::do_async_reply_reason): Rename from
9096         step_command_fsm_async_reply_reason.
9097         (struct until_next_fsm): Inherit from thread_fsm.  Add
9098         constructor.
9099         (until_next_fsm_ops): Remove.
9100         (new_until_next_fsm): Remove.
9101         (until_next_fsm::should_stop): Rename from
9102         until_next_fsm_should_stop.
9103         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9104         (until_next_fsm::do_async_reply_reason): Rename from
9105         until_next_fsm_async_reply_reason.
9106         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9107         constructor.  Change type of breakpoint.
9108         (finish_command_fsm_ops): Remove.
9109         (new_finish_command_fsm): Remove.
9110         (finish_command_fsm::should_stop): Rename from
9111         finish_command_fsm_should_stop.
9112         (finish_command_fsm::clean_up): Rename from
9113         finish_command_fsm_clean_up.
9114         (finish_command_fsm::return_value): Rename from
9115         finish_command_fsm_return_value.
9116         (finish_command_fsm::do_async_reply_reason): Rename from
9117         finish_command_fsm_async_reply_reason.
9118         (finish_command): Update.
9119         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9120         Add constructor.
9121         (call_thread_fsm_ops): Remove.
9122         (call_thread_fsm::call_thread_fsm): Rename from
9123         new_call_thread_fsm.
9124         (call_thread_fsm::should_stop): Rename from
9125         call_thread_fsm_should_stop.
9126         (call_thread_fsm::should_notify_stop): Rename from
9127         call_thread_fsm_should_notify_stop.
9128         (run_inferior_call, call_function_by_hand_dummy): Update.
9129         * cli/cli-interp.c (should_print_stop_to_console): Update.
9130         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9131         Add constructor.  Change type of location_breakpoint,
9132         caller_breakpoint.
9133         (until_break_fsm_ops): Remove.
9134         (new_until_break_fsm): Remove.
9135         (until_break_fsm::should_stop): Rename from
9136         until_break_fsm_should_stop.
9137         (until_break_fsm::clean_up): Rename from
9138         until_break_fsm_clean_up.
9139         (until_break_fsm::do_async_reply_reason): Rename from
9140         until_break_fsm_async_reply_reason.
9141         (until_break_command): Update.
9142         * thread-fsm.c: Remove.
9143         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9144
9145 2019-02-07  Tom Tromey  <tom@tromey.com>
9146
9147         * yy-remap.h: Add include guard.
9148         * xtensa-tdep.h: Add include guard.
9149         * xcoffread.h: Rename include guard.
9150         * varobj-iter.h: Add include guard.
9151         * tui/tui.h: Rename include guard.
9152         * tui/tui-winsource.h: Rename include guard.
9153         * tui/tui-wingeneral.h: Rename include guard.
9154         * tui/tui-windata.h: Rename include guard.
9155         * tui/tui-win.h: Rename include guard.
9156         * tui/tui-stack.h: Rename include guard.
9157         * tui/tui-source.h: Rename include guard.
9158         * tui/tui-regs.h: Rename include guard.
9159         * tui/tui-out.h: Rename include guard.
9160         * tui/tui-layout.h: Rename include guard.
9161         * tui/tui-io.h: Rename include guard.
9162         * tui/tui-hooks.h: Rename include guard.
9163         * tui/tui-file.h: Rename include guard.
9164         * tui/tui-disasm.h: Rename include guard.
9165         * tui/tui-data.h: Rename include guard.
9166         * tui/tui-command.h: Rename include guard.
9167         * tic6x-tdep.h: Add include guard.
9168         * target/waitstatus.h: Rename include guard.
9169         * target/wait.h: Rename include guard.
9170         * target/target.h: Rename include guard.
9171         * target/resume.h: Rename include guard.
9172         * target-float.h: Rename include guard.
9173         * stabsread.h: Add include guard.
9174         * rs6000-tdep.h: Add include guard.
9175         * riscv-fbsd-tdep.h: Add include guard.
9176         * regformats/regdef.h: Rename include guard.
9177         * record.h: Rename include guard.
9178         * python/python.h: Rename include guard.
9179         * python/python-internal.h: Rename include guard.
9180         * python/py-stopevent.h: Rename include guard.
9181         * python/py-ref.h: Rename include guard.
9182         * python/py-record.h: Rename include guard.
9183         * python/py-record-full.h: Rename include guard.
9184         * python/py-record-btrace.h: Rename include guard.
9185         * python/py-instruction.h: Rename include guard.
9186         * python/py-events.h: Rename include guard.
9187         * python/py-event.h: Rename include guard.
9188         * procfs.h: Add include guard.
9189         * proc-utils.h: Add include guard.
9190         * p-lang.h: Add include guard.
9191         * or1k-tdep.h: Rename include guard.
9192         * observable.h: Rename include guard.
9193         * nto-tdep.h: Rename include guard.
9194         * nat/x86-linux.h: Rename include guard.
9195         * nat/x86-linux-dregs.h: Rename include guard.
9196         * nat/x86-gcc-cpuid.h: Add include guard.
9197         * nat/x86-dregs.h: Rename include guard.
9198         * nat/x86-cpuid.h: Rename include guard.
9199         * nat/ppc-linux.h: Rename include guard.
9200         * nat/mips-linux-watch.h: Rename include guard.
9201         * nat/linux-waitpid.h: Rename include guard.
9202         * nat/linux-ptrace.h: Rename include guard.
9203         * nat/linux-procfs.h: Rename include guard.
9204         * nat/linux-osdata.h: Rename include guard.
9205         * nat/linux-nat.h: Rename include guard.
9206         * nat/linux-namespaces.h: Rename include guard.
9207         * nat/linux-btrace.h: Rename include guard.
9208         * nat/glibc_thread_db.h: Rename include guard.
9209         * nat/gdb_thread_db.h: Rename include guard.
9210         * nat/gdb_ptrace.h: Rename include guard.
9211         * nat/fork-inferior.h: Rename include guard.
9212         * nat/amd64-linux-siginfo.h: Rename include guard.
9213         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9214         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9215         * nat/aarch64-linux.h: Rename include guard.
9216         * nat/aarch64-linux-hw-point.h: Rename include guard.
9217         * mn10300-tdep.h: Add include guard.
9218         * mips-linux-tdep.h: Add include guard.
9219         * mi/mi-parse.h: Rename include guard.
9220         * mi/mi-out.h: Rename include guard.
9221         * mi/mi-main.h: Rename include guard.
9222         * mi/mi-interp.h: Rename include guard.
9223         * mi/mi-getopt.h: Rename include guard.
9224         * mi/mi-console.h: Rename include guard.
9225         * mi/mi-common.h: Rename include guard.
9226         * mi/mi-cmds.h: Rename include guard.
9227         * mi/mi-cmd-break.h: Rename include guard.
9228         * m2-lang.h: Add include guard.
9229         * location.h: Rename include guard.
9230         * linux-record.h: Rename include guard.
9231         * linux-nat.h: Add include guard.
9232         * linux-fork.h: Add include guard.
9233         * i386-darwin-tdep.h: Rename include guard.
9234         * hppa-linux-offsets.h: Add include guard.
9235         * guile/guile.h: Rename include guard.
9236         * guile/guile-internal.h: Rename include guard.
9237         * gnu-nat.h: Rename include guard.
9238         * gdb-stabs.h: Rename include guard.
9239         * frv-tdep.h: Add include guard.
9240         * f-lang.h: Add include guard.
9241         * event-loop.h: Add include guard.
9242         * darwin-nat.h: Rename include guard.
9243         * cp-abi.h: Rename include guard.
9244         * config/sparc/nm-sol2.h: Rename include guard.
9245         * config/nm-nto.h: Rename include guard.
9246         * config/nm-linux.h: Add include guard.
9247         * config/i386/nm-i386gnu.h: Rename include guard.
9248         * config/djgpp/nl_types.h: Rename include guard.
9249         * config/djgpp/langinfo.h: Rename include guard.
9250         * compile/gcc-cp-plugin.h: Add include guard.
9251         * compile/gcc-c-plugin.h: Add include guard.
9252         * compile/compile.h: Rename include guard.
9253         * compile/compile-object-run.h: Rename include guard.
9254         * compile/compile-object-load.h: Rename include guard.
9255         * compile/compile-internal.h: Rename include guard.
9256         * compile/compile-cplus.h: Rename include guard.
9257         * compile/compile-c.h: Rename include guard.
9258         * common/xml-utils.h: Rename include guard.
9259         * common/x86-xstate.h: Rename include guard.
9260         * common/version.h: Rename include guard.
9261         * common/vec.h: Rename include guard.
9262         * common/tdesc.h: Rename include guard.
9263         * common/selftest.h: Rename include guard.
9264         * common/scoped_restore.h: Rename include guard.
9265         * common/scoped_mmap.h: Rename include guard.
9266         * common/scoped_fd.h: Rename include guard.
9267         * common/safe-iterator.h: Rename include guard.
9268         * common/run-time-clock.h: Rename include guard.
9269         * common/refcounted-object.h: Rename include guard.
9270         * common/queue.h: Rename include guard.
9271         * common/ptid.h: Rename include guard.
9272         * common/print-utils.h: Rename include guard.
9273         * common/preprocessor.h: Rename include guard.
9274         * common/pathstuff.h: Rename include guard.
9275         * common/observable.h: Rename include guard.
9276         * common/netstuff.h: Rename include guard.
9277         * common/job-control.h: Rename include guard.
9278         * common/host-defs.h: Rename include guard.
9279         * common/gdb_wait.h: Rename include guard.
9280         * common/gdb_vecs.h: Rename include guard.
9281         * common/gdb_unlinker.h: Rename include guard.
9282         * common/gdb_unique_ptr.h: Rename include guard.
9283         * common/gdb_tilde_expand.h: Rename include guard.
9284         * common/gdb_sys_time.h: Rename include guard.
9285         * common/gdb_string_view.h: Rename include guard.
9286         * common/gdb_splay_tree.h: Rename include guard.
9287         * common/gdb_setjmp.h: Rename include guard.
9288         * common/gdb_ref_ptr.h: Rename include guard.
9289         * common/gdb_optional.h: Rename include guard.
9290         * common/gdb_locale.h: Rename include guard.
9291         * common/gdb_assert.h: Rename include guard.
9292         * common/filtered-iterator.h: Rename include guard.
9293         * common/filestuff.h: Rename include guard.
9294         * common/fileio.h: Rename include guard.
9295         * common/environ.h: Rename include guard.
9296         * common/common-utils.h: Rename include guard.
9297         * common/common-types.h: Rename include guard.
9298         * common/common-regcache.h: Rename include guard.
9299         * common/common-inferior.h: Rename include guard.
9300         * common/common-gdbthread.h: Rename include guard.
9301         * common/common-exceptions.h: Rename include guard.
9302         * common/common-defs.h: Rename include guard.
9303         * common/common-debug.h: Rename include guard.
9304         * common/cleanups.h: Rename include guard.
9305         * common/buffer.h: Rename include guard.
9306         * common/btrace-common.h: Rename include guard.
9307         * common/break-common.h: Rename include guard.
9308         * cli/cli-utils.h: Rename include guard.
9309         * cli/cli-style.h: Rename include guard.
9310         * cli/cli-setshow.h: Rename include guard.
9311         * cli/cli-script.h: Rename include guard.
9312         * cli/cli-interp.h: Rename include guard.
9313         * cli/cli-decode.h: Rename include guard.
9314         * cli/cli-cmds.h: Rename include guard.
9315         * charset-list.h: Add include guard.
9316         * buildsym-legacy.h: Rename include guard.
9317         * bfin-tdep.h: Add include guard.
9318         * ax.h: Rename include guard.
9319         * arm-linux-tdep.h: Add include guard.
9320         * arm-fbsd-tdep.h: Add include guard.
9321         * arch/xtensa.h: Rename include guard.
9322         * arch/tic6x.h: Add include guard.
9323         * arch/i386.h: Add include guard.
9324         * arch/arm.h: Rename include guard.
9325         * arch/arm-linux.h: Rename include guard.
9326         * arch/arm-get-next-pcs.h: Rename include guard.
9327         * arch/amd64.h: Add include guard.
9328         * arch/aarch64-insn.h: Rename include guard.
9329         * arch-utils.h: Rename include guard.
9330         * annotate.h: Add include guard.
9331         * amd64-darwin-tdep.h: Rename include guard.
9332         * aarch64-linux-tdep.h: Add include guard.
9333         * aarch64-fbsd-tdep.h: Add include guard.
9334         * aarch32-linux-nat.h: Add include guard.
9335
9336 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9337
9338         * macrotab.c (macro_define_internal): New function that
9339         factorizes macro_define_object_internal and macro_define_function
9340         code.
9341         (macro_define_object_internal): Use macro_define_internal.
9342         (macro_define_function): Likewise.
9343
9344 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9345
9346         * macrocmd.c (extract_identifier): Return
9347         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9348         callers.
9349
9350 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9351
9352         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9353
9354 2019-02-05  Tom Tromey  <tom@tromey.com>
9355
9356         * target.c (target_stack::unpush): Move assertion earlier.
9357
9358 2019-01-30  Tom Tromey  <tom@tromey.com>
9359
9360         PR python/23615:
9361         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9362         (gdbpy_parse_and_eval): Likewise.
9363         * python/python-internal.h (gdbpy_allow_threads): New class.
9364
9365 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9366
9367         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9368         (aarch64_fbsd_fpregmap): Move earlier.
9369         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9370         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9371         instead of individual calls to trad_frame_set_reg_addr.
9372         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9373         earlier.
9374         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9375         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9376         instead of individual calls to trad_frame_set_reg_addr.
9377
9378 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9379
9380         * CONTRIBUTE: Replace contribution list with wiki link.
9381
9382 2019-01-25  Tom Tromey  <tom@tromey.com>
9383
9384         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9385
9386 2019-01-25  Tom Tromey  <tom@tromey.com>
9387
9388         * xtensa-linux-nat.c: Fix common/ includes.
9389         * xml-support.h: Fix common/ includes.
9390         * xml-support.c: Fix common/ includes.
9391         * x86-linux-nat.c: Fix common/ includes.
9392         * windows-nat.c: Fix common/ includes.
9393         * varobj.h: Fix common/ includes.
9394         * varobj.c: Fix common/ includes.
9395         * value.c: Fix common/ includes.
9396         * valops.c: Fix common/ includes.
9397         * utils.c: Fix common/ includes.
9398         * unittests/xml-utils-selftests.c: Fix common/ includes.
9399         * unittests/utils-selftests.c: Fix common/ includes.
9400         * unittests/unpack-selftests.c: Fix common/ includes.
9401         * unittests/tracepoint-selftests.c: Fix common/ includes.
9402         * unittests/style-selftests.c: Fix common/ includes.
9403         * unittests/string_view-selftests.c: Fix common/ includes.
9404         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9405         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9406         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9407         * unittests/rsp-low-selftests.c: Fix common/ includes.
9408         * unittests/parse-connection-spec-selftests.c: Fix common/
9409         includes.
9410         * unittests/optional-selftests.c: Fix common/ includes.
9411         * unittests/offset-type-selftests.c: Fix common/ includes.
9412         * unittests/observable-selftests.c: Fix common/ includes.
9413         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9414         * unittests/memrange-selftests.c: Fix common/ includes.
9415         * unittests/memory-map-selftests.c: Fix common/ includes.
9416         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9417         * unittests/function-view-selftests.c: Fix common/ includes.
9418         * unittests/environ-selftests.c: Fix common/ includes.
9419         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9420         * unittests/common-utils-selftests.c: Fix common/ includes.
9421         * unittests/cli-utils-selftests.c: Fix common/ includes.
9422         * unittests/array-view-selftests.c: Fix common/ includes.
9423         * ui-file.c: Fix common/ includes.
9424         * tui/tui-io.c: Fix common/ includes.
9425         * tracepoint.h: Fix common/ includes.
9426         * tracepoint.c: Fix common/ includes.
9427         * tracefile-tfile.c: Fix common/ includes.
9428         * top.h: Fix common/ includes.
9429         * top.c: Fix common/ includes.
9430         * thread.c: Fix common/ includes.
9431         * target/waitstatus.h: Fix common/ includes.
9432         * target/waitstatus.c: Fix common/ includes.
9433         * target.h: Fix common/ includes.
9434         * target.c: Fix common/ includes.
9435         * target-memory.c: Fix common/ includes.
9436         * target-descriptions.c: Fix common/ includes.
9437         * symtab.h: Fix common/ includes.
9438         * symfile.c: Fix common/ includes.
9439         * stap-probe.c: Fix common/ includes.
9440         * spu-linux-nat.c: Fix common/ includes.
9441         * sparc-nat.c: Fix common/ includes.
9442         * source.c: Fix common/ includes.
9443         * solib.c: Fix common/ includes.
9444         * solib-target.c: Fix common/ includes.
9445         * ser-unix.c: Fix common/ includes.
9446         * ser-tcp.c: Fix common/ includes.
9447         * ser-pipe.c: Fix common/ includes.
9448         * ser-base.c: Fix common/ includes.
9449         * selftest-arch.c: Fix common/ includes.
9450         * s12z-tdep.c: Fix common/ includes.
9451         * rust-exp.y: Fix common/ includes.
9452         * rs6000-aix-tdep.c: Fix common/ includes.
9453         * riscv-tdep.c: Fix common/ includes.
9454         * remote.c: Fix common/ includes.
9455         * remote-notif.h: Fix common/ includes.
9456         * remote-fileio.h: Fix common/ includes.
9457         * remote-fileio.c: Fix common/ includes.
9458         * regcache.h: Fix common/ includes.
9459         * regcache.c: Fix common/ includes.
9460         * record-btrace.c: Fix common/ includes.
9461         * python/python.c: Fix common/ includes.
9462         * python/py-type.c: Fix common/ includes.
9463         * python/py-inferior.c: Fix common/ includes.
9464         * progspace.h: Fix common/ includes.
9465         * producer.c: Fix common/ includes.
9466         * procfs.c: Fix common/ includes.
9467         * proc-api.c: Fix common/ includes.
9468         * printcmd.c: Fix common/ includes.
9469         * ppc-linux-nat.c: Fix common/ includes.
9470         * parser-defs.h: Fix common/ includes.
9471         * osdata.c: Fix common/ includes.
9472         * obsd-nat.c: Fix common/ includes.
9473         * nat/x86-linux.c: Fix common/ includes.
9474         * nat/x86-linux-dregs.c: Fix common/ includes.
9475         * nat/x86-dregs.h: Fix common/ includes.
9476         * nat/x86-dregs.c: Fix common/ includes.
9477         * nat/ppc-linux.c: Fix common/ includes.
9478         * nat/mips-linux-watch.h: Fix common/ includes.
9479         * nat/mips-linux-watch.c: Fix common/ includes.
9480         * nat/linux-waitpid.c: Fix common/ includes.
9481         * nat/linux-ptrace.h: Fix common/ includes.
9482         * nat/linux-ptrace.c: Fix common/ includes.
9483         * nat/linux-procfs.c: Fix common/ includes.
9484         * nat/linux-personality.c: Fix common/ includes.
9485         * nat/linux-osdata.c: Fix common/ includes.
9486         * nat/linux-namespaces.c: Fix common/ includes.
9487         * nat/linux-btrace.h: Fix common/ includes.
9488         * nat/linux-btrace.c: Fix common/ includes.
9489         * nat/fork-inferior.c: Fix common/ includes.
9490         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9491         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9492         * nat/aarch64-linux.c: Fix common/ includes.
9493         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9494         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9495         * namespace.h: Fix common/ includes.
9496         * mips-linux-tdep.c: Fix common/ includes.
9497         * minsyms.c: Fix common/ includes.
9498         * mi/mi-parse.h: Fix common/ includes.
9499         * mi/mi-main.c: Fix common/ includes.
9500         * mi/mi-cmd-env.c: Fix common/ includes.
9501         * memrange.h: Fix common/ includes.
9502         * memattr.c: Fix common/ includes.
9503         * maint.h: Fix common/ includes.
9504         * maint.c: Fix common/ includes.
9505         * main.c: Fix common/ includes.
9506         * machoread.c: Fix common/ includes.
9507         * location.c: Fix common/ includes.
9508         * linux-thread-db.c: Fix common/ includes.
9509         * linux-nat.c: Fix common/ includes.
9510         * linux-fork.c: Fix common/ includes.
9511         * inline-frame.c: Fix common/ includes.
9512         * infrun.c: Fix common/ includes.
9513         * inflow.c: Fix common/ includes.
9514         * inferior.h: Fix common/ includes.
9515         * inferior.c: Fix common/ includes.
9516         * infcmd.c: Fix common/ includes.
9517         * inf-ptrace.c: Fix common/ includes.
9518         * inf-child.c: Fix common/ includes.
9519         * ia64-linux-nat.c: Fix common/ includes.
9520         * i387-tdep.c: Fix common/ includes.
9521         * i386-tdep.c: Fix common/ includes.
9522         * i386-linux-tdep.c: Fix common/ includes.
9523         * i386-linux-nat.c: Fix common/ includes.
9524         * i386-go32-tdep.c: Fix common/ includes.
9525         * i386-fbsd-tdep.c: Fix common/ includes.
9526         * i386-fbsd-nat.c: Fix common/ includes.
9527         * guile/scm-type.c: Fix common/ includes.
9528         * guile/guile.c: Fix common/ includes.
9529         * go32-nat.c: Fix common/ includes.
9530         * gnu-nat.c: Fix common/ includes.
9531         * gdbthread.h: Fix common/ includes.
9532         * gdbarch-selftests.c: Fix common/ includes.
9533         * gdb_usleep.c: Fix common/ includes.
9534         * gdb_select.h: Fix common/ includes.
9535         * gdb_bfd.c: Fix common/ includes.
9536         * gcore.c: Fix common/ includes.
9537         * fork-child.c: Fix common/ includes.
9538         * findvar.c: Fix common/ includes.
9539         * fbsd-nat.c: Fix common/ includes.
9540         * event-top.c: Fix common/ includes.
9541         * event-loop.c: Fix common/ includes.
9542         * dwarf2read.c: Fix common/ includes.
9543         * dwarf2loc.c: Fix common/ includes.
9544         * dwarf2-frame.c: Fix common/ includes.
9545         * dwarf-index-cache.c: Fix common/ includes.
9546         * dtrace-probe.c: Fix common/ includes.
9547         * disasm-selftests.c: Fix common/ includes.
9548         * defs.h: Fix common/ includes.
9549         * csky-tdep.c: Fix common/ includes.
9550         * cp-valprint.c: Fix common/ includes.
9551         * cp-support.h: Fix common/ includes.
9552         * cp-support.c: Fix common/ includes.
9553         * corelow.c: Fix common/ includes.
9554         * completer.h: Fix common/ includes.
9555         * completer.c: Fix common/ includes.
9556         * compile/compile.c: Fix common/ includes.
9557         * compile/compile-loc2c.c: Fix common/ includes.
9558         * compile/compile-cplus-types.c: Fix common/ includes.
9559         * compile/compile-cplus-symbols.c: Fix common/ includes.
9560         * command.h: Fix common/ includes.
9561         * cli/cli-dump.c: Fix common/ includes.
9562         * cli/cli-cmds.c: Fix common/ includes.
9563         * charset.c: Fix common/ includes.
9564         * build-id.c: Fix common/ includes.
9565         * btrace.h: Fix common/ includes.
9566         * btrace.c: Fix common/ includes.
9567         * breakpoint.h: Fix common/ includes.
9568         * breakpoint.c: Fix common/ includes.
9569         * ax.h:
9570         (enum agent_op): Fix common/ includes.
9571         * ax-general.c (struct aop_map): Fix common/ includes.
9572         * ax-gdb.c: Fix common/ includes.
9573         * auxv.c: Fix common/ includes.
9574         * auto-load.c: Fix common/ includes.
9575         * arm-tdep.c: Fix common/ includes.
9576         * arch/riscv.c: Fix common/ includes.
9577         * arch/ppc-linux-common.c: Fix common/ includes.
9578         * arch/i386.c: Fix common/ includes.
9579         * arch/arm.c: Fix common/ includes.
9580         * arch/arm-linux.c: Fix common/ includes.
9581         * arch/arm-get-next-pcs.c: Fix common/ includes.
9582         * arch/amd64.c: Fix common/ includes.
9583         * arch/aarch64.c: Fix common/ includes.
9584         * arch/aarch64-insn.c: Fix common/ includes.
9585         * arch-utils.c: Fix common/ includes.
9586         * amd64-windows-tdep.c: Fix common/ includes.
9587         * amd64-tdep.c: Fix common/ includes.
9588         * amd64-sol2-tdep.c: Fix common/ includes.
9589         * amd64-obsd-tdep.c: Fix common/ includes.
9590         * amd64-nbsd-tdep.c: Fix common/ includes.
9591         * amd64-linux-tdep.c: Fix common/ includes.
9592         * amd64-linux-nat.c: Fix common/ includes.
9593         * amd64-fbsd-tdep.c: Fix common/ includes.
9594         * amd64-fbsd-nat.c: Fix common/ includes.
9595         * amd64-dicos-tdep.c: Fix common/ includes.
9596         * amd64-darwin-tdep.c: Fix common/ includes.
9597         * agent.c: Fix common/ includes.
9598         * ada-lang.h: Fix common/ includes.
9599         * ada-lang.c: Fix common/ includes.
9600         * aarch64-tdep.c: Fix common/ includes.
9601
9602 2019-01-25  Tom Tromey  <tom@tromey.com>
9603
9604         * common/create-version.sh: Use common/version.h.
9605
9606 2019-01-24  Pedro Alves  <palves@redhat.com>
9607
9608         * infrun.c (signal_stop, signal_print, signal_program)
9609         (signal_catch, signal_pass): Now arrays instead of pointers.
9610         (update_signals_program_target, do_target_resume)
9611         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9612         * linux-nat.c (linux_nat_target::pass_signals)
9613         (linux_nat_target::create_inferior, linux_nat_target::attach):
9614         Adjust.
9615         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9616         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9617         * procfs.c (procfs_target::pass_signals): Adjust.
9618         * record-full.c (record_full_target::resume): Adjust.
9619         * remote.c (remote_target::pass_signals)
9620         (remote_target::program_signals): Adjust.
9621         * target-debug.h (target_debug_print_signals): Now takes a
9622         gdb::array_view as parameter.  Adjust.
9623         * target.h (target_ops) <pass_signals, program_signals>: Replace
9624         pointer and length parameters with gdb::array_view.
9625         (target_pass_signals, target_program_signals): Likewise.
9626         * target-delegates.c: Regenerate.
9627
9628 2019-01-24  Pedro Alves  <palves@redhat.com>
9629
9630         * common/forward-scope-exit.h
9631         (forward_scope_exit::forward_scope_exit): Pass arguments to
9632         m_bind_function directly, instead of creating a std::bind and
9633         copying that.
9634
9635 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9636
9637         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9638         for static members.
9639         (pass_in_v_vfp_candidate): Likewise.
9640
9641 2019-01-23  Tom Tromey  <tom@tromey.com>
9642             Pedro Alves  <palves@redhat.com>
9643
9644         * regcache.c (class regcache_invalidator): Remove.
9645         (regcache::raw_write): Use make_scope_exit.
9646
9647 2019-01-23  Tom Tromey  <tom@tromey.com>
9648
9649         * ui-out.h (class ui_out_emit_type): Update comment.
9650
9651 2019-01-23  Tom Tromey  <tom@tromey.com>
9652
9653         * infrun.c (fetch_inferior_event): Update comment.
9654
9655 2019-01-23  Tom Tromey  <tom@tromey.com>
9656             Pedro Alves  <palves@redhat.com>
9657
9658         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9659         parameter.
9660         (fetch_inferior_event): Use SCOPE_EXIT.
9661
9662
9663 2019-01-23  Tom Tromey  <tom@tromey.com>
9664             Pedro Alves  <palves@redhat.com>
9665
9666         * infrun.c (disable_thread_events): Delete.
9667         (stop_all_threads): Use SCOPE_EXIT.
9668
9669 2019-01-23  Tom Tromey  <tom@tromey.com>
9670             Pedro Alves  <palves@redhat.com>
9671
9672         * symfile.c: Include forward-scope-exit.h.
9673         (clear_symtab_users_cleanup): Replace forward declaration with
9674         a FORWARD_SCOPE_EXIT.
9675         (syms_from_objfile_1): Use the forward_scope_exit and
9676         gdb::optional instead of cleanup_function.
9677         (reread_symbols): Use the forward_scope_exit instead of
9678         cleanup_function.
9679         (clear_symtab_users_cleanup): Remove function.
9680
9681 2019-01-23  Tom Tromey  <tom@tromey.com>
9682             Pedro Alves  <palves@redhat.com>
9683
9684         * linux-nat.c: Include scope-exit.h.
9685         (cleanup_target_stop): Remove.
9686         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9687         SCOPE_EXIT.
9688
9689 2019-01-23  Tom Tromey  <tom@tromey.com>
9690             Pedro Alves  <palves@redhat.com>
9691
9692         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9693         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9694
9695 2019-01-23  Tom Tromey  <tom@tromey.com>
9696             Andrew Burgess  <andrew.burgess@embecosm.com>
9697             Pedro Alves  <palves@redhat.com>
9698
9699         * infrun.c (fetch_inferior_event): Use scope_exit.
9700         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9701         * top.c (execute_command): Use scope_exit.
9702         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9703         * utils.c (do_bpstat_clear_actions_cleanup)
9704         (make_bpstat_clear_actions_cleanup): Remove.
9705
9706 2019-01-23  Tom Tromey  <tom@tromey.com>
9707             Pedro Alves  <palves@redhat.com>
9708
9709         * infrun.c: Include "common/scope-exit.h"
9710         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9711         (wait_for_inferior): Use SCOPE_EXIT.
9712         (fetch_inferior_event): Use scope_exit.
9713
9714 2019-01-23  Tom Tromey  <tom@tromey.com>
9715             Pedro Alves  <palves@redhat.com>
9716
9717         * breakpoint.c (create_breakpoint): Remove cleanup.
9718
9719 2019-01-23  Tom Tromey  <tom@tromey.com>
9720             Andrew Burgess  <andrew.burgess@embecosm.com>
9721             Pedro Alves  <palves@redhat.com>
9722
9723 2019-01-23  Pedro Alves  <palves@redhat.com>
9724
9725         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9726
9727 2019-01-23  Pedro Alves  <palves@redhat.com>
9728             Andrew Burgess  <andrew.burgess@embecosm.com>
9729
9730         * gdbthread.h: Include "common/forward-scope-exit.h".
9731         (scoped_finish_thread_state): Redefine custom class in terms of
9732         forward_scope_exit.
9733
9734 2019-01-23  Pedro Alves  <palves@redhat.com>
9735             Andrew Burgess  <andrew.burgess@embecosm.com>
9736
9737         * common/forward-scope-exit.h: New file.
9738
9739 2019-01-23  Pedro Alves  <palves@redhat.com>
9740             Andrew Burgess  <andrew.burgess@embecosm.com>
9741             Tom Tromey  <tom@tromey.com>
9742
9743         * common/scope-exit.h: New file.
9744
9745 2019-01-23  Pedro Alves  <palves@redhat.com>
9746
9747         * common/preprocessor.h (ESC): Rename to ...
9748         (ESC_PARENS): ... this.
9749         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9750         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9751
9752 2019-01-23  Tom Tromey  <tom@tromey.com>
9753
9754         * language.h (class scoped_switch_to_sym_language_if_auto):
9755         Initialize m_lang in both cases.
9756
9757 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9758
9759         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9760         with XCNEW.
9761
9762 2019-01-22  Tom Tromey  <tom@tromey.com>
9763
9764         * corelow.c: Do not include sys/file.h.
9765
9766 2019-01-22  Tom Tromey  <tom@tromey.com>
9767
9768         * tui/tui-wingeneral.h: Include gdb_curses.h.
9769
9770 2019-01-22  Tom Tromey  <tom@tromey.com>
9771
9772         * source-cache.h (class source_cache) <get_source_lines,
9773         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9774
9775 2019-01-22  Tom Tromey  <tom@tromey.com>
9776
9777         * remote-fileio.h (struct remote_target): Declare.
9778
9779 2019-01-22  Tom Tromey  <tom@tromey.com>
9780
9781         * python/py-arch.c: Do not include py-ref.h.
9782         * python/py-bpevent.c: Do not include py-ref.h.
9783         * python/py-cmd.c: Do not include py-ref.h.
9784         * python/py-continueevent.c: Do not include py-ref.h.
9785         * python/py-event.h: Do not include py-ref.h.
9786         * python/py-evtregistry.c: Do not include py-ref.h.
9787         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9788         * python/py-frame.c: Do not include py-ref.h.
9789         * python/py-framefilter.c: Do not include py-ref.h.
9790         * python/py-function.c: Do not include py-ref.h.
9791         * python/py-infevents.c: Do not include py-ref.h.
9792         * python/py-linetable.c: Do not include py-ref.h.
9793         * python/py-objfile.c: Do not include py-ref.h.
9794         * python/py-param.c: Do not include py-ref.h.
9795         * python/py-prettyprint.c: Do not include py-ref.h.
9796         * python/py-progspace.c: Do not include py-ref.h.
9797         * python/py-symbol.c: Do not include py-ref.h.
9798         * python/py-symtab.c: Do not include py-ref.h.
9799         * python/py-type.c: Do not include py-ref.h.
9800         * python/py-unwind.c: Do not include py-ref.h.
9801         * python/py-utils.c: Do not include py-ref.h.
9802         * python/py-value.c: Do not include py-ref.h.
9803         * python/py-varobj.c: Do not include py-ref.h.
9804         * python/py-xmethods.c: Do not include py-ref.h.
9805         * python/python.c: Do not include py-ref.h.
9806         * varobj.c: Do not include py-ref.h.
9807
9808 2019-01-22  Tom Tromey  <tom@tromey.com>
9809
9810         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9811         keyword for bcache.
9812
9813 2019-01-22  Tom Tromey  <tom@tromey.com>
9814
9815         * compile/compile-cplus-types.c: Remove a comment by #include.
9816
9817 2019-01-22  Tom Tromey  <tom@tromey.com>
9818
9819         * compile/gcc-c-plugin.h: Include compile-internal.h.
9820
9821 2019-01-22  Tom Tromey  <tom@tromey.com>
9822
9823         * stabsread.c (EXTERN): Do not define.
9824         (symnum, next_symbol_text_func, processing_gcc_compilation)
9825         (within_function, global_sym_chain, global_stabs)
9826         (previous_stab_code, this_object_header_files)
9827         (n_this_object_header_files)
9828         (n_allocated_this_object_header_files): Define.
9829         * stabsread.h (EXTERN): Never define.  Use "extern".
9830
9831 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9832
9833         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9834         history_value.
9835
9836 2019-01-21  Tom Tromey  <tom@tromey.com>
9837
9838         * ui-out.c: Fix includes.
9839         * tui/tui-source.c: Fix includes.
9840         * target.c: Fix includes.
9841         * remote.c: Fix includes.
9842         * regcache.c: Fix includes.
9843         * python/py-block.c: Fix includes.
9844         * printcmd.c: Fix includes.
9845         * or1k-tdep.c: Fix includes.
9846         * mi/mi-main.c: Fix includes.
9847         * m32r-tdep.c: Fix includes.
9848         * csky-tdep.c: Fix includes.
9849         * compile/compile-cplus-types.c: Fix includes.
9850         * cli/cli-interp.c: Fix includes.
9851
9852 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9853
9854         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9855         for padding.
9856
9857 2019-01-16  Tom Tromey  <tom@tromey.com>
9858
9859         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9860         earlier.
9861         (struct objfile) <msymbols_range>: Move from top level.
9862         <msymbols>: New method.
9863         (class objfile_msymbols): Remove.
9864         * symtab.c (default_collect_symbol_completion_matches_break_on):
9865         Update.
9866         * symmisc.c (dump_msymbols): Update.
9867         * stabsread.c (scan_file_globals): Update.
9868         * objc-lang.c (info_selectors_command, info_classes_command)
9869         (find_methods): Update.
9870         * minsyms.c (find_solib_trampoline_target): Update.
9871         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9872         * coffread.c (coff_symfile_read): Update.
9873         * ada-lang.c (ada_lookup_simple_minsym)
9874         (ada_collect_symbol_completion_matches): Update.
9875
9876 2019-01-16  Tom Tromey  <tom@tromey.com>
9877
9878         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9879         type.  Remove no-argument constructor.
9880         <iterator::operator++>: Simplify.
9881         <begin>: Update.
9882         <end>: Use minimal_symbol_count.
9883
9884 2019-01-16  Tom Tromey  <tom@tromey.com>
9885
9886         * objfiles.h (struct objfile) <psymtabs>: New method.
9887         (class objfile_psymtabs): Remove.
9888         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9889         typedef.
9890         <range>: New method.
9891         (require_partial_symbols): Change return type.
9892         * psymtab.c (require_partial_symbols)
9893         (psym_expand_symtabs_matching): Update.
9894         * mdebugread.c (parse_partial_symbols): Update.
9895         * dbxread.c (dbx_end_psymtab): Update.
9896
9897 2019-01-15  Tom Tromey  <tom@tromey.com>
9898
9899         * symtab.c (lookup_objfile_from_block)
9900         (lookup_symbol_in_objfile_symtabs)
9901         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9902         (find_line_symtab, info_sources_command)
9903         (default_collect_symbol_completion_matches_break_on)
9904         (make_source_files_completion_list): Update.
9905         * symmisc.c (print_objfile_statistics, dump_objfile)
9906         (maintenance_print_symbols, maintenance_info_symtabs)
9907         (maintenance_check_symtabs, maintenance_info_line_tables):
9908         Update.
9909         * source.c (select_source_symtab)
9910         (forget_cached_source_info_for_objfile): Update.
9911         * objfiles.h (class objfile_compunits): Remove.
9912         (struct objfile) <compunits_range>: New typedef.
9913         (compunits): New method.
9914         * objfiles.c (objfile_relocate1): Update.
9915         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9916         * maint.c (count_symtabs_and_blocks): Update.
9917         * linespec.c (iterate_over_all_matching_symtabs): Update.
9918         * cp-support.c (add_symbol_overload_list_qualified): Update.
9919         * coffread.c (coff_symtab_read): Update.
9920         * ada-lang.c (add_nonlocal_symbols)
9921         (ada_collect_symbol_completion_matches)
9922         (ada_add_global_exceptions): Update.
9923
9924 2019-01-15  Tom Tromey  <tom@tromey.com>
9925
9926         * progspace.h (program_space) <objfiles_safe_range>: New
9927         typedef.
9928         <objfiles_safe>: New method.
9929         * objfiles.h (class all_objfiles_safe): Remove.
9930         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9931         * jit.c (jit_inferior_exit_hook): Update.
9932
9933 2019-01-17  Tom Tromey  <tom@tromey.com>
9934
9935         * progspace.h (program_space) <objfiles_range>: New typedef.
9936         <objfiles>: New method.
9937         <objfiles_head>: Rename from objfiles.
9938         (object_files): Update.
9939         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9940         * guile/scm-pretty-print.c
9941         (ppscm_find_pretty_printer_from_objfiles): Update.
9942         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9943         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9944         Update.
9945         * python/py-progspace.c (pspy_get_objfiles): Update.
9946         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9947         Update.
9948         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9949         (objfpy_lookup_objfile_by_build_id): Update.
9950         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9951         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9952         Update.
9953         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9954         (expand_symtab_containing_pc, lookup_objfile_from_block)
9955         (lookup_static_symbol, basic_lookup_transparent_type)
9956         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9957         (find_line_symtab, info_sources_command)
9958         (default_collect_symbol_completion_matches_break_on)
9959         (make_source_files_completion_list, find_main_name): Update.
9960         * symmisc.c (print_symbol_bcache_statistics)
9961         (print_objfile_statistics, maintenance_print_symbols)
9962         (maintenance_print_msymbols, maintenance_print_objfiles)
9963         (maintenance_info_symtabs, maintenance_check_symtabs)
9964         (maintenance_expand_symtabs, maintenance_info_line_tables):
9965         Update.
9966         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9967         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9968         (map_overlay_command, unmap_overlay_command)
9969         (simple_overlay_update, expand_symtabs_matching)
9970         (map_symbol_filenames): Update.
9971         * symfile-debug.c (set_debug_symfile): Update.
9972         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9973         Update.
9974         * source.c (select_source_symtab, forget_cached_source_info):
9975         Update.
9976         * solib.c (solib_read_symbols): Update.
9977         * solib-spu.c (append_ocl_sos): Update.
9978         * psymtab.c (maintenance_print_psymbols)
9979         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9980         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9981         * printcmd.c (info_symbol_command): Update.
9982         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9983         Update.
9984         * objfiles.h (class all_objfiles): Remove.
9985         * objfiles.c (have_partial_symbols, have_full_symbols)
9986         (have_minimal_symbols, qsort_cmp, update_section_map)
9987         (shared_objfile_contains_address_p)
9988         (default_iterate_over_objfiles_in_search_order): Update.
9989         * objc-lang.c (info_selectors_command, info_classes_command)
9990         (find_methods): Update.
9991         * minsyms.c (find_solib_trampoline_target): Update.
9992         * maint.c (maintenance_info_sections)
9993         (maintenance_translate_address, count_symtabs_and_blocks):
9994         Update.
9995         * main.c (captured_main_1): Update.
9996         * linux-thread-db.c (try_thread_db_load_from_pdir)
9997         (has_libpthread): Update.
9998         * linespec.c (iterate_over_all_matching_symtabs)
9999         (search_minsyms_for_name): Update.
10000         * jit.c (jit_find_objf_with_entry_addr): Update.
10001         * hppa-tdep.c (find_unwind_entry)
10002         (hppa_lookup_stub_minimal_symbol): Update.
10003         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10004         Update.
10005         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10006         (elf_gnu_ifunc_resolve_by_got): Update.
10007         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10008         * dwarf-index-write.c (save_gdb_index_command): Update.
10009         * cp-support.c (add_symbol_overload_list_qualified): Update.
10010         * breakpoint.c (create_overlay_event_breakpoint)
10011         (create_longjmp_master_breakpoint)
10012         (create_std_terminate_master_breakpoint)
10013         (create_exception_master_breakpoint): Update.
10014         * blockframe.c (find_pc_partial_function): Update.
10015         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10016         (ada_collect_symbol_completion_matches)
10017         (ada_add_global_exceptions): Update.
10018
10019 2019-01-17  Tom Tromey  <tom@tromey.com>
10020
10021         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10022         declare VEC.
10023         (solib_target_parse_libraries): Change return type.
10024         (library_list_start_segment, library_list_start_section)
10025         (library_list_end_library, library_list_start_library); Update.
10026         (solib_target_free_library_list): Remove.
10027         (solib_target_parse_libraries): Remove cleanup.  Change return
10028         type.
10029         (solib_target_current_sos): Update.
10030
10031 2019-01-17  Tom Tromey  <tromey@bapiya>
10032
10033         * valprint.c: Replace "the the" with "the".
10034         * symtab.c: Replace "the the" with "the".
10035         * solib.c: Replace "the the" with "the".
10036         * solib-dsbt.c: Replace "the the" with "the".
10037         * linespec.c: Replace "the the" with "the".
10038         * dwarf2loc.h: Replace "the the" with "the".
10039         * amd64-windows-tdep.c: Replace "the the" with "the".
10040         * aarch64-tdep.c: Replace "the the" with "the".
10041
10042 2019-01-16  Keith Seitz  <keiths@redhat.com>
10043
10044         PR gdb/23773
10045         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10046         <builder>: Rename to ..
10047         <m_builder>: ... this and make private.
10048         (dwarf2_cu::get_builder): New method.  Change all users of
10049         `builder' to use this method.
10050         (dwarf2_start_symtab): Move to ...
10051         (dwarf2_cu::start_symtab): ... here.  Update all callers
10052         (setup_type_unit_groups): Move to ...
10053         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10054         callers.
10055         (dwarf2_cu::reset_builder): New method.
10056         (process_full_compunit, process_full_type_unit): Use
10057         dwarf2_cu::reset_builder.
10058         (follow_die_offset): Record the ancestor CU if it is different
10059         from the followed DIE's CU.
10060         (follow_die_sig_1): Likewise.
10061
10062 2019-01-15  Tom Tromey  <tom@tromey.com>
10063
10064         * remote.c (class remote_state) <buf>: Now a char_vector.
10065         <buf_size>: Remove.
10066         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10067         parameter.
10068         (remote_target::getpkt_or_notif_sane_1)
10069         (remote_target::getpkt_sane)
10070         (remote_target::getpkt_or_notif_sane): Likewise.
10071         (class remote_target) <putpkt>: New overload.
10072         (remote_target::read_frame): Change type of "buf_p".  Remove
10073         sizeof_p parameter.
10074         (packet_ok): New overload.
10075         (packet_check_result): New overload.
10076         Update all uses.
10077
10078 2019-01-14  Tom Tromey  <tom@tromey.com>
10079
10080         * remote-notif.c (handle_notification, remote_notif_ack)
10081         (remote_notif_parse): Make "buf" const.
10082         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10083         const.
10084         (remote_notif_parse, remote_notif_ack, handle_notification):
10085         Likewise.
10086         * remote.c (remote_notif_stop_parse): Make "buf" const.
10087         (remote_target::remote_parse_stop_reply): Make "buf" const.
10088         (remote_notif_stop_ack): Make "buf" const.
10089
10090 2019-01-14  Tom Tromey  <tom@tromey.com>
10091
10092         * remote.c (remote_console_output): Make parameter const.
10093
10094 2019-01-14  Tom Tromey  <tom@tromey.com>
10095
10096         * target-debug.h (target_debug_print_signals): Constify.
10097         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10098         * procfs.c (procfs_target::pass_signals): Update.
10099         * linux-nat.c (linux_nat_target::pass_signals): Update.
10100         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10101         * target-delegates.c: Rebuild.
10102         * remote.c (remote_target::program_signals): Update.
10103         (remote_target::pass_signals): Update.
10104         * target.c (target_pass_signals): Constify argument.
10105         (target_program_signals): Likewise.
10106         * target.h (struct target_ops) <pass_signals, program_signals>:
10107         Constify argument.
10108         (target_pass_signals, target_program_signals): Constify argument.
10109
10110 2019-01-14  Tom Tromey  <tom@tromey.com>
10111
10112         PR tui/28819:
10113         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10114
10115 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10116
10117         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10118         field.
10119         * rs6000-tdep.c: Include reggroups.h.
10120         (IS_V_ALIAS_PSEUDOREG): Define.
10121         (rs6000_register_name): Return names for the "vX" aliases.
10122         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10123         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10124         aliases.  Call default_register_reggroup_p for all other
10125         pseudo-registers.
10126         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10127         New functions.
10128         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10129         Handle "vX" aliases.
10130         (v_alias_pseudo_register_collect): New function.
10131         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10132         (rs6000_gdbarch_init): Initialize "vX" aliases as
10133         pseudo-registers.  Restore registration of
10134         rs6000_pseudo_register_reggroup_p with
10135         set_tdesc_pseudo_register_reggroup_p.
10136
10137 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10138
10139         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10140         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10141         set_gdbarch_num_pseudo_regs.
10142
10143 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10144
10145         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10146         Remove arg prefixname, add do_set and do_show.
10147         Add member functions set_list and show_list.
10148         * cli/cli-style.c (class cli_style_option): Update accordingly.
10149         (style_set_list): Move to file scope.
10150         (style_show_list): Likewise.
10151         (set_style): Call help_list.
10152         (show_style): Call cmd_show_list.
10153         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10154         Update to use the new macro.
10155
10156 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10157
10158         * ada-lang.c (_initialize_ada_language): Expand the help text
10159         for the "catch exception" command.
10160
10161 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10162
10163         * symtab.c (matching_obj_sections): Initialize obj,
10164         declare it closer to its usage.
10165
10166 2019-01-10  Tom Tromey  <tom@tromey.com>
10167
10168         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10169         (basic_inf_threads_range): Remove.
10170         (inf_threads_range, inf_non_exited_threads_range)
10171         (safe_inf_threads_range): Use next_adapter.
10172
10173 2019-01-10  Keith Seitz  <keiths@redhat.com>
10174
10175         PR gdb/23712
10176         PR symtab/23010
10177         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10178         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10179
10180 2019-01-10  Keith Seitz  <keiths@redhat.com>
10181
10182         PR gdb/23712
10183         PR symtab/23010
10184         * dictionary.c (pending_to_vector): Remove.
10185         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10186         Remove _1 suffix, replacing functions of the same name.  Update
10187         all callers.
10188         (dict_create_hashed, dict_create_hashed_expandable)
10189         (dict_create_linear, dict_create_linear_expandable, dict_free)
10190         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10191         Make functions static.
10192
10193 2019-01-10  Keith Seitz  <keiths@redhat.com>
10194
10195         PR gdb/23712
10196         PR symtab/23010
10197         * dictionary.h (struct dictionary): Replace declaration with
10198         multidictionary.
10199         (dict_create_hashed, dict_create_hashed_expandable)
10200         (dict_create_linear, dict_create_linear_expandable)
10201         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10202         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10203         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10204         taking multidictionary argument.
10205         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10206         * block.h (struct block) <dict>: Change to multidictionary
10207         and rename `multidict'.
10208         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10209         symmisc.c: Update all dictionary references to multidictionary.
10210
10211 2019-01-10  Keith Seitz  <keiths@redhat.com>
10212
10213         PR gdb/23712
10214         PR symtab/23010
10215         * dictionary.c: Include unordered_map.
10216         (pending_to_vector): New function.
10217         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10218         Rewrite the non-"_1" functions to take vector instead
10219         of linked list.
10220         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10221         "new" _1 versions of the same name.
10222         (multidictionary): Define.
10223         (std::hash<enum language): New definition.
10224         (collate_pending_symbols_by_language, mdict_create_hashed)
10225         (mdict_create_hashed_expandable, mdict_create_linear)
10226         (mdict_create_linear_expandable, mdict_free)
10227         (find_language_dictionary, create_new_language_dictionary)
10228         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10229         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10230         (mdict_size, mdict_empty): New functions.
10231         * dictionary.h (mdict_iterator): Define.
10232
10233 2019-01-10  Pedro Alves  <palves@redhat.com>
10234
10235         * breakpoint.c (read_uploaded_action)
10236         (create_tracepoint_from_upload): Adjust to use
10237         gdb::unique_xmalloc_ptr.
10238         * ctf.c (ctf_write_uploaded_tp):
10239         (SET_ARRAY_FIELD): Use emplace_back.
10240         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10241         * tracefile-tfile.c (tfile_write_uploaded_tp):
10242         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10243         gdb::unique_xmalloc_ptr.
10244         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10245         at_string, cond_string, cmd_strings>: Replace char pointers
10246         with gdb::unique_xmalloc_ptr.
10247
10248 2019-01-10  Pedro Alves  <palves@redhat.com>
10249
10250         * solib-target.c (library_list_start_library): Don't xstrdup name.
10251
10252 2019-01-10  Pedro Alves  <palves@redhat.com>
10253
10254         * mdebugread.c (parse_partial_symbols): Use
10255         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10256
10257 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10258
10259         * linux-fork.c (scoped_switch_fork_info)
10260         <~scoped_switch_fork_info>: Fix incorrect variable name.
10261
10262 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10263
10264         * linux-fork.c (scoped_switch_fork_info)
10265         <scoped_switch_fork_info>: Make explicit.
10266         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10267
10268 2019-01-10  Tom Tromey  <tom@tromey.com>
10269
10270         * objfiles.h (objfile::reset_psymtabs): Update.
10271         * objfiles.c (objfile::objfile): Update.
10272         * psymtab.h (psymtab_storage::obstack): Update.
10273         (psymtab_storage::m_obstack): Use gdb::optional.
10274         (class psymtab_storage): Update comment.  Remove objfile
10275         parameter.
10276         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10277
10278 2019-01-10  Tom Tromey  <tom@tromey.com>
10279
10280         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10281         <free_psymtabs>: Now private.
10282         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10283         (allocate_psymtab): Use new method.
10284
10285 2019-01-10  Tom Tromey  <tom@tromey.com>
10286
10287         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10288         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10289         * mdebugread.c (parse_partial_symbols): Use
10290         allocate_dependencies.
10291         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10292         allocate_dependencies.
10293         (process_psymtab_comp_unit_reader)
10294         (build_type_psymtab_dependencies): Likewise.
10295         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10296
10297 2019-01-10  Tom Tromey  <tom@tromey.com>
10298
10299         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10300         PSYMBOL_SET_LANGUAGE.
10301         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10302
10303 2019-01-10  Tom Tromey  <tom@tromey.com>
10304
10305         * psymtab.h (psymtab_storage::obstack): New method.
10306         <m_obstack>: Rename from obstack; now private.
10307         * psymtab.c (psymtab_storage): Update.
10308         * dwarf2read.c (create_addrmap_from_index)
10309         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10310         Update.
10311
10312 2019-01-10  Tom Tromey  <tom@tromey.com>
10313
10314         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10315         * objfiles.h (objfile::reset_psymtabs): New method.
10316
10317 2019-01-10  Tom Tromey  <tom@tromey.com>
10318
10319         * symmisc.c (print_symbol_bcache_statistics): Update.
10320         (print_objfile_statistics): Update.
10321         * symfile.c (reread_symbols): Update.
10322         * psymtab.h (class psymtab_storage): New.
10323         * psymtab.c (psymtab_storage): New constructor.
10324         (~psymtab_storage): New destructor.
10325         (require_partial_symbols): Update.
10326         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10327         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10328         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10329         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10330         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10331         (start_psymtab_common, end_psymtab_common)
10332         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10333         (allocate_psymtab): Update.
10334         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10335         Update.
10336         (dump_psymtab_addrmap, maintenance_print_psymbols)
10337         (maintenance_check_psymtabs): Update.
10338         (class objfile_psymtabs): Move to objfiles.h.
10339         * psympriv.h (discard_psymtab): Now inline.
10340         (psymtab_discarder::psymtab_discarder): Update.
10341         (psymtab_discarder::~psymtab_discarder): Update.
10342         (ALL_OBJFILE_PSYMTABS): Rewrite.
10343         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10344         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10345         Remove fields.
10346         <partial_symtabs>: New field.
10347         (class objfile_psymtabs): Move from psymtab.h.  Update.
10348         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10349         psymbol_cache.
10350         (objfile::~objfile): Don't destroy psymbol_cache.
10351         * mdebugread.c (parse_partial_symbols): Update.
10352         * dwarf2read.c (create_addrmap_from_index)
10353         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10354         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10355         (add_partial_subprogram, dwarf2_ranges_read): Update.
10356         * dwarf-index-write.c (write_address_map)
10357         (write_one_signatured_type, recursively_write_psymbols)
10358         (class debug_names, class debug_names, write_psymtabs_to_index):
10359         Update.
10360
10361 2019-01-10  Tom Tromey  <tom@tromey.com>
10362
10363         * symtab.h (SYMBOL_SET_NAMES): Update.
10364         (symbol_set_names): Update.
10365         (MSYMBOL_SET_NAMES): Update.
10366         * symtab.c (symbol_set_names): Change argument to be an
10367         objfile_per_bfd_storage.
10368         * psymtab.c (add_psymbol_to_bcache): Update.
10369         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10370
10371 2019-01-10  Tom Tromey  <tom@tromey.com>
10372
10373         * symtab.c (create_demangled_names_hash): Change argument to be an
10374         objfile_per_bfd_storage.
10375         (symbol_set_names): Update.
10376
10377 2019-01-10  Tom Tromey  <tom@tromey.com>
10378
10379         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10380         init_psymbol_list.
10381         * psymtab.c (init_psymbol_list): Do nothing if already called.
10382         * psympriv.h (init_psymbol_list): Add comment.
10383         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10384         init_psymbol_list.
10385         * dbxread.c (dbx_symfile_read): Unconditionally call
10386         init_psymbol_list.
10387
10388 2019-01-10  Tom Tromey  <tom@tromey.com>
10389
10390         * xcoffread.c (scan_xcoff_symtab): Update.
10391         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10392         "where".
10393         * mdebugread.c (parse_partial_symbols)
10394         (handle_psymbol_enumerators): Update.
10395         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10396         * dbxread.c (read_dbx_symtab): Update.
10397         * psympriv.h (psymbol_placement): New enum.
10398         (add_psymbol_to_list): Update.
10399
10400 2019-01-10  Tom Tromey  <tom@tromey.com>
10401
10402         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10403         static_psymbols parameters.
10404         (scan_xcoff_symtab): Update.
10405         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10406         static_psymbols parameters.
10407         * psympriv.h (start_psymtab_common): Update.
10408         * mdebugread.c (parse_partial_symbols): Update.
10409         * dwarf2read.c (create_partial_symtab): Update.
10410         * dbxread.c (read_dbx_symtab): Update.
10411         (start_psymtab): Remove global_psymbols and static_psymbols
10412         parameters.
10413
10414 2019-01-10  Tom Tromey  <tom@tromey.com>
10415
10416         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10417         * psymtab.c (allocate_psymtab): Add comment.
10418         * psympriv.h (allocate_psymtab): Add comment.
10419         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10420         initializations.
10421         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10422
10423 2019-01-10  Tom Tromey  <tom@tromey.com>
10424
10425         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10426         Don't declare.
10427         * mipsread.c: Include mdebugread.h.
10428         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10429         Declare.
10430         * elfread.c: Include mdebugread.h.
10431
10432 2019-01-09  Tom Tromey  <tom@tromey.com>
10433
10434         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10435         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10436         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10437         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10438         (psym_lookup_symbol, psym_find_last_source_symtab)
10439         (psym_forget_cached_source_info, psym_print_stats)
10440         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10441         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10442         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10443         (psym_find_compunit_symtab_by_address)
10444         (maintenance_print_psymbols, maintenance_info_psymtabs)
10445         (maintenance_check_psymtabs): Use ranged for.
10446         * psymtab.h (class objfile_psymtabs): New.
10447         (require_partial_symbols): Return objfile_psymtabs.
10448         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10449
10450 2019-01-09  Tom Tromey  <tom@tromey.com>
10451
10452         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10453         (find_pc_mapped_section, list_overlays_command)
10454         (map_overlay_command, unmap_overlay_command)
10455         (simple_overlay_update): Use all_objfiles.
10456         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10457         * printcmd.c (info_symbol_command): Use all_objfiles.
10458         * objfiles.h (ALL_OBJSECTIONS): Remove.
10459         * maint.c (maintenance_translate_address): Use all_objfiles.
10460         * gcore.c (gcore_create_callback): Use all_objfiles.
10461         (objfile_find_memory_regions): Likewise.
10462
10463 2019-01-09  Tom Tromey  <tom@tromey.com>
10464
10465         * symtab.c (find_line_symtab, info_sources_command)
10466         (make_source_files_completion_list): Use objfile_compunits.
10467         * source.c (select_source_symtab): Use objfile_compunits.
10468         * objfiles.h (struct objfile): Update comment.
10469         (ALL_OBJFILES): Remove.
10470         (ALL_FILETABS): Remove.
10471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10472         objfile_compunits.
10473
10474 2019-01-09  Tom Tromey  <tom@tromey.com>
10475
10476         * symmisc.c (print_objfile_statistics, dump_objfile)
10477         (maintenance_print_symbols): Use compunit_filetabs.
10478         * source.c (forget_cached_source_info_for_objfile): Use
10479         compunit_filetabs.
10480         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10481         (ALL_FILETABS): Use compunit_filetabs.
10482         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10483         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10484
10485 2019-01-09  Tom Tromey  <tom@tromey.com>
10486
10487         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10488         (compunit_filetabs): New.
10489         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10490         compunit_filetabs.
10491         (info_sources_command, make_source_files_completion_list): Remove
10492         declaration.
10493         * symmisc.c (print_objfile_statistics, dump_objfile)
10494         (maintenance_print_symbols): Remove declaration.
10495         (maintenance_info_symtabs): Use compunit_filetabs.
10496         (maintenance_info_line_tables): Likewise.
10497         * source.c (select_source_symtab): Change local variable name.
10498         (forget_cached_source_info_for_objfile): Remove declaration.
10499         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10500         * objfiles.c (objfile_relocate1): Remove declaration.
10501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10502         declaration.
10503         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10504         * coffread.c (coff_symtab_read): Remove declaration.
10505         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10506         compunit_filetabs.
10507
10508 2019-01-09  Tom Tromey  <tom@tromey.com>
10509
10510         * symtab.c (lookup_objfile_from_block)
10511         (find_pc_sect_compunit_symtab, search_symbols)
10512         (default_collect_symbol_completion_matches_break_on): Use
10513         objfile_compunits.
10514         * objfiles.h (ALL_COMPUNITS): Remove.
10515         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10516         * cp-support.c (add_symbol_overload_list_qualified): Use
10517         objfile_compunits.
10518         * ada-lang.c (ada_collect_symbol_completion_matches)
10519         (ada_add_global_exceptions): Use objfile_compunits.
10520
10521 2019-01-09  Tom Tromey  <tom@tromey.com>
10522
10523         * source.c (select_source_symtab)
10524         (forget_cached_source_info_for_objfile): Remove declaration.
10525         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10526         declaration.
10527         * maint.c (count_symtabs_and_blocks): Remove declaration.
10528         * cp-support.c (add_symbol_overload_list_qualified): Remove
10529         declaration.
10530         * coffread.c (coff_symtab_read): Remove declaration.
10531         * symtab.c (lookup_symbol_in_objfile_symtabs)
10532         (basic_lookup_transparent_type_1): Use objfile_compunits.
10533         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10534         (info_sources_command, search_symbols)
10535         (default_collect_symbol_completion_matches_break_on)
10536         (make_source_files_completion_list): Remove declaration.
10537         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10538         (ada_collect_symbol_completion_matches)
10539         (ada_add_global_exceptions): Remove declaration.
10540         * linespec.c (iterate_over_all_matching_symtabs): Use
10541         objfile_compunits.
10542         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10543         (class objfile_compunits): New.
10544         (ALL_COMPUNITS): Use objfile_compunits.
10545         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10546         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10547         objfile_compunits.
10548         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10549
10550 2019-01-09  Tom Tromey  <tom@tromey.com>
10551
10552         * symtab.c (search_symbols)
10553         (default_collect_symbol_completion_matches_break_on): Use
10554         objfile_msymbols.
10555         * ada-lang.c (ada_lookup_simple_minsym)
10556         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10557         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10558         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10559         objfile_msymbols.
10560         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10561         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10562         * objc-lang.c (find_methods): Use objfile_msymbols.
10563         (info_selectors_command, info_classes_command): Likewise.
10564         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10565         * objfiles.h (class objfile_msymbols): New.
10566         (ALL_OBJFILE_MSYMBOLS): Remove.
10567         (ALL_MSYMBOLS): Remove.
10568
10569 2019-01-09  Tom Tromey  <tom@tromey.com>
10570
10571         * common/next-iterator.h (next_adapter): Add Iterator template
10572         parameter.
10573         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10574         (class all_objfiles_safe): New.
10575         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10576         * objfiles.c (put_objfile_before): Update comment.
10577         (add_separate_debug_objfile): Likewise.
10578         (free_all_objfiles): Use all_objfiles_safe.
10579         (objfile_purge_solibs): Likewise.
10580
10581 2019-01-09  Tom Tromey  <tom@tromey.com>
10582
10583         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10584         (expand_symtab_containing_pc, lookup_static_symbol)
10585         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10586         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10587         all_objfiles.
10588         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10589         * breakpoint.c (create_overlay_event_breakpoint)
10590         (create_longjmp_master_breakpoint)
10591         (create_std_terminate_master_breakpoint)
10592         (create_exception_master_breakpoint): Use all_objfiles.
10593         * linux-thread-db.c (try_thread_db_load_from_pdir)
10594         (has_libpthread): Use all_objfiles.
10595         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10596         * linespec.c (iterate_over_all_matching_symtabs)
10597         (search_minsyms_for_name): Use all_objfiles.
10598         * maint.c (maintenance_info_sections): Use all_objfiles.
10599         * main.c (captured_main_1): Use all_objfiles.
10600         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10601         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10602         * guile/scm-pretty-print.c
10603         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10604         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10605         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10606         (maintenance_print_msymbols): Use all_objfiles.
10607         * source.c (select_source_symtab): Use all_objfiles.
10608         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10609         * symfile.c (remove_symbol_file_command)
10610         (expand_symtabs_matching, map_symbol_filenames): Use
10611         all_objfiles.
10612         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10613         all_objfiles.
10614         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10615         * objc-lang.c (find_methods): Use all_objfiles.
10616         * objfiles.c (have_partial_symbols, have_full_symbols)
10617         (have_minimal_symbols, qsort_cmp)
10618         (default_iterate_over_objfiles_in_search_order): Use
10619         all_objfiles.
10620         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10621         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10622         (maintenance_check_psymtabs): Use all_objfiles.
10623         (ALL_PSYMTABS): Remove.
10624         * compile/compile-object-run.c (do_module_cleanup): Use
10625         all_objfiles.
10626         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10627         * cp-support.c (add_symbol_overload_list_qualified): Use
10628         all_objfiles.
10629         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10630         Use all_objfiles.
10631         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10632         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10633         all_objfiles.
10634         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10635         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10636         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10637         Uses all_objfiles.
10638         * solib.c (solib_read_symbols): Use all_objfiles
10639
10640 2019-01-09  Tom Tromey  <tom@tromey.com>
10641
10642         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10643         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10644         all_objfiles.
10645         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10646         * symmisc.c (print_symbol_bcache_statistics)
10647         (print_objfile_statistics, maintenance_print_objfiles)
10648         (maintenance_info_symtabs, maintenance_check_symtabs)
10649         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10650         all_objfiles.
10651         * source.c (forget_cached_source_info): Use all_objfiles.
10652         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10653         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10654         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10655         * objfiles.c (update_section_map): Use all_objfiles.
10656         (shared_objfile_contains_address_p): Likewise.
10657         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10658         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10659
10660 2019-01-09  Tom Tromey  <tom@tromey.com>
10661
10662         * common/next-iterator.h: New file.
10663         * objfiles.h (class all_objfiles): New.
10664         (struct objfile_iterator): New.
10665
10666 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10667
10668         * NEWS: Move the description of the changed "frame", "select-frame",
10669          and "info frame" commands to the Changed commands section.
10670
10671 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10672
10673         * gdbtypes.c (check_stub_method_group): Remove handling of old
10674         mangling schemes.
10675         * linespec.c (find_methods): Likewise.
10676         * stabsread.c (read_member_functions): Likewise.
10677         * valops.c (search_struct_method): Likewise.
10678         (value_struct_elt_for_reference): Likewise.
10679         * NEWS: Mention this change.
10680
10681 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10682
10683         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10684         print_source_lines.
10685         * source.c (print_source_lines_base): Update line number check.
10686         (print_source_lines): New function.
10687         (source_lines_range::source_lines_range): New function.
10688         * source.h (class source_lines_range): New class.
10689         (print_source_lines): New declaration.
10690
10691 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10692
10693         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10694
10695 2019-01-08  Tom Tromey  <tom@tromey.com>
10696             Simon Marchi  <simon.marchi@ericsson.com>
10697
10698         PR gdb/24060
10699         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10700         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10701         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10702         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10703         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10704         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10705
10706 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10707
10708         * source.c (select_source_symtab): Move header comment to
10709         declaration in source.h.
10710         (forget_cached_source_info_for_objfile): Likewise.
10711         (forget_cached_source_info): Likewise.
10712         (identify_source_line): Likewise.
10713         * source.h (identify_source_line): Move declaration from symtab.h
10714         and add comment from source.c
10715         (print_source_lines): Likewise.
10716         (forget_cached_source_info_for_objfile): Likewise.
10717         (forget_cached_source_info): Likewise.
10718         (select_source_symtab): Likewise.
10719         (enum print_source_lines_flag): Move definition from symtab.h.
10720         * symtab.h (identify_source_line): Move declaration to source.h.
10721         (print_source_lines): Likewise.
10722         (forget_cached_source_info_for_objfile): Likewise.
10723         (forget_cached_source_info): Likewise.
10724         (select_source_symtab): Likewise.
10725         (enum print_source_lines_flag): Move definition to source.h.
10726         * tui/tui-hooks.c: Add 'source.h' include.
10727
10728 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10729
10730         * source.c (print_source_lines_base): Handle requests to print
10731         reverse line number sequences, and guard against empty lines
10732         string.
10733
10734 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10735
10736         * source.c (print_source_lines_base): Fix skip of '\r' if next
10737         character is '\n'.
10738
10739 2019-01-06  Tom Tromey  <tom@tromey.com>
10740
10741         * c-exp.y (struct c_parse_state) <macro_original_text,
10742         expansion_obstack>: New member.
10743         (macro_original_text, expansion_obstack): Remove globals.
10744         (scan_macro_expansion, scanning_macro_expansion)
10745         (finished_macro_expansion): Update.
10746         (scan_macro_cleanup): Remove.
10747         (yylex, c_parse): Update.
10748
10749 2019-01-06  Tom Tromey  <tom@tromey.com>
10750
10751         * c-exp.y (struct c_parse_state) <strings>: New member.
10752         (operator_stoken): Update.
10753
10754 2019-01-06  Tom Tromey  <tom@tromey.com>
10755
10756         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10757         (union type_stack_elt) <typelist_val>: Now a pointer to
10758         std::vector.
10759         (type_stack_cleanup): Don't declare.
10760         (push_typelist): Update.
10761         * parse.c (pop_typelist): Return a std::vector.
10762         (push_typelist): Take a std::vector.
10763         (follow_types): Update.  Do not free args.
10764         (type_stack_cleanup): Remove.
10765         * c-exp.y (struct c_parse_state): New.
10766         (cpstate): New global.
10767         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10768         (nonempty_typelist): Update.
10769         (func_mod): Create a new vector.
10770         (c_parse): Create a c_parse_state.
10771         (check_parameter_typelist): Do not delete params.
10772         (function_method): Update.  Do not delete type_list.
10773
10774 2019-01-06  Tom Tromey  <tom@tromey.com>
10775
10776         PR gdb/28155:
10777         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10778         check_typedef.
10779         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10780         (print_return_value): Likewise.
10781
10782 2019-01-05  Tom Tromey  <tom@tromey.com>
10783
10784         * contrib/cleanup_check.py: Remove.
10785         * contrib/gcc-with-excheck: Remove.
10786         * contrib/exsummary.py: Remove.
10787         * contrib/excheck.py: Remove.
10788
10789 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10790
10791         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10792         NULL. Initialize tpprev to NULL instead of assigning it
10793         to NULL on the next statement.
10794         * windows-nat.c (windows_delete_thread): Remove check for
10795         main_thread_id before printing thread exit notifications.
10796         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10797         Remove thread ID check against main_thread_id.
10798         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10799         windows_delete_thread.
10800         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10801
10802 2019-01-04  Tom Tromey  <tom@tromey.com>
10803
10804         * compile/compile.c (_initialize_compile): Use upper case for
10805         metasyntactic variables.
10806         * symmisc.c (_initialize_symmisc): Use upper case for
10807         metasyntactic variables.
10808         * psymtab.c (_initialize_psymtab): Use upper case for
10809         metasyntactic variables.
10810         * demangle.c (demangle_command): Use upper case for metasyntactic
10811         variables.
10812         (_initialize_demangler): Likewise.
10813         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10814         variables.
10815
10816 2019-01-03  Tom Tromey  <tom@tromey.com>
10817
10818         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10819
10820 2019-01-03  Tom Tromey  <tom@tromey.com>
10821
10822         * python/py-symtab.c (salpy_str): Update.
10823         (struct salpy_sal_object) <symtab>: Now a PyObject.
10824         (salpy_dealloc): Update.
10825         (del_objfile_sal): Use gdbpy_ref.
10826
10827 2019-01-03  Tom Tromey  <tom@tromey.com>
10828
10829         * python/py-type.c (convert_field): Use new_reference.  Return
10830         gdbpy_ref.
10831         (make_fielditem): Return gdbpy_ref.
10832         (typy_fields): Update.
10833         (typy_getitem): Update.
10834         (field_name): Return gdbpy_ref.  Use new_reference.
10835         (typy_iterator_iternext): Update.
10836
10837 2019-01-03  Tom Tromey  <tom@tromey.com>
10838
10839         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10840
10841 2019-01-03  Tom Tromey  <tom@tromey.com>
10842
10843         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10844         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10845         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10846         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10847         (pspy_set_type_printers): Likewise.
10848         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10849         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10850         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10851         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10852         (objfpy_set_type_printers): Likewise.
10853
10854 2019-01-03  Tom Tromey  <tom@tromey.com>
10855
10856         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10857         (gdbpy_print_stack): Use gdbpy_err_fetch.
10858         * python/python-internal.h (class gdbpy_err_fetch): New class.
10859         (class gdbpy_enter) <m_error_type, m_error_value,
10860         m_error_traceback>: Remove.
10861         <m_error>: New member.
10862         (gdbpy_exception_to_string): Don't declare.
10863         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10864         * python/py-value.c (convert_value_from_python): Use
10865         gdbpy_err_fetch.
10866         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10867         gdbpy_exception_to_string.
10868         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10869         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10870         gdbpy_err_fetch.
10871
10872 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10873
10874         * linux-nat.c (delete_lwp_cleanup): Delete.
10875         (struct lwp_deleter): New struct.
10876         (lwp_info_up): New typedef.
10877         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10878         lwp_info_up.
10879
10880 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10881
10882         * linux-fork.c (class scoped_switch_fork_info): New class.
10883         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10884
10885 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10886
10887         * valops.c (find_overload_match): Remove use of null_cleanup, and
10888         calls to do_cleanups.
10889
10890 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10891
10892         * compile/compile-cplus-types.c
10893         (compile_cplus_instance::decl_name): Handle changes to
10894         cp_func_name.
10895         * cp-support.c (cp_func_name): Update header comment, update
10896         return type.
10897         * cp-support.h (cp_func_name): Update return type in declaration.
10898         * valops.c (find_overload_match): Move temp_func local to top
10899         level of function and change its type.  Use temp_func to hold and
10900         delete temporary string obtained from cp_func_name.
10901
10902 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10903
10904         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10905         gdb::char_vector, remove cleanup, and update uses of `msg`.
10906
10907 2019-01-03  Jim Wilson  <jimw@sifive.com>
10908
10909         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10910
10911 2019-01-02  Tom Tromey  <tom@tromey.com>
10912
10913         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10914         (tdesc_parse_xml): Remove cleanups.
10915         * target-descriptions.h (make_cleanup_free_target_description):
10916         Don't declare.
10917         (target_desc_deleter): New struct.
10918         (target_desc_up): New typedef.
10919         * target-descriptions.c (target_desc_deleter::operator()): Rename
10920         from free_target_description.
10921         (make_cleanup_free_target_description): Remove.
10922
10923 2019-01-02  Tom Tromey  <tom@tromey.com>
10924
10925         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10926         constructor, destructor.
10927         (linespec_parser): Remove typedef.
10928         (~linespec_parser): Rename from linespec_parser_delete.
10929         (linespec_lex_to_end, linespec_complete_label)
10930         (linespec_complete): Update.
10931         (decode_line_full): Remove cleanups.
10932         (decode_line_1): Update.
10933
10934 2019-01-02  Tom Tromey  <tom@tromey.com>
10935
10936         * python/python-internal.h (inferior_to_inferior_object): Change
10937         return type.
10938         * python/py-exitedevent.c (create_exited_event_object): Update.
10939         * python/py-inferior.c (inferior_to_inferior_object): Return
10940         gdbpy_ref.
10941         (python_new_inferior, python_inferior_deleted)
10942         (thread_to_thread_object, delete_thread_object)
10943         (build_inferior_list, gdbpy_selected_inferior): Update.
10944         * python/py-infthread.c (create_thread_object): Update.  Also fail
10945         if inferior_to_inferior_object fails.
10946
10947 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10948
10949         * inferior.h (class inferior) <displaced_step_state>: New field.
10950         * infrun.h (struct displaced_step_state): Move here from
10951         infrun.c.  Initialize fields, add constructor.
10952         <inf>: Remove field.
10953         <reset>: New method.
10954         * infrun.c (struct displaced_step_inferior_state): Move to
10955         infrun.h.
10956         (displaced_step_inferior_states): Remove.
10957         (get_displaced_stepping_state): Adust.
10958         (displaced_step_in_progress_any_inferior): Adjust.
10959         (displaced_step_in_progress_thread): Adjust.
10960         (displaced_step_in_progress): Adjust.
10961         (add_displaced_stepping_state): Remove.
10962         (get_displaced_step_closure_by_addr): Adjust.
10963         (remove_displaced_stepping_state): Remove.
10964         (infrun_inferior_exit): Call displaced_step_state.reset.
10965         (use_displaced_stepping): Don't check for NULL.
10966         (displaced_step_prepare_throw): Call
10967         get_displaced_stepping_state.
10968         (displaced_step_fixup): Don't check for NULL.
10969         (prepare_for_detach): Don't check for NULL.
10970
10971 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10972
10973         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10974          in case of call that did not complete.
10975
10976 2019-01-02  Andrey Utkin  <autkin@undo.io>
10977
10978         * symfile.c (find_separate_debug_file): Fix search of debug files for
10979         remote debuggee.
10980
10981 2019-01-02  Tom Tromey  <tom@tromey.com>
10982
10983         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10984         indentation.
10985         * python/py-frame.c (frapy_older): Remove cast.
10986         (frapy_newer): Likewise.
10987         * python/py-breakpoint.c (local_setattro): Remove cast.
10988         * python/py-arch.c (archpy_name): Remove local variable.
10989         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10990
10991 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10992
10993         * unittests/basic_string_view/element_access/char/empty.cc:
10994         Fix year range in copyright header.
10995
10996 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10997
10998         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10999         Delete.
11000         <operator==>: Update with for removed field.
11001         <hash>: Likewise.
11002         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11003         <isa_features>: ...this.
11004         <abi_features>: New field.
11005         (riscv_isa_flen): Update comment.
11006         (riscv_abi_xlen): New declaration.
11007         (riscv_abi_flen): New declaration.
11008         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11009         isa_features.
11010         (riscv_abi_xlen): New function.
11011         (riscv_isa_flen): Update to get answer from isa_features.
11012         (riscv_abi_flen): New function.
11013         (riscv_has_fp_abi): Update to get answer from abi_features.
11014         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11015         xlen and flen.
11016         (riscv_call_info) <xlen, flen>: Update comment.
11017         (riscv_call_arg_struct): Remove invalid assertions
11018         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11019         is removed.
11020         (riscv_gdbarch_init): Gather isa features and abi features
11021         separately, ensure both match on the gdbarch when reusing an old
11022         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11023         a target with 64-bit float hardware.
11024
11025 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11026
11027         * source.c (search_command_helper): Stop reverse search
11028         when line 1 has been searched.
11029
11030 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11031
11032         * record-full.c (record_full_base_target::close): Rewrite
11033         record_full_core_buf_list free logic.
11034
11035 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11036
11037         * break-catch-syscall.c (print_one_catch_syscall): xfree
11038         the last text.
11039
11040 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11041
11042         * top.c (print_gdb_version): Update Copyright year in version
11043         message.
11044
11045 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11046
11047         Update copyright year range in all GDB files.
11048
11049 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11050
11051         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11052
11053 For older changes see ChangeLog-2018.
11054 \f
11055 Local Variables:
11056 mode: change-log
11057 left-margin: 8
11058 fill-column: 74
11059 version-control: never
11060 coding: utf-8
11061 End:
11062