gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (make_invisible_and_set_new_height)
   4         (make_visible_with_new_height): Call has_locator method.
   5         * tui/tui-layout.c (show_source_disasm_command, show_data)
   6         (show_source_or_disasm_and_command): Update for bool change.
   7         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
   8         (tui_win_info) <has_locator>: New method.
   9         (struct tui_source_window_base) <has_locator>: New method.
  10         (tui_win_has_locator): Don't declare.
  11         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
  12         from tui_win_has_locator.
  13         (tui_source_window_base): Use false, not FALSE.
  14
  15 2019-06-25  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
  18         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
  19         clear_detail method directly.
  20         (tui_clear_win_detail): Remove.
  21
  22 2019-06-25  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
  25         "this", not TUI_DISASM_WIN.
  26
  27 2019-06-25  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
  30         declare.
  31         * tui/tui-winsource.c
  32         (tui_source_window_base::do_scroll_horizontal): Rename from
  33         tui_horizontal_source_scroll.
  34         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
  35         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
  36         from tui_vertical_data_scroll.
  37         * tui/tui-win.h (tui_scroll): Don't declare.
  38         * tui/tui-win.c (tui_win_info::forward_scroll)
  39         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
  40         (tui_win_info::right_scroll): Rename and update.
  41         (tui_scroll_forward_command, tui_scroll_backward_command)
  42         (tui_scroll_left_command, tui_scroll_right_command): Update.
  43         (tui_scroll): Remove.
  44         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
  45         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
  46         from tui_vertical_source_scroll.
  47         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
  48         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
  49         from tui_vertical_disassem_scroll.
  50         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
  51         do_scroll_horizontal>: New methods.
  52         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
  53         Likewise.
  54         (struct tui_source_window_base): Add do_scroll_horizontal.
  55         (struct tui_source_window, struct tui_disasm_window): Add
  56         do_scroll_vertical.
  57         (struct tui_data_window, struct tui_cmd_window): Add
  58         do_scroll_horizontal and do_scroll_vertical.
  59         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
  60
  61 2019-06-25  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-data.h (struct tui_source_window_base): New struct.
  64         (struct tui_source_window): Derive from tui_source_window_base.
  65         (struct tui_disasm_window): New struct.
  66         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
  67         from tui_source_window::clear_detail.
  68         (tui_source_window_base): Rename from tui_source_window.
  69         (~tui_source_window_base): Rename from ~tui_source_window.
  70         (tui_alloc_win_info): Create a tui_disasm_window.
  71
  72 2019-06-25  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-data.h (struct tui_source_window)
  75         (struct tui_data_window): Declare destructors.
  76         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
  77         destructors.
  78         (tui_win_info): Simplify.
  79
  80 2019-06-25  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-winsource.c (tui_display_main)
  83         (tui_update_source_windows_with_addr)
  84         (tui_update_all_breakpoint_info): Update.
  85         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  86         (new_height_ok, parse_scrolling_args): Update.
  87         * tui/tui-stack.c (tui_show_frame_info): Update.
  88         * tui/tui-data.h (struct tui_list): Remove.
  89         (tui_source_windows): Return a reference to a std::vector.
  90         * tui/tui-data.c (source_windows): Now a std::vector.
  91         (tui_source_windows): Change return type.
  92         (tui_clear_source_windows): Rewrite.
  93         (tui_clear_source_windows_detail, tui_add_to_source_windows)
  94         (tui_free_all_source_wins_content): Rewrite.
  95
  96 2019-06-25  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
  99         (struct tui_data_window, struct tui_cmd_window): Declare
 100         clear_detail method.
 101         * tui/tui-data.c (tui_source_window::clear_detail)
 102         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 103         methods.
 104         (tui_clear_win_detail): Simplify.
 105
 106 2019-06-25  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-layout.c (make_source_window, make_disasm_window)
 109         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 110         Return the new window.
 111         (show_source_disasm_command, show_data)
 112         (show_source_or_disasm_and_command): Update.
 113
 114 2019-06-25  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 117         parameter.  Return the new window.
 118         (show_source_disasm_command): Update and remove NULL check.
 119         (show_source_or_disasm_and_command): Update.
 120
 121 2019-06-25  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 124
 125 2019-06-25  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-data.h (struct tui_win_info): Make constructor
 128         protected.  Make destructor virtual.  Add initializers.
 129         (tui_source_window, tui_data_window, tui_cmd_window): New
 130         classes.
 131         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 132         constructor.  Add "type" parameter.
 133         (tui_source_window, tui_data_window, tui_cmd_window): New
 134         constructors.
 135         (tui_alloc_win_info): Instantiate the appropriate subclass.
 136
 137 2019-06-25  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-win.c (tui_resize_all): Use delete.
 140         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 141         destructor.
 142         (tui_free_window): Don't declare.
 143         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 144         Update.
 145
 146 2019-06-25  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-data.h (struct tui_win_info): Add constructor.
 149         * tui/tui-data.c (tui_alloc_win_info): Use new.
 150         (tui_free_window): Use delete.
 151
 152 2019-06-22  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 155         declare.
 156         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 157
 158 2019-06-22  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 161         declare.
 162         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 163
 164 2019-06-22  Tom de Vries  <tdevries@suse.de>
 165
 166         * dwarf2read.c (create_addrmap_from_aranges)
 167         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 168         instead of '%zu'.
 169
 170 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 171
 172         * dwarf2read.h (dwarf2_section_info_def): Remove.
 173         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 174         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 175         std::vector<dwarf2_section_info>.
 176         (struct dwo_file) <~dwo_file>: Remove.
 177         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 178         types field.
 179         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 180         (dwarf2_read_debug_names): Likewise.
 181         (create_debug_types_hash_table): Change parameter type to
 182         array_view, adjust code accordingly.
 183         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 184         (partial_die_info::fixup): Likewise.
 185         (determine_prefix): Likewise.
 186         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 187
 188 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 189
 190         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 191         gdb_bfd_ref_ptr.
 192         <~dwo_file>: Remove call to gdb_bfd_unref.
 193         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 194         gdb_bfd_ref_ptr::get.
 195
 196 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 197
 198         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 199         type to htab_up.
 200         * dwarf2read.c (struct dwo_file): Initialize fields.
 201         <~dwo_file>: New.
 202         (free_dwo_file): Remove, move content to ~dwo_file.
 203         (struct dwo_file_deleter): Remove.
 204         (dwo_file_up>: Remove custom deleter.
 205         (free_dwo_files): Remove.
 206         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 207         dwo_files.
 208         (process_skeletonless_type_units): Call unique_ptr::get.
 209         (allocate_dwo_file_hash_table): Add deleter to created hash
 210         table.  Change return type to htab_up.
 211         (lookup_dwo_file_slot): Don't memset dwo_file, call
 212         unique_ptr::get.
 213         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 214         (create_dwo_unit_in_dwp_v2): Likewise.
 215         (open_and_init_dwo_file): Likewise.
 216         (free_dwo_file_from_slot): Remove.
 217
 218 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 219
 220         * dwarf2read.h (struct dwarf2_section_info) <readin,
 221         is_virtual>: Change type to bool.
 222         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 223         true instead of 1.
 224
 225 2019-06-19  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-data.h (tui_init_content_element): Don't declare.
 228
 229 2019-06-19  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-data.h (tui_init_win_info): Don't declare.
 232
 233 2019-06-19  Tom de Vries  <tdevries@suse.de>
 234
 235         * dwarf2read.h (abstract_to_concrete): Change type to
 236         std::unordered_map<sect_offset, std::vector<sect_offset>,
 237         gdb::hash_enum<sect_offset>>.
 238
 239 2019-06-19  Tom Tromey  <tromey@adacore.com>
 240
 241         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 242         EVAL_AVOID_SIDE_EFFECTS specially.
 243
 244 2019-06-19  Tom Tromey  <tromey@adacore.com>
 245
 246         * source-cache.c (highlighter): New global.
 247         (source_cache::get_source_lines): Create a highlighter on demand.
 248
 249 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 250
 251         * defs.h (deprecated_interactive_hook): Delete declaration.
 252         * interps.c (clear_interpreter_hooks): Remove use of
 253         deprecated_interactive_hook.
 254         * top.c (deprecated_interactive_hook): Delete definition.
 255         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 256
 257 2019-06-18  Tom de Vries  <tdevries@suse.de>
 258
 259         PR gdb/24515
 260         * dwarf2read.h (abstract_to_concrete): Change type from
 261         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 262         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 263         * dwarf2read.c (read_variable): Update.
 264         (dwarf2_fetch_die_loc_sect_off): Update.
 265
 266 2019-06-17  Tom de Vries  <tdevries@suse.de>
 267
 268         PR gdb/24617
 269         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 270         accessing parent[parent_len - 1].
 271
 272 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 273
 274         PR gdb/24364
 275         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 276         call dtrace_process_dof with NULL dof.
 277
 278 2019-06-16  Tom de Vries  <tdevries@suse.de>
 279
 280         PR gdb/24445
 281         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 282
 283 2019-06-16  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 286         (make_all_visible): Use address of member.
 287
 288 2019-06-16  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 291         (tui_free_window, free_content, free_content_elements): Remove
 292         unnecessary cast.
 293         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 294         cast.
 295         * tui/tui-regs.c (tui_show_register_group)
 296         (tui_display_registers_from, tui_display_reg_element_at_line):
 297         Remove unnecessary cast.
 298
 299 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 300
 301         * linux-nat.c (normal_mask): Delete.
 302         (_initialize_linux_nat): Don't initialise normal_mask.
 303
 304 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 305
 306         PR gdb/24445
 307         * dwarf-index-write.h (write_psymtabs_to_index): Add
 308         dwz_basename parameter.
 309         * dwarf-index-write.c (write_gdbindex): Move file writing to
 310         write_gdbindex_1.  Change return type void.
 311         (assert_file_size): Move up, remove filename parameter.
 312         (write_gdbindex_1): New function.
 313         (write_debug_names): Change return type to void, call
 314         assert_file_size.
 315         (struct index_wip_file): New struct.
 316         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 317         file logic to index_wip_file.  Write index for dwz file if
 318         needed.
 319         (save_gdb_index_command): Pass basename of dwz file, if present.
 320         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 321         build-id of dwz file, if present.
 322         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 323         (dwarf2_get_dwz_file): Likewise.
 324         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 325         (dwarf2_get_dwz_file): Likewise.
 326
 327 2019-06-16  Tom Tromey  <tom@tromey.com>
 328
 329         * coffread.c (process_coff_symbol): Use xstrdup.
 330         * value.c (create_internalvar): Use xstrdup.
 331
 332 2019-06-16  Tom Tromey  <tom@tromey.com>
 333
 334         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 335         * breakpoint.c (stopin_command, stopat_command)
 336         (until_break_command, decode_location_default): Remove unnecessary
 337         cast.
 338         * utils.c (subset_compare): Remove unnecessary cast.
 339         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 340         cast.
 341         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 342         cast.
 343         * infcmd.c (path_command): Remove unnecessary cast.
 344         * coffread.c (decode_type): Remove unnecessary cast.
 345         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 346         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 347         * tui/tui-stack.c (tui_show_locator_content)
 348         (tui_show_frame_info): Remove unnecessary cast.
 349         * tui/tui-win.c (tui_scroll_forward_command)
 350         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 351         (parse_scrolling_args): Remove unnecessary cast.
 352         * tui/tui-data.c (init_win_info, tui_del_window)
 353         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 354         (free_content_elements): Remove unnecessary cast.
 355         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 356         unnecessary cast.
 357         * tui/tui-source.c (tui_set_source_content)
 358         (tui_vertical_source_scroll): Remove unnecessary cast.
 359         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 360         cast.
 361         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 362         * tui/tui-regs.c (tui_display_registers_from)
 363         (tui_display_register): Remove unnecessary cast.
 364         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 365         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 366         (make_visible): Remove unnecessary cast.
 367         * tui/tui-winsource.c (tui_erase_source_content)
 368         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 369         unnecessary cast.
 370         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 371         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 372         * stabsread.c (read_type, read_array_type, read_range_type):
 373         Remove unnecessary cast.
 374         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 375         (parse_symbol, parse_type, upgrade_type, parse_external)
 376         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 377         unnecessary cast.
 378         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 379
 380 2019-06-16  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-data.c (tui_alloc_generic_win_info)
 383         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 384         checks.
 385
 386 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 387             Andrew Burgess  <andrew.burgess@embecosm.com>
 388
 389         * f-typeprint.c (f_print_type): Don't return early for not
 390         associated or not allocated types.
 391         (f_type_print_varspec_suffix): Add print_rank parameter and print
 392         ranks of array types in case they dangling.
 393         (f_type_print_base): Add print_rank parameter.
 394
 395 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 396
 397         * NEWS: Mention new MI commands.
 398         * break-catch-throw.c (enum exception_event_kind): Move to
 399         breakpoint.h.
 400         (print_mention_exception_catchpoint): Output text as a single
 401         message.
 402         (catch_exception_command_1): Rename to...
 403         (catch_exception_event): ...this, make non-static, update header
 404         command, and change some parameter types.
 405         (catch_catch_command): Update for changes to
 406         catch_exception_command_1.
 407         (catch_throw_command): Likewise.
 408         (catch_rethrow_command): Likewise.
 409         * breakpoint.c (enum exception_event_kind): Delete.
 410         * breakpoint.h (enum exception_event_kind): Moved here from
 411         break-catch-throw.c.
 412         (catch_exception_event): Declare.
 413         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 414         (mi_cmd_catch_throw): New function.
 415         (mi_cmd_catch_rethrow): New function.
 416         (mi_cmd_catch_catch): New function.
 417         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 418         'catch-catch' entries.
 419         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 420         (mi_cmd_catch_rethrow): Declare.
 421         (mi_cmd_catch_catch): Declare.
 422
 423 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * annotate.c (annotate_source_line): Change return type to void,
 426         update implementation to match.
 427         * annotate.h (annotate_source_line): Change return type to void,
 428         update header comment.
 429         * stack.c (print_frame_info): Don't change what frame information
 430         is printed based on whether annotations are on or not.
 431
 432 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 435         (annotate_source): Make static.
 436         (annotate_source_line): Moved from source.c and renamed from
 437         identify_source_line.  Update the return type.
 438         * annotate.h (annotate_source): Delete declaration.
 439         (annotate_source_line): Declaration moved from source.h, and
 440         renamed from identify_source_line.  Return type updated.
 441         * source.c (identify_source_line): Moved to annotate.c and renamed
 442         to annotate_source_line.
 443         (info_line_command): Remove check of annotation_level.
 444         * source.h (identify_source_line): Move declaration to annotate.h
 445         and rename to annotate_source_line.
 446         * stack.c: Add 'annotate.h' include.
 447         (print_frame_info): Remove check of annotation_level before
 448         calling annotate_source_line.
 449
 450 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 451
 452         * source-cache.c (source_cache::get_plain_source_lines): Use
 453         open_source_file_with_line_charpos instead of just
 454         open_source_file, remove call to find_source_lines.
 455         (source_cache::get_source_lines): Likewise.
 456         * source.c (find_source_lines): Make static.
 457         (get_filename_and_charpos): Renamed into...
 458         (open_source_file_with_line_charpos): ..this along with changes to
 459         return a scoped_fd, and some other minor clean ups.
 460         (identify_source_line): Use open_source_file_with_line_charpos.
 461         (search_command_helper): Use open_source_file_with_line_charpos
 462         instead of just open_source_file, remove call to
 463         find_source_lines.
 464         * source.h (open_source_file_with_line_charpos): Declare new
 465         function.
 466         (find_source_lines): Delete declaration.
 467
 468 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 469
 470         * source.c (get_filename_and_charpos): Remove fullname
 471         parameter.
 472         (identify_source_line): Update call to get_filename_and_charpos.
 473
 474 2019-06-14  Tom Tromey  <tromey@adacore.com>
 475
 476         PR gdb/24502:
 477         * ui-style.h (skip_ansi_escape): Update comment.
 478         * ui-file.h (class no_terminal_escape_file): New class.
 479         * ui-file.c (no_terminal_escape_file::write)
 480         (no_terminal_escape_file::puts): New methods.
 481         * cli/cli-logging.c (handle_redirections): Use
 482         no_terminal_escape_file.
 483
 484 2019-06-14  Tom Tromey  <tromey@adacore.com>
 485
 486         * NEWS: Move convenience variable news above Python news.
 487
 488 2019-06-14  Tom Tromey  <tom@tromey.com>
 489
 490         * gnulib: Move directory to top-level.
 491         * configure.ac: Don't configure gnulib.
 492         * configure: Rebuild.
 493         * common/common-defs.h: Use new path to gnulib.
 494         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 495         (GNULIB_H): Remove.
 496         (INCGNU): Look in new gnulib location.
 497         (HFILES_NO_SRCDIR): Remove gnulib files.
 498         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 499         (generated_files): Remove GNULIB_H.
 500         ($(LIBGNU), all-lib): Remove targets.
 501         (distclean): Don't mention GNULIB_BUILDDIR.
 502         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 503
 504 2019-06-14  Tom Tromey  <tromey@adacore.com>
 505
 506         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 507         Warn if symbol file does not provide any symbols.
 508
 509 2019-06-14  Tom Tromey  <tromey@adacore.com>
 510
 511         * source.c (find_and_open_source): Respect basenames_may_differ.
 512
 513 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * annotate.c (annotate_breakpoints_invalid): Make use of
 516         scoped_restore_terminal_state.
 517         (annotate_frames_invalid): Likewise.
 518
 519 2019-06-14  Tom Tromey  <tromey@adacore.com>
 520
 521         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 522         allow assignment to an internalvar.
 523
 524 2019-06-14  Tom Tromey  <tromey@adacore.com>
 525
 526         * ada-lex.l: Allow "_" in attribute names.
 527
 528 2019-06-14  Tom Tromey  <tromey@adacore.com>
 529
 530         PR gdb/24653:
 531         * regcache.c (registers_changed): Don't call alloca.
 532         * top.c (execute_command): Don't call alloca.
 533
 534 2019-06-13  Pedro Alves  <palves@redhat.com>
 535
 536         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 537         'expression'.  When parsing an expression, error out if there's
 538         junk after "unlimited".
 539         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 540         (do_set_command): Adjust calls to is_unlimited_literal.
 541
 542 2019-06-13  Pedro Alves  <palves@redhat.com>
 543
 544         * compile/compile.c (make_compile_options_def_group): Add braces
 545         around array_view initializer.
 546         * thread.c (make_thread_apply_all_options_def_group)
 547         (make_thread_apply_all_options_def_group): Likewise.
 548
 549 2019-06-13  Pedro Alves  <palves@redhat.com>
 550
 551         * NEWS (New commands): Mention "maint test-options
 552         require-delimiter", "maint test-options unknown-is-error", "maint
 553         test-options unknown-is-operand" and "maint show
 554         test-options-completion-result".
 555         (New command options, command completion): New section.
 556         (Completion improvements): New section.
 557         Mention that you can abbreviate "unlimited".
 558
 559 2019-06-13  Pedro Alves  <palves@redhat.com>
 560
 561         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 562         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 563         * unittests/cli-utils-selftests.c (test_parse_flags)
 564         (test_parse_flags_qcs): Delete.
 565         (test_cli_utils): Don't call deleted functions.
 566
 567 2019-06-13  Pedro Alves  <palves@redhat.com>
 568
 569         * thread.c: Include "cli/cli-option.h".
 570         (tp_array_compar_ascending): Global.
 571         (tp_array_compar): Delete function.
 572         (tp_array_compar_ascending, tp_array_compar_descending): New
 573         functions.
 574         (ascending_option_def, qcs_flag_option_def)
 575         (thr_qcs_flags_option_defs)
 576         (make_thread_apply_all_options_def_group)
 577         (make_thread_apply_options_def_group): New.
 578         (thread_apply_all_command): Use gdb::option::process_options.
 579         (thread_apply_command_completer)
 580         (thread_apply_all_command_completer): New.
 581         (thread_apply_command): Use gdb::option::process_options.
 582         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 583         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 584         to generate help text of "thread apply".  Adjust "taas"'s help.
 585         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 586         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 587
 588 2019-06-13  Pedro Alves  <palves@redhat.com>
 589
 590         * thread.c (thread_apply_command): Check for invalid TID with
 591         isdigit instead of !isalpha.
 592
 593 2019-06-13  Pedro Alves  <palves@redhat.com>
 594
 595         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 596         (validate_flags_qcs): New.
 597         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 598         (validate_flags_qcs): Declare.
 599         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 600         (make_frame_apply_options_def_group): New.
 601         (frame_apply_command_count): Process options with
 602         gdb::option::process_options.
 603         (frame_apply_completer): New.
 604         (frame_apply_level_completer, frame_apply_all_completer)
 605         (frame_apply_completer): New.
 606         (_initialize_stack): Update help of "frame apply", "frame apply
 607         level", "frame apply all" and "faas" to mention supported options
 608         and install command completers.
 609         * stack.h (frame_apply_all_completer): Declare.
 610         * thread.c: Include "stack.h".
 611         (tfaas_command): Add "--".
 612         (_initialize_thread): Update help "tfaas" to mention supported
 613         options and install command completer.
 614
 615 2019-06-13  Pedro Alves  <palves@redhat.com>
 616
 617         * completer.c (complete_nested_command_line): New.
 618         (gdb_completion_word_break_characters_throw): Add assertion.
 619         * completer.h (complete_nested_command_line): Declare.
 620
 621 2019-06-13  Pedro Alves  <palves@redhat.com>
 622
 623         * stack.c (parse_backtrace_qualifiers): New.
 624         (backtrace_command): Use it.
 625         (backtrace_command_completer): Complete on qualifiers.
 626
 627 2019-06-13  Pedro Alves  <palves@redhat.com>
 628
 629         * frame.c: Include "cli/cli-option.h.
 630         (user_set_backtrace_options): New.
 631         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 632         Delete.
 633         (get_prev_frame): Adjust.
 634         (boolean_option_def, uinteger_option_def)
 635         (set_backtrace_option_defs): New.
 636         (_initialize_frame): Adjust and use
 637         gdb::option::add_setshow_cmds_for_options to install "set
 638         backtrace past-main" and "set backtrace past-entry".
 639         * frame.h: Include "cli/cli-option.h".
 640         (struct frame_print_options): Forward declare.
 641         (print_frame_arguments_all, print_frame_arguments_scalars)
 642         (print_frame_arguments_none): Declare.
 643         (print_entry_values): Delete declaration.
 644         (struct frame_print_options, user_frame_print_options): New.
 645         (struct set_backtrace_options): New.
 646         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 647         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 648         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 649         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 650         (list_args_or_locals): Add frame_print_options parameter.
 651         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 652         * python/py-framefilter.c (enumerate_args): Pass down
 653         USER_FRAME_PRINT_OPTIONS.
 654         * stack.c: Include "cli/cli-option.h".
 655         (print_frame_arguments_all, print_frame_arguments_scalars)
 656         (print_frame_arguments_none): Declare.
 657         (print_raw_frame_arguments, print_entry_values): Delete.
 658         (user_frame_print_options): New.
 659         (boolean_option_def, enum_option_def, frame_print_option_defs):
 660         New.
 661         (struct backtrace_cmd_options): New.
 662         (bt_flag_option_def): New.
 663         (backtrace_command_option_defs): New.
 664         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 665         (print_frame_arg, read_frame_arg, print_frame_args)
 666         (print_frame_info, print_frame): Add frame_print_options parameter
 667         and use it.
 668         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 669         (backtrace_command_1): Add frame_print_options and
 670         backtrace_cmd_options parameters and use them.
 671         (make_backtrace_options_def_group): New.
 672         (backtrace_command): Process command options with
 673         gdb::option::process_options.
 674         (backtrace_command_completer): New.
 675         (_initialize_stack): Extend "backtrace"'s help to mention
 676         supported options.  Install completer for "backtrace".
 677         Install some settings commands with add_setshow_cmds_for_options.
 678
 679 2019-06-13  Pedro Alves  <palves@redhat.com>
 680
 681         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 682         and that "set/show print raw frame-arguments" are now deprecated.
 683
 684         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 685         command.
 686         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 687         * stack.c (_initialize_stack): Install "set/show print
 688         raw-frame-arguments", and deprecate "set/show print raw
 689         frame-arguments".
 690         * valprint.c (_initialize_valprint): Deprecate "set/show print
 691         raw".
 692
 693 2019-06-13  Pedro Alves  <palves@redhat.com>
 694
 695         * compile/compile.c (struct compile_options): New.
 696         (compile_flag_option_def, compile_command_option_defs)
 697         (make_compile_options_def_group): New.
 698         (compile_file_command): Handle options with
 699         gdb::option::process_options.
 700         (compile_file_command_completer): New function.
 701         (compile_code_command): Handle options with
 702         gdb::option::process_options.
 703         (compile_code_command_completer): New function.
 704         (_initialize_compiler): Install completers for "compile code" and
 705         "compile file".  Mention available options in "compile code" and
 706         "compile code"'s help.
 707         * completer.c (advance_to_completion_word): New, factored out from
 708         ...
 709         (advance_to_expression_complete_word_point): ... this.
 710         (advance_to_filename_complete_word_point): New.
 711         * completer.h (advance_to_filename_complete_word_point): New
 712         declaration.
 713
 714 2019-06-13  Pedro Alves  <palves@redhat.com>
 715
 716         * compile/compile.c: Include "cli/cli-option.h".
 717         (compile_print_value): Scope data pointer is now a
 718         value_print_options pointer; adjust.
 719         (compile_print_command): Process options.  Scope data pointer is
 720         now a value_print_options pointer; adjust.
 721         (_initialize_compile): Update "compile print"'s help to include
 722         supported options.  Install a completer for "compile print".
 723         * cp-valprint.c (show_vtblprint, show_objectprint)
 724         (show_static_field_print): Delete.
 725         (_initialize_cp_valprint): Don't install "set print
 726         static-members", "set print vtbl", "set print object" here.
 727         * printcmd.c: Include "cli/cli-option.h" and
 728         "common/gdb_optional.h".
 729         (print_command_parse_format): Rework to fill in a
 730         value_print_options instead of a format_data.
 731         (print_value): Change parameter type from format_data pointer to
 732         value_print_options reference.  Adjust.
 733         (print_command_1): Process options.  Adjust to pass down a
 734         value_print_options.
 735         (print_command_completer): New.
 736         (_initialize_printcmd): Install print_command_completer as
 737         handle_brkchars completer for the "print" command.  Update
 738         "print"'s help to include supported options.
 739         * valprint.c: Include "cli/cli-option.h".
 740         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 741         here from cp-valprint.c.
 742         (boolean_option_def, uinteger_option_def)
 743         (value_print_option_defs, make_value_print_options_def_group):
 744         New.  Use gdb::option::add_setshow_cmds_for_options to install
 745         "set print elements", "set print null-stop", "set print repeats",
 746         "set print pretty", "set print union", "set print array", "set
 747         print address", "set print symbol", "set print array-indexes".
 748         * valprint.h: Include <string> and "cli/cli-option.h".
 749         (make_value_print_options_def_group): Declare.
 750         (print_value): Change parameter type from format_data pointer to
 751         value_print_options reference.
 752         (print_command_completer): Declare.
 753
 754 2019-06-13  Pedro Alves  <palves@redhat.com>
 755
 756         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 757         (COMMON_SFILES): Add maint-test-settings.c.
 758         * cli/cli-decode.c (boolean_enums): New global, factored out from
 759         ...
 760         (add_setshow_boolean_cmd): ... here.
 761         * cli/cli-decode.h (boolean_enums): Declare.
 762         * cli/cli-option.c: New file.
 763         * cli/cli-option.h: New file.
 764         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 765         factored out from ...
 766         (parse_cli_boolean_value(const char *)): ... this.
 767         (is_unlimited_literal): Change parameter type to pointer to
 768         pointer.  Adjust and advance ARG pointer.
 769         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 770         (parse_cli_var_enum): New, factored out from ...
 771         (do_set_command): ... this.  Adjust.
 772         * cli/cli-setshow.h (parse_cli_boolean_value)
 773         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 774         (parse_cli_var_enum): Declare.
 775         * cli/cli-utils.c: Include "cli/cli-option.h".
 776         (get_ulongest): New.
 777         * cli/cli-utils.h (get_ulongest): Declare.
 778         (check_for_argument): New overloads.
 779         * maint-test-options.c: New file.
 780
 781 2019-06-13  Pedro Alves  <palves@redhat.com>
 782
 783         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 784         parse a range if "-" is at the end of the string.
 785
 786 2019-06-13  Pedro Alves  <palves@redhat.com>
 787
 788         * cli/cli-setshow.c (parse_auto_binary_operation)
 789         (parse_cli_boolean_value): Don't allow "o".
 790
 791 2019-06-13  Pedro Alves  <palves@redhat.com>
 792
 793         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 794         * NEWS: Mention maint test-settings KIND.
 795         * maint-test-settings.c: New file.
 796
 797 2019-06-13  Pedro Alves  <palves@redhat.com>
 798
 799         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 800         completer.
 801         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 802         "set" completers.
 803
 804 2019-06-13  Pedro Alves  <palves@redhat.com>
 805
 806         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 807         after item.
 808
 809 2019-06-13  Pedro Alves  <palves@redhat.com>
 810
 811         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 812
 813 2019-06-13  Pedro Alves <palves@redhat.com>
 814
 815         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 816         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 817         call.
 818         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 819         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 820         calls.
 821         (check_for_argument): Skip spaces after argument.
 822
 823 2019-06-13  Pedro Alves  <palves@redhat.com>
 824
 825         * thread.c (thread_apply_command): Adjust TID parsing.
 826         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 827         detected before end of string.
 828         (tid_is_in_list): Error out if LIST is invalid.
 829
 830 2019-06-13  Pedro Alves  <palves@redhat.com>
 831
 832         * completer.c (complete_line_internal_1): Rewind completion word
 833         point.
 834         (completion_tracker::advance_custom_word_point_by): Change
 835         parameter type to int.
 836         * completer.h (completion_tracker::advance_custom_word_point_by):
 837         Likewise.
 838
 839 2019-06-13  Pedro Alves  <palves@redhat.com>
 840
 841         * completer.c (advance_to_completion_word): Handle delimiters.
 842
 843 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 844
 845         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 846
 847 2019-06-11  Tom Tromey  <tom@tromey.com>
 848
 849         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 850         (xmalloc_failed): Move to alloc.c.
 851         * alloc.c: New file.
 852         * Makefile.in (COMMON_SFILES): Add alloc.c.
 853
 854 2019-06-11  Tom Tromey  <tom@tromey.com>
 855
 856         * nat/linux-waitpid.c: Don't include server.h.
 857         (linux_debug): Remove.
 858         (my_waitpid): Update.
 859
 860 2019-06-11  Tom Tromey  <tromey@adacore.com>
 861
 862         * infcall.c (_initialize_infcall): Remove trailing newline from
 863         help.
 864         * user-regs.c (_initialize_user_regs): Remove trailing newline
 865         from help.
 866         * typeprint.c (_initialize_typeprint): Remove trailing newline
 867         from help.
 868         * reverse.c (_initialize_reverse): Remove trailing newlines from
 869         help.
 870         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 871         from help.
 872         * language.c (add_set_language_command): Remove trailing newline
 873         from help.
 874         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 875         help.
 876         * disasm.c (_initialize_disasm): Remove trailing newline from
 877         help.
 878         * top.c (init_main): Remove trailing newline from help.
 879         * interps.c (_initialize_interpreter): Remove trailing newline
 880         from help.
 881         * btrace.c (_initialize_btrace): Remove trailing newlines from
 882         help.
 883         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 884         from help.
 885         * python/python.c (_initialize_python): Remove trailing newline
 886         from help.
 887         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 888         help.
 889         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 890         from help.  Reformat some text.
 891         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 892         from help.
 893         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 894         newline from help.
 895
 896 2019-06-11  Tom Tromey  <tromey@adacore.com>
 897
 898         * darwin-nat.c (darwin_decode_exception_message)
 899         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 900
 901 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 902
 903         * valops.c (value_slice): Check for not allocated or not
 904         associated values.
 905
 906 2019-06-10  Tom de Vries  <tdevries@suse.de>
 907
 908         PR gdb/24618
 909         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 910         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 911         invalid.
 912
 913 2019-06-10  Tom de Vries  <tdevries@suse.de>
 914
 915         PR gdb/24611
 916         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 917         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 918
 919 2019-06-10  Tom de Vries  <tdevries@suse.de>
 920
 921         PR symtab/24545
 922         * symtab.c (struct demangled_name_entry): Add language field.
 923         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 924         static minimal symbol".  Set and use language field.
 925
 926 2019-06-10  Tom Tromey  <tromey@adacore.com>
 927
 928         * ada-lang.c (_initialize_ada_language): Update help text.
 929
 930 2019-06-10  Tom Tromey  <tromey@adacore.com>
 931
 932         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 933         with a newline.
 934         * guile/guile.c (handle_boot_error): Don't end warning with a
 935         newline.
 936         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 937         warning with a newline.
 938         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 939         newline.
 940         (s12z_frame_cache): Likewise.
 941         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 942         a newline.
 943         * solib-svr4.c (disable_probes_interface): Don't end warning with
 944         a newline.
 945         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 946         newline.
 947         * python/python.c (do_finish_initialization): Don't end warning
 948         with a newline.
 949
 950 2019-06-10  Tom Tromey  <tom@tromey.com>
 951
 952         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 953         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 954         gdbpy_enter.
 955
 956 2019-06-10  Tom Tromey  <tromey@adacore.com>
 957
 958         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 959         data.
 960         (elf_new_init): Don't call stabsread_new_init.
 961         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 962         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 963         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 964
 965 2019-06-10  Tom de Vries  <tdevries@suse.de>
 966
 967         PR symtab/16264
 968         PR symtab/24517
 969         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 970
 971 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 972
 973         * source.c (find_and_open_source): Also rewrite relative file
 974         names.
 975
 976 2019-04-26  Amos Bird  <amosbird@gmail.com>
 977
 978         * annotate.c (annotate_thread_exited): Add "thread-exited"
 979         annotation.
 980
 981 2019-06-06  Tom Tromey  <tromey@adacore.com>
 982
 983         * maint.h (class scoped_command_stats): Use
 984         DISABLE_COPY_AND_ASSIGN.
 985         <print_time>: New method.
 986         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 987         print_time.
 988         (scoped_command_stats::print_time): New method.
 989
 990 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 993         instructions of lengths 6 or 8 bytes.
 994
 995 2019-06-04  Pedro Alves  <palves@redhat.com>
 996
 997         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 998
 999         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1000         * breakpoint.c (condition_completer): Likewise.
1001         * cli/cli-dump.c (scan_expression): Likewise.
1002         * common/filestuff.c (mkdir_recursive): Likewise.
1003         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1004         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1005         (gdb_abspath): Likewise.
1006         * compile/compile-cplus-types.c
1007         (compile_cplus_instance::decl_name): Likewise.
1008         * completer.c (complete_explicit_location):
1009         (signal_completer, reg_or_group_completer_1): Likewise.
1010         * cp-support.c (cp_remove_params_if_any): Likewise.
1011         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1012         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1013         * infcmd.c (strip_bg_char): Likewise.
1014         * linespec.c (copy_token_string): Likewise.
1015         * mi/mi-main.c (output_cores): Likewise.
1016         * psymtab.c (psymtab_search_name):
1017         * symfile.c (test_set_ext_lang_command): Likewise.
1018         * target.c (target_fileio_read_stralloc): Likewise.
1019         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1020         * value.c (complete_internalvar): Likewise.
1021
1022 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1023
1024         Add objfile property to gdb.Type.
1025         * NEWS: Mention Python API addition.
1026         * python/py-type.c (typy_get_objfile): New method.
1027
1028 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1029
1030         * NEWS: Mention the new set|show style [title|highlight].
1031         Mention changes to "show style", "help" and "apropos".
1032
1033 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1034
1035         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1036         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1037         instead of print_help_for_command.
1038         (print_doc_of_command): New function.
1039         (help_list): Add 'apropos -v word' suggestion.
1040         (print_help_for_command): Style the command name using title style.
1041         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1042         (_initialize_cli_cmds): Describe -v in apropos_command help.
1043
1044 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1045
1046         * cli/cli-style.h (cli_style_option): Add name in constructor,
1047         add m_name class member, add constructor with intensity,
1048         add name class function.
1049         (cli_style_option::add_setshow_commands): Remove name argument.
1050         (highlight_style, title_style): New styles.
1051         * cli/cli-style.c (do_show): New function that shows a style
1052         characteristic styling the style name with itself.
1053         (set_style_name): New function.
1054         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1055         Update all callers according to the changes in cli/cli-style.h.
1056         * utils.h (fputs_highlighted): New function.
1057         * utils.c (fputs_highlighted): Likewise.
1058
1059 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1060
1061         * NEWS: Mention new pipe command and new convenience variables.
1062
1063 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1064
1065         * cli/cli-cmds.c (pipe_command): New function.
1066         (_initialize_cli_cmds): Call add_com for pipe_command.
1067         Define | as an alias for pipe.
1068         (exit_status_set_internal_vars): New function.
1069         (shell_escape): Call exit_status_set_internal_vars.
1070         cli/cli-decode.c (find_command_name_length): Recognize | as
1071         a single character command.
1072
1073 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1074
1075         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1076         top.c (execute_command_to_ui_file): New function, mostly a copy
1077         of execute_command_to_string.
1078         (execute_command_to_string): Implement by calling
1079         execute_command_to_ui_file.
1080
1081 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1082
1083         * top.h (saved_command_line): Remove declaration.
1084         * top.c (previous_saved_command_line, previous_repeat_arguments):
1085         New variables.
1086         (saved_command_line): Make static, define together with other
1087         'repeat variables'.
1088         (dont_repeat): Clear repeat_arguments.
1089         (repeat_previous, get_saved_command_line, save_command_line):
1090         New functions.
1091         (gdb_init): Initialize saved_command_line
1092         and previous_saved_command_line.
1093         * main.c (captured_main_1): Remove saved_command_line initialization.
1094         * event-top.c (handle_line_of_input): Update to use
1095         the new 'repeat' related functions instead of direct access to
1096         saved_command_line.
1097         * command.h (repeat_previous, get_saved_command_line,
1098         save_command_line): New declarations.
1099         (dont_repeat): Add comment.
1100
1101 2019-05-30  Tom Tromey  <tromey@adacore.com>
1102
1103         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1104         Fix comment.
1105         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1106
1107 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1108
1109         PR cli/24587
1110         * completer.c (complete): Initialize variable word.
1111
1112 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1113
1114         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1115         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1116         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1117         'body' is NULL to the outter 'if', protecting the '!is_define'
1118         situation as well.
1119
1120 2019-05-29  Tom Tromey  <tromey@adacore.com>
1121
1122         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1123         (dwarf_unknown): New function.
1124         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1125         (dwarf_type_encoding_name): Use dwarf_unknown.
1126
1127 2019-05-29  Tom Tromey  <tromey@adacore.com>
1128
1129         PR c++/20020:
1130         * cp-valprint.c (cp_print_value_fields): Call
1131         cp_print_static_field inside "try".
1132
1133 2019-05-29  Tom Tromey  <tromey@adacore.com>
1134
1135         * inflow.c (struct terminal_info): Add default operator=.
1136         * configure: Rebuild.
1137         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1138         -Wdeprecated-copy-dtor, -Wredundant-move.
1139
1140 2019-05-29  Tom Tromey  <tromey@adacore.com>
1141
1142         * NEWS: Add entry.
1143         * infcmd.c (print_return_value_1): Handle finish_print
1144         option.
1145         (show_print_finish): New function.
1146         (_initialize_infcmd): Add "set/show print finish" commands.
1147         * valprint.c (user_print_options): Initialize new member.
1148         * valprint.h (struct value_print_options) <finish_print>: New
1149         member.
1150
1151 2019-05-28  Tom Tromey  <tromey@adacore.com>
1152
1153         * ada-lang.c (ada_remove_Xbn_suffix)
1154         (find_old_style_renaming_symbol)
1155         (parse_old_style_renaming): Remove.
1156         (ada_find_renaming_symbol): Don't call
1157         find_old_style_renaming_symbol.
1158         (ada_is_renaming_symbol): Rename from
1159         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1160         bool.  Now static.
1161         (ada_read_var_value): Update and simplify.
1162         * ada-exp.y (write_var_or_type): Remove old code.
1163
1164 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1165
1166         * event-top.c: Remove include comment.
1167         * inflow.c (class scoped_ignore_sigttou): Move from here...
1168         * inflow.h (class scoped_ignore_sigttou): ...to here.
1169         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1170         * top.c:  Remove include comment.
1171
1172 2019-05-27  Tom Tromey  <tom@tromey.com>
1173
1174         * NEWS: Fix typo.
1175
1176 2019-05-22  Tom Tromey  <tromey@adacore.com>
1177
1178         * target.c (target_follow_exec): Constify parameter.
1179         * target-delegates.c: Rebuild.
1180         * remote.c (remote_target::follow_exec): Constify parameter.
1181         * infrun.c (follow_exec): Constify parameter.
1182         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1183         (target_follow_exec): Likewise.
1184
1185 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1186
1187         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1188         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1189
1190 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1191
1192         * NEWS: Add debugredirect and testsuite sections.
1193
1194 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1195
1196         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1197         target descriptions using exclusively floating point register name
1198         aliases.
1199
1200 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         PR gdb/18644:
1203         * f-lang.c (build_fortran_types): Handle the case where
1204         gdbarch_floatformat_for_type returns a nullptr.
1205
1206 2019-05-21  Tom de Vries  <tdevries@suse.de>
1207
1208         PR cli/24587
1209         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1210
1211 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1212
1213         PR gdb/18644:
1214         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1215         16-byte floats.
1216         * i386-tdep.c (i386_floatformat_for_type): Use
1217         floatformats_ia64_quad for the 16-byte floating point component
1218         within a fortran 32-byte complex number.
1219
1220 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1223         delete default constructor.
1224         (find_partial_die): Update to return const struct.
1225         (partial_die_parent_scope): Move variable declaration into scope
1226         of its use and change its type to auto.
1227         (guess_partial_die_structure_name): Likewise.
1228         (partial_die_info::fixup): Likewise.
1229
1230 2019-05-17  Tom Tromey  <tromey@adacore.com>
1231
1232         * source.c (find_and_open_source): Remove cast.
1233
1234 2019-05-17  Tom Tromey  <tromey@adacore.com>
1235
1236         * annotate.c (annotate_source): Make "filename" const.
1237         * annotate.h (annotate_source): Use const.
1238
1239 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1240
1241         * disasm.c (set_disassembler_options): Send errors to stderr.
1242
1243 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1244
1245         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1246         (cli_interp_base::set_logging): Check debug_redirect.
1247         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1248         * cli/cli-logging.c (debug_redirect): Add static variable.
1249         (pop_output_files): Add default param.
1250         (handle_redirections): Print debug setting.
1251         (show_logging_command): Likewise.
1252         (_initialize_cli_logging): Add debugredirect command.
1253         * interps.c (current_interp_set_logging): Add debug_redirect
1254         parameter.
1255         * interps.h (set_logging): Add debug_redirect parameter.
1256         (current_interp_set_logging): Likewise.
1257         * mi/mi-common.h: Likewise.
1258         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1259
1260 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1261             Tom Tromey  <tromey@adacore.com>
1262
1263         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1264         directly.
1265         * cli/cli-interp.h (make_logging_output): Remove declaration.
1266         * cli/cli-logging.c (make_logging_output): Remove function.
1267         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1268         directly.
1269         * ui-file.c (tee_file::tee_file): Remove bools.
1270         (tee_file::~tee_file): Remove deletes.
1271         * ui-file.h (tee_file): Remove bools.
1272
1273 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1274
1275         * mi/mi-cmds.h (mi_cmd_complete): New function.
1276         * mi/mi-main.c (mi_cmd_complete): Likewise.
1277         * mi/mi-cmds.c: Define new MI command -complete.
1278         * NEWS: Mention new -complete command.
1279
1280 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1281
1282         * completer.h (complete): New function.
1283         * completer.c (complete): Likewise.
1284         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1285         function defined in completer.h.
1286
1287 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1288
1289         * MAINTAINERS (Write After Approval): Add myself.
1290
1291 2019-05-17  Tom de Vries  <tdevries@suse.de>
1292
1293         PR gdb/24094
1294         * dwarf2read.c (struct cu_partial_die_info): New struct.
1295         (find_partial_die): Return cu_partial_die_info.
1296         (partial_die_parent_scope, guess_partial_die_structure_name)
1297         (partial_die_info::fixup): Handle new return type of find_partial_die.
1298
1299 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1300
1301         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1302         "std::string", simplifying the algorithm.
1303
1304 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1305
1306         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1307         (stap_static_probe_ops::get_probes): Likewise.
1308
1309 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1310
1311         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1312         '-')" and "else if".
1313         (stap_parse_single_operand): Join checks for
1314         "gdbarch_stap_parse_special_token_p" and
1315         "gdbarch_stap_parse_special_token" in the same "if" statement.
1316         Invert check when verifying for operation on register
1317         displacement.
1318
1319 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1320
1321         * stap-probe.c (stap_get_opcode): Update comment.
1322         (stap_get_expected_argument_type): Likewise.
1323         (handle_stap_probe): Likewise.
1324
1325 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1326
1327         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1328         return type to 'bool'.  Adjust comment.  Use 'bool' when
1329         appropriate.
1330         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1331         * stap-probe.c (stap_parse_argument_1): Likewise.
1332         (stap_is_operator): Likewise.
1333         (stap_is_generic_prefix): Likewise.
1334         (stap_is_register_prefix): Likewise.
1335         (stap_is_register_indirection_prefix): Likewise.
1336         (stap_is_integer_prefix): Likewise.
1337         (stap_generic_check_suffix): Likewise.
1338         (stap_check_integer_suffix): Likewise.
1339         (stap_check_register_suffix): Likewise.
1340         (stap_check_register_indirection_suffix): Likewise.
1341         (stap_parse_register_operand): Likewise.
1342         (stap_parse_single_operand): Likewise.
1343         (stap_parse_argument_1): Likewise.
1344         (stap_probe::get_argument_count): Likewise.
1345         (stap_is_operator): Likewise.
1346
1347 2019-05-16  Tom Tromey  <tromey@adacore.com>
1348
1349         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1350         keyword to foreach.
1351
1352 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1353
1354         * linux-thread-db.c (try_thread_db_load_1): Change return type
1355         to bool.
1356         (try_thread_db_load): Likewise.
1357         (try_thread_db_load_from_pdir_1): Likewise.
1358         (try_thread_db_load_from_pdir): Likewise.
1359         (try_thread_db_load_from_sdir): Likewise.
1360         (try_thread_db_load_from_dir): Likewise.
1361         (thread_db_load_search): Likewise.
1362         (has_libpthread): Likewise.
1363         (thread_db_load): Likewise.
1364
1365 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1366
1367         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1368         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1369         NULL, and complain/return if that's the case.
1370
1371 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1372
1373         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1374         (advance, posn, abstract_read_memory): New functions.
1375         [struct mem_read_abstraction]: New struct.
1376         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1377
1378 2019-05-14  Tom Tromey  <tromey@adacore.com>
1379
1380         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1381         value is not lval_memory.
1382
1383 2019-05-14  Tom Tromey  <tromey@adacore.com>
1384
1385         * solib.c (info_sharedlibrary_command): Style the file name.
1386
1387 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1388
1389         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1390         (aarch64_vnv_type): Likewise.
1391         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1392         * common/tdesc.c: Likewise.
1393         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1394         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1395         * features/aarch64-fpu.xml: Add ieee half view.
1396         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1397         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1398         * gdbtypes.h (struct builtin_type): Likewise.
1399         (struct objfile_type): Likewise.
1400
1401 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1402
1403         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1404         typo.
1405         * location.h (string_to_event_location): Likewise.
1406
1407 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1408
1409         GDB 8.3 released.
1410
1411 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1412
1413         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1414         New variable declaration.
1415         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1416         New variable.
1417         (print_one_breakpoint): Use ui_out::test_flags and new global
1418         variable to compute use_fixed_output.
1419         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1420         Remove.
1421         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1422         (mi_multi_location_breakpoint_output_fixed): Remove.
1423         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1424         new variable.
1425         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1426         fix_multi_location_breakpoint_output flag if version >= 3.
1427         * ui-out.h (enum ui_out_flag)
1428         <fix_multi_location_breakpoint_output>: New enumerator.
1429
1430 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1431
1432         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1433
1434 2019-05-10  Tom Tromey  <tromey@adacore.com>
1435
1436         * ada-lang.c (catch_ada_completer): New function.
1437         (_initialize_ada_language): Use it.
1438
1439 2019-05-10  Tom Tromey  <tromey@adacore.com>
1440
1441         * thread.c (print_thread_info): Make "requested_threads" const.
1442         * gdbthread.h (print_thread_info): Make "requested_threads"
1443         const.
1444         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1445         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1446
1447 2019-05-08  Tom Tromey  <tom@tromey.com>
1448
1449         * gdbtypes.c (objfile_type_data): Change type.
1450         (objfile_type, _initialize_gdbtypes): Update.
1451
1452 2019-05-08  Tom Tromey  <tom@tromey.com>
1453
1454         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1455         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1456         (_initialize_dwarf2_frame): Update.
1457
1458 2019-05-08  Tom Tromey  <tom@tromey.com>
1459
1460         * objc-lang.c (objc_objfile_data): Change type.
1461         (find_methods): Update.
1462         (_initialize_objc_lang): Remove.
1463
1464 2019-05-08  Tom Tromey  <tom@tromey.com>
1465
1466         * stabsread.c (rs6000_builtin_type_data): Change type.
1467         (rs6000_builtin_type, _initialize_stabsread): Update.
1468
1469 2019-05-08  Tom Tromey  <tom@tromey.com>
1470
1471         * mips-tdep.c (mips_pdr_data): Remove.
1472         (_initialize_mips_tdep): Update.
1473
1474 2019-05-08  Tom Tromey  <tom@tromey.com>
1475
1476         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1477         (hppa_init_objfile_priv_data, read_unwind_info)
1478         (find_unwind_entry, _initialize_hppa_tdep): Update.
1479
1480 2019-05-08  Tom Tromey  <tom@tromey.com>
1481
1482         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1483         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1484         on obstack.
1485         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1486
1487 2019-05-08  Tom Tromey  <tom@tromey.com>
1488
1489         * mdebugread.c (basic_type_data): Change type.
1490         (basic_type, _initialize_mdebugread): Update.
1491
1492 2019-05-08  Tom Tromey  <tom@tromey.com>
1493
1494         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1495
1496 2019-05-08  Tom Tromey  <tom@tromey.com>
1497
1498         * nto-tdep.c (nto_inferior_data_reg): Change type.
1499         (nto_inferior_data): Update.
1500         (nto_inferior_data_cleanup, nto_new_inferior_data)
1501         (_initialize_nto_tdep): Remove.
1502         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1503
1504 2019-05-08  Tom Tromey  <tom@tromey.com>
1505
1506         * ada-lang.c (struct ada_inferior_data): Add initializers.
1507         (ada_inferior_data): Change type.
1508         (ada_inferior_data_cleanup): Remove.
1509         (get_ada_inferior_data, ada_inferior_exit)
1510         (struct ada_pspace_data): Add initializers, destructor.
1511         (ada_pspace_data_handle): Change type.
1512         (get_ada_pspace_data): Update.
1513         (ada_pspace_data_cleanup): Remove.
1514
1515 2019-05-08  Tom Tromey  <tom@tromey.com>
1516
1517         * coffread.c (struct coff_symfile_info): Add initializers.
1518         (coff_objfile_data_key): Move lower.  Change type.
1519         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1520         Update.
1521         (coff_free_info): Remove.
1522
1523 2019-05-08  Tom Tromey  <tom@tromey.com>
1524
1525         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1526         (fbsd_pspace_data_handle): Move lower.  Change type.
1527         (get_fbsd_pspace_data): Update.
1528         (fbsd_pspace_data_cleanup): Remove.
1529         (_initialize_fbsd_tdep): Update.
1530
1531 2019-05-08  Tom Tromey  <tom@tromey.com>
1532
1533         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1534         (get_ada_tasks_pspace_data): Update.
1535         (ada_tasks_pspace_data_cleanup): Remove.
1536         (_initialize_tasks): Update.
1537         (ada_tasks_inferior_data_handle): Change type.
1538         (get_ada_tasks_inferior_data): Update.
1539         (ada_tasks_inferior_data_cleanup): Remove.
1540         (struct ada_tasks_pspace_data): Add initializers.
1541
1542 2019-05-08  Tom Tromey  <tom@tromey.com>
1543
1544         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1545         * symfile-debug.c (debug_sym_get_probes): Change type.
1546         * stap-probe.c (handle_stap_probe):
1547         (stap_static_probe_ops::get_probes): Change type.
1548         * probe.h (class static_probe_ops) <get_probes>: Change type.
1549         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1550         (parse_probes_in_pspace): Update.
1551         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1552         Update.
1553         (any_static_probe_ops::get_probes): Change type.
1554         * elfread.c (elfread_data): New typedef.
1555         (probe_key): Change type.
1556         (elf_get_probes): Likewise.  Update.
1557         (probe_key_free): Remove.
1558         (_initialize_elfread): Update.
1559         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1560         Change type.
1561         (dtrace_process_dof_probe, dtrace_process_dof)
1562         (dtrace_static_probe_ops::get_probe): Change type.
1563
1564 2019-05-08  Tom Tromey  <tom@tromey.com>
1565
1566         * xcoffread.c (struct xcoff_symfile_info): Rename from
1567         coff_symfile_info.  Add initializers.
1568         (xcoff_objfile_data_key): Move lower.  Change type.
1569         (XCOFF_DATA): Rewrite.
1570         (xcoff_free_info): Remove.
1571         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1572         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1573         (xcoff_initial_scan): Update.
1574
1575 2019-05-08  Tom Tromey  <tom@tromey.com>
1576
1577         * solib-svr4.c (struct svr4_info): Add initializers and
1578         destructor.
1579         <probes_table>: Now an htab_up.
1580         (solib_svr4_pspace_data): Change type.
1581         (free_probes_table): Simplify.
1582         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1583         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1584         (probes_table_remove_objfile_probes, register_solib_event_probe)
1585         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1586         (_initialize_svr4_solib): Update.
1587
1588 2019-05-08  Tom Tromey  <tom@tromey.com>
1589
1590         * remote.c (remote_pspace_data): Change type.
1591         (remote_pspace_data_cleanup): Remove.
1592         (get_remote_exec_file, set_pspace_remote_exec_file)
1593         (_initialize_remote): Update.
1594
1595 2019-05-08  Tom Tromey  <tom@tromey.com>
1596
1597         * breakpoint.c (breakpoint_objfile_key): Change type.
1598         (get_breakpoint_objfile_data): Update.
1599         (free_breakpoint_objfile_data): Remove.
1600         (_initialize_breakpoint): Update.
1601
1602 2019-05-08  Tom Tromey  <tom@tromey.com>
1603
1604         * linux-tdep.c (struct linux_info): Add initializers.
1605         (linux_inferior_data): Move.  Change type.
1606         (invalidate_linux_cache_inf): Update.
1607         (linux_inferior_data_cleanup): Remove.
1608         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1609
1610 2019-05-08  Tom Tromey  <tom@tromey.com>
1611
1612         * auxv.c (auxv_inferior_data): Move.  Change type.
1613         (auxv_inferior_data_cleanup): Remove.
1614         (invalidate_auxv_cache_inf): Rewrite.
1615         (get_auxv_inferior_data, _initialize_auxv): Update.
1616
1617 2019-05-08  Tom Tromey  <tom@tromey.com>
1618
1619         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1620         (symfile_debug_objfile_data_key): Change type.
1621         (symfile_debug_installed, debug_qf_has_symbols)
1622         (debug_qf_find_last_source_symtab)
1623         (debug_qf_forget_cached_source_info)
1624         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1625         (debug_qf_print_stats, debug_qf_dump)
1626         (debug_qf_expand_symtabs_for_function)
1627         (debug_qf_expand_all_symtabs)
1628         (debug_qf_expand_symtabs_with_fullname)
1629         (debug_qf_map_matching_symbols)
1630         (debug_qf_expand_symtabs_matching)
1631         (debug_qf_find_pc_sect_compunit_symtab)
1632         (debug_qf_map_symbol_filenames)
1633         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1634         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1635         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1636         (debug_sym_read_linetable, debug_sym_relocate): Update.
1637         (symfile_debug_free_objfile): Remove.
1638         (install_symfile_debug_logging, _initialize_symfile_debug):
1639         Update.
1640
1641 2019-05-08  Tom Tromey  <tom@tromey.com>
1642
1643         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1644         allocate_on_obstack.
1645         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1646         (get_dwarf2_per_objfile): Update.
1647         (set_dwarf2_per_objfile): Remove.
1648         (dwarf2_has_info, dwarf2_get_section_info): Update.
1649         (dwarf2_free_objfile): Remove.
1650         (_initialize_dwarf2_read): Update.
1651
1652 2019-05-08  Tom Tromey  <tom@tromey.com>
1653
1654         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1655         initializers.
1656         <unsupported_script_warning_printed,
1657         script_not_found_warning_printed>: Now bool.
1658         (auto_load_pspace_data): Change type.
1659         (~auto_load_pspace_info): Rename from
1660         auto_load_pspace_data_cleanup.
1661         (get_auto_load_pspace_data, init_loaded_scripts_info)
1662         (clear_section_scripts, maybe_print_unsupported_script_warning)
1663         (maybe_print_script_not_found_warning, _initialize_auto_load):
1664         Update.
1665
1666 2019-05-08  Tom Tromey  <tom@tromey.com>
1667
1668         * objfiles.c (objfile_pspace_info): Add destructor and
1669         initializers.
1670         (objfiles_pspace_data): Change type.
1671         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1672         (get_objfile_pspace_data): Update.
1673         (objfiles_bfd_data): Change type.
1674         (get_objfile_bfd_data): Update.
1675         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1676
1677 2019-05-08  Tom Tromey  <tom@tromey.com>
1678
1679         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1680         Change type.
1681         (get_catch_syscall_inferior_data): Update.
1682         (catch_syscall_inferior_data_cleanup): Remove.
1683         (_initialize_break_catch_syscall): Update.
1684
1685 2019-05-08  Tom Tromey  <tom@tromey.com>
1686
1687         * inflow.c (struct terminal_info): Add destructor and
1688         initializers.
1689         (inflow_inferior_data): Change type.
1690         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1691         (get_inflow_inferior_data, inflow_inferior_exit)
1692         (swap_terminal_info, _initialize_inflow): Update.
1693
1694 2019-05-08  Tom Tromey  <tom@tromey.com>
1695
1696         * target-dcache.c (target_dcache_cleanup): Remove.
1697         (target_dcache_aspace_key): Change type.
1698         (target_dcache_init_p, target_dcache_invalidate)
1699         (target_dcache_get, target_dcache_get_or_init)
1700         (_initialize_target_dcache): Update.
1701         * dcache.h (struct dcache_deleter): New.
1702
1703 2019-05-08  Tom Tromey  <tom@tromey.com>
1704
1705         * symtab.c (struct symbol_cache): Add destructor and
1706         initializers.
1707         (symbol_cache_key): Move.  Change type.
1708         (make_symbol_cache, free_symbol_cache): Remove.
1709         (get_symbol_cache): Update.
1710         (symbol_cache_cleanup): Remove.
1711         (ALL_PSPACES, symbol_cache_flush)
1712         (maintenance_print_symbol_cache)
1713         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1714         Update.
1715
1716 2019-05-08  Tom Tromey  <tom@tromey.com>
1717
1718         * symtab.c (struct main_info): Add destructor and initializers.
1719         (main_progspace_key): Move.  Change type.
1720         (get_main_info): Update.
1721         (main_info_cleanup): Remove.
1722         (_initialize_symtab): Update.
1723
1724 2019-05-08  Tom Tromey  <tom@tromey.com>
1725
1726         * registry.h (DECLARE_REGISTRY): Define the _key class.
1727
1728 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1729
1730         * NEWS: Merge two 'New commands' sections.
1731
1732 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1733
1734         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1735         parameter and use Ada language definition instead.
1736         (ada_val_print_ptr): Remove unused language parameter.
1737         (ada_val_print_num): Remove language parameter and use Ada language
1738         definition instead.
1739         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1740         parameter.
1741         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1742         parameter and use Ada language definition instead.
1743         (ada_val_print_1): Update all ada_val_print_xxx calls.
1744         Remove language parameter.
1745         (ada_val_print): Update ada_val_print_1 call.
1746
1747 2019-05-08  Tom Tromey  <tromey@adacore.com>
1748
1749         * remote.c (remote_hw_watchpoint_limit)
1750         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1751         Now static.
1752
1753 2019-05-08  Tom Tromey  <tromey@adacore.com>
1754
1755         * maint.c (_initialize_maint_cmds): Move initialization code to
1756         remote.c.
1757         (watchdog, show_watchdog): Move to remote.c.
1758         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1759         "watchdog" static.
1760         (_initialize_remote): Move initialization code from maint.c.
1761         * defs.h (watchdog): Don't declare.
1762
1763 2019-05-08  Tom Tromey  <tromey@adacore.com>
1764
1765         * tui/tui-interp.c: Include main.h.
1766         * interps.c: Include main.h.
1767         * main.h (interpreter_p): Declare.
1768         * defs.h (interpreter_p): Don't declare.
1769
1770 2019-05-08  Tom Tromey  <tromey@adacore.com>
1771
1772         * dwarf2loc.c: Include dwarf2read.h.
1773         * defs.h (read_unsigned_leb128): Don't declare.
1774         * dwarf2read.h (read_unsigned_leb128): Declare.
1775
1776 2019-05-08  Tom Tromey  <tromey@adacore.com>
1777
1778         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1779         method.
1780
1781 2019-05-08  Tom Tromey  <tromey@adacore.com>
1782
1783         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1784         when no wrap column is set.
1785
1786 2019-05-08  Tom Tromey  <tromey@adacore.com>
1787
1788         * c-lang.c (c_get_string): Handle non-C-style arrays.
1789
1790 2019-05-08  Tom Tromey  <tromey@adacore.com>
1791
1792         * typeprint.c (print_offset_data::update): Print the bit offset,
1793         not the number of bits remaining.
1794
1795 2019-05-08  Tom Tromey  <tromey@adacore.com>
1796
1797         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1798         padding at end of comment.
1799
1800 2019-05-08  Tom Tromey  <tromey@adacore.com>
1801
1802         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1803         Compare main types.
1804
1805 2019-05-06  Tom Tromey  <tom@tromey.com>
1806
1807         * common/scoped_mmap.c: Include common-defs.h.
1808         * common/scoped_mmap.h: Don't include config.h.
1809
1810 2019-05-04  Tom Tromey  <tom@tromey.com>
1811
1812         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1813         (struct aarch64_call_info): Add initializers.
1814         <si>: Now a std::vector.
1815         (pass_on_stack, aarch64_push_dummy_call): Update.
1816
1817 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1818             Tom Tromey  <tom@tromey.com>
1819
1820         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1821         (ppc_threads): Now a std::vector.  Now static.
1822         (hwdebug_find_thread_points_by_tid)
1823         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1824         Update.
1825
1826 2019-05-04  Tom Tromey  <tom@tromey.com>
1827
1828         * arc-tdep.c (arc_tdesc_init): Return bool.
1829
1830 2019-05-04  Tom Tromey  <tom@tromey.com>
1831
1832         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1833         Use gdb_assert_not_reached.
1834
1835 2019-05-04  Tom Tromey  <tom@tromey.com>
1836
1837         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1838         "false".
1839
1840 2019-05-04  Tom Tromey  <tom@tromey.com>
1841
1842         * arc-tdep.c (arc_tdesc_init): Use bool.
1843
1844 2019-05-04  Tom Tromey  <tom@tromey.com>
1845
1846         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1847
1848 2019-05-04  Tom Tromey  <tom@tromey.com>
1849
1850         * cli/cli-cmds.c (valid_command_p): Return bool.
1851
1852 2019-05-04  Tom Tromey  <tom@tromey.com>
1853
1854         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1855         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1856
1857 2019-05-04  Raul Tambre  <raul@tambre.ee>
1858
1859         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1860         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1861         operator for comparison.
1862
1863 2019-05-04  Tom Tromey  <tom@tromey.com>
1864
1865         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1866         (lookup_partial_symbol, print_partial_symbols)
1867         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1868         (psymbol_compare): Update.
1869         (add_psymbol_to_bcache): Clear the entire psymbol.
1870         (maintenance_check_psymtabs): Update.
1871         * psympriv.h (struct partial_symbol): Don't derive from
1872         general_symbol_info.
1873         <obj_section, unrelocated_address, address,
1874         set_unrelocated_address>: Update.
1875         <ginfo>: New member.
1876         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1877         (debug_names::write_psymbols): Update.
1878
1879 2019-05-04  Tom de Vries  <tdevries@suse.de>
1880
1881         * contrib/cc-with-tweaks.sh: Support -n arg.
1882
1883 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1884
1885         * corelow.c (core_target::detach): Ensure frame cache and
1886         register caches are cleared.
1887         inferior.c (exit_inferior_1): Likewise.
1888
1889 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1890             Tom Tromey  <tom@tromey.com>
1891
1892         * dictionary.c (collate_pending_symbols_by_language): Remove
1893         "struct" from foreach.
1894         * symtab.c (lookup_global_symbol_from_objfile)
1895         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1896         foreach.
1897         * ser-tcp.c (net_open): Remove "struct" from foreach.
1898         * objfiles.c (objfile_relocate, objfile_rebase)
1899         (objfile_has_symbols): Remove "struct" from foreach.
1900         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1901         from foreach.
1902         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1903         foreach.
1904         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1905         "struct" from foreach.
1906         * ada-lang.c (create_excep_cond_exprs)
1907         (ada_exception_catchpoint_cond_string): Remove "struct" from
1908         foreach.
1909
1910 2019-05-03  Tom Tromey  <tromey@adacore.com>
1911
1912         * ada-exp.y (convert_char_literal): Check suffix of each
1913         enumerator.
1914
1915 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1916
1917         PR ada/21406:
1918         * ada-exp.y (yywrap): Don't define.
1919         * ada-lex.l (%option): Add noyywrap
1920         (yywrap): Remove.
1921
1922 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1923
1924         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1925         _WIN32_WINNT to the XP level, unless already defined to a higher
1926         level.
1927
1928         * unittests/parse-connection-spec-selftests.c:
1929         * ser-tcp.c:
1930         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1931         override.
1932
1933         * symfile.c (find_separate_debug_file): Remove colon from the
1934         drive spec of DOS/Windows file names of the target, so that the
1935         file name produced from DEBUGDIR and the target's directory will
1936         be valid on DOS/Windows systems.
1937
1938 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * rust-lang.c (val_print_struct): Handle printing structures
1941         containing strings.
1942
1943 2019-05-02  Tom Tromey  <tromey@adacore.com>
1944
1945         * valarith.c (_initialize_valarith): Remove.
1946
1947 2019-05-01  Tom Tromey  <tromey@adacore.com>
1948
1949         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1950         bitfields.
1951
1952 2019-05-01  Tom Tromey  <tromey@adacore.com>
1953
1954         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1955         for big-endian copies.
1956
1957 2019-04-30  Ali Tamur  <tamur@google.com>
1958         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1959         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1960         (read_3_bytes): New function.
1961
1962 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1963
1964         * windows-nat.c (main_thread_id): Delete.
1965         (handle_output_debug_string): Replace main_thread_id by
1966         current_event.dwThreadId.
1967         (fake_create_process): Likewise.
1968         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1969         Do not set main_thread_id.
1970         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1971         current_event.dwThreadId.
1972         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1973
1974 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1975
1976         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1977         Use current_event.dwThreadId instead of main_thread_id.
1978
1979 2019-04-30  Tom Tromey  <tromey@adacore.com>
1980
1981         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1982         (create_excep_cond_exprs): Iterate over program spaces.
1983         (ada_exception_catchpoint_cond_string): Examine all minimal
1984         symbols for exception types.
1985
1986 2019-04-30  Tom Tromey  <tromey@adacore.com>
1987
1988         PR c++/24470:
1989         * dwarf2read.c (process_structure_scope): Handle case where type
1990         has template parameters but no symbol was created.
1991
1992 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1993             Chris January  <chris.january@arm.com>
1994
1995         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1996         qualifier.
1997         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1998
1999 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2000
2001         * f-typeprint.c (f_print_type): Update rules for printing
2002         whitespace.
2003         (f_type_print_varspec_suffix): Likewise.
2004
2005 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2006             Chris January  <chris.january@arm.com>
2007
2008         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2009         function arguments.
2010
2011 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * f-lang.c (build_fortran_types): Change name of void type to
2014         lower case.
2015         * f-typeprint.c (f_type_print_base): Print the name of the void
2016         type, rather than a fixed string.
2017         * f-valprint.c (f_decorations): Use lower case void string.
2018
2019 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2020             Chris January  <chris.january@arm.com>
2021
2022         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2023         types for Fortran.
2024
2025 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2026             Chris January  <chris.january@arm.com>
2027             David Lecomber  <david.lecomber@arm.com>
2028
2029         * f-exp.y (BINOP_INTRINSIC): New token.
2030         (exp): New parser rule handling BINOP_INTRINSIC.
2031         (f77_keywords): Add new builtin procedures.
2032         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2033         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2034         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2035         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2036         (print_unop_subexp_f): New function.
2037         (print_binop_subexp_f): New function.
2038         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2039         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2040         (dump_subexp_body_f): Likewise.
2041         (operator_check_f): Likewise.
2042         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2043         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2044
2045 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2046
2047         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2048         UNOP_KIND.
2049         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2050         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2051         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2052         (operator_length_f): New fuction.
2053         (print_subexp_f): New function.
2054         (op_name_f): New function.
2055         (dump_subexp_body_f): New function.
2056         (operator_check_f): New function.
2057         (exp_descriptor_f): Replace standard expression handling functions
2058         with new functions.
2059         * gdb/fortran-operator.def: New file.
2060         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2061         * gdb/std-operator.def: Remove UNOP_KIND.
2062
2063 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2064
2065         * std-operator.def: Remove unbalanced, stray double quote
2066         character.
2067
2068 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2069             Chris January  <chris.january@arm.com>
2070             Daniel Everett  <daniel.everett@arm.com>
2071             Nick Forrington  <nick.forrington@arm.com>
2072             Richard Bunt  <richard.bunt@arm.com>
2073
2074         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2075         of depth when printing anonymous structs or unions.
2076         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2077         Don't print either the top-level value, or the children if the
2078         max-depth is exceeded.
2079         (ppscm_print_children): When printing the key of a map, allow one
2080         extra level of depth.
2081         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2082         print either the top-level value, or the children if the max-depth
2083         is exceeded.
2084         (print_children): When printing the key of a map, allow one extra
2085         level of depth.
2086         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2087         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2088         (user_print_options): Initialise max_depth field.
2089         (val_print_scalar_or_string_type_p): New function.
2090         (val_print): Check to see if the max depth has been reached.
2091         (val_print_check_max_depth): Define new function.
2092         (show_print_max_depth): New function.
2093         (_initialize_valprint): Add 'print max-depth' option.
2094         * valprint.h (struct value_print_options) <max_depth>: New field.
2095         (val_print_check_max_depth): Declare new function.
2096         * NEWS: Document new feature.
2097
2098 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * ada-lang.c (ada_language_defn): Initialise new field.
2101         * c-lang.c (c_is_string_type_p): New function.
2102         (c_language_defn): Initialise new field.
2103         (cplus_language_defn): Initialise new field.
2104         (asm_language_defn): Initialise new field.
2105         (minimal_language_defn): Initialise new field.
2106         * c-lang.h (c_is_string_type_p): Declare new function.
2107         * d-lang.c (d_language_defn): Initialise new field.
2108         * f-lang.c (f_is_string_type_p): New function.
2109         (f_language_defn): Initialise new field.
2110         * go-lang.c (go_is_string_type_p): New function.
2111         (go_language_defn): Initialise new field.
2112         * language.c (default_is_string_type_p): New function.
2113         (unknown_language_defn): Initialise new field.
2114         (auto_language_defn): Initialise new field.
2115         * language.h (struct language_defn) <la_is_string_type_p>: New
2116         member variable.
2117         (default_is_string_type_p): Declare new function.
2118         * m2-lang.c (m2_language_defn): Initialise new field.
2119         * objc-lang.c (objc_language_defn): Initialise new field.
2120         * opencl-lang.c (opencl_language_defn): Initialise new field.
2121         * p-lang.c (pascal_is_string_type_p): New function.
2122         (pascal_language_defn): Initialise new field.
2123         * rust-lang.c (rust_is_string_type_p): New function.
2124         (rust_language_defn): Initialise new field.
2125
2126 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2127
2128         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2129         New field.
2130         * ada-lang.c (ada_language_defn): Initialise new field.
2131         * c-lang.c (c_language_defn): Likewise.
2132         (cplus_language_defn): Likewise.
2133         (asm_language_defn): Likewise.
2134         (minimal_language_defn): Likewise.
2135         * d-lang.c (d_language_defn): Likewise.
2136         * f-lang.c (f_language_defn): Likewise.
2137         * go-lang.c (go_language_defn): Likewise.
2138         * language.c (unknown_language_defn): Likewise.
2139         (auto_language_defn): Likewise.
2140         * m2-lang.c (m2_language_defn): Likewise.
2141         * objc-lang.c (objc_language_defn): Likewise.
2142         * opencl-lang.c (opencl_language_defn): Likewise.
2143         * p-lang.c (pascal_language_defn): Likewise.
2144         * rust-lang.c (rust_language_defn): Likewise.
2145
2146 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * ada-lang.c (ada_is_character_type): Change return type to bool.
2149         (ada_is_string_type): Likewise.
2150         * ada-lang.h (ada_is_character_type): Update declaration
2151         (ada_is_string_type): Likewise.
2152
2153 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2154
2155         Support style in 'frame|thread apply'
2156
2157         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2158         * record.c (record_start, record_stop): Update callers of
2159         execute_command_to_string with false.
2160         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2161         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2162         methods.
2163         (class string_file): New constructor with term_out parameter.
2164         Override methods term_out and can_emit_style_escape.  New member
2165         term_out.
2166         (class stdio_file): Override can_emit_style_escape.
2167         (class tee_file): Override term_out and can_emit_style_escape.
2168         * utils.h (can_emit_style_escape): Remove.
2169         * utils.c (can_emit_style_escape): Likewise.
2170         Update all callers of can_emit_style_escape (SOMESTREAM) to
2171         SOMESTREAM->can_emit_style_escape.
2172         * source-cache.c (source_cache::get_source_lines): Likewise.
2173         * stack.c (frame_apply_command_count): Call execute_command_to_string
2174         passing the term_out characteristic of the current gdb_stdout.
2175         * thread.c (thr_try_catch_cmd): Likewise.
2176         * top.c (execute_command_to_string): pass term_out parameter
2177         to construct the string_file for the command output.
2178         * ui-file.c (term_cli_styling): New function (most code moved
2179         from utils.c can_emit_style_escape).
2180         (string_file::string_file, string_file::can_emit_style_escape,
2181         stdio_file::can_emit_style_escape, tee_file::term_out,
2182         tee_file::can_emit_style_escape): New functions.
2183
2184 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2185
2186         * NEWS: Mention the new set|show may-call-functions.
2187         * infcall.c (may_call_functions_p): New variable.
2188         (show_may_call_functions_p): New function.
2189         (call_function_by_hand_dummy): Throws an error if not
2190         may-call-functions.
2191         (_initialize_infcall): Call add_setshow_boolean_cmd for
2192         may-call-functions.
2193
2194 2019-04-25  Keith Seitz  <keiths@redhat.com>
2195
2196         PR c++/24367
2197         * cp-support.c (inspect_type): Don't attempt substitutions
2198         of symbol with the same name.
2199
2200 2019-04-25  Tom Tromey  <tromey@adacore.com>
2201
2202         PR gdb/24475:
2203         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2204         static.
2205
2206 2019-04-25  Tom Tromey  <tromey@adacore.com>
2207
2208         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2209         rvalue reference.
2210         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2211         (gdb_xml_parser::parse): Use std::move.
2212         * python/python-internal.h (gdbpy_convert_exception): Take a const
2213         reference.
2214         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2215         std::move.
2216         * python/py-utils.c (gdbpy_convert_exception): Take a const
2217         reference.
2218         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2219         Use std::move.
2220         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2221         Use std::move.
2222         * mi/mi-main.c (mi_print_exception): Take a const reference.
2223         * main.c (handle_command_errors): Take a const reference.
2224         * linespec.c (parse_linespec): Use std::move.
2225         * infcall.c (run_inferior_call): Use std::move.
2226         (call_function_by_hand_dummy): Use std::move.
2227         * exec.c (try_open_exec_file): Use std::move.
2228         * exceptions.h (exception_print, exception_fprintf)
2229         (exception_print_same): Update.
2230         * exceptions.c (print_exception, exception_print)
2231         (exception_fprintf, exception_print_same): Change parameters to
2232         const reference.
2233         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2234         * common/new-op.c: Use std::move.
2235         * common/common-exceptions.h (struct gdb_exception): Add move
2236         constructor.
2237         (struct gdb_exception_error, struct gdb_exception_quit, struct
2238         gdb_quit_bad_alloc): Change constructor to move constructor.
2239         (throw_exception): Change parameter to rvalue reference.
2240         * common/common-exceptions.c (throw_exception): Take rvalue
2241         reference.
2242         * cli/cli-interp.c (safe_execute_command): Use std::move.
2243         * breakpoint.c (insert_bp_location, location_to_sals): Use
2244         std::move.
2245
2246 2019-04-25  Tom Tromey  <tromey@adacore.com>
2247
2248         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2249         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2250         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2251         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2252         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2253         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2254         guile/scm-value.c: Use unpack.
2255         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2256         gdbscm_gdb_exception.
2257         (gdbscm_throw_gdb_exception): Likewise.
2258         (struct gdbscm_gdb_exception): New.
2259         (unpack): New function.
2260         (gdbscm_wrap): Use unpack.
2261
2262 2019-04-25  Tom Tromey  <tromey@adacore.com>
2263
2264         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2265         (gdb_rl_callback_handler): Use std::move.
2266         * common/common-exceptions.h (struct gdb_exception): Add move
2267         assignment operator.
2268         (throw_exception_sjlj): Change "exception" to const reference.
2269         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2270         (throw_exception_sjlj): Change "exception" to const reference.
2271
2272 2019-04-25  Tom Tromey  <tromey@adacore.com>
2273
2274         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2275         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2276         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2277         Update.
2278         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2279         Update.
2280         * mi/mi-interp.c (mi_interp::exec): Update.
2281         * linespec.c (parse_linespec): Update.
2282         * infcall.c (run_inferior_call): Update.
2283         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2284         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2285         (gdbscm_lookup_global_symbol): Update.
2286         * guile/scm-param.c (gdbscm_parameter_value): Update.
2287         * guile/scm-frame.c (gdbscm_frame_read_register)
2288         (gdbscm_frame_read_var): Update.
2289         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2290         * exec.c (try_open_exec_file): Update.
2291         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2292         (gdb_rl_callback_handler): Update.
2293         * common/common-exceptions.h (exception_none): Don't declare.
2294         * common/common-exceptions.c (exception_none): Don't define.
2295         (struct catcher) <exception>: Update.
2296         * cli/cli-interp.c (safe_execute_command): Update.
2297         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2298
2299 2019-04-25  Ali Tamur  <tamur@google.com>
2300
2301         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2302         (read_attribute_value): Likewise.
2303         (dwarf2_read_addr_index): Update comment.
2304         (read_str_index): Add DW_FORM_strx.
2305         (dwarf2_string_attr): Likewise.
2306         (dwarf2_const_value_attr): Likewise.
2307         (dump_die_shallow): Likewise.
2308         (dwarf2_fetch_constant_bytes): Likewise.
2309         (skip_form_bytes): Likewise.
2310         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2311
2312 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2313
2314         PR corefiles/11608
2315         PR corefiles/18187
2316         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2317         OFFSET.  Verify if current mapping contains an ELF header.
2318         (linux_find_memory_regions_full): Adjust call to
2319         dump_mapping_p.
2320
2321 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2322             Kang Li <kanglictf@gmail.com>
2323
2324         PR gdb/21600
2325
2326         * dwarf2-frame.c (read_initial_length): Be consistent about using
2327         unsigned representation of length.
2328         (decode_frame_entry_1): Likewise.  Check for wraparound of
2329         end pointer as well as buffer overflow.
2330
2331 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2332
2333         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2334         "vq".
2335
2336 2019-04-24  Tom Tromey  <tromey@adacore.com>
2337
2338         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2339
2340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2341
2342         * s12z-tdep.c (s12z_unwind_pc): Delete.
2343         (s12z_unwind_sp): Delete.
2344         (s12z_gdbarch_init): Don't register deleted functions with
2345         gdbarch.
2346
2347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * rl78-tdep.c (rl78_unwind_sp): Delete.
2350         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2351
2352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2353
2354         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2355         (xstormy16_unwind_pc): Delete.
2356         (xstormy16_dummy_id): Delete.
2357         (xstormy16_gdbarch_init): Don't register deleted functions with
2358         gdbarch.
2359
2360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * vax-tdep.c (vax_unwind_pc): Delete.
2363         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2364
2365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2366
2367         * v850-tdep.c (v850_unwind_sp): Delete.
2368         (v850_unwind_pc): Delete.
2369         (v850_dummy_id): Delete.
2370         (v850_gdbarch_init): Don't register deleted functions with
2371         gdbarch.
2372
2373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2374
2375         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2376         (tilegx_unwind_pc): Delete.
2377         (tilegx_unwind_dummy_id): Delete.
2378         (tilegx_gdbarch_init): Don't register deleted functions with
2379         gdbarch.
2380
2381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2384         (tic6x_dummy_id): Delete.
2385         (tic6x_gdbarch_init): Don't register deleted functions with
2386         gdbarch.
2387
2388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2389
2390         * sparc-tdep.c (sparc_unwind_pc): Delete.
2391         (sparc32_gdbarch_init): Don't register deleted function with
2392         gdbarch.
2393
2394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * sh-tdep.c (sh_unwind_sp): Delete.
2397         (sh_unwind_pc): Delete.
2398         (sh_dummy_id): Delete.
2399         (sh_gdbarch_init): Don't register deleted functions with
2400         gdbarch.
2401
2402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * score-tdep.c (score_unwind_sp): Delete.
2405         (score_unwind_pc): Delete.
2406         (score_dummy_id): Delete.
2407         (score_gdbarch_init): Don't register deleted functions with
2408         gdbarch.
2409
2410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2411
2412         * rx-tdep.c (rx_unwind_pc): Delete.
2413         (rx_unwind_sp): Delete.
2414         (rx_dummy_id): Delete.
2415         (rx_gdbarch_init): Don't register deleted functions with
2416         gdbarch.  Update comment.
2417
2418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2421         (rs6000_dummy_id): Delete.
2422         (rs6000_gdbarch_init): Don't register deleted functions with
2423         gdbarch.
2424
2425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2426
2427         * or1k-tdep.c (or1k_dummy_id): Delete.
2428         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2429
2430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * nios2-tdep.c (nios2_dummy_id): Delete.
2433         (nios2_unwind_sp): Delete.
2434         (nios2_gdbarch_init): Don't register deleted functions with
2435         gdbarch.
2436
2437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * nds32-tdep.c (nds32_dummy_id): Delete.
2440         (nds32_unwind_pc): Delete.
2441         (nds32_unwind_sp): Delete.
2442         (nds32_gdbarch_init): Don't register deleted functions with
2443         gdbarch.
2444
2445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2446
2447         * msp430-tdep.c (msp430_unwind_pc): Delete.
2448         (msp430_unwind_sp): Delete.
2449         (msp430_dummy_id): Delete.
2450         (msp430_gdbarch_init): Don't register deleted functions with
2451         gdbarch.
2452
2453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * moxie-tdep.c (moxie_unwind_sp): Delete.
2456         (moxie_unwind_pc): Delete.
2457         (moxie_dummy_id): Delete.
2458         (moxie_gdbarch_init): Don't register deleted functions with
2459         gdbarch.
2460
2461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2464         (mn10300_unwind_pc): Delete.
2465         (mn10300_unwind_sp): Delete.
2466         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2467         mn10300_unwind_sp.
2468         (mn10300_frame_unwind_init): Don't register deleted functions with
2469         gdbarch.
2470
2471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2472
2473         * mep-tdep.c (mep_unwind_pc): Delete.
2474         (mep_unwind_sp): Delete.
2475         (mep_dummy_id): Delete.
2476         (mep_gdbarch_init): Don't register deleted functions with
2477         gdbarch.
2478
2479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2482         (m68hc11_unwind_sp): Delete.
2483         (m68hc11_gdbarch_init): Don't register deleted functions with
2484         gdbarch.
2485
2486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * m32r-tdep.c (m32r_unwind_sp): Delete.
2489         (m32r_unwind_pc): Delete.
2490         (m32r_dummy_id): Delete.
2491         (m32r_gdbarch_init): Don't register deleted functions with
2492         gdbarch.
2493
2494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * m32c-tdep.c (m32c_unwind_pc): Delete.
2497         (m32c_unwind_sp): Delete.
2498         (m32c_dummy_id): Delete.
2499         (m32c_gdbarch_init): Don't register deleted functions with
2500         gdbarch.
2501
2502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2503
2504         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2505         (lm32_unwind_pc): Delete.
2506         (lm32_dummy_id): Delete.
2507         (lm32_gdbarch_init): Don't register deleted functions with
2508         gdbarch.
2509
2510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2511
2512         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2513         (iq2000_unwind_pc): Delete.
2514         (iq2000_dummy_id): Delete.
2515         (iq2000_gdbarch_init): Don't register deleted functions with
2516         gdbarch.
2517
2518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * nds32-tdep.c (nds32_type_align): Delete.
2521         (nds32_push_dummy_call): Use type_align instead.
2522
2523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2524
2525         * arm-tdep.c (arm_type_align): Only handle vector override case.
2526         (arm_push_dummy_call): Use type_align.
2527         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2528
2529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2532         case.
2533         (pass_on_stack): Use type_align.
2534         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2535         function.
2536
2537 2019-04-23  Tom Tromey  <tromey@adacore.com>
2538
2539         * dwarf2read.c (line_header::file_name_at): Remove unused
2540         overload.
2541
2542 2019-04-23  Tom de Vries  <tdevries@suse.de>
2543
2544         PR gdb/24438
2545         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2546         invocation.
2547
2548
2549 2019-03-27  Ali Tamur  <tamur@google.com>
2550
2551         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2552         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2553         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2554         (dwarf_expr_context::get_addr_index): Likewise
2555         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2556         (symbol_needs_eval_context::get_addr_index): Likewise
2557         (disassemble_dwarf_expression): Add DW_OP_addrx
2558         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2559         (read_cutu_die_from_dwo): Update comment
2560         (skip_one_die): Add DW_FORM_addrx
2561         (read_attribute_value): Likewise
2562         (var_decode_location): Add DW_OP_addrx
2563         (dwarf2_const_value_attr): Add DW_FORM_addrx
2564         (dump_die_shallow): Likewise
2565         (dwarf2_fetch_constant_bytes): Likewise
2566         (decode_locdesc): Add DW_OP_addrx
2567         (skip_form_bytes): Add DW_FORM_addrx
2568
2569 2019-04-22  Ali Tamur  <tamur@google.com>
2570
2571         * MAINTAINERS (Write After Approval): Add self.
2572
2573 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2574
2575         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2576         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2577         (open_symbol_file_object): Likewise.
2578         (svr4_default_sos): Add info parameter.
2579         (svr4_read_so_list): Likewise.
2580         (svr4_current_sos_direct): Adjust functions calls to pass down
2581         info.
2582         (svr4_current_sos_1): Add info parameter.
2583         (svr4_current_sos): Call get_svr4_info, pass info down to
2584         svr4_current_sos_1.
2585         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2586         get_svr4_info.
2587         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2588         get_svr4_info.
2589         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2590         to get_svr4_info.
2591         (probes_table_remove_objfile_probes): Likewise.
2592         (register_solib_event_probe): Add info parameter.
2593         (solist_update_incremental): Pass info parameter down to
2594         svr4_read_so_list.
2595         (disable_probes_interface): Add info parameter.
2596         (svr4_handle_solib_event): Pass current_program_space to
2597         get_svr4_info.  Adjust disable_probes_interface cleanup.
2598         (svr4_create_probe_breakpoints): Add info parameter, pass it
2599         down to register_solib_event_probe.
2600         (svr4_create_solib_event_breakpoints): Add info parameter,
2601         pass it down to svr4_create_probe_breakpoints.
2602         (enable_break): Pass info down to
2603         svr4_create_solib_event_breakpoints.
2604         (svr4_solib_create_inferior_hook): Pass current_program_space to
2605         get_svr4_info.
2606         (svr4_clear_solib): Likewise.
2607
2608 2019-04-22  Pedro Alves  <palves@redhat.com>
2609
2610         * solib-svr4.c (svr4_free_objfile_observer): New.
2611         (probe_and_action::objfile): New field.
2612         (probes_table_htab_remove_objfile_probes)
2613         (probes_table_remove_objfile_probes): New functions.
2614         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2615         in the new probe_and_action.  Don't store the probe in 'lookup'.
2616         (svr4_create_probe_breakpoints): Pass objfile to
2617         register_solib_event_probe.
2618         (_initialize_svr4_solib): Register a free_objfile observer.
2619
2620 2019-04-19  Tom Tromey  <tom@tromey.com>
2621
2622         * common/queue.h: Remove.
2623
2624 2019-04-19  Tom Tromey  <tom@tromey.com>
2625
2626         * event-loop.c: Don't include "common/queue.h".
2627
2628 2019-04-19  Tom Tromey  <tom@tromey.com>
2629
2630         * remote.c (remote_target): Use delete.
2631         * remote-notif.h: Include <list>, not "common/queue.h".
2632         (notif_client_p): Remove typedef.
2633         (remote_notif_state): Add constructor, destructor, initializer.
2634         <notif_queue>: Now a std::list.
2635         (remote_notif_state_xfree): Don't declare.
2636         * remote-notif.c (remote_notif_process, handle_notification)
2637         (remote_notif_state_allocate): Update.
2638         (~remote_notif_state): Rename from remote_notif_state_xfree.
2639
2640 2019-04-19  Tom Tromey  <tom@tromey.com>
2641
2642         * symfile.c (reread_symbols): Update.
2643         * objfiles.c (objfile_register_static_link)
2644         (objfile_lookup_static_link): Update
2645         (~objfile) Don't delete static_links.
2646         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2647
2648 2019-04-19  Tom Tromey  <tom@tromey.com>
2649
2650         * type-stack.h (struct type_stack) <insert>: Constify string.
2651         * type-stack.c (type_stack::insert): Constify string.
2652         * gdbtypes.h (lookup_template_type): Update.
2653         (address_space_name_to_int): Update.
2654         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2655         const.
2656         (lookup_template_type): Make name const.
2657         * c-exp.y: Update rules.
2658         (lex_one_token, classify_name, classify_inner_name)
2659         (c_print_token): Update.
2660         * p-exp.y: Update rules.
2661         (yylex): Update.
2662         * f-exp.y: Update rules.
2663         (yylex): Update.
2664         * d-exp.y: Update rules.
2665         (lex_one_token, classify_name, classify_inner_name): Update.
2666         * parse.c (write_dollar_variable, copy_name): Return std::string.
2667         * parser-defs.h (copy_name): Change return type.
2668         * m2-exp.y: Update rules.
2669         (yylex): Update.
2670         * go-exp.y (lex_one_token): Update.
2671         Update rules.
2672         (classify_unsafe_function, classify_packaged_name)
2673         (classify_name, yylex): Update.
2674
2675 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2676
2677         * configure.ac: add --enable-source-highlight switch.
2678         * configure: Regenerate.
2679         * top.c (print_gdb_version): plumb --enable-source-highlight
2680         status to "show configuration".
2681
2682 2019-04-19  Tom Tromey  <tromey@adacore.com>
2683
2684         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2685         Check ADA_TYPE_P.
2686         (empty_record, ada_template_to_fixed_record_type_1)
2687         (template_to_static_fixed_type)
2688         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2689         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2690         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2691         macros.
2692
2693 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2694
2695         PR symtab/24423:
2696         * source.c (print_source_lines_base): Advance "iter" when a
2697         control character is seen.
2698
2699 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2700
2701         * inferior.h (struct infcall_suspend_state_deleter):
2702         Catch exception in destructor to avoid crash.
2703
2704 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2705
2706         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2707         close to the add_com "shell".
2708
2709 2019-04-18  Tom Tromey  <tromey@adacore.com>
2710
2711         * process-stratum-target.h (class process_stratum_target)
2712         <stratum>: Add "final".
2713
2714 2019-04-17  Tom Tromey  <tromey@adacore.com>
2715
2716         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2717         against nullptr before use.
2718
2719 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2720
2721         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2722
2723 2019-04-17  Jim Wilson  <jimw@sifive.com>
2724             Andrew Burgess  <andrew.burgess@embecosm.com>
2725
2726         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2727         code read might fail, assume 4-byte breakpoint in that case.
2728
2729 2019-04-15  Leszek Swirski  <leszeks@google.com>
2730
2731         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2732         rather than a hand-rolled POD check when checking for forced MEMORY
2733         classification.
2734
2735 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2736
2737         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2738         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2739         function.
2740         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2741         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2742         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2743         declaration.
2744
2745 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2746
2747         * aarch64-linux-nat.c
2748         (aarch64_linux_nat_target::thread_architecture): Add override.
2749         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2750         each VQ.
2751
2752 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2753
2754         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2755
2756 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2757
2758         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2759         target types of size 96-bits, add some additional comments, and
2760         check that the builtin type we found was the correct size.
2761
2762 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2763
2764         * utils.c (prompt_for_continue): Don't restore the styling at the
2765         end, as applied_style has the wrong value.  This fixes styling in
2766         long lists of file names that are interrupted by the "Continue?"
2767         prompt.
2768
2769 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2772         * c-lang.c (c_language_defn): Likewise.
2773         (cplus_language_defn): Likewise.
2774         (asm_language_defn): Likewise.
2775         (minimal_language_defn): Likewise.
2776         * d-lang.c (d_language_defn): Likewise.
2777         * f-lang.c (f_language_defn): Likewise.
2778         * go-lang.c (go_language_defn): Likewise.
2779         * language.c (unknown_language_defn): Likewise.
2780         (auto_language_defn): Likewise.
2781         * language.h (struct language_defn): Remove la_magic field.
2782         (LANG_MAGIC): Delete.
2783         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2784         * objc-lang.c (objc_language_defn): Likewise.
2785         * opencl-lang.c (opencl_language_defn): Likewise.
2786         * p-lang.c (pascal_language_defn): Likewise.
2787         * rust-lang.c (rust_language_defn): Likewise.
2788
2789 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * riscv-tdep.c (riscv_type_align): New function.
2792         (riscv_type_alignment): Delete.
2793         (riscv_arg_location): Use 'type_align'.
2794         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2795
2796 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * gdbtypes.c (type_align): A struct with no non-static fields also
2799         has alignment of 1.
2800
2801 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2804         component to 0.
2805         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2806         member.
2807         (riscv_struct_info::analyse): New implementation using new
2808         analyse_inner member function.
2809         (riscv_struct_info::field_offset): New member function.
2810         (riscv_struct_info::m_offsets): New member variable.
2811         (riscv_struct_info::analyse_inner): New private member function,
2812         takes the old implementation of riscv_struct_info::analyse but
2813         extended to track field offsets.
2814         (riscv_call_arg_struct): Update the struct folding special cases
2815         to handle cases where empty C++ structs, which are non-zero
2816         length, are found.
2817         (riscv_arg_location): Initialise the length of each location, a
2818         non-zero length now indicates the location is in use.
2819         (riscv_push_dummy_call): Allow for the first location having a
2820         non-zero offset when setting up arguments.
2821         (riscv_return_value): Likewise, but for return values.
2822
2823 2019-04-11  Tom Tromey  <tromey@adacore.com>
2824
2825         * utils.c (internal_vproblem): Make "msg" const.
2826
2827 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2828
2829         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2830         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2831         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2832         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2833
2834 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2835
2836         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2837         function.
2838         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2839         of amd64_collect_native_gregset.
2840         (amd64_linux_nat_target::store_registers): Likewise.
2841
2842 2019-04-10  Tom Tromey  <tom@tromey.com>
2843
2844         * symtab.c (lookup_global_symbol_from_objfile)
2845         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2846         * objfiles.h (class separate_debug_iterator): New.
2847         (class separate_debug_range): New.
2848         (struct objfile) <separate_debug_objfiles>: New method.
2849         (objfile_separate_debug_iterate): Don't declare.
2850         * objfiles.c (separate_debug_iterator::operator++): Rename from
2851         objfile_separate_debug_iterate.
2852         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2853         iterator.
2854         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2855         iterator.
2856
2857 2019-04-10  Tom Tromey  <tom@tromey.com>
2858
2859         * symfile.c (reread_symbols): Remove old comment.
2860         * objfiles.c (free_all_objfiles): Fix a typo.
2861
2862 2019-04-10  Tom Tromey  <tom@tromey.com>
2863
2864         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2865         * minsyms.c (lookup_minimal_symbol): Use foreach.
2866         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2867         (lookup_minimal_symbol_solib_trampoline): Likewise.
2868         * symfile.c (reread_symbols): Use foreach.
2869
2870 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2871             Tom Tromey  <tromey@adacore.com>
2872
2873         PR rust/24414:
2874         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2875         (rust_lex_int_test): Change "value" to be LONGEST.
2876         (rust_lex_tests): Add test for long integer literal.
2877
2878 2019-04-09  Tom Tromey  <tromey@adacore.com>
2879
2880         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2881         to bool.
2882         (extended_remote_target::attach): Update.
2883         (remote_target::remote_notice_new_inferior): Update.
2884         (remote_target::add_current_inferior_and_thread): Update.
2885         * inferior.c (exit_inferior_1): Use "false".
2886         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2887
2888 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2889
2890         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2891         the "start" command.
2892
2893 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2894
2895         * python/py-inferior.c (infpy_thread_from_thread_handle):
2896         Adjust comments to reflect renaming of thread_from_thread_handle
2897         to thread_from_handle.  Adjust keywords.  Fix type error message.
2898         (inferior_object_methods): Add thread_from_handle.  Retain
2899         thread_from_thread_handle, but mark it as deprecated.
2900
2901 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2902
2903         * gdbthread.h (find_thread_by_handle): Revise declaration.
2904         * thread.c (find_thread_by_handle): Likewise.  Adjust
2905         implementation too.
2906         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2907         support for buffer objects as handles.
2908
2909 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2910
2911         * python/py-infthread.c (thpy_thread_handle): New function.
2912         (thread_object_methods): Register thpy_thread_handle.
2913
2914 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2915
2916         * gdbthread.h (thread_to_thread_handle): Declare.
2917         * thread.c (gdbtypes.h): Include.
2918         (thread_to_thread_handle): New function.
2919
2920         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2921         (target_thread_info_to_thread_handle): Declare.
2922         * target.c (target_thread_info_to_thread_handle): New function.
2923         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2924         * target-delegates.c: Regenerate.
2925
2926         * linux-thread-db.c (class thread_db_target): Add method
2927         thread_info_to_thread_handle.
2928         (thread_db_target::thread_info_to_thread_handle): Define.
2929         * remote.c (class remote_target): Add new method
2930         thread_info_to_thread_handle.
2931         (remote_target::thread_info_to_thread_handle): Define.
2932
2933 2019-04-08  Pedro Alves  <palves@redhat.com>
2934
2935         * common/common-exceptions.c (throw_exception): Don't create
2936         named object to throw; throw directly.
2937         (throw_it): Likewise.  Don't initialize gdb_exception::message
2938         here, with new; pass FMT and AP to the ctor instead.
2939         * common/common-exceptions.h: Include <string>.
2940         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2941         const char *, va_list)): New ctor.  Use std::make_shared.
2942         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2943         errors)): Delete.
2944         (gdb_exception_error::gdb_exception_error(enum errors, const char
2945         *, va_list)): New.
2946         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2947         Add assertion.
2948         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2949         errors)): Delete.
2950         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2951         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2952         Add assertion.
2953
2954 2019-04-08  Tom Tromey  <tom@tromey.com>
2955
2956         * valops.c (value_rtti_indirect_type): Replace throw_exception
2957         with throw.
2958         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2959         with throw.
2960         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2961         throw.
2962         * target.c (target_translate_tls_address): Replace throw_exception
2963         with throw.
2964         * stack.c (frame_apply_command_count): Replace throw_exception
2965         with throw.
2966         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2967         throw.
2968         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2969         with throw.
2970         * rs6000-tdep.c (rs6000_frame_cache)
2971         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2972         * remote.c: Replace throw_exception with throw.
2973         * record-full.c (record_full_message, record_full_wait_1)
2974         (record_full_restore): Replace throw_exception with throw.
2975         * record-btrace.c:
2976         (get_thread_current_frame_id, record_btrace_start_replaying)
2977         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2978         (cmd_record_btrace_start): Replace throw_exception with throw.
2979         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2980         throw.
2981         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2982         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2983         * linespec.c:
2984         (find_linespec_symbols): Replace throw_exception with throw.
2985         * infrun.c (displaced_step_prepare, resume): Replace
2986         throw_exception with throw.
2987         * infcmd.c (post_create_inferior): Replace throw_exception with
2988         throw.
2989         * inf-loop.c (inferior_event_handler): Replace throw_exception
2990         with throw.
2991         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2992         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2993         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2994         (get_prev_frame_always, get_frame_pc_if_available)
2995         (get_frame_address_in_block_if_available, get_frame_language):
2996         Replace throw_exception with throw.
2997         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2998         throw_exception with throw.
2999         * eval.c (fetch_subexp_value, evaluate_var_value)
3000         (evaluate_funcall, evaluate_subexp_standard): Replace
3001         throw_exception with throw.
3002         * dwarf2loc.c (call_site_find_chain)
3003         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3004         Replace throw_exception with throw.
3005         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3006         with throw.
3007         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3008         throw.
3009         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3010         * completer.c (complete_line_internal): Replace throw_exception
3011         with throw.
3012         * compile/compile-object-run.c (compile_object_run): Replace
3013         throw_exception with throw.
3014         * cli/cli-script.c (process_next_line): Replace throw_exception
3015         with throw.
3016         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3017         (btrace_enable, btrace_maint_update_pt_packets): Replace
3018         throw_exception with throw.
3019         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3020         throw_exception with throw.
3021         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3022         throw_exception with throw.
3023         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3024         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3025         * aarch64-tdep.c (aarch64_make_prologue_cache)
3026         (aarch64_make_stub_cache): Replace throw_exception with throw.
3027
3028 2019-04-08  Tom Tromey  <tom@tromey.com>
3029
3030         * common/common-exceptions.c (throw_exception): Rename from
3031         throw_exception_cxx.  Remove old copy.  Make argument const.
3032         (throw_it): Create and throw exception objects directly.
3033         * common/common-exceptions.h (throw_exception): Make argument
3034         const.
3035         (struct gdb_exception_error): Add constructor.
3036         (struct gdb_exception_quit): Add constructor.
3037
3038 2019-04-08  Tom Tromey  <tom@tromey.com>
3039
3040         * common/common-exceptions.h (exception_rethrow): Don't declare.
3041         (TRY_SJLJ): Update comment.
3042         (TRY, CATCH, END_CATCH): Remove.
3043         * common/common-exceptions.c (exception_rethrow): Remove.
3044
3045 2019-04-08  Tom Tromey  <tom@tromey.com>
3046
3047         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3048         Remove.
3049         (gdb_exception_error): Rename from
3050         gdb_exception_RETURN_MASK_ERROR.
3051         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3052         (gdb_quit_bad_alloc): Update.
3053         * aarch64-tdep.c: Update.
3054         * ada-lang.c: Update.
3055         * ada-typeprint.c: Update.
3056         * ada-valprint.c: Update.
3057         * amd64-tdep.c: Update.
3058         * arch-utils.c: Update.
3059         * break-catch-throw.c: Update.
3060         * breakpoint.c: Update.
3061         * btrace.c: Update.
3062         * c-varobj.c: Update.
3063         * cli/cli-cmds.c: Update.
3064         * cli/cli-interp.c: Update.
3065         * cli/cli-script.c: Update.
3066         * common/common-exceptions.c: Update.
3067         * common/new-op.c: Update.
3068         * common/selftest.c: Update.
3069         * compile/compile-c-symbols.c: Update.
3070         * compile/compile-cplus-symbols.c: Update.
3071         * compile/compile-object-load.c: Update.
3072         * compile/compile-object-run.c: Update.
3073         * completer.c: Update.
3074         * corelow.c: Update.
3075         * cp-abi.c: Update.
3076         * cp-support.c: Update.
3077         * cp-valprint.c: Update.
3078         * darwin-nat.c: Update.
3079         * disasm-selftests.c: Update.
3080         * dtrace-probe.c: Update.
3081         * dwarf-index-cache.c: Update.
3082         * dwarf-index-write.c: Update.
3083         * dwarf2-frame-tailcall.c: Update.
3084         * dwarf2-frame.c: Update.
3085         * dwarf2loc.c: Update.
3086         * dwarf2read.c: Update.
3087         * eval.c: Update.
3088         * event-loop.c: Update.
3089         * event-top.c: Update.
3090         * exec.c: Update.
3091         * f-valprint.c: Update.
3092         * fbsd-tdep.c: Update.
3093         * frame-unwind.c: Update.
3094         * frame.c: Update.
3095         * gdbtypes.c: Update.
3096         * gnu-v3-abi.c: Update.
3097         * guile/guile-internal.h: Update.
3098         * guile/scm-block.c: Update.
3099         * guile/scm-breakpoint.c: Update.
3100         * guile/scm-cmd.c: Update.
3101         * guile/scm-disasm.c: Update.
3102         * guile/scm-frame.c: Update.
3103         * guile/scm-lazy-string.c: Update.
3104         * guile/scm-math.c: Update.
3105         * guile/scm-param.c: Update.
3106         * guile/scm-ports.c: Update.
3107         * guile/scm-pretty-print.c: Update.
3108         * guile/scm-symbol.c: Update.
3109         * guile/scm-symtab.c: Update.
3110         * guile/scm-type.c: Update.
3111         * guile/scm-value.c: Update.
3112         * i386-linux-tdep.c: Update.
3113         * i386-tdep.c: Update.
3114         * inf-loop.c: Update.
3115         * infcall.c: Update.
3116         * infcmd.c: Update.
3117         * infrun.c: Update.
3118         * jit.c: Update.
3119         * language.c: Update.
3120         * linespec.c: Update.
3121         * linux-fork.c: Update.
3122         * linux-nat.c: Update.
3123         * linux-tdep.c: Update.
3124         * linux-thread-db.c: Update.
3125         * main.c: Update.
3126         * mi/mi-cmd-break.c: Update.
3127         * mi/mi-cmd-stack.c: Update.
3128         * mi/mi-interp.c: Update.
3129         * mi/mi-main.c: Update.
3130         * objc-lang.c: Update.
3131         * p-valprint.c: Update.
3132         * parse.c: Update.
3133         * ppc-linux-tdep.c: Update.
3134         * printcmd.c: Update.
3135         * python/py-arch.c: Update.
3136         * python/py-breakpoint.c: Update.
3137         * python/py-cmd.c: Update.
3138         * python/py-finishbreakpoint.c: Update.
3139         * python/py-frame.c: Update.
3140         * python/py-framefilter.c: Update.
3141         * python/py-gdb-readline.c: Update.
3142         * python/py-inferior.c: Update.
3143         * python/py-infthread.c: Update.
3144         * python/py-lazy-string.c: Update.
3145         * python/py-linetable.c: Update.
3146         * python/py-objfile.c: Update.
3147         * python/py-param.c: Update.
3148         * python/py-prettyprint.c: Update.
3149         * python/py-progspace.c: Update.
3150         * python/py-record-btrace.c: Update.
3151         * python/py-record.c: Update.
3152         * python/py-symbol.c: Update.
3153         * python/py-type.c: Update.
3154         * python/py-unwind.c: Update.
3155         * python/py-utils.c: Update.
3156         * python/py-value.c: Update.
3157         * python/python.c: Update.
3158         * record-btrace.c: Update.
3159         * record-full.c: Update.
3160         * remote-fileio.c: Update.
3161         * remote.c: Update.
3162         * riscv-tdep.c: Update.
3163         * rs6000-aix-tdep.c: Update.
3164         * rs6000-tdep.c: Update.
3165         * rust-exp.y: Update.
3166         * rust-lang.c: Update.
3167         * s390-tdep.c: Update.
3168         * selftest-arch.c: Update.
3169         * solib-dsbt.c: Update.
3170         * solib-frv.c: Update.
3171         * solib-spu.c: Update.
3172         * solib-svr4.c: Update.
3173         * solib.c: Update.
3174         * sparc64-linux-tdep.c: Update.
3175         * stack.c: Update.
3176         * symfile-mem.c: Update.
3177         * symmisc.c: Update.
3178         * target.c: Update.
3179         * thread.c: Update.
3180         * top.c: Update.
3181         * tracefile-tfile.c: Update.
3182         * tui/tui.c: Update.
3183         * typeprint.c: Update.
3184         * unittests/cli-utils-selftests.c: Update.
3185         * unittests/parse-connection-spec-selftests.c: Update.
3186         * valops.c: Update.
3187         * valprint.c: Update.
3188         * value.c: Update.
3189         * varobj.c: Update.
3190         * windows-nat.c: Update.
3191         * x86-linux-nat.c: Update.
3192         * xml-support.c: Update.
3193
3194 2019-04-08  Tom Tromey  <tom@tromey.com>
3195
3196         * xml-support.c: Use C++ exception handling.
3197         * x86-linux-nat.c: Use C++ exception handling.
3198         * windows-nat.c: Use C++ exception handling.
3199         * varobj.c: Use C++ exception handling.
3200         * value.c: Use C++ exception handling.
3201         * valprint.c: Use C++ exception handling.
3202         * valops.c: Use C++ exception handling.
3203         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3204         handling.
3205         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3206         * typeprint.c: Use C++ exception handling.
3207         * tui/tui.c: Use C++ exception handling.
3208         * tracefile-tfile.c: Use C++ exception handling.
3209         * top.c: Use C++ exception handling.
3210         * thread.c: Use C++ exception handling.
3211         * target.c: Use C++ exception handling.
3212         * symmisc.c: Use C++ exception handling.
3213         * symfile-mem.c: Use C++ exception handling.
3214         * stack.c: Use C++ exception handling.
3215         * sparc64-linux-tdep.c: Use C++ exception handling.
3216         * solib.c: Use C++ exception handling.
3217         * solib-svr4.c: Use C++ exception handling.
3218         * solib-spu.c: Use C++ exception handling.
3219         * solib-frv.c: Use C++ exception handling.
3220         * solib-dsbt.c: Use C++ exception handling.
3221         * selftest-arch.c: Use C++ exception handling.
3222         * s390-tdep.c: Use C++ exception handling.
3223         * rust-lang.c: Use C++ exception handling.
3224         * rust-exp.y: Use C++ exception handling.
3225         * rs6000-tdep.c: Use C++ exception handling.
3226         * rs6000-aix-tdep.c: Use C++ exception handling.
3227         * riscv-tdep.c: Use C++ exception handling.
3228         * remote.c: Use C++ exception handling.
3229         * remote-fileio.c: Use C++ exception handling.
3230         * record-full.c: Use C++ exception handling.
3231         * record-btrace.c: Use C++ exception handling.
3232         * python/python.c: Use C++ exception handling.
3233         * python/py-value.c: Use C++ exception handling.
3234         * python/py-utils.c: Use C++ exception handling.
3235         * python/py-unwind.c: Use C++ exception handling.
3236         * python/py-type.c: Use C++ exception handling.
3237         * python/py-symbol.c: Use C++ exception handling.
3238         * python/py-record.c: Use C++ exception handling.
3239         * python/py-record-btrace.c: Use C++ exception handling.
3240         * python/py-progspace.c: Use C++ exception handling.
3241         * python/py-prettyprint.c: Use C++ exception handling.
3242         * python/py-param.c: Use C++ exception handling.
3243         * python/py-objfile.c: Use C++ exception handling.
3244         * python/py-linetable.c: Use C++ exception handling.
3245         * python/py-lazy-string.c: Use C++ exception handling.
3246         * python/py-infthread.c: Use C++ exception handling.
3247         * python/py-inferior.c: Use C++ exception handling.
3248         * python/py-gdb-readline.c: Use C++ exception handling.
3249         * python/py-framefilter.c: Use C++ exception handling.
3250         * python/py-frame.c: Use C++ exception handling.
3251         * python/py-finishbreakpoint.c: Use C++ exception handling.
3252         * python/py-cmd.c: Use C++ exception handling.
3253         * python/py-breakpoint.c: Use C++ exception handling.
3254         * python/py-arch.c: Use C++ exception handling.
3255         * printcmd.c: Use C++ exception handling.
3256         * ppc-linux-tdep.c: Use C++ exception handling.
3257         * parse.c: Use C++ exception handling.
3258         * p-valprint.c: Use C++ exception handling.
3259         * objc-lang.c: Use C++ exception handling.
3260         * mi/mi-main.c: Use C++ exception handling.
3261         * mi/mi-interp.c: Use C++ exception handling.
3262         * mi/mi-cmd-stack.c: Use C++ exception handling.
3263         * mi/mi-cmd-break.c: Use C++ exception handling.
3264         * main.c: Use C++ exception handling.
3265         * linux-thread-db.c: Use C++ exception handling.
3266         * linux-tdep.c: Use C++ exception handling.
3267         * linux-nat.c: Use C++ exception handling.
3268         * linux-fork.c: Use C++ exception handling.
3269         * linespec.c: Use C++ exception handling.
3270         * language.c: Use C++ exception handling.
3271         * jit.c: Use C++ exception handling.
3272         * infrun.c: Use C++ exception handling.
3273         * infcmd.c: Use C++ exception handling.
3274         * infcall.c: Use C++ exception handling.
3275         * inf-loop.c: Use C++ exception handling.
3276         * i386-tdep.c: Use C++ exception handling.
3277         * i386-linux-tdep.c: Use C++ exception handling.
3278         * guile/scm-value.c: Use C++ exception handling.
3279         * guile/scm-type.c: Use C++ exception handling.
3280         * guile/scm-symtab.c: Use C++ exception handling.
3281         * guile/scm-symbol.c: Use C++ exception handling.
3282         * guile/scm-pretty-print.c: Use C++ exception handling.
3283         * guile/scm-ports.c: Use C++ exception handling.
3284         * guile/scm-param.c: Use C++ exception handling.
3285         * guile/scm-math.c: Use C++ exception handling.
3286         * guile/scm-lazy-string.c: Use C++ exception handling.
3287         * guile/scm-frame.c: Use C++ exception handling.
3288         * guile/scm-disasm.c: Use C++ exception handling.
3289         * guile/scm-cmd.c: Use C++ exception handling.
3290         * guile/scm-breakpoint.c: Use C++ exception handling.
3291         * guile/scm-block.c: Use C++ exception handling.
3292         * guile/guile-internal.h: Use C++ exception handling.
3293         * gnu-v3-abi.c: Use C++ exception handling.
3294         * gdbtypes.c: Use C++ exception handling.
3295         * frame.c: Use C++ exception handling.
3296         * frame-unwind.c: Use C++ exception handling.
3297         * fbsd-tdep.c: Use C++ exception handling.
3298         * f-valprint.c: Use C++ exception handling.
3299         * exec.c: Use C++ exception handling.
3300         * event-top.c: Use C++ exception handling.
3301         * event-loop.c: Use C++ exception handling.
3302         * eval.c: Use C++ exception handling.
3303         * dwarf2read.c: Use C++ exception handling.
3304         * dwarf2loc.c: Use C++ exception handling.
3305         * dwarf2-frame.c: Use C++ exception handling.
3306         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3307         * dwarf-index-write.c: Use C++ exception handling.
3308         * dwarf-index-cache.c: Use C++ exception handling.
3309         * dtrace-probe.c: Use C++ exception handling.
3310         * disasm-selftests.c: Use C++ exception handling.
3311         * darwin-nat.c: Use C++ exception handling.
3312         * cp-valprint.c: Use C++ exception handling.
3313         * cp-support.c: Use C++ exception handling.
3314         * cp-abi.c: Use C++ exception handling.
3315         * corelow.c: Use C++ exception handling.
3316         * completer.c: Use C++ exception handling.
3317         * compile/compile-object-run.c: Use C++ exception handling.
3318         * compile/compile-object-load.c: Use C++ exception handling.
3319         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3320         * compile/compile-c-symbols.c: Use C++ exception handling.
3321         * common/selftest.c: Use C++ exception handling.
3322         * common/new-op.c: Use C++ exception handling.
3323         * cli/cli-script.c: Use C++ exception handling.
3324         * cli/cli-interp.c: Use C++ exception handling.
3325         * cli/cli-cmds.c: Use C++ exception handling.
3326         * c-varobj.c: Use C++ exception handling.
3327         * btrace.c: Use C++ exception handling.
3328         * breakpoint.c: Use C++ exception handling.
3329         * break-catch-throw.c: Use C++ exception handling.
3330         * arch-utils.c: Use C++ exception handling.
3331         * amd64-tdep.c: Use C++ exception handling.
3332         * ada-valprint.c: Use C++ exception handling.
3333         * ada-typeprint.c: Use C++ exception handling.
3334         * ada-lang.c: Use C++ exception handling.
3335         * aarch64-tdep.c: Use C++ exception handling.
3336
3337 2019-04-08  Tom Tromey  <tom@tromey.com>
3338
3339         * xml-support.c (gdb_xml_parser::parse): Update.
3340         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3341         * value.c (show_convenience): Update.
3342         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3343         (test_parse_flags_qcs): Update.
3344         * thread.c (thr_try_catch_cmd): Update.
3345         * target.c (target_translate_tls_address): Update.
3346         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3347         (info_frame_command_core, frame_apply_command_count): Update.
3348         * rust-exp.y (rust_lex_exception_test): Update.
3349         * riscv-tdep.c (riscv_print_one_register_info): Update.
3350         * remote.c (remote_target::enable_btrace): Update.
3351         * record-btrace.c (record_btrace_enable_warn): Update.
3352         * python/py-utils.c (gdbpy_convert_exception): Update.
3353         * printcmd.c (do_one_display, print_variable_and_value): Update.
3354         * mi/mi-main.c (mi_print_exception): Update.
3355         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3356         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3357         * linux-nat.c (linux_nat_target::attach): Update.
3358         * linux-fork.c (class scoped_switch_fork_info): Update.
3359         * infrun.c (displaced_step_prepare): Update.
3360         * infcall.c (call_function_by_hand_dummy): Update.
3361         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3362         * gnu-v3-abi.c (print_one_vtable): Update.
3363         * frame.c (get_prev_frame_always): Update.
3364         * f-valprint.c (info_common_command_for_block): Update.
3365         * exec.c (try_open_exec_file): Update.
3366         * exceptions.c (print_exception, exception_print)
3367         (exception_fprintf, exception_print_same): Update.
3368         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3369         * dwarf-index-cache.c (index_cache::store)
3370         (index_cache::lookup_gdb_index): Update.
3371         * darwin-nat.c (maybe_cache_shell): Update.
3372         * cp-valprint.c (cp_print_value_fields): Update.
3373         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3374         (gcc_cplus_symbol_address): Update.
3375         * compile/compile-c-symbols.c (gcc_convert_symbol)
3376         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3377         * common/selftest.c: Update.
3378         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3379         a std::string.
3380         (exception_try_scope_entry, exception_try_scope_exit): Don't
3381         declare.
3382         (struct exception_try_scope): Remove.
3383         (TRY): Don't use exception_try_scope.
3384         (struct gdb_exception): Add constructor, operator=.
3385         <what>: New method.
3386         (struct gdb_exception_RETURN_MASK_ALL)
3387         (struct gdb_exception_RETURN_MASK_ERROR)
3388         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3389         (struct gdb_quit_bad_alloc): Update.
3390         * common/common-exceptions.c (exception_none): Change
3391         initializer.
3392         (struct catcher) <state, exception>: Initialize inline.
3393         <prev>: Remove member.
3394         (current_catcher): Remove.
3395         (catchers): New global.
3396         (exceptions_state_mc_init): Simplify.
3397         (catcher_pop): Remove.
3398         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3399         (try_scope_depth, exception_try_scope_entry)
3400         (exception_try_scope_exit): Remove.
3401         (throw_exception_sjlj): Update.
3402         (exception_messages, exception_messages_size): Remove.
3403         (throw_it): Simplify.
3404         (gdb_exception_sliced_copy): Remove.
3405         (throw_exception_cxx): Update.
3406         * cli/cli-script.c (script_from_file): Update.
3407         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3408         Update.
3409         * ada-valprint.c (ada_val_print): Update.
3410         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3411         (create_excep_cond_exprs): Update.
3412
3413 2019-04-08  Tom Tromey  <tom@tromey.com>
3414
3415         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3416         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3417         (TRY, CATCH, END_CATCH): Remove some definitions.
3418         * common/common-exceptions.c: Don't use GDB_XCPT.
3419         (catcher_list_size): Remove.
3420         (throw_exception, throw_it): Simplify.
3421
3422 2019-04-05  Tom Tromey  <tom@tromey.com>
3423
3424         Revert the header-sorting patch.
3425         * ft32-tdep.c: Revert.
3426         * frv-tdep.c: Revert.
3427         * frv-linux-tdep.c: Revert.
3428         * frame.c: Revert.
3429         * frame-unwind.c: Revert.
3430         * frame-base.c: Revert.
3431         * fork-child.c: Revert.
3432         * findvar.c: Revert.
3433         * findcmd.c: Revert.
3434         * filesystem.c: Revert.
3435         * filename-seen-cache.h: Revert.
3436         * filename-seen-cache.c: Revert.
3437         * fbsd-tdep.c: Revert.
3438         * fbsd-nat.h: Revert.
3439         * fbsd-nat.c: Revert.
3440         * f-valprint.c: Revert.
3441         * f-typeprint.c: Revert.
3442         * f-lang.c: Revert.
3443         * extension.h: Revert.
3444         * extension.c: Revert.
3445         * extension-priv.h: Revert.
3446         * expprint.c: Revert.
3447         * exec.h: Revert.
3448         * exec.c: Revert.
3449         * exceptions.c: Revert.
3450         * event-top.c: Revert.
3451         * event-loop.c: Revert.
3452         * eval.c: Revert.
3453         * elfread.c: Revert.
3454         * dwarf2read.h: Revert.
3455         * dwarf2read.c: Revert.
3456         * dwarf2loc.c: Revert.
3457         * dwarf2expr.h: Revert.
3458         * dwarf2expr.c: Revert.
3459         * dwarf2-frame.c: Revert.
3460         * dwarf2-frame-tailcall.c: Revert.
3461         * dwarf-index-write.h: Revert.
3462         * dwarf-index-write.c: Revert.
3463         * dwarf-index-common.c: Revert.
3464         * dwarf-index-cache.h: Revert.
3465         * dwarf-index-cache.c: Revert.
3466         * dummy-frame.c: Revert.
3467         * dtrace-probe.c: Revert.
3468         * disasm.h: Revert.
3469         * disasm.c: Revert.
3470         * disasm-selftests.c: Revert.
3471         * dictionary.c: Revert.
3472         * dicos-tdep.c: Revert.
3473         * demangle.c: Revert.
3474         * dcache.h: Revert.
3475         * dcache.c: Revert.
3476         * darwin-nat.h: Revert.
3477         * darwin-nat.c: Revert.
3478         * darwin-nat-info.c: Revert.
3479         * d-valprint.c: Revert.
3480         * d-namespace.c: Revert.
3481         * d-lang.c: Revert.
3482         * ctf.c: Revert.
3483         * csky-tdep.c: Revert.
3484         * csky-linux-tdep.c: Revert.
3485         * cris-tdep.c: Revert.
3486         * cris-linux-tdep.c: Revert.
3487         * cp-valprint.c: Revert.
3488         * cp-support.c: Revert.
3489         * cp-namespace.c: Revert.
3490         * cp-abi.c: Revert.
3491         * corelow.c: Revert.
3492         * corefile.c: Revert.
3493         * continuations.c: Revert.
3494         * completer.h: Revert.
3495         * completer.c: Revert.
3496         * complaints.c: Revert.
3497         * coffread.c: Revert.
3498         * coff-pe-read.c: Revert.
3499         * cli-out.h: Revert.
3500         * cli-out.c: Revert.
3501         * charset.c: Revert.
3502         * c-varobj.c: Revert.
3503         * c-valprint.c: Revert.
3504         * c-typeprint.c: Revert.
3505         * c-lang.c: Revert.
3506         * buildsym.c: Revert.
3507         * buildsym-legacy.c: Revert.
3508         * build-id.h: Revert.
3509         * build-id.c: Revert.
3510         * btrace.c: Revert.
3511         * bsd-uthread.c: Revert.
3512         * breakpoint.h: Revert.
3513         * breakpoint.c: Revert.
3514         * break-catch-throw.c: Revert.
3515         * break-catch-syscall.c: Revert.
3516         * break-catch-sig.c: Revert.
3517         * blockframe.c: Revert.
3518         * block.c: Revert.
3519         * bfin-tdep.c: Revert.
3520         * bfin-linux-tdep.c: Revert.
3521         * bfd-target.c: Revert.
3522         * bcache.c: Revert.
3523         * ax-general.c: Revert.
3524         * ax-gdb.h: Revert.
3525         * ax-gdb.c: Revert.
3526         * avr-tdep.c: Revert.
3527         * auxv.c: Revert.
3528         * auto-load.c: Revert.
3529         * arm-wince-tdep.c: Revert.
3530         * arm-tdep.c: Revert.
3531         * arm-symbian-tdep.c: Revert.
3532         * arm-pikeos-tdep.c: Revert.
3533         * arm-obsd-tdep.c: Revert.
3534         * arm-nbsd-tdep.c: Revert.
3535         * arm-nbsd-nat.c: Revert.
3536         * arm-linux-tdep.c: Revert.
3537         * arm-linux-nat.c: Revert.
3538         * arm-fbsd-tdep.c: Revert.
3539         * arm-fbsd-nat.c: Revert.
3540         * arm-bsd-tdep.c: Revert.
3541         * arch-utils.c: Revert.
3542         * arc-tdep.c: Revert.
3543         * arc-newlib-tdep.c: Revert.
3544         * annotate.h: Revert.
3545         * annotate.c: Revert.
3546         * amd64-windows-tdep.c: Revert.
3547         * amd64-windows-nat.c: Revert.
3548         * amd64-tdep.c: Revert.
3549         * amd64-sol2-tdep.c: Revert.
3550         * amd64-obsd-tdep.c: Revert.
3551         * amd64-obsd-nat.c: Revert.
3552         * amd64-nbsd-tdep.c: Revert.
3553         * amd64-nbsd-nat.c: Revert.
3554         * amd64-nat.c: Revert.
3555         * amd64-linux-tdep.c: Revert.
3556         * amd64-linux-nat.c: Revert.
3557         * amd64-fbsd-tdep.c: Revert.
3558         * amd64-fbsd-nat.c: Revert.
3559         * amd64-dicos-tdep.c: Revert.
3560         * amd64-darwin-tdep.c: Revert.
3561         * amd64-bsd-nat.c: Revert.
3562         * alpha-tdep.c: Revert.
3563         * alpha-obsd-tdep.c: Revert.
3564         * alpha-nbsd-tdep.c: Revert.
3565         * alpha-mdebug-tdep.c: Revert.
3566         * alpha-linux-tdep.c: Revert.
3567         * alpha-linux-nat.c: Revert.
3568         * alpha-bsd-tdep.c: Revert.
3569         * alpha-bsd-nat.c: Revert.
3570         * aix-thread.c: Revert.
3571         * agent.c: Revert.
3572         * addrmap.c: Revert.
3573         * ada-varobj.c: Revert.
3574         * ada-valprint.c: Revert.
3575         * ada-typeprint.c: Revert.
3576         * ada-tasks.c: Revert.
3577         * ada-lang.c: Revert.
3578         * aarch64-tdep.c: Revert.
3579         * aarch64-ravenscar-thread.c: Revert.
3580         * aarch64-newlib-tdep.c: Revert.
3581         * aarch64-linux-tdep.c: Revert.
3582         * aarch64-linux-nat.c: Revert.
3583         * aarch64-fbsd-tdep.c: Revert.
3584         * aarch64-fbsd-nat.c: Revert.
3585         * aarch32-linux-nat.c: Revert.
3586
3587 2019-04-05  Tom Tromey  <tom@tromey.com>
3588
3589         * ft32-tdep.c: Sort headers.
3590         * frv-tdep.c: Sort headers.
3591         * frv-linux-tdep.c: Sort headers.
3592         * frame.c: Sort headers.
3593         * frame-unwind.c: Sort headers.
3594         * frame-base.c: Sort headers.
3595         * fork-child.c: Sort headers.
3596         * findvar.c: Sort headers.
3597         * findcmd.c: Sort headers.
3598         * filesystem.c: Sort headers.
3599         * filename-seen-cache.h: Sort headers.
3600         * filename-seen-cache.c: Sort headers.
3601         * fbsd-tdep.c: Sort headers.
3602         * fbsd-nat.h: Sort headers.
3603         * fbsd-nat.c: Sort headers.
3604         * f-valprint.c: Sort headers.
3605         * f-typeprint.c: Sort headers.
3606         * f-lang.c: Sort headers.
3607         * extension.h: Sort headers.
3608         * extension.c: Sort headers.
3609         * extension-priv.h: Sort headers.
3610         * expprint.c: Sort headers.
3611         * exec.h: Sort headers.
3612         * exec.c: Sort headers.
3613         * exceptions.c: Sort headers.
3614         * event-top.c: Sort headers.
3615         * event-loop.c: Sort headers.
3616         * eval.c: Sort headers.
3617         * elfread.c: Sort headers.
3618         * dwarf2read.h: Sort headers.
3619         * dwarf2read.c: Sort headers.
3620         * dwarf2loc.c: Sort headers.
3621         * dwarf2expr.h: Sort headers.
3622         * dwarf2expr.c: Sort headers.
3623         * dwarf2-frame.c: Sort headers.
3624         * dwarf2-frame-tailcall.c: Sort headers.
3625         * dwarf-index-write.h: Sort headers.
3626         * dwarf-index-write.c: Sort headers.
3627         * dwarf-index-common.c: Sort headers.
3628         * dwarf-index-cache.h: Sort headers.
3629         * dwarf-index-cache.c: Sort headers.
3630         * dummy-frame.c: Sort headers.
3631         * dtrace-probe.c: Sort headers.
3632         * disasm.h: Sort headers.
3633         * disasm.c: Sort headers.
3634         * disasm-selftests.c: Sort headers.
3635         * dictionary.c: Sort headers.
3636         * dicos-tdep.c: Sort headers.
3637         * demangle.c: Sort headers.
3638         * dcache.h: Sort headers.
3639         * dcache.c: Sort headers.
3640         * darwin-nat.h: Sort headers.
3641         * darwin-nat.c: Sort headers.
3642         * darwin-nat-info.c: Sort headers.
3643         * d-valprint.c: Sort headers.
3644         * d-namespace.c: Sort headers.
3645         * d-lang.c: Sort headers.
3646         * ctf.c: Sort headers.
3647         * csky-tdep.c: Sort headers.
3648         * csky-linux-tdep.c: Sort headers.
3649         * cris-tdep.c: Sort headers.
3650         * cris-linux-tdep.c: Sort headers.
3651         * cp-valprint.c: Sort headers.
3652         * cp-support.c: Sort headers.
3653         * cp-namespace.c: Sort headers.
3654         * cp-abi.c: Sort headers.
3655         * corelow.c: Sort headers.
3656         * corefile.c: Sort headers.
3657         * continuations.c: Sort headers.
3658         * completer.h: Sort headers.
3659         * completer.c: Sort headers.
3660         * complaints.c: Sort headers.
3661         * coffread.c: Sort headers.
3662         * coff-pe-read.c: Sort headers.
3663         * cli-out.h: Sort headers.
3664         * cli-out.c: Sort headers.
3665         * charset.c: Sort headers.
3666         * c-varobj.c: Sort headers.
3667         * c-valprint.c: Sort headers.
3668         * c-typeprint.c: Sort headers.
3669         * c-lang.c: Sort headers.
3670         * buildsym.c: Sort headers.
3671         * buildsym-legacy.c: Sort headers.
3672         * build-id.h: Sort headers.
3673         * build-id.c: Sort headers.
3674         * btrace.c: Sort headers.
3675         * bsd-uthread.c: Sort headers.
3676         * breakpoint.h: Sort headers.
3677         * breakpoint.c: Sort headers.
3678         * break-catch-throw.c: Sort headers.
3679         * break-catch-syscall.c: Sort headers.
3680         * break-catch-sig.c: Sort headers.
3681         * blockframe.c: Sort headers.
3682         * block.c: Sort headers.
3683         * bfin-tdep.c: Sort headers.
3684         * bfin-linux-tdep.c: Sort headers.
3685         * bfd-target.c: Sort headers.
3686         * bcache.c: Sort headers.
3687         * ax-general.c: Sort headers.
3688         * ax-gdb.h: Sort headers.
3689         * ax-gdb.c: Sort headers.
3690         * avr-tdep.c: Sort headers.
3691         * auxv.c: Sort headers.
3692         * auto-load.c: Sort headers.
3693         * arm-wince-tdep.c: Sort headers.
3694         * arm-tdep.c: Sort headers.
3695         * arm-symbian-tdep.c: Sort headers.
3696         * arm-pikeos-tdep.c: Sort headers.
3697         * arm-obsd-tdep.c: Sort headers.
3698         * arm-nbsd-tdep.c: Sort headers.
3699         * arm-nbsd-nat.c: Sort headers.
3700         * arm-linux-tdep.c: Sort headers.
3701         * arm-linux-nat.c: Sort headers.
3702         * arm-fbsd-tdep.c: Sort headers.
3703         * arm-fbsd-nat.c: Sort headers.
3704         * arm-bsd-tdep.c: Sort headers.
3705         * arch-utils.c: Sort headers.
3706         * arc-tdep.c: Sort headers.
3707         * arc-newlib-tdep.c: Sort headers.
3708         * annotate.h: Sort headers.
3709         * annotate.c: Sort headers.
3710         * amd64-windows-tdep.c: Sort headers.
3711         * amd64-windows-nat.c: Sort headers.
3712         * amd64-tdep.c: Sort headers.
3713         * amd64-sol2-tdep.c: Sort headers.
3714         * amd64-obsd-tdep.c: Sort headers.
3715         * amd64-obsd-nat.c: Sort headers.
3716         * amd64-nbsd-tdep.c: Sort headers.
3717         * amd64-nbsd-nat.c: Sort headers.
3718         * amd64-nat.c: Sort headers.
3719         * amd64-linux-tdep.c: Sort headers.
3720         * amd64-linux-nat.c: Sort headers.
3721         * amd64-fbsd-tdep.c: Sort headers.
3722         * amd64-fbsd-nat.c: Sort headers.
3723         * amd64-dicos-tdep.c: Sort headers.
3724         * amd64-darwin-tdep.c: Sort headers.
3725         * amd64-bsd-nat.c: Sort headers.
3726         * alpha-tdep.c: Sort headers.
3727         * alpha-obsd-tdep.c: Sort headers.
3728         * alpha-nbsd-tdep.c: Sort headers.
3729         * alpha-mdebug-tdep.c: Sort headers.
3730         * alpha-linux-tdep.c: Sort headers.
3731         * alpha-linux-nat.c: Sort headers.
3732         * alpha-bsd-tdep.c: Sort headers.
3733         * alpha-bsd-nat.c: Sort headers.
3734         * aix-thread.c: Sort headers.
3735         * agent.c: Sort headers.
3736         * addrmap.c: Sort headers.
3737         * ada-varobj.c: Sort headers.
3738         * ada-valprint.c: Sort headers.
3739         * ada-typeprint.c: Sort headers.
3740         * ada-tasks.c: Sort headers.
3741         * ada-lang.c: Sort headers.
3742         * aarch64-tdep.c: Sort headers.
3743         * aarch64-ravenscar-thread.c: Sort headers.
3744         * aarch64-newlib-tdep.c: Sort headers.
3745         * aarch64-linux-tdep.c: Sort headers.
3746         * aarch64-linux-nat.c: Sort headers.
3747         * aarch64-fbsd-tdep.c: Sort headers.
3748         * aarch64-fbsd-nat.c: Sort headers.
3749         * aarch32-linux-nat.c: Sort headers.
3750
3751 2019-04-04  Tom Tromey  <tom@tromey.com>
3752
3753         * varobj.c (varobj_create): Update.
3754         * rust-exp.y (struct rust_parser) <update_innermost_block,
3755         lookup_symbol>: New methods.
3756         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3757         Rename.
3758         (rust_parser::rust_lookup_type)
3759         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3760         * printcmd.c (display_command, do_one_display): Update.
3761         * parser-defs.h (struct parser_state) <parser_state>: Add
3762         "tracker" parameter.
3763         (block_tracker): New member.
3764         (class innermost_block_tracker) <innermost_block_tracker>: Add
3765         "types" parameter.
3766         <reset>: Remove method.
3767         (innermost_block): Don't declare.
3768         (null_post_parser): Update.
3769         * parse.c (innermost_block): Remove global.
3770         (write_dollar_variable): Update.
3771         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3772         Remove "tracker_types" parameter.
3773         (parse_expression): Add "tracker" parameter.
3774         (parse_expression_for_completion): Update.
3775         (null_post_parser): Add "tracker" parameter.
3776         * p-exp.y: Update rules.
3777         * m2-exp.y: Update rules.
3778         * language.h (struct language_defn) <la_post_parser>: Add
3779         "tracker" parameter.
3780         * go-exp.y: Update rules.
3781         * f-exp.y: Update rules.
3782         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3783         parameter.
3784         * d-exp.y: Update rules.
3785         * c-exp.y: Update rules.
3786         * breakpoint.c (set_breakpoint_condition): Create an
3787         innermost_block_tracker.
3788         (watch_command_1): Likewise.
3789         * ada-lang.c (resolve): Add "tracker" parameter.
3790         (resolve_subexp): Likewise.
3791         * ada-exp.y (write_var_from_sym): Update.
3792
3793 2019-04-04  Tom Tromey  <tom@tromey.com>
3794
3795         * type-stack.h: New file.
3796         * type-stack.c: New file.
3797         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3798         type-stack.h.
3799         (insert_into_type_stack, insert_type, push_type, push_type_int)
3800         (insert_type_address_space, pop_type, pop_type_int)
3801         (pop_typelist, pop_type_stack, append_type_stack)
3802         (push_type_stack, get_type_stack, push_typelist)
3803         (follow_type_instance_flags, follow_types): Don't declare.
3804         * parse.c (type_stack): Remove global.
3805         (parse_exp_in_context): Update.
3806         (insert_into_type_stack, insert_type, push_type, push_type_int)
3807         (insert_type_address_space, pop_type, pop_type_int)
3808         (pop_typelist, pop_type_stack, append_type_stack)
3809         (push_type_stack, get_type_stack, push_typelist)
3810         (follow_type_instance_flags, follow_types): Remove (moved to
3811         type-stack.c).
3812         * f-exp.y (type_stack): New global.
3813         Update rules.
3814         (push_kind_type, f_parse): Update.
3815         * d-exp.y (type_stack): New global.
3816         Update rules.
3817         (d_parse): Update.
3818         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3819         Update rules.
3820         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3821         (HFILES_NO_SRCDIR): Add type-stack.h.
3822
3823 2019-04-04  Tom Tromey  <tom@tromey.com>
3824
3825         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3826         (rust_parser::convert_ast_to_expression, rust_parse)
3827         (rust_lex_test_completion, rust_lex_tests): Update.
3828         * parser-defs.h (struct expr_completion_state): New.
3829         (struct parser_state) <parser_state>: Add completion parameter.
3830         <mark_struct_expression, mark_completion_tag>: New methods.
3831         <parse_completion, m_completion_state>: New members.
3832         (prefixify_expression, null_post_parser): Update.
3833         (mark_struct_expression, mark_completion_tag): Don't declare.
3834         * parse.c (parse_completion, expout_last_struct)
3835         (expout_tag_completion_type, expout_completion_name): Remove
3836         globals.
3837         (parser_state::mark_struct_expression)
3838         (parser_state::mark_completion_tag): Now methods.
3839         (prefixify_expression): Add last_struct parameter.
3840         (prefixify_subexp): Likewise.
3841         (parse_exp_1): Update.
3842         (parse_exp_in_context): Add cstate parameter.  Update.
3843         (parse_expression_for_completion): Create an
3844         expr_completion_state.
3845         (null_post_parser): Add "completion" parameter.
3846         * p-exp.y: Update rules.
3847         (yylex): Update.
3848         * language.h (struct language_defn) <la_post_parser>: Add
3849         "completing" parameter.
3850         * go-exp.y: Update rules.
3851         (lex_one_token): Update.
3852         * expression.h (parse_completion): Don't declare.
3853         * d-exp.y: Update rules.
3854         (lex_one_token): Update rules.
3855         * c-exp.y: Update rules.
3856         (lex_one_token): Update.
3857         * ada-lang.c (resolve): Add "parse_completion" parameter.
3858         (resolve_subexp): Likewise.
3859         (ada_resolve_function): Likewise.
3860
3861 2019-04-04  Tom Tromey  <tom@tromey.com>
3862
3863         * parser-defs.h (struct parser_state) <start_arglist,
3864         end_arglist>: New methods.
3865         <arglist_len, m_funcall_chain>: New members.
3866         (arglist_len, start_arglist, end_arglist): Don't declare.
3867         * parse.c (arglist_len, funcall_chain): Remove global.
3868         (start_arglist, end_arglist): Remove functions.
3869         (parse_exp_in_context): Update.
3870         * p-exp.y: Update rules.
3871         * m2-exp.y: Update rules.
3872         * go-exp.y: Update rules.
3873         * f-exp.y: Update rules.
3874         * d-exp.y: Update rules.
3875         * c-exp.y: Update rules.
3876
3877 2019-04-04  Tom Tromey  <tom@tromey.com>
3878
3879         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3880         lex_operator, push_back>: New methods.
3881         Update all rules.
3882         (rust_parser::lex_hex, lex_escape): Rename and update.
3883         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3884         (rust_parser::lex_operator): Rename and update.
3885         (rust_parser::lex_number, rustyylex, rustyyerror)
3886         (rust_lex_test_init, rust_lex_test_sequence)
3887         (rust_lex_test_push_back, rust_lex_tests): Update.
3888         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3889         parameter.
3890         <lexptr, prev_lexptr>: New members.
3891         (lexptr, prev_lexptr): Don't declare.
3892         * parse.c (lexptr, prev_lexptr): Remove globals.
3893         (parse_exp_in_context): Update.
3894         * p-exp.y (yylex, yyerror): Update.
3895         * m2-exp.y (parse_number, yylex, yyerror): Update.
3896         * go-exp.y (lex_one_token, yyerror): Update.
3897         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3898         * d-exp.y (lex_one_token, yyerror): Update.
3899         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3900         (lex_one_token, yyerror): Update.
3901         * ada-lex.l (YY_INPUT): Update.
3902         (rewind_to_char): Update.
3903         * ada-exp.y (yyerror): Update.
3904
3905 2019-04-04  Tom Tromey  <tom@tromey.com>
3906
3907         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3908         * parser-defs.h (struct parser_state) <parser_state>: Add new
3909         parameter.
3910         <comma_terminates>: New member.
3911         (comma_terminates): Don't declare global.
3912         * parse.c (comma_terminates): Remove global.
3913         (parse_exp_in_context): Update.
3914         * p-exp.y (yylex): Update.
3915         * m2-exp.y (yylex): Update.
3916         * go-exp.y (lex_one_token): Update.
3917         * f-exp.y (yylex): Update.
3918         * d-exp.y (lex_one_token): Update.
3919         * c-exp.y (lex_one_token): Update.
3920         * ada-lex.l: Update.
3921
3922 2019-04-04  Tom Tromey  <tom@tromey.com>
3923
3924         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3925         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3926         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3927         * parser-defs.h (paren_depth): Don't declare.
3928         * parse.c (paren_depth): Remove global.
3929         (parse_exp_in_context): Update.
3930         * p-exp.y (paren_depth): New global.
3931         (pascal_parse): Initialize it.
3932         * m2-exp.y (paren_depth): New global.
3933         (m2_parse): Initialize it.
3934         * go-exp.y (paren_depth): New global.
3935         (go_parse): Initialize it.
3936         * f-exp.y (paren_depth): New global.
3937         (f_parse): Initialize it.
3938         * d-exp.y (paren_depth): New global.
3939         (d_parse): Initialize it.
3940         * c-exp.y (paren_depth): New global.
3941         (c_parse): Initialize it.
3942         * ada-lex.l (paren_depth): New global.
3943         (lexer_init): Initialize it.
3944
3945 2019-04-04  Tom Tromey  <tom@tromey.com>
3946
3947         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3948         (rust_parser::convert_ast_to_type)
3949         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3950         * parser-defs.h (struct parser_state) <parser_state>: Add
3951         parameters.  Initialize new members.
3952         <expression_context_block, expression_context_pc>: New members.
3953         * parse.c (expression_context_block, expression_context_pc):
3954         Remove globals.
3955         (parse_exp_in_context): Update.
3956         * p-exp.y: Update all rules.
3957         (yylex): Update.
3958         * m2-exp.y: Update all rules.
3959         (yylex): Update.
3960         * go-exp.y (yylex): Update.
3961         * f-exp.y (yylex): Update.
3962         * d-exp.y: Update all rules.
3963         (yylex): Update.
3964         * c-exp.y: Update all rules.
3965         (lex_one_token, classify_name, yylex, c_parse): Update.
3966         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3967
3968 2019-04-04  Tom Tromey  <tom@tromey.com>
3969
3970         * gdbarch.h, gdbarch.c: Rebuild.
3971         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3972         * stap-probe.h:
3973         (struct stap_parse_info): Replace "parser_state" with
3974         "expr_builder".
3975         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3976         (parser_state): New class.
3977         * parse.c (expr_builder): Rename.
3978         (expr_builder::release): Rename.
3979         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3980         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3981         (write_exp_elt_longcst, write_exp_elt_floatcst)
3982         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3983         (write_exp_string_vector, write_exp_bitstring)
3984         (write_exp_msymbol, mark_struct_expression)
3985         (write_dollar_variable)
3986         (insert_type_address_space, increase_expout_size): Replace
3987         "parser_state" with "expr_builder".
3988         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3989         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3990         "parser_state" with "expr_builder".
3991
3992 2019-04-04  Tom Tromey  <tom@tromey.com>
3993
3994         * rust-exp.y: Replace "parse_language" with method call.
3995         * p-exp.y:
3996         (yylex): Replace "parse_language" with method call.
3997         * m2-exp.y:
3998         (yylex): Replace "parse_language" with method call.
3999         * go-exp.y (classify_name): Replace "parse_language" with method
4000         call.
4001         * f-exp.y (yylex): Replace "parse_language" with method call.
4002         * d-exp.y (lex_one_token): Replace "parse_language" with method
4003         call.
4004         * c-exp.y:
4005         (lex_one_token, classify_name, yylex): Replace "parse_language"
4006         with method call.
4007         * ada-exp.y (find_primitive_type, type_char)
4008         (type_system_address): Replace "parse_language" with method call.
4009
4010 2019-04-04  Tom Tromey  <tom@tromey.com>
4011
4012         * rust-exp.y: Replace "parse_gdbarch" with method call.
4013         * parse.c (write_dollar_variable, insert_type_address_space):
4014         Replace "parse_gdbarch" with method call.
4015         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4016         call.
4017         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4018         call.
4019         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4020         "parse_gdbarch" with method call.
4021         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4022         with method call.
4023         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4024         "parse_gdbarch" with method call.
4025         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4026         "parse_gdbarch" with method call.
4027         * c-exp.y (parse_type, parse_number, classify_name): Replace
4028         "parse_gdbarch" with method call.
4029         * ada-lex.l: Replace "parse_gdbarch" with method call.
4030         * ada-exp.y (parse_type, find_primitive_type, type_char)
4031         (type_system_address): Replace "parse_gdbarch" with method call.
4032
4033 2019-04-04  Tom Tromey  <tom@tromey.com>
4034
4035         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4036         * stap-probe.c (stap_parse_argument): Update.
4037         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4038         initial_size parameter.
4039         * rust-exp.y (rust_lex_tests): Update.
4040         * parse.c (parser_state): Update.
4041         (parse_exp_in_context): Update.
4042         * parser-defs.h (struct parser_state) <parser_state>: Remove
4043         "initial_size" parameter.
4044
4045 2019-04-04  Tom Tromey  <tom@tromey.com>
4046
4047         * parser-defs.h (increase_expout_size): Don't declare.
4048         * parse.c (increase_expout_size): Now static.
4049
4050 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4051
4052         * gnu-nat.c (gnu_nat_target::wait): Fix
4053         target_waitstatus_to_string call.
4054
4055 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * eval.c (evaluate_subexp_standard): Handle internal functions
4058         during Fortran function call handling.
4059
4060 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4061
4062         * NEWS: Mention new internal functions.
4063         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4064         (read_base_type): Use dwarf2_init_complex_target_type.
4065         * value.c (creal_internal_fn): New function.
4066         (cimag_internal_fn): New function.
4067         (_initialize_values): Register new internal functions.
4068
4069 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4070
4071         * infrun.c (stop_all_threads): If debug_infrun, always
4072         trace the wait status after wait_one, using
4073         target_waitstatus_to_string and target_pid_to_str.
4074         (handle_inferior_event): Replace various trace of
4075         wait status kind by a single trace.
4076         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4077         wait status kind image by target_waitstatus_to_string.
4078         * target/waitstatus.c (target_waitstatus_to_string): Fix
4079         obsolete comment.
4080
4081 2019-04-01  Tom Tromey  <tromey@adacore.com>
4082
4083         PR symtab/23331:
4084         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4085
4086 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4087             Pedro Alves  <palves@redhat.com>
4088
4089         * top.c (quit_force): Call 'finalize_values'.
4090         * value.c (finalize_values): New function.
4091         * value.h (finalize_values): Declare.
4092
4093 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4094
4095         * NEWS: Announce $_gdb_major and $_gdb_minor.
4096
4097         * top.c (init_gdb_version_vars): New function.
4098         (gdb_init): Call init_gdb_version_vars.
4099
4100 2019-03-29  Tom Tromey  <tromey@adacore.com>
4101
4102         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4103         help text.  Remove dead code.
4104
4105 2019-03-29  Keith Seitz  <keiths@redhat.com>
4106
4107         From Siddhesh Poyarekar:
4108         * f-lang.h (f77_get_upperbound): Return LONGEST.
4109         (f77_get_lowerbound): Likewise.
4110         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4111         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4112         print them.
4113         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4114         plongest to format print it.
4115         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4116         (f77_get_upperbound): Likewise.
4117         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4118         LOWER_BOUND to LONGEST.
4119         (f77_create_arrayprint_offset_tbl): Likewise.
4120
4121 2019-03-29  Keith Seitz  <keiths@redhat.com>
4122
4123         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4124         %s/pulongest for TYPE_LENGTH instead of %d in format
4125         strings.
4126         * ada-typerint.c (ada_print_type): Likewise.
4127         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4128         * compile/compile-c-support.c (generate_register_struct): Likewise.
4129         * gdbtypes.c (recursive_dump_type): Likewise.
4130         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4131         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4132         instead of %d in format strings.
4133         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4134         to std::min to ULONGEST.
4135         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4136         instead of %d in format strings.
4137         * tracepoint.c (info_scope_command): Likewise.
4138         * typeprint.c (print_offset_data::update)
4139         (print_offset_data::finish): Likewise.
4140         * xtensa-tdep.c (xtensa_store_return_value)
4141         (xtensa_push_dummy_call): Likewise.
4142
4143 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4144
4145         * windows-nat.c (display_selector): Fixed format specifications
4146         for 64-bit Cygwin.
4147
4148 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4149
4150         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4151
4152 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4153
4154         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4155         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4156         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4157         (nios2_linux_init_abi): Install it.
4158
4159 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4160
4161         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4162
4163 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4164
4165         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4166
4167 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4168             Tom Tromey  <tromey@adacore.com>
4169
4170         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4171
4172 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4173
4174         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4175         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4176         method to compute the bounds of range types. Also print "[evaluated]"
4177         if the bounds' values come from a dynamic evaluation.
4178
4179 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4182         whitespace when pretty printing is on.
4183
4184 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4185
4186         * ppc-linux-nat.c: Add include.
4187
4188 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4189
4190         * NEWS: Mention AArch64 Pointer Authentication.
4191
4192 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4193
4194         * arm-linux-nat.c: Add include.
4195
4196 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4197
4198         * source-cache.c (source_cache::get_source_lines): Re-read
4199         fullname after calling open_source_file.
4200
4201 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4202
4203         * NEWS: Mention TLS support for FreeBSD.
4204
4205 2019-03-25  Tom Tromey  <tromey@adacore.com>
4206
4207         * minsyms.c (BUNCH_SIZE): Update comment.
4208         (~minimal_symbol_reader): Remove old comment.
4209         (compact_minimal_symbols): Update comment.
4210         (minimal_symbol_reader::install): Remove old comment.  Update
4211         other comments.
4212
4213 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4214
4215         * s390-linux-nat.c: Add include.
4216
4217 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4218
4219         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4220         Call linux_get_hwcap.
4221         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4222         Likewise.
4223         (aarch64_linux_get_hwcap): Remove function.
4224         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4225         declaration.
4226         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4227         linux_get_hwcap.
4228         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4229         * linux-tdep.c (linux_get_hwcap): Add function.
4230         (linux_get_hwcap2): Likewise.
4231         * linux-tdep.h (linux_get_hwcap): Add declaration.
4232         (linux_get_hwcap2): Likewise.
4233         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4234         (ppc_linux_get_hwcap2): Likewise.
4235         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4236         linux_get_hwcap.
4237         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4238         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4239         (ppc_linux_nat_target::read_description): Likewise.
4240         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4241         * s390-linux-nat.c: Likewise.
4242         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4243
4244 2019-03-24  Tom Tromey  <tom@tromey.com>
4245
4246         * ada-lang.c (standard_lookup): Simplify initialization.
4247         (ada_lookup_symbol_nonlocal): Simplify return.
4248         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4249         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4250         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4251         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4252         initialization.
4253         * solib.c (solib_global_lookup): Simplify.
4254         * symtab.c (null_block_symbol): Remove.
4255         (symbol_cache_lookup): Simplify returns.
4256         (lookup_language_this): Simplify returns.
4257         (lookup_symbol_aux): Simplify return.
4258         (lookup_local_symbol): Simplify returns.
4259         (lookup_global_symbol_from_objfile): Simplify return.
4260         (lookup_symbol_in_objfile_symtabs)
4261         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4262         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4263         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4264         * cp-namespace.c (cp_lookup_bare_symbol)
4265         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4266         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4267         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4268         (cp_lookup_symbol_via_imports): Simplify initialization.
4269         (find_symbol_in_baseclass): Likewise.
4270         * symtab.h (null_block_symbol): Remove.
4271         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4272         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4273         (d_lookup_symbol_module): Likewise.
4274         (find_symbol_in_baseclass): Simplify initialization.
4275
4276 2019-03-24  Tom Tromey  <tom@tromey.com>
4277
4278         * expression.h: Don't include symtab.h.
4279         (struct block): Forward declare.
4280
4281 2019-03-24  Tom Tromey  <tom@tromey.com>
4282
4283         * c-exp.y (typebase): Remove casts.
4284         * gdbtypes.c (lookup_unsigned_typename, )
4285         (lookup_signed_typename): Remove cast.
4286         * eval.c (parse_to_comma_and_eval): Remove cast.
4287         * parse.c (write_dollar_variable): Remove cast.
4288         * block.h (struct block) <superblock>: Now const.
4289         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4290         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4291         (map_block): Make "block" const.
4292         * symfile.h (struct quick_symbol_functions)
4293         <map_matching_symbols>: Constify block argument to "callback".
4294         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4295         const.
4296         (find_pc_sect_compunit_symtab): Make "b" const.
4297         (find_symbol_at_address): Likewise.
4298         (search_symbols): Likewise.
4299         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4300         (dw2_debug_names_lookup_symbol): Likewise.
4301         (dw2_map_matching_symbols): Update.
4302         * p-valprint.c (pascal_val_print): Remove "block".
4303         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4304         (aux_add_nonlocal_symbols): Make "block" const.
4305         (resolve_subexp): Remove cast.
4306         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4307         const.
4308         (iterate_over_file_blocks): Likewise.
4309         * f-exp.y (%union) <bval>: Remove.
4310         * coffread.c (patch_opaque_types): Make "b" const.
4311         * spu-tdep.c (spu_catch_start): Make "block" const.
4312         * c-valprint.c (print_unpacked_pointer): Remove "block".
4313         * symmisc.c (dump_symtab_1): Make "b" const.
4314         (block_depth): Make "block" const.
4315         * d-exp.y (%union) <bval>: Remove.
4316         * cp-support.h (cp_lookup_rtti_type): Update.
4317         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4318         * psymtab.c (psym_lookup_symbol): Make "block" const.
4319         (maintenance_check_psymtabs): Make "b" const.
4320         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4321         (enumerate_locals, enumerate_args): Update.
4322         * python/py-symtab.c (stpy_global_block): Make "block" const.
4323         (stpy_static_block): Likewise.
4324         * inline-frame.c (block_starting_point_at): Make "new_block"
4325         const.
4326         * block.c (find_block_in_blockvector): Make return type const.
4327         (blockvector_for_pc_sect): Make "b" const.
4328         (find_block_in_blockvector): Make "b" const.
4329
4330 2019-03-23  Tom Tromey  <tom@tromey.com>
4331
4332         * varobj.c (varobj_create): Update.
4333         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4334         * printcmd.c (display_command, do_one_display): Don't reset
4335         innermost_block.
4336         * parser-defs.h (enum innermost_block_tracker_type): Move to
4337         expression.h.
4338         (innermost_block): Update comment.
4339         * parse.c (parse_exp_1): Add tracker_types parameter.
4340         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4341         tracker_types parameter.  Reset innermost_block.
4342         (parse_exp_in_context): Remove.
4343         (parse_expression_for_completion): Update.
4344         * objfiles.c (~objfile): Don't reset expression_context_block or
4345         innermost_block.
4346         * expression.h (enum innermost_block_tracker_type): Move from
4347         parser-defs.h.
4348         (parse_exp_1): Add tracker_types parameter.
4349         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4350         reset innermost_block.
4351
4352 2019-03-23  Tom Tromey  <tom@tromey.com>
4353
4354         * objfiles.h: Include bcache.h.
4355
4356 2019-03-23  Tom Tromey  <tom@tromey.com>
4357
4358         * linespec.c (get_current_search_block): Use
4359         scoped_restore_current_language.
4360         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4361
4362 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4363             Jiong Wang  <jiong.wang@arm.com>
4364
4365         * aarch64-linux-tdep.c
4366         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4367         section.
4368         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4369
4370 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4371             Jiong Wang  <jiong.wang@arm.com>
4372
4373         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4374         instructions.
4375         (aarch64_analyze_prologue_test): Add PACIASP test.
4376         (aarch64_prologue_prev_register): Unmask PC value.
4377
4378 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4379             Jiong Wang  <jiong.wang@arm.com>
4380
4381         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4382         (aarch64_dwarf2_prev_register): Unmask PC value.
4383         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4384         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4385         DW_CFA_AARCH64_negate_ra_state.
4386         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4387
4388 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4389             Jiong Wang  <jiong.wang@arm.com>
4390
4391         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4392         registers.
4393         (aarch64_pseudo_register_name): Likewise.
4394         (aarch64_pseudo_register_type): Likewise.
4395         (aarch64_pseudo_register_reggroup_p): Likewise.
4396         (aarch64_gdbarch_init): Add pauth registers.
4397         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4398         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4399         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4400         (struct gdbarch_tdep): Add regnum for ra_state.
4401
4402 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4403             Jiong Wang  <jiong.wang@arm.com>
4404
4405         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4406
4407 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4408             Jiong Wang  <jiong.wang@arm.com>
4409
4410         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4411         function.
4412         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4413         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4414         (aarch64_gdbarch_init): Add puth registers.
4415         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4416         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4417         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4418
4419 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4420             Jiong Wang  <jiong.wang@arm.com>
4421
4422         * aarch64-linux-nat.c
4423         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4424         * aarch64-linux-tdep.c
4425         (aarch64_linux_core_read_description): Likewise.
4426         (aarch64_linux_get_hwcap): New function.
4427         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4428         (aarch64_linux_get_hwcap): New declaration.
4429
4430 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4431             Jiong Wang  <jiong.wang@arm.com>
4432
4433         * aarch64-linux-nat.c
4434         (aarch64_linux_nat_target::read_description): Add pauth param.
4435         * aarch64-linux-tdep.c
4436         (aarch64_linux_core_read_description): Likewise.
4437         * aarch64-tdep.c (struct target_desc): Add in pauth.
4438         (aarch64_read_description): Add pauth param.
4439         (aarch64_gdbarch_init): Likewise.
4440         * aarch64-tdep.h (aarch64_read_description): Likewise.
4441         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4442         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4443         * features/Makefile: Add new files.
4444         * features/aarch64-pauth.c: New file.
4445         * features/aarch64-pauth.xml: New file.
4446
4447 2019-03-20  Tom Tromey  <tromey@adacore.com>
4448
4449         * infrun.c (handle_inferior_event): Rename from
4450         handle_inferior_event_1.  Create a scoped_value_mark.
4451         (handle_inferior_event): Remove.
4452
4453 2019-03-19  Tom Tromey  <tromey@adacore.com>
4454
4455         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4456         * infrun.h (print_stop_event): Add "displays" parameter.
4457         * infrun.c (print_stop_event): Add "displays" parameter.
4458
4459 2019-03-19  Pedro Alves  <palves@redhat.com>
4460
4461         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4462         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4463         to -1.  Fix TABs vs spaces.
4464         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4465         * tui/tui-out.h (tui_ui_out) Add intro comments.
4466         <m_line, m_start_of_line>: In-class initialize, and add describing
4467         comment.
4468
4469 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4470
4471         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4472         variable names.
4473         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4474
4475 2019-03-18  Pedro Alves  <palves@redhat.com>
4476             Eli Zaretskii <eliz@gnu.org>
4477
4478         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4479         m_line and m_start_of_line.
4480
4481 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4482
4483         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4484         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4485         it returns a newline.  This fixes a regression in TU mode, whereby
4486         the next line is output on the same screen line as the user input.
4487
4488 2019-03-18  Tom Tromey  <tromey@adacore.com>
4489
4490         * minsyms.c (minimal_symbol_reader::install): Remove call to
4491         obstack_blank.
4492
4493 2019-03-18  Pedro Alves  <palves@redhat.com>
4494
4495         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4496         New globals.
4497         (apply_style): New, factored out from ...
4498         (apply_ansi_escape): ... this.  Handle reverse video mode.
4499         (tui_set_reverse_mode): New function.
4500         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4501         * tui/tui-winsource.c (tui_show_source_line): Use
4502         tui_set_reverse_mode instead of setting A_STANDOUT.
4503         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4504         New setter methods.
4505
4506 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4507
4508         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4509         Handle tabs.
4510
4511 2019-03-18  Tom Tromey  <tromey@adacore.com>
4512
4513         * ada-lang.c (empty_array): Add "high" parameter.
4514         (ada_evaluate_subexp): Update.
4515
4516 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4517
4518         * unittests/string_view-selftests.c: Define
4519         _initialize_string_view_selftests unconditionally.
4520
4521 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4522
4523         PR gdb/24350
4524         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4525
4526 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4527
4528         PR gdb/24351
4529         * windows-nat.c (display_selector): Fix format specifiers.
4530
4531 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4532
4533         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4534         tui_refill_source_window instead of tui_refresh_win, to update the
4535         current execution line.  This fixes redisplay of the current line
4536         when stepping through the code with "next" or "step".
4537
4538 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4539
4540         * source-cache.c (source_cache::get_source_lines): Call
4541         find_source_lines to initialize s->nlines.  This fixes vertical
4542         scrolling of TUI source window when the DOWN arrow is pressed.
4543
4544 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4545
4546         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4547         linux-thread-db.c (_initialize_thread_db): Likewise.
4548
4549 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4550
4551         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4552         wclrtoeol in tui_show_source_line".  This reverts changes made in
4553         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4554
4555 2019-03-15  Tom Tromey  <tom@tromey.com>
4556
4557         * symtab.h (struct minimal_symbol): Derive from
4558         general_symbol_info.
4559         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4560         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4561         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4562         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4563         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4564         (MSYMBOL_SEARCH_NAME): Update.
4565         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4566         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4567         * minsyms.c (minimal_symbol_reader::record_full): Update.
4568
4569 2019-03-15  Tom Tromey  <tom@tromey.com>
4570
4571         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4572
4573 2019-03-15  Tom Tromey  <tom@tromey.com>
4574
4575         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4576         unique_xmalloc_ptr.
4577         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4578         Update.
4579         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4580         (build_minimal_symbol_hash_tables)
4581         (minimal_symbol_reader::install): Update.
4582
4583 2019-03-15  Tom Tromey  <tom@tromey.com>
4584
4585         * symtab.c (create_demangled_names_hash): Update.
4586         (symbol_set_names): Update.
4587         * objfiles.h (struct objfile_per_bfd_storage)
4588         <demangled_names_hash>: Now an htab_up.
4589         * objfiles.c (objfile_per_bfd_storage): Simplify.
4590
4591 2019-03-15  Tom Tromey  <tom@tromey.com>
4592
4593         * objfiles.h (struct objfile_per_bfd_storage): Declare
4594         destructor.
4595         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4596         New.
4597         (get_objfile_bfd_data): Use new.  Don't initialize
4598         language_of_main.
4599         (free_objfile_per_bfd_storage): Remove.
4600         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4601
4602 2019-03-15  Tom Tromey  <tom@tromey.com>
4603
4604         * symfile.c (reread_symbols): Update.
4605         * objfiles.c (objfile::objfile): Update.
4606         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4607         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4608         comment.
4609         (minimal_symbol_reader::install): Update.
4610         (terminate_minimal_symbol_table): Remove.
4611         * jit.c (jit_object_close_impl): Update.
4612
4613 2019-03-15  Tom Tromey  <tom@tromey.com>
4614
4615         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4616         initializations.
4617
4618 2019-03-15  Tom Tromey  <tom@tromey.com>
4619
4620         * objfiles.h (struct objfile_per_bfd_storage)
4621         <demangled_hash_languages>: Now a bitset.
4622         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4623         (lookup_minimal_symbol): Update.
4624
4625 2019-03-15  Tom Tromey  <tom@tromey.com>
4626
4627         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4628         Don't return the symbol.
4629         * coffread.c (record_minimal_symbol): Use record_full.
4630
4631 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4632
4633         The MS-Windows port of ncurses fails to switch to a color pair if
4634         one or both of the colors are the implicit default colors.  This
4635         change records the default colors when TUI is initialized, and
4636         then specifies them explicitly when a color pair uses the default
4637         colors.  This allows color styling in TUI mode on MS-Windows.
4638
4639         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4640         ncurses_norm_attr.
4641         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4642         colors in ncurses_norm_attr.
4643         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4644         "none", replace it with the default color recorded in
4645         ncurses_norm_attr.
4646
4647 2019-03-14  Tom Tromey  <tromey@adacore.com>
4648
4649         * source-cache.h (class source_cache) <get_source_lines>: Return
4650         std::string.
4651         * source-cache.c (source_cache::extract_lines): Handle case where
4652         first_pos==npos.  Return std::string.
4653         (source_cache::get_source_lines): Update.
4654
4655 2019-03-14  Tom Tromey  <tromey@adacore.com>
4656
4657         * NEWS: Add item for "style sources" commands.
4658         * source-cache.c (source_cache::get_source_lines): Check
4659         source_styling.
4660         * cli/cli-style.c (source_styling): New global.
4661         (_initialize_cli_style): Add "style sources" commands.
4662         (show_style_sources): New function.
4663         * cli/cli-style.h (source_styling): Declare.
4664
4665 2019-03-14  Pedro Alves  <palves@redhat.com>
4666             Tom Tromey  <tromey@adacore.com>
4667
4668         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4669         * tui/tui-winsource.c (tui_refill_source_window): New function,
4670         from...
4671         (tui_horizontal_source_scroll): ... here.  Move some logic.
4672         * cli/cli-style.c (set_style_enabled): Notify new observable.
4673         * tui/tui-hooks.c (tui_redisplay_source): New function.
4674         (tui_attach_detach_observers): Attach or detach
4675         tui_redisplay_source.
4676         * observable.h (source_styling_changed): New observable.
4677         * observable.c: Define source_styling_changed observable.
4678
4679 2019-03-13  Tom Tromey  <tromey@adacore.com>
4680
4681         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4682         (i386_gnu_nat_target::store_registers): Update.
4683         * target-debug.h (target_debug_print_std_string): New macro.
4684         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4685         * windows-tdep.c (display_one_tib): Update.
4686         * tui/tui-stack.c (tui_make_status_line): Update.
4687         * top.c (print_inferior_quit_action): Update.
4688         * thread.c (thr_try_catch_cmd): Update.
4689         (add_thread_with_info): Update.
4690         (thread_target_id_str): Update.
4691         (thr_try_catch_cmd): Update.
4692         (thread_command): Update.
4693         (thread_find_command): Update.
4694         * record-btrace.c (record_btrace_target::info_record)
4695         (record_btrace_resume_thread, record_btrace_target::resume)
4696         (record_btrace_cancel_resume, record_btrace_step_thread)
4697         (record_btrace_target::wait, record_btrace_target::wait)
4698         (record_btrace_target::wait, record_btrace_target::stop): Update.
4699         * progspace.c (print_program_space): Update.
4700         * process-stratum-target.c
4701         (process_stratum_target::thread_address_space): Update.
4702         * linux-fork.c (linux_fork_mourn_inferior)
4703         (detach_checkpoint_command, info_checkpoints_command)
4704         (linux_fork_context): Update.
4705         (linux_fork_detach): Update.
4706         (class scoped_switch_fork_info): Update.
4707         (delete_checkpoint_command): Update.
4708         * infrun.c (follow_fork_inferior): Update.
4709         (follow_fork_inferior): Update.
4710         (proceed_after_vfork_done): Update.
4711         (handle_vfork_child_exec_or_exit): Update.
4712         (follow_exec): Update.
4713         (displaced_step_prepare_throw): Update.
4714         (displaced_step_restore): Update.
4715         (start_step_over): Update.
4716         (resume_1): Update.
4717         (clear_proceed_status_thread): Update.
4718         (proceed): Update.
4719         (print_target_wait_results): Update.
4720         (do_target_wait): Update.
4721         (context_switch): Update.
4722         (stop_all_threads): Update.
4723         (restart_threads): Update.
4724         (finish_step_over): Update.
4725         (handle_signal_stop): Update.
4726         (switch_back_to_stepped_thread): Update.
4727         (keep_going_pass_signal): Update.
4728         (print_exited_reason): Update.
4729         (normal_stop): Update.
4730         * inferior.c (inferior_pid_to_str): Change return type.
4731         (print_selected_inferior): Update.
4732         (add_inferior): Update.
4733         (detach_inferior): Update.
4734         * dummy-frame.c (fprint_dummy_frames): Update.
4735         * dcache.c (dcache_info_1): Update.
4736         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4737         (btrace_fetch, btrace_clear): Update.
4738         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4739         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4740         type.
4741         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4742         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4743         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4744         * gdbarch.c, gdbarch.h: Rebuild.
4745         * gdbarch.sh (core_pid_to_str): Change return type.
4746         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4747         return type.
4748         (windows_nat_target::pid_to_str): Change return type.
4749         (windows_delete_thread): Update.
4750         (windows_nat_target::attach): Update.
4751         (windows_nat_target::files_info): Update.
4752         * target-delegates.c: Rebuild.
4753         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4754         return type.
4755         (sol_thread_target::pid_to_str): Change return type.
4756         * remote.c (class remote_target) <pid_to_str>: Change return
4757         type.
4758         (remote_target::pid_to_str): Change return type.
4759         (extended_remote_target::attach, remote_target::remote_stop_ns)
4760         (remote_target::remote_notif_remove_queued_reply)
4761         (remote_target::push_stop_reply, remote_target::disable_btrace):
4762         Update.
4763         (extended_remote_target::attach): Update.
4764         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4765         type.
4766         (gdbsim_target::pid_to_str): Change return type.
4767         * ravenscar-thread.c (struct ravenscar_thread_target)
4768         <pid_to_str>: Change return type.
4769         (ravenscar_thread_target::pid_to_str): Change return type.
4770         * procfs.c (class procfs_target) <pid_to_str>: Change return
4771         type.
4772         (procfs_target::pid_to_str): Change return type.
4773         (procfs_target::attach): Update.
4774         (procfs_target::detach): Update.
4775         (procfs_target::fetch_registers): Update.
4776         (procfs_target::store_registers): Update.
4777         (procfs_target::wait): Update.
4778         (procfs_target::files_info): Update.
4779         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4780         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4781         return type.
4782         (nto_procfs_target::pid_to_str): Change return type.
4783         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4784         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4785         return type.
4786         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4787         (exit_lwp): Update.
4788         (attach_proc_task_lwp_callback, get_detach_signal)
4789         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4790         (linux_nat_target::resume, wait_lwp, stop_callback)
4791         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4792         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4793         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4794         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4795         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4796         type.
4797         (inf_ptrace_target::attach): Update.
4798         (inf_ptrace_target::files_info): Update.
4799         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4800         type.
4801         (go32_nat_target::pid_to_str): Change return type.
4802         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4803         (gnu_nat_target::wait): Update.
4804         (gnu_nat_target::wait): Update.
4805         (gnu_nat_target::resume): Update.
4806         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4807         (fbsd_nat_target::wait): Update.
4808         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4809         type.
4810         (darwin_nat_target::attach): Update.
4811         * corelow.c (class core_target) <pid_to_str>: Change return type.
4812         (core_target::pid_to_str): Change return type.
4813         * target.c (normal_pid_to_str): Change return type.
4814         (default_pid_to_str): Likewise.
4815         (target_pid_to_str): Change return type.
4816         (target_translate_tls_address): Update.
4817         (target_announce_detach): Update.
4818         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4819         return type.
4820         (bsd_uthread_target::pid_to_str): Change return type.
4821         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4822         type.
4823         (bsd_kvm_target::pid_to_str): Change return type.
4824         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4825         return type.
4826         (aix_thread_target::pid_to_str): Change return type.
4827         * target.h (struct target_ops) <pid_to_str>: Change return type.
4828         (target_pid_to_str, normal_pid_to_str): Likewise.
4829         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4830         type.
4831         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4832         type.
4833         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4834         return type.
4835         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4836         type.
4837         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4838         type.
4839         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4840         return type.
4841
4842 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4843
4844         * NEWS: Mention that the new default MI version is 3.  Mention
4845         changes to the output of commands and events that deal with
4846         multi-location breakpoints.
4847         * breakpoint.c: Include "mi/mi-out.h".
4848         (print_one_breakpoint): Change output syntax if using MI version
4849         >= 3.
4850         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4851         New.
4852         (mi_multi_location_breakpoint_output_fixed): New.
4853         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4854         (mi_cmd_fix_multi_location_breakpoint_output): New.
4855         (mi_multi_location_breakpoint_output_fixed): New.
4856         * mi/mi-cmds.c (mi_cmds): Register command
4857         -fix-multi-location-breakpoint-output.
4858         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4859         interpreter "mi".
4860
4861 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4862
4863         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4864         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4865         instantiate mi_ui_out based on interpreter name.
4866         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4867         * mi/mi-main.c (mi_load_progress): Likewise.
4868
4869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4870
4871         * NEWS: Combine separate "New targets" sections for 8.3.
4872
4873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4874
4875         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4876         (ppcfbsd_init_abi): Install gdbarch
4877         "fetch_tls_load_module_address" and "get_thread_local_address"
4878         methods.
4879
4880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4881
4882         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4883         (riscv_fbsd_init_abi): Install gdbarch
4884         "fetch_tls_load_module_address" and "get_thread_local_address"
4885         methods.
4886
4887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4888
4889         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4890         (i386fbsd_init_abi): Install gdbarch
4891         "fetch_tls_load_module_address" and "get_thread_local_address"
4892         methods.
4893
4894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4895
4896         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4897         (amd64fbsd_init_abi): Install gdbarch
4898         "fetch_tls_load_module_address" and "get_thread_local_address"
4899         methods.
4900
4901 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4902
4903         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4904         (struct fbsd_pspace_data): New type.
4905         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4906         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4907         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4908         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4909         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4910
4911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4912
4913         * gdbtypes.c (lookup_struct_elt): New function.
4914         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4915         * gdbtypes.h (struct struct_elt): New type.
4916         (lookup_struct_elt): New prototype.
4917
4918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4919
4920         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4921         remove disabled code block.
4922
4923 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4924
4925         * gdbarch.sh (get_thread_local_address): New method.
4926         * gdbarch.h, gdbarch.c: Regenerate.
4927         * target.c (target_translate_tls_address): Use
4928         gdbarch_get_thread_local_address if present instead of
4929         target::get_thread_local_address.
4930
4931 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4932
4933         * target.h (target::get_thread_local_address): Update comment.
4934
4935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4936
4937         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4938         objfile->separate_debug_objfile_backlink if not NULL.
4939
4940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4941
4942         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4943         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4944         (amd64bsd_store_inferior_registers): Likewise.
4945         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4946         Enable segment base registers.
4947         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4948         PT_GETFSBASE and PT_GETGSBASE.
4949         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4950         PT_SETGSBASE.
4951         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4952         segment base registers.
4953         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4954
4955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4956
4957         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4958         Update calls to i386_target_description to add 'segments'
4959         parameter.
4960         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4961         add segment base registers.
4962         * arch/i386.c (i386_create_target_description): Add 'segments'
4963         parameter to enable segment base registers.
4964         * arch/i386.h (i386_create_target_description): Likewise.
4965         * features/i386/32bit-segments.xml: New file.
4966         * features/i386/32bit-segments.c: Generate.
4967         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4968         call to i386_target_description to add 'segments' parameter.
4969         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4970         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4971         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4972         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4973         if feature is present.
4974         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4975         Add 'segments' parameter to call to i386_target_description.
4976         (i386_target_description): Add 'segments' parameter to enable
4977         segment base registers.
4978         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4979         to call to i386_target_description.
4980         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4981         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4982         Define I386_NUM_REGS.
4983         (i386_target_description): Add 'segments' parameter to enable
4984         segment base registers.
4985
4986 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4987
4988         PR/24325
4989         * source-cache.c: #undef open and close, to avoid unresolved
4990         externals during linking.
4991
4992 2019-03-12  Tom Tromey  <tromey@adacore.com>
4993
4994         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4995         const.  Add initializers.
4996         (_initialize_remote): Don't initialize ptid globals.
4997
4998 2019-03-12  Pedro Alves  <palves@redhat.com>
4999
5000         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5001
5002 2019-03-12  Pedro Alves  <palves@redhat.com>
5003
5004         * cp-name-parser.y (main): Remove unused 'len' variable.
5005
5006 2019-03-12  Tom Tromey  <tromey@adacore.com>
5007
5008         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5009         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5010
5011 2019-03-12  Tom Tromey  <tromey@adacore.com>
5012
5013         * linux-nat.c (iterate_over_lwps): Update.
5014         (stop_callback): Remove parameter.
5015         (stop_wait_callback, detach_callback, resume_set_callback)
5016         (select_singlestep_lwp_callback, set_ignore_sigint)
5017         (status_callback, resumed_callback, resume_clear_callback)
5018         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5019         data parameter.
5020         (linux_nat_target::detach, linux_nat_target::resume)
5021         (linux_stop_and_wait_all_lwps, select_event_lwp)
5022         (linux_nat_filter_event, linux_nat_wait_1)
5023         (linux_nat_target::kill, linux_nat_target::stop)
5024         (linux_nat_target::stop): Update.
5025         (linux_nat_resume_callback): Change type.
5026         (resume_stopped_resumed_lwps, count_events_callback)
5027         (select_event_lwp_callback): Likewise.
5028         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5029         * arm-linux-nat.c (struct update_registers_data): Remove.
5030         (update_registers_callback): Change type.
5031         (arm_linux_insert_hw_breakpoint1): Update.
5032         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5033         parameter.
5034         (x86_linux_dr_set_addr): Update.
5035         (x86_linux_dr_set_control): Update.
5036         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5037         (iterate_over_lwps): Use gdb::function_view.
5038         * nat/aarch64-linux-hw-point.c (struct
5039         aarch64_dr_update_callback_param): Remove.
5040         (debug_reg_change_callback): Change type.
5041         (aarch64_notify_debug_reg_change): Update.
5042         * s390-linux-nat.c (s390_refresh_per_info): Update.
5043
5044 2019-03-11  Tom Tromey  <tromey@adacore.com>
5045
5046         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5047         redundant assignment to "this_cu".
5048
5049 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5050
5051         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5052
5053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5054
5055         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5056         from...
5057         (rank_one_type): ... this.
5058
5059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5060
5061         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5062         from...
5063         (rank_one_type): ... this.
5064
5065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5066
5067         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5068         from...
5069         (rank_one_type): ... this.
5070
5071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5072
5073         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5074         from...
5075         (rank_one_type): ... this.
5076
5077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5078
5079         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5080         from...
5081         (rank_one_type): ... this.
5082
5083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5084
5085         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5086         from...
5087         (rank_one_type): ... this.
5088
5089 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5090
5091         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5092         from...
5093         (rank_one_type): ... this.
5094
5095 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5096
5097         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5098         from...
5099         (rank_one_type): ... this.
5100
5101 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5102
5103         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5104         from...
5105         (rank_one_type): ... this.
5106
5107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5108
5109         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5110         from...
5111         (rank_one_type): ... this.
5112
5113 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5114
5115         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5116         from...
5117         (rank_one_type): ... this.
5118
5119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5120
5121         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5122         from...
5123         (rank_one_type): ... this.
5124
5125 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5126
5127         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5128         inferior-events' shows the example events.
5129
5130 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5131
5132         Support styling on native MS-Windows console
5133
5134         PR/24315
5135         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5136         on MS-Windows if $TERM is not defined.
5137
5138         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5139
5140         * posix-hdep.c (gdb_console_fputs):
5141         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5142         functions.
5143         * ui-file.h (gdb_console_fputs): Add prototype.
5144
5145         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5146         back to fputs only if the former returns zero.
5147
5148 2019-03-07  Tom Tromey  <tom@tromey.com>
5149
5150         * symmisc.c (print_symbol_bcache_statistics): Update.
5151         (print_objfile_statistics): Update.
5152         * symfile.c (allocate_symtab): Update.
5153         * stabsread.c: Don't include bcache.h.
5154         * psymtab.h (struct psymbol_bcache): Don't declare.
5155         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5156         (psymbol_bcache_init, psymbol_bcache_free)
5157         (psymbol_bcache_get_bcache): Don't declare.
5158         * psymtab.c (struct psymbol_bcache): Remove.
5159         (psymtab_storage::psymtab_storage): Update.
5160         (psymtab_storage::~psymtab_storage): Update.
5161         (psymbol_bcache_init, psymbol_bcache_free)
5162         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5163         (add_psymbol_to_bcache): Update.
5164         (allocate_psymtab): Update.
5165         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5166         macro_cache>: No longer pointers.
5167         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5168         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5169         * macrotab.c (macro_bcache): Update.
5170         * macroexp.c: Don't include bcache.h.
5171         * gdbtypes.c (check_types_worklist): Update.
5172         (types_deeply_equal): Remove TRY/CATCH.  Update.
5173         * elfread.c (elf_symtab_read): Update.
5174         * dwarf2read.c: Don't include bcache.h.
5175         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5176         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5177         (print_bcache_statistics, bcache_memory_used): Don't declare.
5178         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5179         methods.  Rename all data members.
5180         * bcache.c (struct bcache): Move to bcache.h.
5181         (bcache::expand_hash_table): Rename from expand_hash_table.
5182         (bcache): Remove.
5183         (bcache::insert): Rename from bcache_full.
5184         (bcache::compare): Rename from bcache_compare.
5185         (bcache_xmalloc): Remove.
5186         (bcache::~bcache): Rename from bcache_xfree.
5187         (bcache::print_statistics): Rename from print_bcache_statistics.
5188         (bcache::memory_used): Rename from bcache_memory_used.
5189
5190 2019-03-07  Pedro Alves  <palves@redhat.com>
5191
5192         * infrun.c (normal_stop): Also check for
5193         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5194
5195 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5196
5197         * f-lang.c (value_from_host_double): Moved to...
5198         * value.c (value_from_host_double): ...here.
5199         * value.h (value_from_host_double): Declare.
5200         * guile/scm-math.c (vlscm_convert_typed_number): Use
5201         value_from_host_double.
5202         (vlscm_convert_number): Likewise.
5203         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5204         * python/py-value.c (convert_value_from_python): Likewise.
5205
5206 2019-03-06  Tom Tromey  <tom@tromey.com>
5207
5208         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5209
5210 2019-03-06  Tom Tromey  <tom@tromey.com>
5211
5212         * utils.h (free_current_contents): Don't declare.
5213         * utils.c (free_current_contents): Remove.
5214
5215 2019-03-06  Tom Tromey  <tom@tromey.com>
5216
5217         * top.c (quit_force): Update.
5218         * main.c (captured_command_loop): Update.
5219         * common/new-op.c (operator new): Update.
5220         * common/common-exceptions.c (struct catcher)
5221         <save_cleanup_chain>: Remove member.
5222         (exceptions_state_mc_init): Update.
5223         (exception_try_scope_entry): Return nullptr.
5224         (exception_try_scope_exit, exception_rethrow)
5225         (throw_exception_sjlj, throw_exception_cxx): Update.
5226         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5227         (all_cleanups, do_cleanups, discard_cleanups)
5228         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5229         (restore_cleanups, restore_final_cleanups): Don't declare.
5230         (do_final_cleanups): Remove parameter.
5231         * common/cleanups.c (cleanup_chain, make_cleanup)
5232         (make_cleanup_dtor, all_cleanups, do_cleanups)
5233         (discard_my_cleanups, discard_cleanups)
5234         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5235         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5236         (null_cleanup): Remove.
5237         (do_final_cleanups): Remove parameter.
5238
5239 2019-03-06  Tom Tromey  <tom@tromey.com>
5240
5241         * remote.c (remote_target::remote_parse_stop_reply): Use
5242         unique_xmalloc_ptr.
5243
5244 2019-03-06  Tom Tromey  <tom@tromey.com>
5245
5246         * stabsread.c (struct stabs_field_info): Rename from field_info.
5247         <list, fnlist>: Add initializers.
5248         <obstack>: New member.
5249         (read_member_functions, read_struct_fields, read_baseclasses):
5250         Allocate on obstack.  Don't use cleanups.
5251         (read_one_struct_field, read_member_functions, read_struct_fields)
5252         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5253         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5254         (read_struct_type): Update.
5255
5256 2019-03-06  Tom Tromey  <tom@tromey.com>
5257
5258         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5259         * common/filestuff.h (make_cleanup_close): Don't declare.
5260         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5261         Remove.
5262
5263 2019-03-06  Tom Tromey  <tom@tromey.com>
5264
5265         * solib-aix.c: Use make_scope_exit.
5266
5267 2019-03-06  Tom Tromey  <tom@tromey.com>
5268
5269         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5270         Use make_scope_exit.
5271
5272 2019-03-06  Tom Tromey  <tom@tromey.com>
5273
5274         * solib-svr4.c (disable_probes_interface): Remove parameter.
5275         (svr4_handle_solib_event): Use make_scope_exit.
5276
5277 2019-03-06  Tom Tromey  <tom@tromey.com>
5278
5279         * remote.c (struct stop_reply_deleter): Remove.
5280         (stop_reply_up): Update.
5281         (struct stop_reply): Derive from notif_event.  Don't typedef.
5282         <regcache>: Now a std::vector.
5283         (stop_reply_xfree): Remove.
5284         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5285         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5286         (remote_target::discard_pending_stop_replies): Use delete.
5287         (remote_target::remote_parse_stop_reply): Update.
5288         (remote_target::process_stop_reply): Update.
5289         * remote-notif.h (struct notif_event): Add virtual destructor.
5290         Remove "dtr" member.
5291         (struct notif_client) <alloc_event>: Return a unique_ptr.
5292         (notif_event_xfree): Don't declare.
5293         (notif_event_up): New typedef.
5294         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5295         (notif_event_xfree, do_notif_event_xfree): Remove.
5296         (remote_notif_state_xfree): Update.
5297
5298 2019-03-06  Tom Tromey  <tom@tromey.com>
5299
5300         * infrun.c (displaced_step_clear_cleanup): Now a
5301         forward_scope_exit type.
5302         (displaced_step_prepare_throw): Update.
5303         (displaced_step_fixup): Update.
5304
5305 2019-03-06  Tom Tromey  <tom@tromey.com>
5306
5307         * inferior.h (class inferior): Update comment.
5308         * gdbthread.h (class thread_info): Update comment.
5309
5310 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5311             Tom Tromey  <tom@tromey.com>
5312
5313         * stabsread.h (struct stab_section_list): Remove.
5314         (coffstab_build_psymtabs): Update.
5315         * dbxread.c (symbuf_sections): Now a std::vector.
5316         (sect_idx): New global.
5317         (fill_symbuf): Update.
5318         (coffstab_build_psymtabs): Change type of stabsects parameter.
5319         Update.
5320         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5321         std::vector.
5322         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5323         (coff_locate_sections): Update.
5324         (coff_symfile_read): Remove cleanups.  Update.
5325         (init_stringtab): Add storage parameter.
5326         (free_stringtab, free_stringtab_cleanup): Remove.
5327         (init_lineno): Add storage parameter.
5328         (free_linetab, free_linetab_cleanup): Remove.
5329
5330 2019-03-06  Pedro Alves  <palves@redhat.com>
5331
5332         * linux-fork.c (fork_info::clobber_regs): Delete.
5333         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5334         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5335         comment.  Adjust.
5336         (scoped_switch_fork_info::scoped_switch_fork_info)
5337         (checkpoint_command, linux_fork_context): Adjust
5338         fork_save_infrun_state calls.
5339
5340 2019-03-06  Pedro Alves  <palves@redhat.com>
5341
5342         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5343         (inf_has_multiple_threads): Return 'bool' and rewrite using
5344         inferior_info::threads().
5345
5346 2019-03-06  Pedro Alves  <palves@redhat.com>
5347
5348         * linux-fork.c: Include <list>.
5349         (fork_list): Now a std::list instance.
5350         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5351         (forks_exist_p, find_last_fork): Adjust.
5352         (new_fork): Delete.
5353         (one_fork_p): New.
5354         (add_fork): Adjust.
5355         (free_fork): Delete, folded into fork_info::~fork_info().
5356         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5357         Adjust.
5358         (init_fork_list): Delete.
5359         (linux_fork_killall, linux_fork_mourn_inferior)
5360         (linux_fork_detach, info_checkpoints_command): Adjust.
5361         (_initialize_linux_fork): No longer call init_fork_list.
5362
5363 2019-03-06  Pedro Alves  <palves@redhat.com>
5364
5365         * linux-fork.c (new_fork): New, split out of ...
5366         (add_fork): ... this.  Return void.  Move "first fork" special
5367         case from here, to ...
5368         (checkpoint_command): ... here.
5369         * linux-linux.h (add_fork): Return void.
5370
5371 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5374
5375 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5376             Chris January  <chris.january@arm.com>
5377             David Lecomber  <david.lecomber@arm.com>
5378
5379         * f-exp.y: New token, UNOP_INTRINSIC.
5380         (exp): New pattern using UNOP_INTRINSIC token.
5381         (f77_keywords): Add 'abs' keyword.
5382         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5383         (value_from_host_double): New function.
5384         (evaluate_subexp_f): Support UNOP_ABS.
5385
5386 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5387
5388         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5389         types.
5390
5391 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5392
5393         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5394         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5395         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5396
5397 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5398
5399         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5400
5401 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5402             Chris January  <chris.january@arm.com>
5403
5404         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5405         * f-exp.y: Define 'KIND' token.
5406         (exp): New pattern for KIND expressions.
5407         (ptype): Handle types with a kind extension.
5408         (direct_abs_decl): Extend to spot kind extensions.
5409         (f77_keywords): Add 'kind' to the list.
5410         (push_kind_type): New function.
5411         (convert_to_kind_type): New function.
5412         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5413         * parse.c (operator_length_standard): Likewise.
5414         * parser-defs.h (enum type_pieces): Add tp_kind.
5415         * std-operator.def: Add UNOP_KIND.
5416
5417 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5418
5419         * f-exp.y (f_parse): Set yydebug.
5420
5421 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5422
5423         * f-lang.c (evaluate_subexp_f): New function.
5424         (exp_descriptor_f): New global.
5425         (f_language_defn): Use exp_descriptor_f instead of
5426         exp_descriptor_standard.
5427
5428 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5429
5430         * f-exp.y (struct token): Add comments.
5431         (dot_ops): Remove uppercase versions and the end marker.
5432         (f77_keywords): Likewise.
5433         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5434         entries in the dot_ops array are case insensitive, and use
5435         strncasecmp to compare strings.  Also some whitespace cleanup in
5436         this area.  Similar for the f77_keywords array, except entries in
5437         this list might be case sensitive.
5438
5439 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5440
5441         * f-exp.y (struct f77_boolean_val): Add comments.
5442         (boolean_values): Remove uppercase versions, and end marker.
5443         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5444         and use strncasecmp to achieve case insensitivity.  Additionally,
5445         perform whitespace cleanup around this code.
5446
5447 2019-03-06  Tom Tromey  <tromey@adacore.com>
5448
5449         * remote-sim.c (gdbsim_target_open): Use result of
5450         gdb_argv::release.
5451
5452 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5453         Dirk Schubert  <dirk.schubert@arm.com>
5454         Chris January  <chris.january@arm.com>
5455
5456         * eval.c (evaluate_subexp_standard): Call Fortran argument
5457         wrapping logic.
5458         * f-lang.c (struct value): A value which can be passed into a
5459         Fortran function call.
5460         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5461         where appropriate.
5462         (struct type): Value ready for a Fortran function call.
5463         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5464         is needed.
5465         * f-lang.h (fortran_argument_convert): Declaration.
5466         (fortran_preserve_arg_pointer): Declaration.
5467         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5468
5469 2019-03-05  Tom Tromey  <tromey@adacore.com>
5470
5471         * python/py-prettyprint.c (print_string_repr): Remove #if.
5472         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5473
5474 2019-03-05  Tom Tromey  <tromey@adacore.com>
5475
5476         * target.c (the_dummy_target): Move later.  Change type to
5477         "dummy_target".
5478         (initialize_targets): Don't initialize the_dummy_target.
5479
5480 2019-03-05  Tom Tromey  <tromey@adacore.com>
5481
5482         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5483         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5484
5485 2019-03-05  Tom Tromey  <tromey@adacore.com>
5486
5487         * windows-nat.c (windows_nat_target::attach)
5488         (windows_nat_target::detach): Don't call gdb_flush.
5489         * valprint.c (generic_val_print, val_print, val_print_string):
5490         Don't call gdb_flush.
5491         * utils.c (defaulted_query): Don't call gdb_flush.
5492         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5493         * target.c (target_announce_detach): Don't call gdb_flush.
5494         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5495         * remote.c (extended_remote_target::attach): Don't call
5496         gdb_flush.
5497         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5498         * printcmd.c (do_examine): Don't call gdb_flush.
5499         (info_display_command): Don't call gdb_flush.
5500         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5501         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5502         * memattr.c (info_mem_command): Don't call gdb_flush.
5503         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5504         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5505         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5506         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5507         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5508         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5509         (gnu_nat_target::detach): Don't call gdb_flush.
5510         * f-valprint.c (f_val_print): Don't call gdb_flush.
5511         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5512         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5513         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5514         gdb_flush.
5515         * c-valprint.c (c_val_print): Don't call gdb_flush.
5516         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5517
5518 2019-03-05  Tom Tromey  <tromey@adacore.com>
5519
5520         * varobj.c (update_dynamic_varobj_children): Update.
5521         (install_default_visualizer): Use reset, not release.
5522         * value.c (set_internalvar): Update.
5523         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5524         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5525         ATTRIBUTE_UNUSED_RESULT.
5526
5527 2019-03-05  Tom Tromey  <tromey@adacore.com>
5528
5529         * remote.c (class scoped_remote_fd) <release>: Add
5530         ATTRIBUTE_UNUSED_RESULT.
5531
5532 2019-03-05  Tom Tromey  <tromey@adacore.com>
5533
5534         * macroexp.c (struct macro_buffer) <release>: Add
5535         ATTRIBUTE_UNUSED_RESULT.
5536
5537 2019-03-05  Tom Tromey  <tromey@adacore.com>
5538
5539         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5540         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5541         ATTRIBUTE_UNUSED_RESULT.
5542
5543 2019-03-05  Tom Tromey  <tromey@adacore.com>
5544
5545         * common/scoped_fd.h (class scoped_fd) <release>: Add
5546         ATTRIBUTE_UNUSED_RESULT.
5547
5548 2019-03-05  Tom Tromey  <tromey@adacore.com>
5549
5550         * parser-defs.h (struct parser_state) <release>: Add
5551         ATTRIBUTE_UNUSED_RESULT.
5552
5553 2019-03-05  Tom Tromey  <tromey@adacore.com>
5554
5555         * utils.h (class gdb_argv) <release>: Add
5556         ATTRIBUTE_UNUSED_RESULT.
5557         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5558
5559 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5560
5561         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5562         for-loop range, to avoid compiler warnings.
5563
5564         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5565         avoid compiler warnings about unused variables.
5566
5567         * NEWS: Mention end of support for native debugging on MS-Windows
5568         before XP.
5569
5570         PR gdb/24292
5571         * common/netstuff.c:
5572         * gdbserver/gdbreplay.c
5573         * gdbserver/remote-utils.c:
5574         * ser-tcp.c:
5575         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5576         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5577         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5578         'getaddrinfo' and 'freeaddrinfo' were not available before
5579         Windows XP, and mingw.org's MinGW headers by default define
5580         _WIN32_WINNT to 0x500.
5581
5582 2019-03-01  Gary Benson <gbenson@redhat.com>
5583
5584         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5585
5586 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5587             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5588
5589         PR gdb/8527
5590         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5591         set_sigint_trap, clear_sigint_trap.
5592
5593 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5594
5595         * target.c (target_detach): Clear the regcache and the
5596         frame cache.
5597
5598 2019-02-27  Pedro Alves  <palves@redhat.com>
5599
5600         * utils.c (set_screen_size): When we cap the height/width sizes,
5601         tweak the corresponding command variable to show "unlimited":
5602
5603 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5604             Pedro Alves  <palves@redhat.com>
5605
5606         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5607         before calling rl_set_screen_size.
5608
5609 2019-02-27  Tom Tromey  <tromey@adacore.com>
5610
5611         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5612         define.
5613         * python/py-value.c: Remove Python 2.4 workaround.
5614         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5615         workaround.
5616         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5617         Python 2.4 workaround.
5618         * python/python-internal.h: Remove Python 2.4 comment.
5619         (Py_ssize_t): Don't define.
5620         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5621         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5622         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5623         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5624         * python/python.c (do_start_initialization): Remove Python 2.4
5625         workaround.
5626         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5627         (print_children): Remove Python 2.4 workaround.
5628         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5629         workaround.
5630         (CHARBUFFERPROC_NAME): Remove.
5631         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5632         Python 2.4 workaround.
5633
5634 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5635
5636         * NEWS: Note minimum Python version.
5637
5638 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5639
5640         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5641         code from these functions.  Remove corresponding ifdefs.  Use
5642         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5643         Remove gotos and target of gotos.
5644         (infpy_search_memory): Likewise.
5645
5646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5649         (hppa_gdbarch_init): Don't register deleted functions with
5650         gdbarch.
5651
5652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5653
5654         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5655         (h8300_unwind_sp): Delete.
5656         (h8300_dummy_id): Delete.
5657         (h8300_gdbarch_init): Don't register deleted functions with
5658         gdbarch.
5659
5660 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5661
5662         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5663         (ft32_unwind_pc): Delete.
5664         (ft32_unwind_sp): Delete.
5665         (ft32_gdbarch_init): Don't register deleted functions with
5666         gdbarch.
5667
5668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5671         (frv_unwind_pc): Delete.
5672         (frv_unwind_sp): Delete.
5673         (frv_gdbarch_init): Don't register deleted functions with
5674         gdbarch.
5675
5676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5677
5678         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5679         (riscv_unwind_pc): Delete.
5680         (riscv_unwind_sp): Delete.
5681         (riscv_gdbarch_init): Don't register deleted functions with
5682         gdbarch.
5683
5684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5685
5686         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5687         (csky_unwind_pc): Delete.
5688         (csky_unwind_sp): Delete.
5689         (csky_gdbarch_init): Don't register deleted functions with
5690         gdbarch.
5691
5692 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5693
5694         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5695         (cris_unwind_pc): Delete.
5696         (cris_unwind_sp): Delete.
5697         (cris_gdbarch_init): Don't register deleted functions with
5698         gdbarch.
5699
5700 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5701
5702         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5703         (bfin_unwind_pc): Delete.
5704         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5705
5706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5709         (arm_unwind_pc): Delete.
5710         (arm_unwind_sp): Delete.
5711         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5712
5713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5714
5715         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5716         (arc_unwind_pc): Delete.
5717         (arc_unwind_sp): Delete.
5718         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5719
5720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5721
5722         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5723         (alpha_unwind_pc): Delete.
5724         (alpha_gdbarch_init): Don't register deleted functions with
5725         gdbarch.
5726
5727 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5728
5729         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5730         (aarch64_unwind_pc): Delete.
5731         (aarch64_unwind_sp): Delete.
5732         (aarch64_gdbarch_init): Don't register deleted functions with
5733         gdbarch.
5734
5735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * gdbtypes.c (type_align): Don't consider static members when
5738         computing structure alignment.
5739
5740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5741
5742         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5743         return 0 for other types.
5744         * arch-utils.c (default_type_align): Always return 0.
5745         * gdbarch.h: Regenerate.
5746         * gdbarch.sh (type_align): Extend comment.
5747         * gdbtypes.c (type_align): Add additional comments, always call
5748         gdbarch_type_align before applying the default rules.
5749         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5750         generic code will then apply a suitable default.
5751         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5752         types, return 0 for other types.
5753
5754 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5755
5756         * NEWS: Create a new section for the next release branch.
5757         Rename the section of the current branch, now that it has
5758         been cut.
5759
5760 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5761
5762         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5763         * version.in: Bump version to 8.3.50.DATE-git.
5764
5765 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5766
5767         * aix-thread.c (ptid_cmp): Remove unused variable.
5768         (get_signaled_thread): Likewise.
5769         (store_regs_user_thread): Likewise.
5770         (store_regs_kernel_thread): Likewise.
5771         (fetch_regs_kernel_thread): Remove shadowed variable.
5772
5773 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5774
5775         * features/riscv/32bit-cpu.xml: Add register numbers.
5776         * features/riscv/32bit-fpu.c: Regenerate.
5777         * features/riscv/32bit-fpu.xml: Add register numbers.
5778         * features/riscv/64bit-cpu.xml: Add register numbers.
5779         * features/riscv/64bit-fpu.c: Regenerate.
5780         * features/riscv/64bit-fpu.xml: Add register numbers.
5781
5782 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5783
5784         * NEWS: Mention two argument form of gdb.Value constructor.
5785         * python/py-value.c (convert_buffer_and_type_to_value): New
5786         function.
5787         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5788         Add support for handling an optional second argument.  Call
5789         convert_buffer_and_type_to_value as appropriate.
5790         * python/python-internal.h (Py_buffer_deleter): New struct.
5791         (Py_buffer_up): New typedef.
5792
5793 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5794
5795         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5796         instead of releasing ownership.
5797
5798 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5799
5800         * dwarf2read.c (open_and_init_dwp_file): Call
5801         elf_numsections instead of bfd_count_sections to initialize
5802         dwp_file->num_sections.
5803
5804 2019-02-25  Tom Tromey  <tromey@adacore.com>
5805
5806         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5807
5808 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5809
5810         * gcore.in: Add '--readnever' option when invoking GDB.
5811
5812 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5813
5814         * MAINTAINERS: Update my email address.
5815
5816 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5817
5818         * build-id.c (build_id_to_debug_bfd_1): New function.
5819         (build_id_to_debug_bfd): Look for separate debug file in
5820         sysroot.
5821
5822 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5823
5824         * gdbarch.sh: Update the copyright year range that is placed into
5825         generated files.
5826
5827 2019-02-22  Keith Seitz  <keiths@redhat.com>
5828
5829         PR symtab/23853
5830         * linespec.c (create_sals_line_offset): Search for the default
5831         symtab's filename instead of its fullname.
5832
5833 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5834
5835         * NEWS: Update style defaults.
5836
5837 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5838
5839         * main.c (captured_main_1): Disable styling in batch mode.
5840
5841 2019-02-20  Tom Tromey  <tom@tromey.com>
5842
5843         * symtab.c (symtab_symbol_info): Fix typos.
5844
5845 2019-02-20  Tom Tromey  <tromey@adacore.com>
5846
5847         * findcmd.c (_initialize_mem_search): Use upper case for
5848         metasyntactic variables.
5849
5850 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5851
5852         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5853         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5854
5855 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5856
5857         * top.h (source_file_name): Change to std::string.
5858         * top.c (source_file_name): Likewise.
5859         (command_line_input): Adjust.
5860         * cli/cli-script.c (script_from_file): Adjust.
5861
5862 2019-02-19  Tom Tromey  <tromey@adacore.com>
5863
5864         * ravenscar-thread.c
5865         (ravenscar_thread_target::update_thread_list): Don't call
5866         ada_build_task_list.
5867         * ada-lang.h (ada_build_task_list): Don't declare.
5868         * ada-tasks.c (struct ada_tasks_inferior_data)
5869         <task_list_valid_p>: Now bool.
5870         (read_known_tasks, ada_task_list_changed)
5871         (ada_tasks_invalidate_inferior_data): Update.
5872         (read_known_tasks_array): Return bool.
5873         (read_known_tasks_list): Likewise.
5874         (read_known_tasks): Return void.
5875         (ada_build_task_list): Now static.
5876
5877 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5878
5879         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5880         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5881
5882 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5883
5884         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5885         variant for ada_tasks_pspace_data_handle and
5886         ada_tasks_inferior_data_handle.
5887         (ada_tasks_pspace_data_cleanup): New function.
5888         (ada_tasks_inferior_data_cleanup): New function.
5889
5890 2019-02-17  Tom Tromey  <tom@tromey.com>
5891
5892         * macrotab.h (macro_source_fullname): Return a std::string.
5893         * macrotab.c (macro_include, check_for_redefinition)
5894         (macro_undef, macro_lookup_definition, foreach_macro)
5895         (foreach_macro_in_scope): Update.
5896         (macro_source_fullname): Return a std::string.
5897         * macrocmd.c (show_pp_source_pos): Update.
5898
5899 2019-02-17  Tom Tromey  <tom@tromey.com>
5900
5901         * macrocmd.c (show_pp_source_pos): Style the file names.
5902
5903 2019-02-17  Tom Tromey  <tom@tromey.com>
5904
5905         PR tui/24197:
5906         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5907
5908 2019-02-17  Tom Tromey  <tom@tromey.com>
5909
5910         * ada-lang.c (user_select_syms): Use filtered printing.
5911         * utils.c (wrap_style): New global.
5912         (desired_style): Remove.
5913         (emit_style_escape): Add stream parameter.
5914         (set_output_style, reset_terminal_style, prompt_for_continue):
5915         Update.
5916         (flush_wrap_buffer): Only flush gdb_stdout.
5917         (wrap_here): Set wrap_style.
5918         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5919         treat escape sequences as a character.  Change when wrap buffer is
5920         flushed.
5921         (fputs_styled): Do not set the output style when the default is
5922         requested.
5923         * ui-style.h (struct ui_file_style) <is_default>: New method.
5924         * source.c (print_source_lines_base): Emit escape sequences in one
5925         piece.
5926
5927 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5928
5929         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5930         integers and enumeration types.
5931
5932 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5933
5934         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5935         instead of lookup_symbol_in_language
5936         (do_exact_match): New function.
5937         (ada_get_symbol_name_matcher): Return do_exact_match when
5938         doing a verbatim match.
5939
5940 2019-02-15  Tom Tromey  <tromey@adacore.com>
5941
5942         * ravenscar-thread.c (ravenscar_thread_target::resume)
5943         (ravenscar_thread_target::wait): Special case wildcard requests.
5944
5945 2019-02-15  Tom Tromey  <tromey@adacore.com>
5946
5947         * ravenscar-thread.c (base_ptid): Remove.
5948         (struct ravenscar_thread_target) <close>: New method.
5949         <m_base_ptid>: New member.
5950         <update_inferior_ptid, active_task, task_is_currently_active,
5951         runtime_initialized>: Declare methods.
5952         <ravenscar_thread_target>: Add constructor.
5953         (ravenscar_thread_target::task_is_currently_active)
5954         (ravenscar_thread_target::update_inferior_ptid)
5955         (ravenscar_runtime_initialized): Rename.  Now methods.
5956         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5957         (ravenscar_thread_target::update_thread_list): Update.
5958         (ravenscar_thread_target::active_task): Now method.
5959         (ravenscar_thread_target::store_registers)
5960         (ravenscar_thread_target::prepare_to_store)
5961         (ravenscar_thread_target::prepare_to_store)
5962         (ravenscar_thread_target::mourn_inferior): Update.
5963         (ravenscar_inferior_created): Use "new" to create target.
5964         (ravenscar_thread_target::get_ada_task_ptid): Update.
5965         (_initialize_ravenscar): Don't initialize base_ptid.
5966         (ravenscar_ops): Remove global.
5967
5968 2019-02-15  Tom Tromey  <tromey@adacore.com>
5969
5970         * target.h (push_target): Declare new overload.
5971         * target.c (push_target): New overload, taking an rvalue reference.
5972         * remote.c (remote_target::open_1): Use push_target overload.
5973         * corelow.c (core_target_open): Use push_target overload.
5974
5975 2019-02-15  Tom Tromey  <tromey@adacore.com>
5976
5977         * ravenscar-thread.c (is_ravenscar_task)
5978         (ravenscar_task_is_currently_active): Return bool.
5979         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5980         (_initialize_ravenscar): Remove "(void)".
5981         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5982         Return bool.
5983
5984 2019-02-15  Tom Tromey  <tromey@adacore.com>
5985
5986         * ravenscar-thread.c (ravenscar_runtime_initializer)
5987         (has_ravenscar_runtime, get_running_thread_id)
5988         (ravenscar_thread_target::resume): Fix indentation.
5989
5990 2019-02-15  Tom Tromey  <tromey@adacore.com>
5991
5992         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5993         from ravenscar_arch_ops.
5994         (sparc_ravenscar_ops::fetch_registers)
5995         (sparc_ravenscar_ops::store_registers): Now methods.
5996         (sparc_ravenscar_prepare_to_store): Remove.
5997         (sparc_ravenscar_ops): Redefine.
5998         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5999         methods and destructor.  Remove members.
6000         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6001         (ravenscar_thread_target::store_registers)
6002         (ravenscar_thread_target::prepare_to_store): Update.
6003         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6004         Remove.
6005         (struct ppc_ravenscar_powerpc_ops): Derive from
6006         ravenscar_arch_ops.
6007         (ppc_ravenscar_powerpc_ops::fetch_registers)
6008         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6009         (ppc_ravenscar_powerpc_ops): Redefine.
6010         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6011         (ppc_ravenscar_e500_ops::fetch_registers)
6012         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6013         (ppc_ravenscar_e500_ops): Redefine.
6014         * aarch64-ravenscar-thread.c
6015         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6016         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6017         (aarch64_ravenscar_fetch_registers)
6018         (aarch64_ravenscar_store_registers): Now methods.
6019         (aarch64_ravenscar_ops): Redefine.
6020
6021 2019-02-15  Tom Tromey  <tromey@adacore.com>
6022
6023         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6024         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6025         (ravenscar_thread_target::stopped_by_watchpoint)
6026         (ravenscar_thread_target::stopped_data_address)
6027         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6028
6029 2019-02-15  Tom Tromey  <tromey@adacore.com>
6030
6031         * ravenscar-thread.c: Fix some typos.
6032
6033 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6034             Tom Tromey  <tromey@adacore.com>
6035
6036         * ada-lang.c (ada_exception_sal): Change addr_string to a
6037         std::string.
6038         (create_ada_exception_catchpoint): Update.
6039
6040 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6041             Tom Tromey  <tromey@adacore.com>
6042
6043         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6044         (bp_location_ops): Remove.
6045         (base_breakpoint_allocate_location): Update.
6046         (free_bp_location): Update.
6047         * ada-lang.c (class ada_catchpoint_location)
6048         <ada_catchpoint_location>: Remove ops parameter.
6049         (ada_catchpoint_location_dtor): Remove.
6050         (ada_catchpoint_location_ops): Remove.
6051         (allocate_location_exception): Update.
6052         * breakpoint.h (struct bp_location_ops): Remove.
6053         (class bp_location) <bp_location>: Remove bp_location_ops
6054         parameter.
6055         <~bp_location>: Add destructor.
6056         <ops>: Remove.
6057
6058 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6059             Pedro Alves  <palves@redhat.com>
6060
6061         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6062         'PATH_MAX'.
6063
6064 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6065             Samuel Thibault  <samuel.thibault@gnu.org>
6066             Thomas Schwinge  <thomas@codesourcery.com>
6067
6068         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6069         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6070
6071 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6072
6073         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6074         (check_empty): Use "const char *".
6075
6076         * gnu-nat.c (gnu_nat_target::detach): Instead of
6077         'detach_inferior (pid)' call
6078         'detach_inferior (find_inferior_pid (pid))'.
6079
6080         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6081         'nat/fork-inferior.o'.
6082         * gnu-nat.c: #include "nat/fork-inferior.h".
6083
6084         * gnu-nat.c (gnu_nat_target::detach): Instead of
6085         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6086         * gnu-nat.h: #include "inf-child.h".
6087         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6088         'i386_gnu_nat_target::fetch_registers'.
6089         (gnu_store_registers): Rename/move to
6090         'i386_gnu_nat_target::store_registers'.
6091
6092         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6093         * gnu-nat.h (mach_thread_info): New function.
6094         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6095
6096         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6097
6098 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6099
6100         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6101
6102 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6103
6104         * windows-nat.c (windows_add_thread): Add new parameter
6105         "main_thread_p" with default value set to false.  Update
6106         function documentation as well as all callers.
6107         (windows_delete_thread): Likewise.
6108         (fake_create_process): Update call to windows_add_thread.
6109         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6110         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6111         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6112         call to windows_delete_thread.
6113
6114 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6115
6116         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6117
6118 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6119
6120         * symfile.c (find_separate_debug_file): Use canonical path of
6121         sysroot with child_path instead of gdb_sysroot if it is valid.
6122
6123 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6124
6125         * symfile.c (find_separate_debug_file): Use child_path to
6126         determine if an object file is under a sysroot.
6127
6128 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6129
6130         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6131         unittests/child-path-selftests.c.
6132         * common/pathstuff.c (child_path): New function.
6133         * common/pathstuff.h (child_path): New prototype.
6134         * unittests/child-path-selftests.c: New file.
6135
6136 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6137
6138         * symfile.c (find_separate_debug_file): Look for separate debug
6139         files in debug directories under the sysroot.
6140
6141 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6142
6143         * symtab.h (struct minimal_symbol data_p): New const method.
6144         (struct minimal_symbol text_p): Likewise.
6145         * symtab.c (output_source_filename): Use file name style
6146         to print file name.
6147         (print_symbol_info): Likewise.
6148         (print_msymbol_info): Use address style to print addresses.
6149         Use function name style to print executable text symbols.
6150         (expand_symtab_containing_pc): Use data_p.
6151         (find_pc_sect_compunit_symtab): Likewise.
6152
6153 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6154
6155         * breakpoint.c (describe_other_breakpoints): Use address style
6156         to print addresses.
6157         (say_where): Likewise.
6158
6159 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6160
6161         * ada-typeprint.c (print_func_type): Print function name
6162         style to print function name.
6163         * c-typeprint.c (c_print_type_1): Likewise.
6164
6165 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6166
6167         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6168         for execve.
6169
6170 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6171
6172         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6173         type_stack.
6174
6175 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6176
6177         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6178         TYPE_CODE_REF types.
6179
6180 2019-02-08  Jim Wilson  <jimw@sifive.com>
6181
6182         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6183         (riscv_linux_fregset): New.
6184         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6185
6186 2019-02-07  Tom Tromey  <tom@tromey.com>
6187
6188         * thread.c (thread_cancel_execution_command): Update.
6189         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6190         methods.
6191         (struct thread_fsm_ops): Remove.
6192         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6193         (thread_fsm_should_stop, thread_fsm_return_value)
6194         (thread_fsm_set_finished, thread_fsm_finished_p)
6195         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6196         Don't declare.
6197         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6198         * infrun.c (clear_proceed_status_thread)
6199         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6200         (print_stop_event): Update.
6201         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6202         Add constructor.
6203         (step_command_fsm_ops): Remove.
6204         (new_step_command_fsm): Remove.
6205         (step_1): Update.
6206         (step_command_fsm::should_stop): Rename from
6207         step_command_fsm_should_stop.
6208         (step_command_fsm::clean_up): Rename from
6209         step_command_fsm_clean_up.
6210         (step_command_fsm::do_async_reply_reason): Rename from
6211         step_command_fsm_async_reply_reason.
6212         (struct until_next_fsm): Inherit from thread_fsm.  Add
6213         constructor.
6214         (until_next_fsm_ops): Remove.
6215         (new_until_next_fsm): Remove.
6216         (until_next_fsm::should_stop): Rename from
6217         until_next_fsm_should_stop.
6218         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6219         (until_next_fsm::do_async_reply_reason): Rename from
6220         until_next_fsm_async_reply_reason.
6221         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6222         constructor.  Change type of breakpoint.
6223         (finish_command_fsm_ops): Remove.
6224         (new_finish_command_fsm): Remove.
6225         (finish_command_fsm::should_stop): Rename from
6226         finish_command_fsm_should_stop.
6227         (finish_command_fsm::clean_up): Rename from
6228         finish_command_fsm_clean_up.
6229         (finish_command_fsm::return_value): Rename from
6230         finish_command_fsm_return_value.
6231         (finish_command_fsm::do_async_reply_reason): Rename from
6232         finish_command_fsm_async_reply_reason.
6233         (finish_command): Update.
6234         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6235         Add constructor.
6236         (call_thread_fsm_ops): Remove.
6237         (call_thread_fsm::call_thread_fsm): Rename from
6238         new_call_thread_fsm.
6239         (call_thread_fsm::should_stop): Rename from
6240         call_thread_fsm_should_stop.
6241         (call_thread_fsm::should_notify_stop): Rename from
6242         call_thread_fsm_should_notify_stop.
6243         (run_inferior_call, call_function_by_hand_dummy): Update.
6244         * cli/cli-interp.c (should_print_stop_to_console): Update.
6245         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6246         Add constructor.  Change type of location_breakpoint,
6247         caller_breakpoint.
6248         (until_break_fsm_ops): Remove.
6249         (new_until_break_fsm): Remove.
6250         (until_break_fsm::should_stop): Rename from
6251         until_break_fsm_should_stop.
6252         (until_break_fsm::clean_up): Rename from
6253         until_break_fsm_clean_up.
6254         (until_break_fsm::do_async_reply_reason): Rename from
6255         until_break_fsm_async_reply_reason.
6256         (until_break_command): Update.
6257         * thread-fsm.c: Remove.
6258         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6259
6260 2019-02-07  Tom Tromey  <tom@tromey.com>
6261
6262         * yy-remap.h: Add include guard.
6263         * xtensa-tdep.h: Add include guard.
6264         * xcoffread.h: Rename include guard.
6265         * varobj-iter.h: Add include guard.
6266         * tui/tui.h: Rename include guard.
6267         * tui/tui-winsource.h: Rename include guard.
6268         * tui/tui-wingeneral.h: Rename include guard.
6269         * tui/tui-windata.h: Rename include guard.
6270         * tui/tui-win.h: Rename include guard.
6271         * tui/tui-stack.h: Rename include guard.
6272         * tui/tui-source.h: Rename include guard.
6273         * tui/tui-regs.h: Rename include guard.
6274         * tui/tui-out.h: Rename include guard.
6275         * tui/tui-layout.h: Rename include guard.
6276         * tui/tui-io.h: Rename include guard.
6277         * tui/tui-hooks.h: Rename include guard.
6278         * tui/tui-file.h: Rename include guard.
6279         * tui/tui-disasm.h: Rename include guard.
6280         * tui/tui-data.h: Rename include guard.
6281         * tui/tui-command.h: Rename include guard.
6282         * tic6x-tdep.h: Add include guard.
6283         * target/waitstatus.h: Rename include guard.
6284         * target/wait.h: Rename include guard.
6285         * target/target.h: Rename include guard.
6286         * target/resume.h: Rename include guard.
6287         * target-float.h: Rename include guard.
6288         * stabsread.h: Add include guard.
6289         * rs6000-tdep.h: Add include guard.
6290         * riscv-fbsd-tdep.h: Add include guard.
6291         * regformats/regdef.h: Rename include guard.
6292         * record.h: Rename include guard.
6293         * python/python.h: Rename include guard.
6294         * python/python-internal.h: Rename include guard.
6295         * python/py-stopevent.h: Rename include guard.
6296         * python/py-ref.h: Rename include guard.
6297         * python/py-record.h: Rename include guard.
6298         * python/py-record-full.h: Rename include guard.
6299         * python/py-record-btrace.h: Rename include guard.
6300         * python/py-instruction.h: Rename include guard.
6301         * python/py-events.h: Rename include guard.
6302         * python/py-event.h: Rename include guard.
6303         * procfs.h: Add include guard.
6304         * proc-utils.h: Add include guard.
6305         * p-lang.h: Add include guard.
6306         * or1k-tdep.h: Rename include guard.
6307         * observable.h: Rename include guard.
6308         * nto-tdep.h: Rename include guard.
6309         * nat/x86-linux.h: Rename include guard.
6310         * nat/x86-linux-dregs.h: Rename include guard.
6311         * nat/x86-gcc-cpuid.h: Add include guard.
6312         * nat/x86-dregs.h: Rename include guard.
6313         * nat/x86-cpuid.h: Rename include guard.
6314         * nat/ppc-linux.h: Rename include guard.
6315         * nat/mips-linux-watch.h: Rename include guard.
6316         * nat/linux-waitpid.h: Rename include guard.
6317         * nat/linux-ptrace.h: Rename include guard.
6318         * nat/linux-procfs.h: Rename include guard.
6319         * nat/linux-osdata.h: Rename include guard.
6320         * nat/linux-nat.h: Rename include guard.
6321         * nat/linux-namespaces.h: Rename include guard.
6322         * nat/linux-btrace.h: Rename include guard.
6323         * nat/glibc_thread_db.h: Rename include guard.
6324         * nat/gdb_thread_db.h: Rename include guard.
6325         * nat/gdb_ptrace.h: Rename include guard.
6326         * nat/fork-inferior.h: Rename include guard.
6327         * nat/amd64-linux-siginfo.h: Rename include guard.
6328         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6329         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6330         * nat/aarch64-linux.h: Rename include guard.
6331         * nat/aarch64-linux-hw-point.h: Rename include guard.
6332         * mn10300-tdep.h: Add include guard.
6333         * mips-linux-tdep.h: Add include guard.
6334         * mi/mi-parse.h: Rename include guard.
6335         * mi/mi-out.h: Rename include guard.
6336         * mi/mi-main.h: Rename include guard.
6337         * mi/mi-interp.h: Rename include guard.
6338         * mi/mi-getopt.h: Rename include guard.
6339         * mi/mi-console.h: Rename include guard.
6340         * mi/mi-common.h: Rename include guard.
6341         * mi/mi-cmds.h: Rename include guard.
6342         * mi/mi-cmd-break.h: Rename include guard.
6343         * m2-lang.h: Add include guard.
6344         * location.h: Rename include guard.
6345         * linux-record.h: Rename include guard.
6346         * linux-nat.h: Add include guard.
6347         * linux-fork.h: Add include guard.
6348         * i386-darwin-tdep.h: Rename include guard.
6349         * hppa-linux-offsets.h: Add include guard.
6350         * guile/guile.h: Rename include guard.
6351         * guile/guile-internal.h: Rename include guard.
6352         * gnu-nat.h: Rename include guard.
6353         * gdb-stabs.h: Rename include guard.
6354         * frv-tdep.h: Add include guard.
6355         * f-lang.h: Add include guard.
6356         * event-loop.h: Add include guard.
6357         * darwin-nat.h: Rename include guard.
6358         * cp-abi.h: Rename include guard.
6359         * config/sparc/nm-sol2.h: Rename include guard.
6360         * config/nm-nto.h: Rename include guard.
6361         * config/nm-linux.h: Add include guard.
6362         * config/i386/nm-i386gnu.h: Rename include guard.
6363         * config/djgpp/nl_types.h: Rename include guard.
6364         * config/djgpp/langinfo.h: Rename include guard.
6365         * compile/gcc-cp-plugin.h: Add include guard.
6366         * compile/gcc-c-plugin.h: Add include guard.
6367         * compile/compile.h: Rename include guard.
6368         * compile/compile-object-run.h: Rename include guard.
6369         * compile/compile-object-load.h: Rename include guard.
6370         * compile/compile-internal.h: Rename include guard.
6371         * compile/compile-cplus.h: Rename include guard.
6372         * compile/compile-c.h: Rename include guard.
6373         * common/xml-utils.h: Rename include guard.
6374         * common/x86-xstate.h: Rename include guard.
6375         * common/version.h: Rename include guard.
6376         * common/vec.h: Rename include guard.
6377         * common/tdesc.h: Rename include guard.
6378         * common/selftest.h: Rename include guard.
6379         * common/scoped_restore.h: Rename include guard.
6380         * common/scoped_mmap.h: Rename include guard.
6381         * common/scoped_fd.h: Rename include guard.
6382         * common/safe-iterator.h: Rename include guard.
6383         * common/run-time-clock.h: Rename include guard.
6384         * common/refcounted-object.h: Rename include guard.
6385         * common/queue.h: Rename include guard.
6386         * common/ptid.h: Rename include guard.
6387         * common/print-utils.h: Rename include guard.
6388         * common/preprocessor.h: Rename include guard.
6389         * common/pathstuff.h: Rename include guard.
6390         * common/observable.h: Rename include guard.
6391         * common/netstuff.h: Rename include guard.
6392         * common/job-control.h: Rename include guard.
6393         * common/host-defs.h: Rename include guard.
6394         * common/gdb_wait.h: Rename include guard.
6395         * common/gdb_vecs.h: Rename include guard.
6396         * common/gdb_unlinker.h: Rename include guard.
6397         * common/gdb_unique_ptr.h: Rename include guard.
6398         * common/gdb_tilde_expand.h: Rename include guard.
6399         * common/gdb_sys_time.h: Rename include guard.
6400         * common/gdb_string_view.h: Rename include guard.
6401         * common/gdb_splay_tree.h: Rename include guard.
6402         * common/gdb_setjmp.h: Rename include guard.
6403         * common/gdb_ref_ptr.h: Rename include guard.
6404         * common/gdb_optional.h: Rename include guard.
6405         * common/gdb_locale.h: Rename include guard.
6406         * common/gdb_assert.h: Rename include guard.
6407         * common/filtered-iterator.h: Rename include guard.
6408         * common/filestuff.h: Rename include guard.
6409         * common/fileio.h: Rename include guard.
6410         * common/environ.h: Rename include guard.
6411         * common/common-utils.h: Rename include guard.
6412         * common/common-types.h: Rename include guard.
6413         * common/common-regcache.h: Rename include guard.
6414         * common/common-inferior.h: Rename include guard.
6415         * common/common-gdbthread.h: Rename include guard.
6416         * common/common-exceptions.h: Rename include guard.
6417         * common/common-defs.h: Rename include guard.
6418         * common/common-debug.h: Rename include guard.
6419         * common/cleanups.h: Rename include guard.
6420         * common/buffer.h: Rename include guard.
6421         * common/btrace-common.h: Rename include guard.
6422         * common/break-common.h: Rename include guard.
6423         * cli/cli-utils.h: Rename include guard.
6424         * cli/cli-style.h: Rename include guard.
6425         * cli/cli-setshow.h: Rename include guard.
6426         * cli/cli-script.h: Rename include guard.
6427         * cli/cli-interp.h: Rename include guard.
6428         * cli/cli-decode.h: Rename include guard.
6429         * cli/cli-cmds.h: Rename include guard.
6430         * charset-list.h: Add include guard.
6431         * buildsym-legacy.h: Rename include guard.
6432         * bfin-tdep.h: Add include guard.
6433         * ax.h: Rename include guard.
6434         * arm-linux-tdep.h: Add include guard.
6435         * arm-fbsd-tdep.h: Add include guard.
6436         * arch/xtensa.h: Rename include guard.
6437         * arch/tic6x.h: Add include guard.
6438         * arch/i386.h: Add include guard.
6439         * arch/arm.h: Rename include guard.
6440         * arch/arm-linux.h: Rename include guard.
6441         * arch/arm-get-next-pcs.h: Rename include guard.
6442         * arch/amd64.h: Add include guard.
6443         * arch/aarch64-insn.h: Rename include guard.
6444         * arch-utils.h: Rename include guard.
6445         * annotate.h: Add include guard.
6446         * amd64-darwin-tdep.h: Rename include guard.
6447         * aarch64-linux-tdep.h: Add include guard.
6448         * aarch64-fbsd-tdep.h: Add include guard.
6449         * aarch32-linux-nat.h: Add include guard.
6450
6451 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6452
6453         * macrotab.c (macro_define_internal): New function that
6454         factorizes macro_define_object_internal and macro_define_function
6455         code.
6456         (macro_define_object_internal): Use macro_define_internal.
6457         (macro_define_function): Likewise.
6458
6459 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6460
6461         * macrocmd.c (extract_identifier): Return
6462         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6463         callers.
6464
6465 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6466
6467         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6468
6469 2019-02-05  Tom Tromey  <tom@tromey.com>
6470
6471         * target.c (target_stack::unpush): Move assertion earlier.
6472
6473 2019-01-30  Tom Tromey  <tom@tromey.com>
6474
6475         PR python/23615:
6476         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6477         (gdbpy_parse_and_eval): Likewise.
6478         * python/python-internal.h (gdbpy_allow_threads): New class.
6479
6480 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6481
6482         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6483         (aarch64_fbsd_fpregmap): Move earlier.
6484         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6485         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6486         instead of individual calls to trad_frame_set_reg_addr.
6487         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6488         earlier.
6489         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6490         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6491         instead of individual calls to trad_frame_set_reg_addr.
6492
6493 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6494
6495         * CONTRIBUTE: Replace contribution list with wiki link.
6496
6497 2019-01-25  Tom Tromey  <tom@tromey.com>
6498
6499         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6500
6501 2019-01-25  Tom Tromey  <tom@tromey.com>
6502
6503         * xtensa-linux-nat.c: Fix common/ includes.
6504         * xml-support.h: Fix common/ includes.
6505         * xml-support.c: Fix common/ includes.
6506         * x86-linux-nat.c: Fix common/ includes.
6507         * windows-nat.c: Fix common/ includes.
6508         * varobj.h: Fix common/ includes.
6509         * varobj.c: Fix common/ includes.
6510         * value.c: Fix common/ includes.
6511         * valops.c: Fix common/ includes.
6512         * utils.c: Fix common/ includes.
6513         * unittests/xml-utils-selftests.c: Fix common/ includes.
6514         * unittests/utils-selftests.c: Fix common/ includes.
6515         * unittests/unpack-selftests.c: Fix common/ includes.
6516         * unittests/tracepoint-selftests.c: Fix common/ includes.
6517         * unittests/style-selftests.c: Fix common/ includes.
6518         * unittests/string_view-selftests.c: Fix common/ includes.
6519         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6520         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6521         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6522         * unittests/rsp-low-selftests.c: Fix common/ includes.
6523         * unittests/parse-connection-spec-selftests.c: Fix common/
6524         includes.
6525         * unittests/optional-selftests.c: Fix common/ includes.
6526         * unittests/offset-type-selftests.c: Fix common/ includes.
6527         * unittests/observable-selftests.c: Fix common/ includes.
6528         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6529         * unittests/memrange-selftests.c: Fix common/ includes.
6530         * unittests/memory-map-selftests.c: Fix common/ includes.
6531         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6532         * unittests/function-view-selftests.c: Fix common/ includes.
6533         * unittests/environ-selftests.c: Fix common/ includes.
6534         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6535         * unittests/common-utils-selftests.c: Fix common/ includes.
6536         * unittests/cli-utils-selftests.c: Fix common/ includes.
6537         * unittests/array-view-selftests.c: Fix common/ includes.
6538         * ui-file.c: Fix common/ includes.
6539         * tui/tui-io.c: Fix common/ includes.
6540         * tracepoint.h: Fix common/ includes.
6541         * tracepoint.c: Fix common/ includes.
6542         * tracefile-tfile.c: Fix common/ includes.
6543         * top.h: Fix common/ includes.
6544         * top.c: Fix common/ includes.
6545         * thread.c: Fix common/ includes.
6546         * target/waitstatus.h: Fix common/ includes.
6547         * target/waitstatus.c: Fix common/ includes.
6548         * target.h: Fix common/ includes.
6549         * target.c: Fix common/ includes.
6550         * target-memory.c: Fix common/ includes.
6551         * target-descriptions.c: Fix common/ includes.
6552         * symtab.h: Fix common/ includes.
6553         * symfile.c: Fix common/ includes.
6554         * stap-probe.c: Fix common/ includes.
6555         * spu-linux-nat.c: Fix common/ includes.
6556         * sparc-nat.c: Fix common/ includes.
6557         * source.c: Fix common/ includes.
6558         * solib.c: Fix common/ includes.
6559         * solib-target.c: Fix common/ includes.
6560         * ser-unix.c: Fix common/ includes.
6561         * ser-tcp.c: Fix common/ includes.
6562         * ser-pipe.c: Fix common/ includes.
6563         * ser-base.c: Fix common/ includes.
6564         * selftest-arch.c: Fix common/ includes.
6565         * s12z-tdep.c: Fix common/ includes.
6566         * rust-exp.y: Fix common/ includes.
6567         * rs6000-aix-tdep.c: Fix common/ includes.
6568         * riscv-tdep.c: Fix common/ includes.
6569         * remote.c: Fix common/ includes.
6570         * remote-notif.h: Fix common/ includes.
6571         * remote-fileio.h: Fix common/ includes.
6572         * remote-fileio.c: Fix common/ includes.
6573         * regcache.h: Fix common/ includes.
6574         * regcache.c: Fix common/ includes.
6575         * record-btrace.c: Fix common/ includes.
6576         * python/python.c: Fix common/ includes.
6577         * python/py-type.c: Fix common/ includes.
6578         * python/py-inferior.c: Fix common/ includes.
6579         * progspace.h: Fix common/ includes.
6580         * producer.c: Fix common/ includes.
6581         * procfs.c: Fix common/ includes.
6582         * proc-api.c: Fix common/ includes.
6583         * printcmd.c: Fix common/ includes.
6584         * ppc-linux-nat.c: Fix common/ includes.
6585         * parser-defs.h: Fix common/ includes.
6586         * osdata.c: Fix common/ includes.
6587         * obsd-nat.c: Fix common/ includes.
6588         * nat/x86-linux.c: Fix common/ includes.
6589         * nat/x86-linux-dregs.c: Fix common/ includes.
6590         * nat/x86-dregs.h: Fix common/ includes.
6591         * nat/x86-dregs.c: Fix common/ includes.
6592         * nat/ppc-linux.c: Fix common/ includes.
6593         * nat/mips-linux-watch.h: Fix common/ includes.
6594         * nat/mips-linux-watch.c: Fix common/ includes.
6595         * nat/linux-waitpid.c: Fix common/ includes.
6596         * nat/linux-ptrace.h: Fix common/ includes.
6597         * nat/linux-ptrace.c: Fix common/ includes.
6598         * nat/linux-procfs.c: Fix common/ includes.
6599         * nat/linux-personality.c: Fix common/ includes.
6600         * nat/linux-osdata.c: Fix common/ includes.
6601         * nat/linux-namespaces.c: Fix common/ includes.
6602         * nat/linux-btrace.h: Fix common/ includes.
6603         * nat/linux-btrace.c: Fix common/ includes.
6604         * nat/fork-inferior.c: Fix common/ includes.
6605         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6606         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6607         * nat/aarch64-linux.c: Fix common/ includes.
6608         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6609         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6610         * namespace.h: Fix common/ includes.
6611         * mips-linux-tdep.c: Fix common/ includes.
6612         * minsyms.c: Fix common/ includes.
6613         * mi/mi-parse.h: Fix common/ includes.
6614         * mi/mi-main.c: Fix common/ includes.
6615         * mi/mi-cmd-env.c: Fix common/ includes.
6616         * memrange.h: Fix common/ includes.
6617         * memattr.c: Fix common/ includes.
6618         * maint.h: Fix common/ includes.
6619         * maint.c: Fix common/ includes.
6620         * main.c: Fix common/ includes.
6621         * machoread.c: Fix common/ includes.
6622         * location.c: Fix common/ includes.
6623         * linux-thread-db.c: Fix common/ includes.
6624         * linux-nat.c: Fix common/ includes.
6625         * linux-fork.c: Fix common/ includes.
6626         * inline-frame.c: Fix common/ includes.
6627         * infrun.c: Fix common/ includes.
6628         * inflow.c: Fix common/ includes.
6629         * inferior.h: Fix common/ includes.
6630         * inferior.c: Fix common/ includes.
6631         * infcmd.c: Fix common/ includes.
6632         * inf-ptrace.c: Fix common/ includes.
6633         * inf-child.c: Fix common/ includes.
6634         * ia64-linux-nat.c: Fix common/ includes.
6635         * i387-tdep.c: Fix common/ includes.
6636         * i386-tdep.c: Fix common/ includes.
6637         * i386-linux-tdep.c: Fix common/ includes.
6638         * i386-linux-nat.c: Fix common/ includes.
6639         * i386-go32-tdep.c: Fix common/ includes.
6640         * i386-fbsd-tdep.c: Fix common/ includes.
6641         * i386-fbsd-nat.c: Fix common/ includes.
6642         * guile/scm-type.c: Fix common/ includes.
6643         * guile/guile.c: Fix common/ includes.
6644         * go32-nat.c: Fix common/ includes.
6645         * gnu-nat.c: Fix common/ includes.
6646         * gdbthread.h: Fix common/ includes.
6647         * gdbarch-selftests.c: Fix common/ includes.
6648         * gdb_usleep.c: Fix common/ includes.
6649         * gdb_select.h: Fix common/ includes.
6650         * gdb_bfd.c: Fix common/ includes.
6651         * gcore.c: Fix common/ includes.
6652         * fork-child.c: Fix common/ includes.
6653         * findvar.c: Fix common/ includes.
6654         * fbsd-nat.c: Fix common/ includes.
6655         * event-top.c: Fix common/ includes.
6656         * event-loop.c: Fix common/ includes.
6657         * dwarf2read.c: Fix common/ includes.
6658         * dwarf2loc.c: Fix common/ includes.
6659         * dwarf2-frame.c: Fix common/ includes.
6660         * dwarf-index-cache.c: Fix common/ includes.
6661         * dtrace-probe.c: Fix common/ includes.
6662         * disasm-selftests.c: Fix common/ includes.
6663         * defs.h: Fix common/ includes.
6664         * csky-tdep.c: Fix common/ includes.
6665         * cp-valprint.c: Fix common/ includes.
6666         * cp-support.h: Fix common/ includes.
6667         * cp-support.c: Fix common/ includes.
6668         * corelow.c: Fix common/ includes.
6669         * completer.h: Fix common/ includes.
6670         * completer.c: Fix common/ includes.
6671         * compile/compile.c: Fix common/ includes.
6672         * compile/compile-loc2c.c: Fix common/ includes.
6673         * compile/compile-cplus-types.c: Fix common/ includes.
6674         * compile/compile-cplus-symbols.c: Fix common/ includes.
6675         * command.h: Fix common/ includes.
6676         * cli/cli-dump.c: Fix common/ includes.
6677         * cli/cli-cmds.c: Fix common/ includes.
6678         * charset.c: Fix common/ includes.
6679         * build-id.c: Fix common/ includes.
6680         * btrace.h: Fix common/ includes.
6681         * btrace.c: Fix common/ includes.
6682         * breakpoint.h: Fix common/ includes.
6683         * breakpoint.c: Fix common/ includes.
6684         * ax.h:
6685         (enum agent_op): Fix common/ includes.
6686         * ax-general.c (struct aop_map): Fix common/ includes.
6687         * ax-gdb.c: Fix common/ includes.
6688         * auxv.c: Fix common/ includes.
6689         * auto-load.c: Fix common/ includes.
6690         * arm-tdep.c: Fix common/ includes.
6691         * arch/riscv.c: Fix common/ includes.
6692         * arch/ppc-linux-common.c: Fix common/ includes.
6693         * arch/i386.c: Fix common/ includes.
6694         * arch/arm.c: Fix common/ includes.
6695         * arch/arm-linux.c: Fix common/ includes.
6696         * arch/arm-get-next-pcs.c: Fix common/ includes.
6697         * arch/amd64.c: Fix common/ includes.
6698         * arch/aarch64.c: Fix common/ includes.
6699         * arch/aarch64-insn.c: Fix common/ includes.
6700         * arch-utils.c: Fix common/ includes.
6701         * amd64-windows-tdep.c: Fix common/ includes.
6702         * amd64-tdep.c: Fix common/ includes.
6703         * amd64-sol2-tdep.c: Fix common/ includes.
6704         * amd64-obsd-tdep.c: Fix common/ includes.
6705         * amd64-nbsd-tdep.c: Fix common/ includes.
6706         * amd64-linux-tdep.c: Fix common/ includes.
6707         * amd64-linux-nat.c: Fix common/ includes.
6708         * amd64-fbsd-tdep.c: Fix common/ includes.
6709         * amd64-fbsd-nat.c: Fix common/ includes.
6710         * amd64-dicos-tdep.c: Fix common/ includes.
6711         * amd64-darwin-tdep.c: Fix common/ includes.
6712         * agent.c: Fix common/ includes.
6713         * ada-lang.h: Fix common/ includes.
6714         * ada-lang.c: Fix common/ includes.
6715         * aarch64-tdep.c: Fix common/ includes.
6716
6717 2019-01-25  Tom Tromey  <tom@tromey.com>
6718
6719         * common/create-version.sh: Use common/version.h.
6720
6721 2019-01-24  Pedro Alves  <palves@redhat.com>
6722
6723         * infrun.c (signal_stop, signal_print, signal_program)
6724         (signal_catch, signal_pass): Now arrays instead of pointers.
6725         (update_signals_program_target, do_target_resume)
6726         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6727         * linux-nat.c (linux_nat_target::pass_signals)
6728         (linux_nat_target::create_inferior, linux_nat_target::attach):
6729         Adjust.
6730         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6731         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6732         * procfs.c (procfs_target::pass_signals): Adjust.
6733         * record-full.c (record_full_target::resume): Adjust.
6734         * remote.c (remote_target::pass_signals)
6735         (remote_target::program_signals): Adjust.
6736         * target-debug.h (target_debug_print_signals): Now takes a
6737         gdb::array_view as parameter.  Adjust.
6738         * target.h (target_ops) <pass_signals, program_signals>: Replace
6739         pointer and length parameters with gdb::array_view.
6740         (target_pass_signals, target_program_signals): Likewise.
6741         * target-delegates.c: Regenerate.
6742
6743 2019-01-24  Pedro Alves  <palves@redhat.com>
6744
6745         * common/forward-scope-exit.h
6746         (forward_scope_exit::forward_scope_exit): Pass arguments to
6747         m_bind_function directly, instead of creating a std::bind and
6748         copying that.
6749
6750 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6751
6752         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6753         for static members.
6754         (pass_in_v_vfp_candidate): Likewise.
6755
6756 2019-01-23  Tom Tromey  <tom@tromey.com>
6757             Pedro Alves  <palves@redhat.com>
6758
6759         * regcache.c (class regcache_invalidator): Remove.
6760         (regcache::raw_write): Use make_scope_exit.
6761
6762 2019-01-23  Tom Tromey  <tom@tromey.com>
6763
6764         * ui-out.h (class ui_out_emit_type): Update comment.
6765
6766 2019-01-23  Tom Tromey  <tom@tromey.com>
6767
6768         * infrun.c (fetch_inferior_event): Update comment.
6769
6770 2019-01-23  Tom Tromey  <tom@tromey.com>
6771             Pedro Alves  <palves@redhat.com>
6772
6773         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6774         parameter.
6775         (fetch_inferior_event): Use SCOPE_EXIT.
6776
6777
6778 2019-01-23  Tom Tromey  <tom@tromey.com>
6779             Pedro Alves  <palves@redhat.com>
6780
6781         * infrun.c (disable_thread_events): Delete.
6782         (stop_all_threads): Use SCOPE_EXIT.
6783
6784 2019-01-23  Tom Tromey  <tom@tromey.com>
6785             Pedro Alves  <palves@redhat.com>
6786
6787         * symfile.c: Include forward-scope-exit.h.
6788         (clear_symtab_users_cleanup): Replace forward declaration with
6789         a FORWARD_SCOPE_EXIT.
6790         (syms_from_objfile_1): Use the forward_scope_exit and
6791         gdb::optional instead of cleanup_function.
6792         (reread_symbols): Use the forward_scope_exit instead of
6793         cleanup_function.
6794         (clear_symtab_users_cleanup): Remove function.
6795
6796 2019-01-23  Tom Tromey  <tom@tromey.com>
6797             Pedro Alves  <palves@redhat.com>
6798
6799         * linux-nat.c: Include scope-exit.h.
6800         (cleanup_target_stop): Remove.
6801         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6802         SCOPE_EXIT.
6803
6804 2019-01-23  Tom Tromey  <tom@tromey.com>
6805             Pedro Alves  <palves@redhat.com>
6806
6807         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6808         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6809
6810 2019-01-23  Tom Tromey  <tom@tromey.com>
6811             Andrew Burgess  <andrew.burgess@embecosm.com>
6812             Pedro Alves  <palves@redhat.com>
6813
6814         * infrun.c (fetch_inferior_event): Use scope_exit.
6815         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6816         * top.c (execute_command): Use scope_exit.
6817         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6818         * utils.c (do_bpstat_clear_actions_cleanup)
6819         (make_bpstat_clear_actions_cleanup): Remove.
6820
6821 2019-01-23  Tom Tromey  <tom@tromey.com>
6822             Pedro Alves  <palves@redhat.com>
6823
6824         * infrun.c: Include "common/scope-exit.h"
6825         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6826         (wait_for_inferior): Use SCOPE_EXIT.
6827         (fetch_inferior_event): Use scope_exit.
6828
6829 2019-01-23  Tom Tromey  <tom@tromey.com>
6830             Pedro Alves  <palves@redhat.com>
6831
6832         * breakpoint.c (create_breakpoint): Remove cleanup.
6833
6834 2019-01-23  Tom Tromey  <tom@tromey.com>
6835             Andrew Burgess  <andrew.burgess@embecosm.com>
6836             Pedro Alves  <palves@redhat.com>
6837
6838 2019-01-23  Pedro Alves  <palves@redhat.com>
6839
6840         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6841
6842 2019-01-23  Pedro Alves  <palves@redhat.com>
6843             Andrew Burgess  <andrew.burgess@embecosm.com>
6844
6845         * gdbthread.h: Include "common/forward-scope-exit.h".
6846         (scoped_finish_thread_state): Redefine custom class in terms of
6847         forward_scope_exit.
6848
6849 2019-01-23  Pedro Alves  <palves@redhat.com>
6850             Andrew Burgess  <andrew.burgess@embecosm.com>
6851
6852         * common/forward-scope-exit.h: New file.
6853
6854 2019-01-23  Pedro Alves  <palves@redhat.com>
6855             Andrew Burgess  <andrew.burgess@embecosm.com>
6856             Tom Tromey  <tom@tromey.com>
6857
6858         * common/scope-exit.h: New file.
6859
6860 2019-01-23  Pedro Alves  <palves@redhat.com>
6861
6862         * common/preprocessor.h (ESC): Rename to ...
6863         (ESC_PARENS): ... this.
6864         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6865         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6866
6867 2019-01-23  Tom Tromey  <tom@tromey.com>
6868
6869         * language.h (class scoped_switch_to_sym_language_if_auto):
6870         Initialize m_lang in both cases.
6871
6872 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6873
6874         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6875         with XCNEW.
6876
6877 2019-01-22  Tom Tromey  <tom@tromey.com>
6878
6879         * corelow.c: Do not include sys/file.h.
6880
6881 2019-01-22  Tom Tromey  <tom@tromey.com>
6882
6883         * tui/tui-wingeneral.h: Include gdb_curses.h.
6884
6885 2019-01-22  Tom Tromey  <tom@tromey.com>
6886
6887         * source-cache.h (class source_cache) <get_source_lines,
6888         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6889
6890 2019-01-22  Tom Tromey  <tom@tromey.com>
6891
6892         * remote-fileio.h (struct remote_target): Declare.
6893
6894 2019-01-22  Tom Tromey  <tom@tromey.com>
6895
6896         * python/py-arch.c: Do not include py-ref.h.
6897         * python/py-bpevent.c: Do not include py-ref.h.
6898         * python/py-cmd.c: Do not include py-ref.h.
6899         * python/py-continueevent.c: Do not include py-ref.h.
6900         * python/py-event.h: Do not include py-ref.h.
6901         * python/py-evtregistry.c: Do not include py-ref.h.
6902         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6903         * python/py-frame.c: Do not include py-ref.h.
6904         * python/py-framefilter.c: Do not include py-ref.h.
6905         * python/py-function.c: Do not include py-ref.h.
6906         * python/py-infevents.c: Do not include py-ref.h.
6907         * python/py-linetable.c: Do not include py-ref.h.
6908         * python/py-objfile.c: Do not include py-ref.h.
6909         * python/py-param.c: Do not include py-ref.h.
6910         * python/py-prettyprint.c: Do not include py-ref.h.
6911         * python/py-progspace.c: Do not include py-ref.h.
6912         * python/py-symbol.c: Do not include py-ref.h.
6913         * python/py-symtab.c: Do not include py-ref.h.
6914         * python/py-type.c: Do not include py-ref.h.
6915         * python/py-unwind.c: Do not include py-ref.h.
6916         * python/py-utils.c: Do not include py-ref.h.
6917         * python/py-value.c: Do not include py-ref.h.
6918         * python/py-varobj.c: Do not include py-ref.h.
6919         * python/py-xmethods.c: Do not include py-ref.h.
6920         * python/python.c: Do not include py-ref.h.
6921         * varobj.c: Do not include py-ref.h.
6922
6923 2019-01-22  Tom Tromey  <tom@tromey.com>
6924
6925         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6926         keyword for bcache.
6927
6928 2019-01-22  Tom Tromey  <tom@tromey.com>
6929
6930         * compile/compile-cplus-types.c: Remove a comment by #include.
6931
6932 2019-01-22  Tom Tromey  <tom@tromey.com>
6933
6934         * compile/gcc-c-plugin.h: Include compile-internal.h.
6935
6936 2019-01-22  Tom Tromey  <tom@tromey.com>
6937
6938         * stabsread.c (EXTERN): Do not define.
6939         (symnum, next_symbol_text_func, processing_gcc_compilation)
6940         (within_function, global_sym_chain, global_stabs)
6941         (previous_stab_code, this_object_header_files)
6942         (n_this_object_header_files)
6943         (n_allocated_this_object_header_files): Define.
6944         * stabsread.h (EXTERN): Never define.  Use "extern".
6945
6946 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6947
6948         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6949         history_value.
6950
6951 2019-01-21  Tom Tromey  <tom@tromey.com>
6952
6953         * ui-out.c: Fix includes.
6954         * tui/tui-source.c: Fix includes.
6955         * target.c: Fix includes.
6956         * remote.c: Fix includes.
6957         * regcache.c: Fix includes.
6958         * python/py-block.c: Fix includes.
6959         * printcmd.c: Fix includes.
6960         * or1k-tdep.c: Fix includes.
6961         * mi/mi-main.c: Fix includes.
6962         * m32r-tdep.c: Fix includes.
6963         * csky-tdep.c: Fix includes.
6964         * compile/compile-cplus-types.c: Fix includes.
6965         * cli/cli-interp.c: Fix includes.
6966
6967 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6968
6969         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6970         for padding.
6971
6972 2019-01-16  Tom Tromey  <tom@tromey.com>
6973
6974         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6975         earlier.
6976         (struct objfile) <msymbols_range>: Move from top level.
6977         <msymbols>: New method.
6978         (class objfile_msymbols): Remove.
6979         * symtab.c (default_collect_symbol_completion_matches_break_on):
6980         Update.
6981         * symmisc.c (dump_msymbols): Update.
6982         * stabsread.c (scan_file_globals): Update.
6983         * objc-lang.c (info_selectors_command, info_classes_command)
6984         (find_methods): Update.
6985         * minsyms.c (find_solib_trampoline_target): Update.
6986         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6987         * coffread.c (coff_symfile_read): Update.
6988         * ada-lang.c (ada_lookup_simple_minsym)
6989         (ada_collect_symbol_completion_matches): Update.
6990
6991 2019-01-16  Tom Tromey  <tom@tromey.com>
6992
6993         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6994         type.  Remove no-argument constructor.
6995         <iterator::operator++>: Simplify.
6996         <begin>: Update.
6997         <end>: Use minimal_symbol_count.
6998
6999 2019-01-16  Tom Tromey  <tom@tromey.com>
7000
7001         * objfiles.h (struct objfile) <psymtabs>: New method.
7002         (class objfile_psymtabs): Remove.
7003         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7004         typedef.
7005         <range>: New method.
7006         (require_partial_symbols): Change return type.
7007         * psymtab.c (require_partial_symbols)
7008         (psym_expand_symtabs_matching): Update.
7009         * mdebugread.c (parse_partial_symbols): Update.
7010         * dbxread.c (dbx_end_psymtab): Update.
7011
7012 2019-01-15  Tom Tromey  <tom@tromey.com>
7013
7014         * symtab.c (lookup_objfile_from_block)
7015         (lookup_symbol_in_objfile_symtabs)
7016         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7017         (find_line_symtab, info_sources_command)
7018         (default_collect_symbol_completion_matches_break_on)
7019         (make_source_files_completion_list): Update.
7020         * symmisc.c (print_objfile_statistics, dump_objfile)
7021         (maintenance_print_symbols, maintenance_info_symtabs)
7022         (maintenance_check_symtabs, maintenance_info_line_tables):
7023         Update.
7024         * source.c (select_source_symtab)
7025         (forget_cached_source_info_for_objfile): Update.
7026         * objfiles.h (class objfile_compunits): Remove.
7027         (struct objfile) <compunits_range>: New typedef.
7028         (compunits): New method.
7029         * objfiles.c (objfile_relocate1): Update.
7030         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7031         * maint.c (count_symtabs_and_blocks): Update.
7032         * linespec.c (iterate_over_all_matching_symtabs): Update.
7033         * cp-support.c (add_symbol_overload_list_qualified): Update.
7034         * coffread.c (coff_symtab_read): Update.
7035         * ada-lang.c (add_nonlocal_symbols)
7036         (ada_collect_symbol_completion_matches)
7037         (ada_add_global_exceptions): Update.
7038
7039 2019-01-15  Tom Tromey  <tom@tromey.com>
7040
7041         * progspace.h (program_space) <objfiles_safe_range>: New
7042         typedef.
7043         <objfiles_safe>: New method.
7044         * objfiles.h (class all_objfiles_safe): Remove.
7045         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7046         * jit.c (jit_inferior_exit_hook): Update.
7047
7048 2019-01-17  Tom Tromey  <tom@tromey.com>
7049
7050         * progspace.h (program_space) <objfiles_range>: New typedef.
7051         <objfiles>: New method.
7052         <objfiles_head>: Rename from objfiles.
7053         (object_files): Update.
7054         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7055         * guile/scm-pretty-print.c
7056         (ppscm_find_pretty_printer_from_objfiles): Update.
7057         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7058         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7059         Update.
7060         * python/py-progspace.c (pspy_get_objfiles): Update.
7061         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7062         Update.
7063         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7064         (objfpy_lookup_objfile_by_build_id): Update.
7065         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7066         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7067         Update.
7068         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7069         (expand_symtab_containing_pc, lookup_objfile_from_block)
7070         (lookup_static_symbol, basic_lookup_transparent_type)
7071         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7072         (find_line_symtab, info_sources_command)
7073         (default_collect_symbol_completion_matches_break_on)
7074         (make_source_files_completion_list, find_main_name): Update.
7075         * symmisc.c (print_symbol_bcache_statistics)
7076         (print_objfile_statistics, maintenance_print_symbols)
7077         (maintenance_print_msymbols, maintenance_print_objfiles)
7078         (maintenance_info_symtabs, maintenance_check_symtabs)
7079         (maintenance_expand_symtabs, maintenance_info_line_tables):
7080         Update.
7081         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7082         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7083         (map_overlay_command, unmap_overlay_command)
7084         (simple_overlay_update, expand_symtabs_matching)
7085         (map_symbol_filenames): Update.
7086         * symfile-debug.c (set_debug_symfile): Update.
7087         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7088         Update.
7089         * source.c (select_source_symtab, forget_cached_source_info):
7090         Update.
7091         * solib.c (solib_read_symbols): Update.
7092         * solib-spu.c (append_ocl_sos): Update.
7093         * psymtab.c (maintenance_print_psymbols)
7094         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7095         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7096         * printcmd.c (info_symbol_command): Update.
7097         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7098         Update.
7099         * objfiles.h (class all_objfiles): Remove.
7100         * objfiles.c (have_partial_symbols, have_full_symbols)
7101         (have_minimal_symbols, qsort_cmp, update_section_map)
7102         (shared_objfile_contains_address_p)
7103         (default_iterate_over_objfiles_in_search_order): Update.
7104         * objc-lang.c (info_selectors_command, info_classes_command)
7105         (find_methods): Update.
7106         * minsyms.c (find_solib_trampoline_target): Update.
7107         * maint.c (maintenance_info_sections)
7108         (maintenance_translate_address, count_symtabs_and_blocks):
7109         Update.
7110         * main.c (captured_main_1): Update.
7111         * linux-thread-db.c (try_thread_db_load_from_pdir)
7112         (has_libpthread): Update.
7113         * linespec.c (iterate_over_all_matching_symtabs)
7114         (search_minsyms_for_name): Update.
7115         * jit.c (jit_find_objf_with_entry_addr): Update.
7116         * hppa-tdep.c (find_unwind_entry)
7117         (hppa_lookup_stub_minimal_symbol): Update.
7118         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7119         Update.
7120         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7121         (elf_gnu_ifunc_resolve_by_got): Update.
7122         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7123         * dwarf-index-write.c (save_gdb_index_command): Update.
7124         * cp-support.c (add_symbol_overload_list_qualified): Update.
7125         * breakpoint.c (create_overlay_event_breakpoint)
7126         (create_longjmp_master_breakpoint)
7127         (create_std_terminate_master_breakpoint)
7128         (create_exception_master_breakpoint): Update.
7129         * blockframe.c (find_pc_partial_function): Update.
7130         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7131         (ada_collect_symbol_completion_matches)
7132         (ada_add_global_exceptions): Update.
7133
7134 2019-01-17  Tom Tromey  <tom@tromey.com>
7135
7136         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7137         declare VEC.
7138         (solib_target_parse_libraries): Change return type.
7139         (library_list_start_segment, library_list_start_section)
7140         (library_list_end_library, library_list_start_library); Update.
7141         (solib_target_free_library_list): Remove.
7142         (solib_target_parse_libraries): Remove cleanup.  Change return
7143         type.
7144         (solib_target_current_sos): Update.
7145
7146 2019-01-17  Tom Tromey  <tromey@bapiya>
7147
7148         * valprint.c: Replace "the the" with "the".
7149         * symtab.c: Replace "the the" with "the".
7150         * solib.c: Replace "the the" with "the".
7151         * solib-dsbt.c: Replace "the the" with "the".
7152         * linespec.c: Replace "the the" with "the".
7153         * dwarf2loc.h: Replace "the the" with "the".
7154         * amd64-windows-tdep.c: Replace "the the" with "the".
7155         * aarch64-tdep.c: Replace "the the" with "the".
7156
7157 2019-01-16  Keith Seitz  <keiths@redhat.com>
7158
7159         PR gdb/23773
7160         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7161         <builder>: Rename to ..
7162         <m_builder>: ... this and make private.
7163         (dwarf2_cu::get_builder): New method.  Change all users of
7164         `builder' to use this method.
7165         (dwarf2_start_symtab): Move to ...
7166         (dwarf2_cu::start_symtab): ... here.  Update all callers
7167         (setup_type_unit_groups): Move to ...
7168         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7169         callers.
7170         (dwarf2_cu::reset_builder): New method.
7171         (process_full_compunit, process_full_type_unit): Use
7172         dwarf2_cu::reset_builder.
7173         (follow_die_offset): Record the ancestor CU if it is different
7174         from the followed DIE's CU.
7175         (follow_die_sig_1): Likewise.
7176
7177 2019-01-15  Tom Tromey  <tom@tromey.com>
7178
7179         * remote.c (class remote_state) <buf>: Now a char_vector.
7180         <buf_size>: Remove.
7181         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7182         parameter.
7183         (remote_target::getpkt_or_notif_sane_1)
7184         (remote_target::getpkt_sane)
7185         (remote_target::getpkt_or_notif_sane): Likewise.
7186         (class remote_target) <putpkt>: New overload.
7187         (remote_target::read_frame): Change type of "buf_p".  Remove
7188         sizeof_p parameter.
7189         (packet_ok): New overload.
7190         (packet_check_result): New overload.
7191         Update all uses.
7192
7193 2019-01-14  Tom Tromey  <tom@tromey.com>
7194
7195         * remote-notif.c (handle_notification, remote_notif_ack)
7196         (remote_notif_parse): Make "buf" const.
7197         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7198         const.
7199         (remote_notif_parse, remote_notif_ack, handle_notification):
7200         Likewise.
7201         * remote.c (remote_notif_stop_parse): Make "buf" const.
7202         (remote_target::remote_parse_stop_reply): Make "buf" const.
7203         (remote_notif_stop_ack): Make "buf" const.
7204
7205 2019-01-14  Tom Tromey  <tom@tromey.com>
7206
7207         * remote.c (remote_console_output): Make parameter const.
7208
7209 2019-01-14  Tom Tromey  <tom@tromey.com>
7210
7211         * target-debug.h (target_debug_print_signals): Constify.
7212         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7213         * procfs.c (procfs_target::pass_signals): Update.
7214         * linux-nat.c (linux_nat_target::pass_signals): Update.
7215         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7216         * target-delegates.c: Rebuild.
7217         * remote.c (remote_target::program_signals): Update.
7218         (remote_target::pass_signals): Update.
7219         * target.c (target_pass_signals): Constify argument.
7220         (target_program_signals): Likewise.
7221         * target.h (struct target_ops) <pass_signals, program_signals>:
7222         Constify argument.
7223         (target_pass_signals, target_program_signals): Constify argument.
7224
7225 2019-01-14  Tom Tromey  <tom@tromey.com>
7226
7227         PR tui/28819:
7228         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7229
7230 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7231
7232         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7233         field.
7234         * rs6000-tdep.c: Include reggroups.h.
7235         (IS_V_ALIAS_PSEUDOREG): Define.
7236         (rs6000_register_name): Return names for the "vX" aliases.
7237         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7238         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7239         aliases.  Call default_register_reggroup_p for all other
7240         pseudo-registers.
7241         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7242         New functions.
7243         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7244         Handle "vX" aliases.
7245         (v_alias_pseudo_register_collect): New function.
7246         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7247         (rs6000_gdbarch_init): Initialize "vX" aliases as
7248         pseudo-registers.  Restore registration of
7249         rs6000_pseudo_register_reggroup_p with
7250         set_tdesc_pseudo_register_reggroup_p.
7251
7252 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7253
7254         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7255         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7256         set_gdbarch_num_pseudo_regs.
7257
7258 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7259
7260         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7261         Remove arg prefixname, add do_set and do_show.
7262         Add member functions set_list and show_list.
7263         * cli/cli-style.c (class cli_style_option): Update accordingly.
7264         (style_set_list): Move to file scope.
7265         (style_show_list): Likewise.
7266         (set_style): Call help_list.
7267         (show_style): Call cmd_show_list.
7268         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7269         Update to use the new macro.
7270
7271 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7272
7273         * ada-lang.c (_initialize_ada_language): Expand the help text
7274         for the "catch exception" command.
7275
7276 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7277
7278         * symtab.c (matching_obj_sections): Initialize obj,
7279         declare it closer to its usage.
7280
7281 2019-01-10  Tom Tromey  <tom@tromey.com>
7282
7283         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7284         (basic_inf_threads_range): Remove.
7285         (inf_threads_range, inf_non_exited_threads_range)
7286         (safe_inf_threads_range): Use next_adapter.
7287
7288 2019-01-10  Keith Seitz  <keiths@redhat.com>
7289
7290         PR gdb/23712
7291         PR symtab/23010
7292         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7293         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7294
7295 2019-01-10  Keith Seitz  <keiths@redhat.com>
7296
7297         PR gdb/23712
7298         PR symtab/23010
7299         * dictionary.c (pending_to_vector): Remove.
7300         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7301         Remove _1 suffix, replacing functions of the same name.  Update
7302         all callers.
7303         (dict_create_hashed, dict_create_hashed_expandable)
7304         (dict_create_linear, dict_create_linear_expandable, dict_free)
7305         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7306         Make functions static.
7307
7308 2019-01-10  Keith Seitz  <keiths@redhat.com>
7309
7310         PR gdb/23712
7311         PR symtab/23010
7312         * dictionary.h (struct dictionary): Replace declaration with
7313         multidictionary.
7314         (dict_create_hashed, dict_create_hashed_expandable)
7315         (dict_create_linear, dict_create_linear_expandable)
7316         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7317         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7318         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7319         taking multidictionary argument.
7320         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7321         * block.h (struct block) <dict>: Change to multidictionary
7322         and rename `multidict'.
7323         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7324         symmisc.c: Update all dictionary references to multidictionary.
7325
7326 2019-01-10  Keith Seitz  <keiths@redhat.com>
7327
7328         PR gdb/23712
7329         PR symtab/23010
7330         * dictionary.c: Include unordered_map.
7331         (pending_to_vector): New function.
7332         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7333         Rewrite the non-"_1" functions to take vector instead
7334         of linked list.
7335         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7336         "new" _1 versions of the same name.
7337         (multidictionary): Define.
7338         (std::hash<enum language): New definition.
7339         (collate_pending_symbols_by_language, mdict_create_hashed)
7340         (mdict_create_hashed_expandable, mdict_create_linear)
7341         (mdict_create_linear_expandable, mdict_free)
7342         (find_language_dictionary, create_new_language_dictionary)
7343         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7344         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7345         (mdict_size, mdict_empty): New functions.
7346         * dictionary.h (mdict_iterator): Define.
7347
7348 2019-01-10  Pedro Alves  <palves@redhat.com>
7349
7350         * breakpoint.c (read_uploaded_action)
7351         (create_tracepoint_from_upload): Adjust to use
7352         gdb::unique_xmalloc_ptr.
7353         * ctf.c (ctf_write_uploaded_tp):
7354         (SET_ARRAY_FIELD): Use emplace_back.
7355         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7356         * tracefile-tfile.c (tfile_write_uploaded_tp):
7357         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7358         gdb::unique_xmalloc_ptr.
7359         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7360         at_string, cond_string, cmd_strings>: Replace char pointers
7361         with gdb::unique_xmalloc_ptr.
7362
7363 2019-01-10  Pedro Alves  <palves@redhat.com>
7364
7365         * solib-target.c (library_list_start_library): Don't xstrdup name.
7366
7367 2019-01-10  Pedro Alves  <palves@redhat.com>
7368
7369         * mdebugread.c (parse_partial_symbols): Use
7370         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7371
7372 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7373
7374         * linux-fork.c (scoped_switch_fork_info)
7375         <~scoped_switch_fork_info>: Fix incorrect variable name.
7376
7377 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7378
7379         * linux-fork.c (scoped_switch_fork_info)
7380         <scoped_switch_fork_info>: Make explicit.
7381         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7382
7383 2019-01-10  Tom Tromey  <tom@tromey.com>
7384
7385         * objfiles.h (objfile::reset_psymtabs): Update.
7386         * objfiles.c (objfile::objfile): Update.
7387         * psymtab.h (psymtab_storage::obstack): Update.
7388         (psymtab_storage::m_obstack): Use gdb::optional.
7389         (class psymtab_storage): Update comment.  Remove objfile
7390         parameter.
7391         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7392
7393 2019-01-10  Tom Tromey  <tom@tromey.com>
7394
7395         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7396         <free_psymtabs>: Now private.
7397         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7398         (allocate_psymtab): Use new method.
7399
7400 2019-01-10  Tom Tromey  <tom@tromey.com>
7401
7402         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7403         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7404         * mdebugread.c (parse_partial_symbols): Use
7405         allocate_dependencies.
7406         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7407         allocate_dependencies.
7408         (process_psymtab_comp_unit_reader)
7409         (build_type_psymtab_dependencies): Likewise.
7410         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7411
7412 2019-01-10  Tom Tromey  <tom@tromey.com>
7413
7414         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7415         PSYMBOL_SET_LANGUAGE.
7416         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7417
7418 2019-01-10  Tom Tromey  <tom@tromey.com>
7419
7420         * psymtab.h (psymtab_storage::obstack): New method.
7421         <m_obstack>: Rename from obstack; now private.
7422         * psymtab.c (psymtab_storage): Update.
7423         * dwarf2read.c (create_addrmap_from_index)
7424         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7425         Update.
7426
7427 2019-01-10  Tom Tromey  <tom@tromey.com>
7428
7429         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7430         * objfiles.h (objfile::reset_psymtabs): New method.
7431
7432 2019-01-10  Tom Tromey  <tom@tromey.com>
7433
7434         * symmisc.c (print_symbol_bcache_statistics): Update.
7435         (print_objfile_statistics): Update.
7436         * symfile.c (reread_symbols): Update.
7437         * psymtab.h (class psymtab_storage): New.
7438         * psymtab.c (psymtab_storage): New constructor.
7439         (~psymtab_storage): New destructor.
7440         (require_partial_symbols): Update.
7441         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7442         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7443         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7444         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7445         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7446         (start_psymtab_common, end_psymtab_common)
7447         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7448         (allocate_psymtab): Update.
7449         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7450         Update.
7451         (dump_psymtab_addrmap, maintenance_print_psymbols)
7452         (maintenance_check_psymtabs): Update.
7453         (class objfile_psymtabs): Move to objfiles.h.
7454         * psympriv.h (discard_psymtab): Now inline.
7455         (psymtab_discarder::psymtab_discarder): Update.
7456         (psymtab_discarder::~psymtab_discarder): Update.
7457         (ALL_OBJFILE_PSYMTABS): Rewrite.
7458         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7459         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7460         Remove fields.
7461         <partial_symtabs>: New field.
7462         (class objfile_psymtabs): Move from psymtab.h.  Update.
7463         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7464         psymbol_cache.
7465         (objfile::~objfile): Don't destroy psymbol_cache.
7466         * mdebugread.c (parse_partial_symbols): Update.
7467         * dwarf2read.c (create_addrmap_from_index)
7468         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7469         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7470         (add_partial_subprogram, dwarf2_ranges_read): Update.
7471         * dwarf-index-write.c (write_address_map)
7472         (write_one_signatured_type, recursively_write_psymbols)
7473         (class debug_names, class debug_names, write_psymtabs_to_index):
7474         Update.
7475
7476 2019-01-10  Tom Tromey  <tom@tromey.com>
7477
7478         * symtab.h (SYMBOL_SET_NAMES): Update.
7479         (symbol_set_names): Update.
7480         (MSYMBOL_SET_NAMES): Update.
7481         * symtab.c (symbol_set_names): Change argument to be an
7482         objfile_per_bfd_storage.
7483         * psymtab.c (add_psymbol_to_bcache): Update.
7484         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7485
7486 2019-01-10  Tom Tromey  <tom@tromey.com>
7487
7488         * symtab.c (create_demangled_names_hash): Change argument to be an
7489         objfile_per_bfd_storage.
7490         (symbol_set_names): Update.
7491
7492 2019-01-10  Tom Tromey  <tom@tromey.com>
7493
7494         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7495         init_psymbol_list.
7496         * psymtab.c (init_psymbol_list): Do nothing if already called.
7497         * psympriv.h (init_psymbol_list): Add comment.
7498         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7499         init_psymbol_list.
7500         * dbxread.c (dbx_symfile_read): Unconditionally call
7501         init_psymbol_list.
7502
7503 2019-01-10  Tom Tromey  <tom@tromey.com>
7504
7505         * xcoffread.c (scan_xcoff_symtab): Update.
7506         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7507         "where".
7508         * mdebugread.c (parse_partial_symbols)
7509         (handle_psymbol_enumerators): Update.
7510         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7511         * dbxread.c (read_dbx_symtab): Update.
7512         * psympriv.h (psymbol_placement): New enum.
7513         (add_psymbol_to_list): Update.
7514
7515 2019-01-10  Tom Tromey  <tom@tromey.com>
7516
7517         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7518         static_psymbols parameters.
7519         (scan_xcoff_symtab): Update.
7520         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7521         static_psymbols parameters.
7522         * psympriv.h (start_psymtab_common): Update.
7523         * mdebugread.c (parse_partial_symbols): Update.
7524         * dwarf2read.c (create_partial_symtab): Update.
7525         * dbxread.c (read_dbx_symtab): Update.
7526         (start_psymtab): Remove global_psymbols and static_psymbols
7527         parameters.
7528
7529 2019-01-10  Tom Tromey  <tom@tromey.com>
7530
7531         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7532         * psymtab.c (allocate_psymtab): Add comment.
7533         * psympriv.h (allocate_psymtab): Add comment.
7534         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7535         initializations.
7536         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7537
7538 2019-01-10  Tom Tromey  <tom@tromey.com>
7539
7540         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7541         Don't declare.
7542         * mipsread.c: Include mdebugread.h.
7543         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7544         Declare.
7545         * elfread.c: Include mdebugread.h.
7546
7547 2019-01-09  Tom Tromey  <tom@tromey.com>
7548
7549         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7550         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7551         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7552         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7553         (psym_lookup_symbol, psym_find_last_source_symtab)
7554         (psym_forget_cached_source_info, psym_print_stats)
7555         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7556         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7557         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7558         (psym_find_compunit_symtab_by_address)
7559         (maintenance_print_psymbols, maintenance_info_psymtabs)
7560         (maintenance_check_psymtabs): Use ranged for.
7561         * psymtab.h (class objfile_psymtabs): New.
7562         (require_partial_symbols): Return objfile_psymtabs.
7563         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7564
7565 2019-01-09  Tom Tromey  <tom@tromey.com>
7566
7567         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7568         (find_pc_mapped_section, list_overlays_command)
7569         (map_overlay_command, unmap_overlay_command)
7570         (simple_overlay_update): Use all_objfiles.
7571         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7572         * printcmd.c (info_symbol_command): Use all_objfiles.
7573         * objfiles.h (ALL_OBJSECTIONS): Remove.
7574         * maint.c (maintenance_translate_address): Use all_objfiles.
7575         * gcore.c (gcore_create_callback): Use all_objfiles.
7576         (objfile_find_memory_regions): Likewise.
7577
7578 2019-01-09  Tom Tromey  <tom@tromey.com>
7579
7580         * symtab.c (find_line_symtab, info_sources_command)
7581         (make_source_files_completion_list): Use objfile_compunits.
7582         * source.c (select_source_symtab): Use objfile_compunits.
7583         * objfiles.h (struct objfile): Update comment.
7584         (ALL_OBJFILES): Remove.
7585         (ALL_FILETABS): Remove.
7586         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7587         objfile_compunits.
7588
7589 2019-01-09  Tom Tromey  <tom@tromey.com>
7590
7591         * symmisc.c (print_objfile_statistics, dump_objfile)
7592         (maintenance_print_symbols): Use compunit_filetabs.
7593         * source.c (forget_cached_source_info_for_objfile): Use
7594         compunit_filetabs.
7595         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7596         (ALL_FILETABS): Use compunit_filetabs.
7597         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7598         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7599
7600 2019-01-09  Tom Tromey  <tom@tromey.com>
7601
7602         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7603         (compunit_filetabs): New.
7604         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7605         compunit_filetabs.
7606         (info_sources_command, make_source_files_completion_list): Remove
7607         declaration.
7608         * symmisc.c (print_objfile_statistics, dump_objfile)
7609         (maintenance_print_symbols): Remove declaration.
7610         (maintenance_info_symtabs): Use compunit_filetabs.
7611         (maintenance_info_line_tables): Likewise.
7612         * source.c (select_source_symtab): Change local variable name.
7613         (forget_cached_source_info_for_objfile): Remove declaration.
7614         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7615         * objfiles.c (objfile_relocate1): Remove declaration.
7616         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7617         declaration.
7618         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7619         * coffread.c (coff_symtab_read): Remove declaration.
7620         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7621         compunit_filetabs.
7622
7623 2019-01-09  Tom Tromey  <tom@tromey.com>
7624
7625         * symtab.c (lookup_objfile_from_block)
7626         (find_pc_sect_compunit_symtab, search_symbols)
7627         (default_collect_symbol_completion_matches_break_on): Use
7628         objfile_compunits.
7629         * objfiles.h (ALL_COMPUNITS): Remove.
7630         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7631         * cp-support.c (add_symbol_overload_list_qualified): Use
7632         objfile_compunits.
7633         * ada-lang.c (ada_collect_symbol_completion_matches)
7634         (ada_add_global_exceptions): Use objfile_compunits.
7635
7636 2019-01-09  Tom Tromey  <tom@tromey.com>
7637
7638         * source.c (select_source_symtab)
7639         (forget_cached_source_info_for_objfile): Remove declaration.
7640         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7641         declaration.
7642         * maint.c (count_symtabs_and_blocks): Remove declaration.
7643         * cp-support.c (add_symbol_overload_list_qualified): Remove
7644         declaration.
7645         * coffread.c (coff_symtab_read): Remove declaration.
7646         * symtab.c (lookup_symbol_in_objfile_symtabs)
7647         (basic_lookup_transparent_type_1): Use objfile_compunits.
7648         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7649         (info_sources_command, search_symbols)
7650         (default_collect_symbol_completion_matches_break_on)
7651         (make_source_files_completion_list): Remove declaration.
7652         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7653         (ada_collect_symbol_completion_matches)
7654         (ada_add_global_exceptions): Remove declaration.
7655         * linespec.c (iterate_over_all_matching_symtabs): Use
7656         objfile_compunits.
7657         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7658         (class objfile_compunits): New.
7659         (ALL_COMPUNITS): Use objfile_compunits.
7660         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7661         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7662         objfile_compunits.
7663         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7664
7665 2019-01-09  Tom Tromey  <tom@tromey.com>
7666
7667         * symtab.c (search_symbols)
7668         (default_collect_symbol_completion_matches_break_on): Use
7669         objfile_msymbols.
7670         * ada-lang.c (ada_lookup_simple_minsym)
7671         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7672         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7673         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7674         objfile_msymbols.
7675         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7676         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7677         * objc-lang.c (find_methods): Use objfile_msymbols.
7678         (info_selectors_command, info_classes_command): Likewise.
7679         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7680         * objfiles.h (class objfile_msymbols): New.
7681         (ALL_OBJFILE_MSYMBOLS): Remove.
7682         (ALL_MSYMBOLS): Remove.
7683
7684 2019-01-09  Tom Tromey  <tom@tromey.com>
7685
7686         * common/next-iterator.h (next_adapter): Add Iterator template
7687         parameter.
7688         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7689         (class all_objfiles_safe): New.
7690         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7691         * objfiles.c (put_objfile_before): Update comment.
7692         (add_separate_debug_objfile): Likewise.
7693         (free_all_objfiles): Use all_objfiles_safe.
7694         (objfile_purge_solibs): Likewise.
7695
7696 2019-01-09  Tom Tromey  <tom@tromey.com>
7697
7698         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7699         (expand_symtab_containing_pc, lookup_static_symbol)
7700         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7701         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7702         all_objfiles.
7703         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7704         * breakpoint.c (create_overlay_event_breakpoint)
7705         (create_longjmp_master_breakpoint)
7706         (create_std_terminate_master_breakpoint)
7707         (create_exception_master_breakpoint): Use all_objfiles.
7708         * linux-thread-db.c (try_thread_db_load_from_pdir)
7709         (has_libpthread): Use all_objfiles.
7710         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7711         * linespec.c (iterate_over_all_matching_symtabs)
7712         (search_minsyms_for_name): Use all_objfiles.
7713         * maint.c (maintenance_info_sections): Use all_objfiles.
7714         * main.c (captured_main_1): Use all_objfiles.
7715         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7716         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7717         * guile/scm-pretty-print.c
7718         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7719         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7720         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7721         (maintenance_print_msymbols): Use all_objfiles.
7722         * source.c (select_source_symtab): Use all_objfiles.
7723         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7724         * symfile.c (remove_symbol_file_command)
7725         (expand_symtabs_matching, map_symbol_filenames): Use
7726         all_objfiles.
7727         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7728         all_objfiles.
7729         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7730         * objc-lang.c (find_methods): Use all_objfiles.
7731         * objfiles.c (have_partial_symbols, have_full_symbols)
7732         (have_minimal_symbols, qsort_cmp)
7733         (default_iterate_over_objfiles_in_search_order): Use
7734         all_objfiles.
7735         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7736         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7737         (maintenance_check_psymtabs): Use all_objfiles.
7738         (ALL_PSYMTABS): Remove.
7739         * compile/compile-object-run.c (do_module_cleanup): Use
7740         all_objfiles.
7741         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7742         * cp-support.c (add_symbol_overload_list_qualified): Use
7743         all_objfiles.
7744         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7745         Use all_objfiles.
7746         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7747         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7748         all_objfiles.
7749         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7750         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7751         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7752         Uses all_objfiles.
7753         * solib.c (solib_read_symbols): Use all_objfiles
7754
7755 2019-01-09  Tom Tromey  <tom@tromey.com>
7756
7757         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7758         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7759         all_objfiles.
7760         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7761         * symmisc.c (print_symbol_bcache_statistics)
7762         (print_objfile_statistics, maintenance_print_objfiles)
7763         (maintenance_info_symtabs, maintenance_check_symtabs)
7764         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7765         all_objfiles.
7766         * source.c (forget_cached_source_info): Use all_objfiles.
7767         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7768         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7769         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7770         * objfiles.c (update_section_map): Use all_objfiles.
7771         (shared_objfile_contains_address_p): Likewise.
7772         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7773         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7774
7775 2019-01-09  Tom Tromey  <tom@tromey.com>
7776
7777         * common/next-iterator.h: New file.
7778         * objfiles.h (class all_objfiles): New.
7779         (struct objfile_iterator): New.
7780
7781 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7782
7783         * NEWS: Move the description of the changed "frame", "select-frame",
7784          and "info frame" commands to the Changed commands section.
7785
7786 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7787
7788         * gdbtypes.c (check_stub_method_group): Remove handling of old
7789         mangling schemes.
7790         * linespec.c (find_methods): Likewise.
7791         * stabsread.c (read_member_functions): Likewise.
7792         * valops.c (search_struct_method): Likewise.
7793         (value_struct_elt_for_reference): Likewise.
7794         * NEWS: Mention this change.
7795
7796 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7797
7798         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7799         print_source_lines.
7800         * source.c (print_source_lines_base): Update line number check.
7801         (print_source_lines): New function.
7802         (source_lines_range::source_lines_range): New function.
7803         * source.h (class source_lines_range): New class.
7804         (print_source_lines): New declaration.
7805
7806 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7807
7808         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7809
7810 2019-01-08  Tom Tromey  <tom@tromey.com>
7811             Simon Marchi  <simon.marchi@ericsson.com>
7812
7813         PR gdb/24060
7814         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7815         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7816         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7817         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7818         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7819         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7820
7821 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7822
7823         * source.c (select_source_symtab): Move header comment to
7824         declaration in source.h.
7825         (forget_cached_source_info_for_objfile): Likewise.
7826         (forget_cached_source_info): Likewise.
7827         (identify_source_line): Likewise.
7828         * source.h (identify_source_line): Move declaration from symtab.h
7829         and add comment from source.c
7830         (print_source_lines): Likewise.
7831         (forget_cached_source_info_for_objfile): Likewise.
7832         (forget_cached_source_info): Likewise.
7833         (select_source_symtab): Likewise.
7834         (enum print_source_lines_flag): Move definition from symtab.h.
7835         * symtab.h (identify_source_line): Move declaration to source.h.
7836         (print_source_lines): Likewise.
7837         (forget_cached_source_info_for_objfile): Likewise.
7838         (forget_cached_source_info): Likewise.
7839         (select_source_symtab): Likewise.
7840         (enum print_source_lines_flag): Move definition to source.h.
7841         * tui/tui-hooks.c: Add 'source.h' include.
7842
7843 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * source.c (print_source_lines_base): Handle requests to print
7846         reverse line number sequences, and guard against empty lines
7847         string.
7848
7849 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7850
7851         * source.c (print_source_lines_base): Fix skip of '\r' if next
7852         character is '\n'.
7853
7854 2019-01-06  Tom Tromey  <tom@tromey.com>
7855
7856         * c-exp.y (struct c_parse_state) <macro_original_text,
7857         expansion_obstack>: New member.
7858         (macro_original_text, expansion_obstack): Remove globals.
7859         (scan_macro_expansion, scanning_macro_expansion)
7860         (finished_macro_expansion): Update.
7861         (scan_macro_cleanup): Remove.
7862         (yylex, c_parse): Update.
7863
7864 2019-01-06  Tom Tromey  <tom@tromey.com>
7865
7866         * c-exp.y (struct c_parse_state) <strings>: New member.
7867         (operator_stoken): Update.
7868
7869 2019-01-06  Tom Tromey  <tom@tromey.com>
7870
7871         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7872         (union type_stack_elt) <typelist_val>: Now a pointer to
7873         std::vector.
7874         (type_stack_cleanup): Don't declare.
7875         (push_typelist): Update.
7876         * parse.c (pop_typelist): Return a std::vector.
7877         (push_typelist): Take a std::vector.
7878         (follow_types): Update.  Do not free args.
7879         (type_stack_cleanup): Remove.
7880         * c-exp.y (struct c_parse_state): New.
7881         (cpstate): New global.
7882         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7883         (nonempty_typelist): Update.
7884         (func_mod): Create a new vector.
7885         (c_parse): Create a c_parse_state.
7886         (check_parameter_typelist): Do not delete params.
7887         (function_method): Update.  Do not delete type_list.
7888
7889 2019-01-06  Tom Tromey  <tom@tromey.com>
7890
7891         PR gdb/28155:
7892         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7893         check_typedef.
7894         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7895         (print_return_value): Likewise.
7896
7897 2019-01-05  Tom Tromey  <tom@tromey.com>
7898
7899         * contrib/cleanup_check.py: Remove.
7900         * contrib/gcc-with-excheck: Remove.
7901         * contrib/exsummary.py: Remove.
7902         * contrib/excheck.py: Remove.
7903
7904 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7905
7906         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7907         NULL. Initialize tpprev to NULL instead of assigning it
7908         to NULL on the next statement.
7909         * windows-nat.c (windows_delete_thread): Remove check for
7910         main_thread_id before printing thread exit notifications.
7911         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7912         Remove thread ID check against main_thread_id.
7913         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7914         windows_delete_thread.
7915         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7916
7917 2019-01-04  Tom Tromey  <tom@tromey.com>
7918
7919         * compile/compile.c (_initialize_compile): Use upper case for
7920         metasyntactic variables.
7921         * symmisc.c (_initialize_symmisc): Use upper case for
7922         metasyntactic variables.
7923         * psymtab.c (_initialize_psymtab): Use upper case for
7924         metasyntactic variables.
7925         * demangle.c (demangle_command): Use upper case for metasyntactic
7926         variables.
7927         (_initialize_demangler): Likewise.
7928         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7929         variables.
7930
7931 2019-01-03  Tom Tromey  <tom@tromey.com>
7932
7933         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7934
7935 2019-01-03  Tom Tromey  <tom@tromey.com>
7936
7937         * python/py-symtab.c (salpy_str): Update.
7938         (struct salpy_sal_object) <symtab>: Now a PyObject.
7939         (salpy_dealloc): Update.
7940         (del_objfile_sal): Use gdbpy_ref.
7941
7942 2019-01-03  Tom Tromey  <tom@tromey.com>
7943
7944         * python/py-type.c (convert_field): Use new_reference.  Return
7945         gdbpy_ref.
7946         (make_fielditem): Return gdbpy_ref.
7947         (typy_fields): Update.
7948         (typy_getitem): Update.
7949         (field_name): Return gdbpy_ref.  Use new_reference.
7950         (typy_iterator_iternext): Update.
7951
7952 2019-01-03  Tom Tromey  <tom@tromey.com>
7953
7954         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7955
7956 2019-01-03  Tom Tromey  <tom@tromey.com>
7957
7958         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7959         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7960         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7961         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7962         (pspy_set_type_printers): Likewise.
7963         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7964         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7965         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7966         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7967         (objfpy_set_type_printers): Likewise.
7968
7969 2019-01-03  Tom Tromey  <tom@tromey.com>
7970
7971         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7972         (gdbpy_print_stack): Use gdbpy_err_fetch.
7973         * python/python-internal.h (class gdbpy_err_fetch): New class.
7974         (class gdbpy_enter) <m_error_type, m_error_value,
7975         m_error_traceback>: Remove.
7976         <m_error>: New member.
7977         (gdbpy_exception_to_string): Don't declare.
7978         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7979         * python/py-value.c (convert_value_from_python): Use
7980         gdbpy_err_fetch.
7981         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7982         gdbpy_exception_to_string.
7983         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7984         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7985         gdbpy_err_fetch.
7986
7987 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7988
7989         * linux-nat.c (delete_lwp_cleanup): Delete.
7990         (struct lwp_deleter): New struct.
7991         (lwp_info_up): New typedef.
7992         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7993         lwp_info_up.
7994
7995 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7996
7997         * linux-fork.c (class scoped_switch_fork_info): New class.
7998         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7999
8000 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8001
8002         * valops.c (find_overload_match): Remove use of null_cleanup, and
8003         calls to do_cleanups.
8004
8005 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8006
8007         * compile/compile-cplus-types.c
8008         (compile_cplus_instance::decl_name): Handle changes to
8009         cp_func_name.
8010         * cp-support.c (cp_func_name): Update header comment, update
8011         return type.
8012         * cp-support.h (cp_func_name): Update return type in declaration.
8013         * valops.c (find_overload_match): Move temp_func local to top
8014         level of function and change its type.  Use temp_func to hold and
8015         delete temporary string obtained from cp_func_name.
8016
8017 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8020         gdb::char_vector, remove cleanup, and update uses of `msg`.
8021
8022 2019-01-03  Jim Wilson  <jimw@sifive.com>
8023
8024         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8025
8026 2019-01-02  Tom Tromey  <tom@tromey.com>
8027
8028         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8029         (tdesc_parse_xml): Remove cleanups.
8030         * target-descriptions.h (make_cleanup_free_target_description):
8031         Don't declare.
8032         (target_desc_deleter): New struct.
8033         (target_desc_up): New typedef.
8034         * target-descriptions.c (target_desc_deleter::operator()): Rename
8035         from free_target_description.
8036         (make_cleanup_free_target_description): Remove.
8037
8038 2019-01-02  Tom Tromey  <tom@tromey.com>
8039
8040         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8041         constructor, destructor.
8042         (linespec_parser): Remove typedef.
8043         (~linespec_parser): Rename from linespec_parser_delete.
8044         (linespec_lex_to_end, linespec_complete_label)
8045         (linespec_complete): Update.
8046         (decode_line_full): Remove cleanups.
8047         (decode_line_1): Update.
8048
8049 2019-01-02  Tom Tromey  <tom@tromey.com>
8050
8051         * python/python-internal.h (inferior_to_inferior_object): Change
8052         return type.
8053         * python/py-exitedevent.c (create_exited_event_object): Update.
8054         * python/py-inferior.c (inferior_to_inferior_object): Return
8055         gdbpy_ref.
8056         (python_new_inferior, python_inferior_deleted)
8057         (thread_to_thread_object, delete_thread_object)
8058         (build_inferior_list, gdbpy_selected_inferior): Update.
8059         * python/py-infthread.c (create_thread_object): Update.  Also fail
8060         if inferior_to_inferior_object fails.
8061
8062 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8063
8064         * inferior.h (class inferior) <displaced_step_state>: New field.
8065         * infrun.h (struct displaced_step_state): Move here from
8066         infrun.c.  Initialize fields, add constructor.
8067         <inf>: Remove field.
8068         <reset>: New method.
8069         * infrun.c (struct displaced_step_inferior_state): Move to
8070         infrun.h.
8071         (displaced_step_inferior_states): Remove.
8072         (get_displaced_stepping_state): Adust.
8073         (displaced_step_in_progress_any_inferior): Adjust.
8074         (displaced_step_in_progress_thread): Adjust.
8075         (displaced_step_in_progress): Adjust.
8076         (add_displaced_stepping_state): Remove.
8077         (get_displaced_step_closure_by_addr): Adjust.
8078         (remove_displaced_stepping_state): Remove.
8079         (infrun_inferior_exit): Call displaced_step_state.reset.
8080         (use_displaced_stepping): Don't check for NULL.
8081         (displaced_step_prepare_throw): Call
8082         get_displaced_stepping_state.
8083         (displaced_step_fixup): Don't check for NULL.
8084         (prepare_for_detach): Don't check for NULL.
8085
8086 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8087
8088         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8089          in case of call that did not complete.
8090
8091 2019-01-02  Andrey Utkin  <autkin@undo.io>
8092
8093         * symfile.c (find_separate_debug_file): Fix search of debug files for
8094         remote debuggee.
8095
8096 2019-01-02  Tom Tromey  <tom@tromey.com>
8097
8098         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8099         indentation.
8100         * python/py-frame.c (frapy_older): Remove cast.
8101         (frapy_newer): Likewise.
8102         * python/py-breakpoint.c (local_setattro): Remove cast.
8103         * python/py-arch.c (archpy_name): Remove local variable.
8104         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8105
8106 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8107
8108         * unittests/basic_string_view/element_access/char/empty.cc:
8109         Fix year range in copyright header.
8110
8111 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8112
8113         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8114         Delete.
8115         <operator==>: Update with for removed field.
8116         <hash>: Likewise.
8117         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8118         <isa_features>: ...this.
8119         <abi_features>: New field.
8120         (riscv_isa_flen): Update comment.
8121         (riscv_abi_xlen): New declaration.
8122         (riscv_abi_flen): New declaration.
8123         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8124         isa_features.
8125         (riscv_abi_xlen): New function.
8126         (riscv_isa_flen): Update to get answer from isa_features.
8127         (riscv_abi_flen): New function.
8128         (riscv_has_fp_abi): Update to get answer from abi_features.
8129         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8130         xlen and flen.
8131         (riscv_call_info) <xlen, flen>: Update comment.
8132         (riscv_call_arg_struct): Remove invalid assertions
8133         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8134         is removed.
8135         (riscv_gdbarch_init): Gather isa features and abi features
8136         separately, ensure both match on the gdbarch when reusing an old
8137         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8138         a target with 64-bit float hardware.
8139
8140 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8141
8142         * source.c (search_command_helper): Stop reverse search
8143         when line 1 has been searched.
8144
8145 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8146
8147         * record-full.c (record_full_base_target::close): Rewrite
8148         record_full_core_buf_list free logic.
8149
8150 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8151
8152         * break-catch-syscall.c (print_one_catch_syscall): xfree
8153         the last text.
8154
8155 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8156
8157         * top.c (print_gdb_version): Update Copyright year in version
8158         message.
8159
8160 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8161
8162         Update copyright year range in all GDB files.
8163
8164 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8165
8166         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8167
8168 For older changes see ChangeLog-2018.
8169 \f
8170 Local Variables:
8171 mode: change-log
8172 left-margin: 8
8173 fill-column: 74
8174 version-control: never
8175 coding: utf-8
8176 End:
8177