gdb/ChangeLog

   1 2019-06-22  Tom de Vries  <tdevries@suse.de>
   2
   3         * dwarf2read.c (create_addrmap_from_aranges)
   4         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
   5         instead of '%zu'.
   6
   7 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
   8
   9         * dwarf2read.h (dwarf2_section_info_def): Remove.
  10         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
  11         * dwarf2read.c (struct dwo_sections) <types>: Change type to
  12         std::vector<dwarf2_section_info>.
  13         (struct dwo_file) <~dwo_file>: Remove.
  14         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
  15         types field.
  16         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
  17         (dwarf2_read_debug_names): Likewise.
  18         (create_debug_types_hash_table): Change parameter type to
  19         array_view, adjust code accordingly.
  20         (dwarf2_locate_dwo_sections): Adjust to std::vector.
  21         (partial_die_info::fixup): Likewise.
  22         (determine_prefix): Likewise.
  23         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
  24
  25 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  26
  27         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
  28         gdb_bfd_ref_ptr.
  29         <~dwo_file>: Remove call to gdb_bfd_unref.
  30         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
  31         gdb_bfd_ref_ptr::get.
  32
  33 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  34
  35         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
  36         type to htab_up.
  37         * dwarf2read.c (struct dwo_file): Initialize fields.
  38         <~dwo_file>: New.
  39         (free_dwo_file): Remove, move content to ~dwo_file.
  40         (struct dwo_file_deleter): Remove.
  41         (dwo_file_up>: Remove custom deleter.
  42         (free_dwo_files): Remove.
  43         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
  44         dwo_files.
  45         (process_skeletonless_type_units): Call unique_ptr::get.
  46         (allocate_dwo_file_hash_table): Add deleter to created hash
  47         table.  Change return type to htab_up.
  48         (lookup_dwo_file_slot): Don't memset dwo_file, call
  49         unique_ptr::get.
  50         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
  51         (create_dwo_unit_in_dwp_v2): Likewise.
  52         (open_and_init_dwo_file): Likewise.
  53         (free_dwo_file_from_slot): Remove.
  54
  55 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  56
  57         * dwarf2read.h (struct dwarf2_section_info) <readin,
  58         is_virtual>: Change type to bool.
  59         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
  60         true instead of 1.
  61
  62 2019-06-19  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-data.h (tui_init_content_element): Don't declare.
  65
  66 2019-06-19  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-data.h (tui_init_win_info): Don't declare.
  69
  70 2019-06-19  Tom de Vries  <tdevries@suse.de>
  71
  72         * dwarf2read.h (abstract_to_concrete): Change type to
  73         std::unordered_map<sect_offset, std::vector<sect_offset>,
  74         gdb::hash_enum<sect_offset>>.
  75
  76 2019-06-19  Tom Tromey  <tromey@adacore.com>
  77
  78         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  79         EVAL_AVOID_SIDE_EFFECTS specially.
  80
  81 2019-06-19  Tom Tromey  <tromey@adacore.com>
  82
  83         * source-cache.c (highlighter): New global.
  84         (source_cache::get_source_lines): Create a highlighter on demand.
  85
  86 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  87
  88         * defs.h (deprecated_interactive_hook): Delete declaration.
  89         * interps.c (clear_interpreter_hooks): Remove use of
  90         deprecated_interactive_hook.
  91         * top.c (deprecated_interactive_hook): Delete definition.
  92         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  93
  94 2019-06-18  Tom de Vries  <tdevries@suse.de>
  95
  96         PR gdb/24515
  97         * dwarf2read.h (abstract_to_concrete): Change type from
  98         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  99         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 100         * dwarf2read.c (read_variable): Update.
 101         (dwarf2_fetch_die_loc_sect_off): Update.
 102
 103 2019-06-17  Tom de Vries  <tdevries@suse.de>
 104
 105         PR gdb/24617
 106         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 107         accessing parent[parent_len - 1].
 108
 109 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 110
 111         PR gdb/24364
 112         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 113         call dtrace_process_dof with NULL dof.
 114
 115 2019-06-16  Tom de Vries  <tdevries@suse.de>
 116
 117         PR gdb/24445
 118         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 119
 120 2019-06-16  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 123         (make_all_visible): Use address of member.
 124
 125 2019-06-16  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 128         (tui_free_window, free_content, free_content_elements): Remove
 129         unnecessary cast.
 130         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 131         cast.
 132         * tui/tui-regs.c (tui_show_register_group)
 133         (tui_display_registers_from, tui_display_reg_element_at_line):
 134         Remove unnecessary cast.
 135
 136 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 137
 138         * linux-nat.c (normal_mask): Delete.
 139         (_initialize_linux_nat): Don't initialise normal_mask.
 140
 141 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 142
 143         PR gdb/24445
 144         * dwarf-index-write.h (write_psymtabs_to_index): Add
 145         dwz_basename parameter.
 146         * dwarf-index-write.c (write_gdbindex): Move file writing to
 147         write_gdbindex_1.  Change return type void.
 148         (assert_file_size): Move up, remove filename parameter.
 149         (write_gdbindex_1): New function.
 150         (write_debug_names): Change return type to void, call
 151         assert_file_size.
 152         (struct index_wip_file): New struct.
 153         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 154         file logic to index_wip_file.  Write index for dwz file if
 155         needed.
 156         (save_gdb_index_command): Pass basename of dwz file, if present.
 157         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 158         build-id of dwz file, if present.
 159         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 160         (dwarf2_get_dwz_file): Likewise.
 161         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 162         (dwarf2_get_dwz_file): Likewise.
 163
 164 2019-06-16  Tom Tromey  <tom@tromey.com>
 165
 166         * coffread.c (process_coff_symbol): Use xstrdup.
 167         * value.c (create_internalvar): Use xstrdup.
 168
 169 2019-06-16  Tom Tromey  <tom@tromey.com>
 170
 171         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 172         * breakpoint.c (stopin_command, stopat_command)
 173         (until_break_command, decode_location_default): Remove unnecessary
 174         cast.
 175         * utils.c (subset_compare): Remove unnecessary cast.
 176         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 177         cast.
 178         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 179         cast.
 180         * infcmd.c (path_command): Remove unnecessary cast.
 181         * coffread.c (decode_type): Remove unnecessary cast.
 182         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 183         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 184         * tui/tui-stack.c (tui_show_locator_content)
 185         (tui_show_frame_info): Remove unnecessary cast.
 186         * tui/tui-win.c (tui_scroll_forward_command)
 187         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 188         (parse_scrolling_args): Remove unnecessary cast.
 189         * tui/tui-data.c (init_win_info, tui_del_window)
 190         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 191         (free_content_elements): Remove unnecessary cast.
 192         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 193         unnecessary cast.
 194         * tui/tui-source.c (tui_set_source_content)
 195         (tui_vertical_source_scroll): Remove unnecessary cast.
 196         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 197         cast.
 198         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 199         * tui/tui-regs.c (tui_display_registers_from)
 200         (tui_display_register): Remove unnecessary cast.
 201         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 202         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 203         (make_visible): Remove unnecessary cast.
 204         * tui/tui-winsource.c (tui_erase_source_content)
 205         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 206         unnecessary cast.
 207         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 208         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 209         * stabsread.c (read_type, read_array_type, read_range_type):
 210         Remove unnecessary cast.
 211         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 212         (parse_symbol, parse_type, upgrade_type, parse_external)
 213         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 214         unnecessary cast.
 215         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 216
 217 2019-06-16  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-data.c (tui_alloc_generic_win_info)
 220         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 221         checks.
 222
 223 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 224             Andrew Burgess  <andrew.burgess@embecosm.com>
 225
 226         * f-typeprint.c (f_print_type): Don't return early for not
 227         associated or not allocated types.
 228         (f_type_print_varspec_suffix): Add print_rank parameter and print
 229         ranks of array types in case they dangling.
 230         (f_type_print_base): Add print_rank parameter.
 231
 232 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 233
 234         * NEWS: Mention new MI commands.
 235         * break-catch-throw.c (enum exception_event_kind): Move to
 236         breakpoint.h.
 237         (print_mention_exception_catchpoint): Output text as a single
 238         message.
 239         (catch_exception_command_1): Rename to...
 240         (catch_exception_event): ...this, make non-static, update header
 241         command, and change some parameter types.
 242         (catch_catch_command): Update for changes to
 243         catch_exception_command_1.
 244         (catch_throw_command): Likewise.
 245         (catch_rethrow_command): Likewise.
 246         * breakpoint.c (enum exception_event_kind): Delete.
 247         * breakpoint.h (enum exception_event_kind): Moved here from
 248         break-catch-throw.c.
 249         (catch_exception_event): Declare.
 250         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 251         (mi_cmd_catch_throw): New function.
 252         (mi_cmd_catch_rethrow): New function.
 253         (mi_cmd_catch_catch): New function.
 254         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 255         'catch-catch' entries.
 256         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 257         (mi_cmd_catch_rethrow): Declare.
 258         (mi_cmd_catch_catch): Declare.
 259
 260 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * annotate.c (annotate_source_line): Change return type to void,
 263         update implementation to match.
 264         * annotate.h (annotate_source_line): Change return type to void,
 265         update header comment.
 266         * stack.c (print_frame_info): Don't change what frame information
 267         is printed based on whether annotations are on or not.
 268
 269 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 270
 271         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 272         (annotate_source): Make static.
 273         (annotate_source_line): Moved from source.c and renamed from
 274         identify_source_line.  Update the return type.
 275         * annotate.h (annotate_source): Delete declaration.
 276         (annotate_source_line): Declaration moved from source.h, and
 277         renamed from identify_source_line.  Return type updated.
 278         * source.c (identify_source_line): Moved to annotate.c and renamed
 279         to annotate_source_line.
 280         (info_line_command): Remove check of annotation_level.
 281         * source.h (identify_source_line): Move declaration to annotate.h
 282         and rename to annotate_source_line.
 283         * stack.c: Add 'annotate.h' include.
 284         (print_frame_info): Remove check of annotation_level before
 285         calling annotate_source_line.
 286
 287 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 288
 289         * source-cache.c (source_cache::get_plain_source_lines): Use
 290         open_source_file_with_line_charpos instead of just
 291         open_source_file, remove call to find_source_lines.
 292         (source_cache::get_source_lines): Likewise.
 293         * source.c (find_source_lines): Make static.
 294         (get_filename_and_charpos): Renamed into...
 295         (open_source_file_with_line_charpos): ..this along with changes to
 296         return a scoped_fd, and some other minor clean ups.
 297         (identify_source_line): Use open_source_file_with_line_charpos.
 298         (search_command_helper): Use open_source_file_with_line_charpos
 299         instead of just open_source_file, remove call to
 300         find_source_lines.
 301         * source.h (open_source_file_with_line_charpos): Declare new
 302         function.
 303         (find_source_lines): Delete declaration.
 304
 305 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 306
 307         * source.c (get_filename_and_charpos): Remove fullname
 308         parameter.
 309         (identify_source_line): Update call to get_filename_and_charpos.
 310
 311 2019-06-14  Tom Tromey  <tromey@adacore.com>
 312
 313         PR gdb/24502:
 314         * ui-style.h (skip_ansi_escape): Update comment.
 315         * ui-file.h (class no_terminal_escape_file): New class.
 316         * ui-file.c (no_terminal_escape_file::write)
 317         (no_terminal_escape_file::puts): New methods.
 318         * cli/cli-logging.c (handle_redirections): Use
 319         no_terminal_escape_file.
 320
 321 2019-06-14  Tom Tromey  <tromey@adacore.com>
 322
 323         * NEWS: Move convenience variable news above Python news.
 324
 325 2019-06-14  Tom Tromey  <tom@tromey.com>
 326
 327         * gnulib: Move directory to top-level.
 328         * configure.ac: Don't configure gnulib.
 329         * configure: Rebuild.
 330         * common/common-defs.h: Use new path to gnulib.
 331         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 332         (GNULIB_H): Remove.
 333         (INCGNU): Look in new gnulib location.
 334         (HFILES_NO_SRCDIR): Remove gnulib files.
 335         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 336         (generated_files): Remove GNULIB_H.
 337         ($(LIBGNU), all-lib): Remove targets.
 338         (distclean): Don't mention GNULIB_BUILDDIR.
 339         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 340
 341 2019-06-14  Tom Tromey  <tromey@adacore.com>
 342
 343         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 344         Warn if symbol file does not provide any symbols.
 345
 346 2019-06-14  Tom Tromey  <tromey@adacore.com>
 347
 348         * source.c (find_and_open_source): Respect basenames_may_differ.
 349
 350 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 351
 352         * annotate.c (annotate_breakpoints_invalid): Make use of
 353         scoped_restore_terminal_state.
 354         (annotate_frames_invalid): Likewise.
 355
 356 2019-06-14  Tom Tromey  <tromey@adacore.com>
 357
 358         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 359         allow assignment to an internalvar.
 360
 361 2019-06-14  Tom Tromey  <tromey@adacore.com>
 362
 363         * ada-lex.l: Allow "_" in attribute names.
 364
 365 2019-06-14  Tom Tromey  <tromey@adacore.com>
 366
 367         PR gdb/24653:
 368         * regcache.c (registers_changed): Don't call alloca.
 369         * top.c (execute_command): Don't call alloca.
 370
 371 2019-06-13  Pedro Alves  <palves@redhat.com>
 372
 373         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 374         'expression'.  When parsing an expression, error out if there's
 375         junk after "unlimited".
 376         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 377         (do_set_command): Adjust calls to is_unlimited_literal.
 378
 379 2019-06-13  Pedro Alves  <palves@redhat.com>
 380
 381         * compile/compile.c (make_compile_options_def_group): Add braces
 382         around array_view initializer.
 383         * thread.c (make_thread_apply_all_options_def_group)
 384         (make_thread_apply_all_options_def_group): Likewise.
 385
 386 2019-06-13  Pedro Alves  <palves@redhat.com>
 387
 388         * NEWS (New commands): Mention "maint test-options
 389         require-delimiter", "maint test-options unknown-is-error", "maint
 390         test-options unknown-is-operand" and "maint show
 391         test-options-completion-result".
 392         (New command options, command completion): New section.
 393         (Completion improvements): New section.
 394         Mention that you can abbreviate "unlimited".
 395
 396 2019-06-13  Pedro Alves  <palves@redhat.com>
 397
 398         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 399         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 400         * unittests/cli-utils-selftests.c (test_parse_flags)
 401         (test_parse_flags_qcs): Delete.
 402         (test_cli_utils): Don't call deleted functions.
 403
 404 2019-06-13  Pedro Alves  <palves@redhat.com>
 405
 406         * thread.c: Include "cli/cli-option.h".
 407         (tp_array_compar_ascending): Global.
 408         (tp_array_compar): Delete function.
 409         (tp_array_compar_ascending, tp_array_compar_descending): New
 410         functions.
 411         (ascending_option_def, qcs_flag_option_def)
 412         (thr_qcs_flags_option_defs)
 413         (make_thread_apply_all_options_def_group)
 414         (make_thread_apply_options_def_group): New.
 415         (thread_apply_all_command): Use gdb::option::process_options.
 416         (thread_apply_command_completer)
 417         (thread_apply_all_command_completer): New.
 418         (thread_apply_command): Use gdb::option::process_options.
 419         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 420         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 421         to generate help text of "thread apply".  Adjust "taas"'s help.
 422         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 423         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 424
 425 2019-06-13  Pedro Alves  <palves@redhat.com>
 426
 427         * thread.c (thread_apply_command): Check for invalid TID with
 428         isdigit instead of !isalpha.
 429
 430 2019-06-13  Pedro Alves  <palves@redhat.com>
 431
 432         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 433         (validate_flags_qcs): New.
 434         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 435         (validate_flags_qcs): Declare.
 436         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 437         (make_frame_apply_options_def_group): New.
 438         (frame_apply_command_count): Process options with
 439         gdb::option::process_options.
 440         (frame_apply_completer): New.
 441         (frame_apply_level_completer, frame_apply_all_completer)
 442         (frame_apply_completer): New.
 443         (_initialize_stack): Update help of "frame apply", "frame apply
 444         level", "frame apply all" and "faas" to mention supported options
 445         and install command completers.
 446         * stack.h (frame_apply_all_completer): Declare.
 447         * thread.c: Include "stack.h".
 448         (tfaas_command): Add "--".
 449         (_initialize_thread): Update help "tfaas" to mention supported
 450         options and install command completer.
 451
 452 2019-06-13  Pedro Alves  <palves@redhat.com>
 453
 454         * completer.c (complete_nested_command_line): New.
 455         (gdb_completion_word_break_characters_throw): Add assertion.
 456         * completer.h (complete_nested_command_line): Declare.
 457
 458 2019-06-13  Pedro Alves  <palves@redhat.com>
 459
 460         * stack.c (parse_backtrace_qualifiers): New.
 461         (backtrace_command): Use it.
 462         (backtrace_command_completer): Complete on qualifiers.
 463
 464 2019-06-13  Pedro Alves  <palves@redhat.com>
 465
 466         * frame.c: Include "cli/cli-option.h.
 467         (user_set_backtrace_options): New.
 468         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 469         Delete.
 470         (get_prev_frame): Adjust.
 471         (boolean_option_def, uinteger_option_def)
 472         (set_backtrace_option_defs): New.
 473         (_initialize_frame): Adjust and use
 474         gdb::option::add_setshow_cmds_for_options to install "set
 475         backtrace past-main" and "set backtrace past-entry".
 476         * frame.h: Include "cli/cli-option.h".
 477         (struct frame_print_options): Forward declare.
 478         (print_frame_arguments_all, print_frame_arguments_scalars)
 479         (print_frame_arguments_none): Declare.
 480         (print_entry_values): Delete declaration.
 481         (struct frame_print_options, user_frame_print_options): New.
 482         (struct set_backtrace_options): New.
 483         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 484         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 485         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 486         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 487         (list_args_or_locals): Add frame_print_options parameter.
 488         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 489         * python/py-framefilter.c (enumerate_args): Pass down
 490         USER_FRAME_PRINT_OPTIONS.
 491         * stack.c: Include "cli/cli-option.h".
 492         (print_frame_arguments_all, print_frame_arguments_scalars)
 493         (print_frame_arguments_none): Declare.
 494         (print_raw_frame_arguments, print_entry_values): Delete.
 495         (user_frame_print_options): New.
 496         (boolean_option_def, enum_option_def, frame_print_option_defs):
 497         New.
 498         (struct backtrace_cmd_options): New.
 499         (bt_flag_option_def): New.
 500         (backtrace_command_option_defs): New.
 501         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 502         (print_frame_arg, read_frame_arg, print_frame_args)
 503         (print_frame_info, print_frame): Add frame_print_options parameter
 504         and use it.
 505         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 506         (backtrace_command_1): Add frame_print_options and
 507         backtrace_cmd_options parameters and use them.
 508         (make_backtrace_options_def_group): New.
 509         (backtrace_command): Process command options with
 510         gdb::option::process_options.
 511         (backtrace_command_completer): New.
 512         (_initialize_stack): Extend "backtrace"'s help to mention
 513         supported options.  Install completer for "backtrace".
 514         Install some settings commands with add_setshow_cmds_for_options.
 515
 516 2019-06-13  Pedro Alves  <palves@redhat.com>
 517
 518         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 519         and that "set/show print raw frame-arguments" are now deprecated.
 520
 521         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 522         command.
 523         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 524         * stack.c (_initialize_stack): Install "set/show print
 525         raw-frame-arguments", and deprecate "set/show print raw
 526         frame-arguments".
 527         * valprint.c (_initialize_valprint): Deprecate "set/show print
 528         raw".
 529
 530 2019-06-13  Pedro Alves  <palves@redhat.com>
 531
 532         * compile/compile.c (struct compile_options): New.
 533         (compile_flag_option_def, compile_command_option_defs)
 534         (make_compile_options_def_group): New.
 535         (compile_file_command): Handle options with
 536         gdb::option::process_options.
 537         (compile_file_command_completer): New function.
 538         (compile_code_command): Handle options with
 539         gdb::option::process_options.
 540         (compile_code_command_completer): New function.
 541         (_initialize_compiler): Install completers for "compile code" and
 542         "compile file".  Mention available options in "compile code" and
 543         "compile code"'s help.
 544         * completer.c (advance_to_completion_word): New, factored out from
 545         ...
 546         (advance_to_expression_complete_word_point): ... this.
 547         (advance_to_filename_complete_word_point): New.
 548         * completer.h (advance_to_filename_complete_word_point): New
 549         declaration.
 550
 551 2019-06-13  Pedro Alves  <palves@redhat.com>
 552
 553         * compile/compile.c: Include "cli/cli-option.h".
 554         (compile_print_value): Scope data pointer is now a
 555         value_print_options pointer; adjust.
 556         (compile_print_command): Process options.  Scope data pointer is
 557         now a value_print_options pointer; adjust.
 558         (_initialize_compile): Update "compile print"'s help to include
 559         supported options.  Install a completer for "compile print".
 560         * cp-valprint.c (show_vtblprint, show_objectprint)
 561         (show_static_field_print): Delete.
 562         (_initialize_cp_valprint): Don't install "set print
 563         static-members", "set print vtbl", "set print object" here.
 564         * printcmd.c: Include "cli/cli-option.h" and
 565         "common/gdb_optional.h".
 566         (print_command_parse_format): Rework to fill in a
 567         value_print_options instead of a format_data.
 568         (print_value): Change parameter type from format_data pointer to
 569         value_print_options reference.  Adjust.
 570         (print_command_1): Process options.  Adjust to pass down a
 571         value_print_options.
 572         (print_command_completer): New.
 573         (_initialize_printcmd): Install print_command_completer as
 574         handle_brkchars completer for the "print" command.  Update
 575         "print"'s help to include supported options.
 576         * valprint.c: Include "cli/cli-option.h".
 577         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 578         here from cp-valprint.c.
 579         (boolean_option_def, uinteger_option_def)
 580         (value_print_option_defs, make_value_print_options_def_group):
 581         New.  Use gdb::option::add_setshow_cmds_for_options to install
 582         "set print elements", "set print null-stop", "set print repeats",
 583         "set print pretty", "set print union", "set print array", "set
 584         print address", "set print symbol", "set print array-indexes".
 585         * valprint.h: Include <string> and "cli/cli-option.h".
 586         (make_value_print_options_def_group): Declare.
 587         (print_value): Change parameter type from format_data pointer to
 588         value_print_options reference.
 589         (print_command_completer): Declare.
 590
 591 2019-06-13  Pedro Alves  <palves@redhat.com>
 592
 593         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 594         (COMMON_SFILES): Add maint-test-settings.c.
 595         * cli/cli-decode.c (boolean_enums): New global, factored out from
 596         ...
 597         (add_setshow_boolean_cmd): ... here.
 598         * cli/cli-decode.h (boolean_enums): Declare.
 599         * cli/cli-option.c: New file.
 600         * cli/cli-option.h: New file.
 601         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 602         factored out from ...
 603         (parse_cli_boolean_value(const char *)): ... this.
 604         (is_unlimited_literal): Change parameter type to pointer to
 605         pointer.  Adjust and advance ARG pointer.
 606         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 607         (parse_cli_var_enum): New, factored out from ...
 608         (do_set_command): ... this.  Adjust.
 609         * cli/cli-setshow.h (parse_cli_boolean_value)
 610         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 611         (parse_cli_var_enum): Declare.
 612         * cli/cli-utils.c: Include "cli/cli-option.h".
 613         (get_ulongest): New.
 614         * cli/cli-utils.h (get_ulongest): Declare.
 615         (check_for_argument): New overloads.
 616         * maint-test-options.c: New file.
 617
 618 2019-06-13  Pedro Alves  <palves@redhat.com>
 619
 620         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 621         parse a range if "-" is at the end of the string.
 622
 623 2019-06-13  Pedro Alves  <palves@redhat.com>
 624
 625         * cli/cli-setshow.c (parse_auto_binary_operation)
 626         (parse_cli_boolean_value): Don't allow "o".
 627
 628 2019-06-13  Pedro Alves  <palves@redhat.com>
 629
 630         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 631         * NEWS: Mention maint test-settings KIND.
 632         * maint-test-settings.c: New file.
 633
 634 2019-06-13  Pedro Alves  <palves@redhat.com>
 635
 636         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 637         completer.
 638         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 639         "set" completers.
 640
 641 2019-06-13  Pedro Alves  <palves@redhat.com>
 642
 643         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 644         after item.
 645
 646 2019-06-13  Pedro Alves  <palves@redhat.com>
 647
 648         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 649
 650 2019-06-13  Pedro Alves <palves@redhat.com>
 651
 652         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 653         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 654         call.
 655         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 656         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 657         calls.
 658         (check_for_argument): Skip spaces after argument.
 659
 660 2019-06-13  Pedro Alves  <palves@redhat.com>
 661
 662         * thread.c (thread_apply_command): Adjust TID parsing.
 663         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 664         detected before end of string.
 665         (tid_is_in_list): Error out if LIST is invalid.
 666
 667 2019-06-13  Pedro Alves  <palves@redhat.com>
 668
 669         * completer.c (complete_line_internal_1): Rewind completion word
 670         point.
 671         (completion_tracker::advance_custom_word_point_by): Change
 672         parameter type to int.
 673         * completer.h (completion_tracker::advance_custom_word_point_by):
 674         Likewise.
 675
 676 2019-06-13  Pedro Alves  <palves@redhat.com>
 677
 678         * completer.c (advance_to_completion_word): Handle delimiters.
 679
 680 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 681
 682         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 683
 684 2019-06-11  Tom Tromey  <tom@tromey.com>
 685
 686         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 687         (xmalloc_failed): Move to alloc.c.
 688         * alloc.c: New file.
 689         * Makefile.in (COMMON_SFILES): Add alloc.c.
 690
 691 2019-06-11  Tom Tromey  <tom@tromey.com>
 692
 693         * nat/linux-waitpid.c: Don't include server.h.
 694         (linux_debug): Remove.
 695         (my_waitpid): Update.
 696
 697 2019-06-11  Tom Tromey  <tromey@adacore.com>
 698
 699         * infcall.c (_initialize_infcall): Remove trailing newline from
 700         help.
 701         * user-regs.c (_initialize_user_regs): Remove trailing newline
 702         from help.
 703         * typeprint.c (_initialize_typeprint): Remove trailing newline
 704         from help.
 705         * reverse.c (_initialize_reverse): Remove trailing newlines from
 706         help.
 707         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 708         from help.
 709         * language.c (add_set_language_command): Remove trailing newline
 710         from help.
 711         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 712         help.
 713         * disasm.c (_initialize_disasm): Remove trailing newline from
 714         help.
 715         * top.c (init_main): Remove trailing newline from help.
 716         * interps.c (_initialize_interpreter): Remove trailing newline
 717         from help.
 718         * btrace.c (_initialize_btrace): Remove trailing newlines from
 719         help.
 720         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 721         from help.
 722         * python/python.c (_initialize_python): Remove trailing newline
 723         from help.
 724         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 725         help.
 726         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 727         from help.  Reformat some text.
 728         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 729         from help.
 730         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 731         newline from help.
 732
 733 2019-06-11  Tom Tromey  <tromey@adacore.com>
 734
 735         * darwin-nat.c (darwin_decode_exception_message)
 736         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 737
 738 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * valops.c (value_slice): Check for not allocated or not
 741         associated values.
 742
 743 2019-06-10  Tom de Vries  <tdevries@suse.de>
 744
 745         PR gdb/24618
 746         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 747         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 748         invalid.
 749
 750 2019-06-10  Tom de Vries  <tdevries@suse.de>
 751
 752         PR gdb/24611
 753         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 754         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 755
 756 2019-06-10  Tom de Vries  <tdevries@suse.de>
 757
 758         PR symtab/24545
 759         * symtab.c (struct demangled_name_entry): Add language field.
 760         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 761         static minimal symbol".  Set and use language field.
 762
 763 2019-06-10  Tom Tromey  <tromey@adacore.com>
 764
 765         * ada-lang.c (_initialize_ada_language): Update help text.
 766
 767 2019-06-10  Tom Tromey  <tromey@adacore.com>
 768
 769         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 770         with a newline.
 771         * guile/guile.c (handle_boot_error): Don't end warning with a
 772         newline.
 773         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 774         warning with a newline.
 775         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 776         newline.
 777         (s12z_frame_cache): Likewise.
 778         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 779         a newline.
 780         * solib-svr4.c (disable_probes_interface): Don't end warning with
 781         a newline.
 782         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 783         newline.
 784         * python/python.c (do_finish_initialization): Don't end warning
 785         with a newline.
 786
 787 2019-06-10  Tom Tromey  <tom@tromey.com>
 788
 789         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 790         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 791         gdbpy_enter.
 792
 793 2019-06-10  Tom Tromey  <tromey@adacore.com>
 794
 795         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 796         data.
 797         (elf_new_init): Don't call stabsread_new_init.
 798         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 799         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 800         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 801
 802 2019-06-10  Tom de Vries  <tdevries@suse.de>
 803
 804         PR symtab/16264
 805         PR symtab/24517
 806         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 807
 808 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 809
 810         * source.c (find_and_open_source): Also rewrite relative file
 811         names.
 812
 813 2019-04-26  Amos Bird  <amosbird@gmail.com>
 814
 815         * annotate.c (annotate_thread_exited): Add "thread-exited"
 816         annotation.
 817
 818 2019-06-06  Tom Tromey  <tromey@adacore.com>
 819
 820         * maint.h (class scoped_command_stats): Use
 821         DISABLE_COPY_AND_ASSIGN.
 822         <print_time>: New method.
 823         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 824         print_time.
 825         (scoped_command_stats::print_time): New method.
 826
 827 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 830         instructions of lengths 6 or 8 bytes.
 831
 832 2019-06-04  Pedro Alves  <palves@redhat.com>
 833
 834         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 835
 836         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 837         * breakpoint.c (condition_completer): Likewise.
 838         * cli/cli-dump.c (scan_expression): Likewise.
 839         * common/filestuff.c (mkdir_recursive): Likewise.
 840         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 841         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 842         (gdb_abspath): Likewise.
 843         * compile/compile-cplus-types.c
 844         (compile_cplus_instance::decl_name): Likewise.
 845         * completer.c (complete_explicit_location):
 846         (signal_completer, reg_or_group_completer_1): Likewise.
 847         * cp-support.c (cp_remove_params_if_any): Likewise.
 848         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 849         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 850         * infcmd.c (strip_bg_char): Likewise.
 851         * linespec.c (copy_token_string): Likewise.
 852         * mi/mi-main.c (output_cores): Likewise.
 853         * psymtab.c (psymtab_search_name):
 854         * symfile.c (test_set_ext_lang_command): Likewise.
 855         * target.c (target_fileio_read_stralloc): Likewise.
 856         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 857         * value.c (complete_internalvar): Likewise.
 858
 859 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 860
 861         Add objfile property to gdb.Type.
 862         * NEWS: Mention Python API addition.
 863         * python/py-type.c (typy_get_objfile): New method.
 864
 865 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 866
 867         * NEWS: Mention the new set|show style [title|highlight].
 868         Mention changes to "show style", "help" and "apropos".
 869
 870 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 871
 872         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 873         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 874         instead of print_help_for_command.
 875         (print_doc_of_command): New function.
 876         (help_list): Add 'apropos -v word' suggestion.
 877         (print_help_for_command): Style the command name using title style.
 878         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 879         (_initialize_cli_cmds): Describe -v in apropos_command help.
 880
 881 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 882
 883         * cli/cli-style.h (cli_style_option): Add name in constructor,
 884         add m_name class member, add constructor with intensity,
 885         add name class function.
 886         (cli_style_option::add_setshow_commands): Remove name argument.
 887         (highlight_style, title_style): New styles.
 888         * cli/cli-style.c (do_show): New function that shows a style
 889         characteristic styling the style name with itself.
 890         (set_style_name): New function.
 891         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 892         Update all callers according to the changes in cli/cli-style.h.
 893         * utils.h (fputs_highlighted): New function.
 894         * utils.c (fputs_highlighted): Likewise.
 895
 896 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 897
 898         * NEWS: Mention new pipe command and new convenience variables.
 899
 900 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 901
 902         * cli/cli-cmds.c (pipe_command): New function.
 903         (_initialize_cli_cmds): Call add_com for pipe_command.
 904         Define | as an alias for pipe.
 905         (exit_status_set_internal_vars): New function.
 906         (shell_escape): Call exit_status_set_internal_vars.
 907         cli/cli-decode.c (find_command_name_length): Recognize | as
 908         a single character command.
 909
 910 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 911
 912         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 913         top.c (execute_command_to_ui_file): New function, mostly a copy
 914         of execute_command_to_string.
 915         (execute_command_to_string): Implement by calling
 916         execute_command_to_ui_file.
 917
 918 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 919
 920         * top.h (saved_command_line): Remove declaration.
 921         * top.c (previous_saved_command_line, previous_repeat_arguments):
 922         New variables.
 923         (saved_command_line): Make static, define together with other
 924         'repeat variables'.
 925         (dont_repeat): Clear repeat_arguments.
 926         (repeat_previous, get_saved_command_line, save_command_line):
 927         New functions.
 928         (gdb_init): Initialize saved_command_line
 929         and previous_saved_command_line.
 930         * main.c (captured_main_1): Remove saved_command_line initialization.
 931         * event-top.c (handle_line_of_input): Update to use
 932         the new 'repeat' related functions instead of direct access to
 933         saved_command_line.
 934         * command.h (repeat_previous, get_saved_command_line,
 935         save_command_line): New declarations.
 936         (dont_repeat): Add comment.
 937
 938 2019-05-30  Tom Tromey  <tromey@adacore.com>
 939
 940         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 941         Fix comment.
 942         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 943
 944 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 945
 946         PR cli/24587
 947         * completer.c (complete): Initialize variable word.
 948
 949 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 950
 951         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 952         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 953         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 954         'body' is NULL to the outter 'if', protecting the '!is_define'
 955         situation as well.
 956
 957 2019-05-29  Tom Tromey  <tromey@adacore.com>
 958
 959         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 960         (dwarf_unknown): New function.
 961         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 962         (dwarf_type_encoding_name): Use dwarf_unknown.
 963
 964 2019-05-29  Tom Tromey  <tromey@adacore.com>
 965
 966         PR c++/20020:
 967         * cp-valprint.c (cp_print_value_fields): Call
 968         cp_print_static_field inside "try".
 969
 970 2019-05-29  Tom Tromey  <tromey@adacore.com>
 971
 972         * inflow.c (struct terminal_info): Add default operator=.
 973         * configure: Rebuild.
 974         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 975         -Wdeprecated-copy-dtor, -Wredundant-move.
 976
 977 2019-05-29  Tom Tromey  <tromey@adacore.com>
 978
 979         * NEWS: Add entry.
 980         * infcmd.c (print_return_value_1): Handle finish_print
 981         option.
 982         (show_print_finish): New function.
 983         (_initialize_infcmd): Add "set/show print finish" commands.
 984         * valprint.c (user_print_options): Initialize new member.
 985         * valprint.h (struct value_print_options) <finish_print>: New
 986         member.
 987
 988 2019-05-28  Tom Tromey  <tromey@adacore.com>
 989
 990         * ada-lang.c (ada_remove_Xbn_suffix)
 991         (find_old_style_renaming_symbol)
 992         (parse_old_style_renaming): Remove.
 993         (ada_find_renaming_symbol): Don't call
 994         find_old_style_renaming_symbol.
 995         (ada_is_renaming_symbol): Rename from
 996         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 997         bool.  Now static.
 998         (ada_read_var_value): Update and simplify.
 999         * ada-exp.y (write_var_or_type): Remove old code.
1000
1001 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1002
1003         * event-top.c: Remove include comment.
1004         * inflow.c (class scoped_ignore_sigttou): Move from here...
1005         * inflow.h (class scoped_ignore_sigttou): ...to here.
1006         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1007         * top.c:  Remove include comment.
1008
1009 2019-05-27  Tom Tromey  <tom@tromey.com>
1010
1011         * NEWS: Fix typo.
1012
1013 2019-05-22  Tom Tromey  <tromey@adacore.com>
1014
1015         * target.c (target_follow_exec): Constify parameter.
1016         * target-delegates.c: Rebuild.
1017         * remote.c (remote_target::follow_exec): Constify parameter.
1018         * infrun.c (follow_exec): Constify parameter.
1019         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1020         (target_follow_exec): Likewise.
1021
1022 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1023
1024         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1025         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1026
1027 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1028
1029         * NEWS: Add debugredirect and testsuite sections.
1030
1031 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1032
1033         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1034         target descriptions using exclusively floating point register name
1035         aliases.
1036
1037 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         PR gdb/18644:
1040         * f-lang.c (build_fortran_types): Handle the case where
1041         gdbarch_floatformat_for_type returns a nullptr.
1042
1043 2019-05-21  Tom de Vries  <tdevries@suse.de>
1044
1045         PR cli/24587
1046         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1047
1048 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         PR gdb/18644:
1051         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1052         16-byte floats.
1053         * i386-tdep.c (i386_floatformat_for_type): Use
1054         floatformats_ia64_quad for the 16-byte floating point component
1055         within a fortran 32-byte complex number.
1056
1057 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1058
1059         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1060         delete default constructor.
1061         (find_partial_die): Update to return const struct.
1062         (partial_die_parent_scope): Move variable declaration into scope
1063         of its use and change its type to auto.
1064         (guess_partial_die_structure_name): Likewise.
1065         (partial_die_info::fixup): Likewise.
1066
1067 2019-05-17  Tom Tromey  <tromey@adacore.com>
1068
1069         * source.c (find_and_open_source): Remove cast.
1070
1071 2019-05-17  Tom Tromey  <tromey@adacore.com>
1072
1073         * annotate.c (annotate_source): Make "filename" const.
1074         * annotate.h (annotate_source): Use const.
1075
1076 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1077
1078         * disasm.c (set_disassembler_options): Send errors to stderr.
1079
1080 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1081
1082         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1083         (cli_interp_base::set_logging): Check debug_redirect.
1084         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1085         * cli/cli-logging.c (debug_redirect): Add static variable.
1086         (pop_output_files): Add default param.
1087         (handle_redirections): Print debug setting.
1088         (show_logging_command): Likewise.
1089         (_initialize_cli_logging): Add debugredirect command.
1090         * interps.c (current_interp_set_logging): Add debug_redirect
1091         parameter.
1092         * interps.h (set_logging): Add debug_redirect parameter.
1093         (current_interp_set_logging): Likewise.
1094         * mi/mi-common.h: Likewise.
1095         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1096
1097 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1098             Tom Tromey  <tromey@adacore.com>
1099
1100         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1101         directly.
1102         * cli/cli-interp.h (make_logging_output): Remove declaration.
1103         * cli/cli-logging.c (make_logging_output): Remove function.
1104         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1105         directly.
1106         * ui-file.c (tee_file::tee_file): Remove bools.
1107         (tee_file::~tee_file): Remove deletes.
1108         * ui-file.h (tee_file): Remove bools.
1109
1110 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1111
1112         * mi/mi-cmds.h (mi_cmd_complete): New function.
1113         * mi/mi-main.c (mi_cmd_complete): Likewise.
1114         * mi/mi-cmds.c: Define new MI command -complete.
1115         * NEWS: Mention new -complete command.
1116
1117 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1118
1119         * completer.h (complete): New function.
1120         * completer.c (complete): Likewise.
1121         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1122         function defined in completer.h.
1123
1124 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1125
1126         * MAINTAINERS (Write After Approval): Add myself.
1127
1128 2019-05-17  Tom de Vries  <tdevries@suse.de>
1129
1130         PR gdb/24094
1131         * dwarf2read.c (struct cu_partial_die_info): New struct.
1132         (find_partial_die): Return cu_partial_die_info.
1133         (partial_die_parent_scope, guess_partial_die_structure_name)
1134         (partial_die_info::fixup): Handle new return type of find_partial_die.
1135
1136 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1137
1138         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1139         "std::string", simplifying the algorithm.
1140
1141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1142
1143         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1144         (stap_static_probe_ops::get_probes): Likewise.
1145
1146 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1147
1148         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1149         '-')" and "else if".
1150         (stap_parse_single_operand): Join checks for
1151         "gdbarch_stap_parse_special_token_p" and
1152         "gdbarch_stap_parse_special_token" in the same "if" statement.
1153         Invert check when verifying for operation on register
1154         displacement.
1155
1156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1157
1158         * stap-probe.c (stap_get_opcode): Update comment.
1159         (stap_get_expected_argument_type): Likewise.
1160         (handle_stap_probe): Likewise.
1161
1162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1163
1164         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1165         return type to 'bool'.  Adjust comment.  Use 'bool' when
1166         appropriate.
1167         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1168         * stap-probe.c (stap_parse_argument_1): Likewise.
1169         (stap_is_operator): Likewise.
1170         (stap_is_generic_prefix): Likewise.
1171         (stap_is_register_prefix): Likewise.
1172         (stap_is_register_indirection_prefix): Likewise.
1173         (stap_is_integer_prefix): Likewise.
1174         (stap_generic_check_suffix): Likewise.
1175         (stap_check_integer_suffix): Likewise.
1176         (stap_check_register_suffix): Likewise.
1177         (stap_check_register_indirection_suffix): Likewise.
1178         (stap_parse_register_operand): Likewise.
1179         (stap_parse_single_operand): Likewise.
1180         (stap_parse_argument_1): Likewise.
1181         (stap_probe::get_argument_count): Likewise.
1182         (stap_is_operator): Likewise.
1183
1184 2019-05-16  Tom Tromey  <tromey@adacore.com>
1185
1186         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1187         keyword to foreach.
1188
1189 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1190
1191         * linux-thread-db.c (try_thread_db_load_1): Change return type
1192         to bool.
1193         (try_thread_db_load): Likewise.
1194         (try_thread_db_load_from_pdir_1): Likewise.
1195         (try_thread_db_load_from_pdir): Likewise.
1196         (try_thread_db_load_from_sdir): Likewise.
1197         (try_thread_db_load_from_dir): Likewise.
1198         (thread_db_load_search): Likewise.
1199         (has_libpthread): Likewise.
1200         (thread_db_load): Likewise.
1201
1202 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1203
1204         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1205         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1206         NULL, and complain/return if that's the case.
1207
1208 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1209
1210         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1211         (advance, posn, abstract_read_memory): New functions.
1212         [struct mem_read_abstraction]: New struct.
1213         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1214
1215 2019-05-14  Tom Tromey  <tromey@adacore.com>
1216
1217         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1218         value is not lval_memory.
1219
1220 2019-05-14  Tom Tromey  <tromey@adacore.com>
1221
1222         * solib.c (info_sharedlibrary_command): Style the file name.
1223
1224 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1225
1226         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1227         (aarch64_vnv_type): Likewise.
1228         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1229         * common/tdesc.c: Likewise.
1230         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1231         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1232         * features/aarch64-fpu.xml: Add ieee half view.
1233         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1234         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1235         * gdbtypes.h (struct builtin_type): Likewise.
1236         (struct objfile_type): Likewise.
1237
1238 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1239
1240         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1241         typo.
1242         * location.h (string_to_event_location): Likewise.
1243
1244 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1245
1246         GDB 8.3 released.
1247
1248 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1249
1250         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1251         New variable declaration.
1252         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1253         New variable.
1254         (print_one_breakpoint): Use ui_out::test_flags and new global
1255         variable to compute use_fixed_output.
1256         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1257         Remove.
1258         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1259         (mi_multi_location_breakpoint_output_fixed): Remove.
1260         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1261         new variable.
1262         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1263         fix_multi_location_breakpoint_output flag if version >= 3.
1264         * ui-out.h (enum ui_out_flag)
1265         <fix_multi_location_breakpoint_output>: New enumerator.
1266
1267 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1268
1269         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1270
1271 2019-05-10  Tom Tromey  <tromey@adacore.com>
1272
1273         * ada-lang.c (catch_ada_completer): New function.
1274         (_initialize_ada_language): Use it.
1275
1276 2019-05-10  Tom Tromey  <tromey@adacore.com>
1277
1278         * thread.c (print_thread_info): Make "requested_threads" const.
1279         * gdbthread.h (print_thread_info): Make "requested_threads"
1280         const.
1281         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1282         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1283
1284 2019-05-08  Tom Tromey  <tom@tromey.com>
1285
1286         * gdbtypes.c (objfile_type_data): Change type.
1287         (objfile_type, _initialize_gdbtypes): Update.
1288
1289 2019-05-08  Tom Tromey  <tom@tromey.com>
1290
1291         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1292         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1293         (_initialize_dwarf2_frame): Update.
1294
1295 2019-05-08  Tom Tromey  <tom@tromey.com>
1296
1297         * objc-lang.c (objc_objfile_data): Change type.
1298         (find_methods): Update.
1299         (_initialize_objc_lang): Remove.
1300
1301 2019-05-08  Tom Tromey  <tom@tromey.com>
1302
1303         * stabsread.c (rs6000_builtin_type_data): Change type.
1304         (rs6000_builtin_type, _initialize_stabsread): Update.
1305
1306 2019-05-08  Tom Tromey  <tom@tromey.com>
1307
1308         * mips-tdep.c (mips_pdr_data): Remove.
1309         (_initialize_mips_tdep): Update.
1310
1311 2019-05-08  Tom Tromey  <tom@tromey.com>
1312
1313         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1314         (hppa_init_objfile_priv_data, read_unwind_info)
1315         (find_unwind_entry, _initialize_hppa_tdep): Update.
1316
1317 2019-05-08  Tom Tromey  <tom@tromey.com>
1318
1319         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1320         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1321         on obstack.
1322         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1323
1324 2019-05-08  Tom Tromey  <tom@tromey.com>
1325
1326         * mdebugread.c (basic_type_data): Change type.
1327         (basic_type, _initialize_mdebugread): Update.
1328
1329 2019-05-08  Tom Tromey  <tom@tromey.com>
1330
1331         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1332
1333 2019-05-08  Tom Tromey  <tom@tromey.com>
1334
1335         * nto-tdep.c (nto_inferior_data_reg): Change type.
1336         (nto_inferior_data): Update.
1337         (nto_inferior_data_cleanup, nto_new_inferior_data)
1338         (_initialize_nto_tdep): Remove.
1339         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1340
1341 2019-05-08  Tom Tromey  <tom@tromey.com>
1342
1343         * ada-lang.c (struct ada_inferior_data): Add initializers.
1344         (ada_inferior_data): Change type.
1345         (ada_inferior_data_cleanup): Remove.
1346         (get_ada_inferior_data, ada_inferior_exit)
1347         (struct ada_pspace_data): Add initializers, destructor.
1348         (ada_pspace_data_handle): Change type.
1349         (get_ada_pspace_data): Update.
1350         (ada_pspace_data_cleanup): Remove.
1351
1352 2019-05-08  Tom Tromey  <tom@tromey.com>
1353
1354         * coffread.c (struct coff_symfile_info): Add initializers.
1355         (coff_objfile_data_key): Move lower.  Change type.
1356         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1357         Update.
1358         (coff_free_info): Remove.
1359
1360 2019-05-08  Tom Tromey  <tom@tromey.com>
1361
1362         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1363         (fbsd_pspace_data_handle): Move lower.  Change type.
1364         (get_fbsd_pspace_data): Update.
1365         (fbsd_pspace_data_cleanup): Remove.
1366         (_initialize_fbsd_tdep): Update.
1367
1368 2019-05-08  Tom Tromey  <tom@tromey.com>
1369
1370         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1371         (get_ada_tasks_pspace_data): Update.
1372         (ada_tasks_pspace_data_cleanup): Remove.
1373         (_initialize_tasks): Update.
1374         (ada_tasks_inferior_data_handle): Change type.
1375         (get_ada_tasks_inferior_data): Update.
1376         (ada_tasks_inferior_data_cleanup): Remove.
1377         (struct ada_tasks_pspace_data): Add initializers.
1378
1379 2019-05-08  Tom Tromey  <tom@tromey.com>
1380
1381         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1382         * symfile-debug.c (debug_sym_get_probes): Change type.
1383         * stap-probe.c (handle_stap_probe):
1384         (stap_static_probe_ops::get_probes): Change type.
1385         * probe.h (class static_probe_ops) <get_probes>: Change type.
1386         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1387         (parse_probes_in_pspace): Update.
1388         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1389         Update.
1390         (any_static_probe_ops::get_probes): Change type.
1391         * elfread.c (elfread_data): New typedef.
1392         (probe_key): Change type.
1393         (elf_get_probes): Likewise.  Update.
1394         (probe_key_free): Remove.
1395         (_initialize_elfread): Update.
1396         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1397         Change type.
1398         (dtrace_process_dof_probe, dtrace_process_dof)
1399         (dtrace_static_probe_ops::get_probe): Change type.
1400
1401 2019-05-08  Tom Tromey  <tom@tromey.com>
1402
1403         * xcoffread.c (struct xcoff_symfile_info): Rename from
1404         coff_symfile_info.  Add initializers.
1405         (xcoff_objfile_data_key): Move lower.  Change type.
1406         (XCOFF_DATA): Rewrite.
1407         (xcoff_free_info): Remove.
1408         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1409         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1410         (xcoff_initial_scan): Update.
1411
1412 2019-05-08  Tom Tromey  <tom@tromey.com>
1413
1414         * solib-svr4.c (struct svr4_info): Add initializers and
1415         destructor.
1416         <probes_table>: Now an htab_up.
1417         (solib_svr4_pspace_data): Change type.
1418         (free_probes_table): Simplify.
1419         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1420         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1421         (probes_table_remove_objfile_probes, register_solib_event_probe)
1422         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1423         (_initialize_svr4_solib): Update.
1424
1425 2019-05-08  Tom Tromey  <tom@tromey.com>
1426
1427         * remote.c (remote_pspace_data): Change type.
1428         (remote_pspace_data_cleanup): Remove.
1429         (get_remote_exec_file, set_pspace_remote_exec_file)
1430         (_initialize_remote): Update.
1431
1432 2019-05-08  Tom Tromey  <tom@tromey.com>
1433
1434         * breakpoint.c (breakpoint_objfile_key): Change type.
1435         (get_breakpoint_objfile_data): Update.
1436         (free_breakpoint_objfile_data): Remove.
1437         (_initialize_breakpoint): Update.
1438
1439 2019-05-08  Tom Tromey  <tom@tromey.com>
1440
1441         * linux-tdep.c (struct linux_info): Add initializers.
1442         (linux_inferior_data): Move.  Change type.
1443         (invalidate_linux_cache_inf): Update.
1444         (linux_inferior_data_cleanup): Remove.
1445         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1446
1447 2019-05-08  Tom Tromey  <tom@tromey.com>
1448
1449         * auxv.c (auxv_inferior_data): Move.  Change type.
1450         (auxv_inferior_data_cleanup): Remove.
1451         (invalidate_auxv_cache_inf): Rewrite.
1452         (get_auxv_inferior_data, _initialize_auxv): Update.
1453
1454 2019-05-08  Tom Tromey  <tom@tromey.com>
1455
1456         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1457         (symfile_debug_objfile_data_key): Change type.
1458         (symfile_debug_installed, debug_qf_has_symbols)
1459         (debug_qf_find_last_source_symtab)
1460         (debug_qf_forget_cached_source_info)
1461         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1462         (debug_qf_print_stats, debug_qf_dump)
1463         (debug_qf_expand_symtabs_for_function)
1464         (debug_qf_expand_all_symtabs)
1465         (debug_qf_expand_symtabs_with_fullname)
1466         (debug_qf_map_matching_symbols)
1467         (debug_qf_expand_symtabs_matching)
1468         (debug_qf_find_pc_sect_compunit_symtab)
1469         (debug_qf_map_symbol_filenames)
1470         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1471         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1472         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1473         (debug_sym_read_linetable, debug_sym_relocate): Update.
1474         (symfile_debug_free_objfile): Remove.
1475         (install_symfile_debug_logging, _initialize_symfile_debug):
1476         Update.
1477
1478 2019-05-08  Tom Tromey  <tom@tromey.com>
1479
1480         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1481         allocate_on_obstack.
1482         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1483         (get_dwarf2_per_objfile): Update.
1484         (set_dwarf2_per_objfile): Remove.
1485         (dwarf2_has_info, dwarf2_get_section_info): Update.
1486         (dwarf2_free_objfile): Remove.
1487         (_initialize_dwarf2_read): Update.
1488
1489 2019-05-08  Tom Tromey  <tom@tromey.com>
1490
1491         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1492         initializers.
1493         <unsupported_script_warning_printed,
1494         script_not_found_warning_printed>: Now bool.
1495         (auto_load_pspace_data): Change type.
1496         (~auto_load_pspace_info): Rename from
1497         auto_load_pspace_data_cleanup.
1498         (get_auto_load_pspace_data, init_loaded_scripts_info)
1499         (clear_section_scripts, maybe_print_unsupported_script_warning)
1500         (maybe_print_script_not_found_warning, _initialize_auto_load):
1501         Update.
1502
1503 2019-05-08  Tom Tromey  <tom@tromey.com>
1504
1505         * objfiles.c (objfile_pspace_info): Add destructor and
1506         initializers.
1507         (objfiles_pspace_data): Change type.
1508         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1509         (get_objfile_pspace_data): Update.
1510         (objfiles_bfd_data): Change type.
1511         (get_objfile_bfd_data): Update.
1512         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1513
1514 2019-05-08  Tom Tromey  <tom@tromey.com>
1515
1516         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1517         Change type.
1518         (get_catch_syscall_inferior_data): Update.
1519         (catch_syscall_inferior_data_cleanup): Remove.
1520         (_initialize_break_catch_syscall): Update.
1521
1522 2019-05-08  Tom Tromey  <tom@tromey.com>
1523
1524         * inflow.c (struct terminal_info): Add destructor and
1525         initializers.
1526         (inflow_inferior_data): Change type.
1527         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1528         (get_inflow_inferior_data, inflow_inferior_exit)
1529         (swap_terminal_info, _initialize_inflow): Update.
1530
1531 2019-05-08  Tom Tromey  <tom@tromey.com>
1532
1533         * target-dcache.c (target_dcache_cleanup): Remove.
1534         (target_dcache_aspace_key): Change type.
1535         (target_dcache_init_p, target_dcache_invalidate)
1536         (target_dcache_get, target_dcache_get_or_init)
1537         (_initialize_target_dcache): Update.
1538         * dcache.h (struct dcache_deleter): New.
1539
1540 2019-05-08  Tom Tromey  <tom@tromey.com>
1541
1542         * symtab.c (struct symbol_cache): Add destructor and
1543         initializers.
1544         (symbol_cache_key): Move.  Change type.
1545         (make_symbol_cache, free_symbol_cache): Remove.
1546         (get_symbol_cache): Update.
1547         (symbol_cache_cleanup): Remove.
1548         (ALL_PSPACES, symbol_cache_flush)
1549         (maintenance_print_symbol_cache)
1550         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1551         Update.
1552
1553 2019-05-08  Tom Tromey  <tom@tromey.com>
1554
1555         * symtab.c (struct main_info): Add destructor and initializers.
1556         (main_progspace_key): Move.  Change type.
1557         (get_main_info): Update.
1558         (main_info_cleanup): Remove.
1559         (_initialize_symtab): Update.
1560
1561 2019-05-08  Tom Tromey  <tom@tromey.com>
1562
1563         * registry.h (DECLARE_REGISTRY): Define the _key class.
1564
1565 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1566
1567         * NEWS: Merge two 'New commands' sections.
1568
1569 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1570
1571         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1572         parameter and use Ada language definition instead.
1573         (ada_val_print_ptr): Remove unused language parameter.
1574         (ada_val_print_num): Remove language parameter and use Ada language
1575         definition instead.
1576         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1577         parameter.
1578         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1579         parameter and use Ada language definition instead.
1580         (ada_val_print_1): Update all ada_val_print_xxx calls.
1581         Remove language parameter.
1582         (ada_val_print): Update ada_val_print_1 call.
1583
1584 2019-05-08  Tom Tromey  <tromey@adacore.com>
1585
1586         * remote.c (remote_hw_watchpoint_limit)
1587         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1588         Now static.
1589
1590 2019-05-08  Tom Tromey  <tromey@adacore.com>
1591
1592         * maint.c (_initialize_maint_cmds): Move initialization code to
1593         remote.c.
1594         (watchdog, show_watchdog): Move to remote.c.
1595         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1596         "watchdog" static.
1597         (_initialize_remote): Move initialization code from maint.c.
1598         * defs.h (watchdog): Don't declare.
1599
1600 2019-05-08  Tom Tromey  <tromey@adacore.com>
1601
1602         * tui/tui-interp.c: Include main.h.
1603         * interps.c: Include main.h.
1604         * main.h (interpreter_p): Declare.
1605         * defs.h (interpreter_p): Don't declare.
1606
1607 2019-05-08  Tom Tromey  <tromey@adacore.com>
1608
1609         * dwarf2loc.c: Include dwarf2read.h.
1610         * defs.h (read_unsigned_leb128): Don't declare.
1611         * dwarf2read.h (read_unsigned_leb128): Declare.
1612
1613 2019-05-08  Tom Tromey  <tromey@adacore.com>
1614
1615         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1616         method.
1617
1618 2019-05-08  Tom Tromey  <tromey@adacore.com>
1619
1620         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1621         when no wrap column is set.
1622
1623 2019-05-08  Tom Tromey  <tromey@adacore.com>
1624
1625         * c-lang.c (c_get_string): Handle non-C-style arrays.
1626
1627 2019-05-08  Tom Tromey  <tromey@adacore.com>
1628
1629         * typeprint.c (print_offset_data::update): Print the bit offset,
1630         not the number of bits remaining.
1631
1632 2019-05-08  Tom Tromey  <tromey@adacore.com>
1633
1634         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1635         padding at end of comment.
1636
1637 2019-05-08  Tom Tromey  <tromey@adacore.com>
1638
1639         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1640         Compare main types.
1641
1642 2019-05-06  Tom Tromey  <tom@tromey.com>
1643
1644         * common/scoped_mmap.c: Include common-defs.h.
1645         * common/scoped_mmap.h: Don't include config.h.
1646
1647 2019-05-04  Tom Tromey  <tom@tromey.com>
1648
1649         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1650         (struct aarch64_call_info): Add initializers.
1651         <si>: Now a std::vector.
1652         (pass_on_stack, aarch64_push_dummy_call): Update.
1653
1654 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1655             Tom Tromey  <tom@tromey.com>
1656
1657         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1658         (ppc_threads): Now a std::vector.  Now static.
1659         (hwdebug_find_thread_points_by_tid)
1660         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1661         Update.
1662
1663 2019-05-04  Tom Tromey  <tom@tromey.com>
1664
1665         * arc-tdep.c (arc_tdesc_init): Return bool.
1666
1667 2019-05-04  Tom Tromey  <tom@tromey.com>
1668
1669         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1670         Use gdb_assert_not_reached.
1671
1672 2019-05-04  Tom Tromey  <tom@tromey.com>
1673
1674         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1675         "false".
1676
1677 2019-05-04  Tom Tromey  <tom@tromey.com>
1678
1679         * arc-tdep.c (arc_tdesc_init): Use bool.
1680
1681 2019-05-04  Tom Tromey  <tom@tromey.com>
1682
1683         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1684
1685 2019-05-04  Tom Tromey  <tom@tromey.com>
1686
1687         * cli/cli-cmds.c (valid_command_p): Return bool.
1688
1689 2019-05-04  Tom Tromey  <tom@tromey.com>
1690
1691         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1692         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1693
1694 2019-05-04  Raul Tambre  <raul@tambre.ee>
1695
1696         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1697         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1698         operator for comparison.
1699
1700 2019-05-04  Tom Tromey  <tom@tromey.com>
1701
1702         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1703         (lookup_partial_symbol, print_partial_symbols)
1704         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1705         (psymbol_compare): Update.
1706         (add_psymbol_to_bcache): Clear the entire psymbol.
1707         (maintenance_check_psymtabs): Update.
1708         * psympriv.h (struct partial_symbol): Don't derive from
1709         general_symbol_info.
1710         <obj_section, unrelocated_address, address,
1711         set_unrelocated_address>: Update.
1712         <ginfo>: New member.
1713         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1714         (debug_names::write_psymbols): Update.
1715
1716 2019-05-04  Tom de Vries  <tdevries@suse.de>
1717
1718         * contrib/cc-with-tweaks.sh: Support -n arg.
1719
1720 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1721
1722         * corelow.c (core_target::detach): Ensure frame cache and
1723         register caches are cleared.
1724         inferior.c (exit_inferior_1): Likewise.
1725
1726 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1727             Tom Tromey  <tom@tromey.com>
1728
1729         * dictionary.c (collate_pending_symbols_by_language): Remove
1730         "struct" from foreach.
1731         * symtab.c (lookup_global_symbol_from_objfile)
1732         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1733         foreach.
1734         * ser-tcp.c (net_open): Remove "struct" from foreach.
1735         * objfiles.c (objfile_relocate, objfile_rebase)
1736         (objfile_has_symbols): Remove "struct" from foreach.
1737         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1738         from foreach.
1739         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1740         foreach.
1741         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1742         "struct" from foreach.
1743         * ada-lang.c (create_excep_cond_exprs)
1744         (ada_exception_catchpoint_cond_string): Remove "struct" from
1745         foreach.
1746
1747 2019-05-03  Tom Tromey  <tromey@adacore.com>
1748
1749         * ada-exp.y (convert_char_literal): Check suffix of each
1750         enumerator.
1751
1752 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1753
1754         PR ada/21406:
1755         * ada-exp.y (yywrap): Don't define.
1756         * ada-lex.l (%option): Add noyywrap
1757         (yywrap): Remove.
1758
1759 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1760
1761         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1762         _WIN32_WINNT to the XP level, unless already defined to a higher
1763         level.
1764
1765         * unittests/parse-connection-spec-selftests.c:
1766         * ser-tcp.c:
1767         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1768         override.
1769
1770         * symfile.c (find_separate_debug_file): Remove colon from the
1771         drive spec of DOS/Windows file names of the target, so that the
1772         file name produced from DEBUGDIR and the target's directory will
1773         be valid on DOS/Windows systems.
1774
1775 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1776
1777         * rust-lang.c (val_print_struct): Handle printing structures
1778         containing strings.
1779
1780 2019-05-02  Tom Tromey  <tromey@adacore.com>
1781
1782         * valarith.c (_initialize_valarith): Remove.
1783
1784 2019-05-01  Tom Tromey  <tromey@adacore.com>
1785
1786         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1787         bitfields.
1788
1789 2019-05-01  Tom Tromey  <tromey@adacore.com>
1790
1791         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1792         for big-endian copies.
1793
1794 2019-04-30  Ali Tamur  <tamur@google.com>
1795         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1796         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1797         (read_3_bytes): New function.
1798
1799 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1800
1801         * windows-nat.c (main_thread_id): Delete.
1802         (handle_output_debug_string): Replace main_thread_id by
1803         current_event.dwThreadId.
1804         (fake_create_process): Likewise.
1805         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1806         Do not set main_thread_id.
1807         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1808         current_event.dwThreadId.
1809         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1810
1811 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1812
1813         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1814         Use current_event.dwThreadId instead of main_thread_id.
1815
1816 2019-04-30  Tom Tromey  <tromey@adacore.com>
1817
1818         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1819         (create_excep_cond_exprs): Iterate over program spaces.
1820         (ada_exception_catchpoint_cond_string): Examine all minimal
1821         symbols for exception types.
1822
1823 2019-04-30  Tom Tromey  <tromey@adacore.com>
1824
1825         PR c++/24470:
1826         * dwarf2read.c (process_structure_scope): Handle case where type
1827         has template parameters but no symbol was created.
1828
1829 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1830             Chris January  <chris.january@arm.com>
1831
1832         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1833         qualifier.
1834         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1835
1836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1837
1838         * f-typeprint.c (f_print_type): Update rules for printing
1839         whitespace.
1840         (f_type_print_varspec_suffix): Likewise.
1841
1842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1843             Chris January  <chris.january@arm.com>
1844
1845         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1846         function arguments.
1847
1848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1849
1850         * f-lang.c (build_fortran_types): Change name of void type to
1851         lower case.
1852         * f-typeprint.c (f_type_print_base): Print the name of the void
1853         type, rather than a fixed string.
1854         * f-valprint.c (f_decorations): Use lower case void string.
1855
1856 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1857             Chris January  <chris.january@arm.com>
1858
1859         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1860         types for Fortran.
1861
1862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1863             Chris January  <chris.january@arm.com>
1864             David Lecomber  <david.lecomber@arm.com>
1865
1866         * f-exp.y (BINOP_INTRINSIC): New token.
1867         (exp): New parser rule handling BINOP_INTRINSIC.
1868         (f77_keywords): Add new builtin procedures.
1869         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1870         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1871         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1872         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1873         (print_unop_subexp_f): New function.
1874         (print_binop_subexp_f): New function.
1875         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1876         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1877         (dump_subexp_body_f): Likewise.
1878         (operator_check_f): Likewise.
1879         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1880         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1881
1882 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1883
1884         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1885         UNOP_KIND.
1886         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1887         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1888         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1889         (operator_length_f): New fuction.
1890         (print_subexp_f): New function.
1891         (op_name_f): New function.
1892         (dump_subexp_body_f): New function.
1893         (operator_check_f): New function.
1894         (exp_descriptor_f): Replace standard expression handling functions
1895         with new functions.
1896         * gdb/fortran-operator.def: New file.
1897         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1898         * gdb/std-operator.def: Remove UNOP_KIND.
1899
1900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1901
1902         * std-operator.def: Remove unbalanced, stray double quote
1903         character.
1904
1905 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1906             Chris January  <chris.january@arm.com>
1907             Daniel Everett  <daniel.everett@arm.com>
1908             Nick Forrington  <nick.forrington@arm.com>
1909             Richard Bunt  <richard.bunt@arm.com>
1910
1911         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1912         of depth when printing anonymous structs or unions.
1913         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1914         Don't print either the top-level value, or the children if the
1915         max-depth is exceeded.
1916         (ppscm_print_children): When printing the key of a map, allow one
1917         extra level of depth.
1918         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1919         print either the top-level value, or the children if the max-depth
1920         is exceeded.
1921         (print_children): When printing the key of a map, allow one extra
1922         level of depth.
1923         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1924         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1925         (user_print_options): Initialise max_depth field.
1926         (val_print_scalar_or_string_type_p): New function.
1927         (val_print): Check to see if the max depth has been reached.
1928         (val_print_check_max_depth): Define new function.
1929         (show_print_max_depth): New function.
1930         (_initialize_valprint): Add 'print max-depth' option.
1931         * valprint.h (struct value_print_options) <max_depth>: New field.
1932         (val_print_check_max_depth): Declare new function.
1933         * NEWS: Document new feature.
1934
1935 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1936
1937         * ada-lang.c (ada_language_defn): Initialise new field.
1938         * c-lang.c (c_is_string_type_p): New function.
1939         (c_language_defn): Initialise new field.
1940         (cplus_language_defn): Initialise new field.
1941         (asm_language_defn): Initialise new field.
1942         (minimal_language_defn): Initialise new field.
1943         * c-lang.h (c_is_string_type_p): Declare new function.
1944         * d-lang.c (d_language_defn): Initialise new field.
1945         * f-lang.c (f_is_string_type_p): New function.
1946         (f_language_defn): Initialise new field.
1947         * go-lang.c (go_is_string_type_p): New function.
1948         (go_language_defn): Initialise new field.
1949         * language.c (default_is_string_type_p): New function.
1950         (unknown_language_defn): Initialise new field.
1951         (auto_language_defn): Initialise new field.
1952         * language.h (struct language_defn) <la_is_string_type_p>: New
1953         member variable.
1954         (default_is_string_type_p): Declare new function.
1955         * m2-lang.c (m2_language_defn): Initialise new field.
1956         * objc-lang.c (objc_language_defn): Initialise new field.
1957         * opencl-lang.c (opencl_language_defn): Initialise new field.
1958         * p-lang.c (pascal_is_string_type_p): New function.
1959         (pascal_language_defn): Initialise new field.
1960         * rust-lang.c (rust_is_string_type_p): New function.
1961         (rust_language_defn): Initialise new field.
1962
1963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1964
1965         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1966         New field.
1967         * ada-lang.c (ada_language_defn): Initialise new field.
1968         * c-lang.c (c_language_defn): Likewise.
1969         (cplus_language_defn): Likewise.
1970         (asm_language_defn): Likewise.
1971         (minimal_language_defn): Likewise.
1972         * d-lang.c (d_language_defn): Likewise.
1973         * f-lang.c (f_language_defn): Likewise.
1974         * go-lang.c (go_language_defn): Likewise.
1975         * language.c (unknown_language_defn): Likewise.
1976         (auto_language_defn): Likewise.
1977         * m2-lang.c (m2_language_defn): Likewise.
1978         * objc-lang.c (objc_language_defn): Likewise.
1979         * opencl-lang.c (opencl_language_defn): Likewise.
1980         * p-lang.c (pascal_language_defn): Likewise.
1981         * rust-lang.c (rust_language_defn): Likewise.
1982
1983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1984
1985         * ada-lang.c (ada_is_character_type): Change return type to bool.
1986         (ada_is_string_type): Likewise.
1987         * ada-lang.h (ada_is_character_type): Update declaration
1988         (ada_is_string_type): Likewise.
1989
1990 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1991
1992         Support style in 'frame|thread apply'
1993
1994         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1995         * record.c (record_start, record_stop): Update callers of
1996         execute_command_to_string with false.
1997         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1998         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1999         methods.
2000         (class string_file): New constructor with term_out parameter.
2001         Override methods term_out and can_emit_style_escape.  New member
2002         term_out.
2003         (class stdio_file): Override can_emit_style_escape.
2004         (class tee_file): Override term_out and can_emit_style_escape.
2005         * utils.h (can_emit_style_escape): Remove.
2006         * utils.c (can_emit_style_escape): Likewise.
2007         Update all callers of can_emit_style_escape (SOMESTREAM) to
2008         SOMESTREAM->can_emit_style_escape.
2009         * source-cache.c (source_cache::get_source_lines): Likewise.
2010         * stack.c (frame_apply_command_count): Call execute_command_to_string
2011         passing the term_out characteristic of the current gdb_stdout.
2012         * thread.c (thr_try_catch_cmd): Likewise.
2013         * top.c (execute_command_to_string): pass term_out parameter
2014         to construct the string_file for the command output.
2015         * ui-file.c (term_cli_styling): New function (most code moved
2016         from utils.c can_emit_style_escape).
2017         (string_file::string_file, string_file::can_emit_style_escape,
2018         stdio_file::can_emit_style_escape, tee_file::term_out,
2019         tee_file::can_emit_style_escape): New functions.
2020
2021 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2022
2023         * NEWS: Mention the new set|show may-call-functions.
2024         * infcall.c (may_call_functions_p): New variable.
2025         (show_may_call_functions_p): New function.
2026         (call_function_by_hand_dummy): Throws an error if not
2027         may-call-functions.
2028         (_initialize_infcall): Call add_setshow_boolean_cmd for
2029         may-call-functions.
2030
2031 2019-04-25  Keith Seitz  <keiths@redhat.com>
2032
2033         PR c++/24367
2034         * cp-support.c (inspect_type): Don't attempt substitutions
2035         of symbol with the same name.
2036
2037 2019-04-25  Tom Tromey  <tromey@adacore.com>
2038
2039         PR gdb/24475:
2040         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2041         static.
2042
2043 2019-04-25  Tom Tromey  <tromey@adacore.com>
2044
2045         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2046         rvalue reference.
2047         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2048         (gdb_xml_parser::parse): Use std::move.
2049         * python/python-internal.h (gdbpy_convert_exception): Take a const
2050         reference.
2051         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2052         std::move.
2053         * python/py-utils.c (gdbpy_convert_exception): Take a const
2054         reference.
2055         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2056         Use std::move.
2057         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2058         Use std::move.
2059         * mi/mi-main.c (mi_print_exception): Take a const reference.
2060         * main.c (handle_command_errors): Take a const reference.
2061         * linespec.c (parse_linespec): Use std::move.
2062         * infcall.c (run_inferior_call): Use std::move.
2063         (call_function_by_hand_dummy): Use std::move.
2064         * exec.c (try_open_exec_file): Use std::move.
2065         * exceptions.h (exception_print, exception_fprintf)
2066         (exception_print_same): Update.
2067         * exceptions.c (print_exception, exception_print)
2068         (exception_fprintf, exception_print_same): Change parameters to
2069         const reference.
2070         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2071         * common/new-op.c: Use std::move.
2072         * common/common-exceptions.h (struct gdb_exception): Add move
2073         constructor.
2074         (struct gdb_exception_error, struct gdb_exception_quit, struct
2075         gdb_quit_bad_alloc): Change constructor to move constructor.
2076         (throw_exception): Change parameter to rvalue reference.
2077         * common/common-exceptions.c (throw_exception): Take rvalue
2078         reference.
2079         * cli/cli-interp.c (safe_execute_command): Use std::move.
2080         * breakpoint.c (insert_bp_location, location_to_sals): Use
2081         std::move.
2082
2083 2019-04-25  Tom Tromey  <tromey@adacore.com>
2084
2085         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2086         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2087         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2088         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2089         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2090         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2091         guile/scm-value.c: Use unpack.
2092         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2093         gdbscm_gdb_exception.
2094         (gdbscm_throw_gdb_exception): Likewise.
2095         (struct gdbscm_gdb_exception): New.
2096         (unpack): New function.
2097         (gdbscm_wrap): Use unpack.
2098
2099 2019-04-25  Tom Tromey  <tromey@adacore.com>
2100
2101         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2102         (gdb_rl_callback_handler): Use std::move.
2103         * common/common-exceptions.h (struct gdb_exception): Add move
2104         assignment operator.
2105         (throw_exception_sjlj): Change "exception" to const reference.
2106         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2107         (throw_exception_sjlj): Change "exception" to const reference.
2108
2109 2019-04-25  Tom Tromey  <tromey@adacore.com>
2110
2111         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2112         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2113         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2114         Update.
2115         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2116         Update.
2117         * mi/mi-interp.c (mi_interp::exec): Update.
2118         * linespec.c (parse_linespec): Update.
2119         * infcall.c (run_inferior_call): Update.
2120         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2121         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2122         (gdbscm_lookup_global_symbol): Update.
2123         * guile/scm-param.c (gdbscm_parameter_value): Update.
2124         * guile/scm-frame.c (gdbscm_frame_read_register)
2125         (gdbscm_frame_read_var): Update.
2126         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2127         * exec.c (try_open_exec_file): Update.
2128         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2129         (gdb_rl_callback_handler): Update.
2130         * common/common-exceptions.h (exception_none): Don't declare.
2131         * common/common-exceptions.c (exception_none): Don't define.
2132         (struct catcher) <exception>: Update.
2133         * cli/cli-interp.c (safe_execute_command): Update.
2134         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2135
2136 2019-04-25  Ali Tamur  <tamur@google.com>
2137
2138         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2139         (read_attribute_value): Likewise.
2140         (dwarf2_read_addr_index): Update comment.
2141         (read_str_index): Add DW_FORM_strx.
2142         (dwarf2_string_attr): Likewise.
2143         (dwarf2_const_value_attr): Likewise.
2144         (dump_die_shallow): Likewise.
2145         (dwarf2_fetch_constant_bytes): Likewise.
2146         (skip_form_bytes): Likewise.
2147         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2148
2149 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2150
2151         PR corefiles/11608
2152         PR corefiles/18187
2153         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2154         OFFSET.  Verify if current mapping contains an ELF header.
2155         (linux_find_memory_regions_full): Adjust call to
2156         dump_mapping_p.
2157
2158 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2159             Kang Li <kanglictf@gmail.com>
2160
2161         PR gdb/21600
2162
2163         * dwarf2-frame.c (read_initial_length): Be consistent about using
2164         unsigned representation of length.
2165         (decode_frame_entry_1): Likewise.  Check for wraparound of
2166         end pointer as well as buffer overflow.
2167
2168 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2169
2170         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2171         "vq".
2172
2173 2019-04-24  Tom Tromey  <tromey@adacore.com>
2174
2175         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2176
2177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2178
2179         * s12z-tdep.c (s12z_unwind_pc): Delete.
2180         (s12z_unwind_sp): Delete.
2181         (s12z_gdbarch_init): Don't register deleted functions with
2182         gdbarch.
2183
2184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2185
2186         * rl78-tdep.c (rl78_unwind_sp): Delete.
2187         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2188
2189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2192         (xstormy16_unwind_pc): Delete.
2193         (xstormy16_dummy_id): Delete.
2194         (xstormy16_gdbarch_init): Don't register deleted functions with
2195         gdbarch.
2196
2197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2198
2199         * vax-tdep.c (vax_unwind_pc): Delete.
2200         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2201
2202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * v850-tdep.c (v850_unwind_sp): Delete.
2205         (v850_unwind_pc): Delete.
2206         (v850_dummy_id): Delete.
2207         (v850_gdbarch_init): Don't register deleted functions with
2208         gdbarch.
2209
2210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2213         (tilegx_unwind_pc): Delete.
2214         (tilegx_unwind_dummy_id): Delete.
2215         (tilegx_gdbarch_init): Don't register deleted functions with
2216         gdbarch.
2217
2218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2219
2220         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2221         (tic6x_dummy_id): Delete.
2222         (tic6x_gdbarch_init): Don't register deleted functions with
2223         gdbarch.
2224
2225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2226
2227         * sparc-tdep.c (sparc_unwind_pc): Delete.
2228         (sparc32_gdbarch_init): Don't register deleted function with
2229         gdbarch.
2230
2231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * sh-tdep.c (sh_unwind_sp): Delete.
2234         (sh_unwind_pc): Delete.
2235         (sh_dummy_id): Delete.
2236         (sh_gdbarch_init): Don't register deleted functions with
2237         gdbarch.
2238
2239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2240
2241         * score-tdep.c (score_unwind_sp): Delete.
2242         (score_unwind_pc): Delete.
2243         (score_dummy_id): Delete.
2244         (score_gdbarch_init): Don't register deleted functions with
2245         gdbarch.
2246
2247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * rx-tdep.c (rx_unwind_pc): Delete.
2250         (rx_unwind_sp): Delete.
2251         (rx_dummy_id): Delete.
2252         (rx_gdbarch_init): Don't register deleted functions with
2253         gdbarch.  Update comment.
2254
2255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2258         (rs6000_dummy_id): Delete.
2259         (rs6000_gdbarch_init): Don't register deleted functions with
2260         gdbarch.
2261
2262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * or1k-tdep.c (or1k_dummy_id): Delete.
2265         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2266
2267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * nios2-tdep.c (nios2_dummy_id): Delete.
2270         (nios2_unwind_sp): Delete.
2271         (nios2_gdbarch_init): Don't register deleted functions with
2272         gdbarch.
2273
2274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2275
2276         * nds32-tdep.c (nds32_dummy_id): Delete.
2277         (nds32_unwind_pc): Delete.
2278         (nds32_unwind_sp): Delete.
2279         (nds32_gdbarch_init): Don't register deleted functions with
2280         gdbarch.
2281
2282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * msp430-tdep.c (msp430_unwind_pc): Delete.
2285         (msp430_unwind_sp): Delete.
2286         (msp430_dummy_id): Delete.
2287         (msp430_gdbarch_init): Don't register deleted functions with
2288         gdbarch.
2289
2290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2291
2292         * moxie-tdep.c (moxie_unwind_sp): Delete.
2293         (moxie_unwind_pc): Delete.
2294         (moxie_dummy_id): Delete.
2295         (moxie_gdbarch_init): Don't register deleted functions with
2296         gdbarch.
2297
2298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2299
2300         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2301         (mn10300_unwind_pc): Delete.
2302         (mn10300_unwind_sp): Delete.
2303         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2304         mn10300_unwind_sp.
2305         (mn10300_frame_unwind_init): Don't register deleted functions with
2306         gdbarch.
2307
2308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * mep-tdep.c (mep_unwind_pc): Delete.
2311         (mep_unwind_sp): Delete.
2312         (mep_dummy_id): Delete.
2313         (mep_gdbarch_init): Don't register deleted functions with
2314         gdbarch.
2315
2316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2317
2318         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2319         (m68hc11_unwind_sp): Delete.
2320         (m68hc11_gdbarch_init): Don't register deleted functions with
2321         gdbarch.
2322
2323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * m32r-tdep.c (m32r_unwind_sp): Delete.
2326         (m32r_unwind_pc): Delete.
2327         (m32r_dummy_id): Delete.
2328         (m32r_gdbarch_init): Don't register deleted functions with
2329         gdbarch.
2330
2331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * m32c-tdep.c (m32c_unwind_pc): Delete.
2334         (m32c_unwind_sp): Delete.
2335         (m32c_dummy_id): Delete.
2336         (m32c_gdbarch_init): Don't register deleted functions with
2337         gdbarch.
2338
2339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2342         (lm32_unwind_pc): Delete.
2343         (lm32_dummy_id): Delete.
2344         (lm32_gdbarch_init): Don't register deleted functions with
2345         gdbarch.
2346
2347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2350         (iq2000_unwind_pc): Delete.
2351         (iq2000_dummy_id): Delete.
2352         (iq2000_gdbarch_init): Don't register deleted functions with
2353         gdbarch.
2354
2355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2356
2357         * nds32-tdep.c (nds32_type_align): Delete.
2358         (nds32_push_dummy_call): Use type_align instead.
2359
2360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * arm-tdep.c (arm_type_align): Only handle vector override case.
2363         (arm_push_dummy_call): Use type_align.
2364         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2365
2366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2369         case.
2370         (pass_on_stack): Use type_align.
2371         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2372         function.
2373
2374 2019-04-23  Tom Tromey  <tromey@adacore.com>
2375
2376         * dwarf2read.c (line_header::file_name_at): Remove unused
2377         overload.
2378
2379 2019-04-23  Tom de Vries  <tdevries@suse.de>
2380
2381         PR gdb/24438
2382         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2383         invocation.
2384
2385
2386 2019-03-27  Ali Tamur  <tamur@google.com>
2387
2388         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2389         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2390         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2391         (dwarf_expr_context::get_addr_index): Likewise
2392         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2393         (symbol_needs_eval_context::get_addr_index): Likewise
2394         (disassemble_dwarf_expression): Add DW_OP_addrx
2395         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2396         (read_cutu_die_from_dwo): Update comment
2397         (skip_one_die): Add DW_FORM_addrx
2398         (read_attribute_value): Likewise
2399         (var_decode_location): Add DW_OP_addrx
2400         (dwarf2_const_value_attr): Add DW_FORM_addrx
2401         (dump_die_shallow): Likewise
2402         (dwarf2_fetch_constant_bytes): Likewise
2403         (decode_locdesc): Add DW_OP_addrx
2404         (skip_form_bytes): Add DW_FORM_addrx
2405
2406 2019-04-22  Ali Tamur  <tamur@google.com>
2407
2408         * MAINTAINERS (Write After Approval): Add self.
2409
2410 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2411
2412         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2413         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2414         (open_symbol_file_object): Likewise.
2415         (svr4_default_sos): Add info parameter.
2416         (svr4_read_so_list): Likewise.
2417         (svr4_current_sos_direct): Adjust functions calls to pass down
2418         info.
2419         (svr4_current_sos_1): Add info parameter.
2420         (svr4_current_sos): Call get_svr4_info, pass info down to
2421         svr4_current_sos_1.
2422         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2423         get_svr4_info.
2424         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2425         get_svr4_info.
2426         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2427         to get_svr4_info.
2428         (probes_table_remove_objfile_probes): Likewise.
2429         (register_solib_event_probe): Add info parameter.
2430         (solist_update_incremental): Pass info parameter down to
2431         svr4_read_so_list.
2432         (disable_probes_interface): Add info parameter.
2433         (svr4_handle_solib_event): Pass current_program_space to
2434         get_svr4_info.  Adjust disable_probes_interface cleanup.
2435         (svr4_create_probe_breakpoints): Add info parameter, pass it
2436         down to register_solib_event_probe.
2437         (svr4_create_solib_event_breakpoints): Add info parameter,
2438         pass it down to svr4_create_probe_breakpoints.
2439         (enable_break): Pass info down to
2440         svr4_create_solib_event_breakpoints.
2441         (svr4_solib_create_inferior_hook): Pass current_program_space to
2442         get_svr4_info.
2443         (svr4_clear_solib): Likewise.
2444
2445 2019-04-22  Pedro Alves  <palves@redhat.com>
2446
2447         * solib-svr4.c (svr4_free_objfile_observer): New.
2448         (probe_and_action::objfile): New field.
2449         (probes_table_htab_remove_objfile_probes)
2450         (probes_table_remove_objfile_probes): New functions.
2451         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2452         in the new probe_and_action.  Don't store the probe in 'lookup'.
2453         (svr4_create_probe_breakpoints): Pass objfile to
2454         register_solib_event_probe.
2455         (_initialize_svr4_solib): Register a free_objfile observer.
2456
2457 2019-04-19  Tom Tromey  <tom@tromey.com>
2458
2459         * common/queue.h: Remove.
2460
2461 2019-04-19  Tom Tromey  <tom@tromey.com>
2462
2463         * event-loop.c: Don't include "common/queue.h".
2464
2465 2019-04-19  Tom Tromey  <tom@tromey.com>
2466
2467         * remote.c (remote_target): Use delete.
2468         * remote-notif.h: Include <list>, not "common/queue.h".
2469         (notif_client_p): Remove typedef.
2470         (remote_notif_state): Add constructor, destructor, initializer.
2471         <notif_queue>: Now a std::list.
2472         (remote_notif_state_xfree): Don't declare.
2473         * remote-notif.c (remote_notif_process, handle_notification)
2474         (remote_notif_state_allocate): Update.
2475         (~remote_notif_state): Rename from remote_notif_state_xfree.
2476
2477 2019-04-19  Tom Tromey  <tom@tromey.com>
2478
2479         * symfile.c (reread_symbols): Update.
2480         * objfiles.c (objfile_register_static_link)
2481         (objfile_lookup_static_link): Update
2482         (~objfile) Don't delete static_links.
2483         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2484
2485 2019-04-19  Tom Tromey  <tom@tromey.com>
2486
2487         * type-stack.h (struct type_stack) <insert>: Constify string.
2488         * type-stack.c (type_stack::insert): Constify string.
2489         * gdbtypes.h (lookup_template_type): Update.
2490         (address_space_name_to_int): Update.
2491         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2492         const.
2493         (lookup_template_type): Make name const.
2494         * c-exp.y: Update rules.
2495         (lex_one_token, classify_name, classify_inner_name)
2496         (c_print_token): Update.
2497         * p-exp.y: Update rules.
2498         (yylex): Update.
2499         * f-exp.y: Update rules.
2500         (yylex): Update.
2501         * d-exp.y: Update rules.
2502         (lex_one_token, classify_name, classify_inner_name): Update.
2503         * parse.c (write_dollar_variable, copy_name): Return std::string.
2504         * parser-defs.h (copy_name): Change return type.
2505         * m2-exp.y: Update rules.
2506         (yylex): Update.
2507         * go-exp.y (lex_one_token): Update.
2508         Update rules.
2509         (classify_unsafe_function, classify_packaged_name)
2510         (classify_name, yylex): Update.
2511
2512 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2513
2514         * configure.ac: add --enable-source-highlight switch.
2515         * configure: Regenerate.
2516         * top.c (print_gdb_version): plumb --enable-source-highlight
2517         status to "show configuration".
2518
2519 2019-04-19  Tom Tromey  <tromey@adacore.com>
2520
2521         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2522         Check ADA_TYPE_P.
2523         (empty_record, ada_template_to_fixed_record_type_1)
2524         (template_to_static_fixed_type)
2525         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2526         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2527         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2528         macros.
2529
2530 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2531
2532         PR symtab/24423:
2533         * source.c (print_source_lines_base): Advance "iter" when a
2534         control character is seen.
2535
2536 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2537
2538         * inferior.h (struct infcall_suspend_state_deleter):
2539         Catch exception in destructor to avoid crash.
2540
2541 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2542
2543         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2544         close to the add_com "shell".
2545
2546 2019-04-18  Tom Tromey  <tromey@adacore.com>
2547
2548         * process-stratum-target.h (class process_stratum_target)
2549         <stratum>: Add "final".
2550
2551 2019-04-17  Tom Tromey  <tromey@adacore.com>
2552
2553         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2554         against nullptr before use.
2555
2556 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2557
2558         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2559
2560 2019-04-17  Jim Wilson  <jimw@sifive.com>
2561             Andrew Burgess  <andrew.burgess@embecosm.com>
2562
2563         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2564         code read might fail, assume 4-byte breakpoint in that case.
2565
2566 2019-04-15  Leszek Swirski  <leszeks@google.com>
2567
2568         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2569         rather than a hand-rolled POD check when checking for forced MEMORY
2570         classification.
2571
2572 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2573
2574         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2575         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2576         function.
2577         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2578         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2579         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2580         declaration.
2581
2582 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2583
2584         * aarch64-linux-nat.c
2585         (aarch64_linux_nat_target::thread_architecture): Add override.
2586         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2587         each VQ.
2588
2589 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2590
2591         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2592
2593 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2594
2595         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2596         target types of size 96-bits, add some additional comments, and
2597         check that the builtin type we found was the correct size.
2598
2599 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2600
2601         * utils.c (prompt_for_continue): Don't restore the styling at the
2602         end, as applied_style has the wrong value.  This fixes styling in
2603         long lists of file names that are interrupted by the "Continue?"
2604         prompt.
2605
2606 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2609         * c-lang.c (c_language_defn): Likewise.
2610         (cplus_language_defn): Likewise.
2611         (asm_language_defn): Likewise.
2612         (minimal_language_defn): Likewise.
2613         * d-lang.c (d_language_defn): Likewise.
2614         * f-lang.c (f_language_defn): Likewise.
2615         * go-lang.c (go_language_defn): Likewise.
2616         * language.c (unknown_language_defn): Likewise.
2617         (auto_language_defn): Likewise.
2618         * language.h (struct language_defn): Remove la_magic field.
2619         (LANG_MAGIC): Delete.
2620         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2621         * objc-lang.c (objc_language_defn): Likewise.
2622         * opencl-lang.c (opencl_language_defn): Likewise.
2623         * p-lang.c (pascal_language_defn): Likewise.
2624         * rust-lang.c (rust_language_defn): Likewise.
2625
2626 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2627
2628         * riscv-tdep.c (riscv_type_align): New function.
2629         (riscv_type_alignment): Delete.
2630         (riscv_arg_location): Use 'type_align'.
2631         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2632
2633 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2634
2635         * gdbtypes.c (type_align): A struct with no non-static fields also
2636         has alignment of 1.
2637
2638 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2641         component to 0.
2642         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2643         member.
2644         (riscv_struct_info::analyse): New implementation using new
2645         analyse_inner member function.
2646         (riscv_struct_info::field_offset): New member function.
2647         (riscv_struct_info::m_offsets): New member variable.
2648         (riscv_struct_info::analyse_inner): New private member function,
2649         takes the old implementation of riscv_struct_info::analyse but
2650         extended to track field offsets.
2651         (riscv_call_arg_struct): Update the struct folding special cases
2652         to handle cases where empty C++ structs, which are non-zero
2653         length, are found.
2654         (riscv_arg_location): Initialise the length of each location, a
2655         non-zero length now indicates the location is in use.
2656         (riscv_push_dummy_call): Allow for the first location having a
2657         non-zero offset when setting up arguments.
2658         (riscv_return_value): Likewise, but for return values.
2659
2660 2019-04-11  Tom Tromey  <tromey@adacore.com>
2661
2662         * utils.c (internal_vproblem): Make "msg" const.
2663
2664 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2665
2666         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2667         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2668         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2669         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2670
2671 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2672
2673         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2674         function.
2675         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2676         of amd64_collect_native_gregset.
2677         (amd64_linux_nat_target::store_registers): Likewise.
2678
2679 2019-04-10  Tom Tromey  <tom@tromey.com>
2680
2681         * symtab.c (lookup_global_symbol_from_objfile)
2682         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2683         * objfiles.h (class separate_debug_iterator): New.
2684         (class separate_debug_range): New.
2685         (struct objfile) <separate_debug_objfiles>: New method.
2686         (objfile_separate_debug_iterate): Don't declare.
2687         * objfiles.c (separate_debug_iterator::operator++): Rename from
2688         objfile_separate_debug_iterate.
2689         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2690         iterator.
2691         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2692         iterator.
2693
2694 2019-04-10  Tom Tromey  <tom@tromey.com>
2695
2696         * symfile.c (reread_symbols): Remove old comment.
2697         * objfiles.c (free_all_objfiles): Fix a typo.
2698
2699 2019-04-10  Tom Tromey  <tom@tromey.com>
2700
2701         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2702         * minsyms.c (lookup_minimal_symbol): Use foreach.
2703         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2704         (lookup_minimal_symbol_solib_trampoline): Likewise.
2705         * symfile.c (reread_symbols): Use foreach.
2706
2707 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2708             Tom Tromey  <tromey@adacore.com>
2709
2710         PR rust/24414:
2711         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2712         (rust_lex_int_test): Change "value" to be LONGEST.
2713         (rust_lex_tests): Add test for long integer literal.
2714
2715 2019-04-09  Tom Tromey  <tromey@adacore.com>
2716
2717         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2718         to bool.
2719         (extended_remote_target::attach): Update.
2720         (remote_target::remote_notice_new_inferior): Update.
2721         (remote_target::add_current_inferior_and_thread): Update.
2722         * inferior.c (exit_inferior_1): Use "false".
2723         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2724
2725 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2726
2727         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2728         the "start" command.
2729
2730 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2731
2732         * python/py-inferior.c (infpy_thread_from_thread_handle):
2733         Adjust comments to reflect renaming of thread_from_thread_handle
2734         to thread_from_handle.  Adjust keywords.  Fix type error message.
2735         (inferior_object_methods): Add thread_from_handle.  Retain
2736         thread_from_thread_handle, but mark it as deprecated.
2737
2738 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2739
2740         * gdbthread.h (find_thread_by_handle): Revise declaration.
2741         * thread.c (find_thread_by_handle): Likewise.  Adjust
2742         implementation too.
2743         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2744         support for buffer objects as handles.
2745
2746 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2747
2748         * python/py-infthread.c (thpy_thread_handle): New function.
2749         (thread_object_methods): Register thpy_thread_handle.
2750
2751 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2752
2753         * gdbthread.h (thread_to_thread_handle): Declare.
2754         * thread.c (gdbtypes.h): Include.
2755         (thread_to_thread_handle): New function.
2756
2757         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2758         (target_thread_info_to_thread_handle): Declare.
2759         * target.c (target_thread_info_to_thread_handle): New function.
2760         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2761         * target-delegates.c: Regenerate.
2762
2763         * linux-thread-db.c (class thread_db_target): Add method
2764         thread_info_to_thread_handle.
2765         (thread_db_target::thread_info_to_thread_handle): Define.
2766         * remote.c (class remote_target): Add new method
2767         thread_info_to_thread_handle.
2768         (remote_target::thread_info_to_thread_handle): Define.
2769
2770 2019-04-08  Pedro Alves  <palves@redhat.com>
2771
2772         * common/common-exceptions.c (throw_exception): Don't create
2773         named object to throw; throw directly.
2774         (throw_it): Likewise.  Don't initialize gdb_exception::message
2775         here, with new; pass FMT and AP to the ctor instead.
2776         * common/common-exceptions.h: Include <string>.
2777         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2778         const char *, va_list)): New ctor.  Use std::make_shared.
2779         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2780         errors)): Delete.
2781         (gdb_exception_error::gdb_exception_error(enum errors, const char
2782         *, va_list)): New.
2783         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2784         Add assertion.
2785         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2786         errors)): Delete.
2787         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2788         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2789         Add assertion.
2790
2791 2019-04-08  Tom Tromey  <tom@tromey.com>
2792
2793         * valops.c (value_rtti_indirect_type): Replace throw_exception
2794         with throw.
2795         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2796         with throw.
2797         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2798         throw.
2799         * target.c (target_translate_tls_address): Replace throw_exception
2800         with throw.
2801         * stack.c (frame_apply_command_count): Replace throw_exception
2802         with throw.
2803         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2804         throw.
2805         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2806         with throw.
2807         * rs6000-tdep.c (rs6000_frame_cache)
2808         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2809         * remote.c: Replace throw_exception with throw.
2810         * record-full.c (record_full_message, record_full_wait_1)
2811         (record_full_restore): Replace throw_exception with throw.
2812         * record-btrace.c:
2813         (get_thread_current_frame_id, record_btrace_start_replaying)
2814         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2815         (cmd_record_btrace_start): Replace throw_exception with throw.
2816         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2817         throw.
2818         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2819         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2820         * linespec.c:
2821         (find_linespec_symbols): Replace throw_exception with throw.
2822         * infrun.c (displaced_step_prepare, resume): Replace
2823         throw_exception with throw.
2824         * infcmd.c (post_create_inferior): Replace throw_exception with
2825         throw.
2826         * inf-loop.c (inferior_event_handler): Replace throw_exception
2827         with throw.
2828         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2829         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2830         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2831         (get_prev_frame_always, get_frame_pc_if_available)
2832         (get_frame_address_in_block_if_available, get_frame_language):
2833         Replace throw_exception with throw.
2834         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2835         throw_exception with throw.
2836         * eval.c (fetch_subexp_value, evaluate_var_value)
2837         (evaluate_funcall, evaluate_subexp_standard): Replace
2838         throw_exception with throw.
2839         * dwarf2loc.c (call_site_find_chain)
2840         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2841         Replace throw_exception with throw.
2842         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2843         with throw.
2844         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2845         throw.
2846         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2847         * completer.c (complete_line_internal): Replace throw_exception
2848         with throw.
2849         * compile/compile-object-run.c (compile_object_run): Replace
2850         throw_exception with throw.
2851         * cli/cli-script.c (process_next_line): Replace throw_exception
2852         with throw.
2853         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2854         (btrace_enable, btrace_maint_update_pt_packets): Replace
2855         throw_exception with throw.
2856         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2857         throw_exception with throw.
2858         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2859         throw_exception with throw.
2860         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2861         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2862         * aarch64-tdep.c (aarch64_make_prologue_cache)
2863         (aarch64_make_stub_cache): Replace throw_exception with throw.
2864
2865 2019-04-08  Tom Tromey  <tom@tromey.com>
2866
2867         * common/common-exceptions.c (throw_exception): Rename from
2868         throw_exception_cxx.  Remove old copy.  Make argument const.
2869         (throw_it): Create and throw exception objects directly.
2870         * common/common-exceptions.h (throw_exception): Make argument
2871         const.
2872         (struct gdb_exception_error): Add constructor.
2873         (struct gdb_exception_quit): Add constructor.
2874
2875 2019-04-08  Tom Tromey  <tom@tromey.com>
2876
2877         * common/common-exceptions.h (exception_rethrow): Don't declare.
2878         (TRY_SJLJ): Update comment.
2879         (TRY, CATCH, END_CATCH): Remove.
2880         * common/common-exceptions.c (exception_rethrow): Remove.
2881
2882 2019-04-08  Tom Tromey  <tom@tromey.com>
2883
2884         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2885         Remove.
2886         (gdb_exception_error): Rename from
2887         gdb_exception_RETURN_MASK_ERROR.
2888         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2889         (gdb_quit_bad_alloc): Update.
2890         * aarch64-tdep.c: Update.
2891         * ada-lang.c: Update.
2892         * ada-typeprint.c: Update.
2893         * ada-valprint.c: Update.
2894         * amd64-tdep.c: Update.
2895         * arch-utils.c: Update.
2896         * break-catch-throw.c: Update.
2897         * breakpoint.c: Update.
2898         * btrace.c: Update.
2899         * c-varobj.c: Update.
2900         * cli/cli-cmds.c: Update.
2901         * cli/cli-interp.c: Update.
2902         * cli/cli-script.c: Update.
2903         * common/common-exceptions.c: Update.
2904         * common/new-op.c: Update.
2905         * common/selftest.c: Update.
2906         * compile/compile-c-symbols.c: Update.
2907         * compile/compile-cplus-symbols.c: Update.
2908         * compile/compile-object-load.c: Update.
2909         * compile/compile-object-run.c: Update.
2910         * completer.c: Update.
2911         * corelow.c: Update.
2912         * cp-abi.c: Update.
2913         * cp-support.c: Update.
2914         * cp-valprint.c: Update.
2915         * darwin-nat.c: Update.
2916         * disasm-selftests.c: Update.
2917         * dtrace-probe.c: Update.
2918         * dwarf-index-cache.c: Update.
2919         * dwarf-index-write.c: Update.
2920         * dwarf2-frame-tailcall.c: Update.
2921         * dwarf2-frame.c: Update.
2922         * dwarf2loc.c: Update.
2923         * dwarf2read.c: Update.
2924         * eval.c: Update.
2925         * event-loop.c: Update.
2926         * event-top.c: Update.
2927         * exec.c: Update.
2928         * f-valprint.c: Update.
2929         * fbsd-tdep.c: Update.
2930         * frame-unwind.c: Update.
2931         * frame.c: Update.
2932         * gdbtypes.c: Update.
2933         * gnu-v3-abi.c: Update.
2934         * guile/guile-internal.h: Update.
2935         * guile/scm-block.c: Update.
2936         * guile/scm-breakpoint.c: Update.
2937         * guile/scm-cmd.c: Update.
2938         * guile/scm-disasm.c: Update.
2939         * guile/scm-frame.c: Update.
2940         * guile/scm-lazy-string.c: Update.
2941         * guile/scm-math.c: Update.
2942         * guile/scm-param.c: Update.
2943         * guile/scm-ports.c: Update.
2944         * guile/scm-pretty-print.c: Update.
2945         * guile/scm-symbol.c: Update.
2946         * guile/scm-symtab.c: Update.
2947         * guile/scm-type.c: Update.
2948         * guile/scm-value.c: Update.
2949         * i386-linux-tdep.c: Update.
2950         * i386-tdep.c: Update.
2951         * inf-loop.c: Update.
2952         * infcall.c: Update.
2953         * infcmd.c: Update.
2954         * infrun.c: Update.
2955         * jit.c: Update.
2956         * language.c: Update.
2957         * linespec.c: Update.
2958         * linux-fork.c: Update.
2959         * linux-nat.c: Update.
2960         * linux-tdep.c: Update.
2961         * linux-thread-db.c: Update.
2962         * main.c: Update.
2963         * mi/mi-cmd-break.c: Update.
2964         * mi/mi-cmd-stack.c: Update.
2965         * mi/mi-interp.c: Update.
2966         * mi/mi-main.c: Update.
2967         * objc-lang.c: Update.
2968         * p-valprint.c: Update.
2969         * parse.c: Update.
2970         * ppc-linux-tdep.c: Update.
2971         * printcmd.c: Update.
2972         * python/py-arch.c: Update.
2973         * python/py-breakpoint.c: Update.
2974         * python/py-cmd.c: Update.
2975         * python/py-finishbreakpoint.c: Update.
2976         * python/py-frame.c: Update.
2977         * python/py-framefilter.c: Update.
2978         * python/py-gdb-readline.c: Update.
2979         * python/py-inferior.c: Update.
2980         * python/py-infthread.c: Update.
2981         * python/py-lazy-string.c: Update.
2982         * python/py-linetable.c: Update.
2983         * python/py-objfile.c: Update.
2984         * python/py-param.c: Update.
2985         * python/py-prettyprint.c: Update.
2986         * python/py-progspace.c: Update.
2987         * python/py-record-btrace.c: Update.
2988         * python/py-record.c: Update.
2989         * python/py-symbol.c: Update.
2990         * python/py-type.c: Update.
2991         * python/py-unwind.c: Update.
2992         * python/py-utils.c: Update.
2993         * python/py-value.c: Update.
2994         * python/python.c: Update.
2995         * record-btrace.c: Update.
2996         * record-full.c: Update.
2997         * remote-fileio.c: Update.
2998         * remote.c: Update.
2999         * riscv-tdep.c: Update.
3000         * rs6000-aix-tdep.c: Update.
3001         * rs6000-tdep.c: Update.
3002         * rust-exp.y: Update.
3003         * rust-lang.c: Update.
3004         * s390-tdep.c: Update.
3005         * selftest-arch.c: Update.
3006         * solib-dsbt.c: Update.
3007         * solib-frv.c: Update.
3008         * solib-spu.c: Update.
3009         * solib-svr4.c: Update.
3010         * solib.c: Update.
3011         * sparc64-linux-tdep.c: Update.
3012         * stack.c: Update.
3013         * symfile-mem.c: Update.
3014         * symmisc.c: Update.
3015         * target.c: Update.
3016         * thread.c: Update.
3017         * top.c: Update.
3018         * tracefile-tfile.c: Update.
3019         * tui/tui.c: Update.
3020         * typeprint.c: Update.
3021         * unittests/cli-utils-selftests.c: Update.
3022         * unittests/parse-connection-spec-selftests.c: Update.
3023         * valops.c: Update.
3024         * valprint.c: Update.
3025         * value.c: Update.
3026         * varobj.c: Update.
3027         * windows-nat.c: Update.
3028         * x86-linux-nat.c: Update.
3029         * xml-support.c: Update.
3030
3031 2019-04-08  Tom Tromey  <tom@tromey.com>
3032
3033         * xml-support.c: Use C++ exception handling.
3034         * x86-linux-nat.c: Use C++ exception handling.
3035         * windows-nat.c: Use C++ exception handling.
3036         * varobj.c: Use C++ exception handling.
3037         * value.c: Use C++ exception handling.
3038         * valprint.c: Use C++ exception handling.
3039         * valops.c: Use C++ exception handling.
3040         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3041         handling.
3042         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3043         * typeprint.c: Use C++ exception handling.
3044         * tui/tui.c: Use C++ exception handling.
3045         * tracefile-tfile.c: Use C++ exception handling.
3046         * top.c: Use C++ exception handling.
3047         * thread.c: Use C++ exception handling.
3048         * target.c: Use C++ exception handling.
3049         * symmisc.c: Use C++ exception handling.
3050         * symfile-mem.c: Use C++ exception handling.
3051         * stack.c: Use C++ exception handling.
3052         * sparc64-linux-tdep.c: Use C++ exception handling.
3053         * solib.c: Use C++ exception handling.
3054         * solib-svr4.c: Use C++ exception handling.
3055         * solib-spu.c: Use C++ exception handling.
3056         * solib-frv.c: Use C++ exception handling.
3057         * solib-dsbt.c: Use C++ exception handling.
3058         * selftest-arch.c: Use C++ exception handling.
3059         * s390-tdep.c: Use C++ exception handling.
3060         * rust-lang.c: Use C++ exception handling.
3061         * rust-exp.y: Use C++ exception handling.
3062         * rs6000-tdep.c: Use C++ exception handling.
3063         * rs6000-aix-tdep.c: Use C++ exception handling.
3064         * riscv-tdep.c: Use C++ exception handling.
3065         * remote.c: Use C++ exception handling.
3066         * remote-fileio.c: Use C++ exception handling.
3067         * record-full.c: Use C++ exception handling.
3068         * record-btrace.c: Use C++ exception handling.
3069         * python/python.c: Use C++ exception handling.
3070         * python/py-value.c: Use C++ exception handling.
3071         * python/py-utils.c: Use C++ exception handling.
3072         * python/py-unwind.c: Use C++ exception handling.
3073         * python/py-type.c: Use C++ exception handling.
3074         * python/py-symbol.c: Use C++ exception handling.
3075         * python/py-record.c: Use C++ exception handling.
3076         * python/py-record-btrace.c: Use C++ exception handling.
3077         * python/py-progspace.c: Use C++ exception handling.
3078         * python/py-prettyprint.c: Use C++ exception handling.
3079         * python/py-param.c: Use C++ exception handling.
3080         * python/py-objfile.c: Use C++ exception handling.
3081         * python/py-linetable.c: Use C++ exception handling.
3082         * python/py-lazy-string.c: Use C++ exception handling.
3083         * python/py-infthread.c: Use C++ exception handling.
3084         * python/py-inferior.c: Use C++ exception handling.
3085         * python/py-gdb-readline.c: Use C++ exception handling.
3086         * python/py-framefilter.c: Use C++ exception handling.
3087         * python/py-frame.c: Use C++ exception handling.
3088         * python/py-finishbreakpoint.c: Use C++ exception handling.
3089         * python/py-cmd.c: Use C++ exception handling.
3090         * python/py-breakpoint.c: Use C++ exception handling.
3091         * python/py-arch.c: Use C++ exception handling.
3092         * printcmd.c: Use C++ exception handling.
3093         * ppc-linux-tdep.c: Use C++ exception handling.
3094         * parse.c: Use C++ exception handling.
3095         * p-valprint.c: Use C++ exception handling.
3096         * objc-lang.c: Use C++ exception handling.
3097         * mi/mi-main.c: Use C++ exception handling.
3098         * mi/mi-interp.c: Use C++ exception handling.
3099         * mi/mi-cmd-stack.c: Use C++ exception handling.
3100         * mi/mi-cmd-break.c: Use C++ exception handling.
3101         * main.c: Use C++ exception handling.
3102         * linux-thread-db.c: Use C++ exception handling.
3103         * linux-tdep.c: Use C++ exception handling.
3104         * linux-nat.c: Use C++ exception handling.
3105         * linux-fork.c: Use C++ exception handling.
3106         * linespec.c: Use C++ exception handling.
3107         * language.c: Use C++ exception handling.
3108         * jit.c: Use C++ exception handling.
3109         * infrun.c: Use C++ exception handling.
3110         * infcmd.c: Use C++ exception handling.
3111         * infcall.c: Use C++ exception handling.
3112         * inf-loop.c: Use C++ exception handling.
3113         * i386-tdep.c: Use C++ exception handling.
3114         * i386-linux-tdep.c: Use C++ exception handling.
3115         * guile/scm-value.c: Use C++ exception handling.
3116         * guile/scm-type.c: Use C++ exception handling.
3117         * guile/scm-symtab.c: Use C++ exception handling.
3118         * guile/scm-symbol.c: Use C++ exception handling.
3119         * guile/scm-pretty-print.c: Use C++ exception handling.
3120         * guile/scm-ports.c: Use C++ exception handling.
3121         * guile/scm-param.c: Use C++ exception handling.
3122         * guile/scm-math.c: Use C++ exception handling.
3123         * guile/scm-lazy-string.c: Use C++ exception handling.
3124         * guile/scm-frame.c: Use C++ exception handling.
3125         * guile/scm-disasm.c: Use C++ exception handling.
3126         * guile/scm-cmd.c: Use C++ exception handling.
3127         * guile/scm-breakpoint.c: Use C++ exception handling.
3128         * guile/scm-block.c: Use C++ exception handling.
3129         * guile/guile-internal.h: Use C++ exception handling.
3130         * gnu-v3-abi.c: Use C++ exception handling.
3131         * gdbtypes.c: Use C++ exception handling.
3132         * frame.c: Use C++ exception handling.
3133         * frame-unwind.c: Use C++ exception handling.
3134         * fbsd-tdep.c: Use C++ exception handling.
3135         * f-valprint.c: Use C++ exception handling.
3136         * exec.c: Use C++ exception handling.
3137         * event-top.c: Use C++ exception handling.
3138         * event-loop.c: Use C++ exception handling.
3139         * eval.c: Use C++ exception handling.
3140         * dwarf2read.c: Use C++ exception handling.
3141         * dwarf2loc.c: Use C++ exception handling.
3142         * dwarf2-frame.c: Use C++ exception handling.
3143         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3144         * dwarf-index-write.c: Use C++ exception handling.
3145         * dwarf-index-cache.c: Use C++ exception handling.
3146         * dtrace-probe.c: Use C++ exception handling.
3147         * disasm-selftests.c: Use C++ exception handling.
3148         * darwin-nat.c: Use C++ exception handling.
3149         * cp-valprint.c: Use C++ exception handling.
3150         * cp-support.c: Use C++ exception handling.
3151         * cp-abi.c: Use C++ exception handling.
3152         * corelow.c: Use C++ exception handling.
3153         * completer.c: Use C++ exception handling.
3154         * compile/compile-object-run.c: Use C++ exception handling.
3155         * compile/compile-object-load.c: Use C++ exception handling.
3156         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3157         * compile/compile-c-symbols.c: Use C++ exception handling.
3158         * common/selftest.c: Use C++ exception handling.
3159         * common/new-op.c: Use C++ exception handling.
3160         * cli/cli-script.c: Use C++ exception handling.
3161         * cli/cli-interp.c: Use C++ exception handling.
3162         * cli/cli-cmds.c: Use C++ exception handling.
3163         * c-varobj.c: Use C++ exception handling.
3164         * btrace.c: Use C++ exception handling.
3165         * breakpoint.c: Use C++ exception handling.
3166         * break-catch-throw.c: Use C++ exception handling.
3167         * arch-utils.c: Use C++ exception handling.
3168         * amd64-tdep.c: Use C++ exception handling.
3169         * ada-valprint.c: Use C++ exception handling.
3170         * ada-typeprint.c: Use C++ exception handling.
3171         * ada-lang.c: Use C++ exception handling.
3172         * aarch64-tdep.c: Use C++ exception handling.
3173
3174 2019-04-08  Tom Tromey  <tom@tromey.com>
3175
3176         * xml-support.c (gdb_xml_parser::parse): Update.
3177         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3178         * value.c (show_convenience): Update.
3179         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3180         (test_parse_flags_qcs): Update.
3181         * thread.c (thr_try_catch_cmd): Update.
3182         * target.c (target_translate_tls_address): Update.
3183         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3184         (info_frame_command_core, frame_apply_command_count): Update.
3185         * rust-exp.y (rust_lex_exception_test): Update.
3186         * riscv-tdep.c (riscv_print_one_register_info): Update.
3187         * remote.c (remote_target::enable_btrace): Update.
3188         * record-btrace.c (record_btrace_enable_warn): Update.
3189         * python/py-utils.c (gdbpy_convert_exception): Update.
3190         * printcmd.c (do_one_display, print_variable_and_value): Update.
3191         * mi/mi-main.c (mi_print_exception): Update.
3192         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3193         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3194         * linux-nat.c (linux_nat_target::attach): Update.
3195         * linux-fork.c (class scoped_switch_fork_info): Update.
3196         * infrun.c (displaced_step_prepare): Update.
3197         * infcall.c (call_function_by_hand_dummy): Update.
3198         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3199         * gnu-v3-abi.c (print_one_vtable): Update.
3200         * frame.c (get_prev_frame_always): Update.
3201         * f-valprint.c (info_common_command_for_block): Update.
3202         * exec.c (try_open_exec_file): Update.
3203         * exceptions.c (print_exception, exception_print)
3204         (exception_fprintf, exception_print_same): Update.
3205         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3206         * dwarf-index-cache.c (index_cache::store)
3207         (index_cache::lookup_gdb_index): Update.
3208         * darwin-nat.c (maybe_cache_shell): Update.
3209         * cp-valprint.c (cp_print_value_fields): Update.
3210         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3211         (gcc_cplus_symbol_address): Update.
3212         * compile/compile-c-symbols.c (gcc_convert_symbol)
3213         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3214         * common/selftest.c: Update.
3215         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3216         a std::string.
3217         (exception_try_scope_entry, exception_try_scope_exit): Don't
3218         declare.
3219         (struct exception_try_scope): Remove.
3220         (TRY): Don't use exception_try_scope.
3221         (struct gdb_exception): Add constructor, operator=.
3222         <what>: New method.
3223         (struct gdb_exception_RETURN_MASK_ALL)
3224         (struct gdb_exception_RETURN_MASK_ERROR)
3225         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3226         (struct gdb_quit_bad_alloc): Update.
3227         * common/common-exceptions.c (exception_none): Change
3228         initializer.
3229         (struct catcher) <state, exception>: Initialize inline.
3230         <prev>: Remove member.
3231         (current_catcher): Remove.
3232         (catchers): New global.
3233         (exceptions_state_mc_init): Simplify.
3234         (catcher_pop): Remove.
3235         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3236         (try_scope_depth, exception_try_scope_entry)
3237         (exception_try_scope_exit): Remove.
3238         (throw_exception_sjlj): Update.
3239         (exception_messages, exception_messages_size): Remove.
3240         (throw_it): Simplify.
3241         (gdb_exception_sliced_copy): Remove.
3242         (throw_exception_cxx): Update.
3243         * cli/cli-script.c (script_from_file): Update.
3244         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3245         Update.
3246         * ada-valprint.c (ada_val_print): Update.
3247         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3248         (create_excep_cond_exprs): Update.
3249
3250 2019-04-08  Tom Tromey  <tom@tromey.com>
3251
3252         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3253         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3254         (TRY, CATCH, END_CATCH): Remove some definitions.
3255         * common/common-exceptions.c: Don't use GDB_XCPT.
3256         (catcher_list_size): Remove.
3257         (throw_exception, throw_it): Simplify.
3258
3259 2019-04-05  Tom Tromey  <tom@tromey.com>
3260
3261         Revert the header-sorting patch.
3262         * ft32-tdep.c: Revert.
3263         * frv-tdep.c: Revert.
3264         * frv-linux-tdep.c: Revert.
3265         * frame.c: Revert.
3266         * frame-unwind.c: Revert.
3267         * frame-base.c: Revert.
3268         * fork-child.c: Revert.
3269         * findvar.c: Revert.
3270         * findcmd.c: Revert.
3271         * filesystem.c: Revert.
3272         * filename-seen-cache.h: Revert.
3273         * filename-seen-cache.c: Revert.
3274         * fbsd-tdep.c: Revert.
3275         * fbsd-nat.h: Revert.
3276         * fbsd-nat.c: Revert.
3277         * f-valprint.c: Revert.
3278         * f-typeprint.c: Revert.
3279         * f-lang.c: Revert.
3280         * extension.h: Revert.
3281         * extension.c: Revert.
3282         * extension-priv.h: Revert.
3283         * expprint.c: Revert.
3284         * exec.h: Revert.
3285         * exec.c: Revert.
3286         * exceptions.c: Revert.
3287         * event-top.c: Revert.
3288         * event-loop.c: Revert.
3289         * eval.c: Revert.
3290         * elfread.c: Revert.
3291         * dwarf2read.h: Revert.
3292         * dwarf2read.c: Revert.
3293         * dwarf2loc.c: Revert.
3294         * dwarf2expr.h: Revert.
3295         * dwarf2expr.c: Revert.
3296         * dwarf2-frame.c: Revert.
3297         * dwarf2-frame-tailcall.c: Revert.
3298         * dwarf-index-write.h: Revert.
3299         * dwarf-index-write.c: Revert.
3300         * dwarf-index-common.c: Revert.
3301         * dwarf-index-cache.h: Revert.
3302         * dwarf-index-cache.c: Revert.
3303         * dummy-frame.c: Revert.
3304         * dtrace-probe.c: Revert.
3305         * disasm.h: Revert.
3306         * disasm.c: Revert.
3307         * disasm-selftests.c: Revert.
3308         * dictionary.c: Revert.
3309         * dicos-tdep.c: Revert.
3310         * demangle.c: Revert.
3311         * dcache.h: Revert.
3312         * dcache.c: Revert.
3313         * darwin-nat.h: Revert.
3314         * darwin-nat.c: Revert.
3315         * darwin-nat-info.c: Revert.
3316         * d-valprint.c: Revert.
3317         * d-namespace.c: Revert.
3318         * d-lang.c: Revert.
3319         * ctf.c: Revert.
3320         * csky-tdep.c: Revert.
3321         * csky-linux-tdep.c: Revert.
3322         * cris-tdep.c: Revert.
3323         * cris-linux-tdep.c: Revert.
3324         * cp-valprint.c: Revert.
3325         * cp-support.c: Revert.
3326         * cp-namespace.c: Revert.
3327         * cp-abi.c: Revert.
3328         * corelow.c: Revert.
3329         * corefile.c: Revert.
3330         * continuations.c: Revert.
3331         * completer.h: Revert.
3332         * completer.c: Revert.
3333         * complaints.c: Revert.
3334         * coffread.c: Revert.
3335         * coff-pe-read.c: Revert.
3336         * cli-out.h: Revert.
3337         * cli-out.c: Revert.
3338         * charset.c: Revert.
3339         * c-varobj.c: Revert.
3340         * c-valprint.c: Revert.
3341         * c-typeprint.c: Revert.
3342         * c-lang.c: Revert.
3343         * buildsym.c: Revert.
3344         * buildsym-legacy.c: Revert.
3345         * build-id.h: Revert.
3346         * build-id.c: Revert.
3347         * btrace.c: Revert.
3348         * bsd-uthread.c: Revert.
3349         * breakpoint.h: Revert.
3350         * breakpoint.c: Revert.
3351         * break-catch-throw.c: Revert.
3352         * break-catch-syscall.c: Revert.
3353         * break-catch-sig.c: Revert.
3354         * blockframe.c: Revert.
3355         * block.c: Revert.
3356         * bfin-tdep.c: Revert.
3357         * bfin-linux-tdep.c: Revert.
3358         * bfd-target.c: Revert.
3359         * bcache.c: Revert.
3360         * ax-general.c: Revert.
3361         * ax-gdb.h: Revert.
3362         * ax-gdb.c: Revert.
3363         * avr-tdep.c: Revert.
3364         * auxv.c: Revert.
3365         * auto-load.c: Revert.
3366         * arm-wince-tdep.c: Revert.
3367         * arm-tdep.c: Revert.
3368         * arm-symbian-tdep.c: Revert.
3369         * arm-pikeos-tdep.c: Revert.
3370         * arm-obsd-tdep.c: Revert.
3371         * arm-nbsd-tdep.c: Revert.
3372         * arm-nbsd-nat.c: Revert.
3373         * arm-linux-tdep.c: Revert.
3374         * arm-linux-nat.c: Revert.
3375         * arm-fbsd-tdep.c: Revert.
3376         * arm-fbsd-nat.c: Revert.
3377         * arm-bsd-tdep.c: Revert.
3378         * arch-utils.c: Revert.
3379         * arc-tdep.c: Revert.
3380         * arc-newlib-tdep.c: Revert.
3381         * annotate.h: Revert.
3382         * annotate.c: Revert.
3383         * amd64-windows-tdep.c: Revert.
3384         * amd64-windows-nat.c: Revert.
3385         * amd64-tdep.c: Revert.
3386         * amd64-sol2-tdep.c: Revert.
3387         * amd64-obsd-tdep.c: Revert.
3388         * amd64-obsd-nat.c: Revert.
3389         * amd64-nbsd-tdep.c: Revert.
3390         * amd64-nbsd-nat.c: Revert.
3391         * amd64-nat.c: Revert.
3392         * amd64-linux-tdep.c: Revert.
3393         * amd64-linux-nat.c: Revert.
3394         * amd64-fbsd-tdep.c: Revert.
3395         * amd64-fbsd-nat.c: Revert.
3396         * amd64-dicos-tdep.c: Revert.
3397         * amd64-darwin-tdep.c: Revert.
3398         * amd64-bsd-nat.c: Revert.
3399         * alpha-tdep.c: Revert.
3400         * alpha-obsd-tdep.c: Revert.
3401         * alpha-nbsd-tdep.c: Revert.
3402         * alpha-mdebug-tdep.c: Revert.
3403         * alpha-linux-tdep.c: Revert.
3404         * alpha-linux-nat.c: Revert.
3405         * alpha-bsd-tdep.c: Revert.
3406         * alpha-bsd-nat.c: Revert.
3407         * aix-thread.c: Revert.
3408         * agent.c: Revert.
3409         * addrmap.c: Revert.
3410         * ada-varobj.c: Revert.
3411         * ada-valprint.c: Revert.
3412         * ada-typeprint.c: Revert.
3413         * ada-tasks.c: Revert.
3414         * ada-lang.c: Revert.
3415         * aarch64-tdep.c: Revert.
3416         * aarch64-ravenscar-thread.c: Revert.
3417         * aarch64-newlib-tdep.c: Revert.
3418         * aarch64-linux-tdep.c: Revert.
3419         * aarch64-linux-nat.c: Revert.
3420         * aarch64-fbsd-tdep.c: Revert.
3421         * aarch64-fbsd-nat.c: Revert.
3422         * aarch32-linux-nat.c: Revert.
3423
3424 2019-04-05  Tom Tromey  <tom@tromey.com>
3425
3426         * ft32-tdep.c: Sort headers.
3427         * frv-tdep.c: Sort headers.
3428         * frv-linux-tdep.c: Sort headers.
3429         * frame.c: Sort headers.
3430         * frame-unwind.c: Sort headers.
3431         * frame-base.c: Sort headers.
3432         * fork-child.c: Sort headers.
3433         * findvar.c: Sort headers.
3434         * findcmd.c: Sort headers.
3435         * filesystem.c: Sort headers.
3436         * filename-seen-cache.h: Sort headers.
3437         * filename-seen-cache.c: Sort headers.
3438         * fbsd-tdep.c: Sort headers.
3439         * fbsd-nat.h: Sort headers.
3440         * fbsd-nat.c: Sort headers.
3441         * f-valprint.c: Sort headers.
3442         * f-typeprint.c: Sort headers.
3443         * f-lang.c: Sort headers.
3444         * extension.h: Sort headers.
3445         * extension.c: Sort headers.
3446         * extension-priv.h: Sort headers.
3447         * expprint.c: Sort headers.
3448         * exec.h: Sort headers.
3449         * exec.c: Sort headers.
3450         * exceptions.c: Sort headers.
3451         * event-top.c: Sort headers.
3452         * event-loop.c: Sort headers.
3453         * eval.c: Sort headers.
3454         * elfread.c: Sort headers.
3455         * dwarf2read.h: Sort headers.
3456         * dwarf2read.c: Sort headers.
3457         * dwarf2loc.c: Sort headers.
3458         * dwarf2expr.h: Sort headers.
3459         * dwarf2expr.c: Sort headers.
3460         * dwarf2-frame.c: Sort headers.
3461         * dwarf2-frame-tailcall.c: Sort headers.
3462         * dwarf-index-write.h: Sort headers.
3463         * dwarf-index-write.c: Sort headers.
3464         * dwarf-index-common.c: Sort headers.
3465         * dwarf-index-cache.h: Sort headers.
3466         * dwarf-index-cache.c: Sort headers.
3467         * dummy-frame.c: Sort headers.
3468         * dtrace-probe.c: Sort headers.
3469         * disasm.h: Sort headers.
3470         * disasm.c: Sort headers.
3471         * disasm-selftests.c: Sort headers.
3472         * dictionary.c: Sort headers.
3473         * dicos-tdep.c: Sort headers.
3474         * demangle.c: Sort headers.
3475         * dcache.h: Sort headers.
3476         * dcache.c: Sort headers.
3477         * darwin-nat.h: Sort headers.
3478         * darwin-nat.c: Sort headers.
3479         * darwin-nat-info.c: Sort headers.
3480         * d-valprint.c: Sort headers.
3481         * d-namespace.c: Sort headers.
3482         * d-lang.c: Sort headers.
3483         * ctf.c: Sort headers.
3484         * csky-tdep.c: Sort headers.
3485         * csky-linux-tdep.c: Sort headers.
3486         * cris-tdep.c: Sort headers.
3487         * cris-linux-tdep.c: Sort headers.
3488         * cp-valprint.c: Sort headers.
3489         * cp-support.c: Sort headers.
3490         * cp-namespace.c: Sort headers.
3491         * cp-abi.c: Sort headers.
3492         * corelow.c: Sort headers.
3493         * corefile.c: Sort headers.
3494         * continuations.c: Sort headers.
3495         * completer.h: Sort headers.
3496         * completer.c: Sort headers.
3497         * complaints.c: Sort headers.
3498         * coffread.c: Sort headers.
3499         * coff-pe-read.c: Sort headers.
3500         * cli-out.h: Sort headers.
3501         * cli-out.c: Sort headers.
3502         * charset.c: Sort headers.
3503         * c-varobj.c: Sort headers.
3504         * c-valprint.c: Sort headers.
3505         * c-typeprint.c: Sort headers.
3506         * c-lang.c: Sort headers.
3507         * buildsym.c: Sort headers.
3508         * buildsym-legacy.c: Sort headers.
3509         * build-id.h: Sort headers.
3510         * build-id.c: Sort headers.
3511         * btrace.c: Sort headers.
3512         * bsd-uthread.c: Sort headers.
3513         * breakpoint.h: Sort headers.
3514         * breakpoint.c: Sort headers.
3515         * break-catch-throw.c: Sort headers.
3516         * break-catch-syscall.c: Sort headers.
3517         * break-catch-sig.c: Sort headers.
3518         * blockframe.c: Sort headers.
3519         * block.c: Sort headers.
3520         * bfin-tdep.c: Sort headers.
3521         * bfin-linux-tdep.c: Sort headers.
3522         * bfd-target.c: Sort headers.
3523         * bcache.c: Sort headers.
3524         * ax-general.c: Sort headers.
3525         * ax-gdb.h: Sort headers.
3526         * ax-gdb.c: Sort headers.
3527         * avr-tdep.c: Sort headers.
3528         * auxv.c: Sort headers.
3529         * auto-load.c: Sort headers.
3530         * arm-wince-tdep.c: Sort headers.
3531         * arm-tdep.c: Sort headers.
3532         * arm-symbian-tdep.c: Sort headers.
3533         * arm-pikeos-tdep.c: Sort headers.
3534         * arm-obsd-tdep.c: Sort headers.
3535         * arm-nbsd-tdep.c: Sort headers.
3536         * arm-nbsd-nat.c: Sort headers.
3537         * arm-linux-tdep.c: Sort headers.
3538         * arm-linux-nat.c: Sort headers.
3539         * arm-fbsd-tdep.c: Sort headers.
3540         * arm-fbsd-nat.c: Sort headers.
3541         * arm-bsd-tdep.c: Sort headers.
3542         * arch-utils.c: Sort headers.
3543         * arc-tdep.c: Sort headers.
3544         * arc-newlib-tdep.c: Sort headers.
3545         * annotate.h: Sort headers.
3546         * annotate.c: Sort headers.
3547         * amd64-windows-tdep.c: Sort headers.
3548         * amd64-windows-nat.c: Sort headers.
3549         * amd64-tdep.c: Sort headers.
3550         * amd64-sol2-tdep.c: Sort headers.
3551         * amd64-obsd-tdep.c: Sort headers.
3552         * amd64-obsd-nat.c: Sort headers.
3553         * amd64-nbsd-tdep.c: Sort headers.
3554         * amd64-nbsd-nat.c: Sort headers.
3555         * amd64-nat.c: Sort headers.
3556         * amd64-linux-tdep.c: Sort headers.
3557         * amd64-linux-nat.c: Sort headers.
3558         * amd64-fbsd-tdep.c: Sort headers.
3559         * amd64-fbsd-nat.c: Sort headers.
3560         * amd64-dicos-tdep.c: Sort headers.
3561         * amd64-darwin-tdep.c: Sort headers.
3562         * amd64-bsd-nat.c: Sort headers.
3563         * alpha-tdep.c: Sort headers.
3564         * alpha-obsd-tdep.c: Sort headers.
3565         * alpha-nbsd-tdep.c: Sort headers.
3566         * alpha-mdebug-tdep.c: Sort headers.
3567         * alpha-linux-tdep.c: Sort headers.
3568         * alpha-linux-nat.c: Sort headers.
3569         * alpha-bsd-tdep.c: Sort headers.
3570         * alpha-bsd-nat.c: Sort headers.
3571         * aix-thread.c: Sort headers.
3572         * agent.c: Sort headers.
3573         * addrmap.c: Sort headers.
3574         * ada-varobj.c: Sort headers.
3575         * ada-valprint.c: Sort headers.
3576         * ada-typeprint.c: Sort headers.
3577         * ada-tasks.c: Sort headers.
3578         * ada-lang.c: Sort headers.
3579         * aarch64-tdep.c: Sort headers.
3580         * aarch64-ravenscar-thread.c: Sort headers.
3581         * aarch64-newlib-tdep.c: Sort headers.
3582         * aarch64-linux-tdep.c: Sort headers.
3583         * aarch64-linux-nat.c: Sort headers.
3584         * aarch64-fbsd-tdep.c: Sort headers.
3585         * aarch64-fbsd-nat.c: Sort headers.
3586         * aarch32-linux-nat.c: Sort headers.
3587
3588 2019-04-04  Tom Tromey  <tom@tromey.com>
3589
3590         * varobj.c (varobj_create): Update.
3591         * rust-exp.y (struct rust_parser) <update_innermost_block,
3592         lookup_symbol>: New methods.
3593         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3594         Rename.
3595         (rust_parser::rust_lookup_type)
3596         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3597         * printcmd.c (display_command, do_one_display): Update.
3598         * parser-defs.h (struct parser_state) <parser_state>: Add
3599         "tracker" parameter.
3600         (block_tracker): New member.
3601         (class innermost_block_tracker) <innermost_block_tracker>: Add
3602         "types" parameter.
3603         <reset>: Remove method.
3604         (innermost_block): Don't declare.
3605         (null_post_parser): Update.
3606         * parse.c (innermost_block): Remove global.
3607         (write_dollar_variable): Update.
3608         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3609         Remove "tracker_types" parameter.
3610         (parse_expression): Add "tracker" parameter.
3611         (parse_expression_for_completion): Update.
3612         (null_post_parser): Add "tracker" parameter.
3613         * p-exp.y: Update rules.
3614         * m2-exp.y: Update rules.
3615         * language.h (struct language_defn) <la_post_parser>: Add
3616         "tracker" parameter.
3617         * go-exp.y: Update rules.
3618         * f-exp.y: Update rules.
3619         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3620         parameter.
3621         * d-exp.y: Update rules.
3622         * c-exp.y: Update rules.
3623         * breakpoint.c (set_breakpoint_condition): Create an
3624         innermost_block_tracker.
3625         (watch_command_1): Likewise.
3626         * ada-lang.c (resolve): Add "tracker" parameter.
3627         (resolve_subexp): Likewise.
3628         * ada-exp.y (write_var_from_sym): Update.
3629
3630 2019-04-04  Tom Tromey  <tom@tromey.com>
3631
3632         * type-stack.h: New file.
3633         * type-stack.c: New file.
3634         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3635         type-stack.h.
3636         (insert_into_type_stack, insert_type, push_type, push_type_int)
3637         (insert_type_address_space, pop_type, pop_type_int)
3638         (pop_typelist, pop_type_stack, append_type_stack)
3639         (push_type_stack, get_type_stack, push_typelist)
3640         (follow_type_instance_flags, follow_types): Don't declare.
3641         * parse.c (type_stack): Remove global.
3642         (parse_exp_in_context): Update.
3643         (insert_into_type_stack, insert_type, push_type, push_type_int)
3644         (insert_type_address_space, pop_type, pop_type_int)
3645         (pop_typelist, pop_type_stack, append_type_stack)
3646         (push_type_stack, get_type_stack, push_typelist)
3647         (follow_type_instance_flags, follow_types): Remove (moved to
3648         type-stack.c).
3649         * f-exp.y (type_stack): New global.
3650         Update rules.
3651         (push_kind_type, f_parse): Update.
3652         * d-exp.y (type_stack): New global.
3653         Update rules.
3654         (d_parse): Update.
3655         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3656         Update rules.
3657         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3658         (HFILES_NO_SRCDIR): Add type-stack.h.
3659
3660 2019-04-04  Tom Tromey  <tom@tromey.com>
3661
3662         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3663         (rust_parser::convert_ast_to_expression, rust_parse)
3664         (rust_lex_test_completion, rust_lex_tests): Update.
3665         * parser-defs.h (struct expr_completion_state): New.
3666         (struct parser_state) <parser_state>: Add completion parameter.
3667         <mark_struct_expression, mark_completion_tag>: New methods.
3668         <parse_completion, m_completion_state>: New members.
3669         (prefixify_expression, null_post_parser): Update.
3670         (mark_struct_expression, mark_completion_tag): Don't declare.
3671         * parse.c (parse_completion, expout_last_struct)
3672         (expout_tag_completion_type, expout_completion_name): Remove
3673         globals.
3674         (parser_state::mark_struct_expression)
3675         (parser_state::mark_completion_tag): Now methods.
3676         (prefixify_expression): Add last_struct parameter.
3677         (prefixify_subexp): Likewise.
3678         (parse_exp_1): Update.
3679         (parse_exp_in_context): Add cstate parameter.  Update.
3680         (parse_expression_for_completion): Create an
3681         expr_completion_state.
3682         (null_post_parser): Add "completion" parameter.
3683         * p-exp.y: Update rules.
3684         (yylex): Update.
3685         * language.h (struct language_defn) <la_post_parser>: Add
3686         "completing" parameter.
3687         * go-exp.y: Update rules.
3688         (lex_one_token): Update.
3689         * expression.h (parse_completion): Don't declare.
3690         * d-exp.y: Update rules.
3691         (lex_one_token): Update rules.
3692         * c-exp.y: Update rules.
3693         (lex_one_token): Update.
3694         * ada-lang.c (resolve): Add "parse_completion" parameter.
3695         (resolve_subexp): Likewise.
3696         (ada_resolve_function): Likewise.
3697
3698 2019-04-04  Tom Tromey  <tom@tromey.com>
3699
3700         * parser-defs.h (struct parser_state) <start_arglist,
3701         end_arglist>: New methods.
3702         <arglist_len, m_funcall_chain>: New members.
3703         (arglist_len, start_arglist, end_arglist): Don't declare.
3704         * parse.c (arglist_len, funcall_chain): Remove global.
3705         (start_arglist, end_arglist): Remove functions.
3706         (parse_exp_in_context): Update.
3707         * p-exp.y: Update rules.
3708         * m2-exp.y: Update rules.
3709         * go-exp.y: Update rules.
3710         * f-exp.y: Update rules.
3711         * d-exp.y: Update rules.
3712         * c-exp.y: Update rules.
3713
3714 2019-04-04  Tom Tromey  <tom@tromey.com>
3715
3716         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3717         lex_operator, push_back>: New methods.
3718         Update all rules.
3719         (rust_parser::lex_hex, lex_escape): Rename and update.
3720         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3721         (rust_parser::lex_operator): Rename and update.
3722         (rust_parser::lex_number, rustyylex, rustyyerror)
3723         (rust_lex_test_init, rust_lex_test_sequence)
3724         (rust_lex_test_push_back, rust_lex_tests): Update.
3725         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3726         parameter.
3727         <lexptr, prev_lexptr>: New members.
3728         (lexptr, prev_lexptr): Don't declare.
3729         * parse.c (lexptr, prev_lexptr): Remove globals.
3730         (parse_exp_in_context): Update.
3731         * p-exp.y (yylex, yyerror): Update.
3732         * m2-exp.y (parse_number, yylex, yyerror): Update.
3733         * go-exp.y (lex_one_token, yyerror): Update.
3734         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3735         * d-exp.y (lex_one_token, yyerror): Update.
3736         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3737         (lex_one_token, yyerror): Update.
3738         * ada-lex.l (YY_INPUT): Update.
3739         (rewind_to_char): Update.
3740         * ada-exp.y (yyerror): Update.
3741
3742 2019-04-04  Tom Tromey  <tom@tromey.com>
3743
3744         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3745         * parser-defs.h (struct parser_state) <parser_state>: Add new
3746         parameter.
3747         <comma_terminates>: New member.
3748         (comma_terminates): Don't declare global.
3749         * parse.c (comma_terminates): Remove global.
3750         (parse_exp_in_context): Update.
3751         * p-exp.y (yylex): Update.
3752         * m2-exp.y (yylex): Update.
3753         * go-exp.y (lex_one_token): Update.
3754         * f-exp.y (yylex): Update.
3755         * d-exp.y (lex_one_token): Update.
3756         * c-exp.y (lex_one_token): Update.
3757         * ada-lex.l: Update.
3758
3759 2019-04-04  Tom Tromey  <tom@tromey.com>
3760
3761         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3762         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3763         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3764         * parser-defs.h (paren_depth): Don't declare.
3765         * parse.c (paren_depth): Remove global.
3766         (parse_exp_in_context): Update.
3767         * p-exp.y (paren_depth): New global.
3768         (pascal_parse): Initialize it.
3769         * m2-exp.y (paren_depth): New global.
3770         (m2_parse): Initialize it.
3771         * go-exp.y (paren_depth): New global.
3772         (go_parse): Initialize it.
3773         * f-exp.y (paren_depth): New global.
3774         (f_parse): Initialize it.
3775         * d-exp.y (paren_depth): New global.
3776         (d_parse): Initialize it.
3777         * c-exp.y (paren_depth): New global.
3778         (c_parse): Initialize it.
3779         * ada-lex.l (paren_depth): New global.
3780         (lexer_init): Initialize it.
3781
3782 2019-04-04  Tom Tromey  <tom@tromey.com>
3783
3784         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3785         (rust_parser::convert_ast_to_type)
3786         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3787         * parser-defs.h (struct parser_state) <parser_state>: Add
3788         parameters.  Initialize new members.
3789         <expression_context_block, expression_context_pc>: New members.
3790         * parse.c (expression_context_block, expression_context_pc):
3791         Remove globals.
3792         (parse_exp_in_context): Update.
3793         * p-exp.y: Update all rules.
3794         (yylex): Update.
3795         * m2-exp.y: Update all rules.
3796         (yylex): Update.
3797         * go-exp.y (yylex): Update.
3798         * f-exp.y (yylex): Update.
3799         * d-exp.y: Update all rules.
3800         (yylex): Update.
3801         * c-exp.y: Update all rules.
3802         (lex_one_token, classify_name, yylex, c_parse): Update.
3803         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3804
3805 2019-04-04  Tom Tromey  <tom@tromey.com>
3806
3807         * gdbarch.h, gdbarch.c: Rebuild.
3808         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3809         * stap-probe.h:
3810         (struct stap_parse_info): Replace "parser_state" with
3811         "expr_builder".
3812         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3813         (parser_state): New class.
3814         * parse.c (expr_builder): Rename.
3815         (expr_builder::release): Rename.
3816         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3817         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3818         (write_exp_elt_longcst, write_exp_elt_floatcst)
3819         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3820         (write_exp_string_vector, write_exp_bitstring)
3821         (write_exp_msymbol, mark_struct_expression)
3822         (write_dollar_variable)
3823         (insert_type_address_space, increase_expout_size): Replace
3824         "parser_state" with "expr_builder".
3825         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3826         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3827         "parser_state" with "expr_builder".
3828
3829 2019-04-04  Tom Tromey  <tom@tromey.com>
3830
3831         * rust-exp.y: Replace "parse_language" with method call.
3832         * p-exp.y:
3833         (yylex): Replace "parse_language" with method call.
3834         * m2-exp.y:
3835         (yylex): Replace "parse_language" with method call.
3836         * go-exp.y (classify_name): Replace "parse_language" with method
3837         call.
3838         * f-exp.y (yylex): Replace "parse_language" with method call.
3839         * d-exp.y (lex_one_token): Replace "parse_language" with method
3840         call.
3841         * c-exp.y:
3842         (lex_one_token, classify_name, yylex): Replace "parse_language"
3843         with method call.
3844         * ada-exp.y (find_primitive_type, type_char)
3845         (type_system_address): Replace "parse_language" with method call.
3846
3847 2019-04-04  Tom Tromey  <tom@tromey.com>
3848
3849         * rust-exp.y: Replace "parse_gdbarch" with method call.
3850         * parse.c (write_dollar_variable, insert_type_address_space):
3851         Replace "parse_gdbarch" with method call.
3852         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3853         call.
3854         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3855         call.
3856         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3857         "parse_gdbarch" with method call.
3858         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3859         with method call.
3860         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3861         "parse_gdbarch" with method call.
3862         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3863         "parse_gdbarch" with method call.
3864         * c-exp.y (parse_type, parse_number, classify_name): Replace
3865         "parse_gdbarch" with method call.
3866         * ada-lex.l: Replace "parse_gdbarch" with method call.
3867         * ada-exp.y (parse_type, find_primitive_type, type_char)
3868         (type_system_address): Replace "parse_gdbarch" with method call.
3869
3870 2019-04-04  Tom Tromey  <tom@tromey.com>
3871
3872         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3873         * stap-probe.c (stap_parse_argument): Update.
3874         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3875         initial_size parameter.
3876         * rust-exp.y (rust_lex_tests): Update.
3877         * parse.c (parser_state): Update.
3878         (parse_exp_in_context): Update.
3879         * parser-defs.h (struct parser_state) <parser_state>: Remove
3880         "initial_size" parameter.
3881
3882 2019-04-04  Tom Tromey  <tom@tromey.com>
3883
3884         * parser-defs.h (increase_expout_size): Don't declare.
3885         * parse.c (increase_expout_size): Now static.
3886
3887 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3888
3889         * gnu-nat.c (gnu_nat_target::wait): Fix
3890         target_waitstatus_to_string call.
3891
3892 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * eval.c (evaluate_subexp_standard): Handle internal functions
3895         during Fortran function call handling.
3896
3897 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * NEWS: Mention new internal functions.
3900         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3901         (read_base_type): Use dwarf2_init_complex_target_type.
3902         * value.c (creal_internal_fn): New function.
3903         (cimag_internal_fn): New function.
3904         (_initialize_values): Register new internal functions.
3905
3906 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3907
3908         * infrun.c (stop_all_threads): If debug_infrun, always
3909         trace the wait status after wait_one, using
3910         target_waitstatus_to_string and target_pid_to_str.
3911         (handle_inferior_event): Replace various trace of
3912         wait status kind by a single trace.
3913         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3914         wait status kind image by target_waitstatus_to_string.
3915         * target/waitstatus.c (target_waitstatus_to_string): Fix
3916         obsolete comment.
3917
3918 2019-04-01  Tom Tromey  <tromey@adacore.com>
3919
3920         PR symtab/23331:
3921         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3922
3923 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3924             Pedro Alves  <palves@redhat.com>
3925
3926         * top.c (quit_force): Call 'finalize_values'.
3927         * value.c (finalize_values): New function.
3928         * value.h (finalize_values): Declare.
3929
3930 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3931
3932         * NEWS: Announce $_gdb_major and $_gdb_minor.
3933
3934         * top.c (init_gdb_version_vars): New function.
3935         (gdb_init): Call init_gdb_version_vars.
3936
3937 2019-03-29  Tom Tromey  <tromey@adacore.com>
3938
3939         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3940         help text.  Remove dead code.
3941
3942 2019-03-29  Keith Seitz  <keiths@redhat.com>
3943
3944         From Siddhesh Poyarekar:
3945         * f-lang.h (f77_get_upperbound): Return LONGEST.
3946         (f77_get_lowerbound): Likewise.
3947         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3948         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3949         print them.
3950         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3951         plongest to format print it.
3952         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3953         (f77_get_upperbound): Likewise.
3954         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3955         LOWER_BOUND to LONGEST.
3956         (f77_create_arrayprint_offset_tbl): Likewise.
3957
3958 2019-03-29  Keith Seitz  <keiths@redhat.com>
3959
3960         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3961         %s/pulongest for TYPE_LENGTH instead of %d in format
3962         strings.
3963         * ada-typerint.c (ada_print_type): Likewise.
3964         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3965         * compile/compile-c-support.c (generate_register_struct): Likewise.
3966         * gdbtypes.c (recursive_dump_type): Likewise.
3967         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3968         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3969         instead of %d in format strings.
3970         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3971         to std::min to ULONGEST.
3972         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3973         instead of %d in format strings.
3974         * tracepoint.c (info_scope_command): Likewise.
3975         * typeprint.c (print_offset_data::update)
3976         (print_offset_data::finish): Likewise.
3977         * xtensa-tdep.c (xtensa_store_return_value)
3978         (xtensa_push_dummy_call): Likewise.
3979
3980 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3981
3982         * windows-nat.c (display_selector): Fixed format specifications
3983         for 64-bit Cygwin.
3984
3985 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3986
3987         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3988
3989 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3990
3991         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3992         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3993         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3994         (nios2_linux_init_abi): Install it.
3995
3996 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3997
3998         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3999
4000 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4001
4002         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4003
4004 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4005             Tom Tromey  <tromey@adacore.com>
4006
4007         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4008
4009 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4010
4011         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4012         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4013         method to compute the bounds of range types. Also print "[evaluated]"
4014         if the bounds' values come from a dynamic evaluation.
4015
4016 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4017
4018         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4019         whitespace when pretty printing is on.
4020
4021 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4022
4023         * ppc-linux-nat.c: Add include.
4024
4025 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4026
4027         * NEWS: Mention AArch64 Pointer Authentication.
4028
4029 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4030
4031         * arm-linux-nat.c: Add include.
4032
4033 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4034
4035         * source-cache.c (source_cache::get_source_lines): Re-read
4036         fullname after calling open_source_file.
4037
4038 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4039
4040         * NEWS: Mention TLS support for FreeBSD.
4041
4042 2019-03-25  Tom Tromey  <tromey@adacore.com>
4043
4044         * minsyms.c (BUNCH_SIZE): Update comment.
4045         (~minimal_symbol_reader): Remove old comment.
4046         (compact_minimal_symbols): Update comment.
4047         (minimal_symbol_reader::install): Remove old comment.  Update
4048         other comments.
4049
4050 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4051
4052         * s390-linux-nat.c: Add include.
4053
4054 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4055
4056         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4057         Call linux_get_hwcap.
4058         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4059         Likewise.
4060         (aarch64_linux_get_hwcap): Remove function.
4061         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4062         declaration.
4063         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4064         linux_get_hwcap.
4065         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4066         * linux-tdep.c (linux_get_hwcap): Add function.
4067         (linux_get_hwcap2): Likewise.
4068         * linux-tdep.h (linux_get_hwcap): Add declaration.
4069         (linux_get_hwcap2): Likewise.
4070         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4071         (ppc_linux_get_hwcap2): Likewise.
4072         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4073         linux_get_hwcap.
4074         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4075         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4076         (ppc_linux_nat_target::read_description): Likewise.
4077         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4078         * s390-linux-nat.c: Likewise.
4079         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4080
4081 2019-03-24  Tom Tromey  <tom@tromey.com>
4082
4083         * ada-lang.c (standard_lookup): Simplify initialization.
4084         (ada_lookup_symbol_nonlocal): Simplify return.
4085         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4086         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4087         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4088         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4089         initialization.
4090         * solib.c (solib_global_lookup): Simplify.
4091         * symtab.c (null_block_symbol): Remove.
4092         (symbol_cache_lookup): Simplify returns.
4093         (lookup_language_this): Simplify returns.
4094         (lookup_symbol_aux): Simplify return.
4095         (lookup_local_symbol): Simplify returns.
4096         (lookup_global_symbol_from_objfile): Simplify return.
4097         (lookup_symbol_in_objfile_symtabs)
4098         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4099         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4100         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4101         * cp-namespace.c (cp_lookup_bare_symbol)
4102         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4103         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4104         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4105         (cp_lookup_symbol_via_imports): Simplify initialization.
4106         (find_symbol_in_baseclass): Likewise.
4107         * symtab.h (null_block_symbol): Remove.
4108         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4109         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4110         (d_lookup_symbol_module): Likewise.
4111         (find_symbol_in_baseclass): Simplify initialization.
4112
4113 2019-03-24  Tom Tromey  <tom@tromey.com>
4114
4115         * expression.h: Don't include symtab.h.
4116         (struct block): Forward declare.
4117
4118 2019-03-24  Tom Tromey  <tom@tromey.com>
4119
4120         * c-exp.y (typebase): Remove casts.
4121         * gdbtypes.c (lookup_unsigned_typename, )
4122         (lookup_signed_typename): Remove cast.
4123         * eval.c (parse_to_comma_and_eval): Remove cast.
4124         * parse.c (write_dollar_variable): Remove cast.
4125         * block.h (struct block) <superblock>: Now const.
4126         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4127         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4128         (map_block): Make "block" const.
4129         * symfile.h (struct quick_symbol_functions)
4130         <map_matching_symbols>: Constify block argument to "callback".
4131         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4132         const.
4133         (find_pc_sect_compunit_symtab): Make "b" const.
4134         (find_symbol_at_address): Likewise.
4135         (search_symbols): Likewise.
4136         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4137         (dw2_debug_names_lookup_symbol): Likewise.
4138         (dw2_map_matching_symbols): Update.
4139         * p-valprint.c (pascal_val_print): Remove "block".
4140         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4141         (aux_add_nonlocal_symbols): Make "block" const.
4142         (resolve_subexp): Remove cast.
4143         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4144         const.
4145         (iterate_over_file_blocks): Likewise.
4146         * f-exp.y (%union) <bval>: Remove.
4147         * coffread.c (patch_opaque_types): Make "b" const.
4148         * spu-tdep.c (spu_catch_start): Make "block" const.
4149         * c-valprint.c (print_unpacked_pointer): Remove "block".
4150         * symmisc.c (dump_symtab_1): Make "b" const.
4151         (block_depth): Make "block" const.
4152         * d-exp.y (%union) <bval>: Remove.
4153         * cp-support.h (cp_lookup_rtti_type): Update.
4154         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4155         * psymtab.c (psym_lookup_symbol): Make "block" const.
4156         (maintenance_check_psymtabs): Make "b" const.
4157         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4158         (enumerate_locals, enumerate_args): Update.
4159         * python/py-symtab.c (stpy_global_block): Make "block" const.
4160         (stpy_static_block): Likewise.
4161         * inline-frame.c (block_starting_point_at): Make "new_block"
4162         const.
4163         * block.c (find_block_in_blockvector): Make return type const.
4164         (blockvector_for_pc_sect): Make "b" const.
4165         (find_block_in_blockvector): Make "b" const.
4166
4167 2019-03-23  Tom Tromey  <tom@tromey.com>
4168
4169         * varobj.c (varobj_create): Update.
4170         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4171         * printcmd.c (display_command, do_one_display): Don't reset
4172         innermost_block.
4173         * parser-defs.h (enum innermost_block_tracker_type): Move to
4174         expression.h.
4175         (innermost_block): Update comment.
4176         * parse.c (parse_exp_1): Add tracker_types parameter.
4177         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4178         tracker_types parameter.  Reset innermost_block.
4179         (parse_exp_in_context): Remove.
4180         (parse_expression_for_completion): Update.
4181         * objfiles.c (~objfile): Don't reset expression_context_block or
4182         innermost_block.
4183         * expression.h (enum innermost_block_tracker_type): Move from
4184         parser-defs.h.
4185         (parse_exp_1): Add tracker_types parameter.
4186         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4187         reset innermost_block.
4188
4189 2019-03-23  Tom Tromey  <tom@tromey.com>
4190
4191         * objfiles.h: Include bcache.h.
4192
4193 2019-03-23  Tom Tromey  <tom@tromey.com>
4194
4195         * linespec.c (get_current_search_block): Use
4196         scoped_restore_current_language.
4197         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4198
4199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4200             Jiong Wang  <jiong.wang@arm.com>
4201
4202         * aarch64-linux-tdep.c
4203         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4204         section.
4205         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4206
4207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4208             Jiong Wang  <jiong.wang@arm.com>
4209
4210         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4211         instructions.
4212         (aarch64_analyze_prologue_test): Add PACIASP test.
4213         (aarch64_prologue_prev_register): Unmask PC value.
4214
4215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4216             Jiong Wang  <jiong.wang@arm.com>
4217
4218         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4219         (aarch64_dwarf2_prev_register): Unmask PC value.
4220         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4221         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4222         DW_CFA_AARCH64_negate_ra_state.
4223         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4224
4225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4226             Jiong Wang  <jiong.wang@arm.com>
4227
4228         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4229         registers.
4230         (aarch64_pseudo_register_name): Likewise.
4231         (aarch64_pseudo_register_type): Likewise.
4232         (aarch64_pseudo_register_reggroup_p): Likewise.
4233         (aarch64_gdbarch_init): Add pauth registers.
4234         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4235         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4236         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4237         (struct gdbarch_tdep): Add regnum for ra_state.
4238
4239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4240             Jiong Wang  <jiong.wang@arm.com>
4241
4242         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4243
4244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4245             Jiong Wang  <jiong.wang@arm.com>
4246
4247         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4248         function.
4249         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4250         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4251         (aarch64_gdbarch_init): Add puth registers.
4252         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4253         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4254         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4255
4256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4257             Jiong Wang  <jiong.wang@arm.com>
4258
4259         * aarch64-linux-nat.c
4260         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4261         * aarch64-linux-tdep.c
4262         (aarch64_linux_core_read_description): Likewise.
4263         (aarch64_linux_get_hwcap): New function.
4264         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4265         (aarch64_linux_get_hwcap): New declaration.
4266
4267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4268             Jiong Wang  <jiong.wang@arm.com>
4269
4270         * aarch64-linux-nat.c
4271         (aarch64_linux_nat_target::read_description): Add pauth param.
4272         * aarch64-linux-tdep.c
4273         (aarch64_linux_core_read_description): Likewise.
4274         * aarch64-tdep.c (struct target_desc): Add in pauth.
4275         (aarch64_read_description): Add pauth param.
4276         (aarch64_gdbarch_init): Likewise.
4277         * aarch64-tdep.h (aarch64_read_description): Likewise.
4278         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4279         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4280         * features/Makefile: Add new files.
4281         * features/aarch64-pauth.c: New file.
4282         * features/aarch64-pauth.xml: New file.
4283
4284 2019-03-20  Tom Tromey  <tromey@adacore.com>
4285
4286         * infrun.c (handle_inferior_event): Rename from
4287         handle_inferior_event_1.  Create a scoped_value_mark.
4288         (handle_inferior_event): Remove.
4289
4290 2019-03-19  Tom Tromey  <tromey@adacore.com>
4291
4292         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4293         * infrun.h (print_stop_event): Add "displays" parameter.
4294         * infrun.c (print_stop_event): Add "displays" parameter.
4295
4296 2019-03-19  Pedro Alves  <palves@redhat.com>
4297
4298         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4299         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4300         to -1.  Fix TABs vs spaces.
4301         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4302         * tui/tui-out.h (tui_ui_out) Add intro comments.
4303         <m_line, m_start_of_line>: In-class initialize, and add describing
4304         comment.
4305
4306 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4307
4308         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4309         variable names.
4310         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4311
4312 2019-03-18  Pedro Alves  <palves@redhat.com>
4313             Eli Zaretskii <eliz@gnu.org>
4314
4315         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4316         m_line and m_start_of_line.
4317
4318 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4319
4320         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4321         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4322         it returns a newline.  This fixes a regression in TU mode, whereby
4323         the next line is output on the same screen line as the user input.
4324
4325 2019-03-18  Tom Tromey  <tromey@adacore.com>
4326
4327         * minsyms.c (minimal_symbol_reader::install): Remove call to
4328         obstack_blank.
4329
4330 2019-03-18  Pedro Alves  <palves@redhat.com>
4331
4332         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4333         New globals.
4334         (apply_style): New, factored out from ...
4335         (apply_ansi_escape): ... this.  Handle reverse video mode.
4336         (tui_set_reverse_mode): New function.
4337         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4338         * tui/tui-winsource.c (tui_show_source_line): Use
4339         tui_set_reverse_mode instead of setting A_STANDOUT.
4340         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4341         New setter methods.
4342
4343 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4344
4345         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4346         Handle tabs.
4347
4348 2019-03-18  Tom Tromey  <tromey@adacore.com>
4349
4350         * ada-lang.c (empty_array): Add "high" parameter.
4351         (ada_evaluate_subexp): Update.
4352
4353 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4354
4355         * unittests/string_view-selftests.c: Define
4356         _initialize_string_view_selftests unconditionally.
4357
4358 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4359
4360         PR gdb/24350
4361         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4362
4363 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4364
4365         PR gdb/24351
4366         * windows-nat.c (display_selector): Fix format specifiers.
4367
4368 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4369
4370         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4371         tui_refill_source_window instead of tui_refresh_win, to update the
4372         current execution line.  This fixes redisplay of the current line
4373         when stepping through the code with "next" or "step".
4374
4375 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4376
4377         * source-cache.c (source_cache::get_source_lines): Call
4378         find_source_lines to initialize s->nlines.  This fixes vertical
4379         scrolling of TUI source window when the DOWN arrow is pressed.
4380
4381 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4382
4383         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4384         linux-thread-db.c (_initialize_thread_db): Likewise.
4385
4386 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4387
4388         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4389         wclrtoeol in tui_show_source_line".  This reverts changes made in
4390         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4391
4392 2019-03-15  Tom Tromey  <tom@tromey.com>
4393
4394         * symtab.h (struct minimal_symbol): Derive from
4395         general_symbol_info.
4396         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4397         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4398         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4399         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4400         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4401         (MSYMBOL_SEARCH_NAME): Update.
4402         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4403         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4404         * minsyms.c (minimal_symbol_reader::record_full): Update.
4405
4406 2019-03-15  Tom Tromey  <tom@tromey.com>
4407
4408         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4409
4410 2019-03-15  Tom Tromey  <tom@tromey.com>
4411
4412         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4413         unique_xmalloc_ptr.
4414         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4415         Update.
4416         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4417         (build_minimal_symbol_hash_tables)
4418         (minimal_symbol_reader::install): Update.
4419
4420 2019-03-15  Tom Tromey  <tom@tromey.com>
4421
4422         * symtab.c (create_demangled_names_hash): Update.
4423         (symbol_set_names): Update.
4424         * objfiles.h (struct objfile_per_bfd_storage)
4425         <demangled_names_hash>: Now an htab_up.
4426         * objfiles.c (objfile_per_bfd_storage): Simplify.
4427
4428 2019-03-15  Tom Tromey  <tom@tromey.com>
4429
4430         * objfiles.h (struct objfile_per_bfd_storage): Declare
4431         destructor.
4432         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4433         New.
4434         (get_objfile_bfd_data): Use new.  Don't initialize
4435         language_of_main.
4436         (free_objfile_per_bfd_storage): Remove.
4437         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4438
4439 2019-03-15  Tom Tromey  <tom@tromey.com>
4440
4441         * symfile.c (reread_symbols): Update.
4442         * objfiles.c (objfile::objfile): Update.
4443         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4444         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4445         comment.
4446         (minimal_symbol_reader::install): Update.
4447         (terminate_minimal_symbol_table): Remove.
4448         * jit.c (jit_object_close_impl): Update.
4449
4450 2019-03-15  Tom Tromey  <tom@tromey.com>
4451
4452         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4453         initializations.
4454
4455 2019-03-15  Tom Tromey  <tom@tromey.com>
4456
4457         * objfiles.h (struct objfile_per_bfd_storage)
4458         <demangled_hash_languages>: Now a bitset.
4459         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4460         (lookup_minimal_symbol): Update.
4461
4462 2019-03-15  Tom Tromey  <tom@tromey.com>
4463
4464         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4465         Don't return the symbol.
4466         * coffread.c (record_minimal_symbol): Use record_full.
4467
4468 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4469
4470         The MS-Windows port of ncurses fails to switch to a color pair if
4471         one or both of the colors are the implicit default colors.  This
4472         change records the default colors when TUI is initialized, and
4473         then specifies them explicitly when a color pair uses the default
4474         colors.  This allows color styling in TUI mode on MS-Windows.
4475
4476         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4477         ncurses_norm_attr.
4478         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4479         colors in ncurses_norm_attr.
4480         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4481         "none", replace it with the default color recorded in
4482         ncurses_norm_attr.
4483
4484 2019-03-14  Tom Tromey  <tromey@adacore.com>
4485
4486         * source-cache.h (class source_cache) <get_source_lines>: Return
4487         std::string.
4488         * source-cache.c (source_cache::extract_lines): Handle case where
4489         first_pos==npos.  Return std::string.
4490         (source_cache::get_source_lines): Update.
4491
4492 2019-03-14  Tom Tromey  <tromey@adacore.com>
4493
4494         * NEWS: Add item for "style sources" commands.
4495         * source-cache.c (source_cache::get_source_lines): Check
4496         source_styling.
4497         * cli/cli-style.c (source_styling): New global.
4498         (_initialize_cli_style): Add "style sources" commands.
4499         (show_style_sources): New function.
4500         * cli/cli-style.h (source_styling): Declare.
4501
4502 2019-03-14  Pedro Alves  <palves@redhat.com>
4503             Tom Tromey  <tromey@adacore.com>
4504
4505         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4506         * tui/tui-winsource.c (tui_refill_source_window): New function,
4507         from...
4508         (tui_horizontal_source_scroll): ... here.  Move some logic.
4509         * cli/cli-style.c (set_style_enabled): Notify new observable.
4510         * tui/tui-hooks.c (tui_redisplay_source): New function.
4511         (tui_attach_detach_observers): Attach or detach
4512         tui_redisplay_source.
4513         * observable.h (source_styling_changed): New observable.
4514         * observable.c: Define source_styling_changed observable.
4515
4516 2019-03-13  Tom Tromey  <tromey@adacore.com>
4517
4518         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4519         (i386_gnu_nat_target::store_registers): Update.
4520         * target-debug.h (target_debug_print_std_string): New macro.
4521         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4522         * windows-tdep.c (display_one_tib): Update.
4523         * tui/tui-stack.c (tui_make_status_line): Update.
4524         * top.c (print_inferior_quit_action): Update.
4525         * thread.c (thr_try_catch_cmd): Update.
4526         (add_thread_with_info): Update.
4527         (thread_target_id_str): Update.
4528         (thr_try_catch_cmd): Update.
4529         (thread_command): Update.
4530         (thread_find_command): Update.
4531         * record-btrace.c (record_btrace_target::info_record)
4532         (record_btrace_resume_thread, record_btrace_target::resume)
4533         (record_btrace_cancel_resume, record_btrace_step_thread)
4534         (record_btrace_target::wait, record_btrace_target::wait)
4535         (record_btrace_target::wait, record_btrace_target::stop): Update.
4536         * progspace.c (print_program_space): Update.
4537         * process-stratum-target.c
4538         (process_stratum_target::thread_address_space): Update.
4539         * linux-fork.c (linux_fork_mourn_inferior)
4540         (detach_checkpoint_command, info_checkpoints_command)
4541         (linux_fork_context): Update.
4542         (linux_fork_detach): Update.
4543         (class scoped_switch_fork_info): Update.
4544         (delete_checkpoint_command): Update.
4545         * infrun.c (follow_fork_inferior): Update.
4546         (follow_fork_inferior): Update.
4547         (proceed_after_vfork_done): Update.
4548         (handle_vfork_child_exec_or_exit): Update.
4549         (follow_exec): Update.
4550         (displaced_step_prepare_throw): Update.
4551         (displaced_step_restore): Update.
4552         (start_step_over): Update.
4553         (resume_1): Update.
4554         (clear_proceed_status_thread): Update.
4555         (proceed): Update.
4556         (print_target_wait_results): Update.
4557         (do_target_wait): Update.
4558         (context_switch): Update.
4559         (stop_all_threads): Update.
4560         (restart_threads): Update.
4561         (finish_step_over): Update.
4562         (handle_signal_stop): Update.
4563         (switch_back_to_stepped_thread): Update.
4564         (keep_going_pass_signal): Update.
4565         (print_exited_reason): Update.
4566         (normal_stop): Update.
4567         * inferior.c (inferior_pid_to_str): Change return type.
4568         (print_selected_inferior): Update.
4569         (add_inferior): Update.
4570         (detach_inferior): Update.
4571         * dummy-frame.c (fprint_dummy_frames): Update.
4572         * dcache.c (dcache_info_1): Update.
4573         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4574         (btrace_fetch, btrace_clear): Update.
4575         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4576         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4577         type.
4578         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4579         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4580         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4581         * gdbarch.c, gdbarch.h: Rebuild.
4582         * gdbarch.sh (core_pid_to_str): Change return type.
4583         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4584         return type.
4585         (windows_nat_target::pid_to_str): Change return type.
4586         (windows_delete_thread): Update.
4587         (windows_nat_target::attach): Update.
4588         (windows_nat_target::files_info): Update.
4589         * target-delegates.c: Rebuild.
4590         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4591         return type.
4592         (sol_thread_target::pid_to_str): Change return type.
4593         * remote.c (class remote_target) <pid_to_str>: Change return
4594         type.
4595         (remote_target::pid_to_str): Change return type.
4596         (extended_remote_target::attach, remote_target::remote_stop_ns)
4597         (remote_target::remote_notif_remove_queued_reply)
4598         (remote_target::push_stop_reply, remote_target::disable_btrace):
4599         Update.
4600         (extended_remote_target::attach): Update.
4601         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4602         type.
4603         (gdbsim_target::pid_to_str): Change return type.
4604         * ravenscar-thread.c (struct ravenscar_thread_target)
4605         <pid_to_str>: Change return type.
4606         (ravenscar_thread_target::pid_to_str): Change return type.
4607         * procfs.c (class procfs_target) <pid_to_str>: Change return
4608         type.
4609         (procfs_target::pid_to_str): Change return type.
4610         (procfs_target::attach): Update.
4611         (procfs_target::detach): Update.
4612         (procfs_target::fetch_registers): Update.
4613         (procfs_target::store_registers): Update.
4614         (procfs_target::wait): Update.
4615         (procfs_target::files_info): Update.
4616         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4617         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4618         return type.
4619         (nto_procfs_target::pid_to_str): Change return type.
4620         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4621         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4622         return type.
4623         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4624         (exit_lwp): Update.
4625         (attach_proc_task_lwp_callback, get_detach_signal)
4626         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4627         (linux_nat_target::resume, wait_lwp, stop_callback)
4628         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4629         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4630         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4631         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4632         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4633         type.
4634         (inf_ptrace_target::attach): Update.
4635         (inf_ptrace_target::files_info): Update.
4636         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4637         type.
4638         (go32_nat_target::pid_to_str): Change return type.
4639         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4640         (gnu_nat_target::wait): Update.
4641         (gnu_nat_target::wait): Update.
4642         (gnu_nat_target::resume): Update.
4643         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4644         (fbsd_nat_target::wait): Update.
4645         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4646         type.
4647         (darwin_nat_target::attach): Update.
4648         * corelow.c (class core_target) <pid_to_str>: Change return type.
4649         (core_target::pid_to_str): Change return type.
4650         * target.c (normal_pid_to_str): Change return type.
4651         (default_pid_to_str): Likewise.
4652         (target_pid_to_str): Change return type.
4653         (target_translate_tls_address): Update.
4654         (target_announce_detach): Update.
4655         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4656         return type.
4657         (bsd_uthread_target::pid_to_str): Change return type.
4658         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4659         type.
4660         (bsd_kvm_target::pid_to_str): Change return type.
4661         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4662         return type.
4663         (aix_thread_target::pid_to_str): Change return type.
4664         * target.h (struct target_ops) <pid_to_str>: Change return type.
4665         (target_pid_to_str, normal_pid_to_str): Likewise.
4666         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4667         type.
4668         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4669         type.
4670         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4671         return type.
4672         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4673         type.
4674         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4675         type.
4676         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4677         return type.
4678
4679 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4680
4681         * NEWS: Mention that the new default MI version is 3.  Mention
4682         changes to the output of commands and events that deal with
4683         multi-location breakpoints.
4684         * breakpoint.c: Include "mi/mi-out.h".
4685         (print_one_breakpoint): Change output syntax if using MI version
4686         >= 3.
4687         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4688         New.
4689         (mi_multi_location_breakpoint_output_fixed): New.
4690         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4691         (mi_cmd_fix_multi_location_breakpoint_output): New.
4692         (mi_multi_location_breakpoint_output_fixed): New.
4693         * mi/mi-cmds.c (mi_cmds): Register command
4694         -fix-multi-location-breakpoint-output.
4695         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4696         interpreter "mi".
4697
4698 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4699
4700         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4701         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4702         instantiate mi_ui_out based on interpreter name.
4703         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4704         * mi/mi-main.c (mi_load_progress): Likewise.
4705
4706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4707
4708         * NEWS: Combine separate "New targets" sections for 8.3.
4709
4710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4711
4712         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4713         (ppcfbsd_init_abi): Install gdbarch
4714         "fetch_tls_load_module_address" and "get_thread_local_address"
4715         methods.
4716
4717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4718
4719         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4720         (riscv_fbsd_init_abi): Install gdbarch
4721         "fetch_tls_load_module_address" and "get_thread_local_address"
4722         methods.
4723
4724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4725
4726         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4727         (i386fbsd_init_abi): Install gdbarch
4728         "fetch_tls_load_module_address" and "get_thread_local_address"
4729         methods.
4730
4731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4732
4733         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4734         (amd64fbsd_init_abi): Install gdbarch
4735         "fetch_tls_load_module_address" and "get_thread_local_address"
4736         methods.
4737
4738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4739
4740         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4741         (struct fbsd_pspace_data): New type.
4742         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4743         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4744         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4745         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4746         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4747
4748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4749
4750         * gdbtypes.c (lookup_struct_elt): New function.
4751         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4752         * gdbtypes.h (struct struct_elt): New type.
4753         (lookup_struct_elt): New prototype.
4754
4755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4756
4757         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4758         remove disabled code block.
4759
4760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4761
4762         * gdbarch.sh (get_thread_local_address): New method.
4763         * gdbarch.h, gdbarch.c: Regenerate.
4764         * target.c (target_translate_tls_address): Use
4765         gdbarch_get_thread_local_address if present instead of
4766         target::get_thread_local_address.
4767
4768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4769
4770         * target.h (target::get_thread_local_address): Update comment.
4771
4772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4773
4774         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4775         objfile->separate_debug_objfile_backlink if not NULL.
4776
4777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4778
4779         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4780         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4781         (amd64bsd_store_inferior_registers): Likewise.
4782         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4783         Enable segment base registers.
4784         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4785         PT_GETFSBASE and PT_GETGSBASE.
4786         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4787         PT_SETGSBASE.
4788         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4789         segment base registers.
4790         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4791
4792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4793
4794         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4795         Update calls to i386_target_description to add 'segments'
4796         parameter.
4797         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4798         add segment base registers.
4799         * arch/i386.c (i386_create_target_description): Add 'segments'
4800         parameter to enable segment base registers.
4801         * arch/i386.h (i386_create_target_description): Likewise.
4802         * features/i386/32bit-segments.xml: New file.
4803         * features/i386/32bit-segments.c: Generate.
4804         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4805         call to i386_target_description to add 'segments' parameter.
4806         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4807         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4808         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4809         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4810         if feature is present.
4811         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4812         Add 'segments' parameter to call to i386_target_description.
4813         (i386_target_description): Add 'segments' parameter to enable
4814         segment base registers.
4815         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4816         to call to i386_target_description.
4817         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4818         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4819         Define I386_NUM_REGS.
4820         (i386_target_description): Add 'segments' parameter to enable
4821         segment base registers.
4822
4823 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4824
4825         PR/24325
4826         * source-cache.c: #undef open and close, to avoid unresolved
4827         externals during linking.
4828
4829 2019-03-12  Tom Tromey  <tromey@adacore.com>
4830
4831         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4832         const.  Add initializers.
4833         (_initialize_remote): Don't initialize ptid globals.
4834
4835 2019-03-12  Pedro Alves  <palves@redhat.com>
4836
4837         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4838
4839 2019-03-12  Pedro Alves  <palves@redhat.com>
4840
4841         * cp-name-parser.y (main): Remove unused 'len' variable.
4842
4843 2019-03-12  Tom Tromey  <tromey@adacore.com>
4844
4845         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4846         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4847
4848 2019-03-12  Tom Tromey  <tromey@adacore.com>
4849
4850         * linux-nat.c (iterate_over_lwps): Update.
4851         (stop_callback): Remove parameter.
4852         (stop_wait_callback, detach_callback, resume_set_callback)
4853         (select_singlestep_lwp_callback, set_ignore_sigint)
4854         (status_callback, resumed_callback, resume_clear_callback)
4855         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4856         data parameter.
4857         (linux_nat_target::detach, linux_nat_target::resume)
4858         (linux_stop_and_wait_all_lwps, select_event_lwp)
4859         (linux_nat_filter_event, linux_nat_wait_1)
4860         (linux_nat_target::kill, linux_nat_target::stop)
4861         (linux_nat_target::stop): Update.
4862         (linux_nat_resume_callback): Change type.
4863         (resume_stopped_resumed_lwps, count_events_callback)
4864         (select_event_lwp_callback): Likewise.
4865         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4866         * arm-linux-nat.c (struct update_registers_data): Remove.
4867         (update_registers_callback): Change type.
4868         (arm_linux_insert_hw_breakpoint1): Update.
4869         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4870         parameter.
4871         (x86_linux_dr_set_addr): Update.
4872         (x86_linux_dr_set_control): Update.
4873         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4874         (iterate_over_lwps): Use gdb::function_view.
4875         * nat/aarch64-linux-hw-point.c (struct
4876         aarch64_dr_update_callback_param): Remove.
4877         (debug_reg_change_callback): Change type.
4878         (aarch64_notify_debug_reg_change): Update.
4879         * s390-linux-nat.c (s390_refresh_per_info): Update.
4880
4881 2019-03-11  Tom Tromey  <tromey@adacore.com>
4882
4883         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4884         redundant assignment to "this_cu".
4885
4886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4887
4888         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4889
4890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4891
4892         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4893         from...
4894         (rank_one_type): ... this.
4895
4896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4897
4898         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4899         from...
4900         (rank_one_type): ... this.
4901
4902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4903
4904         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4905         from...
4906         (rank_one_type): ... this.
4907
4908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4909
4910         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4911         from...
4912         (rank_one_type): ... this.
4913
4914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4915
4916         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4917         from...
4918         (rank_one_type): ... this.
4919
4920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4921
4922         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4923         from...
4924         (rank_one_type): ... this.
4925
4926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4927
4928         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4929         from...
4930         (rank_one_type): ... this.
4931
4932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4933
4934         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4935         from...
4936         (rank_one_type): ... this.
4937
4938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4939
4940         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4941         from...
4942         (rank_one_type): ... this.
4943
4944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4945
4946         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4947         from...
4948         (rank_one_type): ... this.
4949
4950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4951
4952         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4953         from...
4954         (rank_one_type): ... this.
4955
4956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4957
4958         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4959         from...
4960         (rank_one_type): ... this.
4961
4962 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4963
4964         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4965         inferior-events' shows the example events.
4966
4967 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4968
4969         Support styling on native MS-Windows console
4970
4971         PR/24315
4972         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4973         on MS-Windows if $TERM is not defined.
4974
4975         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4976
4977         * posix-hdep.c (gdb_console_fputs):
4978         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4979         functions.
4980         * ui-file.h (gdb_console_fputs): Add prototype.
4981
4982         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4983         back to fputs only if the former returns zero.
4984
4985 2019-03-07  Tom Tromey  <tom@tromey.com>
4986
4987         * symmisc.c (print_symbol_bcache_statistics): Update.
4988         (print_objfile_statistics): Update.
4989         * symfile.c (allocate_symtab): Update.
4990         * stabsread.c: Don't include bcache.h.
4991         * psymtab.h (struct psymbol_bcache): Don't declare.
4992         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4993         (psymbol_bcache_init, psymbol_bcache_free)
4994         (psymbol_bcache_get_bcache): Don't declare.
4995         * psymtab.c (struct psymbol_bcache): Remove.
4996         (psymtab_storage::psymtab_storage): Update.
4997         (psymtab_storage::~psymtab_storage): Update.
4998         (psymbol_bcache_init, psymbol_bcache_free)
4999         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5000         (add_psymbol_to_bcache): Update.
5001         (allocate_psymtab): Update.
5002         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5003         macro_cache>: No longer pointers.
5004         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5005         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5006         * macrotab.c (macro_bcache): Update.
5007         * macroexp.c: Don't include bcache.h.
5008         * gdbtypes.c (check_types_worklist): Update.
5009         (types_deeply_equal): Remove TRY/CATCH.  Update.
5010         * elfread.c (elf_symtab_read): Update.
5011         * dwarf2read.c: Don't include bcache.h.
5012         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5013         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5014         (print_bcache_statistics, bcache_memory_used): Don't declare.
5015         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5016         methods.  Rename all data members.
5017         * bcache.c (struct bcache): Move to bcache.h.
5018         (bcache::expand_hash_table): Rename from expand_hash_table.
5019         (bcache): Remove.
5020         (bcache::insert): Rename from bcache_full.
5021         (bcache::compare): Rename from bcache_compare.
5022         (bcache_xmalloc): Remove.
5023         (bcache::~bcache): Rename from bcache_xfree.
5024         (bcache::print_statistics): Rename from print_bcache_statistics.
5025         (bcache::memory_used): Rename from bcache_memory_used.
5026
5027 2019-03-07  Pedro Alves  <palves@redhat.com>
5028
5029         * infrun.c (normal_stop): Also check for
5030         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5031
5032 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5033
5034         * f-lang.c (value_from_host_double): Moved to...
5035         * value.c (value_from_host_double): ...here.
5036         * value.h (value_from_host_double): Declare.
5037         * guile/scm-math.c (vlscm_convert_typed_number): Use
5038         value_from_host_double.
5039         (vlscm_convert_number): Likewise.
5040         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5041         * python/py-value.c (convert_value_from_python): Likewise.
5042
5043 2019-03-06  Tom Tromey  <tom@tromey.com>
5044
5045         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5046
5047 2019-03-06  Tom Tromey  <tom@tromey.com>
5048
5049         * utils.h (free_current_contents): Don't declare.
5050         * utils.c (free_current_contents): Remove.
5051
5052 2019-03-06  Tom Tromey  <tom@tromey.com>
5053
5054         * top.c (quit_force): Update.
5055         * main.c (captured_command_loop): Update.
5056         * common/new-op.c (operator new): Update.
5057         * common/common-exceptions.c (struct catcher)
5058         <save_cleanup_chain>: Remove member.
5059         (exceptions_state_mc_init): Update.
5060         (exception_try_scope_entry): Return nullptr.
5061         (exception_try_scope_exit, exception_rethrow)
5062         (throw_exception_sjlj, throw_exception_cxx): Update.
5063         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5064         (all_cleanups, do_cleanups, discard_cleanups)
5065         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5066         (restore_cleanups, restore_final_cleanups): Don't declare.
5067         (do_final_cleanups): Remove parameter.
5068         * common/cleanups.c (cleanup_chain, make_cleanup)
5069         (make_cleanup_dtor, all_cleanups, do_cleanups)
5070         (discard_my_cleanups, discard_cleanups)
5071         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5072         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5073         (null_cleanup): Remove.
5074         (do_final_cleanups): Remove parameter.
5075
5076 2019-03-06  Tom Tromey  <tom@tromey.com>
5077
5078         * remote.c (remote_target::remote_parse_stop_reply): Use
5079         unique_xmalloc_ptr.
5080
5081 2019-03-06  Tom Tromey  <tom@tromey.com>
5082
5083         * stabsread.c (struct stabs_field_info): Rename from field_info.
5084         <list, fnlist>: Add initializers.
5085         <obstack>: New member.
5086         (read_member_functions, read_struct_fields, read_baseclasses):
5087         Allocate on obstack.  Don't use cleanups.
5088         (read_one_struct_field, read_member_functions, read_struct_fields)
5089         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5090         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5091         (read_struct_type): Update.
5092
5093 2019-03-06  Tom Tromey  <tom@tromey.com>
5094
5095         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5096         * common/filestuff.h (make_cleanup_close): Don't declare.
5097         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5098         Remove.
5099
5100 2019-03-06  Tom Tromey  <tom@tromey.com>
5101
5102         * solib-aix.c: Use make_scope_exit.
5103
5104 2019-03-06  Tom Tromey  <tom@tromey.com>
5105
5106         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5107         Use make_scope_exit.
5108
5109 2019-03-06  Tom Tromey  <tom@tromey.com>
5110
5111         * solib-svr4.c (disable_probes_interface): Remove parameter.
5112         (svr4_handle_solib_event): Use make_scope_exit.
5113
5114 2019-03-06  Tom Tromey  <tom@tromey.com>
5115
5116         * remote.c (struct stop_reply_deleter): Remove.
5117         (stop_reply_up): Update.
5118         (struct stop_reply): Derive from notif_event.  Don't typedef.
5119         <regcache>: Now a std::vector.
5120         (stop_reply_xfree): Remove.
5121         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5122         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5123         (remote_target::discard_pending_stop_replies): Use delete.
5124         (remote_target::remote_parse_stop_reply): Update.
5125         (remote_target::process_stop_reply): Update.
5126         * remote-notif.h (struct notif_event): Add virtual destructor.
5127         Remove "dtr" member.
5128         (struct notif_client) <alloc_event>: Return a unique_ptr.
5129         (notif_event_xfree): Don't declare.
5130         (notif_event_up): New typedef.
5131         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5132         (notif_event_xfree, do_notif_event_xfree): Remove.
5133         (remote_notif_state_xfree): Update.
5134
5135 2019-03-06  Tom Tromey  <tom@tromey.com>
5136
5137         * infrun.c (displaced_step_clear_cleanup): Now a
5138         forward_scope_exit type.
5139         (displaced_step_prepare_throw): Update.
5140         (displaced_step_fixup): Update.
5141
5142 2019-03-06  Tom Tromey  <tom@tromey.com>
5143
5144         * inferior.h (class inferior): Update comment.
5145         * gdbthread.h (class thread_info): Update comment.
5146
5147 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5148             Tom Tromey  <tom@tromey.com>
5149
5150         * stabsread.h (struct stab_section_list): Remove.
5151         (coffstab_build_psymtabs): Update.
5152         * dbxread.c (symbuf_sections): Now a std::vector.
5153         (sect_idx): New global.
5154         (fill_symbuf): Update.
5155         (coffstab_build_psymtabs): Change type of stabsects parameter.
5156         Update.
5157         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5158         std::vector.
5159         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5160         (coff_locate_sections): Update.
5161         (coff_symfile_read): Remove cleanups.  Update.
5162         (init_stringtab): Add storage parameter.
5163         (free_stringtab, free_stringtab_cleanup): Remove.
5164         (init_lineno): Add storage parameter.
5165         (free_linetab, free_linetab_cleanup): Remove.
5166
5167 2019-03-06  Pedro Alves  <palves@redhat.com>
5168
5169         * linux-fork.c (fork_info::clobber_regs): Delete.
5170         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5171         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5172         comment.  Adjust.
5173         (scoped_switch_fork_info::scoped_switch_fork_info)
5174         (checkpoint_command, linux_fork_context): Adjust
5175         fork_save_infrun_state calls.
5176
5177 2019-03-06  Pedro Alves  <palves@redhat.com>
5178
5179         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5180         (inf_has_multiple_threads): Return 'bool' and rewrite using
5181         inferior_info::threads().
5182
5183 2019-03-06  Pedro Alves  <palves@redhat.com>
5184
5185         * linux-fork.c: Include <list>.
5186         (fork_list): Now a std::list instance.
5187         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5188         (forks_exist_p, find_last_fork): Adjust.
5189         (new_fork): Delete.
5190         (one_fork_p): New.
5191         (add_fork): Adjust.
5192         (free_fork): Delete, folded into fork_info::~fork_info().
5193         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5194         Adjust.
5195         (init_fork_list): Delete.
5196         (linux_fork_killall, linux_fork_mourn_inferior)
5197         (linux_fork_detach, info_checkpoints_command): Adjust.
5198         (_initialize_linux_fork): No longer call init_fork_list.
5199
5200 2019-03-06  Pedro Alves  <palves@redhat.com>
5201
5202         * linux-fork.c (new_fork): New, split out of ...
5203         (add_fork): ... this.  Return void.  Move "first fork" special
5204         case from here, to ...
5205         (checkpoint_command): ... here.
5206         * linux-linux.h (add_fork): Return void.
5207
5208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5209
5210         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5211
5212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5213             Chris January  <chris.january@arm.com>
5214             David Lecomber  <david.lecomber@arm.com>
5215
5216         * f-exp.y: New token, UNOP_INTRINSIC.
5217         (exp): New pattern using UNOP_INTRINSIC token.
5218         (f77_keywords): Add 'abs' keyword.
5219         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5220         (value_from_host_double): New function.
5221         (evaluate_subexp_f): Support UNOP_ABS.
5222
5223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5224
5225         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5226         types.
5227
5228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5229
5230         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5231         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5232         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5233
5234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5237
5238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5239             Chris January  <chris.january@arm.com>
5240
5241         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5242         * f-exp.y: Define 'KIND' token.
5243         (exp): New pattern for KIND expressions.
5244         (ptype): Handle types with a kind extension.
5245         (direct_abs_decl): Extend to spot kind extensions.
5246         (f77_keywords): Add 'kind' to the list.
5247         (push_kind_type): New function.
5248         (convert_to_kind_type): New function.
5249         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5250         * parse.c (operator_length_standard): Likewise.
5251         * parser-defs.h (enum type_pieces): Add tp_kind.
5252         * std-operator.def: Add UNOP_KIND.
5253
5254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5255
5256         * f-exp.y (f_parse): Set yydebug.
5257
5258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * f-lang.c (evaluate_subexp_f): New function.
5261         (exp_descriptor_f): New global.
5262         (f_language_defn): Use exp_descriptor_f instead of
5263         exp_descriptor_standard.
5264
5265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5266
5267         * f-exp.y (struct token): Add comments.
5268         (dot_ops): Remove uppercase versions and the end marker.
5269         (f77_keywords): Likewise.
5270         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5271         entries in the dot_ops array are case insensitive, and use
5272         strncasecmp to compare strings.  Also some whitespace cleanup in
5273         this area.  Similar for the f77_keywords array, except entries in
5274         this list might be case sensitive.
5275
5276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5277
5278         * f-exp.y (struct f77_boolean_val): Add comments.
5279         (boolean_values): Remove uppercase versions, and end marker.
5280         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5281         and use strncasecmp to achieve case insensitivity.  Additionally,
5282         perform whitespace cleanup around this code.
5283
5284 2019-03-06  Tom Tromey  <tromey@adacore.com>
5285
5286         * remote-sim.c (gdbsim_target_open): Use result of
5287         gdb_argv::release.
5288
5289 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5290         Dirk Schubert  <dirk.schubert@arm.com>
5291         Chris January  <chris.january@arm.com>
5292
5293         * eval.c (evaluate_subexp_standard): Call Fortran argument
5294         wrapping logic.
5295         * f-lang.c (struct value): A value which can be passed into a
5296         Fortran function call.
5297         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5298         where appropriate.
5299         (struct type): Value ready for a Fortran function call.
5300         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5301         is needed.
5302         * f-lang.h (fortran_argument_convert): Declaration.
5303         (fortran_preserve_arg_pointer): Declaration.
5304         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5305
5306 2019-03-05  Tom Tromey  <tromey@adacore.com>
5307
5308         * python/py-prettyprint.c (print_string_repr): Remove #if.
5309         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5310
5311 2019-03-05  Tom Tromey  <tromey@adacore.com>
5312
5313         * target.c (the_dummy_target): Move later.  Change type to
5314         "dummy_target".
5315         (initialize_targets): Don't initialize the_dummy_target.
5316
5317 2019-03-05  Tom Tromey  <tromey@adacore.com>
5318
5319         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5320         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5321
5322 2019-03-05  Tom Tromey  <tromey@adacore.com>
5323
5324         * windows-nat.c (windows_nat_target::attach)
5325         (windows_nat_target::detach): Don't call gdb_flush.
5326         * valprint.c (generic_val_print, val_print, val_print_string):
5327         Don't call gdb_flush.
5328         * utils.c (defaulted_query): Don't call gdb_flush.
5329         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5330         * target.c (target_announce_detach): Don't call gdb_flush.
5331         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5332         * remote.c (extended_remote_target::attach): Don't call
5333         gdb_flush.
5334         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5335         * printcmd.c (do_examine): Don't call gdb_flush.
5336         (info_display_command): Don't call gdb_flush.
5337         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5338         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5339         * memattr.c (info_mem_command): Don't call gdb_flush.
5340         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5341         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5342         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5343         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5344         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5345         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5346         (gnu_nat_target::detach): Don't call gdb_flush.
5347         * f-valprint.c (f_val_print): Don't call gdb_flush.
5348         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5349         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5350         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5351         gdb_flush.
5352         * c-valprint.c (c_val_print): Don't call gdb_flush.
5353         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5354
5355 2019-03-05  Tom Tromey  <tromey@adacore.com>
5356
5357         * varobj.c (update_dynamic_varobj_children): Update.
5358         (install_default_visualizer): Use reset, not release.
5359         * value.c (set_internalvar): Update.
5360         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5361         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5362         ATTRIBUTE_UNUSED_RESULT.
5363
5364 2019-03-05  Tom Tromey  <tromey@adacore.com>
5365
5366         * remote.c (class scoped_remote_fd) <release>: Add
5367         ATTRIBUTE_UNUSED_RESULT.
5368
5369 2019-03-05  Tom Tromey  <tromey@adacore.com>
5370
5371         * macroexp.c (struct macro_buffer) <release>: Add
5372         ATTRIBUTE_UNUSED_RESULT.
5373
5374 2019-03-05  Tom Tromey  <tromey@adacore.com>
5375
5376         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5377         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5378         ATTRIBUTE_UNUSED_RESULT.
5379
5380 2019-03-05  Tom Tromey  <tromey@adacore.com>
5381
5382         * common/scoped_fd.h (class scoped_fd) <release>: Add
5383         ATTRIBUTE_UNUSED_RESULT.
5384
5385 2019-03-05  Tom Tromey  <tromey@adacore.com>
5386
5387         * parser-defs.h (struct parser_state) <release>: Add
5388         ATTRIBUTE_UNUSED_RESULT.
5389
5390 2019-03-05  Tom Tromey  <tromey@adacore.com>
5391
5392         * utils.h (class gdb_argv) <release>: Add
5393         ATTRIBUTE_UNUSED_RESULT.
5394         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5395
5396 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5397
5398         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5399         for-loop range, to avoid compiler warnings.
5400
5401         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5402         avoid compiler warnings about unused variables.
5403
5404         * NEWS: Mention end of support for native debugging on MS-Windows
5405         before XP.
5406
5407         PR gdb/24292
5408         * common/netstuff.c:
5409         * gdbserver/gdbreplay.c
5410         * gdbserver/remote-utils.c:
5411         * ser-tcp.c:
5412         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5413         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5414         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5415         'getaddrinfo' and 'freeaddrinfo' were not available before
5416         Windows XP, and mingw.org's MinGW headers by default define
5417         _WIN32_WINNT to 0x500.
5418
5419 2019-03-01  Gary Benson <gbenson@redhat.com>
5420
5421         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5422
5423 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5424             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5425
5426         PR gdb/8527
5427         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5428         set_sigint_trap, clear_sigint_trap.
5429
5430 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5431
5432         * target.c (target_detach): Clear the regcache and the
5433         frame cache.
5434
5435 2019-02-27  Pedro Alves  <palves@redhat.com>
5436
5437         * utils.c (set_screen_size): When we cap the height/width sizes,
5438         tweak the corresponding command variable to show "unlimited":
5439
5440 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5441             Pedro Alves  <palves@redhat.com>
5442
5443         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5444         before calling rl_set_screen_size.
5445
5446 2019-02-27  Tom Tromey  <tromey@adacore.com>
5447
5448         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5449         define.
5450         * python/py-value.c: Remove Python 2.4 workaround.
5451         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5452         workaround.
5453         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5454         Python 2.4 workaround.
5455         * python/python-internal.h: Remove Python 2.4 comment.
5456         (Py_ssize_t): Don't define.
5457         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5458         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5459         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5460         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5461         * python/python.c (do_start_initialization): Remove Python 2.4
5462         workaround.
5463         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5464         (print_children): Remove Python 2.4 workaround.
5465         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5466         workaround.
5467         (CHARBUFFERPROC_NAME): Remove.
5468         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5469         Python 2.4 workaround.
5470
5471 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5472
5473         * NEWS: Note minimum Python version.
5474
5475 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5476
5477         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5478         code from these functions.  Remove corresponding ifdefs.  Use
5479         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5480         Remove gotos and target of gotos.
5481         (infpy_search_memory): Likewise.
5482
5483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5486         (hppa_gdbarch_init): Don't register deleted functions with
5487         gdbarch.
5488
5489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5492         (h8300_unwind_sp): Delete.
5493         (h8300_dummy_id): Delete.
5494         (h8300_gdbarch_init): Don't register deleted functions with
5495         gdbarch.
5496
5497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5498
5499         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5500         (ft32_unwind_pc): Delete.
5501         (ft32_unwind_sp): Delete.
5502         (ft32_gdbarch_init): Don't register deleted functions with
5503         gdbarch.
5504
5505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5506
5507         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5508         (frv_unwind_pc): Delete.
5509         (frv_unwind_sp): Delete.
5510         (frv_gdbarch_init): Don't register deleted functions with
5511         gdbarch.
5512
5513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5514
5515         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5516         (riscv_unwind_pc): Delete.
5517         (riscv_unwind_sp): Delete.
5518         (riscv_gdbarch_init): Don't register deleted functions with
5519         gdbarch.
5520
5521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5522
5523         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5524         (csky_unwind_pc): Delete.
5525         (csky_unwind_sp): Delete.
5526         (csky_gdbarch_init): Don't register deleted functions with
5527         gdbarch.
5528
5529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5530
5531         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5532         (cris_unwind_pc): Delete.
5533         (cris_unwind_sp): Delete.
5534         (cris_gdbarch_init): Don't register deleted functions with
5535         gdbarch.
5536
5537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5538
5539         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5540         (bfin_unwind_pc): Delete.
5541         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5542
5543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5546         (arm_unwind_pc): Delete.
5547         (arm_unwind_sp): Delete.
5548         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5549
5550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5551
5552         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5553         (arc_unwind_pc): Delete.
5554         (arc_unwind_sp): Delete.
5555         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5556
5557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5558
5559         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5560         (alpha_unwind_pc): Delete.
5561         (alpha_gdbarch_init): Don't register deleted functions with
5562         gdbarch.
5563
5564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5565
5566         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5567         (aarch64_unwind_pc): Delete.
5568         (aarch64_unwind_sp): Delete.
5569         (aarch64_gdbarch_init): Don't register deleted functions with
5570         gdbarch.
5571
5572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5573
5574         * gdbtypes.c (type_align): Don't consider static members when
5575         computing structure alignment.
5576
5577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5578
5579         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5580         return 0 for other types.
5581         * arch-utils.c (default_type_align): Always return 0.
5582         * gdbarch.h: Regenerate.
5583         * gdbarch.sh (type_align): Extend comment.
5584         * gdbtypes.c (type_align): Add additional comments, always call
5585         gdbarch_type_align before applying the default rules.
5586         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5587         generic code will then apply a suitable default.
5588         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5589         types, return 0 for other types.
5590
5591 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5592
5593         * NEWS: Create a new section for the next release branch.
5594         Rename the section of the current branch, now that it has
5595         been cut.
5596
5597 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5598
5599         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5600         * version.in: Bump version to 8.3.50.DATE-git.
5601
5602 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5603
5604         * aix-thread.c (ptid_cmp): Remove unused variable.
5605         (get_signaled_thread): Likewise.
5606         (store_regs_user_thread): Likewise.
5607         (store_regs_kernel_thread): Likewise.
5608         (fetch_regs_kernel_thread): Remove shadowed variable.
5609
5610 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5611
5612         * features/riscv/32bit-cpu.xml: Add register numbers.
5613         * features/riscv/32bit-fpu.c: Regenerate.
5614         * features/riscv/32bit-fpu.xml: Add register numbers.
5615         * features/riscv/64bit-cpu.xml: Add register numbers.
5616         * features/riscv/64bit-fpu.c: Regenerate.
5617         * features/riscv/64bit-fpu.xml: Add register numbers.
5618
5619 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5620
5621         * NEWS: Mention two argument form of gdb.Value constructor.
5622         * python/py-value.c (convert_buffer_and_type_to_value): New
5623         function.
5624         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5625         Add support for handling an optional second argument.  Call
5626         convert_buffer_and_type_to_value as appropriate.
5627         * python/python-internal.h (Py_buffer_deleter): New struct.
5628         (Py_buffer_up): New typedef.
5629
5630 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5631
5632         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5633         instead of releasing ownership.
5634
5635 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5636
5637         * dwarf2read.c (open_and_init_dwp_file): Call
5638         elf_numsections instead of bfd_count_sections to initialize
5639         dwp_file->num_sections.
5640
5641 2019-02-25  Tom Tromey  <tromey@adacore.com>
5642
5643         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5644
5645 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5646
5647         * gcore.in: Add '--readnever' option when invoking GDB.
5648
5649 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5650
5651         * MAINTAINERS: Update my email address.
5652
5653 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5654
5655         * build-id.c (build_id_to_debug_bfd_1): New function.
5656         (build_id_to_debug_bfd): Look for separate debug file in
5657         sysroot.
5658
5659 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5660
5661         * gdbarch.sh: Update the copyright year range that is placed into
5662         generated files.
5663
5664 2019-02-22  Keith Seitz  <keiths@redhat.com>
5665
5666         PR symtab/23853
5667         * linespec.c (create_sals_line_offset): Search for the default
5668         symtab's filename instead of its fullname.
5669
5670 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5671
5672         * NEWS: Update style defaults.
5673
5674 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5675
5676         * main.c (captured_main_1): Disable styling in batch mode.
5677
5678 2019-02-20  Tom Tromey  <tom@tromey.com>
5679
5680         * symtab.c (symtab_symbol_info): Fix typos.
5681
5682 2019-02-20  Tom Tromey  <tromey@adacore.com>
5683
5684         * findcmd.c (_initialize_mem_search): Use upper case for
5685         metasyntactic variables.
5686
5687 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5688
5689         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5690         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5691
5692 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5693
5694         * top.h (source_file_name): Change to std::string.
5695         * top.c (source_file_name): Likewise.
5696         (command_line_input): Adjust.
5697         * cli/cli-script.c (script_from_file): Adjust.
5698
5699 2019-02-19  Tom Tromey  <tromey@adacore.com>
5700
5701         * ravenscar-thread.c
5702         (ravenscar_thread_target::update_thread_list): Don't call
5703         ada_build_task_list.
5704         * ada-lang.h (ada_build_task_list): Don't declare.
5705         * ada-tasks.c (struct ada_tasks_inferior_data)
5706         <task_list_valid_p>: Now bool.
5707         (read_known_tasks, ada_task_list_changed)
5708         (ada_tasks_invalidate_inferior_data): Update.
5709         (read_known_tasks_array): Return bool.
5710         (read_known_tasks_list): Likewise.
5711         (read_known_tasks): Return void.
5712         (ada_build_task_list): Now static.
5713
5714 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5715
5716         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5717         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5718
5719 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5720
5721         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5722         variant for ada_tasks_pspace_data_handle and
5723         ada_tasks_inferior_data_handle.
5724         (ada_tasks_pspace_data_cleanup): New function.
5725         (ada_tasks_inferior_data_cleanup): New function.
5726
5727 2019-02-17  Tom Tromey  <tom@tromey.com>
5728
5729         * macrotab.h (macro_source_fullname): Return a std::string.
5730         * macrotab.c (macro_include, check_for_redefinition)
5731         (macro_undef, macro_lookup_definition, foreach_macro)
5732         (foreach_macro_in_scope): Update.
5733         (macro_source_fullname): Return a std::string.
5734         * macrocmd.c (show_pp_source_pos): Update.
5735
5736 2019-02-17  Tom Tromey  <tom@tromey.com>
5737
5738         * macrocmd.c (show_pp_source_pos): Style the file names.
5739
5740 2019-02-17  Tom Tromey  <tom@tromey.com>
5741
5742         PR tui/24197:
5743         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5744
5745 2019-02-17  Tom Tromey  <tom@tromey.com>
5746
5747         * ada-lang.c (user_select_syms): Use filtered printing.
5748         * utils.c (wrap_style): New global.
5749         (desired_style): Remove.
5750         (emit_style_escape): Add stream parameter.
5751         (set_output_style, reset_terminal_style, prompt_for_continue):
5752         Update.
5753         (flush_wrap_buffer): Only flush gdb_stdout.
5754         (wrap_here): Set wrap_style.
5755         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5756         treat escape sequences as a character.  Change when wrap buffer is
5757         flushed.
5758         (fputs_styled): Do not set the output style when the default is
5759         requested.
5760         * ui-style.h (struct ui_file_style) <is_default>: New method.
5761         * source.c (print_source_lines_base): Emit escape sequences in one
5762         piece.
5763
5764 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5765
5766         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5767         integers and enumeration types.
5768
5769 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5770
5771         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5772         instead of lookup_symbol_in_language
5773         (do_exact_match): New function.
5774         (ada_get_symbol_name_matcher): Return do_exact_match when
5775         doing a verbatim match.
5776
5777 2019-02-15  Tom Tromey  <tromey@adacore.com>
5778
5779         * ravenscar-thread.c (ravenscar_thread_target::resume)
5780         (ravenscar_thread_target::wait): Special case wildcard requests.
5781
5782 2019-02-15  Tom Tromey  <tromey@adacore.com>
5783
5784         * ravenscar-thread.c (base_ptid): Remove.
5785         (struct ravenscar_thread_target) <close>: New method.
5786         <m_base_ptid>: New member.
5787         <update_inferior_ptid, active_task, task_is_currently_active,
5788         runtime_initialized>: Declare methods.
5789         <ravenscar_thread_target>: Add constructor.
5790         (ravenscar_thread_target::task_is_currently_active)
5791         (ravenscar_thread_target::update_inferior_ptid)
5792         (ravenscar_runtime_initialized): Rename.  Now methods.
5793         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5794         (ravenscar_thread_target::update_thread_list): Update.
5795         (ravenscar_thread_target::active_task): Now method.
5796         (ravenscar_thread_target::store_registers)
5797         (ravenscar_thread_target::prepare_to_store)
5798         (ravenscar_thread_target::prepare_to_store)
5799         (ravenscar_thread_target::mourn_inferior): Update.
5800         (ravenscar_inferior_created): Use "new" to create target.
5801         (ravenscar_thread_target::get_ada_task_ptid): Update.
5802         (_initialize_ravenscar): Don't initialize base_ptid.
5803         (ravenscar_ops): Remove global.
5804
5805 2019-02-15  Tom Tromey  <tromey@adacore.com>
5806
5807         * target.h (push_target): Declare new overload.
5808         * target.c (push_target): New overload, taking an rvalue reference.
5809         * remote.c (remote_target::open_1): Use push_target overload.
5810         * corelow.c (core_target_open): Use push_target overload.
5811
5812 2019-02-15  Tom Tromey  <tromey@adacore.com>
5813
5814         * ravenscar-thread.c (is_ravenscar_task)
5815         (ravenscar_task_is_currently_active): Return bool.
5816         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5817         (_initialize_ravenscar): Remove "(void)".
5818         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5819         Return bool.
5820
5821 2019-02-15  Tom Tromey  <tromey@adacore.com>
5822
5823         * ravenscar-thread.c (ravenscar_runtime_initializer)
5824         (has_ravenscar_runtime, get_running_thread_id)
5825         (ravenscar_thread_target::resume): Fix indentation.
5826
5827 2019-02-15  Tom Tromey  <tromey@adacore.com>
5828
5829         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5830         from ravenscar_arch_ops.
5831         (sparc_ravenscar_ops::fetch_registers)
5832         (sparc_ravenscar_ops::store_registers): Now methods.
5833         (sparc_ravenscar_prepare_to_store): Remove.
5834         (sparc_ravenscar_ops): Redefine.
5835         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5836         methods and destructor.  Remove members.
5837         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5838         (ravenscar_thread_target::store_registers)
5839         (ravenscar_thread_target::prepare_to_store): Update.
5840         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5841         Remove.
5842         (struct ppc_ravenscar_powerpc_ops): Derive from
5843         ravenscar_arch_ops.
5844         (ppc_ravenscar_powerpc_ops::fetch_registers)
5845         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5846         (ppc_ravenscar_powerpc_ops): Redefine.
5847         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5848         (ppc_ravenscar_e500_ops::fetch_registers)
5849         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5850         (ppc_ravenscar_e500_ops): Redefine.
5851         * aarch64-ravenscar-thread.c
5852         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5853         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5854         (aarch64_ravenscar_fetch_registers)
5855         (aarch64_ravenscar_store_registers): Now methods.
5856         (aarch64_ravenscar_ops): Redefine.
5857
5858 2019-02-15  Tom Tromey  <tromey@adacore.com>
5859
5860         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5861         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5862         (ravenscar_thread_target::stopped_by_watchpoint)
5863         (ravenscar_thread_target::stopped_data_address)
5864         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5865
5866 2019-02-15  Tom Tromey  <tromey@adacore.com>
5867
5868         * ravenscar-thread.c: Fix some typos.
5869
5870 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5871             Tom Tromey  <tromey@adacore.com>
5872
5873         * ada-lang.c (ada_exception_sal): Change addr_string to a
5874         std::string.
5875         (create_ada_exception_catchpoint): Update.
5876
5877 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5878             Tom Tromey  <tromey@adacore.com>
5879
5880         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5881         (bp_location_ops): Remove.
5882         (base_breakpoint_allocate_location): Update.
5883         (free_bp_location): Update.
5884         * ada-lang.c (class ada_catchpoint_location)
5885         <ada_catchpoint_location>: Remove ops parameter.
5886         (ada_catchpoint_location_dtor): Remove.
5887         (ada_catchpoint_location_ops): Remove.
5888         (allocate_location_exception): Update.
5889         * breakpoint.h (struct bp_location_ops): Remove.
5890         (class bp_location) <bp_location>: Remove bp_location_ops
5891         parameter.
5892         <~bp_location>: Add destructor.
5893         <ops>: Remove.
5894
5895 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5896             Pedro Alves  <palves@redhat.com>
5897
5898         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5899         'PATH_MAX'.
5900
5901 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5902             Samuel Thibault  <samuel.thibault@gnu.org>
5903             Thomas Schwinge  <thomas@codesourcery.com>
5904
5905         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5906         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5907
5908 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5909
5910         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5911         (check_empty): Use "const char *".
5912
5913         * gnu-nat.c (gnu_nat_target::detach): Instead of
5914         'detach_inferior (pid)' call
5915         'detach_inferior (find_inferior_pid (pid))'.
5916
5917         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5918         'nat/fork-inferior.o'.
5919         * gnu-nat.c: #include "nat/fork-inferior.h".
5920
5921         * gnu-nat.c (gnu_nat_target::detach): Instead of
5922         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5923         * gnu-nat.h: #include "inf-child.h".
5924         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5925         'i386_gnu_nat_target::fetch_registers'.
5926         (gnu_store_registers): Rename/move to
5927         'i386_gnu_nat_target::store_registers'.
5928
5929         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5930         * gnu-nat.h (mach_thread_info): New function.
5931         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5932
5933         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5934
5935 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5936
5937         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5938
5939 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5940
5941         * windows-nat.c (windows_add_thread): Add new parameter
5942         "main_thread_p" with default value set to false.  Update
5943         function documentation as well as all callers.
5944         (windows_delete_thread): Likewise.
5945         (fake_create_process): Update call to windows_add_thread.
5946         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5947         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5948         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5949         call to windows_delete_thread.
5950
5951 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5952
5953         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5954
5955 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5956
5957         * symfile.c (find_separate_debug_file): Use canonical path of
5958         sysroot with child_path instead of gdb_sysroot if it is valid.
5959
5960 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5961
5962         * symfile.c (find_separate_debug_file): Use child_path to
5963         determine if an object file is under a sysroot.
5964
5965 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5966
5967         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5968         unittests/child-path-selftests.c.
5969         * common/pathstuff.c (child_path): New function.
5970         * common/pathstuff.h (child_path): New prototype.
5971         * unittests/child-path-selftests.c: New file.
5972
5973 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5974
5975         * symfile.c (find_separate_debug_file): Look for separate debug
5976         files in debug directories under the sysroot.
5977
5978 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5979
5980         * symtab.h (struct minimal_symbol data_p): New const method.
5981         (struct minimal_symbol text_p): Likewise.
5982         * symtab.c (output_source_filename): Use file name style
5983         to print file name.
5984         (print_symbol_info): Likewise.
5985         (print_msymbol_info): Use address style to print addresses.
5986         Use function name style to print executable text symbols.
5987         (expand_symtab_containing_pc): Use data_p.
5988         (find_pc_sect_compunit_symtab): Likewise.
5989
5990 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5991
5992         * breakpoint.c (describe_other_breakpoints): Use address style
5993         to print addresses.
5994         (say_where): Likewise.
5995
5996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5997
5998         * ada-typeprint.c (print_func_type): Print function name
5999         style to print function name.
6000         * c-typeprint.c (c_print_type_1): Likewise.
6001
6002 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6003
6004         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6005         for execve.
6006
6007 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6008
6009         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6010         type_stack.
6011
6012 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6013
6014         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6015         TYPE_CODE_REF types.
6016
6017 2019-02-08  Jim Wilson  <jimw@sifive.com>
6018
6019         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6020         (riscv_linux_fregset): New.
6021         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6022
6023 2019-02-07  Tom Tromey  <tom@tromey.com>
6024
6025         * thread.c (thread_cancel_execution_command): Update.
6026         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6027         methods.
6028         (struct thread_fsm_ops): Remove.
6029         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6030         (thread_fsm_should_stop, thread_fsm_return_value)
6031         (thread_fsm_set_finished, thread_fsm_finished_p)
6032         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6033         Don't declare.
6034         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6035         * infrun.c (clear_proceed_status_thread)
6036         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6037         (print_stop_event): Update.
6038         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6039         Add constructor.
6040         (step_command_fsm_ops): Remove.
6041         (new_step_command_fsm): Remove.
6042         (step_1): Update.
6043         (step_command_fsm::should_stop): Rename from
6044         step_command_fsm_should_stop.
6045         (step_command_fsm::clean_up): Rename from
6046         step_command_fsm_clean_up.
6047         (step_command_fsm::do_async_reply_reason): Rename from
6048         step_command_fsm_async_reply_reason.
6049         (struct until_next_fsm): Inherit from thread_fsm.  Add
6050         constructor.
6051         (until_next_fsm_ops): Remove.
6052         (new_until_next_fsm): Remove.
6053         (until_next_fsm::should_stop): Rename from
6054         until_next_fsm_should_stop.
6055         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6056         (until_next_fsm::do_async_reply_reason): Rename from
6057         until_next_fsm_async_reply_reason.
6058         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6059         constructor.  Change type of breakpoint.
6060         (finish_command_fsm_ops): Remove.
6061         (new_finish_command_fsm): Remove.
6062         (finish_command_fsm::should_stop): Rename from
6063         finish_command_fsm_should_stop.
6064         (finish_command_fsm::clean_up): Rename from
6065         finish_command_fsm_clean_up.
6066         (finish_command_fsm::return_value): Rename from
6067         finish_command_fsm_return_value.
6068         (finish_command_fsm::do_async_reply_reason): Rename from
6069         finish_command_fsm_async_reply_reason.
6070         (finish_command): Update.
6071         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6072         Add constructor.
6073         (call_thread_fsm_ops): Remove.
6074         (call_thread_fsm::call_thread_fsm): Rename from
6075         new_call_thread_fsm.
6076         (call_thread_fsm::should_stop): Rename from
6077         call_thread_fsm_should_stop.
6078         (call_thread_fsm::should_notify_stop): Rename from
6079         call_thread_fsm_should_notify_stop.
6080         (run_inferior_call, call_function_by_hand_dummy): Update.
6081         * cli/cli-interp.c (should_print_stop_to_console): Update.
6082         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6083         Add constructor.  Change type of location_breakpoint,
6084         caller_breakpoint.
6085         (until_break_fsm_ops): Remove.
6086         (new_until_break_fsm): Remove.
6087         (until_break_fsm::should_stop): Rename from
6088         until_break_fsm_should_stop.
6089         (until_break_fsm::clean_up): Rename from
6090         until_break_fsm_clean_up.
6091         (until_break_fsm::do_async_reply_reason): Rename from
6092         until_break_fsm_async_reply_reason.
6093         (until_break_command): Update.
6094         * thread-fsm.c: Remove.
6095         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6096
6097 2019-02-07  Tom Tromey  <tom@tromey.com>
6098
6099         * yy-remap.h: Add include guard.
6100         * xtensa-tdep.h: Add include guard.
6101         * xcoffread.h: Rename include guard.
6102         * varobj-iter.h: Add include guard.
6103         * tui/tui.h: Rename include guard.
6104         * tui/tui-winsource.h: Rename include guard.
6105         * tui/tui-wingeneral.h: Rename include guard.
6106         * tui/tui-windata.h: Rename include guard.
6107         * tui/tui-win.h: Rename include guard.
6108         * tui/tui-stack.h: Rename include guard.
6109         * tui/tui-source.h: Rename include guard.
6110         * tui/tui-regs.h: Rename include guard.
6111         * tui/tui-out.h: Rename include guard.
6112         * tui/tui-layout.h: Rename include guard.
6113         * tui/tui-io.h: Rename include guard.
6114         * tui/tui-hooks.h: Rename include guard.
6115         * tui/tui-file.h: Rename include guard.
6116         * tui/tui-disasm.h: Rename include guard.
6117         * tui/tui-data.h: Rename include guard.
6118         * tui/tui-command.h: Rename include guard.
6119         * tic6x-tdep.h: Add include guard.
6120         * target/waitstatus.h: Rename include guard.
6121         * target/wait.h: Rename include guard.
6122         * target/target.h: Rename include guard.
6123         * target/resume.h: Rename include guard.
6124         * target-float.h: Rename include guard.
6125         * stabsread.h: Add include guard.
6126         * rs6000-tdep.h: Add include guard.
6127         * riscv-fbsd-tdep.h: Add include guard.
6128         * regformats/regdef.h: Rename include guard.
6129         * record.h: Rename include guard.
6130         * python/python.h: Rename include guard.
6131         * python/python-internal.h: Rename include guard.
6132         * python/py-stopevent.h: Rename include guard.
6133         * python/py-ref.h: Rename include guard.
6134         * python/py-record.h: Rename include guard.
6135         * python/py-record-full.h: Rename include guard.
6136         * python/py-record-btrace.h: Rename include guard.
6137         * python/py-instruction.h: Rename include guard.
6138         * python/py-events.h: Rename include guard.
6139         * python/py-event.h: Rename include guard.
6140         * procfs.h: Add include guard.
6141         * proc-utils.h: Add include guard.
6142         * p-lang.h: Add include guard.
6143         * or1k-tdep.h: Rename include guard.
6144         * observable.h: Rename include guard.
6145         * nto-tdep.h: Rename include guard.
6146         * nat/x86-linux.h: Rename include guard.
6147         * nat/x86-linux-dregs.h: Rename include guard.
6148         * nat/x86-gcc-cpuid.h: Add include guard.
6149         * nat/x86-dregs.h: Rename include guard.
6150         * nat/x86-cpuid.h: Rename include guard.
6151         * nat/ppc-linux.h: Rename include guard.
6152         * nat/mips-linux-watch.h: Rename include guard.
6153         * nat/linux-waitpid.h: Rename include guard.
6154         * nat/linux-ptrace.h: Rename include guard.
6155         * nat/linux-procfs.h: Rename include guard.
6156         * nat/linux-osdata.h: Rename include guard.
6157         * nat/linux-nat.h: Rename include guard.
6158         * nat/linux-namespaces.h: Rename include guard.
6159         * nat/linux-btrace.h: Rename include guard.
6160         * nat/glibc_thread_db.h: Rename include guard.
6161         * nat/gdb_thread_db.h: Rename include guard.
6162         * nat/gdb_ptrace.h: Rename include guard.
6163         * nat/fork-inferior.h: Rename include guard.
6164         * nat/amd64-linux-siginfo.h: Rename include guard.
6165         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6166         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6167         * nat/aarch64-linux.h: Rename include guard.
6168         * nat/aarch64-linux-hw-point.h: Rename include guard.
6169         * mn10300-tdep.h: Add include guard.
6170         * mips-linux-tdep.h: Add include guard.
6171         * mi/mi-parse.h: Rename include guard.
6172         * mi/mi-out.h: Rename include guard.
6173         * mi/mi-main.h: Rename include guard.
6174         * mi/mi-interp.h: Rename include guard.
6175         * mi/mi-getopt.h: Rename include guard.
6176         * mi/mi-console.h: Rename include guard.
6177         * mi/mi-common.h: Rename include guard.
6178         * mi/mi-cmds.h: Rename include guard.
6179         * mi/mi-cmd-break.h: Rename include guard.
6180         * m2-lang.h: Add include guard.
6181         * location.h: Rename include guard.
6182         * linux-record.h: Rename include guard.
6183         * linux-nat.h: Add include guard.
6184         * linux-fork.h: Add include guard.
6185         * i386-darwin-tdep.h: Rename include guard.
6186         * hppa-linux-offsets.h: Add include guard.
6187         * guile/guile.h: Rename include guard.
6188         * guile/guile-internal.h: Rename include guard.
6189         * gnu-nat.h: Rename include guard.
6190         * gdb-stabs.h: Rename include guard.
6191         * frv-tdep.h: Add include guard.
6192         * f-lang.h: Add include guard.
6193         * event-loop.h: Add include guard.
6194         * darwin-nat.h: Rename include guard.
6195         * cp-abi.h: Rename include guard.
6196         * config/sparc/nm-sol2.h: Rename include guard.
6197         * config/nm-nto.h: Rename include guard.
6198         * config/nm-linux.h: Add include guard.
6199         * config/i386/nm-i386gnu.h: Rename include guard.
6200         * config/djgpp/nl_types.h: Rename include guard.
6201         * config/djgpp/langinfo.h: Rename include guard.
6202         * compile/gcc-cp-plugin.h: Add include guard.
6203         * compile/gcc-c-plugin.h: Add include guard.
6204         * compile/compile.h: Rename include guard.
6205         * compile/compile-object-run.h: Rename include guard.
6206         * compile/compile-object-load.h: Rename include guard.
6207         * compile/compile-internal.h: Rename include guard.
6208         * compile/compile-cplus.h: Rename include guard.
6209         * compile/compile-c.h: Rename include guard.
6210         * common/xml-utils.h: Rename include guard.
6211         * common/x86-xstate.h: Rename include guard.
6212         * common/version.h: Rename include guard.
6213         * common/vec.h: Rename include guard.
6214         * common/tdesc.h: Rename include guard.
6215         * common/selftest.h: Rename include guard.
6216         * common/scoped_restore.h: Rename include guard.
6217         * common/scoped_mmap.h: Rename include guard.
6218         * common/scoped_fd.h: Rename include guard.
6219         * common/safe-iterator.h: Rename include guard.
6220         * common/run-time-clock.h: Rename include guard.
6221         * common/refcounted-object.h: Rename include guard.
6222         * common/queue.h: Rename include guard.
6223         * common/ptid.h: Rename include guard.
6224         * common/print-utils.h: Rename include guard.
6225         * common/preprocessor.h: Rename include guard.
6226         * common/pathstuff.h: Rename include guard.
6227         * common/observable.h: Rename include guard.
6228         * common/netstuff.h: Rename include guard.
6229         * common/job-control.h: Rename include guard.
6230         * common/host-defs.h: Rename include guard.
6231         * common/gdb_wait.h: Rename include guard.
6232         * common/gdb_vecs.h: Rename include guard.
6233         * common/gdb_unlinker.h: Rename include guard.
6234         * common/gdb_unique_ptr.h: Rename include guard.
6235         * common/gdb_tilde_expand.h: Rename include guard.
6236         * common/gdb_sys_time.h: Rename include guard.
6237         * common/gdb_string_view.h: Rename include guard.
6238         * common/gdb_splay_tree.h: Rename include guard.
6239         * common/gdb_setjmp.h: Rename include guard.
6240         * common/gdb_ref_ptr.h: Rename include guard.
6241         * common/gdb_optional.h: Rename include guard.
6242         * common/gdb_locale.h: Rename include guard.
6243         * common/gdb_assert.h: Rename include guard.
6244         * common/filtered-iterator.h: Rename include guard.
6245         * common/filestuff.h: Rename include guard.
6246         * common/fileio.h: Rename include guard.
6247         * common/environ.h: Rename include guard.
6248         * common/common-utils.h: Rename include guard.
6249         * common/common-types.h: Rename include guard.
6250         * common/common-regcache.h: Rename include guard.
6251         * common/common-inferior.h: Rename include guard.
6252         * common/common-gdbthread.h: Rename include guard.
6253         * common/common-exceptions.h: Rename include guard.
6254         * common/common-defs.h: Rename include guard.
6255         * common/common-debug.h: Rename include guard.
6256         * common/cleanups.h: Rename include guard.
6257         * common/buffer.h: Rename include guard.
6258         * common/btrace-common.h: Rename include guard.
6259         * common/break-common.h: Rename include guard.
6260         * cli/cli-utils.h: Rename include guard.
6261         * cli/cli-style.h: Rename include guard.
6262         * cli/cli-setshow.h: Rename include guard.
6263         * cli/cli-script.h: Rename include guard.
6264         * cli/cli-interp.h: Rename include guard.
6265         * cli/cli-decode.h: Rename include guard.
6266         * cli/cli-cmds.h: Rename include guard.
6267         * charset-list.h: Add include guard.
6268         * buildsym-legacy.h: Rename include guard.
6269         * bfin-tdep.h: Add include guard.
6270         * ax.h: Rename include guard.
6271         * arm-linux-tdep.h: Add include guard.
6272         * arm-fbsd-tdep.h: Add include guard.
6273         * arch/xtensa.h: Rename include guard.
6274         * arch/tic6x.h: Add include guard.
6275         * arch/i386.h: Add include guard.
6276         * arch/arm.h: Rename include guard.
6277         * arch/arm-linux.h: Rename include guard.
6278         * arch/arm-get-next-pcs.h: Rename include guard.
6279         * arch/amd64.h: Add include guard.
6280         * arch/aarch64-insn.h: Rename include guard.
6281         * arch-utils.h: Rename include guard.
6282         * annotate.h: Add include guard.
6283         * amd64-darwin-tdep.h: Rename include guard.
6284         * aarch64-linux-tdep.h: Add include guard.
6285         * aarch64-fbsd-tdep.h: Add include guard.
6286         * aarch32-linux-nat.h: Add include guard.
6287
6288 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6289
6290         * macrotab.c (macro_define_internal): New function that
6291         factorizes macro_define_object_internal and macro_define_function
6292         code.
6293         (macro_define_object_internal): Use macro_define_internal.
6294         (macro_define_function): Likewise.
6295
6296 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6297
6298         * macrocmd.c (extract_identifier): Return
6299         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6300         callers.
6301
6302 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6303
6304         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6305
6306 2019-02-05  Tom Tromey  <tom@tromey.com>
6307
6308         * target.c (target_stack::unpush): Move assertion earlier.
6309
6310 2019-01-30  Tom Tromey  <tom@tromey.com>
6311
6312         PR python/23615:
6313         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6314         (gdbpy_parse_and_eval): Likewise.
6315         * python/python-internal.h (gdbpy_allow_threads): New class.
6316
6317 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6318
6319         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6320         (aarch64_fbsd_fpregmap): Move earlier.
6321         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6322         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6323         instead of individual calls to trad_frame_set_reg_addr.
6324         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6325         earlier.
6326         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6327         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6328         instead of individual calls to trad_frame_set_reg_addr.
6329
6330 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6331
6332         * CONTRIBUTE: Replace contribution list with wiki link.
6333
6334 2019-01-25  Tom Tromey  <tom@tromey.com>
6335
6336         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6337
6338 2019-01-25  Tom Tromey  <tom@tromey.com>
6339
6340         * xtensa-linux-nat.c: Fix common/ includes.
6341         * xml-support.h: Fix common/ includes.
6342         * xml-support.c: Fix common/ includes.
6343         * x86-linux-nat.c: Fix common/ includes.
6344         * windows-nat.c: Fix common/ includes.
6345         * varobj.h: Fix common/ includes.
6346         * varobj.c: Fix common/ includes.
6347         * value.c: Fix common/ includes.
6348         * valops.c: Fix common/ includes.
6349         * utils.c: Fix common/ includes.
6350         * unittests/xml-utils-selftests.c: Fix common/ includes.
6351         * unittests/utils-selftests.c: Fix common/ includes.
6352         * unittests/unpack-selftests.c: Fix common/ includes.
6353         * unittests/tracepoint-selftests.c: Fix common/ includes.
6354         * unittests/style-selftests.c: Fix common/ includes.
6355         * unittests/string_view-selftests.c: Fix common/ includes.
6356         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6357         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6358         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6359         * unittests/rsp-low-selftests.c: Fix common/ includes.
6360         * unittests/parse-connection-spec-selftests.c: Fix common/
6361         includes.
6362         * unittests/optional-selftests.c: Fix common/ includes.
6363         * unittests/offset-type-selftests.c: Fix common/ includes.
6364         * unittests/observable-selftests.c: Fix common/ includes.
6365         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6366         * unittests/memrange-selftests.c: Fix common/ includes.
6367         * unittests/memory-map-selftests.c: Fix common/ includes.
6368         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6369         * unittests/function-view-selftests.c: Fix common/ includes.
6370         * unittests/environ-selftests.c: Fix common/ includes.
6371         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6372         * unittests/common-utils-selftests.c: Fix common/ includes.
6373         * unittests/cli-utils-selftests.c: Fix common/ includes.
6374         * unittests/array-view-selftests.c: Fix common/ includes.
6375         * ui-file.c: Fix common/ includes.
6376         * tui/tui-io.c: Fix common/ includes.
6377         * tracepoint.h: Fix common/ includes.
6378         * tracepoint.c: Fix common/ includes.
6379         * tracefile-tfile.c: Fix common/ includes.
6380         * top.h: Fix common/ includes.
6381         * top.c: Fix common/ includes.
6382         * thread.c: Fix common/ includes.
6383         * target/waitstatus.h: Fix common/ includes.
6384         * target/waitstatus.c: Fix common/ includes.
6385         * target.h: Fix common/ includes.
6386         * target.c: Fix common/ includes.
6387         * target-memory.c: Fix common/ includes.
6388         * target-descriptions.c: Fix common/ includes.
6389         * symtab.h: Fix common/ includes.
6390         * symfile.c: Fix common/ includes.
6391         * stap-probe.c: Fix common/ includes.
6392         * spu-linux-nat.c: Fix common/ includes.
6393         * sparc-nat.c: Fix common/ includes.
6394         * source.c: Fix common/ includes.
6395         * solib.c: Fix common/ includes.
6396         * solib-target.c: Fix common/ includes.
6397         * ser-unix.c: Fix common/ includes.
6398         * ser-tcp.c: Fix common/ includes.
6399         * ser-pipe.c: Fix common/ includes.
6400         * ser-base.c: Fix common/ includes.
6401         * selftest-arch.c: Fix common/ includes.
6402         * s12z-tdep.c: Fix common/ includes.
6403         * rust-exp.y: Fix common/ includes.
6404         * rs6000-aix-tdep.c: Fix common/ includes.
6405         * riscv-tdep.c: Fix common/ includes.
6406         * remote.c: Fix common/ includes.
6407         * remote-notif.h: Fix common/ includes.
6408         * remote-fileio.h: Fix common/ includes.
6409         * remote-fileio.c: Fix common/ includes.
6410         * regcache.h: Fix common/ includes.
6411         * regcache.c: Fix common/ includes.
6412         * record-btrace.c: Fix common/ includes.
6413         * python/python.c: Fix common/ includes.
6414         * python/py-type.c: Fix common/ includes.
6415         * python/py-inferior.c: Fix common/ includes.
6416         * progspace.h: Fix common/ includes.
6417         * producer.c: Fix common/ includes.
6418         * procfs.c: Fix common/ includes.
6419         * proc-api.c: Fix common/ includes.
6420         * printcmd.c: Fix common/ includes.
6421         * ppc-linux-nat.c: Fix common/ includes.
6422         * parser-defs.h: Fix common/ includes.
6423         * osdata.c: Fix common/ includes.
6424         * obsd-nat.c: Fix common/ includes.
6425         * nat/x86-linux.c: Fix common/ includes.
6426         * nat/x86-linux-dregs.c: Fix common/ includes.
6427         * nat/x86-dregs.h: Fix common/ includes.
6428         * nat/x86-dregs.c: Fix common/ includes.
6429         * nat/ppc-linux.c: Fix common/ includes.
6430         * nat/mips-linux-watch.h: Fix common/ includes.
6431         * nat/mips-linux-watch.c: Fix common/ includes.
6432         * nat/linux-waitpid.c: Fix common/ includes.
6433         * nat/linux-ptrace.h: Fix common/ includes.
6434         * nat/linux-ptrace.c: Fix common/ includes.
6435         * nat/linux-procfs.c: Fix common/ includes.
6436         * nat/linux-personality.c: Fix common/ includes.
6437         * nat/linux-osdata.c: Fix common/ includes.
6438         * nat/linux-namespaces.c: Fix common/ includes.
6439         * nat/linux-btrace.h: Fix common/ includes.
6440         * nat/linux-btrace.c: Fix common/ includes.
6441         * nat/fork-inferior.c: Fix common/ includes.
6442         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6443         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6444         * nat/aarch64-linux.c: Fix common/ includes.
6445         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6446         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6447         * namespace.h: Fix common/ includes.
6448         * mips-linux-tdep.c: Fix common/ includes.
6449         * minsyms.c: Fix common/ includes.
6450         * mi/mi-parse.h: Fix common/ includes.
6451         * mi/mi-main.c: Fix common/ includes.
6452         * mi/mi-cmd-env.c: Fix common/ includes.
6453         * memrange.h: Fix common/ includes.
6454         * memattr.c: Fix common/ includes.
6455         * maint.h: Fix common/ includes.
6456         * maint.c: Fix common/ includes.
6457         * main.c: Fix common/ includes.
6458         * machoread.c: Fix common/ includes.
6459         * location.c: Fix common/ includes.
6460         * linux-thread-db.c: Fix common/ includes.
6461         * linux-nat.c: Fix common/ includes.
6462         * linux-fork.c: Fix common/ includes.
6463         * inline-frame.c: Fix common/ includes.
6464         * infrun.c: Fix common/ includes.
6465         * inflow.c: Fix common/ includes.
6466         * inferior.h: Fix common/ includes.
6467         * inferior.c: Fix common/ includes.
6468         * infcmd.c: Fix common/ includes.
6469         * inf-ptrace.c: Fix common/ includes.
6470         * inf-child.c: Fix common/ includes.
6471         * ia64-linux-nat.c: Fix common/ includes.
6472         * i387-tdep.c: Fix common/ includes.
6473         * i386-tdep.c: Fix common/ includes.
6474         * i386-linux-tdep.c: Fix common/ includes.
6475         * i386-linux-nat.c: Fix common/ includes.
6476         * i386-go32-tdep.c: Fix common/ includes.
6477         * i386-fbsd-tdep.c: Fix common/ includes.
6478         * i386-fbsd-nat.c: Fix common/ includes.
6479         * guile/scm-type.c: Fix common/ includes.
6480         * guile/guile.c: Fix common/ includes.
6481         * go32-nat.c: Fix common/ includes.
6482         * gnu-nat.c: Fix common/ includes.
6483         * gdbthread.h: Fix common/ includes.
6484         * gdbarch-selftests.c: Fix common/ includes.
6485         * gdb_usleep.c: Fix common/ includes.
6486         * gdb_select.h: Fix common/ includes.
6487         * gdb_bfd.c: Fix common/ includes.
6488         * gcore.c: Fix common/ includes.
6489         * fork-child.c: Fix common/ includes.
6490         * findvar.c: Fix common/ includes.
6491         * fbsd-nat.c: Fix common/ includes.
6492         * event-top.c: Fix common/ includes.
6493         * event-loop.c: Fix common/ includes.
6494         * dwarf2read.c: Fix common/ includes.
6495         * dwarf2loc.c: Fix common/ includes.
6496         * dwarf2-frame.c: Fix common/ includes.
6497         * dwarf-index-cache.c: Fix common/ includes.
6498         * dtrace-probe.c: Fix common/ includes.
6499         * disasm-selftests.c: Fix common/ includes.
6500         * defs.h: Fix common/ includes.
6501         * csky-tdep.c: Fix common/ includes.
6502         * cp-valprint.c: Fix common/ includes.
6503         * cp-support.h: Fix common/ includes.
6504         * cp-support.c: Fix common/ includes.
6505         * corelow.c: Fix common/ includes.
6506         * completer.h: Fix common/ includes.
6507         * completer.c: Fix common/ includes.
6508         * compile/compile.c: Fix common/ includes.
6509         * compile/compile-loc2c.c: Fix common/ includes.
6510         * compile/compile-cplus-types.c: Fix common/ includes.
6511         * compile/compile-cplus-symbols.c: Fix common/ includes.
6512         * command.h: Fix common/ includes.
6513         * cli/cli-dump.c: Fix common/ includes.
6514         * cli/cli-cmds.c: Fix common/ includes.
6515         * charset.c: Fix common/ includes.
6516         * build-id.c: Fix common/ includes.
6517         * btrace.h: Fix common/ includes.
6518         * btrace.c: Fix common/ includes.
6519         * breakpoint.h: Fix common/ includes.
6520         * breakpoint.c: Fix common/ includes.
6521         * ax.h:
6522         (enum agent_op): Fix common/ includes.
6523         * ax-general.c (struct aop_map): Fix common/ includes.
6524         * ax-gdb.c: Fix common/ includes.
6525         * auxv.c: Fix common/ includes.
6526         * auto-load.c: Fix common/ includes.
6527         * arm-tdep.c: Fix common/ includes.
6528         * arch/riscv.c: Fix common/ includes.
6529         * arch/ppc-linux-common.c: Fix common/ includes.
6530         * arch/i386.c: Fix common/ includes.
6531         * arch/arm.c: Fix common/ includes.
6532         * arch/arm-linux.c: Fix common/ includes.
6533         * arch/arm-get-next-pcs.c: Fix common/ includes.
6534         * arch/amd64.c: Fix common/ includes.
6535         * arch/aarch64.c: Fix common/ includes.
6536         * arch/aarch64-insn.c: Fix common/ includes.
6537         * arch-utils.c: Fix common/ includes.
6538         * amd64-windows-tdep.c: Fix common/ includes.
6539         * amd64-tdep.c: Fix common/ includes.
6540         * amd64-sol2-tdep.c: Fix common/ includes.
6541         * amd64-obsd-tdep.c: Fix common/ includes.
6542         * amd64-nbsd-tdep.c: Fix common/ includes.
6543         * amd64-linux-tdep.c: Fix common/ includes.
6544         * amd64-linux-nat.c: Fix common/ includes.
6545         * amd64-fbsd-tdep.c: Fix common/ includes.
6546         * amd64-fbsd-nat.c: Fix common/ includes.
6547         * amd64-dicos-tdep.c: Fix common/ includes.
6548         * amd64-darwin-tdep.c: Fix common/ includes.
6549         * agent.c: Fix common/ includes.
6550         * ada-lang.h: Fix common/ includes.
6551         * ada-lang.c: Fix common/ includes.
6552         * aarch64-tdep.c: Fix common/ includes.
6553
6554 2019-01-25  Tom Tromey  <tom@tromey.com>
6555
6556         * common/create-version.sh: Use common/version.h.
6557
6558 2019-01-24  Pedro Alves  <palves@redhat.com>
6559
6560         * infrun.c (signal_stop, signal_print, signal_program)
6561         (signal_catch, signal_pass): Now arrays instead of pointers.
6562         (update_signals_program_target, do_target_resume)
6563         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6564         * linux-nat.c (linux_nat_target::pass_signals)
6565         (linux_nat_target::create_inferior, linux_nat_target::attach):
6566         Adjust.
6567         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6568         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6569         * procfs.c (procfs_target::pass_signals): Adjust.
6570         * record-full.c (record_full_target::resume): Adjust.
6571         * remote.c (remote_target::pass_signals)
6572         (remote_target::program_signals): Adjust.
6573         * target-debug.h (target_debug_print_signals): Now takes a
6574         gdb::array_view as parameter.  Adjust.
6575         * target.h (target_ops) <pass_signals, program_signals>: Replace
6576         pointer and length parameters with gdb::array_view.
6577         (target_pass_signals, target_program_signals): Likewise.
6578         * target-delegates.c: Regenerate.
6579
6580 2019-01-24  Pedro Alves  <palves@redhat.com>
6581
6582         * common/forward-scope-exit.h
6583         (forward_scope_exit::forward_scope_exit): Pass arguments to
6584         m_bind_function directly, instead of creating a std::bind and
6585         copying that.
6586
6587 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6588
6589         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6590         for static members.
6591         (pass_in_v_vfp_candidate): Likewise.
6592
6593 2019-01-23  Tom Tromey  <tom@tromey.com>
6594             Pedro Alves  <palves@redhat.com>
6595
6596         * regcache.c (class regcache_invalidator): Remove.
6597         (regcache::raw_write): Use make_scope_exit.
6598
6599 2019-01-23  Tom Tromey  <tom@tromey.com>
6600
6601         * ui-out.h (class ui_out_emit_type): Update comment.
6602
6603 2019-01-23  Tom Tromey  <tom@tromey.com>
6604
6605         * infrun.c (fetch_inferior_event): Update comment.
6606
6607 2019-01-23  Tom Tromey  <tom@tromey.com>
6608             Pedro Alves  <palves@redhat.com>
6609
6610         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6611         parameter.
6612         (fetch_inferior_event): Use SCOPE_EXIT.
6613
6614
6615 2019-01-23  Tom Tromey  <tom@tromey.com>
6616             Pedro Alves  <palves@redhat.com>
6617
6618         * infrun.c (disable_thread_events): Delete.
6619         (stop_all_threads): Use SCOPE_EXIT.
6620
6621 2019-01-23  Tom Tromey  <tom@tromey.com>
6622             Pedro Alves  <palves@redhat.com>
6623
6624         * symfile.c: Include forward-scope-exit.h.
6625         (clear_symtab_users_cleanup): Replace forward declaration with
6626         a FORWARD_SCOPE_EXIT.
6627         (syms_from_objfile_1): Use the forward_scope_exit and
6628         gdb::optional instead of cleanup_function.
6629         (reread_symbols): Use the forward_scope_exit instead of
6630         cleanup_function.
6631         (clear_symtab_users_cleanup): Remove function.
6632
6633 2019-01-23  Tom Tromey  <tom@tromey.com>
6634             Pedro Alves  <palves@redhat.com>
6635
6636         * linux-nat.c: Include scope-exit.h.
6637         (cleanup_target_stop): Remove.
6638         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6639         SCOPE_EXIT.
6640
6641 2019-01-23  Tom Tromey  <tom@tromey.com>
6642             Pedro Alves  <palves@redhat.com>
6643
6644         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6645         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6646
6647 2019-01-23  Tom Tromey  <tom@tromey.com>
6648             Andrew Burgess  <andrew.burgess@embecosm.com>
6649             Pedro Alves  <palves@redhat.com>
6650
6651         * infrun.c (fetch_inferior_event): Use scope_exit.
6652         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6653         * top.c (execute_command): Use scope_exit.
6654         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6655         * utils.c (do_bpstat_clear_actions_cleanup)
6656         (make_bpstat_clear_actions_cleanup): Remove.
6657
6658 2019-01-23  Tom Tromey  <tom@tromey.com>
6659             Pedro Alves  <palves@redhat.com>
6660
6661         * infrun.c: Include "common/scope-exit.h"
6662         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6663         (wait_for_inferior): Use SCOPE_EXIT.
6664         (fetch_inferior_event): Use scope_exit.
6665
6666 2019-01-23  Tom Tromey  <tom@tromey.com>
6667             Pedro Alves  <palves@redhat.com>
6668
6669         * breakpoint.c (create_breakpoint): Remove cleanup.
6670
6671 2019-01-23  Tom Tromey  <tom@tromey.com>
6672             Andrew Burgess  <andrew.burgess@embecosm.com>
6673             Pedro Alves  <palves@redhat.com>
6674
6675 2019-01-23  Pedro Alves  <palves@redhat.com>
6676
6677         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6678
6679 2019-01-23  Pedro Alves  <palves@redhat.com>
6680             Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * gdbthread.h: Include "common/forward-scope-exit.h".
6683         (scoped_finish_thread_state): Redefine custom class in terms of
6684         forward_scope_exit.
6685
6686 2019-01-23  Pedro Alves  <palves@redhat.com>
6687             Andrew Burgess  <andrew.burgess@embecosm.com>
6688
6689         * common/forward-scope-exit.h: New file.
6690
6691 2019-01-23  Pedro Alves  <palves@redhat.com>
6692             Andrew Burgess  <andrew.burgess@embecosm.com>
6693             Tom Tromey  <tom@tromey.com>
6694
6695         * common/scope-exit.h: New file.
6696
6697 2019-01-23  Pedro Alves  <palves@redhat.com>
6698
6699         * common/preprocessor.h (ESC): Rename to ...
6700         (ESC_PARENS): ... this.
6701         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6702         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6703
6704 2019-01-23  Tom Tromey  <tom@tromey.com>
6705
6706         * language.h (class scoped_switch_to_sym_language_if_auto):
6707         Initialize m_lang in both cases.
6708
6709 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6710
6711         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6712         with XCNEW.
6713
6714 2019-01-22  Tom Tromey  <tom@tromey.com>
6715
6716         * corelow.c: Do not include sys/file.h.
6717
6718 2019-01-22  Tom Tromey  <tom@tromey.com>
6719
6720         * tui/tui-wingeneral.h: Include gdb_curses.h.
6721
6722 2019-01-22  Tom Tromey  <tom@tromey.com>
6723
6724         * source-cache.h (class source_cache) <get_source_lines,
6725         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6726
6727 2019-01-22  Tom Tromey  <tom@tromey.com>
6728
6729         * remote-fileio.h (struct remote_target): Declare.
6730
6731 2019-01-22  Tom Tromey  <tom@tromey.com>
6732
6733         * python/py-arch.c: Do not include py-ref.h.
6734         * python/py-bpevent.c: Do not include py-ref.h.
6735         * python/py-cmd.c: Do not include py-ref.h.
6736         * python/py-continueevent.c: Do not include py-ref.h.
6737         * python/py-event.h: Do not include py-ref.h.
6738         * python/py-evtregistry.c: Do not include py-ref.h.
6739         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6740         * python/py-frame.c: Do not include py-ref.h.
6741         * python/py-framefilter.c: Do not include py-ref.h.
6742         * python/py-function.c: Do not include py-ref.h.
6743         * python/py-infevents.c: Do not include py-ref.h.
6744         * python/py-linetable.c: Do not include py-ref.h.
6745         * python/py-objfile.c: Do not include py-ref.h.
6746         * python/py-param.c: Do not include py-ref.h.
6747         * python/py-prettyprint.c: Do not include py-ref.h.
6748         * python/py-progspace.c: Do not include py-ref.h.
6749         * python/py-symbol.c: Do not include py-ref.h.
6750         * python/py-symtab.c: Do not include py-ref.h.
6751         * python/py-type.c: Do not include py-ref.h.
6752         * python/py-unwind.c: Do not include py-ref.h.
6753         * python/py-utils.c: Do not include py-ref.h.
6754         * python/py-value.c: Do not include py-ref.h.
6755         * python/py-varobj.c: Do not include py-ref.h.
6756         * python/py-xmethods.c: Do not include py-ref.h.
6757         * python/python.c: Do not include py-ref.h.
6758         * varobj.c: Do not include py-ref.h.
6759
6760 2019-01-22  Tom Tromey  <tom@tromey.com>
6761
6762         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6763         keyword for bcache.
6764
6765 2019-01-22  Tom Tromey  <tom@tromey.com>
6766
6767         * compile/compile-cplus-types.c: Remove a comment by #include.
6768
6769 2019-01-22  Tom Tromey  <tom@tromey.com>
6770
6771         * compile/gcc-c-plugin.h: Include compile-internal.h.
6772
6773 2019-01-22  Tom Tromey  <tom@tromey.com>
6774
6775         * stabsread.c (EXTERN): Do not define.
6776         (symnum, next_symbol_text_func, processing_gcc_compilation)
6777         (within_function, global_sym_chain, global_stabs)
6778         (previous_stab_code, this_object_header_files)
6779         (n_this_object_header_files)
6780         (n_allocated_this_object_header_files): Define.
6781         * stabsread.h (EXTERN): Never define.  Use "extern".
6782
6783 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6784
6785         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6786         history_value.
6787
6788 2019-01-21  Tom Tromey  <tom@tromey.com>
6789
6790         * ui-out.c: Fix includes.
6791         * tui/tui-source.c: Fix includes.
6792         * target.c: Fix includes.
6793         * remote.c: Fix includes.
6794         * regcache.c: Fix includes.
6795         * python/py-block.c: Fix includes.
6796         * printcmd.c: Fix includes.
6797         * or1k-tdep.c: Fix includes.
6798         * mi/mi-main.c: Fix includes.
6799         * m32r-tdep.c: Fix includes.
6800         * csky-tdep.c: Fix includes.
6801         * compile/compile-cplus-types.c: Fix includes.
6802         * cli/cli-interp.c: Fix includes.
6803
6804 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6805
6806         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6807         for padding.
6808
6809 2019-01-16  Tom Tromey  <tom@tromey.com>
6810
6811         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6812         earlier.
6813         (struct objfile) <msymbols_range>: Move from top level.
6814         <msymbols>: New method.
6815         (class objfile_msymbols): Remove.
6816         * symtab.c (default_collect_symbol_completion_matches_break_on):
6817         Update.
6818         * symmisc.c (dump_msymbols): Update.
6819         * stabsread.c (scan_file_globals): Update.
6820         * objc-lang.c (info_selectors_command, info_classes_command)
6821         (find_methods): Update.
6822         * minsyms.c (find_solib_trampoline_target): Update.
6823         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6824         * coffread.c (coff_symfile_read): Update.
6825         * ada-lang.c (ada_lookup_simple_minsym)
6826         (ada_collect_symbol_completion_matches): Update.
6827
6828 2019-01-16  Tom Tromey  <tom@tromey.com>
6829
6830         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6831         type.  Remove no-argument constructor.
6832         <iterator::operator++>: Simplify.
6833         <begin>: Update.
6834         <end>: Use minimal_symbol_count.
6835
6836 2019-01-16  Tom Tromey  <tom@tromey.com>
6837
6838         * objfiles.h (struct objfile) <psymtabs>: New method.
6839         (class objfile_psymtabs): Remove.
6840         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6841         typedef.
6842         <range>: New method.
6843         (require_partial_symbols): Change return type.
6844         * psymtab.c (require_partial_symbols)
6845         (psym_expand_symtabs_matching): Update.
6846         * mdebugread.c (parse_partial_symbols): Update.
6847         * dbxread.c (dbx_end_psymtab): Update.
6848
6849 2019-01-15  Tom Tromey  <tom@tromey.com>
6850
6851         * symtab.c (lookup_objfile_from_block)
6852         (lookup_symbol_in_objfile_symtabs)
6853         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6854         (find_line_symtab, info_sources_command)
6855         (default_collect_symbol_completion_matches_break_on)
6856         (make_source_files_completion_list): Update.
6857         * symmisc.c (print_objfile_statistics, dump_objfile)
6858         (maintenance_print_symbols, maintenance_info_symtabs)
6859         (maintenance_check_symtabs, maintenance_info_line_tables):
6860         Update.
6861         * source.c (select_source_symtab)
6862         (forget_cached_source_info_for_objfile): Update.
6863         * objfiles.h (class objfile_compunits): Remove.
6864         (struct objfile) <compunits_range>: New typedef.
6865         (compunits): New method.
6866         * objfiles.c (objfile_relocate1): Update.
6867         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6868         * maint.c (count_symtabs_and_blocks): Update.
6869         * linespec.c (iterate_over_all_matching_symtabs): Update.
6870         * cp-support.c (add_symbol_overload_list_qualified): Update.
6871         * coffread.c (coff_symtab_read): Update.
6872         * ada-lang.c (add_nonlocal_symbols)
6873         (ada_collect_symbol_completion_matches)
6874         (ada_add_global_exceptions): Update.
6875
6876 2019-01-15  Tom Tromey  <tom@tromey.com>
6877
6878         * progspace.h (program_space) <objfiles_safe_range>: New
6879         typedef.
6880         <objfiles_safe>: New method.
6881         * objfiles.h (class all_objfiles_safe): Remove.
6882         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6883         * jit.c (jit_inferior_exit_hook): Update.
6884
6885 2019-01-17  Tom Tromey  <tom@tromey.com>
6886
6887         * progspace.h (program_space) <objfiles_range>: New typedef.
6888         <objfiles>: New method.
6889         <objfiles_head>: Rename from objfiles.
6890         (object_files): Update.
6891         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6892         * guile/scm-pretty-print.c
6893         (ppscm_find_pretty_printer_from_objfiles): Update.
6894         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6895         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6896         Update.
6897         * python/py-progspace.c (pspy_get_objfiles): Update.
6898         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6899         Update.
6900         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6901         (objfpy_lookup_objfile_by_build_id): Update.
6902         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6903         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6904         Update.
6905         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6906         (expand_symtab_containing_pc, lookup_objfile_from_block)
6907         (lookup_static_symbol, basic_lookup_transparent_type)
6908         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6909         (find_line_symtab, info_sources_command)
6910         (default_collect_symbol_completion_matches_break_on)
6911         (make_source_files_completion_list, find_main_name): Update.
6912         * symmisc.c (print_symbol_bcache_statistics)
6913         (print_objfile_statistics, maintenance_print_symbols)
6914         (maintenance_print_msymbols, maintenance_print_objfiles)
6915         (maintenance_info_symtabs, maintenance_check_symtabs)
6916         (maintenance_expand_symtabs, maintenance_info_line_tables):
6917         Update.
6918         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6919         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6920         (map_overlay_command, unmap_overlay_command)
6921         (simple_overlay_update, expand_symtabs_matching)
6922         (map_symbol_filenames): Update.
6923         * symfile-debug.c (set_debug_symfile): Update.
6924         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6925         Update.
6926         * source.c (select_source_symtab, forget_cached_source_info):
6927         Update.
6928         * solib.c (solib_read_symbols): Update.
6929         * solib-spu.c (append_ocl_sos): Update.
6930         * psymtab.c (maintenance_print_psymbols)
6931         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6932         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6933         * printcmd.c (info_symbol_command): Update.
6934         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6935         Update.
6936         * objfiles.h (class all_objfiles): Remove.
6937         * objfiles.c (have_partial_symbols, have_full_symbols)
6938         (have_minimal_symbols, qsort_cmp, update_section_map)
6939         (shared_objfile_contains_address_p)
6940         (default_iterate_over_objfiles_in_search_order): Update.
6941         * objc-lang.c (info_selectors_command, info_classes_command)
6942         (find_methods): Update.
6943         * minsyms.c (find_solib_trampoline_target): Update.
6944         * maint.c (maintenance_info_sections)
6945         (maintenance_translate_address, count_symtabs_and_blocks):
6946         Update.
6947         * main.c (captured_main_1): Update.
6948         * linux-thread-db.c (try_thread_db_load_from_pdir)
6949         (has_libpthread): Update.
6950         * linespec.c (iterate_over_all_matching_symtabs)
6951         (search_minsyms_for_name): Update.
6952         * jit.c (jit_find_objf_with_entry_addr): Update.
6953         * hppa-tdep.c (find_unwind_entry)
6954         (hppa_lookup_stub_minimal_symbol): Update.
6955         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6956         Update.
6957         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6958         (elf_gnu_ifunc_resolve_by_got): Update.
6959         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6960         * dwarf-index-write.c (save_gdb_index_command): Update.
6961         * cp-support.c (add_symbol_overload_list_qualified): Update.
6962         * breakpoint.c (create_overlay_event_breakpoint)
6963         (create_longjmp_master_breakpoint)
6964         (create_std_terminate_master_breakpoint)
6965         (create_exception_master_breakpoint): Update.
6966         * blockframe.c (find_pc_partial_function): Update.
6967         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6968         (ada_collect_symbol_completion_matches)
6969         (ada_add_global_exceptions): Update.
6970
6971 2019-01-17  Tom Tromey  <tom@tromey.com>
6972
6973         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6974         declare VEC.
6975         (solib_target_parse_libraries): Change return type.
6976         (library_list_start_segment, library_list_start_section)
6977         (library_list_end_library, library_list_start_library); Update.
6978         (solib_target_free_library_list): Remove.
6979         (solib_target_parse_libraries): Remove cleanup.  Change return
6980         type.
6981         (solib_target_current_sos): Update.
6982
6983 2019-01-17  Tom Tromey  <tromey@bapiya>
6984
6985         * valprint.c: Replace "the the" with "the".
6986         * symtab.c: Replace "the the" with "the".
6987         * solib.c: Replace "the the" with "the".
6988         * solib-dsbt.c: Replace "the the" with "the".
6989         * linespec.c: Replace "the the" with "the".
6990         * dwarf2loc.h: Replace "the the" with "the".
6991         * amd64-windows-tdep.c: Replace "the the" with "the".
6992         * aarch64-tdep.c: Replace "the the" with "the".
6993
6994 2019-01-16  Keith Seitz  <keiths@redhat.com>
6995
6996         PR gdb/23773
6997         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6998         <builder>: Rename to ..
6999         <m_builder>: ... this and make private.
7000         (dwarf2_cu::get_builder): New method.  Change all users of
7001         `builder' to use this method.
7002         (dwarf2_start_symtab): Move to ...
7003         (dwarf2_cu::start_symtab): ... here.  Update all callers
7004         (setup_type_unit_groups): Move to ...
7005         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7006         callers.
7007         (dwarf2_cu::reset_builder): New method.
7008         (process_full_compunit, process_full_type_unit): Use
7009         dwarf2_cu::reset_builder.
7010         (follow_die_offset): Record the ancestor CU if it is different
7011         from the followed DIE's CU.
7012         (follow_die_sig_1): Likewise.
7013
7014 2019-01-15  Tom Tromey  <tom@tromey.com>
7015
7016         * remote.c (class remote_state) <buf>: Now a char_vector.
7017         <buf_size>: Remove.
7018         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7019         parameter.
7020         (remote_target::getpkt_or_notif_sane_1)
7021         (remote_target::getpkt_sane)
7022         (remote_target::getpkt_or_notif_sane): Likewise.
7023         (class remote_target) <putpkt>: New overload.
7024         (remote_target::read_frame): Change type of "buf_p".  Remove
7025         sizeof_p parameter.
7026         (packet_ok): New overload.
7027         (packet_check_result): New overload.
7028         Update all uses.
7029
7030 2019-01-14  Tom Tromey  <tom@tromey.com>
7031
7032         * remote-notif.c (handle_notification, remote_notif_ack)
7033         (remote_notif_parse): Make "buf" const.
7034         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7035         const.
7036         (remote_notif_parse, remote_notif_ack, handle_notification):
7037         Likewise.
7038         * remote.c (remote_notif_stop_parse): Make "buf" const.
7039         (remote_target::remote_parse_stop_reply): Make "buf" const.
7040         (remote_notif_stop_ack): Make "buf" const.
7041
7042 2019-01-14  Tom Tromey  <tom@tromey.com>
7043
7044         * remote.c (remote_console_output): Make parameter const.
7045
7046 2019-01-14  Tom Tromey  <tom@tromey.com>
7047
7048         * target-debug.h (target_debug_print_signals): Constify.
7049         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7050         * procfs.c (procfs_target::pass_signals): Update.
7051         * linux-nat.c (linux_nat_target::pass_signals): Update.
7052         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7053         * target-delegates.c: Rebuild.
7054         * remote.c (remote_target::program_signals): Update.
7055         (remote_target::pass_signals): Update.
7056         * target.c (target_pass_signals): Constify argument.
7057         (target_program_signals): Likewise.
7058         * target.h (struct target_ops) <pass_signals, program_signals>:
7059         Constify argument.
7060         (target_pass_signals, target_program_signals): Constify argument.
7061
7062 2019-01-14  Tom Tromey  <tom@tromey.com>
7063
7064         PR tui/28819:
7065         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7066
7067 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7068
7069         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7070         field.
7071         * rs6000-tdep.c: Include reggroups.h.
7072         (IS_V_ALIAS_PSEUDOREG): Define.
7073         (rs6000_register_name): Return names for the "vX" aliases.
7074         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7075         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7076         aliases.  Call default_register_reggroup_p for all other
7077         pseudo-registers.
7078         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7079         New functions.
7080         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7081         Handle "vX" aliases.
7082         (v_alias_pseudo_register_collect): New function.
7083         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7084         (rs6000_gdbarch_init): Initialize "vX" aliases as
7085         pseudo-registers.  Restore registration of
7086         rs6000_pseudo_register_reggroup_p with
7087         set_tdesc_pseudo_register_reggroup_p.
7088
7089 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7090
7091         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7092         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7093         set_gdbarch_num_pseudo_regs.
7094
7095 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7096
7097         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7098         Remove arg prefixname, add do_set and do_show.
7099         Add member functions set_list and show_list.
7100         * cli/cli-style.c (class cli_style_option): Update accordingly.
7101         (style_set_list): Move to file scope.
7102         (style_show_list): Likewise.
7103         (set_style): Call help_list.
7104         (show_style): Call cmd_show_list.
7105         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7106         Update to use the new macro.
7107
7108 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7109
7110         * ada-lang.c (_initialize_ada_language): Expand the help text
7111         for the "catch exception" command.
7112
7113 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7114
7115         * symtab.c (matching_obj_sections): Initialize obj,
7116         declare it closer to its usage.
7117
7118 2019-01-10  Tom Tromey  <tom@tromey.com>
7119
7120         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7121         (basic_inf_threads_range): Remove.
7122         (inf_threads_range, inf_non_exited_threads_range)
7123         (safe_inf_threads_range): Use next_adapter.
7124
7125 2019-01-10  Keith Seitz  <keiths@redhat.com>
7126
7127         PR gdb/23712
7128         PR symtab/23010
7129         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7130         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7131
7132 2019-01-10  Keith Seitz  <keiths@redhat.com>
7133
7134         PR gdb/23712
7135         PR symtab/23010
7136         * dictionary.c (pending_to_vector): Remove.
7137         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7138         Remove _1 suffix, replacing functions of the same name.  Update
7139         all callers.
7140         (dict_create_hashed, dict_create_hashed_expandable)
7141         (dict_create_linear, dict_create_linear_expandable, dict_free)
7142         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7143         Make functions static.
7144
7145 2019-01-10  Keith Seitz  <keiths@redhat.com>
7146
7147         PR gdb/23712
7148         PR symtab/23010
7149         * dictionary.h (struct dictionary): Replace declaration with
7150         multidictionary.
7151         (dict_create_hashed, dict_create_hashed_expandable)
7152         (dict_create_linear, dict_create_linear_expandable)
7153         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7154         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7155         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7156         taking multidictionary argument.
7157         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7158         * block.h (struct block) <dict>: Change to multidictionary
7159         and rename `multidict'.
7160         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7161         symmisc.c: Update all dictionary references to multidictionary.
7162
7163 2019-01-10  Keith Seitz  <keiths@redhat.com>
7164
7165         PR gdb/23712
7166         PR symtab/23010
7167         * dictionary.c: Include unordered_map.
7168         (pending_to_vector): New function.
7169         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7170         Rewrite the non-"_1" functions to take vector instead
7171         of linked list.
7172         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7173         "new" _1 versions of the same name.
7174         (multidictionary): Define.
7175         (std::hash<enum language): New definition.
7176         (collate_pending_symbols_by_language, mdict_create_hashed)
7177         (mdict_create_hashed_expandable, mdict_create_linear)
7178         (mdict_create_linear_expandable, mdict_free)
7179         (find_language_dictionary, create_new_language_dictionary)
7180         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7181         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7182         (mdict_size, mdict_empty): New functions.
7183         * dictionary.h (mdict_iterator): Define.
7184
7185 2019-01-10  Pedro Alves  <palves@redhat.com>
7186
7187         * breakpoint.c (read_uploaded_action)
7188         (create_tracepoint_from_upload): Adjust to use
7189         gdb::unique_xmalloc_ptr.
7190         * ctf.c (ctf_write_uploaded_tp):
7191         (SET_ARRAY_FIELD): Use emplace_back.
7192         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7193         * tracefile-tfile.c (tfile_write_uploaded_tp):
7194         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7195         gdb::unique_xmalloc_ptr.
7196         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7197         at_string, cond_string, cmd_strings>: Replace char pointers
7198         with gdb::unique_xmalloc_ptr.
7199
7200 2019-01-10  Pedro Alves  <palves@redhat.com>
7201
7202         * solib-target.c (library_list_start_library): Don't xstrdup name.
7203
7204 2019-01-10  Pedro Alves  <palves@redhat.com>
7205
7206         * mdebugread.c (parse_partial_symbols): Use
7207         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7208
7209 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7210
7211         * linux-fork.c (scoped_switch_fork_info)
7212         <~scoped_switch_fork_info>: Fix incorrect variable name.
7213
7214 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7215
7216         * linux-fork.c (scoped_switch_fork_info)
7217         <scoped_switch_fork_info>: Make explicit.
7218         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7219
7220 2019-01-10  Tom Tromey  <tom@tromey.com>
7221
7222         * objfiles.h (objfile::reset_psymtabs): Update.
7223         * objfiles.c (objfile::objfile): Update.
7224         * psymtab.h (psymtab_storage::obstack): Update.
7225         (psymtab_storage::m_obstack): Use gdb::optional.
7226         (class psymtab_storage): Update comment.  Remove objfile
7227         parameter.
7228         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7229
7230 2019-01-10  Tom Tromey  <tom@tromey.com>
7231
7232         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7233         <free_psymtabs>: Now private.
7234         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7235         (allocate_psymtab): Use new method.
7236
7237 2019-01-10  Tom Tromey  <tom@tromey.com>
7238
7239         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7240         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7241         * mdebugread.c (parse_partial_symbols): Use
7242         allocate_dependencies.
7243         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7244         allocate_dependencies.
7245         (process_psymtab_comp_unit_reader)
7246         (build_type_psymtab_dependencies): Likewise.
7247         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7248
7249 2019-01-10  Tom Tromey  <tom@tromey.com>
7250
7251         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7252         PSYMBOL_SET_LANGUAGE.
7253         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7254
7255 2019-01-10  Tom Tromey  <tom@tromey.com>
7256
7257         * psymtab.h (psymtab_storage::obstack): New method.
7258         <m_obstack>: Rename from obstack; now private.
7259         * psymtab.c (psymtab_storage): Update.
7260         * dwarf2read.c (create_addrmap_from_index)
7261         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7262         Update.
7263
7264 2019-01-10  Tom Tromey  <tom@tromey.com>
7265
7266         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7267         * objfiles.h (objfile::reset_psymtabs): New method.
7268
7269 2019-01-10  Tom Tromey  <tom@tromey.com>
7270
7271         * symmisc.c (print_symbol_bcache_statistics): Update.
7272         (print_objfile_statistics): Update.
7273         * symfile.c (reread_symbols): Update.
7274         * psymtab.h (class psymtab_storage): New.
7275         * psymtab.c (psymtab_storage): New constructor.
7276         (~psymtab_storage): New destructor.
7277         (require_partial_symbols): Update.
7278         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7279         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7280         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7281         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7282         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7283         (start_psymtab_common, end_psymtab_common)
7284         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7285         (allocate_psymtab): Update.
7286         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7287         Update.
7288         (dump_psymtab_addrmap, maintenance_print_psymbols)
7289         (maintenance_check_psymtabs): Update.
7290         (class objfile_psymtabs): Move to objfiles.h.
7291         * psympriv.h (discard_psymtab): Now inline.
7292         (psymtab_discarder::psymtab_discarder): Update.
7293         (psymtab_discarder::~psymtab_discarder): Update.
7294         (ALL_OBJFILE_PSYMTABS): Rewrite.
7295         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7296         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7297         Remove fields.
7298         <partial_symtabs>: New field.
7299         (class objfile_psymtabs): Move from psymtab.h.  Update.
7300         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7301         psymbol_cache.
7302         (objfile::~objfile): Don't destroy psymbol_cache.
7303         * mdebugread.c (parse_partial_symbols): Update.
7304         * dwarf2read.c (create_addrmap_from_index)
7305         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7306         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7307         (add_partial_subprogram, dwarf2_ranges_read): Update.
7308         * dwarf-index-write.c (write_address_map)
7309         (write_one_signatured_type, recursively_write_psymbols)
7310         (class debug_names, class debug_names, write_psymtabs_to_index):
7311         Update.
7312
7313 2019-01-10  Tom Tromey  <tom@tromey.com>
7314
7315         * symtab.h (SYMBOL_SET_NAMES): Update.
7316         (symbol_set_names): Update.
7317         (MSYMBOL_SET_NAMES): Update.
7318         * symtab.c (symbol_set_names): Change argument to be an
7319         objfile_per_bfd_storage.
7320         * psymtab.c (add_psymbol_to_bcache): Update.
7321         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7322
7323 2019-01-10  Tom Tromey  <tom@tromey.com>
7324
7325         * symtab.c (create_demangled_names_hash): Change argument to be an
7326         objfile_per_bfd_storage.
7327         (symbol_set_names): Update.
7328
7329 2019-01-10  Tom Tromey  <tom@tromey.com>
7330
7331         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7332         init_psymbol_list.
7333         * psymtab.c (init_psymbol_list): Do nothing if already called.
7334         * psympriv.h (init_psymbol_list): Add comment.
7335         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7336         init_psymbol_list.
7337         * dbxread.c (dbx_symfile_read): Unconditionally call
7338         init_psymbol_list.
7339
7340 2019-01-10  Tom Tromey  <tom@tromey.com>
7341
7342         * xcoffread.c (scan_xcoff_symtab): Update.
7343         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7344         "where".
7345         * mdebugread.c (parse_partial_symbols)
7346         (handle_psymbol_enumerators): Update.
7347         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7348         * dbxread.c (read_dbx_symtab): Update.
7349         * psympriv.h (psymbol_placement): New enum.
7350         (add_psymbol_to_list): Update.
7351
7352 2019-01-10  Tom Tromey  <tom@tromey.com>
7353
7354         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7355         static_psymbols parameters.
7356         (scan_xcoff_symtab): Update.
7357         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7358         static_psymbols parameters.
7359         * psympriv.h (start_psymtab_common): Update.
7360         * mdebugread.c (parse_partial_symbols): Update.
7361         * dwarf2read.c (create_partial_symtab): Update.
7362         * dbxread.c (read_dbx_symtab): Update.
7363         (start_psymtab): Remove global_psymbols and static_psymbols
7364         parameters.
7365
7366 2019-01-10  Tom Tromey  <tom@tromey.com>
7367
7368         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7369         * psymtab.c (allocate_psymtab): Add comment.
7370         * psympriv.h (allocate_psymtab): Add comment.
7371         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7372         initializations.
7373         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7374
7375 2019-01-10  Tom Tromey  <tom@tromey.com>
7376
7377         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7378         Don't declare.
7379         * mipsread.c: Include mdebugread.h.
7380         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7381         Declare.
7382         * elfread.c: Include mdebugread.h.
7383
7384 2019-01-09  Tom Tromey  <tom@tromey.com>
7385
7386         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7387         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7388         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7389         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7390         (psym_lookup_symbol, psym_find_last_source_symtab)
7391         (psym_forget_cached_source_info, psym_print_stats)
7392         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7393         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7394         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7395         (psym_find_compunit_symtab_by_address)
7396         (maintenance_print_psymbols, maintenance_info_psymtabs)
7397         (maintenance_check_psymtabs): Use ranged for.
7398         * psymtab.h (class objfile_psymtabs): New.
7399         (require_partial_symbols): Return objfile_psymtabs.
7400         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7401
7402 2019-01-09  Tom Tromey  <tom@tromey.com>
7403
7404         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7405         (find_pc_mapped_section, list_overlays_command)
7406         (map_overlay_command, unmap_overlay_command)
7407         (simple_overlay_update): Use all_objfiles.
7408         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7409         * printcmd.c (info_symbol_command): Use all_objfiles.
7410         * objfiles.h (ALL_OBJSECTIONS): Remove.
7411         * maint.c (maintenance_translate_address): Use all_objfiles.
7412         * gcore.c (gcore_create_callback): Use all_objfiles.
7413         (objfile_find_memory_regions): Likewise.
7414
7415 2019-01-09  Tom Tromey  <tom@tromey.com>
7416
7417         * symtab.c (find_line_symtab, info_sources_command)
7418         (make_source_files_completion_list): Use objfile_compunits.
7419         * source.c (select_source_symtab): Use objfile_compunits.
7420         * objfiles.h (struct objfile): Update comment.
7421         (ALL_OBJFILES): Remove.
7422         (ALL_FILETABS): Remove.
7423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7424         objfile_compunits.
7425
7426 2019-01-09  Tom Tromey  <tom@tromey.com>
7427
7428         * symmisc.c (print_objfile_statistics, dump_objfile)
7429         (maintenance_print_symbols): Use compunit_filetabs.
7430         * source.c (forget_cached_source_info_for_objfile): Use
7431         compunit_filetabs.
7432         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7433         (ALL_FILETABS): Use compunit_filetabs.
7434         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7435         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7436
7437 2019-01-09  Tom Tromey  <tom@tromey.com>
7438
7439         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7440         (compunit_filetabs): New.
7441         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7442         compunit_filetabs.
7443         (info_sources_command, make_source_files_completion_list): Remove
7444         declaration.
7445         * symmisc.c (print_objfile_statistics, dump_objfile)
7446         (maintenance_print_symbols): Remove declaration.
7447         (maintenance_info_symtabs): Use compunit_filetabs.
7448         (maintenance_info_line_tables): Likewise.
7449         * source.c (select_source_symtab): Change local variable name.
7450         (forget_cached_source_info_for_objfile): Remove declaration.
7451         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7452         * objfiles.c (objfile_relocate1): Remove declaration.
7453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7454         declaration.
7455         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7456         * coffread.c (coff_symtab_read): Remove declaration.
7457         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7458         compunit_filetabs.
7459
7460 2019-01-09  Tom Tromey  <tom@tromey.com>
7461
7462         * symtab.c (lookup_objfile_from_block)
7463         (find_pc_sect_compunit_symtab, search_symbols)
7464         (default_collect_symbol_completion_matches_break_on): Use
7465         objfile_compunits.
7466         * objfiles.h (ALL_COMPUNITS): Remove.
7467         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7468         * cp-support.c (add_symbol_overload_list_qualified): Use
7469         objfile_compunits.
7470         * ada-lang.c (ada_collect_symbol_completion_matches)
7471         (ada_add_global_exceptions): Use objfile_compunits.
7472
7473 2019-01-09  Tom Tromey  <tom@tromey.com>
7474
7475         * source.c (select_source_symtab)
7476         (forget_cached_source_info_for_objfile): Remove declaration.
7477         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7478         declaration.
7479         * maint.c (count_symtabs_and_blocks): Remove declaration.
7480         * cp-support.c (add_symbol_overload_list_qualified): Remove
7481         declaration.
7482         * coffread.c (coff_symtab_read): Remove declaration.
7483         * symtab.c (lookup_symbol_in_objfile_symtabs)
7484         (basic_lookup_transparent_type_1): Use objfile_compunits.
7485         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7486         (info_sources_command, search_symbols)
7487         (default_collect_symbol_completion_matches_break_on)
7488         (make_source_files_completion_list): Remove declaration.
7489         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7490         (ada_collect_symbol_completion_matches)
7491         (ada_add_global_exceptions): Remove declaration.
7492         * linespec.c (iterate_over_all_matching_symtabs): Use
7493         objfile_compunits.
7494         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7495         (class objfile_compunits): New.
7496         (ALL_COMPUNITS): Use objfile_compunits.
7497         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7498         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7499         objfile_compunits.
7500         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7501
7502 2019-01-09  Tom Tromey  <tom@tromey.com>
7503
7504         * symtab.c (search_symbols)
7505         (default_collect_symbol_completion_matches_break_on): Use
7506         objfile_msymbols.
7507         * ada-lang.c (ada_lookup_simple_minsym)
7508         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7509         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7510         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7511         objfile_msymbols.
7512         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7513         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7514         * objc-lang.c (find_methods): Use objfile_msymbols.
7515         (info_selectors_command, info_classes_command): Likewise.
7516         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7517         * objfiles.h (class objfile_msymbols): New.
7518         (ALL_OBJFILE_MSYMBOLS): Remove.
7519         (ALL_MSYMBOLS): Remove.
7520
7521 2019-01-09  Tom Tromey  <tom@tromey.com>
7522
7523         * common/next-iterator.h (next_adapter): Add Iterator template
7524         parameter.
7525         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7526         (class all_objfiles_safe): New.
7527         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7528         * objfiles.c (put_objfile_before): Update comment.
7529         (add_separate_debug_objfile): Likewise.
7530         (free_all_objfiles): Use all_objfiles_safe.
7531         (objfile_purge_solibs): Likewise.
7532
7533 2019-01-09  Tom Tromey  <tom@tromey.com>
7534
7535         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7536         (expand_symtab_containing_pc, lookup_static_symbol)
7537         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7538         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7539         all_objfiles.
7540         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7541         * breakpoint.c (create_overlay_event_breakpoint)
7542         (create_longjmp_master_breakpoint)
7543         (create_std_terminate_master_breakpoint)
7544         (create_exception_master_breakpoint): Use all_objfiles.
7545         * linux-thread-db.c (try_thread_db_load_from_pdir)
7546         (has_libpthread): Use all_objfiles.
7547         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7548         * linespec.c (iterate_over_all_matching_symtabs)
7549         (search_minsyms_for_name): Use all_objfiles.
7550         * maint.c (maintenance_info_sections): Use all_objfiles.
7551         * main.c (captured_main_1): Use all_objfiles.
7552         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7553         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7554         * guile/scm-pretty-print.c
7555         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7556         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7557         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7558         (maintenance_print_msymbols): Use all_objfiles.
7559         * source.c (select_source_symtab): Use all_objfiles.
7560         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7561         * symfile.c (remove_symbol_file_command)
7562         (expand_symtabs_matching, map_symbol_filenames): Use
7563         all_objfiles.
7564         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7565         all_objfiles.
7566         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7567         * objc-lang.c (find_methods): Use all_objfiles.
7568         * objfiles.c (have_partial_symbols, have_full_symbols)
7569         (have_minimal_symbols, qsort_cmp)
7570         (default_iterate_over_objfiles_in_search_order): Use
7571         all_objfiles.
7572         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7573         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7574         (maintenance_check_psymtabs): Use all_objfiles.
7575         (ALL_PSYMTABS): Remove.
7576         * compile/compile-object-run.c (do_module_cleanup): Use
7577         all_objfiles.
7578         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7579         * cp-support.c (add_symbol_overload_list_qualified): Use
7580         all_objfiles.
7581         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7582         Use all_objfiles.
7583         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7584         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7585         all_objfiles.
7586         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7587         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7588         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7589         Uses all_objfiles.
7590         * solib.c (solib_read_symbols): Use all_objfiles
7591
7592 2019-01-09  Tom Tromey  <tom@tromey.com>
7593
7594         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7595         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7596         all_objfiles.
7597         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7598         * symmisc.c (print_symbol_bcache_statistics)
7599         (print_objfile_statistics, maintenance_print_objfiles)
7600         (maintenance_info_symtabs, maintenance_check_symtabs)
7601         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7602         all_objfiles.
7603         * source.c (forget_cached_source_info): Use all_objfiles.
7604         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7605         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7606         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7607         * objfiles.c (update_section_map): Use all_objfiles.
7608         (shared_objfile_contains_address_p): Likewise.
7609         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7610         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7611
7612 2019-01-09  Tom Tromey  <tom@tromey.com>
7613
7614         * common/next-iterator.h: New file.
7615         * objfiles.h (class all_objfiles): New.
7616         (struct objfile_iterator): New.
7617
7618 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7619
7620         * NEWS: Move the description of the changed "frame", "select-frame",
7621          and "info frame" commands to the Changed commands section.
7622
7623 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7624
7625         * gdbtypes.c (check_stub_method_group): Remove handling of old
7626         mangling schemes.
7627         * linespec.c (find_methods): Likewise.
7628         * stabsread.c (read_member_functions): Likewise.
7629         * valops.c (search_struct_method): Likewise.
7630         (value_struct_elt_for_reference): Likewise.
7631         * NEWS: Mention this change.
7632
7633 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7636         print_source_lines.
7637         * source.c (print_source_lines_base): Update line number check.
7638         (print_source_lines): New function.
7639         (source_lines_range::source_lines_range): New function.
7640         * source.h (class source_lines_range): New class.
7641         (print_source_lines): New declaration.
7642
7643 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7644
7645         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7646
7647 2019-01-08  Tom Tromey  <tom@tromey.com>
7648             Simon Marchi  <simon.marchi@ericsson.com>
7649
7650         PR gdb/24060
7651         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7652         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7653         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7654         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7655         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7656         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7657
7658 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7659
7660         * source.c (select_source_symtab): Move header comment to
7661         declaration in source.h.
7662         (forget_cached_source_info_for_objfile): Likewise.
7663         (forget_cached_source_info): Likewise.
7664         (identify_source_line): Likewise.
7665         * source.h (identify_source_line): Move declaration from symtab.h
7666         and add comment from source.c
7667         (print_source_lines): Likewise.
7668         (forget_cached_source_info_for_objfile): Likewise.
7669         (forget_cached_source_info): Likewise.
7670         (select_source_symtab): Likewise.
7671         (enum print_source_lines_flag): Move definition from symtab.h.
7672         * symtab.h (identify_source_line): Move declaration to source.h.
7673         (print_source_lines): Likewise.
7674         (forget_cached_source_info_for_objfile): Likewise.
7675         (forget_cached_source_info): Likewise.
7676         (select_source_symtab): Likewise.
7677         (enum print_source_lines_flag): Move definition to source.h.
7678         * tui/tui-hooks.c: Add 'source.h' include.
7679
7680 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7681
7682         * source.c (print_source_lines_base): Handle requests to print
7683         reverse line number sequences, and guard against empty lines
7684         string.
7685
7686 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7687
7688         * source.c (print_source_lines_base): Fix skip of '\r' if next
7689         character is '\n'.
7690
7691 2019-01-06  Tom Tromey  <tom@tromey.com>
7692
7693         * c-exp.y (struct c_parse_state) <macro_original_text,
7694         expansion_obstack>: New member.
7695         (macro_original_text, expansion_obstack): Remove globals.
7696         (scan_macro_expansion, scanning_macro_expansion)
7697         (finished_macro_expansion): Update.
7698         (scan_macro_cleanup): Remove.
7699         (yylex, c_parse): Update.
7700
7701 2019-01-06  Tom Tromey  <tom@tromey.com>
7702
7703         * c-exp.y (struct c_parse_state) <strings>: New member.
7704         (operator_stoken): Update.
7705
7706 2019-01-06  Tom Tromey  <tom@tromey.com>
7707
7708         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7709         (union type_stack_elt) <typelist_val>: Now a pointer to
7710         std::vector.
7711         (type_stack_cleanup): Don't declare.
7712         (push_typelist): Update.
7713         * parse.c (pop_typelist): Return a std::vector.
7714         (push_typelist): Take a std::vector.
7715         (follow_types): Update.  Do not free args.
7716         (type_stack_cleanup): Remove.
7717         * c-exp.y (struct c_parse_state): New.
7718         (cpstate): New global.
7719         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7720         (nonempty_typelist): Update.
7721         (func_mod): Create a new vector.
7722         (c_parse): Create a c_parse_state.
7723         (check_parameter_typelist): Do not delete params.
7724         (function_method): Update.  Do not delete type_list.
7725
7726 2019-01-06  Tom Tromey  <tom@tromey.com>
7727
7728         PR gdb/28155:
7729         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7730         check_typedef.
7731         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7732         (print_return_value): Likewise.
7733
7734 2019-01-05  Tom Tromey  <tom@tromey.com>
7735
7736         * contrib/cleanup_check.py: Remove.
7737         * contrib/gcc-with-excheck: Remove.
7738         * contrib/exsummary.py: Remove.
7739         * contrib/excheck.py: Remove.
7740
7741 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7742
7743         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7744         NULL. Initialize tpprev to NULL instead of assigning it
7745         to NULL on the next statement.
7746         * windows-nat.c (windows_delete_thread): Remove check for
7747         main_thread_id before printing thread exit notifications.
7748         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7749         Remove thread ID check against main_thread_id.
7750         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7751         windows_delete_thread.
7752         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7753
7754 2019-01-04  Tom Tromey  <tom@tromey.com>
7755
7756         * compile/compile.c (_initialize_compile): Use upper case for
7757         metasyntactic variables.
7758         * symmisc.c (_initialize_symmisc): Use upper case for
7759         metasyntactic variables.
7760         * psymtab.c (_initialize_psymtab): Use upper case for
7761         metasyntactic variables.
7762         * demangle.c (demangle_command): Use upper case for metasyntactic
7763         variables.
7764         (_initialize_demangler): Likewise.
7765         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7766         variables.
7767
7768 2019-01-03  Tom Tromey  <tom@tromey.com>
7769
7770         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7771
7772 2019-01-03  Tom Tromey  <tom@tromey.com>
7773
7774         * python/py-symtab.c (salpy_str): Update.
7775         (struct salpy_sal_object) <symtab>: Now a PyObject.
7776         (salpy_dealloc): Update.
7777         (del_objfile_sal): Use gdbpy_ref.
7778
7779 2019-01-03  Tom Tromey  <tom@tromey.com>
7780
7781         * python/py-type.c (convert_field): Use new_reference.  Return
7782         gdbpy_ref.
7783         (make_fielditem): Return gdbpy_ref.
7784         (typy_fields): Update.
7785         (typy_getitem): Update.
7786         (field_name): Return gdbpy_ref.  Use new_reference.
7787         (typy_iterator_iternext): Update.
7788
7789 2019-01-03  Tom Tromey  <tom@tromey.com>
7790
7791         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7792
7793 2019-01-03  Tom Tromey  <tom@tromey.com>
7794
7795         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7796         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7797         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7798         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7799         (pspy_set_type_printers): Likewise.
7800         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7801         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7802         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7803         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7804         (objfpy_set_type_printers): Likewise.
7805
7806 2019-01-03  Tom Tromey  <tom@tromey.com>
7807
7808         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7809         (gdbpy_print_stack): Use gdbpy_err_fetch.
7810         * python/python-internal.h (class gdbpy_err_fetch): New class.
7811         (class gdbpy_enter) <m_error_type, m_error_value,
7812         m_error_traceback>: Remove.
7813         <m_error>: New member.
7814         (gdbpy_exception_to_string): Don't declare.
7815         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7816         * python/py-value.c (convert_value_from_python): Use
7817         gdbpy_err_fetch.
7818         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7819         gdbpy_exception_to_string.
7820         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7821         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7822         gdbpy_err_fetch.
7823
7824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * linux-nat.c (delete_lwp_cleanup): Delete.
7827         (struct lwp_deleter): New struct.
7828         (lwp_info_up): New typedef.
7829         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7830         lwp_info_up.
7831
7832 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7833
7834         * linux-fork.c (class scoped_switch_fork_info): New class.
7835         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7836
7837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * valops.c (find_overload_match): Remove use of null_cleanup, and
7840         calls to do_cleanups.
7841
7842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * compile/compile-cplus-types.c
7845         (compile_cplus_instance::decl_name): Handle changes to
7846         cp_func_name.
7847         * cp-support.c (cp_func_name): Update header comment, update
7848         return type.
7849         * cp-support.h (cp_func_name): Update return type in declaration.
7850         * valops.c (find_overload_match): Move temp_func local to top
7851         level of function and change its type.  Use temp_func to hold and
7852         delete temporary string obtained from cp_func_name.
7853
7854 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7855
7856         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7857         gdb::char_vector, remove cleanup, and update uses of `msg`.
7858
7859 2019-01-03  Jim Wilson  <jimw@sifive.com>
7860
7861         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7862
7863 2019-01-02  Tom Tromey  <tom@tromey.com>
7864
7865         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7866         (tdesc_parse_xml): Remove cleanups.
7867         * target-descriptions.h (make_cleanup_free_target_description):
7868         Don't declare.
7869         (target_desc_deleter): New struct.
7870         (target_desc_up): New typedef.
7871         * target-descriptions.c (target_desc_deleter::operator()): Rename
7872         from free_target_description.
7873         (make_cleanup_free_target_description): Remove.
7874
7875 2019-01-02  Tom Tromey  <tom@tromey.com>
7876
7877         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7878         constructor, destructor.
7879         (linespec_parser): Remove typedef.
7880         (~linespec_parser): Rename from linespec_parser_delete.
7881         (linespec_lex_to_end, linespec_complete_label)
7882         (linespec_complete): Update.
7883         (decode_line_full): Remove cleanups.
7884         (decode_line_1): Update.
7885
7886 2019-01-02  Tom Tromey  <tom@tromey.com>
7887
7888         * python/python-internal.h (inferior_to_inferior_object): Change
7889         return type.
7890         * python/py-exitedevent.c (create_exited_event_object): Update.
7891         * python/py-inferior.c (inferior_to_inferior_object): Return
7892         gdbpy_ref.
7893         (python_new_inferior, python_inferior_deleted)
7894         (thread_to_thread_object, delete_thread_object)
7895         (build_inferior_list, gdbpy_selected_inferior): Update.
7896         * python/py-infthread.c (create_thread_object): Update.  Also fail
7897         if inferior_to_inferior_object fails.
7898
7899 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7900
7901         * inferior.h (class inferior) <displaced_step_state>: New field.
7902         * infrun.h (struct displaced_step_state): Move here from
7903         infrun.c.  Initialize fields, add constructor.
7904         <inf>: Remove field.
7905         <reset>: New method.
7906         * infrun.c (struct displaced_step_inferior_state): Move to
7907         infrun.h.
7908         (displaced_step_inferior_states): Remove.
7909         (get_displaced_stepping_state): Adust.
7910         (displaced_step_in_progress_any_inferior): Adjust.
7911         (displaced_step_in_progress_thread): Adjust.
7912         (displaced_step_in_progress): Adjust.
7913         (add_displaced_stepping_state): Remove.
7914         (get_displaced_step_closure_by_addr): Adjust.
7915         (remove_displaced_stepping_state): Remove.
7916         (infrun_inferior_exit): Call displaced_step_state.reset.
7917         (use_displaced_stepping): Don't check for NULL.
7918         (displaced_step_prepare_throw): Call
7919         get_displaced_stepping_state.
7920         (displaced_step_fixup): Don't check for NULL.
7921         (prepare_for_detach): Don't check for NULL.
7922
7923 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7924
7925         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7926          in case of call that did not complete.
7927
7928 2019-01-02  Andrey Utkin  <autkin@undo.io>
7929
7930         * symfile.c (find_separate_debug_file): Fix search of debug files for
7931         remote debuggee.
7932
7933 2019-01-02  Tom Tromey  <tom@tromey.com>
7934
7935         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7936         indentation.
7937         * python/py-frame.c (frapy_older): Remove cast.
7938         (frapy_newer): Likewise.
7939         * python/py-breakpoint.c (local_setattro): Remove cast.
7940         * python/py-arch.c (archpy_name): Remove local variable.
7941         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7942
7943 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7944
7945         * unittests/basic_string_view/element_access/char/empty.cc:
7946         Fix year range in copyright header.
7947
7948 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7949
7950         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7951         Delete.
7952         <operator==>: Update with for removed field.
7953         <hash>: Likewise.
7954         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7955         <isa_features>: ...this.
7956         <abi_features>: New field.
7957         (riscv_isa_flen): Update comment.
7958         (riscv_abi_xlen): New declaration.
7959         (riscv_abi_flen): New declaration.
7960         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7961         isa_features.
7962         (riscv_abi_xlen): New function.
7963         (riscv_isa_flen): Update to get answer from isa_features.
7964         (riscv_abi_flen): New function.
7965         (riscv_has_fp_abi): Update to get answer from abi_features.
7966         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7967         xlen and flen.
7968         (riscv_call_info) <xlen, flen>: Update comment.
7969         (riscv_call_arg_struct): Remove invalid assertions
7970         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7971         is removed.
7972         (riscv_gdbarch_init): Gather isa features and abi features
7973         separately, ensure both match on the gdbarch when reusing an old
7974         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7975         a target with 64-bit float hardware.
7976
7977 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7978
7979         * source.c (search_command_helper): Stop reverse search
7980         when line 1 has been searched.
7981
7982 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7983
7984         * record-full.c (record_full_base_target::close): Rewrite
7985         record_full_core_buf_list free logic.
7986
7987 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7988
7989         * break-catch-syscall.c (print_one_catch_syscall): xfree
7990         the last text.
7991
7992 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7993
7994         * top.c (print_gdb_version): Update Copyright year in version
7995         message.
7996
7997 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7998
7999         Update copyright year range in all GDB files.
8000
8001 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8002
8003         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8004
8005 For older changes see ChangeLog-2018.
8006 \f
8007 Local Variables:
8008 mode: change-log
8009 left-margin: 8
8010 fill-column: 74
8011 version-control: never
8012 coding: utf-8
8013 End:
8014