gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
   4         from make_visible.
   5         (tui_make_visible, tui_make_invisible): Rewrite.
   6         (tui_win_info::make_visible): Remove.
   7         (tui_source_window_base::make_visible): Update.
   8         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
   9         method.  Moved from...
  10         (struct tui_win_info) <make_visible>: ...here.
  11
  12 2019-06-25  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-winsource.c
  15         (tui_source_window_base::do_scroll_horizontal): Remove direction
  16         parameter.
  17         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
  18         direction parameter.
  19         * tui/tui-win.c (tui_win_info::forward_scroll)
  20         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
  21         (tui_win_info::right_scroll): Update.
  22         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
  23         direction parameter.
  24         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
  25         direction parameter.
  26         * tui/tui-data.h (enum tui_scroll_direction): Remove.
  27         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
  28         Remove direction parameter.
  29         (struct tui_source_window_base, struct tui_source_window)
  30         (struct tui_disasm_window, struct tui_data_window)
  31         (struct tui_cmd_window): Update.
  32
  33 2019-06-25  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.h (tui_set_exec_info_content)
  36         (tui_show_exec_info_content, tui_erase_exec_info_content)
  37         (tui_clear_exec_info_content, tui_update_exec_info): Change
  38         argument to tui_source_window_base.
  39         * tui/tui-winsource.c (tui_set_exec_info_content)
  40         (tui_show_exec_info_content, tui_erase_exec_info_content)
  41         (tui_clear_exec_info_content, tui_update_exec_info): Change
  42         argument to tui_source_window_base.
  43
  44 2019-06-25  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
  47         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
  48
  49 2019-06-25  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
  52         check.
  53
  54 2019-06-25  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
  57         type to void.
  58         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
  59         type to void.
  60         * tui/tui-source.c (tui_set_source_content): Update.
  61         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  62
  63 2019-06-25  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-win.c (window_name_completer, tui_set_focus)
  66         (tui_all_windows_info): Use name method.
  67         * tui/tui-data.h (struct tui_gen_win_info)
  68         (struct tui_source_window, struct tui_disasm_window)
  69         (struct tui_data_window, struct tui_cmd_window) <name>: New
  70         method.
  71         (tui_win_name): Don't declare.
  72         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
  73         (tui_win_name): Remove.
  74
  75 2019-06-25  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-winsource.h (tui_update_source_window)
  78         (tui_update_source_window_as_is): Change parameter type.
  79         * tui/tui-winsource.c (tui_update_source_window): Change win_info
  80         to be a tui_source_window_base.
  81         (tui_update_source_window_as_is): Likewise.
  82         * tui/tui-win.c (make_visible_with_new_height): Update.
  83
  84 2019-06-25  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-winsource.c (tui_erase_source_content)
  87         (tui_show_source_content, tui_show_exec_info_content)
  88         (tui_erase_exec_info_content): Use refresh_window method.
  89         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
  90         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
  91         from tui_refresh_win.
  92         (tui_data_window::refresh_window): New method.
  93         (tui_win_info::refresh, tui_source_window_base::refresh)
  94         (tui_refresh_all): Use refresh_window method.
  95         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
  96         method.
  97         * tui/tui-regs.c (tui_display_register): Call refresh_window
  98         method.
  99         * tui/tui-layout.c (show_source_disasm_command)
 100         (show_source_or_disasm_and_command): Call refresh_window method.
 101         * tui/tui-data.h (struct tui_gen_win_info)
 102         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 103         New method.
 104
 105 2019-06-25  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui.c (tui_rl_other_window, tui_enable)
 108         (tui_is_window_visible, tui_get_command_dimension): Update.
 109         * tui/tui-winsource.c (tui_update_source_window_as_is)
 110         (tui_clear_source_content, tui_erase_source_content)
 111         (tui_show_source_line, tui_source_window_base::refill)
 112         (tui_source_window_base::do_scroll_horizontal)
 113         (tui_source_window_base::set_is_exec_point_at)
 114         (tui_update_breakpoint_info, tui_set_exec_info_content)
 115         (tui_alloc_source_buffer, tui_line_is_displayed)
 116         (tui_addr_is_displayed): Update.
 117         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 118         (tui_check_and_display_highlight_if_needed)
 119         (tui_win_info::make_visible, tui_win_info::refresh)
 120         (tui_refresh_all): Update.
 121         * tui/tui-windata.c (tui_first_data_item_displayed)
 122         (tui_delete_data_content_windows, tui_erase_data_content)
 123         (tui_display_all_data, tui_data_window::refresh_all)
 124         (tui_check_data_values): Update.
 125         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 126         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 127         (tui_win_info::backward_scroll, tui_refresh_all_win)
 128         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 129         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 130         (tui_source_window_base::set_new_height)
 131         (tui_data_window::set_new_height)
 132         (make_invisible_and_set_new_height)
 133         (make_visible_with_new_height, new_height_ok)
 134         (parse_scrolling_args): Update.
 135         * tui/tui-stack.c (tui_show_frame_info): Update.
 136         * tui/tui-source.c (tui_set_source_content)
 137         (tui_set_source_content_nil, tui_source_is_displayed)
 138         (tui_source_window::do_scroll_vertical): Update.
 139         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 140         (tui_display_registers_from, tui_display_reg_element_at_line)
 141         (tui_check_register_values, tui_reg_command): Update.
 142         * tui/tui-layout.c (tui_default_win_height)
 143         (show_source_disasm_command, show_data, init_and_make_win)
 144         (show_source_or_disasm_and_command): Update.
 145         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 146         (tui_redisplay_readline, tui_mld_flush)
 147         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 148         (tui_getc): Update.
 149         * tui/tui-disasm.c (tui_set_disassem_content)
 150         (tui_disasm_window::do_scroll_vertical): Update.
 151         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 152         Now virtual.
 153         (struct tui_win_info): Derive from tui_gen_win_info.
 154         <~tui_win_info>: Mark as override.
 155         <generic>: Remove member.
 156         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 157         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 158         (~tui_data_window, ~tui_win_info)
 159         (tui_free_all_source_wins_content): Update.
 160         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 161
 162 2019-06-25  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-layout.c (init_and_make_win): Use new.
 165         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 166         destructor, initializers.
 167         (tui_alloc_generic_win_info): Don't declare.
 168         * tui/tui-data.c (_locator): Add argument to constructor.
 169         (source_win, disasm_win): New globals.
 170         (exec_info): Remove.
 171         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 172         Update.
 173         (tui_alloc_generic_win_info): Remove.
 174         (init_content_element): Use new.
 175         (tui_win_info::tui_win_info): Update.
 176         (free_content_elements) <case DATA_WIN>: Use delete.
 177
 178 2019-06-25  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 181         * tui/tui-windata.c (tui_first_data_item_displayed)
 182         (tui_delete_data_content_windows): Update.
 183         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 184         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 185         (tui_display_registers_from, tui_check_register_values): Update.
 186         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 187         pointer.
 188         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 189         window.
 190         (tui_free_data_content): Update.
 191         (free_content_elements) <case DATA_WIN>: Free the window.
 192
 193 2019-06-25  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 196         Update.
 197         * tui/tui-layout.c (make_command_window)
 198         (show_source_disasm_command, show_data, init_and_make_win)
 199         (show_source_or_disasm_and_command): Update.
 200         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 201         method.
 202         <can_highight, is_highlighted>: Now bool.
 203         (tui_set_win_highlight): Don't declare.
 204         * tui/tui-data.c (tui_set_win_highlight): Remove.
 205
 206 2019-06-25  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-wingeneral.c (make_visible): Remove check of window
 209         type.
 210
 211 2019-06-25  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-win.c (tui_win_info::max_height)
 214         (tui_cmd_window::max_height): New methods.
 215         (new_height_ok): Call max_height.
 216         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 217         <max_height>: New method.
 218
 219 2019-06-25  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-win.c (tui_source_window_base::set_new_height)
 222         (tui_data_window::set_new_height): New methods.
 223         (make_invisible_and_set_new_height): Call set_new_height method.
 224         * tui/tui-data.h (struct tui_win_info)
 225         (struct tui_source_window_base, struct tui_data_window)
 226         <set_new_height>: New method.
 227
 228 2019-06-25  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 231         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 232         tui_refresh_data_win.
 233         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 234         method.
 235         (tui_refresh_all_win): Call the refresh_all method.
 236         (tui_set_focus): Likewise.
 237         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 238         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 239         Likewise.
 240
 241 2019-06-25  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-winsource.h (tui_refill_source_window)
 244         (tui_set_is_exec_point_at): Don't declare.
 245         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 246         (tui_source_window_base::refill): Rename from
 247         tui_refill_source_window.
 248         (tui_source_window_base::do_scroll_horizontal): Update.
 249         (tui_source_window_base::set_is_exec_point_at): Rename from
 250         tui_set_is_exec_point_at.
 251         (tui_update_all_breakpoint_info): Update.
 252         * tui/tui-stack.c (tui_show_frame_info): Update.
 253         * tui/tui-layout.c (show_data): Add cast.
 254         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 255         * tui/tui-data.h (struct tui_source_window_base) <refill,
 256         set_is_exec_point_at>: New methods.
 257         (tui_source_windows, tui_add_to_source_windows): Update types.
 258         (tui_add_to_source_windows): Remove redundant declaration.
 259         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 260         (tui_source_windows): Change return type.
 261         (tui_clear_source_windows_detail): Update.
 262         (tui_add_to_source_windows): Change type of parameter.
 263         (tui_free_all_source_wins_content): Update.
 264
 265 2019-06-25  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-wingeneral.c (tui_win_info::refresh)
 268         (tui_source_window_base::refresh): New methods.
 269         (tui_refresh_all): Call the refresh method.
 270         * tui/tui-data.h (struct tui_win_info)
 271         (struct tui_source_window_base) <refresh>: New method.
 272
 273 2019-06-25  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui.h (tui_is_window_visible): Return bool.
 276         * tui/tui.c (tui_is_window_visible): Return bool.
 277         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 278         (tui_make_visible, tui_make_invisible)
 279         (tui_win_info::make_visible)
 280         (tui_source_window_base::make_visible, make_all_visible)
 281         (tui_make_all_visible, tui_make_all_invisible): Update.
 282         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 283         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 284         bool.
 285         (struct tui_win_info, struct tui_source_window_base)
 286         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 287         * tui/tui-data.c (tui_init_generic_part): Update.
 288
 289 2019-06-25  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 292         (tui_source_window_base::make_visible): New methods.
 293         (make_all_visible): Make method call.
 294         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 295         (struct tui_source_window_base, struct tui_cmd_window): Override
 296         make_visible.
 297         (tui_win_is_source_type): Don't declare.
 298         * tui/tui-data.c (tui_win_is_source_type): Remove.
 299
 300 2019-06-25  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 303         NULL check.
 304
 305 2019-06-25  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 308         Inline constructor.  Add initializers for members.
 309         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 310         constructors; now inline in class.
 311
 312 2019-06-25  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-regs.c (tui_show_registers): Update.
 315         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 316         bool.
 317         * tui/tui-data.c (tui_data_window::clear_detail)
 318         (tui_data_window): Update.
 319
 320 2019-06-25  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-windata.c (tui_display_all_data)
 323         (tui_display_data_from_line, tui_display_data_from)
 324         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 325         Update.
 326         * tui/tui-regs.c (tui_last_regs_line_no)
 327         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 328         (tui_show_registers, tui_show_register_group)
 329         (tui_display_registers_from, tui_display_reg_element_at_line)
 330         (tui_display_registers_from_line, tui_check_register_values)
 331         (tui_reg_next, tui_reg_prev): Update.
 332         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 333         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 334         tui_data_window.
 335         (struct tui_win_info) <detail>: Remove.  Add new fields from
 336         tui_data_info.
 337         (TUI_DATA_WIN): Add cast.
 338         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 339         (~tui_data_window): Simplify.
 340
 341 2019-06-25  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-layout.c (show_source_disasm_command)
 344         (show_source_or_disasm_and_command): Update.
 345         * tui/tui-io.c (update_cmdwin_start_line)
 346         (tui_redisplay_readline): Update.
 347         * tui/tui-data.h (struct tui_command_info): Remove.
 348         (struct tui_win_info) <detail>: Remove command_info member.
 349         (struct tui_data_window) <start_line>: New member, from
 350         tui_command_info.
 351         (TUI_CMD_WIN): Add casts.
 352
 353 2019-06-25  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-winsource.c (tui_update_source_window)
 356         (tui_refill_source_window)
 357         (tui_source_window_base::do_scroll_horizontal)
 358         (tui_update_breakpoint_info, tui_set_exec_info_content)
 359         (tui_show_exec_info_content, tui_erase_exec_info_content)
 360         (tui_clear_exec_info_content): Update.
 361         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 362         Update.
 363         * tui/tui-win.c (make_invisible_and_set_new_height)
 364         (make_visible_with_new_height): Update.
 365         * tui/tui-source.c (tui_set_source_content)
 366         (tui_show_symtab_source): Update.
 367         * tui/tui-layout.c (extract_display_start_addr)
 368         (show_source_disasm_command, show_data)
 369         (make_source_or_disasm_window)
 370         (show_source_or_disasm_and_command): Update.
 371         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 372         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 373         "gdbarch".
 374         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 375         to tui_source_window_base.
 376         (struct tui_win_info) <detail>: Remove source_info member.
 377         (struct tui_source_window_base) <has_locator>: Inline.
 378         Move contents from tui_source_info; rename has_locator member to
 379         m_has_locator.
 380         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 381         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 382         header file.
 383         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 384         Simplify.
 385         (tui_free_all_source_wins_content): Cast to
 386         tui_source_window_base.
 387
 388 2019-06-25  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-win.c (make_invisible_and_set_new_height)
 391         (make_visible_with_new_height): Call has_locator method.
 392         * tui/tui-layout.c (show_source_disasm_command, show_data)
 393         (show_source_or_disasm_and_command): Update for bool change.
 394         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 395         (tui_win_info) <has_locator>: New method.
 396         (struct tui_source_window_base) <has_locator>: New method.
 397         (tui_win_has_locator): Don't declare.
 398         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 399         from tui_win_has_locator.
 400         (tui_source_window_base): Use false, not FALSE.
 401
 402 2019-06-25  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 405         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 406         clear_detail method directly.
 407         (tui_clear_win_detail): Remove.
 408
 409 2019-06-25  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 412         "this", not TUI_DISASM_WIN.
 413
 414 2019-06-25  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 417         declare.
 418         * tui/tui-winsource.c
 419         (tui_source_window_base::do_scroll_horizontal): Rename from
 420         tui_horizontal_source_scroll.
 421         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 422         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 423         from tui_vertical_data_scroll.
 424         * tui/tui-win.h (tui_scroll): Don't declare.
 425         * tui/tui-win.c (tui_win_info::forward_scroll)
 426         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 427         (tui_win_info::right_scroll): Rename and update.
 428         (tui_scroll_forward_command, tui_scroll_backward_command)
 429         (tui_scroll_left_command, tui_scroll_right_command): Update.
 430         (tui_scroll): Remove.
 431         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 432         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 433         from tui_vertical_source_scroll.
 434         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 435         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 436         from tui_vertical_disassem_scroll.
 437         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 438         do_scroll_horizontal>: New methods.
 439         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 440         Likewise.
 441         (struct tui_source_window_base): Add do_scroll_horizontal.
 442         (struct tui_source_window, struct tui_disasm_window): Add
 443         do_scroll_vertical.
 444         (struct tui_data_window, struct tui_cmd_window): Add
 445         do_scroll_horizontal and do_scroll_vertical.
 446         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 447
 448 2019-06-25  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-data.h (struct tui_source_window_base): New struct.
 451         (struct tui_source_window): Derive from tui_source_window_base.
 452         (struct tui_disasm_window): New struct.
 453         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 454         from tui_source_window::clear_detail.
 455         (tui_source_window_base): Rename from tui_source_window.
 456         (~tui_source_window_base): Rename from ~tui_source_window.
 457         (tui_alloc_win_info): Create a tui_disasm_window.
 458
 459 2019-06-25  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-data.h (struct tui_source_window)
 462         (struct tui_data_window): Declare destructors.
 463         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 464         destructors.
 465         (tui_win_info): Simplify.
 466
 467 2019-06-25  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-winsource.c (tui_display_main)
 470         (tui_update_source_windows_with_addr)
 471         (tui_update_all_breakpoint_info): Update.
 472         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 473         (new_height_ok, parse_scrolling_args): Update.
 474         * tui/tui-stack.c (tui_show_frame_info): Update.
 475         * tui/tui-data.h (struct tui_list): Remove.
 476         (tui_source_windows): Return a reference to a std::vector.
 477         * tui/tui-data.c (source_windows): Now a std::vector.
 478         (tui_source_windows): Change return type.
 479         (tui_clear_source_windows): Rewrite.
 480         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 481         (tui_free_all_source_wins_content): Rewrite.
 482
 483 2019-06-25  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 486         (struct tui_data_window, struct tui_cmd_window): Declare
 487         clear_detail method.
 488         * tui/tui-data.c (tui_source_window::clear_detail)
 489         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 490         methods.
 491         (tui_clear_win_detail): Simplify.
 492
 493 2019-06-25  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-layout.c (make_source_window, make_disasm_window)
 496         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 497         Return the new window.
 498         (show_source_disasm_command, show_data)
 499         (show_source_or_disasm_and_command): Update.
 500
 501 2019-06-25  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 504         parameter.  Return the new window.
 505         (show_source_disasm_command): Update and remove NULL check.
 506         (show_source_or_disasm_and_command): Update.
 507
 508 2019-06-25  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 511
 512 2019-06-25  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-data.h (struct tui_win_info): Make constructor
 515         protected.  Make destructor virtual.  Add initializers.
 516         (tui_source_window, tui_data_window, tui_cmd_window): New
 517         classes.
 518         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 519         constructor.  Add "type" parameter.
 520         (tui_source_window, tui_data_window, tui_cmd_window): New
 521         constructors.
 522         (tui_alloc_win_info): Instantiate the appropriate subclass.
 523
 524 2019-06-25  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-win.c (tui_resize_all): Use delete.
 527         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 528         destructor.
 529         (tui_free_window): Don't declare.
 530         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 531         Update.
 532
 533 2019-06-25  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-data.h (struct tui_win_info): Add constructor.
 536         * tui/tui-data.c (tui_alloc_win_info): Use new.
 537         (tui_free_window): Use delete.
 538
 539 2019-06-22  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 542         declare.
 543         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 544
 545 2019-06-22  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 548         declare.
 549         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 550
 551 2019-06-22  Tom de Vries  <tdevries@suse.de>
 552
 553         * dwarf2read.c (create_addrmap_from_aranges)
 554         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 555         instead of '%zu'.
 556
 557 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 558
 559         * dwarf2read.h (dwarf2_section_info_def): Remove.
 560         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 561         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 562         std::vector<dwarf2_section_info>.
 563         (struct dwo_file) <~dwo_file>: Remove.
 564         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 565         types field.
 566         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 567         (dwarf2_read_debug_names): Likewise.
 568         (create_debug_types_hash_table): Change parameter type to
 569         array_view, adjust code accordingly.
 570         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 571         (partial_die_info::fixup): Likewise.
 572         (determine_prefix): Likewise.
 573         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 574
 575 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 576
 577         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 578         gdb_bfd_ref_ptr.
 579         <~dwo_file>: Remove call to gdb_bfd_unref.
 580         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 581         gdb_bfd_ref_ptr::get.
 582
 583 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 584
 585         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 586         type to htab_up.
 587         * dwarf2read.c (struct dwo_file): Initialize fields.
 588         <~dwo_file>: New.
 589         (free_dwo_file): Remove, move content to ~dwo_file.
 590         (struct dwo_file_deleter): Remove.
 591         (dwo_file_up>: Remove custom deleter.
 592         (free_dwo_files): Remove.
 593         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 594         dwo_files.
 595         (process_skeletonless_type_units): Call unique_ptr::get.
 596         (allocate_dwo_file_hash_table): Add deleter to created hash
 597         table.  Change return type to htab_up.
 598         (lookup_dwo_file_slot): Don't memset dwo_file, call
 599         unique_ptr::get.
 600         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 601         (create_dwo_unit_in_dwp_v2): Likewise.
 602         (open_and_init_dwo_file): Likewise.
 603         (free_dwo_file_from_slot): Remove.
 604
 605 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 606
 607         * dwarf2read.h (struct dwarf2_section_info) <readin,
 608         is_virtual>: Change type to bool.
 609         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 610         true instead of 1.
 611
 612 2019-06-19  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-data.h (tui_init_content_element): Don't declare.
 615
 616 2019-06-19  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-data.h (tui_init_win_info): Don't declare.
 619
 620 2019-06-19  Tom de Vries  <tdevries@suse.de>
 621
 622         * dwarf2read.h (abstract_to_concrete): Change type to
 623         std::unordered_map<sect_offset, std::vector<sect_offset>,
 624         gdb::hash_enum<sect_offset>>.
 625
 626 2019-06-19  Tom Tromey  <tromey@adacore.com>
 627
 628         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 629         EVAL_AVOID_SIDE_EFFECTS specially.
 630
 631 2019-06-19  Tom Tromey  <tromey@adacore.com>
 632
 633         * source-cache.c (highlighter): New global.
 634         (source_cache::get_source_lines): Create a highlighter on demand.
 635
 636 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 637
 638         * defs.h (deprecated_interactive_hook): Delete declaration.
 639         * interps.c (clear_interpreter_hooks): Remove use of
 640         deprecated_interactive_hook.
 641         * top.c (deprecated_interactive_hook): Delete definition.
 642         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 643
 644 2019-06-18  Tom de Vries  <tdevries@suse.de>
 645
 646         PR gdb/24515
 647         * dwarf2read.h (abstract_to_concrete): Change type from
 648         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 649         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 650         * dwarf2read.c (read_variable): Update.
 651         (dwarf2_fetch_die_loc_sect_off): Update.
 652
 653 2019-06-17  Tom de Vries  <tdevries@suse.de>
 654
 655         PR gdb/24617
 656         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 657         accessing parent[parent_len - 1].
 658
 659 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 660
 661         PR gdb/24364
 662         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 663         call dtrace_process_dof with NULL dof.
 664
 665 2019-06-16  Tom de Vries  <tdevries@suse.de>
 666
 667         PR gdb/24445
 668         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 669
 670 2019-06-16  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 673         (make_all_visible): Use address of member.
 674
 675 2019-06-16  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 678         (tui_free_window, free_content, free_content_elements): Remove
 679         unnecessary cast.
 680         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 681         cast.
 682         * tui/tui-regs.c (tui_show_register_group)
 683         (tui_display_registers_from, tui_display_reg_element_at_line):
 684         Remove unnecessary cast.
 685
 686 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 687
 688         * linux-nat.c (normal_mask): Delete.
 689         (_initialize_linux_nat): Don't initialise normal_mask.
 690
 691 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 692
 693         PR gdb/24445
 694         * dwarf-index-write.h (write_psymtabs_to_index): Add
 695         dwz_basename parameter.
 696         * dwarf-index-write.c (write_gdbindex): Move file writing to
 697         write_gdbindex_1.  Change return type void.
 698         (assert_file_size): Move up, remove filename parameter.
 699         (write_gdbindex_1): New function.
 700         (write_debug_names): Change return type to void, call
 701         assert_file_size.
 702         (struct index_wip_file): New struct.
 703         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 704         file logic to index_wip_file.  Write index for dwz file if
 705         needed.
 706         (save_gdb_index_command): Pass basename of dwz file, if present.
 707         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 708         build-id of dwz file, if present.
 709         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 710         (dwarf2_get_dwz_file): Likewise.
 711         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 712         (dwarf2_get_dwz_file): Likewise.
 713
 714 2019-06-16  Tom Tromey  <tom@tromey.com>
 715
 716         * coffread.c (process_coff_symbol): Use xstrdup.
 717         * value.c (create_internalvar): Use xstrdup.
 718
 719 2019-06-16  Tom Tromey  <tom@tromey.com>
 720
 721         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 722         * breakpoint.c (stopin_command, stopat_command)
 723         (until_break_command, decode_location_default): Remove unnecessary
 724         cast.
 725         * utils.c (subset_compare): Remove unnecessary cast.
 726         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 727         cast.
 728         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 729         cast.
 730         * infcmd.c (path_command): Remove unnecessary cast.
 731         * coffread.c (decode_type): Remove unnecessary cast.
 732         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 733         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 734         * tui/tui-stack.c (tui_show_locator_content)
 735         (tui_show_frame_info): Remove unnecessary cast.
 736         * tui/tui-win.c (tui_scroll_forward_command)
 737         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 738         (parse_scrolling_args): Remove unnecessary cast.
 739         * tui/tui-data.c (init_win_info, tui_del_window)
 740         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 741         (free_content_elements): Remove unnecessary cast.
 742         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 743         unnecessary cast.
 744         * tui/tui-source.c (tui_set_source_content)
 745         (tui_vertical_source_scroll): Remove unnecessary cast.
 746         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 747         cast.
 748         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 749         * tui/tui-regs.c (tui_display_registers_from)
 750         (tui_display_register): Remove unnecessary cast.
 751         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 752         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 753         (make_visible): Remove unnecessary cast.
 754         * tui/tui-winsource.c (tui_erase_source_content)
 755         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 756         unnecessary cast.
 757         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 758         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 759         * stabsread.c (read_type, read_array_type, read_range_type):
 760         Remove unnecessary cast.
 761         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 762         (parse_symbol, parse_type, upgrade_type, parse_external)
 763         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 764         unnecessary cast.
 765         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 766
 767 2019-06-16  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-data.c (tui_alloc_generic_win_info)
 770         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 771         checks.
 772
 773 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 774             Andrew Burgess  <andrew.burgess@embecosm.com>
 775
 776         * f-typeprint.c (f_print_type): Don't return early for not
 777         associated or not allocated types.
 778         (f_type_print_varspec_suffix): Add print_rank parameter and print
 779         ranks of array types in case they dangling.
 780         (f_type_print_base): Add print_rank parameter.
 781
 782 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 783
 784         * NEWS: Mention new MI commands.
 785         * break-catch-throw.c (enum exception_event_kind): Move to
 786         breakpoint.h.
 787         (print_mention_exception_catchpoint): Output text as a single
 788         message.
 789         (catch_exception_command_1): Rename to...
 790         (catch_exception_event): ...this, make non-static, update header
 791         command, and change some parameter types.
 792         (catch_catch_command): Update for changes to
 793         catch_exception_command_1.
 794         (catch_throw_command): Likewise.
 795         (catch_rethrow_command): Likewise.
 796         * breakpoint.c (enum exception_event_kind): Delete.
 797         * breakpoint.h (enum exception_event_kind): Moved here from
 798         break-catch-throw.c.
 799         (catch_exception_event): Declare.
 800         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 801         (mi_cmd_catch_throw): New function.
 802         (mi_cmd_catch_rethrow): New function.
 803         (mi_cmd_catch_catch): New function.
 804         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 805         'catch-catch' entries.
 806         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 807         (mi_cmd_catch_rethrow): Declare.
 808         (mi_cmd_catch_catch): Declare.
 809
 810 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * annotate.c (annotate_source_line): Change return type to void,
 813         update implementation to match.
 814         * annotate.h (annotate_source_line): Change return type to void,
 815         update header comment.
 816         * stack.c (print_frame_info): Don't change what frame information
 817         is printed based on whether annotations are on or not.
 818
 819 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 822         (annotate_source): Make static.
 823         (annotate_source_line): Moved from source.c and renamed from
 824         identify_source_line.  Update the return type.
 825         * annotate.h (annotate_source): Delete declaration.
 826         (annotate_source_line): Declaration moved from source.h, and
 827         renamed from identify_source_line.  Return type updated.
 828         * source.c (identify_source_line): Moved to annotate.c and renamed
 829         to annotate_source_line.
 830         (info_line_command): Remove check of annotation_level.
 831         * source.h (identify_source_line): Move declaration to annotate.h
 832         and rename to annotate_source_line.
 833         * stack.c: Add 'annotate.h' include.
 834         (print_frame_info): Remove check of annotation_level before
 835         calling annotate_source_line.
 836
 837 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * source-cache.c (source_cache::get_plain_source_lines): Use
 840         open_source_file_with_line_charpos instead of just
 841         open_source_file, remove call to find_source_lines.
 842         (source_cache::get_source_lines): Likewise.
 843         * source.c (find_source_lines): Make static.
 844         (get_filename_and_charpos): Renamed into...
 845         (open_source_file_with_line_charpos): ..this along with changes to
 846         return a scoped_fd, and some other minor clean ups.
 847         (identify_source_line): Use open_source_file_with_line_charpos.
 848         (search_command_helper): Use open_source_file_with_line_charpos
 849         instead of just open_source_file, remove call to
 850         find_source_lines.
 851         * source.h (open_source_file_with_line_charpos): Declare new
 852         function.
 853         (find_source_lines): Delete declaration.
 854
 855 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * source.c (get_filename_and_charpos): Remove fullname
 858         parameter.
 859         (identify_source_line): Update call to get_filename_and_charpos.
 860
 861 2019-06-14  Tom Tromey  <tromey@adacore.com>
 862
 863         PR gdb/24502:
 864         * ui-style.h (skip_ansi_escape): Update comment.
 865         * ui-file.h (class no_terminal_escape_file): New class.
 866         * ui-file.c (no_terminal_escape_file::write)
 867         (no_terminal_escape_file::puts): New methods.
 868         * cli/cli-logging.c (handle_redirections): Use
 869         no_terminal_escape_file.
 870
 871 2019-06-14  Tom Tromey  <tromey@adacore.com>
 872
 873         * NEWS: Move convenience variable news above Python news.
 874
 875 2019-06-14  Tom Tromey  <tom@tromey.com>
 876
 877         * gnulib: Move directory to top-level.
 878         * configure.ac: Don't configure gnulib.
 879         * configure: Rebuild.
 880         * common/common-defs.h: Use new path to gnulib.
 881         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 882         (GNULIB_H): Remove.
 883         (INCGNU): Look in new gnulib location.
 884         (HFILES_NO_SRCDIR): Remove gnulib files.
 885         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 886         (generated_files): Remove GNULIB_H.
 887         ($(LIBGNU), all-lib): Remove targets.
 888         (distclean): Don't mention GNULIB_BUILDDIR.
 889         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 890
 891 2019-06-14  Tom Tromey  <tromey@adacore.com>
 892
 893         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 894         Warn if symbol file does not provide any symbols.
 895
 896 2019-06-14  Tom Tromey  <tromey@adacore.com>
 897
 898         * source.c (find_and_open_source): Respect basenames_may_differ.
 899
 900 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * annotate.c (annotate_breakpoints_invalid): Make use of
 903         scoped_restore_terminal_state.
 904         (annotate_frames_invalid): Likewise.
 905
 906 2019-06-14  Tom Tromey  <tromey@adacore.com>
 907
 908         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 909         allow assignment to an internalvar.
 910
 911 2019-06-14  Tom Tromey  <tromey@adacore.com>
 912
 913         * ada-lex.l: Allow "_" in attribute names.
 914
 915 2019-06-14  Tom Tromey  <tromey@adacore.com>
 916
 917         PR gdb/24653:
 918         * regcache.c (registers_changed): Don't call alloca.
 919         * top.c (execute_command): Don't call alloca.
 920
 921 2019-06-13  Pedro Alves  <palves@redhat.com>
 922
 923         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 924         'expression'.  When parsing an expression, error out if there's
 925         junk after "unlimited".
 926         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 927         (do_set_command): Adjust calls to is_unlimited_literal.
 928
 929 2019-06-13  Pedro Alves  <palves@redhat.com>
 930
 931         * compile/compile.c (make_compile_options_def_group): Add braces
 932         around array_view initializer.
 933         * thread.c (make_thread_apply_all_options_def_group)
 934         (make_thread_apply_all_options_def_group): Likewise.
 935
 936 2019-06-13  Pedro Alves  <palves@redhat.com>
 937
 938         * NEWS (New commands): Mention "maint test-options
 939         require-delimiter", "maint test-options unknown-is-error", "maint
 940         test-options unknown-is-operand" and "maint show
 941         test-options-completion-result".
 942         (New command options, command completion): New section.
 943         (Completion improvements): New section.
 944         Mention that you can abbreviate "unlimited".
 945
 946 2019-06-13  Pedro Alves  <palves@redhat.com>
 947
 948         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 949         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 950         * unittests/cli-utils-selftests.c (test_parse_flags)
 951         (test_parse_flags_qcs): Delete.
 952         (test_cli_utils): Don't call deleted functions.
 953
 954 2019-06-13  Pedro Alves  <palves@redhat.com>
 955
 956         * thread.c: Include "cli/cli-option.h".
 957         (tp_array_compar_ascending): Global.
 958         (tp_array_compar): Delete function.
 959         (tp_array_compar_ascending, tp_array_compar_descending): New
 960         functions.
 961         (ascending_option_def, qcs_flag_option_def)
 962         (thr_qcs_flags_option_defs)
 963         (make_thread_apply_all_options_def_group)
 964         (make_thread_apply_options_def_group): New.
 965         (thread_apply_all_command): Use gdb::option::process_options.
 966         (thread_apply_command_completer)
 967         (thread_apply_all_command_completer): New.
 968         (thread_apply_command): Use gdb::option::process_options.
 969         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 970         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 971         to generate help text of "thread apply".  Adjust "taas"'s help.
 972         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 973         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 974
 975 2019-06-13  Pedro Alves  <palves@redhat.com>
 976
 977         * thread.c (thread_apply_command): Check for invalid TID with
 978         isdigit instead of !isalpha.
 979
 980 2019-06-13  Pedro Alves  <palves@redhat.com>
 981
 982         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 983         (validate_flags_qcs): New.
 984         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 985         (validate_flags_qcs): Declare.
 986         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 987         (make_frame_apply_options_def_group): New.
 988         (frame_apply_command_count): Process options with
 989         gdb::option::process_options.
 990         (frame_apply_completer): New.
 991         (frame_apply_level_completer, frame_apply_all_completer)
 992         (frame_apply_completer): New.
 993         (_initialize_stack): Update help of "frame apply", "frame apply
 994         level", "frame apply all" and "faas" to mention supported options
 995         and install command completers.
 996         * stack.h (frame_apply_all_completer): Declare.
 997         * thread.c: Include "stack.h".
 998         (tfaas_command): Add "--".
 999         (_initialize_thread): Update help "tfaas" to mention supported
1000         options and install command completer.
1001
1002 2019-06-13  Pedro Alves  <palves@redhat.com>
1003
1004         * completer.c (complete_nested_command_line): New.
1005         (gdb_completion_word_break_characters_throw): Add assertion.
1006         * completer.h (complete_nested_command_line): Declare.
1007
1008 2019-06-13  Pedro Alves  <palves@redhat.com>
1009
1010         * stack.c (parse_backtrace_qualifiers): New.
1011         (backtrace_command): Use it.
1012         (backtrace_command_completer): Complete on qualifiers.
1013
1014 2019-06-13  Pedro Alves  <palves@redhat.com>
1015
1016         * frame.c: Include "cli/cli-option.h.
1017         (user_set_backtrace_options): New.
1018         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1019         Delete.
1020         (get_prev_frame): Adjust.
1021         (boolean_option_def, uinteger_option_def)
1022         (set_backtrace_option_defs): New.
1023         (_initialize_frame): Adjust and use
1024         gdb::option::add_setshow_cmds_for_options to install "set
1025         backtrace past-main" and "set backtrace past-entry".
1026         * frame.h: Include "cli/cli-option.h".
1027         (struct frame_print_options): Forward declare.
1028         (print_frame_arguments_all, print_frame_arguments_scalars)
1029         (print_frame_arguments_none): Declare.
1030         (print_entry_values): Delete declaration.
1031         (struct frame_print_options, user_frame_print_options): New.
1032         (struct set_backtrace_options): New.
1033         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1034         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1035         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1036         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1037         (list_args_or_locals): Add frame_print_options parameter.
1038         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1039         * python/py-framefilter.c (enumerate_args): Pass down
1040         USER_FRAME_PRINT_OPTIONS.
1041         * stack.c: Include "cli/cli-option.h".
1042         (print_frame_arguments_all, print_frame_arguments_scalars)
1043         (print_frame_arguments_none): Declare.
1044         (print_raw_frame_arguments, print_entry_values): Delete.
1045         (user_frame_print_options): New.
1046         (boolean_option_def, enum_option_def, frame_print_option_defs):
1047         New.
1048         (struct backtrace_cmd_options): New.
1049         (bt_flag_option_def): New.
1050         (backtrace_command_option_defs): New.
1051         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1052         (print_frame_arg, read_frame_arg, print_frame_args)
1053         (print_frame_info, print_frame): Add frame_print_options parameter
1054         and use it.
1055         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1056         (backtrace_command_1): Add frame_print_options and
1057         backtrace_cmd_options parameters and use them.
1058         (make_backtrace_options_def_group): New.
1059         (backtrace_command): Process command options with
1060         gdb::option::process_options.
1061         (backtrace_command_completer): New.
1062         (_initialize_stack): Extend "backtrace"'s help to mention
1063         supported options.  Install completer for "backtrace".
1064         Install some settings commands with add_setshow_cmds_for_options.
1065
1066 2019-06-13  Pedro Alves  <palves@redhat.com>
1067
1068         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1069         and that "set/show print raw frame-arguments" are now deprecated.
1070
1071         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1072         command.
1073         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1074         * stack.c (_initialize_stack): Install "set/show print
1075         raw-frame-arguments", and deprecate "set/show print raw
1076         frame-arguments".
1077         * valprint.c (_initialize_valprint): Deprecate "set/show print
1078         raw".
1079
1080 2019-06-13  Pedro Alves  <palves@redhat.com>
1081
1082         * compile/compile.c (struct compile_options): New.
1083         (compile_flag_option_def, compile_command_option_defs)
1084         (make_compile_options_def_group): New.
1085         (compile_file_command): Handle options with
1086         gdb::option::process_options.
1087         (compile_file_command_completer): New function.
1088         (compile_code_command): Handle options with
1089         gdb::option::process_options.
1090         (compile_code_command_completer): New function.
1091         (_initialize_compiler): Install completers for "compile code" and
1092         "compile file".  Mention available options in "compile code" and
1093         "compile code"'s help.
1094         * completer.c (advance_to_completion_word): New, factored out from
1095         ...
1096         (advance_to_expression_complete_word_point): ... this.
1097         (advance_to_filename_complete_word_point): New.
1098         * completer.h (advance_to_filename_complete_word_point): New
1099         declaration.
1100
1101 2019-06-13  Pedro Alves  <palves@redhat.com>
1102
1103         * compile/compile.c: Include "cli/cli-option.h".
1104         (compile_print_value): Scope data pointer is now a
1105         value_print_options pointer; adjust.
1106         (compile_print_command): Process options.  Scope data pointer is
1107         now a value_print_options pointer; adjust.
1108         (_initialize_compile): Update "compile print"'s help to include
1109         supported options.  Install a completer for "compile print".
1110         * cp-valprint.c (show_vtblprint, show_objectprint)
1111         (show_static_field_print): Delete.
1112         (_initialize_cp_valprint): Don't install "set print
1113         static-members", "set print vtbl", "set print object" here.
1114         * printcmd.c: Include "cli/cli-option.h" and
1115         "common/gdb_optional.h".
1116         (print_command_parse_format): Rework to fill in a
1117         value_print_options instead of a format_data.
1118         (print_value): Change parameter type from format_data pointer to
1119         value_print_options reference.  Adjust.
1120         (print_command_1): Process options.  Adjust to pass down a
1121         value_print_options.
1122         (print_command_completer): New.
1123         (_initialize_printcmd): Install print_command_completer as
1124         handle_brkchars completer for the "print" command.  Update
1125         "print"'s help to include supported options.
1126         * valprint.c: Include "cli/cli-option.h".
1127         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1128         here from cp-valprint.c.
1129         (boolean_option_def, uinteger_option_def)
1130         (value_print_option_defs, make_value_print_options_def_group):
1131         New.  Use gdb::option::add_setshow_cmds_for_options to install
1132         "set print elements", "set print null-stop", "set print repeats",
1133         "set print pretty", "set print union", "set print array", "set
1134         print address", "set print symbol", "set print array-indexes".
1135         * valprint.h: Include <string> and "cli/cli-option.h".
1136         (make_value_print_options_def_group): Declare.
1137         (print_value): Change parameter type from format_data pointer to
1138         value_print_options reference.
1139         (print_command_completer): Declare.
1140
1141 2019-06-13  Pedro Alves  <palves@redhat.com>
1142
1143         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1144         (COMMON_SFILES): Add maint-test-settings.c.
1145         * cli/cli-decode.c (boolean_enums): New global, factored out from
1146         ...
1147         (add_setshow_boolean_cmd): ... here.
1148         * cli/cli-decode.h (boolean_enums): Declare.
1149         * cli/cli-option.c: New file.
1150         * cli/cli-option.h: New file.
1151         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1152         factored out from ...
1153         (parse_cli_boolean_value(const char *)): ... this.
1154         (is_unlimited_literal): Change parameter type to pointer to
1155         pointer.  Adjust and advance ARG pointer.
1156         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1157         (parse_cli_var_enum): New, factored out from ...
1158         (do_set_command): ... this.  Adjust.
1159         * cli/cli-setshow.h (parse_cli_boolean_value)
1160         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1161         (parse_cli_var_enum): Declare.
1162         * cli/cli-utils.c: Include "cli/cli-option.h".
1163         (get_ulongest): New.
1164         * cli/cli-utils.h (get_ulongest): Declare.
1165         (check_for_argument): New overloads.
1166         * maint-test-options.c: New file.
1167
1168 2019-06-13  Pedro Alves  <palves@redhat.com>
1169
1170         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1171         parse a range if "-" is at the end of the string.
1172
1173 2019-06-13  Pedro Alves  <palves@redhat.com>
1174
1175         * cli/cli-setshow.c (parse_auto_binary_operation)
1176         (parse_cli_boolean_value): Don't allow "o".
1177
1178 2019-06-13  Pedro Alves  <palves@redhat.com>
1179
1180         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1181         * NEWS: Mention maint test-settings KIND.
1182         * maint-test-settings.c: New file.
1183
1184 2019-06-13  Pedro Alves  <palves@redhat.com>
1185
1186         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1187         completer.
1188         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1189         "set" completers.
1190
1191 2019-06-13  Pedro Alves  <palves@redhat.com>
1192
1193         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1194         after item.
1195
1196 2019-06-13  Pedro Alves  <palves@redhat.com>
1197
1198         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1199
1200 2019-06-13  Pedro Alves <palves@redhat.com>
1201
1202         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1203         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1204         call.
1205         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1206         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1207         calls.
1208         (check_for_argument): Skip spaces after argument.
1209
1210 2019-06-13  Pedro Alves  <palves@redhat.com>
1211
1212         * thread.c (thread_apply_command): Adjust TID parsing.
1213         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1214         detected before end of string.
1215         (tid_is_in_list): Error out if LIST is invalid.
1216
1217 2019-06-13  Pedro Alves  <palves@redhat.com>
1218
1219         * completer.c (complete_line_internal_1): Rewind completion word
1220         point.
1221         (completion_tracker::advance_custom_word_point_by): Change
1222         parameter type to int.
1223         * completer.h (completion_tracker::advance_custom_word_point_by):
1224         Likewise.
1225
1226 2019-06-13  Pedro Alves  <palves@redhat.com>
1227
1228         * completer.c (advance_to_completion_word): Handle delimiters.
1229
1230 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1231
1232         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1233
1234 2019-06-11  Tom Tromey  <tom@tromey.com>
1235
1236         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1237         (xmalloc_failed): Move to alloc.c.
1238         * alloc.c: New file.
1239         * Makefile.in (COMMON_SFILES): Add alloc.c.
1240
1241 2019-06-11  Tom Tromey  <tom@tromey.com>
1242
1243         * nat/linux-waitpid.c: Don't include server.h.
1244         (linux_debug): Remove.
1245         (my_waitpid): Update.
1246
1247 2019-06-11  Tom Tromey  <tromey@adacore.com>
1248
1249         * infcall.c (_initialize_infcall): Remove trailing newline from
1250         help.
1251         * user-regs.c (_initialize_user_regs): Remove trailing newline
1252         from help.
1253         * typeprint.c (_initialize_typeprint): Remove trailing newline
1254         from help.
1255         * reverse.c (_initialize_reverse): Remove trailing newlines from
1256         help.
1257         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1258         from help.
1259         * language.c (add_set_language_command): Remove trailing newline
1260         from help.
1261         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1262         help.
1263         * disasm.c (_initialize_disasm): Remove trailing newline from
1264         help.
1265         * top.c (init_main): Remove trailing newline from help.
1266         * interps.c (_initialize_interpreter): Remove trailing newline
1267         from help.
1268         * btrace.c (_initialize_btrace): Remove trailing newlines from
1269         help.
1270         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1271         from help.
1272         * python/python.c (_initialize_python): Remove trailing newline
1273         from help.
1274         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1275         help.
1276         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1277         from help.  Reformat some text.
1278         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1279         from help.
1280         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1281         newline from help.
1282
1283 2019-06-11  Tom Tromey  <tromey@adacore.com>
1284
1285         * darwin-nat.c (darwin_decode_exception_message)
1286         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1287
1288 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * valops.c (value_slice): Check for not allocated or not
1291         associated values.
1292
1293 2019-06-10  Tom de Vries  <tdevries@suse.de>
1294
1295         PR gdb/24618
1296         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1297         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1298         invalid.
1299
1300 2019-06-10  Tom de Vries  <tdevries@suse.de>
1301
1302         PR gdb/24611
1303         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1304         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1305
1306 2019-06-10  Tom de Vries  <tdevries@suse.de>
1307
1308         PR symtab/24545
1309         * symtab.c (struct demangled_name_entry): Add language field.
1310         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1311         static minimal symbol".  Set and use language field.
1312
1313 2019-06-10  Tom Tromey  <tromey@adacore.com>
1314
1315         * ada-lang.c (_initialize_ada_language): Update help text.
1316
1317 2019-06-10  Tom Tromey  <tromey@adacore.com>
1318
1319         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1320         with a newline.
1321         * guile/guile.c (handle_boot_error): Don't end warning with a
1322         newline.
1323         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1324         warning with a newline.
1325         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1326         newline.
1327         (s12z_frame_cache): Likewise.
1328         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1329         a newline.
1330         * solib-svr4.c (disable_probes_interface): Don't end warning with
1331         a newline.
1332         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1333         newline.
1334         * python/python.c (do_finish_initialization): Don't end warning
1335         with a newline.
1336
1337 2019-06-10  Tom Tromey  <tom@tromey.com>
1338
1339         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1340         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1341         gdbpy_enter.
1342
1343 2019-06-10  Tom Tromey  <tromey@adacore.com>
1344
1345         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1346         data.
1347         (elf_new_init): Don't call stabsread_new_init.
1348         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1349         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1350         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1351
1352 2019-06-10  Tom de Vries  <tdevries@suse.de>
1353
1354         PR symtab/16264
1355         PR symtab/24517
1356         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1357
1358 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1359
1360         * source.c (find_and_open_source): Also rewrite relative file
1361         names.
1362
1363 2019-04-26  Amos Bird  <amosbird@gmail.com>
1364
1365         * annotate.c (annotate_thread_exited): Add "thread-exited"
1366         annotation.
1367
1368 2019-06-06  Tom Tromey  <tromey@adacore.com>
1369
1370         * maint.h (class scoped_command_stats): Use
1371         DISABLE_COPY_AND_ASSIGN.
1372         <print_time>: New method.
1373         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1374         print_time.
1375         (scoped_command_stats::print_time): New method.
1376
1377 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1380         instructions of lengths 6 or 8 bytes.
1381
1382 2019-06-04  Pedro Alves  <palves@redhat.com>
1383
1384         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1385
1386         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1387         * breakpoint.c (condition_completer): Likewise.
1388         * cli/cli-dump.c (scan_expression): Likewise.
1389         * common/filestuff.c (mkdir_recursive): Likewise.
1390         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1391         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1392         (gdb_abspath): Likewise.
1393         * compile/compile-cplus-types.c
1394         (compile_cplus_instance::decl_name): Likewise.
1395         * completer.c (complete_explicit_location):
1396         (signal_completer, reg_or_group_completer_1): Likewise.
1397         * cp-support.c (cp_remove_params_if_any): Likewise.
1398         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1399         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1400         * infcmd.c (strip_bg_char): Likewise.
1401         * linespec.c (copy_token_string): Likewise.
1402         * mi/mi-main.c (output_cores): Likewise.
1403         * psymtab.c (psymtab_search_name):
1404         * symfile.c (test_set_ext_lang_command): Likewise.
1405         * target.c (target_fileio_read_stralloc): Likewise.
1406         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1407         * value.c (complete_internalvar): Likewise.
1408
1409 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1410
1411         Add objfile property to gdb.Type.
1412         * NEWS: Mention Python API addition.
1413         * python/py-type.c (typy_get_objfile): New method.
1414
1415 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1416
1417         * NEWS: Mention the new set|show style [title|highlight].
1418         Mention changes to "show style", "help" and "apropos".
1419
1420 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1421
1422         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1423         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1424         instead of print_help_for_command.
1425         (print_doc_of_command): New function.
1426         (help_list): Add 'apropos -v word' suggestion.
1427         (print_help_for_command): Style the command name using title style.
1428         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1429         (_initialize_cli_cmds): Describe -v in apropos_command help.
1430
1431 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1432
1433         * cli/cli-style.h (cli_style_option): Add name in constructor,
1434         add m_name class member, add constructor with intensity,
1435         add name class function.
1436         (cli_style_option::add_setshow_commands): Remove name argument.
1437         (highlight_style, title_style): New styles.
1438         * cli/cli-style.c (do_show): New function that shows a style
1439         characteristic styling the style name with itself.
1440         (set_style_name): New function.
1441         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1442         Update all callers according to the changes in cli/cli-style.h.
1443         * utils.h (fputs_highlighted): New function.
1444         * utils.c (fputs_highlighted): Likewise.
1445
1446 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1447
1448         * NEWS: Mention new pipe command and new convenience variables.
1449
1450 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1451
1452         * cli/cli-cmds.c (pipe_command): New function.
1453         (_initialize_cli_cmds): Call add_com for pipe_command.
1454         Define | as an alias for pipe.
1455         (exit_status_set_internal_vars): New function.
1456         (shell_escape): Call exit_status_set_internal_vars.
1457         cli/cli-decode.c (find_command_name_length): Recognize | as
1458         a single character command.
1459
1460 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1461
1462         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1463         top.c (execute_command_to_ui_file): New function, mostly a copy
1464         of execute_command_to_string.
1465         (execute_command_to_string): Implement by calling
1466         execute_command_to_ui_file.
1467
1468 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1469
1470         * top.h (saved_command_line): Remove declaration.
1471         * top.c (previous_saved_command_line, previous_repeat_arguments):
1472         New variables.
1473         (saved_command_line): Make static, define together with other
1474         'repeat variables'.
1475         (dont_repeat): Clear repeat_arguments.
1476         (repeat_previous, get_saved_command_line, save_command_line):
1477         New functions.
1478         (gdb_init): Initialize saved_command_line
1479         and previous_saved_command_line.
1480         * main.c (captured_main_1): Remove saved_command_line initialization.
1481         * event-top.c (handle_line_of_input): Update to use
1482         the new 'repeat' related functions instead of direct access to
1483         saved_command_line.
1484         * command.h (repeat_previous, get_saved_command_line,
1485         save_command_line): New declarations.
1486         (dont_repeat): Add comment.
1487
1488 2019-05-30  Tom Tromey  <tromey@adacore.com>
1489
1490         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1491         Fix comment.
1492         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1493
1494 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1495
1496         PR cli/24587
1497         * completer.c (complete): Initialize variable word.
1498
1499 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1500
1501         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1502         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1503         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1504         'body' is NULL to the outter 'if', protecting the '!is_define'
1505         situation as well.
1506
1507 2019-05-29  Tom Tromey  <tromey@adacore.com>
1508
1509         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1510         (dwarf_unknown): New function.
1511         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1512         (dwarf_type_encoding_name): Use dwarf_unknown.
1513
1514 2019-05-29  Tom Tromey  <tromey@adacore.com>
1515
1516         PR c++/20020:
1517         * cp-valprint.c (cp_print_value_fields): Call
1518         cp_print_static_field inside "try".
1519
1520 2019-05-29  Tom Tromey  <tromey@adacore.com>
1521
1522         * inflow.c (struct terminal_info): Add default operator=.
1523         * configure: Rebuild.
1524         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1525         -Wdeprecated-copy-dtor, -Wredundant-move.
1526
1527 2019-05-29  Tom Tromey  <tromey@adacore.com>
1528
1529         * NEWS: Add entry.
1530         * infcmd.c (print_return_value_1): Handle finish_print
1531         option.
1532         (show_print_finish): New function.
1533         (_initialize_infcmd): Add "set/show print finish" commands.
1534         * valprint.c (user_print_options): Initialize new member.
1535         * valprint.h (struct value_print_options) <finish_print>: New
1536         member.
1537
1538 2019-05-28  Tom Tromey  <tromey@adacore.com>
1539
1540         * ada-lang.c (ada_remove_Xbn_suffix)
1541         (find_old_style_renaming_symbol)
1542         (parse_old_style_renaming): Remove.
1543         (ada_find_renaming_symbol): Don't call
1544         find_old_style_renaming_symbol.
1545         (ada_is_renaming_symbol): Rename from
1546         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1547         bool.  Now static.
1548         (ada_read_var_value): Update and simplify.
1549         * ada-exp.y (write_var_or_type): Remove old code.
1550
1551 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1552
1553         * event-top.c: Remove include comment.
1554         * inflow.c (class scoped_ignore_sigttou): Move from here...
1555         * inflow.h (class scoped_ignore_sigttou): ...to here.
1556         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1557         * top.c:  Remove include comment.
1558
1559 2019-05-27  Tom Tromey  <tom@tromey.com>
1560
1561         * NEWS: Fix typo.
1562
1563 2019-05-22  Tom Tromey  <tromey@adacore.com>
1564
1565         * target.c (target_follow_exec): Constify parameter.
1566         * target-delegates.c: Rebuild.
1567         * remote.c (remote_target::follow_exec): Constify parameter.
1568         * infrun.c (follow_exec): Constify parameter.
1569         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1570         (target_follow_exec): Likewise.
1571
1572 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1573
1574         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1575         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1576
1577 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1578
1579         * NEWS: Add debugredirect and testsuite sections.
1580
1581 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1582
1583         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1584         target descriptions using exclusively floating point register name
1585         aliases.
1586
1587 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1588
1589         PR gdb/18644:
1590         * f-lang.c (build_fortran_types): Handle the case where
1591         gdbarch_floatformat_for_type returns a nullptr.
1592
1593 2019-05-21  Tom de Vries  <tdevries@suse.de>
1594
1595         PR cli/24587
1596         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1597
1598 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1599
1600         PR gdb/18644:
1601         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1602         16-byte floats.
1603         * i386-tdep.c (i386_floatformat_for_type): Use
1604         floatformats_ia64_quad for the 16-byte floating point component
1605         within a fortran 32-byte complex number.
1606
1607 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1610         delete default constructor.
1611         (find_partial_die): Update to return const struct.
1612         (partial_die_parent_scope): Move variable declaration into scope
1613         of its use and change its type to auto.
1614         (guess_partial_die_structure_name): Likewise.
1615         (partial_die_info::fixup): Likewise.
1616
1617 2019-05-17  Tom Tromey  <tromey@adacore.com>
1618
1619         * source.c (find_and_open_source): Remove cast.
1620
1621 2019-05-17  Tom Tromey  <tromey@adacore.com>
1622
1623         * annotate.c (annotate_source): Make "filename" const.
1624         * annotate.h (annotate_source): Use const.
1625
1626 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1627
1628         * disasm.c (set_disassembler_options): Send errors to stderr.
1629
1630 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1631
1632         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1633         (cli_interp_base::set_logging): Check debug_redirect.
1634         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1635         * cli/cli-logging.c (debug_redirect): Add static variable.
1636         (pop_output_files): Add default param.
1637         (handle_redirections): Print debug setting.
1638         (show_logging_command): Likewise.
1639         (_initialize_cli_logging): Add debugredirect command.
1640         * interps.c (current_interp_set_logging): Add debug_redirect
1641         parameter.
1642         * interps.h (set_logging): Add debug_redirect parameter.
1643         (current_interp_set_logging): Likewise.
1644         * mi/mi-common.h: Likewise.
1645         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1646
1647 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1648             Tom Tromey  <tromey@adacore.com>
1649
1650         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1651         directly.
1652         * cli/cli-interp.h (make_logging_output): Remove declaration.
1653         * cli/cli-logging.c (make_logging_output): Remove function.
1654         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1655         directly.
1656         * ui-file.c (tee_file::tee_file): Remove bools.
1657         (tee_file::~tee_file): Remove deletes.
1658         * ui-file.h (tee_file): Remove bools.
1659
1660 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1661
1662         * mi/mi-cmds.h (mi_cmd_complete): New function.
1663         * mi/mi-main.c (mi_cmd_complete): Likewise.
1664         * mi/mi-cmds.c: Define new MI command -complete.
1665         * NEWS: Mention new -complete command.
1666
1667 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1668
1669         * completer.h (complete): New function.
1670         * completer.c (complete): Likewise.
1671         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1672         function defined in completer.h.
1673
1674 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1675
1676         * MAINTAINERS (Write After Approval): Add myself.
1677
1678 2019-05-17  Tom de Vries  <tdevries@suse.de>
1679
1680         PR gdb/24094
1681         * dwarf2read.c (struct cu_partial_die_info): New struct.
1682         (find_partial_die): Return cu_partial_die_info.
1683         (partial_die_parent_scope, guess_partial_die_structure_name)
1684         (partial_die_info::fixup): Handle new return type of find_partial_die.
1685
1686 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1687
1688         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1689         "std::string", simplifying the algorithm.
1690
1691 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1692
1693         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1694         (stap_static_probe_ops::get_probes): Likewise.
1695
1696 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1697
1698         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1699         '-')" and "else if".
1700         (stap_parse_single_operand): Join checks for
1701         "gdbarch_stap_parse_special_token_p" and
1702         "gdbarch_stap_parse_special_token" in the same "if" statement.
1703         Invert check when verifying for operation on register
1704         displacement.
1705
1706 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1707
1708         * stap-probe.c (stap_get_opcode): Update comment.
1709         (stap_get_expected_argument_type): Likewise.
1710         (handle_stap_probe): Likewise.
1711
1712 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1713
1714         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1715         return type to 'bool'.  Adjust comment.  Use 'bool' when
1716         appropriate.
1717         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1718         * stap-probe.c (stap_parse_argument_1): Likewise.
1719         (stap_is_operator): Likewise.
1720         (stap_is_generic_prefix): Likewise.
1721         (stap_is_register_prefix): Likewise.
1722         (stap_is_register_indirection_prefix): Likewise.
1723         (stap_is_integer_prefix): Likewise.
1724         (stap_generic_check_suffix): Likewise.
1725         (stap_check_integer_suffix): Likewise.
1726         (stap_check_register_suffix): Likewise.
1727         (stap_check_register_indirection_suffix): Likewise.
1728         (stap_parse_register_operand): Likewise.
1729         (stap_parse_single_operand): Likewise.
1730         (stap_parse_argument_1): Likewise.
1731         (stap_probe::get_argument_count): Likewise.
1732         (stap_is_operator): Likewise.
1733
1734 2019-05-16  Tom Tromey  <tromey@adacore.com>
1735
1736         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1737         keyword to foreach.
1738
1739 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1740
1741         * linux-thread-db.c (try_thread_db_load_1): Change return type
1742         to bool.
1743         (try_thread_db_load): Likewise.
1744         (try_thread_db_load_from_pdir_1): Likewise.
1745         (try_thread_db_load_from_pdir): Likewise.
1746         (try_thread_db_load_from_sdir): Likewise.
1747         (try_thread_db_load_from_dir): Likewise.
1748         (thread_db_load_search): Likewise.
1749         (has_libpthread): Likewise.
1750         (thread_db_load): Likewise.
1751
1752 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1753
1754         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1755         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1756         NULL, and complain/return if that's the case.
1757
1758 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1759
1760         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1761         (advance, posn, abstract_read_memory): New functions.
1762         [struct mem_read_abstraction]: New struct.
1763         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1764
1765 2019-05-14  Tom Tromey  <tromey@adacore.com>
1766
1767         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1768         value is not lval_memory.
1769
1770 2019-05-14  Tom Tromey  <tromey@adacore.com>
1771
1772         * solib.c (info_sharedlibrary_command): Style the file name.
1773
1774 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1775
1776         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1777         (aarch64_vnv_type): Likewise.
1778         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1779         * common/tdesc.c: Likewise.
1780         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1781         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1782         * features/aarch64-fpu.xml: Add ieee half view.
1783         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1784         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1785         * gdbtypes.h (struct builtin_type): Likewise.
1786         (struct objfile_type): Likewise.
1787
1788 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1789
1790         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1791         typo.
1792         * location.h (string_to_event_location): Likewise.
1793
1794 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1795
1796         GDB 8.3 released.
1797
1798 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1799
1800         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1801         New variable declaration.
1802         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1803         New variable.
1804         (print_one_breakpoint): Use ui_out::test_flags and new global
1805         variable to compute use_fixed_output.
1806         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1807         Remove.
1808         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1809         (mi_multi_location_breakpoint_output_fixed): Remove.
1810         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1811         new variable.
1812         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1813         fix_multi_location_breakpoint_output flag if version >= 3.
1814         * ui-out.h (enum ui_out_flag)
1815         <fix_multi_location_breakpoint_output>: New enumerator.
1816
1817 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1818
1819         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1820
1821 2019-05-10  Tom Tromey  <tromey@adacore.com>
1822
1823         * ada-lang.c (catch_ada_completer): New function.
1824         (_initialize_ada_language): Use it.
1825
1826 2019-05-10  Tom Tromey  <tromey@adacore.com>
1827
1828         * thread.c (print_thread_info): Make "requested_threads" const.
1829         * gdbthread.h (print_thread_info): Make "requested_threads"
1830         const.
1831         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1832         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1833
1834 2019-05-08  Tom Tromey  <tom@tromey.com>
1835
1836         * gdbtypes.c (objfile_type_data): Change type.
1837         (objfile_type, _initialize_gdbtypes): Update.
1838
1839 2019-05-08  Tom Tromey  <tom@tromey.com>
1840
1841         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1842         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1843         (_initialize_dwarf2_frame): Update.
1844
1845 2019-05-08  Tom Tromey  <tom@tromey.com>
1846
1847         * objc-lang.c (objc_objfile_data): Change type.
1848         (find_methods): Update.
1849         (_initialize_objc_lang): Remove.
1850
1851 2019-05-08  Tom Tromey  <tom@tromey.com>
1852
1853         * stabsread.c (rs6000_builtin_type_data): Change type.
1854         (rs6000_builtin_type, _initialize_stabsread): Update.
1855
1856 2019-05-08  Tom Tromey  <tom@tromey.com>
1857
1858         * mips-tdep.c (mips_pdr_data): Remove.
1859         (_initialize_mips_tdep): Update.
1860
1861 2019-05-08  Tom Tromey  <tom@tromey.com>
1862
1863         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1864         (hppa_init_objfile_priv_data, read_unwind_info)
1865         (find_unwind_entry, _initialize_hppa_tdep): Update.
1866
1867 2019-05-08  Tom Tromey  <tom@tromey.com>
1868
1869         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1870         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1871         on obstack.
1872         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1873
1874 2019-05-08  Tom Tromey  <tom@tromey.com>
1875
1876         * mdebugread.c (basic_type_data): Change type.
1877         (basic_type, _initialize_mdebugread): Update.
1878
1879 2019-05-08  Tom Tromey  <tom@tromey.com>
1880
1881         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1882
1883 2019-05-08  Tom Tromey  <tom@tromey.com>
1884
1885         * nto-tdep.c (nto_inferior_data_reg): Change type.
1886         (nto_inferior_data): Update.
1887         (nto_inferior_data_cleanup, nto_new_inferior_data)
1888         (_initialize_nto_tdep): Remove.
1889         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1890
1891 2019-05-08  Tom Tromey  <tom@tromey.com>
1892
1893         * ada-lang.c (struct ada_inferior_data): Add initializers.
1894         (ada_inferior_data): Change type.
1895         (ada_inferior_data_cleanup): Remove.
1896         (get_ada_inferior_data, ada_inferior_exit)
1897         (struct ada_pspace_data): Add initializers, destructor.
1898         (ada_pspace_data_handle): Change type.
1899         (get_ada_pspace_data): Update.
1900         (ada_pspace_data_cleanup): Remove.
1901
1902 2019-05-08  Tom Tromey  <tom@tromey.com>
1903
1904         * coffread.c (struct coff_symfile_info): Add initializers.
1905         (coff_objfile_data_key): Move lower.  Change type.
1906         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1907         Update.
1908         (coff_free_info): Remove.
1909
1910 2019-05-08  Tom Tromey  <tom@tromey.com>
1911
1912         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1913         (fbsd_pspace_data_handle): Move lower.  Change type.
1914         (get_fbsd_pspace_data): Update.
1915         (fbsd_pspace_data_cleanup): Remove.
1916         (_initialize_fbsd_tdep): Update.
1917
1918 2019-05-08  Tom Tromey  <tom@tromey.com>
1919
1920         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1921         (get_ada_tasks_pspace_data): Update.
1922         (ada_tasks_pspace_data_cleanup): Remove.
1923         (_initialize_tasks): Update.
1924         (ada_tasks_inferior_data_handle): Change type.
1925         (get_ada_tasks_inferior_data): Update.
1926         (ada_tasks_inferior_data_cleanup): Remove.
1927         (struct ada_tasks_pspace_data): Add initializers.
1928
1929 2019-05-08  Tom Tromey  <tom@tromey.com>
1930
1931         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1932         * symfile-debug.c (debug_sym_get_probes): Change type.
1933         * stap-probe.c (handle_stap_probe):
1934         (stap_static_probe_ops::get_probes): Change type.
1935         * probe.h (class static_probe_ops) <get_probes>: Change type.
1936         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1937         (parse_probes_in_pspace): Update.
1938         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1939         Update.
1940         (any_static_probe_ops::get_probes): Change type.
1941         * elfread.c (elfread_data): New typedef.
1942         (probe_key): Change type.
1943         (elf_get_probes): Likewise.  Update.
1944         (probe_key_free): Remove.
1945         (_initialize_elfread): Update.
1946         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1947         Change type.
1948         (dtrace_process_dof_probe, dtrace_process_dof)
1949         (dtrace_static_probe_ops::get_probe): Change type.
1950
1951 2019-05-08  Tom Tromey  <tom@tromey.com>
1952
1953         * xcoffread.c (struct xcoff_symfile_info): Rename from
1954         coff_symfile_info.  Add initializers.
1955         (xcoff_objfile_data_key): Move lower.  Change type.
1956         (XCOFF_DATA): Rewrite.
1957         (xcoff_free_info): Remove.
1958         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1959         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1960         (xcoff_initial_scan): Update.
1961
1962 2019-05-08  Tom Tromey  <tom@tromey.com>
1963
1964         * solib-svr4.c (struct svr4_info): Add initializers and
1965         destructor.
1966         <probes_table>: Now an htab_up.
1967         (solib_svr4_pspace_data): Change type.
1968         (free_probes_table): Simplify.
1969         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1970         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1971         (probes_table_remove_objfile_probes, register_solib_event_probe)
1972         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1973         (_initialize_svr4_solib): Update.
1974
1975 2019-05-08  Tom Tromey  <tom@tromey.com>
1976
1977         * remote.c (remote_pspace_data): Change type.
1978         (remote_pspace_data_cleanup): Remove.
1979         (get_remote_exec_file, set_pspace_remote_exec_file)
1980         (_initialize_remote): Update.
1981
1982 2019-05-08  Tom Tromey  <tom@tromey.com>
1983
1984         * breakpoint.c (breakpoint_objfile_key): Change type.
1985         (get_breakpoint_objfile_data): Update.
1986         (free_breakpoint_objfile_data): Remove.
1987         (_initialize_breakpoint): Update.
1988
1989 2019-05-08  Tom Tromey  <tom@tromey.com>
1990
1991         * linux-tdep.c (struct linux_info): Add initializers.
1992         (linux_inferior_data): Move.  Change type.
1993         (invalidate_linux_cache_inf): Update.
1994         (linux_inferior_data_cleanup): Remove.
1995         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1996
1997 2019-05-08  Tom Tromey  <tom@tromey.com>
1998
1999         * auxv.c (auxv_inferior_data): Move.  Change type.
2000         (auxv_inferior_data_cleanup): Remove.
2001         (invalidate_auxv_cache_inf): Rewrite.
2002         (get_auxv_inferior_data, _initialize_auxv): Update.
2003
2004 2019-05-08  Tom Tromey  <tom@tromey.com>
2005
2006         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2007         (symfile_debug_objfile_data_key): Change type.
2008         (symfile_debug_installed, debug_qf_has_symbols)
2009         (debug_qf_find_last_source_symtab)
2010         (debug_qf_forget_cached_source_info)
2011         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2012         (debug_qf_print_stats, debug_qf_dump)
2013         (debug_qf_expand_symtabs_for_function)
2014         (debug_qf_expand_all_symtabs)
2015         (debug_qf_expand_symtabs_with_fullname)
2016         (debug_qf_map_matching_symbols)
2017         (debug_qf_expand_symtabs_matching)
2018         (debug_qf_find_pc_sect_compunit_symtab)
2019         (debug_qf_map_symbol_filenames)
2020         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2021         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2022         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2023         (debug_sym_read_linetable, debug_sym_relocate): Update.
2024         (symfile_debug_free_objfile): Remove.
2025         (install_symfile_debug_logging, _initialize_symfile_debug):
2026         Update.
2027
2028 2019-05-08  Tom Tromey  <tom@tromey.com>
2029
2030         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2031         allocate_on_obstack.
2032         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2033         (get_dwarf2_per_objfile): Update.
2034         (set_dwarf2_per_objfile): Remove.
2035         (dwarf2_has_info, dwarf2_get_section_info): Update.
2036         (dwarf2_free_objfile): Remove.
2037         (_initialize_dwarf2_read): Update.
2038
2039 2019-05-08  Tom Tromey  <tom@tromey.com>
2040
2041         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2042         initializers.
2043         <unsupported_script_warning_printed,
2044         script_not_found_warning_printed>: Now bool.
2045         (auto_load_pspace_data): Change type.
2046         (~auto_load_pspace_info): Rename from
2047         auto_load_pspace_data_cleanup.
2048         (get_auto_load_pspace_data, init_loaded_scripts_info)
2049         (clear_section_scripts, maybe_print_unsupported_script_warning)
2050         (maybe_print_script_not_found_warning, _initialize_auto_load):
2051         Update.
2052
2053 2019-05-08  Tom Tromey  <tom@tromey.com>
2054
2055         * objfiles.c (objfile_pspace_info): Add destructor and
2056         initializers.
2057         (objfiles_pspace_data): Change type.
2058         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2059         (get_objfile_pspace_data): Update.
2060         (objfiles_bfd_data): Change type.
2061         (get_objfile_bfd_data): Update.
2062         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2063
2064 2019-05-08  Tom Tromey  <tom@tromey.com>
2065
2066         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2067         Change type.
2068         (get_catch_syscall_inferior_data): Update.
2069         (catch_syscall_inferior_data_cleanup): Remove.
2070         (_initialize_break_catch_syscall): Update.
2071
2072 2019-05-08  Tom Tromey  <tom@tromey.com>
2073
2074         * inflow.c (struct terminal_info): Add destructor and
2075         initializers.
2076         (inflow_inferior_data): Change type.
2077         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2078         (get_inflow_inferior_data, inflow_inferior_exit)
2079         (swap_terminal_info, _initialize_inflow): Update.
2080
2081 2019-05-08  Tom Tromey  <tom@tromey.com>
2082
2083         * target-dcache.c (target_dcache_cleanup): Remove.
2084         (target_dcache_aspace_key): Change type.
2085         (target_dcache_init_p, target_dcache_invalidate)
2086         (target_dcache_get, target_dcache_get_or_init)
2087         (_initialize_target_dcache): Update.
2088         * dcache.h (struct dcache_deleter): New.
2089
2090 2019-05-08  Tom Tromey  <tom@tromey.com>
2091
2092         * symtab.c (struct symbol_cache): Add destructor and
2093         initializers.
2094         (symbol_cache_key): Move.  Change type.
2095         (make_symbol_cache, free_symbol_cache): Remove.
2096         (get_symbol_cache): Update.
2097         (symbol_cache_cleanup): Remove.
2098         (ALL_PSPACES, symbol_cache_flush)
2099         (maintenance_print_symbol_cache)
2100         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2101         Update.
2102
2103 2019-05-08  Tom Tromey  <tom@tromey.com>
2104
2105         * symtab.c (struct main_info): Add destructor and initializers.
2106         (main_progspace_key): Move.  Change type.
2107         (get_main_info): Update.
2108         (main_info_cleanup): Remove.
2109         (_initialize_symtab): Update.
2110
2111 2019-05-08  Tom Tromey  <tom@tromey.com>
2112
2113         * registry.h (DECLARE_REGISTRY): Define the _key class.
2114
2115 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * NEWS: Merge two 'New commands' sections.
2118
2119 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2120
2121         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2122         parameter and use Ada language definition instead.
2123         (ada_val_print_ptr): Remove unused language parameter.
2124         (ada_val_print_num): Remove language parameter and use Ada language
2125         definition instead.
2126         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2127         parameter.
2128         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2129         parameter and use Ada language definition instead.
2130         (ada_val_print_1): Update all ada_val_print_xxx calls.
2131         Remove language parameter.
2132         (ada_val_print): Update ada_val_print_1 call.
2133
2134 2019-05-08  Tom Tromey  <tromey@adacore.com>
2135
2136         * remote.c (remote_hw_watchpoint_limit)
2137         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2138         Now static.
2139
2140 2019-05-08  Tom Tromey  <tromey@adacore.com>
2141
2142         * maint.c (_initialize_maint_cmds): Move initialization code to
2143         remote.c.
2144         (watchdog, show_watchdog): Move to remote.c.
2145         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2146         "watchdog" static.
2147         (_initialize_remote): Move initialization code from maint.c.
2148         * defs.h (watchdog): Don't declare.
2149
2150 2019-05-08  Tom Tromey  <tromey@adacore.com>
2151
2152         * tui/tui-interp.c: Include main.h.
2153         * interps.c: Include main.h.
2154         * main.h (interpreter_p): Declare.
2155         * defs.h (interpreter_p): Don't declare.
2156
2157 2019-05-08  Tom Tromey  <tromey@adacore.com>
2158
2159         * dwarf2loc.c: Include dwarf2read.h.
2160         * defs.h (read_unsigned_leb128): Don't declare.
2161         * dwarf2read.h (read_unsigned_leb128): Declare.
2162
2163 2019-05-08  Tom Tromey  <tromey@adacore.com>
2164
2165         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2166         method.
2167
2168 2019-05-08  Tom Tromey  <tromey@adacore.com>
2169
2170         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2171         when no wrap column is set.
2172
2173 2019-05-08  Tom Tromey  <tromey@adacore.com>
2174
2175         * c-lang.c (c_get_string): Handle non-C-style arrays.
2176
2177 2019-05-08  Tom Tromey  <tromey@adacore.com>
2178
2179         * typeprint.c (print_offset_data::update): Print the bit offset,
2180         not the number of bits remaining.
2181
2182 2019-05-08  Tom Tromey  <tromey@adacore.com>
2183
2184         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2185         padding at end of comment.
2186
2187 2019-05-08  Tom Tromey  <tromey@adacore.com>
2188
2189         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2190         Compare main types.
2191
2192 2019-05-06  Tom Tromey  <tom@tromey.com>
2193
2194         * common/scoped_mmap.c: Include common-defs.h.
2195         * common/scoped_mmap.h: Don't include config.h.
2196
2197 2019-05-04  Tom Tromey  <tom@tromey.com>
2198
2199         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2200         (struct aarch64_call_info): Add initializers.
2201         <si>: Now a std::vector.
2202         (pass_on_stack, aarch64_push_dummy_call): Update.
2203
2204 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2205             Tom Tromey  <tom@tromey.com>
2206
2207         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2208         (ppc_threads): Now a std::vector.  Now static.
2209         (hwdebug_find_thread_points_by_tid)
2210         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2211         Update.
2212
2213 2019-05-04  Tom Tromey  <tom@tromey.com>
2214
2215         * arc-tdep.c (arc_tdesc_init): Return bool.
2216
2217 2019-05-04  Tom Tromey  <tom@tromey.com>
2218
2219         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2220         Use gdb_assert_not_reached.
2221
2222 2019-05-04  Tom Tromey  <tom@tromey.com>
2223
2224         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2225         "false".
2226
2227 2019-05-04  Tom Tromey  <tom@tromey.com>
2228
2229         * arc-tdep.c (arc_tdesc_init): Use bool.
2230
2231 2019-05-04  Tom Tromey  <tom@tromey.com>
2232
2233         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2234
2235 2019-05-04  Tom Tromey  <tom@tromey.com>
2236
2237         * cli/cli-cmds.c (valid_command_p): Return bool.
2238
2239 2019-05-04  Tom Tromey  <tom@tromey.com>
2240
2241         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2242         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2243
2244 2019-05-04  Raul Tambre  <raul@tambre.ee>
2245
2246         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2247         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2248         operator for comparison.
2249
2250 2019-05-04  Tom Tromey  <tom@tromey.com>
2251
2252         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2253         (lookup_partial_symbol, print_partial_symbols)
2254         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2255         (psymbol_compare): Update.
2256         (add_psymbol_to_bcache): Clear the entire psymbol.
2257         (maintenance_check_psymtabs): Update.
2258         * psympriv.h (struct partial_symbol): Don't derive from
2259         general_symbol_info.
2260         <obj_section, unrelocated_address, address,
2261         set_unrelocated_address>: Update.
2262         <ginfo>: New member.
2263         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2264         (debug_names::write_psymbols): Update.
2265
2266 2019-05-04  Tom de Vries  <tdevries@suse.de>
2267
2268         * contrib/cc-with-tweaks.sh: Support -n arg.
2269
2270 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2271
2272         * corelow.c (core_target::detach): Ensure frame cache and
2273         register caches are cleared.
2274         inferior.c (exit_inferior_1): Likewise.
2275
2276 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2277             Tom Tromey  <tom@tromey.com>
2278
2279         * dictionary.c (collate_pending_symbols_by_language): Remove
2280         "struct" from foreach.
2281         * symtab.c (lookup_global_symbol_from_objfile)
2282         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2283         foreach.
2284         * ser-tcp.c (net_open): Remove "struct" from foreach.
2285         * objfiles.c (objfile_relocate, objfile_rebase)
2286         (objfile_has_symbols): Remove "struct" from foreach.
2287         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2288         from foreach.
2289         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2290         foreach.
2291         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2292         "struct" from foreach.
2293         * ada-lang.c (create_excep_cond_exprs)
2294         (ada_exception_catchpoint_cond_string): Remove "struct" from
2295         foreach.
2296
2297 2019-05-03  Tom Tromey  <tromey@adacore.com>
2298
2299         * ada-exp.y (convert_char_literal): Check suffix of each
2300         enumerator.
2301
2302 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2303
2304         PR ada/21406:
2305         * ada-exp.y (yywrap): Don't define.
2306         * ada-lex.l (%option): Add noyywrap
2307         (yywrap): Remove.
2308
2309 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2310
2311         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2312         _WIN32_WINNT to the XP level, unless already defined to a higher
2313         level.
2314
2315         * unittests/parse-connection-spec-selftests.c:
2316         * ser-tcp.c:
2317         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2318         override.
2319
2320         * symfile.c (find_separate_debug_file): Remove colon from the
2321         drive spec of DOS/Windows file names of the target, so that the
2322         file name produced from DEBUGDIR and the target's directory will
2323         be valid on DOS/Windows systems.
2324
2325 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2326
2327         * rust-lang.c (val_print_struct): Handle printing structures
2328         containing strings.
2329
2330 2019-05-02  Tom Tromey  <tromey@adacore.com>
2331
2332         * valarith.c (_initialize_valarith): Remove.
2333
2334 2019-05-01  Tom Tromey  <tromey@adacore.com>
2335
2336         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2337         bitfields.
2338
2339 2019-05-01  Tom Tromey  <tromey@adacore.com>
2340
2341         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2342         for big-endian copies.
2343
2344 2019-04-30  Ali Tamur  <tamur@google.com>
2345         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2346         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2347         (read_3_bytes): New function.
2348
2349 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2350
2351         * windows-nat.c (main_thread_id): Delete.
2352         (handle_output_debug_string): Replace main_thread_id by
2353         current_event.dwThreadId.
2354         (fake_create_process): Likewise.
2355         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2356         Do not set main_thread_id.
2357         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2358         current_event.dwThreadId.
2359         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2360
2361 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2362
2363         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2364         Use current_event.dwThreadId instead of main_thread_id.
2365
2366 2019-04-30  Tom Tromey  <tromey@adacore.com>
2367
2368         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2369         (create_excep_cond_exprs): Iterate over program spaces.
2370         (ada_exception_catchpoint_cond_string): Examine all minimal
2371         symbols for exception types.
2372
2373 2019-04-30  Tom Tromey  <tromey@adacore.com>
2374
2375         PR c++/24470:
2376         * dwarf2read.c (process_structure_scope): Handle case where type
2377         has template parameters but no symbol was created.
2378
2379 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2380             Chris January  <chris.january@arm.com>
2381
2382         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2383         qualifier.
2384         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2385
2386 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2387
2388         * f-typeprint.c (f_print_type): Update rules for printing
2389         whitespace.
2390         (f_type_print_varspec_suffix): Likewise.
2391
2392 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2393             Chris January  <chris.january@arm.com>
2394
2395         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2396         function arguments.
2397
2398 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2399
2400         * f-lang.c (build_fortran_types): Change name of void type to
2401         lower case.
2402         * f-typeprint.c (f_type_print_base): Print the name of the void
2403         type, rather than a fixed string.
2404         * f-valprint.c (f_decorations): Use lower case void string.
2405
2406 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2407             Chris January  <chris.january@arm.com>
2408
2409         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2410         types for Fortran.
2411
2412 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2413             Chris January  <chris.january@arm.com>
2414             David Lecomber  <david.lecomber@arm.com>
2415
2416         * f-exp.y (BINOP_INTRINSIC): New token.
2417         (exp): New parser rule handling BINOP_INTRINSIC.
2418         (f77_keywords): Add new builtin procedures.
2419         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2420         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2421         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2422         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2423         (print_unop_subexp_f): New function.
2424         (print_binop_subexp_f): New function.
2425         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2426         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2427         (dump_subexp_body_f): Likewise.
2428         (operator_check_f): Likewise.
2429         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2430         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2431
2432 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2435         UNOP_KIND.
2436         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2437         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2438         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2439         (operator_length_f): New fuction.
2440         (print_subexp_f): New function.
2441         (op_name_f): New function.
2442         (dump_subexp_body_f): New function.
2443         (operator_check_f): New function.
2444         (exp_descriptor_f): Replace standard expression handling functions
2445         with new functions.
2446         * gdb/fortran-operator.def: New file.
2447         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2448         * gdb/std-operator.def: Remove UNOP_KIND.
2449
2450 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * std-operator.def: Remove unbalanced, stray double quote
2453         character.
2454
2455 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2456             Chris January  <chris.january@arm.com>
2457             Daniel Everett  <daniel.everett@arm.com>
2458             Nick Forrington  <nick.forrington@arm.com>
2459             Richard Bunt  <richard.bunt@arm.com>
2460
2461         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2462         of depth when printing anonymous structs or unions.
2463         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2464         Don't print either the top-level value, or the children if the
2465         max-depth is exceeded.
2466         (ppscm_print_children): When printing the key of a map, allow one
2467         extra level of depth.
2468         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2469         print either the top-level value, or the children if the max-depth
2470         is exceeded.
2471         (print_children): When printing the key of a map, allow one extra
2472         level of depth.
2473         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2474         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2475         (user_print_options): Initialise max_depth field.
2476         (val_print_scalar_or_string_type_p): New function.
2477         (val_print): Check to see if the max depth has been reached.
2478         (val_print_check_max_depth): Define new function.
2479         (show_print_max_depth): New function.
2480         (_initialize_valprint): Add 'print max-depth' option.
2481         * valprint.h (struct value_print_options) <max_depth>: New field.
2482         (val_print_check_max_depth): Declare new function.
2483         * NEWS: Document new feature.
2484
2485 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2486
2487         * ada-lang.c (ada_language_defn): Initialise new field.
2488         * c-lang.c (c_is_string_type_p): New function.
2489         (c_language_defn): Initialise new field.
2490         (cplus_language_defn): Initialise new field.
2491         (asm_language_defn): Initialise new field.
2492         (minimal_language_defn): Initialise new field.
2493         * c-lang.h (c_is_string_type_p): Declare new function.
2494         * d-lang.c (d_language_defn): Initialise new field.
2495         * f-lang.c (f_is_string_type_p): New function.
2496         (f_language_defn): Initialise new field.
2497         * go-lang.c (go_is_string_type_p): New function.
2498         (go_language_defn): Initialise new field.
2499         * language.c (default_is_string_type_p): New function.
2500         (unknown_language_defn): Initialise new field.
2501         (auto_language_defn): Initialise new field.
2502         * language.h (struct language_defn) <la_is_string_type_p>: New
2503         member variable.
2504         (default_is_string_type_p): Declare new function.
2505         * m2-lang.c (m2_language_defn): Initialise new field.
2506         * objc-lang.c (objc_language_defn): Initialise new field.
2507         * opencl-lang.c (opencl_language_defn): Initialise new field.
2508         * p-lang.c (pascal_is_string_type_p): New function.
2509         (pascal_language_defn): Initialise new field.
2510         * rust-lang.c (rust_is_string_type_p): New function.
2511         (rust_language_defn): Initialise new field.
2512
2513 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2516         New field.
2517         * ada-lang.c (ada_language_defn): Initialise new field.
2518         * c-lang.c (c_language_defn): Likewise.
2519         (cplus_language_defn): Likewise.
2520         (asm_language_defn): Likewise.
2521         (minimal_language_defn): Likewise.
2522         * d-lang.c (d_language_defn): Likewise.
2523         * f-lang.c (f_language_defn): Likewise.
2524         * go-lang.c (go_language_defn): Likewise.
2525         * language.c (unknown_language_defn): Likewise.
2526         (auto_language_defn): Likewise.
2527         * m2-lang.c (m2_language_defn): Likewise.
2528         * objc-lang.c (objc_language_defn): Likewise.
2529         * opencl-lang.c (opencl_language_defn): Likewise.
2530         * p-lang.c (pascal_language_defn): Likewise.
2531         * rust-lang.c (rust_language_defn): Likewise.
2532
2533 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * ada-lang.c (ada_is_character_type): Change return type to bool.
2536         (ada_is_string_type): Likewise.
2537         * ada-lang.h (ada_is_character_type): Update declaration
2538         (ada_is_string_type): Likewise.
2539
2540 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2541
2542         Support style in 'frame|thread apply'
2543
2544         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2545         * record.c (record_start, record_stop): Update callers of
2546         execute_command_to_string with false.
2547         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2548         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2549         methods.
2550         (class string_file): New constructor with term_out parameter.
2551         Override methods term_out and can_emit_style_escape.  New member
2552         term_out.
2553         (class stdio_file): Override can_emit_style_escape.
2554         (class tee_file): Override term_out and can_emit_style_escape.
2555         * utils.h (can_emit_style_escape): Remove.
2556         * utils.c (can_emit_style_escape): Likewise.
2557         Update all callers of can_emit_style_escape (SOMESTREAM) to
2558         SOMESTREAM->can_emit_style_escape.
2559         * source-cache.c (source_cache::get_source_lines): Likewise.
2560         * stack.c (frame_apply_command_count): Call execute_command_to_string
2561         passing the term_out characteristic of the current gdb_stdout.
2562         * thread.c (thr_try_catch_cmd): Likewise.
2563         * top.c (execute_command_to_string): pass term_out parameter
2564         to construct the string_file for the command output.
2565         * ui-file.c (term_cli_styling): New function (most code moved
2566         from utils.c can_emit_style_escape).
2567         (string_file::string_file, string_file::can_emit_style_escape,
2568         stdio_file::can_emit_style_escape, tee_file::term_out,
2569         tee_file::can_emit_style_escape): New functions.
2570
2571 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2572
2573         * NEWS: Mention the new set|show may-call-functions.
2574         * infcall.c (may_call_functions_p): New variable.
2575         (show_may_call_functions_p): New function.
2576         (call_function_by_hand_dummy): Throws an error if not
2577         may-call-functions.
2578         (_initialize_infcall): Call add_setshow_boolean_cmd for
2579         may-call-functions.
2580
2581 2019-04-25  Keith Seitz  <keiths@redhat.com>
2582
2583         PR c++/24367
2584         * cp-support.c (inspect_type): Don't attempt substitutions
2585         of symbol with the same name.
2586
2587 2019-04-25  Tom Tromey  <tromey@adacore.com>
2588
2589         PR gdb/24475:
2590         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2591         static.
2592
2593 2019-04-25  Tom Tromey  <tromey@adacore.com>
2594
2595         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2596         rvalue reference.
2597         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2598         (gdb_xml_parser::parse): Use std::move.
2599         * python/python-internal.h (gdbpy_convert_exception): Take a const
2600         reference.
2601         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2602         std::move.
2603         * python/py-utils.c (gdbpy_convert_exception): Take a const
2604         reference.
2605         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2606         Use std::move.
2607         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2608         Use std::move.
2609         * mi/mi-main.c (mi_print_exception): Take a const reference.
2610         * main.c (handle_command_errors): Take a const reference.
2611         * linespec.c (parse_linespec): Use std::move.
2612         * infcall.c (run_inferior_call): Use std::move.
2613         (call_function_by_hand_dummy): Use std::move.
2614         * exec.c (try_open_exec_file): Use std::move.
2615         * exceptions.h (exception_print, exception_fprintf)
2616         (exception_print_same): Update.
2617         * exceptions.c (print_exception, exception_print)
2618         (exception_fprintf, exception_print_same): Change parameters to
2619         const reference.
2620         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2621         * common/new-op.c: Use std::move.
2622         * common/common-exceptions.h (struct gdb_exception): Add move
2623         constructor.
2624         (struct gdb_exception_error, struct gdb_exception_quit, struct
2625         gdb_quit_bad_alloc): Change constructor to move constructor.
2626         (throw_exception): Change parameter to rvalue reference.
2627         * common/common-exceptions.c (throw_exception): Take rvalue
2628         reference.
2629         * cli/cli-interp.c (safe_execute_command): Use std::move.
2630         * breakpoint.c (insert_bp_location, location_to_sals): Use
2631         std::move.
2632
2633 2019-04-25  Tom Tromey  <tromey@adacore.com>
2634
2635         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2636         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2637         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2638         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2639         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2640         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2641         guile/scm-value.c: Use unpack.
2642         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2643         gdbscm_gdb_exception.
2644         (gdbscm_throw_gdb_exception): Likewise.
2645         (struct gdbscm_gdb_exception): New.
2646         (unpack): New function.
2647         (gdbscm_wrap): Use unpack.
2648
2649 2019-04-25  Tom Tromey  <tromey@adacore.com>
2650
2651         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2652         (gdb_rl_callback_handler): Use std::move.
2653         * common/common-exceptions.h (struct gdb_exception): Add move
2654         assignment operator.
2655         (throw_exception_sjlj): Change "exception" to const reference.
2656         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2657         (throw_exception_sjlj): Change "exception" to const reference.
2658
2659 2019-04-25  Tom Tromey  <tromey@adacore.com>
2660
2661         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2662         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2663         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2664         Update.
2665         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2666         Update.
2667         * mi/mi-interp.c (mi_interp::exec): Update.
2668         * linespec.c (parse_linespec): Update.
2669         * infcall.c (run_inferior_call): Update.
2670         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2671         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2672         (gdbscm_lookup_global_symbol): Update.
2673         * guile/scm-param.c (gdbscm_parameter_value): Update.
2674         * guile/scm-frame.c (gdbscm_frame_read_register)
2675         (gdbscm_frame_read_var): Update.
2676         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2677         * exec.c (try_open_exec_file): Update.
2678         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2679         (gdb_rl_callback_handler): Update.
2680         * common/common-exceptions.h (exception_none): Don't declare.
2681         * common/common-exceptions.c (exception_none): Don't define.
2682         (struct catcher) <exception>: Update.
2683         * cli/cli-interp.c (safe_execute_command): Update.
2684         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2685
2686 2019-04-25  Ali Tamur  <tamur@google.com>
2687
2688         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2689         (read_attribute_value): Likewise.
2690         (dwarf2_read_addr_index): Update comment.
2691         (read_str_index): Add DW_FORM_strx.
2692         (dwarf2_string_attr): Likewise.
2693         (dwarf2_const_value_attr): Likewise.
2694         (dump_die_shallow): Likewise.
2695         (dwarf2_fetch_constant_bytes): Likewise.
2696         (skip_form_bytes): Likewise.
2697         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2698
2699 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2700
2701         PR corefiles/11608
2702         PR corefiles/18187
2703         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2704         OFFSET.  Verify if current mapping contains an ELF header.
2705         (linux_find_memory_regions_full): Adjust call to
2706         dump_mapping_p.
2707
2708 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2709             Kang Li <kanglictf@gmail.com>
2710
2711         PR gdb/21600
2712
2713         * dwarf2-frame.c (read_initial_length): Be consistent about using
2714         unsigned representation of length.
2715         (decode_frame_entry_1): Likewise.  Check for wraparound of
2716         end pointer as well as buffer overflow.
2717
2718 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2719
2720         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2721         "vq".
2722
2723 2019-04-24  Tom Tromey  <tromey@adacore.com>
2724
2725         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2726
2727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2728
2729         * s12z-tdep.c (s12z_unwind_pc): Delete.
2730         (s12z_unwind_sp): Delete.
2731         (s12z_gdbarch_init): Don't register deleted functions with
2732         gdbarch.
2733
2734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2735
2736         * rl78-tdep.c (rl78_unwind_sp): Delete.
2737         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2738
2739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2742         (xstormy16_unwind_pc): Delete.
2743         (xstormy16_dummy_id): Delete.
2744         (xstormy16_gdbarch_init): Don't register deleted functions with
2745         gdbarch.
2746
2747 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         * vax-tdep.c (vax_unwind_pc): Delete.
2750         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2751
2752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2753
2754         * v850-tdep.c (v850_unwind_sp): Delete.
2755         (v850_unwind_pc): Delete.
2756         (v850_dummy_id): Delete.
2757         (v850_gdbarch_init): Don't register deleted functions with
2758         gdbarch.
2759
2760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2763         (tilegx_unwind_pc): Delete.
2764         (tilegx_unwind_dummy_id): Delete.
2765         (tilegx_gdbarch_init): Don't register deleted functions with
2766         gdbarch.
2767
2768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2769
2770         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2771         (tic6x_dummy_id): Delete.
2772         (tic6x_gdbarch_init): Don't register deleted functions with
2773         gdbarch.
2774
2775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2776
2777         * sparc-tdep.c (sparc_unwind_pc): Delete.
2778         (sparc32_gdbarch_init): Don't register deleted function with
2779         gdbarch.
2780
2781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * sh-tdep.c (sh_unwind_sp): Delete.
2784         (sh_unwind_pc): Delete.
2785         (sh_dummy_id): Delete.
2786         (sh_gdbarch_init): Don't register deleted functions with
2787         gdbarch.
2788
2789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * score-tdep.c (score_unwind_sp): Delete.
2792         (score_unwind_pc): Delete.
2793         (score_dummy_id): Delete.
2794         (score_gdbarch_init): Don't register deleted functions with
2795         gdbarch.
2796
2797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2798
2799         * rx-tdep.c (rx_unwind_pc): Delete.
2800         (rx_unwind_sp): Delete.
2801         (rx_dummy_id): Delete.
2802         (rx_gdbarch_init): Don't register deleted functions with
2803         gdbarch.  Update comment.
2804
2805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2808         (rs6000_dummy_id): Delete.
2809         (rs6000_gdbarch_init): Don't register deleted functions with
2810         gdbarch.
2811
2812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2813
2814         * or1k-tdep.c (or1k_dummy_id): Delete.
2815         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2816
2817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2818
2819         * nios2-tdep.c (nios2_dummy_id): Delete.
2820         (nios2_unwind_sp): Delete.
2821         (nios2_gdbarch_init): Don't register deleted functions with
2822         gdbarch.
2823
2824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * nds32-tdep.c (nds32_dummy_id): Delete.
2827         (nds32_unwind_pc): Delete.
2828         (nds32_unwind_sp): Delete.
2829         (nds32_gdbarch_init): Don't register deleted functions with
2830         gdbarch.
2831
2832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * msp430-tdep.c (msp430_unwind_pc): Delete.
2835         (msp430_unwind_sp): Delete.
2836         (msp430_dummy_id): Delete.
2837         (msp430_gdbarch_init): Don't register deleted functions with
2838         gdbarch.
2839
2840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         * moxie-tdep.c (moxie_unwind_sp): Delete.
2843         (moxie_unwind_pc): Delete.
2844         (moxie_dummy_id): Delete.
2845         (moxie_gdbarch_init): Don't register deleted functions with
2846         gdbarch.
2847
2848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2851         (mn10300_unwind_pc): Delete.
2852         (mn10300_unwind_sp): Delete.
2853         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2854         mn10300_unwind_sp.
2855         (mn10300_frame_unwind_init): Don't register deleted functions with
2856         gdbarch.
2857
2858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2859
2860         * mep-tdep.c (mep_unwind_pc): Delete.
2861         (mep_unwind_sp): Delete.
2862         (mep_dummy_id): Delete.
2863         (mep_gdbarch_init): Don't register deleted functions with
2864         gdbarch.
2865
2866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2869         (m68hc11_unwind_sp): Delete.
2870         (m68hc11_gdbarch_init): Don't register deleted functions with
2871         gdbarch.
2872
2873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2874
2875         * m32r-tdep.c (m32r_unwind_sp): Delete.
2876         (m32r_unwind_pc): Delete.
2877         (m32r_dummy_id): Delete.
2878         (m32r_gdbarch_init): Don't register deleted functions with
2879         gdbarch.
2880
2881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2882
2883         * m32c-tdep.c (m32c_unwind_pc): Delete.
2884         (m32c_unwind_sp): Delete.
2885         (m32c_dummy_id): Delete.
2886         (m32c_gdbarch_init): Don't register deleted functions with
2887         gdbarch.
2888
2889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2890
2891         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2892         (lm32_unwind_pc): Delete.
2893         (lm32_dummy_id): Delete.
2894         (lm32_gdbarch_init): Don't register deleted functions with
2895         gdbarch.
2896
2897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2898
2899         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2900         (iq2000_unwind_pc): Delete.
2901         (iq2000_dummy_id): Delete.
2902         (iq2000_gdbarch_init): Don't register deleted functions with
2903         gdbarch.
2904
2905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2906
2907         * nds32-tdep.c (nds32_type_align): Delete.
2908         (nds32_push_dummy_call): Use type_align instead.
2909
2910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2911
2912         * arm-tdep.c (arm_type_align): Only handle vector override case.
2913         (arm_push_dummy_call): Use type_align.
2914         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2915
2916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2917
2918         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2919         case.
2920         (pass_on_stack): Use type_align.
2921         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2922         function.
2923
2924 2019-04-23  Tom Tromey  <tromey@adacore.com>
2925
2926         * dwarf2read.c (line_header::file_name_at): Remove unused
2927         overload.
2928
2929 2019-04-23  Tom de Vries  <tdevries@suse.de>
2930
2931         PR gdb/24438
2932         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2933         invocation.
2934
2935
2936 2019-03-27  Ali Tamur  <tamur@google.com>
2937
2938         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2939         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2940         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2941         (dwarf_expr_context::get_addr_index): Likewise
2942         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2943         (symbol_needs_eval_context::get_addr_index): Likewise
2944         (disassemble_dwarf_expression): Add DW_OP_addrx
2945         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2946         (read_cutu_die_from_dwo): Update comment
2947         (skip_one_die): Add DW_FORM_addrx
2948         (read_attribute_value): Likewise
2949         (var_decode_location): Add DW_OP_addrx
2950         (dwarf2_const_value_attr): Add DW_FORM_addrx
2951         (dump_die_shallow): Likewise
2952         (dwarf2_fetch_constant_bytes): Likewise
2953         (decode_locdesc): Add DW_OP_addrx
2954         (skip_form_bytes): Add DW_FORM_addrx
2955
2956 2019-04-22  Ali Tamur  <tamur@google.com>
2957
2958         * MAINTAINERS (Write After Approval): Add self.
2959
2960 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2961
2962         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2963         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2964         (open_symbol_file_object): Likewise.
2965         (svr4_default_sos): Add info parameter.
2966         (svr4_read_so_list): Likewise.
2967         (svr4_current_sos_direct): Adjust functions calls to pass down
2968         info.
2969         (svr4_current_sos_1): Add info parameter.
2970         (svr4_current_sos): Call get_svr4_info, pass info down to
2971         svr4_current_sos_1.
2972         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2973         get_svr4_info.
2974         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2975         get_svr4_info.
2976         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2977         to get_svr4_info.
2978         (probes_table_remove_objfile_probes): Likewise.
2979         (register_solib_event_probe): Add info parameter.
2980         (solist_update_incremental): Pass info parameter down to
2981         svr4_read_so_list.
2982         (disable_probes_interface): Add info parameter.
2983         (svr4_handle_solib_event): Pass current_program_space to
2984         get_svr4_info.  Adjust disable_probes_interface cleanup.
2985         (svr4_create_probe_breakpoints): Add info parameter, pass it
2986         down to register_solib_event_probe.
2987         (svr4_create_solib_event_breakpoints): Add info parameter,
2988         pass it down to svr4_create_probe_breakpoints.
2989         (enable_break): Pass info down to
2990         svr4_create_solib_event_breakpoints.
2991         (svr4_solib_create_inferior_hook): Pass current_program_space to
2992         get_svr4_info.
2993         (svr4_clear_solib): Likewise.
2994
2995 2019-04-22  Pedro Alves  <palves@redhat.com>
2996
2997         * solib-svr4.c (svr4_free_objfile_observer): New.
2998         (probe_and_action::objfile): New field.
2999         (probes_table_htab_remove_objfile_probes)
3000         (probes_table_remove_objfile_probes): New functions.
3001         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3002         in the new probe_and_action.  Don't store the probe in 'lookup'.
3003         (svr4_create_probe_breakpoints): Pass objfile to
3004         register_solib_event_probe.
3005         (_initialize_svr4_solib): Register a free_objfile observer.
3006
3007 2019-04-19  Tom Tromey  <tom@tromey.com>
3008
3009         * common/queue.h: Remove.
3010
3011 2019-04-19  Tom Tromey  <tom@tromey.com>
3012
3013         * event-loop.c: Don't include "common/queue.h".
3014
3015 2019-04-19  Tom Tromey  <tom@tromey.com>
3016
3017         * remote.c (remote_target): Use delete.
3018         * remote-notif.h: Include <list>, not "common/queue.h".
3019         (notif_client_p): Remove typedef.
3020         (remote_notif_state): Add constructor, destructor, initializer.
3021         <notif_queue>: Now a std::list.
3022         (remote_notif_state_xfree): Don't declare.
3023         * remote-notif.c (remote_notif_process, handle_notification)
3024         (remote_notif_state_allocate): Update.
3025         (~remote_notif_state): Rename from remote_notif_state_xfree.
3026
3027 2019-04-19  Tom Tromey  <tom@tromey.com>
3028
3029         * symfile.c (reread_symbols): Update.
3030         * objfiles.c (objfile_register_static_link)
3031         (objfile_lookup_static_link): Update
3032         (~objfile) Don't delete static_links.
3033         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3034
3035 2019-04-19  Tom Tromey  <tom@tromey.com>
3036
3037         * type-stack.h (struct type_stack) <insert>: Constify string.
3038         * type-stack.c (type_stack::insert): Constify string.
3039         * gdbtypes.h (lookup_template_type): Update.
3040         (address_space_name_to_int): Update.
3041         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3042         const.
3043         (lookup_template_type): Make name const.
3044         * c-exp.y: Update rules.
3045         (lex_one_token, classify_name, classify_inner_name)
3046         (c_print_token): Update.
3047         * p-exp.y: Update rules.
3048         (yylex): Update.
3049         * f-exp.y: Update rules.
3050         (yylex): Update.
3051         * d-exp.y: Update rules.
3052         (lex_one_token, classify_name, classify_inner_name): Update.
3053         * parse.c (write_dollar_variable, copy_name): Return std::string.
3054         * parser-defs.h (copy_name): Change return type.
3055         * m2-exp.y: Update rules.
3056         (yylex): Update.
3057         * go-exp.y (lex_one_token): Update.
3058         Update rules.
3059         (classify_unsafe_function, classify_packaged_name)
3060         (classify_name, yylex): Update.
3061
3062 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3063
3064         * configure.ac: add --enable-source-highlight switch.
3065         * configure: Regenerate.
3066         * top.c (print_gdb_version): plumb --enable-source-highlight
3067         status to "show configuration".
3068
3069 2019-04-19  Tom Tromey  <tromey@adacore.com>
3070
3071         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3072         Check ADA_TYPE_P.
3073         (empty_record, ada_template_to_fixed_record_type_1)
3074         (template_to_static_fixed_type)
3075         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3076         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3077         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3078         macros.
3079
3080 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3081
3082         PR symtab/24423:
3083         * source.c (print_source_lines_base): Advance "iter" when a
3084         control character is seen.
3085
3086 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3087
3088         * inferior.h (struct infcall_suspend_state_deleter):
3089         Catch exception in destructor to avoid crash.
3090
3091 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3092
3093         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3094         close to the add_com "shell".
3095
3096 2019-04-18  Tom Tromey  <tromey@adacore.com>
3097
3098         * process-stratum-target.h (class process_stratum_target)
3099         <stratum>: Add "final".
3100
3101 2019-04-17  Tom Tromey  <tromey@adacore.com>
3102
3103         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3104         against nullptr before use.
3105
3106 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3107
3108         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3109
3110 2019-04-17  Jim Wilson  <jimw@sifive.com>
3111             Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3114         code read might fail, assume 4-byte breakpoint in that case.
3115
3116 2019-04-15  Leszek Swirski  <leszeks@google.com>
3117
3118         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3119         rather than a hand-rolled POD check when checking for forced MEMORY
3120         classification.
3121
3122 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3123
3124         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3125         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3126         function.
3127         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3128         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3129         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3130         declaration.
3131
3132 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3133
3134         * aarch64-linux-nat.c
3135         (aarch64_linux_nat_target::thread_architecture): Add override.
3136         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3137         each VQ.
3138
3139 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3140
3141         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3142
3143 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3146         target types of size 96-bits, add some additional comments, and
3147         check that the builtin type we found was the correct size.
3148
3149 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3150
3151         * utils.c (prompt_for_continue): Don't restore the styling at the
3152         end, as applied_style has the wrong value.  This fixes styling in
3153         long lists of file names that are interrupted by the "Continue?"
3154         prompt.
3155
3156 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3159         * c-lang.c (c_language_defn): Likewise.
3160         (cplus_language_defn): Likewise.
3161         (asm_language_defn): Likewise.
3162         (minimal_language_defn): Likewise.
3163         * d-lang.c (d_language_defn): Likewise.
3164         * f-lang.c (f_language_defn): Likewise.
3165         * go-lang.c (go_language_defn): Likewise.
3166         * language.c (unknown_language_defn): Likewise.
3167         (auto_language_defn): Likewise.
3168         * language.h (struct language_defn): Remove la_magic field.
3169         (LANG_MAGIC): Delete.
3170         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3171         * objc-lang.c (objc_language_defn): Likewise.
3172         * opencl-lang.c (opencl_language_defn): Likewise.
3173         * p-lang.c (pascal_language_defn): Likewise.
3174         * rust-lang.c (rust_language_defn): Likewise.
3175
3176 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * riscv-tdep.c (riscv_type_align): New function.
3179         (riscv_type_alignment): Delete.
3180         (riscv_arg_location): Use 'type_align'.
3181         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3182
3183 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3184
3185         * gdbtypes.c (type_align): A struct with no non-static fields also
3186         has alignment of 1.
3187
3188 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3189
3190         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3191         component to 0.
3192         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3193         member.
3194         (riscv_struct_info::analyse): New implementation using new
3195         analyse_inner member function.
3196         (riscv_struct_info::field_offset): New member function.
3197         (riscv_struct_info::m_offsets): New member variable.
3198         (riscv_struct_info::analyse_inner): New private member function,
3199         takes the old implementation of riscv_struct_info::analyse but
3200         extended to track field offsets.
3201         (riscv_call_arg_struct): Update the struct folding special cases
3202         to handle cases where empty C++ structs, which are non-zero
3203         length, are found.
3204         (riscv_arg_location): Initialise the length of each location, a
3205         non-zero length now indicates the location is in use.
3206         (riscv_push_dummy_call): Allow for the first location having a
3207         non-zero offset when setting up arguments.
3208         (riscv_return_value): Likewise, but for return values.
3209
3210 2019-04-11  Tom Tromey  <tromey@adacore.com>
3211
3212         * utils.c (internal_vproblem): Make "msg" const.
3213
3214 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3215
3216         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3217         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3218         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3219         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3220
3221 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3222
3223         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3224         function.
3225         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3226         of amd64_collect_native_gregset.
3227         (amd64_linux_nat_target::store_registers): Likewise.
3228
3229 2019-04-10  Tom Tromey  <tom@tromey.com>
3230
3231         * symtab.c (lookup_global_symbol_from_objfile)
3232         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3233         * objfiles.h (class separate_debug_iterator): New.
3234         (class separate_debug_range): New.
3235         (struct objfile) <separate_debug_objfiles>: New method.
3236         (objfile_separate_debug_iterate): Don't declare.
3237         * objfiles.c (separate_debug_iterator::operator++): Rename from
3238         objfile_separate_debug_iterate.
3239         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3240         iterator.
3241         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3242         iterator.
3243
3244 2019-04-10  Tom Tromey  <tom@tromey.com>
3245
3246         * symfile.c (reread_symbols): Remove old comment.
3247         * objfiles.c (free_all_objfiles): Fix a typo.
3248
3249 2019-04-10  Tom Tromey  <tom@tromey.com>
3250
3251         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3252         * minsyms.c (lookup_minimal_symbol): Use foreach.
3253         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3254         (lookup_minimal_symbol_solib_trampoline): Likewise.
3255         * symfile.c (reread_symbols): Use foreach.
3256
3257 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3258             Tom Tromey  <tromey@adacore.com>
3259
3260         PR rust/24414:
3261         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3262         (rust_lex_int_test): Change "value" to be LONGEST.
3263         (rust_lex_tests): Add test for long integer literal.
3264
3265 2019-04-09  Tom Tromey  <tromey@adacore.com>
3266
3267         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3268         to bool.
3269         (extended_remote_target::attach): Update.
3270         (remote_target::remote_notice_new_inferior): Update.
3271         (remote_target::add_current_inferior_and_thread): Update.
3272         * inferior.c (exit_inferior_1): Use "false".
3273         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3274
3275 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3276
3277         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3278         the "start" command.
3279
3280 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3281
3282         * python/py-inferior.c (infpy_thread_from_thread_handle):
3283         Adjust comments to reflect renaming of thread_from_thread_handle
3284         to thread_from_handle.  Adjust keywords.  Fix type error message.
3285         (inferior_object_methods): Add thread_from_handle.  Retain
3286         thread_from_thread_handle, but mark it as deprecated.
3287
3288 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3289
3290         * gdbthread.h (find_thread_by_handle): Revise declaration.
3291         * thread.c (find_thread_by_handle): Likewise.  Adjust
3292         implementation too.
3293         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3294         support for buffer objects as handles.
3295
3296 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3297
3298         * python/py-infthread.c (thpy_thread_handle): New function.
3299         (thread_object_methods): Register thpy_thread_handle.
3300
3301 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3302
3303         * gdbthread.h (thread_to_thread_handle): Declare.
3304         * thread.c (gdbtypes.h): Include.
3305         (thread_to_thread_handle): New function.
3306
3307         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3308         (target_thread_info_to_thread_handle): Declare.
3309         * target.c (target_thread_info_to_thread_handle): New function.
3310         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3311         * target-delegates.c: Regenerate.
3312
3313         * linux-thread-db.c (class thread_db_target): Add method
3314         thread_info_to_thread_handle.
3315         (thread_db_target::thread_info_to_thread_handle): Define.
3316         * remote.c (class remote_target): Add new method
3317         thread_info_to_thread_handle.
3318         (remote_target::thread_info_to_thread_handle): Define.
3319
3320 2019-04-08  Pedro Alves  <palves@redhat.com>
3321
3322         * common/common-exceptions.c (throw_exception): Don't create
3323         named object to throw; throw directly.
3324         (throw_it): Likewise.  Don't initialize gdb_exception::message
3325         here, with new; pass FMT and AP to the ctor instead.
3326         * common/common-exceptions.h: Include <string>.
3327         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3328         const char *, va_list)): New ctor.  Use std::make_shared.
3329         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3330         errors)): Delete.
3331         (gdb_exception_error::gdb_exception_error(enum errors, const char
3332         *, va_list)): New.
3333         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3334         Add assertion.
3335         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3336         errors)): Delete.
3337         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3338         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3339         Add assertion.
3340
3341 2019-04-08  Tom Tromey  <tom@tromey.com>
3342
3343         * valops.c (value_rtti_indirect_type): Replace throw_exception
3344         with throw.
3345         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3346         with throw.
3347         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3348         throw.
3349         * target.c (target_translate_tls_address): Replace throw_exception
3350         with throw.
3351         * stack.c (frame_apply_command_count): Replace throw_exception
3352         with throw.
3353         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3354         throw.
3355         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3356         with throw.
3357         * rs6000-tdep.c (rs6000_frame_cache)
3358         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3359         * remote.c: Replace throw_exception with throw.
3360         * record-full.c (record_full_message, record_full_wait_1)
3361         (record_full_restore): Replace throw_exception with throw.
3362         * record-btrace.c:
3363         (get_thread_current_frame_id, record_btrace_start_replaying)
3364         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3365         (cmd_record_btrace_start): Replace throw_exception with throw.
3366         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3367         throw.
3368         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3369         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3370         * linespec.c:
3371         (find_linespec_symbols): Replace throw_exception with throw.
3372         * infrun.c (displaced_step_prepare, resume): Replace
3373         throw_exception with throw.
3374         * infcmd.c (post_create_inferior): Replace throw_exception with
3375         throw.
3376         * inf-loop.c (inferior_event_handler): Replace throw_exception
3377         with throw.
3378         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3379         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3380         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3381         (get_prev_frame_always, get_frame_pc_if_available)
3382         (get_frame_address_in_block_if_available, get_frame_language):
3383         Replace throw_exception with throw.
3384         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3385         throw_exception with throw.
3386         * eval.c (fetch_subexp_value, evaluate_var_value)
3387         (evaluate_funcall, evaluate_subexp_standard): Replace
3388         throw_exception with throw.
3389         * dwarf2loc.c (call_site_find_chain)
3390         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3391         Replace throw_exception with throw.
3392         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3393         with throw.
3394         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3395         throw.
3396         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3397         * completer.c (complete_line_internal): Replace throw_exception
3398         with throw.
3399         * compile/compile-object-run.c (compile_object_run): Replace
3400         throw_exception with throw.
3401         * cli/cli-script.c (process_next_line): Replace throw_exception
3402         with throw.
3403         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3404         (btrace_enable, btrace_maint_update_pt_packets): Replace
3405         throw_exception with throw.
3406         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3407         throw_exception with throw.
3408         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3409         throw_exception with throw.
3410         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3411         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3412         * aarch64-tdep.c (aarch64_make_prologue_cache)
3413         (aarch64_make_stub_cache): Replace throw_exception with throw.
3414
3415 2019-04-08  Tom Tromey  <tom@tromey.com>
3416
3417         * common/common-exceptions.c (throw_exception): Rename from
3418         throw_exception_cxx.  Remove old copy.  Make argument const.
3419         (throw_it): Create and throw exception objects directly.
3420         * common/common-exceptions.h (throw_exception): Make argument
3421         const.
3422         (struct gdb_exception_error): Add constructor.
3423         (struct gdb_exception_quit): Add constructor.
3424
3425 2019-04-08  Tom Tromey  <tom@tromey.com>
3426
3427         * common/common-exceptions.h (exception_rethrow): Don't declare.
3428         (TRY_SJLJ): Update comment.
3429         (TRY, CATCH, END_CATCH): Remove.
3430         * common/common-exceptions.c (exception_rethrow): Remove.
3431
3432 2019-04-08  Tom Tromey  <tom@tromey.com>
3433
3434         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3435         Remove.
3436         (gdb_exception_error): Rename from
3437         gdb_exception_RETURN_MASK_ERROR.
3438         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3439         (gdb_quit_bad_alloc): Update.
3440         * aarch64-tdep.c: Update.
3441         * ada-lang.c: Update.
3442         * ada-typeprint.c: Update.
3443         * ada-valprint.c: Update.
3444         * amd64-tdep.c: Update.
3445         * arch-utils.c: Update.
3446         * break-catch-throw.c: Update.
3447         * breakpoint.c: Update.
3448         * btrace.c: Update.
3449         * c-varobj.c: Update.
3450         * cli/cli-cmds.c: Update.
3451         * cli/cli-interp.c: Update.
3452         * cli/cli-script.c: Update.
3453         * common/common-exceptions.c: Update.
3454         * common/new-op.c: Update.
3455         * common/selftest.c: Update.
3456         * compile/compile-c-symbols.c: Update.
3457         * compile/compile-cplus-symbols.c: Update.
3458         * compile/compile-object-load.c: Update.
3459         * compile/compile-object-run.c: Update.
3460         * completer.c: Update.
3461         * corelow.c: Update.
3462         * cp-abi.c: Update.
3463         * cp-support.c: Update.
3464         * cp-valprint.c: Update.
3465         * darwin-nat.c: Update.
3466         * disasm-selftests.c: Update.
3467         * dtrace-probe.c: Update.
3468         * dwarf-index-cache.c: Update.
3469         * dwarf-index-write.c: Update.
3470         * dwarf2-frame-tailcall.c: Update.
3471         * dwarf2-frame.c: Update.
3472         * dwarf2loc.c: Update.
3473         * dwarf2read.c: Update.
3474         * eval.c: Update.
3475         * event-loop.c: Update.
3476         * event-top.c: Update.
3477         * exec.c: Update.
3478         * f-valprint.c: Update.
3479         * fbsd-tdep.c: Update.
3480         * frame-unwind.c: Update.
3481         * frame.c: Update.
3482         * gdbtypes.c: Update.
3483         * gnu-v3-abi.c: Update.
3484         * guile/guile-internal.h: Update.
3485         * guile/scm-block.c: Update.
3486         * guile/scm-breakpoint.c: Update.
3487         * guile/scm-cmd.c: Update.
3488         * guile/scm-disasm.c: Update.
3489         * guile/scm-frame.c: Update.
3490         * guile/scm-lazy-string.c: Update.
3491         * guile/scm-math.c: Update.
3492         * guile/scm-param.c: Update.
3493         * guile/scm-ports.c: Update.
3494         * guile/scm-pretty-print.c: Update.
3495         * guile/scm-symbol.c: Update.
3496         * guile/scm-symtab.c: Update.
3497         * guile/scm-type.c: Update.
3498         * guile/scm-value.c: Update.
3499         * i386-linux-tdep.c: Update.
3500         * i386-tdep.c: Update.
3501         * inf-loop.c: Update.
3502         * infcall.c: Update.
3503         * infcmd.c: Update.
3504         * infrun.c: Update.
3505         * jit.c: Update.
3506         * language.c: Update.
3507         * linespec.c: Update.
3508         * linux-fork.c: Update.
3509         * linux-nat.c: Update.
3510         * linux-tdep.c: Update.
3511         * linux-thread-db.c: Update.
3512         * main.c: Update.
3513         * mi/mi-cmd-break.c: Update.
3514         * mi/mi-cmd-stack.c: Update.
3515         * mi/mi-interp.c: Update.
3516         * mi/mi-main.c: Update.
3517         * objc-lang.c: Update.
3518         * p-valprint.c: Update.
3519         * parse.c: Update.
3520         * ppc-linux-tdep.c: Update.
3521         * printcmd.c: Update.
3522         * python/py-arch.c: Update.
3523         * python/py-breakpoint.c: Update.
3524         * python/py-cmd.c: Update.
3525         * python/py-finishbreakpoint.c: Update.
3526         * python/py-frame.c: Update.
3527         * python/py-framefilter.c: Update.
3528         * python/py-gdb-readline.c: Update.
3529         * python/py-inferior.c: Update.
3530         * python/py-infthread.c: Update.
3531         * python/py-lazy-string.c: Update.
3532         * python/py-linetable.c: Update.
3533         * python/py-objfile.c: Update.
3534         * python/py-param.c: Update.
3535         * python/py-prettyprint.c: Update.
3536         * python/py-progspace.c: Update.
3537         * python/py-record-btrace.c: Update.
3538         * python/py-record.c: Update.
3539         * python/py-symbol.c: Update.
3540         * python/py-type.c: Update.
3541         * python/py-unwind.c: Update.
3542         * python/py-utils.c: Update.
3543         * python/py-value.c: Update.
3544         * python/python.c: Update.
3545         * record-btrace.c: Update.
3546         * record-full.c: Update.
3547         * remote-fileio.c: Update.
3548         * remote.c: Update.
3549         * riscv-tdep.c: Update.
3550         * rs6000-aix-tdep.c: Update.
3551         * rs6000-tdep.c: Update.
3552         * rust-exp.y: Update.
3553         * rust-lang.c: Update.
3554         * s390-tdep.c: Update.
3555         * selftest-arch.c: Update.
3556         * solib-dsbt.c: Update.
3557         * solib-frv.c: Update.
3558         * solib-spu.c: Update.
3559         * solib-svr4.c: Update.
3560         * solib.c: Update.
3561         * sparc64-linux-tdep.c: Update.
3562         * stack.c: Update.
3563         * symfile-mem.c: Update.
3564         * symmisc.c: Update.
3565         * target.c: Update.
3566         * thread.c: Update.
3567         * top.c: Update.
3568         * tracefile-tfile.c: Update.
3569         * tui/tui.c: Update.
3570         * typeprint.c: Update.
3571         * unittests/cli-utils-selftests.c: Update.
3572         * unittests/parse-connection-spec-selftests.c: Update.
3573         * valops.c: Update.
3574         * valprint.c: Update.
3575         * value.c: Update.
3576         * varobj.c: Update.
3577         * windows-nat.c: Update.
3578         * x86-linux-nat.c: Update.
3579         * xml-support.c: Update.
3580
3581 2019-04-08  Tom Tromey  <tom@tromey.com>
3582
3583         * xml-support.c: Use C++ exception handling.
3584         * x86-linux-nat.c: Use C++ exception handling.
3585         * windows-nat.c: Use C++ exception handling.
3586         * varobj.c: Use C++ exception handling.
3587         * value.c: Use C++ exception handling.
3588         * valprint.c: Use C++ exception handling.
3589         * valops.c: Use C++ exception handling.
3590         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3591         handling.
3592         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3593         * typeprint.c: Use C++ exception handling.
3594         * tui/tui.c: Use C++ exception handling.
3595         * tracefile-tfile.c: Use C++ exception handling.
3596         * top.c: Use C++ exception handling.
3597         * thread.c: Use C++ exception handling.
3598         * target.c: Use C++ exception handling.
3599         * symmisc.c: Use C++ exception handling.
3600         * symfile-mem.c: Use C++ exception handling.
3601         * stack.c: Use C++ exception handling.
3602         * sparc64-linux-tdep.c: Use C++ exception handling.
3603         * solib.c: Use C++ exception handling.
3604         * solib-svr4.c: Use C++ exception handling.
3605         * solib-spu.c: Use C++ exception handling.
3606         * solib-frv.c: Use C++ exception handling.
3607         * solib-dsbt.c: Use C++ exception handling.
3608         * selftest-arch.c: Use C++ exception handling.
3609         * s390-tdep.c: Use C++ exception handling.
3610         * rust-lang.c: Use C++ exception handling.
3611         * rust-exp.y: Use C++ exception handling.
3612         * rs6000-tdep.c: Use C++ exception handling.
3613         * rs6000-aix-tdep.c: Use C++ exception handling.
3614         * riscv-tdep.c: Use C++ exception handling.
3615         * remote.c: Use C++ exception handling.
3616         * remote-fileio.c: Use C++ exception handling.
3617         * record-full.c: Use C++ exception handling.
3618         * record-btrace.c: Use C++ exception handling.
3619         * python/python.c: Use C++ exception handling.
3620         * python/py-value.c: Use C++ exception handling.
3621         * python/py-utils.c: Use C++ exception handling.
3622         * python/py-unwind.c: Use C++ exception handling.
3623         * python/py-type.c: Use C++ exception handling.
3624         * python/py-symbol.c: Use C++ exception handling.
3625         * python/py-record.c: Use C++ exception handling.
3626         * python/py-record-btrace.c: Use C++ exception handling.
3627         * python/py-progspace.c: Use C++ exception handling.
3628         * python/py-prettyprint.c: Use C++ exception handling.
3629         * python/py-param.c: Use C++ exception handling.
3630         * python/py-objfile.c: Use C++ exception handling.
3631         * python/py-linetable.c: Use C++ exception handling.
3632         * python/py-lazy-string.c: Use C++ exception handling.
3633         * python/py-infthread.c: Use C++ exception handling.
3634         * python/py-inferior.c: Use C++ exception handling.
3635         * python/py-gdb-readline.c: Use C++ exception handling.
3636         * python/py-framefilter.c: Use C++ exception handling.
3637         * python/py-frame.c: Use C++ exception handling.
3638         * python/py-finishbreakpoint.c: Use C++ exception handling.
3639         * python/py-cmd.c: Use C++ exception handling.
3640         * python/py-breakpoint.c: Use C++ exception handling.
3641         * python/py-arch.c: Use C++ exception handling.
3642         * printcmd.c: Use C++ exception handling.
3643         * ppc-linux-tdep.c: Use C++ exception handling.
3644         * parse.c: Use C++ exception handling.
3645         * p-valprint.c: Use C++ exception handling.
3646         * objc-lang.c: Use C++ exception handling.
3647         * mi/mi-main.c: Use C++ exception handling.
3648         * mi/mi-interp.c: Use C++ exception handling.
3649         * mi/mi-cmd-stack.c: Use C++ exception handling.
3650         * mi/mi-cmd-break.c: Use C++ exception handling.
3651         * main.c: Use C++ exception handling.
3652         * linux-thread-db.c: Use C++ exception handling.
3653         * linux-tdep.c: Use C++ exception handling.
3654         * linux-nat.c: Use C++ exception handling.
3655         * linux-fork.c: Use C++ exception handling.
3656         * linespec.c: Use C++ exception handling.
3657         * language.c: Use C++ exception handling.
3658         * jit.c: Use C++ exception handling.
3659         * infrun.c: Use C++ exception handling.
3660         * infcmd.c: Use C++ exception handling.
3661         * infcall.c: Use C++ exception handling.
3662         * inf-loop.c: Use C++ exception handling.
3663         * i386-tdep.c: Use C++ exception handling.
3664         * i386-linux-tdep.c: Use C++ exception handling.
3665         * guile/scm-value.c: Use C++ exception handling.
3666         * guile/scm-type.c: Use C++ exception handling.
3667         * guile/scm-symtab.c: Use C++ exception handling.
3668         * guile/scm-symbol.c: Use C++ exception handling.
3669         * guile/scm-pretty-print.c: Use C++ exception handling.
3670         * guile/scm-ports.c: Use C++ exception handling.
3671         * guile/scm-param.c: Use C++ exception handling.
3672         * guile/scm-math.c: Use C++ exception handling.
3673         * guile/scm-lazy-string.c: Use C++ exception handling.
3674         * guile/scm-frame.c: Use C++ exception handling.
3675         * guile/scm-disasm.c: Use C++ exception handling.
3676         * guile/scm-cmd.c: Use C++ exception handling.
3677         * guile/scm-breakpoint.c: Use C++ exception handling.
3678         * guile/scm-block.c: Use C++ exception handling.
3679         * guile/guile-internal.h: Use C++ exception handling.
3680         * gnu-v3-abi.c: Use C++ exception handling.
3681         * gdbtypes.c: Use C++ exception handling.
3682         * frame.c: Use C++ exception handling.
3683         * frame-unwind.c: Use C++ exception handling.
3684         * fbsd-tdep.c: Use C++ exception handling.
3685         * f-valprint.c: Use C++ exception handling.
3686         * exec.c: Use C++ exception handling.
3687         * event-top.c: Use C++ exception handling.
3688         * event-loop.c: Use C++ exception handling.
3689         * eval.c: Use C++ exception handling.
3690         * dwarf2read.c: Use C++ exception handling.
3691         * dwarf2loc.c: Use C++ exception handling.
3692         * dwarf2-frame.c: Use C++ exception handling.
3693         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3694         * dwarf-index-write.c: Use C++ exception handling.
3695         * dwarf-index-cache.c: Use C++ exception handling.
3696         * dtrace-probe.c: Use C++ exception handling.
3697         * disasm-selftests.c: Use C++ exception handling.
3698         * darwin-nat.c: Use C++ exception handling.
3699         * cp-valprint.c: Use C++ exception handling.
3700         * cp-support.c: Use C++ exception handling.
3701         * cp-abi.c: Use C++ exception handling.
3702         * corelow.c: Use C++ exception handling.
3703         * completer.c: Use C++ exception handling.
3704         * compile/compile-object-run.c: Use C++ exception handling.
3705         * compile/compile-object-load.c: Use C++ exception handling.
3706         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3707         * compile/compile-c-symbols.c: Use C++ exception handling.
3708         * common/selftest.c: Use C++ exception handling.
3709         * common/new-op.c: Use C++ exception handling.
3710         * cli/cli-script.c: Use C++ exception handling.
3711         * cli/cli-interp.c: Use C++ exception handling.
3712         * cli/cli-cmds.c: Use C++ exception handling.
3713         * c-varobj.c: Use C++ exception handling.
3714         * btrace.c: Use C++ exception handling.
3715         * breakpoint.c: Use C++ exception handling.
3716         * break-catch-throw.c: Use C++ exception handling.
3717         * arch-utils.c: Use C++ exception handling.
3718         * amd64-tdep.c: Use C++ exception handling.
3719         * ada-valprint.c: Use C++ exception handling.
3720         * ada-typeprint.c: Use C++ exception handling.
3721         * ada-lang.c: Use C++ exception handling.
3722         * aarch64-tdep.c: Use C++ exception handling.
3723
3724 2019-04-08  Tom Tromey  <tom@tromey.com>
3725
3726         * xml-support.c (gdb_xml_parser::parse): Update.
3727         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3728         * value.c (show_convenience): Update.
3729         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3730         (test_parse_flags_qcs): Update.
3731         * thread.c (thr_try_catch_cmd): Update.
3732         * target.c (target_translate_tls_address): Update.
3733         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3734         (info_frame_command_core, frame_apply_command_count): Update.
3735         * rust-exp.y (rust_lex_exception_test): Update.
3736         * riscv-tdep.c (riscv_print_one_register_info): Update.
3737         * remote.c (remote_target::enable_btrace): Update.
3738         * record-btrace.c (record_btrace_enable_warn): Update.
3739         * python/py-utils.c (gdbpy_convert_exception): Update.
3740         * printcmd.c (do_one_display, print_variable_and_value): Update.
3741         * mi/mi-main.c (mi_print_exception): Update.
3742         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3743         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3744         * linux-nat.c (linux_nat_target::attach): Update.
3745         * linux-fork.c (class scoped_switch_fork_info): Update.
3746         * infrun.c (displaced_step_prepare): Update.
3747         * infcall.c (call_function_by_hand_dummy): Update.
3748         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3749         * gnu-v3-abi.c (print_one_vtable): Update.
3750         * frame.c (get_prev_frame_always): Update.
3751         * f-valprint.c (info_common_command_for_block): Update.
3752         * exec.c (try_open_exec_file): Update.
3753         * exceptions.c (print_exception, exception_print)
3754         (exception_fprintf, exception_print_same): Update.
3755         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3756         * dwarf-index-cache.c (index_cache::store)
3757         (index_cache::lookup_gdb_index): Update.
3758         * darwin-nat.c (maybe_cache_shell): Update.
3759         * cp-valprint.c (cp_print_value_fields): Update.
3760         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3761         (gcc_cplus_symbol_address): Update.
3762         * compile/compile-c-symbols.c (gcc_convert_symbol)
3763         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3764         * common/selftest.c: Update.
3765         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3766         a std::string.
3767         (exception_try_scope_entry, exception_try_scope_exit): Don't
3768         declare.
3769         (struct exception_try_scope): Remove.
3770         (TRY): Don't use exception_try_scope.
3771         (struct gdb_exception): Add constructor, operator=.
3772         <what>: New method.
3773         (struct gdb_exception_RETURN_MASK_ALL)
3774         (struct gdb_exception_RETURN_MASK_ERROR)
3775         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3776         (struct gdb_quit_bad_alloc): Update.
3777         * common/common-exceptions.c (exception_none): Change
3778         initializer.
3779         (struct catcher) <state, exception>: Initialize inline.
3780         <prev>: Remove member.
3781         (current_catcher): Remove.
3782         (catchers): New global.
3783         (exceptions_state_mc_init): Simplify.
3784         (catcher_pop): Remove.
3785         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3786         (try_scope_depth, exception_try_scope_entry)
3787         (exception_try_scope_exit): Remove.
3788         (throw_exception_sjlj): Update.
3789         (exception_messages, exception_messages_size): Remove.
3790         (throw_it): Simplify.
3791         (gdb_exception_sliced_copy): Remove.
3792         (throw_exception_cxx): Update.
3793         * cli/cli-script.c (script_from_file): Update.
3794         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3795         Update.
3796         * ada-valprint.c (ada_val_print): Update.
3797         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3798         (create_excep_cond_exprs): Update.
3799
3800 2019-04-08  Tom Tromey  <tom@tromey.com>
3801
3802         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3803         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3804         (TRY, CATCH, END_CATCH): Remove some definitions.
3805         * common/common-exceptions.c: Don't use GDB_XCPT.
3806         (catcher_list_size): Remove.
3807         (throw_exception, throw_it): Simplify.
3808
3809 2019-04-05  Tom Tromey  <tom@tromey.com>
3810
3811         Revert the header-sorting patch.
3812         * ft32-tdep.c: Revert.
3813         * frv-tdep.c: Revert.
3814         * frv-linux-tdep.c: Revert.
3815         * frame.c: Revert.
3816         * frame-unwind.c: Revert.
3817         * frame-base.c: Revert.
3818         * fork-child.c: Revert.
3819         * findvar.c: Revert.
3820         * findcmd.c: Revert.
3821         * filesystem.c: Revert.
3822         * filename-seen-cache.h: Revert.
3823         * filename-seen-cache.c: Revert.
3824         * fbsd-tdep.c: Revert.
3825         * fbsd-nat.h: Revert.
3826         * fbsd-nat.c: Revert.
3827         * f-valprint.c: Revert.
3828         * f-typeprint.c: Revert.
3829         * f-lang.c: Revert.
3830         * extension.h: Revert.
3831         * extension.c: Revert.
3832         * extension-priv.h: Revert.
3833         * expprint.c: Revert.
3834         * exec.h: Revert.
3835         * exec.c: Revert.
3836         * exceptions.c: Revert.
3837         * event-top.c: Revert.
3838         * event-loop.c: Revert.
3839         * eval.c: Revert.
3840         * elfread.c: Revert.
3841         * dwarf2read.h: Revert.
3842         * dwarf2read.c: Revert.
3843         * dwarf2loc.c: Revert.
3844         * dwarf2expr.h: Revert.
3845         * dwarf2expr.c: Revert.
3846         * dwarf2-frame.c: Revert.
3847         * dwarf2-frame-tailcall.c: Revert.
3848         * dwarf-index-write.h: Revert.
3849         * dwarf-index-write.c: Revert.
3850         * dwarf-index-common.c: Revert.
3851         * dwarf-index-cache.h: Revert.
3852         * dwarf-index-cache.c: Revert.
3853         * dummy-frame.c: Revert.
3854         * dtrace-probe.c: Revert.
3855         * disasm.h: Revert.
3856         * disasm.c: Revert.
3857         * disasm-selftests.c: Revert.
3858         * dictionary.c: Revert.
3859         * dicos-tdep.c: Revert.
3860         * demangle.c: Revert.
3861         * dcache.h: Revert.
3862         * dcache.c: Revert.
3863         * darwin-nat.h: Revert.
3864         * darwin-nat.c: Revert.
3865         * darwin-nat-info.c: Revert.
3866         * d-valprint.c: Revert.
3867         * d-namespace.c: Revert.
3868         * d-lang.c: Revert.
3869         * ctf.c: Revert.
3870         * csky-tdep.c: Revert.
3871         * csky-linux-tdep.c: Revert.
3872         * cris-tdep.c: Revert.
3873         * cris-linux-tdep.c: Revert.
3874         * cp-valprint.c: Revert.
3875         * cp-support.c: Revert.
3876         * cp-namespace.c: Revert.
3877         * cp-abi.c: Revert.
3878         * corelow.c: Revert.
3879         * corefile.c: Revert.
3880         * continuations.c: Revert.
3881         * completer.h: Revert.
3882         * completer.c: Revert.
3883         * complaints.c: Revert.
3884         * coffread.c: Revert.
3885         * coff-pe-read.c: Revert.
3886         * cli-out.h: Revert.
3887         * cli-out.c: Revert.
3888         * charset.c: Revert.
3889         * c-varobj.c: Revert.
3890         * c-valprint.c: Revert.
3891         * c-typeprint.c: Revert.
3892         * c-lang.c: Revert.
3893         * buildsym.c: Revert.
3894         * buildsym-legacy.c: Revert.
3895         * build-id.h: Revert.
3896         * build-id.c: Revert.
3897         * btrace.c: Revert.
3898         * bsd-uthread.c: Revert.
3899         * breakpoint.h: Revert.
3900         * breakpoint.c: Revert.
3901         * break-catch-throw.c: Revert.
3902         * break-catch-syscall.c: Revert.
3903         * break-catch-sig.c: Revert.
3904         * blockframe.c: Revert.
3905         * block.c: Revert.
3906         * bfin-tdep.c: Revert.
3907         * bfin-linux-tdep.c: Revert.
3908         * bfd-target.c: Revert.
3909         * bcache.c: Revert.
3910         * ax-general.c: Revert.
3911         * ax-gdb.h: Revert.
3912         * ax-gdb.c: Revert.
3913         * avr-tdep.c: Revert.
3914         * auxv.c: Revert.
3915         * auto-load.c: Revert.
3916         * arm-wince-tdep.c: Revert.
3917         * arm-tdep.c: Revert.
3918         * arm-symbian-tdep.c: Revert.
3919         * arm-pikeos-tdep.c: Revert.
3920         * arm-obsd-tdep.c: Revert.
3921         * arm-nbsd-tdep.c: Revert.
3922         * arm-nbsd-nat.c: Revert.
3923         * arm-linux-tdep.c: Revert.
3924         * arm-linux-nat.c: Revert.
3925         * arm-fbsd-tdep.c: Revert.
3926         * arm-fbsd-nat.c: Revert.
3927         * arm-bsd-tdep.c: Revert.
3928         * arch-utils.c: Revert.
3929         * arc-tdep.c: Revert.
3930         * arc-newlib-tdep.c: Revert.
3931         * annotate.h: Revert.
3932         * annotate.c: Revert.
3933         * amd64-windows-tdep.c: Revert.
3934         * amd64-windows-nat.c: Revert.
3935         * amd64-tdep.c: Revert.
3936         * amd64-sol2-tdep.c: Revert.
3937         * amd64-obsd-tdep.c: Revert.
3938         * amd64-obsd-nat.c: Revert.
3939         * amd64-nbsd-tdep.c: Revert.
3940         * amd64-nbsd-nat.c: Revert.
3941         * amd64-nat.c: Revert.
3942         * amd64-linux-tdep.c: Revert.
3943         * amd64-linux-nat.c: Revert.
3944         * amd64-fbsd-tdep.c: Revert.
3945         * amd64-fbsd-nat.c: Revert.
3946         * amd64-dicos-tdep.c: Revert.
3947         * amd64-darwin-tdep.c: Revert.
3948         * amd64-bsd-nat.c: Revert.
3949         * alpha-tdep.c: Revert.
3950         * alpha-obsd-tdep.c: Revert.
3951         * alpha-nbsd-tdep.c: Revert.
3952         * alpha-mdebug-tdep.c: Revert.
3953         * alpha-linux-tdep.c: Revert.
3954         * alpha-linux-nat.c: Revert.
3955         * alpha-bsd-tdep.c: Revert.
3956         * alpha-bsd-nat.c: Revert.
3957         * aix-thread.c: Revert.
3958         * agent.c: Revert.
3959         * addrmap.c: Revert.
3960         * ada-varobj.c: Revert.
3961         * ada-valprint.c: Revert.
3962         * ada-typeprint.c: Revert.
3963         * ada-tasks.c: Revert.
3964         * ada-lang.c: Revert.
3965         * aarch64-tdep.c: Revert.
3966         * aarch64-ravenscar-thread.c: Revert.
3967         * aarch64-newlib-tdep.c: Revert.
3968         * aarch64-linux-tdep.c: Revert.
3969         * aarch64-linux-nat.c: Revert.
3970         * aarch64-fbsd-tdep.c: Revert.
3971         * aarch64-fbsd-nat.c: Revert.
3972         * aarch32-linux-nat.c: Revert.
3973
3974 2019-04-05  Tom Tromey  <tom@tromey.com>
3975
3976         * ft32-tdep.c: Sort headers.
3977         * frv-tdep.c: Sort headers.
3978         * frv-linux-tdep.c: Sort headers.
3979         * frame.c: Sort headers.
3980         * frame-unwind.c: Sort headers.
3981         * frame-base.c: Sort headers.
3982         * fork-child.c: Sort headers.
3983         * findvar.c: Sort headers.
3984         * findcmd.c: Sort headers.
3985         * filesystem.c: Sort headers.
3986         * filename-seen-cache.h: Sort headers.
3987         * filename-seen-cache.c: Sort headers.
3988         * fbsd-tdep.c: Sort headers.
3989         * fbsd-nat.h: Sort headers.
3990         * fbsd-nat.c: Sort headers.
3991         * f-valprint.c: Sort headers.
3992         * f-typeprint.c: Sort headers.
3993         * f-lang.c: Sort headers.
3994         * extension.h: Sort headers.
3995         * extension.c: Sort headers.
3996         * extension-priv.h: Sort headers.
3997         * expprint.c: Sort headers.
3998         * exec.h: Sort headers.
3999         * exec.c: Sort headers.
4000         * exceptions.c: Sort headers.
4001         * event-top.c: Sort headers.
4002         * event-loop.c: Sort headers.
4003         * eval.c: Sort headers.
4004         * elfread.c: Sort headers.
4005         * dwarf2read.h: Sort headers.
4006         * dwarf2read.c: Sort headers.
4007         * dwarf2loc.c: Sort headers.
4008         * dwarf2expr.h: Sort headers.
4009         * dwarf2expr.c: Sort headers.
4010         * dwarf2-frame.c: Sort headers.
4011         * dwarf2-frame-tailcall.c: Sort headers.
4012         * dwarf-index-write.h: Sort headers.
4013         * dwarf-index-write.c: Sort headers.
4014         * dwarf-index-common.c: Sort headers.
4015         * dwarf-index-cache.h: Sort headers.
4016         * dwarf-index-cache.c: Sort headers.
4017         * dummy-frame.c: Sort headers.
4018         * dtrace-probe.c: Sort headers.
4019         * disasm.h: Sort headers.
4020         * disasm.c: Sort headers.
4021         * disasm-selftests.c: Sort headers.
4022         * dictionary.c: Sort headers.
4023         * dicos-tdep.c: Sort headers.
4024         * demangle.c: Sort headers.
4025         * dcache.h: Sort headers.
4026         * dcache.c: Sort headers.
4027         * darwin-nat.h: Sort headers.
4028         * darwin-nat.c: Sort headers.
4029         * darwin-nat-info.c: Sort headers.
4030         * d-valprint.c: Sort headers.
4031         * d-namespace.c: Sort headers.
4032         * d-lang.c: Sort headers.
4033         * ctf.c: Sort headers.
4034         * csky-tdep.c: Sort headers.
4035         * csky-linux-tdep.c: Sort headers.
4036         * cris-tdep.c: Sort headers.
4037         * cris-linux-tdep.c: Sort headers.
4038         * cp-valprint.c: Sort headers.
4039         * cp-support.c: Sort headers.
4040         * cp-namespace.c: Sort headers.
4041         * cp-abi.c: Sort headers.
4042         * corelow.c: Sort headers.
4043         * corefile.c: Sort headers.
4044         * continuations.c: Sort headers.
4045         * completer.h: Sort headers.
4046         * completer.c: Sort headers.
4047         * complaints.c: Sort headers.
4048         * coffread.c: Sort headers.
4049         * coff-pe-read.c: Sort headers.
4050         * cli-out.h: Sort headers.
4051         * cli-out.c: Sort headers.
4052         * charset.c: Sort headers.
4053         * c-varobj.c: Sort headers.
4054         * c-valprint.c: Sort headers.
4055         * c-typeprint.c: Sort headers.
4056         * c-lang.c: Sort headers.
4057         * buildsym.c: Sort headers.
4058         * buildsym-legacy.c: Sort headers.
4059         * build-id.h: Sort headers.
4060         * build-id.c: Sort headers.
4061         * btrace.c: Sort headers.
4062         * bsd-uthread.c: Sort headers.
4063         * breakpoint.h: Sort headers.
4064         * breakpoint.c: Sort headers.
4065         * break-catch-throw.c: Sort headers.
4066         * break-catch-syscall.c: Sort headers.
4067         * break-catch-sig.c: Sort headers.
4068         * blockframe.c: Sort headers.
4069         * block.c: Sort headers.
4070         * bfin-tdep.c: Sort headers.
4071         * bfin-linux-tdep.c: Sort headers.
4072         * bfd-target.c: Sort headers.
4073         * bcache.c: Sort headers.
4074         * ax-general.c: Sort headers.
4075         * ax-gdb.h: Sort headers.
4076         * ax-gdb.c: Sort headers.
4077         * avr-tdep.c: Sort headers.
4078         * auxv.c: Sort headers.
4079         * auto-load.c: Sort headers.
4080         * arm-wince-tdep.c: Sort headers.
4081         * arm-tdep.c: Sort headers.
4082         * arm-symbian-tdep.c: Sort headers.
4083         * arm-pikeos-tdep.c: Sort headers.
4084         * arm-obsd-tdep.c: Sort headers.
4085         * arm-nbsd-tdep.c: Sort headers.
4086         * arm-nbsd-nat.c: Sort headers.
4087         * arm-linux-tdep.c: Sort headers.
4088         * arm-linux-nat.c: Sort headers.
4089         * arm-fbsd-tdep.c: Sort headers.
4090         * arm-fbsd-nat.c: Sort headers.
4091         * arm-bsd-tdep.c: Sort headers.
4092         * arch-utils.c: Sort headers.
4093         * arc-tdep.c: Sort headers.
4094         * arc-newlib-tdep.c: Sort headers.
4095         * annotate.h: Sort headers.
4096         * annotate.c: Sort headers.
4097         * amd64-windows-tdep.c: Sort headers.
4098         * amd64-windows-nat.c: Sort headers.
4099         * amd64-tdep.c: Sort headers.
4100         * amd64-sol2-tdep.c: Sort headers.
4101         * amd64-obsd-tdep.c: Sort headers.
4102         * amd64-obsd-nat.c: Sort headers.
4103         * amd64-nbsd-tdep.c: Sort headers.
4104         * amd64-nbsd-nat.c: Sort headers.
4105         * amd64-nat.c: Sort headers.
4106         * amd64-linux-tdep.c: Sort headers.
4107         * amd64-linux-nat.c: Sort headers.
4108         * amd64-fbsd-tdep.c: Sort headers.
4109         * amd64-fbsd-nat.c: Sort headers.
4110         * amd64-dicos-tdep.c: Sort headers.
4111         * amd64-darwin-tdep.c: Sort headers.
4112         * amd64-bsd-nat.c: Sort headers.
4113         * alpha-tdep.c: Sort headers.
4114         * alpha-obsd-tdep.c: Sort headers.
4115         * alpha-nbsd-tdep.c: Sort headers.
4116         * alpha-mdebug-tdep.c: Sort headers.
4117         * alpha-linux-tdep.c: Sort headers.
4118         * alpha-linux-nat.c: Sort headers.
4119         * alpha-bsd-tdep.c: Sort headers.
4120         * alpha-bsd-nat.c: Sort headers.
4121         * aix-thread.c: Sort headers.
4122         * agent.c: Sort headers.
4123         * addrmap.c: Sort headers.
4124         * ada-varobj.c: Sort headers.
4125         * ada-valprint.c: Sort headers.
4126         * ada-typeprint.c: Sort headers.
4127         * ada-tasks.c: Sort headers.
4128         * ada-lang.c: Sort headers.
4129         * aarch64-tdep.c: Sort headers.
4130         * aarch64-ravenscar-thread.c: Sort headers.
4131         * aarch64-newlib-tdep.c: Sort headers.
4132         * aarch64-linux-tdep.c: Sort headers.
4133         * aarch64-linux-nat.c: Sort headers.
4134         * aarch64-fbsd-tdep.c: Sort headers.
4135         * aarch64-fbsd-nat.c: Sort headers.
4136         * aarch32-linux-nat.c: Sort headers.
4137
4138 2019-04-04  Tom Tromey  <tom@tromey.com>
4139
4140         * varobj.c (varobj_create): Update.
4141         * rust-exp.y (struct rust_parser) <update_innermost_block,
4142         lookup_symbol>: New methods.
4143         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4144         Rename.
4145         (rust_parser::rust_lookup_type)
4146         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4147         * printcmd.c (display_command, do_one_display): Update.
4148         * parser-defs.h (struct parser_state) <parser_state>: Add
4149         "tracker" parameter.
4150         (block_tracker): New member.
4151         (class innermost_block_tracker) <innermost_block_tracker>: Add
4152         "types" parameter.
4153         <reset>: Remove method.
4154         (innermost_block): Don't declare.
4155         (null_post_parser): Update.
4156         * parse.c (innermost_block): Remove global.
4157         (write_dollar_variable): Update.
4158         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4159         Remove "tracker_types" parameter.
4160         (parse_expression): Add "tracker" parameter.
4161         (parse_expression_for_completion): Update.
4162         (null_post_parser): Add "tracker" parameter.
4163         * p-exp.y: Update rules.
4164         * m2-exp.y: Update rules.
4165         * language.h (struct language_defn) <la_post_parser>: Add
4166         "tracker" parameter.
4167         * go-exp.y: Update rules.
4168         * f-exp.y: Update rules.
4169         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4170         parameter.
4171         * d-exp.y: Update rules.
4172         * c-exp.y: Update rules.
4173         * breakpoint.c (set_breakpoint_condition): Create an
4174         innermost_block_tracker.
4175         (watch_command_1): Likewise.
4176         * ada-lang.c (resolve): Add "tracker" parameter.
4177         (resolve_subexp): Likewise.
4178         * ada-exp.y (write_var_from_sym): Update.
4179
4180 2019-04-04  Tom Tromey  <tom@tromey.com>
4181
4182         * type-stack.h: New file.
4183         * type-stack.c: New file.
4184         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4185         type-stack.h.
4186         (insert_into_type_stack, insert_type, push_type, push_type_int)
4187         (insert_type_address_space, pop_type, pop_type_int)
4188         (pop_typelist, pop_type_stack, append_type_stack)
4189         (push_type_stack, get_type_stack, push_typelist)
4190         (follow_type_instance_flags, follow_types): Don't declare.
4191         * parse.c (type_stack): Remove global.
4192         (parse_exp_in_context): Update.
4193         (insert_into_type_stack, insert_type, push_type, push_type_int)
4194         (insert_type_address_space, pop_type, pop_type_int)
4195         (pop_typelist, pop_type_stack, append_type_stack)
4196         (push_type_stack, get_type_stack, push_typelist)
4197         (follow_type_instance_flags, follow_types): Remove (moved to
4198         type-stack.c).
4199         * f-exp.y (type_stack): New global.
4200         Update rules.
4201         (push_kind_type, f_parse): Update.
4202         * d-exp.y (type_stack): New global.
4203         Update rules.
4204         (d_parse): Update.
4205         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4206         Update rules.
4207         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4208         (HFILES_NO_SRCDIR): Add type-stack.h.
4209
4210 2019-04-04  Tom Tromey  <tom@tromey.com>
4211
4212         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4213         (rust_parser::convert_ast_to_expression, rust_parse)
4214         (rust_lex_test_completion, rust_lex_tests): Update.
4215         * parser-defs.h (struct expr_completion_state): New.
4216         (struct parser_state) <parser_state>: Add completion parameter.
4217         <mark_struct_expression, mark_completion_tag>: New methods.
4218         <parse_completion, m_completion_state>: New members.
4219         (prefixify_expression, null_post_parser): Update.
4220         (mark_struct_expression, mark_completion_tag): Don't declare.
4221         * parse.c (parse_completion, expout_last_struct)
4222         (expout_tag_completion_type, expout_completion_name): Remove
4223         globals.
4224         (parser_state::mark_struct_expression)
4225         (parser_state::mark_completion_tag): Now methods.
4226         (prefixify_expression): Add last_struct parameter.
4227         (prefixify_subexp): Likewise.
4228         (parse_exp_1): Update.
4229         (parse_exp_in_context): Add cstate parameter.  Update.
4230         (parse_expression_for_completion): Create an
4231         expr_completion_state.
4232         (null_post_parser): Add "completion" parameter.
4233         * p-exp.y: Update rules.
4234         (yylex): Update.
4235         * language.h (struct language_defn) <la_post_parser>: Add
4236         "completing" parameter.
4237         * go-exp.y: Update rules.
4238         (lex_one_token): Update.
4239         * expression.h (parse_completion): Don't declare.
4240         * d-exp.y: Update rules.
4241         (lex_one_token): Update rules.
4242         * c-exp.y: Update rules.
4243         (lex_one_token): Update.
4244         * ada-lang.c (resolve): Add "parse_completion" parameter.
4245         (resolve_subexp): Likewise.
4246         (ada_resolve_function): Likewise.
4247
4248 2019-04-04  Tom Tromey  <tom@tromey.com>
4249
4250         * parser-defs.h (struct parser_state) <start_arglist,
4251         end_arglist>: New methods.
4252         <arglist_len, m_funcall_chain>: New members.
4253         (arglist_len, start_arglist, end_arglist): Don't declare.
4254         * parse.c (arglist_len, funcall_chain): Remove global.
4255         (start_arglist, end_arglist): Remove functions.
4256         (parse_exp_in_context): Update.
4257         * p-exp.y: Update rules.
4258         * m2-exp.y: Update rules.
4259         * go-exp.y: Update rules.
4260         * f-exp.y: Update rules.
4261         * d-exp.y: Update rules.
4262         * c-exp.y: Update rules.
4263
4264 2019-04-04  Tom Tromey  <tom@tromey.com>
4265
4266         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4267         lex_operator, push_back>: New methods.
4268         Update all rules.
4269         (rust_parser::lex_hex, lex_escape): Rename and update.
4270         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4271         (rust_parser::lex_operator): Rename and update.
4272         (rust_parser::lex_number, rustyylex, rustyyerror)
4273         (rust_lex_test_init, rust_lex_test_sequence)
4274         (rust_lex_test_push_back, rust_lex_tests): Update.
4275         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4276         parameter.
4277         <lexptr, prev_lexptr>: New members.
4278         (lexptr, prev_lexptr): Don't declare.
4279         * parse.c (lexptr, prev_lexptr): Remove globals.
4280         (parse_exp_in_context): Update.
4281         * p-exp.y (yylex, yyerror): Update.
4282         * m2-exp.y (parse_number, yylex, yyerror): Update.
4283         * go-exp.y (lex_one_token, yyerror): Update.
4284         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4285         * d-exp.y (lex_one_token, yyerror): Update.
4286         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4287         (lex_one_token, yyerror): Update.
4288         * ada-lex.l (YY_INPUT): Update.
4289         (rewind_to_char): Update.
4290         * ada-exp.y (yyerror): Update.
4291
4292 2019-04-04  Tom Tromey  <tom@tromey.com>
4293
4294         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4295         * parser-defs.h (struct parser_state) <parser_state>: Add new
4296         parameter.
4297         <comma_terminates>: New member.
4298         (comma_terminates): Don't declare global.
4299         * parse.c (comma_terminates): Remove global.
4300         (parse_exp_in_context): Update.
4301         * p-exp.y (yylex): Update.
4302         * m2-exp.y (yylex): Update.
4303         * go-exp.y (lex_one_token): Update.
4304         * f-exp.y (yylex): Update.
4305         * d-exp.y (lex_one_token): Update.
4306         * c-exp.y (lex_one_token): Update.
4307         * ada-lex.l: Update.
4308
4309 2019-04-04  Tom Tromey  <tom@tromey.com>
4310
4311         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4312         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4313         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4314         * parser-defs.h (paren_depth): Don't declare.
4315         * parse.c (paren_depth): Remove global.
4316         (parse_exp_in_context): Update.
4317         * p-exp.y (paren_depth): New global.
4318         (pascal_parse): Initialize it.
4319         * m2-exp.y (paren_depth): New global.
4320         (m2_parse): Initialize it.
4321         * go-exp.y (paren_depth): New global.
4322         (go_parse): Initialize it.
4323         * f-exp.y (paren_depth): New global.
4324         (f_parse): Initialize it.
4325         * d-exp.y (paren_depth): New global.
4326         (d_parse): Initialize it.
4327         * c-exp.y (paren_depth): New global.
4328         (c_parse): Initialize it.
4329         * ada-lex.l (paren_depth): New global.
4330         (lexer_init): Initialize it.
4331
4332 2019-04-04  Tom Tromey  <tom@tromey.com>
4333
4334         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4335         (rust_parser::convert_ast_to_type)
4336         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4337         * parser-defs.h (struct parser_state) <parser_state>: Add
4338         parameters.  Initialize new members.
4339         <expression_context_block, expression_context_pc>: New members.
4340         * parse.c (expression_context_block, expression_context_pc):
4341         Remove globals.
4342         (parse_exp_in_context): Update.
4343         * p-exp.y: Update all rules.
4344         (yylex): Update.
4345         * m2-exp.y: Update all rules.
4346         (yylex): Update.
4347         * go-exp.y (yylex): Update.
4348         * f-exp.y (yylex): Update.
4349         * d-exp.y: Update all rules.
4350         (yylex): Update.
4351         * c-exp.y: Update all rules.
4352         (lex_one_token, classify_name, yylex, c_parse): Update.
4353         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4354
4355 2019-04-04  Tom Tromey  <tom@tromey.com>
4356
4357         * gdbarch.h, gdbarch.c: Rebuild.
4358         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4359         * stap-probe.h:
4360         (struct stap_parse_info): Replace "parser_state" with
4361         "expr_builder".
4362         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4363         (parser_state): New class.
4364         * parse.c (expr_builder): Rename.
4365         (expr_builder::release): Rename.
4366         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4367         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4368         (write_exp_elt_longcst, write_exp_elt_floatcst)
4369         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4370         (write_exp_string_vector, write_exp_bitstring)
4371         (write_exp_msymbol, mark_struct_expression)
4372         (write_dollar_variable)
4373         (insert_type_address_space, increase_expout_size): Replace
4374         "parser_state" with "expr_builder".
4375         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4376         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4377         "parser_state" with "expr_builder".
4378
4379 2019-04-04  Tom Tromey  <tom@tromey.com>
4380
4381         * rust-exp.y: Replace "parse_language" with method call.
4382         * p-exp.y:
4383         (yylex): Replace "parse_language" with method call.
4384         * m2-exp.y:
4385         (yylex): Replace "parse_language" with method call.
4386         * go-exp.y (classify_name): Replace "parse_language" with method
4387         call.
4388         * f-exp.y (yylex): Replace "parse_language" with method call.
4389         * d-exp.y (lex_one_token): Replace "parse_language" with method
4390         call.
4391         * c-exp.y:
4392         (lex_one_token, classify_name, yylex): Replace "parse_language"
4393         with method call.
4394         * ada-exp.y (find_primitive_type, type_char)
4395         (type_system_address): Replace "parse_language" with method call.
4396
4397 2019-04-04  Tom Tromey  <tom@tromey.com>
4398
4399         * rust-exp.y: Replace "parse_gdbarch" with method call.
4400         * parse.c (write_dollar_variable, insert_type_address_space):
4401         Replace "parse_gdbarch" with method call.
4402         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4403         call.
4404         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4405         call.
4406         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4407         "parse_gdbarch" with method call.
4408         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4409         with method call.
4410         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4411         "parse_gdbarch" with method call.
4412         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4413         "parse_gdbarch" with method call.
4414         * c-exp.y (parse_type, parse_number, classify_name): Replace
4415         "parse_gdbarch" with method call.
4416         * ada-lex.l: Replace "parse_gdbarch" with method call.
4417         * ada-exp.y (parse_type, find_primitive_type, type_char)
4418         (type_system_address): Replace "parse_gdbarch" with method call.
4419
4420 2019-04-04  Tom Tromey  <tom@tromey.com>
4421
4422         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4423         * stap-probe.c (stap_parse_argument): Update.
4424         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4425         initial_size parameter.
4426         * rust-exp.y (rust_lex_tests): Update.
4427         * parse.c (parser_state): Update.
4428         (parse_exp_in_context): Update.
4429         * parser-defs.h (struct parser_state) <parser_state>: Remove
4430         "initial_size" parameter.
4431
4432 2019-04-04  Tom Tromey  <tom@tromey.com>
4433
4434         * parser-defs.h (increase_expout_size): Don't declare.
4435         * parse.c (increase_expout_size): Now static.
4436
4437 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4438
4439         * gnu-nat.c (gnu_nat_target::wait): Fix
4440         target_waitstatus_to_string call.
4441
4442 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * eval.c (evaluate_subexp_standard): Handle internal functions
4445         during Fortran function call handling.
4446
4447 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * NEWS: Mention new internal functions.
4450         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4451         (read_base_type): Use dwarf2_init_complex_target_type.
4452         * value.c (creal_internal_fn): New function.
4453         (cimag_internal_fn): New function.
4454         (_initialize_values): Register new internal functions.
4455
4456 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4457
4458         * infrun.c (stop_all_threads): If debug_infrun, always
4459         trace the wait status after wait_one, using
4460         target_waitstatus_to_string and target_pid_to_str.
4461         (handle_inferior_event): Replace various trace of
4462         wait status kind by a single trace.
4463         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4464         wait status kind image by target_waitstatus_to_string.
4465         * target/waitstatus.c (target_waitstatus_to_string): Fix
4466         obsolete comment.
4467
4468 2019-04-01  Tom Tromey  <tromey@adacore.com>
4469
4470         PR symtab/23331:
4471         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4472
4473 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4474             Pedro Alves  <palves@redhat.com>
4475
4476         * top.c (quit_force): Call 'finalize_values'.
4477         * value.c (finalize_values): New function.
4478         * value.h (finalize_values): Declare.
4479
4480 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4481
4482         * NEWS: Announce $_gdb_major and $_gdb_minor.
4483
4484         * top.c (init_gdb_version_vars): New function.
4485         (gdb_init): Call init_gdb_version_vars.
4486
4487 2019-03-29  Tom Tromey  <tromey@adacore.com>
4488
4489         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4490         help text.  Remove dead code.
4491
4492 2019-03-29  Keith Seitz  <keiths@redhat.com>
4493
4494         From Siddhesh Poyarekar:
4495         * f-lang.h (f77_get_upperbound): Return LONGEST.
4496         (f77_get_lowerbound): Likewise.
4497         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4498         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4499         print them.
4500         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4501         plongest to format print it.
4502         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4503         (f77_get_upperbound): Likewise.
4504         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4505         LOWER_BOUND to LONGEST.
4506         (f77_create_arrayprint_offset_tbl): Likewise.
4507
4508 2019-03-29  Keith Seitz  <keiths@redhat.com>
4509
4510         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4511         %s/pulongest for TYPE_LENGTH instead of %d in format
4512         strings.
4513         * ada-typerint.c (ada_print_type): Likewise.
4514         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4515         * compile/compile-c-support.c (generate_register_struct): Likewise.
4516         * gdbtypes.c (recursive_dump_type): Likewise.
4517         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4518         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4519         instead of %d in format strings.
4520         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4521         to std::min to ULONGEST.
4522         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4523         instead of %d in format strings.
4524         * tracepoint.c (info_scope_command): Likewise.
4525         * typeprint.c (print_offset_data::update)
4526         (print_offset_data::finish): Likewise.
4527         * xtensa-tdep.c (xtensa_store_return_value)
4528         (xtensa_push_dummy_call): Likewise.
4529
4530 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4531
4532         * windows-nat.c (display_selector): Fixed format specifications
4533         for 64-bit Cygwin.
4534
4535 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4536
4537         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4538
4539 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4540
4541         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4542         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4543         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4544         (nios2_linux_init_abi): Install it.
4545
4546 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4547
4548         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4549
4550 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4551
4552         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4553
4554 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555             Tom Tromey  <tromey@adacore.com>
4556
4557         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4558
4559 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4560
4561         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4562         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4563         method to compute the bounds of range types. Also print "[evaluated]"
4564         if the bounds' values come from a dynamic evaluation.
4565
4566 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4569         whitespace when pretty printing is on.
4570
4571 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4572
4573         * ppc-linux-nat.c: Add include.
4574
4575 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4576
4577         * NEWS: Mention AArch64 Pointer Authentication.
4578
4579 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4580
4581         * arm-linux-nat.c: Add include.
4582
4583 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4584
4585         * source-cache.c (source_cache::get_source_lines): Re-read
4586         fullname after calling open_source_file.
4587
4588 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4589
4590         * NEWS: Mention TLS support for FreeBSD.
4591
4592 2019-03-25  Tom Tromey  <tromey@adacore.com>
4593
4594         * minsyms.c (BUNCH_SIZE): Update comment.
4595         (~minimal_symbol_reader): Remove old comment.
4596         (compact_minimal_symbols): Update comment.
4597         (minimal_symbol_reader::install): Remove old comment.  Update
4598         other comments.
4599
4600 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4601
4602         * s390-linux-nat.c: Add include.
4603
4604 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4605
4606         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4607         Call linux_get_hwcap.
4608         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4609         Likewise.
4610         (aarch64_linux_get_hwcap): Remove function.
4611         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4612         declaration.
4613         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4614         linux_get_hwcap.
4615         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4616         * linux-tdep.c (linux_get_hwcap): Add function.
4617         (linux_get_hwcap2): Likewise.
4618         * linux-tdep.h (linux_get_hwcap): Add declaration.
4619         (linux_get_hwcap2): Likewise.
4620         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4621         (ppc_linux_get_hwcap2): Likewise.
4622         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4623         linux_get_hwcap.
4624         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4625         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4626         (ppc_linux_nat_target::read_description): Likewise.
4627         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4628         * s390-linux-nat.c: Likewise.
4629         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4630
4631 2019-03-24  Tom Tromey  <tom@tromey.com>
4632
4633         * ada-lang.c (standard_lookup): Simplify initialization.
4634         (ada_lookup_symbol_nonlocal): Simplify return.
4635         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4636         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4637         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4638         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4639         initialization.
4640         * solib.c (solib_global_lookup): Simplify.
4641         * symtab.c (null_block_symbol): Remove.
4642         (symbol_cache_lookup): Simplify returns.
4643         (lookup_language_this): Simplify returns.
4644         (lookup_symbol_aux): Simplify return.
4645         (lookup_local_symbol): Simplify returns.
4646         (lookup_global_symbol_from_objfile): Simplify return.
4647         (lookup_symbol_in_objfile_symtabs)
4648         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4649         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4650         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4651         * cp-namespace.c (cp_lookup_bare_symbol)
4652         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4653         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4654         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4655         (cp_lookup_symbol_via_imports): Simplify initialization.
4656         (find_symbol_in_baseclass): Likewise.
4657         * symtab.h (null_block_symbol): Remove.
4658         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4659         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4660         (d_lookup_symbol_module): Likewise.
4661         (find_symbol_in_baseclass): Simplify initialization.
4662
4663 2019-03-24  Tom Tromey  <tom@tromey.com>
4664
4665         * expression.h: Don't include symtab.h.
4666         (struct block): Forward declare.
4667
4668 2019-03-24  Tom Tromey  <tom@tromey.com>
4669
4670         * c-exp.y (typebase): Remove casts.
4671         * gdbtypes.c (lookup_unsigned_typename, )
4672         (lookup_signed_typename): Remove cast.
4673         * eval.c (parse_to_comma_and_eval): Remove cast.
4674         * parse.c (write_dollar_variable): Remove cast.
4675         * block.h (struct block) <superblock>: Now const.
4676         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4677         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4678         (map_block): Make "block" const.
4679         * symfile.h (struct quick_symbol_functions)
4680         <map_matching_symbols>: Constify block argument to "callback".
4681         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4682         const.
4683         (find_pc_sect_compunit_symtab): Make "b" const.
4684         (find_symbol_at_address): Likewise.
4685         (search_symbols): Likewise.
4686         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4687         (dw2_debug_names_lookup_symbol): Likewise.
4688         (dw2_map_matching_symbols): Update.
4689         * p-valprint.c (pascal_val_print): Remove "block".
4690         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4691         (aux_add_nonlocal_symbols): Make "block" const.
4692         (resolve_subexp): Remove cast.
4693         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4694         const.
4695         (iterate_over_file_blocks): Likewise.
4696         * f-exp.y (%union) <bval>: Remove.
4697         * coffread.c (patch_opaque_types): Make "b" const.
4698         * spu-tdep.c (spu_catch_start): Make "block" const.
4699         * c-valprint.c (print_unpacked_pointer): Remove "block".
4700         * symmisc.c (dump_symtab_1): Make "b" const.
4701         (block_depth): Make "block" const.
4702         * d-exp.y (%union) <bval>: Remove.
4703         * cp-support.h (cp_lookup_rtti_type): Update.
4704         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4705         * psymtab.c (psym_lookup_symbol): Make "block" const.
4706         (maintenance_check_psymtabs): Make "b" const.
4707         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4708         (enumerate_locals, enumerate_args): Update.
4709         * python/py-symtab.c (stpy_global_block): Make "block" const.
4710         (stpy_static_block): Likewise.
4711         * inline-frame.c (block_starting_point_at): Make "new_block"
4712         const.
4713         * block.c (find_block_in_blockvector): Make return type const.
4714         (blockvector_for_pc_sect): Make "b" const.
4715         (find_block_in_blockvector): Make "b" const.
4716
4717 2019-03-23  Tom Tromey  <tom@tromey.com>
4718
4719         * varobj.c (varobj_create): Update.
4720         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4721         * printcmd.c (display_command, do_one_display): Don't reset
4722         innermost_block.
4723         * parser-defs.h (enum innermost_block_tracker_type): Move to
4724         expression.h.
4725         (innermost_block): Update comment.
4726         * parse.c (parse_exp_1): Add tracker_types parameter.
4727         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4728         tracker_types parameter.  Reset innermost_block.
4729         (parse_exp_in_context): Remove.
4730         (parse_expression_for_completion): Update.
4731         * objfiles.c (~objfile): Don't reset expression_context_block or
4732         innermost_block.
4733         * expression.h (enum innermost_block_tracker_type): Move from
4734         parser-defs.h.
4735         (parse_exp_1): Add tracker_types parameter.
4736         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4737         reset innermost_block.
4738
4739 2019-03-23  Tom Tromey  <tom@tromey.com>
4740
4741         * objfiles.h: Include bcache.h.
4742
4743 2019-03-23  Tom Tromey  <tom@tromey.com>
4744
4745         * linespec.c (get_current_search_block): Use
4746         scoped_restore_current_language.
4747         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4748
4749 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4750             Jiong Wang  <jiong.wang@arm.com>
4751
4752         * aarch64-linux-tdep.c
4753         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4754         section.
4755         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4756
4757 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4758             Jiong Wang  <jiong.wang@arm.com>
4759
4760         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4761         instructions.
4762         (aarch64_analyze_prologue_test): Add PACIASP test.
4763         (aarch64_prologue_prev_register): Unmask PC value.
4764
4765 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4766             Jiong Wang  <jiong.wang@arm.com>
4767
4768         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4769         (aarch64_dwarf2_prev_register): Unmask PC value.
4770         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4771         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4772         DW_CFA_AARCH64_negate_ra_state.
4773         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4774
4775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4776             Jiong Wang  <jiong.wang@arm.com>
4777
4778         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4779         registers.
4780         (aarch64_pseudo_register_name): Likewise.
4781         (aarch64_pseudo_register_type): Likewise.
4782         (aarch64_pseudo_register_reggroup_p): Likewise.
4783         (aarch64_gdbarch_init): Add pauth registers.
4784         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4785         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4786         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4787         (struct gdbarch_tdep): Add regnum for ra_state.
4788
4789 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4790             Jiong Wang  <jiong.wang@arm.com>
4791
4792         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4793
4794 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4795             Jiong Wang  <jiong.wang@arm.com>
4796
4797         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4798         function.
4799         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4800         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4801         (aarch64_gdbarch_init): Add puth registers.
4802         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4803         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4804         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4805
4806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4807             Jiong Wang  <jiong.wang@arm.com>
4808
4809         * aarch64-linux-nat.c
4810         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4811         * aarch64-linux-tdep.c
4812         (aarch64_linux_core_read_description): Likewise.
4813         (aarch64_linux_get_hwcap): New function.
4814         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4815         (aarch64_linux_get_hwcap): New declaration.
4816
4817 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4818             Jiong Wang  <jiong.wang@arm.com>
4819
4820         * aarch64-linux-nat.c
4821         (aarch64_linux_nat_target::read_description): Add pauth param.
4822         * aarch64-linux-tdep.c
4823         (aarch64_linux_core_read_description): Likewise.
4824         * aarch64-tdep.c (struct target_desc): Add in pauth.
4825         (aarch64_read_description): Add pauth param.
4826         (aarch64_gdbarch_init): Likewise.
4827         * aarch64-tdep.h (aarch64_read_description): Likewise.
4828         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4829         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4830         * features/Makefile: Add new files.
4831         * features/aarch64-pauth.c: New file.
4832         * features/aarch64-pauth.xml: New file.
4833
4834 2019-03-20  Tom Tromey  <tromey@adacore.com>
4835
4836         * infrun.c (handle_inferior_event): Rename from
4837         handle_inferior_event_1.  Create a scoped_value_mark.
4838         (handle_inferior_event): Remove.
4839
4840 2019-03-19  Tom Tromey  <tromey@adacore.com>
4841
4842         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4843         * infrun.h (print_stop_event): Add "displays" parameter.
4844         * infrun.c (print_stop_event): Add "displays" parameter.
4845
4846 2019-03-19  Pedro Alves  <palves@redhat.com>
4847
4848         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4849         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4850         to -1.  Fix TABs vs spaces.
4851         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4852         * tui/tui-out.h (tui_ui_out) Add intro comments.
4853         <m_line, m_start_of_line>: In-class initialize, and add describing
4854         comment.
4855
4856 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4857
4858         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4859         variable names.
4860         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4861
4862 2019-03-18  Pedro Alves  <palves@redhat.com>
4863             Eli Zaretskii <eliz@gnu.org>
4864
4865         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4866         m_line and m_start_of_line.
4867
4868 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4869
4870         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4871         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4872         it returns a newline.  This fixes a regression in TU mode, whereby
4873         the next line is output on the same screen line as the user input.
4874
4875 2019-03-18  Tom Tromey  <tromey@adacore.com>
4876
4877         * minsyms.c (minimal_symbol_reader::install): Remove call to
4878         obstack_blank.
4879
4880 2019-03-18  Pedro Alves  <palves@redhat.com>
4881
4882         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4883         New globals.
4884         (apply_style): New, factored out from ...
4885         (apply_ansi_escape): ... this.  Handle reverse video mode.
4886         (tui_set_reverse_mode): New function.
4887         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4888         * tui/tui-winsource.c (tui_show_source_line): Use
4889         tui_set_reverse_mode instead of setting A_STANDOUT.
4890         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4891         New setter methods.
4892
4893 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4894
4895         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4896         Handle tabs.
4897
4898 2019-03-18  Tom Tromey  <tromey@adacore.com>
4899
4900         * ada-lang.c (empty_array): Add "high" parameter.
4901         (ada_evaluate_subexp): Update.
4902
4903 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4904
4905         * unittests/string_view-selftests.c: Define
4906         _initialize_string_view_selftests unconditionally.
4907
4908 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4909
4910         PR gdb/24350
4911         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4912
4913 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4914
4915         PR gdb/24351
4916         * windows-nat.c (display_selector): Fix format specifiers.
4917
4918 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4919
4920         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4921         tui_refill_source_window instead of tui_refresh_win, to update the
4922         current execution line.  This fixes redisplay of the current line
4923         when stepping through the code with "next" or "step".
4924
4925 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4926
4927         * source-cache.c (source_cache::get_source_lines): Call
4928         find_source_lines to initialize s->nlines.  This fixes vertical
4929         scrolling of TUI source window when the DOWN arrow is pressed.
4930
4931 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4932
4933         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4934         linux-thread-db.c (_initialize_thread_db): Likewise.
4935
4936 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4937
4938         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4939         wclrtoeol in tui_show_source_line".  This reverts changes made in
4940         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4941
4942 2019-03-15  Tom Tromey  <tom@tromey.com>
4943
4944         * symtab.h (struct minimal_symbol): Derive from
4945         general_symbol_info.
4946         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4947         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4948         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4949         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4950         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4951         (MSYMBOL_SEARCH_NAME): Update.
4952         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4953         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4954         * minsyms.c (minimal_symbol_reader::record_full): Update.
4955
4956 2019-03-15  Tom Tromey  <tom@tromey.com>
4957
4958         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4959
4960 2019-03-15  Tom Tromey  <tom@tromey.com>
4961
4962         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4963         unique_xmalloc_ptr.
4964         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4965         Update.
4966         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4967         (build_minimal_symbol_hash_tables)
4968         (minimal_symbol_reader::install): Update.
4969
4970 2019-03-15  Tom Tromey  <tom@tromey.com>
4971
4972         * symtab.c (create_demangled_names_hash): Update.
4973         (symbol_set_names): Update.
4974         * objfiles.h (struct objfile_per_bfd_storage)
4975         <demangled_names_hash>: Now an htab_up.
4976         * objfiles.c (objfile_per_bfd_storage): Simplify.
4977
4978 2019-03-15  Tom Tromey  <tom@tromey.com>
4979
4980         * objfiles.h (struct objfile_per_bfd_storage): Declare
4981         destructor.
4982         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4983         New.
4984         (get_objfile_bfd_data): Use new.  Don't initialize
4985         language_of_main.
4986         (free_objfile_per_bfd_storage): Remove.
4987         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4988
4989 2019-03-15  Tom Tromey  <tom@tromey.com>
4990
4991         * symfile.c (reread_symbols): Update.
4992         * objfiles.c (objfile::objfile): Update.
4993         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4994         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4995         comment.
4996         (minimal_symbol_reader::install): Update.
4997         (terminate_minimal_symbol_table): Remove.
4998         * jit.c (jit_object_close_impl): Update.
4999
5000 2019-03-15  Tom Tromey  <tom@tromey.com>
5001
5002         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5003         initializations.
5004
5005 2019-03-15  Tom Tromey  <tom@tromey.com>
5006
5007         * objfiles.h (struct objfile_per_bfd_storage)
5008         <demangled_hash_languages>: Now a bitset.
5009         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5010         (lookup_minimal_symbol): Update.
5011
5012 2019-03-15  Tom Tromey  <tom@tromey.com>
5013
5014         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5015         Don't return the symbol.
5016         * coffread.c (record_minimal_symbol): Use record_full.
5017
5018 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5019
5020         The MS-Windows port of ncurses fails to switch to a color pair if
5021         one or both of the colors are the implicit default colors.  This
5022         change records the default colors when TUI is initialized, and
5023         then specifies them explicitly when a color pair uses the default
5024         colors.  This allows color styling in TUI mode on MS-Windows.
5025
5026         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5027         ncurses_norm_attr.
5028         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5029         colors in ncurses_norm_attr.
5030         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5031         "none", replace it with the default color recorded in
5032         ncurses_norm_attr.
5033
5034 2019-03-14  Tom Tromey  <tromey@adacore.com>
5035
5036         * source-cache.h (class source_cache) <get_source_lines>: Return
5037         std::string.
5038         * source-cache.c (source_cache::extract_lines): Handle case where
5039         first_pos==npos.  Return std::string.
5040         (source_cache::get_source_lines): Update.
5041
5042 2019-03-14  Tom Tromey  <tromey@adacore.com>
5043
5044         * NEWS: Add item for "style sources" commands.
5045         * source-cache.c (source_cache::get_source_lines): Check
5046         source_styling.
5047         * cli/cli-style.c (source_styling): New global.
5048         (_initialize_cli_style): Add "style sources" commands.
5049         (show_style_sources): New function.
5050         * cli/cli-style.h (source_styling): Declare.
5051
5052 2019-03-14  Pedro Alves  <palves@redhat.com>
5053             Tom Tromey  <tromey@adacore.com>
5054
5055         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5056         * tui/tui-winsource.c (tui_refill_source_window): New function,
5057         from...
5058         (tui_horizontal_source_scroll): ... here.  Move some logic.
5059         * cli/cli-style.c (set_style_enabled): Notify new observable.
5060         * tui/tui-hooks.c (tui_redisplay_source): New function.
5061         (tui_attach_detach_observers): Attach or detach
5062         tui_redisplay_source.
5063         * observable.h (source_styling_changed): New observable.
5064         * observable.c: Define source_styling_changed observable.
5065
5066 2019-03-13  Tom Tromey  <tromey@adacore.com>
5067
5068         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5069         (i386_gnu_nat_target::store_registers): Update.
5070         * target-debug.h (target_debug_print_std_string): New macro.
5071         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5072         * windows-tdep.c (display_one_tib): Update.
5073         * tui/tui-stack.c (tui_make_status_line): Update.
5074         * top.c (print_inferior_quit_action): Update.
5075         * thread.c (thr_try_catch_cmd): Update.
5076         (add_thread_with_info): Update.
5077         (thread_target_id_str): Update.
5078         (thr_try_catch_cmd): Update.
5079         (thread_command): Update.
5080         (thread_find_command): Update.
5081         * record-btrace.c (record_btrace_target::info_record)
5082         (record_btrace_resume_thread, record_btrace_target::resume)
5083         (record_btrace_cancel_resume, record_btrace_step_thread)
5084         (record_btrace_target::wait, record_btrace_target::wait)
5085         (record_btrace_target::wait, record_btrace_target::stop): Update.
5086         * progspace.c (print_program_space): Update.
5087         * process-stratum-target.c
5088         (process_stratum_target::thread_address_space): Update.
5089         * linux-fork.c (linux_fork_mourn_inferior)
5090         (detach_checkpoint_command, info_checkpoints_command)
5091         (linux_fork_context): Update.
5092         (linux_fork_detach): Update.
5093         (class scoped_switch_fork_info): Update.
5094         (delete_checkpoint_command): Update.
5095         * infrun.c (follow_fork_inferior): Update.
5096         (follow_fork_inferior): Update.
5097         (proceed_after_vfork_done): Update.
5098         (handle_vfork_child_exec_or_exit): Update.
5099         (follow_exec): Update.
5100         (displaced_step_prepare_throw): Update.
5101         (displaced_step_restore): Update.
5102         (start_step_over): Update.
5103         (resume_1): Update.
5104         (clear_proceed_status_thread): Update.
5105         (proceed): Update.
5106         (print_target_wait_results): Update.
5107         (do_target_wait): Update.
5108         (context_switch): Update.
5109         (stop_all_threads): Update.
5110         (restart_threads): Update.
5111         (finish_step_over): Update.
5112         (handle_signal_stop): Update.
5113         (switch_back_to_stepped_thread): Update.
5114         (keep_going_pass_signal): Update.
5115         (print_exited_reason): Update.
5116         (normal_stop): Update.
5117         * inferior.c (inferior_pid_to_str): Change return type.
5118         (print_selected_inferior): Update.
5119         (add_inferior): Update.
5120         (detach_inferior): Update.
5121         * dummy-frame.c (fprint_dummy_frames): Update.
5122         * dcache.c (dcache_info_1): Update.
5123         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5124         (btrace_fetch, btrace_clear): Update.
5125         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5126         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5127         type.
5128         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5129         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5130         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5131         * gdbarch.c, gdbarch.h: Rebuild.
5132         * gdbarch.sh (core_pid_to_str): Change return type.
5133         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5134         return type.
5135         (windows_nat_target::pid_to_str): Change return type.
5136         (windows_delete_thread): Update.
5137         (windows_nat_target::attach): Update.
5138         (windows_nat_target::files_info): Update.
5139         * target-delegates.c: Rebuild.
5140         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5141         return type.
5142         (sol_thread_target::pid_to_str): Change return type.
5143         * remote.c (class remote_target) <pid_to_str>: Change return
5144         type.
5145         (remote_target::pid_to_str): Change return type.
5146         (extended_remote_target::attach, remote_target::remote_stop_ns)
5147         (remote_target::remote_notif_remove_queued_reply)
5148         (remote_target::push_stop_reply, remote_target::disable_btrace):
5149         Update.
5150         (extended_remote_target::attach): Update.
5151         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5152         type.
5153         (gdbsim_target::pid_to_str): Change return type.
5154         * ravenscar-thread.c (struct ravenscar_thread_target)
5155         <pid_to_str>: Change return type.
5156         (ravenscar_thread_target::pid_to_str): Change return type.
5157         * procfs.c (class procfs_target) <pid_to_str>: Change return
5158         type.
5159         (procfs_target::pid_to_str): Change return type.
5160         (procfs_target::attach): Update.
5161         (procfs_target::detach): Update.
5162         (procfs_target::fetch_registers): Update.
5163         (procfs_target::store_registers): Update.
5164         (procfs_target::wait): Update.
5165         (procfs_target::files_info): Update.
5166         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5167         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5168         return type.
5169         (nto_procfs_target::pid_to_str): Change return type.
5170         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5171         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5172         return type.
5173         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5174         (exit_lwp): Update.
5175         (attach_proc_task_lwp_callback, get_detach_signal)
5176         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5177         (linux_nat_target::resume, wait_lwp, stop_callback)
5178         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5179         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5180         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5181         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5182         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5183         type.
5184         (inf_ptrace_target::attach): Update.
5185         (inf_ptrace_target::files_info): Update.
5186         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5187         type.
5188         (go32_nat_target::pid_to_str): Change return type.
5189         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5190         (gnu_nat_target::wait): Update.
5191         (gnu_nat_target::wait): Update.
5192         (gnu_nat_target::resume): Update.
5193         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5194         (fbsd_nat_target::wait): Update.
5195         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5196         type.
5197         (darwin_nat_target::attach): Update.
5198         * corelow.c (class core_target) <pid_to_str>: Change return type.
5199         (core_target::pid_to_str): Change return type.
5200         * target.c (normal_pid_to_str): Change return type.
5201         (default_pid_to_str): Likewise.
5202         (target_pid_to_str): Change return type.
5203         (target_translate_tls_address): Update.
5204         (target_announce_detach): Update.
5205         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5206         return type.
5207         (bsd_uthread_target::pid_to_str): Change return type.
5208         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5209         type.
5210         (bsd_kvm_target::pid_to_str): Change return type.
5211         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5212         return type.
5213         (aix_thread_target::pid_to_str): Change return type.
5214         * target.h (struct target_ops) <pid_to_str>: Change return type.
5215         (target_pid_to_str, normal_pid_to_str): Likewise.
5216         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5217         type.
5218         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5219         type.
5220         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5221         return type.
5222         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5223         type.
5224         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5225         type.
5226         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5227         return type.
5228
5229 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5230
5231         * NEWS: Mention that the new default MI version is 3.  Mention
5232         changes to the output of commands and events that deal with
5233         multi-location breakpoints.
5234         * breakpoint.c: Include "mi/mi-out.h".
5235         (print_one_breakpoint): Change output syntax if using MI version
5236         >= 3.
5237         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5238         New.
5239         (mi_multi_location_breakpoint_output_fixed): New.
5240         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5241         (mi_cmd_fix_multi_location_breakpoint_output): New.
5242         (mi_multi_location_breakpoint_output_fixed): New.
5243         * mi/mi-cmds.c (mi_cmds): Register command
5244         -fix-multi-location-breakpoint-output.
5245         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5246         interpreter "mi".
5247
5248 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5249
5250         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5251         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5252         instantiate mi_ui_out based on interpreter name.
5253         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5254         * mi/mi-main.c (mi_load_progress): Likewise.
5255
5256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5257
5258         * NEWS: Combine separate "New targets" sections for 8.3.
5259
5260 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5261
5262         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5263         (ppcfbsd_init_abi): Install gdbarch
5264         "fetch_tls_load_module_address" and "get_thread_local_address"
5265         methods.
5266
5267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5268
5269         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5270         (riscv_fbsd_init_abi): Install gdbarch
5271         "fetch_tls_load_module_address" and "get_thread_local_address"
5272         methods.
5273
5274 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5275
5276         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5277         (i386fbsd_init_abi): Install gdbarch
5278         "fetch_tls_load_module_address" and "get_thread_local_address"
5279         methods.
5280
5281 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5282
5283         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5284         (amd64fbsd_init_abi): Install gdbarch
5285         "fetch_tls_load_module_address" and "get_thread_local_address"
5286         methods.
5287
5288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5289
5290         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5291         (struct fbsd_pspace_data): New type.
5292         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5293         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5294         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5295         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5296         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5297
5298 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5299
5300         * gdbtypes.c (lookup_struct_elt): New function.
5301         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5302         * gdbtypes.h (struct struct_elt): New type.
5303         (lookup_struct_elt): New prototype.
5304
5305 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5306
5307         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5308         remove disabled code block.
5309
5310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5311
5312         * gdbarch.sh (get_thread_local_address): New method.
5313         * gdbarch.h, gdbarch.c: Regenerate.
5314         * target.c (target_translate_tls_address): Use
5315         gdbarch_get_thread_local_address if present instead of
5316         target::get_thread_local_address.
5317
5318 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5319
5320         * target.h (target::get_thread_local_address): Update comment.
5321
5322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5323
5324         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5325         objfile->separate_debug_objfile_backlink if not NULL.
5326
5327 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5328
5329         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5330         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5331         (amd64bsd_store_inferior_registers): Likewise.
5332         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5333         Enable segment base registers.
5334         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5335         PT_GETFSBASE and PT_GETGSBASE.
5336         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5337         PT_SETGSBASE.
5338         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5339         segment base registers.
5340         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5341
5342 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5343
5344         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5345         Update calls to i386_target_description to add 'segments'
5346         parameter.
5347         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5348         add segment base registers.
5349         * arch/i386.c (i386_create_target_description): Add 'segments'
5350         parameter to enable segment base registers.
5351         * arch/i386.h (i386_create_target_description): Likewise.
5352         * features/i386/32bit-segments.xml: New file.
5353         * features/i386/32bit-segments.c: Generate.
5354         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5355         call to i386_target_description to add 'segments' parameter.
5356         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5357         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5358         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5359         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5360         if feature is present.
5361         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5362         Add 'segments' parameter to call to i386_target_description.
5363         (i386_target_description): Add 'segments' parameter to enable
5364         segment base registers.
5365         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5366         to call to i386_target_description.
5367         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5368         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5369         Define I386_NUM_REGS.
5370         (i386_target_description): Add 'segments' parameter to enable
5371         segment base registers.
5372
5373 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5374
5375         PR/24325
5376         * source-cache.c: #undef open and close, to avoid unresolved
5377         externals during linking.
5378
5379 2019-03-12  Tom Tromey  <tromey@adacore.com>
5380
5381         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5382         const.  Add initializers.
5383         (_initialize_remote): Don't initialize ptid globals.
5384
5385 2019-03-12  Pedro Alves  <palves@redhat.com>
5386
5387         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5388
5389 2019-03-12  Pedro Alves  <palves@redhat.com>
5390
5391         * cp-name-parser.y (main): Remove unused 'len' variable.
5392
5393 2019-03-12  Tom Tromey  <tromey@adacore.com>
5394
5395         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5396         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5397
5398 2019-03-12  Tom Tromey  <tromey@adacore.com>
5399
5400         * linux-nat.c (iterate_over_lwps): Update.
5401         (stop_callback): Remove parameter.
5402         (stop_wait_callback, detach_callback, resume_set_callback)
5403         (select_singlestep_lwp_callback, set_ignore_sigint)
5404         (status_callback, resumed_callback, resume_clear_callback)
5405         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5406         data parameter.
5407         (linux_nat_target::detach, linux_nat_target::resume)
5408         (linux_stop_and_wait_all_lwps, select_event_lwp)
5409         (linux_nat_filter_event, linux_nat_wait_1)
5410         (linux_nat_target::kill, linux_nat_target::stop)
5411         (linux_nat_target::stop): Update.
5412         (linux_nat_resume_callback): Change type.
5413         (resume_stopped_resumed_lwps, count_events_callback)
5414         (select_event_lwp_callback): Likewise.
5415         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5416         * arm-linux-nat.c (struct update_registers_data): Remove.
5417         (update_registers_callback): Change type.
5418         (arm_linux_insert_hw_breakpoint1): Update.
5419         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5420         parameter.
5421         (x86_linux_dr_set_addr): Update.
5422         (x86_linux_dr_set_control): Update.
5423         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5424         (iterate_over_lwps): Use gdb::function_view.
5425         * nat/aarch64-linux-hw-point.c (struct
5426         aarch64_dr_update_callback_param): Remove.
5427         (debug_reg_change_callback): Change type.
5428         (aarch64_notify_debug_reg_change): Update.
5429         * s390-linux-nat.c (s390_refresh_per_info): Update.
5430
5431 2019-03-11  Tom Tromey  <tromey@adacore.com>
5432
5433         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5434         redundant assignment to "this_cu".
5435
5436 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5437
5438         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5439
5440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5441
5442         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5443         from...
5444         (rank_one_type): ... this.
5445
5446 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5447
5448         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5449         from...
5450         (rank_one_type): ... this.
5451
5452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5453
5454         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5455         from...
5456         (rank_one_type): ... this.
5457
5458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5459
5460         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5461         from...
5462         (rank_one_type): ... this.
5463
5464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5465
5466         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5467         from...
5468         (rank_one_type): ... this.
5469
5470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5471
5472         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5473         from...
5474         (rank_one_type): ... this.
5475
5476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5477
5478         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5479         from...
5480         (rank_one_type): ... this.
5481
5482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5483
5484         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5485         from...
5486         (rank_one_type): ... this.
5487
5488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5489
5490         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5491         from...
5492         (rank_one_type): ... this.
5493
5494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5495
5496         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5497         from...
5498         (rank_one_type): ... this.
5499
5500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5501
5502         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5503         from...
5504         (rank_one_type): ... this.
5505
5506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5507
5508         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5509         from...
5510         (rank_one_type): ... this.
5511
5512 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5513
5514         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5515         inferior-events' shows the example events.
5516
5517 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5518
5519         Support styling on native MS-Windows console
5520
5521         PR/24315
5522         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5523         on MS-Windows if $TERM is not defined.
5524
5525         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5526
5527         * posix-hdep.c (gdb_console_fputs):
5528         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5529         functions.
5530         * ui-file.h (gdb_console_fputs): Add prototype.
5531
5532         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5533         back to fputs only if the former returns zero.
5534
5535 2019-03-07  Tom Tromey  <tom@tromey.com>
5536
5537         * symmisc.c (print_symbol_bcache_statistics): Update.
5538         (print_objfile_statistics): Update.
5539         * symfile.c (allocate_symtab): Update.
5540         * stabsread.c: Don't include bcache.h.
5541         * psymtab.h (struct psymbol_bcache): Don't declare.
5542         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5543         (psymbol_bcache_init, psymbol_bcache_free)
5544         (psymbol_bcache_get_bcache): Don't declare.
5545         * psymtab.c (struct psymbol_bcache): Remove.
5546         (psymtab_storage::psymtab_storage): Update.
5547         (psymtab_storage::~psymtab_storage): Update.
5548         (psymbol_bcache_init, psymbol_bcache_free)
5549         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5550         (add_psymbol_to_bcache): Update.
5551         (allocate_psymtab): Update.
5552         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5553         macro_cache>: No longer pointers.
5554         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5555         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5556         * macrotab.c (macro_bcache): Update.
5557         * macroexp.c: Don't include bcache.h.
5558         * gdbtypes.c (check_types_worklist): Update.
5559         (types_deeply_equal): Remove TRY/CATCH.  Update.
5560         * elfread.c (elf_symtab_read): Update.
5561         * dwarf2read.c: Don't include bcache.h.
5562         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5563         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5564         (print_bcache_statistics, bcache_memory_used): Don't declare.
5565         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5566         methods.  Rename all data members.
5567         * bcache.c (struct bcache): Move to bcache.h.
5568         (bcache::expand_hash_table): Rename from expand_hash_table.
5569         (bcache): Remove.
5570         (bcache::insert): Rename from bcache_full.
5571         (bcache::compare): Rename from bcache_compare.
5572         (bcache_xmalloc): Remove.
5573         (bcache::~bcache): Rename from bcache_xfree.
5574         (bcache::print_statistics): Rename from print_bcache_statistics.
5575         (bcache::memory_used): Rename from bcache_memory_used.
5576
5577 2019-03-07  Pedro Alves  <palves@redhat.com>
5578
5579         * infrun.c (normal_stop): Also check for
5580         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5581
5582 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5583
5584         * f-lang.c (value_from_host_double): Moved to...
5585         * value.c (value_from_host_double): ...here.
5586         * value.h (value_from_host_double): Declare.
5587         * guile/scm-math.c (vlscm_convert_typed_number): Use
5588         value_from_host_double.
5589         (vlscm_convert_number): Likewise.
5590         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5591         * python/py-value.c (convert_value_from_python): Likewise.
5592
5593 2019-03-06  Tom Tromey  <tom@tromey.com>
5594
5595         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5596
5597 2019-03-06  Tom Tromey  <tom@tromey.com>
5598
5599         * utils.h (free_current_contents): Don't declare.
5600         * utils.c (free_current_contents): Remove.
5601
5602 2019-03-06  Tom Tromey  <tom@tromey.com>
5603
5604         * top.c (quit_force): Update.
5605         * main.c (captured_command_loop): Update.
5606         * common/new-op.c (operator new): Update.
5607         * common/common-exceptions.c (struct catcher)
5608         <save_cleanup_chain>: Remove member.
5609         (exceptions_state_mc_init): Update.
5610         (exception_try_scope_entry): Return nullptr.
5611         (exception_try_scope_exit, exception_rethrow)
5612         (throw_exception_sjlj, throw_exception_cxx): Update.
5613         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5614         (all_cleanups, do_cleanups, discard_cleanups)
5615         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5616         (restore_cleanups, restore_final_cleanups): Don't declare.
5617         (do_final_cleanups): Remove parameter.
5618         * common/cleanups.c (cleanup_chain, make_cleanup)
5619         (make_cleanup_dtor, all_cleanups, do_cleanups)
5620         (discard_my_cleanups, discard_cleanups)
5621         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5622         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5623         (null_cleanup): Remove.
5624         (do_final_cleanups): Remove parameter.
5625
5626 2019-03-06  Tom Tromey  <tom@tromey.com>
5627
5628         * remote.c (remote_target::remote_parse_stop_reply): Use
5629         unique_xmalloc_ptr.
5630
5631 2019-03-06  Tom Tromey  <tom@tromey.com>
5632
5633         * stabsread.c (struct stabs_field_info): Rename from field_info.
5634         <list, fnlist>: Add initializers.
5635         <obstack>: New member.
5636         (read_member_functions, read_struct_fields, read_baseclasses):
5637         Allocate on obstack.  Don't use cleanups.
5638         (read_one_struct_field, read_member_functions, read_struct_fields)
5639         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5640         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5641         (read_struct_type): Update.
5642
5643 2019-03-06  Tom Tromey  <tom@tromey.com>
5644
5645         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5646         * common/filestuff.h (make_cleanup_close): Don't declare.
5647         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5648         Remove.
5649
5650 2019-03-06  Tom Tromey  <tom@tromey.com>
5651
5652         * solib-aix.c: Use make_scope_exit.
5653
5654 2019-03-06  Tom Tromey  <tom@tromey.com>
5655
5656         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5657         Use make_scope_exit.
5658
5659 2019-03-06  Tom Tromey  <tom@tromey.com>
5660
5661         * solib-svr4.c (disable_probes_interface): Remove parameter.
5662         (svr4_handle_solib_event): Use make_scope_exit.
5663
5664 2019-03-06  Tom Tromey  <tom@tromey.com>
5665
5666         * remote.c (struct stop_reply_deleter): Remove.
5667         (stop_reply_up): Update.
5668         (struct stop_reply): Derive from notif_event.  Don't typedef.
5669         <regcache>: Now a std::vector.
5670         (stop_reply_xfree): Remove.
5671         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5672         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5673         (remote_target::discard_pending_stop_replies): Use delete.
5674         (remote_target::remote_parse_stop_reply): Update.
5675         (remote_target::process_stop_reply): Update.
5676         * remote-notif.h (struct notif_event): Add virtual destructor.
5677         Remove "dtr" member.
5678         (struct notif_client) <alloc_event>: Return a unique_ptr.
5679         (notif_event_xfree): Don't declare.
5680         (notif_event_up): New typedef.
5681         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5682         (notif_event_xfree, do_notif_event_xfree): Remove.
5683         (remote_notif_state_xfree): Update.
5684
5685 2019-03-06  Tom Tromey  <tom@tromey.com>
5686
5687         * infrun.c (displaced_step_clear_cleanup): Now a
5688         forward_scope_exit type.
5689         (displaced_step_prepare_throw): Update.
5690         (displaced_step_fixup): Update.
5691
5692 2019-03-06  Tom Tromey  <tom@tromey.com>
5693
5694         * inferior.h (class inferior): Update comment.
5695         * gdbthread.h (class thread_info): Update comment.
5696
5697 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5698             Tom Tromey  <tom@tromey.com>
5699
5700         * stabsread.h (struct stab_section_list): Remove.
5701         (coffstab_build_psymtabs): Update.
5702         * dbxread.c (symbuf_sections): Now a std::vector.
5703         (sect_idx): New global.
5704         (fill_symbuf): Update.
5705         (coffstab_build_psymtabs): Change type of stabsects parameter.
5706         Update.
5707         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5708         std::vector.
5709         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5710         (coff_locate_sections): Update.
5711         (coff_symfile_read): Remove cleanups.  Update.
5712         (init_stringtab): Add storage parameter.
5713         (free_stringtab, free_stringtab_cleanup): Remove.
5714         (init_lineno): Add storage parameter.
5715         (free_linetab, free_linetab_cleanup): Remove.
5716
5717 2019-03-06  Pedro Alves  <palves@redhat.com>
5718
5719         * linux-fork.c (fork_info::clobber_regs): Delete.
5720         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5721         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5722         comment.  Adjust.
5723         (scoped_switch_fork_info::scoped_switch_fork_info)
5724         (checkpoint_command, linux_fork_context): Adjust
5725         fork_save_infrun_state calls.
5726
5727 2019-03-06  Pedro Alves  <palves@redhat.com>
5728
5729         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5730         (inf_has_multiple_threads): Return 'bool' and rewrite using
5731         inferior_info::threads().
5732
5733 2019-03-06  Pedro Alves  <palves@redhat.com>
5734
5735         * linux-fork.c: Include <list>.
5736         (fork_list): Now a std::list instance.
5737         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5738         (forks_exist_p, find_last_fork): Adjust.
5739         (new_fork): Delete.
5740         (one_fork_p): New.
5741         (add_fork): Adjust.
5742         (free_fork): Delete, folded into fork_info::~fork_info().
5743         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5744         Adjust.
5745         (init_fork_list): Delete.
5746         (linux_fork_killall, linux_fork_mourn_inferior)
5747         (linux_fork_detach, info_checkpoints_command): Adjust.
5748         (_initialize_linux_fork): No longer call init_fork_list.
5749
5750 2019-03-06  Pedro Alves  <palves@redhat.com>
5751
5752         * linux-fork.c (new_fork): New, split out of ...
5753         (add_fork): ... this.  Return void.  Move "first fork" special
5754         case from here, to ...
5755         (checkpoint_command): ... here.
5756         * linux-linux.h (add_fork): Return void.
5757
5758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5759
5760         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5761
5762 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5763             Chris January  <chris.january@arm.com>
5764             David Lecomber  <david.lecomber@arm.com>
5765
5766         * f-exp.y: New token, UNOP_INTRINSIC.
5767         (exp): New pattern using UNOP_INTRINSIC token.
5768         (f77_keywords): Add 'abs' keyword.
5769         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5770         (value_from_host_double): New function.
5771         (evaluate_subexp_f): Support UNOP_ABS.
5772
5773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5774
5775         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5776         types.
5777
5778 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5779
5780         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5781         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5782         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5783
5784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5785
5786         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5787
5788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5789             Chris January  <chris.january@arm.com>
5790
5791         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5792         * f-exp.y: Define 'KIND' token.
5793         (exp): New pattern for KIND expressions.
5794         (ptype): Handle types with a kind extension.
5795         (direct_abs_decl): Extend to spot kind extensions.
5796         (f77_keywords): Add 'kind' to the list.
5797         (push_kind_type): New function.
5798         (convert_to_kind_type): New function.
5799         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5800         * parse.c (operator_length_standard): Likewise.
5801         * parser-defs.h (enum type_pieces): Add tp_kind.
5802         * std-operator.def: Add UNOP_KIND.
5803
5804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5805
5806         * f-exp.y (f_parse): Set yydebug.
5807
5808 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5809
5810         * f-lang.c (evaluate_subexp_f): New function.
5811         (exp_descriptor_f): New global.
5812         (f_language_defn): Use exp_descriptor_f instead of
5813         exp_descriptor_standard.
5814
5815 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * f-exp.y (struct token): Add comments.
5818         (dot_ops): Remove uppercase versions and the end marker.
5819         (f77_keywords): Likewise.
5820         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5821         entries in the dot_ops array are case insensitive, and use
5822         strncasecmp to compare strings.  Also some whitespace cleanup in
5823         this area.  Similar for the f77_keywords array, except entries in
5824         this list might be case sensitive.
5825
5826 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5827
5828         * f-exp.y (struct f77_boolean_val): Add comments.
5829         (boolean_values): Remove uppercase versions, and end marker.
5830         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5831         and use strncasecmp to achieve case insensitivity.  Additionally,
5832         perform whitespace cleanup around this code.
5833
5834 2019-03-06  Tom Tromey  <tromey@adacore.com>
5835
5836         * remote-sim.c (gdbsim_target_open): Use result of
5837         gdb_argv::release.
5838
5839 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5840         Dirk Schubert  <dirk.schubert@arm.com>
5841         Chris January  <chris.january@arm.com>
5842
5843         * eval.c (evaluate_subexp_standard): Call Fortran argument
5844         wrapping logic.
5845         * f-lang.c (struct value): A value which can be passed into a
5846         Fortran function call.
5847         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5848         where appropriate.
5849         (struct type): Value ready for a Fortran function call.
5850         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5851         is needed.
5852         * f-lang.h (fortran_argument_convert): Declaration.
5853         (fortran_preserve_arg_pointer): Declaration.
5854         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5855
5856 2019-03-05  Tom Tromey  <tromey@adacore.com>
5857
5858         * python/py-prettyprint.c (print_string_repr): Remove #if.
5859         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5860
5861 2019-03-05  Tom Tromey  <tromey@adacore.com>
5862
5863         * target.c (the_dummy_target): Move later.  Change type to
5864         "dummy_target".
5865         (initialize_targets): Don't initialize the_dummy_target.
5866
5867 2019-03-05  Tom Tromey  <tromey@adacore.com>
5868
5869         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5870         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5871
5872 2019-03-05  Tom Tromey  <tromey@adacore.com>
5873
5874         * windows-nat.c (windows_nat_target::attach)
5875         (windows_nat_target::detach): Don't call gdb_flush.
5876         * valprint.c (generic_val_print, val_print, val_print_string):
5877         Don't call gdb_flush.
5878         * utils.c (defaulted_query): Don't call gdb_flush.
5879         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5880         * target.c (target_announce_detach): Don't call gdb_flush.
5881         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5882         * remote.c (extended_remote_target::attach): Don't call
5883         gdb_flush.
5884         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5885         * printcmd.c (do_examine): Don't call gdb_flush.
5886         (info_display_command): Don't call gdb_flush.
5887         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5888         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5889         * memattr.c (info_mem_command): Don't call gdb_flush.
5890         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5891         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5892         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5893         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5894         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5895         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5896         (gnu_nat_target::detach): Don't call gdb_flush.
5897         * f-valprint.c (f_val_print): Don't call gdb_flush.
5898         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5899         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5900         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5901         gdb_flush.
5902         * c-valprint.c (c_val_print): Don't call gdb_flush.
5903         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5904
5905 2019-03-05  Tom Tromey  <tromey@adacore.com>
5906
5907         * varobj.c (update_dynamic_varobj_children): Update.
5908         (install_default_visualizer): Use reset, not release.
5909         * value.c (set_internalvar): Update.
5910         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5911         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5912         ATTRIBUTE_UNUSED_RESULT.
5913
5914 2019-03-05  Tom Tromey  <tromey@adacore.com>
5915
5916         * remote.c (class scoped_remote_fd) <release>: Add
5917         ATTRIBUTE_UNUSED_RESULT.
5918
5919 2019-03-05  Tom Tromey  <tromey@adacore.com>
5920
5921         * macroexp.c (struct macro_buffer) <release>: Add
5922         ATTRIBUTE_UNUSED_RESULT.
5923
5924 2019-03-05  Tom Tromey  <tromey@adacore.com>
5925
5926         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5927         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5928         ATTRIBUTE_UNUSED_RESULT.
5929
5930 2019-03-05  Tom Tromey  <tromey@adacore.com>
5931
5932         * common/scoped_fd.h (class scoped_fd) <release>: Add
5933         ATTRIBUTE_UNUSED_RESULT.
5934
5935 2019-03-05  Tom Tromey  <tromey@adacore.com>
5936
5937         * parser-defs.h (struct parser_state) <release>: Add
5938         ATTRIBUTE_UNUSED_RESULT.
5939
5940 2019-03-05  Tom Tromey  <tromey@adacore.com>
5941
5942         * utils.h (class gdb_argv) <release>: Add
5943         ATTRIBUTE_UNUSED_RESULT.
5944         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5945
5946 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5947
5948         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5949         for-loop range, to avoid compiler warnings.
5950
5951         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5952         avoid compiler warnings about unused variables.
5953
5954         * NEWS: Mention end of support for native debugging on MS-Windows
5955         before XP.
5956
5957         PR gdb/24292
5958         * common/netstuff.c:
5959         * gdbserver/gdbreplay.c
5960         * gdbserver/remote-utils.c:
5961         * ser-tcp.c:
5962         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5963         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5964         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5965         'getaddrinfo' and 'freeaddrinfo' were not available before
5966         Windows XP, and mingw.org's MinGW headers by default define
5967         _WIN32_WINNT to 0x500.
5968
5969 2019-03-01  Gary Benson <gbenson@redhat.com>
5970
5971         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5972
5973 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5974             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5975
5976         PR gdb/8527
5977         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5978         set_sigint_trap, clear_sigint_trap.
5979
5980 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5981
5982         * target.c (target_detach): Clear the regcache and the
5983         frame cache.
5984
5985 2019-02-27  Pedro Alves  <palves@redhat.com>
5986
5987         * utils.c (set_screen_size): When we cap the height/width sizes,
5988         tweak the corresponding command variable to show "unlimited":
5989
5990 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5991             Pedro Alves  <palves@redhat.com>
5992
5993         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5994         before calling rl_set_screen_size.
5995
5996 2019-02-27  Tom Tromey  <tromey@adacore.com>
5997
5998         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5999         define.
6000         * python/py-value.c: Remove Python 2.4 workaround.
6001         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6002         workaround.
6003         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6004         Python 2.4 workaround.
6005         * python/python-internal.h: Remove Python 2.4 comment.
6006         (Py_ssize_t): Don't define.
6007         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6008         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6009         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6010         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6011         * python/python.c (do_start_initialization): Remove Python 2.4
6012         workaround.
6013         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6014         (print_children): Remove Python 2.4 workaround.
6015         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6016         workaround.
6017         (CHARBUFFERPROC_NAME): Remove.
6018         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6019         Python 2.4 workaround.
6020
6021 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6022
6023         * NEWS: Note minimum Python version.
6024
6025 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6026
6027         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6028         code from these functions.  Remove corresponding ifdefs.  Use
6029         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6030         Remove gotos and target of gotos.
6031         (infpy_search_memory): Likewise.
6032
6033 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6034
6035         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6036         (hppa_gdbarch_init): Don't register deleted functions with
6037         gdbarch.
6038
6039 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6042         (h8300_unwind_sp): Delete.
6043         (h8300_dummy_id): Delete.
6044         (h8300_gdbarch_init): Don't register deleted functions with
6045         gdbarch.
6046
6047 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6048
6049         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6050         (ft32_unwind_pc): Delete.
6051         (ft32_unwind_sp): Delete.
6052         (ft32_gdbarch_init): Don't register deleted functions with
6053         gdbarch.
6054
6055 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6058         (frv_unwind_pc): Delete.
6059         (frv_unwind_sp): Delete.
6060         (frv_gdbarch_init): Don't register deleted functions with
6061         gdbarch.
6062
6063 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6064
6065         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6066         (riscv_unwind_pc): Delete.
6067         (riscv_unwind_sp): Delete.
6068         (riscv_gdbarch_init): Don't register deleted functions with
6069         gdbarch.
6070
6071 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6074         (csky_unwind_pc): Delete.
6075         (csky_unwind_sp): Delete.
6076         (csky_gdbarch_init): Don't register deleted functions with
6077         gdbarch.
6078
6079 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6082         (cris_unwind_pc): Delete.
6083         (cris_unwind_sp): Delete.
6084         (cris_gdbarch_init): Don't register deleted functions with
6085         gdbarch.
6086
6087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6088
6089         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6090         (bfin_unwind_pc): Delete.
6091         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6092
6093 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6094
6095         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6096         (arm_unwind_pc): Delete.
6097         (arm_unwind_sp): Delete.
6098         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6099
6100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6101
6102         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6103         (arc_unwind_pc): Delete.
6104         (arc_unwind_sp): Delete.
6105         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6106
6107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6108
6109         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6110         (alpha_unwind_pc): Delete.
6111         (alpha_gdbarch_init): Don't register deleted functions with
6112         gdbarch.
6113
6114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6117         (aarch64_unwind_pc): Delete.
6118         (aarch64_unwind_sp): Delete.
6119         (aarch64_gdbarch_init): Don't register deleted functions with
6120         gdbarch.
6121
6122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6123
6124         * gdbtypes.c (type_align): Don't consider static members when
6125         computing structure alignment.
6126
6127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6128
6129         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6130         return 0 for other types.
6131         * arch-utils.c (default_type_align): Always return 0.
6132         * gdbarch.h: Regenerate.
6133         * gdbarch.sh (type_align): Extend comment.
6134         * gdbtypes.c (type_align): Add additional comments, always call
6135         gdbarch_type_align before applying the default rules.
6136         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6137         generic code will then apply a suitable default.
6138         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6139         types, return 0 for other types.
6140
6141 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6142
6143         * NEWS: Create a new section for the next release branch.
6144         Rename the section of the current branch, now that it has
6145         been cut.
6146
6147 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6148
6149         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6150         * version.in: Bump version to 8.3.50.DATE-git.
6151
6152 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6153
6154         * aix-thread.c (ptid_cmp): Remove unused variable.
6155         (get_signaled_thread): Likewise.
6156         (store_regs_user_thread): Likewise.
6157         (store_regs_kernel_thread): Likewise.
6158         (fetch_regs_kernel_thread): Remove shadowed variable.
6159
6160 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6161
6162         * features/riscv/32bit-cpu.xml: Add register numbers.
6163         * features/riscv/32bit-fpu.c: Regenerate.
6164         * features/riscv/32bit-fpu.xml: Add register numbers.
6165         * features/riscv/64bit-cpu.xml: Add register numbers.
6166         * features/riscv/64bit-fpu.c: Regenerate.
6167         * features/riscv/64bit-fpu.xml: Add register numbers.
6168
6169 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6170
6171         * NEWS: Mention two argument form of gdb.Value constructor.
6172         * python/py-value.c (convert_buffer_and_type_to_value): New
6173         function.
6174         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6175         Add support for handling an optional second argument.  Call
6176         convert_buffer_and_type_to_value as appropriate.
6177         * python/python-internal.h (Py_buffer_deleter): New struct.
6178         (Py_buffer_up): New typedef.
6179
6180 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6181
6182         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6183         instead of releasing ownership.
6184
6185 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6186
6187         * dwarf2read.c (open_and_init_dwp_file): Call
6188         elf_numsections instead of bfd_count_sections to initialize
6189         dwp_file->num_sections.
6190
6191 2019-02-25  Tom Tromey  <tromey@adacore.com>
6192
6193         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6194
6195 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6196
6197         * gcore.in: Add '--readnever' option when invoking GDB.
6198
6199 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6200
6201         * MAINTAINERS: Update my email address.
6202
6203 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6204
6205         * build-id.c (build_id_to_debug_bfd_1): New function.
6206         (build_id_to_debug_bfd): Look for separate debug file in
6207         sysroot.
6208
6209 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6210
6211         * gdbarch.sh: Update the copyright year range that is placed into
6212         generated files.
6213
6214 2019-02-22  Keith Seitz  <keiths@redhat.com>
6215
6216         PR symtab/23853
6217         * linespec.c (create_sals_line_offset): Search for the default
6218         symtab's filename instead of its fullname.
6219
6220 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6221
6222         * NEWS: Update style defaults.
6223
6224 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6225
6226         * main.c (captured_main_1): Disable styling in batch mode.
6227
6228 2019-02-20  Tom Tromey  <tom@tromey.com>
6229
6230         * symtab.c (symtab_symbol_info): Fix typos.
6231
6232 2019-02-20  Tom Tromey  <tromey@adacore.com>
6233
6234         * findcmd.c (_initialize_mem_search): Use upper case for
6235         metasyntactic variables.
6236
6237 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6238
6239         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6240         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6241
6242 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6243
6244         * top.h (source_file_name): Change to std::string.
6245         * top.c (source_file_name): Likewise.
6246         (command_line_input): Adjust.
6247         * cli/cli-script.c (script_from_file): Adjust.
6248
6249 2019-02-19  Tom Tromey  <tromey@adacore.com>
6250
6251         * ravenscar-thread.c
6252         (ravenscar_thread_target::update_thread_list): Don't call
6253         ada_build_task_list.
6254         * ada-lang.h (ada_build_task_list): Don't declare.
6255         * ada-tasks.c (struct ada_tasks_inferior_data)
6256         <task_list_valid_p>: Now bool.
6257         (read_known_tasks, ada_task_list_changed)
6258         (ada_tasks_invalidate_inferior_data): Update.
6259         (read_known_tasks_array): Return bool.
6260         (read_known_tasks_list): Likewise.
6261         (read_known_tasks): Return void.
6262         (ada_build_task_list): Now static.
6263
6264 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6267         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6268
6269 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6270
6271         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6272         variant for ada_tasks_pspace_data_handle and
6273         ada_tasks_inferior_data_handle.
6274         (ada_tasks_pspace_data_cleanup): New function.
6275         (ada_tasks_inferior_data_cleanup): New function.
6276
6277 2019-02-17  Tom Tromey  <tom@tromey.com>
6278
6279         * macrotab.h (macro_source_fullname): Return a std::string.
6280         * macrotab.c (macro_include, check_for_redefinition)
6281         (macro_undef, macro_lookup_definition, foreach_macro)
6282         (foreach_macro_in_scope): Update.
6283         (macro_source_fullname): Return a std::string.
6284         * macrocmd.c (show_pp_source_pos): Update.
6285
6286 2019-02-17  Tom Tromey  <tom@tromey.com>
6287
6288         * macrocmd.c (show_pp_source_pos): Style the file names.
6289
6290 2019-02-17  Tom Tromey  <tom@tromey.com>
6291
6292         PR tui/24197:
6293         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6294
6295 2019-02-17  Tom Tromey  <tom@tromey.com>
6296
6297         * ada-lang.c (user_select_syms): Use filtered printing.
6298         * utils.c (wrap_style): New global.
6299         (desired_style): Remove.
6300         (emit_style_escape): Add stream parameter.
6301         (set_output_style, reset_terminal_style, prompt_for_continue):
6302         Update.
6303         (flush_wrap_buffer): Only flush gdb_stdout.
6304         (wrap_here): Set wrap_style.
6305         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6306         treat escape sequences as a character.  Change when wrap buffer is
6307         flushed.
6308         (fputs_styled): Do not set the output style when the default is
6309         requested.
6310         * ui-style.h (struct ui_file_style) <is_default>: New method.
6311         * source.c (print_source_lines_base): Emit escape sequences in one
6312         piece.
6313
6314 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6315
6316         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6317         integers and enumeration types.
6318
6319 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6320
6321         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6322         instead of lookup_symbol_in_language
6323         (do_exact_match): New function.
6324         (ada_get_symbol_name_matcher): Return do_exact_match when
6325         doing a verbatim match.
6326
6327 2019-02-15  Tom Tromey  <tromey@adacore.com>
6328
6329         * ravenscar-thread.c (ravenscar_thread_target::resume)
6330         (ravenscar_thread_target::wait): Special case wildcard requests.
6331
6332 2019-02-15  Tom Tromey  <tromey@adacore.com>
6333
6334         * ravenscar-thread.c (base_ptid): Remove.
6335         (struct ravenscar_thread_target) <close>: New method.
6336         <m_base_ptid>: New member.
6337         <update_inferior_ptid, active_task, task_is_currently_active,
6338         runtime_initialized>: Declare methods.
6339         <ravenscar_thread_target>: Add constructor.
6340         (ravenscar_thread_target::task_is_currently_active)
6341         (ravenscar_thread_target::update_inferior_ptid)
6342         (ravenscar_runtime_initialized): Rename.  Now methods.
6343         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6344         (ravenscar_thread_target::update_thread_list): Update.
6345         (ravenscar_thread_target::active_task): Now method.
6346         (ravenscar_thread_target::store_registers)
6347         (ravenscar_thread_target::prepare_to_store)
6348         (ravenscar_thread_target::prepare_to_store)
6349         (ravenscar_thread_target::mourn_inferior): Update.
6350         (ravenscar_inferior_created): Use "new" to create target.
6351         (ravenscar_thread_target::get_ada_task_ptid): Update.
6352         (_initialize_ravenscar): Don't initialize base_ptid.
6353         (ravenscar_ops): Remove global.
6354
6355 2019-02-15  Tom Tromey  <tromey@adacore.com>
6356
6357         * target.h (push_target): Declare new overload.
6358         * target.c (push_target): New overload, taking an rvalue reference.
6359         * remote.c (remote_target::open_1): Use push_target overload.
6360         * corelow.c (core_target_open): Use push_target overload.
6361
6362 2019-02-15  Tom Tromey  <tromey@adacore.com>
6363
6364         * ravenscar-thread.c (is_ravenscar_task)
6365         (ravenscar_task_is_currently_active): Return bool.
6366         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6367         (_initialize_ravenscar): Remove "(void)".
6368         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6369         Return bool.
6370
6371 2019-02-15  Tom Tromey  <tromey@adacore.com>
6372
6373         * ravenscar-thread.c (ravenscar_runtime_initializer)
6374         (has_ravenscar_runtime, get_running_thread_id)
6375         (ravenscar_thread_target::resume): Fix indentation.
6376
6377 2019-02-15  Tom Tromey  <tromey@adacore.com>
6378
6379         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6380         from ravenscar_arch_ops.
6381         (sparc_ravenscar_ops::fetch_registers)
6382         (sparc_ravenscar_ops::store_registers): Now methods.
6383         (sparc_ravenscar_prepare_to_store): Remove.
6384         (sparc_ravenscar_ops): Redefine.
6385         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6386         methods and destructor.  Remove members.
6387         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6388         (ravenscar_thread_target::store_registers)
6389         (ravenscar_thread_target::prepare_to_store): Update.
6390         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6391         Remove.
6392         (struct ppc_ravenscar_powerpc_ops): Derive from
6393         ravenscar_arch_ops.
6394         (ppc_ravenscar_powerpc_ops::fetch_registers)
6395         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6396         (ppc_ravenscar_powerpc_ops): Redefine.
6397         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6398         (ppc_ravenscar_e500_ops::fetch_registers)
6399         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6400         (ppc_ravenscar_e500_ops): Redefine.
6401         * aarch64-ravenscar-thread.c
6402         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6403         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6404         (aarch64_ravenscar_fetch_registers)
6405         (aarch64_ravenscar_store_registers): Now methods.
6406         (aarch64_ravenscar_ops): Redefine.
6407
6408 2019-02-15  Tom Tromey  <tromey@adacore.com>
6409
6410         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6411         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6412         (ravenscar_thread_target::stopped_by_watchpoint)
6413         (ravenscar_thread_target::stopped_data_address)
6414         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6415
6416 2019-02-15  Tom Tromey  <tromey@adacore.com>
6417
6418         * ravenscar-thread.c: Fix some typos.
6419
6420 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6421             Tom Tromey  <tromey@adacore.com>
6422
6423         * ada-lang.c (ada_exception_sal): Change addr_string to a
6424         std::string.
6425         (create_ada_exception_catchpoint): Update.
6426
6427 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6428             Tom Tromey  <tromey@adacore.com>
6429
6430         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6431         (bp_location_ops): Remove.
6432         (base_breakpoint_allocate_location): Update.
6433         (free_bp_location): Update.
6434         * ada-lang.c (class ada_catchpoint_location)
6435         <ada_catchpoint_location>: Remove ops parameter.
6436         (ada_catchpoint_location_dtor): Remove.
6437         (ada_catchpoint_location_ops): Remove.
6438         (allocate_location_exception): Update.
6439         * breakpoint.h (struct bp_location_ops): Remove.
6440         (class bp_location) <bp_location>: Remove bp_location_ops
6441         parameter.
6442         <~bp_location>: Add destructor.
6443         <ops>: Remove.
6444
6445 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6446             Pedro Alves  <palves@redhat.com>
6447
6448         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6449         'PATH_MAX'.
6450
6451 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6452             Samuel Thibault  <samuel.thibault@gnu.org>
6453             Thomas Schwinge  <thomas@codesourcery.com>
6454
6455         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6456         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6457
6458 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6459
6460         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6461         (check_empty): Use "const char *".
6462
6463         * gnu-nat.c (gnu_nat_target::detach): Instead of
6464         'detach_inferior (pid)' call
6465         'detach_inferior (find_inferior_pid (pid))'.
6466
6467         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6468         'nat/fork-inferior.o'.
6469         * gnu-nat.c: #include "nat/fork-inferior.h".
6470
6471         * gnu-nat.c (gnu_nat_target::detach): Instead of
6472         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6473         * gnu-nat.h: #include "inf-child.h".
6474         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6475         'i386_gnu_nat_target::fetch_registers'.
6476         (gnu_store_registers): Rename/move to
6477         'i386_gnu_nat_target::store_registers'.
6478
6479         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6480         * gnu-nat.h (mach_thread_info): New function.
6481         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6482
6483         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6484
6485 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6486
6487         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6488
6489 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6490
6491         * windows-nat.c (windows_add_thread): Add new parameter
6492         "main_thread_p" with default value set to false.  Update
6493         function documentation as well as all callers.
6494         (windows_delete_thread): Likewise.
6495         (fake_create_process): Update call to windows_add_thread.
6496         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6497         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6498         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6499         call to windows_delete_thread.
6500
6501 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6502
6503         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6504
6505 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6506
6507         * symfile.c (find_separate_debug_file): Use canonical path of
6508         sysroot with child_path instead of gdb_sysroot if it is valid.
6509
6510 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6511
6512         * symfile.c (find_separate_debug_file): Use child_path to
6513         determine if an object file is under a sysroot.
6514
6515 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6516
6517         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6518         unittests/child-path-selftests.c.
6519         * common/pathstuff.c (child_path): New function.
6520         * common/pathstuff.h (child_path): New prototype.
6521         * unittests/child-path-selftests.c: New file.
6522
6523 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6524
6525         * symfile.c (find_separate_debug_file): Look for separate debug
6526         files in debug directories under the sysroot.
6527
6528 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6529
6530         * symtab.h (struct minimal_symbol data_p): New const method.
6531         (struct minimal_symbol text_p): Likewise.
6532         * symtab.c (output_source_filename): Use file name style
6533         to print file name.
6534         (print_symbol_info): Likewise.
6535         (print_msymbol_info): Use address style to print addresses.
6536         Use function name style to print executable text symbols.
6537         (expand_symtab_containing_pc): Use data_p.
6538         (find_pc_sect_compunit_symtab): Likewise.
6539
6540 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6541
6542         * breakpoint.c (describe_other_breakpoints): Use address style
6543         to print addresses.
6544         (say_where): Likewise.
6545
6546 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6547
6548         * ada-typeprint.c (print_func_type): Print function name
6549         style to print function name.
6550         * c-typeprint.c (c_print_type_1): Likewise.
6551
6552 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6553
6554         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6555         for execve.
6556
6557 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6558
6559         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6560         type_stack.
6561
6562 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6563
6564         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6565         TYPE_CODE_REF types.
6566
6567 2019-02-08  Jim Wilson  <jimw@sifive.com>
6568
6569         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6570         (riscv_linux_fregset): New.
6571         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6572
6573 2019-02-07  Tom Tromey  <tom@tromey.com>
6574
6575         * thread.c (thread_cancel_execution_command): Update.
6576         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6577         methods.
6578         (struct thread_fsm_ops): Remove.
6579         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6580         (thread_fsm_should_stop, thread_fsm_return_value)
6581         (thread_fsm_set_finished, thread_fsm_finished_p)
6582         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6583         Don't declare.
6584         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6585         * infrun.c (clear_proceed_status_thread)
6586         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6587         (print_stop_event): Update.
6588         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6589         Add constructor.
6590         (step_command_fsm_ops): Remove.
6591         (new_step_command_fsm): Remove.
6592         (step_1): Update.
6593         (step_command_fsm::should_stop): Rename from
6594         step_command_fsm_should_stop.
6595         (step_command_fsm::clean_up): Rename from
6596         step_command_fsm_clean_up.
6597         (step_command_fsm::do_async_reply_reason): Rename from
6598         step_command_fsm_async_reply_reason.
6599         (struct until_next_fsm): Inherit from thread_fsm.  Add
6600         constructor.
6601         (until_next_fsm_ops): Remove.
6602         (new_until_next_fsm): Remove.
6603         (until_next_fsm::should_stop): Rename from
6604         until_next_fsm_should_stop.
6605         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6606         (until_next_fsm::do_async_reply_reason): Rename from
6607         until_next_fsm_async_reply_reason.
6608         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6609         constructor.  Change type of breakpoint.
6610         (finish_command_fsm_ops): Remove.
6611         (new_finish_command_fsm): Remove.
6612         (finish_command_fsm::should_stop): Rename from
6613         finish_command_fsm_should_stop.
6614         (finish_command_fsm::clean_up): Rename from
6615         finish_command_fsm_clean_up.
6616         (finish_command_fsm::return_value): Rename from
6617         finish_command_fsm_return_value.
6618         (finish_command_fsm::do_async_reply_reason): Rename from
6619         finish_command_fsm_async_reply_reason.
6620         (finish_command): Update.
6621         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6622         Add constructor.
6623         (call_thread_fsm_ops): Remove.
6624         (call_thread_fsm::call_thread_fsm): Rename from
6625         new_call_thread_fsm.
6626         (call_thread_fsm::should_stop): Rename from
6627         call_thread_fsm_should_stop.
6628         (call_thread_fsm::should_notify_stop): Rename from
6629         call_thread_fsm_should_notify_stop.
6630         (run_inferior_call, call_function_by_hand_dummy): Update.
6631         * cli/cli-interp.c (should_print_stop_to_console): Update.
6632         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6633         Add constructor.  Change type of location_breakpoint,
6634         caller_breakpoint.
6635         (until_break_fsm_ops): Remove.
6636         (new_until_break_fsm): Remove.
6637         (until_break_fsm::should_stop): Rename from
6638         until_break_fsm_should_stop.
6639         (until_break_fsm::clean_up): Rename from
6640         until_break_fsm_clean_up.
6641         (until_break_fsm::do_async_reply_reason): Rename from
6642         until_break_fsm_async_reply_reason.
6643         (until_break_command): Update.
6644         * thread-fsm.c: Remove.
6645         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6646
6647 2019-02-07  Tom Tromey  <tom@tromey.com>
6648
6649         * yy-remap.h: Add include guard.
6650         * xtensa-tdep.h: Add include guard.
6651         * xcoffread.h: Rename include guard.
6652         * varobj-iter.h: Add include guard.
6653         * tui/tui.h: Rename include guard.
6654         * tui/tui-winsource.h: Rename include guard.
6655         * tui/tui-wingeneral.h: Rename include guard.
6656         * tui/tui-windata.h: Rename include guard.
6657         * tui/tui-win.h: Rename include guard.
6658         * tui/tui-stack.h: Rename include guard.
6659         * tui/tui-source.h: Rename include guard.
6660         * tui/tui-regs.h: Rename include guard.
6661         * tui/tui-out.h: Rename include guard.
6662         * tui/tui-layout.h: Rename include guard.
6663         * tui/tui-io.h: Rename include guard.
6664         * tui/tui-hooks.h: Rename include guard.
6665         * tui/tui-file.h: Rename include guard.
6666         * tui/tui-disasm.h: Rename include guard.
6667         * tui/tui-data.h: Rename include guard.
6668         * tui/tui-command.h: Rename include guard.
6669         * tic6x-tdep.h: Add include guard.
6670         * target/waitstatus.h: Rename include guard.
6671         * target/wait.h: Rename include guard.
6672         * target/target.h: Rename include guard.
6673         * target/resume.h: Rename include guard.
6674         * target-float.h: Rename include guard.
6675         * stabsread.h: Add include guard.
6676         * rs6000-tdep.h: Add include guard.
6677         * riscv-fbsd-tdep.h: Add include guard.
6678         * regformats/regdef.h: Rename include guard.
6679         * record.h: Rename include guard.
6680         * python/python.h: Rename include guard.
6681         * python/python-internal.h: Rename include guard.
6682         * python/py-stopevent.h: Rename include guard.
6683         * python/py-ref.h: Rename include guard.
6684         * python/py-record.h: Rename include guard.
6685         * python/py-record-full.h: Rename include guard.
6686         * python/py-record-btrace.h: Rename include guard.
6687         * python/py-instruction.h: Rename include guard.
6688         * python/py-events.h: Rename include guard.
6689         * python/py-event.h: Rename include guard.
6690         * procfs.h: Add include guard.
6691         * proc-utils.h: Add include guard.
6692         * p-lang.h: Add include guard.
6693         * or1k-tdep.h: Rename include guard.
6694         * observable.h: Rename include guard.
6695         * nto-tdep.h: Rename include guard.
6696         * nat/x86-linux.h: Rename include guard.
6697         * nat/x86-linux-dregs.h: Rename include guard.
6698         * nat/x86-gcc-cpuid.h: Add include guard.
6699         * nat/x86-dregs.h: Rename include guard.
6700         * nat/x86-cpuid.h: Rename include guard.
6701         * nat/ppc-linux.h: Rename include guard.
6702         * nat/mips-linux-watch.h: Rename include guard.
6703         * nat/linux-waitpid.h: Rename include guard.
6704         * nat/linux-ptrace.h: Rename include guard.
6705         * nat/linux-procfs.h: Rename include guard.
6706         * nat/linux-osdata.h: Rename include guard.
6707         * nat/linux-nat.h: Rename include guard.
6708         * nat/linux-namespaces.h: Rename include guard.
6709         * nat/linux-btrace.h: Rename include guard.
6710         * nat/glibc_thread_db.h: Rename include guard.
6711         * nat/gdb_thread_db.h: Rename include guard.
6712         * nat/gdb_ptrace.h: Rename include guard.
6713         * nat/fork-inferior.h: Rename include guard.
6714         * nat/amd64-linux-siginfo.h: Rename include guard.
6715         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6716         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6717         * nat/aarch64-linux.h: Rename include guard.
6718         * nat/aarch64-linux-hw-point.h: Rename include guard.
6719         * mn10300-tdep.h: Add include guard.
6720         * mips-linux-tdep.h: Add include guard.
6721         * mi/mi-parse.h: Rename include guard.
6722         * mi/mi-out.h: Rename include guard.
6723         * mi/mi-main.h: Rename include guard.
6724         * mi/mi-interp.h: Rename include guard.
6725         * mi/mi-getopt.h: Rename include guard.
6726         * mi/mi-console.h: Rename include guard.
6727         * mi/mi-common.h: Rename include guard.
6728         * mi/mi-cmds.h: Rename include guard.
6729         * mi/mi-cmd-break.h: Rename include guard.
6730         * m2-lang.h: Add include guard.
6731         * location.h: Rename include guard.
6732         * linux-record.h: Rename include guard.
6733         * linux-nat.h: Add include guard.
6734         * linux-fork.h: Add include guard.
6735         * i386-darwin-tdep.h: Rename include guard.
6736         * hppa-linux-offsets.h: Add include guard.
6737         * guile/guile.h: Rename include guard.
6738         * guile/guile-internal.h: Rename include guard.
6739         * gnu-nat.h: Rename include guard.
6740         * gdb-stabs.h: Rename include guard.
6741         * frv-tdep.h: Add include guard.
6742         * f-lang.h: Add include guard.
6743         * event-loop.h: Add include guard.
6744         * darwin-nat.h: Rename include guard.
6745         * cp-abi.h: Rename include guard.
6746         * config/sparc/nm-sol2.h: Rename include guard.
6747         * config/nm-nto.h: Rename include guard.
6748         * config/nm-linux.h: Add include guard.
6749         * config/i386/nm-i386gnu.h: Rename include guard.
6750         * config/djgpp/nl_types.h: Rename include guard.
6751         * config/djgpp/langinfo.h: Rename include guard.
6752         * compile/gcc-cp-plugin.h: Add include guard.
6753         * compile/gcc-c-plugin.h: Add include guard.
6754         * compile/compile.h: Rename include guard.
6755         * compile/compile-object-run.h: Rename include guard.
6756         * compile/compile-object-load.h: Rename include guard.
6757         * compile/compile-internal.h: Rename include guard.
6758         * compile/compile-cplus.h: Rename include guard.
6759         * compile/compile-c.h: Rename include guard.
6760         * common/xml-utils.h: Rename include guard.
6761         * common/x86-xstate.h: Rename include guard.
6762         * common/version.h: Rename include guard.
6763         * common/vec.h: Rename include guard.
6764         * common/tdesc.h: Rename include guard.
6765         * common/selftest.h: Rename include guard.
6766         * common/scoped_restore.h: Rename include guard.
6767         * common/scoped_mmap.h: Rename include guard.
6768         * common/scoped_fd.h: Rename include guard.
6769         * common/safe-iterator.h: Rename include guard.
6770         * common/run-time-clock.h: Rename include guard.
6771         * common/refcounted-object.h: Rename include guard.
6772         * common/queue.h: Rename include guard.
6773         * common/ptid.h: Rename include guard.
6774         * common/print-utils.h: Rename include guard.
6775         * common/preprocessor.h: Rename include guard.
6776         * common/pathstuff.h: Rename include guard.
6777         * common/observable.h: Rename include guard.
6778         * common/netstuff.h: Rename include guard.
6779         * common/job-control.h: Rename include guard.
6780         * common/host-defs.h: Rename include guard.
6781         * common/gdb_wait.h: Rename include guard.
6782         * common/gdb_vecs.h: Rename include guard.
6783         * common/gdb_unlinker.h: Rename include guard.
6784         * common/gdb_unique_ptr.h: Rename include guard.
6785         * common/gdb_tilde_expand.h: Rename include guard.
6786         * common/gdb_sys_time.h: Rename include guard.
6787         * common/gdb_string_view.h: Rename include guard.
6788         * common/gdb_splay_tree.h: Rename include guard.
6789         * common/gdb_setjmp.h: Rename include guard.
6790         * common/gdb_ref_ptr.h: Rename include guard.
6791         * common/gdb_optional.h: Rename include guard.
6792         * common/gdb_locale.h: Rename include guard.
6793         * common/gdb_assert.h: Rename include guard.
6794         * common/filtered-iterator.h: Rename include guard.
6795         * common/filestuff.h: Rename include guard.
6796         * common/fileio.h: Rename include guard.
6797         * common/environ.h: Rename include guard.
6798         * common/common-utils.h: Rename include guard.
6799         * common/common-types.h: Rename include guard.
6800         * common/common-regcache.h: Rename include guard.
6801         * common/common-inferior.h: Rename include guard.
6802         * common/common-gdbthread.h: Rename include guard.
6803         * common/common-exceptions.h: Rename include guard.
6804         * common/common-defs.h: Rename include guard.
6805         * common/common-debug.h: Rename include guard.
6806         * common/cleanups.h: Rename include guard.
6807         * common/buffer.h: Rename include guard.
6808         * common/btrace-common.h: Rename include guard.
6809         * common/break-common.h: Rename include guard.
6810         * cli/cli-utils.h: Rename include guard.
6811         * cli/cli-style.h: Rename include guard.
6812         * cli/cli-setshow.h: Rename include guard.
6813         * cli/cli-script.h: Rename include guard.
6814         * cli/cli-interp.h: Rename include guard.
6815         * cli/cli-decode.h: Rename include guard.
6816         * cli/cli-cmds.h: Rename include guard.
6817         * charset-list.h: Add include guard.
6818         * buildsym-legacy.h: Rename include guard.
6819         * bfin-tdep.h: Add include guard.
6820         * ax.h: Rename include guard.
6821         * arm-linux-tdep.h: Add include guard.
6822         * arm-fbsd-tdep.h: Add include guard.
6823         * arch/xtensa.h: Rename include guard.
6824         * arch/tic6x.h: Add include guard.
6825         * arch/i386.h: Add include guard.
6826         * arch/arm.h: Rename include guard.
6827         * arch/arm-linux.h: Rename include guard.
6828         * arch/arm-get-next-pcs.h: Rename include guard.
6829         * arch/amd64.h: Add include guard.
6830         * arch/aarch64-insn.h: Rename include guard.
6831         * arch-utils.h: Rename include guard.
6832         * annotate.h: Add include guard.
6833         * amd64-darwin-tdep.h: Rename include guard.
6834         * aarch64-linux-tdep.h: Add include guard.
6835         * aarch64-fbsd-tdep.h: Add include guard.
6836         * aarch32-linux-nat.h: Add include guard.
6837
6838 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6839
6840         * macrotab.c (macro_define_internal): New function that
6841         factorizes macro_define_object_internal and macro_define_function
6842         code.
6843         (macro_define_object_internal): Use macro_define_internal.
6844         (macro_define_function): Likewise.
6845
6846 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6847
6848         * macrocmd.c (extract_identifier): Return
6849         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6850         callers.
6851
6852 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6853
6854         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6855
6856 2019-02-05  Tom Tromey  <tom@tromey.com>
6857
6858         * target.c (target_stack::unpush): Move assertion earlier.
6859
6860 2019-01-30  Tom Tromey  <tom@tromey.com>
6861
6862         PR python/23615:
6863         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6864         (gdbpy_parse_and_eval): Likewise.
6865         * python/python-internal.h (gdbpy_allow_threads): New class.
6866
6867 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6868
6869         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6870         (aarch64_fbsd_fpregmap): Move earlier.
6871         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6872         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6873         instead of individual calls to trad_frame_set_reg_addr.
6874         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6875         earlier.
6876         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6877         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6878         instead of individual calls to trad_frame_set_reg_addr.
6879
6880 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6881
6882         * CONTRIBUTE: Replace contribution list with wiki link.
6883
6884 2019-01-25  Tom Tromey  <tom@tromey.com>
6885
6886         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6887
6888 2019-01-25  Tom Tromey  <tom@tromey.com>
6889
6890         * xtensa-linux-nat.c: Fix common/ includes.
6891         * xml-support.h: Fix common/ includes.
6892         * xml-support.c: Fix common/ includes.
6893         * x86-linux-nat.c: Fix common/ includes.
6894         * windows-nat.c: Fix common/ includes.
6895         * varobj.h: Fix common/ includes.
6896         * varobj.c: Fix common/ includes.
6897         * value.c: Fix common/ includes.
6898         * valops.c: Fix common/ includes.
6899         * utils.c: Fix common/ includes.
6900         * unittests/xml-utils-selftests.c: Fix common/ includes.
6901         * unittests/utils-selftests.c: Fix common/ includes.
6902         * unittests/unpack-selftests.c: Fix common/ includes.
6903         * unittests/tracepoint-selftests.c: Fix common/ includes.
6904         * unittests/style-selftests.c: Fix common/ includes.
6905         * unittests/string_view-selftests.c: Fix common/ includes.
6906         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6907         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6908         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6909         * unittests/rsp-low-selftests.c: Fix common/ includes.
6910         * unittests/parse-connection-spec-selftests.c: Fix common/
6911         includes.
6912         * unittests/optional-selftests.c: Fix common/ includes.
6913         * unittests/offset-type-selftests.c: Fix common/ includes.
6914         * unittests/observable-selftests.c: Fix common/ includes.
6915         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6916         * unittests/memrange-selftests.c: Fix common/ includes.
6917         * unittests/memory-map-selftests.c: Fix common/ includes.
6918         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6919         * unittests/function-view-selftests.c: Fix common/ includes.
6920         * unittests/environ-selftests.c: Fix common/ includes.
6921         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6922         * unittests/common-utils-selftests.c: Fix common/ includes.
6923         * unittests/cli-utils-selftests.c: Fix common/ includes.
6924         * unittests/array-view-selftests.c: Fix common/ includes.
6925         * ui-file.c: Fix common/ includes.
6926         * tui/tui-io.c: Fix common/ includes.
6927         * tracepoint.h: Fix common/ includes.
6928         * tracepoint.c: Fix common/ includes.
6929         * tracefile-tfile.c: Fix common/ includes.
6930         * top.h: Fix common/ includes.
6931         * top.c: Fix common/ includes.
6932         * thread.c: Fix common/ includes.
6933         * target/waitstatus.h: Fix common/ includes.
6934         * target/waitstatus.c: Fix common/ includes.
6935         * target.h: Fix common/ includes.
6936         * target.c: Fix common/ includes.
6937         * target-memory.c: Fix common/ includes.
6938         * target-descriptions.c: Fix common/ includes.
6939         * symtab.h: Fix common/ includes.
6940         * symfile.c: Fix common/ includes.
6941         * stap-probe.c: Fix common/ includes.
6942         * spu-linux-nat.c: Fix common/ includes.
6943         * sparc-nat.c: Fix common/ includes.
6944         * source.c: Fix common/ includes.
6945         * solib.c: Fix common/ includes.
6946         * solib-target.c: Fix common/ includes.
6947         * ser-unix.c: Fix common/ includes.
6948         * ser-tcp.c: Fix common/ includes.
6949         * ser-pipe.c: Fix common/ includes.
6950         * ser-base.c: Fix common/ includes.
6951         * selftest-arch.c: Fix common/ includes.
6952         * s12z-tdep.c: Fix common/ includes.
6953         * rust-exp.y: Fix common/ includes.
6954         * rs6000-aix-tdep.c: Fix common/ includes.
6955         * riscv-tdep.c: Fix common/ includes.
6956         * remote.c: Fix common/ includes.
6957         * remote-notif.h: Fix common/ includes.
6958         * remote-fileio.h: Fix common/ includes.
6959         * remote-fileio.c: Fix common/ includes.
6960         * regcache.h: Fix common/ includes.
6961         * regcache.c: Fix common/ includes.
6962         * record-btrace.c: Fix common/ includes.
6963         * python/python.c: Fix common/ includes.
6964         * python/py-type.c: Fix common/ includes.
6965         * python/py-inferior.c: Fix common/ includes.
6966         * progspace.h: Fix common/ includes.
6967         * producer.c: Fix common/ includes.
6968         * procfs.c: Fix common/ includes.
6969         * proc-api.c: Fix common/ includes.
6970         * printcmd.c: Fix common/ includes.
6971         * ppc-linux-nat.c: Fix common/ includes.
6972         * parser-defs.h: Fix common/ includes.
6973         * osdata.c: Fix common/ includes.
6974         * obsd-nat.c: Fix common/ includes.
6975         * nat/x86-linux.c: Fix common/ includes.
6976         * nat/x86-linux-dregs.c: Fix common/ includes.
6977         * nat/x86-dregs.h: Fix common/ includes.
6978         * nat/x86-dregs.c: Fix common/ includes.
6979         * nat/ppc-linux.c: Fix common/ includes.
6980         * nat/mips-linux-watch.h: Fix common/ includes.
6981         * nat/mips-linux-watch.c: Fix common/ includes.
6982         * nat/linux-waitpid.c: Fix common/ includes.
6983         * nat/linux-ptrace.h: Fix common/ includes.
6984         * nat/linux-ptrace.c: Fix common/ includes.
6985         * nat/linux-procfs.c: Fix common/ includes.
6986         * nat/linux-personality.c: Fix common/ includes.
6987         * nat/linux-osdata.c: Fix common/ includes.
6988         * nat/linux-namespaces.c: Fix common/ includes.
6989         * nat/linux-btrace.h: Fix common/ includes.
6990         * nat/linux-btrace.c: Fix common/ includes.
6991         * nat/fork-inferior.c: Fix common/ includes.
6992         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6993         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6994         * nat/aarch64-linux.c: Fix common/ includes.
6995         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6996         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6997         * namespace.h: Fix common/ includes.
6998         * mips-linux-tdep.c: Fix common/ includes.
6999         * minsyms.c: Fix common/ includes.
7000         * mi/mi-parse.h: Fix common/ includes.
7001         * mi/mi-main.c: Fix common/ includes.
7002         * mi/mi-cmd-env.c: Fix common/ includes.
7003         * memrange.h: Fix common/ includes.
7004         * memattr.c: Fix common/ includes.
7005         * maint.h: Fix common/ includes.
7006         * maint.c: Fix common/ includes.
7007         * main.c: Fix common/ includes.
7008         * machoread.c: Fix common/ includes.
7009         * location.c: Fix common/ includes.
7010         * linux-thread-db.c: Fix common/ includes.
7011         * linux-nat.c: Fix common/ includes.
7012         * linux-fork.c: Fix common/ includes.
7013         * inline-frame.c: Fix common/ includes.
7014         * infrun.c: Fix common/ includes.
7015         * inflow.c: Fix common/ includes.
7016         * inferior.h: Fix common/ includes.
7017         * inferior.c: Fix common/ includes.
7018         * infcmd.c: Fix common/ includes.
7019         * inf-ptrace.c: Fix common/ includes.
7020         * inf-child.c: Fix common/ includes.
7021         * ia64-linux-nat.c: Fix common/ includes.
7022         * i387-tdep.c: Fix common/ includes.
7023         * i386-tdep.c: Fix common/ includes.
7024         * i386-linux-tdep.c: Fix common/ includes.
7025         * i386-linux-nat.c: Fix common/ includes.
7026         * i386-go32-tdep.c: Fix common/ includes.
7027         * i386-fbsd-tdep.c: Fix common/ includes.
7028         * i386-fbsd-nat.c: Fix common/ includes.
7029         * guile/scm-type.c: Fix common/ includes.
7030         * guile/guile.c: Fix common/ includes.
7031         * go32-nat.c: Fix common/ includes.
7032         * gnu-nat.c: Fix common/ includes.
7033         * gdbthread.h: Fix common/ includes.
7034         * gdbarch-selftests.c: Fix common/ includes.
7035         * gdb_usleep.c: Fix common/ includes.
7036         * gdb_select.h: Fix common/ includes.
7037         * gdb_bfd.c: Fix common/ includes.
7038         * gcore.c: Fix common/ includes.
7039         * fork-child.c: Fix common/ includes.
7040         * findvar.c: Fix common/ includes.
7041         * fbsd-nat.c: Fix common/ includes.
7042         * event-top.c: Fix common/ includes.
7043         * event-loop.c: Fix common/ includes.
7044         * dwarf2read.c: Fix common/ includes.
7045         * dwarf2loc.c: Fix common/ includes.
7046         * dwarf2-frame.c: Fix common/ includes.
7047         * dwarf-index-cache.c: Fix common/ includes.
7048         * dtrace-probe.c: Fix common/ includes.
7049         * disasm-selftests.c: Fix common/ includes.
7050         * defs.h: Fix common/ includes.
7051         * csky-tdep.c: Fix common/ includes.
7052         * cp-valprint.c: Fix common/ includes.
7053         * cp-support.h: Fix common/ includes.
7054         * cp-support.c: Fix common/ includes.
7055         * corelow.c: Fix common/ includes.
7056         * completer.h: Fix common/ includes.
7057         * completer.c: Fix common/ includes.
7058         * compile/compile.c: Fix common/ includes.
7059         * compile/compile-loc2c.c: Fix common/ includes.
7060         * compile/compile-cplus-types.c: Fix common/ includes.
7061         * compile/compile-cplus-symbols.c: Fix common/ includes.
7062         * command.h: Fix common/ includes.
7063         * cli/cli-dump.c: Fix common/ includes.
7064         * cli/cli-cmds.c: Fix common/ includes.
7065         * charset.c: Fix common/ includes.
7066         * build-id.c: Fix common/ includes.
7067         * btrace.h: Fix common/ includes.
7068         * btrace.c: Fix common/ includes.
7069         * breakpoint.h: Fix common/ includes.
7070         * breakpoint.c: Fix common/ includes.
7071         * ax.h:
7072         (enum agent_op): Fix common/ includes.
7073         * ax-general.c (struct aop_map): Fix common/ includes.
7074         * ax-gdb.c: Fix common/ includes.
7075         * auxv.c: Fix common/ includes.
7076         * auto-load.c: Fix common/ includes.
7077         * arm-tdep.c: Fix common/ includes.
7078         * arch/riscv.c: Fix common/ includes.
7079         * arch/ppc-linux-common.c: Fix common/ includes.
7080         * arch/i386.c: Fix common/ includes.
7081         * arch/arm.c: Fix common/ includes.
7082         * arch/arm-linux.c: Fix common/ includes.
7083         * arch/arm-get-next-pcs.c: Fix common/ includes.
7084         * arch/amd64.c: Fix common/ includes.
7085         * arch/aarch64.c: Fix common/ includes.
7086         * arch/aarch64-insn.c: Fix common/ includes.
7087         * arch-utils.c: Fix common/ includes.
7088         * amd64-windows-tdep.c: Fix common/ includes.
7089         * amd64-tdep.c: Fix common/ includes.
7090         * amd64-sol2-tdep.c: Fix common/ includes.
7091         * amd64-obsd-tdep.c: Fix common/ includes.
7092         * amd64-nbsd-tdep.c: Fix common/ includes.
7093         * amd64-linux-tdep.c: Fix common/ includes.
7094         * amd64-linux-nat.c: Fix common/ includes.
7095         * amd64-fbsd-tdep.c: Fix common/ includes.
7096         * amd64-fbsd-nat.c: Fix common/ includes.
7097         * amd64-dicos-tdep.c: Fix common/ includes.
7098         * amd64-darwin-tdep.c: Fix common/ includes.
7099         * agent.c: Fix common/ includes.
7100         * ada-lang.h: Fix common/ includes.
7101         * ada-lang.c: Fix common/ includes.
7102         * aarch64-tdep.c: Fix common/ includes.
7103
7104 2019-01-25  Tom Tromey  <tom@tromey.com>
7105
7106         * common/create-version.sh: Use common/version.h.
7107
7108 2019-01-24  Pedro Alves  <palves@redhat.com>
7109
7110         * infrun.c (signal_stop, signal_print, signal_program)
7111         (signal_catch, signal_pass): Now arrays instead of pointers.
7112         (update_signals_program_target, do_target_resume)
7113         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7114         * linux-nat.c (linux_nat_target::pass_signals)
7115         (linux_nat_target::create_inferior, linux_nat_target::attach):
7116         Adjust.
7117         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7118         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7119         * procfs.c (procfs_target::pass_signals): Adjust.
7120         * record-full.c (record_full_target::resume): Adjust.
7121         * remote.c (remote_target::pass_signals)
7122         (remote_target::program_signals): Adjust.
7123         * target-debug.h (target_debug_print_signals): Now takes a
7124         gdb::array_view as parameter.  Adjust.
7125         * target.h (target_ops) <pass_signals, program_signals>: Replace
7126         pointer and length parameters with gdb::array_view.
7127         (target_pass_signals, target_program_signals): Likewise.
7128         * target-delegates.c: Regenerate.
7129
7130 2019-01-24  Pedro Alves  <palves@redhat.com>
7131
7132         * common/forward-scope-exit.h
7133         (forward_scope_exit::forward_scope_exit): Pass arguments to
7134         m_bind_function directly, instead of creating a std::bind and
7135         copying that.
7136
7137 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7138
7139         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7140         for static members.
7141         (pass_in_v_vfp_candidate): Likewise.
7142
7143 2019-01-23  Tom Tromey  <tom@tromey.com>
7144             Pedro Alves  <palves@redhat.com>
7145
7146         * regcache.c (class regcache_invalidator): Remove.
7147         (regcache::raw_write): Use make_scope_exit.
7148
7149 2019-01-23  Tom Tromey  <tom@tromey.com>
7150
7151         * ui-out.h (class ui_out_emit_type): Update comment.
7152
7153 2019-01-23  Tom Tromey  <tom@tromey.com>
7154
7155         * infrun.c (fetch_inferior_event): Update comment.
7156
7157 2019-01-23  Tom Tromey  <tom@tromey.com>
7158             Pedro Alves  <palves@redhat.com>
7159
7160         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7161         parameter.
7162         (fetch_inferior_event): Use SCOPE_EXIT.
7163
7164
7165 2019-01-23  Tom Tromey  <tom@tromey.com>
7166             Pedro Alves  <palves@redhat.com>
7167
7168         * infrun.c (disable_thread_events): Delete.
7169         (stop_all_threads): Use SCOPE_EXIT.
7170
7171 2019-01-23  Tom Tromey  <tom@tromey.com>
7172             Pedro Alves  <palves@redhat.com>
7173
7174         * symfile.c: Include forward-scope-exit.h.
7175         (clear_symtab_users_cleanup): Replace forward declaration with
7176         a FORWARD_SCOPE_EXIT.
7177         (syms_from_objfile_1): Use the forward_scope_exit and
7178         gdb::optional instead of cleanup_function.
7179         (reread_symbols): Use the forward_scope_exit instead of
7180         cleanup_function.
7181         (clear_symtab_users_cleanup): Remove function.
7182
7183 2019-01-23  Tom Tromey  <tom@tromey.com>
7184             Pedro Alves  <palves@redhat.com>
7185
7186         * linux-nat.c: Include scope-exit.h.
7187         (cleanup_target_stop): Remove.
7188         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7189         SCOPE_EXIT.
7190
7191 2019-01-23  Tom Tromey  <tom@tromey.com>
7192             Pedro Alves  <palves@redhat.com>
7193
7194         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7195         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7196
7197 2019-01-23  Tom Tromey  <tom@tromey.com>
7198             Andrew Burgess  <andrew.burgess@embecosm.com>
7199             Pedro Alves  <palves@redhat.com>
7200
7201         * infrun.c (fetch_inferior_event): Use scope_exit.
7202         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7203         * top.c (execute_command): Use scope_exit.
7204         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7205         * utils.c (do_bpstat_clear_actions_cleanup)
7206         (make_bpstat_clear_actions_cleanup): Remove.
7207
7208 2019-01-23  Tom Tromey  <tom@tromey.com>
7209             Pedro Alves  <palves@redhat.com>
7210
7211         * infrun.c: Include "common/scope-exit.h"
7212         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7213         (wait_for_inferior): Use SCOPE_EXIT.
7214         (fetch_inferior_event): Use scope_exit.
7215
7216 2019-01-23  Tom Tromey  <tom@tromey.com>
7217             Pedro Alves  <palves@redhat.com>
7218
7219         * breakpoint.c (create_breakpoint): Remove cleanup.
7220
7221 2019-01-23  Tom Tromey  <tom@tromey.com>
7222             Andrew Burgess  <andrew.burgess@embecosm.com>
7223             Pedro Alves  <palves@redhat.com>
7224
7225 2019-01-23  Pedro Alves  <palves@redhat.com>
7226
7227         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7228
7229 2019-01-23  Pedro Alves  <palves@redhat.com>
7230             Andrew Burgess  <andrew.burgess@embecosm.com>
7231
7232         * gdbthread.h: Include "common/forward-scope-exit.h".
7233         (scoped_finish_thread_state): Redefine custom class in terms of
7234         forward_scope_exit.
7235
7236 2019-01-23  Pedro Alves  <palves@redhat.com>
7237             Andrew Burgess  <andrew.burgess@embecosm.com>
7238
7239         * common/forward-scope-exit.h: New file.
7240
7241 2019-01-23  Pedro Alves  <palves@redhat.com>
7242             Andrew Burgess  <andrew.burgess@embecosm.com>
7243             Tom Tromey  <tom@tromey.com>
7244
7245         * common/scope-exit.h: New file.
7246
7247 2019-01-23  Pedro Alves  <palves@redhat.com>
7248
7249         * common/preprocessor.h (ESC): Rename to ...
7250         (ESC_PARENS): ... this.
7251         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7252         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7253
7254 2019-01-23  Tom Tromey  <tom@tromey.com>
7255
7256         * language.h (class scoped_switch_to_sym_language_if_auto):
7257         Initialize m_lang in both cases.
7258
7259 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7260
7261         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7262         with XCNEW.
7263
7264 2019-01-22  Tom Tromey  <tom@tromey.com>
7265
7266         * corelow.c: Do not include sys/file.h.
7267
7268 2019-01-22  Tom Tromey  <tom@tromey.com>
7269
7270         * tui/tui-wingeneral.h: Include gdb_curses.h.
7271
7272 2019-01-22  Tom Tromey  <tom@tromey.com>
7273
7274         * source-cache.h (class source_cache) <get_source_lines,
7275         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7276
7277 2019-01-22  Tom Tromey  <tom@tromey.com>
7278
7279         * remote-fileio.h (struct remote_target): Declare.
7280
7281 2019-01-22  Tom Tromey  <tom@tromey.com>
7282
7283         * python/py-arch.c: Do not include py-ref.h.
7284         * python/py-bpevent.c: Do not include py-ref.h.
7285         * python/py-cmd.c: Do not include py-ref.h.
7286         * python/py-continueevent.c: Do not include py-ref.h.
7287         * python/py-event.h: Do not include py-ref.h.
7288         * python/py-evtregistry.c: Do not include py-ref.h.
7289         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7290         * python/py-frame.c: Do not include py-ref.h.
7291         * python/py-framefilter.c: Do not include py-ref.h.
7292         * python/py-function.c: Do not include py-ref.h.
7293         * python/py-infevents.c: Do not include py-ref.h.
7294         * python/py-linetable.c: Do not include py-ref.h.
7295         * python/py-objfile.c: Do not include py-ref.h.
7296         * python/py-param.c: Do not include py-ref.h.
7297         * python/py-prettyprint.c: Do not include py-ref.h.
7298         * python/py-progspace.c: Do not include py-ref.h.
7299         * python/py-symbol.c: Do not include py-ref.h.
7300         * python/py-symtab.c: Do not include py-ref.h.
7301         * python/py-type.c: Do not include py-ref.h.
7302         * python/py-unwind.c: Do not include py-ref.h.
7303         * python/py-utils.c: Do not include py-ref.h.
7304         * python/py-value.c: Do not include py-ref.h.
7305         * python/py-varobj.c: Do not include py-ref.h.
7306         * python/py-xmethods.c: Do not include py-ref.h.
7307         * python/python.c: Do not include py-ref.h.
7308         * varobj.c: Do not include py-ref.h.
7309
7310 2019-01-22  Tom Tromey  <tom@tromey.com>
7311
7312         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7313         keyword for bcache.
7314
7315 2019-01-22  Tom Tromey  <tom@tromey.com>
7316
7317         * compile/compile-cplus-types.c: Remove a comment by #include.
7318
7319 2019-01-22  Tom Tromey  <tom@tromey.com>
7320
7321         * compile/gcc-c-plugin.h: Include compile-internal.h.
7322
7323 2019-01-22  Tom Tromey  <tom@tromey.com>
7324
7325         * stabsread.c (EXTERN): Do not define.
7326         (symnum, next_symbol_text_func, processing_gcc_compilation)
7327         (within_function, global_sym_chain, global_stabs)
7328         (previous_stab_code, this_object_header_files)
7329         (n_this_object_header_files)
7330         (n_allocated_this_object_header_files): Define.
7331         * stabsread.h (EXTERN): Never define.  Use "extern".
7332
7333 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7334
7335         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7336         history_value.
7337
7338 2019-01-21  Tom Tromey  <tom@tromey.com>
7339
7340         * ui-out.c: Fix includes.
7341         * tui/tui-source.c: Fix includes.
7342         * target.c: Fix includes.
7343         * remote.c: Fix includes.
7344         * regcache.c: Fix includes.
7345         * python/py-block.c: Fix includes.
7346         * printcmd.c: Fix includes.
7347         * or1k-tdep.c: Fix includes.
7348         * mi/mi-main.c: Fix includes.
7349         * m32r-tdep.c: Fix includes.
7350         * csky-tdep.c: Fix includes.
7351         * compile/compile-cplus-types.c: Fix includes.
7352         * cli/cli-interp.c: Fix includes.
7353
7354 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7355
7356         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7357         for padding.
7358
7359 2019-01-16  Tom Tromey  <tom@tromey.com>
7360
7361         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7362         earlier.
7363         (struct objfile) <msymbols_range>: Move from top level.
7364         <msymbols>: New method.
7365         (class objfile_msymbols): Remove.
7366         * symtab.c (default_collect_symbol_completion_matches_break_on):
7367         Update.
7368         * symmisc.c (dump_msymbols): Update.
7369         * stabsread.c (scan_file_globals): Update.
7370         * objc-lang.c (info_selectors_command, info_classes_command)
7371         (find_methods): Update.
7372         * minsyms.c (find_solib_trampoline_target): Update.
7373         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7374         * coffread.c (coff_symfile_read): Update.
7375         * ada-lang.c (ada_lookup_simple_minsym)
7376         (ada_collect_symbol_completion_matches): Update.
7377
7378 2019-01-16  Tom Tromey  <tom@tromey.com>
7379
7380         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7381         type.  Remove no-argument constructor.
7382         <iterator::operator++>: Simplify.
7383         <begin>: Update.
7384         <end>: Use minimal_symbol_count.
7385
7386 2019-01-16  Tom Tromey  <tom@tromey.com>
7387
7388         * objfiles.h (struct objfile) <psymtabs>: New method.
7389         (class objfile_psymtabs): Remove.
7390         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7391         typedef.
7392         <range>: New method.
7393         (require_partial_symbols): Change return type.
7394         * psymtab.c (require_partial_symbols)
7395         (psym_expand_symtabs_matching): Update.
7396         * mdebugread.c (parse_partial_symbols): Update.
7397         * dbxread.c (dbx_end_psymtab): Update.
7398
7399 2019-01-15  Tom Tromey  <tom@tromey.com>
7400
7401         * symtab.c (lookup_objfile_from_block)
7402         (lookup_symbol_in_objfile_symtabs)
7403         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7404         (find_line_symtab, info_sources_command)
7405         (default_collect_symbol_completion_matches_break_on)
7406         (make_source_files_completion_list): Update.
7407         * symmisc.c (print_objfile_statistics, dump_objfile)
7408         (maintenance_print_symbols, maintenance_info_symtabs)
7409         (maintenance_check_symtabs, maintenance_info_line_tables):
7410         Update.
7411         * source.c (select_source_symtab)
7412         (forget_cached_source_info_for_objfile): Update.
7413         * objfiles.h (class objfile_compunits): Remove.
7414         (struct objfile) <compunits_range>: New typedef.
7415         (compunits): New method.
7416         * objfiles.c (objfile_relocate1): Update.
7417         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7418         * maint.c (count_symtabs_and_blocks): Update.
7419         * linespec.c (iterate_over_all_matching_symtabs): Update.
7420         * cp-support.c (add_symbol_overload_list_qualified): Update.
7421         * coffread.c (coff_symtab_read): Update.
7422         * ada-lang.c (add_nonlocal_symbols)
7423         (ada_collect_symbol_completion_matches)
7424         (ada_add_global_exceptions): Update.
7425
7426 2019-01-15  Tom Tromey  <tom@tromey.com>
7427
7428         * progspace.h (program_space) <objfiles_safe_range>: New
7429         typedef.
7430         <objfiles_safe>: New method.
7431         * objfiles.h (class all_objfiles_safe): Remove.
7432         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7433         * jit.c (jit_inferior_exit_hook): Update.
7434
7435 2019-01-17  Tom Tromey  <tom@tromey.com>
7436
7437         * progspace.h (program_space) <objfiles_range>: New typedef.
7438         <objfiles>: New method.
7439         <objfiles_head>: Rename from objfiles.
7440         (object_files): Update.
7441         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7442         * guile/scm-pretty-print.c
7443         (ppscm_find_pretty_printer_from_objfiles): Update.
7444         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7445         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7446         Update.
7447         * python/py-progspace.c (pspy_get_objfiles): Update.
7448         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7449         Update.
7450         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7451         (objfpy_lookup_objfile_by_build_id): Update.
7452         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7453         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7454         Update.
7455         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7456         (expand_symtab_containing_pc, lookup_objfile_from_block)
7457         (lookup_static_symbol, basic_lookup_transparent_type)
7458         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7459         (find_line_symtab, info_sources_command)
7460         (default_collect_symbol_completion_matches_break_on)
7461         (make_source_files_completion_list, find_main_name): Update.
7462         * symmisc.c (print_symbol_bcache_statistics)
7463         (print_objfile_statistics, maintenance_print_symbols)
7464         (maintenance_print_msymbols, maintenance_print_objfiles)
7465         (maintenance_info_symtabs, maintenance_check_symtabs)
7466         (maintenance_expand_symtabs, maintenance_info_line_tables):
7467         Update.
7468         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7469         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7470         (map_overlay_command, unmap_overlay_command)
7471         (simple_overlay_update, expand_symtabs_matching)
7472         (map_symbol_filenames): Update.
7473         * symfile-debug.c (set_debug_symfile): Update.
7474         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7475         Update.
7476         * source.c (select_source_symtab, forget_cached_source_info):
7477         Update.
7478         * solib.c (solib_read_symbols): Update.
7479         * solib-spu.c (append_ocl_sos): Update.
7480         * psymtab.c (maintenance_print_psymbols)
7481         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7482         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7483         * printcmd.c (info_symbol_command): Update.
7484         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7485         Update.
7486         * objfiles.h (class all_objfiles): Remove.
7487         * objfiles.c (have_partial_symbols, have_full_symbols)
7488         (have_minimal_symbols, qsort_cmp, update_section_map)
7489         (shared_objfile_contains_address_p)
7490         (default_iterate_over_objfiles_in_search_order): Update.
7491         * objc-lang.c (info_selectors_command, info_classes_command)
7492         (find_methods): Update.
7493         * minsyms.c (find_solib_trampoline_target): Update.
7494         * maint.c (maintenance_info_sections)
7495         (maintenance_translate_address, count_symtabs_and_blocks):
7496         Update.
7497         * main.c (captured_main_1): Update.
7498         * linux-thread-db.c (try_thread_db_load_from_pdir)
7499         (has_libpthread): Update.
7500         * linespec.c (iterate_over_all_matching_symtabs)
7501         (search_minsyms_for_name): Update.
7502         * jit.c (jit_find_objf_with_entry_addr): Update.
7503         * hppa-tdep.c (find_unwind_entry)
7504         (hppa_lookup_stub_minimal_symbol): Update.
7505         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7506         Update.
7507         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7508         (elf_gnu_ifunc_resolve_by_got): Update.
7509         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7510         * dwarf-index-write.c (save_gdb_index_command): Update.
7511         * cp-support.c (add_symbol_overload_list_qualified): Update.
7512         * breakpoint.c (create_overlay_event_breakpoint)
7513         (create_longjmp_master_breakpoint)
7514         (create_std_terminate_master_breakpoint)
7515         (create_exception_master_breakpoint): Update.
7516         * blockframe.c (find_pc_partial_function): Update.
7517         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7518         (ada_collect_symbol_completion_matches)
7519         (ada_add_global_exceptions): Update.
7520
7521 2019-01-17  Tom Tromey  <tom@tromey.com>
7522
7523         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7524         declare VEC.
7525         (solib_target_parse_libraries): Change return type.
7526         (library_list_start_segment, library_list_start_section)
7527         (library_list_end_library, library_list_start_library); Update.
7528         (solib_target_free_library_list): Remove.
7529         (solib_target_parse_libraries): Remove cleanup.  Change return
7530         type.
7531         (solib_target_current_sos): Update.
7532
7533 2019-01-17  Tom Tromey  <tromey@bapiya>
7534
7535         * valprint.c: Replace "the the" with "the".
7536         * symtab.c: Replace "the the" with "the".
7537         * solib.c: Replace "the the" with "the".
7538         * solib-dsbt.c: Replace "the the" with "the".
7539         * linespec.c: Replace "the the" with "the".
7540         * dwarf2loc.h: Replace "the the" with "the".
7541         * amd64-windows-tdep.c: Replace "the the" with "the".
7542         * aarch64-tdep.c: Replace "the the" with "the".
7543
7544 2019-01-16  Keith Seitz  <keiths@redhat.com>
7545
7546         PR gdb/23773
7547         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7548         <builder>: Rename to ..
7549         <m_builder>: ... this and make private.
7550         (dwarf2_cu::get_builder): New method.  Change all users of
7551         `builder' to use this method.
7552         (dwarf2_start_symtab): Move to ...
7553         (dwarf2_cu::start_symtab): ... here.  Update all callers
7554         (setup_type_unit_groups): Move to ...
7555         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7556         callers.
7557         (dwarf2_cu::reset_builder): New method.
7558         (process_full_compunit, process_full_type_unit): Use
7559         dwarf2_cu::reset_builder.
7560         (follow_die_offset): Record the ancestor CU if it is different
7561         from the followed DIE's CU.
7562         (follow_die_sig_1): Likewise.
7563
7564 2019-01-15  Tom Tromey  <tom@tromey.com>
7565
7566         * remote.c (class remote_state) <buf>: Now a char_vector.
7567         <buf_size>: Remove.
7568         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7569         parameter.
7570         (remote_target::getpkt_or_notif_sane_1)
7571         (remote_target::getpkt_sane)
7572         (remote_target::getpkt_or_notif_sane): Likewise.
7573         (class remote_target) <putpkt>: New overload.
7574         (remote_target::read_frame): Change type of "buf_p".  Remove
7575         sizeof_p parameter.
7576         (packet_ok): New overload.
7577         (packet_check_result): New overload.
7578         Update all uses.
7579
7580 2019-01-14  Tom Tromey  <tom@tromey.com>
7581
7582         * remote-notif.c (handle_notification, remote_notif_ack)
7583         (remote_notif_parse): Make "buf" const.
7584         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7585         const.
7586         (remote_notif_parse, remote_notif_ack, handle_notification):
7587         Likewise.
7588         * remote.c (remote_notif_stop_parse): Make "buf" const.
7589         (remote_target::remote_parse_stop_reply): Make "buf" const.
7590         (remote_notif_stop_ack): Make "buf" const.
7591
7592 2019-01-14  Tom Tromey  <tom@tromey.com>
7593
7594         * remote.c (remote_console_output): Make parameter const.
7595
7596 2019-01-14  Tom Tromey  <tom@tromey.com>
7597
7598         * target-debug.h (target_debug_print_signals): Constify.
7599         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7600         * procfs.c (procfs_target::pass_signals): Update.
7601         * linux-nat.c (linux_nat_target::pass_signals): Update.
7602         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7603         * target-delegates.c: Rebuild.
7604         * remote.c (remote_target::program_signals): Update.
7605         (remote_target::pass_signals): Update.
7606         * target.c (target_pass_signals): Constify argument.
7607         (target_program_signals): Likewise.
7608         * target.h (struct target_ops) <pass_signals, program_signals>:
7609         Constify argument.
7610         (target_pass_signals, target_program_signals): Constify argument.
7611
7612 2019-01-14  Tom Tromey  <tom@tromey.com>
7613
7614         PR tui/28819:
7615         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7616
7617 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7618
7619         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7620         field.
7621         * rs6000-tdep.c: Include reggroups.h.
7622         (IS_V_ALIAS_PSEUDOREG): Define.
7623         (rs6000_register_name): Return names for the "vX" aliases.
7624         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7625         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7626         aliases.  Call default_register_reggroup_p for all other
7627         pseudo-registers.
7628         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7629         New functions.
7630         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7631         Handle "vX" aliases.
7632         (v_alias_pseudo_register_collect): New function.
7633         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7634         (rs6000_gdbarch_init): Initialize "vX" aliases as
7635         pseudo-registers.  Restore registration of
7636         rs6000_pseudo_register_reggroup_p with
7637         set_tdesc_pseudo_register_reggroup_p.
7638
7639 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7640
7641         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7642         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7643         set_gdbarch_num_pseudo_regs.
7644
7645 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7646
7647         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7648         Remove arg prefixname, add do_set and do_show.
7649         Add member functions set_list and show_list.
7650         * cli/cli-style.c (class cli_style_option): Update accordingly.
7651         (style_set_list): Move to file scope.
7652         (style_show_list): Likewise.
7653         (set_style): Call help_list.
7654         (show_style): Call cmd_show_list.
7655         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7656         Update to use the new macro.
7657
7658 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7659
7660         * ada-lang.c (_initialize_ada_language): Expand the help text
7661         for the "catch exception" command.
7662
7663 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7664
7665         * symtab.c (matching_obj_sections): Initialize obj,
7666         declare it closer to its usage.
7667
7668 2019-01-10  Tom Tromey  <tom@tromey.com>
7669
7670         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7671         (basic_inf_threads_range): Remove.
7672         (inf_threads_range, inf_non_exited_threads_range)
7673         (safe_inf_threads_range): Use next_adapter.
7674
7675 2019-01-10  Keith Seitz  <keiths@redhat.com>
7676
7677         PR gdb/23712
7678         PR symtab/23010
7679         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7680         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7681
7682 2019-01-10  Keith Seitz  <keiths@redhat.com>
7683
7684         PR gdb/23712
7685         PR symtab/23010
7686         * dictionary.c (pending_to_vector): Remove.
7687         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7688         Remove _1 suffix, replacing functions of the same name.  Update
7689         all callers.
7690         (dict_create_hashed, dict_create_hashed_expandable)
7691         (dict_create_linear, dict_create_linear_expandable, dict_free)
7692         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7693         Make functions static.
7694
7695 2019-01-10  Keith Seitz  <keiths@redhat.com>
7696
7697         PR gdb/23712
7698         PR symtab/23010
7699         * dictionary.h (struct dictionary): Replace declaration with
7700         multidictionary.
7701         (dict_create_hashed, dict_create_hashed_expandable)
7702         (dict_create_linear, dict_create_linear_expandable)
7703         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7704         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7705         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7706         taking multidictionary argument.
7707         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7708         * block.h (struct block) <dict>: Change to multidictionary
7709         and rename `multidict'.
7710         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7711         symmisc.c: Update all dictionary references to multidictionary.
7712
7713 2019-01-10  Keith Seitz  <keiths@redhat.com>
7714
7715         PR gdb/23712
7716         PR symtab/23010
7717         * dictionary.c: Include unordered_map.
7718         (pending_to_vector): New function.
7719         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7720         Rewrite the non-"_1" functions to take vector instead
7721         of linked list.
7722         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7723         "new" _1 versions of the same name.
7724         (multidictionary): Define.
7725         (std::hash<enum language): New definition.
7726         (collate_pending_symbols_by_language, mdict_create_hashed)
7727         (mdict_create_hashed_expandable, mdict_create_linear)
7728         (mdict_create_linear_expandable, mdict_free)
7729         (find_language_dictionary, create_new_language_dictionary)
7730         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7731         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7732         (mdict_size, mdict_empty): New functions.
7733         * dictionary.h (mdict_iterator): Define.
7734
7735 2019-01-10  Pedro Alves  <palves@redhat.com>
7736
7737         * breakpoint.c (read_uploaded_action)
7738         (create_tracepoint_from_upload): Adjust to use
7739         gdb::unique_xmalloc_ptr.
7740         * ctf.c (ctf_write_uploaded_tp):
7741         (SET_ARRAY_FIELD): Use emplace_back.
7742         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7743         * tracefile-tfile.c (tfile_write_uploaded_tp):
7744         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7745         gdb::unique_xmalloc_ptr.
7746         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7747         at_string, cond_string, cmd_strings>: Replace char pointers
7748         with gdb::unique_xmalloc_ptr.
7749
7750 2019-01-10  Pedro Alves  <palves@redhat.com>
7751
7752         * solib-target.c (library_list_start_library): Don't xstrdup name.
7753
7754 2019-01-10  Pedro Alves  <palves@redhat.com>
7755
7756         * mdebugread.c (parse_partial_symbols): Use
7757         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7758
7759 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * linux-fork.c (scoped_switch_fork_info)
7762         <~scoped_switch_fork_info>: Fix incorrect variable name.
7763
7764 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7765
7766         * linux-fork.c (scoped_switch_fork_info)
7767         <scoped_switch_fork_info>: Make explicit.
7768         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7769
7770 2019-01-10  Tom Tromey  <tom@tromey.com>
7771
7772         * objfiles.h (objfile::reset_psymtabs): Update.
7773         * objfiles.c (objfile::objfile): Update.
7774         * psymtab.h (psymtab_storage::obstack): Update.
7775         (psymtab_storage::m_obstack): Use gdb::optional.
7776         (class psymtab_storage): Update comment.  Remove objfile
7777         parameter.
7778         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7779
7780 2019-01-10  Tom Tromey  <tom@tromey.com>
7781
7782         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7783         <free_psymtabs>: Now private.
7784         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7785         (allocate_psymtab): Use new method.
7786
7787 2019-01-10  Tom Tromey  <tom@tromey.com>
7788
7789         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7790         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7791         * mdebugread.c (parse_partial_symbols): Use
7792         allocate_dependencies.
7793         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7794         allocate_dependencies.
7795         (process_psymtab_comp_unit_reader)
7796         (build_type_psymtab_dependencies): Likewise.
7797         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7798
7799 2019-01-10  Tom Tromey  <tom@tromey.com>
7800
7801         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7802         PSYMBOL_SET_LANGUAGE.
7803         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7804
7805 2019-01-10  Tom Tromey  <tom@tromey.com>
7806
7807         * psymtab.h (psymtab_storage::obstack): New method.
7808         <m_obstack>: Rename from obstack; now private.
7809         * psymtab.c (psymtab_storage): Update.
7810         * dwarf2read.c (create_addrmap_from_index)
7811         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7812         Update.
7813
7814 2019-01-10  Tom Tromey  <tom@tromey.com>
7815
7816         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7817         * objfiles.h (objfile::reset_psymtabs): New method.
7818
7819 2019-01-10  Tom Tromey  <tom@tromey.com>
7820
7821         * symmisc.c (print_symbol_bcache_statistics): Update.
7822         (print_objfile_statistics): Update.
7823         * symfile.c (reread_symbols): Update.
7824         * psymtab.h (class psymtab_storage): New.
7825         * psymtab.c (psymtab_storage): New constructor.
7826         (~psymtab_storage): New destructor.
7827         (require_partial_symbols): Update.
7828         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7829         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7830         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7831         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7832         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7833         (start_psymtab_common, end_psymtab_common)
7834         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7835         (allocate_psymtab): Update.
7836         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7837         Update.
7838         (dump_psymtab_addrmap, maintenance_print_psymbols)
7839         (maintenance_check_psymtabs): Update.
7840         (class objfile_psymtabs): Move to objfiles.h.
7841         * psympriv.h (discard_psymtab): Now inline.
7842         (psymtab_discarder::psymtab_discarder): Update.
7843         (psymtab_discarder::~psymtab_discarder): Update.
7844         (ALL_OBJFILE_PSYMTABS): Rewrite.
7845         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7846         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7847         Remove fields.
7848         <partial_symtabs>: New field.
7849         (class objfile_psymtabs): Move from psymtab.h.  Update.
7850         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7851         psymbol_cache.
7852         (objfile::~objfile): Don't destroy psymbol_cache.
7853         * mdebugread.c (parse_partial_symbols): Update.
7854         * dwarf2read.c (create_addrmap_from_index)
7855         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7856         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7857         (add_partial_subprogram, dwarf2_ranges_read): Update.
7858         * dwarf-index-write.c (write_address_map)
7859         (write_one_signatured_type, recursively_write_psymbols)
7860         (class debug_names, class debug_names, write_psymtabs_to_index):
7861         Update.
7862
7863 2019-01-10  Tom Tromey  <tom@tromey.com>
7864
7865         * symtab.h (SYMBOL_SET_NAMES): Update.
7866         (symbol_set_names): Update.
7867         (MSYMBOL_SET_NAMES): Update.
7868         * symtab.c (symbol_set_names): Change argument to be an
7869         objfile_per_bfd_storage.
7870         * psymtab.c (add_psymbol_to_bcache): Update.
7871         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7872
7873 2019-01-10  Tom Tromey  <tom@tromey.com>
7874
7875         * symtab.c (create_demangled_names_hash): Change argument to be an
7876         objfile_per_bfd_storage.
7877         (symbol_set_names): Update.
7878
7879 2019-01-10  Tom Tromey  <tom@tromey.com>
7880
7881         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7882         init_psymbol_list.
7883         * psymtab.c (init_psymbol_list): Do nothing if already called.
7884         * psympriv.h (init_psymbol_list): Add comment.
7885         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7886         init_psymbol_list.
7887         * dbxread.c (dbx_symfile_read): Unconditionally call
7888         init_psymbol_list.
7889
7890 2019-01-10  Tom Tromey  <tom@tromey.com>
7891
7892         * xcoffread.c (scan_xcoff_symtab): Update.
7893         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7894         "where".
7895         * mdebugread.c (parse_partial_symbols)
7896         (handle_psymbol_enumerators): Update.
7897         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7898         * dbxread.c (read_dbx_symtab): Update.
7899         * psympriv.h (psymbol_placement): New enum.
7900         (add_psymbol_to_list): Update.
7901
7902 2019-01-10  Tom Tromey  <tom@tromey.com>
7903
7904         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7905         static_psymbols parameters.
7906         (scan_xcoff_symtab): Update.
7907         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7908         static_psymbols parameters.
7909         * psympriv.h (start_psymtab_common): Update.
7910         * mdebugread.c (parse_partial_symbols): Update.
7911         * dwarf2read.c (create_partial_symtab): Update.
7912         * dbxread.c (read_dbx_symtab): Update.
7913         (start_psymtab): Remove global_psymbols and static_psymbols
7914         parameters.
7915
7916 2019-01-10  Tom Tromey  <tom@tromey.com>
7917
7918         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7919         * psymtab.c (allocate_psymtab): Add comment.
7920         * psympriv.h (allocate_psymtab): Add comment.
7921         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7922         initializations.
7923         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7924
7925 2019-01-10  Tom Tromey  <tom@tromey.com>
7926
7927         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7928         Don't declare.
7929         * mipsread.c: Include mdebugread.h.
7930         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7931         Declare.
7932         * elfread.c: Include mdebugread.h.
7933
7934 2019-01-09  Tom Tromey  <tom@tromey.com>
7935
7936         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7937         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7938         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7939         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7940         (psym_lookup_symbol, psym_find_last_source_symtab)
7941         (psym_forget_cached_source_info, psym_print_stats)
7942         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7943         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7944         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7945         (psym_find_compunit_symtab_by_address)
7946         (maintenance_print_psymbols, maintenance_info_psymtabs)
7947         (maintenance_check_psymtabs): Use ranged for.
7948         * psymtab.h (class objfile_psymtabs): New.
7949         (require_partial_symbols): Return objfile_psymtabs.
7950         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7951
7952 2019-01-09  Tom Tromey  <tom@tromey.com>
7953
7954         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7955         (find_pc_mapped_section, list_overlays_command)
7956         (map_overlay_command, unmap_overlay_command)
7957         (simple_overlay_update): Use all_objfiles.
7958         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7959         * printcmd.c (info_symbol_command): Use all_objfiles.
7960         * objfiles.h (ALL_OBJSECTIONS): Remove.
7961         * maint.c (maintenance_translate_address): Use all_objfiles.
7962         * gcore.c (gcore_create_callback): Use all_objfiles.
7963         (objfile_find_memory_regions): Likewise.
7964
7965 2019-01-09  Tom Tromey  <tom@tromey.com>
7966
7967         * symtab.c (find_line_symtab, info_sources_command)
7968         (make_source_files_completion_list): Use objfile_compunits.
7969         * source.c (select_source_symtab): Use objfile_compunits.
7970         * objfiles.h (struct objfile): Update comment.
7971         (ALL_OBJFILES): Remove.
7972         (ALL_FILETABS): Remove.
7973         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7974         objfile_compunits.
7975
7976 2019-01-09  Tom Tromey  <tom@tromey.com>
7977
7978         * symmisc.c (print_objfile_statistics, dump_objfile)
7979         (maintenance_print_symbols): Use compunit_filetabs.
7980         * source.c (forget_cached_source_info_for_objfile): Use
7981         compunit_filetabs.
7982         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7983         (ALL_FILETABS): Use compunit_filetabs.
7984         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7985         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7986
7987 2019-01-09  Tom Tromey  <tom@tromey.com>
7988
7989         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7990         (compunit_filetabs): New.
7991         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7992         compunit_filetabs.
7993         (info_sources_command, make_source_files_completion_list): Remove
7994         declaration.
7995         * symmisc.c (print_objfile_statistics, dump_objfile)
7996         (maintenance_print_symbols): Remove declaration.
7997         (maintenance_info_symtabs): Use compunit_filetabs.
7998         (maintenance_info_line_tables): Likewise.
7999         * source.c (select_source_symtab): Change local variable name.
8000         (forget_cached_source_info_for_objfile): Remove declaration.
8001         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8002         * objfiles.c (objfile_relocate1): Remove declaration.
8003         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8004         declaration.
8005         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8006         * coffread.c (coff_symtab_read): Remove declaration.
8007         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8008         compunit_filetabs.
8009
8010 2019-01-09  Tom Tromey  <tom@tromey.com>
8011
8012         * symtab.c (lookup_objfile_from_block)
8013         (find_pc_sect_compunit_symtab, search_symbols)
8014         (default_collect_symbol_completion_matches_break_on): Use
8015         objfile_compunits.
8016         * objfiles.h (ALL_COMPUNITS): Remove.
8017         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8018         * cp-support.c (add_symbol_overload_list_qualified): Use
8019         objfile_compunits.
8020         * ada-lang.c (ada_collect_symbol_completion_matches)
8021         (ada_add_global_exceptions): Use objfile_compunits.
8022
8023 2019-01-09  Tom Tromey  <tom@tromey.com>
8024
8025         * source.c (select_source_symtab)
8026         (forget_cached_source_info_for_objfile): Remove declaration.
8027         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8028         declaration.
8029         * maint.c (count_symtabs_and_blocks): Remove declaration.
8030         * cp-support.c (add_symbol_overload_list_qualified): Remove
8031         declaration.
8032         * coffread.c (coff_symtab_read): Remove declaration.
8033         * symtab.c (lookup_symbol_in_objfile_symtabs)
8034         (basic_lookup_transparent_type_1): Use objfile_compunits.
8035         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8036         (info_sources_command, search_symbols)
8037         (default_collect_symbol_completion_matches_break_on)
8038         (make_source_files_completion_list): Remove declaration.
8039         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8040         (ada_collect_symbol_completion_matches)
8041         (ada_add_global_exceptions): Remove declaration.
8042         * linespec.c (iterate_over_all_matching_symtabs): Use
8043         objfile_compunits.
8044         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8045         (class objfile_compunits): New.
8046         (ALL_COMPUNITS): Use objfile_compunits.
8047         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8048         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8049         objfile_compunits.
8050         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8051
8052 2019-01-09  Tom Tromey  <tom@tromey.com>
8053
8054         * symtab.c (search_symbols)
8055         (default_collect_symbol_completion_matches_break_on): Use
8056         objfile_msymbols.
8057         * ada-lang.c (ada_lookup_simple_minsym)
8058         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8059         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8060         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8061         objfile_msymbols.
8062         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8063         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8064         * objc-lang.c (find_methods): Use objfile_msymbols.
8065         (info_selectors_command, info_classes_command): Likewise.
8066         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8067         * objfiles.h (class objfile_msymbols): New.
8068         (ALL_OBJFILE_MSYMBOLS): Remove.
8069         (ALL_MSYMBOLS): Remove.
8070
8071 2019-01-09  Tom Tromey  <tom@tromey.com>
8072
8073         * common/next-iterator.h (next_adapter): Add Iterator template
8074         parameter.
8075         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8076         (class all_objfiles_safe): New.
8077         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8078         * objfiles.c (put_objfile_before): Update comment.
8079         (add_separate_debug_objfile): Likewise.
8080         (free_all_objfiles): Use all_objfiles_safe.
8081         (objfile_purge_solibs): Likewise.
8082
8083 2019-01-09  Tom Tromey  <tom@tromey.com>
8084
8085         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8086         (expand_symtab_containing_pc, lookup_static_symbol)
8087         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8088         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8089         all_objfiles.
8090         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8091         * breakpoint.c (create_overlay_event_breakpoint)
8092         (create_longjmp_master_breakpoint)
8093         (create_std_terminate_master_breakpoint)
8094         (create_exception_master_breakpoint): Use all_objfiles.
8095         * linux-thread-db.c (try_thread_db_load_from_pdir)
8096         (has_libpthread): Use all_objfiles.
8097         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8098         * linespec.c (iterate_over_all_matching_symtabs)
8099         (search_minsyms_for_name): Use all_objfiles.
8100         * maint.c (maintenance_info_sections): Use all_objfiles.
8101         * main.c (captured_main_1): Use all_objfiles.
8102         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8103         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8104         * guile/scm-pretty-print.c
8105         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8106         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8107         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8108         (maintenance_print_msymbols): Use all_objfiles.
8109         * source.c (select_source_symtab): Use all_objfiles.
8110         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8111         * symfile.c (remove_symbol_file_command)
8112         (expand_symtabs_matching, map_symbol_filenames): Use
8113         all_objfiles.
8114         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8115         all_objfiles.
8116         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8117         * objc-lang.c (find_methods): Use all_objfiles.
8118         * objfiles.c (have_partial_symbols, have_full_symbols)
8119         (have_minimal_symbols, qsort_cmp)
8120         (default_iterate_over_objfiles_in_search_order): Use
8121         all_objfiles.
8122         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8123         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8124         (maintenance_check_psymtabs): Use all_objfiles.
8125         (ALL_PSYMTABS): Remove.
8126         * compile/compile-object-run.c (do_module_cleanup): Use
8127         all_objfiles.
8128         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8129         * cp-support.c (add_symbol_overload_list_qualified): Use
8130         all_objfiles.
8131         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8132         Use all_objfiles.
8133         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8134         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8135         all_objfiles.
8136         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8137         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8138         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8139         Uses all_objfiles.
8140         * solib.c (solib_read_symbols): Use all_objfiles
8141
8142 2019-01-09  Tom Tromey  <tom@tromey.com>
8143
8144         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8145         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8146         all_objfiles.
8147         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8148         * symmisc.c (print_symbol_bcache_statistics)
8149         (print_objfile_statistics, maintenance_print_objfiles)
8150         (maintenance_info_symtabs, maintenance_check_symtabs)
8151         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8152         all_objfiles.
8153         * source.c (forget_cached_source_info): Use all_objfiles.
8154         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8155         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8156         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8157         * objfiles.c (update_section_map): Use all_objfiles.
8158         (shared_objfile_contains_address_p): Likewise.
8159         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8160         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8161
8162 2019-01-09  Tom Tromey  <tom@tromey.com>
8163
8164         * common/next-iterator.h: New file.
8165         * objfiles.h (class all_objfiles): New.
8166         (struct objfile_iterator): New.
8167
8168 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8169
8170         * NEWS: Move the description of the changed "frame", "select-frame",
8171          and "info frame" commands to the Changed commands section.
8172
8173 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8174
8175         * gdbtypes.c (check_stub_method_group): Remove handling of old
8176         mangling schemes.
8177         * linespec.c (find_methods): Likewise.
8178         * stabsread.c (read_member_functions): Likewise.
8179         * valops.c (search_struct_method): Likewise.
8180         (value_struct_elt_for_reference): Likewise.
8181         * NEWS: Mention this change.
8182
8183 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8184
8185         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8186         print_source_lines.
8187         * source.c (print_source_lines_base): Update line number check.
8188         (print_source_lines): New function.
8189         (source_lines_range::source_lines_range): New function.
8190         * source.h (class source_lines_range): New class.
8191         (print_source_lines): New declaration.
8192
8193 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8194
8195         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8196
8197 2019-01-08  Tom Tromey  <tom@tromey.com>
8198             Simon Marchi  <simon.marchi@ericsson.com>
8199
8200         PR gdb/24060
8201         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8202         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8203         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8204         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8205         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8206         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8207
8208 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8209
8210         * source.c (select_source_symtab): Move header comment to
8211         declaration in source.h.
8212         (forget_cached_source_info_for_objfile): Likewise.
8213         (forget_cached_source_info): Likewise.
8214         (identify_source_line): Likewise.
8215         * source.h (identify_source_line): Move declaration from symtab.h
8216         and add comment from source.c
8217         (print_source_lines): Likewise.
8218         (forget_cached_source_info_for_objfile): Likewise.
8219         (forget_cached_source_info): Likewise.
8220         (select_source_symtab): Likewise.
8221         (enum print_source_lines_flag): Move definition from symtab.h.
8222         * symtab.h (identify_source_line): Move declaration to source.h.
8223         (print_source_lines): Likewise.
8224         (forget_cached_source_info_for_objfile): Likewise.
8225         (forget_cached_source_info): Likewise.
8226         (select_source_symtab): Likewise.
8227         (enum print_source_lines_flag): Move definition to source.h.
8228         * tui/tui-hooks.c: Add 'source.h' include.
8229
8230 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8231
8232         * source.c (print_source_lines_base): Handle requests to print
8233         reverse line number sequences, and guard against empty lines
8234         string.
8235
8236 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8237
8238         * source.c (print_source_lines_base): Fix skip of '\r' if next
8239         character is '\n'.
8240
8241 2019-01-06  Tom Tromey  <tom@tromey.com>
8242
8243         * c-exp.y (struct c_parse_state) <macro_original_text,
8244         expansion_obstack>: New member.
8245         (macro_original_text, expansion_obstack): Remove globals.
8246         (scan_macro_expansion, scanning_macro_expansion)
8247         (finished_macro_expansion): Update.
8248         (scan_macro_cleanup): Remove.
8249         (yylex, c_parse): Update.
8250
8251 2019-01-06  Tom Tromey  <tom@tromey.com>
8252
8253         * c-exp.y (struct c_parse_state) <strings>: New member.
8254         (operator_stoken): Update.
8255
8256 2019-01-06  Tom Tromey  <tom@tromey.com>
8257
8258         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8259         (union type_stack_elt) <typelist_val>: Now a pointer to
8260         std::vector.
8261         (type_stack_cleanup): Don't declare.
8262         (push_typelist): Update.
8263         * parse.c (pop_typelist): Return a std::vector.
8264         (push_typelist): Take a std::vector.
8265         (follow_types): Update.  Do not free args.
8266         (type_stack_cleanup): Remove.
8267         * c-exp.y (struct c_parse_state): New.
8268         (cpstate): New global.
8269         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8270         (nonempty_typelist): Update.
8271         (func_mod): Create a new vector.
8272         (c_parse): Create a c_parse_state.
8273         (check_parameter_typelist): Do not delete params.
8274         (function_method): Update.  Do not delete type_list.
8275
8276 2019-01-06  Tom Tromey  <tom@tromey.com>
8277
8278         PR gdb/28155:
8279         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8280         check_typedef.
8281         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8282         (print_return_value): Likewise.
8283
8284 2019-01-05  Tom Tromey  <tom@tromey.com>
8285
8286         * contrib/cleanup_check.py: Remove.
8287         * contrib/gcc-with-excheck: Remove.
8288         * contrib/exsummary.py: Remove.
8289         * contrib/excheck.py: Remove.
8290
8291 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8292
8293         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8294         NULL. Initialize tpprev to NULL instead of assigning it
8295         to NULL on the next statement.
8296         * windows-nat.c (windows_delete_thread): Remove check for
8297         main_thread_id before printing thread exit notifications.
8298         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8299         Remove thread ID check against main_thread_id.
8300         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8301         windows_delete_thread.
8302         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8303
8304 2019-01-04  Tom Tromey  <tom@tromey.com>
8305
8306         * compile/compile.c (_initialize_compile): Use upper case for
8307         metasyntactic variables.
8308         * symmisc.c (_initialize_symmisc): Use upper case for
8309         metasyntactic variables.
8310         * psymtab.c (_initialize_psymtab): Use upper case for
8311         metasyntactic variables.
8312         * demangle.c (demangle_command): Use upper case for metasyntactic
8313         variables.
8314         (_initialize_demangler): Likewise.
8315         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8316         variables.
8317
8318 2019-01-03  Tom Tromey  <tom@tromey.com>
8319
8320         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8321
8322 2019-01-03  Tom Tromey  <tom@tromey.com>
8323
8324         * python/py-symtab.c (salpy_str): Update.
8325         (struct salpy_sal_object) <symtab>: Now a PyObject.
8326         (salpy_dealloc): Update.
8327         (del_objfile_sal): Use gdbpy_ref.
8328
8329 2019-01-03  Tom Tromey  <tom@tromey.com>
8330
8331         * python/py-type.c (convert_field): Use new_reference.  Return
8332         gdbpy_ref.
8333         (make_fielditem): Return gdbpy_ref.
8334         (typy_fields): Update.
8335         (typy_getitem): Update.
8336         (field_name): Return gdbpy_ref.  Use new_reference.
8337         (typy_iterator_iternext): Update.
8338
8339 2019-01-03  Tom Tromey  <tom@tromey.com>
8340
8341         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8342
8343 2019-01-03  Tom Tromey  <tom@tromey.com>
8344
8345         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8346         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8347         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8348         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8349         (pspy_set_type_printers): Likewise.
8350         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8351         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8352         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8353         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8354         (objfpy_set_type_printers): Likewise.
8355
8356 2019-01-03  Tom Tromey  <tom@tromey.com>
8357
8358         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8359         (gdbpy_print_stack): Use gdbpy_err_fetch.
8360         * python/python-internal.h (class gdbpy_err_fetch): New class.
8361         (class gdbpy_enter) <m_error_type, m_error_value,
8362         m_error_traceback>: Remove.
8363         <m_error>: New member.
8364         (gdbpy_exception_to_string): Don't declare.
8365         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8366         * python/py-value.c (convert_value_from_python): Use
8367         gdbpy_err_fetch.
8368         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8369         gdbpy_exception_to_string.
8370         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8371         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8372         gdbpy_err_fetch.
8373
8374 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8375
8376         * linux-nat.c (delete_lwp_cleanup): Delete.
8377         (struct lwp_deleter): New struct.
8378         (lwp_info_up): New typedef.
8379         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8380         lwp_info_up.
8381
8382 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8383
8384         * linux-fork.c (class scoped_switch_fork_info): New class.
8385         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8386
8387 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8388
8389         * valops.c (find_overload_match): Remove use of null_cleanup, and
8390         calls to do_cleanups.
8391
8392 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8393
8394         * compile/compile-cplus-types.c
8395         (compile_cplus_instance::decl_name): Handle changes to
8396         cp_func_name.
8397         * cp-support.c (cp_func_name): Update header comment, update
8398         return type.
8399         * cp-support.h (cp_func_name): Update return type in declaration.
8400         * valops.c (find_overload_match): Move temp_func local to top
8401         level of function and change its type.  Use temp_func to hold and
8402         delete temporary string obtained from cp_func_name.
8403
8404 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8405
8406         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8407         gdb::char_vector, remove cleanup, and update uses of `msg`.
8408
8409 2019-01-03  Jim Wilson  <jimw@sifive.com>
8410
8411         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8412
8413 2019-01-02  Tom Tromey  <tom@tromey.com>
8414
8415         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8416         (tdesc_parse_xml): Remove cleanups.
8417         * target-descriptions.h (make_cleanup_free_target_description):
8418         Don't declare.
8419         (target_desc_deleter): New struct.
8420         (target_desc_up): New typedef.
8421         * target-descriptions.c (target_desc_deleter::operator()): Rename
8422         from free_target_description.
8423         (make_cleanup_free_target_description): Remove.
8424
8425 2019-01-02  Tom Tromey  <tom@tromey.com>
8426
8427         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8428         constructor, destructor.
8429         (linespec_parser): Remove typedef.
8430         (~linespec_parser): Rename from linespec_parser_delete.
8431         (linespec_lex_to_end, linespec_complete_label)
8432         (linespec_complete): Update.
8433         (decode_line_full): Remove cleanups.
8434         (decode_line_1): Update.
8435
8436 2019-01-02  Tom Tromey  <tom@tromey.com>
8437
8438         * python/python-internal.h (inferior_to_inferior_object): Change
8439         return type.
8440         * python/py-exitedevent.c (create_exited_event_object): Update.
8441         * python/py-inferior.c (inferior_to_inferior_object): Return
8442         gdbpy_ref.
8443         (python_new_inferior, python_inferior_deleted)
8444         (thread_to_thread_object, delete_thread_object)
8445         (build_inferior_list, gdbpy_selected_inferior): Update.
8446         * python/py-infthread.c (create_thread_object): Update.  Also fail
8447         if inferior_to_inferior_object fails.
8448
8449 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8450
8451         * inferior.h (class inferior) <displaced_step_state>: New field.
8452         * infrun.h (struct displaced_step_state): Move here from
8453         infrun.c.  Initialize fields, add constructor.
8454         <inf>: Remove field.
8455         <reset>: New method.
8456         * infrun.c (struct displaced_step_inferior_state): Move to
8457         infrun.h.
8458         (displaced_step_inferior_states): Remove.
8459         (get_displaced_stepping_state): Adust.
8460         (displaced_step_in_progress_any_inferior): Adjust.
8461         (displaced_step_in_progress_thread): Adjust.
8462         (displaced_step_in_progress): Adjust.
8463         (add_displaced_stepping_state): Remove.
8464         (get_displaced_step_closure_by_addr): Adjust.
8465         (remove_displaced_stepping_state): Remove.
8466         (infrun_inferior_exit): Call displaced_step_state.reset.
8467         (use_displaced_stepping): Don't check for NULL.
8468         (displaced_step_prepare_throw): Call
8469         get_displaced_stepping_state.
8470         (displaced_step_fixup): Don't check for NULL.
8471         (prepare_for_detach): Don't check for NULL.
8472
8473 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8474
8475         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8476          in case of call that did not complete.
8477
8478 2019-01-02  Andrey Utkin  <autkin@undo.io>
8479
8480         * symfile.c (find_separate_debug_file): Fix search of debug files for
8481         remote debuggee.
8482
8483 2019-01-02  Tom Tromey  <tom@tromey.com>
8484
8485         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8486         indentation.
8487         * python/py-frame.c (frapy_older): Remove cast.
8488         (frapy_newer): Likewise.
8489         * python/py-breakpoint.c (local_setattro): Remove cast.
8490         * python/py-arch.c (archpy_name): Remove local variable.
8491         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8492
8493 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8494
8495         * unittests/basic_string_view/element_access/char/empty.cc:
8496         Fix year range in copyright header.
8497
8498 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8499
8500         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8501         Delete.
8502         <operator==>: Update with for removed field.
8503         <hash>: Likewise.
8504         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8505         <isa_features>: ...this.
8506         <abi_features>: New field.
8507         (riscv_isa_flen): Update comment.
8508         (riscv_abi_xlen): New declaration.
8509         (riscv_abi_flen): New declaration.
8510         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8511         isa_features.
8512         (riscv_abi_xlen): New function.
8513         (riscv_isa_flen): Update to get answer from isa_features.
8514         (riscv_abi_flen): New function.
8515         (riscv_has_fp_abi): Update to get answer from abi_features.
8516         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8517         xlen and flen.
8518         (riscv_call_info) <xlen, flen>: Update comment.
8519         (riscv_call_arg_struct): Remove invalid assertions
8520         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8521         is removed.
8522         (riscv_gdbarch_init): Gather isa features and abi features
8523         separately, ensure both match on the gdbarch when reusing an old
8524         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8525         a target with 64-bit float hardware.
8526
8527 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8528
8529         * source.c (search_command_helper): Stop reverse search
8530         when line 1 has been searched.
8531
8532 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8533
8534         * record-full.c (record_full_base_target::close): Rewrite
8535         record_full_core_buf_list free logic.
8536
8537 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8538
8539         * break-catch-syscall.c (print_one_catch_syscall): xfree
8540         the last text.
8541
8542 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8543
8544         * top.c (print_gdb_version): Update Copyright year in version
8545         message.
8546
8547 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8548
8549         Update copyright year range in all GDB files.
8550
8551 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8552
8553         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8554
8555 For older changes see ChangeLog-2018.
8556 \f
8557 Local Variables:
8558 mode: change-log
8559 left-margin: 8
8560 fill-column: 74
8561 version-control: never
8562 coding: utf-8
8563 End:
8564