1 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3 * blockframe.c (find_pc_partial_function): Change return type to bool.
4 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
5 * minsyms.c (in_gnu_ifunc_stub): Likewise.
6 (stub_gnu_ifunc_resolve_name): Likewise.
7 * symtab.c (compare_filenames_for_search): Likewise.
8 (compare_glob_filenames_for_search): Likewise.
9 (matching_obj_sections): Likewise.
10 (symbol_matches_domain): Likewise.
11 (find_line_symtab): Change out param EXACT_MATCH to bool *.
12 (find_line_pc): Change return type to bool.
13 (find_line_pc_range): Likewise.
14 (producer_is_realview): Likewise.
15 * symtab.h (symbol_matches_domain): Likewise.
16 (find_pc_partial_function): Likewise.
17 (find_pc_line_pc_range): Likewise.
18 (in_gnu_ifunc_stub): Likewise.
19 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
20 (find_line_pc): Likewise.
21 (find_line_pc_range): Likewise.
22 (matching_obj_sections): Likewise.
23 (find_line_symtab): Change out parameter to bool.
24 (producer_is_realview): Change return type to bool.
25 (compare_filenames_for_search): Likewise.
26 (compare_glob_filenames_for_search): Likewise.
28 2019-09-26 Tom Tromey <tom@tromey.com>
30 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
31 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
32 * gdb_usleep.h: Remove.
33 * gdb_usleep.c: Remove.
34 * utils.c: Don't include gdb_usleep.h.
36 2019-09-26 Tom Tromey <tromey@adacore.com>
38 * python/py-type.c (type_to_type_object): Call check_typedef
41 2019-09-26 Tom Tromey <tom@tromey.com>
43 * utils.h (initialize_utils): Don't declare.
44 * top.c (gdb_init): Don't call initialize_utils.
45 * utils.c (initialize_utils): Remove. Move contents...
46 (_initialize_utils): ... here.
48 2019-09-25 Tom Tromey <tom@tromey.com>
50 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
51 * utils.h (make_hex_string): Don't declare.
52 * utils.c (make_hex_string): Remove.
54 2019-09-24 Tom de Vries <tdevries@suse.de>
57 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
58 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
60 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
62 * NEWS: Mention new simulator port for PRU.
64 2019-09-23 Christian Biesinger <cbiesinger@google.com>
66 * ada-exp.y (write_object_remaining): Update.
67 * ada-lang.c (ada_decode): Return a std::string instead of a char*
68 and eliminate the static buffer.
69 (ada_decode_symbol): Update.
70 (ada_la_decode): Update.
71 (ada_sniff_from_mangled_name): Update.
72 (is_valid_name_for_wild_match): Update.
73 (ada_lookup_name_info::matches): Update and simplify.
74 (name_matches_regex): Update.
75 (ada_add_global_exceptions): Update.
76 * ada-lang.h (ada_decode): Update signature.
77 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
78 * dwarf-index-write.c (debug_names::insert): Update.
80 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
82 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
85 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
87 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
88 Change "nonzero" to "true" in documentation.
90 2019-09-20 Christian Biesinger <cbiesinger@google.com>
92 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
93 (_initialize_darwin_solib): Don't set
94 darwin_so_ops.lookup_lib_global_symbol.
95 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
96 set_gdbarch_iterate_over_objfiles_in_search_order.
97 (elf_lookup_lib_symbol): Rename to...
98 (svr4_iterate_over_objfiles_in_search_order): this, and update
100 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
101 * solib.c (solib_global_lookup): Remove.
102 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
103 (solib_global_lookup): Remove.
104 * symtab.c (lookup_global_or_static_symbol): Remove call to
107 2019-09-20 Joel Brobecker <brobecker@adacore.com>
109 * NEWS: Move entries about default MI version now being
110 version 3, and about the GDB/MI fix for multi-location
111 breakpoints to the "since GDB 8.3" section.
113 2019-09-20 Joel Brobecker <brobecker@adacore.com>
117 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
119 * NEWS: Mention that Cell/B.E. debugging support was removed.
120 * MAINTAINERS: Remove spu target.
122 * config/djgpp/fnchange.lst: Remove entries for removed files.
124 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
125 spu-multiarch.o, and spu-tdep.o.
126 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
127 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
128 spu-multiarch.c, and spu-tdep.c.
129 * spu-linux-nat.c: Remove file.
130 * spu-multiarch.c: Remove file.
131 * spu-tdep.c: Remove file.
132 * spu-tdep.h: Remove file.
133 * solib-spu.c: Remove file.
134 * solib-spu.h: Remove file.
136 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
137 * configure.nat (spu-linux): Remove.
138 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
139 solib-multiarch.o from gdb_target_obs.
142 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
144 (ppc_linux_no_features): Update.
145 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
147 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
148 (tdesc_powerpc_cell64l): Likewise.
149 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
150 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
152 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
153 Do not include "features/rs6000/powerpc-cell32l.c" or
154 "features/rs6000/powerpc-cell64l.c".
155 (ppc_linux_spu_section): Remove.
156 (ppc_linux_core_read_description): Remove Cell/B.E. support.
157 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
158 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
159 (ppc_linux_spe_context_lookup): Remove.
160 (ppc_linux_spe_context_inferior_created): Remove.
161 (ppc_linux_spe_context_solib_loaded): Remove.
162 (ppc_linux_spe_context_solib_unloaded): Remove.
163 (ppc_linux_spe_context): Remove.
164 (struct ppu2spu_cache): Remove.
165 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
166 (struct ppu2spu_data): Remove.
167 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
168 ppu2spu_unwind): Remove.
169 (ppc_linux_init_abi): Remove Cell/B.E. support.
170 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
172 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
173 (rs6000/powerpc-cell64l-expedite): Likewise
174 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
175 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
176 rs6000/powerpc-cell64l.xml.
177 * features/rs6000/powerpc-cell32l.xml: Remove.
178 * features/rs6000/powerpc-cell64l.xml: Likewise.
179 * features/rs6000/powerpc-cell32l.c: Remove generated file.
180 * features/rs6000/powerpc-cell64l.c: Likewise.
181 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
182 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
183 * regformats/reg-spu.dat: Remove.
185 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
186 * corelow.c (struct spuid_list): Remove.
187 (add_to_spuid_list): Remove.
188 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
189 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
190 (remote_protocol_features): Remove associated entries.
191 (_initialize_remote): No longer initialize them.
192 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
193 * linux-nat.c (SPUFS_MAGIC): Remove.
194 (linux_proc_xfer_spu): Remove.
195 (spu_enumerate_spu_ids): Remove.
196 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
197 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
198 (linux_make_corefile_notes): No longer call it.
200 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
201 (cooked_write_test): Likewise.
203 2019-09-20 Tom Tromey <tom@tromey.com>
205 * NEWS: Mention case-sensitivity of TUI commands.
206 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
207 (tui_set_win_height_command, parse_scrolling_args): Likewise.
208 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
210 2019-09-20 Tom Tromey <tom@tromey.com>
212 * tui/tui-source.c (tui_source_window::set_contents): Use
214 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
217 2019-09-20 Tom Tromey <tom@tromey.com>
219 * tui/tui-data.c: Remove separator comments.
220 * tui/tui-layout.c: Remove separator comments.
221 * tui/tui-win.c: Remove separator comments.
222 * tui/tui-wingeneral.c: Remove separator comments.
224 2019-09-20 Tom Tromey <tom@tromey.com>
226 * tui/tui.h (strcat_to_buf): Don't declare.
227 * tui/tui.c (strcat_to_buf): Remove.
229 2019-09-20 Tom Tromey <tom@tromey.com>
231 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
233 * tui/tui-source.c (tui_source_window::set_contents)
234 (tui_source_window::location_matches_p)
235 (tui_source_window::maybe_update): Update.
237 2019-09-20 Tom Tromey <tom@tromey.com>
239 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
241 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
243 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
244 (tui_data_window::line_from_reg_element_no)
245 (tui_data_window::first_reg_element_no_inline)
246 (tui_data_window::show_registers)
247 (tui_data_window::show_register_group)
248 (tui_data_window::display_registers_from)
249 (tui_data_window::display_registers_from_line)
250 (tui_data_window::first_data_item_displayed)
251 (tui_data_window::delete_data_content_windows)
252 (tui_data_window::erase_data_content)
253 (tui_data_window::do_scroll_vertical)
254 (tui_data_window::refresh_window)
255 (tui_data_window::check_register_values): Update.
257 2019-09-20 Tom Tromey <tom@tromey.com>
259 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
260 (struct tui_locator_window) <full_name, proc_name>: Now
262 * tui/tui-stack.c (tui_locator_window::make_status_line)
263 (tui_locator_window::set_locator_fullname)
264 (tui_locator_window::set_locator_info): Update.
265 * tui/tui-source.c (tui_source_window::set_contents)
266 (tui_source_window::showing_source_p): Update.
268 2019-09-20 Tom Tromey <tom@tromey.com>
270 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
271 Don't call tui_locator_win_info_ptr.
273 2019-09-20 Tom Tromey <tom@tromey.com>
275 * tui/tui-win.c (tui_resize_all): Don't call refresh.
277 2019-09-20 Tom Tromey <tom@tromey.com>
279 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
281 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
282 * tui/tui-layout.c (show_source_disasm_command, show_data)
283 (show_source_or_disasm_and_command): Use 1 as height for locator.
285 2019-09-20 Tom Tromey <tom@tromey.com>
287 * tui/tui.c (tui_enable): Update.
288 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
290 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
292 * tui/tui-data.c (win_resized): Now bool.
293 (tui_win_resized): Return bool.
294 (tui_set_win_resized_to): Accept a bool.
296 2019-09-20 Tom Tromey <tom@tromey.com>
298 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
299 Change type of "refresh_values_only".
300 * tui/tui-regs.c (tui_data_window::show_register_group): Change
301 type of "refresh_values_only".
303 2019-09-20 Tom Tromey <tom@tromey.com>
305 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
307 (tui_disassemble): Add "pos" parameter.
308 (tui_disasm_window::set_contents): Simplify.
310 2019-09-20 Tom Tromey <tom@tromey.com>
312 * tui/tui-winsource.h (struct tui_source_window_base)
313 <show_source_content>: Now private.
314 * tui/tui-winsource.c
315 (tui_source_window_base::show_source_content): Don't handle empty
318 2019-09-20 Tom Tromey <tom@tromey.com>
320 * tui/tui-layout.c (show_source_disasm_command)
321 (show_source_or_disasm_and_command): Don't call
324 2019-09-20 Tom Tromey <tom@tromey.com>
326 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
328 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
329 from tui_make_status_line.
330 (tui_locator_window::rerender): Update.
332 2019-09-20 Tom Tromey <tom@tromey.com>
334 * tui/tui-stack.c (tui_make_status_line): Return std::string.
335 (tui_locator_window::rerender): Update.
337 2019-09-20 Tom Tromey <tom@tromey.com>
339 * tui/tui-winsource.h (struct tui_source_window_base)
340 <~tui_source_window_base>: Don't declare.
342 * tui/tui-winsource.c (~tui_source_window_base): Remove.
343 * tui/tui-source.h (struct tui_source_window) <fullname>: New
345 * tui/tui-source.c (tui_source_window::set_contents): Update.
346 (tui_source_window::location_matches_p)
347 (tui_source_window::maybe_update): Update.
349 2019-09-20 Tom Tromey <tom@tromey.com>
351 * tui/tui-winsource.h (~tui_source_element): Remove.
352 (tui_source_element): Update.
353 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
354 * tui/tui-winsource.c (tui_show_source_line): Update.
355 * tui/tui-source.c (tui_source_window::set_contents): Update.
356 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
358 2019-09-20 Tom Tromey <tom@tromey.com>
360 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
362 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
363 tui_clear_source_windows_detail.
364 * tui/tui-winsource.h (struct tui_source_window_base)
365 <clear_detail>: Don't declare.
366 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
368 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
370 2019-09-20 Tom Tromey <tromey@adacore.com>
373 * block.c (contained_in): Fix final return value.
375 2019-09-20 Alan Modra <amodra@gmail.com>
377 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
378 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
379 (read_indirect_string_from_dwz): Use bfd accessor.
380 * dwarf2read.h (struct dwz_file <filename>): Likewise.
381 * machoread.c (macho_symfile_read_all_oso): Likewise.
382 * solib.c (solib_bfd_open): Likewise.
384 2019-09-19 Christian Biesinger <cbiesinger@google.com>
386 * eval.c: Move declaration of overload_resolution to...
389 2019-09-19 Christian Biesinger <cbiesinger@google.com>
391 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
392 * arm-linux-tdep.c: Likewise.
393 * arm-nbsd-nat.c: Likewise.
394 * arm-tdep.h: Declare arm_apcs_32.
395 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
397 2019-09-19 Christian Biesinger <cbiesinger@google.com>
399 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
400 * dwarf2read.h: Declare dwarf_always_disassemble.
402 2019-09-19 Tom de Vries <tdevries@suse.de>
405 * source-cache.c (source_cache::ensure): Catch exception thrown during
406 construction of the highlighter.
408 2019-09-18 Alan Modra <amodra@gmail.com>
410 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
411 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
412 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
413 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
414 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
415 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
416 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
417 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
418 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
419 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
420 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
421 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
422 * solib-spu.c, * solib-svr4.c, * solib-target.c,
423 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
424 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
425 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
426 * mi/mi-interp.c: Update throughout for bfd section macro and
428 * gcore (gcore_create_callback): Use bfd_set_section_lma.
429 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
431 2019-09-18 Tom Tromey <tom@tromey.com>
434 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
436 (tui_enable): Do not call rl_initialize.
438 2019-09-18 Christian Groessler <chris@groessler.org>
440 * alpha-linux-nat.c: Include gdbarch.h.
442 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
444 * ui-file.c: Include cli/cli-style.h.
445 (term_cli_styling): Remove cli_styling declaration.
447 2019-09-18 Alan Modra <amodra@gmail.com>
449 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
450 to bfd_asymbol_section.
452 2019-09-18 Alan Modra <amodra@gmail.com>
454 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
455 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
456 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
458 2019-09-18 Alan Modra <amodra@gmail.com>
460 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
461 * spu-linux-nat.c (spu_bfd_open): Likewise.
463 2019-09-18 Christian Biesinger <cbiesinger@google.com>
465 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
466 to bool to match definition in dwarf2read.c.
468 2019-09-17 Christian Biesinger <cbiesinger@google.com>
470 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
471 (print_signatures): Likewise.
472 (trust_pad_over_xvs): Likewise.
473 * arch/aarch64-insn.c (aarch64_debug): Likewise.
474 * arch/aarch64-insn.h (aarch64_debug): Likewise.
475 * arm-linux-nat.c (arm_apcs_32): Likewise.
476 * arm-linux-tdep.c (arm_apcs_32): Likewise.
477 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
478 * arm-tdep.c (arm_debug): Likewise.
479 (arm_apcs_32): Likewise.
480 * auto-load.c (debug_auto_load): Likewise.
481 (auto_load_gdb_scripts): Likewise.
482 (global_auto_load): Likewise.
483 (auto_load_local_gdbinit): Likewise.
484 (auto_load_local_gdbinit_loaded): Likewise.
485 * auto-load.h (global_auto_load): Likewise.
486 (auto_load_local_gdbinit): Likewise.
487 (auto_load_local_gdbinit_loaded): Likewise.
488 * breakpoint.c (disconnected_dprintf): Likewise.
489 (breakpoint_proceeded): Likewise.
490 (automatic_hardware_breakpoints): Likewise.
491 (always_inserted_mode): Likewise.
492 (target_exact_watchpoints): Likewise.
493 (_initialize_breakpoint): Update.
494 * breakpoint.h (target_exact_watchpoints): Change to bool.
495 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
496 * cli/cli-cmds.c (trace_commands): Likewise.
497 * cli/cli-cmds.h (trace_commands): Likewise.
498 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
500 * cli/cli-logging.c (logging_overwrite): Change to bool.
501 (logging_redirect): Likewise.
502 (debug_redirect): Likewise.
503 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
504 (struct boolean_option_def) <get_var_address_cb_>: Change return type
506 <boolean_option_def>: Update.
507 (struct flag_option_def): Change default type of Context to bool
509 <flag_option_def>: Change return type of var_address_cb_ to bool*.
510 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
511 (get_setshow_command_value_string): Likewise.
512 * cli/cli-style.c (cli_styling): Change to bool.
513 (source_styling): Likewise.
514 * cli/cli-style.h (source_styling): Likewise.
515 (cli_styling): Likewise.
516 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
518 * command.h (var_types): Update comment.
519 (add_setshow_boolean_cmd): Change int* var argument to bool*.
520 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
522 (debug_compile_cplus_scopes): Likewise.
523 * compile/compile-internal.h (compile_debug): Likewise.
524 * compile/compile.c (compile_debug): Likewise.
525 (struct compile_options) <raw>: Likewise.
526 * cp-support.c (catch_demangler_crashes): Likewise.
527 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
528 (usr_cmd_cris_dwarf2_cfi): Likewise.
529 * csky-tdep.c (csky_debug): Likewise.
530 * darwin-nat.c (enable_mach_exceptions): Likewise.
531 * dcache.c (dcache_enabled_p): Likewise.
532 * defs.h (info_verbose): Likewise.
533 * demangle.c (demangle): Likewise.
534 (asm_demangle): Likewise.
535 * dwarf-index-cache.c (debug_index_cache): Likewise.
536 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
537 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
538 * dwarf2read.c (check_physname): Likewise.
539 (use_deprecated_index_sections): Likewise.
540 (dwarf_always_disassemble): Likewise.
541 * eval.c (overload_resolution): Likewise.
542 * event-top.c (set_editing_cmd_var): Likewise.
543 (exec_done_display_p): Likewise.
544 * event-top.h (set_editing_cmd_var): Likewise.
545 (exec_done_display_p): Likewise.
546 * exec.c (write_files): Likewise.
547 * fbsd-nat.c (debug_fbsd_lwp): Likewise
548 (debug_fbsd_nat): Likewise.
549 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
551 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
552 <backtrace_past_entry> Likewise.
553 * gdb-demangle.h (demangle): Likewise.
554 (asm_demangle): Likewise.
555 * gdb_bfd.c (bfd_sharing): Likewise.
556 * gdbcore.h (write_files): Likewise.
557 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
558 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
559 * gdbthread.h (print_thread_events): Likewise.
560 * gdbtypes.c (opaque_type_resolution): Likewise.
561 (strict_type_checking): Likewise.
562 * gnu-nat.c (gnu_debug_flag): Likewise.
563 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
564 * guile/scm-param.c (pascm_variable): Add boolval.
565 (add_setshow_generic): Update.
566 (pascm_param_value): Update.
567 (pascm_set_param_value_x): Update.
568 * hppa-tdep.c (hppa_debug): Change to bool..
569 * infcall.c (may_call_functions_p): Likewise.
570 (coerce_float_to_double_p): Likewise.
571 (unwind_on_signal_p): Likewise.
572 (unwind_on_terminating_exception_p): Likewise.
573 * infcmd.c (startup_with_shell): Likewise.
574 * inferior.c (print_inferior_events): Likewise.
575 * inferior.h (startup_with_shell): Likewise.
576 (print_inferior_events): Likewise.
577 * infrun.c (step_stop_if_no_debug): Likewise.
578 (detach_fork): Likewise.
579 (debug_displaced): Likewise.
580 (disable_randomization): Likewise.
581 (non_stop): Likewise.
582 (non_stop_1): Likewise.
583 (observer_mode): Likewise.
584 (observer_mode_1): Likewise.
585 (set_observer_mode): Update.
586 (sched_multi): Change to bool.
587 * infrun.h (debug_displaced): Likewise.
588 (sched_multi): Likewise.
589 (step_stop_if_no_debug): Likewise.
590 (non_stop): Likewise.
591 (disable_randomization): Likewise.
592 * linux-tdep.c (use_coredump_filter): Likewise.
593 (dump_excluded_mappings): Likewise.
594 * linux-thread-db.c (auto_load_thread_db): Likewise.
595 (check_thread_db_on_load): Likewise.
596 * main.c (captured_main_1): Update.
597 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
598 xx2_opt, boolean_opt>: Change to bool.
599 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
600 * maint.c (maintenance_profile_p): Likewise.
601 (per_command_time): Likewise.
602 (per_command_space): Likewise.
603 (per_command_symtab): Likewise.
604 * memattr.c (inaccessible_by_default): Likewise.
605 * mi/mi-main.c (mi_async): Likewise.
606 (mi_async_1): Likewise.
607 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
608 * nat/fork-inferior.h (startup_with_shell): Likewise.
609 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
610 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
611 * nios2-tdep.c (nios2_debug): Likewise.
612 * or1k-tdep.c (or1k_debug): Likewise.
613 * parse.c (parser_debug): Likewise.
614 * parser-defs.h (parser_debug): Likewise.
615 * printcmd.c (print_symbol_filename): Likewise.
616 * proc-api.c (procfs_trace): Likewise.
617 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
618 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
619 (set_parameter_value): Update.
620 (add_setshow_generic): Update.
621 * python/py-value.c (copy_py_bool_obj): Change argument from int*
623 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
625 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
626 * record-btrace.c (record_btrace_target::store_registers): Update.
627 * record-full.c (record_full_memory_query): Change to bool.
628 (record_full_stop_at_limit): Likewise.
629 * record-full.h (record_full_memory_query): Likewise.
630 * remote-notif.c (notif_debug): Likewise.
631 * remote-notif.h (notif_debug): Likewise.
632 * remote.c (use_range_stepping): Likewise.
633 (interrupt_on_connect): Likewise.
634 (remote_break): Likewise.
635 * ser-tcp.c (tcp_auto_retry): Likewise.
636 * ser-unix.c (serial_hwflow): Likewise.
637 * skip.c (debug_skip): Likewise.
638 * solib-aix.c (solib_aix_debug): Likewise.
639 * spu-tdep.c (spu_stop_on_load_p): Likewise.
640 (spu_auto_flush_cache_p): Likewise.
641 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
643 (struct info_print_options) <quiet>: Likewise.
644 * symfile-debug.c (debug_symfile): Likewise.
645 * symfile.c (auto_solib_add): Likewise.
646 (separate_debug_file_debug): Likewise.
647 * symfile.h (auto_solib_add): Likewise.
648 (separate_debug_file_debug): Likewise.
649 * symtab.c (basenames_may_differ): Likewise.
650 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
651 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
652 (struct info_types_options) <quiet>: Likewise.
653 * symtab.h (demangle): Likewise.
654 (basenames_may_differ): Likewise.
655 * target-dcache.c (stack_cache_enabled_1): Likewise.
656 (code_cache_enabled_1): Likewise.
657 * target.c (trust_readonly): Likewise.
658 (may_write_registers): Likewise.
659 (may_write_memory): Likewise.
660 (may_insert_breakpoints): Likewise.
661 (may_insert_tracepoints): Likewise.
662 (may_insert_fast_tracepoints): Likewise.
663 (may_stop): Likewise.
664 (auto_connect_native_target): Likewise.
665 (target_stop_and_wait): Update.
666 (target_async_permitted): Change to bool.
667 (target_async_permitted_1): Likewise.
668 (may_write_registers_1): Likewise.
669 (may_write_memory_1): Likewise.
670 (may_insert_breakpoints_1): Likewise.
671 (may_insert_tracepoints_1): Likewise.
672 (may_insert_fast_tracepoints_1): Likewise.
673 (may_stop_1): Likewise.
674 * target.h (target_async_permitted): Likewise.
675 (may_write_registers): Likewise.
676 (may_write_memory): Likewise.
677 (may_insert_breakpoints): Likewise.
678 (may_insert_tracepoints): Likewise.
679 (may_insert_fast_tracepoints): Likewise.
680 (may_stop): Likewise.
681 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
682 (make_thread_apply_all_options_def_group): Change argument from int*
684 (thread_apply_all_command): Update.
685 (print_thread_events): Change to bool.
686 * top.c (confirm): Likewise.
687 (command_editing_p): Likewise.
688 (history_expansion_p): Likewise.
689 (write_history_p): Likewise.
690 (info_verbose): Likewise.
691 * top.h (confirm): Likewise.
692 (history_expansion_p): Likewise.
693 * tracepoint.c (disconnected_tracing): Likewise.
694 (circular_trace_buffer): Likewise.
695 * typeprint.c (print_methods): Likewise.
696 (print_typedefs): Likewise.
697 * utils.c (debug_timestamp): Likewise.
698 (sevenbit_strings): Likewise.
699 (pagination_enabled): Likewise.
700 * utils.h (sevenbit_strings): Likewise.
701 (pagination_enabled): Likewise.
702 * valops.c (overload_resolution): Likewise.
703 * valprint.h (struct value_print_options) <prettyformat_arrays,
704 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
705 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
706 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
708 * windows-nat.c (new_console): Likewise.
709 (cygwin_exceptions): Likewise.
710 (new_group): Likewise.
711 (debug_exec): Likewise.
712 (debug_events): Likewise.
713 (debug_memory): Likewise.
714 (debug_exceptions): Likewise.
715 (useshell): Likewise.
716 * windows-tdep.c (maint_display_all_tib): Likewise.
717 * xml-support.c (debug_xml): Likewise.
719 2019-09-17 Mike Gulick <mgulick@mathworks.com>
721 * source.c (prepare_path_for_appending): New function.
722 (openp): Make use of new function.
723 (find_and_open_source): Search for the compilation directory and
724 source file as a relative path beneath the directory search path.
726 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
728 * source-cache.c (source_cache::get_line_charpos): Catch
729 exceptions and return false, this matches the behaviour documented
732 2019-09-17 Joel Brobecker <brobecker@adacore.com>
734 * ada-tasks.c (info_task): Remove quoting of the task's name.
736 2019-09-16 Christian Biesinger <cbiesinger@google.com>
738 * symfile.c (auto_solib_add): Replace comment with a reference
741 2019-09-14 Christian Biesinger <cbiesinger@google.com>
743 * NEWS: Mention that gdb can now be compiled with Python 3
746 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
748 * maint.c (maint_print_section_data::maint_print_section_data):
749 Force use of 'float log10 (float)' by casting the argument to
752 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
754 * maint.c: Add 'cmath' include.
755 (struct maint_print_section_data): New structure.
756 (print_section_index): New function.
757 (print_bfd_section_info): Add header comment, small whitespace
758 cleanup, and update to call new print_section_index function.
759 (print_objfile_section_info): Likewise.
760 (maint_obj_section_from_bfd_section): New function.
761 (print_bfd_section_info_maybe_relocated): New function.
762 (maintenance_info_sections): Add header comment, always use
763 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
765 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
767 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
768 inner scope, add check that the objfile has psymtabs before
769 checking psymtabs_addrmap.
770 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
772 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
774 * NEWS: Announce that Ada task names are now shown at more places,
775 and between quotes (except in info task output).
776 * gdb/ada-tasks.c (task_to_str): New function.
777 (display_current_task_id): Call task_to_str.
778 (task_command_1): Likewise.
779 (print_ada_task_info): In non-mi mode, Properly align headers and data
780 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
782 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
784 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
785 prstatus.pr_lwp.pr_info instead of making it up.
787 2019-09-11 Christian Biesinger <cbiesinger@google.com>
789 * auto-load.c (auto_load_expand_dir_vars): Update.
790 * defs.h (gdb_datadir): Change to std::string.
791 (python_libdir): Likewise.
792 (relocate_gdb_directory): Change return type to std::string.
793 * guile/guile.c (gdbscm_data_directory): Update.
794 (initialize_scheme_side): Update.
795 * jit.c (jit_reader_dir): Change to std::string.
796 (jit_reader_load_command): Update.
797 * main.c (gdb_datadir): Change to std::string.
798 (python_libdir): Likewise.
799 (set_gdb_data_directory): Update.
800 (relocate_path): Change to return std::string.
801 (relocate_gdb_directory): Change to return std::string.
802 (relocate_gdbinit_path_maybe_in_datadir): Update.
803 (captured_main_1): Update.
804 * python/python.c (do_start_initialization): Update.
805 * top.c (show_gdb_datadir): Update.
806 * xml-syscall.c (xml_init_syscalls_info): Update.
807 (init_syscalls_info): Update.
809 2019-09-11 Christian Biesinger <cbiesinger@google.com>
811 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
812 out of get_init_files.
813 (get_init_files): Update.
815 2019-09-11 Christian Biesinger <cbiesinger@google.com>
817 * main.c (get_init_files): Change to use std::string.
818 (captured_main_1): Update.
819 (print_gdb_help): Update.
821 2019-09-11 Ali Tamur <tamur@google.com>
823 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
826 2019-09-11 Christian Biesinger <cbiesinger@google.com>
828 * dbxread.c (read_dbx_symtab): Update.
829 * dwarf2read.c (load_partial_dies): Update.
830 * mdebugread.c (parse_partial_symbols): Update.
831 (handle_psymbol_enumerators): Update.
832 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
833 * psymtab.c (add_psymbol_to_bcache): Likewise.
834 (add_psymbol_to_list): Likewise.
835 * symtab.c (symbol_set_names): Likewise.
836 * symtab.h (symbol_set_names): Likewise.
837 * xcoffread.c (scan_xcoff_symtab): Update.
839 2019-09-11 Tom Tromey <tom@tromey.com>
841 * symfile-mem.c (symbol_file_add_from_memory): Use
843 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
844 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
846 2019-09-10 Tom Tromey <tromey@adacore.com>
848 * dwarf-index-write.c (write_psymbols): Extend error message.
849 (debug_names::insert): Add Ada code.
850 (debug_names::write_psymbols): Remove Ada check.
851 (debug_names) <m_string_obstack>: New member.
852 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
853 (gdb_index_symbol_name_matcher::matches): Remove.
854 (mapped_index_base::find_name_components_bounds): Add "lang"
856 (mapped_index_base::build_name_components): Also split names
857 according to Ada syntax.
858 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
859 type of "match_callback".
860 (check_match, check_find_bounds_finds)
861 (dw2_expand_symtabs_matching): Update.
862 (dw2_debug_names_iterator): Add new constructor.
863 (dw2_debug_names_map_matching_symbols): New function.
864 (dw2_debug_names_expand_symtabs_matching): Update.
865 (dwarf2_debug_names_functions): Use
866 dw2_debug_names_map_matching_symbols.
868 2019-09-10 Tom Tromey <tromey@adacore.com>
870 * dwarf2read.c (dw2_get_file_names_reader): Add the
871 CU's file name to the results.
873 2019-09-10 Tom Tromey <tromey@adacore.com>
875 * ada-lang.c (add_nonlocal_symbols): Combine calls to
876 map_matching_symbols. Update.
877 * dwarf2read.c (dw2_map_matching_symbols): Update.
878 * psymtab.c (match_partial_symbol): Change type; update.
879 (psym_map_matching_symbols): Likewise.
880 * symfile-debug.c (debug_qf_map_matching_symbols): Change
882 * symfile.h (struct quick_symbol_functions)
883 <map_matching_symbols>: Change "name" to be a lookup_name_info.
886 2019-09-10 Tom Tromey <tromey@adacore.com>
888 * psymtab.c (map_block): Remove.
889 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
890 * symtab.c (iterate_over_symbols_terminated): New function.
891 * symtab.c (iterate_over_symbols_terminated): Declare.
893 2019-09-10 Tom Tromey <tromey@adacore.com>
895 * ada-lang.c (ada_iterate_over_symbols): Return bool.
896 * language.h (struct language_defn) <la_iterate_over_symbols>:
898 * symtab.c (iterate_over_symbols): Return bool.
899 * symtab.h (iterate_over_symbols): Return bool.
901 2019-09-10 Tom Tromey <tromey@adacore.com>
903 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
904 (add_nonlocal_symbols): Update.
905 * dwarf2read.c (dw2_map_matching_symbols): Change type.
906 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
907 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
908 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
909 Change type of "callback". Remove "data".
912 2019-09-09 Ali Tamur <tamur@google.com>
914 * dwarf2read.c (comp_unit_head): Update comment.
915 (dwarf2_dwo_name): New function declaration.
916 (dwarf_unit_type_name): New function declaration.
917 (read_comp_unit_head): Add support for new compilation units,
918 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
919 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
920 (currently named as "signature") in their header. Also clarify error
922 (lookup_dwo_id): New function. Returns the dwo id of the given
924 (lookup_dwo_unit): Use the new lookup_dwo_id function.
925 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
927 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
928 (dwarf2_dwo_name): Get the dwo name if present.
929 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
932 2019-09-09 Tom Tromey <tom@tromey.com>
934 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
936 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
938 * python/python.c (do_start_initialization): Make progname_copy static,
939 to avoid a leak report.
941 2019-09-08 Tom Tromey <tom@tromey.com>
943 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
945 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
947 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
948 Change type to gdb::optional<block_enum>.
949 (dw2_symtab_iter_init): Change block_index parameter type
950 to gdb::optional<block_enum>.
951 (dw2_lookup_symbol): Change block_index parameter
953 (dw2_debug_names_lookup_symbol): Likewise.
954 * psymtab.c (psym_lookup_symbol): Likewise.
955 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
956 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
959 2019-09-06 Christian Biesinger <cbiesinger@google.com>
961 * defs.h (relocate_gdb_directory): Change int to bool in
962 signature and rename flag to relocatable.
963 * main.c (relocate_path): Likewise.
964 (relocate_gdb_directory): Likewise.
966 2019-09-06 Alan Modra <amodra@gmail.com>
968 * coffread.c (coff_symfile_read): Constify filename variable.
969 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
970 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
971 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
972 * solib.c (reload_shared_libraries_1): Likewise.
973 * symfile.c (reread_symbols): Likewise.
974 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
975 * solib-darwin.c (darwin_bfd_open): Likewise.
976 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
978 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
980 * psymtab.c (print_partial_symbols): Handle missing domain_enum
981 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
983 2019-09-03 Tom Tromey <tromey@adacore.com>
985 * ada-valprint.c (ada_val_print_num): Don't recurse for range
987 (has_negatives): Unbias a range type bound.
988 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
989 * gdbtypes.c (operator==): Handle new field.
990 (create_range_type): Add "bias" parameter.
991 (create_static_range_type, resolve_dynamic_range): Update.
992 * gdbtypes.h (struct range_bounds) <bias>: New member.
993 (create_range_type): Add bias parameter.
994 * printcmd.c (print_scalar_formatted): Unbias range types.
995 * value.c (unpack_long): Unbias range types.
996 (pack_long): Bias range types.
998 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1000 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1003 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1005 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1006 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1007 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1008 (compile_probe_arg): Likewise.
1009 * probe.h (get_argument_count): Likewise.
1010 * solib-svr4.c (solib_event_probe_action): Likewise.
1011 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1013 2019-09-02 Alan Hayward <alan.hayward@arm.com>
1015 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1017 (svr4_create_solib_event_breakpoints): ...from here.
1019 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1021 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1022 suffix from warning message.
1024 2019-08-30 Tom Tromey <tom@tromey.com>
1026 * tui/tui-winsource.h (struct tui_source_window_base)
1027 <refresh_all>: Don't declare.
1028 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1030 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1031 tui_show_locator_content.
1032 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1034 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1035 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1038 2019-08-30 Tom Tromey <tom@tromey.com>
1040 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1042 2019-08-30 Tom Tromey <tom@tromey.com>
1044 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1045 Remove unnecessary forward declarations.
1047 2019-08-30 Tom Tromey <tom@tromey.com>
1049 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1051 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1052 tui_show_locator_content.
1054 2019-08-30 Tom Tromey <tom@tromey.com>
1056 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1057 (tui_locator_window::rerender): Rewrite using body of previous
1058 tui_show_locator_content.
1060 2019-08-30 Tom Tromey <tom@tromey.com>
1062 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1063 set_locator_fullname>: New methods.
1064 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1065 Rename from tui_set_locator_fullname.
1066 (tui_locator_window::set_locator_info): Rename from
1067 tui_set_locator_info. Return bool.
1068 (tui_update_locator_fullname, tui_show_frame_info): Update.
1070 2019-08-30 Tom Tromey <tom@tromey.com>
1072 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1074 2019-08-30 Tom Tromey <tom@tromey.com>
1076 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1079 2019-08-30 Tom Tromey <tom@tromey.com>
1081 * tui/tui-wingeneral.c (box_win): Assume win_info and
1082 win_info->handle cannot be NULL.
1084 2019-08-30 Tom Tromey <tom@tromey.com>
1086 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1087 refresh_window>: Declare.
1088 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1090 (tui_data_item_window::rerender): Rename from
1091 tui_display_register.
1092 (tui_data_item_window::refresh_window): New method.
1093 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1096 2019-08-30 Tom Tromey <tom@tromey.com>
1098 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1099 regs_column_count, current_group>: Move later. Now private.
1100 <get_current_group>: New method.
1101 * tui/tui-regs.c (tui_reg_command): Update.
1102 * tui/tui-layout.c (tui_set_layout): Update.
1104 2019-08-30 Tom Tromey <tom@tromey.com>
1106 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1107 (tui_data_window::rerender): Don't call
1108 check_and_display_highlight_if_needed.
1109 (tui_data_window::refresh_all): Remove call to
1112 2019-08-30 Tom Tromey <tom@tromey.com>
1114 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1115 (tui_data_window::display_registers_from)
1116 (tui_data_window::display_reg_element_at_line)
1117 (tui_data_window::display_registers_from_line): Remove checks of
1120 2019-08-30 Tom Tromey <tom@tromey.com>
1122 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1124 * tui/tui-regs.c (tui_data_window::show_registers): Call
1126 (tui_data_window::rerender): Rename from display_all_data.
1127 (tui_data_window::rerender): Remove old implementation.
1129 2019-08-30 Tom Tromey <tom@tromey.com>
1131 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1133 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1135 2019-08-29 Bernhard Wodok <barto@gmx.net>
1136 Sergio Durigan Junior <sergiodj@redhat.com>
1139 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1141 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1143 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1144 when searching for types.
1146 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1148 * f-lang.c (f_language_defn): Use f_print_typedef.
1149 * f-lang.h (f_print_typedef): Declare.
1150 * f-typeprint.c (f_print_typedef): Define.
1152 2019-08-27 Christian Biesinger <cbiesinger@google.com>
1154 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1156 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1158 * cli/cli-utils.c (info_print_options_defs): Delete.
1159 (make_info_print_options_def_group): Delete.
1160 (extract_info_print_options): Delete.
1161 (info_print_command_completer): Delete.
1162 (info_print_args_help): Add extra parameter, and optionally
1163 include text about -n flag.
1164 * cli/cli-utils.h (struct info_print_options): Delete.
1165 (extract_info_print_options): Delete declaration.
1166 (info_print_command_completer): Delete declaration.
1167 (info_print_args_help): Add extra parameter, extend header
1169 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1171 * stack.c (struct info_print_options): New type.
1172 (info_print_options_defs): New file scoped variable.
1173 (make_info_print_options_def_group): New static function.
1174 (info_print_command_completer): New static function.
1175 (info_locals_command): Update to use new local functions.
1176 (info_args_command): Likewise.
1177 (_initialize_stack): Add extra parameter to calls to
1178 info_print_args_help.
1179 * symtab.c (search_symbols): Add extra parameter, use this to
1180 possibly excluse non-debug symbols.
1181 (symtab_symbol_info): Add extra parameter, which is passed on to
1183 (struct info_print_options): New type.
1184 (info_print_options_defs): New file scoped variable.
1185 (make_info_print_options_def_group): New static function.
1186 (info_print_command_completer): New static function.
1187 (info_variables_command): Update to use local functions, and pass
1188 extra parameter through to symtab_symbol_info.
1189 (info_functions_command): Likewise.
1190 (info_types_command): Pass additional argument through to
1192 (rbreak_command): Pass extra argument to search_symbols.
1193 (_initialize_symtab): Add extra arguments for calls to
1194 info_print_args_help, and update help text for 'info variables',
1195 'whereis', and 'info functions' commands.
1196 * symtab.h (search_symbols): Add extra argument to declaration.
1197 * NEWS: Mention new flags.
1199 2019-08-26 Christian Biesinger <cbiesinger@google.com>
1201 * symtab.c (lookup_static_symbol): Call the new function (and move
1202 it down to be next to lookup_global_symbol).
1203 (struct global_sym_lookup_data): Add block_enum member and rename to...
1204 (struct global_or_static_sym_lookup_data): ...this.
1205 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1206 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1207 (lookup_symbol_global_or_static_iterator_cb): ...this.
1208 (lookup_global_or_static_symbol): New function.
1209 (lookup_global_symbol): Call new function.
1211 2019-08-26 Tom de Vries <tdevries@suse.de>
1214 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1215 when pc_probe.prob == NULL.
1217 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
1219 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1220 variable symbol_linkage to symbol_linkage_.
1222 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
1224 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1225 represent whether the symbol is static, dynamic, or we don't
1228 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1230 * gdb/rx-tdep.c (rx_register_names): New.
1231 (rx_register_name): Delete.
1232 (rx_psw_type): Delete.
1233 (rx_fpsw_type): Delete.
1234 (rx_register_type): Delete.
1235 (rx_gdbarch_init): Convert target-descriptions.
1236 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1237 * gdb/features/Makefile: Add rx.xml.
1238 * gdb/features/rx.xml: New.
1239 * gdb/features/rx.c: Generated.
1240 * gdb/NEWS: Mention target description support.
1242 2019-08-22 Christian Biesinger <cbiesinger@google.com>
1244 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1247 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1249 * configure.ac: Don't check for 'dlfcn.h' (moved to
1250 gdbsupport/common.m4).
1251 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1253 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1254 * compile/compile-c-support.c: Include
1255 'gdbsupport/gdb-dlfcn.h'.
1256 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1257 * gdb-dlfcn.c: Move to...
1258 * gdbsupport/gdb-dlfcn.c: ... here.
1259 * gdb-dlfcn.h: Move to...
1260 * gdbsupport/gdb-dlfcn.h: ... here.
1262 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1264 * nios2-tdep.c (struct reg_value): Improve comments. Make
1265 the offset field signed.
1267 2019-08-22 Christian Biesinger <cbiesinger@google.com>
1269 * python/lib/gdb/__init__.py (_execute_file): New function.
1270 * python/python.c (python_run_simple_file): Call gdb._execute_file
1273 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1275 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1276 all uses as this was never set to anything but a zero value.
1278 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1280 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1282 2019-08-21 Christian Biesinger <cbiesinger@google.com>
1284 * tui/tui-data.h (tui_gen_win_info): Add an =default
1285 move constructor, required by some GCC versions.
1287 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
1289 * go32-nat.c (go32_sysinfo): Add hygon_p.
1291 2019-08-20 Tom Tromey <tom@tromey.com>
1293 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1294 line_from_reg_element_no, first_reg_element_no_inline,
1295 display_all_data, delete_data_content_windows,
1296 erase_data_content>: Now private.
1298 2019-08-20 Tom Tromey <tom@tromey.com>
1300 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1301 (tui_unhighlight_win, tui_highlight_win)
1302 (tui_win_info::make_window): Update.
1303 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1305 2019-08-20 Tom Tromey <tom@tromey.com>
1307 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1308 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1309 (MAX_PID_WIDTH): Move to tui-stack.c.
1310 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1311 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1312 (MAX_PID_WIDTH): Move from tui-data.h.
1314 2019-08-20 Tom Tromey <tom@tromey.com>
1316 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1317 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1319 (tui_gen_win_info::make_window): Rename from tui_make_window.
1320 (tui_win_info::make_window): New method.
1321 (tui_gen_win_info::make_visible): Update.
1322 * tui/tui-source.c (tui_source_window::set_contents): Update.
1323 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1324 (tui_data_window::display_registers_from): Update.
1325 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1326 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1330 (struct tui_win_info) <make_window>: Declare.
1331 <can_box>: Now virtual.
1332 <title>: New member.
1333 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1334 * tui/tui-command.c (tui_cmd_window::resize): Update.
1336 2019-08-20 Tom Tromey <tom@tromey.com>
1338 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1339 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1340 (tui_data_window::check_register_values): Update.
1342 2019-08-20 Tom Tromey <tom@tromey.com>
1344 * tui/tui-regs.h (struct tui_data_window): Use
1345 DISABLE_COPY_AND_ASSIGN.
1346 <regs_content>: Change type, removing unique_ptr.
1347 <tui_data_window>: Add move constructor.
1348 * tui/tui-regs.c (tui_data_window::show_registers)
1349 (tui_data_window::show_register_group)
1350 (tui_data_window::display_registers_from)
1351 (tui_data_window::display_registers_from)
1352 (tui_data_window::first_data_item_displayed)
1353 (tui_data_window::delete_data_content_windows)
1354 (tui_data_window::rerender, tui_data_window::refresh_window)
1355 (tui_data_window::check_register_values): Update.
1357 2019-08-20 Tom Tromey <tom@tromey.com>
1359 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1360 show_register_group>: Declare.
1361 (tui_show_register_group): Don't declare.
1362 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1364 (tui_data_window::show_register_group): Rename from
1365 tui_show_register_group.
1366 (tui_data_window::check_register_values, tui_reg_command):
1368 * tui/tui-layout.c (tui_set_layout): Update.
1370 2019-08-20 Tom Tromey <tom@tromey.com>
1372 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1374 (tui_check_register_values): Don't declare.
1375 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1376 from tui_check_register_values.
1377 * tui/tui-hooks.c (tui_register_changed): Update.
1379 2019-08-20 Tom Tromey <tom@tromey.com>
1381 * tui/tui-regs.c (tui_reg_layout): Move later.
1382 (tui_show_registers): Don't enable TUI mode or change layout.
1384 2019-08-20 Tom Tromey <tom@tromey.com>
1386 * tui/tui-regs.h (struct tui_data_item_window)
1387 <~tui_data_item_window>: Remove.
1388 <content>: Now a unique_xmalloc_ptr.
1389 * tui/tui-regs.c (tui_register_format): Return a
1391 (tui_get_register): Update.
1392 (~tui_data_item_window): Remove.
1393 (tui_data_window::display_registers_from, tui_display_register):
1395 * tui/tui-io.h (tui_expand_tabs): Update.
1396 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1397 Remove "col" parameter.
1399 2019-08-20 Tom Tromey <tom@tromey.com>
1401 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1403 * tui/tui-regs.c (~tui_data_item_window): Update.
1405 2019-08-20 Tom Tromey <tom@tromey.com>
1407 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1410 2019-08-20 Tom Tromey <tom@tromey.com>
1412 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1414 2019-08-20 Tom Tromey <tom@tromey.com>
1416 * tui/tui-source.h (struct tui_source_window): Update.
1417 * tui/tui-regs.c (tui_show_registers): Update.
1418 * tui/tui-disasm.h (struct tui_disasm_window): Update.
1419 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1420 (NO_REGS_STRING): Remove defines.
1422 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
1424 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1425 unnecessary thread walk if remote doesn't support the packet.
1427 2019-08-19 Tom Tromey <tromey@adacore.com>
1429 * python/py-value.c (value_has_field): Fix indentation.
1431 2019-08-19 Tom Tromey <tromey@adacore.com>
1433 * printcmd.c (do_one_display, info_display_command): Update.
1434 * block.h (contained_in): Return bool. Add allow_nested
1436 * block.c (contained_in): Return bool. Add allow_nested
1439 2019-08-19 Tom Tromey <tom@tromey.com>
1441 * configure: Rebuild.
1442 * configure.ac: Disallow the combination of -static-libstdc++ and
1444 * source-cache.c (get_language_name): Handle rust.
1445 (source_cache::get_source_lines): Ignore highlighting exceptions.
1447 2019-08-16 Tom Tromey <tom@tromey.com>
1449 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1450 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1451 (struct tui_source_window_base) <make_visible, refresh_window,
1452 resize>: Remove methods.
1453 <execution_info>: Remove field.
1454 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1455 (tui_show_source_line, tui_source_window_base)
1456 (~tui_source_window_base): Update.
1457 (tui_source_window_base::resize)
1458 (tui_source_window_base::make_visible)
1459 (tui_source_window_base::refresh_window): Remove.
1460 (tui_source_window_base::update_exec_info): Update.
1461 * tui/tui-source.c (tui_source_window::set_contents): Update.
1462 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1464 2019-08-16 Tom Tromey <tom@tromey.com>
1466 * tui/tui-hooks.c (tui_remove_hooks): Don't set
1467 deprecated_query_hook.
1469 2019-08-16 Tom Tromey <tom@tromey.com>
1471 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1472 (tui_update_source_windows_with_line): Update.
1473 * tui/tui-source.h (struct tui_source_window)
1474 <show_symtab_source>: Declare.
1475 (tui_show_symtab_source): Don't declare.
1476 * tui/tui-source.c (tui_show_symtab_source): Rename from
1477 tui_show_symtab_source.
1479 2019-08-16 Tom Tromey <tom@tromey.com>
1481 * tui/tui-winsource.h (struct tui_source_window_base)
1482 <set_contents>: Declare.
1483 * tui/tui-winsource.c
1484 (tui_source_window_base::update_source_window_as_is): Update.
1485 * tui/tui-source.h (struct tui_source_window) <set_contents>:
1487 (tui_set_source_content): Don't declare.
1488 * tui/tui-source.c (tui_source_window::set_contents): Rename from
1489 tui_set_source_content.
1490 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1492 (tui_set_disassem_content): Don't declare.
1493 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1494 tui_set_disassem_content.
1496 2019-08-16 Tom Tromey <tom@tromey.com>
1498 * tui/tui-winsource.h (struct tui_source_window_base)
1499 <update_breakpoint_info>: Declare.
1500 (tui_update_breakpoint_info): Don't declare.
1501 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1502 (tui_update_all_breakpoint_info): Update.
1503 (tui_source_window_base::update_breakpoint_info): Rename from
1504 tui_update_breakpoint_info.
1505 (tui_source_window_base::update_exec_info): Update.
1507 2019-08-16 Tom Tromey <tom@tromey.com>
1509 * tui/tui-winsource.h (struct tui_source_window_base)
1510 <update_source_window>: Declare.
1511 (tui_update_source_window): Don't declare.
1512 * tui/tui-winsource.c
1513 (tui_source_window_base::update_source_window): Rename from
1514 tui_update_source_window.
1515 (tui_source_window_base::rerender): Update.
1516 * tui/tui-source.c (tui_source_window::maybe_update): Update.
1517 * tui/tui-disasm.c (tui_show_disassem)
1518 (tui_show_disassem_and_update_source)
1519 (tui_disasm_window::maybe_update): Update.
1521 2019-08-16 Tom Tromey <tom@tromey.com>
1523 * tui/tui-winsource.h (struct tui_source_window_base)
1524 <update_source_window_as_is>: Declare.
1525 (tui_update_source_window_as_is): Don't declare.
1526 * tui/tui-winsource.c (tui_update_source_window): Update
1527 (tui_source_window_base::update_source_window_as_is): Rename from
1528 tui_update_source_window_as_is.
1529 (tui_source_window_base::refill): Update.
1530 * tui/tui-source.c (tui_show_symtab_source): Update.
1531 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1534 2019-08-16 Tom Tromey <tom@tromey.com>
1536 * tui/tui-winsource.h (tui_update_source_window)
1537 (tui_update_source_window_as_is): Remove "noerror" parameter.
1538 * tui/tui-winsource.c (tui_update_source_window)
1539 (tui_update_source_window_as_is): Remove "noerror" parameter.
1540 (tui_update_source_windows_with_addr)
1541 (tui_update_source_windows_with_line)
1542 (tui_source_window_base::rerender)
1543 (tui_source_window_base::refill): Update.
1544 * tui/tui-source.h (tui_set_source_content)
1545 (tui_show_symtab_source): Remove "noerror" parameter.
1546 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1548 (tui_show_symtab_source): Likewise.
1549 (tui_source_window::maybe_update): Update.
1550 * tui/tui-disasm.c (tui_show_disassem)
1551 (tui_show_disassem_and_update_source)
1552 (tui_disasm_window::do_scroll_vertical)
1553 (tui_disasm_window::maybe_update): Update.
1555 2019-08-16 Tom Tromey <tom@tromey.com>
1557 * tui/tui.c (tui_is_window_visible): Update.
1558 * tui/tui-wingeneral.c (tui_make_window)
1559 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1560 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1561 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1562 (tui_set_win_height_command, parse_scrolling_args): Update.
1563 * tui/tui-source.c (tui_source_window::style_changed): Update.
1564 * tui/tui-regs.c (tui_show_registers)
1565 (tui_data_window::first_data_item_displayed)
1566 (tui_data_window::delete_data_content_windows)
1567 (tui_check_register_values, tui_reg_command): Update.
1568 * tui/tui-disasm.c (tui_show_disassem): Update.
1569 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1571 <is_visible>: Remove field.
1572 * tui/tui-data.c (tui_next_win, tui_prev_win)
1573 (tui_delete_invisible_windows): Update.
1575 2019-08-16 Tom Tromey <tom@tromey.com>
1577 * tui/tui-winsource.h (struct tui_source_window_base)
1578 <m_has_locator>: Remove.
1579 * tui/tui-layout.c (show_source_disasm_command, show_data)
1580 (show_source_or_disasm_and_command): Update.
1582 2019-08-16 Alan Hayward <alan.hayward@arm.com>
1584 * NEWS (Other MI changes): New subsection.
1585 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1586 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1587 * arch-utils.c (default_get_pc_address_flags): New function.
1588 * arch-utils.h (default_get_pc_address_flags): New declaration.
1589 * gdbarch.sh: Add get_pc_address_flags.
1590 * gdbarch.c: Regenerate.
1591 * gdbarch.h: Likewise.
1592 * stack.c (print_pc): New function.
1593 (print_frame_info) (print_frame): Call print_pc.
1595 2019-08-16 Tom de Vries <tdevries@suse.de>
1597 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1598 print_objfile_section_info.
1600 2019-08-15 Tom Tromey <tom@tromey.com>
1602 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1603 calling update_cmdwin_start_line.
1604 * tui/tui-winsource.h (struct tui_source_window_base)
1605 <do_make_visible_with_new_height, set_new_height>: Don't declare.
1606 <rerender>: Declare.
1607 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1609 (tui_source_window_base::set_new_height): Remove.
1610 (tui_source_window_base::rerender): Rename from
1611 do_make_visible_with_new_height.
1612 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1614 (tui_win_info::make_invisible_and_set_new_height)
1615 (tui_win_info::make_visible_with_new_height): Remove.
1616 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1618 * tui/tui-stack.c (tui_locator_window::rerender): New method.
1619 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1620 do_make_visible_with_new_height>: Don't declare.
1621 <rerender>: Declare.
1622 * tui/tui-regs.c (tui_data_window::rerender): Rename from
1624 (tui_data_window::do_make_visible_with_new_height): Remove.
1625 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1626 call tui_show_locator_content.
1627 (tui_gen_win_info::resize): Call rerender.
1628 (show_source_or_disasm_and_command): Don't call
1629 tui_show_locator_content.
1630 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1632 (struct tui_win_info) <rerender>: Declare.
1633 <set_new_height, make_invisible_and_set_new_height,
1634 make_visible_with_new_height>: Don't declare.
1635 * tui/tui-data.c (tui_win_list::rerender): New method.
1636 * tui/tui-command.h (struct tui_cmd_window)
1637 <do_make_visible_with_new_height>: Don't declare.
1639 (tui_cmd_window::do_make_visible_with_new_height): Remove.
1641 2019-08-15 Tom Tromey <tromey@adacore.com>
1643 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1644 * ada-lang.c (ada_enum_name): Likewise.
1646 2019-08-15 Christian Biesinger <cbiesinger@google.com>
1648 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1650 (GdbOutputErrorFile): Likewise.
1651 (global scope): Adjust constructor calls to GdbOutput{,Error}File
1653 (execute_unwinders): Rename to have a leading underscore.
1654 (auto_load_packages): Likewise.
1655 (global scope): Adjust call to auto_load_packages accordingly.
1656 (GdbSetPythonDirectory): Likewise.
1657 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1658 instead of execute_unwinders.
1660 2019-08-15 Tom Tromey <tom@tromey.com>
1662 * tui/tui-layout.c (show_layout, show_source_disasm_command)
1663 (show_data): Don't change window visibility.
1664 (tui_gen_win_info::resize): Remove special case for command
1665 window. Use wresize, when available.
1666 (show_source_or_disasm_and_command): Don't change window
1668 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1669 <make_visible>: New method.
1670 * tui/tui-command.c (tui_cmd_window::resize): New method.
1672 2019-08-15 Tom Tromey <tom@tromey.com>
1674 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1675 (struct tui_source_windows): New.
1676 * tui/tui-winsource.c (tui_display_main): Update.
1677 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1678 (new_height_ok, parse_scrolling_args): Update.
1679 * tui/tui-layout.c (show_layout, show_data): Update.
1680 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1681 (tui_add_to_source_windows): Don't declare.
1682 * tui/tui-data.c (source_windows, tui_source_windows)
1683 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1685 2019-08-15 Tom Tromey <tom@tromey.com>
1687 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1689 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1690 * tui/tui-layout.c (show_source_disasm_command, show_data):
1692 (tui_gen_win_info::resize): Rename.
1693 (show_source_or_disasm_and_command): Update.
1694 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1697 2019-08-15 Tom Tromey <tom@tromey.com>
1699 * tui/tui-stack.c (tui_initialize_static_data): Remove.
1700 * tui/tui-interp.c (tui_interp::init): Don't call
1701 tui_initialize_static_data.
1702 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1704 2019-08-15 Tom Tromey <tom@tromey.com>
1706 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1707 examine tui_win_list.
1709 2019-08-15 Tom Tromey <tom@tromey.com>
1711 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1712 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1713 tui_clear_source_content.
1714 (tui_clear_source_content): Remove.
1715 (tui_source_window_base::do_erase_source_content): Hoist call to
1717 * tui/tui-stack.c (tui_show_frame_info): Don't call
1718 tui_clear_source_content.
1720 2019-08-15 Tom Tromey <tom@tromey.com>
1722 * tui/tui-winsource.h (struct tui_source_window_base)
1723 <do_erase_source_content>: New method.
1724 <erase_source_content>: New method.
1725 (tui_erase_source_content): Don't declare.
1726 * tui/tui-winsource.c (tui_clear_source_content): Update.
1727 (tui_source_window_base::do_erase_source_content): Rename from
1728 tui_erase_source_content.
1729 (tui_source_window_base::show_source_content): Update.
1730 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1731 * tui/tui-source.h (struct tui_source_window)
1732 <erase_source_content>: New method.
1733 * tui/tui-disasm.h (struct tui_disasm_window)
1734 <erase_source_content>: New method.
1736 2019-08-15 Tom Tromey <tom@tromey.com>
1738 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1739 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1741 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1742 * tui/tui-source.c (tui_set_source_content): Update.
1743 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1745 2019-08-15 Tom Tromey <tom@tromey.com>
1747 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1748 * tui/tui-winsource.c (tui_line_is_displayed): Move to
1750 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1752 * tui/tui-source.c (tui_source_window::line_is_displayed): New
1754 (tui_source_window::maybe_update): Update.
1756 2019-08-15 Tom Tromey <tom@tromey.com>
1758 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1759 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1761 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1763 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1765 (tui_disasm_window::maybe_update): Update.
1767 2019-08-15 Tom Tromey <tom@tromey.com>
1769 * tui/tui-winsource.h (struct tui_source_window_base)
1770 <maybe_update>: Declare.
1771 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1773 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1775 * tui/tui-source.c (tui_source_window::maybe_update): New method.
1776 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1778 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1780 2019-08-15 Tom Tromey <tom@tromey.com>
1782 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1784 2019-08-15 Tom Tromey <tom@tromey.com>
1786 * tui/tui-wingeneral.c: Include tui-stack.h.
1787 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1788 (struct tui_locator_window): Move from tui-data.h.
1789 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1790 (tui_initialize_static_data): Move from tui-data.c.
1791 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1792 (struct tui_locator_window): Move to tui-stack.c.
1793 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1794 (tui_initialize_static_data): Move to tui-stack.c.
1796 2019-08-15 Tom Tromey <tom@tromey.com>
1798 * tui/tui-layout.c (show_source_disasm_command)
1799 (show_source_or_disasm_and_command): Use make_visible method, not
1801 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1804 2019-08-15 Tom Tromey <tom@tromey.com>
1806 * tui/tui-wingeneral.h (tui_make_window): Update.
1807 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1809 (tui_gen_win_info::make_visible): Update.
1810 * tui/tui-regs.c (tui_data_window::display_registers_from):
1812 * tui/tui-layout.c (show_source_disasm_command)
1813 (show_source_or_disasm_and_command): Update.
1814 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1815 (enum tui_box): Remove.
1816 (struct tui_win_info) <can_box>: New method.
1817 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1820 2019-08-15 Tom de Vries <tdevries@suse.de>
1822 * linux-nat-trad.c: Include gdbarch.h.
1824 2019-08-14 Alan Hayward <alan.hayward@arm.com>
1826 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1829 2019-08-14 Tom Tromey <tromey@adacore.com>
1831 * darwin-nat.c: Include gdbarch.h.
1832 * darwin-nat-info.c: Include gdbarch.h.
1834 2019-08-13 Tom Tromey <tom@tromey.com>
1836 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1838 * tui/tui-data.c (tui_initialize_static_data): Update.
1840 2019-08-13 Tom Tromey <tom@tromey.com>
1842 * tui/tui-winsource.h (struct tui_exec_info_window)
1843 <~tui_exec_info_window, maybe_allocate_content, get_content,
1845 (struct tui_source_window_base) <set_exec_info_content,
1846 show_exec_info_content>: Don't declare.
1847 * tui/tui-winsource.c
1848 (tui_exec_info_window::maybe_allocate_content): Remove.
1849 (tui_source_window_base::update_exec_info): Rename from
1850 set_exec_info_content.
1851 (tui_source_window_base::show_exec_info_content)
1852 (tui_source_window_base::update_exec_info): Remove.
1854 2019-08-13 Tom Tromey <tom@tromey.com>
1856 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1858 * tui/tui-winsource.c (tui_update_source_window_as_is)
1859 (tui_update_source_windows_with_addr, tui_erase_source_content):
1861 (tui_clear_exec_info_content): Remove.
1863 2019-08-13 Tom Tromey <tom@tromey.com>
1865 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1867 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1868 call tui_erase_exec_info_content.
1869 (tui_clear_exec_info_content): Rename from
1870 tui_erase_exec_info_content.
1871 (tui_clear_exec_info_content): Delete.
1873 2019-08-13 Tom Tromey <tom@tromey.com>
1875 * tui/tui-winsource.h (struct tui_source_window_base)
1876 <show_exec_info_content>: Declare.
1877 (tui_show_exec_info_content): Don't declare.
1878 * tui/tui-winsource.c
1879 (tui_source_window_base::show_exec_info_content): Rename from
1880 tui_show_exec_info_content.
1881 (tui_source_window_base::update_exec_info): Update.
1883 2019-08-13 Tom Tromey <tom@tromey.com>
1885 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1886 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1887 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1888 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1889 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1890 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1893 2019-08-13 Tom Tromey <tom@tromey.com>
1895 * tui/tui-winsource.h (struct tui_source_window_base)
1896 <update_exec_info>: Declare.
1897 (tui_update_exec_info): Don't declare.
1898 * tui/tui-winsource.c (tui_update_source_window_as_is)
1899 (tui_source_window_base::refresh_all)
1900 (tui_update_all_breakpoint_info): Update.
1901 (tui_source_window_base::update_exec_info): Rename from
1902 tui_update_exec_info.
1903 * tui/tui-stack.c (tui_show_frame_info): Update.
1905 2019-08-13 Tom Tromey <tom@tromey.com>
1907 * tui/tui-winsource.h (struct tui_source_window_base)
1908 <set_exec_info_content>: Declare.
1909 (tui_set_exec_info_content): Don't declare.
1910 * tui/tui-winsource.c
1911 (tui_source_window_base::set_exec_info_content): Rename from
1912 tui_set_exec_info_content.
1913 (tui_update_exec_info): Update.
1915 2019-08-13 Tom Tromey <tom@tromey.com>
1917 * tui/tui-winsource.h (struct tui_source_window_base)
1918 <show_source_content>: Declare.
1919 (tui_show_source_content): Don't declare.
1920 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1921 (tui_source_window_base::show_source_content): Rename from
1922 tui_show_source_content.
1923 (tui_source_window_base::refresh_all): Update.
1924 * tui/tui-layout.c (show_source_disasm_command)
1925 (show_source_or_disasm_and_command): Update.
1927 2019-08-13 Tom Tromey <tom@tromey.com>
1929 * tui/tui-winsource.c (tui_erase_source_content)
1930 (tui_show_source_content, tui_source_window_base::refresh_all):
1932 * tui/tui-wingeneral.h
1933 (tui_check_and_display_highlight_if_needed): Don't declare.
1934 * tui/tui-wingeneral.c
1935 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1936 check_and_display_highlight_if_needed.
1937 * tui/tui-win.c (tui_rehighlight_all)
1938 (tui_win_info::make_visible_with_new_height): Update.
1939 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1940 (tui_data_window::erase_data_content)
1941 (tui_data_window::display_all_data): Update.
1942 * tui/tui-data.h (struct tui_win_info)
1943 <check_and_display_highlight_if_needed>: Declare.
1945 2019-08-13 Tom Tromey <tom@tromey.com>
1947 * tui/tui-win.c (tui_resize_all): Call
1948 tui_delete_invisible_windows.
1949 * tui/tui-layout.c (show_layout): Call
1950 tui_delete_invisible_windows.
1951 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1952 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1954 2019-08-13 Tom Tromey <tom@tromey.com>
1956 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1957 tui_add_win_to_layout.
1959 2019-08-13 Tom Tromey <tom@tromey.com>
1961 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1962 * tui/tui-layout.c (tui_default_win_height): Now static.
1964 2019-08-13 Tom Tromey <tom@tromey.com>
1966 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1968 (show_source_disasm_command, show_source_or_disasm_and_command):
1969 Don't check current layout.
1971 2019-08-13 Tom Tromey <tom@tromey.com>
1973 * tui/tui-wingeneral.c (make_all_visible): Remove.
1974 (tui_make_all_invisible): Simplify.
1975 * tui/tui-layout.c (tui_make_all_invisible): Move from
1976 tui-wingeneral.c; simplify.
1977 (show_layout): Hoist call to tui_make_all_invisible.
1978 (show_data): Don't call tui_make_all_invisible.
1980 2019-08-13 Tom Tromey <tom@tromey.com>
1982 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1983 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1985 2019-08-13 Tom Tromey <tom@tromey.com>
1987 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1989 (show_source_disasm_command, show_data)
1990 (show_source_or_disasm_and_command): Don't use
1991 tui_set_current_layout_to.
1992 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1993 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1995 (tui_set_current_layout_to): Remove.
1997 2019-08-13 Tom Tromey <tom@tromey.com>
1999 * tui/tui-layout.c (tui_set_layout): Update.
2000 * tui/tui-data.h (struct tui_layout_def): Remove.
2001 (tui_layout_def): Don't declare.
2002 * tui/tui-data.c (layout_def): Remove.
2003 (tui_layout_def): Remove.
2005 2019-08-13 Tom Tromey <tom@tromey.com>
2007 * tui/tui-winsource.h (struct tui_source_window_base)
2008 <clear_detail>: No longer "override".
2009 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2010 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2011 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2012 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2014 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2016 2019-08-13 Tom Tromey <tromey@adacore.com>
2018 * tracepoint.c: Don't include readline.h or history.h.
2020 2019-08-12 Tom Tromey <tom@tromey.com>
2022 * configure: Rebuild.
2023 * configure.ac: Check for readline 7.
2024 * NEWS: Mention readline 7 requirement.
2027 2019-08-12 Tom Tromey <tom@tromey.com>
2029 * mingw-hdep.c (gdb_select): Remove readline hack.
2031 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2033 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2034 when the function fails.
2036 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2038 * s390-tdep.c (s390_type_align): New function.
2039 (s390_gdbarch_init): Set it as type_align gdbarch method.
2041 2019-08-09 Tom de Vries <tdevries@suse.de>
2044 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2045 pc_low with relocation offset.
2047 2019-08-07 Tom Tromey <tromey@adacore.com>
2049 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2050 (print_frame_args): Update.
2051 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2053 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2054 * frame.h (struct frame_arg): Add initializers.
2055 <error>: Now a unique_xmalloc_ptr.
2057 2019-08-07 Alan Hayward <alan.hayward@arm.com>
2059 * NEWS: Expand the Pointer Authentication entry.
2060 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2061 (aarch64_frame_unmask_lr): ... to this.
2062 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2063 Call aarch64_frame_unmask_lr.
2064 * frame.c (struct frame_info): Add "masked" variable.
2065 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2066 (fprint_frame): Check for masked pc.
2067 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2069 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2070 * stack.c (print_frame): Check for masked pc.
2072 2019-08-06 Tom Tromey <tom@tromey.com>
2074 * stabsread.c (patch_block_stabs, read_one_struct_field)
2075 (read_enum_type): Use obstack_strndup.
2076 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2077 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2078 * dwarf2read.c (guess_full_die_structure_name)
2079 (anonymous_struct_prefix): Use obstack_strndup.
2080 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2081 * c-exp.y (yylex): Use obstack_strndup.
2082 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2083 (write_var_or_type): Use obstack_strndup.
2085 2019-08-06 Tom Tromey <tom@tromey.com>
2087 * symfile.c (reread_symbols): Use obstack_strdup.
2088 * stabsread.c (read_type): Use obstack_strdup.
2089 * gdb_obstack.h (obstack_strdup): New overload.
2090 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2091 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2092 (dwarf2_canonicalize_name): Use obstack_strdup.
2093 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2094 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2097 2019-08-06 Tom Tromey <tom@tromey.com>
2099 * gdb_obstack.h (obstack_strdup): Define.
2100 * gdb_obstack.c (obstack_strdup): Don't define.
2102 2019-08-06 Tom Tromey <tom@tromey.com>
2104 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2106 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2108 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2109 * stabsread.c (common_block_start): Use obstack_strdup.
2110 * objfiles.c (set_objfile_main_name, objfile): Use
2112 * namespace.c (add_using_directive): Use obstack_strdup.
2113 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2114 * jit.c (finalize_symtab): Use obstack_strdup.
2115 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2116 (guess_partial_die_structure_name, partial_die_info::fixup)
2117 (dwarf2_name): Use obstack_strdup.
2118 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2120 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2121 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2123 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2125 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2127 * unittests/help-doc-selftests.c: New file.
2128 * Makefile.in: Add the new file.
2130 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2132 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2133 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2134 the full first line, except when FOR_VALUE_PREFIX. In this case,
2135 the trailing '.' is not output, and the first character is uppercased.
2136 (print_help_for_command): Update call to print_doc_line.
2137 (print_doc_of_command): Likewise.
2138 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2139 * cli/cli-option.c (append_indented_doc): Do not append newline.
2140 (build_help_option): Append newline after first appended_indented_doc
2141 only if a second call is done.
2142 (build_help): Append 2 new lines before each option, except the first
2144 * compile/compile.c (_initialize_compile): Add new lines after
2145 %OPTIONS%, when not at the end of the help.
2146 Change help doc or code
2147 producing the help doc to respect the invariants.
2148 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2149 Also removed the new line after 'Options:', as all other commands
2150 do not put an empty line between 'Options:' and the first option.
2151 * printcmd.c (_initialize_printcmd): Likewise.
2152 * stack.c (_initialize_stack): Likewise.
2153 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2154 incorrectly telling COMMAND is optional.
2155 * ada-lang.c (_initialize_ada_language): Change help doc or code
2156 producing the help doc to respect the invariants.
2157 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2158 * breakpoint.c (_initialize_breakpoint): Likewise.
2159 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2160 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2161 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2162 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2163 _initialize_cli_style): Likewise.
2164 * corelow.c (core_target_info): Likewise.
2165 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2166 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2167 * filesystem.c (_initialize_filesystem): Likewise.
2168 * frame.c (_initialize_frame): Likewise.
2169 * gnu-nat.c (add_task_commands): Likewise.
2170 * infcall.c (_initialize_infcall): Likewise.
2171 * infcmd.c (_initialize_infcmd): Likewise.
2172 * interps.c (_initialize_interpreter): Likewise.
2173 * language.c (_initialize_language): Likewise.
2174 * linux-fork.c (_initialize_linux_fork): Likewise.
2175 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2176 * maint.c (_initialize_maint_cmds): Likewise.
2177 * memattr.c (_initialize_mem): Likewise.
2178 * printcmd.c (_initialize_printcmd): Likewise.
2179 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2181 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2182 * record-btrace.c (_initialize_record_btrace): Likewise.
2183 * record-full.c (_initialize_record_full): Likewise.
2184 * record.c (_initialize_record): Likewise.
2185 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2186 * regcache.c (_initialize_regcache): Likewise.
2187 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2188 _initialize_remote): Likewise.
2189 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2190 * serial.c (_initialize_serial): Likewise.
2191 * skip.c (_initialize_step_skip): Likewise.
2192 * source.c (_initialize_source): Likewise.
2193 * stack.c (_initialize_stack): Likewise.
2194 * symfile.c (_initialize_symfile): Likewise.
2195 * symtab.c (_initialize_symtab): Likewise.
2196 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2197 * top.c (init_main): Likewise.
2198 * tracefile-tfile.c (tfile_target_info): Likewise.
2199 * tracepoint.c (_initialize_tracepoint): Likewise.
2200 * tui/tui-win.c (_initialize_tui_win): Likewise.
2201 * utils.c (add_internal_problem_command): Likewise.
2202 * valprint.c (value_print_option_defs): Likewise.
2204 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
2207 * configure.ac: Drop enable-libmcheck support.
2208 * configure, config.in: Rebuild.
2209 * libmcheck.m4: Remove.
2210 * acinclude.m4: Don't include it.
2211 * Makefile.in: Don't distribute it.
2212 * top.c (print_gdb_configuration): Don't mention it.
2214 2019-08-06 Tom Tromey <tom@tromey.com>
2216 * utils.c (set_output_style): Sometimes pass stream to
2218 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2219 * record-btrace.c (btrace_insn_history): Update.
2220 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2222 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2223 Update initializers.
2224 <m_uiout>: New field.
2226 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2227 Remove "uiout" parameter.
2228 (dump_insns): Update.
2229 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2230 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2232 2019-08-06 Christian Biesinger <cbiesinger@google.com>
2234 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2235 (error_in_psymtab_expansion): Likewise.
2236 (lookup_symbol_via_quick_fns): Likewise.
2237 (basic_lookup_transparent_type_quick): Likewise.
2238 (basic_lookup_transparent_type_1): Likewise.
2240 2019-08-06 Tom Tromey <tromey@adacore.com>
2242 * source.c (last_source_error): Now bool.
2243 (print_source_lines_base): Make "noprint" bool. Only open
2244 source file when last_source_visited changes.
2246 2019-08-06 Tom Tromey <tromey@adacore.com>
2248 * annotate.c (annotate_source_line): Use g_source_cache.
2249 * source-cache.c (source_cache::get_plain_source_lines): Change
2250 parameters. Populate m_offset_cache.
2251 (source_cache::ensure): New method.
2252 (source_cache::get_line_charpos): New method.
2253 (extract_lines): Move lower. Change parameters.
2254 (source_cache::get_source_lines): Move lower.
2255 * source-cache.h (class source_cache): Update comment.
2256 <get_line_charpos>: New method.
2257 <get_source_lines>: Update comment.
2258 <clear>: Clear m_offset_cache.
2259 <get_plain_source_lines>: Change parameters.
2260 <ensure>: New method
2261 <m_offset_cache>: New member.
2262 * source.c (forget_cached_source_info_for_objfile): Update.
2263 (info_source_command): Use g_source_cache.
2264 (find_source_lines, open_source_file_with_line_charpos): Remove.
2265 (print_source_lines_base, search_command_helper): Use g_source_cache.
2266 * source.h (open_source_file_with_line_charpos): Don't declare.
2267 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2268 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2271 2019-08-06 Tom Tromey <tromey@adacore.com>
2273 * source-cache.c (source_cache::get_plain_source_lines):
2274 Remove "first_line" and "last_line" parameters.
2275 (source_cache::get_source_lines): Cache plain text.
2276 * source-cache.h (class source_cache)
2277 <get_plain_source_lines>: Update.
2279 2019-08-06 Tom Tromey <tromey@adacore.com>
2281 * source-cache.c (extract_lines): No longer a method.
2282 Changed type of parameter. Include final newline.
2283 (selftests::extract_lines_test): New function.
2284 (_initialize_source_cache): Likewise.
2285 * source-cache.h (class source_cache)
2286 <extract_lines>: Don't declare.
2288 2019-08-06 Tom Tromey <tromey@adacore.com>
2290 * breakpoint.c (init_breakpoint_sal): Update.
2291 (breakpoint): Update.
2292 * breakpoint.h (struct breakpoint) <filter>: Now a
2295 2019-08-05 Christian Biesinger <cbiesinger@google.com>
2297 * NEWS: Mention dictionary access on blocks.
2298 * python/py-block.c (blpy_getitem): New function.
2299 (block_object_as_mapping): New struct.
2300 (block_object_type): Use new struct for tp_as_mapping field.
2302 2019-08-05 Christian Biesinger <cbiesinger@google.com>
2304 * objfiles.h (objfile): Add a comment describing partial symbols.
2306 2019-08-05 Tom Tromey <tromey@adacore.com>
2308 * compile/compile.c (_initialize_compile): Use _(), not N_().
2309 * thread.c (_initialize_thread): Use _(), not N_().
2310 * stack.c (_initialize_stack): Use _(), not N_().
2311 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2313 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2315 * dwarf2read.c (struct dw2_symtab_iterator):
2316 <want_specific_block>: Remove.
2317 <block_index>: Change type to gdb::optional.
2318 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2319 change type of BLOCK_INDEX parameter to gdb::optional.
2320 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2321 (dw2_lookup_symbol): Don't pass argument for
2322 WANT_SPECIFIC_BLOCK.
2323 (dw2_expand_symtabs_for_function): Don't pass argument for
2324 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2325 (class dw2_debug_names_iterator)
2326 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2327 parameter, change BLOCK_INDEX type to gdb::optional.
2328 <m_want_specific_block>: Remove.
2329 <m_block_index>: Change type to gdb::optional.
2330 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2331 gdb::optional. Re-write in function of gdb::optional.
2332 (dw2_debug_names_lookup_symbol): Don't pass argument for
2333 WANT_SPECIFIC_BLOCK.
2334 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2335 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2338 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2340 * NEWS: Mention changes to "info sources" command.
2342 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2344 * symtab.c (filename_partial_match_opts): New struct type.
2345 (struct output_source_filename_data): New members
2346 regexp, c_regexp, partial_match.
2347 (output_source_filename): Use new members to decide to print file.
2348 (info_sources_option_defs): New variable.
2349 (make_info_sources_options_def_group, print_info_sources_header,
2350 info_sources_command_completer):
2352 (info_sources_command): Read new optional arguments.
2353 (_initialize_symtab): Update info sources help.
2355 2019-08-02 Alexandre Oliva <oliva@adacore.com>
2357 * ada-lang.c (exception_support_info_v0): Renamed from...
2358 (default_exception_support_info): ... this. Create new
2360 (ada_has_this_exception_support): Look up catch_handlers_sym.
2361 (ada_exception_support_info_sniffer): Try v0 after default.
2363 2019-08-01 Tom Tromey <tromey@adacore.com>
2365 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2368 2019-08-01 Christian Biesinger <cbiesinger@google.com>
2370 * s12z-tdep.c: Fix include path for s12z-opc.h.
2372 2019-08-01 Alan Hayward <alan.hayward@arm.com>
2374 * NEWS: Require GNU make 3.82.
2376 2019-07-16 Tom Tromey <tom@tromey.com>
2378 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2381 2019-07-30 Tom Tromey <tromey@adacore.com>
2383 * block.c (contained_in): Remove BLOCK_FUNCTION check.
2385 2019-07-30 Kevin Buettner <kevinb@redhat.com>
2387 * printcmd.c (print_address_symbolic): Print negative offsets.
2388 (build_address_symbolic): Force signed arithmetic when computing
2391 2019-07-30 Christian Biesinger <cbiesinger@google.com>
2393 PR/24474: Add a function to lookup static variables.
2394 * NEWS: Mention this new function.
2395 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2396 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2397 * python/python.c (python_GdbMethods): Add new function.
2399 2019-07-29 Christian Biesinger <cbiesinger@google.com>
2401 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2402 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2403 (objfpy_lookup_static_symbol): New function.
2404 (objfile_object_methods): Add new functions.
2406 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2408 * NEWS: Mention 'set|show print frame-info'. Mention new
2409 'presence' value for 'frame-arguments'. Mention new '-frame-info'
2410 backtrace argument. Mention that python frame filtering code
2411 is now consistent with what 'backtrace' command prints.
2413 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2415 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2417 (print_frame_info_auto, print_frame_info_source_line,
2418 print_frame_info_location, print_frame_info_source_and_location,
2419 print_frame_info_location_and_address, print_frame_info_short_location):
2421 (struct frame_print_options): New member print_frame_info.
2422 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2423 * stack.h (get_user_print_what_frame_info): New declaration.
2424 (frame_show_address): New declaration.
2425 * stack.c (print_frame_arguments_choices): New value 'presence'.
2426 (print_frame_info_auto, print_frame_info_source_line,
2427 print_frame_info_location, print_frame_info_source_and_location,
2428 print_frame_info_location_and_address, print_frame_info_short_location,
2429 print_frame_info_choices, print_frame_info_print_what): New definitions.
2430 (print_frame_args): Only print dots for args if print frame-arguments
2432 (frame_print_option_defs): New element for "frame-info".
2433 (get_user_print_what_frame_info): New function.
2434 (frame_show_address): Make non static. Move comment to stack.h.
2435 (print_frame_info_to_print_what): New function.
2436 (print_frame_info): Update comment. Use fp_opts.print_frame_info
2437 to decide what to print.
2438 (backtrace_command_1): Handle the new print_frame_arguments_presence
2440 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2441 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2442 (py_print_frame): In non-mi mode, use LOCATION as default for
2443 print_what, similarly to frame information printed directly by
2444 backtrace command. Handle frame-info user option in non MI mode.
2446 2019-07-27 Kevin Buettner <kevinb@redhat.com>
2448 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2449 Add case for debugging 32-bit target on 64-bit host. Revise
2452 2019-07-27 Kevin Buettner <kevinb@redhat.com>
2454 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2455 instead of find_function_entry_range_from_pc.
2457 2019-07-27 Kevin Buettner <kevinb@redhat.com>
2459 * stack.c (find_frame_funname): Remove code which preferred
2460 minsym over symtab sym in "certain pathological cases".
2462 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2463 parameter. Change type of "do_demangle" to bool.
2464 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2465 Pass suitable "prefer_sym_over_minsym" flag to
2466 build_address_symbolic(). Don't output "+" for negative offsets.
2467 * printcmd.c (print_address_symbolic): Update invocation of
2468 build_address_symbolic to include a "prefer_sym_over_minsym"
2470 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2471 Restrict cases in which use of minimal symbol is preferred to that
2472 of a found symbol. Update comments.
2474 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2475 for entry pc when entry pc is out of range for that FDE.
2477 2019-07-26 Brian Callahan <bcallah@openbsd.org>
2480 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2483 2019-07-25 Christian Biesinger <cbiesinger@google.com>
2485 * python/py-objfile.c (add_separate_debug_file): Fix comment about
2486 this function's Python signature.
2489 2019-07-24 Christian Biesinger <cbiesinger@google.com>
2491 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2492 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2493 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2494 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2495 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2498 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
2500 * h8300-tdep.c (h8300_register_name_common): New.
2501 h8300_register_name): Use h8300_register_name_common.
2502 (h8300s_register_name): Likewise.
2503 (h8300sx_register_name): Likewise.
2504 (h8300h_register_nam): New.
2505 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2508 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
2510 * arm-tdep.c (arm_skip_cmse_entry): New function.
2511 (arm_is_sgstubs_section): New function.
2512 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2514 2019-07-22 Tom Tromey <tom@tromey.com>
2516 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2519 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2521 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2524 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2526 * symtab.c (search_symbols): Adjust msymbol matching type arrays
2527 so that GDB doesn't match any msymbols when searching in the
2529 (print_symbol_info): Print using typedef_print or type_print based
2530 on the type of the symbol. Add updated FIXME comment moved from...
2531 (_initialize_symtab): ... move and update FIXME comment to above.
2533 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2535 * NEWS: Mention adding -q option to "info types".
2536 * symtab.c (struct info_types_options): New struct.
2537 (info_types_options_defs): New variable.
2538 (make_info_types_options_def_group): New function.
2539 (info_types_command): Use gdb::option framework to parse options.
2540 (info_types_command_completer): New function.
2541 (_initialize_symtab): Extend the help text on "info types" and
2542 register command completer.
2544 2019-07-21 Christian Biesinger <cbiesinger@google.com>
2546 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2547 (lookup_symbol_in_objfile): Change int to block_enum and add a
2548 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2550 2019-07-20 Christian Biesinger <cbiesinger@google.com>
2552 * MAINTAINERS (Write After Approval): Add self.
2554 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
2556 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2557 instruction to the dummy code region.
2559 2019-07-19 Tom Tromey <tromey@adacore.com>
2561 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2562 (ARGSUSED, PARAMS, __func__): Remove rules.
2564 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2566 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2567 * features/arm/arm-with-iwmmxt.c: Remove.
2568 * features/arm/arm-with-iwmmxt.xml: Remove.
2569 * features/arm/arm-with-m-fpa-layout.c: Remove.
2570 * features/arm/arm-with-m-fpa-layout.xml: Remove.
2571 * features/arm/arm-with-m-vfp-d16.c: Remove.
2572 * features/arm/arm-with-m-vfp-d16.xml: Remove.
2573 * features/arm/arm-with-m.c: Remove.
2574 * features/arm/arm-with-m.xml: Remove.
2575 * features/arm/arm-with-neon.c: Remove.
2576 * features/arm/arm-with-neon.xml: Remove.
2577 * features/arm/arm-with-vfpv2.c: Remove.
2578 * features/arm/arm-with-vfpv2.xml: Remove.
2579 * features/arm/arm-with-vfpv3.c: Remove.
2580 * features/arm/arm-with-vfpv3.xml: Remove.
2582 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2584 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2586 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2588 * arch/aarch32.c (aarch32_create_target_description): Create
2589 target descriptions using features.
2590 * arch/arm.c (arm_create_target_description)
2591 (arm_create_mprofile_target_description): Likewise.
2592 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2594 2019-07-19 Alan Hayward <alan.hayward@arm.com>
2596 * Makefile.in: Add new files.
2597 * aarch32-tdep.c: New file.
2598 * aarch32-tdep.h: New file.
2599 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2600 Call aarch32_read_description.
2601 * arch/aarch32.c: New file.
2602 * arch/aarch32.h: New file.
2603 * arch/arm.c (arm_create_target_description)
2604 (arm_create_mprofile_target_description): New function.
2605 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2606 (arm_create_target_description)
2607 (arm_create_mprofile_target_description): New declaration.
2608 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2609 read_description functions.
2610 * arm-linux-nat.c (arm_linux_nat_target::read_description):
2612 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2613 * arm-tdep.c (tdesc_arm_list): New variable.
2614 (arm_register_g_packet_guesses): Call create description functions.
2615 (arm_read_description) (arm_read_mprofile_description): New
2617 * arm-tdep.h (arm_read_description)
2618 (arm_read_mprofile_description): Add declaration.
2619 * configure.tgt: Add new files.
2621 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
2623 * top.c (new_ui_command): Open specified terminal just once.
2625 2019-07-18 Tom Tromey <tromey@adacore.com>
2627 * symtab.c (main_name): Constify return type.
2628 * symfile.c (set_initial_language): Update.
2629 * symtab.h (main_name): Constify return type.
2631 2019-07-17 Tom Tromey <tom@tromey.com>
2633 * tui/tui-winsource.c (tui_update_source_window)
2634 (tui_update_source_window_as_is)
2635 (tui_update_source_windows_with_line): Remove return.
2636 * tui/tui-disasm.c (tui_show_disassem)
2637 (tui_show_disassem_and_update_source): Remove return.
2638 * tui/tui.c (tui_reset): Remove return.
2639 * tui/tui-wingeneral.c
2640 (tui_check_and_display_highlight_if_needed): Remove return.
2642 2019-07-17 Tom Tromey <tom@tromey.com>
2644 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2646 2019-07-17 Tom Tromey <tom@tromey.com>
2648 * tui/tui-winsource.h (struct tui_exec_info_window)
2649 (struct tui_source_window_base): Move from tui-data.h.
2650 * tui/tui-winsource.c: Move many method definitions from
2651 elsewhere. Remove "structuring" comments.
2652 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2653 (tui_source_window_base::refresh_window): Move to
2655 * tui/tui-win.c (tui_source_window_base::refresh_all)
2656 (tui_source_window_base::update_tab_width)
2657 (tui_source_window_base::set_new_height)
2658 (tui_source_window_base::do_make_visible_with_new_height): Move to
2660 * tui/tui-source.h: Update.
2661 * tui/tui-source.c (tui_source_window_base::reset): Move to
2663 * tui/tui-disasm.h: Update.
2664 * tui/tui-data.h (struct tui_exec_info_window): Move to
2666 (struct tui_source_window_base): Likewise.
2667 * tui/tui-data.c (tui_source_window_base::clear_detail)
2668 (tui_source_window_base, ~tui_source_window_base): Move to
2671 2019-07-17 Tom Tromey <tom@tromey.com>
2673 * tui/tui-win.c (tui_resize_all)
2674 (tui_source_window_base::update_tab_width)
2675 (tui_adjust_win_heights): Update.
2676 (tui_win_info::make_invisible_and_set_new_height): Rename from
2677 make_invisible_and_set_new_height.
2678 * tui/tui-data.h (struct tui_win_info)
2679 <make_invisible_and_set_new_height>: New method.
2681 2019-07-17 Tom Tromey <tom@tromey.com>
2683 * tui/tui.c: Update.
2684 * tui/tui-source.h (struct tui_source_window): Move from
2686 * tui/tui-layout.c: Update.
2687 * tui/tui-disasm.c: Update.
2688 * tui/tui-data.h (struct tui_source_window): Move to
2691 2019-07-17 Tom Tromey <tom@tromey.com>
2693 * tui/tui-disasm.h (struct tui_disasm_window): Move from
2695 * tui/tui-data.h (struct tui_disasm_window): Move to
2698 2019-07-17 Tom Tromey <tom@tromey.com>
2700 * tui/tui-regs.h (struct tui_data_item_window): Move from
2702 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2703 * tui/tui-data.h (struct tui_data_item_window): Move to
2705 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2707 2019-07-17 Tom Tromey <tom@tromey.com>
2709 * tui/tui.c: Update.
2710 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2711 (tui_cmd_window::max_height): Move to tui-command.c.
2712 * tui/tui-layout.c: Update.
2713 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2714 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2716 * tui/tui-command.h (struct tui_cmd_window): Move from
2718 * tui/tui-command.c: Remove "structuring" comments.
2719 (tui_cmd_window::clear_detail)
2720 (tui_cmd_window::do_make_visible_with_new_height)
2721 (tui_cmd_window::max_height): Move from elsewhere.
2723 2019-07-17 Tom Tromey <tom@tromey.com>
2725 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2727 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2728 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2730 2019-07-17 Tom Tromey <tom@tromey.com>
2732 * tui/tui.c: Update.
2733 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2735 * tui/tui-windata.h: Remove file.
2736 * tui/tui-windata.c: Remove file.
2737 * tui/tui-win.c (tui_data_window::set_new_height)
2738 (tui_data_window::do_make_visible_with_new_height): Move to
2740 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2741 * tui/tui-regs.c: Remove "structuring" comments.
2742 (tui_data_window::first_data_item_displayed)
2743 (tui_data_window::delete_data_content_windows)
2744 (tui_data_window::erase_data_content)
2745 (tui_data_window::display_all_data)
2746 (tui_data_window::refresh_all)
2747 (tui_data_window::do_scroll_vertical)
2748 (tui_data_window::clear_detail, tui_data_window::set_new_height)
2749 (tui_data_window::do_make_visible_with_new_height)
2750 (tui_data_window::refresh_window): Move from elsewhere.
2751 (_initialize_tui_regs): Move to end of file.
2752 * tui/tui-layout.c: Update.
2753 * tui/tui-hooks.c: Update.
2754 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2755 * tui/tui-data.c (tui_data_window::clear_detail): Move to
2757 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2759 2019-07-17 Tom Tromey <tom@tromey.com>
2761 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2764 2019-07-17 Tom Tromey <tom@tromey.com>
2766 * tui/tui-win.c (tui_source_window_base::set_new_height)
2767 (tui_source_window_base::do_make_visible_with_new_height): Use
2768 m_has_locator field directly.
2769 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2771 (struct tui_source_window_base) <has_locator>: Likewise.
2773 2019-07-17 Tom Tromey <tom@tromey.com>
2775 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2777 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2779 * tui/tui-win.c (tui_source_window_base::set_new_height)
2780 (tui_source_window_base::set_new_height)
2781 (make_invisible_and_set_new_height)
2782 (tui_source_window_base::do_make_visible_with_new_height)
2783 (tui_source_window_base::do_make_visible_with_new_height):
2785 * tui/tui-layout.c (show_source_disasm_command, show_data)
2786 (show_source_or_disasm_and_command): Update.
2787 * tui/tui-layout.c (show_layout): Update.
2789 2019-07-17 Tom Tromey <tom@tromey.com>
2791 * tui/tui-layout.c (make_data_window): Remove.
2792 (show_data): Unify creation and re-initialization cases.
2794 2019-07-17 Tom Tromey <tom@tromey.com>
2796 * tui/tui-layout.c (make_source_window, make_disasm_window):
2798 (show_data): Unify creation and re-initialization cases.
2800 2019-07-17 Tom Tromey <tom@tromey.com>
2802 * tui/tui-layout.c (make_command_window): Remove.
2803 (show_source_disasm_command, show_source_or_disasm_and_command):
2804 Unify creation and re-initialization cases.
2806 2019-07-17 Tom Tromey <tom@tromey.com>
2808 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2809 creation and re-initialization cases.
2811 2019-07-17 Tom Tromey <tom@tromey.com>
2813 * tui/tui-regs.c (tui_get_register): Return void.
2815 2019-07-17 Tom Tromey <tom@tromey.com>
2817 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2820 2019-07-17 Tom Tromey <tom@tromey.com>
2822 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2825 2019-07-17 Tom Tromey <tom@tromey.com>
2827 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2828 * tui/tui-regs.c (tui_reg_layout): New function.
2829 (tui_show_registers, tui_reg_command): Use it.
2830 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2831 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2833 (tui_layout_command): Remove.
2835 2019-07-17 Tom Tromey <tom@tromey.com>
2837 * tui/tui-layout.h (tui/tui-layout): Return void.
2838 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2840 2019-07-17 Tom Tromey <tom@tromey.com>
2842 * tui/tui-layout.c (show_source_disasm_command, show_data):
2844 (reset_locator): Remove.
2845 (show_source_or_disasm_and_command): Update.
2847 2019-07-17 Tom Tromey <tom@tromey.com>
2849 * tui/tui-source.c (tui_source_window_base::reset): Remove
2851 * tui/tui-layout.c (make_command_window, make_source_window)
2852 (make_disasm_window, make_data_window)
2853 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2854 (reset_locator, show_source_or_disasm_and_command): Update.
2855 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2857 (struct tui_source_window_base) <reset>: Likewise.
2859 2019-07-17 Tom Tromey <tom@tromey.com>
2861 * tui/tui-layout.c (show_source_disasm_command): Use
2863 (reset_locator): New function.
2864 (init_and_make_win): Remove.
2865 (show_source_or_disasm_and_command): Use reset_locator.
2867 2019-07-17 Tom Tromey <tom@tromey.com>
2869 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2871 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2873 * tui/tui-source.c (tui_source_window_base::reset): New method.
2874 * tui/tui-layout.c (make_command_window): Don't call
2876 (make_source_window, make_disasm_window): Don't call
2877 make_source_or_disasm_window.
2878 (make_data_window): Don't call init_and_make_win. Change calling
2880 (show_source_disasm_command, show_data): Simplify.
2881 (make_source_or_disasm_window): Remove.
2882 (show_source_or_disasm_and_command): Simplify.
2883 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2884 (struct tui_source_window_base) <reset>: Likewise.
2885 <execution_info>: Remove initializer.
2886 * tui/tui-data.c (tui_source_window_base): Initialize
2889 2019-07-17 Tom Tromey <tom@tromey.com>
2891 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2894 2019-07-17 Tom Tromey <tom@tromey.com>
2896 * tui/tui.c (tui_rl_other_window): Update.
2897 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2898 superclass method first. Always iterate over regs_content.
2899 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2901 * tui/tui-win.c (tui_set_focus_command): Update.
2903 2019-07-17 Tom Tromey <tom@tromey.com>
2905 * tui/tui-win.c (tui_set_focus_command): Rename from
2906 tui_set_focus. Call tui_enable.
2907 (tui_set_focus_command): Remove.
2909 2019-07-17 Tom Tromey <tom@tromey.com>
2911 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2913 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2915 (tui_data_window::refresh_window): Call refresh_window on data
2916 items. Always call superclass refresh_window.
2917 (tui_win_info::refresh): Remove.
2918 (tui_source_window_base::refresh_window): Update.
2919 (tui_refresh_all): Update.
2920 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2922 (show_source_or_disasm_and_command): Likewise.
2923 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2924 (struct tui_source_window_base) <refresh>: Likewise.
2926 2019-07-17 Tom Tromey <tom@tromey.com>
2928 * tui/tui-winsource.c (tui_clear_source_content)
2929 (tui_show_source_content): Update.
2930 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2931 whether content is empty.
2932 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2935 2019-07-17 Tom Tromey <tom@tromey.com>
2937 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2939 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2940 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2942 2019-07-17 Tom Tromey <tom@tromey.com>
2944 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2945 (struct tui_data_item_window): Update.
2947 2019-07-17 Tom Tromey <tom@tromey.com>
2949 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2950 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2953 2019-07-17 Tom Tromey <tom@tromey.com>
2955 * tui/tui-winsource.h (tui_erase_source_content)
2956 (tui_clear_source_content): Remove "display_prompt" parameter.
2957 * tui/tui-winsource.c (tui_update_source_window_as_is)
2958 (tui_update_source_windows_with_addr): Update.
2959 (tui_clear_source_content): Remove "display_prompt" parameter.
2960 (tui_erase_source_content): Likewise. Simplify.
2961 (tui_show_source_content): Update.
2962 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2963 * tui/tui-stack.c (tui_show_frame_info): Update.
2964 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2967 2019-07-17 Tom Tromey <tom@tromey.com>
2969 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2970 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2972 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2975 2019-07-17 Tom Tromey <tom@tromey.com>
2977 * tui/tui-winsource.c (tui_clear_source_content)
2978 (tui_show_source_content, tui_show_exec_info_content)
2979 (tui_clear_exec_info_content): Update.
2980 * tui/tui-stack.c (tui_show_locator_content): Update.
2981 (tui_show_frame_info): Update.
2982 * tui/tui-source.h (tui_source_window): Don't declare.
2983 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2984 from tui_source_is_displayed.
2985 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2987 (struct tui_source_window_base) <content_in_use>: New field. Now
2989 (struct tui_source_window) <showing_source_p>: New method.
2990 (TUI_SRC_WIN): Change cast.
2991 * tui/tui-data.c (tui_initialize_static_data): Update.
2993 2019-07-17 Tom Tromey <tom@tromey.com>
2995 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2997 * tui/tui-source.c (tui_source_window::location_matches_p): New
2999 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3001 * tui/tui-data.h (struct tui_source_window_base)
3002 <location_matches_p>: New method.
3003 (struct tui_source_window, struct tui_disasm_window)
3004 <location_matches_p>: Likewise.
3006 2019-07-17 Tom Tromey <tom@tromey.com>
3008 * tui/tui-win.c (tui_set_win_height_command): Rename from
3010 (tui_set_win_height_command): Remove.
3012 2019-07-17 Tom Tromey <tom@tromey.com>
3014 * tui/tui-source.c (tui_source_window): New constructor. Add
3016 (~tui_source_window): New destructor.
3017 (tui_source_window::style_changed): New method.
3018 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3019 (tui_attach_detach_observers): Update.
3020 * tui/tui-data.h (struct tui_source_window): Make constructor not
3021 inline. Add destructor.
3022 (struct tui_source_window) <style_changed>: New method.
3023 <m_observable>: New member.
3025 2019-07-17 Tom Tromey <tom@tromey.com>
3027 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3028 * tui/tui-win.c (tui_resize_all): Fix typo.
3030 2019-07-17 Tom Tromey <tom@tromey.com>
3032 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3033 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3034 (tui_refresh_all): Remove "list" parameter. Use foreach.
3035 * tui/tui-win.c (window_name_completer): Use foreach.
3036 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3037 (update_tab_width): Likewise.
3038 * tui/tui-layout.c (show_layout): Update.
3039 * tui/tui-data.h (class tui_window_iterator): New.
3040 (struct all_tui_windows): New.
3041 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3043 2019-07-17 Tom Tromey <tom@tromey.com>
3045 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3046 parameter. Don't reference globals.
3047 (tui_reg_command): Update.
3049 2019-07-17 Tom Tromey <tom@tromey.com>
3051 * tui/tui-regs.c (tui_show_registers): Simplify.
3053 2019-07-17 Tom Tromey <tom@tromey.com>
3055 * tui/tui-regs.c (tui_show_registers): Update.
3056 (tui_show_register_group): Add win_info parameter.
3058 2019-07-17 Tom Tromey <tom@tromey.com>
3060 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3061 Rename from tui_display_reg_element_at_line.
3062 (tui_data_window::display_registers_from_line): Update.
3063 * tui/tui-data.h (struct tui_data_window)
3064 <display_reg_element_at_line>: New method.
3066 2019-07-17 Tom Tromey <tom@tromey.com>
3068 * tui/tui-regs.h (tui_display_registers_from)
3069 (tui_display_registers_from_line): Don't declare.
3070 * tui/tui-windata.c (tui_data_window::display_all_data)
3071 (tui_data_window::refresh_all)
3072 (tui_data_window::do_scroll_vertical): Update.
3073 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3074 from tui_display_registers_from.
3075 (tui_display_reg_element_at_line): Update.
3076 (tui_data_window::display_registers_from_line): Rename from
3077 tui_display_registers_from_line.
3078 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3079 display_registers_from_line>: New methods.
3081 2019-07-17 Tom Tromey <tom@tromey.com>
3083 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3084 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3085 from tui_erase_data_content.
3086 (tui_data_window::display_all_data)
3087 (tui_data_window::refresh_all)
3088 (tui_data_window::do_scroll_vertical): Update.
3089 * tui/tui-regs.c (tui_show_registers): Update.
3090 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3093 2019-07-17 Tom Tromey <tom@tromey.com>
3095 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3098 (tui_data_window::delete_data_content_windows): Rename from
3099 tui_delete_data_content_windows.
3100 (tui_data_window::display_all_data)
3101 (tui_data_window::do_scroll_vertical): Update.
3102 * tui/tui-data.h (struct tui_data_window)
3103 <delete_data_content_windows>: New method.
3105 2019-07-17 Tom Tromey <tom@tromey.com>
3107 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3108 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3110 2019-07-17 Tom Tromey <tom@tromey.com>
3112 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3113 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3114 from tui_display_all_data.
3116 (tui_data_window::do_make_visible_with_new_height): Update.
3117 * tui/tui-regs.c (tui_show_registers): Update.
3118 * tui/tui-layout.c (tui_set_layout): Update.
3119 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3122 2019-07-17 Tom Tromey <tom@tromey.com>
3124 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3125 * tui/tui-windata.c (tui_display_data_from): Remove.
3126 (tui_data_window::refresh_all): Update.
3128 2019-07-17 Tom Tromey <tom@tromey.com>
3130 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3131 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3132 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3133 tui_display_registers_from_line.
3134 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3135 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3136 "force_display" parameter.
3138 2019-07-17 Tom Tromey <tom@tromey.com>
3140 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3142 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3143 Rename from tui_first_reg_element_no_inline.
3144 (tui_display_reg_element_at_line)
3145 (tui_display_registers_from_line): Update.
3146 * tui/tui-data.h (struct tui_data_window)
3147 <first_reg_element_no_inline>: New method.
3149 2019-07-17 Tom Tromey <tom@tromey.com>
3151 * tui/tui-windata.c (tui_display_data_from)
3152 (tui_data_window::do_scroll_vertical): Update.
3153 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3154 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3155 Rename from tui_line_from_reg_element_no.
3156 (tui_display_registers_from_line): Update.
3157 * tui/tui-data.h (struct tui_data_window)
3158 <line_from_reg_element_no>: New method.
3160 2019-07-17 Tom Tromey <tom@tromey.com>
3162 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3163 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3164 tui_last_regs_line_no.
3165 (tui_display_reg_element_at_line)
3166 (tui_display_registers_from_line): Update.
3167 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3170 2019-07-17 Tom Tromey <tom@tromey.com>
3173 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3174 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3175 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3176 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3177 (tui_update_breakpoint_info): Likewise.
3178 * tui/tui-hooks.c (tui_event_create_breakpoint)
3179 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3182 2019-07-17 Tom Tromey <tom@tromey.com>
3184 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3186 2019-07-17 Tom Tromey <tom@tromey.com>
3188 * tui/tui-winsource.c (tui_update_source_window_as_is)
3189 (tui_update_source_windows_with_addr): Update.
3190 * tui/tui-source.h (tui_set_source_content)
3191 (tui_show_symtab_source): Add "win_info" parameter.
3192 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3194 (tui_show_symtab_source): Likewise.
3196 2019-07-17 Tom Tromey <tom@tromey.com>
3198 * tui/tui-wingeneral.c
3199 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3201 2019-07-17 Tom Tromey <tom@tromey.com>
3203 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3204 (struct tui_cmd_window) <can_scroll>: New method.
3205 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3208 2019-07-17 Tom Tromey <tromey@adacore.com>
3210 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3211 do_field_signed>: Rename. Change type of "value".
3212 * ui-out.c (ui_out::field_signed): Rename from field_int.
3213 Change type of "value".
3214 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3216 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3217 do_field_int. Change type of "value".
3218 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3219 do_field_int. Change type of "value".
3220 * tracepoint.c (trace_status_mi, tfind_1)
3221 (print_one_static_tracepoint_marker): Update.
3222 * thread.c (print_thread_info_1, print_selected_thread_frame):
3224 * stack.c (print_frame, print_frame_info): Update.
3225 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3227 * source.c (print_source_lines_base): Update.
3228 * skip.c (info_skip_command): Update.
3229 * record-btrace.c (btrace_ui_out_decode_error)
3230 (btrace_call_history_src_line): Update.
3231 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3233 * progspace.c (print_program_space): Update.
3234 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3235 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3236 do_field_int. Change type of "value".
3237 * mi/mi-out.c (mi_ui_out::do_table_begin)
3238 (mi_ui_out::do_table_header): Update.
3239 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3241 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3242 (mi_cmd_data_list_changed_registers, output_register)
3243 (mi_cmd_data_read_memory, mi_load_progress)
3244 (mi_cmd_trace_frame_collected): Update.
3245 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3247 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3248 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3249 (mi_cmd_var_list_children, varobj_update_one): Update.
3250 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3251 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3252 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3253 * inferior.c (print_inferior): Update.
3254 * gdb_bfd.c (print_one_bfd): Update.
3255 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3257 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3258 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3259 do_field_int. Change type of "value".
3260 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3261 do_field_int. Change type of "value".
3262 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3263 (print_one_breakpoint_location, print_it_catch_fork)
3264 (print_one_catch_fork, print_it_catch_vfork)
3265 (print_one_catch_vfork, print_it_catch_solib)
3266 (print_it_catch_exec, print_it_ranged_breakpoint)
3267 (print_mention_watchpoint, print_mention_masked_watchpoint)
3268 (bkpt_print_it, update_static_tracepoint): Update.
3269 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3270 * break-catch-syscall.c (print_it_catch_syscall): Update.
3271 * ada-tasks.c (print_ada_task_info): Update.
3272 * ada-lang.c (print_it_exception, print_mention_exception):
3275 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3277 PR breakpoints/24541
3278 * gdbarch.c: Regenerate.
3279 * gdbarch.h: Regenerate.
3280 * gdbarch.sh: Adjust return type and parameter types for
3281 'stap_adjust_register'.
3282 (i386_stap_adjust_register): Adjust signature and return new
3284 * stap-probe.c (stap_parse_register_operand): Adjust use of
3285 'gdbarch_stap_adjust_register'.
3287 2019-07-17 Tom Tromey <tromey@adacore.com>
3289 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3291 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3293 (struct s390_process_info): Add initializers.
3294 (s390_add_process): Use new.
3295 (s390_linux_nat_target::low_forget_process): Use delete.
3296 (s390_linux_nat_target::low_new_fork)
3297 (s390_linux_nat_target::stopped_by_watchpoint)
3298 (s390_linux_nat_target::low_prepare_to_resume)
3299 (s390_linux_nat_target::insert_watchpoint)
3300 (s390_linux_nat_target::insert_hw_breakpoint)
3301 (s390_linux_nat_target::remove_watchpoint)
3302 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3304 2019-07-16 John Baldwin <jhb@FreeBSD.org>
3306 * aarch64-fbsd-nat.c: Include regcache.h.
3307 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3309 (aarch64_fbsd_nat_target::fetch_registers)
3310 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3312 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3314 2019-07-16 John Baldwin <jhb@FreeBSD.org>
3316 * fbsd-nat.c: Include gdbarch.h.
3318 2019-07-15 Tom Tromey <tromey@adacore.com>
3320 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3322 2019-07-15 Tom Tromey <tromey@adacore.com>
3324 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3325 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3326 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3327 * cli-out.c (cli_ui_out::do_field_int): New method.
3328 * ui-out.c (ui_out::field_unsigned): New method.
3329 * symfile.c (generic_load): Use field_unsigned.
3330 (print_transfer_performance): Likewise.
3331 * record-btrace.c (ui_out_field_uint): Remove.
3332 (btrace_call_history_insn_range, btrace_call_history): Use
3334 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3336 * ui-out.h (class ui_out) <field_unsigned>: New method.
3337 <do_field_unsigned>: Likewise.
3339 2019-07-15 Tom Tromey <tromey@adacore.com>
3341 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3342 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3343 * target.c (flash_erase_command): Use field_string.
3344 * infrun.c (print_signal_received_reason): Use field_string.
3345 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3346 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3348 * ada-tasks.c (print_ada_task_info): Use field_string.
3350 2019-07-15 Tom Tromey <tromey@adacore.com>
3352 * target.c (flash_erase_command): Use field_core_addr.
3353 * symfile.c (generic_load): Use field_core_addr.
3354 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3355 Use field_core_addr.
3356 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3359 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3361 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3362 value if its desired type is smaller than a CORE_ADDR and signed.
3364 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3366 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3367 of changes to field names, and use new is_reference field to
3368 decide if a property is a reference or not.
3369 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3371 (struct dwarf2_property_baton): Update header comment, rename
3372 'referenced_type' to 'property_type' and update comments.
3373 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3374 default property type, store in property baton, update to take
3375 accound of renamed field.
3376 (read_func_scope): Update call to attr_to_dynamic_prop.
3377 (read_array_type): Likewise.
3378 (dwarf2_per_cu_addr_sized_int_type): New function.
3379 (read_subrange_index_type): Move type finding code to
3380 dwarf2_per_cu_addr_sized_int_type.
3381 (read_subrange_type): Update calls to attr_to_dynamic_prop.
3382 (dwarf2_per_cu_addr_type): New function.
3383 (set_die_type): Update calls to attr_to_dynamic_prop.
3385 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3387 * dwarf2read.c (read_subrange_index_type): New function.
3388 (read_subrange_type): Move code into new function and call it.
3389 * gdbtypes.c (create_range_type): Add some asserts.
3391 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3393 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3394 update return statements.
3395 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3396 declaration, and update comment to match.
3397 * gdbtypes.c (resolve_dynamic_array): Update call to
3398 dwarf2_evaluate_property to match new return type.
3400 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3402 * valarith.c (value_subscripted_rvalue): Change lowerbound
3403 parameter type from int to LONGEST.
3404 * value.h (value_subscripted_rvalue): Likewise in declaration.
3406 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3408 * cli/cli-utils.c (info_print_command_completer): New function.
3409 * cli/cli-utils.h: Add 'completer.h' include, and forward
3410 declaration for 'struct cmd_list_element'.
3411 (info_print_command_completer): Declare.
3412 * stack.c (_initialize_stack): Add completer for 'info locals' and
3414 * symtab.c (_initialize_symtab): Add completer for 'info
3415 variables' and 'info functions'.
3416 * NEWS: Mention completion for additional info commands.
3418 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3420 * cli/cli-utils.c (extract_info_print_args): Delete.
3421 (extract_arg_maybe_quoted): Delete.
3422 (info_print_options_defs): New variable.
3423 (make_info_print_options_def_group): New function.
3424 (extract_info_print_options): Define new function.
3425 * cli/cli-utils.h (extract_info_print_args): Delete.
3426 (struct info_print_options): New structure.
3427 (extract_info_print_options): Declare new function.
3428 * stack.c (info_locals_command): Update to use new
3429 extract_info_print_options, also add a header comment.
3430 (info_args_command): Likewise.
3431 * symtab.c (info_variables_command): Likewise.
3432 (info_functions_command): Likewise.
3434 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3436 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3437 to extract string arguments.
3438 * common/common-utils.c (extract_string_maybe_quoted): New function.
3439 * common/common-utils.h (extract_string_maybe_quoted): Declare.
3441 2019-07-11 Tom Tromey <tromey@adacore.com>
3443 * main.c (get_init_files): Use GDBINIT, not gdbinit.
3444 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3445 * top.h (gdbinit): Don't declare.
3446 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3448 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
3449 * top.c (gdb_init): Don't call init_cli_cmds.
3451 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3453 2019-07-11 Tom Tromey <tromey@adacore.com>
3455 * python/py-inferior.c (add_thread_object): Don't use thread_obj
3456 after it has been moved.
3458 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3460 * valops.c (value_must_coerce_to_target): Change return type to
3462 * value.h (value_must_coerce_to_target): Likewise.
3464 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
3466 * breakpoint.c (is_hardware_watchpoint): Remove
3467 forward-declaration.
3468 (is_masked_watchpoint): Change return type to bool.
3469 (is_tracepoint): Likewise.
3470 (is_breakpoint): Likewise.
3471 (is_hardware_watchpoint): Likewise.
3472 (is_watchpoint): Likewise.
3473 (is_no_memory_software_watchpoint): Likewise.
3474 (is_catchpoint): Likewise.
3475 (breakpoint_1): Make FILTER parameter's return type bool.
3476 is_masked_watchpoint): Change return type to bool.
3477 (save_breakpoints): Make FILTER parameter's return type bool.
3478 * breakpoint.h (is_breakpoint): Change return type to bool.
3479 (is_watchpoint): Likewise.
3480 (is_catchpoint): Likewise.
3481 (is_tracepoint): Likewise.
3483 2019-07-10 Tom Tromey <tom@tromey.com>
3485 * defs.h: Don't include gdbarch.h.
3486 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3487 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3488 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3489 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3490 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3491 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3492 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3493 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3494 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3495 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3496 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3497 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3498 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3499 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3500 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3501 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3502 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3503 record-btrace.c, record.h, regcache-dump.c, regcache.h,
3504 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3505 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3506 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3507 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3508 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3509 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3510 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3511 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3512 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3514 2019-07-10 Tom Tromey <tromey@adacore.com>
3516 * ada-lang.h (is_ada_exception_catchpoint): Declare.
3517 * breakpoint.c (init_ada_exception_breakpoint): Register as
3519 (print_one_breakpoint_location, print_one_breakpoint): Use
3520 is_ada_exception_catchpoint.
3521 * ada-lang.c (class ada_catchpoint_location): Pass
3522 bp_loc_software_breakpoint to bp_location constructor.
3523 (is_ada_exception_catchpoint): New function.
3525 2019-07-10 Tom Tromey <tromey@adacore.com>
3527 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
3529 (struct arm_exidx_entry): New method operator<.
3530 (struct arm_exidx_data) <section_maps>: Change type.
3531 (arm_exidx_data_free): Remove.
3532 (arm_exidx_data_key): Change type. Move lower.
3533 (arm_exidx_new_objfile): Update.
3534 (arm_compare_exidx_entries): Remove.
3535 (arm_find_exidx_entry, _initialize_arm_tdep)
3537 2019-07-10 Tom Tromey <tromey@adacore.com>
3539 * solib-spu.c (ocl_program_data_key): Change type.
3540 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3543 2019-07-10 Tom Tromey <tromey@adacore.com>
3545 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
3546 (struct solib_aix_inferior_data) <library_list>: Change type.
3547 (solib_aix_inferior_data_handle): Change type.
3548 (get_solib_aix_inferior_data): Update.
3549 (solib_aix_free_library_list): Remove.
3550 (library_list_start_library): Update.
3551 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3553 (solib_aix_get_library_list)
3554 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3555 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3557 2019-07-10 Tom Tromey <tromey@adacore.com>
3559 * solib-dsbt.c (struct dsbt_info): Add initializers.
3560 (solib_dsbt_pspace_data): Change type.
3561 (dsbt_pspace_data_cleanup): Remove.
3562 (get_dsbt_info, _initialize_dsbt_solib): Update.
3564 2019-07-10 Tom Tromey <tromey@adacore.com>
3566 * spu-tdep.c (spu_overlay_data): Change type.
3567 (spu_get_overlay_table, spu_overlay_new_objfile)
3568 (_initialize_spu_tdep): Update.
3570 2019-07-10 Tom Tromey <tromey@adacore.com>
3572 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3574 (dbx_objfile_data_key): Change type and declare later.
3575 (DBX_SYMFILE_INFO): Rewrite.
3576 * dbxread.c (dbx_objfile_data_key): Change type.
3577 (dbx_symfile_init): Update.
3578 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
3579 (coffstab_build_psymtabs, elfstab_build_psymtabs)
3580 (stabsect_build_psymtabs, _initialize_dbxread): Update.
3582 2019-07-10 Tom Tromey <tromey@adacore.com>
3584 * jit.c (jit_program_space_key): Change type. Move lower.
3585 (get_jit_program_space_data): Update.
3586 (jit_program_space_data_cleanup): Remove.
3587 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3589 (struct jit_program_space_data): Add initializers.
3591 2019-07-10 Tom Tromey <tromey@adacore.com>
3593 * solib-darwin.c (struct darwin_info): Add initializers.
3594 (solib_darwin_pspace_data): Change type.
3595 (darwin_pspace_data_cleanup): Remove.
3596 (get_darwin_info, _initialize_darwin_solib): Update.
3598 2019-07-10 Tom Tromey <tromey@adacore.com>
3600 * remote-sim.c (struct sim_inferior_data): Add initializers,
3601 constructor, and destructor.
3602 (sim_inferior_data_key): Change type. Move lower.
3603 (check_for_duplicate_sim_descriptor): Update.
3604 (get_sim_inferior_data): Use new. Update.
3605 (~sim_inferior_data_cleanup): Rename from
3606 sim_inferior_data_cleanup. Simplify.
3607 (gdbsim_close_inferior, simulator_command)
3608 (sim_command_completer, _initialize_remote_sim): Update.
3609 (next_pid, INITIAL_PID): Move earlier.
3611 2019-07-10 Tom Tromey <tromey@adacore.com>
3613 * python/python-internal.h (create_thread_object): Return
3615 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3616 * python/py-inferior.c (struct threadlist_entry): Add
3618 <thread_obj>: Now a gdbpy_ref.
3619 (thread_to_thread_object): Update.
3620 (add_thread_object): Use new.
3621 (delete_thread_object): Use delete.
3622 (infpy_threads): Update.
3623 (py_free_inferior): Update. Construct "inf_obj" after acquiring
3626 2019-07-10 Tom Tromey <tromey@adacore.com>
3628 * valops.c (value_cast): Specialize error message for Ada.
3630 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3632 * breakpoint.c (breakpoint_1): Update doc and parameter names.
3634 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3636 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3637 bpstat_should_step): Return bool, adjust comments.
3638 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3639 bpstat_should_step): Likewise.
3641 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3643 * features/Makefile: Use feature target descriptions for Arm.
3644 * features/arm/arm-core.c: Generate new file.
3645 * features/arm/arm-fpa.c: Likewise.
3646 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3647 * features/arm/arm-m-profile.c: Likewise.
3648 * features/arm/arm-vfpv2.c: Likewise.
3649 * features/arm/arm-vfpv3.c: Likewise.
3650 * features/arm/xscale-iwmmxt.c: Likewise.
3651 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3653 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3655 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3658 2019-07-10 Alan Hayward <alan.hayward@arm.com>
3660 * features/aarch64-pauth.c: Regenerate.
3662 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
3664 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3666 (bpstat_what): Use false instead of 0.
3668 2019-07-09 Pedro Alves <palves@redhat.com>
3670 * break-catch-throw.c (is_exception_catchpoint): New.
3671 * breakpoint.c (print_one_breakpoint_location): New parameter
3672 'raw_loc'. Handle it. Use
3673 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3674 looking at the breakpoint's type.
3675 (print_one_breakpoint): If handling "maint info breakpoints", also
3676 print locations of exception catchpoints.
3677 * breakpoint.h (is_exception_catchpoint): Declare.
3679 2019-07-09 Pedro Alves <palves@redhat.com>
3681 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3683 (allocate_location_exception_catchpoint): New.
3684 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3685 (initialize_throw_catchpoint_ops): Install
3686 allocate_location_exception_catchpoint as allocate_location
3688 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3689 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3691 (breakpoint_address_is_meaningful): Delete.
3692 (bl_address_is_meaningful): New.
3693 (breakpoint_locations_match): Adjust comment.
3694 (bp_location_from_bp_type): New, factored out of...
3695 (bp_location::bp_location(breakpoint *)): ... this.
3696 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3698 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
3699 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3700 breakpoint_address_is_meaningful.
3701 (bp_locations_compare): Adjust comment.
3702 (update_global_location_list): Use bl_address_is_meaningful
3703 instead of breakpoint_address_is_meaningful.
3704 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3706 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3707 * python/py-breakpoint.c (bppy_get_location): No longer check
3708 whether location is null.
3710 2019-07-09 Pedro Alves <palves@redhat.com>
3713 * breakpoint.c (print_one_breakpoint_location): Remove
3714 single-location assert.
3716 2019-07-09 Tom Tromey <tom@tromey.com>
3718 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3719 * configure: Rebuild.
3720 * configure.ac: Change common to gdbsupport.
3721 * gdbsupport: Rename from common.
3722 * acinclude.m4: Change common to gdbsupport.
3723 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3724 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3726 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3727 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3728 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3729 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3730 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3731 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3732 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3733 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3734 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3735 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3736 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3737 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3738 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3739 coff-pe-read.c, command.h, compile/compile-c-support.c,
3740 compile/compile-c.h, compile/compile-cplus-symbols.c,
3741 compile/compile-cplus-types.c, compile/compile-cplus.h,
3742 compile/compile-loc2c.c, compile/compile.c, completer.c,
3743 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3744 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3745 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3746 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3747 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3748 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3749 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3750 features/aarch64-core.c, features/aarch64-fpu.c,
3751 features/aarch64-pauth.c, features/aarch64-sve.c,
3752 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3753 features/i386/32bit-core.c, features/i386/32bit-linux.c,
3754 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3755 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3756 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3757 features/i386/64bit-core.c, features/i386/64bit-linux.c,
3758 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3759 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3760 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3761 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3762 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3763 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3764 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3765 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3766 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3767 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3768 go32-nat.c, guile/guile.c, guile/scm-ports.c,
3769 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3770 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3771 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3772 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3773 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3774 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3775 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3776 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3777 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3778 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3779 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3780 minsyms.c, mips-linux-tdep.c, namespace.h,
3781 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3782 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3783 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3784 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3785 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3786 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3787 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3788 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3789 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3790 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3791 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3792 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3793 procfs.c, producer.c, progspace.h, psymtab.h,
3794 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3795 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3796 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3797 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3798 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3799 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3800 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3801 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3802 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3803 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3804 target-memory.c, target.c, target.h, target/waitstatus.c,
3805 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3806 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3807 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3808 unittests/array-view-selftests.c,
3809 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3810 unittests/common-utils-selftests.c,
3811 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3812 unittests/format_pieces-selftests.c,
3813 unittests/function-view-selftests.c,
3814 unittests/lookup_name_info-selftests.c,
3815 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3816 unittests/mkdir-recursive-selftests.c,
3817 unittests/observable-selftests.c,
3818 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3819 unittests/parse-connection-spec-selftests.c,
3820 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3821 unittests/scoped_fd-selftests.c,
3822 unittests/scoped_mmap-selftests.c,
3823 unittests/scoped_restore-selftests.c,
3824 unittests/string_view-selftests.c, unittests/style-selftests.c,
3825 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3826 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3827 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3828 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3829 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3830 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3832 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3834 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3836 (decode_digits_ordinary): Set explicit_line field in sal.
3837 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3838 symtab_and_line that was set on an explicit line number in
3839 assembler code. Do always update the recorded symtab and line if
3840 we do skip the prologue.
3842 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3844 * breakpoint.c (set_breakpoint_location_function): Remove
3845 explicit_loc parameter.
3846 (momentary_breakpoint_from_master): Update call to
3847 set_breakpoint_location_function.
3848 (add_location_to_breakpoint): Likewise.
3850 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3852 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3853 required features based on default bfd type when no specific bfd
3856 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3858 * NEWS: Mention that GDB printf and eval commands can now print
3859 C-style and Ada-style convenience var strings without
3860 calling the inferior.
3861 * printcmd.c (printf_c_string): Locally print GDB internal var
3862 instead of transiting via the inferior.
3863 (printf_wide_c_string): Likewise.
3865 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3867 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3869 2019-07-04 Tom Tromey <tom@tromey.com>
3872 * tui/tui-winsource.c (tui_clear_source_content): Update.
3873 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3874 (tui_update_breakpoint_info): Update.
3875 (tui_set_exec_info_content): Update.
3876 * tui/tui-source.c (tui_set_source_content_nil): Update.
3877 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3879 * tui/tui-data.h (enum tui_bp_flag): New.
3880 (tui_bp_flags): New enum flags type.
3881 (struct tui_source_element) <break_mode>: Change type. Rename
3883 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3884 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3886 * tui/tui-winsource.h: Fix comment.
3888 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3890 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3891 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3892 (store_fpregs_to_thread)
3893 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3894 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3895 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3896 (IWMMXT_REGS_SIZE): Add define.
3897 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3898 (fetch_vfp_regs, store_vfp_regs)
3899 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3900 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3902 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3904 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3906 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3907 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3908 (ARM_INT_REGISTER_SIZE): ...to this.
3909 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3910 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3911 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3912 (arm_linux_collect_gregset, supply_nwfpe_register)
3913 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3915 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3916 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3917 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3918 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3919 (arm_return_in_memory, arm_store_return_value)
3920 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3921 (arm_record_ld_st_multiple): Likewise.
3922 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3923 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3925 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3927 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3928 AARCH64_DISPLACED_MODIFIED_INSNS.
3929 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3930 (aarch64_displaced_step_copy_insn): Likewise.
3931 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3932 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3933 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3934 ARM_DISPLACED_MODIFIED_INSNS.
3935 * arm-tdep.c (arm_gdbarch_init): Likewise.
3936 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3937 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3938 (struct arm_displaced_step_closure): Use
3939 ARM_DISPLACED_MODIFIED_INSNS.
3941 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3943 * features/Makefile: Remove unused xml files.
3944 * features/aarch64.xml: Remove.
3945 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3946 * features/i386/amd64-avx-avx512.xml: Remove.
3947 * features/i386/amd64-avx-linux.xml: Remove.
3948 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3949 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3950 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3951 * features/i386/amd64-avx-mpx.xml: Remove.
3952 * features/i386/amd64-avx.xml: Remove.
3953 * features/i386/amd64-linux.xml: Remove.
3954 * features/i386/amd64-mpx-linux.xml: Remove.
3955 * features/i386/amd64-mpx.xml: Remove.
3956 * features/i386/amd64.xml: Remove.
3957 * features/i386/i386-avx-avx512-linux.xml: Remove.
3958 * features/i386/i386-avx-avx512.xml: Remove.
3959 * features/i386/i386-avx-linux.xml: Remove.
3960 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3961 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3962 * features/i386/i386-avx-mpx-linux.xml: Remove.
3963 * features/i386/i386-avx-mpx.xml: Remove.
3964 * features/i386/i386-avx.xml: Remove.
3965 * features/i386/i386-linux.xml: Remove.
3966 * features/i386/i386-mmx-linux.xml: Remove.
3967 * features/i386/i386-mmx.xml: Remove.
3968 * features/i386/i386-mpx-linux.xml: Remove.
3969 * features/i386/i386-mpx.xml: Remove.
3970 * features/i386/i386.xml: Remove.
3971 * features/i386/x32-avx-avx512-linux.xml: Remove.
3972 * features/i386/x32-avx-linux.xml: Remove.
3973 * features/i386/x32-linux.xml: Remove.
3975 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3977 * regformats/aarch64.dat: Remove.
3978 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3979 * regformats/i386/amd64-avx-linux.dat: Remove.
3980 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3981 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3982 * regformats/i386/amd64-linux.dat: Remove.
3983 * regformats/i386/amd64-mpx-linux.dat: Remove.
3984 * regformats/i386/amd64.dat: Remove.
3985 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3986 * regformats/i386/i386-avx-linux.dat: Remove.
3987 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3988 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3989 * regformats/i386/i386-linux.dat: Remove.
3990 * regformats/i386/i386-mmx-linux.dat: Remove.
3991 * regformats/i386/i386-mpx-linux.dat: Remove.
3992 * regformats/i386/i386.dat: Remove.
3993 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3994 * regformats/i386/x32-avx-linux.dat: Remove.
3995 * regformats/i386/x32-linux.dat: Remove.
3997 2019-07-04 Alan Hayward <alan.hayward@arm.com>
3999 * aarch64-tdep.c: Remove xml self tests.
4000 * amd64-linux-tdep.c: Likewise.
4001 * amd64-tdep.c: Likewise.
4002 * i386-linux-tdep.c: Likewise.
4003 * i386-tdep.c: Likewise.
4005 2019-07-03 Pedro Alves <palves@redhat.com>
4008 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4009 (pipe_cmd_option_defs): New.
4010 (make_pipe_cmd_options_def_group): New.
4011 (pipe_command): Use gdb::option::process_options.
4012 (pipe_command_completer): New function.
4013 (_initialize_cli_cmds): Install completer for "pipe" command.
4015 2019-07-03 Pedro Alves <palves@redhat.com>
4017 * cli/cli-option.c (union option_value) <string>: New field.
4018 (struct option_def_and_value): Add ctor, move ctor, dtor and
4019 use DISABLE_COPY_AND_ASSIGN.
4020 (option_def_and_value::clear_value): New.
4021 (parse_option, save_option_value_in_ctx, get_val_type_str)
4022 (add_setshow_cmds_for_options): Handle var_string.
4023 * cli-option.h (union option_def::var_address) <string>: New
4025 (struct string_option_def): New.
4026 * maint-test-options.c (struct test_options_opts): Add default
4027 ctor and use DISABLE_COPY_AND_ASSIGN.
4028 <string_opt>: New field.
4029 (test_options_opts::~test_options_opts): New.
4030 (test_options_opts::dump): Also dump "-string".
4031 (test_options_option_defs): Install "string.
4033 2019-07-03 Pedro Alves <palves@redhat.com>
4035 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4036 option_value with a null enumeration.
4037 (complete_options): Save the option values in the context.
4038 (save_option_value_in_ctx): New, factored out from ...
4039 (process_options): ... here.
4040 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4042 * maint-test-options.c (test_options_opts::dump): New, factored
4044 (maintenance_test_options_command_mode): ... here.
4045 (maintenance_test_options_command_completion_result): Delete.
4046 (maintenance_test_options_command_completion_text): Update
4048 (maintenance_show_test_options_completion_result): Change
4049 prototype. Just print
4050 maintenance_test_options_command_completion_text.
4051 (save_completion_result): New.
4052 (maintenance_test_options_completer_mode): Pass options context to
4053 complete_options, and then save a dump.
4054 (_initialize_maint_test_options): Use add_cmd to install "maint
4055 show test-options-completion-result".
4057 2019-07-03 Pedro Alves <palves@redhat.com>
4059 * NEWS (New commands): Mention "with" and "maint with".
4060 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4061 (with_command, with_command_completer): New.
4062 (pipe_command): Adjust to new repeat_previous
4064 (_initialize_cli_cmds): Install the "with" command and its "w"
4066 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4068 * cli/cli-setshow.c (parse_cli_var_uinteger)
4069 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4070 argument strings for all var_types.
4071 (get_setshow_command_value_string): New, factored out from ...
4072 (do_show_command): ... this.
4073 * cli/cli-setshow.h: Include <string>.
4074 (get_setshow_command_value_string): Declare.
4075 * command.h (repeat_previous): Now returns const char *. Adjust
4077 * maint.c: Include "cli/cli-cmds.h".
4078 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4079 (_initialize_maint_cmds): Register the "maintenance with" command.
4080 * top.c (repeat_previous): Move bits from pipe_command here:
4081 Return the saved command line, if any; error out if there's no
4082 command to relaunch.
4084 2019-07-03 Pedro Alves <palves@redhat.com>
4086 * NEWS (New commands): Mention "maint set/show test-settings"
4087 instead of "maint test-settings".
4088 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4089 (maintenance_test_settings_set_list): Rename to ...
4090 (maintenance_set_test_settings_list): ... this.
4091 (maintenance_test_settings_show_list): Rename to ...
4092 (maintenance_show_test_settings_list): ... this.
4093 (maintenance_test_settings_cmd): Delete.
4094 (maintenance_test_settings_set_cmd): ...
4095 (maintenance_set_test_settings_cmd): ... this.
4096 (maintenance_test_settings_show_cmd): ...
4097 (maintenance_show_test_settings_cmd): ... this.
4098 (maintenance_test_settings_show_value_cmd):
4099 (maintenance_show_test_settings_value_cmd): ... this.
4100 (_initialize_maint_test_settings): No longer install the "maint
4101 test-settings" prefix command. Rename "maint test-settings set"
4102 to "maint set test-settings", and "maint test-settings show" to
4103 "maint show test-settings". Adjust all subcommands.
4105 2019-07-03 Pedro Alves <palves@redhat.com>
4107 * maint-test-settings.c: Fix file's intro comment. Replace all
4108 references to "test-options" with references to "test-settings",
4111 2019-07-03 Pedro Alves <palves@redhat.com>
4113 * maint-test-settings.c (maintenance_test_settings_xxx)
4114 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4116 (maintenance_test_settings_enums): Use them.
4117 (maintenance_test_settings_enum): Default to
4118 maintenance_test_settings_xxx.
4119 (_initialize_maint_test_settings): Initialize
4120 MAINTENANCE_TEST_SETTINGS_FILENAME.
4122 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4124 * breakpoint.h (remove_breakpoints_inf): Change return type to
4125 void, move function documentation here.
4126 * breakpoint.c (remove_breakpoints_inf): Change return type to
4127 void, move function documentation to header.
4129 2019-07-02 Pedro Alves <palves@redhat.com>
4131 * NEWS (Completion improvements): Mention "info threads".
4132 * thread.c (struct info_threads_opts, info_threads_option_defs)
4133 (make_info_threads_options_def_group): New.
4134 (info_threads_command): Use gdb::option::process_options.
4135 (info_threads_command_completer): New.
4136 (_initialize_thread): Use gdb::option::build_help to build the
4137 help text for "info threads".
4139 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4141 * defs.h (generic_load): Move from here...
4142 * symfile.h (generic_load): ... to here. Rename name parameter
4144 * symfile.c (generic_load): Add comment.
4146 2019-07-01 Tom Tromey <tromey@adacore.com>
4149 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4150 declaration of without_params. Fix formatting.
4152 2019-07-01 Tom Tromey <tromey@adacore.com>
4154 * ada-exp.y (find_primitive_type): Update.
4155 * ada-lang.h (ada_lookup_symbol): Update.
4156 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4158 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4160 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4162 PR breakpoints/24541
4163 * gdbarch.c: Regenerate.
4164 * gdbarch.h: Regenerate.
4165 * gdbarch.sh: Add 'stap_adjust_register'.
4166 * i386-tdep.c: Include '<unordered_set>'.
4167 (i386_stap_adjust_register): New function.
4168 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4169 * stap-probe.c (stap_parse_register_operand): Call
4170 'gdbarch_stap_adjust_register'.
4172 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4175 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4176 * python/python.c (do_start_initialization): Use 'xmalloc'
4177 instead of 'PyMem_Malloc'.
4179 2019-06-28 Tom Tromey <tromey@adacore.com>
4181 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4184 2019-06-27 Tom Tromey <tromey@adacore.com>
4186 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4188 (arm_find_mapping_symbol, arm_record_special_symbol)
4189 (_initialize_arm_tdep): Update.
4190 (arm_objfile_data_free): Remove.
4192 2019-06-27 Tom Tromey <tromey@adacore.com>
4194 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4195 to cp_print_static_field.
4197 2019-06-26 Tom Tromey <tromey@adacore.com>
4199 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4200 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4203 2019-06-26 Alan Hayward <alan.hayward@arm.com>
4205 * features/aarch64-core.c (create_feature_aarch64_core):
4207 * features/aarch64-core.xml: Add cpsr flags.
4209 2019-06-26 Alan Hayward <alan.hayward@arm.com>
4211 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4212 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4214 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4216 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4218 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4220 (arm_record_special_symbol): Don't insert new symbol in sorted
4221 position, push it at the end.
4223 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4225 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4226 (arm_mapping_symbol_s): Remove.
4227 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4228 (arm_mapping_symbol_vec): New typedef.
4229 (struct arm_per_objfile): Add constructor.
4230 <section_maps>: Change type to
4231 std::unique_ptr<arm_mapping_symbol_vec[]>.
4232 (arm_compare_mapping_symbols): Remove.
4233 (arm_find_mapping_symbol): Adjust to section_maps type change.
4234 (arm_objfile_data_free): Call delete on arm_per_objfile.
4235 (arm_record_special_symbol): Adjust to section_maps type change.
4236 Allocate arm_per_objfile with new.
4238 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4240 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4241 with the command prefix.
4243 2019-06-25 Tom Tromey <tom@tromey.com>
4245 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4246 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4248 2019-06-25 Tom Tromey <tom@tromey.com>
4250 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4252 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4255 2019-06-25 Tom Tromey <tom@tromey.com>
4257 * tui/tui-winsource.c
4258 (tui_source_window_base::set_is_exec_point_at): Add check against
4261 2019-06-25 Tom Tromey <tom@tromey.com>
4263 * tui/tui-source.c (tui_set_source_content): Don't check before
4265 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4267 2019-06-25 Tom Tromey <tom@tromey.com>
4269 * tui/tui-winsource.h (tui_update_source_window_as_is)
4270 (tui_alloc_source_buffer, tui_line_is_displayed)
4271 (tui_addr_is_displayed): Change type of win_info.
4272 * tui/tui-winsource.c (tui_update_source_window_as_is)
4273 (tui_clear_source_content, tui_show_source_line)
4274 (tui_show_source_content, tui_source_window_base::refill)
4275 (tui_source_window_base::set_is_exec_point_at)
4276 (tui_source_window_base::set_is_exec_point_at)
4277 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4278 (tui_alloc_source_buffer, tui_line_is_displayed)
4279 (tui_addr_is_displayed): Change type of win_info. Update.
4280 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4281 (tui_source_window_base::do_make_visible_with_new_height):
4283 * tui/tui-source.c (tui_set_source_content)
4284 (tui_set_source_content_nil)
4285 (tui_source_window::do_scroll_vertical): Update.
4286 * tui/tui-layout.c (show_layout): Update.
4287 * tui/tui-disasm.c (tui_set_disassem_content)
4288 (tui_disasm_window::do_scroll_vertical): Update.
4289 * tui/tui-data.h (tui_win_content): Remove.
4290 (struct tui_gen_win_info) <content, content_size>: Remove.
4291 (struct tui_source_element): Add initializers and destructor.
4292 (union tui_which_element, struct tui_win_element): Remove.
4293 (struct tui_source_window_base) <content>: New field.
4294 (struct tui_data_window): Remove destructor.
4295 (tui_alloc_content, tui_free_win_content)
4296 (tui_free_all_source_wins_content): Don't declare.
4297 * tui/tui-data.c (tui_initialize_static_data): Update.
4298 (init_content_element, tui_alloc_content): Remove.
4299 (~tui_gen_win_info): Update.
4300 (~tui_data_window, tui_free_all_source_wins_content)
4301 (tui_free_win_content, free_content, free_content_elements):
4304 2019-06-25 Tom Tromey <tom@tromey.com>
4306 * tui/tui-winsource.h (tui_clear_source_content)
4307 (tui_erase_source_content, tui_show_source_content): Change type
4309 * tui/tui-winsource.c (tui_clear_source_content)
4310 (tui_erase_source_content, tui_show_source_content): Change type
4312 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4313 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4315 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4317 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4319 2019-06-25 Tom Tromey <tom@tromey.com>
4321 * tui/tui-winsource.c (tui_clear_source_content)
4322 (tui_source_window_base::set_is_exec_point_at): Update.
4323 * tui/tui-source.c (tui_set_source_content_nil): Update.
4324 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4326 * tui/tui-data.c (init_content_element): Update.
4328 2019-06-25 Tom Tromey <tom@tromey.com>
4330 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4331 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4332 * tui/tui-layout.c (init_and_make_win): Update.
4333 * tui/tui.h (enum tui_win_type): Update.
4334 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4335 tui_win_is_auxillary.
4336 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4337 tui_win_is_auxillary.
4339 2019-06-25 Tom Tromey <tom@tromey.com>
4341 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4342 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4343 (tui_delete_data_content_windows, tui_display_all_data)
4344 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4346 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4347 * tui/tui-regs.c (tui_last_regs_line_no)
4348 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4349 (tui_show_registers): Update.
4350 (tui_show_register_group): Return void. Update.
4351 (tui_display_registers_from, tui_display_reg_element_at_line)
4352 (tui_display_registers_from_line, tui_check_register_values):
4354 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4356 (struct tui_data_window) <regs_content>: Now a std::vector.
4357 <regs_content_count>: Remove.
4358 (tui_add_content_elements, tui_free_data_content): Don't declare.
4359 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4360 (init_content_element): Remove DATA_WIN case. Add assert.
4361 (tui_add_content_elements): Remove.
4362 (tui_data_window): Update.
4363 (tui_free_data_content): Remove.
4364 (free_content_elements): Remove DATA_WIN case.
4366 2019-06-25 Tom Tromey <tom@tromey.com>
4368 * tui/tui-data.c (tui_data_item_window): Update.
4369 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4370 * tui/tui-windata.c (tui_display_all_data)
4371 (tui_display_data_from_line): Update.
4372 (tui_check_data_values): Remove.
4373 * tui/tui-regs.c (tui_show_register_group)
4374 (tui_display_reg_element_at_line): Update.
4375 * tui/tui-hooks.c (tui_register_changed)
4376 (tui_refresh_frame_and_register_information): Call
4377 tui_check_register_values.
4378 * tui/tui-data.h (struct tui_data_window) <data_content,
4379 data_content_count, data_type>: Remove.
4380 (enum tui_data_type): Remove.
4382 * tui/tui-data.c (tui_data_window::clear_detail)
4383 (~tui_data_window): Update.
4385 2019-06-25 Tom Tromey <tom@tromey.com>
4387 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4389 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4390 Rename from tui_first_data_item_displayed. Update.
4391 (tui_data_window::refresh_all)
4392 (tui_data_window::do_scroll_vertical): Update.
4393 * tui/tui-data.h (struct tui_data_window)
4394 <first_data_item_displayed>: Declare new method.
4396 2019-06-25 Tom Tromey <tom@tromey.com>
4398 * tui/tui-data.h (tui_init_generic_part): Don't declare.
4399 * tui/tui-data.c (tui_init_generic_part): Remove, moving
4401 (tui_initialize_static_data): ...here.
4403 2019-06-25 Tom Tromey <tom@tromey.com>
4405 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4406 (tui_display_registers_from, tui_check_register_values): Update.
4407 (tui_display_register): Remove win_info parameter; update.
4408 (tui_get_register): Change type of parameters.
4409 * tui/tui-data.h (struct tui_data_element): Remove.
4410 (union tui_which_element) <data>: Remove.
4411 <data_window>: Change type.
4412 (struct tui_data_item_window): New.
4413 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4415 (~tui_data_item_window): New destructor.
4416 (free_content_elements): Remove DATA_ITEM_WIN case.
4418 2019-06-25 Tom Tromey <tom@tromey.com>
4420 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4423 2019-06-25 Tom Tromey <tom@tromey.com>
4425 * tui/tui-data.h (struct tui_command_element): Remove.
4426 (union tui_which_element) <command>: Remove.
4427 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
4429 (free_content_elements): Remove CMD_WIN case.
4431 2019-06-25 Tom Tromey <tom@tromey.com>
4433 * tui/tui-layout.c (tui_set_layout): Update.
4434 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4435 * tui/tui-data.c (layout_def): Update.
4437 2019-06-25 Tom Tromey <tom@tromey.com>
4439 * tui/tui-wingeneral.c (tui_refresh_all): Update.
4440 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4441 (tui_source_window_base::set_new_height): Update.
4442 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4444 (tui_set_locator_fullname, tui_set_locator_info)
4445 (tui_show_frame_info): Update.
4446 * tui/tui-source.c (tui_set_source_content)
4447 (tui_source_is_displayed): Update.
4448 * tui/tui-layout.c (show_source_disasm_command, show_data)
4449 (show_source_or_disasm_and_command): Update.
4450 * tui/tui-disasm.c (tui_set_disassem_content)
4451 (tui_get_begin_asm_address): Update.
4452 * tui/tui-data.h (struct tui_locator_element): Remove.
4453 (union tui_which_element) <locator>: Remove.
4454 (struct tui_locator_window): New.
4455 (tui_locator_win_info_ptr): Change return type.
4456 * tui/tui-data.c (_locator): Change type.
4457 (tui_locator_win_info_ptr): Change return type.
4458 (init_content_element): Remove LOCATOR_WIN case. Add assert.
4459 (tui_alloc_content): Add assert.
4461 2019-06-25 Tom Tromey <tom@tromey.com>
4463 * tui/tui-winsource.c
4464 (tui_exec_info_window::maybe_allocate_content): New method.
4465 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4466 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4467 (make_source_or_disasm_window): Add cast.
4468 * tui/tui-data.h (union tui_which_element) <simple_string>:
4470 (struct tui_source_info): New.
4471 (struct tui_source_window_base) <execution_info>: Change type.
4472 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4473 case, and add assert.
4474 (tui_alloc_content): Add assert.
4476 2019-06-25 Tom Tromey <tom@tromey.com>
4478 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4479 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4480 * tui/tui-data.c (tui_alloc_win_info): Remove.
4482 2019-06-25 Tom Tromey <tom@tromey.com>
4484 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4485 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4488 2019-06-25 Tom Tromey <tom@tromey.com>
4490 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4491 make_visible_with_new_height method.
4492 (tui_win_info::make_visible_with_new_height): New method.
4493 (tui_source_window_base::do_make_visible_with_new_height)
4494 (tui_data_window::do_make_visible_with_new_height)
4495 (tui_cmd_window::do_make_visible_with_new_height): New methods.
4496 (make_visible_with_new_height): Remove.
4497 (tui_resize_all, tui_adjust_win_heights): Use
4498 make_visible_with_new_height method.
4499 * tui/tui-data.h (struct tui_win_info)
4500 <do_make_visible_with_new_height, make_visible_with_new_height>:
4502 (struct tui_source_window_base, struct tui_data_window)
4503 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4506 2019-06-25 Tom Tromey <tom@tromey.com>
4508 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4510 (update_tab_width): Call update_tab_width method.
4511 * tui/tui-data.h (struct tui_win_info)
4512 (struct tui_source_window_base) <update_tab_width>: New methods.
4514 2019-06-25 Tom Tromey <tom@tromey.com>
4516 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4518 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4520 (tui_gen_win_info::make_visible): Update.
4521 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4523 * tui/tui-data.h (enum tui_box): New enum.
4524 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4526 2019-06-25 Tom Tromey <tom@tromey.com>
4528 * tui/tui-layout.c (make_source_or_disasm_window): Always use
4529 init_and_make_win for EXEC_INFO_WIN.
4530 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4532 (struct tui_win_info) <~tui_win_info>: Inline.
4533 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4535 * tui/tui-data.c (source_win, disasm_win): Remove globals.
4536 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4538 (tui_initialize_static_data): Update.
4539 (~tui_gen_win_info): Handle more cleanup here.
4540 (~tui_source_window_base): Delete "execution_info".
4541 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4543 2019-06-25 Tom Tromey <tom@tromey.com>
4545 * tui/tui-layout.c (make_command_window): Don't set
4547 (show_source_disasm_command): Call the reset method.
4548 (show_data): Don't set can_highlight. Call the reset method.
4549 (tui_gen_win_info::reset): Rename from init_gen_win_info
4550 (init_and_make_win): Simplify. Return tui_gen_win_info.
4551 (show_source_or_disasm_and_command): Call the reset method.
4552 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4553 (struct tui_cmd_window): Set can_highlight.
4555 2019-06-25 Tom Tromey <tom@tromey.com>
4557 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4559 (tui_make_visible, tui_make_invisible): Rewrite.
4560 (tui_win_info::make_visible): Remove.
4561 (tui_source_window_base::make_visible): Update.
4562 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4563 method. Moved from...
4564 (struct tui_win_info) <make_visible>: ...here.
4566 2019-06-25 Tom Tromey <tom@tromey.com>
4568 * tui/tui-winsource.c
4569 (tui_source_window_base::do_scroll_horizontal): Remove direction
4571 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4572 direction parameter.
4573 * tui/tui-win.c (tui_win_info::forward_scroll)
4574 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4575 (tui_win_info::right_scroll): Update.
4576 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4577 direction parameter.
4578 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4579 direction parameter.
4580 * tui/tui-data.h (enum tui_scroll_direction): Remove.
4581 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4582 Remove direction parameter.
4583 (struct tui_source_window_base, struct tui_source_window)
4584 (struct tui_disasm_window, struct tui_data_window)
4585 (struct tui_cmd_window): Update.
4587 2019-06-25 Tom Tromey <tom@tromey.com>
4589 * tui/tui-winsource.h (tui_set_exec_info_content)
4590 (tui_show_exec_info_content, tui_erase_exec_info_content)
4591 (tui_clear_exec_info_content, tui_update_exec_info): Change
4592 argument to tui_source_window_base.
4593 * tui/tui-winsource.c (tui_set_exec_info_content)
4594 (tui_show_exec_info_content, tui_erase_exec_info_content)
4595 (tui_clear_exec_info_content, tui_update_exec_info): Change
4596 argument to tui_source_window_base.
4598 2019-06-25 Tom Tromey <tom@tromey.com>
4600 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4601 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4603 2019-06-25 Tom Tromey <tom@tromey.com>
4605 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4608 2019-06-25 Tom Tromey <tom@tromey.com>
4610 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4612 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4614 * tui/tui-source.c (tui_set_source_content): Update.
4615 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4617 2019-06-25 Tom Tromey <tom@tromey.com>
4619 * tui/tui-win.c (window_name_completer, tui_set_focus)
4620 (tui_all_windows_info): Use name method.
4621 * tui/tui-data.h (struct tui_gen_win_info)
4622 (struct tui_source_window, struct tui_disasm_window)
4623 (struct tui_data_window, struct tui_cmd_window) <name>: New
4625 (tui_win_name): Don't declare.
4626 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4627 (tui_win_name): Remove.
4629 2019-06-25 Tom Tromey <tom@tromey.com>
4631 * tui/tui-winsource.h (tui_update_source_window)
4632 (tui_update_source_window_as_is): Change parameter type.
4633 * tui/tui-winsource.c (tui_update_source_window): Change win_info
4634 to be a tui_source_window_base.
4635 (tui_update_source_window_as_is): Likewise.
4636 * tui/tui-win.c (make_visible_with_new_height): Update.
4638 2019-06-25 Tom Tromey <tom@tromey.com>
4640 * tui/tui-winsource.c (tui_erase_source_content)
4641 (tui_show_source_content, tui_show_exec_info_content)
4642 (tui_erase_exec_info_content): Use refresh_window method.
4643 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4644 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4645 from tui_refresh_win.
4646 (tui_data_window::refresh_window): New method.
4647 (tui_win_info::refresh, tui_source_window_base::refresh)
4648 (tui_refresh_all): Use refresh_window method.
4649 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4651 * tui/tui-regs.c (tui_display_register): Call refresh_window
4653 * tui/tui-layout.c (show_source_disasm_command)
4654 (show_source_or_disasm_and_command): Call refresh_window method.
4655 * tui/tui-data.h (struct tui_gen_win_info)
4656 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4659 2019-06-25 Tom Tromey <tom@tromey.com>
4661 * tui/tui.c (tui_rl_other_window, tui_enable)
4662 (tui_is_window_visible, tui_get_command_dimension): Update.
4663 * tui/tui-winsource.c (tui_update_source_window_as_is)
4664 (tui_clear_source_content, tui_erase_source_content)
4665 (tui_show_source_line, tui_source_window_base::refill)
4666 (tui_source_window_base::do_scroll_horizontal)
4667 (tui_source_window_base::set_is_exec_point_at)
4668 (tui_update_breakpoint_info, tui_set_exec_info_content)
4669 (tui_alloc_source_buffer, tui_line_is_displayed)
4670 (tui_addr_is_displayed): Update.
4671 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4672 (tui_check_and_display_highlight_if_needed)
4673 (tui_win_info::make_visible, tui_win_info::refresh)
4674 (tui_refresh_all): Update.
4675 * tui/tui-windata.c (tui_first_data_item_displayed)
4676 (tui_delete_data_content_windows, tui_erase_data_content)
4677 (tui_display_all_data, tui_data_window::refresh_all)
4678 (tui_check_data_values): Update.
4679 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4680 (tui_set_win_focus_to, tui_win_info::forward_scroll)
4681 (tui_win_info::backward_scroll, tui_refresh_all_win)
4682 (tui_resize_all, tui_set_focus, tui_all_windows_info)
4683 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4684 (tui_source_window_base::set_new_height)
4685 (tui_data_window::set_new_height)
4686 (make_invisible_and_set_new_height)
4687 (make_visible_with_new_height, new_height_ok)
4688 (parse_scrolling_args): Update.
4689 * tui/tui-stack.c (tui_show_frame_info): Update.
4690 * tui/tui-source.c (tui_set_source_content)
4691 (tui_set_source_content_nil, tui_source_is_displayed)
4692 (tui_source_window::do_scroll_vertical): Update.
4693 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4694 (tui_display_registers_from, tui_display_reg_element_at_line)
4695 (tui_check_register_values, tui_reg_command): Update.
4696 * tui/tui-layout.c (tui_default_win_height)
4697 (show_source_disasm_command, show_data, init_and_make_win)
4698 (show_source_or_disasm_and_command): Update.
4699 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4700 (tui_redisplay_readline, tui_mld_flush)
4701 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4703 * tui/tui-disasm.c (tui_set_disassem_content)
4704 (tui_disasm_window::do_scroll_vertical): Update.
4705 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4707 (struct tui_win_info): Derive from tui_gen_win_info.
4708 <~tui_win_info>: Mark as override.
4709 <generic>: Remove member.
4710 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4711 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4712 (~tui_data_window, ~tui_win_info)
4713 (tui_free_all_source_wins_content): Update.
4714 * tui/tui-command.c (tui_refresh_cmd_win): Update.
4716 2019-06-25 Tom Tromey <tom@tromey.com>
4718 * tui/tui-layout.c (init_and_make_win): Use new.
4719 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4720 destructor, initializers.
4721 (tui_alloc_generic_win_info): Don't declare.
4722 * tui/tui-data.c (_locator): Add argument to constructor.
4723 (source_win, disasm_win): New globals.
4724 (exec_info): Remove.
4725 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4727 (tui_alloc_generic_win_info): Remove.
4728 (init_content_element): Use new.
4729 (tui_win_info::tui_win_info): Update.
4730 (free_content_elements) <case DATA_WIN>: Use delete.
4732 2019-06-25 Tom Tromey <tom@tromey.com>
4734 * tui/tui-wingeneral.c (tui_refresh_win): Update.
4735 * tui/tui-windata.c (tui_first_data_item_displayed)
4736 (tui_delete_data_content_windows): Update.
4737 * tui/tui-win.c (tui_data_window::set_new_height): Update.
4738 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4739 (tui_display_registers_from, tui_check_register_values): Update.
4740 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4742 * tui/tui-data.c (init_content_element): Update. Allocate the new
4744 (tui_free_data_content): Update.
4745 (free_content_elements) <case DATA_WIN>: Free the window.
4747 2019-06-25 Tom Tromey <tom@tromey.com>
4749 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4751 * tui/tui-layout.c (make_command_window)
4752 (show_source_disasm_command, show_data, init_and_make_win)
4753 (show_source_or_disasm_and_command): Update.
4754 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4756 <can_highight, is_highlighted>: Now bool.
4757 (tui_set_win_highlight): Don't declare.
4758 * tui/tui-data.c (tui_set_win_highlight): Remove.
4760 2019-06-25 Tom Tromey <tom@tromey.com>
4762 * tui/tui-wingeneral.c (make_visible): Remove check of window
4765 2019-06-25 Tom Tromey <tom@tromey.com>
4767 * tui/tui-win.c (tui_win_info::max_height)
4768 (tui_cmd_window::max_height): New methods.
4769 (new_height_ok): Call max_height.
4770 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4771 <max_height>: New method.
4773 2019-06-25 Tom Tromey <tom@tromey.com>
4775 * tui/tui-win.c (tui_source_window_base::set_new_height)
4776 (tui_data_window::set_new_height): New methods.
4777 (make_invisible_and_set_new_height): Call set_new_height method.
4778 * tui/tui-data.h (struct tui_win_info)
4779 (struct tui_source_window_base, struct tui_data_window)
4780 <set_new_height>: New method.
4782 2019-06-25 Tom Tromey <tom@tromey.com>
4784 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4785 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4786 tui_refresh_data_win.
4787 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4789 (tui_refresh_all_win): Call the refresh_all method.
4790 (tui_set_focus): Likewise.
4791 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4792 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4795 2019-06-25 Tom Tromey <tom@tromey.com>
4797 * tui/tui-winsource.h (tui_refill_source_window)
4798 (tui_set_is_exec_point_at): Don't declare.
4799 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4800 (tui_source_window_base::refill): Rename from
4801 tui_refill_source_window.
4802 (tui_source_window_base::do_scroll_horizontal): Update.
4803 (tui_source_window_base::set_is_exec_point_at): Rename from
4804 tui_set_is_exec_point_at.
4805 (tui_update_all_breakpoint_info): Update.
4806 * tui/tui-stack.c (tui_show_frame_info): Update.
4807 * tui/tui-layout.c (show_data): Add cast.
4808 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4809 * tui/tui-data.h (struct tui_source_window_base) <refill,
4810 set_is_exec_point_at>: New methods.
4811 (tui_source_windows, tui_add_to_source_windows): Update types.
4812 (tui_add_to_source_windows): Remove redundant declaration.
4813 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4814 (tui_source_windows): Change return type.
4815 (tui_clear_source_windows_detail): Update.
4816 (tui_add_to_source_windows): Change type of parameter.
4817 (tui_free_all_source_wins_content): Update.
4819 2019-06-25 Tom Tromey <tom@tromey.com>
4821 * tui/tui-wingeneral.c (tui_win_info::refresh)
4822 (tui_source_window_base::refresh): New methods.
4823 (tui_refresh_all): Call the refresh method.
4824 * tui/tui-data.h (struct tui_win_info)
4825 (struct tui_source_window_base) <refresh>: New method.
4827 2019-06-25 Tom Tromey <tom@tromey.com>
4829 * tui/tui.h (tui_is_window_visible): Return bool.
4830 * tui/tui.c (tui_is_window_visible): Return bool.
4831 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4832 (tui_make_visible, tui_make_invisible)
4833 (tui_win_info::make_visible)
4834 (tui_source_window_base::make_visible, make_all_visible)
4835 (tui_make_all_visible, tui_make_all_invisible): Update.
4836 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4837 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4839 (struct tui_win_info, struct tui_source_window_base)
4840 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4841 * tui/tui-data.c (tui_init_generic_part): Update.
4843 2019-06-25 Tom Tromey <tom@tromey.com>
4845 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4846 (tui_source_window_base::make_visible): New methods.
4847 (make_all_visible): Make method call.
4848 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4849 (struct tui_source_window_base, struct tui_cmd_window): Override
4851 (tui_win_is_source_type): Don't declare.
4852 * tui/tui-data.c (tui_win_is_source_type): Remove.
4854 2019-06-25 Tom Tromey <tom@tromey.com>
4856 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4859 2019-06-25 Tom Tromey <tom@tromey.com>
4861 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4862 Inline constructor. Add initializers for members.
4863 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4864 constructors; now inline in class.
4866 2019-06-25 Tom Tromey <tom@tromey.com>
4868 * tui/tui-regs.c (tui_show_registers): Update.
4869 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4871 * tui/tui-data.c (tui_data_window::clear_detail)
4872 (tui_data_window): Update.
4874 2019-06-25 Tom Tromey <tom@tromey.com>
4876 * tui/tui-windata.c (tui_display_all_data)
4877 (tui_display_data_from_line, tui_display_data_from)
4878 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4880 * tui/tui-regs.c (tui_last_regs_line_no)
4881 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4882 (tui_show_registers, tui_show_register_group)
4883 (tui_display_registers_from, tui_display_reg_element_at_line)
4884 (tui_display_registers_from_line, tui_check_register_values)
4885 (tui_reg_next, tui_reg_prev): Update.
4886 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4887 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4889 (struct tui_win_info) <detail>: Remove. Add new fields from
4891 (TUI_DATA_WIN): Add cast.
4892 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4893 (~tui_data_window): Simplify.
4895 2019-06-25 Tom Tromey <tom@tromey.com>
4897 * tui/tui-layout.c (show_source_disasm_command)
4898 (show_source_or_disasm_and_command): Update.
4899 * tui/tui-io.c (update_cmdwin_start_line)
4900 (tui_redisplay_readline): Update.
4901 * tui/tui-data.h (struct tui_command_info): Remove.
4902 (struct tui_win_info) <detail>: Remove command_info member.
4903 (struct tui_data_window) <start_line>: New member, from
4905 (TUI_CMD_WIN): Add casts.
4907 2019-06-25 Tom Tromey <tom@tromey.com>
4909 * tui/tui-winsource.c (tui_update_source_window)
4910 (tui_refill_source_window)
4911 (tui_source_window_base::do_scroll_horizontal)
4912 (tui_update_breakpoint_info, tui_set_exec_info_content)
4913 (tui_show_exec_info_content, tui_erase_exec_info_content)
4914 (tui_clear_exec_info_content): Update.
4915 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4917 * tui/tui-win.c (make_invisible_and_set_new_height)
4918 (make_visible_with_new_height): Update.
4919 * tui/tui-source.c (tui_set_source_content)
4920 (tui_show_symtab_source): Update.
4921 * tui/tui-layout.c (extract_display_start_addr)
4922 (show_source_disasm_command, show_data)
4923 (make_source_or_disasm_window)
4924 (show_source_or_disasm_and_command): Update.
4925 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4926 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4928 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4929 to tui_source_window_base.
4930 (struct tui_win_info) <detail>: Remove source_info member.
4931 (struct tui_source_window_base) <has_locator>: Inline.
4932 Move contents from tui_source_info; rename has_locator member to
4934 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4935 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4937 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4939 (tui_free_all_source_wins_content): Cast to
4940 tui_source_window_base.
4942 2019-06-25 Tom Tromey <tom@tromey.com>
4944 * tui/tui-win.c (make_invisible_and_set_new_height)
4945 (make_visible_with_new_height): Call has_locator method.
4946 * tui/tui-layout.c (show_source_disasm_command, show_data)
4947 (show_source_or_disasm_and_command): Update for bool change.
4948 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4949 (tui_win_info) <has_locator>: New method.
4950 (struct tui_source_window_base) <has_locator>: New method.
4951 (tui_win_has_locator): Don't declare.
4952 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4953 from tui_win_has_locator.
4954 (tui_source_window_base): Use false, not FALSE.
4956 2019-06-25 Tom Tromey <tom@tromey.com>
4958 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4959 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4960 clear_detail method directly.
4961 (tui_clear_win_detail): Remove.
4963 2019-06-25 Tom Tromey <tom@tromey.com>
4965 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4966 "this", not TUI_DISASM_WIN.
4968 2019-06-25 Tom Tromey <tom@tromey.com>
4970 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4972 * tui/tui-winsource.c
4973 (tui_source_window_base::do_scroll_horizontal): Rename from
4974 tui_horizontal_source_scroll.
4975 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4976 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4977 from tui_vertical_data_scroll.
4978 * tui/tui-win.h (tui_scroll): Don't declare.
4979 * tui/tui-win.c (tui_win_info::forward_scroll)
4980 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4981 (tui_win_info::right_scroll): Rename and update.
4982 (tui_scroll_forward_command, tui_scroll_backward_command)
4983 (tui_scroll_left_command, tui_scroll_right_command): Update.
4984 (tui_scroll): Remove.
4985 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4986 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4987 from tui_vertical_source_scroll.
4988 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4989 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4990 from tui_vertical_disassem_scroll.
4991 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4992 do_scroll_horizontal>: New methods.
4993 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4995 (struct tui_source_window_base): Add do_scroll_horizontal.
4996 (struct tui_source_window, struct tui_disasm_window): Add
4998 (struct tui_data_window, struct tui_cmd_window): Add
4999 do_scroll_horizontal and do_scroll_vertical.
5000 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5002 2019-06-25 Tom Tromey <tom@tromey.com>
5004 * tui/tui-data.h (struct tui_source_window_base): New struct.
5005 (struct tui_source_window): Derive from tui_source_window_base.
5006 (struct tui_disasm_window): New struct.
5007 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5008 from tui_source_window::clear_detail.
5009 (tui_source_window_base): Rename from tui_source_window.
5010 (~tui_source_window_base): Rename from ~tui_source_window.
5011 (tui_alloc_win_info): Create a tui_disasm_window.
5013 2019-06-25 Tom Tromey <tom@tromey.com>
5015 * tui/tui-data.h (struct tui_source_window)
5016 (struct tui_data_window): Declare destructors.
5017 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5019 (tui_win_info): Simplify.
5021 2019-06-25 Tom Tromey <tom@tromey.com>
5023 * tui/tui-winsource.c (tui_display_main)
5024 (tui_update_source_windows_with_addr)
5025 (tui_update_all_breakpoint_info): Update.
5026 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5027 (new_height_ok, parse_scrolling_args): Update.
5028 * tui/tui-stack.c (tui_show_frame_info): Update.
5029 * tui/tui-data.h (struct tui_list): Remove.
5030 (tui_source_windows): Return a reference to a std::vector.
5031 * tui/tui-data.c (source_windows): Now a std::vector.
5032 (tui_source_windows): Change return type.
5033 (tui_clear_source_windows): Rewrite.
5034 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5035 (tui_free_all_source_wins_content): Rewrite.
5037 2019-06-25 Tom Tromey <tom@tromey.com>
5039 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5040 (struct tui_data_window, struct tui_cmd_window): Declare
5041 clear_detail method.
5042 * tui/tui-data.c (tui_source_window::clear_detail)
5043 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5045 (tui_clear_win_detail): Simplify.
5047 2019-06-25 Tom Tromey <tom@tromey.com>
5049 * tui/tui-layout.c (make_source_window, make_disasm_window)
5050 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5051 Return the new window.
5052 (show_source_disasm_command, show_data)
5053 (show_source_or_disasm_and_command): Update.
5055 2019-06-25 Tom Tromey <tom@tromey.com>
5057 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5058 parameter. Return the new window.
5059 (show_source_disasm_command): Update and remove NULL check.
5060 (show_source_or_disasm_and_command): Update.
5062 2019-06-25 Tom Tromey <tom@tromey.com>
5064 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5066 2019-06-25 Tom Tromey <tom@tromey.com>
5068 * tui/tui-data.h (struct tui_win_info): Make constructor
5069 protected. Make destructor virtual. Add initializers.
5070 (tui_source_window, tui_data_window, tui_cmd_window): New
5072 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5073 constructor. Add "type" parameter.
5074 (tui_source_window, tui_data_window, tui_cmd_window): New
5076 (tui_alloc_win_info): Instantiate the appropriate subclass.
5078 2019-06-25 Tom Tromey <tom@tromey.com>
5080 * tui/tui-win.c (tui_resize_all): Use delete.
5081 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5083 (tui_free_window): Don't declare.
5084 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5087 2019-06-25 Tom Tromey <tom@tromey.com>
5089 * tui/tui-data.h (struct tui_win_info): Add constructor.
5090 * tui/tui-data.c (tui_alloc_win_info): Use new.
5091 (tui_free_window): Use delete.
5093 2019-06-22 Tom Tromey <tom@tromey.com>
5095 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5097 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5099 2019-06-22 Tom Tromey <tom@tromey.com>
5101 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5103 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5105 2019-06-22 Tom de Vries <tdevries@suse.de>
5107 * dwarf2read.c (create_addrmap_from_aranges)
5108 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5111 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
5113 * dwarf2read.h (dwarf2_section_info_def): Remove.
5114 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5115 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5116 std::vector<dwarf2_section_info>.
5117 (struct dwo_file) <~dwo_file>: Remove.
5118 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5120 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5121 (dwarf2_read_debug_names): Likewise.
5122 (create_debug_types_hash_table): Change parameter type to
5123 array_view, adjust code accordingly.
5124 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5125 (partial_die_info::fixup): Likewise.
5126 (determine_prefix): Likewise.
5127 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5129 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5131 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5133 <~dwo_file>: Remove call to gdb_bfd_unref.
5134 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5135 gdb_bfd_ref_ptr::get.
5137 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5139 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5141 * dwarf2read.c (struct dwo_file): Initialize fields.
5143 (free_dwo_file): Remove, move content to ~dwo_file.
5144 (struct dwo_file_deleter): Remove.
5145 (dwo_file_up>: Remove custom deleter.
5146 (free_dwo_files): Remove.
5147 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5149 (process_skeletonless_type_units): Call unique_ptr::get.
5150 (allocate_dwo_file_hash_table): Add deleter to created hash
5151 table. Change return type to htab_up.
5152 (lookup_dwo_file_slot): Don't memset dwo_file, call
5154 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5155 (create_dwo_unit_in_dwp_v2): Likewise.
5156 (open_and_init_dwo_file): Likewise.
5157 (free_dwo_file_from_slot): Remove.
5159 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5161 * dwarf2read.h (struct dwarf2_section_info) <readin,
5162 is_virtual>: Change type to bool.
5163 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5166 2019-06-19 Tom Tromey <tom@tromey.com>
5168 * tui/tui-data.h (tui_init_content_element): Don't declare.
5170 2019-06-19 Tom Tromey <tom@tromey.com>
5172 * tui/tui-data.h (tui_init_win_info): Don't declare.
5174 2019-06-19 Tom de Vries <tdevries@suse.de>
5176 * dwarf2read.h (abstract_to_concrete): Change type to
5177 std::unordered_map<sect_offset, std::vector<sect_offset>,
5178 gdb::hash_enum<sect_offset>>.
5180 2019-06-19 Tom Tromey <tromey@adacore.com>
5182 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5183 EVAL_AVOID_SIDE_EFFECTS specially.
5185 2019-06-19 Tom Tromey <tromey@adacore.com>
5187 * source-cache.c (highlighter): New global.
5188 (source_cache::get_source_lines): Create a highlighter on demand.
5190 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5192 * defs.h (deprecated_interactive_hook): Delete declaration.
5193 * interps.c (clear_interpreter_hooks): Remove use of
5194 deprecated_interactive_hook.
5195 * top.c (deprecated_interactive_hook): Delete definition.
5196 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5198 2019-06-18 Tom de Vries <tdevries@suse.de>
5201 * dwarf2read.h (abstract_to_concrete): Change type from
5202 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5203 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5204 * dwarf2read.c (read_variable): Update.
5205 (dwarf2_fetch_die_loc_sect_off): Update.
5207 2019-06-17 Tom de Vries <tdevries@suse.de>
5210 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5211 accessing parent[parent_len - 1].
5213 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5216 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5217 call dtrace_process_dof with NULL dof.
5219 2019-06-16 Tom de Vries <tdevries@suse.de>
5222 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5224 2019-06-16 Tom Tromey <tom@tromey.com>
5226 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5227 (make_all_visible): Use address of member.
5229 2019-06-16 Tom Tromey <tom@tromey.com>
5231 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5232 (tui_free_window, free_content, free_content_elements): Remove
5234 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5236 * tui/tui-regs.c (tui_show_register_group)
5237 (tui_display_registers_from, tui_display_reg_element_at_line):
5238 Remove unnecessary cast.
5240 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5242 * linux-nat.c (normal_mask): Delete.
5243 (_initialize_linux_nat): Don't initialise normal_mask.
5245 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5248 * dwarf-index-write.h (write_psymtabs_to_index): Add
5249 dwz_basename parameter.
5250 * dwarf-index-write.c (write_gdbindex): Move file writing to
5251 write_gdbindex_1. Change return type void.
5252 (assert_file_size): Move up, remove filename parameter.
5253 (write_gdbindex_1): New function.
5254 (write_debug_names): Change return type to void, call
5256 (struct index_wip_file): New struct.
5257 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5258 file logic to index_wip_file. Write index for dwz file if
5260 (save_gdb_index_command): Pass basename of dwz file, if present.
5261 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5262 build-id of dwz file, if present.
5263 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5264 (dwarf2_get_dwz_file): Likewise.
5265 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5266 (dwarf2_get_dwz_file): Likewise.
5268 2019-06-16 Tom Tromey <tom@tromey.com>
5270 * coffread.c (process_coff_symbol): Use xstrdup.
5271 * value.c (create_internalvar): Use xstrdup.
5273 2019-06-16 Tom Tromey <tom@tromey.com>
5275 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5276 * breakpoint.c (stopin_command, stopat_command)
5277 (until_break_command, decode_location_default): Remove unnecessary
5279 * utils.c (subset_compare): Remove unnecessary cast.
5280 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5282 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5284 * infcmd.c (path_command): Remove unnecessary cast.
5285 * coffread.c (decode_type): Remove unnecessary cast.
5286 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5287 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5288 * tui/tui-stack.c (tui_show_locator_content)
5289 (tui_show_frame_info): Remove unnecessary cast.
5290 * tui/tui-win.c (tui_scroll_forward_command)
5291 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5292 (parse_scrolling_args): Remove unnecessary cast.
5293 * tui/tui-data.c (init_win_info, tui_del_window)
5294 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5295 (free_content_elements): Remove unnecessary cast.
5296 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5298 * tui/tui-source.c (tui_set_source_content)
5299 (tui_vertical_source_scroll): Remove unnecessary cast.
5300 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5302 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5303 * tui/tui-regs.c (tui_display_registers_from)
5304 (tui_display_register): Remove unnecessary cast.
5305 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5306 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5307 (make_visible): Remove unnecessary cast.
5308 * tui/tui-winsource.c (tui_erase_source_content)
5309 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5311 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5312 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5313 * stabsread.c (read_type, read_array_type, read_range_type):
5314 Remove unnecessary cast.
5315 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5316 (parse_symbol, parse_type, upgrade_type, parse_external)
5317 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5319 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5321 2019-06-16 Tom Tromey <tom@tromey.com>
5323 * tui/tui-data.c (tui_alloc_generic_win_info)
5324 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5327 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5328 Andrew Burgess <andrew.burgess@embecosm.com>
5330 * f-typeprint.c (f_print_type): Don't return early for not
5331 associated or not allocated types.
5332 (f_type_print_varspec_suffix): Add print_rank parameter and print
5333 ranks of array types in case they dangling.
5334 (f_type_print_base): Add print_rank parameter.
5336 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5338 * NEWS: Mention new MI commands.
5339 * break-catch-throw.c (enum exception_event_kind): Move to
5341 (print_mention_exception_catchpoint): Output text as a single
5343 (catch_exception_command_1): Rename to...
5344 (catch_exception_event): ...this, make non-static, update header
5345 command, and change some parameter types.
5346 (catch_catch_command): Update for changes to
5347 catch_exception_command_1.
5348 (catch_throw_command): Likewise.
5349 (catch_rethrow_command): Likewise.
5350 * breakpoint.c (enum exception_event_kind): Delete.
5351 * breakpoint.h (enum exception_event_kind): Moved here from
5352 break-catch-throw.c.
5353 (catch_exception_event): Declare.
5354 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5355 (mi_cmd_catch_throw): New function.
5356 (mi_cmd_catch_rethrow): New function.
5357 (mi_cmd_catch_catch): New function.
5358 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5359 'catch-catch' entries.
5360 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5361 (mi_cmd_catch_rethrow): Declare.
5362 (mi_cmd_catch_catch): Declare.
5364 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5366 * annotate.c (annotate_source_line): Change return type to void,
5367 update implementation to match.
5368 * annotate.h (annotate_source_line): Change return type to void,
5369 update header comment.
5370 * stack.c (print_frame_info): Don't change what frame information
5371 is printed based on whether annotations are on or not.
5373 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5375 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5376 (annotate_source): Make static.
5377 (annotate_source_line): Moved from source.c and renamed from
5378 identify_source_line. Update the return type.
5379 * annotate.h (annotate_source): Delete declaration.
5380 (annotate_source_line): Declaration moved from source.h, and
5381 renamed from identify_source_line. Return type updated.
5382 * source.c (identify_source_line): Moved to annotate.c and renamed
5383 to annotate_source_line.
5384 (info_line_command): Remove check of annotation_level.
5385 * source.h (identify_source_line): Move declaration to annotate.h
5386 and rename to annotate_source_line.
5387 * stack.c: Add 'annotate.h' include.
5388 (print_frame_info): Remove check of annotation_level before
5389 calling annotate_source_line.
5391 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5393 * source-cache.c (source_cache::get_plain_source_lines): Use
5394 open_source_file_with_line_charpos instead of just
5395 open_source_file, remove call to find_source_lines.
5396 (source_cache::get_source_lines): Likewise.
5397 * source.c (find_source_lines): Make static.
5398 (get_filename_and_charpos): Renamed into...
5399 (open_source_file_with_line_charpos): ..this along with changes to
5400 return a scoped_fd, and some other minor clean ups.
5401 (identify_source_line): Use open_source_file_with_line_charpos.
5402 (search_command_helper): Use open_source_file_with_line_charpos
5403 instead of just open_source_file, remove call to
5405 * source.h (open_source_file_with_line_charpos): Declare new
5407 (find_source_lines): Delete declaration.
5409 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5411 * source.c (get_filename_and_charpos): Remove fullname
5413 (identify_source_line): Update call to get_filename_and_charpos.
5415 2019-06-14 Tom Tromey <tromey@adacore.com>
5418 * ui-style.h (skip_ansi_escape): Update comment.
5419 * ui-file.h (class no_terminal_escape_file): New class.
5420 * ui-file.c (no_terminal_escape_file::write)
5421 (no_terminal_escape_file::puts): New methods.
5422 * cli/cli-logging.c (handle_redirections): Use
5423 no_terminal_escape_file.
5425 2019-06-14 Tom Tromey <tromey@adacore.com>
5427 * NEWS: Move convenience variable news above Python news.
5429 2019-06-14 Tom Tromey <tom@tromey.com>
5431 * gnulib: Move directory to top-level.
5432 * configure.ac: Don't configure gnulib.
5433 * configure: Rebuild.
5434 * common/common-defs.h: Use new path to gnulib.
5435 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5437 (INCGNU): Look in new gnulib location.
5438 (HFILES_NO_SRCDIR): Remove gnulib files.
5439 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5440 (generated_files): Remove GNULIB_H.
5441 ($(LIBGNU), all-lib): Remove targets.
5442 (distclean): Don't mention GNULIB_BUILDDIR.
5443 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5445 2019-06-14 Tom Tromey <tromey@adacore.com>
5447 * symfile.c (add_symbol_file_command): Remove obsolete comment.
5448 Warn if symbol file does not provide any symbols.
5450 2019-06-14 Tom Tromey <tromey@adacore.com>
5452 * source.c (find_and_open_source): Respect basenames_may_differ.
5454 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
5456 * annotate.c (annotate_breakpoints_invalid): Make use of
5457 scoped_restore_terminal_state.
5458 (annotate_frames_invalid): Likewise.
5460 2019-06-14 Tom Tromey <tromey@adacore.com>
5462 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5463 allow assignment to an internalvar.
5465 2019-06-14 Tom Tromey <tromey@adacore.com>
5467 * ada-lex.l: Allow "_" in attribute names.
5469 2019-06-14 Tom Tromey <tromey@adacore.com>
5472 * regcache.c (registers_changed): Don't call alloca.
5473 * top.c (execute_command): Don't call alloca.
5475 2019-06-13 Pedro Alves <palves@redhat.com>
5477 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5478 'expression'. When parsing an expression, error out if there's
5479 junk after "unlimited".
5480 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5481 (do_set_command): Adjust calls to is_unlimited_literal.
5483 2019-06-13 Pedro Alves <palves@redhat.com>
5485 * compile/compile.c (make_compile_options_def_group): Add braces
5486 around array_view initializer.
5487 * thread.c (make_thread_apply_all_options_def_group)
5488 (make_thread_apply_all_options_def_group): Likewise.
5490 2019-06-13 Pedro Alves <palves@redhat.com>
5492 * NEWS (New commands): Mention "maint test-options
5493 require-delimiter", "maint test-options unknown-is-error", "maint
5494 test-options unknown-is-operand" and "maint show
5495 test-options-completion-result".
5496 (New command options, command completion): New section.
5497 (Completion improvements): New section.
5498 Mention that you can abbreviate "unlimited".
5500 2019-06-13 Pedro Alves <palves@redhat.com>
5502 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5503 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5504 * unittests/cli-utils-selftests.c (test_parse_flags)
5505 (test_parse_flags_qcs): Delete.
5506 (test_cli_utils): Don't call deleted functions.
5508 2019-06-13 Pedro Alves <palves@redhat.com>
5510 * thread.c: Include "cli/cli-option.h".
5511 (tp_array_compar_ascending): Global.
5512 (tp_array_compar): Delete function.
5513 (tp_array_compar_ascending, tp_array_compar_descending): New
5515 (ascending_option_def, qcs_flag_option_def)
5516 (thr_qcs_flags_option_defs)
5517 (make_thread_apply_all_options_def_group)
5518 (make_thread_apply_options_def_group): New.
5519 (thread_apply_all_command): Use gdb::option::process_options.
5520 (thread_apply_command_completer)
5521 (thread_apply_all_command_completer): New.
5522 (thread_apply_command): Use gdb::option::process_options.
5523 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5524 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
5525 to generate help text of "thread apply". Adjust "taas"'s help.
5526 * tid-parse.c (tid_range_parser::in_thread_range): New method.
5527 * tid-parse.h (tid_range_parser::in_thread_range): New method.
5529 2019-06-13 Pedro Alves <palves@redhat.com>
5531 * thread.c (thread_apply_command): Check for invalid TID with
5532 isdigit instead of !isalpha.
5534 2019-06-13 Pedro Alves <palves@redhat.com>
5536 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5537 (validate_flags_qcs): New.
5538 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5539 (validate_flags_qcs): Declare.
5540 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5541 (make_frame_apply_options_def_group): New.
5542 (frame_apply_command_count): Process options with
5543 gdb::option::process_options.
5544 (frame_apply_completer): New.
5545 (frame_apply_level_completer, frame_apply_all_completer)
5546 (frame_apply_completer): New.
5547 (_initialize_stack): Update help of "frame apply", "frame apply
5548 level", "frame apply all" and "faas" to mention supported options
5549 and install command completers.
5550 * stack.h (frame_apply_all_completer): Declare.
5551 * thread.c: Include "stack.h".
5552 (tfaas_command): Add "--".
5553 (_initialize_thread): Update help "tfaas" to mention supported
5554 options and install command completer.
5556 2019-06-13 Pedro Alves <palves@redhat.com>
5558 * completer.c (complete_nested_command_line): New.
5559 (gdb_completion_word_break_characters_throw): Add assertion.
5560 * completer.h (complete_nested_command_line): Declare.
5562 2019-06-13 Pedro Alves <palves@redhat.com>
5564 * stack.c (parse_backtrace_qualifiers): New.
5565 (backtrace_command): Use it.
5566 (backtrace_command_completer): Complete on qualifiers.
5568 2019-06-13 Pedro Alves <palves@redhat.com>
5570 * frame.c: Include "cli/cli-option.h.
5571 (user_set_backtrace_options): New.
5572 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5574 (get_prev_frame): Adjust.
5575 (boolean_option_def, uinteger_option_def)
5576 (set_backtrace_option_defs): New.
5577 (_initialize_frame): Adjust and use
5578 gdb::option::add_setshow_cmds_for_options to install "set
5579 backtrace past-main" and "set backtrace past-entry".
5580 * frame.h: Include "cli/cli-option.h".
5581 (struct frame_print_options): Forward declare.
5582 (print_frame_arguments_all, print_frame_arguments_scalars)
5583 (print_frame_arguments_none): Declare.
5584 (print_entry_values): Delete declaration.
5585 (struct frame_print_options, user_frame_print_options): New.
5586 (struct set_backtrace_options): New.
5587 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5588 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5589 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5590 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5591 (list_args_or_locals): Add frame_print_options parameter.
5592 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5593 * python/py-framefilter.c (enumerate_args): Pass down
5594 USER_FRAME_PRINT_OPTIONS.
5595 * stack.c: Include "cli/cli-option.h".
5596 (print_frame_arguments_all, print_frame_arguments_scalars)
5597 (print_frame_arguments_none): Declare.
5598 (print_raw_frame_arguments, print_entry_values): Delete.
5599 (user_frame_print_options): New.
5600 (boolean_option_def, enum_option_def, frame_print_option_defs):
5602 (struct backtrace_cmd_options): New.
5603 (bt_flag_option_def): New.
5604 (backtrace_command_option_defs): New.
5605 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5606 (print_frame_arg, read_frame_arg, print_frame_args)
5607 (print_frame_info, print_frame): Add frame_print_options parameter
5609 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5610 (backtrace_command_1): Add frame_print_options and
5611 backtrace_cmd_options parameters and use them.
5612 (make_backtrace_options_def_group): New.
5613 (backtrace_command): Process command options with
5614 gdb::option::process_options.
5615 (backtrace_command_completer): New.
5616 (_initialize_stack): Extend "backtrace"'s help to mention
5617 supported options. Install completer for "backtrace".
5618 Install some settings commands with add_setshow_cmds_for_options.
5620 2019-06-13 Pedro Alves <palves@redhat.com>
5622 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5623 and that "set/show print raw frame-arguments" are now deprecated.
5625 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5627 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5628 * stack.c (_initialize_stack): Install "set/show print
5629 raw-frame-arguments", and deprecate "set/show print raw
5631 * valprint.c (_initialize_valprint): Deprecate "set/show print
5634 2019-06-13 Pedro Alves <palves@redhat.com>
5636 * compile/compile.c (struct compile_options): New.
5637 (compile_flag_option_def, compile_command_option_defs)
5638 (make_compile_options_def_group): New.
5639 (compile_file_command): Handle options with
5640 gdb::option::process_options.
5641 (compile_file_command_completer): New function.
5642 (compile_code_command): Handle options with
5643 gdb::option::process_options.
5644 (compile_code_command_completer): New function.
5645 (_initialize_compiler): Install completers for "compile code" and
5646 "compile file". Mention available options in "compile code" and
5647 "compile code"'s help.
5648 * completer.c (advance_to_completion_word): New, factored out from
5650 (advance_to_expression_complete_word_point): ... this.
5651 (advance_to_filename_complete_word_point): New.
5652 * completer.h (advance_to_filename_complete_word_point): New
5655 2019-06-13 Pedro Alves <palves@redhat.com>
5657 * compile/compile.c: Include "cli/cli-option.h".
5658 (compile_print_value): Scope data pointer is now a
5659 value_print_options pointer; adjust.
5660 (compile_print_command): Process options. Scope data pointer is
5661 now a value_print_options pointer; adjust.
5662 (_initialize_compile): Update "compile print"'s help to include
5663 supported options. Install a completer for "compile print".
5664 * cp-valprint.c (show_vtblprint, show_objectprint)
5665 (show_static_field_print): Delete.
5666 (_initialize_cp_valprint): Don't install "set print
5667 static-members", "set print vtbl", "set print object" here.
5668 * printcmd.c: Include "cli/cli-option.h" and
5669 "common/gdb_optional.h".
5670 (print_command_parse_format): Rework to fill in a
5671 value_print_options instead of a format_data.
5672 (print_value): Change parameter type from format_data pointer to
5673 value_print_options reference. Adjust.
5674 (print_command_1): Process options. Adjust to pass down a
5675 value_print_options.
5676 (print_command_completer): New.
5677 (_initialize_printcmd): Install print_command_completer as
5678 handle_brkchars completer for the "print" command. Update
5679 "print"'s help to include supported options.
5680 * valprint.c: Include "cli/cli-option.h".
5681 (show_vtblprint, show_objectprint, show_static_field_print): Moved
5682 here from cp-valprint.c.
5683 (boolean_option_def, uinteger_option_def)
5684 (value_print_option_defs, make_value_print_options_def_group):
5685 New. Use gdb::option::add_setshow_cmds_for_options to install
5686 "set print elements", "set print null-stop", "set print repeats",
5687 "set print pretty", "set print union", "set print array", "set
5688 print address", "set print symbol", "set print array-indexes".
5689 * valprint.h: Include <string> and "cli/cli-option.h".
5690 (make_value_print_options_def_group): Declare.
5691 (print_value): Change parameter type from format_data pointer to
5692 value_print_options reference.
5693 (print_command_completer): Declare.
5695 2019-06-13 Pedro Alves <palves@redhat.com>
5697 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5698 (COMMON_SFILES): Add maint-test-settings.c.
5699 * cli/cli-decode.c (boolean_enums): New global, factored out from
5701 (add_setshow_boolean_cmd): ... here.
5702 * cli/cli-decode.h (boolean_enums): Declare.
5703 * cli/cli-option.c: New file.
5704 * cli/cli-option.h: New file.
5705 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5706 factored out from ...
5707 (parse_cli_boolean_value(const char *)): ... this.
5708 (is_unlimited_literal): Change parameter type to pointer to
5709 pointer. Adjust and advance ARG pointer.
5710 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5711 (parse_cli_var_enum): New, factored out from ...
5712 (do_set_command): ... this. Adjust.
5713 * cli/cli-setshow.h (parse_cli_boolean_value)
5714 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5715 (parse_cli_var_enum): Declare.
5716 * cli/cli-utils.c: Include "cli/cli-option.h".
5717 (get_ulongest): New.
5718 * cli/cli-utils.h (get_ulongest): Declare.
5719 (check_for_argument): New overloads.
5720 * maint-test-options.c: New file.
5722 2019-06-13 Pedro Alves <palves@redhat.com>
5724 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5725 parse a range if "-" is at the end of the string.
5727 2019-06-13 Pedro Alves <palves@redhat.com>
5729 * cli/cli-setshow.c (parse_auto_binary_operation)
5730 (parse_cli_boolean_value): Don't allow "o".
5732 2019-06-13 Pedro Alves <palves@redhat.com>
5734 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5735 * NEWS: Mention maint test-settings KIND.
5736 * maint-test-settings.c: New file.
5738 2019-06-13 Pedro Alves <palves@redhat.com>
5740 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5742 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5745 2019-06-13 Pedro Alves <palves@redhat.com>
5747 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5750 2019-06-13 Pedro Alves <palves@redhat.com>
5752 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5754 2019-06-13 Pedro Alves <palves@redhat.com>
5756 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5757 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5759 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5760 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5762 (check_for_argument): Skip spaces after argument.
5764 2019-06-13 Pedro Alves <palves@redhat.com>
5766 * thread.c (thread_apply_command): Adjust TID parsing.
5767 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5768 detected before end of string.
5769 (tid_is_in_list): Error out if LIST is invalid.
5771 2019-06-13 Pedro Alves <palves@redhat.com>
5773 * completer.c (complete_line_internal_1): Rewind completion word
5775 (completion_tracker::advance_custom_word_point_by): Change
5776 parameter type to int.
5777 * completer.h (completion_tracker::advance_custom_word_point_by):
5780 2019-06-13 Pedro Alves <palves@redhat.com>
5782 * completer.c (advance_to_completion_word): Handle delimiters.
5784 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5786 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5788 2019-06-11 Tom Tromey <tom@tromey.com>
5790 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5791 (xmalloc_failed): Move to alloc.c.
5792 * alloc.c: New file.
5793 * Makefile.in (COMMON_SFILES): Add alloc.c.
5795 2019-06-11 Tom Tromey <tom@tromey.com>
5797 * nat/linux-waitpid.c: Don't include server.h.
5798 (linux_debug): Remove.
5799 (my_waitpid): Update.
5801 2019-06-11 Tom Tromey <tromey@adacore.com>
5803 * infcall.c (_initialize_infcall): Remove trailing newline from
5805 * user-regs.c (_initialize_user_regs): Remove trailing newline
5807 * typeprint.c (_initialize_typeprint): Remove trailing newline
5809 * reverse.c (_initialize_reverse): Remove trailing newlines from
5811 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5813 * language.c (add_set_language_command): Remove trailing newline
5815 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5817 * disasm.c (_initialize_disasm): Remove trailing newline from
5819 * top.c (init_main): Remove trailing newline from help.
5820 * interps.c (_initialize_interpreter): Remove trailing newline
5822 * btrace.c (_initialize_btrace): Remove trailing newlines from
5824 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5826 * python/python.c (_initialize_python): Remove trailing newline
5828 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5830 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5831 from help. Reformat some text.
5832 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5834 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5837 2019-06-11 Tom Tromey <tromey@adacore.com>
5839 * darwin-nat.c (darwin_decode_exception_message)
5840 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5842 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5844 * valops.c (value_slice): Check for not allocated or not
5847 2019-06-10 Tom de Vries <tdevries@suse.de>
5850 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5851 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5854 2019-06-10 Tom de Vries <tdevries@suse.de>
5857 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5858 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5860 2019-06-10 Tom de Vries <tdevries@suse.de>
5863 * symtab.c (struct demangled_name_entry): Add language field.
5864 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5865 static minimal symbol". Set and use language field.
5867 2019-06-10 Tom Tromey <tromey@adacore.com>
5869 * ada-lang.c (_initialize_ada_language): Update help text.
5871 2019-06-10 Tom Tromey <tromey@adacore.com>
5873 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5875 * guile/guile.c (handle_boot_error): Don't end warning with a
5877 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5878 warning with a newline.
5879 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5881 (s12z_frame_cache): Likewise.
5882 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5884 * solib-svr4.c (disable_probes_interface): Don't end warning with
5886 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5888 * python/python.c (do_finish_initialization): Don't end warning
5891 2019-06-10 Tom Tromey <tom@tromey.com>
5893 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5894 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5897 2019-06-10 Tom Tromey <tromey@adacore.com>
5899 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5901 (elf_new_init): Don't call stabsread_new_init.
5902 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5903 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5904 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5906 2019-06-10 Tom de Vries <tdevries@suse.de>
5910 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5912 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5914 * source.c (find_and_open_source): Also rewrite relative file
5917 2019-04-26 Amos Bird <amosbird@gmail.com>
5919 * annotate.c (annotate_thread_exited): Add "thread-exited"
5922 2019-06-06 Tom Tromey <tromey@adacore.com>
5924 * maint.h (class scoped_command_stats): Use
5925 DISABLE_COPY_AND_ASSIGN.
5926 <print_time>: New method.
5927 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5929 (scoped_command_stats::print_time): New method.
5931 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5933 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5934 instructions of lengths 6 or 8 bytes.
5936 2019-06-04 Pedro Alves <palves@redhat.com>
5938 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5940 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5941 * breakpoint.c (condition_completer): Likewise.
5942 * cli/cli-dump.c (scan_expression): Likewise.
5943 * common/filestuff.c (mkdir_recursive): Likewise.
5944 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5945 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5946 (gdb_abspath): Likewise.
5947 * compile/compile-cplus-types.c
5948 (compile_cplus_instance::decl_name): Likewise.
5949 * completer.c (complete_explicit_location):
5950 (signal_completer, reg_or_group_completer_1): Likewise.
5951 * cp-support.c (cp_remove_params_if_any): Likewise.
5952 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5953 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5954 * infcmd.c (strip_bg_char): Likewise.
5955 * linespec.c (copy_token_string): Likewise.
5956 * mi/mi-main.c (output_cores): Likewise.
5957 * psymtab.c (psymtab_search_name):
5958 * symfile.c (test_set_ext_lang_command): Likewise.
5959 * target.c (target_fileio_read_stralloc): Likewise.
5960 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5961 * value.c (complete_internalvar): Likewise.
5963 2019-06-04 Christian Biesinger <cbiesinger@google.com>
5965 Add objfile property to gdb.Type.
5966 * NEWS: Mention Python API addition.
5967 * python/py-type.c (typy_get_objfile): New method.
5969 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5971 * NEWS: Mention the new set|show style [title|highlight].
5972 Mention changes to "show style", "help" and "apropos".
5974 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5976 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5977 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5978 instead of print_help_for_command.
5979 (print_doc_of_command): New function.
5980 (help_list): Add 'apropos -v word' suggestion.
5981 (print_help_for_command): Style the command name using title style.
5982 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5983 (_initialize_cli_cmds): Describe -v in apropos_command help.
5985 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5987 * cli/cli-style.h (cli_style_option): Add name in constructor,
5988 add m_name class member, add constructor with intensity,
5989 add name class function.
5990 (cli_style_option::add_setshow_commands): Remove name argument.
5991 (highlight_style, title_style): New styles.
5992 * cli/cli-style.c (do_show): New function that shows a style
5993 characteristic styling the style name with itself.
5994 (set_style_name): New function.
5995 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5996 Update all callers according to the changes in cli/cli-style.h.
5997 * utils.h (fputs_highlighted): New function.
5998 * utils.c (fputs_highlighted): Likewise.
6000 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6002 * NEWS: Mention new pipe command and new convenience variables.
6004 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6006 * cli/cli-cmds.c (pipe_command): New function.
6007 (_initialize_cli_cmds): Call add_com for pipe_command.
6008 Define | as an alias for pipe.
6009 (exit_status_set_internal_vars): New function.
6010 (shell_escape): Call exit_status_set_internal_vars.
6011 cli/cli-decode.c (find_command_name_length): Recognize | as
6012 a single character command.
6014 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6016 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6017 top.c (execute_command_to_ui_file): New function, mostly a copy
6018 of execute_command_to_string.
6019 (execute_command_to_string): Implement by calling
6020 execute_command_to_ui_file.
6022 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6024 * top.h (saved_command_line): Remove declaration.
6025 * top.c (previous_saved_command_line, previous_repeat_arguments):
6027 (saved_command_line): Make static, define together with other
6029 (dont_repeat): Clear repeat_arguments.
6030 (repeat_previous, get_saved_command_line, save_command_line):
6032 (gdb_init): Initialize saved_command_line
6033 and previous_saved_command_line.
6034 * main.c (captured_main_1): Remove saved_command_line initialization.
6035 * event-top.c (handle_line_of_input): Update to use
6036 the new 'repeat' related functions instead of direct access to
6038 * command.h (repeat_previous, get_saved_command_line,
6039 save_command_line): New declarations.
6040 (dont_repeat): Add comment.
6042 2019-05-30 Tom Tromey <tromey@adacore.com>
6044 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6046 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6048 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6051 * completer.c (complete): Initialize variable word.
6053 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6055 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6056 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6057 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6058 'body' is NULL to the outter 'if', protecting the '!is_define'
6061 2019-05-29 Tom Tromey <tromey@adacore.com>
6063 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6064 (dwarf_unknown): New function.
6065 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6066 (dwarf_type_encoding_name): Use dwarf_unknown.
6068 2019-05-29 Tom Tromey <tromey@adacore.com>
6071 * cp-valprint.c (cp_print_value_fields): Call
6072 cp_print_static_field inside "try".
6074 2019-05-29 Tom Tromey <tromey@adacore.com>
6076 * inflow.c (struct terminal_info): Add default operator=.
6077 * configure: Rebuild.
6078 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6079 -Wdeprecated-copy-dtor, -Wredundant-move.
6081 2019-05-29 Tom Tromey <tromey@adacore.com>
6084 * infcmd.c (print_return_value_1): Handle finish_print
6086 (show_print_finish): New function.
6087 (_initialize_infcmd): Add "set/show print finish" commands.
6088 * valprint.c (user_print_options): Initialize new member.
6089 * valprint.h (struct value_print_options) <finish_print>: New
6092 2019-05-28 Tom Tromey <tromey@adacore.com>
6094 * ada-lang.c (ada_remove_Xbn_suffix)
6095 (find_old_style_renaming_symbol)
6096 (parse_old_style_renaming): Remove.
6097 (ada_find_renaming_symbol): Don't call
6098 find_old_style_renaming_symbol.
6099 (ada_is_renaming_symbol): Rename from
6100 ada_find_renaming_symbol. Remove "block" parameter. Return
6102 (ada_read_var_value): Update and simplify.
6103 * ada-exp.y (write_var_or_type): Remove old code.
6105 2019-05-28 Alan Hayward <alan.hayward@arm.com>
6107 * event-top.c: Remove include comment.
6108 * inflow.c (class scoped_ignore_sigttou): Move from here...
6109 * inflow.h (class scoped_ignore_sigttou): ...to here.
6110 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6111 * top.c: Remove include comment.
6113 2019-05-27 Tom Tromey <tom@tromey.com>
6117 2019-05-22 Tom Tromey <tromey@adacore.com>
6119 * target.c (target_follow_exec): Constify parameter.
6120 * target-delegates.c: Rebuild.
6121 * remote.c (remote_target::follow_exec): Constify parameter.
6122 * infrun.c (follow_exec): Constify parameter.
6123 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6124 (target_follow_exec): Likewise.
6126 2019-05-22 Alan Hayward <alan.hayward@arm.com>
6128 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6129 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6131 2019-05-22 Alan Hayward <alan.hayward@arm.com>
6133 * NEWS: Add debugredirect and testsuite sections.
6135 2019-05-22 Simon Cook <simon.cook@embecosm.com>
6137 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6138 target descriptions using exclusively floating point register name
6141 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6144 * f-lang.c (build_fortran_types): Handle the case where
6145 gdbarch_floatformat_for_type returns a nullptr.
6147 2019-05-21 Tom de Vries <tdevries@suse.de>
6150 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6152 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6155 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6157 * i386-tdep.c (i386_floatformat_for_type): Use
6158 floatformats_ia64_quad for the 16-byte floating point component
6159 within a fortran 32-byte complex number.
6161 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6163 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6164 delete default constructor.
6165 (find_partial_die): Update to return const struct.
6166 (partial_die_parent_scope): Move variable declaration into scope
6167 of its use and change its type to auto.
6168 (guess_partial_die_structure_name): Likewise.
6169 (partial_die_info::fixup): Likewise.
6171 2019-05-17 Tom Tromey <tromey@adacore.com>
6173 * source.c (find_and_open_source): Remove cast.
6175 2019-05-17 Tom Tromey <tromey@adacore.com>
6177 * annotate.c (annotate_source): Make "filename" const.
6178 * annotate.h (annotate_source): Use const.
6180 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6182 * disasm.c (set_disassembler_options): Send errors to stderr.
6184 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6186 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6187 (cli_interp_base::set_logging): Check debug_redirect.
6188 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6189 * cli/cli-logging.c (debug_redirect): Add static variable.
6190 (pop_output_files): Add default param.
6191 (handle_redirections): Print debug setting.
6192 (show_logging_command): Likewise.
6193 (_initialize_cli_logging): Add debugredirect command.
6194 * interps.c (current_interp_set_logging): Add debug_redirect
6196 * interps.h (set_logging): Add debug_redirect parameter.
6197 (current_interp_set_logging): Likewise.
6198 * mi/mi-common.h: Likewise.
6199 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6201 2019-05-17 Alan Hayward <alan.hayward@arm.com>
6202 Tom Tromey <tromey@adacore.com>
6204 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6206 * cli/cli-interp.h (make_logging_output): Remove declaration.
6207 * cli/cli-logging.c (make_logging_output): Remove function.
6208 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6210 * ui-file.c (tee_file::tee_file): Remove bools.
6211 (tee_file::~tee_file): Remove deletes.
6212 * ui-file.h (tee_file): Remove bools.
6214 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6216 * mi/mi-cmds.h (mi_cmd_complete): New function.
6217 * mi/mi-main.c (mi_cmd_complete): Likewise.
6218 * mi/mi-cmds.c: Define new MI command -complete.
6219 * NEWS: Mention new -complete command.
6221 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6223 * completer.h (complete): New function.
6224 * completer.c (complete): Likewise.
6225 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6226 function defined in completer.h.
6228 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6230 * MAINTAINERS (Write After Approval): Add myself.
6232 2019-05-17 Tom de Vries <tdevries@suse.de>
6235 * dwarf2read.c (struct cu_partial_die_info): New struct.
6236 (find_partial_die): Return cu_partial_die_info.
6237 (partial_die_parent_scope, guess_partial_die_structure_name)
6238 (partial_die_info::fixup): Handle new return type of find_partial_die.
6240 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6242 PR breakpoints/24541
6243 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6244 "std::string", simplifying the algorithm.
6246 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6248 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6249 (stap_static_probe_ops::get_probes): Likewise.
6251 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6253 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6254 '-')" and "else if".
6255 (stap_parse_single_operand): Join checks for
6256 "gdbarch_stap_parse_special_token_p" and
6257 "gdbarch_stap_parse_special_token" in the same "if" statement.
6258 Invert check when verifying for operation on register
6261 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6263 * stap-probe.c (stap_get_opcode): Update comment.
6264 (stap_get_expected_argument_type): Likewise.
6265 (handle_stap_probe): Likewise.
6267 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6269 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6270 return type to 'bool'. Adjust comment. Use 'bool' when
6272 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6273 * stap-probe.c (stap_parse_argument_1): Likewise.
6274 (stap_is_operator): Likewise.
6275 (stap_is_generic_prefix): Likewise.
6276 (stap_is_register_prefix): Likewise.
6277 (stap_is_register_indirection_prefix): Likewise.
6278 (stap_is_integer_prefix): Likewise.
6279 (stap_generic_check_suffix): Likewise.
6280 (stap_check_integer_suffix): Likewise.
6281 (stap_check_register_suffix): Likewise.
6282 (stap_check_register_indirection_suffix): Likewise.
6283 (stap_parse_register_operand): Likewise.
6284 (stap_parse_single_operand): Likewise.
6285 (stap_parse_argument_1): Likewise.
6286 (stap_probe::get_argument_count): Likewise.
6287 (stap_is_operator): Likewise.
6289 2019-05-16 Tom Tromey <tromey@adacore.com>
6291 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6294 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
6296 * linux-thread-db.c (try_thread_db_load_1): Change return type
6298 (try_thread_db_load): Likewise.
6299 (try_thread_db_load_from_pdir_1): Likewise.
6300 (try_thread_db_load_from_pdir): Likewise.
6301 (try_thread_db_load_from_sdir): Likewise.
6302 (try_thread_db_load_from_dir): Likewise.
6303 (thread_db_load_search): Likewise.
6304 (has_libpthread): Likewise.
6305 (thread_db_load): Likewise.
6307 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6309 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6310 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6311 NULL, and complain/return if that's the case.
6313 2019-05-15 John Darrington <john@darrington.wattle.id.au>
6315 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6316 (advance, posn, abstract_read_memory): New functions.
6317 [struct mem_read_abstraction]: New struct.
6318 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6320 2019-05-14 Tom Tromey <tromey@adacore.com>
6322 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6323 value is not lval_memory.
6325 2019-05-14 Tom Tromey <tromey@adacore.com>
6327 * solib.c (info_sharedlibrary_command): Style the file name.
6329 2019-05-14 Alan Hayward <alan.hayward@arm.com>
6331 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6332 (aarch64_vnv_type): Likewise.
6333 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6334 * common/tdesc.c: Likewise.
6335 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6336 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6337 * features/aarch64-fpu.xml: Add ieee half view.
6338 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6339 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6340 * gdbtypes.h (struct builtin_type): Likewise.
6341 (struct objfile_type): Likewise.
6343 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
6345 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6347 * location.h (string_to_event_location): Likewise.
6349 2019-05-11 Joel Brobecker <brobecker@adacore.com>
6353 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
6355 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6356 New variable declaration.
6357 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6359 (print_one_breakpoint): Use ui_out::test_flags and new global
6360 variable to compute use_fixed_output.
6361 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6363 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6364 (mi_multi_location_breakpoint_output_fixed): Remove.
6365 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6367 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6368 fix_multi_location_breakpoint_output flag if version >= 3.
6369 * ui-out.h (enum ui_out_flag)
6370 <fix_multi_location_breakpoint_output>: New enumerator.
6372 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
6374 * contrib/cc-with-tweaks.sh: Validate dwz's work.
6376 2019-05-10 Tom Tromey <tromey@adacore.com>
6378 * ada-lang.c (catch_ada_completer): New function.
6379 (_initialize_ada_language): Use it.
6381 2019-05-10 Tom Tromey <tromey@adacore.com>
6383 * thread.c (print_thread_info): Make "requested_threads" const.
6384 * gdbthread.h (print_thread_info): Make "requested_threads"
6386 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6387 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6389 2019-05-08 Tom Tromey <tom@tromey.com>
6391 * gdbtypes.c (objfile_type_data): Change type.
6392 (objfile_type, _initialize_gdbtypes): Update.
6394 2019-05-08 Tom Tromey <tom@tromey.com>
6396 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6397 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6398 (_initialize_dwarf2_frame): Update.
6400 2019-05-08 Tom Tromey <tom@tromey.com>
6402 * objc-lang.c (objc_objfile_data): Change type.
6403 (find_methods): Update.
6404 (_initialize_objc_lang): Remove.
6406 2019-05-08 Tom Tromey <tom@tromey.com>
6408 * stabsread.c (rs6000_builtin_type_data): Change type.
6409 (rs6000_builtin_type, _initialize_stabsread): Update.
6411 2019-05-08 Tom Tromey <tom@tromey.com>
6413 * mips-tdep.c (mips_pdr_data): Remove.
6414 (_initialize_mips_tdep): Update.
6416 2019-05-08 Tom Tromey <tom@tromey.com>
6418 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6419 (hppa_init_objfile_priv_data, read_unwind_info)
6420 (find_unwind_entry, _initialize_hppa_tdep): Update.
6422 2019-05-08 Tom Tromey <tom@tromey.com>
6424 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6425 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
6427 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6429 2019-05-08 Tom Tromey <tom@tromey.com>
6431 * mdebugread.c (basic_type_data): Change type.
6432 (basic_type, _initialize_mdebugread): Update.
6434 2019-05-08 Tom Tromey <tom@tromey.com>
6436 * common/gdb_unique_ptr.h (struct noop_deleter): New.
6438 2019-05-08 Tom Tromey <tom@tromey.com>
6440 * nto-tdep.c (nto_inferior_data_reg): Change type.
6441 (nto_inferior_data): Update.
6442 (nto_inferior_data_cleanup, nto_new_inferior_data)
6443 (_initialize_nto_tdep): Remove.
6444 * nto-tdep.h (struct nto_inferior_data): Add initializers.
6446 2019-05-08 Tom Tromey <tom@tromey.com>
6448 * ada-lang.c (struct ada_inferior_data): Add initializers.
6449 (ada_inferior_data): Change type.
6450 (ada_inferior_data_cleanup): Remove.
6451 (get_ada_inferior_data, ada_inferior_exit)
6452 (struct ada_pspace_data): Add initializers, destructor.
6453 (ada_pspace_data_handle): Change type.
6454 (get_ada_pspace_data): Update.
6455 (ada_pspace_data_cleanup): Remove.
6457 2019-05-08 Tom Tromey <tom@tromey.com>
6459 * coffread.c (struct coff_symfile_info): Add initializers.
6460 (coff_objfile_data_key): Move lower. Change type.
6461 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6463 (coff_free_info): Remove.
6465 2019-05-08 Tom Tromey <tom@tromey.com>
6467 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6468 (fbsd_pspace_data_handle): Move lower. Change type.
6469 (get_fbsd_pspace_data): Update.
6470 (fbsd_pspace_data_cleanup): Remove.
6471 (_initialize_fbsd_tdep): Update.
6473 2019-05-08 Tom Tromey <tom@tromey.com>
6475 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6476 (get_ada_tasks_pspace_data): Update.
6477 (ada_tasks_pspace_data_cleanup): Remove.
6478 (_initialize_tasks): Update.
6479 (ada_tasks_inferior_data_handle): Change type.
6480 (get_ada_tasks_inferior_data): Update.
6481 (ada_tasks_inferior_data_cleanup): Remove.
6482 (struct ada_tasks_pspace_data): Add initializers.
6484 2019-05-08 Tom Tromey <tom@tromey.com>
6486 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6487 * symfile-debug.c (debug_sym_get_probes): Change type.
6488 * stap-probe.c (handle_stap_probe):
6489 (stap_static_probe_ops::get_probes): Change type.
6490 * probe.h (class static_probe_ops) <get_probes>: Change type.
6491 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6492 (parse_probes_in_pspace): Update.
6493 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6495 (any_static_probe_ops::get_probes): Change type.
6496 * elfread.c (elfread_data): New typedef.
6497 (probe_key): Change type.
6498 (elf_get_probes): Likewise. Update.
6499 (probe_key_free): Remove.
6500 (_initialize_elfread): Update.
6501 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6503 (dtrace_process_dof_probe, dtrace_process_dof)
6504 (dtrace_static_probe_ops::get_probe): Change type.
6506 2019-05-08 Tom Tromey <tom@tromey.com>
6508 * xcoffread.c (struct xcoff_symfile_info): Rename from
6509 coff_symfile_info. Add initializers.
6510 (xcoff_objfile_data_key): Move lower. Change type.
6511 (XCOFF_DATA): Rewrite.
6512 (xcoff_free_info): Remove.
6513 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6514 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6515 (xcoff_initial_scan): Update.
6517 2019-05-08 Tom Tromey <tom@tromey.com>
6519 * solib-svr4.c (struct svr4_info): Add initializers and
6521 <probes_table>: Now an htab_up.
6522 (solib_svr4_pspace_data): Change type.
6523 (free_probes_table): Simplify.
6524 (~svr4_info): Rename from svr4_pspace_data_cleanup.
6525 (get_svr4_info, probes_table_htab_remove_objfile_probes)
6526 (probes_table_remove_objfile_probes, register_solib_event_probe)
6527 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6528 (_initialize_svr4_solib): Update.
6530 2019-05-08 Tom Tromey <tom@tromey.com>
6532 * remote.c (remote_pspace_data): Change type.
6533 (remote_pspace_data_cleanup): Remove.
6534 (get_remote_exec_file, set_pspace_remote_exec_file)
6535 (_initialize_remote): Update.
6537 2019-05-08 Tom Tromey <tom@tromey.com>
6539 * breakpoint.c (breakpoint_objfile_key): Change type.
6540 (get_breakpoint_objfile_data): Update.
6541 (free_breakpoint_objfile_data): Remove.
6542 (_initialize_breakpoint): Update.
6544 2019-05-08 Tom Tromey <tom@tromey.com>
6546 * linux-tdep.c (struct linux_info): Add initializers.
6547 (linux_inferior_data): Move. Change type.
6548 (invalidate_linux_cache_inf): Update.
6549 (linux_inferior_data_cleanup): Remove.
6550 (get_linux_inferior_data, _initialize_linux_tdep): Update.
6552 2019-05-08 Tom Tromey <tom@tromey.com>
6554 * auxv.c (auxv_inferior_data): Move. Change type.
6555 (auxv_inferior_data_cleanup): Remove.
6556 (invalidate_auxv_cache_inf): Rewrite.
6557 (get_auxv_inferior_data, _initialize_auxv): Update.
6559 2019-05-08 Tom Tromey <tom@tromey.com>
6561 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6562 (symfile_debug_objfile_data_key): Change type.
6563 (symfile_debug_installed, debug_qf_has_symbols)
6564 (debug_qf_find_last_source_symtab)
6565 (debug_qf_forget_cached_source_info)
6566 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6567 (debug_qf_print_stats, debug_qf_dump)
6568 (debug_qf_expand_symtabs_for_function)
6569 (debug_qf_expand_all_symtabs)
6570 (debug_qf_expand_symtabs_with_fullname)
6571 (debug_qf_map_matching_symbols)
6572 (debug_qf_expand_symtabs_matching)
6573 (debug_qf_find_pc_sect_compunit_symtab)
6574 (debug_qf_map_symbol_filenames)
6575 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6576 (debug_sym_new_init, debug_sym_init, debug_sym_read)
6577 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6578 (debug_sym_read_linetable, debug_sym_relocate): Update.
6579 (symfile_debug_free_objfile): Remove.
6580 (install_symfile_debug_logging, _initialize_symfile_debug):
6583 2019-05-08 Tom Tromey <tom@tromey.com>
6585 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6586 allocate_on_obstack.
6587 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6588 (get_dwarf2_per_objfile): Update.
6589 (set_dwarf2_per_objfile): Remove.
6590 (dwarf2_has_info, dwarf2_get_section_info): Update.
6591 (dwarf2_free_objfile): Remove.
6592 (_initialize_dwarf2_read): Update.
6594 2019-05-08 Tom Tromey <tom@tromey.com>
6596 * auto-load.c (struct auto_load_pspace_info): Add destructor and
6598 <unsupported_script_warning_printed,
6599 script_not_found_warning_printed>: Now bool.
6600 (auto_load_pspace_data): Change type.
6601 (~auto_load_pspace_info): Rename from
6602 auto_load_pspace_data_cleanup.
6603 (get_auto_load_pspace_data, init_loaded_scripts_info)
6604 (clear_section_scripts, maybe_print_unsupported_script_warning)
6605 (maybe_print_script_not_found_warning, _initialize_auto_load):
6608 2019-05-08 Tom Tromey <tom@tromey.com>
6610 * objfiles.c (objfile_pspace_info): Add destructor and
6612 (objfiles_pspace_data): Change type.
6613 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6614 (get_objfile_pspace_data): Update.
6615 (objfiles_bfd_data): Change type.
6616 (get_objfile_bfd_data): Update.
6617 (objfile_bfd_data_free, _initialize_objfiles): Remove.
6619 2019-05-08 Tom Tromey <tom@tromey.com>
6621 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6623 (get_catch_syscall_inferior_data): Update.
6624 (catch_syscall_inferior_data_cleanup): Remove.
6625 (_initialize_break_catch_syscall): Update.
6627 2019-05-08 Tom Tromey <tom@tromey.com>
6629 * inflow.c (struct terminal_info): Add destructor and
6631 (inflow_inferior_data): Change type.
6632 (~terminal_info): Rename from inflow_inferior_data_cleanup.
6633 (get_inflow_inferior_data, inflow_inferior_exit)
6634 (swap_terminal_info, _initialize_inflow): Update.
6636 2019-05-08 Tom Tromey <tom@tromey.com>
6638 * target-dcache.c (target_dcache_cleanup): Remove.
6639 (target_dcache_aspace_key): Change type.
6640 (target_dcache_init_p, target_dcache_invalidate)
6641 (target_dcache_get, target_dcache_get_or_init)
6642 (_initialize_target_dcache): Update.
6643 * dcache.h (struct dcache_deleter): New.
6645 2019-05-08 Tom Tromey <tom@tromey.com>
6647 * symtab.c (struct symbol_cache): Add destructor and
6649 (symbol_cache_key): Move. Change type.
6650 (make_symbol_cache, free_symbol_cache): Remove.
6651 (get_symbol_cache): Update.
6652 (symbol_cache_cleanup): Remove.
6653 (ALL_PSPACES, symbol_cache_flush)
6654 (maintenance_print_symbol_cache)
6655 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6658 2019-05-08 Tom Tromey <tom@tromey.com>
6660 * symtab.c (struct main_info): Add destructor and initializers.
6661 (main_progspace_key): Move. Change type.
6662 (get_main_info): Update.
6663 (main_info_cleanup): Remove.
6664 (_initialize_symtab): Update.
6666 2019-05-08 Tom Tromey <tom@tromey.com>
6668 * registry.h (DECLARE_REGISTRY): Define the _key class.
6670 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
6672 * NEWS: Merge two 'New commands' sections.
6674 2019-05-08 Joel Brobecker <brobecker@adacore.com>
6676 * ada-valprint.c (ada_val_print_gnat_array): Remove language
6677 parameter and use Ada language definition instead.
6678 (ada_val_print_ptr): Remove unused language parameter.
6679 (ada_val_print_num): Remove language parameter and use Ada language
6681 (ada_val_print_enum, ada_val_print_flt): Remove unused language
6683 (ada_val_print_struct_union, ada_val_print_ref): Remove language
6684 parameter and use Ada language definition instead.
6685 (ada_val_print_1): Update all ada_val_print_xxx calls.
6686 Remove language parameter.
6687 (ada_val_print): Update ada_val_print_1 call.
6689 2019-05-08 Tom Tromey <tromey@adacore.com>
6691 * remote.c (remote_hw_watchpoint_limit)
6692 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6695 2019-05-08 Tom Tromey <tromey@adacore.com>
6697 * maint.c (_initialize_maint_cmds): Move initialization code to
6699 (watchdog, show_watchdog): Move to remote.c.
6700 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
6702 (_initialize_remote): Move initialization code from maint.c.
6703 * defs.h (watchdog): Don't declare.
6705 2019-05-08 Tom Tromey <tromey@adacore.com>
6707 * tui/tui-interp.c: Include main.h.
6708 * interps.c: Include main.h.
6709 * main.h (interpreter_p): Declare.
6710 * defs.h (interpreter_p): Don't declare.
6712 2019-05-08 Tom Tromey <tromey@adacore.com>
6714 * dwarf2loc.c: Include dwarf2read.h.
6715 * defs.h (read_unsigned_leb128): Don't declare.
6716 * dwarf2read.h (read_unsigned_leb128): Declare.
6718 2019-05-08 Tom Tromey <tromey@adacore.com>
6720 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6723 2019-05-08 Tom Tromey <tromey@adacore.com>
6725 * utils.c (fputs_maybe_filtered): Reset style after paging, even
6726 when no wrap column is set.
6728 2019-05-08 Tom Tromey <tromey@adacore.com>
6730 * c-lang.c (c_get_string): Handle non-C-style arrays.
6732 2019-05-08 Tom Tromey <tromey@adacore.com>
6734 * typeprint.c (print_offset_data::update): Print the bit offset,
6735 not the number of bits remaining.
6737 2019-05-08 Tom Tromey <tromey@adacore.com>
6739 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6740 padding at end of comment.
6742 2019-05-08 Tom Tromey <tromey@adacore.com>
6744 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6747 2019-05-06 Tom Tromey <tom@tromey.com>
6749 * common/scoped_mmap.c: Include common-defs.h.
6750 * common/scoped_mmap.h: Don't include config.h.
6752 2019-05-04 Tom Tromey <tom@tromey.com>
6754 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6755 (struct aarch64_call_info): Add initializers.
6756 <si>: Now a std::vector.
6757 (pass_on_stack, aarch64_push_dummy_call): Update.
6759 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
6760 Tom Tromey <tom@tromey.com>
6762 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6763 (ppc_threads): Now a std::vector. Now static.
6764 (hwdebug_find_thread_points_by_tid)
6765 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6768 2019-05-04 Tom Tromey <tom@tromey.com>
6770 * arc-tdep.c (arc_tdesc_init): Return bool.
6772 2019-05-04 Tom Tromey <tom@tromey.com>
6774 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6775 Use gdb_assert_not_reached.
6777 2019-05-04 Tom Tromey <tom@tromey.com>
6779 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6782 2019-05-04 Tom Tromey <tom@tromey.com>
6784 * arc-tdep.c (arc_tdesc_init): Use bool.
6786 2019-05-04 Tom Tromey <tom@tromey.com>
6788 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6790 2019-05-04 Tom Tromey <tom@tromey.com>
6792 * cli/cli-cmds.c (valid_command_p): Return bool.
6794 2019-05-04 Tom Tromey <tom@tromey.com>
6796 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6797 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6799 2019-05-04 Raul Tambre <raul@tambre.ee>
6801 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6802 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6803 operator for comparison.
6805 2019-05-04 Tom Tromey <tom@tromey.com>
6807 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6808 (lookup_partial_symbol, print_partial_symbols)
6809 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6810 (psymbol_compare): Update.
6811 (add_psymbol_to_bcache): Clear the entire psymbol.
6812 (maintenance_check_psymtabs): Update.
6813 * psympriv.h (struct partial_symbol): Don't derive from
6814 general_symbol_info.
6815 <obj_section, unrelocated_address, address,
6816 set_unrelocated_address>: Update.
6817 <ginfo>: New member.
6818 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6819 (debug_names::write_psymbols): Update.
6821 2019-05-04 Tom de Vries <tdevries@suse.de>
6823 * contrib/cc-with-tweaks.sh: Support -n arg.
6825 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6827 * corelow.c (core_target::detach): Ensure frame cache and
6828 register caches are cleared.
6829 inferior.c (exit_inferior_1): Likewise.
6831 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6832 Tom Tromey <tom@tromey.com>
6834 * dictionary.c (collate_pending_symbols_by_language): Remove
6835 "struct" from foreach.
6836 * symtab.c (lookup_global_symbol_from_objfile)
6837 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6839 * ser-tcp.c (net_open): Remove "struct" from foreach.
6840 * objfiles.c (objfile_relocate, objfile_rebase)
6841 (objfile_has_symbols): Remove "struct" from foreach.
6842 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6844 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6846 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6847 "struct" from foreach.
6848 * ada-lang.c (create_excep_cond_exprs)
6849 (ada_exception_catchpoint_cond_string): Remove "struct" from
6852 2019-05-03 Tom Tromey <tromey@adacore.com>
6854 * ada-exp.y (convert_char_literal): Check suffix of each
6857 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6860 * ada-exp.y (yywrap): Don't define.
6861 * ada-lex.l (%option): Add noyywrap
6864 2019-05-03 Eli Zaretskii <eliz@gnu.org>
6866 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6867 _WIN32_WINNT to the XP level, unless already defined to a higher
6870 * unittests/parse-connection-spec-selftests.c:
6872 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6875 * symfile.c (find_separate_debug_file): Remove colon from the
6876 drive spec of DOS/Windows file names of the target, so that the
6877 file name produced from DEBUGDIR and the target's directory will
6878 be valid on DOS/Windows systems.
6880 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6882 * rust-lang.c (val_print_struct): Handle printing structures
6885 2019-05-02 Tom Tromey <tromey@adacore.com>
6887 * valarith.c (_initialize_valarith): Remove.
6889 2019-05-01 Tom Tromey <tromey@adacore.com>
6891 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6894 2019-05-01 Tom Tromey <tromey@adacore.com>
6896 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6897 for big-endian copies.
6899 2019-04-30 Ali Tamur <tamur@google.com>
6900 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6901 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6902 (read_3_bytes): New function.
6904 2019-04-30 Joel Brobecker <brobecker@adacore.com>
6906 * windows-nat.c (main_thread_id): Delete.
6907 (handle_output_debug_string): Replace main_thread_id by
6908 current_event.dwThreadId.
6909 (fake_create_process): Likewise.
6910 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6911 Do not set main_thread_id.
6912 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6913 current_event.dwThreadId.
6914 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6916 2019-04-30 Joel Brobecker <brobecker@adacore.com>
6918 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6919 Use current_event.dwThreadId instead of main_thread_id.
6921 2019-04-30 Tom Tromey <tromey@adacore.com>
6923 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6924 (create_excep_cond_exprs): Iterate over program spaces.
6925 (ada_exception_catchpoint_cond_string): Examine all minimal
6926 symbols for exception types.
6928 2019-04-30 Tom Tromey <tromey@adacore.com>
6931 * dwarf2read.c (process_structure_scope): Handle case where type
6932 has template parameters but no symbol was created.
6934 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6935 Chris January <chris.january@arm.com>
6937 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6939 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6941 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6943 * f-typeprint.c (f_print_type): Update rules for printing
6945 (f_type_print_varspec_suffix): Likewise.
6947 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6948 Chris January <chris.january@arm.com>
6950 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6953 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6955 * f-lang.c (build_fortran_types): Change name of void type to
6957 * f-typeprint.c (f_type_print_base): Print the name of the void
6958 type, rather than a fixed string.
6959 * f-valprint.c (f_decorations): Use lower case void string.
6961 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6962 Chris January <chris.january@arm.com>
6964 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6967 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6968 Chris January <chris.january@arm.com>
6969 David Lecomber <david.lecomber@arm.com>
6971 * f-exp.y (BINOP_INTRINSIC): New token.
6972 (exp): New parser rule handling BINOP_INTRINSIC.
6973 (f77_keywords): Add new builtin procedures.
6974 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6975 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6976 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6977 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6978 (print_unop_subexp_f): New function.
6979 (print_binop_subexp_f): New function.
6980 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6981 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6982 (dump_subexp_body_f): Likewise.
6983 (operator_check_f): Likewise.
6984 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6985 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6987 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6989 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6991 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6992 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6993 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6994 (operator_length_f): New fuction.
6995 (print_subexp_f): New function.
6996 (op_name_f): New function.
6997 (dump_subexp_body_f): New function.
6998 (operator_check_f): New function.
6999 (exp_descriptor_f): Replace standard expression handling functions
7001 * gdb/fortran-operator.def: New file.
7002 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7003 * gdb/std-operator.def: Remove UNOP_KIND.
7005 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7007 * std-operator.def: Remove unbalanced, stray double quote
7010 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7011 Chris January <chris.january@arm.com>
7012 Daniel Everett <daniel.everett@arm.com>
7013 Nick Forrington <nick.forrington@arm.com>
7014 Richard Bunt <richard.bunt@arm.com>
7016 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7017 of depth when printing anonymous structs or unions.
7018 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7019 Don't print either the top-level value, or the children if the
7020 max-depth is exceeded.
7021 (ppscm_print_children): When printing the key of a map, allow one
7022 extra level of depth.
7023 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7024 print either the top-level value, or the children if the max-depth
7026 (print_children): When printing the key of a map, allow one extra
7028 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7029 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7030 (user_print_options): Initialise max_depth field.
7031 (val_print_scalar_or_string_type_p): New function.
7032 (val_print): Check to see if the max depth has been reached.
7033 (val_print_check_max_depth): Define new function.
7034 (show_print_max_depth): New function.
7035 (_initialize_valprint): Add 'print max-depth' option.
7036 * valprint.h (struct value_print_options) <max_depth>: New field.
7037 (val_print_check_max_depth): Declare new function.
7038 * NEWS: Document new feature.
7040 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7042 * ada-lang.c (ada_language_defn): Initialise new field.
7043 * c-lang.c (c_is_string_type_p): New function.
7044 (c_language_defn): Initialise new field.
7045 (cplus_language_defn): Initialise new field.
7046 (asm_language_defn): Initialise new field.
7047 (minimal_language_defn): Initialise new field.
7048 * c-lang.h (c_is_string_type_p): Declare new function.
7049 * d-lang.c (d_language_defn): Initialise new field.
7050 * f-lang.c (f_is_string_type_p): New function.
7051 (f_language_defn): Initialise new field.
7052 * go-lang.c (go_is_string_type_p): New function.
7053 (go_language_defn): Initialise new field.
7054 * language.c (default_is_string_type_p): New function.
7055 (unknown_language_defn): Initialise new field.
7056 (auto_language_defn): Initialise new field.
7057 * language.h (struct language_defn) <la_is_string_type_p>: New
7059 (default_is_string_type_p): Declare new function.
7060 * m2-lang.c (m2_language_defn): Initialise new field.
7061 * objc-lang.c (objc_language_defn): Initialise new field.
7062 * opencl-lang.c (opencl_language_defn): Initialise new field.
7063 * p-lang.c (pascal_is_string_type_p): New function.
7064 (pascal_language_defn): Initialise new field.
7065 * rust-lang.c (rust_is_string_type_p): New function.
7066 (rust_language_defn): Initialise new field.
7068 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7070 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7072 * ada-lang.c (ada_language_defn): Initialise new field.
7073 * c-lang.c (c_language_defn): Likewise.
7074 (cplus_language_defn): Likewise.
7075 (asm_language_defn): Likewise.
7076 (minimal_language_defn): Likewise.
7077 * d-lang.c (d_language_defn): Likewise.
7078 * f-lang.c (f_language_defn): Likewise.
7079 * go-lang.c (go_language_defn): Likewise.
7080 * language.c (unknown_language_defn): Likewise.
7081 (auto_language_defn): Likewise.
7082 * m2-lang.c (m2_language_defn): Likewise.
7083 * objc-lang.c (objc_language_defn): Likewise.
7084 * opencl-lang.c (opencl_language_defn): Likewise.
7085 * p-lang.c (pascal_language_defn): Likewise.
7086 * rust-lang.c (rust_language_defn): Likewise.
7088 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7090 * ada-lang.c (ada_is_character_type): Change return type to bool.
7091 (ada_is_string_type): Likewise.
7092 * ada-lang.h (ada_is_character_type): Update declaration
7093 (ada_is_string_type): Likewise.
7095 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7097 Support style in 'frame|thread apply'
7099 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7100 * record.c (record_start, record_stop): Update callers of
7101 execute_command_to_string with false.
7102 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7103 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7105 (class string_file): New constructor with term_out parameter.
7106 Override methods term_out and can_emit_style_escape. New member
7108 (class stdio_file): Override can_emit_style_escape.
7109 (class tee_file): Override term_out and can_emit_style_escape.
7110 * utils.h (can_emit_style_escape): Remove.
7111 * utils.c (can_emit_style_escape): Likewise.
7112 Update all callers of can_emit_style_escape (SOMESTREAM) to
7113 SOMESTREAM->can_emit_style_escape.
7114 * source-cache.c (source_cache::get_source_lines): Likewise.
7115 * stack.c (frame_apply_command_count): Call execute_command_to_string
7116 passing the term_out characteristic of the current gdb_stdout.
7117 * thread.c (thr_try_catch_cmd): Likewise.
7118 * top.c (execute_command_to_string): pass term_out parameter
7119 to construct the string_file for the command output.
7120 * ui-file.c (term_cli_styling): New function (most code moved
7121 from utils.c can_emit_style_escape).
7122 (string_file::string_file, string_file::can_emit_style_escape,
7123 stdio_file::can_emit_style_escape, tee_file::term_out,
7124 tee_file::can_emit_style_escape): New functions.
7126 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7128 * NEWS: Mention the new set|show may-call-functions.
7129 * infcall.c (may_call_functions_p): New variable.
7130 (show_may_call_functions_p): New function.
7131 (call_function_by_hand_dummy): Throws an error if not
7133 (_initialize_infcall): Call add_setshow_boolean_cmd for
7136 2019-04-25 Keith Seitz <keiths@redhat.com>
7139 * cp-support.c (inspect_type): Don't attempt substitutions
7140 of symbol with the same name.
7142 2019-04-25 Tom Tromey <tromey@adacore.com>
7145 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7148 2019-04-25 Tom Tromey <tromey@adacore.com>
7150 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7152 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7153 (gdb_xml_parser::parse): Use std::move.
7154 * python/python-internal.h (gdbpy_convert_exception): Take a const
7156 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7158 * python/py-utils.c (gdbpy_convert_exception): Take a const
7160 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7162 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7164 * mi/mi-main.c (mi_print_exception): Take a const reference.
7165 * main.c (handle_command_errors): Take a const reference.
7166 * linespec.c (parse_linespec): Use std::move.
7167 * infcall.c (run_inferior_call): Use std::move.
7168 (call_function_by_hand_dummy): Use std::move.
7169 * exec.c (try_open_exec_file): Use std::move.
7170 * exceptions.h (exception_print, exception_fprintf)
7171 (exception_print_same): Update.
7172 * exceptions.c (print_exception, exception_print)
7173 (exception_fprintf, exception_print_same): Change parameters to
7175 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7176 * common/new-op.c: Use std::move.
7177 * common/common-exceptions.h (struct gdb_exception): Add move
7179 (struct gdb_exception_error, struct gdb_exception_quit, struct
7180 gdb_quit_bad_alloc): Change constructor to move constructor.
7181 (throw_exception): Change parameter to rvalue reference.
7182 * common/common-exceptions.c (throw_exception): Take rvalue
7184 * cli/cli-interp.c (safe_execute_command): Use std::move.
7185 * breakpoint.c (insert_bp_location, location_to_sals): Use
7188 2019-04-25 Tom Tromey <tromey@adacore.com>
7190 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7191 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7192 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7193 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7194 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7195 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7196 guile/scm-value.c: Use unpack.
7197 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7198 gdbscm_gdb_exception.
7199 (gdbscm_throw_gdb_exception): Likewise.
7200 (struct gdbscm_gdb_exception): New.
7201 (unpack): New function.
7202 (gdbscm_wrap): Use unpack.
7204 2019-04-25 Tom Tromey <tromey@adacore.com>
7206 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7207 (gdb_rl_callback_handler): Use std::move.
7208 * common/common-exceptions.h (struct gdb_exception): Add move
7209 assignment operator.
7210 (throw_exception_sjlj): Change "exception" to const reference.
7211 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7212 (throw_exception_sjlj): Change "exception" to const reference.
7214 2019-04-25 Tom Tromey <tromey@adacore.com>
7216 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7217 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7218 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7220 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7222 * mi/mi-interp.c (mi_interp::exec): Update.
7223 * linespec.c (parse_linespec): Update.
7224 * infcall.c (run_inferior_call): Update.
7225 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7226 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7227 (gdbscm_lookup_global_symbol): Update.
7228 * guile/scm-param.c (gdbscm_parameter_value): Update.
7229 * guile/scm-frame.c (gdbscm_frame_read_register)
7230 (gdbscm_frame_read_var): Update.
7231 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7232 * exec.c (try_open_exec_file): Update.
7233 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7234 (gdb_rl_callback_handler): Update.
7235 * common/common-exceptions.h (exception_none): Don't declare.
7236 * common/common-exceptions.c (exception_none): Don't define.
7237 (struct catcher) <exception>: Update.
7238 * cli/cli-interp.c (safe_execute_command): Update.
7239 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7241 2019-04-25 Ali Tamur <tamur@google.com>
7243 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7244 (read_attribute_value): Likewise.
7245 (dwarf2_read_addr_index): Update comment.
7246 (read_str_index): Add DW_FORM_strx.
7247 (dwarf2_string_attr): Likewise.
7248 (dwarf2_const_value_attr): Likewise.
7249 (dump_die_shallow): Likewise.
7250 (dwarf2_fetch_constant_bytes): Likewise.
7251 (skip_form_bytes): Likewise.
7252 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7254 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7258 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7259 OFFSET. Verify if current mapping contains an ELF header.
7260 (linux_find_memory_regions_full): Adjust call to
7263 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7264 Kang Li <kanglictf@gmail.com>
7268 * dwarf2-frame.c (read_initial_length): Be consistent about using
7269 unsigned representation of length.
7270 (decode_frame_entry_1): Likewise. Check for wraparound of
7271 end pointer as well as buffer overflow.
7273 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7275 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7278 2019-04-24 Tom Tromey <tromey@adacore.com>
7280 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7282 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7284 * s12z-tdep.c (s12z_unwind_pc): Delete.
7285 (s12z_unwind_sp): Delete.
7286 (s12z_gdbarch_init): Don't register deleted functions with
7289 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7291 * rl78-tdep.c (rl78_unwind_sp): Delete.
7292 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7294 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7296 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7297 (xstormy16_unwind_pc): Delete.
7298 (xstormy16_dummy_id): Delete.
7299 (xstormy16_gdbarch_init): Don't register deleted functions with
7302 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7304 * vax-tdep.c (vax_unwind_pc): Delete.
7305 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7307 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7309 * v850-tdep.c (v850_unwind_sp): Delete.
7310 (v850_unwind_pc): Delete.
7311 (v850_dummy_id): Delete.
7312 (v850_gdbarch_init): Don't register deleted functions with
7315 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7317 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7318 (tilegx_unwind_pc): Delete.
7319 (tilegx_unwind_dummy_id): Delete.
7320 (tilegx_gdbarch_init): Don't register deleted functions with
7323 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7325 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7326 (tic6x_dummy_id): Delete.
7327 (tic6x_gdbarch_init): Don't register deleted functions with
7330 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7332 * sparc-tdep.c (sparc_unwind_pc): Delete.
7333 (sparc32_gdbarch_init): Don't register deleted function with
7336 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7338 * sh-tdep.c (sh_unwind_sp): Delete.
7339 (sh_unwind_pc): Delete.
7340 (sh_dummy_id): Delete.
7341 (sh_gdbarch_init): Don't register deleted functions with
7344 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7346 * score-tdep.c (score_unwind_sp): Delete.
7347 (score_unwind_pc): Delete.
7348 (score_dummy_id): Delete.
7349 (score_gdbarch_init): Don't register deleted functions with
7352 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7354 * rx-tdep.c (rx_unwind_pc): Delete.
7355 (rx_unwind_sp): Delete.
7356 (rx_dummy_id): Delete.
7357 (rx_gdbarch_init): Don't register deleted functions with
7358 gdbarch. Update comment.
7360 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7362 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7363 (rs6000_dummy_id): Delete.
7364 (rs6000_gdbarch_init): Don't register deleted functions with
7367 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7369 * or1k-tdep.c (or1k_dummy_id): Delete.
7370 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7372 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7374 * nios2-tdep.c (nios2_dummy_id): Delete.
7375 (nios2_unwind_sp): Delete.
7376 (nios2_gdbarch_init): Don't register deleted functions with
7379 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7381 * nds32-tdep.c (nds32_dummy_id): Delete.
7382 (nds32_unwind_pc): Delete.
7383 (nds32_unwind_sp): Delete.
7384 (nds32_gdbarch_init): Don't register deleted functions with
7387 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7389 * msp430-tdep.c (msp430_unwind_pc): Delete.
7390 (msp430_unwind_sp): Delete.
7391 (msp430_dummy_id): Delete.
7392 (msp430_gdbarch_init): Don't register deleted functions with
7395 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7397 * moxie-tdep.c (moxie_unwind_sp): Delete.
7398 (moxie_unwind_pc): Delete.
7399 (moxie_dummy_id): Delete.
7400 (moxie_gdbarch_init): Don't register deleted functions with
7403 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7405 * mn10300-tdep.c (mn10300_dummy_id): Delete.
7406 (mn10300_unwind_pc): Delete.
7407 (mn10300_unwind_sp): Delete.
7408 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7410 (mn10300_frame_unwind_init): Don't register deleted functions with
7413 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7415 * mep-tdep.c (mep_unwind_pc): Delete.
7416 (mep_unwind_sp): Delete.
7417 (mep_dummy_id): Delete.
7418 (mep_gdbarch_init): Don't register deleted functions with
7421 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7423 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7424 (m68hc11_unwind_sp): Delete.
7425 (m68hc11_gdbarch_init): Don't register deleted functions with
7428 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7430 * m32r-tdep.c (m32r_unwind_sp): Delete.
7431 (m32r_unwind_pc): Delete.
7432 (m32r_dummy_id): Delete.
7433 (m32r_gdbarch_init): Don't register deleted functions with
7436 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7438 * m32c-tdep.c (m32c_unwind_pc): Delete.
7439 (m32c_unwind_sp): Delete.
7440 (m32c_dummy_id): Delete.
7441 (m32c_gdbarch_init): Don't register deleted functions with
7444 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7446 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7447 (lm32_unwind_pc): Delete.
7448 (lm32_dummy_id): Delete.
7449 (lm32_gdbarch_init): Don't register deleted functions with
7452 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7454 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7455 (iq2000_unwind_pc): Delete.
7456 (iq2000_dummy_id): Delete.
7457 (iq2000_gdbarch_init): Don't register deleted functions with
7460 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7462 * nds32-tdep.c (nds32_type_align): Delete.
7463 (nds32_push_dummy_call): Use type_align instead.
7465 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7467 * arm-tdep.c (arm_type_align): Only handle vector override case.
7468 (arm_push_dummy_call): Use type_align.
7469 (arm_gdbarch_init): Register arm_type_align gdbarch function.
7471 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7473 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7475 (pass_on_stack): Use type_align.
7476 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7479 2019-04-23 Tom Tromey <tromey@adacore.com>
7481 * dwarf2read.c (line_header::file_name_at): Remove unused
7484 2019-04-23 Tom de Vries <tdevries@suse.de>
7487 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7491 2019-03-27 Ali Tamur <tamur@google.com>
7493 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7494 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7495 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7496 (dwarf_expr_context::get_addr_index): Likewise
7497 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7498 (symbol_needs_eval_context::get_addr_index): Likewise
7499 (disassemble_dwarf_expression): Add DW_OP_addrx
7500 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7501 (read_cutu_die_from_dwo): Update comment
7502 (skip_one_die): Add DW_FORM_addrx
7503 (read_attribute_value): Likewise
7504 (var_decode_location): Add DW_OP_addrx
7505 (dwarf2_const_value_attr): Add DW_FORM_addrx
7506 (dump_die_shallow): Likewise
7507 (dwarf2_fetch_constant_bytes): Likewise
7508 (decode_locdesc): Add DW_OP_addrx
7509 (skip_form_bytes): Add DW_FORM_addrx
7511 2019-04-22 Ali Tamur <tamur@google.com>
7513 * MAINTAINERS (Write After Approval): Add self.
7515 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
7517 * solib-svr4.c (get_svr4_info): Add pspace parameter.
7518 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7519 (open_symbol_file_object): Likewise.
7520 (svr4_default_sos): Add info parameter.
7521 (svr4_read_so_list): Likewise.
7522 (svr4_current_sos_direct): Adjust functions calls to pass down
7524 (svr4_current_sos_1): Add info parameter.
7525 (svr4_current_sos): Call get_svr4_info, pass info down to
7527 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7529 (svr4_in_dynsym_resolve_code): Pass current_program_space to
7531 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7533 (probes_table_remove_objfile_probes): Likewise.
7534 (register_solib_event_probe): Add info parameter.
7535 (solist_update_incremental): Pass info parameter down to
7537 (disable_probes_interface): Add info parameter.
7538 (svr4_handle_solib_event): Pass current_program_space to
7539 get_svr4_info. Adjust disable_probes_interface cleanup.
7540 (svr4_create_probe_breakpoints): Add info parameter, pass it
7541 down to register_solib_event_probe.
7542 (svr4_create_solib_event_breakpoints): Add info parameter,
7543 pass it down to svr4_create_probe_breakpoints.
7544 (enable_break): Pass info down to
7545 svr4_create_solib_event_breakpoints.
7546 (svr4_solib_create_inferior_hook): Pass current_program_space to
7548 (svr4_clear_solib): Likewise.
7550 2019-04-22 Pedro Alves <palves@redhat.com>
7552 * solib-svr4.c (svr4_free_objfile_observer): New.
7553 (probe_and_action::objfile): New field.
7554 (probes_table_htab_remove_objfile_probes)
7555 (probes_table_remove_objfile_probes): New functions.
7556 (register_solib_event_probe): Add 'objfile' parameter. Store it
7557 in the new probe_and_action. Don't store the probe in 'lookup'.
7558 (svr4_create_probe_breakpoints): Pass objfile to
7559 register_solib_event_probe.
7560 (_initialize_svr4_solib): Register a free_objfile observer.
7562 2019-04-19 Tom Tromey <tom@tromey.com>
7564 * common/queue.h: Remove.
7566 2019-04-19 Tom Tromey <tom@tromey.com>
7568 * event-loop.c: Don't include "common/queue.h".
7570 2019-04-19 Tom Tromey <tom@tromey.com>
7572 * remote.c (remote_target): Use delete.
7573 * remote-notif.h: Include <list>, not "common/queue.h".
7574 (notif_client_p): Remove typedef.
7575 (remote_notif_state): Add constructor, destructor, initializer.
7576 <notif_queue>: Now a std::list.
7577 (remote_notif_state_xfree): Don't declare.
7578 * remote-notif.c (remote_notif_process, handle_notification)
7579 (remote_notif_state_allocate): Update.
7580 (~remote_notif_state): Rename from remote_notif_state_xfree.
7582 2019-04-19 Tom Tromey <tom@tromey.com>
7584 * symfile.c (reread_symbols): Update.
7585 * objfiles.c (objfile_register_static_link)
7586 (objfile_lookup_static_link): Update
7587 (~objfile) Don't delete static_links.
7588 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7590 2019-04-19 Tom Tromey <tom@tromey.com>
7592 * type-stack.h (struct type_stack) <insert>: Constify string.
7593 * type-stack.c (type_stack::insert): Constify string.
7594 * gdbtypes.h (lookup_template_type): Update.
7595 (address_space_name_to_int): Update.
7596 * gdbtypes.c (address_space_name_to_int): Make space_identifier
7598 (lookup_template_type): Make name const.
7599 * c-exp.y: Update rules.
7600 (lex_one_token, classify_name, classify_inner_name)
7601 (c_print_token): Update.
7602 * p-exp.y: Update rules.
7604 * f-exp.y: Update rules.
7606 * d-exp.y: Update rules.
7607 (lex_one_token, classify_name, classify_inner_name): Update.
7608 * parse.c (write_dollar_variable, copy_name): Return std::string.
7609 * parser-defs.h (copy_name): Change return type.
7610 * m2-exp.y: Update rules.
7612 * go-exp.y (lex_one_token): Update.
7614 (classify_unsafe_function, classify_packaged_name)
7615 (classify_name, yylex): Update.
7617 2019-04-19 Sergei Trofimovich <siarheit@google.com>
7619 * configure.ac: add --enable-source-highlight switch.
7620 * configure: Regenerate.
7621 * top.c (print_gdb_version): plumb --enable-source-highlight
7622 status to "show configuration".
7624 2019-04-19 Tom Tromey <tromey@adacore.com>
7626 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7628 (empty_record, ada_template_to_fixed_record_type_1)
7629 (template_to_static_fixed_type)
7630 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7631 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7632 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7635 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
7638 * source.c (print_source_lines_base): Advance "iter" when a
7639 control character is seen.
7641 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7643 * inferior.h (struct infcall_suspend_state_deleter):
7644 Catch exception in destructor to avoid crash.
7646 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7648 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7649 close to the add_com "shell".
7651 2019-04-18 Tom Tromey <tromey@adacore.com>
7653 * process-stratum-target.h (class process_stratum_target)
7654 <stratum>: Add "final".
7656 2019-04-17 Tom Tromey <tromey@adacore.com>
7658 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7659 against nullptr before use.
7661 2019-04-17 Alan Hayward <alan.hayward@arm.com>
7663 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7665 2019-04-17 Jim Wilson <jimw@sifive.com>
7666 Andrew Burgess <andrew.burgess@embecosm.com>
7668 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7669 code read might fail, assume 4-byte breakpoint in that case.
7671 2019-04-15 Leszek Swirski <leszeks@google.com>
7673 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7674 rather than a hand-rolled POD check when checking for forced MEMORY
7677 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7679 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7680 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7682 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7683 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7684 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7687 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7689 * aarch64-linux-nat.c
7690 (aarch64_linux_nat_target::thread_architecture): Add override.
7691 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7694 2019-04-15 Alan Hayward <alan.hayward@arm.com>
7696 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7698 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
7700 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7701 target types of size 96-bits, add some additional comments, and
7702 check that the builtin type we found was the correct size.
7704 2019-04-12 Eli Zaretskii <eliz@gnu.org>
7706 * utils.c (prompt_for_continue): Don't restore the styling at the
7707 end, as applied_style has the wrong value. This fixes styling in
7708 long lists of file names that are interrupted by the "Continue?"
7711 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
7713 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7714 * c-lang.c (c_language_defn): Likewise.
7715 (cplus_language_defn): Likewise.
7716 (asm_language_defn): Likewise.
7717 (minimal_language_defn): Likewise.
7718 * d-lang.c (d_language_defn): Likewise.
7719 * f-lang.c (f_language_defn): Likewise.
7720 * go-lang.c (go_language_defn): Likewise.
7721 * language.c (unknown_language_defn): Likewise.
7722 (auto_language_defn): Likewise.
7723 * language.h (struct language_defn): Remove la_magic field.
7724 (LANG_MAGIC): Delete.
7725 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7726 * objc-lang.c (objc_language_defn): Likewise.
7727 * opencl-lang.c (opencl_language_defn): Likewise.
7728 * p-lang.c (pascal_language_defn): Likewise.
7729 * rust-lang.c (rust_language_defn): Likewise.
7731 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7733 * riscv-tdep.c (riscv_type_align): New function.
7734 (riscv_type_alignment): Delete.
7735 (riscv_arg_location): Use 'type_align'.
7736 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7738 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7740 * gdbtypes.c (type_align): A struct with no non-static fields also
7743 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7745 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7747 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7749 (riscv_struct_info::analyse): New implementation using new
7750 analyse_inner member function.
7751 (riscv_struct_info::field_offset): New member function.
7752 (riscv_struct_info::m_offsets): New member variable.
7753 (riscv_struct_info::analyse_inner): New private member function,
7754 takes the old implementation of riscv_struct_info::analyse but
7755 extended to track field offsets.
7756 (riscv_call_arg_struct): Update the struct folding special cases
7757 to handle cases where empty C++ structs, which are non-zero
7759 (riscv_arg_location): Initialise the length of each location, a
7760 non-zero length now indicates the location is in use.
7761 (riscv_push_dummy_call): Allow for the first location having a
7762 non-zero offset when setting up arguments.
7763 (riscv_return_value): Likewise, but for return values.
7765 2019-04-11 Tom Tromey <tromey@adacore.com>
7767 * utils.c (internal_vproblem): Make "msg" const.
7769 2019-04-11 Alan Hayward <alan.hayward@arm.com>
7771 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7772 * trad-frame.c (trad_frame_reset_saved_regs): New function.
7773 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7774 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7776 2019-04-10 Kevin Buettner <kevinb@redhat.com>
7778 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7780 (fill_gregset): Call amd64_linux_collect_native_gregset instead
7781 of amd64_collect_native_gregset.
7782 (amd64_linux_nat_target::store_registers): Likewise.
7784 2019-04-10 Tom Tromey <tom@tromey.com>
7786 * symtab.c (lookup_global_symbol_from_objfile)
7787 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7788 * objfiles.h (class separate_debug_iterator): New.
7789 (class separate_debug_range): New.
7790 (struct objfile) <separate_debug_objfiles>: New method.
7791 (objfile_separate_debug_iterate): Don't declare.
7792 * objfiles.c (separate_debug_iterator::operator++): Rename from
7793 objfile_separate_debug_iterate.
7794 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7796 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7799 2019-04-10 Tom Tromey <tom@tromey.com>
7801 * symfile.c (reread_symbols): Remove old comment.
7802 * objfiles.c (free_all_objfiles): Fix a typo.
7804 2019-04-10 Tom Tromey <tom@tromey.com>
7806 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7807 * minsyms.c (lookup_minimal_symbol): Use foreach.
7808 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7809 (lookup_minimal_symbol_solib_trampoline): Likewise.
7810 * symfile.c (reread_symbols): Use foreach.
7812 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
7813 Tom Tromey <tromey@adacore.com>
7816 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7817 (rust_lex_int_test): Change "value" to be LONGEST.
7818 (rust_lex_tests): Add test for long integer literal.
7820 2019-04-09 Tom Tromey <tromey@adacore.com>
7822 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7824 (extended_remote_target::attach): Update.
7825 (remote_target::remote_notice_new_inferior): Update.
7826 (remote_target::add_current_inferior_and_thread): Update.
7827 * inferior.c (exit_inferior_1): Use "false".
7828 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7830 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
7832 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7833 the "start" command.
7835 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7837 * python/py-inferior.c (infpy_thread_from_thread_handle):
7838 Adjust comments to reflect renaming of thread_from_thread_handle
7839 to thread_from_handle. Adjust keywords. Fix type error message.
7840 (inferior_object_methods): Add thread_from_handle. Retain
7841 thread_from_thread_handle, but mark it as deprecated.
7843 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7845 * gdbthread.h (find_thread_by_handle): Revise declaration.
7846 * thread.c (find_thread_by_handle): Likewise. Adjust
7848 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7849 support for buffer objects as handles.
7851 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7853 * python/py-infthread.c (thpy_thread_handle): New function.
7854 (thread_object_methods): Register thpy_thread_handle.
7856 2019-04-08 Kevin Buettner <kevinb@redhat.com>
7858 * gdbthread.h (thread_to_thread_handle): Declare.
7859 * thread.c (gdbtypes.h): Include.
7860 (thread_to_thread_handle): New function.
7862 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7863 (target_thread_info_to_thread_handle): Declare.
7864 * target.c (target_thread_info_to_thread_handle): New function.
7865 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7866 * target-delegates.c: Regenerate.
7868 * linux-thread-db.c (class thread_db_target): Add method
7869 thread_info_to_thread_handle.
7870 (thread_db_target::thread_info_to_thread_handle): Define.
7871 * remote.c (class remote_target): Add new method
7872 thread_info_to_thread_handle.
7873 (remote_target::thread_info_to_thread_handle): Define.
7875 2019-04-08 Pedro Alves <palves@redhat.com>
7877 * common/common-exceptions.c (throw_exception): Don't create
7878 named object to throw; throw directly.
7879 (throw_it): Likewise. Don't initialize gdb_exception::message
7880 here, with new; pass FMT and AP to the ctor instead.
7881 * common/common-exceptions.h: Include <string>.
7882 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7883 const char *, va_list)): New ctor. Use std::make_shared.
7884 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7886 (gdb_exception_error::gdb_exception_error(enum errors, const char
7888 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7890 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7892 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7893 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7896 2019-04-08 Tom Tromey <tom@tromey.com>
7898 * valops.c (value_rtti_indirect_type): Replace throw_exception
7900 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7902 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7904 * target.c (target_translate_tls_address): Replace throw_exception
7906 * stack.c (frame_apply_command_count): Replace throw_exception
7908 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7910 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7912 * rs6000-tdep.c (rs6000_frame_cache)
7913 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7914 * remote.c: Replace throw_exception with throw.
7915 * record-full.c (record_full_message, record_full_wait_1)
7916 (record_full_restore): Replace throw_exception with throw.
7918 (get_thread_current_frame_id, record_btrace_start_replaying)
7919 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7920 (cmd_record_btrace_start): Replace throw_exception with throw.
7921 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7923 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7924 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7926 (find_linespec_symbols): Replace throw_exception with throw.
7927 * infrun.c (displaced_step_prepare, resume): Replace
7928 throw_exception with throw.
7929 * infcmd.c (post_create_inferior): Replace throw_exception with
7931 * inf-loop.c (inferior_event_handler): Replace throw_exception
7933 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7934 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7935 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7936 (get_prev_frame_always, get_frame_pc_if_available)
7937 (get_frame_address_in_block_if_available, get_frame_language):
7938 Replace throw_exception with throw.
7939 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7940 throw_exception with throw.
7941 * eval.c (fetch_subexp_value, evaluate_var_value)
7942 (evaluate_funcall, evaluate_subexp_standard): Replace
7943 throw_exception with throw.
7944 * dwarf2loc.c (call_site_find_chain)
7945 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7946 Replace throw_exception with throw.
7947 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7949 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7951 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7952 * completer.c (complete_line_internal): Replace throw_exception
7954 * compile/compile-object-run.c (compile_object_run): Replace
7955 throw_exception with throw.
7956 * cli/cli-script.c (process_next_line): Replace throw_exception
7958 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7959 (btrace_enable, btrace_maint_update_pt_packets): Replace
7960 throw_exception with throw.
7961 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7962 throw_exception with throw.
7963 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7964 throw_exception with throw.
7965 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7966 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7967 * aarch64-tdep.c (aarch64_make_prologue_cache)
7968 (aarch64_make_stub_cache): Replace throw_exception with throw.
7970 2019-04-08 Tom Tromey <tom@tromey.com>
7972 * common/common-exceptions.c (throw_exception): Rename from
7973 throw_exception_cxx. Remove old copy. Make argument const.
7974 (throw_it): Create and throw exception objects directly.
7975 * common/common-exceptions.h (throw_exception): Make argument
7977 (struct gdb_exception_error): Add constructor.
7978 (struct gdb_exception_quit): Add constructor.
7980 2019-04-08 Tom Tromey <tom@tromey.com>
7982 * common/common-exceptions.h (exception_rethrow): Don't declare.
7983 (TRY_SJLJ): Update comment.
7984 (TRY, CATCH, END_CATCH): Remove.
7985 * common/common-exceptions.c (exception_rethrow): Remove.
7987 2019-04-08 Tom Tromey <tom@tromey.com>
7989 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7991 (gdb_exception_error): Rename from
7992 gdb_exception_RETURN_MASK_ERROR.
7993 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7994 (gdb_quit_bad_alloc): Update.
7995 * aarch64-tdep.c: Update.
7996 * ada-lang.c: Update.
7997 * ada-typeprint.c: Update.
7998 * ada-valprint.c: Update.
7999 * amd64-tdep.c: Update.
8000 * arch-utils.c: Update.
8001 * break-catch-throw.c: Update.
8002 * breakpoint.c: Update.
8004 * c-varobj.c: Update.
8005 * cli/cli-cmds.c: Update.
8006 * cli/cli-interp.c: Update.
8007 * cli/cli-script.c: Update.
8008 * common/common-exceptions.c: Update.
8009 * common/new-op.c: Update.
8010 * common/selftest.c: Update.
8011 * compile/compile-c-symbols.c: Update.
8012 * compile/compile-cplus-symbols.c: Update.
8013 * compile/compile-object-load.c: Update.
8014 * compile/compile-object-run.c: Update.
8015 * completer.c: Update.
8016 * corelow.c: Update.
8018 * cp-support.c: Update.
8019 * cp-valprint.c: Update.
8020 * darwin-nat.c: Update.
8021 * disasm-selftests.c: Update.
8022 * dtrace-probe.c: Update.
8023 * dwarf-index-cache.c: Update.
8024 * dwarf-index-write.c: Update.
8025 * dwarf2-frame-tailcall.c: Update.
8026 * dwarf2-frame.c: Update.
8027 * dwarf2loc.c: Update.
8028 * dwarf2read.c: Update.
8030 * event-loop.c: Update.
8031 * event-top.c: Update.
8033 * f-valprint.c: Update.
8034 * fbsd-tdep.c: Update.
8035 * frame-unwind.c: Update.
8037 * gdbtypes.c: Update.
8038 * gnu-v3-abi.c: Update.
8039 * guile/guile-internal.h: Update.
8040 * guile/scm-block.c: Update.
8041 * guile/scm-breakpoint.c: Update.
8042 * guile/scm-cmd.c: Update.
8043 * guile/scm-disasm.c: Update.
8044 * guile/scm-frame.c: Update.
8045 * guile/scm-lazy-string.c: Update.
8046 * guile/scm-math.c: Update.
8047 * guile/scm-param.c: Update.
8048 * guile/scm-ports.c: Update.
8049 * guile/scm-pretty-print.c: Update.
8050 * guile/scm-symbol.c: Update.
8051 * guile/scm-symtab.c: Update.
8052 * guile/scm-type.c: Update.
8053 * guile/scm-value.c: Update.
8054 * i386-linux-tdep.c: Update.
8055 * i386-tdep.c: Update.
8056 * inf-loop.c: Update.
8057 * infcall.c: Update.
8061 * language.c: Update.
8062 * linespec.c: Update.
8063 * linux-fork.c: Update.
8064 * linux-nat.c: Update.
8065 * linux-tdep.c: Update.
8066 * linux-thread-db.c: Update.
8068 * mi/mi-cmd-break.c: Update.
8069 * mi/mi-cmd-stack.c: Update.
8070 * mi/mi-interp.c: Update.
8071 * mi/mi-main.c: Update.
8072 * objc-lang.c: Update.
8073 * p-valprint.c: Update.
8075 * ppc-linux-tdep.c: Update.
8076 * printcmd.c: Update.
8077 * python/py-arch.c: Update.
8078 * python/py-breakpoint.c: Update.
8079 * python/py-cmd.c: Update.
8080 * python/py-finishbreakpoint.c: Update.
8081 * python/py-frame.c: Update.
8082 * python/py-framefilter.c: Update.
8083 * python/py-gdb-readline.c: Update.
8084 * python/py-inferior.c: Update.
8085 * python/py-infthread.c: Update.
8086 * python/py-lazy-string.c: Update.
8087 * python/py-linetable.c: Update.
8088 * python/py-objfile.c: Update.
8089 * python/py-param.c: Update.
8090 * python/py-prettyprint.c: Update.
8091 * python/py-progspace.c: Update.
8092 * python/py-record-btrace.c: Update.
8093 * python/py-record.c: Update.
8094 * python/py-symbol.c: Update.
8095 * python/py-type.c: Update.
8096 * python/py-unwind.c: Update.
8097 * python/py-utils.c: Update.
8098 * python/py-value.c: Update.
8099 * python/python.c: Update.
8100 * record-btrace.c: Update.
8101 * record-full.c: Update.
8102 * remote-fileio.c: Update.
8104 * riscv-tdep.c: Update.
8105 * rs6000-aix-tdep.c: Update.
8106 * rs6000-tdep.c: Update.
8107 * rust-exp.y: Update.
8108 * rust-lang.c: Update.
8109 * s390-tdep.c: Update.
8110 * selftest-arch.c: Update.
8111 * solib-dsbt.c: Update.
8112 * solib-frv.c: Update.
8113 * solib-spu.c: Update.
8114 * solib-svr4.c: Update.
8116 * sparc64-linux-tdep.c: Update.
8118 * symfile-mem.c: Update.
8119 * symmisc.c: Update.
8123 * tracefile-tfile.c: Update.
8124 * tui/tui.c: Update.
8125 * typeprint.c: Update.
8126 * unittests/cli-utils-selftests.c: Update.
8127 * unittests/parse-connection-spec-selftests.c: Update.
8129 * valprint.c: Update.
8132 * windows-nat.c: Update.
8133 * x86-linux-nat.c: Update.
8134 * xml-support.c: Update.
8136 2019-04-08 Tom Tromey <tom@tromey.com>
8138 * xml-support.c: Use C++ exception handling.
8139 * x86-linux-nat.c: Use C++ exception handling.
8140 * windows-nat.c: Use C++ exception handling.
8141 * varobj.c: Use C++ exception handling.
8142 * value.c: Use C++ exception handling.
8143 * valprint.c: Use C++ exception handling.
8144 * valops.c: Use C++ exception handling.
8145 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8147 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8148 * typeprint.c: Use C++ exception handling.
8149 * tui/tui.c: Use C++ exception handling.
8150 * tracefile-tfile.c: Use C++ exception handling.
8151 * top.c: Use C++ exception handling.
8152 * thread.c: Use C++ exception handling.
8153 * target.c: Use C++ exception handling.
8154 * symmisc.c: Use C++ exception handling.
8155 * symfile-mem.c: Use C++ exception handling.
8156 * stack.c: Use C++ exception handling.
8157 * sparc64-linux-tdep.c: Use C++ exception handling.
8158 * solib.c: Use C++ exception handling.
8159 * solib-svr4.c: Use C++ exception handling.
8160 * solib-spu.c: Use C++ exception handling.
8161 * solib-frv.c: Use C++ exception handling.
8162 * solib-dsbt.c: Use C++ exception handling.
8163 * selftest-arch.c: Use C++ exception handling.
8164 * s390-tdep.c: Use C++ exception handling.
8165 * rust-lang.c: Use C++ exception handling.
8166 * rust-exp.y: Use C++ exception handling.
8167 * rs6000-tdep.c: Use C++ exception handling.
8168 * rs6000-aix-tdep.c: Use C++ exception handling.
8169 * riscv-tdep.c: Use C++ exception handling.
8170 * remote.c: Use C++ exception handling.
8171 * remote-fileio.c: Use C++ exception handling.
8172 * record-full.c: Use C++ exception handling.
8173 * record-btrace.c: Use C++ exception handling.
8174 * python/python.c: Use C++ exception handling.
8175 * python/py-value.c: Use C++ exception handling.
8176 * python/py-utils.c: Use C++ exception handling.
8177 * python/py-unwind.c: Use C++ exception handling.
8178 * python/py-type.c: Use C++ exception handling.
8179 * python/py-symbol.c: Use C++ exception handling.
8180 * python/py-record.c: Use C++ exception handling.
8181 * python/py-record-btrace.c: Use C++ exception handling.
8182 * python/py-progspace.c: Use C++ exception handling.
8183 * python/py-prettyprint.c: Use C++ exception handling.
8184 * python/py-param.c: Use C++ exception handling.
8185 * python/py-objfile.c: Use C++ exception handling.
8186 * python/py-linetable.c: Use C++ exception handling.
8187 * python/py-lazy-string.c: Use C++ exception handling.
8188 * python/py-infthread.c: Use C++ exception handling.
8189 * python/py-inferior.c: Use C++ exception handling.
8190 * python/py-gdb-readline.c: Use C++ exception handling.
8191 * python/py-framefilter.c: Use C++ exception handling.
8192 * python/py-frame.c: Use C++ exception handling.
8193 * python/py-finishbreakpoint.c: Use C++ exception handling.
8194 * python/py-cmd.c: Use C++ exception handling.
8195 * python/py-breakpoint.c: Use C++ exception handling.
8196 * python/py-arch.c: Use C++ exception handling.
8197 * printcmd.c: Use C++ exception handling.
8198 * ppc-linux-tdep.c: Use C++ exception handling.
8199 * parse.c: Use C++ exception handling.
8200 * p-valprint.c: Use C++ exception handling.
8201 * objc-lang.c: Use C++ exception handling.
8202 * mi/mi-main.c: Use C++ exception handling.
8203 * mi/mi-interp.c: Use C++ exception handling.
8204 * mi/mi-cmd-stack.c: Use C++ exception handling.
8205 * mi/mi-cmd-break.c: Use C++ exception handling.
8206 * main.c: Use C++ exception handling.
8207 * linux-thread-db.c: Use C++ exception handling.
8208 * linux-tdep.c: Use C++ exception handling.
8209 * linux-nat.c: Use C++ exception handling.
8210 * linux-fork.c: Use C++ exception handling.
8211 * linespec.c: Use C++ exception handling.
8212 * language.c: Use C++ exception handling.
8213 * jit.c: Use C++ exception handling.
8214 * infrun.c: Use C++ exception handling.
8215 * infcmd.c: Use C++ exception handling.
8216 * infcall.c: Use C++ exception handling.
8217 * inf-loop.c: Use C++ exception handling.
8218 * i386-tdep.c: Use C++ exception handling.
8219 * i386-linux-tdep.c: Use C++ exception handling.
8220 * guile/scm-value.c: Use C++ exception handling.
8221 * guile/scm-type.c: Use C++ exception handling.
8222 * guile/scm-symtab.c: Use C++ exception handling.
8223 * guile/scm-symbol.c: Use C++ exception handling.
8224 * guile/scm-pretty-print.c: Use C++ exception handling.
8225 * guile/scm-ports.c: Use C++ exception handling.
8226 * guile/scm-param.c: Use C++ exception handling.
8227 * guile/scm-math.c: Use C++ exception handling.
8228 * guile/scm-lazy-string.c: Use C++ exception handling.
8229 * guile/scm-frame.c: Use C++ exception handling.
8230 * guile/scm-disasm.c: Use C++ exception handling.
8231 * guile/scm-cmd.c: Use C++ exception handling.
8232 * guile/scm-breakpoint.c: Use C++ exception handling.
8233 * guile/scm-block.c: Use C++ exception handling.
8234 * guile/guile-internal.h: Use C++ exception handling.
8235 * gnu-v3-abi.c: Use C++ exception handling.
8236 * gdbtypes.c: Use C++ exception handling.
8237 * frame.c: Use C++ exception handling.
8238 * frame-unwind.c: Use C++ exception handling.
8239 * fbsd-tdep.c: Use C++ exception handling.
8240 * f-valprint.c: Use C++ exception handling.
8241 * exec.c: Use C++ exception handling.
8242 * event-top.c: Use C++ exception handling.
8243 * event-loop.c: Use C++ exception handling.
8244 * eval.c: Use C++ exception handling.
8245 * dwarf2read.c: Use C++ exception handling.
8246 * dwarf2loc.c: Use C++ exception handling.
8247 * dwarf2-frame.c: Use C++ exception handling.
8248 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8249 * dwarf-index-write.c: Use C++ exception handling.
8250 * dwarf-index-cache.c: Use C++ exception handling.
8251 * dtrace-probe.c: Use C++ exception handling.
8252 * disasm-selftests.c: Use C++ exception handling.
8253 * darwin-nat.c: Use C++ exception handling.
8254 * cp-valprint.c: Use C++ exception handling.
8255 * cp-support.c: Use C++ exception handling.
8256 * cp-abi.c: Use C++ exception handling.
8257 * corelow.c: Use C++ exception handling.
8258 * completer.c: Use C++ exception handling.
8259 * compile/compile-object-run.c: Use C++ exception handling.
8260 * compile/compile-object-load.c: Use C++ exception handling.
8261 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8262 * compile/compile-c-symbols.c: Use C++ exception handling.
8263 * common/selftest.c: Use C++ exception handling.
8264 * common/new-op.c: Use C++ exception handling.
8265 * cli/cli-script.c: Use C++ exception handling.
8266 * cli/cli-interp.c: Use C++ exception handling.
8267 * cli/cli-cmds.c: Use C++ exception handling.
8268 * c-varobj.c: Use C++ exception handling.
8269 * btrace.c: Use C++ exception handling.
8270 * breakpoint.c: Use C++ exception handling.
8271 * break-catch-throw.c: Use C++ exception handling.
8272 * arch-utils.c: Use C++ exception handling.
8273 * amd64-tdep.c: Use C++ exception handling.
8274 * ada-valprint.c: Use C++ exception handling.
8275 * ada-typeprint.c: Use C++ exception handling.
8276 * ada-lang.c: Use C++ exception handling.
8277 * aarch64-tdep.c: Use C++ exception handling.
8279 2019-04-08 Tom Tromey <tom@tromey.com>
8281 * xml-support.c (gdb_xml_parser::parse): Update.
8282 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8283 * value.c (show_convenience): Update.
8284 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8285 (test_parse_flags_qcs): Update.
8286 * thread.c (thr_try_catch_cmd): Update.
8287 * target.c (target_translate_tls_address): Update.
8288 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8289 (info_frame_command_core, frame_apply_command_count): Update.
8290 * rust-exp.y (rust_lex_exception_test): Update.
8291 * riscv-tdep.c (riscv_print_one_register_info): Update.
8292 * remote.c (remote_target::enable_btrace): Update.
8293 * record-btrace.c (record_btrace_enable_warn): Update.
8294 * python/py-utils.c (gdbpy_convert_exception): Update.
8295 * printcmd.c (do_one_display, print_variable_and_value): Update.
8296 * mi/mi-main.c (mi_print_exception): Update.
8297 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8298 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8299 * linux-nat.c (linux_nat_target::attach): Update.
8300 * linux-fork.c (class scoped_switch_fork_info): Update.
8301 * infrun.c (displaced_step_prepare): Update.
8302 * infcall.c (call_function_by_hand_dummy): Update.
8303 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8304 * gnu-v3-abi.c (print_one_vtable): Update.
8305 * frame.c (get_prev_frame_always): Update.
8306 * f-valprint.c (info_common_command_for_block): Update.
8307 * exec.c (try_open_exec_file): Update.
8308 * exceptions.c (print_exception, exception_print)
8309 (exception_fprintf, exception_print_same): Update.
8310 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8311 * dwarf-index-cache.c (index_cache::store)
8312 (index_cache::lookup_gdb_index): Update.
8313 * darwin-nat.c (maybe_cache_shell): Update.
8314 * cp-valprint.c (cp_print_value_fields): Update.
8315 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8316 (gcc_cplus_symbol_address): Update.
8317 * compile/compile-c-symbols.c (gcc_convert_symbol)
8318 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8319 * common/selftest.c: Update.
8320 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8322 (exception_try_scope_entry, exception_try_scope_exit): Don't
8324 (struct exception_try_scope): Remove.
8325 (TRY): Don't use exception_try_scope.
8326 (struct gdb_exception): Add constructor, operator=.
8328 (struct gdb_exception_RETURN_MASK_ALL)
8329 (struct gdb_exception_RETURN_MASK_ERROR)
8330 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8331 (struct gdb_quit_bad_alloc): Update.
8332 * common/common-exceptions.c (exception_none): Change
8334 (struct catcher) <state, exception>: Initialize inline.
8335 <prev>: Remove member.
8336 (current_catcher): Remove.
8337 (catchers): New global.
8338 (exceptions_state_mc_init): Simplify.
8339 (catcher_pop): Remove.
8340 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8341 (try_scope_depth, exception_try_scope_entry)
8342 (exception_try_scope_exit): Remove.
8343 (throw_exception_sjlj): Update.
8344 (exception_messages, exception_messages_size): Remove.
8345 (throw_it): Simplify.
8346 (gdb_exception_sliced_copy): Remove.
8347 (throw_exception_cxx): Update.
8348 * cli/cli-script.c (script_from_file): Update.
8349 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8351 * ada-valprint.c (ada_val_print): Update.
8352 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8353 (create_excep_cond_exprs): Update.
8355 2019-04-08 Tom Tromey <tom@tromey.com>
8357 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8358 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8359 (TRY, CATCH, END_CATCH): Remove some definitions.
8360 * common/common-exceptions.c: Don't use GDB_XCPT.
8361 (catcher_list_size): Remove.
8362 (throw_exception, throw_it): Simplify.
8364 2019-04-05 Tom Tromey <tom@tromey.com>
8366 Revert the header-sorting patch.
8367 * ft32-tdep.c: Revert.
8368 * frv-tdep.c: Revert.
8369 * frv-linux-tdep.c: Revert.
8371 * frame-unwind.c: Revert.
8372 * frame-base.c: Revert.
8373 * fork-child.c: Revert.
8374 * findvar.c: Revert.
8375 * findcmd.c: Revert.
8376 * filesystem.c: Revert.
8377 * filename-seen-cache.h: Revert.
8378 * filename-seen-cache.c: Revert.
8379 * fbsd-tdep.c: Revert.
8380 * fbsd-nat.h: Revert.
8381 * fbsd-nat.c: Revert.
8382 * f-valprint.c: Revert.
8383 * f-typeprint.c: Revert.
8385 * extension.h: Revert.
8386 * extension.c: Revert.
8387 * extension-priv.h: Revert.
8388 * expprint.c: Revert.
8391 * exceptions.c: Revert.
8392 * event-top.c: Revert.
8393 * event-loop.c: Revert.
8395 * elfread.c: Revert.
8396 * dwarf2read.h: Revert.
8397 * dwarf2read.c: Revert.
8398 * dwarf2loc.c: Revert.
8399 * dwarf2expr.h: Revert.
8400 * dwarf2expr.c: Revert.
8401 * dwarf2-frame.c: Revert.
8402 * dwarf2-frame-tailcall.c: Revert.
8403 * dwarf-index-write.h: Revert.
8404 * dwarf-index-write.c: Revert.
8405 * dwarf-index-common.c: Revert.
8406 * dwarf-index-cache.h: Revert.
8407 * dwarf-index-cache.c: Revert.
8408 * dummy-frame.c: Revert.
8409 * dtrace-probe.c: Revert.
8412 * disasm-selftests.c: Revert.
8413 * dictionary.c: Revert.
8414 * dicos-tdep.c: Revert.
8415 * demangle.c: Revert.
8418 * darwin-nat.h: Revert.
8419 * darwin-nat.c: Revert.
8420 * darwin-nat-info.c: Revert.
8421 * d-valprint.c: Revert.
8422 * d-namespace.c: Revert.
8425 * csky-tdep.c: Revert.
8426 * csky-linux-tdep.c: Revert.
8427 * cris-tdep.c: Revert.
8428 * cris-linux-tdep.c: Revert.
8429 * cp-valprint.c: Revert.
8430 * cp-support.c: Revert.
8431 * cp-namespace.c: Revert.
8433 * corelow.c: Revert.
8434 * corefile.c: Revert.
8435 * continuations.c: Revert.
8436 * completer.h: Revert.
8437 * completer.c: Revert.
8438 * complaints.c: Revert.
8439 * coffread.c: Revert.
8440 * coff-pe-read.c: Revert.
8441 * cli-out.h: Revert.
8442 * cli-out.c: Revert.
8443 * charset.c: Revert.
8444 * c-varobj.c: Revert.
8445 * c-valprint.c: Revert.
8446 * c-typeprint.c: Revert.
8448 * buildsym.c: Revert.
8449 * buildsym-legacy.c: Revert.
8450 * build-id.h: Revert.
8451 * build-id.c: Revert.
8453 * bsd-uthread.c: Revert.
8454 * breakpoint.h: Revert.
8455 * breakpoint.c: Revert.
8456 * break-catch-throw.c: Revert.
8457 * break-catch-syscall.c: Revert.
8458 * break-catch-sig.c: Revert.
8459 * blockframe.c: Revert.
8461 * bfin-tdep.c: Revert.
8462 * bfin-linux-tdep.c: Revert.
8463 * bfd-target.c: Revert.
8465 * ax-general.c: Revert.
8468 * avr-tdep.c: Revert.
8470 * auto-load.c: Revert.
8471 * arm-wince-tdep.c: Revert.
8472 * arm-tdep.c: Revert.
8473 * arm-symbian-tdep.c: Revert.
8474 * arm-pikeos-tdep.c: Revert.
8475 * arm-obsd-tdep.c: Revert.
8476 * arm-nbsd-tdep.c: Revert.
8477 * arm-nbsd-nat.c: Revert.
8478 * arm-linux-tdep.c: Revert.
8479 * arm-linux-nat.c: Revert.
8480 * arm-fbsd-tdep.c: Revert.
8481 * arm-fbsd-nat.c: Revert.
8482 * arm-bsd-tdep.c: Revert.
8483 * arch-utils.c: Revert.
8484 * arc-tdep.c: Revert.
8485 * arc-newlib-tdep.c: Revert.
8486 * annotate.h: Revert.
8487 * annotate.c: Revert.
8488 * amd64-windows-tdep.c: Revert.
8489 * amd64-windows-nat.c: Revert.
8490 * amd64-tdep.c: Revert.
8491 * amd64-sol2-tdep.c: Revert.
8492 * amd64-obsd-tdep.c: Revert.
8493 * amd64-obsd-nat.c: Revert.
8494 * amd64-nbsd-tdep.c: Revert.
8495 * amd64-nbsd-nat.c: Revert.
8496 * amd64-nat.c: Revert.
8497 * amd64-linux-tdep.c: Revert.
8498 * amd64-linux-nat.c: Revert.
8499 * amd64-fbsd-tdep.c: Revert.
8500 * amd64-fbsd-nat.c: Revert.
8501 * amd64-dicos-tdep.c: Revert.
8502 * amd64-darwin-tdep.c: Revert.
8503 * amd64-bsd-nat.c: Revert.
8504 * alpha-tdep.c: Revert.
8505 * alpha-obsd-tdep.c: Revert.
8506 * alpha-nbsd-tdep.c: Revert.
8507 * alpha-mdebug-tdep.c: Revert.
8508 * alpha-linux-tdep.c: Revert.
8509 * alpha-linux-nat.c: Revert.
8510 * alpha-bsd-tdep.c: Revert.
8511 * alpha-bsd-nat.c: Revert.
8512 * aix-thread.c: Revert.
8514 * addrmap.c: Revert.
8515 * ada-varobj.c: Revert.
8516 * ada-valprint.c: Revert.
8517 * ada-typeprint.c: Revert.
8518 * ada-tasks.c: Revert.
8519 * ada-lang.c: Revert.
8520 * aarch64-tdep.c: Revert.
8521 * aarch64-ravenscar-thread.c: Revert.
8522 * aarch64-newlib-tdep.c: Revert.
8523 * aarch64-linux-tdep.c: Revert.
8524 * aarch64-linux-nat.c: Revert.
8525 * aarch64-fbsd-tdep.c: Revert.
8526 * aarch64-fbsd-nat.c: Revert.
8527 * aarch32-linux-nat.c: Revert.
8529 2019-04-05 Tom Tromey <tom@tromey.com>
8531 * ft32-tdep.c: Sort headers.
8532 * frv-tdep.c: Sort headers.
8533 * frv-linux-tdep.c: Sort headers.
8534 * frame.c: Sort headers.
8535 * frame-unwind.c: Sort headers.
8536 * frame-base.c: Sort headers.
8537 * fork-child.c: Sort headers.
8538 * findvar.c: Sort headers.
8539 * findcmd.c: Sort headers.
8540 * filesystem.c: Sort headers.
8541 * filename-seen-cache.h: Sort headers.
8542 * filename-seen-cache.c: Sort headers.
8543 * fbsd-tdep.c: Sort headers.
8544 * fbsd-nat.h: Sort headers.
8545 * fbsd-nat.c: Sort headers.
8546 * f-valprint.c: Sort headers.
8547 * f-typeprint.c: Sort headers.
8548 * f-lang.c: Sort headers.
8549 * extension.h: Sort headers.
8550 * extension.c: Sort headers.
8551 * extension-priv.h: Sort headers.
8552 * expprint.c: Sort headers.
8553 * exec.h: Sort headers.
8554 * exec.c: Sort headers.
8555 * exceptions.c: Sort headers.
8556 * event-top.c: Sort headers.
8557 * event-loop.c: Sort headers.
8558 * eval.c: Sort headers.
8559 * elfread.c: Sort headers.
8560 * dwarf2read.h: Sort headers.
8561 * dwarf2read.c: Sort headers.
8562 * dwarf2loc.c: Sort headers.
8563 * dwarf2expr.h: Sort headers.
8564 * dwarf2expr.c: Sort headers.
8565 * dwarf2-frame.c: Sort headers.
8566 * dwarf2-frame-tailcall.c: Sort headers.
8567 * dwarf-index-write.h: Sort headers.
8568 * dwarf-index-write.c: Sort headers.
8569 * dwarf-index-common.c: Sort headers.
8570 * dwarf-index-cache.h: Sort headers.
8571 * dwarf-index-cache.c: Sort headers.
8572 * dummy-frame.c: Sort headers.
8573 * dtrace-probe.c: Sort headers.
8574 * disasm.h: Sort headers.
8575 * disasm.c: Sort headers.
8576 * disasm-selftests.c: Sort headers.
8577 * dictionary.c: Sort headers.
8578 * dicos-tdep.c: Sort headers.
8579 * demangle.c: Sort headers.
8580 * dcache.h: Sort headers.
8581 * dcache.c: Sort headers.
8582 * darwin-nat.h: Sort headers.
8583 * darwin-nat.c: Sort headers.
8584 * darwin-nat-info.c: Sort headers.
8585 * d-valprint.c: Sort headers.
8586 * d-namespace.c: Sort headers.
8587 * d-lang.c: Sort headers.
8588 * ctf.c: Sort headers.
8589 * csky-tdep.c: Sort headers.
8590 * csky-linux-tdep.c: Sort headers.
8591 * cris-tdep.c: Sort headers.
8592 * cris-linux-tdep.c: Sort headers.
8593 * cp-valprint.c: Sort headers.
8594 * cp-support.c: Sort headers.
8595 * cp-namespace.c: Sort headers.
8596 * cp-abi.c: Sort headers.
8597 * corelow.c: Sort headers.
8598 * corefile.c: Sort headers.
8599 * continuations.c: Sort headers.
8600 * completer.h: Sort headers.
8601 * completer.c: Sort headers.
8602 * complaints.c: Sort headers.
8603 * coffread.c: Sort headers.
8604 * coff-pe-read.c: Sort headers.
8605 * cli-out.h: Sort headers.
8606 * cli-out.c: Sort headers.
8607 * charset.c: Sort headers.
8608 * c-varobj.c: Sort headers.
8609 * c-valprint.c: Sort headers.
8610 * c-typeprint.c: Sort headers.
8611 * c-lang.c: Sort headers.
8612 * buildsym.c: Sort headers.
8613 * buildsym-legacy.c: Sort headers.
8614 * build-id.h: Sort headers.
8615 * build-id.c: Sort headers.
8616 * btrace.c: Sort headers.
8617 * bsd-uthread.c: Sort headers.
8618 * breakpoint.h: Sort headers.
8619 * breakpoint.c: Sort headers.
8620 * break-catch-throw.c: Sort headers.
8621 * break-catch-syscall.c: Sort headers.
8622 * break-catch-sig.c: Sort headers.
8623 * blockframe.c: Sort headers.
8624 * block.c: Sort headers.
8625 * bfin-tdep.c: Sort headers.
8626 * bfin-linux-tdep.c: Sort headers.
8627 * bfd-target.c: Sort headers.
8628 * bcache.c: Sort headers.
8629 * ax-general.c: Sort headers.
8630 * ax-gdb.h: Sort headers.
8631 * ax-gdb.c: Sort headers.
8632 * avr-tdep.c: Sort headers.
8633 * auxv.c: Sort headers.
8634 * auto-load.c: Sort headers.
8635 * arm-wince-tdep.c: Sort headers.
8636 * arm-tdep.c: Sort headers.
8637 * arm-symbian-tdep.c: Sort headers.
8638 * arm-pikeos-tdep.c: Sort headers.
8639 * arm-obsd-tdep.c: Sort headers.
8640 * arm-nbsd-tdep.c: Sort headers.
8641 * arm-nbsd-nat.c: Sort headers.
8642 * arm-linux-tdep.c: Sort headers.
8643 * arm-linux-nat.c: Sort headers.
8644 * arm-fbsd-tdep.c: Sort headers.
8645 * arm-fbsd-nat.c: Sort headers.
8646 * arm-bsd-tdep.c: Sort headers.
8647 * arch-utils.c: Sort headers.
8648 * arc-tdep.c: Sort headers.
8649 * arc-newlib-tdep.c: Sort headers.
8650 * annotate.h: Sort headers.
8651 * annotate.c: Sort headers.
8652 * amd64-windows-tdep.c: Sort headers.
8653 * amd64-windows-nat.c: Sort headers.
8654 * amd64-tdep.c: Sort headers.
8655 * amd64-sol2-tdep.c: Sort headers.
8656 * amd64-obsd-tdep.c: Sort headers.
8657 * amd64-obsd-nat.c: Sort headers.
8658 * amd64-nbsd-tdep.c: Sort headers.
8659 * amd64-nbsd-nat.c: Sort headers.
8660 * amd64-nat.c: Sort headers.
8661 * amd64-linux-tdep.c: Sort headers.
8662 * amd64-linux-nat.c: Sort headers.
8663 * amd64-fbsd-tdep.c: Sort headers.
8664 * amd64-fbsd-nat.c: Sort headers.
8665 * amd64-dicos-tdep.c: Sort headers.
8666 * amd64-darwin-tdep.c: Sort headers.
8667 * amd64-bsd-nat.c: Sort headers.
8668 * alpha-tdep.c: Sort headers.
8669 * alpha-obsd-tdep.c: Sort headers.
8670 * alpha-nbsd-tdep.c: Sort headers.
8671 * alpha-mdebug-tdep.c: Sort headers.
8672 * alpha-linux-tdep.c: Sort headers.
8673 * alpha-linux-nat.c: Sort headers.
8674 * alpha-bsd-tdep.c: Sort headers.
8675 * alpha-bsd-nat.c: Sort headers.
8676 * aix-thread.c: Sort headers.
8677 * agent.c: Sort headers.
8678 * addrmap.c: Sort headers.
8679 * ada-varobj.c: Sort headers.
8680 * ada-valprint.c: Sort headers.
8681 * ada-typeprint.c: Sort headers.
8682 * ada-tasks.c: Sort headers.
8683 * ada-lang.c: Sort headers.
8684 * aarch64-tdep.c: Sort headers.
8685 * aarch64-ravenscar-thread.c: Sort headers.
8686 * aarch64-newlib-tdep.c: Sort headers.
8687 * aarch64-linux-tdep.c: Sort headers.
8688 * aarch64-linux-nat.c: Sort headers.
8689 * aarch64-fbsd-tdep.c: Sort headers.
8690 * aarch64-fbsd-nat.c: Sort headers.
8691 * aarch32-linux-nat.c: Sort headers.
8693 2019-04-04 Tom Tromey <tom@tromey.com>
8695 * varobj.c (varobj_create): Update.
8696 * rust-exp.y (struct rust_parser) <update_innermost_block,
8697 lookup_symbol>: New methods.
8698 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8700 (rust_parser::rust_lookup_type)
8701 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8702 * printcmd.c (display_command, do_one_display): Update.
8703 * parser-defs.h (struct parser_state) <parser_state>: Add
8704 "tracker" parameter.
8705 (block_tracker): New member.
8706 (class innermost_block_tracker) <innermost_block_tracker>: Add
8708 <reset>: Remove method.
8709 (innermost_block): Don't declare.
8710 (null_post_parser): Update.
8711 * parse.c (innermost_block): Remove global.
8712 (write_dollar_variable): Update.
8713 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8714 Remove "tracker_types" parameter.
8715 (parse_expression): Add "tracker" parameter.
8716 (parse_expression_for_completion): Update.
8717 (null_post_parser): Add "tracker" parameter.
8718 * p-exp.y: Update rules.
8719 * m2-exp.y: Update rules.
8720 * language.h (struct language_defn) <la_post_parser>: Add
8721 "tracker" parameter.
8722 * go-exp.y: Update rules.
8723 * f-exp.y: Update rules.
8724 * expression.h (parse_expression, parse_exp_1): Add "tracker"
8726 * d-exp.y: Update rules.
8727 * c-exp.y: Update rules.
8728 * breakpoint.c (set_breakpoint_condition): Create an
8729 innermost_block_tracker.
8730 (watch_command_1): Likewise.
8731 * ada-lang.c (resolve): Add "tracker" parameter.
8732 (resolve_subexp): Likewise.
8733 * ada-exp.y (write_var_from_sym): Update.
8735 2019-04-04 Tom Tromey <tom@tromey.com>
8737 * type-stack.h: New file.
8738 * type-stack.c: New file.
8739 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8741 (insert_into_type_stack, insert_type, push_type, push_type_int)
8742 (insert_type_address_space, pop_type, pop_type_int)
8743 (pop_typelist, pop_type_stack, append_type_stack)
8744 (push_type_stack, get_type_stack, push_typelist)
8745 (follow_type_instance_flags, follow_types): Don't declare.
8746 * parse.c (type_stack): Remove global.
8747 (parse_exp_in_context): Update.
8748 (insert_into_type_stack, insert_type, push_type, push_type_int)
8749 (insert_type_address_space, pop_type, pop_type_int)
8750 (pop_typelist, pop_type_stack, append_type_stack)
8751 (push_type_stack, get_type_stack, push_typelist)
8752 (follow_type_instance_flags, follow_types): Remove (moved to
8754 * f-exp.y (type_stack): New global.
8756 (push_kind_type, f_parse): Update.
8757 * d-exp.y (type_stack): New global.
8760 * c-exp.y (struct c_parse_state) <type_stack>: New member.
8762 * Makefile.in (COMMON_SFILES): Add type-stack.c.
8763 (HFILES_NO_SRCDIR): Add type-stack.h.
8765 2019-04-04 Tom Tromey <tom@tromey.com>
8767 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8768 (rust_parser::convert_ast_to_expression, rust_parse)
8769 (rust_lex_test_completion, rust_lex_tests): Update.
8770 * parser-defs.h (struct expr_completion_state): New.
8771 (struct parser_state) <parser_state>: Add completion parameter.
8772 <mark_struct_expression, mark_completion_tag>: New methods.
8773 <parse_completion, m_completion_state>: New members.
8774 (prefixify_expression, null_post_parser): Update.
8775 (mark_struct_expression, mark_completion_tag): Don't declare.
8776 * parse.c (parse_completion, expout_last_struct)
8777 (expout_tag_completion_type, expout_completion_name): Remove
8779 (parser_state::mark_struct_expression)
8780 (parser_state::mark_completion_tag): Now methods.
8781 (prefixify_expression): Add last_struct parameter.
8782 (prefixify_subexp): Likewise.
8783 (parse_exp_1): Update.
8784 (parse_exp_in_context): Add cstate parameter. Update.
8785 (parse_expression_for_completion): Create an
8786 expr_completion_state.
8787 (null_post_parser): Add "completion" parameter.
8788 * p-exp.y: Update rules.
8790 * language.h (struct language_defn) <la_post_parser>: Add
8791 "completing" parameter.
8792 * go-exp.y: Update rules.
8793 (lex_one_token): Update.
8794 * expression.h (parse_completion): Don't declare.
8795 * d-exp.y: Update rules.
8796 (lex_one_token): Update rules.
8797 * c-exp.y: Update rules.
8798 (lex_one_token): Update.
8799 * ada-lang.c (resolve): Add "parse_completion" parameter.
8800 (resolve_subexp): Likewise.
8801 (ada_resolve_function): Likewise.
8803 2019-04-04 Tom Tromey <tom@tromey.com>
8805 * parser-defs.h (struct parser_state) <start_arglist,
8806 end_arglist>: New methods.
8807 <arglist_len, m_funcall_chain>: New members.
8808 (arglist_len, start_arglist, end_arglist): Don't declare.
8809 * parse.c (arglist_len, funcall_chain): Remove global.
8810 (start_arglist, end_arglist): Remove functions.
8811 (parse_exp_in_context): Update.
8812 * p-exp.y: Update rules.
8813 * m2-exp.y: Update rules.
8814 * go-exp.y: Update rules.
8815 * f-exp.y: Update rules.
8816 * d-exp.y: Update rules.
8817 * c-exp.y: Update rules.
8819 2019-04-04 Tom Tromey <tom@tromey.com>
8821 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8822 lex_operator, push_back>: New methods.
8824 (rust_parser::lex_hex, lex_escape): Rename and update.
8825 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8826 (rust_parser::lex_operator): Rename and update.
8827 (rust_parser::lex_number, rustyylex, rustyyerror)
8828 (rust_lex_test_init, rust_lex_test_sequence)
8829 (rust_lex_test_push_back, rust_lex_tests): Update.
8830 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8832 <lexptr, prev_lexptr>: New members.
8833 (lexptr, prev_lexptr): Don't declare.
8834 * parse.c (lexptr, prev_lexptr): Remove globals.
8835 (parse_exp_in_context): Update.
8836 * p-exp.y (yylex, yyerror): Update.
8837 * m2-exp.y (parse_number, yylex, yyerror): Update.
8838 * go-exp.y (lex_one_token, yyerror): Update.
8839 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8840 * d-exp.y (lex_one_token, yyerror): Update.
8841 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8842 (lex_one_token, yyerror): Update.
8843 * ada-lex.l (YY_INPUT): Update.
8844 (rewind_to_char): Update.
8845 * ada-exp.y (yyerror): Update.
8847 2019-04-04 Tom Tromey <tom@tromey.com>
8849 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8850 * parser-defs.h (struct parser_state) <parser_state>: Add new
8852 <comma_terminates>: New member.
8853 (comma_terminates): Don't declare global.
8854 * parse.c (comma_terminates): Remove global.
8855 (parse_exp_in_context): Update.
8856 * p-exp.y (yylex): Update.
8857 * m2-exp.y (yylex): Update.
8858 * go-exp.y (lex_one_token): Update.
8859 * f-exp.y (yylex): Update.
8860 * d-exp.y (lex_one_token): Update.
8861 * c-exp.y (lex_one_token): Update.
8862 * ada-lex.l: Update.
8864 2019-04-04 Tom Tromey <tom@tromey.com>
8866 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8867 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8868 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8869 * parser-defs.h (paren_depth): Don't declare.
8870 * parse.c (paren_depth): Remove global.
8871 (parse_exp_in_context): Update.
8872 * p-exp.y (paren_depth): New global.
8873 (pascal_parse): Initialize it.
8874 * m2-exp.y (paren_depth): New global.
8875 (m2_parse): Initialize it.
8876 * go-exp.y (paren_depth): New global.
8877 (go_parse): Initialize it.
8878 * f-exp.y (paren_depth): New global.
8879 (f_parse): Initialize it.
8880 * d-exp.y (paren_depth): New global.
8881 (d_parse): Initialize it.
8882 * c-exp.y (paren_depth): New global.
8883 (c_parse): Initialize it.
8884 * ada-lex.l (paren_depth): New global.
8885 (lexer_init): Initialize it.
8887 2019-04-04 Tom Tromey <tom@tromey.com>
8889 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8890 (rust_parser::convert_ast_to_type)
8891 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8892 * parser-defs.h (struct parser_state) <parser_state>: Add
8893 parameters. Initialize new members.
8894 <expression_context_block, expression_context_pc>: New members.
8895 * parse.c (expression_context_block, expression_context_pc):
8897 (parse_exp_in_context): Update.
8898 * p-exp.y: Update all rules.
8900 * m2-exp.y: Update all rules.
8902 * go-exp.y (yylex): Update.
8903 * f-exp.y (yylex): Update.
8904 * d-exp.y: Update all rules.
8906 * c-exp.y: Update all rules.
8907 (lex_one_token, classify_name, yylex, c_parse): Update.
8908 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8910 2019-04-04 Tom Tromey <tom@tromey.com>
8912 * gdbarch.h, gdbarch.c: Rebuild.
8913 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8915 (struct stap_parse_info): Replace "parser_state" with
8917 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8918 (parser_state): New class.
8919 * parse.c (expr_builder): Rename.
8920 (expr_builder::release): Rename.
8921 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8922 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8923 (write_exp_elt_longcst, write_exp_elt_floatcst)
8924 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8925 (write_exp_string_vector, write_exp_bitstring)
8926 (write_exp_msymbol, mark_struct_expression)
8927 (write_dollar_variable)
8928 (insert_type_address_space, increase_expout_size): Replace
8929 "parser_state" with "expr_builder".
8930 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8931 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8932 "parser_state" with "expr_builder".
8934 2019-04-04 Tom Tromey <tom@tromey.com>
8936 * rust-exp.y: Replace "parse_language" with method call.
8938 (yylex): Replace "parse_language" with method call.
8940 (yylex): Replace "parse_language" with method call.
8941 * go-exp.y (classify_name): Replace "parse_language" with method
8943 * f-exp.y (yylex): Replace "parse_language" with method call.
8944 * d-exp.y (lex_one_token): Replace "parse_language" with method
8947 (lex_one_token, classify_name, yylex): Replace "parse_language"
8949 * ada-exp.y (find_primitive_type, type_char)
8950 (type_system_address): Replace "parse_language" with method call.
8952 2019-04-04 Tom Tromey <tom@tromey.com>
8954 * rust-exp.y: Replace "parse_gdbarch" with method call.
8955 * parse.c (write_dollar_variable, insert_type_address_space):
8956 Replace "parse_gdbarch" with method call.
8957 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8959 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8961 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8962 "parse_gdbarch" with method call.
8963 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8965 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8966 "parse_gdbarch" with method call.
8967 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8968 "parse_gdbarch" with method call.
8969 * c-exp.y (parse_type, parse_number, classify_name): Replace
8970 "parse_gdbarch" with method call.
8971 * ada-lex.l: Replace "parse_gdbarch" with method call.
8972 * ada-exp.y (parse_type, find_primitive_type, type_char)
8973 (type_system_address): Replace "parse_gdbarch" with method call.
8975 2019-04-04 Tom Tromey <tom@tromey.com>
8977 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8978 * stap-probe.c (stap_parse_argument): Update.
8979 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8980 initial_size parameter.
8981 * rust-exp.y (rust_lex_tests): Update.
8982 * parse.c (parser_state): Update.
8983 (parse_exp_in_context): Update.
8984 * parser-defs.h (struct parser_state) <parser_state>: Remove
8985 "initial_size" parameter.
8987 2019-04-04 Tom Tromey <tom@tromey.com>
8989 * parser-defs.h (increase_expout_size): Don't declare.
8990 * parse.c (increase_expout_size): Now static.
8992 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8994 * gnu-nat.c (gnu_nat_target::wait): Fix
8995 target_waitstatus_to_string call.
8997 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8999 * eval.c (evaluate_subexp_standard): Handle internal functions
9000 during Fortran function call handling.
9002 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9004 * NEWS: Mention new internal functions.
9005 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9006 (read_base_type): Use dwarf2_init_complex_target_type.
9007 * value.c (creal_internal_fn): New function.
9008 (cimag_internal_fn): New function.
9009 (_initialize_values): Register new internal functions.
9011 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9013 * infrun.c (stop_all_threads): If debug_infrun, always
9014 trace the wait status after wait_one, using
9015 target_waitstatus_to_string and target_pid_to_str.
9016 (handle_inferior_event): Replace various trace of
9017 wait status kind by a single trace.
9018 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9019 wait status kind image by target_waitstatus_to_string.
9020 * target/waitstatus.c (target_waitstatus_to_string): Fix
9023 2019-04-01 Tom Tromey <tromey@adacore.com>
9026 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9028 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9029 Pedro Alves <palves@redhat.com>
9031 * top.c (quit_force): Call 'finalize_values'.
9032 * value.c (finalize_values): New function.
9033 * value.h (finalize_values): Declare.
9035 2019-03-30 Eli Zaretskii <eliz@gnu.org>
9037 * NEWS: Announce $_gdb_major and $_gdb_minor.
9039 * top.c (init_gdb_version_vars): New function.
9040 (gdb_init): Call init_gdb_version_vars.
9042 2019-03-29 Tom Tromey <tromey@adacore.com>
9044 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9045 help text. Remove dead code.
9047 2019-03-29 Keith Seitz <keiths@redhat.com>
9049 From Siddhesh Poyarekar:
9050 * f-lang.h (f77_get_upperbound): Return LONGEST.
9051 (f77_get_lowerbound): Likewise.
9052 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9053 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9055 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9056 plongest to format print it.
9057 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9058 (f77_get_upperbound): Likewise.
9059 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9060 LOWER_BOUND to LONGEST.
9061 (f77_create_arrayprint_offset_tbl): Likewise.
9063 2019-03-29 Keith Seitz <keiths@redhat.com>
9065 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9066 %s/pulongest for TYPE_LENGTH instead of %d in format
9068 * ada-typerint.c (ada_print_type): Likewise.
9069 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9070 * compile/compile-c-support.c (generate_register_struct): Likewise.
9071 * gdbtypes.c (recursive_dump_type): Likewise.
9072 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9073 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9074 instead of %d in format strings.
9075 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9076 to std::min to ULONGEST.
9077 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9078 instead of %d in format strings.
9079 * tracepoint.c (info_scope_command): Likewise.
9080 * typeprint.c (print_offset_data::update)
9081 (print_offset_data::finish): Likewise.
9082 * xtensa-tdep.c (xtensa_store_return_value)
9083 (xtensa_push_dummy_call): Likewise.
9085 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9087 * windows-nat.c (display_selector): Fixed format specifications
9090 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9092 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9094 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9096 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9097 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9098 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9099 (nios2_linux_init_abi): Install it.
9101 2019-03-28 Alan Hayward <alan.hayward@arm.com>
9103 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9105 2019-03-28 Alan Hayward <alan.hayward@arm.com>
9107 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9109 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9110 Tom Tromey <tromey@adacore.com>
9112 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9114 2019-03-26 Joel Brobecker <brobecker@adacore.com>
9116 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9117 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9118 method to compute the bounds of range types. Also print "[evaluated]"
9119 if the bounds' values come from a dynamic evaluation.
9121 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9123 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9124 whitespace when pretty printing is on.
9126 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9128 * ppc-linux-nat.c: Add include.
9130 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9132 * NEWS: Mention AArch64 Pointer Authentication.
9134 2019-03-26 Alan Hayward <alan.hayward@arm.com>
9136 * arm-linux-nat.c: Add include.
9138 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9140 * source-cache.c (source_cache::get_source_lines): Re-read
9141 fullname after calling open_source_file.
9143 2019-03-25 John Baldwin <jhb@FreeBSD.org>
9145 * NEWS: Mention TLS support for FreeBSD.
9147 2019-03-25 Tom Tromey <tromey@adacore.com>
9149 * minsyms.c (BUNCH_SIZE): Update comment.
9150 (~minimal_symbol_reader): Remove old comment.
9151 (compact_minimal_symbols): Update comment.
9152 (minimal_symbol_reader::install): Remove old comment. Update
9155 2019-03-25 Alan Hayward <alan.hayward@arm.com>
9157 * s390-linux-nat.c: Add include.
9159 2019-03-25 Alan Hayward <alan.hayward@arm.com>
9161 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9162 Call linux_get_hwcap.
9163 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9165 (aarch64_linux_get_hwcap): Remove function.
9166 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9168 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9170 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9171 * linux-tdep.c (linux_get_hwcap): Add function.
9172 (linux_get_hwcap2): Likewise.
9173 * linux-tdep.h (linux_get_hwcap): Add declaration.
9174 (linux_get_hwcap2): Likewise.
9175 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9176 (ppc_linux_get_hwcap2): Likewise.
9177 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9179 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9180 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9181 (ppc_linux_nat_target::read_description): Likewise.
9182 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9183 * s390-linux-nat.c: Likewise.
9184 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9186 2019-03-24 Tom Tromey <tom@tromey.com>
9188 * ada-lang.c (standard_lookup): Simplify initialization.
9189 (ada_lookup_symbol_nonlocal): Simplify return.
9190 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9191 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9192 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9193 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9195 * solib.c (solib_global_lookup): Simplify.
9196 * symtab.c (null_block_symbol): Remove.
9197 (symbol_cache_lookup): Simplify returns.
9198 (lookup_language_this): Simplify returns.
9199 (lookup_symbol_aux): Simplify return.
9200 (lookup_local_symbol): Simplify returns.
9201 (lookup_global_symbol_from_objfile): Simplify return.
9202 (lookup_symbol_in_objfile_symtabs)
9203 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9204 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9205 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9206 * cp-namespace.c (cp_lookup_bare_symbol)
9207 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9208 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9209 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9210 (cp_lookup_symbol_via_imports): Simplify initialization.
9211 (find_symbol_in_baseclass): Likewise.
9212 * symtab.h (null_block_symbol): Remove.
9213 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9214 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9215 (d_lookup_symbol_module): Likewise.
9216 (find_symbol_in_baseclass): Simplify initialization.
9218 2019-03-24 Tom Tromey <tom@tromey.com>
9220 * expression.h: Don't include symtab.h.
9221 (struct block): Forward declare.
9223 2019-03-24 Tom Tromey <tom@tromey.com>
9225 * c-exp.y (typebase): Remove casts.
9226 * gdbtypes.c (lookup_unsigned_typename, )
9227 (lookup_signed_typename): Remove cast.
9228 * eval.c (parse_to_comma_and_eval): Remove cast.
9229 * parse.c (write_dollar_variable): Remove cast.
9230 * block.h (struct block) <superblock>: Now const.
9231 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9232 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9233 (map_block): Make "block" const.
9234 * symfile.h (struct quick_symbol_functions)
9235 <map_matching_symbols>: Constify block argument to "callback".
9236 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9238 (find_pc_sect_compunit_symtab): Make "b" const.
9239 (find_symbol_at_address): Likewise.
9240 (search_symbols): Likewise.
9241 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9242 (dw2_debug_names_lookup_symbol): Likewise.
9243 (dw2_map_matching_symbols): Update.
9244 * p-valprint.c (pascal_val_print): Remove "block".
9245 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9246 (aux_add_nonlocal_symbols): Make "block" const.
9247 (resolve_subexp): Remove cast.
9248 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9250 (iterate_over_file_blocks): Likewise.
9251 * f-exp.y (%union) <bval>: Remove.
9252 * coffread.c (patch_opaque_types): Make "b" const.
9253 * spu-tdep.c (spu_catch_start): Make "block" const.
9254 * c-valprint.c (print_unpacked_pointer): Remove "block".
9255 * symmisc.c (dump_symtab_1): Make "b" const.
9256 (block_depth): Make "block" const.
9257 * d-exp.y (%union) <bval>: Remove.
9258 * cp-support.h (cp_lookup_rtti_type): Update.
9259 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9260 * psymtab.c (psym_lookup_symbol): Make "block" const.
9261 (maintenance_check_psymtabs): Make "b" const.
9262 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9263 (enumerate_locals, enumerate_args): Update.
9264 * python/py-symtab.c (stpy_global_block): Make "block" const.
9265 (stpy_static_block): Likewise.
9266 * inline-frame.c (block_starting_point_at): Make "new_block"
9268 * block.c (find_block_in_blockvector): Make return type const.
9269 (blockvector_for_pc_sect): Make "b" const.
9270 (find_block_in_blockvector): Make "b" const.
9272 2019-03-23 Tom Tromey <tom@tromey.com>
9274 * varobj.c (varobj_create): Update.
9275 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9276 * printcmd.c (display_command, do_one_display): Don't reset
9278 * parser-defs.h (enum innermost_block_tracker_type): Move to
9280 (innermost_block): Update comment.
9281 * parse.c (parse_exp_1): Add tracker_types parameter.
9282 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9283 tracker_types parameter. Reset innermost_block.
9284 (parse_exp_in_context): Remove.
9285 (parse_expression_for_completion): Update.
9286 * objfiles.c (~objfile): Don't reset expression_context_block or
9288 * expression.h (enum innermost_block_tracker_type): Move from
9290 (parse_exp_1): Add tracker_types parameter.
9291 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9292 reset innermost_block.
9294 2019-03-23 Tom Tromey <tom@tromey.com>
9296 * objfiles.h: Include bcache.h.
9298 2019-03-23 Tom Tromey <tom@tromey.com>
9300 * linespec.c (get_current_search_block): Use
9301 scoped_restore_current_language.
9302 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9304 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9305 Jiong Wang <jiong.wang@arm.com>
9307 * aarch64-linux-tdep.c
9308 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9310 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9312 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9313 Jiong Wang <jiong.wang@arm.com>
9315 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9317 (aarch64_analyze_prologue_test): Add PACIASP test.
9318 (aarch64_prologue_prev_register): Unmask PC value.
9320 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9321 Jiong Wang <jiong.wang@arm.com>
9323 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9324 (aarch64_dwarf2_prev_register): Unmask PC value.
9325 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9326 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9327 DW_CFA_AARCH64_negate_ra_state.
9328 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9330 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9331 Jiong Wang <jiong.wang@arm.com>
9333 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9335 (aarch64_pseudo_register_name): Likewise.
9336 (aarch64_pseudo_register_type): Likewise.
9337 (aarch64_pseudo_register_reggroup_p): Likewise.
9338 (aarch64_gdbarch_init): Add pauth registers.
9339 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9340 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9341 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9342 (struct gdbarch_tdep): Add regnum for ra_state.
9344 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9345 Jiong Wang <jiong.wang@arm.com>
9347 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9349 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9350 Jiong Wang <jiong.wang@arm.com>
9352 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9354 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9355 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9356 (aarch64_gdbarch_init): Add puth registers.
9357 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9358 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9359 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9361 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9362 Jiong Wang <jiong.wang@arm.com>
9364 * aarch64-linux-nat.c
9365 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9366 * aarch64-linux-tdep.c
9367 (aarch64_linux_core_read_description): Likewise.
9368 (aarch64_linux_get_hwcap): New function.
9369 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9370 (aarch64_linux_get_hwcap): New declaration.
9372 2019-03-22 Alan Hayward <alan.hayward@arm.com>
9373 Jiong Wang <jiong.wang@arm.com>
9375 * aarch64-linux-nat.c
9376 (aarch64_linux_nat_target::read_description): Add pauth param.
9377 * aarch64-linux-tdep.c
9378 (aarch64_linux_core_read_description): Likewise.
9379 * aarch64-tdep.c (struct target_desc): Add in pauth.
9380 (aarch64_read_description): Add pauth param.
9381 (aarch64_gdbarch_init): Likewise.
9382 * aarch64-tdep.h (aarch64_read_description): Likewise.
9383 * arch/aarch64.c (aarch64_create_target_description): Likewise.
9384 * arch/aarch64.h (aarch64_create_target_description): Likewise.
9385 * features/Makefile: Add new files.
9386 * features/aarch64-pauth.c: New file.
9387 * features/aarch64-pauth.xml: New file.
9389 2019-03-20 Tom Tromey <tromey@adacore.com>
9391 * infrun.c (handle_inferior_event): Rename from
9392 handle_inferior_event_1. Create a scoped_value_mark.
9393 (handle_inferior_event): Remove.
9395 2019-03-19 Tom Tromey <tromey@adacore.com>
9397 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9398 * infrun.h (print_stop_event): Add "displays" parameter.
9399 * infrun.c (print_stop_event): Add "displays" parameter.
9401 2019-03-19 Pedro Alves <palves@redhat.com>
9403 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9404 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
9405 to -1. Fix TABs vs spaces.
9406 (tui_ui_out::tui_ui_out): Don't initialize fields here.
9407 * tui/tui-out.h (tui_ui_out) Add intro comments.
9408 <m_line, m_start_of_line>: In-class initialize, and add describing
9411 2019-03-18 Alan Hayward <alan.hayward@arm.com>
9413 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9415 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9417 2019-03-18 Pedro Alves <palves@redhat.com>
9418 Eli Zaretskii <eliz@gnu.org>
9420 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9421 m_line and m_start_of_line.
9423 2019-03-18 Eli Zaretskii <eliz@gnu.org>
9425 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9426 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9427 it returns a newline. This fixes a regression in TU mode, whereby
9428 the next line is output on the same screen line as the user input.
9430 2019-03-18 Tom Tromey <tromey@adacore.com>
9432 * minsyms.c (minimal_symbol_reader::install): Remove call to
9435 2019-03-18 Pedro Alves <palves@redhat.com>
9437 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9439 (apply_style): New, factored out from ...
9440 (apply_ansi_escape): ... this. Handle reverse video mode.
9441 (tui_set_reverse_mode): New function.
9442 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9443 * tui/tui-winsource.c (tui_show_source_line): Use
9444 tui_set_reverse_mode instead of setting A_STANDOUT.
9445 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9448 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
9450 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9453 2019-03-18 Tom Tromey <tromey@adacore.com>
9455 * ada-lang.c (empty_array): Add "high" parameter.
9456 (ada_evaluate_subexp): Update.
9458 2019-03-17 Sergei Trofimovich <siarheit@google.com>
9460 * unittests/string_view-selftests.c: Define
9461 _initialize_string_view_selftests unconditionally.
9463 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9466 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9468 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9471 * windows-nat.c (display_selector): Fix format specifiers.
9473 2019-03-17 Eli Zaretskii <eliz@gnu.org>
9475 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9476 tui_refill_source_window instead of tui_refresh_win, to update the
9477 current execution line. This fixes redisplay of the current line
9478 when stepping through the code with "next" or "step".
9480 2019-03-16 Eli Zaretskii <eliz@gnu.org>
9482 * source-cache.c (source_cache::get_source_lines): Call
9483 find_source_lines to initialize s->nlines. This fixes vertical
9484 scrolling of TUI source window when the DOWN arrow is pressed.
9486 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9488 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9489 linux-thread-db.c (_initialize_thread_db): Likewise.
9491 2019-03-16 Eli Zaretskii <eliz@gnu.org>
9493 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9494 wclrtoeol in tui_show_source_line". This reverts changes made in
9495 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9497 2019-03-15 Tom Tromey <tom@tromey.com>
9499 * symtab.h (struct minimal_symbol): Derive from
9500 general_symbol_info.
9501 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9502 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9503 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9504 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9505 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9506 (MSYMBOL_SEARCH_NAME): Update.
9507 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9508 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9509 * minsyms.c (minimal_symbol_reader::record_full): Update.
9511 2019-03-15 Tom Tromey <tom@tromey.com>
9513 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9515 2019-03-15 Tom Tromey <tom@tromey.com>
9517 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9519 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9521 * minsyms.c (lookup_minimal_symbol_by_pc_section)
9522 (build_minimal_symbol_hash_tables)
9523 (minimal_symbol_reader::install): Update.
9525 2019-03-15 Tom Tromey <tom@tromey.com>
9527 * symtab.c (create_demangled_names_hash): Update.
9528 (symbol_set_names): Update.
9529 * objfiles.h (struct objfile_per_bfd_storage)
9530 <demangled_names_hash>: Now an htab_up.
9531 * objfiles.c (objfile_per_bfd_storage): Simplify.
9533 2019-03-15 Tom Tromey <tom@tromey.com>
9535 * objfiles.h (struct objfile_per_bfd_storage): Declare
9537 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9539 (get_objfile_bfd_data): Use new. Don't initialize
9541 (free_objfile_per_bfd_storage): Remove.
9542 (objfile_bfd_data_free, objfile::~objfile): Use delete.
9544 2019-03-15 Tom Tromey <tom@tromey.com>
9546 * symfile.c (reread_symbols): Update.
9547 * objfiles.c (objfile::objfile): Update.
9548 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9549 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9551 (minimal_symbol_reader::install): Update.
9552 (terminate_minimal_symbol_table): Remove.
9553 * jit.c (jit_object_close_impl): Update.
9555 2019-03-15 Tom Tromey <tom@tromey.com>
9557 * minsyms.c (minimal_symbol_reader::record_full): Remove some
9560 2019-03-15 Tom Tromey <tom@tromey.com>
9562 * objfiles.h (struct objfile_per_bfd_storage)
9563 <demangled_hash_languages>: Now a bitset.
9564 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9565 (lookup_minimal_symbol): Update.
9567 2019-03-15 Tom Tromey <tom@tromey.com>
9569 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9570 Don't return the symbol.
9571 * coffread.c (record_minimal_symbol): Use record_full.
9573 2019-03-14 Eli Zaretskii <eliz@gnu.org>
9575 The MS-Windows port of ncurses fails to switch to a color pair if
9576 one or both of the colors are the implicit default colors. This
9577 change records the default colors when TUI is initialized, and
9578 then specifies them explicitly when a color pair uses the default
9579 colors. This allows color styling in TUI mode on MS-Windows.
9581 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
9583 (tui_initialize_io) [__MINGW32__]: Record the default terminal
9584 colors in ncurses_norm_attr.
9585 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9586 "none", replace it with the default color recorded in
9589 2019-03-14 Tom Tromey <tromey@adacore.com>
9591 * source-cache.h (class source_cache) <get_source_lines>: Return
9593 * source-cache.c (source_cache::extract_lines): Handle case where
9594 first_pos==npos. Return std::string.
9595 (source_cache::get_source_lines): Update.
9597 2019-03-14 Tom Tromey <tromey@adacore.com>
9599 * NEWS: Add item for "style sources" commands.
9600 * source-cache.c (source_cache::get_source_lines): Check
9602 * cli/cli-style.c (source_styling): New global.
9603 (_initialize_cli_style): Add "style sources" commands.
9604 (show_style_sources): New function.
9605 * cli/cli-style.h (source_styling): Declare.
9607 2019-03-14 Pedro Alves <palves@redhat.com>
9608 Tom Tromey <tromey@adacore.com>
9610 * tui/tui-winsource.h (tui_refill_source_window): Declare.
9611 * tui/tui-winsource.c (tui_refill_source_window): New function,
9613 (tui_horizontal_source_scroll): ... here. Move some logic.
9614 * cli/cli-style.c (set_style_enabled): Notify new observable.
9615 * tui/tui-hooks.c (tui_redisplay_source): New function.
9616 (tui_attach_detach_observers): Attach or detach
9617 tui_redisplay_source.
9618 * observable.h (source_styling_changed): New observable.
9619 * observable.c: Define source_styling_changed observable.
9621 2019-03-13 Tom Tromey <tromey@adacore.com>
9623 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9624 (i386_gnu_nat_target::store_registers): Update.
9625 * target-debug.h (target_debug_print_std_string): New macro.
9626 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9627 * windows-tdep.c (display_one_tib): Update.
9628 * tui/tui-stack.c (tui_make_status_line): Update.
9629 * top.c (print_inferior_quit_action): Update.
9630 * thread.c (thr_try_catch_cmd): Update.
9631 (add_thread_with_info): Update.
9632 (thread_target_id_str): Update.
9633 (thr_try_catch_cmd): Update.
9634 (thread_command): Update.
9635 (thread_find_command): Update.
9636 * record-btrace.c (record_btrace_target::info_record)
9637 (record_btrace_resume_thread, record_btrace_target::resume)
9638 (record_btrace_cancel_resume, record_btrace_step_thread)
9639 (record_btrace_target::wait, record_btrace_target::wait)
9640 (record_btrace_target::wait, record_btrace_target::stop): Update.
9641 * progspace.c (print_program_space): Update.
9642 * process-stratum-target.c
9643 (process_stratum_target::thread_address_space): Update.
9644 * linux-fork.c (linux_fork_mourn_inferior)
9645 (detach_checkpoint_command, info_checkpoints_command)
9646 (linux_fork_context): Update.
9647 (linux_fork_detach): Update.
9648 (class scoped_switch_fork_info): Update.
9649 (delete_checkpoint_command): Update.
9650 * infrun.c (follow_fork_inferior): Update.
9651 (follow_fork_inferior): Update.
9652 (proceed_after_vfork_done): Update.
9653 (handle_vfork_child_exec_or_exit): Update.
9654 (follow_exec): Update.
9655 (displaced_step_prepare_throw): Update.
9656 (displaced_step_restore): Update.
9657 (start_step_over): Update.
9659 (clear_proceed_status_thread): Update.
9661 (print_target_wait_results): Update.
9662 (do_target_wait): Update.
9663 (context_switch): Update.
9664 (stop_all_threads): Update.
9665 (restart_threads): Update.
9666 (finish_step_over): Update.
9667 (handle_signal_stop): Update.
9668 (switch_back_to_stepped_thread): Update.
9669 (keep_going_pass_signal): Update.
9670 (print_exited_reason): Update.
9671 (normal_stop): Update.
9672 * inferior.c (inferior_pid_to_str): Change return type.
9673 (print_selected_inferior): Update.
9674 (add_inferior): Update.
9675 (detach_inferior): Update.
9676 * dummy-frame.c (fprint_dummy_frames): Update.
9677 * dcache.c (dcache_info_1): Update.
9678 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9679 (btrace_fetch, btrace_clear): Update.
9680 * linux-tdep.c (linux_core_pid_to_str): Change return type.
9681 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9683 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9684 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9685 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9686 * gdbarch.c, gdbarch.h: Rebuild.
9687 * gdbarch.sh (core_pid_to_str): Change return type.
9688 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9690 (windows_nat_target::pid_to_str): Change return type.
9691 (windows_delete_thread): Update.
9692 (windows_nat_target::attach): Update.
9693 (windows_nat_target::files_info): Update.
9694 * target-delegates.c: Rebuild.
9695 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9697 (sol_thread_target::pid_to_str): Change return type.
9698 * remote.c (class remote_target) <pid_to_str>: Change return
9700 (remote_target::pid_to_str): Change return type.
9701 (extended_remote_target::attach, remote_target::remote_stop_ns)
9702 (remote_target::remote_notif_remove_queued_reply)
9703 (remote_target::push_stop_reply, remote_target::disable_btrace):
9705 (extended_remote_target::attach): Update.
9706 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9708 (gdbsim_target::pid_to_str): Change return type.
9709 * ravenscar-thread.c (struct ravenscar_thread_target)
9710 <pid_to_str>: Change return type.
9711 (ravenscar_thread_target::pid_to_str): Change return type.
9712 * procfs.c (class procfs_target) <pid_to_str>: Change return
9714 (procfs_target::pid_to_str): Change return type.
9715 (procfs_target::attach): Update.
9716 (procfs_target::detach): Update.
9717 (procfs_target::fetch_registers): Update.
9718 (procfs_target::store_registers): Update.
9719 (procfs_target::wait): Update.
9720 (procfs_target::files_info): Update.
9721 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9722 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9724 (nto_procfs_target::pid_to_str): Change return type.
9725 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9726 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9728 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9730 (attach_proc_task_lwp_callback, get_detach_signal)
9731 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9732 (linux_nat_target::resume, wait_lwp, stop_callback)
9733 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9734 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9735 (linux_nat_wait_1, resume_stopped_resumed_lwps)
9736 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9737 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9739 (inf_ptrace_target::attach): Update.
9740 (inf_ptrace_target::files_info): Update.
9741 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9743 (go32_nat_target::pid_to_str): Change return type.
9744 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9745 (gnu_nat_target::wait): Update.
9746 (gnu_nat_target::wait): Update.
9747 (gnu_nat_target::resume): Update.
9748 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9749 (fbsd_nat_target::wait): Update.
9750 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9752 (darwin_nat_target::attach): Update.
9753 * corelow.c (class core_target) <pid_to_str>: Change return type.
9754 (core_target::pid_to_str): Change return type.
9755 * target.c (normal_pid_to_str): Change return type.
9756 (default_pid_to_str): Likewise.
9757 (target_pid_to_str): Change return type.
9758 (target_translate_tls_address): Update.
9759 (target_announce_detach): Update.
9760 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9762 (bsd_uthread_target::pid_to_str): Change return type.
9763 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9765 (bsd_kvm_target::pid_to_str): Change return type.
9766 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9768 (aix_thread_target::pid_to_str): Change return type.
9769 * target.h (struct target_ops) <pid_to_str>: Change return type.
9770 (target_pid_to_str, normal_pid_to_str): Likewise.
9771 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9773 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9775 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9777 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9779 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9781 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9784 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9786 * NEWS: Mention that the new default MI version is 3. Mention
9787 changes to the output of commands and events that deal with
9788 multi-location breakpoints.
9789 * breakpoint.c: Include "mi/mi-out.h".
9790 (print_one_breakpoint): Change output syntax if using MI version
9792 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9794 (mi_multi_location_breakpoint_output_fixed): New.
9795 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9796 (mi_cmd_fix_multi_location_breakpoint_output): New.
9797 (mi_multi_location_breakpoint_output_fixed): New.
9798 * mi/mi-cmds.c (mi_cmds): Register command
9799 -fix-multi-location-breakpoint-output.
9800 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9803 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9805 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9806 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9807 instantiate mi_ui_out based on interpreter name.
9808 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9809 * mi/mi-main.c (mi_load_progress): Likewise.
9811 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9813 * NEWS: Combine separate "New targets" sections for 8.3.
9815 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9817 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9818 (ppcfbsd_init_abi): Install gdbarch
9819 "fetch_tls_load_module_address" and "get_thread_local_address"
9822 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9824 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9825 (riscv_fbsd_init_abi): Install gdbarch
9826 "fetch_tls_load_module_address" and "get_thread_local_address"
9829 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9831 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9832 (i386fbsd_init_abi): Install gdbarch
9833 "fetch_tls_load_module_address" and "get_thread_local_address"
9836 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9838 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9839 (amd64fbsd_init_abi): Install gdbarch
9840 "fetch_tls_load_module_address" and "get_thread_local_address"
9843 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9845 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9846 (struct fbsd_pspace_data): New type.
9847 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9848 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9849 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9850 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9851 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9853 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9855 * gdbtypes.c (lookup_struct_elt): New function.
9856 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9857 * gdbtypes.h (struct struct_elt): New type.
9858 (lookup_struct_elt): New prototype.
9860 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9862 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9863 remove disabled code block.
9865 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9867 * gdbarch.sh (get_thread_local_address): New method.
9868 * gdbarch.h, gdbarch.c: Regenerate.
9869 * target.c (target_translate_tls_address): Use
9870 gdbarch_get_thread_local_address if present instead of
9871 target::get_thread_local_address.
9873 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9875 * target.h (target::get_thread_local_address): Update comment.
9877 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9879 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9880 objfile->separate_debug_objfile_backlink if not NULL.
9882 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9884 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9885 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9886 (amd64bsd_store_inferior_registers): Likewise.
9887 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9888 Enable segment base registers.
9889 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9890 PT_GETFSBASE and PT_GETGSBASE.
9891 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9893 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9894 segment base registers.
9895 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9897 2019-03-12 John Baldwin <jhb@FreeBSD.org>
9899 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9900 Update calls to i386_target_description to add 'segments'
9902 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9903 add segment base registers.
9904 * arch/i386.c (i386_create_target_description): Add 'segments'
9905 parameter to enable segment base registers.
9906 * arch/i386.h (i386_create_target_description): Likewise.
9907 * features/i386/32bit-segments.xml: New file.
9908 * features/i386/32bit-segments.c: Generate.
9909 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9910 call to i386_target_description to add 'segments' parameter.
9911 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9912 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9913 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9914 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9915 if feature is present.
9916 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9917 Add 'segments' parameter to call to i386_target_description.
9918 (i386_target_description): Add 'segments' parameter to enable
9919 segment base registers.
9920 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9921 to call to i386_target_description.
9922 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9923 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9924 Define I386_NUM_REGS.
9925 (i386_target_description): Add 'segments' parameter to enable
9926 segment base registers.
9928 2019-03-12 Eli Zaretskii <eliz@gnu.org>
9931 * source-cache.c: #undef open and close, to avoid unresolved
9932 externals during linking.
9934 2019-03-12 Tom Tromey <tromey@adacore.com>
9936 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9937 const. Add initializers.
9938 (_initialize_remote): Don't initialize ptid globals.
9940 2019-03-12 Pedro Alves <palves@redhat.com>
9942 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9944 2019-03-12 Pedro Alves <palves@redhat.com>
9946 * cp-name-parser.y (main): Remove unused 'len' variable.
9948 2019-03-12 Tom Tromey <tromey@adacore.com>
9950 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9951 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9953 2019-03-12 Tom Tromey <tromey@adacore.com>
9955 * linux-nat.c (iterate_over_lwps): Update.
9956 (stop_callback): Remove parameter.
9957 (stop_wait_callback, detach_callback, resume_set_callback)
9958 (select_singlestep_lwp_callback, set_ignore_sigint)
9959 (status_callback, resumed_callback, resume_clear_callback)
9960 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9962 (linux_nat_target::detach, linux_nat_target::resume)
9963 (linux_stop_and_wait_all_lwps, select_event_lwp)
9964 (linux_nat_filter_event, linux_nat_wait_1)
9965 (linux_nat_target::kill, linux_nat_target::stop)
9966 (linux_nat_target::stop): Update.
9967 (linux_nat_resume_callback): Change type.
9968 (resume_stopped_resumed_lwps, count_events_callback)
9969 (select_event_lwp_callback): Likewise.
9970 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9971 * arm-linux-nat.c (struct update_registers_data): Remove.
9972 (update_registers_callback): Change type.
9973 (arm_linux_insert_hw_breakpoint1): Update.
9974 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9976 (x86_linux_dr_set_addr): Update.
9977 (x86_linux_dr_set_control): Update.
9978 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9979 (iterate_over_lwps): Use gdb::function_view.
9980 * nat/aarch64-linux-hw-point.c (struct
9981 aarch64_dr_update_callback_param): Remove.
9982 (debug_reg_change_callback): Change type.
9983 (aarch64_notify_debug_reg_change): Update.
9984 * s390-linux-nat.c (s390_refresh_per_info): Update.
9986 2019-03-11 Tom Tromey <tromey@adacore.com>
9988 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9989 redundant assignment to "this_cu".
9991 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9993 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9995 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9997 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9999 (rank_one_type): ... this.
10001 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10003 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10005 (rank_one_type): ... this.
10007 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10009 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10011 (rank_one_type): ... this.
10013 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10015 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10017 (rank_one_type): ... this.
10019 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10021 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10023 (rank_one_type): ... this.
10025 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10027 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10029 (rank_one_type): ... this.
10031 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10033 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10035 (rank_one_type): ... this.
10037 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10039 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10041 (rank_one_type): ... this.
10043 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10045 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10047 (rank_one_type): ... this.
10049 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10051 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10053 (rank_one_type): ... this.
10055 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10057 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10059 (rank_one_type): ... this.
10061 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
10063 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10065 (rank_one_type): ... this.
10067 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10069 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10070 inferior-events' shows the example events.
10072 2019-03-08 Eli Zaretskii <eliz@gnu.org>
10074 Support styling on native MS-Windows console
10077 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10078 on MS-Windows if $TERM is not defined.
10080 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10082 * posix-hdep.c (gdb_console_fputs):
10083 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10085 * ui-file.h (gdb_console_fputs): Add prototype.
10087 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10088 back to fputs only if the former returns zero.
10090 2019-03-07 Tom Tromey <tom@tromey.com>
10092 * symmisc.c (print_symbol_bcache_statistics): Update.
10093 (print_objfile_statistics): Update.
10094 * symfile.c (allocate_symtab): Update.
10095 * stabsread.c: Don't include bcache.h.
10096 * psymtab.h (struct psymbol_bcache): Don't declare.
10097 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10098 (psymbol_bcache_init, psymbol_bcache_free)
10099 (psymbol_bcache_get_bcache): Don't declare.
10100 * psymtab.c (struct psymbol_bcache): Remove.
10101 (psymtab_storage::psymtab_storage): Update.
10102 (psymtab_storage::~psymtab_storage): Update.
10103 (psymbol_bcache_init, psymbol_bcache_free)
10104 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10105 (add_psymbol_to_bcache): Update.
10106 (allocate_psymtab): Update.
10107 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10108 macro_cache>: No longer pointers.
10109 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10110 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10111 * macrotab.c (macro_bcache): Update.
10112 * macroexp.c: Don't include bcache.h.
10113 * gdbtypes.c (check_types_worklist): Update.
10114 (types_deeply_equal): Remove TRY/CATCH. Update.
10115 * elfread.c (elf_symtab_read): Update.
10116 * dwarf2read.c: Don't include bcache.h.
10117 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10118 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10119 (print_bcache_statistics, bcache_memory_used): Don't declare.
10120 (struct bcache): Move from bcache.c. Add constructor, destructor,
10121 methods. Rename all data members.
10122 * bcache.c (struct bcache): Move to bcache.h.
10123 (bcache::expand_hash_table): Rename from expand_hash_table.
10125 (bcache::insert): Rename from bcache_full.
10126 (bcache::compare): Rename from bcache_compare.
10127 (bcache_xmalloc): Remove.
10128 (bcache::~bcache): Rename from bcache_xfree.
10129 (bcache::print_statistics): Rename from print_bcache_statistics.
10130 (bcache::memory_used): Rename from bcache_memory_used.
10132 2019-03-07 Pedro Alves <palves@redhat.com>
10134 * infrun.c (normal_stop): Also check for
10135 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10137 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10139 * f-lang.c (value_from_host_double): Moved to...
10140 * value.c (value_from_host_double): ...here.
10141 * value.h (value_from_host_double): Declare.
10142 * guile/scm-math.c (vlscm_convert_typed_number): Use
10143 value_from_host_double.
10144 (vlscm_convert_number): Likewise.
10145 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10146 * python/py-value.c (convert_value_from_python): Likewise.
10148 2019-03-06 Tom Tromey <tom@tromey.com>
10150 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10152 2019-03-06 Tom Tromey <tom@tromey.com>
10154 * utils.h (free_current_contents): Don't declare.
10155 * utils.c (free_current_contents): Remove.
10157 2019-03-06 Tom Tromey <tom@tromey.com>
10159 * top.c (quit_force): Update.
10160 * main.c (captured_command_loop): Update.
10161 * common/new-op.c (operator new): Update.
10162 * common/common-exceptions.c (struct catcher)
10163 <save_cleanup_chain>: Remove member.
10164 (exceptions_state_mc_init): Update.
10165 (exception_try_scope_entry): Return nullptr.
10166 (exception_try_scope_exit, exception_rethrow)
10167 (throw_exception_sjlj, throw_exception_cxx): Update.
10168 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10169 (all_cleanups, do_cleanups, discard_cleanups)
10170 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10171 (restore_cleanups, restore_final_cleanups): Don't declare.
10172 (do_final_cleanups): Remove parameter.
10173 * common/cleanups.c (cleanup_chain, make_cleanup)
10174 (make_cleanup_dtor, all_cleanups, do_cleanups)
10175 (discard_my_cleanups, discard_cleanups)
10176 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10177 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10178 (null_cleanup): Remove.
10179 (do_final_cleanups): Remove parameter.
10181 2019-03-06 Tom Tromey <tom@tromey.com>
10183 * remote.c (remote_target::remote_parse_stop_reply): Use
10184 unique_xmalloc_ptr.
10186 2019-03-06 Tom Tromey <tom@tromey.com>
10188 * stabsread.c (struct stabs_field_info): Rename from field_info.
10189 <list, fnlist>: Add initializers.
10190 <obstack>: New member.
10191 (read_member_functions, read_struct_fields, read_baseclasses):
10192 Allocate on obstack. Don't use cleanups.
10193 (read_one_struct_field, read_member_functions, read_struct_fields)
10194 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10195 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10196 (read_struct_type): Update.
10198 2019-03-06 Tom Tromey <tom@tromey.com>
10200 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10201 * common/filestuff.h (make_cleanup_close): Don't declare.
10202 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10205 2019-03-06 Tom Tromey <tom@tromey.com>
10207 * solib-aix.c: Use make_scope_exit.
10209 2019-03-06 Tom Tromey <tom@tromey.com>
10211 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10212 Use make_scope_exit.
10214 2019-03-06 Tom Tromey <tom@tromey.com>
10216 * solib-svr4.c (disable_probes_interface): Remove parameter.
10217 (svr4_handle_solib_event): Use make_scope_exit.
10219 2019-03-06 Tom Tromey <tom@tromey.com>
10221 * remote.c (struct stop_reply_deleter): Remove.
10222 (stop_reply_up): Update.
10223 (struct stop_reply): Derive from notif_event. Don't typedef.
10224 <regcache>: Now a std::vector.
10225 (stop_reply_xfree): Remove.
10226 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10227 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10228 (remote_target::discard_pending_stop_replies): Use delete.
10229 (remote_target::remote_parse_stop_reply): Update.
10230 (remote_target::process_stop_reply): Update.
10231 * remote-notif.h (struct notif_event): Add virtual destructor.
10232 Remove "dtr" member.
10233 (struct notif_client) <alloc_event>: Return a unique_ptr.
10234 (notif_event_xfree): Don't declare.
10235 (notif_event_up): New typedef.
10236 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10237 (notif_event_xfree, do_notif_event_xfree): Remove.
10238 (remote_notif_state_xfree): Update.
10240 2019-03-06 Tom Tromey <tom@tromey.com>
10242 * infrun.c (displaced_step_clear_cleanup): Now a
10243 forward_scope_exit type.
10244 (displaced_step_prepare_throw): Update.
10245 (displaced_step_fixup): Update.
10247 2019-03-06 Tom Tromey <tom@tromey.com>
10249 * inferior.h (class inferior): Update comment.
10250 * gdbthread.h (class thread_info): Update comment.
10252 2019-03-06 Joel Brobecker <brobecker@adacore.com>
10253 Tom Tromey <tom@tromey.com>
10255 * stabsread.h (struct stab_section_list): Remove.
10256 (coffstab_build_psymtabs): Update.
10257 * dbxread.c (symbuf_sections): Now a std::vector.
10258 (sect_idx): New global.
10259 (fill_symbuf): Update.
10260 (coffstab_build_psymtabs): Change type of stabsects parameter.
10262 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10264 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10265 (coff_locate_sections): Update.
10266 (coff_symfile_read): Remove cleanups. Update.
10267 (init_stringtab): Add storage parameter.
10268 (free_stringtab, free_stringtab_cleanup): Remove.
10269 (init_lineno): Add storage parameter.
10270 (free_linetab, free_linetab_cleanup): Remove.
10272 2019-03-06 Pedro Alves <palves@redhat.com>
10274 * linux-fork.c (fork_info::clobber_regs): Delete.
10275 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10276 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10278 (scoped_switch_fork_info::scoped_switch_fork_info)
10279 (checkpoint_command, linux_fork_context): Adjust
10280 fork_save_infrun_state calls.
10282 2019-03-06 Pedro Alves <palves@redhat.com>
10284 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10285 (inf_has_multiple_threads): Return 'bool' and rewrite using
10286 inferior_info::threads().
10288 2019-03-06 Pedro Alves <palves@redhat.com>
10290 * linux-fork.c: Include <list>.
10291 (fork_list): Now a std::list instance.
10292 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10293 (forks_exist_p, find_last_fork): Adjust.
10294 (new_fork): Delete.
10296 (add_fork): Adjust.
10297 (free_fork): Delete, folded into fork_info::~fork_info().
10298 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10300 (init_fork_list): Delete.
10301 (linux_fork_killall, linux_fork_mourn_inferior)
10302 (linux_fork_detach, info_checkpoints_command): Adjust.
10303 (_initialize_linux_fork): No longer call init_fork_list.
10305 2019-03-06 Pedro Alves <palves@redhat.com>
10307 * linux-fork.c (new_fork): New, split out of ...
10308 (add_fork): ... this. Return void. Move "first fork" special
10309 case from here, to ...
10310 (checkpoint_command): ... here.
10311 * linux-linux.h (add_fork): Return void.
10313 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10315 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10317 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10318 Chris January <chris.january@arm.com>
10319 David Lecomber <david.lecomber@arm.com>
10321 * f-exp.y: New token, UNOP_INTRINSIC.
10322 (exp): New pattern using UNOP_INTRINSIC token.
10323 (f77_keywords): Add 'abs' keyword.
10324 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10325 (value_from_host_double): New function.
10326 (evaluate_subexp_f): Support UNOP_ABS.
10328 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10330 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10333 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10335 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10336 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10337 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10339 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10341 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10343 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10344 Chris January <chris.january@arm.com>
10346 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10347 * f-exp.y: Define 'KIND' token.
10348 (exp): New pattern for KIND expressions.
10349 (ptype): Handle types with a kind extension.
10350 (direct_abs_decl): Extend to spot kind extensions.
10351 (f77_keywords): Add 'kind' to the list.
10352 (push_kind_type): New function.
10353 (convert_to_kind_type): New function.
10354 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10355 * parse.c (operator_length_standard): Likewise.
10356 * parser-defs.h (enum type_pieces): Add tp_kind.
10357 * std-operator.def: Add UNOP_KIND.
10359 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10361 * f-exp.y (f_parse): Set yydebug.
10363 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10365 * f-lang.c (evaluate_subexp_f): New function.
10366 (exp_descriptor_f): New global.
10367 (f_language_defn): Use exp_descriptor_f instead of
10368 exp_descriptor_standard.
10370 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10372 * f-exp.y (struct token): Add comments.
10373 (dot_ops): Remove uppercase versions and the end marker.
10374 (f77_keywords): Likewise.
10375 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10376 entries in the dot_ops array are case insensitive, and use
10377 strncasecmp to compare strings. Also some whitespace cleanup in
10378 this area. Similar for the f77_keywords array, except entries in
10379 this list might be case sensitive.
10381 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10383 * f-exp.y (struct f77_boolean_val): Add comments.
10384 (boolean_values): Remove uppercase versions, and end marker.
10385 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10386 and use strncasecmp to achieve case insensitivity. Additionally,
10387 perform whitespace cleanup around this code.
10389 2019-03-06 Tom Tromey <tromey@adacore.com>
10391 * remote-sim.c (gdbsim_target_open): Use result of
10394 2019-03-06 Richard Bunt <richard.bunt@arm.com>
10395 Dirk Schubert <dirk.schubert@arm.com>
10396 Chris January <chris.january@arm.com>
10398 * eval.c (evaluate_subexp_standard): Call Fortran argument
10400 * f-lang.c (struct value): A value which can be passed into a
10401 Fortran function call.
10402 (fortran_argument_convert): Wrap Fortran arguments in a pointer
10404 (struct type): Value ready for a Fortran function call.
10405 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10407 * f-lang.h (fortran_argument_convert): Declaration.
10408 (fortran_preserve_arg_pointer): Declaration.
10409 * infcall.c (value_arg_coerce): Call Fortran argument logic.
10411 2019-03-05 Tom Tromey <tromey@adacore.com>
10413 * python/py-prettyprint.c (print_string_repr): Remove #if.
10414 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10416 2019-03-05 Tom Tromey <tromey@adacore.com>
10418 * target.c (the_dummy_target): Move later. Change type to
10420 (initialize_targets): Don't initialize the_dummy_target.
10422 2019-03-05 Tom Tromey <tromey@adacore.com>
10424 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10425 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10427 2019-03-05 Tom Tromey <tromey@adacore.com>
10429 * windows-nat.c (windows_nat_target::attach)
10430 (windows_nat_target::detach): Don't call gdb_flush.
10431 * valprint.c (generic_val_print, val_print, val_print_string):
10432 Don't call gdb_flush.
10433 * utils.c (defaulted_query): Don't call gdb_flush.
10434 * typeprint.c (print_type_scalar): Don't call gdb_flush.
10435 * target.c (target_announce_detach): Don't call gdb_flush.
10436 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10437 * remote.c (extended_remote_target::attach): Don't call
10439 * procfs.c (procfs_target::detach): Don't call gdb_flush.
10440 * printcmd.c (do_examine): Don't call gdb_flush.
10441 (info_display_command): Don't call gdb_flush.
10442 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10443 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10444 * memattr.c (info_mem_command): Don't call gdb_flush.
10445 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10446 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10447 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10448 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10449 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10450 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10451 (gnu_nat_target::detach): Don't call gdb_flush.
10452 * f-valprint.c (f_val_print): Don't call gdb_flush.
10453 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10454 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10455 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10457 * c-valprint.c (c_val_print): Don't call gdb_flush.
10458 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10460 2019-03-05 Tom Tromey <tromey@adacore.com>
10462 * varobj.c (update_dynamic_varobj_children): Update.
10463 (install_default_visualizer): Use reset, not release.
10464 * value.c (set_internalvar): Update.
10465 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10466 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10467 ATTRIBUTE_UNUSED_RESULT.
10469 2019-03-05 Tom Tromey <tromey@adacore.com>
10471 * remote.c (class scoped_remote_fd) <release>: Add
10472 ATTRIBUTE_UNUSED_RESULT.
10474 2019-03-05 Tom Tromey <tromey@adacore.com>
10476 * macroexp.c (struct macro_buffer) <release>: Add
10477 ATTRIBUTE_UNUSED_RESULT.
10479 2019-03-05 Tom Tromey <tromey@adacore.com>
10481 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10482 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10483 ATTRIBUTE_UNUSED_RESULT.
10485 2019-03-05 Tom Tromey <tromey@adacore.com>
10487 * common/scoped_fd.h (class scoped_fd) <release>: Add
10488 ATTRIBUTE_UNUSED_RESULT.
10490 2019-03-05 Tom Tromey <tromey@adacore.com>
10492 * parser-defs.h (struct parser_state) <release>: Add
10493 ATTRIBUTE_UNUSED_RESULT.
10495 2019-03-05 Tom Tromey <tromey@adacore.com>
10497 * utils.h (class gdb_argv) <release>: Add
10498 ATTRIBUTE_UNUSED_RESULT.
10499 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10501 2019-03-02 Eli Zaretskii <eliz@gnu.org>
10503 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10504 for-loop range, to avoid compiler warnings.
10506 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10507 avoid compiler warnings about unused variables.
10509 * NEWS: Mention end of support for native debugging on MS-Windows
10513 * common/netstuff.c:
10514 * gdbserver/gdbreplay.c
10515 * gdbserver/remote-utils.c:
10517 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10518 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
10519 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10520 'getaddrinfo' and 'freeaddrinfo' were not available before
10521 Windows XP, and mingw.org's MinGW headers by default define
10522 _WIN32_WINNT to 0x500.
10524 2019-03-01 Gary Benson <gbenson@redhat.com>
10526 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10528 2019-02-28 Brian Vandenberg <phantall@gmail.com>
10529 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
10532 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10533 set_sigint_trap, clear_sigint_trap.
10535 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10537 * target.c (target_detach): Clear the regcache and the
10540 2019-02-27 Pedro Alves <palves@redhat.com>
10542 * utils.c (set_screen_size): When we cap the height/width sizes,
10543 tweak the corresponding command variable to show "unlimited":
10545 2019-02-27 Saagar Jha <saagar@saagarjha.com>
10546 Pedro Alves <palves@redhat.com>
10548 * utils.c (set_screen_size): Reduce "infinite" rows and columns
10549 before calling rl_set_screen_size.
10551 2019-02-27 Tom Tromey <tromey@adacore.com>
10553 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10555 * python/py-value.c: Remove Python 2.4 workaround.
10556 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10558 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10559 Python 2.4 workaround.
10560 * python/python-internal.h: Remove Python 2.4 comment.
10561 (Py_ssize_t): Don't define.
10562 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10563 (gdb_Py_DECREF): Remove Python 2.4 workaround.
10564 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10565 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10566 * python/python.c (do_start_initialization): Remove Python 2.4
10568 * python/py-prettyprint.c (class dummy_python_frame): Remove.
10569 (print_children): Remove Python 2.4 workaround.
10570 * python/py-inferior.c (buffer_procs): Remove Python 2.4
10572 (CHARBUFFERPROC_NAME): Remove.
10573 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10574 Python 2.4 workaround.
10576 2019-02-27 Kevin Buettner <kevinb@redhat.com>
10578 * NEWS: Note minimum Python version.
10580 2019-02-27 Kevin Buettner <kevinb@redhat.com>
10582 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10583 code from these functions. Remove corresponding ifdefs. Use
10584 Py_buffer_up instead of explicit calls to PyBuffer_Release.
10585 Remove gotos and target of gotos.
10586 (infpy_search_memory): Likewise.
10588 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10590 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10591 (hppa_gdbarch_init): Don't register deleted functions with
10594 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10596 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10597 (h8300_unwind_sp): Delete.
10598 (h8300_dummy_id): Delete.
10599 (h8300_gdbarch_init): Don't register deleted functions with
10602 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10604 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10605 (ft32_unwind_pc): Delete.
10606 (ft32_unwind_sp): Delete.
10607 (ft32_gdbarch_init): Don't register deleted functions with
10610 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10612 * gdb/frv-tdep.c (frv_dummy_id): Delete.
10613 (frv_unwind_pc): Delete.
10614 (frv_unwind_sp): Delete.
10615 (frv_gdbarch_init): Don't register deleted functions with
10618 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10620 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10621 (riscv_unwind_pc): Delete.
10622 (riscv_unwind_sp): Delete.
10623 (riscv_gdbarch_init): Don't register deleted functions with
10626 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10628 * gdb/csky-tdep.c (csky_dummy_id): Delete.
10629 (csky_unwind_pc): Delete.
10630 (csky_unwind_sp): Delete.
10631 (csky_gdbarch_init): Don't register deleted functions with
10634 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10636 * gdb/cris-tdep.c (cris_dummy_id): Delete.
10637 (cris_unwind_pc): Delete.
10638 (cris_unwind_sp): Delete.
10639 (cris_gdbarch_init): Don't register deleted functions with
10642 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10644 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10645 (bfin_unwind_pc): Delete.
10646 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10648 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10650 * gdb/arm-tdep.c (arm_dummy_id): Delete.
10651 (arm_unwind_pc): Delete.
10652 (arm_unwind_sp): Delete.
10653 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10655 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10657 * gdb/arc-tdep.c (arc_dummy_id): Delete.
10658 (arc_unwind_pc): Delete.
10659 (arc_unwind_sp): Delete.
10660 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10662 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10664 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10665 (alpha_unwind_pc): Delete.
10666 (alpha_gdbarch_init): Don't register deleted functions with
10669 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10671 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10672 (aarch64_unwind_pc): Delete.
10673 (aarch64_unwind_sp): Delete.
10674 (aarch64_gdbarch_init): Don't register deleted functions with
10677 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10679 * gdbtypes.c (type_align): Don't consider static members when
10680 computing structure alignment.
10682 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10684 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10685 return 0 for other types.
10686 * arch-utils.c (default_type_align): Always return 0.
10687 * gdbarch.h: Regenerate.
10688 * gdbarch.sh (type_align): Extend comment.
10689 * gdbtypes.c (type_align): Add additional comments, always call
10690 gdbarch_type_align before applying the default rules.
10691 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10692 generic code will then apply a suitable default.
10693 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10694 types, return 0 for other types.
10696 2019-02-27 Joel Brobecker <brobecker@adacore.com>
10698 * NEWS: Create a new section for the next release branch.
10699 Rename the section of the current branch, now that it has
10702 2019-02-27 Joel Brobecker <brobecker@adacore.com>
10704 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10705 * version.in: Bump version to 8.3.50.DATE-git.
10707 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
10709 * aix-thread.c (ptid_cmp): Remove unused variable.
10710 (get_signaled_thread): Likewise.
10711 (store_regs_user_thread): Likewise.
10712 (store_regs_kernel_thread): Likewise.
10713 (fetch_regs_kernel_thread): Remove shadowed variable.
10715 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
10717 * features/riscv/32bit-cpu.xml: Add register numbers.
10718 * features/riscv/32bit-fpu.c: Regenerate.
10719 * features/riscv/32bit-fpu.xml: Add register numbers.
10720 * features/riscv/64bit-cpu.xml: Add register numbers.
10721 * features/riscv/64bit-fpu.c: Regenerate.
10722 * features/riscv/64bit-fpu.xml: Add register numbers.
10724 2019-02-26 Kevin Buettner <kevinb@redhat.com>
10726 * NEWS: Mention two argument form of gdb.Value constructor.
10727 * python/py-value.c (convert_buffer_and_type_to_value): New
10729 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10730 Add support for handling an optional second argument. Call
10731 convert_buffer_and_type_to_value as appropriate.
10732 * python/python-internal.h (Py_buffer_deleter): New struct.
10733 (Py_buffer_up): New typedef.
10735 2019-02-25 John Baldwin <jhb@FreeBSD.org>
10737 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10738 instead of releasing ownership.
10740 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
10742 * dwarf2read.c (open_and_init_dwp_file): Call
10743 elf_numsections instead of bfd_count_sections to initialize
10744 dwp_file->num_sections.
10746 2019-02-25 Tom Tromey <tromey@adacore.com>
10748 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10750 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
10752 * gcore.in: Add '--readnever' option when invoking GDB.
10754 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10756 * MAINTAINERS: Update my email address.
10758 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10760 * build-id.c (build_id_to_debug_bfd_1): New function.
10761 (build_id_to_debug_bfd): Look for separate debug file in
10764 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
10766 * gdbarch.sh: Update the copyright year range that is placed into
10769 2019-02-22 Keith Seitz <keiths@redhat.com>
10772 * linespec.c (create_sals_line_offset): Search for the default
10773 symtab's filename instead of its fullname.
10775 2019-02-21 Alan Hayward <alan.hayward@arm.com>
10777 * NEWS: Update style defaults.
10779 2019-02-21 Alan Hayward <alan.hayward@arm.com>
10781 * main.c (captured_main_1): Disable styling in batch mode.
10783 2019-02-20 Tom Tromey <tom@tromey.com>
10785 * symtab.c (symtab_symbol_info): Fix typos.
10787 2019-02-20 Tom Tromey <tromey@adacore.com>
10789 * findcmd.c (_initialize_mem_search): Use upper case for
10790 metasyntactic variables.
10792 2019-02-20 Alan Hayward <alan.hayward@arm.com>
10794 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10795 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10797 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10799 * top.h (source_file_name): Change to std::string.
10800 * top.c (source_file_name): Likewise.
10801 (command_line_input): Adjust.
10802 * cli/cli-script.c (script_from_file): Adjust.
10804 2019-02-19 Tom Tromey <tromey@adacore.com>
10806 * ravenscar-thread.c
10807 (ravenscar_thread_target::update_thread_list): Don't call
10808 ada_build_task_list.
10809 * ada-lang.h (ada_build_task_list): Don't declare.
10810 * ada-tasks.c (struct ada_tasks_inferior_data)
10811 <task_list_valid_p>: Now bool.
10812 (read_known_tasks, ada_task_list_changed)
10813 (ada_tasks_invalidate_inferior_data): Update.
10814 (read_known_tasks_array): Return bool.
10815 (read_known_tasks_list): Likewise.
10816 (read_known_tasks): Return void.
10817 (ada_build_task_list): Now static.
10819 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10821 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10822 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10824 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10826 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10827 variant for ada_tasks_pspace_data_handle and
10828 ada_tasks_inferior_data_handle.
10829 (ada_tasks_pspace_data_cleanup): New function.
10830 (ada_tasks_inferior_data_cleanup): New function.
10832 2019-02-17 Tom Tromey <tom@tromey.com>
10834 * macrotab.h (macro_source_fullname): Return a std::string.
10835 * macrotab.c (macro_include, check_for_redefinition)
10836 (macro_undef, macro_lookup_definition, foreach_macro)
10837 (foreach_macro_in_scope): Update.
10838 (macro_source_fullname): Return a std::string.
10839 * macrocmd.c (show_pp_source_pos): Update.
10841 2019-02-17 Tom Tromey <tom@tromey.com>
10843 * macrocmd.c (show_pp_source_pos): Style the file names.
10845 2019-02-17 Tom Tromey <tom@tromey.com>
10848 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10850 2019-02-17 Tom Tromey <tom@tromey.com>
10852 * ada-lang.c (user_select_syms): Use filtered printing.
10853 * utils.c (wrap_style): New global.
10854 (desired_style): Remove.
10855 (emit_style_escape): Add stream parameter.
10856 (set_output_style, reset_terminal_style, prompt_for_continue):
10858 (flush_wrap_buffer): Only flush gdb_stdout.
10859 (wrap_here): Set wrap_style.
10860 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10861 treat escape sequences as a character. Change when wrap buffer is
10863 (fputs_styled): Do not set the output style when the default is
10865 * ui-style.h (struct ui_file_style) <is_default>: New method.
10866 * source.c (print_source_lines_base): Emit escape sequences in one
10869 2019-02-17 Joel Brobecker <brobecker@adacore.com>
10871 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10872 integers and enumeration types.
10874 2019-02-17 Joel Brobecker <brobecker@adacore.com>
10876 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10877 instead of lookup_symbol_in_language
10878 (do_exact_match): New function.
10879 (ada_get_symbol_name_matcher): Return do_exact_match when
10880 doing a verbatim match.
10882 2019-02-15 Tom Tromey <tromey@adacore.com>
10884 * ravenscar-thread.c (ravenscar_thread_target::resume)
10885 (ravenscar_thread_target::wait): Special case wildcard requests.
10887 2019-02-15 Tom Tromey <tromey@adacore.com>
10889 * ravenscar-thread.c (base_ptid): Remove.
10890 (struct ravenscar_thread_target) <close>: New method.
10891 <m_base_ptid>: New member.
10892 <update_inferior_ptid, active_task, task_is_currently_active,
10893 runtime_initialized>: Declare methods.
10894 <ravenscar_thread_target>: Add constructor.
10895 (ravenscar_thread_target::task_is_currently_active)
10896 (ravenscar_thread_target::update_inferior_ptid)
10897 (ravenscar_runtime_initialized): Rename. Now methods.
10898 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10899 (ravenscar_thread_target::update_thread_list): Update.
10900 (ravenscar_thread_target::active_task): Now method.
10901 (ravenscar_thread_target::store_registers)
10902 (ravenscar_thread_target::prepare_to_store)
10903 (ravenscar_thread_target::prepare_to_store)
10904 (ravenscar_thread_target::mourn_inferior): Update.
10905 (ravenscar_inferior_created): Use "new" to create target.
10906 (ravenscar_thread_target::get_ada_task_ptid): Update.
10907 (_initialize_ravenscar): Don't initialize base_ptid.
10908 (ravenscar_ops): Remove global.
10910 2019-02-15 Tom Tromey <tromey@adacore.com>
10912 * target.h (push_target): Declare new overload.
10913 * target.c (push_target): New overload, taking an rvalue reference.
10914 * remote.c (remote_target::open_1): Use push_target overload.
10915 * corelow.c (core_target_open): Use push_target overload.
10917 2019-02-15 Tom Tromey <tromey@adacore.com>
10919 * ravenscar-thread.c (is_ravenscar_task)
10920 (ravenscar_task_is_currently_active): Return bool.
10921 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10922 (_initialize_ravenscar): Remove "(void)".
10923 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10926 2019-02-15 Tom Tromey <tromey@adacore.com>
10928 * ravenscar-thread.c (ravenscar_runtime_initializer)
10929 (has_ravenscar_runtime, get_running_thread_id)
10930 (ravenscar_thread_target::resume): Fix indentation.
10932 2019-02-15 Tom Tromey <tromey@adacore.com>
10934 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10935 from ravenscar_arch_ops.
10936 (sparc_ravenscar_ops::fetch_registers)
10937 (sparc_ravenscar_ops::store_registers): Now methods.
10938 (sparc_ravenscar_prepare_to_store): Remove.
10939 (sparc_ravenscar_ops): Redefine.
10940 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10941 methods and destructor. Remove members.
10942 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10943 (ravenscar_thread_target::store_registers)
10944 (ravenscar_thread_target::prepare_to_store): Update.
10945 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10947 (struct ppc_ravenscar_powerpc_ops): Derive from
10948 ravenscar_arch_ops.
10949 (ppc_ravenscar_powerpc_ops::fetch_registers)
10950 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10951 (ppc_ravenscar_powerpc_ops): Redefine.
10952 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10953 (ppc_ravenscar_e500_ops::fetch_registers)
10954 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10955 (ppc_ravenscar_e500_ops): Redefine.
10956 * aarch64-ravenscar-thread.c
10957 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10958 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10959 (aarch64_ravenscar_fetch_registers)
10960 (aarch64_ravenscar_store_registers): Now methods.
10961 (aarch64_ravenscar_ops): Redefine.
10963 2019-02-15 Tom Tromey <tromey@adacore.com>
10965 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10966 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10967 (ravenscar_thread_target::stopped_by_watchpoint)
10968 (ravenscar_thread_target::stopped_data_address)
10969 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10971 2019-02-15 Tom Tromey <tromey@adacore.com>
10973 * ravenscar-thread.c: Fix some typos.
10975 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10976 Tom Tromey <tromey@adacore.com>
10978 * ada-lang.c (ada_exception_sal): Change addr_string to a
10980 (create_ada_exception_catchpoint): Update.
10982 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10983 Tom Tromey <tromey@adacore.com>
10985 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10986 (bp_location_ops): Remove.
10987 (base_breakpoint_allocate_location): Update.
10988 (free_bp_location): Update.
10989 * ada-lang.c (class ada_catchpoint_location)
10990 <ada_catchpoint_location>: Remove ops parameter.
10991 (ada_catchpoint_location_dtor): Remove.
10992 (ada_catchpoint_location_ops): Remove.
10993 (allocate_location_exception): Update.
10994 * breakpoint.h (struct bp_location_ops): Remove.
10995 (class bp_location) <bp_location>: Remove bp_location_ops
10997 <~bp_location>: Add destructor.
11000 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11001 Pedro Alves <palves@redhat.com>
11003 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11006 2019-02-14 David Michael <fedora.dm0@gmail.com>
11007 Samuel Thibault <samuel.thibault@gnu.org>
11008 Thomas Schwinge <thomas@codesourcery.com>
11010 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11011 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11013 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11015 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11016 (check_empty): Use "const char *".
11018 * gnu-nat.c (gnu_nat_target::detach): Instead of
11019 'detach_inferior (pid)' call
11020 'detach_inferior (find_inferior_pid (pid))'.
11022 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11023 'nat/fork-inferior.o'.
11024 * gnu-nat.c: #include "nat/fork-inferior.h".
11026 * gnu-nat.c (gnu_nat_target::detach): Instead of
11027 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11028 * gnu-nat.h: #include "inf-child.h".
11029 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11030 'i386_gnu_nat_target::fetch_registers'.
11031 (gnu_store_registers): Rename/move to
11032 'i386_gnu_nat_target::store_registers'.
11034 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11035 * gnu-nat.h (mach_thread_info): New function.
11036 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11038 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11040 2019-02-14 Frederic Konrad <konrad@adacore.com>
11042 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11044 2019-02-14 Joel Brobecker <brobecker@adacore.com>
11046 * windows-nat.c (windows_add_thread): Add new parameter
11047 "main_thread_p" with default value set to false. Update
11048 function documentation as well as all callers.
11049 (windows_delete_thread): Likewise.
11050 (fake_create_process): Update call to windows_add_thread.
11051 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11052 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11053 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11054 call to windows_delete_thread.
11056 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11058 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11060 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11062 * symfile.c (find_separate_debug_file): Use canonical path of
11063 sysroot with child_path instead of gdb_sysroot if it is valid.
11065 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11067 * symfile.c (find_separate_debug_file): Use child_path to
11068 determine if an object file is under a sysroot.
11070 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11072 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11073 unittests/child-path-selftests.c.
11074 * common/pathstuff.c (child_path): New function.
11075 * common/pathstuff.h (child_path): New prototype.
11076 * unittests/child-path-selftests.c: New file.
11078 2019-02-12 John Baldwin <jhb@FreeBSD.org>
11080 * symfile.c (find_separate_debug_file): Look for separate debug
11081 files in debug directories under the sysroot.
11083 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11085 * symtab.h (struct minimal_symbol data_p): New const method.
11086 (struct minimal_symbol text_p): Likewise.
11087 * symtab.c (output_source_filename): Use file name style
11088 to print file name.
11089 (print_symbol_info): Likewise.
11090 (print_msymbol_info): Use address style to print addresses.
11091 Use function name style to print executable text symbols.
11092 (expand_symtab_containing_pc): Use data_p.
11093 (find_pc_sect_compunit_symtab): Likewise.
11095 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11097 * breakpoint.c (describe_other_breakpoints): Use address style
11098 to print addresses.
11099 (say_where): Likewise.
11101 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11103 * ada-typeprint.c (print_func_type): Print function name
11104 style to print function name.
11105 * c-typeprint.c (c_print_type_1): Likewise.
11107 2019-02-11 Alan Hayward <alan.hayward@arm.com>
11109 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11112 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11114 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11117 2019-02-10 Joel Brobecker <brobecker@adacore.com>
11119 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11120 TYPE_CODE_REF types.
11122 2019-02-08 Jim Wilson <jimw@sifive.com>
11124 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11125 (riscv_linux_fregset): New.
11126 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11128 2019-02-07 Tom Tromey <tom@tromey.com>
11130 * thread.c (thread_cancel_execution_command): Update.
11131 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11133 (struct thread_fsm_ops): Remove.
11134 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11135 (thread_fsm_should_stop, thread_fsm_return_value)
11136 (thread_fsm_set_finished, thread_fsm_finished_p)
11137 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11139 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11140 * infrun.c (clear_proceed_status_thread)
11141 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11142 (print_stop_event): Update.
11143 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11145 (step_command_fsm_ops): Remove.
11146 (new_step_command_fsm): Remove.
11148 (step_command_fsm::should_stop): Rename from
11149 step_command_fsm_should_stop.
11150 (step_command_fsm::clean_up): Rename from
11151 step_command_fsm_clean_up.
11152 (step_command_fsm::do_async_reply_reason): Rename from
11153 step_command_fsm_async_reply_reason.
11154 (struct until_next_fsm): Inherit from thread_fsm. Add
11156 (until_next_fsm_ops): Remove.
11157 (new_until_next_fsm): Remove.
11158 (until_next_fsm::should_stop): Rename from
11159 until_next_fsm_should_stop.
11160 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11161 (until_next_fsm::do_async_reply_reason): Rename from
11162 until_next_fsm_async_reply_reason.
11163 (struct finish_command_fsm): Inherit from thread_fsm. Add
11164 constructor. Change type of breakpoint.
11165 (finish_command_fsm_ops): Remove.
11166 (new_finish_command_fsm): Remove.
11167 (finish_command_fsm::should_stop): Rename from
11168 finish_command_fsm_should_stop.
11169 (finish_command_fsm::clean_up): Rename from
11170 finish_command_fsm_clean_up.
11171 (finish_command_fsm::return_value): Rename from
11172 finish_command_fsm_return_value.
11173 (finish_command_fsm::do_async_reply_reason): Rename from
11174 finish_command_fsm_async_reply_reason.
11175 (finish_command): Update.
11176 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11178 (call_thread_fsm_ops): Remove.
11179 (call_thread_fsm::call_thread_fsm): Rename from
11180 new_call_thread_fsm.
11181 (call_thread_fsm::should_stop): Rename from
11182 call_thread_fsm_should_stop.
11183 (call_thread_fsm::should_notify_stop): Rename from
11184 call_thread_fsm_should_notify_stop.
11185 (run_inferior_call, call_function_by_hand_dummy): Update.
11186 * cli/cli-interp.c (should_print_stop_to_console): Update.
11187 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11188 Add constructor. Change type of location_breakpoint,
11190 (until_break_fsm_ops): Remove.
11191 (new_until_break_fsm): Remove.
11192 (until_break_fsm::should_stop): Rename from
11193 until_break_fsm_should_stop.
11194 (until_break_fsm::clean_up): Rename from
11195 until_break_fsm_clean_up.
11196 (until_break_fsm::do_async_reply_reason): Rename from
11197 until_break_fsm_async_reply_reason.
11198 (until_break_command): Update.
11199 * thread-fsm.c: Remove.
11200 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11202 2019-02-07 Tom Tromey <tom@tromey.com>
11204 * yy-remap.h: Add include guard.
11205 * xtensa-tdep.h: Add include guard.
11206 * xcoffread.h: Rename include guard.
11207 * varobj-iter.h: Add include guard.
11208 * tui/tui.h: Rename include guard.
11209 * tui/tui-winsource.h: Rename include guard.
11210 * tui/tui-wingeneral.h: Rename include guard.
11211 * tui/tui-windata.h: Rename include guard.
11212 * tui/tui-win.h: Rename include guard.
11213 * tui/tui-stack.h: Rename include guard.
11214 * tui/tui-source.h: Rename include guard.
11215 * tui/tui-regs.h: Rename include guard.
11216 * tui/tui-out.h: Rename include guard.
11217 * tui/tui-layout.h: Rename include guard.
11218 * tui/tui-io.h: Rename include guard.
11219 * tui/tui-hooks.h: Rename include guard.
11220 * tui/tui-file.h: Rename include guard.
11221 * tui/tui-disasm.h: Rename include guard.
11222 * tui/tui-data.h: Rename include guard.
11223 * tui/tui-command.h: Rename include guard.
11224 * tic6x-tdep.h: Add include guard.
11225 * target/waitstatus.h: Rename include guard.
11226 * target/wait.h: Rename include guard.
11227 * target/target.h: Rename include guard.
11228 * target/resume.h: Rename include guard.
11229 * target-float.h: Rename include guard.
11230 * stabsread.h: Add include guard.
11231 * rs6000-tdep.h: Add include guard.
11232 * riscv-fbsd-tdep.h: Add include guard.
11233 * regformats/regdef.h: Rename include guard.
11234 * record.h: Rename include guard.
11235 * python/python.h: Rename include guard.
11236 * python/python-internal.h: Rename include guard.
11237 * python/py-stopevent.h: Rename include guard.
11238 * python/py-ref.h: Rename include guard.
11239 * python/py-record.h: Rename include guard.
11240 * python/py-record-full.h: Rename include guard.
11241 * python/py-record-btrace.h: Rename include guard.
11242 * python/py-instruction.h: Rename include guard.
11243 * python/py-events.h: Rename include guard.
11244 * python/py-event.h: Rename include guard.
11245 * procfs.h: Add include guard.
11246 * proc-utils.h: Add include guard.
11247 * p-lang.h: Add include guard.
11248 * or1k-tdep.h: Rename include guard.
11249 * observable.h: Rename include guard.
11250 * nto-tdep.h: Rename include guard.
11251 * nat/x86-linux.h: Rename include guard.
11252 * nat/x86-linux-dregs.h: Rename include guard.
11253 * nat/x86-gcc-cpuid.h: Add include guard.
11254 * nat/x86-dregs.h: Rename include guard.
11255 * nat/x86-cpuid.h: Rename include guard.
11256 * nat/ppc-linux.h: Rename include guard.
11257 * nat/mips-linux-watch.h: Rename include guard.
11258 * nat/linux-waitpid.h: Rename include guard.
11259 * nat/linux-ptrace.h: Rename include guard.
11260 * nat/linux-procfs.h: Rename include guard.
11261 * nat/linux-osdata.h: Rename include guard.
11262 * nat/linux-nat.h: Rename include guard.
11263 * nat/linux-namespaces.h: Rename include guard.
11264 * nat/linux-btrace.h: Rename include guard.
11265 * nat/glibc_thread_db.h: Rename include guard.
11266 * nat/gdb_thread_db.h: Rename include guard.
11267 * nat/gdb_ptrace.h: Rename include guard.
11268 * nat/fork-inferior.h: Rename include guard.
11269 * nat/amd64-linux-siginfo.h: Rename include guard.
11270 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11271 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11272 * nat/aarch64-linux.h: Rename include guard.
11273 * nat/aarch64-linux-hw-point.h: Rename include guard.
11274 * mn10300-tdep.h: Add include guard.
11275 * mips-linux-tdep.h: Add include guard.
11276 * mi/mi-parse.h: Rename include guard.
11277 * mi/mi-out.h: Rename include guard.
11278 * mi/mi-main.h: Rename include guard.
11279 * mi/mi-interp.h: Rename include guard.
11280 * mi/mi-getopt.h: Rename include guard.
11281 * mi/mi-console.h: Rename include guard.
11282 * mi/mi-common.h: Rename include guard.
11283 * mi/mi-cmds.h: Rename include guard.
11284 * mi/mi-cmd-break.h: Rename include guard.
11285 * m2-lang.h: Add include guard.
11286 * location.h: Rename include guard.
11287 * linux-record.h: Rename include guard.
11288 * linux-nat.h: Add include guard.
11289 * linux-fork.h: Add include guard.
11290 * i386-darwin-tdep.h: Rename include guard.
11291 * hppa-linux-offsets.h: Add include guard.
11292 * guile/guile.h: Rename include guard.
11293 * guile/guile-internal.h: Rename include guard.
11294 * gnu-nat.h: Rename include guard.
11295 * gdb-stabs.h: Rename include guard.
11296 * frv-tdep.h: Add include guard.
11297 * f-lang.h: Add include guard.
11298 * event-loop.h: Add include guard.
11299 * darwin-nat.h: Rename include guard.
11300 * cp-abi.h: Rename include guard.
11301 * config/sparc/nm-sol2.h: Rename include guard.
11302 * config/nm-nto.h: Rename include guard.
11303 * config/nm-linux.h: Add include guard.
11304 * config/i386/nm-i386gnu.h: Rename include guard.
11305 * config/djgpp/nl_types.h: Rename include guard.
11306 * config/djgpp/langinfo.h: Rename include guard.
11307 * compile/gcc-cp-plugin.h: Add include guard.
11308 * compile/gcc-c-plugin.h: Add include guard.
11309 * compile/compile.h: Rename include guard.
11310 * compile/compile-object-run.h: Rename include guard.
11311 * compile/compile-object-load.h: Rename include guard.
11312 * compile/compile-internal.h: Rename include guard.
11313 * compile/compile-cplus.h: Rename include guard.
11314 * compile/compile-c.h: Rename include guard.
11315 * common/xml-utils.h: Rename include guard.
11316 * common/x86-xstate.h: Rename include guard.
11317 * common/version.h: Rename include guard.
11318 * common/vec.h: Rename include guard.
11319 * common/tdesc.h: Rename include guard.
11320 * common/selftest.h: Rename include guard.
11321 * common/scoped_restore.h: Rename include guard.
11322 * common/scoped_mmap.h: Rename include guard.
11323 * common/scoped_fd.h: Rename include guard.
11324 * common/safe-iterator.h: Rename include guard.
11325 * common/run-time-clock.h: Rename include guard.
11326 * common/refcounted-object.h: Rename include guard.
11327 * common/queue.h: Rename include guard.
11328 * common/ptid.h: Rename include guard.
11329 * common/print-utils.h: Rename include guard.
11330 * common/preprocessor.h: Rename include guard.
11331 * common/pathstuff.h: Rename include guard.
11332 * common/observable.h: Rename include guard.
11333 * common/netstuff.h: Rename include guard.
11334 * common/job-control.h: Rename include guard.
11335 * common/host-defs.h: Rename include guard.
11336 * common/gdb_wait.h: Rename include guard.
11337 * common/gdb_vecs.h: Rename include guard.
11338 * common/gdb_unlinker.h: Rename include guard.
11339 * common/gdb_unique_ptr.h: Rename include guard.
11340 * common/gdb_tilde_expand.h: Rename include guard.
11341 * common/gdb_sys_time.h: Rename include guard.
11342 * common/gdb_string_view.h: Rename include guard.
11343 * common/gdb_splay_tree.h: Rename include guard.
11344 * common/gdb_setjmp.h: Rename include guard.
11345 * common/gdb_ref_ptr.h: Rename include guard.
11346 * common/gdb_optional.h: Rename include guard.
11347 * common/gdb_locale.h: Rename include guard.
11348 * common/gdb_assert.h: Rename include guard.
11349 * common/filtered-iterator.h: Rename include guard.
11350 * common/filestuff.h: Rename include guard.
11351 * common/fileio.h: Rename include guard.
11352 * common/environ.h: Rename include guard.
11353 * common/common-utils.h: Rename include guard.
11354 * common/common-types.h: Rename include guard.
11355 * common/common-regcache.h: Rename include guard.
11356 * common/common-inferior.h: Rename include guard.
11357 * common/common-gdbthread.h: Rename include guard.
11358 * common/common-exceptions.h: Rename include guard.
11359 * common/common-defs.h: Rename include guard.
11360 * common/common-debug.h: Rename include guard.
11361 * common/cleanups.h: Rename include guard.
11362 * common/buffer.h: Rename include guard.
11363 * common/btrace-common.h: Rename include guard.
11364 * common/break-common.h: Rename include guard.
11365 * cli/cli-utils.h: Rename include guard.
11366 * cli/cli-style.h: Rename include guard.
11367 * cli/cli-setshow.h: Rename include guard.
11368 * cli/cli-script.h: Rename include guard.
11369 * cli/cli-interp.h: Rename include guard.
11370 * cli/cli-decode.h: Rename include guard.
11371 * cli/cli-cmds.h: Rename include guard.
11372 * charset-list.h: Add include guard.
11373 * buildsym-legacy.h: Rename include guard.
11374 * bfin-tdep.h: Add include guard.
11375 * ax.h: Rename include guard.
11376 * arm-linux-tdep.h: Add include guard.
11377 * arm-fbsd-tdep.h: Add include guard.
11378 * arch/xtensa.h: Rename include guard.
11379 * arch/tic6x.h: Add include guard.
11380 * arch/i386.h: Add include guard.
11381 * arch/arm.h: Rename include guard.
11382 * arch/arm-linux.h: Rename include guard.
11383 * arch/arm-get-next-pcs.h: Rename include guard.
11384 * arch/amd64.h: Add include guard.
11385 * arch/aarch64-insn.h: Rename include guard.
11386 * arch-utils.h: Rename include guard.
11387 * annotate.h: Add include guard.
11388 * amd64-darwin-tdep.h: Rename include guard.
11389 * aarch64-linux-tdep.h: Add include guard.
11390 * aarch64-fbsd-tdep.h: Add include guard.
11391 * aarch32-linux-nat.h: Add include guard.
11393 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11395 * macrotab.c (macro_define_internal): New function that
11396 factorizes macro_define_object_internal and macro_define_function
11398 (macro_define_object_internal): Use macro_define_internal.
11399 (macro_define_function): Likewise.
11401 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11403 * macrocmd.c (extract_identifier): Return
11404 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11407 2019-02-06 John Baldwin <jhb@FreeBSD.org>
11409 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11411 2019-02-05 Tom Tromey <tom@tromey.com>
11413 * target.c (target_stack::unpush): Move assertion earlier.
11415 2019-01-30 Tom Tromey <tom@tromey.com>
11418 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11419 (gdbpy_parse_and_eval): Likewise.
11420 * python/python-internal.h (gdbpy_allow_threads): New class.
11422 2019-01-28 John Baldwin <jhb@FreeBSD.org>
11424 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11425 (aarch64_fbsd_fpregmap): Move earlier.
11426 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11427 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11428 instead of individual calls to trad_frame_set_reg_addr.
11429 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11431 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11432 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11433 instead of individual calls to trad_frame_set_reg_addr.
11435 2019-01-28 Alan Hayward <alan.hayward@arm.com>
11437 * CONTRIBUTE: Replace contribution list with wiki link.
11439 2019-01-25 Tom Tromey <tom@tromey.com>
11441 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11443 2019-01-25 Tom Tromey <tom@tromey.com>
11445 * xtensa-linux-nat.c: Fix common/ includes.
11446 * xml-support.h: Fix common/ includes.
11447 * xml-support.c: Fix common/ includes.
11448 * x86-linux-nat.c: Fix common/ includes.
11449 * windows-nat.c: Fix common/ includes.
11450 * varobj.h: Fix common/ includes.
11451 * varobj.c: Fix common/ includes.
11452 * value.c: Fix common/ includes.
11453 * valops.c: Fix common/ includes.
11454 * utils.c: Fix common/ includes.
11455 * unittests/xml-utils-selftests.c: Fix common/ includes.
11456 * unittests/utils-selftests.c: Fix common/ includes.
11457 * unittests/unpack-selftests.c: Fix common/ includes.
11458 * unittests/tracepoint-selftests.c: Fix common/ includes.
11459 * unittests/style-selftests.c: Fix common/ includes.
11460 * unittests/string_view-selftests.c: Fix common/ includes.
11461 * unittests/scoped_restore-selftests.c: Fix common/ includes.
11462 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11463 * unittests/scoped_fd-selftests.c: Fix common/ includes.
11464 * unittests/rsp-low-selftests.c: Fix common/ includes.
11465 * unittests/parse-connection-spec-selftests.c: Fix common/
11467 * unittests/optional-selftests.c: Fix common/ includes.
11468 * unittests/offset-type-selftests.c: Fix common/ includes.
11469 * unittests/observable-selftests.c: Fix common/ includes.
11470 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11471 * unittests/memrange-selftests.c: Fix common/ includes.
11472 * unittests/memory-map-selftests.c: Fix common/ includes.
11473 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11474 * unittests/function-view-selftests.c: Fix common/ includes.
11475 * unittests/environ-selftests.c: Fix common/ includes.
11476 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11477 * unittests/common-utils-selftests.c: Fix common/ includes.
11478 * unittests/cli-utils-selftests.c: Fix common/ includes.
11479 * unittests/array-view-selftests.c: Fix common/ includes.
11480 * ui-file.c: Fix common/ includes.
11481 * tui/tui-io.c: Fix common/ includes.
11482 * tracepoint.h: Fix common/ includes.
11483 * tracepoint.c: Fix common/ includes.
11484 * tracefile-tfile.c: Fix common/ includes.
11485 * top.h: Fix common/ includes.
11486 * top.c: Fix common/ includes.
11487 * thread.c: Fix common/ includes.
11488 * target/waitstatus.h: Fix common/ includes.
11489 * target/waitstatus.c: Fix common/ includes.
11490 * target.h: Fix common/ includes.
11491 * target.c: Fix common/ includes.
11492 * target-memory.c: Fix common/ includes.
11493 * target-descriptions.c: Fix common/ includes.
11494 * symtab.h: Fix common/ includes.
11495 * symfile.c: Fix common/ includes.
11496 * stap-probe.c: Fix common/ includes.
11497 * spu-linux-nat.c: Fix common/ includes.
11498 * sparc-nat.c: Fix common/ includes.
11499 * source.c: Fix common/ includes.
11500 * solib.c: Fix common/ includes.
11501 * solib-target.c: Fix common/ includes.
11502 * ser-unix.c: Fix common/ includes.
11503 * ser-tcp.c: Fix common/ includes.
11504 * ser-pipe.c: Fix common/ includes.
11505 * ser-base.c: Fix common/ includes.
11506 * selftest-arch.c: Fix common/ includes.
11507 * s12z-tdep.c: Fix common/ includes.
11508 * rust-exp.y: Fix common/ includes.
11509 * rs6000-aix-tdep.c: Fix common/ includes.
11510 * riscv-tdep.c: Fix common/ includes.
11511 * remote.c: Fix common/ includes.
11512 * remote-notif.h: Fix common/ includes.
11513 * remote-fileio.h: Fix common/ includes.
11514 * remote-fileio.c: Fix common/ includes.
11515 * regcache.h: Fix common/ includes.
11516 * regcache.c: Fix common/ includes.
11517 * record-btrace.c: Fix common/ includes.
11518 * python/python.c: Fix common/ includes.
11519 * python/py-type.c: Fix common/ includes.
11520 * python/py-inferior.c: Fix common/ includes.
11521 * progspace.h: Fix common/ includes.
11522 * producer.c: Fix common/ includes.
11523 * procfs.c: Fix common/ includes.
11524 * proc-api.c: Fix common/ includes.
11525 * printcmd.c: Fix common/ includes.
11526 * ppc-linux-nat.c: Fix common/ includes.
11527 * parser-defs.h: Fix common/ includes.
11528 * osdata.c: Fix common/ includes.
11529 * obsd-nat.c: Fix common/ includes.
11530 * nat/x86-linux.c: Fix common/ includes.
11531 * nat/x86-linux-dregs.c: Fix common/ includes.
11532 * nat/x86-dregs.h: Fix common/ includes.
11533 * nat/x86-dregs.c: Fix common/ includes.
11534 * nat/ppc-linux.c: Fix common/ includes.
11535 * nat/mips-linux-watch.h: Fix common/ includes.
11536 * nat/mips-linux-watch.c: Fix common/ includes.
11537 * nat/linux-waitpid.c: Fix common/ includes.
11538 * nat/linux-ptrace.h: Fix common/ includes.
11539 * nat/linux-ptrace.c: Fix common/ includes.
11540 * nat/linux-procfs.c: Fix common/ includes.
11541 * nat/linux-personality.c: Fix common/ includes.
11542 * nat/linux-osdata.c: Fix common/ includes.
11543 * nat/linux-namespaces.c: Fix common/ includes.
11544 * nat/linux-btrace.h: Fix common/ includes.
11545 * nat/linux-btrace.c: Fix common/ includes.
11546 * nat/fork-inferior.c: Fix common/ includes.
11547 * nat/amd64-linux-siginfo.c: Fix common/ includes.
11548 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11549 * nat/aarch64-linux.c: Fix common/ includes.
11550 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11551 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11552 * namespace.h: Fix common/ includes.
11553 * mips-linux-tdep.c: Fix common/ includes.
11554 * minsyms.c: Fix common/ includes.
11555 * mi/mi-parse.h: Fix common/ includes.
11556 * mi/mi-main.c: Fix common/ includes.
11557 * mi/mi-cmd-env.c: Fix common/ includes.
11558 * memrange.h: Fix common/ includes.
11559 * memattr.c: Fix common/ includes.
11560 * maint.h: Fix common/ includes.
11561 * maint.c: Fix common/ includes.
11562 * main.c: Fix common/ includes.
11563 * machoread.c: Fix common/ includes.
11564 * location.c: Fix common/ includes.
11565 * linux-thread-db.c: Fix common/ includes.
11566 * linux-nat.c: Fix common/ includes.
11567 * linux-fork.c: Fix common/ includes.
11568 * inline-frame.c: Fix common/ includes.
11569 * infrun.c: Fix common/ includes.
11570 * inflow.c: Fix common/ includes.
11571 * inferior.h: Fix common/ includes.
11572 * inferior.c: Fix common/ includes.
11573 * infcmd.c: Fix common/ includes.
11574 * inf-ptrace.c: Fix common/ includes.
11575 * inf-child.c: Fix common/ includes.
11576 * ia64-linux-nat.c: Fix common/ includes.
11577 * i387-tdep.c: Fix common/ includes.
11578 * i386-tdep.c: Fix common/ includes.
11579 * i386-linux-tdep.c: Fix common/ includes.
11580 * i386-linux-nat.c: Fix common/ includes.
11581 * i386-go32-tdep.c: Fix common/ includes.
11582 * i386-fbsd-tdep.c: Fix common/ includes.
11583 * i386-fbsd-nat.c: Fix common/ includes.
11584 * guile/scm-type.c: Fix common/ includes.
11585 * guile/guile.c: Fix common/ includes.
11586 * go32-nat.c: Fix common/ includes.
11587 * gnu-nat.c: Fix common/ includes.
11588 * gdbthread.h: Fix common/ includes.
11589 * gdbarch-selftests.c: Fix common/ includes.
11590 * gdb_usleep.c: Fix common/ includes.
11591 * gdb_select.h: Fix common/ includes.
11592 * gdb_bfd.c: Fix common/ includes.
11593 * gcore.c: Fix common/ includes.
11594 * fork-child.c: Fix common/ includes.
11595 * findvar.c: Fix common/ includes.
11596 * fbsd-nat.c: Fix common/ includes.
11597 * event-top.c: Fix common/ includes.
11598 * event-loop.c: Fix common/ includes.
11599 * dwarf2read.c: Fix common/ includes.
11600 * dwarf2loc.c: Fix common/ includes.
11601 * dwarf2-frame.c: Fix common/ includes.
11602 * dwarf-index-cache.c: Fix common/ includes.
11603 * dtrace-probe.c: Fix common/ includes.
11604 * disasm-selftests.c: Fix common/ includes.
11605 * defs.h: Fix common/ includes.
11606 * csky-tdep.c: Fix common/ includes.
11607 * cp-valprint.c: Fix common/ includes.
11608 * cp-support.h: Fix common/ includes.
11609 * cp-support.c: Fix common/ includes.
11610 * corelow.c: Fix common/ includes.
11611 * completer.h: Fix common/ includes.
11612 * completer.c: Fix common/ includes.
11613 * compile/compile.c: Fix common/ includes.
11614 * compile/compile-loc2c.c: Fix common/ includes.
11615 * compile/compile-cplus-types.c: Fix common/ includes.
11616 * compile/compile-cplus-symbols.c: Fix common/ includes.
11617 * command.h: Fix common/ includes.
11618 * cli/cli-dump.c: Fix common/ includes.
11619 * cli/cli-cmds.c: Fix common/ includes.
11620 * charset.c: Fix common/ includes.
11621 * build-id.c: Fix common/ includes.
11622 * btrace.h: Fix common/ includes.
11623 * btrace.c: Fix common/ includes.
11624 * breakpoint.h: Fix common/ includes.
11625 * breakpoint.c: Fix common/ includes.
11627 (enum agent_op): Fix common/ includes.
11628 * ax-general.c (struct aop_map): Fix common/ includes.
11629 * ax-gdb.c: Fix common/ includes.
11630 * auxv.c: Fix common/ includes.
11631 * auto-load.c: Fix common/ includes.
11632 * arm-tdep.c: Fix common/ includes.
11633 * arch/riscv.c: Fix common/ includes.
11634 * arch/ppc-linux-common.c: Fix common/ includes.
11635 * arch/i386.c: Fix common/ includes.
11636 * arch/arm.c: Fix common/ includes.
11637 * arch/arm-linux.c: Fix common/ includes.
11638 * arch/arm-get-next-pcs.c: Fix common/ includes.
11639 * arch/amd64.c: Fix common/ includes.
11640 * arch/aarch64.c: Fix common/ includes.
11641 * arch/aarch64-insn.c: Fix common/ includes.
11642 * arch-utils.c: Fix common/ includes.
11643 * amd64-windows-tdep.c: Fix common/ includes.
11644 * amd64-tdep.c: Fix common/ includes.
11645 * amd64-sol2-tdep.c: Fix common/ includes.
11646 * amd64-obsd-tdep.c: Fix common/ includes.
11647 * amd64-nbsd-tdep.c: Fix common/ includes.
11648 * amd64-linux-tdep.c: Fix common/ includes.
11649 * amd64-linux-nat.c: Fix common/ includes.
11650 * amd64-fbsd-tdep.c: Fix common/ includes.
11651 * amd64-fbsd-nat.c: Fix common/ includes.
11652 * amd64-dicos-tdep.c: Fix common/ includes.
11653 * amd64-darwin-tdep.c: Fix common/ includes.
11654 * agent.c: Fix common/ includes.
11655 * ada-lang.h: Fix common/ includes.
11656 * ada-lang.c: Fix common/ includes.
11657 * aarch64-tdep.c: Fix common/ includes.
11659 2019-01-25 Tom Tromey <tom@tromey.com>
11661 * common/create-version.sh: Use common/version.h.
11663 2019-01-24 Pedro Alves <palves@redhat.com>
11665 * infrun.c (signal_stop, signal_print, signal_program)
11666 (signal_catch, signal_pass): Now arrays instead of pointers.
11667 (update_signals_program_target, do_target_resume)
11668 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11669 * linux-nat.c (linux_nat_target::pass_signals)
11670 (linux_nat_target::create_inferior, linux_nat_target::attach):
11672 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11673 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11674 * procfs.c (procfs_target::pass_signals): Adjust.
11675 * record-full.c (record_full_target::resume): Adjust.
11676 * remote.c (remote_target::pass_signals)
11677 (remote_target::program_signals): Adjust.
11678 * target-debug.h (target_debug_print_signals): Now takes a
11679 gdb::array_view as parameter. Adjust.
11680 * target.h (target_ops) <pass_signals, program_signals>: Replace
11681 pointer and length parameters with gdb::array_view.
11682 (target_pass_signals, target_program_signals): Likewise.
11683 * target-delegates.c: Regenerate.
11685 2019-01-24 Pedro Alves <palves@redhat.com>
11687 * common/forward-scope-exit.h
11688 (forward_scope_exit::forward_scope_exit): Pass arguments to
11689 m_bind_function directly, instead of creating a std::bind and
11692 2019-01-24 Alan Hayward <alan.hayward@arm.com>
11694 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11695 for static members.
11696 (pass_in_v_vfp_candidate): Likewise.
11698 2019-01-23 Tom Tromey <tom@tromey.com>
11699 Pedro Alves <palves@redhat.com>
11701 * regcache.c (class regcache_invalidator): Remove.
11702 (regcache::raw_write): Use make_scope_exit.
11704 2019-01-23 Tom Tromey <tom@tromey.com>
11706 * ui-out.h (class ui_out_emit_type): Update comment.
11708 2019-01-23 Tom Tromey <tom@tromey.com>
11710 * infrun.c (fetch_inferior_event): Update comment.
11712 2019-01-23 Tom Tromey <tom@tromey.com>
11713 Pedro Alves <palves@redhat.com>
11715 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11717 (fetch_inferior_event): Use SCOPE_EXIT.
11720 2019-01-23 Tom Tromey <tom@tromey.com>
11721 Pedro Alves <palves@redhat.com>
11723 * infrun.c (disable_thread_events): Delete.
11724 (stop_all_threads): Use SCOPE_EXIT.
11726 2019-01-23 Tom Tromey <tom@tromey.com>
11727 Pedro Alves <palves@redhat.com>
11729 * symfile.c: Include forward-scope-exit.h.
11730 (clear_symtab_users_cleanup): Replace forward declaration with
11731 a FORWARD_SCOPE_EXIT.
11732 (syms_from_objfile_1): Use the forward_scope_exit and
11733 gdb::optional instead of cleanup_function.
11734 (reread_symbols): Use the forward_scope_exit instead of
11736 (clear_symtab_users_cleanup): Remove function.
11738 2019-01-23 Tom Tromey <tom@tromey.com>
11739 Pedro Alves <palves@redhat.com>
11741 * linux-nat.c: Include scope-exit.h.
11742 (cleanup_target_stop): Remove.
11743 (linux_nat_target::static_tracepoint_markers_by_strid): Use
11746 2019-01-23 Tom Tromey <tom@tromey.com>
11747 Pedro Alves <palves@redhat.com>
11749 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11750 (call_function_by_hand_dummy): Use SCOPE_EXIT.
11752 2019-01-23 Tom Tromey <tom@tromey.com>
11753 Andrew Burgess <andrew.burgess@embecosm.com>
11754 Pedro Alves <palves@redhat.com>
11756 * infrun.c (fetch_inferior_event): Use scope_exit.
11757 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11758 * top.c (execute_command): Use scope_exit.
11759 * breakpoint.c (bpstat_do_actions): Use scope_exit.
11760 * utils.c (do_bpstat_clear_actions_cleanup)
11761 (make_bpstat_clear_actions_cleanup): Remove.
11763 2019-01-23 Tom Tromey <tom@tromey.com>
11764 Pedro Alves <palves@redhat.com>
11766 * infrun.c: Include "common/scope-exit.h"
11767 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11768 (wait_for_inferior): Use SCOPE_EXIT.
11769 (fetch_inferior_event): Use scope_exit.
11771 2019-01-23 Tom Tromey <tom@tromey.com>
11772 Pedro Alves <palves@redhat.com>
11774 * breakpoint.c (create_breakpoint): Remove cleanup.
11776 2019-01-23 Tom Tromey <tom@tromey.com>
11777 Andrew Burgess <andrew.burgess@embecosm.com>
11778 Pedro Alves <palves@redhat.com>
11780 2019-01-23 Pedro Alves <palves@redhat.com>
11782 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11784 2019-01-23 Pedro Alves <palves@redhat.com>
11785 Andrew Burgess <andrew.burgess@embecosm.com>
11787 * gdbthread.h: Include "common/forward-scope-exit.h".
11788 (scoped_finish_thread_state): Redefine custom class in terms of
11789 forward_scope_exit.
11791 2019-01-23 Pedro Alves <palves@redhat.com>
11792 Andrew Burgess <andrew.burgess@embecosm.com>
11794 * common/forward-scope-exit.h: New file.
11796 2019-01-23 Pedro Alves <palves@redhat.com>
11797 Andrew Burgess <andrew.burgess@embecosm.com>
11798 Tom Tromey <tom@tromey.com>
11800 * common/scope-exit.h: New file.
11802 2019-01-23 Pedro Alves <palves@redhat.com>
11804 * common/preprocessor.h (ESC): Rename to ...
11805 (ESC_PARENS): ... this.
11806 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11807 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11809 2019-01-23 Tom Tromey <tom@tromey.com>
11811 * language.h (class scoped_switch_to_sym_language_if_auto):
11812 Initialize m_lang in both cases.
11814 2019-01-23 Alan Hayward <alan.hayward@arm.com>
11816 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11819 2019-01-22 Tom Tromey <tom@tromey.com>
11821 * corelow.c: Do not include sys/file.h.
11823 2019-01-22 Tom Tromey <tom@tromey.com>
11825 * tui/tui-wingeneral.h: Include gdb_curses.h.
11827 2019-01-22 Tom Tromey <tom@tromey.com>
11829 * source-cache.h (class source_cache) <get_source_lines,
11830 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11832 2019-01-22 Tom Tromey <tom@tromey.com>
11834 * remote-fileio.h (struct remote_target): Declare.
11836 2019-01-22 Tom Tromey <tom@tromey.com>
11838 * python/py-arch.c: Do not include py-ref.h.
11839 * python/py-bpevent.c: Do not include py-ref.h.
11840 * python/py-cmd.c: Do not include py-ref.h.
11841 * python/py-continueevent.c: Do not include py-ref.h.
11842 * python/py-event.h: Do not include py-ref.h.
11843 * python/py-evtregistry.c: Do not include py-ref.h.
11844 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11845 * python/py-frame.c: Do not include py-ref.h.
11846 * python/py-framefilter.c: Do not include py-ref.h.
11847 * python/py-function.c: Do not include py-ref.h.
11848 * python/py-infevents.c: Do not include py-ref.h.
11849 * python/py-linetable.c: Do not include py-ref.h.
11850 * python/py-objfile.c: Do not include py-ref.h.
11851 * python/py-param.c: Do not include py-ref.h.
11852 * python/py-prettyprint.c: Do not include py-ref.h.
11853 * python/py-progspace.c: Do not include py-ref.h.
11854 * python/py-symbol.c: Do not include py-ref.h.
11855 * python/py-symtab.c: Do not include py-ref.h.
11856 * python/py-type.c: Do not include py-ref.h.
11857 * python/py-unwind.c: Do not include py-ref.h.
11858 * python/py-utils.c: Do not include py-ref.h.
11859 * python/py-value.c: Do not include py-ref.h.
11860 * python/py-varobj.c: Do not include py-ref.h.
11861 * python/py-xmethods.c: Do not include py-ref.h.
11862 * python/python.c: Do not include py-ref.h.
11863 * varobj.c: Do not include py-ref.h.
11865 2019-01-22 Tom Tromey <tom@tromey.com>
11867 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11868 keyword for bcache.
11870 2019-01-22 Tom Tromey <tom@tromey.com>
11872 * compile/compile-cplus-types.c: Remove a comment by #include.
11874 2019-01-22 Tom Tromey <tom@tromey.com>
11876 * compile/gcc-c-plugin.h: Include compile-internal.h.
11878 2019-01-22 Tom Tromey <tom@tromey.com>
11880 * stabsread.c (EXTERN): Do not define.
11881 (symnum, next_symbol_text_func, processing_gcc_compilation)
11882 (within_function, global_sym_chain, global_stabs)
11883 (previous_stab_code, this_object_header_files)
11884 (n_this_object_header_files)
11885 (n_allocated_this_object_header_files): Define.
11886 * stabsread.h (EXTERN): Never define. Use "extern".
11888 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11890 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11893 2019-01-21 Tom Tromey <tom@tromey.com>
11895 * ui-out.c: Fix includes.
11896 * tui/tui-source.c: Fix includes.
11897 * target.c: Fix includes.
11898 * remote.c: Fix includes.
11899 * regcache.c: Fix includes.
11900 * python/py-block.c: Fix includes.
11901 * printcmd.c: Fix includes.
11902 * or1k-tdep.c: Fix includes.
11903 * mi/mi-main.c: Fix includes.
11904 * m32r-tdep.c: Fix includes.
11905 * csky-tdep.c: Fix includes.
11906 * compile/compile-cplus-types.c: Fix includes.
11907 * cli/cli-interp.c: Fix includes.
11909 2019-01-21 Alan Hayward <alan.hayward@arm.com>
11911 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11914 2019-01-16 Tom Tromey <tom@tromey.com>
11916 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11918 (struct objfile) <msymbols_range>: Move from top level.
11919 <msymbols>: New method.
11920 (class objfile_msymbols): Remove.
11921 * symtab.c (default_collect_symbol_completion_matches_break_on):
11923 * symmisc.c (dump_msymbols): Update.
11924 * stabsread.c (scan_file_globals): Update.
11925 * objc-lang.c (info_selectors_command, info_classes_command)
11926 (find_methods): Update.
11927 * minsyms.c (find_solib_trampoline_target): Update.
11928 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11929 * coffread.c (coff_symfile_read): Update.
11930 * ada-lang.c (ada_lookup_simple_minsym)
11931 (ada_collect_symbol_completion_matches): Update.
11933 2019-01-16 Tom Tromey <tom@tromey.com>
11935 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11936 type. Remove no-argument constructor.
11937 <iterator::operator++>: Simplify.
11939 <end>: Use minimal_symbol_count.
11941 2019-01-16 Tom Tromey <tom@tromey.com>
11943 * objfiles.h (struct objfile) <psymtabs>: New method.
11944 (class objfile_psymtabs): Remove.
11945 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11947 <range>: New method.
11948 (require_partial_symbols): Change return type.
11949 * psymtab.c (require_partial_symbols)
11950 (psym_expand_symtabs_matching): Update.
11951 * mdebugread.c (parse_partial_symbols): Update.
11952 * dbxread.c (dbx_end_psymtab): Update.
11954 2019-01-15 Tom Tromey <tom@tromey.com>
11956 * symtab.c (lookup_objfile_from_block)
11957 (lookup_symbol_in_objfile_symtabs)
11958 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11959 (find_line_symtab, info_sources_command)
11960 (default_collect_symbol_completion_matches_break_on)
11961 (make_source_files_completion_list): Update.
11962 * symmisc.c (print_objfile_statistics, dump_objfile)
11963 (maintenance_print_symbols, maintenance_info_symtabs)
11964 (maintenance_check_symtabs, maintenance_info_line_tables):
11966 * source.c (select_source_symtab)
11967 (forget_cached_source_info_for_objfile): Update.
11968 * objfiles.h (class objfile_compunits): Remove.
11969 (struct objfile) <compunits_range>: New typedef.
11970 (compunits): New method.
11971 * objfiles.c (objfile_relocate1): Update.
11972 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11973 * maint.c (count_symtabs_and_blocks): Update.
11974 * linespec.c (iterate_over_all_matching_symtabs): Update.
11975 * cp-support.c (add_symbol_overload_list_qualified): Update.
11976 * coffread.c (coff_symtab_read): Update.
11977 * ada-lang.c (add_nonlocal_symbols)
11978 (ada_collect_symbol_completion_matches)
11979 (ada_add_global_exceptions): Update.
11981 2019-01-15 Tom Tromey <tom@tromey.com>
11983 * progspace.h (program_space) <objfiles_safe_range>: New
11985 <objfiles_safe>: New method.
11986 * objfiles.h (class all_objfiles_safe): Remove.
11987 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11988 * jit.c (jit_inferior_exit_hook): Update.
11990 2019-01-17 Tom Tromey <tom@tromey.com>
11992 * progspace.h (program_space) <objfiles_range>: New typedef.
11993 <objfiles>: New method.
11994 <objfiles_head>: Rename from objfiles.
11995 (object_files): Update.
11996 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11997 * guile/scm-pretty-print.c
11998 (ppscm_find_pretty_printer_from_objfiles): Update.
11999 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12000 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12002 * python/py-progspace.c (pspy_get_objfiles): Update.
12003 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12005 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12006 (objfpy_lookup_objfile_by_build_id): Update.
12007 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12008 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12010 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12011 (expand_symtab_containing_pc, lookup_objfile_from_block)
12012 (lookup_static_symbol, basic_lookup_transparent_type)
12013 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12014 (find_line_symtab, info_sources_command)
12015 (default_collect_symbol_completion_matches_break_on)
12016 (make_source_files_completion_list, find_main_name): Update.
12017 * symmisc.c (print_symbol_bcache_statistics)
12018 (print_objfile_statistics, maintenance_print_symbols)
12019 (maintenance_print_msymbols, maintenance_print_objfiles)
12020 (maintenance_info_symtabs, maintenance_check_symtabs)
12021 (maintenance_expand_symtabs, maintenance_info_line_tables):
12023 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12024 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12025 (map_overlay_command, unmap_overlay_command)
12026 (simple_overlay_update, expand_symtabs_matching)
12027 (map_symbol_filenames): Update.
12028 * symfile-debug.c (set_debug_symfile): Update.
12029 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12031 * source.c (select_source_symtab, forget_cached_source_info):
12033 * solib.c (solib_read_symbols): Update.
12034 * solib-spu.c (append_ocl_sos): Update.
12035 * psymtab.c (maintenance_print_psymbols)
12036 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12037 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12038 * printcmd.c (info_symbol_command): Update.
12039 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12041 * objfiles.h (class all_objfiles): Remove.
12042 * objfiles.c (have_partial_symbols, have_full_symbols)
12043 (have_minimal_symbols, qsort_cmp, update_section_map)
12044 (shared_objfile_contains_address_p)
12045 (default_iterate_over_objfiles_in_search_order): Update.
12046 * objc-lang.c (info_selectors_command, info_classes_command)
12047 (find_methods): Update.
12048 * minsyms.c (find_solib_trampoline_target): Update.
12049 * maint.c (maintenance_info_sections)
12050 (maintenance_translate_address, count_symtabs_and_blocks):
12052 * main.c (captured_main_1): Update.
12053 * linux-thread-db.c (try_thread_db_load_from_pdir)
12054 (has_libpthread): Update.
12055 * linespec.c (iterate_over_all_matching_symtabs)
12056 (search_minsyms_for_name): Update.
12057 * jit.c (jit_find_objf_with_entry_addr): Update.
12058 * hppa-tdep.c (find_unwind_entry)
12059 (hppa_lookup_stub_minimal_symbol): Update.
12060 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12062 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12063 (elf_gnu_ifunc_resolve_by_got): Update.
12064 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12065 * dwarf-index-write.c (save_gdb_index_command): Update.
12066 * cp-support.c (add_symbol_overload_list_qualified): Update.
12067 * breakpoint.c (create_overlay_event_breakpoint)
12068 (create_longjmp_master_breakpoint)
12069 (create_std_terminate_master_breakpoint)
12070 (create_exception_master_breakpoint): Update.
12071 * blockframe.c (find_pc_partial_function): Update.
12072 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12073 (ada_collect_symbol_completion_matches)
12074 (ada_add_global_exceptions): Update.
12076 2019-01-17 Tom Tromey <tom@tromey.com>
12078 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12080 (solib_target_parse_libraries): Change return type.
12081 (library_list_start_segment, library_list_start_section)
12082 (library_list_end_library, library_list_start_library); Update.
12083 (solib_target_free_library_list): Remove.
12084 (solib_target_parse_libraries): Remove cleanup. Change return
12086 (solib_target_current_sos): Update.
12088 2019-01-17 Tom Tromey <tromey@bapiya>
12090 * valprint.c: Replace "the the" with "the".
12091 * symtab.c: Replace "the the" with "the".
12092 * solib.c: Replace "the the" with "the".
12093 * solib-dsbt.c: Replace "the the" with "the".
12094 * linespec.c: Replace "the the" with "the".
12095 * dwarf2loc.h: Replace "the the" with "the".
12096 * amd64-windows-tdep.c: Replace "the the" with "the".
12097 * aarch64-tdep.c: Replace "the the" with "the".
12099 2019-01-16 Keith Seitz <keiths@redhat.com>
12102 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12103 <builder>: Rename to ..
12104 <m_builder>: ... this and make private.
12105 (dwarf2_cu::get_builder): New method. Change all users of
12106 `builder' to use this method.
12107 (dwarf2_start_symtab): Move to ...
12108 (dwarf2_cu::start_symtab): ... here. Update all callers
12109 (setup_type_unit_groups): Move to ...
12110 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12112 (dwarf2_cu::reset_builder): New method.
12113 (process_full_compunit, process_full_type_unit): Use
12114 dwarf2_cu::reset_builder.
12115 (follow_die_offset): Record the ancestor CU if it is different
12116 from the followed DIE's CU.
12117 (follow_die_sig_1): Likewise.
12119 2019-01-15 Tom Tromey <tom@tromey.com>
12121 * remote.c (class remote_state) <buf>: Now a char_vector.
12122 <buf_size>: Remove.
12123 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12125 (remote_target::getpkt_or_notif_sane_1)
12126 (remote_target::getpkt_sane)
12127 (remote_target::getpkt_or_notif_sane): Likewise.
12128 (class remote_target) <putpkt>: New overload.
12129 (remote_target::read_frame): Change type of "buf_p". Remove
12130 sizeof_p parameter.
12131 (packet_ok): New overload.
12132 (packet_check_result): New overload.
12135 2019-01-14 Tom Tromey <tom@tromey.com>
12137 * remote-notif.c (handle_notification, remote_notif_ack)
12138 (remote_notif_parse): Make "buf" const.
12139 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12141 (remote_notif_parse, remote_notif_ack, handle_notification):
12143 * remote.c (remote_notif_stop_parse): Make "buf" const.
12144 (remote_target::remote_parse_stop_reply): Make "buf" const.
12145 (remote_notif_stop_ack): Make "buf" const.
12147 2019-01-14 Tom Tromey <tom@tromey.com>
12149 * remote.c (remote_console_output): Make parameter const.
12151 2019-01-14 Tom Tromey <tom@tromey.com>
12153 * target-debug.h (target_debug_print_signals): Constify.
12154 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12155 * procfs.c (procfs_target::pass_signals): Update.
12156 * linux-nat.c (linux_nat_target::pass_signals): Update.
12157 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12158 * target-delegates.c: Rebuild.
12159 * remote.c (remote_target::program_signals): Update.
12160 (remote_target::pass_signals): Update.
12161 * target.c (target_pass_signals): Constify argument.
12162 (target_program_signals): Likewise.
12163 * target.h (struct target_ops) <pass_signals, program_signals>:
12165 (target_pass_signals, target_program_signals): Constify argument.
12167 2019-01-14 Tom Tromey <tom@tromey.com>
12170 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12172 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12174 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12176 * rs6000-tdep.c: Include reggroups.h.
12177 (IS_V_ALIAS_PSEUDOREG): Define.
12178 (rs6000_register_name): Return names for the "vX" aliases.
12179 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12180 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12181 aliases. Call default_register_reggroup_p for all other
12183 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12185 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12186 Handle "vX" aliases.
12187 (v_alias_pseudo_register_collect): New function.
12188 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12189 (rs6000_gdbarch_init): Initialize "vX" aliases as
12190 pseudo-registers. Restore registration of
12191 rs6000_pseudo_register_reggroup_p with
12192 set_tdesc_pseudo_register_reggroup_p.
12194 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12196 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12197 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12198 set_gdbarch_num_pseudo_regs.
12200 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12202 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12203 Remove arg prefixname, add do_set and do_show.
12204 Add member functions set_list and show_list.
12205 * cli/cli-style.c (class cli_style_option): Update accordingly.
12206 (style_set_list): Move to file scope.
12207 (style_show_list): Likewise.
12208 (set_style): Call help_list.
12209 (show_style): Call cmd_show_list.
12210 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12211 Update to use the new macro.
12213 2019-10-12 Joel Brobecker <brobecker@adacore.com>
12215 * ada-lang.c (_initialize_ada_language): Expand the help text
12216 for the "catch exception" command.
12218 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12220 * symtab.c (matching_obj_sections): Initialize obj,
12221 declare it closer to its usage.
12223 2019-01-10 Tom Tromey <tom@tromey.com>
12225 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12226 (basic_inf_threads_range): Remove.
12227 (inf_threads_range, inf_non_exited_threads_range)
12228 (safe_inf_threads_range): Use next_adapter.
12230 2019-01-10 Keith Seitz <keiths@redhat.com>
12234 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12235 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12237 2019-01-10 Keith Seitz <keiths@redhat.com>
12241 * dictionary.c (pending_to_vector): Remove.
12242 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12243 Remove _1 suffix, replacing functions of the same name. Update
12245 (dict_create_hashed, dict_create_hashed_expandable)
12246 (dict_create_linear, dict_create_linear_expandable, dict_free)
12247 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12248 Make functions static.
12250 2019-01-10 Keith Seitz <keiths@redhat.com>
12254 * dictionary.h (struct dictionary): Replace declaration with
12256 (dict_create_hashed, dict_create_hashed_expandable)
12257 (dict_create_linear, dict_create_linear_expandable)
12258 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12259 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12260 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12261 taking multidictionary argument.
12262 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12263 * block.h (struct block) <dict>: Change to multidictionary
12264 and rename `multidict'.
12265 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12266 symmisc.c: Update all dictionary references to multidictionary.
12268 2019-01-10 Keith Seitz <keiths@redhat.com>
12272 * dictionary.c: Include unordered_map.
12273 (pending_to_vector): New function.
12274 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12275 Rewrite the non-"_1" functions to take vector instead
12277 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12278 "new" _1 versions of the same name.
12279 (multidictionary): Define.
12280 (std::hash<enum language): New definition.
12281 (collate_pending_symbols_by_language, mdict_create_hashed)
12282 (mdict_create_hashed_expandable, mdict_create_linear)
12283 (mdict_create_linear_expandable, mdict_free)
12284 (find_language_dictionary, create_new_language_dictionary)
12285 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12286 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12287 (mdict_size, mdict_empty): New functions.
12288 * dictionary.h (mdict_iterator): Define.
12290 2019-01-10 Pedro Alves <palves@redhat.com>
12292 * breakpoint.c (read_uploaded_action)
12293 (create_tracepoint_from_upload): Adjust to use
12294 gdb::unique_xmalloc_ptr.
12295 * ctf.c (ctf_write_uploaded_tp):
12296 (SET_ARRAY_FIELD): Use emplace_back.
12297 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12298 * tracefile-tfile.c (tfile_write_uploaded_tp):
12299 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12300 gdb::unique_xmalloc_ptr.
12301 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12302 at_string, cond_string, cmd_strings>: Replace char pointers
12303 with gdb::unique_xmalloc_ptr.
12305 2019-01-10 Pedro Alves <palves@redhat.com>
12307 * solib-target.c (library_list_start_library): Don't xstrdup name.
12309 2019-01-10 Pedro Alves <palves@redhat.com>
12311 * mdebugread.c (parse_partial_symbols): Use
12312 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12314 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12316 * linux-fork.c (scoped_switch_fork_info)
12317 <~scoped_switch_fork_info>: Fix incorrect variable name.
12319 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12321 * linux-fork.c (scoped_switch_fork_info)
12322 <scoped_switch_fork_info>: Make explicit.
12323 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12325 2019-01-10 Tom Tromey <tom@tromey.com>
12327 * objfiles.h (objfile::reset_psymtabs): Update.
12328 * objfiles.c (objfile::objfile): Update.
12329 * psymtab.h (psymtab_storage::obstack): Update.
12330 (psymtab_storage::m_obstack): Use gdb::optional.
12331 (class psymtab_storage): Update comment. Remove objfile
12333 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12335 2019-01-10 Tom Tromey <tom@tromey.com>
12337 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12338 <free_psymtabs>: Now private.
12339 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12340 (allocate_psymtab): Use new method.
12342 2019-01-10 Tom Tromey <tom@tromey.com>
12344 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12345 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12346 * mdebugread.c (parse_partial_symbols): Use
12347 allocate_dependencies.
12348 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12349 allocate_dependencies.
12350 (process_psymtab_comp_unit_reader)
12351 (build_type_psymtab_dependencies): Likewise.
12352 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12354 2019-01-10 Tom Tromey <tom@tromey.com>
12356 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12357 PSYMBOL_SET_LANGUAGE.
12358 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12360 2019-01-10 Tom Tromey <tom@tromey.com>
12362 * psymtab.h (psymtab_storage::obstack): New method.
12363 <m_obstack>: Rename from obstack; now private.
12364 * psymtab.c (psymtab_storage): Update.
12365 * dwarf2read.c (create_addrmap_from_index)
12366 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12369 2019-01-10 Tom Tromey <tom@tromey.com>
12371 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12372 * objfiles.h (objfile::reset_psymtabs): New method.
12374 2019-01-10 Tom Tromey <tom@tromey.com>
12376 * symmisc.c (print_symbol_bcache_statistics): Update.
12377 (print_objfile_statistics): Update.
12378 * symfile.c (reread_symbols): Update.
12379 * psymtab.h (class psymtab_storage): New.
12380 * psymtab.c (psymtab_storage): New constructor.
12381 (~psymtab_storage): New destructor.
12382 (require_partial_symbols): Update.
12383 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12384 (find_pc_sect_psymtab, find_pc_sect_psymbol)
12385 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12386 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12387 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12388 (start_psymtab_common, end_psymtab_common)
12389 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12390 (allocate_psymtab): Update.
12391 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12393 (dump_psymtab_addrmap, maintenance_print_psymbols)
12394 (maintenance_check_psymtabs): Update.
12395 (class objfile_psymtabs): Move to objfiles.h.
12396 * psympriv.h (discard_psymtab): Now inline.
12397 (psymtab_discarder::psymtab_discarder): Update.
12398 (psymtab_discarder::~psymtab_discarder): Update.
12399 (ALL_OBJFILE_PSYMTABS): Rewrite.
12400 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12401 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12403 <partial_symtabs>: New field.
12404 (class objfile_psymtabs): Move from psymtab.h. Update.
12405 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12407 (objfile::~objfile): Don't destroy psymbol_cache.
12408 * mdebugread.c (parse_partial_symbols): Update.
12409 * dwarf2read.c (create_addrmap_from_index)
12410 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12411 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12412 (add_partial_subprogram, dwarf2_ranges_read): Update.
12413 * dwarf-index-write.c (write_address_map)
12414 (write_one_signatured_type, recursively_write_psymbols)
12415 (class debug_names, class debug_names, write_psymtabs_to_index):
12418 2019-01-10 Tom Tromey <tom@tromey.com>
12420 * symtab.h (SYMBOL_SET_NAMES): Update.
12421 (symbol_set_names): Update.
12422 (MSYMBOL_SET_NAMES): Update.
12423 * symtab.c (symbol_set_names): Change argument to be an
12424 objfile_per_bfd_storage.
12425 * psymtab.c (add_psymbol_to_bcache): Update.
12426 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12428 2019-01-10 Tom Tromey <tom@tromey.com>
12430 * symtab.c (create_demangled_names_hash): Change argument to be an
12431 objfile_per_bfd_storage.
12432 (symbol_set_names): Update.
12434 2019-01-10 Tom Tromey <tom@tromey.com>
12436 * xcoffread.c (xcoff_initial_scan): Unconditionally call
12438 * psymtab.c (init_psymbol_list): Do nothing if already called.
12439 * psympriv.h (init_psymbol_list): Add comment.
12440 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12442 * dbxread.c (dbx_symfile_read): Unconditionally call
12445 2019-01-10 Tom Tromey <tom@tromey.com>
12447 * xcoffread.c (scan_xcoff_symtab): Update.
12448 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12450 * mdebugread.c (parse_partial_symbols)
12451 (handle_psymbol_enumerators): Update.
12452 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12453 * dbxread.c (read_dbx_symtab): Update.
12454 * psympriv.h (psymbol_placement): New enum.
12455 (add_psymbol_to_list): Update.
12457 2019-01-10 Tom Tromey <tom@tromey.com>
12459 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12460 static_psymbols parameters.
12461 (scan_xcoff_symtab): Update.
12462 * psymtab.c (start_psymtab_common): Remove global_psymbols and
12463 static_psymbols parameters.
12464 * psympriv.h (start_psymtab_common): Update.
12465 * mdebugread.c (parse_partial_symbols): Update.
12466 * dwarf2read.c (create_partial_symtab): Update.
12467 * dbxread.c (read_dbx_symtab): Update.
12468 (start_psymtab): Remove global_psymbols and static_psymbols
12471 2019-01-10 Tom Tromey <tom@tromey.com>
12473 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12474 * psymtab.c (allocate_psymtab): Add comment.
12475 * psympriv.h (allocate_psymtab): Add comment.
12476 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12478 * dbxread.c (dbx_end_psymtab): Remove some initializations.
12480 2019-01-10 Tom Tromey <tom@tromey.com>
12482 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12484 * mipsread.c: Include mdebugread.h.
12485 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12487 * elfread.c: Include mdebugread.h.
12489 2019-01-09 Tom Tromey <tom@tromey.com>
12491 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12492 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12493 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12494 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12495 (psym_lookup_symbol, psym_find_last_source_symtab)
12496 (psym_forget_cached_source_info, psym_print_stats)
12497 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12498 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12499 (psym_map_matching_symbols, psym_expand_symtabs_matching)
12500 (psym_find_compunit_symtab_by_address)
12501 (maintenance_print_psymbols, maintenance_info_psymtabs)
12502 (maintenance_check_psymtabs): Use ranged for.
12503 * psymtab.h (class objfile_psymtabs): New.
12504 (require_partial_symbols): Return objfile_psymtabs.
12505 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12507 2019-01-09 Tom Tromey <tom@tromey.com>
12509 * symfile.c (overlay_invalidate_all, find_pc_overlay)
12510 (find_pc_mapped_section, list_overlays_command)
12511 (map_overlay_command, unmap_overlay_command)
12512 (simple_overlay_update): Use all_objfiles.
12513 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12514 * printcmd.c (info_symbol_command): Use all_objfiles.
12515 * objfiles.h (ALL_OBJSECTIONS): Remove.
12516 * maint.c (maintenance_translate_address): Use all_objfiles.
12517 * gcore.c (gcore_create_callback): Use all_objfiles.
12518 (objfile_find_memory_regions): Likewise.
12520 2019-01-09 Tom Tromey <tom@tromey.com>
12522 * symtab.c (find_line_symtab, info_sources_command)
12523 (make_source_files_completion_list): Use objfile_compunits.
12524 * source.c (select_source_symtab): Use objfile_compunits.
12525 * objfiles.h (struct objfile): Update comment.
12526 (ALL_OBJFILES): Remove.
12527 (ALL_FILETABS): Remove.
12528 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12531 2019-01-09 Tom Tromey <tom@tromey.com>
12533 * symmisc.c (print_objfile_statistics, dump_objfile)
12534 (maintenance_print_symbols): Use compunit_filetabs.
12535 * source.c (forget_cached_source_info_for_objfile): Use
12537 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12538 (ALL_FILETABS): Use compunit_filetabs.
12539 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12540 * coffread.c (coff_symtab_read): Use compunit_filetabs.
12542 2019-01-09 Tom Tromey <tom@tromey.com>
12544 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12545 (compunit_filetabs): New.
12546 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12548 (info_sources_command, make_source_files_completion_list): Remove
12550 * symmisc.c (print_objfile_statistics, dump_objfile)
12551 (maintenance_print_symbols): Remove declaration.
12552 (maintenance_info_symtabs): Use compunit_filetabs.
12553 (maintenance_info_line_tables): Likewise.
12554 * source.c (select_source_symtab): Change local variable name.
12555 (forget_cached_source_info_for_objfile): Remove declaration.
12556 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12557 * objfiles.c (objfile_relocate1): Remove declaration.
12558 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12560 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12561 * coffread.c (coff_symtab_read): Remove declaration.
12562 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12565 2019-01-09 Tom Tromey <tom@tromey.com>
12567 * symtab.c (lookup_objfile_from_block)
12568 (find_pc_sect_compunit_symtab, search_symbols)
12569 (default_collect_symbol_completion_matches_break_on): Use
12571 * objfiles.h (ALL_COMPUNITS): Remove.
12572 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12573 * cp-support.c (add_symbol_overload_list_qualified): Use
12575 * ada-lang.c (ada_collect_symbol_completion_matches)
12576 (ada_add_global_exceptions): Use objfile_compunits.
12578 2019-01-09 Tom Tromey <tom@tromey.com>
12580 * source.c (select_source_symtab)
12581 (forget_cached_source_info_for_objfile): Remove declaration.
12582 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12584 * maint.c (count_symtabs_and_blocks): Remove declaration.
12585 * cp-support.c (add_symbol_overload_list_qualified): Remove
12587 * coffread.c (coff_symtab_read): Remove declaration.
12588 * symtab.c (lookup_symbol_in_objfile_symtabs)
12589 (basic_lookup_transparent_type_1): Use objfile_compunits.
12590 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12591 (info_sources_command, search_symbols)
12592 (default_collect_symbol_completion_matches_break_on)
12593 (make_source_files_completion_list): Remove declaration.
12594 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12595 (ada_collect_symbol_completion_matches)
12596 (ada_add_global_exceptions): Remove declaration.
12597 * linespec.c (iterate_over_all_matching_symtabs): Use
12599 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12600 (class objfile_compunits): New.
12601 (ALL_COMPUNITS): Use objfile_compunits.
12602 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12603 (maintenance_check_symtabs, maintenance_info_line_tables): Use
12605 * objfiles.c (objfile_relocate1): Use objfile_compunits.
12607 2019-01-09 Tom Tromey <tom@tromey.com>
12609 * symtab.c (search_symbols)
12610 (default_collect_symbol_completion_matches_break_on): Use
12612 * ada-lang.c (ada_lookup_simple_minsym)
12613 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12614 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12615 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12617 * coffread.c (coff_symfile_read): Use objfile_msymbols.
12618 * symmisc.c (dump_msymbols): Use objfile_msymbols.
12619 * objc-lang.c (find_methods): Use objfile_msymbols.
12620 (info_selectors_command, info_classes_command): Likewise.
12621 * stabsread.c (scan_file_globals): Use objfile_msymbols.
12622 * objfiles.h (class objfile_msymbols): New.
12623 (ALL_OBJFILE_MSYMBOLS): Remove.
12624 (ALL_MSYMBOLS): Remove.
12626 2019-01-09 Tom Tromey <tom@tromey.com>
12628 * common/next-iterator.h (next_adapter): Add Iterator template
12630 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12631 (class all_objfiles_safe): New.
12632 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12633 * objfiles.c (put_objfile_before): Update comment.
12634 (add_separate_debug_objfile): Likewise.
12635 (free_all_objfiles): Use all_objfiles_safe.
12636 (objfile_purge_solibs): Likewise.
12638 2019-01-09 Tom Tromey <tom@tromey.com>
12640 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12641 (expand_symtab_containing_pc, lookup_static_symbol)
12642 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12643 (find_symbol_at_address, find_line_symtab, find_main_name): Use
12645 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12646 * breakpoint.c (create_overlay_event_breakpoint)
12647 (create_longjmp_master_breakpoint)
12648 (create_std_terminate_master_breakpoint)
12649 (create_exception_master_breakpoint): Use all_objfiles.
12650 * linux-thread-db.c (try_thread_db_load_from_pdir)
12651 (has_libpthread): Use all_objfiles.
12652 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12653 * linespec.c (iterate_over_all_matching_symtabs)
12654 (search_minsyms_for_name): Use all_objfiles.
12655 * maint.c (maintenance_info_sections): Use all_objfiles.
12656 * main.c (captured_main_1): Use all_objfiles.
12657 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12658 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12659 * guile/scm-pretty-print.c
12660 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12661 * solib-spu.c (append_ocl_sos): Use all_objfiles.
12662 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12663 (maintenance_print_msymbols): Use all_objfiles.
12664 * source.c (select_source_symtab): Use all_objfiles.
12665 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12666 * symfile.c (remove_symbol_file_command)
12667 (expand_symtabs_matching, map_symbol_filenames): Use
12669 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12671 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12672 * objc-lang.c (find_methods): Use all_objfiles.
12673 * objfiles.c (have_partial_symbols, have_full_symbols)
12674 (have_minimal_symbols, qsort_cmp)
12675 (default_iterate_over_objfiles_in_search_order): Use
12677 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12678 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12679 (maintenance_check_psymtabs): Use all_objfiles.
12680 (ALL_PSYMTABS): Remove.
12681 * compile/compile-object-run.c (do_module_cleanup): Use
12683 * blockframe.c (find_pc_partial_function): Use all_objfiles.
12684 * cp-support.c (add_symbol_overload_list_qualified): Use
12686 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12688 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12689 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12691 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12692 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12693 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12695 * solib.c (solib_read_symbols): Use all_objfiles
12697 2019-01-09 Tom Tromey <tom@tromey.com>
12699 * probe.c (parse_probes_in_pspace): Use all_objfiles.
12700 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12702 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12703 * symmisc.c (print_symbol_bcache_statistics)
12704 (print_objfile_statistics, maintenance_print_objfiles)
12705 (maintenance_info_symtabs, maintenance_check_symtabs)
12706 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12708 * source.c (forget_cached_source_info): Use all_objfiles.
12709 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12710 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12711 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12712 * objfiles.c (update_section_map): Use all_objfiles.
12713 (shared_objfile_contains_address_p): Likewise.
12714 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12715 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12717 2019-01-09 Tom Tromey <tom@tromey.com>
12719 * common/next-iterator.h: New file.
12720 * objfiles.h (class all_objfiles): New.
12721 (struct objfile_iterator): New.
12723 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12725 * NEWS: Move the description of the changed "frame", "select-frame",
12726 and "info frame" commands to the Changed commands section.
12728 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
12730 * gdbtypes.c (check_stub_method_group): Remove handling of old
12732 * linespec.c (find_methods): Likewise.
12733 * stabsread.c (read_member_functions): Likewise.
12734 * valops.c (search_struct_method): Likewise.
12735 (value_struct_elt_for_reference): Likewise.
12736 * NEWS: Mention this change.
12738 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
12740 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12741 print_source_lines.
12742 * source.c (print_source_lines_base): Update line number check.
12743 (print_source_lines): New function.
12744 (source_lines_range::source_lines_range): New function.
12745 * source.h (class source_lines_range): New class.
12746 (print_source_lines): New declaration.
12748 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12750 * linespec.c (linespec_state_destructor): Free self->canonical_names.
12752 2019-01-08 Tom Tromey <tom@tromey.com>
12753 Simon Marchi <simon.marchi@ericsson.com>
12756 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12757 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12758 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12759 * f-exp.y (DOLLAR_VARIABLE): Likewise.
12760 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12761 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12763 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12765 * source.c (select_source_symtab): Move header comment to
12766 declaration in source.h.
12767 (forget_cached_source_info_for_objfile): Likewise.
12768 (forget_cached_source_info): Likewise.
12769 (identify_source_line): Likewise.
12770 * source.h (identify_source_line): Move declaration from symtab.h
12771 and add comment from source.c
12772 (print_source_lines): Likewise.
12773 (forget_cached_source_info_for_objfile): Likewise.
12774 (forget_cached_source_info): Likewise.
12775 (select_source_symtab): Likewise.
12776 (enum print_source_lines_flag): Move definition from symtab.h.
12777 * symtab.h (identify_source_line): Move declaration to source.h.
12778 (print_source_lines): Likewise.
12779 (forget_cached_source_info_for_objfile): Likewise.
12780 (forget_cached_source_info): Likewise.
12781 (select_source_symtab): Likewise.
12782 (enum print_source_lines_flag): Move definition to source.h.
12783 * tui/tui-hooks.c: Add 'source.h' include.
12785 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12787 * source.c (print_source_lines_base): Handle requests to print
12788 reverse line number sequences, and guard against empty lines
12791 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12793 * source.c (print_source_lines_base): Fix skip of '\r' if next
12796 2019-01-06 Tom Tromey <tom@tromey.com>
12798 * c-exp.y (struct c_parse_state) <macro_original_text,
12799 expansion_obstack>: New member.
12800 (macro_original_text, expansion_obstack): Remove globals.
12801 (scan_macro_expansion, scanning_macro_expansion)
12802 (finished_macro_expansion): Update.
12803 (scan_macro_cleanup): Remove.
12804 (yylex, c_parse): Update.
12806 2019-01-06 Tom Tromey <tom@tromey.com>
12808 * c-exp.y (struct c_parse_state) <strings>: New member.
12809 (operator_stoken): Update.
12811 2019-01-06 Tom Tromey <tom@tromey.com>
12813 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12814 (union type_stack_elt) <typelist_val>: Now a pointer to
12816 (type_stack_cleanup): Don't declare.
12817 (push_typelist): Update.
12818 * parse.c (pop_typelist): Return a std::vector.
12819 (push_typelist): Take a std::vector.
12820 (follow_types): Update. Do not free args.
12821 (type_stack_cleanup): Remove.
12822 * c-exp.y (struct c_parse_state): New.
12823 (cpstate): New global.
12824 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12825 (nonempty_typelist): Update.
12826 (func_mod): Create a new vector.
12827 (c_parse): Create a c_parse_state.
12828 (check_parameter_typelist): Do not delete params.
12829 (function_method): Update. Do not delete type_list.
12831 2019-01-06 Tom Tromey <tom@tromey.com>
12834 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12836 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12837 (print_return_value): Likewise.
12839 2019-01-05 Tom Tromey <tom@tromey.com>
12841 * contrib/cleanup_check.py: Remove.
12842 * contrib/gcc-with-excheck: Remove.
12843 * contrib/exsummary.py: Remove.
12844 * contrib/excheck.py: Remove.
12846 2019-01-05 Joel Brobecker <brobecker@adacore.com>
12848 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12849 NULL. Initialize tpprev to NULL instead of assigning it
12850 to NULL on the next statement.
12851 * windows-nat.c (windows_delete_thread): Remove check for
12852 main_thread_id before printing thread exit notifications.
12853 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12854 Remove thread ID check against main_thread_id.
12855 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12856 windows_delete_thread.
12857 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12859 2019-01-04 Tom Tromey <tom@tromey.com>
12861 * compile/compile.c (_initialize_compile): Use upper case for
12862 metasyntactic variables.
12863 * symmisc.c (_initialize_symmisc): Use upper case for
12864 metasyntactic variables.
12865 * psymtab.c (_initialize_psymtab): Use upper case for
12866 metasyntactic variables.
12867 * demangle.c (demangle_command): Use upper case for metasyntactic
12869 (_initialize_demangler): Likewise.
12870 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12873 2019-01-03 Tom Tromey <tom@tromey.com>
12875 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12877 2019-01-03 Tom Tromey <tom@tromey.com>
12879 * python/py-symtab.c (salpy_str): Update.
12880 (struct salpy_sal_object) <symtab>: Now a PyObject.
12881 (salpy_dealloc): Update.
12882 (del_objfile_sal): Use gdbpy_ref.
12884 2019-01-03 Tom Tromey <tom@tromey.com>
12886 * python/py-type.c (convert_field): Use new_reference. Return
12888 (make_fielditem): Return gdbpy_ref.
12889 (typy_fields): Update.
12890 (typy_getitem): Update.
12891 (field_name): Return gdbpy_ref. Use new_reference.
12892 (typy_iterator_iternext): Update.
12894 2019-01-03 Tom Tromey <tom@tromey.com>
12896 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12898 2019-01-03 Tom Tromey <tom@tromey.com>
12900 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12901 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12902 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12903 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12904 (pspy_set_type_printers): Likewise.
12905 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12906 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12907 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12908 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12909 (objfpy_set_type_printers): Likewise.
12911 2019-01-03 Tom Tromey <tom@tromey.com>
12913 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12914 (gdbpy_print_stack): Use gdbpy_err_fetch.
12915 * python/python-internal.h (class gdbpy_err_fetch): New class.
12916 (class gdbpy_enter) <m_error_type, m_error_value,
12917 m_error_traceback>: Remove.
12918 <m_error>: New member.
12919 (gdbpy_exception_to_string): Don't declare.
12920 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12921 * python/py-value.c (convert_value_from_python): Use
12923 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12924 gdbpy_exception_to_string.
12925 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12926 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12929 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12931 * linux-nat.c (delete_lwp_cleanup): Delete.
12932 (struct lwp_deleter): New struct.
12933 (lwp_info_up): New typedef.
12934 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12937 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12939 * linux-fork.c (class scoped_switch_fork_info): New class.
12940 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12942 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12944 * valops.c (find_overload_match): Remove use of null_cleanup, and
12945 calls to do_cleanups.
12947 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12949 * compile/compile-cplus-types.c
12950 (compile_cplus_instance::decl_name): Handle changes to
12952 * cp-support.c (cp_func_name): Update header comment, update
12954 * cp-support.h (cp_func_name): Update return type in declaration.
12955 * valops.c (find_overload_match): Move temp_func local to top
12956 level of function and change its type. Use temp_func to hold and
12957 delete temporary string obtained from cp_func_name.
12959 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12961 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12962 gdb::char_vector, remove cleanup, and update uses of `msg`.
12964 2019-01-03 Jim Wilson <jimw@sifive.com>
12966 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12968 2019-01-02 Tom Tromey <tom@tromey.com>
12970 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12971 (tdesc_parse_xml): Remove cleanups.
12972 * target-descriptions.h (make_cleanup_free_target_description):
12974 (target_desc_deleter): New struct.
12975 (target_desc_up): New typedef.
12976 * target-descriptions.c (target_desc_deleter::operator()): Rename
12977 from free_target_description.
12978 (make_cleanup_free_target_description): Remove.
12980 2019-01-02 Tom Tromey <tom@tromey.com>
12982 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12983 constructor, destructor.
12984 (linespec_parser): Remove typedef.
12985 (~linespec_parser): Rename from linespec_parser_delete.
12986 (linespec_lex_to_end, linespec_complete_label)
12987 (linespec_complete): Update.
12988 (decode_line_full): Remove cleanups.
12989 (decode_line_1): Update.
12991 2019-01-02 Tom Tromey <tom@tromey.com>
12993 * python/python-internal.h (inferior_to_inferior_object): Change
12995 * python/py-exitedevent.c (create_exited_event_object): Update.
12996 * python/py-inferior.c (inferior_to_inferior_object): Return
12998 (python_new_inferior, python_inferior_deleted)
12999 (thread_to_thread_object, delete_thread_object)
13000 (build_inferior_list, gdbpy_selected_inferior): Update.
13001 * python/py-infthread.c (create_thread_object): Update. Also fail
13002 if inferior_to_inferior_object fails.
13004 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13006 * inferior.h (class inferior) <displaced_step_state>: New field.
13007 * infrun.h (struct displaced_step_state): Move here from
13008 infrun.c. Initialize fields, add constructor.
13009 <inf>: Remove field.
13010 <reset>: New method.
13011 * infrun.c (struct displaced_step_inferior_state): Move to
13013 (displaced_step_inferior_states): Remove.
13014 (get_displaced_stepping_state): Adust.
13015 (displaced_step_in_progress_any_inferior): Adjust.
13016 (displaced_step_in_progress_thread): Adjust.
13017 (displaced_step_in_progress): Adjust.
13018 (add_displaced_stepping_state): Remove.
13019 (get_displaced_step_closure_by_addr): Adjust.
13020 (remove_displaced_stepping_state): Remove.
13021 (infrun_inferior_exit): Call displaced_step_state.reset.
13022 (use_displaced_stepping): Don't check for NULL.
13023 (displaced_step_prepare_throw): Call
13024 get_displaced_stepping_state.
13025 (displaced_step_fixup): Don't check for NULL.
13026 (prepare_for_detach): Don't check for NULL.
13028 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13030 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13031 in case of call that did not complete.
13033 2019-01-02 Andrey Utkin <autkin@undo.io>
13035 * symfile.c (find_separate_debug_file): Fix search of debug files for
13038 2019-01-02 Tom Tromey <tom@tromey.com>
13040 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13042 * python/py-frame.c (frapy_older): Remove cast.
13043 (frapy_newer): Likewise.
13044 * python/py-breakpoint.c (local_setattro): Remove cast.
13045 * python/py-arch.c (archpy_name): Remove local variable.
13046 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13048 2019-01-02 Joel Brobecker <brobecker@adacore.com>
13050 * unittests/basic_string_view/element_access/char/empty.cc:
13051 Fix year range in copyright header.
13053 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13055 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13057 <operator==>: Update with for removed field.
13059 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13060 <isa_features>: ...this.
13061 <abi_features>: New field.
13062 (riscv_isa_flen): Update comment.
13063 (riscv_abi_xlen): New declaration.
13064 (riscv_abi_flen): New declaration.
13065 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13067 (riscv_abi_xlen): New function.
13068 (riscv_isa_flen): Update to get answer from isa_features.
13069 (riscv_abi_flen): New function.
13070 (riscv_has_fp_abi): Update to get answer from abi_features.
13071 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13073 (riscv_call_info) <xlen, flen>: Update comment.
13074 (riscv_call_arg_struct): Remove invalid assertions
13075 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13077 (riscv_gdbarch_init): Gather isa features and abi features
13078 separately, ensure both match on the gdbarch when reusing an old
13079 gdbarch. Relax an error check to allow 32-bit abi float to run on
13080 a target with 64-bit float hardware.
13082 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13084 * source.c (search_command_helper): Stop reverse search
13085 when line 1 has been searched.
13087 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13089 * record-full.c (record_full_base_target::close): Rewrite
13090 record_full_core_buf_list free logic.
13092 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13094 * break-catch-syscall.c (print_one_catch_syscall): xfree
13097 2019-01-01 Joel Brobecker <brobecker@adacore.com>
13099 * top.c (print_gdb_version): Update Copyright year in version
13102 2019-01-01 Joel Brobecker <brobecker@adacore.com>
13104 Update copyright year range in all GDB files.
13106 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
13108 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13110 For older changes see ChangeLog-2018.
13116 version-control: never